blob: ceefc0809a7b63b3145387199836e037b8443195 [file] [log] [blame]
Josip Sokcevic4de5dea2022-03-23 21:15:14 +00001#!/usr/bin/env python3
maruel@chromium.org3bbf2942012-01-10 16:52:06 +00002# Copyright (c) 2012 The Chromium Authors. All rights reserved.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00003# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5
6"""Enables directory-specific presubmit checks to run at upload and/or commit.
7"""
8
Raul Tambre80ee78e2019-05-06 22:41:05 +00009from __future__ import print_function
10
Saagar Sanghavi99816902020-08-11 22:41:25 +000011__version__ = '2.0.0'
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000012
13# TODO(joi) Add caching where appropriate/needed. The API is designed to allow
14# caching (between all different invocations of presubmit scripts for a given
15# change). We should add it as our presubmit scripts start feeling slow.
16
Edward Lemura5799e32020-01-17 19:26:51 +000017import argparse
Takeshi Yoshino07a6bea2017-08-02 02:44:06 +090018import ast # Exposed through the API.
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +000019import contextlib
Yoshisato Yanagisawa406de132018-06-29 05:43:25 +000020import cpplint
dcheng091b7db2016-06-16 01:27:51 -070021import fnmatch # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000022import glob
asvitkine@chromium.org15169952011-09-27 14:30:53 +000023import inspect
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +000024import itertools
maruel@chromium.org4f6852c2012-04-20 20:39:20 +000025import json # Exposed through the API.
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +000026import logging
ilevy@chromium.orgbc117312013-04-20 03:57:56 +000027import multiprocessing
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000028import os # Somewhat exposed through the API.
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +000029import random
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000030import re # Exposed through the API.
Edward Lesmes8e282792018-04-03 18:50:29 -040031import signal
Allen Webbfe7d7092021-05-18 02:05:49 +000032import six
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000033import sys # Parts exposed through API.
34import tempfile # Exposed through the API.
Edward Lesmes8e282792018-04-03 18:50:29 -040035import threading
jam@chromium.org2a891dc2009-08-20 20:33:37 +000036import time
Edward Lemurde9e3ca2019-10-24 21:13:31 +000037import traceback
maruel@chromium.org1487d532009-06-06 00:22:57 +000038import unittest # Exposed through the API.
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +000039from warnings import warn
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000040
41# Local imports.
maruel@chromium.org35625c72011-03-23 17:34:02 +000042import fix_encoding
Yoshisato Yanagisawa04600b42019-03-15 03:03:41 +000043import gclient_paths # Exposed through the API
44import gclient_utils
Aaron Gableb584c4f2017-04-26 16:28:08 -070045import git_footers
tandrii@chromium.org015ebae2016-04-25 19:37:22 +000046import gerrit_util
Edward Lesmes9ce03f82021-01-12 20:13:31 +000047import owners_client
Jochen Eisinger76f5fc62017-04-07 16:27:46 +020048import owners_finder
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000049import presubmit_canned_checks
Saagar Sanghavi9949ab72020-07-20 20:56:40 +000050import rdb_wrapper
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +000051import scm
maruel@chromium.org84f4fe32011-04-06 13:26:45 +000052import subprocess2 as subprocess # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000053
Edward Lemur16af3562019-10-17 22:11:33 +000054if sys.version_info.major == 2:
55 # TODO(1009814): Expose urllib2 only through urllib_request and urllib_error
56 import urllib2 # Exposed through the API.
57 import urlparse
58 import urllib2 as urllib_request
59 import urllib2 as urllib_error
60else:
61 import urllib.parse as urlparse
62 import urllib.request as urllib_request
63 import urllib.error as urllib_error
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000064
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +000065# Ask for feedback only once in program lifetime.
66_ASKED_FOR_FEEDBACK = False
67
Bruce Dawsondca14bc2022-09-15 20:59:38 +000068# Set if super-verbose mode is requested, for tracking where presubmit messages
69# are coming from.
70_SHOW_CALLSTACKS = False
71
72
Edward Lemurecc27072020-01-06 16:42:34 +000073def time_time():
74 # Use this so that it can be mocked in tests without interfering with python
75 # system machinery.
76 return time.time()
77
78
maruel@chromium.org899e1c12011-04-07 17:03:18 +000079class PresubmitFailure(Exception):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000080 pass
81
82
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000083class CommandData(object):
Edward Lemur940c2822019-08-23 00:34:25 +000084 def __init__(self, name, cmd, kwargs, message, python3=False):
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000085 self.name = name
86 self.cmd = cmd
Edward Lesmes8e282792018-04-03 18:50:29 -040087 self.stdin = kwargs.get('stdin', None)
Edward Lemur2d6b67c2019-08-23 22:25:41 +000088 self.kwargs = kwargs.copy()
Edward Lesmes8e282792018-04-03 18:50:29 -040089 self.kwargs['stdout'] = subprocess.PIPE
90 self.kwargs['stderr'] = subprocess.STDOUT
91 self.kwargs['stdin'] = subprocess.PIPE
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000092 self.message = message
93 self.info = None
Edward Lemur940c2822019-08-23 00:34:25 +000094 self.python3 = python3
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000095
ilevy@chromium.orgbc117312013-04-20 03:57:56 +000096
Edward Lesmes8e282792018-04-03 18:50:29 -040097# Adapted from
98# https://github.com/google/gtest-parallel/blob/master/gtest_parallel.py#L37
99#
100# An object that catches SIGINT sent to the Python process and notices
101# if processes passed to wait() die by SIGINT (we need to look for
102# both of those cases, because pressing Ctrl+C can result in either
103# the main process or one of the subprocesses getting the signal).
104#
105# Before a SIGINT is seen, wait(p) will simply call p.wait() and
106# return the result. Once a SIGINT has been seen (in the main process
107# or a subprocess, including the one the current call is waiting for),
Edward Lemur9a5bb612019-09-26 02:01:52 +0000108# wait(p) will call p.terminate().
Edward Lesmes8e282792018-04-03 18:50:29 -0400109class SigintHandler(object):
Edward Lesmes8e282792018-04-03 18:50:29 -0400110 sigint_returncodes = {-signal.SIGINT, # Unix
111 -1073741510, # Windows
112 }
113 def __init__(self):
114 self.__lock = threading.Lock()
115 self.__processes = set()
116 self.__got_sigint = False
Edward Lemur9a5bb612019-09-26 02:01:52 +0000117 self.__previous_signal = signal.signal(signal.SIGINT, self.interrupt)
Edward Lesmes8e282792018-04-03 18:50:29 -0400118
119 def __on_sigint(self):
120 self.__got_sigint = True
121 while self.__processes:
122 try:
123 self.__processes.pop().terminate()
124 except OSError:
125 pass
126
Edward Lemur9a5bb612019-09-26 02:01:52 +0000127 def interrupt(self, signal_num, frame):
Edward Lesmes8e282792018-04-03 18:50:29 -0400128 with self.__lock:
129 self.__on_sigint()
Edward Lemur9a5bb612019-09-26 02:01:52 +0000130 self.__previous_signal(signal_num, frame)
Edward Lesmes8e282792018-04-03 18:50:29 -0400131
132 def got_sigint(self):
133 with self.__lock:
134 return self.__got_sigint
135
136 def wait(self, p, stdin):
137 with self.__lock:
138 if self.__got_sigint:
139 p.terminate()
140 self.__processes.add(p)
141 stdout, stderr = p.communicate(stdin)
142 code = p.returncode
143 with self.__lock:
144 self.__processes.discard(p)
145 if code in self.sigint_returncodes:
146 self.__on_sigint()
Edward Lesmes8e282792018-04-03 18:50:29 -0400147 return stdout, stderr
148
149sigint_handler = SigintHandler()
150
151
Edward Lemurecc27072020-01-06 16:42:34 +0000152class Timer(object):
153 def __init__(self, timeout, fn):
154 self.completed = False
155 self._fn = fn
156 self._timer = threading.Timer(timeout, self._onTimer) if timeout else None
157
158 def __enter__(self):
159 if self._timer:
160 self._timer.start()
161 return self
162
163 def __exit__(self, _type, _value, _traceback):
164 if self._timer:
165 self._timer.cancel()
166
167 def _onTimer(self):
168 self._fn()
169 self.completed = True
170
171
Edward Lesmes8e282792018-04-03 18:50:29 -0400172class ThreadPool(object):
Edward Lemurecc27072020-01-06 16:42:34 +0000173 def __init__(self, pool_size=None, timeout=None):
174 self.timeout = timeout
Edward Lesmes8e282792018-04-03 18:50:29 -0400175 self._pool_size = pool_size or multiprocessing.cpu_count()
Bruce Dawson8254f062022-06-17 17:33:08 +0000176 if sys.platform == 'win32':
177 # TODO(crbug.com/1190269) - we can't use more than 56 child processes on
178 # Windows or Python3 may hang.
179 self._pool_size = min(self._pool_size, 56)
Edward Lesmes8e282792018-04-03 18:50:29 -0400180 self._messages = []
181 self._messages_lock = threading.Lock()
182 self._tests = []
183 self._tests_lock = threading.Lock()
184 self._nonparallel_tests = []
185
Edward Lemurecc27072020-01-06 16:42:34 +0000186 def _GetCommand(self, test):
Edward Lemur940c2822019-08-23 00:34:25 +0000187 vpython = 'vpython'
188 if test.python3:
189 vpython += '3'
190 if sys.platform == 'win32':
191 vpython += '.bat'
Edward Lesmes8e282792018-04-03 18:50:29 -0400192
193 cmd = test.cmd
194 if cmd[0] == 'python':
195 cmd = list(cmd)
196 cmd[0] = vpython
197 elif cmd[0].endswith('.py'):
198 cmd = [vpython] + cmd
199
Edward Lemur336e51f2019-11-14 21:42:04 +0000200 # On Windows, scripts on the current directory take precedence over PATH, so
201 # that when testing depot_tools on Windows, calling `vpython.bat` will
202 # execute the copy of vpython of the depot_tools under test instead of the
203 # one in the bot.
204 # As a workaround, we run the tests from the parent directory instead.
205 if (cmd[0] == vpython and
206 'cwd' in test.kwargs and
207 os.path.basename(test.kwargs['cwd']) == 'depot_tools'):
208 test.kwargs['cwd'] = os.path.dirname(test.kwargs['cwd'])
209 cmd[1] = os.path.join('depot_tools', cmd[1])
210
Edward Lemurecc27072020-01-06 16:42:34 +0000211 return cmd
212
213 def _RunWithTimeout(self, cmd, stdin, kwargs):
214 p = subprocess.Popen(cmd, **kwargs)
215 with Timer(self.timeout, p.terminate) as timer:
216 stdout, _ = sigint_handler.wait(p, stdin)
Josip Sokcevic6635baf2021-11-19 02:04:39 +0000217 stdout = stdout.decode('utf-8', 'ignore')
Edward Lemurecc27072020-01-06 16:42:34 +0000218 if timer.completed:
219 stdout = 'Process timed out after %ss\n%s' % (self.timeout, stdout)
Josip Sokcevic6635baf2021-11-19 02:04:39 +0000220 return p.returncode, stdout
Edward Lemurecc27072020-01-06 16:42:34 +0000221
222 def CallCommand(self, test):
223 """Runs an external program.
224
Edward Lemura5799e32020-01-17 19:26:51 +0000225 This function converts invocation of .py files and invocations of 'python'
Edward Lemurecc27072020-01-06 16:42:34 +0000226 to vpython invocations.
227 """
228 cmd = self._GetCommand(test)
Edward Lesmes8e282792018-04-03 18:50:29 -0400229 try:
Edward Lemurecc27072020-01-06 16:42:34 +0000230 start = time_time()
231 returncode, stdout = self._RunWithTimeout(cmd, test.stdin, test.kwargs)
232 duration = time_time() - start
Edward Lemur7cf94382019-11-15 22:36:41 +0000233 except Exception:
Edward Lemurecc27072020-01-06 16:42:34 +0000234 duration = time_time() - start
Edward Lesmes8e282792018-04-03 18:50:29 -0400235 return test.message(
Edward Lemur7cf94382019-11-15 22:36:41 +0000236 '%s\n%s exec failure (%4.2fs)\n%s' % (
237 test.name, ' '.join(cmd), duration, traceback.format_exc()))
Edward Lemurde9e3ca2019-10-24 21:13:31 +0000238
Edward Lemurecc27072020-01-06 16:42:34 +0000239 if returncode != 0:
Edward Lesmes8e282792018-04-03 18:50:29 -0400240 return test.message(
Edward Lemur7cf94382019-11-15 22:36:41 +0000241 '%s\n%s (%4.2fs) failed\n%s' % (
242 test.name, ' '.join(cmd), duration, stdout))
Edward Lemurecc27072020-01-06 16:42:34 +0000243
Edward Lesmes8e282792018-04-03 18:50:29 -0400244 if test.info:
Edward Lemur7cf94382019-11-15 22:36:41 +0000245 return test.info('%s\n%s (%4.2fs)' % (test.name, ' '.join(cmd), duration))
Edward Lesmes8e282792018-04-03 18:50:29 -0400246
247 def AddTests(self, tests, parallel=True):
248 if parallel:
249 self._tests.extend(tests)
250 else:
251 self._nonparallel_tests.extend(tests)
252
253 def RunAsync(self):
254 self._messages = []
255
256 def _WorkerFn():
257 while True:
258 test = None
259 with self._tests_lock:
260 if not self._tests:
261 break
262 test = self._tests.pop()
263 result = self.CallCommand(test)
264 if result:
265 with self._messages_lock:
266 self._messages.append(result)
267
268 def _StartDaemon():
269 t = threading.Thread(target=_WorkerFn)
270 t.daemon = True
271 t.start()
272 return t
273
274 while self._nonparallel_tests:
275 test = self._nonparallel_tests.pop()
276 result = self.CallCommand(test)
277 if result:
278 self._messages.append(result)
279
280 if self._tests:
281 threads = [_StartDaemon() for _ in range(self._pool_size)]
282 for worker in threads:
283 worker.join()
284
285 return self._messages
286
287
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000288def normpath(path):
289 '''Version of os.path.normpath that also changes backward slashes to
290 forward slashes when not running on Windows.
291 '''
292 # This is safe to always do because the Windows version of os.path.normpath
293 # will replace forward slashes with backward slashes.
294 path = path.replace(os.sep, '/')
295 return os.path.normpath(path)
296
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000297
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000298def _RightHandSideLinesImpl(affected_files):
299 """Implements RightHandSideLines for InputApi and GclChange."""
300 for af in affected_files:
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000301 lines = af.ChangedContents()
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000302 for line in lines:
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000303 yield (af, line[0], line[1])
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000304
305
Edward Lemur6eb1d322020-02-27 22:20:15 +0000306def prompt_should_continue(prompt_string):
307 sys.stdout.write(prompt_string)
Dirk Pranke7288f882021-06-03 18:01:30 +0000308 sys.stdout.flush()
Edward Lemur6eb1d322020-02-27 22:20:15 +0000309 response = sys.stdin.readline().strip().lower()
310 return response in ('y', 'yes')
dpranke@chromium.org5ac21012011-03-16 02:58:25 +0000311
312
Josip Sokcevice293d3d2022-02-16 22:52:15 +0000313def _ShouldRunPresubmit(script_text, use_python3):
314 """Try to figure out whether these presubmit checks should be run under
315 python2 or python3. We need to do this without actually trying to
316 compile the text, since the text might compile in one but not the
317 other.
318
319 Args:
320 script_text: The text of the presubmit script.
321 use_python3: if true, will use python3 instead of python2 by default
322 if USE_PYTHON3 is not specified.
323
324 Return:
325 A boolean if presubmit should be executed
326 """
327 m = re.search('^USE_PYTHON3 = (True|False)$', script_text, flags=re.MULTILINE)
328 if m:
329 use_python3 = m.group(1) == 'True'
330
331 return ((sys.version_info.major == 2) and not use_python3) or \
332 ((sys.version_info.major == 3) and use_python3)
333
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000334# Top level object so multiprocessing can pickle
335# Public access through OutputApi object.
336class _PresubmitResult(object):
337 """Base class for result objects."""
338 fatal = False
339 should_prompt = False
340
341 def __init__(self, message, items=None, long_text=''):
342 """
343 message: A short one-line message to indicate errors.
344 items: A list of short strings to indicate where errors occurred.
345 long_text: multi-line text output, e.g. from another tool
346 """
Bruce Dawsondb8622b2022-04-03 15:38:12 +0000347 self._message = _PresubmitResult._ensure_str(message)
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000348 self._items = items or []
Tom McKee61c72652021-07-20 11:56:32 +0000349 self._long_text = _PresubmitResult._ensure_str(long_text.rstrip())
Bruce Dawsondca14bc2022-09-15 20:59:38 +0000350 if _SHOW_CALLSTACKS:
351 self._long_text += 'Presubmit result call stack is:\n'
352 self._long_text += ''.join(traceback.format_stack(None, 8))
Tom McKee61c72652021-07-20 11:56:32 +0000353
354 @staticmethod
355 def _ensure_str(val):
356 """
357 val: A "stringish" value. Can be any of str, unicode or bytes.
358 returns: A str after applying encoding/decoding as needed.
359 Assumes/uses UTF-8 for relevant inputs/outputs.
360
361 We'd prefer to use six.ensure_str but our copy of six is old :(
362 """
363 if isinstance(val, str):
364 return val
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +0000365
Tom McKee61c72652021-07-20 11:56:32 +0000366 if six.PY2 and isinstance(val, unicode):
367 return val.encode()
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +0000368
369 if six.PY3 and isinstance(val, bytes):
Tom McKee61c72652021-07-20 11:56:32 +0000370 return val.decode()
371 raise ValueError("Unknown string type %s" % type(val))
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000372
Edward Lemur6eb1d322020-02-27 22:20:15 +0000373 def handle(self):
374 sys.stdout.write(self._message)
375 sys.stdout.write('\n')
Takuto Ikutabaa7be02022-08-23 00:19:34 +0000376 for item in self._items:
Edward Lemur6eb1d322020-02-27 22:20:15 +0000377 sys.stdout.write(' ')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000378 # Write separately in case it's unicode.
Edward Lemur6eb1d322020-02-27 22:20:15 +0000379 sys.stdout.write(str(item))
Edward Lemur6eb1d322020-02-27 22:20:15 +0000380 sys.stdout.write('\n')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000381 if self._long_text:
Edward Lemur6eb1d322020-02-27 22:20:15 +0000382 sys.stdout.write('\n***************\n')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000383 # Write separately in case it's unicode.
Tom McKee61c72652021-07-20 11:56:32 +0000384 sys.stdout.write(self._long_text)
Edward Lemur6eb1d322020-02-27 22:20:15 +0000385 sys.stdout.write('\n***************\n')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000386
Debrian Figueroadd2737e2019-06-21 23:50:13 +0000387 def json_format(self):
388 return {
389 'message': self._message,
Debrian Figueroa6095d402019-06-28 18:47:18 +0000390 'items': [str(item) for item in self._items],
Debrian Figueroadd2737e2019-06-21 23:50:13 +0000391 'long_text': self._long_text,
392 'fatal': self.fatal
393 }
394
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000395
396# Top level object so multiprocessing can pickle
397# Public access through OutputApi object.
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000398class _PresubmitError(_PresubmitResult):
399 """A hard presubmit error."""
400 fatal = True
401
402
403# Top level object so multiprocessing can pickle
404# Public access through OutputApi object.
405class _PresubmitPromptWarning(_PresubmitResult):
406 """An warning that prompts the user if they want to continue."""
407 should_prompt = True
408
409
410# Top level object so multiprocessing can pickle
411# Public access through OutputApi object.
412class _PresubmitNotifyResult(_PresubmitResult):
413 """Just print something to the screen -- but it's not even a warning."""
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000414
415
416# Top level object so multiprocessing can pickle
417# Public access through OutputApi object.
418class _MailTextResult(_PresubmitResult):
419 """A warning that should be included in the review request email."""
420 def __init__(self, *args, **kwargs):
421 super(_MailTextResult, self).__init__()
422 raise NotImplementedError()
423
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000424class GerritAccessor(object):
425 """Limited Gerrit functionality for canned presubmit checks to work.
426
427 To avoid excessive Gerrit calls, caches the results.
428 """
429
Edward Lesmeseb1bd622021-03-01 19:54:07 +0000430 def __init__(self, url=None, project=None, branch=None):
431 self.host = urlparse.urlparse(url).netloc if url else None
432 self.project = project
433 self.branch = branch
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000434 self.cache = {}
Edward Lesmes8170c292021-03-19 20:04:43 +0000435 self.code_owners_enabled = None
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000436
437 def _FetchChangeDetail(self, issue):
438 # Separate function to be easily mocked in tests.
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +0100439 try:
440 return gerrit_util.GetChangeDetail(
441 self.host, str(issue),
Aaron Gable6f5a8d92017-04-18 14:49:05 -0700442 ['ALL_REVISIONS', 'DETAILED_LABELS', 'ALL_COMMITS'])
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +0100443 except gerrit_util.GerritError as e:
444 if e.http_status == 404:
445 raise Exception('Either Gerrit issue %s doesn\'t exist, or '
446 'no credentials to fetch issue details' % issue)
447 raise
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000448
449 def GetChangeInfo(self, issue):
450 """Returns labels and all revisions (patchsets) for this issue.
451
452 The result is a dictionary according to Gerrit REST Api.
453 https://gerrit-review.googlesource.com/Documentation/rest-api.html
454
455 However, API isn't very clear what's inside, so see tests for example.
456 """
457 assert issue
458 cache_key = int(issue)
459 if cache_key not in self.cache:
460 self.cache[cache_key] = self._FetchChangeDetail(issue)
461 return self.cache[cache_key]
462
463 def GetChangeDescription(self, issue, patchset=None):
464 """If patchset is none, fetches current patchset."""
465 info = self.GetChangeInfo(issue)
466 # info is a reference to cache. We'll modify it here adding description to
467 # it to the right patchset, if it is not yet there.
468
469 # Find revision info for the patchset we want.
470 if patchset is not None:
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +0000471 for rev, rev_info in info['revisions'].items():
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000472 if str(rev_info['_number']) == str(patchset):
473 break
474 else:
475 raise Exception('patchset %s doesn\'t exist in issue %s' % (
476 patchset, issue))
477 else:
478 rev = info['current_revision']
479 rev_info = info['revisions'][rev]
480
Andrii Shyshkalov9c3a4642017-01-24 17:41:22 +0100481 return rev_info['commit']['message']
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000482
Mun Yong Jang603d01e2017-12-19 16:38:30 -0800483 def GetDestRef(self, issue):
484 ref = self.GetChangeInfo(issue)['branch']
485 if not ref.startswith('refs/'):
486 # NOTE: it is possible to create 'refs/x' branch,
487 # aka 'refs/heads/refs/x'. However, this is ill-advised.
488 ref = 'refs/heads/%s' % ref
489 return ref
490
Edward Lesmes02d4b822020-11-11 00:37:35 +0000491 def _GetApproversForLabel(self, issue, label):
492 change_info = self.GetChangeInfo(issue)
493 label_info = change_info.get('labels', {}).get(label, {})
494 values = label_info.get('values', {}).keys()
495 if not values:
496 return []
497 max_value = max(int(v) for v in values)
498 return [v for v in label_info.get('all', [])
499 if v.get('value', 0) == max_value]
500
Edward Lesmesc4566172021-03-19 16:55:13 +0000501 def IsBotCommitApproved(self, issue):
502 return bool(self._GetApproversForLabel(issue, 'Bot-Commit'))
503
Edward Lesmescf49cb82020-11-11 01:08:36 +0000504 def IsOwnersOverrideApproved(self, issue):
505 return bool(self._GetApproversForLabel(issue, 'Owners-Override'))
506
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000507 def GetChangeOwner(self, issue):
508 return self.GetChangeInfo(issue)['owner']['email']
509
510 def GetChangeReviewers(self, issue, approving_only=True):
Aaron Gable8b478f02017-07-31 15:33:19 -0700511 changeinfo = self.GetChangeInfo(issue)
512 if approving_only:
Edward Lesmes02d4b822020-11-11 00:37:35 +0000513 reviewers = self._GetApproversForLabel(issue, 'Code-Review')
Aaron Gable8b478f02017-07-31 15:33:19 -0700514 else:
515 reviewers = changeinfo.get('reviewers', {}).get('REVIEWER', [])
516 return [r.get('email') for r in reviewers]
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000517
Edward Lemure4d329c2020-02-03 20:41:18 +0000518 def UpdateDescription(self, description, issue):
519 gerrit_util.SetCommitMessage(self.host, issue, description, notify='NONE')
520
Edward Lesmes8170c292021-03-19 20:04:43 +0000521 def IsCodeOwnersEnabledOnRepo(self):
522 if self.code_owners_enabled is None:
523 self.code_owners_enabled = gerrit_util.IsCodeOwnersEnabledOnRepo(
Edward Lesmes392c4072021-03-19 21:58:45 +0000524 self.host, self.project)
Edward Lesmes8170c292021-03-19 20:04:43 +0000525 return self.code_owners_enabled
526
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000527
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000528class OutputApi(object):
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000529 """An instance of OutputApi gets passed to presubmit scripts so that they
530 can output various types of results.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000531 """
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000532 PresubmitResult = _PresubmitResult
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000533 PresubmitError = _PresubmitError
534 PresubmitPromptWarning = _PresubmitPromptWarning
535 PresubmitNotifyResult = _PresubmitNotifyResult
536 MailTextResult = _MailTextResult
537
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000538 def __init__(self, is_committing):
539 self.is_committing = is_committing
Daniel Cheng7227d212017-11-17 08:12:37 -0800540 self.more_cc = []
541
542 def AppendCC(self, cc):
543 """Appends a user to cc for this change."""
Daniel Cheng0e9f6682022-10-19 17:42:57 +0000544 if cc not in self.more_cc:
545 self.more_cc.append(cc)
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000546
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000547 def PresubmitPromptOrNotify(self, *args, **kwargs):
548 """Warn the user when uploading, but only notify if committing."""
549 if self.is_committing:
550 return self.PresubmitNotifyResult(*args, **kwargs)
551 return self.PresubmitPromptWarning(*args, **kwargs)
552
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000553
554class InputApi(object):
555 """An instance of this object is passed to presubmit scripts so they can
556 know stuff about the change they're looking at.
557 """
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000558 # Method could be a function
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800559 # pylint: disable=no-self-use
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000560
maruel@chromium.org3410d912009-06-09 20:56:16 +0000561 # File extensions that are considered source files from a style guide
562 # perspective. Don't modify this list from a presubmit script!
maruel@chromium.orgc33455a2011-06-24 19:14:18 +0000563 #
564 # Files without an extension aren't included in the list. If you want to
local_bot30f774e2020-06-25 18:23:34 +0000565 # filter them as source files, add r'(^|.*?[\\\/])[^.]+$' to the allow list.
local_bot64021412020-07-08 21:05:39 +0000566 # Note that ALL CAPS files are skipped in DEFAULT_FILES_TO_SKIP below.
567 DEFAULT_FILES_TO_CHECK = (
maruel@chromium.org3410d912009-06-09 20:56:16 +0000568 # C++ and friends
Edward Lemura5799e32020-01-17 19:26:51 +0000569 r'.+\.c$', r'.+\.cc$', r'.+\.cpp$', r'.+\.h$', r'.+\.m$', r'.+\.mm$',
570 r'.+\.inl$', r'.+\.asm$', r'.+\.hxx$', r'.+\.hpp$', r'.+\.s$', r'.+\.S$',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000571 # Scripts
dpapad443d9132022-05-05 00:17:30 +0000572 r'.+\.js$', r'.+\.ts$', r'.+\.py$', r'.+\.sh$', r'.+\.rb$', r'.+\.pl$',
573 r'.+\.pm$',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000574 # Other
Edward Lemura5799e32020-01-17 19:26:51 +0000575 r'.+\.java$', r'.+\.mk$', r'.+\.am$', r'.+\.css$', r'.+\.mojom$',
576 r'.+\.fidl$'
maruel@chromium.org3410d912009-06-09 20:56:16 +0000577 )
578
579 # Path regexp that should be excluded from being considered containing source
580 # files. Don't modify this list from a presubmit script!
local_bot64021412020-07-08 21:05:39 +0000581 DEFAULT_FILES_TO_SKIP = (
Edward Lemura5799e32020-01-17 19:26:51 +0000582 r'testing_support[\\\/]google_appengine[\\\/].*',
583 r'.*\bexperimental[\\\/].*',
Kent Tamura179dd1e2018-04-26 15:07:41 +0900584 # Exclude third_party/.* but NOT third_party/{WebKit,blink}
585 # (crbug.com/539768 and crbug.com/836555).
Edward Lemura5799e32020-01-17 19:26:51 +0000586 r'.*\bthird_party[\\\/](?!(WebKit|blink)[\\\/]).*',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000587 # Output directories (just in case)
Edward Lemura5799e32020-01-17 19:26:51 +0000588 r'.*\bDebug[\\\/].*',
589 r'.*\bRelease[\\\/].*',
590 r'.*\bxcodebuild[\\\/].*',
591 r'.*\bout[\\\/].*',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000592 # All caps files like README and LICENCE.
Edward Lemura5799e32020-01-17 19:26:51 +0000593 r'.*\b[A-Z0-9_]{2,}$',
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +0000594 # SCM (can happen in dual SCM configuration). (Slightly over aggressive)
Edward Lemura5799e32020-01-17 19:26:51 +0000595 r'(|.*[\\\/])\.git[\\\/].*',
596 r'(|.*[\\\/])\.svn[\\\/].*',
maruel@chromium.org7ccb4bb2011-11-07 20:26:20 +0000597 # There is no point in processing a patch file.
Edward Lemura5799e32020-01-17 19:26:51 +0000598 r'.+\.diff$',
599 r'.+\.patch$',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000600 )
601
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000602 def __init__(self, change, presubmit_path, is_committing,
Bruce Dawson09c0c072022-05-26 20:28:58 +0000603 verbose, gerrit_obj, dry_run=None, thread_pool=None, parallel=False,
604 no_diffs=False):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000605 """Builds an InputApi object.
606
607 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000608 change: A presubmit.Change object.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000609 presubmit_path: The path to the presubmit script being processed.
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000610 is_committing: True if the change is about to be committed.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000611 gerrit_obj: provides basic Gerrit codereview functionality.
612 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -0400613 parallel: if true, all tests reported via input_api.RunTests for all
614 PRESUBMIT files will be run in parallel.
Bruce Dawson09c0c072022-05-26 20:28:58 +0000615 no_diffs: if true, implies that --files or --all was specified so some
616 checks can be skipped, and some errors will be messages.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000617 """
maruel@chromium.org9711bba2009-05-22 23:51:39 +0000618 # Version number of the presubmit_support script.
619 self.version = [int(x) for x in __version__.split('.')]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000620 self.change = change
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000621 self.is_committing = is_committing
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000622 self.gerrit = gerrit_obj
tandrii@chromium.org57bafac2016-04-28 05:09:03 +0000623 self.dry_run = dry_run
Bruce Dawson09c0c072022-05-26 20:28:58 +0000624 self.no_diffs = no_diffs
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000625
Edward Lesmes8e282792018-04-03 18:50:29 -0400626 self.parallel = parallel
627 self.thread_pool = thread_pool or ThreadPool()
628
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000629 # We expose various modules and functions as attributes of the input_api
630 # so that presubmit scripts don't have to import them.
Takeshi Yoshino07a6bea2017-08-02 02:44:06 +0900631 self.ast = ast
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000632 self.basename = os.path.basename
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000633 self.cpplint = cpplint
dcheng091b7db2016-06-16 01:27:51 -0700634 self.fnmatch = fnmatch
Yoshisato Yanagisawa04600b42019-03-15 03:03:41 +0000635 self.gclient_paths = gclient_paths
Yoshisato Yanagisawa57dd17b2019-03-22 09:10:29 +0000636 # TODO(yyanagisawa): stop exposing this when python3 become default.
637 # Since python3's tempfile has TemporaryDirectory, we do not need this.
638 self.temporary_directory = gclient_utils.temporary_directory
dpranke@chromium.org17cc2442012-10-17 21:12:09 +0000639 self.glob = glob.glob
maruel@chromium.orgfb11c7b2010-03-18 18:22:14 +0000640 self.json = json
maruel@chromium.org6fba34d2011-06-02 13:45:12 +0000641 self.logging = logging.getLogger('PRESUBMIT')
maruel@chromium.org2b5ce562011-03-31 16:15:44 +0000642 self.os_listdir = os.listdir
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000643 self.os_path = os.path
pgervais@chromium.orgbd0cace2014-10-02 23:23:46 +0000644 self.os_stat = os.stat
Yoshisato Yanagisawa406de132018-06-29 05:43:25 +0000645 self.os_walk = os.walk
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000646 self.re = re
647 self.subprocess = subprocess
Edward Lemurb9830242019-10-30 22:19:20 +0000648 self.sys = sys
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000649 self.tempfile = tempfile
dpranke@chromium.org0d1bdea2011-03-24 22:54:38 +0000650 self.time = time
maruel@chromium.org1487d532009-06-06 00:22:57 +0000651 self.unittest = unittest
Edward Lemurb9830242019-10-30 22:19:20 +0000652 if sys.version_info.major == 2:
653 self.urllib2 = urllib2
Edward Lemur16af3562019-10-17 22:11:33 +0000654 self.urllib_request = urllib_request
655 self.urllib_error = urllib_error
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000656
Robert Iannucci50258932018-03-19 10:30:59 -0700657 self.is_windows = sys.platform == 'win32'
658
Edward Lemurb9646622019-10-25 20:57:35 +0000659 # Set python_executable to 'vpython' in order to allow scripts in other
660 # repos (e.g. src.git) to automatically pick up that repo's .vpython file,
661 # instead of inheriting the one in depot_tools.
662 self.python_executable = 'vpython'
Erik Staab69135d12021-05-14 22:31:57 +0000663 # Offer a python 3 executable for use during the migration off of python 2.
664 self.python3_executable = 'vpython3'
maruel@chromium.orgc0b22972009-06-25 16:19:14 +0000665 self.environ = os.environ
666
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000667 # InputApi.platform is the platform you're currently running on.
668 self.platform = sys.platform
669
iannucci@chromium.org0af3bb32015-06-12 20:44:35 +0000670 self.cpu_count = multiprocessing.cpu_count()
Bruce Dawson8254f062022-06-17 17:33:08 +0000671 if self.is_windows:
672 # TODO(crbug.com/1190269) - we can't use more than 56 child processes on
673 # Windows or Python3 may hang.
674 self.cpu_count = min(self.cpu_count, 56)
iannucci@chromium.org0af3bb32015-06-12 20:44:35 +0000675
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000676 # The local path of the currently-being-processed presubmit script.
maruel@chromium.org3d235242009-05-15 12:40:48 +0000677 self._current_presubmit_path = os.path.dirname(presubmit_path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000678
679 # We carry the canned checks so presubmit scripts can easily use them.
680 self.canned_checks = presubmit_canned_checks
681
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +0100682 # Temporary files we must manually remove at the end of a run.
683 self._named_temporary_files = []
Jochen Eisinger72606f82017-04-04 10:44:18 +0200684
Edward Lesmesdc11c6b2021-03-19 19:22:05 +0000685 self.owners_client = None
Bruce Dawsoneb8426e2022-08-05 23:58:15 +0000686 if self.gerrit and not 'PRESUBMIT_SKIP_NETWORK' in self.environ:
Bruce Dawson9b9f4512022-04-27 00:56:52 +0000687 try:
688 self.owners_client = owners_client.GetCodeOwnersClient(
Bruce Dawson9b9f4512022-04-27 00:56:52 +0000689 host=self.gerrit.host,
690 project=self.gerrit.project,
691 branch=self.gerrit.branch)
692 except Exception as e:
693 print('Failed to set owners_client - %s' % str(e))
Jochen Eisinger76f5fc62017-04-07 16:27:46 +0200694 self.owners_finder = owners_finder.OwnersFinder
maruel@chromium.org899e1c12011-04-07 17:03:18 +0000695 self.verbose = verbose
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000696 self.Command = CommandData
dpranke@chromium.org2a009622011-03-01 02:43:31 +0000697
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000698 # Replace <hash_map> and <hash_set> as headers that need to be included
Edward Lemura5799e32020-01-17 19:26:51 +0000699 # with 'base/containers/hash_tables.h' instead.
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000700 # Access to a protected member _XX of a client class
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800701 # pylint: disable=protected-access
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000702 self.cpplint._re_pattern_templates = [
danakj@chromium.org18278522013-06-11 22:42:32 +0000703 (a, b, 'base/containers/hash_tables.h')
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000704 if header in ('<hash_map>', '<hash_set>') else (a, b, header)
705 for (a, b, header) in cpplint._re_pattern_templates
706 ]
707
Edward Lemurecc27072020-01-06 16:42:34 +0000708 def SetTimeout(self, timeout):
709 self.thread_pool.timeout = timeout
710
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000711 def PresubmitLocalPath(self):
712 """Returns the local path of the presubmit script currently being run.
713
714 This is useful if you don't want to hard-code absolute paths in the
715 presubmit script. For example, It can be used to find another file
716 relative to the PRESUBMIT.py script, so the whole tree can be branched and
717 the presubmit script still works, without editing its content.
718 """
maruel@chromium.org3d235242009-05-15 12:40:48 +0000719 return self._current_presubmit_path
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000720
agable0b65e732016-11-22 09:25:46 -0800721 def AffectedFiles(self, include_deletes=True, file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000722 """Same as input_api.change.AffectedFiles() except only lists files
723 (and optionally directories) in the same directory as the current presubmit
Bruce Dawson7a0b07a2020-04-23 17:14:40 +0000724 script, or subdirectories thereof. Note that files are listed using the OS
725 path separator, so backslashes are used as separators on Windows.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000726 """
Bruce Dawson31bfd512022-05-10 23:19:39 +0000727 dir_with_slash = normpath(self.PresubmitLocalPath())
728 # normpath strips trailing path separators, so the trailing separator has to
729 # be added after the normpath call.
730 if len(dir_with_slash) > 0:
731 dir_with_slash += os.path.sep
sail@chromium.org5538e022011-05-12 17:53:16 +0000732
Edward Lemurb9830242019-10-30 22:19:20 +0000733 return list(filter(
maruel@chromium.org4661e0c2009-06-04 00:45:26 +0000734 lambda x: normpath(x.AbsoluteLocalPath()).startswith(dir_with_slash),
Edward Lemurb9830242019-10-30 22:19:20 +0000735 self.change.AffectedFiles(include_deletes, file_filter)))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000736
agable0b65e732016-11-22 09:25:46 -0800737 def LocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000738 """Returns local paths of input_api.AffectedFiles()."""
agable0b65e732016-11-22 09:25:46 -0800739 paths = [af.LocalPath() for af in self.AffectedFiles()]
Edward Lemura5799e32020-01-17 19:26:51 +0000740 logging.debug('LocalPaths: %s', paths)
pgervais@chromium.org2f64f782014-04-25 00:12:33 +0000741 return paths
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000742
agable0b65e732016-11-22 09:25:46 -0800743 def AbsoluteLocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000744 """Returns absolute local paths of input_api.AffectedFiles()."""
agable0b65e732016-11-22 09:25:46 -0800745 return [af.AbsoluteLocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000746
John Budorick16162372018-04-18 10:39:53 -0700747 def AffectedTestableFiles(self, include_deletes=None, **kwargs):
agable0b65e732016-11-22 09:25:46 -0800748 """Same as input_api.change.AffectedTestableFiles() except only lists files
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000749 in the same directory as the current presubmit script, or subdirectories
750 thereof.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000751 """
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000752 if include_deletes is not None:
Edward Lemura5799e32020-01-17 19:26:51 +0000753 warn('AffectedTestableFiles(include_deletes=%s)'
754 ' is deprecated and ignored' % str(include_deletes),
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000755 category=DeprecationWarning,
756 stacklevel=2)
Josip Sokcevic4de5dea2022-03-23 21:15:14 +0000757 # pylint: disable=consider-using-generator
758 return [
759 x for x in self.AffectedFiles(include_deletes=False, **kwargs)
760 if x.IsTestableFile()
761 ]
agable0b65e732016-11-22 09:25:46 -0800762
763 def AffectedTextFiles(self, include_deletes=None):
764 """An alias to AffectedTestableFiles for backwards compatibility."""
765 return self.AffectedTestableFiles(include_deletes=include_deletes)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000766
Josip Sokcevic8c955952021-02-01 21:32:57 +0000767 def FilterSourceFile(self,
768 affected_file,
769 files_to_check=None,
770 files_to_skip=None,
771 allow_list=None,
772 block_list=None):
Edward Lemura5799e32020-01-17 19:26:51 +0000773 """Filters out files that aren't considered 'source file'.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000774
local_bot64021412020-07-08 21:05:39 +0000775 If files_to_check or files_to_skip is None, InputApi.DEFAULT_FILES_TO_CHECK
776 and InputApi.DEFAULT_FILES_TO_SKIP is used respectively.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000777
Bruce Dawson635383f2022-09-13 16:23:18 +0000778 affected_file.LocalPath() needs to re.match an entry in the files_to_check
779 list and not re.match any entries in the files_to_skip list.
780 '/' path separators should be used in the regular expressions and will work
781 on Windows as well as other platforms.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000782
783 Note: Copy-paste this function to suit your needs or use a lambda function.
784 """
local_bot64021412020-07-08 21:05:39 +0000785 if files_to_check is None:
786 files_to_check = self.DEFAULT_FILES_TO_CHECK
787 if files_to_skip is None:
788 files_to_skip = self.DEFAULT_FILES_TO_SKIP
local_bot30f774e2020-06-25 18:23:34 +0000789
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000790 def Find(affected_file, items):
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000791 local_path = affected_file.LocalPath()
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000792 for item in items:
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +0000793 if self.re.match(item, local_path):
maruel@chromium.org3410d912009-06-09 20:56:16 +0000794 return True
Bruce Dawsona3a014e2022-04-27 23:28:17 +0000795 # Handle the cases where the files regex only handles /, but the local
796 # path uses \.
797 if self.is_windows and self.re.match(item, local_path.replace(
798 '\\', '/')):
799 return True
maruel@chromium.org3410d912009-06-09 20:56:16 +0000800 return False
local_bot64021412020-07-08 21:05:39 +0000801 return (Find(affected_file, files_to_check) and
802 not Find(affected_file, files_to_skip))
maruel@chromium.org3410d912009-06-09 20:56:16 +0000803
804 def AffectedSourceFiles(self, source_file):
agable0b65e732016-11-22 09:25:46 -0800805 """Filter the list of AffectedTestableFiles by the function source_file.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000806
807 If source_file is None, InputApi.FilterSourceFile() is used.
808 """
809 if not source_file:
810 source_file = self.FilterSourceFile
Edward Lemurb9830242019-10-30 22:19:20 +0000811 return list(filter(source_file, self.AffectedTestableFiles()))
maruel@chromium.org3410d912009-06-09 20:56:16 +0000812
813 def RightHandSideLines(self, source_file_filter=None):
Edward Lemura5799e32020-01-17 19:26:51 +0000814 """An iterator over all text lines in 'new' version of changed files.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000815
816 Only lists lines from new or modified text files in the change that are
817 contained by the directory of the currently executing presubmit script.
818
819 This is useful for doing line-by-line regex checks, like checking for
820 trailing whitespace.
821
822 Yields:
823 a 3 tuple:
824 the AffectedFile instance of the current file;
825 integer line number (1-based); and
826 the contents of the line as a string.
maruel@chromium.org1487d532009-06-06 00:22:57 +0000827
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000828 Note: The carriage return (LF or CR) is stripped off.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000829 """
maruel@chromium.org3410d912009-06-09 20:56:16 +0000830 files = self.AffectedSourceFiles(source_file_filter)
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000831 return _RightHandSideLinesImpl(files)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000832
maruel@chromium.orge3608df2009-11-10 20:22:57 +0000833 def ReadFile(self, file_item, mode='r'):
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000834 """Reads an arbitrary file.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000835
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000836 Deny reading anything outside the repository.
837 """
maruel@chromium.orge3608df2009-11-10 20:22:57 +0000838 if isinstance(file_item, AffectedFile):
839 file_item = file_item.AbsoluteLocalPath()
840 if not file_item.startswith(self.change.RepositoryRoot()):
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000841 raise IOError('Access outside the repository root is denied.')
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +0000842 return gclient_utils.FileRead(file_item, mode)
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000843
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +0100844 def CreateTemporaryFile(self, **kwargs):
845 """Returns a named temporary file that must be removed with a call to
846 RemoveTemporaryFiles().
847
848 All keyword arguments are forwarded to tempfile.NamedTemporaryFile(),
849 except for |delete|, which is always set to False.
850
851 Presubmit checks that need to create a temporary file and pass it for
852 reading should use this function instead of NamedTemporaryFile(), as
853 Windows fails to open a file that is already open for writing.
854
855 with input_api.CreateTemporaryFile() as f:
856 f.write('xyz')
857 f.close()
858 input_api.subprocess.check_output(['script-that', '--reads-from',
859 f.name])
860
861
862 Note that callers of CreateTemporaryFile() should not worry about removing
863 any temporary file; this is done transparently by the presubmit handling
864 code.
865 """
866 if 'delete' in kwargs:
867 # Prevent users from passing |delete|; we take care of file deletion
868 # ourselves and this prevents unintuitive error messages when we pass
869 # delete=False and 'delete' is also in kwargs.
870 raise TypeError('CreateTemporaryFile() does not take a "delete" '
871 'argument, file deletion is handled automatically by '
872 'the same presubmit_support code that creates InputApi '
873 'objects.')
874 temp_file = self.tempfile.NamedTemporaryFile(delete=False, **kwargs)
875 self._named_temporary_files.append(temp_file.name)
876 return temp_file
877
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000878 @property
879 def tbr(self):
880 """Returns if a change is TBR'ed."""
Jeremy Romandce22502017-06-20 15:37:29 -0400881 return 'TBR' in self.change.tags or self.change.TBRsFromDescription()
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000882
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +0000883 def RunTests(self, tests_mix, parallel=True):
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000884 tests = []
885 msgs = []
886 for t in tests_mix:
Edward Lesmes8e282792018-04-03 18:50:29 -0400887 if isinstance(t, OutputApi.PresubmitResult) and t:
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000888 msgs.append(t)
889 else:
890 assert issubclass(t.message, _PresubmitResult)
891 tests.append(t)
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +0000892 if self.verbose:
893 t.info = _PresubmitNotifyResult
Edward Lemur1037c742018-05-01 18:56:04 -0400894 if not t.kwargs.get('cwd'):
895 t.kwargs['cwd'] = self.PresubmitLocalPath()
Edward Lesmes8e282792018-04-03 18:50:29 -0400896 self.thread_pool.AddTests(tests, parallel)
Edward Lemur21000eb2019-05-24 23:25:58 +0000897 # When self.parallel is True (i.e. --parallel is passed as an option)
898 # RunTests doesn't actually run tests. It adds them to a ThreadPool that
899 # will run all tests once all PRESUBMIT files are processed.
900 # Otherwise, it will run them and return the results.
901 if not self.parallel:
Edward Lesmes8e282792018-04-03 18:50:29 -0400902 msgs.extend(self.thread_pool.RunAsync())
903 return msgs
scottmg86099d72016-09-01 09:16:51 -0700904
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000905
nick@chromium.orgff526192013-06-10 19:30:26 +0000906class _DiffCache(object):
907 """Caches diffs retrieved from a particular SCM."""
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000908 def __init__(self, upstream=None):
909 """Stores the upstream revision against which all diffs will be computed."""
910 self._upstream = upstream
nick@chromium.orgff526192013-06-10 19:30:26 +0000911
912 def GetDiff(self, path, local_root):
913 """Get the diff for a particular path."""
914 raise NotImplementedError()
915
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700916 def GetOldContents(self, path, local_root):
917 """Get the old version for a particular path."""
918 raise NotImplementedError()
919
nick@chromium.orgff526192013-06-10 19:30:26 +0000920
nick@chromium.orgff526192013-06-10 19:30:26 +0000921class _GitDiffCache(_DiffCache):
922 """DiffCache implementation for git; gets all file diffs at once."""
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000923 def __init__(self, upstream):
924 super(_GitDiffCache, self).__init__(upstream=upstream)
nick@chromium.orgff526192013-06-10 19:30:26 +0000925 self._diffs_by_file = None
926
927 def GetDiff(self, path, local_root):
Bruce Dawson5f63d3c2022-04-19 17:02:36 +0000928 # Compare against None to distinguish between None and an initialized but
929 # empty dictionary.
930 if self._diffs_by_file == None:
nick@chromium.orgff526192013-06-10 19:30:26 +0000931 # Compute a single diff for all files and parse the output; should
932 # with git this is much faster than computing one diff for each file.
933 diffs = {}
934
935 # Don't specify any filenames below, because there are command line length
936 # limits on some platforms and GenerateDiff would fail.
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000937 unified_diff = scm.GIT.GenerateDiff(local_root, files=[], full_move=True,
938 branch=self._upstream)
nick@chromium.orgff526192013-06-10 19:30:26 +0000939
940 # This regex matches the path twice, separated by a space. Note that
941 # filename itself may contain spaces.
942 file_marker = re.compile('^diff --git (?P<filename>.*) (?P=filename)$')
943 current_diff = []
944 keep_line_endings = True
945 for x in unified_diff.splitlines(keep_line_endings):
946 match = file_marker.match(x)
947 if match:
948 # Marks the start of a new per-file section.
949 diffs[match.group('filename')] = current_diff = [x]
950 elif x.startswith('diff --git'):
951 raise PresubmitFailure('Unexpected diff line: %s' % x)
952 else:
953 current_diff.append(x)
954
955 self._diffs_by_file = dict(
956 (normpath(path), ''.join(diff)) for path, diff in diffs.items())
957
958 if path not in self._diffs_by_file:
Josip Sokcevicc1ab7342022-02-24 19:02:44 +0000959 # SCM didn't have any diff on this file. It could be that the file was not
960 # modified at all (e.g. user used --all flag in git cl presubmit).
961 # Intead of failing, return empty string.
962 # See: https://crbug.com/808346.
Josip Sokcevicc1ab7342022-02-24 19:02:44 +0000963 return ''
nick@chromium.orgff526192013-06-10 19:30:26 +0000964
965 return self._diffs_by_file[path]
966
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700967 def GetOldContents(self, path, local_root):
968 return scm.GIT.GetOldContents(local_root, path, branch=self._upstream)
969
nick@chromium.orgff526192013-06-10 19:30:26 +0000970
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000971class AffectedFile(object):
972 """Representation of a file in a change."""
nick@chromium.orgff526192013-06-10 19:30:26 +0000973
974 DIFF_CACHE = _DiffCache
975
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000976 # Method could be a function
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800977 # pylint: disable=no-self-use
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000978 def __init__(self, path, action, repository_root, diff_cache):
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000979 self._path = path
980 self._action = action
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000981 self._local_root = repository_root
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000982 self._is_directory = None
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000983 self._cached_changed_contents = None
984 self._cached_new_contents = None
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000985 self._diff_cache = diff_cache
tobiasjs2836bcf2016-08-16 04:08:16 -0700986 logging.debug('%s(%s)', self.__class__.__name__, self._path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000987
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000988 def LocalPath(self):
989 """Returns the path of this file on the local disk relative to client root.
Andrew Grieve92b8b992017-11-02 09:42:24 -0400990
991 This should be used for error messages but not for accessing files,
992 because presubmit checks are run with CWD=PresubmitLocalPath() (which is
993 often != client root).
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000994 """
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000995 return normpath(self._path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000996
997 def AbsoluteLocalPath(self):
998 """Returns the absolute path of this file on the local disk.
999 """
chase@chromium.org8e416c82009-10-06 04:30:44 +00001000 return os.path.abspath(os.path.join(self._local_root, self.LocalPath()))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001001
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001002 def Action(self):
1003 """Returns the action on this opened file, e.g. A, M, D, etc."""
maruel@chromium.org15bdffa2009-05-29 11:16:29 +00001004 return self._action
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001005
agable0b65e732016-11-22 09:25:46 -08001006 def IsTestableFile(self):
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +00001007 """Returns True if the file is a text file and not a binary file.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +00001008
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +00001009 Deleted files are not text file."""
maruel@chromium.org1e08c002009-05-28 19:09:33 +00001010 raise NotImplementedError() # Implement when needed
1011
agable0b65e732016-11-22 09:25:46 -08001012 def IsTextFile(self):
1013 """An alias to IsTestableFile for backwards compatibility."""
1014 return self.IsTestableFile()
1015
Daniel Cheng7a1f04d2017-03-21 19:12:31 -07001016 def OldContents(self):
1017 """Returns an iterator over the lines in the old version of file.
1018
Daniel Cheng2da34fe2017-03-21 20:42:12 -07001019 The old version is the file before any modifications in the user's
Edward Lemura5799e32020-01-17 19:26:51 +00001020 workspace, i.e. the 'left hand side'.
Daniel Cheng7a1f04d2017-03-21 19:12:31 -07001021
1022 Contents will be empty if the file is a directory or does not exist.
1023 Note: The carriage returns (LF or CR) are stripped off.
1024 """
1025 return self._diff_cache.GetOldContents(self.LocalPath(),
1026 self._local_root).splitlines()
1027
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001028 def NewContents(self):
1029 """Returns an iterator over the lines in the new version of file.
1030
Edward Lemura5799e32020-01-17 19:26:51 +00001031 The new version is the file in the user's workspace, i.e. the 'right hand
1032 side'.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001033
1034 Contents will be empty if the file is a directory or does not exist.
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +00001035 Note: The carriage returns (LF or CR) are stripped off.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001036 """
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +00001037 if self._cached_new_contents is None:
1038 self._cached_new_contents = []
agable0b65e732016-11-22 09:25:46 -08001039 try:
1040 self._cached_new_contents = gclient_utils.FileRead(
1041 self.AbsoluteLocalPath(), 'rU').splitlines()
1042 except IOError:
1043 pass # File not found? That's fine; maybe it was deleted.
Greg Thompson30cde452021-06-01 16:38:47 +00001044 except UnicodeDecodeError as e:
Dirk Pranke6fc394f2021-05-26 23:25:14 +00001045 # log the filename since we're probably trying to read a binary
1046 # file, and shouldn't be.
1047 print('Error reading %s: %s' % (self.AbsoluteLocalPath(), e))
1048 raise
1049
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +00001050 return self._cached_new_contents[:]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001051
Bruce Dawsonf0bcfdd2021-05-21 18:10:23 +00001052 def ChangedContents(self, keeplinebreaks=False):
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001053 """Returns a list of tuples (line number, line text) of all new lines.
1054
1055 This relies on the scm diff output describing each changed code section
1056 with a line of the form
1057
1058 ^@@ <old line num>,<old size> <new line num>,<new size> @@$
1059 """
Bruce Dawsonf0bcfdd2021-05-21 18:10:23 +00001060 # Don't return cached results when line breaks are requested.
1061 if not keeplinebreaks and self._cached_changed_contents is not None:
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +00001062 return self._cached_changed_contents[:]
Bruce Dawsonf0bcfdd2021-05-21 18:10:23 +00001063 result = []
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001064 line_num = 0
1065
Bruce Dawsonf0bcfdd2021-05-21 18:10:23 +00001066 # The keeplinebreaks parameter to splitlines must be True or else the
1067 # CheckForWindowsLineEndings presubmit will be a NOP.
1068 for line in self.GenerateScmDiff().splitlines(keeplinebreaks):
Edward Lemurac5c55f2020-02-29 00:17:16 +00001069 m = re.match(r'^@@ [0-9\,\+\-]+ \+([0-9]+)\,[0-9]+ @@', line)
1070 if m:
1071 line_num = int(m.groups(1)[0])
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001072 continue
1073 if line.startswith('+') and not line.startswith('++'):
Bruce Dawsonf0bcfdd2021-05-21 18:10:23 +00001074 result.append((line_num, line[1:]))
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001075 if not line.startswith('-'):
1076 line_num += 1
Bruce Dawsonf0bcfdd2021-05-21 18:10:23 +00001077 # Don't cache results with line breaks.
1078 if keeplinebreaks:
1079 return result;
1080 self._cached_changed_contents = result
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +00001081 return self._cached_changed_contents[:]
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001082
maruel@chromium.org5de13972009-06-10 18:16:06 +00001083 def __str__(self):
1084 return self.LocalPath()
1085
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001086 def GenerateScmDiff(self):
nick@chromium.orgff526192013-06-10 19:30:26 +00001087 return self._diff_cache.GetDiff(self.LocalPath(), self._local_root)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001088
maruel@chromium.org58407af2011-04-12 23:15:57 +00001089
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001090class GitAffectedFile(AffectedFile):
1091 """Representation of a file in a change out of a git checkout."""
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +00001092 # Method 'NNN' is abstract in class 'NNN' but is not overridden
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -08001093 # pylint: disable=abstract-method
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001094
nick@chromium.orgff526192013-06-10 19:30:26 +00001095 DIFF_CACHE = _GitDiffCache
1096
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001097 def __init__(self, *args, **kwargs):
1098 AffectedFile.__init__(self, *args, **kwargs)
1099 self._server_path = None
agable0b65e732016-11-22 09:25:46 -08001100 self._is_testable_file = None
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001101
agable0b65e732016-11-22 09:25:46 -08001102 def IsTestableFile(self):
1103 if self._is_testable_file is None:
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001104 if self.Action() == 'D':
agable0b65e732016-11-22 09:25:46 -08001105 # A deleted file is not testable.
1106 self._is_testable_file = False
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001107 else:
agable0b65e732016-11-22 09:25:46 -08001108 self._is_testable_file = os.path.isfile(self.AbsoluteLocalPath())
1109 return self._is_testable_file
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001110
maruel@chromium.orgc1938752011-04-12 23:11:13 +00001111
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001112class Change(object):
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001113 """Describe a change.
1114
1115 Used directly by the presubmit scripts to query the current change being
1116 tested.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +00001117
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001118 Instance members:
nick@chromium.orgff526192013-06-10 19:30:26 +00001119 tags: Dictionary of KEY=VALUE pairs found in the change description.
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001120 self.KEY: equivalent to tags['KEY']
1121 """
1122
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001123 _AFFECTED_FILES = AffectedFile
1124
Edward Lemura5799e32020-01-17 19:26:51 +00001125 # Matches key/value (or 'tag') lines in changelist descriptions.
maruel@chromium.org428342a2011-11-10 15:46:33 +00001126 TAG_LINE_RE = re.compile(
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001127 '^[ \t]*(?P<key>[A-Z][A-Z_0-9]*)[ \t]*=[ \t]*(?P<value>.*?)[ \t]*$')
maruel@chromium.orgc1938752011-04-12 23:11:13 +00001128 scm = ''
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001129
maruel@chromium.org58407af2011-04-12 23:15:57 +00001130 def __init__(
agable@chromium.orgea84ef12014-04-30 19:55:12 +00001131 self, name, description, local_root, files, issue, patchset, author,
1132 upstream=None):
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001133 if files is None:
1134 files = []
1135 self._name = name
chase@chromium.org8e416c82009-10-06 04:30:44 +00001136 # Convert root into an absolute path.
1137 self._local_root = os.path.abspath(local_root)
agable@chromium.orgea84ef12014-04-30 19:55:12 +00001138 self._upstream = upstream
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001139 self.issue = issue
1140 self.patchset = patchset
maruel@chromium.org58407af2011-04-12 23:15:57 +00001141 self.author_email = author
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001142
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001143 self._full_description = ''
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001144 self.tags = {}
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001145 self._description_without_tags = ''
1146 self.SetDescriptionText(description)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001147
maruel@chromium.orge085d812011-10-10 19:49:15 +00001148 assert all(
1149 (isinstance(f, (list, tuple)) and len(f) == 2) for f in files), files
1150
agable@chromium.orgea84ef12014-04-30 19:55:12 +00001151 diff_cache = self._AFFECTED_FILES.DIFF_CACHE(self._upstream)
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001152 self._affected_files = [
nick@chromium.orgff526192013-06-10 19:30:26 +00001153 self._AFFECTED_FILES(path, action.strip(), self._local_root, diff_cache)
1154 for action, path in files
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +00001155 ]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001156
Edward Lesmes9ce03f82021-01-12 20:13:31 +00001157 def UpstreamBranch(self):
1158 """Returns the upstream branch for the change."""
1159 return self._upstream
1160
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001161 def Name(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001162 """Returns the change name."""
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001163 return self._name
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001164
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001165 def DescriptionText(self):
1166 """Returns the user-entered changelist description, minus tags.
1167
Edward Lemura5799e32020-01-17 19:26:51 +00001168 Any line in the user-provided description starting with e.g. 'FOO='
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001169 (whitespace permitted before and around) is considered a tag line. Such
1170 lines are stripped out of the description this function returns.
1171 """
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001172 return self._description_without_tags
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001173
1174 def FullDescriptionText(self):
1175 """Returns the complete changelist description including tags."""
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001176 return self._full_description
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001177
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001178 def SetDescriptionText(self, description):
1179 """Sets the full description text (including tags) to |description|.
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001180
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001181 Also updates the list of tags."""
1182 self._full_description = description
1183
1184 # From the description text, build up a dictionary of key/value pairs
Edward Lemura5799e32020-01-17 19:26:51 +00001185 # plus the description minus all key/value or 'tag' lines.
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001186 description_without_tags = []
1187 self.tags = {}
1188 for line in self._full_description.splitlines():
1189 m = self.TAG_LINE_RE.match(line)
1190 if m:
1191 self.tags[m.group('key')] = m.group('value')
1192 else:
1193 description_without_tags.append(line)
1194
1195 # Change back to text and remove whitespace at end.
1196 self._description_without_tags = (
1197 '\n'.join(description_without_tags).rstrip())
1198
Edward Lemur69bb8be2020-02-03 20:37:38 +00001199 def AddDescriptionFooter(self, key, value):
1200 """Adds the given footer to the change description.
1201
1202 Args:
1203 key: A string with the key for the git footer. It must conform to
1204 the git footers format (i.e. 'List-Of-Tokens') and will be case
1205 normalized so that each token is title-cased.
1206 value: A string with the value for the git footer.
1207 """
1208 description = git_footers.add_footer(
1209 self.FullDescriptionText(), git_footers.normalize_name(key), value)
1210 self.SetDescriptionText(description)
1211
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001212 def RepositoryRoot(self):
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001213 """Returns the repository (checkout) root directory for this change,
1214 as an absolute path.
1215 """
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001216 return self._local_root
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001217
1218 def __getattr__(self, attr):
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001219 """Return tags directly as attributes on the object."""
Edward Lemura5799e32020-01-17 19:26:51 +00001220 if not re.match(r'^[A-Z_]*$', attr):
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001221 raise AttributeError(self, attr)
maruel@chromium.orge1a524f2009-05-27 14:43:46 +00001222 return self.tags.get(attr)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001223
Edward Lemur69bb8be2020-02-03 20:37:38 +00001224 def GitFootersFromDescription(self):
1225 """Return the git footers present in the description.
1226
1227 Returns:
1228 footers: A dict of {footer: [values]} containing a multimap of the footers
1229 in the change description.
1230 """
1231 return git_footers.parse_footers(self.FullDescriptionText())
1232
Aaron Gablefc03e672017-05-15 14:09:42 -07001233 def BugsFromDescription(self):
1234 """Returns all bugs referenced in the commit description."""
Sean McAllister1e509c52021-10-25 17:54:25 +00001235 bug_tags = ['BUG', 'FIXED']
1236
1237 tags = []
1238 for tag in bug_tags:
1239 values = self.tags.get(tag)
1240 if values:
1241 tags += [value.strip() for value in values.split(',')]
1242
Caleb Rouleauc0546b92019-02-22 06:12:57 +00001243 footers = []
Edward Lemur69bb8be2020-02-03 20:37:38 +00001244 parsed = self.GitFootersFromDescription()
Dan Beam62954042019-10-03 21:20:33 +00001245 unsplit_footers = parsed.get('Bug', []) + parsed.get('Fixed', [])
Caleb Rouleauc0546b92019-02-22 06:12:57 +00001246 for unsplit_footer in unsplit_footers:
1247 footers += [b.strip() for b in unsplit_footer.split(',')]
Aaron Gable12ef5012017-05-15 14:29:00 -07001248 return sorted(set(tags + footers))
Aaron Gablefc03e672017-05-15 14:09:42 -07001249
1250 def ReviewersFromDescription(self):
1251 """Returns all reviewers listed in the commit description."""
Edward Lemura5799e32020-01-17 19:26:51 +00001252 # We don't support a 'R:' git-footer for reviewers; that is in metadata.
Aaron Gable12ef5012017-05-15 14:29:00 -07001253 tags = [r.strip() for r in self.tags.get('R', '').split(',') if r.strip()]
1254 return sorted(set(tags))
Aaron Gablefc03e672017-05-15 14:09:42 -07001255
1256 def TBRsFromDescription(self):
1257 """Returns all TBR reviewers listed in the commit description."""
Aaron Gable12ef5012017-05-15 14:29:00 -07001258 tags = [r.strip() for r in self.tags.get('TBR', '').split(',') if r.strip()]
Aaron Gable6e7ddb62020-05-27 22:23:29 +00001259 # TODO(crbug.com/839208): Remove support for 'Tbr:' when TBRs are
1260 # programmatically determined by self-CR+1s.
Edward Lemur69bb8be2020-02-03 20:37:38 +00001261 footers = self.GitFootersFromDescription().get('Tbr', [])
Aaron Gable12ef5012017-05-15 14:29:00 -07001262 return sorted(set(tags + footers))
Aaron Gablefc03e672017-05-15 14:09:42 -07001263
Aaron Gable6e7ddb62020-05-27 22:23:29 +00001264 # TODO(crbug.com/753425): Delete these once we're sure they're unused.
Aaron Gablefc03e672017-05-15 14:09:42 -07001265 @property
1266 def BUG(self):
1267 return ','.join(self.BugsFromDescription())
1268 @property
1269 def R(self):
1270 return ','.join(self.ReviewersFromDescription())
1271 @property
1272 def TBR(self):
1273 return ','.join(self.TBRsFromDescription())
1274
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001275 def AllFiles(self, root=None):
1276 """List all files under source control in the repo."""
1277 raise NotImplementedError()
1278
agable0b65e732016-11-22 09:25:46 -08001279 def AffectedFiles(self, include_deletes=True, file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001280 """Returns a list of AffectedFile instances for all files in the change.
1281
1282 Args:
1283 include_deletes: If false, deleted files will be filtered out.
sail@chromium.org5538e022011-05-12 17:53:16 +00001284 file_filter: An additional filter to apply.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001285
1286 Returns:
1287 [AffectedFile(path, action), AffectedFile(path, action)]
1288 """
Edward Lemurb9830242019-10-30 22:19:20 +00001289 affected = list(filter(file_filter, self._affected_files))
sail@chromium.org5538e022011-05-12 17:53:16 +00001290
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001291 if include_deletes:
1292 return affected
Edward Lemurb9830242019-10-30 22:19:20 +00001293 return list(filter(lambda x: x.Action() != 'D', affected))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001294
John Budorick16162372018-04-18 10:39:53 -07001295 def AffectedTestableFiles(self, include_deletes=None, **kwargs):
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +00001296 """Return a list of the existing text files in a change."""
1297 if include_deletes is not None:
Edward Lemura5799e32020-01-17 19:26:51 +00001298 warn('AffectedTeestableFiles(include_deletes=%s)'
1299 ' is deprecated and ignored' % str(include_deletes),
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +00001300 category=DeprecationWarning,
1301 stacklevel=2)
Edward Lemurb9830242019-10-30 22:19:20 +00001302 return list(filter(
1303 lambda x: x.IsTestableFile(),
1304 self.AffectedFiles(include_deletes=False, **kwargs)))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001305
agable0b65e732016-11-22 09:25:46 -08001306 def AffectedTextFiles(self, include_deletes=None):
1307 """An alias to AffectedTestableFiles for backwards compatibility."""
1308 return self.AffectedTestableFiles(include_deletes=include_deletes)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001309
agable0b65e732016-11-22 09:25:46 -08001310 def LocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001311 """Convenience function."""
agable0b65e732016-11-22 09:25:46 -08001312 return [af.LocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001313
agable0b65e732016-11-22 09:25:46 -08001314 def AbsoluteLocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001315 """Convenience function."""
agable0b65e732016-11-22 09:25:46 -08001316 return [af.AbsoluteLocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001317
1318 def RightHandSideLines(self):
Edward Lemura5799e32020-01-17 19:26:51 +00001319 """An iterator over all text lines in 'new' version of changed files.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001320
1321 Lists lines from new or modified text files in the change.
1322
1323 This is useful for doing line-by-line regex checks, like checking for
1324 trailing whitespace.
1325
1326 Yields:
1327 a 3 tuple:
1328 the AffectedFile instance of the current file;
1329 integer line number (1-based); and
1330 the contents of the line as a string.
1331 """
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +00001332 return _RightHandSideLinesImpl(
1333 x for x in self.AffectedFiles(include_deletes=False)
agable0b65e732016-11-22 09:25:46 -08001334 if x.IsTestableFile())
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001335
Jochen Eisingerd0573ec2017-04-13 10:55:06 +02001336 def OriginalOwnersFiles(self):
1337 """A map from path names of affected OWNERS files to their old content."""
1338 def owners_file_filter(f):
1339 return 'OWNERS' in os.path.split(f.LocalPath())[1]
1340 files = self.AffectedFiles(file_filter=owners_file_filter)
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +00001341 return {f.LocalPath(): f.OldContents() for f in files}
Jochen Eisingerd0573ec2017-04-13 10:55:06 +02001342
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001343
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001344class GitChange(Change):
1345 _AFFECTED_FILES = GitAffectedFile
maruel@chromium.orgc1938752011-04-12 23:11:13 +00001346 scm = 'git'
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +00001347
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001348 def AllFiles(self, root=None):
1349 """List all files under source control in the repo."""
1350 root = root or self.RepositoryRoot()
1351 return subprocess.check_output(
Aaron Gable7817f022017-12-12 09:43:17 -08001352 ['git', '-c', 'core.quotePath=false', 'ls-files', '--', '.'],
Josip Sokcevic0b123462021-06-08 20:41:32 +00001353 cwd=root).decode('utf-8', 'ignore').splitlines()
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001354
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001355
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001356def ListRelevantPresubmitFiles(files, root):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001357 """Finds all presubmit files that apply to a given set of source files.
1358
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001359 If inherit-review-settings-ok is present right under root, looks for
1360 PRESUBMIT.py in directories enclosing root.
1361
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001362 Args:
1363 files: An iterable container containing file paths.
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001364 root: Path where to stop searching.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001365
1366 Return:
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001367 List of absolute paths of the existing PRESUBMIT.py scripts.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001368 """
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001369 files = [normpath(os.path.join(root, f)) for f in files]
1370
1371 # List all the individual directories containing files.
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +00001372 directories = {os.path.dirname(f) for f in files}
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001373
1374 # Ignore root if inherit-review-settings-ok is present.
1375 if os.path.isfile(os.path.join(root, 'inherit-review-settings-ok')):
1376 root = None
1377
1378 # Collect all unique directories that may contain PRESUBMIT.py.
1379 candidates = set()
1380 for directory in directories:
1381 while True:
1382 if directory in candidates:
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001383 break
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001384 candidates.add(directory)
1385 if directory == root:
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001386 break
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001387 parent_dir = os.path.dirname(directory)
1388 if parent_dir == directory:
1389 # We hit the system root directory.
1390 break
1391 directory = parent_dir
1392
1393 # Look for PRESUBMIT.py in all candidate directories.
1394 results = []
1395 for directory in sorted(list(candidates)):
tobiasjsff061c02016-08-17 03:23:57 -07001396 try:
1397 for f in os.listdir(directory):
1398 p = os.path.join(directory, f)
1399 if os.path.isfile(p) and re.match(
1400 r'PRESUBMIT.*\.py$', f) and not f.startswith('PRESUBMIT_test'):
1401 results.append(p)
1402 except OSError:
1403 pass
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001404
tobiasjs2836bcf2016-08-16 04:08:16 -07001405 logging.debug('Presubmit files: %s', ','.join(results))
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001406 return results
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001407
1408
rmistry@google.com5626a922015-02-26 14:03:30 +00001409class GetPostUploadExecuter(object):
Josip Sokcevice293d3d2022-02-16 22:52:15 +00001410 def __init__(self, use_python3):
1411 """
1412 Args:
1413 use_python3: if true, will use python3 instead of python2 by default
1414 if USE_PYTHON3 is not specified.
1415 """
1416 self.use_python3 = use_python3
1417
1418 def ExecPresubmitScript(self, script_text, presubmit_path, gerrit_obj,
1419 change):
rmistry@google.com5626a922015-02-26 14:03:30 +00001420 """Executes PostUploadHook() from a single presubmit script.
Josip Sokcevic632bbc02022-05-19 05:32:50 +00001421 Caller is responsible for validating whether the hook should be executed
1422 and should only call this function if it should be.
rmistry@google.com5626a922015-02-26 14:03:30 +00001423
1424 Args:
1425 script_text: The text of the presubmit script.
1426 presubmit_path: Project script to run.
Edward Lemur016a0872020-02-04 22:13:28 +00001427 gerrit_obj: The GerritAccessor object.
rmistry@google.com5626a922015-02-26 14:03:30 +00001428 change: The Change object.
1429
1430 Return:
1431 A list of results objects.
1432 """
1433 context = {}
1434 try:
Raul Tambre09e64b42019-05-14 01:57:22 +00001435 exec(compile(script_text, 'PRESUBMIT.py', 'exec', dont_inherit=True),
1436 context)
Raul Tambre7c938462019-05-24 16:35:35 +00001437 except Exception as e:
rmistry@google.com5626a922015-02-26 14:03:30 +00001438 raise PresubmitFailure('"%s" had an exception.\n%s'
1439 % (presubmit_path, e))
1440
1441 function_name = 'PostUploadHook'
1442 if function_name not in context:
1443 return {}
1444 post_upload_hook = context[function_name]
1445 if not len(inspect.getargspec(post_upload_hook)[0]) == 3:
1446 raise PresubmitFailure(
1447 'Expected function "PostUploadHook" to take three arguments.')
Edward Lemur016a0872020-02-04 22:13:28 +00001448 return post_upload_hook(gerrit_obj, change, OutputApi(False))
rmistry@google.com5626a922015-02-26 14:03:30 +00001449
1450
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001451def _MergeMasters(masters1, masters2):
1452 """Merges two master maps. Merges also the tests of each builder."""
1453 result = {}
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001454 for (master, builders) in itertools.chain(masters1.items(),
1455 masters2.items()):
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001456 new_builders = result.setdefault(master, {})
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001457 for (builder, tests) in builders.items():
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001458 new_builders.setdefault(builder, set([])).update(tests)
1459 return result
1460
1461
Josip Sokcevice293d3d2022-02-16 22:52:15 +00001462def DoPostUploadExecuter(change, gerrit_obj, verbose, use_python3=False):
rmistry@google.com5626a922015-02-26 14:03:30 +00001463 """Execute the post upload hook.
1464
1465 Args:
1466 change: The Change object.
Edward Lemur016a0872020-02-04 22:13:28 +00001467 gerrit_obj: The GerritAccessor object.
rmistry@google.com5626a922015-02-26 14:03:30 +00001468 verbose: Prints debug info.
Josip Sokcevice293d3d2022-02-16 22:52:15 +00001469 use_python3: if true, default to using Python3 for presubmit checks
1470 rather than Python2.
rmistry@google.com5626a922015-02-26 14:03:30 +00001471 """
Josip Sokcevice293d3d2022-02-16 22:52:15 +00001472 python_version = 'Python %s' % sys.version_info.major
1473 sys.stdout.write('Running %s post upload checks ...\n' % python_version)
rmistry@google.com5626a922015-02-26 14:03:30 +00001474 presubmit_files = ListRelevantPresubmitFiles(
Edward Lemur6eb1d322020-02-27 22:20:15 +00001475 change.LocalPaths(), change.RepositoryRoot())
rmistry@google.com5626a922015-02-26 14:03:30 +00001476 if not presubmit_files and verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001477 sys.stdout.write('Warning, no PRESUBMIT.py found.\n')
rmistry@google.com5626a922015-02-26 14:03:30 +00001478 results = []
Josip Sokcevice293d3d2022-02-16 22:52:15 +00001479 executer = GetPostUploadExecuter(use_python3)
rmistry@google.com5626a922015-02-26 14:03:30 +00001480 # The root presubmit file should be executed after the ones in subdirectories.
1481 # i.e. the specific post upload hooks should run before the general ones.
1482 # Thus, reverse the order provided by ListRelevantPresubmitFiles.
1483 presubmit_files.reverse()
1484
1485 for filename in presubmit_files:
1486 filename = os.path.abspath(filename)
rmistry@google.com5626a922015-02-26 14:03:30 +00001487 # Accept CRLF presubmit script.
Bruce Dawson6e70e862022-07-01 19:37:01 +00001488 presubmit_script = gclient_utils.FileRead(filename).replace('\r\n', '\n')
Josip Sokcevic632bbc02022-05-19 05:32:50 +00001489 if _ShouldRunPresubmit(presubmit_script, use_python3):
Bruce Dawson8d78bd12022-08-12 19:17:03 +00001490 if sys.version_info[0] == 2:
Bruce Dawson443f9852022-09-08 17:30:59 +00001491 sys.stdout.write(
1492 'Running %s under Python 2. Add USE_PYTHON3 = True to prevent '
1493 'this.\n' % filename)
Bruce Dawson8d78bd12022-08-12 19:17:03 +00001494 elif verbose:
1495 sys.stdout.write('Running %s\n' % filename)
Josip Sokcevic632bbc02022-05-19 05:32:50 +00001496 results.extend(executer.ExecPresubmitScript(
1497 presubmit_script, filename, gerrit_obj, change))
rmistry@google.com5626a922015-02-26 14:03:30 +00001498
Edward Lemur6eb1d322020-02-27 22:20:15 +00001499 if not results:
1500 return 0
1501
1502 sys.stdout.write('\n')
1503 sys.stdout.write('** Post Upload Hook Messages **\n')
1504
1505 exit_code = 0
1506 for result in results:
1507 if result.fatal:
1508 exit_code = 1
1509 result.handle()
1510 sys.stdout.write('\n')
1511
1512 return exit_code
rmistry@google.com5626a922015-02-26 14:03:30 +00001513
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001514class PresubmitExecuter(object):
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001515 def __init__(self, change, committing, verbose, gerrit_obj, dry_run=None,
Bruce Dawson09c0c072022-05-26 20:28:58 +00001516 thread_pool=None, parallel=False, use_python3=False,
1517 no_diffs=False):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001518 """
1519 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001520 change: The Change object.
agable92bec4f2016-08-24 09:27:27 -07001521 committing: True if 'git cl land' is running, False if 'git cl upload' is.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001522 gerrit_obj: provides basic Gerrit codereview functionality.
1523 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -04001524 parallel: if true, all tests reported via input_api.RunTests for all
1525 PRESUBMIT files will be run in parallel.
Dirk Pranke6f0df682021-06-25 00:42:33 +00001526 use_python3: if true, will use python3 instead of python2 by default
1527 if USE_PYTHON3 is not specified.
Bruce Dawson09c0c072022-05-26 20:28:58 +00001528 no_diffs: if true, implies that --files or --all was specified so some
1529 checks can be skipped, and some errors will be messages.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001530 """
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001531 self.change = change
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001532 self.committing = committing
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001533 self.gerrit = gerrit_obj
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001534 self.verbose = verbose
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001535 self.dry_run = dry_run
Daniel Cheng7227d212017-11-17 08:12:37 -08001536 self.more_cc = []
Edward Lesmes8e282792018-04-03 18:50:29 -04001537 self.thread_pool = thread_pool
1538 self.parallel = parallel
Dirk Pranke6f0df682021-06-25 00:42:33 +00001539 self.use_python3 = use_python3
Bruce Dawson09c0c072022-05-26 20:28:58 +00001540 self.no_diffs = no_diffs
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001541
1542 def ExecPresubmitScript(self, script_text, presubmit_path):
1543 """Executes a single presubmit script.
Josip Sokcevic632bbc02022-05-19 05:32:50 +00001544 Caller is responsible for validating whether the hook should be executed
1545 and should only call this function if it should be.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001546
1547 Args:
1548 script_text: The text of the presubmit script.
1549 presubmit_path: The path to the presubmit file (this will be reported via
1550 input_api.PresubmitLocalPath()).
1551
1552 Return:
1553 A list of result objects, empty if no problems.
1554 """
chase@chromium.org8e416c82009-10-06 04:30:44 +00001555 # Change to the presubmit file's directory to support local imports.
1556 main_path = os.getcwd()
Saagar Sanghavi98b332f2020-07-31 17:19:15 +00001557 presubmit_dir = os.path.dirname(presubmit_path)
1558 os.chdir(presubmit_dir)
chase@chromium.org8e416c82009-10-06 04:30:44 +00001559
1560 # Load the presubmit script into context.
dpranke@chromium.org970c5222011-03-12 00:32:24 +00001561 input_api = InputApi(self.change, presubmit_path, self.committing,
Aaron Gable668c1d82018-04-03 10:19:16 -07001562 self.verbose, gerrit_obj=self.gerrit,
Edward Lesmes8e282792018-04-03 18:50:29 -04001563 dry_run=self.dry_run, thread_pool=self.thread_pool,
Bruce Dawson09c0c072022-05-26 20:28:58 +00001564 parallel=self.parallel, no_diffs=self.no_diffs)
Daniel Cheng7227d212017-11-17 08:12:37 -08001565 output_api = OutputApi(self.committing)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001566 context = {}
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001567
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001568 try:
Bruce Dawson0ba2fd42022-07-21 13:47:21 +00001569 exec(compile(script_text, presubmit_path, 'exec', dont_inherit=True),
Raul Tambre09e64b42019-05-14 01:57:22 +00001570 context)
Raul Tambre7c938462019-05-24 16:35:35 +00001571 except Exception as e:
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001572 raise PresubmitFailure('"%s" had an exception.\n%s' % (presubmit_path, e))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001573
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001574 context['__args'] = (input_api, output_api)
Ben Pastene8351dc12020-08-06 05:01:35 +00001575
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001576 # Get path of presubmit directory relative to repository root.
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001577 # Always use forward slashes, so that path is same in *nix and Windows
1578 root = input_api.change.RepositoryRoot()
1579 rel_path = os.path.relpath(presubmit_dir, root)
1580 rel_path = rel_path.replace(os.path.sep, '/')
Ben Pastene8351dc12020-08-06 05:01:35 +00001581
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001582 # Get the URL of git remote origin and use it to identify host and project
Edward Lesmeseb1bd622021-03-01 19:54:07 +00001583 host = project = ''
1584 if self.gerrit:
1585 host = self.gerrit.host or ''
1586 project = self.gerrit.project or ''
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001587
1588 # Prefix for test names
1589 prefix = 'presubmit:%s/%s:%s/' % (host, project, rel_path)
1590
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001591 # Perform all the desired presubmit checks.
1592 results = []
Ben Pastene8351dc12020-08-06 05:01:35 +00001593
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001594 try:
Scott Leecc2fe9b2020-11-19 19:38:06 +00001595 version = [
1596 int(x) for x in context.get('PRESUBMIT_VERSION', '0.0.0').split('.')
1597 ]
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001598
Scott Leecc2fe9b2020-11-19 19:38:06 +00001599 with rdb_wrapper.client(prefix) as sink:
1600 if version >= [2, 0, 0]:
Andrew Grievebdfb8f22022-02-02 21:56:47 +00001601 # Copy the keys to prevent "dictionary changed size during iteration"
1602 # exception if checks add globals to context. E.g. sometimes the
1603 # Python runtime will add __warningregistry__.
1604 for function_name in list(context.keys()):
Scott Leecc2fe9b2020-11-19 19:38:06 +00001605 if not function_name.startswith('Check'):
1606 continue
1607 if function_name.endswith('Commit') and not self.committing:
1608 continue
1609 if function_name.endswith('Upload') and self.committing:
1610 continue
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001611 logging.debug('Running %s in %s', function_name, presubmit_path)
1612 results.extend(
Bruce Dawson8fa42e22022-03-29 17:05:38 +00001613 self._run_check_function(function_name, context, sink,
1614 presubmit_path))
Scott Leecc2fe9b2020-11-19 19:38:06 +00001615 logging.debug('Running %s done.', function_name)
1616 self.more_cc.extend(output_api.more_cc)
1617
1618 else: # Old format
1619 if self.committing:
1620 function_name = 'CheckChangeOnCommit'
1621 else:
1622 function_name = 'CheckChangeOnUpload'
Andrew Grievebdfb8f22022-02-02 21:56:47 +00001623 if function_name in list(context.keys()):
Scott Leecc2fe9b2020-11-19 19:38:06 +00001624 logging.debug('Running %s in %s', function_name, presubmit_path)
1625 results.extend(
Bruce Dawson8fa42e22022-03-29 17:05:38 +00001626 self._run_check_function(function_name, context, sink,
1627 presubmit_path))
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001628 logging.debug('Running %s done.', function_name)
1629 self.more_cc.extend(output_api.more_cc)
1630
1631 finally:
1632 for f in input_api._named_temporary_files:
1633 os.remove(f)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001634
chase@chromium.org8e416c82009-10-06 04:30:44 +00001635 # Return the process to the original working directory.
1636 os.chdir(main_path)
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001637 return results
1638
Bruce Dawson8fa42e22022-03-29 17:05:38 +00001639 def _run_check_function(self, function_name, context, sink, presubmit_path):
Scott Leecc2fe9b2020-11-19 19:38:06 +00001640 """Evaluates and returns the result of a given presubmit function.
1641
1642 If sink is given, the result of the presubmit function will be reported
1643 to the ResultSink.
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001644
1645 Args:
Scott Leecc2fe9b2020-11-19 19:38:06 +00001646 function_name: the name of the presubmit function to evaluate
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001647 context: a context dictionary in which the function will be evaluated
Scott Leecc2fe9b2020-11-19 19:38:06 +00001648 sink: an instance of ResultSink. None, by default.
1649 Returns:
1650 the result of the presubmit function call.
1651 """
1652 start_time = time_time()
1653 try:
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001654 result = eval(function_name + '(*__args)', context)
1655 self._check_result_type(result)
Allen Webbfe7d7092021-05-18 02:05:49 +00001656 except Exception:
Bruce Dawson10a82862022-05-27 19:25:56 +00001657 _, e_value, _ = sys.exc_info()
1658 result = [
1659 OutputApi.PresubmitError(
1660 'Evaluation of %s failed: %s, %s' %
1661 (function_name, e_value, traceback.format_exc()))
1662 ]
Scott Leecc2fe9b2020-11-19 19:38:06 +00001663
Bruce Dawson2bdc49f2021-05-21 19:13:03 +00001664 elapsed_time = time_time() - start_time
1665 if elapsed_time > 10.0:
Bruce Dawson6757d462022-07-13 04:04:40 +00001666 sys.stdout.write('%6.1fs to run %s from %s.\n' %
1667 (elapsed_time, function_name, presubmit_path))
Scott Leecc2fe9b2020-11-19 19:38:06 +00001668 if sink:
Erik Staab9f38b632022-10-31 14:05:24 +00001669 failure_reason = None
Scott Leecc2fe9b2020-11-19 19:38:06 +00001670 status = rdb_wrapper.STATUS_PASS
1671 if any(r.fatal for r in result):
1672 status = rdb_wrapper.STATUS_FAIL
Erik Staab9f38b632022-10-31 14:05:24 +00001673 failure_reasons = []
1674 for r in result:
1675 fields = r.json_format()
1676 message = fields['message']
1677 items = '\n'.join(' %s' % item for item in fields['items'])
1678 failure_reasons.append('\n'.join([message, items]))
1679 if failure_reasons:
1680 failure_reason = '\n'.join(failure_reasons)
1681 sink.report(function_name, status, elapsed_time, failure_reason)
Scott Leecc2fe9b2020-11-19 19:38:06 +00001682
1683 return result
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001684
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00001685 def _check_result_type(self, result):
1686 """Helper function which ensures result is a list, and all elements are
1687 instances of OutputApi.PresubmitResult"""
1688 if not isinstance(result, (tuple, list)):
1689 raise PresubmitFailure('Presubmit functions must return a tuple or list')
1690 if not all(isinstance(res, OutputApi.PresubmitResult) for res in result):
1691 raise PresubmitFailure(
1692 'All presubmit results must be of types derived from '
1693 'output_api.PresubmitResult')
1694
1695
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001696def DoPresubmitChecks(change,
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001697 committing,
1698 verbose,
maruel@chromium.orgb0dfd352009-06-10 14:12:54 +00001699 default_presubmit,
dpranke@chromium.org970c5222011-03-12 00:32:24 +00001700 may_prompt,
Aaron Gable668c1d82018-04-03 10:19:16 -07001701 gerrit_obj,
Edward Lesmes8e282792018-04-03 18:50:29 -04001702 dry_run=None,
Debrian Figueroadd2737e2019-06-21 23:50:13 +00001703 parallel=False,
Dirk Pranke6f0df682021-06-25 00:42:33 +00001704 json_output=None,
Bruce Dawson09c0c072022-05-26 20:28:58 +00001705 use_python3=False,
1706 no_diffs=False):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001707 """Runs all presubmit checks that apply to the files in the change.
1708
1709 This finds all PRESUBMIT.py files in directories enclosing the files in the
1710 change (up to the repository root) and calls the relevant entrypoint function
1711 depending on whether the change is being committed or uploaded.
1712
1713 Prints errors, warnings and notifications. Prompts the user for warnings
1714 when needed.
1715
1716 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001717 change: The Change object.
agable92bec4f2016-08-24 09:27:27 -07001718 committing: True if 'git cl land' is running, False if 'git cl upload' is.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001719 verbose: Prints debug info.
maruel@chromium.org0ff1fab2009-05-22 13:08:15 +00001720 default_presubmit: A default presubmit script to execute in any case.
Quinten Yearsley516fe7f2016-12-14 11:50:18 -08001721 may_prompt: Enable (y/n) questions on warning or error. If False,
1722 any questions are answered with yes by default.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001723 gerrit_obj: provides basic Gerrit codereview functionality.
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001724 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -04001725 parallel: if true, all tests specified by input_api.RunTests in all
1726 PRESUBMIT files will be run in parallel.
Dirk Pranke6f0df682021-06-25 00:42:33 +00001727 use_python3: if true, default to using Python3 for presubmit checks
1728 rather than Python2.
Bruce Dawson09c0c072022-05-26 20:28:58 +00001729 no_diffs: if true, implies that --files or --all was specified so some
1730 checks can be skipped, and some errors will be messages.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001731 Return:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001732 1 if presubmit checks failed or 0 otherwise.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001733 """
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001734 old_environ = os.environ
1735 try:
1736 # Make sure python subprocesses won't generate .pyc files.
1737 os.environ = os.environ.copy()
Edward Lemurb9830242019-10-30 22:19:20 +00001738 os.environ['PYTHONDONTWRITEBYTECODE'] = '1'
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001739
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001740 python_version = 'Python %s' % sys.version_info.major
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001741 if committing:
Dirk Pranke6fc394f2021-05-26 23:25:14 +00001742 sys.stdout.write('Running %s presubmit commit checks ...\n' %
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001743 python_version)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001744 else:
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001745 sys.stdout.write('Running %s presubmit upload checks ...\n' %
1746 python_version)
Edward Lemurecc27072020-01-06 16:42:34 +00001747 start_time = time_time()
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001748 presubmit_files = ListRelevantPresubmitFiles(
agable0b65e732016-11-22 09:25:46 -08001749 change.AbsoluteLocalPaths(), change.RepositoryRoot())
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001750 if not presubmit_files and verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001751 sys.stdout.write('Warning, no PRESUBMIT.py found.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001752 results = []
Bruce Dawsonc9f904f2022-10-14 20:59:49 +00001753 if sys.platform == 'win32':
1754 temp = os.environ['TEMP']
1755 else:
1756 temp = '/tmp'
1757 python2_usage_log_file = os.path.join(temp, 'python2_usage.txt')
Bruce Dawsonf2b04212022-06-10 16:42:54 +00001758 if os.path.exists(python2_usage_log_file):
1759 os.remove(python2_usage_log_file)
Edward Lesmes8e282792018-04-03 18:50:29 -04001760 thread_pool = ThreadPool()
Edward Lemur7e3c67f2018-07-20 20:52:49 +00001761 executer = PresubmitExecuter(change, committing, verbose, gerrit_obj,
Bruce Dawson09c0c072022-05-26 20:28:58 +00001762 dry_run, thread_pool, parallel, use_python3,
1763 no_diffs)
Josip Sokcevic632bbc02022-05-19 05:32:50 +00001764 skipped_count = 0;
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001765 if default_presubmit:
1766 if verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001767 sys.stdout.write('Running default presubmit script.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001768 fake_path = os.path.join(change.RepositoryRoot(), 'PRESUBMIT.py')
Josip Sokcevic632bbc02022-05-19 05:32:50 +00001769 if _ShouldRunPresubmit(default_presubmit, use_python3):
1770 results += executer.ExecPresubmitScript(default_presubmit, fake_path)
1771 else:
1772 skipped_count += 1
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001773 for filename in presubmit_files:
1774 filename = os.path.abspath(filename)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001775 # Accept CRLF presubmit script.
Bruce Dawson6e70e862022-07-01 19:37:01 +00001776 presubmit_script = gclient_utils.FileRead(filename).replace('\r\n', '\n')
Josip Sokcevic632bbc02022-05-19 05:32:50 +00001777 if _ShouldRunPresubmit(presubmit_script, use_python3):
Bruce Dawson8d78bd12022-08-12 19:17:03 +00001778 if sys.version_info[0] == 2:
Bruce Dawson443f9852022-09-08 17:30:59 +00001779 sys.stdout.write(
1780 'Running %s under Python 2. Add USE_PYTHON3 = True to prevent '
1781 'this.\n' % filename)
Bruce Dawson8d78bd12022-08-12 19:17:03 +00001782 elif verbose:
1783 sys.stdout.write('Running %s\n' % filename)
Josip Sokcevic632bbc02022-05-19 05:32:50 +00001784 results += executer.ExecPresubmitScript(presubmit_script, filename)
1785 else:
1786 skipped_count += 1
Bruce Dawson76fe1a72022-05-25 20:52:21 +00001787
Edward Lesmes8e282792018-04-03 18:50:29 -04001788 results += thread_pool.RunAsync()
1789
Bruce Dawsonf2b04212022-06-10 16:42:54 +00001790 if os.path.exists(python2_usage_log_file):
1791 with open(python2_usage_log_file) as f:
1792 python2_usage = [x.strip() for x in f.readlines()]
1793 results.append(
1794 OutputApi(committing).PresubmitPromptWarning(
1795 'Python 2 scripts were run during %s presubmits. Please see '
1796 'https://bugs.chromium.org/p/chromium/issues/detail?id=1313804'
1797 '#c61 for tips on resolving this.'
1798 % python_version,
1799 items=python2_usage))
1800
Edward Lemur6eb1d322020-02-27 22:20:15 +00001801 messages = {}
1802 should_prompt = False
1803 presubmits_failed = False
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001804 for result in results:
1805 if result.fatal:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001806 presubmits_failed = True
1807 messages.setdefault('ERRORS', []).append(result)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001808 elif result.should_prompt:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001809 should_prompt = True
1810 messages.setdefault('Warnings', []).append(result)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001811 else:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001812 messages.setdefault('Messages', []).append(result)
pam@chromium.orged9a0832009-09-09 22:48:55 +00001813
Bruce Dawson76fe1a72022-05-25 20:52:21 +00001814 # Print the different message types in a consistent order. ERRORS go last
1815 # so that they will be most visible in the local-presubmit output.
1816 for name in ['Messages', 'Warnings', 'ERRORS']:
1817 if name in messages:
1818 items = messages[name]
Gavin Makd22bf602022-07-11 21:10:41 +00001819 sys.stdout.write('** Presubmit %s: %d **\n' % (name, len(items)))
Bruce Dawson76fe1a72022-05-25 20:52:21 +00001820 for item in items:
1821 item.handle()
1822 sys.stdout.write('\n')
pam@chromium.orged9a0832009-09-09 22:48:55 +00001823
Edward Lemurecc27072020-01-06 16:42:34 +00001824 total_time = time_time() - start_time
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001825 if total_time > 1.0:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001826 sys.stdout.write(
Louis Romero4ca9e1c2022-03-10 10:29:11 +00001827 'Presubmit checks took %.1fs to calculate.\n' % total_time)
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +00001828
Edward Lemur6eb1d322020-02-27 22:20:15 +00001829 if not should_prompt and not presubmits_failed:
Louis Romero4ca9e1c2022-03-10 10:29:11 +00001830 sys.stdout.write('%s presubmit checks passed.\n\n' % python_version)
Josip Sokcevic7592e0a2022-01-12 00:57:54 +00001831 elif should_prompt and not presubmits_failed:
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001832 sys.stdout.write('There were %s presubmit warnings. ' % python_version)
Quinten Yearsley516fe7f2016-12-14 11:50:18 -08001833 if may_prompt:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001834 presubmits_failed = not prompt_should_continue(
1835 'Are you sure you wish to continue? (y/N): ')
Garrett Beatyacb807e2020-08-28 18:17:24 +00001836 else:
1837 sys.stdout.write('\n')
Bruce Dawson76fe1a72022-05-25 20:52:21 +00001838 else:
1839 sys.stdout.write('There were %s presubmit errors.\n' % python_version)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001840
Edward Lemur1dc66e12020-02-21 21:36:34 +00001841 if json_output:
1842 # Write the presubmit results to json output
1843 presubmit_results = {
1844 'errors': [
Edward Lemur6eb1d322020-02-27 22:20:15 +00001845 error.json_format()
1846 for error in messages.get('ERRORS', [])
Edward Lemur1dc66e12020-02-21 21:36:34 +00001847 ],
1848 'notifications': [
Edward Lemur6eb1d322020-02-27 22:20:15 +00001849 notification.json_format()
1850 for notification in messages.get('Messages', [])
Edward Lemur1dc66e12020-02-21 21:36:34 +00001851 ],
1852 'warnings': [
Edward Lemur6eb1d322020-02-27 22:20:15 +00001853 warning.json_format()
1854 for warning in messages.get('Warnings', [])
Edward Lemur1dc66e12020-02-21 21:36:34 +00001855 ],
Edward Lemur6eb1d322020-02-27 22:20:15 +00001856 'more_cc': executer.more_cc,
Josip Sokcevic632bbc02022-05-19 05:32:50 +00001857 'skipped_presubmits': skipped_count,
Edward Lemur1dc66e12020-02-21 21:36:34 +00001858 }
1859
1860 gclient_utils.FileWrite(
1861 json_output, json.dumps(presubmit_results, sort_keys=True))
1862
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001863 global _ASKED_FOR_FEEDBACK
1864 # Ask for feedback one time out of 5.
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +00001865 if (results and random.randint(0, 4) == 0 and not _ASKED_FOR_FEEDBACK):
Edward Lemur6eb1d322020-02-27 22:20:15 +00001866 sys.stdout.write(
maruel@chromium.org1ce8e662014-01-14 15:23:00 +00001867 'Was the presubmit check useful? If not, run "git cl presubmit -v"\n'
1868 'to figure out which PRESUBMIT.py was run, then run git blame\n'
1869 'on the file to figure out who to ask for help.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001870 _ASKED_FOR_FEEDBACK = True
Edward Lemur6eb1d322020-02-27 22:20:15 +00001871
1872 return 1 if presubmits_failed else 0
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001873 finally:
1874 os.environ = old_environ
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001875
1876
Edward Lemur50984a62020-02-06 18:10:18 +00001877def _scan_sub_dirs(mask, recursive):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001878 if not recursive:
pgervais@chromium.orge57b09d2014-05-07 00:58:13 +00001879 return [x for x in glob.glob(mask) if x not in ('.svn', '.git')]
Lei Zhang9611c4c2017-04-04 01:41:56 -07001880
1881 results = []
1882 for root, dirs, files in os.walk('.'):
1883 if '.svn' in dirs:
1884 dirs.remove('.svn')
1885 if '.git' in dirs:
1886 dirs.remove('.git')
1887 for name in files:
1888 if fnmatch.fnmatch(name, mask):
1889 results.append(os.path.join(root, name))
1890 return results
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001891
1892
Edward Lemur50984a62020-02-06 18:10:18 +00001893def _parse_files(args, recursive):
tobiasjs2836bcf2016-08-16 04:08:16 -07001894 logging.debug('Searching for %s', args)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001895 files = []
1896 for arg in args:
Edward Lemur50984a62020-02-06 18:10:18 +00001897 files.extend([('M', f) for f in _scan_sub_dirs(arg, recursive)])
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001898 return files
1899
1900
Edward Lemur50984a62020-02-06 18:10:18 +00001901def _parse_change(parser, options):
1902 """Process change options.
1903
1904 Args:
1905 parser: The parser used to parse the arguments from command line.
1906 options: The arguments parsed from command line.
1907 Returns:
1908 A GitChange if the change root is a git repository, or a Change otherwise.
1909 """
1910 if options.files and options.all_files:
1911 parser.error('<files> cannot be specified when --all-files is set.')
1912
Edward Lesmes44ea3ff2020-02-05 00:14:30 +00001913 change_scm = scm.determine_scm(options.root)
Edward Lemur50984a62020-02-06 18:10:18 +00001914 if change_scm != 'git' and not options.files:
1915 parser.error('<files> is not optional for unversioned directories.')
1916
1917 if options.files:
Josip Sokcevic017544d2022-03-31 23:47:53 +00001918 if options.source_controlled_only:
1919 # Get the filtered set of files from SCM.
1920 change_files = []
1921 for name in scm.GIT.GetAllFiles(options.root):
1922 for mask in options.files:
1923 if fnmatch.fnmatch(name, mask):
1924 change_files.append(('M', name))
1925 break
1926 else:
1927 # Get the filtered set of files from a directory scan.
1928 change_files = _parse_files(options.files, options.recursive)
Edward Lemur50984a62020-02-06 18:10:18 +00001929 elif options.all_files:
1930 change_files = [('M', f) for f in scm.GIT.GetAllFiles(options.root)]
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001931 else:
Edward Lemur50984a62020-02-06 18:10:18 +00001932 change_files = scm.GIT.CaptureStatus(
Edward Lemur7f6dec02020-02-06 20:23:58 +00001933 options.root, options.upstream or None)
Edward Lemur50984a62020-02-06 18:10:18 +00001934
1935 logging.info('Found %d file(s).', len(change_files))
1936
1937 change_class = GitChange if change_scm == 'git' else Change
1938 return change_class(
1939 options.name,
1940 options.description,
1941 options.root,
1942 change_files,
1943 options.issue,
1944 options.patchset,
1945 options.author,
1946 upstream=options.upstream)
1947
1948
1949def _parse_gerrit_options(parser, options):
1950 """Process gerrit options.
1951
1952 SIDE EFFECTS: Modifies options.author and options.description from Gerrit if
1953 options.gerrit_fetch is set.
1954
1955 Args:
1956 parser: The parser used to parse the arguments from command line.
1957 options: The arguments parsed from command line.
1958 Returns:
Stephen Martinisfb09de22021-02-25 03:41:13 +00001959 A GerritAccessor object if options.gerrit_url is set, or None otherwise.
Edward Lemur50984a62020-02-06 18:10:18 +00001960 """
1961 gerrit_obj = None
Stephen Martinisfb09de22021-02-25 03:41:13 +00001962 if options.gerrit_url:
Edward Lesmeseb1bd622021-03-01 19:54:07 +00001963 gerrit_obj = GerritAccessor(
1964 url=options.gerrit_url,
1965 project=options.gerrit_project,
1966 branch=options.gerrit_branch)
Edward Lemur50984a62020-02-06 18:10:18 +00001967
1968 if not options.gerrit_fetch:
1969 return gerrit_obj
1970
1971 if not options.gerrit_url or not options.issue or not options.patchset:
1972 parser.error(
1973 '--gerrit_fetch requires --gerrit_url, --issue and --patchset.')
1974
1975 options.author = gerrit_obj.GetChangeOwner(options.issue)
1976 options.description = gerrit_obj.GetChangeDescription(
1977 options.issue, options.patchset)
1978
1979 logging.info('Got author: "%s"', options.author)
1980 logging.info('Got description: """\n%s\n"""', options.description)
1981
1982 return gerrit_obj
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001983
1984
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001985@contextlib.contextmanager
1986def canned_check_filter(method_names):
1987 filtered = {}
1988 try:
1989 for method_name in method_names:
1990 if not hasattr(presubmit_canned_checks, method_name):
Gavin Make6a62332020-12-04 21:57:10 +00001991 logging.warning('Skipping unknown "canned" check %s' % method_name)
Aaron Gableecee74c2018-04-02 15:13:08 -07001992 continue
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001993 filtered[method_name] = getattr(presubmit_canned_checks, method_name)
1994 setattr(presubmit_canned_checks, method_name, lambda *_a, **_kw: [])
1995 yield
1996 finally:
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001997 for name, method in filtered.items():
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001998 setattr(presubmit_canned_checks, name, method)
1999
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +00002000
sbc@chromium.org013731e2015-02-26 18:28:43 +00002001def main(argv=None):
Edward Lemura5799e32020-01-17 19:26:51 +00002002 parser = argparse.ArgumentParser(usage='%(prog)s [options] <files...>')
2003 hooks = parser.add_mutually_exclusive_group()
2004 hooks.add_argument('-c', '--commit', action='store_true',
2005 help='Use commit instead of upload checks.')
2006 hooks.add_argument('-u', '--upload', action='store_false', dest='commit',
2007 help='Use upload instead of commit checks.')
Edward Lemur75526302020-02-27 22:31:05 +00002008 hooks.add_argument('--post_upload', action='store_true',
2009 help='Run post-upload commit hooks.')
Edward Lemura5799e32020-01-17 19:26:51 +00002010 parser.add_argument('-r', '--recursive', action='store_true',
2011 help='Act recursively.')
2012 parser.add_argument('-v', '--verbose', action='count', default=0,
2013 help='Use 2 times for more debug info.')
2014 parser.add_argument('--name', default='no name')
2015 parser.add_argument('--author')
Edward Lemur227d5102020-02-25 23:45:35 +00002016 desc = parser.add_mutually_exclusive_group()
2017 desc.add_argument('--description', default='', help='The change description.')
2018 desc.add_argument('--description_file',
2019 help='File to read change description from.')
Edward Lemura5799e32020-01-17 19:26:51 +00002020 parser.add_argument('--issue', type=int, default=0)
2021 parser.add_argument('--patchset', type=int, default=0)
2022 parser.add_argument('--root', default=os.getcwd(),
2023 help='Search for PRESUBMIT.py up to this directory. '
2024 'If inherit-review-settings-ok is present in this '
2025 'directory, parent directories up to the root file '
2026 'system directories will also be searched.')
2027 parser.add_argument('--upstream',
2028 help='Git only: the base ref or upstream branch against '
2029 'which the diff should be computed.')
2030 parser.add_argument('--default_presubmit')
2031 parser.add_argument('--may_prompt', action='store_true', default=False)
2032 parser.add_argument('--skip_canned', action='append', default=[],
2033 help='A list of checks to skip which appear in '
2034 'presubmit_canned_checks. Can be provided multiple times '
2035 'to skip multiple canned checks.')
2036 parser.add_argument('--dry_run', action='store_true', help=argparse.SUPPRESS)
2037 parser.add_argument('--gerrit_url', help=argparse.SUPPRESS)
Edward Lesmeseb1bd622021-03-01 19:54:07 +00002038 parser.add_argument('--gerrit_project', help=argparse.SUPPRESS)
2039 parser.add_argument('--gerrit_branch', help=argparse.SUPPRESS)
Edward Lemura5799e32020-01-17 19:26:51 +00002040 parser.add_argument('--gerrit_fetch', action='store_true',
2041 help=argparse.SUPPRESS)
2042 parser.add_argument('--parallel', action='store_true',
2043 help='Run all tests specified by input_api.RunTests in '
2044 'all PRESUBMIT files in parallel.')
2045 parser.add_argument('--json_output',
2046 help='Write presubmit errors to json output.')
Edward Lemur1dc66e12020-02-21 21:36:34 +00002047 parser.add_argument('--all_files', action='store_true',
Edward Lemur50984a62020-02-06 18:10:18 +00002048 help='Mark all files under source control as modified.')
Bruce Dawson09c0c072022-05-26 20:28:58 +00002049
Edward Lemura5799e32020-01-17 19:26:51 +00002050 parser.add_argument('files', nargs='*',
2051 help='List of files to be marked as modified when '
2052 'executing presubmit or post-upload hooks. fnmatch '
2053 'wildcards can also be used.')
Josip Sokcevic017544d2022-03-31 23:47:53 +00002054 parser.add_argument('--source_controlled_only', action='store_true',
2055 help='Constrain \'files\' to those in source control.')
Dirk Pranke6f0df682021-06-25 00:42:33 +00002056 parser.add_argument('--use-python3', action='store_true',
2057 help='Use python3 for presubmit checks by default')
Bruce Dawson09c0c072022-05-26 20:28:58 +00002058 parser.add_argument('--no_diffs', action='store_true',
2059 help='Assume that all "modified" files have no diffs.')
Edward Lemura5799e32020-01-17 19:26:51 +00002060 options = parser.parse_args(argv)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00002061
Erik Staabcca5c492020-04-16 17:40:07 +00002062 log_level = logging.ERROR
maruel@chromium.org899e1c12011-04-07 17:03:18 +00002063 if options.verbose >= 2:
Erik Staabcca5c492020-04-16 17:40:07 +00002064 log_level = logging.DEBUG
maruel@chromium.org899e1c12011-04-07 17:03:18 +00002065 elif options.verbose:
Erik Staabcca5c492020-04-16 17:40:07 +00002066 log_level = logging.INFO
2067 log_format = ('[%(levelname).1s%(asctime)s %(process)d %(thread)d '
2068 '%(filename)s] %(message)s')
2069 logging.basicConfig(format=log_format, level=log_level)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00002070
Bruce Dawsondca14bc2022-09-15 20:59:38 +00002071 # Print call stacks when _PresubmitResult objects are created with -v -v is
2072 # specified. This helps track down where presubmit messages are coming from.
2073 if options.verbose >= 2:
2074 global _SHOW_CALLSTACKS
2075 _SHOW_CALLSTACKS = True
2076
Edward Lemur227d5102020-02-25 23:45:35 +00002077 if options.description_file:
2078 options.description = gclient_utils.FileRead(options.description_file)
Edward Lemur50984a62020-02-06 18:10:18 +00002079 gerrit_obj = _parse_gerrit_options(parser, options)
2080 change = _parse_change(parser, options)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00002081
maruel@chromium.org899e1c12011-04-07 17:03:18 +00002082 try:
Edward Lemur75526302020-02-27 22:31:05 +00002083 if options.post_upload:
Josip Sokcevice293d3d2022-02-16 22:52:15 +00002084 return DoPostUploadExecuter(change, gerrit_obj, options.verbose,
2085 options.use_python3)
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00002086 with canned_check_filter(options.skip_canned):
Edward Lemur6eb1d322020-02-27 22:20:15 +00002087 return DoPresubmitChecks(
Edward Lemur50984a62020-02-06 18:10:18 +00002088 change,
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00002089 options.commit,
2090 options.verbose,
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00002091 options.default_presubmit,
2092 options.may_prompt,
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00002093 gerrit_obj,
Edward Lesmes8e282792018-04-03 18:50:29 -04002094 options.dry_run,
Debrian Figueroadd2737e2019-06-21 23:50:13 +00002095 options.parallel,
Dirk Pranke6f0df682021-06-25 00:42:33 +00002096 options.json_output,
Bruce Dawson09c0c072022-05-26 20:28:58 +00002097 options.use_python3,
2098 options.no_diffs)
Raul Tambre7c938462019-05-24 16:35:35 +00002099 except PresubmitFailure as e:
Josip Sokcevic0399e172022-03-21 23:11:51 +00002100 import utils
Raul Tambre80ee78e2019-05-06 22:41:05 +00002101 print(e, file=sys.stderr)
2102 print('Maybe your depot_tools is out of date?', file=sys.stderr)
Josip Sokcevic0399e172022-03-21 23:11:51 +00002103 print('depot_tools version: %s' % utils.depot_tools_version(),
2104 file=sys.stderr)
maruel@chromium.org899e1c12011-04-07 17:03:18 +00002105 return 2
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00002106
2107
2108if __name__ == '__main__':
maruel@chromium.org35625c72011-03-23 17:34:02 +00002109 fix_encoding.fix_encoding()
sbc@chromium.org013731e2015-02-26 18:28:43 +00002110 try:
2111 sys.exit(main())
2112 except KeyboardInterrupt:
2113 sys.stderr.write('interrupted\n')
sergiybf8a3b382016-07-05 11:21:30 -07002114 sys.exit(2)