blob: c84933151a86428de518ca86f19ecf1f73b4f71a [file] [log] [blame]
maruel@chromium.org725f1c32011-04-01 20:24:54 +00001#!/usr/bin/env python
maruel@chromium.org3bbf2942012-01-10 16:52:06 +00002# Copyright (c) 2012 The Chromium Authors. All rights reserved.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00003# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5
6"""Enables directory-specific presubmit checks to run at upload and/or commit.
7"""
8
Raul Tambre80ee78e2019-05-06 22:41:05 +00009from __future__ import print_function
10
Saagar Sanghavi99816902020-08-11 22:41:25 +000011__version__ = '2.0.0'
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000012
13# TODO(joi) Add caching where appropriate/needed. The API is designed to allow
14# caching (between all different invocations of presubmit scripts for a given
15# change). We should add it as our presubmit scripts start feeling slow.
16
Edward Lemura5799e32020-01-17 19:26:51 +000017import argparse
Takeshi Yoshino07a6bea2017-08-02 02:44:06 +090018import ast # Exposed through the API.
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +000019import contextlib
Yoshisato Yanagisawa406de132018-06-29 05:43:25 +000020import cpplint
dcheng091b7db2016-06-16 01:27:51 -070021import fnmatch # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000022import glob
asvitkine@chromium.org15169952011-09-27 14:30:53 +000023import inspect
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +000024import itertools
maruel@chromium.org4f6852c2012-04-20 20:39:20 +000025import json # Exposed through the API.
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +000026import logging
ilevy@chromium.orgbc117312013-04-20 03:57:56 +000027import multiprocessing
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000028import os # Somewhat exposed through the API.
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +000029import random
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000030import re # Exposed through the API.
Edward Lesmes8e282792018-04-03 18:50:29 -040031import signal
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000032import sys # Parts exposed through API.
33import tempfile # Exposed through the API.
Edward Lesmes8e282792018-04-03 18:50:29 -040034import threading
jam@chromium.org2a891dc2009-08-20 20:33:37 +000035import time
Edward Lemurde9e3ca2019-10-24 21:13:31 +000036import traceback
maruel@chromium.org1487d532009-06-06 00:22:57 +000037import unittest # Exposed through the API.
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +000038from warnings import warn
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000039
40# Local imports.
maruel@chromium.org35625c72011-03-23 17:34:02 +000041import fix_encoding
Yoshisato Yanagisawa04600b42019-03-15 03:03:41 +000042import gclient_paths # Exposed through the API
43import gclient_utils
Aaron Gableb584c4f2017-04-26 16:28:08 -070044import git_footers
tandrii@chromium.org015ebae2016-04-25 19:37:22 +000045import gerrit_util
dpranke@chromium.org2a009622011-03-01 02:43:31 +000046import owners
Jochen Eisinger76f5fc62017-04-07 16:27:46 +020047import owners_finder
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000048import presubmit_canned_checks
Saagar Sanghavi9949ab72020-07-20 20:56:40 +000049import rdb_wrapper
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +000050import scm
maruel@chromium.org84f4fe32011-04-06 13:26:45 +000051import subprocess2 as subprocess # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000052
Edward Lemur16af3562019-10-17 22:11:33 +000053if sys.version_info.major == 2:
54 # TODO(1009814): Expose urllib2 only through urllib_request and urllib_error
55 import urllib2 # Exposed through the API.
56 import urlparse
57 import urllib2 as urllib_request
58 import urllib2 as urllib_error
59else:
60 import urllib.parse as urlparse
61 import urllib.request as urllib_request
62 import urllib.error as urllib_error
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000063
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +000064# Ask for feedback only once in program lifetime.
65_ASKED_FOR_FEEDBACK = False
66
Edward Lemurecc27072020-01-06 16:42:34 +000067def time_time():
68 # Use this so that it can be mocked in tests without interfering with python
69 # system machinery.
70 return time.time()
71
72
maruel@chromium.org899e1c12011-04-07 17:03:18 +000073class PresubmitFailure(Exception):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000074 pass
75
76
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000077class CommandData(object):
Edward Lemur940c2822019-08-23 00:34:25 +000078 def __init__(self, name, cmd, kwargs, message, python3=False):
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000079 self.name = name
80 self.cmd = cmd
Edward Lesmes8e282792018-04-03 18:50:29 -040081 self.stdin = kwargs.get('stdin', None)
Edward Lemur2d6b67c2019-08-23 22:25:41 +000082 self.kwargs = kwargs.copy()
Edward Lesmes8e282792018-04-03 18:50:29 -040083 self.kwargs['stdout'] = subprocess.PIPE
84 self.kwargs['stderr'] = subprocess.STDOUT
85 self.kwargs['stdin'] = subprocess.PIPE
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000086 self.message = message
87 self.info = None
Edward Lemur940c2822019-08-23 00:34:25 +000088 self.python3 = python3
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000089
ilevy@chromium.orgbc117312013-04-20 03:57:56 +000090
Edward Lesmes8e282792018-04-03 18:50:29 -040091# Adapted from
92# https://github.com/google/gtest-parallel/blob/master/gtest_parallel.py#L37
93#
94# An object that catches SIGINT sent to the Python process and notices
95# if processes passed to wait() die by SIGINT (we need to look for
96# both of those cases, because pressing Ctrl+C can result in either
97# the main process or one of the subprocesses getting the signal).
98#
99# Before a SIGINT is seen, wait(p) will simply call p.wait() and
100# return the result. Once a SIGINT has been seen (in the main process
101# or a subprocess, including the one the current call is waiting for),
Edward Lemur9a5bb612019-09-26 02:01:52 +0000102# wait(p) will call p.terminate().
Edward Lesmes8e282792018-04-03 18:50:29 -0400103class SigintHandler(object):
Edward Lesmes8e282792018-04-03 18:50:29 -0400104 sigint_returncodes = {-signal.SIGINT, # Unix
105 -1073741510, # Windows
106 }
107 def __init__(self):
108 self.__lock = threading.Lock()
109 self.__processes = set()
110 self.__got_sigint = False
Edward Lemur9a5bb612019-09-26 02:01:52 +0000111 self.__previous_signal = signal.signal(signal.SIGINT, self.interrupt)
Edward Lesmes8e282792018-04-03 18:50:29 -0400112
113 def __on_sigint(self):
114 self.__got_sigint = True
115 while self.__processes:
116 try:
117 self.__processes.pop().terminate()
118 except OSError:
119 pass
120
Edward Lemur9a5bb612019-09-26 02:01:52 +0000121 def interrupt(self, signal_num, frame):
Edward Lesmes8e282792018-04-03 18:50:29 -0400122 with self.__lock:
123 self.__on_sigint()
Edward Lemur9a5bb612019-09-26 02:01:52 +0000124 self.__previous_signal(signal_num, frame)
Edward Lesmes8e282792018-04-03 18:50:29 -0400125
126 def got_sigint(self):
127 with self.__lock:
128 return self.__got_sigint
129
130 def wait(self, p, stdin):
131 with self.__lock:
132 if self.__got_sigint:
133 p.terminate()
134 self.__processes.add(p)
135 stdout, stderr = p.communicate(stdin)
136 code = p.returncode
137 with self.__lock:
138 self.__processes.discard(p)
139 if code in self.sigint_returncodes:
140 self.__on_sigint()
Edward Lesmes8e282792018-04-03 18:50:29 -0400141 return stdout, stderr
142
143sigint_handler = SigintHandler()
144
145
Edward Lemurecc27072020-01-06 16:42:34 +0000146class Timer(object):
147 def __init__(self, timeout, fn):
148 self.completed = False
149 self._fn = fn
150 self._timer = threading.Timer(timeout, self._onTimer) if timeout else None
151
152 def __enter__(self):
153 if self._timer:
154 self._timer.start()
155 return self
156
157 def __exit__(self, _type, _value, _traceback):
158 if self._timer:
159 self._timer.cancel()
160
161 def _onTimer(self):
162 self._fn()
163 self.completed = True
164
165
Edward Lesmes8e282792018-04-03 18:50:29 -0400166class ThreadPool(object):
Edward Lemurecc27072020-01-06 16:42:34 +0000167 def __init__(self, pool_size=None, timeout=None):
168 self.timeout = timeout
Edward Lesmes8e282792018-04-03 18:50:29 -0400169 self._pool_size = pool_size or multiprocessing.cpu_count()
170 self._messages = []
171 self._messages_lock = threading.Lock()
172 self._tests = []
173 self._tests_lock = threading.Lock()
174 self._nonparallel_tests = []
175
Edward Lemurecc27072020-01-06 16:42:34 +0000176 def _GetCommand(self, test):
Edward Lemur940c2822019-08-23 00:34:25 +0000177 vpython = 'vpython'
178 if test.python3:
179 vpython += '3'
180 if sys.platform == 'win32':
181 vpython += '.bat'
Edward Lesmes8e282792018-04-03 18:50:29 -0400182
183 cmd = test.cmd
184 if cmd[0] == 'python':
185 cmd = list(cmd)
186 cmd[0] = vpython
187 elif cmd[0].endswith('.py'):
188 cmd = [vpython] + cmd
189
Edward Lemur336e51f2019-11-14 21:42:04 +0000190 # On Windows, scripts on the current directory take precedence over PATH, so
191 # that when testing depot_tools on Windows, calling `vpython.bat` will
192 # execute the copy of vpython of the depot_tools under test instead of the
193 # one in the bot.
194 # As a workaround, we run the tests from the parent directory instead.
195 if (cmd[0] == vpython and
196 'cwd' in test.kwargs and
197 os.path.basename(test.kwargs['cwd']) == 'depot_tools'):
198 test.kwargs['cwd'] = os.path.dirname(test.kwargs['cwd'])
199 cmd[1] = os.path.join('depot_tools', cmd[1])
200
Edward Lemurecc27072020-01-06 16:42:34 +0000201 return cmd
202
203 def _RunWithTimeout(self, cmd, stdin, kwargs):
204 p = subprocess.Popen(cmd, **kwargs)
205 with Timer(self.timeout, p.terminate) as timer:
206 stdout, _ = sigint_handler.wait(p, stdin)
207 if timer.completed:
208 stdout = 'Process timed out after %ss\n%s' % (self.timeout, stdout)
209 return p.returncode, stdout
210
211 def CallCommand(self, test):
212 """Runs an external program.
213
Edward Lemura5799e32020-01-17 19:26:51 +0000214 This function converts invocation of .py files and invocations of 'python'
Edward Lemurecc27072020-01-06 16:42:34 +0000215 to vpython invocations.
216 """
217 cmd = self._GetCommand(test)
Edward Lesmes8e282792018-04-03 18:50:29 -0400218 try:
Edward Lemurecc27072020-01-06 16:42:34 +0000219 start = time_time()
220 returncode, stdout = self._RunWithTimeout(cmd, test.stdin, test.kwargs)
221 duration = time_time() - start
Edward Lemur7cf94382019-11-15 22:36:41 +0000222 except Exception:
Edward Lemurecc27072020-01-06 16:42:34 +0000223 duration = time_time() - start
Edward Lesmes8e282792018-04-03 18:50:29 -0400224 return test.message(
Edward Lemur7cf94382019-11-15 22:36:41 +0000225 '%s\n%s exec failure (%4.2fs)\n%s' % (
226 test.name, ' '.join(cmd), duration, traceback.format_exc()))
Edward Lemurde9e3ca2019-10-24 21:13:31 +0000227
Edward Lemurecc27072020-01-06 16:42:34 +0000228 if returncode != 0:
Edward Lesmes8e282792018-04-03 18:50:29 -0400229 return test.message(
Edward Lemur7cf94382019-11-15 22:36:41 +0000230 '%s\n%s (%4.2fs) failed\n%s' % (
231 test.name, ' '.join(cmd), duration, stdout))
Edward Lemurecc27072020-01-06 16:42:34 +0000232
Edward Lesmes8e282792018-04-03 18:50:29 -0400233 if test.info:
Edward Lemur7cf94382019-11-15 22:36:41 +0000234 return test.info('%s\n%s (%4.2fs)' % (test.name, ' '.join(cmd), duration))
Edward Lesmes8e282792018-04-03 18:50:29 -0400235
236 def AddTests(self, tests, parallel=True):
237 if parallel:
238 self._tests.extend(tests)
239 else:
240 self._nonparallel_tests.extend(tests)
241
242 def RunAsync(self):
243 self._messages = []
244
245 def _WorkerFn():
246 while True:
247 test = None
248 with self._tests_lock:
249 if not self._tests:
250 break
251 test = self._tests.pop()
252 result = self.CallCommand(test)
253 if result:
254 with self._messages_lock:
255 self._messages.append(result)
256
257 def _StartDaemon():
258 t = threading.Thread(target=_WorkerFn)
259 t.daemon = True
260 t.start()
261 return t
262
263 while self._nonparallel_tests:
264 test = self._nonparallel_tests.pop()
265 result = self.CallCommand(test)
266 if result:
267 self._messages.append(result)
268
269 if self._tests:
270 threads = [_StartDaemon() for _ in range(self._pool_size)]
271 for worker in threads:
272 worker.join()
273
274 return self._messages
275
276
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000277def normpath(path):
278 '''Version of os.path.normpath that also changes backward slashes to
279 forward slashes when not running on Windows.
280 '''
281 # This is safe to always do because the Windows version of os.path.normpath
282 # will replace forward slashes with backward slashes.
283 path = path.replace(os.sep, '/')
284 return os.path.normpath(path)
285
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000286
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000287def _RightHandSideLinesImpl(affected_files):
288 """Implements RightHandSideLines for InputApi and GclChange."""
289 for af in affected_files:
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000290 lines = af.ChangedContents()
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000291 for line in lines:
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000292 yield (af, line[0], line[1])
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000293
294
Edward Lemur6eb1d322020-02-27 22:20:15 +0000295def prompt_should_continue(prompt_string):
296 sys.stdout.write(prompt_string)
297 response = sys.stdin.readline().strip().lower()
298 return response in ('y', 'yes')
dpranke@chromium.org5ac21012011-03-16 02:58:25 +0000299
300
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000301# Top level object so multiprocessing can pickle
302# Public access through OutputApi object.
303class _PresubmitResult(object):
304 """Base class for result objects."""
305 fatal = False
306 should_prompt = False
307
308 def __init__(self, message, items=None, long_text=''):
309 """
310 message: A short one-line message to indicate errors.
311 items: A list of short strings to indicate where errors occurred.
312 long_text: multi-line text output, e.g. from another tool
313 """
314 self._message = message
315 self._items = items or []
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000316 self._long_text = long_text.rstrip()
317
Edward Lemur6eb1d322020-02-27 22:20:15 +0000318 def handle(self):
319 sys.stdout.write(self._message)
320 sys.stdout.write('\n')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000321 for index, item in enumerate(self._items):
Edward Lemur6eb1d322020-02-27 22:20:15 +0000322 sys.stdout.write(' ')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000323 # Write separately in case it's unicode.
Edward Lemur6eb1d322020-02-27 22:20:15 +0000324 sys.stdout.write(str(item))
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000325 if index < len(self._items) - 1:
Edward Lemur6eb1d322020-02-27 22:20:15 +0000326 sys.stdout.write(' \\')
327 sys.stdout.write('\n')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000328 if self._long_text:
Edward Lemur6eb1d322020-02-27 22:20:15 +0000329 sys.stdout.write('\n***************\n')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000330 # Write separately in case it's unicode.
Edward Lemur6eb1d322020-02-27 22:20:15 +0000331 sys.stdout.write(self._long_text)
332 sys.stdout.write('\n***************\n')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000333
Debrian Figueroadd2737e2019-06-21 23:50:13 +0000334 def json_format(self):
335 return {
336 'message': self._message,
Debrian Figueroa6095d402019-06-28 18:47:18 +0000337 'items': [str(item) for item in self._items],
Debrian Figueroadd2737e2019-06-21 23:50:13 +0000338 'long_text': self._long_text,
339 'fatal': self.fatal
340 }
341
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000342
343# Top level object so multiprocessing can pickle
344# Public access through OutputApi object.
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000345class _PresubmitError(_PresubmitResult):
346 """A hard presubmit error."""
347 fatal = True
348
349
350# Top level object so multiprocessing can pickle
351# Public access through OutputApi object.
352class _PresubmitPromptWarning(_PresubmitResult):
353 """An warning that prompts the user if they want to continue."""
354 should_prompt = True
355
356
357# Top level object so multiprocessing can pickle
358# Public access through OutputApi object.
359class _PresubmitNotifyResult(_PresubmitResult):
360 """Just print something to the screen -- but it's not even a warning."""
361 pass
362
363
364# Top level object so multiprocessing can pickle
365# Public access through OutputApi object.
366class _MailTextResult(_PresubmitResult):
367 """A warning that should be included in the review request email."""
368 def __init__(self, *args, **kwargs):
369 super(_MailTextResult, self).__init__()
370 raise NotImplementedError()
371
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000372class GerritAccessor(object):
373 """Limited Gerrit functionality for canned presubmit checks to work.
374
375 To avoid excessive Gerrit calls, caches the results.
376 """
377
378 def __init__(self, host):
379 self.host = host
380 self.cache = {}
381
382 def _FetchChangeDetail(self, issue):
383 # Separate function to be easily mocked in tests.
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +0100384 try:
385 return gerrit_util.GetChangeDetail(
386 self.host, str(issue),
Aaron Gable6f5a8d92017-04-18 14:49:05 -0700387 ['ALL_REVISIONS', 'DETAILED_LABELS', 'ALL_COMMITS'])
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +0100388 except gerrit_util.GerritError as e:
389 if e.http_status == 404:
390 raise Exception('Either Gerrit issue %s doesn\'t exist, or '
391 'no credentials to fetch issue details' % issue)
392 raise
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000393
394 def GetChangeInfo(self, issue):
395 """Returns labels and all revisions (patchsets) for this issue.
396
397 The result is a dictionary according to Gerrit REST Api.
398 https://gerrit-review.googlesource.com/Documentation/rest-api.html
399
400 However, API isn't very clear what's inside, so see tests for example.
401 """
402 assert issue
403 cache_key = int(issue)
404 if cache_key not in self.cache:
405 self.cache[cache_key] = self._FetchChangeDetail(issue)
406 return self.cache[cache_key]
407
408 def GetChangeDescription(self, issue, patchset=None):
409 """If patchset is none, fetches current patchset."""
410 info = self.GetChangeInfo(issue)
411 # info is a reference to cache. We'll modify it here adding description to
412 # it to the right patchset, if it is not yet there.
413
414 # Find revision info for the patchset we want.
415 if patchset is not None:
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +0000416 for rev, rev_info in info['revisions'].items():
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000417 if str(rev_info['_number']) == str(patchset):
418 break
419 else:
420 raise Exception('patchset %s doesn\'t exist in issue %s' % (
421 patchset, issue))
422 else:
423 rev = info['current_revision']
424 rev_info = info['revisions'][rev]
425
Andrii Shyshkalov9c3a4642017-01-24 17:41:22 +0100426 return rev_info['commit']['message']
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000427
Mun Yong Jang603d01e2017-12-19 16:38:30 -0800428 def GetDestRef(self, issue):
429 ref = self.GetChangeInfo(issue)['branch']
430 if not ref.startswith('refs/'):
431 # NOTE: it is possible to create 'refs/x' branch,
432 # aka 'refs/heads/refs/x'. However, this is ill-advised.
433 ref = 'refs/heads/%s' % ref
434 return ref
435
Edward Lesmes02d4b822020-11-11 00:37:35 +0000436 def _GetApproversForLabel(self, issue, label):
437 change_info = self.GetChangeInfo(issue)
438 label_info = change_info.get('labels', {}).get(label, {})
439 values = label_info.get('values', {}).keys()
440 if not values:
441 return []
442 max_value = max(int(v) for v in values)
443 return [v for v in label_info.get('all', [])
444 if v.get('value', 0) == max_value]
445
446 def IsBotCommitApproved(self, issue):
447 return bool(self._GetApproversForLabel(issue, 'Bot-Commit'))
448
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000449 def GetChangeOwner(self, issue):
450 return self.GetChangeInfo(issue)['owner']['email']
451
452 def GetChangeReviewers(self, issue, approving_only=True):
Aaron Gable8b478f02017-07-31 15:33:19 -0700453 changeinfo = self.GetChangeInfo(issue)
454 if approving_only:
Edward Lesmes02d4b822020-11-11 00:37:35 +0000455 reviewers = self._GetApproversForLabel(issue, 'Code-Review')
Aaron Gable8b478f02017-07-31 15:33:19 -0700456 else:
457 reviewers = changeinfo.get('reviewers', {}).get('REVIEWER', [])
458 return [r.get('email') for r in reviewers]
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000459
Edward Lemure4d329c2020-02-03 20:41:18 +0000460 def UpdateDescription(self, description, issue):
461 gerrit_util.SetCommitMessage(self.host, issue, description, notify='NONE')
462
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000463
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000464class OutputApi(object):
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000465 """An instance of OutputApi gets passed to presubmit scripts so that they
466 can output various types of results.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000467 """
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000468 PresubmitResult = _PresubmitResult
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000469 PresubmitError = _PresubmitError
470 PresubmitPromptWarning = _PresubmitPromptWarning
471 PresubmitNotifyResult = _PresubmitNotifyResult
472 MailTextResult = _MailTextResult
473
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000474 def __init__(self, is_committing):
475 self.is_committing = is_committing
Daniel Cheng7227d212017-11-17 08:12:37 -0800476 self.more_cc = []
477
478 def AppendCC(self, cc):
479 """Appends a user to cc for this change."""
480 self.more_cc.append(cc)
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000481
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000482 def PresubmitPromptOrNotify(self, *args, **kwargs):
483 """Warn the user when uploading, but only notify if committing."""
484 if self.is_committing:
485 return self.PresubmitNotifyResult(*args, **kwargs)
486 return self.PresubmitPromptWarning(*args, **kwargs)
487
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000488
489class InputApi(object):
490 """An instance of this object is passed to presubmit scripts so they can
491 know stuff about the change they're looking at.
492 """
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000493 # Method could be a function
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800494 # pylint: disable=no-self-use
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000495
maruel@chromium.org3410d912009-06-09 20:56:16 +0000496 # File extensions that are considered source files from a style guide
497 # perspective. Don't modify this list from a presubmit script!
maruel@chromium.orgc33455a2011-06-24 19:14:18 +0000498 #
499 # Files without an extension aren't included in the list. If you want to
local_bot30f774e2020-06-25 18:23:34 +0000500 # filter them as source files, add r'(^|.*?[\\\/])[^.]+$' to the allow list.
local_bot64021412020-07-08 21:05:39 +0000501 # Note that ALL CAPS files are skipped in DEFAULT_FILES_TO_SKIP below.
502 DEFAULT_FILES_TO_CHECK = (
maruel@chromium.org3410d912009-06-09 20:56:16 +0000503 # C++ and friends
Edward Lemura5799e32020-01-17 19:26:51 +0000504 r'.+\.c$', r'.+\.cc$', r'.+\.cpp$', r'.+\.h$', r'.+\.m$', r'.+\.mm$',
505 r'.+\.inl$', r'.+\.asm$', r'.+\.hxx$', r'.+\.hpp$', r'.+\.s$', r'.+\.S$',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000506 # Scripts
Edward Lemura5799e32020-01-17 19:26:51 +0000507 r'.+\.js$', r'.+\.py$', r'.+\.sh$', r'.+\.rb$', r'.+\.pl$', r'.+\.pm$',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000508 # Other
Edward Lemura5799e32020-01-17 19:26:51 +0000509 r'.+\.java$', r'.+\.mk$', r'.+\.am$', r'.+\.css$', r'.+\.mojom$',
510 r'.+\.fidl$'
maruel@chromium.org3410d912009-06-09 20:56:16 +0000511 )
512
513 # Path regexp that should be excluded from being considered containing source
514 # files. Don't modify this list from a presubmit script!
local_bot64021412020-07-08 21:05:39 +0000515 DEFAULT_FILES_TO_SKIP = (
Edward Lemura5799e32020-01-17 19:26:51 +0000516 r'testing_support[\\\/]google_appengine[\\\/].*',
517 r'.*\bexperimental[\\\/].*',
Kent Tamura179dd1e2018-04-26 15:07:41 +0900518 # Exclude third_party/.* but NOT third_party/{WebKit,blink}
519 # (crbug.com/539768 and crbug.com/836555).
Edward Lemura5799e32020-01-17 19:26:51 +0000520 r'.*\bthird_party[\\\/](?!(WebKit|blink)[\\\/]).*',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000521 # Output directories (just in case)
Edward Lemura5799e32020-01-17 19:26:51 +0000522 r'.*\bDebug[\\\/].*',
523 r'.*\bRelease[\\\/].*',
524 r'.*\bxcodebuild[\\\/].*',
525 r'.*\bout[\\\/].*',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000526 # All caps files like README and LICENCE.
Edward Lemura5799e32020-01-17 19:26:51 +0000527 r'.*\b[A-Z0-9_]{2,}$',
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +0000528 # SCM (can happen in dual SCM configuration). (Slightly over aggressive)
Edward Lemura5799e32020-01-17 19:26:51 +0000529 r'(|.*[\\\/])\.git[\\\/].*',
530 r'(|.*[\\\/])\.svn[\\\/].*',
maruel@chromium.org7ccb4bb2011-11-07 20:26:20 +0000531 # There is no point in processing a patch file.
Edward Lemura5799e32020-01-17 19:26:51 +0000532 r'.+\.diff$',
533 r'.+\.patch$',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000534 )
535
local_bot30f774e2020-06-25 18:23:34 +0000536 # TODO(https://crbug.com/1098562): Remove once no longer used
537 @property
538 def DEFAULT_WHITE_LIST(self):
local_bot64021412020-07-08 21:05:39 +0000539 return self.DEFAULT_FILES_TO_CHECK
local_bot30f774e2020-06-25 18:23:34 +0000540
541 # TODO(https://crbug.com/1098562): Remove once no longer used
local_bot37ce2012020-06-26 17:39:24 +0000542 @DEFAULT_WHITE_LIST.setter
543 def DEFAULT_WHITE_LIST(self, value):
local_bot64021412020-07-08 21:05:39 +0000544 self.DEFAULT_FILES_TO_CHECK = value
545
546 # TODO(https://crbug.com/1098562): Remove once no longer used
547 @property
548 def DEFAULT_ALLOW_LIST(self):
549 return self.DEFAULT_FILES_TO_CHECK
550
551 # TODO(https://crbug.com/1098562): Remove once no longer used
552 @DEFAULT_ALLOW_LIST.setter
553 def DEFAULT_ALLOW_LIST(self, value):
554 self.DEFAULT_FILES_TO_CHECK = value
local_bot37ce2012020-06-26 17:39:24 +0000555
556 # TODO(https://crbug.com/1098562): Remove once no longer used
local_bot30f774e2020-06-25 18:23:34 +0000557 @property
558 def DEFAULT_BLACK_LIST(self):
local_bot64021412020-07-08 21:05:39 +0000559 return self.DEFAULT_FILES_TO_SKIP
local_bot30f774e2020-06-25 18:23:34 +0000560
local_bot37ce2012020-06-26 17:39:24 +0000561 # TODO(https://crbug.com/1098562): Remove once no longer used
562 @DEFAULT_BLACK_LIST.setter
563 def DEFAULT_BLACK_LIST(self, value):
local_bot64021412020-07-08 21:05:39 +0000564 self.DEFAULT_FILES_TO_SKIP = value
565
566 # TODO(https://crbug.com/1098562): Remove once no longer used
567 @property
568 def DEFAULT_BLOCK_LIST(self):
569 return self.DEFAULT_FILES_TO_SKIP
570
571 # TODO(https://crbug.com/1098562): Remove once no longer used
572 @DEFAULT_BLOCK_LIST.setter
573 def DEFAULT_BLOCK_LIST(self, value):
574 self.DEFAULT_FILES_TO_SKIP = value
local_bot37ce2012020-06-26 17:39:24 +0000575
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000576 def __init__(self, change, presubmit_path, is_committing,
Edward Lesmes8e282792018-04-03 18:50:29 -0400577 verbose, gerrit_obj, dry_run=None, thread_pool=None, parallel=False):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000578 """Builds an InputApi object.
579
580 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000581 change: A presubmit.Change object.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000582 presubmit_path: The path to the presubmit script being processed.
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000583 is_committing: True if the change is about to be committed.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000584 gerrit_obj: provides basic Gerrit codereview functionality.
585 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -0400586 parallel: if true, all tests reported via input_api.RunTests for all
587 PRESUBMIT files will be run in parallel.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000588 """
maruel@chromium.org9711bba2009-05-22 23:51:39 +0000589 # Version number of the presubmit_support script.
590 self.version = [int(x) for x in __version__.split('.')]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000591 self.change = change
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000592 self.is_committing = is_committing
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000593 self.gerrit = gerrit_obj
tandrii@chromium.org57bafac2016-04-28 05:09:03 +0000594 self.dry_run = dry_run
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000595
Edward Lesmes8e282792018-04-03 18:50:29 -0400596 self.parallel = parallel
597 self.thread_pool = thread_pool or ThreadPool()
598
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000599 # We expose various modules and functions as attributes of the input_api
600 # so that presubmit scripts don't have to import them.
Takeshi Yoshino07a6bea2017-08-02 02:44:06 +0900601 self.ast = ast
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000602 self.basename = os.path.basename
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000603 self.cpplint = cpplint
dcheng091b7db2016-06-16 01:27:51 -0700604 self.fnmatch = fnmatch
Yoshisato Yanagisawa04600b42019-03-15 03:03:41 +0000605 self.gclient_paths = gclient_paths
Yoshisato Yanagisawa57dd17b2019-03-22 09:10:29 +0000606 # TODO(yyanagisawa): stop exposing this when python3 become default.
607 # Since python3's tempfile has TemporaryDirectory, we do not need this.
608 self.temporary_directory = gclient_utils.temporary_directory
dpranke@chromium.org17cc2442012-10-17 21:12:09 +0000609 self.glob = glob.glob
maruel@chromium.orgfb11c7b2010-03-18 18:22:14 +0000610 self.json = json
maruel@chromium.org6fba34d2011-06-02 13:45:12 +0000611 self.logging = logging.getLogger('PRESUBMIT')
maruel@chromium.org2b5ce562011-03-31 16:15:44 +0000612 self.os_listdir = os.listdir
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000613 self.os_path = os.path
pgervais@chromium.orgbd0cace2014-10-02 23:23:46 +0000614 self.os_stat = os.stat
Yoshisato Yanagisawa406de132018-06-29 05:43:25 +0000615 self.os_walk = os.walk
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000616 self.re = re
617 self.subprocess = subprocess
Edward Lemurb9830242019-10-30 22:19:20 +0000618 self.sys = sys
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000619 self.tempfile = tempfile
dpranke@chromium.org0d1bdea2011-03-24 22:54:38 +0000620 self.time = time
maruel@chromium.org1487d532009-06-06 00:22:57 +0000621 self.unittest = unittest
Edward Lemurb9830242019-10-30 22:19:20 +0000622 if sys.version_info.major == 2:
623 self.urllib2 = urllib2
Edward Lemur16af3562019-10-17 22:11:33 +0000624 self.urllib_request = urllib_request
625 self.urllib_error = urllib_error
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000626
Robert Iannucci50258932018-03-19 10:30:59 -0700627 self.is_windows = sys.platform == 'win32'
628
Edward Lemurb9646622019-10-25 20:57:35 +0000629 # Set python_executable to 'vpython' in order to allow scripts in other
630 # repos (e.g. src.git) to automatically pick up that repo's .vpython file,
631 # instead of inheriting the one in depot_tools.
632 self.python_executable = 'vpython'
maruel@chromium.orgc0b22972009-06-25 16:19:14 +0000633 self.environ = os.environ
634
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000635 # InputApi.platform is the platform you're currently running on.
636 self.platform = sys.platform
637
iannucci@chromium.org0af3bb32015-06-12 20:44:35 +0000638 self.cpu_count = multiprocessing.cpu_count()
639
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000640 # The local path of the currently-being-processed presubmit script.
maruel@chromium.org3d235242009-05-15 12:40:48 +0000641 self._current_presubmit_path = os.path.dirname(presubmit_path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000642
643 # We carry the canned checks so presubmit scripts can easily use them.
644 self.canned_checks = presubmit_canned_checks
645
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +0100646 # Temporary files we must manually remove at the end of a run.
647 self._named_temporary_files = []
Jochen Eisinger72606f82017-04-04 10:44:18 +0200648
dpranke@chromium.org2a009622011-03-01 02:43:31 +0000649 # TODO(dpranke): figure out a list of all approved owners for a repo
650 # in order to be able to handle wildcard OWNERS files?
651 self.owners_db = owners.Database(change.RepositoryRoot(),
Edward Lemurb9830242019-10-30 22:19:20 +0000652 fopen=open, os_path=self.os_path)
Jochen Eisinger76f5fc62017-04-07 16:27:46 +0200653 self.owners_finder = owners_finder.OwnersFinder
maruel@chromium.org899e1c12011-04-07 17:03:18 +0000654 self.verbose = verbose
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000655 self.Command = CommandData
dpranke@chromium.org2a009622011-03-01 02:43:31 +0000656
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000657 # Replace <hash_map> and <hash_set> as headers that need to be included
Edward Lemura5799e32020-01-17 19:26:51 +0000658 # with 'base/containers/hash_tables.h' instead.
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000659 # Access to a protected member _XX of a client class
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800660 # pylint: disable=protected-access
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000661 self.cpplint._re_pattern_templates = [
danakj@chromium.org18278522013-06-11 22:42:32 +0000662 (a, b, 'base/containers/hash_tables.h')
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000663 if header in ('<hash_map>', '<hash_set>') else (a, b, header)
664 for (a, b, header) in cpplint._re_pattern_templates
665 ]
666
Edward Lemurecc27072020-01-06 16:42:34 +0000667 def SetTimeout(self, timeout):
668 self.thread_pool.timeout = timeout
669
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000670 def PresubmitLocalPath(self):
671 """Returns the local path of the presubmit script currently being run.
672
673 This is useful if you don't want to hard-code absolute paths in the
674 presubmit script. For example, It can be used to find another file
675 relative to the PRESUBMIT.py script, so the whole tree can be branched and
676 the presubmit script still works, without editing its content.
677 """
maruel@chromium.org3d235242009-05-15 12:40:48 +0000678 return self._current_presubmit_path
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000679
agable0b65e732016-11-22 09:25:46 -0800680 def AffectedFiles(self, include_deletes=True, file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000681 """Same as input_api.change.AffectedFiles() except only lists files
682 (and optionally directories) in the same directory as the current presubmit
Bruce Dawson7a0b07a2020-04-23 17:14:40 +0000683 script, or subdirectories thereof. Note that files are listed using the OS
684 path separator, so backslashes are used as separators on Windows.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000685 """
Edward Lemura5799e32020-01-17 19:26:51 +0000686 dir_with_slash = normpath('%s/' % self.PresubmitLocalPath())
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000687 if len(dir_with_slash) == 1:
688 dir_with_slash = ''
sail@chromium.org5538e022011-05-12 17:53:16 +0000689
Edward Lemurb9830242019-10-30 22:19:20 +0000690 return list(filter(
maruel@chromium.org4661e0c2009-06-04 00:45:26 +0000691 lambda x: normpath(x.AbsoluteLocalPath()).startswith(dir_with_slash),
Edward Lemurb9830242019-10-30 22:19:20 +0000692 self.change.AffectedFiles(include_deletes, file_filter)))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000693
agable0b65e732016-11-22 09:25:46 -0800694 def LocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000695 """Returns local paths of input_api.AffectedFiles()."""
agable0b65e732016-11-22 09:25:46 -0800696 paths = [af.LocalPath() for af in self.AffectedFiles()]
Edward Lemura5799e32020-01-17 19:26:51 +0000697 logging.debug('LocalPaths: %s', paths)
pgervais@chromium.org2f64f782014-04-25 00:12:33 +0000698 return paths
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000699
agable0b65e732016-11-22 09:25:46 -0800700 def AbsoluteLocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000701 """Returns absolute local paths of input_api.AffectedFiles()."""
agable0b65e732016-11-22 09:25:46 -0800702 return [af.AbsoluteLocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000703
John Budorick16162372018-04-18 10:39:53 -0700704 def AffectedTestableFiles(self, include_deletes=None, **kwargs):
agable0b65e732016-11-22 09:25:46 -0800705 """Same as input_api.change.AffectedTestableFiles() except only lists files
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000706 in the same directory as the current presubmit script, or subdirectories
707 thereof.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000708 """
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000709 if include_deletes is not None:
Edward Lemura5799e32020-01-17 19:26:51 +0000710 warn('AffectedTestableFiles(include_deletes=%s)'
711 ' is deprecated and ignored' % str(include_deletes),
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000712 category=DeprecationWarning,
713 stacklevel=2)
Edward Lemurb9830242019-10-30 22:19:20 +0000714 return list(filter(
715 lambda x: x.IsTestableFile(),
716 self.AffectedFiles(include_deletes=False, **kwargs)))
agable0b65e732016-11-22 09:25:46 -0800717
718 def AffectedTextFiles(self, include_deletes=None):
719 """An alias to AffectedTestableFiles for backwards compatibility."""
720 return self.AffectedTestableFiles(include_deletes=include_deletes)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000721
local_bot64021412020-07-08 21:05:39 +0000722 def FilterSourceFile(self, affected_file, files_to_check=None,
723 files_to_skip=None, allow_list=None, block_list=None,
local_bot30f774e2020-06-25 18:23:34 +0000724 white_list=None, black_list=None):
Edward Lemura5799e32020-01-17 19:26:51 +0000725 """Filters out files that aren't considered 'source file'.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000726
local_bot64021412020-07-08 21:05:39 +0000727 If files_to_check or files_to_skip is None, InputApi.DEFAULT_FILES_TO_CHECK
728 and InputApi.DEFAULT_FILES_TO_SKIP is used respectively.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000729
730 The lists will be compiled as regular expression and
731 AffectedFile.LocalPath() needs to pass both list.
732
local_bot64021412020-07-08 21:05:39 +0000733 Note: if files_to_check or files_to_skip is not set, and
734 white_list/allow_list or black_list/block_list is, then those values are
735 used. This is used for backward compatibility reasons.
local_bot30f774e2020-06-25 18:23:34 +0000736
maruel@chromium.org3410d912009-06-09 20:56:16 +0000737 Note: Copy-paste this function to suit your needs or use a lambda function.
738 """
Josip Sokcevicc6aa1512020-08-25 23:47:13 +0000739 # TODO(https://crbug.com/1098560): Remove non inclusive parameter names.
740 if files_to_check is None and (allow_list or white_list):
741 warn('Use files_to_check in FilterSourceFile')
local_bot64021412020-07-08 21:05:39 +0000742 files_to_check = allow_list or white_list
Josip Sokcevicc6aa1512020-08-25 23:47:13 +0000743 if files_to_skip is None and (block_list or black_list):
744 warn('Use files_to_skip in FilterSourceFile')
local_bot64021412020-07-08 21:05:39 +0000745 files_to_skip = block_list or black_list
746
747 if files_to_check is None:
748 files_to_check = self.DEFAULT_FILES_TO_CHECK
749 if files_to_skip is None:
750 files_to_skip = self.DEFAULT_FILES_TO_SKIP
local_bot30f774e2020-06-25 18:23:34 +0000751
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000752 def Find(affected_file, items):
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000753 local_path = affected_file.LocalPath()
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000754 for item in items:
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +0000755 if self.re.match(item, local_path):
maruel@chromium.org3410d912009-06-09 20:56:16 +0000756 return True
757 return False
local_bot64021412020-07-08 21:05:39 +0000758 return (Find(affected_file, files_to_check) and
759 not Find(affected_file, files_to_skip))
maruel@chromium.org3410d912009-06-09 20:56:16 +0000760
761 def AffectedSourceFiles(self, source_file):
agable0b65e732016-11-22 09:25:46 -0800762 """Filter the list of AffectedTestableFiles by the function source_file.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000763
764 If source_file is None, InputApi.FilterSourceFile() is used.
765 """
766 if not source_file:
767 source_file = self.FilterSourceFile
Edward Lemurb9830242019-10-30 22:19:20 +0000768 return list(filter(source_file, self.AffectedTestableFiles()))
maruel@chromium.org3410d912009-06-09 20:56:16 +0000769
770 def RightHandSideLines(self, source_file_filter=None):
Edward Lemura5799e32020-01-17 19:26:51 +0000771 """An iterator over all text lines in 'new' version of changed files.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000772
773 Only lists lines from new or modified text files in the change that are
774 contained by the directory of the currently executing presubmit script.
775
776 This is useful for doing line-by-line regex checks, like checking for
777 trailing whitespace.
778
779 Yields:
780 a 3 tuple:
781 the AffectedFile instance of the current file;
782 integer line number (1-based); and
783 the contents of the line as a string.
maruel@chromium.org1487d532009-06-06 00:22:57 +0000784
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000785 Note: The carriage return (LF or CR) is stripped off.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000786 """
maruel@chromium.org3410d912009-06-09 20:56:16 +0000787 files = self.AffectedSourceFiles(source_file_filter)
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000788 return _RightHandSideLinesImpl(files)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000789
maruel@chromium.orge3608df2009-11-10 20:22:57 +0000790 def ReadFile(self, file_item, mode='r'):
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000791 """Reads an arbitrary file.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000792
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000793 Deny reading anything outside the repository.
794 """
maruel@chromium.orge3608df2009-11-10 20:22:57 +0000795 if isinstance(file_item, AffectedFile):
796 file_item = file_item.AbsoluteLocalPath()
797 if not file_item.startswith(self.change.RepositoryRoot()):
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000798 raise IOError('Access outside the repository root is denied.')
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +0000799 return gclient_utils.FileRead(file_item, mode)
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000800
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +0100801 def CreateTemporaryFile(self, **kwargs):
802 """Returns a named temporary file that must be removed with a call to
803 RemoveTemporaryFiles().
804
805 All keyword arguments are forwarded to tempfile.NamedTemporaryFile(),
806 except for |delete|, which is always set to False.
807
808 Presubmit checks that need to create a temporary file and pass it for
809 reading should use this function instead of NamedTemporaryFile(), as
810 Windows fails to open a file that is already open for writing.
811
812 with input_api.CreateTemporaryFile() as f:
813 f.write('xyz')
814 f.close()
815 input_api.subprocess.check_output(['script-that', '--reads-from',
816 f.name])
817
818
819 Note that callers of CreateTemporaryFile() should not worry about removing
820 any temporary file; this is done transparently by the presubmit handling
821 code.
822 """
823 if 'delete' in kwargs:
824 # Prevent users from passing |delete|; we take care of file deletion
825 # ourselves and this prevents unintuitive error messages when we pass
826 # delete=False and 'delete' is also in kwargs.
827 raise TypeError('CreateTemporaryFile() does not take a "delete" '
828 'argument, file deletion is handled automatically by '
829 'the same presubmit_support code that creates InputApi '
830 'objects.')
831 temp_file = self.tempfile.NamedTemporaryFile(delete=False, **kwargs)
832 self._named_temporary_files.append(temp_file.name)
833 return temp_file
834
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000835 @property
836 def tbr(self):
837 """Returns if a change is TBR'ed."""
Jeremy Romandce22502017-06-20 15:37:29 -0400838 return 'TBR' in self.change.tags or self.change.TBRsFromDescription()
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000839
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +0000840 def RunTests(self, tests_mix, parallel=True):
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000841 tests = []
842 msgs = []
843 for t in tests_mix:
Edward Lesmes8e282792018-04-03 18:50:29 -0400844 if isinstance(t, OutputApi.PresubmitResult) and t:
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000845 msgs.append(t)
846 else:
847 assert issubclass(t.message, _PresubmitResult)
848 tests.append(t)
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +0000849 if self.verbose:
850 t.info = _PresubmitNotifyResult
Edward Lemur1037c742018-05-01 18:56:04 -0400851 if not t.kwargs.get('cwd'):
852 t.kwargs['cwd'] = self.PresubmitLocalPath()
Edward Lesmes8e282792018-04-03 18:50:29 -0400853 self.thread_pool.AddTests(tests, parallel)
Edward Lemur21000eb2019-05-24 23:25:58 +0000854 # When self.parallel is True (i.e. --parallel is passed as an option)
855 # RunTests doesn't actually run tests. It adds them to a ThreadPool that
856 # will run all tests once all PRESUBMIT files are processed.
857 # Otherwise, it will run them and return the results.
858 if not self.parallel:
Edward Lesmes8e282792018-04-03 18:50:29 -0400859 msgs.extend(self.thread_pool.RunAsync())
860 return msgs
scottmg86099d72016-09-01 09:16:51 -0700861
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000862
nick@chromium.orgff526192013-06-10 19:30:26 +0000863class _DiffCache(object):
864 """Caches diffs retrieved from a particular SCM."""
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000865 def __init__(self, upstream=None):
866 """Stores the upstream revision against which all diffs will be computed."""
867 self._upstream = upstream
nick@chromium.orgff526192013-06-10 19:30:26 +0000868
869 def GetDiff(self, path, local_root):
870 """Get the diff for a particular path."""
871 raise NotImplementedError()
872
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700873 def GetOldContents(self, path, local_root):
874 """Get the old version for a particular path."""
875 raise NotImplementedError()
876
nick@chromium.orgff526192013-06-10 19:30:26 +0000877
nick@chromium.orgff526192013-06-10 19:30:26 +0000878class _GitDiffCache(_DiffCache):
879 """DiffCache implementation for git; gets all file diffs at once."""
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000880 def __init__(self, upstream):
881 super(_GitDiffCache, self).__init__(upstream=upstream)
nick@chromium.orgff526192013-06-10 19:30:26 +0000882 self._diffs_by_file = None
883
884 def GetDiff(self, path, local_root):
885 if not self._diffs_by_file:
886 # Compute a single diff for all files and parse the output; should
887 # with git this is much faster than computing one diff for each file.
888 diffs = {}
889
890 # Don't specify any filenames below, because there are command line length
891 # limits on some platforms and GenerateDiff would fail.
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000892 unified_diff = scm.GIT.GenerateDiff(local_root, files=[], full_move=True,
893 branch=self._upstream)
nick@chromium.orgff526192013-06-10 19:30:26 +0000894
895 # This regex matches the path twice, separated by a space. Note that
896 # filename itself may contain spaces.
897 file_marker = re.compile('^diff --git (?P<filename>.*) (?P=filename)$')
898 current_diff = []
899 keep_line_endings = True
900 for x in unified_diff.splitlines(keep_line_endings):
901 match = file_marker.match(x)
902 if match:
903 # Marks the start of a new per-file section.
904 diffs[match.group('filename')] = current_diff = [x]
905 elif x.startswith('diff --git'):
906 raise PresubmitFailure('Unexpected diff line: %s' % x)
907 else:
908 current_diff.append(x)
909
910 self._diffs_by_file = dict(
911 (normpath(path), ''.join(diff)) for path, diff in diffs.items())
912
913 if path not in self._diffs_by_file:
914 raise PresubmitFailure(
915 'Unified diff did not contain entry for file %s' % path)
916
917 return self._diffs_by_file[path]
918
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700919 def GetOldContents(self, path, local_root):
920 return scm.GIT.GetOldContents(local_root, path, branch=self._upstream)
921
nick@chromium.orgff526192013-06-10 19:30:26 +0000922
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000923class AffectedFile(object):
924 """Representation of a file in a change."""
nick@chromium.orgff526192013-06-10 19:30:26 +0000925
926 DIFF_CACHE = _DiffCache
927
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000928 # Method could be a function
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800929 # pylint: disable=no-self-use
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000930 def __init__(self, path, action, repository_root, diff_cache):
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000931 self._path = path
932 self._action = action
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000933 self._local_root = repository_root
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000934 self._is_directory = None
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000935 self._cached_changed_contents = None
936 self._cached_new_contents = None
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000937 self._diff_cache = diff_cache
tobiasjs2836bcf2016-08-16 04:08:16 -0700938 logging.debug('%s(%s)', self.__class__.__name__, self._path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000939
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000940 def LocalPath(self):
941 """Returns the path of this file on the local disk relative to client root.
Andrew Grieve92b8b992017-11-02 09:42:24 -0400942
943 This should be used for error messages but not for accessing files,
944 because presubmit checks are run with CWD=PresubmitLocalPath() (which is
945 often != client root).
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000946 """
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000947 return normpath(self._path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000948
949 def AbsoluteLocalPath(self):
950 """Returns the absolute path of this file on the local disk.
951 """
chase@chromium.org8e416c82009-10-06 04:30:44 +0000952 return os.path.abspath(os.path.join(self._local_root, self.LocalPath()))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000953
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000954 def Action(self):
955 """Returns the action on this opened file, e.g. A, M, D, etc."""
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000956 return self._action
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000957
agable0b65e732016-11-22 09:25:46 -0800958 def IsTestableFile(self):
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000959 """Returns True if the file is a text file and not a binary file.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000960
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000961 Deleted files are not text file."""
maruel@chromium.org1e08c002009-05-28 19:09:33 +0000962 raise NotImplementedError() # Implement when needed
963
agable0b65e732016-11-22 09:25:46 -0800964 def IsTextFile(self):
965 """An alias to IsTestableFile for backwards compatibility."""
966 return self.IsTestableFile()
967
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700968 def OldContents(self):
969 """Returns an iterator over the lines in the old version of file.
970
Daniel Cheng2da34fe2017-03-21 20:42:12 -0700971 The old version is the file before any modifications in the user's
Edward Lemura5799e32020-01-17 19:26:51 +0000972 workspace, i.e. the 'left hand side'.
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700973
974 Contents will be empty if the file is a directory or does not exist.
975 Note: The carriage returns (LF or CR) are stripped off.
976 """
977 return self._diff_cache.GetOldContents(self.LocalPath(),
978 self._local_root).splitlines()
979
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000980 def NewContents(self):
981 """Returns an iterator over the lines in the new version of file.
982
Edward Lemura5799e32020-01-17 19:26:51 +0000983 The new version is the file in the user's workspace, i.e. the 'right hand
984 side'.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000985
986 Contents will be empty if the file is a directory or does not exist.
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000987 Note: The carriage returns (LF or CR) are stripped off.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000988 """
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000989 if self._cached_new_contents is None:
990 self._cached_new_contents = []
agable0b65e732016-11-22 09:25:46 -0800991 try:
992 self._cached_new_contents = gclient_utils.FileRead(
993 self.AbsoluteLocalPath(), 'rU').splitlines()
994 except IOError:
995 pass # File not found? That's fine; maybe it was deleted.
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000996 return self._cached_new_contents[:]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000997
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000998 def ChangedContents(self):
999 """Returns a list of tuples (line number, line text) of all new lines.
1000
1001 This relies on the scm diff output describing each changed code section
1002 with a line of the form
1003
1004 ^@@ <old line num>,<old size> <new line num>,<new size> @@$
1005 """
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +00001006 if self._cached_changed_contents is not None:
1007 return self._cached_changed_contents[:]
1008 self._cached_changed_contents = []
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001009 line_num = 0
1010
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001011 for line in self.GenerateScmDiff().splitlines():
Edward Lemurac5c55f2020-02-29 00:17:16 +00001012 m = re.match(r'^@@ [0-9\,\+\-]+ \+([0-9]+)\,[0-9]+ @@', line)
1013 if m:
1014 line_num = int(m.groups(1)[0])
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001015 continue
1016 if line.startswith('+') and not line.startswith('++'):
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +00001017 self._cached_changed_contents.append((line_num, line[1:]))
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001018 if not line.startswith('-'):
1019 line_num += 1
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +00001020 return self._cached_changed_contents[:]
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001021
maruel@chromium.org5de13972009-06-10 18:16:06 +00001022 def __str__(self):
1023 return self.LocalPath()
1024
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001025 def GenerateScmDiff(self):
nick@chromium.orgff526192013-06-10 19:30:26 +00001026 return self._diff_cache.GetDiff(self.LocalPath(), self._local_root)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001027
maruel@chromium.org58407af2011-04-12 23:15:57 +00001028
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001029class GitAffectedFile(AffectedFile):
1030 """Representation of a file in a change out of a git checkout."""
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +00001031 # Method 'NNN' is abstract in class 'NNN' but is not overridden
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -08001032 # pylint: disable=abstract-method
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001033
nick@chromium.orgff526192013-06-10 19:30:26 +00001034 DIFF_CACHE = _GitDiffCache
1035
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001036 def __init__(self, *args, **kwargs):
1037 AffectedFile.__init__(self, *args, **kwargs)
1038 self._server_path = None
agable0b65e732016-11-22 09:25:46 -08001039 self._is_testable_file = None
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001040
agable0b65e732016-11-22 09:25:46 -08001041 def IsTestableFile(self):
1042 if self._is_testable_file is None:
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001043 if self.Action() == 'D':
agable0b65e732016-11-22 09:25:46 -08001044 # A deleted file is not testable.
1045 self._is_testable_file = False
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001046 else:
agable0b65e732016-11-22 09:25:46 -08001047 self._is_testable_file = os.path.isfile(self.AbsoluteLocalPath())
1048 return self._is_testable_file
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001049
maruel@chromium.orgc1938752011-04-12 23:11:13 +00001050
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001051class Change(object):
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001052 """Describe a change.
1053
1054 Used directly by the presubmit scripts to query the current change being
1055 tested.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +00001056
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001057 Instance members:
nick@chromium.orgff526192013-06-10 19:30:26 +00001058 tags: Dictionary of KEY=VALUE pairs found in the change description.
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001059 self.KEY: equivalent to tags['KEY']
1060 """
1061
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001062 _AFFECTED_FILES = AffectedFile
1063
Edward Lemura5799e32020-01-17 19:26:51 +00001064 # Matches key/value (or 'tag') lines in changelist descriptions.
maruel@chromium.org428342a2011-11-10 15:46:33 +00001065 TAG_LINE_RE = re.compile(
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001066 '^[ \t]*(?P<key>[A-Z][A-Z_0-9]*)[ \t]*=[ \t]*(?P<value>.*?)[ \t]*$')
maruel@chromium.orgc1938752011-04-12 23:11:13 +00001067 scm = ''
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001068
maruel@chromium.org58407af2011-04-12 23:15:57 +00001069 def __init__(
agable@chromium.orgea84ef12014-04-30 19:55:12 +00001070 self, name, description, local_root, files, issue, patchset, author,
1071 upstream=None):
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001072 if files is None:
1073 files = []
1074 self._name = name
chase@chromium.org8e416c82009-10-06 04:30:44 +00001075 # Convert root into an absolute path.
1076 self._local_root = os.path.abspath(local_root)
agable@chromium.orgea84ef12014-04-30 19:55:12 +00001077 self._upstream = upstream
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001078 self.issue = issue
1079 self.patchset = patchset
maruel@chromium.org58407af2011-04-12 23:15:57 +00001080 self.author_email = author
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001081
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001082 self._full_description = ''
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001083 self.tags = {}
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001084 self._description_without_tags = ''
1085 self.SetDescriptionText(description)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001086
maruel@chromium.orge085d812011-10-10 19:49:15 +00001087 assert all(
1088 (isinstance(f, (list, tuple)) and len(f) == 2) for f in files), files
1089
agable@chromium.orgea84ef12014-04-30 19:55:12 +00001090 diff_cache = self._AFFECTED_FILES.DIFF_CACHE(self._upstream)
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001091 self._affected_files = [
nick@chromium.orgff526192013-06-10 19:30:26 +00001092 self._AFFECTED_FILES(path, action.strip(), self._local_root, diff_cache)
1093 for action, path in files
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +00001094 ]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001095
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001096 def Name(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001097 """Returns the change name."""
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001098 return self._name
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001099
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001100 def DescriptionText(self):
1101 """Returns the user-entered changelist description, minus tags.
1102
Edward Lemura5799e32020-01-17 19:26:51 +00001103 Any line in the user-provided description starting with e.g. 'FOO='
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001104 (whitespace permitted before and around) is considered a tag line. Such
1105 lines are stripped out of the description this function returns.
1106 """
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001107 return self._description_without_tags
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001108
1109 def FullDescriptionText(self):
1110 """Returns the complete changelist description including tags."""
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001111 return self._full_description
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001112
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001113 def SetDescriptionText(self, description):
1114 """Sets the full description text (including tags) to |description|.
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001115
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001116 Also updates the list of tags."""
1117 self._full_description = description
1118
1119 # From the description text, build up a dictionary of key/value pairs
Edward Lemura5799e32020-01-17 19:26:51 +00001120 # plus the description minus all key/value or 'tag' lines.
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001121 description_without_tags = []
1122 self.tags = {}
1123 for line in self._full_description.splitlines():
1124 m = self.TAG_LINE_RE.match(line)
1125 if m:
1126 self.tags[m.group('key')] = m.group('value')
1127 else:
1128 description_without_tags.append(line)
1129
1130 # Change back to text and remove whitespace at end.
1131 self._description_without_tags = (
1132 '\n'.join(description_without_tags).rstrip())
1133
Edward Lemur69bb8be2020-02-03 20:37:38 +00001134 def AddDescriptionFooter(self, key, value):
1135 """Adds the given footer to the change description.
1136
1137 Args:
1138 key: A string with the key for the git footer. It must conform to
1139 the git footers format (i.e. 'List-Of-Tokens') and will be case
1140 normalized so that each token is title-cased.
1141 value: A string with the value for the git footer.
1142 """
1143 description = git_footers.add_footer(
1144 self.FullDescriptionText(), git_footers.normalize_name(key), value)
1145 self.SetDescriptionText(description)
1146
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001147 def RepositoryRoot(self):
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001148 """Returns the repository (checkout) root directory for this change,
1149 as an absolute path.
1150 """
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001151 return self._local_root
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001152
1153 def __getattr__(self, attr):
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001154 """Return tags directly as attributes on the object."""
Edward Lemura5799e32020-01-17 19:26:51 +00001155 if not re.match(r'^[A-Z_]*$', attr):
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001156 raise AttributeError(self, attr)
maruel@chromium.orge1a524f2009-05-27 14:43:46 +00001157 return self.tags.get(attr)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001158
Edward Lemur69bb8be2020-02-03 20:37:38 +00001159 def GitFootersFromDescription(self):
1160 """Return the git footers present in the description.
1161
1162 Returns:
1163 footers: A dict of {footer: [values]} containing a multimap of the footers
1164 in the change description.
1165 """
1166 return git_footers.parse_footers(self.FullDescriptionText())
1167
Aaron Gablefc03e672017-05-15 14:09:42 -07001168 def BugsFromDescription(self):
1169 """Returns all bugs referenced in the commit description."""
Aaron Gable12ef5012017-05-15 14:29:00 -07001170 tags = [b.strip() for b in self.tags.get('BUG', '').split(',') if b.strip()]
Caleb Rouleauc0546b92019-02-22 06:12:57 +00001171 footers = []
Edward Lemur69bb8be2020-02-03 20:37:38 +00001172 parsed = self.GitFootersFromDescription()
Dan Beam62954042019-10-03 21:20:33 +00001173 unsplit_footers = parsed.get('Bug', []) + parsed.get('Fixed', [])
Caleb Rouleauc0546b92019-02-22 06:12:57 +00001174 for unsplit_footer in unsplit_footers:
1175 footers += [b.strip() for b in unsplit_footer.split(',')]
Aaron Gable12ef5012017-05-15 14:29:00 -07001176 return sorted(set(tags + footers))
Aaron Gablefc03e672017-05-15 14:09:42 -07001177
1178 def ReviewersFromDescription(self):
1179 """Returns all reviewers listed in the commit description."""
Edward Lemura5799e32020-01-17 19:26:51 +00001180 # We don't support a 'R:' git-footer for reviewers; that is in metadata.
Aaron Gable12ef5012017-05-15 14:29:00 -07001181 tags = [r.strip() for r in self.tags.get('R', '').split(',') if r.strip()]
1182 return sorted(set(tags))
Aaron Gablefc03e672017-05-15 14:09:42 -07001183
1184 def TBRsFromDescription(self):
1185 """Returns all TBR reviewers listed in the commit description."""
Aaron Gable12ef5012017-05-15 14:29:00 -07001186 tags = [r.strip() for r in self.tags.get('TBR', '').split(',') if r.strip()]
Aaron Gable6e7ddb62020-05-27 22:23:29 +00001187 # TODO(crbug.com/839208): Remove support for 'Tbr:' when TBRs are
1188 # programmatically determined by self-CR+1s.
Edward Lemur69bb8be2020-02-03 20:37:38 +00001189 footers = self.GitFootersFromDescription().get('Tbr', [])
Aaron Gable12ef5012017-05-15 14:29:00 -07001190 return sorted(set(tags + footers))
Aaron Gablefc03e672017-05-15 14:09:42 -07001191
Aaron Gable6e7ddb62020-05-27 22:23:29 +00001192 # TODO(crbug.com/753425): Delete these once we're sure they're unused.
Aaron Gablefc03e672017-05-15 14:09:42 -07001193 @property
1194 def BUG(self):
1195 return ','.join(self.BugsFromDescription())
1196 @property
1197 def R(self):
1198 return ','.join(self.ReviewersFromDescription())
1199 @property
1200 def TBR(self):
1201 return ','.join(self.TBRsFromDescription())
1202
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001203 def AllFiles(self, root=None):
1204 """List all files under source control in the repo."""
1205 raise NotImplementedError()
1206
agable0b65e732016-11-22 09:25:46 -08001207 def AffectedFiles(self, include_deletes=True, file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001208 """Returns a list of AffectedFile instances for all files in the change.
1209
1210 Args:
1211 include_deletes: If false, deleted files will be filtered out.
sail@chromium.org5538e022011-05-12 17:53:16 +00001212 file_filter: An additional filter to apply.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001213
1214 Returns:
1215 [AffectedFile(path, action), AffectedFile(path, action)]
1216 """
Edward Lemurb9830242019-10-30 22:19:20 +00001217 affected = list(filter(file_filter, self._affected_files))
sail@chromium.org5538e022011-05-12 17:53:16 +00001218
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001219 if include_deletes:
1220 return affected
Edward Lemurb9830242019-10-30 22:19:20 +00001221 return list(filter(lambda x: x.Action() != 'D', affected))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001222
John Budorick16162372018-04-18 10:39:53 -07001223 def AffectedTestableFiles(self, include_deletes=None, **kwargs):
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +00001224 """Return a list of the existing text files in a change."""
1225 if include_deletes is not None:
Edward Lemura5799e32020-01-17 19:26:51 +00001226 warn('AffectedTeestableFiles(include_deletes=%s)'
1227 ' is deprecated and ignored' % str(include_deletes),
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +00001228 category=DeprecationWarning,
1229 stacklevel=2)
Edward Lemurb9830242019-10-30 22:19:20 +00001230 return list(filter(
1231 lambda x: x.IsTestableFile(),
1232 self.AffectedFiles(include_deletes=False, **kwargs)))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001233
agable0b65e732016-11-22 09:25:46 -08001234 def AffectedTextFiles(self, include_deletes=None):
1235 """An alias to AffectedTestableFiles for backwards compatibility."""
1236 return self.AffectedTestableFiles(include_deletes=include_deletes)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001237
agable0b65e732016-11-22 09:25:46 -08001238 def LocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001239 """Convenience function."""
agable0b65e732016-11-22 09:25:46 -08001240 return [af.LocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001241
agable0b65e732016-11-22 09:25:46 -08001242 def AbsoluteLocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001243 """Convenience function."""
agable0b65e732016-11-22 09:25:46 -08001244 return [af.AbsoluteLocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001245
1246 def RightHandSideLines(self):
Edward Lemura5799e32020-01-17 19:26:51 +00001247 """An iterator over all text lines in 'new' version of changed files.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001248
1249 Lists lines from new or modified text files in the change.
1250
1251 This is useful for doing line-by-line regex checks, like checking for
1252 trailing whitespace.
1253
1254 Yields:
1255 a 3 tuple:
1256 the AffectedFile instance of the current file;
1257 integer line number (1-based); and
1258 the contents of the line as a string.
1259 """
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +00001260 return _RightHandSideLinesImpl(
1261 x for x in self.AffectedFiles(include_deletes=False)
agable0b65e732016-11-22 09:25:46 -08001262 if x.IsTestableFile())
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001263
Jochen Eisingerd0573ec2017-04-13 10:55:06 +02001264 def OriginalOwnersFiles(self):
1265 """A map from path names of affected OWNERS files to their old content."""
1266 def owners_file_filter(f):
1267 return 'OWNERS' in os.path.split(f.LocalPath())[1]
1268 files = self.AffectedFiles(file_filter=owners_file_filter)
1269 return dict([(f.LocalPath(), f.OldContents()) for f in files])
1270
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001271
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001272class GitChange(Change):
1273 _AFFECTED_FILES = GitAffectedFile
maruel@chromium.orgc1938752011-04-12 23:11:13 +00001274 scm = 'git'
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +00001275
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001276 def AllFiles(self, root=None):
1277 """List all files under source control in the repo."""
1278 root = root or self.RepositoryRoot()
1279 return subprocess.check_output(
Aaron Gable7817f022017-12-12 09:43:17 -08001280 ['git', '-c', 'core.quotePath=false', 'ls-files', '--', '.'],
1281 cwd=root).splitlines()
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001282
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001283
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001284def ListRelevantPresubmitFiles(files, root):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001285 """Finds all presubmit files that apply to a given set of source files.
1286
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001287 If inherit-review-settings-ok is present right under root, looks for
1288 PRESUBMIT.py in directories enclosing root.
1289
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001290 Args:
1291 files: An iterable container containing file paths.
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001292 root: Path where to stop searching.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001293
1294 Return:
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001295 List of absolute paths of the existing PRESUBMIT.py scripts.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001296 """
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001297 files = [normpath(os.path.join(root, f)) for f in files]
1298
1299 # List all the individual directories containing files.
1300 directories = set([os.path.dirname(f) for f in files])
1301
1302 # Ignore root if inherit-review-settings-ok is present.
1303 if os.path.isfile(os.path.join(root, 'inherit-review-settings-ok')):
1304 root = None
1305
1306 # Collect all unique directories that may contain PRESUBMIT.py.
1307 candidates = set()
1308 for directory in directories:
1309 while True:
1310 if directory in candidates:
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001311 break
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001312 candidates.add(directory)
1313 if directory == root:
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001314 break
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001315 parent_dir = os.path.dirname(directory)
1316 if parent_dir == directory:
1317 # We hit the system root directory.
1318 break
1319 directory = parent_dir
1320
1321 # Look for PRESUBMIT.py in all candidate directories.
1322 results = []
1323 for directory in sorted(list(candidates)):
tobiasjsff061c02016-08-17 03:23:57 -07001324 try:
1325 for f in os.listdir(directory):
1326 p = os.path.join(directory, f)
1327 if os.path.isfile(p) and re.match(
1328 r'PRESUBMIT.*\.py$', f) and not f.startswith('PRESUBMIT_test'):
1329 results.append(p)
1330 except OSError:
1331 pass
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001332
tobiasjs2836bcf2016-08-16 04:08:16 -07001333 logging.debug('Presubmit files: %s', ','.join(results))
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001334 return results
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001335
1336
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001337class GetTryMastersExecuter(object):
1338 @staticmethod
1339 def ExecPresubmitScript(script_text, presubmit_path, project, change):
1340 """Executes GetPreferredTryMasters() from a single presubmit script.
1341
1342 Args:
1343 script_text: The text of the presubmit script.
1344 presubmit_path: Project script to run.
1345 project: Project name to pass to presubmit script for bot selection.
1346
1347 Return:
1348 A map of try masters to map of builders to set of tests.
1349 """
1350 context = {}
1351 try:
Raul Tambre09e64b42019-05-14 01:57:22 +00001352 exec(compile(script_text, 'PRESUBMIT.py', 'exec', dont_inherit=True),
1353 context)
Raul Tambre7c938462019-05-24 16:35:35 +00001354 except Exception as e:
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001355 raise PresubmitFailure('"%s" had an exception.\n%s'
1356 % (presubmit_path, e))
1357
1358 function_name = 'GetPreferredTryMasters'
1359 if function_name not in context:
1360 return {}
1361 get_preferred_try_masters = context[function_name]
1362 if not len(inspect.getargspec(get_preferred_try_masters)[0]) == 2:
1363 raise PresubmitFailure(
1364 'Expected function "GetPreferredTryMasters" to take two arguments.')
1365 return get_preferred_try_masters(project, change)
1366
1367
rmistry@google.com5626a922015-02-26 14:03:30 +00001368class GetPostUploadExecuter(object):
1369 @staticmethod
Edward Lemur016a0872020-02-04 22:13:28 +00001370 def ExecPresubmitScript(script_text, presubmit_path, gerrit_obj, change):
rmistry@google.com5626a922015-02-26 14:03:30 +00001371 """Executes PostUploadHook() from a single presubmit script.
1372
1373 Args:
1374 script_text: The text of the presubmit script.
1375 presubmit_path: Project script to run.
Edward Lemur016a0872020-02-04 22:13:28 +00001376 gerrit_obj: The GerritAccessor object.
rmistry@google.com5626a922015-02-26 14:03:30 +00001377 change: The Change object.
1378
1379 Return:
1380 A list of results objects.
1381 """
1382 context = {}
1383 try:
Raul Tambre09e64b42019-05-14 01:57:22 +00001384 exec(compile(script_text, 'PRESUBMIT.py', 'exec', dont_inherit=True),
1385 context)
Raul Tambre7c938462019-05-24 16:35:35 +00001386 except Exception as e:
rmistry@google.com5626a922015-02-26 14:03:30 +00001387 raise PresubmitFailure('"%s" had an exception.\n%s'
1388 % (presubmit_path, e))
1389
1390 function_name = 'PostUploadHook'
1391 if function_name not in context:
1392 return {}
1393 post_upload_hook = context[function_name]
1394 if not len(inspect.getargspec(post_upload_hook)[0]) == 3:
1395 raise PresubmitFailure(
1396 'Expected function "PostUploadHook" to take three arguments.')
Edward Lemur016a0872020-02-04 22:13:28 +00001397 return post_upload_hook(gerrit_obj, change, OutputApi(False))
rmistry@google.com5626a922015-02-26 14:03:30 +00001398
1399
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001400def _MergeMasters(masters1, masters2):
1401 """Merges two master maps. Merges also the tests of each builder."""
1402 result = {}
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001403 for (master, builders) in itertools.chain(masters1.items(),
1404 masters2.items()):
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001405 new_builders = result.setdefault(master, {})
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001406 for (builder, tests) in builders.items():
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001407 new_builders.setdefault(builder, set([])).update(tests)
1408 return result
1409
1410
1411def DoGetTryMasters(change,
1412 changed_files,
1413 repository_root,
1414 default_presubmit,
1415 project,
1416 verbose,
1417 output_stream):
1418 """Get the list of try masters from the presubmit scripts.
1419
1420 Args:
1421 changed_files: List of modified files.
1422 repository_root: The repository root.
1423 default_presubmit: A default presubmit script to execute in any case.
1424 project: Optional name of a project used in selecting trybots.
1425 verbose: Prints debug info.
1426 output_stream: A stream to write debug output to.
1427
1428 Return:
1429 Map of try masters to map of builders to set of tests.
1430 """
1431 presubmit_files = ListRelevantPresubmitFiles(changed_files, repository_root)
1432 if not presubmit_files and verbose:
Edward Lemura5799e32020-01-17 19:26:51 +00001433 output_stream.write('Warning, no PRESUBMIT.py found.\n')
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001434 results = {}
1435 executer = GetTryMastersExecuter()
1436
1437 if default_presubmit:
1438 if verbose:
Edward Lemura5799e32020-01-17 19:26:51 +00001439 output_stream.write('Running default presubmit script.\n')
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001440 fake_path = os.path.join(repository_root, 'PRESUBMIT.py')
1441 results = _MergeMasters(results, executer.ExecPresubmitScript(
1442 default_presubmit, fake_path, project, change))
1443 for filename in presubmit_files:
1444 filename = os.path.abspath(filename)
1445 if verbose:
Edward Lemura5799e32020-01-17 19:26:51 +00001446 output_stream.write('Running %s\n' % filename)
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001447 # Accept CRLF presubmit script.
1448 presubmit_script = gclient_utils.FileRead(filename, 'rU')
1449 results = _MergeMasters(results, executer.ExecPresubmitScript(
1450 presubmit_script, filename, project, change))
1451
1452 # Make sets to lists again for later JSON serialization.
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001453 for builders in results.values():
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001454 for builder in builders:
1455 builders[builder] = list(builders[builder])
1456
1457 if results and verbose:
1458 output_stream.write('%s\n' % str(results))
1459 return results
1460
1461
rmistry@google.com5626a922015-02-26 14:03:30 +00001462def DoPostUploadExecuter(change,
Edward Lemur016a0872020-02-04 22:13:28 +00001463 gerrit_obj,
Edward Lemur6eb1d322020-02-27 22:20:15 +00001464 verbose):
rmistry@google.com5626a922015-02-26 14:03:30 +00001465 """Execute the post upload hook.
1466
1467 Args:
1468 change: The Change object.
Edward Lemur016a0872020-02-04 22:13:28 +00001469 gerrit_obj: The GerritAccessor object.
rmistry@google.com5626a922015-02-26 14:03:30 +00001470 verbose: Prints debug info.
rmistry@google.com5626a922015-02-26 14:03:30 +00001471 """
1472 presubmit_files = ListRelevantPresubmitFiles(
Edward Lemur6eb1d322020-02-27 22:20:15 +00001473 change.LocalPaths(), change.RepositoryRoot())
rmistry@google.com5626a922015-02-26 14:03:30 +00001474 if not presubmit_files and verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001475 sys.stdout.write('Warning, no PRESUBMIT.py found.\n')
rmistry@google.com5626a922015-02-26 14:03:30 +00001476 results = []
1477 executer = GetPostUploadExecuter()
1478 # The root presubmit file should be executed after the ones in subdirectories.
1479 # i.e. the specific post upload hooks should run before the general ones.
1480 # Thus, reverse the order provided by ListRelevantPresubmitFiles.
1481 presubmit_files.reverse()
1482
1483 for filename in presubmit_files:
1484 filename = os.path.abspath(filename)
1485 if verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001486 sys.stdout.write('Running %s\n' % filename)
rmistry@google.com5626a922015-02-26 14:03:30 +00001487 # Accept CRLF presubmit script.
1488 presubmit_script = gclient_utils.FileRead(filename, 'rU')
1489 results.extend(executer.ExecPresubmitScript(
Edward Lemur016a0872020-02-04 22:13:28 +00001490 presubmit_script, filename, gerrit_obj, change))
rmistry@google.com5626a922015-02-26 14:03:30 +00001491
Edward Lemur6eb1d322020-02-27 22:20:15 +00001492 if not results:
1493 return 0
1494
1495 sys.stdout.write('\n')
1496 sys.stdout.write('** Post Upload Hook Messages **\n')
1497
1498 exit_code = 0
1499 for result in results:
1500 if result.fatal:
1501 exit_code = 1
1502 result.handle()
1503 sys.stdout.write('\n')
1504
1505 return exit_code
rmistry@google.com5626a922015-02-26 14:03:30 +00001506
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001507class PresubmitExecuter(object):
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001508 def __init__(self, change, committing, verbose, gerrit_obj, dry_run=None,
1509 thread_pool=None, parallel=False, gerrit_project=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001510 """
1511 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001512 change: The Change object.
agable92bec4f2016-08-24 09:27:27 -07001513 committing: True if 'git cl land' is running, False if 'git cl upload' is.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001514 gerrit_obj: provides basic Gerrit codereview functionality.
1515 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -04001516 parallel: if true, all tests reported via input_api.RunTests for all
1517 PRESUBMIT files will be run in parallel.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001518 """
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001519 self.change = change
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001520 self.committing = committing
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001521 self.gerrit = gerrit_obj
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001522 self.verbose = verbose
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001523 self.dry_run = dry_run
Daniel Cheng7227d212017-11-17 08:12:37 -08001524 self.more_cc = []
Edward Lesmes8e282792018-04-03 18:50:29 -04001525 self.thread_pool = thread_pool
1526 self.parallel = parallel
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001527 self.gerrit_project = gerrit_project
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001528
1529 def ExecPresubmitScript(self, script_text, presubmit_path):
1530 """Executes a single presubmit script.
1531
1532 Args:
1533 script_text: The text of the presubmit script.
1534 presubmit_path: The path to the presubmit file (this will be reported via
1535 input_api.PresubmitLocalPath()).
1536
1537 Return:
1538 A list of result objects, empty if no problems.
1539 """
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001540
chase@chromium.org8e416c82009-10-06 04:30:44 +00001541 # Change to the presubmit file's directory to support local imports.
1542 main_path = os.getcwd()
Saagar Sanghavi98b332f2020-07-31 17:19:15 +00001543 presubmit_dir = os.path.dirname(presubmit_path)
1544 os.chdir(presubmit_dir)
chase@chromium.org8e416c82009-10-06 04:30:44 +00001545
1546 # Load the presubmit script into context.
dpranke@chromium.org970c5222011-03-12 00:32:24 +00001547 input_api = InputApi(self.change, presubmit_path, self.committing,
Aaron Gable668c1d82018-04-03 10:19:16 -07001548 self.verbose, gerrit_obj=self.gerrit,
Edward Lesmes8e282792018-04-03 18:50:29 -04001549 dry_run=self.dry_run, thread_pool=self.thread_pool,
1550 parallel=self.parallel)
Daniel Cheng7227d212017-11-17 08:12:37 -08001551 output_api = OutputApi(self.committing)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001552 context = {}
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001553
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001554 try:
Raul Tambre09e64b42019-05-14 01:57:22 +00001555 exec(compile(script_text, 'PRESUBMIT.py', 'exec', dont_inherit=True),
1556 context)
Raul Tambre7c938462019-05-24 16:35:35 +00001557 except Exception as e:
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001558 raise PresubmitFailure('"%s" had an exception.\n%s' % (presubmit_path, e))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001559
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001560 context['__args'] = (input_api, output_api)
Ben Pastene8351dc12020-08-06 05:01:35 +00001561
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001562 # Get path of presubmit directory relative to repository root.
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001563 # Always use forward slashes, so that path is same in *nix and Windows
1564 root = input_api.change.RepositoryRoot()
1565 rel_path = os.path.relpath(presubmit_dir, root)
1566 rel_path = rel_path.replace(os.path.sep, '/')
Ben Pastene8351dc12020-08-06 05:01:35 +00001567
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001568 # Get the URL of git remote origin and use it to identify host and project
1569 host = ''
1570 if self.gerrit and self.gerrit.host:
1571 host = self.gerrit.host
1572 project = self.gerrit_project or ''
1573
1574 # Prefix for test names
1575 prefix = 'presubmit:%s/%s:%s/' % (host, project, rel_path)
1576
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001577 # Perform all the desired presubmit checks.
1578 results = []
Ben Pastene8351dc12020-08-06 05:01:35 +00001579
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001580 try:
Saagar Sanghavi99816902020-08-11 22:41:25 +00001581 if 'PRESUBMIT_VERSION' in context and \
1582 [int(x) for x in context['PRESUBMIT_VERSION'].split('.')] >= [2, 0, 0]:
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001583 for function_name in context:
1584 if not function_name.startswith('Check'):
1585 continue
1586 if function_name.endswith('Commit') and not self.committing:
1587 continue
1588 if function_name.endswith('Upload') and self.committing:
1589 continue
1590 logging.debug('Running %s in %s', function_name, presubmit_path)
1591 results.extend(
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001592 self._run_check_function(function_name, context, prefix))
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001593 logging.debug('Running %s done.', function_name)
1594 self.more_cc.extend(output_api.more_cc)
1595
1596 else: # Old format
1597 if self.committing:
1598 function_name = 'CheckChangeOnCommit'
1599 else:
1600 function_name = 'CheckChangeOnUpload'
1601 if function_name in context:
1602 logging.debug('Running %s in %s', function_name, presubmit_path)
1603 results.extend(
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001604 self._run_check_function(function_name, context, prefix))
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001605 logging.debug('Running %s done.', function_name)
1606 self.more_cc.extend(output_api.more_cc)
1607
1608 finally:
1609 for f in input_api._named_temporary_files:
1610 os.remove(f)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001611
chase@chromium.org8e416c82009-10-06 04:30:44 +00001612 # Return the process to the original working directory.
1613 os.chdir(main_path)
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001614 return results
1615
1616 def _run_check_function(self, function_name, context, prefix):
1617 """Evaluates a presubmit check function, function_name, in the context
1618 provided. If LUCI_CONTEXT is enabled, it will send the result to ResultSink.
1619 Passes function_name and prefix to rdb_wrapper.setup_rdb. Returns results.
1620
1621 Args:
1622 function_name: a string representing the name of the function to run
1623 context: a context dictionary in which the function will be evaluated
1624 prefix: a string describing prefix for ResultDB test id
1625
1626 Returns: Results from evaluating the function call."""
1627 with rdb_wrapper.setup_rdb(function_name, prefix) as my_status:
1628 result = eval(function_name + '(*__args)', context)
1629 self._check_result_type(result)
1630 if any(res.fatal for res in result):
1631 my_status.status = rdb_wrapper.STATUS_FAIL
1632 return result
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001633
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00001634 def _check_result_type(self, result):
1635 """Helper function which ensures result is a list, and all elements are
1636 instances of OutputApi.PresubmitResult"""
1637 if not isinstance(result, (tuple, list)):
1638 raise PresubmitFailure('Presubmit functions must return a tuple or list')
1639 if not all(isinstance(res, OutputApi.PresubmitResult) for res in result):
1640 raise PresubmitFailure(
1641 'All presubmit results must be of types derived from '
1642 'output_api.PresubmitResult')
1643
1644
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001645def DoPresubmitChecks(change,
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001646 committing,
1647 verbose,
maruel@chromium.orgb0dfd352009-06-10 14:12:54 +00001648 default_presubmit,
dpranke@chromium.org970c5222011-03-12 00:32:24 +00001649 may_prompt,
Aaron Gable668c1d82018-04-03 10:19:16 -07001650 gerrit_obj,
Edward Lesmes8e282792018-04-03 18:50:29 -04001651 dry_run=None,
Debrian Figueroadd2737e2019-06-21 23:50:13 +00001652 parallel=False,
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001653 json_output=None,
1654 gerrit_project=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001655 """Runs all presubmit checks that apply to the files in the change.
1656
1657 This finds all PRESUBMIT.py files in directories enclosing the files in the
1658 change (up to the repository root) and calls the relevant entrypoint function
1659 depending on whether the change is being committed or uploaded.
1660
1661 Prints errors, warnings and notifications. Prompts the user for warnings
1662 when needed.
1663
1664 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001665 change: The Change object.
agable92bec4f2016-08-24 09:27:27 -07001666 committing: True if 'git cl land' is running, False if 'git cl upload' is.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001667 verbose: Prints debug info.
maruel@chromium.org0ff1fab2009-05-22 13:08:15 +00001668 default_presubmit: A default presubmit script to execute in any case.
Quinten Yearsley516fe7f2016-12-14 11:50:18 -08001669 may_prompt: Enable (y/n) questions on warning or error. If False,
1670 any questions are answered with yes by default.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001671 gerrit_obj: provides basic Gerrit codereview functionality.
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001672 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -04001673 parallel: if true, all tests specified by input_api.RunTests in all
1674 PRESUBMIT files will be run in parallel.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001675
1676 Return:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001677 1 if presubmit checks failed or 0 otherwise.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001678 """
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001679 old_environ = os.environ
1680 try:
1681 # Make sure python subprocesses won't generate .pyc files.
1682 os.environ = os.environ.copy()
Edward Lemurb9830242019-10-30 22:19:20 +00001683 os.environ['PYTHONDONTWRITEBYTECODE'] = '1'
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001684
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001685 if committing:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001686 sys.stdout.write('Running presubmit commit checks ...\n')
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001687 else:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001688 sys.stdout.write('Running presubmit upload checks ...\n')
Edward Lemurecc27072020-01-06 16:42:34 +00001689 start_time = time_time()
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001690 presubmit_files = ListRelevantPresubmitFiles(
agable0b65e732016-11-22 09:25:46 -08001691 change.AbsoluteLocalPaths(), change.RepositoryRoot())
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001692 if not presubmit_files and verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001693 sys.stdout.write('Warning, no PRESUBMIT.py found.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001694 results = []
Edward Lesmes8e282792018-04-03 18:50:29 -04001695 thread_pool = ThreadPool()
Edward Lemur7e3c67f2018-07-20 20:52:49 +00001696 executer = PresubmitExecuter(change, committing, verbose, gerrit_obj,
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001697 dry_run, thread_pool, parallel, gerrit_project)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001698 if default_presubmit:
1699 if verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001700 sys.stdout.write('Running default presubmit script.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001701 fake_path = os.path.join(change.RepositoryRoot(), 'PRESUBMIT.py')
1702 results += executer.ExecPresubmitScript(default_presubmit, fake_path)
1703 for filename in presubmit_files:
1704 filename = os.path.abspath(filename)
1705 if verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001706 sys.stdout.write('Running %s\n' % filename)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001707 # Accept CRLF presubmit script.
1708 presubmit_script = gclient_utils.FileRead(filename, 'rU')
1709 results += executer.ExecPresubmitScript(presubmit_script, filename)
Edward Lesmes8e282792018-04-03 18:50:29 -04001710 results += thread_pool.RunAsync()
1711
Edward Lemur6eb1d322020-02-27 22:20:15 +00001712 messages = {}
1713 should_prompt = False
1714 presubmits_failed = False
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001715 for result in results:
1716 if result.fatal:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001717 presubmits_failed = True
1718 messages.setdefault('ERRORS', []).append(result)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001719 elif result.should_prompt:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001720 should_prompt = True
1721 messages.setdefault('Warnings', []).append(result)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001722 else:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001723 messages.setdefault('Messages', []).append(result)
pam@chromium.orged9a0832009-09-09 22:48:55 +00001724
Edward Lemur6eb1d322020-02-27 22:20:15 +00001725 sys.stdout.write('\n')
1726 for name, items in messages.items():
1727 sys.stdout.write('** Presubmit %s **\n' % name)
1728 for item in items:
1729 item.handle()
1730 sys.stdout.write('\n')
pam@chromium.orged9a0832009-09-09 22:48:55 +00001731
Edward Lemurecc27072020-01-06 16:42:34 +00001732 total_time = time_time() - start_time
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001733 if total_time > 1.0:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001734 sys.stdout.write(
1735 'Presubmit checks took %.1fs to calculate.\n\n' % total_time)
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +00001736
Edward Lemur6eb1d322020-02-27 22:20:15 +00001737 if not should_prompt and not presubmits_failed:
1738 sys.stdout.write('Presubmit checks passed.\n')
1739 elif should_prompt:
1740 sys.stdout.write('There were presubmit warnings. ')
Quinten Yearsley516fe7f2016-12-14 11:50:18 -08001741 if may_prompt:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001742 presubmits_failed = not prompt_should_continue(
1743 'Are you sure you wish to continue? (y/N): ')
Garrett Beatyacb807e2020-08-28 18:17:24 +00001744 else:
1745 sys.stdout.write('\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001746
Edward Lemur1dc66e12020-02-21 21:36:34 +00001747 if json_output:
1748 # Write the presubmit results to json output
1749 presubmit_results = {
1750 'errors': [
Edward Lemur6eb1d322020-02-27 22:20:15 +00001751 error.json_format()
1752 for error in messages.get('ERRORS', [])
Edward Lemur1dc66e12020-02-21 21:36:34 +00001753 ],
1754 'notifications': [
Edward Lemur6eb1d322020-02-27 22:20:15 +00001755 notification.json_format()
1756 for notification in messages.get('Messages', [])
Edward Lemur1dc66e12020-02-21 21:36:34 +00001757 ],
1758 'warnings': [
Edward Lemur6eb1d322020-02-27 22:20:15 +00001759 warning.json_format()
1760 for warning in messages.get('Warnings', [])
Edward Lemur1dc66e12020-02-21 21:36:34 +00001761 ],
Edward Lemur6eb1d322020-02-27 22:20:15 +00001762 'more_cc': executer.more_cc,
Edward Lemur1dc66e12020-02-21 21:36:34 +00001763 }
1764
1765 gclient_utils.FileWrite(
1766 json_output, json.dumps(presubmit_results, sort_keys=True))
1767
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001768 global _ASKED_FOR_FEEDBACK
1769 # Ask for feedback one time out of 5.
1770 if (len(results) and random.randint(0, 4) == 0 and not _ASKED_FOR_FEEDBACK):
Edward Lemur6eb1d322020-02-27 22:20:15 +00001771 sys.stdout.write(
maruel@chromium.org1ce8e662014-01-14 15:23:00 +00001772 'Was the presubmit check useful? If not, run "git cl presubmit -v"\n'
1773 'to figure out which PRESUBMIT.py was run, then run git blame\n'
1774 'on the file to figure out who to ask for help.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001775 _ASKED_FOR_FEEDBACK = True
Edward Lemur6eb1d322020-02-27 22:20:15 +00001776
1777 return 1 if presubmits_failed else 0
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001778 finally:
1779 os.environ = old_environ
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001780
1781
Edward Lemur50984a62020-02-06 18:10:18 +00001782def _scan_sub_dirs(mask, recursive):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001783 if not recursive:
pgervais@chromium.orge57b09d2014-05-07 00:58:13 +00001784 return [x for x in glob.glob(mask) if x not in ('.svn', '.git')]
Lei Zhang9611c4c2017-04-04 01:41:56 -07001785
1786 results = []
1787 for root, dirs, files in os.walk('.'):
1788 if '.svn' in dirs:
1789 dirs.remove('.svn')
1790 if '.git' in dirs:
1791 dirs.remove('.git')
1792 for name in files:
1793 if fnmatch.fnmatch(name, mask):
1794 results.append(os.path.join(root, name))
1795 return results
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001796
1797
Edward Lemur50984a62020-02-06 18:10:18 +00001798def _parse_files(args, recursive):
tobiasjs2836bcf2016-08-16 04:08:16 -07001799 logging.debug('Searching for %s', args)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001800 files = []
1801 for arg in args:
Edward Lemur50984a62020-02-06 18:10:18 +00001802 files.extend([('M', f) for f in _scan_sub_dirs(arg, recursive)])
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001803 return files
1804
1805
Edward Lemur50984a62020-02-06 18:10:18 +00001806def _parse_change(parser, options):
1807 """Process change options.
1808
1809 Args:
1810 parser: The parser used to parse the arguments from command line.
1811 options: The arguments parsed from command line.
1812 Returns:
1813 A GitChange if the change root is a git repository, or a Change otherwise.
1814 """
1815 if options.files and options.all_files:
1816 parser.error('<files> cannot be specified when --all-files is set.')
1817
Edward Lesmes44ea3ff2020-02-05 00:14:30 +00001818 change_scm = scm.determine_scm(options.root)
Edward Lemur50984a62020-02-06 18:10:18 +00001819 if change_scm != 'git' and not options.files:
1820 parser.error('<files> is not optional for unversioned directories.')
1821
1822 if options.files:
1823 change_files = _parse_files(options.files, options.recursive)
1824 elif options.all_files:
1825 change_files = [('M', f) for f in scm.GIT.GetAllFiles(options.root)]
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001826 else:
Edward Lemur50984a62020-02-06 18:10:18 +00001827 change_files = scm.GIT.CaptureStatus(
Edward Lemur7f6dec02020-02-06 20:23:58 +00001828 options.root, options.upstream or None)
Edward Lemur50984a62020-02-06 18:10:18 +00001829
1830 logging.info('Found %d file(s).', len(change_files))
1831
1832 change_class = GitChange if change_scm == 'git' else Change
1833 return change_class(
1834 options.name,
1835 options.description,
1836 options.root,
1837 change_files,
1838 options.issue,
1839 options.patchset,
1840 options.author,
1841 upstream=options.upstream)
1842
1843
1844def _parse_gerrit_options(parser, options):
1845 """Process gerrit options.
1846
1847 SIDE EFFECTS: Modifies options.author and options.description from Gerrit if
1848 options.gerrit_fetch is set.
1849
1850 Args:
1851 parser: The parser used to parse the arguments from command line.
1852 options: The arguments parsed from command line.
1853 Returns:
1854 A GerritAccessor object if options.gerrit_url is set, or None otherwise.
1855 """
1856 gerrit_obj = None
1857 if options.gerrit_url:
1858 gerrit_obj = GerritAccessor(urlparse.urlparse(options.gerrit_url).netloc)
1859
1860 if not options.gerrit_fetch:
1861 return gerrit_obj
1862
1863 if not options.gerrit_url or not options.issue or not options.patchset:
1864 parser.error(
1865 '--gerrit_fetch requires --gerrit_url, --issue and --patchset.')
1866
1867 options.author = gerrit_obj.GetChangeOwner(options.issue)
1868 options.description = gerrit_obj.GetChangeDescription(
1869 options.issue, options.patchset)
1870
1871 logging.info('Got author: "%s"', options.author)
1872 logging.info('Got description: """\n%s\n"""', options.description)
1873
1874 return gerrit_obj
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001875
1876
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001877@contextlib.contextmanager
1878def canned_check_filter(method_names):
1879 filtered = {}
1880 try:
1881 for method_name in method_names:
1882 if not hasattr(presubmit_canned_checks, method_name):
Aaron Gableecee74c2018-04-02 15:13:08 -07001883 logging.warn('Skipping unknown "canned" check %s' % method_name)
1884 continue
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001885 filtered[method_name] = getattr(presubmit_canned_checks, method_name)
1886 setattr(presubmit_canned_checks, method_name, lambda *_a, **_kw: [])
1887 yield
1888 finally:
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001889 for name, method in filtered.items():
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001890 setattr(presubmit_canned_checks, name, method)
1891
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +00001892
sbc@chromium.org013731e2015-02-26 18:28:43 +00001893def main(argv=None):
Edward Lemura5799e32020-01-17 19:26:51 +00001894 parser = argparse.ArgumentParser(usage='%(prog)s [options] <files...>')
1895 hooks = parser.add_mutually_exclusive_group()
1896 hooks.add_argument('-c', '--commit', action='store_true',
1897 help='Use commit instead of upload checks.')
1898 hooks.add_argument('-u', '--upload', action='store_false', dest='commit',
1899 help='Use upload instead of commit checks.')
Edward Lemur75526302020-02-27 22:31:05 +00001900 hooks.add_argument('--post_upload', action='store_true',
1901 help='Run post-upload commit hooks.')
Edward Lemura5799e32020-01-17 19:26:51 +00001902 parser.add_argument('-r', '--recursive', action='store_true',
1903 help='Act recursively.')
1904 parser.add_argument('-v', '--verbose', action='count', default=0,
1905 help='Use 2 times for more debug info.')
1906 parser.add_argument('--name', default='no name')
1907 parser.add_argument('--author')
Edward Lemur227d5102020-02-25 23:45:35 +00001908 desc = parser.add_mutually_exclusive_group()
1909 desc.add_argument('--description', default='', help='The change description.')
1910 desc.add_argument('--description_file',
1911 help='File to read change description from.')
Edward Lemura5799e32020-01-17 19:26:51 +00001912 parser.add_argument('--issue', type=int, default=0)
1913 parser.add_argument('--patchset', type=int, default=0)
1914 parser.add_argument('--root', default=os.getcwd(),
1915 help='Search for PRESUBMIT.py up to this directory. '
1916 'If inherit-review-settings-ok is present in this '
1917 'directory, parent directories up to the root file '
1918 'system directories will also be searched.')
1919 parser.add_argument('--upstream',
1920 help='Git only: the base ref or upstream branch against '
1921 'which the diff should be computed.')
1922 parser.add_argument('--default_presubmit')
1923 parser.add_argument('--may_prompt', action='store_true', default=False)
1924 parser.add_argument('--skip_canned', action='append', default=[],
1925 help='A list of checks to skip which appear in '
1926 'presubmit_canned_checks. Can be provided multiple times '
1927 'to skip multiple canned checks.')
1928 parser.add_argument('--dry_run', action='store_true', help=argparse.SUPPRESS)
1929 parser.add_argument('--gerrit_url', help=argparse.SUPPRESS)
1930 parser.add_argument('--gerrit_fetch', action='store_true',
1931 help=argparse.SUPPRESS)
1932 parser.add_argument('--parallel', action='store_true',
1933 help='Run all tests specified by input_api.RunTests in '
1934 'all PRESUBMIT files in parallel.')
1935 parser.add_argument('--json_output',
1936 help='Write presubmit errors to json output.')
Edward Lemur1dc66e12020-02-21 21:36:34 +00001937 parser.add_argument('--all_files', action='store_true',
Edward Lemur50984a62020-02-06 18:10:18 +00001938 help='Mark all files under source control as modified.')
Edward Lemura5799e32020-01-17 19:26:51 +00001939 parser.add_argument('files', nargs='*',
1940 help='List of files to be marked as modified when '
1941 'executing presubmit or post-upload hooks. fnmatch '
1942 'wildcards can also be used.')
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001943 parser.add_argument('--gerrit_project', help=argparse.SUPPRESS)
Edward Lemura5799e32020-01-17 19:26:51 +00001944 options = parser.parse_args(argv)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001945
Erik Staabcca5c492020-04-16 17:40:07 +00001946 log_level = logging.ERROR
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001947 if options.verbose >= 2:
Erik Staabcca5c492020-04-16 17:40:07 +00001948 log_level = logging.DEBUG
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001949 elif options.verbose:
Erik Staabcca5c492020-04-16 17:40:07 +00001950 log_level = logging.INFO
1951 log_format = ('[%(levelname).1s%(asctime)s %(process)d %(thread)d '
1952 '%(filename)s] %(message)s')
1953 logging.basicConfig(format=log_format, level=log_level)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001954
Edward Lemur227d5102020-02-25 23:45:35 +00001955 if options.description_file:
1956 options.description = gclient_utils.FileRead(options.description_file)
Edward Lemur50984a62020-02-06 18:10:18 +00001957 gerrit_obj = _parse_gerrit_options(parser, options)
1958 change = _parse_change(parser, options)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001959
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001960 try:
Edward Lemur75526302020-02-27 22:31:05 +00001961 if options.post_upload:
1962 return DoPostUploadExecuter(
1963 change,
1964 gerrit_obj,
1965 options.verbose)
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001966 with canned_check_filter(options.skip_canned):
Edward Lemur6eb1d322020-02-27 22:20:15 +00001967 return DoPresubmitChecks(
Edward Lemur50984a62020-02-06 18:10:18 +00001968 change,
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001969 options.commit,
1970 options.verbose,
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001971 options.default_presubmit,
1972 options.may_prompt,
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001973 gerrit_obj,
Edward Lesmes8e282792018-04-03 18:50:29 -04001974 options.dry_run,
Debrian Figueroadd2737e2019-06-21 23:50:13 +00001975 options.parallel,
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001976 options.json_output,
1977 options.gerrit_project)
Raul Tambre7c938462019-05-24 16:35:35 +00001978 except PresubmitFailure as e:
Raul Tambre80ee78e2019-05-06 22:41:05 +00001979 print(e, file=sys.stderr)
1980 print('Maybe your depot_tools is out of date?', file=sys.stderr)
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001981 return 2
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001982
1983
1984if __name__ == '__main__':
maruel@chromium.org35625c72011-03-23 17:34:02 +00001985 fix_encoding.fix_encoding()
sbc@chromium.org013731e2015-02-26 18:28:43 +00001986 try:
1987 sys.exit(main())
1988 except KeyboardInterrupt:
1989 sys.stderr.write('interrupted\n')
sergiybf8a3b382016-07-05 11:21:30 -07001990 sys.exit(2)