blob: 8b006af7c2962acbd8db62a6f95faed3f1cb437b [file] [log] [blame]
maruel@chromium.org725f1c32011-04-01 20:24:54 +00001#!/usr/bin/env python
maruel@chromium.org3bbf2942012-01-10 16:52:06 +00002# Copyright (c) 2012 The Chromium Authors. All rights reserved.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00003# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5
6"""Enables directory-specific presubmit checks to run at upload and/or commit.
7"""
8
Raul Tambre80ee78e2019-05-06 22:41:05 +00009from __future__ import print_function
10
Saagar Sanghavi99816902020-08-11 22:41:25 +000011__version__ = '2.0.0'
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000012
13# TODO(joi) Add caching where appropriate/needed. The API is designed to allow
14# caching (between all different invocations of presubmit scripts for a given
15# change). We should add it as our presubmit scripts start feeling slow.
16
Edward Lemura5799e32020-01-17 19:26:51 +000017import argparse
Takeshi Yoshino07a6bea2017-08-02 02:44:06 +090018import ast # Exposed through the API.
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +000019import contextlib
Yoshisato Yanagisawa406de132018-06-29 05:43:25 +000020import cpplint
dcheng091b7db2016-06-16 01:27:51 -070021import fnmatch # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000022import glob
asvitkine@chromium.org15169952011-09-27 14:30:53 +000023import inspect
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +000024import itertools
maruel@chromium.org4f6852c2012-04-20 20:39:20 +000025import json # Exposed through the API.
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +000026import logging
ilevy@chromium.orgbc117312013-04-20 03:57:56 +000027import multiprocessing
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000028import os # Somewhat exposed through the API.
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +000029import random
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000030import re # Exposed through the API.
Edward Lesmes8e282792018-04-03 18:50:29 -040031import signal
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000032import sys # Parts exposed through API.
33import tempfile # Exposed through the API.
Edward Lesmes8e282792018-04-03 18:50:29 -040034import threading
jam@chromium.org2a891dc2009-08-20 20:33:37 +000035import time
Edward Lemurde9e3ca2019-10-24 21:13:31 +000036import traceback
maruel@chromium.org1487d532009-06-06 00:22:57 +000037import unittest # Exposed through the API.
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +000038from warnings import warn
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000039
40# Local imports.
maruel@chromium.org35625c72011-03-23 17:34:02 +000041import fix_encoding
Yoshisato Yanagisawa04600b42019-03-15 03:03:41 +000042import gclient_paths # Exposed through the API
43import gclient_utils
Aaron Gableb584c4f2017-04-26 16:28:08 -070044import git_footers
tandrii@chromium.org015ebae2016-04-25 19:37:22 +000045import gerrit_util
dpranke@chromium.org2a009622011-03-01 02:43:31 +000046import owners
Jochen Eisinger76f5fc62017-04-07 16:27:46 +020047import owners_finder
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000048import presubmit_canned_checks
Saagar Sanghavi9949ab72020-07-20 20:56:40 +000049import rdb_wrapper
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +000050import scm
maruel@chromium.org84f4fe32011-04-06 13:26:45 +000051import subprocess2 as subprocess # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000052
Edward Lemur16af3562019-10-17 22:11:33 +000053if sys.version_info.major == 2:
54 # TODO(1009814): Expose urllib2 only through urllib_request and urllib_error
55 import urllib2 # Exposed through the API.
56 import urlparse
57 import urllib2 as urllib_request
58 import urllib2 as urllib_error
59else:
60 import urllib.parse as urlparse
61 import urllib.request as urllib_request
62 import urllib.error as urllib_error
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000063
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +000064# Ask for feedback only once in program lifetime.
65_ASKED_FOR_FEEDBACK = False
66
Edward Lemurecc27072020-01-06 16:42:34 +000067def time_time():
68 # Use this so that it can be mocked in tests without interfering with python
69 # system machinery.
70 return time.time()
71
72
maruel@chromium.org899e1c12011-04-07 17:03:18 +000073class PresubmitFailure(Exception):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000074 pass
75
76
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000077class CommandData(object):
Edward Lemur940c2822019-08-23 00:34:25 +000078 def __init__(self, name, cmd, kwargs, message, python3=False):
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000079 self.name = name
80 self.cmd = cmd
Edward Lesmes8e282792018-04-03 18:50:29 -040081 self.stdin = kwargs.get('stdin', None)
Edward Lemur2d6b67c2019-08-23 22:25:41 +000082 self.kwargs = kwargs.copy()
Edward Lesmes8e282792018-04-03 18:50:29 -040083 self.kwargs['stdout'] = subprocess.PIPE
84 self.kwargs['stderr'] = subprocess.STDOUT
85 self.kwargs['stdin'] = subprocess.PIPE
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000086 self.message = message
87 self.info = None
Edward Lemur940c2822019-08-23 00:34:25 +000088 self.python3 = python3
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000089
ilevy@chromium.orgbc117312013-04-20 03:57:56 +000090
Edward Lesmes8e282792018-04-03 18:50:29 -040091# Adapted from
92# https://github.com/google/gtest-parallel/blob/master/gtest_parallel.py#L37
93#
94# An object that catches SIGINT sent to the Python process and notices
95# if processes passed to wait() die by SIGINT (we need to look for
96# both of those cases, because pressing Ctrl+C can result in either
97# the main process or one of the subprocesses getting the signal).
98#
99# Before a SIGINT is seen, wait(p) will simply call p.wait() and
100# return the result. Once a SIGINT has been seen (in the main process
101# or a subprocess, including the one the current call is waiting for),
Edward Lemur9a5bb612019-09-26 02:01:52 +0000102# wait(p) will call p.terminate().
Edward Lesmes8e282792018-04-03 18:50:29 -0400103class SigintHandler(object):
Edward Lesmes8e282792018-04-03 18:50:29 -0400104 sigint_returncodes = {-signal.SIGINT, # Unix
105 -1073741510, # Windows
106 }
107 def __init__(self):
108 self.__lock = threading.Lock()
109 self.__processes = set()
110 self.__got_sigint = False
Edward Lemur9a5bb612019-09-26 02:01:52 +0000111 self.__previous_signal = signal.signal(signal.SIGINT, self.interrupt)
Edward Lesmes8e282792018-04-03 18:50:29 -0400112
113 def __on_sigint(self):
114 self.__got_sigint = True
115 while self.__processes:
116 try:
117 self.__processes.pop().terminate()
118 except OSError:
119 pass
120
Edward Lemur9a5bb612019-09-26 02:01:52 +0000121 def interrupt(self, signal_num, frame):
Edward Lesmes8e282792018-04-03 18:50:29 -0400122 with self.__lock:
123 self.__on_sigint()
Edward Lemur9a5bb612019-09-26 02:01:52 +0000124 self.__previous_signal(signal_num, frame)
Edward Lesmes8e282792018-04-03 18:50:29 -0400125
126 def got_sigint(self):
127 with self.__lock:
128 return self.__got_sigint
129
130 def wait(self, p, stdin):
131 with self.__lock:
132 if self.__got_sigint:
133 p.terminate()
134 self.__processes.add(p)
135 stdout, stderr = p.communicate(stdin)
136 code = p.returncode
137 with self.__lock:
138 self.__processes.discard(p)
139 if code in self.sigint_returncodes:
140 self.__on_sigint()
Edward Lesmes8e282792018-04-03 18:50:29 -0400141 return stdout, stderr
142
143sigint_handler = SigintHandler()
144
145
Edward Lemurecc27072020-01-06 16:42:34 +0000146class Timer(object):
147 def __init__(self, timeout, fn):
148 self.completed = False
149 self._fn = fn
150 self._timer = threading.Timer(timeout, self._onTimer) if timeout else None
151
152 def __enter__(self):
153 if self._timer:
154 self._timer.start()
155 return self
156
157 def __exit__(self, _type, _value, _traceback):
158 if self._timer:
159 self._timer.cancel()
160
161 def _onTimer(self):
162 self._fn()
163 self.completed = True
164
165
Edward Lesmes8e282792018-04-03 18:50:29 -0400166class ThreadPool(object):
Edward Lemurecc27072020-01-06 16:42:34 +0000167 def __init__(self, pool_size=None, timeout=None):
168 self.timeout = timeout
Edward Lesmes8e282792018-04-03 18:50:29 -0400169 self._pool_size = pool_size or multiprocessing.cpu_count()
170 self._messages = []
171 self._messages_lock = threading.Lock()
172 self._tests = []
173 self._tests_lock = threading.Lock()
174 self._nonparallel_tests = []
175
Edward Lemurecc27072020-01-06 16:42:34 +0000176 def _GetCommand(self, test):
Edward Lemur940c2822019-08-23 00:34:25 +0000177 vpython = 'vpython'
178 if test.python3:
179 vpython += '3'
180 if sys.platform == 'win32':
181 vpython += '.bat'
Edward Lesmes8e282792018-04-03 18:50:29 -0400182
183 cmd = test.cmd
184 if cmd[0] == 'python':
185 cmd = list(cmd)
186 cmd[0] = vpython
187 elif cmd[0].endswith('.py'):
188 cmd = [vpython] + cmd
189
Edward Lemur336e51f2019-11-14 21:42:04 +0000190 # On Windows, scripts on the current directory take precedence over PATH, so
191 # that when testing depot_tools on Windows, calling `vpython.bat` will
192 # execute the copy of vpython of the depot_tools under test instead of the
193 # one in the bot.
194 # As a workaround, we run the tests from the parent directory instead.
195 if (cmd[0] == vpython and
196 'cwd' in test.kwargs and
197 os.path.basename(test.kwargs['cwd']) == 'depot_tools'):
198 test.kwargs['cwd'] = os.path.dirname(test.kwargs['cwd'])
199 cmd[1] = os.path.join('depot_tools', cmd[1])
200
Edward Lemurecc27072020-01-06 16:42:34 +0000201 return cmd
202
203 def _RunWithTimeout(self, cmd, stdin, kwargs):
204 p = subprocess.Popen(cmd, **kwargs)
205 with Timer(self.timeout, p.terminate) as timer:
206 stdout, _ = sigint_handler.wait(p, stdin)
207 if timer.completed:
208 stdout = 'Process timed out after %ss\n%s' % (self.timeout, stdout)
209 return p.returncode, stdout
210
211 def CallCommand(self, test):
212 """Runs an external program.
213
Edward Lemura5799e32020-01-17 19:26:51 +0000214 This function converts invocation of .py files and invocations of 'python'
Edward Lemurecc27072020-01-06 16:42:34 +0000215 to vpython invocations.
216 """
217 cmd = self._GetCommand(test)
Edward Lesmes8e282792018-04-03 18:50:29 -0400218 try:
Edward Lemurecc27072020-01-06 16:42:34 +0000219 start = time_time()
220 returncode, stdout = self._RunWithTimeout(cmd, test.stdin, test.kwargs)
221 duration = time_time() - start
Edward Lemur7cf94382019-11-15 22:36:41 +0000222 except Exception:
Edward Lemurecc27072020-01-06 16:42:34 +0000223 duration = time_time() - start
Edward Lesmes8e282792018-04-03 18:50:29 -0400224 return test.message(
Edward Lemur7cf94382019-11-15 22:36:41 +0000225 '%s\n%s exec failure (%4.2fs)\n%s' % (
226 test.name, ' '.join(cmd), duration, traceback.format_exc()))
Edward Lemurde9e3ca2019-10-24 21:13:31 +0000227
Edward Lemurecc27072020-01-06 16:42:34 +0000228 if returncode != 0:
Edward Lesmes8e282792018-04-03 18:50:29 -0400229 return test.message(
Edward Lemur7cf94382019-11-15 22:36:41 +0000230 '%s\n%s (%4.2fs) failed\n%s' % (
231 test.name, ' '.join(cmd), duration, stdout))
Edward Lemurecc27072020-01-06 16:42:34 +0000232
Edward Lesmes8e282792018-04-03 18:50:29 -0400233 if test.info:
Edward Lemur7cf94382019-11-15 22:36:41 +0000234 return test.info('%s\n%s (%4.2fs)' % (test.name, ' '.join(cmd), duration))
Edward Lesmes8e282792018-04-03 18:50:29 -0400235
236 def AddTests(self, tests, parallel=True):
237 if parallel:
238 self._tests.extend(tests)
239 else:
240 self._nonparallel_tests.extend(tests)
241
242 def RunAsync(self):
243 self._messages = []
244
245 def _WorkerFn():
246 while True:
247 test = None
248 with self._tests_lock:
249 if not self._tests:
250 break
251 test = self._tests.pop()
252 result = self.CallCommand(test)
253 if result:
254 with self._messages_lock:
255 self._messages.append(result)
256
257 def _StartDaemon():
258 t = threading.Thread(target=_WorkerFn)
259 t.daemon = True
260 t.start()
261 return t
262
263 while self._nonparallel_tests:
264 test = self._nonparallel_tests.pop()
265 result = self.CallCommand(test)
266 if result:
267 self._messages.append(result)
268
269 if self._tests:
270 threads = [_StartDaemon() for _ in range(self._pool_size)]
271 for worker in threads:
272 worker.join()
273
274 return self._messages
275
276
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000277def normpath(path):
278 '''Version of os.path.normpath that also changes backward slashes to
279 forward slashes when not running on Windows.
280 '''
281 # This is safe to always do because the Windows version of os.path.normpath
282 # will replace forward slashes with backward slashes.
283 path = path.replace(os.sep, '/')
284 return os.path.normpath(path)
285
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000286
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000287def _RightHandSideLinesImpl(affected_files):
288 """Implements RightHandSideLines for InputApi and GclChange."""
289 for af in affected_files:
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000290 lines = af.ChangedContents()
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000291 for line in lines:
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000292 yield (af, line[0], line[1])
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000293
294
Edward Lemur6eb1d322020-02-27 22:20:15 +0000295def prompt_should_continue(prompt_string):
296 sys.stdout.write(prompt_string)
297 response = sys.stdin.readline().strip().lower()
298 return response in ('y', 'yes')
dpranke@chromium.org5ac21012011-03-16 02:58:25 +0000299
300
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000301# Top level object so multiprocessing can pickle
302# Public access through OutputApi object.
303class _PresubmitResult(object):
304 """Base class for result objects."""
305 fatal = False
306 should_prompt = False
307
308 def __init__(self, message, items=None, long_text=''):
309 """
310 message: A short one-line message to indicate errors.
311 items: A list of short strings to indicate where errors occurred.
312 long_text: multi-line text output, e.g. from another tool
313 """
314 self._message = message
315 self._items = items or []
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000316 self._long_text = long_text.rstrip()
317
Edward Lemur6eb1d322020-02-27 22:20:15 +0000318 def handle(self):
319 sys.stdout.write(self._message)
320 sys.stdout.write('\n')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000321 for index, item in enumerate(self._items):
Edward Lemur6eb1d322020-02-27 22:20:15 +0000322 sys.stdout.write(' ')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000323 # Write separately in case it's unicode.
Edward Lemur6eb1d322020-02-27 22:20:15 +0000324 sys.stdout.write(str(item))
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000325 if index < len(self._items) - 1:
Edward Lemur6eb1d322020-02-27 22:20:15 +0000326 sys.stdout.write(' \\')
327 sys.stdout.write('\n')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000328 if self._long_text:
Edward Lemur6eb1d322020-02-27 22:20:15 +0000329 sys.stdout.write('\n***************\n')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000330 # Write separately in case it's unicode.
Edward Lemur6eb1d322020-02-27 22:20:15 +0000331 sys.stdout.write(self._long_text)
332 sys.stdout.write('\n***************\n')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000333
Debrian Figueroadd2737e2019-06-21 23:50:13 +0000334 def json_format(self):
335 return {
336 'message': self._message,
Debrian Figueroa6095d402019-06-28 18:47:18 +0000337 'items': [str(item) for item in self._items],
Debrian Figueroadd2737e2019-06-21 23:50:13 +0000338 'long_text': self._long_text,
339 'fatal': self.fatal
340 }
341
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000342
343# Top level object so multiprocessing can pickle
344# Public access through OutputApi object.
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000345class _PresubmitError(_PresubmitResult):
346 """A hard presubmit error."""
347 fatal = True
348
349
350# Top level object so multiprocessing can pickle
351# Public access through OutputApi object.
352class _PresubmitPromptWarning(_PresubmitResult):
353 """An warning that prompts the user if they want to continue."""
354 should_prompt = True
355
356
357# Top level object so multiprocessing can pickle
358# Public access through OutputApi object.
359class _PresubmitNotifyResult(_PresubmitResult):
360 """Just print something to the screen -- but it's not even a warning."""
361 pass
362
363
364# Top level object so multiprocessing can pickle
365# Public access through OutputApi object.
366class _MailTextResult(_PresubmitResult):
367 """A warning that should be included in the review request email."""
368 def __init__(self, *args, **kwargs):
369 super(_MailTextResult, self).__init__()
370 raise NotImplementedError()
371
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000372class GerritAccessor(object):
373 """Limited Gerrit functionality for canned presubmit checks to work.
374
375 To avoid excessive Gerrit calls, caches the results.
376 """
377
378 def __init__(self, host):
379 self.host = host
380 self.cache = {}
381
382 def _FetchChangeDetail(self, issue):
383 # Separate function to be easily mocked in tests.
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +0100384 try:
385 return gerrit_util.GetChangeDetail(
386 self.host, str(issue),
Aaron Gable6f5a8d92017-04-18 14:49:05 -0700387 ['ALL_REVISIONS', 'DETAILED_LABELS', 'ALL_COMMITS'])
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +0100388 except gerrit_util.GerritError as e:
389 if e.http_status == 404:
390 raise Exception('Either Gerrit issue %s doesn\'t exist, or '
391 'no credentials to fetch issue details' % issue)
392 raise
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000393
394 def GetChangeInfo(self, issue):
395 """Returns labels and all revisions (patchsets) for this issue.
396
397 The result is a dictionary according to Gerrit REST Api.
398 https://gerrit-review.googlesource.com/Documentation/rest-api.html
399
400 However, API isn't very clear what's inside, so see tests for example.
401 """
402 assert issue
403 cache_key = int(issue)
404 if cache_key not in self.cache:
405 self.cache[cache_key] = self._FetchChangeDetail(issue)
406 return self.cache[cache_key]
407
408 def GetChangeDescription(self, issue, patchset=None):
409 """If patchset is none, fetches current patchset."""
410 info = self.GetChangeInfo(issue)
411 # info is a reference to cache. We'll modify it here adding description to
412 # it to the right patchset, if it is not yet there.
413
414 # Find revision info for the patchset we want.
415 if patchset is not None:
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +0000416 for rev, rev_info in info['revisions'].items():
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000417 if str(rev_info['_number']) == str(patchset):
418 break
419 else:
420 raise Exception('patchset %s doesn\'t exist in issue %s' % (
421 patchset, issue))
422 else:
423 rev = info['current_revision']
424 rev_info = info['revisions'][rev]
425
Andrii Shyshkalov9c3a4642017-01-24 17:41:22 +0100426 return rev_info['commit']['message']
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000427
Mun Yong Jang603d01e2017-12-19 16:38:30 -0800428 def GetDestRef(self, issue):
429 ref = self.GetChangeInfo(issue)['branch']
430 if not ref.startswith('refs/'):
431 # NOTE: it is possible to create 'refs/x' branch,
432 # aka 'refs/heads/refs/x'. However, this is ill-advised.
433 ref = 'refs/heads/%s' % ref
434 return ref
435
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000436 def GetChangeOwner(self, issue):
437 return self.GetChangeInfo(issue)['owner']['email']
438
439 def GetChangeReviewers(self, issue, approving_only=True):
Aaron Gable8b478f02017-07-31 15:33:19 -0700440 changeinfo = self.GetChangeInfo(issue)
441 if approving_only:
442 labelinfo = changeinfo.get('labels', {}).get('Code-Review', {})
443 values = labelinfo.get('values', {}).keys()
444 try:
445 max_value = max(int(v) for v in values)
446 reviewers = [r for r in labelinfo.get('all', [])
447 if r.get('value', 0) == max_value]
448 except ValueError: # values is the empty list
449 reviewers = []
450 else:
451 reviewers = changeinfo.get('reviewers', {}).get('REVIEWER', [])
452 return [r.get('email') for r in reviewers]
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000453
Edward Lemure4d329c2020-02-03 20:41:18 +0000454 def UpdateDescription(self, description, issue):
455 gerrit_util.SetCommitMessage(self.host, issue, description, notify='NONE')
456
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000457
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000458class OutputApi(object):
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000459 """An instance of OutputApi gets passed to presubmit scripts so that they
460 can output various types of results.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000461 """
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000462 PresubmitResult = _PresubmitResult
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000463 PresubmitError = _PresubmitError
464 PresubmitPromptWarning = _PresubmitPromptWarning
465 PresubmitNotifyResult = _PresubmitNotifyResult
466 MailTextResult = _MailTextResult
467
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000468 def __init__(self, is_committing):
469 self.is_committing = is_committing
Daniel Cheng7227d212017-11-17 08:12:37 -0800470 self.more_cc = []
471
472 def AppendCC(self, cc):
473 """Appends a user to cc for this change."""
474 self.more_cc.append(cc)
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000475
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000476 def PresubmitPromptOrNotify(self, *args, **kwargs):
477 """Warn the user when uploading, but only notify if committing."""
478 if self.is_committing:
479 return self.PresubmitNotifyResult(*args, **kwargs)
480 return self.PresubmitPromptWarning(*args, **kwargs)
481
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000482
483class InputApi(object):
484 """An instance of this object is passed to presubmit scripts so they can
485 know stuff about the change they're looking at.
486 """
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000487 # Method could be a function
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800488 # pylint: disable=no-self-use
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000489
maruel@chromium.org3410d912009-06-09 20:56:16 +0000490 # File extensions that are considered source files from a style guide
491 # perspective. Don't modify this list from a presubmit script!
maruel@chromium.orgc33455a2011-06-24 19:14:18 +0000492 #
493 # Files without an extension aren't included in the list. If you want to
local_bot30f774e2020-06-25 18:23:34 +0000494 # filter them as source files, add r'(^|.*?[\\\/])[^.]+$' to the allow list.
local_bot64021412020-07-08 21:05:39 +0000495 # Note that ALL CAPS files are skipped in DEFAULT_FILES_TO_SKIP below.
496 DEFAULT_FILES_TO_CHECK = (
maruel@chromium.org3410d912009-06-09 20:56:16 +0000497 # C++ and friends
Edward Lemura5799e32020-01-17 19:26:51 +0000498 r'.+\.c$', r'.+\.cc$', r'.+\.cpp$', r'.+\.h$', r'.+\.m$', r'.+\.mm$',
499 r'.+\.inl$', r'.+\.asm$', r'.+\.hxx$', r'.+\.hpp$', r'.+\.s$', r'.+\.S$',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000500 # Scripts
Edward Lemura5799e32020-01-17 19:26:51 +0000501 r'.+\.js$', r'.+\.py$', r'.+\.sh$', r'.+\.rb$', r'.+\.pl$', r'.+\.pm$',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000502 # Other
Edward Lemura5799e32020-01-17 19:26:51 +0000503 r'.+\.java$', r'.+\.mk$', r'.+\.am$', r'.+\.css$', r'.+\.mojom$',
504 r'.+\.fidl$'
maruel@chromium.org3410d912009-06-09 20:56:16 +0000505 )
506
507 # Path regexp that should be excluded from being considered containing source
508 # files. Don't modify this list from a presubmit script!
local_bot64021412020-07-08 21:05:39 +0000509 DEFAULT_FILES_TO_SKIP = (
Edward Lemura5799e32020-01-17 19:26:51 +0000510 r'testing_support[\\\/]google_appengine[\\\/].*',
511 r'.*\bexperimental[\\\/].*',
Kent Tamura179dd1e2018-04-26 15:07:41 +0900512 # Exclude third_party/.* but NOT third_party/{WebKit,blink}
513 # (crbug.com/539768 and crbug.com/836555).
Edward Lemura5799e32020-01-17 19:26:51 +0000514 r'.*\bthird_party[\\\/](?!(WebKit|blink)[\\\/]).*',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000515 # Output directories (just in case)
Edward Lemura5799e32020-01-17 19:26:51 +0000516 r'.*\bDebug[\\\/].*',
517 r'.*\bRelease[\\\/].*',
518 r'.*\bxcodebuild[\\\/].*',
519 r'.*\bout[\\\/].*',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000520 # All caps files like README and LICENCE.
Edward Lemura5799e32020-01-17 19:26:51 +0000521 r'.*\b[A-Z0-9_]{2,}$',
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +0000522 # SCM (can happen in dual SCM configuration). (Slightly over aggressive)
Edward Lemura5799e32020-01-17 19:26:51 +0000523 r'(|.*[\\\/])\.git[\\\/].*',
524 r'(|.*[\\\/])\.svn[\\\/].*',
maruel@chromium.org7ccb4bb2011-11-07 20:26:20 +0000525 # There is no point in processing a patch file.
Edward Lemura5799e32020-01-17 19:26:51 +0000526 r'.+\.diff$',
527 r'.+\.patch$',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000528 )
529
local_bot30f774e2020-06-25 18:23:34 +0000530 # TODO(https://crbug.com/1098562): Remove once no longer used
531 @property
532 def DEFAULT_WHITE_LIST(self):
local_bot64021412020-07-08 21:05:39 +0000533 return self.DEFAULT_FILES_TO_CHECK
local_bot30f774e2020-06-25 18:23:34 +0000534
535 # TODO(https://crbug.com/1098562): Remove once no longer used
local_bot37ce2012020-06-26 17:39:24 +0000536 @DEFAULT_WHITE_LIST.setter
537 def DEFAULT_WHITE_LIST(self, value):
local_bot64021412020-07-08 21:05:39 +0000538 self.DEFAULT_FILES_TO_CHECK = value
539
540 # TODO(https://crbug.com/1098562): Remove once no longer used
541 @property
542 def DEFAULT_ALLOW_LIST(self):
543 return self.DEFAULT_FILES_TO_CHECK
544
545 # TODO(https://crbug.com/1098562): Remove once no longer used
546 @DEFAULT_ALLOW_LIST.setter
547 def DEFAULT_ALLOW_LIST(self, value):
548 self.DEFAULT_FILES_TO_CHECK = value
local_bot37ce2012020-06-26 17:39:24 +0000549
550 # TODO(https://crbug.com/1098562): Remove once no longer used
local_bot30f774e2020-06-25 18:23:34 +0000551 @property
552 def DEFAULT_BLACK_LIST(self):
local_bot64021412020-07-08 21:05:39 +0000553 return self.DEFAULT_FILES_TO_SKIP
local_bot30f774e2020-06-25 18:23:34 +0000554
local_bot37ce2012020-06-26 17:39:24 +0000555 # TODO(https://crbug.com/1098562): Remove once no longer used
556 @DEFAULT_BLACK_LIST.setter
557 def DEFAULT_BLACK_LIST(self, value):
local_bot64021412020-07-08 21:05:39 +0000558 self.DEFAULT_FILES_TO_SKIP = value
559
560 # TODO(https://crbug.com/1098562): Remove once no longer used
561 @property
562 def DEFAULT_BLOCK_LIST(self):
563 return self.DEFAULT_FILES_TO_SKIP
564
565 # TODO(https://crbug.com/1098562): Remove once no longer used
566 @DEFAULT_BLOCK_LIST.setter
567 def DEFAULT_BLOCK_LIST(self, value):
568 self.DEFAULT_FILES_TO_SKIP = value
local_bot37ce2012020-06-26 17:39:24 +0000569
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000570 def __init__(self, change, presubmit_path, is_committing,
Edward Lesmes8e282792018-04-03 18:50:29 -0400571 verbose, gerrit_obj, dry_run=None, thread_pool=None, parallel=False):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000572 """Builds an InputApi object.
573
574 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000575 change: A presubmit.Change object.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000576 presubmit_path: The path to the presubmit script being processed.
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000577 is_committing: True if the change is about to be committed.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000578 gerrit_obj: provides basic Gerrit codereview functionality.
579 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -0400580 parallel: if true, all tests reported via input_api.RunTests for all
581 PRESUBMIT files will be run in parallel.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000582 """
maruel@chromium.org9711bba2009-05-22 23:51:39 +0000583 # Version number of the presubmit_support script.
584 self.version = [int(x) for x in __version__.split('.')]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000585 self.change = change
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000586 self.is_committing = is_committing
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000587 self.gerrit = gerrit_obj
tandrii@chromium.org57bafac2016-04-28 05:09:03 +0000588 self.dry_run = dry_run
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000589
Edward Lesmes8e282792018-04-03 18:50:29 -0400590 self.parallel = parallel
591 self.thread_pool = thread_pool or ThreadPool()
592
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000593 # We expose various modules and functions as attributes of the input_api
594 # so that presubmit scripts don't have to import them.
Takeshi Yoshino07a6bea2017-08-02 02:44:06 +0900595 self.ast = ast
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000596 self.basename = os.path.basename
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000597 self.cpplint = cpplint
dcheng091b7db2016-06-16 01:27:51 -0700598 self.fnmatch = fnmatch
Yoshisato Yanagisawa04600b42019-03-15 03:03:41 +0000599 self.gclient_paths = gclient_paths
Yoshisato Yanagisawa57dd17b2019-03-22 09:10:29 +0000600 # TODO(yyanagisawa): stop exposing this when python3 become default.
601 # Since python3's tempfile has TemporaryDirectory, we do not need this.
602 self.temporary_directory = gclient_utils.temporary_directory
dpranke@chromium.org17cc2442012-10-17 21:12:09 +0000603 self.glob = glob.glob
maruel@chromium.orgfb11c7b2010-03-18 18:22:14 +0000604 self.json = json
maruel@chromium.org6fba34d2011-06-02 13:45:12 +0000605 self.logging = logging.getLogger('PRESUBMIT')
maruel@chromium.org2b5ce562011-03-31 16:15:44 +0000606 self.os_listdir = os.listdir
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000607 self.os_path = os.path
pgervais@chromium.orgbd0cace2014-10-02 23:23:46 +0000608 self.os_stat = os.stat
Yoshisato Yanagisawa406de132018-06-29 05:43:25 +0000609 self.os_walk = os.walk
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000610 self.re = re
611 self.subprocess = subprocess
Edward Lemurb9830242019-10-30 22:19:20 +0000612 self.sys = sys
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000613 self.tempfile = tempfile
dpranke@chromium.org0d1bdea2011-03-24 22:54:38 +0000614 self.time = time
maruel@chromium.org1487d532009-06-06 00:22:57 +0000615 self.unittest = unittest
Edward Lemurb9830242019-10-30 22:19:20 +0000616 if sys.version_info.major == 2:
617 self.urllib2 = urllib2
Edward Lemur16af3562019-10-17 22:11:33 +0000618 self.urllib_request = urllib_request
619 self.urllib_error = urllib_error
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000620
Robert Iannucci50258932018-03-19 10:30:59 -0700621 self.is_windows = sys.platform == 'win32'
622
Edward Lemurb9646622019-10-25 20:57:35 +0000623 # Set python_executable to 'vpython' in order to allow scripts in other
624 # repos (e.g. src.git) to automatically pick up that repo's .vpython file,
625 # instead of inheriting the one in depot_tools.
626 self.python_executable = 'vpython'
maruel@chromium.orgc0b22972009-06-25 16:19:14 +0000627 self.environ = os.environ
628
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000629 # InputApi.platform is the platform you're currently running on.
630 self.platform = sys.platform
631
iannucci@chromium.org0af3bb32015-06-12 20:44:35 +0000632 self.cpu_count = multiprocessing.cpu_count()
633
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000634 # The local path of the currently-being-processed presubmit script.
maruel@chromium.org3d235242009-05-15 12:40:48 +0000635 self._current_presubmit_path = os.path.dirname(presubmit_path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000636
637 # We carry the canned checks so presubmit scripts can easily use them.
638 self.canned_checks = presubmit_canned_checks
639
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +0100640 # Temporary files we must manually remove at the end of a run.
641 self._named_temporary_files = []
Jochen Eisinger72606f82017-04-04 10:44:18 +0200642
dpranke@chromium.org2a009622011-03-01 02:43:31 +0000643 # TODO(dpranke): figure out a list of all approved owners for a repo
644 # in order to be able to handle wildcard OWNERS files?
645 self.owners_db = owners.Database(change.RepositoryRoot(),
Edward Lemurb9830242019-10-30 22:19:20 +0000646 fopen=open, os_path=self.os_path)
Jochen Eisinger76f5fc62017-04-07 16:27:46 +0200647 self.owners_finder = owners_finder.OwnersFinder
maruel@chromium.org899e1c12011-04-07 17:03:18 +0000648 self.verbose = verbose
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000649 self.Command = CommandData
dpranke@chromium.org2a009622011-03-01 02:43:31 +0000650
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000651 # Replace <hash_map> and <hash_set> as headers that need to be included
Edward Lemura5799e32020-01-17 19:26:51 +0000652 # with 'base/containers/hash_tables.h' instead.
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000653 # Access to a protected member _XX of a client class
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800654 # pylint: disable=protected-access
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000655 self.cpplint._re_pattern_templates = [
danakj@chromium.org18278522013-06-11 22:42:32 +0000656 (a, b, 'base/containers/hash_tables.h')
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000657 if header in ('<hash_map>', '<hash_set>') else (a, b, header)
658 for (a, b, header) in cpplint._re_pattern_templates
659 ]
660
Edward Lemurecc27072020-01-06 16:42:34 +0000661 def SetTimeout(self, timeout):
662 self.thread_pool.timeout = timeout
663
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000664 def PresubmitLocalPath(self):
665 """Returns the local path of the presubmit script currently being run.
666
667 This is useful if you don't want to hard-code absolute paths in the
668 presubmit script. For example, It can be used to find another file
669 relative to the PRESUBMIT.py script, so the whole tree can be branched and
670 the presubmit script still works, without editing its content.
671 """
maruel@chromium.org3d235242009-05-15 12:40:48 +0000672 return self._current_presubmit_path
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000673
agable0b65e732016-11-22 09:25:46 -0800674 def AffectedFiles(self, include_deletes=True, file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000675 """Same as input_api.change.AffectedFiles() except only lists files
676 (and optionally directories) in the same directory as the current presubmit
Bruce Dawson7a0b07a2020-04-23 17:14:40 +0000677 script, or subdirectories thereof. Note that files are listed using the OS
678 path separator, so backslashes are used as separators on Windows.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000679 """
Edward Lemura5799e32020-01-17 19:26:51 +0000680 dir_with_slash = normpath('%s/' % self.PresubmitLocalPath())
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000681 if len(dir_with_slash) == 1:
682 dir_with_slash = ''
sail@chromium.org5538e022011-05-12 17:53:16 +0000683
Edward Lemurb9830242019-10-30 22:19:20 +0000684 return list(filter(
maruel@chromium.org4661e0c2009-06-04 00:45:26 +0000685 lambda x: normpath(x.AbsoluteLocalPath()).startswith(dir_with_slash),
Edward Lemurb9830242019-10-30 22:19:20 +0000686 self.change.AffectedFiles(include_deletes, file_filter)))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000687
agable0b65e732016-11-22 09:25:46 -0800688 def LocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000689 """Returns local paths of input_api.AffectedFiles()."""
agable0b65e732016-11-22 09:25:46 -0800690 paths = [af.LocalPath() for af in self.AffectedFiles()]
Edward Lemura5799e32020-01-17 19:26:51 +0000691 logging.debug('LocalPaths: %s', paths)
pgervais@chromium.org2f64f782014-04-25 00:12:33 +0000692 return paths
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000693
agable0b65e732016-11-22 09:25:46 -0800694 def AbsoluteLocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000695 """Returns absolute local paths of input_api.AffectedFiles()."""
agable0b65e732016-11-22 09:25:46 -0800696 return [af.AbsoluteLocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000697
John Budorick16162372018-04-18 10:39:53 -0700698 def AffectedTestableFiles(self, include_deletes=None, **kwargs):
agable0b65e732016-11-22 09:25:46 -0800699 """Same as input_api.change.AffectedTestableFiles() except only lists files
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000700 in the same directory as the current presubmit script, or subdirectories
701 thereof.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000702 """
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000703 if include_deletes is not None:
Edward Lemura5799e32020-01-17 19:26:51 +0000704 warn('AffectedTestableFiles(include_deletes=%s)'
705 ' is deprecated and ignored' % str(include_deletes),
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000706 category=DeprecationWarning,
707 stacklevel=2)
Edward Lemurb9830242019-10-30 22:19:20 +0000708 return list(filter(
709 lambda x: x.IsTestableFile(),
710 self.AffectedFiles(include_deletes=False, **kwargs)))
agable0b65e732016-11-22 09:25:46 -0800711
712 def AffectedTextFiles(self, include_deletes=None):
713 """An alias to AffectedTestableFiles for backwards compatibility."""
714 return self.AffectedTestableFiles(include_deletes=include_deletes)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000715
local_bot64021412020-07-08 21:05:39 +0000716 def FilterSourceFile(self, affected_file, files_to_check=None,
717 files_to_skip=None, allow_list=None, block_list=None,
local_bot30f774e2020-06-25 18:23:34 +0000718 white_list=None, black_list=None):
Edward Lemura5799e32020-01-17 19:26:51 +0000719 """Filters out files that aren't considered 'source file'.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000720
local_bot64021412020-07-08 21:05:39 +0000721 If files_to_check or files_to_skip is None, InputApi.DEFAULT_FILES_TO_CHECK
722 and InputApi.DEFAULT_FILES_TO_SKIP is used respectively.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000723
724 The lists will be compiled as regular expression and
725 AffectedFile.LocalPath() needs to pass both list.
726
local_bot64021412020-07-08 21:05:39 +0000727 Note: if files_to_check or files_to_skip is not set, and
728 white_list/allow_list or black_list/block_list is, then those values are
729 used. This is used for backward compatibility reasons.
local_bot30f774e2020-06-25 18:23:34 +0000730
maruel@chromium.org3410d912009-06-09 20:56:16 +0000731 Note: Copy-paste this function to suit your needs or use a lambda function.
732 """
Josip Sokcevicc6aa1512020-08-25 23:47:13 +0000733 # TODO(https://crbug.com/1098560): Remove non inclusive parameter names.
734 if files_to_check is None and (allow_list or white_list):
735 warn('Use files_to_check in FilterSourceFile')
local_bot64021412020-07-08 21:05:39 +0000736 files_to_check = allow_list or white_list
Josip Sokcevicc6aa1512020-08-25 23:47:13 +0000737 if files_to_skip is None and (block_list or black_list):
738 warn('Use files_to_skip in FilterSourceFile')
local_bot64021412020-07-08 21:05:39 +0000739 files_to_skip = block_list or black_list
740
741 if files_to_check is None:
742 files_to_check = self.DEFAULT_FILES_TO_CHECK
743 if files_to_skip is None:
744 files_to_skip = self.DEFAULT_FILES_TO_SKIP
local_bot30f774e2020-06-25 18:23:34 +0000745
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000746 def Find(affected_file, items):
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000747 local_path = affected_file.LocalPath()
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000748 for item in items:
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +0000749 if self.re.match(item, local_path):
maruel@chromium.org3410d912009-06-09 20:56:16 +0000750 return True
751 return False
local_bot64021412020-07-08 21:05:39 +0000752 return (Find(affected_file, files_to_check) and
753 not Find(affected_file, files_to_skip))
maruel@chromium.org3410d912009-06-09 20:56:16 +0000754
755 def AffectedSourceFiles(self, source_file):
agable0b65e732016-11-22 09:25:46 -0800756 """Filter the list of AffectedTestableFiles by the function source_file.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000757
758 If source_file is None, InputApi.FilterSourceFile() is used.
759 """
760 if not source_file:
761 source_file = self.FilterSourceFile
Edward Lemurb9830242019-10-30 22:19:20 +0000762 return list(filter(source_file, self.AffectedTestableFiles()))
maruel@chromium.org3410d912009-06-09 20:56:16 +0000763
764 def RightHandSideLines(self, source_file_filter=None):
Edward Lemura5799e32020-01-17 19:26:51 +0000765 """An iterator over all text lines in 'new' version of changed files.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000766
767 Only lists lines from new or modified text files in the change that are
768 contained by the directory of the currently executing presubmit script.
769
770 This is useful for doing line-by-line regex checks, like checking for
771 trailing whitespace.
772
773 Yields:
774 a 3 tuple:
775 the AffectedFile instance of the current file;
776 integer line number (1-based); and
777 the contents of the line as a string.
maruel@chromium.org1487d532009-06-06 00:22:57 +0000778
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000779 Note: The carriage return (LF or CR) is stripped off.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000780 """
maruel@chromium.org3410d912009-06-09 20:56:16 +0000781 files = self.AffectedSourceFiles(source_file_filter)
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000782 return _RightHandSideLinesImpl(files)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000783
maruel@chromium.orge3608df2009-11-10 20:22:57 +0000784 def ReadFile(self, file_item, mode='r'):
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000785 """Reads an arbitrary file.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000786
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000787 Deny reading anything outside the repository.
788 """
maruel@chromium.orge3608df2009-11-10 20:22:57 +0000789 if isinstance(file_item, AffectedFile):
790 file_item = file_item.AbsoluteLocalPath()
791 if not file_item.startswith(self.change.RepositoryRoot()):
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000792 raise IOError('Access outside the repository root is denied.')
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +0000793 return gclient_utils.FileRead(file_item, mode)
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000794
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +0100795 def CreateTemporaryFile(self, **kwargs):
796 """Returns a named temporary file that must be removed with a call to
797 RemoveTemporaryFiles().
798
799 All keyword arguments are forwarded to tempfile.NamedTemporaryFile(),
800 except for |delete|, which is always set to False.
801
802 Presubmit checks that need to create a temporary file and pass it for
803 reading should use this function instead of NamedTemporaryFile(), as
804 Windows fails to open a file that is already open for writing.
805
806 with input_api.CreateTemporaryFile() as f:
807 f.write('xyz')
808 f.close()
809 input_api.subprocess.check_output(['script-that', '--reads-from',
810 f.name])
811
812
813 Note that callers of CreateTemporaryFile() should not worry about removing
814 any temporary file; this is done transparently by the presubmit handling
815 code.
816 """
817 if 'delete' in kwargs:
818 # Prevent users from passing |delete|; we take care of file deletion
819 # ourselves and this prevents unintuitive error messages when we pass
820 # delete=False and 'delete' is also in kwargs.
821 raise TypeError('CreateTemporaryFile() does not take a "delete" '
822 'argument, file deletion is handled automatically by '
823 'the same presubmit_support code that creates InputApi '
824 'objects.')
825 temp_file = self.tempfile.NamedTemporaryFile(delete=False, **kwargs)
826 self._named_temporary_files.append(temp_file.name)
827 return temp_file
828
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000829 @property
830 def tbr(self):
831 """Returns if a change is TBR'ed."""
Jeremy Romandce22502017-06-20 15:37:29 -0400832 return 'TBR' in self.change.tags or self.change.TBRsFromDescription()
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000833
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +0000834 def RunTests(self, tests_mix, parallel=True):
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000835 tests = []
836 msgs = []
837 for t in tests_mix:
Edward Lesmes8e282792018-04-03 18:50:29 -0400838 if isinstance(t, OutputApi.PresubmitResult) and t:
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000839 msgs.append(t)
840 else:
841 assert issubclass(t.message, _PresubmitResult)
842 tests.append(t)
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +0000843 if self.verbose:
844 t.info = _PresubmitNotifyResult
Edward Lemur1037c742018-05-01 18:56:04 -0400845 if not t.kwargs.get('cwd'):
846 t.kwargs['cwd'] = self.PresubmitLocalPath()
Edward Lesmes8e282792018-04-03 18:50:29 -0400847 self.thread_pool.AddTests(tests, parallel)
Edward Lemur21000eb2019-05-24 23:25:58 +0000848 # When self.parallel is True (i.e. --parallel is passed as an option)
849 # RunTests doesn't actually run tests. It adds them to a ThreadPool that
850 # will run all tests once all PRESUBMIT files are processed.
851 # Otherwise, it will run them and return the results.
852 if not self.parallel:
Edward Lesmes8e282792018-04-03 18:50:29 -0400853 msgs.extend(self.thread_pool.RunAsync())
854 return msgs
scottmg86099d72016-09-01 09:16:51 -0700855
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000856
nick@chromium.orgff526192013-06-10 19:30:26 +0000857class _DiffCache(object):
858 """Caches diffs retrieved from a particular SCM."""
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000859 def __init__(self, upstream=None):
860 """Stores the upstream revision against which all diffs will be computed."""
861 self._upstream = upstream
nick@chromium.orgff526192013-06-10 19:30:26 +0000862
863 def GetDiff(self, path, local_root):
864 """Get the diff for a particular path."""
865 raise NotImplementedError()
866
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700867 def GetOldContents(self, path, local_root):
868 """Get the old version for a particular path."""
869 raise NotImplementedError()
870
nick@chromium.orgff526192013-06-10 19:30:26 +0000871
nick@chromium.orgff526192013-06-10 19:30:26 +0000872class _GitDiffCache(_DiffCache):
873 """DiffCache implementation for git; gets all file diffs at once."""
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000874 def __init__(self, upstream):
875 super(_GitDiffCache, self).__init__(upstream=upstream)
nick@chromium.orgff526192013-06-10 19:30:26 +0000876 self._diffs_by_file = None
877
878 def GetDiff(self, path, local_root):
879 if not self._diffs_by_file:
880 # Compute a single diff for all files and parse the output; should
881 # with git this is much faster than computing one diff for each file.
882 diffs = {}
883
884 # Don't specify any filenames below, because there are command line length
885 # limits on some platforms and GenerateDiff would fail.
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000886 unified_diff = scm.GIT.GenerateDiff(local_root, files=[], full_move=True,
887 branch=self._upstream)
nick@chromium.orgff526192013-06-10 19:30:26 +0000888
889 # This regex matches the path twice, separated by a space. Note that
890 # filename itself may contain spaces.
891 file_marker = re.compile('^diff --git (?P<filename>.*) (?P=filename)$')
892 current_diff = []
893 keep_line_endings = True
894 for x in unified_diff.splitlines(keep_line_endings):
895 match = file_marker.match(x)
896 if match:
897 # Marks the start of a new per-file section.
898 diffs[match.group('filename')] = current_diff = [x]
899 elif x.startswith('diff --git'):
900 raise PresubmitFailure('Unexpected diff line: %s' % x)
901 else:
902 current_diff.append(x)
903
904 self._diffs_by_file = dict(
905 (normpath(path), ''.join(diff)) for path, diff in diffs.items())
906
907 if path not in self._diffs_by_file:
908 raise PresubmitFailure(
909 'Unified diff did not contain entry for file %s' % path)
910
911 return self._diffs_by_file[path]
912
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700913 def GetOldContents(self, path, local_root):
914 return scm.GIT.GetOldContents(local_root, path, branch=self._upstream)
915
nick@chromium.orgff526192013-06-10 19:30:26 +0000916
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000917class AffectedFile(object):
918 """Representation of a file in a change."""
nick@chromium.orgff526192013-06-10 19:30:26 +0000919
920 DIFF_CACHE = _DiffCache
921
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000922 # Method could be a function
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800923 # pylint: disable=no-self-use
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000924 def __init__(self, path, action, repository_root, diff_cache):
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000925 self._path = path
926 self._action = action
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000927 self._local_root = repository_root
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000928 self._is_directory = None
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000929 self._cached_changed_contents = None
930 self._cached_new_contents = None
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000931 self._diff_cache = diff_cache
tobiasjs2836bcf2016-08-16 04:08:16 -0700932 logging.debug('%s(%s)', self.__class__.__name__, self._path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000933
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000934 def LocalPath(self):
935 """Returns the path of this file on the local disk relative to client root.
Andrew Grieve92b8b992017-11-02 09:42:24 -0400936
937 This should be used for error messages but not for accessing files,
938 because presubmit checks are run with CWD=PresubmitLocalPath() (which is
939 often != client root).
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000940 """
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000941 return normpath(self._path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000942
943 def AbsoluteLocalPath(self):
944 """Returns the absolute path of this file on the local disk.
945 """
chase@chromium.org8e416c82009-10-06 04:30:44 +0000946 return os.path.abspath(os.path.join(self._local_root, self.LocalPath()))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000947
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000948 def Action(self):
949 """Returns the action on this opened file, e.g. A, M, D, etc."""
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000950 return self._action
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000951
agable0b65e732016-11-22 09:25:46 -0800952 def IsTestableFile(self):
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000953 """Returns True if the file is a text file and not a binary file.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000954
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000955 Deleted files are not text file."""
maruel@chromium.org1e08c002009-05-28 19:09:33 +0000956 raise NotImplementedError() # Implement when needed
957
agable0b65e732016-11-22 09:25:46 -0800958 def IsTextFile(self):
959 """An alias to IsTestableFile for backwards compatibility."""
960 return self.IsTestableFile()
961
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700962 def OldContents(self):
963 """Returns an iterator over the lines in the old version of file.
964
Daniel Cheng2da34fe2017-03-21 20:42:12 -0700965 The old version is the file before any modifications in the user's
Edward Lemura5799e32020-01-17 19:26:51 +0000966 workspace, i.e. the 'left hand side'.
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700967
968 Contents will be empty if the file is a directory or does not exist.
969 Note: The carriage returns (LF or CR) are stripped off.
970 """
971 return self._diff_cache.GetOldContents(self.LocalPath(),
972 self._local_root).splitlines()
973
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000974 def NewContents(self):
975 """Returns an iterator over the lines in the new version of file.
976
Edward Lemura5799e32020-01-17 19:26:51 +0000977 The new version is the file in the user's workspace, i.e. the 'right hand
978 side'.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000979
980 Contents will be empty if the file is a directory or does not exist.
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000981 Note: The carriage returns (LF or CR) are stripped off.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000982 """
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000983 if self._cached_new_contents is None:
984 self._cached_new_contents = []
agable0b65e732016-11-22 09:25:46 -0800985 try:
986 self._cached_new_contents = gclient_utils.FileRead(
987 self.AbsoluteLocalPath(), 'rU').splitlines()
988 except IOError:
989 pass # File not found? That's fine; maybe it was deleted.
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000990 return self._cached_new_contents[:]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000991
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000992 def ChangedContents(self):
993 """Returns a list of tuples (line number, line text) of all new lines.
994
995 This relies on the scm diff output describing each changed code section
996 with a line of the form
997
998 ^@@ <old line num>,<old size> <new line num>,<new size> @@$
999 """
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +00001000 if self._cached_changed_contents is not None:
1001 return self._cached_changed_contents[:]
1002 self._cached_changed_contents = []
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001003 line_num = 0
1004
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001005 for line in self.GenerateScmDiff().splitlines():
Edward Lemurac5c55f2020-02-29 00:17:16 +00001006 m = re.match(r'^@@ [0-9\,\+\-]+ \+([0-9]+)\,[0-9]+ @@', line)
1007 if m:
1008 line_num = int(m.groups(1)[0])
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001009 continue
1010 if line.startswith('+') and not line.startswith('++'):
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +00001011 self._cached_changed_contents.append((line_num, line[1:]))
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001012 if not line.startswith('-'):
1013 line_num += 1
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +00001014 return self._cached_changed_contents[:]
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001015
maruel@chromium.org5de13972009-06-10 18:16:06 +00001016 def __str__(self):
1017 return self.LocalPath()
1018
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001019 def GenerateScmDiff(self):
nick@chromium.orgff526192013-06-10 19:30:26 +00001020 return self._diff_cache.GetDiff(self.LocalPath(), self._local_root)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001021
maruel@chromium.org58407af2011-04-12 23:15:57 +00001022
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001023class GitAffectedFile(AffectedFile):
1024 """Representation of a file in a change out of a git checkout."""
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +00001025 # Method 'NNN' is abstract in class 'NNN' but is not overridden
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -08001026 # pylint: disable=abstract-method
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001027
nick@chromium.orgff526192013-06-10 19:30:26 +00001028 DIFF_CACHE = _GitDiffCache
1029
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001030 def __init__(self, *args, **kwargs):
1031 AffectedFile.__init__(self, *args, **kwargs)
1032 self._server_path = None
agable0b65e732016-11-22 09:25:46 -08001033 self._is_testable_file = None
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001034
agable0b65e732016-11-22 09:25:46 -08001035 def IsTestableFile(self):
1036 if self._is_testable_file is None:
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001037 if self.Action() == 'D':
agable0b65e732016-11-22 09:25:46 -08001038 # A deleted file is not testable.
1039 self._is_testable_file = False
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001040 else:
agable0b65e732016-11-22 09:25:46 -08001041 self._is_testable_file = os.path.isfile(self.AbsoluteLocalPath())
1042 return self._is_testable_file
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001043
maruel@chromium.orgc1938752011-04-12 23:11:13 +00001044
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001045class Change(object):
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001046 """Describe a change.
1047
1048 Used directly by the presubmit scripts to query the current change being
1049 tested.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +00001050
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001051 Instance members:
nick@chromium.orgff526192013-06-10 19:30:26 +00001052 tags: Dictionary of KEY=VALUE pairs found in the change description.
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001053 self.KEY: equivalent to tags['KEY']
1054 """
1055
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001056 _AFFECTED_FILES = AffectedFile
1057
Edward Lemura5799e32020-01-17 19:26:51 +00001058 # Matches key/value (or 'tag') lines in changelist descriptions.
maruel@chromium.org428342a2011-11-10 15:46:33 +00001059 TAG_LINE_RE = re.compile(
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001060 '^[ \t]*(?P<key>[A-Z][A-Z_0-9]*)[ \t]*=[ \t]*(?P<value>.*?)[ \t]*$')
maruel@chromium.orgc1938752011-04-12 23:11:13 +00001061 scm = ''
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001062
maruel@chromium.org58407af2011-04-12 23:15:57 +00001063 def __init__(
agable@chromium.orgea84ef12014-04-30 19:55:12 +00001064 self, name, description, local_root, files, issue, patchset, author,
1065 upstream=None):
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001066 if files is None:
1067 files = []
1068 self._name = name
chase@chromium.org8e416c82009-10-06 04:30:44 +00001069 # Convert root into an absolute path.
1070 self._local_root = os.path.abspath(local_root)
agable@chromium.orgea84ef12014-04-30 19:55:12 +00001071 self._upstream = upstream
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001072 self.issue = issue
1073 self.patchset = patchset
maruel@chromium.org58407af2011-04-12 23:15:57 +00001074 self.author_email = author
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001075
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001076 self._full_description = ''
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001077 self.tags = {}
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001078 self._description_without_tags = ''
1079 self.SetDescriptionText(description)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001080
maruel@chromium.orge085d812011-10-10 19:49:15 +00001081 assert all(
1082 (isinstance(f, (list, tuple)) and len(f) == 2) for f in files), files
1083
agable@chromium.orgea84ef12014-04-30 19:55:12 +00001084 diff_cache = self._AFFECTED_FILES.DIFF_CACHE(self._upstream)
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001085 self._affected_files = [
nick@chromium.orgff526192013-06-10 19:30:26 +00001086 self._AFFECTED_FILES(path, action.strip(), self._local_root, diff_cache)
1087 for action, path in files
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +00001088 ]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001089
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001090 def Name(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001091 """Returns the change name."""
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001092 return self._name
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001093
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001094 def DescriptionText(self):
1095 """Returns the user-entered changelist description, minus tags.
1096
Edward Lemura5799e32020-01-17 19:26:51 +00001097 Any line in the user-provided description starting with e.g. 'FOO='
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001098 (whitespace permitted before and around) is considered a tag line. Such
1099 lines are stripped out of the description this function returns.
1100 """
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001101 return self._description_without_tags
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001102
1103 def FullDescriptionText(self):
1104 """Returns the complete changelist description including tags."""
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001105 return self._full_description
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001106
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001107 def SetDescriptionText(self, description):
1108 """Sets the full description text (including tags) to |description|.
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001109
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001110 Also updates the list of tags."""
1111 self._full_description = description
1112
1113 # From the description text, build up a dictionary of key/value pairs
Edward Lemura5799e32020-01-17 19:26:51 +00001114 # plus the description minus all key/value or 'tag' lines.
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001115 description_without_tags = []
1116 self.tags = {}
1117 for line in self._full_description.splitlines():
1118 m = self.TAG_LINE_RE.match(line)
1119 if m:
1120 self.tags[m.group('key')] = m.group('value')
1121 else:
1122 description_without_tags.append(line)
1123
1124 # Change back to text and remove whitespace at end.
1125 self._description_without_tags = (
1126 '\n'.join(description_without_tags).rstrip())
1127
Edward Lemur69bb8be2020-02-03 20:37:38 +00001128 def AddDescriptionFooter(self, key, value):
1129 """Adds the given footer to the change description.
1130
1131 Args:
1132 key: A string with the key for the git footer. It must conform to
1133 the git footers format (i.e. 'List-Of-Tokens') and will be case
1134 normalized so that each token is title-cased.
1135 value: A string with the value for the git footer.
1136 """
1137 description = git_footers.add_footer(
1138 self.FullDescriptionText(), git_footers.normalize_name(key), value)
1139 self.SetDescriptionText(description)
1140
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001141 def RepositoryRoot(self):
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001142 """Returns the repository (checkout) root directory for this change,
1143 as an absolute path.
1144 """
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001145 return self._local_root
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001146
1147 def __getattr__(self, attr):
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001148 """Return tags directly as attributes on the object."""
Edward Lemura5799e32020-01-17 19:26:51 +00001149 if not re.match(r'^[A-Z_]*$', attr):
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001150 raise AttributeError(self, attr)
maruel@chromium.orge1a524f2009-05-27 14:43:46 +00001151 return self.tags.get(attr)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001152
Edward Lemur69bb8be2020-02-03 20:37:38 +00001153 def GitFootersFromDescription(self):
1154 """Return the git footers present in the description.
1155
1156 Returns:
1157 footers: A dict of {footer: [values]} containing a multimap of the footers
1158 in the change description.
1159 """
1160 return git_footers.parse_footers(self.FullDescriptionText())
1161
Aaron Gablefc03e672017-05-15 14:09:42 -07001162 def BugsFromDescription(self):
1163 """Returns all bugs referenced in the commit description."""
Aaron Gable12ef5012017-05-15 14:29:00 -07001164 tags = [b.strip() for b in self.tags.get('BUG', '').split(',') if b.strip()]
Caleb Rouleauc0546b92019-02-22 06:12:57 +00001165 footers = []
Edward Lemur69bb8be2020-02-03 20:37:38 +00001166 parsed = self.GitFootersFromDescription()
Dan Beam62954042019-10-03 21:20:33 +00001167 unsplit_footers = parsed.get('Bug', []) + parsed.get('Fixed', [])
Caleb Rouleauc0546b92019-02-22 06:12:57 +00001168 for unsplit_footer in unsplit_footers:
1169 footers += [b.strip() for b in unsplit_footer.split(',')]
Aaron Gable12ef5012017-05-15 14:29:00 -07001170 return sorted(set(tags + footers))
Aaron Gablefc03e672017-05-15 14:09:42 -07001171
1172 def ReviewersFromDescription(self):
1173 """Returns all reviewers listed in the commit description."""
Edward Lemura5799e32020-01-17 19:26:51 +00001174 # We don't support a 'R:' git-footer for reviewers; that is in metadata.
Aaron Gable12ef5012017-05-15 14:29:00 -07001175 tags = [r.strip() for r in self.tags.get('R', '').split(',') if r.strip()]
1176 return sorted(set(tags))
Aaron Gablefc03e672017-05-15 14:09:42 -07001177
1178 def TBRsFromDescription(self):
1179 """Returns all TBR reviewers listed in the commit description."""
Aaron Gable12ef5012017-05-15 14:29:00 -07001180 tags = [r.strip() for r in self.tags.get('TBR', '').split(',') if r.strip()]
Aaron Gable6e7ddb62020-05-27 22:23:29 +00001181 # TODO(crbug.com/839208): Remove support for 'Tbr:' when TBRs are
1182 # programmatically determined by self-CR+1s.
Edward Lemur69bb8be2020-02-03 20:37:38 +00001183 footers = self.GitFootersFromDescription().get('Tbr', [])
Aaron Gable12ef5012017-05-15 14:29:00 -07001184 return sorted(set(tags + footers))
Aaron Gablefc03e672017-05-15 14:09:42 -07001185
Aaron Gable6e7ddb62020-05-27 22:23:29 +00001186 # TODO(crbug.com/753425): Delete these once we're sure they're unused.
Aaron Gablefc03e672017-05-15 14:09:42 -07001187 @property
1188 def BUG(self):
1189 return ','.join(self.BugsFromDescription())
1190 @property
1191 def R(self):
1192 return ','.join(self.ReviewersFromDescription())
1193 @property
1194 def TBR(self):
1195 return ','.join(self.TBRsFromDescription())
1196
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001197 def AllFiles(self, root=None):
1198 """List all files under source control in the repo."""
1199 raise NotImplementedError()
1200
agable0b65e732016-11-22 09:25:46 -08001201 def AffectedFiles(self, include_deletes=True, file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001202 """Returns a list of AffectedFile instances for all files in the change.
1203
1204 Args:
1205 include_deletes: If false, deleted files will be filtered out.
sail@chromium.org5538e022011-05-12 17:53:16 +00001206 file_filter: An additional filter to apply.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001207
1208 Returns:
1209 [AffectedFile(path, action), AffectedFile(path, action)]
1210 """
Edward Lemurb9830242019-10-30 22:19:20 +00001211 affected = list(filter(file_filter, self._affected_files))
sail@chromium.org5538e022011-05-12 17:53:16 +00001212
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001213 if include_deletes:
1214 return affected
Edward Lemurb9830242019-10-30 22:19:20 +00001215 return list(filter(lambda x: x.Action() != 'D', affected))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001216
John Budorick16162372018-04-18 10:39:53 -07001217 def AffectedTestableFiles(self, include_deletes=None, **kwargs):
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +00001218 """Return a list of the existing text files in a change."""
1219 if include_deletes is not None:
Edward Lemura5799e32020-01-17 19:26:51 +00001220 warn('AffectedTeestableFiles(include_deletes=%s)'
1221 ' is deprecated and ignored' % str(include_deletes),
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +00001222 category=DeprecationWarning,
1223 stacklevel=2)
Edward Lemurb9830242019-10-30 22:19:20 +00001224 return list(filter(
1225 lambda x: x.IsTestableFile(),
1226 self.AffectedFiles(include_deletes=False, **kwargs)))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001227
agable0b65e732016-11-22 09:25:46 -08001228 def AffectedTextFiles(self, include_deletes=None):
1229 """An alias to AffectedTestableFiles for backwards compatibility."""
1230 return self.AffectedTestableFiles(include_deletes=include_deletes)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001231
agable0b65e732016-11-22 09:25:46 -08001232 def LocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001233 """Convenience function."""
agable0b65e732016-11-22 09:25:46 -08001234 return [af.LocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001235
agable0b65e732016-11-22 09:25:46 -08001236 def AbsoluteLocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001237 """Convenience function."""
agable0b65e732016-11-22 09:25:46 -08001238 return [af.AbsoluteLocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001239
1240 def RightHandSideLines(self):
Edward Lemura5799e32020-01-17 19:26:51 +00001241 """An iterator over all text lines in 'new' version of changed files.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001242
1243 Lists lines from new or modified text files in the change.
1244
1245 This is useful for doing line-by-line regex checks, like checking for
1246 trailing whitespace.
1247
1248 Yields:
1249 a 3 tuple:
1250 the AffectedFile instance of the current file;
1251 integer line number (1-based); and
1252 the contents of the line as a string.
1253 """
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +00001254 return _RightHandSideLinesImpl(
1255 x for x in self.AffectedFiles(include_deletes=False)
agable0b65e732016-11-22 09:25:46 -08001256 if x.IsTestableFile())
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001257
Jochen Eisingerd0573ec2017-04-13 10:55:06 +02001258 def OriginalOwnersFiles(self):
1259 """A map from path names of affected OWNERS files to their old content."""
1260 def owners_file_filter(f):
1261 return 'OWNERS' in os.path.split(f.LocalPath())[1]
1262 files = self.AffectedFiles(file_filter=owners_file_filter)
1263 return dict([(f.LocalPath(), f.OldContents()) for f in files])
1264
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001265
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001266class GitChange(Change):
1267 _AFFECTED_FILES = GitAffectedFile
maruel@chromium.orgc1938752011-04-12 23:11:13 +00001268 scm = 'git'
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +00001269
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001270 def AllFiles(self, root=None):
1271 """List all files under source control in the repo."""
1272 root = root or self.RepositoryRoot()
1273 return subprocess.check_output(
Aaron Gable7817f022017-12-12 09:43:17 -08001274 ['git', '-c', 'core.quotePath=false', 'ls-files', '--', '.'],
1275 cwd=root).splitlines()
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001276
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001277
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001278def ListRelevantPresubmitFiles(files, root):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001279 """Finds all presubmit files that apply to a given set of source files.
1280
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001281 If inherit-review-settings-ok is present right under root, looks for
1282 PRESUBMIT.py in directories enclosing root.
1283
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001284 Args:
1285 files: An iterable container containing file paths.
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001286 root: Path where to stop searching.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001287
1288 Return:
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001289 List of absolute paths of the existing PRESUBMIT.py scripts.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001290 """
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001291 files = [normpath(os.path.join(root, f)) for f in files]
1292
1293 # List all the individual directories containing files.
1294 directories = set([os.path.dirname(f) for f in files])
1295
1296 # Ignore root if inherit-review-settings-ok is present.
1297 if os.path.isfile(os.path.join(root, 'inherit-review-settings-ok')):
1298 root = None
1299
1300 # Collect all unique directories that may contain PRESUBMIT.py.
1301 candidates = set()
1302 for directory in directories:
1303 while True:
1304 if directory in candidates:
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001305 break
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001306 candidates.add(directory)
1307 if directory == root:
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001308 break
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001309 parent_dir = os.path.dirname(directory)
1310 if parent_dir == directory:
1311 # We hit the system root directory.
1312 break
1313 directory = parent_dir
1314
1315 # Look for PRESUBMIT.py in all candidate directories.
1316 results = []
1317 for directory in sorted(list(candidates)):
tobiasjsff061c02016-08-17 03:23:57 -07001318 try:
1319 for f in os.listdir(directory):
1320 p = os.path.join(directory, f)
1321 if os.path.isfile(p) and re.match(
1322 r'PRESUBMIT.*\.py$', f) and not f.startswith('PRESUBMIT_test'):
1323 results.append(p)
1324 except OSError:
1325 pass
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001326
tobiasjs2836bcf2016-08-16 04:08:16 -07001327 logging.debug('Presubmit files: %s', ','.join(results))
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001328 return results
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001329
1330
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001331class GetTryMastersExecuter(object):
1332 @staticmethod
1333 def ExecPresubmitScript(script_text, presubmit_path, project, change):
1334 """Executes GetPreferredTryMasters() from a single presubmit script.
1335
1336 Args:
1337 script_text: The text of the presubmit script.
1338 presubmit_path: Project script to run.
1339 project: Project name to pass to presubmit script for bot selection.
1340
1341 Return:
1342 A map of try masters to map of builders to set of tests.
1343 """
1344 context = {}
1345 try:
Raul Tambre09e64b42019-05-14 01:57:22 +00001346 exec(compile(script_text, 'PRESUBMIT.py', 'exec', dont_inherit=True),
1347 context)
Raul Tambre7c938462019-05-24 16:35:35 +00001348 except Exception as e:
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001349 raise PresubmitFailure('"%s" had an exception.\n%s'
1350 % (presubmit_path, e))
1351
1352 function_name = 'GetPreferredTryMasters'
1353 if function_name not in context:
1354 return {}
1355 get_preferred_try_masters = context[function_name]
1356 if not len(inspect.getargspec(get_preferred_try_masters)[0]) == 2:
1357 raise PresubmitFailure(
1358 'Expected function "GetPreferredTryMasters" to take two arguments.')
1359 return get_preferred_try_masters(project, change)
1360
1361
rmistry@google.com5626a922015-02-26 14:03:30 +00001362class GetPostUploadExecuter(object):
1363 @staticmethod
Edward Lemur016a0872020-02-04 22:13:28 +00001364 def ExecPresubmitScript(script_text, presubmit_path, gerrit_obj, change):
rmistry@google.com5626a922015-02-26 14:03:30 +00001365 """Executes PostUploadHook() from a single presubmit script.
1366
1367 Args:
1368 script_text: The text of the presubmit script.
1369 presubmit_path: Project script to run.
Edward Lemur016a0872020-02-04 22:13:28 +00001370 gerrit_obj: The GerritAccessor object.
rmistry@google.com5626a922015-02-26 14:03:30 +00001371 change: The Change object.
1372
1373 Return:
1374 A list of results objects.
1375 """
1376 context = {}
1377 try:
Raul Tambre09e64b42019-05-14 01:57:22 +00001378 exec(compile(script_text, 'PRESUBMIT.py', 'exec', dont_inherit=True),
1379 context)
Raul Tambre7c938462019-05-24 16:35:35 +00001380 except Exception as e:
rmistry@google.com5626a922015-02-26 14:03:30 +00001381 raise PresubmitFailure('"%s" had an exception.\n%s'
1382 % (presubmit_path, e))
1383
1384 function_name = 'PostUploadHook'
1385 if function_name not in context:
1386 return {}
1387 post_upload_hook = context[function_name]
1388 if not len(inspect.getargspec(post_upload_hook)[0]) == 3:
1389 raise PresubmitFailure(
1390 'Expected function "PostUploadHook" to take three arguments.')
Edward Lemur016a0872020-02-04 22:13:28 +00001391 return post_upload_hook(gerrit_obj, change, OutputApi(False))
rmistry@google.com5626a922015-02-26 14:03:30 +00001392
1393
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001394def _MergeMasters(masters1, masters2):
1395 """Merges two master maps. Merges also the tests of each builder."""
1396 result = {}
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001397 for (master, builders) in itertools.chain(masters1.items(),
1398 masters2.items()):
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001399 new_builders = result.setdefault(master, {})
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001400 for (builder, tests) in builders.items():
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001401 new_builders.setdefault(builder, set([])).update(tests)
1402 return result
1403
1404
1405def DoGetTryMasters(change,
1406 changed_files,
1407 repository_root,
1408 default_presubmit,
1409 project,
1410 verbose,
1411 output_stream):
1412 """Get the list of try masters from the presubmit scripts.
1413
1414 Args:
1415 changed_files: List of modified files.
1416 repository_root: The repository root.
1417 default_presubmit: A default presubmit script to execute in any case.
1418 project: Optional name of a project used in selecting trybots.
1419 verbose: Prints debug info.
1420 output_stream: A stream to write debug output to.
1421
1422 Return:
1423 Map of try masters to map of builders to set of tests.
1424 """
1425 presubmit_files = ListRelevantPresubmitFiles(changed_files, repository_root)
1426 if not presubmit_files and verbose:
Edward Lemura5799e32020-01-17 19:26:51 +00001427 output_stream.write('Warning, no PRESUBMIT.py found.\n')
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001428 results = {}
1429 executer = GetTryMastersExecuter()
1430
1431 if default_presubmit:
1432 if verbose:
Edward Lemura5799e32020-01-17 19:26:51 +00001433 output_stream.write('Running default presubmit script.\n')
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001434 fake_path = os.path.join(repository_root, 'PRESUBMIT.py')
1435 results = _MergeMasters(results, executer.ExecPresubmitScript(
1436 default_presubmit, fake_path, project, change))
1437 for filename in presubmit_files:
1438 filename = os.path.abspath(filename)
1439 if verbose:
Edward Lemura5799e32020-01-17 19:26:51 +00001440 output_stream.write('Running %s\n' % filename)
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001441 # Accept CRLF presubmit script.
1442 presubmit_script = gclient_utils.FileRead(filename, 'rU')
1443 results = _MergeMasters(results, executer.ExecPresubmitScript(
1444 presubmit_script, filename, project, change))
1445
1446 # Make sets to lists again for later JSON serialization.
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001447 for builders in results.values():
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001448 for builder in builders:
1449 builders[builder] = list(builders[builder])
1450
1451 if results and verbose:
1452 output_stream.write('%s\n' % str(results))
1453 return results
1454
1455
rmistry@google.com5626a922015-02-26 14:03:30 +00001456def DoPostUploadExecuter(change,
Edward Lemur016a0872020-02-04 22:13:28 +00001457 gerrit_obj,
Edward Lemur6eb1d322020-02-27 22:20:15 +00001458 verbose):
rmistry@google.com5626a922015-02-26 14:03:30 +00001459 """Execute the post upload hook.
1460
1461 Args:
1462 change: The Change object.
Edward Lemur016a0872020-02-04 22:13:28 +00001463 gerrit_obj: The GerritAccessor object.
rmistry@google.com5626a922015-02-26 14:03:30 +00001464 verbose: Prints debug info.
rmistry@google.com5626a922015-02-26 14:03:30 +00001465 """
1466 presubmit_files = ListRelevantPresubmitFiles(
Edward Lemur6eb1d322020-02-27 22:20:15 +00001467 change.LocalPaths(), change.RepositoryRoot())
rmistry@google.com5626a922015-02-26 14:03:30 +00001468 if not presubmit_files and verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001469 sys.stdout.write('Warning, no PRESUBMIT.py found.\n')
rmistry@google.com5626a922015-02-26 14:03:30 +00001470 results = []
1471 executer = GetPostUploadExecuter()
1472 # The root presubmit file should be executed after the ones in subdirectories.
1473 # i.e. the specific post upload hooks should run before the general ones.
1474 # Thus, reverse the order provided by ListRelevantPresubmitFiles.
1475 presubmit_files.reverse()
1476
1477 for filename in presubmit_files:
1478 filename = os.path.abspath(filename)
1479 if verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001480 sys.stdout.write('Running %s\n' % filename)
rmistry@google.com5626a922015-02-26 14:03:30 +00001481 # Accept CRLF presubmit script.
1482 presubmit_script = gclient_utils.FileRead(filename, 'rU')
1483 results.extend(executer.ExecPresubmitScript(
Edward Lemur016a0872020-02-04 22:13:28 +00001484 presubmit_script, filename, gerrit_obj, change))
rmistry@google.com5626a922015-02-26 14:03:30 +00001485
Edward Lemur6eb1d322020-02-27 22:20:15 +00001486 if not results:
1487 return 0
1488
1489 sys.stdout.write('\n')
1490 sys.stdout.write('** Post Upload Hook Messages **\n')
1491
1492 exit_code = 0
1493 for result in results:
1494 if result.fatal:
1495 exit_code = 1
1496 result.handle()
1497 sys.stdout.write('\n')
1498
1499 return exit_code
rmistry@google.com5626a922015-02-26 14:03:30 +00001500
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001501class PresubmitExecuter(object):
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001502 def __init__(self, change, committing, verbose, gerrit_obj, dry_run=None,
1503 thread_pool=None, parallel=False, gerrit_project=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001504 """
1505 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001506 change: The Change object.
agable92bec4f2016-08-24 09:27:27 -07001507 committing: True if 'git cl land' is running, False if 'git cl upload' is.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001508 gerrit_obj: provides basic Gerrit codereview functionality.
1509 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -04001510 parallel: if true, all tests reported via input_api.RunTests for all
1511 PRESUBMIT files will be run in parallel.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001512 """
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001513 self.change = change
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001514 self.committing = committing
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001515 self.gerrit = gerrit_obj
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001516 self.verbose = verbose
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001517 self.dry_run = dry_run
Daniel Cheng7227d212017-11-17 08:12:37 -08001518 self.more_cc = []
Edward Lesmes8e282792018-04-03 18:50:29 -04001519 self.thread_pool = thread_pool
1520 self.parallel = parallel
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001521 self.gerrit_project = gerrit_project
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001522
1523 def ExecPresubmitScript(self, script_text, presubmit_path):
1524 """Executes a single presubmit script.
1525
1526 Args:
1527 script_text: The text of the presubmit script.
1528 presubmit_path: The path to the presubmit file (this will be reported via
1529 input_api.PresubmitLocalPath()).
1530
1531 Return:
1532 A list of result objects, empty if no problems.
1533 """
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001534
chase@chromium.org8e416c82009-10-06 04:30:44 +00001535 # Change to the presubmit file's directory to support local imports.
1536 main_path = os.getcwd()
Saagar Sanghavi98b332f2020-07-31 17:19:15 +00001537 presubmit_dir = os.path.dirname(presubmit_path)
1538 os.chdir(presubmit_dir)
chase@chromium.org8e416c82009-10-06 04:30:44 +00001539
1540 # Load the presubmit script into context.
dpranke@chromium.org970c5222011-03-12 00:32:24 +00001541 input_api = InputApi(self.change, presubmit_path, self.committing,
Aaron Gable668c1d82018-04-03 10:19:16 -07001542 self.verbose, gerrit_obj=self.gerrit,
Edward Lesmes8e282792018-04-03 18:50:29 -04001543 dry_run=self.dry_run, thread_pool=self.thread_pool,
1544 parallel=self.parallel)
Daniel Cheng7227d212017-11-17 08:12:37 -08001545 output_api = OutputApi(self.committing)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001546 context = {}
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001547
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001548 try:
Raul Tambre09e64b42019-05-14 01:57:22 +00001549 exec(compile(script_text, 'PRESUBMIT.py', 'exec', dont_inherit=True),
1550 context)
Raul Tambre7c938462019-05-24 16:35:35 +00001551 except Exception as e:
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001552 raise PresubmitFailure('"%s" had an exception.\n%s' % (presubmit_path, e))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001553
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001554 context['__args'] = (input_api, output_api)
Ben Pastene8351dc12020-08-06 05:01:35 +00001555
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001556 # Get path of presubmit directory relative to repository root.
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001557 # Always use forward slashes, so that path is same in *nix and Windows
1558 root = input_api.change.RepositoryRoot()
1559 rel_path = os.path.relpath(presubmit_dir, root)
1560 rel_path = rel_path.replace(os.path.sep, '/')
Ben Pastene8351dc12020-08-06 05:01:35 +00001561
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001562 # Get the URL of git remote origin and use it to identify host and project
1563 host = ''
1564 if self.gerrit and self.gerrit.host:
1565 host = self.gerrit.host
1566 project = self.gerrit_project or ''
1567
1568 # Prefix for test names
1569 prefix = 'presubmit:%s/%s:%s/' % (host, project, rel_path)
1570
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001571 # Perform all the desired presubmit checks.
1572 results = []
Ben Pastene8351dc12020-08-06 05:01:35 +00001573
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001574 try:
Saagar Sanghavi99816902020-08-11 22:41:25 +00001575 if 'PRESUBMIT_VERSION' in context and \
1576 [int(x) for x in context['PRESUBMIT_VERSION'].split('.')] >= [2, 0, 0]:
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001577 for function_name in context:
1578 if not function_name.startswith('Check'):
1579 continue
1580 if function_name.endswith('Commit') and not self.committing:
1581 continue
1582 if function_name.endswith('Upload') and self.committing:
1583 continue
1584 logging.debug('Running %s in %s', function_name, presubmit_path)
1585 results.extend(
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001586 self._run_check_function(function_name, context, prefix))
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001587 logging.debug('Running %s done.', function_name)
1588 self.more_cc.extend(output_api.more_cc)
1589
1590 else: # Old format
1591 if self.committing:
1592 function_name = 'CheckChangeOnCommit'
1593 else:
1594 function_name = 'CheckChangeOnUpload'
1595 if function_name in context:
1596 logging.debug('Running %s in %s', function_name, presubmit_path)
1597 results.extend(
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001598 self._run_check_function(function_name, context, prefix))
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001599 logging.debug('Running %s done.', function_name)
1600 self.more_cc.extend(output_api.more_cc)
1601
1602 finally:
1603 for f in input_api._named_temporary_files:
1604 os.remove(f)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001605
chase@chromium.org8e416c82009-10-06 04:30:44 +00001606 # Return the process to the original working directory.
1607 os.chdir(main_path)
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001608 return results
1609
1610 def _run_check_function(self, function_name, context, prefix):
1611 """Evaluates a presubmit check function, function_name, in the context
1612 provided. If LUCI_CONTEXT is enabled, it will send the result to ResultSink.
1613 Passes function_name and prefix to rdb_wrapper.setup_rdb. Returns results.
1614
1615 Args:
1616 function_name: a string representing the name of the function to run
1617 context: a context dictionary in which the function will be evaluated
1618 prefix: a string describing prefix for ResultDB test id
1619
1620 Returns: Results from evaluating the function call."""
1621 with rdb_wrapper.setup_rdb(function_name, prefix) as my_status:
1622 result = eval(function_name + '(*__args)', context)
1623 self._check_result_type(result)
1624 if any(res.fatal for res in result):
1625 my_status.status = rdb_wrapper.STATUS_FAIL
1626 return result
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001627
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00001628 def _check_result_type(self, result):
1629 """Helper function which ensures result is a list, and all elements are
1630 instances of OutputApi.PresubmitResult"""
1631 if not isinstance(result, (tuple, list)):
1632 raise PresubmitFailure('Presubmit functions must return a tuple or list')
1633 if not all(isinstance(res, OutputApi.PresubmitResult) for res in result):
1634 raise PresubmitFailure(
1635 'All presubmit results must be of types derived from '
1636 'output_api.PresubmitResult')
1637
1638
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001639def DoPresubmitChecks(change,
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001640 committing,
1641 verbose,
maruel@chromium.orgb0dfd352009-06-10 14:12:54 +00001642 default_presubmit,
dpranke@chromium.org970c5222011-03-12 00:32:24 +00001643 may_prompt,
Aaron Gable668c1d82018-04-03 10:19:16 -07001644 gerrit_obj,
Edward Lesmes8e282792018-04-03 18:50:29 -04001645 dry_run=None,
Debrian Figueroadd2737e2019-06-21 23:50:13 +00001646 parallel=False,
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001647 json_output=None,
1648 gerrit_project=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001649 """Runs all presubmit checks that apply to the files in the change.
1650
1651 This finds all PRESUBMIT.py files in directories enclosing the files in the
1652 change (up to the repository root) and calls the relevant entrypoint function
1653 depending on whether the change is being committed or uploaded.
1654
1655 Prints errors, warnings and notifications. Prompts the user for warnings
1656 when needed.
1657
1658 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001659 change: The Change object.
agable92bec4f2016-08-24 09:27:27 -07001660 committing: True if 'git cl land' is running, False if 'git cl upload' is.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001661 verbose: Prints debug info.
maruel@chromium.org0ff1fab2009-05-22 13:08:15 +00001662 default_presubmit: A default presubmit script to execute in any case.
Quinten Yearsley516fe7f2016-12-14 11:50:18 -08001663 may_prompt: Enable (y/n) questions on warning or error. If False,
1664 any questions are answered with yes by default.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001665 gerrit_obj: provides basic Gerrit codereview functionality.
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001666 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -04001667 parallel: if true, all tests specified by input_api.RunTests in all
1668 PRESUBMIT files will be run in parallel.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001669
1670 Return:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001671 1 if presubmit checks failed or 0 otherwise.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001672 """
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001673 old_environ = os.environ
1674 try:
1675 # Make sure python subprocesses won't generate .pyc files.
1676 os.environ = os.environ.copy()
Edward Lemurb9830242019-10-30 22:19:20 +00001677 os.environ['PYTHONDONTWRITEBYTECODE'] = '1'
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001678
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001679 if committing:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001680 sys.stdout.write('Running presubmit commit checks ...\n')
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001681 else:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001682 sys.stdout.write('Running presubmit upload checks ...\n')
Edward Lemurecc27072020-01-06 16:42:34 +00001683 start_time = time_time()
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001684 presubmit_files = ListRelevantPresubmitFiles(
agable0b65e732016-11-22 09:25:46 -08001685 change.AbsoluteLocalPaths(), change.RepositoryRoot())
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001686 if not presubmit_files and verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001687 sys.stdout.write('Warning, no PRESUBMIT.py found.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001688 results = []
Edward Lesmes8e282792018-04-03 18:50:29 -04001689 thread_pool = ThreadPool()
Edward Lemur7e3c67f2018-07-20 20:52:49 +00001690 executer = PresubmitExecuter(change, committing, verbose, gerrit_obj,
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001691 dry_run, thread_pool, parallel, gerrit_project)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001692 if default_presubmit:
1693 if verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001694 sys.stdout.write('Running default presubmit script.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001695 fake_path = os.path.join(change.RepositoryRoot(), 'PRESUBMIT.py')
1696 results += executer.ExecPresubmitScript(default_presubmit, fake_path)
1697 for filename in presubmit_files:
1698 filename = os.path.abspath(filename)
1699 if verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001700 sys.stdout.write('Running %s\n' % filename)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001701 # Accept CRLF presubmit script.
1702 presubmit_script = gclient_utils.FileRead(filename, 'rU')
1703 results += executer.ExecPresubmitScript(presubmit_script, filename)
Edward Lesmes8e282792018-04-03 18:50:29 -04001704 results += thread_pool.RunAsync()
1705
Edward Lemur6eb1d322020-02-27 22:20:15 +00001706 messages = {}
1707 should_prompt = False
1708 presubmits_failed = False
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001709 for result in results:
1710 if result.fatal:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001711 presubmits_failed = True
1712 messages.setdefault('ERRORS', []).append(result)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001713 elif result.should_prompt:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001714 should_prompt = True
1715 messages.setdefault('Warnings', []).append(result)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001716 else:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001717 messages.setdefault('Messages', []).append(result)
pam@chromium.orged9a0832009-09-09 22:48:55 +00001718
Edward Lemur6eb1d322020-02-27 22:20:15 +00001719 sys.stdout.write('\n')
1720 for name, items in messages.items():
1721 sys.stdout.write('** Presubmit %s **\n' % name)
1722 for item in items:
1723 item.handle()
1724 sys.stdout.write('\n')
pam@chromium.orged9a0832009-09-09 22:48:55 +00001725
Edward Lemurecc27072020-01-06 16:42:34 +00001726 total_time = time_time() - start_time
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001727 if total_time > 1.0:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001728 sys.stdout.write(
1729 'Presubmit checks took %.1fs to calculate.\n\n' % total_time)
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +00001730
Edward Lemur6eb1d322020-02-27 22:20:15 +00001731 if not should_prompt and not presubmits_failed:
1732 sys.stdout.write('Presubmit checks passed.\n')
1733 elif should_prompt:
1734 sys.stdout.write('There were presubmit warnings. ')
Quinten Yearsley516fe7f2016-12-14 11:50:18 -08001735 if may_prompt:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001736 presubmits_failed = not prompt_should_continue(
1737 'Are you sure you wish to continue? (y/N): ')
Garrett Beatyacb807e2020-08-28 18:17:24 +00001738 else:
1739 sys.stdout.write('\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001740
Edward Lemur1dc66e12020-02-21 21:36:34 +00001741 if json_output:
1742 # Write the presubmit results to json output
1743 presubmit_results = {
1744 'errors': [
Edward Lemur6eb1d322020-02-27 22:20:15 +00001745 error.json_format()
1746 for error in messages.get('ERRORS', [])
Edward Lemur1dc66e12020-02-21 21:36:34 +00001747 ],
1748 'notifications': [
Edward Lemur6eb1d322020-02-27 22:20:15 +00001749 notification.json_format()
1750 for notification in messages.get('Messages', [])
Edward Lemur1dc66e12020-02-21 21:36:34 +00001751 ],
1752 'warnings': [
Edward Lemur6eb1d322020-02-27 22:20:15 +00001753 warning.json_format()
1754 for warning in messages.get('Warnings', [])
Edward Lemur1dc66e12020-02-21 21:36:34 +00001755 ],
Edward Lemur6eb1d322020-02-27 22:20:15 +00001756 'more_cc': executer.more_cc,
Edward Lemur1dc66e12020-02-21 21:36:34 +00001757 }
1758
1759 gclient_utils.FileWrite(
1760 json_output, json.dumps(presubmit_results, sort_keys=True))
1761
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001762 global _ASKED_FOR_FEEDBACK
1763 # Ask for feedback one time out of 5.
1764 if (len(results) and random.randint(0, 4) == 0 and not _ASKED_FOR_FEEDBACK):
Edward Lemur6eb1d322020-02-27 22:20:15 +00001765 sys.stdout.write(
maruel@chromium.org1ce8e662014-01-14 15:23:00 +00001766 'Was the presubmit check useful? If not, run "git cl presubmit -v"\n'
1767 'to figure out which PRESUBMIT.py was run, then run git blame\n'
1768 'on the file to figure out who to ask for help.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001769 _ASKED_FOR_FEEDBACK = True
Edward Lemur6eb1d322020-02-27 22:20:15 +00001770
1771 return 1 if presubmits_failed else 0
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001772 finally:
1773 os.environ = old_environ
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001774
1775
Edward Lemur50984a62020-02-06 18:10:18 +00001776def _scan_sub_dirs(mask, recursive):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001777 if not recursive:
pgervais@chromium.orge57b09d2014-05-07 00:58:13 +00001778 return [x for x in glob.glob(mask) if x not in ('.svn', '.git')]
Lei Zhang9611c4c2017-04-04 01:41:56 -07001779
1780 results = []
1781 for root, dirs, files in os.walk('.'):
1782 if '.svn' in dirs:
1783 dirs.remove('.svn')
1784 if '.git' in dirs:
1785 dirs.remove('.git')
1786 for name in files:
1787 if fnmatch.fnmatch(name, mask):
1788 results.append(os.path.join(root, name))
1789 return results
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001790
1791
Edward Lemur50984a62020-02-06 18:10:18 +00001792def _parse_files(args, recursive):
tobiasjs2836bcf2016-08-16 04:08:16 -07001793 logging.debug('Searching for %s', args)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001794 files = []
1795 for arg in args:
Edward Lemur50984a62020-02-06 18:10:18 +00001796 files.extend([('M', f) for f in _scan_sub_dirs(arg, recursive)])
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001797 return files
1798
1799
Edward Lemur50984a62020-02-06 18:10:18 +00001800def _parse_change(parser, options):
1801 """Process change options.
1802
1803 Args:
1804 parser: The parser used to parse the arguments from command line.
1805 options: The arguments parsed from command line.
1806 Returns:
1807 A GitChange if the change root is a git repository, or a Change otherwise.
1808 """
1809 if options.files and options.all_files:
1810 parser.error('<files> cannot be specified when --all-files is set.')
1811
Edward Lesmes44ea3ff2020-02-05 00:14:30 +00001812 change_scm = scm.determine_scm(options.root)
Edward Lemur50984a62020-02-06 18:10:18 +00001813 if change_scm != 'git' and not options.files:
1814 parser.error('<files> is not optional for unversioned directories.')
1815
1816 if options.files:
1817 change_files = _parse_files(options.files, options.recursive)
1818 elif options.all_files:
1819 change_files = [('M', f) for f in scm.GIT.GetAllFiles(options.root)]
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001820 else:
Edward Lemur50984a62020-02-06 18:10:18 +00001821 change_files = scm.GIT.CaptureStatus(
Edward Lemur7f6dec02020-02-06 20:23:58 +00001822 options.root, options.upstream or None)
Edward Lemur50984a62020-02-06 18:10:18 +00001823
1824 logging.info('Found %d file(s).', len(change_files))
1825
1826 change_class = GitChange if change_scm == 'git' else Change
1827 return change_class(
1828 options.name,
1829 options.description,
1830 options.root,
1831 change_files,
1832 options.issue,
1833 options.patchset,
1834 options.author,
1835 upstream=options.upstream)
1836
1837
1838def _parse_gerrit_options(parser, options):
1839 """Process gerrit options.
1840
1841 SIDE EFFECTS: Modifies options.author and options.description from Gerrit if
1842 options.gerrit_fetch is set.
1843
1844 Args:
1845 parser: The parser used to parse the arguments from command line.
1846 options: The arguments parsed from command line.
1847 Returns:
1848 A GerritAccessor object if options.gerrit_url is set, or None otherwise.
1849 """
1850 gerrit_obj = None
1851 if options.gerrit_url:
1852 gerrit_obj = GerritAccessor(urlparse.urlparse(options.gerrit_url).netloc)
1853
1854 if not options.gerrit_fetch:
1855 return gerrit_obj
1856
1857 if not options.gerrit_url or not options.issue or not options.patchset:
1858 parser.error(
1859 '--gerrit_fetch requires --gerrit_url, --issue and --patchset.')
1860
1861 options.author = gerrit_obj.GetChangeOwner(options.issue)
1862 options.description = gerrit_obj.GetChangeDescription(
1863 options.issue, options.patchset)
1864
1865 logging.info('Got author: "%s"', options.author)
1866 logging.info('Got description: """\n%s\n"""', options.description)
1867
1868 return gerrit_obj
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001869
1870
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001871@contextlib.contextmanager
1872def canned_check_filter(method_names):
1873 filtered = {}
1874 try:
1875 for method_name in method_names:
1876 if not hasattr(presubmit_canned_checks, method_name):
Aaron Gableecee74c2018-04-02 15:13:08 -07001877 logging.warn('Skipping unknown "canned" check %s' % method_name)
1878 continue
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001879 filtered[method_name] = getattr(presubmit_canned_checks, method_name)
1880 setattr(presubmit_canned_checks, method_name, lambda *_a, **_kw: [])
1881 yield
1882 finally:
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001883 for name, method in filtered.items():
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001884 setattr(presubmit_canned_checks, name, method)
1885
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +00001886
sbc@chromium.org013731e2015-02-26 18:28:43 +00001887def main(argv=None):
Edward Lemura5799e32020-01-17 19:26:51 +00001888 parser = argparse.ArgumentParser(usage='%(prog)s [options] <files...>')
1889 hooks = parser.add_mutually_exclusive_group()
1890 hooks.add_argument('-c', '--commit', action='store_true',
1891 help='Use commit instead of upload checks.')
1892 hooks.add_argument('-u', '--upload', action='store_false', dest='commit',
1893 help='Use upload instead of commit checks.')
Edward Lemur75526302020-02-27 22:31:05 +00001894 hooks.add_argument('--post_upload', action='store_true',
1895 help='Run post-upload commit hooks.')
Edward Lemura5799e32020-01-17 19:26:51 +00001896 parser.add_argument('-r', '--recursive', action='store_true',
1897 help='Act recursively.')
1898 parser.add_argument('-v', '--verbose', action='count', default=0,
1899 help='Use 2 times for more debug info.')
1900 parser.add_argument('--name', default='no name')
1901 parser.add_argument('--author')
Edward Lemur227d5102020-02-25 23:45:35 +00001902 desc = parser.add_mutually_exclusive_group()
1903 desc.add_argument('--description', default='', help='The change description.')
1904 desc.add_argument('--description_file',
1905 help='File to read change description from.')
Edward Lemura5799e32020-01-17 19:26:51 +00001906 parser.add_argument('--issue', type=int, default=0)
1907 parser.add_argument('--patchset', type=int, default=0)
1908 parser.add_argument('--root', default=os.getcwd(),
1909 help='Search for PRESUBMIT.py up to this directory. '
1910 'If inherit-review-settings-ok is present in this '
1911 'directory, parent directories up to the root file '
1912 'system directories will also be searched.')
1913 parser.add_argument('--upstream',
1914 help='Git only: the base ref or upstream branch against '
1915 'which the diff should be computed.')
1916 parser.add_argument('--default_presubmit')
1917 parser.add_argument('--may_prompt', action='store_true', default=False)
1918 parser.add_argument('--skip_canned', action='append', default=[],
1919 help='A list of checks to skip which appear in '
1920 'presubmit_canned_checks. Can be provided multiple times '
1921 'to skip multiple canned checks.')
1922 parser.add_argument('--dry_run', action='store_true', help=argparse.SUPPRESS)
1923 parser.add_argument('--gerrit_url', help=argparse.SUPPRESS)
1924 parser.add_argument('--gerrit_fetch', action='store_true',
1925 help=argparse.SUPPRESS)
1926 parser.add_argument('--parallel', action='store_true',
1927 help='Run all tests specified by input_api.RunTests in '
1928 'all PRESUBMIT files in parallel.')
1929 parser.add_argument('--json_output',
1930 help='Write presubmit errors to json output.')
Edward Lemur1dc66e12020-02-21 21:36:34 +00001931 parser.add_argument('--all_files', action='store_true',
Edward Lemur50984a62020-02-06 18:10:18 +00001932 help='Mark all files under source control as modified.')
Edward Lemura5799e32020-01-17 19:26:51 +00001933 parser.add_argument('files', nargs='*',
1934 help='List of files to be marked as modified when '
1935 'executing presubmit or post-upload hooks. fnmatch '
1936 'wildcards can also be used.')
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001937 parser.add_argument('--gerrit_project', help=argparse.SUPPRESS)
Edward Lemura5799e32020-01-17 19:26:51 +00001938 options = parser.parse_args(argv)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001939
Erik Staabcca5c492020-04-16 17:40:07 +00001940 log_level = logging.ERROR
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001941 if options.verbose >= 2:
Erik Staabcca5c492020-04-16 17:40:07 +00001942 log_level = logging.DEBUG
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001943 elif options.verbose:
Erik Staabcca5c492020-04-16 17:40:07 +00001944 log_level = logging.INFO
1945 log_format = ('[%(levelname).1s%(asctime)s %(process)d %(thread)d '
1946 '%(filename)s] %(message)s')
1947 logging.basicConfig(format=log_format, level=log_level)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001948
Edward Lemur227d5102020-02-25 23:45:35 +00001949 if options.description_file:
1950 options.description = gclient_utils.FileRead(options.description_file)
Edward Lemur50984a62020-02-06 18:10:18 +00001951 gerrit_obj = _parse_gerrit_options(parser, options)
1952 change = _parse_change(parser, options)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001953
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001954 try:
Edward Lemur75526302020-02-27 22:31:05 +00001955 if options.post_upload:
1956 return DoPostUploadExecuter(
1957 change,
1958 gerrit_obj,
1959 options.verbose)
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001960 with canned_check_filter(options.skip_canned):
Edward Lemur6eb1d322020-02-27 22:20:15 +00001961 return DoPresubmitChecks(
Edward Lemur50984a62020-02-06 18:10:18 +00001962 change,
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001963 options.commit,
1964 options.verbose,
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001965 options.default_presubmit,
1966 options.may_prompt,
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001967 gerrit_obj,
Edward Lesmes8e282792018-04-03 18:50:29 -04001968 options.dry_run,
Debrian Figueroadd2737e2019-06-21 23:50:13 +00001969 options.parallel,
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001970 options.json_output,
1971 options.gerrit_project)
Raul Tambre7c938462019-05-24 16:35:35 +00001972 except PresubmitFailure as e:
Raul Tambre80ee78e2019-05-06 22:41:05 +00001973 print(e, file=sys.stderr)
1974 print('Maybe your depot_tools is out of date?', file=sys.stderr)
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001975 return 2
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001976
1977
1978if __name__ == '__main__':
maruel@chromium.org35625c72011-03-23 17:34:02 +00001979 fix_encoding.fix_encoding()
sbc@chromium.org013731e2015-02-26 18:28:43 +00001980 try:
1981 sys.exit(main())
1982 except KeyboardInterrupt:
1983 sys.stderr.write('interrupted\n')
sergiybf8a3b382016-07-05 11:21:30 -07001984 sys.exit(2)