blob: 968d8c2ebd0df415a1371befcdab8cb131c61147 [file] [log] [blame]
maruel@chromium.org725f1c32011-04-01 20:24:54 +00001#!/usr/bin/env python
maruel@chromium.org3bbf2942012-01-10 16:52:06 +00002# Copyright (c) 2012 The Chromium Authors. All rights reserved.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00003# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5
6"""Enables directory-specific presubmit checks to run at upload and/or commit.
7"""
8
Raul Tambre80ee78e2019-05-06 22:41:05 +00009from __future__ import print_function
10
stip@chromium.orgf7d31f52014-01-03 20:14:46 +000011__version__ = '1.8.0'
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000012
13# TODO(joi) Add caching where appropriate/needed. The API is designed to allow
14# caching (between all different invocations of presubmit scripts for a given
15# change). We should add it as our presubmit scripts start feeling slow.
16
Edward Lemura5799e32020-01-17 19:26:51 +000017import argparse
Takeshi Yoshino07a6bea2017-08-02 02:44:06 +090018import ast # Exposed through the API.
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +000019import contextlib
Yoshisato Yanagisawa406de132018-06-29 05:43:25 +000020import cpplint
dcheng091b7db2016-06-16 01:27:51 -070021import fnmatch # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000022import glob
asvitkine@chromium.org15169952011-09-27 14:30:53 +000023import inspect
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +000024import itertools
maruel@chromium.org4f6852c2012-04-20 20:39:20 +000025import json # Exposed through the API.
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +000026import logging
ilevy@chromium.orgbc117312013-04-20 03:57:56 +000027import multiprocessing
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000028import os # Somewhat exposed through the API.
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +000029import random
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000030import re # Exposed through the API.
Edward Lesmes8e282792018-04-03 18:50:29 -040031import signal
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000032import sys # Parts exposed through API.
33import tempfile # Exposed through the API.
Edward Lesmes8e282792018-04-03 18:50:29 -040034import threading
jam@chromium.org2a891dc2009-08-20 20:33:37 +000035import time
Edward Lemurde9e3ca2019-10-24 21:13:31 +000036import traceback
maruel@chromium.org1487d532009-06-06 00:22:57 +000037import unittest # Exposed through the API.
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +000038from warnings import warn
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000039
40# Local imports.
maruel@chromium.org35625c72011-03-23 17:34:02 +000041import fix_encoding
Yoshisato Yanagisawa04600b42019-03-15 03:03:41 +000042import gclient_paths # Exposed through the API
43import gclient_utils
Aaron Gableb584c4f2017-04-26 16:28:08 -070044import git_footers
tandrii@chromium.org015ebae2016-04-25 19:37:22 +000045import gerrit_util
dpranke@chromium.org2a009622011-03-01 02:43:31 +000046import owners
Jochen Eisinger76f5fc62017-04-07 16:27:46 +020047import owners_finder
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000048import presubmit_canned_checks
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +000049import scm
maruel@chromium.org84f4fe32011-04-06 13:26:45 +000050import subprocess2 as subprocess # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000051
Edward Lemur16af3562019-10-17 22:11:33 +000052if sys.version_info.major == 2:
53 # TODO(1009814): Expose urllib2 only through urllib_request and urllib_error
54 import urllib2 # Exposed through the API.
55 import urlparse
56 import urllib2 as urllib_request
57 import urllib2 as urllib_error
58else:
59 import urllib.parse as urlparse
60 import urllib.request as urllib_request
61 import urllib.error as urllib_error
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000062
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +000063# Ask for feedback only once in program lifetime.
64_ASKED_FOR_FEEDBACK = False
65
66
Edward Lemurecc27072020-01-06 16:42:34 +000067def time_time():
68 # Use this so that it can be mocked in tests without interfering with python
69 # system machinery.
70 return time.time()
71
72
maruel@chromium.org899e1c12011-04-07 17:03:18 +000073class PresubmitFailure(Exception):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000074 pass
75
76
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000077class CommandData(object):
Edward Lemur940c2822019-08-23 00:34:25 +000078 def __init__(self, name, cmd, kwargs, message, python3=False):
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000079 self.name = name
80 self.cmd = cmd
Edward Lesmes8e282792018-04-03 18:50:29 -040081 self.stdin = kwargs.get('stdin', None)
Edward Lemur2d6b67c2019-08-23 22:25:41 +000082 self.kwargs = kwargs.copy()
Edward Lesmes8e282792018-04-03 18:50:29 -040083 self.kwargs['stdout'] = subprocess.PIPE
84 self.kwargs['stderr'] = subprocess.STDOUT
85 self.kwargs['stdin'] = subprocess.PIPE
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000086 self.message = message
87 self.info = None
Edward Lemur940c2822019-08-23 00:34:25 +000088 self.python3 = python3
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000089
ilevy@chromium.orgbc117312013-04-20 03:57:56 +000090
Edward Lesmes8e282792018-04-03 18:50:29 -040091# Adapted from
92# https://github.com/google/gtest-parallel/blob/master/gtest_parallel.py#L37
93#
94# An object that catches SIGINT sent to the Python process and notices
95# if processes passed to wait() die by SIGINT (we need to look for
96# both of those cases, because pressing Ctrl+C can result in either
97# the main process or one of the subprocesses getting the signal).
98#
99# Before a SIGINT is seen, wait(p) will simply call p.wait() and
100# return the result. Once a SIGINT has been seen (in the main process
101# or a subprocess, including the one the current call is waiting for),
Edward Lemur9a5bb612019-09-26 02:01:52 +0000102# wait(p) will call p.terminate().
Edward Lesmes8e282792018-04-03 18:50:29 -0400103class SigintHandler(object):
Edward Lesmes8e282792018-04-03 18:50:29 -0400104 sigint_returncodes = {-signal.SIGINT, # Unix
105 -1073741510, # Windows
106 }
107 def __init__(self):
108 self.__lock = threading.Lock()
109 self.__processes = set()
110 self.__got_sigint = False
Edward Lemur9a5bb612019-09-26 02:01:52 +0000111 self.__previous_signal = signal.signal(signal.SIGINT, self.interrupt)
Edward Lesmes8e282792018-04-03 18:50:29 -0400112
113 def __on_sigint(self):
114 self.__got_sigint = True
115 while self.__processes:
116 try:
117 self.__processes.pop().terminate()
118 except OSError:
119 pass
120
Edward Lemur9a5bb612019-09-26 02:01:52 +0000121 def interrupt(self, signal_num, frame):
Edward Lesmes8e282792018-04-03 18:50:29 -0400122 with self.__lock:
123 self.__on_sigint()
Edward Lemur9a5bb612019-09-26 02:01:52 +0000124 self.__previous_signal(signal_num, frame)
Edward Lesmes8e282792018-04-03 18:50:29 -0400125
126 def got_sigint(self):
127 with self.__lock:
128 return self.__got_sigint
129
130 def wait(self, p, stdin):
131 with self.__lock:
132 if self.__got_sigint:
133 p.terminate()
134 self.__processes.add(p)
135 stdout, stderr = p.communicate(stdin)
136 code = p.returncode
137 with self.__lock:
138 self.__processes.discard(p)
139 if code in self.sigint_returncodes:
140 self.__on_sigint()
Edward Lesmes8e282792018-04-03 18:50:29 -0400141 return stdout, stderr
142
143sigint_handler = SigintHandler()
144
145
Edward Lemurecc27072020-01-06 16:42:34 +0000146class Timer(object):
147 def __init__(self, timeout, fn):
148 self.completed = False
149 self._fn = fn
150 self._timer = threading.Timer(timeout, self._onTimer) if timeout else None
151
152 def __enter__(self):
153 if self._timer:
154 self._timer.start()
155 return self
156
157 def __exit__(self, _type, _value, _traceback):
158 if self._timer:
159 self._timer.cancel()
160
161 def _onTimer(self):
162 self._fn()
163 self.completed = True
164
165
Edward Lesmes8e282792018-04-03 18:50:29 -0400166class ThreadPool(object):
Edward Lemurecc27072020-01-06 16:42:34 +0000167 def __init__(self, pool_size=None, timeout=None):
168 self.timeout = timeout
Edward Lesmes8e282792018-04-03 18:50:29 -0400169 self._pool_size = pool_size or multiprocessing.cpu_count()
170 self._messages = []
171 self._messages_lock = threading.Lock()
172 self._tests = []
173 self._tests_lock = threading.Lock()
174 self._nonparallel_tests = []
175
Edward Lemurecc27072020-01-06 16:42:34 +0000176 def _GetCommand(self, test):
Edward Lemur940c2822019-08-23 00:34:25 +0000177 vpython = 'vpython'
178 if test.python3:
179 vpython += '3'
180 if sys.platform == 'win32':
181 vpython += '.bat'
Edward Lesmes8e282792018-04-03 18:50:29 -0400182
183 cmd = test.cmd
184 if cmd[0] == 'python':
185 cmd = list(cmd)
186 cmd[0] = vpython
187 elif cmd[0].endswith('.py'):
188 cmd = [vpython] + cmd
189
Edward Lemur336e51f2019-11-14 21:42:04 +0000190 # On Windows, scripts on the current directory take precedence over PATH, so
191 # that when testing depot_tools on Windows, calling `vpython.bat` will
192 # execute the copy of vpython of the depot_tools under test instead of the
193 # one in the bot.
194 # As a workaround, we run the tests from the parent directory instead.
195 if (cmd[0] == vpython and
196 'cwd' in test.kwargs and
197 os.path.basename(test.kwargs['cwd']) == 'depot_tools'):
198 test.kwargs['cwd'] = os.path.dirname(test.kwargs['cwd'])
199 cmd[1] = os.path.join('depot_tools', cmd[1])
200
Edward Lemurecc27072020-01-06 16:42:34 +0000201 return cmd
202
203 def _RunWithTimeout(self, cmd, stdin, kwargs):
204 p = subprocess.Popen(cmd, **kwargs)
205 with Timer(self.timeout, p.terminate) as timer:
206 stdout, _ = sigint_handler.wait(p, stdin)
207 if timer.completed:
208 stdout = 'Process timed out after %ss\n%s' % (self.timeout, stdout)
209 return p.returncode, stdout
210
211 def CallCommand(self, test):
212 """Runs an external program.
213
Edward Lemura5799e32020-01-17 19:26:51 +0000214 This function converts invocation of .py files and invocations of 'python'
Edward Lemurecc27072020-01-06 16:42:34 +0000215 to vpython invocations.
216 """
217 cmd = self._GetCommand(test)
Edward Lesmes8e282792018-04-03 18:50:29 -0400218 try:
Edward Lemurecc27072020-01-06 16:42:34 +0000219 start = time_time()
220 returncode, stdout = self._RunWithTimeout(cmd, test.stdin, test.kwargs)
221 duration = time_time() - start
Edward Lemur7cf94382019-11-15 22:36:41 +0000222 except Exception:
Edward Lemurecc27072020-01-06 16:42:34 +0000223 duration = time_time() - start
Edward Lesmes8e282792018-04-03 18:50:29 -0400224 return test.message(
Edward Lemur7cf94382019-11-15 22:36:41 +0000225 '%s\n%s exec failure (%4.2fs)\n%s' % (
226 test.name, ' '.join(cmd), duration, traceback.format_exc()))
Edward Lemurde9e3ca2019-10-24 21:13:31 +0000227
Edward Lemurecc27072020-01-06 16:42:34 +0000228 if returncode != 0:
Edward Lesmes8e282792018-04-03 18:50:29 -0400229 return test.message(
Edward Lemur7cf94382019-11-15 22:36:41 +0000230 '%s\n%s (%4.2fs) failed\n%s' % (
231 test.name, ' '.join(cmd), duration, stdout))
Edward Lemurecc27072020-01-06 16:42:34 +0000232
Edward Lesmes8e282792018-04-03 18:50:29 -0400233 if test.info:
Edward Lemur7cf94382019-11-15 22:36:41 +0000234 return test.info('%s\n%s (%4.2fs)' % (test.name, ' '.join(cmd), duration))
Edward Lesmes8e282792018-04-03 18:50:29 -0400235
236 def AddTests(self, tests, parallel=True):
237 if parallel:
238 self._tests.extend(tests)
239 else:
240 self._nonparallel_tests.extend(tests)
241
242 def RunAsync(self):
243 self._messages = []
244
245 def _WorkerFn():
246 while True:
247 test = None
248 with self._tests_lock:
249 if not self._tests:
250 break
251 test = self._tests.pop()
252 result = self.CallCommand(test)
253 if result:
254 with self._messages_lock:
255 self._messages.append(result)
256
257 def _StartDaemon():
258 t = threading.Thread(target=_WorkerFn)
259 t.daemon = True
260 t.start()
261 return t
262
263 while self._nonparallel_tests:
264 test = self._nonparallel_tests.pop()
265 result = self.CallCommand(test)
266 if result:
267 self._messages.append(result)
268
269 if self._tests:
270 threads = [_StartDaemon() for _ in range(self._pool_size)]
271 for worker in threads:
272 worker.join()
273
274 return self._messages
275
276
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000277def normpath(path):
278 '''Version of os.path.normpath that also changes backward slashes to
279 forward slashes when not running on Windows.
280 '''
281 # This is safe to always do because the Windows version of os.path.normpath
282 # will replace forward slashes with backward slashes.
283 path = path.replace(os.sep, '/')
284 return os.path.normpath(path)
285
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000286
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000287def _RightHandSideLinesImpl(affected_files):
288 """Implements RightHandSideLines for InputApi and GclChange."""
289 for af in affected_files:
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000290 lines = af.ChangedContents()
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000291 for line in lines:
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000292 yield (af, line[0], line[1])
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000293
294
Edward Lemur6eb1d322020-02-27 22:20:15 +0000295def prompt_should_continue(prompt_string):
296 sys.stdout.write(prompt_string)
297 response = sys.stdin.readline().strip().lower()
298 return response in ('y', 'yes')
dpranke@chromium.org5ac21012011-03-16 02:58:25 +0000299
300
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000301# Top level object so multiprocessing can pickle
302# Public access through OutputApi object.
303class _PresubmitResult(object):
304 """Base class for result objects."""
305 fatal = False
306 should_prompt = False
307
308 def __init__(self, message, items=None, long_text=''):
309 """
310 message: A short one-line message to indicate errors.
311 items: A list of short strings to indicate where errors occurred.
312 long_text: multi-line text output, e.g. from another tool
313 """
314 self._message = message
315 self._items = items or []
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000316 self._long_text = long_text.rstrip()
317
Edward Lemur6eb1d322020-02-27 22:20:15 +0000318 def handle(self):
319 sys.stdout.write(self._message)
320 sys.stdout.write('\n')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000321 for index, item in enumerate(self._items):
Edward Lemur6eb1d322020-02-27 22:20:15 +0000322 sys.stdout.write(' ')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000323 # Write separately in case it's unicode.
Edward Lemur6eb1d322020-02-27 22:20:15 +0000324 sys.stdout.write(str(item))
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000325 if index < len(self._items) - 1:
Edward Lemur6eb1d322020-02-27 22:20:15 +0000326 sys.stdout.write(' \\')
327 sys.stdout.write('\n')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000328 if self._long_text:
Edward Lemur6eb1d322020-02-27 22:20:15 +0000329 sys.stdout.write('\n***************\n')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000330 # Write separately in case it's unicode.
Edward Lemur6eb1d322020-02-27 22:20:15 +0000331 sys.stdout.write(self._long_text)
332 sys.stdout.write('\n***************\n')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000333
Debrian Figueroadd2737e2019-06-21 23:50:13 +0000334 def json_format(self):
335 return {
336 'message': self._message,
Debrian Figueroa6095d402019-06-28 18:47:18 +0000337 'items': [str(item) for item in self._items],
Debrian Figueroadd2737e2019-06-21 23:50:13 +0000338 'long_text': self._long_text,
339 'fatal': self.fatal
340 }
341
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000342
343# Top level object so multiprocessing can pickle
344# Public access through OutputApi object.
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000345class _PresubmitError(_PresubmitResult):
346 """A hard presubmit error."""
347 fatal = True
348
349
350# Top level object so multiprocessing can pickle
351# Public access through OutputApi object.
352class _PresubmitPromptWarning(_PresubmitResult):
353 """An warning that prompts the user if they want to continue."""
354 should_prompt = True
355
356
357# Top level object so multiprocessing can pickle
358# Public access through OutputApi object.
359class _PresubmitNotifyResult(_PresubmitResult):
360 """Just print something to the screen -- but it's not even a warning."""
361 pass
362
363
364# Top level object so multiprocessing can pickle
365# Public access through OutputApi object.
366class _MailTextResult(_PresubmitResult):
367 """A warning that should be included in the review request email."""
368 def __init__(self, *args, **kwargs):
369 super(_MailTextResult, self).__init__()
370 raise NotImplementedError()
371
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000372class GerritAccessor(object):
373 """Limited Gerrit functionality for canned presubmit checks to work.
374
375 To avoid excessive Gerrit calls, caches the results.
376 """
377
378 def __init__(self, host):
379 self.host = host
380 self.cache = {}
381
382 def _FetchChangeDetail(self, issue):
383 # Separate function to be easily mocked in tests.
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +0100384 try:
385 return gerrit_util.GetChangeDetail(
386 self.host, str(issue),
Aaron Gable6f5a8d92017-04-18 14:49:05 -0700387 ['ALL_REVISIONS', 'DETAILED_LABELS', 'ALL_COMMITS'])
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +0100388 except gerrit_util.GerritError as e:
389 if e.http_status == 404:
390 raise Exception('Either Gerrit issue %s doesn\'t exist, or '
391 'no credentials to fetch issue details' % issue)
392 raise
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000393
394 def GetChangeInfo(self, issue):
395 """Returns labels and all revisions (patchsets) for this issue.
396
397 The result is a dictionary according to Gerrit REST Api.
398 https://gerrit-review.googlesource.com/Documentation/rest-api.html
399
400 However, API isn't very clear what's inside, so see tests for example.
401 """
402 assert issue
403 cache_key = int(issue)
404 if cache_key not in self.cache:
405 self.cache[cache_key] = self._FetchChangeDetail(issue)
406 return self.cache[cache_key]
407
408 def GetChangeDescription(self, issue, patchset=None):
409 """If patchset is none, fetches current patchset."""
410 info = self.GetChangeInfo(issue)
411 # info is a reference to cache. We'll modify it here adding description to
412 # it to the right patchset, if it is not yet there.
413
414 # Find revision info for the patchset we want.
415 if patchset is not None:
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +0000416 for rev, rev_info in info['revisions'].items():
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000417 if str(rev_info['_number']) == str(patchset):
418 break
419 else:
420 raise Exception('patchset %s doesn\'t exist in issue %s' % (
421 patchset, issue))
422 else:
423 rev = info['current_revision']
424 rev_info = info['revisions'][rev]
425
Andrii Shyshkalov9c3a4642017-01-24 17:41:22 +0100426 return rev_info['commit']['message']
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000427
Mun Yong Jang603d01e2017-12-19 16:38:30 -0800428 def GetDestRef(self, issue):
429 ref = self.GetChangeInfo(issue)['branch']
430 if not ref.startswith('refs/'):
431 # NOTE: it is possible to create 'refs/x' branch,
432 # aka 'refs/heads/refs/x'. However, this is ill-advised.
433 ref = 'refs/heads/%s' % ref
434 return ref
435
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000436 def GetChangeOwner(self, issue):
437 return self.GetChangeInfo(issue)['owner']['email']
438
439 def GetChangeReviewers(self, issue, approving_only=True):
Aaron Gable8b478f02017-07-31 15:33:19 -0700440 changeinfo = self.GetChangeInfo(issue)
441 if approving_only:
442 labelinfo = changeinfo.get('labels', {}).get('Code-Review', {})
443 values = labelinfo.get('values', {}).keys()
444 try:
445 max_value = max(int(v) for v in values)
446 reviewers = [r for r in labelinfo.get('all', [])
447 if r.get('value', 0) == max_value]
448 except ValueError: # values is the empty list
449 reviewers = []
450 else:
451 reviewers = changeinfo.get('reviewers', {}).get('REVIEWER', [])
452 return [r.get('email') for r in reviewers]
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000453
Edward Lemure4d329c2020-02-03 20:41:18 +0000454 def UpdateDescription(self, description, issue):
455 gerrit_util.SetCommitMessage(self.host, issue, description, notify='NONE')
456
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000457
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000458class OutputApi(object):
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000459 """An instance of OutputApi gets passed to presubmit scripts so that they
460 can output various types of results.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000461 """
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000462 PresubmitResult = _PresubmitResult
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000463 PresubmitError = _PresubmitError
464 PresubmitPromptWarning = _PresubmitPromptWarning
465 PresubmitNotifyResult = _PresubmitNotifyResult
466 MailTextResult = _MailTextResult
467
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000468 def __init__(self, is_committing):
469 self.is_committing = is_committing
Daniel Cheng7227d212017-11-17 08:12:37 -0800470 self.more_cc = []
471
472 def AppendCC(self, cc):
473 """Appends a user to cc for this change."""
474 self.more_cc.append(cc)
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000475
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000476 def PresubmitPromptOrNotify(self, *args, **kwargs):
477 """Warn the user when uploading, but only notify if committing."""
478 if self.is_committing:
479 return self.PresubmitNotifyResult(*args, **kwargs)
480 return self.PresubmitPromptWarning(*args, **kwargs)
481
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000482
483class InputApi(object):
484 """An instance of this object is passed to presubmit scripts so they can
485 know stuff about the change they're looking at.
486 """
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000487 # Method could be a function
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800488 # pylint: disable=no-self-use
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000489
maruel@chromium.org3410d912009-06-09 20:56:16 +0000490 # File extensions that are considered source files from a style guide
491 # perspective. Don't modify this list from a presubmit script!
maruel@chromium.orgc33455a2011-06-24 19:14:18 +0000492 #
493 # Files without an extension aren't included in the list. If you want to
local_bot30f774e2020-06-25 18:23:34 +0000494 # filter them as source files, add r'(^|.*?[\\\/])[^.]+$' to the allow list.
495 # Note that ALL CAPS files are blocked in DEFAULT_BLOCK_LIST below.
496 DEFAULT_ALLOW_LIST = (
maruel@chromium.org3410d912009-06-09 20:56:16 +0000497 # C++ and friends
Edward Lemura5799e32020-01-17 19:26:51 +0000498 r'.+\.c$', r'.+\.cc$', r'.+\.cpp$', r'.+\.h$', r'.+\.m$', r'.+\.mm$',
499 r'.+\.inl$', r'.+\.asm$', r'.+\.hxx$', r'.+\.hpp$', r'.+\.s$', r'.+\.S$',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000500 # Scripts
Edward Lemura5799e32020-01-17 19:26:51 +0000501 r'.+\.js$', r'.+\.py$', r'.+\.sh$', r'.+\.rb$', r'.+\.pl$', r'.+\.pm$',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000502 # Other
Edward Lemura5799e32020-01-17 19:26:51 +0000503 r'.+\.java$', r'.+\.mk$', r'.+\.am$', r'.+\.css$', r'.+\.mojom$',
504 r'.+\.fidl$'
maruel@chromium.org3410d912009-06-09 20:56:16 +0000505 )
506
507 # Path regexp that should be excluded from being considered containing source
508 # files. Don't modify this list from a presubmit script!
local_bot30f774e2020-06-25 18:23:34 +0000509 DEFAULT_BLOCK_LIST = (
Edward Lemura5799e32020-01-17 19:26:51 +0000510 r'testing_support[\\\/]google_appengine[\\\/].*',
511 r'.*\bexperimental[\\\/].*',
Kent Tamura179dd1e2018-04-26 15:07:41 +0900512 # Exclude third_party/.* but NOT third_party/{WebKit,blink}
513 # (crbug.com/539768 and crbug.com/836555).
Edward Lemura5799e32020-01-17 19:26:51 +0000514 r'.*\bthird_party[\\\/](?!(WebKit|blink)[\\\/]).*',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000515 # Output directories (just in case)
Edward Lemura5799e32020-01-17 19:26:51 +0000516 r'.*\bDebug[\\\/].*',
517 r'.*\bRelease[\\\/].*',
518 r'.*\bxcodebuild[\\\/].*',
519 r'.*\bout[\\\/].*',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000520 # All caps files like README and LICENCE.
Edward Lemura5799e32020-01-17 19:26:51 +0000521 r'.*\b[A-Z0-9_]{2,}$',
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +0000522 # SCM (can happen in dual SCM configuration). (Slightly over aggressive)
Edward Lemura5799e32020-01-17 19:26:51 +0000523 r'(|.*[\\\/])\.git[\\\/].*',
524 r'(|.*[\\\/])\.svn[\\\/].*',
maruel@chromium.org7ccb4bb2011-11-07 20:26:20 +0000525 # There is no point in processing a patch file.
Edward Lemura5799e32020-01-17 19:26:51 +0000526 r'.+\.diff$',
527 r'.+\.patch$',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000528 )
529
local_bot30f774e2020-06-25 18:23:34 +0000530 # TODO(https://crbug.com/1098562): Remove once no longer used
531 @property
532 def DEFAULT_WHITE_LIST(self):
533 return self.DEFAULT_ALLOW_LIST
534
535 # TODO(https://crbug.com/1098562): Remove once no longer used
local_bot37ce2012020-06-26 17:39:24 +0000536 @DEFAULT_WHITE_LIST.setter
537 def DEFAULT_WHITE_LIST(self, value):
538 self.DEFAULT_ALLOW_LIST = value
539
540 # TODO(https://crbug.com/1098562): Remove once no longer used
local_bot30f774e2020-06-25 18:23:34 +0000541 @property
542 def DEFAULT_BLACK_LIST(self):
543 return self.DEFAULT_BLOCK_LIST
544
local_bot37ce2012020-06-26 17:39:24 +0000545 # TODO(https://crbug.com/1098562): Remove once no longer used
546 @DEFAULT_BLACK_LIST.setter
547 def DEFAULT_BLACK_LIST(self, value):
548 self.DEFAULT_BLOCK_LIST = value
549
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000550 def __init__(self, change, presubmit_path, is_committing,
Edward Lesmes8e282792018-04-03 18:50:29 -0400551 verbose, gerrit_obj, dry_run=None, thread_pool=None, parallel=False):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000552 """Builds an InputApi object.
553
554 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000555 change: A presubmit.Change object.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000556 presubmit_path: The path to the presubmit script being processed.
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000557 is_committing: True if the change is about to be committed.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000558 gerrit_obj: provides basic Gerrit codereview functionality.
559 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -0400560 parallel: if true, all tests reported via input_api.RunTests for all
561 PRESUBMIT files will be run in parallel.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000562 """
maruel@chromium.org9711bba2009-05-22 23:51:39 +0000563 # Version number of the presubmit_support script.
564 self.version = [int(x) for x in __version__.split('.')]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000565 self.change = change
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000566 self.is_committing = is_committing
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000567 self.gerrit = gerrit_obj
tandrii@chromium.org57bafac2016-04-28 05:09:03 +0000568 self.dry_run = dry_run
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000569
Edward Lesmes8e282792018-04-03 18:50:29 -0400570 self.parallel = parallel
571 self.thread_pool = thread_pool or ThreadPool()
572
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000573 # We expose various modules and functions as attributes of the input_api
574 # so that presubmit scripts don't have to import them.
Takeshi Yoshino07a6bea2017-08-02 02:44:06 +0900575 self.ast = ast
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000576 self.basename = os.path.basename
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000577 self.cpplint = cpplint
dcheng091b7db2016-06-16 01:27:51 -0700578 self.fnmatch = fnmatch
Yoshisato Yanagisawa04600b42019-03-15 03:03:41 +0000579 self.gclient_paths = gclient_paths
Yoshisato Yanagisawa57dd17b2019-03-22 09:10:29 +0000580 # TODO(yyanagisawa): stop exposing this when python3 become default.
581 # Since python3's tempfile has TemporaryDirectory, we do not need this.
582 self.temporary_directory = gclient_utils.temporary_directory
dpranke@chromium.org17cc2442012-10-17 21:12:09 +0000583 self.glob = glob.glob
maruel@chromium.orgfb11c7b2010-03-18 18:22:14 +0000584 self.json = json
maruel@chromium.org6fba34d2011-06-02 13:45:12 +0000585 self.logging = logging.getLogger('PRESUBMIT')
maruel@chromium.org2b5ce562011-03-31 16:15:44 +0000586 self.os_listdir = os.listdir
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000587 self.os_path = os.path
pgervais@chromium.orgbd0cace2014-10-02 23:23:46 +0000588 self.os_stat = os.stat
Yoshisato Yanagisawa406de132018-06-29 05:43:25 +0000589 self.os_walk = os.walk
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000590 self.re = re
591 self.subprocess = subprocess
Edward Lemurb9830242019-10-30 22:19:20 +0000592 self.sys = sys
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000593 self.tempfile = tempfile
dpranke@chromium.org0d1bdea2011-03-24 22:54:38 +0000594 self.time = time
maruel@chromium.org1487d532009-06-06 00:22:57 +0000595 self.unittest = unittest
Edward Lemurb9830242019-10-30 22:19:20 +0000596 if sys.version_info.major == 2:
597 self.urllib2 = urllib2
Edward Lemur16af3562019-10-17 22:11:33 +0000598 self.urllib_request = urllib_request
599 self.urllib_error = urllib_error
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000600
Robert Iannucci50258932018-03-19 10:30:59 -0700601 self.is_windows = sys.platform == 'win32'
602
Edward Lemurb9646622019-10-25 20:57:35 +0000603 # Set python_executable to 'vpython' in order to allow scripts in other
604 # repos (e.g. src.git) to automatically pick up that repo's .vpython file,
605 # instead of inheriting the one in depot_tools.
606 self.python_executable = 'vpython'
maruel@chromium.orgc0b22972009-06-25 16:19:14 +0000607 self.environ = os.environ
608
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000609 # InputApi.platform is the platform you're currently running on.
610 self.platform = sys.platform
611
iannucci@chromium.org0af3bb32015-06-12 20:44:35 +0000612 self.cpu_count = multiprocessing.cpu_count()
613
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000614 # The local path of the currently-being-processed presubmit script.
maruel@chromium.org3d235242009-05-15 12:40:48 +0000615 self._current_presubmit_path = os.path.dirname(presubmit_path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000616
617 # We carry the canned checks so presubmit scripts can easily use them.
618 self.canned_checks = presubmit_canned_checks
619
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +0100620 # Temporary files we must manually remove at the end of a run.
621 self._named_temporary_files = []
Jochen Eisinger72606f82017-04-04 10:44:18 +0200622
dpranke@chromium.org2a009622011-03-01 02:43:31 +0000623 # TODO(dpranke): figure out a list of all approved owners for a repo
624 # in order to be able to handle wildcard OWNERS files?
625 self.owners_db = owners.Database(change.RepositoryRoot(),
Edward Lemurb9830242019-10-30 22:19:20 +0000626 fopen=open, os_path=self.os_path)
Jochen Eisinger76f5fc62017-04-07 16:27:46 +0200627 self.owners_finder = owners_finder.OwnersFinder
maruel@chromium.org899e1c12011-04-07 17:03:18 +0000628 self.verbose = verbose
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000629 self.Command = CommandData
dpranke@chromium.org2a009622011-03-01 02:43:31 +0000630
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000631 # Replace <hash_map> and <hash_set> as headers that need to be included
Edward Lemura5799e32020-01-17 19:26:51 +0000632 # with 'base/containers/hash_tables.h' instead.
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000633 # Access to a protected member _XX of a client class
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800634 # pylint: disable=protected-access
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000635 self.cpplint._re_pattern_templates = [
danakj@chromium.org18278522013-06-11 22:42:32 +0000636 (a, b, 'base/containers/hash_tables.h')
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000637 if header in ('<hash_map>', '<hash_set>') else (a, b, header)
638 for (a, b, header) in cpplint._re_pattern_templates
639 ]
640
Edward Lemurecc27072020-01-06 16:42:34 +0000641 def SetTimeout(self, timeout):
642 self.thread_pool.timeout = timeout
643
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000644 def PresubmitLocalPath(self):
645 """Returns the local path of the presubmit script currently being run.
646
647 This is useful if you don't want to hard-code absolute paths in the
648 presubmit script. For example, It can be used to find another file
649 relative to the PRESUBMIT.py script, so the whole tree can be branched and
650 the presubmit script still works, without editing its content.
651 """
maruel@chromium.org3d235242009-05-15 12:40:48 +0000652 return self._current_presubmit_path
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000653
agable0b65e732016-11-22 09:25:46 -0800654 def AffectedFiles(self, include_deletes=True, file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000655 """Same as input_api.change.AffectedFiles() except only lists files
656 (and optionally directories) in the same directory as the current presubmit
Bruce Dawson7a0b07a2020-04-23 17:14:40 +0000657 script, or subdirectories thereof. Note that files are listed using the OS
658 path separator, so backslashes are used as separators on Windows.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000659 """
Edward Lemura5799e32020-01-17 19:26:51 +0000660 dir_with_slash = normpath('%s/' % self.PresubmitLocalPath())
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000661 if len(dir_with_slash) == 1:
662 dir_with_slash = ''
sail@chromium.org5538e022011-05-12 17:53:16 +0000663
Edward Lemurb9830242019-10-30 22:19:20 +0000664 return list(filter(
maruel@chromium.org4661e0c2009-06-04 00:45:26 +0000665 lambda x: normpath(x.AbsoluteLocalPath()).startswith(dir_with_slash),
Edward Lemurb9830242019-10-30 22:19:20 +0000666 self.change.AffectedFiles(include_deletes, file_filter)))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000667
agable0b65e732016-11-22 09:25:46 -0800668 def LocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000669 """Returns local paths of input_api.AffectedFiles()."""
agable0b65e732016-11-22 09:25:46 -0800670 paths = [af.LocalPath() for af in self.AffectedFiles()]
Edward Lemura5799e32020-01-17 19:26:51 +0000671 logging.debug('LocalPaths: %s', paths)
pgervais@chromium.org2f64f782014-04-25 00:12:33 +0000672 return paths
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000673
agable0b65e732016-11-22 09:25:46 -0800674 def AbsoluteLocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000675 """Returns absolute local paths of input_api.AffectedFiles()."""
agable0b65e732016-11-22 09:25:46 -0800676 return [af.AbsoluteLocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000677
John Budorick16162372018-04-18 10:39:53 -0700678 def AffectedTestableFiles(self, include_deletes=None, **kwargs):
agable0b65e732016-11-22 09:25:46 -0800679 """Same as input_api.change.AffectedTestableFiles() except only lists files
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000680 in the same directory as the current presubmit script, or subdirectories
681 thereof.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000682 """
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000683 if include_deletes is not None:
Edward Lemura5799e32020-01-17 19:26:51 +0000684 warn('AffectedTestableFiles(include_deletes=%s)'
685 ' is deprecated and ignored' % str(include_deletes),
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000686 category=DeprecationWarning,
687 stacklevel=2)
Edward Lemurb9830242019-10-30 22:19:20 +0000688 return list(filter(
689 lambda x: x.IsTestableFile(),
690 self.AffectedFiles(include_deletes=False, **kwargs)))
agable0b65e732016-11-22 09:25:46 -0800691
692 def AffectedTextFiles(self, include_deletes=None):
693 """An alias to AffectedTestableFiles for backwards compatibility."""
694 return self.AffectedTestableFiles(include_deletes=include_deletes)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000695
local_bot30f774e2020-06-25 18:23:34 +0000696 def FilterSourceFile(self, affected_file, allow_list=None, block_list=None,
697 white_list=None, black_list=None):
Edward Lemura5799e32020-01-17 19:26:51 +0000698 """Filters out files that aren't considered 'source file'.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000699
local_bot30f774e2020-06-25 18:23:34 +0000700 If allow_list or block_list is None, InputApi.DEFAULT_ALLOW_LIST
701 and InputApi.DEFAULT_BLOCK_LIST is used respectively.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000702
703 The lists will be compiled as regular expression and
704 AffectedFile.LocalPath() needs to pass both list.
705
local_bot30f774e2020-06-25 18:23:34 +0000706 Note: if allow_list or block_list is not set, and white_list or black_list
707 is, then those values are used. This is used for backward compatibility
708 reasons.
709
maruel@chromium.org3410d912009-06-09 20:56:16 +0000710 Note: Copy-paste this function to suit your needs or use a lambda function.
711 """
local_bot30f774e2020-06-25 18:23:34 +0000712 if allow_list is None:
713 allow_list = white_list
714 if block_list is None:
715 block_list = black_list
716
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000717 def Find(affected_file, items):
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000718 local_path = affected_file.LocalPath()
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000719 for item in items:
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +0000720 if self.re.match(item, local_path):
maruel@chromium.org3410d912009-06-09 20:56:16 +0000721 return True
722 return False
local_bot30f774e2020-06-25 18:23:34 +0000723 return (Find(affected_file, allow_list or self.DEFAULT_ALLOW_LIST) and
724 not Find(affected_file, block_list or self.DEFAULT_BLOCK_LIST))
maruel@chromium.org3410d912009-06-09 20:56:16 +0000725
726 def AffectedSourceFiles(self, source_file):
agable0b65e732016-11-22 09:25:46 -0800727 """Filter the list of AffectedTestableFiles by the function source_file.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000728
729 If source_file is None, InputApi.FilterSourceFile() is used.
730 """
731 if not source_file:
732 source_file = self.FilterSourceFile
Edward Lemurb9830242019-10-30 22:19:20 +0000733 return list(filter(source_file, self.AffectedTestableFiles()))
maruel@chromium.org3410d912009-06-09 20:56:16 +0000734
735 def RightHandSideLines(self, source_file_filter=None):
Edward Lemura5799e32020-01-17 19:26:51 +0000736 """An iterator over all text lines in 'new' version of changed files.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000737
738 Only lists lines from new or modified text files in the change that are
739 contained by the directory of the currently executing presubmit script.
740
741 This is useful for doing line-by-line regex checks, like checking for
742 trailing whitespace.
743
744 Yields:
745 a 3 tuple:
746 the AffectedFile instance of the current file;
747 integer line number (1-based); and
748 the contents of the line as a string.
maruel@chromium.org1487d532009-06-06 00:22:57 +0000749
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000750 Note: The carriage return (LF or CR) is stripped off.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000751 """
maruel@chromium.org3410d912009-06-09 20:56:16 +0000752 files = self.AffectedSourceFiles(source_file_filter)
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000753 return _RightHandSideLinesImpl(files)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000754
maruel@chromium.orge3608df2009-11-10 20:22:57 +0000755 def ReadFile(self, file_item, mode='r'):
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000756 """Reads an arbitrary file.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000757
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000758 Deny reading anything outside the repository.
759 """
maruel@chromium.orge3608df2009-11-10 20:22:57 +0000760 if isinstance(file_item, AffectedFile):
761 file_item = file_item.AbsoluteLocalPath()
762 if not file_item.startswith(self.change.RepositoryRoot()):
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000763 raise IOError('Access outside the repository root is denied.')
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +0000764 return gclient_utils.FileRead(file_item, mode)
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000765
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +0100766 def CreateTemporaryFile(self, **kwargs):
767 """Returns a named temporary file that must be removed with a call to
768 RemoveTemporaryFiles().
769
770 All keyword arguments are forwarded to tempfile.NamedTemporaryFile(),
771 except for |delete|, which is always set to False.
772
773 Presubmit checks that need to create a temporary file and pass it for
774 reading should use this function instead of NamedTemporaryFile(), as
775 Windows fails to open a file that is already open for writing.
776
777 with input_api.CreateTemporaryFile() as f:
778 f.write('xyz')
779 f.close()
780 input_api.subprocess.check_output(['script-that', '--reads-from',
781 f.name])
782
783
784 Note that callers of CreateTemporaryFile() should not worry about removing
785 any temporary file; this is done transparently by the presubmit handling
786 code.
787 """
788 if 'delete' in kwargs:
789 # Prevent users from passing |delete|; we take care of file deletion
790 # ourselves and this prevents unintuitive error messages when we pass
791 # delete=False and 'delete' is also in kwargs.
792 raise TypeError('CreateTemporaryFile() does not take a "delete" '
793 'argument, file deletion is handled automatically by '
794 'the same presubmit_support code that creates InputApi '
795 'objects.')
796 temp_file = self.tempfile.NamedTemporaryFile(delete=False, **kwargs)
797 self._named_temporary_files.append(temp_file.name)
798 return temp_file
799
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000800 @property
801 def tbr(self):
802 """Returns if a change is TBR'ed."""
Jeremy Romandce22502017-06-20 15:37:29 -0400803 return 'TBR' in self.change.tags or self.change.TBRsFromDescription()
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000804
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +0000805 def RunTests(self, tests_mix, parallel=True):
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000806 tests = []
807 msgs = []
808 for t in tests_mix:
Edward Lesmes8e282792018-04-03 18:50:29 -0400809 if isinstance(t, OutputApi.PresubmitResult) and t:
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000810 msgs.append(t)
811 else:
812 assert issubclass(t.message, _PresubmitResult)
813 tests.append(t)
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +0000814 if self.verbose:
815 t.info = _PresubmitNotifyResult
Edward Lemur1037c742018-05-01 18:56:04 -0400816 if not t.kwargs.get('cwd'):
817 t.kwargs['cwd'] = self.PresubmitLocalPath()
Edward Lesmes8e282792018-04-03 18:50:29 -0400818 self.thread_pool.AddTests(tests, parallel)
Edward Lemur21000eb2019-05-24 23:25:58 +0000819 # When self.parallel is True (i.e. --parallel is passed as an option)
820 # RunTests doesn't actually run tests. It adds them to a ThreadPool that
821 # will run all tests once all PRESUBMIT files are processed.
822 # Otherwise, it will run them and return the results.
823 if not self.parallel:
Edward Lesmes8e282792018-04-03 18:50:29 -0400824 msgs.extend(self.thread_pool.RunAsync())
825 return msgs
scottmg86099d72016-09-01 09:16:51 -0700826
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000827
nick@chromium.orgff526192013-06-10 19:30:26 +0000828class _DiffCache(object):
829 """Caches diffs retrieved from a particular SCM."""
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000830 def __init__(self, upstream=None):
831 """Stores the upstream revision against which all diffs will be computed."""
832 self._upstream = upstream
nick@chromium.orgff526192013-06-10 19:30:26 +0000833
834 def GetDiff(self, path, local_root):
835 """Get the diff for a particular path."""
836 raise NotImplementedError()
837
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700838 def GetOldContents(self, path, local_root):
839 """Get the old version for a particular path."""
840 raise NotImplementedError()
841
nick@chromium.orgff526192013-06-10 19:30:26 +0000842
nick@chromium.orgff526192013-06-10 19:30:26 +0000843class _GitDiffCache(_DiffCache):
844 """DiffCache implementation for git; gets all file diffs at once."""
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000845 def __init__(self, upstream):
846 super(_GitDiffCache, self).__init__(upstream=upstream)
nick@chromium.orgff526192013-06-10 19:30:26 +0000847 self._diffs_by_file = None
848
849 def GetDiff(self, path, local_root):
850 if not self._diffs_by_file:
851 # Compute a single diff for all files and parse the output; should
852 # with git this is much faster than computing one diff for each file.
853 diffs = {}
854
855 # Don't specify any filenames below, because there are command line length
856 # limits on some platforms and GenerateDiff would fail.
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000857 unified_diff = scm.GIT.GenerateDiff(local_root, files=[], full_move=True,
858 branch=self._upstream)
nick@chromium.orgff526192013-06-10 19:30:26 +0000859
860 # This regex matches the path twice, separated by a space. Note that
861 # filename itself may contain spaces.
862 file_marker = re.compile('^diff --git (?P<filename>.*) (?P=filename)$')
863 current_diff = []
864 keep_line_endings = True
865 for x in unified_diff.splitlines(keep_line_endings):
866 match = file_marker.match(x)
867 if match:
868 # Marks the start of a new per-file section.
869 diffs[match.group('filename')] = current_diff = [x]
870 elif x.startswith('diff --git'):
871 raise PresubmitFailure('Unexpected diff line: %s' % x)
872 else:
873 current_diff.append(x)
874
875 self._diffs_by_file = dict(
876 (normpath(path), ''.join(diff)) for path, diff in diffs.items())
877
878 if path not in self._diffs_by_file:
879 raise PresubmitFailure(
880 'Unified diff did not contain entry for file %s' % path)
881
882 return self._diffs_by_file[path]
883
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700884 def GetOldContents(self, path, local_root):
885 return scm.GIT.GetOldContents(local_root, path, branch=self._upstream)
886
nick@chromium.orgff526192013-06-10 19:30:26 +0000887
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000888class AffectedFile(object):
889 """Representation of a file in a change."""
nick@chromium.orgff526192013-06-10 19:30:26 +0000890
891 DIFF_CACHE = _DiffCache
892
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000893 # Method could be a function
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800894 # pylint: disable=no-self-use
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000895 def __init__(self, path, action, repository_root, diff_cache):
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000896 self._path = path
897 self._action = action
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000898 self._local_root = repository_root
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000899 self._is_directory = None
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000900 self._cached_changed_contents = None
901 self._cached_new_contents = None
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000902 self._diff_cache = diff_cache
tobiasjs2836bcf2016-08-16 04:08:16 -0700903 logging.debug('%s(%s)', self.__class__.__name__, self._path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000904
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000905 def LocalPath(self):
906 """Returns the path of this file on the local disk relative to client root.
Andrew Grieve92b8b992017-11-02 09:42:24 -0400907
908 This should be used for error messages but not for accessing files,
909 because presubmit checks are run with CWD=PresubmitLocalPath() (which is
910 often != client root).
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000911 """
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000912 return normpath(self._path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000913
914 def AbsoluteLocalPath(self):
915 """Returns the absolute path of this file on the local disk.
916 """
chase@chromium.org8e416c82009-10-06 04:30:44 +0000917 return os.path.abspath(os.path.join(self._local_root, self.LocalPath()))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000918
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000919 def Action(self):
920 """Returns the action on this opened file, e.g. A, M, D, etc."""
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000921 return self._action
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000922
agable0b65e732016-11-22 09:25:46 -0800923 def IsTestableFile(self):
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000924 """Returns True if the file is a text file and not a binary file.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000925
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000926 Deleted files are not text file."""
maruel@chromium.org1e08c002009-05-28 19:09:33 +0000927 raise NotImplementedError() # Implement when needed
928
agable0b65e732016-11-22 09:25:46 -0800929 def IsTextFile(self):
930 """An alias to IsTestableFile for backwards compatibility."""
931 return self.IsTestableFile()
932
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700933 def OldContents(self):
934 """Returns an iterator over the lines in the old version of file.
935
Daniel Cheng2da34fe2017-03-21 20:42:12 -0700936 The old version is the file before any modifications in the user's
Edward Lemura5799e32020-01-17 19:26:51 +0000937 workspace, i.e. the 'left hand side'.
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700938
939 Contents will be empty if the file is a directory or does not exist.
940 Note: The carriage returns (LF or CR) are stripped off.
941 """
942 return self._diff_cache.GetOldContents(self.LocalPath(),
943 self._local_root).splitlines()
944
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000945 def NewContents(self):
946 """Returns an iterator over the lines in the new version of file.
947
Edward Lemura5799e32020-01-17 19:26:51 +0000948 The new version is the file in the user's workspace, i.e. the 'right hand
949 side'.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000950
951 Contents will be empty if the file is a directory or does not exist.
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000952 Note: The carriage returns (LF or CR) are stripped off.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000953 """
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000954 if self._cached_new_contents is None:
955 self._cached_new_contents = []
agable0b65e732016-11-22 09:25:46 -0800956 try:
957 self._cached_new_contents = gclient_utils.FileRead(
958 self.AbsoluteLocalPath(), 'rU').splitlines()
959 except IOError:
960 pass # File not found? That's fine; maybe it was deleted.
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000961 return self._cached_new_contents[:]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000962
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000963 def ChangedContents(self):
964 """Returns a list of tuples (line number, line text) of all new lines.
965
966 This relies on the scm diff output describing each changed code section
967 with a line of the form
968
969 ^@@ <old line num>,<old size> <new line num>,<new size> @@$
970 """
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000971 if self._cached_changed_contents is not None:
972 return self._cached_changed_contents[:]
973 self._cached_changed_contents = []
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000974 line_num = 0
975
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000976 for line in self.GenerateScmDiff().splitlines():
Edward Lemurac5c55f2020-02-29 00:17:16 +0000977 m = re.match(r'^@@ [0-9\,\+\-]+ \+([0-9]+)\,[0-9]+ @@', line)
978 if m:
979 line_num = int(m.groups(1)[0])
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000980 continue
981 if line.startswith('+') and not line.startswith('++'):
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000982 self._cached_changed_contents.append((line_num, line[1:]))
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000983 if not line.startswith('-'):
984 line_num += 1
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000985 return self._cached_changed_contents[:]
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000986
maruel@chromium.org5de13972009-06-10 18:16:06 +0000987 def __str__(self):
988 return self.LocalPath()
989
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000990 def GenerateScmDiff(self):
nick@chromium.orgff526192013-06-10 19:30:26 +0000991 return self._diff_cache.GetDiff(self.LocalPath(), self._local_root)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000992
maruel@chromium.org58407af2011-04-12 23:15:57 +0000993
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000994class GitAffectedFile(AffectedFile):
995 """Representation of a file in a change out of a git checkout."""
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000996 # Method 'NNN' is abstract in class 'NNN' but is not overridden
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800997 # pylint: disable=abstract-method
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000998
nick@chromium.orgff526192013-06-10 19:30:26 +0000999 DIFF_CACHE = _GitDiffCache
1000
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001001 def __init__(self, *args, **kwargs):
1002 AffectedFile.__init__(self, *args, **kwargs)
1003 self._server_path = None
agable0b65e732016-11-22 09:25:46 -08001004 self._is_testable_file = None
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001005
agable0b65e732016-11-22 09:25:46 -08001006 def IsTestableFile(self):
1007 if self._is_testable_file is None:
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001008 if self.Action() == 'D':
agable0b65e732016-11-22 09:25:46 -08001009 # A deleted file is not testable.
1010 self._is_testable_file = False
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001011 else:
agable0b65e732016-11-22 09:25:46 -08001012 self._is_testable_file = os.path.isfile(self.AbsoluteLocalPath())
1013 return self._is_testable_file
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001014
maruel@chromium.orgc1938752011-04-12 23:11:13 +00001015
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001016class Change(object):
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001017 """Describe a change.
1018
1019 Used directly by the presubmit scripts to query the current change being
1020 tested.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +00001021
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001022 Instance members:
nick@chromium.orgff526192013-06-10 19:30:26 +00001023 tags: Dictionary of KEY=VALUE pairs found in the change description.
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001024 self.KEY: equivalent to tags['KEY']
1025 """
1026
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001027 _AFFECTED_FILES = AffectedFile
1028
Edward Lemura5799e32020-01-17 19:26:51 +00001029 # Matches key/value (or 'tag') lines in changelist descriptions.
maruel@chromium.org428342a2011-11-10 15:46:33 +00001030 TAG_LINE_RE = re.compile(
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001031 '^[ \t]*(?P<key>[A-Z][A-Z_0-9]*)[ \t]*=[ \t]*(?P<value>.*?)[ \t]*$')
maruel@chromium.orgc1938752011-04-12 23:11:13 +00001032 scm = ''
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001033
maruel@chromium.org58407af2011-04-12 23:15:57 +00001034 def __init__(
agable@chromium.orgea84ef12014-04-30 19:55:12 +00001035 self, name, description, local_root, files, issue, patchset, author,
1036 upstream=None):
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001037 if files is None:
1038 files = []
1039 self._name = name
chase@chromium.org8e416c82009-10-06 04:30:44 +00001040 # Convert root into an absolute path.
1041 self._local_root = os.path.abspath(local_root)
agable@chromium.orgea84ef12014-04-30 19:55:12 +00001042 self._upstream = upstream
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001043 self.issue = issue
1044 self.patchset = patchset
maruel@chromium.org58407af2011-04-12 23:15:57 +00001045 self.author_email = author
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001046
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001047 self._full_description = ''
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001048 self.tags = {}
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001049 self._description_without_tags = ''
1050 self.SetDescriptionText(description)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001051
maruel@chromium.orge085d812011-10-10 19:49:15 +00001052 assert all(
1053 (isinstance(f, (list, tuple)) and len(f) == 2) for f in files), files
1054
agable@chromium.orgea84ef12014-04-30 19:55:12 +00001055 diff_cache = self._AFFECTED_FILES.DIFF_CACHE(self._upstream)
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001056 self._affected_files = [
nick@chromium.orgff526192013-06-10 19:30:26 +00001057 self._AFFECTED_FILES(path, action.strip(), self._local_root, diff_cache)
1058 for action, path in files
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +00001059 ]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001060
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001061 def Name(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001062 """Returns the change name."""
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001063 return self._name
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001064
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001065 def DescriptionText(self):
1066 """Returns the user-entered changelist description, minus tags.
1067
Edward Lemura5799e32020-01-17 19:26:51 +00001068 Any line in the user-provided description starting with e.g. 'FOO='
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001069 (whitespace permitted before and around) is considered a tag line. Such
1070 lines are stripped out of the description this function returns.
1071 """
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001072 return self._description_without_tags
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001073
1074 def FullDescriptionText(self):
1075 """Returns the complete changelist description including tags."""
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001076 return self._full_description
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001077
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001078 def SetDescriptionText(self, description):
1079 """Sets the full description text (including tags) to |description|.
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001080
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001081 Also updates the list of tags."""
1082 self._full_description = description
1083
1084 # From the description text, build up a dictionary of key/value pairs
Edward Lemura5799e32020-01-17 19:26:51 +00001085 # plus the description minus all key/value or 'tag' lines.
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001086 description_without_tags = []
1087 self.tags = {}
1088 for line in self._full_description.splitlines():
1089 m = self.TAG_LINE_RE.match(line)
1090 if m:
1091 self.tags[m.group('key')] = m.group('value')
1092 else:
1093 description_without_tags.append(line)
1094
1095 # Change back to text and remove whitespace at end.
1096 self._description_without_tags = (
1097 '\n'.join(description_without_tags).rstrip())
1098
Edward Lemur69bb8be2020-02-03 20:37:38 +00001099 def AddDescriptionFooter(self, key, value):
1100 """Adds the given footer to the change description.
1101
1102 Args:
1103 key: A string with the key for the git footer. It must conform to
1104 the git footers format (i.e. 'List-Of-Tokens') and will be case
1105 normalized so that each token is title-cased.
1106 value: A string with the value for the git footer.
1107 """
1108 description = git_footers.add_footer(
1109 self.FullDescriptionText(), git_footers.normalize_name(key), value)
1110 self.SetDescriptionText(description)
1111
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001112 def RepositoryRoot(self):
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001113 """Returns the repository (checkout) root directory for this change,
1114 as an absolute path.
1115 """
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001116 return self._local_root
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001117
1118 def __getattr__(self, attr):
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001119 """Return tags directly as attributes on the object."""
Edward Lemura5799e32020-01-17 19:26:51 +00001120 if not re.match(r'^[A-Z_]*$', attr):
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001121 raise AttributeError(self, attr)
maruel@chromium.orge1a524f2009-05-27 14:43:46 +00001122 return self.tags.get(attr)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001123
Edward Lemur69bb8be2020-02-03 20:37:38 +00001124 def GitFootersFromDescription(self):
1125 """Return the git footers present in the description.
1126
1127 Returns:
1128 footers: A dict of {footer: [values]} containing a multimap of the footers
1129 in the change description.
1130 """
1131 return git_footers.parse_footers(self.FullDescriptionText())
1132
Aaron Gablefc03e672017-05-15 14:09:42 -07001133 def BugsFromDescription(self):
1134 """Returns all bugs referenced in the commit description."""
Aaron Gable12ef5012017-05-15 14:29:00 -07001135 tags = [b.strip() for b in self.tags.get('BUG', '').split(',') if b.strip()]
Caleb Rouleauc0546b92019-02-22 06:12:57 +00001136 footers = []
Edward Lemur69bb8be2020-02-03 20:37:38 +00001137 parsed = self.GitFootersFromDescription()
Dan Beam62954042019-10-03 21:20:33 +00001138 unsplit_footers = parsed.get('Bug', []) + parsed.get('Fixed', [])
Caleb Rouleauc0546b92019-02-22 06:12:57 +00001139 for unsplit_footer in unsplit_footers:
1140 footers += [b.strip() for b in unsplit_footer.split(',')]
Aaron Gable12ef5012017-05-15 14:29:00 -07001141 return sorted(set(tags + footers))
Aaron Gablefc03e672017-05-15 14:09:42 -07001142
1143 def ReviewersFromDescription(self):
1144 """Returns all reviewers listed in the commit description."""
Edward Lemura5799e32020-01-17 19:26:51 +00001145 # We don't support a 'R:' git-footer for reviewers; that is in metadata.
Aaron Gable12ef5012017-05-15 14:29:00 -07001146 tags = [r.strip() for r in self.tags.get('R', '').split(',') if r.strip()]
1147 return sorted(set(tags))
Aaron Gablefc03e672017-05-15 14:09:42 -07001148
1149 def TBRsFromDescription(self):
1150 """Returns all TBR reviewers listed in the commit description."""
Aaron Gable12ef5012017-05-15 14:29:00 -07001151 tags = [r.strip() for r in self.tags.get('TBR', '').split(',') if r.strip()]
Aaron Gable6e7ddb62020-05-27 22:23:29 +00001152 # TODO(crbug.com/839208): Remove support for 'Tbr:' when TBRs are
1153 # programmatically determined by self-CR+1s.
Edward Lemur69bb8be2020-02-03 20:37:38 +00001154 footers = self.GitFootersFromDescription().get('Tbr', [])
Aaron Gable12ef5012017-05-15 14:29:00 -07001155 return sorted(set(tags + footers))
Aaron Gablefc03e672017-05-15 14:09:42 -07001156
Aaron Gable6e7ddb62020-05-27 22:23:29 +00001157 # TODO(crbug.com/753425): Delete these once we're sure they're unused.
Aaron Gablefc03e672017-05-15 14:09:42 -07001158 @property
1159 def BUG(self):
1160 return ','.join(self.BugsFromDescription())
1161 @property
1162 def R(self):
1163 return ','.join(self.ReviewersFromDescription())
1164 @property
1165 def TBR(self):
1166 return ','.join(self.TBRsFromDescription())
1167
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001168 def AllFiles(self, root=None):
1169 """List all files under source control in the repo."""
1170 raise NotImplementedError()
1171
agable0b65e732016-11-22 09:25:46 -08001172 def AffectedFiles(self, include_deletes=True, file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001173 """Returns a list of AffectedFile instances for all files in the change.
1174
1175 Args:
1176 include_deletes: If false, deleted files will be filtered out.
sail@chromium.org5538e022011-05-12 17:53:16 +00001177 file_filter: An additional filter to apply.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001178
1179 Returns:
1180 [AffectedFile(path, action), AffectedFile(path, action)]
1181 """
Edward Lemurb9830242019-10-30 22:19:20 +00001182 affected = list(filter(file_filter, self._affected_files))
sail@chromium.org5538e022011-05-12 17:53:16 +00001183
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001184 if include_deletes:
1185 return affected
Edward Lemurb9830242019-10-30 22:19:20 +00001186 return list(filter(lambda x: x.Action() != 'D', affected))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001187
John Budorick16162372018-04-18 10:39:53 -07001188 def AffectedTestableFiles(self, include_deletes=None, **kwargs):
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +00001189 """Return a list of the existing text files in a change."""
1190 if include_deletes is not None:
Edward Lemura5799e32020-01-17 19:26:51 +00001191 warn('AffectedTeestableFiles(include_deletes=%s)'
1192 ' is deprecated and ignored' % str(include_deletes),
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +00001193 category=DeprecationWarning,
1194 stacklevel=2)
Edward Lemurb9830242019-10-30 22:19:20 +00001195 return list(filter(
1196 lambda x: x.IsTestableFile(),
1197 self.AffectedFiles(include_deletes=False, **kwargs)))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001198
agable0b65e732016-11-22 09:25:46 -08001199 def AffectedTextFiles(self, include_deletes=None):
1200 """An alias to AffectedTestableFiles for backwards compatibility."""
1201 return self.AffectedTestableFiles(include_deletes=include_deletes)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001202
agable0b65e732016-11-22 09:25:46 -08001203 def LocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001204 """Convenience function."""
agable0b65e732016-11-22 09:25:46 -08001205 return [af.LocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001206
agable0b65e732016-11-22 09:25:46 -08001207 def AbsoluteLocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001208 """Convenience function."""
agable0b65e732016-11-22 09:25:46 -08001209 return [af.AbsoluteLocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001210
1211 def RightHandSideLines(self):
Edward Lemura5799e32020-01-17 19:26:51 +00001212 """An iterator over all text lines in 'new' version of changed files.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001213
1214 Lists lines from new or modified text files in the change.
1215
1216 This is useful for doing line-by-line regex checks, like checking for
1217 trailing whitespace.
1218
1219 Yields:
1220 a 3 tuple:
1221 the AffectedFile instance of the current file;
1222 integer line number (1-based); and
1223 the contents of the line as a string.
1224 """
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +00001225 return _RightHandSideLinesImpl(
1226 x for x in self.AffectedFiles(include_deletes=False)
agable0b65e732016-11-22 09:25:46 -08001227 if x.IsTestableFile())
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001228
Jochen Eisingerd0573ec2017-04-13 10:55:06 +02001229 def OriginalOwnersFiles(self):
1230 """A map from path names of affected OWNERS files to their old content."""
1231 def owners_file_filter(f):
1232 return 'OWNERS' in os.path.split(f.LocalPath())[1]
1233 files = self.AffectedFiles(file_filter=owners_file_filter)
1234 return dict([(f.LocalPath(), f.OldContents()) for f in files])
1235
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001236
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001237class GitChange(Change):
1238 _AFFECTED_FILES = GitAffectedFile
maruel@chromium.orgc1938752011-04-12 23:11:13 +00001239 scm = 'git'
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +00001240
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001241 def AllFiles(self, root=None):
1242 """List all files under source control in the repo."""
1243 root = root or self.RepositoryRoot()
1244 return subprocess.check_output(
Aaron Gable7817f022017-12-12 09:43:17 -08001245 ['git', '-c', 'core.quotePath=false', 'ls-files', '--', '.'],
1246 cwd=root).splitlines()
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001247
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001248
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001249def ListRelevantPresubmitFiles(files, root):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001250 """Finds all presubmit files that apply to a given set of source files.
1251
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001252 If inherit-review-settings-ok is present right under root, looks for
1253 PRESUBMIT.py in directories enclosing root.
1254
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001255 Args:
1256 files: An iterable container containing file paths.
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001257 root: Path where to stop searching.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001258
1259 Return:
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001260 List of absolute paths of the existing PRESUBMIT.py scripts.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001261 """
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001262 files = [normpath(os.path.join(root, f)) for f in files]
1263
1264 # List all the individual directories containing files.
1265 directories = set([os.path.dirname(f) for f in files])
1266
1267 # Ignore root if inherit-review-settings-ok is present.
1268 if os.path.isfile(os.path.join(root, 'inherit-review-settings-ok')):
1269 root = None
1270
1271 # Collect all unique directories that may contain PRESUBMIT.py.
1272 candidates = set()
1273 for directory in directories:
1274 while True:
1275 if directory in candidates:
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001276 break
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001277 candidates.add(directory)
1278 if directory == root:
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001279 break
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001280 parent_dir = os.path.dirname(directory)
1281 if parent_dir == directory:
1282 # We hit the system root directory.
1283 break
1284 directory = parent_dir
1285
1286 # Look for PRESUBMIT.py in all candidate directories.
1287 results = []
1288 for directory in sorted(list(candidates)):
tobiasjsff061c02016-08-17 03:23:57 -07001289 try:
1290 for f in os.listdir(directory):
1291 p = os.path.join(directory, f)
1292 if os.path.isfile(p) and re.match(
1293 r'PRESUBMIT.*\.py$', f) and not f.startswith('PRESUBMIT_test'):
1294 results.append(p)
1295 except OSError:
1296 pass
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001297
tobiasjs2836bcf2016-08-16 04:08:16 -07001298 logging.debug('Presubmit files: %s', ','.join(results))
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001299 return results
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001300
1301
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001302class GetTryMastersExecuter(object):
1303 @staticmethod
1304 def ExecPresubmitScript(script_text, presubmit_path, project, change):
1305 """Executes GetPreferredTryMasters() from a single presubmit script.
1306
1307 Args:
1308 script_text: The text of the presubmit script.
1309 presubmit_path: Project script to run.
1310 project: Project name to pass to presubmit script for bot selection.
1311
1312 Return:
1313 A map of try masters to map of builders to set of tests.
1314 """
1315 context = {}
1316 try:
Raul Tambre09e64b42019-05-14 01:57:22 +00001317 exec(compile(script_text, 'PRESUBMIT.py', 'exec', dont_inherit=True),
1318 context)
Raul Tambre7c938462019-05-24 16:35:35 +00001319 except Exception as e:
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001320 raise PresubmitFailure('"%s" had an exception.\n%s'
1321 % (presubmit_path, e))
1322
1323 function_name = 'GetPreferredTryMasters'
1324 if function_name not in context:
1325 return {}
1326 get_preferred_try_masters = context[function_name]
1327 if not len(inspect.getargspec(get_preferred_try_masters)[0]) == 2:
1328 raise PresubmitFailure(
1329 'Expected function "GetPreferredTryMasters" to take two arguments.')
1330 return get_preferred_try_masters(project, change)
1331
1332
rmistry@google.com5626a922015-02-26 14:03:30 +00001333class GetPostUploadExecuter(object):
1334 @staticmethod
Edward Lemur016a0872020-02-04 22:13:28 +00001335 def ExecPresubmitScript(script_text, presubmit_path, gerrit_obj, change):
rmistry@google.com5626a922015-02-26 14:03:30 +00001336 """Executes PostUploadHook() from a single presubmit script.
1337
1338 Args:
1339 script_text: The text of the presubmit script.
1340 presubmit_path: Project script to run.
Edward Lemur016a0872020-02-04 22:13:28 +00001341 gerrit_obj: The GerritAccessor object.
rmistry@google.com5626a922015-02-26 14:03:30 +00001342 change: The Change object.
1343
1344 Return:
1345 A list of results objects.
1346 """
1347 context = {}
1348 try:
Raul Tambre09e64b42019-05-14 01:57:22 +00001349 exec(compile(script_text, 'PRESUBMIT.py', 'exec', dont_inherit=True),
1350 context)
Raul Tambre7c938462019-05-24 16:35:35 +00001351 except Exception as e:
rmistry@google.com5626a922015-02-26 14:03:30 +00001352 raise PresubmitFailure('"%s" had an exception.\n%s'
1353 % (presubmit_path, e))
1354
1355 function_name = 'PostUploadHook'
1356 if function_name not in context:
1357 return {}
1358 post_upload_hook = context[function_name]
1359 if not len(inspect.getargspec(post_upload_hook)[0]) == 3:
1360 raise PresubmitFailure(
1361 'Expected function "PostUploadHook" to take three arguments.')
Edward Lemur016a0872020-02-04 22:13:28 +00001362 return post_upload_hook(gerrit_obj, change, OutputApi(False))
rmistry@google.com5626a922015-02-26 14:03:30 +00001363
1364
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001365def _MergeMasters(masters1, masters2):
1366 """Merges two master maps. Merges also the tests of each builder."""
1367 result = {}
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001368 for (master, builders) in itertools.chain(masters1.items(),
1369 masters2.items()):
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001370 new_builders = result.setdefault(master, {})
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001371 for (builder, tests) in builders.items():
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001372 new_builders.setdefault(builder, set([])).update(tests)
1373 return result
1374
1375
1376def DoGetTryMasters(change,
1377 changed_files,
1378 repository_root,
1379 default_presubmit,
1380 project,
1381 verbose,
1382 output_stream):
1383 """Get the list of try masters from the presubmit scripts.
1384
1385 Args:
1386 changed_files: List of modified files.
1387 repository_root: The repository root.
1388 default_presubmit: A default presubmit script to execute in any case.
1389 project: Optional name of a project used in selecting trybots.
1390 verbose: Prints debug info.
1391 output_stream: A stream to write debug output to.
1392
1393 Return:
1394 Map of try masters to map of builders to set of tests.
1395 """
1396 presubmit_files = ListRelevantPresubmitFiles(changed_files, repository_root)
1397 if not presubmit_files and verbose:
Edward Lemura5799e32020-01-17 19:26:51 +00001398 output_stream.write('Warning, no PRESUBMIT.py found.\n')
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001399 results = {}
1400 executer = GetTryMastersExecuter()
1401
1402 if default_presubmit:
1403 if verbose:
Edward Lemura5799e32020-01-17 19:26:51 +00001404 output_stream.write('Running default presubmit script.\n')
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001405 fake_path = os.path.join(repository_root, 'PRESUBMIT.py')
1406 results = _MergeMasters(results, executer.ExecPresubmitScript(
1407 default_presubmit, fake_path, project, change))
1408 for filename in presubmit_files:
1409 filename = os.path.abspath(filename)
1410 if verbose:
Edward Lemura5799e32020-01-17 19:26:51 +00001411 output_stream.write('Running %s\n' % filename)
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001412 # Accept CRLF presubmit script.
1413 presubmit_script = gclient_utils.FileRead(filename, 'rU')
1414 results = _MergeMasters(results, executer.ExecPresubmitScript(
1415 presubmit_script, filename, project, change))
1416
1417 # Make sets to lists again for later JSON serialization.
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001418 for builders in results.values():
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001419 for builder in builders:
1420 builders[builder] = list(builders[builder])
1421
1422 if results and verbose:
1423 output_stream.write('%s\n' % str(results))
1424 return results
1425
1426
rmistry@google.com5626a922015-02-26 14:03:30 +00001427def DoPostUploadExecuter(change,
Edward Lemur016a0872020-02-04 22:13:28 +00001428 gerrit_obj,
Edward Lemur6eb1d322020-02-27 22:20:15 +00001429 verbose):
rmistry@google.com5626a922015-02-26 14:03:30 +00001430 """Execute the post upload hook.
1431
1432 Args:
1433 change: The Change object.
Edward Lemur016a0872020-02-04 22:13:28 +00001434 gerrit_obj: The GerritAccessor object.
rmistry@google.com5626a922015-02-26 14:03:30 +00001435 verbose: Prints debug info.
rmistry@google.com5626a922015-02-26 14:03:30 +00001436 """
1437 presubmit_files = ListRelevantPresubmitFiles(
Edward Lemur6eb1d322020-02-27 22:20:15 +00001438 change.LocalPaths(), change.RepositoryRoot())
rmistry@google.com5626a922015-02-26 14:03:30 +00001439 if not presubmit_files and verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001440 sys.stdout.write('Warning, no PRESUBMIT.py found.\n')
rmistry@google.com5626a922015-02-26 14:03:30 +00001441 results = []
1442 executer = GetPostUploadExecuter()
1443 # The root presubmit file should be executed after the ones in subdirectories.
1444 # i.e. the specific post upload hooks should run before the general ones.
1445 # Thus, reverse the order provided by ListRelevantPresubmitFiles.
1446 presubmit_files.reverse()
1447
1448 for filename in presubmit_files:
1449 filename = os.path.abspath(filename)
1450 if verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001451 sys.stdout.write('Running %s\n' % filename)
rmistry@google.com5626a922015-02-26 14:03:30 +00001452 # Accept CRLF presubmit script.
1453 presubmit_script = gclient_utils.FileRead(filename, 'rU')
1454 results.extend(executer.ExecPresubmitScript(
Edward Lemur016a0872020-02-04 22:13:28 +00001455 presubmit_script, filename, gerrit_obj, change))
rmistry@google.com5626a922015-02-26 14:03:30 +00001456
Edward Lemur6eb1d322020-02-27 22:20:15 +00001457 if not results:
1458 return 0
1459
1460 sys.stdout.write('\n')
1461 sys.stdout.write('** Post Upload Hook Messages **\n')
1462
1463 exit_code = 0
1464 for result in results:
1465 if result.fatal:
1466 exit_code = 1
1467 result.handle()
1468 sys.stdout.write('\n')
1469
1470 return exit_code
rmistry@google.com5626a922015-02-26 14:03:30 +00001471
1472
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001473class PresubmitExecuter(object):
Aaron Gable668c1d82018-04-03 10:19:16 -07001474 def __init__(self, change, committing, verbose,
Edward Lesmes8e282792018-04-03 18:50:29 -04001475 gerrit_obj, dry_run=None, thread_pool=None, parallel=False):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001476 """
1477 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001478 change: The Change object.
agable92bec4f2016-08-24 09:27:27 -07001479 committing: True if 'git cl land' is running, False if 'git cl upload' is.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001480 gerrit_obj: provides basic Gerrit codereview functionality.
1481 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -04001482 parallel: if true, all tests reported via input_api.RunTests for all
1483 PRESUBMIT files will be run in parallel.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001484 """
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001485 self.change = change
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001486 self.committing = committing
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001487 self.gerrit = gerrit_obj
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001488 self.verbose = verbose
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001489 self.dry_run = dry_run
Daniel Cheng7227d212017-11-17 08:12:37 -08001490 self.more_cc = []
Edward Lesmes8e282792018-04-03 18:50:29 -04001491 self.thread_pool = thread_pool
1492 self.parallel = parallel
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001493
1494 def ExecPresubmitScript(self, script_text, presubmit_path):
1495 """Executes a single presubmit script.
1496
1497 Args:
1498 script_text: The text of the presubmit script.
1499 presubmit_path: The path to the presubmit file (this will be reported via
1500 input_api.PresubmitLocalPath()).
1501
1502 Return:
1503 A list of result objects, empty if no problems.
1504 """
thakis@chromium.orgc6ef53a2014-11-04 00:13:54 +00001505
chase@chromium.org8e416c82009-10-06 04:30:44 +00001506 # Change to the presubmit file's directory to support local imports.
1507 main_path = os.getcwd()
1508 os.chdir(os.path.dirname(presubmit_path))
1509
1510 # Load the presubmit script into context.
dpranke@chromium.org970c5222011-03-12 00:32:24 +00001511 input_api = InputApi(self.change, presubmit_path, self.committing,
Aaron Gable668c1d82018-04-03 10:19:16 -07001512 self.verbose, gerrit_obj=self.gerrit,
Edward Lesmes8e282792018-04-03 18:50:29 -04001513 dry_run=self.dry_run, thread_pool=self.thread_pool,
1514 parallel=self.parallel)
Daniel Cheng7227d212017-11-17 08:12:37 -08001515 output_api = OutputApi(self.committing)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001516 context = {}
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001517 try:
Raul Tambre09e64b42019-05-14 01:57:22 +00001518 exec(compile(script_text, 'PRESUBMIT.py', 'exec', dont_inherit=True),
1519 context)
Raul Tambre7c938462019-05-24 16:35:35 +00001520 except Exception as e:
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001521 raise PresubmitFailure('"%s" had an exception.\n%s' % (presubmit_path, e))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001522
1523 # These function names must change if we make substantial changes to
1524 # the presubmit API that are not backwards compatible.
1525 if self.committing:
1526 function_name = 'CheckChangeOnCommit'
1527 else:
1528 function_name = 'CheckChangeOnUpload'
1529 if function_name in context:
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +01001530 try:
Daniel Cheng7227d212017-11-17 08:12:37 -08001531 context['__args'] = (input_api, output_api)
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +01001532 logging.debug('Running %s in %s', function_name, presubmit_path)
1533 result = eval(function_name + '(*__args)', context)
1534 logging.debug('Running %s done.', function_name)
Daniel Chengd36fce42017-11-21 21:52:52 -08001535 self.more_cc.extend(output_api.more_cc)
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +01001536 finally:
Edward Lemurb9830242019-10-30 22:19:20 +00001537 for f in input_api._named_temporary_files:
1538 os.remove(f)
1539 if not isinstance(result, (tuple, list)):
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001540 raise PresubmitFailure(
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001541 'Presubmit functions must return a tuple or list')
1542 for item in result:
1543 if not isinstance(item, OutputApi.PresubmitResult):
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001544 raise PresubmitFailure(
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001545 'All presubmit results must be of types derived from '
1546 'output_api.PresubmitResult')
1547 else:
1548 result = () # no error since the script doesn't care about current event.
1549
chase@chromium.org8e416c82009-10-06 04:30:44 +00001550 # Return the process to the original working directory.
1551 os.chdir(main_path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001552 return result
1553
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001554def DoPresubmitChecks(change,
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001555 committing,
1556 verbose,
maruel@chromium.orgb0dfd352009-06-10 14:12:54 +00001557 default_presubmit,
dpranke@chromium.org970c5222011-03-12 00:32:24 +00001558 may_prompt,
Aaron Gable668c1d82018-04-03 10:19:16 -07001559 gerrit_obj,
Edward Lesmes8e282792018-04-03 18:50:29 -04001560 dry_run=None,
Debrian Figueroadd2737e2019-06-21 23:50:13 +00001561 parallel=False,
1562 json_output=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001563 """Runs all presubmit checks that apply to the files in the change.
1564
1565 This finds all PRESUBMIT.py files in directories enclosing the files in the
1566 change (up to the repository root) and calls the relevant entrypoint function
1567 depending on whether the change is being committed or uploaded.
1568
1569 Prints errors, warnings and notifications. Prompts the user for warnings
1570 when needed.
1571
1572 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001573 change: The Change object.
agable92bec4f2016-08-24 09:27:27 -07001574 committing: True if 'git cl land' is running, False if 'git cl upload' is.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001575 verbose: Prints debug info.
maruel@chromium.org0ff1fab2009-05-22 13:08:15 +00001576 default_presubmit: A default presubmit script to execute in any case.
Quinten Yearsley516fe7f2016-12-14 11:50:18 -08001577 may_prompt: Enable (y/n) questions on warning or error. If False,
1578 any questions are answered with yes by default.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001579 gerrit_obj: provides basic Gerrit codereview functionality.
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001580 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -04001581 parallel: if true, all tests specified by input_api.RunTests in all
1582 PRESUBMIT files will be run in parallel.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001583
1584 Return:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001585 1 if presubmit checks failed or 0 otherwise.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001586 """
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001587 old_environ = os.environ
1588 try:
1589 # Make sure python subprocesses won't generate .pyc files.
1590 os.environ = os.environ.copy()
Edward Lemurb9830242019-10-30 22:19:20 +00001591 os.environ['PYTHONDONTWRITEBYTECODE'] = '1'
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001592
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001593 if committing:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001594 sys.stdout.write('Running presubmit commit checks ...\n')
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001595 else:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001596 sys.stdout.write('Running presubmit upload checks ...\n')
Edward Lemurecc27072020-01-06 16:42:34 +00001597 start_time = time_time()
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001598 presubmit_files = ListRelevantPresubmitFiles(
agable0b65e732016-11-22 09:25:46 -08001599 change.AbsoluteLocalPaths(), change.RepositoryRoot())
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001600 if not presubmit_files and verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001601 sys.stdout.write('Warning, no PRESUBMIT.py found.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001602 results = []
Edward Lesmes8e282792018-04-03 18:50:29 -04001603 thread_pool = ThreadPool()
Edward Lemur7e3c67f2018-07-20 20:52:49 +00001604 executer = PresubmitExecuter(change, committing, verbose, gerrit_obj,
1605 dry_run, thread_pool, parallel)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001606 if default_presubmit:
1607 if verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001608 sys.stdout.write('Running default presubmit script.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001609 fake_path = os.path.join(change.RepositoryRoot(), 'PRESUBMIT.py')
1610 results += executer.ExecPresubmitScript(default_presubmit, fake_path)
1611 for filename in presubmit_files:
1612 filename = os.path.abspath(filename)
1613 if verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001614 sys.stdout.write('Running %s\n' % filename)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001615 # Accept CRLF presubmit script.
1616 presubmit_script = gclient_utils.FileRead(filename, 'rU')
1617 results += executer.ExecPresubmitScript(presubmit_script, filename)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001618
Edward Lesmes8e282792018-04-03 18:50:29 -04001619 results += thread_pool.RunAsync()
1620
Edward Lemur6eb1d322020-02-27 22:20:15 +00001621 messages = {}
1622 should_prompt = False
1623 presubmits_failed = False
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001624 for result in results:
1625 if result.fatal:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001626 presubmits_failed = True
1627 messages.setdefault('ERRORS', []).append(result)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001628 elif result.should_prompt:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001629 should_prompt = True
1630 messages.setdefault('Warnings', []).append(result)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001631 else:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001632 messages.setdefault('Messages', []).append(result)
pam@chromium.orged9a0832009-09-09 22:48:55 +00001633
Edward Lemur6eb1d322020-02-27 22:20:15 +00001634 sys.stdout.write('\n')
1635 for name, items in messages.items():
1636 sys.stdout.write('** Presubmit %s **\n' % name)
1637 for item in items:
1638 item.handle()
1639 sys.stdout.write('\n')
pam@chromium.orged9a0832009-09-09 22:48:55 +00001640
Edward Lemurecc27072020-01-06 16:42:34 +00001641 total_time = time_time() - start_time
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001642 if total_time > 1.0:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001643 sys.stdout.write(
1644 'Presubmit checks took %.1fs to calculate.\n\n' % total_time)
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +00001645
Edward Lemur6eb1d322020-02-27 22:20:15 +00001646 if not should_prompt and not presubmits_failed:
1647 sys.stdout.write('Presubmit checks passed.\n')
1648 elif should_prompt:
1649 sys.stdout.write('There were presubmit warnings. ')
Quinten Yearsley516fe7f2016-12-14 11:50:18 -08001650 if may_prompt:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001651 presubmits_failed = not prompt_should_continue(
1652 'Are you sure you wish to continue? (y/N): ')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001653
Edward Lemur1dc66e12020-02-21 21:36:34 +00001654 if json_output:
1655 # Write the presubmit results to json output
1656 presubmit_results = {
1657 'errors': [
Edward Lemur6eb1d322020-02-27 22:20:15 +00001658 error.json_format()
1659 for error in messages.get('ERRORS', [])
Edward Lemur1dc66e12020-02-21 21:36:34 +00001660 ],
1661 'notifications': [
Edward Lemur6eb1d322020-02-27 22:20:15 +00001662 notification.json_format()
1663 for notification in messages.get('Messages', [])
Edward Lemur1dc66e12020-02-21 21:36:34 +00001664 ],
1665 'warnings': [
Edward Lemur6eb1d322020-02-27 22:20:15 +00001666 warning.json_format()
1667 for warning in messages.get('Warnings', [])
Edward Lemur1dc66e12020-02-21 21:36:34 +00001668 ],
Edward Lemur6eb1d322020-02-27 22:20:15 +00001669 'more_cc': executer.more_cc,
Edward Lemur1dc66e12020-02-21 21:36:34 +00001670 }
1671
1672 gclient_utils.FileWrite(
1673 json_output, json.dumps(presubmit_results, sort_keys=True))
1674
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001675 global _ASKED_FOR_FEEDBACK
1676 # Ask for feedback one time out of 5.
1677 if (len(results) and random.randint(0, 4) == 0 and not _ASKED_FOR_FEEDBACK):
Edward Lemur6eb1d322020-02-27 22:20:15 +00001678 sys.stdout.write(
maruel@chromium.org1ce8e662014-01-14 15:23:00 +00001679 'Was the presubmit check useful? If not, run "git cl presubmit -v"\n'
1680 'to figure out which PRESUBMIT.py was run, then run git blame\n'
1681 'on the file to figure out who to ask for help.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001682 _ASKED_FOR_FEEDBACK = True
Edward Lemur6eb1d322020-02-27 22:20:15 +00001683
1684 return 1 if presubmits_failed else 0
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001685 finally:
1686 os.environ = old_environ
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001687
1688
Edward Lemur50984a62020-02-06 18:10:18 +00001689def _scan_sub_dirs(mask, recursive):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001690 if not recursive:
pgervais@chromium.orge57b09d2014-05-07 00:58:13 +00001691 return [x for x in glob.glob(mask) if x not in ('.svn', '.git')]
Lei Zhang9611c4c2017-04-04 01:41:56 -07001692
1693 results = []
1694 for root, dirs, files in os.walk('.'):
1695 if '.svn' in dirs:
1696 dirs.remove('.svn')
1697 if '.git' in dirs:
1698 dirs.remove('.git')
1699 for name in files:
1700 if fnmatch.fnmatch(name, mask):
1701 results.append(os.path.join(root, name))
1702 return results
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001703
1704
Edward Lemur50984a62020-02-06 18:10:18 +00001705def _parse_files(args, recursive):
tobiasjs2836bcf2016-08-16 04:08:16 -07001706 logging.debug('Searching for %s', args)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001707 files = []
1708 for arg in args:
Edward Lemur50984a62020-02-06 18:10:18 +00001709 files.extend([('M', f) for f in _scan_sub_dirs(arg, recursive)])
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001710 return files
1711
1712
Edward Lemur50984a62020-02-06 18:10:18 +00001713def _parse_change(parser, options):
1714 """Process change options.
1715
1716 Args:
1717 parser: The parser used to parse the arguments from command line.
1718 options: The arguments parsed from command line.
1719 Returns:
1720 A GitChange if the change root is a git repository, or a Change otherwise.
1721 """
1722 if options.files and options.all_files:
1723 parser.error('<files> cannot be specified when --all-files is set.')
1724
Edward Lesmes44ea3ff2020-02-05 00:14:30 +00001725 change_scm = scm.determine_scm(options.root)
Edward Lemur50984a62020-02-06 18:10:18 +00001726 if change_scm != 'git' and not options.files:
1727 parser.error('<files> is not optional for unversioned directories.')
1728
1729 if options.files:
1730 change_files = _parse_files(options.files, options.recursive)
1731 elif options.all_files:
1732 change_files = [('M', f) for f in scm.GIT.GetAllFiles(options.root)]
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001733 else:
Edward Lemur50984a62020-02-06 18:10:18 +00001734 change_files = scm.GIT.CaptureStatus(
Edward Lemur7f6dec02020-02-06 20:23:58 +00001735 options.root, options.upstream or None)
Edward Lemur50984a62020-02-06 18:10:18 +00001736
1737 logging.info('Found %d file(s).', len(change_files))
1738
1739 change_class = GitChange if change_scm == 'git' else Change
1740 return change_class(
1741 options.name,
1742 options.description,
1743 options.root,
1744 change_files,
1745 options.issue,
1746 options.patchset,
1747 options.author,
1748 upstream=options.upstream)
1749
1750
1751def _parse_gerrit_options(parser, options):
1752 """Process gerrit options.
1753
1754 SIDE EFFECTS: Modifies options.author and options.description from Gerrit if
1755 options.gerrit_fetch is set.
1756
1757 Args:
1758 parser: The parser used to parse the arguments from command line.
1759 options: The arguments parsed from command line.
1760 Returns:
1761 A GerritAccessor object if options.gerrit_url is set, or None otherwise.
1762 """
1763 gerrit_obj = None
1764 if options.gerrit_url:
1765 gerrit_obj = GerritAccessor(urlparse.urlparse(options.gerrit_url).netloc)
1766
1767 if not options.gerrit_fetch:
1768 return gerrit_obj
1769
1770 if not options.gerrit_url or not options.issue or not options.patchset:
1771 parser.error(
1772 '--gerrit_fetch requires --gerrit_url, --issue and --patchset.')
1773
1774 options.author = gerrit_obj.GetChangeOwner(options.issue)
1775 options.description = gerrit_obj.GetChangeDescription(
1776 options.issue, options.patchset)
1777
1778 logging.info('Got author: "%s"', options.author)
1779 logging.info('Got description: """\n%s\n"""', options.description)
1780
1781 return gerrit_obj
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001782
1783
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001784@contextlib.contextmanager
1785def canned_check_filter(method_names):
1786 filtered = {}
1787 try:
1788 for method_name in method_names:
1789 if not hasattr(presubmit_canned_checks, method_name):
Aaron Gableecee74c2018-04-02 15:13:08 -07001790 logging.warn('Skipping unknown "canned" check %s' % method_name)
1791 continue
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001792 filtered[method_name] = getattr(presubmit_canned_checks, method_name)
1793 setattr(presubmit_canned_checks, method_name, lambda *_a, **_kw: [])
1794 yield
1795 finally:
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001796 for name, method in filtered.items():
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001797 setattr(presubmit_canned_checks, name, method)
1798
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +00001799
sbc@chromium.org013731e2015-02-26 18:28:43 +00001800def main(argv=None):
Edward Lemura5799e32020-01-17 19:26:51 +00001801 parser = argparse.ArgumentParser(usage='%(prog)s [options] <files...>')
1802 hooks = parser.add_mutually_exclusive_group()
1803 hooks.add_argument('-c', '--commit', action='store_true',
1804 help='Use commit instead of upload checks.')
1805 hooks.add_argument('-u', '--upload', action='store_false', dest='commit',
1806 help='Use upload instead of commit checks.')
Edward Lemur75526302020-02-27 22:31:05 +00001807 hooks.add_argument('--post_upload', action='store_true',
1808 help='Run post-upload commit hooks.')
Edward Lemura5799e32020-01-17 19:26:51 +00001809 parser.add_argument('-r', '--recursive', action='store_true',
1810 help='Act recursively.')
1811 parser.add_argument('-v', '--verbose', action='count', default=0,
1812 help='Use 2 times for more debug info.')
1813 parser.add_argument('--name', default='no name')
1814 parser.add_argument('--author')
Edward Lemur227d5102020-02-25 23:45:35 +00001815 desc = parser.add_mutually_exclusive_group()
1816 desc.add_argument('--description', default='', help='The change description.')
1817 desc.add_argument('--description_file',
1818 help='File to read change description from.')
Edward Lemura5799e32020-01-17 19:26:51 +00001819 parser.add_argument('--issue', type=int, default=0)
1820 parser.add_argument('--patchset', type=int, default=0)
1821 parser.add_argument('--root', default=os.getcwd(),
1822 help='Search for PRESUBMIT.py up to this directory. '
1823 'If inherit-review-settings-ok is present in this '
1824 'directory, parent directories up to the root file '
1825 'system directories will also be searched.')
1826 parser.add_argument('--upstream',
1827 help='Git only: the base ref or upstream branch against '
1828 'which the diff should be computed.')
1829 parser.add_argument('--default_presubmit')
1830 parser.add_argument('--may_prompt', action='store_true', default=False)
1831 parser.add_argument('--skip_canned', action='append', default=[],
1832 help='A list of checks to skip which appear in '
1833 'presubmit_canned_checks. Can be provided multiple times '
1834 'to skip multiple canned checks.')
1835 parser.add_argument('--dry_run', action='store_true', help=argparse.SUPPRESS)
1836 parser.add_argument('--gerrit_url', help=argparse.SUPPRESS)
1837 parser.add_argument('--gerrit_fetch', action='store_true',
1838 help=argparse.SUPPRESS)
1839 parser.add_argument('--parallel', action='store_true',
1840 help='Run all tests specified by input_api.RunTests in '
1841 'all PRESUBMIT files in parallel.')
1842 parser.add_argument('--json_output',
1843 help='Write presubmit errors to json output.')
Edward Lemur1dc66e12020-02-21 21:36:34 +00001844 parser.add_argument('--all_files', action='store_true',
Edward Lemur50984a62020-02-06 18:10:18 +00001845 help='Mark all files under source control as modified.')
Edward Lemura5799e32020-01-17 19:26:51 +00001846 parser.add_argument('files', nargs='*',
1847 help='List of files to be marked as modified when '
1848 'executing presubmit or post-upload hooks. fnmatch '
1849 'wildcards can also be used.')
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001850
Edward Lemura5799e32020-01-17 19:26:51 +00001851 options = parser.parse_args(argv)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001852
Erik Staabcca5c492020-04-16 17:40:07 +00001853 log_level = logging.ERROR
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001854 if options.verbose >= 2:
Erik Staabcca5c492020-04-16 17:40:07 +00001855 log_level = logging.DEBUG
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001856 elif options.verbose:
Erik Staabcca5c492020-04-16 17:40:07 +00001857 log_level = logging.INFO
1858 log_format = ('[%(levelname).1s%(asctime)s %(process)d %(thread)d '
1859 '%(filename)s] %(message)s')
1860 logging.basicConfig(format=log_format, level=log_level)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001861
Edward Lemur227d5102020-02-25 23:45:35 +00001862 if options.description_file:
1863 options.description = gclient_utils.FileRead(options.description_file)
Edward Lemur50984a62020-02-06 18:10:18 +00001864 gerrit_obj = _parse_gerrit_options(parser, options)
1865 change = _parse_change(parser, options)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001866
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001867 try:
Edward Lemur75526302020-02-27 22:31:05 +00001868 if options.post_upload:
1869 return DoPostUploadExecuter(
1870 change,
1871 gerrit_obj,
1872 options.verbose)
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001873 with canned_check_filter(options.skip_canned):
Edward Lemur6eb1d322020-02-27 22:20:15 +00001874 return DoPresubmitChecks(
Edward Lemur50984a62020-02-06 18:10:18 +00001875 change,
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001876 options.commit,
1877 options.verbose,
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001878 options.default_presubmit,
1879 options.may_prompt,
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001880 gerrit_obj,
Edward Lesmes8e282792018-04-03 18:50:29 -04001881 options.dry_run,
Debrian Figueroadd2737e2019-06-21 23:50:13 +00001882 options.parallel,
1883 options.json_output)
Raul Tambre7c938462019-05-24 16:35:35 +00001884 except PresubmitFailure as e:
Raul Tambre80ee78e2019-05-06 22:41:05 +00001885 print(e, file=sys.stderr)
1886 print('Maybe your depot_tools is out of date?', file=sys.stderr)
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001887 return 2
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001888
1889
1890if __name__ == '__main__':
maruel@chromium.org35625c72011-03-23 17:34:02 +00001891 fix_encoding.fix_encoding()
sbc@chromium.org013731e2015-02-26 18:28:43 +00001892 try:
1893 sys.exit(main())
1894 except KeyboardInterrupt:
1895 sys.stderr.write('interrupted\n')
sergiybf8a3b382016-07-05 11:21:30 -07001896 sys.exit(2)