blob: a31dbab354c7582226ec7f35e4d9a6b5f4bcd06a [file] [log] [blame]
maruel@chromium.org725f1c32011-04-01 20:24:54 +00001#!/usr/bin/env python
maruel@chromium.org3bbf2942012-01-10 16:52:06 +00002# Copyright (c) 2012 The Chromium Authors. All rights reserved.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00003# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5
6"""Enables directory-specific presubmit checks to run at upload and/or commit.
7"""
8
Raul Tambre80ee78e2019-05-06 22:41:05 +00009from __future__ import print_function
10
stip@chromium.orgf7d31f52014-01-03 20:14:46 +000011__version__ = '1.8.0'
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000012
13# TODO(joi) Add caching where appropriate/needed. The API is designed to allow
14# caching (between all different invocations of presubmit scripts for a given
15# change). We should add it as our presubmit scripts start feeling slow.
16
Edward Lemura5799e32020-01-17 19:26:51 +000017import argparse
Takeshi Yoshino07a6bea2017-08-02 02:44:06 +090018import ast # Exposed through the API.
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +000019import contextlib
Yoshisato Yanagisawa406de132018-06-29 05:43:25 +000020import cpplint
dcheng091b7db2016-06-16 01:27:51 -070021import fnmatch # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000022import glob
asvitkine@chromium.org15169952011-09-27 14:30:53 +000023import inspect
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +000024import itertools
maruel@chromium.org4f6852c2012-04-20 20:39:20 +000025import json # Exposed through the API.
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +000026import logging
ilevy@chromium.orgbc117312013-04-20 03:57:56 +000027import multiprocessing
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000028import os # Somewhat exposed through the API.
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +000029import random
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000030import re # Exposed through the API.
Edward Lesmes8e282792018-04-03 18:50:29 -040031import signal
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000032import sys # Parts exposed through API.
33import tempfile # Exposed through the API.
Edward Lesmes8e282792018-04-03 18:50:29 -040034import threading
jam@chromium.org2a891dc2009-08-20 20:33:37 +000035import time
Edward Lemurde9e3ca2019-10-24 21:13:31 +000036import traceback
maruel@chromium.org1487d532009-06-06 00:22:57 +000037import unittest # Exposed through the API.
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +000038from warnings import warn
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000039
40# Local imports.
maruel@chromium.org35625c72011-03-23 17:34:02 +000041import fix_encoding
Yoshisato Yanagisawa04600b42019-03-15 03:03:41 +000042import gclient_paths # Exposed through the API
43import gclient_utils
Aaron Gableb584c4f2017-04-26 16:28:08 -070044import git_footers
tandrii@chromium.org015ebae2016-04-25 19:37:22 +000045import gerrit_util
dpranke@chromium.org2a009622011-03-01 02:43:31 +000046import owners
Jochen Eisinger76f5fc62017-04-07 16:27:46 +020047import owners_finder
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000048import presubmit_canned_checks
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +000049import scm
maruel@chromium.org84f4fe32011-04-06 13:26:45 +000050import subprocess2 as subprocess # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000051
Edward Lemur16af3562019-10-17 22:11:33 +000052if sys.version_info.major == 2:
53 # TODO(1009814): Expose urllib2 only through urllib_request and urllib_error
54 import urllib2 # Exposed through the API.
55 import urlparse
56 import urllib2 as urllib_request
57 import urllib2 as urllib_error
58else:
59 import urllib.parse as urlparse
60 import urllib.request as urllib_request
61 import urllib.error as urllib_error
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000062
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +000063# Ask for feedback only once in program lifetime.
64_ASKED_FOR_FEEDBACK = False
65
66
Edward Lemurecc27072020-01-06 16:42:34 +000067def time_time():
68 # Use this so that it can be mocked in tests without interfering with python
69 # system machinery.
70 return time.time()
71
72
maruel@chromium.org899e1c12011-04-07 17:03:18 +000073class PresubmitFailure(Exception):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000074 pass
75
76
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000077class CommandData(object):
Edward Lemur940c2822019-08-23 00:34:25 +000078 def __init__(self, name, cmd, kwargs, message, python3=False):
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000079 self.name = name
80 self.cmd = cmd
Edward Lesmes8e282792018-04-03 18:50:29 -040081 self.stdin = kwargs.get('stdin', None)
Edward Lemur2d6b67c2019-08-23 22:25:41 +000082 self.kwargs = kwargs.copy()
Edward Lesmes8e282792018-04-03 18:50:29 -040083 self.kwargs['stdout'] = subprocess.PIPE
84 self.kwargs['stderr'] = subprocess.STDOUT
85 self.kwargs['stdin'] = subprocess.PIPE
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000086 self.message = message
87 self.info = None
Edward Lemur940c2822019-08-23 00:34:25 +000088 self.python3 = python3
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000089
ilevy@chromium.orgbc117312013-04-20 03:57:56 +000090
Edward Lesmes8e282792018-04-03 18:50:29 -040091# Adapted from
92# https://github.com/google/gtest-parallel/blob/master/gtest_parallel.py#L37
93#
94# An object that catches SIGINT sent to the Python process and notices
95# if processes passed to wait() die by SIGINT (we need to look for
96# both of those cases, because pressing Ctrl+C can result in either
97# the main process or one of the subprocesses getting the signal).
98#
99# Before a SIGINT is seen, wait(p) will simply call p.wait() and
100# return the result. Once a SIGINT has been seen (in the main process
101# or a subprocess, including the one the current call is waiting for),
Edward Lemur9a5bb612019-09-26 02:01:52 +0000102# wait(p) will call p.terminate().
Edward Lesmes8e282792018-04-03 18:50:29 -0400103class SigintHandler(object):
Edward Lesmes8e282792018-04-03 18:50:29 -0400104 sigint_returncodes = {-signal.SIGINT, # Unix
105 -1073741510, # Windows
106 }
107 def __init__(self):
108 self.__lock = threading.Lock()
109 self.__processes = set()
110 self.__got_sigint = False
Edward Lemur9a5bb612019-09-26 02:01:52 +0000111 self.__previous_signal = signal.signal(signal.SIGINT, self.interrupt)
Edward Lesmes8e282792018-04-03 18:50:29 -0400112
113 def __on_sigint(self):
114 self.__got_sigint = True
115 while self.__processes:
116 try:
117 self.__processes.pop().terminate()
118 except OSError:
119 pass
120
Edward Lemur9a5bb612019-09-26 02:01:52 +0000121 def interrupt(self, signal_num, frame):
Edward Lesmes8e282792018-04-03 18:50:29 -0400122 with self.__lock:
123 self.__on_sigint()
Edward Lemur9a5bb612019-09-26 02:01:52 +0000124 self.__previous_signal(signal_num, frame)
Edward Lesmes8e282792018-04-03 18:50:29 -0400125
126 def got_sigint(self):
127 with self.__lock:
128 return self.__got_sigint
129
130 def wait(self, p, stdin):
131 with self.__lock:
132 if self.__got_sigint:
133 p.terminate()
134 self.__processes.add(p)
135 stdout, stderr = p.communicate(stdin)
136 code = p.returncode
137 with self.__lock:
138 self.__processes.discard(p)
139 if code in self.sigint_returncodes:
140 self.__on_sigint()
Edward Lesmes8e282792018-04-03 18:50:29 -0400141 return stdout, stderr
142
143sigint_handler = SigintHandler()
144
145
Edward Lemurecc27072020-01-06 16:42:34 +0000146class Timer(object):
147 def __init__(self, timeout, fn):
148 self.completed = False
149 self._fn = fn
150 self._timer = threading.Timer(timeout, self._onTimer) if timeout else None
151
152 def __enter__(self):
153 if self._timer:
154 self._timer.start()
155 return self
156
157 def __exit__(self, _type, _value, _traceback):
158 if self._timer:
159 self._timer.cancel()
160
161 def _onTimer(self):
162 self._fn()
163 self.completed = True
164
165
Edward Lesmes8e282792018-04-03 18:50:29 -0400166class ThreadPool(object):
Edward Lemurecc27072020-01-06 16:42:34 +0000167 def __init__(self, pool_size=None, timeout=None):
168 self.timeout = timeout
Edward Lesmes8e282792018-04-03 18:50:29 -0400169 self._pool_size = pool_size or multiprocessing.cpu_count()
170 self._messages = []
171 self._messages_lock = threading.Lock()
172 self._tests = []
173 self._tests_lock = threading.Lock()
174 self._nonparallel_tests = []
175
Edward Lemurecc27072020-01-06 16:42:34 +0000176 def _GetCommand(self, test):
Edward Lemur940c2822019-08-23 00:34:25 +0000177 vpython = 'vpython'
178 if test.python3:
179 vpython += '3'
180 if sys.platform == 'win32':
181 vpython += '.bat'
Edward Lesmes8e282792018-04-03 18:50:29 -0400182
183 cmd = test.cmd
184 if cmd[0] == 'python':
185 cmd = list(cmd)
186 cmd[0] = vpython
187 elif cmd[0].endswith('.py'):
188 cmd = [vpython] + cmd
189
Edward Lemur336e51f2019-11-14 21:42:04 +0000190 # On Windows, scripts on the current directory take precedence over PATH, so
191 # that when testing depot_tools on Windows, calling `vpython.bat` will
192 # execute the copy of vpython of the depot_tools under test instead of the
193 # one in the bot.
194 # As a workaround, we run the tests from the parent directory instead.
195 if (cmd[0] == vpython and
196 'cwd' in test.kwargs and
197 os.path.basename(test.kwargs['cwd']) == 'depot_tools'):
198 test.kwargs['cwd'] = os.path.dirname(test.kwargs['cwd'])
199 cmd[1] = os.path.join('depot_tools', cmd[1])
200
Edward Lemurecc27072020-01-06 16:42:34 +0000201 return cmd
202
203 def _RunWithTimeout(self, cmd, stdin, kwargs):
204 p = subprocess.Popen(cmd, **kwargs)
205 with Timer(self.timeout, p.terminate) as timer:
206 stdout, _ = sigint_handler.wait(p, stdin)
207 if timer.completed:
208 stdout = 'Process timed out after %ss\n%s' % (self.timeout, stdout)
209 return p.returncode, stdout
210
211 def CallCommand(self, test):
212 """Runs an external program.
213
Edward Lemura5799e32020-01-17 19:26:51 +0000214 This function converts invocation of .py files and invocations of 'python'
Edward Lemurecc27072020-01-06 16:42:34 +0000215 to vpython invocations.
216 """
217 cmd = self._GetCommand(test)
Edward Lesmes8e282792018-04-03 18:50:29 -0400218 try:
Edward Lemurecc27072020-01-06 16:42:34 +0000219 start = time_time()
220 returncode, stdout = self._RunWithTimeout(cmd, test.stdin, test.kwargs)
221 duration = time_time() - start
Edward Lemur7cf94382019-11-15 22:36:41 +0000222 except Exception:
Edward Lemurecc27072020-01-06 16:42:34 +0000223 duration = time_time() - start
Edward Lesmes8e282792018-04-03 18:50:29 -0400224 return test.message(
Edward Lemur7cf94382019-11-15 22:36:41 +0000225 '%s\n%s exec failure (%4.2fs)\n%s' % (
226 test.name, ' '.join(cmd), duration, traceback.format_exc()))
Edward Lemurde9e3ca2019-10-24 21:13:31 +0000227
Edward Lemurecc27072020-01-06 16:42:34 +0000228 if returncode != 0:
Edward Lesmes8e282792018-04-03 18:50:29 -0400229 return test.message(
Edward Lemur7cf94382019-11-15 22:36:41 +0000230 '%s\n%s (%4.2fs) failed\n%s' % (
231 test.name, ' '.join(cmd), duration, stdout))
Edward Lemurecc27072020-01-06 16:42:34 +0000232
Edward Lesmes8e282792018-04-03 18:50:29 -0400233 if test.info:
Edward Lemur7cf94382019-11-15 22:36:41 +0000234 return test.info('%s\n%s (%4.2fs)' % (test.name, ' '.join(cmd), duration))
Edward Lesmes8e282792018-04-03 18:50:29 -0400235
236 def AddTests(self, tests, parallel=True):
237 if parallel:
238 self._tests.extend(tests)
239 else:
240 self._nonparallel_tests.extend(tests)
241
242 def RunAsync(self):
243 self._messages = []
244
245 def _WorkerFn():
246 while True:
247 test = None
248 with self._tests_lock:
249 if not self._tests:
250 break
251 test = self._tests.pop()
252 result = self.CallCommand(test)
253 if result:
254 with self._messages_lock:
255 self._messages.append(result)
256
257 def _StartDaemon():
258 t = threading.Thread(target=_WorkerFn)
259 t.daemon = True
260 t.start()
261 return t
262
263 while self._nonparallel_tests:
264 test = self._nonparallel_tests.pop()
265 result = self.CallCommand(test)
266 if result:
267 self._messages.append(result)
268
269 if self._tests:
270 threads = [_StartDaemon() for _ in range(self._pool_size)]
271 for worker in threads:
272 worker.join()
273
274 return self._messages
275
276
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000277def normpath(path):
278 '''Version of os.path.normpath that also changes backward slashes to
279 forward slashes when not running on Windows.
280 '''
281 # This is safe to always do because the Windows version of os.path.normpath
282 # will replace forward slashes with backward slashes.
283 path = path.replace(os.sep, '/')
284 return os.path.normpath(path)
285
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000286
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000287def _RightHandSideLinesImpl(affected_files):
288 """Implements RightHandSideLines for InputApi and GclChange."""
289 for af in affected_files:
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000290 lines = af.ChangedContents()
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000291 for line in lines:
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000292 yield (af, line[0], line[1])
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000293
294
Edward Lemur6eb1d322020-02-27 22:20:15 +0000295def prompt_should_continue(prompt_string):
296 sys.stdout.write(prompt_string)
297 response = sys.stdin.readline().strip().lower()
298 return response in ('y', 'yes')
dpranke@chromium.org5ac21012011-03-16 02:58:25 +0000299
300
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000301# Top level object so multiprocessing can pickle
302# Public access through OutputApi object.
303class _PresubmitResult(object):
304 """Base class for result objects."""
305 fatal = False
306 should_prompt = False
307
308 def __init__(self, message, items=None, long_text=''):
309 """
310 message: A short one-line message to indicate errors.
311 items: A list of short strings to indicate where errors occurred.
312 long_text: multi-line text output, e.g. from another tool
313 """
314 self._message = message
315 self._items = items or []
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000316 self._long_text = long_text.rstrip()
317
Edward Lemur6eb1d322020-02-27 22:20:15 +0000318 def handle(self):
319 sys.stdout.write(self._message)
320 sys.stdout.write('\n')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000321 for index, item in enumerate(self._items):
Edward Lemur6eb1d322020-02-27 22:20:15 +0000322 sys.stdout.write(' ')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000323 # Write separately in case it's unicode.
Edward Lemur6eb1d322020-02-27 22:20:15 +0000324 sys.stdout.write(str(item))
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000325 if index < len(self._items) - 1:
Edward Lemur6eb1d322020-02-27 22:20:15 +0000326 sys.stdout.write(' \\')
327 sys.stdout.write('\n')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000328 if self._long_text:
Edward Lemur6eb1d322020-02-27 22:20:15 +0000329 sys.stdout.write('\n***************\n')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000330 # Write separately in case it's unicode.
Edward Lemur6eb1d322020-02-27 22:20:15 +0000331 sys.stdout.write(self._long_text)
332 sys.stdout.write('\n***************\n')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000333
Debrian Figueroadd2737e2019-06-21 23:50:13 +0000334 def json_format(self):
335 return {
336 'message': self._message,
Debrian Figueroa6095d402019-06-28 18:47:18 +0000337 'items': [str(item) for item in self._items],
Debrian Figueroadd2737e2019-06-21 23:50:13 +0000338 'long_text': self._long_text,
339 'fatal': self.fatal
340 }
341
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000342
343# Top level object so multiprocessing can pickle
344# Public access through OutputApi object.
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000345class _PresubmitError(_PresubmitResult):
346 """A hard presubmit error."""
347 fatal = True
348
349
350# Top level object so multiprocessing can pickle
351# Public access through OutputApi object.
352class _PresubmitPromptWarning(_PresubmitResult):
353 """An warning that prompts the user if they want to continue."""
354 should_prompt = True
355
356
357# Top level object so multiprocessing can pickle
358# Public access through OutputApi object.
359class _PresubmitNotifyResult(_PresubmitResult):
360 """Just print something to the screen -- but it's not even a warning."""
361 pass
362
363
364# Top level object so multiprocessing can pickle
365# Public access through OutputApi object.
366class _MailTextResult(_PresubmitResult):
367 """A warning that should be included in the review request email."""
368 def __init__(self, *args, **kwargs):
369 super(_MailTextResult, self).__init__()
370 raise NotImplementedError()
371
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000372class GerritAccessor(object):
373 """Limited Gerrit functionality for canned presubmit checks to work.
374
375 To avoid excessive Gerrit calls, caches the results.
376 """
377
378 def __init__(self, host):
379 self.host = host
380 self.cache = {}
381
382 def _FetchChangeDetail(self, issue):
383 # Separate function to be easily mocked in tests.
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +0100384 try:
385 return gerrit_util.GetChangeDetail(
386 self.host, str(issue),
Aaron Gable6f5a8d92017-04-18 14:49:05 -0700387 ['ALL_REVISIONS', 'DETAILED_LABELS', 'ALL_COMMITS'])
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +0100388 except gerrit_util.GerritError as e:
389 if e.http_status == 404:
390 raise Exception('Either Gerrit issue %s doesn\'t exist, or '
391 'no credentials to fetch issue details' % issue)
392 raise
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000393
394 def GetChangeInfo(self, issue):
395 """Returns labels and all revisions (patchsets) for this issue.
396
397 The result is a dictionary according to Gerrit REST Api.
398 https://gerrit-review.googlesource.com/Documentation/rest-api.html
399
400 However, API isn't very clear what's inside, so see tests for example.
401 """
402 assert issue
403 cache_key = int(issue)
404 if cache_key not in self.cache:
405 self.cache[cache_key] = self._FetchChangeDetail(issue)
406 return self.cache[cache_key]
407
408 def GetChangeDescription(self, issue, patchset=None):
409 """If patchset is none, fetches current patchset."""
410 info = self.GetChangeInfo(issue)
411 # info is a reference to cache. We'll modify it here adding description to
412 # it to the right patchset, if it is not yet there.
413
414 # Find revision info for the patchset we want.
415 if patchset is not None:
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +0000416 for rev, rev_info in info['revisions'].items():
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000417 if str(rev_info['_number']) == str(patchset):
418 break
419 else:
420 raise Exception('patchset %s doesn\'t exist in issue %s' % (
421 patchset, issue))
422 else:
423 rev = info['current_revision']
424 rev_info = info['revisions'][rev]
425
Andrii Shyshkalov9c3a4642017-01-24 17:41:22 +0100426 return rev_info['commit']['message']
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000427
Mun Yong Jang603d01e2017-12-19 16:38:30 -0800428 def GetDestRef(self, issue):
429 ref = self.GetChangeInfo(issue)['branch']
430 if not ref.startswith('refs/'):
431 # NOTE: it is possible to create 'refs/x' branch,
432 # aka 'refs/heads/refs/x'. However, this is ill-advised.
433 ref = 'refs/heads/%s' % ref
434 return ref
435
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000436 def GetChangeOwner(self, issue):
437 return self.GetChangeInfo(issue)['owner']['email']
438
439 def GetChangeReviewers(self, issue, approving_only=True):
Aaron Gable8b478f02017-07-31 15:33:19 -0700440 changeinfo = self.GetChangeInfo(issue)
441 if approving_only:
442 labelinfo = changeinfo.get('labels', {}).get('Code-Review', {})
443 values = labelinfo.get('values', {}).keys()
444 try:
445 max_value = max(int(v) for v in values)
446 reviewers = [r for r in labelinfo.get('all', [])
447 if r.get('value', 0) == max_value]
448 except ValueError: # values is the empty list
449 reviewers = []
450 else:
451 reviewers = changeinfo.get('reviewers', {}).get('REVIEWER', [])
452 return [r.get('email') for r in reviewers]
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000453
Edward Lemure4d329c2020-02-03 20:41:18 +0000454 def UpdateDescription(self, description, issue):
455 gerrit_util.SetCommitMessage(self.host, issue, description, notify='NONE')
456
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000457
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000458class OutputApi(object):
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000459 """An instance of OutputApi gets passed to presubmit scripts so that they
460 can output various types of results.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000461 """
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000462 PresubmitResult = _PresubmitResult
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000463 PresubmitError = _PresubmitError
464 PresubmitPromptWarning = _PresubmitPromptWarning
465 PresubmitNotifyResult = _PresubmitNotifyResult
466 MailTextResult = _MailTextResult
467
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000468 def __init__(self, is_committing):
469 self.is_committing = is_committing
Daniel Cheng7227d212017-11-17 08:12:37 -0800470 self.more_cc = []
471
472 def AppendCC(self, cc):
473 """Appends a user to cc for this change."""
474 self.more_cc.append(cc)
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000475
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000476 def PresubmitPromptOrNotify(self, *args, **kwargs):
477 """Warn the user when uploading, but only notify if committing."""
478 if self.is_committing:
479 return self.PresubmitNotifyResult(*args, **kwargs)
480 return self.PresubmitPromptWarning(*args, **kwargs)
481
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000482
483class InputApi(object):
484 """An instance of this object is passed to presubmit scripts so they can
485 know stuff about the change they're looking at.
486 """
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000487 # Method could be a function
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800488 # pylint: disable=no-self-use
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000489
maruel@chromium.org3410d912009-06-09 20:56:16 +0000490 # File extensions that are considered source files from a style guide
491 # perspective. Don't modify this list from a presubmit script!
maruel@chromium.orgc33455a2011-06-24 19:14:18 +0000492 #
493 # Files without an extension aren't included in the list. If you want to
local_bot30f774e2020-06-25 18:23:34 +0000494 # filter them as source files, add r'(^|.*?[\\\/])[^.]+$' to the allow list.
495 # Note that ALL CAPS files are blocked in DEFAULT_BLOCK_LIST below.
496 DEFAULT_ALLOW_LIST = (
maruel@chromium.org3410d912009-06-09 20:56:16 +0000497 # C++ and friends
Edward Lemura5799e32020-01-17 19:26:51 +0000498 r'.+\.c$', r'.+\.cc$', r'.+\.cpp$', r'.+\.h$', r'.+\.m$', r'.+\.mm$',
499 r'.+\.inl$', r'.+\.asm$', r'.+\.hxx$', r'.+\.hpp$', r'.+\.s$', r'.+\.S$',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000500 # Scripts
Edward Lemura5799e32020-01-17 19:26:51 +0000501 r'.+\.js$', r'.+\.py$', r'.+\.sh$', r'.+\.rb$', r'.+\.pl$', r'.+\.pm$',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000502 # Other
Edward Lemura5799e32020-01-17 19:26:51 +0000503 r'.+\.java$', r'.+\.mk$', r'.+\.am$', r'.+\.css$', r'.+\.mojom$',
504 r'.+\.fidl$'
maruel@chromium.org3410d912009-06-09 20:56:16 +0000505 )
506
507 # Path regexp that should be excluded from being considered containing source
508 # files. Don't modify this list from a presubmit script!
local_bot30f774e2020-06-25 18:23:34 +0000509 DEFAULT_BLOCK_LIST = (
Edward Lemura5799e32020-01-17 19:26:51 +0000510 r'testing_support[\\\/]google_appengine[\\\/].*',
511 r'.*\bexperimental[\\\/].*',
Kent Tamura179dd1e2018-04-26 15:07:41 +0900512 # Exclude third_party/.* but NOT third_party/{WebKit,blink}
513 # (crbug.com/539768 and crbug.com/836555).
Edward Lemura5799e32020-01-17 19:26:51 +0000514 r'.*\bthird_party[\\\/](?!(WebKit|blink)[\\\/]).*',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000515 # Output directories (just in case)
Edward Lemura5799e32020-01-17 19:26:51 +0000516 r'.*\bDebug[\\\/].*',
517 r'.*\bRelease[\\\/].*',
518 r'.*\bxcodebuild[\\\/].*',
519 r'.*\bout[\\\/].*',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000520 # All caps files like README and LICENCE.
Edward Lemura5799e32020-01-17 19:26:51 +0000521 r'.*\b[A-Z0-9_]{2,}$',
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +0000522 # SCM (can happen in dual SCM configuration). (Slightly over aggressive)
Edward Lemura5799e32020-01-17 19:26:51 +0000523 r'(|.*[\\\/])\.git[\\\/].*',
524 r'(|.*[\\\/])\.svn[\\\/].*',
maruel@chromium.org7ccb4bb2011-11-07 20:26:20 +0000525 # There is no point in processing a patch file.
Edward Lemura5799e32020-01-17 19:26:51 +0000526 r'.+\.diff$',
527 r'.+\.patch$',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000528 )
529
local_bot30f774e2020-06-25 18:23:34 +0000530 # TODO(https://crbug.com/1098562): Remove once no longer used
531 @property
532 def DEFAULT_WHITE_LIST(self):
533 return self.DEFAULT_ALLOW_LIST
534
535 # TODO(https://crbug.com/1098562): Remove once no longer used
536 @property
537 def DEFAULT_BLACK_LIST(self):
538 return self.DEFAULT_BLOCK_LIST
539
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000540 def __init__(self, change, presubmit_path, is_committing,
Edward Lesmes8e282792018-04-03 18:50:29 -0400541 verbose, gerrit_obj, dry_run=None, thread_pool=None, parallel=False):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000542 """Builds an InputApi object.
543
544 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000545 change: A presubmit.Change object.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000546 presubmit_path: The path to the presubmit script being processed.
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000547 is_committing: True if the change is about to be committed.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000548 gerrit_obj: provides basic Gerrit codereview functionality.
549 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -0400550 parallel: if true, all tests reported via input_api.RunTests for all
551 PRESUBMIT files will be run in parallel.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000552 """
maruel@chromium.org9711bba2009-05-22 23:51:39 +0000553 # Version number of the presubmit_support script.
554 self.version = [int(x) for x in __version__.split('.')]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000555 self.change = change
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000556 self.is_committing = is_committing
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000557 self.gerrit = gerrit_obj
tandrii@chromium.org57bafac2016-04-28 05:09:03 +0000558 self.dry_run = dry_run
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000559
Edward Lesmes8e282792018-04-03 18:50:29 -0400560 self.parallel = parallel
561 self.thread_pool = thread_pool or ThreadPool()
562
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000563 # We expose various modules and functions as attributes of the input_api
564 # so that presubmit scripts don't have to import them.
Takeshi Yoshino07a6bea2017-08-02 02:44:06 +0900565 self.ast = ast
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000566 self.basename = os.path.basename
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000567 self.cpplint = cpplint
dcheng091b7db2016-06-16 01:27:51 -0700568 self.fnmatch = fnmatch
Yoshisato Yanagisawa04600b42019-03-15 03:03:41 +0000569 self.gclient_paths = gclient_paths
Yoshisato Yanagisawa57dd17b2019-03-22 09:10:29 +0000570 # TODO(yyanagisawa): stop exposing this when python3 become default.
571 # Since python3's tempfile has TemporaryDirectory, we do not need this.
572 self.temporary_directory = gclient_utils.temporary_directory
dpranke@chromium.org17cc2442012-10-17 21:12:09 +0000573 self.glob = glob.glob
maruel@chromium.orgfb11c7b2010-03-18 18:22:14 +0000574 self.json = json
maruel@chromium.org6fba34d2011-06-02 13:45:12 +0000575 self.logging = logging.getLogger('PRESUBMIT')
maruel@chromium.org2b5ce562011-03-31 16:15:44 +0000576 self.os_listdir = os.listdir
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000577 self.os_path = os.path
pgervais@chromium.orgbd0cace2014-10-02 23:23:46 +0000578 self.os_stat = os.stat
Yoshisato Yanagisawa406de132018-06-29 05:43:25 +0000579 self.os_walk = os.walk
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000580 self.re = re
581 self.subprocess = subprocess
Edward Lemurb9830242019-10-30 22:19:20 +0000582 self.sys = sys
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000583 self.tempfile = tempfile
dpranke@chromium.org0d1bdea2011-03-24 22:54:38 +0000584 self.time = time
maruel@chromium.org1487d532009-06-06 00:22:57 +0000585 self.unittest = unittest
Edward Lemurb9830242019-10-30 22:19:20 +0000586 if sys.version_info.major == 2:
587 self.urllib2 = urllib2
Edward Lemur16af3562019-10-17 22:11:33 +0000588 self.urllib_request = urllib_request
589 self.urllib_error = urllib_error
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000590
Robert Iannucci50258932018-03-19 10:30:59 -0700591 self.is_windows = sys.platform == 'win32'
592
Edward Lemurb9646622019-10-25 20:57:35 +0000593 # Set python_executable to 'vpython' in order to allow scripts in other
594 # repos (e.g. src.git) to automatically pick up that repo's .vpython file,
595 # instead of inheriting the one in depot_tools.
596 self.python_executable = 'vpython'
maruel@chromium.orgc0b22972009-06-25 16:19:14 +0000597 self.environ = os.environ
598
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000599 # InputApi.platform is the platform you're currently running on.
600 self.platform = sys.platform
601
iannucci@chromium.org0af3bb32015-06-12 20:44:35 +0000602 self.cpu_count = multiprocessing.cpu_count()
603
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000604 # The local path of the currently-being-processed presubmit script.
maruel@chromium.org3d235242009-05-15 12:40:48 +0000605 self._current_presubmit_path = os.path.dirname(presubmit_path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000606
607 # We carry the canned checks so presubmit scripts can easily use them.
608 self.canned_checks = presubmit_canned_checks
609
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +0100610 # Temporary files we must manually remove at the end of a run.
611 self._named_temporary_files = []
Jochen Eisinger72606f82017-04-04 10:44:18 +0200612
dpranke@chromium.org2a009622011-03-01 02:43:31 +0000613 # TODO(dpranke): figure out a list of all approved owners for a repo
614 # in order to be able to handle wildcard OWNERS files?
615 self.owners_db = owners.Database(change.RepositoryRoot(),
Edward Lemurb9830242019-10-30 22:19:20 +0000616 fopen=open, os_path=self.os_path)
Jochen Eisinger76f5fc62017-04-07 16:27:46 +0200617 self.owners_finder = owners_finder.OwnersFinder
maruel@chromium.org899e1c12011-04-07 17:03:18 +0000618 self.verbose = verbose
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000619 self.Command = CommandData
dpranke@chromium.org2a009622011-03-01 02:43:31 +0000620
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000621 # Replace <hash_map> and <hash_set> as headers that need to be included
Edward Lemura5799e32020-01-17 19:26:51 +0000622 # with 'base/containers/hash_tables.h' instead.
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000623 # Access to a protected member _XX of a client class
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800624 # pylint: disable=protected-access
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000625 self.cpplint._re_pattern_templates = [
danakj@chromium.org18278522013-06-11 22:42:32 +0000626 (a, b, 'base/containers/hash_tables.h')
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000627 if header in ('<hash_map>', '<hash_set>') else (a, b, header)
628 for (a, b, header) in cpplint._re_pattern_templates
629 ]
630
Edward Lemurecc27072020-01-06 16:42:34 +0000631 def SetTimeout(self, timeout):
632 self.thread_pool.timeout = timeout
633
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000634 def PresubmitLocalPath(self):
635 """Returns the local path of the presubmit script currently being run.
636
637 This is useful if you don't want to hard-code absolute paths in the
638 presubmit script. For example, It can be used to find another file
639 relative to the PRESUBMIT.py script, so the whole tree can be branched and
640 the presubmit script still works, without editing its content.
641 """
maruel@chromium.org3d235242009-05-15 12:40:48 +0000642 return self._current_presubmit_path
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000643
agable0b65e732016-11-22 09:25:46 -0800644 def AffectedFiles(self, include_deletes=True, file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000645 """Same as input_api.change.AffectedFiles() except only lists files
646 (and optionally directories) in the same directory as the current presubmit
Bruce Dawson7a0b07a2020-04-23 17:14:40 +0000647 script, or subdirectories thereof. Note that files are listed using the OS
648 path separator, so backslashes are used as separators on Windows.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000649 """
Edward Lemura5799e32020-01-17 19:26:51 +0000650 dir_with_slash = normpath('%s/' % self.PresubmitLocalPath())
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000651 if len(dir_with_slash) == 1:
652 dir_with_slash = ''
sail@chromium.org5538e022011-05-12 17:53:16 +0000653
Edward Lemurb9830242019-10-30 22:19:20 +0000654 return list(filter(
maruel@chromium.org4661e0c2009-06-04 00:45:26 +0000655 lambda x: normpath(x.AbsoluteLocalPath()).startswith(dir_with_slash),
Edward Lemurb9830242019-10-30 22:19:20 +0000656 self.change.AffectedFiles(include_deletes, file_filter)))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000657
agable0b65e732016-11-22 09:25:46 -0800658 def LocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000659 """Returns local paths of input_api.AffectedFiles()."""
agable0b65e732016-11-22 09:25:46 -0800660 paths = [af.LocalPath() for af in self.AffectedFiles()]
Edward Lemura5799e32020-01-17 19:26:51 +0000661 logging.debug('LocalPaths: %s', paths)
pgervais@chromium.org2f64f782014-04-25 00:12:33 +0000662 return paths
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000663
agable0b65e732016-11-22 09:25:46 -0800664 def AbsoluteLocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000665 """Returns absolute local paths of input_api.AffectedFiles()."""
agable0b65e732016-11-22 09:25:46 -0800666 return [af.AbsoluteLocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000667
John Budorick16162372018-04-18 10:39:53 -0700668 def AffectedTestableFiles(self, include_deletes=None, **kwargs):
agable0b65e732016-11-22 09:25:46 -0800669 """Same as input_api.change.AffectedTestableFiles() except only lists files
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000670 in the same directory as the current presubmit script, or subdirectories
671 thereof.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000672 """
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000673 if include_deletes is not None:
Edward Lemura5799e32020-01-17 19:26:51 +0000674 warn('AffectedTestableFiles(include_deletes=%s)'
675 ' is deprecated and ignored' % str(include_deletes),
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000676 category=DeprecationWarning,
677 stacklevel=2)
Edward Lemurb9830242019-10-30 22:19:20 +0000678 return list(filter(
679 lambda x: x.IsTestableFile(),
680 self.AffectedFiles(include_deletes=False, **kwargs)))
agable0b65e732016-11-22 09:25:46 -0800681
682 def AffectedTextFiles(self, include_deletes=None):
683 """An alias to AffectedTestableFiles for backwards compatibility."""
684 return self.AffectedTestableFiles(include_deletes=include_deletes)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000685
local_bot30f774e2020-06-25 18:23:34 +0000686 def FilterSourceFile(self, affected_file, allow_list=None, block_list=None,
687 white_list=None, black_list=None):
Edward Lemura5799e32020-01-17 19:26:51 +0000688 """Filters out files that aren't considered 'source file'.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000689
local_bot30f774e2020-06-25 18:23:34 +0000690 If allow_list or block_list is None, InputApi.DEFAULT_ALLOW_LIST
691 and InputApi.DEFAULT_BLOCK_LIST is used respectively.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000692
693 The lists will be compiled as regular expression and
694 AffectedFile.LocalPath() needs to pass both list.
695
local_bot30f774e2020-06-25 18:23:34 +0000696 Note: if allow_list or block_list is not set, and white_list or black_list
697 is, then those values are used. This is used for backward compatibility
698 reasons.
699
maruel@chromium.org3410d912009-06-09 20:56:16 +0000700 Note: Copy-paste this function to suit your needs or use a lambda function.
701 """
local_bot30f774e2020-06-25 18:23:34 +0000702 if allow_list is None:
703 allow_list = white_list
704 if block_list is None:
705 block_list = black_list
706
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000707 def Find(affected_file, items):
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000708 local_path = affected_file.LocalPath()
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000709 for item in items:
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +0000710 if self.re.match(item, local_path):
maruel@chromium.org3410d912009-06-09 20:56:16 +0000711 return True
712 return False
local_bot30f774e2020-06-25 18:23:34 +0000713 return (Find(affected_file, allow_list or self.DEFAULT_ALLOW_LIST) and
714 not Find(affected_file, block_list or self.DEFAULT_BLOCK_LIST))
maruel@chromium.org3410d912009-06-09 20:56:16 +0000715
716 def AffectedSourceFiles(self, source_file):
agable0b65e732016-11-22 09:25:46 -0800717 """Filter the list of AffectedTestableFiles by the function source_file.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000718
719 If source_file is None, InputApi.FilterSourceFile() is used.
720 """
721 if not source_file:
722 source_file = self.FilterSourceFile
Edward Lemurb9830242019-10-30 22:19:20 +0000723 return list(filter(source_file, self.AffectedTestableFiles()))
maruel@chromium.org3410d912009-06-09 20:56:16 +0000724
725 def RightHandSideLines(self, source_file_filter=None):
Edward Lemura5799e32020-01-17 19:26:51 +0000726 """An iterator over all text lines in 'new' version of changed files.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000727
728 Only lists lines from new or modified text files in the change that are
729 contained by the directory of the currently executing presubmit script.
730
731 This is useful for doing line-by-line regex checks, like checking for
732 trailing whitespace.
733
734 Yields:
735 a 3 tuple:
736 the AffectedFile instance of the current file;
737 integer line number (1-based); and
738 the contents of the line as a string.
maruel@chromium.org1487d532009-06-06 00:22:57 +0000739
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000740 Note: The carriage return (LF or CR) is stripped off.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000741 """
maruel@chromium.org3410d912009-06-09 20:56:16 +0000742 files = self.AffectedSourceFiles(source_file_filter)
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000743 return _RightHandSideLinesImpl(files)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000744
maruel@chromium.orge3608df2009-11-10 20:22:57 +0000745 def ReadFile(self, file_item, mode='r'):
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000746 """Reads an arbitrary file.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000747
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000748 Deny reading anything outside the repository.
749 """
maruel@chromium.orge3608df2009-11-10 20:22:57 +0000750 if isinstance(file_item, AffectedFile):
751 file_item = file_item.AbsoluteLocalPath()
752 if not file_item.startswith(self.change.RepositoryRoot()):
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000753 raise IOError('Access outside the repository root is denied.')
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +0000754 return gclient_utils.FileRead(file_item, mode)
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000755
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +0100756 def CreateTemporaryFile(self, **kwargs):
757 """Returns a named temporary file that must be removed with a call to
758 RemoveTemporaryFiles().
759
760 All keyword arguments are forwarded to tempfile.NamedTemporaryFile(),
761 except for |delete|, which is always set to False.
762
763 Presubmit checks that need to create a temporary file and pass it for
764 reading should use this function instead of NamedTemporaryFile(), as
765 Windows fails to open a file that is already open for writing.
766
767 with input_api.CreateTemporaryFile() as f:
768 f.write('xyz')
769 f.close()
770 input_api.subprocess.check_output(['script-that', '--reads-from',
771 f.name])
772
773
774 Note that callers of CreateTemporaryFile() should not worry about removing
775 any temporary file; this is done transparently by the presubmit handling
776 code.
777 """
778 if 'delete' in kwargs:
779 # Prevent users from passing |delete|; we take care of file deletion
780 # ourselves and this prevents unintuitive error messages when we pass
781 # delete=False and 'delete' is also in kwargs.
782 raise TypeError('CreateTemporaryFile() does not take a "delete" '
783 'argument, file deletion is handled automatically by '
784 'the same presubmit_support code that creates InputApi '
785 'objects.')
786 temp_file = self.tempfile.NamedTemporaryFile(delete=False, **kwargs)
787 self._named_temporary_files.append(temp_file.name)
788 return temp_file
789
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000790 @property
791 def tbr(self):
792 """Returns if a change is TBR'ed."""
Jeremy Romandce22502017-06-20 15:37:29 -0400793 return 'TBR' in self.change.tags or self.change.TBRsFromDescription()
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000794
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +0000795 def RunTests(self, tests_mix, parallel=True):
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000796 tests = []
797 msgs = []
798 for t in tests_mix:
Edward Lesmes8e282792018-04-03 18:50:29 -0400799 if isinstance(t, OutputApi.PresubmitResult) and t:
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000800 msgs.append(t)
801 else:
802 assert issubclass(t.message, _PresubmitResult)
803 tests.append(t)
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +0000804 if self.verbose:
805 t.info = _PresubmitNotifyResult
Edward Lemur1037c742018-05-01 18:56:04 -0400806 if not t.kwargs.get('cwd'):
807 t.kwargs['cwd'] = self.PresubmitLocalPath()
Edward Lesmes8e282792018-04-03 18:50:29 -0400808 self.thread_pool.AddTests(tests, parallel)
Edward Lemur21000eb2019-05-24 23:25:58 +0000809 # When self.parallel is True (i.e. --parallel is passed as an option)
810 # RunTests doesn't actually run tests. It adds them to a ThreadPool that
811 # will run all tests once all PRESUBMIT files are processed.
812 # Otherwise, it will run them and return the results.
813 if not self.parallel:
Edward Lesmes8e282792018-04-03 18:50:29 -0400814 msgs.extend(self.thread_pool.RunAsync())
815 return msgs
scottmg86099d72016-09-01 09:16:51 -0700816
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000817
nick@chromium.orgff526192013-06-10 19:30:26 +0000818class _DiffCache(object):
819 """Caches diffs retrieved from a particular SCM."""
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000820 def __init__(self, upstream=None):
821 """Stores the upstream revision against which all diffs will be computed."""
822 self._upstream = upstream
nick@chromium.orgff526192013-06-10 19:30:26 +0000823
824 def GetDiff(self, path, local_root):
825 """Get the diff for a particular path."""
826 raise NotImplementedError()
827
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700828 def GetOldContents(self, path, local_root):
829 """Get the old version for a particular path."""
830 raise NotImplementedError()
831
nick@chromium.orgff526192013-06-10 19:30:26 +0000832
nick@chromium.orgff526192013-06-10 19:30:26 +0000833class _GitDiffCache(_DiffCache):
834 """DiffCache implementation for git; gets all file diffs at once."""
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000835 def __init__(self, upstream):
836 super(_GitDiffCache, self).__init__(upstream=upstream)
nick@chromium.orgff526192013-06-10 19:30:26 +0000837 self._diffs_by_file = None
838
839 def GetDiff(self, path, local_root):
840 if not self._diffs_by_file:
841 # Compute a single diff for all files and parse the output; should
842 # with git this is much faster than computing one diff for each file.
843 diffs = {}
844
845 # Don't specify any filenames below, because there are command line length
846 # limits on some platforms and GenerateDiff would fail.
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000847 unified_diff = scm.GIT.GenerateDiff(local_root, files=[], full_move=True,
848 branch=self._upstream)
nick@chromium.orgff526192013-06-10 19:30:26 +0000849
850 # This regex matches the path twice, separated by a space. Note that
851 # filename itself may contain spaces.
852 file_marker = re.compile('^diff --git (?P<filename>.*) (?P=filename)$')
853 current_diff = []
854 keep_line_endings = True
855 for x in unified_diff.splitlines(keep_line_endings):
856 match = file_marker.match(x)
857 if match:
858 # Marks the start of a new per-file section.
859 diffs[match.group('filename')] = current_diff = [x]
860 elif x.startswith('diff --git'):
861 raise PresubmitFailure('Unexpected diff line: %s' % x)
862 else:
863 current_diff.append(x)
864
865 self._diffs_by_file = dict(
866 (normpath(path), ''.join(diff)) for path, diff in diffs.items())
867
868 if path not in self._diffs_by_file:
869 raise PresubmitFailure(
870 'Unified diff did not contain entry for file %s' % path)
871
872 return self._diffs_by_file[path]
873
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700874 def GetOldContents(self, path, local_root):
875 return scm.GIT.GetOldContents(local_root, path, branch=self._upstream)
876
nick@chromium.orgff526192013-06-10 19:30:26 +0000877
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000878class AffectedFile(object):
879 """Representation of a file in a change."""
nick@chromium.orgff526192013-06-10 19:30:26 +0000880
881 DIFF_CACHE = _DiffCache
882
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000883 # Method could be a function
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800884 # pylint: disable=no-self-use
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000885 def __init__(self, path, action, repository_root, diff_cache):
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000886 self._path = path
887 self._action = action
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000888 self._local_root = repository_root
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000889 self._is_directory = None
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000890 self._cached_changed_contents = None
891 self._cached_new_contents = None
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000892 self._diff_cache = diff_cache
tobiasjs2836bcf2016-08-16 04:08:16 -0700893 logging.debug('%s(%s)', self.__class__.__name__, self._path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000894
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000895 def LocalPath(self):
896 """Returns the path of this file on the local disk relative to client root.
Andrew Grieve92b8b992017-11-02 09:42:24 -0400897
898 This should be used for error messages but not for accessing files,
899 because presubmit checks are run with CWD=PresubmitLocalPath() (which is
900 often != client root).
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000901 """
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000902 return normpath(self._path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000903
904 def AbsoluteLocalPath(self):
905 """Returns the absolute path of this file on the local disk.
906 """
chase@chromium.org8e416c82009-10-06 04:30:44 +0000907 return os.path.abspath(os.path.join(self._local_root, self.LocalPath()))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000908
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000909 def Action(self):
910 """Returns the action on this opened file, e.g. A, M, D, etc."""
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000911 return self._action
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000912
agable0b65e732016-11-22 09:25:46 -0800913 def IsTestableFile(self):
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000914 """Returns True if the file is a text file and not a binary file.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000915
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000916 Deleted files are not text file."""
maruel@chromium.org1e08c002009-05-28 19:09:33 +0000917 raise NotImplementedError() # Implement when needed
918
agable0b65e732016-11-22 09:25:46 -0800919 def IsTextFile(self):
920 """An alias to IsTestableFile for backwards compatibility."""
921 return self.IsTestableFile()
922
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700923 def OldContents(self):
924 """Returns an iterator over the lines in the old version of file.
925
Daniel Cheng2da34fe2017-03-21 20:42:12 -0700926 The old version is the file before any modifications in the user's
Edward Lemura5799e32020-01-17 19:26:51 +0000927 workspace, i.e. the 'left hand side'.
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700928
929 Contents will be empty if the file is a directory or does not exist.
930 Note: The carriage returns (LF or CR) are stripped off.
931 """
932 return self._diff_cache.GetOldContents(self.LocalPath(),
933 self._local_root).splitlines()
934
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000935 def NewContents(self):
936 """Returns an iterator over the lines in the new version of file.
937
Edward Lemura5799e32020-01-17 19:26:51 +0000938 The new version is the file in the user's workspace, i.e. the 'right hand
939 side'.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000940
941 Contents will be empty if the file is a directory or does not exist.
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000942 Note: The carriage returns (LF or CR) are stripped off.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000943 """
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000944 if self._cached_new_contents is None:
945 self._cached_new_contents = []
agable0b65e732016-11-22 09:25:46 -0800946 try:
947 self._cached_new_contents = gclient_utils.FileRead(
948 self.AbsoluteLocalPath(), 'rU').splitlines()
949 except IOError:
950 pass # File not found? That's fine; maybe it was deleted.
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000951 return self._cached_new_contents[:]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000952
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000953 def ChangedContents(self):
954 """Returns a list of tuples (line number, line text) of all new lines.
955
956 This relies on the scm diff output describing each changed code section
957 with a line of the form
958
959 ^@@ <old line num>,<old size> <new line num>,<new size> @@$
960 """
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000961 if self._cached_changed_contents is not None:
962 return self._cached_changed_contents[:]
963 self._cached_changed_contents = []
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000964 line_num = 0
965
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000966 for line in self.GenerateScmDiff().splitlines():
Edward Lemurac5c55f2020-02-29 00:17:16 +0000967 m = re.match(r'^@@ [0-9\,\+\-]+ \+([0-9]+)\,[0-9]+ @@', line)
968 if m:
969 line_num = int(m.groups(1)[0])
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000970 continue
971 if line.startswith('+') and not line.startswith('++'):
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000972 self._cached_changed_contents.append((line_num, line[1:]))
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000973 if not line.startswith('-'):
974 line_num += 1
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000975 return self._cached_changed_contents[:]
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000976
maruel@chromium.org5de13972009-06-10 18:16:06 +0000977 def __str__(self):
978 return self.LocalPath()
979
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000980 def GenerateScmDiff(self):
nick@chromium.orgff526192013-06-10 19:30:26 +0000981 return self._diff_cache.GetDiff(self.LocalPath(), self._local_root)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000982
maruel@chromium.org58407af2011-04-12 23:15:57 +0000983
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000984class GitAffectedFile(AffectedFile):
985 """Representation of a file in a change out of a git checkout."""
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000986 # Method 'NNN' is abstract in class 'NNN' but is not overridden
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800987 # pylint: disable=abstract-method
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000988
nick@chromium.orgff526192013-06-10 19:30:26 +0000989 DIFF_CACHE = _GitDiffCache
990
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000991 def __init__(self, *args, **kwargs):
992 AffectedFile.__init__(self, *args, **kwargs)
993 self._server_path = None
agable0b65e732016-11-22 09:25:46 -0800994 self._is_testable_file = None
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000995
agable0b65e732016-11-22 09:25:46 -0800996 def IsTestableFile(self):
997 if self._is_testable_file is None:
maruel@chromium.orgc70a2202009-06-17 12:55:10 +0000998 if self.Action() == 'D':
agable0b65e732016-11-22 09:25:46 -0800999 # A deleted file is not testable.
1000 self._is_testable_file = False
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001001 else:
agable0b65e732016-11-22 09:25:46 -08001002 self._is_testable_file = os.path.isfile(self.AbsoluteLocalPath())
1003 return self._is_testable_file
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001004
maruel@chromium.orgc1938752011-04-12 23:11:13 +00001005
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001006class Change(object):
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001007 """Describe a change.
1008
1009 Used directly by the presubmit scripts to query the current change being
1010 tested.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +00001011
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001012 Instance members:
nick@chromium.orgff526192013-06-10 19:30:26 +00001013 tags: Dictionary of KEY=VALUE pairs found in the change description.
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001014 self.KEY: equivalent to tags['KEY']
1015 """
1016
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001017 _AFFECTED_FILES = AffectedFile
1018
Edward Lemura5799e32020-01-17 19:26:51 +00001019 # Matches key/value (or 'tag') lines in changelist descriptions.
maruel@chromium.org428342a2011-11-10 15:46:33 +00001020 TAG_LINE_RE = re.compile(
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001021 '^[ \t]*(?P<key>[A-Z][A-Z_0-9]*)[ \t]*=[ \t]*(?P<value>.*?)[ \t]*$')
maruel@chromium.orgc1938752011-04-12 23:11:13 +00001022 scm = ''
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001023
maruel@chromium.org58407af2011-04-12 23:15:57 +00001024 def __init__(
agable@chromium.orgea84ef12014-04-30 19:55:12 +00001025 self, name, description, local_root, files, issue, patchset, author,
1026 upstream=None):
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001027 if files is None:
1028 files = []
1029 self._name = name
chase@chromium.org8e416c82009-10-06 04:30:44 +00001030 # Convert root into an absolute path.
1031 self._local_root = os.path.abspath(local_root)
agable@chromium.orgea84ef12014-04-30 19:55:12 +00001032 self._upstream = upstream
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001033 self.issue = issue
1034 self.patchset = patchset
maruel@chromium.org58407af2011-04-12 23:15:57 +00001035 self.author_email = author
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001036
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001037 self._full_description = ''
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001038 self.tags = {}
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001039 self._description_without_tags = ''
1040 self.SetDescriptionText(description)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001041
maruel@chromium.orge085d812011-10-10 19:49:15 +00001042 assert all(
1043 (isinstance(f, (list, tuple)) and len(f) == 2) for f in files), files
1044
agable@chromium.orgea84ef12014-04-30 19:55:12 +00001045 diff_cache = self._AFFECTED_FILES.DIFF_CACHE(self._upstream)
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001046 self._affected_files = [
nick@chromium.orgff526192013-06-10 19:30:26 +00001047 self._AFFECTED_FILES(path, action.strip(), self._local_root, diff_cache)
1048 for action, path in files
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +00001049 ]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001050
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001051 def Name(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001052 """Returns the change name."""
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001053 return self._name
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001054
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001055 def DescriptionText(self):
1056 """Returns the user-entered changelist description, minus tags.
1057
Edward Lemura5799e32020-01-17 19:26:51 +00001058 Any line in the user-provided description starting with e.g. 'FOO='
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001059 (whitespace permitted before and around) is considered a tag line. Such
1060 lines are stripped out of the description this function returns.
1061 """
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001062 return self._description_without_tags
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001063
1064 def FullDescriptionText(self):
1065 """Returns the complete changelist description including tags."""
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001066 return self._full_description
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001067
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001068 def SetDescriptionText(self, description):
1069 """Sets the full description text (including tags) to |description|.
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001070
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001071 Also updates the list of tags."""
1072 self._full_description = description
1073
1074 # From the description text, build up a dictionary of key/value pairs
Edward Lemura5799e32020-01-17 19:26:51 +00001075 # plus the description minus all key/value or 'tag' lines.
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001076 description_without_tags = []
1077 self.tags = {}
1078 for line in self._full_description.splitlines():
1079 m = self.TAG_LINE_RE.match(line)
1080 if m:
1081 self.tags[m.group('key')] = m.group('value')
1082 else:
1083 description_without_tags.append(line)
1084
1085 # Change back to text and remove whitespace at end.
1086 self._description_without_tags = (
1087 '\n'.join(description_without_tags).rstrip())
1088
Edward Lemur69bb8be2020-02-03 20:37:38 +00001089 def AddDescriptionFooter(self, key, value):
1090 """Adds the given footer to the change description.
1091
1092 Args:
1093 key: A string with the key for the git footer. It must conform to
1094 the git footers format (i.e. 'List-Of-Tokens') and will be case
1095 normalized so that each token is title-cased.
1096 value: A string with the value for the git footer.
1097 """
1098 description = git_footers.add_footer(
1099 self.FullDescriptionText(), git_footers.normalize_name(key), value)
1100 self.SetDescriptionText(description)
1101
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001102 def RepositoryRoot(self):
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001103 """Returns the repository (checkout) root directory for this change,
1104 as an absolute path.
1105 """
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001106 return self._local_root
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001107
1108 def __getattr__(self, attr):
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001109 """Return tags directly as attributes on the object."""
Edward Lemura5799e32020-01-17 19:26:51 +00001110 if not re.match(r'^[A-Z_]*$', attr):
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001111 raise AttributeError(self, attr)
maruel@chromium.orge1a524f2009-05-27 14:43:46 +00001112 return self.tags.get(attr)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001113
Edward Lemur69bb8be2020-02-03 20:37:38 +00001114 def GitFootersFromDescription(self):
1115 """Return the git footers present in the description.
1116
1117 Returns:
1118 footers: A dict of {footer: [values]} containing a multimap of the footers
1119 in the change description.
1120 """
1121 return git_footers.parse_footers(self.FullDescriptionText())
1122
Aaron Gablefc03e672017-05-15 14:09:42 -07001123 def BugsFromDescription(self):
1124 """Returns all bugs referenced in the commit description."""
Aaron Gable12ef5012017-05-15 14:29:00 -07001125 tags = [b.strip() for b in self.tags.get('BUG', '').split(',') if b.strip()]
Caleb Rouleauc0546b92019-02-22 06:12:57 +00001126 footers = []
Edward Lemur69bb8be2020-02-03 20:37:38 +00001127 parsed = self.GitFootersFromDescription()
Dan Beam62954042019-10-03 21:20:33 +00001128 unsplit_footers = parsed.get('Bug', []) + parsed.get('Fixed', [])
Caleb Rouleauc0546b92019-02-22 06:12:57 +00001129 for unsplit_footer in unsplit_footers:
1130 footers += [b.strip() for b in unsplit_footer.split(',')]
Aaron Gable12ef5012017-05-15 14:29:00 -07001131 return sorted(set(tags + footers))
Aaron Gablefc03e672017-05-15 14:09:42 -07001132
1133 def ReviewersFromDescription(self):
1134 """Returns all reviewers listed in the commit description."""
Edward Lemura5799e32020-01-17 19:26:51 +00001135 # We don't support a 'R:' git-footer for reviewers; that is in metadata.
Aaron Gable12ef5012017-05-15 14:29:00 -07001136 tags = [r.strip() for r in self.tags.get('R', '').split(',') if r.strip()]
1137 return sorted(set(tags))
Aaron Gablefc03e672017-05-15 14:09:42 -07001138
1139 def TBRsFromDescription(self):
1140 """Returns all TBR reviewers listed in the commit description."""
Aaron Gable12ef5012017-05-15 14:29:00 -07001141 tags = [r.strip() for r in self.tags.get('TBR', '').split(',') if r.strip()]
Aaron Gable6e7ddb62020-05-27 22:23:29 +00001142 # TODO(crbug.com/839208): Remove support for 'Tbr:' when TBRs are
1143 # programmatically determined by self-CR+1s.
Edward Lemur69bb8be2020-02-03 20:37:38 +00001144 footers = self.GitFootersFromDescription().get('Tbr', [])
Aaron Gable12ef5012017-05-15 14:29:00 -07001145 return sorted(set(tags + footers))
Aaron Gablefc03e672017-05-15 14:09:42 -07001146
Aaron Gable6e7ddb62020-05-27 22:23:29 +00001147 # TODO(crbug.com/753425): Delete these once we're sure they're unused.
Aaron Gablefc03e672017-05-15 14:09:42 -07001148 @property
1149 def BUG(self):
1150 return ','.join(self.BugsFromDescription())
1151 @property
1152 def R(self):
1153 return ','.join(self.ReviewersFromDescription())
1154 @property
1155 def TBR(self):
1156 return ','.join(self.TBRsFromDescription())
1157
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001158 def AllFiles(self, root=None):
1159 """List all files under source control in the repo."""
1160 raise NotImplementedError()
1161
agable0b65e732016-11-22 09:25:46 -08001162 def AffectedFiles(self, include_deletes=True, file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001163 """Returns a list of AffectedFile instances for all files in the change.
1164
1165 Args:
1166 include_deletes: If false, deleted files will be filtered out.
sail@chromium.org5538e022011-05-12 17:53:16 +00001167 file_filter: An additional filter to apply.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001168
1169 Returns:
1170 [AffectedFile(path, action), AffectedFile(path, action)]
1171 """
Edward Lemurb9830242019-10-30 22:19:20 +00001172 affected = list(filter(file_filter, self._affected_files))
sail@chromium.org5538e022011-05-12 17:53:16 +00001173
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001174 if include_deletes:
1175 return affected
Edward Lemurb9830242019-10-30 22:19:20 +00001176 return list(filter(lambda x: x.Action() != 'D', affected))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001177
John Budorick16162372018-04-18 10:39:53 -07001178 def AffectedTestableFiles(self, include_deletes=None, **kwargs):
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +00001179 """Return a list of the existing text files in a change."""
1180 if include_deletes is not None:
Edward Lemura5799e32020-01-17 19:26:51 +00001181 warn('AffectedTeestableFiles(include_deletes=%s)'
1182 ' is deprecated and ignored' % str(include_deletes),
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +00001183 category=DeprecationWarning,
1184 stacklevel=2)
Edward Lemurb9830242019-10-30 22:19:20 +00001185 return list(filter(
1186 lambda x: x.IsTestableFile(),
1187 self.AffectedFiles(include_deletes=False, **kwargs)))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001188
agable0b65e732016-11-22 09:25:46 -08001189 def AffectedTextFiles(self, include_deletes=None):
1190 """An alias to AffectedTestableFiles for backwards compatibility."""
1191 return self.AffectedTestableFiles(include_deletes=include_deletes)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001192
agable0b65e732016-11-22 09:25:46 -08001193 def LocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001194 """Convenience function."""
agable0b65e732016-11-22 09:25:46 -08001195 return [af.LocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001196
agable0b65e732016-11-22 09:25:46 -08001197 def AbsoluteLocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001198 """Convenience function."""
agable0b65e732016-11-22 09:25:46 -08001199 return [af.AbsoluteLocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001200
1201 def RightHandSideLines(self):
Edward Lemura5799e32020-01-17 19:26:51 +00001202 """An iterator over all text lines in 'new' version of changed files.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001203
1204 Lists lines from new or modified text files in the change.
1205
1206 This is useful for doing line-by-line regex checks, like checking for
1207 trailing whitespace.
1208
1209 Yields:
1210 a 3 tuple:
1211 the AffectedFile instance of the current file;
1212 integer line number (1-based); and
1213 the contents of the line as a string.
1214 """
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +00001215 return _RightHandSideLinesImpl(
1216 x for x in self.AffectedFiles(include_deletes=False)
agable0b65e732016-11-22 09:25:46 -08001217 if x.IsTestableFile())
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001218
Jochen Eisingerd0573ec2017-04-13 10:55:06 +02001219 def OriginalOwnersFiles(self):
1220 """A map from path names of affected OWNERS files to their old content."""
1221 def owners_file_filter(f):
1222 return 'OWNERS' in os.path.split(f.LocalPath())[1]
1223 files = self.AffectedFiles(file_filter=owners_file_filter)
1224 return dict([(f.LocalPath(), f.OldContents()) for f in files])
1225
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001226
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001227class GitChange(Change):
1228 _AFFECTED_FILES = GitAffectedFile
maruel@chromium.orgc1938752011-04-12 23:11:13 +00001229 scm = 'git'
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +00001230
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001231 def AllFiles(self, root=None):
1232 """List all files under source control in the repo."""
1233 root = root or self.RepositoryRoot()
1234 return subprocess.check_output(
Aaron Gable7817f022017-12-12 09:43:17 -08001235 ['git', '-c', 'core.quotePath=false', 'ls-files', '--', '.'],
1236 cwd=root).splitlines()
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001237
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001238
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001239def ListRelevantPresubmitFiles(files, root):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001240 """Finds all presubmit files that apply to a given set of source files.
1241
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001242 If inherit-review-settings-ok is present right under root, looks for
1243 PRESUBMIT.py in directories enclosing root.
1244
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001245 Args:
1246 files: An iterable container containing file paths.
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001247 root: Path where to stop searching.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001248
1249 Return:
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001250 List of absolute paths of the existing PRESUBMIT.py scripts.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001251 """
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001252 files = [normpath(os.path.join(root, f)) for f in files]
1253
1254 # List all the individual directories containing files.
1255 directories = set([os.path.dirname(f) for f in files])
1256
1257 # Ignore root if inherit-review-settings-ok is present.
1258 if os.path.isfile(os.path.join(root, 'inherit-review-settings-ok')):
1259 root = None
1260
1261 # Collect all unique directories that may contain PRESUBMIT.py.
1262 candidates = set()
1263 for directory in directories:
1264 while True:
1265 if directory in candidates:
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001266 break
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001267 candidates.add(directory)
1268 if directory == root:
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001269 break
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001270 parent_dir = os.path.dirname(directory)
1271 if parent_dir == directory:
1272 # We hit the system root directory.
1273 break
1274 directory = parent_dir
1275
1276 # Look for PRESUBMIT.py in all candidate directories.
1277 results = []
1278 for directory in sorted(list(candidates)):
tobiasjsff061c02016-08-17 03:23:57 -07001279 try:
1280 for f in os.listdir(directory):
1281 p = os.path.join(directory, f)
1282 if os.path.isfile(p) and re.match(
1283 r'PRESUBMIT.*\.py$', f) and not f.startswith('PRESUBMIT_test'):
1284 results.append(p)
1285 except OSError:
1286 pass
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001287
tobiasjs2836bcf2016-08-16 04:08:16 -07001288 logging.debug('Presubmit files: %s', ','.join(results))
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001289 return results
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001290
1291
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001292class GetTryMastersExecuter(object):
1293 @staticmethod
1294 def ExecPresubmitScript(script_text, presubmit_path, project, change):
1295 """Executes GetPreferredTryMasters() from a single presubmit script.
1296
1297 Args:
1298 script_text: The text of the presubmit script.
1299 presubmit_path: Project script to run.
1300 project: Project name to pass to presubmit script for bot selection.
1301
1302 Return:
1303 A map of try masters to map of builders to set of tests.
1304 """
1305 context = {}
1306 try:
Raul Tambre09e64b42019-05-14 01:57:22 +00001307 exec(compile(script_text, 'PRESUBMIT.py', 'exec', dont_inherit=True),
1308 context)
Raul Tambre7c938462019-05-24 16:35:35 +00001309 except Exception as e:
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001310 raise PresubmitFailure('"%s" had an exception.\n%s'
1311 % (presubmit_path, e))
1312
1313 function_name = 'GetPreferredTryMasters'
1314 if function_name not in context:
1315 return {}
1316 get_preferred_try_masters = context[function_name]
1317 if not len(inspect.getargspec(get_preferred_try_masters)[0]) == 2:
1318 raise PresubmitFailure(
1319 'Expected function "GetPreferredTryMasters" to take two arguments.')
1320 return get_preferred_try_masters(project, change)
1321
1322
rmistry@google.com5626a922015-02-26 14:03:30 +00001323class GetPostUploadExecuter(object):
1324 @staticmethod
Edward Lemur016a0872020-02-04 22:13:28 +00001325 def ExecPresubmitScript(script_text, presubmit_path, gerrit_obj, change):
rmistry@google.com5626a922015-02-26 14:03:30 +00001326 """Executes PostUploadHook() from a single presubmit script.
1327
1328 Args:
1329 script_text: The text of the presubmit script.
1330 presubmit_path: Project script to run.
Edward Lemur016a0872020-02-04 22:13:28 +00001331 gerrit_obj: The GerritAccessor object.
rmistry@google.com5626a922015-02-26 14:03:30 +00001332 change: The Change object.
1333
1334 Return:
1335 A list of results objects.
1336 """
1337 context = {}
1338 try:
Raul Tambre09e64b42019-05-14 01:57:22 +00001339 exec(compile(script_text, 'PRESUBMIT.py', 'exec', dont_inherit=True),
1340 context)
Raul Tambre7c938462019-05-24 16:35:35 +00001341 except Exception as e:
rmistry@google.com5626a922015-02-26 14:03:30 +00001342 raise PresubmitFailure('"%s" had an exception.\n%s'
1343 % (presubmit_path, e))
1344
1345 function_name = 'PostUploadHook'
1346 if function_name not in context:
1347 return {}
1348 post_upload_hook = context[function_name]
1349 if not len(inspect.getargspec(post_upload_hook)[0]) == 3:
1350 raise PresubmitFailure(
1351 'Expected function "PostUploadHook" to take three arguments.')
Edward Lemur016a0872020-02-04 22:13:28 +00001352 return post_upload_hook(gerrit_obj, change, OutputApi(False))
rmistry@google.com5626a922015-02-26 14:03:30 +00001353
1354
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001355def _MergeMasters(masters1, masters2):
1356 """Merges two master maps. Merges also the tests of each builder."""
1357 result = {}
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001358 for (master, builders) in itertools.chain(masters1.items(),
1359 masters2.items()):
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001360 new_builders = result.setdefault(master, {})
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001361 for (builder, tests) in builders.items():
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001362 new_builders.setdefault(builder, set([])).update(tests)
1363 return result
1364
1365
1366def DoGetTryMasters(change,
1367 changed_files,
1368 repository_root,
1369 default_presubmit,
1370 project,
1371 verbose,
1372 output_stream):
1373 """Get the list of try masters from the presubmit scripts.
1374
1375 Args:
1376 changed_files: List of modified files.
1377 repository_root: The repository root.
1378 default_presubmit: A default presubmit script to execute in any case.
1379 project: Optional name of a project used in selecting trybots.
1380 verbose: Prints debug info.
1381 output_stream: A stream to write debug output to.
1382
1383 Return:
1384 Map of try masters to map of builders to set of tests.
1385 """
1386 presubmit_files = ListRelevantPresubmitFiles(changed_files, repository_root)
1387 if not presubmit_files and verbose:
Edward Lemura5799e32020-01-17 19:26:51 +00001388 output_stream.write('Warning, no PRESUBMIT.py found.\n')
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001389 results = {}
1390 executer = GetTryMastersExecuter()
1391
1392 if default_presubmit:
1393 if verbose:
Edward Lemura5799e32020-01-17 19:26:51 +00001394 output_stream.write('Running default presubmit script.\n')
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001395 fake_path = os.path.join(repository_root, 'PRESUBMIT.py')
1396 results = _MergeMasters(results, executer.ExecPresubmitScript(
1397 default_presubmit, fake_path, project, change))
1398 for filename in presubmit_files:
1399 filename = os.path.abspath(filename)
1400 if verbose:
Edward Lemura5799e32020-01-17 19:26:51 +00001401 output_stream.write('Running %s\n' % filename)
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001402 # Accept CRLF presubmit script.
1403 presubmit_script = gclient_utils.FileRead(filename, 'rU')
1404 results = _MergeMasters(results, executer.ExecPresubmitScript(
1405 presubmit_script, filename, project, change))
1406
1407 # Make sets to lists again for later JSON serialization.
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001408 for builders in results.values():
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001409 for builder in builders:
1410 builders[builder] = list(builders[builder])
1411
1412 if results and verbose:
1413 output_stream.write('%s\n' % str(results))
1414 return results
1415
1416
rmistry@google.com5626a922015-02-26 14:03:30 +00001417def DoPostUploadExecuter(change,
Edward Lemur016a0872020-02-04 22:13:28 +00001418 gerrit_obj,
Edward Lemur6eb1d322020-02-27 22:20:15 +00001419 verbose):
rmistry@google.com5626a922015-02-26 14:03:30 +00001420 """Execute the post upload hook.
1421
1422 Args:
1423 change: The Change object.
Edward Lemur016a0872020-02-04 22:13:28 +00001424 gerrit_obj: The GerritAccessor object.
rmistry@google.com5626a922015-02-26 14:03:30 +00001425 verbose: Prints debug info.
rmistry@google.com5626a922015-02-26 14:03:30 +00001426 """
1427 presubmit_files = ListRelevantPresubmitFiles(
Edward Lemur6eb1d322020-02-27 22:20:15 +00001428 change.LocalPaths(), change.RepositoryRoot())
rmistry@google.com5626a922015-02-26 14:03:30 +00001429 if not presubmit_files and verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001430 sys.stdout.write('Warning, no PRESUBMIT.py found.\n')
rmistry@google.com5626a922015-02-26 14:03:30 +00001431 results = []
1432 executer = GetPostUploadExecuter()
1433 # The root presubmit file should be executed after the ones in subdirectories.
1434 # i.e. the specific post upload hooks should run before the general ones.
1435 # Thus, reverse the order provided by ListRelevantPresubmitFiles.
1436 presubmit_files.reverse()
1437
1438 for filename in presubmit_files:
1439 filename = os.path.abspath(filename)
1440 if verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001441 sys.stdout.write('Running %s\n' % filename)
rmistry@google.com5626a922015-02-26 14:03:30 +00001442 # Accept CRLF presubmit script.
1443 presubmit_script = gclient_utils.FileRead(filename, 'rU')
1444 results.extend(executer.ExecPresubmitScript(
Edward Lemur016a0872020-02-04 22:13:28 +00001445 presubmit_script, filename, gerrit_obj, change))
rmistry@google.com5626a922015-02-26 14:03:30 +00001446
Edward Lemur6eb1d322020-02-27 22:20:15 +00001447 if not results:
1448 return 0
1449
1450 sys.stdout.write('\n')
1451 sys.stdout.write('** Post Upload Hook Messages **\n')
1452
1453 exit_code = 0
1454 for result in results:
1455 if result.fatal:
1456 exit_code = 1
1457 result.handle()
1458 sys.stdout.write('\n')
1459
1460 return exit_code
rmistry@google.com5626a922015-02-26 14:03:30 +00001461
1462
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001463class PresubmitExecuter(object):
Aaron Gable668c1d82018-04-03 10:19:16 -07001464 def __init__(self, change, committing, verbose,
Edward Lesmes8e282792018-04-03 18:50:29 -04001465 gerrit_obj, dry_run=None, thread_pool=None, parallel=False):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001466 """
1467 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001468 change: The Change object.
agable92bec4f2016-08-24 09:27:27 -07001469 committing: True if 'git cl land' is running, False if 'git cl upload' is.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001470 gerrit_obj: provides basic Gerrit codereview functionality.
1471 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -04001472 parallel: if true, all tests reported via input_api.RunTests for all
1473 PRESUBMIT files will be run in parallel.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001474 """
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001475 self.change = change
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001476 self.committing = committing
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001477 self.gerrit = gerrit_obj
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001478 self.verbose = verbose
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001479 self.dry_run = dry_run
Daniel Cheng7227d212017-11-17 08:12:37 -08001480 self.more_cc = []
Edward Lesmes8e282792018-04-03 18:50:29 -04001481 self.thread_pool = thread_pool
1482 self.parallel = parallel
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001483
1484 def ExecPresubmitScript(self, script_text, presubmit_path):
1485 """Executes a single presubmit script.
1486
1487 Args:
1488 script_text: The text of the presubmit script.
1489 presubmit_path: The path to the presubmit file (this will be reported via
1490 input_api.PresubmitLocalPath()).
1491
1492 Return:
1493 A list of result objects, empty if no problems.
1494 """
thakis@chromium.orgc6ef53a2014-11-04 00:13:54 +00001495
chase@chromium.org8e416c82009-10-06 04:30:44 +00001496 # Change to the presubmit file's directory to support local imports.
1497 main_path = os.getcwd()
1498 os.chdir(os.path.dirname(presubmit_path))
1499
1500 # Load the presubmit script into context.
dpranke@chromium.org970c5222011-03-12 00:32:24 +00001501 input_api = InputApi(self.change, presubmit_path, self.committing,
Aaron Gable668c1d82018-04-03 10:19:16 -07001502 self.verbose, gerrit_obj=self.gerrit,
Edward Lesmes8e282792018-04-03 18:50:29 -04001503 dry_run=self.dry_run, thread_pool=self.thread_pool,
1504 parallel=self.parallel)
Daniel Cheng7227d212017-11-17 08:12:37 -08001505 output_api = OutputApi(self.committing)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001506 context = {}
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001507 try:
Raul Tambre09e64b42019-05-14 01:57:22 +00001508 exec(compile(script_text, 'PRESUBMIT.py', 'exec', dont_inherit=True),
1509 context)
Raul Tambre7c938462019-05-24 16:35:35 +00001510 except Exception as e:
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001511 raise PresubmitFailure('"%s" had an exception.\n%s' % (presubmit_path, e))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001512
1513 # These function names must change if we make substantial changes to
1514 # the presubmit API that are not backwards compatible.
1515 if self.committing:
1516 function_name = 'CheckChangeOnCommit'
1517 else:
1518 function_name = 'CheckChangeOnUpload'
1519 if function_name in context:
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +01001520 try:
Daniel Cheng7227d212017-11-17 08:12:37 -08001521 context['__args'] = (input_api, output_api)
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +01001522 logging.debug('Running %s in %s', function_name, presubmit_path)
1523 result = eval(function_name + '(*__args)', context)
1524 logging.debug('Running %s done.', function_name)
Daniel Chengd36fce42017-11-21 21:52:52 -08001525 self.more_cc.extend(output_api.more_cc)
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +01001526 finally:
Edward Lemurb9830242019-10-30 22:19:20 +00001527 for f in input_api._named_temporary_files:
1528 os.remove(f)
1529 if not isinstance(result, (tuple, list)):
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001530 raise PresubmitFailure(
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001531 'Presubmit functions must return a tuple or list')
1532 for item in result:
1533 if not isinstance(item, OutputApi.PresubmitResult):
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001534 raise PresubmitFailure(
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001535 'All presubmit results must be of types derived from '
1536 'output_api.PresubmitResult')
1537 else:
1538 result = () # no error since the script doesn't care about current event.
1539
chase@chromium.org8e416c82009-10-06 04:30:44 +00001540 # Return the process to the original working directory.
1541 os.chdir(main_path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001542 return result
1543
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001544def DoPresubmitChecks(change,
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001545 committing,
1546 verbose,
maruel@chromium.orgb0dfd352009-06-10 14:12:54 +00001547 default_presubmit,
dpranke@chromium.org970c5222011-03-12 00:32:24 +00001548 may_prompt,
Aaron Gable668c1d82018-04-03 10:19:16 -07001549 gerrit_obj,
Edward Lesmes8e282792018-04-03 18:50:29 -04001550 dry_run=None,
Debrian Figueroadd2737e2019-06-21 23:50:13 +00001551 parallel=False,
1552 json_output=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001553 """Runs all presubmit checks that apply to the files in the change.
1554
1555 This finds all PRESUBMIT.py files in directories enclosing the files in the
1556 change (up to the repository root) and calls the relevant entrypoint function
1557 depending on whether the change is being committed or uploaded.
1558
1559 Prints errors, warnings and notifications. Prompts the user for warnings
1560 when needed.
1561
1562 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001563 change: The Change object.
agable92bec4f2016-08-24 09:27:27 -07001564 committing: True if 'git cl land' is running, False if 'git cl upload' is.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001565 verbose: Prints debug info.
maruel@chromium.org0ff1fab2009-05-22 13:08:15 +00001566 default_presubmit: A default presubmit script to execute in any case.
Quinten Yearsley516fe7f2016-12-14 11:50:18 -08001567 may_prompt: Enable (y/n) questions on warning or error. If False,
1568 any questions are answered with yes by default.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001569 gerrit_obj: provides basic Gerrit codereview functionality.
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001570 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -04001571 parallel: if true, all tests specified by input_api.RunTests in all
1572 PRESUBMIT files will be run in parallel.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001573
1574 Return:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001575 1 if presubmit checks failed or 0 otherwise.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001576 """
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001577 old_environ = os.environ
1578 try:
1579 # Make sure python subprocesses won't generate .pyc files.
1580 os.environ = os.environ.copy()
Edward Lemurb9830242019-10-30 22:19:20 +00001581 os.environ['PYTHONDONTWRITEBYTECODE'] = '1'
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001582
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001583 if committing:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001584 sys.stdout.write('Running presubmit commit checks ...\n')
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001585 else:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001586 sys.stdout.write('Running presubmit upload checks ...\n')
Edward Lemurecc27072020-01-06 16:42:34 +00001587 start_time = time_time()
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001588 presubmit_files = ListRelevantPresubmitFiles(
agable0b65e732016-11-22 09:25:46 -08001589 change.AbsoluteLocalPaths(), change.RepositoryRoot())
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001590 if not presubmit_files and verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001591 sys.stdout.write('Warning, no PRESUBMIT.py found.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001592 results = []
Edward Lesmes8e282792018-04-03 18:50:29 -04001593 thread_pool = ThreadPool()
Edward Lemur7e3c67f2018-07-20 20:52:49 +00001594 executer = PresubmitExecuter(change, committing, verbose, gerrit_obj,
1595 dry_run, thread_pool, parallel)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001596 if default_presubmit:
1597 if verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001598 sys.stdout.write('Running default presubmit script.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001599 fake_path = os.path.join(change.RepositoryRoot(), 'PRESUBMIT.py')
1600 results += executer.ExecPresubmitScript(default_presubmit, fake_path)
1601 for filename in presubmit_files:
1602 filename = os.path.abspath(filename)
1603 if verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001604 sys.stdout.write('Running %s\n' % filename)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001605 # Accept CRLF presubmit script.
1606 presubmit_script = gclient_utils.FileRead(filename, 'rU')
1607 results += executer.ExecPresubmitScript(presubmit_script, filename)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001608
Edward Lesmes8e282792018-04-03 18:50:29 -04001609 results += thread_pool.RunAsync()
1610
Edward Lemur6eb1d322020-02-27 22:20:15 +00001611 messages = {}
1612 should_prompt = False
1613 presubmits_failed = False
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001614 for result in results:
1615 if result.fatal:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001616 presubmits_failed = True
1617 messages.setdefault('ERRORS', []).append(result)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001618 elif result.should_prompt:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001619 should_prompt = True
1620 messages.setdefault('Warnings', []).append(result)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001621 else:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001622 messages.setdefault('Messages', []).append(result)
pam@chromium.orged9a0832009-09-09 22:48:55 +00001623
Edward Lemur6eb1d322020-02-27 22:20:15 +00001624 sys.stdout.write('\n')
1625 for name, items in messages.items():
1626 sys.stdout.write('** Presubmit %s **\n' % name)
1627 for item in items:
1628 item.handle()
1629 sys.stdout.write('\n')
pam@chromium.orged9a0832009-09-09 22:48:55 +00001630
Edward Lemurecc27072020-01-06 16:42:34 +00001631 total_time = time_time() - start_time
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001632 if total_time > 1.0:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001633 sys.stdout.write(
1634 'Presubmit checks took %.1fs to calculate.\n\n' % total_time)
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +00001635
Edward Lemur6eb1d322020-02-27 22:20:15 +00001636 if not should_prompt and not presubmits_failed:
1637 sys.stdout.write('Presubmit checks passed.\n')
1638 elif should_prompt:
1639 sys.stdout.write('There were presubmit warnings. ')
Quinten Yearsley516fe7f2016-12-14 11:50:18 -08001640 if may_prompt:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001641 presubmits_failed = not prompt_should_continue(
1642 'Are you sure you wish to continue? (y/N): ')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001643
Edward Lemur1dc66e12020-02-21 21:36:34 +00001644 if json_output:
1645 # Write the presubmit results to json output
1646 presubmit_results = {
1647 'errors': [
Edward Lemur6eb1d322020-02-27 22:20:15 +00001648 error.json_format()
1649 for error in messages.get('ERRORS', [])
Edward Lemur1dc66e12020-02-21 21:36:34 +00001650 ],
1651 'notifications': [
Edward Lemur6eb1d322020-02-27 22:20:15 +00001652 notification.json_format()
1653 for notification in messages.get('Messages', [])
Edward Lemur1dc66e12020-02-21 21:36:34 +00001654 ],
1655 'warnings': [
Edward Lemur6eb1d322020-02-27 22:20:15 +00001656 warning.json_format()
1657 for warning in messages.get('Warnings', [])
Edward Lemur1dc66e12020-02-21 21:36:34 +00001658 ],
Edward Lemur6eb1d322020-02-27 22:20:15 +00001659 'more_cc': executer.more_cc,
Edward Lemur1dc66e12020-02-21 21:36:34 +00001660 }
1661
1662 gclient_utils.FileWrite(
1663 json_output, json.dumps(presubmit_results, sort_keys=True))
1664
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001665 global _ASKED_FOR_FEEDBACK
1666 # Ask for feedback one time out of 5.
1667 if (len(results) and random.randint(0, 4) == 0 and not _ASKED_FOR_FEEDBACK):
Edward Lemur6eb1d322020-02-27 22:20:15 +00001668 sys.stdout.write(
maruel@chromium.org1ce8e662014-01-14 15:23:00 +00001669 'Was the presubmit check useful? If not, run "git cl presubmit -v"\n'
1670 'to figure out which PRESUBMIT.py was run, then run git blame\n'
1671 'on the file to figure out who to ask for help.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001672 _ASKED_FOR_FEEDBACK = True
Edward Lemur6eb1d322020-02-27 22:20:15 +00001673
1674 return 1 if presubmits_failed else 0
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001675 finally:
1676 os.environ = old_environ
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001677
1678
Edward Lemur50984a62020-02-06 18:10:18 +00001679def _scan_sub_dirs(mask, recursive):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001680 if not recursive:
pgervais@chromium.orge57b09d2014-05-07 00:58:13 +00001681 return [x for x in glob.glob(mask) if x not in ('.svn', '.git')]
Lei Zhang9611c4c2017-04-04 01:41:56 -07001682
1683 results = []
1684 for root, dirs, files in os.walk('.'):
1685 if '.svn' in dirs:
1686 dirs.remove('.svn')
1687 if '.git' in dirs:
1688 dirs.remove('.git')
1689 for name in files:
1690 if fnmatch.fnmatch(name, mask):
1691 results.append(os.path.join(root, name))
1692 return results
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001693
1694
Edward Lemur50984a62020-02-06 18:10:18 +00001695def _parse_files(args, recursive):
tobiasjs2836bcf2016-08-16 04:08:16 -07001696 logging.debug('Searching for %s', args)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001697 files = []
1698 for arg in args:
Edward Lemur50984a62020-02-06 18:10:18 +00001699 files.extend([('M', f) for f in _scan_sub_dirs(arg, recursive)])
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001700 return files
1701
1702
Edward Lemur50984a62020-02-06 18:10:18 +00001703def _parse_change(parser, options):
1704 """Process change options.
1705
1706 Args:
1707 parser: The parser used to parse the arguments from command line.
1708 options: The arguments parsed from command line.
1709 Returns:
1710 A GitChange if the change root is a git repository, or a Change otherwise.
1711 """
1712 if options.files and options.all_files:
1713 parser.error('<files> cannot be specified when --all-files is set.')
1714
Edward Lesmes44ea3ff2020-02-05 00:14:30 +00001715 change_scm = scm.determine_scm(options.root)
Edward Lemur50984a62020-02-06 18:10:18 +00001716 if change_scm != 'git' and not options.files:
1717 parser.error('<files> is not optional for unversioned directories.')
1718
1719 if options.files:
1720 change_files = _parse_files(options.files, options.recursive)
1721 elif options.all_files:
1722 change_files = [('M', f) for f in scm.GIT.GetAllFiles(options.root)]
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001723 else:
Edward Lemur50984a62020-02-06 18:10:18 +00001724 change_files = scm.GIT.CaptureStatus(
Edward Lemur7f6dec02020-02-06 20:23:58 +00001725 options.root, options.upstream or None)
Edward Lemur50984a62020-02-06 18:10:18 +00001726
1727 logging.info('Found %d file(s).', len(change_files))
1728
1729 change_class = GitChange if change_scm == 'git' else Change
1730 return change_class(
1731 options.name,
1732 options.description,
1733 options.root,
1734 change_files,
1735 options.issue,
1736 options.patchset,
1737 options.author,
1738 upstream=options.upstream)
1739
1740
1741def _parse_gerrit_options(parser, options):
1742 """Process gerrit options.
1743
1744 SIDE EFFECTS: Modifies options.author and options.description from Gerrit if
1745 options.gerrit_fetch is set.
1746
1747 Args:
1748 parser: The parser used to parse the arguments from command line.
1749 options: The arguments parsed from command line.
1750 Returns:
1751 A GerritAccessor object if options.gerrit_url is set, or None otherwise.
1752 """
1753 gerrit_obj = None
1754 if options.gerrit_url:
1755 gerrit_obj = GerritAccessor(urlparse.urlparse(options.gerrit_url).netloc)
1756
1757 if not options.gerrit_fetch:
1758 return gerrit_obj
1759
1760 if not options.gerrit_url or not options.issue or not options.patchset:
1761 parser.error(
1762 '--gerrit_fetch requires --gerrit_url, --issue and --patchset.')
1763
1764 options.author = gerrit_obj.GetChangeOwner(options.issue)
1765 options.description = gerrit_obj.GetChangeDescription(
1766 options.issue, options.patchset)
1767
1768 logging.info('Got author: "%s"', options.author)
1769 logging.info('Got description: """\n%s\n"""', options.description)
1770
1771 return gerrit_obj
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001772
1773
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001774@contextlib.contextmanager
1775def canned_check_filter(method_names):
1776 filtered = {}
1777 try:
1778 for method_name in method_names:
1779 if not hasattr(presubmit_canned_checks, method_name):
Aaron Gableecee74c2018-04-02 15:13:08 -07001780 logging.warn('Skipping unknown "canned" check %s' % method_name)
1781 continue
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001782 filtered[method_name] = getattr(presubmit_canned_checks, method_name)
1783 setattr(presubmit_canned_checks, method_name, lambda *_a, **_kw: [])
1784 yield
1785 finally:
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001786 for name, method in filtered.items():
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001787 setattr(presubmit_canned_checks, name, method)
1788
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +00001789
sbc@chromium.org013731e2015-02-26 18:28:43 +00001790def main(argv=None):
Edward Lemura5799e32020-01-17 19:26:51 +00001791 parser = argparse.ArgumentParser(usage='%(prog)s [options] <files...>')
1792 hooks = parser.add_mutually_exclusive_group()
1793 hooks.add_argument('-c', '--commit', action='store_true',
1794 help='Use commit instead of upload checks.')
1795 hooks.add_argument('-u', '--upload', action='store_false', dest='commit',
1796 help='Use upload instead of commit checks.')
Edward Lemur75526302020-02-27 22:31:05 +00001797 hooks.add_argument('--post_upload', action='store_true',
1798 help='Run post-upload commit hooks.')
Edward Lemura5799e32020-01-17 19:26:51 +00001799 parser.add_argument('-r', '--recursive', action='store_true',
1800 help='Act recursively.')
1801 parser.add_argument('-v', '--verbose', action='count', default=0,
1802 help='Use 2 times for more debug info.')
1803 parser.add_argument('--name', default='no name')
1804 parser.add_argument('--author')
Edward Lemur227d5102020-02-25 23:45:35 +00001805 desc = parser.add_mutually_exclusive_group()
1806 desc.add_argument('--description', default='', help='The change description.')
1807 desc.add_argument('--description_file',
1808 help='File to read change description from.')
Edward Lemura5799e32020-01-17 19:26:51 +00001809 parser.add_argument('--issue', type=int, default=0)
1810 parser.add_argument('--patchset', type=int, default=0)
1811 parser.add_argument('--root', default=os.getcwd(),
1812 help='Search for PRESUBMIT.py up to this directory. '
1813 'If inherit-review-settings-ok is present in this '
1814 'directory, parent directories up to the root file '
1815 'system directories will also be searched.')
1816 parser.add_argument('--upstream',
1817 help='Git only: the base ref or upstream branch against '
1818 'which the diff should be computed.')
1819 parser.add_argument('--default_presubmit')
1820 parser.add_argument('--may_prompt', action='store_true', default=False)
1821 parser.add_argument('--skip_canned', action='append', default=[],
1822 help='A list of checks to skip which appear in '
1823 'presubmit_canned_checks. Can be provided multiple times '
1824 'to skip multiple canned checks.')
1825 parser.add_argument('--dry_run', action='store_true', help=argparse.SUPPRESS)
1826 parser.add_argument('--gerrit_url', help=argparse.SUPPRESS)
1827 parser.add_argument('--gerrit_fetch', action='store_true',
1828 help=argparse.SUPPRESS)
1829 parser.add_argument('--parallel', action='store_true',
1830 help='Run all tests specified by input_api.RunTests in '
1831 'all PRESUBMIT files in parallel.')
1832 parser.add_argument('--json_output',
1833 help='Write presubmit errors to json output.')
Edward Lemur1dc66e12020-02-21 21:36:34 +00001834 parser.add_argument('--all_files', action='store_true',
Edward Lemur50984a62020-02-06 18:10:18 +00001835 help='Mark all files under source control as modified.')
Edward Lemura5799e32020-01-17 19:26:51 +00001836 parser.add_argument('files', nargs='*',
1837 help='List of files to be marked as modified when '
1838 'executing presubmit or post-upload hooks. fnmatch '
1839 'wildcards can also be used.')
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001840
Edward Lemura5799e32020-01-17 19:26:51 +00001841 options = parser.parse_args(argv)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001842
Erik Staabcca5c492020-04-16 17:40:07 +00001843 log_level = logging.ERROR
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001844 if options.verbose >= 2:
Erik Staabcca5c492020-04-16 17:40:07 +00001845 log_level = logging.DEBUG
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001846 elif options.verbose:
Erik Staabcca5c492020-04-16 17:40:07 +00001847 log_level = logging.INFO
1848 log_format = ('[%(levelname).1s%(asctime)s %(process)d %(thread)d '
1849 '%(filename)s] %(message)s')
1850 logging.basicConfig(format=log_format, level=log_level)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001851
Edward Lemur227d5102020-02-25 23:45:35 +00001852 if options.description_file:
1853 options.description = gclient_utils.FileRead(options.description_file)
Edward Lemur50984a62020-02-06 18:10:18 +00001854 gerrit_obj = _parse_gerrit_options(parser, options)
1855 change = _parse_change(parser, options)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001856
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001857 try:
Edward Lemur75526302020-02-27 22:31:05 +00001858 if options.post_upload:
1859 return DoPostUploadExecuter(
1860 change,
1861 gerrit_obj,
1862 options.verbose)
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001863 with canned_check_filter(options.skip_canned):
Edward Lemur6eb1d322020-02-27 22:20:15 +00001864 return DoPresubmitChecks(
Edward Lemur50984a62020-02-06 18:10:18 +00001865 change,
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001866 options.commit,
1867 options.verbose,
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001868 options.default_presubmit,
1869 options.may_prompt,
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001870 gerrit_obj,
Edward Lesmes8e282792018-04-03 18:50:29 -04001871 options.dry_run,
Debrian Figueroadd2737e2019-06-21 23:50:13 +00001872 options.parallel,
1873 options.json_output)
Raul Tambre7c938462019-05-24 16:35:35 +00001874 except PresubmitFailure as e:
Raul Tambre80ee78e2019-05-06 22:41:05 +00001875 print(e, file=sys.stderr)
1876 print('Maybe your depot_tools is out of date?', file=sys.stderr)
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001877 return 2
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001878
1879
1880if __name__ == '__main__':
maruel@chromium.org35625c72011-03-23 17:34:02 +00001881 fix_encoding.fix_encoding()
sbc@chromium.org013731e2015-02-26 18:28:43 +00001882 try:
1883 sys.exit(main())
1884 except KeyboardInterrupt:
1885 sys.stderr.write('interrupted\n')
sergiybf8a3b382016-07-05 11:21:30 -07001886 sys.exit(2)