blob: 71264ecd8aa7de8ba93615deed847fd8a9df084b [file] [log] [blame]
maruel@chromium.org725f1c32011-04-01 20:24:54 +00001#!/usr/bin/env python
maruel@chromium.org3bbf2942012-01-10 16:52:06 +00002# Copyright (c) 2012 The Chromium Authors. All rights reserved.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00003# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5
6"""Enables directory-specific presubmit checks to run at upload and/or commit.
7"""
8
Raul Tambre80ee78e2019-05-06 22:41:05 +00009from __future__ import print_function
10
stip@chromium.orgf7d31f52014-01-03 20:14:46 +000011__version__ = '1.8.0'
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000012
13# TODO(joi) Add caching where appropriate/needed. The API is designed to allow
14# caching (between all different invocations of presubmit scripts for a given
15# change). We should add it as our presubmit scripts start feeling slow.
16
Edward Lemura5799e32020-01-17 19:26:51 +000017import argparse
Takeshi Yoshino07a6bea2017-08-02 02:44:06 +090018import ast # Exposed through the API.
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +000019import contextlib
Yoshisato Yanagisawa406de132018-06-29 05:43:25 +000020import cpplint
dcheng091b7db2016-06-16 01:27:51 -070021import fnmatch # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000022import glob
asvitkine@chromium.org15169952011-09-27 14:30:53 +000023import inspect
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +000024import itertools
maruel@chromium.org4f6852c2012-04-20 20:39:20 +000025import json # Exposed through the API.
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +000026import logging
ilevy@chromium.orgbc117312013-04-20 03:57:56 +000027import multiprocessing
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000028import os # Somewhat exposed through the API.
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +000029import random
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000030import re # Exposed through the API.
Edward Lesmes8e282792018-04-03 18:50:29 -040031import signal
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000032import sys # Parts exposed through API.
33import tempfile # Exposed through the API.
Edward Lesmes8e282792018-04-03 18:50:29 -040034import threading
jam@chromium.org2a891dc2009-08-20 20:33:37 +000035import time
Edward Lemurde9e3ca2019-10-24 21:13:31 +000036import traceback
maruel@chromium.org1487d532009-06-06 00:22:57 +000037import unittest # Exposed through the API.
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +000038from warnings import warn
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000039
40# Local imports.
maruel@chromium.org35625c72011-03-23 17:34:02 +000041import fix_encoding
Yoshisato Yanagisawa04600b42019-03-15 03:03:41 +000042import gclient_paths # Exposed through the API
43import gclient_utils
Aaron Gableb584c4f2017-04-26 16:28:08 -070044import git_footers
tandrii@chromium.org015ebae2016-04-25 19:37:22 +000045import gerrit_util
dpranke@chromium.org2a009622011-03-01 02:43:31 +000046import owners
Jochen Eisinger76f5fc62017-04-07 16:27:46 +020047import owners_finder
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000048import presubmit_canned_checks
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +000049import scm
maruel@chromium.org84f4fe32011-04-06 13:26:45 +000050import subprocess2 as subprocess # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000051
Edward Lemur16af3562019-10-17 22:11:33 +000052if sys.version_info.major == 2:
53 # TODO(1009814): Expose urllib2 only through urllib_request and urllib_error
54 import urllib2 # Exposed through the API.
55 import urlparse
56 import urllib2 as urllib_request
57 import urllib2 as urllib_error
58else:
59 import urllib.parse as urlparse
60 import urllib.request as urllib_request
61 import urllib.error as urllib_error
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000062
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +000063# Ask for feedback only once in program lifetime.
64_ASKED_FOR_FEEDBACK = False
65
66
Edward Lemurecc27072020-01-06 16:42:34 +000067def time_time():
68 # Use this so that it can be mocked in tests without interfering with python
69 # system machinery.
70 return time.time()
71
72
maruel@chromium.org899e1c12011-04-07 17:03:18 +000073class PresubmitFailure(Exception):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000074 pass
75
76
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000077class CommandData(object):
Edward Lemur940c2822019-08-23 00:34:25 +000078 def __init__(self, name, cmd, kwargs, message, python3=False):
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000079 self.name = name
80 self.cmd = cmd
Edward Lesmes8e282792018-04-03 18:50:29 -040081 self.stdin = kwargs.get('stdin', None)
Edward Lemur2d6b67c2019-08-23 22:25:41 +000082 self.kwargs = kwargs.copy()
Edward Lesmes8e282792018-04-03 18:50:29 -040083 self.kwargs['stdout'] = subprocess.PIPE
84 self.kwargs['stderr'] = subprocess.STDOUT
85 self.kwargs['stdin'] = subprocess.PIPE
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000086 self.message = message
87 self.info = None
Edward Lemur940c2822019-08-23 00:34:25 +000088 self.python3 = python3
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000089
ilevy@chromium.orgbc117312013-04-20 03:57:56 +000090
Edward Lesmes8e282792018-04-03 18:50:29 -040091# Adapted from
92# https://github.com/google/gtest-parallel/blob/master/gtest_parallel.py#L37
93#
94# An object that catches SIGINT sent to the Python process and notices
95# if processes passed to wait() die by SIGINT (we need to look for
96# both of those cases, because pressing Ctrl+C can result in either
97# the main process or one of the subprocesses getting the signal).
98#
99# Before a SIGINT is seen, wait(p) will simply call p.wait() and
100# return the result. Once a SIGINT has been seen (in the main process
101# or a subprocess, including the one the current call is waiting for),
Edward Lemur9a5bb612019-09-26 02:01:52 +0000102# wait(p) will call p.terminate().
Edward Lesmes8e282792018-04-03 18:50:29 -0400103class SigintHandler(object):
Edward Lesmes8e282792018-04-03 18:50:29 -0400104 sigint_returncodes = {-signal.SIGINT, # Unix
105 -1073741510, # Windows
106 }
107 def __init__(self):
108 self.__lock = threading.Lock()
109 self.__processes = set()
110 self.__got_sigint = False
Edward Lemur9a5bb612019-09-26 02:01:52 +0000111 self.__previous_signal = signal.signal(signal.SIGINT, self.interrupt)
Edward Lesmes8e282792018-04-03 18:50:29 -0400112
113 def __on_sigint(self):
114 self.__got_sigint = True
115 while self.__processes:
116 try:
117 self.__processes.pop().terminate()
118 except OSError:
119 pass
120
Edward Lemur9a5bb612019-09-26 02:01:52 +0000121 def interrupt(self, signal_num, frame):
Edward Lesmes8e282792018-04-03 18:50:29 -0400122 with self.__lock:
123 self.__on_sigint()
Edward Lemur9a5bb612019-09-26 02:01:52 +0000124 self.__previous_signal(signal_num, frame)
Edward Lesmes8e282792018-04-03 18:50:29 -0400125
126 def got_sigint(self):
127 with self.__lock:
128 return self.__got_sigint
129
130 def wait(self, p, stdin):
131 with self.__lock:
132 if self.__got_sigint:
133 p.terminate()
134 self.__processes.add(p)
135 stdout, stderr = p.communicate(stdin)
136 code = p.returncode
137 with self.__lock:
138 self.__processes.discard(p)
139 if code in self.sigint_returncodes:
140 self.__on_sigint()
Edward Lesmes8e282792018-04-03 18:50:29 -0400141 return stdout, stderr
142
143sigint_handler = SigintHandler()
144
145
Edward Lemurecc27072020-01-06 16:42:34 +0000146class Timer(object):
147 def __init__(self, timeout, fn):
148 self.completed = False
149 self._fn = fn
150 self._timer = threading.Timer(timeout, self._onTimer) if timeout else None
151
152 def __enter__(self):
153 if self._timer:
154 self._timer.start()
155 return self
156
157 def __exit__(self, _type, _value, _traceback):
158 if self._timer:
159 self._timer.cancel()
160
161 def _onTimer(self):
162 self._fn()
163 self.completed = True
164
165
Edward Lesmes8e282792018-04-03 18:50:29 -0400166class ThreadPool(object):
Edward Lemurecc27072020-01-06 16:42:34 +0000167 def __init__(self, pool_size=None, timeout=None):
168 self.timeout = timeout
Edward Lesmes8e282792018-04-03 18:50:29 -0400169 self._pool_size = pool_size or multiprocessing.cpu_count()
170 self._messages = []
171 self._messages_lock = threading.Lock()
172 self._tests = []
173 self._tests_lock = threading.Lock()
174 self._nonparallel_tests = []
175
Edward Lemurecc27072020-01-06 16:42:34 +0000176 def _GetCommand(self, test):
Edward Lemur940c2822019-08-23 00:34:25 +0000177 vpython = 'vpython'
178 if test.python3:
179 vpython += '3'
180 if sys.platform == 'win32':
181 vpython += '.bat'
Edward Lesmes8e282792018-04-03 18:50:29 -0400182
183 cmd = test.cmd
184 if cmd[0] == 'python':
185 cmd = list(cmd)
186 cmd[0] = vpython
187 elif cmd[0].endswith('.py'):
188 cmd = [vpython] + cmd
189
Edward Lemur336e51f2019-11-14 21:42:04 +0000190 # On Windows, scripts on the current directory take precedence over PATH, so
191 # that when testing depot_tools on Windows, calling `vpython.bat` will
192 # execute the copy of vpython of the depot_tools under test instead of the
193 # one in the bot.
194 # As a workaround, we run the tests from the parent directory instead.
195 if (cmd[0] == vpython and
196 'cwd' in test.kwargs and
197 os.path.basename(test.kwargs['cwd']) == 'depot_tools'):
198 test.kwargs['cwd'] = os.path.dirname(test.kwargs['cwd'])
199 cmd[1] = os.path.join('depot_tools', cmd[1])
200
Edward Lemurecc27072020-01-06 16:42:34 +0000201 return cmd
202
203 def _RunWithTimeout(self, cmd, stdin, kwargs):
204 p = subprocess.Popen(cmd, **kwargs)
205 with Timer(self.timeout, p.terminate) as timer:
206 stdout, _ = sigint_handler.wait(p, stdin)
207 if timer.completed:
208 stdout = 'Process timed out after %ss\n%s' % (self.timeout, stdout)
209 return p.returncode, stdout
210
211 def CallCommand(self, test):
212 """Runs an external program.
213
Edward Lemura5799e32020-01-17 19:26:51 +0000214 This function converts invocation of .py files and invocations of 'python'
Edward Lemurecc27072020-01-06 16:42:34 +0000215 to vpython invocations.
216 """
217 cmd = self._GetCommand(test)
Edward Lesmes8e282792018-04-03 18:50:29 -0400218 try:
Edward Lemurecc27072020-01-06 16:42:34 +0000219 start = time_time()
220 returncode, stdout = self._RunWithTimeout(cmd, test.stdin, test.kwargs)
221 duration = time_time() - start
Edward Lemur7cf94382019-11-15 22:36:41 +0000222 except Exception:
Edward Lemurecc27072020-01-06 16:42:34 +0000223 duration = time_time() - start
Edward Lesmes8e282792018-04-03 18:50:29 -0400224 return test.message(
Edward Lemur7cf94382019-11-15 22:36:41 +0000225 '%s\n%s exec failure (%4.2fs)\n%s' % (
226 test.name, ' '.join(cmd), duration, traceback.format_exc()))
Edward Lemurde9e3ca2019-10-24 21:13:31 +0000227
Edward Lemurecc27072020-01-06 16:42:34 +0000228 if returncode != 0:
Edward Lesmes8e282792018-04-03 18:50:29 -0400229 return test.message(
Edward Lemur7cf94382019-11-15 22:36:41 +0000230 '%s\n%s (%4.2fs) failed\n%s' % (
231 test.name, ' '.join(cmd), duration, stdout))
Edward Lemurecc27072020-01-06 16:42:34 +0000232
Edward Lesmes8e282792018-04-03 18:50:29 -0400233 if test.info:
Edward Lemur7cf94382019-11-15 22:36:41 +0000234 return test.info('%s\n%s (%4.2fs)' % (test.name, ' '.join(cmd), duration))
Edward Lesmes8e282792018-04-03 18:50:29 -0400235
236 def AddTests(self, tests, parallel=True):
237 if parallel:
238 self._tests.extend(tests)
239 else:
240 self._nonparallel_tests.extend(tests)
241
242 def RunAsync(self):
243 self._messages = []
244
245 def _WorkerFn():
246 while True:
247 test = None
248 with self._tests_lock:
249 if not self._tests:
250 break
251 test = self._tests.pop()
252 result = self.CallCommand(test)
253 if result:
254 with self._messages_lock:
255 self._messages.append(result)
256
257 def _StartDaemon():
258 t = threading.Thread(target=_WorkerFn)
259 t.daemon = True
260 t.start()
261 return t
262
263 while self._nonparallel_tests:
264 test = self._nonparallel_tests.pop()
265 result = self.CallCommand(test)
266 if result:
267 self._messages.append(result)
268
269 if self._tests:
270 threads = [_StartDaemon() for _ in range(self._pool_size)]
271 for worker in threads:
272 worker.join()
273
274 return self._messages
275
276
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000277def normpath(path):
278 '''Version of os.path.normpath that also changes backward slashes to
279 forward slashes when not running on Windows.
280 '''
281 # This is safe to always do because the Windows version of os.path.normpath
282 # will replace forward slashes with backward slashes.
283 path = path.replace(os.sep, '/')
284 return os.path.normpath(path)
285
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000286
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000287def _RightHandSideLinesImpl(affected_files):
288 """Implements RightHandSideLines for InputApi and GclChange."""
289 for af in affected_files:
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000290 lines = af.ChangedContents()
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000291 for line in lines:
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000292 yield (af, line[0], line[1])
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000293
294
dpranke@chromium.org5ac21012011-03-16 02:58:25 +0000295class PresubmitOutput(object):
296 def __init__(self, input_stream=None, output_stream=None):
297 self.input_stream = input_stream
298 self.output_stream = output_stream
Daniel Cheng7227d212017-11-17 08:12:37 -0800299 self.more_cc = []
dpranke@chromium.org5ac21012011-03-16 02:58:25 +0000300 self.written_output = []
301 self.error_count = 0
302
303 def prompt_yes_no(self, prompt_string):
304 self.write(prompt_string)
305 if self.input_stream:
306 response = self.input_stream.readline().strip().lower()
307 if response not in ('y', 'yes'):
308 self.fail()
309 else:
310 self.fail()
311
312 def fail(self):
313 self.error_count += 1
314
315 def should_continue(self):
316 return not self.error_count
317
318 def write(self, s):
319 self.written_output.append(s)
320 if self.output_stream:
321 self.output_stream.write(s)
322
323 def getvalue(self):
324 return ''.join(self.written_output)
325
326
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000327# Top level object so multiprocessing can pickle
328# Public access through OutputApi object.
329class _PresubmitResult(object):
330 """Base class for result objects."""
331 fatal = False
332 should_prompt = False
333
334 def __init__(self, message, items=None, long_text=''):
335 """
336 message: A short one-line message to indicate errors.
337 items: A list of short strings to indicate where errors occurred.
338 long_text: multi-line text output, e.g. from another tool
339 """
340 self._message = message
341 self._items = items or []
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000342 self._long_text = long_text.rstrip()
343
344 def handle(self, output):
345 output.write(self._message)
346 output.write('\n')
347 for index, item in enumerate(self._items):
348 output.write(' ')
349 # Write separately in case it's unicode.
350 output.write(str(item))
351 if index < len(self._items) - 1:
352 output.write(' \\')
353 output.write('\n')
354 if self._long_text:
355 output.write('\n***************\n')
356 # Write separately in case it's unicode.
357 output.write(self._long_text)
358 output.write('\n***************\n')
359 if self.fatal:
360 output.fail()
361
Debrian Figueroadd2737e2019-06-21 23:50:13 +0000362 def json_format(self):
363 return {
364 'message': self._message,
Debrian Figueroa6095d402019-06-28 18:47:18 +0000365 'items': [str(item) for item in self._items],
Debrian Figueroadd2737e2019-06-21 23:50:13 +0000366 'long_text': self._long_text,
367 'fatal': self.fatal
368 }
369
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000370
371# Top level object so multiprocessing can pickle
372# Public access through OutputApi object.
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000373class _PresubmitError(_PresubmitResult):
374 """A hard presubmit error."""
375 fatal = True
376
377
378# Top level object so multiprocessing can pickle
379# Public access through OutputApi object.
380class _PresubmitPromptWarning(_PresubmitResult):
381 """An warning that prompts the user if they want to continue."""
382 should_prompt = True
383
384
385# Top level object so multiprocessing can pickle
386# Public access through OutputApi object.
387class _PresubmitNotifyResult(_PresubmitResult):
388 """Just print something to the screen -- but it's not even a warning."""
389 pass
390
391
392# Top level object so multiprocessing can pickle
393# Public access through OutputApi object.
394class _MailTextResult(_PresubmitResult):
395 """A warning that should be included in the review request email."""
396 def __init__(self, *args, **kwargs):
397 super(_MailTextResult, self).__init__()
398 raise NotImplementedError()
399
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000400class GerritAccessor(object):
401 """Limited Gerrit functionality for canned presubmit checks to work.
402
403 To avoid excessive Gerrit calls, caches the results.
404 """
405
406 def __init__(self, host):
407 self.host = host
408 self.cache = {}
409
410 def _FetchChangeDetail(self, issue):
411 # Separate function to be easily mocked in tests.
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +0100412 try:
413 return gerrit_util.GetChangeDetail(
414 self.host, str(issue),
Aaron Gable6f5a8d92017-04-18 14:49:05 -0700415 ['ALL_REVISIONS', 'DETAILED_LABELS', 'ALL_COMMITS'])
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +0100416 except gerrit_util.GerritError as e:
417 if e.http_status == 404:
418 raise Exception('Either Gerrit issue %s doesn\'t exist, or '
419 'no credentials to fetch issue details' % issue)
420 raise
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000421
422 def GetChangeInfo(self, issue):
423 """Returns labels and all revisions (patchsets) for this issue.
424
425 The result is a dictionary according to Gerrit REST Api.
426 https://gerrit-review.googlesource.com/Documentation/rest-api.html
427
428 However, API isn't very clear what's inside, so see tests for example.
429 """
430 assert issue
431 cache_key = int(issue)
432 if cache_key not in self.cache:
433 self.cache[cache_key] = self._FetchChangeDetail(issue)
434 return self.cache[cache_key]
435
436 def GetChangeDescription(self, issue, patchset=None):
437 """If patchset is none, fetches current patchset."""
438 info = self.GetChangeInfo(issue)
439 # info is a reference to cache. We'll modify it here adding description to
440 # it to the right patchset, if it is not yet there.
441
442 # Find revision info for the patchset we want.
443 if patchset is not None:
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +0000444 for rev, rev_info in info['revisions'].items():
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000445 if str(rev_info['_number']) == str(patchset):
446 break
447 else:
448 raise Exception('patchset %s doesn\'t exist in issue %s' % (
449 patchset, issue))
450 else:
451 rev = info['current_revision']
452 rev_info = info['revisions'][rev]
453
Andrii Shyshkalov9c3a4642017-01-24 17:41:22 +0100454 return rev_info['commit']['message']
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000455
Mun Yong Jang603d01e2017-12-19 16:38:30 -0800456 def GetDestRef(self, issue):
457 ref = self.GetChangeInfo(issue)['branch']
458 if not ref.startswith('refs/'):
459 # NOTE: it is possible to create 'refs/x' branch,
460 # aka 'refs/heads/refs/x'. However, this is ill-advised.
461 ref = 'refs/heads/%s' % ref
462 return ref
463
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000464 def GetChangeOwner(self, issue):
465 return self.GetChangeInfo(issue)['owner']['email']
466
467 def GetChangeReviewers(self, issue, approving_only=True):
Aaron Gable8b478f02017-07-31 15:33:19 -0700468 changeinfo = self.GetChangeInfo(issue)
469 if approving_only:
470 labelinfo = changeinfo.get('labels', {}).get('Code-Review', {})
471 values = labelinfo.get('values', {}).keys()
472 try:
473 max_value = max(int(v) for v in values)
474 reviewers = [r for r in labelinfo.get('all', [])
475 if r.get('value', 0) == max_value]
476 except ValueError: # values is the empty list
477 reviewers = []
478 else:
479 reviewers = changeinfo.get('reviewers', {}).get('REVIEWER', [])
480 return [r.get('email') for r in reviewers]
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000481
Edward Lemure4d329c2020-02-03 20:41:18 +0000482 def UpdateDescription(self, description, issue):
483 gerrit_util.SetCommitMessage(self.host, issue, description, notify='NONE')
484
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000485
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000486class OutputApi(object):
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000487 """An instance of OutputApi gets passed to presubmit scripts so that they
488 can output various types of results.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000489 """
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000490 PresubmitResult = _PresubmitResult
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000491 PresubmitError = _PresubmitError
492 PresubmitPromptWarning = _PresubmitPromptWarning
493 PresubmitNotifyResult = _PresubmitNotifyResult
494 MailTextResult = _MailTextResult
495
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000496 def __init__(self, is_committing):
497 self.is_committing = is_committing
Daniel Cheng7227d212017-11-17 08:12:37 -0800498 self.more_cc = []
499
500 def AppendCC(self, cc):
501 """Appends a user to cc for this change."""
502 self.more_cc.append(cc)
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000503
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000504 def PresubmitPromptOrNotify(self, *args, **kwargs):
505 """Warn the user when uploading, but only notify if committing."""
506 if self.is_committing:
507 return self.PresubmitNotifyResult(*args, **kwargs)
508 return self.PresubmitPromptWarning(*args, **kwargs)
509
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000510
511class InputApi(object):
512 """An instance of this object is passed to presubmit scripts so they can
513 know stuff about the change they're looking at.
514 """
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000515 # Method could be a function
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800516 # pylint: disable=no-self-use
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000517
maruel@chromium.org3410d912009-06-09 20:56:16 +0000518 # File extensions that are considered source files from a style guide
519 # perspective. Don't modify this list from a presubmit script!
maruel@chromium.orgc33455a2011-06-24 19:14:18 +0000520 #
521 # Files without an extension aren't included in the list. If you want to
Edward Lemura5799e32020-01-17 19:26:51 +0000522 # filter them as source files, add r'(^|.*?[\\\/])[^.]+$' to the white list.
maruel@chromium.orgc33455a2011-06-24 19:14:18 +0000523 # Note that ALL CAPS files are black listed in DEFAULT_BLACK_LIST below.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000524 DEFAULT_WHITE_LIST = (
525 # C++ and friends
Edward Lemura5799e32020-01-17 19:26:51 +0000526 r'.+\.c$', r'.+\.cc$', r'.+\.cpp$', r'.+\.h$', r'.+\.m$', r'.+\.mm$',
527 r'.+\.inl$', r'.+\.asm$', r'.+\.hxx$', r'.+\.hpp$', r'.+\.s$', r'.+\.S$',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000528 # Scripts
Edward Lemura5799e32020-01-17 19:26:51 +0000529 r'.+\.js$', r'.+\.py$', r'.+\.sh$', r'.+\.rb$', r'.+\.pl$', r'.+\.pm$',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000530 # Other
Edward Lemura5799e32020-01-17 19:26:51 +0000531 r'.+\.java$', r'.+\.mk$', r'.+\.am$', r'.+\.css$', r'.+\.mojom$',
532 r'.+\.fidl$'
maruel@chromium.org3410d912009-06-09 20:56:16 +0000533 )
534
535 # Path regexp that should be excluded from being considered containing source
536 # files. Don't modify this list from a presubmit script!
537 DEFAULT_BLACK_LIST = (
Edward Lemura5799e32020-01-17 19:26:51 +0000538 r'testing_support[\\\/]google_appengine[\\\/].*',
539 r'.*\bexperimental[\\\/].*',
Kent Tamura179dd1e2018-04-26 15:07:41 +0900540 # Exclude third_party/.* but NOT third_party/{WebKit,blink}
541 # (crbug.com/539768 and crbug.com/836555).
Edward Lemura5799e32020-01-17 19:26:51 +0000542 r'.*\bthird_party[\\\/](?!(WebKit|blink)[\\\/]).*',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000543 # Output directories (just in case)
Edward Lemura5799e32020-01-17 19:26:51 +0000544 r'.*\bDebug[\\\/].*',
545 r'.*\bRelease[\\\/].*',
546 r'.*\bxcodebuild[\\\/].*',
547 r'.*\bout[\\\/].*',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000548 # All caps files like README and LICENCE.
Edward Lemura5799e32020-01-17 19:26:51 +0000549 r'.*\b[A-Z0-9_]{2,}$',
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +0000550 # SCM (can happen in dual SCM configuration). (Slightly over aggressive)
Edward Lemura5799e32020-01-17 19:26:51 +0000551 r'(|.*[\\\/])\.git[\\\/].*',
552 r'(|.*[\\\/])\.svn[\\\/].*',
maruel@chromium.org7ccb4bb2011-11-07 20:26:20 +0000553 # There is no point in processing a patch file.
Edward Lemura5799e32020-01-17 19:26:51 +0000554 r'.+\.diff$',
555 r'.+\.patch$',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000556 )
557
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000558 def __init__(self, change, presubmit_path, is_committing,
Edward Lesmes8e282792018-04-03 18:50:29 -0400559 verbose, gerrit_obj, dry_run=None, thread_pool=None, parallel=False):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000560 """Builds an InputApi object.
561
562 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000563 change: A presubmit.Change object.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000564 presubmit_path: The path to the presubmit script being processed.
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000565 is_committing: True if the change is about to be committed.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000566 gerrit_obj: provides basic Gerrit codereview functionality.
567 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -0400568 parallel: if true, all tests reported via input_api.RunTests for all
569 PRESUBMIT files will be run in parallel.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000570 """
maruel@chromium.org9711bba2009-05-22 23:51:39 +0000571 # Version number of the presubmit_support script.
572 self.version = [int(x) for x in __version__.split('.')]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000573 self.change = change
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000574 self.is_committing = is_committing
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000575 self.gerrit = gerrit_obj
tandrii@chromium.org57bafac2016-04-28 05:09:03 +0000576 self.dry_run = dry_run
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000577
Edward Lesmes8e282792018-04-03 18:50:29 -0400578 self.parallel = parallel
579 self.thread_pool = thread_pool or ThreadPool()
580
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000581 # We expose various modules and functions as attributes of the input_api
582 # so that presubmit scripts don't have to import them.
Takeshi Yoshino07a6bea2017-08-02 02:44:06 +0900583 self.ast = ast
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000584 self.basename = os.path.basename
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000585 self.cpplint = cpplint
dcheng091b7db2016-06-16 01:27:51 -0700586 self.fnmatch = fnmatch
Yoshisato Yanagisawa04600b42019-03-15 03:03:41 +0000587 self.gclient_paths = gclient_paths
Yoshisato Yanagisawa57dd17b2019-03-22 09:10:29 +0000588 # TODO(yyanagisawa): stop exposing this when python3 become default.
589 # Since python3's tempfile has TemporaryDirectory, we do not need this.
590 self.temporary_directory = gclient_utils.temporary_directory
dpranke@chromium.org17cc2442012-10-17 21:12:09 +0000591 self.glob = glob.glob
maruel@chromium.orgfb11c7b2010-03-18 18:22:14 +0000592 self.json = json
maruel@chromium.org6fba34d2011-06-02 13:45:12 +0000593 self.logging = logging.getLogger('PRESUBMIT')
maruel@chromium.org2b5ce562011-03-31 16:15:44 +0000594 self.os_listdir = os.listdir
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000595 self.os_path = os.path
pgervais@chromium.orgbd0cace2014-10-02 23:23:46 +0000596 self.os_stat = os.stat
Yoshisato Yanagisawa406de132018-06-29 05:43:25 +0000597 self.os_walk = os.walk
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000598 self.re = re
599 self.subprocess = subprocess
Edward Lemurb9830242019-10-30 22:19:20 +0000600 self.sys = sys
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000601 self.tempfile = tempfile
dpranke@chromium.org0d1bdea2011-03-24 22:54:38 +0000602 self.time = time
maruel@chromium.org1487d532009-06-06 00:22:57 +0000603 self.unittest = unittest
Edward Lemurb9830242019-10-30 22:19:20 +0000604 if sys.version_info.major == 2:
605 self.urllib2 = urllib2
Edward Lemur16af3562019-10-17 22:11:33 +0000606 self.urllib_request = urllib_request
607 self.urllib_error = urllib_error
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000608
Robert Iannucci50258932018-03-19 10:30:59 -0700609 self.is_windows = sys.platform == 'win32'
610
Edward Lemurb9646622019-10-25 20:57:35 +0000611 # Set python_executable to 'vpython' in order to allow scripts in other
612 # repos (e.g. src.git) to automatically pick up that repo's .vpython file,
613 # instead of inheriting the one in depot_tools.
614 self.python_executable = 'vpython'
maruel@chromium.orgc0b22972009-06-25 16:19:14 +0000615 self.environ = os.environ
616
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000617 # InputApi.platform is the platform you're currently running on.
618 self.platform = sys.platform
619
iannucci@chromium.org0af3bb32015-06-12 20:44:35 +0000620 self.cpu_count = multiprocessing.cpu_count()
621
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000622 # The local path of the currently-being-processed presubmit script.
maruel@chromium.org3d235242009-05-15 12:40:48 +0000623 self._current_presubmit_path = os.path.dirname(presubmit_path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000624
625 # We carry the canned checks so presubmit scripts can easily use them.
626 self.canned_checks = presubmit_canned_checks
627
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +0100628 # Temporary files we must manually remove at the end of a run.
629 self._named_temporary_files = []
Jochen Eisinger72606f82017-04-04 10:44:18 +0200630
dpranke@chromium.org2a009622011-03-01 02:43:31 +0000631 # TODO(dpranke): figure out a list of all approved owners for a repo
632 # in order to be able to handle wildcard OWNERS files?
633 self.owners_db = owners.Database(change.RepositoryRoot(),
Edward Lemurb9830242019-10-30 22:19:20 +0000634 fopen=open, os_path=self.os_path)
Jochen Eisinger76f5fc62017-04-07 16:27:46 +0200635 self.owners_finder = owners_finder.OwnersFinder
maruel@chromium.org899e1c12011-04-07 17:03:18 +0000636 self.verbose = verbose
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000637 self.Command = CommandData
dpranke@chromium.org2a009622011-03-01 02:43:31 +0000638
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000639 # Replace <hash_map> and <hash_set> as headers that need to be included
Edward Lemura5799e32020-01-17 19:26:51 +0000640 # with 'base/containers/hash_tables.h' instead.
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000641 # Access to a protected member _XX of a client class
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800642 # pylint: disable=protected-access
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000643 self.cpplint._re_pattern_templates = [
danakj@chromium.org18278522013-06-11 22:42:32 +0000644 (a, b, 'base/containers/hash_tables.h')
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000645 if header in ('<hash_map>', '<hash_set>') else (a, b, header)
646 for (a, b, header) in cpplint._re_pattern_templates
647 ]
648
Edward Lemurecc27072020-01-06 16:42:34 +0000649 def SetTimeout(self, timeout):
650 self.thread_pool.timeout = timeout
651
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000652 def PresubmitLocalPath(self):
653 """Returns the local path of the presubmit script currently being run.
654
655 This is useful if you don't want to hard-code absolute paths in the
656 presubmit script. For example, It can be used to find another file
657 relative to the PRESUBMIT.py script, so the whole tree can be branched and
658 the presubmit script still works, without editing its content.
659 """
maruel@chromium.org3d235242009-05-15 12:40:48 +0000660 return self._current_presubmit_path
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000661
agable0b65e732016-11-22 09:25:46 -0800662 def AffectedFiles(self, include_deletes=True, file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000663 """Same as input_api.change.AffectedFiles() except only lists files
664 (and optionally directories) in the same directory as the current presubmit
665 script, or subdirectories thereof.
666 """
Edward Lemura5799e32020-01-17 19:26:51 +0000667 dir_with_slash = normpath('%s/' % self.PresubmitLocalPath())
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000668 if len(dir_with_slash) == 1:
669 dir_with_slash = ''
sail@chromium.org5538e022011-05-12 17:53:16 +0000670
Edward Lemurb9830242019-10-30 22:19:20 +0000671 return list(filter(
maruel@chromium.org4661e0c2009-06-04 00:45:26 +0000672 lambda x: normpath(x.AbsoluteLocalPath()).startswith(dir_with_slash),
Edward Lemurb9830242019-10-30 22:19:20 +0000673 self.change.AffectedFiles(include_deletes, file_filter)))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000674
agable0b65e732016-11-22 09:25:46 -0800675 def LocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000676 """Returns local paths of input_api.AffectedFiles()."""
agable0b65e732016-11-22 09:25:46 -0800677 paths = [af.LocalPath() for af in self.AffectedFiles()]
Edward Lemura5799e32020-01-17 19:26:51 +0000678 logging.debug('LocalPaths: %s', paths)
pgervais@chromium.org2f64f782014-04-25 00:12:33 +0000679 return paths
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000680
agable0b65e732016-11-22 09:25:46 -0800681 def AbsoluteLocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000682 """Returns absolute local paths of input_api.AffectedFiles()."""
agable0b65e732016-11-22 09:25:46 -0800683 return [af.AbsoluteLocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000684
John Budorick16162372018-04-18 10:39:53 -0700685 def AffectedTestableFiles(self, include_deletes=None, **kwargs):
agable0b65e732016-11-22 09:25:46 -0800686 """Same as input_api.change.AffectedTestableFiles() except only lists files
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000687 in the same directory as the current presubmit script, or subdirectories
688 thereof.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000689 """
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000690 if include_deletes is not None:
Edward Lemura5799e32020-01-17 19:26:51 +0000691 warn('AffectedTestableFiles(include_deletes=%s)'
692 ' is deprecated and ignored' % str(include_deletes),
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000693 category=DeprecationWarning,
694 stacklevel=2)
Edward Lemurb9830242019-10-30 22:19:20 +0000695 return list(filter(
696 lambda x: x.IsTestableFile(),
697 self.AffectedFiles(include_deletes=False, **kwargs)))
agable0b65e732016-11-22 09:25:46 -0800698
699 def AffectedTextFiles(self, include_deletes=None):
700 """An alias to AffectedTestableFiles for backwards compatibility."""
701 return self.AffectedTestableFiles(include_deletes=include_deletes)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000702
maruel@chromium.org3410d912009-06-09 20:56:16 +0000703 def FilterSourceFile(self, affected_file, white_list=None, black_list=None):
Edward Lemura5799e32020-01-17 19:26:51 +0000704 """Filters out files that aren't considered 'source file'.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000705
706 If white_list or black_list is None, InputApi.DEFAULT_WHITE_LIST
707 and InputApi.DEFAULT_BLACK_LIST is used respectively.
708
709 The lists will be compiled as regular expression and
710 AffectedFile.LocalPath() needs to pass both list.
711
712 Note: Copy-paste this function to suit your needs or use a lambda function.
713 """
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000714 def Find(affected_file, items):
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000715 local_path = affected_file.LocalPath()
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000716 for item in items:
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +0000717 if self.re.match(item, local_path):
maruel@chromium.org3410d912009-06-09 20:56:16 +0000718 return True
719 return False
720 return (Find(affected_file, white_list or self.DEFAULT_WHITE_LIST) and
721 not Find(affected_file, black_list or self.DEFAULT_BLACK_LIST))
722
723 def AffectedSourceFiles(self, source_file):
agable0b65e732016-11-22 09:25:46 -0800724 """Filter the list of AffectedTestableFiles by the function source_file.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000725
726 If source_file is None, InputApi.FilterSourceFile() is used.
727 """
728 if not source_file:
729 source_file = self.FilterSourceFile
Edward Lemurb9830242019-10-30 22:19:20 +0000730 return list(filter(source_file, self.AffectedTestableFiles()))
maruel@chromium.org3410d912009-06-09 20:56:16 +0000731
732 def RightHandSideLines(self, source_file_filter=None):
Edward Lemura5799e32020-01-17 19:26:51 +0000733 """An iterator over all text lines in 'new' version of changed files.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000734
735 Only lists lines from new or modified text files in the change that are
736 contained by the directory of the currently executing presubmit script.
737
738 This is useful for doing line-by-line regex checks, like checking for
739 trailing whitespace.
740
741 Yields:
742 a 3 tuple:
743 the AffectedFile instance of the current file;
744 integer line number (1-based); and
745 the contents of the line as a string.
maruel@chromium.org1487d532009-06-06 00:22:57 +0000746
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000747 Note: The carriage return (LF or CR) is stripped off.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000748 """
maruel@chromium.org3410d912009-06-09 20:56:16 +0000749 files = self.AffectedSourceFiles(source_file_filter)
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000750 return _RightHandSideLinesImpl(files)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000751
maruel@chromium.orge3608df2009-11-10 20:22:57 +0000752 def ReadFile(self, file_item, mode='r'):
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000753 """Reads an arbitrary file.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000754
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000755 Deny reading anything outside the repository.
756 """
maruel@chromium.orge3608df2009-11-10 20:22:57 +0000757 if isinstance(file_item, AffectedFile):
758 file_item = file_item.AbsoluteLocalPath()
759 if not file_item.startswith(self.change.RepositoryRoot()):
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000760 raise IOError('Access outside the repository root is denied.')
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +0000761 return gclient_utils.FileRead(file_item, mode)
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000762
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +0100763 def CreateTemporaryFile(self, **kwargs):
764 """Returns a named temporary file that must be removed with a call to
765 RemoveTemporaryFiles().
766
767 All keyword arguments are forwarded to tempfile.NamedTemporaryFile(),
768 except for |delete|, which is always set to False.
769
770 Presubmit checks that need to create a temporary file and pass it for
771 reading should use this function instead of NamedTemporaryFile(), as
772 Windows fails to open a file that is already open for writing.
773
774 with input_api.CreateTemporaryFile() as f:
775 f.write('xyz')
776 f.close()
777 input_api.subprocess.check_output(['script-that', '--reads-from',
778 f.name])
779
780
781 Note that callers of CreateTemporaryFile() should not worry about removing
782 any temporary file; this is done transparently by the presubmit handling
783 code.
784 """
785 if 'delete' in kwargs:
786 # Prevent users from passing |delete|; we take care of file deletion
787 # ourselves and this prevents unintuitive error messages when we pass
788 # delete=False and 'delete' is also in kwargs.
789 raise TypeError('CreateTemporaryFile() does not take a "delete" '
790 'argument, file deletion is handled automatically by '
791 'the same presubmit_support code that creates InputApi '
792 'objects.')
793 temp_file = self.tempfile.NamedTemporaryFile(delete=False, **kwargs)
794 self._named_temporary_files.append(temp_file.name)
795 return temp_file
796
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000797 @property
798 def tbr(self):
799 """Returns if a change is TBR'ed."""
Jeremy Romandce22502017-06-20 15:37:29 -0400800 return 'TBR' in self.change.tags or self.change.TBRsFromDescription()
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000801
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +0000802 def RunTests(self, tests_mix, parallel=True):
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000803 tests = []
804 msgs = []
805 for t in tests_mix:
Edward Lesmes8e282792018-04-03 18:50:29 -0400806 if isinstance(t, OutputApi.PresubmitResult) and t:
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000807 msgs.append(t)
808 else:
809 assert issubclass(t.message, _PresubmitResult)
810 tests.append(t)
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +0000811 if self.verbose:
812 t.info = _PresubmitNotifyResult
Edward Lemur1037c742018-05-01 18:56:04 -0400813 if not t.kwargs.get('cwd'):
814 t.kwargs['cwd'] = self.PresubmitLocalPath()
Edward Lesmes8e282792018-04-03 18:50:29 -0400815 self.thread_pool.AddTests(tests, parallel)
Edward Lemur21000eb2019-05-24 23:25:58 +0000816 # When self.parallel is True (i.e. --parallel is passed as an option)
817 # RunTests doesn't actually run tests. It adds them to a ThreadPool that
818 # will run all tests once all PRESUBMIT files are processed.
819 # Otherwise, it will run them and return the results.
820 if not self.parallel:
Edward Lesmes8e282792018-04-03 18:50:29 -0400821 msgs.extend(self.thread_pool.RunAsync())
822 return msgs
scottmg86099d72016-09-01 09:16:51 -0700823
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000824
nick@chromium.orgff526192013-06-10 19:30:26 +0000825class _DiffCache(object):
826 """Caches diffs retrieved from a particular SCM."""
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000827 def __init__(self, upstream=None):
828 """Stores the upstream revision against which all diffs will be computed."""
829 self._upstream = upstream
nick@chromium.orgff526192013-06-10 19:30:26 +0000830
831 def GetDiff(self, path, local_root):
832 """Get the diff for a particular path."""
833 raise NotImplementedError()
834
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700835 def GetOldContents(self, path, local_root):
836 """Get the old version for a particular path."""
837 raise NotImplementedError()
838
nick@chromium.orgff526192013-06-10 19:30:26 +0000839
nick@chromium.orgff526192013-06-10 19:30:26 +0000840class _GitDiffCache(_DiffCache):
841 """DiffCache implementation for git; gets all file diffs at once."""
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000842 def __init__(self, upstream):
843 super(_GitDiffCache, self).__init__(upstream=upstream)
nick@chromium.orgff526192013-06-10 19:30:26 +0000844 self._diffs_by_file = None
845
846 def GetDiff(self, path, local_root):
847 if not self._diffs_by_file:
848 # Compute a single diff for all files and parse the output; should
849 # with git this is much faster than computing one diff for each file.
850 diffs = {}
851
852 # Don't specify any filenames below, because there are command line length
853 # limits on some platforms and GenerateDiff would fail.
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000854 unified_diff = scm.GIT.GenerateDiff(local_root, files=[], full_move=True,
855 branch=self._upstream)
nick@chromium.orgff526192013-06-10 19:30:26 +0000856
857 # This regex matches the path twice, separated by a space. Note that
858 # filename itself may contain spaces.
859 file_marker = re.compile('^diff --git (?P<filename>.*) (?P=filename)$')
860 current_diff = []
861 keep_line_endings = True
862 for x in unified_diff.splitlines(keep_line_endings):
863 match = file_marker.match(x)
864 if match:
865 # Marks the start of a new per-file section.
866 diffs[match.group('filename')] = current_diff = [x]
867 elif x.startswith('diff --git'):
868 raise PresubmitFailure('Unexpected diff line: %s' % x)
869 else:
870 current_diff.append(x)
871
872 self._diffs_by_file = dict(
873 (normpath(path), ''.join(diff)) for path, diff in diffs.items())
874
875 if path not in self._diffs_by_file:
876 raise PresubmitFailure(
877 'Unified diff did not contain entry for file %s' % path)
878
879 return self._diffs_by_file[path]
880
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700881 def GetOldContents(self, path, local_root):
882 return scm.GIT.GetOldContents(local_root, path, branch=self._upstream)
883
nick@chromium.orgff526192013-06-10 19:30:26 +0000884
Yannic Bonenberger68409632020-01-23 18:29:01 +0000885def _ParseDiffHeader(line):
886 """Searches |line| for diff headers and returns a tuple
887 (header, old_line, old_size, new_line, new_size), or None if line doesn't
888 contain a diff header.
889
890 This relies on the scm diff output describing each changed code section
891 with a line of the form
892
893 ^@@ <old line num>,<old size> <new line num>,<new size> @@$
894 """
895 m = re.match(r'^@@ \-([0-9]+)\,([0-9]+) \+([0-9]+)\,([0-9]+) @@', line)
896 if m:
897 return (m.group(0), int(m.group(1)), int(m.group(2)), int(m.group(3)),
898 int(m.group(4)))
899
900
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000901class AffectedFile(object):
902 """Representation of a file in a change."""
nick@chromium.orgff526192013-06-10 19:30:26 +0000903
904 DIFF_CACHE = _DiffCache
905
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000906 # Method could be a function
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800907 # pylint: disable=no-self-use
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000908 def __init__(self, path, action, repository_root, diff_cache):
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000909 self._path = path
910 self._action = action
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000911 self._local_root = repository_root
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000912 self._is_directory = None
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000913 self._cached_changed_contents = None
Yannic Bonenberger68409632020-01-23 18:29:01 +0000914 self._cached_change_size_in_bytes = None
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000915 self._cached_new_contents = None
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000916 self._diff_cache = diff_cache
tobiasjs2836bcf2016-08-16 04:08:16 -0700917 logging.debug('%s(%s)', self.__class__.__name__, self._path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000918
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000919 def LocalPath(self):
920 """Returns the path of this file on the local disk relative to client root.
Andrew Grieve92b8b992017-11-02 09:42:24 -0400921
922 This should be used for error messages but not for accessing files,
923 because presubmit checks are run with CWD=PresubmitLocalPath() (which is
924 often != client root).
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000925 """
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000926 return normpath(self._path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000927
928 def AbsoluteLocalPath(self):
929 """Returns the absolute path of this file on the local disk.
930 """
chase@chromium.org8e416c82009-10-06 04:30:44 +0000931 return os.path.abspath(os.path.join(self._local_root, self.LocalPath()))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000932
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000933 def Action(self):
934 """Returns the action on this opened file, e.g. A, M, D, etc."""
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000935 return self._action
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000936
agable0b65e732016-11-22 09:25:46 -0800937 def IsTestableFile(self):
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000938 """Returns True if the file is a text file and not a binary file.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000939
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000940 Deleted files are not text file."""
maruel@chromium.org1e08c002009-05-28 19:09:33 +0000941 raise NotImplementedError() # Implement when needed
942
agable0b65e732016-11-22 09:25:46 -0800943 def IsTextFile(self):
944 """An alias to IsTestableFile for backwards compatibility."""
945 return self.IsTestableFile()
946
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700947 def OldContents(self):
948 """Returns an iterator over the lines in the old version of file.
949
Daniel Cheng2da34fe2017-03-21 20:42:12 -0700950 The old version is the file before any modifications in the user's
Edward Lemura5799e32020-01-17 19:26:51 +0000951 workspace, i.e. the 'left hand side'.
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700952
953 Contents will be empty if the file is a directory or does not exist.
954 Note: The carriage returns (LF or CR) are stripped off.
955 """
956 return self._diff_cache.GetOldContents(self.LocalPath(),
957 self._local_root).splitlines()
958
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000959 def NewContents(self):
960 """Returns an iterator over the lines in the new version of file.
961
Edward Lemura5799e32020-01-17 19:26:51 +0000962 The new version is the file in the user's workspace, i.e. the 'right hand
963 side'.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000964
965 Contents will be empty if the file is a directory or does not exist.
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000966 Note: The carriage returns (LF or CR) are stripped off.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000967 """
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000968 if self._cached_new_contents is None:
969 self._cached_new_contents = []
agable0b65e732016-11-22 09:25:46 -0800970 try:
971 self._cached_new_contents = gclient_utils.FileRead(
972 self.AbsoluteLocalPath(), 'rU').splitlines()
973 except IOError:
974 pass # File not found? That's fine; maybe it was deleted.
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000975 return self._cached_new_contents[:]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000976
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000977 def ChangedContents(self):
978 """Returns a list of tuples (line number, line text) of all new lines.
979
980 This relies on the scm diff output describing each changed code section
981 with a line of the form
982
983 ^@@ <old line num>,<old size> <new line num>,<new size> @@$
984 """
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000985 if self._cached_changed_contents is not None:
986 return self._cached_changed_contents[:]
987 self._cached_changed_contents = []
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000988 line_num = 0
989
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000990 for line in self.GenerateScmDiff().splitlines():
Yannic Bonenberger68409632020-01-23 18:29:01 +0000991 h = _ParseDiffHeader(line)
992 if h:
993 line_num = h[3]
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000994 continue
995 if line.startswith('+') and not line.startswith('++'):
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000996 self._cached_changed_contents.append((line_num, line[1:]))
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000997 if not line.startswith('-'):
998 line_num += 1
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000999 return self._cached_changed_contents[:]
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001000
Yannic Bonenberger68409632020-01-23 18:29:01 +00001001 def ChangeSizeInBytes(self):
1002 """Returns a list of tuples (deleted bytes, added bytes) of all changes
1003 in this file.
1004
1005 This relies on the scm diff output describing each changed code section
1006 with a line of the form
1007
1008 ^@@ <old line num>,<old size> <new line num>,<new size> @@$
1009 """
1010 if self._cached_change_size_in_bytes is not None:
1011 return self._cached_change_size_in_bytes[:]
1012 self._cached_change_size_in_bytes = []
1013
1014 for line in self.GenerateScmDiff().splitlines():
1015 h = _ParseDiffHeader(line)
1016 if h:
1017 self._cached_change_size_in_bytes.append((h[2], h[4]))
1018 return self._cached_change_size_in_bytes[:]
1019
maruel@chromium.org5de13972009-06-10 18:16:06 +00001020 def __str__(self):
1021 return self.LocalPath()
1022
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001023 def GenerateScmDiff(self):
nick@chromium.orgff526192013-06-10 19:30:26 +00001024 return self._diff_cache.GetDiff(self.LocalPath(), self._local_root)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001025
maruel@chromium.org58407af2011-04-12 23:15:57 +00001026
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001027class GitAffectedFile(AffectedFile):
1028 """Representation of a file in a change out of a git checkout."""
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +00001029 # Method 'NNN' is abstract in class 'NNN' but is not overridden
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -08001030 # pylint: disable=abstract-method
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001031
nick@chromium.orgff526192013-06-10 19:30:26 +00001032 DIFF_CACHE = _GitDiffCache
1033
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001034 def __init__(self, *args, **kwargs):
1035 AffectedFile.__init__(self, *args, **kwargs)
1036 self._server_path = None
agable0b65e732016-11-22 09:25:46 -08001037 self._is_testable_file = None
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001038
agable0b65e732016-11-22 09:25:46 -08001039 def IsTestableFile(self):
1040 if self._is_testable_file is None:
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001041 if self.Action() == 'D':
agable0b65e732016-11-22 09:25:46 -08001042 # A deleted file is not testable.
1043 self._is_testable_file = False
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001044 else:
agable0b65e732016-11-22 09:25:46 -08001045 self._is_testable_file = os.path.isfile(self.AbsoluteLocalPath())
1046 return self._is_testable_file
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001047
maruel@chromium.orgc1938752011-04-12 23:11:13 +00001048
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001049class Change(object):
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001050 """Describe a change.
1051
1052 Used directly by the presubmit scripts to query the current change being
1053 tested.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +00001054
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001055 Instance members:
nick@chromium.orgff526192013-06-10 19:30:26 +00001056 tags: Dictionary of KEY=VALUE pairs found in the change description.
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001057 self.KEY: equivalent to tags['KEY']
1058 """
1059
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001060 _AFFECTED_FILES = AffectedFile
1061
Edward Lemura5799e32020-01-17 19:26:51 +00001062 # Matches key/value (or 'tag') lines in changelist descriptions.
maruel@chromium.org428342a2011-11-10 15:46:33 +00001063 TAG_LINE_RE = re.compile(
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001064 '^[ \t]*(?P<key>[A-Z][A-Z_0-9]*)[ \t]*=[ \t]*(?P<value>.*?)[ \t]*$')
maruel@chromium.orgc1938752011-04-12 23:11:13 +00001065 scm = ''
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001066
maruel@chromium.org58407af2011-04-12 23:15:57 +00001067 def __init__(
agable@chromium.orgea84ef12014-04-30 19:55:12 +00001068 self, name, description, local_root, files, issue, patchset, author,
1069 upstream=None):
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001070 if files is None:
1071 files = []
1072 self._name = name
chase@chromium.org8e416c82009-10-06 04:30:44 +00001073 # Convert root into an absolute path.
1074 self._local_root = os.path.abspath(local_root)
agable@chromium.orgea84ef12014-04-30 19:55:12 +00001075 self._upstream = upstream
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001076 self.issue = issue
1077 self.patchset = patchset
maruel@chromium.org58407af2011-04-12 23:15:57 +00001078 self.author_email = author
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001079
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001080 self._full_description = ''
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001081 self.tags = {}
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001082 self._description_without_tags = ''
1083 self.SetDescriptionText(description)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001084
maruel@chromium.orge085d812011-10-10 19:49:15 +00001085 assert all(
1086 (isinstance(f, (list, tuple)) and len(f) == 2) for f in files), files
1087
agable@chromium.orgea84ef12014-04-30 19:55:12 +00001088 diff_cache = self._AFFECTED_FILES.DIFF_CACHE(self._upstream)
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001089 self._affected_files = [
nick@chromium.orgff526192013-06-10 19:30:26 +00001090 self._AFFECTED_FILES(path, action.strip(), self._local_root, diff_cache)
1091 for action, path in files
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +00001092 ]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001093
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001094 def Name(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001095 """Returns the change name."""
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001096 return self._name
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001097
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001098 def DescriptionText(self):
1099 """Returns the user-entered changelist description, minus tags.
1100
Edward Lemura5799e32020-01-17 19:26:51 +00001101 Any line in the user-provided description starting with e.g. 'FOO='
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001102 (whitespace permitted before and around) is considered a tag line. Such
1103 lines are stripped out of the description this function returns.
1104 """
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001105 return self._description_without_tags
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001106
1107 def FullDescriptionText(self):
1108 """Returns the complete changelist description including tags."""
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001109 return self._full_description
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001110
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001111 def SetDescriptionText(self, description):
1112 """Sets the full description text (including tags) to |description|.
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001113
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001114 Also updates the list of tags."""
1115 self._full_description = description
1116
1117 # From the description text, build up a dictionary of key/value pairs
Edward Lemura5799e32020-01-17 19:26:51 +00001118 # plus the description minus all key/value or 'tag' lines.
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001119 description_without_tags = []
1120 self.tags = {}
1121 for line in self._full_description.splitlines():
1122 m = self.TAG_LINE_RE.match(line)
1123 if m:
1124 self.tags[m.group('key')] = m.group('value')
1125 else:
1126 description_without_tags.append(line)
1127
1128 # Change back to text and remove whitespace at end.
1129 self._description_without_tags = (
1130 '\n'.join(description_without_tags).rstrip())
1131
Edward Lemur69bb8be2020-02-03 20:37:38 +00001132 def AddDescriptionFooter(self, key, value):
1133 """Adds the given footer to the change description.
1134
1135 Args:
1136 key: A string with the key for the git footer. It must conform to
1137 the git footers format (i.e. 'List-Of-Tokens') and will be case
1138 normalized so that each token is title-cased.
1139 value: A string with the value for the git footer.
1140 """
1141 description = git_footers.add_footer(
1142 self.FullDescriptionText(), git_footers.normalize_name(key), value)
1143 self.SetDescriptionText(description)
1144
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001145 def RepositoryRoot(self):
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001146 """Returns the repository (checkout) root directory for this change,
1147 as an absolute path.
1148 """
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001149 return self._local_root
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001150
1151 def __getattr__(self, attr):
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001152 """Return tags directly as attributes on the object."""
Edward Lemura5799e32020-01-17 19:26:51 +00001153 if not re.match(r'^[A-Z_]*$', attr):
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001154 raise AttributeError(self, attr)
maruel@chromium.orge1a524f2009-05-27 14:43:46 +00001155 return self.tags.get(attr)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001156
Edward Lemur69bb8be2020-02-03 20:37:38 +00001157 def GitFootersFromDescription(self):
1158 """Return the git footers present in the description.
1159
1160 Returns:
1161 footers: A dict of {footer: [values]} containing a multimap of the footers
1162 in the change description.
1163 """
1164 return git_footers.parse_footers(self.FullDescriptionText())
1165
Aaron Gablefc03e672017-05-15 14:09:42 -07001166 def BugsFromDescription(self):
1167 """Returns all bugs referenced in the commit description."""
Aaron Gable12ef5012017-05-15 14:29:00 -07001168 tags = [b.strip() for b in self.tags.get('BUG', '').split(',') if b.strip()]
Caleb Rouleauc0546b92019-02-22 06:12:57 +00001169 footers = []
Edward Lemur69bb8be2020-02-03 20:37:38 +00001170 parsed = self.GitFootersFromDescription()
Dan Beam62954042019-10-03 21:20:33 +00001171 unsplit_footers = parsed.get('Bug', []) + parsed.get('Fixed', [])
Caleb Rouleauc0546b92019-02-22 06:12:57 +00001172 for unsplit_footer in unsplit_footers:
1173 footers += [b.strip() for b in unsplit_footer.split(',')]
Aaron Gable12ef5012017-05-15 14:29:00 -07001174 return sorted(set(tags + footers))
Aaron Gablefc03e672017-05-15 14:09:42 -07001175
1176 def ReviewersFromDescription(self):
1177 """Returns all reviewers listed in the commit description."""
Edward Lemura5799e32020-01-17 19:26:51 +00001178 # We don't support a 'R:' git-footer for reviewers; that is in metadata.
Aaron Gable12ef5012017-05-15 14:29:00 -07001179 tags = [r.strip() for r in self.tags.get('R', '').split(',') if r.strip()]
1180 return sorted(set(tags))
Aaron Gablefc03e672017-05-15 14:09:42 -07001181
1182 def TBRsFromDescription(self):
1183 """Returns all TBR reviewers listed in the commit description."""
Aaron Gable12ef5012017-05-15 14:29:00 -07001184 tags = [r.strip() for r in self.tags.get('TBR', '').split(',') if r.strip()]
1185 # TODO(agable): Remove support for 'Tbr:' when TBRs are programmatically
1186 # determined by self-CR+1s.
Edward Lemur69bb8be2020-02-03 20:37:38 +00001187 footers = self.GitFootersFromDescription().get('Tbr', [])
Aaron Gable12ef5012017-05-15 14:29:00 -07001188 return sorted(set(tags + footers))
Aaron Gablefc03e672017-05-15 14:09:42 -07001189
1190 # TODO(agable): Delete these once we're sure they're unused.
1191 @property
1192 def BUG(self):
1193 return ','.join(self.BugsFromDescription())
1194 @property
1195 def R(self):
1196 return ','.join(self.ReviewersFromDescription())
1197 @property
1198 def TBR(self):
1199 return ','.join(self.TBRsFromDescription())
1200
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001201 def AllFiles(self, root=None):
1202 """List all files under source control in the repo."""
1203 raise NotImplementedError()
1204
agable0b65e732016-11-22 09:25:46 -08001205 def AffectedFiles(self, include_deletes=True, file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001206 """Returns a list of AffectedFile instances for all files in the change.
1207
1208 Args:
1209 include_deletes: If false, deleted files will be filtered out.
sail@chromium.org5538e022011-05-12 17:53:16 +00001210 file_filter: An additional filter to apply.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001211
1212 Returns:
1213 [AffectedFile(path, action), AffectedFile(path, action)]
1214 """
Edward Lemurb9830242019-10-30 22:19:20 +00001215 affected = list(filter(file_filter, self._affected_files))
sail@chromium.org5538e022011-05-12 17:53:16 +00001216
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001217 if include_deletes:
1218 return affected
Edward Lemurb9830242019-10-30 22:19:20 +00001219 return list(filter(lambda x: x.Action() != 'D', affected))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001220
John Budorick16162372018-04-18 10:39:53 -07001221 def AffectedTestableFiles(self, include_deletes=None, **kwargs):
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +00001222 """Return a list of the existing text files in a change."""
1223 if include_deletes is not None:
Edward Lemura5799e32020-01-17 19:26:51 +00001224 warn('AffectedTeestableFiles(include_deletes=%s)'
1225 ' is deprecated and ignored' % str(include_deletes),
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +00001226 category=DeprecationWarning,
1227 stacklevel=2)
Edward Lemurb9830242019-10-30 22:19:20 +00001228 return list(filter(
1229 lambda x: x.IsTestableFile(),
1230 self.AffectedFiles(include_deletes=False, **kwargs)))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001231
agable0b65e732016-11-22 09:25:46 -08001232 def AffectedTextFiles(self, include_deletes=None):
1233 """An alias to AffectedTestableFiles for backwards compatibility."""
1234 return self.AffectedTestableFiles(include_deletes=include_deletes)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001235
agable0b65e732016-11-22 09:25:46 -08001236 def LocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001237 """Convenience function."""
agable0b65e732016-11-22 09:25:46 -08001238 return [af.LocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001239
agable0b65e732016-11-22 09:25:46 -08001240 def AbsoluteLocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001241 """Convenience function."""
agable0b65e732016-11-22 09:25:46 -08001242 return [af.AbsoluteLocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001243
1244 def RightHandSideLines(self):
Edward Lemura5799e32020-01-17 19:26:51 +00001245 """An iterator over all text lines in 'new' version of changed files.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001246
1247 Lists lines from new or modified text files in the change.
1248
1249 This is useful for doing line-by-line regex checks, like checking for
1250 trailing whitespace.
1251
1252 Yields:
1253 a 3 tuple:
1254 the AffectedFile instance of the current file;
1255 integer line number (1-based); and
1256 the contents of the line as a string.
1257 """
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +00001258 return _RightHandSideLinesImpl(
1259 x for x in self.AffectedFiles(include_deletes=False)
agable0b65e732016-11-22 09:25:46 -08001260 if x.IsTestableFile())
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001261
Jochen Eisingerd0573ec2017-04-13 10:55:06 +02001262 def OriginalOwnersFiles(self):
1263 """A map from path names of affected OWNERS files to their old content."""
1264 def owners_file_filter(f):
1265 return 'OWNERS' in os.path.split(f.LocalPath())[1]
1266 files = self.AffectedFiles(file_filter=owners_file_filter)
1267 return dict([(f.LocalPath(), f.OldContents()) for f in files])
1268
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001269
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001270class GitChange(Change):
1271 _AFFECTED_FILES = GitAffectedFile
maruel@chromium.orgc1938752011-04-12 23:11:13 +00001272 scm = 'git'
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +00001273
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001274 def AllFiles(self, root=None):
1275 """List all files under source control in the repo."""
1276 root = root or self.RepositoryRoot()
1277 return subprocess.check_output(
Aaron Gable7817f022017-12-12 09:43:17 -08001278 ['git', '-c', 'core.quotePath=false', 'ls-files', '--', '.'],
1279 cwd=root).splitlines()
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001280
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001281
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001282def ListRelevantPresubmitFiles(files, root):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001283 """Finds all presubmit files that apply to a given set of source files.
1284
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001285 If inherit-review-settings-ok is present right under root, looks for
1286 PRESUBMIT.py in directories enclosing root.
1287
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001288 Args:
1289 files: An iterable container containing file paths.
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001290 root: Path where to stop searching.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001291
1292 Return:
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001293 List of absolute paths of the existing PRESUBMIT.py scripts.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001294 """
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001295 files = [normpath(os.path.join(root, f)) for f in files]
1296
1297 # List all the individual directories containing files.
1298 directories = set([os.path.dirname(f) for f in files])
1299
1300 # Ignore root if inherit-review-settings-ok is present.
1301 if os.path.isfile(os.path.join(root, 'inherit-review-settings-ok')):
1302 root = None
1303
1304 # Collect all unique directories that may contain PRESUBMIT.py.
1305 candidates = set()
1306 for directory in directories:
1307 while True:
1308 if directory in candidates:
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001309 break
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001310 candidates.add(directory)
1311 if directory == root:
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001312 break
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001313 parent_dir = os.path.dirname(directory)
1314 if parent_dir == directory:
1315 # We hit the system root directory.
1316 break
1317 directory = parent_dir
1318
1319 # Look for PRESUBMIT.py in all candidate directories.
1320 results = []
1321 for directory in sorted(list(candidates)):
tobiasjsff061c02016-08-17 03:23:57 -07001322 try:
1323 for f in os.listdir(directory):
1324 p = os.path.join(directory, f)
1325 if os.path.isfile(p) and re.match(
1326 r'PRESUBMIT.*\.py$', f) and not f.startswith('PRESUBMIT_test'):
1327 results.append(p)
1328 except OSError:
1329 pass
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001330
tobiasjs2836bcf2016-08-16 04:08:16 -07001331 logging.debug('Presubmit files: %s', ','.join(results))
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001332 return results
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001333
1334
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001335class GetTryMastersExecuter(object):
1336 @staticmethod
1337 def ExecPresubmitScript(script_text, presubmit_path, project, change):
1338 """Executes GetPreferredTryMasters() from a single presubmit script.
1339
1340 Args:
1341 script_text: The text of the presubmit script.
1342 presubmit_path: Project script to run.
1343 project: Project name to pass to presubmit script for bot selection.
1344
1345 Return:
1346 A map of try masters to map of builders to set of tests.
1347 """
1348 context = {}
1349 try:
Raul Tambre09e64b42019-05-14 01:57:22 +00001350 exec(compile(script_text, 'PRESUBMIT.py', 'exec', dont_inherit=True),
1351 context)
Raul Tambre7c938462019-05-24 16:35:35 +00001352 except Exception as e:
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001353 raise PresubmitFailure('"%s" had an exception.\n%s'
1354 % (presubmit_path, e))
1355
1356 function_name = 'GetPreferredTryMasters'
1357 if function_name not in context:
1358 return {}
1359 get_preferred_try_masters = context[function_name]
1360 if not len(inspect.getargspec(get_preferred_try_masters)[0]) == 2:
1361 raise PresubmitFailure(
1362 'Expected function "GetPreferredTryMasters" to take two arguments.')
1363 return get_preferred_try_masters(project, change)
1364
1365
rmistry@google.com5626a922015-02-26 14:03:30 +00001366class GetPostUploadExecuter(object):
1367 @staticmethod
Edward Lemur016a0872020-02-04 22:13:28 +00001368 def ExecPresubmitScript(script_text, presubmit_path, gerrit_obj, change):
rmistry@google.com5626a922015-02-26 14:03:30 +00001369 """Executes PostUploadHook() from a single presubmit script.
1370
1371 Args:
1372 script_text: The text of the presubmit script.
1373 presubmit_path: Project script to run.
Edward Lemur016a0872020-02-04 22:13:28 +00001374 gerrit_obj: The GerritAccessor object.
rmistry@google.com5626a922015-02-26 14:03:30 +00001375 change: The Change object.
1376
1377 Return:
1378 A list of results objects.
1379 """
1380 context = {}
1381 try:
Raul Tambre09e64b42019-05-14 01:57:22 +00001382 exec(compile(script_text, 'PRESUBMIT.py', 'exec', dont_inherit=True),
1383 context)
Raul Tambre7c938462019-05-24 16:35:35 +00001384 except Exception as e:
rmistry@google.com5626a922015-02-26 14:03:30 +00001385 raise PresubmitFailure('"%s" had an exception.\n%s'
1386 % (presubmit_path, e))
1387
1388 function_name = 'PostUploadHook'
1389 if function_name not in context:
1390 return {}
1391 post_upload_hook = context[function_name]
1392 if not len(inspect.getargspec(post_upload_hook)[0]) == 3:
1393 raise PresubmitFailure(
1394 'Expected function "PostUploadHook" to take three arguments.')
Edward Lemur016a0872020-02-04 22:13:28 +00001395 return post_upload_hook(gerrit_obj, change, OutputApi(False))
rmistry@google.com5626a922015-02-26 14:03:30 +00001396
1397
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001398def _MergeMasters(masters1, masters2):
1399 """Merges two master maps. Merges also the tests of each builder."""
1400 result = {}
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001401 for (master, builders) in itertools.chain(masters1.items(),
1402 masters2.items()):
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001403 new_builders = result.setdefault(master, {})
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001404 for (builder, tests) in builders.items():
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001405 new_builders.setdefault(builder, set([])).update(tests)
1406 return result
1407
1408
1409def DoGetTryMasters(change,
1410 changed_files,
1411 repository_root,
1412 default_presubmit,
1413 project,
1414 verbose,
1415 output_stream):
1416 """Get the list of try masters from the presubmit scripts.
1417
1418 Args:
1419 changed_files: List of modified files.
1420 repository_root: The repository root.
1421 default_presubmit: A default presubmit script to execute in any case.
1422 project: Optional name of a project used in selecting trybots.
1423 verbose: Prints debug info.
1424 output_stream: A stream to write debug output to.
1425
1426 Return:
1427 Map of try masters to map of builders to set of tests.
1428 """
1429 presubmit_files = ListRelevantPresubmitFiles(changed_files, repository_root)
1430 if not presubmit_files and verbose:
Edward Lemura5799e32020-01-17 19:26:51 +00001431 output_stream.write('Warning, no PRESUBMIT.py found.\n')
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001432 results = {}
1433 executer = GetTryMastersExecuter()
1434
1435 if default_presubmit:
1436 if verbose:
Edward Lemura5799e32020-01-17 19:26:51 +00001437 output_stream.write('Running default presubmit script.\n')
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001438 fake_path = os.path.join(repository_root, 'PRESUBMIT.py')
1439 results = _MergeMasters(results, executer.ExecPresubmitScript(
1440 default_presubmit, fake_path, project, change))
1441 for filename in presubmit_files:
1442 filename = os.path.abspath(filename)
1443 if verbose:
Edward Lemura5799e32020-01-17 19:26:51 +00001444 output_stream.write('Running %s\n' % filename)
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001445 # Accept CRLF presubmit script.
1446 presubmit_script = gclient_utils.FileRead(filename, 'rU')
1447 results = _MergeMasters(results, executer.ExecPresubmitScript(
1448 presubmit_script, filename, project, change))
1449
1450 # Make sets to lists again for later JSON serialization.
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001451 for builders in results.values():
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001452 for builder in builders:
1453 builders[builder] = list(builders[builder])
1454
1455 if results and verbose:
1456 output_stream.write('%s\n' % str(results))
1457 return results
1458
1459
rmistry@google.com5626a922015-02-26 14:03:30 +00001460def DoPostUploadExecuter(change,
Edward Lemur016a0872020-02-04 22:13:28 +00001461 gerrit_obj,
rmistry@google.com5626a922015-02-26 14:03:30 +00001462 repository_root,
1463 verbose,
1464 output_stream):
1465 """Execute the post upload hook.
1466
1467 Args:
1468 change: The Change object.
Edward Lemur016a0872020-02-04 22:13:28 +00001469 gerrit_obj: The GerritAccessor object.
rmistry@google.com5626a922015-02-26 14:03:30 +00001470 repository_root: The repository root.
1471 verbose: Prints debug info.
1472 output_stream: A stream to write debug output to.
1473 """
1474 presubmit_files = ListRelevantPresubmitFiles(
1475 change.LocalPaths(), repository_root)
1476 if not presubmit_files and verbose:
Edward Lemura5799e32020-01-17 19:26:51 +00001477 output_stream.write('Warning, no PRESUBMIT.py found.\n')
rmistry@google.com5626a922015-02-26 14:03:30 +00001478 results = []
1479 executer = GetPostUploadExecuter()
1480 # The root presubmit file should be executed after the ones in subdirectories.
1481 # i.e. the specific post upload hooks should run before the general ones.
1482 # Thus, reverse the order provided by ListRelevantPresubmitFiles.
1483 presubmit_files.reverse()
1484
1485 for filename in presubmit_files:
1486 filename = os.path.abspath(filename)
1487 if verbose:
Edward Lemura5799e32020-01-17 19:26:51 +00001488 output_stream.write('Running %s\n' % filename)
rmistry@google.com5626a922015-02-26 14:03:30 +00001489 # Accept CRLF presubmit script.
1490 presubmit_script = gclient_utils.FileRead(filename, 'rU')
1491 results.extend(executer.ExecPresubmitScript(
Edward Lemur016a0872020-02-04 22:13:28 +00001492 presubmit_script, filename, gerrit_obj, change))
rmistry@google.com5626a922015-02-26 14:03:30 +00001493 output_stream.write('\n')
1494 if results:
1495 output_stream.write('** Post Upload Hook Messages **\n')
1496 for result in results:
1497 result.handle(output_stream)
1498 output_stream.write('\n')
1499
1500 return results
1501
1502
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001503class PresubmitExecuter(object):
Aaron Gable668c1d82018-04-03 10:19:16 -07001504 def __init__(self, change, committing, verbose,
Edward Lesmes8e282792018-04-03 18:50:29 -04001505 gerrit_obj, dry_run=None, thread_pool=None, parallel=False):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001506 """
1507 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001508 change: The Change object.
agable92bec4f2016-08-24 09:27:27 -07001509 committing: True if 'git cl land' is running, False if 'git cl upload' is.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001510 gerrit_obj: provides basic Gerrit codereview functionality.
1511 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -04001512 parallel: if true, all tests reported via input_api.RunTests for all
1513 PRESUBMIT files will be run in parallel.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001514 """
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001515 self.change = change
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001516 self.committing = committing
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001517 self.gerrit = gerrit_obj
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001518 self.verbose = verbose
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001519 self.dry_run = dry_run
Daniel Cheng7227d212017-11-17 08:12:37 -08001520 self.more_cc = []
Edward Lesmes8e282792018-04-03 18:50:29 -04001521 self.thread_pool = thread_pool
1522 self.parallel = parallel
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001523
1524 def ExecPresubmitScript(self, script_text, presubmit_path):
1525 """Executes a single presubmit script.
1526
1527 Args:
1528 script_text: The text of the presubmit script.
1529 presubmit_path: The path to the presubmit file (this will be reported via
1530 input_api.PresubmitLocalPath()).
1531
1532 Return:
1533 A list of result objects, empty if no problems.
1534 """
thakis@chromium.orgc6ef53a2014-11-04 00:13:54 +00001535
chase@chromium.org8e416c82009-10-06 04:30:44 +00001536 # Change to the presubmit file's directory to support local imports.
1537 main_path = os.getcwd()
1538 os.chdir(os.path.dirname(presubmit_path))
1539
1540 # Load the presubmit script into context.
dpranke@chromium.org970c5222011-03-12 00:32:24 +00001541 input_api = InputApi(self.change, presubmit_path, self.committing,
Aaron Gable668c1d82018-04-03 10:19:16 -07001542 self.verbose, gerrit_obj=self.gerrit,
Edward Lesmes8e282792018-04-03 18:50:29 -04001543 dry_run=self.dry_run, thread_pool=self.thread_pool,
1544 parallel=self.parallel)
Daniel Cheng7227d212017-11-17 08:12:37 -08001545 output_api = OutputApi(self.committing)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001546 context = {}
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001547 try:
Raul Tambre09e64b42019-05-14 01:57:22 +00001548 exec(compile(script_text, 'PRESUBMIT.py', 'exec', dont_inherit=True),
1549 context)
Raul Tambre7c938462019-05-24 16:35:35 +00001550 except Exception as e:
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001551 raise PresubmitFailure('"%s" had an exception.\n%s' % (presubmit_path, e))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001552
1553 # These function names must change if we make substantial changes to
1554 # the presubmit API that are not backwards compatible.
1555 if self.committing:
1556 function_name = 'CheckChangeOnCommit'
1557 else:
1558 function_name = 'CheckChangeOnUpload'
1559 if function_name in context:
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +01001560 try:
Daniel Cheng7227d212017-11-17 08:12:37 -08001561 context['__args'] = (input_api, output_api)
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +01001562 logging.debug('Running %s in %s', function_name, presubmit_path)
1563 result = eval(function_name + '(*__args)', context)
1564 logging.debug('Running %s done.', function_name)
Daniel Chengd36fce42017-11-21 21:52:52 -08001565 self.more_cc.extend(output_api.more_cc)
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +01001566 finally:
Edward Lemurb9830242019-10-30 22:19:20 +00001567 for f in input_api._named_temporary_files:
1568 os.remove(f)
1569 if not isinstance(result, (tuple, list)):
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001570 raise PresubmitFailure(
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001571 'Presubmit functions must return a tuple or list')
1572 for item in result:
1573 if not isinstance(item, OutputApi.PresubmitResult):
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001574 raise PresubmitFailure(
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001575 'All presubmit results must be of types derived from '
1576 'output_api.PresubmitResult')
1577 else:
1578 result = () # no error since the script doesn't care about current event.
1579
chase@chromium.org8e416c82009-10-06 04:30:44 +00001580 # Return the process to the original working directory.
1581 os.chdir(main_path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001582 return result
1583
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001584def DoPresubmitChecks(change,
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001585 committing,
1586 verbose,
1587 output_stream,
maruel@chromium.org0ff1fab2009-05-22 13:08:15 +00001588 input_stream,
maruel@chromium.orgb0dfd352009-06-10 14:12:54 +00001589 default_presubmit,
dpranke@chromium.org970c5222011-03-12 00:32:24 +00001590 may_prompt,
Aaron Gable668c1d82018-04-03 10:19:16 -07001591 gerrit_obj,
Edward Lesmes8e282792018-04-03 18:50:29 -04001592 dry_run=None,
Debrian Figueroadd2737e2019-06-21 23:50:13 +00001593 parallel=False,
1594 json_output=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001595 """Runs all presubmit checks that apply to the files in the change.
1596
1597 This finds all PRESUBMIT.py files in directories enclosing the files in the
1598 change (up to the repository root) and calls the relevant entrypoint function
1599 depending on whether the change is being committed or uploaded.
1600
1601 Prints errors, warnings and notifications. Prompts the user for warnings
1602 when needed.
1603
1604 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001605 change: The Change object.
agable92bec4f2016-08-24 09:27:27 -07001606 committing: True if 'git cl land' is running, False if 'git cl upload' is.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001607 verbose: Prints debug info.
1608 output_stream: A stream to write output from presubmit tests to.
1609 input_stream: A stream to read input from the user.
maruel@chromium.org0ff1fab2009-05-22 13:08:15 +00001610 default_presubmit: A default presubmit script to execute in any case.
Quinten Yearsley516fe7f2016-12-14 11:50:18 -08001611 may_prompt: Enable (y/n) questions on warning or error. If False,
1612 any questions are answered with yes by default.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001613 gerrit_obj: provides basic Gerrit codereview functionality.
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001614 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -04001615 parallel: if true, all tests specified by input_api.RunTests in all
1616 PRESUBMIT files will be run in parallel.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001617
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +00001618 Warning:
1619 If may_prompt is true, output_stream SHOULD be sys.stdout and input_stream
1620 SHOULD be sys.stdin.
1621
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001622 Return:
dpranke@chromium.org5ac21012011-03-16 02:58:25 +00001623 A PresubmitOutput object. Use output.should_continue() to figure out
1624 if there were errors or warnings and the caller should abort.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001625 """
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001626 old_environ = os.environ
1627 try:
1628 # Make sure python subprocesses won't generate .pyc files.
1629 os.environ = os.environ.copy()
Edward Lemurb9830242019-10-30 22:19:20 +00001630 os.environ['PYTHONDONTWRITEBYTECODE'] = '1'
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001631
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001632 output = PresubmitOutput(input_stream, output_stream)
Debrian Figueroadd2737e2019-06-21 23:50:13 +00001633
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001634 if committing:
Edward Lemura5799e32020-01-17 19:26:51 +00001635 output.write('Running presubmit commit checks ...\n')
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001636 else:
Edward Lemura5799e32020-01-17 19:26:51 +00001637 output.write('Running presubmit upload checks ...\n')
Edward Lemurecc27072020-01-06 16:42:34 +00001638 start_time = time_time()
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001639 presubmit_files = ListRelevantPresubmitFiles(
agable0b65e732016-11-22 09:25:46 -08001640 change.AbsoluteLocalPaths(), change.RepositoryRoot())
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001641 if not presubmit_files and verbose:
Edward Lemura5799e32020-01-17 19:26:51 +00001642 output.write('Warning, no PRESUBMIT.py found.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001643 results = []
Edward Lesmes8e282792018-04-03 18:50:29 -04001644 thread_pool = ThreadPool()
Edward Lemur7e3c67f2018-07-20 20:52:49 +00001645 executer = PresubmitExecuter(change, committing, verbose, gerrit_obj,
1646 dry_run, thread_pool, parallel)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001647 if default_presubmit:
1648 if verbose:
Edward Lemura5799e32020-01-17 19:26:51 +00001649 output.write('Running default presubmit script.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001650 fake_path = os.path.join(change.RepositoryRoot(), 'PRESUBMIT.py')
1651 results += executer.ExecPresubmitScript(default_presubmit, fake_path)
1652 for filename in presubmit_files:
1653 filename = os.path.abspath(filename)
1654 if verbose:
Edward Lemura5799e32020-01-17 19:26:51 +00001655 output.write('Running %s\n' % filename)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001656 # Accept CRLF presubmit script.
1657 presubmit_script = gclient_utils.FileRead(filename, 'rU')
1658 results += executer.ExecPresubmitScript(presubmit_script, filename)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001659
Edward Lesmes8e282792018-04-03 18:50:29 -04001660 results += thread_pool.RunAsync()
1661
Daniel Cheng7227d212017-11-17 08:12:37 -08001662 output.more_cc.extend(executer.more_cc)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001663 errors = []
1664 notifications = []
1665 warnings = []
1666 for result in results:
1667 if result.fatal:
1668 errors.append(result)
1669 elif result.should_prompt:
1670 warnings.append(result)
1671 else:
1672 notifications.append(result)
pam@chromium.orged9a0832009-09-09 22:48:55 +00001673
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001674 output.write('\n')
1675 for name, items in (('Messages', notifications),
1676 ('Warnings', warnings),
1677 ('ERRORS', errors)):
1678 if items:
1679 output.write('** Presubmit %s **\n' % name)
1680 for item in items:
1681 item.handle(output)
1682 output.write('\n')
pam@chromium.orged9a0832009-09-09 22:48:55 +00001683
Edward Lemurecc27072020-01-06 16:42:34 +00001684 total_time = time_time() - start_time
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001685 if total_time > 1.0:
Edward Lemura5799e32020-01-17 19:26:51 +00001686 output.write('Presubmit checks took %.1fs to calculate.\n\n' % total_time)
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +00001687
Quinten Yearsley516fe7f2016-12-14 11:50:18 -08001688 if errors:
1689 output.fail()
1690 elif warnings:
1691 output.write('There were presubmit warnings. ')
1692 if may_prompt:
1693 output.prompt_yes_no('Are you sure you wish to continue? (y/N): ')
1694 else:
1695 output.write('Presubmit checks passed.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001696
Edward Lemur1dc66e12020-02-21 21:36:34 +00001697 if json_output:
1698 # Write the presubmit results to json output
1699 presubmit_results = {
1700 'errors': [
1701 error.json_format() for error in errors
1702 ],
1703 'notifications': [
1704 notification.json_format() for notification in notifications
1705 ],
1706 'warnings': [
1707 warning.json_format() for warning in warnings
1708 ],
1709 'should_continue': output.should_continue(),
1710 'more_cc': output.more_cc,
1711 }
1712
1713 gclient_utils.FileWrite(
1714 json_output, json.dumps(presubmit_results, sort_keys=True))
1715
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001716 global _ASKED_FOR_FEEDBACK
1717 # Ask for feedback one time out of 5.
1718 if (len(results) and random.randint(0, 4) == 0 and not _ASKED_FOR_FEEDBACK):
maruel@chromium.org1ce8e662014-01-14 15:23:00 +00001719 output.write(
1720 'Was the presubmit check useful? If not, run "git cl presubmit -v"\n'
1721 'to figure out which PRESUBMIT.py was run, then run git blame\n'
1722 'on the file to figure out who to ask for help.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001723 _ASKED_FOR_FEEDBACK = True
1724 return output
1725 finally:
1726 os.environ = old_environ
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001727
1728
Edward Lemur50984a62020-02-06 18:10:18 +00001729def _scan_sub_dirs(mask, recursive):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001730 if not recursive:
pgervais@chromium.orge57b09d2014-05-07 00:58:13 +00001731 return [x for x in glob.glob(mask) if x not in ('.svn', '.git')]
Lei Zhang9611c4c2017-04-04 01:41:56 -07001732
1733 results = []
1734 for root, dirs, files in os.walk('.'):
1735 if '.svn' in dirs:
1736 dirs.remove('.svn')
1737 if '.git' in dirs:
1738 dirs.remove('.git')
1739 for name in files:
1740 if fnmatch.fnmatch(name, mask):
1741 results.append(os.path.join(root, name))
1742 return results
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001743
1744
Edward Lemur50984a62020-02-06 18:10:18 +00001745def _parse_files(args, recursive):
tobiasjs2836bcf2016-08-16 04:08:16 -07001746 logging.debug('Searching for %s', args)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001747 files = []
1748 for arg in args:
Edward Lemur50984a62020-02-06 18:10:18 +00001749 files.extend([('M', f) for f in _scan_sub_dirs(arg, recursive)])
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001750 return files
1751
1752
Edward Lemur50984a62020-02-06 18:10:18 +00001753def _parse_change(parser, options):
1754 """Process change options.
1755
1756 Args:
1757 parser: The parser used to parse the arguments from command line.
1758 options: The arguments parsed from command line.
1759 Returns:
1760 A GitChange if the change root is a git repository, or a Change otherwise.
1761 """
1762 if options.files and options.all_files:
1763 parser.error('<files> cannot be specified when --all-files is set.')
1764
Edward Lesmes44ea3ff2020-02-05 00:14:30 +00001765 change_scm = scm.determine_scm(options.root)
Edward Lemur50984a62020-02-06 18:10:18 +00001766 if change_scm != 'git' and not options.files:
1767 parser.error('<files> is not optional for unversioned directories.')
1768
1769 if options.files:
1770 change_files = _parse_files(options.files, options.recursive)
1771 elif options.all_files:
1772 change_files = [('M', f) for f in scm.GIT.GetAllFiles(options.root)]
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001773 else:
Edward Lemur50984a62020-02-06 18:10:18 +00001774 change_files = scm.GIT.CaptureStatus(
Edward Lemur7f6dec02020-02-06 20:23:58 +00001775 options.root, options.upstream or None)
Edward Lemur50984a62020-02-06 18:10:18 +00001776
1777 logging.info('Found %d file(s).', len(change_files))
1778
1779 change_class = GitChange if change_scm == 'git' else Change
1780 return change_class(
1781 options.name,
1782 options.description,
1783 options.root,
1784 change_files,
1785 options.issue,
1786 options.patchset,
1787 options.author,
1788 upstream=options.upstream)
1789
1790
1791def _parse_gerrit_options(parser, options):
1792 """Process gerrit options.
1793
1794 SIDE EFFECTS: Modifies options.author and options.description from Gerrit if
1795 options.gerrit_fetch is set.
1796
1797 Args:
1798 parser: The parser used to parse the arguments from command line.
1799 options: The arguments parsed from command line.
1800 Returns:
1801 A GerritAccessor object if options.gerrit_url is set, or None otherwise.
1802 """
1803 gerrit_obj = None
1804 if options.gerrit_url:
1805 gerrit_obj = GerritAccessor(urlparse.urlparse(options.gerrit_url).netloc)
1806
1807 if not options.gerrit_fetch:
1808 return gerrit_obj
1809
1810 if not options.gerrit_url or not options.issue or not options.patchset:
1811 parser.error(
1812 '--gerrit_fetch requires --gerrit_url, --issue and --patchset.')
1813
1814 options.author = gerrit_obj.GetChangeOwner(options.issue)
1815 options.description = gerrit_obj.GetChangeDescription(
1816 options.issue, options.patchset)
1817
1818 logging.info('Got author: "%s"', options.author)
1819 logging.info('Got description: """\n%s\n"""', options.description)
1820
1821 return gerrit_obj
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001822
1823
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001824@contextlib.contextmanager
1825def canned_check_filter(method_names):
1826 filtered = {}
1827 try:
1828 for method_name in method_names:
1829 if not hasattr(presubmit_canned_checks, method_name):
Aaron Gableecee74c2018-04-02 15:13:08 -07001830 logging.warn('Skipping unknown "canned" check %s' % method_name)
1831 continue
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001832 filtered[method_name] = getattr(presubmit_canned_checks, method_name)
1833 setattr(presubmit_canned_checks, method_name, lambda *_a, **_kw: [])
1834 yield
1835 finally:
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001836 for name, method in filtered.items():
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001837 setattr(presubmit_canned_checks, name, method)
1838
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +00001839
sbc@chromium.org013731e2015-02-26 18:28:43 +00001840def main(argv=None):
Edward Lemura5799e32020-01-17 19:26:51 +00001841 parser = argparse.ArgumentParser(usage='%(prog)s [options] <files...>')
1842 hooks = parser.add_mutually_exclusive_group()
1843 hooks.add_argument('-c', '--commit', action='store_true',
1844 help='Use commit instead of upload checks.')
1845 hooks.add_argument('-u', '--upload', action='store_false', dest='commit',
1846 help='Use upload instead of commit checks.')
1847 parser.add_argument('-r', '--recursive', action='store_true',
1848 help='Act recursively.')
1849 parser.add_argument('-v', '--verbose', action='count', default=0,
1850 help='Use 2 times for more debug info.')
1851 parser.add_argument('--name', default='no name')
1852 parser.add_argument('--author')
1853 parser.add_argument('--description', default='')
1854 parser.add_argument('--issue', type=int, default=0)
1855 parser.add_argument('--patchset', type=int, default=0)
1856 parser.add_argument('--root', default=os.getcwd(),
1857 help='Search for PRESUBMIT.py up to this directory. '
1858 'If inherit-review-settings-ok is present in this '
1859 'directory, parent directories up to the root file '
1860 'system directories will also be searched.')
1861 parser.add_argument('--upstream',
1862 help='Git only: the base ref or upstream branch against '
1863 'which the diff should be computed.')
1864 parser.add_argument('--default_presubmit')
1865 parser.add_argument('--may_prompt', action='store_true', default=False)
1866 parser.add_argument('--skip_canned', action='append', default=[],
1867 help='A list of checks to skip which appear in '
1868 'presubmit_canned_checks. Can be provided multiple times '
1869 'to skip multiple canned checks.')
1870 parser.add_argument('--dry_run', action='store_true', help=argparse.SUPPRESS)
1871 parser.add_argument('--gerrit_url', help=argparse.SUPPRESS)
1872 parser.add_argument('--gerrit_fetch', action='store_true',
1873 help=argparse.SUPPRESS)
1874 parser.add_argument('--parallel', action='store_true',
1875 help='Run all tests specified by input_api.RunTests in '
1876 'all PRESUBMIT files in parallel.')
1877 parser.add_argument('--json_output',
1878 help='Write presubmit errors to json output.')
Edward Lemur1dc66e12020-02-21 21:36:34 +00001879 parser.add_argument('--all_files', action='store_true',
Edward Lemur50984a62020-02-06 18:10:18 +00001880 help='Mark all files under source control as modified.')
Edward Lemura5799e32020-01-17 19:26:51 +00001881 parser.add_argument('files', nargs='*',
1882 help='List of files to be marked as modified when '
1883 'executing presubmit or post-upload hooks. fnmatch '
1884 'wildcards can also be used.')
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001885
Edward Lemura5799e32020-01-17 19:26:51 +00001886 options = parser.parse_args(argv)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001887
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001888 if options.verbose >= 2:
maruel@chromium.org7444c502011-02-09 14:02:11 +00001889 logging.basicConfig(level=logging.DEBUG)
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001890 elif options.verbose:
1891 logging.basicConfig(level=logging.INFO)
1892 else:
1893 logging.basicConfig(level=logging.ERROR)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001894
Edward Lemur50984a62020-02-06 18:10:18 +00001895 gerrit_obj = _parse_gerrit_options(parser, options)
1896 change = _parse_change(parser, options)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001897
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001898 try:
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001899 with canned_check_filter(options.skip_canned):
1900 results = DoPresubmitChecks(
Edward Lemur50984a62020-02-06 18:10:18 +00001901 change,
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001902 options.commit,
1903 options.verbose,
1904 sys.stdout,
1905 sys.stdin,
1906 options.default_presubmit,
1907 options.may_prompt,
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001908 gerrit_obj,
Edward Lesmes8e282792018-04-03 18:50:29 -04001909 options.dry_run,
Debrian Figueroadd2737e2019-06-21 23:50:13 +00001910 options.parallel,
1911 options.json_output)
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001912 return not results.should_continue()
Raul Tambre7c938462019-05-24 16:35:35 +00001913 except PresubmitFailure as e:
Raul Tambre80ee78e2019-05-06 22:41:05 +00001914 print(e, file=sys.stderr)
1915 print('Maybe your depot_tools is out of date?', file=sys.stderr)
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001916 return 2
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001917
1918
1919if __name__ == '__main__':
maruel@chromium.org35625c72011-03-23 17:34:02 +00001920 fix_encoding.fix_encoding()
sbc@chromium.org013731e2015-02-26 18:28:43 +00001921 try:
1922 sys.exit(main())
1923 except KeyboardInterrupt:
1924 sys.stderr.write('interrupted\n')
sergiybf8a3b382016-07-05 11:21:30 -07001925 sys.exit(2)