blob: 9b339d4e4ed3bdeba8dcd6bebe38959a15f7418a [file] [log] [blame]
maruel@chromium.org725f1c32011-04-01 20:24:54 +00001#!/usr/bin/env python
maruel@chromium.org3bbf2942012-01-10 16:52:06 +00002# Copyright (c) 2012 The Chromium Authors. All rights reserved.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00003# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5
6"""Enables directory-specific presubmit checks to run at upload and/or commit.
7"""
8
Raul Tambre80ee78e2019-05-06 22:41:05 +00009from __future__ import print_function
10
Saagar Sanghavi99816902020-08-11 22:41:25 +000011__version__ = '2.0.0'
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000012
13# TODO(joi) Add caching where appropriate/needed. The API is designed to allow
14# caching (between all different invocations of presubmit scripts for a given
15# change). We should add it as our presubmit scripts start feeling slow.
16
Edward Lemura5799e32020-01-17 19:26:51 +000017import argparse
Takeshi Yoshino07a6bea2017-08-02 02:44:06 +090018import ast # Exposed through the API.
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +000019import contextlib
Yoshisato Yanagisawa406de132018-06-29 05:43:25 +000020import cpplint
dcheng091b7db2016-06-16 01:27:51 -070021import fnmatch # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000022import glob
asvitkine@chromium.org15169952011-09-27 14:30:53 +000023import inspect
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +000024import itertools
maruel@chromium.org4f6852c2012-04-20 20:39:20 +000025import json # Exposed through the API.
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +000026import logging
ilevy@chromium.orgbc117312013-04-20 03:57:56 +000027import multiprocessing
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000028import os # Somewhat exposed through the API.
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +000029import random
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000030import re # Exposed through the API.
Edward Lesmes8e282792018-04-03 18:50:29 -040031import signal
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000032import sys # Parts exposed through API.
33import tempfile # Exposed through the API.
Edward Lesmes8e282792018-04-03 18:50:29 -040034import threading
jam@chromium.org2a891dc2009-08-20 20:33:37 +000035import time
Edward Lemurde9e3ca2019-10-24 21:13:31 +000036import traceback
maruel@chromium.org1487d532009-06-06 00:22:57 +000037import unittest # Exposed through the API.
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +000038from warnings import warn
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000039
40# Local imports.
maruel@chromium.org35625c72011-03-23 17:34:02 +000041import fix_encoding
Yoshisato Yanagisawa04600b42019-03-15 03:03:41 +000042import gclient_paths # Exposed through the API
43import gclient_utils
Aaron Gableb584c4f2017-04-26 16:28:08 -070044import git_footers
tandrii@chromium.org015ebae2016-04-25 19:37:22 +000045import gerrit_util
Edward Lesmes9ce03f82021-01-12 20:13:31 +000046import owners as owners_db
47import owners_client
Jochen Eisinger76f5fc62017-04-07 16:27:46 +020048import owners_finder
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000049import presubmit_canned_checks
Saagar Sanghavi9949ab72020-07-20 20:56:40 +000050import rdb_wrapper
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +000051import scm
maruel@chromium.org84f4fe32011-04-06 13:26:45 +000052import subprocess2 as subprocess # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000053
Edward Lemur16af3562019-10-17 22:11:33 +000054if sys.version_info.major == 2:
55 # TODO(1009814): Expose urllib2 only through urllib_request and urllib_error
56 import urllib2 # Exposed through the API.
57 import urlparse
58 import urllib2 as urllib_request
59 import urllib2 as urllib_error
60else:
61 import urllib.parse as urlparse
62 import urllib.request as urllib_request
63 import urllib.error as urllib_error
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000064
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +000065# Ask for feedback only once in program lifetime.
66_ASKED_FOR_FEEDBACK = False
67
Edward Lemurecc27072020-01-06 16:42:34 +000068def time_time():
69 # Use this so that it can be mocked in tests without interfering with python
70 # system machinery.
71 return time.time()
72
73
maruel@chromium.org899e1c12011-04-07 17:03:18 +000074class PresubmitFailure(Exception):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000075 pass
76
77
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000078class CommandData(object):
Edward Lemur940c2822019-08-23 00:34:25 +000079 def __init__(self, name, cmd, kwargs, message, python3=False):
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000080 self.name = name
81 self.cmd = cmd
Edward Lesmes8e282792018-04-03 18:50:29 -040082 self.stdin = kwargs.get('stdin', None)
Edward Lemur2d6b67c2019-08-23 22:25:41 +000083 self.kwargs = kwargs.copy()
Edward Lesmes8e282792018-04-03 18:50:29 -040084 self.kwargs['stdout'] = subprocess.PIPE
85 self.kwargs['stderr'] = subprocess.STDOUT
86 self.kwargs['stdin'] = subprocess.PIPE
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000087 self.message = message
88 self.info = None
Edward Lemur940c2822019-08-23 00:34:25 +000089 self.python3 = python3
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000090
ilevy@chromium.orgbc117312013-04-20 03:57:56 +000091
Edward Lesmes8e282792018-04-03 18:50:29 -040092# Adapted from
93# https://github.com/google/gtest-parallel/blob/master/gtest_parallel.py#L37
94#
95# An object that catches SIGINT sent to the Python process and notices
96# if processes passed to wait() die by SIGINT (we need to look for
97# both of those cases, because pressing Ctrl+C can result in either
98# the main process or one of the subprocesses getting the signal).
99#
100# Before a SIGINT is seen, wait(p) will simply call p.wait() and
101# return the result. Once a SIGINT has been seen (in the main process
102# or a subprocess, including the one the current call is waiting for),
Edward Lemur9a5bb612019-09-26 02:01:52 +0000103# wait(p) will call p.terminate().
Edward Lesmes8e282792018-04-03 18:50:29 -0400104class SigintHandler(object):
Edward Lesmes8e282792018-04-03 18:50:29 -0400105 sigint_returncodes = {-signal.SIGINT, # Unix
106 -1073741510, # Windows
107 }
108 def __init__(self):
109 self.__lock = threading.Lock()
110 self.__processes = set()
111 self.__got_sigint = False
Edward Lemur9a5bb612019-09-26 02:01:52 +0000112 self.__previous_signal = signal.signal(signal.SIGINT, self.interrupt)
Edward Lesmes8e282792018-04-03 18:50:29 -0400113
114 def __on_sigint(self):
115 self.__got_sigint = True
116 while self.__processes:
117 try:
118 self.__processes.pop().terminate()
119 except OSError:
120 pass
121
Edward Lemur9a5bb612019-09-26 02:01:52 +0000122 def interrupt(self, signal_num, frame):
Edward Lesmes8e282792018-04-03 18:50:29 -0400123 with self.__lock:
124 self.__on_sigint()
Edward Lemur9a5bb612019-09-26 02:01:52 +0000125 self.__previous_signal(signal_num, frame)
Edward Lesmes8e282792018-04-03 18:50:29 -0400126
127 def got_sigint(self):
128 with self.__lock:
129 return self.__got_sigint
130
131 def wait(self, p, stdin):
132 with self.__lock:
133 if self.__got_sigint:
134 p.terminate()
135 self.__processes.add(p)
136 stdout, stderr = p.communicate(stdin)
137 code = p.returncode
138 with self.__lock:
139 self.__processes.discard(p)
140 if code in self.sigint_returncodes:
141 self.__on_sigint()
Edward Lesmes8e282792018-04-03 18:50:29 -0400142 return stdout, stderr
143
144sigint_handler = SigintHandler()
145
146
Edward Lemurecc27072020-01-06 16:42:34 +0000147class Timer(object):
148 def __init__(self, timeout, fn):
149 self.completed = False
150 self._fn = fn
151 self._timer = threading.Timer(timeout, self._onTimer) if timeout else None
152
153 def __enter__(self):
154 if self._timer:
155 self._timer.start()
156 return self
157
158 def __exit__(self, _type, _value, _traceback):
159 if self._timer:
160 self._timer.cancel()
161
162 def _onTimer(self):
163 self._fn()
164 self.completed = True
165
166
Edward Lesmes8e282792018-04-03 18:50:29 -0400167class ThreadPool(object):
Edward Lemurecc27072020-01-06 16:42:34 +0000168 def __init__(self, pool_size=None, timeout=None):
169 self.timeout = timeout
Edward Lesmes8e282792018-04-03 18:50:29 -0400170 self._pool_size = pool_size or multiprocessing.cpu_count()
171 self._messages = []
172 self._messages_lock = threading.Lock()
173 self._tests = []
174 self._tests_lock = threading.Lock()
175 self._nonparallel_tests = []
176
Edward Lemurecc27072020-01-06 16:42:34 +0000177 def _GetCommand(self, test):
Edward Lemur940c2822019-08-23 00:34:25 +0000178 vpython = 'vpython'
179 if test.python3:
180 vpython += '3'
181 if sys.platform == 'win32':
182 vpython += '.bat'
Edward Lesmes8e282792018-04-03 18:50:29 -0400183
184 cmd = test.cmd
185 if cmd[0] == 'python':
186 cmd = list(cmd)
187 cmd[0] = vpython
188 elif cmd[0].endswith('.py'):
189 cmd = [vpython] + cmd
190
Edward Lemur336e51f2019-11-14 21:42:04 +0000191 # On Windows, scripts on the current directory take precedence over PATH, so
192 # that when testing depot_tools on Windows, calling `vpython.bat` will
193 # execute the copy of vpython of the depot_tools under test instead of the
194 # one in the bot.
195 # As a workaround, we run the tests from the parent directory instead.
196 if (cmd[0] == vpython and
197 'cwd' in test.kwargs and
198 os.path.basename(test.kwargs['cwd']) == 'depot_tools'):
199 test.kwargs['cwd'] = os.path.dirname(test.kwargs['cwd'])
200 cmd[1] = os.path.join('depot_tools', cmd[1])
201
Edward Lemurecc27072020-01-06 16:42:34 +0000202 return cmd
203
204 def _RunWithTimeout(self, cmd, stdin, kwargs):
205 p = subprocess.Popen(cmd, **kwargs)
206 with Timer(self.timeout, p.terminate) as timer:
207 stdout, _ = sigint_handler.wait(p, stdin)
208 if timer.completed:
209 stdout = 'Process timed out after %ss\n%s' % (self.timeout, stdout)
210 return p.returncode, stdout
211
212 def CallCommand(self, test):
213 """Runs an external program.
214
Edward Lemura5799e32020-01-17 19:26:51 +0000215 This function converts invocation of .py files and invocations of 'python'
Edward Lemurecc27072020-01-06 16:42:34 +0000216 to vpython invocations.
217 """
218 cmd = self._GetCommand(test)
Edward Lesmes8e282792018-04-03 18:50:29 -0400219 try:
Edward Lemurecc27072020-01-06 16:42:34 +0000220 start = time_time()
221 returncode, stdout = self._RunWithTimeout(cmd, test.stdin, test.kwargs)
222 duration = time_time() - start
Edward Lemur7cf94382019-11-15 22:36:41 +0000223 except Exception:
Edward Lemurecc27072020-01-06 16:42:34 +0000224 duration = time_time() - start
Edward Lesmes8e282792018-04-03 18:50:29 -0400225 return test.message(
Edward Lemur7cf94382019-11-15 22:36:41 +0000226 '%s\n%s exec failure (%4.2fs)\n%s' % (
227 test.name, ' '.join(cmd), duration, traceback.format_exc()))
Edward Lemurde9e3ca2019-10-24 21:13:31 +0000228
Edward Lemurecc27072020-01-06 16:42:34 +0000229 if returncode != 0:
Edward Lesmes8e282792018-04-03 18:50:29 -0400230 return test.message(
Edward Lemur7cf94382019-11-15 22:36:41 +0000231 '%s\n%s (%4.2fs) failed\n%s' % (
232 test.name, ' '.join(cmd), duration, stdout))
Edward Lemurecc27072020-01-06 16:42:34 +0000233
Edward Lesmes8e282792018-04-03 18:50:29 -0400234 if test.info:
Edward Lemur7cf94382019-11-15 22:36:41 +0000235 return test.info('%s\n%s (%4.2fs)' % (test.name, ' '.join(cmd), duration))
Edward Lesmes8e282792018-04-03 18:50:29 -0400236
237 def AddTests(self, tests, parallel=True):
238 if parallel:
239 self._tests.extend(tests)
240 else:
241 self._nonparallel_tests.extend(tests)
242
243 def RunAsync(self):
244 self._messages = []
245
246 def _WorkerFn():
247 while True:
248 test = None
249 with self._tests_lock:
250 if not self._tests:
251 break
252 test = self._tests.pop()
253 result = self.CallCommand(test)
254 if result:
255 with self._messages_lock:
256 self._messages.append(result)
257
258 def _StartDaemon():
259 t = threading.Thread(target=_WorkerFn)
260 t.daemon = True
261 t.start()
262 return t
263
264 while self._nonparallel_tests:
265 test = self._nonparallel_tests.pop()
266 result = self.CallCommand(test)
267 if result:
268 self._messages.append(result)
269
270 if self._tests:
271 threads = [_StartDaemon() for _ in range(self._pool_size)]
272 for worker in threads:
273 worker.join()
274
275 return self._messages
276
277
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000278def normpath(path):
279 '''Version of os.path.normpath that also changes backward slashes to
280 forward slashes when not running on Windows.
281 '''
282 # This is safe to always do because the Windows version of os.path.normpath
283 # will replace forward slashes with backward slashes.
284 path = path.replace(os.sep, '/')
285 return os.path.normpath(path)
286
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000287
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000288def _RightHandSideLinesImpl(affected_files):
289 """Implements RightHandSideLines for InputApi and GclChange."""
290 for af in affected_files:
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000291 lines = af.ChangedContents()
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000292 for line in lines:
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000293 yield (af, line[0], line[1])
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000294
295
Edward Lemur6eb1d322020-02-27 22:20:15 +0000296def prompt_should_continue(prompt_string):
297 sys.stdout.write(prompt_string)
298 response = sys.stdin.readline().strip().lower()
299 return response in ('y', 'yes')
dpranke@chromium.org5ac21012011-03-16 02:58:25 +0000300
301
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000302# Top level object so multiprocessing can pickle
303# Public access through OutputApi object.
304class _PresubmitResult(object):
305 """Base class for result objects."""
306 fatal = False
307 should_prompt = False
308
309 def __init__(self, message, items=None, long_text=''):
310 """
311 message: A short one-line message to indicate errors.
312 items: A list of short strings to indicate where errors occurred.
313 long_text: multi-line text output, e.g. from another tool
314 """
315 self._message = message
316 self._items = items or []
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000317 self._long_text = long_text.rstrip()
318
Edward Lemur6eb1d322020-02-27 22:20:15 +0000319 def handle(self):
320 sys.stdout.write(self._message)
321 sys.stdout.write('\n')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000322 for index, item in enumerate(self._items):
Edward Lemur6eb1d322020-02-27 22:20:15 +0000323 sys.stdout.write(' ')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000324 # Write separately in case it's unicode.
Edward Lemur6eb1d322020-02-27 22:20:15 +0000325 sys.stdout.write(str(item))
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000326 if index < len(self._items) - 1:
Edward Lemur6eb1d322020-02-27 22:20:15 +0000327 sys.stdout.write(' \\')
328 sys.stdout.write('\n')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000329 if self._long_text:
Edward Lemur6eb1d322020-02-27 22:20:15 +0000330 sys.stdout.write('\n***************\n')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000331 # Write separately in case it's unicode.
Edward Lemur6eb1d322020-02-27 22:20:15 +0000332 sys.stdout.write(self._long_text)
333 sys.stdout.write('\n***************\n')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000334
Debrian Figueroadd2737e2019-06-21 23:50:13 +0000335 def json_format(self):
336 return {
337 'message': self._message,
Debrian Figueroa6095d402019-06-28 18:47:18 +0000338 'items': [str(item) for item in self._items],
Debrian Figueroadd2737e2019-06-21 23:50:13 +0000339 'long_text': self._long_text,
340 'fatal': self.fatal
341 }
342
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000343
344# Top level object so multiprocessing can pickle
345# Public access through OutputApi object.
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000346class _PresubmitError(_PresubmitResult):
347 """A hard presubmit error."""
348 fatal = True
349
350
351# Top level object so multiprocessing can pickle
352# Public access through OutputApi object.
353class _PresubmitPromptWarning(_PresubmitResult):
354 """An warning that prompts the user if they want to continue."""
355 should_prompt = True
356
357
358# Top level object so multiprocessing can pickle
359# Public access through OutputApi object.
360class _PresubmitNotifyResult(_PresubmitResult):
361 """Just print something to the screen -- but it's not even a warning."""
362 pass
363
364
365# Top level object so multiprocessing can pickle
366# Public access through OutputApi object.
367class _MailTextResult(_PresubmitResult):
368 """A warning that should be included in the review request email."""
369 def __init__(self, *args, **kwargs):
370 super(_MailTextResult, self).__init__()
371 raise NotImplementedError()
372
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000373class GerritAccessor(object):
374 """Limited Gerrit functionality for canned presubmit checks to work.
375
376 To avoid excessive Gerrit calls, caches the results.
377 """
378
Edward Lesmeseb1bd622021-03-01 19:54:07 +0000379 def __init__(self, url=None, project=None, branch=None):
380 self.host = urlparse.urlparse(url).netloc if url else None
381 self.project = project
382 self.branch = branch
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000383 self.cache = {}
384
385 def _FetchChangeDetail(self, issue):
386 # Separate function to be easily mocked in tests.
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +0100387 try:
388 return gerrit_util.GetChangeDetail(
389 self.host, str(issue),
Aaron Gable6f5a8d92017-04-18 14:49:05 -0700390 ['ALL_REVISIONS', 'DETAILED_LABELS', 'ALL_COMMITS'])
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +0100391 except gerrit_util.GerritError as e:
392 if e.http_status == 404:
393 raise Exception('Either Gerrit issue %s doesn\'t exist, or '
394 'no credentials to fetch issue details' % issue)
395 raise
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000396
397 def GetChangeInfo(self, issue):
398 """Returns labels and all revisions (patchsets) for this issue.
399
400 The result is a dictionary according to Gerrit REST Api.
401 https://gerrit-review.googlesource.com/Documentation/rest-api.html
402
403 However, API isn't very clear what's inside, so see tests for example.
404 """
405 assert issue
406 cache_key = int(issue)
407 if cache_key not in self.cache:
408 self.cache[cache_key] = self._FetchChangeDetail(issue)
409 return self.cache[cache_key]
410
411 def GetChangeDescription(self, issue, patchset=None):
412 """If patchset is none, fetches current patchset."""
413 info = self.GetChangeInfo(issue)
414 # info is a reference to cache. We'll modify it here adding description to
415 # it to the right patchset, if it is not yet there.
416
417 # Find revision info for the patchset we want.
418 if patchset is not None:
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +0000419 for rev, rev_info in info['revisions'].items():
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000420 if str(rev_info['_number']) == str(patchset):
421 break
422 else:
423 raise Exception('patchset %s doesn\'t exist in issue %s' % (
424 patchset, issue))
425 else:
426 rev = info['current_revision']
427 rev_info = info['revisions'][rev]
428
Andrii Shyshkalov9c3a4642017-01-24 17:41:22 +0100429 return rev_info['commit']['message']
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000430
Mun Yong Jang603d01e2017-12-19 16:38:30 -0800431 def GetDestRef(self, issue):
432 ref = self.GetChangeInfo(issue)['branch']
433 if not ref.startswith('refs/'):
434 # NOTE: it is possible to create 'refs/x' branch,
435 # aka 'refs/heads/refs/x'. However, this is ill-advised.
436 ref = 'refs/heads/%s' % ref
437 return ref
438
Edward Lesmes02d4b822020-11-11 00:37:35 +0000439 def _GetApproversForLabel(self, issue, label):
440 change_info = self.GetChangeInfo(issue)
441 label_info = change_info.get('labels', {}).get(label, {})
442 values = label_info.get('values', {}).keys()
443 if not values:
444 return []
445 max_value = max(int(v) for v in values)
446 return [v for v in label_info.get('all', [])
447 if v.get('value', 0) == max_value]
448
Edward Lesmesc4566172021-03-19 16:55:13 +0000449 def IsBotCommitApproved(self, issue):
450 return bool(self._GetApproversForLabel(issue, 'Bot-Commit'))
451
Edward Lesmescf49cb82020-11-11 01:08:36 +0000452 def IsOwnersOverrideApproved(self, issue):
453 return bool(self._GetApproversForLabel(issue, 'Owners-Override'))
454
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000455 def GetChangeOwner(self, issue):
456 return self.GetChangeInfo(issue)['owner']['email']
457
458 def GetChangeReviewers(self, issue, approving_only=True):
Aaron Gable8b478f02017-07-31 15:33:19 -0700459 changeinfo = self.GetChangeInfo(issue)
460 if approving_only:
Edward Lesmes02d4b822020-11-11 00:37:35 +0000461 reviewers = self._GetApproversForLabel(issue, 'Code-Review')
Aaron Gable8b478f02017-07-31 15:33:19 -0700462 else:
463 reviewers = changeinfo.get('reviewers', {}).get('REVIEWER', [])
464 return [r.get('email') for r in reviewers]
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000465
Edward Lemure4d329c2020-02-03 20:41:18 +0000466 def UpdateDescription(self, description, issue):
467 gerrit_util.SetCommitMessage(self.host, issue, description, notify='NONE')
468
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000469
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000470class OutputApi(object):
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000471 """An instance of OutputApi gets passed to presubmit scripts so that they
472 can output various types of results.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000473 """
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000474 PresubmitResult = _PresubmitResult
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000475 PresubmitError = _PresubmitError
476 PresubmitPromptWarning = _PresubmitPromptWarning
477 PresubmitNotifyResult = _PresubmitNotifyResult
478 MailTextResult = _MailTextResult
479
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000480 def __init__(self, is_committing):
481 self.is_committing = is_committing
Daniel Cheng7227d212017-11-17 08:12:37 -0800482 self.more_cc = []
483
484 def AppendCC(self, cc):
485 """Appends a user to cc for this change."""
486 self.more_cc.append(cc)
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000487
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000488 def PresubmitPromptOrNotify(self, *args, **kwargs):
489 """Warn the user when uploading, but only notify if committing."""
490 if self.is_committing:
491 return self.PresubmitNotifyResult(*args, **kwargs)
492 return self.PresubmitPromptWarning(*args, **kwargs)
493
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000494
495class InputApi(object):
496 """An instance of this object is passed to presubmit scripts so they can
497 know stuff about the change they're looking at.
498 """
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000499 # Method could be a function
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800500 # pylint: disable=no-self-use
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000501
maruel@chromium.org3410d912009-06-09 20:56:16 +0000502 # File extensions that are considered source files from a style guide
503 # perspective. Don't modify this list from a presubmit script!
maruel@chromium.orgc33455a2011-06-24 19:14:18 +0000504 #
505 # Files without an extension aren't included in the list. If you want to
local_bot30f774e2020-06-25 18:23:34 +0000506 # filter them as source files, add r'(^|.*?[\\\/])[^.]+$' to the allow list.
local_bot64021412020-07-08 21:05:39 +0000507 # Note that ALL CAPS files are skipped in DEFAULT_FILES_TO_SKIP below.
508 DEFAULT_FILES_TO_CHECK = (
maruel@chromium.org3410d912009-06-09 20:56:16 +0000509 # C++ and friends
Edward Lemura5799e32020-01-17 19:26:51 +0000510 r'.+\.c$', r'.+\.cc$', r'.+\.cpp$', r'.+\.h$', r'.+\.m$', r'.+\.mm$',
511 r'.+\.inl$', r'.+\.asm$', r'.+\.hxx$', r'.+\.hpp$', r'.+\.s$', r'.+\.S$',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000512 # Scripts
Edward Lemura5799e32020-01-17 19:26:51 +0000513 r'.+\.js$', r'.+\.py$', r'.+\.sh$', r'.+\.rb$', r'.+\.pl$', r'.+\.pm$',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000514 # Other
Edward Lemura5799e32020-01-17 19:26:51 +0000515 r'.+\.java$', r'.+\.mk$', r'.+\.am$', r'.+\.css$', r'.+\.mojom$',
516 r'.+\.fidl$'
maruel@chromium.org3410d912009-06-09 20:56:16 +0000517 )
518
519 # Path regexp that should be excluded from being considered containing source
520 # files. Don't modify this list from a presubmit script!
local_bot64021412020-07-08 21:05:39 +0000521 DEFAULT_FILES_TO_SKIP = (
Edward Lemura5799e32020-01-17 19:26:51 +0000522 r'testing_support[\\\/]google_appengine[\\\/].*',
523 r'.*\bexperimental[\\\/].*',
Kent Tamura179dd1e2018-04-26 15:07:41 +0900524 # Exclude third_party/.* but NOT third_party/{WebKit,blink}
525 # (crbug.com/539768 and crbug.com/836555).
Edward Lemura5799e32020-01-17 19:26:51 +0000526 r'.*\bthird_party[\\\/](?!(WebKit|blink)[\\\/]).*',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000527 # Output directories (just in case)
Edward Lemura5799e32020-01-17 19:26:51 +0000528 r'.*\bDebug[\\\/].*',
529 r'.*\bRelease[\\\/].*',
530 r'.*\bxcodebuild[\\\/].*',
531 r'.*\bout[\\\/].*',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000532 # All caps files like README and LICENCE.
Edward Lemura5799e32020-01-17 19:26:51 +0000533 r'.*\b[A-Z0-9_]{2,}$',
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +0000534 # SCM (can happen in dual SCM configuration). (Slightly over aggressive)
Edward Lemura5799e32020-01-17 19:26:51 +0000535 r'(|.*[\\\/])\.git[\\\/].*',
536 r'(|.*[\\\/])\.svn[\\\/].*',
maruel@chromium.org7ccb4bb2011-11-07 20:26:20 +0000537 # There is no point in processing a patch file.
Edward Lemura5799e32020-01-17 19:26:51 +0000538 r'.+\.diff$',
539 r'.+\.patch$',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000540 )
541
local_bot30f774e2020-06-25 18:23:34 +0000542 # TODO(https://crbug.com/1098562): Remove once no longer used
543 @property
544 def DEFAULT_WHITE_LIST(self):
local_bot64021412020-07-08 21:05:39 +0000545 return self.DEFAULT_FILES_TO_CHECK
local_bot30f774e2020-06-25 18:23:34 +0000546
547 # TODO(https://crbug.com/1098562): Remove once no longer used
local_bot37ce2012020-06-26 17:39:24 +0000548 @DEFAULT_WHITE_LIST.setter
549 def DEFAULT_WHITE_LIST(self, value):
local_bot64021412020-07-08 21:05:39 +0000550 self.DEFAULT_FILES_TO_CHECK = value
551
552 # TODO(https://crbug.com/1098562): Remove once no longer used
553 @property
554 def DEFAULT_ALLOW_LIST(self):
555 return self.DEFAULT_FILES_TO_CHECK
556
557 # TODO(https://crbug.com/1098562): Remove once no longer used
558 @DEFAULT_ALLOW_LIST.setter
559 def DEFAULT_ALLOW_LIST(self, value):
560 self.DEFAULT_FILES_TO_CHECK = value
local_bot37ce2012020-06-26 17:39:24 +0000561
562 # TODO(https://crbug.com/1098562): Remove once no longer used
local_bot30f774e2020-06-25 18:23:34 +0000563 @property
564 def DEFAULT_BLACK_LIST(self):
local_bot64021412020-07-08 21:05:39 +0000565 return self.DEFAULT_FILES_TO_SKIP
local_bot30f774e2020-06-25 18:23:34 +0000566
local_bot37ce2012020-06-26 17:39:24 +0000567 # TODO(https://crbug.com/1098562): Remove once no longer used
568 @DEFAULT_BLACK_LIST.setter
569 def DEFAULT_BLACK_LIST(self, value):
local_bot64021412020-07-08 21:05:39 +0000570 self.DEFAULT_FILES_TO_SKIP = value
571
572 # TODO(https://crbug.com/1098562): Remove once no longer used
573 @property
574 def DEFAULT_BLOCK_LIST(self):
575 return self.DEFAULT_FILES_TO_SKIP
576
577 # TODO(https://crbug.com/1098562): Remove once no longer used
578 @DEFAULT_BLOCK_LIST.setter
579 def DEFAULT_BLOCK_LIST(self, value):
580 self.DEFAULT_FILES_TO_SKIP = value
local_bot37ce2012020-06-26 17:39:24 +0000581
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000582 def __init__(self, change, presubmit_path, is_committing,
Edward Lesmes8e282792018-04-03 18:50:29 -0400583 verbose, gerrit_obj, dry_run=None, thread_pool=None, parallel=False):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000584 """Builds an InputApi object.
585
586 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000587 change: A presubmit.Change object.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000588 presubmit_path: The path to the presubmit script being processed.
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000589 is_committing: True if the change is about to be committed.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000590 gerrit_obj: provides basic Gerrit codereview functionality.
591 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -0400592 parallel: if true, all tests reported via input_api.RunTests for all
593 PRESUBMIT files will be run in parallel.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000594 """
maruel@chromium.org9711bba2009-05-22 23:51:39 +0000595 # Version number of the presubmit_support script.
596 self.version = [int(x) for x in __version__.split('.')]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000597 self.change = change
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000598 self.is_committing = is_committing
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000599 self.gerrit = gerrit_obj
tandrii@chromium.org57bafac2016-04-28 05:09:03 +0000600 self.dry_run = dry_run
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000601
Edward Lesmes8e282792018-04-03 18:50:29 -0400602 self.parallel = parallel
603 self.thread_pool = thread_pool or ThreadPool()
604
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000605 # We expose various modules and functions as attributes of the input_api
606 # so that presubmit scripts don't have to import them.
Takeshi Yoshino07a6bea2017-08-02 02:44:06 +0900607 self.ast = ast
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000608 self.basename = os.path.basename
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000609 self.cpplint = cpplint
dcheng091b7db2016-06-16 01:27:51 -0700610 self.fnmatch = fnmatch
Yoshisato Yanagisawa04600b42019-03-15 03:03:41 +0000611 self.gclient_paths = gclient_paths
Yoshisato Yanagisawa57dd17b2019-03-22 09:10:29 +0000612 # TODO(yyanagisawa): stop exposing this when python3 become default.
613 # Since python3's tempfile has TemporaryDirectory, we do not need this.
614 self.temporary_directory = gclient_utils.temporary_directory
dpranke@chromium.org17cc2442012-10-17 21:12:09 +0000615 self.glob = glob.glob
maruel@chromium.orgfb11c7b2010-03-18 18:22:14 +0000616 self.json = json
maruel@chromium.org6fba34d2011-06-02 13:45:12 +0000617 self.logging = logging.getLogger('PRESUBMIT')
maruel@chromium.org2b5ce562011-03-31 16:15:44 +0000618 self.os_listdir = os.listdir
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000619 self.os_path = os.path
pgervais@chromium.orgbd0cace2014-10-02 23:23:46 +0000620 self.os_stat = os.stat
Yoshisato Yanagisawa406de132018-06-29 05:43:25 +0000621 self.os_walk = os.walk
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000622 self.re = re
623 self.subprocess = subprocess
Edward Lemurb9830242019-10-30 22:19:20 +0000624 self.sys = sys
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000625 self.tempfile = tempfile
dpranke@chromium.org0d1bdea2011-03-24 22:54:38 +0000626 self.time = time
maruel@chromium.org1487d532009-06-06 00:22:57 +0000627 self.unittest = unittest
Edward Lemurb9830242019-10-30 22:19:20 +0000628 if sys.version_info.major == 2:
629 self.urllib2 = urllib2
Edward Lemur16af3562019-10-17 22:11:33 +0000630 self.urllib_request = urllib_request
631 self.urllib_error = urllib_error
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000632
Robert Iannucci50258932018-03-19 10:30:59 -0700633 self.is_windows = sys.platform == 'win32'
634
Edward Lemurb9646622019-10-25 20:57:35 +0000635 # Set python_executable to 'vpython' in order to allow scripts in other
636 # repos (e.g. src.git) to automatically pick up that repo's .vpython file,
637 # instead of inheriting the one in depot_tools.
638 self.python_executable = 'vpython'
maruel@chromium.orgc0b22972009-06-25 16:19:14 +0000639 self.environ = os.environ
640
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000641 # InputApi.platform is the platform you're currently running on.
642 self.platform = sys.platform
643
iannucci@chromium.org0af3bb32015-06-12 20:44:35 +0000644 self.cpu_count = multiprocessing.cpu_count()
645
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000646 # The local path of the currently-being-processed presubmit script.
maruel@chromium.org3d235242009-05-15 12:40:48 +0000647 self._current_presubmit_path = os.path.dirname(presubmit_path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000648
649 # We carry the canned checks so presubmit scripts can easily use them.
650 self.canned_checks = presubmit_canned_checks
651
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +0100652 # Temporary files we must manually remove at the end of a run.
653 self._named_temporary_files = []
Jochen Eisinger72606f82017-04-04 10:44:18 +0200654
Edward Lesmesdc11c6b2021-03-19 19:22:05 +0000655 self.owners_client = None
656 if self.gerrit:
657 self.owners_client = owners_client.GetCodeOwnersClient(
658 root=change.RepositoryRoot(),
659 upstream=change.UpstreamBranch(),
660 host=self.gerrit.host,
661 project=self.gerrit.project,
662 branch=self.gerrit.branch)
Edward Lesmes9ce03f82021-01-12 20:13:31 +0000663 self.owners_db = owners_db.Database(
664 change.RepositoryRoot(), fopen=open, os_path=self.os_path)
Jochen Eisinger76f5fc62017-04-07 16:27:46 +0200665 self.owners_finder = owners_finder.OwnersFinder
maruel@chromium.org899e1c12011-04-07 17:03:18 +0000666 self.verbose = verbose
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000667 self.Command = CommandData
dpranke@chromium.org2a009622011-03-01 02:43:31 +0000668
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000669 # Replace <hash_map> and <hash_set> as headers that need to be included
Edward Lemura5799e32020-01-17 19:26:51 +0000670 # with 'base/containers/hash_tables.h' instead.
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000671 # Access to a protected member _XX of a client class
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800672 # pylint: disable=protected-access
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000673 self.cpplint._re_pattern_templates = [
danakj@chromium.org18278522013-06-11 22:42:32 +0000674 (a, b, 'base/containers/hash_tables.h')
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000675 if header in ('<hash_map>', '<hash_set>') else (a, b, header)
676 for (a, b, header) in cpplint._re_pattern_templates
677 ]
678
Edward Lemurecc27072020-01-06 16:42:34 +0000679 def SetTimeout(self, timeout):
680 self.thread_pool.timeout = timeout
681
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000682 def PresubmitLocalPath(self):
683 """Returns the local path of the presubmit script currently being run.
684
685 This is useful if you don't want to hard-code absolute paths in the
686 presubmit script. For example, It can be used to find another file
687 relative to the PRESUBMIT.py script, so the whole tree can be branched and
688 the presubmit script still works, without editing its content.
689 """
maruel@chromium.org3d235242009-05-15 12:40:48 +0000690 return self._current_presubmit_path
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000691
agable0b65e732016-11-22 09:25:46 -0800692 def AffectedFiles(self, include_deletes=True, file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000693 """Same as input_api.change.AffectedFiles() except only lists files
694 (and optionally directories) in the same directory as the current presubmit
Bruce Dawson7a0b07a2020-04-23 17:14:40 +0000695 script, or subdirectories thereof. Note that files are listed using the OS
696 path separator, so backslashes are used as separators on Windows.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000697 """
Edward Lemura5799e32020-01-17 19:26:51 +0000698 dir_with_slash = normpath('%s/' % self.PresubmitLocalPath())
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000699 if len(dir_with_slash) == 1:
700 dir_with_slash = ''
sail@chromium.org5538e022011-05-12 17:53:16 +0000701
Edward Lemurb9830242019-10-30 22:19:20 +0000702 return list(filter(
maruel@chromium.org4661e0c2009-06-04 00:45:26 +0000703 lambda x: normpath(x.AbsoluteLocalPath()).startswith(dir_with_slash),
Edward Lemurb9830242019-10-30 22:19:20 +0000704 self.change.AffectedFiles(include_deletes, file_filter)))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000705
agable0b65e732016-11-22 09:25:46 -0800706 def LocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000707 """Returns local paths of input_api.AffectedFiles()."""
agable0b65e732016-11-22 09:25:46 -0800708 paths = [af.LocalPath() for af in self.AffectedFiles()]
Edward Lemura5799e32020-01-17 19:26:51 +0000709 logging.debug('LocalPaths: %s', paths)
pgervais@chromium.org2f64f782014-04-25 00:12:33 +0000710 return paths
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000711
agable0b65e732016-11-22 09:25:46 -0800712 def AbsoluteLocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000713 """Returns absolute local paths of input_api.AffectedFiles()."""
agable0b65e732016-11-22 09:25:46 -0800714 return [af.AbsoluteLocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000715
John Budorick16162372018-04-18 10:39:53 -0700716 def AffectedTestableFiles(self, include_deletes=None, **kwargs):
agable0b65e732016-11-22 09:25:46 -0800717 """Same as input_api.change.AffectedTestableFiles() except only lists files
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000718 in the same directory as the current presubmit script, or subdirectories
719 thereof.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000720 """
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000721 if include_deletes is not None:
Edward Lemura5799e32020-01-17 19:26:51 +0000722 warn('AffectedTestableFiles(include_deletes=%s)'
723 ' is deprecated and ignored' % str(include_deletes),
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000724 category=DeprecationWarning,
725 stacklevel=2)
Edward Lemurb9830242019-10-30 22:19:20 +0000726 return list(filter(
727 lambda x: x.IsTestableFile(),
728 self.AffectedFiles(include_deletes=False, **kwargs)))
agable0b65e732016-11-22 09:25:46 -0800729
730 def AffectedTextFiles(self, include_deletes=None):
731 """An alias to AffectedTestableFiles for backwards compatibility."""
732 return self.AffectedTestableFiles(include_deletes=include_deletes)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000733
Josip Sokcevic8c955952021-02-01 21:32:57 +0000734 def FilterSourceFile(self,
735 affected_file,
736 files_to_check=None,
737 files_to_skip=None,
738 allow_list=None,
739 block_list=None):
Edward Lemura5799e32020-01-17 19:26:51 +0000740 """Filters out files that aren't considered 'source file'.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000741
local_bot64021412020-07-08 21:05:39 +0000742 If files_to_check or files_to_skip is None, InputApi.DEFAULT_FILES_TO_CHECK
743 and InputApi.DEFAULT_FILES_TO_SKIP is used respectively.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000744
745 The lists will be compiled as regular expression and
746 AffectedFile.LocalPath() needs to pass both list.
747
748 Note: Copy-paste this function to suit your needs or use a lambda function.
749 """
local_bot64021412020-07-08 21:05:39 +0000750 if files_to_check is None:
751 files_to_check = self.DEFAULT_FILES_TO_CHECK
752 if files_to_skip is None:
753 files_to_skip = self.DEFAULT_FILES_TO_SKIP
local_bot30f774e2020-06-25 18:23:34 +0000754
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000755 def Find(affected_file, items):
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000756 local_path = affected_file.LocalPath()
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000757 for item in items:
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +0000758 if self.re.match(item, local_path):
maruel@chromium.org3410d912009-06-09 20:56:16 +0000759 return True
760 return False
local_bot64021412020-07-08 21:05:39 +0000761 return (Find(affected_file, files_to_check) and
762 not Find(affected_file, files_to_skip))
maruel@chromium.org3410d912009-06-09 20:56:16 +0000763
764 def AffectedSourceFiles(self, source_file):
agable0b65e732016-11-22 09:25:46 -0800765 """Filter the list of AffectedTestableFiles by the function source_file.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000766
767 If source_file is None, InputApi.FilterSourceFile() is used.
768 """
769 if not source_file:
770 source_file = self.FilterSourceFile
Edward Lemurb9830242019-10-30 22:19:20 +0000771 return list(filter(source_file, self.AffectedTestableFiles()))
maruel@chromium.org3410d912009-06-09 20:56:16 +0000772
773 def RightHandSideLines(self, source_file_filter=None):
Edward Lemura5799e32020-01-17 19:26:51 +0000774 """An iterator over all text lines in 'new' version of changed files.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000775
776 Only lists lines from new or modified text files in the change that are
777 contained by the directory of the currently executing presubmit script.
778
779 This is useful for doing line-by-line regex checks, like checking for
780 trailing whitespace.
781
782 Yields:
783 a 3 tuple:
784 the AffectedFile instance of the current file;
785 integer line number (1-based); and
786 the contents of the line as a string.
maruel@chromium.org1487d532009-06-06 00:22:57 +0000787
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000788 Note: The carriage return (LF or CR) is stripped off.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000789 """
maruel@chromium.org3410d912009-06-09 20:56:16 +0000790 files = self.AffectedSourceFiles(source_file_filter)
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000791 return _RightHandSideLinesImpl(files)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000792
maruel@chromium.orge3608df2009-11-10 20:22:57 +0000793 def ReadFile(self, file_item, mode='r'):
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000794 """Reads an arbitrary file.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000795
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000796 Deny reading anything outside the repository.
797 """
maruel@chromium.orge3608df2009-11-10 20:22:57 +0000798 if isinstance(file_item, AffectedFile):
799 file_item = file_item.AbsoluteLocalPath()
800 if not file_item.startswith(self.change.RepositoryRoot()):
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000801 raise IOError('Access outside the repository root is denied.')
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +0000802 return gclient_utils.FileRead(file_item, mode)
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000803
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +0100804 def CreateTemporaryFile(self, **kwargs):
805 """Returns a named temporary file that must be removed with a call to
806 RemoveTemporaryFiles().
807
808 All keyword arguments are forwarded to tempfile.NamedTemporaryFile(),
809 except for |delete|, which is always set to False.
810
811 Presubmit checks that need to create a temporary file and pass it for
812 reading should use this function instead of NamedTemporaryFile(), as
813 Windows fails to open a file that is already open for writing.
814
815 with input_api.CreateTemporaryFile() as f:
816 f.write('xyz')
817 f.close()
818 input_api.subprocess.check_output(['script-that', '--reads-from',
819 f.name])
820
821
822 Note that callers of CreateTemporaryFile() should not worry about removing
823 any temporary file; this is done transparently by the presubmit handling
824 code.
825 """
826 if 'delete' in kwargs:
827 # Prevent users from passing |delete|; we take care of file deletion
828 # ourselves and this prevents unintuitive error messages when we pass
829 # delete=False and 'delete' is also in kwargs.
830 raise TypeError('CreateTemporaryFile() does not take a "delete" '
831 'argument, file deletion is handled automatically by '
832 'the same presubmit_support code that creates InputApi '
833 'objects.')
834 temp_file = self.tempfile.NamedTemporaryFile(delete=False, **kwargs)
835 self._named_temporary_files.append(temp_file.name)
836 return temp_file
837
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000838 @property
839 def tbr(self):
840 """Returns if a change is TBR'ed."""
Jeremy Romandce22502017-06-20 15:37:29 -0400841 return 'TBR' in self.change.tags or self.change.TBRsFromDescription()
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000842
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +0000843 def RunTests(self, tests_mix, parallel=True):
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000844 tests = []
845 msgs = []
846 for t in tests_mix:
Edward Lesmes8e282792018-04-03 18:50:29 -0400847 if isinstance(t, OutputApi.PresubmitResult) and t:
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000848 msgs.append(t)
849 else:
850 assert issubclass(t.message, _PresubmitResult)
851 tests.append(t)
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +0000852 if self.verbose:
853 t.info = _PresubmitNotifyResult
Edward Lemur1037c742018-05-01 18:56:04 -0400854 if not t.kwargs.get('cwd'):
855 t.kwargs['cwd'] = self.PresubmitLocalPath()
Edward Lesmes8e282792018-04-03 18:50:29 -0400856 self.thread_pool.AddTests(tests, parallel)
Edward Lemur21000eb2019-05-24 23:25:58 +0000857 # When self.parallel is True (i.e. --parallel is passed as an option)
858 # RunTests doesn't actually run tests. It adds them to a ThreadPool that
859 # will run all tests once all PRESUBMIT files are processed.
860 # Otherwise, it will run them and return the results.
861 if not self.parallel:
Edward Lesmes8e282792018-04-03 18:50:29 -0400862 msgs.extend(self.thread_pool.RunAsync())
863 return msgs
scottmg86099d72016-09-01 09:16:51 -0700864
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000865
nick@chromium.orgff526192013-06-10 19:30:26 +0000866class _DiffCache(object):
867 """Caches diffs retrieved from a particular SCM."""
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000868 def __init__(self, upstream=None):
869 """Stores the upstream revision against which all diffs will be computed."""
870 self._upstream = upstream
nick@chromium.orgff526192013-06-10 19:30:26 +0000871
872 def GetDiff(self, path, local_root):
873 """Get the diff for a particular path."""
874 raise NotImplementedError()
875
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700876 def GetOldContents(self, path, local_root):
877 """Get the old version for a particular path."""
878 raise NotImplementedError()
879
nick@chromium.orgff526192013-06-10 19:30:26 +0000880
nick@chromium.orgff526192013-06-10 19:30:26 +0000881class _GitDiffCache(_DiffCache):
882 """DiffCache implementation for git; gets all file diffs at once."""
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000883 def __init__(self, upstream):
884 super(_GitDiffCache, self).__init__(upstream=upstream)
nick@chromium.orgff526192013-06-10 19:30:26 +0000885 self._diffs_by_file = None
886
887 def GetDiff(self, path, local_root):
888 if not self._diffs_by_file:
889 # Compute a single diff for all files and parse the output; should
890 # with git this is much faster than computing one diff for each file.
891 diffs = {}
892
893 # Don't specify any filenames below, because there are command line length
894 # limits on some platforms and GenerateDiff would fail.
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000895 unified_diff = scm.GIT.GenerateDiff(local_root, files=[], full_move=True,
896 branch=self._upstream)
nick@chromium.orgff526192013-06-10 19:30:26 +0000897
898 # This regex matches the path twice, separated by a space. Note that
899 # filename itself may contain spaces.
900 file_marker = re.compile('^diff --git (?P<filename>.*) (?P=filename)$')
901 current_diff = []
902 keep_line_endings = True
903 for x in unified_diff.splitlines(keep_line_endings):
904 match = file_marker.match(x)
905 if match:
906 # Marks the start of a new per-file section.
907 diffs[match.group('filename')] = current_diff = [x]
908 elif x.startswith('diff --git'):
909 raise PresubmitFailure('Unexpected diff line: %s' % x)
910 else:
911 current_diff.append(x)
912
913 self._diffs_by_file = dict(
914 (normpath(path), ''.join(diff)) for path, diff in diffs.items())
915
916 if path not in self._diffs_by_file:
917 raise PresubmitFailure(
918 'Unified diff did not contain entry for file %s' % path)
919
920 return self._diffs_by_file[path]
921
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700922 def GetOldContents(self, path, local_root):
923 return scm.GIT.GetOldContents(local_root, path, branch=self._upstream)
924
nick@chromium.orgff526192013-06-10 19:30:26 +0000925
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000926class AffectedFile(object):
927 """Representation of a file in a change."""
nick@chromium.orgff526192013-06-10 19:30:26 +0000928
929 DIFF_CACHE = _DiffCache
930
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000931 # Method could be a function
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800932 # pylint: disable=no-self-use
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000933 def __init__(self, path, action, repository_root, diff_cache):
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000934 self._path = path
935 self._action = action
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000936 self._local_root = repository_root
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000937 self._is_directory = None
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000938 self._cached_changed_contents = None
939 self._cached_new_contents = None
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000940 self._diff_cache = diff_cache
tobiasjs2836bcf2016-08-16 04:08:16 -0700941 logging.debug('%s(%s)', self.__class__.__name__, self._path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000942
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000943 def LocalPath(self):
944 """Returns the path of this file on the local disk relative to client root.
Andrew Grieve92b8b992017-11-02 09:42:24 -0400945
946 This should be used for error messages but not for accessing files,
947 because presubmit checks are run with CWD=PresubmitLocalPath() (which is
948 often != client root).
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000949 """
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000950 return normpath(self._path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000951
952 def AbsoluteLocalPath(self):
953 """Returns the absolute path of this file on the local disk.
954 """
chase@chromium.org8e416c82009-10-06 04:30:44 +0000955 return os.path.abspath(os.path.join(self._local_root, self.LocalPath()))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000956
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000957 def Action(self):
958 """Returns the action on this opened file, e.g. A, M, D, etc."""
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000959 return self._action
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000960
agable0b65e732016-11-22 09:25:46 -0800961 def IsTestableFile(self):
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000962 """Returns True if the file is a text file and not a binary file.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000963
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000964 Deleted files are not text file."""
maruel@chromium.org1e08c002009-05-28 19:09:33 +0000965 raise NotImplementedError() # Implement when needed
966
agable0b65e732016-11-22 09:25:46 -0800967 def IsTextFile(self):
968 """An alias to IsTestableFile for backwards compatibility."""
969 return self.IsTestableFile()
970
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700971 def OldContents(self):
972 """Returns an iterator over the lines in the old version of file.
973
Daniel Cheng2da34fe2017-03-21 20:42:12 -0700974 The old version is the file before any modifications in the user's
Edward Lemura5799e32020-01-17 19:26:51 +0000975 workspace, i.e. the 'left hand side'.
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700976
977 Contents will be empty if the file is a directory or does not exist.
978 Note: The carriage returns (LF or CR) are stripped off.
979 """
980 return self._diff_cache.GetOldContents(self.LocalPath(),
981 self._local_root).splitlines()
982
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000983 def NewContents(self):
984 """Returns an iterator over the lines in the new version of file.
985
Edward Lemura5799e32020-01-17 19:26:51 +0000986 The new version is the file in the user's workspace, i.e. the 'right hand
987 side'.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000988
989 Contents will be empty if the file is a directory or does not exist.
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000990 Note: The carriage returns (LF or CR) are stripped off.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000991 """
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000992 if self._cached_new_contents is None:
993 self._cached_new_contents = []
agable0b65e732016-11-22 09:25:46 -0800994 try:
995 self._cached_new_contents = gclient_utils.FileRead(
996 self.AbsoluteLocalPath(), 'rU').splitlines()
997 except IOError:
998 pass # File not found? That's fine; maybe it was deleted.
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000999 return self._cached_new_contents[:]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001000
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001001 def ChangedContents(self):
1002 """Returns a list of tuples (line number, line text) of all new lines.
1003
1004 This relies on the scm diff output describing each changed code section
1005 with a line of the form
1006
1007 ^@@ <old line num>,<old size> <new line num>,<new size> @@$
1008 """
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +00001009 if self._cached_changed_contents is not None:
1010 return self._cached_changed_contents[:]
1011 self._cached_changed_contents = []
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001012 line_num = 0
1013
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001014 for line in self.GenerateScmDiff().splitlines():
Edward Lemurac5c55f2020-02-29 00:17:16 +00001015 m = re.match(r'^@@ [0-9\,\+\-]+ \+([0-9]+)\,[0-9]+ @@', line)
1016 if m:
1017 line_num = int(m.groups(1)[0])
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001018 continue
1019 if line.startswith('+') and not line.startswith('++'):
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +00001020 self._cached_changed_contents.append((line_num, line[1:]))
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001021 if not line.startswith('-'):
1022 line_num += 1
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +00001023 return self._cached_changed_contents[:]
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001024
maruel@chromium.org5de13972009-06-10 18:16:06 +00001025 def __str__(self):
1026 return self.LocalPath()
1027
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001028 def GenerateScmDiff(self):
nick@chromium.orgff526192013-06-10 19:30:26 +00001029 return self._diff_cache.GetDiff(self.LocalPath(), self._local_root)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001030
maruel@chromium.org58407af2011-04-12 23:15:57 +00001031
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001032class GitAffectedFile(AffectedFile):
1033 """Representation of a file in a change out of a git checkout."""
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +00001034 # Method 'NNN' is abstract in class 'NNN' but is not overridden
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -08001035 # pylint: disable=abstract-method
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001036
nick@chromium.orgff526192013-06-10 19:30:26 +00001037 DIFF_CACHE = _GitDiffCache
1038
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001039 def __init__(self, *args, **kwargs):
1040 AffectedFile.__init__(self, *args, **kwargs)
1041 self._server_path = None
agable0b65e732016-11-22 09:25:46 -08001042 self._is_testable_file = None
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001043
agable0b65e732016-11-22 09:25:46 -08001044 def IsTestableFile(self):
1045 if self._is_testable_file is None:
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001046 if self.Action() == 'D':
agable0b65e732016-11-22 09:25:46 -08001047 # A deleted file is not testable.
1048 self._is_testable_file = False
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001049 else:
agable0b65e732016-11-22 09:25:46 -08001050 self._is_testable_file = os.path.isfile(self.AbsoluteLocalPath())
1051 return self._is_testable_file
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001052
maruel@chromium.orgc1938752011-04-12 23:11:13 +00001053
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001054class Change(object):
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001055 """Describe a change.
1056
1057 Used directly by the presubmit scripts to query the current change being
1058 tested.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +00001059
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001060 Instance members:
nick@chromium.orgff526192013-06-10 19:30:26 +00001061 tags: Dictionary of KEY=VALUE pairs found in the change description.
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001062 self.KEY: equivalent to tags['KEY']
1063 """
1064
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001065 _AFFECTED_FILES = AffectedFile
1066
Edward Lemura5799e32020-01-17 19:26:51 +00001067 # Matches key/value (or 'tag') lines in changelist descriptions.
maruel@chromium.org428342a2011-11-10 15:46:33 +00001068 TAG_LINE_RE = re.compile(
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001069 '^[ \t]*(?P<key>[A-Z][A-Z_0-9]*)[ \t]*=[ \t]*(?P<value>.*?)[ \t]*$')
maruel@chromium.orgc1938752011-04-12 23:11:13 +00001070 scm = ''
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001071
maruel@chromium.org58407af2011-04-12 23:15:57 +00001072 def __init__(
agable@chromium.orgea84ef12014-04-30 19:55:12 +00001073 self, name, description, local_root, files, issue, patchset, author,
1074 upstream=None):
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001075 if files is None:
1076 files = []
1077 self._name = name
chase@chromium.org8e416c82009-10-06 04:30:44 +00001078 # Convert root into an absolute path.
1079 self._local_root = os.path.abspath(local_root)
agable@chromium.orgea84ef12014-04-30 19:55:12 +00001080 self._upstream = upstream
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001081 self.issue = issue
1082 self.patchset = patchset
maruel@chromium.org58407af2011-04-12 23:15:57 +00001083 self.author_email = author
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001084
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001085 self._full_description = ''
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001086 self.tags = {}
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001087 self._description_without_tags = ''
1088 self.SetDescriptionText(description)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001089
maruel@chromium.orge085d812011-10-10 19:49:15 +00001090 assert all(
1091 (isinstance(f, (list, tuple)) and len(f) == 2) for f in files), files
1092
agable@chromium.orgea84ef12014-04-30 19:55:12 +00001093 diff_cache = self._AFFECTED_FILES.DIFF_CACHE(self._upstream)
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001094 self._affected_files = [
nick@chromium.orgff526192013-06-10 19:30:26 +00001095 self._AFFECTED_FILES(path, action.strip(), self._local_root, diff_cache)
1096 for action, path in files
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +00001097 ]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001098
Edward Lesmes9ce03f82021-01-12 20:13:31 +00001099 def UpstreamBranch(self):
1100 """Returns the upstream branch for the change."""
1101 return self._upstream
1102
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001103 def Name(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001104 """Returns the change name."""
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001105 return self._name
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001106
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001107 def DescriptionText(self):
1108 """Returns the user-entered changelist description, minus tags.
1109
Edward Lemura5799e32020-01-17 19:26:51 +00001110 Any line in the user-provided description starting with e.g. 'FOO='
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001111 (whitespace permitted before and around) is considered a tag line. Such
1112 lines are stripped out of the description this function returns.
1113 """
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001114 return self._description_without_tags
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001115
1116 def FullDescriptionText(self):
1117 """Returns the complete changelist description including tags."""
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001118 return self._full_description
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001119
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001120 def SetDescriptionText(self, description):
1121 """Sets the full description text (including tags) to |description|.
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001122
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001123 Also updates the list of tags."""
1124 self._full_description = description
1125
1126 # From the description text, build up a dictionary of key/value pairs
Edward Lemura5799e32020-01-17 19:26:51 +00001127 # plus the description minus all key/value or 'tag' lines.
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001128 description_without_tags = []
1129 self.tags = {}
1130 for line in self._full_description.splitlines():
1131 m = self.TAG_LINE_RE.match(line)
1132 if m:
1133 self.tags[m.group('key')] = m.group('value')
1134 else:
1135 description_without_tags.append(line)
1136
1137 # Change back to text and remove whitespace at end.
1138 self._description_without_tags = (
1139 '\n'.join(description_without_tags).rstrip())
1140
Edward Lemur69bb8be2020-02-03 20:37:38 +00001141 def AddDescriptionFooter(self, key, value):
1142 """Adds the given footer to the change description.
1143
1144 Args:
1145 key: A string with the key for the git footer. It must conform to
1146 the git footers format (i.e. 'List-Of-Tokens') and will be case
1147 normalized so that each token is title-cased.
1148 value: A string with the value for the git footer.
1149 """
1150 description = git_footers.add_footer(
1151 self.FullDescriptionText(), git_footers.normalize_name(key), value)
1152 self.SetDescriptionText(description)
1153
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001154 def RepositoryRoot(self):
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001155 """Returns the repository (checkout) root directory for this change,
1156 as an absolute path.
1157 """
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001158 return self._local_root
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001159
1160 def __getattr__(self, attr):
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001161 """Return tags directly as attributes on the object."""
Edward Lemura5799e32020-01-17 19:26:51 +00001162 if not re.match(r'^[A-Z_]*$', attr):
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001163 raise AttributeError(self, attr)
maruel@chromium.orge1a524f2009-05-27 14:43:46 +00001164 return self.tags.get(attr)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001165
Edward Lemur69bb8be2020-02-03 20:37:38 +00001166 def GitFootersFromDescription(self):
1167 """Return the git footers present in the description.
1168
1169 Returns:
1170 footers: A dict of {footer: [values]} containing a multimap of the footers
1171 in the change description.
1172 """
1173 return git_footers.parse_footers(self.FullDescriptionText())
1174
Aaron Gablefc03e672017-05-15 14:09:42 -07001175 def BugsFromDescription(self):
1176 """Returns all bugs referenced in the commit description."""
Aaron Gable12ef5012017-05-15 14:29:00 -07001177 tags = [b.strip() for b in self.tags.get('BUG', '').split(',') if b.strip()]
Caleb Rouleauc0546b92019-02-22 06:12:57 +00001178 footers = []
Edward Lemur69bb8be2020-02-03 20:37:38 +00001179 parsed = self.GitFootersFromDescription()
Dan Beam62954042019-10-03 21:20:33 +00001180 unsplit_footers = parsed.get('Bug', []) + parsed.get('Fixed', [])
Caleb Rouleauc0546b92019-02-22 06:12:57 +00001181 for unsplit_footer in unsplit_footers:
1182 footers += [b.strip() for b in unsplit_footer.split(',')]
Aaron Gable12ef5012017-05-15 14:29:00 -07001183 return sorted(set(tags + footers))
Aaron Gablefc03e672017-05-15 14:09:42 -07001184
1185 def ReviewersFromDescription(self):
1186 """Returns all reviewers listed in the commit description."""
Edward Lemura5799e32020-01-17 19:26:51 +00001187 # We don't support a 'R:' git-footer for reviewers; that is in metadata.
Aaron Gable12ef5012017-05-15 14:29:00 -07001188 tags = [r.strip() for r in self.tags.get('R', '').split(',') if r.strip()]
1189 return sorted(set(tags))
Aaron Gablefc03e672017-05-15 14:09:42 -07001190
1191 def TBRsFromDescription(self):
1192 """Returns all TBR reviewers listed in the commit description."""
Aaron Gable12ef5012017-05-15 14:29:00 -07001193 tags = [r.strip() for r in self.tags.get('TBR', '').split(',') if r.strip()]
Aaron Gable6e7ddb62020-05-27 22:23:29 +00001194 # TODO(crbug.com/839208): Remove support for 'Tbr:' when TBRs are
1195 # programmatically determined by self-CR+1s.
Edward Lemur69bb8be2020-02-03 20:37:38 +00001196 footers = self.GitFootersFromDescription().get('Tbr', [])
Aaron Gable12ef5012017-05-15 14:29:00 -07001197 return sorted(set(tags + footers))
Aaron Gablefc03e672017-05-15 14:09:42 -07001198
Aaron Gable6e7ddb62020-05-27 22:23:29 +00001199 # TODO(crbug.com/753425): Delete these once we're sure they're unused.
Aaron Gablefc03e672017-05-15 14:09:42 -07001200 @property
1201 def BUG(self):
1202 return ','.join(self.BugsFromDescription())
1203 @property
1204 def R(self):
1205 return ','.join(self.ReviewersFromDescription())
1206 @property
1207 def TBR(self):
1208 return ','.join(self.TBRsFromDescription())
1209
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001210 def AllFiles(self, root=None):
1211 """List all files under source control in the repo."""
1212 raise NotImplementedError()
1213
agable0b65e732016-11-22 09:25:46 -08001214 def AffectedFiles(self, include_deletes=True, file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001215 """Returns a list of AffectedFile instances for all files in the change.
1216
1217 Args:
1218 include_deletes: If false, deleted files will be filtered out.
sail@chromium.org5538e022011-05-12 17:53:16 +00001219 file_filter: An additional filter to apply.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001220
1221 Returns:
1222 [AffectedFile(path, action), AffectedFile(path, action)]
1223 """
Edward Lemurb9830242019-10-30 22:19:20 +00001224 affected = list(filter(file_filter, self._affected_files))
sail@chromium.org5538e022011-05-12 17:53:16 +00001225
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001226 if include_deletes:
1227 return affected
Edward Lemurb9830242019-10-30 22:19:20 +00001228 return list(filter(lambda x: x.Action() != 'D', affected))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001229
John Budorick16162372018-04-18 10:39:53 -07001230 def AffectedTestableFiles(self, include_deletes=None, **kwargs):
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +00001231 """Return a list of the existing text files in a change."""
1232 if include_deletes is not None:
Edward Lemura5799e32020-01-17 19:26:51 +00001233 warn('AffectedTeestableFiles(include_deletes=%s)'
1234 ' is deprecated and ignored' % str(include_deletes),
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +00001235 category=DeprecationWarning,
1236 stacklevel=2)
Edward Lemurb9830242019-10-30 22:19:20 +00001237 return list(filter(
1238 lambda x: x.IsTestableFile(),
1239 self.AffectedFiles(include_deletes=False, **kwargs)))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001240
agable0b65e732016-11-22 09:25:46 -08001241 def AffectedTextFiles(self, include_deletes=None):
1242 """An alias to AffectedTestableFiles for backwards compatibility."""
1243 return self.AffectedTestableFiles(include_deletes=include_deletes)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001244
agable0b65e732016-11-22 09:25:46 -08001245 def LocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001246 """Convenience function."""
agable0b65e732016-11-22 09:25:46 -08001247 return [af.LocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001248
agable0b65e732016-11-22 09:25:46 -08001249 def AbsoluteLocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001250 """Convenience function."""
agable0b65e732016-11-22 09:25:46 -08001251 return [af.AbsoluteLocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001252
1253 def RightHandSideLines(self):
Edward Lemura5799e32020-01-17 19:26:51 +00001254 """An iterator over all text lines in 'new' version of changed files.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001255
1256 Lists lines from new or modified text files in the change.
1257
1258 This is useful for doing line-by-line regex checks, like checking for
1259 trailing whitespace.
1260
1261 Yields:
1262 a 3 tuple:
1263 the AffectedFile instance of the current file;
1264 integer line number (1-based); and
1265 the contents of the line as a string.
1266 """
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +00001267 return _RightHandSideLinesImpl(
1268 x for x in self.AffectedFiles(include_deletes=False)
agable0b65e732016-11-22 09:25:46 -08001269 if x.IsTestableFile())
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001270
Jochen Eisingerd0573ec2017-04-13 10:55:06 +02001271 def OriginalOwnersFiles(self):
1272 """A map from path names of affected OWNERS files to their old content."""
1273 def owners_file_filter(f):
1274 return 'OWNERS' in os.path.split(f.LocalPath())[1]
1275 files = self.AffectedFiles(file_filter=owners_file_filter)
1276 return dict([(f.LocalPath(), f.OldContents()) for f in files])
1277
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001278
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001279class GitChange(Change):
1280 _AFFECTED_FILES = GitAffectedFile
maruel@chromium.orgc1938752011-04-12 23:11:13 +00001281 scm = 'git'
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +00001282
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001283 def AllFiles(self, root=None):
1284 """List all files under source control in the repo."""
1285 root = root or self.RepositoryRoot()
1286 return subprocess.check_output(
Aaron Gable7817f022017-12-12 09:43:17 -08001287 ['git', '-c', 'core.quotePath=false', 'ls-files', '--', '.'],
1288 cwd=root).splitlines()
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001289
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001290
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001291def ListRelevantPresubmitFiles(files, root):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001292 """Finds all presubmit files that apply to a given set of source files.
1293
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001294 If inherit-review-settings-ok is present right under root, looks for
1295 PRESUBMIT.py in directories enclosing root.
1296
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001297 Args:
1298 files: An iterable container containing file paths.
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001299 root: Path where to stop searching.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001300
1301 Return:
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001302 List of absolute paths of the existing PRESUBMIT.py scripts.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001303 """
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001304 files = [normpath(os.path.join(root, f)) for f in files]
1305
1306 # List all the individual directories containing files.
1307 directories = set([os.path.dirname(f) for f in files])
1308
1309 # Ignore root if inherit-review-settings-ok is present.
1310 if os.path.isfile(os.path.join(root, 'inherit-review-settings-ok')):
1311 root = None
1312
1313 # Collect all unique directories that may contain PRESUBMIT.py.
1314 candidates = set()
1315 for directory in directories:
1316 while True:
1317 if directory in candidates:
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001318 break
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001319 candidates.add(directory)
1320 if directory == root:
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001321 break
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001322 parent_dir = os.path.dirname(directory)
1323 if parent_dir == directory:
1324 # We hit the system root directory.
1325 break
1326 directory = parent_dir
1327
1328 # Look for PRESUBMIT.py in all candidate directories.
1329 results = []
1330 for directory in sorted(list(candidates)):
tobiasjsff061c02016-08-17 03:23:57 -07001331 try:
1332 for f in os.listdir(directory):
1333 p = os.path.join(directory, f)
1334 if os.path.isfile(p) and re.match(
1335 r'PRESUBMIT.*\.py$', f) and not f.startswith('PRESUBMIT_test'):
1336 results.append(p)
1337 except OSError:
1338 pass
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001339
tobiasjs2836bcf2016-08-16 04:08:16 -07001340 logging.debug('Presubmit files: %s', ','.join(results))
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001341 return results
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001342
1343
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001344class GetTryMastersExecuter(object):
1345 @staticmethod
1346 def ExecPresubmitScript(script_text, presubmit_path, project, change):
1347 """Executes GetPreferredTryMasters() from a single presubmit script.
1348
1349 Args:
1350 script_text: The text of the presubmit script.
1351 presubmit_path: Project script to run.
1352 project: Project name to pass to presubmit script for bot selection.
1353
1354 Return:
1355 A map of try masters to map of builders to set of tests.
1356 """
1357 context = {}
1358 try:
Raul Tambre09e64b42019-05-14 01:57:22 +00001359 exec(compile(script_text, 'PRESUBMIT.py', 'exec', dont_inherit=True),
1360 context)
Raul Tambre7c938462019-05-24 16:35:35 +00001361 except Exception as e:
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001362 raise PresubmitFailure('"%s" had an exception.\n%s'
1363 % (presubmit_path, e))
1364
1365 function_name = 'GetPreferredTryMasters'
1366 if function_name not in context:
1367 return {}
1368 get_preferred_try_masters = context[function_name]
1369 if not len(inspect.getargspec(get_preferred_try_masters)[0]) == 2:
1370 raise PresubmitFailure(
1371 'Expected function "GetPreferredTryMasters" to take two arguments.')
1372 return get_preferred_try_masters(project, change)
1373
1374
rmistry@google.com5626a922015-02-26 14:03:30 +00001375class GetPostUploadExecuter(object):
1376 @staticmethod
Edward Lemur016a0872020-02-04 22:13:28 +00001377 def ExecPresubmitScript(script_text, presubmit_path, gerrit_obj, change):
rmistry@google.com5626a922015-02-26 14:03:30 +00001378 """Executes PostUploadHook() from a single presubmit script.
1379
1380 Args:
1381 script_text: The text of the presubmit script.
1382 presubmit_path: Project script to run.
Edward Lemur016a0872020-02-04 22:13:28 +00001383 gerrit_obj: The GerritAccessor object.
rmistry@google.com5626a922015-02-26 14:03:30 +00001384 change: The Change object.
1385
1386 Return:
1387 A list of results objects.
1388 """
1389 context = {}
1390 try:
Raul Tambre09e64b42019-05-14 01:57:22 +00001391 exec(compile(script_text, 'PRESUBMIT.py', 'exec', dont_inherit=True),
1392 context)
Raul Tambre7c938462019-05-24 16:35:35 +00001393 except Exception as e:
rmistry@google.com5626a922015-02-26 14:03:30 +00001394 raise PresubmitFailure('"%s" had an exception.\n%s'
1395 % (presubmit_path, e))
1396
1397 function_name = 'PostUploadHook'
1398 if function_name not in context:
1399 return {}
1400 post_upload_hook = context[function_name]
1401 if not len(inspect.getargspec(post_upload_hook)[0]) == 3:
1402 raise PresubmitFailure(
1403 'Expected function "PostUploadHook" to take three arguments.')
Edward Lemur016a0872020-02-04 22:13:28 +00001404 return post_upload_hook(gerrit_obj, change, OutputApi(False))
rmistry@google.com5626a922015-02-26 14:03:30 +00001405
1406
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001407def _MergeMasters(masters1, masters2):
1408 """Merges two master maps. Merges also the tests of each builder."""
1409 result = {}
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001410 for (master, builders) in itertools.chain(masters1.items(),
1411 masters2.items()):
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001412 new_builders = result.setdefault(master, {})
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001413 for (builder, tests) in builders.items():
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001414 new_builders.setdefault(builder, set([])).update(tests)
1415 return result
1416
1417
1418def DoGetTryMasters(change,
1419 changed_files,
1420 repository_root,
1421 default_presubmit,
1422 project,
1423 verbose,
1424 output_stream):
1425 """Get the list of try masters from the presubmit scripts.
1426
1427 Args:
1428 changed_files: List of modified files.
1429 repository_root: The repository root.
1430 default_presubmit: A default presubmit script to execute in any case.
1431 project: Optional name of a project used in selecting trybots.
1432 verbose: Prints debug info.
1433 output_stream: A stream to write debug output to.
1434
1435 Return:
1436 Map of try masters to map of builders to set of tests.
1437 """
1438 presubmit_files = ListRelevantPresubmitFiles(changed_files, repository_root)
1439 if not presubmit_files and verbose:
Edward Lemura5799e32020-01-17 19:26:51 +00001440 output_stream.write('Warning, no PRESUBMIT.py found.\n')
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001441 results = {}
1442 executer = GetTryMastersExecuter()
1443
1444 if default_presubmit:
1445 if verbose:
Edward Lemura5799e32020-01-17 19:26:51 +00001446 output_stream.write('Running default presubmit script.\n')
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001447 fake_path = os.path.join(repository_root, 'PRESUBMIT.py')
1448 results = _MergeMasters(results, executer.ExecPresubmitScript(
1449 default_presubmit, fake_path, project, change))
1450 for filename in presubmit_files:
1451 filename = os.path.abspath(filename)
1452 if verbose:
Edward Lemura5799e32020-01-17 19:26:51 +00001453 output_stream.write('Running %s\n' % filename)
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001454 # Accept CRLF presubmit script.
1455 presubmit_script = gclient_utils.FileRead(filename, 'rU')
1456 results = _MergeMasters(results, executer.ExecPresubmitScript(
1457 presubmit_script, filename, project, change))
1458
1459 # Make sets to lists again for later JSON serialization.
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001460 for builders in results.values():
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001461 for builder in builders:
1462 builders[builder] = list(builders[builder])
1463
1464 if results and verbose:
1465 output_stream.write('%s\n' % str(results))
1466 return results
1467
1468
rmistry@google.com5626a922015-02-26 14:03:30 +00001469def DoPostUploadExecuter(change,
Edward Lemur016a0872020-02-04 22:13:28 +00001470 gerrit_obj,
Edward Lemur6eb1d322020-02-27 22:20:15 +00001471 verbose):
rmistry@google.com5626a922015-02-26 14:03:30 +00001472 """Execute the post upload hook.
1473
1474 Args:
1475 change: The Change object.
Edward Lemur016a0872020-02-04 22:13:28 +00001476 gerrit_obj: The GerritAccessor object.
rmistry@google.com5626a922015-02-26 14:03:30 +00001477 verbose: Prints debug info.
rmistry@google.com5626a922015-02-26 14:03:30 +00001478 """
1479 presubmit_files = ListRelevantPresubmitFiles(
Edward Lemur6eb1d322020-02-27 22:20:15 +00001480 change.LocalPaths(), change.RepositoryRoot())
rmistry@google.com5626a922015-02-26 14:03:30 +00001481 if not presubmit_files and verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001482 sys.stdout.write('Warning, no PRESUBMIT.py found.\n')
rmistry@google.com5626a922015-02-26 14:03:30 +00001483 results = []
1484 executer = GetPostUploadExecuter()
1485 # The root presubmit file should be executed after the ones in subdirectories.
1486 # i.e. the specific post upload hooks should run before the general ones.
1487 # Thus, reverse the order provided by ListRelevantPresubmitFiles.
1488 presubmit_files.reverse()
1489
1490 for filename in presubmit_files:
1491 filename = os.path.abspath(filename)
1492 if verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001493 sys.stdout.write('Running %s\n' % filename)
rmistry@google.com5626a922015-02-26 14:03:30 +00001494 # Accept CRLF presubmit script.
1495 presubmit_script = gclient_utils.FileRead(filename, 'rU')
1496 results.extend(executer.ExecPresubmitScript(
Edward Lemur016a0872020-02-04 22:13:28 +00001497 presubmit_script, filename, gerrit_obj, change))
rmistry@google.com5626a922015-02-26 14:03:30 +00001498
Edward Lemur6eb1d322020-02-27 22:20:15 +00001499 if not results:
1500 return 0
1501
1502 sys.stdout.write('\n')
1503 sys.stdout.write('** Post Upload Hook Messages **\n')
1504
1505 exit_code = 0
1506 for result in results:
1507 if result.fatal:
1508 exit_code = 1
1509 result.handle()
1510 sys.stdout.write('\n')
1511
1512 return exit_code
rmistry@google.com5626a922015-02-26 14:03:30 +00001513
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001514class PresubmitExecuter(object):
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001515 def __init__(self, change, committing, verbose, gerrit_obj, dry_run=None,
Edward Lesmeseb1bd622021-03-01 19:54:07 +00001516 thread_pool=None, parallel=False):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001517 """
1518 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001519 change: The Change object.
agable92bec4f2016-08-24 09:27:27 -07001520 committing: True if 'git cl land' is running, False if 'git cl upload' is.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001521 gerrit_obj: provides basic Gerrit codereview functionality.
1522 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -04001523 parallel: if true, all tests reported via input_api.RunTests for all
1524 PRESUBMIT files will be run in parallel.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001525 """
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001526 self.change = change
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001527 self.committing = committing
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001528 self.gerrit = gerrit_obj
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001529 self.verbose = verbose
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001530 self.dry_run = dry_run
Daniel Cheng7227d212017-11-17 08:12:37 -08001531 self.more_cc = []
Edward Lesmes8e282792018-04-03 18:50:29 -04001532 self.thread_pool = thread_pool
1533 self.parallel = parallel
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001534
1535 def ExecPresubmitScript(self, script_text, presubmit_path):
1536 """Executes a single presubmit script.
1537
1538 Args:
1539 script_text: The text of the presubmit script.
1540 presubmit_path: The path to the presubmit file (this will be reported via
1541 input_api.PresubmitLocalPath()).
1542
1543 Return:
1544 A list of result objects, empty if no problems.
1545 """
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001546
chase@chromium.org8e416c82009-10-06 04:30:44 +00001547 # Change to the presubmit file's directory to support local imports.
1548 main_path = os.getcwd()
Saagar Sanghavi98b332f2020-07-31 17:19:15 +00001549 presubmit_dir = os.path.dirname(presubmit_path)
1550 os.chdir(presubmit_dir)
chase@chromium.org8e416c82009-10-06 04:30:44 +00001551
1552 # Load the presubmit script into context.
dpranke@chromium.org970c5222011-03-12 00:32:24 +00001553 input_api = InputApi(self.change, presubmit_path, self.committing,
Aaron Gable668c1d82018-04-03 10:19:16 -07001554 self.verbose, gerrit_obj=self.gerrit,
Edward Lesmes8e282792018-04-03 18:50:29 -04001555 dry_run=self.dry_run, thread_pool=self.thread_pool,
1556 parallel=self.parallel)
Daniel Cheng7227d212017-11-17 08:12:37 -08001557 output_api = OutputApi(self.committing)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001558 context = {}
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001559
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001560 try:
Raul Tambre09e64b42019-05-14 01:57:22 +00001561 exec(compile(script_text, 'PRESUBMIT.py', 'exec', dont_inherit=True),
1562 context)
Raul Tambre7c938462019-05-24 16:35:35 +00001563 except Exception as e:
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001564 raise PresubmitFailure('"%s" had an exception.\n%s' % (presubmit_path, e))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001565
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001566 context['__args'] = (input_api, output_api)
Ben Pastene8351dc12020-08-06 05:01:35 +00001567
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001568 # Get path of presubmit directory relative to repository root.
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001569 # Always use forward slashes, so that path is same in *nix and Windows
1570 root = input_api.change.RepositoryRoot()
1571 rel_path = os.path.relpath(presubmit_dir, root)
1572 rel_path = rel_path.replace(os.path.sep, '/')
Ben Pastene8351dc12020-08-06 05:01:35 +00001573
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001574 # Get the URL of git remote origin and use it to identify host and project
Edward Lesmeseb1bd622021-03-01 19:54:07 +00001575 host = project = ''
1576 if self.gerrit:
1577 host = self.gerrit.host or ''
1578 project = self.gerrit.project or ''
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001579
1580 # Prefix for test names
1581 prefix = 'presubmit:%s/%s:%s/' % (host, project, rel_path)
1582
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001583 # Perform all the desired presubmit checks.
1584 results = []
Ben Pastene8351dc12020-08-06 05:01:35 +00001585
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001586 try:
Scott Leecc2fe9b2020-11-19 19:38:06 +00001587 version = [
1588 int(x) for x in context.get('PRESUBMIT_VERSION', '0.0.0').split('.')
1589 ]
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001590
Scott Leecc2fe9b2020-11-19 19:38:06 +00001591 with rdb_wrapper.client(prefix) as sink:
1592 if version >= [2, 0, 0]:
1593 for function_name in context:
1594 if not function_name.startswith('Check'):
1595 continue
1596 if function_name.endswith('Commit') and not self.committing:
1597 continue
1598 if function_name.endswith('Upload') and self.committing:
1599 continue
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001600 logging.debug('Running %s in %s', function_name, presubmit_path)
1601 results.extend(
Scott Leecc2fe9b2020-11-19 19:38:06 +00001602 self._run_check_function(function_name, context, sink))
1603 logging.debug('Running %s done.', function_name)
1604 self.more_cc.extend(output_api.more_cc)
1605
1606 else: # Old format
1607 if self.committing:
1608 function_name = 'CheckChangeOnCommit'
1609 else:
1610 function_name = 'CheckChangeOnUpload'
1611 if function_name in context:
1612 logging.debug('Running %s in %s', function_name, presubmit_path)
1613 results.extend(
1614 self._run_check_function(function_name, context, sink))
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001615 logging.debug('Running %s done.', function_name)
1616 self.more_cc.extend(output_api.more_cc)
1617
1618 finally:
1619 for f in input_api._named_temporary_files:
1620 os.remove(f)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001621
chase@chromium.org8e416c82009-10-06 04:30:44 +00001622 # Return the process to the original working directory.
1623 os.chdir(main_path)
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001624 return results
1625
Scott Leecc2fe9b2020-11-19 19:38:06 +00001626 def _run_check_function(self, function_name, context, sink=None):
1627 """Evaluates and returns the result of a given presubmit function.
1628
1629 If sink is given, the result of the presubmit function will be reported
1630 to the ResultSink.
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001631
1632 Args:
Scott Leecc2fe9b2020-11-19 19:38:06 +00001633 function_name: the name of the presubmit function to evaluate
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001634 context: a context dictionary in which the function will be evaluated
Scott Leecc2fe9b2020-11-19 19:38:06 +00001635 sink: an instance of ResultSink. None, by default.
1636 Returns:
1637 the result of the presubmit function call.
1638 """
1639 start_time = time_time()
1640 try:
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001641 result = eval(function_name + '(*__args)', context)
1642 self._check_result_type(result)
Scott Leecc2fe9b2020-11-19 19:38:06 +00001643 except:
1644 if sink:
1645 elapsed_time = time_time() - start_time
1646 sink.report(function_name, rdb_wrapper.STATUS_FAIL, elapsed_time)
1647 raise
1648
1649 if sink:
1650 elapsed_time = time_time() - start_time
1651 status = rdb_wrapper.STATUS_PASS
1652 if any(r.fatal for r in result):
1653 status = rdb_wrapper.STATUS_FAIL
1654 sink.report(function_name, status, elapsed_time)
1655
1656 return result
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001657
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00001658 def _check_result_type(self, result):
1659 """Helper function which ensures result is a list, and all elements are
1660 instances of OutputApi.PresubmitResult"""
1661 if not isinstance(result, (tuple, list)):
1662 raise PresubmitFailure('Presubmit functions must return a tuple or list')
1663 if not all(isinstance(res, OutputApi.PresubmitResult) for res in result):
1664 raise PresubmitFailure(
1665 'All presubmit results must be of types derived from '
1666 'output_api.PresubmitResult')
1667
1668
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001669def DoPresubmitChecks(change,
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001670 committing,
1671 verbose,
maruel@chromium.orgb0dfd352009-06-10 14:12:54 +00001672 default_presubmit,
dpranke@chromium.org970c5222011-03-12 00:32:24 +00001673 may_prompt,
Aaron Gable668c1d82018-04-03 10:19:16 -07001674 gerrit_obj,
Edward Lesmes8e282792018-04-03 18:50:29 -04001675 dry_run=None,
Debrian Figueroadd2737e2019-06-21 23:50:13 +00001676 parallel=False,
Edward Lesmeseb1bd622021-03-01 19:54:07 +00001677 json_output=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001678 """Runs all presubmit checks that apply to the files in the change.
1679
1680 This finds all PRESUBMIT.py files in directories enclosing the files in the
1681 change (up to the repository root) and calls the relevant entrypoint function
1682 depending on whether the change is being committed or uploaded.
1683
1684 Prints errors, warnings and notifications. Prompts the user for warnings
1685 when needed.
1686
1687 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001688 change: The Change object.
agable92bec4f2016-08-24 09:27:27 -07001689 committing: True if 'git cl land' is running, False if 'git cl upload' is.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001690 verbose: Prints debug info.
maruel@chromium.org0ff1fab2009-05-22 13:08:15 +00001691 default_presubmit: A default presubmit script to execute in any case.
Quinten Yearsley516fe7f2016-12-14 11:50:18 -08001692 may_prompt: Enable (y/n) questions on warning or error. If False,
1693 any questions are answered with yes by default.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001694 gerrit_obj: provides basic Gerrit codereview functionality.
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001695 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -04001696 parallel: if true, all tests specified by input_api.RunTests in all
1697 PRESUBMIT files will be run in parallel.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001698
1699 Return:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001700 1 if presubmit checks failed or 0 otherwise.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001701 """
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001702 old_environ = os.environ
1703 try:
1704 # Make sure python subprocesses won't generate .pyc files.
1705 os.environ = os.environ.copy()
Edward Lemurb9830242019-10-30 22:19:20 +00001706 os.environ['PYTHONDONTWRITEBYTECODE'] = '1'
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001707
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001708 if committing:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001709 sys.stdout.write('Running presubmit commit checks ...\n')
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001710 else:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001711 sys.stdout.write('Running presubmit upload checks ...\n')
Edward Lemurecc27072020-01-06 16:42:34 +00001712 start_time = time_time()
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001713 presubmit_files = ListRelevantPresubmitFiles(
agable0b65e732016-11-22 09:25:46 -08001714 change.AbsoluteLocalPaths(), change.RepositoryRoot())
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001715 if not presubmit_files and verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001716 sys.stdout.write('Warning, no PRESUBMIT.py found.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001717 results = []
Edward Lesmes8e282792018-04-03 18:50:29 -04001718 thread_pool = ThreadPool()
Edward Lemur7e3c67f2018-07-20 20:52:49 +00001719 executer = PresubmitExecuter(change, committing, verbose, gerrit_obj,
Edward Lesmeseb1bd622021-03-01 19:54:07 +00001720 dry_run, thread_pool, parallel)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001721 if default_presubmit:
1722 if verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001723 sys.stdout.write('Running default presubmit script.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001724 fake_path = os.path.join(change.RepositoryRoot(), 'PRESUBMIT.py')
1725 results += executer.ExecPresubmitScript(default_presubmit, fake_path)
1726 for filename in presubmit_files:
1727 filename = os.path.abspath(filename)
1728 if verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001729 sys.stdout.write('Running %s\n' % filename)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001730 # Accept CRLF presubmit script.
1731 presubmit_script = gclient_utils.FileRead(filename, 'rU')
1732 results += executer.ExecPresubmitScript(presubmit_script, filename)
Edward Lesmes8e282792018-04-03 18:50:29 -04001733 results += thread_pool.RunAsync()
1734
Edward Lemur6eb1d322020-02-27 22:20:15 +00001735 messages = {}
1736 should_prompt = False
1737 presubmits_failed = False
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001738 for result in results:
1739 if result.fatal:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001740 presubmits_failed = True
1741 messages.setdefault('ERRORS', []).append(result)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001742 elif result.should_prompt:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001743 should_prompt = True
1744 messages.setdefault('Warnings', []).append(result)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001745 else:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001746 messages.setdefault('Messages', []).append(result)
pam@chromium.orged9a0832009-09-09 22:48:55 +00001747
Edward Lemur6eb1d322020-02-27 22:20:15 +00001748 sys.stdout.write('\n')
1749 for name, items in messages.items():
1750 sys.stdout.write('** Presubmit %s **\n' % name)
1751 for item in items:
1752 item.handle()
1753 sys.stdout.write('\n')
pam@chromium.orged9a0832009-09-09 22:48:55 +00001754
Edward Lemurecc27072020-01-06 16:42:34 +00001755 total_time = time_time() - start_time
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001756 if total_time > 1.0:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001757 sys.stdout.write(
1758 'Presubmit checks took %.1fs to calculate.\n\n' % total_time)
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +00001759
Edward Lemur6eb1d322020-02-27 22:20:15 +00001760 if not should_prompt and not presubmits_failed:
1761 sys.stdout.write('Presubmit checks passed.\n')
1762 elif should_prompt:
1763 sys.stdout.write('There were presubmit warnings. ')
Quinten Yearsley516fe7f2016-12-14 11:50:18 -08001764 if may_prompt:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001765 presubmits_failed = not prompt_should_continue(
1766 'Are you sure you wish to continue? (y/N): ')
Garrett Beatyacb807e2020-08-28 18:17:24 +00001767 else:
1768 sys.stdout.write('\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001769
Edward Lemur1dc66e12020-02-21 21:36:34 +00001770 if json_output:
1771 # Write the presubmit results to json output
1772 presubmit_results = {
1773 'errors': [
Edward Lemur6eb1d322020-02-27 22:20:15 +00001774 error.json_format()
1775 for error in messages.get('ERRORS', [])
Edward Lemur1dc66e12020-02-21 21:36:34 +00001776 ],
1777 'notifications': [
Edward Lemur6eb1d322020-02-27 22:20:15 +00001778 notification.json_format()
1779 for notification in messages.get('Messages', [])
Edward Lemur1dc66e12020-02-21 21:36:34 +00001780 ],
1781 'warnings': [
Edward Lemur6eb1d322020-02-27 22:20:15 +00001782 warning.json_format()
1783 for warning in messages.get('Warnings', [])
Edward Lemur1dc66e12020-02-21 21:36:34 +00001784 ],
Edward Lemur6eb1d322020-02-27 22:20:15 +00001785 'more_cc': executer.more_cc,
Edward Lemur1dc66e12020-02-21 21:36:34 +00001786 }
1787
1788 gclient_utils.FileWrite(
1789 json_output, json.dumps(presubmit_results, sort_keys=True))
1790
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001791 global _ASKED_FOR_FEEDBACK
1792 # Ask for feedback one time out of 5.
1793 if (len(results) and random.randint(0, 4) == 0 and not _ASKED_FOR_FEEDBACK):
Edward Lemur6eb1d322020-02-27 22:20:15 +00001794 sys.stdout.write(
maruel@chromium.org1ce8e662014-01-14 15:23:00 +00001795 'Was the presubmit check useful? If not, run "git cl presubmit -v"\n'
1796 'to figure out which PRESUBMIT.py was run, then run git blame\n'
1797 'on the file to figure out who to ask for help.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001798 _ASKED_FOR_FEEDBACK = True
Edward Lemur6eb1d322020-02-27 22:20:15 +00001799
1800 return 1 if presubmits_failed else 0
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001801 finally:
1802 os.environ = old_environ
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001803
1804
Edward Lemur50984a62020-02-06 18:10:18 +00001805def _scan_sub_dirs(mask, recursive):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001806 if not recursive:
pgervais@chromium.orge57b09d2014-05-07 00:58:13 +00001807 return [x for x in glob.glob(mask) if x not in ('.svn', '.git')]
Lei Zhang9611c4c2017-04-04 01:41:56 -07001808
1809 results = []
1810 for root, dirs, files in os.walk('.'):
1811 if '.svn' in dirs:
1812 dirs.remove('.svn')
1813 if '.git' in dirs:
1814 dirs.remove('.git')
1815 for name in files:
1816 if fnmatch.fnmatch(name, mask):
1817 results.append(os.path.join(root, name))
1818 return results
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001819
1820
Edward Lemur50984a62020-02-06 18:10:18 +00001821def _parse_files(args, recursive):
tobiasjs2836bcf2016-08-16 04:08:16 -07001822 logging.debug('Searching for %s', args)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001823 files = []
1824 for arg in args:
Edward Lemur50984a62020-02-06 18:10:18 +00001825 files.extend([('M', f) for f in _scan_sub_dirs(arg, recursive)])
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001826 return files
1827
1828
Edward Lemur50984a62020-02-06 18:10:18 +00001829def _parse_change(parser, options):
1830 """Process change options.
1831
1832 Args:
1833 parser: The parser used to parse the arguments from command line.
1834 options: The arguments parsed from command line.
1835 Returns:
1836 A GitChange if the change root is a git repository, or a Change otherwise.
1837 """
1838 if options.files and options.all_files:
1839 parser.error('<files> cannot be specified when --all-files is set.')
1840
Edward Lesmes44ea3ff2020-02-05 00:14:30 +00001841 change_scm = scm.determine_scm(options.root)
Edward Lemur50984a62020-02-06 18:10:18 +00001842 if change_scm != 'git' and not options.files:
1843 parser.error('<files> is not optional for unversioned directories.')
1844
1845 if options.files:
1846 change_files = _parse_files(options.files, options.recursive)
1847 elif options.all_files:
1848 change_files = [('M', f) for f in scm.GIT.GetAllFiles(options.root)]
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001849 else:
Edward Lemur50984a62020-02-06 18:10:18 +00001850 change_files = scm.GIT.CaptureStatus(
Edward Lemur7f6dec02020-02-06 20:23:58 +00001851 options.root, options.upstream or None)
Edward Lemur50984a62020-02-06 18:10:18 +00001852
1853 logging.info('Found %d file(s).', len(change_files))
1854
1855 change_class = GitChange if change_scm == 'git' else Change
1856 return change_class(
1857 options.name,
1858 options.description,
1859 options.root,
1860 change_files,
1861 options.issue,
1862 options.patchset,
1863 options.author,
1864 upstream=options.upstream)
1865
1866
1867def _parse_gerrit_options(parser, options):
1868 """Process gerrit options.
1869
1870 SIDE EFFECTS: Modifies options.author and options.description from Gerrit if
1871 options.gerrit_fetch is set.
1872
1873 Args:
1874 parser: The parser used to parse the arguments from command line.
1875 options: The arguments parsed from command line.
1876 Returns:
Stephen Martinisfb09de22021-02-25 03:41:13 +00001877 A GerritAccessor object if options.gerrit_url is set, or None otherwise.
Edward Lemur50984a62020-02-06 18:10:18 +00001878 """
1879 gerrit_obj = None
Stephen Martinisfb09de22021-02-25 03:41:13 +00001880 if options.gerrit_url:
Edward Lesmeseb1bd622021-03-01 19:54:07 +00001881 gerrit_obj = GerritAccessor(
1882 url=options.gerrit_url,
1883 project=options.gerrit_project,
1884 branch=options.gerrit_branch)
Edward Lemur50984a62020-02-06 18:10:18 +00001885
1886 if not options.gerrit_fetch:
1887 return gerrit_obj
1888
1889 if not options.gerrit_url or not options.issue or not options.patchset:
1890 parser.error(
1891 '--gerrit_fetch requires --gerrit_url, --issue and --patchset.')
1892
1893 options.author = gerrit_obj.GetChangeOwner(options.issue)
1894 options.description = gerrit_obj.GetChangeDescription(
1895 options.issue, options.patchset)
1896
1897 logging.info('Got author: "%s"', options.author)
1898 logging.info('Got description: """\n%s\n"""', options.description)
1899
1900 return gerrit_obj
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001901
1902
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001903@contextlib.contextmanager
1904def canned_check_filter(method_names):
1905 filtered = {}
1906 try:
1907 for method_name in method_names:
1908 if not hasattr(presubmit_canned_checks, method_name):
Gavin Make6a62332020-12-04 21:57:10 +00001909 logging.warning('Skipping unknown "canned" check %s' % method_name)
Aaron Gableecee74c2018-04-02 15:13:08 -07001910 continue
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001911 filtered[method_name] = getattr(presubmit_canned_checks, method_name)
1912 setattr(presubmit_canned_checks, method_name, lambda *_a, **_kw: [])
1913 yield
1914 finally:
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001915 for name, method in filtered.items():
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001916 setattr(presubmit_canned_checks, name, method)
1917
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +00001918
sbc@chromium.org013731e2015-02-26 18:28:43 +00001919def main(argv=None):
Edward Lemura5799e32020-01-17 19:26:51 +00001920 parser = argparse.ArgumentParser(usage='%(prog)s [options] <files...>')
1921 hooks = parser.add_mutually_exclusive_group()
1922 hooks.add_argument('-c', '--commit', action='store_true',
1923 help='Use commit instead of upload checks.')
1924 hooks.add_argument('-u', '--upload', action='store_false', dest='commit',
1925 help='Use upload instead of commit checks.')
Edward Lemur75526302020-02-27 22:31:05 +00001926 hooks.add_argument('--post_upload', action='store_true',
1927 help='Run post-upload commit hooks.')
Edward Lemura5799e32020-01-17 19:26:51 +00001928 parser.add_argument('-r', '--recursive', action='store_true',
1929 help='Act recursively.')
1930 parser.add_argument('-v', '--verbose', action='count', default=0,
1931 help='Use 2 times for more debug info.')
1932 parser.add_argument('--name', default='no name')
1933 parser.add_argument('--author')
Edward Lemur227d5102020-02-25 23:45:35 +00001934 desc = parser.add_mutually_exclusive_group()
1935 desc.add_argument('--description', default='', help='The change description.')
1936 desc.add_argument('--description_file',
1937 help='File to read change description from.')
Edward Lemura5799e32020-01-17 19:26:51 +00001938 parser.add_argument('--issue', type=int, default=0)
1939 parser.add_argument('--patchset', type=int, default=0)
1940 parser.add_argument('--root', default=os.getcwd(),
1941 help='Search for PRESUBMIT.py up to this directory. '
1942 'If inherit-review-settings-ok is present in this '
1943 'directory, parent directories up to the root file '
1944 'system directories will also be searched.')
1945 parser.add_argument('--upstream',
1946 help='Git only: the base ref or upstream branch against '
1947 'which the diff should be computed.')
1948 parser.add_argument('--default_presubmit')
1949 parser.add_argument('--may_prompt', action='store_true', default=False)
1950 parser.add_argument('--skip_canned', action='append', default=[],
1951 help='A list of checks to skip which appear in '
1952 'presubmit_canned_checks. Can be provided multiple times '
1953 'to skip multiple canned checks.')
1954 parser.add_argument('--dry_run', action='store_true', help=argparse.SUPPRESS)
1955 parser.add_argument('--gerrit_url', help=argparse.SUPPRESS)
Edward Lesmeseb1bd622021-03-01 19:54:07 +00001956 parser.add_argument('--gerrit_project', help=argparse.SUPPRESS)
1957 parser.add_argument('--gerrit_branch', help=argparse.SUPPRESS)
Edward Lemura5799e32020-01-17 19:26:51 +00001958 parser.add_argument('--gerrit_fetch', action='store_true',
1959 help=argparse.SUPPRESS)
1960 parser.add_argument('--parallel', action='store_true',
1961 help='Run all tests specified by input_api.RunTests in '
1962 'all PRESUBMIT files in parallel.')
1963 parser.add_argument('--json_output',
1964 help='Write presubmit errors to json output.')
Edward Lemur1dc66e12020-02-21 21:36:34 +00001965 parser.add_argument('--all_files', action='store_true',
Edward Lemur50984a62020-02-06 18:10:18 +00001966 help='Mark all files under source control as modified.')
Edward Lemura5799e32020-01-17 19:26:51 +00001967 parser.add_argument('files', nargs='*',
1968 help='List of files to be marked as modified when '
1969 'executing presubmit or post-upload hooks. fnmatch '
1970 'wildcards can also be used.')
Edward Lemura5799e32020-01-17 19:26:51 +00001971 options = parser.parse_args(argv)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001972
Erik Staabcca5c492020-04-16 17:40:07 +00001973 log_level = logging.ERROR
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001974 if options.verbose >= 2:
Erik Staabcca5c492020-04-16 17:40:07 +00001975 log_level = logging.DEBUG
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001976 elif options.verbose:
Erik Staabcca5c492020-04-16 17:40:07 +00001977 log_level = logging.INFO
1978 log_format = ('[%(levelname).1s%(asctime)s %(process)d %(thread)d '
1979 '%(filename)s] %(message)s')
1980 logging.basicConfig(format=log_format, level=log_level)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001981
Edward Lemur227d5102020-02-25 23:45:35 +00001982 if options.description_file:
1983 options.description = gclient_utils.FileRead(options.description_file)
Edward Lemur50984a62020-02-06 18:10:18 +00001984 gerrit_obj = _parse_gerrit_options(parser, options)
1985 change = _parse_change(parser, options)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001986
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001987 try:
Edward Lemur75526302020-02-27 22:31:05 +00001988 if options.post_upload:
1989 return DoPostUploadExecuter(
1990 change,
1991 gerrit_obj,
1992 options.verbose)
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001993 with canned_check_filter(options.skip_canned):
Edward Lemur6eb1d322020-02-27 22:20:15 +00001994 return DoPresubmitChecks(
Edward Lemur50984a62020-02-06 18:10:18 +00001995 change,
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001996 options.commit,
1997 options.verbose,
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001998 options.default_presubmit,
1999 options.may_prompt,
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00002000 gerrit_obj,
Edward Lesmes8e282792018-04-03 18:50:29 -04002001 options.dry_run,
Debrian Figueroadd2737e2019-06-21 23:50:13 +00002002 options.parallel,
Edward Lesmeseb1bd622021-03-01 19:54:07 +00002003 options.json_output)
Raul Tambre7c938462019-05-24 16:35:35 +00002004 except PresubmitFailure as e:
Raul Tambre80ee78e2019-05-06 22:41:05 +00002005 print(e, file=sys.stderr)
2006 print('Maybe your depot_tools is out of date?', file=sys.stderr)
maruel@chromium.org899e1c12011-04-07 17:03:18 +00002007 return 2
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00002008
2009
2010if __name__ == '__main__':
maruel@chromium.org35625c72011-03-23 17:34:02 +00002011 fix_encoding.fix_encoding()
sbc@chromium.org013731e2015-02-26 18:28:43 +00002012 try:
2013 sys.exit(main())
2014 except KeyboardInterrupt:
2015 sys.stderr.write('interrupted\n')
sergiybf8a3b382016-07-05 11:21:30 -07002016 sys.exit(2)