blob: 01201e9e79278049803feb4975bb0f41bfc87ec9 [file] [log] [blame]
maruel@chromium.org725f1c32011-04-01 20:24:54 +00001#!/usr/bin/env python
maruel@chromium.org3bbf2942012-01-10 16:52:06 +00002# Copyright (c) 2012 The Chromium Authors. All rights reserved.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00003# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5
6"""Enables directory-specific presubmit checks to run at upload and/or commit.
7"""
8
Raul Tambre80ee78e2019-05-06 22:41:05 +00009from __future__ import print_function
10
Saagar Sanghavi99816902020-08-11 22:41:25 +000011__version__ = '2.0.0'
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000012
13# TODO(joi) Add caching where appropriate/needed. The API is designed to allow
14# caching (between all different invocations of presubmit scripts for a given
15# change). We should add it as our presubmit scripts start feeling slow.
16
Edward Lemura5799e32020-01-17 19:26:51 +000017import argparse
Takeshi Yoshino07a6bea2017-08-02 02:44:06 +090018import ast # Exposed through the API.
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +000019import contextlib
Yoshisato Yanagisawa406de132018-06-29 05:43:25 +000020import cpplint
dcheng091b7db2016-06-16 01:27:51 -070021import fnmatch # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000022import glob
asvitkine@chromium.org15169952011-09-27 14:30:53 +000023import inspect
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +000024import itertools
maruel@chromium.org4f6852c2012-04-20 20:39:20 +000025import json # Exposed through the API.
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +000026import logging
ilevy@chromium.orgbc117312013-04-20 03:57:56 +000027import multiprocessing
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000028import os # Somewhat exposed through the API.
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +000029import random
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000030import re # Exposed through the API.
Edward Lesmes8e282792018-04-03 18:50:29 -040031import signal
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000032import sys # Parts exposed through API.
33import tempfile # Exposed through the API.
Edward Lesmes8e282792018-04-03 18:50:29 -040034import threading
jam@chromium.org2a891dc2009-08-20 20:33:37 +000035import time
Edward Lemurde9e3ca2019-10-24 21:13:31 +000036import traceback
maruel@chromium.org1487d532009-06-06 00:22:57 +000037import unittest # Exposed through the API.
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +000038from warnings import warn
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000039
40# Local imports.
maruel@chromium.org35625c72011-03-23 17:34:02 +000041import fix_encoding
Yoshisato Yanagisawa04600b42019-03-15 03:03:41 +000042import gclient_paths # Exposed through the API
43import gclient_utils
Aaron Gableb584c4f2017-04-26 16:28:08 -070044import git_footers
tandrii@chromium.org015ebae2016-04-25 19:37:22 +000045import gerrit_util
dpranke@chromium.org2a009622011-03-01 02:43:31 +000046import owners
Jochen Eisinger76f5fc62017-04-07 16:27:46 +020047import owners_finder
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000048import presubmit_canned_checks
Saagar Sanghavi9949ab72020-07-20 20:56:40 +000049import rdb_wrapper
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +000050import scm
maruel@chromium.org84f4fe32011-04-06 13:26:45 +000051import subprocess2 as subprocess # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000052
Edward Lemur16af3562019-10-17 22:11:33 +000053if sys.version_info.major == 2:
54 # TODO(1009814): Expose urllib2 only through urllib_request and urllib_error
55 import urllib2 # Exposed through the API.
56 import urlparse
57 import urllib2 as urllib_request
58 import urllib2 as urllib_error
59else:
60 import urllib.parse as urlparse
61 import urllib.request as urllib_request
62 import urllib.error as urllib_error
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000063
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +000064# Ask for feedback only once in program lifetime.
65_ASKED_FOR_FEEDBACK = False
66
Edward Lemurecc27072020-01-06 16:42:34 +000067def time_time():
68 # Use this so that it can be mocked in tests without interfering with python
69 # system machinery.
70 return time.time()
71
72
maruel@chromium.org899e1c12011-04-07 17:03:18 +000073class PresubmitFailure(Exception):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000074 pass
75
76
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000077class CommandData(object):
Edward Lemur940c2822019-08-23 00:34:25 +000078 def __init__(self, name, cmd, kwargs, message, python3=False):
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000079 self.name = name
80 self.cmd = cmd
Edward Lesmes8e282792018-04-03 18:50:29 -040081 self.stdin = kwargs.get('stdin', None)
Edward Lemur2d6b67c2019-08-23 22:25:41 +000082 self.kwargs = kwargs.copy()
Edward Lesmes8e282792018-04-03 18:50:29 -040083 self.kwargs['stdout'] = subprocess.PIPE
84 self.kwargs['stderr'] = subprocess.STDOUT
85 self.kwargs['stdin'] = subprocess.PIPE
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000086 self.message = message
87 self.info = None
Edward Lemur940c2822019-08-23 00:34:25 +000088 self.python3 = python3
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000089
ilevy@chromium.orgbc117312013-04-20 03:57:56 +000090
Edward Lesmes8e282792018-04-03 18:50:29 -040091# Adapted from
92# https://github.com/google/gtest-parallel/blob/master/gtest_parallel.py#L37
93#
94# An object that catches SIGINT sent to the Python process and notices
95# if processes passed to wait() die by SIGINT (we need to look for
96# both of those cases, because pressing Ctrl+C can result in either
97# the main process or one of the subprocesses getting the signal).
98#
99# Before a SIGINT is seen, wait(p) will simply call p.wait() and
100# return the result. Once a SIGINT has been seen (in the main process
101# or a subprocess, including the one the current call is waiting for),
Edward Lemur9a5bb612019-09-26 02:01:52 +0000102# wait(p) will call p.terminate().
Edward Lesmes8e282792018-04-03 18:50:29 -0400103class SigintHandler(object):
Edward Lesmes8e282792018-04-03 18:50:29 -0400104 sigint_returncodes = {-signal.SIGINT, # Unix
105 -1073741510, # Windows
106 }
107 def __init__(self):
108 self.__lock = threading.Lock()
109 self.__processes = set()
110 self.__got_sigint = False
Edward Lemur9a5bb612019-09-26 02:01:52 +0000111 self.__previous_signal = signal.signal(signal.SIGINT, self.interrupt)
Edward Lesmes8e282792018-04-03 18:50:29 -0400112
113 def __on_sigint(self):
114 self.__got_sigint = True
115 while self.__processes:
116 try:
117 self.__processes.pop().terminate()
118 except OSError:
119 pass
120
Edward Lemur9a5bb612019-09-26 02:01:52 +0000121 def interrupt(self, signal_num, frame):
Edward Lesmes8e282792018-04-03 18:50:29 -0400122 with self.__lock:
123 self.__on_sigint()
Edward Lemur9a5bb612019-09-26 02:01:52 +0000124 self.__previous_signal(signal_num, frame)
Edward Lesmes8e282792018-04-03 18:50:29 -0400125
126 def got_sigint(self):
127 with self.__lock:
128 return self.__got_sigint
129
130 def wait(self, p, stdin):
131 with self.__lock:
132 if self.__got_sigint:
133 p.terminate()
134 self.__processes.add(p)
135 stdout, stderr = p.communicate(stdin)
136 code = p.returncode
137 with self.__lock:
138 self.__processes.discard(p)
139 if code in self.sigint_returncodes:
140 self.__on_sigint()
Edward Lesmes8e282792018-04-03 18:50:29 -0400141 return stdout, stderr
142
143sigint_handler = SigintHandler()
144
145
Edward Lemurecc27072020-01-06 16:42:34 +0000146class Timer(object):
147 def __init__(self, timeout, fn):
148 self.completed = False
149 self._fn = fn
150 self._timer = threading.Timer(timeout, self._onTimer) if timeout else None
151
152 def __enter__(self):
153 if self._timer:
154 self._timer.start()
155 return self
156
157 def __exit__(self, _type, _value, _traceback):
158 if self._timer:
159 self._timer.cancel()
160
161 def _onTimer(self):
162 self._fn()
163 self.completed = True
164
165
Edward Lesmes8e282792018-04-03 18:50:29 -0400166class ThreadPool(object):
Edward Lemurecc27072020-01-06 16:42:34 +0000167 def __init__(self, pool_size=None, timeout=None):
168 self.timeout = timeout
Edward Lesmes8e282792018-04-03 18:50:29 -0400169 self._pool_size = pool_size or multiprocessing.cpu_count()
170 self._messages = []
171 self._messages_lock = threading.Lock()
172 self._tests = []
173 self._tests_lock = threading.Lock()
174 self._nonparallel_tests = []
175
Edward Lemurecc27072020-01-06 16:42:34 +0000176 def _GetCommand(self, test):
Edward Lemur940c2822019-08-23 00:34:25 +0000177 vpython = 'vpython'
178 if test.python3:
179 vpython += '3'
180 if sys.platform == 'win32':
181 vpython += '.bat'
Edward Lesmes8e282792018-04-03 18:50:29 -0400182
183 cmd = test.cmd
184 if cmd[0] == 'python':
185 cmd = list(cmd)
186 cmd[0] = vpython
187 elif cmd[0].endswith('.py'):
188 cmd = [vpython] + cmd
189
Edward Lemur336e51f2019-11-14 21:42:04 +0000190 # On Windows, scripts on the current directory take precedence over PATH, so
191 # that when testing depot_tools on Windows, calling `vpython.bat` will
192 # execute the copy of vpython of the depot_tools under test instead of the
193 # one in the bot.
194 # As a workaround, we run the tests from the parent directory instead.
195 if (cmd[0] == vpython and
196 'cwd' in test.kwargs and
197 os.path.basename(test.kwargs['cwd']) == 'depot_tools'):
198 test.kwargs['cwd'] = os.path.dirname(test.kwargs['cwd'])
199 cmd[1] = os.path.join('depot_tools', cmd[1])
200
Edward Lemurecc27072020-01-06 16:42:34 +0000201 return cmd
202
203 def _RunWithTimeout(self, cmd, stdin, kwargs):
204 p = subprocess.Popen(cmd, **kwargs)
205 with Timer(self.timeout, p.terminate) as timer:
206 stdout, _ = sigint_handler.wait(p, stdin)
207 if timer.completed:
208 stdout = 'Process timed out after %ss\n%s' % (self.timeout, stdout)
209 return p.returncode, stdout
210
211 def CallCommand(self, test):
212 """Runs an external program.
213
Edward Lemura5799e32020-01-17 19:26:51 +0000214 This function converts invocation of .py files and invocations of 'python'
Edward Lemurecc27072020-01-06 16:42:34 +0000215 to vpython invocations.
216 """
217 cmd = self._GetCommand(test)
Edward Lesmes8e282792018-04-03 18:50:29 -0400218 try:
Edward Lemurecc27072020-01-06 16:42:34 +0000219 start = time_time()
220 returncode, stdout = self._RunWithTimeout(cmd, test.stdin, test.kwargs)
221 duration = time_time() - start
Edward Lemur7cf94382019-11-15 22:36:41 +0000222 except Exception:
Edward Lemurecc27072020-01-06 16:42:34 +0000223 duration = time_time() - start
Edward Lesmes8e282792018-04-03 18:50:29 -0400224 return test.message(
Edward Lemur7cf94382019-11-15 22:36:41 +0000225 '%s\n%s exec failure (%4.2fs)\n%s' % (
226 test.name, ' '.join(cmd), duration, traceback.format_exc()))
Edward Lemurde9e3ca2019-10-24 21:13:31 +0000227
Edward Lemurecc27072020-01-06 16:42:34 +0000228 if returncode != 0:
Edward Lesmes8e282792018-04-03 18:50:29 -0400229 return test.message(
Edward Lemur7cf94382019-11-15 22:36:41 +0000230 '%s\n%s (%4.2fs) failed\n%s' % (
231 test.name, ' '.join(cmd), duration, stdout))
Edward Lemurecc27072020-01-06 16:42:34 +0000232
Edward Lesmes8e282792018-04-03 18:50:29 -0400233 if test.info:
Edward Lemur7cf94382019-11-15 22:36:41 +0000234 return test.info('%s\n%s (%4.2fs)' % (test.name, ' '.join(cmd), duration))
Edward Lesmes8e282792018-04-03 18:50:29 -0400235
236 def AddTests(self, tests, parallel=True):
237 if parallel:
238 self._tests.extend(tests)
239 else:
240 self._nonparallel_tests.extend(tests)
241
242 def RunAsync(self):
243 self._messages = []
244
245 def _WorkerFn():
246 while True:
247 test = None
248 with self._tests_lock:
249 if not self._tests:
250 break
251 test = self._tests.pop()
252 result = self.CallCommand(test)
253 if result:
254 with self._messages_lock:
255 self._messages.append(result)
256
257 def _StartDaemon():
258 t = threading.Thread(target=_WorkerFn)
259 t.daemon = True
260 t.start()
261 return t
262
263 while self._nonparallel_tests:
264 test = self._nonparallel_tests.pop()
265 result = self.CallCommand(test)
266 if result:
267 self._messages.append(result)
268
269 if self._tests:
270 threads = [_StartDaemon() for _ in range(self._pool_size)]
271 for worker in threads:
272 worker.join()
273
274 return self._messages
275
276
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000277def normpath(path):
278 '''Version of os.path.normpath that also changes backward slashes to
279 forward slashes when not running on Windows.
280 '''
281 # This is safe to always do because the Windows version of os.path.normpath
282 # will replace forward slashes with backward slashes.
283 path = path.replace(os.sep, '/')
284 return os.path.normpath(path)
285
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000286
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000287def _RightHandSideLinesImpl(affected_files):
288 """Implements RightHandSideLines for InputApi and GclChange."""
289 for af in affected_files:
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000290 lines = af.ChangedContents()
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000291 for line in lines:
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000292 yield (af, line[0], line[1])
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000293
294
Edward Lemur6eb1d322020-02-27 22:20:15 +0000295def prompt_should_continue(prompt_string):
296 sys.stdout.write(prompt_string)
297 response = sys.stdin.readline().strip().lower()
298 return response in ('y', 'yes')
dpranke@chromium.org5ac21012011-03-16 02:58:25 +0000299
300
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000301# Top level object so multiprocessing can pickle
302# Public access through OutputApi object.
303class _PresubmitResult(object):
304 """Base class for result objects."""
305 fatal = False
306 should_prompt = False
307
308 def __init__(self, message, items=None, long_text=''):
309 """
310 message: A short one-line message to indicate errors.
311 items: A list of short strings to indicate where errors occurred.
312 long_text: multi-line text output, e.g. from another tool
313 """
314 self._message = message
315 self._items = items or []
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000316 self._long_text = long_text.rstrip()
317
Edward Lemur6eb1d322020-02-27 22:20:15 +0000318 def handle(self):
319 sys.stdout.write(self._message)
320 sys.stdout.write('\n')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000321 for index, item in enumerate(self._items):
Edward Lemur6eb1d322020-02-27 22:20:15 +0000322 sys.stdout.write(' ')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000323 # Write separately in case it's unicode.
Edward Lemur6eb1d322020-02-27 22:20:15 +0000324 sys.stdout.write(str(item))
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000325 if index < len(self._items) - 1:
Edward Lemur6eb1d322020-02-27 22:20:15 +0000326 sys.stdout.write(' \\')
327 sys.stdout.write('\n')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000328 if self._long_text:
Edward Lemur6eb1d322020-02-27 22:20:15 +0000329 sys.stdout.write('\n***************\n')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000330 # Write separately in case it's unicode.
Edward Lemur6eb1d322020-02-27 22:20:15 +0000331 sys.stdout.write(self._long_text)
332 sys.stdout.write('\n***************\n')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000333
Debrian Figueroadd2737e2019-06-21 23:50:13 +0000334 def json_format(self):
335 return {
336 'message': self._message,
Debrian Figueroa6095d402019-06-28 18:47:18 +0000337 'items': [str(item) for item in self._items],
Debrian Figueroadd2737e2019-06-21 23:50:13 +0000338 'long_text': self._long_text,
339 'fatal': self.fatal
340 }
341
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000342
343# Top level object so multiprocessing can pickle
344# Public access through OutputApi object.
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000345class _PresubmitError(_PresubmitResult):
346 """A hard presubmit error."""
347 fatal = True
348
349
350# Top level object so multiprocessing can pickle
351# Public access through OutputApi object.
352class _PresubmitPromptWarning(_PresubmitResult):
353 """An warning that prompts the user if they want to continue."""
354 should_prompt = True
355
356
357# Top level object so multiprocessing can pickle
358# Public access through OutputApi object.
359class _PresubmitNotifyResult(_PresubmitResult):
360 """Just print something to the screen -- but it's not even a warning."""
361 pass
362
363
364# Top level object so multiprocessing can pickle
365# Public access through OutputApi object.
366class _MailTextResult(_PresubmitResult):
367 """A warning that should be included in the review request email."""
368 def __init__(self, *args, **kwargs):
369 super(_MailTextResult, self).__init__()
370 raise NotImplementedError()
371
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000372class GerritAccessor(object):
373 """Limited Gerrit functionality for canned presubmit checks to work.
374
375 To avoid excessive Gerrit calls, caches the results.
376 """
377
378 def __init__(self, host):
379 self.host = host
380 self.cache = {}
381
382 def _FetchChangeDetail(self, issue):
383 # Separate function to be easily mocked in tests.
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +0100384 try:
385 return gerrit_util.GetChangeDetail(
386 self.host, str(issue),
Aaron Gable6f5a8d92017-04-18 14:49:05 -0700387 ['ALL_REVISIONS', 'DETAILED_LABELS', 'ALL_COMMITS'])
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +0100388 except gerrit_util.GerritError as e:
389 if e.http_status == 404:
390 raise Exception('Either Gerrit issue %s doesn\'t exist, or '
391 'no credentials to fetch issue details' % issue)
392 raise
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000393
394 def GetChangeInfo(self, issue):
395 """Returns labels and all revisions (patchsets) for this issue.
396
397 The result is a dictionary according to Gerrit REST Api.
398 https://gerrit-review.googlesource.com/Documentation/rest-api.html
399
400 However, API isn't very clear what's inside, so see tests for example.
401 """
402 assert issue
403 cache_key = int(issue)
404 if cache_key not in self.cache:
405 self.cache[cache_key] = self._FetchChangeDetail(issue)
406 return self.cache[cache_key]
407
408 def GetChangeDescription(self, issue, patchset=None):
409 """If patchset is none, fetches current patchset."""
410 info = self.GetChangeInfo(issue)
411 # info is a reference to cache. We'll modify it here adding description to
412 # it to the right patchset, if it is not yet there.
413
414 # Find revision info for the patchset we want.
415 if patchset is not None:
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +0000416 for rev, rev_info in info['revisions'].items():
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000417 if str(rev_info['_number']) == str(patchset):
418 break
419 else:
420 raise Exception('patchset %s doesn\'t exist in issue %s' % (
421 patchset, issue))
422 else:
423 rev = info['current_revision']
424 rev_info = info['revisions'][rev]
425
Andrii Shyshkalov9c3a4642017-01-24 17:41:22 +0100426 return rev_info['commit']['message']
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000427
Mun Yong Jang603d01e2017-12-19 16:38:30 -0800428 def GetDestRef(self, issue):
429 ref = self.GetChangeInfo(issue)['branch']
430 if not ref.startswith('refs/'):
431 # NOTE: it is possible to create 'refs/x' branch,
432 # aka 'refs/heads/refs/x'. However, this is ill-advised.
433 ref = 'refs/heads/%s' % ref
434 return ref
435
Edward Lesmes02d4b822020-11-11 00:37:35 +0000436 def _GetApproversForLabel(self, issue, label):
437 change_info = self.GetChangeInfo(issue)
438 label_info = change_info.get('labels', {}).get(label, {})
439 values = label_info.get('values', {}).keys()
440 if not values:
441 return []
442 max_value = max(int(v) for v in values)
443 return [v for v in label_info.get('all', [])
444 if v.get('value', 0) == max_value]
445
446 def IsBotCommitApproved(self, issue):
447 return bool(self._GetApproversForLabel(issue, 'Bot-Commit'))
448
Edward Lesmescf49cb82020-11-11 01:08:36 +0000449 def IsOwnersOverrideApproved(self, issue):
450 return bool(self._GetApproversForLabel(issue, 'Owners-Override'))
451
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000452 def GetChangeOwner(self, issue):
453 return self.GetChangeInfo(issue)['owner']['email']
454
455 def GetChangeReviewers(self, issue, approving_only=True):
Aaron Gable8b478f02017-07-31 15:33:19 -0700456 changeinfo = self.GetChangeInfo(issue)
457 if approving_only:
Edward Lesmes02d4b822020-11-11 00:37:35 +0000458 reviewers = self._GetApproversForLabel(issue, 'Code-Review')
Aaron Gable8b478f02017-07-31 15:33:19 -0700459 else:
460 reviewers = changeinfo.get('reviewers', {}).get('REVIEWER', [])
461 return [r.get('email') for r in reviewers]
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000462
Edward Lemure4d329c2020-02-03 20:41:18 +0000463 def UpdateDescription(self, description, issue):
464 gerrit_util.SetCommitMessage(self.host, issue, description, notify='NONE')
465
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000466
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000467class OutputApi(object):
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000468 """An instance of OutputApi gets passed to presubmit scripts so that they
469 can output various types of results.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000470 """
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000471 PresubmitResult = _PresubmitResult
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000472 PresubmitError = _PresubmitError
473 PresubmitPromptWarning = _PresubmitPromptWarning
474 PresubmitNotifyResult = _PresubmitNotifyResult
475 MailTextResult = _MailTextResult
476
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000477 def __init__(self, is_committing):
478 self.is_committing = is_committing
Daniel Cheng7227d212017-11-17 08:12:37 -0800479 self.more_cc = []
480
481 def AppendCC(self, cc):
482 """Appends a user to cc for this change."""
483 self.more_cc.append(cc)
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000484
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000485 def PresubmitPromptOrNotify(self, *args, **kwargs):
486 """Warn the user when uploading, but only notify if committing."""
487 if self.is_committing:
488 return self.PresubmitNotifyResult(*args, **kwargs)
489 return self.PresubmitPromptWarning(*args, **kwargs)
490
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000491
492class InputApi(object):
493 """An instance of this object is passed to presubmit scripts so they can
494 know stuff about the change they're looking at.
495 """
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000496 # Method could be a function
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800497 # pylint: disable=no-self-use
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000498
maruel@chromium.org3410d912009-06-09 20:56:16 +0000499 # File extensions that are considered source files from a style guide
500 # perspective. Don't modify this list from a presubmit script!
maruel@chromium.orgc33455a2011-06-24 19:14:18 +0000501 #
502 # Files without an extension aren't included in the list. If you want to
local_bot30f774e2020-06-25 18:23:34 +0000503 # filter them as source files, add r'(^|.*?[\\\/])[^.]+$' to the allow list.
local_bot64021412020-07-08 21:05:39 +0000504 # Note that ALL CAPS files are skipped in DEFAULT_FILES_TO_SKIP below.
505 DEFAULT_FILES_TO_CHECK = (
maruel@chromium.org3410d912009-06-09 20:56:16 +0000506 # C++ and friends
Edward Lemura5799e32020-01-17 19:26:51 +0000507 r'.+\.c$', r'.+\.cc$', r'.+\.cpp$', r'.+\.h$', r'.+\.m$', r'.+\.mm$',
508 r'.+\.inl$', r'.+\.asm$', r'.+\.hxx$', r'.+\.hpp$', r'.+\.s$', r'.+\.S$',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000509 # Scripts
Edward Lemura5799e32020-01-17 19:26:51 +0000510 r'.+\.js$', r'.+\.py$', r'.+\.sh$', r'.+\.rb$', r'.+\.pl$', r'.+\.pm$',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000511 # Other
Edward Lemura5799e32020-01-17 19:26:51 +0000512 r'.+\.java$', r'.+\.mk$', r'.+\.am$', r'.+\.css$', r'.+\.mojom$',
513 r'.+\.fidl$'
maruel@chromium.org3410d912009-06-09 20:56:16 +0000514 )
515
516 # Path regexp that should be excluded from being considered containing source
517 # files. Don't modify this list from a presubmit script!
local_bot64021412020-07-08 21:05:39 +0000518 DEFAULT_FILES_TO_SKIP = (
Edward Lemura5799e32020-01-17 19:26:51 +0000519 r'testing_support[\\\/]google_appengine[\\\/].*',
520 r'.*\bexperimental[\\\/].*',
Kent Tamura179dd1e2018-04-26 15:07:41 +0900521 # Exclude third_party/.* but NOT third_party/{WebKit,blink}
522 # (crbug.com/539768 and crbug.com/836555).
Edward Lemura5799e32020-01-17 19:26:51 +0000523 r'.*\bthird_party[\\\/](?!(WebKit|blink)[\\\/]).*',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000524 # Output directories (just in case)
Edward Lemura5799e32020-01-17 19:26:51 +0000525 r'.*\bDebug[\\\/].*',
526 r'.*\bRelease[\\\/].*',
527 r'.*\bxcodebuild[\\\/].*',
528 r'.*\bout[\\\/].*',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000529 # All caps files like README and LICENCE.
Edward Lemura5799e32020-01-17 19:26:51 +0000530 r'.*\b[A-Z0-9_]{2,}$',
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +0000531 # SCM (can happen in dual SCM configuration). (Slightly over aggressive)
Edward Lemura5799e32020-01-17 19:26:51 +0000532 r'(|.*[\\\/])\.git[\\\/].*',
533 r'(|.*[\\\/])\.svn[\\\/].*',
maruel@chromium.org7ccb4bb2011-11-07 20:26:20 +0000534 # There is no point in processing a patch file.
Edward Lemura5799e32020-01-17 19:26:51 +0000535 r'.+\.diff$',
536 r'.+\.patch$',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000537 )
538
local_bot30f774e2020-06-25 18:23:34 +0000539 # TODO(https://crbug.com/1098562): Remove once no longer used
540 @property
541 def DEFAULT_WHITE_LIST(self):
local_bot64021412020-07-08 21:05:39 +0000542 return self.DEFAULT_FILES_TO_CHECK
local_bot30f774e2020-06-25 18:23:34 +0000543
544 # TODO(https://crbug.com/1098562): Remove once no longer used
local_bot37ce2012020-06-26 17:39:24 +0000545 @DEFAULT_WHITE_LIST.setter
546 def DEFAULT_WHITE_LIST(self, value):
local_bot64021412020-07-08 21:05:39 +0000547 self.DEFAULT_FILES_TO_CHECK = value
548
549 # TODO(https://crbug.com/1098562): Remove once no longer used
550 @property
551 def DEFAULT_ALLOW_LIST(self):
552 return self.DEFAULT_FILES_TO_CHECK
553
554 # TODO(https://crbug.com/1098562): Remove once no longer used
555 @DEFAULT_ALLOW_LIST.setter
556 def DEFAULT_ALLOW_LIST(self, value):
557 self.DEFAULT_FILES_TO_CHECK = value
local_bot37ce2012020-06-26 17:39:24 +0000558
559 # TODO(https://crbug.com/1098562): Remove once no longer used
local_bot30f774e2020-06-25 18:23:34 +0000560 @property
561 def DEFAULT_BLACK_LIST(self):
local_bot64021412020-07-08 21:05:39 +0000562 return self.DEFAULT_FILES_TO_SKIP
local_bot30f774e2020-06-25 18:23:34 +0000563
local_bot37ce2012020-06-26 17:39:24 +0000564 # TODO(https://crbug.com/1098562): Remove once no longer used
565 @DEFAULT_BLACK_LIST.setter
566 def DEFAULT_BLACK_LIST(self, value):
local_bot64021412020-07-08 21:05:39 +0000567 self.DEFAULT_FILES_TO_SKIP = value
568
569 # TODO(https://crbug.com/1098562): Remove once no longer used
570 @property
571 def DEFAULT_BLOCK_LIST(self):
572 return self.DEFAULT_FILES_TO_SKIP
573
574 # TODO(https://crbug.com/1098562): Remove once no longer used
575 @DEFAULT_BLOCK_LIST.setter
576 def DEFAULT_BLOCK_LIST(self, value):
577 self.DEFAULT_FILES_TO_SKIP = value
local_bot37ce2012020-06-26 17:39:24 +0000578
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000579 def __init__(self, change, presubmit_path, is_committing,
Edward Lesmes8e282792018-04-03 18:50:29 -0400580 verbose, gerrit_obj, dry_run=None, thread_pool=None, parallel=False):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000581 """Builds an InputApi object.
582
583 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000584 change: A presubmit.Change object.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000585 presubmit_path: The path to the presubmit script being processed.
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000586 is_committing: True if the change is about to be committed.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000587 gerrit_obj: provides basic Gerrit codereview functionality.
588 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -0400589 parallel: if true, all tests reported via input_api.RunTests for all
590 PRESUBMIT files will be run in parallel.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000591 """
maruel@chromium.org9711bba2009-05-22 23:51:39 +0000592 # Version number of the presubmit_support script.
593 self.version = [int(x) for x in __version__.split('.')]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000594 self.change = change
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000595 self.is_committing = is_committing
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000596 self.gerrit = gerrit_obj
tandrii@chromium.org57bafac2016-04-28 05:09:03 +0000597 self.dry_run = dry_run
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000598
Edward Lesmes8e282792018-04-03 18:50:29 -0400599 self.parallel = parallel
600 self.thread_pool = thread_pool or ThreadPool()
601
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000602 # We expose various modules and functions as attributes of the input_api
603 # so that presubmit scripts don't have to import them.
Takeshi Yoshino07a6bea2017-08-02 02:44:06 +0900604 self.ast = ast
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000605 self.basename = os.path.basename
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000606 self.cpplint = cpplint
dcheng091b7db2016-06-16 01:27:51 -0700607 self.fnmatch = fnmatch
Yoshisato Yanagisawa04600b42019-03-15 03:03:41 +0000608 self.gclient_paths = gclient_paths
Yoshisato Yanagisawa57dd17b2019-03-22 09:10:29 +0000609 # TODO(yyanagisawa): stop exposing this when python3 become default.
610 # Since python3's tempfile has TemporaryDirectory, we do not need this.
611 self.temporary_directory = gclient_utils.temporary_directory
dpranke@chromium.org17cc2442012-10-17 21:12:09 +0000612 self.glob = glob.glob
maruel@chromium.orgfb11c7b2010-03-18 18:22:14 +0000613 self.json = json
maruel@chromium.org6fba34d2011-06-02 13:45:12 +0000614 self.logging = logging.getLogger('PRESUBMIT')
maruel@chromium.org2b5ce562011-03-31 16:15:44 +0000615 self.os_listdir = os.listdir
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000616 self.os_path = os.path
pgervais@chromium.orgbd0cace2014-10-02 23:23:46 +0000617 self.os_stat = os.stat
Yoshisato Yanagisawa406de132018-06-29 05:43:25 +0000618 self.os_walk = os.walk
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000619 self.re = re
620 self.subprocess = subprocess
Edward Lemurb9830242019-10-30 22:19:20 +0000621 self.sys = sys
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000622 self.tempfile = tempfile
dpranke@chromium.org0d1bdea2011-03-24 22:54:38 +0000623 self.time = time
maruel@chromium.org1487d532009-06-06 00:22:57 +0000624 self.unittest = unittest
Edward Lemurb9830242019-10-30 22:19:20 +0000625 if sys.version_info.major == 2:
626 self.urllib2 = urllib2
Edward Lemur16af3562019-10-17 22:11:33 +0000627 self.urllib_request = urllib_request
628 self.urllib_error = urllib_error
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000629
Robert Iannucci50258932018-03-19 10:30:59 -0700630 self.is_windows = sys.platform == 'win32'
631
Edward Lemurb9646622019-10-25 20:57:35 +0000632 # Set python_executable to 'vpython' in order to allow scripts in other
633 # repos (e.g. src.git) to automatically pick up that repo's .vpython file,
634 # instead of inheriting the one in depot_tools.
635 self.python_executable = 'vpython'
maruel@chromium.orgc0b22972009-06-25 16:19:14 +0000636 self.environ = os.environ
637
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000638 # InputApi.platform is the platform you're currently running on.
639 self.platform = sys.platform
640
iannucci@chromium.org0af3bb32015-06-12 20:44:35 +0000641 self.cpu_count = multiprocessing.cpu_count()
642
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000643 # The local path of the currently-being-processed presubmit script.
maruel@chromium.org3d235242009-05-15 12:40:48 +0000644 self._current_presubmit_path = os.path.dirname(presubmit_path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000645
646 # We carry the canned checks so presubmit scripts can easily use them.
647 self.canned_checks = presubmit_canned_checks
648
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +0100649 # Temporary files we must manually remove at the end of a run.
650 self._named_temporary_files = []
Jochen Eisinger72606f82017-04-04 10:44:18 +0200651
dpranke@chromium.org2a009622011-03-01 02:43:31 +0000652 # TODO(dpranke): figure out a list of all approved owners for a repo
653 # in order to be able to handle wildcard OWNERS files?
654 self.owners_db = owners.Database(change.RepositoryRoot(),
Edward Lemurb9830242019-10-30 22:19:20 +0000655 fopen=open, os_path=self.os_path)
Jochen Eisinger76f5fc62017-04-07 16:27:46 +0200656 self.owners_finder = owners_finder.OwnersFinder
maruel@chromium.org899e1c12011-04-07 17:03:18 +0000657 self.verbose = verbose
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000658 self.Command = CommandData
dpranke@chromium.org2a009622011-03-01 02:43:31 +0000659
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000660 # Replace <hash_map> and <hash_set> as headers that need to be included
Edward Lemura5799e32020-01-17 19:26:51 +0000661 # with 'base/containers/hash_tables.h' instead.
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000662 # Access to a protected member _XX of a client class
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800663 # pylint: disable=protected-access
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000664 self.cpplint._re_pattern_templates = [
danakj@chromium.org18278522013-06-11 22:42:32 +0000665 (a, b, 'base/containers/hash_tables.h')
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000666 if header in ('<hash_map>', '<hash_set>') else (a, b, header)
667 for (a, b, header) in cpplint._re_pattern_templates
668 ]
669
Edward Lemurecc27072020-01-06 16:42:34 +0000670 def SetTimeout(self, timeout):
671 self.thread_pool.timeout = timeout
672
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000673 def PresubmitLocalPath(self):
674 """Returns the local path of the presubmit script currently being run.
675
676 This is useful if you don't want to hard-code absolute paths in the
677 presubmit script. For example, It can be used to find another file
678 relative to the PRESUBMIT.py script, so the whole tree can be branched and
679 the presubmit script still works, without editing its content.
680 """
maruel@chromium.org3d235242009-05-15 12:40:48 +0000681 return self._current_presubmit_path
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000682
agable0b65e732016-11-22 09:25:46 -0800683 def AffectedFiles(self, include_deletes=True, file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000684 """Same as input_api.change.AffectedFiles() except only lists files
685 (and optionally directories) in the same directory as the current presubmit
Bruce Dawson7a0b07a2020-04-23 17:14:40 +0000686 script, or subdirectories thereof. Note that files are listed using the OS
687 path separator, so backslashes are used as separators on Windows.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000688 """
Edward Lemura5799e32020-01-17 19:26:51 +0000689 dir_with_slash = normpath('%s/' % self.PresubmitLocalPath())
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000690 if len(dir_with_slash) == 1:
691 dir_with_slash = ''
sail@chromium.org5538e022011-05-12 17:53:16 +0000692
Edward Lemurb9830242019-10-30 22:19:20 +0000693 return list(filter(
maruel@chromium.org4661e0c2009-06-04 00:45:26 +0000694 lambda x: normpath(x.AbsoluteLocalPath()).startswith(dir_with_slash),
Edward Lemurb9830242019-10-30 22:19:20 +0000695 self.change.AffectedFiles(include_deletes, file_filter)))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000696
agable0b65e732016-11-22 09:25:46 -0800697 def LocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000698 """Returns local paths of input_api.AffectedFiles()."""
agable0b65e732016-11-22 09:25:46 -0800699 paths = [af.LocalPath() for af in self.AffectedFiles()]
Edward Lemura5799e32020-01-17 19:26:51 +0000700 logging.debug('LocalPaths: %s', paths)
pgervais@chromium.org2f64f782014-04-25 00:12:33 +0000701 return paths
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000702
agable0b65e732016-11-22 09:25:46 -0800703 def AbsoluteLocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000704 """Returns absolute local paths of input_api.AffectedFiles()."""
agable0b65e732016-11-22 09:25:46 -0800705 return [af.AbsoluteLocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000706
John Budorick16162372018-04-18 10:39:53 -0700707 def AffectedTestableFiles(self, include_deletes=None, **kwargs):
agable0b65e732016-11-22 09:25:46 -0800708 """Same as input_api.change.AffectedTestableFiles() except only lists files
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000709 in the same directory as the current presubmit script, or subdirectories
710 thereof.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000711 """
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000712 if include_deletes is not None:
Edward Lemura5799e32020-01-17 19:26:51 +0000713 warn('AffectedTestableFiles(include_deletes=%s)'
714 ' is deprecated and ignored' % str(include_deletes),
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000715 category=DeprecationWarning,
716 stacklevel=2)
Edward Lemurb9830242019-10-30 22:19:20 +0000717 return list(filter(
718 lambda x: x.IsTestableFile(),
719 self.AffectedFiles(include_deletes=False, **kwargs)))
agable0b65e732016-11-22 09:25:46 -0800720
721 def AffectedTextFiles(self, include_deletes=None):
722 """An alias to AffectedTestableFiles for backwards compatibility."""
723 return self.AffectedTestableFiles(include_deletes=include_deletes)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000724
local_bot64021412020-07-08 21:05:39 +0000725 def FilterSourceFile(self, affected_file, files_to_check=None,
726 files_to_skip=None, allow_list=None, block_list=None,
local_bot30f774e2020-06-25 18:23:34 +0000727 white_list=None, black_list=None):
Edward Lemura5799e32020-01-17 19:26:51 +0000728 """Filters out files that aren't considered 'source file'.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000729
local_bot64021412020-07-08 21:05:39 +0000730 If files_to_check or files_to_skip is None, InputApi.DEFAULT_FILES_TO_CHECK
731 and InputApi.DEFAULT_FILES_TO_SKIP is used respectively.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000732
733 The lists will be compiled as regular expression and
734 AffectedFile.LocalPath() needs to pass both list.
735
local_bot64021412020-07-08 21:05:39 +0000736 Note: if files_to_check or files_to_skip is not set, and
737 white_list/allow_list or black_list/block_list is, then those values are
738 used. This is used for backward compatibility reasons.
local_bot30f774e2020-06-25 18:23:34 +0000739
maruel@chromium.org3410d912009-06-09 20:56:16 +0000740 Note: Copy-paste this function to suit your needs or use a lambda function.
741 """
Josip Sokcevicc6aa1512020-08-25 23:47:13 +0000742 # TODO(https://crbug.com/1098560): Remove non inclusive parameter names.
743 if files_to_check is None and (allow_list or white_list):
744 warn('Use files_to_check in FilterSourceFile')
local_bot64021412020-07-08 21:05:39 +0000745 files_to_check = allow_list or white_list
Josip Sokcevicc6aa1512020-08-25 23:47:13 +0000746 if files_to_skip is None and (block_list or black_list):
747 warn('Use files_to_skip in FilterSourceFile')
local_bot64021412020-07-08 21:05:39 +0000748 files_to_skip = block_list or black_list
749
750 if files_to_check is None:
751 files_to_check = self.DEFAULT_FILES_TO_CHECK
752 if files_to_skip is None:
753 files_to_skip = self.DEFAULT_FILES_TO_SKIP
local_bot30f774e2020-06-25 18:23:34 +0000754
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000755 def Find(affected_file, items):
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000756 local_path = affected_file.LocalPath()
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000757 for item in items:
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +0000758 if self.re.match(item, local_path):
maruel@chromium.org3410d912009-06-09 20:56:16 +0000759 return True
760 return False
local_bot64021412020-07-08 21:05:39 +0000761 return (Find(affected_file, files_to_check) and
762 not Find(affected_file, files_to_skip))
maruel@chromium.org3410d912009-06-09 20:56:16 +0000763
764 def AffectedSourceFiles(self, source_file):
agable0b65e732016-11-22 09:25:46 -0800765 """Filter the list of AffectedTestableFiles by the function source_file.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000766
767 If source_file is None, InputApi.FilterSourceFile() is used.
768 """
769 if not source_file:
770 source_file = self.FilterSourceFile
Edward Lemurb9830242019-10-30 22:19:20 +0000771 return list(filter(source_file, self.AffectedTestableFiles()))
maruel@chromium.org3410d912009-06-09 20:56:16 +0000772
773 def RightHandSideLines(self, source_file_filter=None):
Edward Lemura5799e32020-01-17 19:26:51 +0000774 """An iterator over all text lines in 'new' version of changed files.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000775
776 Only lists lines from new or modified text files in the change that are
777 contained by the directory of the currently executing presubmit script.
778
779 This is useful for doing line-by-line regex checks, like checking for
780 trailing whitespace.
781
782 Yields:
783 a 3 tuple:
784 the AffectedFile instance of the current file;
785 integer line number (1-based); and
786 the contents of the line as a string.
maruel@chromium.org1487d532009-06-06 00:22:57 +0000787
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000788 Note: The carriage return (LF or CR) is stripped off.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000789 """
maruel@chromium.org3410d912009-06-09 20:56:16 +0000790 files = self.AffectedSourceFiles(source_file_filter)
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000791 return _RightHandSideLinesImpl(files)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000792
maruel@chromium.orge3608df2009-11-10 20:22:57 +0000793 def ReadFile(self, file_item, mode='r'):
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000794 """Reads an arbitrary file.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000795
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000796 Deny reading anything outside the repository.
797 """
maruel@chromium.orge3608df2009-11-10 20:22:57 +0000798 if isinstance(file_item, AffectedFile):
799 file_item = file_item.AbsoluteLocalPath()
800 if not file_item.startswith(self.change.RepositoryRoot()):
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000801 raise IOError('Access outside the repository root is denied.')
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +0000802 return gclient_utils.FileRead(file_item, mode)
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000803
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +0100804 def CreateTemporaryFile(self, **kwargs):
805 """Returns a named temporary file that must be removed with a call to
806 RemoveTemporaryFiles().
807
808 All keyword arguments are forwarded to tempfile.NamedTemporaryFile(),
809 except for |delete|, which is always set to False.
810
811 Presubmit checks that need to create a temporary file and pass it for
812 reading should use this function instead of NamedTemporaryFile(), as
813 Windows fails to open a file that is already open for writing.
814
815 with input_api.CreateTemporaryFile() as f:
816 f.write('xyz')
817 f.close()
818 input_api.subprocess.check_output(['script-that', '--reads-from',
819 f.name])
820
821
822 Note that callers of CreateTemporaryFile() should not worry about removing
823 any temporary file; this is done transparently by the presubmit handling
824 code.
825 """
826 if 'delete' in kwargs:
827 # Prevent users from passing |delete|; we take care of file deletion
828 # ourselves and this prevents unintuitive error messages when we pass
829 # delete=False and 'delete' is also in kwargs.
830 raise TypeError('CreateTemporaryFile() does not take a "delete" '
831 'argument, file deletion is handled automatically by '
832 'the same presubmit_support code that creates InputApi '
833 'objects.')
834 temp_file = self.tempfile.NamedTemporaryFile(delete=False, **kwargs)
835 self._named_temporary_files.append(temp_file.name)
836 return temp_file
837
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000838 @property
839 def tbr(self):
840 """Returns if a change is TBR'ed."""
Jeremy Romandce22502017-06-20 15:37:29 -0400841 return 'TBR' in self.change.tags or self.change.TBRsFromDescription()
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000842
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +0000843 def RunTests(self, tests_mix, parallel=True):
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000844 tests = []
845 msgs = []
846 for t in tests_mix:
Edward Lesmes8e282792018-04-03 18:50:29 -0400847 if isinstance(t, OutputApi.PresubmitResult) and t:
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000848 msgs.append(t)
849 else:
850 assert issubclass(t.message, _PresubmitResult)
851 tests.append(t)
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +0000852 if self.verbose:
853 t.info = _PresubmitNotifyResult
Edward Lemur1037c742018-05-01 18:56:04 -0400854 if not t.kwargs.get('cwd'):
855 t.kwargs['cwd'] = self.PresubmitLocalPath()
Edward Lesmes8e282792018-04-03 18:50:29 -0400856 self.thread_pool.AddTests(tests, parallel)
Edward Lemur21000eb2019-05-24 23:25:58 +0000857 # When self.parallel is True (i.e. --parallel is passed as an option)
858 # RunTests doesn't actually run tests. It adds them to a ThreadPool that
859 # will run all tests once all PRESUBMIT files are processed.
860 # Otherwise, it will run them and return the results.
861 if not self.parallel:
Edward Lesmes8e282792018-04-03 18:50:29 -0400862 msgs.extend(self.thread_pool.RunAsync())
863 return msgs
scottmg86099d72016-09-01 09:16:51 -0700864
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000865
nick@chromium.orgff526192013-06-10 19:30:26 +0000866class _DiffCache(object):
867 """Caches diffs retrieved from a particular SCM."""
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000868 def __init__(self, upstream=None):
869 """Stores the upstream revision against which all diffs will be computed."""
870 self._upstream = upstream
nick@chromium.orgff526192013-06-10 19:30:26 +0000871
872 def GetDiff(self, path, local_root):
873 """Get the diff for a particular path."""
874 raise NotImplementedError()
875
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700876 def GetOldContents(self, path, local_root):
877 """Get the old version for a particular path."""
878 raise NotImplementedError()
879
nick@chromium.orgff526192013-06-10 19:30:26 +0000880
nick@chromium.orgff526192013-06-10 19:30:26 +0000881class _GitDiffCache(_DiffCache):
882 """DiffCache implementation for git; gets all file diffs at once."""
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000883 def __init__(self, upstream):
884 super(_GitDiffCache, self).__init__(upstream=upstream)
nick@chromium.orgff526192013-06-10 19:30:26 +0000885 self._diffs_by_file = None
886
887 def GetDiff(self, path, local_root):
888 if not self._diffs_by_file:
889 # Compute a single diff for all files and parse the output; should
890 # with git this is much faster than computing one diff for each file.
891 diffs = {}
892
893 # Don't specify any filenames below, because there are command line length
894 # limits on some platforms and GenerateDiff would fail.
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000895 unified_diff = scm.GIT.GenerateDiff(local_root, files=[], full_move=True,
896 branch=self._upstream)
nick@chromium.orgff526192013-06-10 19:30:26 +0000897
898 # This regex matches the path twice, separated by a space. Note that
899 # filename itself may contain spaces.
900 file_marker = re.compile('^diff --git (?P<filename>.*) (?P=filename)$')
901 current_diff = []
902 keep_line_endings = True
903 for x in unified_diff.splitlines(keep_line_endings):
904 match = file_marker.match(x)
905 if match:
906 # Marks the start of a new per-file section.
907 diffs[match.group('filename')] = current_diff = [x]
908 elif x.startswith('diff --git'):
909 raise PresubmitFailure('Unexpected diff line: %s' % x)
910 else:
911 current_diff.append(x)
912
913 self._diffs_by_file = dict(
914 (normpath(path), ''.join(diff)) for path, diff in diffs.items())
915
916 if path not in self._diffs_by_file:
917 raise PresubmitFailure(
918 'Unified diff did not contain entry for file %s' % path)
919
920 return self._diffs_by_file[path]
921
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700922 def GetOldContents(self, path, local_root):
923 return scm.GIT.GetOldContents(local_root, path, branch=self._upstream)
924
nick@chromium.orgff526192013-06-10 19:30:26 +0000925
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000926class AffectedFile(object):
927 """Representation of a file in a change."""
nick@chromium.orgff526192013-06-10 19:30:26 +0000928
929 DIFF_CACHE = _DiffCache
930
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000931 # Method could be a function
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800932 # pylint: disable=no-self-use
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000933 def __init__(self, path, action, repository_root, diff_cache):
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000934 self._path = path
935 self._action = action
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000936 self._local_root = repository_root
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000937 self._is_directory = None
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000938 self._cached_changed_contents = None
939 self._cached_new_contents = None
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000940 self._diff_cache = diff_cache
tobiasjs2836bcf2016-08-16 04:08:16 -0700941 logging.debug('%s(%s)', self.__class__.__name__, self._path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000942
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000943 def LocalPath(self):
944 """Returns the path of this file on the local disk relative to client root.
Andrew Grieve92b8b992017-11-02 09:42:24 -0400945
946 This should be used for error messages but not for accessing files,
947 because presubmit checks are run with CWD=PresubmitLocalPath() (which is
948 often != client root).
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000949 """
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000950 return normpath(self._path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000951
952 def AbsoluteLocalPath(self):
953 """Returns the absolute path of this file on the local disk.
954 """
chase@chromium.org8e416c82009-10-06 04:30:44 +0000955 return os.path.abspath(os.path.join(self._local_root, self.LocalPath()))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000956
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000957 def Action(self):
958 """Returns the action on this opened file, e.g. A, M, D, etc."""
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000959 return self._action
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000960
agable0b65e732016-11-22 09:25:46 -0800961 def IsTestableFile(self):
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000962 """Returns True if the file is a text file and not a binary file.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000963
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000964 Deleted files are not text file."""
maruel@chromium.org1e08c002009-05-28 19:09:33 +0000965 raise NotImplementedError() # Implement when needed
966
agable0b65e732016-11-22 09:25:46 -0800967 def IsTextFile(self):
968 """An alias to IsTestableFile for backwards compatibility."""
969 return self.IsTestableFile()
970
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700971 def OldContents(self):
972 """Returns an iterator over the lines in the old version of file.
973
Daniel Cheng2da34fe2017-03-21 20:42:12 -0700974 The old version is the file before any modifications in the user's
Edward Lemura5799e32020-01-17 19:26:51 +0000975 workspace, i.e. the 'left hand side'.
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700976
977 Contents will be empty if the file is a directory or does not exist.
978 Note: The carriage returns (LF or CR) are stripped off.
979 """
980 return self._diff_cache.GetOldContents(self.LocalPath(),
981 self._local_root).splitlines()
982
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000983 def NewContents(self):
984 """Returns an iterator over the lines in the new version of file.
985
Edward Lemura5799e32020-01-17 19:26:51 +0000986 The new version is the file in the user's workspace, i.e. the 'right hand
987 side'.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000988
989 Contents will be empty if the file is a directory or does not exist.
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000990 Note: The carriage returns (LF or CR) are stripped off.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000991 """
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000992 if self._cached_new_contents is None:
993 self._cached_new_contents = []
agable0b65e732016-11-22 09:25:46 -0800994 try:
995 self._cached_new_contents = gclient_utils.FileRead(
996 self.AbsoluteLocalPath(), 'rU').splitlines()
997 except IOError:
998 pass # File not found? That's fine; maybe it was deleted.
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000999 return self._cached_new_contents[:]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001000
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001001 def ChangedContents(self):
1002 """Returns a list of tuples (line number, line text) of all new lines.
1003
1004 This relies on the scm diff output describing each changed code section
1005 with a line of the form
1006
1007 ^@@ <old line num>,<old size> <new line num>,<new size> @@$
1008 """
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +00001009 if self._cached_changed_contents is not None:
1010 return self._cached_changed_contents[:]
1011 self._cached_changed_contents = []
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001012 line_num = 0
1013
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001014 for line in self.GenerateScmDiff().splitlines():
Edward Lemurac5c55f2020-02-29 00:17:16 +00001015 m = re.match(r'^@@ [0-9\,\+\-]+ \+([0-9]+)\,[0-9]+ @@', line)
1016 if m:
1017 line_num = int(m.groups(1)[0])
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001018 continue
1019 if line.startswith('+') and not line.startswith('++'):
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +00001020 self._cached_changed_contents.append((line_num, line[1:]))
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001021 if not line.startswith('-'):
1022 line_num += 1
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +00001023 return self._cached_changed_contents[:]
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001024
maruel@chromium.org5de13972009-06-10 18:16:06 +00001025 def __str__(self):
1026 return self.LocalPath()
1027
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001028 def GenerateScmDiff(self):
nick@chromium.orgff526192013-06-10 19:30:26 +00001029 return self._diff_cache.GetDiff(self.LocalPath(), self._local_root)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001030
maruel@chromium.org58407af2011-04-12 23:15:57 +00001031
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001032class GitAffectedFile(AffectedFile):
1033 """Representation of a file in a change out of a git checkout."""
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +00001034 # Method 'NNN' is abstract in class 'NNN' but is not overridden
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -08001035 # pylint: disable=abstract-method
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001036
nick@chromium.orgff526192013-06-10 19:30:26 +00001037 DIFF_CACHE = _GitDiffCache
1038
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001039 def __init__(self, *args, **kwargs):
1040 AffectedFile.__init__(self, *args, **kwargs)
1041 self._server_path = None
agable0b65e732016-11-22 09:25:46 -08001042 self._is_testable_file = None
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001043
agable0b65e732016-11-22 09:25:46 -08001044 def IsTestableFile(self):
1045 if self._is_testable_file is None:
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001046 if self.Action() == 'D':
agable0b65e732016-11-22 09:25:46 -08001047 # A deleted file is not testable.
1048 self._is_testable_file = False
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001049 else:
agable0b65e732016-11-22 09:25:46 -08001050 self._is_testable_file = os.path.isfile(self.AbsoluteLocalPath())
1051 return self._is_testable_file
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001052
maruel@chromium.orgc1938752011-04-12 23:11:13 +00001053
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001054class Change(object):
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001055 """Describe a change.
1056
1057 Used directly by the presubmit scripts to query the current change being
1058 tested.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +00001059
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001060 Instance members:
nick@chromium.orgff526192013-06-10 19:30:26 +00001061 tags: Dictionary of KEY=VALUE pairs found in the change description.
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001062 self.KEY: equivalent to tags['KEY']
1063 """
1064
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001065 _AFFECTED_FILES = AffectedFile
1066
Edward Lemura5799e32020-01-17 19:26:51 +00001067 # Matches key/value (or 'tag') lines in changelist descriptions.
maruel@chromium.org428342a2011-11-10 15:46:33 +00001068 TAG_LINE_RE = re.compile(
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001069 '^[ \t]*(?P<key>[A-Z][A-Z_0-9]*)[ \t]*=[ \t]*(?P<value>.*?)[ \t]*$')
maruel@chromium.orgc1938752011-04-12 23:11:13 +00001070 scm = ''
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001071
maruel@chromium.org58407af2011-04-12 23:15:57 +00001072 def __init__(
agable@chromium.orgea84ef12014-04-30 19:55:12 +00001073 self, name, description, local_root, files, issue, patchset, author,
1074 upstream=None):
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001075 if files is None:
1076 files = []
1077 self._name = name
chase@chromium.org8e416c82009-10-06 04:30:44 +00001078 # Convert root into an absolute path.
1079 self._local_root = os.path.abspath(local_root)
agable@chromium.orgea84ef12014-04-30 19:55:12 +00001080 self._upstream = upstream
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001081 self.issue = issue
1082 self.patchset = patchset
maruel@chromium.org58407af2011-04-12 23:15:57 +00001083 self.author_email = author
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001084
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001085 self._full_description = ''
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001086 self.tags = {}
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001087 self._description_without_tags = ''
1088 self.SetDescriptionText(description)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001089
maruel@chromium.orge085d812011-10-10 19:49:15 +00001090 assert all(
1091 (isinstance(f, (list, tuple)) and len(f) == 2) for f in files), files
1092
agable@chromium.orgea84ef12014-04-30 19:55:12 +00001093 diff_cache = self._AFFECTED_FILES.DIFF_CACHE(self._upstream)
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001094 self._affected_files = [
nick@chromium.orgff526192013-06-10 19:30:26 +00001095 self._AFFECTED_FILES(path, action.strip(), self._local_root, diff_cache)
1096 for action, path in files
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +00001097 ]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001098
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001099 def Name(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001100 """Returns the change name."""
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001101 return self._name
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001102
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001103 def DescriptionText(self):
1104 """Returns the user-entered changelist description, minus tags.
1105
Edward Lemura5799e32020-01-17 19:26:51 +00001106 Any line in the user-provided description starting with e.g. 'FOO='
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001107 (whitespace permitted before and around) is considered a tag line. Such
1108 lines are stripped out of the description this function returns.
1109 """
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001110 return self._description_without_tags
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001111
1112 def FullDescriptionText(self):
1113 """Returns the complete changelist description including tags."""
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001114 return self._full_description
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001115
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001116 def SetDescriptionText(self, description):
1117 """Sets the full description text (including tags) to |description|.
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001118
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001119 Also updates the list of tags."""
1120 self._full_description = description
1121
1122 # From the description text, build up a dictionary of key/value pairs
Edward Lemura5799e32020-01-17 19:26:51 +00001123 # plus the description minus all key/value or 'tag' lines.
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001124 description_without_tags = []
1125 self.tags = {}
1126 for line in self._full_description.splitlines():
1127 m = self.TAG_LINE_RE.match(line)
1128 if m:
1129 self.tags[m.group('key')] = m.group('value')
1130 else:
1131 description_without_tags.append(line)
1132
1133 # Change back to text and remove whitespace at end.
1134 self._description_without_tags = (
1135 '\n'.join(description_without_tags).rstrip())
1136
Edward Lemur69bb8be2020-02-03 20:37:38 +00001137 def AddDescriptionFooter(self, key, value):
1138 """Adds the given footer to the change description.
1139
1140 Args:
1141 key: A string with the key for the git footer. It must conform to
1142 the git footers format (i.e. 'List-Of-Tokens') and will be case
1143 normalized so that each token is title-cased.
1144 value: A string with the value for the git footer.
1145 """
1146 description = git_footers.add_footer(
1147 self.FullDescriptionText(), git_footers.normalize_name(key), value)
1148 self.SetDescriptionText(description)
1149
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001150 def RepositoryRoot(self):
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001151 """Returns the repository (checkout) root directory for this change,
1152 as an absolute path.
1153 """
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001154 return self._local_root
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001155
1156 def __getattr__(self, attr):
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001157 """Return tags directly as attributes on the object."""
Edward Lemura5799e32020-01-17 19:26:51 +00001158 if not re.match(r'^[A-Z_]*$', attr):
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001159 raise AttributeError(self, attr)
maruel@chromium.orge1a524f2009-05-27 14:43:46 +00001160 return self.tags.get(attr)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001161
Edward Lemur69bb8be2020-02-03 20:37:38 +00001162 def GitFootersFromDescription(self):
1163 """Return the git footers present in the description.
1164
1165 Returns:
1166 footers: A dict of {footer: [values]} containing a multimap of the footers
1167 in the change description.
1168 """
1169 return git_footers.parse_footers(self.FullDescriptionText())
1170
Aaron Gablefc03e672017-05-15 14:09:42 -07001171 def BugsFromDescription(self):
1172 """Returns all bugs referenced in the commit description."""
Aaron Gable12ef5012017-05-15 14:29:00 -07001173 tags = [b.strip() for b in self.tags.get('BUG', '').split(',') if b.strip()]
Caleb Rouleauc0546b92019-02-22 06:12:57 +00001174 footers = []
Edward Lemur69bb8be2020-02-03 20:37:38 +00001175 parsed = self.GitFootersFromDescription()
Dan Beam62954042019-10-03 21:20:33 +00001176 unsplit_footers = parsed.get('Bug', []) + parsed.get('Fixed', [])
Caleb Rouleauc0546b92019-02-22 06:12:57 +00001177 for unsplit_footer in unsplit_footers:
1178 footers += [b.strip() for b in unsplit_footer.split(',')]
Aaron Gable12ef5012017-05-15 14:29:00 -07001179 return sorted(set(tags + footers))
Aaron Gablefc03e672017-05-15 14:09:42 -07001180
1181 def ReviewersFromDescription(self):
1182 """Returns all reviewers listed in the commit description."""
Edward Lemura5799e32020-01-17 19:26:51 +00001183 # We don't support a 'R:' git-footer for reviewers; that is in metadata.
Aaron Gable12ef5012017-05-15 14:29:00 -07001184 tags = [r.strip() for r in self.tags.get('R', '').split(',') if r.strip()]
1185 return sorted(set(tags))
Aaron Gablefc03e672017-05-15 14:09:42 -07001186
1187 def TBRsFromDescription(self):
1188 """Returns all TBR reviewers listed in the commit description."""
Aaron Gable12ef5012017-05-15 14:29:00 -07001189 tags = [r.strip() for r in self.tags.get('TBR', '').split(',') if r.strip()]
Aaron Gable6e7ddb62020-05-27 22:23:29 +00001190 # TODO(crbug.com/839208): Remove support for 'Tbr:' when TBRs are
1191 # programmatically determined by self-CR+1s.
Edward Lemur69bb8be2020-02-03 20:37:38 +00001192 footers = self.GitFootersFromDescription().get('Tbr', [])
Aaron Gable12ef5012017-05-15 14:29:00 -07001193 return sorted(set(tags + footers))
Aaron Gablefc03e672017-05-15 14:09:42 -07001194
Aaron Gable6e7ddb62020-05-27 22:23:29 +00001195 # TODO(crbug.com/753425): Delete these once we're sure they're unused.
Aaron Gablefc03e672017-05-15 14:09:42 -07001196 @property
1197 def BUG(self):
1198 return ','.join(self.BugsFromDescription())
1199 @property
1200 def R(self):
1201 return ','.join(self.ReviewersFromDescription())
1202 @property
1203 def TBR(self):
1204 return ','.join(self.TBRsFromDescription())
1205
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001206 def AllFiles(self, root=None):
1207 """List all files under source control in the repo."""
1208 raise NotImplementedError()
1209
agable0b65e732016-11-22 09:25:46 -08001210 def AffectedFiles(self, include_deletes=True, file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001211 """Returns a list of AffectedFile instances for all files in the change.
1212
1213 Args:
1214 include_deletes: If false, deleted files will be filtered out.
sail@chromium.org5538e022011-05-12 17:53:16 +00001215 file_filter: An additional filter to apply.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001216
1217 Returns:
1218 [AffectedFile(path, action), AffectedFile(path, action)]
1219 """
Edward Lemurb9830242019-10-30 22:19:20 +00001220 affected = list(filter(file_filter, self._affected_files))
sail@chromium.org5538e022011-05-12 17:53:16 +00001221
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001222 if include_deletes:
1223 return affected
Edward Lemurb9830242019-10-30 22:19:20 +00001224 return list(filter(lambda x: x.Action() != 'D', affected))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001225
John Budorick16162372018-04-18 10:39:53 -07001226 def AffectedTestableFiles(self, include_deletes=None, **kwargs):
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +00001227 """Return a list of the existing text files in a change."""
1228 if include_deletes is not None:
Edward Lemura5799e32020-01-17 19:26:51 +00001229 warn('AffectedTeestableFiles(include_deletes=%s)'
1230 ' is deprecated and ignored' % str(include_deletes),
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +00001231 category=DeprecationWarning,
1232 stacklevel=2)
Edward Lemurb9830242019-10-30 22:19:20 +00001233 return list(filter(
1234 lambda x: x.IsTestableFile(),
1235 self.AffectedFiles(include_deletes=False, **kwargs)))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001236
agable0b65e732016-11-22 09:25:46 -08001237 def AffectedTextFiles(self, include_deletes=None):
1238 """An alias to AffectedTestableFiles for backwards compatibility."""
1239 return self.AffectedTestableFiles(include_deletes=include_deletes)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001240
agable0b65e732016-11-22 09:25:46 -08001241 def LocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001242 """Convenience function."""
agable0b65e732016-11-22 09:25:46 -08001243 return [af.LocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001244
agable0b65e732016-11-22 09:25:46 -08001245 def AbsoluteLocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001246 """Convenience function."""
agable0b65e732016-11-22 09:25:46 -08001247 return [af.AbsoluteLocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001248
1249 def RightHandSideLines(self):
Edward Lemura5799e32020-01-17 19:26:51 +00001250 """An iterator over all text lines in 'new' version of changed files.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001251
1252 Lists lines from new or modified text files in the change.
1253
1254 This is useful for doing line-by-line regex checks, like checking for
1255 trailing whitespace.
1256
1257 Yields:
1258 a 3 tuple:
1259 the AffectedFile instance of the current file;
1260 integer line number (1-based); and
1261 the contents of the line as a string.
1262 """
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +00001263 return _RightHandSideLinesImpl(
1264 x for x in self.AffectedFiles(include_deletes=False)
agable0b65e732016-11-22 09:25:46 -08001265 if x.IsTestableFile())
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001266
Jochen Eisingerd0573ec2017-04-13 10:55:06 +02001267 def OriginalOwnersFiles(self):
1268 """A map from path names of affected OWNERS files to their old content."""
1269 def owners_file_filter(f):
1270 return 'OWNERS' in os.path.split(f.LocalPath())[1]
1271 files = self.AffectedFiles(file_filter=owners_file_filter)
1272 return dict([(f.LocalPath(), f.OldContents()) for f in files])
1273
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001274
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001275class GitChange(Change):
1276 _AFFECTED_FILES = GitAffectedFile
maruel@chromium.orgc1938752011-04-12 23:11:13 +00001277 scm = 'git'
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +00001278
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001279 def AllFiles(self, root=None):
1280 """List all files under source control in the repo."""
1281 root = root or self.RepositoryRoot()
1282 return subprocess.check_output(
Aaron Gable7817f022017-12-12 09:43:17 -08001283 ['git', '-c', 'core.quotePath=false', 'ls-files', '--', '.'],
1284 cwd=root).splitlines()
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001285
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001286
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001287def ListRelevantPresubmitFiles(files, root):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001288 """Finds all presubmit files that apply to a given set of source files.
1289
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001290 If inherit-review-settings-ok is present right under root, looks for
1291 PRESUBMIT.py in directories enclosing root.
1292
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001293 Args:
1294 files: An iterable container containing file paths.
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001295 root: Path where to stop searching.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001296
1297 Return:
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001298 List of absolute paths of the existing PRESUBMIT.py scripts.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001299 """
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001300 files = [normpath(os.path.join(root, f)) for f in files]
1301
1302 # List all the individual directories containing files.
1303 directories = set([os.path.dirname(f) for f in files])
1304
1305 # Ignore root if inherit-review-settings-ok is present.
1306 if os.path.isfile(os.path.join(root, 'inherit-review-settings-ok')):
1307 root = None
1308
1309 # Collect all unique directories that may contain PRESUBMIT.py.
1310 candidates = set()
1311 for directory in directories:
1312 while True:
1313 if directory in candidates:
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001314 break
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001315 candidates.add(directory)
1316 if directory == root:
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001317 break
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001318 parent_dir = os.path.dirname(directory)
1319 if parent_dir == directory:
1320 # We hit the system root directory.
1321 break
1322 directory = parent_dir
1323
1324 # Look for PRESUBMIT.py in all candidate directories.
1325 results = []
1326 for directory in sorted(list(candidates)):
tobiasjsff061c02016-08-17 03:23:57 -07001327 try:
1328 for f in os.listdir(directory):
1329 p = os.path.join(directory, f)
1330 if os.path.isfile(p) and re.match(
1331 r'PRESUBMIT.*\.py$', f) and not f.startswith('PRESUBMIT_test'):
1332 results.append(p)
1333 except OSError:
1334 pass
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001335
tobiasjs2836bcf2016-08-16 04:08:16 -07001336 logging.debug('Presubmit files: %s', ','.join(results))
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001337 return results
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001338
1339
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001340class GetTryMastersExecuter(object):
1341 @staticmethod
1342 def ExecPresubmitScript(script_text, presubmit_path, project, change):
1343 """Executes GetPreferredTryMasters() from a single presubmit script.
1344
1345 Args:
1346 script_text: The text of the presubmit script.
1347 presubmit_path: Project script to run.
1348 project: Project name to pass to presubmit script for bot selection.
1349
1350 Return:
1351 A map of try masters to map of builders to set of tests.
1352 """
1353 context = {}
1354 try:
Raul Tambre09e64b42019-05-14 01:57:22 +00001355 exec(compile(script_text, 'PRESUBMIT.py', 'exec', dont_inherit=True),
1356 context)
Raul Tambre7c938462019-05-24 16:35:35 +00001357 except Exception as e:
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001358 raise PresubmitFailure('"%s" had an exception.\n%s'
1359 % (presubmit_path, e))
1360
1361 function_name = 'GetPreferredTryMasters'
1362 if function_name not in context:
1363 return {}
1364 get_preferred_try_masters = context[function_name]
1365 if not len(inspect.getargspec(get_preferred_try_masters)[0]) == 2:
1366 raise PresubmitFailure(
1367 'Expected function "GetPreferredTryMasters" to take two arguments.')
1368 return get_preferred_try_masters(project, change)
1369
1370
rmistry@google.com5626a922015-02-26 14:03:30 +00001371class GetPostUploadExecuter(object):
1372 @staticmethod
Edward Lemur016a0872020-02-04 22:13:28 +00001373 def ExecPresubmitScript(script_text, presubmit_path, gerrit_obj, change):
rmistry@google.com5626a922015-02-26 14:03:30 +00001374 """Executes PostUploadHook() from a single presubmit script.
1375
1376 Args:
1377 script_text: The text of the presubmit script.
1378 presubmit_path: Project script to run.
Edward Lemur016a0872020-02-04 22:13:28 +00001379 gerrit_obj: The GerritAccessor object.
rmistry@google.com5626a922015-02-26 14:03:30 +00001380 change: The Change object.
1381
1382 Return:
1383 A list of results objects.
1384 """
1385 context = {}
1386 try:
Raul Tambre09e64b42019-05-14 01:57:22 +00001387 exec(compile(script_text, 'PRESUBMIT.py', 'exec', dont_inherit=True),
1388 context)
Raul Tambre7c938462019-05-24 16:35:35 +00001389 except Exception as e:
rmistry@google.com5626a922015-02-26 14:03:30 +00001390 raise PresubmitFailure('"%s" had an exception.\n%s'
1391 % (presubmit_path, e))
1392
1393 function_name = 'PostUploadHook'
1394 if function_name not in context:
1395 return {}
1396 post_upload_hook = context[function_name]
1397 if not len(inspect.getargspec(post_upload_hook)[0]) == 3:
1398 raise PresubmitFailure(
1399 'Expected function "PostUploadHook" to take three arguments.')
Edward Lemur016a0872020-02-04 22:13:28 +00001400 return post_upload_hook(gerrit_obj, change, OutputApi(False))
rmistry@google.com5626a922015-02-26 14:03:30 +00001401
1402
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001403def _MergeMasters(masters1, masters2):
1404 """Merges two master maps. Merges also the tests of each builder."""
1405 result = {}
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001406 for (master, builders) in itertools.chain(masters1.items(),
1407 masters2.items()):
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001408 new_builders = result.setdefault(master, {})
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001409 for (builder, tests) in builders.items():
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001410 new_builders.setdefault(builder, set([])).update(tests)
1411 return result
1412
1413
1414def DoGetTryMasters(change,
1415 changed_files,
1416 repository_root,
1417 default_presubmit,
1418 project,
1419 verbose,
1420 output_stream):
1421 """Get the list of try masters from the presubmit scripts.
1422
1423 Args:
1424 changed_files: List of modified files.
1425 repository_root: The repository root.
1426 default_presubmit: A default presubmit script to execute in any case.
1427 project: Optional name of a project used in selecting trybots.
1428 verbose: Prints debug info.
1429 output_stream: A stream to write debug output to.
1430
1431 Return:
1432 Map of try masters to map of builders to set of tests.
1433 """
1434 presubmit_files = ListRelevantPresubmitFiles(changed_files, repository_root)
1435 if not presubmit_files and verbose:
Edward Lemura5799e32020-01-17 19:26:51 +00001436 output_stream.write('Warning, no PRESUBMIT.py found.\n')
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001437 results = {}
1438 executer = GetTryMastersExecuter()
1439
1440 if default_presubmit:
1441 if verbose:
Edward Lemura5799e32020-01-17 19:26:51 +00001442 output_stream.write('Running default presubmit script.\n')
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001443 fake_path = os.path.join(repository_root, 'PRESUBMIT.py')
1444 results = _MergeMasters(results, executer.ExecPresubmitScript(
1445 default_presubmit, fake_path, project, change))
1446 for filename in presubmit_files:
1447 filename = os.path.abspath(filename)
1448 if verbose:
Edward Lemura5799e32020-01-17 19:26:51 +00001449 output_stream.write('Running %s\n' % filename)
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001450 # Accept CRLF presubmit script.
1451 presubmit_script = gclient_utils.FileRead(filename, 'rU')
1452 results = _MergeMasters(results, executer.ExecPresubmitScript(
1453 presubmit_script, filename, project, change))
1454
1455 # Make sets to lists again for later JSON serialization.
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001456 for builders in results.values():
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001457 for builder in builders:
1458 builders[builder] = list(builders[builder])
1459
1460 if results and verbose:
1461 output_stream.write('%s\n' % str(results))
1462 return results
1463
1464
rmistry@google.com5626a922015-02-26 14:03:30 +00001465def DoPostUploadExecuter(change,
Edward Lemur016a0872020-02-04 22:13:28 +00001466 gerrit_obj,
Edward Lemur6eb1d322020-02-27 22:20:15 +00001467 verbose):
rmistry@google.com5626a922015-02-26 14:03:30 +00001468 """Execute the post upload hook.
1469
1470 Args:
1471 change: The Change object.
Edward Lemur016a0872020-02-04 22:13:28 +00001472 gerrit_obj: The GerritAccessor object.
rmistry@google.com5626a922015-02-26 14:03:30 +00001473 verbose: Prints debug info.
rmistry@google.com5626a922015-02-26 14:03:30 +00001474 """
1475 presubmit_files = ListRelevantPresubmitFiles(
Edward Lemur6eb1d322020-02-27 22:20:15 +00001476 change.LocalPaths(), change.RepositoryRoot())
rmistry@google.com5626a922015-02-26 14:03:30 +00001477 if not presubmit_files and verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001478 sys.stdout.write('Warning, no PRESUBMIT.py found.\n')
rmistry@google.com5626a922015-02-26 14:03:30 +00001479 results = []
1480 executer = GetPostUploadExecuter()
1481 # The root presubmit file should be executed after the ones in subdirectories.
1482 # i.e. the specific post upload hooks should run before the general ones.
1483 # Thus, reverse the order provided by ListRelevantPresubmitFiles.
1484 presubmit_files.reverse()
1485
1486 for filename in presubmit_files:
1487 filename = os.path.abspath(filename)
1488 if verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001489 sys.stdout.write('Running %s\n' % filename)
rmistry@google.com5626a922015-02-26 14:03:30 +00001490 # Accept CRLF presubmit script.
1491 presubmit_script = gclient_utils.FileRead(filename, 'rU')
1492 results.extend(executer.ExecPresubmitScript(
Edward Lemur016a0872020-02-04 22:13:28 +00001493 presubmit_script, filename, gerrit_obj, change))
rmistry@google.com5626a922015-02-26 14:03:30 +00001494
Edward Lemur6eb1d322020-02-27 22:20:15 +00001495 if not results:
1496 return 0
1497
1498 sys.stdout.write('\n')
1499 sys.stdout.write('** Post Upload Hook Messages **\n')
1500
1501 exit_code = 0
1502 for result in results:
1503 if result.fatal:
1504 exit_code = 1
1505 result.handle()
1506 sys.stdout.write('\n')
1507
1508 return exit_code
rmistry@google.com5626a922015-02-26 14:03:30 +00001509
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001510class PresubmitExecuter(object):
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001511 def __init__(self, change, committing, verbose, gerrit_obj, dry_run=None,
1512 thread_pool=None, parallel=False, gerrit_project=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001513 """
1514 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001515 change: The Change object.
agable92bec4f2016-08-24 09:27:27 -07001516 committing: True if 'git cl land' is running, False if 'git cl upload' is.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001517 gerrit_obj: provides basic Gerrit codereview functionality.
1518 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -04001519 parallel: if true, all tests reported via input_api.RunTests for all
1520 PRESUBMIT files will be run in parallel.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001521 """
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001522 self.change = change
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001523 self.committing = committing
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001524 self.gerrit = gerrit_obj
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001525 self.verbose = verbose
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001526 self.dry_run = dry_run
Daniel Cheng7227d212017-11-17 08:12:37 -08001527 self.more_cc = []
Edward Lesmes8e282792018-04-03 18:50:29 -04001528 self.thread_pool = thread_pool
1529 self.parallel = parallel
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001530 self.gerrit_project = gerrit_project
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001531
1532 def ExecPresubmitScript(self, script_text, presubmit_path):
1533 """Executes a single presubmit script.
1534
1535 Args:
1536 script_text: The text of the presubmit script.
1537 presubmit_path: The path to the presubmit file (this will be reported via
1538 input_api.PresubmitLocalPath()).
1539
1540 Return:
1541 A list of result objects, empty if no problems.
1542 """
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001543
chase@chromium.org8e416c82009-10-06 04:30:44 +00001544 # Change to the presubmit file's directory to support local imports.
1545 main_path = os.getcwd()
Saagar Sanghavi98b332f2020-07-31 17:19:15 +00001546 presubmit_dir = os.path.dirname(presubmit_path)
1547 os.chdir(presubmit_dir)
chase@chromium.org8e416c82009-10-06 04:30:44 +00001548
1549 # Load the presubmit script into context.
dpranke@chromium.org970c5222011-03-12 00:32:24 +00001550 input_api = InputApi(self.change, presubmit_path, self.committing,
Aaron Gable668c1d82018-04-03 10:19:16 -07001551 self.verbose, gerrit_obj=self.gerrit,
Edward Lesmes8e282792018-04-03 18:50:29 -04001552 dry_run=self.dry_run, thread_pool=self.thread_pool,
1553 parallel=self.parallel)
Daniel Cheng7227d212017-11-17 08:12:37 -08001554 output_api = OutputApi(self.committing)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001555 context = {}
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001556
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001557 try:
Raul Tambre09e64b42019-05-14 01:57:22 +00001558 exec(compile(script_text, 'PRESUBMIT.py', 'exec', dont_inherit=True),
1559 context)
Raul Tambre7c938462019-05-24 16:35:35 +00001560 except Exception as e:
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001561 raise PresubmitFailure('"%s" had an exception.\n%s' % (presubmit_path, e))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001562
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001563 context['__args'] = (input_api, output_api)
Ben Pastene8351dc12020-08-06 05:01:35 +00001564
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001565 # Get path of presubmit directory relative to repository root.
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001566 # Always use forward slashes, so that path is same in *nix and Windows
1567 root = input_api.change.RepositoryRoot()
1568 rel_path = os.path.relpath(presubmit_dir, root)
1569 rel_path = rel_path.replace(os.path.sep, '/')
Ben Pastene8351dc12020-08-06 05:01:35 +00001570
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001571 # Get the URL of git remote origin and use it to identify host and project
1572 host = ''
1573 if self.gerrit and self.gerrit.host:
1574 host = self.gerrit.host
1575 project = self.gerrit_project or ''
1576
1577 # Prefix for test names
1578 prefix = 'presubmit:%s/%s:%s/' % (host, project, rel_path)
1579
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001580 # Perform all the desired presubmit checks.
1581 results = []
Ben Pastene8351dc12020-08-06 05:01:35 +00001582
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001583 try:
Scott Leecc2fe9b2020-11-19 19:38:06 +00001584 version = [
1585 int(x) for x in context.get('PRESUBMIT_VERSION', '0.0.0').split('.')
1586 ]
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001587
Scott Leecc2fe9b2020-11-19 19:38:06 +00001588 with rdb_wrapper.client(prefix) as sink:
1589 if version >= [2, 0, 0]:
1590 for function_name in context:
1591 if not function_name.startswith('Check'):
1592 continue
1593 if function_name.endswith('Commit') and not self.committing:
1594 continue
1595 if function_name.endswith('Upload') and self.committing:
1596 continue
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001597 logging.debug('Running %s in %s', function_name, presubmit_path)
1598 results.extend(
Scott Leecc2fe9b2020-11-19 19:38:06 +00001599 self._run_check_function(function_name, context, sink))
1600 logging.debug('Running %s done.', function_name)
1601 self.more_cc.extend(output_api.more_cc)
1602
1603 else: # Old format
1604 if self.committing:
1605 function_name = 'CheckChangeOnCommit'
1606 else:
1607 function_name = 'CheckChangeOnUpload'
1608 if function_name in context:
1609 logging.debug('Running %s in %s', function_name, presubmit_path)
1610 results.extend(
1611 self._run_check_function(function_name, context, sink))
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001612 logging.debug('Running %s done.', function_name)
1613 self.more_cc.extend(output_api.more_cc)
1614
1615 finally:
1616 for f in input_api._named_temporary_files:
1617 os.remove(f)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001618
chase@chromium.org8e416c82009-10-06 04:30:44 +00001619 # Return the process to the original working directory.
1620 os.chdir(main_path)
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001621 return results
1622
Scott Leecc2fe9b2020-11-19 19:38:06 +00001623 def _run_check_function(self, function_name, context, sink=None):
1624 """Evaluates and returns the result of a given presubmit function.
1625
1626 If sink is given, the result of the presubmit function will be reported
1627 to the ResultSink.
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001628
1629 Args:
Scott Leecc2fe9b2020-11-19 19:38:06 +00001630 function_name: the name of the presubmit function to evaluate
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001631 context: a context dictionary in which the function will be evaluated
Scott Leecc2fe9b2020-11-19 19:38:06 +00001632 sink: an instance of ResultSink. None, by default.
1633 Returns:
1634 the result of the presubmit function call.
1635 """
1636 start_time = time_time()
1637 try:
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001638 result = eval(function_name + '(*__args)', context)
1639 self._check_result_type(result)
Scott Leecc2fe9b2020-11-19 19:38:06 +00001640 except:
1641 if sink:
1642 elapsed_time = time_time() - start_time
1643 sink.report(function_name, rdb_wrapper.STATUS_FAIL, elapsed_time)
1644 raise
1645
1646 if sink:
1647 elapsed_time = time_time() - start_time
1648 status = rdb_wrapper.STATUS_PASS
1649 if any(r.fatal for r in result):
1650 status = rdb_wrapper.STATUS_FAIL
1651 sink.report(function_name, status, elapsed_time)
1652
1653 return result
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001654
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00001655 def _check_result_type(self, result):
1656 """Helper function which ensures result is a list, and all elements are
1657 instances of OutputApi.PresubmitResult"""
1658 if not isinstance(result, (tuple, list)):
1659 raise PresubmitFailure('Presubmit functions must return a tuple or list')
1660 if not all(isinstance(res, OutputApi.PresubmitResult) for res in result):
1661 raise PresubmitFailure(
1662 'All presubmit results must be of types derived from '
1663 'output_api.PresubmitResult')
1664
1665
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001666def DoPresubmitChecks(change,
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001667 committing,
1668 verbose,
maruel@chromium.orgb0dfd352009-06-10 14:12:54 +00001669 default_presubmit,
dpranke@chromium.org970c5222011-03-12 00:32:24 +00001670 may_prompt,
Aaron Gable668c1d82018-04-03 10:19:16 -07001671 gerrit_obj,
Edward Lesmes8e282792018-04-03 18:50:29 -04001672 dry_run=None,
Debrian Figueroadd2737e2019-06-21 23:50:13 +00001673 parallel=False,
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001674 json_output=None,
1675 gerrit_project=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001676 """Runs all presubmit checks that apply to the files in the change.
1677
1678 This finds all PRESUBMIT.py files in directories enclosing the files in the
1679 change (up to the repository root) and calls the relevant entrypoint function
1680 depending on whether the change is being committed or uploaded.
1681
1682 Prints errors, warnings and notifications. Prompts the user for warnings
1683 when needed.
1684
1685 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001686 change: The Change object.
agable92bec4f2016-08-24 09:27:27 -07001687 committing: True if 'git cl land' is running, False if 'git cl upload' is.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001688 verbose: Prints debug info.
maruel@chromium.org0ff1fab2009-05-22 13:08:15 +00001689 default_presubmit: A default presubmit script to execute in any case.
Quinten Yearsley516fe7f2016-12-14 11:50:18 -08001690 may_prompt: Enable (y/n) questions on warning or error. If False,
1691 any questions are answered with yes by default.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001692 gerrit_obj: provides basic Gerrit codereview functionality.
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001693 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -04001694 parallel: if true, all tests specified by input_api.RunTests in all
1695 PRESUBMIT files will be run in parallel.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001696
1697 Return:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001698 1 if presubmit checks failed or 0 otherwise.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001699 """
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001700 old_environ = os.environ
1701 try:
1702 # Make sure python subprocesses won't generate .pyc files.
1703 os.environ = os.environ.copy()
Edward Lemurb9830242019-10-30 22:19:20 +00001704 os.environ['PYTHONDONTWRITEBYTECODE'] = '1'
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001705
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001706 if committing:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001707 sys.stdout.write('Running presubmit commit checks ...\n')
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001708 else:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001709 sys.stdout.write('Running presubmit upload checks ...\n')
Edward Lemurecc27072020-01-06 16:42:34 +00001710 start_time = time_time()
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001711 presubmit_files = ListRelevantPresubmitFiles(
agable0b65e732016-11-22 09:25:46 -08001712 change.AbsoluteLocalPaths(), change.RepositoryRoot())
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001713 if not presubmit_files and verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001714 sys.stdout.write('Warning, no PRESUBMIT.py found.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001715 results = []
Edward Lesmes8e282792018-04-03 18:50:29 -04001716 thread_pool = ThreadPool()
Edward Lemur7e3c67f2018-07-20 20:52:49 +00001717 executer = PresubmitExecuter(change, committing, verbose, gerrit_obj,
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001718 dry_run, thread_pool, parallel, gerrit_project)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001719 if default_presubmit:
1720 if verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001721 sys.stdout.write('Running default presubmit script.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001722 fake_path = os.path.join(change.RepositoryRoot(), 'PRESUBMIT.py')
1723 results += executer.ExecPresubmitScript(default_presubmit, fake_path)
1724 for filename in presubmit_files:
1725 filename = os.path.abspath(filename)
1726 if verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001727 sys.stdout.write('Running %s\n' % filename)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001728 # Accept CRLF presubmit script.
1729 presubmit_script = gclient_utils.FileRead(filename, 'rU')
1730 results += executer.ExecPresubmitScript(presubmit_script, filename)
Edward Lesmes8e282792018-04-03 18:50:29 -04001731 results += thread_pool.RunAsync()
1732
Edward Lemur6eb1d322020-02-27 22:20:15 +00001733 messages = {}
1734 should_prompt = False
1735 presubmits_failed = False
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001736 for result in results:
1737 if result.fatal:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001738 presubmits_failed = True
1739 messages.setdefault('ERRORS', []).append(result)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001740 elif result.should_prompt:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001741 should_prompt = True
1742 messages.setdefault('Warnings', []).append(result)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001743 else:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001744 messages.setdefault('Messages', []).append(result)
pam@chromium.orged9a0832009-09-09 22:48:55 +00001745
Edward Lemur6eb1d322020-02-27 22:20:15 +00001746 sys.stdout.write('\n')
1747 for name, items in messages.items():
1748 sys.stdout.write('** Presubmit %s **\n' % name)
1749 for item in items:
1750 item.handle()
1751 sys.stdout.write('\n')
pam@chromium.orged9a0832009-09-09 22:48:55 +00001752
Edward Lemurecc27072020-01-06 16:42:34 +00001753 total_time = time_time() - start_time
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001754 if total_time > 1.0:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001755 sys.stdout.write(
1756 'Presubmit checks took %.1fs to calculate.\n\n' % total_time)
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +00001757
Edward Lemur6eb1d322020-02-27 22:20:15 +00001758 if not should_prompt and not presubmits_failed:
1759 sys.stdout.write('Presubmit checks passed.\n')
1760 elif should_prompt:
1761 sys.stdout.write('There were presubmit warnings. ')
Quinten Yearsley516fe7f2016-12-14 11:50:18 -08001762 if may_prompt:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001763 presubmits_failed = not prompt_should_continue(
1764 'Are you sure you wish to continue? (y/N): ')
Garrett Beatyacb807e2020-08-28 18:17:24 +00001765 else:
1766 sys.stdout.write('\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001767
Edward Lemur1dc66e12020-02-21 21:36:34 +00001768 if json_output:
1769 # Write the presubmit results to json output
1770 presubmit_results = {
1771 'errors': [
Edward Lemur6eb1d322020-02-27 22:20:15 +00001772 error.json_format()
1773 for error in messages.get('ERRORS', [])
Edward Lemur1dc66e12020-02-21 21:36:34 +00001774 ],
1775 'notifications': [
Edward Lemur6eb1d322020-02-27 22:20:15 +00001776 notification.json_format()
1777 for notification in messages.get('Messages', [])
Edward Lemur1dc66e12020-02-21 21:36:34 +00001778 ],
1779 'warnings': [
Edward Lemur6eb1d322020-02-27 22:20:15 +00001780 warning.json_format()
1781 for warning in messages.get('Warnings', [])
Edward Lemur1dc66e12020-02-21 21:36:34 +00001782 ],
Edward Lemur6eb1d322020-02-27 22:20:15 +00001783 'more_cc': executer.more_cc,
Edward Lemur1dc66e12020-02-21 21:36:34 +00001784 }
1785
1786 gclient_utils.FileWrite(
1787 json_output, json.dumps(presubmit_results, sort_keys=True))
1788
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001789 global _ASKED_FOR_FEEDBACK
1790 # Ask for feedback one time out of 5.
1791 if (len(results) and random.randint(0, 4) == 0 and not _ASKED_FOR_FEEDBACK):
Edward Lemur6eb1d322020-02-27 22:20:15 +00001792 sys.stdout.write(
maruel@chromium.org1ce8e662014-01-14 15:23:00 +00001793 'Was the presubmit check useful? If not, run "git cl presubmit -v"\n'
1794 'to figure out which PRESUBMIT.py was run, then run git blame\n'
1795 'on the file to figure out who to ask for help.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001796 _ASKED_FOR_FEEDBACK = True
Edward Lemur6eb1d322020-02-27 22:20:15 +00001797
1798 return 1 if presubmits_failed else 0
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001799 finally:
1800 os.environ = old_environ
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001801
1802
Edward Lemur50984a62020-02-06 18:10:18 +00001803def _scan_sub_dirs(mask, recursive):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001804 if not recursive:
pgervais@chromium.orge57b09d2014-05-07 00:58:13 +00001805 return [x for x in glob.glob(mask) if x not in ('.svn', '.git')]
Lei Zhang9611c4c2017-04-04 01:41:56 -07001806
1807 results = []
1808 for root, dirs, files in os.walk('.'):
1809 if '.svn' in dirs:
1810 dirs.remove('.svn')
1811 if '.git' in dirs:
1812 dirs.remove('.git')
1813 for name in files:
1814 if fnmatch.fnmatch(name, mask):
1815 results.append(os.path.join(root, name))
1816 return results
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001817
1818
Edward Lemur50984a62020-02-06 18:10:18 +00001819def _parse_files(args, recursive):
tobiasjs2836bcf2016-08-16 04:08:16 -07001820 logging.debug('Searching for %s', args)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001821 files = []
1822 for arg in args:
Edward Lemur50984a62020-02-06 18:10:18 +00001823 files.extend([('M', f) for f in _scan_sub_dirs(arg, recursive)])
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001824 return files
1825
1826
Edward Lemur50984a62020-02-06 18:10:18 +00001827def _parse_change(parser, options):
1828 """Process change options.
1829
1830 Args:
1831 parser: The parser used to parse the arguments from command line.
1832 options: The arguments parsed from command line.
1833 Returns:
1834 A GitChange if the change root is a git repository, or a Change otherwise.
1835 """
1836 if options.files and options.all_files:
1837 parser.error('<files> cannot be specified when --all-files is set.')
1838
Edward Lesmes44ea3ff2020-02-05 00:14:30 +00001839 change_scm = scm.determine_scm(options.root)
Edward Lemur50984a62020-02-06 18:10:18 +00001840 if change_scm != 'git' and not options.files:
1841 parser.error('<files> is not optional for unversioned directories.')
1842
1843 if options.files:
1844 change_files = _parse_files(options.files, options.recursive)
1845 elif options.all_files:
1846 change_files = [('M', f) for f in scm.GIT.GetAllFiles(options.root)]
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001847 else:
Edward Lemur50984a62020-02-06 18:10:18 +00001848 change_files = scm.GIT.CaptureStatus(
Edward Lemur7f6dec02020-02-06 20:23:58 +00001849 options.root, options.upstream or None)
Edward Lemur50984a62020-02-06 18:10:18 +00001850
1851 logging.info('Found %d file(s).', len(change_files))
1852
1853 change_class = GitChange if change_scm == 'git' else Change
1854 return change_class(
1855 options.name,
1856 options.description,
1857 options.root,
1858 change_files,
1859 options.issue,
1860 options.patchset,
1861 options.author,
1862 upstream=options.upstream)
1863
1864
1865def _parse_gerrit_options(parser, options):
1866 """Process gerrit options.
1867
1868 SIDE EFFECTS: Modifies options.author and options.description from Gerrit if
1869 options.gerrit_fetch is set.
1870
1871 Args:
1872 parser: The parser used to parse the arguments from command line.
1873 options: The arguments parsed from command line.
1874 Returns:
1875 A GerritAccessor object if options.gerrit_url is set, or None otherwise.
1876 """
1877 gerrit_obj = None
1878 if options.gerrit_url:
1879 gerrit_obj = GerritAccessor(urlparse.urlparse(options.gerrit_url).netloc)
1880
1881 if not options.gerrit_fetch:
1882 return gerrit_obj
1883
1884 if not options.gerrit_url or not options.issue or not options.patchset:
1885 parser.error(
1886 '--gerrit_fetch requires --gerrit_url, --issue and --patchset.')
1887
1888 options.author = gerrit_obj.GetChangeOwner(options.issue)
1889 options.description = gerrit_obj.GetChangeDescription(
1890 options.issue, options.patchset)
1891
1892 logging.info('Got author: "%s"', options.author)
1893 logging.info('Got description: """\n%s\n"""', options.description)
1894
1895 return gerrit_obj
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001896
1897
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001898@contextlib.contextmanager
1899def canned_check_filter(method_names):
1900 filtered = {}
1901 try:
1902 for method_name in method_names:
1903 if not hasattr(presubmit_canned_checks, method_name):
Aaron Gableecee74c2018-04-02 15:13:08 -07001904 logging.warn('Skipping unknown "canned" check %s' % method_name)
1905 continue
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001906 filtered[method_name] = getattr(presubmit_canned_checks, method_name)
1907 setattr(presubmit_canned_checks, method_name, lambda *_a, **_kw: [])
1908 yield
1909 finally:
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001910 for name, method in filtered.items():
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001911 setattr(presubmit_canned_checks, name, method)
1912
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +00001913
sbc@chromium.org013731e2015-02-26 18:28:43 +00001914def main(argv=None):
Edward Lemura5799e32020-01-17 19:26:51 +00001915 parser = argparse.ArgumentParser(usage='%(prog)s [options] <files...>')
1916 hooks = parser.add_mutually_exclusive_group()
1917 hooks.add_argument('-c', '--commit', action='store_true',
1918 help='Use commit instead of upload checks.')
1919 hooks.add_argument('-u', '--upload', action='store_false', dest='commit',
1920 help='Use upload instead of commit checks.')
Edward Lemur75526302020-02-27 22:31:05 +00001921 hooks.add_argument('--post_upload', action='store_true',
1922 help='Run post-upload commit hooks.')
Edward Lemura5799e32020-01-17 19:26:51 +00001923 parser.add_argument('-r', '--recursive', action='store_true',
1924 help='Act recursively.')
1925 parser.add_argument('-v', '--verbose', action='count', default=0,
1926 help='Use 2 times for more debug info.')
1927 parser.add_argument('--name', default='no name')
1928 parser.add_argument('--author')
Edward Lemur227d5102020-02-25 23:45:35 +00001929 desc = parser.add_mutually_exclusive_group()
1930 desc.add_argument('--description', default='', help='The change description.')
1931 desc.add_argument('--description_file',
1932 help='File to read change description from.')
Edward Lemura5799e32020-01-17 19:26:51 +00001933 parser.add_argument('--issue', type=int, default=0)
1934 parser.add_argument('--patchset', type=int, default=0)
1935 parser.add_argument('--root', default=os.getcwd(),
1936 help='Search for PRESUBMIT.py up to this directory. '
1937 'If inherit-review-settings-ok is present in this '
1938 'directory, parent directories up to the root file '
1939 'system directories will also be searched.')
1940 parser.add_argument('--upstream',
1941 help='Git only: the base ref or upstream branch against '
1942 'which the diff should be computed.')
1943 parser.add_argument('--default_presubmit')
1944 parser.add_argument('--may_prompt', action='store_true', default=False)
1945 parser.add_argument('--skip_canned', action='append', default=[],
1946 help='A list of checks to skip which appear in '
1947 'presubmit_canned_checks. Can be provided multiple times '
1948 'to skip multiple canned checks.')
1949 parser.add_argument('--dry_run', action='store_true', help=argparse.SUPPRESS)
1950 parser.add_argument('--gerrit_url', help=argparse.SUPPRESS)
1951 parser.add_argument('--gerrit_fetch', action='store_true',
1952 help=argparse.SUPPRESS)
1953 parser.add_argument('--parallel', action='store_true',
1954 help='Run all tests specified by input_api.RunTests in '
1955 'all PRESUBMIT files in parallel.')
1956 parser.add_argument('--json_output',
1957 help='Write presubmit errors to json output.')
Edward Lemur1dc66e12020-02-21 21:36:34 +00001958 parser.add_argument('--all_files', action='store_true',
Edward Lemur50984a62020-02-06 18:10:18 +00001959 help='Mark all files under source control as modified.')
Edward Lemura5799e32020-01-17 19:26:51 +00001960 parser.add_argument('files', nargs='*',
1961 help='List of files to be marked as modified when '
1962 'executing presubmit or post-upload hooks. fnmatch '
1963 'wildcards can also be used.')
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001964 parser.add_argument('--gerrit_project', help=argparse.SUPPRESS)
Edward Lemura5799e32020-01-17 19:26:51 +00001965 options = parser.parse_args(argv)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001966
Erik Staabcca5c492020-04-16 17:40:07 +00001967 log_level = logging.ERROR
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001968 if options.verbose >= 2:
Erik Staabcca5c492020-04-16 17:40:07 +00001969 log_level = logging.DEBUG
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001970 elif options.verbose:
Erik Staabcca5c492020-04-16 17:40:07 +00001971 log_level = logging.INFO
1972 log_format = ('[%(levelname).1s%(asctime)s %(process)d %(thread)d '
1973 '%(filename)s] %(message)s')
1974 logging.basicConfig(format=log_format, level=log_level)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001975
Edward Lemur227d5102020-02-25 23:45:35 +00001976 if options.description_file:
1977 options.description = gclient_utils.FileRead(options.description_file)
Edward Lemur50984a62020-02-06 18:10:18 +00001978 gerrit_obj = _parse_gerrit_options(parser, options)
1979 change = _parse_change(parser, options)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001980
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001981 try:
Edward Lemur75526302020-02-27 22:31:05 +00001982 if options.post_upload:
1983 return DoPostUploadExecuter(
1984 change,
1985 gerrit_obj,
1986 options.verbose)
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001987 with canned_check_filter(options.skip_canned):
Edward Lemur6eb1d322020-02-27 22:20:15 +00001988 return DoPresubmitChecks(
Edward Lemur50984a62020-02-06 18:10:18 +00001989 change,
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001990 options.commit,
1991 options.verbose,
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001992 options.default_presubmit,
1993 options.may_prompt,
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001994 gerrit_obj,
Edward Lesmes8e282792018-04-03 18:50:29 -04001995 options.dry_run,
Debrian Figueroadd2737e2019-06-21 23:50:13 +00001996 options.parallel,
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001997 options.json_output,
1998 options.gerrit_project)
Raul Tambre7c938462019-05-24 16:35:35 +00001999 except PresubmitFailure as e:
Raul Tambre80ee78e2019-05-06 22:41:05 +00002000 print(e, file=sys.stderr)
2001 print('Maybe your depot_tools is out of date?', file=sys.stderr)
maruel@chromium.org899e1c12011-04-07 17:03:18 +00002002 return 2
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00002003
2004
2005if __name__ == '__main__':
maruel@chromium.org35625c72011-03-23 17:34:02 +00002006 fix_encoding.fix_encoding()
sbc@chromium.org013731e2015-02-26 18:28:43 +00002007 try:
2008 sys.exit(main())
2009 except KeyboardInterrupt:
2010 sys.stderr.write('interrupted\n')
sergiybf8a3b382016-07-05 11:21:30 -07002011 sys.exit(2)