blob: 26bb6de9c8ac0c6ad0a6ad67372d2b071a3a5bd7 [file] [log] [blame]
maruel@chromium.org725f1c32011-04-01 20:24:54 +00001#!/usr/bin/env python
maruel@chromium.org3bbf2942012-01-10 16:52:06 +00002# Copyright (c) 2012 The Chromium Authors. All rights reserved.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00003# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5
6"""Enables directory-specific presubmit checks to run at upload and/or commit.
7"""
8
Raul Tambre80ee78e2019-05-06 22:41:05 +00009from __future__ import print_function
10
Saagar Sanghavi99816902020-08-11 22:41:25 +000011__version__ = '2.0.0'
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000012
13# TODO(joi) Add caching where appropriate/needed. The API is designed to allow
14# caching (between all different invocations of presubmit scripts for a given
15# change). We should add it as our presubmit scripts start feeling slow.
16
Edward Lemura5799e32020-01-17 19:26:51 +000017import argparse
Takeshi Yoshino07a6bea2017-08-02 02:44:06 +090018import ast # Exposed through the API.
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +000019import contextlib
Yoshisato Yanagisawa406de132018-06-29 05:43:25 +000020import cpplint
dcheng091b7db2016-06-16 01:27:51 -070021import fnmatch # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000022import glob
asvitkine@chromium.org15169952011-09-27 14:30:53 +000023import inspect
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +000024import itertools
maruel@chromium.org4f6852c2012-04-20 20:39:20 +000025import json # Exposed through the API.
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +000026import logging
ilevy@chromium.orgbc117312013-04-20 03:57:56 +000027import multiprocessing
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000028import os # Somewhat exposed through the API.
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +000029import random
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000030import re # Exposed through the API.
Edward Lesmes8e282792018-04-03 18:50:29 -040031import signal
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000032import sys # Parts exposed through API.
33import tempfile # Exposed through the API.
Edward Lesmes8e282792018-04-03 18:50:29 -040034import threading
jam@chromium.org2a891dc2009-08-20 20:33:37 +000035import time
Edward Lemurde9e3ca2019-10-24 21:13:31 +000036import traceback
maruel@chromium.org1487d532009-06-06 00:22:57 +000037import unittest # Exposed through the API.
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +000038from warnings import warn
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000039
40# Local imports.
maruel@chromium.org35625c72011-03-23 17:34:02 +000041import fix_encoding
Yoshisato Yanagisawa04600b42019-03-15 03:03:41 +000042import gclient_paths # Exposed through the API
43import gclient_utils
Aaron Gableb584c4f2017-04-26 16:28:08 -070044import git_footers
tandrii@chromium.org015ebae2016-04-25 19:37:22 +000045import gerrit_util
Edward Lesmes9ce03f82021-01-12 20:13:31 +000046import owners as owners_db
47import owners_client
Jochen Eisinger76f5fc62017-04-07 16:27:46 +020048import owners_finder
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000049import presubmit_canned_checks
Saagar Sanghavi9949ab72020-07-20 20:56:40 +000050import rdb_wrapper
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +000051import scm
maruel@chromium.org84f4fe32011-04-06 13:26:45 +000052import subprocess2 as subprocess # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000053
Edward Lemur16af3562019-10-17 22:11:33 +000054if sys.version_info.major == 2:
55 # TODO(1009814): Expose urllib2 only through urllib_request and urllib_error
56 import urllib2 # Exposed through the API.
57 import urlparse
58 import urllib2 as urllib_request
59 import urllib2 as urllib_error
60else:
61 import urllib.parse as urlparse
62 import urllib.request as urllib_request
63 import urllib.error as urllib_error
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000064
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +000065# Ask for feedback only once in program lifetime.
66_ASKED_FOR_FEEDBACK = False
67
Edward Lemurecc27072020-01-06 16:42:34 +000068def time_time():
69 # Use this so that it can be mocked in tests without interfering with python
70 # system machinery.
71 return time.time()
72
73
maruel@chromium.org899e1c12011-04-07 17:03:18 +000074class PresubmitFailure(Exception):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000075 pass
76
77
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000078class CommandData(object):
Edward Lemur940c2822019-08-23 00:34:25 +000079 def __init__(self, name, cmd, kwargs, message, python3=False):
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000080 self.name = name
81 self.cmd = cmd
Edward Lesmes8e282792018-04-03 18:50:29 -040082 self.stdin = kwargs.get('stdin', None)
Edward Lemur2d6b67c2019-08-23 22:25:41 +000083 self.kwargs = kwargs.copy()
Edward Lesmes8e282792018-04-03 18:50:29 -040084 self.kwargs['stdout'] = subprocess.PIPE
85 self.kwargs['stderr'] = subprocess.STDOUT
86 self.kwargs['stdin'] = subprocess.PIPE
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000087 self.message = message
88 self.info = None
Edward Lemur940c2822019-08-23 00:34:25 +000089 self.python3 = python3
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000090
ilevy@chromium.orgbc117312013-04-20 03:57:56 +000091
Edward Lesmes8e282792018-04-03 18:50:29 -040092# Adapted from
93# https://github.com/google/gtest-parallel/blob/master/gtest_parallel.py#L37
94#
95# An object that catches SIGINT sent to the Python process and notices
96# if processes passed to wait() die by SIGINT (we need to look for
97# both of those cases, because pressing Ctrl+C can result in either
98# the main process or one of the subprocesses getting the signal).
99#
100# Before a SIGINT is seen, wait(p) will simply call p.wait() and
101# return the result. Once a SIGINT has been seen (in the main process
102# or a subprocess, including the one the current call is waiting for),
Edward Lemur9a5bb612019-09-26 02:01:52 +0000103# wait(p) will call p.terminate().
Edward Lesmes8e282792018-04-03 18:50:29 -0400104class SigintHandler(object):
Edward Lesmes8e282792018-04-03 18:50:29 -0400105 sigint_returncodes = {-signal.SIGINT, # Unix
106 -1073741510, # Windows
107 }
108 def __init__(self):
109 self.__lock = threading.Lock()
110 self.__processes = set()
111 self.__got_sigint = False
Edward Lemur9a5bb612019-09-26 02:01:52 +0000112 self.__previous_signal = signal.signal(signal.SIGINT, self.interrupt)
Edward Lesmes8e282792018-04-03 18:50:29 -0400113
114 def __on_sigint(self):
115 self.__got_sigint = True
116 while self.__processes:
117 try:
118 self.__processes.pop().terminate()
119 except OSError:
120 pass
121
Edward Lemur9a5bb612019-09-26 02:01:52 +0000122 def interrupt(self, signal_num, frame):
Edward Lesmes8e282792018-04-03 18:50:29 -0400123 with self.__lock:
124 self.__on_sigint()
Edward Lemur9a5bb612019-09-26 02:01:52 +0000125 self.__previous_signal(signal_num, frame)
Edward Lesmes8e282792018-04-03 18:50:29 -0400126
127 def got_sigint(self):
128 with self.__lock:
129 return self.__got_sigint
130
131 def wait(self, p, stdin):
132 with self.__lock:
133 if self.__got_sigint:
134 p.terminate()
135 self.__processes.add(p)
136 stdout, stderr = p.communicate(stdin)
137 code = p.returncode
138 with self.__lock:
139 self.__processes.discard(p)
140 if code in self.sigint_returncodes:
141 self.__on_sigint()
Edward Lesmes8e282792018-04-03 18:50:29 -0400142 return stdout, stderr
143
144sigint_handler = SigintHandler()
145
146
Edward Lemurecc27072020-01-06 16:42:34 +0000147class Timer(object):
148 def __init__(self, timeout, fn):
149 self.completed = False
150 self._fn = fn
151 self._timer = threading.Timer(timeout, self._onTimer) if timeout else None
152
153 def __enter__(self):
154 if self._timer:
155 self._timer.start()
156 return self
157
158 def __exit__(self, _type, _value, _traceback):
159 if self._timer:
160 self._timer.cancel()
161
162 def _onTimer(self):
163 self._fn()
164 self.completed = True
165
166
Edward Lesmes8e282792018-04-03 18:50:29 -0400167class ThreadPool(object):
Edward Lemurecc27072020-01-06 16:42:34 +0000168 def __init__(self, pool_size=None, timeout=None):
169 self.timeout = timeout
Edward Lesmes8e282792018-04-03 18:50:29 -0400170 self._pool_size = pool_size or multiprocessing.cpu_count()
171 self._messages = []
172 self._messages_lock = threading.Lock()
173 self._tests = []
174 self._tests_lock = threading.Lock()
175 self._nonparallel_tests = []
176
Edward Lemurecc27072020-01-06 16:42:34 +0000177 def _GetCommand(self, test):
Edward Lemur940c2822019-08-23 00:34:25 +0000178 vpython = 'vpython'
179 if test.python3:
180 vpython += '3'
181 if sys.platform == 'win32':
182 vpython += '.bat'
Edward Lesmes8e282792018-04-03 18:50:29 -0400183
184 cmd = test.cmd
185 if cmd[0] == 'python':
186 cmd = list(cmd)
187 cmd[0] = vpython
188 elif cmd[0].endswith('.py'):
189 cmd = [vpython] + cmd
190
Edward Lemur336e51f2019-11-14 21:42:04 +0000191 # On Windows, scripts on the current directory take precedence over PATH, so
192 # that when testing depot_tools on Windows, calling `vpython.bat` will
193 # execute the copy of vpython of the depot_tools under test instead of the
194 # one in the bot.
195 # As a workaround, we run the tests from the parent directory instead.
196 if (cmd[0] == vpython and
197 'cwd' in test.kwargs and
198 os.path.basename(test.kwargs['cwd']) == 'depot_tools'):
199 test.kwargs['cwd'] = os.path.dirname(test.kwargs['cwd'])
200 cmd[1] = os.path.join('depot_tools', cmd[1])
201
Edward Lemurecc27072020-01-06 16:42:34 +0000202 return cmd
203
204 def _RunWithTimeout(self, cmd, stdin, kwargs):
205 p = subprocess.Popen(cmd, **kwargs)
206 with Timer(self.timeout, p.terminate) as timer:
207 stdout, _ = sigint_handler.wait(p, stdin)
208 if timer.completed:
209 stdout = 'Process timed out after %ss\n%s' % (self.timeout, stdout)
210 return p.returncode, stdout
211
212 def CallCommand(self, test):
213 """Runs an external program.
214
Edward Lemura5799e32020-01-17 19:26:51 +0000215 This function converts invocation of .py files and invocations of 'python'
Edward Lemurecc27072020-01-06 16:42:34 +0000216 to vpython invocations.
217 """
218 cmd = self._GetCommand(test)
Edward Lesmes8e282792018-04-03 18:50:29 -0400219 try:
Edward Lemurecc27072020-01-06 16:42:34 +0000220 start = time_time()
221 returncode, stdout = self._RunWithTimeout(cmd, test.stdin, test.kwargs)
222 duration = time_time() - start
Edward Lemur7cf94382019-11-15 22:36:41 +0000223 except Exception:
Edward Lemurecc27072020-01-06 16:42:34 +0000224 duration = time_time() - start
Edward Lesmes8e282792018-04-03 18:50:29 -0400225 return test.message(
Edward Lemur7cf94382019-11-15 22:36:41 +0000226 '%s\n%s exec failure (%4.2fs)\n%s' % (
227 test.name, ' '.join(cmd), duration, traceback.format_exc()))
Edward Lemurde9e3ca2019-10-24 21:13:31 +0000228
Edward Lemurecc27072020-01-06 16:42:34 +0000229 if returncode != 0:
Edward Lesmes8e282792018-04-03 18:50:29 -0400230 return test.message(
Edward Lemur7cf94382019-11-15 22:36:41 +0000231 '%s\n%s (%4.2fs) failed\n%s' % (
232 test.name, ' '.join(cmd), duration, stdout))
Edward Lemurecc27072020-01-06 16:42:34 +0000233
Edward Lesmes8e282792018-04-03 18:50:29 -0400234 if test.info:
Edward Lemur7cf94382019-11-15 22:36:41 +0000235 return test.info('%s\n%s (%4.2fs)' % (test.name, ' '.join(cmd), duration))
Edward Lesmes8e282792018-04-03 18:50:29 -0400236
237 def AddTests(self, tests, parallel=True):
238 if parallel:
239 self._tests.extend(tests)
240 else:
241 self._nonparallel_tests.extend(tests)
242
243 def RunAsync(self):
244 self._messages = []
245
246 def _WorkerFn():
247 while True:
248 test = None
249 with self._tests_lock:
250 if not self._tests:
251 break
252 test = self._tests.pop()
253 result = self.CallCommand(test)
254 if result:
255 with self._messages_lock:
256 self._messages.append(result)
257
258 def _StartDaemon():
259 t = threading.Thread(target=_WorkerFn)
260 t.daemon = True
261 t.start()
262 return t
263
264 while self._nonparallel_tests:
265 test = self._nonparallel_tests.pop()
266 result = self.CallCommand(test)
267 if result:
268 self._messages.append(result)
269
270 if self._tests:
271 threads = [_StartDaemon() for _ in range(self._pool_size)]
272 for worker in threads:
273 worker.join()
274
275 return self._messages
276
277
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000278def normpath(path):
279 '''Version of os.path.normpath that also changes backward slashes to
280 forward slashes when not running on Windows.
281 '''
282 # This is safe to always do because the Windows version of os.path.normpath
283 # will replace forward slashes with backward slashes.
284 path = path.replace(os.sep, '/')
285 return os.path.normpath(path)
286
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000287
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000288def _RightHandSideLinesImpl(affected_files):
289 """Implements RightHandSideLines for InputApi and GclChange."""
290 for af in affected_files:
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000291 lines = af.ChangedContents()
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000292 for line in lines:
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000293 yield (af, line[0], line[1])
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000294
295
Edward Lemur6eb1d322020-02-27 22:20:15 +0000296def prompt_should_continue(prompt_string):
297 sys.stdout.write(prompt_string)
298 response = sys.stdin.readline().strip().lower()
299 return response in ('y', 'yes')
dpranke@chromium.org5ac21012011-03-16 02:58:25 +0000300
301
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000302# Top level object so multiprocessing can pickle
303# Public access through OutputApi object.
304class _PresubmitResult(object):
305 """Base class for result objects."""
306 fatal = False
307 should_prompt = False
308
309 def __init__(self, message, items=None, long_text=''):
310 """
311 message: A short one-line message to indicate errors.
312 items: A list of short strings to indicate where errors occurred.
313 long_text: multi-line text output, e.g. from another tool
314 """
315 self._message = message
316 self._items = items or []
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000317 self._long_text = long_text.rstrip()
318
Edward Lemur6eb1d322020-02-27 22:20:15 +0000319 def handle(self):
320 sys.stdout.write(self._message)
321 sys.stdout.write('\n')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000322 for index, item in enumerate(self._items):
Edward Lemur6eb1d322020-02-27 22:20:15 +0000323 sys.stdout.write(' ')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000324 # Write separately in case it's unicode.
Edward Lemur6eb1d322020-02-27 22:20:15 +0000325 sys.stdout.write(str(item))
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000326 if index < len(self._items) - 1:
Edward Lemur6eb1d322020-02-27 22:20:15 +0000327 sys.stdout.write(' \\')
328 sys.stdout.write('\n')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000329 if self._long_text:
Edward Lemur6eb1d322020-02-27 22:20:15 +0000330 sys.stdout.write('\n***************\n')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000331 # Write separately in case it's unicode.
Edward Lemur6eb1d322020-02-27 22:20:15 +0000332 sys.stdout.write(self._long_text)
333 sys.stdout.write('\n***************\n')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000334
Debrian Figueroadd2737e2019-06-21 23:50:13 +0000335 def json_format(self):
336 return {
337 'message': self._message,
Debrian Figueroa6095d402019-06-28 18:47:18 +0000338 'items': [str(item) for item in self._items],
Debrian Figueroadd2737e2019-06-21 23:50:13 +0000339 'long_text': self._long_text,
340 'fatal': self.fatal
341 }
342
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000343
344# Top level object so multiprocessing can pickle
345# Public access through OutputApi object.
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000346class _PresubmitError(_PresubmitResult):
347 """A hard presubmit error."""
348 fatal = True
349
350
351# Top level object so multiprocessing can pickle
352# Public access through OutputApi object.
353class _PresubmitPromptWarning(_PresubmitResult):
354 """An warning that prompts the user if they want to continue."""
355 should_prompt = True
356
357
358# Top level object so multiprocessing can pickle
359# Public access through OutputApi object.
360class _PresubmitNotifyResult(_PresubmitResult):
361 """Just print something to the screen -- but it's not even a warning."""
362 pass
363
364
365# Top level object so multiprocessing can pickle
366# Public access through OutputApi object.
367class _MailTextResult(_PresubmitResult):
368 """A warning that should be included in the review request email."""
369 def __init__(self, *args, **kwargs):
370 super(_MailTextResult, self).__init__()
371 raise NotImplementedError()
372
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000373class GerritAccessor(object):
374 """Limited Gerrit functionality for canned presubmit checks to work.
375
376 To avoid excessive Gerrit calls, caches the results.
377 """
378
379 def __init__(self, host):
380 self.host = host
381 self.cache = {}
382
383 def _FetchChangeDetail(self, issue):
384 # Separate function to be easily mocked in tests.
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +0100385 try:
386 return gerrit_util.GetChangeDetail(
387 self.host, str(issue),
Aaron Gable6f5a8d92017-04-18 14:49:05 -0700388 ['ALL_REVISIONS', 'DETAILED_LABELS', 'ALL_COMMITS'])
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +0100389 except gerrit_util.GerritError as e:
390 if e.http_status == 404:
391 raise Exception('Either Gerrit issue %s doesn\'t exist, or '
392 'no credentials to fetch issue details' % issue)
393 raise
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000394
395 def GetChangeInfo(self, issue):
396 """Returns labels and all revisions (patchsets) for this issue.
397
398 The result is a dictionary according to Gerrit REST Api.
399 https://gerrit-review.googlesource.com/Documentation/rest-api.html
400
401 However, API isn't very clear what's inside, so see tests for example.
402 """
403 assert issue
404 cache_key = int(issue)
405 if cache_key not in self.cache:
406 self.cache[cache_key] = self._FetchChangeDetail(issue)
407 return self.cache[cache_key]
408
409 def GetChangeDescription(self, issue, patchset=None):
410 """If patchset is none, fetches current patchset."""
411 info = self.GetChangeInfo(issue)
412 # info is a reference to cache. We'll modify it here adding description to
413 # it to the right patchset, if it is not yet there.
414
415 # Find revision info for the patchset we want.
416 if patchset is not None:
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +0000417 for rev, rev_info in info['revisions'].items():
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000418 if str(rev_info['_number']) == str(patchset):
419 break
420 else:
421 raise Exception('patchset %s doesn\'t exist in issue %s' % (
422 patchset, issue))
423 else:
424 rev = info['current_revision']
425 rev_info = info['revisions'][rev]
426
Andrii Shyshkalov9c3a4642017-01-24 17:41:22 +0100427 return rev_info['commit']['message']
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000428
Mun Yong Jang603d01e2017-12-19 16:38:30 -0800429 def GetDestRef(self, issue):
430 ref = self.GetChangeInfo(issue)['branch']
431 if not ref.startswith('refs/'):
432 # NOTE: it is possible to create 'refs/x' branch,
433 # aka 'refs/heads/refs/x'. However, this is ill-advised.
434 ref = 'refs/heads/%s' % ref
435 return ref
436
Edward Lesmes02d4b822020-11-11 00:37:35 +0000437 def _GetApproversForLabel(self, issue, label):
438 change_info = self.GetChangeInfo(issue)
439 label_info = change_info.get('labels', {}).get(label, {})
440 values = label_info.get('values', {}).keys()
441 if not values:
442 return []
443 max_value = max(int(v) for v in values)
444 return [v for v in label_info.get('all', [])
445 if v.get('value', 0) == max_value]
446
447 def IsBotCommitApproved(self, issue):
448 return bool(self._GetApproversForLabel(issue, 'Bot-Commit'))
449
Edward Lesmescf49cb82020-11-11 01:08:36 +0000450 def IsOwnersOverrideApproved(self, issue):
451 return bool(self._GetApproversForLabel(issue, 'Owners-Override'))
452
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000453 def GetChangeOwner(self, issue):
454 return self.GetChangeInfo(issue)['owner']['email']
455
456 def GetChangeReviewers(self, issue, approving_only=True):
Aaron Gable8b478f02017-07-31 15:33:19 -0700457 changeinfo = self.GetChangeInfo(issue)
458 if approving_only:
Edward Lesmes02d4b822020-11-11 00:37:35 +0000459 reviewers = self._GetApproversForLabel(issue, 'Code-Review')
Aaron Gable8b478f02017-07-31 15:33:19 -0700460 else:
461 reviewers = changeinfo.get('reviewers', {}).get('REVIEWER', [])
462 return [r.get('email') for r in reviewers]
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000463
Edward Lemure4d329c2020-02-03 20:41:18 +0000464 def UpdateDescription(self, description, issue):
465 gerrit_util.SetCommitMessage(self.host, issue, description, notify='NONE')
466
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000467
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000468class OutputApi(object):
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000469 """An instance of OutputApi gets passed to presubmit scripts so that they
470 can output various types of results.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000471 """
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000472 PresubmitResult = _PresubmitResult
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000473 PresubmitError = _PresubmitError
474 PresubmitPromptWarning = _PresubmitPromptWarning
475 PresubmitNotifyResult = _PresubmitNotifyResult
476 MailTextResult = _MailTextResult
477
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000478 def __init__(self, is_committing):
479 self.is_committing = is_committing
Daniel Cheng7227d212017-11-17 08:12:37 -0800480 self.more_cc = []
481
482 def AppendCC(self, cc):
483 """Appends a user to cc for this change."""
484 self.more_cc.append(cc)
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000485
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000486 def PresubmitPromptOrNotify(self, *args, **kwargs):
487 """Warn the user when uploading, but only notify if committing."""
488 if self.is_committing:
489 return self.PresubmitNotifyResult(*args, **kwargs)
490 return self.PresubmitPromptWarning(*args, **kwargs)
491
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000492
493class InputApi(object):
494 """An instance of this object is passed to presubmit scripts so they can
495 know stuff about the change they're looking at.
496 """
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000497 # Method could be a function
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800498 # pylint: disable=no-self-use
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000499
maruel@chromium.org3410d912009-06-09 20:56:16 +0000500 # File extensions that are considered source files from a style guide
501 # perspective. Don't modify this list from a presubmit script!
maruel@chromium.orgc33455a2011-06-24 19:14:18 +0000502 #
503 # Files without an extension aren't included in the list. If you want to
local_bot30f774e2020-06-25 18:23:34 +0000504 # filter them as source files, add r'(^|.*?[\\\/])[^.]+$' to the allow list.
local_bot64021412020-07-08 21:05:39 +0000505 # Note that ALL CAPS files are skipped in DEFAULT_FILES_TO_SKIP below.
506 DEFAULT_FILES_TO_CHECK = (
maruel@chromium.org3410d912009-06-09 20:56:16 +0000507 # C++ and friends
Edward Lemura5799e32020-01-17 19:26:51 +0000508 r'.+\.c$', r'.+\.cc$', r'.+\.cpp$', r'.+\.h$', r'.+\.m$', r'.+\.mm$',
509 r'.+\.inl$', r'.+\.asm$', r'.+\.hxx$', r'.+\.hpp$', r'.+\.s$', r'.+\.S$',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000510 # Scripts
Edward Lemura5799e32020-01-17 19:26:51 +0000511 r'.+\.js$', r'.+\.py$', r'.+\.sh$', r'.+\.rb$', r'.+\.pl$', r'.+\.pm$',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000512 # Other
Edward Lemura5799e32020-01-17 19:26:51 +0000513 r'.+\.java$', r'.+\.mk$', r'.+\.am$', r'.+\.css$', r'.+\.mojom$',
514 r'.+\.fidl$'
maruel@chromium.org3410d912009-06-09 20:56:16 +0000515 )
516
517 # Path regexp that should be excluded from being considered containing source
518 # files. Don't modify this list from a presubmit script!
local_bot64021412020-07-08 21:05:39 +0000519 DEFAULT_FILES_TO_SKIP = (
Edward Lemura5799e32020-01-17 19:26:51 +0000520 r'testing_support[\\\/]google_appengine[\\\/].*',
521 r'.*\bexperimental[\\\/].*',
Kent Tamura179dd1e2018-04-26 15:07:41 +0900522 # Exclude third_party/.* but NOT third_party/{WebKit,blink}
523 # (crbug.com/539768 and crbug.com/836555).
Edward Lemura5799e32020-01-17 19:26:51 +0000524 r'.*\bthird_party[\\\/](?!(WebKit|blink)[\\\/]).*',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000525 # Output directories (just in case)
Edward Lemura5799e32020-01-17 19:26:51 +0000526 r'.*\bDebug[\\\/].*',
527 r'.*\bRelease[\\\/].*',
528 r'.*\bxcodebuild[\\\/].*',
529 r'.*\bout[\\\/].*',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000530 # All caps files like README and LICENCE.
Edward Lemura5799e32020-01-17 19:26:51 +0000531 r'.*\b[A-Z0-9_]{2,}$',
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +0000532 # SCM (can happen in dual SCM configuration). (Slightly over aggressive)
Edward Lemura5799e32020-01-17 19:26:51 +0000533 r'(|.*[\\\/])\.git[\\\/].*',
534 r'(|.*[\\\/])\.svn[\\\/].*',
maruel@chromium.org7ccb4bb2011-11-07 20:26:20 +0000535 # There is no point in processing a patch file.
Edward Lemura5799e32020-01-17 19:26:51 +0000536 r'.+\.diff$',
537 r'.+\.patch$',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000538 )
539
local_bot30f774e2020-06-25 18:23:34 +0000540 # TODO(https://crbug.com/1098562): Remove once no longer used
541 @property
542 def DEFAULT_WHITE_LIST(self):
local_bot64021412020-07-08 21:05:39 +0000543 return self.DEFAULT_FILES_TO_CHECK
local_bot30f774e2020-06-25 18:23:34 +0000544
545 # TODO(https://crbug.com/1098562): Remove once no longer used
local_bot37ce2012020-06-26 17:39:24 +0000546 @DEFAULT_WHITE_LIST.setter
547 def DEFAULT_WHITE_LIST(self, value):
local_bot64021412020-07-08 21:05:39 +0000548 self.DEFAULT_FILES_TO_CHECK = value
549
550 # TODO(https://crbug.com/1098562): Remove once no longer used
551 @property
552 def DEFAULT_ALLOW_LIST(self):
553 return self.DEFAULT_FILES_TO_CHECK
554
555 # TODO(https://crbug.com/1098562): Remove once no longer used
556 @DEFAULT_ALLOW_LIST.setter
557 def DEFAULT_ALLOW_LIST(self, value):
558 self.DEFAULT_FILES_TO_CHECK = value
local_bot37ce2012020-06-26 17:39:24 +0000559
560 # TODO(https://crbug.com/1098562): Remove once no longer used
local_bot30f774e2020-06-25 18:23:34 +0000561 @property
562 def DEFAULT_BLACK_LIST(self):
local_bot64021412020-07-08 21:05:39 +0000563 return self.DEFAULT_FILES_TO_SKIP
local_bot30f774e2020-06-25 18:23:34 +0000564
local_bot37ce2012020-06-26 17:39:24 +0000565 # TODO(https://crbug.com/1098562): Remove once no longer used
566 @DEFAULT_BLACK_LIST.setter
567 def DEFAULT_BLACK_LIST(self, value):
local_bot64021412020-07-08 21:05:39 +0000568 self.DEFAULT_FILES_TO_SKIP = value
569
570 # TODO(https://crbug.com/1098562): Remove once no longer used
571 @property
572 def DEFAULT_BLOCK_LIST(self):
573 return self.DEFAULT_FILES_TO_SKIP
574
575 # TODO(https://crbug.com/1098562): Remove once no longer used
576 @DEFAULT_BLOCK_LIST.setter
577 def DEFAULT_BLOCK_LIST(self, value):
578 self.DEFAULT_FILES_TO_SKIP = value
local_bot37ce2012020-06-26 17:39:24 +0000579
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000580 def __init__(self, change, presubmit_path, is_committing,
Edward Lesmes8e282792018-04-03 18:50:29 -0400581 verbose, gerrit_obj, dry_run=None, thread_pool=None, parallel=False):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000582 """Builds an InputApi object.
583
584 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000585 change: A presubmit.Change object.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000586 presubmit_path: The path to the presubmit script being processed.
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000587 is_committing: True if the change is about to be committed.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000588 gerrit_obj: provides basic Gerrit codereview functionality.
589 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -0400590 parallel: if true, all tests reported via input_api.RunTests for all
591 PRESUBMIT files will be run in parallel.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000592 """
maruel@chromium.org9711bba2009-05-22 23:51:39 +0000593 # Version number of the presubmit_support script.
594 self.version = [int(x) for x in __version__.split('.')]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000595 self.change = change
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000596 self.is_committing = is_committing
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000597 self.gerrit = gerrit_obj
tandrii@chromium.org57bafac2016-04-28 05:09:03 +0000598 self.dry_run = dry_run
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000599
Edward Lesmes8e282792018-04-03 18:50:29 -0400600 self.parallel = parallel
601 self.thread_pool = thread_pool or ThreadPool()
602
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000603 # We expose various modules and functions as attributes of the input_api
604 # so that presubmit scripts don't have to import them.
Takeshi Yoshino07a6bea2017-08-02 02:44:06 +0900605 self.ast = ast
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000606 self.basename = os.path.basename
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000607 self.cpplint = cpplint
dcheng091b7db2016-06-16 01:27:51 -0700608 self.fnmatch = fnmatch
Yoshisato Yanagisawa04600b42019-03-15 03:03:41 +0000609 self.gclient_paths = gclient_paths
Yoshisato Yanagisawa57dd17b2019-03-22 09:10:29 +0000610 # TODO(yyanagisawa): stop exposing this when python3 become default.
611 # Since python3's tempfile has TemporaryDirectory, we do not need this.
612 self.temporary_directory = gclient_utils.temporary_directory
dpranke@chromium.org17cc2442012-10-17 21:12:09 +0000613 self.glob = glob.glob
maruel@chromium.orgfb11c7b2010-03-18 18:22:14 +0000614 self.json = json
maruel@chromium.org6fba34d2011-06-02 13:45:12 +0000615 self.logging = logging.getLogger('PRESUBMIT')
maruel@chromium.org2b5ce562011-03-31 16:15:44 +0000616 self.os_listdir = os.listdir
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000617 self.os_path = os.path
pgervais@chromium.orgbd0cace2014-10-02 23:23:46 +0000618 self.os_stat = os.stat
Yoshisato Yanagisawa406de132018-06-29 05:43:25 +0000619 self.os_walk = os.walk
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000620 self.re = re
621 self.subprocess = subprocess
Edward Lemurb9830242019-10-30 22:19:20 +0000622 self.sys = sys
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000623 self.tempfile = tempfile
dpranke@chromium.org0d1bdea2011-03-24 22:54:38 +0000624 self.time = time
maruel@chromium.org1487d532009-06-06 00:22:57 +0000625 self.unittest = unittest
Edward Lemurb9830242019-10-30 22:19:20 +0000626 if sys.version_info.major == 2:
627 self.urllib2 = urllib2
Edward Lemur16af3562019-10-17 22:11:33 +0000628 self.urllib_request = urllib_request
629 self.urllib_error = urllib_error
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000630
Robert Iannucci50258932018-03-19 10:30:59 -0700631 self.is_windows = sys.platform == 'win32'
632
Edward Lemurb9646622019-10-25 20:57:35 +0000633 # Set python_executable to 'vpython' in order to allow scripts in other
634 # repos (e.g. src.git) to automatically pick up that repo's .vpython file,
635 # instead of inheriting the one in depot_tools.
636 self.python_executable = 'vpython'
maruel@chromium.orgc0b22972009-06-25 16:19:14 +0000637 self.environ = os.environ
638
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000639 # InputApi.platform is the platform you're currently running on.
640 self.platform = sys.platform
641
iannucci@chromium.org0af3bb32015-06-12 20:44:35 +0000642 self.cpu_count = multiprocessing.cpu_count()
643
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000644 # The local path of the currently-being-processed presubmit script.
maruel@chromium.org3d235242009-05-15 12:40:48 +0000645 self._current_presubmit_path = os.path.dirname(presubmit_path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000646
647 # We carry the canned checks so presubmit scripts can easily use them.
648 self.canned_checks = presubmit_canned_checks
649
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +0100650 # Temporary files we must manually remove at the end of a run.
651 self._named_temporary_files = []
Jochen Eisinger72606f82017-04-04 10:44:18 +0200652
dpranke@chromium.org2a009622011-03-01 02:43:31 +0000653 # TODO(dpranke): figure out a list of all approved owners for a repo
654 # in order to be able to handle wildcard OWNERS files?
Edward Lesmes9ce03f82021-01-12 20:13:31 +0000655 self.owners_client = owners_client.DepotToolsClient(
656 change.RepositoryRoot(), change.UpstreamBranch(), os_path=self.os_path)
657 self.owners_db = owners_db.Database(
658 change.RepositoryRoot(), fopen=open, os_path=self.os_path)
Jochen Eisinger76f5fc62017-04-07 16:27:46 +0200659 self.owners_finder = owners_finder.OwnersFinder
maruel@chromium.org899e1c12011-04-07 17:03:18 +0000660 self.verbose = verbose
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000661 self.Command = CommandData
dpranke@chromium.org2a009622011-03-01 02:43:31 +0000662
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000663 # Replace <hash_map> and <hash_set> as headers that need to be included
Edward Lemura5799e32020-01-17 19:26:51 +0000664 # with 'base/containers/hash_tables.h' instead.
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000665 # Access to a protected member _XX of a client class
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800666 # pylint: disable=protected-access
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000667 self.cpplint._re_pattern_templates = [
danakj@chromium.org18278522013-06-11 22:42:32 +0000668 (a, b, 'base/containers/hash_tables.h')
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000669 if header in ('<hash_map>', '<hash_set>') else (a, b, header)
670 for (a, b, header) in cpplint._re_pattern_templates
671 ]
672
Edward Lemurecc27072020-01-06 16:42:34 +0000673 def SetTimeout(self, timeout):
674 self.thread_pool.timeout = timeout
675
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000676 def PresubmitLocalPath(self):
677 """Returns the local path of the presubmit script currently being run.
678
679 This is useful if you don't want to hard-code absolute paths in the
680 presubmit script. For example, It can be used to find another file
681 relative to the PRESUBMIT.py script, so the whole tree can be branched and
682 the presubmit script still works, without editing its content.
683 """
maruel@chromium.org3d235242009-05-15 12:40:48 +0000684 return self._current_presubmit_path
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000685
agable0b65e732016-11-22 09:25:46 -0800686 def AffectedFiles(self, include_deletes=True, file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000687 """Same as input_api.change.AffectedFiles() except only lists files
688 (and optionally directories) in the same directory as the current presubmit
Bruce Dawson7a0b07a2020-04-23 17:14:40 +0000689 script, or subdirectories thereof. Note that files are listed using the OS
690 path separator, so backslashes are used as separators on Windows.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000691 """
Edward Lemura5799e32020-01-17 19:26:51 +0000692 dir_with_slash = normpath('%s/' % self.PresubmitLocalPath())
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000693 if len(dir_with_slash) == 1:
694 dir_with_slash = ''
sail@chromium.org5538e022011-05-12 17:53:16 +0000695
Edward Lemurb9830242019-10-30 22:19:20 +0000696 return list(filter(
maruel@chromium.org4661e0c2009-06-04 00:45:26 +0000697 lambda x: normpath(x.AbsoluteLocalPath()).startswith(dir_with_slash),
Edward Lemurb9830242019-10-30 22:19:20 +0000698 self.change.AffectedFiles(include_deletes, file_filter)))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000699
agable0b65e732016-11-22 09:25:46 -0800700 def LocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000701 """Returns local paths of input_api.AffectedFiles()."""
agable0b65e732016-11-22 09:25:46 -0800702 paths = [af.LocalPath() for af in self.AffectedFiles()]
Edward Lemura5799e32020-01-17 19:26:51 +0000703 logging.debug('LocalPaths: %s', paths)
pgervais@chromium.org2f64f782014-04-25 00:12:33 +0000704 return paths
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000705
agable0b65e732016-11-22 09:25:46 -0800706 def AbsoluteLocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000707 """Returns absolute local paths of input_api.AffectedFiles()."""
agable0b65e732016-11-22 09:25:46 -0800708 return [af.AbsoluteLocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000709
John Budorick16162372018-04-18 10:39:53 -0700710 def AffectedTestableFiles(self, include_deletes=None, **kwargs):
agable0b65e732016-11-22 09:25:46 -0800711 """Same as input_api.change.AffectedTestableFiles() except only lists files
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000712 in the same directory as the current presubmit script, or subdirectories
713 thereof.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000714 """
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000715 if include_deletes is not None:
Edward Lemura5799e32020-01-17 19:26:51 +0000716 warn('AffectedTestableFiles(include_deletes=%s)'
717 ' is deprecated and ignored' % str(include_deletes),
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000718 category=DeprecationWarning,
719 stacklevel=2)
Edward Lemurb9830242019-10-30 22:19:20 +0000720 return list(filter(
721 lambda x: x.IsTestableFile(),
722 self.AffectedFiles(include_deletes=False, **kwargs)))
agable0b65e732016-11-22 09:25:46 -0800723
724 def AffectedTextFiles(self, include_deletes=None):
725 """An alias to AffectedTestableFiles for backwards compatibility."""
726 return self.AffectedTestableFiles(include_deletes=include_deletes)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000727
local_bot64021412020-07-08 21:05:39 +0000728 def FilterSourceFile(self, affected_file, files_to_check=None,
729 files_to_skip=None, allow_list=None, block_list=None,
local_bot30f774e2020-06-25 18:23:34 +0000730 white_list=None, black_list=None):
Edward Lemura5799e32020-01-17 19:26:51 +0000731 """Filters out files that aren't considered 'source file'.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000732
local_bot64021412020-07-08 21:05:39 +0000733 If files_to_check or files_to_skip is None, InputApi.DEFAULT_FILES_TO_CHECK
734 and InputApi.DEFAULT_FILES_TO_SKIP is used respectively.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000735
736 The lists will be compiled as regular expression and
737 AffectedFile.LocalPath() needs to pass both list.
738
local_bot64021412020-07-08 21:05:39 +0000739 Note: if files_to_check or files_to_skip is not set, and
740 white_list/allow_list or black_list/block_list is, then those values are
741 used. This is used for backward compatibility reasons.
local_bot30f774e2020-06-25 18:23:34 +0000742
maruel@chromium.org3410d912009-06-09 20:56:16 +0000743 Note: Copy-paste this function to suit your needs or use a lambda function.
744 """
Josip Sokcevicc6aa1512020-08-25 23:47:13 +0000745 # TODO(https://crbug.com/1098560): Remove non inclusive parameter names.
746 if files_to_check is None and (allow_list or white_list):
747 warn('Use files_to_check in FilterSourceFile')
local_bot64021412020-07-08 21:05:39 +0000748 files_to_check = allow_list or white_list
Josip Sokcevicc6aa1512020-08-25 23:47:13 +0000749 if files_to_skip is None and (block_list or black_list):
750 warn('Use files_to_skip in FilterSourceFile')
local_bot64021412020-07-08 21:05:39 +0000751 files_to_skip = block_list or black_list
752
753 if files_to_check is None:
754 files_to_check = self.DEFAULT_FILES_TO_CHECK
755 if files_to_skip is None:
756 files_to_skip = self.DEFAULT_FILES_TO_SKIP
local_bot30f774e2020-06-25 18:23:34 +0000757
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000758 def Find(affected_file, items):
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000759 local_path = affected_file.LocalPath()
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000760 for item in items:
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +0000761 if self.re.match(item, local_path):
maruel@chromium.org3410d912009-06-09 20:56:16 +0000762 return True
763 return False
local_bot64021412020-07-08 21:05:39 +0000764 return (Find(affected_file, files_to_check) and
765 not Find(affected_file, files_to_skip))
maruel@chromium.org3410d912009-06-09 20:56:16 +0000766
767 def AffectedSourceFiles(self, source_file):
agable0b65e732016-11-22 09:25:46 -0800768 """Filter the list of AffectedTestableFiles by the function source_file.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000769
770 If source_file is None, InputApi.FilterSourceFile() is used.
771 """
772 if not source_file:
773 source_file = self.FilterSourceFile
Edward Lemurb9830242019-10-30 22:19:20 +0000774 return list(filter(source_file, self.AffectedTestableFiles()))
maruel@chromium.org3410d912009-06-09 20:56:16 +0000775
776 def RightHandSideLines(self, source_file_filter=None):
Edward Lemura5799e32020-01-17 19:26:51 +0000777 """An iterator over all text lines in 'new' version of changed files.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000778
779 Only lists lines from new or modified text files in the change that are
780 contained by the directory of the currently executing presubmit script.
781
782 This is useful for doing line-by-line regex checks, like checking for
783 trailing whitespace.
784
785 Yields:
786 a 3 tuple:
787 the AffectedFile instance of the current file;
788 integer line number (1-based); and
789 the contents of the line as a string.
maruel@chromium.org1487d532009-06-06 00:22:57 +0000790
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000791 Note: The carriage return (LF or CR) is stripped off.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000792 """
maruel@chromium.org3410d912009-06-09 20:56:16 +0000793 files = self.AffectedSourceFiles(source_file_filter)
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000794 return _RightHandSideLinesImpl(files)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000795
maruel@chromium.orge3608df2009-11-10 20:22:57 +0000796 def ReadFile(self, file_item, mode='r'):
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000797 """Reads an arbitrary file.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000798
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000799 Deny reading anything outside the repository.
800 """
maruel@chromium.orge3608df2009-11-10 20:22:57 +0000801 if isinstance(file_item, AffectedFile):
802 file_item = file_item.AbsoluteLocalPath()
803 if not file_item.startswith(self.change.RepositoryRoot()):
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000804 raise IOError('Access outside the repository root is denied.')
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +0000805 return gclient_utils.FileRead(file_item, mode)
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000806
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +0100807 def CreateTemporaryFile(self, **kwargs):
808 """Returns a named temporary file that must be removed with a call to
809 RemoveTemporaryFiles().
810
811 All keyword arguments are forwarded to tempfile.NamedTemporaryFile(),
812 except for |delete|, which is always set to False.
813
814 Presubmit checks that need to create a temporary file and pass it for
815 reading should use this function instead of NamedTemporaryFile(), as
816 Windows fails to open a file that is already open for writing.
817
818 with input_api.CreateTemporaryFile() as f:
819 f.write('xyz')
820 f.close()
821 input_api.subprocess.check_output(['script-that', '--reads-from',
822 f.name])
823
824
825 Note that callers of CreateTemporaryFile() should not worry about removing
826 any temporary file; this is done transparently by the presubmit handling
827 code.
828 """
829 if 'delete' in kwargs:
830 # Prevent users from passing |delete|; we take care of file deletion
831 # ourselves and this prevents unintuitive error messages when we pass
832 # delete=False and 'delete' is also in kwargs.
833 raise TypeError('CreateTemporaryFile() does not take a "delete" '
834 'argument, file deletion is handled automatically by '
835 'the same presubmit_support code that creates InputApi '
836 'objects.')
837 temp_file = self.tempfile.NamedTemporaryFile(delete=False, **kwargs)
838 self._named_temporary_files.append(temp_file.name)
839 return temp_file
840
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000841 @property
842 def tbr(self):
843 """Returns if a change is TBR'ed."""
Jeremy Romandce22502017-06-20 15:37:29 -0400844 return 'TBR' in self.change.tags or self.change.TBRsFromDescription()
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000845
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +0000846 def RunTests(self, tests_mix, parallel=True):
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000847 tests = []
848 msgs = []
849 for t in tests_mix:
Edward Lesmes8e282792018-04-03 18:50:29 -0400850 if isinstance(t, OutputApi.PresubmitResult) and t:
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000851 msgs.append(t)
852 else:
853 assert issubclass(t.message, _PresubmitResult)
854 tests.append(t)
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +0000855 if self.verbose:
856 t.info = _PresubmitNotifyResult
Edward Lemur1037c742018-05-01 18:56:04 -0400857 if not t.kwargs.get('cwd'):
858 t.kwargs['cwd'] = self.PresubmitLocalPath()
Edward Lesmes8e282792018-04-03 18:50:29 -0400859 self.thread_pool.AddTests(tests, parallel)
Edward Lemur21000eb2019-05-24 23:25:58 +0000860 # When self.parallel is True (i.e. --parallel is passed as an option)
861 # RunTests doesn't actually run tests. It adds them to a ThreadPool that
862 # will run all tests once all PRESUBMIT files are processed.
863 # Otherwise, it will run them and return the results.
864 if not self.parallel:
Edward Lesmes8e282792018-04-03 18:50:29 -0400865 msgs.extend(self.thread_pool.RunAsync())
866 return msgs
scottmg86099d72016-09-01 09:16:51 -0700867
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000868
nick@chromium.orgff526192013-06-10 19:30:26 +0000869class _DiffCache(object):
870 """Caches diffs retrieved from a particular SCM."""
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000871 def __init__(self, upstream=None):
872 """Stores the upstream revision against which all diffs will be computed."""
873 self._upstream = upstream
nick@chromium.orgff526192013-06-10 19:30:26 +0000874
875 def GetDiff(self, path, local_root):
876 """Get the diff for a particular path."""
877 raise NotImplementedError()
878
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700879 def GetOldContents(self, path, local_root):
880 """Get the old version for a particular path."""
881 raise NotImplementedError()
882
nick@chromium.orgff526192013-06-10 19:30:26 +0000883
nick@chromium.orgff526192013-06-10 19:30:26 +0000884class _GitDiffCache(_DiffCache):
885 """DiffCache implementation for git; gets all file diffs at once."""
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000886 def __init__(self, upstream):
887 super(_GitDiffCache, self).__init__(upstream=upstream)
nick@chromium.orgff526192013-06-10 19:30:26 +0000888 self._diffs_by_file = None
889
890 def GetDiff(self, path, local_root):
891 if not self._diffs_by_file:
892 # Compute a single diff for all files and parse the output; should
893 # with git this is much faster than computing one diff for each file.
894 diffs = {}
895
896 # Don't specify any filenames below, because there are command line length
897 # limits on some platforms and GenerateDiff would fail.
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000898 unified_diff = scm.GIT.GenerateDiff(local_root, files=[], full_move=True,
899 branch=self._upstream)
nick@chromium.orgff526192013-06-10 19:30:26 +0000900
901 # This regex matches the path twice, separated by a space. Note that
902 # filename itself may contain spaces.
903 file_marker = re.compile('^diff --git (?P<filename>.*) (?P=filename)$')
904 current_diff = []
905 keep_line_endings = True
906 for x in unified_diff.splitlines(keep_line_endings):
907 match = file_marker.match(x)
908 if match:
909 # Marks the start of a new per-file section.
910 diffs[match.group('filename')] = current_diff = [x]
911 elif x.startswith('diff --git'):
912 raise PresubmitFailure('Unexpected diff line: %s' % x)
913 else:
914 current_diff.append(x)
915
916 self._diffs_by_file = dict(
917 (normpath(path), ''.join(diff)) for path, diff in diffs.items())
918
919 if path not in self._diffs_by_file:
920 raise PresubmitFailure(
921 'Unified diff did not contain entry for file %s' % path)
922
923 return self._diffs_by_file[path]
924
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700925 def GetOldContents(self, path, local_root):
926 return scm.GIT.GetOldContents(local_root, path, branch=self._upstream)
927
nick@chromium.orgff526192013-06-10 19:30:26 +0000928
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000929class AffectedFile(object):
930 """Representation of a file in a change."""
nick@chromium.orgff526192013-06-10 19:30:26 +0000931
932 DIFF_CACHE = _DiffCache
933
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000934 # Method could be a function
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800935 # pylint: disable=no-self-use
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000936 def __init__(self, path, action, repository_root, diff_cache):
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000937 self._path = path
938 self._action = action
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000939 self._local_root = repository_root
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000940 self._is_directory = None
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000941 self._cached_changed_contents = None
942 self._cached_new_contents = None
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000943 self._diff_cache = diff_cache
tobiasjs2836bcf2016-08-16 04:08:16 -0700944 logging.debug('%s(%s)', self.__class__.__name__, self._path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000945
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000946 def LocalPath(self):
947 """Returns the path of this file on the local disk relative to client root.
Andrew Grieve92b8b992017-11-02 09:42:24 -0400948
949 This should be used for error messages but not for accessing files,
950 because presubmit checks are run with CWD=PresubmitLocalPath() (which is
951 often != client root).
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000952 """
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000953 return normpath(self._path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000954
955 def AbsoluteLocalPath(self):
956 """Returns the absolute path of this file on the local disk.
957 """
chase@chromium.org8e416c82009-10-06 04:30:44 +0000958 return os.path.abspath(os.path.join(self._local_root, self.LocalPath()))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000959
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000960 def Action(self):
961 """Returns the action on this opened file, e.g. A, M, D, etc."""
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000962 return self._action
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000963
agable0b65e732016-11-22 09:25:46 -0800964 def IsTestableFile(self):
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000965 """Returns True if the file is a text file and not a binary file.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000966
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000967 Deleted files are not text file."""
maruel@chromium.org1e08c002009-05-28 19:09:33 +0000968 raise NotImplementedError() # Implement when needed
969
agable0b65e732016-11-22 09:25:46 -0800970 def IsTextFile(self):
971 """An alias to IsTestableFile for backwards compatibility."""
972 return self.IsTestableFile()
973
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700974 def OldContents(self):
975 """Returns an iterator over the lines in the old version of file.
976
Daniel Cheng2da34fe2017-03-21 20:42:12 -0700977 The old version is the file before any modifications in the user's
Edward Lemura5799e32020-01-17 19:26:51 +0000978 workspace, i.e. the 'left hand side'.
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700979
980 Contents will be empty if the file is a directory or does not exist.
981 Note: The carriage returns (LF or CR) are stripped off.
982 """
983 return self._diff_cache.GetOldContents(self.LocalPath(),
984 self._local_root).splitlines()
985
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000986 def NewContents(self):
987 """Returns an iterator over the lines in the new version of file.
988
Edward Lemura5799e32020-01-17 19:26:51 +0000989 The new version is the file in the user's workspace, i.e. the 'right hand
990 side'.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000991
992 Contents will be empty if the file is a directory or does not exist.
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000993 Note: The carriage returns (LF or CR) are stripped off.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000994 """
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000995 if self._cached_new_contents is None:
996 self._cached_new_contents = []
agable0b65e732016-11-22 09:25:46 -0800997 try:
998 self._cached_new_contents = gclient_utils.FileRead(
999 self.AbsoluteLocalPath(), 'rU').splitlines()
1000 except IOError:
1001 pass # File not found? That's fine; maybe it was deleted.
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +00001002 return self._cached_new_contents[:]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001003
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001004 def ChangedContents(self):
1005 """Returns a list of tuples (line number, line text) of all new lines.
1006
1007 This relies on the scm diff output describing each changed code section
1008 with a line of the form
1009
1010 ^@@ <old line num>,<old size> <new line num>,<new size> @@$
1011 """
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +00001012 if self._cached_changed_contents is not None:
1013 return self._cached_changed_contents[:]
1014 self._cached_changed_contents = []
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001015 line_num = 0
1016
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001017 for line in self.GenerateScmDiff().splitlines():
Edward Lemurac5c55f2020-02-29 00:17:16 +00001018 m = re.match(r'^@@ [0-9\,\+\-]+ \+([0-9]+)\,[0-9]+ @@', line)
1019 if m:
1020 line_num = int(m.groups(1)[0])
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001021 continue
1022 if line.startswith('+') and not line.startswith('++'):
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +00001023 self._cached_changed_contents.append((line_num, line[1:]))
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001024 if not line.startswith('-'):
1025 line_num += 1
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +00001026 return self._cached_changed_contents[:]
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001027
maruel@chromium.org5de13972009-06-10 18:16:06 +00001028 def __str__(self):
1029 return self.LocalPath()
1030
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001031 def GenerateScmDiff(self):
nick@chromium.orgff526192013-06-10 19:30:26 +00001032 return self._diff_cache.GetDiff(self.LocalPath(), self._local_root)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001033
maruel@chromium.org58407af2011-04-12 23:15:57 +00001034
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001035class GitAffectedFile(AffectedFile):
1036 """Representation of a file in a change out of a git checkout."""
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +00001037 # Method 'NNN' is abstract in class 'NNN' but is not overridden
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -08001038 # pylint: disable=abstract-method
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001039
nick@chromium.orgff526192013-06-10 19:30:26 +00001040 DIFF_CACHE = _GitDiffCache
1041
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001042 def __init__(self, *args, **kwargs):
1043 AffectedFile.__init__(self, *args, **kwargs)
1044 self._server_path = None
agable0b65e732016-11-22 09:25:46 -08001045 self._is_testable_file = None
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001046
agable0b65e732016-11-22 09:25:46 -08001047 def IsTestableFile(self):
1048 if self._is_testable_file is None:
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001049 if self.Action() == 'D':
agable0b65e732016-11-22 09:25:46 -08001050 # A deleted file is not testable.
1051 self._is_testable_file = False
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001052 else:
agable0b65e732016-11-22 09:25:46 -08001053 self._is_testable_file = os.path.isfile(self.AbsoluteLocalPath())
1054 return self._is_testable_file
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001055
maruel@chromium.orgc1938752011-04-12 23:11:13 +00001056
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001057class Change(object):
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001058 """Describe a change.
1059
1060 Used directly by the presubmit scripts to query the current change being
1061 tested.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +00001062
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001063 Instance members:
nick@chromium.orgff526192013-06-10 19:30:26 +00001064 tags: Dictionary of KEY=VALUE pairs found in the change description.
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001065 self.KEY: equivalent to tags['KEY']
1066 """
1067
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001068 _AFFECTED_FILES = AffectedFile
1069
Edward Lemura5799e32020-01-17 19:26:51 +00001070 # Matches key/value (or 'tag') lines in changelist descriptions.
maruel@chromium.org428342a2011-11-10 15:46:33 +00001071 TAG_LINE_RE = re.compile(
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001072 '^[ \t]*(?P<key>[A-Z][A-Z_0-9]*)[ \t]*=[ \t]*(?P<value>.*?)[ \t]*$')
maruel@chromium.orgc1938752011-04-12 23:11:13 +00001073 scm = ''
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001074
maruel@chromium.org58407af2011-04-12 23:15:57 +00001075 def __init__(
agable@chromium.orgea84ef12014-04-30 19:55:12 +00001076 self, name, description, local_root, files, issue, patchset, author,
1077 upstream=None):
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001078 if files is None:
1079 files = []
1080 self._name = name
chase@chromium.org8e416c82009-10-06 04:30:44 +00001081 # Convert root into an absolute path.
1082 self._local_root = os.path.abspath(local_root)
agable@chromium.orgea84ef12014-04-30 19:55:12 +00001083 self._upstream = upstream
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001084 self.issue = issue
1085 self.patchset = patchset
maruel@chromium.org58407af2011-04-12 23:15:57 +00001086 self.author_email = author
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001087
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001088 self._full_description = ''
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001089 self.tags = {}
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001090 self._description_without_tags = ''
1091 self.SetDescriptionText(description)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001092
maruel@chromium.orge085d812011-10-10 19:49:15 +00001093 assert all(
1094 (isinstance(f, (list, tuple)) and len(f) == 2) for f in files), files
1095
agable@chromium.orgea84ef12014-04-30 19:55:12 +00001096 diff_cache = self._AFFECTED_FILES.DIFF_CACHE(self._upstream)
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001097 self._affected_files = [
nick@chromium.orgff526192013-06-10 19:30:26 +00001098 self._AFFECTED_FILES(path, action.strip(), self._local_root, diff_cache)
1099 for action, path in files
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +00001100 ]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001101
Edward Lesmes9ce03f82021-01-12 20:13:31 +00001102 def UpstreamBranch(self):
1103 """Returns the upstream branch for the change."""
1104 return self._upstream
1105
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001106 def Name(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001107 """Returns the change name."""
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001108 return self._name
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001109
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001110 def DescriptionText(self):
1111 """Returns the user-entered changelist description, minus tags.
1112
Edward Lemura5799e32020-01-17 19:26:51 +00001113 Any line in the user-provided description starting with e.g. 'FOO='
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001114 (whitespace permitted before and around) is considered a tag line. Such
1115 lines are stripped out of the description this function returns.
1116 """
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001117 return self._description_without_tags
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001118
1119 def FullDescriptionText(self):
1120 """Returns the complete changelist description including tags."""
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001121 return self._full_description
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001122
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001123 def SetDescriptionText(self, description):
1124 """Sets the full description text (including tags) to |description|.
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001125
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001126 Also updates the list of tags."""
1127 self._full_description = description
1128
1129 # From the description text, build up a dictionary of key/value pairs
Edward Lemura5799e32020-01-17 19:26:51 +00001130 # plus the description minus all key/value or 'tag' lines.
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001131 description_without_tags = []
1132 self.tags = {}
1133 for line in self._full_description.splitlines():
1134 m = self.TAG_LINE_RE.match(line)
1135 if m:
1136 self.tags[m.group('key')] = m.group('value')
1137 else:
1138 description_without_tags.append(line)
1139
1140 # Change back to text and remove whitespace at end.
1141 self._description_without_tags = (
1142 '\n'.join(description_without_tags).rstrip())
1143
Edward Lemur69bb8be2020-02-03 20:37:38 +00001144 def AddDescriptionFooter(self, key, value):
1145 """Adds the given footer to the change description.
1146
1147 Args:
1148 key: A string with the key for the git footer. It must conform to
1149 the git footers format (i.e. 'List-Of-Tokens') and will be case
1150 normalized so that each token is title-cased.
1151 value: A string with the value for the git footer.
1152 """
1153 description = git_footers.add_footer(
1154 self.FullDescriptionText(), git_footers.normalize_name(key), value)
1155 self.SetDescriptionText(description)
1156
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001157 def RepositoryRoot(self):
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001158 """Returns the repository (checkout) root directory for this change,
1159 as an absolute path.
1160 """
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001161 return self._local_root
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001162
1163 def __getattr__(self, attr):
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001164 """Return tags directly as attributes on the object."""
Edward Lemura5799e32020-01-17 19:26:51 +00001165 if not re.match(r'^[A-Z_]*$', attr):
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001166 raise AttributeError(self, attr)
maruel@chromium.orge1a524f2009-05-27 14:43:46 +00001167 return self.tags.get(attr)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001168
Edward Lemur69bb8be2020-02-03 20:37:38 +00001169 def GitFootersFromDescription(self):
1170 """Return the git footers present in the description.
1171
1172 Returns:
1173 footers: A dict of {footer: [values]} containing a multimap of the footers
1174 in the change description.
1175 """
1176 return git_footers.parse_footers(self.FullDescriptionText())
1177
Aaron Gablefc03e672017-05-15 14:09:42 -07001178 def BugsFromDescription(self):
1179 """Returns all bugs referenced in the commit description."""
Aaron Gable12ef5012017-05-15 14:29:00 -07001180 tags = [b.strip() for b in self.tags.get('BUG', '').split(',') if b.strip()]
Caleb Rouleauc0546b92019-02-22 06:12:57 +00001181 footers = []
Edward Lemur69bb8be2020-02-03 20:37:38 +00001182 parsed = self.GitFootersFromDescription()
Dan Beam62954042019-10-03 21:20:33 +00001183 unsplit_footers = parsed.get('Bug', []) + parsed.get('Fixed', [])
Caleb Rouleauc0546b92019-02-22 06:12:57 +00001184 for unsplit_footer in unsplit_footers:
1185 footers += [b.strip() for b in unsplit_footer.split(',')]
Aaron Gable12ef5012017-05-15 14:29:00 -07001186 return sorted(set(tags + footers))
Aaron Gablefc03e672017-05-15 14:09:42 -07001187
1188 def ReviewersFromDescription(self):
1189 """Returns all reviewers listed in the commit description."""
Edward Lemura5799e32020-01-17 19:26:51 +00001190 # We don't support a 'R:' git-footer for reviewers; that is in metadata.
Aaron Gable12ef5012017-05-15 14:29:00 -07001191 tags = [r.strip() for r in self.tags.get('R', '').split(',') if r.strip()]
1192 return sorted(set(tags))
Aaron Gablefc03e672017-05-15 14:09:42 -07001193
1194 def TBRsFromDescription(self):
1195 """Returns all TBR reviewers listed in the commit description."""
Aaron Gable12ef5012017-05-15 14:29:00 -07001196 tags = [r.strip() for r in self.tags.get('TBR', '').split(',') if r.strip()]
Aaron Gable6e7ddb62020-05-27 22:23:29 +00001197 # TODO(crbug.com/839208): Remove support for 'Tbr:' when TBRs are
1198 # programmatically determined by self-CR+1s.
Edward Lemur69bb8be2020-02-03 20:37:38 +00001199 footers = self.GitFootersFromDescription().get('Tbr', [])
Aaron Gable12ef5012017-05-15 14:29:00 -07001200 return sorted(set(tags + footers))
Aaron Gablefc03e672017-05-15 14:09:42 -07001201
Aaron Gable6e7ddb62020-05-27 22:23:29 +00001202 # TODO(crbug.com/753425): Delete these once we're sure they're unused.
Aaron Gablefc03e672017-05-15 14:09:42 -07001203 @property
1204 def BUG(self):
1205 return ','.join(self.BugsFromDescription())
1206 @property
1207 def R(self):
1208 return ','.join(self.ReviewersFromDescription())
1209 @property
1210 def TBR(self):
1211 return ','.join(self.TBRsFromDescription())
1212
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001213 def AllFiles(self, root=None):
1214 """List all files under source control in the repo."""
1215 raise NotImplementedError()
1216
agable0b65e732016-11-22 09:25:46 -08001217 def AffectedFiles(self, include_deletes=True, file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001218 """Returns a list of AffectedFile instances for all files in the change.
1219
1220 Args:
1221 include_deletes: If false, deleted files will be filtered out.
sail@chromium.org5538e022011-05-12 17:53:16 +00001222 file_filter: An additional filter to apply.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001223
1224 Returns:
1225 [AffectedFile(path, action), AffectedFile(path, action)]
1226 """
Edward Lemurb9830242019-10-30 22:19:20 +00001227 affected = list(filter(file_filter, self._affected_files))
sail@chromium.org5538e022011-05-12 17:53:16 +00001228
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001229 if include_deletes:
1230 return affected
Edward Lemurb9830242019-10-30 22:19:20 +00001231 return list(filter(lambda x: x.Action() != 'D', affected))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001232
John Budorick16162372018-04-18 10:39:53 -07001233 def AffectedTestableFiles(self, include_deletes=None, **kwargs):
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +00001234 """Return a list of the existing text files in a change."""
1235 if include_deletes is not None:
Edward Lemura5799e32020-01-17 19:26:51 +00001236 warn('AffectedTeestableFiles(include_deletes=%s)'
1237 ' is deprecated and ignored' % str(include_deletes),
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +00001238 category=DeprecationWarning,
1239 stacklevel=2)
Edward Lemurb9830242019-10-30 22:19:20 +00001240 return list(filter(
1241 lambda x: x.IsTestableFile(),
1242 self.AffectedFiles(include_deletes=False, **kwargs)))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001243
agable0b65e732016-11-22 09:25:46 -08001244 def AffectedTextFiles(self, include_deletes=None):
1245 """An alias to AffectedTestableFiles for backwards compatibility."""
1246 return self.AffectedTestableFiles(include_deletes=include_deletes)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001247
agable0b65e732016-11-22 09:25:46 -08001248 def LocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001249 """Convenience function."""
agable0b65e732016-11-22 09:25:46 -08001250 return [af.LocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001251
agable0b65e732016-11-22 09:25:46 -08001252 def AbsoluteLocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001253 """Convenience function."""
agable0b65e732016-11-22 09:25:46 -08001254 return [af.AbsoluteLocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001255
1256 def RightHandSideLines(self):
Edward Lemura5799e32020-01-17 19:26:51 +00001257 """An iterator over all text lines in 'new' version of changed files.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001258
1259 Lists lines from new or modified text files in the change.
1260
1261 This is useful for doing line-by-line regex checks, like checking for
1262 trailing whitespace.
1263
1264 Yields:
1265 a 3 tuple:
1266 the AffectedFile instance of the current file;
1267 integer line number (1-based); and
1268 the contents of the line as a string.
1269 """
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +00001270 return _RightHandSideLinesImpl(
1271 x for x in self.AffectedFiles(include_deletes=False)
agable0b65e732016-11-22 09:25:46 -08001272 if x.IsTestableFile())
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001273
Jochen Eisingerd0573ec2017-04-13 10:55:06 +02001274 def OriginalOwnersFiles(self):
1275 """A map from path names of affected OWNERS files to their old content."""
1276 def owners_file_filter(f):
1277 return 'OWNERS' in os.path.split(f.LocalPath())[1]
1278 files = self.AffectedFiles(file_filter=owners_file_filter)
1279 return dict([(f.LocalPath(), f.OldContents()) for f in files])
1280
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001281
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001282class GitChange(Change):
1283 _AFFECTED_FILES = GitAffectedFile
maruel@chromium.orgc1938752011-04-12 23:11:13 +00001284 scm = 'git'
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +00001285
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001286 def AllFiles(self, root=None):
1287 """List all files under source control in the repo."""
1288 root = root or self.RepositoryRoot()
1289 return subprocess.check_output(
Aaron Gable7817f022017-12-12 09:43:17 -08001290 ['git', '-c', 'core.quotePath=false', 'ls-files', '--', '.'],
1291 cwd=root).splitlines()
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001292
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001293
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001294def ListRelevantPresubmitFiles(files, root):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001295 """Finds all presubmit files that apply to a given set of source files.
1296
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001297 If inherit-review-settings-ok is present right under root, looks for
1298 PRESUBMIT.py in directories enclosing root.
1299
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001300 Args:
1301 files: An iterable container containing file paths.
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001302 root: Path where to stop searching.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001303
1304 Return:
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001305 List of absolute paths of the existing PRESUBMIT.py scripts.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001306 """
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001307 files = [normpath(os.path.join(root, f)) for f in files]
1308
1309 # List all the individual directories containing files.
1310 directories = set([os.path.dirname(f) for f in files])
1311
1312 # Ignore root if inherit-review-settings-ok is present.
1313 if os.path.isfile(os.path.join(root, 'inherit-review-settings-ok')):
1314 root = None
1315
1316 # Collect all unique directories that may contain PRESUBMIT.py.
1317 candidates = set()
1318 for directory in directories:
1319 while True:
1320 if directory in candidates:
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001321 break
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001322 candidates.add(directory)
1323 if directory == root:
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001324 break
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001325 parent_dir = os.path.dirname(directory)
1326 if parent_dir == directory:
1327 # We hit the system root directory.
1328 break
1329 directory = parent_dir
1330
1331 # Look for PRESUBMIT.py in all candidate directories.
1332 results = []
1333 for directory in sorted(list(candidates)):
tobiasjsff061c02016-08-17 03:23:57 -07001334 try:
1335 for f in os.listdir(directory):
1336 p = os.path.join(directory, f)
1337 if os.path.isfile(p) and re.match(
1338 r'PRESUBMIT.*\.py$', f) and not f.startswith('PRESUBMIT_test'):
1339 results.append(p)
1340 except OSError:
1341 pass
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001342
tobiasjs2836bcf2016-08-16 04:08:16 -07001343 logging.debug('Presubmit files: %s', ','.join(results))
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001344 return results
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001345
1346
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001347class GetTryMastersExecuter(object):
1348 @staticmethod
1349 def ExecPresubmitScript(script_text, presubmit_path, project, change):
1350 """Executes GetPreferredTryMasters() from a single presubmit script.
1351
1352 Args:
1353 script_text: The text of the presubmit script.
1354 presubmit_path: Project script to run.
1355 project: Project name to pass to presubmit script for bot selection.
1356
1357 Return:
1358 A map of try masters to map of builders to set of tests.
1359 """
1360 context = {}
1361 try:
Raul Tambre09e64b42019-05-14 01:57:22 +00001362 exec(compile(script_text, 'PRESUBMIT.py', 'exec', dont_inherit=True),
1363 context)
Raul Tambre7c938462019-05-24 16:35:35 +00001364 except Exception as e:
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001365 raise PresubmitFailure('"%s" had an exception.\n%s'
1366 % (presubmit_path, e))
1367
1368 function_name = 'GetPreferredTryMasters'
1369 if function_name not in context:
1370 return {}
1371 get_preferred_try_masters = context[function_name]
1372 if not len(inspect.getargspec(get_preferred_try_masters)[0]) == 2:
1373 raise PresubmitFailure(
1374 'Expected function "GetPreferredTryMasters" to take two arguments.')
1375 return get_preferred_try_masters(project, change)
1376
1377
rmistry@google.com5626a922015-02-26 14:03:30 +00001378class GetPostUploadExecuter(object):
1379 @staticmethod
Edward Lemur016a0872020-02-04 22:13:28 +00001380 def ExecPresubmitScript(script_text, presubmit_path, gerrit_obj, change):
rmistry@google.com5626a922015-02-26 14:03:30 +00001381 """Executes PostUploadHook() from a single presubmit script.
1382
1383 Args:
1384 script_text: The text of the presubmit script.
1385 presubmit_path: Project script to run.
Edward Lemur016a0872020-02-04 22:13:28 +00001386 gerrit_obj: The GerritAccessor object.
rmistry@google.com5626a922015-02-26 14:03:30 +00001387 change: The Change object.
1388
1389 Return:
1390 A list of results objects.
1391 """
1392 context = {}
1393 try:
Raul Tambre09e64b42019-05-14 01:57:22 +00001394 exec(compile(script_text, 'PRESUBMIT.py', 'exec', dont_inherit=True),
1395 context)
Raul Tambre7c938462019-05-24 16:35:35 +00001396 except Exception as e:
rmistry@google.com5626a922015-02-26 14:03:30 +00001397 raise PresubmitFailure('"%s" had an exception.\n%s'
1398 % (presubmit_path, e))
1399
1400 function_name = 'PostUploadHook'
1401 if function_name not in context:
1402 return {}
1403 post_upload_hook = context[function_name]
1404 if not len(inspect.getargspec(post_upload_hook)[0]) == 3:
1405 raise PresubmitFailure(
1406 'Expected function "PostUploadHook" to take three arguments.')
Edward Lemur016a0872020-02-04 22:13:28 +00001407 return post_upload_hook(gerrit_obj, change, OutputApi(False))
rmistry@google.com5626a922015-02-26 14:03:30 +00001408
1409
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001410def _MergeMasters(masters1, masters2):
1411 """Merges two master maps. Merges also the tests of each builder."""
1412 result = {}
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001413 for (master, builders) in itertools.chain(masters1.items(),
1414 masters2.items()):
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001415 new_builders = result.setdefault(master, {})
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001416 for (builder, tests) in builders.items():
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001417 new_builders.setdefault(builder, set([])).update(tests)
1418 return result
1419
1420
1421def DoGetTryMasters(change,
1422 changed_files,
1423 repository_root,
1424 default_presubmit,
1425 project,
1426 verbose,
1427 output_stream):
1428 """Get the list of try masters from the presubmit scripts.
1429
1430 Args:
1431 changed_files: List of modified files.
1432 repository_root: The repository root.
1433 default_presubmit: A default presubmit script to execute in any case.
1434 project: Optional name of a project used in selecting trybots.
1435 verbose: Prints debug info.
1436 output_stream: A stream to write debug output to.
1437
1438 Return:
1439 Map of try masters to map of builders to set of tests.
1440 """
1441 presubmit_files = ListRelevantPresubmitFiles(changed_files, repository_root)
1442 if not presubmit_files and verbose:
Edward Lemura5799e32020-01-17 19:26:51 +00001443 output_stream.write('Warning, no PRESUBMIT.py found.\n')
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001444 results = {}
1445 executer = GetTryMastersExecuter()
1446
1447 if default_presubmit:
1448 if verbose:
Edward Lemura5799e32020-01-17 19:26:51 +00001449 output_stream.write('Running default presubmit script.\n')
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001450 fake_path = os.path.join(repository_root, 'PRESUBMIT.py')
1451 results = _MergeMasters(results, executer.ExecPresubmitScript(
1452 default_presubmit, fake_path, project, change))
1453 for filename in presubmit_files:
1454 filename = os.path.abspath(filename)
1455 if verbose:
Edward Lemura5799e32020-01-17 19:26:51 +00001456 output_stream.write('Running %s\n' % filename)
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001457 # Accept CRLF presubmit script.
1458 presubmit_script = gclient_utils.FileRead(filename, 'rU')
1459 results = _MergeMasters(results, executer.ExecPresubmitScript(
1460 presubmit_script, filename, project, change))
1461
1462 # Make sets to lists again for later JSON serialization.
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001463 for builders in results.values():
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001464 for builder in builders:
1465 builders[builder] = list(builders[builder])
1466
1467 if results and verbose:
1468 output_stream.write('%s\n' % str(results))
1469 return results
1470
1471
rmistry@google.com5626a922015-02-26 14:03:30 +00001472def DoPostUploadExecuter(change,
Edward Lemur016a0872020-02-04 22:13:28 +00001473 gerrit_obj,
Edward Lemur6eb1d322020-02-27 22:20:15 +00001474 verbose):
rmistry@google.com5626a922015-02-26 14:03:30 +00001475 """Execute the post upload hook.
1476
1477 Args:
1478 change: The Change object.
Edward Lemur016a0872020-02-04 22:13:28 +00001479 gerrit_obj: The GerritAccessor object.
rmistry@google.com5626a922015-02-26 14:03:30 +00001480 verbose: Prints debug info.
rmistry@google.com5626a922015-02-26 14:03:30 +00001481 """
1482 presubmit_files = ListRelevantPresubmitFiles(
Edward Lemur6eb1d322020-02-27 22:20:15 +00001483 change.LocalPaths(), change.RepositoryRoot())
rmistry@google.com5626a922015-02-26 14:03:30 +00001484 if not presubmit_files and verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001485 sys.stdout.write('Warning, no PRESUBMIT.py found.\n')
rmistry@google.com5626a922015-02-26 14:03:30 +00001486 results = []
1487 executer = GetPostUploadExecuter()
1488 # The root presubmit file should be executed after the ones in subdirectories.
1489 # i.e. the specific post upload hooks should run before the general ones.
1490 # Thus, reverse the order provided by ListRelevantPresubmitFiles.
1491 presubmit_files.reverse()
1492
1493 for filename in presubmit_files:
1494 filename = os.path.abspath(filename)
1495 if verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001496 sys.stdout.write('Running %s\n' % filename)
rmistry@google.com5626a922015-02-26 14:03:30 +00001497 # Accept CRLF presubmit script.
1498 presubmit_script = gclient_utils.FileRead(filename, 'rU')
1499 results.extend(executer.ExecPresubmitScript(
Edward Lemur016a0872020-02-04 22:13:28 +00001500 presubmit_script, filename, gerrit_obj, change))
rmistry@google.com5626a922015-02-26 14:03:30 +00001501
Edward Lemur6eb1d322020-02-27 22:20:15 +00001502 if not results:
1503 return 0
1504
1505 sys.stdout.write('\n')
1506 sys.stdout.write('** Post Upload Hook Messages **\n')
1507
1508 exit_code = 0
1509 for result in results:
1510 if result.fatal:
1511 exit_code = 1
1512 result.handle()
1513 sys.stdout.write('\n')
1514
1515 return exit_code
rmistry@google.com5626a922015-02-26 14:03:30 +00001516
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001517class PresubmitExecuter(object):
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001518 def __init__(self, change, committing, verbose, gerrit_obj, dry_run=None,
1519 thread_pool=None, parallel=False, gerrit_project=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001520 """
1521 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001522 change: The Change object.
agable92bec4f2016-08-24 09:27:27 -07001523 committing: True if 'git cl land' is running, False if 'git cl upload' is.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001524 gerrit_obj: provides basic Gerrit codereview functionality.
1525 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -04001526 parallel: if true, all tests reported via input_api.RunTests for all
1527 PRESUBMIT files will be run in parallel.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001528 """
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001529 self.change = change
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001530 self.committing = committing
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001531 self.gerrit = gerrit_obj
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001532 self.verbose = verbose
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001533 self.dry_run = dry_run
Daniel Cheng7227d212017-11-17 08:12:37 -08001534 self.more_cc = []
Edward Lesmes8e282792018-04-03 18:50:29 -04001535 self.thread_pool = thread_pool
1536 self.parallel = parallel
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001537 self.gerrit_project = gerrit_project
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001538
1539 def ExecPresubmitScript(self, script_text, presubmit_path):
1540 """Executes a single presubmit script.
1541
1542 Args:
1543 script_text: The text of the presubmit script.
1544 presubmit_path: The path to the presubmit file (this will be reported via
1545 input_api.PresubmitLocalPath()).
1546
1547 Return:
1548 A list of result objects, empty if no problems.
1549 """
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001550
chase@chromium.org8e416c82009-10-06 04:30:44 +00001551 # Change to the presubmit file's directory to support local imports.
1552 main_path = os.getcwd()
Saagar Sanghavi98b332f2020-07-31 17:19:15 +00001553 presubmit_dir = os.path.dirname(presubmit_path)
1554 os.chdir(presubmit_dir)
chase@chromium.org8e416c82009-10-06 04:30:44 +00001555
1556 # Load the presubmit script into context.
dpranke@chromium.org970c5222011-03-12 00:32:24 +00001557 input_api = InputApi(self.change, presubmit_path, self.committing,
Aaron Gable668c1d82018-04-03 10:19:16 -07001558 self.verbose, gerrit_obj=self.gerrit,
Edward Lesmes8e282792018-04-03 18:50:29 -04001559 dry_run=self.dry_run, thread_pool=self.thread_pool,
1560 parallel=self.parallel)
Daniel Cheng7227d212017-11-17 08:12:37 -08001561 output_api = OutputApi(self.committing)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001562 context = {}
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001563
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001564 try:
Raul Tambre09e64b42019-05-14 01:57:22 +00001565 exec(compile(script_text, 'PRESUBMIT.py', 'exec', dont_inherit=True),
1566 context)
Raul Tambre7c938462019-05-24 16:35:35 +00001567 except Exception as e:
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001568 raise PresubmitFailure('"%s" had an exception.\n%s' % (presubmit_path, e))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001569
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001570 context['__args'] = (input_api, output_api)
Ben Pastene8351dc12020-08-06 05:01:35 +00001571
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001572 # Get path of presubmit directory relative to repository root.
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001573 # Always use forward slashes, so that path is same in *nix and Windows
1574 root = input_api.change.RepositoryRoot()
1575 rel_path = os.path.relpath(presubmit_dir, root)
1576 rel_path = rel_path.replace(os.path.sep, '/')
Ben Pastene8351dc12020-08-06 05:01:35 +00001577
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001578 # Get the URL of git remote origin and use it to identify host and project
1579 host = ''
1580 if self.gerrit and self.gerrit.host:
1581 host = self.gerrit.host
1582 project = self.gerrit_project or ''
1583
1584 # Prefix for test names
1585 prefix = 'presubmit:%s/%s:%s/' % (host, project, rel_path)
1586
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001587 # Perform all the desired presubmit checks.
1588 results = []
Ben Pastene8351dc12020-08-06 05:01:35 +00001589
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001590 try:
Scott Leecc2fe9b2020-11-19 19:38:06 +00001591 version = [
1592 int(x) for x in context.get('PRESUBMIT_VERSION', '0.0.0').split('.')
1593 ]
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001594
Scott Leecc2fe9b2020-11-19 19:38:06 +00001595 with rdb_wrapper.client(prefix) as sink:
1596 if version >= [2, 0, 0]:
1597 for function_name in context:
1598 if not function_name.startswith('Check'):
1599 continue
1600 if function_name.endswith('Commit') and not self.committing:
1601 continue
1602 if function_name.endswith('Upload') and self.committing:
1603 continue
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001604 logging.debug('Running %s in %s', function_name, presubmit_path)
1605 results.extend(
Scott Leecc2fe9b2020-11-19 19:38:06 +00001606 self._run_check_function(function_name, context, sink))
1607 logging.debug('Running %s done.', function_name)
1608 self.more_cc.extend(output_api.more_cc)
1609
1610 else: # Old format
1611 if self.committing:
1612 function_name = 'CheckChangeOnCommit'
1613 else:
1614 function_name = 'CheckChangeOnUpload'
1615 if function_name in context:
1616 logging.debug('Running %s in %s', function_name, presubmit_path)
1617 results.extend(
1618 self._run_check_function(function_name, context, sink))
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001619 logging.debug('Running %s done.', function_name)
1620 self.more_cc.extend(output_api.more_cc)
1621
1622 finally:
1623 for f in input_api._named_temporary_files:
1624 os.remove(f)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001625
chase@chromium.org8e416c82009-10-06 04:30:44 +00001626 # Return the process to the original working directory.
1627 os.chdir(main_path)
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001628 return results
1629
Scott Leecc2fe9b2020-11-19 19:38:06 +00001630 def _run_check_function(self, function_name, context, sink=None):
1631 """Evaluates and returns the result of a given presubmit function.
1632
1633 If sink is given, the result of the presubmit function will be reported
1634 to the ResultSink.
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001635
1636 Args:
Scott Leecc2fe9b2020-11-19 19:38:06 +00001637 function_name: the name of the presubmit function to evaluate
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001638 context: a context dictionary in which the function will be evaluated
Scott Leecc2fe9b2020-11-19 19:38:06 +00001639 sink: an instance of ResultSink. None, by default.
1640 Returns:
1641 the result of the presubmit function call.
1642 """
1643 start_time = time_time()
1644 try:
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001645 result = eval(function_name + '(*__args)', context)
1646 self._check_result_type(result)
Scott Leecc2fe9b2020-11-19 19:38:06 +00001647 except:
1648 if sink:
1649 elapsed_time = time_time() - start_time
1650 sink.report(function_name, rdb_wrapper.STATUS_FAIL, elapsed_time)
1651 raise
1652
1653 if sink:
1654 elapsed_time = time_time() - start_time
1655 status = rdb_wrapper.STATUS_PASS
1656 if any(r.fatal for r in result):
1657 status = rdb_wrapper.STATUS_FAIL
1658 sink.report(function_name, status, elapsed_time)
1659
1660 return result
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001661
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00001662 def _check_result_type(self, result):
1663 """Helper function which ensures result is a list, and all elements are
1664 instances of OutputApi.PresubmitResult"""
1665 if not isinstance(result, (tuple, list)):
1666 raise PresubmitFailure('Presubmit functions must return a tuple or list')
1667 if not all(isinstance(res, OutputApi.PresubmitResult) for res in result):
1668 raise PresubmitFailure(
1669 'All presubmit results must be of types derived from '
1670 'output_api.PresubmitResult')
1671
1672
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001673def DoPresubmitChecks(change,
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001674 committing,
1675 verbose,
maruel@chromium.orgb0dfd352009-06-10 14:12:54 +00001676 default_presubmit,
dpranke@chromium.org970c5222011-03-12 00:32:24 +00001677 may_prompt,
Aaron Gable668c1d82018-04-03 10:19:16 -07001678 gerrit_obj,
Edward Lesmes8e282792018-04-03 18:50:29 -04001679 dry_run=None,
Debrian Figueroadd2737e2019-06-21 23:50:13 +00001680 parallel=False,
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001681 json_output=None,
1682 gerrit_project=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001683 """Runs all presubmit checks that apply to the files in the change.
1684
1685 This finds all PRESUBMIT.py files in directories enclosing the files in the
1686 change (up to the repository root) and calls the relevant entrypoint function
1687 depending on whether the change is being committed or uploaded.
1688
1689 Prints errors, warnings and notifications. Prompts the user for warnings
1690 when needed.
1691
1692 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001693 change: The Change object.
agable92bec4f2016-08-24 09:27:27 -07001694 committing: True if 'git cl land' is running, False if 'git cl upload' is.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001695 verbose: Prints debug info.
maruel@chromium.org0ff1fab2009-05-22 13:08:15 +00001696 default_presubmit: A default presubmit script to execute in any case.
Quinten Yearsley516fe7f2016-12-14 11:50:18 -08001697 may_prompt: Enable (y/n) questions on warning or error. If False,
1698 any questions are answered with yes by default.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001699 gerrit_obj: provides basic Gerrit codereview functionality.
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001700 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -04001701 parallel: if true, all tests specified by input_api.RunTests in all
1702 PRESUBMIT files will be run in parallel.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001703
1704 Return:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001705 1 if presubmit checks failed or 0 otherwise.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001706 """
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001707 old_environ = os.environ
1708 try:
1709 # Make sure python subprocesses won't generate .pyc files.
1710 os.environ = os.environ.copy()
Edward Lemurb9830242019-10-30 22:19:20 +00001711 os.environ['PYTHONDONTWRITEBYTECODE'] = '1'
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001712
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001713 if committing:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001714 sys.stdout.write('Running presubmit commit checks ...\n')
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001715 else:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001716 sys.stdout.write('Running presubmit upload checks ...\n')
Edward Lemurecc27072020-01-06 16:42:34 +00001717 start_time = time_time()
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001718 presubmit_files = ListRelevantPresubmitFiles(
agable0b65e732016-11-22 09:25:46 -08001719 change.AbsoluteLocalPaths(), change.RepositoryRoot())
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001720 if not presubmit_files and verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001721 sys.stdout.write('Warning, no PRESUBMIT.py found.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001722 results = []
Edward Lesmes8e282792018-04-03 18:50:29 -04001723 thread_pool = ThreadPool()
Edward Lemur7e3c67f2018-07-20 20:52:49 +00001724 executer = PresubmitExecuter(change, committing, verbose, gerrit_obj,
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001725 dry_run, thread_pool, parallel, gerrit_project)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001726 if default_presubmit:
1727 if verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001728 sys.stdout.write('Running default presubmit script.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001729 fake_path = os.path.join(change.RepositoryRoot(), 'PRESUBMIT.py')
1730 results += executer.ExecPresubmitScript(default_presubmit, fake_path)
1731 for filename in presubmit_files:
1732 filename = os.path.abspath(filename)
1733 if verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001734 sys.stdout.write('Running %s\n' % filename)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001735 # Accept CRLF presubmit script.
1736 presubmit_script = gclient_utils.FileRead(filename, 'rU')
1737 results += executer.ExecPresubmitScript(presubmit_script, filename)
Edward Lesmes8e282792018-04-03 18:50:29 -04001738 results += thread_pool.RunAsync()
1739
Edward Lemur6eb1d322020-02-27 22:20:15 +00001740 messages = {}
1741 should_prompt = False
1742 presubmits_failed = False
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001743 for result in results:
1744 if result.fatal:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001745 presubmits_failed = True
1746 messages.setdefault('ERRORS', []).append(result)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001747 elif result.should_prompt:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001748 should_prompt = True
1749 messages.setdefault('Warnings', []).append(result)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001750 else:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001751 messages.setdefault('Messages', []).append(result)
pam@chromium.orged9a0832009-09-09 22:48:55 +00001752
Edward Lemur6eb1d322020-02-27 22:20:15 +00001753 sys.stdout.write('\n')
1754 for name, items in messages.items():
1755 sys.stdout.write('** Presubmit %s **\n' % name)
1756 for item in items:
1757 item.handle()
1758 sys.stdout.write('\n')
pam@chromium.orged9a0832009-09-09 22:48:55 +00001759
Edward Lemurecc27072020-01-06 16:42:34 +00001760 total_time = time_time() - start_time
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001761 if total_time > 1.0:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001762 sys.stdout.write(
1763 'Presubmit checks took %.1fs to calculate.\n\n' % total_time)
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +00001764
Edward Lemur6eb1d322020-02-27 22:20:15 +00001765 if not should_prompt and not presubmits_failed:
1766 sys.stdout.write('Presubmit checks passed.\n')
1767 elif should_prompt:
1768 sys.stdout.write('There were presubmit warnings. ')
Quinten Yearsley516fe7f2016-12-14 11:50:18 -08001769 if may_prompt:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001770 presubmits_failed = not prompt_should_continue(
1771 'Are you sure you wish to continue? (y/N): ')
Garrett Beatyacb807e2020-08-28 18:17:24 +00001772 else:
1773 sys.stdout.write('\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001774
Edward Lemur1dc66e12020-02-21 21:36:34 +00001775 if json_output:
1776 # Write the presubmit results to json output
1777 presubmit_results = {
1778 'errors': [
Edward Lemur6eb1d322020-02-27 22:20:15 +00001779 error.json_format()
1780 for error in messages.get('ERRORS', [])
Edward Lemur1dc66e12020-02-21 21:36:34 +00001781 ],
1782 'notifications': [
Edward Lemur6eb1d322020-02-27 22:20:15 +00001783 notification.json_format()
1784 for notification in messages.get('Messages', [])
Edward Lemur1dc66e12020-02-21 21:36:34 +00001785 ],
1786 'warnings': [
Edward Lemur6eb1d322020-02-27 22:20:15 +00001787 warning.json_format()
1788 for warning in messages.get('Warnings', [])
Edward Lemur1dc66e12020-02-21 21:36:34 +00001789 ],
Edward Lemur6eb1d322020-02-27 22:20:15 +00001790 'more_cc': executer.more_cc,
Edward Lemur1dc66e12020-02-21 21:36:34 +00001791 }
1792
1793 gclient_utils.FileWrite(
1794 json_output, json.dumps(presubmit_results, sort_keys=True))
1795
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001796 global _ASKED_FOR_FEEDBACK
1797 # Ask for feedback one time out of 5.
1798 if (len(results) and random.randint(0, 4) == 0 and not _ASKED_FOR_FEEDBACK):
Edward Lemur6eb1d322020-02-27 22:20:15 +00001799 sys.stdout.write(
maruel@chromium.org1ce8e662014-01-14 15:23:00 +00001800 'Was the presubmit check useful? If not, run "git cl presubmit -v"\n'
1801 'to figure out which PRESUBMIT.py was run, then run git blame\n'
1802 'on the file to figure out who to ask for help.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001803 _ASKED_FOR_FEEDBACK = True
Edward Lemur6eb1d322020-02-27 22:20:15 +00001804
1805 return 1 if presubmits_failed else 0
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001806 finally:
1807 os.environ = old_environ
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001808
1809
Edward Lemur50984a62020-02-06 18:10:18 +00001810def _scan_sub_dirs(mask, recursive):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001811 if not recursive:
pgervais@chromium.orge57b09d2014-05-07 00:58:13 +00001812 return [x for x in glob.glob(mask) if x not in ('.svn', '.git')]
Lei Zhang9611c4c2017-04-04 01:41:56 -07001813
1814 results = []
1815 for root, dirs, files in os.walk('.'):
1816 if '.svn' in dirs:
1817 dirs.remove('.svn')
1818 if '.git' in dirs:
1819 dirs.remove('.git')
1820 for name in files:
1821 if fnmatch.fnmatch(name, mask):
1822 results.append(os.path.join(root, name))
1823 return results
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001824
1825
Edward Lemur50984a62020-02-06 18:10:18 +00001826def _parse_files(args, recursive):
tobiasjs2836bcf2016-08-16 04:08:16 -07001827 logging.debug('Searching for %s', args)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001828 files = []
1829 for arg in args:
Edward Lemur50984a62020-02-06 18:10:18 +00001830 files.extend([('M', f) for f in _scan_sub_dirs(arg, recursive)])
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001831 return files
1832
1833
Edward Lemur50984a62020-02-06 18:10:18 +00001834def _parse_change(parser, options):
1835 """Process change options.
1836
1837 Args:
1838 parser: The parser used to parse the arguments from command line.
1839 options: The arguments parsed from command line.
1840 Returns:
1841 A GitChange if the change root is a git repository, or a Change otherwise.
1842 """
1843 if options.files and options.all_files:
1844 parser.error('<files> cannot be specified when --all-files is set.')
1845
Edward Lesmes44ea3ff2020-02-05 00:14:30 +00001846 change_scm = scm.determine_scm(options.root)
Edward Lemur50984a62020-02-06 18:10:18 +00001847 if change_scm != 'git' and not options.files:
1848 parser.error('<files> is not optional for unversioned directories.')
1849
1850 if options.files:
1851 change_files = _parse_files(options.files, options.recursive)
1852 elif options.all_files:
1853 change_files = [('M', f) for f in scm.GIT.GetAllFiles(options.root)]
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001854 else:
Edward Lemur50984a62020-02-06 18:10:18 +00001855 change_files = scm.GIT.CaptureStatus(
Edward Lemur7f6dec02020-02-06 20:23:58 +00001856 options.root, options.upstream or None)
Edward Lemur50984a62020-02-06 18:10:18 +00001857
1858 logging.info('Found %d file(s).', len(change_files))
1859
1860 change_class = GitChange if change_scm == 'git' else Change
1861 return change_class(
1862 options.name,
1863 options.description,
1864 options.root,
1865 change_files,
1866 options.issue,
1867 options.patchset,
1868 options.author,
1869 upstream=options.upstream)
1870
1871
1872def _parse_gerrit_options(parser, options):
1873 """Process gerrit options.
1874
1875 SIDE EFFECTS: Modifies options.author and options.description from Gerrit if
1876 options.gerrit_fetch is set.
1877
1878 Args:
1879 parser: The parser used to parse the arguments from command line.
1880 options: The arguments parsed from command line.
1881 Returns:
1882 A GerritAccessor object if options.gerrit_url is set, or None otherwise.
1883 """
1884 gerrit_obj = None
1885 if options.gerrit_url:
1886 gerrit_obj = GerritAccessor(urlparse.urlparse(options.gerrit_url).netloc)
1887
1888 if not options.gerrit_fetch:
1889 return gerrit_obj
1890
1891 if not options.gerrit_url or not options.issue or not options.patchset:
1892 parser.error(
1893 '--gerrit_fetch requires --gerrit_url, --issue and --patchset.')
1894
1895 options.author = gerrit_obj.GetChangeOwner(options.issue)
1896 options.description = gerrit_obj.GetChangeDescription(
1897 options.issue, options.patchset)
1898
1899 logging.info('Got author: "%s"', options.author)
1900 logging.info('Got description: """\n%s\n"""', options.description)
1901
1902 return gerrit_obj
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001903
1904
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001905@contextlib.contextmanager
1906def canned_check_filter(method_names):
1907 filtered = {}
1908 try:
1909 for method_name in method_names:
1910 if not hasattr(presubmit_canned_checks, method_name):
Gavin Make6a62332020-12-04 21:57:10 +00001911 logging.warning('Skipping unknown "canned" check %s' % method_name)
Aaron Gableecee74c2018-04-02 15:13:08 -07001912 continue
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001913 filtered[method_name] = getattr(presubmit_canned_checks, method_name)
1914 setattr(presubmit_canned_checks, method_name, lambda *_a, **_kw: [])
1915 yield
1916 finally:
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001917 for name, method in filtered.items():
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001918 setattr(presubmit_canned_checks, name, method)
1919
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +00001920
sbc@chromium.org013731e2015-02-26 18:28:43 +00001921def main(argv=None):
Edward Lemura5799e32020-01-17 19:26:51 +00001922 parser = argparse.ArgumentParser(usage='%(prog)s [options] <files...>')
1923 hooks = parser.add_mutually_exclusive_group()
1924 hooks.add_argument('-c', '--commit', action='store_true',
1925 help='Use commit instead of upload checks.')
1926 hooks.add_argument('-u', '--upload', action='store_false', dest='commit',
1927 help='Use upload instead of commit checks.')
Edward Lemur75526302020-02-27 22:31:05 +00001928 hooks.add_argument('--post_upload', action='store_true',
1929 help='Run post-upload commit hooks.')
Edward Lemura5799e32020-01-17 19:26:51 +00001930 parser.add_argument('-r', '--recursive', action='store_true',
1931 help='Act recursively.')
1932 parser.add_argument('-v', '--verbose', action='count', default=0,
1933 help='Use 2 times for more debug info.')
1934 parser.add_argument('--name', default='no name')
1935 parser.add_argument('--author')
Edward Lemur227d5102020-02-25 23:45:35 +00001936 desc = parser.add_mutually_exclusive_group()
1937 desc.add_argument('--description', default='', help='The change description.')
1938 desc.add_argument('--description_file',
1939 help='File to read change description from.')
Edward Lemura5799e32020-01-17 19:26:51 +00001940 parser.add_argument('--issue', type=int, default=0)
1941 parser.add_argument('--patchset', type=int, default=0)
1942 parser.add_argument('--root', default=os.getcwd(),
1943 help='Search for PRESUBMIT.py up to this directory. '
1944 'If inherit-review-settings-ok is present in this '
1945 'directory, parent directories up to the root file '
1946 'system directories will also be searched.')
1947 parser.add_argument('--upstream',
1948 help='Git only: the base ref or upstream branch against '
1949 'which the diff should be computed.')
1950 parser.add_argument('--default_presubmit')
1951 parser.add_argument('--may_prompt', action='store_true', default=False)
1952 parser.add_argument('--skip_canned', action='append', default=[],
1953 help='A list of checks to skip which appear in '
1954 'presubmit_canned_checks. Can be provided multiple times '
1955 'to skip multiple canned checks.')
1956 parser.add_argument('--dry_run', action='store_true', help=argparse.SUPPRESS)
1957 parser.add_argument('--gerrit_url', help=argparse.SUPPRESS)
1958 parser.add_argument('--gerrit_fetch', action='store_true',
1959 help=argparse.SUPPRESS)
1960 parser.add_argument('--parallel', action='store_true',
1961 help='Run all tests specified by input_api.RunTests in '
1962 'all PRESUBMIT files in parallel.')
1963 parser.add_argument('--json_output',
1964 help='Write presubmit errors to json output.')
Edward Lemur1dc66e12020-02-21 21:36:34 +00001965 parser.add_argument('--all_files', action='store_true',
Edward Lemur50984a62020-02-06 18:10:18 +00001966 help='Mark all files under source control as modified.')
Edward Lemura5799e32020-01-17 19:26:51 +00001967 parser.add_argument('files', nargs='*',
1968 help='List of files to be marked as modified when '
1969 'executing presubmit or post-upload hooks. fnmatch '
1970 'wildcards can also be used.')
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001971 parser.add_argument('--gerrit_project', help=argparse.SUPPRESS)
Edward Lemura5799e32020-01-17 19:26:51 +00001972 options = parser.parse_args(argv)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001973
Erik Staabcca5c492020-04-16 17:40:07 +00001974 log_level = logging.ERROR
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001975 if options.verbose >= 2:
Erik Staabcca5c492020-04-16 17:40:07 +00001976 log_level = logging.DEBUG
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001977 elif options.verbose:
Erik Staabcca5c492020-04-16 17:40:07 +00001978 log_level = logging.INFO
1979 log_format = ('[%(levelname).1s%(asctime)s %(process)d %(thread)d '
1980 '%(filename)s] %(message)s')
1981 logging.basicConfig(format=log_format, level=log_level)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001982
Edward Lemur227d5102020-02-25 23:45:35 +00001983 if options.description_file:
1984 options.description = gclient_utils.FileRead(options.description_file)
Edward Lemur50984a62020-02-06 18:10:18 +00001985 gerrit_obj = _parse_gerrit_options(parser, options)
1986 change = _parse_change(parser, options)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001987
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001988 try:
Edward Lemur75526302020-02-27 22:31:05 +00001989 if options.post_upload:
1990 return DoPostUploadExecuter(
1991 change,
1992 gerrit_obj,
1993 options.verbose)
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001994 with canned_check_filter(options.skip_canned):
Edward Lemur6eb1d322020-02-27 22:20:15 +00001995 return DoPresubmitChecks(
Edward Lemur50984a62020-02-06 18:10:18 +00001996 change,
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001997 options.commit,
1998 options.verbose,
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001999 options.default_presubmit,
2000 options.may_prompt,
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00002001 gerrit_obj,
Edward Lesmes8e282792018-04-03 18:50:29 -04002002 options.dry_run,
Debrian Figueroadd2737e2019-06-21 23:50:13 +00002003 options.parallel,
Saagar Sanghavi531d9922020-08-10 20:14:01 +00002004 options.json_output,
2005 options.gerrit_project)
Raul Tambre7c938462019-05-24 16:35:35 +00002006 except PresubmitFailure as e:
Raul Tambre80ee78e2019-05-06 22:41:05 +00002007 print(e, file=sys.stderr)
2008 print('Maybe your depot_tools is out of date?', file=sys.stderr)
maruel@chromium.org899e1c12011-04-07 17:03:18 +00002009 return 2
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00002010
2011
2012if __name__ == '__main__':
maruel@chromium.org35625c72011-03-23 17:34:02 +00002013 fix_encoding.fix_encoding()
sbc@chromium.org013731e2015-02-26 18:28:43 +00002014 try:
2015 sys.exit(main())
2016 except KeyboardInterrupt:
2017 sys.stderr.write('interrupted\n')
sergiybf8a3b382016-07-05 11:21:30 -07002018 sys.exit(2)