blob: b7cf13afc3bf40fe49882fa55deb7ee9a8221710 [file] [log] [blame]
Josip Sokcevic4de5dea2022-03-23 21:15:14 +00001#!/usr/bin/env python3
maruel@chromium.org3bbf2942012-01-10 16:52:06 +00002# Copyright (c) 2012 The Chromium Authors. All rights reserved.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00003# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5
6"""Enables directory-specific presubmit checks to run at upload and/or commit.
7"""
8
Raul Tambre80ee78e2019-05-06 22:41:05 +00009from __future__ import print_function
10
Saagar Sanghavi99816902020-08-11 22:41:25 +000011__version__ = '2.0.0'
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000012
13# TODO(joi) Add caching where appropriate/needed. The API is designed to allow
14# caching (between all different invocations of presubmit scripts for a given
15# change). We should add it as our presubmit scripts start feeling slow.
16
Edward Lemura5799e32020-01-17 19:26:51 +000017import argparse
Takeshi Yoshino07a6bea2017-08-02 02:44:06 +090018import ast # Exposed through the API.
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +000019import contextlib
Yoshisato Yanagisawa406de132018-06-29 05:43:25 +000020import cpplint
dcheng091b7db2016-06-16 01:27:51 -070021import fnmatch # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000022import glob
asvitkine@chromium.org15169952011-09-27 14:30:53 +000023import inspect
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +000024import itertools
maruel@chromium.org4f6852c2012-04-20 20:39:20 +000025import json # Exposed through the API.
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +000026import logging
ilevy@chromium.orgbc117312013-04-20 03:57:56 +000027import multiprocessing
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000028import os # Somewhat exposed through the API.
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +000029import random
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000030import re # Exposed through the API.
Edward Lesmes8e282792018-04-03 18:50:29 -040031import signal
Allen Webbfe7d7092021-05-18 02:05:49 +000032import six
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000033import sys # Parts exposed through API.
34import tempfile # Exposed through the API.
Edward Lesmes8e282792018-04-03 18:50:29 -040035import threading
jam@chromium.org2a891dc2009-08-20 20:33:37 +000036import time
Edward Lemurde9e3ca2019-10-24 21:13:31 +000037import traceback
maruel@chromium.org1487d532009-06-06 00:22:57 +000038import unittest # Exposed through the API.
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +000039from warnings import warn
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000040
41# Local imports.
maruel@chromium.org35625c72011-03-23 17:34:02 +000042import fix_encoding
Yoshisato Yanagisawa04600b42019-03-15 03:03:41 +000043import gclient_paths # Exposed through the API
44import gclient_utils
Aaron Gableb584c4f2017-04-26 16:28:08 -070045import git_footers
tandrii@chromium.org015ebae2016-04-25 19:37:22 +000046import gerrit_util
Edward Lesmes9ce03f82021-01-12 20:13:31 +000047import owners_client
Jochen Eisinger76f5fc62017-04-07 16:27:46 +020048import owners_finder
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000049import presubmit_canned_checks
Saagar Sanghavi9949ab72020-07-20 20:56:40 +000050import rdb_wrapper
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +000051import scm
maruel@chromium.org84f4fe32011-04-06 13:26:45 +000052import subprocess2 as subprocess # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000053
Edward Lemur16af3562019-10-17 22:11:33 +000054if sys.version_info.major == 2:
55 # TODO(1009814): Expose urllib2 only through urllib_request and urllib_error
56 import urllib2 # Exposed through the API.
57 import urlparse
58 import urllib2 as urllib_request
59 import urllib2 as urllib_error
60else:
61 import urllib.parse as urlparse
62 import urllib.request as urllib_request
63 import urllib.error as urllib_error
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000064
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +000065# Ask for feedback only once in program lifetime.
66_ASKED_FOR_FEEDBACK = False
67
Edward Lemurecc27072020-01-06 16:42:34 +000068def time_time():
69 # Use this so that it can be mocked in tests without interfering with python
70 # system machinery.
71 return time.time()
72
73
maruel@chromium.org899e1c12011-04-07 17:03:18 +000074class PresubmitFailure(Exception):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000075 pass
76
77
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000078class CommandData(object):
Edward Lemur940c2822019-08-23 00:34:25 +000079 def __init__(self, name, cmd, kwargs, message, python3=False):
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000080 self.name = name
81 self.cmd = cmd
Edward Lesmes8e282792018-04-03 18:50:29 -040082 self.stdin = kwargs.get('stdin', None)
Edward Lemur2d6b67c2019-08-23 22:25:41 +000083 self.kwargs = kwargs.copy()
Edward Lesmes8e282792018-04-03 18:50:29 -040084 self.kwargs['stdout'] = subprocess.PIPE
85 self.kwargs['stderr'] = subprocess.STDOUT
86 self.kwargs['stdin'] = subprocess.PIPE
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000087 self.message = message
88 self.info = None
Edward Lemur940c2822019-08-23 00:34:25 +000089 self.python3 = python3
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000090
ilevy@chromium.orgbc117312013-04-20 03:57:56 +000091
Edward Lesmes8e282792018-04-03 18:50:29 -040092# Adapted from
93# https://github.com/google/gtest-parallel/blob/master/gtest_parallel.py#L37
94#
95# An object that catches SIGINT sent to the Python process and notices
96# if processes passed to wait() die by SIGINT (we need to look for
97# both of those cases, because pressing Ctrl+C can result in either
98# the main process or one of the subprocesses getting the signal).
99#
100# Before a SIGINT is seen, wait(p) will simply call p.wait() and
101# return the result. Once a SIGINT has been seen (in the main process
102# or a subprocess, including the one the current call is waiting for),
Edward Lemur9a5bb612019-09-26 02:01:52 +0000103# wait(p) will call p.terminate().
Edward Lesmes8e282792018-04-03 18:50:29 -0400104class SigintHandler(object):
Edward Lesmes8e282792018-04-03 18:50:29 -0400105 sigint_returncodes = {-signal.SIGINT, # Unix
106 -1073741510, # Windows
107 }
108 def __init__(self):
109 self.__lock = threading.Lock()
110 self.__processes = set()
111 self.__got_sigint = False
Edward Lemur9a5bb612019-09-26 02:01:52 +0000112 self.__previous_signal = signal.signal(signal.SIGINT, self.interrupt)
Edward Lesmes8e282792018-04-03 18:50:29 -0400113
114 def __on_sigint(self):
115 self.__got_sigint = True
116 while self.__processes:
117 try:
118 self.__processes.pop().terminate()
119 except OSError:
120 pass
121
Edward Lemur9a5bb612019-09-26 02:01:52 +0000122 def interrupt(self, signal_num, frame):
Edward Lesmes8e282792018-04-03 18:50:29 -0400123 with self.__lock:
124 self.__on_sigint()
Edward Lemur9a5bb612019-09-26 02:01:52 +0000125 self.__previous_signal(signal_num, frame)
Edward Lesmes8e282792018-04-03 18:50:29 -0400126
127 def got_sigint(self):
128 with self.__lock:
129 return self.__got_sigint
130
131 def wait(self, p, stdin):
132 with self.__lock:
133 if self.__got_sigint:
134 p.terminate()
135 self.__processes.add(p)
136 stdout, stderr = p.communicate(stdin)
137 code = p.returncode
138 with self.__lock:
139 self.__processes.discard(p)
140 if code in self.sigint_returncodes:
141 self.__on_sigint()
Edward Lesmes8e282792018-04-03 18:50:29 -0400142 return stdout, stderr
143
144sigint_handler = SigintHandler()
145
146
Edward Lemurecc27072020-01-06 16:42:34 +0000147class Timer(object):
148 def __init__(self, timeout, fn):
149 self.completed = False
150 self._fn = fn
151 self._timer = threading.Timer(timeout, self._onTimer) if timeout else None
152
153 def __enter__(self):
154 if self._timer:
155 self._timer.start()
156 return self
157
158 def __exit__(self, _type, _value, _traceback):
159 if self._timer:
160 self._timer.cancel()
161
162 def _onTimer(self):
163 self._fn()
164 self.completed = True
165
166
Edward Lesmes8e282792018-04-03 18:50:29 -0400167class ThreadPool(object):
Edward Lemurecc27072020-01-06 16:42:34 +0000168 def __init__(self, pool_size=None, timeout=None):
169 self.timeout = timeout
Edward Lesmes8e282792018-04-03 18:50:29 -0400170 self._pool_size = pool_size or multiprocessing.cpu_count()
Bruce Dawson8254f062022-06-17 17:33:08 +0000171 if sys.platform == 'win32':
172 # TODO(crbug.com/1190269) - we can't use more than 56 child processes on
173 # Windows or Python3 may hang.
174 self._pool_size = min(self._pool_size, 56)
Edward Lesmes8e282792018-04-03 18:50:29 -0400175 self._messages = []
176 self._messages_lock = threading.Lock()
177 self._tests = []
178 self._tests_lock = threading.Lock()
179 self._nonparallel_tests = []
180
Edward Lemurecc27072020-01-06 16:42:34 +0000181 def _GetCommand(self, test):
Edward Lemur940c2822019-08-23 00:34:25 +0000182 vpython = 'vpython'
183 if test.python3:
184 vpython += '3'
185 if sys.platform == 'win32':
186 vpython += '.bat'
Edward Lesmes8e282792018-04-03 18:50:29 -0400187
188 cmd = test.cmd
189 if cmd[0] == 'python':
190 cmd = list(cmd)
191 cmd[0] = vpython
192 elif cmd[0].endswith('.py'):
193 cmd = [vpython] + cmd
194
Edward Lemur336e51f2019-11-14 21:42:04 +0000195 # On Windows, scripts on the current directory take precedence over PATH, so
196 # that when testing depot_tools on Windows, calling `vpython.bat` will
197 # execute the copy of vpython of the depot_tools under test instead of the
198 # one in the bot.
199 # As a workaround, we run the tests from the parent directory instead.
200 if (cmd[0] == vpython and
201 'cwd' in test.kwargs and
202 os.path.basename(test.kwargs['cwd']) == 'depot_tools'):
203 test.kwargs['cwd'] = os.path.dirname(test.kwargs['cwd'])
204 cmd[1] = os.path.join('depot_tools', cmd[1])
205
Edward Lemurecc27072020-01-06 16:42:34 +0000206 return cmd
207
208 def _RunWithTimeout(self, cmd, stdin, kwargs):
209 p = subprocess.Popen(cmd, **kwargs)
210 with Timer(self.timeout, p.terminate) as timer:
211 stdout, _ = sigint_handler.wait(p, stdin)
Josip Sokcevic6635baf2021-11-19 02:04:39 +0000212 stdout = stdout.decode('utf-8', 'ignore')
Edward Lemurecc27072020-01-06 16:42:34 +0000213 if timer.completed:
214 stdout = 'Process timed out after %ss\n%s' % (self.timeout, stdout)
Josip Sokcevic6635baf2021-11-19 02:04:39 +0000215 return p.returncode, stdout
Edward Lemurecc27072020-01-06 16:42:34 +0000216
217 def CallCommand(self, test):
218 """Runs an external program.
219
Edward Lemura5799e32020-01-17 19:26:51 +0000220 This function converts invocation of .py files and invocations of 'python'
Edward Lemurecc27072020-01-06 16:42:34 +0000221 to vpython invocations.
222 """
223 cmd = self._GetCommand(test)
Edward Lesmes8e282792018-04-03 18:50:29 -0400224 try:
Edward Lemurecc27072020-01-06 16:42:34 +0000225 start = time_time()
226 returncode, stdout = self._RunWithTimeout(cmd, test.stdin, test.kwargs)
227 duration = time_time() - start
Edward Lemur7cf94382019-11-15 22:36:41 +0000228 except Exception:
Edward Lemurecc27072020-01-06 16:42:34 +0000229 duration = time_time() - start
Edward Lesmes8e282792018-04-03 18:50:29 -0400230 return test.message(
Edward Lemur7cf94382019-11-15 22:36:41 +0000231 '%s\n%s exec failure (%4.2fs)\n%s' % (
232 test.name, ' '.join(cmd), duration, traceback.format_exc()))
Edward Lemurde9e3ca2019-10-24 21:13:31 +0000233
Edward Lemurecc27072020-01-06 16:42:34 +0000234 if returncode != 0:
Edward Lesmes8e282792018-04-03 18:50:29 -0400235 return test.message(
Edward Lemur7cf94382019-11-15 22:36:41 +0000236 '%s\n%s (%4.2fs) failed\n%s' % (
237 test.name, ' '.join(cmd), duration, stdout))
Edward Lemurecc27072020-01-06 16:42:34 +0000238
Edward Lesmes8e282792018-04-03 18:50:29 -0400239 if test.info:
Edward Lemur7cf94382019-11-15 22:36:41 +0000240 return test.info('%s\n%s (%4.2fs)' % (test.name, ' '.join(cmd), duration))
Edward Lesmes8e282792018-04-03 18:50:29 -0400241
242 def AddTests(self, tests, parallel=True):
243 if parallel:
244 self._tests.extend(tests)
245 else:
246 self._nonparallel_tests.extend(tests)
247
248 def RunAsync(self):
249 self._messages = []
250
251 def _WorkerFn():
252 while True:
253 test = None
254 with self._tests_lock:
255 if not self._tests:
256 break
257 test = self._tests.pop()
258 result = self.CallCommand(test)
259 if result:
260 with self._messages_lock:
261 self._messages.append(result)
262
263 def _StartDaemon():
264 t = threading.Thread(target=_WorkerFn)
265 t.daemon = True
266 t.start()
267 return t
268
269 while self._nonparallel_tests:
270 test = self._nonparallel_tests.pop()
271 result = self.CallCommand(test)
272 if result:
273 self._messages.append(result)
274
275 if self._tests:
276 threads = [_StartDaemon() for _ in range(self._pool_size)]
277 for worker in threads:
278 worker.join()
279
280 return self._messages
281
282
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000283def normpath(path):
284 '''Version of os.path.normpath that also changes backward slashes to
285 forward slashes when not running on Windows.
286 '''
287 # This is safe to always do because the Windows version of os.path.normpath
288 # will replace forward slashes with backward slashes.
289 path = path.replace(os.sep, '/')
290 return os.path.normpath(path)
291
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000292
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000293def _RightHandSideLinesImpl(affected_files):
294 """Implements RightHandSideLines for InputApi and GclChange."""
295 for af in affected_files:
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000296 lines = af.ChangedContents()
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000297 for line in lines:
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000298 yield (af, line[0], line[1])
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000299
300
Edward Lemur6eb1d322020-02-27 22:20:15 +0000301def prompt_should_continue(prompt_string):
302 sys.stdout.write(prompt_string)
Dirk Pranke7288f882021-06-03 18:01:30 +0000303 sys.stdout.flush()
Edward Lemur6eb1d322020-02-27 22:20:15 +0000304 response = sys.stdin.readline().strip().lower()
305 return response in ('y', 'yes')
dpranke@chromium.org5ac21012011-03-16 02:58:25 +0000306
307
Josip Sokcevice293d3d2022-02-16 22:52:15 +0000308def _ShouldRunPresubmit(script_text, use_python3):
309 """Try to figure out whether these presubmit checks should be run under
310 python2 or python3. We need to do this without actually trying to
311 compile the text, since the text might compile in one but not the
312 other.
313
314 Args:
315 script_text: The text of the presubmit script.
316 use_python3: if true, will use python3 instead of python2 by default
317 if USE_PYTHON3 is not specified.
318
319 Return:
320 A boolean if presubmit should be executed
321 """
322 m = re.search('^USE_PYTHON3 = (True|False)$', script_text, flags=re.MULTILINE)
323 if m:
324 use_python3 = m.group(1) == 'True'
325
326 return ((sys.version_info.major == 2) and not use_python3) or \
327 ((sys.version_info.major == 3) and use_python3)
328
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000329# Top level object so multiprocessing can pickle
330# Public access through OutputApi object.
331class _PresubmitResult(object):
332 """Base class for result objects."""
333 fatal = False
334 should_prompt = False
335
336 def __init__(self, message, items=None, long_text=''):
337 """
338 message: A short one-line message to indicate errors.
339 items: A list of short strings to indicate where errors occurred.
340 long_text: multi-line text output, e.g. from another tool
341 """
Bruce Dawsondb8622b2022-04-03 15:38:12 +0000342 self._message = _PresubmitResult._ensure_str(message)
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000343 self._items = items or []
Tom McKee61c72652021-07-20 11:56:32 +0000344 self._long_text = _PresubmitResult._ensure_str(long_text.rstrip())
345
346 @staticmethod
347 def _ensure_str(val):
348 """
349 val: A "stringish" value. Can be any of str, unicode or bytes.
350 returns: A str after applying encoding/decoding as needed.
351 Assumes/uses UTF-8 for relevant inputs/outputs.
352
353 We'd prefer to use six.ensure_str but our copy of six is old :(
354 """
355 if isinstance(val, str):
356 return val
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +0000357
Tom McKee61c72652021-07-20 11:56:32 +0000358 if six.PY2 and isinstance(val, unicode):
359 return val.encode()
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +0000360
361 if six.PY3 and isinstance(val, bytes):
Tom McKee61c72652021-07-20 11:56:32 +0000362 return val.decode()
363 raise ValueError("Unknown string type %s" % type(val))
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000364
Edward Lemur6eb1d322020-02-27 22:20:15 +0000365 def handle(self):
366 sys.stdout.write(self._message)
367 sys.stdout.write('\n')
Takuto Ikutabaa7be02022-08-23 00:19:34 +0000368 for item in self._items:
Edward Lemur6eb1d322020-02-27 22:20:15 +0000369 sys.stdout.write(' ')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000370 # Write separately in case it's unicode.
Edward Lemur6eb1d322020-02-27 22:20:15 +0000371 sys.stdout.write(str(item))
Edward Lemur6eb1d322020-02-27 22:20:15 +0000372 sys.stdout.write('\n')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000373 if self._long_text:
Edward Lemur6eb1d322020-02-27 22:20:15 +0000374 sys.stdout.write('\n***************\n')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000375 # Write separately in case it's unicode.
Tom McKee61c72652021-07-20 11:56:32 +0000376 sys.stdout.write(self._long_text)
Edward Lemur6eb1d322020-02-27 22:20:15 +0000377 sys.stdout.write('\n***************\n')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000378
Debrian Figueroadd2737e2019-06-21 23:50:13 +0000379 def json_format(self):
380 return {
381 'message': self._message,
Debrian Figueroa6095d402019-06-28 18:47:18 +0000382 'items': [str(item) for item in self._items],
Debrian Figueroadd2737e2019-06-21 23:50:13 +0000383 'long_text': self._long_text,
384 'fatal': self.fatal
385 }
386
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000387
388# Top level object so multiprocessing can pickle
389# Public access through OutputApi object.
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000390class _PresubmitError(_PresubmitResult):
391 """A hard presubmit error."""
392 fatal = True
393
394
395# Top level object so multiprocessing can pickle
396# Public access through OutputApi object.
397class _PresubmitPromptWarning(_PresubmitResult):
398 """An warning that prompts the user if they want to continue."""
399 should_prompt = True
400
401
402# Top level object so multiprocessing can pickle
403# Public access through OutputApi object.
404class _PresubmitNotifyResult(_PresubmitResult):
405 """Just print something to the screen -- but it's not even a warning."""
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000406
407
408# Top level object so multiprocessing can pickle
409# Public access through OutputApi object.
410class _MailTextResult(_PresubmitResult):
411 """A warning that should be included in the review request email."""
412 def __init__(self, *args, **kwargs):
413 super(_MailTextResult, self).__init__()
414 raise NotImplementedError()
415
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000416class GerritAccessor(object):
417 """Limited Gerrit functionality for canned presubmit checks to work.
418
419 To avoid excessive Gerrit calls, caches the results.
420 """
421
Edward Lesmeseb1bd622021-03-01 19:54:07 +0000422 def __init__(self, url=None, project=None, branch=None):
423 self.host = urlparse.urlparse(url).netloc if url else None
424 self.project = project
425 self.branch = branch
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000426 self.cache = {}
Edward Lesmes8170c292021-03-19 20:04:43 +0000427 self.code_owners_enabled = None
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000428
429 def _FetchChangeDetail(self, issue):
430 # Separate function to be easily mocked in tests.
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +0100431 try:
432 return gerrit_util.GetChangeDetail(
433 self.host, str(issue),
Aaron Gable6f5a8d92017-04-18 14:49:05 -0700434 ['ALL_REVISIONS', 'DETAILED_LABELS', 'ALL_COMMITS'])
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +0100435 except gerrit_util.GerritError as e:
436 if e.http_status == 404:
437 raise Exception('Either Gerrit issue %s doesn\'t exist, or '
438 'no credentials to fetch issue details' % issue)
439 raise
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000440
441 def GetChangeInfo(self, issue):
442 """Returns labels and all revisions (patchsets) for this issue.
443
444 The result is a dictionary according to Gerrit REST Api.
445 https://gerrit-review.googlesource.com/Documentation/rest-api.html
446
447 However, API isn't very clear what's inside, so see tests for example.
448 """
449 assert issue
450 cache_key = int(issue)
451 if cache_key not in self.cache:
452 self.cache[cache_key] = self._FetchChangeDetail(issue)
453 return self.cache[cache_key]
454
455 def GetChangeDescription(self, issue, patchset=None):
456 """If patchset is none, fetches current patchset."""
457 info = self.GetChangeInfo(issue)
458 # info is a reference to cache. We'll modify it here adding description to
459 # it to the right patchset, if it is not yet there.
460
461 # Find revision info for the patchset we want.
462 if patchset is not None:
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +0000463 for rev, rev_info in info['revisions'].items():
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000464 if str(rev_info['_number']) == str(patchset):
465 break
466 else:
467 raise Exception('patchset %s doesn\'t exist in issue %s' % (
468 patchset, issue))
469 else:
470 rev = info['current_revision']
471 rev_info = info['revisions'][rev]
472
Andrii Shyshkalov9c3a4642017-01-24 17:41:22 +0100473 return rev_info['commit']['message']
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000474
Mun Yong Jang603d01e2017-12-19 16:38:30 -0800475 def GetDestRef(self, issue):
476 ref = self.GetChangeInfo(issue)['branch']
477 if not ref.startswith('refs/'):
478 # NOTE: it is possible to create 'refs/x' branch,
479 # aka 'refs/heads/refs/x'. However, this is ill-advised.
480 ref = 'refs/heads/%s' % ref
481 return ref
482
Edward Lesmes02d4b822020-11-11 00:37:35 +0000483 def _GetApproversForLabel(self, issue, label):
484 change_info = self.GetChangeInfo(issue)
485 label_info = change_info.get('labels', {}).get(label, {})
486 values = label_info.get('values', {}).keys()
487 if not values:
488 return []
489 max_value = max(int(v) for v in values)
490 return [v for v in label_info.get('all', [])
491 if v.get('value', 0) == max_value]
492
Edward Lesmesc4566172021-03-19 16:55:13 +0000493 def IsBotCommitApproved(self, issue):
494 return bool(self._GetApproversForLabel(issue, 'Bot-Commit'))
495
Edward Lesmescf49cb82020-11-11 01:08:36 +0000496 def IsOwnersOverrideApproved(self, issue):
497 return bool(self._GetApproversForLabel(issue, 'Owners-Override'))
498
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000499 def GetChangeOwner(self, issue):
500 return self.GetChangeInfo(issue)['owner']['email']
501
502 def GetChangeReviewers(self, issue, approving_only=True):
Aaron Gable8b478f02017-07-31 15:33:19 -0700503 changeinfo = self.GetChangeInfo(issue)
504 if approving_only:
Edward Lesmes02d4b822020-11-11 00:37:35 +0000505 reviewers = self._GetApproversForLabel(issue, 'Code-Review')
Aaron Gable8b478f02017-07-31 15:33:19 -0700506 else:
507 reviewers = changeinfo.get('reviewers', {}).get('REVIEWER', [])
508 return [r.get('email') for r in reviewers]
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000509
Edward Lemure4d329c2020-02-03 20:41:18 +0000510 def UpdateDescription(self, description, issue):
511 gerrit_util.SetCommitMessage(self.host, issue, description, notify='NONE')
512
Edward Lesmes8170c292021-03-19 20:04:43 +0000513 def IsCodeOwnersEnabledOnRepo(self):
514 if self.code_owners_enabled is None:
515 self.code_owners_enabled = gerrit_util.IsCodeOwnersEnabledOnRepo(
Edward Lesmes392c4072021-03-19 21:58:45 +0000516 self.host, self.project)
Edward Lesmes8170c292021-03-19 20:04:43 +0000517 return self.code_owners_enabled
518
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000519
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000520class OutputApi(object):
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000521 """An instance of OutputApi gets passed to presubmit scripts so that they
522 can output various types of results.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000523 """
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000524 PresubmitResult = _PresubmitResult
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000525 PresubmitError = _PresubmitError
526 PresubmitPromptWarning = _PresubmitPromptWarning
527 PresubmitNotifyResult = _PresubmitNotifyResult
528 MailTextResult = _MailTextResult
529
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000530 def __init__(self, is_committing):
531 self.is_committing = is_committing
Daniel Cheng7227d212017-11-17 08:12:37 -0800532 self.more_cc = []
533
534 def AppendCC(self, cc):
535 """Appends a user to cc for this change."""
536 self.more_cc.append(cc)
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000537
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000538 def PresubmitPromptOrNotify(self, *args, **kwargs):
539 """Warn the user when uploading, but only notify if committing."""
540 if self.is_committing:
541 return self.PresubmitNotifyResult(*args, **kwargs)
542 return self.PresubmitPromptWarning(*args, **kwargs)
543
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000544
545class InputApi(object):
546 """An instance of this object is passed to presubmit scripts so they can
547 know stuff about the change they're looking at.
548 """
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000549 # Method could be a function
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800550 # pylint: disable=no-self-use
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000551
maruel@chromium.org3410d912009-06-09 20:56:16 +0000552 # File extensions that are considered source files from a style guide
553 # perspective. Don't modify this list from a presubmit script!
maruel@chromium.orgc33455a2011-06-24 19:14:18 +0000554 #
555 # Files without an extension aren't included in the list. If you want to
local_bot30f774e2020-06-25 18:23:34 +0000556 # filter them as source files, add r'(^|.*?[\\\/])[^.]+$' to the allow list.
local_bot64021412020-07-08 21:05:39 +0000557 # Note that ALL CAPS files are skipped in DEFAULT_FILES_TO_SKIP below.
558 DEFAULT_FILES_TO_CHECK = (
maruel@chromium.org3410d912009-06-09 20:56:16 +0000559 # C++ and friends
Edward Lemura5799e32020-01-17 19:26:51 +0000560 r'.+\.c$', r'.+\.cc$', r'.+\.cpp$', r'.+\.h$', r'.+\.m$', r'.+\.mm$',
561 r'.+\.inl$', r'.+\.asm$', r'.+\.hxx$', r'.+\.hpp$', r'.+\.s$', r'.+\.S$',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000562 # Scripts
dpapad443d9132022-05-05 00:17:30 +0000563 r'.+\.js$', r'.+\.ts$', r'.+\.py$', r'.+\.sh$', r'.+\.rb$', r'.+\.pl$',
564 r'.+\.pm$',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000565 # Other
Edward Lemura5799e32020-01-17 19:26:51 +0000566 r'.+\.java$', r'.+\.mk$', r'.+\.am$', r'.+\.css$', r'.+\.mojom$',
567 r'.+\.fidl$'
maruel@chromium.org3410d912009-06-09 20:56:16 +0000568 )
569
570 # Path regexp that should be excluded from being considered containing source
571 # files. Don't modify this list from a presubmit script!
local_bot64021412020-07-08 21:05:39 +0000572 DEFAULT_FILES_TO_SKIP = (
Edward Lemura5799e32020-01-17 19:26:51 +0000573 r'testing_support[\\\/]google_appengine[\\\/].*',
574 r'.*\bexperimental[\\\/].*',
Kent Tamura179dd1e2018-04-26 15:07:41 +0900575 # Exclude third_party/.* but NOT third_party/{WebKit,blink}
576 # (crbug.com/539768 and crbug.com/836555).
Edward Lemura5799e32020-01-17 19:26:51 +0000577 r'.*\bthird_party[\\\/](?!(WebKit|blink)[\\\/]).*',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000578 # Output directories (just in case)
Edward Lemura5799e32020-01-17 19:26:51 +0000579 r'.*\bDebug[\\\/].*',
580 r'.*\bRelease[\\\/].*',
581 r'.*\bxcodebuild[\\\/].*',
582 r'.*\bout[\\\/].*',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000583 # All caps files like README and LICENCE.
Edward Lemura5799e32020-01-17 19:26:51 +0000584 r'.*\b[A-Z0-9_]{2,}$',
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +0000585 # SCM (can happen in dual SCM configuration). (Slightly over aggressive)
Edward Lemura5799e32020-01-17 19:26:51 +0000586 r'(|.*[\\\/])\.git[\\\/].*',
587 r'(|.*[\\\/])\.svn[\\\/].*',
maruel@chromium.org7ccb4bb2011-11-07 20:26:20 +0000588 # There is no point in processing a patch file.
Edward Lemura5799e32020-01-17 19:26:51 +0000589 r'.+\.diff$',
590 r'.+\.patch$',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000591 )
592
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000593 def __init__(self, change, presubmit_path, is_committing,
Bruce Dawson09c0c072022-05-26 20:28:58 +0000594 verbose, gerrit_obj, dry_run=None, thread_pool=None, parallel=False,
595 no_diffs=False):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000596 """Builds an InputApi object.
597
598 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000599 change: A presubmit.Change object.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000600 presubmit_path: The path to the presubmit script being processed.
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000601 is_committing: True if the change is about to be committed.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000602 gerrit_obj: provides basic Gerrit codereview functionality.
603 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -0400604 parallel: if true, all tests reported via input_api.RunTests for all
605 PRESUBMIT files will be run in parallel.
Bruce Dawson09c0c072022-05-26 20:28:58 +0000606 no_diffs: if true, implies that --files or --all was specified so some
607 checks can be skipped, and some errors will be messages.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000608 """
maruel@chromium.org9711bba2009-05-22 23:51:39 +0000609 # Version number of the presubmit_support script.
610 self.version = [int(x) for x in __version__.split('.')]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000611 self.change = change
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000612 self.is_committing = is_committing
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000613 self.gerrit = gerrit_obj
tandrii@chromium.org57bafac2016-04-28 05:09:03 +0000614 self.dry_run = dry_run
Bruce Dawson09c0c072022-05-26 20:28:58 +0000615 self.no_diffs = no_diffs
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000616
Edward Lesmes8e282792018-04-03 18:50:29 -0400617 self.parallel = parallel
618 self.thread_pool = thread_pool or ThreadPool()
619
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000620 # We expose various modules and functions as attributes of the input_api
621 # so that presubmit scripts don't have to import them.
Takeshi Yoshino07a6bea2017-08-02 02:44:06 +0900622 self.ast = ast
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000623 self.basename = os.path.basename
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000624 self.cpplint = cpplint
dcheng091b7db2016-06-16 01:27:51 -0700625 self.fnmatch = fnmatch
Yoshisato Yanagisawa04600b42019-03-15 03:03:41 +0000626 self.gclient_paths = gclient_paths
Yoshisato Yanagisawa57dd17b2019-03-22 09:10:29 +0000627 # TODO(yyanagisawa): stop exposing this when python3 become default.
628 # Since python3's tempfile has TemporaryDirectory, we do not need this.
629 self.temporary_directory = gclient_utils.temporary_directory
dpranke@chromium.org17cc2442012-10-17 21:12:09 +0000630 self.glob = glob.glob
maruel@chromium.orgfb11c7b2010-03-18 18:22:14 +0000631 self.json = json
maruel@chromium.org6fba34d2011-06-02 13:45:12 +0000632 self.logging = logging.getLogger('PRESUBMIT')
maruel@chromium.org2b5ce562011-03-31 16:15:44 +0000633 self.os_listdir = os.listdir
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000634 self.os_path = os.path
pgervais@chromium.orgbd0cace2014-10-02 23:23:46 +0000635 self.os_stat = os.stat
Yoshisato Yanagisawa406de132018-06-29 05:43:25 +0000636 self.os_walk = os.walk
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000637 self.re = re
638 self.subprocess = subprocess
Edward Lemurb9830242019-10-30 22:19:20 +0000639 self.sys = sys
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000640 self.tempfile = tempfile
dpranke@chromium.org0d1bdea2011-03-24 22:54:38 +0000641 self.time = time
maruel@chromium.org1487d532009-06-06 00:22:57 +0000642 self.unittest = unittest
Edward Lemurb9830242019-10-30 22:19:20 +0000643 if sys.version_info.major == 2:
644 self.urllib2 = urllib2
Edward Lemur16af3562019-10-17 22:11:33 +0000645 self.urllib_request = urllib_request
646 self.urllib_error = urllib_error
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000647
Robert Iannucci50258932018-03-19 10:30:59 -0700648 self.is_windows = sys.platform == 'win32'
649
Edward Lemurb9646622019-10-25 20:57:35 +0000650 # Set python_executable to 'vpython' in order to allow scripts in other
651 # repos (e.g. src.git) to automatically pick up that repo's .vpython file,
652 # instead of inheriting the one in depot_tools.
653 self.python_executable = 'vpython'
Erik Staab69135d12021-05-14 22:31:57 +0000654 # Offer a python 3 executable for use during the migration off of python 2.
655 self.python3_executable = 'vpython3'
maruel@chromium.orgc0b22972009-06-25 16:19:14 +0000656 self.environ = os.environ
657
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000658 # InputApi.platform is the platform you're currently running on.
659 self.platform = sys.platform
660
iannucci@chromium.org0af3bb32015-06-12 20:44:35 +0000661 self.cpu_count = multiprocessing.cpu_count()
Bruce Dawson8254f062022-06-17 17:33:08 +0000662 if self.is_windows:
663 # TODO(crbug.com/1190269) - we can't use more than 56 child processes on
664 # Windows or Python3 may hang.
665 self.cpu_count = min(self.cpu_count, 56)
iannucci@chromium.org0af3bb32015-06-12 20:44:35 +0000666
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000667 # The local path of the currently-being-processed presubmit script.
maruel@chromium.org3d235242009-05-15 12:40:48 +0000668 self._current_presubmit_path = os.path.dirname(presubmit_path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000669
670 # We carry the canned checks so presubmit scripts can easily use them.
671 self.canned_checks = presubmit_canned_checks
672
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +0100673 # Temporary files we must manually remove at the end of a run.
674 self._named_temporary_files = []
Jochen Eisinger72606f82017-04-04 10:44:18 +0200675
Edward Lesmesdc11c6b2021-03-19 19:22:05 +0000676 self.owners_client = None
Bruce Dawsoneb8426e2022-08-05 23:58:15 +0000677 if self.gerrit and not 'PRESUBMIT_SKIP_NETWORK' in self.environ:
Bruce Dawson9b9f4512022-04-27 00:56:52 +0000678 try:
679 self.owners_client = owners_client.GetCodeOwnersClient(
Bruce Dawson9b9f4512022-04-27 00:56:52 +0000680 host=self.gerrit.host,
681 project=self.gerrit.project,
682 branch=self.gerrit.branch)
683 except Exception as e:
684 print('Failed to set owners_client - %s' % str(e))
Jochen Eisinger76f5fc62017-04-07 16:27:46 +0200685 self.owners_finder = owners_finder.OwnersFinder
maruel@chromium.org899e1c12011-04-07 17:03:18 +0000686 self.verbose = verbose
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000687 self.Command = CommandData
dpranke@chromium.org2a009622011-03-01 02:43:31 +0000688
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000689 # Replace <hash_map> and <hash_set> as headers that need to be included
Edward Lemura5799e32020-01-17 19:26:51 +0000690 # with 'base/containers/hash_tables.h' instead.
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000691 # Access to a protected member _XX of a client class
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800692 # pylint: disable=protected-access
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000693 self.cpplint._re_pattern_templates = [
danakj@chromium.org18278522013-06-11 22:42:32 +0000694 (a, b, 'base/containers/hash_tables.h')
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000695 if header in ('<hash_map>', '<hash_set>') else (a, b, header)
696 for (a, b, header) in cpplint._re_pattern_templates
697 ]
698
Edward Lemurecc27072020-01-06 16:42:34 +0000699 def SetTimeout(self, timeout):
700 self.thread_pool.timeout = timeout
701
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000702 def PresubmitLocalPath(self):
703 """Returns the local path of the presubmit script currently being run.
704
705 This is useful if you don't want to hard-code absolute paths in the
706 presubmit script. For example, It can be used to find another file
707 relative to the PRESUBMIT.py script, so the whole tree can be branched and
708 the presubmit script still works, without editing its content.
709 """
maruel@chromium.org3d235242009-05-15 12:40:48 +0000710 return self._current_presubmit_path
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000711
agable0b65e732016-11-22 09:25:46 -0800712 def AffectedFiles(self, include_deletes=True, file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000713 """Same as input_api.change.AffectedFiles() except only lists files
714 (and optionally directories) in the same directory as the current presubmit
Bruce Dawson7a0b07a2020-04-23 17:14:40 +0000715 script, or subdirectories thereof. Note that files are listed using the OS
716 path separator, so backslashes are used as separators on Windows.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000717 """
Bruce Dawson31bfd512022-05-10 23:19:39 +0000718 dir_with_slash = normpath(self.PresubmitLocalPath())
719 # normpath strips trailing path separators, so the trailing separator has to
720 # be added after the normpath call.
721 if len(dir_with_slash) > 0:
722 dir_with_slash += os.path.sep
sail@chromium.org5538e022011-05-12 17:53:16 +0000723
Edward Lemurb9830242019-10-30 22:19:20 +0000724 return list(filter(
maruel@chromium.org4661e0c2009-06-04 00:45:26 +0000725 lambda x: normpath(x.AbsoluteLocalPath()).startswith(dir_with_slash),
Edward Lemurb9830242019-10-30 22:19:20 +0000726 self.change.AffectedFiles(include_deletes, file_filter)))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000727
agable0b65e732016-11-22 09:25:46 -0800728 def LocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000729 """Returns local paths of input_api.AffectedFiles()."""
agable0b65e732016-11-22 09:25:46 -0800730 paths = [af.LocalPath() for af in self.AffectedFiles()]
Edward Lemura5799e32020-01-17 19:26:51 +0000731 logging.debug('LocalPaths: %s', paths)
pgervais@chromium.org2f64f782014-04-25 00:12:33 +0000732 return paths
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000733
agable0b65e732016-11-22 09:25:46 -0800734 def AbsoluteLocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000735 """Returns absolute local paths of input_api.AffectedFiles()."""
agable0b65e732016-11-22 09:25:46 -0800736 return [af.AbsoluteLocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000737
John Budorick16162372018-04-18 10:39:53 -0700738 def AffectedTestableFiles(self, include_deletes=None, **kwargs):
agable0b65e732016-11-22 09:25:46 -0800739 """Same as input_api.change.AffectedTestableFiles() except only lists files
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000740 in the same directory as the current presubmit script, or subdirectories
741 thereof.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000742 """
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000743 if include_deletes is not None:
Edward Lemura5799e32020-01-17 19:26:51 +0000744 warn('AffectedTestableFiles(include_deletes=%s)'
745 ' is deprecated and ignored' % str(include_deletes),
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000746 category=DeprecationWarning,
747 stacklevel=2)
Josip Sokcevic4de5dea2022-03-23 21:15:14 +0000748 # pylint: disable=consider-using-generator
749 return [
750 x for x in self.AffectedFiles(include_deletes=False, **kwargs)
751 if x.IsTestableFile()
752 ]
agable0b65e732016-11-22 09:25:46 -0800753
754 def AffectedTextFiles(self, include_deletes=None):
755 """An alias to AffectedTestableFiles for backwards compatibility."""
756 return self.AffectedTestableFiles(include_deletes=include_deletes)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000757
Josip Sokcevic8c955952021-02-01 21:32:57 +0000758 def FilterSourceFile(self,
759 affected_file,
760 files_to_check=None,
761 files_to_skip=None,
762 allow_list=None,
763 block_list=None):
Edward Lemura5799e32020-01-17 19:26:51 +0000764 """Filters out files that aren't considered 'source file'.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000765
local_bot64021412020-07-08 21:05:39 +0000766 If files_to_check or files_to_skip is None, InputApi.DEFAULT_FILES_TO_CHECK
767 and InputApi.DEFAULT_FILES_TO_SKIP is used respectively.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000768
769 The lists will be compiled as regular expression and
770 AffectedFile.LocalPath() needs to pass both list.
771
772 Note: Copy-paste this function to suit your needs or use a lambda function.
773 """
local_bot64021412020-07-08 21:05:39 +0000774 if files_to_check is None:
775 files_to_check = self.DEFAULT_FILES_TO_CHECK
776 if files_to_skip is None:
777 files_to_skip = self.DEFAULT_FILES_TO_SKIP
local_bot30f774e2020-06-25 18:23:34 +0000778
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000779 def Find(affected_file, items):
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000780 local_path = affected_file.LocalPath()
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000781 for item in items:
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +0000782 if self.re.match(item, local_path):
maruel@chromium.org3410d912009-06-09 20:56:16 +0000783 return True
Bruce Dawsona3a014e2022-04-27 23:28:17 +0000784 # Handle the cases where the files regex only handles /, but the local
785 # path uses \.
786 if self.is_windows and self.re.match(item, local_path.replace(
787 '\\', '/')):
788 return True
maruel@chromium.org3410d912009-06-09 20:56:16 +0000789 return False
local_bot64021412020-07-08 21:05:39 +0000790 return (Find(affected_file, files_to_check) and
791 not Find(affected_file, files_to_skip))
maruel@chromium.org3410d912009-06-09 20:56:16 +0000792
793 def AffectedSourceFiles(self, source_file):
agable0b65e732016-11-22 09:25:46 -0800794 """Filter the list of AffectedTestableFiles by the function source_file.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000795
796 If source_file is None, InputApi.FilterSourceFile() is used.
797 """
798 if not source_file:
799 source_file = self.FilterSourceFile
Edward Lemurb9830242019-10-30 22:19:20 +0000800 return list(filter(source_file, self.AffectedTestableFiles()))
maruel@chromium.org3410d912009-06-09 20:56:16 +0000801
802 def RightHandSideLines(self, source_file_filter=None):
Edward Lemura5799e32020-01-17 19:26:51 +0000803 """An iterator over all text lines in 'new' version of changed files.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000804
805 Only lists lines from new or modified text files in the change that are
806 contained by the directory of the currently executing presubmit script.
807
808 This is useful for doing line-by-line regex checks, like checking for
809 trailing whitespace.
810
811 Yields:
812 a 3 tuple:
813 the AffectedFile instance of the current file;
814 integer line number (1-based); and
815 the contents of the line as a string.
maruel@chromium.org1487d532009-06-06 00:22:57 +0000816
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000817 Note: The carriage return (LF or CR) is stripped off.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000818 """
maruel@chromium.org3410d912009-06-09 20:56:16 +0000819 files = self.AffectedSourceFiles(source_file_filter)
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000820 return _RightHandSideLinesImpl(files)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000821
maruel@chromium.orge3608df2009-11-10 20:22:57 +0000822 def ReadFile(self, file_item, mode='r'):
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000823 """Reads an arbitrary file.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000824
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000825 Deny reading anything outside the repository.
826 """
maruel@chromium.orge3608df2009-11-10 20:22:57 +0000827 if isinstance(file_item, AffectedFile):
828 file_item = file_item.AbsoluteLocalPath()
829 if not file_item.startswith(self.change.RepositoryRoot()):
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000830 raise IOError('Access outside the repository root is denied.')
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +0000831 return gclient_utils.FileRead(file_item, mode)
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000832
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +0100833 def CreateTemporaryFile(self, **kwargs):
834 """Returns a named temporary file that must be removed with a call to
835 RemoveTemporaryFiles().
836
837 All keyword arguments are forwarded to tempfile.NamedTemporaryFile(),
838 except for |delete|, which is always set to False.
839
840 Presubmit checks that need to create a temporary file and pass it for
841 reading should use this function instead of NamedTemporaryFile(), as
842 Windows fails to open a file that is already open for writing.
843
844 with input_api.CreateTemporaryFile() as f:
845 f.write('xyz')
846 f.close()
847 input_api.subprocess.check_output(['script-that', '--reads-from',
848 f.name])
849
850
851 Note that callers of CreateTemporaryFile() should not worry about removing
852 any temporary file; this is done transparently by the presubmit handling
853 code.
854 """
855 if 'delete' in kwargs:
856 # Prevent users from passing |delete|; we take care of file deletion
857 # ourselves and this prevents unintuitive error messages when we pass
858 # delete=False and 'delete' is also in kwargs.
859 raise TypeError('CreateTemporaryFile() does not take a "delete" '
860 'argument, file deletion is handled automatically by '
861 'the same presubmit_support code that creates InputApi '
862 'objects.')
863 temp_file = self.tempfile.NamedTemporaryFile(delete=False, **kwargs)
864 self._named_temporary_files.append(temp_file.name)
865 return temp_file
866
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000867 @property
868 def tbr(self):
869 """Returns if a change is TBR'ed."""
Jeremy Romandce22502017-06-20 15:37:29 -0400870 return 'TBR' in self.change.tags or self.change.TBRsFromDescription()
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000871
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +0000872 def RunTests(self, tests_mix, parallel=True):
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000873 tests = []
874 msgs = []
875 for t in tests_mix:
Edward Lesmes8e282792018-04-03 18:50:29 -0400876 if isinstance(t, OutputApi.PresubmitResult) and t:
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000877 msgs.append(t)
878 else:
879 assert issubclass(t.message, _PresubmitResult)
880 tests.append(t)
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +0000881 if self.verbose:
882 t.info = _PresubmitNotifyResult
Edward Lemur1037c742018-05-01 18:56:04 -0400883 if not t.kwargs.get('cwd'):
884 t.kwargs['cwd'] = self.PresubmitLocalPath()
Edward Lesmes8e282792018-04-03 18:50:29 -0400885 self.thread_pool.AddTests(tests, parallel)
Edward Lemur21000eb2019-05-24 23:25:58 +0000886 # When self.parallel is True (i.e. --parallel is passed as an option)
887 # RunTests doesn't actually run tests. It adds them to a ThreadPool that
888 # will run all tests once all PRESUBMIT files are processed.
889 # Otherwise, it will run them and return the results.
890 if not self.parallel:
Edward Lesmes8e282792018-04-03 18:50:29 -0400891 msgs.extend(self.thread_pool.RunAsync())
892 return msgs
scottmg86099d72016-09-01 09:16:51 -0700893
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000894
nick@chromium.orgff526192013-06-10 19:30:26 +0000895class _DiffCache(object):
896 """Caches diffs retrieved from a particular SCM."""
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000897 def __init__(self, upstream=None):
898 """Stores the upstream revision against which all diffs will be computed."""
899 self._upstream = upstream
nick@chromium.orgff526192013-06-10 19:30:26 +0000900
901 def GetDiff(self, path, local_root):
902 """Get the diff for a particular path."""
903 raise NotImplementedError()
904
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700905 def GetOldContents(self, path, local_root):
906 """Get the old version for a particular path."""
907 raise NotImplementedError()
908
nick@chromium.orgff526192013-06-10 19:30:26 +0000909
nick@chromium.orgff526192013-06-10 19:30:26 +0000910class _GitDiffCache(_DiffCache):
911 """DiffCache implementation for git; gets all file diffs at once."""
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000912 def __init__(self, upstream):
913 super(_GitDiffCache, self).__init__(upstream=upstream)
nick@chromium.orgff526192013-06-10 19:30:26 +0000914 self._diffs_by_file = None
915
916 def GetDiff(self, path, local_root):
Bruce Dawson5f63d3c2022-04-19 17:02:36 +0000917 # Compare against None to distinguish between None and an initialized but
918 # empty dictionary.
919 if self._diffs_by_file == None:
nick@chromium.orgff526192013-06-10 19:30:26 +0000920 # Compute a single diff for all files and parse the output; should
921 # with git this is much faster than computing one diff for each file.
922 diffs = {}
923
924 # Don't specify any filenames below, because there are command line length
925 # limits on some platforms and GenerateDiff would fail.
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000926 unified_diff = scm.GIT.GenerateDiff(local_root, files=[], full_move=True,
927 branch=self._upstream)
nick@chromium.orgff526192013-06-10 19:30:26 +0000928
929 # This regex matches the path twice, separated by a space. Note that
930 # filename itself may contain spaces.
931 file_marker = re.compile('^diff --git (?P<filename>.*) (?P=filename)$')
932 current_diff = []
933 keep_line_endings = True
934 for x in unified_diff.splitlines(keep_line_endings):
935 match = file_marker.match(x)
936 if match:
937 # Marks the start of a new per-file section.
938 diffs[match.group('filename')] = current_diff = [x]
939 elif x.startswith('diff --git'):
940 raise PresubmitFailure('Unexpected diff line: %s' % x)
941 else:
942 current_diff.append(x)
943
944 self._diffs_by_file = dict(
945 (normpath(path), ''.join(diff)) for path, diff in diffs.items())
946
947 if path not in self._diffs_by_file:
Josip Sokcevicc1ab7342022-02-24 19:02:44 +0000948 # SCM didn't have any diff on this file. It could be that the file was not
949 # modified at all (e.g. user used --all flag in git cl presubmit).
950 # Intead of failing, return empty string.
951 # See: https://crbug.com/808346.
Josip Sokcevicc1ab7342022-02-24 19:02:44 +0000952 return ''
nick@chromium.orgff526192013-06-10 19:30:26 +0000953
954 return self._diffs_by_file[path]
955
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700956 def GetOldContents(self, path, local_root):
957 return scm.GIT.GetOldContents(local_root, path, branch=self._upstream)
958
nick@chromium.orgff526192013-06-10 19:30:26 +0000959
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000960class AffectedFile(object):
961 """Representation of a file in a change."""
nick@chromium.orgff526192013-06-10 19:30:26 +0000962
963 DIFF_CACHE = _DiffCache
964
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000965 # Method could be a function
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800966 # pylint: disable=no-self-use
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000967 def __init__(self, path, action, repository_root, diff_cache):
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000968 self._path = path
969 self._action = action
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000970 self._local_root = repository_root
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000971 self._is_directory = None
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000972 self._cached_changed_contents = None
973 self._cached_new_contents = None
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000974 self._diff_cache = diff_cache
tobiasjs2836bcf2016-08-16 04:08:16 -0700975 logging.debug('%s(%s)', self.__class__.__name__, self._path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000976
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000977 def LocalPath(self):
978 """Returns the path of this file on the local disk relative to client root.
Andrew Grieve92b8b992017-11-02 09:42:24 -0400979
980 This should be used for error messages but not for accessing files,
981 because presubmit checks are run with CWD=PresubmitLocalPath() (which is
982 often != client root).
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000983 """
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000984 return normpath(self._path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000985
986 def AbsoluteLocalPath(self):
987 """Returns the absolute path of this file on the local disk.
988 """
chase@chromium.org8e416c82009-10-06 04:30:44 +0000989 return os.path.abspath(os.path.join(self._local_root, self.LocalPath()))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000990
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000991 def Action(self):
992 """Returns the action on this opened file, e.g. A, M, D, etc."""
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000993 return self._action
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000994
agable0b65e732016-11-22 09:25:46 -0800995 def IsTestableFile(self):
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000996 """Returns True if the file is a text file and not a binary file.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000997
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000998 Deleted files are not text file."""
maruel@chromium.org1e08c002009-05-28 19:09:33 +0000999 raise NotImplementedError() # Implement when needed
1000
agable0b65e732016-11-22 09:25:46 -08001001 def IsTextFile(self):
1002 """An alias to IsTestableFile for backwards compatibility."""
1003 return self.IsTestableFile()
1004
Daniel Cheng7a1f04d2017-03-21 19:12:31 -07001005 def OldContents(self):
1006 """Returns an iterator over the lines in the old version of file.
1007
Daniel Cheng2da34fe2017-03-21 20:42:12 -07001008 The old version is the file before any modifications in the user's
Edward Lemura5799e32020-01-17 19:26:51 +00001009 workspace, i.e. the 'left hand side'.
Daniel Cheng7a1f04d2017-03-21 19:12:31 -07001010
1011 Contents will be empty if the file is a directory or does not exist.
1012 Note: The carriage returns (LF or CR) are stripped off.
1013 """
1014 return self._diff_cache.GetOldContents(self.LocalPath(),
1015 self._local_root).splitlines()
1016
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001017 def NewContents(self):
1018 """Returns an iterator over the lines in the new version of file.
1019
Edward Lemura5799e32020-01-17 19:26:51 +00001020 The new version is the file in the user's workspace, i.e. the 'right hand
1021 side'.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001022
1023 Contents will be empty if the file is a directory or does not exist.
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +00001024 Note: The carriage returns (LF or CR) are stripped off.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001025 """
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +00001026 if self._cached_new_contents is None:
1027 self._cached_new_contents = []
agable0b65e732016-11-22 09:25:46 -08001028 try:
1029 self._cached_new_contents = gclient_utils.FileRead(
1030 self.AbsoluteLocalPath(), 'rU').splitlines()
1031 except IOError:
1032 pass # File not found? That's fine; maybe it was deleted.
Greg Thompson30cde452021-06-01 16:38:47 +00001033 except UnicodeDecodeError as e:
Dirk Pranke6fc394f2021-05-26 23:25:14 +00001034 # log the filename since we're probably trying to read a binary
1035 # file, and shouldn't be.
1036 print('Error reading %s: %s' % (self.AbsoluteLocalPath(), e))
1037 raise
1038
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +00001039 return self._cached_new_contents[:]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001040
Bruce Dawsonf0bcfdd2021-05-21 18:10:23 +00001041 def ChangedContents(self, keeplinebreaks=False):
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001042 """Returns a list of tuples (line number, line text) of all new lines.
1043
1044 This relies on the scm diff output describing each changed code section
1045 with a line of the form
1046
1047 ^@@ <old line num>,<old size> <new line num>,<new size> @@$
1048 """
Bruce Dawsonf0bcfdd2021-05-21 18:10:23 +00001049 # Don't return cached results when line breaks are requested.
1050 if not keeplinebreaks and self._cached_changed_contents is not None:
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +00001051 return self._cached_changed_contents[:]
Bruce Dawsonf0bcfdd2021-05-21 18:10:23 +00001052 result = []
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001053 line_num = 0
1054
Bruce Dawsonf0bcfdd2021-05-21 18:10:23 +00001055 # The keeplinebreaks parameter to splitlines must be True or else the
1056 # CheckForWindowsLineEndings presubmit will be a NOP.
1057 for line in self.GenerateScmDiff().splitlines(keeplinebreaks):
Edward Lemurac5c55f2020-02-29 00:17:16 +00001058 m = re.match(r'^@@ [0-9\,\+\-]+ \+([0-9]+)\,[0-9]+ @@', line)
1059 if m:
1060 line_num = int(m.groups(1)[0])
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001061 continue
1062 if line.startswith('+') and not line.startswith('++'):
Bruce Dawsonf0bcfdd2021-05-21 18:10:23 +00001063 result.append((line_num, line[1:]))
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001064 if not line.startswith('-'):
1065 line_num += 1
Bruce Dawsonf0bcfdd2021-05-21 18:10:23 +00001066 # Don't cache results with line breaks.
1067 if keeplinebreaks:
1068 return result;
1069 self._cached_changed_contents = result
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +00001070 return self._cached_changed_contents[:]
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001071
maruel@chromium.org5de13972009-06-10 18:16:06 +00001072 def __str__(self):
1073 return self.LocalPath()
1074
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001075 def GenerateScmDiff(self):
nick@chromium.orgff526192013-06-10 19:30:26 +00001076 return self._diff_cache.GetDiff(self.LocalPath(), self._local_root)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001077
maruel@chromium.org58407af2011-04-12 23:15:57 +00001078
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001079class GitAffectedFile(AffectedFile):
1080 """Representation of a file in a change out of a git checkout."""
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +00001081 # Method 'NNN' is abstract in class 'NNN' but is not overridden
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -08001082 # pylint: disable=abstract-method
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001083
nick@chromium.orgff526192013-06-10 19:30:26 +00001084 DIFF_CACHE = _GitDiffCache
1085
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001086 def __init__(self, *args, **kwargs):
1087 AffectedFile.__init__(self, *args, **kwargs)
1088 self._server_path = None
agable0b65e732016-11-22 09:25:46 -08001089 self._is_testable_file = None
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001090
agable0b65e732016-11-22 09:25:46 -08001091 def IsTestableFile(self):
1092 if self._is_testable_file is None:
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001093 if self.Action() == 'D':
agable0b65e732016-11-22 09:25:46 -08001094 # A deleted file is not testable.
1095 self._is_testable_file = False
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001096 else:
agable0b65e732016-11-22 09:25:46 -08001097 self._is_testable_file = os.path.isfile(self.AbsoluteLocalPath())
1098 return self._is_testable_file
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001099
maruel@chromium.orgc1938752011-04-12 23:11:13 +00001100
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001101class Change(object):
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001102 """Describe a change.
1103
1104 Used directly by the presubmit scripts to query the current change being
1105 tested.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +00001106
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001107 Instance members:
nick@chromium.orgff526192013-06-10 19:30:26 +00001108 tags: Dictionary of KEY=VALUE pairs found in the change description.
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001109 self.KEY: equivalent to tags['KEY']
1110 """
1111
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001112 _AFFECTED_FILES = AffectedFile
1113
Edward Lemura5799e32020-01-17 19:26:51 +00001114 # Matches key/value (or 'tag') lines in changelist descriptions.
maruel@chromium.org428342a2011-11-10 15:46:33 +00001115 TAG_LINE_RE = re.compile(
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001116 '^[ \t]*(?P<key>[A-Z][A-Z_0-9]*)[ \t]*=[ \t]*(?P<value>.*?)[ \t]*$')
maruel@chromium.orgc1938752011-04-12 23:11:13 +00001117 scm = ''
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001118
maruel@chromium.org58407af2011-04-12 23:15:57 +00001119 def __init__(
agable@chromium.orgea84ef12014-04-30 19:55:12 +00001120 self, name, description, local_root, files, issue, patchset, author,
1121 upstream=None):
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001122 if files is None:
1123 files = []
1124 self._name = name
chase@chromium.org8e416c82009-10-06 04:30:44 +00001125 # Convert root into an absolute path.
1126 self._local_root = os.path.abspath(local_root)
agable@chromium.orgea84ef12014-04-30 19:55:12 +00001127 self._upstream = upstream
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001128 self.issue = issue
1129 self.patchset = patchset
maruel@chromium.org58407af2011-04-12 23:15:57 +00001130 self.author_email = author
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001131
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001132 self._full_description = ''
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001133 self.tags = {}
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001134 self._description_without_tags = ''
1135 self.SetDescriptionText(description)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001136
maruel@chromium.orge085d812011-10-10 19:49:15 +00001137 assert all(
1138 (isinstance(f, (list, tuple)) and len(f) == 2) for f in files), files
1139
agable@chromium.orgea84ef12014-04-30 19:55:12 +00001140 diff_cache = self._AFFECTED_FILES.DIFF_CACHE(self._upstream)
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001141 self._affected_files = [
nick@chromium.orgff526192013-06-10 19:30:26 +00001142 self._AFFECTED_FILES(path, action.strip(), self._local_root, diff_cache)
1143 for action, path in files
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +00001144 ]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001145
Edward Lesmes9ce03f82021-01-12 20:13:31 +00001146 def UpstreamBranch(self):
1147 """Returns the upstream branch for the change."""
1148 return self._upstream
1149
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001150 def Name(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001151 """Returns the change name."""
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001152 return self._name
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001153
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001154 def DescriptionText(self):
1155 """Returns the user-entered changelist description, minus tags.
1156
Edward Lemura5799e32020-01-17 19:26:51 +00001157 Any line in the user-provided description starting with e.g. 'FOO='
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001158 (whitespace permitted before and around) is considered a tag line. Such
1159 lines are stripped out of the description this function returns.
1160 """
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001161 return self._description_without_tags
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001162
1163 def FullDescriptionText(self):
1164 """Returns the complete changelist description including tags."""
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001165 return self._full_description
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001166
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001167 def SetDescriptionText(self, description):
1168 """Sets the full description text (including tags) to |description|.
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001169
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001170 Also updates the list of tags."""
1171 self._full_description = description
1172
1173 # From the description text, build up a dictionary of key/value pairs
Edward Lemura5799e32020-01-17 19:26:51 +00001174 # plus the description minus all key/value or 'tag' lines.
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001175 description_without_tags = []
1176 self.tags = {}
1177 for line in self._full_description.splitlines():
1178 m = self.TAG_LINE_RE.match(line)
1179 if m:
1180 self.tags[m.group('key')] = m.group('value')
1181 else:
1182 description_without_tags.append(line)
1183
1184 # Change back to text and remove whitespace at end.
1185 self._description_without_tags = (
1186 '\n'.join(description_without_tags).rstrip())
1187
Edward Lemur69bb8be2020-02-03 20:37:38 +00001188 def AddDescriptionFooter(self, key, value):
1189 """Adds the given footer to the change description.
1190
1191 Args:
1192 key: A string with the key for the git footer. It must conform to
1193 the git footers format (i.e. 'List-Of-Tokens') and will be case
1194 normalized so that each token is title-cased.
1195 value: A string with the value for the git footer.
1196 """
1197 description = git_footers.add_footer(
1198 self.FullDescriptionText(), git_footers.normalize_name(key), value)
1199 self.SetDescriptionText(description)
1200
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001201 def RepositoryRoot(self):
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001202 """Returns the repository (checkout) root directory for this change,
1203 as an absolute path.
1204 """
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001205 return self._local_root
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001206
1207 def __getattr__(self, attr):
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001208 """Return tags directly as attributes on the object."""
Edward Lemura5799e32020-01-17 19:26:51 +00001209 if not re.match(r'^[A-Z_]*$', attr):
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001210 raise AttributeError(self, attr)
maruel@chromium.orge1a524f2009-05-27 14:43:46 +00001211 return self.tags.get(attr)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001212
Edward Lemur69bb8be2020-02-03 20:37:38 +00001213 def GitFootersFromDescription(self):
1214 """Return the git footers present in the description.
1215
1216 Returns:
1217 footers: A dict of {footer: [values]} containing a multimap of the footers
1218 in the change description.
1219 """
1220 return git_footers.parse_footers(self.FullDescriptionText())
1221
Aaron Gablefc03e672017-05-15 14:09:42 -07001222 def BugsFromDescription(self):
1223 """Returns all bugs referenced in the commit description."""
Sean McAllister1e509c52021-10-25 17:54:25 +00001224 bug_tags = ['BUG', 'FIXED']
1225
1226 tags = []
1227 for tag in bug_tags:
1228 values = self.tags.get(tag)
1229 if values:
1230 tags += [value.strip() for value in values.split(',')]
1231
Caleb Rouleauc0546b92019-02-22 06:12:57 +00001232 footers = []
Edward Lemur69bb8be2020-02-03 20:37:38 +00001233 parsed = self.GitFootersFromDescription()
Dan Beam62954042019-10-03 21:20:33 +00001234 unsplit_footers = parsed.get('Bug', []) + parsed.get('Fixed', [])
Caleb Rouleauc0546b92019-02-22 06:12:57 +00001235 for unsplit_footer in unsplit_footers:
1236 footers += [b.strip() for b in unsplit_footer.split(',')]
Aaron Gable12ef5012017-05-15 14:29:00 -07001237 return sorted(set(tags + footers))
Aaron Gablefc03e672017-05-15 14:09:42 -07001238
1239 def ReviewersFromDescription(self):
1240 """Returns all reviewers listed in the commit description."""
Edward Lemura5799e32020-01-17 19:26:51 +00001241 # We don't support a 'R:' git-footer for reviewers; that is in metadata.
Aaron Gable12ef5012017-05-15 14:29:00 -07001242 tags = [r.strip() for r in self.tags.get('R', '').split(',') if r.strip()]
1243 return sorted(set(tags))
Aaron Gablefc03e672017-05-15 14:09:42 -07001244
1245 def TBRsFromDescription(self):
1246 """Returns all TBR reviewers listed in the commit description."""
Aaron Gable12ef5012017-05-15 14:29:00 -07001247 tags = [r.strip() for r in self.tags.get('TBR', '').split(',') if r.strip()]
Aaron Gable6e7ddb62020-05-27 22:23:29 +00001248 # TODO(crbug.com/839208): Remove support for 'Tbr:' when TBRs are
1249 # programmatically determined by self-CR+1s.
Edward Lemur69bb8be2020-02-03 20:37:38 +00001250 footers = self.GitFootersFromDescription().get('Tbr', [])
Aaron Gable12ef5012017-05-15 14:29:00 -07001251 return sorted(set(tags + footers))
Aaron Gablefc03e672017-05-15 14:09:42 -07001252
Aaron Gable6e7ddb62020-05-27 22:23:29 +00001253 # TODO(crbug.com/753425): Delete these once we're sure they're unused.
Aaron Gablefc03e672017-05-15 14:09:42 -07001254 @property
1255 def BUG(self):
1256 return ','.join(self.BugsFromDescription())
1257 @property
1258 def R(self):
1259 return ','.join(self.ReviewersFromDescription())
1260 @property
1261 def TBR(self):
1262 return ','.join(self.TBRsFromDescription())
1263
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001264 def AllFiles(self, root=None):
1265 """List all files under source control in the repo."""
1266 raise NotImplementedError()
1267
agable0b65e732016-11-22 09:25:46 -08001268 def AffectedFiles(self, include_deletes=True, file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001269 """Returns a list of AffectedFile instances for all files in the change.
1270
1271 Args:
1272 include_deletes: If false, deleted files will be filtered out.
sail@chromium.org5538e022011-05-12 17:53:16 +00001273 file_filter: An additional filter to apply.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001274
1275 Returns:
1276 [AffectedFile(path, action), AffectedFile(path, action)]
1277 """
Edward Lemurb9830242019-10-30 22:19:20 +00001278 affected = list(filter(file_filter, self._affected_files))
sail@chromium.org5538e022011-05-12 17:53:16 +00001279
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001280 if include_deletes:
1281 return affected
Edward Lemurb9830242019-10-30 22:19:20 +00001282 return list(filter(lambda x: x.Action() != 'D', affected))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001283
John Budorick16162372018-04-18 10:39:53 -07001284 def AffectedTestableFiles(self, include_deletes=None, **kwargs):
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +00001285 """Return a list of the existing text files in a change."""
1286 if include_deletes is not None:
Edward Lemura5799e32020-01-17 19:26:51 +00001287 warn('AffectedTeestableFiles(include_deletes=%s)'
1288 ' is deprecated and ignored' % str(include_deletes),
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +00001289 category=DeprecationWarning,
1290 stacklevel=2)
Edward Lemurb9830242019-10-30 22:19:20 +00001291 return list(filter(
1292 lambda x: x.IsTestableFile(),
1293 self.AffectedFiles(include_deletes=False, **kwargs)))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001294
agable0b65e732016-11-22 09:25:46 -08001295 def AffectedTextFiles(self, include_deletes=None):
1296 """An alias to AffectedTestableFiles for backwards compatibility."""
1297 return self.AffectedTestableFiles(include_deletes=include_deletes)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001298
agable0b65e732016-11-22 09:25:46 -08001299 def LocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001300 """Convenience function."""
agable0b65e732016-11-22 09:25:46 -08001301 return [af.LocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001302
agable0b65e732016-11-22 09:25:46 -08001303 def AbsoluteLocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001304 """Convenience function."""
agable0b65e732016-11-22 09:25:46 -08001305 return [af.AbsoluteLocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001306
1307 def RightHandSideLines(self):
Edward Lemura5799e32020-01-17 19:26:51 +00001308 """An iterator over all text lines in 'new' version of changed files.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001309
1310 Lists lines from new or modified text files in the change.
1311
1312 This is useful for doing line-by-line regex checks, like checking for
1313 trailing whitespace.
1314
1315 Yields:
1316 a 3 tuple:
1317 the AffectedFile instance of the current file;
1318 integer line number (1-based); and
1319 the contents of the line as a string.
1320 """
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +00001321 return _RightHandSideLinesImpl(
1322 x for x in self.AffectedFiles(include_deletes=False)
agable0b65e732016-11-22 09:25:46 -08001323 if x.IsTestableFile())
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001324
Jochen Eisingerd0573ec2017-04-13 10:55:06 +02001325 def OriginalOwnersFiles(self):
1326 """A map from path names of affected OWNERS files to their old content."""
1327 def owners_file_filter(f):
1328 return 'OWNERS' in os.path.split(f.LocalPath())[1]
1329 files = self.AffectedFiles(file_filter=owners_file_filter)
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +00001330 return {f.LocalPath(): f.OldContents() for f in files}
Jochen Eisingerd0573ec2017-04-13 10:55:06 +02001331
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001332
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001333class GitChange(Change):
1334 _AFFECTED_FILES = GitAffectedFile
maruel@chromium.orgc1938752011-04-12 23:11:13 +00001335 scm = 'git'
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +00001336
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001337 def AllFiles(self, root=None):
1338 """List all files under source control in the repo."""
1339 root = root or self.RepositoryRoot()
1340 return subprocess.check_output(
Aaron Gable7817f022017-12-12 09:43:17 -08001341 ['git', '-c', 'core.quotePath=false', 'ls-files', '--', '.'],
Josip Sokcevic0b123462021-06-08 20:41:32 +00001342 cwd=root).decode('utf-8', 'ignore').splitlines()
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001343
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001344
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001345def ListRelevantPresubmitFiles(files, root):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001346 """Finds all presubmit files that apply to a given set of source files.
1347
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001348 If inherit-review-settings-ok is present right under root, looks for
1349 PRESUBMIT.py in directories enclosing root.
1350
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001351 Args:
1352 files: An iterable container containing file paths.
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001353 root: Path where to stop searching.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001354
1355 Return:
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001356 List of absolute paths of the existing PRESUBMIT.py scripts.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001357 """
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001358 files = [normpath(os.path.join(root, f)) for f in files]
1359
1360 # List all the individual directories containing files.
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +00001361 directories = {os.path.dirname(f) for f in files}
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001362
1363 # Ignore root if inherit-review-settings-ok is present.
1364 if os.path.isfile(os.path.join(root, 'inherit-review-settings-ok')):
1365 root = None
1366
1367 # Collect all unique directories that may contain PRESUBMIT.py.
1368 candidates = set()
1369 for directory in directories:
1370 while True:
1371 if directory in candidates:
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001372 break
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001373 candidates.add(directory)
1374 if directory == root:
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001375 break
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001376 parent_dir = os.path.dirname(directory)
1377 if parent_dir == directory:
1378 # We hit the system root directory.
1379 break
1380 directory = parent_dir
1381
1382 # Look for PRESUBMIT.py in all candidate directories.
1383 results = []
1384 for directory in sorted(list(candidates)):
tobiasjsff061c02016-08-17 03:23:57 -07001385 try:
1386 for f in os.listdir(directory):
1387 p = os.path.join(directory, f)
1388 if os.path.isfile(p) and re.match(
1389 r'PRESUBMIT.*\.py$', f) and not f.startswith('PRESUBMIT_test'):
1390 results.append(p)
1391 except OSError:
1392 pass
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001393
tobiasjs2836bcf2016-08-16 04:08:16 -07001394 logging.debug('Presubmit files: %s', ','.join(results))
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001395 return results
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001396
1397
rmistry@google.com5626a922015-02-26 14:03:30 +00001398class GetPostUploadExecuter(object):
Josip Sokcevice293d3d2022-02-16 22:52:15 +00001399 def __init__(self, use_python3):
1400 """
1401 Args:
1402 use_python3: if true, will use python3 instead of python2 by default
1403 if USE_PYTHON3 is not specified.
1404 """
1405 self.use_python3 = use_python3
1406
1407 def ExecPresubmitScript(self, script_text, presubmit_path, gerrit_obj,
1408 change):
rmistry@google.com5626a922015-02-26 14:03:30 +00001409 """Executes PostUploadHook() from a single presubmit script.
Josip Sokcevic632bbc02022-05-19 05:32:50 +00001410 Caller is responsible for validating whether the hook should be executed
1411 and should only call this function if it should be.
rmistry@google.com5626a922015-02-26 14:03:30 +00001412
1413 Args:
1414 script_text: The text of the presubmit script.
1415 presubmit_path: Project script to run.
Edward Lemur016a0872020-02-04 22:13:28 +00001416 gerrit_obj: The GerritAccessor object.
rmistry@google.com5626a922015-02-26 14:03:30 +00001417 change: The Change object.
1418
1419 Return:
1420 A list of results objects.
1421 """
1422 context = {}
1423 try:
Raul Tambre09e64b42019-05-14 01:57:22 +00001424 exec(compile(script_text, 'PRESUBMIT.py', 'exec', dont_inherit=True),
1425 context)
Raul Tambre7c938462019-05-24 16:35:35 +00001426 except Exception as e:
rmistry@google.com5626a922015-02-26 14:03:30 +00001427 raise PresubmitFailure('"%s" had an exception.\n%s'
1428 % (presubmit_path, e))
1429
1430 function_name = 'PostUploadHook'
1431 if function_name not in context:
1432 return {}
1433 post_upload_hook = context[function_name]
1434 if not len(inspect.getargspec(post_upload_hook)[0]) == 3:
1435 raise PresubmitFailure(
1436 'Expected function "PostUploadHook" to take three arguments.')
Edward Lemur016a0872020-02-04 22:13:28 +00001437 return post_upload_hook(gerrit_obj, change, OutputApi(False))
rmistry@google.com5626a922015-02-26 14:03:30 +00001438
1439
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001440def _MergeMasters(masters1, masters2):
1441 """Merges two master maps. Merges also the tests of each builder."""
1442 result = {}
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001443 for (master, builders) in itertools.chain(masters1.items(),
1444 masters2.items()):
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001445 new_builders = result.setdefault(master, {})
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001446 for (builder, tests) in builders.items():
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001447 new_builders.setdefault(builder, set([])).update(tests)
1448 return result
1449
1450
Josip Sokcevice293d3d2022-02-16 22:52:15 +00001451def DoPostUploadExecuter(change, gerrit_obj, verbose, use_python3=False):
rmistry@google.com5626a922015-02-26 14:03:30 +00001452 """Execute the post upload hook.
1453
1454 Args:
1455 change: The Change object.
Edward Lemur016a0872020-02-04 22:13:28 +00001456 gerrit_obj: The GerritAccessor object.
rmistry@google.com5626a922015-02-26 14:03:30 +00001457 verbose: Prints debug info.
Josip Sokcevice293d3d2022-02-16 22:52:15 +00001458 use_python3: if true, default to using Python3 for presubmit checks
1459 rather than Python2.
rmistry@google.com5626a922015-02-26 14:03:30 +00001460 """
Josip Sokcevice293d3d2022-02-16 22:52:15 +00001461 python_version = 'Python %s' % sys.version_info.major
1462 sys.stdout.write('Running %s post upload checks ...\n' % python_version)
rmistry@google.com5626a922015-02-26 14:03:30 +00001463 presubmit_files = ListRelevantPresubmitFiles(
Edward Lemur6eb1d322020-02-27 22:20:15 +00001464 change.LocalPaths(), change.RepositoryRoot())
rmistry@google.com5626a922015-02-26 14:03:30 +00001465 if not presubmit_files and verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001466 sys.stdout.write('Warning, no PRESUBMIT.py found.\n')
rmistry@google.com5626a922015-02-26 14:03:30 +00001467 results = []
Josip Sokcevice293d3d2022-02-16 22:52:15 +00001468 executer = GetPostUploadExecuter(use_python3)
rmistry@google.com5626a922015-02-26 14:03:30 +00001469 # The root presubmit file should be executed after the ones in subdirectories.
1470 # i.e. the specific post upload hooks should run before the general ones.
1471 # Thus, reverse the order provided by ListRelevantPresubmitFiles.
1472 presubmit_files.reverse()
1473
1474 for filename in presubmit_files:
1475 filename = os.path.abspath(filename)
rmistry@google.com5626a922015-02-26 14:03:30 +00001476 # Accept CRLF presubmit script.
Bruce Dawson6e70e862022-07-01 19:37:01 +00001477 presubmit_script = gclient_utils.FileRead(filename).replace('\r\n', '\n')
Josip Sokcevic632bbc02022-05-19 05:32:50 +00001478 if _ShouldRunPresubmit(presubmit_script, use_python3):
Bruce Dawson8d78bd12022-08-12 19:17:03 +00001479 if sys.version_info[0] == 2:
Bruce Dawson443f9852022-09-08 17:30:59 +00001480 sys.stdout.write(
1481 'Running %s under Python 2. Add USE_PYTHON3 = True to prevent '
1482 'this.\n' % filename)
Bruce Dawson8d78bd12022-08-12 19:17:03 +00001483 elif verbose:
1484 sys.stdout.write('Running %s\n' % filename)
Josip Sokcevic632bbc02022-05-19 05:32:50 +00001485 results.extend(executer.ExecPresubmitScript(
1486 presubmit_script, filename, gerrit_obj, change))
rmistry@google.com5626a922015-02-26 14:03:30 +00001487
Edward Lemur6eb1d322020-02-27 22:20:15 +00001488 if not results:
1489 return 0
1490
1491 sys.stdout.write('\n')
1492 sys.stdout.write('** Post Upload Hook Messages **\n')
1493
1494 exit_code = 0
1495 for result in results:
1496 if result.fatal:
1497 exit_code = 1
1498 result.handle()
1499 sys.stdout.write('\n')
1500
1501 return exit_code
rmistry@google.com5626a922015-02-26 14:03:30 +00001502
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001503class PresubmitExecuter(object):
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001504 def __init__(self, change, committing, verbose, gerrit_obj, dry_run=None,
Bruce Dawson09c0c072022-05-26 20:28:58 +00001505 thread_pool=None, parallel=False, use_python3=False,
1506 no_diffs=False):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001507 """
1508 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001509 change: The Change object.
agable92bec4f2016-08-24 09:27:27 -07001510 committing: True if 'git cl land' is running, False if 'git cl upload' is.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001511 gerrit_obj: provides basic Gerrit codereview functionality.
1512 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -04001513 parallel: if true, all tests reported via input_api.RunTests for all
1514 PRESUBMIT files will be run in parallel.
Dirk Pranke6f0df682021-06-25 00:42:33 +00001515 use_python3: if true, will use python3 instead of python2 by default
1516 if USE_PYTHON3 is not specified.
Bruce Dawson09c0c072022-05-26 20:28:58 +00001517 no_diffs: if true, implies that --files or --all was specified so some
1518 checks can be skipped, and some errors will be messages.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001519 """
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001520 self.change = change
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001521 self.committing = committing
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001522 self.gerrit = gerrit_obj
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001523 self.verbose = verbose
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001524 self.dry_run = dry_run
Daniel Cheng7227d212017-11-17 08:12:37 -08001525 self.more_cc = []
Edward Lesmes8e282792018-04-03 18:50:29 -04001526 self.thread_pool = thread_pool
1527 self.parallel = parallel
Dirk Pranke6f0df682021-06-25 00:42:33 +00001528 self.use_python3 = use_python3
Bruce Dawson09c0c072022-05-26 20:28:58 +00001529 self.no_diffs = no_diffs
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001530
1531 def ExecPresubmitScript(self, script_text, presubmit_path):
1532 """Executes a single presubmit script.
Josip Sokcevic632bbc02022-05-19 05:32:50 +00001533 Caller is responsible for validating whether the hook should be executed
1534 and should only call this function if it should be.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001535
1536 Args:
1537 script_text: The text of the presubmit script.
1538 presubmit_path: The path to the presubmit file (this will be reported via
1539 input_api.PresubmitLocalPath()).
1540
1541 Return:
1542 A list of result objects, empty if no problems.
1543 """
chase@chromium.org8e416c82009-10-06 04:30:44 +00001544 # Change to the presubmit file's directory to support local imports.
1545 main_path = os.getcwd()
Saagar Sanghavi98b332f2020-07-31 17:19:15 +00001546 presubmit_dir = os.path.dirname(presubmit_path)
1547 os.chdir(presubmit_dir)
chase@chromium.org8e416c82009-10-06 04:30:44 +00001548
1549 # Load the presubmit script into context.
dpranke@chromium.org970c5222011-03-12 00:32:24 +00001550 input_api = InputApi(self.change, presubmit_path, self.committing,
Aaron Gable668c1d82018-04-03 10:19:16 -07001551 self.verbose, gerrit_obj=self.gerrit,
Edward Lesmes8e282792018-04-03 18:50:29 -04001552 dry_run=self.dry_run, thread_pool=self.thread_pool,
Bruce Dawson09c0c072022-05-26 20:28:58 +00001553 parallel=self.parallel, no_diffs=self.no_diffs)
Daniel Cheng7227d212017-11-17 08:12:37 -08001554 output_api = OutputApi(self.committing)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001555 context = {}
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001556
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001557 try:
Bruce Dawson0ba2fd42022-07-21 13:47:21 +00001558 exec(compile(script_text, presubmit_path, 'exec', dont_inherit=True),
Raul Tambre09e64b42019-05-14 01:57:22 +00001559 context)
Raul Tambre7c938462019-05-24 16:35:35 +00001560 except Exception as e:
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001561 raise PresubmitFailure('"%s" had an exception.\n%s' % (presubmit_path, e))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001562
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001563 context['__args'] = (input_api, output_api)
Ben Pastene8351dc12020-08-06 05:01:35 +00001564
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001565 # Get path of presubmit directory relative to repository root.
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001566 # Always use forward slashes, so that path is same in *nix and Windows
1567 root = input_api.change.RepositoryRoot()
1568 rel_path = os.path.relpath(presubmit_dir, root)
1569 rel_path = rel_path.replace(os.path.sep, '/')
Ben Pastene8351dc12020-08-06 05:01:35 +00001570
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001571 # Get the URL of git remote origin and use it to identify host and project
Edward Lesmeseb1bd622021-03-01 19:54:07 +00001572 host = project = ''
1573 if self.gerrit:
1574 host = self.gerrit.host or ''
1575 project = self.gerrit.project or ''
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001576
1577 # Prefix for test names
1578 prefix = 'presubmit:%s/%s:%s/' % (host, project, rel_path)
1579
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001580 # Perform all the desired presubmit checks.
1581 results = []
Ben Pastene8351dc12020-08-06 05:01:35 +00001582
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001583 try:
Scott Leecc2fe9b2020-11-19 19:38:06 +00001584 version = [
1585 int(x) for x in context.get('PRESUBMIT_VERSION', '0.0.0').split('.')
1586 ]
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001587
Scott Leecc2fe9b2020-11-19 19:38:06 +00001588 with rdb_wrapper.client(prefix) as sink:
1589 if version >= [2, 0, 0]:
Andrew Grievebdfb8f22022-02-02 21:56:47 +00001590 # Copy the keys to prevent "dictionary changed size during iteration"
1591 # exception if checks add globals to context. E.g. sometimes the
1592 # Python runtime will add __warningregistry__.
1593 for function_name in list(context.keys()):
Scott Leecc2fe9b2020-11-19 19:38:06 +00001594 if not function_name.startswith('Check'):
1595 continue
1596 if function_name.endswith('Commit') and not self.committing:
1597 continue
1598 if function_name.endswith('Upload') and self.committing:
1599 continue
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001600 logging.debug('Running %s in %s', function_name, presubmit_path)
1601 results.extend(
Bruce Dawson8fa42e22022-03-29 17:05:38 +00001602 self._run_check_function(function_name, context, sink,
1603 presubmit_path))
Scott Leecc2fe9b2020-11-19 19:38:06 +00001604 logging.debug('Running %s done.', function_name)
1605 self.more_cc.extend(output_api.more_cc)
1606
1607 else: # Old format
1608 if self.committing:
1609 function_name = 'CheckChangeOnCommit'
1610 else:
1611 function_name = 'CheckChangeOnUpload'
Andrew Grievebdfb8f22022-02-02 21:56:47 +00001612 if function_name in list(context.keys()):
Scott Leecc2fe9b2020-11-19 19:38:06 +00001613 logging.debug('Running %s in %s', function_name, presubmit_path)
1614 results.extend(
Bruce Dawson8fa42e22022-03-29 17:05:38 +00001615 self._run_check_function(function_name, context, sink,
1616 presubmit_path))
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001617 logging.debug('Running %s done.', function_name)
1618 self.more_cc.extend(output_api.more_cc)
1619
1620 finally:
1621 for f in input_api._named_temporary_files:
1622 os.remove(f)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001623
chase@chromium.org8e416c82009-10-06 04:30:44 +00001624 # Return the process to the original working directory.
1625 os.chdir(main_path)
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001626 return results
1627
Bruce Dawson8fa42e22022-03-29 17:05:38 +00001628 def _run_check_function(self, function_name, context, sink, presubmit_path):
Scott Leecc2fe9b2020-11-19 19:38:06 +00001629 """Evaluates and returns the result of a given presubmit function.
1630
1631 If sink is given, the result of the presubmit function will be reported
1632 to the ResultSink.
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001633
1634 Args:
Scott Leecc2fe9b2020-11-19 19:38:06 +00001635 function_name: the name of the presubmit function to evaluate
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001636 context: a context dictionary in which the function will be evaluated
Scott Leecc2fe9b2020-11-19 19:38:06 +00001637 sink: an instance of ResultSink. None, by default.
1638 Returns:
1639 the result of the presubmit function call.
1640 """
1641 start_time = time_time()
1642 try:
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001643 result = eval(function_name + '(*__args)', context)
1644 self._check_result_type(result)
Allen Webbfe7d7092021-05-18 02:05:49 +00001645 except Exception:
Bruce Dawson10a82862022-05-27 19:25:56 +00001646 _, e_value, _ = sys.exc_info()
1647 result = [
1648 OutputApi.PresubmitError(
1649 'Evaluation of %s failed: %s, %s' %
1650 (function_name, e_value, traceback.format_exc()))
1651 ]
Scott Leecc2fe9b2020-11-19 19:38:06 +00001652
Bruce Dawson2bdc49f2021-05-21 19:13:03 +00001653 elapsed_time = time_time() - start_time
1654 if elapsed_time > 10.0:
Bruce Dawson6757d462022-07-13 04:04:40 +00001655 sys.stdout.write('%6.1fs to run %s from %s.\n' %
1656 (elapsed_time, function_name, presubmit_path))
Scott Leecc2fe9b2020-11-19 19:38:06 +00001657 if sink:
Scott Leecc2fe9b2020-11-19 19:38:06 +00001658 status = rdb_wrapper.STATUS_PASS
1659 if any(r.fatal for r in result):
1660 status = rdb_wrapper.STATUS_FAIL
1661 sink.report(function_name, status, elapsed_time)
1662
1663 return result
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001664
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00001665 def _check_result_type(self, result):
1666 """Helper function which ensures result is a list, and all elements are
1667 instances of OutputApi.PresubmitResult"""
1668 if not isinstance(result, (tuple, list)):
1669 raise PresubmitFailure('Presubmit functions must return a tuple or list')
1670 if not all(isinstance(res, OutputApi.PresubmitResult) for res in result):
1671 raise PresubmitFailure(
1672 'All presubmit results must be of types derived from '
1673 'output_api.PresubmitResult')
1674
1675
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001676def DoPresubmitChecks(change,
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001677 committing,
1678 verbose,
maruel@chromium.orgb0dfd352009-06-10 14:12:54 +00001679 default_presubmit,
dpranke@chromium.org970c5222011-03-12 00:32:24 +00001680 may_prompt,
Aaron Gable668c1d82018-04-03 10:19:16 -07001681 gerrit_obj,
Edward Lesmes8e282792018-04-03 18:50:29 -04001682 dry_run=None,
Debrian Figueroadd2737e2019-06-21 23:50:13 +00001683 parallel=False,
Dirk Pranke6f0df682021-06-25 00:42:33 +00001684 json_output=None,
Bruce Dawson09c0c072022-05-26 20:28:58 +00001685 use_python3=False,
1686 no_diffs=False):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001687 """Runs all presubmit checks that apply to the files in the change.
1688
1689 This finds all PRESUBMIT.py files in directories enclosing the files in the
1690 change (up to the repository root) and calls the relevant entrypoint function
1691 depending on whether the change is being committed or uploaded.
1692
1693 Prints errors, warnings and notifications. Prompts the user for warnings
1694 when needed.
1695
1696 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001697 change: The Change object.
agable92bec4f2016-08-24 09:27:27 -07001698 committing: True if 'git cl land' is running, False if 'git cl upload' is.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001699 verbose: Prints debug info.
maruel@chromium.org0ff1fab2009-05-22 13:08:15 +00001700 default_presubmit: A default presubmit script to execute in any case.
Quinten Yearsley516fe7f2016-12-14 11:50:18 -08001701 may_prompt: Enable (y/n) questions on warning or error. If False,
1702 any questions are answered with yes by default.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001703 gerrit_obj: provides basic Gerrit codereview functionality.
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001704 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -04001705 parallel: if true, all tests specified by input_api.RunTests in all
1706 PRESUBMIT files will be run in parallel.
Dirk Pranke6f0df682021-06-25 00:42:33 +00001707 use_python3: if true, default to using Python3 for presubmit checks
1708 rather than Python2.
Bruce Dawson09c0c072022-05-26 20:28:58 +00001709 no_diffs: if true, implies that --files or --all was specified so some
1710 checks can be skipped, and some errors will be messages.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001711 Return:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001712 1 if presubmit checks failed or 0 otherwise.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001713 """
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001714 old_environ = os.environ
1715 try:
1716 # Make sure python subprocesses won't generate .pyc files.
1717 os.environ = os.environ.copy()
Edward Lemurb9830242019-10-30 22:19:20 +00001718 os.environ['PYTHONDONTWRITEBYTECODE'] = '1'
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001719
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001720 python_version = 'Python %s' % sys.version_info.major
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001721 if committing:
Dirk Pranke6fc394f2021-05-26 23:25:14 +00001722 sys.stdout.write('Running %s presubmit commit checks ...\n' %
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001723 python_version)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001724 else:
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001725 sys.stdout.write('Running %s presubmit upload checks ...\n' %
1726 python_version)
Edward Lemurecc27072020-01-06 16:42:34 +00001727 start_time = time_time()
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001728 presubmit_files = ListRelevantPresubmitFiles(
agable0b65e732016-11-22 09:25:46 -08001729 change.AbsoluteLocalPaths(), change.RepositoryRoot())
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001730 if not presubmit_files and verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001731 sys.stdout.write('Warning, no PRESUBMIT.py found.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001732 results = []
Bruce Dawsonf2b04212022-06-10 16:42:54 +00001733 depot_tools = os.path.dirname(os.path.abspath(__file__))
1734 python2_usage_log_file = os.path.join(depot_tools, 'python2_usage.txt')
1735 if os.path.exists(python2_usage_log_file):
1736 os.remove(python2_usage_log_file)
Edward Lesmes8e282792018-04-03 18:50:29 -04001737 thread_pool = ThreadPool()
Edward Lemur7e3c67f2018-07-20 20:52:49 +00001738 executer = PresubmitExecuter(change, committing, verbose, gerrit_obj,
Bruce Dawson09c0c072022-05-26 20:28:58 +00001739 dry_run, thread_pool, parallel, use_python3,
1740 no_diffs)
Josip Sokcevic632bbc02022-05-19 05:32:50 +00001741 skipped_count = 0;
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001742 if default_presubmit:
1743 if verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001744 sys.stdout.write('Running default presubmit script.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001745 fake_path = os.path.join(change.RepositoryRoot(), 'PRESUBMIT.py')
Josip Sokcevic632bbc02022-05-19 05:32:50 +00001746 if _ShouldRunPresubmit(default_presubmit, use_python3):
1747 results += executer.ExecPresubmitScript(default_presubmit, fake_path)
1748 else:
1749 skipped_count += 1
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001750 for filename in presubmit_files:
1751 filename = os.path.abspath(filename)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001752 # Accept CRLF presubmit script.
Bruce Dawson6e70e862022-07-01 19:37:01 +00001753 presubmit_script = gclient_utils.FileRead(filename).replace('\r\n', '\n')
Josip Sokcevic632bbc02022-05-19 05:32:50 +00001754 if _ShouldRunPresubmit(presubmit_script, use_python3):
Bruce Dawson8d78bd12022-08-12 19:17:03 +00001755 if sys.version_info[0] == 2:
Bruce Dawson443f9852022-09-08 17:30:59 +00001756 sys.stdout.write(
1757 'Running %s under Python 2. Add USE_PYTHON3 = True to prevent '
1758 'this.\n' % filename)
Bruce Dawson8d78bd12022-08-12 19:17:03 +00001759 elif verbose:
1760 sys.stdout.write('Running %s\n' % filename)
Josip Sokcevic632bbc02022-05-19 05:32:50 +00001761 results += executer.ExecPresubmitScript(presubmit_script, filename)
1762 else:
1763 skipped_count += 1
Bruce Dawson76fe1a72022-05-25 20:52:21 +00001764
Edward Lesmes8e282792018-04-03 18:50:29 -04001765 results += thread_pool.RunAsync()
1766
Bruce Dawsonf2b04212022-06-10 16:42:54 +00001767 if os.path.exists(python2_usage_log_file):
1768 with open(python2_usage_log_file) as f:
1769 python2_usage = [x.strip() for x in f.readlines()]
1770 results.append(
1771 OutputApi(committing).PresubmitPromptWarning(
1772 'Python 2 scripts were run during %s presubmits. Please see '
1773 'https://bugs.chromium.org/p/chromium/issues/detail?id=1313804'
1774 '#c61 for tips on resolving this.'
1775 % python_version,
1776 items=python2_usage))
1777
Edward Lemur6eb1d322020-02-27 22:20:15 +00001778 messages = {}
1779 should_prompt = False
1780 presubmits_failed = False
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001781 for result in results:
1782 if result.fatal:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001783 presubmits_failed = True
1784 messages.setdefault('ERRORS', []).append(result)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001785 elif result.should_prompt:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001786 should_prompt = True
1787 messages.setdefault('Warnings', []).append(result)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001788 else:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001789 messages.setdefault('Messages', []).append(result)
pam@chromium.orged9a0832009-09-09 22:48:55 +00001790
Bruce Dawson76fe1a72022-05-25 20:52:21 +00001791 # Print the different message types in a consistent order. ERRORS go last
1792 # so that they will be most visible in the local-presubmit output.
1793 for name in ['Messages', 'Warnings', 'ERRORS']:
1794 if name in messages:
1795 items = messages[name]
Gavin Makd22bf602022-07-11 21:10:41 +00001796 sys.stdout.write('** Presubmit %s: %d **\n' % (name, len(items)))
Bruce Dawson76fe1a72022-05-25 20:52:21 +00001797 for item in items:
1798 item.handle()
1799 sys.stdout.write('\n')
pam@chromium.orged9a0832009-09-09 22:48:55 +00001800
Edward Lemurecc27072020-01-06 16:42:34 +00001801 total_time = time_time() - start_time
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001802 if total_time > 1.0:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001803 sys.stdout.write(
Louis Romero4ca9e1c2022-03-10 10:29:11 +00001804 'Presubmit checks took %.1fs to calculate.\n' % total_time)
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +00001805
Edward Lemur6eb1d322020-02-27 22:20:15 +00001806 if not should_prompt and not presubmits_failed:
Louis Romero4ca9e1c2022-03-10 10:29:11 +00001807 sys.stdout.write('%s presubmit checks passed.\n\n' % python_version)
Josip Sokcevic7592e0a2022-01-12 00:57:54 +00001808 elif should_prompt and not presubmits_failed:
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001809 sys.stdout.write('There were %s presubmit warnings. ' % python_version)
Quinten Yearsley516fe7f2016-12-14 11:50:18 -08001810 if may_prompt:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001811 presubmits_failed = not prompt_should_continue(
1812 'Are you sure you wish to continue? (y/N): ')
Garrett Beatyacb807e2020-08-28 18:17:24 +00001813 else:
1814 sys.stdout.write('\n')
Bruce Dawson76fe1a72022-05-25 20:52:21 +00001815 else:
1816 sys.stdout.write('There were %s presubmit errors.\n' % python_version)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001817
Edward Lemur1dc66e12020-02-21 21:36:34 +00001818 if json_output:
1819 # Write the presubmit results to json output
1820 presubmit_results = {
1821 'errors': [
Edward Lemur6eb1d322020-02-27 22:20:15 +00001822 error.json_format()
1823 for error in messages.get('ERRORS', [])
Edward Lemur1dc66e12020-02-21 21:36:34 +00001824 ],
1825 'notifications': [
Edward Lemur6eb1d322020-02-27 22:20:15 +00001826 notification.json_format()
1827 for notification in messages.get('Messages', [])
Edward Lemur1dc66e12020-02-21 21:36:34 +00001828 ],
1829 'warnings': [
Edward Lemur6eb1d322020-02-27 22:20:15 +00001830 warning.json_format()
1831 for warning in messages.get('Warnings', [])
Edward Lemur1dc66e12020-02-21 21:36:34 +00001832 ],
Edward Lemur6eb1d322020-02-27 22:20:15 +00001833 'more_cc': executer.more_cc,
Josip Sokcevic632bbc02022-05-19 05:32:50 +00001834 'skipped_presubmits': skipped_count,
Edward Lemur1dc66e12020-02-21 21:36:34 +00001835 }
1836
1837 gclient_utils.FileWrite(
1838 json_output, json.dumps(presubmit_results, sort_keys=True))
1839
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001840 global _ASKED_FOR_FEEDBACK
1841 # Ask for feedback one time out of 5.
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +00001842 if (results and random.randint(0, 4) == 0 and not _ASKED_FOR_FEEDBACK):
Edward Lemur6eb1d322020-02-27 22:20:15 +00001843 sys.stdout.write(
maruel@chromium.org1ce8e662014-01-14 15:23:00 +00001844 'Was the presubmit check useful? If not, run "git cl presubmit -v"\n'
1845 'to figure out which PRESUBMIT.py was run, then run git blame\n'
1846 'on the file to figure out who to ask for help.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001847 _ASKED_FOR_FEEDBACK = True
Edward Lemur6eb1d322020-02-27 22:20:15 +00001848
1849 return 1 if presubmits_failed else 0
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001850 finally:
1851 os.environ = old_environ
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001852
1853
Edward Lemur50984a62020-02-06 18:10:18 +00001854def _scan_sub_dirs(mask, recursive):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001855 if not recursive:
pgervais@chromium.orge57b09d2014-05-07 00:58:13 +00001856 return [x for x in glob.glob(mask) if x not in ('.svn', '.git')]
Lei Zhang9611c4c2017-04-04 01:41:56 -07001857
1858 results = []
1859 for root, dirs, files in os.walk('.'):
1860 if '.svn' in dirs:
1861 dirs.remove('.svn')
1862 if '.git' in dirs:
1863 dirs.remove('.git')
1864 for name in files:
1865 if fnmatch.fnmatch(name, mask):
1866 results.append(os.path.join(root, name))
1867 return results
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001868
1869
Edward Lemur50984a62020-02-06 18:10:18 +00001870def _parse_files(args, recursive):
tobiasjs2836bcf2016-08-16 04:08:16 -07001871 logging.debug('Searching for %s', args)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001872 files = []
1873 for arg in args:
Edward Lemur50984a62020-02-06 18:10:18 +00001874 files.extend([('M', f) for f in _scan_sub_dirs(arg, recursive)])
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001875 return files
1876
1877
Edward Lemur50984a62020-02-06 18:10:18 +00001878def _parse_change(parser, options):
1879 """Process change options.
1880
1881 Args:
1882 parser: The parser used to parse the arguments from command line.
1883 options: The arguments parsed from command line.
1884 Returns:
1885 A GitChange if the change root is a git repository, or a Change otherwise.
1886 """
1887 if options.files and options.all_files:
1888 parser.error('<files> cannot be specified when --all-files is set.')
1889
Edward Lesmes44ea3ff2020-02-05 00:14:30 +00001890 change_scm = scm.determine_scm(options.root)
Edward Lemur50984a62020-02-06 18:10:18 +00001891 if change_scm != 'git' and not options.files:
1892 parser.error('<files> is not optional for unversioned directories.')
1893
1894 if options.files:
Josip Sokcevic017544d2022-03-31 23:47:53 +00001895 if options.source_controlled_only:
1896 # Get the filtered set of files from SCM.
1897 change_files = []
1898 for name in scm.GIT.GetAllFiles(options.root):
1899 for mask in options.files:
1900 if fnmatch.fnmatch(name, mask):
1901 change_files.append(('M', name))
1902 break
1903 else:
1904 # Get the filtered set of files from a directory scan.
1905 change_files = _parse_files(options.files, options.recursive)
Edward Lemur50984a62020-02-06 18:10:18 +00001906 elif options.all_files:
1907 change_files = [('M', f) for f in scm.GIT.GetAllFiles(options.root)]
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001908 else:
Edward Lemur50984a62020-02-06 18:10:18 +00001909 change_files = scm.GIT.CaptureStatus(
Edward Lemur7f6dec02020-02-06 20:23:58 +00001910 options.root, options.upstream or None)
Edward Lemur50984a62020-02-06 18:10:18 +00001911
1912 logging.info('Found %d file(s).', len(change_files))
1913
1914 change_class = GitChange if change_scm == 'git' else Change
1915 return change_class(
1916 options.name,
1917 options.description,
1918 options.root,
1919 change_files,
1920 options.issue,
1921 options.patchset,
1922 options.author,
1923 upstream=options.upstream)
1924
1925
1926def _parse_gerrit_options(parser, options):
1927 """Process gerrit options.
1928
1929 SIDE EFFECTS: Modifies options.author and options.description from Gerrit if
1930 options.gerrit_fetch is set.
1931
1932 Args:
1933 parser: The parser used to parse the arguments from command line.
1934 options: The arguments parsed from command line.
1935 Returns:
Stephen Martinisfb09de22021-02-25 03:41:13 +00001936 A GerritAccessor object if options.gerrit_url is set, or None otherwise.
Edward Lemur50984a62020-02-06 18:10:18 +00001937 """
1938 gerrit_obj = None
Stephen Martinisfb09de22021-02-25 03:41:13 +00001939 if options.gerrit_url:
Edward Lesmeseb1bd622021-03-01 19:54:07 +00001940 gerrit_obj = GerritAccessor(
1941 url=options.gerrit_url,
1942 project=options.gerrit_project,
1943 branch=options.gerrit_branch)
Edward Lemur50984a62020-02-06 18:10:18 +00001944
1945 if not options.gerrit_fetch:
1946 return gerrit_obj
1947
1948 if not options.gerrit_url or not options.issue or not options.patchset:
1949 parser.error(
1950 '--gerrit_fetch requires --gerrit_url, --issue and --patchset.')
1951
1952 options.author = gerrit_obj.GetChangeOwner(options.issue)
1953 options.description = gerrit_obj.GetChangeDescription(
1954 options.issue, options.patchset)
1955
1956 logging.info('Got author: "%s"', options.author)
1957 logging.info('Got description: """\n%s\n"""', options.description)
1958
1959 return gerrit_obj
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001960
1961
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001962@contextlib.contextmanager
1963def canned_check_filter(method_names):
1964 filtered = {}
1965 try:
1966 for method_name in method_names:
1967 if not hasattr(presubmit_canned_checks, method_name):
Gavin Make6a62332020-12-04 21:57:10 +00001968 logging.warning('Skipping unknown "canned" check %s' % method_name)
Aaron Gableecee74c2018-04-02 15:13:08 -07001969 continue
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001970 filtered[method_name] = getattr(presubmit_canned_checks, method_name)
1971 setattr(presubmit_canned_checks, method_name, lambda *_a, **_kw: [])
1972 yield
1973 finally:
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001974 for name, method in filtered.items():
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001975 setattr(presubmit_canned_checks, name, method)
1976
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +00001977
sbc@chromium.org013731e2015-02-26 18:28:43 +00001978def main(argv=None):
Edward Lemura5799e32020-01-17 19:26:51 +00001979 parser = argparse.ArgumentParser(usage='%(prog)s [options] <files...>')
1980 hooks = parser.add_mutually_exclusive_group()
1981 hooks.add_argument('-c', '--commit', action='store_true',
1982 help='Use commit instead of upload checks.')
1983 hooks.add_argument('-u', '--upload', action='store_false', dest='commit',
1984 help='Use upload instead of commit checks.')
Edward Lemur75526302020-02-27 22:31:05 +00001985 hooks.add_argument('--post_upload', action='store_true',
1986 help='Run post-upload commit hooks.')
Edward Lemura5799e32020-01-17 19:26:51 +00001987 parser.add_argument('-r', '--recursive', action='store_true',
1988 help='Act recursively.')
1989 parser.add_argument('-v', '--verbose', action='count', default=0,
1990 help='Use 2 times for more debug info.')
1991 parser.add_argument('--name', default='no name')
1992 parser.add_argument('--author')
Edward Lemur227d5102020-02-25 23:45:35 +00001993 desc = parser.add_mutually_exclusive_group()
1994 desc.add_argument('--description', default='', help='The change description.')
1995 desc.add_argument('--description_file',
1996 help='File to read change description from.')
Edward Lemura5799e32020-01-17 19:26:51 +00001997 parser.add_argument('--issue', type=int, default=0)
1998 parser.add_argument('--patchset', type=int, default=0)
1999 parser.add_argument('--root', default=os.getcwd(),
2000 help='Search for PRESUBMIT.py up to this directory. '
2001 'If inherit-review-settings-ok is present in this '
2002 'directory, parent directories up to the root file '
2003 'system directories will also be searched.')
2004 parser.add_argument('--upstream',
2005 help='Git only: the base ref or upstream branch against '
2006 'which the diff should be computed.')
2007 parser.add_argument('--default_presubmit')
2008 parser.add_argument('--may_prompt', action='store_true', default=False)
2009 parser.add_argument('--skip_canned', action='append', default=[],
2010 help='A list of checks to skip which appear in '
2011 'presubmit_canned_checks. Can be provided multiple times '
2012 'to skip multiple canned checks.')
2013 parser.add_argument('--dry_run', action='store_true', help=argparse.SUPPRESS)
2014 parser.add_argument('--gerrit_url', help=argparse.SUPPRESS)
Edward Lesmeseb1bd622021-03-01 19:54:07 +00002015 parser.add_argument('--gerrit_project', help=argparse.SUPPRESS)
2016 parser.add_argument('--gerrit_branch', help=argparse.SUPPRESS)
Edward Lemura5799e32020-01-17 19:26:51 +00002017 parser.add_argument('--gerrit_fetch', action='store_true',
2018 help=argparse.SUPPRESS)
2019 parser.add_argument('--parallel', action='store_true',
2020 help='Run all tests specified by input_api.RunTests in '
2021 'all PRESUBMIT files in parallel.')
2022 parser.add_argument('--json_output',
2023 help='Write presubmit errors to json output.')
Edward Lemur1dc66e12020-02-21 21:36:34 +00002024 parser.add_argument('--all_files', action='store_true',
Edward Lemur50984a62020-02-06 18:10:18 +00002025 help='Mark all files under source control as modified.')
Bruce Dawson09c0c072022-05-26 20:28:58 +00002026
Edward Lemura5799e32020-01-17 19:26:51 +00002027 parser.add_argument('files', nargs='*',
2028 help='List of files to be marked as modified when '
2029 'executing presubmit or post-upload hooks. fnmatch '
2030 'wildcards can also be used.')
Josip Sokcevic017544d2022-03-31 23:47:53 +00002031 parser.add_argument('--source_controlled_only', action='store_true',
2032 help='Constrain \'files\' to those in source control.')
Dirk Pranke6f0df682021-06-25 00:42:33 +00002033 parser.add_argument('--use-python3', action='store_true',
2034 help='Use python3 for presubmit checks by default')
Bruce Dawson09c0c072022-05-26 20:28:58 +00002035 parser.add_argument('--no_diffs', action='store_true',
2036 help='Assume that all "modified" files have no diffs.')
Edward Lemura5799e32020-01-17 19:26:51 +00002037 options = parser.parse_args(argv)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00002038
Erik Staabcca5c492020-04-16 17:40:07 +00002039 log_level = logging.ERROR
maruel@chromium.org899e1c12011-04-07 17:03:18 +00002040 if options.verbose >= 2:
Erik Staabcca5c492020-04-16 17:40:07 +00002041 log_level = logging.DEBUG
maruel@chromium.org899e1c12011-04-07 17:03:18 +00002042 elif options.verbose:
Erik Staabcca5c492020-04-16 17:40:07 +00002043 log_level = logging.INFO
2044 log_format = ('[%(levelname).1s%(asctime)s %(process)d %(thread)d '
2045 '%(filename)s] %(message)s')
2046 logging.basicConfig(format=log_format, level=log_level)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00002047
Edward Lemur227d5102020-02-25 23:45:35 +00002048 if options.description_file:
2049 options.description = gclient_utils.FileRead(options.description_file)
Edward Lemur50984a62020-02-06 18:10:18 +00002050 gerrit_obj = _parse_gerrit_options(parser, options)
2051 change = _parse_change(parser, options)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00002052
maruel@chromium.org899e1c12011-04-07 17:03:18 +00002053 try:
Edward Lemur75526302020-02-27 22:31:05 +00002054 if options.post_upload:
Josip Sokcevice293d3d2022-02-16 22:52:15 +00002055 return DoPostUploadExecuter(change, gerrit_obj, options.verbose,
2056 options.use_python3)
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00002057 with canned_check_filter(options.skip_canned):
Edward Lemur6eb1d322020-02-27 22:20:15 +00002058 return DoPresubmitChecks(
Edward Lemur50984a62020-02-06 18:10:18 +00002059 change,
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00002060 options.commit,
2061 options.verbose,
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00002062 options.default_presubmit,
2063 options.may_prompt,
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00002064 gerrit_obj,
Edward Lesmes8e282792018-04-03 18:50:29 -04002065 options.dry_run,
Debrian Figueroadd2737e2019-06-21 23:50:13 +00002066 options.parallel,
Dirk Pranke6f0df682021-06-25 00:42:33 +00002067 options.json_output,
Bruce Dawson09c0c072022-05-26 20:28:58 +00002068 options.use_python3,
2069 options.no_diffs)
Raul Tambre7c938462019-05-24 16:35:35 +00002070 except PresubmitFailure as e:
Josip Sokcevic0399e172022-03-21 23:11:51 +00002071 import utils
Raul Tambre80ee78e2019-05-06 22:41:05 +00002072 print(e, file=sys.stderr)
2073 print('Maybe your depot_tools is out of date?', file=sys.stderr)
Josip Sokcevic0399e172022-03-21 23:11:51 +00002074 print('depot_tools version: %s' % utils.depot_tools_version(),
2075 file=sys.stderr)
maruel@chromium.org899e1c12011-04-07 17:03:18 +00002076 return 2
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00002077
2078
2079if __name__ == '__main__':
maruel@chromium.org35625c72011-03-23 17:34:02 +00002080 fix_encoding.fix_encoding()
sbc@chromium.org013731e2015-02-26 18:28:43 +00002081 try:
2082 sys.exit(main())
2083 except KeyboardInterrupt:
2084 sys.stderr.write('interrupted\n')
sergiybf8a3b382016-07-05 11:21:30 -07002085 sys.exit(2)