blob: 5ff2a236e2be16d70387544f00d6b6fe712396da [file] [log] [blame]
Josip Sokcevic4de5dea2022-03-23 21:15:14 +00001#!/usr/bin/env python3
maruel@chromium.org3bbf2942012-01-10 16:52:06 +00002# Copyright (c) 2012 The Chromium Authors. All rights reserved.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00003# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5
6"""Enables directory-specific presubmit checks to run at upload and/or commit.
7"""
8
Raul Tambre80ee78e2019-05-06 22:41:05 +00009from __future__ import print_function
10
Saagar Sanghavi99816902020-08-11 22:41:25 +000011__version__ = '2.0.0'
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000012
13# TODO(joi) Add caching where appropriate/needed. The API is designed to allow
14# caching (between all different invocations of presubmit scripts for a given
15# change). We should add it as our presubmit scripts start feeling slow.
16
Edward Lemura5799e32020-01-17 19:26:51 +000017import argparse
Takeshi Yoshino07a6bea2017-08-02 02:44:06 +090018import ast # Exposed through the API.
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +000019import contextlib
Yoshisato Yanagisawa406de132018-06-29 05:43:25 +000020import cpplint
dcheng091b7db2016-06-16 01:27:51 -070021import fnmatch # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000022import glob
asvitkine@chromium.org15169952011-09-27 14:30:53 +000023import inspect
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +000024import itertools
maruel@chromium.org4f6852c2012-04-20 20:39:20 +000025import json # Exposed through the API.
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +000026import logging
ilevy@chromium.orgbc117312013-04-20 03:57:56 +000027import multiprocessing
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000028import os # Somewhat exposed through the API.
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +000029import random
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000030import re # Exposed through the API.
Edward Lesmes8e282792018-04-03 18:50:29 -040031import signal
Allen Webbfe7d7092021-05-18 02:05:49 +000032import six
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000033import sys # Parts exposed through API.
34import tempfile # Exposed through the API.
Edward Lesmes8e282792018-04-03 18:50:29 -040035import threading
jam@chromium.org2a891dc2009-08-20 20:33:37 +000036import time
Edward Lemurde9e3ca2019-10-24 21:13:31 +000037import traceback
maruel@chromium.org1487d532009-06-06 00:22:57 +000038import unittest # Exposed through the API.
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +000039from warnings import warn
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000040
41# Local imports.
maruel@chromium.org35625c72011-03-23 17:34:02 +000042import fix_encoding
Yoshisato Yanagisawa04600b42019-03-15 03:03:41 +000043import gclient_paths # Exposed through the API
44import gclient_utils
Aaron Gableb584c4f2017-04-26 16:28:08 -070045import git_footers
tandrii@chromium.org015ebae2016-04-25 19:37:22 +000046import gerrit_util
Edward Lesmes9ce03f82021-01-12 20:13:31 +000047import owners as owners_db
48import owners_client
Jochen Eisinger76f5fc62017-04-07 16:27:46 +020049import owners_finder
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000050import presubmit_canned_checks
Saagar Sanghavi9949ab72020-07-20 20:56:40 +000051import rdb_wrapper
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +000052import scm
maruel@chromium.org84f4fe32011-04-06 13:26:45 +000053import subprocess2 as subprocess # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000054
Edward Lemur16af3562019-10-17 22:11:33 +000055if sys.version_info.major == 2:
56 # TODO(1009814): Expose urllib2 only through urllib_request and urllib_error
57 import urllib2 # Exposed through the API.
58 import urlparse
59 import urllib2 as urllib_request
60 import urllib2 as urllib_error
61else:
62 import urllib.parse as urlparse
63 import urllib.request as urllib_request
64 import urllib.error as urllib_error
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000065
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +000066# Ask for feedback only once in program lifetime.
67_ASKED_FOR_FEEDBACK = False
68
Edward Lemurecc27072020-01-06 16:42:34 +000069def time_time():
70 # Use this so that it can be mocked in tests without interfering with python
71 # system machinery.
72 return time.time()
73
74
maruel@chromium.org899e1c12011-04-07 17:03:18 +000075class PresubmitFailure(Exception):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000076 pass
77
78
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000079class CommandData(object):
Edward Lemur940c2822019-08-23 00:34:25 +000080 def __init__(self, name, cmd, kwargs, message, python3=False):
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000081 self.name = name
82 self.cmd = cmd
Edward Lesmes8e282792018-04-03 18:50:29 -040083 self.stdin = kwargs.get('stdin', None)
Edward Lemur2d6b67c2019-08-23 22:25:41 +000084 self.kwargs = kwargs.copy()
Edward Lesmes8e282792018-04-03 18:50:29 -040085 self.kwargs['stdout'] = subprocess.PIPE
86 self.kwargs['stderr'] = subprocess.STDOUT
87 self.kwargs['stdin'] = subprocess.PIPE
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000088 self.message = message
89 self.info = None
Edward Lemur940c2822019-08-23 00:34:25 +000090 self.python3 = python3
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000091
ilevy@chromium.orgbc117312013-04-20 03:57:56 +000092
Edward Lesmes8e282792018-04-03 18:50:29 -040093# Adapted from
94# https://github.com/google/gtest-parallel/blob/master/gtest_parallel.py#L37
95#
96# An object that catches SIGINT sent to the Python process and notices
97# if processes passed to wait() die by SIGINT (we need to look for
98# both of those cases, because pressing Ctrl+C can result in either
99# the main process or one of the subprocesses getting the signal).
100#
101# Before a SIGINT is seen, wait(p) will simply call p.wait() and
102# return the result. Once a SIGINT has been seen (in the main process
103# or a subprocess, including the one the current call is waiting for),
Edward Lemur9a5bb612019-09-26 02:01:52 +0000104# wait(p) will call p.terminate().
Edward Lesmes8e282792018-04-03 18:50:29 -0400105class SigintHandler(object):
Edward Lesmes8e282792018-04-03 18:50:29 -0400106 sigint_returncodes = {-signal.SIGINT, # Unix
107 -1073741510, # Windows
108 }
109 def __init__(self):
110 self.__lock = threading.Lock()
111 self.__processes = set()
112 self.__got_sigint = False
Edward Lemur9a5bb612019-09-26 02:01:52 +0000113 self.__previous_signal = signal.signal(signal.SIGINT, self.interrupt)
Edward Lesmes8e282792018-04-03 18:50:29 -0400114
115 def __on_sigint(self):
116 self.__got_sigint = True
117 while self.__processes:
118 try:
119 self.__processes.pop().terminate()
120 except OSError:
121 pass
122
Edward Lemur9a5bb612019-09-26 02:01:52 +0000123 def interrupt(self, signal_num, frame):
Edward Lesmes8e282792018-04-03 18:50:29 -0400124 with self.__lock:
125 self.__on_sigint()
Edward Lemur9a5bb612019-09-26 02:01:52 +0000126 self.__previous_signal(signal_num, frame)
Edward Lesmes8e282792018-04-03 18:50:29 -0400127
128 def got_sigint(self):
129 with self.__lock:
130 return self.__got_sigint
131
132 def wait(self, p, stdin):
133 with self.__lock:
134 if self.__got_sigint:
135 p.terminate()
136 self.__processes.add(p)
137 stdout, stderr = p.communicate(stdin)
138 code = p.returncode
139 with self.__lock:
140 self.__processes.discard(p)
141 if code in self.sigint_returncodes:
142 self.__on_sigint()
Edward Lesmes8e282792018-04-03 18:50:29 -0400143 return stdout, stderr
144
145sigint_handler = SigintHandler()
146
147
Edward Lemurecc27072020-01-06 16:42:34 +0000148class Timer(object):
149 def __init__(self, timeout, fn):
150 self.completed = False
151 self._fn = fn
152 self._timer = threading.Timer(timeout, self._onTimer) if timeout else None
153
154 def __enter__(self):
155 if self._timer:
156 self._timer.start()
157 return self
158
159 def __exit__(self, _type, _value, _traceback):
160 if self._timer:
161 self._timer.cancel()
162
163 def _onTimer(self):
164 self._fn()
165 self.completed = True
166
167
Edward Lesmes8e282792018-04-03 18:50:29 -0400168class ThreadPool(object):
Edward Lemurecc27072020-01-06 16:42:34 +0000169 def __init__(self, pool_size=None, timeout=None):
170 self.timeout = timeout
Edward Lesmes8e282792018-04-03 18:50:29 -0400171 self._pool_size = pool_size or multiprocessing.cpu_count()
172 self._messages = []
173 self._messages_lock = threading.Lock()
174 self._tests = []
175 self._tests_lock = threading.Lock()
176 self._nonparallel_tests = []
177
Edward Lemurecc27072020-01-06 16:42:34 +0000178 def _GetCommand(self, test):
Edward Lemur940c2822019-08-23 00:34:25 +0000179 vpython = 'vpython'
180 if test.python3:
181 vpython += '3'
182 if sys.platform == 'win32':
183 vpython += '.bat'
Edward Lesmes8e282792018-04-03 18:50:29 -0400184
185 cmd = test.cmd
186 if cmd[0] == 'python':
187 cmd = list(cmd)
188 cmd[0] = vpython
189 elif cmd[0].endswith('.py'):
190 cmd = [vpython] + cmd
191
Edward Lemur336e51f2019-11-14 21:42:04 +0000192 # On Windows, scripts on the current directory take precedence over PATH, so
193 # that when testing depot_tools on Windows, calling `vpython.bat` will
194 # execute the copy of vpython of the depot_tools under test instead of the
195 # one in the bot.
196 # As a workaround, we run the tests from the parent directory instead.
197 if (cmd[0] == vpython and
198 'cwd' in test.kwargs and
199 os.path.basename(test.kwargs['cwd']) == 'depot_tools'):
200 test.kwargs['cwd'] = os.path.dirname(test.kwargs['cwd'])
201 cmd[1] = os.path.join('depot_tools', cmd[1])
202
Edward Lemurecc27072020-01-06 16:42:34 +0000203 return cmd
204
205 def _RunWithTimeout(self, cmd, stdin, kwargs):
206 p = subprocess.Popen(cmd, **kwargs)
207 with Timer(self.timeout, p.terminate) as timer:
208 stdout, _ = sigint_handler.wait(p, stdin)
Josip Sokcevic6635baf2021-11-19 02:04:39 +0000209 stdout = stdout.decode('utf-8', 'ignore')
Edward Lemurecc27072020-01-06 16:42:34 +0000210 if timer.completed:
211 stdout = 'Process timed out after %ss\n%s' % (self.timeout, stdout)
Josip Sokcevic6635baf2021-11-19 02:04:39 +0000212 return p.returncode, stdout
Edward Lemurecc27072020-01-06 16:42:34 +0000213
214 def CallCommand(self, test):
215 """Runs an external program.
216
Edward Lemura5799e32020-01-17 19:26:51 +0000217 This function converts invocation of .py files and invocations of 'python'
Edward Lemurecc27072020-01-06 16:42:34 +0000218 to vpython invocations.
219 """
220 cmd = self._GetCommand(test)
Edward Lesmes8e282792018-04-03 18:50:29 -0400221 try:
Edward Lemurecc27072020-01-06 16:42:34 +0000222 start = time_time()
223 returncode, stdout = self._RunWithTimeout(cmd, test.stdin, test.kwargs)
224 duration = time_time() - start
Edward Lemur7cf94382019-11-15 22:36:41 +0000225 except Exception:
Edward Lemurecc27072020-01-06 16:42:34 +0000226 duration = time_time() - start
Edward Lesmes8e282792018-04-03 18:50:29 -0400227 return test.message(
Edward Lemur7cf94382019-11-15 22:36:41 +0000228 '%s\n%s exec failure (%4.2fs)\n%s' % (
229 test.name, ' '.join(cmd), duration, traceback.format_exc()))
Edward Lemurde9e3ca2019-10-24 21:13:31 +0000230
Edward Lemurecc27072020-01-06 16:42:34 +0000231 if returncode != 0:
Edward Lesmes8e282792018-04-03 18:50:29 -0400232 return test.message(
Edward Lemur7cf94382019-11-15 22:36:41 +0000233 '%s\n%s (%4.2fs) failed\n%s' % (
234 test.name, ' '.join(cmd), duration, stdout))
Edward Lemurecc27072020-01-06 16:42:34 +0000235
Edward Lesmes8e282792018-04-03 18:50:29 -0400236 if test.info:
Edward Lemur7cf94382019-11-15 22:36:41 +0000237 return test.info('%s\n%s (%4.2fs)' % (test.name, ' '.join(cmd), duration))
Edward Lesmes8e282792018-04-03 18:50:29 -0400238
239 def AddTests(self, tests, parallel=True):
240 if parallel:
241 self._tests.extend(tests)
242 else:
243 self._nonparallel_tests.extend(tests)
244
245 def RunAsync(self):
246 self._messages = []
247
248 def _WorkerFn():
249 while True:
250 test = None
251 with self._tests_lock:
252 if not self._tests:
253 break
254 test = self._tests.pop()
255 result = self.CallCommand(test)
256 if result:
257 with self._messages_lock:
258 self._messages.append(result)
259
260 def _StartDaemon():
261 t = threading.Thread(target=_WorkerFn)
262 t.daemon = True
263 t.start()
264 return t
265
266 while self._nonparallel_tests:
267 test = self._nonparallel_tests.pop()
268 result = self.CallCommand(test)
269 if result:
270 self._messages.append(result)
271
272 if self._tests:
273 threads = [_StartDaemon() for _ in range(self._pool_size)]
274 for worker in threads:
275 worker.join()
276
277 return self._messages
278
279
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000280def normpath(path):
281 '''Version of os.path.normpath that also changes backward slashes to
282 forward slashes when not running on Windows.
283 '''
284 # This is safe to always do because the Windows version of os.path.normpath
285 # will replace forward slashes with backward slashes.
286 path = path.replace(os.sep, '/')
287 return os.path.normpath(path)
288
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000289
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000290def _RightHandSideLinesImpl(affected_files):
291 """Implements RightHandSideLines for InputApi and GclChange."""
292 for af in affected_files:
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000293 lines = af.ChangedContents()
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000294 for line in lines:
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000295 yield (af, line[0], line[1])
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000296
297
Edward Lemur6eb1d322020-02-27 22:20:15 +0000298def prompt_should_continue(prompt_string):
299 sys.stdout.write(prompt_string)
Dirk Pranke7288f882021-06-03 18:01:30 +0000300 sys.stdout.flush()
Edward Lemur6eb1d322020-02-27 22:20:15 +0000301 response = sys.stdin.readline().strip().lower()
302 return response in ('y', 'yes')
dpranke@chromium.org5ac21012011-03-16 02:58:25 +0000303
304
Josip Sokcevice293d3d2022-02-16 22:52:15 +0000305def _ShouldRunPresubmit(script_text, use_python3):
306 """Try to figure out whether these presubmit checks should be run under
307 python2 or python3. We need to do this without actually trying to
308 compile the text, since the text might compile in one but not the
309 other.
310
311 Args:
312 script_text: The text of the presubmit script.
313 use_python3: if true, will use python3 instead of python2 by default
314 if USE_PYTHON3 is not specified.
315
316 Return:
317 A boolean if presubmit should be executed
318 """
319 m = re.search('^USE_PYTHON3 = (True|False)$', script_text, flags=re.MULTILINE)
320 if m:
321 use_python3 = m.group(1) == 'True'
322
323 return ((sys.version_info.major == 2) and not use_python3) or \
324 ((sys.version_info.major == 3) and use_python3)
325
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000326# Top level object so multiprocessing can pickle
327# Public access through OutputApi object.
328class _PresubmitResult(object):
329 """Base class for result objects."""
330 fatal = False
331 should_prompt = False
332
333 def __init__(self, message, items=None, long_text=''):
334 """
335 message: A short one-line message to indicate errors.
336 items: A list of short strings to indicate where errors occurred.
337 long_text: multi-line text output, e.g. from another tool
338 """
Bruce Dawsondb8622b2022-04-03 15:38:12 +0000339 self._message = _PresubmitResult._ensure_str(message)
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000340 self._items = items or []
Tom McKee61c72652021-07-20 11:56:32 +0000341 self._long_text = _PresubmitResult._ensure_str(long_text.rstrip())
342
343 @staticmethod
344 def _ensure_str(val):
345 """
346 val: A "stringish" value. Can be any of str, unicode or bytes.
347 returns: A str after applying encoding/decoding as needed.
348 Assumes/uses UTF-8 for relevant inputs/outputs.
349
350 We'd prefer to use six.ensure_str but our copy of six is old :(
351 """
352 if isinstance(val, str):
353 return val
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +0000354
Tom McKee61c72652021-07-20 11:56:32 +0000355 if six.PY2 and isinstance(val, unicode):
356 return val.encode()
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +0000357
358 if six.PY3 and isinstance(val, bytes):
Tom McKee61c72652021-07-20 11:56:32 +0000359 return val.decode()
360 raise ValueError("Unknown string type %s" % type(val))
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000361
Edward Lemur6eb1d322020-02-27 22:20:15 +0000362 def handle(self):
363 sys.stdout.write(self._message)
364 sys.stdout.write('\n')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000365 for index, item in enumerate(self._items):
Edward Lemur6eb1d322020-02-27 22:20:15 +0000366 sys.stdout.write(' ')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000367 # Write separately in case it's unicode.
Edward Lemur6eb1d322020-02-27 22:20:15 +0000368 sys.stdout.write(str(item))
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000369 if index < len(self._items) - 1:
Edward Lemur6eb1d322020-02-27 22:20:15 +0000370 sys.stdout.write(' \\')
371 sys.stdout.write('\n')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000372 if self._long_text:
Edward Lemur6eb1d322020-02-27 22:20:15 +0000373 sys.stdout.write('\n***************\n')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000374 # Write separately in case it's unicode.
Tom McKee61c72652021-07-20 11:56:32 +0000375 sys.stdout.write(self._long_text)
Edward Lemur6eb1d322020-02-27 22:20:15 +0000376 sys.stdout.write('\n***************\n')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000377
Debrian Figueroadd2737e2019-06-21 23:50:13 +0000378 def json_format(self):
379 return {
380 'message': self._message,
Debrian Figueroa6095d402019-06-28 18:47:18 +0000381 'items': [str(item) for item in self._items],
Debrian Figueroadd2737e2019-06-21 23:50:13 +0000382 'long_text': self._long_text,
383 'fatal': self.fatal
384 }
385
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000386
387# Top level object so multiprocessing can pickle
388# Public access through OutputApi object.
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000389class _PresubmitError(_PresubmitResult):
390 """A hard presubmit error."""
391 fatal = True
392
393
394# Top level object so multiprocessing can pickle
395# Public access through OutputApi object.
396class _PresubmitPromptWarning(_PresubmitResult):
397 """An warning that prompts the user if they want to continue."""
398 should_prompt = True
399
400
401# Top level object so multiprocessing can pickle
402# Public access through OutputApi object.
403class _PresubmitNotifyResult(_PresubmitResult):
404 """Just print something to the screen -- but it's not even a warning."""
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000405
406
407# Top level object so multiprocessing can pickle
408# Public access through OutputApi object.
409class _MailTextResult(_PresubmitResult):
410 """A warning that should be included in the review request email."""
411 def __init__(self, *args, **kwargs):
412 super(_MailTextResult, self).__init__()
413 raise NotImplementedError()
414
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000415class GerritAccessor(object):
416 """Limited Gerrit functionality for canned presubmit checks to work.
417
418 To avoid excessive Gerrit calls, caches the results.
419 """
420
Edward Lesmeseb1bd622021-03-01 19:54:07 +0000421 def __init__(self, url=None, project=None, branch=None):
422 self.host = urlparse.urlparse(url).netloc if url else None
423 self.project = project
424 self.branch = branch
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000425 self.cache = {}
Edward Lesmes8170c292021-03-19 20:04:43 +0000426 self.code_owners_enabled = None
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000427
428 def _FetchChangeDetail(self, issue):
429 # Separate function to be easily mocked in tests.
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +0100430 try:
431 return gerrit_util.GetChangeDetail(
432 self.host, str(issue),
Aaron Gable6f5a8d92017-04-18 14:49:05 -0700433 ['ALL_REVISIONS', 'DETAILED_LABELS', 'ALL_COMMITS'])
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +0100434 except gerrit_util.GerritError as e:
435 if e.http_status == 404:
436 raise Exception('Either Gerrit issue %s doesn\'t exist, or '
437 'no credentials to fetch issue details' % issue)
438 raise
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000439
440 def GetChangeInfo(self, issue):
441 """Returns labels and all revisions (patchsets) for this issue.
442
443 The result is a dictionary according to Gerrit REST Api.
444 https://gerrit-review.googlesource.com/Documentation/rest-api.html
445
446 However, API isn't very clear what's inside, so see tests for example.
447 """
448 assert issue
449 cache_key = int(issue)
450 if cache_key not in self.cache:
451 self.cache[cache_key] = self._FetchChangeDetail(issue)
452 return self.cache[cache_key]
453
454 def GetChangeDescription(self, issue, patchset=None):
455 """If patchset is none, fetches current patchset."""
456 info = self.GetChangeInfo(issue)
457 # info is a reference to cache. We'll modify it here adding description to
458 # it to the right patchset, if it is not yet there.
459
460 # Find revision info for the patchset we want.
461 if patchset is not None:
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +0000462 for rev, rev_info in info['revisions'].items():
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000463 if str(rev_info['_number']) == str(patchset):
464 break
465 else:
466 raise Exception('patchset %s doesn\'t exist in issue %s' % (
467 patchset, issue))
468 else:
469 rev = info['current_revision']
470 rev_info = info['revisions'][rev]
471
Andrii Shyshkalov9c3a4642017-01-24 17:41:22 +0100472 return rev_info['commit']['message']
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000473
Mun Yong Jang603d01e2017-12-19 16:38:30 -0800474 def GetDestRef(self, issue):
475 ref = self.GetChangeInfo(issue)['branch']
476 if not ref.startswith('refs/'):
477 # NOTE: it is possible to create 'refs/x' branch,
478 # aka 'refs/heads/refs/x'. However, this is ill-advised.
479 ref = 'refs/heads/%s' % ref
480 return ref
481
Edward Lesmes02d4b822020-11-11 00:37:35 +0000482 def _GetApproversForLabel(self, issue, label):
483 change_info = self.GetChangeInfo(issue)
484 label_info = change_info.get('labels', {}).get(label, {})
485 values = label_info.get('values', {}).keys()
486 if not values:
487 return []
488 max_value = max(int(v) for v in values)
489 return [v for v in label_info.get('all', [])
490 if v.get('value', 0) == max_value]
491
Edward Lesmesc4566172021-03-19 16:55:13 +0000492 def IsBotCommitApproved(self, issue):
493 return bool(self._GetApproversForLabel(issue, 'Bot-Commit'))
494
Edward Lesmescf49cb82020-11-11 01:08:36 +0000495 def IsOwnersOverrideApproved(self, issue):
496 return bool(self._GetApproversForLabel(issue, 'Owners-Override'))
497
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000498 def GetChangeOwner(self, issue):
499 return self.GetChangeInfo(issue)['owner']['email']
500
501 def GetChangeReviewers(self, issue, approving_only=True):
Aaron Gable8b478f02017-07-31 15:33:19 -0700502 changeinfo = self.GetChangeInfo(issue)
503 if approving_only:
Edward Lesmes02d4b822020-11-11 00:37:35 +0000504 reviewers = self._GetApproversForLabel(issue, 'Code-Review')
Aaron Gable8b478f02017-07-31 15:33:19 -0700505 else:
506 reviewers = changeinfo.get('reviewers', {}).get('REVIEWER', [])
507 return [r.get('email') for r in reviewers]
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000508
Edward Lemure4d329c2020-02-03 20:41:18 +0000509 def UpdateDescription(self, description, issue):
510 gerrit_util.SetCommitMessage(self.host, issue, description, notify='NONE')
511
Edward Lesmes8170c292021-03-19 20:04:43 +0000512 def IsCodeOwnersEnabledOnRepo(self):
513 if self.code_owners_enabled is None:
514 self.code_owners_enabled = gerrit_util.IsCodeOwnersEnabledOnRepo(
Edward Lesmes392c4072021-03-19 21:58:45 +0000515 self.host, self.project)
Edward Lesmes8170c292021-03-19 20:04:43 +0000516 return self.code_owners_enabled
517
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000518
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000519class OutputApi(object):
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000520 """An instance of OutputApi gets passed to presubmit scripts so that they
521 can output various types of results.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000522 """
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000523 PresubmitResult = _PresubmitResult
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000524 PresubmitError = _PresubmitError
525 PresubmitPromptWarning = _PresubmitPromptWarning
526 PresubmitNotifyResult = _PresubmitNotifyResult
527 MailTextResult = _MailTextResult
528
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000529 def __init__(self, is_committing):
530 self.is_committing = is_committing
Daniel Cheng7227d212017-11-17 08:12:37 -0800531 self.more_cc = []
532
533 def AppendCC(self, cc):
534 """Appends a user to cc for this change."""
535 self.more_cc.append(cc)
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000536
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000537 def PresubmitPromptOrNotify(self, *args, **kwargs):
538 """Warn the user when uploading, but only notify if committing."""
539 if self.is_committing:
540 return self.PresubmitNotifyResult(*args, **kwargs)
541 return self.PresubmitPromptWarning(*args, **kwargs)
542
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000543
544class InputApi(object):
545 """An instance of this object is passed to presubmit scripts so they can
546 know stuff about the change they're looking at.
547 """
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000548 # Method could be a function
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800549 # pylint: disable=no-self-use
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000550
maruel@chromium.org3410d912009-06-09 20:56:16 +0000551 # File extensions that are considered source files from a style guide
552 # perspective. Don't modify this list from a presubmit script!
maruel@chromium.orgc33455a2011-06-24 19:14:18 +0000553 #
554 # Files without an extension aren't included in the list. If you want to
local_bot30f774e2020-06-25 18:23:34 +0000555 # filter them as source files, add r'(^|.*?[\\\/])[^.]+$' to the allow list.
local_bot64021412020-07-08 21:05:39 +0000556 # Note that ALL CAPS files are skipped in DEFAULT_FILES_TO_SKIP below.
557 DEFAULT_FILES_TO_CHECK = (
maruel@chromium.org3410d912009-06-09 20:56:16 +0000558 # C++ and friends
Edward Lemura5799e32020-01-17 19:26:51 +0000559 r'.+\.c$', r'.+\.cc$', r'.+\.cpp$', r'.+\.h$', r'.+\.m$', r'.+\.mm$',
560 r'.+\.inl$', r'.+\.asm$', r'.+\.hxx$', r'.+\.hpp$', r'.+\.s$', r'.+\.S$',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000561 # Scripts
Edward Lemura5799e32020-01-17 19:26:51 +0000562 r'.+\.js$', r'.+\.py$', r'.+\.sh$', r'.+\.rb$', r'.+\.pl$', r'.+\.pm$',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000563 # Other
Edward Lemura5799e32020-01-17 19:26:51 +0000564 r'.+\.java$', r'.+\.mk$', r'.+\.am$', r'.+\.css$', r'.+\.mojom$',
565 r'.+\.fidl$'
maruel@chromium.org3410d912009-06-09 20:56:16 +0000566 )
567
568 # Path regexp that should be excluded from being considered containing source
569 # files. Don't modify this list from a presubmit script!
local_bot64021412020-07-08 21:05:39 +0000570 DEFAULT_FILES_TO_SKIP = (
Edward Lemura5799e32020-01-17 19:26:51 +0000571 r'testing_support[\\\/]google_appengine[\\\/].*',
572 r'.*\bexperimental[\\\/].*',
Kent Tamura179dd1e2018-04-26 15:07:41 +0900573 # Exclude third_party/.* but NOT third_party/{WebKit,blink}
574 # (crbug.com/539768 and crbug.com/836555).
Edward Lemura5799e32020-01-17 19:26:51 +0000575 r'.*\bthird_party[\\\/](?!(WebKit|blink)[\\\/]).*',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000576 # Output directories (just in case)
Edward Lemura5799e32020-01-17 19:26:51 +0000577 r'.*\bDebug[\\\/].*',
578 r'.*\bRelease[\\\/].*',
579 r'.*\bxcodebuild[\\\/].*',
580 r'.*\bout[\\\/].*',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000581 # All caps files like README and LICENCE.
Edward Lemura5799e32020-01-17 19:26:51 +0000582 r'.*\b[A-Z0-9_]{2,}$',
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +0000583 # SCM (can happen in dual SCM configuration). (Slightly over aggressive)
Edward Lemura5799e32020-01-17 19:26:51 +0000584 r'(|.*[\\\/])\.git[\\\/].*',
585 r'(|.*[\\\/])\.svn[\\\/].*',
maruel@chromium.org7ccb4bb2011-11-07 20:26:20 +0000586 # There is no point in processing a patch file.
Edward Lemura5799e32020-01-17 19:26:51 +0000587 r'.+\.diff$',
588 r'.+\.patch$',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000589 )
590
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000591 def __init__(self, change, presubmit_path, is_committing,
Edward Lesmes8e282792018-04-03 18:50:29 -0400592 verbose, gerrit_obj, dry_run=None, thread_pool=None, parallel=False):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000593 """Builds an InputApi object.
594
595 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000596 change: A presubmit.Change object.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000597 presubmit_path: The path to the presubmit script being processed.
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000598 is_committing: True if the change is about to be committed.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000599 gerrit_obj: provides basic Gerrit codereview functionality.
600 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -0400601 parallel: if true, all tests reported via input_api.RunTests for all
602 PRESUBMIT files will be run in parallel.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000603 """
maruel@chromium.org9711bba2009-05-22 23:51:39 +0000604 # Version number of the presubmit_support script.
605 self.version = [int(x) for x in __version__.split('.')]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000606 self.change = change
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000607 self.is_committing = is_committing
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000608 self.gerrit = gerrit_obj
tandrii@chromium.org57bafac2016-04-28 05:09:03 +0000609 self.dry_run = dry_run
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000610
Edward Lesmes8e282792018-04-03 18:50:29 -0400611 self.parallel = parallel
612 self.thread_pool = thread_pool or ThreadPool()
613
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000614 # We expose various modules and functions as attributes of the input_api
615 # so that presubmit scripts don't have to import them.
Takeshi Yoshino07a6bea2017-08-02 02:44:06 +0900616 self.ast = ast
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000617 self.basename = os.path.basename
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000618 self.cpplint = cpplint
dcheng091b7db2016-06-16 01:27:51 -0700619 self.fnmatch = fnmatch
Yoshisato Yanagisawa04600b42019-03-15 03:03:41 +0000620 self.gclient_paths = gclient_paths
Yoshisato Yanagisawa57dd17b2019-03-22 09:10:29 +0000621 # TODO(yyanagisawa): stop exposing this when python3 become default.
622 # Since python3's tempfile has TemporaryDirectory, we do not need this.
623 self.temporary_directory = gclient_utils.temporary_directory
dpranke@chromium.org17cc2442012-10-17 21:12:09 +0000624 self.glob = glob.glob
maruel@chromium.orgfb11c7b2010-03-18 18:22:14 +0000625 self.json = json
maruel@chromium.org6fba34d2011-06-02 13:45:12 +0000626 self.logging = logging.getLogger('PRESUBMIT')
maruel@chromium.org2b5ce562011-03-31 16:15:44 +0000627 self.os_listdir = os.listdir
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000628 self.os_path = os.path
pgervais@chromium.orgbd0cace2014-10-02 23:23:46 +0000629 self.os_stat = os.stat
Yoshisato Yanagisawa406de132018-06-29 05:43:25 +0000630 self.os_walk = os.walk
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000631 self.re = re
632 self.subprocess = subprocess
Edward Lemurb9830242019-10-30 22:19:20 +0000633 self.sys = sys
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000634 self.tempfile = tempfile
dpranke@chromium.org0d1bdea2011-03-24 22:54:38 +0000635 self.time = time
maruel@chromium.org1487d532009-06-06 00:22:57 +0000636 self.unittest = unittest
Edward Lemurb9830242019-10-30 22:19:20 +0000637 if sys.version_info.major == 2:
638 self.urllib2 = urllib2
Edward Lemur16af3562019-10-17 22:11:33 +0000639 self.urllib_request = urllib_request
640 self.urllib_error = urllib_error
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000641
Robert Iannucci50258932018-03-19 10:30:59 -0700642 self.is_windows = sys.platform == 'win32'
643
Edward Lemurb9646622019-10-25 20:57:35 +0000644 # Set python_executable to 'vpython' in order to allow scripts in other
645 # repos (e.g. src.git) to automatically pick up that repo's .vpython file,
646 # instead of inheriting the one in depot_tools.
647 self.python_executable = 'vpython'
Erik Staab69135d12021-05-14 22:31:57 +0000648 # Offer a python 3 executable for use during the migration off of python 2.
649 self.python3_executable = 'vpython3'
maruel@chromium.orgc0b22972009-06-25 16:19:14 +0000650 self.environ = os.environ
651
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000652 # InputApi.platform is the platform you're currently running on.
653 self.platform = sys.platform
654
iannucci@chromium.org0af3bb32015-06-12 20:44:35 +0000655 self.cpu_count = multiprocessing.cpu_count()
656
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000657 # The local path of the currently-being-processed presubmit script.
maruel@chromium.org3d235242009-05-15 12:40:48 +0000658 self._current_presubmit_path = os.path.dirname(presubmit_path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000659
660 # We carry the canned checks so presubmit scripts can easily use them.
661 self.canned_checks = presubmit_canned_checks
662
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +0100663 # Temporary files we must manually remove at the end of a run.
664 self._named_temporary_files = []
Jochen Eisinger72606f82017-04-04 10:44:18 +0200665
Edward Lesmesdc11c6b2021-03-19 19:22:05 +0000666 self.owners_client = None
667 if self.gerrit:
Bruce Dawson9b9f4512022-04-27 00:56:52 +0000668 try:
669 self.owners_client = owners_client.GetCodeOwnersClient(
670 root=change.RepositoryRoot(),
671 upstream=change.UpstreamBranch(),
672 host=self.gerrit.host,
673 project=self.gerrit.project,
674 branch=self.gerrit.branch)
675 except Exception as e:
676 print('Failed to set owners_client - %s' % str(e))
Edward Lesmes9ce03f82021-01-12 20:13:31 +0000677 self.owners_db = owners_db.Database(
678 change.RepositoryRoot(), fopen=open, os_path=self.os_path)
Jochen Eisinger76f5fc62017-04-07 16:27:46 +0200679 self.owners_finder = owners_finder.OwnersFinder
maruel@chromium.org899e1c12011-04-07 17:03:18 +0000680 self.verbose = verbose
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000681 self.Command = CommandData
dpranke@chromium.org2a009622011-03-01 02:43:31 +0000682
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000683 # Replace <hash_map> and <hash_set> as headers that need to be included
Edward Lemura5799e32020-01-17 19:26:51 +0000684 # with 'base/containers/hash_tables.h' instead.
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000685 # Access to a protected member _XX of a client class
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800686 # pylint: disable=protected-access
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000687 self.cpplint._re_pattern_templates = [
danakj@chromium.org18278522013-06-11 22:42:32 +0000688 (a, b, 'base/containers/hash_tables.h')
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000689 if header in ('<hash_map>', '<hash_set>') else (a, b, header)
690 for (a, b, header) in cpplint._re_pattern_templates
691 ]
692
Edward Lemurecc27072020-01-06 16:42:34 +0000693 def SetTimeout(self, timeout):
694 self.thread_pool.timeout = timeout
695
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000696 def PresubmitLocalPath(self):
697 """Returns the local path of the presubmit script currently being run.
698
699 This is useful if you don't want to hard-code absolute paths in the
700 presubmit script. For example, It can be used to find another file
701 relative to the PRESUBMIT.py script, so the whole tree can be branched and
702 the presubmit script still works, without editing its content.
703 """
maruel@chromium.org3d235242009-05-15 12:40:48 +0000704 return self._current_presubmit_path
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000705
agable0b65e732016-11-22 09:25:46 -0800706 def AffectedFiles(self, include_deletes=True, file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000707 """Same as input_api.change.AffectedFiles() except only lists files
708 (and optionally directories) in the same directory as the current presubmit
Bruce Dawson7a0b07a2020-04-23 17:14:40 +0000709 script, or subdirectories thereof. Note that files are listed using the OS
710 path separator, so backslashes are used as separators on Windows.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000711 """
Edward Lemura5799e32020-01-17 19:26:51 +0000712 dir_with_slash = normpath('%s/' % self.PresubmitLocalPath())
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000713 if len(dir_with_slash) == 1:
714 dir_with_slash = ''
sail@chromium.org5538e022011-05-12 17:53:16 +0000715
Edward Lemurb9830242019-10-30 22:19:20 +0000716 return list(filter(
maruel@chromium.org4661e0c2009-06-04 00:45:26 +0000717 lambda x: normpath(x.AbsoluteLocalPath()).startswith(dir_with_slash),
Edward Lemurb9830242019-10-30 22:19:20 +0000718 self.change.AffectedFiles(include_deletes, file_filter)))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000719
agable0b65e732016-11-22 09:25:46 -0800720 def LocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000721 """Returns local paths of input_api.AffectedFiles()."""
agable0b65e732016-11-22 09:25:46 -0800722 paths = [af.LocalPath() for af in self.AffectedFiles()]
Edward Lemura5799e32020-01-17 19:26:51 +0000723 logging.debug('LocalPaths: %s', paths)
pgervais@chromium.org2f64f782014-04-25 00:12:33 +0000724 return paths
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000725
agable0b65e732016-11-22 09:25:46 -0800726 def AbsoluteLocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000727 """Returns absolute local paths of input_api.AffectedFiles()."""
agable0b65e732016-11-22 09:25:46 -0800728 return [af.AbsoluteLocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000729
John Budorick16162372018-04-18 10:39:53 -0700730 def AffectedTestableFiles(self, include_deletes=None, **kwargs):
agable0b65e732016-11-22 09:25:46 -0800731 """Same as input_api.change.AffectedTestableFiles() except only lists files
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000732 in the same directory as the current presubmit script, or subdirectories
733 thereof.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000734 """
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000735 if include_deletes is not None:
Edward Lemura5799e32020-01-17 19:26:51 +0000736 warn('AffectedTestableFiles(include_deletes=%s)'
737 ' is deprecated and ignored' % str(include_deletes),
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000738 category=DeprecationWarning,
739 stacklevel=2)
Josip Sokcevic4de5dea2022-03-23 21:15:14 +0000740 # pylint: disable=consider-using-generator
741 return [
742 x for x in self.AffectedFiles(include_deletes=False, **kwargs)
743 if x.IsTestableFile()
744 ]
agable0b65e732016-11-22 09:25:46 -0800745
746 def AffectedTextFiles(self, include_deletes=None):
747 """An alias to AffectedTestableFiles for backwards compatibility."""
748 return self.AffectedTestableFiles(include_deletes=include_deletes)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000749
Josip Sokcevic8c955952021-02-01 21:32:57 +0000750 def FilterSourceFile(self,
751 affected_file,
752 files_to_check=None,
753 files_to_skip=None,
754 allow_list=None,
755 block_list=None):
Edward Lemura5799e32020-01-17 19:26:51 +0000756 """Filters out files that aren't considered 'source file'.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000757
local_bot64021412020-07-08 21:05:39 +0000758 If files_to_check or files_to_skip is None, InputApi.DEFAULT_FILES_TO_CHECK
759 and InputApi.DEFAULT_FILES_TO_SKIP is used respectively.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000760
761 The lists will be compiled as regular expression and
762 AffectedFile.LocalPath() needs to pass both list.
763
764 Note: Copy-paste this function to suit your needs or use a lambda function.
765 """
local_bot64021412020-07-08 21:05:39 +0000766 if files_to_check is None:
767 files_to_check = self.DEFAULT_FILES_TO_CHECK
768 if files_to_skip is None:
769 files_to_skip = self.DEFAULT_FILES_TO_SKIP
local_bot30f774e2020-06-25 18:23:34 +0000770
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000771 def Find(affected_file, items):
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000772 local_path = affected_file.LocalPath()
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000773 for item in items:
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +0000774 if self.re.match(item, local_path):
maruel@chromium.org3410d912009-06-09 20:56:16 +0000775 return True
Bruce Dawsona3a014e2022-04-27 23:28:17 +0000776 # Handle the cases where the files regex only handles /, but the local
777 # path uses \.
778 if self.is_windows and self.re.match(item, local_path.replace(
779 '\\', '/')):
780 return True
maruel@chromium.org3410d912009-06-09 20:56:16 +0000781 return False
local_bot64021412020-07-08 21:05:39 +0000782 return (Find(affected_file, files_to_check) and
783 not Find(affected_file, files_to_skip))
maruel@chromium.org3410d912009-06-09 20:56:16 +0000784
785 def AffectedSourceFiles(self, source_file):
agable0b65e732016-11-22 09:25:46 -0800786 """Filter the list of AffectedTestableFiles by the function source_file.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000787
788 If source_file is None, InputApi.FilterSourceFile() is used.
789 """
790 if not source_file:
791 source_file = self.FilterSourceFile
Edward Lemurb9830242019-10-30 22:19:20 +0000792 return list(filter(source_file, self.AffectedTestableFiles()))
maruel@chromium.org3410d912009-06-09 20:56:16 +0000793
794 def RightHandSideLines(self, source_file_filter=None):
Edward Lemura5799e32020-01-17 19:26:51 +0000795 """An iterator over all text lines in 'new' version of changed files.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000796
797 Only lists lines from new or modified text files in the change that are
798 contained by the directory of the currently executing presubmit script.
799
800 This is useful for doing line-by-line regex checks, like checking for
801 trailing whitespace.
802
803 Yields:
804 a 3 tuple:
805 the AffectedFile instance of the current file;
806 integer line number (1-based); and
807 the contents of the line as a string.
maruel@chromium.org1487d532009-06-06 00:22:57 +0000808
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000809 Note: The carriage return (LF or CR) is stripped off.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000810 """
maruel@chromium.org3410d912009-06-09 20:56:16 +0000811 files = self.AffectedSourceFiles(source_file_filter)
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000812 return _RightHandSideLinesImpl(files)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000813
maruel@chromium.orge3608df2009-11-10 20:22:57 +0000814 def ReadFile(self, file_item, mode='r'):
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000815 """Reads an arbitrary file.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000816
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000817 Deny reading anything outside the repository.
818 """
maruel@chromium.orge3608df2009-11-10 20:22:57 +0000819 if isinstance(file_item, AffectedFile):
820 file_item = file_item.AbsoluteLocalPath()
821 if not file_item.startswith(self.change.RepositoryRoot()):
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000822 raise IOError('Access outside the repository root is denied.')
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +0000823 return gclient_utils.FileRead(file_item, mode)
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000824
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +0100825 def CreateTemporaryFile(self, **kwargs):
826 """Returns a named temporary file that must be removed with a call to
827 RemoveTemporaryFiles().
828
829 All keyword arguments are forwarded to tempfile.NamedTemporaryFile(),
830 except for |delete|, which is always set to False.
831
832 Presubmit checks that need to create a temporary file and pass it for
833 reading should use this function instead of NamedTemporaryFile(), as
834 Windows fails to open a file that is already open for writing.
835
836 with input_api.CreateTemporaryFile() as f:
837 f.write('xyz')
838 f.close()
839 input_api.subprocess.check_output(['script-that', '--reads-from',
840 f.name])
841
842
843 Note that callers of CreateTemporaryFile() should not worry about removing
844 any temporary file; this is done transparently by the presubmit handling
845 code.
846 """
847 if 'delete' in kwargs:
848 # Prevent users from passing |delete|; we take care of file deletion
849 # ourselves and this prevents unintuitive error messages when we pass
850 # delete=False and 'delete' is also in kwargs.
851 raise TypeError('CreateTemporaryFile() does not take a "delete" '
852 'argument, file deletion is handled automatically by '
853 'the same presubmit_support code that creates InputApi '
854 'objects.')
855 temp_file = self.tempfile.NamedTemporaryFile(delete=False, **kwargs)
856 self._named_temporary_files.append(temp_file.name)
857 return temp_file
858
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000859 @property
860 def tbr(self):
861 """Returns if a change is TBR'ed."""
Jeremy Romandce22502017-06-20 15:37:29 -0400862 return 'TBR' in self.change.tags or self.change.TBRsFromDescription()
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000863
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +0000864 def RunTests(self, tests_mix, parallel=True):
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000865 tests = []
866 msgs = []
867 for t in tests_mix:
Edward Lesmes8e282792018-04-03 18:50:29 -0400868 if isinstance(t, OutputApi.PresubmitResult) and t:
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000869 msgs.append(t)
870 else:
871 assert issubclass(t.message, _PresubmitResult)
872 tests.append(t)
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +0000873 if self.verbose:
874 t.info = _PresubmitNotifyResult
Edward Lemur1037c742018-05-01 18:56:04 -0400875 if not t.kwargs.get('cwd'):
876 t.kwargs['cwd'] = self.PresubmitLocalPath()
Edward Lesmes8e282792018-04-03 18:50:29 -0400877 self.thread_pool.AddTests(tests, parallel)
Edward Lemur21000eb2019-05-24 23:25:58 +0000878 # When self.parallel is True (i.e. --parallel is passed as an option)
879 # RunTests doesn't actually run tests. It adds them to a ThreadPool that
880 # will run all tests once all PRESUBMIT files are processed.
881 # Otherwise, it will run them and return the results.
882 if not self.parallel:
Edward Lesmes8e282792018-04-03 18:50:29 -0400883 msgs.extend(self.thread_pool.RunAsync())
884 return msgs
scottmg86099d72016-09-01 09:16:51 -0700885
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000886
nick@chromium.orgff526192013-06-10 19:30:26 +0000887class _DiffCache(object):
888 """Caches diffs retrieved from a particular SCM."""
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000889 def __init__(self, upstream=None):
890 """Stores the upstream revision against which all diffs will be computed."""
891 self._upstream = upstream
nick@chromium.orgff526192013-06-10 19:30:26 +0000892
893 def GetDiff(self, path, local_root):
894 """Get the diff for a particular path."""
895 raise NotImplementedError()
896
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700897 def GetOldContents(self, path, local_root):
898 """Get the old version for a particular path."""
899 raise NotImplementedError()
900
nick@chromium.orgff526192013-06-10 19:30:26 +0000901
nick@chromium.orgff526192013-06-10 19:30:26 +0000902class _GitDiffCache(_DiffCache):
903 """DiffCache implementation for git; gets all file diffs at once."""
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000904 def __init__(self, upstream):
905 super(_GitDiffCache, self).__init__(upstream=upstream)
nick@chromium.orgff526192013-06-10 19:30:26 +0000906 self._diffs_by_file = None
907
908 def GetDiff(self, path, local_root):
Bruce Dawson5f63d3c2022-04-19 17:02:36 +0000909 # Compare against None to distinguish between None and an initialized but
910 # empty dictionary.
911 if self._diffs_by_file == None:
nick@chromium.orgff526192013-06-10 19:30:26 +0000912 # Compute a single diff for all files and parse the output; should
913 # with git this is much faster than computing one diff for each file.
914 diffs = {}
915
916 # Don't specify any filenames below, because there are command line length
917 # limits on some platforms and GenerateDiff would fail.
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000918 unified_diff = scm.GIT.GenerateDiff(local_root, files=[], full_move=True,
919 branch=self._upstream)
nick@chromium.orgff526192013-06-10 19:30:26 +0000920
921 # This regex matches the path twice, separated by a space. Note that
922 # filename itself may contain spaces.
923 file_marker = re.compile('^diff --git (?P<filename>.*) (?P=filename)$')
924 current_diff = []
925 keep_line_endings = True
926 for x in unified_diff.splitlines(keep_line_endings):
927 match = file_marker.match(x)
928 if match:
929 # Marks the start of a new per-file section.
930 diffs[match.group('filename')] = current_diff = [x]
931 elif x.startswith('diff --git'):
932 raise PresubmitFailure('Unexpected diff line: %s' % x)
933 else:
934 current_diff.append(x)
935
936 self._diffs_by_file = dict(
937 (normpath(path), ''.join(diff)) for path, diff in diffs.items())
938
939 if path not in self._diffs_by_file:
Josip Sokcevicc1ab7342022-02-24 19:02:44 +0000940 # SCM didn't have any diff on this file. It could be that the file was not
941 # modified at all (e.g. user used --all flag in git cl presubmit).
942 # Intead of failing, return empty string.
943 # See: https://crbug.com/808346.
Josip Sokcevicc1ab7342022-02-24 19:02:44 +0000944 return ''
nick@chromium.orgff526192013-06-10 19:30:26 +0000945
946 return self._diffs_by_file[path]
947
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700948 def GetOldContents(self, path, local_root):
949 return scm.GIT.GetOldContents(local_root, path, branch=self._upstream)
950
nick@chromium.orgff526192013-06-10 19:30:26 +0000951
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000952class AffectedFile(object):
953 """Representation of a file in a change."""
nick@chromium.orgff526192013-06-10 19:30:26 +0000954
955 DIFF_CACHE = _DiffCache
956
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000957 # Method could be a function
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800958 # pylint: disable=no-self-use
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000959 def __init__(self, path, action, repository_root, diff_cache):
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000960 self._path = path
961 self._action = action
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000962 self._local_root = repository_root
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000963 self._is_directory = None
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000964 self._cached_changed_contents = None
965 self._cached_new_contents = None
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000966 self._diff_cache = diff_cache
tobiasjs2836bcf2016-08-16 04:08:16 -0700967 logging.debug('%s(%s)', self.__class__.__name__, self._path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000968
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000969 def LocalPath(self):
970 """Returns the path of this file on the local disk relative to client root.
Andrew Grieve92b8b992017-11-02 09:42:24 -0400971
972 This should be used for error messages but not for accessing files,
973 because presubmit checks are run with CWD=PresubmitLocalPath() (which is
974 often != client root).
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000975 """
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000976 return normpath(self._path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000977
978 def AbsoluteLocalPath(self):
979 """Returns the absolute path of this file on the local disk.
980 """
chase@chromium.org8e416c82009-10-06 04:30:44 +0000981 return os.path.abspath(os.path.join(self._local_root, self.LocalPath()))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000982
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000983 def Action(self):
984 """Returns the action on this opened file, e.g. A, M, D, etc."""
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000985 return self._action
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000986
agable0b65e732016-11-22 09:25:46 -0800987 def IsTestableFile(self):
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000988 """Returns True if the file is a text file and not a binary file.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000989
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000990 Deleted files are not text file."""
maruel@chromium.org1e08c002009-05-28 19:09:33 +0000991 raise NotImplementedError() # Implement when needed
992
agable0b65e732016-11-22 09:25:46 -0800993 def IsTextFile(self):
994 """An alias to IsTestableFile for backwards compatibility."""
995 return self.IsTestableFile()
996
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700997 def OldContents(self):
998 """Returns an iterator over the lines in the old version of file.
999
Daniel Cheng2da34fe2017-03-21 20:42:12 -07001000 The old version is the file before any modifications in the user's
Edward Lemura5799e32020-01-17 19:26:51 +00001001 workspace, i.e. the 'left hand side'.
Daniel Cheng7a1f04d2017-03-21 19:12:31 -07001002
1003 Contents will be empty if the file is a directory or does not exist.
1004 Note: The carriage returns (LF or CR) are stripped off.
1005 """
1006 return self._diff_cache.GetOldContents(self.LocalPath(),
1007 self._local_root).splitlines()
1008
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001009 def NewContents(self):
1010 """Returns an iterator over the lines in the new version of file.
1011
Edward Lemura5799e32020-01-17 19:26:51 +00001012 The new version is the file in the user's workspace, i.e. the 'right hand
1013 side'.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001014
1015 Contents will be empty if the file is a directory or does not exist.
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +00001016 Note: The carriage returns (LF or CR) are stripped off.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001017 """
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +00001018 if self._cached_new_contents is None:
1019 self._cached_new_contents = []
agable0b65e732016-11-22 09:25:46 -08001020 try:
1021 self._cached_new_contents = gclient_utils.FileRead(
1022 self.AbsoluteLocalPath(), 'rU').splitlines()
1023 except IOError:
1024 pass # File not found? That's fine; maybe it was deleted.
Greg Thompson30cde452021-06-01 16:38:47 +00001025 except UnicodeDecodeError as e:
Dirk Pranke6fc394f2021-05-26 23:25:14 +00001026 # log the filename since we're probably trying to read a binary
1027 # file, and shouldn't be.
1028 print('Error reading %s: %s' % (self.AbsoluteLocalPath(), e))
1029 raise
1030
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +00001031 return self._cached_new_contents[:]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001032
Bruce Dawsonf0bcfdd2021-05-21 18:10:23 +00001033 def ChangedContents(self, keeplinebreaks=False):
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001034 """Returns a list of tuples (line number, line text) of all new lines.
1035
1036 This relies on the scm diff output describing each changed code section
1037 with a line of the form
1038
1039 ^@@ <old line num>,<old size> <new line num>,<new size> @@$
1040 """
Bruce Dawsonf0bcfdd2021-05-21 18:10:23 +00001041 # Don't return cached results when line breaks are requested.
1042 if not keeplinebreaks and self._cached_changed_contents is not None:
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +00001043 return self._cached_changed_contents[:]
Bruce Dawsonf0bcfdd2021-05-21 18:10:23 +00001044 result = []
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001045 line_num = 0
1046
Bruce Dawsonf0bcfdd2021-05-21 18:10:23 +00001047 # The keeplinebreaks parameter to splitlines must be True or else the
1048 # CheckForWindowsLineEndings presubmit will be a NOP.
1049 for line in self.GenerateScmDiff().splitlines(keeplinebreaks):
Edward Lemurac5c55f2020-02-29 00:17:16 +00001050 m = re.match(r'^@@ [0-9\,\+\-]+ \+([0-9]+)\,[0-9]+ @@', line)
1051 if m:
1052 line_num = int(m.groups(1)[0])
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001053 continue
1054 if line.startswith('+') and not line.startswith('++'):
Bruce Dawsonf0bcfdd2021-05-21 18:10:23 +00001055 result.append((line_num, line[1:]))
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001056 if not line.startswith('-'):
1057 line_num += 1
Bruce Dawsonf0bcfdd2021-05-21 18:10:23 +00001058 # Don't cache results with line breaks.
1059 if keeplinebreaks:
1060 return result;
1061 self._cached_changed_contents = result
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +00001062 return self._cached_changed_contents[:]
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001063
maruel@chromium.org5de13972009-06-10 18:16:06 +00001064 def __str__(self):
1065 return self.LocalPath()
1066
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001067 def GenerateScmDiff(self):
nick@chromium.orgff526192013-06-10 19:30:26 +00001068 return self._diff_cache.GetDiff(self.LocalPath(), self._local_root)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001069
maruel@chromium.org58407af2011-04-12 23:15:57 +00001070
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001071class GitAffectedFile(AffectedFile):
1072 """Representation of a file in a change out of a git checkout."""
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +00001073 # Method 'NNN' is abstract in class 'NNN' but is not overridden
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -08001074 # pylint: disable=abstract-method
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001075
nick@chromium.orgff526192013-06-10 19:30:26 +00001076 DIFF_CACHE = _GitDiffCache
1077
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001078 def __init__(self, *args, **kwargs):
1079 AffectedFile.__init__(self, *args, **kwargs)
1080 self._server_path = None
agable0b65e732016-11-22 09:25:46 -08001081 self._is_testable_file = None
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001082
agable0b65e732016-11-22 09:25:46 -08001083 def IsTestableFile(self):
1084 if self._is_testable_file is None:
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001085 if self.Action() == 'D':
agable0b65e732016-11-22 09:25:46 -08001086 # A deleted file is not testable.
1087 self._is_testable_file = False
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001088 else:
agable0b65e732016-11-22 09:25:46 -08001089 self._is_testable_file = os.path.isfile(self.AbsoluteLocalPath())
1090 return self._is_testable_file
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001091
maruel@chromium.orgc1938752011-04-12 23:11:13 +00001092
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001093class Change(object):
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001094 """Describe a change.
1095
1096 Used directly by the presubmit scripts to query the current change being
1097 tested.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +00001098
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001099 Instance members:
nick@chromium.orgff526192013-06-10 19:30:26 +00001100 tags: Dictionary of KEY=VALUE pairs found in the change description.
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001101 self.KEY: equivalent to tags['KEY']
1102 """
1103
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001104 _AFFECTED_FILES = AffectedFile
1105
Edward Lemura5799e32020-01-17 19:26:51 +00001106 # Matches key/value (or 'tag') lines in changelist descriptions.
maruel@chromium.org428342a2011-11-10 15:46:33 +00001107 TAG_LINE_RE = re.compile(
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001108 '^[ \t]*(?P<key>[A-Z][A-Z_0-9]*)[ \t]*=[ \t]*(?P<value>.*?)[ \t]*$')
maruel@chromium.orgc1938752011-04-12 23:11:13 +00001109 scm = ''
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001110
maruel@chromium.org58407af2011-04-12 23:15:57 +00001111 def __init__(
agable@chromium.orgea84ef12014-04-30 19:55:12 +00001112 self, name, description, local_root, files, issue, patchset, author,
1113 upstream=None):
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001114 if files is None:
1115 files = []
1116 self._name = name
chase@chromium.org8e416c82009-10-06 04:30:44 +00001117 # Convert root into an absolute path.
1118 self._local_root = os.path.abspath(local_root)
agable@chromium.orgea84ef12014-04-30 19:55:12 +00001119 self._upstream = upstream
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001120 self.issue = issue
1121 self.patchset = patchset
maruel@chromium.org58407af2011-04-12 23:15:57 +00001122 self.author_email = author
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001123
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001124 self._full_description = ''
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001125 self.tags = {}
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001126 self._description_without_tags = ''
1127 self.SetDescriptionText(description)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001128
maruel@chromium.orge085d812011-10-10 19:49:15 +00001129 assert all(
1130 (isinstance(f, (list, tuple)) and len(f) == 2) for f in files), files
1131
agable@chromium.orgea84ef12014-04-30 19:55:12 +00001132 diff_cache = self._AFFECTED_FILES.DIFF_CACHE(self._upstream)
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001133 self._affected_files = [
nick@chromium.orgff526192013-06-10 19:30:26 +00001134 self._AFFECTED_FILES(path, action.strip(), self._local_root, diff_cache)
1135 for action, path in files
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +00001136 ]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001137
Edward Lesmes9ce03f82021-01-12 20:13:31 +00001138 def UpstreamBranch(self):
1139 """Returns the upstream branch for the change."""
1140 return self._upstream
1141
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001142 def Name(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001143 """Returns the change name."""
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001144 return self._name
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001145
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001146 def DescriptionText(self):
1147 """Returns the user-entered changelist description, minus tags.
1148
Edward Lemura5799e32020-01-17 19:26:51 +00001149 Any line in the user-provided description starting with e.g. 'FOO='
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001150 (whitespace permitted before and around) is considered a tag line. Such
1151 lines are stripped out of the description this function returns.
1152 """
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001153 return self._description_without_tags
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001154
1155 def FullDescriptionText(self):
1156 """Returns the complete changelist description including tags."""
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001157 return self._full_description
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001158
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001159 def SetDescriptionText(self, description):
1160 """Sets the full description text (including tags) to |description|.
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001161
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001162 Also updates the list of tags."""
1163 self._full_description = description
1164
1165 # From the description text, build up a dictionary of key/value pairs
Edward Lemura5799e32020-01-17 19:26:51 +00001166 # plus the description minus all key/value or 'tag' lines.
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001167 description_without_tags = []
1168 self.tags = {}
1169 for line in self._full_description.splitlines():
1170 m = self.TAG_LINE_RE.match(line)
1171 if m:
1172 self.tags[m.group('key')] = m.group('value')
1173 else:
1174 description_without_tags.append(line)
1175
1176 # Change back to text and remove whitespace at end.
1177 self._description_without_tags = (
1178 '\n'.join(description_without_tags).rstrip())
1179
Edward Lemur69bb8be2020-02-03 20:37:38 +00001180 def AddDescriptionFooter(self, key, value):
1181 """Adds the given footer to the change description.
1182
1183 Args:
1184 key: A string with the key for the git footer. It must conform to
1185 the git footers format (i.e. 'List-Of-Tokens') and will be case
1186 normalized so that each token is title-cased.
1187 value: A string with the value for the git footer.
1188 """
1189 description = git_footers.add_footer(
1190 self.FullDescriptionText(), git_footers.normalize_name(key), value)
1191 self.SetDescriptionText(description)
1192
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001193 def RepositoryRoot(self):
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001194 """Returns the repository (checkout) root directory for this change,
1195 as an absolute path.
1196 """
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001197 return self._local_root
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001198
1199 def __getattr__(self, attr):
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001200 """Return tags directly as attributes on the object."""
Edward Lemura5799e32020-01-17 19:26:51 +00001201 if not re.match(r'^[A-Z_]*$', attr):
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001202 raise AttributeError(self, attr)
maruel@chromium.orge1a524f2009-05-27 14:43:46 +00001203 return self.tags.get(attr)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001204
Edward Lemur69bb8be2020-02-03 20:37:38 +00001205 def GitFootersFromDescription(self):
1206 """Return the git footers present in the description.
1207
1208 Returns:
1209 footers: A dict of {footer: [values]} containing a multimap of the footers
1210 in the change description.
1211 """
1212 return git_footers.parse_footers(self.FullDescriptionText())
1213
Aaron Gablefc03e672017-05-15 14:09:42 -07001214 def BugsFromDescription(self):
1215 """Returns all bugs referenced in the commit description."""
Sean McAllister1e509c52021-10-25 17:54:25 +00001216 bug_tags = ['BUG', 'FIXED']
1217
1218 tags = []
1219 for tag in bug_tags:
1220 values = self.tags.get(tag)
1221 if values:
1222 tags += [value.strip() for value in values.split(',')]
1223
Caleb Rouleauc0546b92019-02-22 06:12:57 +00001224 footers = []
Edward Lemur69bb8be2020-02-03 20:37:38 +00001225 parsed = self.GitFootersFromDescription()
Dan Beam62954042019-10-03 21:20:33 +00001226 unsplit_footers = parsed.get('Bug', []) + parsed.get('Fixed', [])
Caleb Rouleauc0546b92019-02-22 06:12:57 +00001227 for unsplit_footer in unsplit_footers:
1228 footers += [b.strip() for b in unsplit_footer.split(',')]
Aaron Gable12ef5012017-05-15 14:29:00 -07001229 return sorted(set(tags + footers))
Aaron Gablefc03e672017-05-15 14:09:42 -07001230
1231 def ReviewersFromDescription(self):
1232 """Returns all reviewers listed in the commit description."""
Edward Lemura5799e32020-01-17 19:26:51 +00001233 # We don't support a 'R:' git-footer for reviewers; that is in metadata.
Aaron Gable12ef5012017-05-15 14:29:00 -07001234 tags = [r.strip() for r in self.tags.get('R', '').split(',') if r.strip()]
1235 return sorted(set(tags))
Aaron Gablefc03e672017-05-15 14:09:42 -07001236
1237 def TBRsFromDescription(self):
1238 """Returns all TBR reviewers listed in the commit description."""
Aaron Gable12ef5012017-05-15 14:29:00 -07001239 tags = [r.strip() for r in self.tags.get('TBR', '').split(',') if r.strip()]
Aaron Gable6e7ddb62020-05-27 22:23:29 +00001240 # TODO(crbug.com/839208): Remove support for 'Tbr:' when TBRs are
1241 # programmatically determined by self-CR+1s.
Edward Lemur69bb8be2020-02-03 20:37:38 +00001242 footers = self.GitFootersFromDescription().get('Tbr', [])
Aaron Gable12ef5012017-05-15 14:29:00 -07001243 return sorted(set(tags + footers))
Aaron Gablefc03e672017-05-15 14:09:42 -07001244
Aaron Gable6e7ddb62020-05-27 22:23:29 +00001245 # TODO(crbug.com/753425): Delete these once we're sure they're unused.
Aaron Gablefc03e672017-05-15 14:09:42 -07001246 @property
1247 def BUG(self):
1248 return ','.join(self.BugsFromDescription())
1249 @property
1250 def R(self):
1251 return ','.join(self.ReviewersFromDescription())
1252 @property
1253 def TBR(self):
1254 return ','.join(self.TBRsFromDescription())
1255
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001256 def AllFiles(self, root=None):
1257 """List all files under source control in the repo."""
1258 raise NotImplementedError()
1259
agable0b65e732016-11-22 09:25:46 -08001260 def AffectedFiles(self, include_deletes=True, file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001261 """Returns a list of AffectedFile instances for all files in the change.
1262
1263 Args:
1264 include_deletes: If false, deleted files will be filtered out.
sail@chromium.org5538e022011-05-12 17:53:16 +00001265 file_filter: An additional filter to apply.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001266
1267 Returns:
1268 [AffectedFile(path, action), AffectedFile(path, action)]
1269 """
Edward Lemurb9830242019-10-30 22:19:20 +00001270 affected = list(filter(file_filter, self._affected_files))
sail@chromium.org5538e022011-05-12 17:53:16 +00001271
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001272 if include_deletes:
1273 return affected
Edward Lemurb9830242019-10-30 22:19:20 +00001274 return list(filter(lambda x: x.Action() != 'D', affected))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001275
John Budorick16162372018-04-18 10:39:53 -07001276 def AffectedTestableFiles(self, include_deletes=None, **kwargs):
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +00001277 """Return a list of the existing text files in a change."""
1278 if include_deletes is not None:
Edward Lemura5799e32020-01-17 19:26:51 +00001279 warn('AffectedTeestableFiles(include_deletes=%s)'
1280 ' is deprecated and ignored' % str(include_deletes),
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +00001281 category=DeprecationWarning,
1282 stacklevel=2)
Edward Lemurb9830242019-10-30 22:19:20 +00001283 return list(filter(
1284 lambda x: x.IsTestableFile(),
1285 self.AffectedFiles(include_deletes=False, **kwargs)))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001286
agable0b65e732016-11-22 09:25:46 -08001287 def AffectedTextFiles(self, include_deletes=None):
1288 """An alias to AffectedTestableFiles for backwards compatibility."""
1289 return self.AffectedTestableFiles(include_deletes=include_deletes)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001290
agable0b65e732016-11-22 09:25:46 -08001291 def LocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001292 """Convenience function."""
agable0b65e732016-11-22 09:25:46 -08001293 return [af.LocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001294
agable0b65e732016-11-22 09:25:46 -08001295 def AbsoluteLocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001296 """Convenience function."""
agable0b65e732016-11-22 09:25:46 -08001297 return [af.AbsoluteLocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001298
1299 def RightHandSideLines(self):
Edward Lemura5799e32020-01-17 19:26:51 +00001300 """An iterator over all text lines in 'new' version of changed files.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001301
1302 Lists lines from new or modified text files in the change.
1303
1304 This is useful for doing line-by-line regex checks, like checking for
1305 trailing whitespace.
1306
1307 Yields:
1308 a 3 tuple:
1309 the AffectedFile instance of the current file;
1310 integer line number (1-based); and
1311 the contents of the line as a string.
1312 """
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +00001313 return _RightHandSideLinesImpl(
1314 x for x in self.AffectedFiles(include_deletes=False)
agable0b65e732016-11-22 09:25:46 -08001315 if x.IsTestableFile())
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001316
Jochen Eisingerd0573ec2017-04-13 10:55:06 +02001317 def OriginalOwnersFiles(self):
1318 """A map from path names of affected OWNERS files to their old content."""
1319 def owners_file_filter(f):
1320 return 'OWNERS' in os.path.split(f.LocalPath())[1]
1321 files = self.AffectedFiles(file_filter=owners_file_filter)
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +00001322 return {f.LocalPath(): f.OldContents() for f in files}
Jochen Eisingerd0573ec2017-04-13 10:55:06 +02001323
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001324
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001325class GitChange(Change):
1326 _AFFECTED_FILES = GitAffectedFile
maruel@chromium.orgc1938752011-04-12 23:11:13 +00001327 scm = 'git'
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +00001328
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001329 def AllFiles(self, root=None):
1330 """List all files under source control in the repo."""
1331 root = root or self.RepositoryRoot()
1332 return subprocess.check_output(
Aaron Gable7817f022017-12-12 09:43:17 -08001333 ['git', '-c', 'core.quotePath=false', 'ls-files', '--', '.'],
Josip Sokcevic0b123462021-06-08 20:41:32 +00001334 cwd=root).decode('utf-8', 'ignore').splitlines()
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001335
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001336
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001337def ListRelevantPresubmitFiles(files, root):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001338 """Finds all presubmit files that apply to a given set of source files.
1339
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001340 If inherit-review-settings-ok is present right under root, looks for
1341 PRESUBMIT.py in directories enclosing root.
1342
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001343 Args:
1344 files: An iterable container containing file paths.
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001345 root: Path where to stop searching.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001346
1347 Return:
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001348 List of absolute paths of the existing PRESUBMIT.py scripts.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001349 """
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001350 files = [normpath(os.path.join(root, f)) for f in files]
1351
1352 # List all the individual directories containing files.
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +00001353 directories = {os.path.dirname(f) for f in files}
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001354
1355 # Ignore root if inherit-review-settings-ok is present.
1356 if os.path.isfile(os.path.join(root, 'inherit-review-settings-ok')):
1357 root = None
1358
1359 # Collect all unique directories that may contain PRESUBMIT.py.
1360 candidates = set()
1361 for directory in directories:
1362 while True:
1363 if directory in candidates:
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001364 break
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001365 candidates.add(directory)
1366 if directory == root:
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001367 break
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001368 parent_dir = os.path.dirname(directory)
1369 if parent_dir == directory:
1370 # We hit the system root directory.
1371 break
1372 directory = parent_dir
1373
1374 # Look for PRESUBMIT.py in all candidate directories.
1375 results = []
1376 for directory in sorted(list(candidates)):
tobiasjsff061c02016-08-17 03:23:57 -07001377 try:
1378 for f in os.listdir(directory):
1379 p = os.path.join(directory, f)
1380 if os.path.isfile(p) and re.match(
1381 r'PRESUBMIT.*\.py$', f) and not f.startswith('PRESUBMIT_test'):
1382 results.append(p)
1383 except OSError:
1384 pass
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001385
tobiasjs2836bcf2016-08-16 04:08:16 -07001386 logging.debug('Presubmit files: %s', ','.join(results))
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001387 return results
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001388
1389
rmistry@google.com5626a922015-02-26 14:03:30 +00001390class GetPostUploadExecuter(object):
Josip Sokcevice293d3d2022-02-16 22:52:15 +00001391 def __init__(self, use_python3):
1392 """
1393 Args:
1394 use_python3: if true, will use python3 instead of python2 by default
1395 if USE_PYTHON3 is not specified.
1396 """
1397 self.use_python3 = use_python3
1398
1399 def ExecPresubmitScript(self, script_text, presubmit_path, gerrit_obj,
1400 change):
rmistry@google.com5626a922015-02-26 14:03:30 +00001401 """Executes PostUploadHook() from a single presubmit script.
1402
1403 Args:
1404 script_text: The text of the presubmit script.
1405 presubmit_path: Project script to run.
Edward Lemur016a0872020-02-04 22:13:28 +00001406 gerrit_obj: The GerritAccessor object.
rmistry@google.com5626a922015-02-26 14:03:30 +00001407 change: The Change object.
1408
1409 Return:
1410 A list of results objects.
1411 """
Josip Sokcevice293d3d2022-02-16 22:52:15 +00001412 if not _ShouldRunPresubmit(script_text, self.use_python3):
1413 return {}
1414
rmistry@google.com5626a922015-02-26 14:03:30 +00001415 context = {}
1416 try:
Raul Tambre09e64b42019-05-14 01:57:22 +00001417 exec(compile(script_text, 'PRESUBMIT.py', 'exec', dont_inherit=True),
1418 context)
Raul Tambre7c938462019-05-24 16:35:35 +00001419 except Exception as e:
rmistry@google.com5626a922015-02-26 14:03:30 +00001420 raise PresubmitFailure('"%s" had an exception.\n%s'
1421 % (presubmit_path, e))
1422
1423 function_name = 'PostUploadHook'
1424 if function_name not in context:
1425 return {}
1426 post_upload_hook = context[function_name]
1427 if not len(inspect.getargspec(post_upload_hook)[0]) == 3:
1428 raise PresubmitFailure(
1429 'Expected function "PostUploadHook" to take three arguments.')
Edward Lemur016a0872020-02-04 22:13:28 +00001430 return post_upload_hook(gerrit_obj, change, OutputApi(False))
rmistry@google.com5626a922015-02-26 14:03:30 +00001431
1432
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001433def _MergeMasters(masters1, masters2):
1434 """Merges two master maps. Merges also the tests of each builder."""
1435 result = {}
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001436 for (master, builders) in itertools.chain(masters1.items(),
1437 masters2.items()):
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001438 new_builders = result.setdefault(master, {})
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001439 for (builder, tests) in builders.items():
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001440 new_builders.setdefault(builder, set([])).update(tests)
1441 return result
1442
1443
Josip Sokcevice293d3d2022-02-16 22:52:15 +00001444def DoPostUploadExecuter(change, gerrit_obj, verbose, use_python3=False):
rmistry@google.com5626a922015-02-26 14:03:30 +00001445 """Execute the post upload hook.
1446
1447 Args:
1448 change: The Change object.
Edward Lemur016a0872020-02-04 22:13:28 +00001449 gerrit_obj: The GerritAccessor object.
rmistry@google.com5626a922015-02-26 14:03:30 +00001450 verbose: Prints debug info.
Josip Sokcevice293d3d2022-02-16 22:52:15 +00001451 use_python3: if true, default to using Python3 for presubmit checks
1452 rather than Python2.
rmistry@google.com5626a922015-02-26 14:03:30 +00001453 """
Josip Sokcevice293d3d2022-02-16 22:52:15 +00001454 python_version = 'Python %s' % sys.version_info.major
1455 sys.stdout.write('Running %s post upload checks ...\n' % python_version)
rmistry@google.com5626a922015-02-26 14:03:30 +00001456 presubmit_files = ListRelevantPresubmitFiles(
Edward Lemur6eb1d322020-02-27 22:20:15 +00001457 change.LocalPaths(), change.RepositoryRoot())
rmistry@google.com5626a922015-02-26 14:03:30 +00001458 if not presubmit_files and verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001459 sys.stdout.write('Warning, no PRESUBMIT.py found.\n')
rmistry@google.com5626a922015-02-26 14:03:30 +00001460 results = []
Josip Sokcevice293d3d2022-02-16 22:52:15 +00001461 executer = GetPostUploadExecuter(use_python3)
rmistry@google.com5626a922015-02-26 14:03:30 +00001462 # The root presubmit file should be executed after the ones in subdirectories.
1463 # i.e. the specific post upload hooks should run before the general ones.
1464 # Thus, reverse the order provided by ListRelevantPresubmitFiles.
1465 presubmit_files.reverse()
1466
1467 for filename in presubmit_files:
1468 filename = os.path.abspath(filename)
1469 if verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001470 sys.stdout.write('Running %s\n' % filename)
rmistry@google.com5626a922015-02-26 14:03:30 +00001471 # Accept CRLF presubmit script.
1472 presubmit_script = gclient_utils.FileRead(filename, 'rU')
1473 results.extend(executer.ExecPresubmitScript(
Edward Lemur016a0872020-02-04 22:13:28 +00001474 presubmit_script, filename, gerrit_obj, change))
rmistry@google.com5626a922015-02-26 14:03:30 +00001475
Edward Lemur6eb1d322020-02-27 22:20:15 +00001476 if not results:
1477 return 0
1478
1479 sys.stdout.write('\n')
1480 sys.stdout.write('** Post Upload Hook Messages **\n')
1481
1482 exit_code = 0
1483 for result in results:
1484 if result.fatal:
1485 exit_code = 1
1486 result.handle()
1487 sys.stdout.write('\n')
1488
1489 return exit_code
rmistry@google.com5626a922015-02-26 14:03:30 +00001490
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001491class PresubmitExecuter(object):
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001492 def __init__(self, change, committing, verbose, gerrit_obj, dry_run=None,
Dirk Pranke6f0df682021-06-25 00:42:33 +00001493 thread_pool=None, parallel=False, use_python3=False):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001494 """
1495 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001496 change: The Change object.
agable92bec4f2016-08-24 09:27:27 -07001497 committing: True if 'git cl land' is running, False if 'git cl upload' is.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001498 gerrit_obj: provides basic Gerrit codereview functionality.
1499 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -04001500 parallel: if true, all tests reported via input_api.RunTests for all
1501 PRESUBMIT files will be run in parallel.
Dirk Pranke6f0df682021-06-25 00:42:33 +00001502 use_python3: if true, will use python3 instead of python2 by default
1503 if USE_PYTHON3 is not specified.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001504 """
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001505 self.change = change
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001506 self.committing = committing
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001507 self.gerrit = gerrit_obj
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001508 self.verbose = verbose
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001509 self.dry_run = dry_run
Daniel Cheng7227d212017-11-17 08:12:37 -08001510 self.more_cc = []
Edward Lesmes8e282792018-04-03 18:50:29 -04001511 self.thread_pool = thread_pool
1512 self.parallel = parallel
Dirk Pranke6f0df682021-06-25 00:42:33 +00001513 self.use_python3 = use_python3
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001514
1515 def ExecPresubmitScript(self, script_text, presubmit_path):
1516 """Executes a single presubmit script.
1517
1518 Args:
1519 script_text: The text of the presubmit script.
1520 presubmit_path: The path to the presubmit file (this will be reported via
1521 input_api.PresubmitLocalPath()).
1522
1523 Return:
1524 A list of result objects, empty if no problems.
1525 """
Josip Sokcevice293d3d2022-02-16 22:52:15 +00001526 if not _ShouldRunPresubmit(script_text, self.use_python3):
1527 return []
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001528
chase@chromium.org8e416c82009-10-06 04:30:44 +00001529 # Change to the presubmit file's directory to support local imports.
1530 main_path = os.getcwd()
Saagar Sanghavi98b332f2020-07-31 17:19:15 +00001531 presubmit_dir = os.path.dirname(presubmit_path)
1532 os.chdir(presubmit_dir)
chase@chromium.org8e416c82009-10-06 04:30:44 +00001533
1534 # Load the presubmit script into context.
dpranke@chromium.org970c5222011-03-12 00:32:24 +00001535 input_api = InputApi(self.change, presubmit_path, self.committing,
Aaron Gable668c1d82018-04-03 10:19:16 -07001536 self.verbose, gerrit_obj=self.gerrit,
Edward Lesmes8e282792018-04-03 18:50:29 -04001537 dry_run=self.dry_run, thread_pool=self.thread_pool,
1538 parallel=self.parallel)
Daniel Cheng7227d212017-11-17 08:12:37 -08001539 output_api = OutputApi(self.committing)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001540 context = {}
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001541
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001542 try:
Raul Tambre09e64b42019-05-14 01:57:22 +00001543 exec(compile(script_text, 'PRESUBMIT.py', 'exec', dont_inherit=True),
1544 context)
Raul Tambre7c938462019-05-24 16:35:35 +00001545 except Exception as e:
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001546 raise PresubmitFailure('"%s" had an exception.\n%s' % (presubmit_path, e))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001547
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001548 context['__args'] = (input_api, output_api)
Ben Pastene8351dc12020-08-06 05:01:35 +00001549
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001550 # Get path of presubmit directory relative to repository root.
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001551 # Always use forward slashes, so that path is same in *nix and Windows
1552 root = input_api.change.RepositoryRoot()
1553 rel_path = os.path.relpath(presubmit_dir, root)
1554 rel_path = rel_path.replace(os.path.sep, '/')
Ben Pastene8351dc12020-08-06 05:01:35 +00001555
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001556 # Get the URL of git remote origin and use it to identify host and project
Edward Lesmeseb1bd622021-03-01 19:54:07 +00001557 host = project = ''
1558 if self.gerrit:
1559 host = self.gerrit.host or ''
1560 project = self.gerrit.project or ''
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001561
1562 # Prefix for test names
1563 prefix = 'presubmit:%s/%s:%s/' % (host, project, rel_path)
1564
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001565 # Perform all the desired presubmit checks.
1566 results = []
Ben Pastene8351dc12020-08-06 05:01:35 +00001567
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001568 try:
Scott Leecc2fe9b2020-11-19 19:38:06 +00001569 version = [
1570 int(x) for x in context.get('PRESUBMIT_VERSION', '0.0.0').split('.')
1571 ]
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001572
Scott Leecc2fe9b2020-11-19 19:38:06 +00001573 with rdb_wrapper.client(prefix) as sink:
1574 if version >= [2, 0, 0]:
Andrew Grievebdfb8f22022-02-02 21:56:47 +00001575 # Copy the keys to prevent "dictionary changed size during iteration"
1576 # exception if checks add globals to context. E.g. sometimes the
1577 # Python runtime will add __warningregistry__.
1578 for function_name in list(context.keys()):
Scott Leecc2fe9b2020-11-19 19:38:06 +00001579 if not function_name.startswith('Check'):
1580 continue
1581 if function_name.endswith('Commit') and not self.committing:
1582 continue
1583 if function_name.endswith('Upload') and self.committing:
1584 continue
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001585 logging.debug('Running %s in %s', function_name, presubmit_path)
1586 results.extend(
Bruce Dawson8fa42e22022-03-29 17:05:38 +00001587 self._run_check_function(function_name, context, sink,
1588 presubmit_path))
Scott Leecc2fe9b2020-11-19 19:38:06 +00001589 logging.debug('Running %s done.', function_name)
1590 self.more_cc.extend(output_api.more_cc)
1591
1592 else: # Old format
1593 if self.committing:
1594 function_name = 'CheckChangeOnCommit'
1595 else:
1596 function_name = 'CheckChangeOnUpload'
Andrew Grievebdfb8f22022-02-02 21:56:47 +00001597 if function_name in list(context.keys()):
Scott Leecc2fe9b2020-11-19 19:38:06 +00001598 logging.debug('Running %s in %s', function_name, presubmit_path)
1599 results.extend(
Bruce Dawson8fa42e22022-03-29 17:05:38 +00001600 self._run_check_function(function_name, context, sink,
1601 presubmit_path))
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001602 logging.debug('Running %s done.', function_name)
1603 self.more_cc.extend(output_api.more_cc)
1604
1605 finally:
1606 for f in input_api._named_temporary_files:
1607 os.remove(f)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001608
chase@chromium.org8e416c82009-10-06 04:30:44 +00001609 # Return the process to the original working directory.
1610 os.chdir(main_path)
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001611 return results
1612
Bruce Dawson8fa42e22022-03-29 17:05:38 +00001613 def _run_check_function(self, function_name, context, sink, presubmit_path):
Scott Leecc2fe9b2020-11-19 19:38:06 +00001614 """Evaluates and returns the result of a given presubmit function.
1615
1616 If sink is given, the result of the presubmit function will be reported
1617 to the ResultSink.
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001618
1619 Args:
Scott Leecc2fe9b2020-11-19 19:38:06 +00001620 function_name: the name of the presubmit function to evaluate
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001621 context: a context dictionary in which the function will be evaluated
Scott Leecc2fe9b2020-11-19 19:38:06 +00001622 sink: an instance of ResultSink. None, by default.
1623 Returns:
1624 the result of the presubmit function call.
1625 """
1626 start_time = time_time()
1627 try:
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001628 result = eval(function_name + '(*__args)', context)
1629 self._check_result_type(result)
Allen Webbfe7d7092021-05-18 02:05:49 +00001630 except Exception:
Scott Leecc2fe9b2020-11-19 19:38:06 +00001631 if sink:
1632 elapsed_time = time_time() - start_time
1633 sink.report(function_name, rdb_wrapper.STATUS_FAIL, elapsed_time)
Allen Webbfe7d7092021-05-18 02:05:49 +00001634 # TODO(crbug.com/953884): replace reraise with native py3:
Allen Webbb65bbfe2021-05-11 21:22:01 +00001635 # raise .. from e
Allen Webbfe7d7092021-05-18 02:05:49 +00001636 e_type, e_value, e_tb = sys.exc_info()
Dirk Pranke6fc394f2021-05-26 23:25:14 +00001637 print('Evaluation of %s failed: %s' % (function_name, e_value))
1638 six.reraise(e_type, e_value, e_tb)
Scott Leecc2fe9b2020-11-19 19:38:06 +00001639
Bruce Dawson2bdc49f2021-05-21 19:13:03 +00001640 elapsed_time = time_time() - start_time
1641 if elapsed_time > 10.0:
Bruce Dawson8fa42e22022-03-29 17:05:38 +00001642 sys.stdout.write('%s from %s took %.1fs to run.\n' %
1643 (function_name, presubmit_path, elapsed_time))
Scott Leecc2fe9b2020-11-19 19:38:06 +00001644 if sink:
Scott Leecc2fe9b2020-11-19 19:38:06 +00001645 status = rdb_wrapper.STATUS_PASS
1646 if any(r.fatal for r in result):
1647 status = rdb_wrapper.STATUS_FAIL
1648 sink.report(function_name, status, elapsed_time)
1649
1650 return result
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001651
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00001652 def _check_result_type(self, result):
1653 """Helper function which ensures result is a list, and all elements are
1654 instances of OutputApi.PresubmitResult"""
1655 if not isinstance(result, (tuple, list)):
1656 raise PresubmitFailure('Presubmit functions must return a tuple or list')
1657 if not all(isinstance(res, OutputApi.PresubmitResult) for res in result):
1658 raise PresubmitFailure(
1659 'All presubmit results must be of types derived from '
1660 'output_api.PresubmitResult')
1661
1662
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001663def DoPresubmitChecks(change,
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001664 committing,
1665 verbose,
maruel@chromium.orgb0dfd352009-06-10 14:12:54 +00001666 default_presubmit,
dpranke@chromium.org970c5222011-03-12 00:32:24 +00001667 may_prompt,
Aaron Gable668c1d82018-04-03 10:19:16 -07001668 gerrit_obj,
Edward Lesmes8e282792018-04-03 18:50:29 -04001669 dry_run=None,
Debrian Figueroadd2737e2019-06-21 23:50:13 +00001670 parallel=False,
Dirk Pranke6f0df682021-06-25 00:42:33 +00001671 json_output=None,
1672 use_python3=False):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001673 """Runs all presubmit checks that apply to the files in the change.
1674
1675 This finds all PRESUBMIT.py files in directories enclosing the files in the
1676 change (up to the repository root) and calls the relevant entrypoint function
1677 depending on whether the change is being committed or uploaded.
1678
1679 Prints errors, warnings and notifications. Prompts the user for warnings
1680 when needed.
1681
1682 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001683 change: The Change object.
agable92bec4f2016-08-24 09:27:27 -07001684 committing: True if 'git cl land' is running, False if 'git cl upload' is.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001685 verbose: Prints debug info.
maruel@chromium.org0ff1fab2009-05-22 13:08:15 +00001686 default_presubmit: A default presubmit script to execute in any case.
Quinten Yearsley516fe7f2016-12-14 11:50:18 -08001687 may_prompt: Enable (y/n) questions on warning or error. If False,
1688 any questions are answered with yes by default.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001689 gerrit_obj: provides basic Gerrit codereview functionality.
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001690 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -04001691 parallel: if true, all tests specified by input_api.RunTests in all
1692 PRESUBMIT files will be run in parallel.
Dirk Pranke6f0df682021-06-25 00:42:33 +00001693 use_python3: if true, default to using Python3 for presubmit checks
1694 rather than Python2.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001695 Return:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001696 1 if presubmit checks failed or 0 otherwise.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001697 """
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001698 old_environ = os.environ
1699 try:
1700 # Make sure python subprocesses won't generate .pyc files.
1701 os.environ = os.environ.copy()
Edward Lemurb9830242019-10-30 22:19:20 +00001702 os.environ['PYTHONDONTWRITEBYTECODE'] = '1'
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001703
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001704 python_version = 'Python %s' % sys.version_info.major
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001705 if committing:
Dirk Pranke6fc394f2021-05-26 23:25:14 +00001706 sys.stdout.write('Running %s presubmit commit checks ...\n' %
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001707 python_version)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001708 else:
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001709 sys.stdout.write('Running %s presubmit upload checks ...\n' %
1710 python_version)
Edward Lemurecc27072020-01-06 16:42:34 +00001711 start_time = time_time()
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001712 presubmit_files = ListRelevantPresubmitFiles(
agable0b65e732016-11-22 09:25:46 -08001713 change.AbsoluteLocalPaths(), change.RepositoryRoot())
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001714 if not presubmit_files and verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001715 sys.stdout.write('Warning, no PRESUBMIT.py found.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001716 results = []
Edward Lesmes8e282792018-04-03 18:50:29 -04001717 thread_pool = ThreadPool()
Edward Lemur7e3c67f2018-07-20 20:52:49 +00001718 executer = PresubmitExecuter(change, committing, verbose, gerrit_obj,
Dirk Pranke6f0df682021-06-25 00:42:33 +00001719 dry_run, thread_pool, parallel, use_python3)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001720 if default_presubmit:
1721 if verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001722 sys.stdout.write('Running default presubmit script.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001723 fake_path = os.path.join(change.RepositoryRoot(), 'PRESUBMIT.py')
1724 results += executer.ExecPresubmitScript(default_presubmit, fake_path)
1725 for filename in presubmit_files:
1726 filename = os.path.abspath(filename)
1727 if verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001728 sys.stdout.write('Running %s\n' % filename)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001729 # Accept CRLF presubmit script.
1730 presubmit_script = gclient_utils.FileRead(filename, 'rU')
1731 results += executer.ExecPresubmitScript(presubmit_script, filename)
Edward Lesmes8e282792018-04-03 18:50:29 -04001732 results += thread_pool.RunAsync()
1733
Edward Lemur6eb1d322020-02-27 22:20:15 +00001734 messages = {}
1735 should_prompt = False
1736 presubmits_failed = False
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001737 for result in results:
1738 if result.fatal:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001739 presubmits_failed = True
1740 messages.setdefault('ERRORS', []).append(result)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001741 elif result.should_prompt:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001742 should_prompt = True
1743 messages.setdefault('Warnings', []).append(result)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001744 else:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001745 messages.setdefault('Messages', []).append(result)
pam@chromium.orged9a0832009-09-09 22:48:55 +00001746
Edward Lemur6eb1d322020-02-27 22:20:15 +00001747 for name, items in messages.items():
1748 sys.stdout.write('** Presubmit %s **\n' % name)
1749 for item in items:
1750 item.handle()
1751 sys.stdout.write('\n')
pam@chromium.orged9a0832009-09-09 22:48:55 +00001752
Edward Lemurecc27072020-01-06 16:42:34 +00001753 total_time = time_time() - start_time
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001754 if total_time > 1.0:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001755 sys.stdout.write(
Louis Romero4ca9e1c2022-03-10 10:29:11 +00001756 'Presubmit checks took %.1fs to calculate.\n' % total_time)
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +00001757
Edward Lemur6eb1d322020-02-27 22:20:15 +00001758 if not should_prompt and not presubmits_failed:
Louis Romero4ca9e1c2022-03-10 10:29:11 +00001759 sys.stdout.write('%s presubmit checks passed.\n\n' % python_version)
Josip Sokcevic7592e0a2022-01-12 00:57:54 +00001760 elif should_prompt and not presubmits_failed:
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001761 sys.stdout.write('There were %s presubmit warnings. ' % python_version)
Quinten Yearsley516fe7f2016-12-14 11:50:18 -08001762 if may_prompt:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001763 presubmits_failed = not prompt_should_continue(
1764 'Are you sure you wish to continue? (y/N): ')
Garrett Beatyacb807e2020-08-28 18:17:24 +00001765 else:
1766 sys.stdout.write('\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001767
Edward Lemur1dc66e12020-02-21 21:36:34 +00001768 if json_output:
1769 # Write the presubmit results to json output
1770 presubmit_results = {
1771 'errors': [
Edward Lemur6eb1d322020-02-27 22:20:15 +00001772 error.json_format()
1773 for error in messages.get('ERRORS', [])
Edward Lemur1dc66e12020-02-21 21:36:34 +00001774 ],
1775 'notifications': [
Edward Lemur6eb1d322020-02-27 22:20:15 +00001776 notification.json_format()
1777 for notification in messages.get('Messages', [])
Edward Lemur1dc66e12020-02-21 21:36:34 +00001778 ],
1779 'warnings': [
Edward Lemur6eb1d322020-02-27 22:20:15 +00001780 warning.json_format()
1781 for warning in messages.get('Warnings', [])
Edward Lemur1dc66e12020-02-21 21:36:34 +00001782 ],
Edward Lemur6eb1d322020-02-27 22:20:15 +00001783 'more_cc': executer.more_cc,
Edward Lemur1dc66e12020-02-21 21:36:34 +00001784 }
1785
1786 gclient_utils.FileWrite(
1787 json_output, json.dumps(presubmit_results, sort_keys=True))
1788
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001789 global _ASKED_FOR_FEEDBACK
1790 # Ask for feedback one time out of 5.
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +00001791 if (results and random.randint(0, 4) == 0 and not _ASKED_FOR_FEEDBACK):
Edward Lemur6eb1d322020-02-27 22:20:15 +00001792 sys.stdout.write(
maruel@chromium.org1ce8e662014-01-14 15:23:00 +00001793 'Was the presubmit check useful? If not, run "git cl presubmit -v"\n'
1794 'to figure out which PRESUBMIT.py was run, then run git blame\n'
1795 'on the file to figure out who to ask for help.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001796 _ASKED_FOR_FEEDBACK = True
Edward Lemur6eb1d322020-02-27 22:20:15 +00001797
1798 return 1 if presubmits_failed else 0
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001799 finally:
1800 os.environ = old_environ
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001801
1802
Edward Lemur50984a62020-02-06 18:10:18 +00001803def _scan_sub_dirs(mask, recursive):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001804 if not recursive:
pgervais@chromium.orge57b09d2014-05-07 00:58:13 +00001805 return [x for x in glob.glob(mask) if x not in ('.svn', '.git')]
Lei Zhang9611c4c2017-04-04 01:41:56 -07001806
1807 results = []
1808 for root, dirs, files in os.walk('.'):
1809 if '.svn' in dirs:
1810 dirs.remove('.svn')
1811 if '.git' in dirs:
1812 dirs.remove('.git')
1813 for name in files:
1814 if fnmatch.fnmatch(name, mask):
1815 results.append(os.path.join(root, name))
1816 return results
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001817
1818
Edward Lemur50984a62020-02-06 18:10:18 +00001819def _parse_files(args, recursive):
tobiasjs2836bcf2016-08-16 04:08:16 -07001820 logging.debug('Searching for %s', args)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001821 files = []
1822 for arg in args:
Edward Lemur50984a62020-02-06 18:10:18 +00001823 files.extend([('M', f) for f in _scan_sub_dirs(arg, recursive)])
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001824 return files
1825
1826
Edward Lemur50984a62020-02-06 18:10:18 +00001827def _parse_change(parser, options):
1828 """Process change options.
1829
1830 Args:
1831 parser: The parser used to parse the arguments from command line.
1832 options: The arguments parsed from command line.
1833 Returns:
1834 A GitChange if the change root is a git repository, or a Change otherwise.
1835 """
1836 if options.files and options.all_files:
1837 parser.error('<files> cannot be specified when --all-files is set.')
1838
Edward Lesmes44ea3ff2020-02-05 00:14:30 +00001839 change_scm = scm.determine_scm(options.root)
Edward Lemur50984a62020-02-06 18:10:18 +00001840 if change_scm != 'git' and not options.files:
1841 parser.error('<files> is not optional for unversioned directories.')
1842
1843 if options.files:
Josip Sokcevic017544d2022-03-31 23:47:53 +00001844 if options.source_controlled_only:
1845 # Get the filtered set of files from SCM.
1846 change_files = []
1847 for name in scm.GIT.GetAllFiles(options.root):
1848 for mask in options.files:
1849 if fnmatch.fnmatch(name, mask):
1850 change_files.append(('M', name))
1851 break
1852 else:
1853 # Get the filtered set of files from a directory scan.
1854 change_files = _parse_files(options.files, options.recursive)
Edward Lemur50984a62020-02-06 18:10:18 +00001855 elif options.all_files:
1856 change_files = [('M', f) for f in scm.GIT.GetAllFiles(options.root)]
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001857 else:
Edward Lemur50984a62020-02-06 18:10:18 +00001858 change_files = scm.GIT.CaptureStatus(
Edward Lemur7f6dec02020-02-06 20:23:58 +00001859 options.root, options.upstream or None)
Edward Lemur50984a62020-02-06 18:10:18 +00001860
1861 logging.info('Found %d file(s).', len(change_files))
1862
1863 change_class = GitChange if change_scm == 'git' else Change
1864 return change_class(
1865 options.name,
1866 options.description,
1867 options.root,
1868 change_files,
1869 options.issue,
1870 options.patchset,
1871 options.author,
1872 upstream=options.upstream)
1873
1874
1875def _parse_gerrit_options(parser, options):
1876 """Process gerrit options.
1877
1878 SIDE EFFECTS: Modifies options.author and options.description from Gerrit if
1879 options.gerrit_fetch is set.
1880
1881 Args:
1882 parser: The parser used to parse the arguments from command line.
1883 options: The arguments parsed from command line.
1884 Returns:
Stephen Martinisfb09de22021-02-25 03:41:13 +00001885 A GerritAccessor object if options.gerrit_url is set, or None otherwise.
Edward Lemur50984a62020-02-06 18:10:18 +00001886 """
1887 gerrit_obj = None
Stephen Martinisfb09de22021-02-25 03:41:13 +00001888 if options.gerrit_url:
Edward Lesmeseb1bd622021-03-01 19:54:07 +00001889 gerrit_obj = GerritAccessor(
1890 url=options.gerrit_url,
1891 project=options.gerrit_project,
1892 branch=options.gerrit_branch)
Edward Lemur50984a62020-02-06 18:10:18 +00001893
1894 if not options.gerrit_fetch:
1895 return gerrit_obj
1896
1897 if not options.gerrit_url or not options.issue or not options.patchset:
1898 parser.error(
1899 '--gerrit_fetch requires --gerrit_url, --issue and --patchset.')
1900
1901 options.author = gerrit_obj.GetChangeOwner(options.issue)
1902 options.description = gerrit_obj.GetChangeDescription(
1903 options.issue, options.patchset)
1904
1905 logging.info('Got author: "%s"', options.author)
1906 logging.info('Got description: """\n%s\n"""', options.description)
1907
1908 return gerrit_obj
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001909
1910
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001911@contextlib.contextmanager
1912def canned_check_filter(method_names):
1913 filtered = {}
1914 try:
1915 for method_name in method_names:
1916 if not hasattr(presubmit_canned_checks, method_name):
Gavin Make6a62332020-12-04 21:57:10 +00001917 logging.warning('Skipping unknown "canned" check %s' % method_name)
Aaron Gableecee74c2018-04-02 15:13:08 -07001918 continue
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001919 filtered[method_name] = getattr(presubmit_canned_checks, method_name)
1920 setattr(presubmit_canned_checks, method_name, lambda *_a, **_kw: [])
1921 yield
1922 finally:
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001923 for name, method in filtered.items():
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001924 setattr(presubmit_canned_checks, name, method)
1925
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +00001926
sbc@chromium.org013731e2015-02-26 18:28:43 +00001927def main(argv=None):
Edward Lemura5799e32020-01-17 19:26:51 +00001928 parser = argparse.ArgumentParser(usage='%(prog)s [options] <files...>')
1929 hooks = parser.add_mutually_exclusive_group()
1930 hooks.add_argument('-c', '--commit', action='store_true',
1931 help='Use commit instead of upload checks.')
1932 hooks.add_argument('-u', '--upload', action='store_false', dest='commit',
1933 help='Use upload instead of commit checks.')
Edward Lemur75526302020-02-27 22:31:05 +00001934 hooks.add_argument('--post_upload', action='store_true',
1935 help='Run post-upload commit hooks.')
Edward Lemura5799e32020-01-17 19:26:51 +00001936 parser.add_argument('-r', '--recursive', action='store_true',
1937 help='Act recursively.')
1938 parser.add_argument('-v', '--verbose', action='count', default=0,
1939 help='Use 2 times for more debug info.')
1940 parser.add_argument('--name', default='no name')
1941 parser.add_argument('--author')
Edward Lemur227d5102020-02-25 23:45:35 +00001942 desc = parser.add_mutually_exclusive_group()
1943 desc.add_argument('--description', default='', help='The change description.')
1944 desc.add_argument('--description_file',
1945 help='File to read change description from.')
Edward Lemura5799e32020-01-17 19:26:51 +00001946 parser.add_argument('--issue', type=int, default=0)
1947 parser.add_argument('--patchset', type=int, default=0)
1948 parser.add_argument('--root', default=os.getcwd(),
1949 help='Search for PRESUBMIT.py up to this directory. '
1950 'If inherit-review-settings-ok is present in this '
1951 'directory, parent directories up to the root file '
1952 'system directories will also be searched.')
1953 parser.add_argument('--upstream',
1954 help='Git only: the base ref or upstream branch against '
1955 'which the diff should be computed.')
1956 parser.add_argument('--default_presubmit')
1957 parser.add_argument('--may_prompt', action='store_true', default=False)
1958 parser.add_argument('--skip_canned', action='append', default=[],
1959 help='A list of checks to skip which appear in '
1960 'presubmit_canned_checks. Can be provided multiple times '
1961 'to skip multiple canned checks.')
1962 parser.add_argument('--dry_run', action='store_true', help=argparse.SUPPRESS)
1963 parser.add_argument('--gerrit_url', help=argparse.SUPPRESS)
Edward Lesmeseb1bd622021-03-01 19:54:07 +00001964 parser.add_argument('--gerrit_project', help=argparse.SUPPRESS)
1965 parser.add_argument('--gerrit_branch', help=argparse.SUPPRESS)
Edward Lemura5799e32020-01-17 19:26:51 +00001966 parser.add_argument('--gerrit_fetch', action='store_true',
1967 help=argparse.SUPPRESS)
1968 parser.add_argument('--parallel', action='store_true',
1969 help='Run all tests specified by input_api.RunTests in '
1970 'all PRESUBMIT files in parallel.')
1971 parser.add_argument('--json_output',
1972 help='Write presubmit errors to json output.')
Edward Lemur1dc66e12020-02-21 21:36:34 +00001973 parser.add_argument('--all_files', action='store_true',
Edward Lemur50984a62020-02-06 18:10:18 +00001974 help='Mark all files under source control as modified.')
Edward Lemura5799e32020-01-17 19:26:51 +00001975 parser.add_argument('files', nargs='*',
1976 help='List of files to be marked as modified when '
1977 'executing presubmit or post-upload hooks. fnmatch '
1978 'wildcards can also be used.')
Josip Sokcevic017544d2022-03-31 23:47:53 +00001979 parser.add_argument('--source_controlled_only', action='store_true',
1980 help='Constrain \'files\' to those in source control.')
Dirk Pranke6f0df682021-06-25 00:42:33 +00001981 parser.add_argument('--use-python3', action='store_true',
1982 help='Use python3 for presubmit checks by default')
Edward Lemura5799e32020-01-17 19:26:51 +00001983 options = parser.parse_args(argv)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001984
Erik Staabcca5c492020-04-16 17:40:07 +00001985 log_level = logging.ERROR
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001986 if options.verbose >= 2:
Erik Staabcca5c492020-04-16 17:40:07 +00001987 log_level = logging.DEBUG
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001988 elif options.verbose:
Erik Staabcca5c492020-04-16 17:40:07 +00001989 log_level = logging.INFO
1990 log_format = ('[%(levelname).1s%(asctime)s %(process)d %(thread)d '
1991 '%(filename)s] %(message)s')
1992 logging.basicConfig(format=log_format, level=log_level)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001993
Edward Lemur227d5102020-02-25 23:45:35 +00001994 if options.description_file:
1995 options.description = gclient_utils.FileRead(options.description_file)
Edward Lemur50984a62020-02-06 18:10:18 +00001996 gerrit_obj = _parse_gerrit_options(parser, options)
1997 change = _parse_change(parser, options)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001998
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001999 try:
Edward Lemur75526302020-02-27 22:31:05 +00002000 if options.post_upload:
Josip Sokcevice293d3d2022-02-16 22:52:15 +00002001 return DoPostUploadExecuter(change, gerrit_obj, options.verbose,
2002 options.use_python3)
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00002003 with canned_check_filter(options.skip_canned):
Edward Lemur6eb1d322020-02-27 22:20:15 +00002004 return DoPresubmitChecks(
Edward Lemur50984a62020-02-06 18:10:18 +00002005 change,
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00002006 options.commit,
2007 options.verbose,
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00002008 options.default_presubmit,
2009 options.may_prompt,
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00002010 gerrit_obj,
Edward Lesmes8e282792018-04-03 18:50:29 -04002011 options.dry_run,
Debrian Figueroadd2737e2019-06-21 23:50:13 +00002012 options.parallel,
Dirk Pranke6f0df682021-06-25 00:42:33 +00002013 options.json_output,
2014 options.use_python3)
Raul Tambre7c938462019-05-24 16:35:35 +00002015 except PresubmitFailure as e:
Josip Sokcevic0399e172022-03-21 23:11:51 +00002016 import utils
Raul Tambre80ee78e2019-05-06 22:41:05 +00002017 print(e, file=sys.stderr)
2018 print('Maybe your depot_tools is out of date?', file=sys.stderr)
Josip Sokcevic0399e172022-03-21 23:11:51 +00002019 print('depot_tools version: %s' % utils.depot_tools_version(),
2020 file=sys.stderr)
maruel@chromium.org899e1c12011-04-07 17:03:18 +00002021 return 2
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00002022
2023
2024if __name__ == '__main__':
maruel@chromium.org35625c72011-03-23 17:34:02 +00002025 fix_encoding.fix_encoding()
sbc@chromium.org013731e2015-02-26 18:28:43 +00002026 try:
2027 sys.exit(main())
2028 except KeyboardInterrupt:
2029 sys.stderr.write('interrupted\n')
sergiybf8a3b382016-07-05 11:21:30 -07002030 sys.exit(2)