blob: e149dd2447b289e61d156bcbf8923862808e51f9 [file] [log] [blame]
maruel@chromium.org725f1c32011-04-01 20:24:54 +00001#!/usr/bin/env python
maruel@chromium.org3bbf2942012-01-10 16:52:06 +00002# Copyright (c) 2012 The Chromium Authors. All rights reserved.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00003# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5
6"""Enables directory-specific presubmit checks to run at upload and/or commit.
7"""
8
Raul Tambre80ee78e2019-05-06 22:41:05 +00009from __future__ import print_function
10
Saagar Sanghavi99816902020-08-11 22:41:25 +000011__version__ = '2.0.0'
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000012
13# TODO(joi) Add caching where appropriate/needed. The API is designed to allow
14# caching (between all different invocations of presubmit scripts for a given
15# change). We should add it as our presubmit scripts start feeling slow.
16
Edward Lemura5799e32020-01-17 19:26:51 +000017import argparse
Takeshi Yoshino07a6bea2017-08-02 02:44:06 +090018import ast # Exposed through the API.
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +000019import contextlib
Yoshisato Yanagisawa406de132018-06-29 05:43:25 +000020import cpplint
dcheng091b7db2016-06-16 01:27:51 -070021import fnmatch # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000022import glob
asvitkine@chromium.org15169952011-09-27 14:30:53 +000023import inspect
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +000024import itertools
maruel@chromium.org4f6852c2012-04-20 20:39:20 +000025import json # Exposed through the API.
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +000026import logging
ilevy@chromium.orgbc117312013-04-20 03:57:56 +000027import multiprocessing
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000028import os # Somewhat exposed through the API.
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +000029import random
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000030import re # Exposed through the API.
Edward Lesmes8e282792018-04-03 18:50:29 -040031import signal
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000032import sys # Parts exposed through API.
33import tempfile # Exposed through the API.
Edward Lesmes8e282792018-04-03 18:50:29 -040034import threading
jam@chromium.org2a891dc2009-08-20 20:33:37 +000035import time
Edward Lemurde9e3ca2019-10-24 21:13:31 +000036import traceback
maruel@chromium.org1487d532009-06-06 00:22:57 +000037import unittest # Exposed through the API.
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +000038from warnings import warn
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000039
40# Local imports.
maruel@chromium.org35625c72011-03-23 17:34:02 +000041import fix_encoding
Yoshisato Yanagisawa04600b42019-03-15 03:03:41 +000042import gclient_paths # Exposed through the API
43import gclient_utils
Aaron Gableb584c4f2017-04-26 16:28:08 -070044import git_footers
tandrii@chromium.org015ebae2016-04-25 19:37:22 +000045import gerrit_util
Edward Lesmes9ce03f82021-01-12 20:13:31 +000046import owners as owners_db
47import owners_client
Jochen Eisinger76f5fc62017-04-07 16:27:46 +020048import owners_finder
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000049import presubmit_canned_checks
Saagar Sanghavi9949ab72020-07-20 20:56:40 +000050import rdb_wrapper
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +000051import scm
maruel@chromium.org84f4fe32011-04-06 13:26:45 +000052import subprocess2 as subprocess # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000053
Edward Lemur16af3562019-10-17 22:11:33 +000054if sys.version_info.major == 2:
55 # TODO(1009814): Expose urllib2 only through urllib_request and urllib_error
56 import urllib2 # Exposed through the API.
57 import urlparse
58 import urllib2 as urllib_request
59 import urllib2 as urllib_error
60else:
61 import urllib.parse as urlparse
62 import urllib.request as urllib_request
63 import urllib.error as urllib_error
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000064
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +000065# Ask for feedback only once in program lifetime.
66_ASKED_FOR_FEEDBACK = False
67
Edward Lemurecc27072020-01-06 16:42:34 +000068def time_time():
69 # Use this so that it can be mocked in tests without interfering with python
70 # system machinery.
71 return time.time()
72
73
maruel@chromium.org899e1c12011-04-07 17:03:18 +000074class PresubmitFailure(Exception):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000075 pass
76
77
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000078class CommandData(object):
Edward Lemur940c2822019-08-23 00:34:25 +000079 def __init__(self, name, cmd, kwargs, message, python3=False):
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000080 self.name = name
81 self.cmd = cmd
Edward Lesmes8e282792018-04-03 18:50:29 -040082 self.stdin = kwargs.get('stdin', None)
Edward Lemur2d6b67c2019-08-23 22:25:41 +000083 self.kwargs = kwargs.copy()
Edward Lesmes8e282792018-04-03 18:50:29 -040084 self.kwargs['stdout'] = subprocess.PIPE
85 self.kwargs['stderr'] = subprocess.STDOUT
86 self.kwargs['stdin'] = subprocess.PIPE
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000087 self.message = message
88 self.info = None
Edward Lemur940c2822019-08-23 00:34:25 +000089 self.python3 = python3
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000090
ilevy@chromium.orgbc117312013-04-20 03:57:56 +000091
Edward Lesmes8e282792018-04-03 18:50:29 -040092# Adapted from
93# https://github.com/google/gtest-parallel/blob/master/gtest_parallel.py#L37
94#
95# An object that catches SIGINT sent to the Python process and notices
96# if processes passed to wait() die by SIGINT (we need to look for
97# both of those cases, because pressing Ctrl+C can result in either
98# the main process or one of the subprocesses getting the signal).
99#
100# Before a SIGINT is seen, wait(p) will simply call p.wait() and
101# return the result. Once a SIGINT has been seen (in the main process
102# or a subprocess, including the one the current call is waiting for),
Edward Lemur9a5bb612019-09-26 02:01:52 +0000103# wait(p) will call p.terminate().
Edward Lesmes8e282792018-04-03 18:50:29 -0400104class SigintHandler(object):
Edward Lesmes8e282792018-04-03 18:50:29 -0400105 sigint_returncodes = {-signal.SIGINT, # Unix
106 -1073741510, # Windows
107 }
108 def __init__(self):
109 self.__lock = threading.Lock()
110 self.__processes = set()
111 self.__got_sigint = False
Edward Lemur9a5bb612019-09-26 02:01:52 +0000112 self.__previous_signal = signal.signal(signal.SIGINT, self.interrupt)
Edward Lesmes8e282792018-04-03 18:50:29 -0400113
114 def __on_sigint(self):
115 self.__got_sigint = True
116 while self.__processes:
117 try:
118 self.__processes.pop().terminate()
119 except OSError:
120 pass
121
Edward Lemur9a5bb612019-09-26 02:01:52 +0000122 def interrupt(self, signal_num, frame):
Edward Lesmes8e282792018-04-03 18:50:29 -0400123 with self.__lock:
124 self.__on_sigint()
Edward Lemur9a5bb612019-09-26 02:01:52 +0000125 self.__previous_signal(signal_num, frame)
Edward Lesmes8e282792018-04-03 18:50:29 -0400126
127 def got_sigint(self):
128 with self.__lock:
129 return self.__got_sigint
130
131 def wait(self, p, stdin):
132 with self.__lock:
133 if self.__got_sigint:
134 p.terminate()
135 self.__processes.add(p)
136 stdout, stderr = p.communicate(stdin)
137 code = p.returncode
138 with self.__lock:
139 self.__processes.discard(p)
140 if code in self.sigint_returncodes:
141 self.__on_sigint()
Edward Lesmes8e282792018-04-03 18:50:29 -0400142 return stdout, stderr
143
144sigint_handler = SigintHandler()
145
146
Edward Lemurecc27072020-01-06 16:42:34 +0000147class Timer(object):
148 def __init__(self, timeout, fn):
149 self.completed = False
150 self._fn = fn
151 self._timer = threading.Timer(timeout, self._onTimer) if timeout else None
152
153 def __enter__(self):
154 if self._timer:
155 self._timer.start()
156 return self
157
158 def __exit__(self, _type, _value, _traceback):
159 if self._timer:
160 self._timer.cancel()
161
162 def _onTimer(self):
163 self._fn()
164 self.completed = True
165
166
Edward Lesmes8e282792018-04-03 18:50:29 -0400167class ThreadPool(object):
Edward Lemurecc27072020-01-06 16:42:34 +0000168 def __init__(self, pool_size=None, timeout=None):
169 self.timeout = timeout
Edward Lesmes8e282792018-04-03 18:50:29 -0400170 self._pool_size = pool_size or multiprocessing.cpu_count()
171 self._messages = []
172 self._messages_lock = threading.Lock()
173 self._tests = []
174 self._tests_lock = threading.Lock()
175 self._nonparallel_tests = []
176
Edward Lemurecc27072020-01-06 16:42:34 +0000177 def _GetCommand(self, test):
Edward Lemur940c2822019-08-23 00:34:25 +0000178 vpython = 'vpython'
179 if test.python3:
180 vpython += '3'
181 if sys.platform == 'win32':
182 vpython += '.bat'
Edward Lesmes8e282792018-04-03 18:50:29 -0400183
184 cmd = test.cmd
185 if cmd[0] == 'python':
186 cmd = list(cmd)
187 cmd[0] = vpython
188 elif cmd[0].endswith('.py'):
189 cmd = [vpython] + cmd
190
Edward Lemur336e51f2019-11-14 21:42:04 +0000191 # On Windows, scripts on the current directory take precedence over PATH, so
192 # that when testing depot_tools on Windows, calling `vpython.bat` will
193 # execute the copy of vpython of the depot_tools under test instead of the
194 # one in the bot.
195 # As a workaround, we run the tests from the parent directory instead.
196 if (cmd[0] == vpython and
197 'cwd' in test.kwargs and
198 os.path.basename(test.kwargs['cwd']) == 'depot_tools'):
199 test.kwargs['cwd'] = os.path.dirname(test.kwargs['cwd'])
200 cmd[1] = os.path.join('depot_tools', cmd[1])
201
Edward Lemurecc27072020-01-06 16:42:34 +0000202 return cmd
203
204 def _RunWithTimeout(self, cmd, stdin, kwargs):
205 p = subprocess.Popen(cmd, **kwargs)
206 with Timer(self.timeout, p.terminate) as timer:
207 stdout, _ = sigint_handler.wait(p, stdin)
208 if timer.completed:
209 stdout = 'Process timed out after %ss\n%s' % (self.timeout, stdout)
210 return p.returncode, stdout
211
212 def CallCommand(self, test):
213 """Runs an external program.
214
Edward Lemura5799e32020-01-17 19:26:51 +0000215 This function converts invocation of .py files and invocations of 'python'
Edward Lemurecc27072020-01-06 16:42:34 +0000216 to vpython invocations.
217 """
218 cmd = self._GetCommand(test)
Edward Lesmes8e282792018-04-03 18:50:29 -0400219 try:
Edward Lemurecc27072020-01-06 16:42:34 +0000220 start = time_time()
221 returncode, stdout = self._RunWithTimeout(cmd, test.stdin, test.kwargs)
222 duration = time_time() - start
Edward Lemur7cf94382019-11-15 22:36:41 +0000223 except Exception:
Edward Lemurecc27072020-01-06 16:42:34 +0000224 duration = time_time() - start
Edward Lesmes8e282792018-04-03 18:50:29 -0400225 return test.message(
Edward Lemur7cf94382019-11-15 22:36:41 +0000226 '%s\n%s exec failure (%4.2fs)\n%s' % (
227 test.name, ' '.join(cmd), duration, traceback.format_exc()))
Edward Lemurde9e3ca2019-10-24 21:13:31 +0000228
Edward Lemurecc27072020-01-06 16:42:34 +0000229 if returncode != 0:
Edward Lesmes8e282792018-04-03 18:50:29 -0400230 return test.message(
Edward Lemur7cf94382019-11-15 22:36:41 +0000231 '%s\n%s (%4.2fs) failed\n%s' % (
232 test.name, ' '.join(cmd), duration, stdout))
Edward Lemurecc27072020-01-06 16:42:34 +0000233
Edward Lesmes8e282792018-04-03 18:50:29 -0400234 if test.info:
Edward Lemur7cf94382019-11-15 22:36:41 +0000235 return test.info('%s\n%s (%4.2fs)' % (test.name, ' '.join(cmd), duration))
Edward Lesmes8e282792018-04-03 18:50:29 -0400236
237 def AddTests(self, tests, parallel=True):
238 if parallel:
239 self._tests.extend(tests)
240 else:
241 self._nonparallel_tests.extend(tests)
242
243 def RunAsync(self):
244 self._messages = []
245
246 def _WorkerFn():
247 while True:
248 test = None
249 with self._tests_lock:
250 if not self._tests:
251 break
252 test = self._tests.pop()
253 result = self.CallCommand(test)
254 if result:
255 with self._messages_lock:
256 self._messages.append(result)
257
258 def _StartDaemon():
259 t = threading.Thread(target=_WorkerFn)
260 t.daemon = True
261 t.start()
262 return t
263
264 while self._nonparallel_tests:
265 test = self._nonparallel_tests.pop()
266 result = self.CallCommand(test)
267 if result:
268 self._messages.append(result)
269
270 if self._tests:
271 threads = [_StartDaemon() for _ in range(self._pool_size)]
272 for worker in threads:
273 worker.join()
274
275 return self._messages
276
277
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000278def normpath(path):
279 '''Version of os.path.normpath that also changes backward slashes to
280 forward slashes when not running on Windows.
281 '''
282 # This is safe to always do because the Windows version of os.path.normpath
283 # will replace forward slashes with backward slashes.
284 path = path.replace(os.sep, '/')
285 return os.path.normpath(path)
286
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000287
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000288def _RightHandSideLinesImpl(affected_files):
289 """Implements RightHandSideLines for InputApi and GclChange."""
290 for af in affected_files:
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000291 lines = af.ChangedContents()
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000292 for line in lines:
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000293 yield (af, line[0], line[1])
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000294
295
Edward Lemur6eb1d322020-02-27 22:20:15 +0000296def prompt_should_continue(prompt_string):
297 sys.stdout.write(prompt_string)
298 response = sys.stdin.readline().strip().lower()
299 return response in ('y', 'yes')
dpranke@chromium.org5ac21012011-03-16 02:58:25 +0000300
301
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000302# Top level object so multiprocessing can pickle
303# Public access through OutputApi object.
304class _PresubmitResult(object):
305 """Base class for result objects."""
306 fatal = False
307 should_prompt = False
308
309 def __init__(self, message, items=None, long_text=''):
310 """
311 message: A short one-line message to indicate errors.
312 items: A list of short strings to indicate where errors occurred.
313 long_text: multi-line text output, e.g. from another tool
314 """
315 self._message = message
316 self._items = items or []
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000317 self._long_text = long_text.rstrip()
318
Edward Lemur6eb1d322020-02-27 22:20:15 +0000319 def handle(self):
320 sys.stdout.write(self._message)
321 sys.stdout.write('\n')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000322 for index, item in enumerate(self._items):
Edward Lemur6eb1d322020-02-27 22:20:15 +0000323 sys.stdout.write(' ')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000324 # Write separately in case it's unicode.
Edward Lemur6eb1d322020-02-27 22:20:15 +0000325 sys.stdout.write(str(item))
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000326 if index < len(self._items) - 1:
Edward Lemur6eb1d322020-02-27 22:20:15 +0000327 sys.stdout.write(' \\')
328 sys.stdout.write('\n')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000329 if self._long_text:
Edward Lemur6eb1d322020-02-27 22:20:15 +0000330 sys.stdout.write('\n***************\n')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000331 # Write separately in case it's unicode.
Edward Lemur6eb1d322020-02-27 22:20:15 +0000332 sys.stdout.write(self._long_text)
333 sys.stdout.write('\n***************\n')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000334
Debrian Figueroadd2737e2019-06-21 23:50:13 +0000335 def json_format(self):
336 return {
337 'message': self._message,
Debrian Figueroa6095d402019-06-28 18:47:18 +0000338 'items': [str(item) for item in self._items],
Debrian Figueroadd2737e2019-06-21 23:50:13 +0000339 'long_text': self._long_text,
340 'fatal': self.fatal
341 }
342
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000343
344# Top level object so multiprocessing can pickle
345# Public access through OutputApi object.
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000346class _PresubmitError(_PresubmitResult):
347 """A hard presubmit error."""
348 fatal = True
349
350
351# Top level object so multiprocessing can pickle
352# Public access through OutputApi object.
353class _PresubmitPromptWarning(_PresubmitResult):
354 """An warning that prompts the user if they want to continue."""
355 should_prompt = True
356
357
358# Top level object so multiprocessing can pickle
359# Public access through OutputApi object.
360class _PresubmitNotifyResult(_PresubmitResult):
361 """Just print something to the screen -- but it's not even a warning."""
362 pass
363
364
365# Top level object so multiprocessing can pickle
366# Public access through OutputApi object.
367class _MailTextResult(_PresubmitResult):
368 """A warning that should be included in the review request email."""
369 def __init__(self, *args, **kwargs):
370 super(_MailTextResult, self).__init__()
371 raise NotImplementedError()
372
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000373class GerritAccessor(object):
374 """Limited Gerrit functionality for canned presubmit checks to work.
375
376 To avoid excessive Gerrit calls, caches the results.
377 """
378
Edward Lesmeseb1bd622021-03-01 19:54:07 +0000379 def __init__(self, url=None, project=None, branch=None):
380 self.host = urlparse.urlparse(url).netloc if url else None
381 self.project = project
382 self.branch = branch
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000383 self.cache = {}
Edward Lesmes8170c292021-03-19 20:04:43 +0000384 self.code_owners_enabled = None
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000385
386 def _FetchChangeDetail(self, issue):
387 # Separate function to be easily mocked in tests.
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +0100388 try:
389 return gerrit_util.GetChangeDetail(
390 self.host, str(issue),
Aaron Gable6f5a8d92017-04-18 14:49:05 -0700391 ['ALL_REVISIONS', 'DETAILED_LABELS', 'ALL_COMMITS'])
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +0100392 except gerrit_util.GerritError as e:
393 if e.http_status == 404:
394 raise Exception('Either Gerrit issue %s doesn\'t exist, or '
395 'no credentials to fetch issue details' % issue)
396 raise
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000397
398 def GetChangeInfo(self, issue):
399 """Returns labels and all revisions (patchsets) for this issue.
400
401 The result is a dictionary according to Gerrit REST Api.
402 https://gerrit-review.googlesource.com/Documentation/rest-api.html
403
404 However, API isn't very clear what's inside, so see tests for example.
405 """
406 assert issue
407 cache_key = int(issue)
408 if cache_key not in self.cache:
409 self.cache[cache_key] = self._FetchChangeDetail(issue)
410 return self.cache[cache_key]
411
412 def GetChangeDescription(self, issue, patchset=None):
413 """If patchset is none, fetches current patchset."""
414 info = self.GetChangeInfo(issue)
415 # info is a reference to cache. We'll modify it here adding description to
416 # it to the right patchset, if it is not yet there.
417
418 # Find revision info for the patchset we want.
419 if patchset is not None:
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +0000420 for rev, rev_info in info['revisions'].items():
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000421 if str(rev_info['_number']) == str(patchset):
422 break
423 else:
424 raise Exception('patchset %s doesn\'t exist in issue %s' % (
425 patchset, issue))
426 else:
427 rev = info['current_revision']
428 rev_info = info['revisions'][rev]
429
Andrii Shyshkalov9c3a4642017-01-24 17:41:22 +0100430 return rev_info['commit']['message']
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000431
Mun Yong Jang603d01e2017-12-19 16:38:30 -0800432 def GetDestRef(self, issue):
433 ref = self.GetChangeInfo(issue)['branch']
434 if not ref.startswith('refs/'):
435 # NOTE: it is possible to create 'refs/x' branch,
436 # aka 'refs/heads/refs/x'. However, this is ill-advised.
437 ref = 'refs/heads/%s' % ref
438 return ref
439
Edward Lesmes02d4b822020-11-11 00:37:35 +0000440 def _GetApproversForLabel(self, issue, label):
441 change_info = self.GetChangeInfo(issue)
442 label_info = change_info.get('labels', {}).get(label, {})
443 values = label_info.get('values', {}).keys()
444 if not values:
445 return []
446 max_value = max(int(v) for v in values)
447 return [v for v in label_info.get('all', [])
448 if v.get('value', 0) == max_value]
449
Edward Lesmesc4566172021-03-19 16:55:13 +0000450 def IsBotCommitApproved(self, issue):
451 return bool(self._GetApproversForLabel(issue, 'Bot-Commit'))
452
Edward Lesmescf49cb82020-11-11 01:08:36 +0000453 def IsOwnersOverrideApproved(self, issue):
454 return bool(self._GetApproversForLabel(issue, 'Owners-Override'))
455
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000456 def GetChangeOwner(self, issue):
457 return self.GetChangeInfo(issue)['owner']['email']
458
459 def GetChangeReviewers(self, issue, approving_only=True):
Aaron Gable8b478f02017-07-31 15:33:19 -0700460 changeinfo = self.GetChangeInfo(issue)
461 if approving_only:
Edward Lesmes02d4b822020-11-11 00:37:35 +0000462 reviewers = self._GetApproversForLabel(issue, 'Code-Review')
Aaron Gable8b478f02017-07-31 15:33:19 -0700463 else:
464 reviewers = changeinfo.get('reviewers', {}).get('REVIEWER', [])
465 return [r.get('email') for r in reviewers]
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000466
Edward Lemure4d329c2020-02-03 20:41:18 +0000467 def UpdateDescription(self, description, issue):
468 gerrit_util.SetCommitMessage(self.host, issue, description, notify='NONE')
469
Edward Lesmes8170c292021-03-19 20:04:43 +0000470 def IsCodeOwnersEnabledOnRepo(self):
471 if self.code_owners_enabled is None:
472 self.code_owners_enabled = gerrit_util.IsCodeOwnersEnabledOnRepo(
Edward Lesmes392c4072021-03-19 21:58:45 +0000473 self.host, self.project)
Edward Lesmes8170c292021-03-19 20:04:43 +0000474 return self.code_owners_enabled
475
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000476
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000477class OutputApi(object):
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000478 """An instance of OutputApi gets passed to presubmit scripts so that they
479 can output various types of results.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000480 """
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000481 PresubmitResult = _PresubmitResult
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000482 PresubmitError = _PresubmitError
483 PresubmitPromptWarning = _PresubmitPromptWarning
484 PresubmitNotifyResult = _PresubmitNotifyResult
485 MailTextResult = _MailTextResult
486
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000487 def __init__(self, is_committing):
488 self.is_committing = is_committing
Daniel Cheng7227d212017-11-17 08:12:37 -0800489 self.more_cc = []
490
491 def AppendCC(self, cc):
492 """Appends a user to cc for this change."""
493 self.more_cc.append(cc)
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000494
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000495 def PresubmitPromptOrNotify(self, *args, **kwargs):
496 """Warn the user when uploading, but only notify if committing."""
497 if self.is_committing:
498 return self.PresubmitNotifyResult(*args, **kwargs)
499 return self.PresubmitPromptWarning(*args, **kwargs)
500
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000501
502class InputApi(object):
503 """An instance of this object is passed to presubmit scripts so they can
504 know stuff about the change they're looking at.
505 """
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000506 # Method could be a function
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800507 # pylint: disable=no-self-use
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000508
maruel@chromium.org3410d912009-06-09 20:56:16 +0000509 # File extensions that are considered source files from a style guide
510 # perspective. Don't modify this list from a presubmit script!
maruel@chromium.orgc33455a2011-06-24 19:14:18 +0000511 #
512 # Files without an extension aren't included in the list. If you want to
local_bot30f774e2020-06-25 18:23:34 +0000513 # filter them as source files, add r'(^|.*?[\\\/])[^.]+$' to the allow list.
local_bot64021412020-07-08 21:05:39 +0000514 # Note that ALL CAPS files are skipped in DEFAULT_FILES_TO_SKIP below.
515 DEFAULT_FILES_TO_CHECK = (
maruel@chromium.org3410d912009-06-09 20:56:16 +0000516 # C++ and friends
Edward Lemura5799e32020-01-17 19:26:51 +0000517 r'.+\.c$', r'.+\.cc$', r'.+\.cpp$', r'.+\.h$', r'.+\.m$', r'.+\.mm$',
518 r'.+\.inl$', r'.+\.asm$', r'.+\.hxx$', r'.+\.hpp$', r'.+\.s$', r'.+\.S$',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000519 # Scripts
Edward Lemura5799e32020-01-17 19:26:51 +0000520 r'.+\.js$', r'.+\.py$', r'.+\.sh$', r'.+\.rb$', r'.+\.pl$', r'.+\.pm$',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000521 # Other
Edward Lemura5799e32020-01-17 19:26:51 +0000522 r'.+\.java$', r'.+\.mk$', r'.+\.am$', r'.+\.css$', r'.+\.mojom$',
523 r'.+\.fidl$'
maruel@chromium.org3410d912009-06-09 20:56:16 +0000524 )
525
526 # Path regexp that should be excluded from being considered containing source
527 # files. Don't modify this list from a presubmit script!
local_bot64021412020-07-08 21:05:39 +0000528 DEFAULT_FILES_TO_SKIP = (
Edward Lemura5799e32020-01-17 19:26:51 +0000529 r'testing_support[\\\/]google_appengine[\\\/].*',
530 r'.*\bexperimental[\\\/].*',
Kent Tamura179dd1e2018-04-26 15:07:41 +0900531 # Exclude third_party/.* but NOT third_party/{WebKit,blink}
532 # (crbug.com/539768 and crbug.com/836555).
Edward Lemura5799e32020-01-17 19:26:51 +0000533 r'.*\bthird_party[\\\/](?!(WebKit|blink)[\\\/]).*',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000534 # Output directories (just in case)
Edward Lemura5799e32020-01-17 19:26:51 +0000535 r'.*\bDebug[\\\/].*',
536 r'.*\bRelease[\\\/].*',
537 r'.*\bxcodebuild[\\\/].*',
538 r'.*\bout[\\\/].*',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000539 # All caps files like README and LICENCE.
Edward Lemura5799e32020-01-17 19:26:51 +0000540 r'.*\b[A-Z0-9_]{2,}$',
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +0000541 # SCM (can happen in dual SCM configuration). (Slightly over aggressive)
Edward Lemura5799e32020-01-17 19:26:51 +0000542 r'(|.*[\\\/])\.git[\\\/].*',
543 r'(|.*[\\\/])\.svn[\\\/].*',
maruel@chromium.org7ccb4bb2011-11-07 20:26:20 +0000544 # There is no point in processing a patch file.
Edward Lemura5799e32020-01-17 19:26:51 +0000545 r'.+\.diff$',
546 r'.+\.patch$',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000547 )
548
local_bot30f774e2020-06-25 18:23:34 +0000549 # TODO(https://crbug.com/1098562): Remove once no longer used
550 @property
551 def DEFAULT_WHITE_LIST(self):
local_bot64021412020-07-08 21:05:39 +0000552 return self.DEFAULT_FILES_TO_CHECK
local_bot30f774e2020-06-25 18:23:34 +0000553
554 # TODO(https://crbug.com/1098562): Remove once no longer used
local_bot37ce2012020-06-26 17:39:24 +0000555 @DEFAULT_WHITE_LIST.setter
556 def DEFAULT_WHITE_LIST(self, value):
local_bot64021412020-07-08 21:05:39 +0000557 self.DEFAULT_FILES_TO_CHECK = value
558
559 # TODO(https://crbug.com/1098562): Remove once no longer used
560 @property
561 def DEFAULT_ALLOW_LIST(self):
562 return self.DEFAULT_FILES_TO_CHECK
563
564 # TODO(https://crbug.com/1098562): Remove once no longer used
565 @DEFAULT_ALLOW_LIST.setter
566 def DEFAULT_ALLOW_LIST(self, value):
567 self.DEFAULT_FILES_TO_CHECK = value
local_bot37ce2012020-06-26 17:39:24 +0000568
569 # TODO(https://crbug.com/1098562): Remove once no longer used
local_bot30f774e2020-06-25 18:23:34 +0000570 @property
571 def DEFAULT_BLACK_LIST(self):
local_bot64021412020-07-08 21:05:39 +0000572 return self.DEFAULT_FILES_TO_SKIP
local_bot30f774e2020-06-25 18:23:34 +0000573
local_bot37ce2012020-06-26 17:39:24 +0000574 # TODO(https://crbug.com/1098562): Remove once no longer used
575 @DEFAULT_BLACK_LIST.setter
576 def DEFAULT_BLACK_LIST(self, value):
local_bot64021412020-07-08 21:05:39 +0000577 self.DEFAULT_FILES_TO_SKIP = value
578
579 # TODO(https://crbug.com/1098562): Remove once no longer used
580 @property
581 def DEFAULT_BLOCK_LIST(self):
582 return self.DEFAULT_FILES_TO_SKIP
583
584 # TODO(https://crbug.com/1098562): Remove once no longer used
585 @DEFAULT_BLOCK_LIST.setter
586 def DEFAULT_BLOCK_LIST(self, value):
587 self.DEFAULT_FILES_TO_SKIP = value
local_bot37ce2012020-06-26 17:39:24 +0000588
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000589 def __init__(self, change, presubmit_path, is_committing,
Edward Lesmes8e282792018-04-03 18:50:29 -0400590 verbose, gerrit_obj, dry_run=None, thread_pool=None, parallel=False):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000591 """Builds an InputApi object.
592
593 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000594 change: A presubmit.Change object.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000595 presubmit_path: The path to the presubmit script being processed.
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000596 is_committing: True if the change is about to be committed.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000597 gerrit_obj: provides basic Gerrit codereview functionality.
598 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -0400599 parallel: if true, all tests reported via input_api.RunTests for all
600 PRESUBMIT files will be run in parallel.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000601 """
maruel@chromium.org9711bba2009-05-22 23:51:39 +0000602 # Version number of the presubmit_support script.
603 self.version = [int(x) for x in __version__.split('.')]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000604 self.change = change
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000605 self.is_committing = is_committing
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000606 self.gerrit = gerrit_obj
tandrii@chromium.org57bafac2016-04-28 05:09:03 +0000607 self.dry_run = dry_run
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000608
Edward Lesmes8e282792018-04-03 18:50:29 -0400609 self.parallel = parallel
610 self.thread_pool = thread_pool or ThreadPool()
611
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000612 # We expose various modules and functions as attributes of the input_api
613 # so that presubmit scripts don't have to import them.
Takeshi Yoshino07a6bea2017-08-02 02:44:06 +0900614 self.ast = ast
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000615 self.basename = os.path.basename
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000616 self.cpplint = cpplint
dcheng091b7db2016-06-16 01:27:51 -0700617 self.fnmatch = fnmatch
Yoshisato Yanagisawa04600b42019-03-15 03:03:41 +0000618 self.gclient_paths = gclient_paths
Yoshisato Yanagisawa57dd17b2019-03-22 09:10:29 +0000619 # TODO(yyanagisawa): stop exposing this when python3 become default.
620 # Since python3's tempfile has TemporaryDirectory, we do not need this.
621 self.temporary_directory = gclient_utils.temporary_directory
dpranke@chromium.org17cc2442012-10-17 21:12:09 +0000622 self.glob = glob.glob
maruel@chromium.orgfb11c7b2010-03-18 18:22:14 +0000623 self.json = json
maruel@chromium.org6fba34d2011-06-02 13:45:12 +0000624 self.logging = logging.getLogger('PRESUBMIT')
maruel@chromium.org2b5ce562011-03-31 16:15:44 +0000625 self.os_listdir = os.listdir
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000626 self.os_path = os.path
pgervais@chromium.orgbd0cace2014-10-02 23:23:46 +0000627 self.os_stat = os.stat
Yoshisato Yanagisawa406de132018-06-29 05:43:25 +0000628 self.os_walk = os.walk
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000629 self.re = re
630 self.subprocess = subprocess
Edward Lemurb9830242019-10-30 22:19:20 +0000631 self.sys = sys
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000632 self.tempfile = tempfile
dpranke@chromium.org0d1bdea2011-03-24 22:54:38 +0000633 self.time = time
maruel@chromium.org1487d532009-06-06 00:22:57 +0000634 self.unittest = unittest
Edward Lemurb9830242019-10-30 22:19:20 +0000635 if sys.version_info.major == 2:
636 self.urllib2 = urllib2
Edward Lemur16af3562019-10-17 22:11:33 +0000637 self.urllib_request = urllib_request
638 self.urllib_error = urllib_error
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000639
Robert Iannucci50258932018-03-19 10:30:59 -0700640 self.is_windows = sys.platform == 'win32'
641
Edward Lemurb9646622019-10-25 20:57:35 +0000642 # Set python_executable to 'vpython' in order to allow scripts in other
643 # repos (e.g. src.git) to automatically pick up that repo's .vpython file,
644 # instead of inheriting the one in depot_tools.
645 self.python_executable = 'vpython'
Erik Staab69135d12021-05-14 22:31:57 +0000646 # Offer a python 3 executable for use during the migration off of python 2.
647 self.python3_executable = 'vpython3'
maruel@chromium.orgc0b22972009-06-25 16:19:14 +0000648 self.environ = os.environ
649
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000650 # InputApi.platform is the platform you're currently running on.
651 self.platform = sys.platform
652
iannucci@chromium.org0af3bb32015-06-12 20:44:35 +0000653 self.cpu_count = multiprocessing.cpu_count()
654
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000655 # The local path of the currently-being-processed presubmit script.
maruel@chromium.org3d235242009-05-15 12:40:48 +0000656 self._current_presubmit_path = os.path.dirname(presubmit_path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000657
658 # We carry the canned checks so presubmit scripts can easily use them.
659 self.canned_checks = presubmit_canned_checks
660
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +0100661 # Temporary files we must manually remove at the end of a run.
662 self._named_temporary_files = []
Jochen Eisinger72606f82017-04-04 10:44:18 +0200663
Edward Lesmesdc11c6b2021-03-19 19:22:05 +0000664 self.owners_client = None
665 if self.gerrit:
666 self.owners_client = owners_client.GetCodeOwnersClient(
667 root=change.RepositoryRoot(),
668 upstream=change.UpstreamBranch(),
669 host=self.gerrit.host,
670 project=self.gerrit.project,
671 branch=self.gerrit.branch)
Edward Lesmes9ce03f82021-01-12 20:13:31 +0000672 self.owners_db = owners_db.Database(
673 change.RepositoryRoot(), fopen=open, os_path=self.os_path)
Jochen Eisinger76f5fc62017-04-07 16:27:46 +0200674 self.owners_finder = owners_finder.OwnersFinder
maruel@chromium.org899e1c12011-04-07 17:03:18 +0000675 self.verbose = verbose
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000676 self.Command = CommandData
dpranke@chromium.org2a009622011-03-01 02:43:31 +0000677
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000678 # Replace <hash_map> and <hash_set> as headers that need to be included
Edward Lemura5799e32020-01-17 19:26:51 +0000679 # with 'base/containers/hash_tables.h' instead.
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000680 # Access to a protected member _XX of a client class
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800681 # pylint: disable=protected-access
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000682 self.cpplint._re_pattern_templates = [
danakj@chromium.org18278522013-06-11 22:42:32 +0000683 (a, b, 'base/containers/hash_tables.h')
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000684 if header in ('<hash_map>', '<hash_set>') else (a, b, header)
685 for (a, b, header) in cpplint._re_pattern_templates
686 ]
687
Edward Lemurecc27072020-01-06 16:42:34 +0000688 def SetTimeout(self, timeout):
689 self.thread_pool.timeout = timeout
690
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000691 def PresubmitLocalPath(self):
692 """Returns the local path of the presubmit script currently being run.
693
694 This is useful if you don't want to hard-code absolute paths in the
695 presubmit script. For example, It can be used to find another file
696 relative to the PRESUBMIT.py script, so the whole tree can be branched and
697 the presubmit script still works, without editing its content.
698 """
maruel@chromium.org3d235242009-05-15 12:40:48 +0000699 return self._current_presubmit_path
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000700
agable0b65e732016-11-22 09:25:46 -0800701 def AffectedFiles(self, include_deletes=True, file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000702 """Same as input_api.change.AffectedFiles() except only lists files
703 (and optionally directories) in the same directory as the current presubmit
Bruce Dawson7a0b07a2020-04-23 17:14:40 +0000704 script, or subdirectories thereof. Note that files are listed using the OS
705 path separator, so backslashes are used as separators on Windows.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000706 """
Edward Lemura5799e32020-01-17 19:26:51 +0000707 dir_with_slash = normpath('%s/' % self.PresubmitLocalPath())
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000708 if len(dir_with_slash) == 1:
709 dir_with_slash = ''
sail@chromium.org5538e022011-05-12 17:53:16 +0000710
Edward Lemurb9830242019-10-30 22:19:20 +0000711 return list(filter(
maruel@chromium.org4661e0c2009-06-04 00:45:26 +0000712 lambda x: normpath(x.AbsoluteLocalPath()).startswith(dir_with_slash),
Edward Lemurb9830242019-10-30 22:19:20 +0000713 self.change.AffectedFiles(include_deletes, file_filter)))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000714
agable0b65e732016-11-22 09:25:46 -0800715 def LocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000716 """Returns local paths of input_api.AffectedFiles()."""
agable0b65e732016-11-22 09:25:46 -0800717 paths = [af.LocalPath() for af in self.AffectedFiles()]
Edward Lemura5799e32020-01-17 19:26:51 +0000718 logging.debug('LocalPaths: %s', paths)
pgervais@chromium.org2f64f782014-04-25 00:12:33 +0000719 return paths
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000720
agable0b65e732016-11-22 09:25:46 -0800721 def AbsoluteLocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000722 """Returns absolute local paths of input_api.AffectedFiles()."""
agable0b65e732016-11-22 09:25:46 -0800723 return [af.AbsoluteLocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000724
John Budorick16162372018-04-18 10:39:53 -0700725 def AffectedTestableFiles(self, include_deletes=None, **kwargs):
agable0b65e732016-11-22 09:25:46 -0800726 """Same as input_api.change.AffectedTestableFiles() except only lists files
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000727 in the same directory as the current presubmit script, or subdirectories
728 thereof.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000729 """
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000730 if include_deletes is not None:
Edward Lemura5799e32020-01-17 19:26:51 +0000731 warn('AffectedTestableFiles(include_deletes=%s)'
732 ' is deprecated and ignored' % str(include_deletes),
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000733 category=DeprecationWarning,
734 stacklevel=2)
Edward Lemurb9830242019-10-30 22:19:20 +0000735 return list(filter(
736 lambda x: x.IsTestableFile(),
737 self.AffectedFiles(include_deletes=False, **kwargs)))
agable0b65e732016-11-22 09:25:46 -0800738
739 def AffectedTextFiles(self, include_deletes=None):
740 """An alias to AffectedTestableFiles for backwards compatibility."""
741 return self.AffectedTestableFiles(include_deletes=include_deletes)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000742
Josip Sokcevic8c955952021-02-01 21:32:57 +0000743 def FilterSourceFile(self,
744 affected_file,
745 files_to_check=None,
746 files_to_skip=None,
747 allow_list=None,
748 block_list=None):
Edward Lemura5799e32020-01-17 19:26:51 +0000749 """Filters out files that aren't considered 'source file'.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000750
local_bot64021412020-07-08 21:05:39 +0000751 If files_to_check or files_to_skip is None, InputApi.DEFAULT_FILES_TO_CHECK
752 and InputApi.DEFAULT_FILES_TO_SKIP is used respectively.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000753
754 The lists will be compiled as regular expression and
755 AffectedFile.LocalPath() needs to pass both list.
756
757 Note: Copy-paste this function to suit your needs or use a lambda function.
758 """
local_bot64021412020-07-08 21:05:39 +0000759 if files_to_check is None:
760 files_to_check = self.DEFAULT_FILES_TO_CHECK
761 if files_to_skip is None:
762 files_to_skip = self.DEFAULT_FILES_TO_SKIP
local_bot30f774e2020-06-25 18:23:34 +0000763
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000764 def Find(affected_file, items):
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000765 local_path = affected_file.LocalPath()
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000766 for item in items:
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +0000767 if self.re.match(item, local_path):
maruel@chromium.org3410d912009-06-09 20:56:16 +0000768 return True
769 return False
local_bot64021412020-07-08 21:05:39 +0000770 return (Find(affected_file, files_to_check) and
771 not Find(affected_file, files_to_skip))
maruel@chromium.org3410d912009-06-09 20:56:16 +0000772
773 def AffectedSourceFiles(self, source_file):
agable0b65e732016-11-22 09:25:46 -0800774 """Filter the list of AffectedTestableFiles by the function source_file.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000775
776 If source_file is None, InputApi.FilterSourceFile() is used.
777 """
778 if not source_file:
779 source_file = self.FilterSourceFile
Edward Lemurb9830242019-10-30 22:19:20 +0000780 return list(filter(source_file, self.AffectedTestableFiles()))
maruel@chromium.org3410d912009-06-09 20:56:16 +0000781
782 def RightHandSideLines(self, source_file_filter=None):
Edward Lemura5799e32020-01-17 19:26:51 +0000783 """An iterator over all text lines in 'new' version of changed files.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000784
785 Only lists lines from new or modified text files in the change that are
786 contained by the directory of the currently executing presubmit script.
787
788 This is useful for doing line-by-line regex checks, like checking for
789 trailing whitespace.
790
791 Yields:
792 a 3 tuple:
793 the AffectedFile instance of the current file;
794 integer line number (1-based); and
795 the contents of the line as a string.
maruel@chromium.org1487d532009-06-06 00:22:57 +0000796
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000797 Note: The carriage return (LF or CR) is stripped off.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000798 """
maruel@chromium.org3410d912009-06-09 20:56:16 +0000799 files = self.AffectedSourceFiles(source_file_filter)
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000800 return _RightHandSideLinesImpl(files)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000801
maruel@chromium.orge3608df2009-11-10 20:22:57 +0000802 def ReadFile(self, file_item, mode='r'):
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000803 """Reads an arbitrary file.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000804
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000805 Deny reading anything outside the repository.
806 """
maruel@chromium.orge3608df2009-11-10 20:22:57 +0000807 if isinstance(file_item, AffectedFile):
808 file_item = file_item.AbsoluteLocalPath()
809 if not file_item.startswith(self.change.RepositoryRoot()):
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000810 raise IOError('Access outside the repository root is denied.')
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +0000811 return gclient_utils.FileRead(file_item, mode)
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000812
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +0100813 def CreateTemporaryFile(self, **kwargs):
814 """Returns a named temporary file that must be removed with a call to
815 RemoveTemporaryFiles().
816
817 All keyword arguments are forwarded to tempfile.NamedTemporaryFile(),
818 except for |delete|, which is always set to False.
819
820 Presubmit checks that need to create a temporary file and pass it for
821 reading should use this function instead of NamedTemporaryFile(), as
822 Windows fails to open a file that is already open for writing.
823
824 with input_api.CreateTemporaryFile() as f:
825 f.write('xyz')
826 f.close()
827 input_api.subprocess.check_output(['script-that', '--reads-from',
828 f.name])
829
830
831 Note that callers of CreateTemporaryFile() should not worry about removing
832 any temporary file; this is done transparently by the presubmit handling
833 code.
834 """
835 if 'delete' in kwargs:
836 # Prevent users from passing |delete|; we take care of file deletion
837 # ourselves and this prevents unintuitive error messages when we pass
838 # delete=False and 'delete' is also in kwargs.
839 raise TypeError('CreateTemporaryFile() does not take a "delete" '
840 'argument, file deletion is handled automatically by '
841 'the same presubmit_support code that creates InputApi '
842 'objects.')
843 temp_file = self.tempfile.NamedTemporaryFile(delete=False, **kwargs)
844 self._named_temporary_files.append(temp_file.name)
845 return temp_file
846
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000847 @property
848 def tbr(self):
849 """Returns if a change is TBR'ed."""
Jeremy Romandce22502017-06-20 15:37:29 -0400850 return 'TBR' in self.change.tags or self.change.TBRsFromDescription()
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000851
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +0000852 def RunTests(self, tests_mix, parallel=True):
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000853 tests = []
854 msgs = []
855 for t in tests_mix:
Edward Lesmes8e282792018-04-03 18:50:29 -0400856 if isinstance(t, OutputApi.PresubmitResult) and t:
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000857 msgs.append(t)
858 else:
859 assert issubclass(t.message, _PresubmitResult)
860 tests.append(t)
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +0000861 if self.verbose:
862 t.info = _PresubmitNotifyResult
Edward Lemur1037c742018-05-01 18:56:04 -0400863 if not t.kwargs.get('cwd'):
864 t.kwargs['cwd'] = self.PresubmitLocalPath()
Edward Lesmes8e282792018-04-03 18:50:29 -0400865 self.thread_pool.AddTests(tests, parallel)
Edward Lemur21000eb2019-05-24 23:25:58 +0000866 # When self.parallel is True (i.e. --parallel is passed as an option)
867 # RunTests doesn't actually run tests. It adds them to a ThreadPool that
868 # will run all tests once all PRESUBMIT files are processed.
869 # Otherwise, it will run them and return the results.
870 if not self.parallel:
Edward Lesmes8e282792018-04-03 18:50:29 -0400871 msgs.extend(self.thread_pool.RunAsync())
872 return msgs
scottmg86099d72016-09-01 09:16:51 -0700873
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000874
nick@chromium.orgff526192013-06-10 19:30:26 +0000875class _DiffCache(object):
876 """Caches diffs retrieved from a particular SCM."""
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000877 def __init__(self, upstream=None):
878 """Stores the upstream revision against which all diffs will be computed."""
879 self._upstream = upstream
nick@chromium.orgff526192013-06-10 19:30:26 +0000880
881 def GetDiff(self, path, local_root):
882 """Get the diff for a particular path."""
883 raise NotImplementedError()
884
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700885 def GetOldContents(self, path, local_root):
886 """Get the old version for a particular path."""
887 raise NotImplementedError()
888
nick@chromium.orgff526192013-06-10 19:30:26 +0000889
nick@chromium.orgff526192013-06-10 19:30:26 +0000890class _GitDiffCache(_DiffCache):
891 """DiffCache implementation for git; gets all file diffs at once."""
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000892 def __init__(self, upstream):
893 super(_GitDiffCache, self).__init__(upstream=upstream)
nick@chromium.orgff526192013-06-10 19:30:26 +0000894 self._diffs_by_file = None
895
896 def GetDiff(self, path, local_root):
897 if not self._diffs_by_file:
898 # Compute a single diff for all files and parse the output; should
899 # with git this is much faster than computing one diff for each file.
900 diffs = {}
901
902 # Don't specify any filenames below, because there are command line length
903 # limits on some platforms and GenerateDiff would fail.
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000904 unified_diff = scm.GIT.GenerateDiff(local_root, files=[], full_move=True,
905 branch=self._upstream)
nick@chromium.orgff526192013-06-10 19:30:26 +0000906
907 # This regex matches the path twice, separated by a space. Note that
908 # filename itself may contain spaces.
909 file_marker = re.compile('^diff --git (?P<filename>.*) (?P=filename)$')
910 current_diff = []
911 keep_line_endings = True
912 for x in unified_diff.splitlines(keep_line_endings):
913 match = file_marker.match(x)
914 if match:
915 # Marks the start of a new per-file section.
916 diffs[match.group('filename')] = current_diff = [x]
917 elif x.startswith('diff --git'):
918 raise PresubmitFailure('Unexpected diff line: %s' % x)
919 else:
920 current_diff.append(x)
921
922 self._diffs_by_file = dict(
923 (normpath(path), ''.join(diff)) for path, diff in diffs.items())
924
925 if path not in self._diffs_by_file:
926 raise PresubmitFailure(
927 'Unified diff did not contain entry for file %s' % path)
928
929 return self._diffs_by_file[path]
930
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700931 def GetOldContents(self, path, local_root):
932 return scm.GIT.GetOldContents(local_root, path, branch=self._upstream)
933
nick@chromium.orgff526192013-06-10 19:30:26 +0000934
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000935class AffectedFile(object):
936 """Representation of a file in a change."""
nick@chromium.orgff526192013-06-10 19:30:26 +0000937
938 DIFF_CACHE = _DiffCache
939
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000940 # Method could be a function
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800941 # pylint: disable=no-self-use
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000942 def __init__(self, path, action, repository_root, diff_cache):
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000943 self._path = path
944 self._action = action
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000945 self._local_root = repository_root
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000946 self._is_directory = None
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000947 self._cached_changed_contents = None
948 self._cached_new_contents = None
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000949 self._diff_cache = diff_cache
tobiasjs2836bcf2016-08-16 04:08:16 -0700950 logging.debug('%s(%s)', self.__class__.__name__, self._path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000951
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000952 def LocalPath(self):
953 """Returns the path of this file on the local disk relative to client root.
Andrew Grieve92b8b992017-11-02 09:42:24 -0400954
955 This should be used for error messages but not for accessing files,
956 because presubmit checks are run with CWD=PresubmitLocalPath() (which is
957 often != client root).
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000958 """
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000959 return normpath(self._path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000960
961 def AbsoluteLocalPath(self):
962 """Returns the absolute path of this file on the local disk.
963 """
chase@chromium.org8e416c82009-10-06 04:30:44 +0000964 return os.path.abspath(os.path.join(self._local_root, self.LocalPath()))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000965
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000966 def Action(self):
967 """Returns the action on this opened file, e.g. A, M, D, etc."""
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000968 return self._action
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000969
agable0b65e732016-11-22 09:25:46 -0800970 def IsTestableFile(self):
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000971 """Returns True if the file is a text file and not a binary file.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000972
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000973 Deleted files are not text file."""
maruel@chromium.org1e08c002009-05-28 19:09:33 +0000974 raise NotImplementedError() # Implement when needed
975
agable0b65e732016-11-22 09:25:46 -0800976 def IsTextFile(self):
977 """An alias to IsTestableFile for backwards compatibility."""
978 return self.IsTestableFile()
979
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700980 def OldContents(self):
981 """Returns an iterator over the lines in the old version of file.
982
Daniel Cheng2da34fe2017-03-21 20:42:12 -0700983 The old version is the file before any modifications in the user's
Edward Lemura5799e32020-01-17 19:26:51 +0000984 workspace, i.e. the 'left hand side'.
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700985
986 Contents will be empty if the file is a directory or does not exist.
987 Note: The carriage returns (LF or CR) are stripped off.
988 """
989 return self._diff_cache.GetOldContents(self.LocalPath(),
990 self._local_root).splitlines()
991
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000992 def NewContents(self):
993 """Returns an iterator over the lines in the new version of file.
994
Edward Lemura5799e32020-01-17 19:26:51 +0000995 The new version is the file in the user's workspace, i.e. the 'right hand
996 side'.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000997
998 Contents will be empty if the file is a directory or does not exist.
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000999 Note: The carriage returns (LF or CR) are stripped off.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001000 """
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +00001001 if self._cached_new_contents is None:
1002 self._cached_new_contents = []
agable0b65e732016-11-22 09:25:46 -08001003 try:
1004 self._cached_new_contents = gclient_utils.FileRead(
1005 self.AbsoluteLocalPath(), 'rU').splitlines()
1006 except IOError:
1007 pass # File not found? That's fine; maybe it was deleted.
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +00001008 return self._cached_new_contents[:]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001009
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001010 def ChangedContents(self):
1011 """Returns a list of tuples (line number, line text) of all new lines.
1012
1013 This relies on the scm diff output describing each changed code section
1014 with a line of the form
1015
1016 ^@@ <old line num>,<old size> <new line num>,<new size> @@$
1017 """
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +00001018 if self._cached_changed_contents is not None:
1019 return self._cached_changed_contents[:]
1020 self._cached_changed_contents = []
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001021 line_num = 0
1022
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001023 for line in self.GenerateScmDiff().splitlines():
Edward Lemurac5c55f2020-02-29 00:17:16 +00001024 m = re.match(r'^@@ [0-9\,\+\-]+ \+([0-9]+)\,[0-9]+ @@', line)
1025 if m:
1026 line_num = int(m.groups(1)[0])
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001027 continue
1028 if line.startswith('+') and not line.startswith('++'):
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +00001029 self._cached_changed_contents.append((line_num, line[1:]))
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001030 if not line.startswith('-'):
1031 line_num += 1
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +00001032 return self._cached_changed_contents[:]
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001033
maruel@chromium.org5de13972009-06-10 18:16:06 +00001034 def __str__(self):
1035 return self.LocalPath()
1036
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001037 def GenerateScmDiff(self):
nick@chromium.orgff526192013-06-10 19:30:26 +00001038 return self._diff_cache.GetDiff(self.LocalPath(), self._local_root)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001039
maruel@chromium.org58407af2011-04-12 23:15:57 +00001040
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001041class GitAffectedFile(AffectedFile):
1042 """Representation of a file in a change out of a git checkout."""
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +00001043 # Method 'NNN' is abstract in class 'NNN' but is not overridden
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -08001044 # pylint: disable=abstract-method
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001045
nick@chromium.orgff526192013-06-10 19:30:26 +00001046 DIFF_CACHE = _GitDiffCache
1047
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001048 def __init__(self, *args, **kwargs):
1049 AffectedFile.__init__(self, *args, **kwargs)
1050 self._server_path = None
agable0b65e732016-11-22 09:25:46 -08001051 self._is_testable_file = None
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001052
agable0b65e732016-11-22 09:25:46 -08001053 def IsTestableFile(self):
1054 if self._is_testable_file is None:
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001055 if self.Action() == 'D':
agable0b65e732016-11-22 09:25:46 -08001056 # A deleted file is not testable.
1057 self._is_testable_file = False
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001058 else:
agable0b65e732016-11-22 09:25:46 -08001059 self._is_testable_file = os.path.isfile(self.AbsoluteLocalPath())
1060 return self._is_testable_file
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001061
maruel@chromium.orgc1938752011-04-12 23:11:13 +00001062
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001063class Change(object):
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001064 """Describe a change.
1065
1066 Used directly by the presubmit scripts to query the current change being
1067 tested.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +00001068
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001069 Instance members:
nick@chromium.orgff526192013-06-10 19:30:26 +00001070 tags: Dictionary of KEY=VALUE pairs found in the change description.
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001071 self.KEY: equivalent to tags['KEY']
1072 """
1073
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001074 _AFFECTED_FILES = AffectedFile
1075
Edward Lemura5799e32020-01-17 19:26:51 +00001076 # Matches key/value (or 'tag') lines in changelist descriptions.
maruel@chromium.org428342a2011-11-10 15:46:33 +00001077 TAG_LINE_RE = re.compile(
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001078 '^[ \t]*(?P<key>[A-Z][A-Z_0-9]*)[ \t]*=[ \t]*(?P<value>.*?)[ \t]*$')
maruel@chromium.orgc1938752011-04-12 23:11:13 +00001079 scm = ''
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001080
maruel@chromium.org58407af2011-04-12 23:15:57 +00001081 def __init__(
agable@chromium.orgea84ef12014-04-30 19:55:12 +00001082 self, name, description, local_root, files, issue, patchset, author,
1083 upstream=None):
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001084 if files is None:
1085 files = []
1086 self._name = name
chase@chromium.org8e416c82009-10-06 04:30:44 +00001087 # Convert root into an absolute path.
1088 self._local_root = os.path.abspath(local_root)
agable@chromium.orgea84ef12014-04-30 19:55:12 +00001089 self._upstream = upstream
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001090 self.issue = issue
1091 self.patchset = patchset
maruel@chromium.org58407af2011-04-12 23:15:57 +00001092 self.author_email = author
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001093
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001094 self._full_description = ''
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001095 self.tags = {}
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001096 self._description_without_tags = ''
1097 self.SetDescriptionText(description)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001098
maruel@chromium.orge085d812011-10-10 19:49:15 +00001099 assert all(
1100 (isinstance(f, (list, tuple)) and len(f) == 2) for f in files), files
1101
agable@chromium.orgea84ef12014-04-30 19:55:12 +00001102 diff_cache = self._AFFECTED_FILES.DIFF_CACHE(self._upstream)
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001103 self._affected_files = [
nick@chromium.orgff526192013-06-10 19:30:26 +00001104 self._AFFECTED_FILES(path, action.strip(), self._local_root, diff_cache)
1105 for action, path in files
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +00001106 ]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001107
Edward Lesmes9ce03f82021-01-12 20:13:31 +00001108 def UpstreamBranch(self):
1109 """Returns the upstream branch for the change."""
1110 return self._upstream
1111
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001112 def Name(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001113 """Returns the change name."""
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001114 return self._name
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001115
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001116 def DescriptionText(self):
1117 """Returns the user-entered changelist description, minus tags.
1118
Edward Lemura5799e32020-01-17 19:26:51 +00001119 Any line in the user-provided description starting with e.g. 'FOO='
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001120 (whitespace permitted before and around) is considered a tag line. Such
1121 lines are stripped out of the description this function returns.
1122 """
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001123 return self._description_without_tags
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001124
1125 def FullDescriptionText(self):
1126 """Returns the complete changelist description including tags."""
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001127 return self._full_description
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001128
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001129 def SetDescriptionText(self, description):
1130 """Sets the full description text (including tags) to |description|.
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001131
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001132 Also updates the list of tags."""
1133 self._full_description = description
1134
1135 # From the description text, build up a dictionary of key/value pairs
Edward Lemura5799e32020-01-17 19:26:51 +00001136 # plus the description minus all key/value or 'tag' lines.
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001137 description_without_tags = []
1138 self.tags = {}
1139 for line in self._full_description.splitlines():
1140 m = self.TAG_LINE_RE.match(line)
1141 if m:
1142 self.tags[m.group('key')] = m.group('value')
1143 else:
1144 description_without_tags.append(line)
1145
1146 # Change back to text and remove whitespace at end.
1147 self._description_without_tags = (
1148 '\n'.join(description_without_tags).rstrip())
1149
Edward Lemur69bb8be2020-02-03 20:37:38 +00001150 def AddDescriptionFooter(self, key, value):
1151 """Adds the given footer to the change description.
1152
1153 Args:
1154 key: A string with the key for the git footer. It must conform to
1155 the git footers format (i.e. 'List-Of-Tokens') and will be case
1156 normalized so that each token is title-cased.
1157 value: A string with the value for the git footer.
1158 """
1159 description = git_footers.add_footer(
1160 self.FullDescriptionText(), git_footers.normalize_name(key), value)
1161 self.SetDescriptionText(description)
1162
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001163 def RepositoryRoot(self):
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001164 """Returns the repository (checkout) root directory for this change,
1165 as an absolute path.
1166 """
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001167 return self._local_root
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001168
1169 def __getattr__(self, attr):
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001170 """Return tags directly as attributes on the object."""
Edward Lemura5799e32020-01-17 19:26:51 +00001171 if not re.match(r'^[A-Z_]*$', attr):
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001172 raise AttributeError(self, attr)
maruel@chromium.orge1a524f2009-05-27 14:43:46 +00001173 return self.tags.get(attr)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001174
Edward Lemur69bb8be2020-02-03 20:37:38 +00001175 def GitFootersFromDescription(self):
1176 """Return the git footers present in the description.
1177
1178 Returns:
1179 footers: A dict of {footer: [values]} containing a multimap of the footers
1180 in the change description.
1181 """
1182 return git_footers.parse_footers(self.FullDescriptionText())
1183
Aaron Gablefc03e672017-05-15 14:09:42 -07001184 def BugsFromDescription(self):
1185 """Returns all bugs referenced in the commit description."""
Aaron Gable12ef5012017-05-15 14:29:00 -07001186 tags = [b.strip() for b in self.tags.get('BUG', '').split(',') if b.strip()]
Caleb Rouleauc0546b92019-02-22 06:12:57 +00001187 footers = []
Edward Lemur69bb8be2020-02-03 20:37:38 +00001188 parsed = self.GitFootersFromDescription()
Dan Beam62954042019-10-03 21:20:33 +00001189 unsplit_footers = parsed.get('Bug', []) + parsed.get('Fixed', [])
Caleb Rouleauc0546b92019-02-22 06:12:57 +00001190 for unsplit_footer in unsplit_footers:
1191 footers += [b.strip() for b in unsplit_footer.split(',')]
Aaron Gable12ef5012017-05-15 14:29:00 -07001192 return sorted(set(tags + footers))
Aaron Gablefc03e672017-05-15 14:09:42 -07001193
1194 def ReviewersFromDescription(self):
1195 """Returns all reviewers listed in the commit description."""
Edward Lemura5799e32020-01-17 19:26:51 +00001196 # We don't support a 'R:' git-footer for reviewers; that is in metadata.
Aaron Gable12ef5012017-05-15 14:29:00 -07001197 tags = [r.strip() for r in self.tags.get('R', '').split(',') if r.strip()]
1198 return sorted(set(tags))
Aaron Gablefc03e672017-05-15 14:09:42 -07001199
1200 def TBRsFromDescription(self):
1201 """Returns all TBR reviewers listed in the commit description."""
Aaron Gable12ef5012017-05-15 14:29:00 -07001202 tags = [r.strip() for r in self.tags.get('TBR', '').split(',') if r.strip()]
Aaron Gable6e7ddb62020-05-27 22:23:29 +00001203 # TODO(crbug.com/839208): Remove support for 'Tbr:' when TBRs are
1204 # programmatically determined by self-CR+1s.
Edward Lemur69bb8be2020-02-03 20:37:38 +00001205 footers = self.GitFootersFromDescription().get('Tbr', [])
Aaron Gable12ef5012017-05-15 14:29:00 -07001206 return sorted(set(tags + footers))
Aaron Gablefc03e672017-05-15 14:09:42 -07001207
Aaron Gable6e7ddb62020-05-27 22:23:29 +00001208 # TODO(crbug.com/753425): Delete these once we're sure they're unused.
Aaron Gablefc03e672017-05-15 14:09:42 -07001209 @property
1210 def BUG(self):
1211 return ','.join(self.BugsFromDescription())
1212 @property
1213 def R(self):
1214 return ','.join(self.ReviewersFromDescription())
1215 @property
1216 def TBR(self):
1217 return ','.join(self.TBRsFromDescription())
1218
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001219 def AllFiles(self, root=None):
1220 """List all files under source control in the repo."""
1221 raise NotImplementedError()
1222
agable0b65e732016-11-22 09:25:46 -08001223 def AffectedFiles(self, include_deletes=True, file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001224 """Returns a list of AffectedFile instances for all files in the change.
1225
1226 Args:
1227 include_deletes: If false, deleted files will be filtered out.
sail@chromium.org5538e022011-05-12 17:53:16 +00001228 file_filter: An additional filter to apply.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001229
1230 Returns:
1231 [AffectedFile(path, action), AffectedFile(path, action)]
1232 """
Edward Lemurb9830242019-10-30 22:19:20 +00001233 affected = list(filter(file_filter, self._affected_files))
sail@chromium.org5538e022011-05-12 17:53:16 +00001234
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001235 if include_deletes:
1236 return affected
Edward Lemurb9830242019-10-30 22:19:20 +00001237 return list(filter(lambda x: x.Action() != 'D', affected))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001238
John Budorick16162372018-04-18 10:39:53 -07001239 def AffectedTestableFiles(self, include_deletes=None, **kwargs):
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +00001240 """Return a list of the existing text files in a change."""
1241 if include_deletes is not None:
Edward Lemura5799e32020-01-17 19:26:51 +00001242 warn('AffectedTeestableFiles(include_deletes=%s)'
1243 ' is deprecated and ignored' % str(include_deletes),
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +00001244 category=DeprecationWarning,
1245 stacklevel=2)
Edward Lemurb9830242019-10-30 22:19:20 +00001246 return list(filter(
1247 lambda x: x.IsTestableFile(),
1248 self.AffectedFiles(include_deletes=False, **kwargs)))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001249
agable0b65e732016-11-22 09:25:46 -08001250 def AffectedTextFiles(self, include_deletes=None):
1251 """An alias to AffectedTestableFiles for backwards compatibility."""
1252 return self.AffectedTestableFiles(include_deletes=include_deletes)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001253
agable0b65e732016-11-22 09:25:46 -08001254 def LocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001255 """Convenience function."""
agable0b65e732016-11-22 09:25:46 -08001256 return [af.LocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001257
agable0b65e732016-11-22 09:25:46 -08001258 def AbsoluteLocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001259 """Convenience function."""
agable0b65e732016-11-22 09:25:46 -08001260 return [af.AbsoluteLocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001261
1262 def RightHandSideLines(self):
Edward Lemura5799e32020-01-17 19:26:51 +00001263 """An iterator over all text lines in 'new' version of changed files.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001264
1265 Lists lines from new or modified text files in the change.
1266
1267 This is useful for doing line-by-line regex checks, like checking for
1268 trailing whitespace.
1269
1270 Yields:
1271 a 3 tuple:
1272 the AffectedFile instance of the current file;
1273 integer line number (1-based); and
1274 the contents of the line as a string.
1275 """
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +00001276 return _RightHandSideLinesImpl(
1277 x for x in self.AffectedFiles(include_deletes=False)
agable0b65e732016-11-22 09:25:46 -08001278 if x.IsTestableFile())
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001279
Jochen Eisingerd0573ec2017-04-13 10:55:06 +02001280 def OriginalOwnersFiles(self):
1281 """A map from path names of affected OWNERS files to their old content."""
1282 def owners_file_filter(f):
1283 return 'OWNERS' in os.path.split(f.LocalPath())[1]
1284 files = self.AffectedFiles(file_filter=owners_file_filter)
1285 return dict([(f.LocalPath(), f.OldContents()) for f in files])
1286
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001287
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001288class GitChange(Change):
1289 _AFFECTED_FILES = GitAffectedFile
maruel@chromium.orgc1938752011-04-12 23:11:13 +00001290 scm = 'git'
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +00001291
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001292 def AllFiles(self, root=None):
1293 """List all files under source control in the repo."""
1294 root = root or self.RepositoryRoot()
1295 return subprocess.check_output(
Aaron Gable7817f022017-12-12 09:43:17 -08001296 ['git', '-c', 'core.quotePath=false', 'ls-files', '--', '.'],
1297 cwd=root).splitlines()
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001298
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001299
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001300def ListRelevantPresubmitFiles(files, root):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001301 """Finds all presubmit files that apply to a given set of source files.
1302
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001303 If inherit-review-settings-ok is present right under root, looks for
1304 PRESUBMIT.py in directories enclosing root.
1305
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001306 Args:
1307 files: An iterable container containing file paths.
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001308 root: Path where to stop searching.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001309
1310 Return:
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001311 List of absolute paths of the existing PRESUBMIT.py scripts.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001312 """
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001313 files = [normpath(os.path.join(root, f)) for f in files]
1314
1315 # List all the individual directories containing files.
1316 directories = set([os.path.dirname(f) for f in files])
1317
1318 # Ignore root if inherit-review-settings-ok is present.
1319 if os.path.isfile(os.path.join(root, 'inherit-review-settings-ok')):
1320 root = None
1321
1322 # Collect all unique directories that may contain PRESUBMIT.py.
1323 candidates = set()
1324 for directory in directories:
1325 while True:
1326 if directory in candidates:
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001327 break
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001328 candidates.add(directory)
1329 if directory == root:
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001330 break
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001331 parent_dir = os.path.dirname(directory)
1332 if parent_dir == directory:
1333 # We hit the system root directory.
1334 break
1335 directory = parent_dir
1336
1337 # Look for PRESUBMIT.py in all candidate directories.
1338 results = []
1339 for directory in sorted(list(candidates)):
tobiasjsff061c02016-08-17 03:23:57 -07001340 try:
1341 for f in os.listdir(directory):
1342 p = os.path.join(directory, f)
1343 if os.path.isfile(p) and re.match(
1344 r'PRESUBMIT.*\.py$', f) and not f.startswith('PRESUBMIT_test'):
1345 results.append(p)
1346 except OSError:
1347 pass
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001348
tobiasjs2836bcf2016-08-16 04:08:16 -07001349 logging.debug('Presubmit files: %s', ','.join(results))
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001350 return results
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001351
1352
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001353class GetTryMastersExecuter(object):
1354 @staticmethod
1355 def ExecPresubmitScript(script_text, presubmit_path, project, change):
1356 """Executes GetPreferredTryMasters() from a single presubmit script.
1357
1358 Args:
1359 script_text: The text of the presubmit script.
1360 presubmit_path: Project script to run.
1361 project: Project name to pass to presubmit script for bot selection.
1362
1363 Return:
1364 A map of try masters to map of builders to set of tests.
1365 """
1366 context = {}
1367 try:
Raul Tambre09e64b42019-05-14 01:57:22 +00001368 exec(compile(script_text, 'PRESUBMIT.py', 'exec', dont_inherit=True),
1369 context)
Raul Tambre7c938462019-05-24 16:35:35 +00001370 except Exception as e:
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001371 raise PresubmitFailure('"%s" had an exception.\n%s'
1372 % (presubmit_path, e))
1373
1374 function_name = 'GetPreferredTryMasters'
1375 if function_name not in context:
1376 return {}
1377 get_preferred_try_masters = context[function_name]
1378 if not len(inspect.getargspec(get_preferred_try_masters)[0]) == 2:
1379 raise PresubmitFailure(
1380 'Expected function "GetPreferredTryMasters" to take two arguments.')
1381 return get_preferred_try_masters(project, change)
1382
1383
rmistry@google.com5626a922015-02-26 14:03:30 +00001384class GetPostUploadExecuter(object):
1385 @staticmethod
Edward Lemur016a0872020-02-04 22:13:28 +00001386 def ExecPresubmitScript(script_text, presubmit_path, gerrit_obj, change):
rmistry@google.com5626a922015-02-26 14:03:30 +00001387 """Executes PostUploadHook() from a single presubmit script.
1388
1389 Args:
1390 script_text: The text of the presubmit script.
1391 presubmit_path: Project script to run.
Edward Lemur016a0872020-02-04 22:13:28 +00001392 gerrit_obj: The GerritAccessor object.
rmistry@google.com5626a922015-02-26 14:03:30 +00001393 change: The Change object.
1394
1395 Return:
1396 A list of results objects.
1397 """
1398 context = {}
1399 try:
Raul Tambre09e64b42019-05-14 01:57:22 +00001400 exec(compile(script_text, 'PRESUBMIT.py', 'exec', dont_inherit=True),
1401 context)
Raul Tambre7c938462019-05-24 16:35:35 +00001402 except Exception as e:
rmistry@google.com5626a922015-02-26 14:03:30 +00001403 raise PresubmitFailure('"%s" had an exception.\n%s'
1404 % (presubmit_path, e))
1405
1406 function_name = 'PostUploadHook'
1407 if function_name not in context:
1408 return {}
1409 post_upload_hook = context[function_name]
1410 if not len(inspect.getargspec(post_upload_hook)[0]) == 3:
1411 raise PresubmitFailure(
1412 'Expected function "PostUploadHook" to take three arguments.')
Edward Lemur016a0872020-02-04 22:13:28 +00001413 return post_upload_hook(gerrit_obj, change, OutputApi(False))
rmistry@google.com5626a922015-02-26 14:03:30 +00001414
1415
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001416def _MergeMasters(masters1, masters2):
1417 """Merges two master maps. Merges also the tests of each builder."""
1418 result = {}
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001419 for (master, builders) in itertools.chain(masters1.items(),
1420 masters2.items()):
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001421 new_builders = result.setdefault(master, {})
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001422 for (builder, tests) in builders.items():
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001423 new_builders.setdefault(builder, set([])).update(tests)
1424 return result
1425
1426
1427def DoGetTryMasters(change,
1428 changed_files,
1429 repository_root,
1430 default_presubmit,
1431 project,
1432 verbose,
1433 output_stream):
1434 """Get the list of try masters from the presubmit scripts.
1435
1436 Args:
1437 changed_files: List of modified files.
1438 repository_root: The repository root.
1439 default_presubmit: A default presubmit script to execute in any case.
1440 project: Optional name of a project used in selecting trybots.
1441 verbose: Prints debug info.
1442 output_stream: A stream to write debug output to.
1443
1444 Return:
1445 Map of try masters to map of builders to set of tests.
1446 """
1447 presubmit_files = ListRelevantPresubmitFiles(changed_files, repository_root)
1448 if not presubmit_files and verbose:
Edward Lemura5799e32020-01-17 19:26:51 +00001449 output_stream.write('Warning, no PRESUBMIT.py found.\n')
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001450 results = {}
1451 executer = GetTryMastersExecuter()
1452
1453 if default_presubmit:
1454 if verbose:
Edward Lemura5799e32020-01-17 19:26:51 +00001455 output_stream.write('Running default presubmit script.\n')
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001456 fake_path = os.path.join(repository_root, 'PRESUBMIT.py')
1457 results = _MergeMasters(results, executer.ExecPresubmitScript(
1458 default_presubmit, fake_path, project, change))
1459 for filename in presubmit_files:
1460 filename = os.path.abspath(filename)
1461 if verbose:
Edward Lemura5799e32020-01-17 19:26:51 +00001462 output_stream.write('Running %s\n' % filename)
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001463 # Accept CRLF presubmit script.
1464 presubmit_script = gclient_utils.FileRead(filename, 'rU')
1465 results = _MergeMasters(results, executer.ExecPresubmitScript(
1466 presubmit_script, filename, project, change))
1467
1468 # Make sets to lists again for later JSON serialization.
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001469 for builders in results.values():
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001470 for builder in builders:
1471 builders[builder] = list(builders[builder])
1472
1473 if results and verbose:
1474 output_stream.write('%s\n' % str(results))
1475 return results
1476
1477
rmistry@google.com5626a922015-02-26 14:03:30 +00001478def DoPostUploadExecuter(change,
Edward Lemur016a0872020-02-04 22:13:28 +00001479 gerrit_obj,
Edward Lemur6eb1d322020-02-27 22:20:15 +00001480 verbose):
rmistry@google.com5626a922015-02-26 14:03:30 +00001481 """Execute the post upload hook.
1482
1483 Args:
1484 change: The Change object.
Edward Lemur016a0872020-02-04 22:13:28 +00001485 gerrit_obj: The GerritAccessor object.
rmistry@google.com5626a922015-02-26 14:03:30 +00001486 verbose: Prints debug info.
rmistry@google.com5626a922015-02-26 14:03:30 +00001487 """
1488 presubmit_files = ListRelevantPresubmitFiles(
Edward Lemur6eb1d322020-02-27 22:20:15 +00001489 change.LocalPaths(), change.RepositoryRoot())
rmistry@google.com5626a922015-02-26 14:03:30 +00001490 if not presubmit_files and verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001491 sys.stdout.write('Warning, no PRESUBMIT.py found.\n')
rmistry@google.com5626a922015-02-26 14:03:30 +00001492 results = []
1493 executer = GetPostUploadExecuter()
1494 # The root presubmit file should be executed after the ones in subdirectories.
1495 # i.e. the specific post upload hooks should run before the general ones.
1496 # Thus, reverse the order provided by ListRelevantPresubmitFiles.
1497 presubmit_files.reverse()
1498
1499 for filename in presubmit_files:
1500 filename = os.path.abspath(filename)
1501 if verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001502 sys.stdout.write('Running %s\n' % filename)
rmistry@google.com5626a922015-02-26 14:03:30 +00001503 # Accept CRLF presubmit script.
1504 presubmit_script = gclient_utils.FileRead(filename, 'rU')
1505 results.extend(executer.ExecPresubmitScript(
Edward Lemur016a0872020-02-04 22:13:28 +00001506 presubmit_script, filename, gerrit_obj, change))
rmistry@google.com5626a922015-02-26 14:03:30 +00001507
Edward Lemur6eb1d322020-02-27 22:20:15 +00001508 if not results:
1509 return 0
1510
1511 sys.stdout.write('\n')
1512 sys.stdout.write('** Post Upload Hook Messages **\n')
1513
1514 exit_code = 0
1515 for result in results:
1516 if result.fatal:
1517 exit_code = 1
1518 result.handle()
1519 sys.stdout.write('\n')
1520
1521 return exit_code
rmistry@google.com5626a922015-02-26 14:03:30 +00001522
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001523class PresubmitExecuter(object):
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001524 def __init__(self, change, committing, verbose, gerrit_obj, dry_run=None,
Edward Lesmeseb1bd622021-03-01 19:54:07 +00001525 thread_pool=None, parallel=False):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001526 """
1527 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001528 change: The Change object.
agable92bec4f2016-08-24 09:27:27 -07001529 committing: True if 'git cl land' is running, False if 'git cl upload' is.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001530 gerrit_obj: provides basic Gerrit codereview functionality.
1531 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -04001532 parallel: if true, all tests reported via input_api.RunTests for all
1533 PRESUBMIT files will be run in parallel.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001534 """
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001535 self.change = change
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001536 self.committing = committing
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001537 self.gerrit = gerrit_obj
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001538 self.verbose = verbose
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001539 self.dry_run = dry_run
Daniel Cheng7227d212017-11-17 08:12:37 -08001540 self.more_cc = []
Edward Lesmes8e282792018-04-03 18:50:29 -04001541 self.thread_pool = thread_pool
1542 self.parallel = parallel
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001543
1544 def ExecPresubmitScript(self, script_text, presubmit_path):
1545 """Executes a single presubmit script.
1546
1547 Args:
1548 script_text: The text of the presubmit script.
1549 presubmit_path: The path to the presubmit file (this will be reported via
1550 input_api.PresubmitLocalPath()).
1551
1552 Return:
1553 A list of result objects, empty if no problems.
1554 """
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001555
chase@chromium.org8e416c82009-10-06 04:30:44 +00001556 # Change to the presubmit file's directory to support local imports.
1557 main_path = os.getcwd()
Saagar Sanghavi98b332f2020-07-31 17:19:15 +00001558 presubmit_dir = os.path.dirname(presubmit_path)
1559 os.chdir(presubmit_dir)
chase@chromium.org8e416c82009-10-06 04:30:44 +00001560
1561 # Load the presubmit script into context.
dpranke@chromium.org970c5222011-03-12 00:32:24 +00001562 input_api = InputApi(self.change, presubmit_path, self.committing,
Aaron Gable668c1d82018-04-03 10:19:16 -07001563 self.verbose, gerrit_obj=self.gerrit,
Edward Lesmes8e282792018-04-03 18:50:29 -04001564 dry_run=self.dry_run, thread_pool=self.thread_pool,
1565 parallel=self.parallel)
Daniel Cheng7227d212017-11-17 08:12:37 -08001566 output_api = OutputApi(self.committing)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001567 context = {}
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001568
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001569 # Try to figure out whether these presubmit checks should be run under
1570 # python2 or python3. We need to do this without actually trying to
1571 # compile the text, since the text might compile in one but not the
1572 # other.
1573 m = re.search('^USE_PYTHON3 = True$', script_text, flags=re.MULTILINE)
1574 use_python3 = m is not None
1575 if (((sys.version_info.major == 2) and use_python3) or
1576 ((sys.version_info.major == 3) and not use_python3)):
1577 return []
1578
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001579 try:
Raul Tambre09e64b42019-05-14 01:57:22 +00001580 exec(compile(script_text, 'PRESUBMIT.py', 'exec', dont_inherit=True),
1581 context)
Raul Tambre7c938462019-05-24 16:35:35 +00001582 except Exception as e:
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001583 raise PresubmitFailure('"%s" had an exception.\n%s' % (presubmit_path, e))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001584
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001585 context['__args'] = (input_api, output_api)
Ben Pastene8351dc12020-08-06 05:01:35 +00001586
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001587 # Get path of presubmit directory relative to repository root.
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001588 # Always use forward slashes, so that path is same in *nix and Windows
1589 root = input_api.change.RepositoryRoot()
1590 rel_path = os.path.relpath(presubmit_dir, root)
1591 rel_path = rel_path.replace(os.path.sep, '/')
Ben Pastene8351dc12020-08-06 05:01:35 +00001592
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001593 # Get the URL of git remote origin and use it to identify host and project
Edward Lesmeseb1bd622021-03-01 19:54:07 +00001594 host = project = ''
1595 if self.gerrit:
1596 host = self.gerrit.host or ''
1597 project = self.gerrit.project or ''
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001598
1599 # Prefix for test names
1600 prefix = 'presubmit:%s/%s:%s/' % (host, project, rel_path)
1601
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001602 # Perform all the desired presubmit checks.
1603 results = []
Ben Pastene8351dc12020-08-06 05:01:35 +00001604
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001605 try:
Scott Leecc2fe9b2020-11-19 19:38:06 +00001606 version = [
1607 int(x) for x in context.get('PRESUBMIT_VERSION', '0.0.0').split('.')
1608 ]
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001609
Scott Leecc2fe9b2020-11-19 19:38:06 +00001610 with rdb_wrapper.client(prefix) as sink:
1611 if version >= [2, 0, 0]:
1612 for function_name in context:
1613 if not function_name.startswith('Check'):
1614 continue
1615 if function_name.endswith('Commit') and not self.committing:
1616 continue
1617 if function_name.endswith('Upload') and self.committing:
1618 continue
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001619 logging.debug('Running %s in %s', function_name, presubmit_path)
1620 results.extend(
Scott Leecc2fe9b2020-11-19 19:38:06 +00001621 self._run_check_function(function_name, context, sink))
1622 logging.debug('Running %s done.', function_name)
1623 self.more_cc.extend(output_api.more_cc)
1624
1625 else: # Old format
1626 if self.committing:
1627 function_name = 'CheckChangeOnCommit'
1628 else:
1629 function_name = 'CheckChangeOnUpload'
1630 if function_name in context:
1631 logging.debug('Running %s in %s', function_name, presubmit_path)
1632 results.extend(
1633 self._run_check_function(function_name, context, sink))
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001634 logging.debug('Running %s done.', function_name)
1635 self.more_cc.extend(output_api.more_cc)
1636
1637 finally:
1638 for f in input_api._named_temporary_files:
1639 os.remove(f)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001640
chase@chromium.org8e416c82009-10-06 04:30:44 +00001641 # Return the process to the original working directory.
1642 os.chdir(main_path)
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001643 return results
1644
Scott Leecc2fe9b2020-11-19 19:38:06 +00001645 def _run_check_function(self, function_name, context, sink=None):
1646 """Evaluates and returns the result of a given presubmit function.
1647
1648 If sink is given, the result of the presubmit function will be reported
1649 to the ResultSink.
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001650
1651 Args:
Scott Leecc2fe9b2020-11-19 19:38:06 +00001652 function_name: the name of the presubmit function to evaluate
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001653 context: a context dictionary in which the function will be evaluated
Scott Leecc2fe9b2020-11-19 19:38:06 +00001654 sink: an instance of ResultSink. None, by default.
1655 Returns:
1656 the result of the presubmit function call.
1657 """
1658 start_time = time_time()
1659 try:
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001660 result = eval(function_name + '(*__args)', context)
1661 self._check_result_type(result)
Gavin Mak554187a2021-03-31 20:34:42 +00001662 except Exception as e:
Scott Leecc2fe9b2020-11-19 19:38:06 +00001663 if sink:
1664 elapsed_time = time_time() - start_time
1665 sink.report(function_name, rdb_wrapper.STATUS_FAIL, elapsed_time)
Allen Webbb65bbfe2021-05-11 21:22:01 +00001666 # TODO(crbug.com/953884): replace raise_from with native py3:
1667 # raise .. from e
1668 try:
1669 from future.utils import raise_from
1670 raise_from(type(e)('Evaluation of %s failed: %s' % (function_name, e)),
1671 e)
1672 except ImportError:
1673 if self.verbose:
1674 traceback.print_exc()
1675 raise type(e)('Evaluation of %s failed: %s' % (function_name, e))
Scott Leecc2fe9b2020-11-19 19:38:06 +00001676
1677 if sink:
1678 elapsed_time = time_time() - start_time
1679 status = rdb_wrapper.STATUS_PASS
1680 if any(r.fatal for r in result):
1681 status = rdb_wrapper.STATUS_FAIL
1682 sink.report(function_name, status, elapsed_time)
1683
1684 return result
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001685
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00001686 def _check_result_type(self, result):
1687 """Helper function which ensures result is a list, and all elements are
1688 instances of OutputApi.PresubmitResult"""
1689 if not isinstance(result, (tuple, list)):
1690 raise PresubmitFailure('Presubmit functions must return a tuple or list')
1691 if not all(isinstance(res, OutputApi.PresubmitResult) for res in result):
1692 raise PresubmitFailure(
1693 'All presubmit results must be of types derived from '
1694 'output_api.PresubmitResult')
1695
1696
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001697def DoPresubmitChecks(change,
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001698 committing,
1699 verbose,
maruel@chromium.orgb0dfd352009-06-10 14:12:54 +00001700 default_presubmit,
dpranke@chromium.org970c5222011-03-12 00:32:24 +00001701 may_prompt,
Aaron Gable668c1d82018-04-03 10:19:16 -07001702 gerrit_obj,
Edward Lesmes8e282792018-04-03 18:50:29 -04001703 dry_run=None,
Debrian Figueroadd2737e2019-06-21 23:50:13 +00001704 parallel=False,
Edward Lesmeseb1bd622021-03-01 19:54:07 +00001705 json_output=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001706 """Runs all presubmit checks that apply to the files in the change.
1707
1708 This finds all PRESUBMIT.py files in directories enclosing the files in the
1709 change (up to the repository root) and calls the relevant entrypoint function
1710 depending on whether the change is being committed or uploaded.
1711
1712 Prints errors, warnings and notifications. Prompts the user for warnings
1713 when needed.
1714
1715 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001716 change: The Change object.
agable92bec4f2016-08-24 09:27:27 -07001717 committing: True if 'git cl land' is running, False if 'git cl upload' is.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001718 verbose: Prints debug info.
maruel@chromium.org0ff1fab2009-05-22 13:08:15 +00001719 default_presubmit: A default presubmit script to execute in any case.
Quinten Yearsley516fe7f2016-12-14 11:50:18 -08001720 may_prompt: Enable (y/n) questions on warning or error. If False,
1721 any questions are answered with yes by default.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001722 gerrit_obj: provides basic Gerrit codereview functionality.
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001723 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -04001724 parallel: if true, all tests specified by input_api.RunTests in all
1725 PRESUBMIT files will be run in parallel.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001726
1727 Return:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001728 1 if presubmit checks failed or 0 otherwise.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001729 """
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001730 old_environ = os.environ
1731 try:
1732 # Make sure python subprocesses won't generate .pyc files.
1733 os.environ = os.environ.copy()
Edward Lemurb9830242019-10-30 22:19:20 +00001734 os.environ['PYTHONDONTWRITEBYTECODE'] = '1'
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001735
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001736 python_version = 'Python %s' % sys.version_info.major
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001737 if committing:
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001738 sys.stdout.write('Running %s presubmit commit checks ...\n' %
1739 python_version)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001740 else:
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001741 sys.stdout.write('Running %s presubmit upload checks ...\n' %
1742 python_version)
Edward Lemurecc27072020-01-06 16:42:34 +00001743 start_time = time_time()
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001744 presubmit_files = ListRelevantPresubmitFiles(
agable0b65e732016-11-22 09:25:46 -08001745 change.AbsoluteLocalPaths(), change.RepositoryRoot())
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001746 if not presubmit_files and verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001747 sys.stdout.write('Warning, no PRESUBMIT.py found.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001748 results = []
Edward Lesmes8e282792018-04-03 18:50:29 -04001749 thread_pool = ThreadPool()
Edward Lemur7e3c67f2018-07-20 20:52:49 +00001750 executer = PresubmitExecuter(change, committing, verbose, gerrit_obj,
Edward Lesmeseb1bd622021-03-01 19:54:07 +00001751 dry_run, thread_pool, parallel)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001752 if default_presubmit:
1753 if verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001754 sys.stdout.write('Running default presubmit script.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001755 fake_path = os.path.join(change.RepositoryRoot(), 'PRESUBMIT.py')
1756 results += executer.ExecPresubmitScript(default_presubmit, fake_path)
1757 for filename in presubmit_files:
1758 filename = os.path.abspath(filename)
1759 if verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001760 sys.stdout.write('Running %s\n' % filename)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001761 # Accept CRLF presubmit script.
1762 presubmit_script = gclient_utils.FileRead(filename, 'rU')
1763 results += executer.ExecPresubmitScript(presubmit_script, filename)
Edward Lesmes8e282792018-04-03 18:50:29 -04001764 results += thread_pool.RunAsync()
1765
Edward Lemur6eb1d322020-02-27 22:20:15 +00001766 messages = {}
1767 should_prompt = False
1768 presubmits_failed = False
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001769 for result in results:
1770 if result.fatal:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001771 presubmits_failed = True
1772 messages.setdefault('ERRORS', []).append(result)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001773 elif result.should_prompt:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001774 should_prompt = True
1775 messages.setdefault('Warnings', []).append(result)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001776 else:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001777 messages.setdefault('Messages', []).append(result)
pam@chromium.orged9a0832009-09-09 22:48:55 +00001778
Edward Lemur6eb1d322020-02-27 22:20:15 +00001779 sys.stdout.write('\n')
1780 for name, items in messages.items():
1781 sys.stdout.write('** Presubmit %s **\n' % name)
1782 for item in items:
1783 item.handle()
1784 sys.stdout.write('\n')
pam@chromium.orged9a0832009-09-09 22:48:55 +00001785
Edward Lemurecc27072020-01-06 16:42:34 +00001786 total_time = time_time() - start_time
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001787 if total_time > 1.0:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001788 sys.stdout.write(
1789 'Presubmit checks took %.1fs to calculate.\n\n' % total_time)
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +00001790
Edward Lemur6eb1d322020-02-27 22:20:15 +00001791 if not should_prompt and not presubmits_failed:
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001792 sys.stdout.write('%s presubmit checks passed.\n' % python_version)
Edward Lemur6eb1d322020-02-27 22:20:15 +00001793 elif should_prompt:
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001794 sys.stdout.write('There were %s presubmit warnings. ' % python_version)
Quinten Yearsley516fe7f2016-12-14 11:50:18 -08001795 if may_prompt:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001796 presubmits_failed = not prompt_should_continue(
1797 'Are you sure you wish to continue? (y/N): ')
Garrett Beatyacb807e2020-08-28 18:17:24 +00001798 else:
1799 sys.stdout.write('\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001800
Edward Lemur1dc66e12020-02-21 21:36:34 +00001801 if json_output:
1802 # Write the presubmit results to json output
1803 presubmit_results = {
1804 'errors': [
Edward Lemur6eb1d322020-02-27 22:20:15 +00001805 error.json_format()
1806 for error in messages.get('ERRORS', [])
Edward Lemur1dc66e12020-02-21 21:36:34 +00001807 ],
1808 'notifications': [
Edward Lemur6eb1d322020-02-27 22:20:15 +00001809 notification.json_format()
1810 for notification in messages.get('Messages', [])
Edward Lemur1dc66e12020-02-21 21:36:34 +00001811 ],
1812 'warnings': [
Edward Lemur6eb1d322020-02-27 22:20:15 +00001813 warning.json_format()
1814 for warning in messages.get('Warnings', [])
Edward Lemur1dc66e12020-02-21 21:36:34 +00001815 ],
Edward Lemur6eb1d322020-02-27 22:20:15 +00001816 'more_cc': executer.more_cc,
Edward Lemur1dc66e12020-02-21 21:36:34 +00001817 }
1818
1819 gclient_utils.FileWrite(
1820 json_output, json.dumps(presubmit_results, sort_keys=True))
1821
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001822 global _ASKED_FOR_FEEDBACK
1823 # Ask for feedback one time out of 5.
1824 if (len(results) and random.randint(0, 4) == 0 and not _ASKED_FOR_FEEDBACK):
Edward Lemur6eb1d322020-02-27 22:20:15 +00001825 sys.stdout.write(
maruel@chromium.org1ce8e662014-01-14 15:23:00 +00001826 'Was the presubmit check useful? If not, run "git cl presubmit -v"\n'
1827 'to figure out which PRESUBMIT.py was run, then run git blame\n'
1828 'on the file to figure out who to ask for help.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001829 _ASKED_FOR_FEEDBACK = True
Edward Lemur6eb1d322020-02-27 22:20:15 +00001830
1831 return 1 if presubmits_failed else 0
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001832 finally:
1833 os.environ = old_environ
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001834
1835
Edward Lemur50984a62020-02-06 18:10:18 +00001836def _scan_sub_dirs(mask, recursive):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001837 if not recursive:
pgervais@chromium.orge57b09d2014-05-07 00:58:13 +00001838 return [x for x in glob.glob(mask) if x not in ('.svn', '.git')]
Lei Zhang9611c4c2017-04-04 01:41:56 -07001839
1840 results = []
1841 for root, dirs, files in os.walk('.'):
1842 if '.svn' in dirs:
1843 dirs.remove('.svn')
1844 if '.git' in dirs:
1845 dirs.remove('.git')
1846 for name in files:
1847 if fnmatch.fnmatch(name, mask):
1848 results.append(os.path.join(root, name))
1849 return results
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001850
1851
Edward Lemur50984a62020-02-06 18:10:18 +00001852def _parse_files(args, recursive):
tobiasjs2836bcf2016-08-16 04:08:16 -07001853 logging.debug('Searching for %s', args)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001854 files = []
1855 for arg in args:
Edward Lemur50984a62020-02-06 18:10:18 +00001856 files.extend([('M', f) for f in _scan_sub_dirs(arg, recursive)])
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001857 return files
1858
1859
Edward Lemur50984a62020-02-06 18:10:18 +00001860def _parse_change(parser, options):
1861 """Process change options.
1862
1863 Args:
1864 parser: The parser used to parse the arguments from command line.
1865 options: The arguments parsed from command line.
1866 Returns:
1867 A GitChange if the change root is a git repository, or a Change otherwise.
1868 """
1869 if options.files and options.all_files:
1870 parser.error('<files> cannot be specified when --all-files is set.')
1871
Edward Lesmes44ea3ff2020-02-05 00:14:30 +00001872 change_scm = scm.determine_scm(options.root)
Edward Lemur50984a62020-02-06 18:10:18 +00001873 if change_scm != 'git' and not options.files:
1874 parser.error('<files> is not optional for unversioned directories.')
1875
1876 if options.files:
1877 change_files = _parse_files(options.files, options.recursive)
1878 elif options.all_files:
1879 change_files = [('M', f) for f in scm.GIT.GetAllFiles(options.root)]
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001880 else:
Edward Lemur50984a62020-02-06 18:10:18 +00001881 change_files = scm.GIT.CaptureStatus(
Edward Lemur7f6dec02020-02-06 20:23:58 +00001882 options.root, options.upstream or None)
Edward Lemur50984a62020-02-06 18:10:18 +00001883
1884 logging.info('Found %d file(s).', len(change_files))
1885
1886 change_class = GitChange if change_scm == 'git' else Change
1887 return change_class(
1888 options.name,
1889 options.description,
1890 options.root,
1891 change_files,
1892 options.issue,
1893 options.patchset,
1894 options.author,
1895 upstream=options.upstream)
1896
1897
1898def _parse_gerrit_options(parser, options):
1899 """Process gerrit options.
1900
1901 SIDE EFFECTS: Modifies options.author and options.description from Gerrit if
1902 options.gerrit_fetch is set.
1903
1904 Args:
1905 parser: The parser used to parse the arguments from command line.
1906 options: The arguments parsed from command line.
1907 Returns:
Stephen Martinisfb09de22021-02-25 03:41:13 +00001908 A GerritAccessor object if options.gerrit_url is set, or None otherwise.
Edward Lemur50984a62020-02-06 18:10:18 +00001909 """
1910 gerrit_obj = None
Stephen Martinisfb09de22021-02-25 03:41:13 +00001911 if options.gerrit_url:
Edward Lesmeseb1bd622021-03-01 19:54:07 +00001912 gerrit_obj = GerritAccessor(
1913 url=options.gerrit_url,
1914 project=options.gerrit_project,
1915 branch=options.gerrit_branch)
Edward Lemur50984a62020-02-06 18:10:18 +00001916
1917 if not options.gerrit_fetch:
1918 return gerrit_obj
1919
1920 if not options.gerrit_url or not options.issue or not options.patchset:
1921 parser.error(
1922 '--gerrit_fetch requires --gerrit_url, --issue and --patchset.')
1923
1924 options.author = gerrit_obj.GetChangeOwner(options.issue)
1925 options.description = gerrit_obj.GetChangeDescription(
1926 options.issue, options.patchset)
1927
1928 logging.info('Got author: "%s"', options.author)
1929 logging.info('Got description: """\n%s\n"""', options.description)
1930
1931 return gerrit_obj
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001932
1933
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001934@contextlib.contextmanager
1935def canned_check_filter(method_names):
1936 filtered = {}
1937 try:
1938 for method_name in method_names:
1939 if not hasattr(presubmit_canned_checks, method_name):
Gavin Make6a62332020-12-04 21:57:10 +00001940 logging.warning('Skipping unknown "canned" check %s' % method_name)
Aaron Gableecee74c2018-04-02 15:13:08 -07001941 continue
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001942 filtered[method_name] = getattr(presubmit_canned_checks, method_name)
1943 setattr(presubmit_canned_checks, method_name, lambda *_a, **_kw: [])
1944 yield
1945 finally:
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001946 for name, method in filtered.items():
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001947 setattr(presubmit_canned_checks, name, method)
1948
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +00001949
sbc@chromium.org013731e2015-02-26 18:28:43 +00001950def main(argv=None):
Edward Lemura5799e32020-01-17 19:26:51 +00001951 parser = argparse.ArgumentParser(usage='%(prog)s [options] <files...>')
1952 hooks = parser.add_mutually_exclusive_group()
1953 hooks.add_argument('-c', '--commit', action='store_true',
1954 help='Use commit instead of upload checks.')
1955 hooks.add_argument('-u', '--upload', action='store_false', dest='commit',
1956 help='Use upload instead of commit checks.')
Edward Lemur75526302020-02-27 22:31:05 +00001957 hooks.add_argument('--post_upload', action='store_true',
1958 help='Run post-upload commit hooks.')
Edward Lemura5799e32020-01-17 19:26:51 +00001959 parser.add_argument('-r', '--recursive', action='store_true',
1960 help='Act recursively.')
1961 parser.add_argument('-v', '--verbose', action='count', default=0,
1962 help='Use 2 times for more debug info.')
1963 parser.add_argument('--name', default='no name')
1964 parser.add_argument('--author')
Edward Lemur227d5102020-02-25 23:45:35 +00001965 desc = parser.add_mutually_exclusive_group()
1966 desc.add_argument('--description', default='', help='The change description.')
1967 desc.add_argument('--description_file',
1968 help='File to read change description from.')
Edward Lemura5799e32020-01-17 19:26:51 +00001969 parser.add_argument('--issue', type=int, default=0)
1970 parser.add_argument('--patchset', type=int, default=0)
1971 parser.add_argument('--root', default=os.getcwd(),
1972 help='Search for PRESUBMIT.py up to this directory. '
1973 'If inherit-review-settings-ok is present in this '
1974 'directory, parent directories up to the root file '
1975 'system directories will also be searched.')
1976 parser.add_argument('--upstream',
1977 help='Git only: the base ref or upstream branch against '
1978 'which the diff should be computed.')
1979 parser.add_argument('--default_presubmit')
1980 parser.add_argument('--may_prompt', action='store_true', default=False)
1981 parser.add_argument('--skip_canned', action='append', default=[],
1982 help='A list of checks to skip which appear in '
1983 'presubmit_canned_checks. Can be provided multiple times '
1984 'to skip multiple canned checks.')
1985 parser.add_argument('--dry_run', action='store_true', help=argparse.SUPPRESS)
1986 parser.add_argument('--gerrit_url', help=argparse.SUPPRESS)
Edward Lesmeseb1bd622021-03-01 19:54:07 +00001987 parser.add_argument('--gerrit_project', help=argparse.SUPPRESS)
1988 parser.add_argument('--gerrit_branch', help=argparse.SUPPRESS)
Edward Lemura5799e32020-01-17 19:26:51 +00001989 parser.add_argument('--gerrit_fetch', action='store_true',
1990 help=argparse.SUPPRESS)
1991 parser.add_argument('--parallel', action='store_true',
1992 help='Run all tests specified by input_api.RunTests in '
1993 'all PRESUBMIT files in parallel.')
1994 parser.add_argument('--json_output',
1995 help='Write presubmit errors to json output.')
Edward Lemur1dc66e12020-02-21 21:36:34 +00001996 parser.add_argument('--all_files', action='store_true',
Edward Lemur50984a62020-02-06 18:10:18 +00001997 help='Mark all files under source control as modified.')
Edward Lemura5799e32020-01-17 19:26:51 +00001998 parser.add_argument('files', nargs='*',
1999 help='List of files to be marked as modified when '
2000 'executing presubmit or post-upload hooks. fnmatch '
2001 'wildcards can also be used.')
Edward Lemura5799e32020-01-17 19:26:51 +00002002 options = parser.parse_args(argv)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00002003
Erik Staabcca5c492020-04-16 17:40:07 +00002004 log_level = logging.ERROR
maruel@chromium.org899e1c12011-04-07 17:03:18 +00002005 if options.verbose >= 2:
Erik Staabcca5c492020-04-16 17:40:07 +00002006 log_level = logging.DEBUG
maruel@chromium.org899e1c12011-04-07 17:03:18 +00002007 elif options.verbose:
Erik Staabcca5c492020-04-16 17:40:07 +00002008 log_level = logging.INFO
2009 log_format = ('[%(levelname).1s%(asctime)s %(process)d %(thread)d '
2010 '%(filename)s] %(message)s')
2011 logging.basicConfig(format=log_format, level=log_level)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00002012
Edward Lemur227d5102020-02-25 23:45:35 +00002013 if options.description_file:
2014 options.description = gclient_utils.FileRead(options.description_file)
Edward Lemur50984a62020-02-06 18:10:18 +00002015 gerrit_obj = _parse_gerrit_options(parser, options)
2016 change = _parse_change(parser, options)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00002017
maruel@chromium.org899e1c12011-04-07 17:03:18 +00002018 try:
Edward Lemur75526302020-02-27 22:31:05 +00002019 if options.post_upload:
2020 return DoPostUploadExecuter(
2021 change,
2022 gerrit_obj,
2023 options.verbose)
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00002024 with canned_check_filter(options.skip_canned):
Edward Lemur6eb1d322020-02-27 22:20:15 +00002025 return DoPresubmitChecks(
Edward Lemur50984a62020-02-06 18:10:18 +00002026 change,
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00002027 options.commit,
2028 options.verbose,
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00002029 options.default_presubmit,
2030 options.may_prompt,
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00002031 gerrit_obj,
Edward Lesmes8e282792018-04-03 18:50:29 -04002032 options.dry_run,
Debrian Figueroadd2737e2019-06-21 23:50:13 +00002033 options.parallel,
Edward Lesmeseb1bd622021-03-01 19:54:07 +00002034 options.json_output)
Raul Tambre7c938462019-05-24 16:35:35 +00002035 except PresubmitFailure as e:
Raul Tambre80ee78e2019-05-06 22:41:05 +00002036 print(e, file=sys.stderr)
2037 print('Maybe your depot_tools is out of date?', file=sys.stderr)
maruel@chromium.org899e1c12011-04-07 17:03:18 +00002038 return 2
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00002039
2040
2041if __name__ == '__main__':
maruel@chromium.org35625c72011-03-23 17:34:02 +00002042 fix_encoding.fix_encoding()
sbc@chromium.org013731e2015-02-26 18:28:43 +00002043 try:
2044 sys.exit(main())
2045 except KeyboardInterrupt:
2046 sys.stderr.write('interrupted\n')
sergiybf8a3b382016-07-05 11:21:30 -07002047 sys.exit(2)