blob: 0d19a1cbdf04c2664995f224f98fb04347af11db [file] [log] [blame]
Josip Sokcevic4de5dea2022-03-23 21:15:14 +00001#!/usr/bin/env python3
maruel@chromium.org3bbf2942012-01-10 16:52:06 +00002# Copyright (c) 2012 The Chromium Authors. All rights reserved.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00003# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5
6"""Enables directory-specific presubmit checks to run at upload and/or commit.
7"""
8
Raul Tambre80ee78e2019-05-06 22:41:05 +00009from __future__ import print_function
10
Saagar Sanghavi99816902020-08-11 22:41:25 +000011__version__ = '2.0.0'
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000012
13# TODO(joi) Add caching where appropriate/needed. The API is designed to allow
14# caching (between all different invocations of presubmit scripts for a given
15# change). We should add it as our presubmit scripts start feeling slow.
16
Edward Lemura5799e32020-01-17 19:26:51 +000017import argparse
Takeshi Yoshino07a6bea2017-08-02 02:44:06 +090018import ast # Exposed through the API.
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +000019import contextlib
Yoshisato Yanagisawa406de132018-06-29 05:43:25 +000020import cpplint
dcheng091b7db2016-06-16 01:27:51 -070021import fnmatch # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000022import glob
asvitkine@chromium.org15169952011-09-27 14:30:53 +000023import inspect
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +000024import itertools
maruel@chromium.org4f6852c2012-04-20 20:39:20 +000025import json # Exposed through the API.
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +000026import logging
ilevy@chromium.orgbc117312013-04-20 03:57:56 +000027import multiprocessing
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000028import os # Somewhat exposed through the API.
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +000029import random
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000030import re # Exposed through the API.
Edward Lesmes8e282792018-04-03 18:50:29 -040031import signal
Allen Webbfe7d7092021-05-18 02:05:49 +000032import six
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000033import sys # Parts exposed through API.
34import tempfile # Exposed through the API.
Edward Lesmes8e282792018-04-03 18:50:29 -040035import threading
jam@chromium.org2a891dc2009-08-20 20:33:37 +000036import time
Edward Lemurde9e3ca2019-10-24 21:13:31 +000037import traceback
maruel@chromium.org1487d532009-06-06 00:22:57 +000038import unittest # Exposed through the API.
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +000039from warnings import warn
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000040
41# Local imports.
maruel@chromium.org35625c72011-03-23 17:34:02 +000042import fix_encoding
Yoshisato Yanagisawa04600b42019-03-15 03:03:41 +000043import gclient_paths # Exposed through the API
44import gclient_utils
Josip Sokcevic7958e302023-03-01 23:02:21 +000045import git_footers
tandrii@chromium.org015ebae2016-04-25 19:37:22 +000046import gerrit_util
Edward Lesmes9ce03f82021-01-12 20:13:31 +000047import owners_client
Jochen Eisinger76f5fc62017-04-07 16:27:46 +020048import owners_finder
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000049import presubmit_canned_checks
Saagar Sanghavi9949ab72020-07-20 20:56:40 +000050import rdb_wrapper
Josip Sokcevic7958e302023-03-01 23:02:21 +000051import scm
maruel@chromium.org84f4fe32011-04-06 13:26:45 +000052import subprocess2 as subprocess # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000053
Edward Lemur16af3562019-10-17 22:11:33 +000054if sys.version_info.major == 2:
55 # TODO(1009814): Expose urllib2 only through urllib_request and urllib_error
56 import urllib2 # Exposed through the API.
57 import urlparse
58 import urllib2 as urllib_request
59 import urllib2 as urllib_error
60else:
61 import urllib.parse as urlparse
62 import urllib.request as urllib_request
63 import urllib.error as urllib_error
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000064
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +000065# Ask for feedback only once in program lifetime.
66_ASKED_FOR_FEEDBACK = False
67
Bruce Dawsondca14bc2022-09-15 20:59:38 +000068# Set if super-verbose mode is requested, for tracking where presubmit messages
69# are coming from.
70_SHOW_CALLSTACKS = False
71
72
Edward Lemurecc27072020-01-06 16:42:34 +000073def time_time():
74 # Use this so that it can be mocked in tests without interfering with python
75 # system machinery.
76 return time.time()
77
78
maruel@chromium.org899e1c12011-04-07 17:03:18 +000079class PresubmitFailure(Exception):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000080 pass
81
82
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000083class CommandData(object):
Edward Lemur940c2822019-08-23 00:34:25 +000084 def __init__(self, name, cmd, kwargs, message, python3=False):
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000085 self.name = name
86 self.cmd = cmd
Edward Lesmes8e282792018-04-03 18:50:29 -040087 self.stdin = kwargs.get('stdin', None)
Edward Lemur2d6b67c2019-08-23 22:25:41 +000088 self.kwargs = kwargs.copy()
Edward Lesmes8e282792018-04-03 18:50:29 -040089 self.kwargs['stdout'] = subprocess.PIPE
90 self.kwargs['stderr'] = subprocess.STDOUT
91 self.kwargs['stdin'] = subprocess.PIPE
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000092 self.message = message
93 self.info = None
Edward Lemur940c2822019-08-23 00:34:25 +000094 self.python3 = python3
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000095
ilevy@chromium.orgbc117312013-04-20 03:57:56 +000096
Edward Lesmes8e282792018-04-03 18:50:29 -040097# Adapted from
98# https://github.com/google/gtest-parallel/blob/master/gtest_parallel.py#L37
99#
100# An object that catches SIGINT sent to the Python process and notices
101# if processes passed to wait() die by SIGINT (we need to look for
102# both of those cases, because pressing Ctrl+C can result in either
103# the main process or one of the subprocesses getting the signal).
104#
105# Before a SIGINT is seen, wait(p) will simply call p.wait() and
106# return the result. Once a SIGINT has been seen (in the main process
107# or a subprocess, including the one the current call is waiting for),
Edward Lemur9a5bb612019-09-26 02:01:52 +0000108# wait(p) will call p.terminate().
Edward Lesmes8e282792018-04-03 18:50:29 -0400109class SigintHandler(object):
Edward Lesmes8e282792018-04-03 18:50:29 -0400110 sigint_returncodes = {-signal.SIGINT, # Unix
111 -1073741510, # Windows
112 }
113 def __init__(self):
114 self.__lock = threading.Lock()
115 self.__processes = set()
116 self.__got_sigint = False
Edward Lemur9a5bb612019-09-26 02:01:52 +0000117 self.__previous_signal = signal.signal(signal.SIGINT, self.interrupt)
Edward Lesmes8e282792018-04-03 18:50:29 -0400118
119 def __on_sigint(self):
120 self.__got_sigint = True
121 while self.__processes:
122 try:
123 self.__processes.pop().terminate()
124 except OSError:
125 pass
126
Edward Lemur9a5bb612019-09-26 02:01:52 +0000127 def interrupt(self, signal_num, frame):
Edward Lesmes8e282792018-04-03 18:50:29 -0400128 with self.__lock:
129 self.__on_sigint()
Edward Lemur9a5bb612019-09-26 02:01:52 +0000130 self.__previous_signal(signal_num, frame)
Edward Lesmes8e282792018-04-03 18:50:29 -0400131
132 def got_sigint(self):
133 with self.__lock:
134 return self.__got_sigint
135
136 def wait(self, p, stdin):
137 with self.__lock:
138 if self.__got_sigint:
139 p.terminate()
140 self.__processes.add(p)
141 stdout, stderr = p.communicate(stdin)
142 code = p.returncode
143 with self.__lock:
144 self.__processes.discard(p)
145 if code in self.sigint_returncodes:
146 self.__on_sigint()
Edward Lesmes8e282792018-04-03 18:50:29 -0400147 return stdout, stderr
148
149sigint_handler = SigintHandler()
150
151
Edward Lemurecc27072020-01-06 16:42:34 +0000152class Timer(object):
153 def __init__(self, timeout, fn):
154 self.completed = False
155 self._fn = fn
156 self._timer = threading.Timer(timeout, self._onTimer) if timeout else None
157
158 def __enter__(self):
159 if self._timer:
160 self._timer.start()
161 return self
162
163 def __exit__(self, _type, _value, _traceback):
164 if self._timer:
165 self._timer.cancel()
166
167 def _onTimer(self):
168 self._fn()
169 self.completed = True
170
171
Edward Lesmes8e282792018-04-03 18:50:29 -0400172class ThreadPool(object):
Edward Lemurecc27072020-01-06 16:42:34 +0000173 def __init__(self, pool_size=None, timeout=None):
174 self.timeout = timeout
Edward Lesmes8e282792018-04-03 18:50:29 -0400175 self._pool_size = pool_size or multiprocessing.cpu_count()
Bruce Dawson8254f062022-06-17 17:33:08 +0000176 if sys.platform == 'win32':
177 # TODO(crbug.com/1190269) - we can't use more than 56 child processes on
178 # Windows or Python3 may hang.
179 self._pool_size = min(self._pool_size, 56)
Edward Lesmes8e282792018-04-03 18:50:29 -0400180 self._messages = []
181 self._messages_lock = threading.Lock()
182 self._tests = []
183 self._tests_lock = threading.Lock()
184 self._nonparallel_tests = []
185
Edward Lemurecc27072020-01-06 16:42:34 +0000186 def _GetCommand(self, test):
Edward Lemur940c2822019-08-23 00:34:25 +0000187 vpython = 'vpython'
188 if test.python3:
189 vpython += '3'
190 if sys.platform == 'win32':
191 vpython += '.bat'
Edward Lesmes8e282792018-04-03 18:50:29 -0400192
193 cmd = test.cmd
194 if cmd[0] == 'python':
195 cmd = list(cmd)
196 cmd[0] = vpython
197 elif cmd[0].endswith('.py'):
198 cmd = [vpython] + cmd
199
Edward Lemur336e51f2019-11-14 21:42:04 +0000200 # On Windows, scripts on the current directory take precedence over PATH, so
201 # that when testing depot_tools on Windows, calling `vpython.bat` will
202 # execute the copy of vpython of the depot_tools under test instead of the
203 # one in the bot.
204 # As a workaround, we run the tests from the parent directory instead.
205 if (cmd[0] == vpython and
206 'cwd' in test.kwargs and
207 os.path.basename(test.kwargs['cwd']) == 'depot_tools'):
208 test.kwargs['cwd'] = os.path.dirname(test.kwargs['cwd'])
209 cmd[1] = os.path.join('depot_tools', cmd[1])
210
Edward Lemurecc27072020-01-06 16:42:34 +0000211 return cmd
212
213 def _RunWithTimeout(self, cmd, stdin, kwargs):
214 p = subprocess.Popen(cmd, **kwargs)
215 with Timer(self.timeout, p.terminate) as timer:
216 stdout, _ = sigint_handler.wait(p, stdin)
Josip Sokcevic6635baf2021-11-19 02:04:39 +0000217 stdout = stdout.decode('utf-8', 'ignore')
Edward Lemurecc27072020-01-06 16:42:34 +0000218 if timer.completed:
219 stdout = 'Process timed out after %ss\n%s' % (self.timeout, stdout)
Josip Sokcevic6635baf2021-11-19 02:04:39 +0000220 return p.returncode, stdout
Edward Lemurecc27072020-01-06 16:42:34 +0000221
222 def CallCommand(self, test):
223 """Runs an external program.
224
Edward Lemura5799e32020-01-17 19:26:51 +0000225 This function converts invocation of .py files and invocations of 'python'
Edward Lemurecc27072020-01-06 16:42:34 +0000226 to vpython invocations.
227 """
228 cmd = self._GetCommand(test)
Edward Lesmes8e282792018-04-03 18:50:29 -0400229 try:
Edward Lemurecc27072020-01-06 16:42:34 +0000230 start = time_time()
231 returncode, stdout = self._RunWithTimeout(cmd, test.stdin, test.kwargs)
232 duration = time_time() - start
Edward Lemur7cf94382019-11-15 22:36:41 +0000233 except Exception:
Edward Lemurecc27072020-01-06 16:42:34 +0000234 duration = time_time() - start
Edward Lesmes8e282792018-04-03 18:50:29 -0400235 return test.message(
Edward Lemur7cf94382019-11-15 22:36:41 +0000236 '%s\n%s exec failure (%4.2fs)\n%s' % (
237 test.name, ' '.join(cmd), duration, traceback.format_exc()))
Edward Lemurde9e3ca2019-10-24 21:13:31 +0000238
Edward Lemurecc27072020-01-06 16:42:34 +0000239 if returncode != 0:
Edward Lesmes8e282792018-04-03 18:50:29 -0400240 return test.message(
Edward Lemur7cf94382019-11-15 22:36:41 +0000241 '%s\n%s (%4.2fs) failed\n%s' % (
242 test.name, ' '.join(cmd), duration, stdout))
Edward Lemurecc27072020-01-06 16:42:34 +0000243
Edward Lesmes8e282792018-04-03 18:50:29 -0400244 if test.info:
Edward Lemur7cf94382019-11-15 22:36:41 +0000245 return test.info('%s\n%s (%4.2fs)' % (test.name, ' '.join(cmd), duration))
Edward Lesmes8e282792018-04-03 18:50:29 -0400246
247 def AddTests(self, tests, parallel=True):
248 if parallel:
249 self._tests.extend(tests)
250 else:
251 self._nonparallel_tests.extend(tests)
252
253 def RunAsync(self):
254 self._messages = []
255
256 def _WorkerFn():
257 while True:
258 test = None
259 with self._tests_lock:
260 if not self._tests:
261 break
262 test = self._tests.pop()
263 result = self.CallCommand(test)
264 if result:
265 with self._messages_lock:
266 self._messages.append(result)
267
268 def _StartDaemon():
269 t = threading.Thread(target=_WorkerFn)
270 t.daemon = True
271 t.start()
272 return t
273
274 while self._nonparallel_tests:
275 test = self._nonparallel_tests.pop()
276 result = self.CallCommand(test)
277 if result:
278 self._messages.append(result)
279
280 if self._tests:
281 threads = [_StartDaemon() for _ in range(self._pool_size)]
282 for worker in threads:
283 worker.join()
284
285 return self._messages
286
287
Josip Sokcevica9a7eec2023-03-10 03:54:52 +0000288def normpath(path):
289 '''Version of os.path.normpath that also changes backward slashes to
290 forward slashes when not running on Windows.
291 '''
292 # This is safe to always do because the Windows version of os.path.normpath
293 # will replace forward slashes with backward slashes.
294 path = path.replace(os.sep, '/')
295 return os.path.normpath(path)
296
297
Josip Sokcevic7958e302023-03-01 23:02:21 +0000298def _RightHandSideLinesImpl(affected_files):
299 """Implements RightHandSideLines for InputApi and GclChange."""
300 for af in affected_files:
301 lines = af.ChangedContents()
302 for line in lines:
303 yield (af, line[0], line[1])
304
305
Edward Lemur6eb1d322020-02-27 22:20:15 +0000306def prompt_should_continue(prompt_string):
307 sys.stdout.write(prompt_string)
Dirk Pranke7288f882021-06-03 18:01:30 +0000308 sys.stdout.flush()
Edward Lemur6eb1d322020-02-27 22:20:15 +0000309 response = sys.stdin.readline().strip().lower()
310 return response in ('y', 'yes')
dpranke@chromium.org5ac21012011-03-16 02:58:25 +0000311
Josip Sokcevic967cf672023-05-10 17:09:58 +0000312
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000313# Top level object so multiprocessing can pickle
314# Public access through OutputApi object.
315class _PresubmitResult(object):
316 """Base class for result objects."""
317 fatal = False
318 should_prompt = False
319
320 def __init__(self, message, items=None, long_text=''):
321 """
322 message: A short one-line message to indicate errors.
323 items: A list of short strings to indicate where errors occurred.
324 long_text: multi-line text output, e.g. from another tool
325 """
Bruce Dawsondb8622b2022-04-03 15:38:12 +0000326 self._message = _PresubmitResult._ensure_str(message)
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000327 self._items = items or []
Tom McKee61c72652021-07-20 11:56:32 +0000328 self._long_text = _PresubmitResult._ensure_str(long_text.rstrip())
Bruce Dawsondca14bc2022-09-15 20:59:38 +0000329 if _SHOW_CALLSTACKS:
330 self._long_text += 'Presubmit result call stack is:\n'
331 self._long_text += ''.join(traceback.format_stack(None, 8))
Tom McKee61c72652021-07-20 11:56:32 +0000332
333 @staticmethod
334 def _ensure_str(val):
335 """
336 val: A "stringish" value. Can be any of str, unicode or bytes.
337 returns: A str after applying encoding/decoding as needed.
338 Assumes/uses UTF-8 for relevant inputs/outputs.
339
340 We'd prefer to use six.ensure_str but our copy of six is old :(
341 """
342 if isinstance(val, str):
343 return val
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +0000344
Tom McKee61c72652021-07-20 11:56:32 +0000345 if six.PY2 and isinstance(val, unicode):
346 return val.encode()
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +0000347
348 if six.PY3 and isinstance(val, bytes):
Tom McKee61c72652021-07-20 11:56:32 +0000349 return val.decode()
350 raise ValueError("Unknown string type %s" % type(val))
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000351
Edward Lemur6eb1d322020-02-27 22:20:15 +0000352 def handle(self):
353 sys.stdout.write(self._message)
354 sys.stdout.write('\n')
Takuto Ikutabaa7be02022-08-23 00:19:34 +0000355 for item in self._items:
Edward Lemur6eb1d322020-02-27 22:20:15 +0000356 sys.stdout.write(' ')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000357 # Write separately in case it's unicode.
Edward Lemur6eb1d322020-02-27 22:20:15 +0000358 sys.stdout.write(str(item))
Edward Lemur6eb1d322020-02-27 22:20:15 +0000359 sys.stdout.write('\n')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000360 if self._long_text:
Edward Lemur6eb1d322020-02-27 22:20:15 +0000361 sys.stdout.write('\n***************\n')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000362 # Write separately in case it's unicode.
Tom McKee61c72652021-07-20 11:56:32 +0000363 sys.stdout.write(self._long_text)
Edward Lemur6eb1d322020-02-27 22:20:15 +0000364 sys.stdout.write('\n***************\n')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000365
Debrian Figueroadd2737e2019-06-21 23:50:13 +0000366 def json_format(self):
367 return {
368 'message': self._message,
Debrian Figueroa6095d402019-06-28 18:47:18 +0000369 'items': [str(item) for item in self._items],
Debrian Figueroadd2737e2019-06-21 23:50:13 +0000370 'long_text': self._long_text,
371 'fatal': self.fatal
372 }
373
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000374
375# Top level object so multiprocessing can pickle
376# Public access through OutputApi object.
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000377class _PresubmitError(_PresubmitResult):
378 """A hard presubmit error."""
379 fatal = True
380
381
382# Top level object so multiprocessing can pickle
383# Public access through OutputApi object.
384class _PresubmitPromptWarning(_PresubmitResult):
385 """An warning that prompts the user if they want to continue."""
386 should_prompt = True
387
388
389# Top level object so multiprocessing can pickle
390# Public access through OutputApi object.
391class _PresubmitNotifyResult(_PresubmitResult):
392 """Just print something to the screen -- but it's not even a warning."""
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000393
394
395# Top level object so multiprocessing can pickle
396# Public access through OutputApi object.
397class _MailTextResult(_PresubmitResult):
398 """A warning that should be included in the review request email."""
399 def __init__(self, *args, **kwargs):
400 super(_MailTextResult, self).__init__()
401 raise NotImplementedError()
402
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000403class GerritAccessor(object):
404 """Limited Gerrit functionality for canned presubmit checks to work.
405
406 To avoid excessive Gerrit calls, caches the results.
407 """
408
Edward Lesmeseb1bd622021-03-01 19:54:07 +0000409 def __init__(self, url=None, project=None, branch=None):
410 self.host = urlparse.urlparse(url).netloc if url else None
411 self.project = project
412 self.branch = branch
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000413 self.cache = {}
Edward Lesmes8170c292021-03-19 20:04:43 +0000414 self.code_owners_enabled = None
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000415
416 def _FetchChangeDetail(self, issue):
417 # Separate function to be easily mocked in tests.
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +0100418 try:
419 return gerrit_util.GetChangeDetail(
420 self.host, str(issue),
Aaron Gable6f5a8d92017-04-18 14:49:05 -0700421 ['ALL_REVISIONS', 'DETAILED_LABELS', 'ALL_COMMITS'])
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +0100422 except gerrit_util.GerritError as e:
423 if e.http_status == 404:
424 raise Exception('Either Gerrit issue %s doesn\'t exist, or '
425 'no credentials to fetch issue details' % issue)
426 raise
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000427
428 def GetChangeInfo(self, issue):
429 """Returns labels and all revisions (patchsets) for this issue.
430
431 The result is a dictionary according to Gerrit REST Api.
432 https://gerrit-review.googlesource.com/Documentation/rest-api.html
433
434 However, API isn't very clear what's inside, so see tests for example.
435 """
436 assert issue
437 cache_key = int(issue)
438 if cache_key not in self.cache:
439 self.cache[cache_key] = self._FetchChangeDetail(issue)
440 return self.cache[cache_key]
441
442 def GetChangeDescription(self, issue, patchset=None):
443 """If patchset is none, fetches current patchset."""
444 info = self.GetChangeInfo(issue)
445 # info is a reference to cache. We'll modify it here adding description to
446 # it to the right patchset, if it is not yet there.
447
448 # Find revision info for the patchset we want.
449 if patchset is not None:
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +0000450 for rev, rev_info in info['revisions'].items():
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000451 if str(rev_info['_number']) == str(patchset):
452 break
453 else:
454 raise Exception('patchset %s doesn\'t exist in issue %s' % (
455 patchset, issue))
456 else:
457 rev = info['current_revision']
458 rev_info = info['revisions'][rev]
459
Andrii Shyshkalov9c3a4642017-01-24 17:41:22 +0100460 return rev_info['commit']['message']
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000461
Mun Yong Jang603d01e2017-12-19 16:38:30 -0800462 def GetDestRef(self, issue):
463 ref = self.GetChangeInfo(issue)['branch']
464 if not ref.startswith('refs/'):
465 # NOTE: it is possible to create 'refs/x' branch,
466 # aka 'refs/heads/refs/x'. However, this is ill-advised.
467 ref = 'refs/heads/%s' % ref
468 return ref
469
Edward Lesmes02d4b822020-11-11 00:37:35 +0000470 def _GetApproversForLabel(self, issue, label):
471 change_info = self.GetChangeInfo(issue)
472 label_info = change_info.get('labels', {}).get(label, {})
473 values = label_info.get('values', {}).keys()
474 if not values:
475 return []
476 max_value = max(int(v) for v in values)
477 return [v for v in label_info.get('all', [])
478 if v.get('value', 0) == max_value]
479
Edward Lesmesc4566172021-03-19 16:55:13 +0000480 def IsBotCommitApproved(self, issue):
481 return bool(self._GetApproversForLabel(issue, 'Bot-Commit'))
482
Edward Lesmescf49cb82020-11-11 01:08:36 +0000483 def IsOwnersOverrideApproved(self, issue):
484 return bool(self._GetApproversForLabel(issue, 'Owners-Override'))
485
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000486 def GetChangeOwner(self, issue):
487 return self.GetChangeInfo(issue)['owner']['email']
488
489 def GetChangeReviewers(self, issue, approving_only=True):
Aaron Gable8b478f02017-07-31 15:33:19 -0700490 changeinfo = self.GetChangeInfo(issue)
491 if approving_only:
Edward Lesmes02d4b822020-11-11 00:37:35 +0000492 reviewers = self._GetApproversForLabel(issue, 'Code-Review')
Aaron Gable8b478f02017-07-31 15:33:19 -0700493 else:
494 reviewers = changeinfo.get('reviewers', {}).get('REVIEWER', [])
495 return [r.get('email') for r in reviewers]
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000496
Edward Lemure4d329c2020-02-03 20:41:18 +0000497 def UpdateDescription(self, description, issue):
498 gerrit_util.SetCommitMessage(self.host, issue, description, notify='NONE')
499
Edward Lesmes8170c292021-03-19 20:04:43 +0000500 def IsCodeOwnersEnabledOnRepo(self):
501 if self.code_owners_enabled is None:
502 self.code_owners_enabled = gerrit_util.IsCodeOwnersEnabledOnRepo(
Edward Lesmes392c4072021-03-19 21:58:45 +0000503 self.host, self.project)
Edward Lesmes8170c292021-03-19 20:04:43 +0000504 return self.code_owners_enabled
505
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000506
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000507class OutputApi(object):
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000508 """An instance of OutputApi gets passed to presubmit scripts so that they
509 can output various types of results.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000510 """
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000511 PresubmitResult = _PresubmitResult
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000512 PresubmitError = _PresubmitError
513 PresubmitPromptWarning = _PresubmitPromptWarning
514 PresubmitNotifyResult = _PresubmitNotifyResult
515 MailTextResult = _MailTextResult
516
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000517 def __init__(self, is_committing):
518 self.is_committing = is_committing
Daniel Cheng7227d212017-11-17 08:12:37 -0800519 self.more_cc = []
520
521 def AppendCC(self, cc):
522 """Appends a user to cc for this change."""
Daniel Cheng0e9f6682022-10-19 17:42:57 +0000523 if cc not in self.more_cc:
524 self.more_cc.append(cc)
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000525
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000526 def PresubmitPromptOrNotify(self, *args, **kwargs):
527 """Warn the user when uploading, but only notify if committing."""
528 if self.is_committing:
529 return self.PresubmitNotifyResult(*args, **kwargs)
530 return self.PresubmitPromptWarning(*args, **kwargs)
531
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000532
533class InputApi(object):
534 """An instance of this object is passed to presubmit scripts so they can
535 know stuff about the change they're looking at.
536 """
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000537 # Method could be a function
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800538 # pylint: disable=no-self-use
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000539
maruel@chromium.org3410d912009-06-09 20:56:16 +0000540 # File extensions that are considered source files from a style guide
541 # perspective. Don't modify this list from a presubmit script!
maruel@chromium.orgc33455a2011-06-24 19:14:18 +0000542 #
543 # Files without an extension aren't included in the list. If you want to
local_bot30f774e2020-06-25 18:23:34 +0000544 # filter them as source files, add r'(^|.*?[\\\/])[^.]+$' to the allow list.
local_bot64021412020-07-08 21:05:39 +0000545 # Note that ALL CAPS files are skipped in DEFAULT_FILES_TO_SKIP below.
546 DEFAULT_FILES_TO_CHECK = (
maruel@chromium.org3410d912009-06-09 20:56:16 +0000547 # C++ and friends
Edward Lemura5799e32020-01-17 19:26:51 +0000548 r'.+\.c$', r'.+\.cc$', r'.+\.cpp$', r'.+\.h$', r'.+\.m$', r'.+\.mm$',
549 r'.+\.inl$', r'.+\.asm$', r'.+\.hxx$', r'.+\.hpp$', r'.+\.s$', r'.+\.S$',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000550 # Scripts
dpapad443d9132022-05-05 00:17:30 +0000551 r'.+\.js$', r'.+\.ts$', r'.+\.py$', r'.+\.sh$', r'.+\.rb$', r'.+\.pl$',
552 r'.+\.pm$',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000553 # Other
Edward Lemura5799e32020-01-17 19:26:51 +0000554 r'.+\.java$', r'.+\.mk$', r'.+\.am$', r'.+\.css$', r'.+\.mojom$',
Bruce Dawson7a81ebf2023-01-03 18:36:18 +0000555 r'.+\.fidl$', r'.+\.rs$',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000556 )
557
558 # Path regexp that should be excluded from being considered containing source
559 # files. Don't modify this list from a presubmit script!
local_bot64021412020-07-08 21:05:39 +0000560 DEFAULT_FILES_TO_SKIP = (
Edward Lemura5799e32020-01-17 19:26:51 +0000561 r'testing_support[\\\/]google_appengine[\\\/].*',
562 r'.*\bexperimental[\\\/].*',
Kent Tamura179dd1e2018-04-26 15:07:41 +0900563 # Exclude third_party/.* but NOT third_party/{WebKit,blink}
564 # (crbug.com/539768 and crbug.com/836555).
Edward Lemura5799e32020-01-17 19:26:51 +0000565 r'.*\bthird_party[\\\/](?!(WebKit|blink)[\\\/]).*',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000566 # Output directories (just in case)
Edward Lemura5799e32020-01-17 19:26:51 +0000567 r'.*\bDebug[\\\/].*',
568 r'.*\bRelease[\\\/].*',
569 r'.*\bxcodebuild[\\\/].*',
570 r'.*\bout[\\\/].*',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000571 # All caps files like README and LICENCE.
Edward Lemura5799e32020-01-17 19:26:51 +0000572 r'.*\b[A-Z0-9_]{2,}$',
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +0000573 # SCM (can happen in dual SCM configuration). (Slightly over aggressive)
Edward Lemura5799e32020-01-17 19:26:51 +0000574 r'(|.*[\\\/])\.git[\\\/].*',
575 r'(|.*[\\\/])\.svn[\\\/].*',
maruel@chromium.org7ccb4bb2011-11-07 20:26:20 +0000576 # There is no point in processing a patch file.
Edward Lemura5799e32020-01-17 19:26:51 +0000577 r'.+\.diff$',
578 r'.+\.patch$',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000579 )
580
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000581 def __init__(self, change, presubmit_path, is_committing,
Bruce Dawson09c0c072022-05-26 20:28:58 +0000582 verbose, gerrit_obj, dry_run=None, thread_pool=None, parallel=False,
583 no_diffs=False):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000584 """Builds an InputApi object.
585
586 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000587 change: A presubmit.Change object.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000588 presubmit_path: The path to the presubmit script being processed.
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000589 is_committing: True if the change is about to be committed.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000590 gerrit_obj: provides basic Gerrit codereview functionality.
591 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -0400592 parallel: if true, all tests reported via input_api.RunTests for all
593 PRESUBMIT files will be run in parallel.
Bruce Dawson09c0c072022-05-26 20:28:58 +0000594 no_diffs: if true, implies that --files or --all was specified so some
595 checks can be skipped, and some errors will be messages.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000596 """
maruel@chromium.org9711bba2009-05-22 23:51:39 +0000597 # Version number of the presubmit_support script.
598 self.version = [int(x) for x in __version__.split('.')]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000599 self.change = change
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000600 self.is_committing = is_committing
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000601 self.gerrit = gerrit_obj
tandrii@chromium.org57bafac2016-04-28 05:09:03 +0000602 self.dry_run = dry_run
Bruce Dawson09c0c072022-05-26 20:28:58 +0000603 self.no_diffs = no_diffs
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000604
Edward Lesmes8e282792018-04-03 18:50:29 -0400605 self.parallel = parallel
606 self.thread_pool = thread_pool or ThreadPool()
607
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000608 # We expose various modules and functions as attributes of the input_api
609 # so that presubmit scripts don't have to import them.
Takeshi Yoshino07a6bea2017-08-02 02:44:06 +0900610 self.ast = ast
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000611 self.basename = os.path.basename
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000612 self.cpplint = cpplint
dcheng091b7db2016-06-16 01:27:51 -0700613 self.fnmatch = fnmatch
Yoshisato Yanagisawa04600b42019-03-15 03:03:41 +0000614 self.gclient_paths = gclient_paths
Yoshisato Yanagisawa57dd17b2019-03-22 09:10:29 +0000615 # TODO(yyanagisawa): stop exposing this when python3 become default.
616 # Since python3's tempfile has TemporaryDirectory, we do not need this.
617 self.temporary_directory = gclient_utils.temporary_directory
dpranke@chromium.org17cc2442012-10-17 21:12:09 +0000618 self.glob = glob.glob
maruel@chromium.orgfb11c7b2010-03-18 18:22:14 +0000619 self.json = json
maruel@chromium.org6fba34d2011-06-02 13:45:12 +0000620 self.logging = logging.getLogger('PRESUBMIT')
maruel@chromium.org2b5ce562011-03-31 16:15:44 +0000621 self.os_listdir = os.listdir
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000622 self.os_path = os.path
pgervais@chromium.orgbd0cace2014-10-02 23:23:46 +0000623 self.os_stat = os.stat
Yoshisato Yanagisawa406de132018-06-29 05:43:25 +0000624 self.os_walk = os.walk
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000625 self.re = re
626 self.subprocess = subprocess
Edward Lemurb9830242019-10-30 22:19:20 +0000627 self.sys = sys
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000628 self.tempfile = tempfile
dpranke@chromium.org0d1bdea2011-03-24 22:54:38 +0000629 self.time = time
maruel@chromium.org1487d532009-06-06 00:22:57 +0000630 self.unittest = unittest
Edward Lemurb9830242019-10-30 22:19:20 +0000631 if sys.version_info.major == 2:
632 self.urllib2 = urllib2
Edward Lemur16af3562019-10-17 22:11:33 +0000633 self.urllib_request = urllib_request
634 self.urllib_error = urllib_error
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000635
Robert Iannucci50258932018-03-19 10:30:59 -0700636 self.is_windows = sys.platform == 'win32'
637
Edward Lemurb9646622019-10-25 20:57:35 +0000638 # Set python_executable to 'vpython' in order to allow scripts in other
639 # repos (e.g. src.git) to automatically pick up that repo's .vpython file,
640 # instead of inheriting the one in depot_tools.
641 self.python_executable = 'vpython'
Erik Staab69135d12021-05-14 22:31:57 +0000642 # Offer a python 3 executable for use during the migration off of python 2.
643 self.python3_executable = 'vpython3'
maruel@chromium.orgc0b22972009-06-25 16:19:14 +0000644 self.environ = os.environ
645
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000646 # InputApi.platform is the platform you're currently running on.
647 self.platform = sys.platform
648
iannucci@chromium.org0af3bb32015-06-12 20:44:35 +0000649 self.cpu_count = multiprocessing.cpu_count()
Bruce Dawson8254f062022-06-17 17:33:08 +0000650 if self.is_windows:
651 # TODO(crbug.com/1190269) - we can't use more than 56 child processes on
652 # Windows or Python3 may hang.
653 self.cpu_count = min(self.cpu_count, 56)
iannucci@chromium.org0af3bb32015-06-12 20:44:35 +0000654
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000655 # The local path of the currently-being-processed presubmit script.
maruel@chromium.org3d235242009-05-15 12:40:48 +0000656 self._current_presubmit_path = os.path.dirname(presubmit_path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000657
658 # We carry the canned checks so presubmit scripts can easily use them.
659 self.canned_checks = presubmit_canned_checks
660
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +0100661 # Temporary files we must manually remove at the end of a run.
662 self._named_temporary_files = []
Jochen Eisinger72606f82017-04-04 10:44:18 +0200663
Edward Lesmesdc11c6b2021-03-19 19:22:05 +0000664 self.owners_client = None
Bruce Dawsoneb8426e2022-08-05 23:58:15 +0000665 if self.gerrit and not 'PRESUBMIT_SKIP_NETWORK' in self.environ:
Bruce Dawson9b9f4512022-04-27 00:56:52 +0000666 try:
667 self.owners_client = owners_client.GetCodeOwnersClient(
Bruce Dawson9b9f4512022-04-27 00:56:52 +0000668 host=self.gerrit.host,
669 project=self.gerrit.project,
670 branch=self.gerrit.branch)
671 except Exception as e:
672 print('Failed to set owners_client - %s' % str(e))
Jochen Eisinger76f5fc62017-04-07 16:27:46 +0200673 self.owners_finder = owners_finder.OwnersFinder
maruel@chromium.org899e1c12011-04-07 17:03:18 +0000674 self.verbose = verbose
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000675 self.Command = CommandData
dpranke@chromium.org2a009622011-03-01 02:43:31 +0000676
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000677 # Replace <hash_map> and <hash_set> as headers that need to be included
Edward Lemura5799e32020-01-17 19:26:51 +0000678 # with 'base/containers/hash_tables.h' instead.
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000679 # Access to a protected member _XX of a client class
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800680 # pylint: disable=protected-access
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000681 self.cpplint._re_pattern_templates = [
danakj@chromium.org18278522013-06-11 22:42:32 +0000682 (a, b, 'base/containers/hash_tables.h')
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000683 if header in ('<hash_map>', '<hash_set>') else (a, b, header)
684 for (a, b, header) in cpplint._re_pattern_templates
685 ]
686
Edward Lemurecc27072020-01-06 16:42:34 +0000687 def SetTimeout(self, timeout):
688 self.thread_pool.timeout = timeout
689
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000690 def PresubmitLocalPath(self):
691 """Returns the local path of the presubmit script currently being run.
692
693 This is useful if you don't want to hard-code absolute paths in the
694 presubmit script. For example, It can be used to find another file
695 relative to the PRESUBMIT.py script, so the whole tree can be branched and
696 the presubmit script still works, without editing its content.
697 """
maruel@chromium.org3d235242009-05-15 12:40:48 +0000698 return self._current_presubmit_path
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000699
agable0b65e732016-11-22 09:25:46 -0800700 def AffectedFiles(self, include_deletes=True, file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000701 """Same as input_api.change.AffectedFiles() except only lists files
702 (and optionally directories) in the same directory as the current presubmit
Bruce Dawson7a0b07a2020-04-23 17:14:40 +0000703 script, or subdirectories thereof. Note that files are listed using the OS
704 path separator, so backslashes are used as separators on Windows.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000705 """
Josip Sokcevica9a7eec2023-03-10 03:54:52 +0000706 dir_with_slash = normpath(self.PresubmitLocalPath())
Bruce Dawson31bfd512022-05-10 23:19:39 +0000707 # normpath strips trailing path separators, so the trailing separator has to
708 # be added after the normpath call.
709 if len(dir_with_slash) > 0:
710 dir_with_slash += os.path.sep
sail@chromium.org5538e022011-05-12 17:53:16 +0000711
Josip Sokcevica9a7eec2023-03-10 03:54:52 +0000712 return list(filter(
713 lambda x: normpath(x.AbsoluteLocalPath()).startswith(dir_with_slash),
714 self.change.AffectedFiles(include_deletes, file_filter)))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000715
agable0b65e732016-11-22 09:25:46 -0800716 def LocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000717 """Returns local paths of input_api.AffectedFiles()."""
agable0b65e732016-11-22 09:25:46 -0800718 paths = [af.LocalPath() for af in self.AffectedFiles()]
Edward Lemura5799e32020-01-17 19:26:51 +0000719 logging.debug('LocalPaths: %s', paths)
pgervais@chromium.org2f64f782014-04-25 00:12:33 +0000720 return paths
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000721
agable0b65e732016-11-22 09:25:46 -0800722 def AbsoluteLocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000723 """Returns absolute local paths of input_api.AffectedFiles()."""
agable0b65e732016-11-22 09:25:46 -0800724 return [af.AbsoluteLocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000725
John Budorick16162372018-04-18 10:39:53 -0700726 def AffectedTestableFiles(self, include_deletes=None, **kwargs):
agable0b65e732016-11-22 09:25:46 -0800727 """Same as input_api.change.AffectedTestableFiles() except only lists files
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000728 in the same directory as the current presubmit script, or subdirectories
729 thereof.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000730 """
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000731 if include_deletes is not None:
Edward Lemura5799e32020-01-17 19:26:51 +0000732 warn('AffectedTestableFiles(include_deletes=%s)'
733 ' is deprecated and ignored' % str(include_deletes),
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000734 category=DeprecationWarning,
735 stacklevel=2)
Josip Sokcevic4de5dea2022-03-23 21:15:14 +0000736 # pylint: disable=consider-using-generator
737 return [
738 x for x in self.AffectedFiles(include_deletes=False, **kwargs)
739 if x.IsTestableFile()
740 ]
agable0b65e732016-11-22 09:25:46 -0800741
742 def AffectedTextFiles(self, include_deletes=None):
743 """An alias to AffectedTestableFiles for backwards compatibility."""
744 return self.AffectedTestableFiles(include_deletes=include_deletes)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000745
Josip Sokcevic8c955952021-02-01 21:32:57 +0000746 def FilterSourceFile(self,
747 affected_file,
748 files_to_check=None,
749 files_to_skip=None,
750 allow_list=None,
751 block_list=None):
Edward Lemura5799e32020-01-17 19:26:51 +0000752 """Filters out files that aren't considered 'source file'.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000753
local_bot64021412020-07-08 21:05:39 +0000754 If files_to_check or files_to_skip is None, InputApi.DEFAULT_FILES_TO_CHECK
755 and InputApi.DEFAULT_FILES_TO_SKIP is used respectively.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000756
Bruce Dawson635383f2022-09-13 16:23:18 +0000757 affected_file.LocalPath() needs to re.match an entry in the files_to_check
758 list and not re.match any entries in the files_to_skip list.
759 '/' path separators should be used in the regular expressions and will work
760 on Windows as well as other platforms.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000761
762 Note: Copy-paste this function to suit your needs or use a lambda function.
763 """
local_bot64021412020-07-08 21:05:39 +0000764 if files_to_check is None:
765 files_to_check = self.DEFAULT_FILES_TO_CHECK
766 if files_to_skip is None:
767 files_to_skip = self.DEFAULT_FILES_TO_SKIP
local_bot30f774e2020-06-25 18:23:34 +0000768
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000769 def Find(affected_file, items):
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000770 local_path = affected_file.LocalPath()
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000771 for item in items:
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +0000772 if self.re.match(item, local_path):
maruel@chromium.org3410d912009-06-09 20:56:16 +0000773 return True
Bruce Dawsona3a014e2022-04-27 23:28:17 +0000774 # Handle the cases where the files regex only handles /, but the local
775 # path uses \.
776 if self.is_windows and self.re.match(item, local_path.replace(
777 '\\', '/')):
778 return True
maruel@chromium.org3410d912009-06-09 20:56:16 +0000779 return False
local_bot64021412020-07-08 21:05:39 +0000780 return (Find(affected_file, files_to_check) and
781 not Find(affected_file, files_to_skip))
maruel@chromium.org3410d912009-06-09 20:56:16 +0000782
783 def AffectedSourceFiles(self, source_file):
agable0b65e732016-11-22 09:25:46 -0800784 """Filter the list of AffectedTestableFiles by the function source_file.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000785
786 If source_file is None, InputApi.FilterSourceFile() is used.
787 """
788 if not source_file:
789 source_file = self.FilterSourceFile
Edward Lemurb9830242019-10-30 22:19:20 +0000790 return list(filter(source_file, self.AffectedTestableFiles()))
maruel@chromium.org3410d912009-06-09 20:56:16 +0000791
792 def RightHandSideLines(self, source_file_filter=None):
Edward Lemura5799e32020-01-17 19:26:51 +0000793 """An iterator over all text lines in 'new' version of changed files.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000794
795 Only lists lines from new or modified text files in the change that are
796 contained by the directory of the currently executing presubmit script.
797
798 This is useful for doing line-by-line regex checks, like checking for
799 trailing whitespace.
800
801 Yields:
802 a 3 tuple:
Josip Sokcevic7958e302023-03-01 23:02:21 +0000803 the AffectedFile instance of the current file;
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000804 integer line number (1-based); and
805 the contents of the line as a string.
maruel@chromium.org1487d532009-06-06 00:22:57 +0000806
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000807 Note: The carriage return (LF or CR) is stripped off.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000808 """
maruel@chromium.org3410d912009-06-09 20:56:16 +0000809 files = self.AffectedSourceFiles(source_file_filter)
Josip Sokcevic7958e302023-03-01 23:02:21 +0000810 return _RightHandSideLinesImpl(files)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000811
maruel@chromium.orge3608df2009-11-10 20:22:57 +0000812 def ReadFile(self, file_item, mode='r'):
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000813 """Reads an arbitrary file.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000814
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000815 Deny reading anything outside the repository.
816 """
Josip Sokcevic7958e302023-03-01 23:02:21 +0000817 if isinstance(file_item, AffectedFile):
maruel@chromium.orge3608df2009-11-10 20:22:57 +0000818 file_item = file_item.AbsoluteLocalPath()
819 if not file_item.startswith(self.change.RepositoryRoot()):
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000820 raise IOError('Access outside the repository root is denied.')
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +0000821 return gclient_utils.FileRead(file_item, mode)
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000822
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +0100823 def CreateTemporaryFile(self, **kwargs):
824 """Returns a named temporary file that must be removed with a call to
825 RemoveTemporaryFiles().
826
827 All keyword arguments are forwarded to tempfile.NamedTemporaryFile(),
828 except for |delete|, which is always set to False.
829
830 Presubmit checks that need to create a temporary file and pass it for
831 reading should use this function instead of NamedTemporaryFile(), as
832 Windows fails to open a file that is already open for writing.
833
834 with input_api.CreateTemporaryFile() as f:
835 f.write('xyz')
836 f.close()
837 input_api.subprocess.check_output(['script-that', '--reads-from',
838 f.name])
839
840
841 Note that callers of CreateTemporaryFile() should not worry about removing
842 any temporary file; this is done transparently by the presubmit handling
843 code.
844 """
845 if 'delete' in kwargs:
846 # Prevent users from passing |delete|; we take care of file deletion
847 # ourselves and this prevents unintuitive error messages when we pass
848 # delete=False and 'delete' is also in kwargs.
849 raise TypeError('CreateTemporaryFile() does not take a "delete" '
850 'argument, file deletion is handled automatically by '
851 'the same presubmit_support code that creates InputApi '
852 'objects.')
853 temp_file = self.tempfile.NamedTemporaryFile(delete=False, **kwargs)
854 self._named_temporary_files.append(temp_file.name)
855 return temp_file
856
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000857 @property
858 def tbr(self):
859 """Returns if a change is TBR'ed."""
Jeremy Romandce22502017-06-20 15:37:29 -0400860 return 'TBR' in self.change.tags or self.change.TBRsFromDescription()
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000861
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +0000862 def RunTests(self, tests_mix, parallel=True):
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000863 tests = []
864 msgs = []
865 for t in tests_mix:
Edward Lesmes8e282792018-04-03 18:50:29 -0400866 if isinstance(t, OutputApi.PresubmitResult) and t:
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000867 msgs.append(t)
868 else:
869 assert issubclass(t.message, _PresubmitResult)
870 tests.append(t)
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +0000871 if self.verbose:
872 t.info = _PresubmitNotifyResult
Edward Lemur1037c742018-05-01 18:56:04 -0400873 if not t.kwargs.get('cwd'):
874 t.kwargs['cwd'] = self.PresubmitLocalPath()
Edward Lesmes8e282792018-04-03 18:50:29 -0400875 self.thread_pool.AddTests(tests, parallel)
Edward Lemur21000eb2019-05-24 23:25:58 +0000876 # When self.parallel is True (i.e. --parallel is passed as an option)
877 # RunTests doesn't actually run tests. It adds them to a ThreadPool that
878 # will run all tests once all PRESUBMIT files are processed.
879 # Otherwise, it will run them and return the results.
880 if not self.parallel:
Edward Lesmes8e282792018-04-03 18:50:29 -0400881 msgs.extend(self.thread_pool.RunAsync())
882 return msgs
scottmg86099d72016-09-01 09:16:51 -0700883
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000884
Josip Sokcevic7958e302023-03-01 23:02:21 +0000885class _DiffCache(object):
886 """Caches diffs retrieved from a particular SCM."""
887 def __init__(self, upstream=None):
888 """Stores the upstream revision against which all diffs will be computed."""
889 self._upstream = upstream
890
891 def GetDiff(self, path, local_root):
892 """Get the diff for a particular path."""
893 raise NotImplementedError()
894
895 def GetOldContents(self, path, local_root):
896 """Get the old version for a particular path."""
897 raise NotImplementedError()
898
899
900class _GitDiffCache(_DiffCache):
901 """DiffCache implementation for git; gets all file diffs at once."""
902 def __init__(self, upstream):
903 super(_GitDiffCache, self).__init__(upstream=upstream)
904 self._diffs_by_file = None
905
906 def GetDiff(self, path, local_root):
907 # Compare against None to distinguish between None and an initialized but
908 # empty dictionary.
909 if self._diffs_by_file == None:
910 # Compute a single diff for all files and parse the output; should
911 # with git this is much faster than computing one diff for each file.
912 diffs = {}
913
914 # Don't specify any filenames below, because there are command line length
915 # limits on some platforms and GenerateDiff would fail.
916 unified_diff = scm.GIT.GenerateDiff(local_root, files=[], full_move=True,
917 branch=self._upstream)
918
919 # This regex matches the path twice, separated by a space. Note that
920 # filename itself may contain spaces.
921 file_marker = re.compile('^diff --git (?P<filename>.*) (?P=filename)$')
922 current_diff = []
923 keep_line_endings = True
924 for x in unified_diff.splitlines(keep_line_endings):
925 match = file_marker.match(x)
926 if match:
927 # Marks the start of a new per-file section.
928 diffs[match.group('filename')] = current_diff = [x]
929 elif x.startswith('diff --git'):
930 raise PresubmitFailure('Unexpected diff line: %s' % x)
931 else:
932 current_diff.append(x)
933
934 self._diffs_by_file = dict(
Josip Sokcevica9a7eec2023-03-10 03:54:52 +0000935 (normpath(path), ''.join(diff)) for path, diff in diffs.items())
Josip Sokcevic7958e302023-03-01 23:02:21 +0000936
937 if path not in self._diffs_by_file:
938 # SCM didn't have any diff on this file. It could be that the file was not
939 # modified at all (e.g. user used --all flag in git cl presubmit).
940 # Intead of failing, return empty string.
941 # See: https://crbug.com/808346.
942 return ''
943
944 return self._diffs_by_file[path]
945
946 def GetOldContents(self, path, local_root):
947 return scm.GIT.GetOldContents(local_root, path, branch=self._upstream)
948
949
950class AffectedFile(object):
951 """Representation of a file in a change."""
952
953 DIFF_CACHE = _DiffCache
954
955 # Method could be a function
956 # pylint: disable=no-self-use
957 def __init__(self, path, action, repository_root, diff_cache):
958 self._path = path
959 self._action = action
960 self._local_root = repository_root
961 self._is_directory = None
962 self._cached_changed_contents = None
963 self._cached_new_contents = None
964 self._diff_cache = diff_cache
965 logging.debug('%s(%s)', self.__class__.__name__, self._path)
966
967 def LocalPath(self):
968 """Returns the path of this file on the local disk relative to client root.
969
970 This should be used for error messages but not for accessing files,
971 because presubmit checks are run with CWD=PresubmitLocalPath() (which is
972 often != client root).
973 """
Josip Sokcevica9a7eec2023-03-10 03:54:52 +0000974 return normpath(self._path)
Josip Sokcevic7958e302023-03-01 23:02:21 +0000975
976 def AbsoluteLocalPath(self):
977 """Returns the absolute path of this file on the local disk.
978 """
979 return os.path.abspath(os.path.join(self._local_root, self.LocalPath()))
980
981 def Action(self):
982 """Returns the action on this opened file, e.g. A, M, D, etc."""
983 return self._action
984
985 def IsTestableFile(self):
986 """Returns True if the file is a text file and not a binary file.
987
988 Deleted files are not text file."""
989 raise NotImplementedError() # Implement when needed
990
991 def IsTextFile(self):
992 """An alias to IsTestableFile for backwards compatibility."""
993 return self.IsTestableFile()
994
995 def OldContents(self):
996 """Returns an iterator over the lines in the old version of file.
997
998 The old version is the file before any modifications in the user's
999 workspace, i.e. the 'left hand side'.
1000
1001 Contents will be empty if the file is a directory or does not exist.
1002 Note: The carriage returns (LF or CR) are stripped off.
1003 """
1004 return self._diff_cache.GetOldContents(self.LocalPath(),
1005 self._local_root).splitlines()
1006
1007 def NewContents(self):
1008 """Returns an iterator over the lines in the new version of file.
1009
1010 The new version is the file in the user's workspace, i.e. the 'right hand
1011 side'.
1012
1013 Contents will be empty if the file is a directory or does not exist.
1014 Note: The carriage returns (LF or CR) are stripped off.
1015 """
1016 if self._cached_new_contents is None:
1017 self._cached_new_contents = []
1018 try:
1019 self._cached_new_contents = gclient_utils.FileRead(
1020 self.AbsoluteLocalPath(), 'rU').splitlines()
1021 except IOError:
1022 pass # File not found? That's fine; maybe it was deleted.
1023 except UnicodeDecodeError as e:
1024 # log the filename since we're probably trying to read a binary
1025 # file, and shouldn't be.
1026 print('Error reading %s: %s' % (self.AbsoluteLocalPath(), e))
1027 raise
1028
1029 return self._cached_new_contents[:]
1030
1031 def ChangedContents(self, keeplinebreaks=False):
1032 """Returns a list of tuples (line number, line text) of all new lines.
1033
1034 This relies on the scm diff output describing each changed code section
1035 with a line of the form
1036
1037 ^@@ <old line num>,<old size> <new line num>,<new size> @@$
1038 """
1039 # Don't return cached results when line breaks are requested.
1040 if not keeplinebreaks and self._cached_changed_contents is not None:
1041 return self._cached_changed_contents[:]
1042 result = []
1043 line_num = 0
1044
1045 # The keeplinebreaks parameter to splitlines must be True or else the
1046 # CheckForWindowsLineEndings presubmit will be a NOP.
1047 for line in self.GenerateScmDiff().splitlines(keeplinebreaks):
1048 m = re.match(r'^@@ [0-9\,\+\-]+ \+([0-9]+)\,[0-9]+ @@', line)
1049 if m:
1050 line_num = int(m.groups(1)[0])
1051 continue
1052 if line.startswith('+') and not line.startswith('++'):
1053 result.append((line_num, line[1:]))
1054 if not line.startswith('-'):
1055 line_num += 1
1056 # Don't cache results with line breaks.
1057 if keeplinebreaks:
1058 return result;
1059 self._cached_changed_contents = result
1060 return self._cached_changed_contents[:]
1061
1062 def __str__(self):
1063 return self.LocalPath()
1064
1065 def GenerateScmDiff(self):
1066 return self._diff_cache.GetDiff(self.LocalPath(), self._local_root)
1067
1068
1069class GitAffectedFile(AffectedFile):
1070 """Representation of a file in a change out of a git checkout."""
1071 # Method 'NNN' is abstract in class 'NNN' but is not overridden
1072 # pylint: disable=abstract-method
1073
1074 DIFF_CACHE = _GitDiffCache
1075
1076 def __init__(self, *args, **kwargs):
1077 AffectedFile.__init__(self, *args, **kwargs)
1078 self._server_path = None
1079 self._is_testable_file = None
1080
1081 def IsTestableFile(self):
1082 if self._is_testable_file is None:
1083 if self.Action() == 'D':
1084 # A deleted file is not testable.
1085 self._is_testable_file = False
1086 else:
1087 self._is_testable_file = os.path.isfile(self.AbsoluteLocalPath())
1088 return self._is_testable_file
1089
1090
1091class Change(object):
1092 """Describe a change.
1093
1094 Used directly by the presubmit scripts to query the current change being
1095 tested.
1096
1097 Instance members:
1098 tags: Dictionary of KEY=VALUE pairs found in the change description.
1099 self.KEY: equivalent to tags['KEY']
1100 """
1101
1102 _AFFECTED_FILES = AffectedFile
1103
1104 # Matches key/value (or 'tag') lines in changelist descriptions.
1105 TAG_LINE_RE = re.compile(
1106 '^[ \t]*(?P<key>[A-Z][A-Z_0-9]*)[ \t]*=[ \t]*(?P<value>.*?)[ \t]*$')
1107 scm = ''
1108
1109 def __init__(
1110 self, name, description, local_root, files, issue, patchset, author,
1111 upstream=None):
1112 if files is None:
1113 files = []
1114 self._name = name
1115 # Convert root into an absolute path.
1116 self._local_root = os.path.abspath(local_root)
1117 self._upstream = upstream
1118 self.issue = issue
1119 self.patchset = patchset
1120 self.author_email = author
1121
1122 self._full_description = ''
1123 self.tags = {}
1124 self._description_without_tags = ''
1125 self.SetDescriptionText(description)
1126
1127 assert all(
1128 (isinstance(f, (list, tuple)) and len(f) == 2) for f in files), files
1129
1130 diff_cache = self._AFFECTED_FILES.DIFF_CACHE(self._upstream)
1131 self._affected_files = [
1132 self._AFFECTED_FILES(path, action.strip(), self._local_root, diff_cache)
1133 for action, path in files
1134 ]
1135
1136 def UpstreamBranch(self):
1137 """Returns the upstream branch for the change."""
1138 return self._upstream
1139
1140 def Name(self):
1141 """Returns the change name."""
1142 return self._name
1143
1144 def DescriptionText(self):
1145 """Returns the user-entered changelist description, minus tags.
1146
1147 Any line in the user-provided description starting with e.g. 'FOO='
1148 (whitespace permitted before and around) is considered a tag line. Such
1149 lines are stripped out of the description this function returns.
1150 """
1151 return self._description_without_tags
1152
1153 def FullDescriptionText(self):
1154 """Returns the complete changelist description including tags."""
1155 return self._full_description
1156
1157 def SetDescriptionText(self, description):
1158 """Sets the full description text (including tags) to |description|.
1159
1160 Also updates the list of tags."""
1161 self._full_description = description
1162
1163 # From the description text, build up a dictionary of key/value pairs
1164 # plus the description minus all key/value or 'tag' lines.
1165 description_without_tags = []
1166 self.tags = {}
1167 for line in self._full_description.splitlines():
1168 m = self.TAG_LINE_RE.match(line)
1169 if m:
1170 self.tags[m.group('key')] = m.group('value')
1171 else:
1172 description_without_tags.append(line)
1173
1174 # Change back to text and remove whitespace at end.
1175 self._description_without_tags = (
1176 '\n'.join(description_without_tags).rstrip())
1177
1178 def AddDescriptionFooter(self, key, value):
1179 """Adds the given footer to the change description.
1180
1181 Args:
1182 key: A string with the key for the git footer. It must conform to
1183 the git footers format (i.e. 'List-Of-Tokens') and will be case
1184 normalized so that each token is title-cased.
1185 value: A string with the value for the git footer.
1186 """
1187 description = git_footers.add_footer(
1188 self.FullDescriptionText(), git_footers.normalize_name(key), value)
1189 self.SetDescriptionText(description)
1190
1191 def RepositoryRoot(self):
1192 """Returns the repository (checkout) root directory for this change,
1193 as an absolute path.
1194 """
1195 return self._local_root
1196
1197 def __getattr__(self, attr):
1198 """Return tags directly as attributes on the object."""
1199 if not re.match(r'^[A-Z_]*$', attr):
1200 raise AttributeError(self, attr)
1201 return self.tags.get(attr)
1202
1203 def GitFootersFromDescription(self):
1204 """Return the git footers present in the description.
1205
1206 Returns:
1207 footers: A dict of {footer: [values]} containing a multimap of the footers
1208 in the change description.
1209 """
1210 return git_footers.parse_footers(self.FullDescriptionText())
1211
1212 def BugsFromDescription(self):
1213 """Returns all bugs referenced in the commit description."""
1214 bug_tags = ['BUG', 'FIXED']
1215
1216 tags = []
1217 for tag in bug_tags:
1218 values = self.tags.get(tag)
1219 if values:
1220 tags += [value.strip() for value in values.split(',')]
1221
1222 footers = []
1223 parsed = self.GitFootersFromDescription()
1224 unsplit_footers = parsed.get('Bug', []) + parsed.get('Fixed', [])
1225 for unsplit_footer in unsplit_footers:
1226 footers += [b.strip() for b in unsplit_footer.split(',')]
1227 return sorted(set(tags + footers))
1228
1229 def ReviewersFromDescription(self):
1230 """Returns all reviewers listed in the commit description."""
1231 # We don't support a 'R:' git-footer for reviewers; that is in metadata.
1232 tags = [r.strip() for r in self.tags.get('R', '').split(',') if r.strip()]
1233 return sorted(set(tags))
1234
1235 def TBRsFromDescription(self):
1236 """Returns all TBR reviewers listed in the commit description."""
1237 tags = [r.strip() for r in self.tags.get('TBR', '').split(',') if r.strip()]
1238 # TODO(crbug.com/839208): Remove support for 'Tbr:' when TBRs are
1239 # programmatically determined by self-CR+1s.
1240 footers = self.GitFootersFromDescription().get('Tbr', [])
1241 return sorted(set(tags + footers))
1242
1243 # TODO(crbug.com/753425): Delete these once we're sure they're unused.
1244 @property
1245 def BUG(self):
1246 return ','.join(self.BugsFromDescription())
1247 @property
1248 def R(self):
1249 return ','.join(self.ReviewersFromDescription())
1250 @property
1251 def TBR(self):
1252 return ','.join(self.TBRsFromDescription())
1253
1254 def AllFiles(self, root=None):
1255 """List all files under source control in the repo."""
1256 raise NotImplementedError()
1257
1258 def AffectedFiles(self, include_deletes=True, file_filter=None):
1259 """Returns a list of AffectedFile instances for all files in the change.
1260
1261 Args:
1262 include_deletes: If false, deleted files will be filtered out.
1263 file_filter: An additional filter to apply.
1264
1265 Returns:
1266 [AffectedFile(path, action), AffectedFile(path, action)]
1267 """
1268 affected = list(filter(file_filter, self._affected_files))
1269
1270 if include_deletes:
1271 return affected
1272 return list(filter(lambda x: x.Action() != 'D', affected))
1273
1274 def AffectedTestableFiles(self, include_deletes=None, **kwargs):
1275 """Return a list of the existing text files in a change."""
1276 if include_deletes is not None:
1277 warn('AffectedTeestableFiles(include_deletes=%s)'
1278 ' is deprecated and ignored' % str(include_deletes),
1279 category=DeprecationWarning,
1280 stacklevel=2)
1281 return list(filter(
1282 lambda x: x.IsTestableFile(),
1283 self.AffectedFiles(include_deletes=False, **kwargs)))
1284
1285 def AffectedTextFiles(self, include_deletes=None):
1286 """An alias to AffectedTestableFiles for backwards compatibility."""
1287 return self.AffectedTestableFiles(include_deletes=include_deletes)
1288
1289 def LocalPaths(self):
1290 """Convenience function."""
1291 return [af.LocalPath() for af in self.AffectedFiles()]
1292
1293 def AbsoluteLocalPaths(self):
1294 """Convenience function."""
1295 return [af.AbsoluteLocalPath() for af in self.AffectedFiles()]
1296
1297 def RightHandSideLines(self):
1298 """An iterator over all text lines in 'new' version of changed files.
1299
1300 Lists lines from new or modified text files in the change.
1301
1302 This is useful for doing line-by-line regex checks, like checking for
1303 trailing whitespace.
1304
1305 Yields:
1306 a 3 tuple:
1307 the AffectedFile instance of the current file;
1308 integer line number (1-based); and
1309 the contents of the line as a string.
1310 """
1311 return _RightHandSideLinesImpl(
1312 x for x in self.AffectedFiles(include_deletes=False)
1313 if x.IsTestableFile())
1314
1315 def OriginalOwnersFiles(self):
1316 """A map from path names of affected OWNERS files to their old content."""
1317 def owners_file_filter(f):
1318 return 'OWNERS' in os.path.split(f.LocalPath())[1]
1319 files = self.AffectedFiles(file_filter=owners_file_filter)
1320 return {f.LocalPath(): f.OldContents() for f in files}
1321
1322
1323class GitChange(Change):
1324 _AFFECTED_FILES = GitAffectedFile
1325 scm = 'git'
1326
1327 def AllFiles(self, root=None):
1328 """List all files under source control in the repo."""
1329 root = root or self.RepositoryRoot()
1330 return subprocess.check_output(
1331 ['git', '-c', 'core.quotePath=false', 'ls-files', '--', '.'],
1332 cwd=root).decode('utf-8', 'ignore').splitlines()
1333
1334
Josip Sokcevica9a7eec2023-03-10 03:54:52 +00001335def ListRelevantPresubmitFiles(files, root):
1336 """Finds all presubmit files that apply to a given set of source files.
1337
1338 If inherit-review-settings-ok is present right under root, looks for
1339 PRESUBMIT.py in directories enclosing root.
1340
1341 Args:
1342 files: An iterable container containing file paths.
1343 root: Path where to stop searching.
1344
1345 Return:
1346 List of absolute paths of the existing PRESUBMIT.py scripts.
1347 """
1348 files = [normpath(os.path.join(root, f)) for f in files]
1349
1350 # List all the individual directories containing files.
1351 directories = {os.path.dirname(f) for f in files}
1352
1353 # Ignore root if inherit-review-settings-ok is present.
1354 if os.path.isfile(os.path.join(root, 'inherit-review-settings-ok')):
1355 root = None
1356
1357 # Collect all unique directories that may contain PRESUBMIT.py.
1358 candidates = set()
1359 for directory in directories:
1360 while True:
1361 if directory in candidates:
1362 break
1363 candidates.add(directory)
1364 if directory == root:
1365 break
1366 parent_dir = os.path.dirname(directory)
1367 if parent_dir == directory:
1368 # We hit the system root directory.
1369 break
1370 directory = parent_dir
1371
1372 # Look for PRESUBMIT.py in all candidate directories.
1373 results = []
1374 for directory in sorted(list(candidates)):
1375 try:
1376 for f in os.listdir(directory):
1377 p = os.path.join(directory, f)
1378 if os.path.isfile(p) and re.match(
1379 r'PRESUBMIT.*\.py$', f) and not f.startswith('PRESUBMIT_test'):
1380 results.append(p)
1381 except OSError:
1382 pass
1383
1384 logging.debug('Presubmit files: %s', ','.join(results))
1385 return results
1386
1387
rmistry@google.com5626a922015-02-26 14:03:30 +00001388class GetPostUploadExecuter(object):
Robert Iannucci3d6d2d22023-05-11 17:25:05 +00001389 def __init__(self, change, gerrit_obj):
Josip Sokcevice293d3d2022-02-16 22:52:15 +00001390 """
1391 Args:
Pavol Marko624e7ee2023-01-09 09:56:29 +00001392 change: The Change object.
1393 gerrit_obj: provides basic Gerrit codereview functionality.
Josip Sokcevice293d3d2022-02-16 22:52:15 +00001394 """
Pavol Marko624e7ee2023-01-09 09:56:29 +00001395 self.change = change
1396 self.gerrit = gerrit_obj
Josip Sokcevice293d3d2022-02-16 22:52:15 +00001397
Pavol Marko624e7ee2023-01-09 09:56:29 +00001398 def ExecPresubmitScript(self, script_text, presubmit_path):
rmistry@google.com5626a922015-02-26 14:03:30 +00001399 """Executes PostUploadHook() from a single presubmit script.
Josip Sokcevic632bbc02022-05-19 05:32:50 +00001400 Caller is responsible for validating whether the hook should be executed
1401 and should only call this function if it should be.
rmistry@google.com5626a922015-02-26 14:03:30 +00001402
1403 Args:
1404 script_text: The text of the presubmit script.
1405 presubmit_path: Project script to run.
rmistry@google.com5626a922015-02-26 14:03:30 +00001406
1407 Return:
1408 A list of results objects.
1409 """
Pavol Marko624e7ee2023-01-09 09:56:29 +00001410 # Change to the presubmit file's directory to support local imports.
1411 presubmit_dir = os.path.dirname(presubmit_path)
1412 main_path = os.getcwd()
1413 try:
1414 os.chdir(presubmit_dir)
1415 return self._execute_with_local_working_directory(script_text,
1416 presubmit_dir,
1417 presubmit_path)
1418 finally:
1419 # Return the process to the original working directory.
1420 os.chdir(main_path)
1421
1422 def _execute_with_local_working_directory(self, script_text, presubmit_dir,
1423 presubmit_path):
rmistry@google.com5626a922015-02-26 14:03:30 +00001424 context = {}
1425 try:
Pavol Marko624e7ee2023-01-09 09:56:29 +00001426 exec(compile(script_text, presubmit_path, 'exec', dont_inherit=True),
Raul Tambre09e64b42019-05-14 01:57:22 +00001427 context)
Raul Tambre7c938462019-05-24 16:35:35 +00001428 except Exception as e:
rmistry@google.com5626a922015-02-26 14:03:30 +00001429 raise PresubmitFailure('"%s" had an exception.\n%s'
1430 % (presubmit_path, e))
1431
1432 function_name = 'PostUploadHook'
1433 if function_name not in context:
1434 return {}
1435 post_upload_hook = context[function_name]
1436 if not len(inspect.getargspec(post_upload_hook)[0]) == 3:
1437 raise PresubmitFailure(
1438 'Expected function "PostUploadHook" to take three arguments.')
Pavol Marko624e7ee2023-01-09 09:56:29 +00001439 return post_upload_hook(self.gerrit, self.change, OutputApi(False))
rmistry@google.com5626a922015-02-26 14:03:30 +00001440
1441
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001442def _MergeMasters(masters1, masters2):
1443 """Merges two master maps. Merges also the tests of each builder."""
1444 result = {}
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001445 for (master, builders) in itertools.chain(masters1.items(),
1446 masters2.items()):
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001447 new_builders = result.setdefault(master, {})
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001448 for (builder, tests) in builders.items():
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001449 new_builders.setdefault(builder, set([])).update(tests)
1450 return result
1451
1452
Robert Iannucci3d6d2d22023-05-11 17:25:05 +00001453def DoPostUploadExecuter(change, gerrit_obj, verbose):
rmistry@google.com5626a922015-02-26 14:03:30 +00001454 """Execute the post upload hook.
1455
1456 Args:
1457 change: The Change object.
Edward Lemur016a0872020-02-04 22:13:28 +00001458 gerrit_obj: The GerritAccessor object.
rmistry@google.com5626a922015-02-26 14:03:30 +00001459 verbose: Prints debug info.
rmistry@google.com5626a922015-02-26 14:03:30 +00001460 """
Josip Sokcevice293d3d2022-02-16 22:52:15 +00001461 python_version = 'Python %s' % sys.version_info.major
1462 sys.stdout.write('Running %s post upload checks ...\n' % python_version)
Josip Sokcevica9a7eec2023-03-10 03:54:52 +00001463 presubmit_files = ListRelevantPresubmitFiles(
1464 change.LocalPaths(), change.RepositoryRoot())
rmistry@google.com5626a922015-02-26 14:03:30 +00001465 if not presubmit_files and verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001466 sys.stdout.write('Warning, no PRESUBMIT.py found.\n')
rmistry@google.com5626a922015-02-26 14:03:30 +00001467 results = []
Robert Iannucci3d6d2d22023-05-11 17:25:05 +00001468 executer = GetPostUploadExecuter(change, gerrit_obj)
rmistry@google.com5626a922015-02-26 14:03:30 +00001469 # The root presubmit file should be executed after the ones in subdirectories.
1470 # i.e. the specific post upload hooks should run before the general ones.
Josip Sokcevica9a7eec2023-03-10 03:54:52 +00001471 # Thus, reverse the order provided by ListRelevantPresubmitFiles.
rmistry@google.com5626a922015-02-26 14:03:30 +00001472 presubmit_files.reverse()
1473
1474 for filename in presubmit_files:
1475 filename = os.path.abspath(filename)
rmistry@google.com5626a922015-02-26 14:03:30 +00001476 # Accept CRLF presubmit script.
Bruce Dawson6e70e862022-07-01 19:37:01 +00001477 presubmit_script = gclient_utils.FileRead(filename).replace('\r\n', '\n')
Robert Iannucci3d6d2d22023-05-11 17:25:05 +00001478 if verbose:
1479 sys.stdout.write('Running %s\n' % filename)
1480 results.extend(executer.ExecPresubmitScript(presubmit_script, filename))
rmistry@google.com5626a922015-02-26 14:03:30 +00001481
Edward Lemur6eb1d322020-02-27 22:20:15 +00001482 if not results:
1483 return 0
1484
1485 sys.stdout.write('\n')
1486 sys.stdout.write('** Post Upload Hook Messages **\n')
1487
1488 exit_code = 0
1489 for result in results:
1490 if result.fatal:
1491 exit_code = 1
1492 result.handle()
1493 sys.stdout.write('\n')
1494
1495 return exit_code
rmistry@google.com5626a922015-02-26 14:03:30 +00001496
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001497class PresubmitExecuter(object):
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001498 def __init__(self, change, committing, verbose, gerrit_obj, dry_run=None,
Robert Iannucci3d6d2d22023-05-11 17:25:05 +00001499 thread_pool=None, parallel=False, no_diffs=False):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001500 """
1501 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001502 change: The Change object.
agable92bec4f2016-08-24 09:27:27 -07001503 committing: True if 'git cl land' is running, False if 'git cl upload' is.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001504 gerrit_obj: provides basic Gerrit codereview functionality.
1505 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -04001506 parallel: if true, all tests reported via input_api.RunTests for all
1507 PRESUBMIT files will be run in parallel.
Bruce Dawson09c0c072022-05-26 20:28:58 +00001508 no_diffs: if true, implies that --files or --all was specified so some
1509 checks can be skipped, and some errors will be messages.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001510 """
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001511 self.change = change
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001512 self.committing = committing
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001513 self.gerrit = gerrit_obj
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001514 self.verbose = verbose
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001515 self.dry_run = dry_run
Daniel Cheng7227d212017-11-17 08:12:37 -08001516 self.more_cc = []
Edward Lesmes8e282792018-04-03 18:50:29 -04001517 self.thread_pool = thread_pool
1518 self.parallel = parallel
Bruce Dawson09c0c072022-05-26 20:28:58 +00001519 self.no_diffs = no_diffs
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001520
1521 def ExecPresubmitScript(self, script_text, presubmit_path):
1522 """Executes a single presubmit script.
Josip Sokcevic632bbc02022-05-19 05:32:50 +00001523 Caller is responsible for validating whether the hook should be executed
1524 and should only call this function if it should be.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001525
1526 Args:
1527 script_text: The text of the presubmit script.
1528 presubmit_path: The path to the presubmit file (this will be reported via
1529 input_api.PresubmitLocalPath()).
1530
1531 Return:
1532 A list of result objects, empty if no problems.
1533 """
chase@chromium.org8e416c82009-10-06 04:30:44 +00001534 # Change to the presubmit file's directory to support local imports.
Saagar Sanghavi98b332f2020-07-31 17:19:15 +00001535 presubmit_dir = os.path.dirname(presubmit_path)
Pavol Marko624e7ee2023-01-09 09:56:29 +00001536 main_path = os.getcwd()
1537 try:
1538 os.chdir(presubmit_dir)
1539 return self._execute_with_local_working_directory(script_text,
1540 presubmit_dir,
1541 presubmit_path)
1542 finally:
1543 # Return the process to the original working directory.
1544 os.chdir(main_path)
chase@chromium.org8e416c82009-10-06 04:30:44 +00001545
Pavol Marko624e7ee2023-01-09 09:56:29 +00001546 def _execute_with_local_working_directory(self, script_text, presubmit_dir,
1547 presubmit_path):
chase@chromium.org8e416c82009-10-06 04:30:44 +00001548 # Load the presubmit script into context.
dpranke@chromium.org970c5222011-03-12 00:32:24 +00001549 input_api = InputApi(self.change, presubmit_path, self.committing,
Aaron Gable668c1d82018-04-03 10:19:16 -07001550 self.verbose, gerrit_obj=self.gerrit,
Edward Lesmes8e282792018-04-03 18:50:29 -04001551 dry_run=self.dry_run, thread_pool=self.thread_pool,
Bruce Dawson09c0c072022-05-26 20:28:58 +00001552 parallel=self.parallel, no_diffs=self.no_diffs)
Daniel Cheng7227d212017-11-17 08:12:37 -08001553 output_api = OutputApi(self.committing)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001554 context = {}
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001555
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001556 try:
Bruce Dawson0ba2fd42022-07-21 13:47:21 +00001557 exec(compile(script_text, presubmit_path, 'exec', dont_inherit=True),
Raul Tambre09e64b42019-05-14 01:57:22 +00001558 context)
Raul Tambre7c938462019-05-24 16:35:35 +00001559 except Exception as e:
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001560 raise PresubmitFailure('"%s" had an exception.\n%s' % (presubmit_path, e))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001561
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001562 context['__args'] = (input_api, output_api)
Ben Pastene8351dc12020-08-06 05:01:35 +00001563
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001564 # Get path of presubmit directory relative to repository root.
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001565 # Always use forward slashes, so that path is same in *nix and Windows
1566 root = input_api.change.RepositoryRoot()
1567 rel_path = os.path.relpath(presubmit_dir, root)
1568 rel_path = rel_path.replace(os.path.sep, '/')
Ben Pastene8351dc12020-08-06 05:01:35 +00001569
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001570 # Get the URL of git remote origin and use it to identify host and project
Edward Lesmeseb1bd622021-03-01 19:54:07 +00001571 host = project = ''
1572 if self.gerrit:
1573 host = self.gerrit.host or ''
1574 project = self.gerrit.project or ''
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001575
1576 # Prefix for test names
1577 prefix = 'presubmit:%s/%s:%s/' % (host, project, rel_path)
1578
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001579 # Perform all the desired presubmit checks.
1580 results = []
Ben Pastene8351dc12020-08-06 05:01:35 +00001581
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001582 try:
Scott Leecc2fe9b2020-11-19 19:38:06 +00001583 version = [
1584 int(x) for x in context.get('PRESUBMIT_VERSION', '0.0.0').split('.')
1585 ]
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001586
Scott Leecc2fe9b2020-11-19 19:38:06 +00001587 with rdb_wrapper.client(prefix) as sink:
1588 if version >= [2, 0, 0]:
Andrew Grievebdfb8f22022-02-02 21:56:47 +00001589 # Copy the keys to prevent "dictionary changed size during iteration"
1590 # exception if checks add globals to context. E.g. sometimes the
1591 # Python runtime will add __warningregistry__.
1592 for function_name in list(context.keys()):
Scott Leecc2fe9b2020-11-19 19:38:06 +00001593 if not function_name.startswith('Check'):
1594 continue
1595 if function_name.endswith('Commit') and not self.committing:
1596 continue
1597 if function_name.endswith('Upload') and self.committing:
1598 continue
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001599 logging.debug('Running %s in %s', function_name, presubmit_path)
1600 results.extend(
Bruce Dawson8fa42e22022-03-29 17:05:38 +00001601 self._run_check_function(function_name, context, sink,
1602 presubmit_path))
Scott Leecc2fe9b2020-11-19 19:38:06 +00001603 logging.debug('Running %s done.', function_name)
1604 self.more_cc.extend(output_api.more_cc)
1605
1606 else: # Old format
1607 if self.committing:
1608 function_name = 'CheckChangeOnCommit'
1609 else:
1610 function_name = 'CheckChangeOnUpload'
Andrew Grievebdfb8f22022-02-02 21:56:47 +00001611 if function_name in list(context.keys()):
Scott Leecc2fe9b2020-11-19 19:38:06 +00001612 logging.debug('Running %s in %s', function_name, presubmit_path)
1613 results.extend(
Bruce Dawson8fa42e22022-03-29 17:05:38 +00001614 self._run_check_function(function_name, context, sink,
1615 presubmit_path))
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001616 logging.debug('Running %s done.', function_name)
1617 self.more_cc.extend(output_api.more_cc)
1618
1619 finally:
1620 for f in input_api._named_temporary_files:
1621 os.remove(f)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001622
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001623 return results
1624
Bruce Dawson8fa42e22022-03-29 17:05:38 +00001625 def _run_check_function(self, function_name, context, sink, presubmit_path):
Scott Leecc2fe9b2020-11-19 19:38:06 +00001626 """Evaluates and returns the result of a given presubmit function.
1627
1628 If sink is given, the result of the presubmit function will be reported
1629 to the ResultSink.
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001630
1631 Args:
Scott Leecc2fe9b2020-11-19 19:38:06 +00001632 function_name: the name of the presubmit function to evaluate
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001633 context: a context dictionary in which the function will be evaluated
Scott Leecc2fe9b2020-11-19 19:38:06 +00001634 sink: an instance of ResultSink. None, by default.
1635 Returns:
1636 the result of the presubmit function call.
1637 """
1638 start_time = time_time()
1639 try:
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001640 result = eval(function_name + '(*__args)', context)
1641 self._check_result_type(result)
Allen Webbfe7d7092021-05-18 02:05:49 +00001642 except Exception:
Bruce Dawson10a82862022-05-27 19:25:56 +00001643 _, e_value, _ = sys.exc_info()
1644 result = [
1645 OutputApi.PresubmitError(
1646 'Evaluation of %s failed: %s, %s' %
1647 (function_name, e_value, traceback.format_exc()))
1648 ]
Scott Leecc2fe9b2020-11-19 19:38:06 +00001649
Bruce Dawson2bdc49f2021-05-21 19:13:03 +00001650 elapsed_time = time_time() - start_time
1651 if elapsed_time > 10.0:
Bruce Dawson6757d462022-07-13 04:04:40 +00001652 sys.stdout.write('%6.1fs to run %s from %s.\n' %
1653 (elapsed_time, function_name, presubmit_path))
Scott Leecc2fe9b2020-11-19 19:38:06 +00001654 if sink:
Erik Staab9f38b632022-10-31 14:05:24 +00001655 failure_reason = None
Scott Leecc2fe9b2020-11-19 19:38:06 +00001656 status = rdb_wrapper.STATUS_PASS
1657 if any(r.fatal for r in result):
1658 status = rdb_wrapper.STATUS_FAIL
Erik Staab9f38b632022-10-31 14:05:24 +00001659 failure_reasons = []
1660 for r in result:
1661 fields = r.json_format()
1662 message = fields['message']
1663 items = '\n'.join(' %s' % item for item in fields['items'])
1664 failure_reasons.append('\n'.join([message, items]))
1665 if failure_reasons:
1666 failure_reason = '\n'.join(failure_reasons)
1667 sink.report(function_name, status, elapsed_time, failure_reason)
Scott Leecc2fe9b2020-11-19 19:38:06 +00001668
1669 return result
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001670
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00001671 def _check_result_type(self, result):
1672 """Helper function which ensures result is a list, and all elements are
1673 instances of OutputApi.PresubmitResult"""
1674 if not isinstance(result, (tuple, list)):
1675 raise PresubmitFailure('Presubmit functions must return a tuple or list')
1676 if not all(isinstance(res, OutputApi.PresubmitResult) for res in result):
1677 raise PresubmitFailure(
1678 'All presubmit results must be of types derived from '
1679 'output_api.PresubmitResult')
1680
1681
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001682def DoPresubmitChecks(change,
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001683 committing,
1684 verbose,
maruel@chromium.orgb0dfd352009-06-10 14:12:54 +00001685 default_presubmit,
dpranke@chromium.org970c5222011-03-12 00:32:24 +00001686 may_prompt,
Aaron Gable668c1d82018-04-03 10:19:16 -07001687 gerrit_obj,
Edward Lesmes8e282792018-04-03 18:50:29 -04001688 dry_run=None,
Debrian Figueroadd2737e2019-06-21 23:50:13 +00001689 parallel=False,
Dirk Pranke6f0df682021-06-25 00:42:33 +00001690 json_output=None,
Bruce Dawson09c0c072022-05-26 20:28:58 +00001691 no_diffs=False):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001692 """Runs all presubmit checks that apply to the files in the change.
1693
1694 This finds all PRESUBMIT.py files in directories enclosing the files in the
1695 change (up to the repository root) and calls the relevant entrypoint function
1696 depending on whether the change is being committed or uploaded.
1697
1698 Prints errors, warnings and notifications. Prompts the user for warnings
1699 when needed.
1700
1701 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001702 change: The Change object.
agable92bec4f2016-08-24 09:27:27 -07001703 committing: True if 'git cl land' is running, False if 'git cl upload' is.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001704 verbose: Prints debug info.
maruel@chromium.org0ff1fab2009-05-22 13:08:15 +00001705 default_presubmit: A default presubmit script to execute in any case.
Quinten Yearsley516fe7f2016-12-14 11:50:18 -08001706 may_prompt: Enable (y/n) questions on warning or error. If False,
1707 any questions are answered with yes by default.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001708 gerrit_obj: provides basic Gerrit codereview functionality.
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001709 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -04001710 parallel: if true, all tests specified by input_api.RunTests in all
1711 PRESUBMIT files will be run in parallel.
Bruce Dawson09c0c072022-05-26 20:28:58 +00001712 no_diffs: if true, implies that --files or --all was specified so some
1713 checks can be skipped, and some errors will be messages.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001714 Return:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001715 1 if presubmit checks failed or 0 otherwise.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001716 """
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001717 old_environ = os.environ
1718 try:
1719 # Make sure python subprocesses won't generate .pyc files.
1720 os.environ = os.environ.copy()
Edward Lemurb9830242019-10-30 22:19:20 +00001721 os.environ['PYTHONDONTWRITEBYTECODE'] = '1'
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001722
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001723 python_version = 'Python %s' % sys.version_info.major
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001724 if committing:
Dirk Pranke6fc394f2021-05-26 23:25:14 +00001725 sys.stdout.write('Running %s presubmit commit checks ...\n' %
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001726 python_version)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001727 else:
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001728 sys.stdout.write('Running %s presubmit upload checks ...\n' %
1729 python_version)
Edward Lemurecc27072020-01-06 16:42:34 +00001730 start_time = time_time()
Josip Sokcevica9a7eec2023-03-10 03:54:52 +00001731 presubmit_files = ListRelevantPresubmitFiles(
1732 change.AbsoluteLocalPaths(), change.RepositoryRoot())
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001733 if not presubmit_files and verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001734 sys.stdout.write('Warning, no PRESUBMIT.py found.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001735 results = []
Bruce Dawsonc9f904f2022-10-14 20:59:49 +00001736 if sys.platform == 'win32':
1737 temp = os.environ['TEMP']
1738 else:
1739 temp = '/tmp'
1740 python2_usage_log_file = os.path.join(temp, 'python2_usage.txt')
Bruce Dawsonf2b04212022-06-10 16:42:54 +00001741 if os.path.exists(python2_usage_log_file):
1742 os.remove(python2_usage_log_file)
Edward Lesmes8e282792018-04-03 18:50:29 -04001743 thread_pool = ThreadPool()
Edward Lemur7e3c67f2018-07-20 20:52:49 +00001744 executer = PresubmitExecuter(change, committing, verbose, gerrit_obj,
Robert Iannucci3d6d2d22023-05-11 17:25:05 +00001745 dry_run, thread_pool, parallel, no_diffs)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001746 if default_presubmit:
1747 if verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001748 sys.stdout.write('Running default presubmit script.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001749 fake_path = os.path.join(change.RepositoryRoot(), 'PRESUBMIT.py')
Robert Iannucci3d6d2d22023-05-11 17:25:05 +00001750 results += executer.ExecPresubmitScript(default_presubmit, fake_path)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001751 for filename in presubmit_files:
1752 filename = os.path.abspath(filename)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001753 # Accept CRLF presubmit script.
Bruce Dawson6e70e862022-07-01 19:37:01 +00001754 presubmit_script = gclient_utils.FileRead(filename).replace('\r\n', '\n')
Robert Iannucci3d6d2d22023-05-11 17:25:05 +00001755 if verbose:
1756 sys.stdout.write('Running %s\n' % filename)
1757 results += executer.ExecPresubmitScript(presubmit_script, filename)
Bruce Dawson76fe1a72022-05-25 20:52:21 +00001758
Edward Lesmes8e282792018-04-03 18:50:29 -04001759 results += thread_pool.RunAsync()
1760
Bruce Dawsonf2b04212022-06-10 16:42:54 +00001761 if os.path.exists(python2_usage_log_file):
1762 with open(python2_usage_log_file) as f:
1763 python2_usage = [x.strip() for x in f.readlines()]
1764 results.append(
1765 OutputApi(committing).PresubmitPromptWarning(
1766 'Python 2 scripts were run during %s presubmits. Please see '
1767 'https://bugs.chromium.org/p/chromium/issues/detail?id=1313804'
1768 '#c61 for tips on resolving this.'
1769 % python_version,
1770 items=python2_usage))
1771
Edward Lemur6eb1d322020-02-27 22:20:15 +00001772 messages = {}
1773 should_prompt = False
1774 presubmits_failed = False
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001775 for result in results:
1776 if result.fatal:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001777 presubmits_failed = True
1778 messages.setdefault('ERRORS', []).append(result)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001779 elif result.should_prompt:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001780 should_prompt = True
1781 messages.setdefault('Warnings', []).append(result)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001782 else:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001783 messages.setdefault('Messages', []).append(result)
pam@chromium.orged9a0832009-09-09 22:48:55 +00001784
Bruce Dawson76fe1a72022-05-25 20:52:21 +00001785 # Print the different message types in a consistent order. ERRORS go last
1786 # so that they will be most visible in the local-presubmit output.
1787 for name in ['Messages', 'Warnings', 'ERRORS']:
1788 if name in messages:
1789 items = messages[name]
Gavin Makd22bf602022-07-11 21:10:41 +00001790 sys.stdout.write('** Presubmit %s: %d **\n' % (name, len(items)))
Bruce Dawson76fe1a72022-05-25 20:52:21 +00001791 for item in items:
1792 item.handle()
1793 sys.stdout.write('\n')
pam@chromium.orged9a0832009-09-09 22:48:55 +00001794
Edward Lemurecc27072020-01-06 16:42:34 +00001795 total_time = time_time() - start_time
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001796 if total_time > 1.0:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001797 sys.stdout.write(
Louis Romero4ca9e1c2022-03-10 10:29:11 +00001798 'Presubmit checks took %.1fs to calculate.\n' % total_time)
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +00001799
Edward Lemur6eb1d322020-02-27 22:20:15 +00001800 if not should_prompt and not presubmits_failed:
Louis Romero4ca9e1c2022-03-10 10:29:11 +00001801 sys.stdout.write('%s presubmit checks passed.\n\n' % python_version)
Josip Sokcevic7592e0a2022-01-12 00:57:54 +00001802 elif should_prompt and not presubmits_failed:
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001803 sys.stdout.write('There were %s presubmit warnings. ' % python_version)
Quinten Yearsley516fe7f2016-12-14 11:50:18 -08001804 if may_prompt:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001805 presubmits_failed = not prompt_should_continue(
1806 'Are you sure you wish to continue? (y/N): ')
Garrett Beatyacb807e2020-08-28 18:17:24 +00001807 else:
1808 sys.stdout.write('\n')
Bruce Dawson76fe1a72022-05-25 20:52:21 +00001809 else:
1810 sys.stdout.write('There were %s presubmit errors.\n' % python_version)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001811
Edward Lemur1dc66e12020-02-21 21:36:34 +00001812 if json_output:
1813 # Write the presubmit results to json output
1814 presubmit_results = {
1815 'errors': [
Edward Lemur6eb1d322020-02-27 22:20:15 +00001816 error.json_format()
1817 for error in messages.get('ERRORS', [])
Edward Lemur1dc66e12020-02-21 21:36:34 +00001818 ],
1819 'notifications': [
Edward Lemur6eb1d322020-02-27 22:20:15 +00001820 notification.json_format()
1821 for notification in messages.get('Messages', [])
Edward Lemur1dc66e12020-02-21 21:36:34 +00001822 ],
1823 'warnings': [
Edward Lemur6eb1d322020-02-27 22:20:15 +00001824 warning.json_format()
1825 for warning in messages.get('Warnings', [])
Edward Lemur1dc66e12020-02-21 21:36:34 +00001826 ],
Edward Lemur6eb1d322020-02-27 22:20:15 +00001827 'more_cc': executer.more_cc,
Edward Lemur1dc66e12020-02-21 21:36:34 +00001828 }
1829
1830 gclient_utils.FileWrite(
1831 json_output, json.dumps(presubmit_results, sort_keys=True))
1832
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001833 global _ASKED_FOR_FEEDBACK
1834 # Ask for feedback one time out of 5.
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +00001835 if (results and random.randint(0, 4) == 0 and not _ASKED_FOR_FEEDBACK):
Edward Lemur6eb1d322020-02-27 22:20:15 +00001836 sys.stdout.write(
maruel@chromium.org1ce8e662014-01-14 15:23:00 +00001837 'Was the presubmit check useful? If not, run "git cl presubmit -v"\n'
1838 'to figure out which PRESUBMIT.py was run, then run git blame\n'
1839 'on the file to figure out who to ask for help.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001840 _ASKED_FOR_FEEDBACK = True
Edward Lemur6eb1d322020-02-27 22:20:15 +00001841
1842 return 1 if presubmits_failed else 0
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001843 finally:
1844 os.environ = old_environ
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001845
1846
Edward Lemur50984a62020-02-06 18:10:18 +00001847def _scan_sub_dirs(mask, recursive):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001848 if not recursive:
pgervais@chromium.orge57b09d2014-05-07 00:58:13 +00001849 return [x for x in glob.glob(mask) if x not in ('.svn', '.git')]
Lei Zhang9611c4c2017-04-04 01:41:56 -07001850
1851 results = []
1852 for root, dirs, files in os.walk('.'):
1853 if '.svn' in dirs:
1854 dirs.remove('.svn')
1855 if '.git' in dirs:
1856 dirs.remove('.git')
1857 for name in files:
1858 if fnmatch.fnmatch(name, mask):
1859 results.append(os.path.join(root, name))
1860 return results
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001861
1862
Edward Lemur50984a62020-02-06 18:10:18 +00001863def _parse_files(args, recursive):
tobiasjs2836bcf2016-08-16 04:08:16 -07001864 logging.debug('Searching for %s', args)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001865 files = []
1866 for arg in args:
Edward Lemur50984a62020-02-06 18:10:18 +00001867 files.extend([('M', f) for f in _scan_sub_dirs(arg, recursive)])
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001868 return files
1869
1870
Edward Lemur50984a62020-02-06 18:10:18 +00001871def _parse_change(parser, options):
1872 """Process change options.
1873
1874 Args:
1875 parser: The parser used to parse the arguments from command line.
1876 options: The arguments parsed from command line.
1877 Returns:
Josip Sokcevic7958e302023-03-01 23:02:21 +00001878 A GitChange if the change root is a git repository, or a Change otherwise.
Edward Lemur50984a62020-02-06 18:10:18 +00001879 """
1880 if options.files and options.all_files:
1881 parser.error('<files> cannot be specified when --all-files is set.')
1882
Edward Lesmes44ea3ff2020-02-05 00:14:30 +00001883 change_scm = scm.determine_scm(options.root)
Edward Lemur50984a62020-02-06 18:10:18 +00001884 if change_scm != 'git' and not options.files:
1885 parser.error('<files> is not optional for unversioned directories.')
1886
1887 if options.files:
Josip Sokcevic017544d2022-03-31 23:47:53 +00001888 if options.source_controlled_only:
1889 # Get the filtered set of files from SCM.
1890 change_files = []
1891 for name in scm.GIT.GetAllFiles(options.root):
1892 for mask in options.files:
1893 if fnmatch.fnmatch(name, mask):
1894 change_files.append(('M', name))
1895 break
1896 else:
1897 # Get the filtered set of files from a directory scan.
1898 change_files = _parse_files(options.files, options.recursive)
Edward Lemur50984a62020-02-06 18:10:18 +00001899 elif options.all_files:
1900 change_files = [('M', f) for f in scm.GIT.GetAllFiles(options.root)]
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001901 else:
Edward Lemur50984a62020-02-06 18:10:18 +00001902 change_files = scm.GIT.CaptureStatus(
Edward Lemur7f6dec02020-02-06 20:23:58 +00001903 options.root, options.upstream or None)
Edward Lemur50984a62020-02-06 18:10:18 +00001904
1905 logging.info('Found %d file(s).', len(change_files))
1906
Josip Sokcevic7958e302023-03-01 23:02:21 +00001907 change_class = GitChange if change_scm == 'git' else Change
Edward Lemur50984a62020-02-06 18:10:18 +00001908 return change_class(
1909 options.name,
1910 options.description,
1911 options.root,
1912 change_files,
1913 options.issue,
1914 options.patchset,
1915 options.author,
1916 upstream=options.upstream)
1917
1918
1919def _parse_gerrit_options(parser, options):
1920 """Process gerrit options.
1921
1922 SIDE EFFECTS: Modifies options.author and options.description from Gerrit if
1923 options.gerrit_fetch is set.
1924
1925 Args:
1926 parser: The parser used to parse the arguments from command line.
1927 options: The arguments parsed from command line.
1928 Returns:
Stephen Martinisfb09de22021-02-25 03:41:13 +00001929 A GerritAccessor object if options.gerrit_url is set, or None otherwise.
Edward Lemur50984a62020-02-06 18:10:18 +00001930 """
1931 gerrit_obj = None
Stephen Martinisfb09de22021-02-25 03:41:13 +00001932 if options.gerrit_url:
Edward Lesmeseb1bd622021-03-01 19:54:07 +00001933 gerrit_obj = GerritAccessor(
1934 url=options.gerrit_url,
1935 project=options.gerrit_project,
1936 branch=options.gerrit_branch)
Edward Lemur50984a62020-02-06 18:10:18 +00001937
1938 if not options.gerrit_fetch:
1939 return gerrit_obj
1940
1941 if not options.gerrit_url or not options.issue or not options.patchset:
1942 parser.error(
1943 '--gerrit_fetch requires --gerrit_url, --issue and --patchset.')
1944
1945 options.author = gerrit_obj.GetChangeOwner(options.issue)
1946 options.description = gerrit_obj.GetChangeDescription(
1947 options.issue, options.patchset)
1948
1949 logging.info('Got author: "%s"', options.author)
1950 logging.info('Got description: """\n%s\n"""', options.description)
1951
1952 return gerrit_obj
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001953
1954
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001955@contextlib.contextmanager
1956def canned_check_filter(method_names):
1957 filtered = {}
1958 try:
1959 for method_name in method_names:
1960 if not hasattr(presubmit_canned_checks, method_name):
Gavin Make6a62332020-12-04 21:57:10 +00001961 logging.warning('Skipping unknown "canned" check %s' % method_name)
Aaron Gableecee74c2018-04-02 15:13:08 -07001962 continue
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001963 filtered[method_name] = getattr(presubmit_canned_checks, method_name)
1964 setattr(presubmit_canned_checks, method_name, lambda *_a, **_kw: [])
1965 yield
1966 finally:
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001967 for name, method in filtered.items():
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001968 setattr(presubmit_canned_checks, name, method)
1969
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +00001970
sbc@chromium.org013731e2015-02-26 18:28:43 +00001971def main(argv=None):
Edward Lemura5799e32020-01-17 19:26:51 +00001972 parser = argparse.ArgumentParser(usage='%(prog)s [options] <files...>')
1973 hooks = parser.add_mutually_exclusive_group()
1974 hooks.add_argument('-c', '--commit', action='store_true',
1975 help='Use commit instead of upload checks.')
1976 hooks.add_argument('-u', '--upload', action='store_false', dest='commit',
1977 help='Use upload instead of commit checks.')
Edward Lemur75526302020-02-27 22:31:05 +00001978 hooks.add_argument('--post_upload', action='store_true',
1979 help='Run post-upload commit hooks.')
Edward Lemura5799e32020-01-17 19:26:51 +00001980 parser.add_argument('-r', '--recursive', action='store_true',
1981 help='Act recursively.')
1982 parser.add_argument('-v', '--verbose', action='count', default=0,
1983 help='Use 2 times for more debug info.')
1984 parser.add_argument('--name', default='no name')
1985 parser.add_argument('--author')
Edward Lemur227d5102020-02-25 23:45:35 +00001986 desc = parser.add_mutually_exclusive_group()
1987 desc.add_argument('--description', default='', help='The change description.')
1988 desc.add_argument('--description_file',
1989 help='File to read change description from.')
Edward Lemura5799e32020-01-17 19:26:51 +00001990 parser.add_argument('--issue', type=int, default=0)
1991 parser.add_argument('--patchset', type=int, default=0)
1992 parser.add_argument('--root', default=os.getcwd(),
1993 help='Search for PRESUBMIT.py up to this directory. '
1994 'If inherit-review-settings-ok is present in this '
1995 'directory, parent directories up to the root file '
1996 'system directories will also be searched.')
1997 parser.add_argument('--upstream',
1998 help='Git only: the base ref or upstream branch against '
1999 'which the diff should be computed.')
2000 parser.add_argument('--default_presubmit')
2001 parser.add_argument('--may_prompt', action='store_true', default=False)
2002 parser.add_argument('--skip_canned', action='append', default=[],
2003 help='A list of checks to skip which appear in '
2004 'presubmit_canned_checks. Can be provided multiple times '
2005 'to skip multiple canned checks.')
2006 parser.add_argument('--dry_run', action='store_true', help=argparse.SUPPRESS)
2007 parser.add_argument('--gerrit_url', help=argparse.SUPPRESS)
Edward Lesmeseb1bd622021-03-01 19:54:07 +00002008 parser.add_argument('--gerrit_project', help=argparse.SUPPRESS)
2009 parser.add_argument('--gerrit_branch', help=argparse.SUPPRESS)
Edward Lemura5799e32020-01-17 19:26:51 +00002010 parser.add_argument('--gerrit_fetch', action='store_true',
2011 help=argparse.SUPPRESS)
2012 parser.add_argument('--parallel', action='store_true',
2013 help='Run all tests specified by input_api.RunTests in '
2014 'all PRESUBMIT files in parallel.')
2015 parser.add_argument('--json_output',
2016 help='Write presubmit errors to json output.')
Edward Lemur1dc66e12020-02-21 21:36:34 +00002017 parser.add_argument('--all_files', action='store_true',
Edward Lemur50984a62020-02-06 18:10:18 +00002018 help='Mark all files under source control as modified.')
Bruce Dawson09c0c072022-05-26 20:28:58 +00002019
Edward Lemura5799e32020-01-17 19:26:51 +00002020 parser.add_argument('files', nargs='*',
2021 help='List of files to be marked as modified when '
2022 'executing presubmit or post-upload hooks. fnmatch '
2023 'wildcards can also be used.')
Josip Sokcevic017544d2022-03-31 23:47:53 +00002024 parser.add_argument('--source_controlled_only', action='store_true',
2025 help='Constrain \'files\' to those in source control.')
Bruce Dawson09c0c072022-05-26 20:28:58 +00002026 parser.add_argument('--no_diffs', action='store_true',
2027 help='Assume that all "modified" files have no diffs.')
Edward Lemura5799e32020-01-17 19:26:51 +00002028 options = parser.parse_args(argv)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00002029
Erik Staabcca5c492020-04-16 17:40:07 +00002030 log_level = logging.ERROR
maruel@chromium.org899e1c12011-04-07 17:03:18 +00002031 if options.verbose >= 2:
Erik Staabcca5c492020-04-16 17:40:07 +00002032 log_level = logging.DEBUG
maruel@chromium.org899e1c12011-04-07 17:03:18 +00002033 elif options.verbose:
Erik Staabcca5c492020-04-16 17:40:07 +00002034 log_level = logging.INFO
2035 log_format = ('[%(levelname).1s%(asctime)s %(process)d %(thread)d '
2036 '%(filename)s] %(message)s')
2037 logging.basicConfig(format=log_format, level=log_level)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00002038
Bruce Dawsondca14bc2022-09-15 20:59:38 +00002039 # Print call stacks when _PresubmitResult objects are created with -v -v is
2040 # specified. This helps track down where presubmit messages are coming from.
2041 if options.verbose >= 2:
2042 global _SHOW_CALLSTACKS
2043 _SHOW_CALLSTACKS = True
2044
Edward Lemur227d5102020-02-25 23:45:35 +00002045 if options.description_file:
2046 options.description = gclient_utils.FileRead(options.description_file)
Edward Lemur50984a62020-02-06 18:10:18 +00002047 gerrit_obj = _parse_gerrit_options(parser, options)
2048 change = _parse_change(parser, options)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00002049
maruel@chromium.org899e1c12011-04-07 17:03:18 +00002050 try:
Edward Lemur75526302020-02-27 22:31:05 +00002051 if options.post_upload:
Robert Iannucci3d6d2d22023-05-11 17:25:05 +00002052 return DoPostUploadExecuter(change, gerrit_obj, options.verbose)
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00002053 with canned_check_filter(options.skip_canned):
Edward Lemur6eb1d322020-02-27 22:20:15 +00002054 return DoPresubmitChecks(
Edward Lemur50984a62020-02-06 18:10:18 +00002055 change,
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00002056 options.commit,
2057 options.verbose,
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00002058 options.default_presubmit,
2059 options.may_prompt,
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00002060 gerrit_obj,
Edward Lesmes8e282792018-04-03 18:50:29 -04002061 options.dry_run,
Debrian Figueroadd2737e2019-06-21 23:50:13 +00002062 options.parallel,
Dirk Pranke6f0df682021-06-25 00:42:33 +00002063 options.json_output,
Bruce Dawson09c0c072022-05-26 20:28:58 +00002064 options.no_diffs)
Raul Tambre7c938462019-05-24 16:35:35 +00002065 except PresubmitFailure as e:
Josip Sokcevica9a7eec2023-03-10 03:54:52 +00002066 import utils
Raul Tambre80ee78e2019-05-06 22:41:05 +00002067 print(e, file=sys.stderr)
2068 print('Maybe your depot_tools is out of date?', file=sys.stderr)
Josip Sokcevic0399e172022-03-21 23:11:51 +00002069 print('depot_tools version: %s' % utils.depot_tools_version(),
2070 file=sys.stderr)
maruel@chromium.org899e1c12011-04-07 17:03:18 +00002071 return 2
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00002072
2073
2074if __name__ == '__main__':
maruel@chromium.org35625c72011-03-23 17:34:02 +00002075 fix_encoding.fix_encoding()
sbc@chromium.org013731e2015-02-26 18:28:43 +00002076 try:
2077 sys.exit(main())
2078 except KeyboardInterrupt:
2079 sys.stderr.write('interrupted\n')
sergiybf8a3b382016-07-05 11:21:30 -07002080 sys.exit(2)