Edward Lemur | 0db01f0 | 2019-11-12 22:01:51 +0000 | [diff] [blame] | 1 | #!/usr/bin/env vpython3 |
| 2 | # coding=utf-8 |
maruel@chromium.org | eb5edbc | 2012-01-16 17:03:28 +0000 | [diff] [blame] | 3 | # Copyright (c) 2012 The Chromium Authors. All rights reserved. |
maruel@chromium.org | ddd5941 | 2011-11-30 14:20:38 +0000 | [diff] [blame] | 4 | # Use of this source code is governed by a BSD-style license that can be |
| 5 | # found in the LICENSE file. |
| 6 | |
| 7 | """Unit tests for git_cl.py.""" |
| 8 | |
Edward Lemur | 8515328 | 2020-02-14 22:06:29 +0000 | [diff] [blame] | 9 | from __future__ import print_function |
Edward Lemur | 0db01f0 | 2019-11-12 22:01:51 +0000 | [diff] [blame] | 10 | from __future__ import unicode_literals |
| 11 | |
Andrii Shyshkalov | d8aa49f | 2017-03-17 16:05:49 +0100 | [diff] [blame] | 12 | import datetime |
tandrii | de281ae | 2016-10-12 06:02:30 -0700 | [diff] [blame] | 13 | import json |
Andrii Shyshkalov | 18df0cd | 2017-01-25 15:22:20 +0100 | [diff] [blame] | 14 | import logging |
maruel@chromium.org | ddd5941 | 2011-11-30 14:20:38 +0000 | [diff] [blame] | 15 | import os |
Edward Lemur | 8515328 | 2020-02-14 22:06:29 +0000 | [diff] [blame] | 16 | import pprint |
Brian Sheedy | 59b06a8 | 2019-10-14 17:03:29 +0000 | [diff] [blame] | 17 | import shutil |
maruel@chromium.org | ddd5941 | 2011-11-30 14:20:38 +0000 | [diff] [blame] | 18 | import sys |
Aaron Gable | 9a03ae0 | 2017-11-03 11:31:07 -0700 | [diff] [blame] | 19 | import tempfile |
maruel@chromium.org | ddd5941 | 2011-11-30 14:20:38 +0000 | [diff] [blame] | 20 | import unittest |
| 21 | |
Edward Lemur | a814502 | 2020-01-06 18:47:54 +0000 | [diff] [blame] | 22 | if sys.version_info.major == 2: |
| 23 | from StringIO import StringIO |
| 24 | import mock |
| 25 | else: |
| 26 | from io import StringIO |
| 27 | from unittest import mock |
| 28 | |
maruel@chromium.org | ddd5941 | 2011-11-30 14:20:38 +0000 | [diff] [blame] | 29 | sys.path.insert(0, os.path.dirname(os.path.dirname(os.path.abspath(__file__)))) |
| 30 | |
Edward Lemur | 5ba1e9c | 2018-07-23 18:19:02 +0000 | [diff] [blame] | 31 | import metrics |
| 32 | # We have to disable monitoring before importing git_cl. |
| 33 | metrics.DISABLE_METRICS_COLLECTION = True |
| 34 | |
Edward Lemur | 1773f37 | 2020-02-22 00:27:14 +0000 | [diff] [blame] | 35 | import contextlib |
Jamie Madill | 5e96ad1 | 2020-01-13 16:08:35 +0000 | [diff] [blame] | 36 | import clang_format |
Edward Lemur | 1773f37 | 2020-02-22 00:27:14 +0000 | [diff] [blame] | 37 | import gclient_utils |
Eric Boren | 2fb6310 | 2018-10-05 13:05:03 +0000 | [diff] [blame] | 38 | import gerrit_util |
maruel@chromium.org | ddd5941 | 2011-11-30 14:20:38 +0000 | [diff] [blame] | 39 | import git_cl |
iannucci@chromium.org | 9e84927 | 2014-04-04 00:31:55 +0000 | [diff] [blame] | 40 | import git_common |
tandrii@chromium.org | 57d8654 | 2016-03-04 16:11:32 +0000 | [diff] [blame] | 41 | import git_footers |
Edward Lemur | 8515328 | 2020-02-14 22:06:29 +0000 | [diff] [blame] | 42 | import git_new_branch |
| 43 | import scm |
maruel@chromium.org | ddd5941 | 2011-11-30 14:20:38 +0000 | [diff] [blame] | 44 | import subprocess2 |
maruel@chromium.org | ddd5941 | 2011-11-30 14:20:38 +0000 | [diff] [blame] | 45 | |
Quinten Yearsley | d9cbe7a | 2019-09-03 16:49:11 +0000 | [diff] [blame] | 46 | |
Edward Lemur | 0db01f0 | 2019-11-12 22:01:51 +0000 | [diff] [blame] | 47 | def callError(code=1, cmd='', cwd='', stdout=b'', stderr=b''): |
tandrii | 5d48c32 | 2016-08-18 16:19:37 -0700 | [diff] [blame] | 48 | return subprocess2.CalledProcessError(code, cmd, cwd, stdout, stderr) |
| 49 | |
| 50 | |
Edward Lemur | 4c707a2 | 2019-09-24 21:13:43 +0000 | [diff] [blame] | 51 | def _constantFn(return_value): |
| 52 | def f(*args, **kwargs): |
| 53 | return return_value |
| 54 | return f |
| 55 | |
| 56 | |
tandrii | 5d48c32 | 2016-08-18 16:19:37 -0700 | [diff] [blame] | 57 | CERR1 = callError(1) |
| 58 | |
| 59 | |
Edward Lemur | 1773f37 | 2020-02-22 00:27:14 +0000 | [diff] [blame] | 60 | class TemporaryFileMock(object): |
| 61 | def __init__(self): |
| 62 | self.suffix = 0 |
Aaron Gable | 9a03ae0 | 2017-11-03 11:31:07 -0700 | [diff] [blame] | 63 | |
Edward Lemur | 1773f37 | 2020-02-22 00:27:14 +0000 | [diff] [blame] | 64 | @contextlib.contextmanager |
| 65 | def __call__(self): |
| 66 | self.suffix += 1 |
| 67 | yield '/tmp/fake-temp' + str(self.suffix) |
Aaron Gable | 9a03ae0 | 2017-11-03 11:31:07 -0700 | [diff] [blame] | 68 | |
| 69 | |
martiniss@chromium.org | d6648e2 | 2016-04-29 19:22:16 +0000 | [diff] [blame] | 70 | class ChangelistMock(object): |
| 71 | # A class variable so we can access it when we don't have access to the |
| 72 | # instance that's being set. |
Quinten Yearsley | d9cbe7a | 2019-09-03 16:49:11 +0000 | [diff] [blame] | 73 | desc = '' |
martiniss@chromium.org | d6648e2 | 2016-04-29 19:22:16 +0000 | [diff] [blame] | 74 | def __init__(self, **kwargs): |
| 75 | pass |
| 76 | def GetIssue(self): |
| 77 | return 1 |
Edward Lemur | 6c6827c | 2020-02-06 21:15:18 +0000 | [diff] [blame] | 78 | def FetchDescription(self): |
martiniss@chromium.org | d6648e2 | 2016-04-29 19:22:16 +0000 | [diff] [blame] | 79 | return ChangelistMock.desc |
dsansome | e2d6fd9 | 2016-09-08 00:10:47 -0700 | [diff] [blame] | 80 | def UpdateDescription(self, desc, force=False): |
martiniss@chromium.org | d6648e2 | 2016-04-29 19:22:16 +0000 | [diff] [blame] | 81 | ChangelistMock.desc = desc |
| 82 | |
tandrii | 5d48c32 | 2016-08-18 16:19:37 -0700 | [diff] [blame] | 83 | |
maruel@chromium.org | 2e72bb1 | 2012-01-17 15:18:35 +0000 | [diff] [blame] | 84 | class PresubmitMock(object): |
| 85 | def __init__(self, *args, **kwargs): |
| 86 | self.reviewers = [] |
Daniel Cheng | 7227d21 | 2017-11-17 08:12:37 -0800 | [diff] [blame] | 87 | self.more_cc = ['chromium-reviews+test-more-cc@chromium.org'] |
| 88 | |
maruel@chromium.org | 2e72bb1 | 2012-01-17 15:18:35 +0000 | [diff] [blame] | 89 | @staticmethod |
| 90 | def should_continue(): |
| 91 | return True |
| 92 | |
| 93 | |
Edward Lemur | 8515328 | 2020-02-14 22:06:29 +0000 | [diff] [blame] | 94 | class GitMocks(object): |
| 95 | def __init__(self, config=None, branchref=None): |
| 96 | self.branchref = branchref or 'refs/heads/master' |
| 97 | self.config = config or {} |
| 98 | |
| 99 | def GetBranchRef(self, _root): |
| 100 | return self.branchref |
| 101 | |
| 102 | def NewBranch(self, branchref): |
| 103 | self.branchref = branchref |
| 104 | |
Edward Lemur | 2696407 | 2020-02-19 19:18:51 +0000 | [diff] [blame] | 105 | def GetConfig(self, root, key, default=None): |
| 106 | if root != '': |
| 107 | key = '%s:%s' % (root, key) |
Edward Lemur | 8515328 | 2020-02-14 22:06:29 +0000 | [diff] [blame] | 108 | return self.config.get(key, default) |
| 109 | |
Edward Lemur | 2696407 | 2020-02-19 19:18:51 +0000 | [diff] [blame] | 110 | def SetConfig(self, root, key, value=None): |
| 111 | if root != '': |
| 112 | key = '%s:%s' % (root, key) |
Edward Lemur | 8515328 | 2020-02-14 22:06:29 +0000 | [diff] [blame] | 113 | if value: |
| 114 | self.config[key] = value |
| 115 | return |
| 116 | if key not in self.config: |
| 117 | raise CERR1 |
| 118 | del self.config[key] |
| 119 | |
| 120 | |
maruel@chromium.org | 2e72bb1 | 2012-01-17 15:18:35 +0000 | [diff] [blame] | 121 | class WatchlistsMock(object): |
| 122 | def __init__(self, _): |
| 123 | pass |
| 124 | @staticmethod |
| 125 | def GetWatchersForPaths(_): |
| 126 | return ['joe@example.com'] |
| 127 | |
| 128 | |
Edward Lemur | 4c707a2 | 2019-09-24 21:13:43 +0000 | [diff] [blame] | 129 | class CodereviewSettingsFileMock(object): |
| 130 | def __init__(self): |
| 131 | pass |
| 132 | # pylint: disable=no-self-use |
| 133 | def read(self): |
| 134 | return ('CODE_REVIEW_SERVER: gerrit.chromium.org\n' + |
| 135 | 'GERRIT_HOST: True\n') |
| 136 | |
| 137 | |
vadimsh@chromium.org | eed4df3 | 2015-04-10 21:30:20 +0000 | [diff] [blame] | 138 | class AuthenticatorMock(object): |
| 139 | def __init__(self, *_args): |
| 140 | pass |
| 141 | def has_cached_credentials(self): |
| 142 | return True |
tandrii | 221ab25 | 2016-10-06 08:12:04 -0700 | [diff] [blame] | 143 | def authorize(self, http): |
| 144 | return http |
vadimsh@chromium.org | eed4df3 | 2015-04-10 21:30:20 +0000 | [diff] [blame] | 145 | |
| 146 | |
Andrii Shyshkalov | bb86fbb | 2017-03-24 14:59:28 +0100 | [diff] [blame] | 147 | def CookiesAuthenticatorMockFactory(hosts_with_creds=None, same_auth=False): |
tandrii@chromium.org | fe30f18 | 2016-04-13 12:15:04 +0000 | [diff] [blame] | 148 | """Use to mock Gerrit/Git credentials from ~/.netrc or ~/.gitcookies. |
| 149 | |
| 150 | Usage: |
| 151 | >>> self.mock(git_cl.gerrit_util, "CookiesAuthenticator", |
Andrii Shyshkalov | bb86fbb | 2017-03-24 14:59:28 +0100 | [diff] [blame] | 152 | CookiesAuthenticatorMockFactory({'host': ('user', _, 'pass')}) |
tandrii@chromium.org | fe30f18 | 2016-04-13 12:15:04 +0000 | [diff] [blame] | 153 | |
| 154 | OR |
| 155 | >>> self.mock(git_cl.gerrit_util, "CookiesAuthenticator", |
Andrii Shyshkalov | bb86fbb | 2017-03-24 14:59:28 +0100 | [diff] [blame] | 156 | CookiesAuthenticatorMockFactory( |
| 157 | same_auth=('user', '', 'pass')) |
tandrii@chromium.org | fe30f18 | 2016-04-13 12:15:04 +0000 | [diff] [blame] | 158 | """ |
| 159 | class CookiesAuthenticatorMock(git_cl.gerrit_util.CookiesAuthenticator): |
Quinten Yearsley | b2cc4a9 | 2016-12-15 13:53:26 -0800 | [diff] [blame] | 160 | def __init__(self): # pylint: disable=super-init-not-called |
tandrii@chromium.org | fe30f18 | 2016-04-13 12:15:04 +0000 | [diff] [blame] | 161 | # Intentionally not calling super() because it reads actual cookie files. |
| 162 | pass |
| 163 | @classmethod |
| 164 | def get_gitcookies_path(cls): |
| 165 | return '~/.gitcookies' |
| 166 | @classmethod |
| 167 | def get_netrc_path(cls): |
| 168 | return '~/.netrc' |
Andrii Shyshkalov | bb86fbb | 2017-03-24 14:59:28 +0100 | [diff] [blame] | 169 | def _get_auth_for_host(self, host): |
| 170 | if same_auth: |
| 171 | return same_auth |
tandrii@chromium.org | fe30f18 | 2016-04-13 12:15:04 +0000 | [diff] [blame] | 172 | return (hosts_with_creds or {}).get(host) |
| 173 | return CookiesAuthenticatorMock |
| 174 | |
Aaron Gable | 9a03ae0 | 2017-11-03 11:31:07 -0700 | [diff] [blame] | 175 | |
kmarshall | 9249e01 | 2016-08-23 12:02:16 -0700 | [diff] [blame] | 176 | class MockChangelistWithBranchAndIssue(): |
| 177 | def __init__(self, branch, issue): |
| 178 | self.branch = branch |
| 179 | self.issue = issue |
| 180 | def GetBranch(self): |
| 181 | return self.branch |
| 182 | def GetIssue(self): |
| 183 | return self.issue |
tandrii@chromium.org | fe30f18 | 2016-04-13 12:15:04 +0000 | [diff] [blame] | 184 | |
tandrii | c2405f5 | 2016-10-10 08:13:15 -0700 | [diff] [blame] | 185 | |
| 186 | class SystemExitMock(Exception): |
| 187 | pass |
| 188 | |
| 189 | |
tandrii@chromium.org | f86c7d3 | 2016-04-01 19:27:30 +0000 | [diff] [blame] | 190 | class TestGitClBasic(unittest.TestCase): |
Edward Lemur | 6c6827c | 2020-02-06 21:15:18 +0000 | [diff] [blame] | 191 | def test_fetch_description(self): |
Edward Lemur | f38bc17 | 2019-09-03 21:02:13 +0000 | [diff] [blame] | 192 | cl = git_cl.Changelist(issue=1, codereview_host='host') |
Andrii Shyshkalov | 3186301 | 2017-02-08 11:35:12 +0100 | [diff] [blame] | 193 | cl.description = 'x' |
| 194 | cl.has_description = True |
Edward Lemur | 6c6827c | 2020-02-06 21:15:18 +0000 | [diff] [blame] | 195 | self.assertEqual(cl.FetchDescription(), 'x') |
Robert Iannucci | 09f1f3d | 2017-03-28 16:54:32 -0700 | [diff] [blame] | 196 | |
Andrii Shyshkalov | 71f0da3 | 2019-07-15 22:45:18 +0000 | [diff] [blame] | 197 | def test_set_preserve_tryjobs(self): |
| 198 | d = git_cl.ChangeDescription('Simple.') |
| 199 | d.set_preserve_tryjobs() |
| 200 | self.assertEqual(d.description.splitlines(), [ |
| 201 | 'Simple.', |
| 202 | '', |
| 203 | 'Cq-Do-Not-Cancel-Tryjobs: true', |
| 204 | ]) |
| 205 | before = d.description |
| 206 | d.set_preserve_tryjobs() |
| 207 | self.assertEqual(before, d.description) |
| 208 | |
| 209 | d = git_cl.ChangeDescription('\n'.join([ |
| 210 | 'One is enough', |
| 211 | '', |
| 212 | 'Cq-Do-Not-Cancel-Tryjobs: dups not encouraged, but don\'t hurt', |
| 213 | 'Change-Id: Ideadbeef', |
| 214 | ])) |
| 215 | d.set_preserve_tryjobs() |
| 216 | self.assertEqual(d.description.splitlines(), [ |
| 217 | 'One is enough', |
| 218 | '', |
| 219 | 'Cq-Do-Not-Cancel-Tryjobs: dups not encouraged, but don\'t hurt', |
| 220 | 'Change-Id: Ideadbeef', |
| 221 | 'Cq-Do-Not-Cancel-Tryjobs: true', |
| 222 | ]) |
| 223 | |
tandrii | f9aefb7 | 2016-07-01 09:06:51 -0700 | [diff] [blame] | 224 | def test_get_bug_line_values(self): |
| 225 | f = lambda p, bugs: list(git_cl._get_bug_line_values(p, bugs)) |
| 226 | self.assertEqual(f('', ''), []) |
| 227 | self.assertEqual(f('', '123,v8:456'), ['123', 'v8:456']) |
| 228 | self.assertEqual(f('v8', '456'), ['v8:456']) |
| 229 | self.assertEqual(f('v8', 'chromium:123,456'), ['v8:456', 'chromium:123']) |
| 230 | # Not nice, but not worth carying. |
| 231 | self.assertEqual(f('v8', 'chromium:123,456,v8:123'), |
| 232 | ['v8:456', 'chromium:123', 'v8:123']) |
| 233 | |
Andrii Shyshkalov | 15e50cc | 2016-12-02 14:34:08 +0100 | [diff] [blame] | 234 | def _test_git_number(self, parent_msg, dest_ref, child_msg, |
| 235 | parent_hash='parenthash'): |
| 236 | desc = git_cl.ChangeDescription(child_msg) |
| 237 | desc.update_with_git_number_footers(parent_hash, parent_msg, dest_ref) |
| 238 | return desc.description |
| 239 | |
| 240 | def assertEqualByLine(self, actual, expected): |
| 241 | self.assertEqual(actual.splitlines(), expected.splitlines()) |
| 242 | |
| 243 | def test_git_number_bad_parent(self): |
| 244 | with self.assertRaises(ValueError): |
| 245 | self._test_git_number('Parent', 'refs/heads/master', 'Child') |
| 246 | |
| 247 | def test_git_number_bad_parent_footer(self): |
| 248 | with self.assertRaises(AssertionError): |
| 249 | self._test_git_number( |
| 250 | 'Parent\n' |
| 251 | '\n' |
| 252 | 'Cr-Commit-Position: wrong', |
| 253 | 'refs/heads/master', 'Child') |
| 254 | |
| 255 | def test_git_number_bad_lineage_ignored(self): |
| 256 | actual = self._test_git_number( |
| 257 | 'Parent\n' |
| 258 | '\n' |
| 259 | 'Cr-Commit-Position: refs/heads/master@{#1}\n' |
| 260 | 'Cr-Branched-From: mustBeReal40CharHash-branch@{#pos}', |
| 261 | 'refs/heads/master', 'Child') |
| 262 | self.assertEqualByLine( |
| 263 | actual, |
| 264 | 'Child\n' |
| 265 | '\n' |
| 266 | 'Cr-Commit-Position: refs/heads/master@{#2}\n' |
| 267 | 'Cr-Branched-From: mustBeReal40CharHash-branch@{#pos}') |
| 268 | |
| 269 | def test_git_number_same_branch(self): |
| 270 | actual = self._test_git_number( |
| 271 | 'Parent\n' |
| 272 | '\n' |
| 273 | 'Cr-Commit-Position: refs/heads/master@{#12}', |
| 274 | dest_ref='refs/heads/master', |
| 275 | child_msg='Child') |
| 276 | self.assertEqualByLine( |
| 277 | actual, |
| 278 | 'Child\n' |
| 279 | '\n' |
| 280 | 'Cr-Commit-Position: refs/heads/master@{#13}') |
| 281 | |
Andrii Shyshkalov | de37c01 | 2017-07-06 21:06:50 +0200 | [diff] [blame] | 282 | def test_git_number_same_branch_mixed_footers(self): |
| 283 | actual = self._test_git_number( |
| 284 | 'Parent\n' |
| 285 | '\n' |
| 286 | 'Cr-Commit-Position: refs/heads/master@{#12}', |
| 287 | dest_ref='refs/heads/master', |
| 288 | child_msg='Child\n' |
| 289 | '\n' |
| 290 | 'Broken-by: design\n' |
| 291 | 'BUG=123') |
| 292 | self.assertEqualByLine( |
| 293 | actual, |
| 294 | 'Child\n' |
| 295 | '\n' |
| 296 | 'Broken-by: design\n' |
| 297 | 'BUG=123\n' |
| 298 | 'Cr-Commit-Position: refs/heads/master@{#13}') |
| 299 | |
Andrii Shyshkalov | 15e50cc | 2016-12-02 14:34:08 +0100 | [diff] [blame] | 300 | def test_git_number_same_branch_with_originals(self): |
| 301 | actual = self._test_git_number( |
| 302 | 'Parent\n' |
| 303 | '\n' |
| 304 | 'Cr-Commit-Position: refs/heads/master@{#12}', |
| 305 | dest_ref='refs/heads/master', |
| 306 | child_msg='Child\n' |
| 307 | '\n' |
| 308 | 'Some users are smart and insert their own footers\n' |
| 309 | '\n' |
| 310 | 'Cr-Whatever: value\n' |
| 311 | 'Cr-Commit-Position: refs/copy/paste@{#22}') |
| 312 | self.assertEqualByLine( |
| 313 | actual, |
| 314 | 'Child\n' |
| 315 | '\n' |
| 316 | 'Some users are smart and insert their own footers\n' |
| 317 | '\n' |
| 318 | 'Cr-Original-Whatever: value\n' |
| 319 | 'Cr-Original-Commit-Position: refs/copy/paste@{#22}\n' |
| 320 | 'Cr-Commit-Position: refs/heads/master@{#13}') |
| 321 | |
| 322 | def test_git_number_new_branch(self): |
| 323 | actual = self._test_git_number( |
| 324 | 'Parent\n' |
| 325 | '\n' |
| 326 | 'Cr-Commit-Position: refs/heads/master@{#12}', |
| 327 | dest_ref='refs/heads/branch', |
| 328 | child_msg='Child') |
| 329 | self.assertEqualByLine( |
| 330 | actual, |
| 331 | 'Child\n' |
| 332 | '\n' |
| 333 | 'Cr-Commit-Position: refs/heads/branch@{#1}\n' |
| 334 | 'Cr-Branched-From: parenthash-refs/heads/master@{#12}') |
| 335 | |
| 336 | def test_git_number_lineage(self): |
| 337 | actual = self._test_git_number( |
| 338 | 'Parent\n' |
| 339 | '\n' |
| 340 | 'Cr-Commit-Position: refs/heads/branch@{#1}\n' |
| 341 | 'Cr-Branched-From: somehash-refs/heads/master@{#12}', |
| 342 | dest_ref='refs/heads/branch', |
| 343 | child_msg='Child') |
| 344 | self.assertEqualByLine( |
| 345 | actual, |
| 346 | 'Child\n' |
| 347 | '\n' |
| 348 | 'Cr-Commit-Position: refs/heads/branch@{#2}\n' |
| 349 | 'Cr-Branched-From: somehash-refs/heads/master@{#12}') |
| 350 | |
| 351 | def test_git_number_moooooooore_lineage(self): |
| 352 | actual = self._test_git_number( |
| 353 | 'Parent\n' |
| 354 | '\n' |
| 355 | 'Cr-Commit-Position: refs/heads/branch@{#5}\n' |
| 356 | 'Cr-Branched-From: somehash-refs/heads/master@{#12}', |
| 357 | dest_ref='refs/heads/mooore', |
| 358 | child_msg='Child') |
| 359 | self.assertEqualByLine( |
| 360 | actual, |
| 361 | 'Child\n' |
| 362 | '\n' |
| 363 | 'Cr-Commit-Position: refs/heads/mooore@{#1}\n' |
| 364 | 'Cr-Branched-From: parenthash-refs/heads/branch@{#5}\n' |
| 365 | 'Cr-Branched-From: somehash-refs/heads/master@{#12}') |
| 366 | |
Andrii Shyshkalov | b5effa1 | 2016-12-14 19:35:12 +0100 | [diff] [blame] | 367 | def test_git_number_ever_moooooooore_lineage(self): |
Robert Iannucci | 456b0d6 | 2018-03-13 19:15:50 -0700 | [diff] [blame] | 368 | self.maxDiff = 10000 # pylint: disable=attribute-defined-outside-init |
Andrii Shyshkalov | b5effa1 | 2016-12-14 19:35:12 +0100 | [diff] [blame] | 369 | actual = self._test_git_number( |
| 370 | 'CQ commit on fresh new branch + numbering.\n' |
| 371 | '\n' |
| 372 | 'NOTRY=True\n' |
| 373 | 'NOPRESUBMIT=True\n' |
| 374 | 'BUG=\n' |
| 375 | '\n' |
| 376 | 'Review-Url: https://codereview.chromium.org/2577703003\n' |
| 377 | 'Cr-Commit-Position: refs/heads/gnumb-test/br@{#1}\n' |
| 378 | 'Cr-Branched-From: 0749ff9edc-refs/heads/gnumb-test/cq@{#4}\n' |
| 379 | 'Cr-Branched-From: 5c49df2da6-refs/heads/master@{#41618}', |
| 380 | dest_ref='refs/heads/gnumb-test/cl', |
| 381 | child_msg='git cl on fresh new branch + numbering.\n' |
| 382 | '\n' |
| 383 | 'Review-Url: https://codereview.chromium.org/2575043003 .\n') |
| 384 | self.assertEqualByLine( |
| 385 | actual, |
| 386 | 'git cl on fresh new branch + numbering.\n' |
| 387 | '\n' |
| 388 | 'Review-Url: https://codereview.chromium.org/2575043003 .\n' |
| 389 | 'Cr-Commit-Position: refs/heads/gnumb-test/cl@{#1}\n' |
| 390 | 'Cr-Branched-From: parenthash-refs/heads/gnumb-test/br@{#1}\n' |
| 391 | 'Cr-Branched-From: 0749ff9edc-refs/heads/gnumb-test/cq@{#4}\n' |
| 392 | 'Cr-Branched-From: 5c49df2da6-refs/heads/master@{#41618}') |
Andrii Shyshkalov | 15e50cc | 2016-12-02 14:34:08 +0100 | [diff] [blame] | 393 | |
| 394 | def test_git_number_cherry_pick(self): |
| 395 | actual = self._test_git_number( |
| 396 | 'Parent\n' |
| 397 | '\n' |
| 398 | 'Cr-Commit-Position: refs/heads/branch@{#1}\n' |
| 399 | 'Cr-Branched-From: somehash-refs/heads/master@{#12}', |
| 400 | dest_ref='refs/heads/branch', |
| 401 | child_msg='Child, which is cherry-pick from master\n' |
| 402 | '\n' |
| 403 | 'Cr-Commit-Position: refs/heads/master@{#100}\n' |
| 404 | '(cherry picked from commit deadbeef12345678deadbeef12345678deadbeef)') |
| 405 | self.assertEqualByLine( |
| 406 | actual, |
| 407 | 'Child, which is cherry-pick from master\n' |
| 408 | '\n' |
| 409 | '(cherry picked from commit deadbeef12345678deadbeef12345678deadbeef)\n' |
| 410 | '\n' |
| 411 | 'Cr-Original-Commit-Position: refs/heads/master@{#100}\n' |
| 412 | 'Cr-Commit-Position: refs/heads/branch@{#2}\n' |
| 413 | 'Cr-Branched-From: somehash-refs/heads/master@{#12}') |
| 414 | |
Edward Lemur | da4b6c6 | 2020-02-13 00:28:40 +0000 | [diff] [blame] | 415 | @mock.patch('gerrit_util.GetAccountDetails') |
| 416 | def test_valid_accounts(self, mockGetAccountDetails): |
Andrii Shyshkalov | ba7b0a4 | 2018-10-15 03:20:35 +0000 | [diff] [blame] | 417 | mock_per_account = { |
| 418 | 'u1': None, # 404, doesn't exist. |
| 419 | 'u2': { |
| 420 | '_account_id': 123124, |
| 421 | 'avatars': [], |
| 422 | 'email': 'u2@example.com', |
| 423 | 'name': 'User Number 2', |
| 424 | 'status': 'OOO', |
| 425 | }, |
| 426 | 'u3': git_cl.gerrit_util.GerritError(500, 'retries didn\'t help :('), |
| 427 | } |
| 428 | def GetAccountDetailsMock(_, account): |
| 429 | # Poor-man's mock library's side_effect. |
| 430 | v = mock_per_account.pop(account) |
| 431 | if isinstance(v, Exception): |
| 432 | raise v |
| 433 | return v |
| 434 | |
Edward Lemur | da4b6c6 | 2020-02-13 00:28:40 +0000 | [diff] [blame] | 435 | mockGetAccountDetails.side_effect = GetAccountDetailsMock |
| 436 | actual = git_cl.gerrit_util.ValidAccounts( |
| 437 | 'host', ['u1', 'u2', 'u3'], max_threads=1) |
Andrii Shyshkalov | ba7b0a4 | 2018-10-15 03:20:35 +0000 | [diff] [blame] | 438 | self.assertEqual(actual, { |
| 439 | 'u2': { |
| 440 | '_account_id': 123124, |
| 441 | 'avatars': [], |
| 442 | 'email': 'u2@example.com', |
| 443 | 'name': 'User Number 2', |
| 444 | 'status': 'OOO', |
| 445 | }, |
| 446 | }) |
| 447 | |
| 448 | |
Andrii Shyshkalov | 90f3192 | 2017-04-10 16:10:21 +0200 | [diff] [blame] | 449 | class TestParseIssueURL(unittest.TestCase): |
| 450 | def _validate(self, parsed, issue=None, patchset=None, hostname=None, |
Edward Lemur | f38bc17 | 2019-09-03 21:02:13 +0000 | [diff] [blame] | 451 | fail=False): |
Andrii Shyshkalov | 90f3192 | 2017-04-10 16:10:21 +0200 | [diff] [blame] | 452 | self.assertIsNotNone(parsed) |
| 453 | if fail: |
| 454 | self.assertFalse(parsed.valid) |
| 455 | return |
| 456 | self.assertTrue(parsed.valid) |
| 457 | self.assertEqual(parsed.issue, issue) |
| 458 | self.assertEqual(parsed.patchset, patchset) |
| 459 | self.assertEqual(parsed.hostname, hostname) |
Andrii Shyshkalov | 90f3192 | 2017-04-10 16:10:21 +0200 | [diff] [blame] | 460 | |
Edward Lemur | 678a684 | 2019-10-03 22:25:05 +0000 | [diff] [blame] | 461 | def test_ParseIssueNumberArgument(self): |
| 462 | def test(arg, *args, **kwargs): |
| 463 | self._validate(git_cl.ParseIssueNumberArgument(arg), *args, **kwargs) |
Andrii Shyshkalov | 90f3192 | 2017-04-10 16:10:21 +0200 | [diff] [blame] | 464 | |
Edward Lemur | 678a684 | 2019-10-03 22:25:05 +0000 | [diff] [blame] | 465 | test('123', 123) |
| 466 | test('', fail=True) |
| 467 | test('abc', fail=True) |
| 468 | test('123/1', fail=True) |
| 469 | test('123a', fail=True) |
| 470 | test('ssh://chrome-review.source.com/#/c/123/4/', fail=True) |
Andrii Shyshkalov | 90f3192 | 2017-04-10 16:10:21 +0200 | [diff] [blame] | 471 | |
Edward Lemur | 678a684 | 2019-10-03 22:25:05 +0000 | [diff] [blame] | 472 | test('https://codereview.source.com/123', |
| 473 | 123, None, 'codereview.source.com') |
Andrii Shyshkalov | 90f3192 | 2017-04-10 16:10:21 +0200 | [diff] [blame] | 474 | test('http://chrome-review.source.com/c/123', |
| 475 | 123, None, 'chrome-review.source.com') |
| 476 | test('https://chrome-review.source.com/c/123/', |
| 477 | 123, None, 'chrome-review.source.com') |
| 478 | test('https://chrome-review.source.com/c/123/4', |
| 479 | 123, 4, 'chrome-review.source.com') |
| 480 | test('https://chrome-review.source.com/#/c/123/4', |
| 481 | 123, 4, 'chrome-review.source.com') |
| 482 | test('https://chrome-review.source.com/c/123/4', |
| 483 | 123, 4, 'chrome-review.source.com') |
| 484 | test('https://chrome-review.source.com/123', |
| 485 | 123, None, 'chrome-review.source.com') |
| 486 | test('https://chrome-review.source.com/123/4', |
| 487 | 123, 4, 'chrome-review.source.com') |
| 488 | |
Edward Lemur | 678a684 | 2019-10-03 22:25:05 +0000 | [diff] [blame] | 489 | test('https://chrome-review.source.com/bad/123/4', fail=True) |
Andrii Shyshkalov | 90f3192 | 2017-04-10 16:10:21 +0200 | [diff] [blame] | 490 | test('https://chrome-review.source.com/c/123/1/whatisthis', fail=True) |
| 491 | test('https://chrome-review.source.com/c/abc/', fail=True) |
| 492 | test('ssh://chrome-review.source.com/c/123/1/', fail=True) |
| 493 | |
Andrii Shyshkalov | 90f3192 | 2017-04-10 16:10:21 +0200 | [diff] [blame] | 494 | |
| 495 | |
Edward Lemur | da4b6c6 | 2020-02-13 00:28:40 +0000 | [diff] [blame] | 496 | class GitCookiesCheckerTest(unittest.TestCase): |
Andrii Shyshkalov | 9780050 | 2017-03-16 16:04:32 +0100 | [diff] [blame] | 497 | def setUp(self): |
| 498 | super(GitCookiesCheckerTest, self).setUp() |
| 499 | self.c = git_cl._GitCookiesChecker() |
Andrii Shyshkalov | 0a0b067 | 2017-03-16 16:27:48 +0100 | [diff] [blame] | 500 | self.c._all_hosts = [] |
Edward Lemur | da4b6c6 | 2020-02-13 00:28:40 +0000 | [diff] [blame] | 501 | mock.patch('sys.stdout', StringIO()).start() |
| 502 | self.addCleanup(mock.patch.stopall) |
Andrii Shyshkalov | 9780050 | 2017-03-16 16:04:32 +0100 | [diff] [blame] | 503 | |
| 504 | def mock_hosts_creds(self, subhost_identity_pairs): |
| 505 | def ensure_googlesource(h): |
| 506 | if not h.endswith(self.c._GOOGLESOURCE): |
| 507 | assert not h.endswith('.') |
| 508 | return h + '.' + self.c._GOOGLESOURCE |
| 509 | return h |
| 510 | self.c._all_hosts = [(ensure_googlesource(h), i, '.gitcookies') |
| 511 | for h, i in subhost_identity_pairs] |
| 512 | |
Andrii Shyshkalov | 0d2dea0 | 2017-07-17 15:17:55 +0200 | [diff] [blame] | 513 | def test_identity_parsing(self): |
| 514 | self.assertEqual(self.c._parse_identity('ldap.google.com'), |
| 515 | ('ldap', 'google.com')) |
| 516 | self.assertEqual(self.c._parse_identity('git-ldap.example.com'), |
| 517 | ('ldap', 'example.com')) |
| 518 | # Specical case because we know there are no subdomains in chromium.org. |
| 519 | self.assertEqual(self.c._parse_identity('git-note.period.chromium.org'), |
| 520 | ('note.period', 'chromium.org')) |
Lei Zhang | d3f769a | 2017-12-15 15:16:14 -0800 | [diff] [blame] | 521 | # Pathological: ".period." can be either username OR domain, more likely |
| 522 | # domain. |
Andrii Shyshkalov | 0d2dea0 | 2017-07-17 15:17:55 +0200 | [diff] [blame] | 523 | self.assertEqual(self.c._parse_identity('git-note.period.example.com'), |
| 524 | ('note', 'period.example.com')) |
| 525 | |
Andrii Shyshkalov | 9780050 | 2017-03-16 16:04:32 +0100 | [diff] [blame] | 526 | def test_analysis_nothing(self): |
| 527 | self.c._all_hosts = [] |
| 528 | self.assertFalse(self.c.has_generic_host()) |
| 529 | self.assertEqual(set(), self.c.get_conflicting_hosts()) |
| 530 | self.assertEqual(set(), self.c.get_duplicated_hosts()) |
| 531 | self.assertEqual(set(), self.c.get_partially_configured_hosts()) |
| 532 | self.assertEqual(set(), self.c.get_hosts_with_wrong_identities()) |
| 533 | |
| 534 | def test_analysis(self): |
| 535 | self.mock_hosts_creds([ |
| 536 | ('.googlesource.com', 'git-example.chromium.org'), |
| 537 | |
| 538 | ('chromium', 'git-example.google.com'), |
| 539 | ('chromium-review', 'git-example.google.com'), |
| 540 | ('chrome-internal', 'git-example.chromium.org'), |
| 541 | ('chrome-internal-review', 'git-example.chromium.org'), |
| 542 | ('conflict', 'git-example.google.com'), |
| 543 | ('conflict-review', 'git-example.chromium.org'), |
| 544 | ('dup', 'git-example.google.com'), |
| 545 | ('dup', 'git-example.google.com'), |
| 546 | ('dup-review', 'git-example.google.com'), |
| 547 | ('partial', 'git-example.google.com'), |
Andrii Shyshkalov | c817382 | 2017-07-10 12:10:53 +0200 | [diff] [blame] | 548 | ('gpartial-review', 'git-example.google.com'), |
Andrii Shyshkalov | 9780050 | 2017-03-16 16:04:32 +0100 | [diff] [blame] | 549 | ]) |
| 550 | self.assertTrue(self.c.has_generic_host()) |
| 551 | self.assertEqual(set(['conflict.googlesource.com']), |
| 552 | self.c.get_conflicting_hosts()) |
| 553 | self.assertEqual(set(['dup.googlesource.com']), |
| 554 | self.c.get_duplicated_hosts()) |
Andrii Shyshkalov | c817382 | 2017-07-10 12:10:53 +0200 | [diff] [blame] | 555 | self.assertEqual(set(['partial.googlesource.com', |
| 556 | 'gpartial-review.googlesource.com']), |
Andrii Shyshkalov | 9780050 | 2017-03-16 16:04:32 +0100 | [diff] [blame] | 557 | self.c.get_partially_configured_hosts()) |
| 558 | self.assertEqual(set(['chromium.googlesource.com', |
| 559 | 'chrome-internal.googlesource.com']), |
| 560 | self.c.get_hosts_with_wrong_identities()) |
| 561 | |
Andrii Shyshkalov | 0a0b067 | 2017-03-16 16:27:48 +0100 | [diff] [blame] | 562 | def test_report_no_problems(self): |
| 563 | self.test_analysis_nothing() |
Andrii Shyshkalov | 0a0b067 | 2017-03-16 16:27:48 +0100 | [diff] [blame] | 564 | self.assertFalse(self.c.find_and_report_problems()) |
| 565 | self.assertEqual(sys.stdout.getvalue(), '') |
| 566 | |
Edward Lemur | da4b6c6 | 2020-02-13 00:28:40 +0000 | [diff] [blame] | 567 | @mock.patch( |
| 568 | 'git_cl.gerrit_util.CookiesAuthenticator.get_gitcookies_path', |
| 569 | return_value='~/.gitcookies') |
| 570 | def test_report(self, *_mocks): |
Andrii Shyshkalov | 0a0b067 | 2017-03-16 16:27:48 +0100 | [diff] [blame] | 571 | self.test_analysis() |
Andrii Shyshkalov | 0a0b067 | 2017-03-16 16:27:48 +0100 | [diff] [blame] | 572 | self.assertTrue(self.c.find_and_report_problems()) |
| 573 | with open(os.path.join(os.path.dirname(__file__), |
| 574 | 'git_cl_creds_check_report.txt')) as f: |
| 575 | expected = f.read() |
| 576 | def by_line(text): |
| 577 | return [l.rstrip() for l in text.rstrip().splitlines()] |
Robert Iannucci | 456b0d6 | 2018-03-13 19:15:50 -0700 | [diff] [blame] | 578 | self.maxDiff = 10000 # pylint: disable=attribute-defined-outside-init |
Andrii Shyshkalov | 4812e61 | 2017-03-27 17:22:57 +0200 | [diff] [blame] | 579 | self.assertEqual(by_line(sys.stdout.getvalue().strip()), by_line(expected)) |
Andrii Shyshkalov | 9780050 | 2017-03-16 16:04:32 +0100 | [diff] [blame] | 580 | |
Nodir Turakulov | d0e2cd2 | 2017-11-15 10:22:06 -0800 | [diff] [blame] | 581 | |
Edward Lemur | da4b6c6 | 2020-02-13 00:28:40 +0000 | [diff] [blame] | 582 | class TestGitCl(unittest.TestCase): |
maruel@chromium.org | ddd5941 | 2011-11-30 14:20:38 +0000 | [diff] [blame] | 583 | def setUp(self): |
| 584 | super(TestGitCl, self).setUp() |
| 585 | self.calls = [] |
tandrii | 9d20675 | 2016-06-20 11:32:47 -0700 | [diff] [blame] | 586 | self._calls_done = [] |
Edward Lemur | da4b6c6 | 2020-02-13 00:28:40 +0000 | [diff] [blame] | 587 | mock.patch('sys.stdout', StringIO()).start() |
| 588 | mock.patch( |
| 589 | 'git_cl.time_time', |
| 590 | lambda: self._mocked_call('time.time')).start() |
| 591 | mock.patch( |
| 592 | 'git_cl.metrics.collector.add_repeated', |
| 593 | lambda *a: self._mocked_call('add_repeated', *a)).start() |
| 594 | mock.patch('subprocess2.call', self._mocked_call).start() |
| 595 | mock.patch('subprocess2.check_call', self._mocked_call).start() |
| 596 | mock.patch('subprocess2.check_output', self._mocked_call).start() |
| 597 | mock.patch( |
| 598 | 'subprocess2.communicate', |
| 599 | lambda *a, **_k: ([self._mocked_call(*a), ''], 0)).start() |
| 600 | mock.patch( |
| 601 | 'git_cl.gclient_utils.CheckCallAndFilter', |
| 602 | self._mocked_call).start() |
| 603 | mock.patch('git_common.is_dirty_git_tree', lambda x: False).start() |
| 604 | mock.patch( |
| 605 | 'git_common.get_or_create_merge_base', |
| 606 | lambda *a: self._mocked_call('get_or_create_merge_base', *a)).start() |
| 607 | mock.patch('git_cl.BranchExists', return_value=True).start() |
| 608 | mock.patch('git_cl.FindCodereviewSettingsFile', return_value='').start() |
| 609 | mock.patch( |
| 610 | 'git_cl.SaveDescriptionBackup', |
| 611 | lambda _: self._mocked_call('SaveDescriptionBackup')).start() |
| 612 | mock.patch( |
| 613 | 'git_cl.ask_for_data', |
| 614 | lambda prompt: self._mocked_call('ask_for_data', prompt)).start() |
| 615 | mock.patch( |
| 616 | 'git_cl.write_json', |
| 617 | lambda *a: self._mocked_call('write_json', *a)).start() |
| 618 | mock.patch( |
| 619 | 'git_cl.presubmit_support.DoPresubmitChecks', PresubmitMock).start() |
| 620 | mock.patch('git_cl.watchlists.Watchlists', WatchlistsMock).start() |
| 621 | mock.patch('git_cl.auth.Authenticator', AuthenticatorMock).start() |
Edward Lesmes | 7677e5c | 2020-02-19 20:39:03 +0000 | [diff] [blame] | 622 | mock.patch('gerrit_util.GetChangeDetail').start() |
Edward Lemur | da4b6c6 | 2020-02-13 00:28:40 +0000 | [diff] [blame] | 623 | mock.patch( |
| 624 | 'git_cl.gerrit_util.GetChangeComments', |
| 625 | lambda *a: self._mocked_call('GetChangeComments', *a)).start() |
| 626 | mock.patch( |
| 627 | 'git_cl.gerrit_util.GetChangeRobotComments', |
| 628 | lambda *a: self._mocked_call('GetChangeRobotComments', *a)).start() |
| 629 | mock.patch( |
| 630 | 'git_cl.gerrit_util.AddReviewers', |
| 631 | lambda *a: self._mocked_call('AddReviewers', *a)).start() |
| 632 | mock.patch( |
| 633 | 'git_cl.gerrit_util.SetReview', |
| 634 | lambda h, i, msg=None, labels=None, notify=None, ready=None: ( |
| 635 | self._mocked_call( |
| 636 | 'SetReview', h, i, msg, labels, notify, ready))).start() |
| 637 | mock.patch( |
| 638 | 'git_cl.gerrit_util.LuciContextAuthenticator.is_luci', |
| 639 | return_value=False).start() |
| 640 | mock.patch( |
| 641 | 'git_cl.gerrit_util.GceAuthenticator.is_gce', |
| 642 | return_value=False).start() |
| 643 | mock.patch( |
| 644 | 'git_cl.gerrit_util.ValidAccounts', |
| 645 | lambda *a: self._mocked_call('ValidAccounts', *a)).start() |
Edward Lemur | d55c507 | 2020-02-20 01:09:07 +0000 | [diff] [blame] | 646 | mock.patch('sys.exit', side_effect=SystemExitMock).start() |
Edward Lemur | 15a9b8c | 2020-02-13 00:52:30 +0000 | [diff] [blame] | 647 | mock.patch('git_cl.Settings.GetRoot', return_value='').start() |
Edward Lemur | 8515328 | 2020-02-14 22:06:29 +0000 | [diff] [blame] | 648 | self.mockGit = GitMocks() |
| 649 | mock.patch('scm.GIT.GetBranchRef', self.mockGit.GetBranchRef).start() |
| 650 | mock.patch('scm.GIT.GetConfig', self.mockGit.GetConfig).start() |
| 651 | mock.patch('scm.GIT.SetConfig', self.mockGit.SetConfig).start() |
Edward Lemur | 8410164 | 2020-02-21 21:40:34 +0000 | [diff] [blame] | 652 | mock.patch( |
| 653 | 'git_new_branch.create_new_branch', self.mockGit.NewBranch).start() |
Edward Lemur | 15a9b8c | 2020-02-13 00:52:30 +0000 | [diff] [blame] | 654 | mock.patch( |
Edward Lemur | 8515328 | 2020-02-14 22:06:29 +0000 | [diff] [blame] | 655 | 'scm.GIT.FetchUpstreamTuple', |
Edward Lemur | 15a9b8c | 2020-02-13 00:52:30 +0000 | [diff] [blame] | 656 | return_value=('origin', 'refs/heads/master')).start() |
Edward Lemur | 8515328 | 2020-02-14 22:06:29 +0000 | [diff] [blame] | 657 | mock.patch( |
| 658 | 'scm.GIT.CaptureStatus', return_value=[('M', 'foo.txt')]).start() |
maruel@chromium.org | ddd5941 | 2011-11-30 14:20:38 +0000 | [diff] [blame] | 659 | # It's important to reset settings to not have inter-tests interference. |
| 660 | git_cl.settings = None |
Edward Lemur | da4b6c6 | 2020-02-13 00:28:40 +0000 | [diff] [blame] | 661 | self.addCleanup(mock.patch.stopall) |
maruel@chromium.org | ddd5941 | 2011-11-30 14:20:38 +0000 | [diff] [blame] | 662 | |
| 663 | def tearDown(self): |
wychen@chromium.org | 445c896 | 2015-04-28 23:30:05 +0000 | [diff] [blame] | 664 | try: |
Raphael Kubo da Costa | e9342a7 | 2019-10-14 17:49:39 +0000 | [diff] [blame] | 665 | self.assertEqual([], self.calls) |
Andrii Shyshkalov | 18df0cd | 2017-01-25 15:22:20 +0100 | [diff] [blame] | 666 | except AssertionError: |
Edward Lemur | 8515328 | 2020-02-14 22:06:29 +0000 | [diff] [blame] | 667 | calls = ''.join(' %s\n' % str(call) for call in self.calls[:5]) |
| 668 | if len(self.calls) > 5: |
| 669 | calls += ' ...\n' |
| 670 | self.fail( |
| 671 | '\n' |
| 672 | 'There are un-consumed calls after this test has finished:\n' + |
| 673 | calls) |
wychen@chromium.org | 445c896 | 2015-04-28 23:30:05 +0000 | [diff] [blame] | 674 | finally: |
| 675 | super(TestGitCl, self).tearDown() |
maruel@chromium.org | ddd5941 | 2011-11-30 14:20:38 +0000 | [diff] [blame] | 676 | |
iannucci@chromium.org | 9e84927 | 2014-04-04 00:31:55 +0000 | [diff] [blame] | 677 | def _mocked_call(self, *args, **_kwargs): |
maruel@chromium.org | 2e72bb1 | 2012-01-17 15:18:35 +0000 | [diff] [blame] | 678 | self.assertTrue( |
| 679 | self.calls, |
tandrii | 9d20675 | 2016-06-20 11:32:47 -0700 | [diff] [blame] | 680 | '@%d Expected: <Missing> Actual: %r' % (len(self._calls_done), args)) |
wychen@chromium.org | a872e75 | 2015-04-28 23:42:18 +0000 | [diff] [blame] | 681 | top = self.calls.pop(0) |
wychen@chromium.org | a872e75 | 2015-04-28 23:42:18 +0000 | [diff] [blame] | 682 | expected_args, result = top |
| 683 | |
maruel@chromium.org | e52678e | 2013-04-26 18:34:44 +0000 | [diff] [blame] | 684 | # Also logs otherwise it could get caught in a try/finally and be hard to |
| 685 | # diagnose. |
| 686 | if expected_args != args: |
tandrii | 9d20675 | 2016-06-20 11:32:47 -0700 | [diff] [blame] | 687 | N = 5 |
Quinten Yearsley | d9cbe7a | 2019-09-03 16:49:11 +0000 | [diff] [blame] | 688 | prior_calls = '\n '.join( |
tandrii | 9d20675 | 2016-06-20 11:32:47 -0700 | [diff] [blame] | 689 | '@%d: %r' % (len(self._calls_done) - N + i, c[0]) |
| 690 | for i, c in enumerate(self._calls_done[-N:])) |
| 691 | following_calls = '\n '.join( |
| 692 | '@%d: %r' % (len(self._calls_done) + i + 1, c[0]) |
| 693 | for i, c in enumerate(self.calls[:N])) |
| 694 | extended_msg = ( |
| 695 | 'A few prior calls:\n %s\n\n' |
| 696 | 'This (expected):\n @%d: %r\n' |
| 697 | 'This (actual):\n @%d: %r\n\n' |
| 698 | 'A few following expected calls:\n %s' % |
| 699 | (prior_calls, len(self._calls_done), expected_args, |
| 700 | len(self._calls_done), args, following_calls)) |
tandrii | 9d20675 | 2016-06-20 11:32:47 -0700 | [diff] [blame] | 701 | |
tandrii | 99a72f2 | 2016-08-17 14:33:24 -0700 | [diff] [blame] | 702 | self.fail('@%d\n' |
| 703 | ' Expected: %r\n' |
Edward Lemur | 2696407 | 2020-02-19 19:18:51 +0000 | [diff] [blame] | 704 | ' Actual: %r\n' |
| 705 | '\n' |
| 706 | '%s' % ( |
| 707 | len(self._calls_done), expected_args, args, extended_msg)) |
tandrii | 9d20675 | 2016-06-20 11:32:47 -0700 | [diff] [blame] | 708 | |
| 709 | self._calls_done.append(top) |
tandrii | 5d48c32 | 2016-08-18 16:19:37 -0700 | [diff] [blame] | 710 | if isinstance(result, Exception): |
| 711 | raise result |
Edward Lemur | 0db01f0 | 2019-11-12 22:01:51 +0000 | [diff] [blame] | 712 | # stdout from git commands is supposed to be a bytestream. Convert it here |
| 713 | # instead of converting all test output in this file to bytes. |
| 714 | if args[0][0] == 'git' and not isinstance(result, bytes): |
| 715 | result = result.encode('utf-8') |
maruel@chromium.org | 2e72bb1 | 2012-01-17 15:18:35 +0000 | [diff] [blame] | 716 | return result |
| 717 | |
Andrii Shyshkalov | abc26ac | 2017-03-14 14:49:38 +0100 | [diff] [blame] | 718 | def test_ask_for_explicit_yes_true(self): |
| 719 | self.calls = [ |
| 720 | (('ask_for_data', 'prompt [Yes/No]: '), 'blah'), |
| 721 | (('ask_for_data', 'Please, type yes or no: '), 'ye'), |
| 722 | ] |
| 723 | self.assertTrue(git_cl.ask_for_explicit_yes('prompt')) |
| 724 | |
tandrii | 48df581 | 2016-10-17 03:55:37 -0700 | [diff] [blame] | 725 | def test_LoadCodereviewSettingsFromFile_gerrit(self): |
Edward Lemur | 79d4f99 | 2019-11-11 23:49:02 +0000 | [diff] [blame] | 726 | codereview_file = StringIO('GERRIT_HOST: true') |
tandrii | 48df581 | 2016-10-17 03:55:37 -0700 | [diff] [blame] | 727 | self.calls = [ |
| 728 | ((['git', 'config', '--unset-all', 'rietveld.cc'],), CERR1), |
tandrii | 48df581 | 2016-10-17 03:55:37 -0700 | [diff] [blame] | 729 | ((['git', 'config', '--unset-all', 'rietveld.tree-status-url'],), CERR1), |
| 730 | ((['git', 'config', '--unset-all', 'rietveld.viewvc-url'],), CERR1), |
| 731 | ((['git', 'config', '--unset-all', 'rietveld.bug-prefix'],), CERR1), |
| 732 | ((['git', 'config', '--unset-all', 'rietveld.cpplint-regex'],), CERR1), |
tandrii | 48df581 | 2016-10-17 03:55:37 -0700 | [diff] [blame] | 733 | ((['git', 'config', '--unset-all', 'rietveld.cpplint-ignore-regex'],), |
| 734 | CERR1), |
tandrii | 48df581 | 2016-10-17 03:55:37 -0700 | [diff] [blame] | 735 | ((['git', 'config', '--unset-all', 'rietveld.run-post-upload-hook'],), |
| 736 | CERR1), |
Jamie Madill | dc4d19e | 2019-10-24 21:50:02 +0000 | [diff] [blame] | 737 | ((['git', 'config', '--unset-all', 'rietveld.format-full-by-default'],), |
| 738 | CERR1), |
tandrii | 48df581 | 2016-10-17 03:55:37 -0700 | [diff] [blame] | 739 | ((['git', 'config', 'gerrit.host', 'true'],), ''), |
| 740 | ] |
| 741 | self.assertIsNone(git_cl.LoadCodereviewSettingsFromFile(codereview_file)) |
| 742 | |
ilevy@chromium.org | 0f58fa8 | 2012-11-05 01:45:20 +0000 | [diff] [blame] | 743 | @classmethod |
Andrii Shyshkalov | 5c3d0b3 | 2017-02-16 17:47:31 +0100 | [diff] [blame] | 744 | def _gerrit_base_calls(cls, issue=None, fetched_description=None, |
Andrii Shyshkalov | 550e924 | 2017-04-12 17:14:49 +0200 | [diff] [blame] | 745 | fetched_status=None, other_cl_owner=None, |
Anthony Polito | 8b95534 | 2019-09-24 19:01:36 +0000 | [diff] [blame] | 746 | custom_cl_base=None, short_hostname='chromium', |
| 747 | change_id=None): |
Edward Lemur | 2696407 | 2020-02-19 19:18:51 +0000 | [diff] [blame] | 748 | calls = [] |
Andrii Shyshkalov | 550e924 | 2017-04-12 17:14:49 +0200 | [diff] [blame] | 749 | if custom_cl_base: |
| 750 | ancestor_revision = custom_cl_base |
| 751 | else: |
| 752 | # Determine ancestor_revision to be merge base. |
| 753 | ancestor_revision = 'fake_ancestor_sha' |
| 754 | calls += [ |
Edward Lemur | da4b6c6 | 2020-02-13 00:28:40 +0000 | [diff] [blame] | 755 | (('get_or_create_merge_base', 'master', 'refs/remotes/origin/master'), |
| 756 | ancestor_revision), |
Andrii Shyshkalov | 550e924 | 2017-04-12 17:14:49 +0200 | [diff] [blame] | 757 | ] |
| 758 | |
Andrii Shyshkalov | 0293956 | 2017-02-16 17:47:17 +0100 | [diff] [blame] | 759 | if issue: |
Edward Lesmes | 7677e5c | 2020-02-19 20:39:03 +0000 | [diff] [blame] | 760 | gerrit_util.GetChangeDetail.return_value = { |
| 761 | 'owner': {'email': (other_cl_owner or 'owner@example.com')}, |
| 762 | 'change_id': (change_id or '123456789'), |
| 763 | 'current_revision': 'sha1_of_current_revision', |
| 764 | 'revisions': {'sha1_of_current_revision': { |
| 765 | 'commit': {'message': fetched_description}, |
| 766 | }}, |
| 767 | 'status': fetched_status or 'NEW', |
| 768 | } |
Andrii Shyshkalov | 5c3d0b3 | 2017-02-16 17:47:31 +0100 | [diff] [blame] | 769 | if fetched_status == 'ABANDONED': |
Andrii Shyshkalov | 5c3d0b3 | 2017-02-16 17:47:31 +0100 | [diff] [blame] | 770 | return calls |
Andrii Shyshkalov | bb86fbb | 2017-03-24 14:59:28 +0100 | [diff] [blame] | 771 | if other_cl_owner: |
| 772 | calls += [ |
| 773 | (('ask_for_data', 'Press Enter to upload, or Ctrl+C to abort'), ''), |
| 774 | ] |
Andrii Shyshkalov | 0293956 | 2017-02-16 17:47:17 +0100 | [diff] [blame] | 775 | |
Andrii Shyshkalov | 0293956 | 2017-02-16 17:47:17 +0100 | [diff] [blame] | 776 | calls += [ |
Andrii Shyshkalov | 550e924 | 2017-04-12 17:14:49 +0200 | [diff] [blame] | 777 | ((['git', 'rev-parse', 'HEAD'],), '12345'), |
Andrii Shyshkalov | 0293956 | 2017-02-16 17:47:17 +0100 | [diff] [blame] | 778 | ] |
| 779 | |
| 780 | if not issue: |
| 781 | calls += [ |
Andrii Shyshkalov | 550e924 | 2017-04-12 17:14:49 +0200 | [diff] [blame] | 782 | ((['git', 'log', '--pretty=format:%s%n%n%b', |
| 783 | ancestor_revision + '...'],), |
ilevy@chromium.org | 0f58fa8 | 2012-11-05 01:45:20 +0000 | [diff] [blame] | 784 | 'foo'), |
Andrii Shyshkalov | 0293956 | 2017-02-16 17:47:17 +0100 | [diff] [blame] | 785 | ] |
| 786 | |
| 787 | calls += [ |
Andrii Shyshkalov | 550e924 | 2017-04-12 17:14:49 +0200 | [diff] [blame] | 788 | ((['git', 'config', 'user.email'],), 'me@example.com'), |
Edward Lemur | 2c48f24 | 2019-06-04 16:14:09 +0000 | [diff] [blame] | 789 | (('time.time',), 1000,), |
| 790 | (('time.time',), 3000,), |
| 791 | (('add_repeated', 'sub_commands', { |
| 792 | 'execution_time': 2000, |
| 793 | 'command': 'presubmit', |
| 794 | 'exit_code': 0 |
| 795 | }), None,), |
Andrii Shyshkalov | 550e924 | 2017-04-12 17:14:49 +0200 | [diff] [blame] | 796 | ((['git', 'diff', '--no-ext-diff', '--stat', '-l100000', '-C50'] + |
| 797 | ([custom_cl_base] if custom_cl_base else |
| 798 | [ancestor_revision, 'HEAD']),), |
| 799 | '+dat'), |
Andrii Shyshkalov | 0293956 | 2017-02-16 17:47:17 +0100 | [diff] [blame] | 800 | ] |
| 801 | return calls |
ukai@chromium.org | e807781 | 2012-02-03 03:41:46 +0000 | [diff] [blame] | 802 | |
Edward Lemur | 2696407 | 2020-02-19 19:18:51 +0000 | [diff] [blame] | 803 | def _gerrit_upload_calls(self, description, reviewers, squash, |
tandrii | a60502f | 2016-06-20 02:01:53 -0700 | [diff] [blame] | 804 | squash_mode='default', |
tandrii@chromium.org | 1062500 | 2016-03-04 20:03:47 +0000 | [diff] [blame] | 805 | expected_upstream_ref='origin/refs/heads/master', |
Aaron Gable | fd23808 | 2017-06-07 13:42:34 -0700 | [diff] [blame] | 806 | title=None, notify=False, |
Andrii Shyshkalov | e9c78ff | 2017-02-06 15:53:13 +0100 | [diff] [blame] | 807 | post_amend_description=None, issue=None, cc=None, |
Andrii Shyshkalov | 0da5e8f | 2018-10-30 17:29:18 +0000 | [diff] [blame] | 808 | custom_cl_base=None, tbr=None, |
Andrii Shyshkalov | e7a7fc4 | 2018-10-30 17:35:09 +0000 | [diff] [blame] | 809 | short_hostname='chromium', |
Edward Lemur | 1b52d87 | 2019-05-09 21:12:12 +0000 | [diff] [blame] | 810 | labels=None, change_id=None, original_title=None, |
Anthony Polito | 8b95534 | 2019-09-24 19:01:36 +0000 | [diff] [blame] | 811 | final_description=None, gitcookies_exists=True, |
Josip | e827b0f | 2020-01-30 00:07:20 +0000 | [diff] [blame] | 812 | force=False, edit_description=None): |
tandrii@chromium.org | 1062500 | 2016-03-04 20:03:47 +0000 | [diff] [blame] | 813 | if post_amend_description is None: |
| 814 | post_amend_description = description |
bradnelson | d975b30 | 2016-10-23 12:20:23 -0700 | [diff] [blame] | 815 | cc = cc or [] |
Andrii Shyshkalov | 550e924 | 2017-04-12 17:14:49 +0200 | [diff] [blame] | 816 | # Determined in `_gerrit_base_calls`. |
| 817 | determined_ancestor_revision = custom_cl_base or 'fake_ancestor_sha' |
| 818 | |
| 819 | calls = [] |
tandrii@chromium.org | 512d79c | 2016-03-31 12:55:28 +0000 | [diff] [blame] | 820 | |
Edward Lemur | 2696407 | 2020-02-19 19:18:51 +0000 | [diff] [blame] | 821 | if squash_mode in ('override_squash', 'override_nosquash'): |
| 822 | self.mockGit.config['gerrit.override-squash-uploads'] = ( |
| 823 | 'true' if squash_mode == 'override_squash' else 'false') |
tandrii | a60502f | 2016-06-20 02:01:53 -0700 | [diff] [blame] | 824 | |
tandrii@chromium.org | 512d79c | 2016-03-31 12:55:28 +0000 | [diff] [blame] | 825 | # If issue is given, then description is fetched from Gerrit instead. |
| 826 | if issue is None: |
tandrii@chromium.org | 512d79c | 2016-03-31 12:55:28 +0000 | [diff] [blame] | 827 | calls += [ |
Andrii Shyshkalov | 550e924 | 2017-04-12 17:14:49 +0200 | [diff] [blame] | 828 | ((['git', 'log', '--pretty=format:%s\n\n%b', |
| 829 | ((custom_cl_base + '..') if custom_cl_base else |
| 830 | 'fake_ancestor_sha..HEAD')],), |
| 831 | description), |
| 832 | ] |
Aaron Gable | b56ad33 | 2017-01-06 15:24:31 -0800 | [diff] [blame] | 833 | if squash: |
Andrii Shyshkalov | febbae9 | 2017-04-05 15:05:20 +0000 | [diff] [blame] | 834 | title = 'Initial_upload' |
Aaron Gable | b56ad33 | 2017-01-06 15:24:31 -0800 | [diff] [blame] | 835 | else: |
| 836 | if not title: |
| 837 | calls += [ |
Andrii Shyshkalov | 550e924 | 2017-04-12 17:14:49 +0200 | [diff] [blame] | 838 | ((['git', 'show', '-s', '--format=%s', 'HEAD'],), ''), |
| 839 | (('ask_for_data', 'Title for patchset []: '), 'User input'), |
Aaron Gable | b56ad33 | 2017-01-06 15:24:31 -0800 | [diff] [blame] | 840 | ] |
Andrii Shyshkalov | febbae9 | 2017-04-05 15:05:20 +0000 | [diff] [blame] | 841 | title = 'User_input' |
tandrii@chromium.org | 57d8654 | 2016-03-04 16:11:32 +0000 | [diff] [blame] | 842 | if not git_footers.get_footer_change_id(description) and not squash: |
sivachandra@chromium.org | aebe87f | 2012-10-22 20:34:21 +0000 | [diff] [blame] | 843 | calls += [ |
Andrii Shyshkalov | 550e924 | 2017-04-12 17:14:49 +0200 | [diff] [blame] | 844 | (('DownloadGerritHook', False), ''), |
| 845 | # Amending of commit message to get the Change-Id. |
| 846 | ((['git', 'log', '--pretty=format:%s\n\n%b', |
| 847 | determined_ancestor_revision + '..HEAD'],), |
| 848 | description), |
| 849 | ((['git', 'commit', '--amend', '-m', description],), ''), |
| 850 | ((['git', 'log', '--pretty=format:%s\n\n%b', |
| 851 | determined_ancestor_revision + '..HEAD'],), |
| 852 | post_amend_description) |
| 853 | ] |
bauerb@chromium.org | 27386dd | 2015-02-16 10:45:39 +0000 | [diff] [blame] | 854 | if squash: |
Anthony Polito | 8b95534 | 2019-09-24 19:01:36 +0000 | [diff] [blame] | 855 | if force or not issue: |
Anthony Polito | 8b95534 | 2019-09-24 19:01:36 +0000 | [diff] [blame] | 856 | if not force: |
| 857 | calls += [ |
Anthony Polito | 8b95534 | 2019-09-24 19:01:36 +0000 | [diff] [blame] | 858 | ((['RunEditor'],), description), |
| 859 | ] |
Josip | e827b0f | 2020-01-30 00:07:20 +0000 | [diff] [blame] | 860 | # user wants to edit description |
| 861 | if edit_description: |
| 862 | calls += [ |
Josip | e827b0f | 2020-01-30 00:07:20 +0000 | [diff] [blame] | 863 | ((['RunEditor'],), edit_description), |
| 864 | ] |
bauerb@chromium.org | 27386dd | 2015-02-16 10:45:39 +0000 | [diff] [blame] | 865 | ref_to_push = 'abcdef0123456789' |
| 866 | calls += [ |
Andrii Shyshkalov | 550e924 | 2017-04-12 17:14:49 +0200 | [diff] [blame] | 867 | ] |
| 868 | |
| 869 | if custom_cl_base is None: |
| 870 | calls += [ |
Edward Lemur | da4b6c6 | 2020-02-13 00:28:40 +0000 | [diff] [blame] | 871 | (('get_or_create_merge_base', 'master', 'refs/remotes/origin/master'), |
bauerb@chromium.org | 27386dd | 2015-02-16 10:45:39 +0000 | [diff] [blame] | 872 | 'origin/master'), |
Andrii Shyshkalov | 550e924 | 2017-04-12 17:14:49 +0200 | [diff] [blame] | 873 | ] |
| 874 | parent = 'origin/master' |
| 875 | else: |
| 876 | calls += [ |
| 877 | ((['git', 'merge-base', '--is-ancestor', custom_cl_base, |
| 878 | 'refs/remotes/origin/master'],), |
| 879 | callError(1)), # Means not ancenstor. |
| 880 | (('ask_for_data', |
| 881 | 'Do you take responsibility for cleaning up potential mess ' |
| 882 | 'resulting from proceeding with upload? Press Enter to upload, ' |
| 883 | 'or Ctrl+C to abort'), ''), |
| 884 | ] |
| 885 | parent = custom_cl_base |
| 886 | |
| 887 | calls += [ |
| 888 | ((['git', 'rev-parse', 'HEAD:'],), # `HEAD:` means HEAD's tree hash. |
| 889 | '0123456789abcdef'), |
Edward Lemur | 1773f37 | 2020-02-22 00:27:14 +0000 | [diff] [blame] | 890 | ((['FileWrite', '/tmp/fake-temp1', description],), None), |
Andrii Shyshkalov | 550e924 | 2017-04-12 17:14:49 +0200 | [diff] [blame] | 891 | ((['git', 'commit-tree', '0123456789abcdef', '-p', parent, |
Edward Lemur | 1773f37 | 2020-02-22 00:27:14 +0000 | [diff] [blame] | 892 | '-F', '/tmp/fake-temp1'],), |
Andrii Shyshkalov | 550e924 | 2017-04-12 17:14:49 +0200 | [diff] [blame] | 893 | ref_to_push), |
| 894 | ] |
bauerb@chromium.org | 27386dd | 2015-02-16 10:45:39 +0000 | [diff] [blame] | 895 | else: |
| 896 | ref_to_push = 'HEAD' |
| 897 | |
sivachandra@chromium.org | aebe87f | 2012-10-22 20:34:21 +0000 | [diff] [blame] | 898 | calls += [ |
Andrii Shyshkalov | d9fdc1f | 2018-09-27 02:13:09 +0000 | [diff] [blame] | 899 | (('SaveDescriptionBackup',), None), |
Andrii Shyshkalov | 550e924 | 2017-04-12 17:14:49 +0200 | [diff] [blame] | 900 | ((['git', 'rev-list', |
| 901 | (custom_cl_base if custom_cl_base else expected_upstream_ref) + '..' + |
| 902 | ref_to_push],), |
| 903 | '1hashPerLine\n'), |
| 904 | ] |
tandrii@chromium.org | 8da4540 | 2016-05-24 23:11:03 +0000 | [diff] [blame] | 905 | |
Edward Lemur | 01f4a4f | 2018-11-03 00:40:38 +0000 | [diff] [blame] | 906 | metrics_arguments = [] |
| 907 | |
Aaron Gable | afd5277 | 2017-06-27 16:40:10 -0700 | [diff] [blame] | 908 | if notify: |
Aaron Gable | 844cf29 | 2017-06-28 11:32:59 -0700 | [diff] [blame] | 909 | ref_suffix = '%ready,notify=ALL' |
Edward Lemur | 01f4a4f | 2018-11-03 00:40:38 +0000 | [diff] [blame] | 910 | metrics_arguments += ['ready', 'notify=ALL'] |
Aaron Gable | 844cf29 | 2017-06-28 11:32:59 -0700 | [diff] [blame] | 911 | else: |
Jamie Madill | 276da0b | 2018-04-27 14:41:20 -0400 | [diff] [blame] | 912 | if not issue and squash: |
Aaron Gable | 844cf29 | 2017-06-28 11:32:59 -0700 | [diff] [blame] | 913 | ref_suffix = '%wip' |
Edward Lemur | 01f4a4f | 2018-11-03 00:40:38 +0000 | [diff] [blame] | 914 | metrics_arguments.append('wip') |
Aaron Gable | 844cf29 | 2017-06-28 11:32:59 -0700 | [diff] [blame] | 915 | else: |
| 916 | ref_suffix = '%notify=NONE' |
Edward Lemur | 01f4a4f | 2018-11-03 00:40:38 +0000 | [diff] [blame] | 917 | metrics_arguments.append('notify=NONE') |
Aaron Gable | 9b713dd | 2016-12-14 16:04:21 -0800 | [diff] [blame] | 918 | |
Aaron Gable | 70f4e24 | 2017-06-26 10:45:59 -0700 | [diff] [blame] | 919 | if title: |
Aaron Gable | afd5277 | 2017-06-27 16:40:10 -0700 | [diff] [blame] | 920 | ref_suffix += ',m=' + title |
Edward Lemur | 01f4a4f | 2018-11-03 00:40:38 +0000 | [diff] [blame] | 921 | metrics_arguments.append('m') |
Andrii Shyshkalov | febbae9 | 2017-04-05 15:05:20 +0000 | [diff] [blame] | 922 | |
Andrii Shyshkalov | 0da5e8f | 2018-10-30 17:29:18 +0000 | [diff] [blame] | 923 | if short_hostname == 'chromium': |
| 924 | # All reviwers and ccs get into ref_suffix. |
| 925 | for r in sorted(reviewers): |
| 926 | ref_suffix += ',r=%s' % r |
Edward Lemur | 01f4a4f | 2018-11-03 00:40:38 +0000 | [diff] [blame] | 927 | metrics_arguments.append('r') |
Edward Lemur | 4508b42 | 2019-10-03 21:56:35 +0000 | [diff] [blame] | 928 | if issue is None: |
| 929 | cc += ['chromium-reviews+test-more-cc@chromium.org', 'joe@example.com'] |
| 930 | for c in sorted(cc): |
Andrii Shyshkalov | 0da5e8f | 2018-10-30 17:29:18 +0000 | [diff] [blame] | 931 | ref_suffix += ',cc=%s' % c |
Edward Lemur | 01f4a4f | 2018-11-03 00:40:38 +0000 | [diff] [blame] | 932 | metrics_arguments.append('cc') |
Andrii Shyshkalov | 0da5e8f | 2018-10-30 17:29:18 +0000 | [diff] [blame] | 933 | reviewers, cc = [], [] |
| 934 | else: |
| 935 | # TODO(crbug/877717): remove this case. |
| 936 | calls += [ |
| 937 | (('ValidAccounts', '%s-review.googlesource.com' % short_hostname, |
| 938 | sorted(reviewers) + ['joe@example.com', |
| 939 | 'chromium-reviews+test-more-cc@chromium.org'] + cc), |
| 940 | { |
| 941 | e: {'email': e} |
| 942 | for e in (reviewers + ['joe@example.com'] + cc) |
| 943 | }) |
| 944 | ] |
| 945 | for r in sorted(reviewers): |
| 946 | if r != 'bad-account-or-email': |
| 947 | ref_suffix += ',r=%s' % r |
Edward Lemur | 01f4a4f | 2018-11-03 00:40:38 +0000 | [diff] [blame] | 948 | metrics_arguments.append('r') |
Andrii Shyshkalov | 0da5e8f | 2018-10-30 17:29:18 +0000 | [diff] [blame] | 949 | reviewers.remove(r) |
Edward Lemur | 4508b42 | 2019-10-03 21:56:35 +0000 | [diff] [blame] | 950 | if issue is None: |
| 951 | cc += ['joe@example.com'] |
| 952 | for c in sorted(cc): |
Andrii Shyshkalov | 0da5e8f | 2018-10-30 17:29:18 +0000 | [diff] [blame] | 953 | ref_suffix += ',cc=%s' % c |
Edward Lemur | 01f4a4f | 2018-11-03 00:40:38 +0000 | [diff] [blame] | 954 | metrics_arguments.append('cc') |
Andrii Shyshkalov | 0da5e8f | 2018-10-30 17:29:18 +0000 | [diff] [blame] | 955 | if c in cc: |
| 956 | cc.remove(c) |
Andrii Shyshkalov | 76988a8 | 2018-10-15 03:12:25 +0000 | [diff] [blame] | 957 | |
Edward Lemur | 687ca90 | 2018-12-05 02:30:30 +0000 | [diff] [blame] | 958 | for k, v in sorted((labels or {}).items()): |
| 959 | ref_suffix += ',l=%s+%d' % (k, v) |
| 960 | metrics_arguments.append('l=%s+%d' % (k, v)) |
| 961 | |
| 962 | if tbr: |
| 963 | calls += [ |
| 964 | (('GetCodeReviewTbrScore', |
| 965 | '%s-review.googlesource.com' % short_hostname, |
| 966 | 'my/repo'), |
| 967 | 2,), |
| 968 | ] |
Andrii Shyshkalov | e7a7fc4 | 2018-10-30 17:35:09 +0000 | [diff] [blame] | 969 | |
Edward Lemur | 01f4a4f | 2018-11-03 00:40:38 +0000 | [diff] [blame] | 970 | calls += [ |
| 971 | (('time.time',), 1000,), |
| 972 | ((['git', 'push', |
| 973 | 'https://%s.googlesource.com/my/repo' % short_hostname, |
| 974 | ref_to_push + ':refs/for/refs/heads/master' + ref_suffix],), |
| 975 | (('remote:\n' |
| 976 | 'remote: Processing changes: (\)\n' |
| 977 | 'remote: Processing changes: (|)\n' |
| 978 | 'remote: Processing changes: (/)\n' |
| 979 | 'remote: Processing changes: (-)\n' |
| 980 | 'remote: Processing changes: new: 1 (/)\n' |
| 981 | 'remote: Processing changes: new: 1, done\n' |
| 982 | 'remote:\n' |
| 983 | 'remote: New Changes:\n' |
| 984 | 'remote: https://%s-review.googlesource.com/#/c/my/repo/+/123456' |
| 985 | ' XXX\n' |
| 986 | 'remote:\n' |
| 987 | 'To https://%s.googlesource.com/my/repo\n' |
| 988 | ' * [new branch] hhhh -> refs/for/refs/heads/master\n' |
| 989 | ) % (short_hostname, short_hostname)),), |
| 990 | (('time.time',), 2000,), |
| 991 | (('add_repeated', |
| 992 | 'sub_commands', |
| 993 | { |
| 994 | 'execution_time': 1000, |
| 995 | 'command': 'git push', |
| 996 | 'exit_code': 0, |
| 997 | 'arguments': sorted(metrics_arguments), |
| 998 | }), |
| 999 | None,), |
| 1000 | ] |
| 1001 | |
Edward Lemur | 1b52d87 | 2019-05-09 21:12:12 +0000 | [diff] [blame] | 1002 | final_description = final_description or post_amend_description.strip() |
| 1003 | original_title = original_title or title or '<untitled>' |
| 1004 | # Trace-related calls |
| 1005 | calls += [ |
| 1006 | # Write a description with context for the current trace. |
| 1007 | ((['FileWrite', 'TRACES_DIR/20170316T200041.000000-README', |
Edward Lemur | 75391d4 | 2019-05-14 23:35:56 +0000 | [diff] [blame] | 1008 | 'Thu Mar 16 20:00:41 2017\n' |
| 1009 | '%(short_hostname)s-review.googlesource.com\n' |
| 1010 | '%(change_id)s\n' |
| 1011 | '%(title)s\n' |
| 1012 | '%(description)s\n' |
| 1013 | '1000\n' |
| 1014 | '0\n' |
| 1015 | '%(trace_name)s' % { |
Edward Lemur | 1b52d87 | 2019-05-09 21:12:12 +0000 | [diff] [blame] | 1016 | 'short_hostname': short_hostname, |
| 1017 | 'change_id': change_id, |
| 1018 | 'description': final_description, |
| 1019 | 'title': original_title, |
Edward Lemur | 75391d4 | 2019-05-14 23:35:56 +0000 | [diff] [blame] | 1020 | 'trace_name': 'TRACES_DIR/20170316T200041.000000', |
Edward Lemur | 1b52d87 | 2019-05-09 21:12:12 +0000 | [diff] [blame] | 1021 | }],), |
| 1022 | None, |
| 1023 | ), |
| 1024 | # Read traces and shorten git hashes. |
| 1025 | ((['os.path.isfile', 'TEMP_DIR/trace-packet'],), |
| 1026 | True, |
| 1027 | ), |
| 1028 | ((['FileRead', 'TEMP_DIR/trace-packet'],), |
| 1029 | ('git-hash: 0123456789012345678901234567890123456789\n' |
| 1030 | 'git-hash: abcdeabcdeabcdeabcdeabcdeabcdeabcdeabcde\n'), |
| 1031 | ), |
| 1032 | ((['FileWrite', 'TEMP_DIR/trace-packet', |
| 1033 | 'git-hash: 012345\n' |
| 1034 | 'git-hash: abcdea\n'],), |
| 1035 | None, |
| 1036 | ), |
| 1037 | # Make zip file for the git traces. |
| 1038 | ((['make_archive', 'TRACES_DIR/20170316T200041.000000-traces', 'zip', |
| 1039 | 'TEMP_DIR'],), |
| 1040 | None, |
| 1041 | ), |
| 1042 | # Collect git config and gitcookies. |
| 1043 | ((['git', 'config', '-l'],), |
| 1044 | 'git-config-output', |
| 1045 | ), |
| 1046 | ((['FileWrite', 'TEMP_DIR/git-config', 'git-config-output'],), |
| 1047 | None, |
| 1048 | ), |
| 1049 | ((['os.path.isfile', '~/.gitcookies'],), |
| 1050 | gitcookies_exists, |
| 1051 | ), |
| 1052 | ] |
| 1053 | if gitcookies_exists: |
| 1054 | calls += [ |
| 1055 | ((['FileRead', '~/.gitcookies'],), |
| 1056 | 'gitcookies 1/SECRET', |
| 1057 | ), |
| 1058 | ((['FileWrite', 'TEMP_DIR/gitcookies', 'gitcookies REDACTED'],), |
| 1059 | None, |
| 1060 | ), |
| 1061 | ] |
| 1062 | calls += [ |
| 1063 | # Make zip file for the git config and gitcookies. |
| 1064 | ((['make_archive', 'TRACES_DIR/20170316T200041.000000-git-info', 'zip', |
| 1065 | 'TEMP_DIR'],), |
| 1066 | None, |
| 1067 | ), |
| 1068 | ] |
| 1069 | |
Andrii Shyshkalov | 0da5e8f | 2018-10-30 17:29:18 +0000 | [diff] [blame] | 1070 | # TODO(crbug/877717): this should never be used. |
| 1071 | if squash and short_hostname != 'chromium': |
Andrii Shyshkalov | 0ec9d15 | 2018-08-23 00:22:58 +0000 | [diff] [blame] | 1072 | calls += [ |
| 1073 | (('AddReviewers', |
Andrii Shyshkalov | 1e82867 | 2018-08-23 22:34:37 +0000 | [diff] [blame] | 1074 | 'chromium-review.googlesource.com', 'my%2Frepo~123456', |
Andrii Shyshkalov | 0ec9d15 | 2018-08-23 00:22:58 +0000 | [diff] [blame] | 1075 | sorted(reviewers), |
Andrii Shyshkalov | 2f72791 | 2018-10-15 17:02:33 +0000 | [diff] [blame] | 1076 | cc + ['chromium-reviews+test-more-cc@chromium.org'], |
| 1077 | notify), |
| 1078 | ''), |
Andrii Shyshkalov | 0ec9d15 | 2018-08-23 00:22:58 +0000 | [diff] [blame] | 1079 | ] |
Edward Lemur | 2696407 | 2020-02-19 19:18:51 +0000 | [diff] [blame] | 1080 | calls += [ |
| 1081 | ((['git', 'rev-parse', 'HEAD'],), 'hash'), |
| 1082 | ] |
ukai@chromium.org | e807781 | 2012-02-03 03:41:46 +0000 | [diff] [blame] | 1083 | return calls |
| 1084 | |
sivachandra@chromium.org | aebe87f | 2012-10-22 20:34:21 +0000 | [diff] [blame] | 1085 | def _run_gerrit_upload_test( |
ukai@chromium.org | e807781 | 2012-02-03 03:41:46 +0000 | [diff] [blame] | 1086 | self, |
| 1087 | upload_args, |
| 1088 | description, |
tandrii@chromium.org | bf766ba | 2016-04-13 12:51:23 +0000 | [diff] [blame] | 1089 | reviewers=None, |
tandrii | a60502f | 2016-06-20 02:01:53 -0700 | [diff] [blame] | 1090 | squash=True, |
| 1091 | squash_mode=None, |
tandrii@chromium.org | 1062500 | 2016-03-04 20:03:47 +0000 | [diff] [blame] | 1092 | expected_upstream_ref='origin/refs/heads/master', |
Aaron Gable | 9b713dd | 2016-12-14 16:04:21 -0800 | [diff] [blame] | 1093 | title=None, |
tandrii@chromium.org | 8da4540 | 2016-05-24 23:11:03 +0000 | [diff] [blame] | 1094 | notify=False, |
tandrii@chromium.org | 512d79c | 2016-03-31 12:55:28 +0000 | [diff] [blame] | 1095 | post_amend_description=None, |
bradnelson | d975b30 | 2016-10-23 12:20:23 -0700 | [diff] [blame] | 1096 | issue=None, |
Andrii Shyshkalov | e9c78ff | 2017-02-06 15:53:13 +0100 | [diff] [blame] | 1097 | cc=None, |
Andrii Shyshkalov | bb86fbb | 2017-03-24 14:59:28 +0100 | [diff] [blame] | 1098 | fetched_status=None, |
Andrii Shyshkalov | 550e924 | 2017-04-12 17:14:49 +0200 | [diff] [blame] | 1099 | other_cl_owner=None, |
Aaron Gable | fd23808 | 2017-06-07 13:42:34 -0700 | [diff] [blame] | 1100 | custom_cl_base=None, |
Andrii Shyshkalov | 0da5e8f | 2018-10-30 17:29:18 +0000 | [diff] [blame] | 1101 | tbr=None, |
Andrii Shyshkalov | e7a7fc4 | 2018-10-30 17:35:09 +0000 | [diff] [blame] | 1102 | short_hostname='chromium', |
Edward Lemur | 1b52d87 | 2019-05-09 21:12:12 +0000 | [diff] [blame] | 1103 | labels=None, |
| 1104 | change_id=None, |
| 1105 | original_title=None, |
| 1106 | final_description=None, |
Anthony Polito | 8b95534 | 2019-09-24 19:01:36 +0000 | [diff] [blame] | 1107 | gitcookies_exists=True, |
| 1108 | force=False, |
Josip | e827b0f | 2020-01-30 00:07:20 +0000 | [diff] [blame] | 1109 | edit_description=None, |
Anthony Polito | 8b95534 | 2019-09-24 19:01:36 +0000 | [diff] [blame] | 1110 | fetched_description=None): |
sivachandra@chromium.org | aebe87f | 2012-10-22 20:34:21 +0000 | [diff] [blame] | 1111 | """Generic gerrit upload test framework.""" |
tandrii | a60502f | 2016-06-20 02:01:53 -0700 | [diff] [blame] | 1112 | if squash_mode is None: |
| 1113 | if '--no-squash' in upload_args: |
| 1114 | squash_mode = 'nosquash' |
| 1115 | elif '--squash' in upload_args: |
| 1116 | squash_mode = 'squash' |
| 1117 | else: |
| 1118 | squash_mode = 'default' |
| 1119 | |
tandrii@chromium.org | bf766ba | 2016-04-13 12:51:23 +0000 | [diff] [blame] | 1120 | reviewers = reviewers or [] |
bradnelson | d975b30 | 2016-10-23 12:20:23 -0700 | [diff] [blame] | 1121 | cc = cc or [] |
Edward Lemur | da4b6c6 | 2020-02-13 00:28:40 +0000 | [diff] [blame] | 1122 | mock.patch('git_cl.gerrit_util.CookiesAuthenticator', |
Andrii Shyshkalov | bb86fbb | 2017-03-24 14:59:28 +0100 | [diff] [blame] | 1123 | CookiesAuthenticatorMockFactory( |
Edward Lemur | da4b6c6 | 2020-02-13 00:28:40 +0000 | [diff] [blame] | 1124 | same_auth=('git-owner.example.com', '', 'pass'))).start() |
| 1125 | mock.patch('git_cl.Changelist._GerritCommitMsgHookCheck', |
| 1126 | lambda _, offer_removal: None).start() |
| 1127 | mock.patch('git_cl.gclient_utils.RunEditor', |
| 1128 | lambda *_, **__: self._mocked_call(['RunEditor'])).start() |
| 1129 | mock.patch('git_cl.DownloadGerritHook', lambda force: self._mocked_call( |
| 1130 | 'DownloadGerritHook', force)).start() |
| 1131 | mock.patch('git_cl.gclient_utils.FileRead', |
| 1132 | lambda path: self._mocked_call(['FileRead', path])).start() |
| 1133 | mock.patch('git_cl.gclient_utils.FileWrite', |
Edward Lemur | 1b52d87 | 2019-05-09 21:12:12 +0000 | [diff] [blame] | 1134 | lambda path, contents: self._mocked_call( |
Edward Lemur | da4b6c6 | 2020-02-13 00:28:40 +0000 | [diff] [blame] | 1135 | ['FileWrite', path, contents])).start() |
| 1136 | mock.patch('git_cl.datetime_now', |
| 1137 | lambda: datetime.datetime(2017, 3, 16, 20, 0, 41, 0)).start() |
| 1138 | mock.patch('git_cl.tempfile.mkdtemp', lambda: 'TEMP_DIR').start() |
| 1139 | mock.patch('git_cl.TRACES_DIR', 'TRACES_DIR').start() |
| 1140 | mock.patch('git_cl.TRACES_README_FORMAT', |
Edward Lemur | 75391d4 | 2019-05-14 23:35:56 +0000 | [diff] [blame] | 1141 | '%(now)s\n' |
| 1142 | '%(gerrit_host)s\n' |
| 1143 | '%(change_id)s\n' |
| 1144 | '%(title)s\n' |
| 1145 | '%(description)s\n' |
| 1146 | '%(execution_time)s\n' |
| 1147 | '%(exit_code)s\n' |
Edward Lemur | da4b6c6 | 2020-02-13 00:28:40 +0000 | [diff] [blame] | 1148 | '%(trace_name)s').start() |
| 1149 | mock.patch('git_cl.shutil.make_archive', |
| 1150 | lambda *args: self._mocked_call(['make_archive'] + |
| 1151 | list(args))).start() |
| 1152 | mock.patch('os.path.isfile', |
| 1153 | lambda path: self._mocked_call(['os.path.isfile', path])).start() |
Edward Lemur | d55c507 | 2020-02-20 01:09:07 +0000 | [diff] [blame] | 1154 | mock.patch('git_cl.Changelist.GitSanityChecks', return_value=True).start() |
tandrii | a60502f | 2016-06-20 02:01:53 -0700 | [diff] [blame] | 1155 | |
Edward Lemur | 2696407 | 2020-02-19 19:18:51 +0000 | [diff] [blame] | 1156 | self.mockGit.config['gerrit.host'] = 'true' |
Edward Lemur | 8515328 | 2020-02-14 22:06:29 +0000 | [diff] [blame] | 1157 | self.mockGit.config['branch.master.gerritissue'] = ( |
| 1158 | str(issue) if issue else None) |
| 1159 | self.mockGit.config['remote.origin.url'] = ( |
| 1160 | 'https://%s.googlesource.com/my/repo' % short_hostname) |
| 1161 | |
Andrii Shyshkalov | 8fc0c1d | 2017-01-26 09:38:10 +0100 | [diff] [blame] | 1162 | self.calls = self._gerrit_base_calls( |
| 1163 | issue=issue, |
Anthony Polito | 8b95534 | 2019-09-24 19:01:36 +0000 | [diff] [blame] | 1164 | fetched_description=fetched_description or description, |
Andrii Shyshkalov | bb86fbb | 2017-03-24 14:59:28 +0100 | [diff] [blame] | 1165 | fetched_status=fetched_status, |
Andrii Shyshkalov | 550e924 | 2017-04-12 17:14:49 +0200 | [diff] [blame] | 1166 | other_cl_owner=other_cl_owner, |
Andrii Shyshkalov | 0da5e8f | 2018-10-30 17:29:18 +0000 | [diff] [blame] | 1167 | custom_cl_base=custom_cl_base, |
Anthony Polito | 8b95534 | 2019-09-24 19:01:36 +0000 | [diff] [blame] | 1168 | short_hostname=short_hostname, |
| 1169 | change_id=change_id) |
Andrii Shyshkalov | 5c3d0b3 | 2017-02-16 17:47:31 +0100 | [diff] [blame] | 1170 | if fetched_status != 'ABANDONED': |
Edward Lemur | da4b6c6 | 2020-02-13 00:28:40 +0000 | [diff] [blame] | 1171 | mock.patch( |
Edward Lemur | 1773f37 | 2020-02-22 00:27:14 +0000 | [diff] [blame] | 1172 | 'gclient_utils.temporary_file', TemporaryFileMock()).start() |
Edward Lemur | da4b6c6 | 2020-02-13 00:28:40 +0000 | [diff] [blame] | 1173 | mock.patch('os.remove', return_value=True).start() |
Andrii Shyshkalov | 5c3d0b3 | 2017-02-16 17:47:31 +0100 | [diff] [blame] | 1174 | self.calls += self._gerrit_upload_calls( |
| 1175 | description, reviewers, squash, |
| 1176 | squash_mode=squash_mode, |
| 1177 | expected_upstream_ref=expected_upstream_ref, |
Aaron Gable | fd23808 | 2017-06-07 13:42:34 -0700 | [diff] [blame] | 1178 | title=title, notify=notify, |
Andrii Shyshkalov | 5c3d0b3 | 2017-02-16 17:47:31 +0100 | [diff] [blame] | 1179 | post_amend_description=post_amend_description, |
Andrii Shyshkalov | 81db1d5 | 2018-08-23 02:17:41 +0000 | [diff] [blame] | 1180 | issue=issue, cc=cc, |
Andrii Shyshkalov | 0da5e8f | 2018-10-30 17:29:18 +0000 | [diff] [blame] | 1181 | custom_cl_base=custom_cl_base, tbr=tbr, |
Andrii Shyshkalov | e7a7fc4 | 2018-10-30 17:35:09 +0000 | [diff] [blame] | 1182 | short_hostname=short_hostname, |
Edward Lemur | 1b52d87 | 2019-05-09 21:12:12 +0000 | [diff] [blame] | 1183 | labels=labels, |
| 1184 | change_id=change_id, |
| 1185 | original_title=original_title, |
| 1186 | final_description=final_description, |
Anthony Polito | 8b95534 | 2019-09-24 19:01:36 +0000 | [diff] [blame] | 1187 | gitcookies_exists=gitcookies_exists, |
Josip | e827b0f | 2020-01-30 00:07:20 +0000 | [diff] [blame] | 1188 | force=force, |
| 1189 | edit_description=edit_description) |
tandrii@chromium.org | 09d7a6a | 2016-03-04 15:44:48 +0000 | [diff] [blame] | 1190 | # Uncomment when debugging. |
Raul Tambre | 80ee78e | 2019-05-06 22:41:05 +0000 | [diff] [blame] | 1191 | # print('\n'.join(map(lambda x: '%2i: %s' % x, enumerate(self.calls)))) |
ukai@chromium.org | e807781 | 2012-02-03 03:41:46 +0000 | [diff] [blame] | 1192 | git_cl.main(['upload'] + upload_args) |
Edward Lemur | 8515328 | 2020-02-14 22:06:29 +0000 | [diff] [blame] | 1193 | if squash: |
Edward Lemur | 2696407 | 2020-02-19 19:18:51 +0000 | [diff] [blame] | 1194 | self.assertIssueAndPatchset(patchset=None) |
Edward Lemur | 8515328 | 2020-02-14 22:06:29 +0000 | [diff] [blame] | 1195 | self.assertEqual( |
| 1196 | 'abcdef0123456789', |
Edward Lemur | 2696407 | 2020-02-19 19:18:51 +0000 | [diff] [blame] | 1197 | scm.GIT.GetBranchConfig('', 'master', 'gerritsquashhash')) |
ukai@chromium.org | e807781 | 2012-02-03 03:41:46 +0000 | [diff] [blame] | 1198 | |
Edward Lemur | 1b52d87 | 2019-05-09 21:12:12 +0000 | [diff] [blame] | 1199 | def test_gerrit_upload_traces_no_gitcookies(self): |
| 1200 | self._run_gerrit_upload_test( |
| 1201 | ['--no-squash'], |
Edward Lemur | 0db01f0 | 2019-11-12 22:01:51 +0000 | [diff] [blame] | 1202 | 'desc ✔\n\nBUG=\n', |
Edward Lemur | 1b52d87 | 2019-05-09 21:12:12 +0000 | [diff] [blame] | 1203 | [], |
| 1204 | squash=False, |
Edward Lemur | 0db01f0 | 2019-11-12 22:01:51 +0000 | [diff] [blame] | 1205 | post_amend_description='desc ✔\n\nBUG=\n\nChange-Id: Ixxx', |
Edward Lemur | 1b52d87 | 2019-05-09 21:12:12 +0000 | [diff] [blame] | 1206 | change_id='Ixxx', |
| 1207 | gitcookies_exists=False) |
| 1208 | |
sivachandra@chromium.org | aebe87f | 2012-10-22 20:34:21 +0000 | [diff] [blame] | 1209 | def test_gerrit_upload_without_change_id(self): |
tandrii | a60502f | 2016-06-20 02:01:53 -0700 | [diff] [blame] | 1210 | self._run_gerrit_upload_test( |
| 1211 | ['--no-squash'], |
Edward Lemur | 0db01f0 | 2019-11-12 22:01:51 +0000 | [diff] [blame] | 1212 | 'desc ✔\n\nBUG=\n', |
tandrii | a60502f | 2016-06-20 02:01:53 -0700 | [diff] [blame] | 1213 | [], |
| 1214 | squash=False, |
Edward Lemur | 0db01f0 | 2019-11-12 22:01:51 +0000 | [diff] [blame] | 1215 | post_amend_description='desc ✔\n\nBUG=\n\nChange-Id: Ixxx', |
Edward Lemur | 1b52d87 | 2019-05-09 21:12:12 +0000 | [diff] [blame] | 1216 | change_id='Ixxx') |
tandrii | a60502f | 2016-06-20 02:01:53 -0700 | [diff] [blame] | 1217 | |
| 1218 | def test_gerrit_upload_without_change_id_override_nosquash(self): |
sivachandra@chromium.org | aebe87f | 2012-10-22 20:34:21 +0000 | [diff] [blame] | 1219 | self._run_gerrit_upload_test( |
ukai@chromium.org | e807781 | 2012-02-03 03:41:46 +0000 | [diff] [blame] | 1220 | [], |
Edward Lemur | 0db01f0 | 2019-11-12 22:01:51 +0000 | [diff] [blame] | 1221 | 'desc ✔\n\nBUG=\n', |
tandrii@chromium.org | 1062500 | 2016-03-04 20:03:47 +0000 | [diff] [blame] | 1222 | [], |
tandrii | a60502f | 2016-06-20 02:01:53 -0700 | [diff] [blame] | 1223 | squash=False, |
| 1224 | squash_mode='override_nosquash', |
Edward Lemur | 0db01f0 | 2019-11-12 22:01:51 +0000 | [diff] [blame] | 1225 | post_amend_description='desc ✔\n\nBUG=\n\nChange-Id: Ixxx', |
Edward Lemur | 1b52d87 | 2019-05-09 21:12:12 +0000 | [diff] [blame] | 1226 | change_id='Ixxx') |
ukai@chromium.org | e807781 | 2012-02-03 03:41:46 +0000 | [diff] [blame] | 1227 | |
sivachandra@chromium.org | aebe87f | 2012-10-22 20:34:21 +0000 | [diff] [blame] | 1228 | def test_gerrit_no_reviewer(self): |
| 1229 | self._run_gerrit_upload_test( |
| 1230 | [], |
Edward Lemur | 0db01f0 | 2019-11-12 22:01:51 +0000 | [diff] [blame] | 1231 | 'desc ✔\n\nBUG=\n\nChange-Id: I123456789\n', |
tandrii | a60502f | 2016-06-20 02:01:53 -0700 | [diff] [blame] | 1232 | [], |
| 1233 | squash=False, |
Edward Lemur | 1b52d87 | 2019-05-09 21:12:12 +0000 | [diff] [blame] | 1234 | squash_mode='override_nosquash', |
| 1235 | change_id='I123456789') |
sivachandra@chromium.org | aebe87f | 2012-10-22 20:34:21 +0000 | [diff] [blame] | 1236 | |
Andrii Shyshkalov | 0da5e8f | 2018-10-30 17:29:18 +0000 | [diff] [blame] | 1237 | def test_gerrit_no_reviewer_non_chromium_host(self): |
| 1238 | # TODO(crbug/877717): remove this test case. |
| 1239 | self._run_gerrit_upload_test( |
| 1240 | [], |
Edward Lemur | 0db01f0 | 2019-11-12 22:01:51 +0000 | [diff] [blame] | 1241 | 'desc ✔\n\nBUG=\n\nChange-Id: I123456789\n', |
Andrii Shyshkalov | 0da5e8f | 2018-10-30 17:29:18 +0000 | [diff] [blame] | 1242 | [], |
| 1243 | squash=False, |
| 1244 | squash_mode='override_nosquash', |
Edward Lemur | 1b52d87 | 2019-05-09 21:12:12 +0000 | [diff] [blame] | 1245 | short_hostname='other', |
| 1246 | change_id='I123456789') |
Andrii Shyshkalov | 0da5e8f | 2018-10-30 17:29:18 +0000 | [diff] [blame] | 1247 | |
Nick Carter | 8692b18 | 2017-11-06 16:30:38 -0800 | [diff] [blame] | 1248 | def test_gerrit_patchset_title_special_chars(self): |
Andrii Shyshkalov | febbae9 | 2017-04-05 15:05:20 +0000 | [diff] [blame] | 1249 | self._run_gerrit_upload_test( |
Nick Carter | 8692b18 | 2017-11-06 16:30:38 -0800 | [diff] [blame] | 1250 | ['-f', '-t', 'We\'ll escape ^_ ^ special chars...@{u}'], |
Edward Lemur | 0db01f0 | 2019-11-12 22:01:51 +0000 | [diff] [blame] | 1251 | 'desc ✔\n\nBUG=\n\nChange-Id: I123456789', |
Andrii Shyshkalov | febbae9 | 2017-04-05 15:05:20 +0000 | [diff] [blame] | 1252 | squash=False, |
| 1253 | squash_mode='override_nosquash', |
Edward Lemur | 1b52d87 | 2019-05-09 21:12:12 +0000 | [diff] [blame] | 1254 | title='We%27ll_escape_%5E%5F_%5E_special_chars%2E%2E%2E%40%7Bu%7D', |
| 1255 | change_id='I123456789', |
| 1256 | original_title='We\'ll escape ^_ ^ special chars...@{u}') |
Andrii Shyshkalov | febbae9 | 2017-04-05 15:05:20 +0000 | [diff] [blame] | 1257 | |
ukai@chromium.org | e807781 | 2012-02-03 03:41:46 +0000 | [diff] [blame] | 1258 | def test_gerrit_reviewers_cmd_line(self): |
sivachandra@chromium.org | aebe87f | 2012-10-22 20:34:21 +0000 | [diff] [blame] | 1259 | self._run_gerrit_upload_test( |
tandrii@chromium.org | 8da4540 | 2016-05-24 23:11:03 +0000 | [diff] [blame] | 1260 | ['-r', 'foo@example.com', '--send-mail'], |
Edward Lemur | 0db01f0 | 2019-11-12 22:01:51 +0000 | [diff] [blame] | 1261 | 'desc ✔\n\nBUG=\n\nChange-Id: I123456789', |
tandrii@chromium.org | 8da4540 | 2016-05-24 23:11:03 +0000 | [diff] [blame] | 1262 | ['foo@example.com'], |
tandrii | a60502f | 2016-06-20 02:01:53 -0700 | [diff] [blame] | 1263 | squash=False, |
| 1264 | squash_mode='override_nosquash', |
Edward Lemur | 1b52d87 | 2019-05-09 21:12:12 +0000 | [diff] [blame] | 1265 | notify=True, |
| 1266 | change_id='I123456789', |
Quinten Yearsley | d9cbe7a | 2019-09-03 16:49:11 +0000 | [diff] [blame] | 1267 | final_description=( |
Edward Lemur | 0db01f0 | 2019-11-12 22:01:51 +0000 | [diff] [blame] | 1268 | 'desc ✔\n\nBUG=\nR=foo@example.com\n\nChange-Id: I123456789')) |
ukai@chromium.org | e807781 | 2012-02-03 03:41:46 +0000 | [diff] [blame] | 1269 | |
Anthony Polito | 8b95534 | 2019-09-24 19:01:36 +0000 | [diff] [blame] | 1270 | def test_gerrit_upload_force_sets_bug(self): |
| 1271 | self._run_gerrit_upload_test( |
| 1272 | ['-b', '10000', '-f'], |
| 1273 | u'desc=\n\nBug: 10000\nChange-Id: Ixxx', |
| 1274 | [], |
| 1275 | force=True, |
| 1276 | expected_upstream_ref='origin/master', |
| 1277 | fetched_description='desc=\n\nChange-Id: Ixxx', |
| 1278 | original_title='Initial upload', |
| 1279 | change_id='Ixxx') |
| 1280 | |
| 1281 | def test_gerrit_upload_force_sets_bug_if_wrong_changeid(self): |
| 1282 | self._run_gerrit_upload_test( |
| 1283 | ['-b', '10000', '-f', '-m', 'Title'], |
| 1284 | u'desc=\n\nChange-Id: Ixxxx\n\nChange-Id: Izzzz\nBug: 10000', |
| 1285 | [], |
| 1286 | force=True, |
| 1287 | issue='123456', |
| 1288 | expected_upstream_ref='origin/master', |
| 1289 | fetched_description='desc=\n\nChange-Id: Ixxxx', |
| 1290 | original_title='Title', |
| 1291 | title='Title', |
| 1292 | change_id='Izzzz') |
| 1293 | |
Dan Beam | d8b04ca | 2019-10-10 21:23:26 +0000 | [diff] [blame] | 1294 | def test_gerrit_upload_force_sets_fixed(self): |
| 1295 | self._run_gerrit_upload_test( |
| 1296 | ['-x', '10000', '-f'], |
| 1297 | u'desc=\n\nFixed: 10000\nChange-Id: Ixxx', |
| 1298 | [], |
| 1299 | force=True, |
| 1300 | expected_upstream_ref='origin/master', |
| 1301 | fetched_description='desc=\n\nChange-Id: Ixxx', |
| 1302 | original_title='Initial upload', |
| 1303 | change_id='Ixxx') |
| 1304 | |
ukai@chromium.org | e807781 | 2012-02-03 03:41:46 +0000 | [diff] [blame] | 1305 | def test_gerrit_reviewer_multiple(self): |
Edward Lemur | da4b6c6 | 2020-02-13 00:28:40 +0000 | [diff] [blame] | 1306 | mock.patch('git_cl.gerrit_util.GetCodeReviewTbrScore', |
| 1307 | lambda *a: self._mocked_call('GetCodeReviewTbrScore', *a)).start() |
sivachandra@chromium.org | aebe87f | 2012-10-22 20:34:21 +0000 | [diff] [blame] | 1308 | self._run_gerrit_upload_test( |
ukai@chromium.org | e807781 | 2012-02-03 03:41:46 +0000 | [diff] [blame] | 1309 | [], |
Edward Lemur | 0db01f0 | 2019-11-12 22:01:51 +0000 | [diff] [blame] | 1310 | 'desc ✔\nTBR=reviewer@example.com\nBUG=\nR=another@example.com\n' |
bradnelson | d975b30 | 2016-10-23 12:20:23 -0700 | [diff] [blame] | 1311 | 'CC=more@example.com,people@example.com\n\n' |
Yoshisato Yanagisawa | 81e3ff5 | 2017-09-26 15:33:34 +0900 | [diff] [blame] | 1312 | 'Change-Id: 123456789', |
tandrii | a60502f | 2016-06-20 02:01:53 -0700 | [diff] [blame] | 1313 | ['reviewer@example.com', 'another@example.com'], |
Yoshisato Yanagisawa | 81e3ff5 | 2017-09-26 15:33:34 +0900 | [diff] [blame] | 1314 | expected_upstream_ref='origin/master', |
Aaron Gable | fd23808 | 2017-06-07 13:42:34 -0700 | [diff] [blame] | 1315 | cc=['more@example.com', 'people@example.com'], |
Edward Lemur | 687ca90 | 2018-12-05 02:30:30 +0000 | [diff] [blame] | 1316 | tbr='reviewer@example.com', |
Edward Lemur | 1b52d87 | 2019-05-09 21:12:12 +0000 | [diff] [blame] | 1317 | labels={'Code-Review': 2}, |
| 1318 | change_id='123456789', |
| 1319 | original_title='Initial upload') |
tandrii | a60502f | 2016-06-20 02:01:53 -0700 | [diff] [blame] | 1320 | |
| 1321 | def test_gerrit_upload_squash_first_is_default(self): |
tandrii | a60502f | 2016-06-20 02:01:53 -0700 | [diff] [blame] | 1322 | self._run_gerrit_upload_test( |
| 1323 | [], |
Edward Lemur | 0db01f0 | 2019-11-12 22:01:51 +0000 | [diff] [blame] | 1324 | 'desc ✔\nBUG=\n\nChange-Id: 123456789', |
tandrii | a60502f | 2016-06-20 02:01:53 -0700 | [diff] [blame] | 1325 | [], |
Edward Lemur | 1b52d87 | 2019-05-09 21:12:12 +0000 | [diff] [blame] | 1326 | expected_upstream_ref='origin/master', |
| 1327 | change_id='123456789', |
| 1328 | original_title='Initial upload') |
ukai@chromium.org | e807781 | 2012-02-03 03:41:46 +0000 | [diff] [blame] | 1329 | |
tandrii@chromium.org | 512d79c | 2016-03-31 12:55:28 +0000 | [diff] [blame] | 1330 | def test_gerrit_upload_squash_first(self): |
bauerb@chromium.org | 27386dd | 2015-02-16 10:45:39 +0000 | [diff] [blame] | 1331 | self._run_gerrit_upload_test( |
| 1332 | ['--squash'], |
Edward Lemur | 0db01f0 | 2019-11-12 22:01:51 +0000 | [diff] [blame] | 1333 | 'desc ✔\nBUG=\n\nChange-Id: 123456789', |
bauerb@chromium.org | 27386dd | 2015-02-16 10:45:39 +0000 | [diff] [blame] | 1334 | [], |
luqui@chromium.org | 609f395 | 2015-05-04 22:47:04 +0000 | [diff] [blame] | 1335 | squash=True, |
Edward Lemur | 1b52d87 | 2019-05-09 21:12:12 +0000 | [diff] [blame] | 1336 | expected_upstream_ref='origin/master', |
| 1337 | change_id='123456789', |
| 1338 | original_title='Initial upload') |
ukai@chromium.org | e807781 | 2012-02-03 03:41:46 +0000 | [diff] [blame] | 1339 | |
Andrii Shyshkalov | e7a7fc4 | 2018-10-30 17:35:09 +0000 | [diff] [blame] | 1340 | def test_gerrit_upload_squash_first_with_labels(self): |
| 1341 | self._run_gerrit_upload_test( |
| 1342 | ['--squash', '--cq-dry-run', '--enable-auto-submit'], |
Edward Lemur | 0db01f0 | 2019-11-12 22:01:51 +0000 | [diff] [blame] | 1343 | 'desc ✔\nBUG=\n\nChange-Id: 123456789', |
Andrii Shyshkalov | e7a7fc4 | 2018-10-30 17:35:09 +0000 | [diff] [blame] | 1344 | [], |
| 1345 | squash=True, |
| 1346 | expected_upstream_ref='origin/master', |
Edward Lemur | 1b52d87 | 2019-05-09 21:12:12 +0000 | [diff] [blame] | 1347 | labels={'Commit-Queue': 1, 'Auto-Submit': 1}, |
| 1348 | change_id='123456789', |
| 1349 | original_title='Initial upload') |
Andrii Shyshkalov | e7a7fc4 | 2018-10-30 17:35:09 +0000 | [diff] [blame] | 1350 | |
Andrii Shyshkalov | 550e924 | 2017-04-12 17:14:49 +0200 | [diff] [blame] | 1351 | def test_gerrit_upload_squash_first_against_rev(self): |
| 1352 | custom_cl_base = 'custom_cl_base_rev_or_branch' |
| 1353 | self._run_gerrit_upload_test( |
| 1354 | ['--squash', custom_cl_base], |
Edward Lemur | 0db01f0 | 2019-11-12 22:01:51 +0000 | [diff] [blame] | 1355 | 'desc ✔\nBUG=\n\nChange-Id: 123456789', |
Andrii Shyshkalov | 550e924 | 2017-04-12 17:14:49 +0200 | [diff] [blame] | 1356 | [], |
| 1357 | squash=True, |
| 1358 | expected_upstream_ref='origin/master', |
Edward Lemur | 1b52d87 | 2019-05-09 21:12:12 +0000 | [diff] [blame] | 1359 | custom_cl_base=custom_cl_base, |
| 1360 | change_id='123456789', |
| 1361 | original_title='Initial upload') |
Andrii Shyshkalov | 550e924 | 2017-04-12 17:14:49 +0200 | [diff] [blame] | 1362 | self.assertIn( |
| 1363 | 'If you proceed with upload, more than 1 CL may be created by Gerrit', |
| 1364 | sys.stdout.getvalue()) |
| 1365 | |
tandrii@chromium.org | 512d79c | 2016-03-31 12:55:28 +0000 | [diff] [blame] | 1366 | def test_gerrit_upload_squash_reupload(self): |
Edward Lemur | 0db01f0 | 2019-11-12 22:01:51 +0000 | [diff] [blame] | 1367 | description = 'desc ✔\nBUG=\n\nChange-Id: 123456789' |
tandrii@chromium.org | 512d79c | 2016-03-31 12:55:28 +0000 | [diff] [blame] | 1368 | self._run_gerrit_upload_test( |
| 1369 | ['--squash'], |
| 1370 | description, |
| 1371 | [], |
| 1372 | squash=True, |
| 1373 | expected_upstream_ref='origin/master', |
Edward Lemur | 1b52d87 | 2019-05-09 21:12:12 +0000 | [diff] [blame] | 1374 | issue=123456, |
| 1375 | change_id='123456789', |
| 1376 | original_title='User input') |
tandrii@chromium.org | 512d79c | 2016-03-31 12:55:28 +0000 | [diff] [blame] | 1377 | |
Edward Lemur | d55c507 | 2020-02-20 01:09:07 +0000 | [diff] [blame] | 1378 | @mock.patch('sys.stderr', StringIO()) |
Andrii Shyshkalov | 5c3d0b3 | 2017-02-16 17:47:31 +0100 | [diff] [blame] | 1379 | def test_gerrit_upload_squash_reupload_to_abandoned(self): |
Edward Lemur | 0db01f0 | 2019-11-12 22:01:51 +0000 | [diff] [blame] | 1380 | description = 'desc ✔\nBUG=\n\nChange-Id: 123456789' |
Andrii Shyshkalov | 5c3d0b3 | 2017-02-16 17:47:31 +0100 | [diff] [blame] | 1381 | with self.assertRaises(SystemExitMock): |
| 1382 | self._run_gerrit_upload_test( |
| 1383 | ['--squash'], |
| 1384 | description, |
| 1385 | [], |
| 1386 | squash=True, |
| 1387 | expected_upstream_ref='origin/master', |
| 1388 | issue=123456, |
Edward Lemur | 1b52d87 | 2019-05-09 21:12:12 +0000 | [diff] [blame] | 1389 | fetched_status='ABANDONED', |
| 1390 | change_id='123456789') |
Edward Lemur | d55c507 | 2020-02-20 01:09:07 +0000 | [diff] [blame] | 1391 | self.assertEqual( |
| 1392 | 'Change https://chromium-review.googlesource.com/123456 has been ' |
| 1393 | 'abandoned, new uploads are not allowed\n', |
| 1394 | sys.stderr.getvalue()) |
Andrii Shyshkalov | 5c3d0b3 | 2017-02-16 17:47:31 +0100 | [diff] [blame] | 1395 | |
Edward Lemur | da4b6c6 | 2020-02-13 00:28:40 +0000 | [diff] [blame] | 1396 | @mock.patch( |
| 1397 | 'gerrit_util.GetAccountDetails', |
| 1398 | return_value={'email': 'yet-another@example.com'}) |
| 1399 | def test_gerrit_upload_squash_reupload_to_not_owned(self, _mock): |
Edward Lemur | 0db01f0 | 2019-11-12 22:01:51 +0000 | [diff] [blame] | 1400 | description = 'desc ✔\nBUG=\n\nChange-Id: 123456789' |
Andrii Shyshkalov | bb86fbb | 2017-03-24 14:59:28 +0100 | [diff] [blame] | 1401 | self._run_gerrit_upload_test( |
| 1402 | ['--squash'], |
| 1403 | description, |
| 1404 | [], |
| 1405 | squash=True, |
| 1406 | expected_upstream_ref='origin/master', |
| 1407 | issue=123456, |
Edward Lemur | 1b52d87 | 2019-05-09 21:12:12 +0000 | [diff] [blame] | 1408 | other_cl_owner='other@example.com', |
| 1409 | change_id='123456789', |
| 1410 | original_title='User input') |
Andrii Shyshkalov | bb86fbb | 2017-03-24 14:59:28 +0100 | [diff] [blame] | 1411 | self.assertIn( |
Quinten Yearsley | 0c62da9 | 2017-05-31 13:39:42 -0700 | [diff] [blame] | 1412 | 'WARNING: Change 123456 is owned by other@example.com, but you ' |
Andrii Shyshkalov | bb86fbb | 2017-03-24 14:59:28 +0100 | [diff] [blame] | 1413 | 'authenticate to Gerrit as yet-another@example.com.\n' |
| 1414 | 'Uploading may fail due to lack of permissions', |
Edward Lemur | da4b6c6 | 2020-02-13 00:28:40 +0000 | [diff] [blame] | 1415 | sys.stdout.getvalue()) |
Andrii Shyshkalov | bb86fbb | 2017-03-24 14:59:28 +0100 | [diff] [blame] | 1416 | |
Josip | e827b0f | 2020-01-30 00:07:20 +0000 | [diff] [blame] | 1417 | def test_upload_change_description_editor(self): |
| 1418 | fetched_description = 'foo\n\nChange-Id: 123456789' |
| 1419 | description = 'bar\n\nChange-Id: 123456789' |
| 1420 | self._run_gerrit_upload_test( |
| 1421 | ['--squash', '--edit-description'], |
| 1422 | description, |
| 1423 | [], |
| 1424 | fetched_description=fetched_description, |
| 1425 | squash=True, |
| 1426 | expected_upstream_ref='origin/master', |
| 1427 | issue=123456, |
| 1428 | change_id='123456789', |
| 1429 | original_title='User input', |
| 1430 | edit_description=description) |
| 1431 | |
Edward Lemur | da4b6c6 | 2020-02-13 00:28:40 +0000 | [diff] [blame] | 1432 | @mock.patch('git_cl.RunGit') |
| 1433 | @mock.patch('git_cl.CMDupload') |
| 1434 | @mock.patch('git_cl.ask_for_data') |
| 1435 | def test_upload_branch_deps(self, *_mocks): |
rmistry@google.com | 2dd9986 | 2015-06-22 12:22:18 +0000 | [diff] [blame] | 1436 | def mock_run_git(*args, **_kwargs): |
| 1437 | if args[0] == ['for-each-ref', |
| 1438 | '--format=%(refname:short) %(upstream:short)', |
| 1439 | 'refs/heads']: |
| 1440 | # Create a local branch dependency tree that looks like this: |
| 1441 | # test1 -> test2 -> test3 -> test4 -> test5 |
| 1442 | # -> test3.1 |
| 1443 | # test6 -> test0 |
| 1444 | branch_deps = [ |
| 1445 | 'test2 test1', # test1 -> test2 |
| 1446 | 'test3 test2', # test2 -> test3 |
| 1447 | 'test3.1 test2', # test2 -> test3.1 |
| 1448 | 'test4 test3', # test3 -> test4 |
| 1449 | 'test5 test4', # test4 -> test5 |
| 1450 | 'test6 test0', # test0 -> test6 |
| 1451 | 'test7', # test7 |
| 1452 | ] |
| 1453 | return '\n'.join(branch_deps) |
Edward Lemur | da4b6c6 | 2020-02-13 00:28:40 +0000 | [diff] [blame] | 1454 | git_cl.RunGit.side_effect = mock_run_git |
| 1455 | git_cl.CMDupload.return_value = 0 |
rmistry@google.com | 2dd9986 | 2015-06-22 12:22:18 +0000 | [diff] [blame] | 1456 | |
| 1457 | class MockChangelist(): |
| 1458 | def __init__(self): |
| 1459 | pass |
| 1460 | def GetBranch(self): |
| 1461 | return 'test1' |
| 1462 | def GetIssue(self): |
| 1463 | return '123' |
| 1464 | def GetPatchset(self): |
| 1465 | return '1001' |
tandrii@chromium.org | 4c72b08 | 2016-03-31 22:26:35 +0000 | [diff] [blame] | 1466 | def IsGerrit(self): |
| 1467 | return False |
rmistry@google.com | 2dd9986 | 2015-06-22 12:22:18 +0000 | [diff] [blame] | 1468 | |
| 1469 | ret = git_cl.upload_branch_deps(MockChangelist(), []) |
| 1470 | # CMDupload should have been called 5 times because of 5 dependent branches. |
Edward Lemur | da4b6c6 | 2020-02-13 00:28:40 +0000 | [diff] [blame] | 1471 | self.assertEqual(5, len(git_cl.CMDupload.mock_calls)) |
| 1472 | git_cl.ask_for_data.assert_called_once_with( |
| 1473 | 'This command will checkout all dependent branches ' |
| 1474 | 'and run "git cl upload". Press Enter to continue, ' |
| 1475 | 'or Ctrl+C to abort') |
Raphael Kubo da Costa | e9342a7 | 2019-10-14 17:49:39 +0000 | [diff] [blame] | 1476 | self.assertEqual(0, ret) |
rmistry@google.com | 2dd9986 | 2015-06-22 12:22:18 +0000 | [diff] [blame] | 1477 | |
tandrii@chromium.org | 65874e1 | 2016-03-04 12:03:02 +0000 | [diff] [blame] | 1478 | def test_gerrit_change_id(self): |
| 1479 | self.calls = [ |
| 1480 | ((['git', 'write-tree'], ), |
| 1481 | 'hashtree'), |
| 1482 | ((['git', 'rev-parse', 'HEAD~0'], ), |
| 1483 | 'branch-parent'), |
| 1484 | ((['git', 'var', 'GIT_AUTHOR_IDENT'], ), |
| 1485 | 'A B <a@b.org> 1456848326 +0100'), |
| 1486 | ((['git', 'var', 'GIT_COMMITTER_IDENT'], ), |
| 1487 | 'C D <c@d.org> 1456858326 +0100'), |
| 1488 | ((['git', 'hash-object', '-t', 'commit', '--stdin'], ), |
| 1489 | 'hashchange'), |
| 1490 | ] |
| 1491 | change_id = git_cl.GenerateGerritChangeId('line1\nline2\n') |
| 1492 | self.assertEqual(change_id, 'Ihashchange') |
| 1493 | |
tandrii@chromium.org | 601e1d1 | 2016-06-03 13:03:54 +0000 | [diff] [blame] | 1494 | def test_desecription_append_footer(self): |
| 1495 | for init_desc, footer_line, expected_desc in [ |
| 1496 | # Use unique desc first lines for easy test failure identification. |
| 1497 | ('foo', 'R=one', 'foo\n\nR=one'), |
| 1498 | ('foo\n\nR=one', 'BUG=', 'foo\n\nR=one\nBUG='), |
| 1499 | ('foo\n\nR=one', 'Change-Id: Ixx', 'foo\n\nR=one\n\nChange-Id: Ixx'), |
| 1500 | ('foo\n\nChange-Id: Ixx', 'R=one', 'foo\n\nR=one\n\nChange-Id: Ixx'), |
| 1501 | ('foo\n\nR=one\n\nChange-Id: Ixx', 'TBR=two', |
| 1502 | 'foo\n\nR=one\nTBR=two\n\nChange-Id: Ixx'), |
| 1503 | ('foo\n\nR=one\n\nChange-Id: Ixx', 'Foo-Bar: baz', |
| 1504 | 'foo\n\nR=one\n\nChange-Id: Ixx\nFoo-Bar: baz'), |
| 1505 | ('foo\n\nChange-Id: Ixx', 'Foo-Bak: baz', |
| 1506 | 'foo\n\nChange-Id: Ixx\nFoo-Bak: baz'), |
| 1507 | ('foo', 'Change-Id: Ixx', 'foo\n\nChange-Id: Ixx'), |
| 1508 | ]: |
| 1509 | desc = git_cl.ChangeDescription(init_desc) |
| 1510 | desc.append_footer(footer_line) |
| 1511 | self.assertEqual(desc.description, expected_desc) |
| 1512 | |
maruel@chromium.org | 78936cb | 2013-04-11 00:17:52 +0000 | [diff] [blame] | 1513 | def test_update_reviewers(self): |
| 1514 | data = [ |
Robert Iannucci | 6c98dc6 | 2017-04-18 11:38:00 -0700 | [diff] [blame] | 1515 | ('foo', [], [], |
| 1516 | 'foo'), |
| 1517 | ('foo\nR=xx', [], [], |
| 1518 | 'foo\nR=xx'), |
| 1519 | ('foo\nTBR=xx', [], [], |
| 1520 | 'foo\nTBR=xx'), |
| 1521 | ('foo', ['a@c'], [], |
| 1522 | 'foo\n\nR=a@c'), |
| 1523 | ('foo\nR=xx', ['a@c'], [], |
| 1524 | 'foo\n\nR=a@c, xx'), |
| 1525 | ('foo\nTBR=xx', ['a@c'], [], |
| 1526 | 'foo\n\nR=a@c\nTBR=xx'), |
| 1527 | ('foo\nTBR=xx\nR=yy', ['a@c'], [], |
| 1528 | 'foo\n\nR=a@c, yy\nTBR=xx'), |
| 1529 | ('foo\nBUG=', ['a@c'], [], |
| 1530 | 'foo\nBUG=\nR=a@c'), |
| 1531 | ('foo\nR=xx\nTBR=yy\nR=bar', ['a@c'], [], |
| 1532 | 'foo\n\nR=a@c, bar, xx\nTBR=yy'), |
| 1533 | ('foo', ['a@c', 'b@c'], [], |
| 1534 | 'foo\n\nR=a@c, b@c'), |
| 1535 | ('foo\nBar\n\nR=\nBUG=', ['c@c'], [], |
| 1536 | 'foo\nBar\n\nR=c@c\nBUG='), |
| 1537 | ('foo\nBar\n\nR=\nBUG=\nR=', ['c@c'], [], |
| 1538 | 'foo\nBar\n\nR=c@c\nBUG='), |
maruel@chromium.org | c6f60e8 | 2013-04-19 17:01:57 +0000 | [diff] [blame] | 1539 | # Same as the line before, but full of whitespaces. |
| 1540 | ( |
Robert Iannucci | 6c98dc6 | 2017-04-18 11:38:00 -0700 | [diff] [blame] | 1541 | 'foo\nBar\n\n R = \n BUG = \n R = ', ['c@c'], [], |
maruel@chromium.org | c6f60e8 | 2013-04-19 17:01:57 +0000 | [diff] [blame] | 1542 | 'foo\nBar\n\nR=c@c\n BUG =', |
| 1543 | ), |
| 1544 | # Whitespaces aren't interpreted as new lines. |
Robert Iannucci | 6c98dc6 | 2017-04-18 11:38:00 -0700 | [diff] [blame] | 1545 | ('foo BUG=allo R=joe ', ['c@c'], [], |
| 1546 | 'foo BUG=allo R=joe\n\nR=c@c'), |
| 1547 | # Redundant TBRs get promoted to Rs |
| 1548 | ('foo\n\nR=a@c\nTBR=t@c', ['b@c', 'a@c'], ['a@c', 't@c'], |
| 1549 | 'foo\n\nR=a@c, b@c\nTBR=t@c'), |
maruel@chromium.org | 78936cb | 2013-04-11 00:17:52 +0000 | [diff] [blame] | 1550 | ] |
Robert Iannucci | 6c98dc6 | 2017-04-18 11:38:00 -0700 | [diff] [blame] | 1551 | expected = [i[-1] for i in data] |
maruel@chromium.org | c6f60e8 | 2013-04-19 17:01:57 +0000 | [diff] [blame] | 1552 | actual = [] |
Robert Iannucci | 6c98dc6 | 2017-04-18 11:38:00 -0700 | [diff] [blame] | 1553 | for orig, reviewers, tbrs, _expected in data: |
maruel@chromium.org | 78936cb | 2013-04-11 00:17:52 +0000 | [diff] [blame] | 1554 | obj = git_cl.ChangeDescription(orig) |
Robert Iannucci | 6c98dc6 | 2017-04-18 11:38:00 -0700 | [diff] [blame] | 1555 | obj.update_reviewers(reviewers, tbrs) |
maruel@chromium.org | c6f60e8 | 2013-04-19 17:01:57 +0000 | [diff] [blame] | 1556 | actual.append(obj.description) |
| 1557 | self.assertEqual(expected, actual) |
maruel@chromium.org | 78936cb | 2013-04-11 00:17:52 +0000 | [diff] [blame] | 1558 | |
Nodir Turakulov | 23b8214 | 2017-11-16 11:04:25 -0800 | [diff] [blame] | 1559 | def test_get_hash_tags(self): |
| 1560 | cases = [ |
| 1561 | ('', []), |
| 1562 | ('a', []), |
| 1563 | ('[a]', ['a']), |
| 1564 | ('[aa]', ['aa']), |
| 1565 | ('[a ]', ['a']), |
| 1566 | ('[a- ]', ['a']), |
| 1567 | ('[a- b]', ['a-b']), |
| 1568 | ('[a--b]', ['a-b']), |
| 1569 | ('[a', []), |
| 1570 | ('[a]x', ['a']), |
| 1571 | ('[aa]x', ['aa']), |
| 1572 | ('[a b]', ['a-b']), |
| 1573 | ('[a b]', ['a-b']), |
| 1574 | ('[a__b]', ['a-b']), |
| 1575 | ('[a] x', ['a']), |
| 1576 | ('[a][b]', ['a', 'b']), |
| 1577 | ('[a] [b]', ['a', 'b']), |
| 1578 | ('[a][b]x', ['a', 'b']), |
| 1579 | ('[a][b] x', ['a', 'b']), |
| 1580 | ('[a]\n[b]', ['a']), |
| 1581 | ('[a\nb]', []), |
| 1582 | ('[a][', ['a']), |
| 1583 | ('Revert "[a] feature"', ['a']), |
| 1584 | ('Reland "[a] feature"', ['a']), |
| 1585 | ('Revert: [a] feature', ['a']), |
| 1586 | ('Reland: [a] feature', ['a']), |
| 1587 | ('Revert "Reland: [a] feature"', ['a']), |
| 1588 | ('Foo: feature', ['foo']), |
| 1589 | ('Foo Bar: feature', ['foo-bar']), |
Anthony Polito | 02b5af3 | 2019-12-02 19:49:47 +0000 | [diff] [blame] | 1590 | ('Change Foo::Bar', []), |
| 1591 | ('Foo: Change Foo::Bar', ['foo']), |
Nodir Turakulov | 23b8214 | 2017-11-16 11:04:25 -0800 | [diff] [blame] | 1592 | ('Revert "Foo bar: feature"', ['foo-bar']), |
| 1593 | ('Reland "Foo bar: feature"', ['foo-bar']), |
| 1594 | ] |
| 1595 | for desc, expected in cases: |
| 1596 | change_desc = git_cl.ChangeDescription(desc) |
| 1597 | actual = change_desc.get_hash_tags() |
| 1598 | self.assertEqual( |
| 1599 | actual, |
| 1600 | expected, |
| 1601 | 'GetHashTags(%r) == %r, expected %r' % (desc, actual, expected)) |
| 1602 | |
Andrii Shyshkalov | f3a20ae | 2017-01-24 21:23:57 +0100 | [diff] [blame] | 1603 | self.assertEqual(None, git_cl.GetTargetRef('origin', None, 'master')) |
wittman@chromium.org | 455dc92 | 2015-01-26 20:15:50 +0000 | [diff] [blame] | 1604 | self.assertEqual(None, git_cl.GetTargetRef(None, |
| 1605 | 'refs/remotes/origin/master', |
Andrii Shyshkalov | f3a20ae | 2017-01-24 21:23:57 +0100 | [diff] [blame] | 1606 | 'master')) |
bauerb@chromium.org | 27386dd | 2015-02-16 10:45:39 +0000 | [diff] [blame] | 1607 | |
wittman@chromium.org | 455dc92 | 2015-01-26 20:15:50 +0000 | [diff] [blame] | 1608 | # Check default target refs for branches. |
| 1609 | self.assertEqual('refs/heads/master', |
| 1610 | git_cl.GetTargetRef('origin', 'refs/remotes/origin/master', |
Andrii Shyshkalov | f3a20ae | 2017-01-24 21:23:57 +0100 | [diff] [blame] | 1611 | None)) |
wittman@chromium.org | 455dc92 | 2015-01-26 20:15:50 +0000 | [diff] [blame] | 1612 | self.assertEqual('refs/heads/master', |
| 1613 | git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkgr', |
Andrii Shyshkalov | f3a20ae | 2017-01-24 21:23:57 +0100 | [diff] [blame] | 1614 | None)) |
wittman@chromium.org | 455dc92 | 2015-01-26 20:15:50 +0000 | [diff] [blame] | 1615 | self.assertEqual('refs/heads/master', |
| 1616 | git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkcr', |
Andrii Shyshkalov | f3a20ae | 2017-01-24 21:23:57 +0100 | [diff] [blame] | 1617 | None)) |
wittman@chromium.org | 455dc92 | 2015-01-26 20:15:50 +0000 | [diff] [blame] | 1618 | self.assertEqual('refs/branch-heads/123', |
| 1619 | git_cl.GetTargetRef('origin', |
| 1620 | 'refs/remotes/branch-heads/123', |
Andrii Shyshkalov | f3a20ae | 2017-01-24 21:23:57 +0100 | [diff] [blame] | 1621 | None)) |
wittman@chromium.org | 455dc92 | 2015-01-26 20:15:50 +0000 | [diff] [blame] | 1622 | self.assertEqual('refs/diff/test', |
| 1623 | git_cl.GetTargetRef('origin', |
| 1624 | 'refs/remotes/origin/refs/diff/test', |
Andrii Shyshkalov | f3a20ae | 2017-01-24 21:23:57 +0100 | [diff] [blame] | 1625 | None)) |
rmistry@google.com | c68112d | 2015-03-03 12:48:06 +0000 | [diff] [blame] | 1626 | self.assertEqual('refs/heads/chrome/m42', |
| 1627 | git_cl.GetTargetRef('origin', |
| 1628 | 'refs/remotes/origin/chrome/m42', |
Andrii Shyshkalov | f3a20ae | 2017-01-24 21:23:57 +0100 | [diff] [blame] | 1629 | None)) |
wittman@chromium.org | 455dc92 | 2015-01-26 20:15:50 +0000 | [diff] [blame] | 1630 | |
| 1631 | # Check target refs for user-specified target branch. |
| 1632 | for branch in ('branch-heads/123', 'remotes/branch-heads/123', |
| 1633 | 'refs/remotes/branch-heads/123'): |
| 1634 | self.assertEqual('refs/branch-heads/123', |
| 1635 | git_cl.GetTargetRef('origin', |
| 1636 | 'refs/remotes/origin/master', |
Andrii Shyshkalov | f3a20ae | 2017-01-24 21:23:57 +0100 | [diff] [blame] | 1637 | branch)) |
wittman@chromium.org | 455dc92 | 2015-01-26 20:15:50 +0000 | [diff] [blame] | 1638 | for branch in ('origin/master', 'remotes/origin/master', |
| 1639 | 'refs/remotes/origin/master'): |
| 1640 | self.assertEqual('refs/heads/master', |
| 1641 | git_cl.GetTargetRef('origin', |
| 1642 | 'refs/remotes/branch-heads/123', |
Andrii Shyshkalov | f3a20ae | 2017-01-24 21:23:57 +0100 | [diff] [blame] | 1643 | branch)) |
wittman@chromium.org | 455dc92 | 2015-01-26 20:15:50 +0000 | [diff] [blame] | 1644 | for branch in ('master', 'heads/master', 'refs/heads/master'): |
| 1645 | self.assertEqual('refs/heads/master', |
| 1646 | git_cl.GetTargetRef('origin', |
| 1647 | 'refs/remotes/branch-heads/123', |
Andrii Shyshkalov | f3a20ae | 2017-01-24 21:23:57 +0100 | [diff] [blame] | 1648 | branch)) |
wittman@chromium.org | 455dc92 | 2015-01-26 20:15:50 +0000 | [diff] [blame] | 1649 | |
Edward Lemur | da4b6c6 | 2020-02-13 00:28:40 +0000 | [diff] [blame] | 1650 | @mock.patch('git_common.is_dirty_git_tree', return_value=True) |
| 1651 | def test_patch_when_dirty(self, *_mocks): |
Quinten Yearsley | d9cbe7a | 2019-09-03 16:49:11 +0000 | [diff] [blame] | 1652 | # Patch when local tree is dirty. |
wychen@chromium.org | a872e75 | 2015-04-28 23:42:18 +0000 | [diff] [blame] | 1653 | self.assertNotEqual(git_cl.main(['patch', '123456']), 0) |
| 1654 | |
Edward Lemur | 8515328 | 2020-02-14 22:06:29 +0000 | [diff] [blame] | 1655 | def assertIssueAndPatchset( |
| 1656 | self, branch='master', issue='123456', patchset='7', |
| 1657 | git_short_host='chromium'): |
| 1658 | self.assertEqual( |
Edward Lemur | 2696407 | 2020-02-19 19:18:51 +0000 | [diff] [blame] | 1659 | issue, scm.GIT.GetBranchConfig('', branch, 'gerritissue')) |
Edward Lemur | 8515328 | 2020-02-14 22:06:29 +0000 | [diff] [blame] | 1660 | self.assertEqual( |
Edward Lemur | 2696407 | 2020-02-19 19:18:51 +0000 | [diff] [blame] | 1661 | patchset, scm.GIT.GetBranchConfig('', branch, 'gerritpatchset')) |
Edward Lemur | 8515328 | 2020-02-14 22:06:29 +0000 | [diff] [blame] | 1662 | self.assertEqual( |
| 1663 | 'https://%s-review.googlesource.com' % git_short_host, |
Edward Lemur | 2696407 | 2020-02-19 19:18:51 +0000 | [diff] [blame] | 1664 | scm.GIT.GetBranchConfig('', branch, 'gerritserver')) |
Andrii Shyshkalov | 8fc0c1d | 2017-01-26 09:38:10 +0100 | [diff] [blame] | 1665 | |
Edward Lemur | 8515328 | 2020-02-14 22:06:29 +0000 | [diff] [blame] | 1666 | def _patch_common(self, git_short_host='chromium'): |
Edward Lemur | da4b6c6 | 2020-02-13 00:28:40 +0000 | [diff] [blame] | 1667 | mock.patch('git_cl.IsGitVersionAtLeast', return_value=True).start() |
Edward Lemur | 2696407 | 2020-02-19 19:18:51 +0000 | [diff] [blame] | 1668 | self.mockGit.config['remote.origin.url'] = ( |
| 1669 | 'https://%s.googlesource.com/my/repo' % git_short_host) |
Edward Lesmes | 7677e5c | 2020-02-19 20:39:03 +0000 | [diff] [blame] | 1670 | gerrit_util.GetChangeDetail.return_value = { |
| 1671 | 'current_revision': '7777777777', |
| 1672 | 'revisions': { |
| 1673 | '1111111111': { |
| 1674 | '_number': 1, |
| 1675 | 'fetch': {'http': { |
| 1676 | 'url': 'https://%s.googlesource.com/my/repo' % git_short_host, |
| 1677 | 'ref': 'refs/changes/56/123456/1', |
| 1678 | }}, |
| 1679 | }, |
| 1680 | '7777777777': { |
| 1681 | '_number': 7, |
| 1682 | 'fetch': {'http': { |
| 1683 | 'url': 'https://%s.googlesource.com/my/repo' % git_short_host, |
| 1684 | 'ref': 'refs/changes/56/123456/7', |
| 1685 | }}, |
| 1686 | }, |
| 1687 | }, |
| 1688 | } |
wychen@chromium.org | a872e75 | 2015-04-28 23:42:18 +0000 | [diff] [blame] | 1689 | |
Andrii Shyshkalov | c971239 | 2017-04-11 13:35:21 +0200 | [diff] [blame] | 1690 | def test_patch_gerrit_default(self): |
Edward Lemur | 8515328 | 2020-02-14 22:06:29 +0000 | [diff] [blame] | 1691 | self._patch_common() |
tandrii@chromium.org | f86c7d3 | 2016-04-01 19:27:30 +0000 | [diff] [blame] | 1692 | self.calls += [ |
| 1693 | ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo', |
| 1694 | 'refs/changes/56/123456/7'],), ''), |
Aaron Gable | 62619a3 | 2017-06-16 08:22:09 -0700 | [diff] [blame] | 1695 | ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''), |
Aaron Gable | 9387b4f | 2017-06-08 10:50:03 -0700 | [diff] [blame] | 1696 | ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'), |
tandrii@chromium.org | f86c7d3 | 2016-04-01 19:27:30 +0000 | [diff] [blame] | 1697 | ] |
| 1698 | self.assertEqual(git_cl.main(['patch', '123456']), 0) |
Edward Lemur | 8515328 | 2020-02-14 22:06:29 +0000 | [diff] [blame] | 1699 | self.assertIssueAndPatchset() |
tandrii@chromium.org | f86c7d3 | 2016-04-01 19:27:30 +0000 | [diff] [blame] | 1700 | |
Andrii Shyshkalov | f57841b | 2018-08-28 00:48:53 +0000 | [diff] [blame] | 1701 | def test_patch_gerrit_new_branch(self): |
Edward Lemur | 8515328 | 2020-02-14 22:06:29 +0000 | [diff] [blame] | 1702 | self._patch_common() |
Andrii Shyshkalov | f57841b | 2018-08-28 00:48:53 +0000 | [diff] [blame] | 1703 | self.calls += [ |
| 1704 | ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo', |
| 1705 | 'refs/changes/56/123456/7'],), ''), |
| 1706 | ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''), |
Andrii Shyshkalov | f57841b | 2018-08-28 00:48:53 +0000 | [diff] [blame] | 1707 | ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'), |
Andrii Shyshkalov | f57841b | 2018-08-28 00:48:53 +0000 | [diff] [blame] | 1708 | ] |
Edward Lemur | 8515328 | 2020-02-14 22:06:29 +0000 | [diff] [blame] | 1709 | self.assertEqual(git_cl.main(['patch', '-b', 'feature', '123456']), 0) |
| 1710 | self.assertIssueAndPatchset(branch='feature') |
Andrii Shyshkalov | f57841b | 2018-08-28 00:48:53 +0000 | [diff] [blame] | 1711 | |
Andrii Shyshkalov | c971239 | 2017-04-11 13:35:21 +0200 | [diff] [blame] | 1712 | def test_patch_gerrit_force(self): |
Edward Lemur | 8515328 | 2020-02-14 22:06:29 +0000 | [diff] [blame] | 1713 | self._patch_common('host') |
tandrii@chromium.org | dde6462 | 2016-04-13 17:11:21 +0000 | [diff] [blame] | 1714 | self.calls += [ |
Andrii Shyshkalov | 8fc0c1d | 2017-01-26 09:38:10 +0100 | [diff] [blame] | 1715 | ((['git', 'fetch', 'https://host.googlesource.com/my/repo', |
tandrii@chromium.org | dde6462 | 2016-04-13 17:11:21 +0000 | [diff] [blame] | 1716 | 'refs/changes/56/123456/7'],), ''), |
Aaron Gable | 9387b4f | 2017-06-08 10:50:03 -0700 | [diff] [blame] | 1717 | ((['git', 'reset', '--hard', 'FETCH_HEAD'],), ''), |
Aaron Gable | 9387b4f | 2017-06-08 10:50:03 -0700 | [diff] [blame] | 1718 | ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'), |
tandrii@chromium.org | dde6462 | 2016-04-13 17:11:21 +0000 | [diff] [blame] | 1719 | ] |
Edward Lemur | 52969c9 | 2020-02-06 18:15:28 +0000 | [diff] [blame] | 1720 | self.assertEqual(git_cl.main(['patch', '123456', '--force']), 0) |
Edward Lemur | 8515328 | 2020-02-14 22:06:29 +0000 | [diff] [blame] | 1721 | self.assertIssueAndPatchset(git_short_host='host') |
tandrii@chromium.org | dde6462 | 2016-04-13 17:11:21 +0000 | [diff] [blame] | 1722 | |
Andrii Shyshkalov | c971239 | 2017-04-11 13:35:21 +0200 | [diff] [blame] | 1723 | def test_patch_gerrit_guess_by_url(self): |
Edward Lemur | 8515328 | 2020-02-14 22:06:29 +0000 | [diff] [blame] | 1724 | self._patch_common('else') |
tandrii@chromium.org | f86c7d3 | 2016-04-01 19:27:30 +0000 | [diff] [blame] | 1725 | self.calls += [ |
Andrii Shyshkalov | 8fc0c1d | 2017-01-26 09:38:10 +0100 | [diff] [blame] | 1726 | ((['git', 'fetch', 'https://else.googlesource.com/my/repo', |
tandrii@chromium.org | f86c7d3 | 2016-04-01 19:27:30 +0000 | [diff] [blame] | 1727 | 'refs/changes/56/123456/1'],), ''), |
Aaron Gable | 62619a3 | 2017-06-16 08:22:09 -0700 | [diff] [blame] | 1728 | ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''), |
Aaron Gable | 9387b4f | 2017-06-08 10:50:03 -0700 | [diff] [blame] | 1729 | ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'), |
tandrii@chromium.org | f86c7d3 | 2016-04-01 19:27:30 +0000 | [diff] [blame] | 1730 | ] |
| 1731 | self.assertEqual(git_cl.main( |
Andrii Shyshkalov | 8fc0c1d | 2017-01-26 09:38:10 +0100 | [diff] [blame] | 1732 | ['patch', 'https://else-review.googlesource.com/#/c/123456/1']), 0) |
Edward Lemur | 8515328 | 2020-02-14 22:06:29 +0000 | [diff] [blame] | 1733 | self.assertIssueAndPatchset(patchset='1', git_short_host='else') |
tandrii@chromium.org | f86c7d3 | 2016-04-01 19:27:30 +0000 | [diff] [blame] | 1734 | |
Aaron Gable | 697a91b | 2018-01-19 15:20:15 -0800 | [diff] [blame] | 1735 | def test_patch_gerrit_guess_by_url_with_repo(self): |
Edward Lemur | 8515328 | 2020-02-14 22:06:29 +0000 | [diff] [blame] | 1736 | self._patch_common('else') |
Aaron Gable | 697a91b | 2018-01-19 15:20:15 -0800 | [diff] [blame] | 1737 | self.calls += [ |
| 1738 | ((['git', 'fetch', 'https://else.googlesource.com/my/repo', |
| 1739 | 'refs/changes/56/123456/1'],), ''), |
| 1740 | ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''), |
Aaron Gable | 697a91b | 2018-01-19 15:20:15 -0800 | [diff] [blame] | 1741 | ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'), |
Aaron Gable | 697a91b | 2018-01-19 15:20:15 -0800 | [diff] [blame] | 1742 | ] |
| 1743 | self.assertEqual(git_cl.main( |
| 1744 | ['patch', 'https://else-review.googlesource.com/c/my/repo/+/123456/1']), |
| 1745 | 0) |
Edward Lemur | 8515328 | 2020-02-14 22:06:29 +0000 | [diff] [blame] | 1746 | self.assertIssueAndPatchset(patchset='1', git_short_host='else') |
Aaron Gable | 697a91b | 2018-01-19 15:20:15 -0800 | [diff] [blame] | 1747 | |
Edward Lemur | d55c507 | 2020-02-20 01:09:07 +0000 | [diff] [blame] | 1748 | @mock.patch('sys.stderr', StringIO()) |
Andrii Shyshkalov | c971239 | 2017-04-11 13:35:21 +0200 | [diff] [blame] | 1749 | def test_patch_gerrit_conflict(self): |
Edward Lemur | 8515328 | 2020-02-14 22:06:29 +0000 | [diff] [blame] | 1750 | self._patch_common() |
tandrii@chromium.org | f86c7d3 | 2016-04-01 19:27:30 +0000 | [diff] [blame] | 1751 | self.calls += [ |
| 1752 | ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo', |
Andrii Shyshkalov | c971239 | 2017-04-11 13:35:21 +0200 | [diff] [blame] | 1753 | 'refs/changes/56/123456/7'],), ''), |
tandrii | 5d48c32 | 2016-08-18 16:19:37 -0700 | [diff] [blame] | 1754 | ((['git', 'cherry-pick', 'FETCH_HEAD'],), CERR1), |
tandrii@chromium.org | f86c7d3 | 2016-04-01 19:27:30 +0000 | [diff] [blame] | 1755 | ] |
| 1756 | with self.assertRaises(SystemExitMock): |
Andrii Shyshkalov | c971239 | 2017-04-11 13:35:21 +0200 | [diff] [blame] | 1757 | git_cl.main(['patch', '123456']) |
Edward Lemur | d55c507 | 2020-02-20 01:09:07 +0000 | [diff] [blame] | 1758 | self.assertEqual( |
| 1759 | 'Command "git cherry-pick FETCH_HEAD" failed.\n\n', |
| 1760 | sys.stderr.getvalue()) |
tandrii@chromium.org | f86c7d3 | 2016-04-01 19:27:30 +0000 | [diff] [blame] | 1761 | |
Edward Lemur | da4b6c6 | 2020-02-13 00:28:40 +0000 | [diff] [blame] | 1762 | @mock.patch( |
Edward Lesmes | 7677e5c | 2020-02-19 20:39:03 +0000 | [diff] [blame] | 1763 | 'gerrit_util.GetChangeDetail', |
Edward Lemur | da4b6c6 | 2020-02-13 00:28:40 +0000 | [diff] [blame] | 1764 | side_effect=gerrit_util.GerritError(404, '')) |
Edward Lemur | d55c507 | 2020-02-20 01:09:07 +0000 | [diff] [blame] | 1765 | @mock.patch('sys.stderr', StringIO()) |
Edward Lemur | da4b6c6 | 2020-02-13 00:28:40 +0000 | [diff] [blame] | 1766 | def test_patch_gerrit_not_exists(self, *_mocks): |
Edward Lemur | 2696407 | 2020-02-19 19:18:51 +0000 | [diff] [blame] | 1767 | self.mockGit.config['remote.origin.url'] = ( |
| 1768 | 'https://chromium.googlesource.com/my/repo') |
tandrii | c2405f5 | 2016-10-10 08:13:15 -0700 | [diff] [blame] | 1769 | with self.assertRaises(SystemExitMock): |
Andrii Shyshkalov | c971239 | 2017-04-11 13:35:21 +0200 | [diff] [blame] | 1770 | self.assertEqual(1, git_cl.main(['patch', '123456'])) |
Edward Lemur | d55c507 | 2020-02-20 01:09:07 +0000 | [diff] [blame] | 1771 | self.assertEqual( |
| 1772 | 'change 123456 at https://chromium-review.googlesource.com does not ' |
| 1773 | 'exist or you have no access to it\n', |
| 1774 | sys.stderr.getvalue()) |
tandrii | c2405f5 | 2016-10-10 08:13:15 -0700 | [diff] [blame] | 1775 | |
tandrii@chromium.org | 5df290f | 2016-04-11 16:12:29 +0000 | [diff] [blame] | 1776 | def _checkout_calls(self): |
| 1777 | return [ |
| 1778 | ((['git', 'config', '--local', '--get-regexp', |
tandrii@chromium.org | 5df290f | 2016-04-11 16:12:29 +0000 | [diff] [blame] | 1779 | 'branch\\..*\\.gerritissue'], ), |
| 1780 | ('branch.ger-branch.gerritissue 123456\n' |
| 1781 | 'branch.gbranch654.gerritissue 654321\n')), |
| 1782 | ] |
| 1783 | |
| 1784 | def test_checkout_gerrit(self): |
| 1785 | """Tests git cl checkout <issue>.""" |
| 1786 | self.calls = self._checkout_calls() |
| 1787 | self.calls += [((['git', 'checkout', 'ger-branch'], ), '')] |
| 1788 | self.assertEqual(0, git_cl.main(['checkout', '123456'])) |
| 1789 | |
tandrii@chromium.org | 5df290f | 2016-04-11 16:12:29 +0000 | [diff] [blame] | 1790 | def test_checkout_not_found(self): |
| 1791 | """Tests git cl checkout <issue>.""" |
| 1792 | self.calls = self._checkout_calls() |
| 1793 | self.assertEqual(1, git_cl.main(['checkout', '99999'])) |
| 1794 | |
tandrii@chromium.org | 26c8fd2 | 2016-04-11 21:33:21 +0000 | [diff] [blame] | 1795 | def test_checkout_no_branch_issues(self): |
| 1796 | """Tests git cl checkout <issue>.""" |
| 1797 | self.calls = [ |
| 1798 | ((['git', 'config', '--local', '--get-regexp', |
tandrii | 5d48c32 | 2016-08-18 16:19:37 -0700 | [diff] [blame] | 1799 | 'branch\\..*\\.gerritissue'], ), CERR1), |
tandrii@chromium.org | 26c8fd2 | 2016-04-11 21:33:21 +0000 | [diff] [blame] | 1800 | ] |
| 1801 | self.assertEqual(1, git_cl.main(['checkout', '99999'])) |
| 1802 | |
Edward Lemur | 2696407 | 2020-02-19 19:18:51 +0000 | [diff] [blame] | 1803 | def _test_gerrit_ensure_authenticated_common(self, auth): |
Edward Lemur | da4b6c6 | 2020-02-13 00:28:40 +0000 | [diff] [blame] | 1804 | mock.patch('git_cl.gerrit_util.CookiesAuthenticator', |
| 1805 | CookiesAuthenticatorMockFactory(hosts_with_creds=auth)).start() |
Edward Lemur | 2696407 | 2020-02-19 19:18:51 +0000 | [diff] [blame] | 1806 | self.mockGit.config['remote.origin.url'] = ( |
| 1807 | 'https://chromium.googlesource.com/my/repo') |
Edward Lemur | f38bc17 | 2019-09-03 21:02:13 +0000 | [diff] [blame] | 1808 | cl = git_cl.Changelist() |
tandrii@chromium.org | 2825353 | 2016-04-14 13:46:56 +0000 | [diff] [blame] | 1809 | cl.branch = 'master' |
| 1810 | cl.branchref = 'refs/heads/master' |
tandrii@chromium.org | fe30f18 | 2016-04-13 12:15:04 +0000 | [diff] [blame] | 1811 | return cl |
| 1812 | |
Edward Lemur | d55c507 | 2020-02-20 01:09:07 +0000 | [diff] [blame] | 1813 | @mock.patch('sys.stderr', StringIO()) |
tandrii@chromium.org | fe30f18 | 2016-04-13 12:15:04 +0000 | [diff] [blame] | 1814 | def test_gerrit_ensure_authenticated_missing(self): |
| 1815 | cl = self._test_gerrit_ensure_authenticated_common(auth={ |
Andrii Shyshkalov | bb86fbb | 2017-03-24 14:59:28 +0100 | [diff] [blame] | 1816 | 'chromium.googlesource.com': ('git-is.ok', '', 'but gerrit is missing'), |
tandrii@chromium.org | fe30f18 | 2016-04-13 12:15:04 +0000 | [diff] [blame] | 1817 | }) |
Edward Lemur | d55c507 | 2020-02-20 01:09:07 +0000 | [diff] [blame] | 1818 | with self.assertRaises(SystemExitMock): |
| 1819 | cl.EnsureAuthenticated(force=False) |
| 1820 | self.assertEqual( |
| 1821 | 'Credentials for the following hosts are required:\n' |
| 1822 | ' chromium-review.googlesource.com\n' |
| 1823 | 'These are read from ~/.gitcookies (or legacy ~/.netrc)\n' |
| 1824 | 'You can (re)generate your credentials by visiting ' |
| 1825 | 'https://chromium-review.googlesource.com/new-password\n', |
| 1826 | sys.stderr.getvalue()) |
tandrii@chromium.org | fe30f18 | 2016-04-13 12:15:04 +0000 | [diff] [blame] | 1827 | |
| 1828 | def test_gerrit_ensure_authenticated_conflict(self): |
| 1829 | cl = self._test_gerrit_ensure_authenticated_common(auth={ |
Andrii Shyshkalov | bb86fbb | 2017-03-24 14:59:28 +0100 | [diff] [blame] | 1830 | 'chromium.googlesource.com': |
| 1831 | ('git-one.example.com', None, 'secret1'), |
| 1832 | 'chromium-review.googlesource.com': |
| 1833 | ('git-other.example.com', None, 'secret2'), |
tandrii@chromium.org | fe30f18 | 2016-04-13 12:15:04 +0000 | [diff] [blame] | 1834 | }) |
| 1835 | self.calls.append( |
Andrii Shyshkalov | abc26ac | 2017-03-14 14:49:38 +0100 | [diff] [blame] | 1836 | (('ask_for_data', 'If you know what you are doing ' |
| 1837 | 'press Enter to continue, or Ctrl+C to abort'), '')) |
tandrii@chromium.org | fe30f18 | 2016-04-13 12:15:04 +0000 | [diff] [blame] | 1838 | self.assertIsNone(cl.EnsureAuthenticated(force=False)) |
| 1839 | |
| 1840 | def test_gerrit_ensure_authenticated_ok(self): |
| 1841 | cl = self._test_gerrit_ensure_authenticated_common(auth={ |
Andrii Shyshkalov | bb86fbb | 2017-03-24 14:59:28 +0100 | [diff] [blame] | 1842 | 'chromium.googlesource.com': |
| 1843 | ('git-same.example.com', None, 'secret'), |
| 1844 | 'chromium-review.googlesource.com': |
| 1845 | ('git-same.example.com', None, 'secret'), |
tandrii@chromium.org | fe30f18 | 2016-04-13 12:15:04 +0000 | [diff] [blame] | 1846 | }) |
| 1847 | self.assertIsNone(cl.EnsureAuthenticated(force=False)) |
| 1848 | |
tandrii@chromium.org | 2825353 | 2016-04-14 13:46:56 +0000 | [diff] [blame] | 1849 | def test_gerrit_ensure_authenticated_skipped(self): |
Edward Lemur | 2696407 | 2020-02-19 19:18:51 +0000 | [diff] [blame] | 1850 | self.mockGit.config['gerrit.skip-ensure-authenticated'] = 'true' |
| 1851 | cl = self._test_gerrit_ensure_authenticated_common(auth={}) |
tandrii@chromium.org | 2825353 | 2016-04-14 13:46:56 +0000 | [diff] [blame] | 1852 | self.assertIsNone(cl.EnsureAuthenticated(force=False)) |
| 1853 | |
Eric Boren | 2fb6310 | 2018-10-05 13:05:03 +0000 | [diff] [blame] | 1854 | def test_gerrit_ensure_authenticated_bearer_token(self): |
| 1855 | cl = self._test_gerrit_ensure_authenticated_common(auth={ |
| 1856 | 'chromium.googlesource.com': |
| 1857 | ('', None, 'secret'), |
| 1858 | 'chromium-review.googlesource.com': |
| 1859 | ('', None, 'secret'), |
| 1860 | }) |
| 1861 | self.assertIsNone(cl.EnsureAuthenticated(force=False)) |
| 1862 | header = gerrit_util.CookiesAuthenticator().get_auth_header( |
| 1863 | 'chromium.googlesource.com') |
| 1864 | self.assertTrue('Bearer' in header) |
| 1865 | |
Daniel Cheng | cf6269b | 2019-05-18 01:02:12 +0000 | [diff] [blame] | 1866 | def test_gerrit_ensure_authenticated_non_https(self): |
Edward Lemur | 2696407 | 2020-02-19 19:18:51 +0000 | [diff] [blame] | 1867 | self.mockGit.config['remote.origin.url'] = 'custom-scheme://repo' |
Daniel Cheng | cf6269b | 2019-05-18 01:02:12 +0000 | [diff] [blame] | 1868 | self.calls = [ |
Josip | 906bfde | 2020-01-31 22:38:49 +0000 | [diff] [blame] | 1869 | (('logging.warning', |
| 1870 | 'Ignoring branch %(branch)s with non-https remote ' |
| 1871 | '%(remote)s', { |
| 1872 | 'branch': 'master', |
| 1873 | 'remote': 'custom-scheme://repo'} |
| 1874 | ), None), |
Daniel Cheng | cf6269b | 2019-05-18 01:02:12 +0000 | [diff] [blame] | 1875 | ] |
Edward Lemur | da4b6c6 | 2020-02-13 00:28:40 +0000 | [diff] [blame] | 1876 | mock.patch('git_cl.gerrit_util.CookiesAuthenticator', |
| 1877 | CookiesAuthenticatorMockFactory(hosts_with_creds={})).start() |
| 1878 | mock.patch('logging.warning', |
| 1879 | lambda *a: self._mocked_call('logging.warning', *a)).start() |
Edward Lemur | f38bc17 | 2019-09-03 21:02:13 +0000 | [diff] [blame] | 1880 | cl = git_cl.Changelist() |
Daniel Cheng | cf6269b | 2019-05-18 01:02:12 +0000 | [diff] [blame] | 1881 | cl.branch = 'master' |
| 1882 | cl.branchref = 'refs/heads/master' |
| 1883 | cl.lookedup_issue = True |
| 1884 | self.assertIsNone(cl.EnsureAuthenticated(force=False)) |
| 1885 | |
Florian Mayer | ae510e8 | 2020-01-30 21:04:48 +0000 | [diff] [blame] | 1886 | def test_gerrit_ensure_authenticated_non_url(self): |
Edward Lemur | 2696407 | 2020-02-19 19:18:51 +0000 | [diff] [blame] | 1887 | self.mockGit.config['remote.origin.url'] = ( |
| 1888 | 'git@somehost.example:foo/bar.git') |
Florian Mayer | ae510e8 | 2020-01-30 21:04:48 +0000 | [diff] [blame] | 1889 | self.calls = [ |
Josip | 906bfde | 2020-01-31 22:38:49 +0000 | [diff] [blame] | 1890 | (('logging.error', |
| 1891 | 'Remote "%(remote)s" for branch "%(branch)s" points to "%(url)s", ' |
| 1892 | 'but it doesn\'t exist.', { |
| 1893 | 'remote': 'origin', |
| 1894 | 'branch': 'master', |
| 1895 | 'url': 'git@somehost.example:foo/bar.git'} |
| 1896 | ), None), |
Florian Mayer | ae510e8 | 2020-01-30 21:04:48 +0000 | [diff] [blame] | 1897 | ] |
Edward Lemur | da4b6c6 | 2020-02-13 00:28:40 +0000 | [diff] [blame] | 1898 | mock.patch('git_cl.gerrit_util.CookiesAuthenticator', |
| 1899 | CookiesAuthenticatorMockFactory(hosts_with_creds={})).start() |
| 1900 | mock.patch('logging.error', |
| 1901 | lambda *a: self._mocked_call('logging.error', *a)).start() |
Florian Mayer | ae510e8 | 2020-01-30 21:04:48 +0000 | [diff] [blame] | 1902 | cl = git_cl.Changelist() |
| 1903 | cl.branch = 'master' |
| 1904 | cl.branchref = 'refs/heads/master' |
| 1905 | cl.lookedup_issue = True |
| 1906 | self.assertIsNone(cl.EnsureAuthenticated(force=False)) |
| 1907 | |
Andrii Shyshkalov | 828701b | 2016-12-09 10:46:47 +0100 | [diff] [blame] | 1908 | def _cmd_set_commit_gerrit_common(self, vote, notify=None): |
Edward Lemur | 8515328 | 2020-02-14 22:06:29 +0000 | [diff] [blame] | 1909 | self.mockGit.config['branch.master.gerritissue'] = '123' |
| 1910 | self.mockGit.config['branch.master.gerritserver'] = ( |
| 1911 | 'https://chromium-review.googlesource.com') |
Edward Lemur | 2696407 | 2020-02-19 19:18:51 +0000 | [diff] [blame] | 1912 | self.mockGit.config['remote.origin.url'] = ( |
| 1913 | 'https://chromium.googlesource.com/infra/infra') |
tandrii@chromium.org | fa330e8 | 2016-04-13 17:09:52 +0000 | [diff] [blame] | 1914 | self.calls = [ |
Edward Lemur | da4b6c6 | 2020-02-13 00:28:40 +0000 | [diff] [blame] | 1915 | (('SetReview', 'chromium-review.googlesource.com', |
| 1916 | 'infra%2Finfra~123', None, |
| 1917 | {'Commit-Queue': vote}, notify, None), ''), |
tandrii@chromium.org | fa330e8 | 2016-04-13 17:09:52 +0000 | [diff] [blame] | 1918 | ] |
tandrii | d9e5ce5 | 2016-07-13 02:32:59 -0700 | [diff] [blame] | 1919 | |
| 1920 | def test_cmd_set_commit_gerrit_clear(self): |
| 1921 | self._cmd_set_commit_gerrit_common(0) |
| 1922 | self.assertEqual(0, git_cl.main(['set-commit', '-c'])) |
| 1923 | |
| 1924 | def test_cmd_set_commit_gerrit_dry(self): |
Aaron Gable | 75e7872 | 2017-06-09 10:40:16 -0700 | [diff] [blame] | 1925 | self._cmd_set_commit_gerrit_common(1, notify=False) |
tandrii@chromium.org | fa330e8 | 2016-04-13 17:09:52 +0000 | [diff] [blame] | 1926 | self.assertEqual(0, git_cl.main(['set-commit', '-d'])) |
| 1927 | |
tandrii | d9e5ce5 | 2016-07-13 02:32:59 -0700 | [diff] [blame] | 1928 | def test_cmd_set_commit_gerrit(self): |
| 1929 | self._cmd_set_commit_gerrit_common(2) |
| 1930 | self.assertEqual(0, git_cl.main(['set-commit'])) |
| 1931 | |
martiniss@chromium.org | 2b55fe3 | 2016-04-26 20:28:54 +0000 | [diff] [blame] | 1932 | def test_description_display(self): |
Edward Lemur | da4b6c6 | 2020-02-13 00:28:40 +0000 | [diff] [blame] | 1933 | mock.patch('git_cl.Changelist', ChangelistMock).start() |
martiniss@chromium.org | d6648e2 | 2016-04-29 19:22:16 +0000 | [diff] [blame] | 1934 | ChangelistMock.desc = 'foo\n' |
martiniss@chromium.org | 2b55fe3 | 2016-04-26 20:28:54 +0000 | [diff] [blame] | 1935 | |
| 1936 | self.assertEqual(0, git_cl.main(['description', '-d'])) |
Edward Lemur | da4b6c6 | 2020-02-13 00:28:40 +0000 | [diff] [blame] | 1937 | self.assertEqual('foo\n', sys.stdout.getvalue()) |
martiniss@chromium.org | 2b55fe3 | 2016-04-26 20:28:54 +0000 | [diff] [blame] | 1938 | |
Edward Lemur | da4b6c6 | 2020-02-13 00:28:40 +0000 | [diff] [blame] | 1939 | @mock.patch('sys.stderr', StringIO()) |
iannucci | 3c972b9 | 2016-08-17 13:24:10 -0700 | [diff] [blame] | 1940 | def test_StatusFieldOverrideIssueMissingArgs(self): |
iannucci | 3c972b9 | 2016-08-17 13:24:10 -0700 | [diff] [blame] | 1941 | try: |
| 1942 | self.assertEqual(git_cl.main(['status', '--issue', '1']), 0) |
Edward Lemur | d55c507 | 2020-02-20 01:09:07 +0000 | [diff] [blame] | 1943 | except SystemExitMock: |
Edward Lemur | 6c6827c | 2020-02-06 21:15:18 +0000 | [diff] [blame] | 1944 | self.assertIn( |
Edward Lemur | da4b6c6 | 2020-02-13 00:28:40 +0000 | [diff] [blame] | 1945 | '--field must be given when --issue is set.', sys.stderr.getvalue()) |
iannucci | 3c972b9 | 2016-08-17 13:24:10 -0700 | [diff] [blame] | 1946 | |
| 1947 | def test_StatusFieldOverrideIssue(self): |
iannucci | 3c972b9 | 2016-08-17 13:24:10 -0700 | [diff] [blame] | 1948 | def assertIssue(cl_self, *_args): |
Raphael Kubo da Costa | e9342a7 | 2019-10-14 17:49:39 +0000 | [diff] [blame] | 1949 | self.assertEqual(cl_self.issue, 1) |
iannucci | 3c972b9 | 2016-08-17 13:24:10 -0700 | [diff] [blame] | 1950 | return 'foobar' |
| 1951 | |
Edward Lemur | da4b6c6 | 2020-02-13 00:28:40 +0000 | [diff] [blame] | 1952 | mock.patch('git_cl.Changelist.FetchDescription', assertIssue).start() |
iannucci | e53c935 | 2016-08-17 14:40:40 -0700 | [diff] [blame] | 1953 | self.assertEqual( |
Edward Lemur | 52969c9 | 2020-02-06 18:15:28 +0000 | [diff] [blame] | 1954 | git_cl.main(['status', '--issue', '1', '--field', 'desc']), |
iannucci | e53c935 | 2016-08-17 14:40:40 -0700 | [diff] [blame] | 1955 | 0) |
Edward Lemur | da4b6c6 | 2020-02-13 00:28:40 +0000 | [diff] [blame] | 1956 | self.assertEqual(sys.stdout.getvalue(), 'foobar\n') |
iannucci | 3c972b9 | 2016-08-17 13:24:10 -0700 | [diff] [blame] | 1957 | |
iannucci | e53c935 | 2016-08-17 14:40:40 -0700 | [diff] [blame] | 1958 | def test_SetCloseOverrideIssue(self): |
Quinten Yearsley | d9cbe7a | 2019-09-03 16:49:11 +0000 | [diff] [blame] | 1959 | |
iannucci | e53c935 | 2016-08-17 14:40:40 -0700 | [diff] [blame] | 1960 | def assertIssue(cl_self, *_args): |
Raphael Kubo da Costa | e9342a7 | 2019-10-14 17:49:39 +0000 | [diff] [blame] | 1961 | self.assertEqual(cl_self.issue, 1) |
iannucci | e53c935 | 2016-08-17 14:40:40 -0700 | [diff] [blame] | 1962 | return 'foobar' |
| 1963 | |
Edward Lemur | da4b6c6 | 2020-02-13 00:28:40 +0000 | [diff] [blame] | 1964 | mock.patch('git_cl.Changelist.FetchDescription', assertIssue).start() |
| 1965 | mock.patch('git_cl.Changelist.CloseIssue', lambda *_: None).start() |
iannucci | e53c935 | 2016-08-17 14:40:40 -0700 | [diff] [blame] | 1966 | self.assertEqual( |
Edward Lemur | 52969c9 | 2020-02-06 18:15:28 +0000 | [diff] [blame] | 1967 | git_cl.main(['set-close', '--issue', '1']), 0) |
iannucci | e53c935 | 2016-08-17 14:40:40 -0700 | [diff] [blame] | 1968 | |
Andrii Shyshkalov | dd672fb | 2018-10-16 06:09:51 +0000 | [diff] [blame] | 1969 | def test_description(self): |
Edward Lemur | 2696407 | 2020-02-19 19:18:51 +0000 | [diff] [blame] | 1970 | self.mockGit.config['remote.origin.url'] = ( |
| 1971 | 'https://chromium.googlesource.com/my/repo') |
Edward Lesmes | 7677e5c | 2020-02-19 20:39:03 +0000 | [diff] [blame] | 1972 | gerrit_util.GetChangeDetail.return_value = { |
| 1973 | 'current_revision': 'sha1', |
| 1974 | 'revisions': {'sha1': { |
| 1975 | 'commit': {'message': 'foobar'}, |
| 1976 | }}, |
| 1977 | } |
martiniss@chromium.org | 2b55fe3 | 2016-04-26 20:28:54 +0000 | [diff] [blame] | 1978 | self.assertEqual(0, git_cl.main([ |
Andrii Shyshkalov | dd672fb | 2018-10-16 06:09:51 +0000 | [diff] [blame] | 1979 | 'description', |
| 1980 | 'https://chromium-review.googlesource.com/c/my/repo/+/123123', |
| 1981 | '-d'])) |
Edward Lemur | da4b6c6 | 2020-02-13 00:28:40 +0000 | [diff] [blame] | 1982 | self.assertEqual('foobar\n', sys.stdout.getvalue()) |
martiniss@chromium.org | 2b55fe3 | 2016-04-26 20:28:54 +0000 | [diff] [blame] | 1983 | |
martiniss@chromium.org | d6648e2 | 2016-04-29 19:22:16 +0000 | [diff] [blame] | 1984 | def test_description_set_raw(self): |
Edward Lemur | da4b6c6 | 2020-02-13 00:28:40 +0000 | [diff] [blame] | 1985 | mock.patch('git_cl.Changelist', ChangelistMock).start() |
| 1986 | mock.patch('git_cl.sys.stdin', StringIO('hihi')).start() |
martiniss@chromium.org | d6648e2 | 2016-04-29 19:22:16 +0000 | [diff] [blame] | 1987 | |
| 1988 | self.assertEqual(0, git_cl.main(['description', '-n', 'hihi'])) |
| 1989 | self.assertEqual('hihi', ChangelistMock.desc) |
| 1990 | |
tandrii@chromium.org | d605a51 | 2016-06-03 09:55:00 +0000 | [diff] [blame] | 1991 | def test_description_appends_bug_line(self): |
tandrii@chromium.org | 601e1d1 | 2016-06-03 13:03:54 +0000 | [diff] [blame] | 1992 | current_desc = 'Some.\n\nChange-Id: xxx' |
tandrii@chromium.org | d605a51 | 2016-06-03 09:55:00 +0000 | [diff] [blame] | 1993 | |
| 1994 | def RunEditor(desc, _, **kwargs): |
Raphael Kubo da Costa | e9342a7 | 2019-10-14 17:49:39 +0000 | [diff] [blame] | 1995 | self.assertEqual( |
tandrii@chromium.org | d605a51 | 2016-06-03 09:55:00 +0000 | [diff] [blame] | 1996 | '# Enter a description of the change.\n' |
| 1997 | '# This will be displayed on the codereview site.\n' |
| 1998 | '# The first line will also be used as the subject of the review.\n' |
| 1999 | '#--------------------This line is 72 characters long' |
tandrii@chromium.org | 601e1d1 | 2016-06-03 13:03:54 +0000 | [diff] [blame] | 2000 | '--------------------\n' |
Aaron Gable | 3a16ed1 | 2017-03-23 10:51:55 -0700 | [diff] [blame] | 2001 | 'Some.\n\nChange-Id: xxx\nBug: ', |
tandrii@chromium.org | d605a51 | 2016-06-03 09:55:00 +0000 | [diff] [blame] | 2002 | desc) |
tandrii@chromium.org | 601e1d1 | 2016-06-03 13:03:54 +0000 | [diff] [blame] | 2003 | # Simulate user changing something. |
Aaron Gable | 3a16ed1 | 2017-03-23 10:51:55 -0700 | [diff] [blame] | 2004 | return 'Some.\n\nChange-Id: xxx\nBug: 123' |
tandrii@chromium.org | d605a51 | 2016-06-03 09:55:00 +0000 | [diff] [blame] | 2005 | |
Edward Lemur | 6c6827c | 2020-02-06 21:15:18 +0000 | [diff] [blame] | 2006 | def UpdateDescription(_, desc, force=False): |
Raphael Kubo da Costa | e9342a7 | 2019-10-14 17:49:39 +0000 | [diff] [blame] | 2007 | self.assertEqual(desc, 'Some.\n\nChange-Id: xxx\nBug: 123') |
tandrii@chromium.org | d605a51 | 2016-06-03 09:55:00 +0000 | [diff] [blame] | 2008 | |
Edward Lemur | da4b6c6 | 2020-02-13 00:28:40 +0000 | [diff] [blame] | 2009 | mock.patch('git_cl.Changelist.FetchDescription', |
| 2010 | lambda *args: current_desc).start() |
| 2011 | mock.patch('git_cl.Changelist.UpdateDescription', |
| 2012 | UpdateDescription).start() |
| 2013 | mock.patch('git_cl.gclient_utils.RunEditor', RunEditor).start() |
tandrii@chromium.org | d605a51 | 2016-06-03 09:55:00 +0000 | [diff] [blame] | 2014 | |
Edward Lemur | 8515328 | 2020-02-14 22:06:29 +0000 | [diff] [blame] | 2015 | self.mockGit.config['branch.master.gerritissue'] = '123' |
Edward Lemur | 52969c9 | 2020-02-06 18:15:28 +0000 | [diff] [blame] | 2016 | self.assertEqual(0, git_cl.main(['description'])) |
tandrii@chromium.org | d605a51 | 2016-06-03 09:55:00 +0000 | [diff] [blame] | 2017 | |
Dan Beam | d8b04ca | 2019-10-10 21:23:26 +0000 | [diff] [blame] | 2018 | def test_description_does_not_append_bug_line_if_fixed_is_present(self): |
| 2019 | current_desc = 'Some.\n\nFixed: 123\nChange-Id: xxx' |
| 2020 | |
| 2021 | def RunEditor(desc, _, **kwargs): |
Raphael Kubo da Costa | e9342a7 | 2019-10-14 17:49:39 +0000 | [diff] [blame] | 2022 | self.assertEqual( |
Dan Beam | d8b04ca | 2019-10-10 21:23:26 +0000 | [diff] [blame] | 2023 | '# Enter a description of the change.\n' |
| 2024 | '# This will be displayed on the codereview site.\n' |
| 2025 | '# The first line will also be used as the subject of the review.\n' |
| 2026 | '#--------------------This line is 72 characters long' |
| 2027 | '--------------------\n' |
| 2028 | 'Some.\n\nFixed: 123\nChange-Id: xxx', |
| 2029 | desc) |
| 2030 | return desc |
| 2031 | |
Edward Lemur | da4b6c6 | 2020-02-13 00:28:40 +0000 | [diff] [blame] | 2032 | mock.patch('git_cl.Changelist.FetchDescription', |
| 2033 | lambda *args: current_desc).start() |
| 2034 | mock.patch('git_cl.gclient_utils.RunEditor', RunEditor).start() |
Dan Beam | d8b04ca | 2019-10-10 21:23:26 +0000 | [diff] [blame] | 2035 | |
Edward Lemur | 8515328 | 2020-02-14 22:06:29 +0000 | [diff] [blame] | 2036 | self.mockGit.config['branch.master.gerritissue'] = '123' |
Edward Lemur | 52969c9 | 2020-02-06 18:15:28 +0000 | [diff] [blame] | 2037 | self.assertEqual(0, git_cl.main(['description'])) |
Dan Beam | d8b04ca | 2019-10-10 21:23:26 +0000 | [diff] [blame] | 2038 | |
martiniss@chromium.org | d6648e2 | 2016-04-29 19:22:16 +0000 | [diff] [blame] | 2039 | def test_description_set_stdin(self): |
Edward Lemur | da4b6c6 | 2020-02-13 00:28:40 +0000 | [diff] [blame] | 2040 | mock.patch('git_cl.Changelist', ChangelistMock).start() |
| 2041 | mock.patch('git_cl.sys.stdin', StringIO('hi \r\n\t there\n\nman')).start() |
martiniss@chromium.org | d6648e2 | 2016-04-29 19:22:16 +0000 | [diff] [blame] | 2042 | |
| 2043 | self.assertEqual(0, git_cl.main(['description', '-n', '-'])) |
| 2044 | self.assertEqual('hi\n\t there\n\nman', ChangelistMock.desc) |
| 2045 | |
kmarshall | 3bff56b | 2016-06-06 18:31:47 -0700 | [diff] [blame] | 2046 | def test_archive(self): |
Quinten Yearsley | d9cbe7a | 2019-09-03 16:49:11 +0000 | [diff] [blame] | 2047 | self.calls = [ |
| 2048 | ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],), |
Edward Lemur | f38bc17 | 2019-09-03 21:02:13 +0000 | [diff] [blame] | 2049 | 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'), |
Kevin Marshall | 0e60ecd | 2019-12-04 17:44:13 +0000 | [diff] [blame] | 2050 | ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''), |
Quinten Yearsley | d9cbe7a | 2019-09-03 16:49:11 +0000 | [diff] [blame] | 2051 | ((['git', 'tag', 'git-cl-archived-456-foo', 'foo'],), ''), |
Edward Lemur | f38bc17 | 2019-09-03 21:02:13 +0000 | [diff] [blame] | 2052 | ((['git', 'branch', '-D', 'foo'],), '') |
Quinten Yearsley | d9cbe7a | 2019-09-03 16:49:11 +0000 | [diff] [blame] | 2053 | ] |
kmarshall | 3bff56b | 2016-06-06 18:31:47 -0700 | [diff] [blame] | 2054 | |
Edward Lemur | da4b6c6 | 2020-02-13 00:28:40 +0000 | [diff] [blame] | 2055 | mock.patch('git_cl.get_cl_statuses', |
kmarshall | 3bff56b | 2016-06-06 18:31:47 -0700 | [diff] [blame] | 2056 | lambda branches, fine_grained, max_processes: |
kmarshall | 9249e01 | 2016-08-23 12:02:16 -0700 | [diff] [blame] | 2057 | [(MockChangelistWithBranchAndIssue('master', 1), 'open'), |
| 2058 | (MockChangelistWithBranchAndIssue('foo', 456), 'closed'), |
Edward Lemur | da4b6c6 | 2020-02-13 00:28:40 +0000 | [diff] [blame] | 2059 | (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start() |
kmarshall | 3bff56b | 2016-06-06 18:31:47 -0700 | [diff] [blame] | 2060 | |
| 2061 | self.assertEqual(0, git_cl.main(['archive', '-f'])) |
| 2062 | |
Kevin Marshall | 0e60ecd | 2019-12-04 17:44:13 +0000 | [diff] [blame] | 2063 | def test_archive_tag_collision(self): |
Kevin Marshall | 0e60ecd | 2019-12-04 17:44:13 +0000 | [diff] [blame] | 2064 | self.calls = [ |
| 2065 | ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],), |
| 2066 | 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'), |
| 2067 | ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), |
| 2068 | 'refs/tags/git-cl-archived-456-foo'), |
Kevin Marshall | 0e60ecd | 2019-12-04 17:44:13 +0000 | [diff] [blame] | 2069 | ((['git', 'tag', 'git-cl-archived-456-foo-2', 'foo'],), ''), |
| 2070 | ((['git', 'branch', '-D', 'foo'],), '') |
| 2071 | ] |
| 2072 | |
Edward Lemur | da4b6c6 | 2020-02-13 00:28:40 +0000 | [diff] [blame] | 2073 | mock.patch('git_cl.get_cl_statuses', |
Kevin Marshall | 0e60ecd | 2019-12-04 17:44:13 +0000 | [diff] [blame] | 2074 | lambda branches, fine_grained, max_processes: |
| 2075 | [(MockChangelistWithBranchAndIssue('master', 1), 'open'), |
| 2076 | (MockChangelistWithBranchAndIssue('foo', 456), 'closed'), |
Edward Lemur | da4b6c6 | 2020-02-13 00:28:40 +0000 | [diff] [blame] | 2077 | (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start() |
Kevin Marshall | 0e60ecd | 2019-12-04 17:44:13 +0000 | [diff] [blame] | 2078 | |
| 2079 | self.assertEqual(0, git_cl.main(['archive', '-f'])) |
| 2080 | |
kmarshall | 3bff56b | 2016-06-06 18:31:47 -0700 | [diff] [blame] | 2081 | def test_archive_current_branch_fails(self): |
Quinten Yearsley | d9cbe7a | 2019-09-03 16:49:11 +0000 | [diff] [blame] | 2082 | self.calls = [ |
| 2083 | ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],), |
| 2084 | 'refs/heads/master'), |
Kevin Marshall | 0e60ecd | 2019-12-04 17:44:13 +0000 | [diff] [blame] | 2085 | ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''), |
Quinten Yearsley | d9cbe7a | 2019-09-03 16:49:11 +0000 | [diff] [blame] | 2086 | ] |
kmarshall | 3bff56b | 2016-06-06 18:31:47 -0700 | [diff] [blame] | 2087 | |
Edward Lemur | da4b6c6 | 2020-02-13 00:28:40 +0000 | [diff] [blame] | 2088 | mock.patch('git_cl.get_cl_statuses', |
kmarshall | 9249e01 | 2016-08-23 12:02:16 -0700 | [diff] [blame] | 2089 | lambda branches, fine_grained, max_processes: |
Edward Lemur | da4b6c6 | 2020-02-13 00:28:40 +0000 | [diff] [blame] | 2090 | [(MockChangelistWithBranchAndIssue('master', 1), |
| 2091 | 'closed')]).start() |
kmarshall | 9249e01 | 2016-08-23 12:02:16 -0700 | [diff] [blame] | 2092 | |
| 2093 | self.assertEqual(1, git_cl.main(['archive', '-f'])) |
| 2094 | |
| 2095 | def test_archive_dry_run(self): |
Quinten Yearsley | d9cbe7a | 2019-09-03 16:49:11 +0000 | [diff] [blame] | 2096 | self.calls = [ |
| 2097 | ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],), |
| 2098 | 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'), |
Kevin Marshall | 0e60ecd | 2019-12-04 17:44:13 +0000 | [diff] [blame] | 2099 | ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''), |
Quinten Yearsley | d9cbe7a | 2019-09-03 16:49:11 +0000 | [diff] [blame] | 2100 | ] |
kmarshall | 3bff56b | 2016-06-06 18:31:47 -0700 | [diff] [blame] | 2101 | |
Edward Lemur | da4b6c6 | 2020-02-13 00:28:40 +0000 | [diff] [blame] | 2102 | mock.patch('git_cl.get_cl_statuses', |
kmarshall | 3bff56b | 2016-06-06 18:31:47 -0700 | [diff] [blame] | 2103 | lambda branches, fine_grained, max_processes: |
kmarshall | 9249e01 | 2016-08-23 12:02:16 -0700 | [diff] [blame] | 2104 | [(MockChangelistWithBranchAndIssue('master', 1), 'open'), |
| 2105 | (MockChangelistWithBranchAndIssue('foo', 456), 'closed'), |
Edward Lemur | da4b6c6 | 2020-02-13 00:28:40 +0000 | [diff] [blame] | 2106 | (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start() |
kmarshall | 3bff56b | 2016-06-06 18:31:47 -0700 | [diff] [blame] | 2107 | |
kmarshall | 9249e01 | 2016-08-23 12:02:16 -0700 | [diff] [blame] | 2108 | self.assertEqual(0, git_cl.main(['archive', '-f', '--dry-run'])) |
| 2109 | |
| 2110 | def test_archive_no_tags(self): |
Quinten Yearsley | d9cbe7a | 2019-09-03 16:49:11 +0000 | [diff] [blame] | 2111 | self.calls = [ |
| 2112 | ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],), |
| 2113 | 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'), |
Kevin Marshall | 0e60ecd | 2019-12-04 17:44:13 +0000 | [diff] [blame] | 2114 | ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''), |
Quinten Yearsley | d9cbe7a | 2019-09-03 16:49:11 +0000 | [diff] [blame] | 2115 | ((['git', 'branch', '-D', 'foo'],), '') |
| 2116 | ] |
kmarshall | 9249e01 | 2016-08-23 12:02:16 -0700 | [diff] [blame] | 2117 | |
Edward Lemur | da4b6c6 | 2020-02-13 00:28:40 +0000 | [diff] [blame] | 2118 | mock.patch('git_cl.get_cl_statuses', |
kmarshall | 9249e01 | 2016-08-23 12:02:16 -0700 | [diff] [blame] | 2119 | lambda branches, fine_grained, max_processes: |
| 2120 | [(MockChangelistWithBranchAndIssue('master', 1), 'open'), |
| 2121 | (MockChangelistWithBranchAndIssue('foo', 456), 'closed'), |
Edward Lemur | da4b6c6 | 2020-02-13 00:28:40 +0000 | [diff] [blame] | 2122 | (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start() |
kmarshall | 9249e01 | 2016-08-23 12:02:16 -0700 | [diff] [blame] | 2123 | |
| 2124 | self.assertEqual(0, git_cl.main(['archive', '-f', '--notags'])) |
kmarshall | 3bff56b | 2016-06-06 18:31:47 -0700 | [diff] [blame] | 2125 | |
Kevin Marshall | 0e60ecd | 2019-12-04 17:44:13 +0000 | [diff] [blame] | 2126 | def test_archive_tag_cleanup_on_branch_deletion_error(self): |
Kevin Marshall | 0e60ecd | 2019-12-04 17:44:13 +0000 | [diff] [blame] | 2127 | self.calls = [ |
| 2128 | ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],), |
| 2129 | 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'), |
| 2130 | ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''), |
Kevin Marshall | 0e60ecd | 2019-12-04 17:44:13 +0000 | [diff] [blame] | 2131 | ((['git', 'tag', 'git-cl-archived-456-foo', 'foo'],), |
| 2132 | 'refs/tags/git-cl-archived-456-foo'), |
| 2133 | ((['git', 'branch', '-D', 'foo'],), CERR1), |
| 2134 | ((['git', 'tag', '-d', 'git-cl-archived-456-foo'],), |
| 2135 | 'refs/tags/git-cl-archived-456-foo'), |
| 2136 | ] |
| 2137 | |
Edward Lemur | da4b6c6 | 2020-02-13 00:28:40 +0000 | [diff] [blame] | 2138 | mock.patch('git_cl.get_cl_statuses', |
Kevin Marshall | 0e60ecd | 2019-12-04 17:44:13 +0000 | [diff] [blame] | 2139 | lambda branches, fine_grained, max_processes: |
| 2140 | [(MockChangelistWithBranchAndIssue('master', 1), 'open'), |
| 2141 | (MockChangelistWithBranchAndIssue('foo', 456), 'closed'), |
Edward Lemur | da4b6c6 | 2020-02-13 00:28:40 +0000 | [diff] [blame] | 2142 | (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start() |
Kevin Marshall | 0e60ecd | 2019-12-04 17:44:13 +0000 | [diff] [blame] | 2143 | |
| 2144 | self.assertEqual(0, git_cl.main(['archive', '-f'])) |
| 2145 | |
tandrii@chromium.org | 9b7fd71 | 2016-06-01 13:45:20 +0000 | [diff] [blame] | 2146 | def test_cmd_issue_erase_existing(self): |
Edward Lemur | 8515328 | 2020-02-14 22:06:29 +0000 | [diff] [blame] | 2147 | self.mockGit.config['branch.master.gerritissue'] = '123' |
| 2148 | self.mockGit.config['branch.master.gerritserver'] = ( |
| 2149 | 'https://chromium-review.googlesource.com') |
tandrii@chromium.org | 9b7fd71 | 2016-06-01 13:45:20 +0000 | [diff] [blame] | 2150 | self.calls = [ |
Aaron Gable | ca01e2c | 2017-07-19 11:16:02 -0700 | [diff] [blame] | 2151 | ((['git', 'log', '-1', '--format=%B'],), 'This is a description'), |
tandrii@chromium.org | 9b7fd71 | 2016-06-01 13:45:20 +0000 | [diff] [blame] | 2152 | ] |
| 2153 | self.assertEqual(0, git_cl.main(['issue', '0'])) |
Edward Lemur | 8515328 | 2020-02-14 22:06:29 +0000 | [diff] [blame] | 2154 | self.assertNotIn('branch.master.gerritissue', self.mockGit.config) |
| 2155 | self.assertNotIn('branch.master.gerritserver', self.mockGit.config) |
tandrii@chromium.org | 9b7fd71 | 2016-06-01 13:45:20 +0000 | [diff] [blame] | 2156 | |
Aaron Gable | 400e989 | 2017-07-12 15:31:21 -0700 | [diff] [blame] | 2157 | def test_cmd_issue_erase_existing_with_change_id(self): |
Edward Lemur | 8515328 | 2020-02-14 22:06:29 +0000 | [diff] [blame] | 2158 | self.mockGit.config['branch.master.gerritissue'] = '123' |
| 2159 | self.mockGit.config['branch.master.gerritserver'] = ( |
| 2160 | 'https://chromium-review.googlesource.com') |
Edward Lemur | da4b6c6 | 2020-02-13 00:28:40 +0000 | [diff] [blame] | 2161 | mock.patch('git_cl.Changelist.FetchDescription', |
| 2162 | lambda _: 'This is a description\n\nChange-Id: Ideadbeef').start() |
Aaron Gable | 400e989 | 2017-07-12 15:31:21 -0700 | [diff] [blame] | 2163 | self.calls = [ |
Aaron Gable | ca01e2c | 2017-07-19 11:16:02 -0700 | [diff] [blame] | 2164 | ((['git', 'log', '-1', '--format=%B'],), |
| 2165 | 'This is a description\n\nChange-Id: Ideadbeef'), |
| 2166 | ((['git', 'commit', '--amend', '-m', 'This is a description\n'],), ''), |
Aaron Gable | 400e989 | 2017-07-12 15:31:21 -0700 | [diff] [blame] | 2167 | ] |
| 2168 | self.assertEqual(0, git_cl.main(['issue', '0'])) |
Edward Lemur | 8515328 | 2020-02-14 22:06:29 +0000 | [diff] [blame] | 2169 | self.assertNotIn('branch.master.gerritissue', self.mockGit.config) |
| 2170 | self.assertNotIn('branch.master.gerritserver', self.mockGit.config) |
Aaron Gable | 400e989 | 2017-07-12 15:31:21 -0700 | [diff] [blame] | 2171 | |
phajdan.jr | e328cf9 | 2016-08-22 04:12:17 -0700 | [diff] [blame] | 2172 | def test_cmd_issue_json(self): |
Edward Lemur | 8515328 | 2020-02-14 22:06:29 +0000 | [diff] [blame] | 2173 | self.mockGit.config['branch.master.gerritissue'] = '123' |
| 2174 | self.mockGit.config['branch.master.gerritserver'] = ( |
| 2175 | 'https://chromium-review.googlesource.com') |
phajdan.jr | e328cf9 | 2016-08-22 04:12:17 -0700 | [diff] [blame] | 2176 | self.calls = [ |
phajdan.jr | e328cf9 | 2016-08-22 04:12:17 -0700 | [diff] [blame] | 2177 | (('write_json', 'output.json', |
Andrii Shyshkalov | a185e2e | 2018-11-21 00:42:55 +0000 | [diff] [blame] | 2178 | {'issue': 123, |
| 2179 | 'issue_url': 'https://chromium-review.googlesource.com/123'}), |
phajdan.jr | e328cf9 | 2016-08-22 04:12:17 -0700 | [diff] [blame] | 2180 | ''), |
| 2181 | ] |
| 2182 | self.assertEqual(0, git_cl.main(['issue', '--json', 'output.json'])) |
| 2183 | |
tandrii | 16e0b4e | 2016-06-07 10:34:28 -0700 | [diff] [blame] | 2184 | def _common_GerritCommitMsgHookCheck(self): |
Edward Lemur | 15a9b8c | 2020-02-13 00:52:30 +0000 | [diff] [blame] | 2185 | mock.patch( |
| 2186 | 'git_cl.os.path.abspath', |
| 2187 | lambda path: self._mocked_call(['abspath', path])).start() |
| 2188 | mock.patch( |
| 2189 | 'git_cl.os.path.exists', |
| 2190 | lambda path: self._mocked_call(['exists', path])).start() |
| 2191 | mock.patch( |
| 2192 | 'git_cl.gclient_utils.FileRead', |
| 2193 | lambda path: self._mocked_call(['FileRead', path])).start() |
| 2194 | mock.patch( |
| 2195 | 'git_cl.gclient_utils.rm_file_or_tree', |
| 2196 | lambda path: self._mocked_call(['rm_file_or_tree', path])).start() |
Edward Lemur | f38bc17 | 2019-09-03 21:02:13 +0000 | [diff] [blame] | 2197 | return git_cl.Changelist(issue=123) |
tandrii | 16e0b4e | 2016-06-07 10:34:28 -0700 | [diff] [blame] | 2198 | |
| 2199 | def test_GerritCommitMsgHookCheck_custom_hook(self): |
| 2200 | cl = self._common_GerritCommitMsgHookCheck() |
| 2201 | self.calls += [ |
Edward Lemur | 15a9b8c | 2020-02-13 00:52:30 +0000 | [diff] [blame] | 2202 | ((['exists', '.git/hooks/commit-msg'],), True), |
| 2203 | ((['FileRead', '.git/hooks/commit-msg'],), |
tandrii | 16e0b4e | 2016-06-07 10:34:28 -0700 | [diff] [blame] | 2204 | '#!/bin/sh\necho "custom hook"') |
| 2205 | ] |
Edward Lemur | 125d60a | 2019-09-13 18:25:41 +0000 | [diff] [blame] | 2206 | cl._GerritCommitMsgHookCheck(offer_removal=True) |
tandrii | 16e0b4e | 2016-06-07 10:34:28 -0700 | [diff] [blame] | 2207 | |
| 2208 | def test_GerritCommitMsgHookCheck_not_exists(self): |
| 2209 | cl = self._common_GerritCommitMsgHookCheck() |
| 2210 | self.calls += [ |
Edward Lemur | 15a9b8c | 2020-02-13 00:52:30 +0000 | [diff] [blame] | 2211 | ((['exists', '.git/hooks/commit-msg'],), False), |
tandrii | 16e0b4e | 2016-06-07 10:34:28 -0700 | [diff] [blame] | 2212 | ] |
Edward Lemur | 125d60a | 2019-09-13 18:25:41 +0000 | [diff] [blame] | 2213 | cl._GerritCommitMsgHookCheck(offer_removal=True) |
tandrii | 16e0b4e | 2016-06-07 10:34:28 -0700 | [diff] [blame] | 2214 | |
| 2215 | def test_GerritCommitMsgHookCheck(self): |
| 2216 | cl = self._common_GerritCommitMsgHookCheck() |
| 2217 | self.calls += [ |
Edward Lemur | 15a9b8c | 2020-02-13 00:52:30 +0000 | [diff] [blame] | 2218 | ((['exists', '.git/hooks/commit-msg'],), True), |
| 2219 | ((['FileRead', '.git/hooks/commit-msg'],), |
tandrii | 16e0b4e | 2016-06-07 10:34:28 -0700 | [diff] [blame] | 2220 | '...\n# From Gerrit Code Review\n...\nadd_ChangeId()\n'), |
Andrii Shyshkalov | abc26ac | 2017-03-14 14:49:38 +0100 | [diff] [blame] | 2221 | (('ask_for_data', 'Do you want to remove it now? [Yes/No]: '), 'Yes'), |
Edward Lemur | 15a9b8c | 2020-02-13 00:52:30 +0000 | [diff] [blame] | 2222 | ((['rm_file_or_tree', '.git/hooks/commit-msg'],), |
tandrii | 16e0b4e | 2016-06-07 10:34:28 -0700 | [diff] [blame] | 2223 | ''), |
| 2224 | ] |
Edward Lemur | 125d60a | 2019-09-13 18:25:41 +0000 | [diff] [blame] | 2225 | cl._GerritCommitMsgHookCheck(offer_removal=True) |
tandrii | 16e0b4e | 2016-06-07 10:34:28 -0700 | [diff] [blame] | 2226 | |
tandrii | c4344b5 | 2016-08-29 06:04:54 -0700 | [diff] [blame] | 2227 | def test_GerritCmdLand(self): |
Edward Lemur | 8515328 | 2020-02-14 22:06:29 +0000 | [diff] [blame] | 2228 | self.mockGit.config['branch.master.gerritsquashhash'] = 'deadbeaf' |
| 2229 | self.mockGit.config['branch.master.gerritserver'] = ( |
| 2230 | 'chromium-review.googlesource.com') |
tandrii | c4344b5 | 2016-08-29 06:04:54 -0700 | [diff] [blame] | 2231 | self.calls += [ |
tandrii | c4344b5 | 2016-08-29 06:04:54 -0700 | [diff] [blame] | 2232 | ((['git', 'diff', 'deadbeaf'],), ''), # No diff. |
tandrii | c4344b5 | 2016-08-29 06:04:54 -0700 | [diff] [blame] | 2233 | ] |
Edward Lemur | f38bc17 | 2019-09-03 21:02:13 +0000 | [diff] [blame] | 2234 | cl = git_cl.Changelist(issue=123) |
Edward Lemur | 125d60a | 2019-09-13 18:25:41 +0000 | [diff] [blame] | 2235 | cl._GetChangeDetail = lambda *args, **kwargs: { |
tandrii | c4344b5 | 2016-08-29 06:04:54 -0700 | [diff] [blame] | 2236 | 'labels': {}, |
| 2237 | 'current_revision': 'deadbeaf', |
| 2238 | } |
Edward Lemur | 125d60a | 2019-09-13 18:25:41 +0000 | [diff] [blame] | 2239 | cl._GetChangeCommit = lambda: { |
agable | 32978d9 | 2016-11-01 12:55:02 -0700 | [diff] [blame] | 2240 | 'commit': 'deadbeef', |
Aaron Gable | 02cdbb4 | 2016-12-13 16:24:25 -0800 | [diff] [blame] | 2241 | 'web_links': [{'name': 'gitiles', |
agable | 32978d9 | 2016-11-01 12:55:02 -0700 | [diff] [blame] | 2242 | 'url': 'https://git.googlesource.com/test/+/deadbeef'}], |
| 2243 | } |
Edward Lemur | 125d60a | 2019-09-13 18:25:41 +0000 | [diff] [blame] | 2244 | cl.SubmitIssue = lambda wait_for_merge: None |
Olivier Robin | 75ee725 | 2018-04-13 10:02:56 +0200 | [diff] [blame] | 2245 | self.assertEqual(0, cl.CMDLand(force=True, |
| 2246 | bypass_hooks=True, |
| 2247 | verbose=True, |
| 2248 | parallel=False)) |
Edward Lemur | 73c7670 | 2020-02-06 23:57:18 +0000 | [diff] [blame] | 2249 | self.assertIn( |
| 2250 | 'Issue chromium-review.googlesource.com/123 has been submitted', |
Edward Lemur | da4b6c6 | 2020-02-13 00:28:40 +0000 | [diff] [blame] | 2251 | sys.stdout.getvalue()) |
Edward Lemur | 73c7670 | 2020-02-06 23:57:18 +0000 | [diff] [blame] | 2252 | self.assertIn( |
| 2253 | 'Landed as: https://git.googlesource.com/test/+/deadbeef', |
Edward Lemur | da4b6c6 | 2020-02-13 00:28:40 +0000 | [diff] [blame] | 2254 | sys.stdout.getvalue()) |
tandrii | c4344b5 | 2016-08-29 06:04:54 -0700 | [diff] [blame] | 2255 | |
Andrii Shyshkalov | 258e0a6 | 2017-01-24 16:50:57 +0100 | [diff] [blame] | 2256 | def _mock_gerrit_changes_for_detail_cache(self): |
Edward Lemur | da4b6c6 | 2020-02-13 00:28:40 +0000 | [diff] [blame] | 2257 | mock.patch('git_cl.Changelist._GetGerritHost', lambda _: 'host').start() |
Andrii Shyshkalov | 258e0a6 | 2017-01-24 16:50:57 +0100 | [diff] [blame] | 2258 | |
Andrii Shyshkalov | 258e0a6 | 2017-01-24 16:50:57 +0100 | [diff] [blame] | 2259 | def test_gerrit_change_detail_cache_simple(self): |
| 2260 | self._mock_gerrit_changes_for_detail_cache() |
Edward Lesmes | 7677e5c | 2020-02-19 20:39:03 +0000 | [diff] [blame] | 2261 | gerrit_util.GetChangeDetail.side_effect = ['a', 'b'] |
Edward Lemur | f38bc17 | 2019-09-03 21:02:13 +0000 | [diff] [blame] | 2262 | cl1 = git_cl.Changelist(issue=1) |
Andrii Shyshkalov | 03e0ed2 | 2018-08-28 19:39:30 +0000 | [diff] [blame] | 2263 | cl1._cached_remote_url = ( |
| 2264 | True, 'https://chromium.googlesource.com/a/my/repo.git/') |
Edward Lemur | f38bc17 | 2019-09-03 21:02:13 +0000 | [diff] [blame] | 2265 | cl2 = git_cl.Changelist(issue=2) |
Andrii Shyshkalov | 03e0ed2 | 2018-08-28 19:39:30 +0000 | [diff] [blame] | 2266 | cl2._cached_remote_url = ( |
| 2267 | True, 'https://chromium.googlesource.com/ab/repo') |
Andrii Shyshkalov | b721460 | 2018-08-22 23:20:26 +0000 | [diff] [blame] | 2268 | self.assertEqual(cl1._GetChangeDetail(), 'a') # Miss. |
| 2269 | self.assertEqual(cl1._GetChangeDetail(), 'a') |
| 2270 | self.assertEqual(cl2._GetChangeDetail(), 'b') # Miss. |
Andrii Shyshkalov | 258e0a6 | 2017-01-24 16:50:57 +0100 | [diff] [blame] | 2271 | |
| 2272 | def test_gerrit_change_detail_cache_options(self): |
| 2273 | self._mock_gerrit_changes_for_detail_cache() |
Edward Lesmes | 7677e5c | 2020-02-19 20:39:03 +0000 | [diff] [blame] | 2274 | gerrit_util.GetChangeDetail.side_effect = ['cab', 'ad'] |
Edward Lemur | f38bc17 | 2019-09-03 21:02:13 +0000 | [diff] [blame] | 2275 | cl = git_cl.Changelist(issue=1) |
Andrii Shyshkalov | 03e0ed2 | 2018-08-28 19:39:30 +0000 | [diff] [blame] | 2276 | cl._cached_remote_url = (True, 'https://chromium.googlesource.com/repo/') |
Andrii Shyshkalov | 258e0a6 | 2017-01-24 16:50:57 +0100 | [diff] [blame] | 2277 | self.assertEqual(cl._GetChangeDetail(options=['C', 'A', 'B']), 'cab') |
| 2278 | self.assertEqual(cl._GetChangeDetail(options=['A', 'B', 'C']), 'cab') |
| 2279 | self.assertEqual(cl._GetChangeDetail(options=['B', 'A']), 'cab') |
| 2280 | self.assertEqual(cl._GetChangeDetail(options=['C']), 'cab') |
| 2281 | self.assertEqual(cl._GetChangeDetail(options=['A']), 'cab') |
| 2282 | self.assertEqual(cl._GetChangeDetail(), 'cab') |
| 2283 | |
| 2284 | self.assertEqual(cl._GetChangeDetail(options=['A', 'D']), 'ad') |
| 2285 | self.assertEqual(cl._GetChangeDetail(options=['A']), 'cab') |
| 2286 | self.assertEqual(cl._GetChangeDetail(options=['D']), 'ad') |
| 2287 | self.assertEqual(cl._GetChangeDetail(), 'cab') |
| 2288 | |
Andrii Shyshkalov | 21fb824 | 2017-02-15 21:09:27 +0100 | [diff] [blame] | 2289 | def test_gerrit_description_caching(self): |
Edward Lesmes | 7677e5c | 2020-02-19 20:39:03 +0000 | [diff] [blame] | 2290 | gerrit_util.GetChangeDetail.return_value = { |
| 2291 | 'current_revision': 'rev1', |
| 2292 | 'revisions': { |
| 2293 | 'rev1': {'commit': {'message': 'desc1'}}, |
| 2294 | }, |
| 2295 | } |
Andrii Shyshkalov | 21fb824 | 2017-02-15 21:09:27 +0100 | [diff] [blame] | 2296 | |
| 2297 | self._mock_gerrit_changes_for_detail_cache() |
Edward Lemur | f38bc17 | 2019-09-03 21:02:13 +0000 | [diff] [blame] | 2298 | cl = git_cl.Changelist(issue=1) |
Andrii Shyshkalov | 03e0ed2 | 2018-08-28 19:39:30 +0000 | [diff] [blame] | 2299 | cl._cached_remote_url = ( |
| 2300 | True, 'https://chromium.googlesource.com/a/my/repo.git/') |
Edward Lemur | 6c6827c | 2020-02-06 21:15:18 +0000 | [diff] [blame] | 2301 | self.assertEqual(cl.FetchDescription(), 'desc1') |
| 2302 | self.assertEqual(cl.FetchDescription(), 'desc1') # cache hit. |
tandrii@chromium.org | f86c7d3 | 2016-04-01 19:27:30 +0000 | [diff] [blame] | 2303 | |
Andrii Shyshkalov | 34924cd | 2017-03-15 17:08:32 +0100 | [diff] [blame] | 2304 | def test_print_current_creds(self): |
| 2305 | class CookiesAuthenticatorMock(object): |
| 2306 | def __init__(self): |
| 2307 | self.gitcookies = { |
| 2308 | 'host.googlesource.com': ('user', 'pass'), |
| 2309 | 'host-review.googlesource.com': ('user', 'pass'), |
| 2310 | } |
| 2311 | self.netrc = self |
| 2312 | self.netrc.hosts = { |
| 2313 | 'github.com': ('user2', None, 'pass2'), |
| 2314 | 'host2.googlesource.com': ('user3', None, 'pass'), |
| 2315 | } |
Edward Lemur | da4b6c6 | 2020-02-13 00:28:40 +0000 | [diff] [blame] | 2316 | mock.patch('git_cl.gerrit_util.CookiesAuthenticator', |
| 2317 | CookiesAuthenticatorMock).start() |
Andrii Shyshkalov | 34924cd | 2017-03-15 17:08:32 +0100 | [diff] [blame] | 2318 | git_cl._GitCookiesChecker().print_current_creds(include_netrc=True) |
| 2319 | self.assertEqual(list(sys.stdout.getvalue().splitlines()), [ |
| 2320 | ' Host\t User\t Which file', |
| 2321 | '============================\t=====\t===========', |
| 2322 | 'host-review.googlesource.com\t user\t.gitcookies', |
| 2323 | ' host.googlesource.com\t user\t.gitcookies', |
| 2324 | ' host2.googlesource.com\tuser3\t .netrc', |
| 2325 | ]) |
Edward Lemur | 79d4f99 | 2019-11-11 23:49:02 +0000 | [diff] [blame] | 2326 | sys.stdout.seek(0) |
| 2327 | sys.stdout.truncate(0) |
Andrii Shyshkalov | 34924cd | 2017-03-15 17:08:32 +0100 | [diff] [blame] | 2328 | git_cl._GitCookiesChecker().print_current_creds(include_netrc=False) |
| 2329 | self.assertEqual(list(sys.stdout.getvalue().splitlines()), [ |
| 2330 | ' Host\tUser\t Which file', |
| 2331 | '============================\t====\t===========', |
| 2332 | 'host-review.googlesource.com\tuser\t.gitcookies', |
| 2333 | ' host.googlesource.com\tuser\t.gitcookies', |
| 2334 | ]) |
| 2335 | |
Andrii Shyshkalov | 353637c | 2017-03-14 16:52:18 +0100 | [diff] [blame] | 2336 | def _common_creds_check_mocks(self): |
| 2337 | def exists_mock(path): |
| 2338 | dirname = os.path.dirname(path) |
| 2339 | if dirname == os.path.expanduser('~'): |
| 2340 | dirname = '~' |
| 2341 | base = os.path.basename(path) |
| 2342 | if base in ('.netrc', '.gitcookies'): |
| 2343 | return self._mocked_call('os.path.exists', '%s/%s' % (dirname, base)) |
| 2344 | # git cl also checks for existence other files not relevant to this test. |
| 2345 | return None |
Edward Lemur | da4b6c6 | 2020-02-13 00:28:40 +0000 | [diff] [blame] | 2346 | mock.patch('os.path.exists', exists_mock).start() |
Andrii Shyshkalov | 353637c | 2017-03-14 16:52:18 +0100 | [diff] [blame] | 2347 | |
| 2348 | def test_creds_check_gitcookies_not_configured(self): |
| 2349 | self._common_creds_check_mocks() |
Edward Lemur | da4b6c6 | 2020-02-13 00:28:40 +0000 | [diff] [blame] | 2350 | mock.patch('git_cl._GitCookiesChecker.get_hosts_with_creds', |
| 2351 | lambda _, include_netrc=False: []).start() |
Andrii Shyshkalov | 353637c | 2017-03-14 16:52:18 +0100 | [diff] [blame] | 2352 | self.calls = [ |
Aaron Gable | 8797cab | 2018-03-06 13:55:00 -0800 | [diff] [blame] | 2353 | ((['git', 'config', '--path', 'http.cookiefile'],), CERR1), |
Andrii Shyshkalov | 353637c | 2017-03-14 16:52:18 +0100 | [diff] [blame] | 2354 | ((['git', 'config', '--global', 'http.cookiefile'],), CERR1), |
| 2355 | (('os.path.exists', '~/.netrc'), True), |
| 2356 | (('ask_for_data', 'Press Enter to setup .gitcookies, ' |
| 2357 | 'or Ctrl+C to abort'), ''), |
| 2358 | ((['git', 'config', '--global', 'http.cookiefile', |
| 2359 | os.path.expanduser('~/.gitcookies')], ), ''), |
| 2360 | ] |
| 2361 | self.assertEqual(0, git_cl.main(['creds-check'])) |
Edward Lemur | 73c7670 | 2020-02-06 23:57:18 +0000 | [diff] [blame] | 2362 | self.assertTrue( |
| 2363 | sys.stdout.getvalue().startswith( |
| 2364 | 'You seem to be using outdated .netrc for git credentials:')) |
| 2365 | self.assertIn( |
| 2366 | '\nConfigured git to use .gitcookies from', |
| 2367 | sys.stdout.getvalue()) |
Andrii Shyshkalov | 353637c | 2017-03-14 16:52:18 +0100 | [diff] [blame] | 2368 | |
| 2369 | def test_creds_check_gitcookies_configured_custom_broken(self): |
| 2370 | self._common_creds_check_mocks() |
Edward Lemur | da4b6c6 | 2020-02-13 00:28:40 +0000 | [diff] [blame] | 2371 | mock.patch('git_cl._GitCookiesChecker.get_hosts_with_creds', |
| 2372 | lambda _, include_netrc=False: []).start() |
Andrii Shyshkalov | 353637c | 2017-03-14 16:52:18 +0100 | [diff] [blame] | 2373 | self.calls = [ |
Aaron Gable | 8797cab | 2018-03-06 13:55:00 -0800 | [diff] [blame] | 2374 | ((['git', 'config', '--path', 'http.cookiefile'],), CERR1), |
Andrii Shyshkalov | 353637c | 2017-03-14 16:52:18 +0100 | [diff] [blame] | 2375 | ((['git', 'config', '--global', 'http.cookiefile'],), |
| 2376 | '/custom/.gitcookies'), |
| 2377 | (('os.path.exists', '/custom/.gitcookies'), False), |
| 2378 | (('ask_for_data', 'Reconfigure git to use default .gitcookies? ' |
| 2379 | 'Press Enter to reconfigure, or Ctrl+C to abort'), ''), |
| 2380 | ((['git', 'config', '--global', 'http.cookiefile', |
| 2381 | os.path.expanduser('~/.gitcookies')], ), ''), |
| 2382 | ] |
| 2383 | self.assertEqual(0, git_cl.main(['creds-check'])) |
Edward Lemur | 73c7670 | 2020-02-06 23:57:18 +0000 | [diff] [blame] | 2384 | self.assertIn( |
| 2385 | 'WARNING: You have configured custom path to .gitcookies: ', |
| 2386 | sys.stdout.getvalue()) |
| 2387 | self.assertIn( |
| 2388 | 'However, your configured .gitcookies file is missing.', |
| 2389 | sys.stdout.getvalue()) |
Andrii Shyshkalov | 353637c | 2017-03-14 16:52:18 +0100 | [diff] [blame] | 2390 | |
Andrii Shyshkalov | 625986d | 2017-03-16 00:24:37 +0100 | [diff] [blame] | 2391 | def test_git_cl_comment_add_gerrit(self): |
Edward Lemur | 8515328 | 2020-02-14 22:06:29 +0000 | [diff] [blame] | 2392 | self.mockGit.branchref = None |
Edward Lemur | 2696407 | 2020-02-19 19:18:51 +0000 | [diff] [blame] | 2393 | self.mockGit.config['remote.origin.url'] = ( |
| 2394 | 'https://chromium.googlesource.com/infra/infra') |
Andrii Shyshkalov | 625986d | 2017-03-16 00:24:37 +0100 | [diff] [blame] | 2395 | self.calls = [ |
Andrii Shyshkalov | 889677c | 2018-08-28 20:43:06 +0000 | [diff] [blame] | 2396 | (('SetReview', 'chromium-review.googlesource.com', 'infra%2Finfra~10', |
Edward Lemur | da4b6c6 | 2020-02-13 00:28:40 +0000 | [diff] [blame] | 2397 | 'msg', None, None, None), |
Aaron Gable | 636b13f | 2017-07-14 10:42:48 -0700 | [diff] [blame] | 2398 | None), |
Andrii Shyshkalov | 625986d | 2017-03-16 00:24:37 +0100 | [diff] [blame] | 2399 | ] |
Edward Lemur | 52969c9 | 2020-02-06 18:15:28 +0000 | [diff] [blame] | 2400 | self.assertEqual(0, git_cl.main(['comment', '-i', '10', '-a', 'msg'])) |
Andrii Shyshkalov | 625986d | 2017-03-16 00:24:37 +0100 | [diff] [blame] | 2401 | |
Edward Lemur | da4b6c6 | 2020-02-13 00:28:40 +0000 | [diff] [blame] | 2402 | @mock.patch('git_cl.Changelist.GetBranch', return_value='foo') |
| 2403 | def test_git_cl_comments_fetch_gerrit(self, *_mocks): |
Edward Lemur | 2696407 | 2020-02-19 19:18:51 +0000 | [diff] [blame] | 2404 | self.mockGit.config['remote.origin.url'] = ( |
| 2405 | 'https://chromium.googlesource.com/infra/infra') |
Edward Lesmes | 7677e5c | 2020-02-19 20:39:03 +0000 | [diff] [blame] | 2406 | gerrit_util.GetChangeDetail.return_value = { |
Aaron Gable | 0ffdf2d | 2017-06-05 13:01:17 -0700 | [diff] [blame] | 2407 | 'owner': {'email': 'owner@example.com'}, |
Quinten Yearsley | 0e617c0 | 2019-02-20 00:37:03 +0000 | [diff] [blame] | 2408 | 'current_revision': 'ba5eba11', |
| 2409 | 'revisions': { |
Quinten Yearsley | d9cbe7a | 2019-09-03 16:49:11 +0000 | [diff] [blame] | 2410 | 'deadbeaf': { |
Quinten Yearsley | 0e617c0 | 2019-02-20 00:37:03 +0000 | [diff] [blame] | 2411 | '_number': 1, |
| 2412 | }, |
Quinten Yearsley | d9cbe7a | 2019-09-03 16:49:11 +0000 | [diff] [blame] | 2413 | 'ba5eba11': { |
Quinten Yearsley | 0e617c0 | 2019-02-20 00:37:03 +0000 | [diff] [blame] | 2414 | '_number': 2, |
| 2415 | }, |
| 2416 | }, |
Andrii Shyshkalov | 5a0cf20 | 2017-03-17 16:14:59 +0100 | [diff] [blame] | 2417 | 'messages': [ |
| 2418 | { |
| 2419 | u'_revision_number': 1, |
| 2420 | u'author': { |
| 2421 | u'_account_id': 1111084, |
| 2422 | u'email': u'commit-bot@chromium.org', |
| 2423 | u'name': u'Commit Bot' |
| 2424 | }, |
| 2425 | u'date': u'2017-03-15 20:08:45.000000000', |
| 2426 | u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046dc50b', |
Dirk Pranke | f6a5880 | 2017-10-17 12:49:42 -0700 | [diff] [blame] | 2427 | u'message': u'Patch Set 1:\n\nDry run: CQ is trying the patch...', |
Andrii Shyshkalov | 5a0cf20 | 2017-03-17 16:14:59 +0100 | [diff] [blame] | 2428 | u'tag': u'autogenerated:cq:dry-run' |
| 2429 | }, |
| 2430 | { |
| 2431 | u'_revision_number': 2, |
| 2432 | u'author': { |
| 2433 | u'_account_id': 11151243, |
| 2434 | u'email': u'owner@example.com', |
| 2435 | u'name': u'owner' |
| 2436 | }, |
| 2437 | u'date': u'2017-03-16 20:00:41.000000000', |
| 2438 | u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234', |
| 2439 | u'message': u'PTAL', |
| 2440 | }, |
| 2441 | { |
| 2442 | u'_revision_number': 2, |
| 2443 | u'author': { |
Quinten Yearsley | d9cbe7a | 2019-09-03 16:49:11 +0000 | [diff] [blame] | 2444 | u'_account_id': 148512, |
Andrii Shyshkalov | 5a0cf20 | 2017-03-17 16:14:59 +0100 | [diff] [blame] | 2445 | u'email': u'reviewer@example.com', |
| 2446 | u'name': u'reviewer' |
| 2447 | }, |
| 2448 | u'date': u'2017-03-17 05:19:37.500000000', |
| 2449 | u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d4568', |
| 2450 | u'message': u'Patch Set 2: Code-Review+1', |
| 2451 | }, |
| 2452 | ] |
Edward Lesmes | 7677e5c | 2020-02-19 20:39:03 +0000 | [diff] [blame] | 2453 | } |
| 2454 | self.calls = [ |
Andrii Shyshkalov | 889677c | 2018-08-28 20:43:06 +0000 | [diff] [blame] | 2455 | (('GetChangeComments', 'chromium-review.googlesource.com', |
| 2456 | 'infra%2Finfra~1'), { |
Aaron Gable | 0ffdf2d | 2017-06-05 13:01:17 -0700 | [diff] [blame] | 2457 | '/COMMIT_MSG': [ |
| 2458 | { |
| 2459 | 'author': {'email': u'reviewer@example.com'}, |
| 2460 | 'updated': u'2017-03-17 05:19:37.500000000', |
| 2461 | 'patch_set': 2, |
| 2462 | 'side': 'REVISION', |
| 2463 | 'message': 'Please include a bug link', |
| 2464 | }, |
| 2465 | ], |
| 2466 | 'codereview.settings': [ |
| 2467 | { |
| 2468 | 'author': {'email': u'owner@example.com'}, |
| 2469 | 'updated': u'2017-03-16 20:00:41.000000000', |
| 2470 | 'patch_set': 2, |
| 2471 | 'side': 'PARENT', |
| 2472 | 'line': 42, |
| 2473 | 'message': 'I removed this because it is bad', |
| 2474 | }, |
| 2475 | ] |
Quinten Yearsley | 0e617c0 | 2019-02-20 00:37:03 +0000 | [diff] [blame] | 2476 | }), |
| 2477 | (('GetChangeRobotComments', 'chromium-review.googlesource.com', |
| 2478 | 'infra%2Finfra~1'), {}), |
Leszek Swirski | 45b20c4 | 2018-09-17 17:05:26 +0000 | [diff] [blame] | 2479 | ] * 2 + [ |
| 2480 | (('write_json', 'output.json', [ |
| 2481 | { |
| 2482 | u'date': u'2017-03-16 20:00:41.000000', |
| 2483 | u'message': ( |
| 2484 | u'PTAL\n' + |
| 2485 | u'\n' + |
| 2486 | u'codereview.settings\n' + |
| 2487 | u' Base, Line 42: https://chromium-review.googlesource.com/' + |
| 2488 | u'c/1/2/codereview.settings#b42\n' + |
| 2489 | u' I removed this because it is bad\n'), |
Quinten Yearsley | 0e617c0 | 2019-02-20 00:37:03 +0000 | [diff] [blame] | 2490 | u'autogenerated': False, |
Leszek Swirski | 45b20c4 | 2018-09-17 17:05:26 +0000 | [diff] [blame] | 2491 | u'approval': False, |
| 2492 | u'disapproval': False, |
| 2493 | u'sender': u'owner@example.com' |
| 2494 | }, { |
| 2495 | u'date': u'2017-03-17 05:19:37.500000', |
| 2496 | u'message': ( |
| 2497 | u'Patch Set 2: Code-Review+1\n' + |
| 2498 | u'\n' + |
| 2499 | u'/COMMIT_MSG\n' + |
| 2500 | u' PS2, File comment: https://chromium-review.googlesource' + |
| 2501 | u'.com/c/1/2//COMMIT_MSG#\n' + |
| 2502 | u' Please include a bug link\n'), |
Quinten Yearsley | 0e617c0 | 2019-02-20 00:37:03 +0000 | [diff] [blame] | 2503 | u'autogenerated': False, |
Leszek Swirski | 45b20c4 | 2018-09-17 17:05:26 +0000 | [diff] [blame] | 2504 | u'approval': False, |
| 2505 | u'disapproval': False, |
| 2506 | u'sender': u'reviewer@example.com' |
| 2507 | } |
Quinten Yearsley | d9cbe7a | 2019-09-03 16:49:11 +0000 | [diff] [blame] | 2508 | ]), '') |
Leszek Swirski | 45b20c4 | 2018-09-17 17:05:26 +0000 | [diff] [blame] | 2509 | ] |
Andrii Shyshkalov | 5a0cf20 | 2017-03-17 16:14:59 +0100 | [diff] [blame] | 2510 | expected_comments_summary = [ |
| 2511 | git_cl._CommentSummary( |
Aaron Gable | 0ffdf2d | 2017-06-05 13:01:17 -0700 | [diff] [blame] | 2512 | message=( |
| 2513 | u'PTAL\n' + |
| 2514 | u'\n' + |
| 2515 | u'codereview.settings\n' + |
| 2516 | u' Base, Line 42: https://chromium-review.googlesource.com/' + |
| 2517 | u'c/1/2/codereview.settings#b42\n' + |
| 2518 | u' I removed this because it is bad\n'), |
Andrii Shyshkalov | 5a0cf20 | 2017-03-17 16:14:59 +0100 | [diff] [blame] | 2519 | date=datetime.datetime(2017, 3, 16, 20, 0, 41, 0), |
Quinten Yearsley | 0e617c0 | 2019-02-20 00:37:03 +0000 | [diff] [blame] | 2520 | autogenerated=False, |
Andrii Shyshkalov | 5a0cf20 | 2017-03-17 16:14:59 +0100 | [diff] [blame] | 2521 | disapproval=False, approval=False, sender=u'owner@example.com'), |
| 2522 | git_cl._CommentSummary( |
Aaron Gable | 0ffdf2d | 2017-06-05 13:01:17 -0700 | [diff] [blame] | 2523 | message=( |
| 2524 | u'Patch Set 2: Code-Review+1\n' + |
| 2525 | u'\n' + |
| 2526 | u'/COMMIT_MSG\n' + |
| 2527 | u' PS2, File comment: https://chromium-review.googlesource.com/' + |
| 2528 | u'c/1/2//COMMIT_MSG#\n' + |
| 2529 | u' Please include a bug link\n'), |
Andrii Shyshkalov | 5a0cf20 | 2017-03-17 16:14:59 +0100 | [diff] [blame] | 2530 | date=datetime.datetime(2017, 3, 17, 5, 19, 37, 500000), |
Quinten Yearsley | 0e617c0 | 2019-02-20 00:37:03 +0000 | [diff] [blame] | 2531 | autogenerated=False, |
Andrii Shyshkalov | 5a0cf20 | 2017-03-17 16:14:59 +0100 | [diff] [blame] | 2532 | disapproval=False, approval=False, sender=u'reviewer@example.com'), |
| 2533 | ] |
Quinten Yearsley | 0e617c0 | 2019-02-20 00:37:03 +0000 | [diff] [blame] | 2534 | cl = git_cl.Changelist( |
Edward Lemur | f38bc17 | 2019-09-03 21:02:13 +0000 | [diff] [blame] | 2535 | issue=1, branchref='refs/heads/foo') |
Andrii Shyshkalov | 5a0cf20 | 2017-03-17 16:14:59 +0100 | [diff] [blame] | 2536 | self.assertEqual(cl.GetCommentsSummary(), expected_comments_summary) |
Quinten Yearsley | 0e617c0 | 2019-02-20 00:37:03 +0000 | [diff] [blame] | 2537 | self.assertEqual( |
| 2538 | 0, git_cl.main(['comments', '-i', '1', '-j', 'output.json'])) |
| 2539 | |
| 2540 | def test_git_cl_comments_robot_comments(self): |
| 2541 | # git cl comments also fetches robot comments (which are considered a type |
| 2542 | # of autogenerated comment), and unlike other types of comments, only robot |
| 2543 | # comments from the latest patchset are shown. |
Edward Lemur | 2696407 | 2020-02-19 19:18:51 +0000 | [diff] [blame] | 2544 | self.mockGit.config['remote.origin.url'] = ( |
| 2545 | 'https://chromium.googlesource.com/infra/infra') |
Edward Lesmes | 7677e5c | 2020-02-19 20:39:03 +0000 | [diff] [blame] | 2546 | gerrit_util.GetChangeDetail.return_value = { |
| 2547 | 'owner': {'email': 'owner@example.com'}, |
| 2548 | 'current_revision': 'ba5eba11', |
| 2549 | 'revisions': { |
| 2550 | 'deadbeaf': { |
| 2551 | '_number': 1, |
Quinten Yearsley | 0e617c0 | 2019-02-20 00:37:03 +0000 | [diff] [blame] | 2552 | }, |
Edward Lesmes | 7677e5c | 2020-02-19 20:39:03 +0000 | [diff] [blame] | 2553 | 'ba5eba11': { |
| 2554 | '_number': 2, |
| 2555 | }, |
| 2556 | }, |
| 2557 | 'messages': [ |
| 2558 | { |
| 2559 | u'_revision_number': 1, |
| 2560 | u'author': { |
| 2561 | u'_account_id': 1111084, |
| 2562 | u'email': u'commit-bot@chromium.org', |
| 2563 | u'name': u'Commit Bot' |
| 2564 | }, |
| 2565 | u'date': u'2017-03-15 20:08:45.000000000', |
| 2566 | u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046dc50b', |
| 2567 | u'message': u'Patch Set 1:\n\nDry run: CQ is trying the patch...', |
| 2568 | u'tag': u'autogenerated:cq:dry-run' |
| 2569 | }, |
| 2570 | { |
| 2571 | u'_revision_number': 1, |
| 2572 | u'author': { |
| 2573 | u'_account_id': 123, |
| 2574 | u'email': u'tricium@serviceaccount.com', |
| 2575 | u'name': u'Tricium' |
| 2576 | }, |
| 2577 | u'date': u'2017-03-16 20:00:41.000000000', |
| 2578 | u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234', |
| 2579 | u'message': u'(1 comment)', |
| 2580 | u'tag': u'autogenerated:tricium', |
| 2581 | }, |
| 2582 | { |
| 2583 | u'_revision_number': 1, |
| 2584 | u'author': { |
| 2585 | u'_account_id': 123, |
| 2586 | u'email': u'tricium@serviceaccount.com', |
| 2587 | u'name': u'Tricium' |
| 2588 | }, |
| 2589 | u'date': u'2017-03-16 20:00:41.000000000', |
| 2590 | u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234', |
| 2591 | u'message': u'(1 comment)', |
| 2592 | u'tag': u'autogenerated:tricium', |
| 2593 | }, |
| 2594 | { |
| 2595 | u'_revision_number': 2, |
| 2596 | u'author': { |
| 2597 | u'_account_id': 123, |
| 2598 | u'email': u'tricium@serviceaccount.com', |
| 2599 | u'name': u'reviewer' |
| 2600 | }, |
| 2601 | u'date': u'2017-03-17 05:30:37.000000000', |
| 2602 | u'tag': u'autogenerated:tricium', |
| 2603 | u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d4568', |
| 2604 | u'message': u'(1 comment)', |
| 2605 | }, |
| 2606 | ] |
| 2607 | } |
| 2608 | self.calls = [ |
Quinten Yearsley | 0e617c0 | 2019-02-20 00:37:03 +0000 | [diff] [blame] | 2609 | (('GetChangeComments', 'chromium-review.googlesource.com', |
| 2610 | 'infra%2Finfra~1'), {}), |
| 2611 | (('GetChangeRobotComments', 'chromium-review.googlesource.com', |
| 2612 | 'infra%2Finfra~1'), { |
| 2613 | 'codereview.settings': [ |
| 2614 | { |
| 2615 | u'author': {u'email': u'tricium@serviceaccount.com'}, |
| 2616 | u'updated': u'2017-03-17 05:30:37.000000000', |
| 2617 | u'robot_run_id': u'5565031076855808', |
| 2618 | u'robot_id': u'Linter/Category', |
| 2619 | u'tag': u'autogenerated:tricium', |
| 2620 | u'patch_set': 2, |
| 2621 | u'side': u'REVISION', |
| 2622 | u'message': u'Linter warning message text', |
| 2623 | u'line': 32, |
| 2624 | }, |
| 2625 | ], |
| 2626 | }), |
Quinten Yearsley | 0e617c0 | 2019-02-20 00:37:03 +0000 | [diff] [blame] | 2627 | ] |
| 2628 | expected_comments_summary = [ |
| 2629 | git_cl._CommentSummary(date=datetime.datetime(2017, 3, 17, 5, 30, 37), |
| 2630 | message=( |
| 2631 | u'(1 comment)\n\ncodereview.settings\n' |
| 2632 | u' PS2, Line 32: https://chromium-review.googlesource.com/' |
| 2633 | u'c/1/2/codereview.settings#32\n' |
| 2634 | u' Linter warning message text\n'), |
| 2635 | sender=u'tricium@serviceaccount.com', |
| 2636 | autogenerated=True, approval=False, disapproval=False) |
| 2637 | ] |
| 2638 | cl = git_cl.Changelist( |
Edward Lemur | f38bc17 | 2019-09-03 21:02:13 +0000 | [diff] [blame] | 2639 | issue=1, branchref='refs/heads/foo') |
Quinten Yearsley | 0e617c0 | 2019-02-20 00:37:03 +0000 | [diff] [blame] | 2640 | self.assertEqual(cl.GetCommentsSummary(), expected_comments_summary) |
Andrii Shyshkalov | 34924cd | 2017-03-15 17:08:32 +0100 | [diff] [blame] | 2641 | |
Andrii Shyshkalov | 81db1d5 | 2018-08-23 02:17:41 +0000 | [diff] [blame] | 2642 | def test_get_remote_url_with_mirror(self): |
| 2643 | original_os_path_isdir = os.path.isdir |
Quinten Yearsley | d9cbe7a | 2019-09-03 16:49:11 +0000 | [diff] [blame] | 2644 | |
Andrii Shyshkalov | 81db1d5 | 2018-08-23 02:17:41 +0000 | [diff] [blame] | 2645 | def selective_os_path_isdir_mock(path): |
| 2646 | if path == '/cache/this-dir-exists': |
| 2647 | return self._mocked_call('os.path.isdir', path) |
| 2648 | return original_os_path_isdir(path) |
Quinten Yearsley | d9cbe7a | 2019-09-03 16:49:11 +0000 | [diff] [blame] | 2649 | |
Edward Lemur | da4b6c6 | 2020-02-13 00:28:40 +0000 | [diff] [blame] | 2650 | mock.patch('os.path.isdir', selective_os_path_isdir_mock).start() |
Andrii Shyshkalov | 81db1d5 | 2018-08-23 02:17:41 +0000 | [diff] [blame] | 2651 | |
| 2652 | url = 'https://chromium.googlesource.com/my/repo' |
Edward Lemur | 2696407 | 2020-02-19 19:18:51 +0000 | [diff] [blame] | 2653 | self.mockGit.config['remote.origin.url'] = ( |
| 2654 | '/cache/this-dir-exists') |
| 2655 | self.mockGit.config['/cache/this-dir-exists:remote.origin.url'] = ( |
| 2656 | url) |
Andrii Shyshkalov | 81db1d5 | 2018-08-23 02:17:41 +0000 | [diff] [blame] | 2657 | self.calls = [ |
Andrii Shyshkalov | 81db1d5 | 2018-08-23 02:17:41 +0000 | [diff] [blame] | 2658 | (('os.path.isdir', '/cache/this-dir-exists'), |
| 2659 | True), |
Andrii Shyshkalov | 81db1d5 | 2018-08-23 02:17:41 +0000 | [diff] [blame] | 2660 | ] |
Edward Lemur | f38bc17 | 2019-09-03 21:02:13 +0000 | [diff] [blame] | 2661 | cl = git_cl.Changelist(issue=1) |
Andrii Shyshkalov | 81db1d5 | 2018-08-23 02:17:41 +0000 | [diff] [blame] | 2662 | self.assertEqual(cl.GetRemoteUrl(), url) |
| 2663 | self.assertEqual(cl.GetRemoteUrl(), url) # Must be cached. |
| 2664 | |
Edward Lemur | 298f2cf | 2019-02-22 21:40:39 +0000 | [diff] [blame] | 2665 | def test_get_remote_url_non_existing_mirror(self): |
| 2666 | original_os_path_isdir = os.path.isdir |
Quinten Yearsley | d9cbe7a | 2019-09-03 16:49:11 +0000 | [diff] [blame] | 2667 | |
Edward Lemur | 298f2cf | 2019-02-22 21:40:39 +0000 | [diff] [blame] | 2668 | def selective_os_path_isdir_mock(path): |
| 2669 | if path == '/cache/this-dir-doesnt-exist': |
| 2670 | return self._mocked_call('os.path.isdir', path) |
| 2671 | return original_os_path_isdir(path) |
Quinten Yearsley | d9cbe7a | 2019-09-03 16:49:11 +0000 | [diff] [blame] | 2672 | |
Edward Lemur | da4b6c6 | 2020-02-13 00:28:40 +0000 | [diff] [blame] | 2673 | mock.patch('os.path.isdir', selective_os_path_isdir_mock).start() |
| 2674 | mock.patch('logging.error', |
| 2675 | lambda *a: self._mocked_call('logging.error', *a)).start() |
Edward Lemur | 298f2cf | 2019-02-22 21:40:39 +0000 | [diff] [blame] | 2676 | |
Edward Lemur | 2696407 | 2020-02-19 19:18:51 +0000 | [diff] [blame] | 2677 | self.mockGit.config['remote.origin.url'] = ( |
| 2678 | '/cache/this-dir-doesnt-exist') |
Edward Lemur | 298f2cf | 2019-02-22 21:40:39 +0000 | [diff] [blame] | 2679 | self.calls = [ |
Edward Lemur | 298f2cf | 2019-02-22 21:40:39 +0000 | [diff] [blame] | 2680 | (('os.path.isdir', '/cache/this-dir-doesnt-exist'), |
| 2681 | False), |
| 2682 | (('logging.error', |
Josip | 906bfde | 2020-01-31 22:38:49 +0000 | [diff] [blame] | 2683 | 'Remote "%(remote)s" for branch "%(branch)s" points to "%(url)s", ' |
| 2684 | 'but it doesn\'t exist.', { |
| 2685 | 'remote': 'origin', |
| 2686 | 'branch': 'master', |
| 2687 | 'url': '/cache/this-dir-doesnt-exist'} |
| 2688 | ), None), |
Edward Lemur | 298f2cf | 2019-02-22 21:40:39 +0000 | [diff] [blame] | 2689 | ] |
Edward Lemur | f38bc17 | 2019-09-03 21:02:13 +0000 | [diff] [blame] | 2690 | cl = git_cl.Changelist(issue=1) |
Edward Lemur | 298f2cf | 2019-02-22 21:40:39 +0000 | [diff] [blame] | 2691 | self.assertIsNone(cl.GetRemoteUrl()) |
| 2692 | |
| 2693 | def test_get_remote_url_misconfigured_mirror(self): |
| 2694 | original_os_path_isdir = os.path.isdir |
Quinten Yearsley | d9cbe7a | 2019-09-03 16:49:11 +0000 | [diff] [blame] | 2695 | |
Edward Lemur | 298f2cf | 2019-02-22 21:40:39 +0000 | [diff] [blame] | 2696 | def selective_os_path_isdir_mock(path): |
| 2697 | if path == '/cache/this-dir-exists': |
| 2698 | return self._mocked_call('os.path.isdir', path) |
| 2699 | return original_os_path_isdir(path) |
Quinten Yearsley | d9cbe7a | 2019-09-03 16:49:11 +0000 | [diff] [blame] | 2700 | |
Edward Lemur | da4b6c6 | 2020-02-13 00:28:40 +0000 | [diff] [blame] | 2701 | mock.patch('os.path.isdir', selective_os_path_isdir_mock).start() |
| 2702 | mock.patch('logging.error', |
| 2703 | lambda *a: self._mocked_call('logging.error', *a)).start() |
Edward Lemur | 298f2cf | 2019-02-22 21:40:39 +0000 | [diff] [blame] | 2704 | |
Edward Lemur | 2696407 | 2020-02-19 19:18:51 +0000 | [diff] [blame] | 2705 | self.mockGit.config['remote.origin.url'] = ( |
| 2706 | '/cache/this-dir-exists') |
Edward Lemur | 298f2cf | 2019-02-22 21:40:39 +0000 | [diff] [blame] | 2707 | self.calls = [ |
Edward Lemur | 298f2cf | 2019-02-22 21:40:39 +0000 | [diff] [blame] | 2708 | (('os.path.isdir', '/cache/this-dir-exists'), True), |
Edward Lemur | 298f2cf | 2019-02-22 21:40:39 +0000 | [diff] [blame] | 2709 | (('logging.error', |
| 2710 | 'Remote "%(remote)s" for branch "%(branch)s" points to ' |
| 2711 | '"%(cache_path)s", but it is misconfigured.\n' |
| 2712 | '"%(cache_path)s" must be a git repo and must have a remote named ' |
| 2713 | '"%(remote)s" pointing to the git host.', { |
| 2714 | 'remote': 'origin', |
| 2715 | 'cache_path': '/cache/this-dir-exists', |
| 2716 | 'branch': 'master'} |
| 2717 | ), None), |
| 2718 | ] |
Edward Lemur | f38bc17 | 2019-09-03 21:02:13 +0000 | [diff] [blame] | 2719 | cl = git_cl.Changelist(issue=1) |
Edward Lemur | 298f2cf | 2019-02-22 21:40:39 +0000 | [diff] [blame] | 2720 | self.assertIsNone(cl.GetRemoteUrl()) |
| 2721 | |
Andrii Shyshkalov | 2d0e03c | 2018-08-25 04:18:09 +0000 | [diff] [blame] | 2722 | def test_gerrit_change_identifier_with_project(self): |
Edward Lemur | 2696407 | 2020-02-19 19:18:51 +0000 | [diff] [blame] | 2723 | self.mockGit.config['remote.origin.url'] = ( |
| 2724 | 'https://chromium.googlesource.com/a/my/repo.git/') |
Edward Lemur | f38bc17 | 2019-09-03 21:02:13 +0000 | [diff] [blame] | 2725 | cl = git_cl.Changelist(issue=123456) |
Andrii Shyshkalov | 2d0e03c | 2018-08-25 04:18:09 +0000 | [diff] [blame] | 2726 | self.assertEqual(cl._GerritChangeIdentifier(), 'my%2Frepo~123456') |
| 2727 | |
| 2728 | def test_gerrit_change_identifier_without_project(self): |
Edward Lemur | da4b6c6 | 2020-02-13 00:28:40 +0000 | [diff] [blame] | 2729 | mock.patch('logging.error', |
| 2730 | lambda *a: self._mocked_call('logging.error', *a)).start() |
Josip | 906bfde | 2020-01-31 22:38:49 +0000 | [diff] [blame] | 2731 | |
Andrii Shyshkalov | 2d0e03c | 2018-08-25 04:18:09 +0000 | [diff] [blame] | 2732 | self.calls = [ |
Josip | 906bfde | 2020-01-31 22:38:49 +0000 | [diff] [blame] | 2733 | (('logging.error', |
| 2734 | 'Remote "%(remote)s" for branch "%(branch)s" points to "%(url)s", ' |
| 2735 | 'but it doesn\'t exist.', { |
| 2736 | 'remote': 'origin', |
| 2737 | 'branch': 'master', |
| 2738 | 'url': ''} |
| 2739 | ), None), |
Andrii Shyshkalov | 2d0e03c | 2018-08-25 04:18:09 +0000 | [diff] [blame] | 2740 | ] |
Edward Lemur | f38bc17 | 2019-09-03 21:02:13 +0000 | [diff] [blame] | 2741 | cl = git_cl.Changelist(issue=123456) |
Andrii Shyshkalov | 2d0e03c | 2018-08-25 04:18:09 +0000 | [diff] [blame] | 2742 | self.assertEqual(cl._GerritChangeIdentifier(), '123456') |
Andrii Shyshkalov | 1e82867 | 2018-08-23 22:34:37 +0000 | [diff] [blame] | 2743 | |
Quinten Yearsley | 0c62da9 | 2017-05-31 13:39:42 -0700 | [diff] [blame] | 2744 | |
Edward Lemur | baaf6be | 2019-10-09 18:00:44 +0000 | [diff] [blame] | 2745 | class CMDTestCaseBase(unittest.TestCase): |
| 2746 | _STATUSES = [ |
| 2747 | 'STATUS_UNSPECIFIED', 'SCHEDULED', 'STARTED', 'SUCCESS', 'FAILURE', |
| 2748 | 'INFRA_FAILURE', 'CANCELED', |
| 2749 | ] |
| 2750 | _CHANGE_DETAIL = { |
| 2751 | 'project': 'depot_tools', |
| 2752 | 'status': 'OPEN', |
| 2753 | 'owner': {'email': 'owner@e.mail'}, |
| 2754 | 'current_revision': 'beeeeeef', |
| 2755 | 'revisions': { |
| 2756 | 'deadbeaf': {'_number': 6}, |
| 2757 | 'beeeeeef': { |
| 2758 | '_number': 7, |
| 2759 | 'fetch': {'http': { |
| 2760 | 'url': 'https://chromium.googlesource.com/depot_tools', |
| 2761 | 'ref': 'refs/changes/56/123456/7' |
| 2762 | }}, |
| 2763 | }, |
| 2764 | }, |
| 2765 | } |
| 2766 | _DEFAULT_RESPONSE = { |
Andrii Shyshkalov | 2cbae8a | 2019-10-11 21:30:27 +0000 | [diff] [blame] | 2767 | 'builds': [{ |
| 2768 | 'id': str(100 + idx), |
| 2769 | 'builder': { |
| 2770 | 'project': 'chromium', |
| 2771 | 'bucket': 'try', |
| 2772 | 'builder': 'bot_' + status.lower(), |
| 2773 | }, |
| 2774 | 'createTime': '2019-10-09T08:00:0%d.854286Z' % (idx % 10), |
| 2775 | 'tags': [], |
| 2776 | 'status': status, |
| 2777 | } for idx, status in enumerate(_STATUSES)] |
Edward Lemur | baaf6be | 2019-10-09 18:00:44 +0000 | [diff] [blame] | 2778 | } |
| 2779 | |
Edward Lemur | 4c707a2 | 2019-09-24 21:13:43 +0000 | [diff] [blame] | 2780 | def setUp(self): |
Edward Lemur | baaf6be | 2019-10-09 18:00:44 +0000 | [diff] [blame] | 2781 | super(CMDTestCaseBase, self).setUp() |
Edward Lemur | 79d4f99 | 2019-11-11 23:49:02 +0000 | [diff] [blame] | 2782 | mock.patch('git_cl.sys.stdout', StringIO()).start() |
Edward Lemur | baaf6be | 2019-10-09 18:00:44 +0000 | [diff] [blame] | 2783 | mock.patch('git_cl.uuid.uuid4', return_value='uuid4').start() |
| 2784 | mock.patch('git_cl.Changelist.GetIssue', return_value=123456).start() |
Edward Lesmes | 7677e5c | 2020-02-19 20:39:03 +0000 | [diff] [blame] | 2785 | mock.patch( |
| 2786 | 'git_cl.Changelist.GetCodereviewServer', |
| 2787 | return_value='https://chromium-review.googlesource.com').start() |
| 2788 | mock.patch( |
| 2789 | 'git_cl.Changelist._GetGerritHost', |
| 2790 | return_value='chromium-review.googlesource.com').start() |
| 2791 | mock.patch( |
| 2792 | 'git_cl.Changelist.GetMostRecentPatchset', |
| 2793 | return_value=7).start() |
| 2794 | mock.patch( |
| 2795 | 'git_cl.Changelist.GetRemoteUrl', |
| 2796 | return_value='https://chromium.googlesource.com/depot_tools').start() |
| 2797 | mock.patch( |
| 2798 | 'auth.Authenticator', |
| 2799 | return_value=AuthenticatorMock()).start() |
| 2800 | mock.patch( |
| 2801 | 'gerrit_util.GetChangeDetail', |
| 2802 | return_value=self._CHANGE_DETAIL).start() |
| 2803 | mock.patch( |
| 2804 | 'git_cl._call_buildbucket', |
| 2805 | return_value = self._DEFAULT_RESPONSE).start() |
Edward Lemur | baaf6be | 2019-10-09 18:00:44 +0000 | [diff] [blame] | 2806 | mock.patch('git_common.is_dirty_git_tree', return_value=False).start() |
Edward Lemur | 4c707a2 | 2019-09-24 21:13:43 +0000 | [diff] [blame] | 2807 | self.addCleanup(mock.patch.stopall) |
| 2808 | |
Edward Lemur | 4c707a2 | 2019-09-24 21:13:43 +0000 | [diff] [blame] | 2809 | |
Edward Lemur | baaf6be | 2019-10-09 18:00:44 +0000 | [diff] [blame] | 2810 | class CMDTryResultsTestCase(CMDTestCaseBase): |
| 2811 | _DEFAULT_REQUEST = { |
| 2812 | 'predicate': { |
Andrii Shyshkalov | 2cbae8a | 2019-10-11 21:30:27 +0000 | [diff] [blame] | 2813 | "gerritChanges": [{ |
| 2814 | "project": "depot_tools", |
| 2815 | "host": "chromium-review.googlesource.com", |
| 2816 | "patchset": 7, |
| 2817 | "change": 123456, |
| 2818 | }], |
Edward Lemur | baaf6be | 2019-10-09 18:00:44 +0000 | [diff] [blame] | 2819 | }, |
Andrii Shyshkalov | 2cbae8a | 2019-10-11 21:30:27 +0000 | [diff] [blame] | 2820 | 'fields': ('builds.*.id,builds.*.builder,builds.*.status' + |
| 2821 | ',builds.*.createTime,builds.*.tags'), |
Edward Lemur | baaf6be | 2019-10-09 18:00:44 +0000 | [diff] [blame] | 2822 | } |
| 2823 | |
| 2824 | def testNoJobs(self): |
| 2825 | git_cl._call_buildbucket.return_value = {} |
| 2826 | |
| 2827 | self.assertEqual(0, git_cl.main(['try-results'])) |
| 2828 | self.assertEqual('No tryjobs scheduled.\n', sys.stdout.getvalue()) |
| 2829 | git_cl._call_buildbucket.assert_called_once_with( |
| 2830 | mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds', |
| 2831 | self._DEFAULT_REQUEST) |
| 2832 | |
| 2833 | def testPrintToStdout(self): |
| 2834 | self.assertEqual(0, git_cl.main(['try-results'])) |
| 2835 | self.assertEqual([ |
| 2836 | 'Successes:', |
| 2837 | ' bot_success https://ci.chromium.org/b/103', |
| 2838 | 'Infra Failures:', |
| 2839 | ' bot_infra_failure https://ci.chromium.org/b/105', |
| 2840 | 'Failures:', |
| 2841 | ' bot_failure https://ci.chromium.org/b/104', |
| 2842 | 'Canceled:', |
| 2843 | ' bot_canceled ', |
| 2844 | 'Started:', |
| 2845 | ' bot_started https://ci.chromium.org/b/102', |
| 2846 | 'Scheduled:', |
| 2847 | ' bot_scheduled id=101', |
| 2848 | 'Other:', |
| 2849 | ' bot_status_unspecified id=100', |
| 2850 | 'Total: 7 tryjobs', |
| 2851 | ], sys.stdout.getvalue().splitlines()) |
| 2852 | git_cl._call_buildbucket.assert_called_once_with( |
| 2853 | mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds', |
| 2854 | self._DEFAULT_REQUEST) |
| 2855 | |
| 2856 | def testPrintToStdoutWithMasters(self): |
| 2857 | self.assertEqual(0, git_cl.main(['try-results', '--print-master'])) |
| 2858 | self.assertEqual([ |
| 2859 | 'Successes:', |
| 2860 | ' try bot_success https://ci.chromium.org/b/103', |
| 2861 | 'Infra Failures:', |
| 2862 | ' try bot_infra_failure https://ci.chromium.org/b/105', |
| 2863 | 'Failures:', |
| 2864 | ' try bot_failure https://ci.chromium.org/b/104', |
| 2865 | 'Canceled:', |
| 2866 | ' try bot_canceled ', |
| 2867 | 'Started:', |
| 2868 | ' try bot_started https://ci.chromium.org/b/102', |
| 2869 | 'Scheduled:', |
| 2870 | ' try bot_scheduled id=101', |
| 2871 | 'Other:', |
| 2872 | ' try bot_status_unspecified id=100', |
| 2873 | 'Total: 7 tryjobs', |
| 2874 | ], sys.stdout.getvalue().splitlines()) |
| 2875 | git_cl._call_buildbucket.assert_called_once_with( |
| 2876 | mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds', |
| 2877 | self._DEFAULT_REQUEST) |
| 2878 | |
| 2879 | @mock.patch('git_cl.write_json') |
| 2880 | def testWriteToJson(self, mockJsonDump): |
| 2881 | self.assertEqual(0, git_cl.main(['try-results', '--json', 'file.json'])) |
| 2882 | git_cl._call_buildbucket.assert_called_once_with( |
| 2883 | mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds', |
| 2884 | self._DEFAULT_REQUEST) |
| 2885 | mockJsonDump.assert_called_once_with( |
| 2886 | 'file.json', self._DEFAULT_RESPONSE['builds']) |
| 2887 | |
Andrii Shyshkalov | 2cbae8a | 2019-10-11 21:30:27 +0000 | [diff] [blame] | 2888 | def test_filter_failed_for_one_simple(self): |
| 2889 | self.assertEqual({}, git_cl._filter_failed_for_retry([])) |
Edward Lemur | baaf6be | 2019-10-09 18:00:44 +0000 | [diff] [blame] | 2890 | self.assertEqual({ |
Andrii Shyshkalov | 2cbae8a | 2019-10-11 21:30:27 +0000 | [diff] [blame] | 2891 | 'chromium/try': { |
| 2892 | 'bot_failure': [], |
| 2893 | 'bot_infra_failure': [] |
| 2894 | }, |
| 2895 | }, git_cl._filter_failed_for_retry(self._DEFAULT_RESPONSE['builds'])) |
| 2896 | |
| 2897 | def test_filter_failed_for_retry_many_builds(self): |
| 2898 | |
| 2899 | def _build(name, created_sec, status, experimental=False): |
| 2900 | assert 0 <= created_sec < 100, created_sec |
| 2901 | b = { |
| 2902 | 'id': 112112, |
| 2903 | 'builder': { |
| 2904 | 'project': 'chromium', |
| 2905 | 'bucket': 'try', |
| 2906 | 'builder': name, |
| 2907 | }, |
| 2908 | 'createTime': '2019-10-09T08:00:%02d.854286Z' % created_sec, |
| 2909 | 'status': status, |
| 2910 | 'tags': [], |
| 2911 | } |
| 2912 | if experimental: |
| 2913 | b['tags'].append({'key': 'cq_experimental', 'value': 'true'}) |
| 2914 | return b |
| 2915 | |
| 2916 | builds = [ |
| 2917 | _build('flaky-last-green', 1, 'FAILURE'), |
| 2918 | _build('flaky-last-green', 2, 'SUCCESS'), |
| 2919 | _build('flaky', 1, 'SUCCESS'), |
| 2920 | _build('flaky', 2, 'FAILURE'), |
| 2921 | _build('running', 1, 'FAILED'), |
| 2922 | _build('running', 2, 'SCHEDULED'), |
| 2923 | _build('yep-still-running', 1, 'STARTED'), |
| 2924 | _build('yep-still-running', 2, 'FAILURE'), |
| 2925 | _build('cq-experimental', 1, 'SUCCESS', experimental=True), |
| 2926 | _build('cq-experimental', 2, 'FAILURE', experimental=True), |
| 2927 | |
| 2928 | # Simulate experimental in CQ builder, which developer decided |
| 2929 | # to retry manually which resulted in 2nd build non-experimental. |
| 2930 | _build('sometimes-experimental', 1, 'FAILURE', experimental=True), |
| 2931 | _build('sometimes-experimental', 2, 'FAILURE', experimental=False), |
| 2932 | ] |
| 2933 | builds.sort(key=lambda b: b['status']) # ~deterministic shuffle. |
| 2934 | self.assertEqual({ |
| 2935 | 'chromium/try': { |
| 2936 | 'flaky': [], |
| 2937 | 'sometimes-experimental': [] |
| 2938 | }, |
| 2939 | }, git_cl._filter_failed_for_retry(builds)) |
Edward Lemur | baaf6be | 2019-10-09 18:00:44 +0000 | [diff] [blame] | 2940 | |
| 2941 | |
| 2942 | class CMDTryTestCase(CMDTestCaseBase): |
| 2943 | |
| 2944 | @mock.patch('git_cl.Changelist.SetCQState') |
| 2945 | @mock.patch('git_cl._get_bucket_map', return_value={}) |
| 2946 | def testSetCQDryRunByDefault(self, _mockGetBucketMap, mockSetCQState): |
| 2947 | mockSetCQState.return_value = 0 |
Edward Lemur | 4c707a2 | 2019-09-24 21:13:43 +0000 | [diff] [blame] | 2948 | self.assertEqual(0, git_cl.main(['try'])) |
| 2949 | git_cl.Changelist.SetCQState.assert_called_with(git_cl._CQState.DRY_RUN) |
| 2950 | self.assertEqual( |
| 2951 | sys.stdout.getvalue(), |
| 2952 | 'Scheduling CQ dry run on: ' |
| 2953 | 'https://chromium-review.googlesource.com/123456\n') |
| 2954 | |
Edward Lemur | 4c707a2 | 2019-09-24 21:13:43 +0000 | [diff] [blame] | 2955 | @mock.patch('git_cl._call_buildbucket') |
Edward Lemur | baaf6be | 2019-10-09 18:00:44 +0000 | [diff] [blame] | 2956 | def testScheduleOnBuildbucket(self, mockCallBuildbucket): |
Edward Lemur | 4c707a2 | 2019-09-24 21:13:43 +0000 | [diff] [blame] | 2957 | mockCallBuildbucket.return_value = {} |
Edward Lemur | 4c707a2 | 2019-09-24 21:13:43 +0000 | [diff] [blame] | 2958 | |
| 2959 | self.assertEqual(0, git_cl.main([ |
| 2960 | 'try', '-B', 'luci.chromium.try', '-b', 'win', |
| 2961 | '-p', 'key=val', '-p', 'json=[{"a":1}, null]'])) |
| 2962 | self.assertIn( |
| 2963 | 'Scheduling jobs on:\nBucket: luci.chromium.try', |
| 2964 | git_cl.sys.stdout.getvalue()) |
| 2965 | |
| 2966 | expected_request = { |
| 2967 | "requests": [{ |
| 2968 | "scheduleBuild": { |
| 2969 | "requestId": "uuid4", |
| 2970 | "builder": { |
| 2971 | "project": "chromium", |
| 2972 | "builder": "win", |
| 2973 | "bucket": "try", |
| 2974 | }, |
| 2975 | "gerritChanges": [{ |
| 2976 | "project": "depot_tools", |
| 2977 | "host": "chromium-review.googlesource.com", |
| 2978 | "patchset": 7, |
| 2979 | "change": 123456, |
| 2980 | }], |
| 2981 | "properties": { |
| 2982 | "category": "git_cl_try", |
| 2983 | "json": [{"a": 1}, None], |
| 2984 | "key": "val", |
| 2985 | }, |
| 2986 | "tags": [ |
| 2987 | {"value": "win", "key": "builder"}, |
| 2988 | {"value": "git_cl_try", "key": "user_agent"}, |
| 2989 | ], |
| 2990 | }, |
| 2991 | }], |
| 2992 | } |
| 2993 | mockCallBuildbucket.assert_called_with( |
| 2994 | mock.ANY, 'cr-buildbucket.appspot.com', 'Batch', expected_request) |
| 2995 | |
Anthony Polito | 1a5fe23 | 2020-01-24 23:17:52 +0000 | [diff] [blame] | 2996 | @mock.patch('git_cl._call_buildbucket') |
| 2997 | def testScheduleOnBuildbucketWithRevision(self, mockCallBuildbucket): |
| 2998 | mockCallBuildbucket.return_value = {} |
| 2999 | |
| 3000 | self.assertEqual(0, git_cl.main([ |
| 3001 | 'try', '-B', 'luci.chromium.try', '-b', 'win', '-b', 'linux', |
| 3002 | '-p', 'key=val', '-p', 'json=[{"a":1}, null]', |
| 3003 | '-r', 'beeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeef'])) |
| 3004 | self.assertIn( |
| 3005 | 'Scheduling jobs on:\nBucket: luci.chromium.try', |
| 3006 | git_cl.sys.stdout.getvalue()) |
| 3007 | |
| 3008 | expected_request = { |
| 3009 | "requests": [{ |
| 3010 | "scheduleBuild": { |
| 3011 | "requestId": "uuid4", |
| 3012 | "builder": { |
| 3013 | "project": "chromium", |
| 3014 | "builder": "linux", |
| 3015 | "bucket": "try", |
| 3016 | }, |
| 3017 | "gerritChanges": [{ |
| 3018 | "project": "depot_tools", |
| 3019 | "host": "chromium-review.googlesource.com", |
| 3020 | "patchset": 7, |
| 3021 | "change": 123456, |
| 3022 | }], |
| 3023 | "properties": { |
| 3024 | "category": "git_cl_try", |
| 3025 | "json": [{"a": 1}, None], |
| 3026 | "key": "val", |
| 3027 | }, |
| 3028 | "tags": [ |
| 3029 | {"value": "linux", "key": "builder"}, |
| 3030 | {"value": "git_cl_try", "key": "user_agent"}, |
| 3031 | ], |
| 3032 | "gitilesCommit": { |
| 3033 | "host": "chromium-review.googlesource.com", |
| 3034 | "project": "depot_tools", |
| 3035 | "id": "beeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeef", |
| 3036 | } |
| 3037 | }, |
| 3038 | }, |
| 3039 | { |
| 3040 | "scheduleBuild": { |
| 3041 | "requestId": "uuid4", |
| 3042 | "builder": { |
| 3043 | "project": "chromium", |
| 3044 | "builder": "win", |
| 3045 | "bucket": "try", |
| 3046 | }, |
| 3047 | "gerritChanges": [{ |
| 3048 | "project": "depot_tools", |
| 3049 | "host": "chromium-review.googlesource.com", |
| 3050 | "patchset": 7, |
| 3051 | "change": 123456, |
| 3052 | }], |
| 3053 | "properties": { |
| 3054 | "category": "git_cl_try", |
| 3055 | "json": [{"a": 1}, None], |
| 3056 | "key": "val", |
| 3057 | }, |
| 3058 | "tags": [ |
| 3059 | {"value": "win", "key": "builder"}, |
| 3060 | {"value": "git_cl_try", "key": "user_agent"}, |
| 3061 | ], |
| 3062 | "gitilesCommit": { |
| 3063 | "host": "chromium-review.googlesource.com", |
| 3064 | "project": "depot_tools", |
| 3065 | "id": "beeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeef", |
| 3066 | } |
| 3067 | }, |
| 3068 | }], |
| 3069 | } |
| 3070 | mockCallBuildbucket.assert_called_with( |
| 3071 | mock.ANY, 'cr-buildbucket.appspot.com', 'Batch', expected_request) |
| 3072 | |
Edward Lemur | baaf6be | 2019-10-09 18:00:44 +0000 | [diff] [blame] | 3073 | def testScheduleOnBuildbucket_WrongBucket(self): |
Edward Lemur | 4c707a2 | 2019-09-24 21:13:43 +0000 | [diff] [blame] | 3074 | self.assertEqual(0, git_cl.main([ |
| 3075 | 'try', '-B', 'not-a-bucket', '-b', 'win', |
| 3076 | '-p', 'key=val', '-p', 'json=[{"a":1}, null]'])) |
| 3077 | self.assertIn( |
| 3078 | 'WARNING Could not parse bucket "not-a-bucket". Skipping.', |
| 3079 | git_cl.sys.stdout.getvalue()) |
| 3080 | |
Andrii Shyshkalov | aeee6a8 | 2019-10-09 21:56:25 +0000 | [diff] [blame] | 3081 | @mock.patch('git_cl._call_buildbucket') |
| 3082 | @mock.patch('git_cl.fetch_try_jobs') |
| 3083 | def testScheduleOnBuildbucketRetryFailed( |
| 3084 | self, mockFetchTryJobs, mockCallBuildbucket): |
| 3085 | |
| 3086 | git_cl.fetch_try_jobs.side_effect = lambda *_, **kw: { |
| 3087 | 7: [], |
| 3088 | 6: [{ |
| 3089 | 'id': 112112, |
| 3090 | 'builder': { |
| 3091 | 'project': 'chromium', |
| 3092 | 'bucket': 'try', |
Andrii Shyshkalov | 2cbae8a | 2019-10-11 21:30:27 +0000 | [diff] [blame] | 3093 | 'builder': 'linux',}, |
| 3094 | 'createTime': '2019-10-09T08:00:01.854286Z', |
| 3095 | 'tags': [], |
| 3096 | 'status': 'FAILURE',}],}[kw['patchset']] |
Andrii Shyshkalov | aeee6a8 | 2019-10-09 21:56:25 +0000 | [diff] [blame] | 3097 | mockCallBuildbucket.return_value = {} |
| 3098 | |
| 3099 | self.assertEqual(0, git_cl.main(['try', '--retry-failed'])) |
| 3100 | self.assertIn( |
| 3101 | 'Scheduling jobs on:\nBucket: chromium/try', |
| 3102 | git_cl.sys.stdout.getvalue()) |
| 3103 | |
| 3104 | expected_request = { |
| 3105 | "requests": [{ |
| 3106 | "scheduleBuild": { |
| 3107 | "requestId": "uuid4", |
| 3108 | "builder": { |
| 3109 | "project": "chromium", |
| 3110 | "bucket": "try", |
| 3111 | "builder": "linux", |
| 3112 | }, |
| 3113 | "gerritChanges": [{ |
| 3114 | "project": "depot_tools", |
| 3115 | "host": "chromium-review.googlesource.com", |
| 3116 | "patchset": 7, |
| 3117 | "change": 123456, |
| 3118 | }], |
| 3119 | "properties": { |
| 3120 | "category": "git_cl_try", |
| 3121 | }, |
| 3122 | "tags": [ |
| 3123 | {"value": "linux", "key": "builder"}, |
| 3124 | {"value": "git_cl_try", "key": "user_agent"}, |
| 3125 | {"value": "1", "key": "retry_failed"}, |
| 3126 | ], |
| 3127 | }, |
| 3128 | }], |
| 3129 | } |
| 3130 | mockCallBuildbucket.assert_called_with( |
| 3131 | mock.ANY, 'cr-buildbucket.appspot.com', 'Batch', expected_request) |
| 3132 | |
Edward Lemur | 4c707a2 | 2019-09-24 21:13:43 +0000 | [diff] [blame] | 3133 | def test_parse_bucket(self): |
| 3134 | test_cases = [ |
| 3135 | { |
| 3136 | 'bucket': 'chromium/try', |
| 3137 | 'result': ('chromium', 'try'), |
| 3138 | }, |
| 3139 | { |
| 3140 | 'bucket': 'luci.chromium.try', |
| 3141 | 'result': ('chromium', 'try'), |
| 3142 | 'has_warning': True, |
| 3143 | }, |
| 3144 | { |
| 3145 | 'bucket': 'skia.primary', |
| 3146 | 'result': ('skia', 'skia.primary'), |
| 3147 | 'has_warning': True, |
| 3148 | }, |
| 3149 | { |
| 3150 | 'bucket': 'not-a-bucket', |
| 3151 | 'result': (None, None), |
| 3152 | }, |
| 3153 | ] |
| 3154 | |
| 3155 | for test_case in test_cases: |
| 3156 | git_cl.sys.stdout.truncate(0) |
| 3157 | self.assertEqual( |
| 3158 | test_case['result'], git_cl._parse_bucket(test_case['bucket'])) |
| 3159 | if test_case.get('has_warning'): |
Edward Lemur | 6215c79 | 2019-10-03 21:59:05 +0000 | [diff] [blame] | 3160 | expected_warning = 'WARNING Please use %s/%s to specify the bucket' % ( |
| 3161 | test_case['result']) |
| 3162 | self.assertIn(expected_warning, git_cl.sys.stdout.getvalue()) |
Edward Lemur | 4c707a2 | 2019-09-24 21:13:43 +0000 | [diff] [blame] | 3163 | |
| 3164 | |
Edward Lemur | baaf6be | 2019-10-09 18:00:44 +0000 | [diff] [blame] | 3165 | class CMDUploadTestCase(CMDTestCaseBase): |
Quinten Yearsley | a19d353 | 2019-09-30 21:54:39 +0000 | [diff] [blame] | 3166 | def setUp(self): |
| 3167 | super(CMDUploadTestCase, self).setUp() |
Edward Lemur | baaf6be | 2019-10-09 18:00:44 +0000 | [diff] [blame] | 3168 | mock.patch('git_cl.fetch_try_jobs').start() |
| 3169 | mock.patch('git_cl._trigger_try_jobs', return_value={}).start() |
| 3170 | mock.patch('git_cl.Changelist.CMDUpload', return_value=0).start() |
Anthony Polito | 46689b0 | 2019-11-15 20:56:41 +0000 | [diff] [blame] | 3171 | mock.patch('git_cl.Settings.GetIsGerrit', return_value=True).start() |
Quinten Yearsley | a19d353 | 2019-09-30 21:54:39 +0000 | [diff] [blame] | 3172 | self.addCleanup(mock.patch.stopall) |
| 3173 | |
Edward Lesmes | 7677e5c | 2020-02-19 20:39:03 +0000 | [diff] [blame] | 3174 | def testWarmUpChangeDetailCache(self): |
| 3175 | self.assertEqual(0, git_cl.main(['upload'])) |
| 3176 | gerrit_util.GetChangeDetail.assert_called_once_with( |
| 3177 | 'chromium-review.googlesource.com', 'depot_tools~123456', |
| 3178 | frozenset([ |
| 3179 | 'LABELS', 'CURRENT_REVISION', 'DETAILED_ACCOUNTS', |
| 3180 | 'CURRENT_COMMIT'])) |
| 3181 | |
Edward Lemur | baaf6be | 2019-10-09 18:00:44 +0000 | [diff] [blame] | 3182 | def testUploadRetryFailed(self): |
Quinten Yearsley | a19d353 | 2019-09-30 21:54:39 +0000 | [diff] [blame] | 3183 | # This test mocks out the actual upload part, and just asserts that after |
| 3184 | # upload, if --retry-failed is added, then the tool will fetch try jobs |
| 3185 | # from the previous patchset and trigger the right builders on the latest |
| 3186 | # patchset. |
Edward Lemur | baaf6be | 2019-10-09 18:00:44 +0000 | [diff] [blame] | 3187 | git_cl.fetch_try_jobs.side_effect = [ |
| 3188 | # Latest patchset: No builds. |
| 3189 | [], |
| 3190 | # Patchset before latest: Some builds. |
Andrii Shyshkalov | 2cbae8a | 2019-10-11 21:30:27 +0000 | [diff] [blame] | 3191 | [{ |
| 3192 | 'id': str(100 + idx), |
| 3193 | 'builder': { |
| 3194 | 'project': 'chromium', |
| 3195 | 'bucket': 'try', |
| 3196 | 'builder': 'bot_' + status.lower(), |
| 3197 | }, |
| 3198 | 'createTime': '2019-10-09T08:00:0%d.854286Z' % (idx % 10), |
| 3199 | 'tags': [], |
| 3200 | 'status': status, |
| 3201 | } for idx, status in enumerate(self._STATUSES)], |
Andrii Shyshkalov | 1ad5811 | 2019-10-08 01:46:14 +0000 | [diff] [blame] | 3202 | ] |
Edward Lemur | baaf6be | 2019-10-09 18:00:44 +0000 | [diff] [blame] | 3203 | |
Quinten Yearsley | a19d353 | 2019-09-30 21:54:39 +0000 | [diff] [blame] | 3204 | self.assertEqual(0, git_cl.main(['upload', '--retry-failed'])) |
Edward Lemur | baaf6be | 2019-10-09 18:00:44 +0000 | [diff] [blame] | 3205 | self.assertEqual([ |
Edward Lemur | 5b929a4 | 2019-10-21 17:57:39 +0000 | [diff] [blame] | 3206 | mock.call(mock.ANY, 'cr-buildbucket.appspot.com', patchset=7), |
| 3207 | mock.call(mock.ANY, 'cr-buildbucket.appspot.com', patchset=6), |
Edward Lemur | baaf6be | 2019-10-09 18:00:44 +0000 | [diff] [blame] | 3208 | ], git_cl.fetch_try_jobs.mock_calls) |
| 3209 | expected_buckets = { |
| 3210 | 'chromium/try': {'bot_failure': [], 'bot_infra_failure': []}, |
| 3211 | } |
| 3212 | git_cl._trigger_try_jobs.assert_called_once_with( |
Edward Lemur | 5b929a4 | 2019-10-21 17:57:39 +0000 | [diff] [blame] | 3213 | mock.ANY, expected_buckets, mock.ANY, 8) |
Quinten Yearsley | a19d353 | 2019-09-30 21:54:39 +0000 | [diff] [blame] | 3214 | |
Brian Sheedy | 59b06a8 | 2019-10-14 17:03:29 +0000 | [diff] [blame] | 3215 | |
Edward Lemur | da4b6c6 | 2020-02-13 00:28:40 +0000 | [diff] [blame] | 3216 | class CMDFormatTestCase(unittest.TestCase): |
Brian Sheedy | 59b06a8 | 2019-10-14 17:03:29 +0000 | [diff] [blame] | 3217 | |
| 3218 | def setUp(self): |
| 3219 | super(CMDFormatTestCase, self).setUp() |
Jamie Madill | 5e96ad1 | 2020-01-13 16:08:35 +0000 | [diff] [blame] | 3220 | mock.patch('git_cl.RunCommand').start() |
| 3221 | mock.patch('clang_format.FindClangFormatToolInChromiumTree').start() |
| 3222 | mock.patch('clang_format.FindClangFormatScriptInChromiumTree').start() |
| 3223 | mock.patch('git_cl.settings').start() |
Brian Sheedy | 59b06a8 | 2019-10-14 17:03:29 +0000 | [diff] [blame] | 3224 | self._top_dir = tempfile.mkdtemp() |
Jamie Madill | 5e96ad1 | 2020-01-13 16:08:35 +0000 | [diff] [blame] | 3225 | self.addCleanup(mock.patch.stopall) |
Brian Sheedy | 59b06a8 | 2019-10-14 17:03:29 +0000 | [diff] [blame] | 3226 | |
| 3227 | def tearDown(self): |
| 3228 | shutil.rmtree(self._top_dir) |
| 3229 | super(CMDFormatTestCase, self).tearDown() |
| 3230 | |
Jamie Madill | 5e96ad1 | 2020-01-13 16:08:35 +0000 | [diff] [blame] | 3231 | def _make_temp_file(self, fname, contents): |
| 3232 | with open(os.path.join(self._top_dir, fname), 'w') as tf: |
| 3233 | tf.write('\n'.join(contents)) |
| 3234 | |
Brian Sheedy | 59b06a8 | 2019-10-14 17:03:29 +0000 | [diff] [blame] | 3235 | def _make_yapfignore(self, contents): |
Jamie Madill | 5e96ad1 | 2020-01-13 16:08:35 +0000 | [diff] [blame] | 3236 | self._make_temp_file('.yapfignore', contents) |
Brian Sheedy | 59b06a8 | 2019-10-14 17:03:29 +0000 | [diff] [blame] | 3237 | |
Brian Sheedy | b4307d5 | 2019-12-02 19:18:17 +0000 | [diff] [blame] | 3238 | def _check_yapf_filtering(self, files, expected): |
| 3239 | self.assertEqual(expected, git_cl._FilterYapfIgnoredFiles( |
| 3240 | files, git_cl._GetYapfIgnorePatterns(self._top_dir))) |
Brian Sheedy | 59b06a8 | 2019-10-14 17:03:29 +0000 | [diff] [blame] | 3241 | |
Jamie Madill | 5e96ad1 | 2020-01-13 16:08:35 +0000 | [diff] [blame] | 3242 | def testClangFormatDiffFull(self): |
| 3243 | self._make_temp_file('test.cc', ['// test']) |
| 3244 | git_cl.settings.GetFormatFullByDefault.return_value = False |
| 3245 | diff_file = [os.path.join(self._top_dir, 'test.cc')] |
| 3246 | mock_opts = mock.Mock(full=True, dry_run=True, diff=False) |
| 3247 | |
| 3248 | # Diff |
| 3249 | git_cl.RunCommand.return_value = ' // test' |
| 3250 | return_value = git_cl._RunClangFormatDiff(mock_opts, diff_file, |
| 3251 | self._top_dir, 'HEAD') |
| 3252 | self.assertEqual(2, return_value) |
| 3253 | |
| 3254 | # No diff |
| 3255 | git_cl.RunCommand.return_value = '// test' |
| 3256 | return_value = git_cl._RunClangFormatDiff(mock_opts, diff_file, |
| 3257 | self._top_dir, 'HEAD') |
| 3258 | self.assertEqual(0, return_value) |
| 3259 | |
| 3260 | def testClangFormatDiff(self): |
| 3261 | git_cl.settings.GetFormatFullByDefault.return_value = False |
| 3262 | mock_opts = mock.Mock(full=False, dry_run=True, diff=False) |
| 3263 | |
| 3264 | # Diff |
| 3265 | git_cl.RunCommand.return_value = 'error' |
| 3266 | return_value = git_cl._RunClangFormatDiff(mock_opts, ['.'], self._top_dir, |
| 3267 | 'HEAD') |
| 3268 | self.assertEqual(2, return_value) |
| 3269 | |
| 3270 | # No diff |
| 3271 | git_cl.RunCommand.return_value = '' |
| 3272 | return_value = git_cl._RunClangFormatDiff(mock_opts, ['.'], self._top_dir, |
| 3273 | 'HEAD') |
| 3274 | self.assertEqual(0, return_value) |
| 3275 | |
Brian Sheedy | b4307d5 | 2019-12-02 19:18:17 +0000 | [diff] [blame] | 3276 | def testYapfignoreExplicit(self): |
| 3277 | self._make_yapfignore(['foo/bar.py', 'foo/bar/baz.py']) |
| 3278 | files = [ |
| 3279 | 'bar.py', |
| 3280 | 'foo/bar.py', |
| 3281 | 'foo/baz.py', |
| 3282 | 'foo/bar/baz.py', |
| 3283 | 'foo/bar/foobar.py', |
| 3284 | ] |
| 3285 | expected = [ |
| 3286 | 'bar.py', |
| 3287 | 'foo/baz.py', |
| 3288 | 'foo/bar/foobar.py', |
| 3289 | ] |
| 3290 | self._check_yapf_filtering(files, expected) |
Brian Sheedy | 59b06a8 | 2019-10-14 17:03:29 +0000 | [diff] [blame] | 3291 | |
Brian Sheedy | b4307d5 | 2019-12-02 19:18:17 +0000 | [diff] [blame] | 3292 | def testYapfignoreSingleWildcards(self): |
| 3293 | self._make_yapfignore(['*bar.py', 'foo*', 'baz*.py']) |
| 3294 | files = [ |
| 3295 | 'bar.py', # Matched by *bar.py. |
| 3296 | 'bar.txt', |
| 3297 | 'foobar.py', # Matched by *bar.py, foo*. |
| 3298 | 'foobar.txt', # Matched by foo*. |
| 3299 | 'bazbar.py', # Matched by *bar.py, baz*.py. |
| 3300 | 'bazbar.txt', |
| 3301 | 'foo/baz.txt', # Matched by foo*. |
| 3302 | 'bar/bar.py', # Matched by *bar.py. |
| 3303 | 'baz/foo.py', # Matched by baz*.py, foo*. |
| 3304 | 'baz/foo.txt', |
| 3305 | ] |
| 3306 | expected = [ |
| 3307 | 'bar.txt', |
| 3308 | 'bazbar.txt', |
| 3309 | 'baz/foo.txt', |
| 3310 | ] |
| 3311 | self._check_yapf_filtering(files, expected) |
Brian Sheedy | 59b06a8 | 2019-10-14 17:03:29 +0000 | [diff] [blame] | 3312 | |
Brian Sheedy | b4307d5 | 2019-12-02 19:18:17 +0000 | [diff] [blame] | 3313 | def testYapfignoreMultiplewildcards(self): |
| 3314 | self._make_yapfignore(['*bar*', '*foo*baz.txt']) |
| 3315 | files = [ |
| 3316 | 'bar.py', # Matched by *bar*. |
| 3317 | 'bar.txt', # Matched by *bar*. |
| 3318 | 'abar.py', # Matched by *bar*. |
| 3319 | 'foobaz.txt', # Matched by *foo*baz.txt. |
| 3320 | 'foobaz.py', |
| 3321 | 'afoobaz.txt', # Matched by *foo*baz.txt. |
| 3322 | ] |
| 3323 | expected = [ |
| 3324 | 'foobaz.py', |
| 3325 | ] |
| 3326 | self._check_yapf_filtering(files, expected) |
Brian Sheedy | 59b06a8 | 2019-10-14 17:03:29 +0000 | [diff] [blame] | 3327 | |
| 3328 | def testYapfignoreComments(self): |
| 3329 | self._make_yapfignore(['test.py', '#test2.py']) |
Brian Sheedy | b4307d5 | 2019-12-02 19:18:17 +0000 | [diff] [blame] | 3330 | files = [ |
| 3331 | 'test.py', |
| 3332 | 'test2.py', |
| 3333 | ] |
| 3334 | expected = [ |
| 3335 | 'test2.py', |
| 3336 | ] |
| 3337 | self._check_yapf_filtering(files, expected) |
Brian Sheedy | 59b06a8 | 2019-10-14 17:03:29 +0000 | [diff] [blame] | 3338 | |
| 3339 | def testYapfignoreBlankLines(self): |
| 3340 | self._make_yapfignore(['test.py', '', '', 'test2.py']) |
Brian Sheedy | b4307d5 | 2019-12-02 19:18:17 +0000 | [diff] [blame] | 3341 | files = [ |
| 3342 | 'test.py', |
| 3343 | 'test2.py', |
| 3344 | 'test3.py', |
| 3345 | ] |
| 3346 | expected = [ |
| 3347 | 'test3.py', |
| 3348 | ] |
| 3349 | self._check_yapf_filtering(files, expected) |
Brian Sheedy | 59b06a8 | 2019-10-14 17:03:29 +0000 | [diff] [blame] | 3350 | |
| 3351 | def testYapfignoreWhitespace(self): |
| 3352 | self._make_yapfignore([' test.py ']) |
Brian Sheedy | b4307d5 | 2019-12-02 19:18:17 +0000 | [diff] [blame] | 3353 | files = [ |
| 3354 | 'test.py', |
| 3355 | 'test2.py', |
| 3356 | ] |
| 3357 | expected = [ |
| 3358 | 'test2.py', |
| 3359 | ] |
| 3360 | self._check_yapf_filtering(files, expected) |
Brian Sheedy | 59b06a8 | 2019-10-14 17:03:29 +0000 | [diff] [blame] | 3361 | |
Brian Sheedy | b4307d5 | 2019-12-02 19:18:17 +0000 | [diff] [blame] | 3362 | def testYapfignoreNoFiles(self): |
Brian Sheedy | 59b06a8 | 2019-10-14 17:03:29 +0000 | [diff] [blame] | 3363 | self._make_yapfignore(['test.py']) |
Brian Sheedy | b4307d5 | 2019-12-02 19:18:17 +0000 | [diff] [blame] | 3364 | self._check_yapf_filtering([], []) |
| 3365 | |
| 3366 | def testYapfignoreMissingYapfignore(self): |
| 3367 | files = [ |
| 3368 | 'test.py', |
| 3369 | ] |
| 3370 | expected = [ |
| 3371 | 'test.py', |
| 3372 | ] |
| 3373 | self._check_yapf_filtering(files, expected) |
Brian Sheedy | 59b06a8 | 2019-10-14 17:03:29 +0000 | [diff] [blame] | 3374 | |
| 3375 | |
maruel@chromium.org | ddd5941 | 2011-11-30 14:20:38 +0000 | [diff] [blame] | 3376 | if __name__ == '__main__': |
Andrii Shyshkalov | 18df0cd | 2017-01-25 15:22:20 +0100 | [diff] [blame] | 3377 | logging.basicConfig( |
| 3378 | level=logging.DEBUG if '-v' in sys.argv else logging.ERROR) |
maruel@chromium.org | ddd5941 | 2011-11-30 14:20:38 +0000 | [diff] [blame] | 3379 | unittest.main() |