blob: 8378ee3eaf2d1cce92407dfc1f2e011613d1c467 [file] [log] [blame]
Edward Lemur0db01f02019-11-12 22:01:51 +00001#!/usr/bin/env vpython3
2# coding=utf-8
maruel@chromium.orgeb5edbc2012-01-16 17:03:28 +00003# Copyright (c) 2012 The Chromium Authors. All rights reserved.
maruel@chromium.orgddd59412011-11-30 14:20:38 +00004# Use of this source code is governed by a BSD-style license that can be
5# found in the LICENSE file.
6
7"""Unit tests for git_cl.py."""
8
Edward Lemur85153282020-02-14 22:06:29 +00009from __future__ import print_function
Edward Lemur0db01f02019-11-12 22:01:51 +000010from __future__ import unicode_literals
11
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +010012import datetime
tandriide281ae2016-10-12 06:02:30 -070013import json
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +010014import logging
maruel@chromium.orgddd59412011-11-30 14:20:38 +000015import os
Edward Lemur85153282020-02-14 22:06:29 +000016import pprint
Brian Sheedy59b06a82019-10-14 17:03:29 +000017import shutil
maruel@chromium.orgddd59412011-11-30 14:20:38 +000018import sys
Aaron Gable9a03ae02017-11-03 11:31:07 -070019import tempfile
maruel@chromium.orgddd59412011-11-30 14:20:38 +000020import unittest
21
Edward Lemura8145022020-01-06 18:47:54 +000022if sys.version_info.major == 2:
23 from StringIO import StringIO
24 import mock
25else:
26 from io import StringIO
27 from unittest import mock
28
maruel@chromium.orgddd59412011-11-30 14:20:38 +000029sys.path.insert(0, os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
30
Edward Lemur5ba1e9c2018-07-23 18:19:02 +000031import metrics
32# We have to disable monitoring before importing git_cl.
33metrics.DISABLE_METRICS_COLLECTION = True
34
Edward Lemur1773f372020-02-22 00:27:14 +000035import contextlib
Jamie Madill5e96ad12020-01-13 16:08:35 +000036import clang_format
Edward Lemur1773f372020-02-22 00:27:14 +000037import gclient_utils
Eric Boren2fb63102018-10-05 13:05:03 +000038import gerrit_util
maruel@chromium.orgddd59412011-11-30 14:20:38 +000039import git_cl
iannucci@chromium.org9e849272014-04-04 00:31:55 +000040import git_common
tandrii@chromium.org57d86542016-03-04 16:11:32 +000041import git_footers
Edward Lemur85153282020-02-14 22:06:29 +000042import git_new_branch
43import scm
maruel@chromium.orgddd59412011-11-30 14:20:38 +000044import subprocess2
maruel@chromium.orgddd59412011-11-30 14:20:38 +000045
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +000046
Edward Lemur0db01f02019-11-12 22:01:51 +000047def callError(code=1, cmd='', cwd='', stdout=b'', stderr=b''):
tandrii5d48c322016-08-18 16:19:37 -070048 return subprocess2.CalledProcessError(code, cmd, cwd, stdout, stderr)
49
50
Edward Lemur4c707a22019-09-24 21:13:43 +000051def _constantFn(return_value):
52 def f(*args, **kwargs):
53 return return_value
54 return f
55
56
tandrii5d48c322016-08-18 16:19:37 -070057CERR1 = callError(1)
58
59
Edward Lemur1773f372020-02-22 00:27:14 +000060class TemporaryFileMock(object):
61 def __init__(self):
62 self.suffix = 0
Aaron Gable9a03ae02017-11-03 11:31:07 -070063
Edward Lemur1773f372020-02-22 00:27:14 +000064 @contextlib.contextmanager
65 def __call__(self):
66 self.suffix += 1
67 yield '/tmp/fake-temp' + str(self.suffix)
Aaron Gable9a03ae02017-11-03 11:31:07 -070068
69
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000070class ChangelistMock(object):
71 # A class variable so we can access it when we don't have access to the
72 # instance that's being set.
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +000073 desc = ''
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000074 def __init__(self, **kwargs):
75 pass
76 def GetIssue(self):
77 return 1
Edward Lemur6c6827c2020-02-06 21:15:18 +000078 def FetchDescription(self):
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000079 return ChangelistMock.desc
dsansomee2d6fd92016-09-08 00:10:47 -070080 def UpdateDescription(self, desc, force=False):
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000081 ChangelistMock.desc = desc
82
tandrii5d48c322016-08-18 16:19:37 -070083
maruel@chromium.org2e72bb12012-01-17 15:18:35 +000084class PresubmitMock(object):
85 def __init__(self, *args, **kwargs):
86 self.reviewers = []
Daniel Cheng7227d212017-11-17 08:12:37 -080087 self.more_cc = ['chromium-reviews+test-more-cc@chromium.org']
88
maruel@chromium.org2e72bb12012-01-17 15:18:35 +000089 @staticmethod
90 def should_continue():
91 return True
92
93
Edward Lemur85153282020-02-14 22:06:29 +000094class GitMocks(object):
95 def __init__(self, config=None, branchref=None):
96 self.branchref = branchref or 'refs/heads/master'
97 self.config = config or {}
98
99 def GetBranchRef(self, _root):
100 return self.branchref
101
102 def NewBranch(self, branchref):
103 self.branchref = branchref
104
Edward Lemur26964072020-02-19 19:18:51 +0000105 def GetConfig(self, root, key, default=None):
106 if root != '':
107 key = '%s:%s' % (root, key)
Edward Lemur85153282020-02-14 22:06:29 +0000108 return self.config.get(key, default)
109
Edward Lemur26964072020-02-19 19:18:51 +0000110 def SetConfig(self, root, key, value=None):
111 if root != '':
112 key = '%s:%s' % (root, key)
Edward Lemur85153282020-02-14 22:06:29 +0000113 if value:
114 self.config[key] = value
115 return
116 if key not in self.config:
117 raise CERR1
118 del self.config[key]
119
120
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000121class WatchlistsMock(object):
122 def __init__(self, _):
123 pass
124 @staticmethod
125 def GetWatchersForPaths(_):
126 return ['joe@example.com']
127
128
Edward Lemur4c707a22019-09-24 21:13:43 +0000129class CodereviewSettingsFileMock(object):
130 def __init__(self):
131 pass
132 # pylint: disable=no-self-use
133 def read(self):
134 return ('CODE_REVIEW_SERVER: gerrit.chromium.org\n' +
135 'GERRIT_HOST: True\n')
136
137
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000138class AuthenticatorMock(object):
139 def __init__(self, *_args):
140 pass
141 def has_cached_credentials(self):
142 return True
tandrii221ab252016-10-06 08:12:04 -0700143 def authorize(self, http):
144 return http
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000145
146
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100147def CookiesAuthenticatorMockFactory(hosts_with_creds=None, same_auth=False):
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000148 """Use to mock Gerrit/Git credentials from ~/.netrc or ~/.gitcookies.
149
150 Usage:
151 >>> self.mock(git_cl.gerrit_util, "CookiesAuthenticator",
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100152 CookiesAuthenticatorMockFactory({'host': ('user', _, 'pass')})
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000153
154 OR
155 >>> self.mock(git_cl.gerrit_util, "CookiesAuthenticator",
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100156 CookiesAuthenticatorMockFactory(
157 same_auth=('user', '', 'pass'))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000158 """
159 class CookiesAuthenticatorMock(git_cl.gerrit_util.CookiesAuthenticator):
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800160 def __init__(self): # pylint: disable=super-init-not-called
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000161 # Intentionally not calling super() because it reads actual cookie files.
162 pass
163 @classmethod
164 def get_gitcookies_path(cls):
165 return '~/.gitcookies'
166 @classmethod
167 def get_netrc_path(cls):
168 return '~/.netrc'
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100169 def _get_auth_for_host(self, host):
170 if same_auth:
171 return same_auth
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000172 return (hosts_with_creds or {}).get(host)
173 return CookiesAuthenticatorMock
174
Aaron Gable9a03ae02017-11-03 11:31:07 -0700175
kmarshall9249e012016-08-23 12:02:16 -0700176class MockChangelistWithBranchAndIssue():
177 def __init__(self, branch, issue):
178 self.branch = branch
179 self.issue = issue
180 def GetBranch(self):
181 return self.branch
182 def GetIssue(self):
183 return self.issue
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000184
tandriic2405f52016-10-10 08:13:15 -0700185
186class SystemExitMock(Exception):
187 pass
188
189
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000190class TestGitClBasic(unittest.TestCase):
Edward Lemur6c6827c2020-02-06 21:15:18 +0000191 def test_fetch_description(self):
Edward Lemurf38bc172019-09-03 21:02:13 +0000192 cl = git_cl.Changelist(issue=1, codereview_host='host')
Andrii Shyshkalov31863012017-02-08 11:35:12 +0100193 cl.description = 'x'
194 cl.has_description = True
Edward Lemur6c6827c2020-02-06 21:15:18 +0000195 self.assertEqual(cl.FetchDescription(), 'x')
Robert Iannucci09f1f3d2017-03-28 16:54:32 -0700196
Andrii Shyshkalov71f0da32019-07-15 22:45:18 +0000197 def test_set_preserve_tryjobs(self):
198 d = git_cl.ChangeDescription('Simple.')
199 d.set_preserve_tryjobs()
200 self.assertEqual(d.description.splitlines(), [
201 'Simple.',
202 '',
203 'Cq-Do-Not-Cancel-Tryjobs: true',
204 ])
205 before = d.description
206 d.set_preserve_tryjobs()
207 self.assertEqual(before, d.description)
208
209 d = git_cl.ChangeDescription('\n'.join([
210 'One is enough',
211 '',
212 'Cq-Do-Not-Cancel-Tryjobs: dups not encouraged, but don\'t hurt',
213 'Change-Id: Ideadbeef',
214 ]))
215 d.set_preserve_tryjobs()
216 self.assertEqual(d.description.splitlines(), [
217 'One is enough',
218 '',
219 'Cq-Do-Not-Cancel-Tryjobs: dups not encouraged, but don\'t hurt',
220 'Change-Id: Ideadbeef',
221 'Cq-Do-Not-Cancel-Tryjobs: true',
222 ])
223
tandriif9aefb72016-07-01 09:06:51 -0700224 def test_get_bug_line_values(self):
225 f = lambda p, bugs: list(git_cl._get_bug_line_values(p, bugs))
226 self.assertEqual(f('', ''), [])
227 self.assertEqual(f('', '123,v8:456'), ['123', 'v8:456'])
228 self.assertEqual(f('v8', '456'), ['v8:456'])
229 self.assertEqual(f('v8', 'chromium:123,456'), ['v8:456', 'chromium:123'])
230 # Not nice, but not worth carying.
231 self.assertEqual(f('v8', 'chromium:123,456,v8:123'),
232 ['v8:456', 'chromium:123', 'v8:123'])
233
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100234 def _test_git_number(self, parent_msg, dest_ref, child_msg,
235 parent_hash='parenthash'):
236 desc = git_cl.ChangeDescription(child_msg)
237 desc.update_with_git_number_footers(parent_hash, parent_msg, dest_ref)
238 return desc.description
239
240 def assertEqualByLine(self, actual, expected):
241 self.assertEqual(actual.splitlines(), expected.splitlines())
242
243 def test_git_number_bad_parent(self):
244 with self.assertRaises(ValueError):
245 self._test_git_number('Parent', 'refs/heads/master', 'Child')
246
247 def test_git_number_bad_parent_footer(self):
248 with self.assertRaises(AssertionError):
249 self._test_git_number(
250 'Parent\n'
251 '\n'
252 'Cr-Commit-Position: wrong',
253 'refs/heads/master', 'Child')
254
255 def test_git_number_bad_lineage_ignored(self):
256 actual = self._test_git_number(
257 'Parent\n'
258 '\n'
259 'Cr-Commit-Position: refs/heads/master@{#1}\n'
260 'Cr-Branched-From: mustBeReal40CharHash-branch@{#pos}',
261 'refs/heads/master', 'Child')
262 self.assertEqualByLine(
263 actual,
264 'Child\n'
265 '\n'
266 'Cr-Commit-Position: refs/heads/master@{#2}\n'
267 'Cr-Branched-From: mustBeReal40CharHash-branch@{#pos}')
268
269 def test_git_number_same_branch(self):
270 actual = self._test_git_number(
271 'Parent\n'
272 '\n'
273 'Cr-Commit-Position: refs/heads/master@{#12}',
274 dest_ref='refs/heads/master',
275 child_msg='Child')
276 self.assertEqualByLine(
277 actual,
278 'Child\n'
279 '\n'
280 'Cr-Commit-Position: refs/heads/master@{#13}')
281
Andrii Shyshkalovde37c012017-07-06 21:06:50 +0200282 def test_git_number_same_branch_mixed_footers(self):
283 actual = self._test_git_number(
284 'Parent\n'
285 '\n'
286 'Cr-Commit-Position: refs/heads/master@{#12}',
287 dest_ref='refs/heads/master',
288 child_msg='Child\n'
289 '\n'
290 'Broken-by: design\n'
291 'BUG=123')
292 self.assertEqualByLine(
293 actual,
294 'Child\n'
295 '\n'
296 'Broken-by: design\n'
297 'BUG=123\n'
298 'Cr-Commit-Position: refs/heads/master@{#13}')
299
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100300 def test_git_number_same_branch_with_originals(self):
301 actual = self._test_git_number(
302 'Parent\n'
303 '\n'
304 'Cr-Commit-Position: refs/heads/master@{#12}',
305 dest_ref='refs/heads/master',
306 child_msg='Child\n'
307 '\n'
308 'Some users are smart and insert their own footers\n'
309 '\n'
310 'Cr-Whatever: value\n'
311 'Cr-Commit-Position: refs/copy/paste@{#22}')
312 self.assertEqualByLine(
313 actual,
314 'Child\n'
315 '\n'
316 'Some users are smart and insert their own footers\n'
317 '\n'
318 'Cr-Original-Whatever: value\n'
319 'Cr-Original-Commit-Position: refs/copy/paste@{#22}\n'
320 'Cr-Commit-Position: refs/heads/master@{#13}')
321
322 def test_git_number_new_branch(self):
323 actual = self._test_git_number(
324 'Parent\n'
325 '\n'
326 'Cr-Commit-Position: refs/heads/master@{#12}',
327 dest_ref='refs/heads/branch',
328 child_msg='Child')
329 self.assertEqualByLine(
330 actual,
331 'Child\n'
332 '\n'
333 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
334 'Cr-Branched-From: parenthash-refs/heads/master@{#12}')
335
336 def test_git_number_lineage(self):
337 actual = self._test_git_number(
338 'Parent\n'
339 '\n'
340 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
341 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
342 dest_ref='refs/heads/branch',
343 child_msg='Child')
344 self.assertEqualByLine(
345 actual,
346 'Child\n'
347 '\n'
348 'Cr-Commit-Position: refs/heads/branch@{#2}\n'
349 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
350
351 def test_git_number_moooooooore_lineage(self):
352 actual = self._test_git_number(
353 'Parent\n'
354 '\n'
355 'Cr-Commit-Position: refs/heads/branch@{#5}\n'
356 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
357 dest_ref='refs/heads/mooore',
358 child_msg='Child')
359 self.assertEqualByLine(
360 actual,
361 'Child\n'
362 '\n'
363 'Cr-Commit-Position: refs/heads/mooore@{#1}\n'
364 'Cr-Branched-From: parenthash-refs/heads/branch@{#5}\n'
365 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
366
Andrii Shyshkalovb5effa12016-12-14 19:35:12 +0100367 def test_git_number_ever_moooooooore_lineage(self):
Robert Iannucci456b0d62018-03-13 19:15:50 -0700368 self.maxDiff = 10000 # pylint: disable=attribute-defined-outside-init
Andrii Shyshkalovb5effa12016-12-14 19:35:12 +0100369 actual = self._test_git_number(
370 'CQ commit on fresh new branch + numbering.\n'
371 '\n'
372 'NOTRY=True\n'
373 'NOPRESUBMIT=True\n'
374 'BUG=\n'
375 '\n'
376 'Review-Url: https://codereview.chromium.org/2577703003\n'
377 'Cr-Commit-Position: refs/heads/gnumb-test/br@{#1}\n'
378 'Cr-Branched-From: 0749ff9edc-refs/heads/gnumb-test/cq@{#4}\n'
379 'Cr-Branched-From: 5c49df2da6-refs/heads/master@{#41618}',
380 dest_ref='refs/heads/gnumb-test/cl',
381 child_msg='git cl on fresh new branch + numbering.\n'
382 '\n'
383 'Review-Url: https://codereview.chromium.org/2575043003 .\n')
384 self.assertEqualByLine(
385 actual,
386 'git cl on fresh new branch + numbering.\n'
387 '\n'
388 'Review-Url: https://codereview.chromium.org/2575043003 .\n'
389 'Cr-Commit-Position: refs/heads/gnumb-test/cl@{#1}\n'
390 'Cr-Branched-From: parenthash-refs/heads/gnumb-test/br@{#1}\n'
391 'Cr-Branched-From: 0749ff9edc-refs/heads/gnumb-test/cq@{#4}\n'
392 'Cr-Branched-From: 5c49df2da6-refs/heads/master@{#41618}')
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100393
394 def test_git_number_cherry_pick(self):
395 actual = self._test_git_number(
396 'Parent\n'
397 '\n'
398 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
399 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
400 dest_ref='refs/heads/branch',
401 child_msg='Child, which is cherry-pick from master\n'
402 '\n'
403 'Cr-Commit-Position: refs/heads/master@{#100}\n'
404 '(cherry picked from commit deadbeef12345678deadbeef12345678deadbeef)')
405 self.assertEqualByLine(
406 actual,
407 'Child, which is cherry-pick from master\n'
408 '\n'
409 '(cherry picked from commit deadbeef12345678deadbeef12345678deadbeef)\n'
410 '\n'
411 'Cr-Original-Commit-Position: refs/heads/master@{#100}\n'
412 'Cr-Commit-Position: refs/heads/branch@{#2}\n'
413 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
414
Edward Lemurda4b6c62020-02-13 00:28:40 +0000415 @mock.patch('gerrit_util.GetAccountDetails')
416 def test_valid_accounts(self, mockGetAccountDetails):
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +0000417 mock_per_account = {
418 'u1': None, # 404, doesn't exist.
419 'u2': {
420 '_account_id': 123124,
421 'avatars': [],
422 'email': 'u2@example.com',
423 'name': 'User Number 2',
424 'status': 'OOO',
425 },
426 'u3': git_cl.gerrit_util.GerritError(500, 'retries didn\'t help :('),
427 }
428 def GetAccountDetailsMock(_, account):
429 # Poor-man's mock library's side_effect.
430 v = mock_per_account.pop(account)
431 if isinstance(v, Exception):
432 raise v
433 return v
434
Edward Lemurda4b6c62020-02-13 00:28:40 +0000435 mockGetAccountDetails.side_effect = GetAccountDetailsMock
436 actual = git_cl.gerrit_util.ValidAccounts(
437 'host', ['u1', 'u2', 'u3'], max_threads=1)
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +0000438 self.assertEqual(actual, {
439 'u2': {
440 '_account_id': 123124,
441 'avatars': [],
442 'email': 'u2@example.com',
443 'name': 'User Number 2',
444 'status': 'OOO',
445 },
446 })
447
448
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200449class TestParseIssueURL(unittest.TestCase):
450 def _validate(self, parsed, issue=None, patchset=None, hostname=None,
Edward Lemurf38bc172019-09-03 21:02:13 +0000451 fail=False):
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200452 self.assertIsNotNone(parsed)
453 if fail:
454 self.assertFalse(parsed.valid)
455 return
456 self.assertTrue(parsed.valid)
457 self.assertEqual(parsed.issue, issue)
458 self.assertEqual(parsed.patchset, patchset)
459 self.assertEqual(parsed.hostname, hostname)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200460
Edward Lemur678a6842019-10-03 22:25:05 +0000461 def test_ParseIssueNumberArgument(self):
462 def test(arg, *args, **kwargs):
463 self._validate(git_cl.ParseIssueNumberArgument(arg), *args, **kwargs)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200464
Edward Lemur678a6842019-10-03 22:25:05 +0000465 test('123', 123)
466 test('', fail=True)
467 test('abc', fail=True)
468 test('123/1', fail=True)
469 test('123a', fail=True)
470 test('ssh://chrome-review.source.com/#/c/123/4/', fail=True)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200471
Edward Lemur678a6842019-10-03 22:25:05 +0000472 test('https://codereview.source.com/123',
473 123, None, 'codereview.source.com')
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200474 test('http://chrome-review.source.com/c/123',
475 123, None, 'chrome-review.source.com')
476 test('https://chrome-review.source.com/c/123/',
477 123, None, 'chrome-review.source.com')
478 test('https://chrome-review.source.com/c/123/4',
479 123, 4, 'chrome-review.source.com')
480 test('https://chrome-review.source.com/#/c/123/4',
481 123, 4, 'chrome-review.source.com')
482 test('https://chrome-review.source.com/c/123/4',
483 123, 4, 'chrome-review.source.com')
484 test('https://chrome-review.source.com/123',
485 123, None, 'chrome-review.source.com')
486 test('https://chrome-review.source.com/123/4',
487 123, 4, 'chrome-review.source.com')
488
Edward Lemur678a6842019-10-03 22:25:05 +0000489 test('https://chrome-review.source.com/bad/123/4', fail=True)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200490 test('https://chrome-review.source.com/c/123/1/whatisthis', fail=True)
491 test('https://chrome-review.source.com/c/abc/', fail=True)
492 test('ssh://chrome-review.source.com/c/123/1/', fail=True)
493
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200494
495
Edward Lemurda4b6c62020-02-13 00:28:40 +0000496class GitCookiesCheckerTest(unittest.TestCase):
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100497 def setUp(self):
498 super(GitCookiesCheckerTest, self).setUp()
499 self.c = git_cl._GitCookiesChecker()
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100500 self.c._all_hosts = []
Edward Lemurda4b6c62020-02-13 00:28:40 +0000501 mock.patch('sys.stdout', StringIO()).start()
502 self.addCleanup(mock.patch.stopall)
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100503
504 def mock_hosts_creds(self, subhost_identity_pairs):
505 def ensure_googlesource(h):
506 if not h.endswith(self.c._GOOGLESOURCE):
507 assert not h.endswith('.')
508 return h + '.' + self.c._GOOGLESOURCE
509 return h
510 self.c._all_hosts = [(ensure_googlesource(h), i, '.gitcookies')
511 for h, i in subhost_identity_pairs]
512
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +0200513 def test_identity_parsing(self):
514 self.assertEqual(self.c._parse_identity('ldap.google.com'),
515 ('ldap', 'google.com'))
516 self.assertEqual(self.c._parse_identity('git-ldap.example.com'),
517 ('ldap', 'example.com'))
518 # Specical case because we know there are no subdomains in chromium.org.
519 self.assertEqual(self.c._parse_identity('git-note.period.chromium.org'),
520 ('note.period', 'chromium.org'))
Lei Zhangd3f769a2017-12-15 15:16:14 -0800521 # Pathological: ".period." can be either username OR domain, more likely
522 # domain.
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +0200523 self.assertEqual(self.c._parse_identity('git-note.period.example.com'),
524 ('note', 'period.example.com'))
525
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100526 def test_analysis_nothing(self):
527 self.c._all_hosts = []
528 self.assertFalse(self.c.has_generic_host())
529 self.assertEqual(set(), self.c.get_conflicting_hosts())
530 self.assertEqual(set(), self.c.get_duplicated_hosts())
531 self.assertEqual(set(), self.c.get_partially_configured_hosts())
532 self.assertEqual(set(), self.c.get_hosts_with_wrong_identities())
533
534 def test_analysis(self):
535 self.mock_hosts_creds([
536 ('.googlesource.com', 'git-example.chromium.org'),
537
538 ('chromium', 'git-example.google.com'),
539 ('chromium-review', 'git-example.google.com'),
540 ('chrome-internal', 'git-example.chromium.org'),
541 ('chrome-internal-review', 'git-example.chromium.org'),
542 ('conflict', 'git-example.google.com'),
543 ('conflict-review', 'git-example.chromium.org'),
544 ('dup', 'git-example.google.com'),
545 ('dup', 'git-example.google.com'),
546 ('dup-review', 'git-example.google.com'),
547 ('partial', 'git-example.google.com'),
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200548 ('gpartial-review', 'git-example.google.com'),
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100549 ])
550 self.assertTrue(self.c.has_generic_host())
551 self.assertEqual(set(['conflict.googlesource.com']),
552 self.c.get_conflicting_hosts())
553 self.assertEqual(set(['dup.googlesource.com']),
554 self.c.get_duplicated_hosts())
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200555 self.assertEqual(set(['partial.googlesource.com',
556 'gpartial-review.googlesource.com']),
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100557 self.c.get_partially_configured_hosts())
558 self.assertEqual(set(['chromium.googlesource.com',
559 'chrome-internal.googlesource.com']),
560 self.c.get_hosts_with_wrong_identities())
561
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100562 def test_report_no_problems(self):
563 self.test_analysis_nothing()
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100564 self.assertFalse(self.c.find_and_report_problems())
565 self.assertEqual(sys.stdout.getvalue(), '')
566
Edward Lemurda4b6c62020-02-13 00:28:40 +0000567 @mock.patch(
568 'git_cl.gerrit_util.CookiesAuthenticator.get_gitcookies_path',
569 return_value='~/.gitcookies')
570 def test_report(self, *_mocks):
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100571 self.test_analysis()
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100572 self.assertTrue(self.c.find_and_report_problems())
573 with open(os.path.join(os.path.dirname(__file__),
574 'git_cl_creds_check_report.txt')) as f:
575 expected = f.read()
576 def by_line(text):
577 return [l.rstrip() for l in text.rstrip().splitlines()]
Robert Iannucci456b0d62018-03-13 19:15:50 -0700578 self.maxDiff = 10000 # pylint: disable=attribute-defined-outside-init
Andrii Shyshkalov4812e612017-03-27 17:22:57 +0200579 self.assertEqual(by_line(sys.stdout.getvalue().strip()), by_line(expected))
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100580
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -0800581
Edward Lemurda4b6c62020-02-13 00:28:40 +0000582class TestGitCl(unittest.TestCase):
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000583 def setUp(self):
584 super(TestGitCl, self).setUp()
585 self.calls = []
tandrii9d206752016-06-20 11:32:47 -0700586 self._calls_done = []
Edward Lemurda4b6c62020-02-13 00:28:40 +0000587 mock.patch('sys.stdout', StringIO()).start()
588 mock.patch(
589 'git_cl.time_time',
590 lambda: self._mocked_call('time.time')).start()
591 mock.patch(
592 'git_cl.metrics.collector.add_repeated',
593 lambda *a: self._mocked_call('add_repeated', *a)).start()
594 mock.patch('subprocess2.call', self._mocked_call).start()
595 mock.patch('subprocess2.check_call', self._mocked_call).start()
596 mock.patch('subprocess2.check_output', self._mocked_call).start()
597 mock.patch(
598 'subprocess2.communicate',
599 lambda *a, **_k: ([self._mocked_call(*a), ''], 0)).start()
600 mock.patch(
601 'git_cl.gclient_utils.CheckCallAndFilter',
602 self._mocked_call).start()
603 mock.patch('git_common.is_dirty_git_tree', lambda x: False).start()
604 mock.patch(
605 'git_common.get_or_create_merge_base',
606 lambda *a: self._mocked_call('get_or_create_merge_base', *a)).start()
607 mock.patch('git_cl.BranchExists', return_value=True).start()
608 mock.patch('git_cl.FindCodereviewSettingsFile', return_value='').start()
609 mock.patch(
610 'git_cl.SaveDescriptionBackup',
611 lambda _: self._mocked_call('SaveDescriptionBackup')).start()
612 mock.patch(
613 'git_cl.ask_for_data',
614 lambda prompt: self._mocked_call('ask_for_data', prompt)).start()
615 mock.patch(
616 'git_cl.write_json',
617 lambda *a: self._mocked_call('write_json', *a)).start()
618 mock.patch(
619 'git_cl.presubmit_support.DoPresubmitChecks', PresubmitMock).start()
620 mock.patch('git_cl.watchlists.Watchlists', WatchlistsMock).start()
621 mock.patch('git_cl.auth.Authenticator', AuthenticatorMock).start()
Edward Lesmes7677e5c2020-02-19 20:39:03 +0000622 mock.patch('gerrit_util.GetChangeDetail').start()
Edward Lemurda4b6c62020-02-13 00:28:40 +0000623 mock.patch(
624 'git_cl.gerrit_util.GetChangeComments',
625 lambda *a: self._mocked_call('GetChangeComments', *a)).start()
626 mock.patch(
627 'git_cl.gerrit_util.GetChangeRobotComments',
628 lambda *a: self._mocked_call('GetChangeRobotComments', *a)).start()
629 mock.patch(
630 'git_cl.gerrit_util.AddReviewers',
631 lambda *a: self._mocked_call('AddReviewers', *a)).start()
632 mock.patch(
633 'git_cl.gerrit_util.SetReview',
634 lambda h, i, msg=None, labels=None, notify=None, ready=None: (
635 self._mocked_call(
636 'SetReview', h, i, msg, labels, notify, ready))).start()
637 mock.patch(
638 'git_cl.gerrit_util.LuciContextAuthenticator.is_luci',
639 return_value=False).start()
640 mock.patch(
641 'git_cl.gerrit_util.GceAuthenticator.is_gce',
642 return_value=False).start()
643 mock.patch(
644 'git_cl.gerrit_util.ValidAccounts',
645 lambda *a: self._mocked_call('ValidAccounts', *a)).start()
Edward Lemurd55c5072020-02-20 01:09:07 +0000646 mock.patch('sys.exit', side_effect=SystemExitMock).start()
Edward Lemur15a9b8c2020-02-13 00:52:30 +0000647 mock.patch('git_cl.Settings.GetRoot', return_value='').start()
Edward Lemur85153282020-02-14 22:06:29 +0000648 self.mockGit = GitMocks()
649 mock.patch('scm.GIT.GetBranchRef', self.mockGit.GetBranchRef).start()
650 mock.patch('scm.GIT.GetConfig', self.mockGit.GetConfig).start()
651 mock.patch('scm.GIT.SetConfig', self.mockGit.SetConfig).start()
Edward Lemur84101642020-02-21 21:40:34 +0000652 mock.patch(
653 'git_new_branch.create_new_branch', self.mockGit.NewBranch).start()
Edward Lemur15a9b8c2020-02-13 00:52:30 +0000654 mock.patch(
Edward Lemur85153282020-02-14 22:06:29 +0000655 'scm.GIT.FetchUpstreamTuple',
Edward Lemur15a9b8c2020-02-13 00:52:30 +0000656 return_value=('origin', 'refs/heads/master')).start()
Edward Lemur85153282020-02-14 22:06:29 +0000657 mock.patch(
658 'scm.GIT.CaptureStatus', return_value=[('M', 'foo.txt')]).start()
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000659 # It's important to reset settings to not have inter-tests interference.
660 git_cl.settings = None
Edward Lemurda4b6c62020-02-13 00:28:40 +0000661 self.addCleanup(mock.patch.stopall)
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000662
663 def tearDown(self):
wychen@chromium.org445c8962015-04-28 23:30:05 +0000664 try:
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +0000665 self.assertEqual([], self.calls)
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100666 except AssertionError:
Edward Lemur85153282020-02-14 22:06:29 +0000667 calls = ''.join(' %s\n' % str(call) for call in self.calls[:5])
668 if len(self.calls) > 5:
669 calls += ' ...\n'
670 self.fail(
671 '\n'
672 'There are un-consumed calls after this test has finished:\n' +
673 calls)
wychen@chromium.org445c8962015-04-28 23:30:05 +0000674 finally:
675 super(TestGitCl, self).tearDown()
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000676
iannucci@chromium.org9e849272014-04-04 00:31:55 +0000677 def _mocked_call(self, *args, **_kwargs):
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000678 self.assertTrue(
679 self.calls,
tandrii9d206752016-06-20 11:32:47 -0700680 '@%d Expected: <Missing> Actual: %r' % (len(self._calls_done), args))
wychen@chromium.orga872e752015-04-28 23:42:18 +0000681 top = self.calls.pop(0)
wychen@chromium.orga872e752015-04-28 23:42:18 +0000682 expected_args, result = top
683
maruel@chromium.orge52678e2013-04-26 18:34:44 +0000684 # Also logs otherwise it could get caught in a try/finally and be hard to
685 # diagnose.
686 if expected_args != args:
tandrii9d206752016-06-20 11:32:47 -0700687 N = 5
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000688 prior_calls = '\n '.join(
tandrii9d206752016-06-20 11:32:47 -0700689 '@%d: %r' % (len(self._calls_done) - N + i, c[0])
690 for i, c in enumerate(self._calls_done[-N:]))
691 following_calls = '\n '.join(
692 '@%d: %r' % (len(self._calls_done) + i + 1, c[0])
693 for i, c in enumerate(self.calls[:N]))
694 extended_msg = (
695 'A few prior calls:\n %s\n\n'
696 'This (expected):\n @%d: %r\n'
697 'This (actual):\n @%d: %r\n\n'
698 'A few following expected calls:\n %s' %
699 (prior_calls, len(self._calls_done), expected_args,
700 len(self._calls_done), args, following_calls))
tandrii9d206752016-06-20 11:32:47 -0700701
tandrii99a72f22016-08-17 14:33:24 -0700702 self.fail('@%d\n'
703 ' Expected: %r\n'
Edward Lemur26964072020-02-19 19:18:51 +0000704 ' Actual: %r\n'
705 '\n'
706 '%s' % (
707 len(self._calls_done), expected_args, args, extended_msg))
tandrii9d206752016-06-20 11:32:47 -0700708
709 self._calls_done.append(top)
tandrii5d48c322016-08-18 16:19:37 -0700710 if isinstance(result, Exception):
711 raise result
Edward Lemur0db01f02019-11-12 22:01:51 +0000712 # stdout from git commands is supposed to be a bytestream. Convert it here
713 # instead of converting all test output in this file to bytes.
714 if args[0][0] == 'git' and not isinstance(result, bytes):
715 result = result.encode('utf-8')
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000716 return result
717
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100718 def test_ask_for_explicit_yes_true(self):
719 self.calls = [
720 (('ask_for_data', 'prompt [Yes/No]: '), 'blah'),
721 (('ask_for_data', 'Please, type yes or no: '), 'ye'),
722 ]
723 self.assertTrue(git_cl.ask_for_explicit_yes('prompt'))
724
tandrii48df5812016-10-17 03:55:37 -0700725 def test_LoadCodereviewSettingsFromFile_gerrit(self):
Edward Lemur79d4f992019-11-11 23:49:02 +0000726 codereview_file = StringIO('GERRIT_HOST: true')
tandrii48df5812016-10-17 03:55:37 -0700727 self.calls = [
728 ((['git', 'config', '--unset-all', 'rietveld.cc'],), CERR1),
tandrii48df5812016-10-17 03:55:37 -0700729 ((['git', 'config', '--unset-all', 'rietveld.tree-status-url'],), CERR1),
730 ((['git', 'config', '--unset-all', 'rietveld.viewvc-url'],), CERR1),
731 ((['git', 'config', '--unset-all', 'rietveld.bug-prefix'],), CERR1),
732 ((['git', 'config', '--unset-all', 'rietveld.cpplint-regex'],), CERR1),
tandrii48df5812016-10-17 03:55:37 -0700733 ((['git', 'config', '--unset-all', 'rietveld.cpplint-ignore-regex'],),
734 CERR1),
tandrii48df5812016-10-17 03:55:37 -0700735 ((['git', 'config', '--unset-all', 'rietveld.run-post-upload-hook'],),
736 CERR1),
Jamie Madilldc4d19e2019-10-24 21:50:02 +0000737 ((['git', 'config', '--unset-all', 'rietveld.format-full-by-default'],),
738 CERR1),
tandrii48df5812016-10-17 03:55:37 -0700739 ((['git', 'config', 'gerrit.host', 'true'],), ''),
740 ]
741 self.assertIsNone(git_cl.LoadCodereviewSettingsFromFile(codereview_file))
742
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000743 @classmethod
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100744 def _gerrit_base_calls(cls, issue=None, fetched_description=None,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200745 fetched_status=None, other_cl_owner=None,
Anthony Polito8b955342019-09-24 19:01:36 +0000746 custom_cl_base=None, short_hostname='chromium',
747 change_id=None):
Edward Lemur26964072020-02-19 19:18:51 +0000748 calls = []
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200749 if custom_cl_base:
750 ancestor_revision = custom_cl_base
751 else:
752 # Determine ancestor_revision to be merge base.
753 ancestor_revision = 'fake_ancestor_sha'
754 calls += [
Edward Lemurda4b6c62020-02-13 00:28:40 +0000755 (('get_or_create_merge_base', 'master', 'refs/remotes/origin/master'),
756 ancestor_revision),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200757 ]
758
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100759 if issue:
Edward Lesmes7677e5c2020-02-19 20:39:03 +0000760 gerrit_util.GetChangeDetail.return_value = {
761 'owner': {'email': (other_cl_owner or 'owner@example.com')},
762 'change_id': (change_id or '123456789'),
763 'current_revision': 'sha1_of_current_revision',
764 'revisions': {'sha1_of_current_revision': {
765 'commit': {'message': fetched_description},
766 }},
767 'status': fetched_status or 'NEW',
768 }
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100769 if fetched_status == 'ABANDONED':
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100770 return calls
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100771 if other_cl_owner:
772 calls += [
773 (('ask_for_data', 'Press Enter to upload, or Ctrl+C to abort'), ''),
774 ]
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100775
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100776 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200777 ((['git', 'rev-parse', 'HEAD'],), '12345'),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100778 ]
779
780 if not issue:
781 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200782 ((['git', 'log', '--pretty=format:%s%n%n%b',
783 ancestor_revision + '...'],),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000784 'foo'),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100785 ]
786
787 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200788 ((['git', 'config', 'user.email'],), 'me@example.com'),
Edward Lemur2c48f242019-06-04 16:14:09 +0000789 (('time.time',), 1000,),
790 (('time.time',), 3000,),
791 (('add_repeated', 'sub_commands', {
792 'execution_time': 2000,
793 'command': 'presubmit',
794 'exit_code': 0
795 }), None,),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200796 ((['git', 'diff', '--no-ext-diff', '--stat', '-l100000', '-C50'] +
797 ([custom_cl_base] if custom_cl_base else
798 [ancestor_revision, 'HEAD']),),
799 '+dat'),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100800 ]
801 return calls
ukai@chromium.orge8077812012-02-03 03:41:46 +0000802
Edward Lemur26964072020-02-19 19:18:51 +0000803 def _gerrit_upload_calls(self, description, reviewers, squash,
tandriia60502f2016-06-20 02:01:53 -0700804 squash_mode='default',
tandrii@chromium.org10625002016-03-04 20:03:47 +0000805 expected_upstream_ref='origin/refs/heads/master',
Aaron Gablefd238082017-06-07 13:42:34 -0700806 title=None, notify=False,
Andrii Shyshkalove9c78ff2017-02-06 15:53:13 +0100807 post_amend_description=None, issue=None, cc=None,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000808 custom_cl_base=None, tbr=None,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +0000809 short_hostname='chromium',
Edward Lemur1b52d872019-05-09 21:12:12 +0000810 labels=None, change_id=None, original_title=None,
Anthony Polito8b955342019-09-24 19:01:36 +0000811 final_description=None, gitcookies_exists=True,
Josipe827b0f2020-01-30 00:07:20 +0000812 force=False, edit_description=None):
tandrii@chromium.org10625002016-03-04 20:03:47 +0000813 if post_amend_description is None:
814 post_amend_description = description
bradnelsond975b302016-10-23 12:20:23 -0700815 cc = cc or []
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200816 # Determined in `_gerrit_base_calls`.
817 determined_ancestor_revision = custom_cl_base or 'fake_ancestor_sha'
818
819 calls = []
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000820
Edward Lemur26964072020-02-19 19:18:51 +0000821 if squash_mode in ('override_squash', 'override_nosquash'):
822 self.mockGit.config['gerrit.override-squash-uploads'] = (
823 'true' if squash_mode == 'override_squash' else 'false')
tandriia60502f2016-06-20 02:01:53 -0700824
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000825 # If issue is given, then description is fetched from Gerrit instead.
826 if issue is None:
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000827 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200828 ((['git', 'log', '--pretty=format:%s\n\n%b',
829 ((custom_cl_base + '..') if custom_cl_base else
830 'fake_ancestor_sha..HEAD')],),
831 description),
832 ]
Aaron Gableb56ad332017-01-06 15:24:31 -0800833 if squash:
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +0000834 title = 'Initial_upload'
Aaron Gableb56ad332017-01-06 15:24:31 -0800835 else:
836 if not title:
837 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200838 ((['git', 'show', '-s', '--format=%s', 'HEAD'],), ''),
839 (('ask_for_data', 'Title for patchset []: '), 'User input'),
Aaron Gableb56ad332017-01-06 15:24:31 -0800840 ]
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +0000841 title = 'User_input'
tandrii@chromium.org57d86542016-03-04 16:11:32 +0000842 if not git_footers.get_footer_change_id(description) and not squash:
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +0000843 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200844 (('DownloadGerritHook', False), ''),
845 # Amending of commit message to get the Change-Id.
846 ((['git', 'log', '--pretty=format:%s\n\n%b',
847 determined_ancestor_revision + '..HEAD'],),
848 description),
849 ((['git', 'commit', '--amend', '-m', description],), ''),
850 ((['git', 'log', '--pretty=format:%s\n\n%b',
851 determined_ancestor_revision + '..HEAD'],),
852 post_amend_description)
853 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000854 if squash:
Anthony Polito8b955342019-09-24 19:01:36 +0000855 if force or not issue:
Anthony Polito8b955342019-09-24 19:01:36 +0000856 if not force:
857 calls += [
Anthony Polito8b955342019-09-24 19:01:36 +0000858 ((['RunEditor'],), description),
859 ]
Josipe827b0f2020-01-30 00:07:20 +0000860 # user wants to edit description
861 if edit_description:
862 calls += [
Josipe827b0f2020-01-30 00:07:20 +0000863 ((['RunEditor'],), edit_description),
864 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000865 ref_to_push = 'abcdef0123456789'
866 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200867 ]
868
869 if custom_cl_base is None:
870 calls += [
Edward Lemurda4b6c62020-02-13 00:28:40 +0000871 (('get_or_create_merge_base', 'master', 'refs/remotes/origin/master'),
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000872 'origin/master'),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200873 ]
874 parent = 'origin/master'
875 else:
876 calls += [
877 ((['git', 'merge-base', '--is-ancestor', custom_cl_base,
878 'refs/remotes/origin/master'],),
879 callError(1)), # Means not ancenstor.
880 (('ask_for_data',
881 'Do you take responsibility for cleaning up potential mess '
882 'resulting from proceeding with upload? Press Enter to upload, '
883 'or Ctrl+C to abort'), ''),
884 ]
885 parent = custom_cl_base
886
887 calls += [
888 ((['git', 'rev-parse', 'HEAD:'],), # `HEAD:` means HEAD's tree hash.
889 '0123456789abcdef'),
Edward Lemur1773f372020-02-22 00:27:14 +0000890 ((['FileWrite', '/tmp/fake-temp1', description],), None),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200891 ((['git', 'commit-tree', '0123456789abcdef', '-p', parent,
Edward Lemur1773f372020-02-22 00:27:14 +0000892 '-F', '/tmp/fake-temp1'],),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200893 ref_to_push),
894 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000895 else:
896 ref_to_push = 'HEAD'
897
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +0000898 calls += [
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000899 (('SaveDescriptionBackup',), None),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200900 ((['git', 'rev-list',
901 (custom_cl_base if custom_cl_base else expected_upstream_ref) + '..' +
902 ref_to_push],),
903 '1hashPerLine\n'),
904 ]
tandrii@chromium.org8da45402016-05-24 23:11:03 +0000905
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000906 metrics_arguments = []
907
Aaron Gableafd52772017-06-27 16:40:10 -0700908 if notify:
Aaron Gable844cf292017-06-28 11:32:59 -0700909 ref_suffix = '%ready,notify=ALL'
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000910 metrics_arguments += ['ready', 'notify=ALL']
Aaron Gable844cf292017-06-28 11:32:59 -0700911 else:
Jamie Madill276da0b2018-04-27 14:41:20 -0400912 if not issue and squash:
Aaron Gable844cf292017-06-28 11:32:59 -0700913 ref_suffix = '%wip'
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000914 metrics_arguments.append('wip')
Aaron Gable844cf292017-06-28 11:32:59 -0700915 else:
916 ref_suffix = '%notify=NONE'
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000917 metrics_arguments.append('notify=NONE')
Aaron Gable9b713dd2016-12-14 16:04:21 -0800918
Aaron Gable70f4e242017-06-26 10:45:59 -0700919 if title:
Aaron Gableafd52772017-06-27 16:40:10 -0700920 ref_suffix += ',m=' + title
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000921 metrics_arguments.append('m')
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +0000922
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000923 if short_hostname == 'chromium':
924 # All reviwers and ccs get into ref_suffix.
925 for r in sorted(reviewers):
926 ref_suffix += ',r=%s' % r
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000927 metrics_arguments.append('r')
Edward Lemur4508b422019-10-03 21:56:35 +0000928 if issue is None:
929 cc += ['chromium-reviews+test-more-cc@chromium.org', 'joe@example.com']
930 for c in sorted(cc):
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000931 ref_suffix += ',cc=%s' % c
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000932 metrics_arguments.append('cc')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000933 reviewers, cc = [], []
934 else:
935 # TODO(crbug/877717): remove this case.
936 calls += [
937 (('ValidAccounts', '%s-review.googlesource.com' % short_hostname,
938 sorted(reviewers) + ['joe@example.com',
939 'chromium-reviews+test-more-cc@chromium.org'] + cc),
940 {
941 e: {'email': e}
942 for e in (reviewers + ['joe@example.com'] + cc)
943 })
944 ]
945 for r in sorted(reviewers):
946 if r != 'bad-account-or-email':
947 ref_suffix += ',r=%s' % r
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000948 metrics_arguments.append('r')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000949 reviewers.remove(r)
Edward Lemur4508b422019-10-03 21:56:35 +0000950 if issue is None:
951 cc += ['joe@example.com']
952 for c in sorted(cc):
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000953 ref_suffix += ',cc=%s' % c
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000954 metrics_arguments.append('cc')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000955 if c in cc:
956 cc.remove(c)
Andrii Shyshkalov76988a82018-10-15 03:12:25 +0000957
Edward Lemur687ca902018-12-05 02:30:30 +0000958 for k, v in sorted((labels or {}).items()):
959 ref_suffix += ',l=%s+%d' % (k, v)
960 metrics_arguments.append('l=%s+%d' % (k, v))
961
962 if tbr:
963 calls += [
964 (('GetCodeReviewTbrScore',
965 '%s-review.googlesource.com' % short_hostname,
966 'my/repo'),
967 2,),
968 ]
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +0000969
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000970 calls += [
971 (('time.time',), 1000,),
972 ((['git', 'push',
973 'https://%s.googlesource.com/my/repo' % short_hostname,
974 ref_to_push + ':refs/for/refs/heads/master' + ref_suffix],),
975 (('remote:\n'
976 'remote: Processing changes: (\)\n'
977 'remote: Processing changes: (|)\n'
978 'remote: Processing changes: (/)\n'
979 'remote: Processing changes: (-)\n'
980 'remote: Processing changes: new: 1 (/)\n'
981 'remote: Processing changes: new: 1, done\n'
982 'remote:\n'
983 'remote: New Changes:\n'
984 'remote: https://%s-review.googlesource.com/#/c/my/repo/+/123456'
985 ' XXX\n'
986 'remote:\n'
987 'To https://%s.googlesource.com/my/repo\n'
988 ' * [new branch] hhhh -> refs/for/refs/heads/master\n'
989 ) % (short_hostname, short_hostname)),),
990 (('time.time',), 2000,),
991 (('add_repeated',
992 'sub_commands',
993 {
994 'execution_time': 1000,
995 'command': 'git push',
996 'exit_code': 0,
997 'arguments': sorted(metrics_arguments),
998 }),
999 None,),
1000 ]
1001
Edward Lemur1b52d872019-05-09 21:12:12 +00001002 final_description = final_description or post_amend_description.strip()
1003 original_title = original_title or title or '<untitled>'
1004 # Trace-related calls
1005 calls += [
1006 # Write a description with context for the current trace.
1007 ((['FileWrite', 'TRACES_DIR/20170316T200041.000000-README',
Edward Lemur75391d42019-05-14 23:35:56 +00001008 'Thu Mar 16 20:00:41 2017\n'
1009 '%(short_hostname)s-review.googlesource.com\n'
1010 '%(change_id)s\n'
1011 '%(title)s\n'
1012 '%(description)s\n'
1013 '1000\n'
1014 '0\n'
1015 '%(trace_name)s' % {
Edward Lemur1b52d872019-05-09 21:12:12 +00001016 'short_hostname': short_hostname,
1017 'change_id': change_id,
1018 'description': final_description,
1019 'title': original_title,
Edward Lemur75391d42019-05-14 23:35:56 +00001020 'trace_name': 'TRACES_DIR/20170316T200041.000000',
Edward Lemur1b52d872019-05-09 21:12:12 +00001021 }],),
1022 None,
1023 ),
1024 # Read traces and shorten git hashes.
1025 ((['os.path.isfile', 'TEMP_DIR/trace-packet'],),
1026 True,
1027 ),
1028 ((['FileRead', 'TEMP_DIR/trace-packet'],),
1029 ('git-hash: 0123456789012345678901234567890123456789\n'
1030 'git-hash: abcdeabcdeabcdeabcdeabcdeabcdeabcdeabcde\n'),
1031 ),
1032 ((['FileWrite', 'TEMP_DIR/trace-packet',
1033 'git-hash: 012345\n'
1034 'git-hash: abcdea\n'],),
1035 None,
1036 ),
1037 # Make zip file for the git traces.
1038 ((['make_archive', 'TRACES_DIR/20170316T200041.000000-traces', 'zip',
1039 'TEMP_DIR'],),
1040 None,
1041 ),
1042 # Collect git config and gitcookies.
1043 ((['git', 'config', '-l'],),
1044 'git-config-output',
1045 ),
1046 ((['FileWrite', 'TEMP_DIR/git-config', 'git-config-output'],),
1047 None,
1048 ),
1049 ((['os.path.isfile', '~/.gitcookies'],),
1050 gitcookies_exists,
1051 ),
1052 ]
1053 if gitcookies_exists:
1054 calls += [
1055 ((['FileRead', '~/.gitcookies'],),
1056 'gitcookies 1/SECRET',
1057 ),
1058 ((['FileWrite', 'TEMP_DIR/gitcookies', 'gitcookies REDACTED'],),
1059 None,
1060 ),
1061 ]
1062 calls += [
1063 # Make zip file for the git config and gitcookies.
1064 ((['make_archive', 'TRACES_DIR/20170316T200041.000000-git-info', 'zip',
1065 'TEMP_DIR'],),
1066 None,
1067 ),
1068 ]
1069
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001070 # TODO(crbug/877717): this should never be used.
1071 if squash and short_hostname != 'chromium':
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001072 calls += [
1073 (('AddReviewers',
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00001074 'chromium-review.googlesource.com', 'my%2Frepo~123456',
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001075 sorted(reviewers),
Andrii Shyshkalov2f727912018-10-15 17:02:33 +00001076 cc + ['chromium-reviews+test-more-cc@chromium.org'],
1077 notify),
1078 ''),
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001079 ]
Edward Lemur26964072020-02-19 19:18:51 +00001080 calls += [
1081 ((['git', 'rev-parse', 'HEAD'],), 'hash'),
1082 ]
ukai@chromium.orge8077812012-02-03 03:41:46 +00001083 return calls
1084
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001085 def _run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001086 self,
1087 upload_args,
1088 description,
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00001089 reviewers=None,
tandriia60502f2016-06-20 02:01:53 -07001090 squash=True,
1091 squash_mode=None,
tandrii@chromium.org10625002016-03-04 20:03:47 +00001092 expected_upstream_ref='origin/refs/heads/master',
Aaron Gable9b713dd2016-12-14 16:04:21 -08001093 title=None,
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001094 notify=False,
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001095 post_amend_description=None,
bradnelsond975b302016-10-23 12:20:23 -07001096 issue=None,
Andrii Shyshkalove9c78ff2017-02-06 15:53:13 +01001097 cc=None,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001098 fetched_status=None,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001099 other_cl_owner=None,
Aaron Gablefd238082017-06-07 13:42:34 -07001100 custom_cl_base=None,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001101 tbr=None,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001102 short_hostname='chromium',
Edward Lemur1b52d872019-05-09 21:12:12 +00001103 labels=None,
1104 change_id=None,
1105 original_title=None,
1106 final_description=None,
Anthony Polito8b955342019-09-24 19:01:36 +00001107 gitcookies_exists=True,
1108 force=False,
Josipe827b0f2020-01-30 00:07:20 +00001109 edit_description=None,
Anthony Polito8b955342019-09-24 19:01:36 +00001110 fetched_description=None):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001111 """Generic gerrit upload test framework."""
tandriia60502f2016-06-20 02:01:53 -07001112 if squash_mode is None:
1113 if '--no-squash' in upload_args:
1114 squash_mode = 'nosquash'
1115 elif '--squash' in upload_args:
1116 squash_mode = 'squash'
1117 else:
1118 squash_mode = 'default'
1119
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00001120 reviewers = reviewers or []
bradnelsond975b302016-10-23 12:20:23 -07001121 cc = cc or []
Edward Lemurda4b6c62020-02-13 00:28:40 +00001122 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001123 CookiesAuthenticatorMockFactory(
Edward Lemurda4b6c62020-02-13 00:28:40 +00001124 same_auth=('git-owner.example.com', '', 'pass'))).start()
1125 mock.patch('git_cl.Changelist._GerritCommitMsgHookCheck',
1126 lambda _, offer_removal: None).start()
1127 mock.patch('git_cl.gclient_utils.RunEditor',
1128 lambda *_, **__: self._mocked_call(['RunEditor'])).start()
1129 mock.patch('git_cl.DownloadGerritHook', lambda force: self._mocked_call(
1130 'DownloadGerritHook', force)).start()
1131 mock.patch('git_cl.gclient_utils.FileRead',
1132 lambda path: self._mocked_call(['FileRead', path])).start()
1133 mock.patch('git_cl.gclient_utils.FileWrite',
Edward Lemur1b52d872019-05-09 21:12:12 +00001134 lambda path, contents: self._mocked_call(
Edward Lemurda4b6c62020-02-13 00:28:40 +00001135 ['FileWrite', path, contents])).start()
1136 mock.patch('git_cl.datetime_now',
1137 lambda: datetime.datetime(2017, 3, 16, 20, 0, 41, 0)).start()
1138 mock.patch('git_cl.tempfile.mkdtemp', lambda: 'TEMP_DIR').start()
1139 mock.patch('git_cl.TRACES_DIR', 'TRACES_DIR').start()
1140 mock.patch('git_cl.TRACES_README_FORMAT',
Edward Lemur75391d42019-05-14 23:35:56 +00001141 '%(now)s\n'
1142 '%(gerrit_host)s\n'
1143 '%(change_id)s\n'
1144 '%(title)s\n'
1145 '%(description)s\n'
1146 '%(execution_time)s\n'
1147 '%(exit_code)s\n'
Edward Lemurda4b6c62020-02-13 00:28:40 +00001148 '%(trace_name)s').start()
1149 mock.patch('git_cl.shutil.make_archive',
1150 lambda *args: self._mocked_call(['make_archive'] +
1151 list(args))).start()
1152 mock.patch('os.path.isfile',
1153 lambda path: self._mocked_call(['os.path.isfile', path])).start()
Edward Lemurd55c5072020-02-20 01:09:07 +00001154 mock.patch('git_cl.Changelist.GitSanityChecks', return_value=True).start()
tandriia60502f2016-06-20 02:01:53 -07001155
Edward Lemur26964072020-02-19 19:18:51 +00001156 self.mockGit.config['gerrit.host'] = 'true'
Edward Lemur85153282020-02-14 22:06:29 +00001157 self.mockGit.config['branch.master.gerritissue'] = (
1158 str(issue) if issue else None)
1159 self.mockGit.config['remote.origin.url'] = (
1160 'https://%s.googlesource.com/my/repo' % short_hostname)
1161
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001162 self.calls = self._gerrit_base_calls(
1163 issue=issue,
Anthony Polito8b955342019-09-24 19:01:36 +00001164 fetched_description=fetched_description or description,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001165 fetched_status=fetched_status,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001166 other_cl_owner=other_cl_owner,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001167 custom_cl_base=custom_cl_base,
Anthony Polito8b955342019-09-24 19:01:36 +00001168 short_hostname=short_hostname,
1169 change_id=change_id)
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001170 if fetched_status != 'ABANDONED':
Edward Lemurda4b6c62020-02-13 00:28:40 +00001171 mock.patch(
Edward Lemur1773f372020-02-22 00:27:14 +00001172 'gclient_utils.temporary_file', TemporaryFileMock()).start()
Edward Lemurda4b6c62020-02-13 00:28:40 +00001173 mock.patch('os.remove', return_value=True).start()
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001174 self.calls += self._gerrit_upload_calls(
1175 description, reviewers, squash,
1176 squash_mode=squash_mode,
1177 expected_upstream_ref=expected_upstream_ref,
Aaron Gablefd238082017-06-07 13:42:34 -07001178 title=title, notify=notify,
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001179 post_amend_description=post_amend_description,
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00001180 issue=issue, cc=cc,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001181 custom_cl_base=custom_cl_base, tbr=tbr,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001182 short_hostname=short_hostname,
Edward Lemur1b52d872019-05-09 21:12:12 +00001183 labels=labels,
1184 change_id=change_id,
1185 original_title=original_title,
1186 final_description=final_description,
Anthony Polito8b955342019-09-24 19:01:36 +00001187 gitcookies_exists=gitcookies_exists,
Josipe827b0f2020-01-30 00:07:20 +00001188 force=force,
1189 edit_description=edit_description)
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +00001190 # Uncomment when debugging.
Raul Tambre80ee78e2019-05-06 22:41:05 +00001191 # print('\n'.join(map(lambda x: '%2i: %s' % x, enumerate(self.calls))))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001192 git_cl.main(['upload'] + upload_args)
Edward Lemur85153282020-02-14 22:06:29 +00001193 if squash:
Edward Lemur26964072020-02-19 19:18:51 +00001194 self.assertIssueAndPatchset(patchset=None)
Edward Lemur85153282020-02-14 22:06:29 +00001195 self.assertEqual(
1196 'abcdef0123456789',
Edward Lemur26964072020-02-19 19:18:51 +00001197 scm.GIT.GetBranchConfig('', 'master', 'gerritsquashhash'))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001198
Edward Lemur1b52d872019-05-09 21:12:12 +00001199 def test_gerrit_upload_traces_no_gitcookies(self):
1200 self._run_gerrit_upload_test(
1201 ['--no-squash'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001202 'desc ✔\n\nBUG=\n',
Edward Lemur1b52d872019-05-09 21:12:12 +00001203 [],
1204 squash=False,
Edward Lemur0db01f02019-11-12 22:01:51 +00001205 post_amend_description='desc ✔\n\nBUG=\n\nChange-Id: Ixxx',
Edward Lemur1b52d872019-05-09 21:12:12 +00001206 change_id='Ixxx',
1207 gitcookies_exists=False)
1208
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001209 def test_gerrit_upload_without_change_id(self):
tandriia60502f2016-06-20 02:01:53 -07001210 self._run_gerrit_upload_test(
1211 ['--no-squash'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001212 'desc ✔\n\nBUG=\n',
tandriia60502f2016-06-20 02:01:53 -07001213 [],
1214 squash=False,
Edward Lemur0db01f02019-11-12 22:01:51 +00001215 post_amend_description='desc ✔\n\nBUG=\n\nChange-Id: Ixxx',
Edward Lemur1b52d872019-05-09 21:12:12 +00001216 change_id='Ixxx')
tandriia60502f2016-06-20 02:01:53 -07001217
1218 def test_gerrit_upload_without_change_id_override_nosquash(self):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001219 self._run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001220 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001221 'desc ✔\n\nBUG=\n',
tandrii@chromium.org10625002016-03-04 20:03:47 +00001222 [],
tandriia60502f2016-06-20 02:01:53 -07001223 squash=False,
1224 squash_mode='override_nosquash',
Edward Lemur0db01f02019-11-12 22:01:51 +00001225 post_amend_description='desc ✔\n\nBUG=\n\nChange-Id: Ixxx',
Edward Lemur1b52d872019-05-09 21:12:12 +00001226 change_id='Ixxx')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001227
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001228 def test_gerrit_no_reviewer(self):
1229 self._run_gerrit_upload_test(
1230 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001231 'desc ✔\n\nBUG=\n\nChange-Id: I123456789\n',
tandriia60502f2016-06-20 02:01:53 -07001232 [],
1233 squash=False,
Edward Lemur1b52d872019-05-09 21:12:12 +00001234 squash_mode='override_nosquash',
1235 change_id='I123456789')
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001236
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001237 def test_gerrit_no_reviewer_non_chromium_host(self):
1238 # TODO(crbug/877717): remove this test case.
1239 self._run_gerrit_upload_test(
1240 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001241 'desc ✔\n\nBUG=\n\nChange-Id: I123456789\n',
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001242 [],
1243 squash=False,
1244 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001245 short_hostname='other',
1246 change_id='I123456789')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001247
Nick Carter8692b182017-11-06 16:30:38 -08001248 def test_gerrit_patchset_title_special_chars(self):
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001249 self._run_gerrit_upload_test(
Nick Carter8692b182017-11-06 16:30:38 -08001250 ['-f', '-t', 'We\'ll escape ^_ ^ special chars...@{u}'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001251 'desc ✔\n\nBUG=\n\nChange-Id: I123456789',
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001252 squash=False,
1253 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001254 title='We%27ll_escape_%5E%5F_%5E_special_chars%2E%2E%2E%40%7Bu%7D',
1255 change_id='I123456789',
1256 original_title='We\'ll escape ^_ ^ special chars...@{u}')
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001257
ukai@chromium.orge8077812012-02-03 03:41:46 +00001258 def test_gerrit_reviewers_cmd_line(self):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001259 self._run_gerrit_upload_test(
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001260 ['-r', 'foo@example.com', '--send-mail'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001261 'desc ✔\n\nBUG=\n\nChange-Id: I123456789',
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001262 ['foo@example.com'],
tandriia60502f2016-06-20 02:01:53 -07001263 squash=False,
1264 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001265 notify=True,
1266 change_id='I123456789',
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001267 final_description=(
Edward Lemur0db01f02019-11-12 22:01:51 +00001268 'desc ✔\n\nBUG=\nR=foo@example.com\n\nChange-Id: I123456789'))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001269
Anthony Polito8b955342019-09-24 19:01:36 +00001270 def test_gerrit_upload_force_sets_bug(self):
1271 self._run_gerrit_upload_test(
1272 ['-b', '10000', '-f'],
1273 u'desc=\n\nBug: 10000\nChange-Id: Ixxx',
1274 [],
1275 force=True,
1276 expected_upstream_ref='origin/master',
1277 fetched_description='desc=\n\nChange-Id: Ixxx',
1278 original_title='Initial upload',
1279 change_id='Ixxx')
1280
1281 def test_gerrit_upload_force_sets_bug_if_wrong_changeid(self):
1282 self._run_gerrit_upload_test(
1283 ['-b', '10000', '-f', '-m', 'Title'],
1284 u'desc=\n\nChange-Id: Ixxxx\n\nChange-Id: Izzzz\nBug: 10000',
1285 [],
1286 force=True,
1287 issue='123456',
1288 expected_upstream_ref='origin/master',
1289 fetched_description='desc=\n\nChange-Id: Ixxxx',
1290 original_title='Title',
1291 title='Title',
1292 change_id='Izzzz')
1293
Dan Beamd8b04ca2019-10-10 21:23:26 +00001294 def test_gerrit_upload_force_sets_fixed(self):
1295 self._run_gerrit_upload_test(
1296 ['-x', '10000', '-f'],
1297 u'desc=\n\nFixed: 10000\nChange-Id: Ixxx',
1298 [],
1299 force=True,
1300 expected_upstream_ref='origin/master',
1301 fetched_description='desc=\n\nChange-Id: Ixxx',
1302 original_title='Initial upload',
1303 change_id='Ixxx')
1304
ukai@chromium.orge8077812012-02-03 03:41:46 +00001305 def test_gerrit_reviewer_multiple(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00001306 mock.patch('git_cl.gerrit_util.GetCodeReviewTbrScore',
1307 lambda *a: self._mocked_call('GetCodeReviewTbrScore', *a)).start()
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001308 self._run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001309 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001310 'desc ✔\nTBR=reviewer@example.com\nBUG=\nR=another@example.com\n'
bradnelsond975b302016-10-23 12:20:23 -07001311 'CC=more@example.com,people@example.com\n\n'
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +09001312 'Change-Id: 123456789',
tandriia60502f2016-06-20 02:01:53 -07001313 ['reviewer@example.com', 'another@example.com'],
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +09001314 expected_upstream_ref='origin/master',
Aaron Gablefd238082017-06-07 13:42:34 -07001315 cc=['more@example.com', 'people@example.com'],
Edward Lemur687ca902018-12-05 02:30:30 +00001316 tbr='reviewer@example.com',
Edward Lemur1b52d872019-05-09 21:12:12 +00001317 labels={'Code-Review': 2},
1318 change_id='123456789',
1319 original_title='Initial upload')
tandriia60502f2016-06-20 02:01:53 -07001320
1321 def test_gerrit_upload_squash_first_is_default(self):
tandriia60502f2016-06-20 02:01:53 -07001322 self._run_gerrit_upload_test(
1323 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001324 'desc ✔\nBUG=\n\nChange-Id: 123456789',
tandriia60502f2016-06-20 02:01:53 -07001325 [],
Edward Lemur1b52d872019-05-09 21:12:12 +00001326 expected_upstream_ref='origin/master',
1327 change_id='123456789',
1328 original_title='Initial upload')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001329
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001330 def test_gerrit_upload_squash_first(self):
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001331 self._run_gerrit_upload_test(
1332 ['--squash'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001333 'desc ✔\nBUG=\n\nChange-Id: 123456789',
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001334 [],
luqui@chromium.org609f3952015-05-04 22:47:04 +00001335 squash=True,
Edward Lemur1b52d872019-05-09 21:12:12 +00001336 expected_upstream_ref='origin/master',
1337 change_id='123456789',
1338 original_title='Initial upload')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001339
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001340 def test_gerrit_upload_squash_first_with_labels(self):
1341 self._run_gerrit_upload_test(
1342 ['--squash', '--cq-dry-run', '--enable-auto-submit'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001343 'desc ✔\nBUG=\n\nChange-Id: 123456789',
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001344 [],
1345 squash=True,
1346 expected_upstream_ref='origin/master',
Edward Lemur1b52d872019-05-09 21:12:12 +00001347 labels={'Commit-Queue': 1, 'Auto-Submit': 1},
1348 change_id='123456789',
1349 original_title='Initial upload')
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001350
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001351 def test_gerrit_upload_squash_first_against_rev(self):
1352 custom_cl_base = 'custom_cl_base_rev_or_branch'
1353 self._run_gerrit_upload_test(
1354 ['--squash', custom_cl_base],
Edward Lemur0db01f02019-11-12 22:01:51 +00001355 'desc ✔\nBUG=\n\nChange-Id: 123456789',
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001356 [],
1357 squash=True,
1358 expected_upstream_ref='origin/master',
Edward Lemur1b52d872019-05-09 21:12:12 +00001359 custom_cl_base=custom_cl_base,
1360 change_id='123456789',
1361 original_title='Initial upload')
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001362 self.assertIn(
1363 'If you proceed with upload, more than 1 CL may be created by Gerrit',
1364 sys.stdout.getvalue())
1365
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001366 def test_gerrit_upload_squash_reupload(self):
Edward Lemur0db01f02019-11-12 22:01:51 +00001367 description = 'desc ✔\nBUG=\n\nChange-Id: 123456789'
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001368 self._run_gerrit_upload_test(
1369 ['--squash'],
1370 description,
1371 [],
1372 squash=True,
1373 expected_upstream_ref='origin/master',
Edward Lemur1b52d872019-05-09 21:12:12 +00001374 issue=123456,
1375 change_id='123456789',
1376 original_title='User input')
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001377
Edward Lemurd55c5072020-02-20 01:09:07 +00001378 @mock.patch('sys.stderr', StringIO())
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001379 def test_gerrit_upload_squash_reupload_to_abandoned(self):
Edward Lemur0db01f02019-11-12 22:01:51 +00001380 description = 'desc ✔\nBUG=\n\nChange-Id: 123456789'
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001381 with self.assertRaises(SystemExitMock):
1382 self._run_gerrit_upload_test(
1383 ['--squash'],
1384 description,
1385 [],
1386 squash=True,
1387 expected_upstream_ref='origin/master',
1388 issue=123456,
Edward Lemur1b52d872019-05-09 21:12:12 +00001389 fetched_status='ABANDONED',
1390 change_id='123456789')
Edward Lemurd55c5072020-02-20 01:09:07 +00001391 self.assertEqual(
1392 'Change https://chromium-review.googlesource.com/123456 has been '
1393 'abandoned, new uploads are not allowed\n',
1394 sys.stderr.getvalue())
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001395
Edward Lemurda4b6c62020-02-13 00:28:40 +00001396 @mock.patch(
1397 'gerrit_util.GetAccountDetails',
1398 return_value={'email': 'yet-another@example.com'})
1399 def test_gerrit_upload_squash_reupload_to_not_owned(self, _mock):
Edward Lemur0db01f02019-11-12 22:01:51 +00001400 description = 'desc ✔\nBUG=\n\nChange-Id: 123456789'
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001401 self._run_gerrit_upload_test(
1402 ['--squash'],
1403 description,
1404 [],
1405 squash=True,
1406 expected_upstream_ref='origin/master',
1407 issue=123456,
Edward Lemur1b52d872019-05-09 21:12:12 +00001408 other_cl_owner='other@example.com',
1409 change_id='123456789',
1410 original_title='User input')
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001411 self.assertIn(
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001412 'WARNING: Change 123456 is owned by other@example.com, but you '
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001413 'authenticate to Gerrit as yet-another@example.com.\n'
1414 'Uploading may fail due to lack of permissions',
Edward Lemurda4b6c62020-02-13 00:28:40 +00001415 sys.stdout.getvalue())
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001416
Josipe827b0f2020-01-30 00:07:20 +00001417 def test_upload_change_description_editor(self):
1418 fetched_description = 'foo\n\nChange-Id: 123456789'
1419 description = 'bar\n\nChange-Id: 123456789'
1420 self._run_gerrit_upload_test(
1421 ['--squash', '--edit-description'],
1422 description,
1423 [],
1424 fetched_description=fetched_description,
1425 squash=True,
1426 expected_upstream_ref='origin/master',
1427 issue=123456,
1428 change_id='123456789',
1429 original_title='User input',
1430 edit_description=description)
1431
Edward Lemurda4b6c62020-02-13 00:28:40 +00001432 @mock.patch('git_cl.RunGit')
1433 @mock.patch('git_cl.CMDupload')
1434 @mock.patch('git_cl.ask_for_data')
1435 def test_upload_branch_deps(self, *_mocks):
rmistry@google.com2dd99862015-06-22 12:22:18 +00001436 def mock_run_git(*args, **_kwargs):
1437 if args[0] == ['for-each-ref',
1438 '--format=%(refname:short) %(upstream:short)',
1439 'refs/heads']:
1440 # Create a local branch dependency tree that looks like this:
1441 # test1 -> test2 -> test3 -> test4 -> test5
1442 # -> test3.1
1443 # test6 -> test0
1444 branch_deps = [
1445 'test2 test1', # test1 -> test2
1446 'test3 test2', # test2 -> test3
1447 'test3.1 test2', # test2 -> test3.1
1448 'test4 test3', # test3 -> test4
1449 'test5 test4', # test4 -> test5
1450 'test6 test0', # test0 -> test6
1451 'test7', # test7
1452 ]
1453 return '\n'.join(branch_deps)
Edward Lemurda4b6c62020-02-13 00:28:40 +00001454 git_cl.RunGit.side_effect = mock_run_git
1455 git_cl.CMDupload.return_value = 0
rmistry@google.com2dd99862015-06-22 12:22:18 +00001456
1457 class MockChangelist():
1458 def __init__(self):
1459 pass
1460 def GetBranch(self):
1461 return 'test1'
1462 def GetIssue(self):
1463 return '123'
1464 def GetPatchset(self):
1465 return '1001'
tandrii@chromium.org4c72b082016-03-31 22:26:35 +00001466 def IsGerrit(self):
1467 return False
rmistry@google.com2dd99862015-06-22 12:22:18 +00001468
1469 ret = git_cl.upload_branch_deps(MockChangelist(), [])
1470 # CMDupload should have been called 5 times because of 5 dependent branches.
Edward Lemurda4b6c62020-02-13 00:28:40 +00001471 self.assertEqual(5, len(git_cl.CMDupload.mock_calls))
1472 git_cl.ask_for_data.assert_called_once_with(
1473 'This command will checkout all dependent branches '
1474 'and run "git cl upload". Press Enter to continue, '
1475 'or Ctrl+C to abort')
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00001476 self.assertEqual(0, ret)
rmistry@google.com2dd99862015-06-22 12:22:18 +00001477
tandrii@chromium.org65874e12016-03-04 12:03:02 +00001478 def test_gerrit_change_id(self):
1479 self.calls = [
1480 ((['git', 'write-tree'], ),
1481 'hashtree'),
1482 ((['git', 'rev-parse', 'HEAD~0'], ),
1483 'branch-parent'),
1484 ((['git', 'var', 'GIT_AUTHOR_IDENT'], ),
1485 'A B <a@b.org> 1456848326 +0100'),
1486 ((['git', 'var', 'GIT_COMMITTER_IDENT'], ),
1487 'C D <c@d.org> 1456858326 +0100'),
1488 ((['git', 'hash-object', '-t', 'commit', '--stdin'], ),
1489 'hashchange'),
1490 ]
1491 change_id = git_cl.GenerateGerritChangeId('line1\nline2\n')
1492 self.assertEqual(change_id, 'Ihashchange')
1493
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00001494 def test_desecription_append_footer(self):
1495 for init_desc, footer_line, expected_desc in [
1496 # Use unique desc first lines for easy test failure identification.
1497 ('foo', 'R=one', 'foo\n\nR=one'),
1498 ('foo\n\nR=one', 'BUG=', 'foo\n\nR=one\nBUG='),
1499 ('foo\n\nR=one', 'Change-Id: Ixx', 'foo\n\nR=one\n\nChange-Id: Ixx'),
1500 ('foo\n\nChange-Id: Ixx', 'R=one', 'foo\n\nR=one\n\nChange-Id: Ixx'),
1501 ('foo\n\nR=one\n\nChange-Id: Ixx', 'TBR=two',
1502 'foo\n\nR=one\nTBR=two\n\nChange-Id: Ixx'),
1503 ('foo\n\nR=one\n\nChange-Id: Ixx', 'Foo-Bar: baz',
1504 'foo\n\nR=one\n\nChange-Id: Ixx\nFoo-Bar: baz'),
1505 ('foo\n\nChange-Id: Ixx', 'Foo-Bak: baz',
1506 'foo\n\nChange-Id: Ixx\nFoo-Bak: baz'),
1507 ('foo', 'Change-Id: Ixx', 'foo\n\nChange-Id: Ixx'),
1508 ]:
1509 desc = git_cl.ChangeDescription(init_desc)
1510 desc.append_footer(footer_line)
1511 self.assertEqual(desc.description, expected_desc)
1512
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001513 def test_update_reviewers(self):
1514 data = [
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001515 ('foo', [], [],
1516 'foo'),
1517 ('foo\nR=xx', [], [],
1518 'foo\nR=xx'),
1519 ('foo\nTBR=xx', [], [],
1520 'foo\nTBR=xx'),
1521 ('foo', ['a@c'], [],
1522 'foo\n\nR=a@c'),
1523 ('foo\nR=xx', ['a@c'], [],
1524 'foo\n\nR=a@c, xx'),
1525 ('foo\nTBR=xx', ['a@c'], [],
1526 'foo\n\nR=a@c\nTBR=xx'),
1527 ('foo\nTBR=xx\nR=yy', ['a@c'], [],
1528 'foo\n\nR=a@c, yy\nTBR=xx'),
1529 ('foo\nBUG=', ['a@c'], [],
1530 'foo\nBUG=\nR=a@c'),
1531 ('foo\nR=xx\nTBR=yy\nR=bar', ['a@c'], [],
1532 'foo\n\nR=a@c, bar, xx\nTBR=yy'),
1533 ('foo', ['a@c', 'b@c'], [],
1534 'foo\n\nR=a@c, b@c'),
1535 ('foo\nBar\n\nR=\nBUG=', ['c@c'], [],
1536 'foo\nBar\n\nR=c@c\nBUG='),
1537 ('foo\nBar\n\nR=\nBUG=\nR=', ['c@c'], [],
1538 'foo\nBar\n\nR=c@c\nBUG='),
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001539 # Same as the line before, but full of whitespaces.
1540 (
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001541 'foo\nBar\n\n R = \n BUG = \n R = ', ['c@c'], [],
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001542 'foo\nBar\n\nR=c@c\n BUG =',
1543 ),
1544 # Whitespaces aren't interpreted as new lines.
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001545 ('foo BUG=allo R=joe ', ['c@c'], [],
1546 'foo BUG=allo R=joe\n\nR=c@c'),
1547 # Redundant TBRs get promoted to Rs
1548 ('foo\n\nR=a@c\nTBR=t@c', ['b@c', 'a@c'], ['a@c', 't@c'],
1549 'foo\n\nR=a@c, b@c\nTBR=t@c'),
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001550 ]
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001551 expected = [i[-1] for i in data]
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001552 actual = []
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001553 for orig, reviewers, tbrs, _expected in data:
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001554 obj = git_cl.ChangeDescription(orig)
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001555 obj.update_reviewers(reviewers, tbrs)
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001556 actual.append(obj.description)
1557 self.assertEqual(expected, actual)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001558
Nodir Turakulov23b82142017-11-16 11:04:25 -08001559 def test_get_hash_tags(self):
1560 cases = [
1561 ('', []),
1562 ('a', []),
1563 ('[a]', ['a']),
1564 ('[aa]', ['aa']),
1565 ('[a ]', ['a']),
1566 ('[a- ]', ['a']),
1567 ('[a- b]', ['a-b']),
1568 ('[a--b]', ['a-b']),
1569 ('[a', []),
1570 ('[a]x', ['a']),
1571 ('[aa]x', ['aa']),
1572 ('[a b]', ['a-b']),
1573 ('[a b]', ['a-b']),
1574 ('[a__b]', ['a-b']),
1575 ('[a] x', ['a']),
1576 ('[a][b]', ['a', 'b']),
1577 ('[a] [b]', ['a', 'b']),
1578 ('[a][b]x', ['a', 'b']),
1579 ('[a][b] x', ['a', 'b']),
1580 ('[a]\n[b]', ['a']),
1581 ('[a\nb]', []),
1582 ('[a][', ['a']),
1583 ('Revert "[a] feature"', ['a']),
1584 ('Reland "[a] feature"', ['a']),
1585 ('Revert: [a] feature', ['a']),
1586 ('Reland: [a] feature', ['a']),
1587 ('Revert "Reland: [a] feature"', ['a']),
1588 ('Foo: feature', ['foo']),
1589 ('Foo Bar: feature', ['foo-bar']),
Anthony Polito02b5af32019-12-02 19:49:47 +00001590 ('Change Foo::Bar', []),
1591 ('Foo: Change Foo::Bar', ['foo']),
Nodir Turakulov23b82142017-11-16 11:04:25 -08001592 ('Revert "Foo bar: feature"', ['foo-bar']),
1593 ('Reland "Foo bar: feature"', ['foo-bar']),
1594 ]
1595 for desc, expected in cases:
1596 change_desc = git_cl.ChangeDescription(desc)
1597 actual = change_desc.get_hash_tags()
1598 self.assertEqual(
1599 actual,
1600 expected,
1601 'GetHashTags(%r) == %r, expected %r' % (desc, actual, expected))
1602
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001603 self.assertEqual(None, git_cl.GetTargetRef('origin', None, 'master'))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001604 self.assertEqual(None, git_cl.GetTargetRef(None,
1605 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001606 'master'))
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001607
wittman@chromium.org455dc922015-01-26 20:15:50 +00001608 # Check default target refs for branches.
1609 self.assertEqual('refs/heads/master',
1610 git_cl.GetTargetRef('origin', 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001611 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001612 self.assertEqual('refs/heads/master',
1613 git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkgr',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001614 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001615 self.assertEqual('refs/heads/master',
1616 git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkcr',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001617 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001618 self.assertEqual('refs/branch-heads/123',
1619 git_cl.GetTargetRef('origin',
1620 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001621 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001622 self.assertEqual('refs/diff/test',
1623 git_cl.GetTargetRef('origin',
1624 'refs/remotes/origin/refs/diff/test',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001625 None))
rmistry@google.comc68112d2015-03-03 12:48:06 +00001626 self.assertEqual('refs/heads/chrome/m42',
1627 git_cl.GetTargetRef('origin',
1628 'refs/remotes/origin/chrome/m42',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001629 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001630
1631 # Check target refs for user-specified target branch.
1632 for branch in ('branch-heads/123', 'remotes/branch-heads/123',
1633 'refs/remotes/branch-heads/123'):
1634 self.assertEqual('refs/branch-heads/123',
1635 git_cl.GetTargetRef('origin',
1636 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001637 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001638 for branch in ('origin/master', 'remotes/origin/master',
1639 'refs/remotes/origin/master'):
1640 self.assertEqual('refs/heads/master',
1641 git_cl.GetTargetRef('origin',
1642 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001643 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001644 for branch in ('master', 'heads/master', 'refs/heads/master'):
1645 self.assertEqual('refs/heads/master',
1646 git_cl.GetTargetRef('origin',
1647 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001648 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001649
Edward Lemurda4b6c62020-02-13 00:28:40 +00001650 @mock.patch('git_common.is_dirty_git_tree', return_value=True)
1651 def test_patch_when_dirty(self, *_mocks):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001652 # Patch when local tree is dirty.
wychen@chromium.orga872e752015-04-28 23:42:18 +00001653 self.assertNotEqual(git_cl.main(['patch', '123456']), 0)
1654
Edward Lemur85153282020-02-14 22:06:29 +00001655 def assertIssueAndPatchset(
1656 self, branch='master', issue='123456', patchset='7',
1657 git_short_host='chromium'):
1658 self.assertEqual(
Edward Lemur26964072020-02-19 19:18:51 +00001659 issue, scm.GIT.GetBranchConfig('', branch, 'gerritissue'))
Edward Lemur85153282020-02-14 22:06:29 +00001660 self.assertEqual(
Edward Lemur26964072020-02-19 19:18:51 +00001661 patchset, scm.GIT.GetBranchConfig('', branch, 'gerritpatchset'))
Edward Lemur85153282020-02-14 22:06:29 +00001662 self.assertEqual(
1663 'https://%s-review.googlesource.com' % git_short_host,
Edward Lemur26964072020-02-19 19:18:51 +00001664 scm.GIT.GetBranchConfig('', branch, 'gerritserver'))
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001665
Edward Lemur85153282020-02-14 22:06:29 +00001666 def _patch_common(self, git_short_host='chromium'):
Edward Lemurda4b6c62020-02-13 00:28:40 +00001667 mock.patch('git_cl.IsGitVersionAtLeast', return_value=True).start()
Edward Lemur26964072020-02-19 19:18:51 +00001668 self.mockGit.config['remote.origin.url'] = (
1669 'https://%s.googlesource.com/my/repo' % git_short_host)
Edward Lesmes7677e5c2020-02-19 20:39:03 +00001670 gerrit_util.GetChangeDetail.return_value = {
1671 'current_revision': '7777777777',
1672 'revisions': {
1673 '1111111111': {
1674 '_number': 1,
1675 'fetch': {'http': {
1676 'url': 'https://%s.googlesource.com/my/repo' % git_short_host,
1677 'ref': 'refs/changes/56/123456/1',
1678 }},
1679 },
1680 '7777777777': {
1681 '_number': 7,
1682 'fetch': {'http': {
1683 'url': 'https://%s.googlesource.com/my/repo' % git_short_host,
1684 'ref': 'refs/changes/56/123456/7',
1685 }},
1686 },
1687 },
1688 }
wychen@chromium.orga872e752015-04-28 23:42:18 +00001689
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001690 def test_patch_gerrit_default(self):
Edward Lemur85153282020-02-14 22:06:29 +00001691 self._patch_common()
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001692 self.calls += [
1693 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
1694 'refs/changes/56/123456/7'],), ''),
Aaron Gable62619a32017-06-16 08:22:09 -07001695 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001696 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001697 ]
1698 self.assertEqual(git_cl.main(['patch', '123456']), 0)
Edward Lemur85153282020-02-14 22:06:29 +00001699 self.assertIssueAndPatchset()
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001700
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001701 def test_patch_gerrit_new_branch(self):
Edward Lemur85153282020-02-14 22:06:29 +00001702 self._patch_common()
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001703 self.calls += [
1704 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
1705 'refs/changes/56/123456/7'],), ''),
1706 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001707 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001708 ]
Edward Lemur85153282020-02-14 22:06:29 +00001709 self.assertEqual(git_cl.main(['patch', '-b', 'feature', '123456']), 0)
1710 self.assertIssueAndPatchset(branch='feature')
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001711
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001712 def test_patch_gerrit_force(self):
Edward Lemur85153282020-02-14 22:06:29 +00001713 self._patch_common('host')
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001714 self.calls += [
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001715 ((['git', 'fetch', 'https://host.googlesource.com/my/repo',
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001716 'refs/changes/56/123456/7'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001717 ((['git', 'reset', '--hard', 'FETCH_HEAD'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001718 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001719 ]
Edward Lemur52969c92020-02-06 18:15:28 +00001720 self.assertEqual(git_cl.main(['patch', '123456', '--force']), 0)
Edward Lemur85153282020-02-14 22:06:29 +00001721 self.assertIssueAndPatchset(git_short_host='host')
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001722
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001723 def test_patch_gerrit_guess_by_url(self):
Edward Lemur85153282020-02-14 22:06:29 +00001724 self._patch_common('else')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001725 self.calls += [
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001726 ((['git', 'fetch', 'https://else.googlesource.com/my/repo',
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001727 'refs/changes/56/123456/1'],), ''),
Aaron Gable62619a32017-06-16 08:22:09 -07001728 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001729 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001730 ]
1731 self.assertEqual(git_cl.main(
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001732 ['patch', 'https://else-review.googlesource.com/#/c/123456/1']), 0)
Edward Lemur85153282020-02-14 22:06:29 +00001733 self.assertIssueAndPatchset(patchset='1', git_short_host='else')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001734
Aaron Gable697a91b2018-01-19 15:20:15 -08001735 def test_patch_gerrit_guess_by_url_with_repo(self):
Edward Lemur85153282020-02-14 22:06:29 +00001736 self._patch_common('else')
Aaron Gable697a91b2018-01-19 15:20:15 -08001737 self.calls += [
1738 ((['git', 'fetch', 'https://else.googlesource.com/my/repo',
1739 'refs/changes/56/123456/1'],), ''),
1740 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
Aaron Gable697a91b2018-01-19 15:20:15 -08001741 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
Aaron Gable697a91b2018-01-19 15:20:15 -08001742 ]
1743 self.assertEqual(git_cl.main(
1744 ['patch', 'https://else-review.googlesource.com/c/my/repo/+/123456/1']),
1745 0)
Edward Lemur85153282020-02-14 22:06:29 +00001746 self.assertIssueAndPatchset(patchset='1', git_short_host='else')
Aaron Gable697a91b2018-01-19 15:20:15 -08001747
Edward Lemurd55c5072020-02-20 01:09:07 +00001748 @mock.patch('sys.stderr', StringIO())
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001749 def test_patch_gerrit_conflict(self):
Edward Lemur85153282020-02-14 22:06:29 +00001750 self._patch_common()
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001751 self.calls += [
1752 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001753 'refs/changes/56/123456/7'],), ''),
tandrii5d48c322016-08-18 16:19:37 -07001754 ((['git', 'cherry-pick', 'FETCH_HEAD'],), CERR1),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001755 ]
1756 with self.assertRaises(SystemExitMock):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001757 git_cl.main(['patch', '123456'])
Edward Lemurd55c5072020-02-20 01:09:07 +00001758 self.assertEqual(
1759 'Command "git cherry-pick FETCH_HEAD" failed.\n\n',
1760 sys.stderr.getvalue())
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001761
Edward Lemurda4b6c62020-02-13 00:28:40 +00001762 @mock.patch(
Edward Lesmes7677e5c2020-02-19 20:39:03 +00001763 'gerrit_util.GetChangeDetail',
Edward Lemurda4b6c62020-02-13 00:28:40 +00001764 side_effect=gerrit_util.GerritError(404, ''))
Edward Lemurd55c5072020-02-20 01:09:07 +00001765 @mock.patch('sys.stderr', StringIO())
Edward Lemurda4b6c62020-02-13 00:28:40 +00001766 def test_patch_gerrit_not_exists(self, *_mocks):
Edward Lemur26964072020-02-19 19:18:51 +00001767 self.mockGit.config['remote.origin.url'] = (
1768 'https://chromium.googlesource.com/my/repo')
tandriic2405f52016-10-10 08:13:15 -07001769 with self.assertRaises(SystemExitMock):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001770 self.assertEqual(1, git_cl.main(['patch', '123456']))
Edward Lemurd55c5072020-02-20 01:09:07 +00001771 self.assertEqual(
1772 'change 123456 at https://chromium-review.googlesource.com does not '
1773 'exist or you have no access to it\n',
1774 sys.stderr.getvalue())
tandriic2405f52016-10-10 08:13:15 -07001775
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001776 def _checkout_calls(self):
1777 return [
1778 ((['git', 'config', '--local', '--get-regexp',
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001779 'branch\\..*\\.gerritissue'], ),
1780 ('branch.ger-branch.gerritissue 123456\n'
1781 'branch.gbranch654.gerritissue 654321\n')),
1782 ]
1783
1784 def test_checkout_gerrit(self):
1785 """Tests git cl checkout <issue>."""
1786 self.calls = self._checkout_calls()
1787 self.calls += [((['git', 'checkout', 'ger-branch'], ), '')]
1788 self.assertEqual(0, git_cl.main(['checkout', '123456']))
1789
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001790 def test_checkout_not_found(self):
1791 """Tests git cl checkout <issue>."""
1792 self.calls = self._checkout_calls()
1793 self.assertEqual(1, git_cl.main(['checkout', '99999']))
1794
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001795 def test_checkout_no_branch_issues(self):
1796 """Tests git cl checkout <issue>."""
1797 self.calls = [
1798 ((['git', 'config', '--local', '--get-regexp',
tandrii5d48c322016-08-18 16:19:37 -07001799 'branch\\..*\\.gerritissue'], ), CERR1),
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001800 ]
1801 self.assertEqual(1, git_cl.main(['checkout', '99999']))
1802
Edward Lemur26964072020-02-19 19:18:51 +00001803 def _test_gerrit_ensure_authenticated_common(self, auth):
Edward Lemurda4b6c62020-02-13 00:28:40 +00001804 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
1805 CookiesAuthenticatorMockFactory(hosts_with_creds=auth)).start()
Edward Lemur26964072020-02-19 19:18:51 +00001806 self.mockGit.config['remote.origin.url'] = (
1807 'https://chromium.googlesource.com/my/repo')
Edward Lemurf38bc172019-09-03 21:02:13 +00001808 cl = git_cl.Changelist()
tandrii@chromium.org28253532016-04-14 13:46:56 +00001809 cl.branch = 'master'
1810 cl.branchref = 'refs/heads/master'
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001811 return cl
1812
Edward Lemurd55c5072020-02-20 01:09:07 +00001813 @mock.patch('sys.stderr', StringIO())
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001814 def test_gerrit_ensure_authenticated_missing(self):
1815 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001816 'chromium.googlesource.com': ('git-is.ok', '', 'but gerrit is missing'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001817 })
Edward Lemurd55c5072020-02-20 01:09:07 +00001818 with self.assertRaises(SystemExitMock):
1819 cl.EnsureAuthenticated(force=False)
1820 self.assertEqual(
1821 'Credentials for the following hosts are required:\n'
1822 ' chromium-review.googlesource.com\n'
1823 'These are read from ~/.gitcookies (or legacy ~/.netrc)\n'
1824 'You can (re)generate your credentials by visiting '
1825 'https://chromium-review.googlesource.com/new-password\n',
1826 sys.stderr.getvalue())
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001827
1828 def test_gerrit_ensure_authenticated_conflict(self):
1829 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001830 'chromium.googlesource.com':
1831 ('git-one.example.com', None, 'secret1'),
1832 'chromium-review.googlesource.com':
1833 ('git-other.example.com', None, 'secret2'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001834 })
1835 self.calls.append(
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01001836 (('ask_for_data', 'If you know what you are doing '
1837 'press Enter to continue, or Ctrl+C to abort'), ''))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001838 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1839
1840 def test_gerrit_ensure_authenticated_ok(self):
1841 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001842 'chromium.googlesource.com':
1843 ('git-same.example.com', None, 'secret'),
1844 'chromium-review.googlesource.com':
1845 ('git-same.example.com', None, 'secret'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001846 })
1847 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1848
tandrii@chromium.org28253532016-04-14 13:46:56 +00001849 def test_gerrit_ensure_authenticated_skipped(self):
Edward Lemur26964072020-02-19 19:18:51 +00001850 self.mockGit.config['gerrit.skip-ensure-authenticated'] = 'true'
1851 cl = self._test_gerrit_ensure_authenticated_common(auth={})
tandrii@chromium.org28253532016-04-14 13:46:56 +00001852 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1853
Eric Boren2fb63102018-10-05 13:05:03 +00001854 def test_gerrit_ensure_authenticated_bearer_token(self):
1855 cl = self._test_gerrit_ensure_authenticated_common(auth={
1856 'chromium.googlesource.com':
1857 ('', None, 'secret'),
1858 'chromium-review.googlesource.com':
1859 ('', None, 'secret'),
1860 })
1861 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1862 header = gerrit_util.CookiesAuthenticator().get_auth_header(
1863 'chromium.googlesource.com')
1864 self.assertTrue('Bearer' in header)
1865
Daniel Chengcf6269b2019-05-18 01:02:12 +00001866 def test_gerrit_ensure_authenticated_non_https(self):
Edward Lemur26964072020-02-19 19:18:51 +00001867 self.mockGit.config['remote.origin.url'] = 'custom-scheme://repo'
Daniel Chengcf6269b2019-05-18 01:02:12 +00001868 self.calls = [
Josip906bfde2020-01-31 22:38:49 +00001869 (('logging.warning',
1870 'Ignoring branch %(branch)s with non-https remote '
1871 '%(remote)s', {
1872 'branch': 'master',
1873 'remote': 'custom-scheme://repo'}
1874 ), None),
Daniel Chengcf6269b2019-05-18 01:02:12 +00001875 ]
Edward Lemurda4b6c62020-02-13 00:28:40 +00001876 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
1877 CookiesAuthenticatorMockFactory(hosts_with_creds={})).start()
1878 mock.patch('logging.warning',
1879 lambda *a: self._mocked_call('logging.warning', *a)).start()
Edward Lemurf38bc172019-09-03 21:02:13 +00001880 cl = git_cl.Changelist()
Daniel Chengcf6269b2019-05-18 01:02:12 +00001881 cl.branch = 'master'
1882 cl.branchref = 'refs/heads/master'
1883 cl.lookedup_issue = True
1884 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1885
Florian Mayerae510e82020-01-30 21:04:48 +00001886 def test_gerrit_ensure_authenticated_non_url(self):
Edward Lemur26964072020-02-19 19:18:51 +00001887 self.mockGit.config['remote.origin.url'] = (
1888 'git@somehost.example:foo/bar.git')
Florian Mayerae510e82020-01-30 21:04:48 +00001889 self.calls = [
Josip906bfde2020-01-31 22:38:49 +00001890 (('logging.error',
1891 'Remote "%(remote)s" for branch "%(branch)s" points to "%(url)s", '
1892 'but it doesn\'t exist.', {
1893 'remote': 'origin',
1894 'branch': 'master',
1895 'url': 'git@somehost.example:foo/bar.git'}
1896 ), None),
Florian Mayerae510e82020-01-30 21:04:48 +00001897 ]
Edward Lemurda4b6c62020-02-13 00:28:40 +00001898 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
1899 CookiesAuthenticatorMockFactory(hosts_with_creds={})).start()
1900 mock.patch('logging.error',
1901 lambda *a: self._mocked_call('logging.error', *a)).start()
Florian Mayerae510e82020-01-30 21:04:48 +00001902 cl = git_cl.Changelist()
1903 cl.branch = 'master'
1904 cl.branchref = 'refs/heads/master'
1905 cl.lookedup_issue = True
1906 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1907
Andrii Shyshkalov828701b2016-12-09 10:46:47 +01001908 def _cmd_set_commit_gerrit_common(self, vote, notify=None):
Edward Lemur85153282020-02-14 22:06:29 +00001909 self.mockGit.config['branch.master.gerritissue'] = '123'
1910 self.mockGit.config['branch.master.gerritserver'] = (
1911 'https://chromium-review.googlesource.com')
Edward Lemur26964072020-02-19 19:18:51 +00001912 self.mockGit.config['remote.origin.url'] = (
1913 'https://chromium.googlesource.com/infra/infra')
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001914 self.calls = [
Edward Lemurda4b6c62020-02-13 00:28:40 +00001915 (('SetReview', 'chromium-review.googlesource.com',
1916 'infra%2Finfra~123', None,
1917 {'Commit-Queue': vote}, notify, None), ''),
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001918 ]
tandriid9e5ce52016-07-13 02:32:59 -07001919
1920 def test_cmd_set_commit_gerrit_clear(self):
1921 self._cmd_set_commit_gerrit_common(0)
1922 self.assertEqual(0, git_cl.main(['set-commit', '-c']))
1923
1924 def test_cmd_set_commit_gerrit_dry(self):
Aaron Gable75e78722017-06-09 10:40:16 -07001925 self._cmd_set_commit_gerrit_common(1, notify=False)
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001926 self.assertEqual(0, git_cl.main(['set-commit', '-d']))
1927
tandriid9e5ce52016-07-13 02:32:59 -07001928 def test_cmd_set_commit_gerrit(self):
1929 self._cmd_set_commit_gerrit_common(2)
1930 self.assertEqual(0, git_cl.main(['set-commit']))
1931
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00001932 def test_description_display(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00001933 mock.patch('git_cl.Changelist', ChangelistMock).start()
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00001934 ChangelistMock.desc = 'foo\n'
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00001935
1936 self.assertEqual(0, git_cl.main(['description', '-d']))
Edward Lemurda4b6c62020-02-13 00:28:40 +00001937 self.assertEqual('foo\n', sys.stdout.getvalue())
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00001938
Edward Lemurda4b6c62020-02-13 00:28:40 +00001939 @mock.patch('sys.stderr', StringIO())
iannucci3c972b92016-08-17 13:24:10 -07001940 def test_StatusFieldOverrideIssueMissingArgs(self):
iannucci3c972b92016-08-17 13:24:10 -07001941 try:
1942 self.assertEqual(git_cl.main(['status', '--issue', '1']), 0)
Edward Lemurd55c5072020-02-20 01:09:07 +00001943 except SystemExitMock:
Edward Lemur6c6827c2020-02-06 21:15:18 +00001944 self.assertIn(
Edward Lemurda4b6c62020-02-13 00:28:40 +00001945 '--field must be given when --issue is set.', sys.stderr.getvalue())
iannucci3c972b92016-08-17 13:24:10 -07001946
1947 def test_StatusFieldOverrideIssue(self):
iannucci3c972b92016-08-17 13:24:10 -07001948 def assertIssue(cl_self, *_args):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00001949 self.assertEqual(cl_self.issue, 1)
iannucci3c972b92016-08-17 13:24:10 -07001950 return 'foobar'
1951
Edward Lemurda4b6c62020-02-13 00:28:40 +00001952 mock.patch('git_cl.Changelist.FetchDescription', assertIssue).start()
iannuccie53c9352016-08-17 14:40:40 -07001953 self.assertEqual(
Edward Lemur52969c92020-02-06 18:15:28 +00001954 git_cl.main(['status', '--issue', '1', '--field', 'desc']),
iannuccie53c9352016-08-17 14:40:40 -07001955 0)
Edward Lemurda4b6c62020-02-13 00:28:40 +00001956 self.assertEqual(sys.stdout.getvalue(), 'foobar\n')
iannucci3c972b92016-08-17 13:24:10 -07001957
iannuccie53c9352016-08-17 14:40:40 -07001958 def test_SetCloseOverrideIssue(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001959
iannuccie53c9352016-08-17 14:40:40 -07001960 def assertIssue(cl_self, *_args):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00001961 self.assertEqual(cl_self.issue, 1)
iannuccie53c9352016-08-17 14:40:40 -07001962 return 'foobar'
1963
Edward Lemurda4b6c62020-02-13 00:28:40 +00001964 mock.patch('git_cl.Changelist.FetchDescription', assertIssue).start()
1965 mock.patch('git_cl.Changelist.CloseIssue', lambda *_: None).start()
iannuccie53c9352016-08-17 14:40:40 -07001966 self.assertEqual(
Edward Lemur52969c92020-02-06 18:15:28 +00001967 git_cl.main(['set-close', '--issue', '1']), 0)
iannuccie53c9352016-08-17 14:40:40 -07001968
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00001969 def test_description(self):
Edward Lemur26964072020-02-19 19:18:51 +00001970 self.mockGit.config['remote.origin.url'] = (
1971 'https://chromium.googlesource.com/my/repo')
Edward Lesmes7677e5c2020-02-19 20:39:03 +00001972 gerrit_util.GetChangeDetail.return_value = {
1973 'current_revision': 'sha1',
1974 'revisions': {'sha1': {
1975 'commit': {'message': 'foobar'},
1976 }},
1977 }
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00001978 self.assertEqual(0, git_cl.main([
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00001979 'description',
1980 'https://chromium-review.googlesource.com/c/my/repo/+/123123',
1981 '-d']))
Edward Lemurda4b6c62020-02-13 00:28:40 +00001982 self.assertEqual('foobar\n', sys.stdout.getvalue())
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00001983
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00001984 def test_description_set_raw(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00001985 mock.patch('git_cl.Changelist', ChangelistMock).start()
1986 mock.patch('git_cl.sys.stdin', StringIO('hihi')).start()
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00001987
1988 self.assertEqual(0, git_cl.main(['description', '-n', 'hihi']))
1989 self.assertEqual('hihi', ChangelistMock.desc)
1990
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00001991 def test_description_appends_bug_line(self):
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00001992 current_desc = 'Some.\n\nChange-Id: xxx'
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00001993
1994 def RunEditor(desc, _, **kwargs):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00001995 self.assertEqual(
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00001996 '# Enter a description of the change.\n'
1997 '# This will be displayed on the codereview site.\n'
1998 '# The first line will also be used as the subject of the review.\n'
1999 '#--------------------This line is 72 characters long'
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002000 '--------------------\n'
Aaron Gable3a16ed12017-03-23 10:51:55 -07002001 'Some.\n\nChange-Id: xxx\nBug: ',
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002002 desc)
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002003 # Simulate user changing something.
Aaron Gable3a16ed12017-03-23 10:51:55 -07002004 return 'Some.\n\nChange-Id: xxx\nBug: 123'
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002005
Edward Lemur6c6827c2020-02-06 21:15:18 +00002006 def UpdateDescription(_, desc, force=False):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002007 self.assertEqual(desc, 'Some.\n\nChange-Id: xxx\nBug: 123')
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002008
Edward Lemurda4b6c62020-02-13 00:28:40 +00002009 mock.patch('git_cl.Changelist.FetchDescription',
2010 lambda *args: current_desc).start()
2011 mock.patch('git_cl.Changelist.UpdateDescription',
2012 UpdateDescription).start()
2013 mock.patch('git_cl.gclient_utils.RunEditor', RunEditor).start()
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002014
Edward Lemur85153282020-02-14 22:06:29 +00002015 self.mockGit.config['branch.master.gerritissue'] = '123'
Edward Lemur52969c92020-02-06 18:15:28 +00002016 self.assertEqual(0, git_cl.main(['description']))
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002017
Dan Beamd8b04ca2019-10-10 21:23:26 +00002018 def test_description_does_not_append_bug_line_if_fixed_is_present(self):
2019 current_desc = 'Some.\n\nFixed: 123\nChange-Id: xxx'
2020
2021 def RunEditor(desc, _, **kwargs):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002022 self.assertEqual(
Dan Beamd8b04ca2019-10-10 21:23:26 +00002023 '# Enter a description of the change.\n'
2024 '# This will be displayed on the codereview site.\n'
2025 '# The first line will also be used as the subject of the review.\n'
2026 '#--------------------This line is 72 characters long'
2027 '--------------------\n'
2028 'Some.\n\nFixed: 123\nChange-Id: xxx',
2029 desc)
2030 return desc
2031
Edward Lemurda4b6c62020-02-13 00:28:40 +00002032 mock.patch('git_cl.Changelist.FetchDescription',
2033 lambda *args: current_desc).start()
2034 mock.patch('git_cl.gclient_utils.RunEditor', RunEditor).start()
Dan Beamd8b04ca2019-10-10 21:23:26 +00002035
Edward Lemur85153282020-02-14 22:06:29 +00002036 self.mockGit.config['branch.master.gerritissue'] = '123'
Edward Lemur52969c92020-02-06 18:15:28 +00002037 self.assertEqual(0, git_cl.main(['description']))
Dan Beamd8b04ca2019-10-10 21:23:26 +00002038
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002039 def test_description_set_stdin(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00002040 mock.patch('git_cl.Changelist', ChangelistMock).start()
2041 mock.patch('git_cl.sys.stdin', StringIO('hi \r\n\t there\n\nman')).start()
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002042
2043 self.assertEqual(0, git_cl.main(['description', '-n', '-']))
2044 self.assertEqual('hi\n\t there\n\nman', ChangelistMock.desc)
2045
kmarshall3bff56b2016-06-06 18:31:47 -07002046 def test_archive(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002047 self.calls = [
2048 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
Edward Lemurf38bc172019-09-03 21:02:13 +00002049 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002050 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002051 ((['git', 'tag', 'git-cl-archived-456-foo', 'foo'],), ''),
Edward Lemurf38bc172019-09-03 21:02:13 +00002052 ((['git', 'branch', '-D', 'foo'],), '')
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002053 ]
kmarshall3bff56b2016-06-06 18:31:47 -07002054
Edward Lemurda4b6c62020-02-13 00:28:40 +00002055 mock.patch('git_cl.get_cl_statuses',
kmarshall3bff56b2016-06-06 18:31:47 -07002056 lambda branches, fine_grained, max_processes:
kmarshall9249e012016-08-23 12:02:16 -07002057 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2058 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002059 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
kmarshall3bff56b2016-06-06 18:31:47 -07002060
2061 self.assertEqual(0, git_cl.main(['archive', '-f']))
2062
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002063 def test_archive_tag_collision(self):
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002064 self.calls = [
2065 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2066 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
2067 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],),
2068 'refs/tags/git-cl-archived-456-foo'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002069 ((['git', 'tag', 'git-cl-archived-456-foo-2', 'foo'],), ''),
2070 ((['git', 'branch', '-D', 'foo'],), '')
2071 ]
2072
Edward Lemurda4b6c62020-02-13 00:28:40 +00002073 mock.patch('git_cl.get_cl_statuses',
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002074 lambda branches, fine_grained, max_processes:
2075 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2076 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002077 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002078
2079 self.assertEqual(0, git_cl.main(['archive', '-f']))
2080
kmarshall3bff56b2016-06-06 18:31:47 -07002081 def test_archive_current_branch_fails(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002082 self.calls = [
2083 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2084 'refs/heads/master'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002085 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002086 ]
kmarshall3bff56b2016-06-06 18:31:47 -07002087
Edward Lemurda4b6c62020-02-13 00:28:40 +00002088 mock.patch('git_cl.get_cl_statuses',
kmarshall9249e012016-08-23 12:02:16 -07002089 lambda branches, fine_grained, max_processes:
Edward Lemurda4b6c62020-02-13 00:28:40 +00002090 [(MockChangelistWithBranchAndIssue('master', 1),
2091 'closed')]).start()
kmarshall9249e012016-08-23 12:02:16 -07002092
2093 self.assertEqual(1, git_cl.main(['archive', '-f']))
2094
2095 def test_archive_dry_run(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002096 self.calls = [
2097 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2098 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002099 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002100 ]
kmarshall3bff56b2016-06-06 18:31:47 -07002101
Edward Lemurda4b6c62020-02-13 00:28:40 +00002102 mock.patch('git_cl.get_cl_statuses',
kmarshall3bff56b2016-06-06 18:31:47 -07002103 lambda branches, fine_grained, max_processes:
kmarshall9249e012016-08-23 12:02:16 -07002104 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2105 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002106 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
kmarshall3bff56b2016-06-06 18:31:47 -07002107
kmarshall9249e012016-08-23 12:02:16 -07002108 self.assertEqual(0, git_cl.main(['archive', '-f', '--dry-run']))
2109
2110 def test_archive_no_tags(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002111 self.calls = [
2112 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2113 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002114 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002115 ((['git', 'branch', '-D', 'foo'],), '')
2116 ]
kmarshall9249e012016-08-23 12:02:16 -07002117
Edward Lemurda4b6c62020-02-13 00:28:40 +00002118 mock.patch('git_cl.get_cl_statuses',
kmarshall9249e012016-08-23 12:02:16 -07002119 lambda branches, fine_grained, max_processes:
2120 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2121 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002122 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
kmarshall9249e012016-08-23 12:02:16 -07002123
2124 self.assertEqual(0, git_cl.main(['archive', '-f', '--notags']))
kmarshall3bff56b2016-06-06 18:31:47 -07002125
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002126 def test_archive_tag_cleanup_on_branch_deletion_error(self):
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002127 self.calls = [
2128 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2129 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
2130 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002131 ((['git', 'tag', 'git-cl-archived-456-foo', 'foo'],),
2132 'refs/tags/git-cl-archived-456-foo'),
2133 ((['git', 'branch', '-D', 'foo'],), CERR1),
2134 ((['git', 'tag', '-d', 'git-cl-archived-456-foo'],),
2135 'refs/tags/git-cl-archived-456-foo'),
2136 ]
2137
Edward Lemurda4b6c62020-02-13 00:28:40 +00002138 mock.patch('git_cl.get_cl_statuses',
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002139 lambda branches, fine_grained, max_processes:
2140 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2141 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
Edward Lemurda4b6c62020-02-13 00:28:40 +00002142 (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002143
2144 self.assertEqual(0, git_cl.main(['archive', '-f']))
2145
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002146 def test_cmd_issue_erase_existing(self):
Edward Lemur85153282020-02-14 22:06:29 +00002147 self.mockGit.config['branch.master.gerritissue'] = '123'
2148 self.mockGit.config['branch.master.gerritserver'] = (
2149 'https://chromium-review.googlesource.com')
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002150 self.calls = [
Aaron Gableca01e2c2017-07-19 11:16:02 -07002151 ((['git', 'log', '-1', '--format=%B'],), 'This is a description'),
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002152 ]
2153 self.assertEqual(0, git_cl.main(['issue', '0']))
Edward Lemur85153282020-02-14 22:06:29 +00002154 self.assertNotIn('branch.master.gerritissue', self.mockGit.config)
2155 self.assertNotIn('branch.master.gerritserver', self.mockGit.config)
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002156
Aaron Gable400e9892017-07-12 15:31:21 -07002157 def test_cmd_issue_erase_existing_with_change_id(self):
Edward Lemur85153282020-02-14 22:06:29 +00002158 self.mockGit.config['branch.master.gerritissue'] = '123'
2159 self.mockGit.config['branch.master.gerritserver'] = (
2160 'https://chromium-review.googlesource.com')
Edward Lemurda4b6c62020-02-13 00:28:40 +00002161 mock.patch('git_cl.Changelist.FetchDescription',
2162 lambda _: 'This is a description\n\nChange-Id: Ideadbeef').start()
Aaron Gable400e9892017-07-12 15:31:21 -07002163 self.calls = [
Aaron Gableca01e2c2017-07-19 11:16:02 -07002164 ((['git', 'log', '-1', '--format=%B'],),
2165 'This is a description\n\nChange-Id: Ideadbeef'),
2166 ((['git', 'commit', '--amend', '-m', 'This is a description\n'],), ''),
Aaron Gable400e9892017-07-12 15:31:21 -07002167 ]
2168 self.assertEqual(0, git_cl.main(['issue', '0']))
Edward Lemur85153282020-02-14 22:06:29 +00002169 self.assertNotIn('branch.master.gerritissue', self.mockGit.config)
2170 self.assertNotIn('branch.master.gerritserver', self.mockGit.config)
Aaron Gable400e9892017-07-12 15:31:21 -07002171
phajdan.jre328cf92016-08-22 04:12:17 -07002172 def test_cmd_issue_json(self):
Edward Lemur85153282020-02-14 22:06:29 +00002173 self.mockGit.config['branch.master.gerritissue'] = '123'
2174 self.mockGit.config['branch.master.gerritserver'] = (
2175 'https://chromium-review.googlesource.com')
phajdan.jre328cf92016-08-22 04:12:17 -07002176 self.calls = [
phajdan.jre328cf92016-08-22 04:12:17 -07002177 (('write_json', 'output.json',
Andrii Shyshkalova185e2e2018-11-21 00:42:55 +00002178 {'issue': 123,
2179 'issue_url': 'https://chromium-review.googlesource.com/123'}),
phajdan.jre328cf92016-08-22 04:12:17 -07002180 ''),
2181 ]
2182 self.assertEqual(0, git_cl.main(['issue', '--json', 'output.json']))
2183
tandrii16e0b4e2016-06-07 10:34:28 -07002184 def _common_GerritCommitMsgHookCheck(self):
Edward Lemur15a9b8c2020-02-13 00:52:30 +00002185 mock.patch(
2186 'git_cl.os.path.abspath',
2187 lambda path: self._mocked_call(['abspath', path])).start()
2188 mock.patch(
2189 'git_cl.os.path.exists',
2190 lambda path: self._mocked_call(['exists', path])).start()
2191 mock.patch(
2192 'git_cl.gclient_utils.FileRead',
2193 lambda path: self._mocked_call(['FileRead', path])).start()
2194 mock.patch(
2195 'git_cl.gclient_utils.rm_file_or_tree',
2196 lambda path: self._mocked_call(['rm_file_or_tree', path])).start()
Edward Lemurf38bc172019-09-03 21:02:13 +00002197 return git_cl.Changelist(issue=123)
tandrii16e0b4e2016-06-07 10:34:28 -07002198
2199 def test_GerritCommitMsgHookCheck_custom_hook(self):
2200 cl = self._common_GerritCommitMsgHookCheck()
2201 self.calls += [
Edward Lemur15a9b8c2020-02-13 00:52:30 +00002202 ((['exists', '.git/hooks/commit-msg'],), True),
2203 ((['FileRead', '.git/hooks/commit-msg'],),
tandrii16e0b4e2016-06-07 10:34:28 -07002204 '#!/bin/sh\necho "custom hook"')
2205 ]
Edward Lemur125d60a2019-09-13 18:25:41 +00002206 cl._GerritCommitMsgHookCheck(offer_removal=True)
tandrii16e0b4e2016-06-07 10:34:28 -07002207
2208 def test_GerritCommitMsgHookCheck_not_exists(self):
2209 cl = self._common_GerritCommitMsgHookCheck()
2210 self.calls += [
Edward Lemur15a9b8c2020-02-13 00:52:30 +00002211 ((['exists', '.git/hooks/commit-msg'],), False),
tandrii16e0b4e2016-06-07 10:34:28 -07002212 ]
Edward Lemur125d60a2019-09-13 18:25:41 +00002213 cl._GerritCommitMsgHookCheck(offer_removal=True)
tandrii16e0b4e2016-06-07 10:34:28 -07002214
2215 def test_GerritCommitMsgHookCheck(self):
2216 cl = self._common_GerritCommitMsgHookCheck()
2217 self.calls += [
Edward Lemur15a9b8c2020-02-13 00:52:30 +00002218 ((['exists', '.git/hooks/commit-msg'],), True),
2219 ((['FileRead', '.git/hooks/commit-msg'],),
tandrii16e0b4e2016-06-07 10:34:28 -07002220 '...\n# From Gerrit Code Review\n...\nadd_ChangeId()\n'),
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002221 (('ask_for_data', 'Do you want to remove it now? [Yes/No]: '), 'Yes'),
Edward Lemur15a9b8c2020-02-13 00:52:30 +00002222 ((['rm_file_or_tree', '.git/hooks/commit-msg'],),
tandrii16e0b4e2016-06-07 10:34:28 -07002223 ''),
2224 ]
Edward Lemur125d60a2019-09-13 18:25:41 +00002225 cl._GerritCommitMsgHookCheck(offer_removal=True)
tandrii16e0b4e2016-06-07 10:34:28 -07002226
tandriic4344b52016-08-29 06:04:54 -07002227 def test_GerritCmdLand(self):
Edward Lemur85153282020-02-14 22:06:29 +00002228 self.mockGit.config['branch.master.gerritsquashhash'] = 'deadbeaf'
2229 self.mockGit.config['branch.master.gerritserver'] = (
2230 'chromium-review.googlesource.com')
tandriic4344b52016-08-29 06:04:54 -07002231 self.calls += [
tandriic4344b52016-08-29 06:04:54 -07002232 ((['git', 'diff', 'deadbeaf'],), ''), # No diff.
tandriic4344b52016-08-29 06:04:54 -07002233 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002234 cl = git_cl.Changelist(issue=123)
Edward Lemur125d60a2019-09-13 18:25:41 +00002235 cl._GetChangeDetail = lambda *args, **kwargs: {
tandriic4344b52016-08-29 06:04:54 -07002236 'labels': {},
2237 'current_revision': 'deadbeaf',
2238 }
Edward Lemur125d60a2019-09-13 18:25:41 +00002239 cl._GetChangeCommit = lambda: {
agable32978d92016-11-01 12:55:02 -07002240 'commit': 'deadbeef',
Aaron Gable02cdbb42016-12-13 16:24:25 -08002241 'web_links': [{'name': 'gitiles',
agable32978d92016-11-01 12:55:02 -07002242 'url': 'https://git.googlesource.com/test/+/deadbeef'}],
2243 }
Edward Lemur125d60a2019-09-13 18:25:41 +00002244 cl.SubmitIssue = lambda wait_for_merge: None
Olivier Robin75ee7252018-04-13 10:02:56 +02002245 self.assertEqual(0, cl.CMDLand(force=True,
2246 bypass_hooks=True,
2247 verbose=True,
2248 parallel=False))
Edward Lemur73c76702020-02-06 23:57:18 +00002249 self.assertIn(
2250 'Issue chromium-review.googlesource.com/123 has been submitted',
Edward Lemurda4b6c62020-02-13 00:28:40 +00002251 sys.stdout.getvalue())
Edward Lemur73c76702020-02-06 23:57:18 +00002252 self.assertIn(
2253 'Landed as: https://git.googlesource.com/test/+/deadbeef',
Edward Lemurda4b6c62020-02-13 00:28:40 +00002254 sys.stdout.getvalue())
tandriic4344b52016-08-29 06:04:54 -07002255
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002256 def _mock_gerrit_changes_for_detail_cache(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00002257 mock.patch('git_cl.Changelist._GetGerritHost', lambda _: 'host').start()
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002258
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002259 def test_gerrit_change_detail_cache_simple(self):
2260 self._mock_gerrit_changes_for_detail_cache()
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002261 gerrit_util.GetChangeDetail.side_effect = ['a', 'b']
Edward Lemurf38bc172019-09-03 21:02:13 +00002262 cl1 = git_cl.Changelist(issue=1)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002263 cl1._cached_remote_url = (
2264 True, 'https://chromium.googlesource.com/a/my/repo.git/')
Edward Lemurf38bc172019-09-03 21:02:13 +00002265 cl2 = git_cl.Changelist(issue=2)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002266 cl2._cached_remote_url = (
2267 True, 'https://chromium.googlesource.com/ab/repo')
Andrii Shyshkalovb7214602018-08-22 23:20:26 +00002268 self.assertEqual(cl1._GetChangeDetail(), 'a') # Miss.
2269 self.assertEqual(cl1._GetChangeDetail(), 'a')
2270 self.assertEqual(cl2._GetChangeDetail(), 'b') # Miss.
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002271
2272 def test_gerrit_change_detail_cache_options(self):
2273 self._mock_gerrit_changes_for_detail_cache()
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002274 gerrit_util.GetChangeDetail.side_effect = ['cab', 'ad']
Edward Lemurf38bc172019-09-03 21:02:13 +00002275 cl = git_cl.Changelist(issue=1)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002276 cl._cached_remote_url = (True, 'https://chromium.googlesource.com/repo/')
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002277 self.assertEqual(cl._GetChangeDetail(options=['C', 'A', 'B']), 'cab')
2278 self.assertEqual(cl._GetChangeDetail(options=['A', 'B', 'C']), 'cab')
2279 self.assertEqual(cl._GetChangeDetail(options=['B', 'A']), 'cab')
2280 self.assertEqual(cl._GetChangeDetail(options=['C']), 'cab')
2281 self.assertEqual(cl._GetChangeDetail(options=['A']), 'cab')
2282 self.assertEqual(cl._GetChangeDetail(), 'cab')
2283
2284 self.assertEqual(cl._GetChangeDetail(options=['A', 'D']), 'ad')
2285 self.assertEqual(cl._GetChangeDetail(options=['A']), 'cab')
2286 self.assertEqual(cl._GetChangeDetail(options=['D']), 'ad')
2287 self.assertEqual(cl._GetChangeDetail(), 'cab')
2288
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002289 def test_gerrit_description_caching(self):
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002290 gerrit_util.GetChangeDetail.return_value = {
2291 'current_revision': 'rev1',
2292 'revisions': {
2293 'rev1': {'commit': {'message': 'desc1'}},
2294 },
2295 }
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002296
2297 self._mock_gerrit_changes_for_detail_cache()
Edward Lemurf38bc172019-09-03 21:02:13 +00002298 cl = git_cl.Changelist(issue=1)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002299 cl._cached_remote_url = (
2300 True, 'https://chromium.googlesource.com/a/my/repo.git/')
Edward Lemur6c6827c2020-02-06 21:15:18 +00002301 self.assertEqual(cl.FetchDescription(), 'desc1')
2302 self.assertEqual(cl.FetchDescription(), 'desc1') # cache hit.
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002303
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002304 def test_print_current_creds(self):
2305 class CookiesAuthenticatorMock(object):
2306 def __init__(self):
2307 self.gitcookies = {
2308 'host.googlesource.com': ('user', 'pass'),
2309 'host-review.googlesource.com': ('user', 'pass'),
2310 }
2311 self.netrc = self
2312 self.netrc.hosts = {
2313 'github.com': ('user2', None, 'pass2'),
2314 'host2.googlesource.com': ('user3', None, 'pass'),
2315 }
Edward Lemurda4b6c62020-02-13 00:28:40 +00002316 mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
2317 CookiesAuthenticatorMock).start()
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002318 git_cl._GitCookiesChecker().print_current_creds(include_netrc=True)
2319 self.assertEqual(list(sys.stdout.getvalue().splitlines()), [
2320 ' Host\t User\t Which file',
2321 '============================\t=====\t===========',
2322 'host-review.googlesource.com\t user\t.gitcookies',
2323 ' host.googlesource.com\t user\t.gitcookies',
2324 ' host2.googlesource.com\tuser3\t .netrc',
2325 ])
Edward Lemur79d4f992019-11-11 23:49:02 +00002326 sys.stdout.seek(0)
2327 sys.stdout.truncate(0)
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002328 git_cl._GitCookiesChecker().print_current_creds(include_netrc=False)
2329 self.assertEqual(list(sys.stdout.getvalue().splitlines()), [
2330 ' Host\tUser\t Which file',
2331 '============================\t====\t===========',
2332 'host-review.googlesource.com\tuser\t.gitcookies',
2333 ' host.googlesource.com\tuser\t.gitcookies',
2334 ])
2335
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002336 def _common_creds_check_mocks(self):
2337 def exists_mock(path):
2338 dirname = os.path.dirname(path)
2339 if dirname == os.path.expanduser('~'):
2340 dirname = '~'
2341 base = os.path.basename(path)
2342 if base in ('.netrc', '.gitcookies'):
2343 return self._mocked_call('os.path.exists', '%s/%s' % (dirname, base))
2344 # git cl also checks for existence other files not relevant to this test.
2345 return None
Edward Lemurda4b6c62020-02-13 00:28:40 +00002346 mock.patch('os.path.exists', exists_mock).start()
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002347
2348 def test_creds_check_gitcookies_not_configured(self):
2349 self._common_creds_check_mocks()
Edward Lemurda4b6c62020-02-13 00:28:40 +00002350 mock.patch('git_cl._GitCookiesChecker.get_hosts_with_creds',
2351 lambda _, include_netrc=False: []).start()
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002352 self.calls = [
Aaron Gable8797cab2018-03-06 13:55:00 -08002353 ((['git', 'config', '--path', 'http.cookiefile'],), CERR1),
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002354 ((['git', 'config', '--global', 'http.cookiefile'],), CERR1),
2355 (('os.path.exists', '~/.netrc'), True),
2356 (('ask_for_data', 'Press Enter to setup .gitcookies, '
2357 'or Ctrl+C to abort'), ''),
2358 ((['git', 'config', '--global', 'http.cookiefile',
2359 os.path.expanduser('~/.gitcookies')], ), ''),
2360 ]
2361 self.assertEqual(0, git_cl.main(['creds-check']))
Edward Lemur73c76702020-02-06 23:57:18 +00002362 self.assertTrue(
2363 sys.stdout.getvalue().startswith(
2364 'You seem to be using outdated .netrc for git credentials:'))
2365 self.assertIn(
2366 '\nConfigured git to use .gitcookies from',
2367 sys.stdout.getvalue())
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002368
2369 def test_creds_check_gitcookies_configured_custom_broken(self):
2370 self._common_creds_check_mocks()
Edward Lemurda4b6c62020-02-13 00:28:40 +00002371 mock.patch('git_cl._GitCookiesChecker.get_hosts_with_creds',
2372 lambda _, include_netrc=False: []).start()
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002373 self.calls = [
Aaron Gable8797cab2018-03-06 13:55:00 -08002374 ((['git', 'config', '--path', 'http.cookiefile'],), CERR1),
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002375 ((['git', 'config', '--global', 'http.cookiefile'],),
2376 '/custom/.gitcookies'),
2377 (('os.path.exists', '/custom/.gitcookies'), False),
2378 (('ask_for_data', 'Reconfigure git to use default .gitcookies? '
2379 'Press Enter to reconfigure, or Ctrl+C to abort'), ''),
2380 ((['git', 'config', '--global', 'http.cookiefile',
2381 os.path.expanduser('~/.gitcookies')], ), ''),
2382 ]
2383 self.assertEqual(0, git_cl.main(['creds-check']))
Edward Lemur73c76702020-02-06 23:57:18 +00002384 self.assertIn(
2385 'WARNING: You have configured custom path to .gitcookies: ',
2386 sys.stdout.getvalue())
2387 self.assertIn(
2388 'However, your configured .gitcookies file is missing.',
2389 sys.stdout.getvalue())
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002390
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002391 def test_git_cl_comment_add_gerrit(self):
Edward Lemur85153282020-02-14 22:06:29 +00002392 self.mockGit.branchref = None
Edward Lemur26964072020-02-19 19:18:51 +00002393 self.mockGit.config['remote.origin.url'] = (
2394 'https://chromium.googlesource.com/infra/infra')
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002395 self.calls = [
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002396 (('SetReview', 'chromium-review.googlesource.com', 'infra%2Finfra~10',
Edward Lemurda4b6c62020-02-13 00:28:40 +00002397 'msg', None, None, None),
Aaron Gable636b13f2017-07-14 10:42:48 -07002398 None),
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002399 ]
Edward Lemur52969c92020-02-06 18:15:28 +00002400 self.assertEqual(0, git_cl.main(['comment', '-i', '10', '-a', 'msg']))
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002401
Edward Lemurda4b6c62020-02-13 00:28:40 +00002402 @mock.patch('git_cl.Changelist.GetBranch', return_value='foo')
2403 def test_git_cl_comments_fetch_gerrit(self, *_mocks):
Edward Lemur26964072020-02-19 19:18:51 +00002404 self.mockGit.config['remote.origin.url'] = (
2405 'https://chromium.googlesource.com/infra/infra')
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002406 gerrit_util.GetChangeDetail.return_value = {
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002407 'owner': {'email': 'owner@example.com'},
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002408 'current_revision': 'ba5eba11',
2409 'revisions': {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002410 'deadbeaf': {
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002411 '_number': 1,
2412 },
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002413 'ba5eba11': {
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002414 '_number': 2,
2415 },
2416 },
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002417 'messages': [
2418 {
2419 u'_revision_number': 1,
2420 u'author': {
2421 u'_account_id': 1111084,
2422 u'email': u'commit-bot@chromium.org',
2423 u'name': u'Commit Bot'
2424 },
2425 u'date': u'2017-03-15 20:08:45.000000000',
2426 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046dc50b',
Dirk Prankef6a58802017-10-17 12:49:42 -07002427 u'message': u'Patch Set 1:\n\nDry run: CQ is trying the patch...',
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002428 u'tag': u'autogenerated:cq:dry-run'
2429 },
2430 {
2431 u'_revision_number': 2,
2432 u'author': {
2433 u'_account_id': 11151243,
2434 u'email': u'owner@example.com',
2435 u'name': u'owner'
2436 },
2437 u'date': u'2017-03-16 20:00:41.000000000',
2438 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2439 u'message': u'PTAL',
2440 },
2441 {
2442 u'_revision_number': 2,
2443 u'author': {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002444 u'_account_id': 148512,
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002445 u'email': u'reviewer@example.com',
2446 u'name': u'reviewer'
2447 },
2448 u'date': u'2017-03-17 05:19:37.500000000',
2449 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d4568',
2450 u'message': u'Patch Set 2: Code-Review+1',
2451 },
2452 ]
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002453 }
2454 self.calls = [
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002455 (('GetChangeComments', 'chromium-review.googlesource.com',
2456 'infra%2Finfra~1'), {
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002457 '/COMMIT_MSG': [
2458 {
2459 'author': {'email': u'reviewer@example.com'},
2460 'updated': u'2017-03-17 05:19:37.500000000',
2461 'patch_set': 2,
2462 'side': 'REVISION',
2463 'message': 'Please include a bug link',
2464 },
2465 ],
2466 'codereview.settings': [
2467 {
2468 'author': {'email': u'owner@example.com'},
2469 'updated': u'2017-03-16 20:00:41.000000000',
2470 'patch_set': 2,
2471 'side': 'PARENT',
2472 'line': 42,
2473 'message': 'I removed this because it is bad',
2474 },
2475 ]
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002476 }),
2477 (('GetChangeRobotComments', 'chromium-review.googlesource.com',
2478 'infra%2Finfra~1'), {}),
Leszek Swirski45b20c42018-09-17 17:05:26 +00002479 ] * 2 + [
2480 (('write_json', 'output.json', [
2481 {
2482 u'date': u'2017-03-16 20:00:41.000000',
2483 u'message': (
2484 u'PTAL\n' +
2485 u'\n' +
2486 u'codereview.settings\n' +
2487 u' Base, Line 42: https://chromium-review.googlesource.com/' +
2488 u'c/1/2/codereview.settings#b42\n' +
2489 u' I removed this because it is bad\n'),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002490 u'autogenerated': False,
Leszek Swirski45b20c42018-09-17 17:05:26 +00002491 u'approval': False,
2492 u'disapproval': False,
2493 u'sender': u'owner@example.com'
2494 }, {
2495 u'date': u'2017-03-17 05:19:37.500000',
2496 u'message': (
2497 u'Patch Set 2: Code-Review+1\n' +
2498 u'\n' +
2499 u'/COMMIT_MSG\n' +
2500 u' PS2, File comment: https://chromium-review.googlesource' +
2501 u'.com/c/1/2//COMMIT_MSG#\n' +
2502 u' Please include a bug link\n'),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002503 u'autogenerated': False,
Leszek Swirski45b20c42018-09-17 17:05:26 +00002504 u'approval': False,
2505 u'disapproval': False,
2506 u'sender': u'reviewer@example.com'
2507 }
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002508 ]), '')
Leszek Swirski45b20c42018-09-17 17:05:26 +00002509 ]
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002510 expected_comments_summary = [
2511 git_cl._CommentSummary(
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002512 message=(
2513 u'PTAL\n' +
2514 u'\n' +
2515 u'codereview.settings\n' +
2516 u' Base, Line 42: https://chromium-review.googlesource.com/' +
2517 u'c/1/2/codereview.settings#b42\n' +
2518 u' I removed this because it is bad\n'),
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002519 date=datetime.datetime(2017, 3, 16, 20, 0, 41, 0),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002520 autogenerated=False,
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002521 disapproval=False, approval=False, sender=u'owner@example.com'),
2522 git_cl._CommentSummary(
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002523 message=(
2524 u'Patch Set 2: Code-Review+1\n' +
2525 u'\n' +
2526 u'/COMMIT_MSG\n' +
2527 u' PS2, File comment: https://chromium-review.googlesource.com/' +
2528 u'c/1/2//COMMIT_MSG#\n' +
2529 u' Please include a bug link\n'),
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002530 date=datetime.datetime(2017, 3, 17, 5, 19, 37, 500000),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002531 autogenerated=False,
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002532 disapproval=False, approval=False, sender=u'reviewer@example.com'),
2533 ]
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002534 cl = git_cl.Changelist(
Edward Lemurf38bc172019-09-03 21:02:13 +00002535 issue=1, branchref='refs/heads/foo')
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002536 self.assertEqual(cl.GetCommentsSummary(), expected_comments_summary)
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002537 self.assertEqual(
2538 0, git_cl.main(['comments', '-i', '1', '-j', 'output.json']))
2539
2540 def test_git_cl_comments_robot_comments(self):
2541 # git cl comments also fetches robot comments (which are considered a type
2542 # of autogenerated comment), and unlike other types of comments, only robot
2543 # comments from the latest patchset are shown.
Edward Lemur26964072020-02-19 19:18:51 +00002544 self.mockGit.config['remote.origin.url'] = (
2545 'https://chromium.googlesource.com/infra/infra')
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002546 gerrit_util.GetChangeDetail.return_value = {
2547 'owner': {'email': 'owner@example.com'},
2548 'current_revision': 'ba5eba11',
2549 'revisions': {
2550 'deadbeaf': {
2551 '_number': 1,
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002552 },
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002553 'ba5eba11': {
2554 '_number': 2,
2555 },
2556 },
2557 'messages': [
2558 {
2559 u'_revision_number': 1,
2560 u'author': {
2561 u'_account_id': 1111084,
2562 u'email': u'commit-bot@chromium.org',
2563 u'name': u'Commit Bot'
2564 },
2565 u'date': u'2017-03-15 20:08:45.000000000',
2566 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046dc50b',
2567 u'message': u'Patch Set 1:\n\nDry run: CQ is trying the patch...',
2568 u'tag': u'autogenerated:cq:dry-run'
2569 },
2570 {
2571 u'_revision_number': 1,
2572 u'author': {
2573 u'_account_id': 123,
2574 u'email': u'tricium@serviceaccount.com',
2575 u'name': u'Tricium'
2576 },
2577 u'date': u'2017-03-16 20:00:41.000000000',
2578 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2579 u'message': u'(1 comment)',
2580 u'tag': u'autogenerated:tricium',
2581 },
2582 {
2583 u'_revision_number': 1,
2584 u'author': {
2585 u'_account_id': 123,
2586 u'email': u'tricium@serviceaccount.com',
2587 u'name': u'Tricium'
2588 },
2589 u'date': u'2017-03-16 20:00:41.000000000',
2590 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2591 u'message': u'(1 comment)',
2592 u'tag': u'autogenerated:tricium',
2593 },
2594 {
2595 u'_revision_number': 2,
2596 u'author': {
2597 u'_account_id': 123,
2598 u'email': u'tricium@serviceaccount.com',
2599 u'name': u'reviewer'
2600 },
2601 u'date': u'2017-03-17 05:30:37.000000000',
2602 u'tag': u'autogenerated:tricium',
2603 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d4568',
2604 u'message': u'(1 comment)',
2605 },
2606 ]
2607 }
2608 self.calls = [
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002609 (('GetChangeComments', 'chromium-review.googlesource.com',
2610 'infra%2Finfra~1'), {}),
2611 (('GetChangeRobotComments', 'chromium-review.googlesource.com',
2612 'infra%2Finfra~1'), {
2613 'codereview.settings': [
2614 {
2615 u'author': {u'email': u'tricium@serviceaccount.com'},
2616 u'updated': u'2017-03-17 05:30:37.000000000',
2617 u'robot_run_id': u'5565031076855808',
2618 u'robot_id': u'Linter/Category',
2619 u'tag': u'autogenerated:tricium',
2620 u'patch_set': 2,
2621 u'side': u'REVISION',
2622 u'message': u'Linter warning message text',
2623 u'line': 32,
2624 },
2625 ],
2626 }),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002627 ]
2628 expected_comments_summary = [
2629 git_cl._CommentSummary(date=datetime.datetime(2017, 3, 17, 5, 30, 37),
2630 message=(
2631 u'(1 comment)\n\ncodereview.settings\n'
2632 u' PS2, Line 32: https://chromium-review.googlesource.com/'
2633 u'c/1/2/codereview.settings#32\n'
2634 u' Linter warning message text\n'),
2635 sender=u'tricium@serviceaccount.com',
2636 autogenerated=True, approval=False, disapproval=False)
2637 ]
2638 cl = git_cl.Changelist(
Edward Lemurf38bc172019-09-03 21:02:13 +00002639 issue=1, branchref='refs/heads/foo')
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002640 self.assertEqual(cl.GetCommentsSummary(), expected_comments_summary)
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002641
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002642 def test_get_remote_url_with_mirror(self):
2643 original_os_path_isdir = os.path.isdir
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002644
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002645 def selective_os_path_isdir_mock(path):
2646 if path == '/cache/this-dir-exists':
2647 return self._mocked_call('os.path.isdir', path)
2648 return original_os_path_isdir(path)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002649
Edward Lemurda4b6c62020-02-13 00:28:40 +00002650 mock.patch('os.path.isdir', selective_os_path_isdir_mock).start()
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002651
2652 url = 'https://chromium.googlesource.com/my/repo'
Edward Lemur26964072020-02-19 19:18:51 +00002653 self.mockGit.config['remote.origin.url'] = (
2654 '/cache/this-dir-exists')
2655 self.mockGit.config['/cache/this-dir-exists:remote.origin.url'] = (
2656 url)
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002657 self.calls = [
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002658 (('os.path.isdir', '/cache/this-dir-exists'),
2659 True),
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002660 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002661 cl = git_cl.Changelist(issue=1)
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002662 self.assertEqual(cl.GetRemoteUrl(), url)
2663 self.assertEqual(cl.GetRemoteUrl(), url) # Must be cached.
2664
Edward Lemur298f2cf2019-02-22 21:40:39 +00002665 def test_get_remote_url_non_existing_mirror(self):
2666 original_os_path_isdir = os.path.isdir
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002667
Edward Lemur298f2cf2019-02-22 21:40:39 +00002668 def selective_os_path_isdir_mock(path):
2669 if path == '/cache/this-dir-doesnt-exist':
2670 return self._mocked_call('os.path.isdir', path)
2671 return original_os_path_isdir(path)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002672
Edward Lemurda4b6c62020-02-13 00:28:40 +00002673 mock.patch('os.path.isdir', selective_os_path_isdir_mock).start()
2674 mock.patch('logging.error',
2675 lambda *a: self._mocked_call('logging.error', *a)).start()
Edward Lemur298f2cf2019-02-22 21:40:39 +00002676
Edward Lemur26964072020-02-19 19:18:51 +00002677 self.mockGit.config['remote.origin.url'] = (
2678 '/cache/this-dir-doesnt-exist')
Edward Lemur298f2cf2019-02-22 21:40:39 +00002679 self.calls = [
Edward Lemur298f2cf2019-02-22 21:40:39 +00002680 (('os.path.isdir', '/cache/this-dir-doesnt-exist'),
2681 False),
2682 (('logging.error',
Josip906bfde2020-01-31 22:38:49 +00002683 'Remote "%(remote)s" for branch "%(branch)s" points to "%(url)s", '
2684 'but it doesn\'t exist.', {
2685 'remote': 'origin',
2686 'branch': 'master',
2687 'url': '/cache/this-dir-doesnt-exist'}
2688 ), None),
Edward Lemur298f2cf2019-02-22 21:40:39 +00002689 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002690 cl = git_cl.Changelist(issue=1)
Edward Lemur298f2cf2019-02-22 21:40:39 +00002691 self.assertIsNone(cl.GetRemoteUrl())
2692
2693 def test_get_remote_url_misconfigured_mirror(self):
2694 original_os_path_isdir = os.path.isdir
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002695
Edward Lemur298f2cf2019-02-22 21:40:39 +00002696 def selective_os_path_isdir_mock(path):
2697 if path == '/cache/this-dir-exists':
2698 return self._mocked_call('os.path.isdir', path)
2699 return original_os_path_isdir(path)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002700
Edward Lemurda4b6c62020-02-13 00:28:40 +00002701 mock.patch('os.path.isdir', selective_os_path_isdir_mock).start()
2702 mock.patch('logging.error',
2703 lambda *a: self._mocked_call('logging.error', *a)).start()
Edward Lemur298f2cf2019-02-22 21:40:39 +00002704
Edward Lemur26964072020-02-19 19:18:51 +00002705 self.mockGit.config['remote.origin.url'] = (
2706 '/cache/this-dir-exists')
Edward Lemur298f2cf2019-02-22 21:40:39 +00002707 self.calls = [
Edward Lemur298f2cf2019-02-22 21:40:39 +00002708 (('os.path.isdir', '/cache/this-dir-exists'), True),
Edward Lemur298f2cf2019-02-22 21:40:39 +00002709 (('logging.error',
2710 'Remote "%(remote)s" for branch "%(branch)s" points to '
2711 '"%(cache_path)s", but it is misconfigured.\n'
2712 '"%(cache_path)s" must be a git repo and must have a remote named '
2713 '"%(remote)s" pointing to the git host.', {
2714 'remote': 'origin',
2715 'cache_path': '/cache/this-dir-exists',
2716 'branch': 'master'}
2717 ), None),
2718 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002719 cl = git_cl.Changelist(issue=1)
Edward Lemur298f2cf2019-02-22 21:40:39 +00002720 self.assertIsNone(cl.GetRemoteUrl())
2721
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002722 def test_gerrit_change_identifier_with_project(self):
Edward Lemur26964072020-02-19 19:18:51 +00002723 self.mockGit.config['remote.origin.url'] = (
2724 'https://chromium.googlesource.com/a/my/repo.git/')
Edward Lemurf38bc172019-09-03 21:02:13 +00002725 cl = git_cl.Changelist(issue=123456)
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002726 self.assertEqual(cl._GerritChangeIdentifier(), 'my%2Frepo~123456')
2727
2728 def test_gerrit_change_identifier_without_project(self):
Edward Lemurda4b6c62020-02-13 00:28:40 +00002729 mock.patch('logging.error',
2730 lambda *a: self._mocked_call('logging.error', *a)).start()
Josip906bfde2020-01-31 22:38:49 +00002731
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002732 self.calls = [
Josip906bfde2020-01-31 22:38:49 +00002733 (('logging.error',
2734 'Remote "%(remote)s" for branch "%(branch)s" points to "%(url)s", '
2735 'but it doesn\'t exist.', {
2736 'remote': 'origin',
2737 'branch': 'master',
2738 'url': ''}
2739 ), None),
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002740 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002741 cl = git_cl.Changelist(issue=123456)
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002742 self.assertEqual(cl._GerritChangeIdentifier(), '123456')
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00002743
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002744
Edward Lemurbaaf6be2019-10-09 18:00:44 +00002745class CMDTestCaseBase(unittest.TestCase):
2746 _STATUSES = [
2747 'STATUS_UNSPECIFIED', 'SCHEDULED', 'STARTED', 'SUCCESS', 'FAILURE',
2748 'INFRA_FAILURE', 'CANCELED',
2749 ]
2750 _CHANGE_DETAIL = {
2751 'project': 'depot_tools',
2752 'status': 'OPEN',
2753 'owner': {'email': 'owner@e.mail'},
2754 'current_revision': 'beeeeeef',
2755 'revisions': {
2756 'deadbeaf': {'_number': 6},
2757 'beeeeeef': {
2758 '_number': 7,
2759 'fetch': {'http': {
2760 'url': 'https://chromium.googlesource.com/depot_tools',
2761 'ref': 'refs/changes/56/123456/7'
2762 }},
2763 },
2764 },
2765 }
2766 _DEFAULT_RESPONSE = {
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00002767 'builds': [{
2768 'id': str(100 + idx),
2769 'builder': {
2770 'project': 'chromium',
2771 'bucket': 'try',
2772 'builder': 'bot_' + status.lower(),
2773 },
2774 'createTime': '2019-10-09T08:00:0%d.854286Z' % (idx % 10),
2775 'tags': [],
2776 'status': status,
2777 } for idx, status in enumerate(_STATUSES)]
Edward Lemurbaaf6be2019-10-09 18:00:44 +00002778 }
2779
Edward Lemur4c707a22019-09-24 21:13:43 +00002780 def setUp(self):
Edward Lemurbaaf6be2019-10-09 18:00:44 +00002781 super(CMDTestCaseBase, self).setUp()
Edward Lemur79d4f992019-11-11 23:49:02 +00002782 mock.patch('git_cl.sys.stdout', StringIO()).start()
Edward Lemurbaaf6be2019-10-09 18:00:44 +00002783 mock.patch('git_cl.uuid.uuid4', return_value='uuid4').start()
2784 mock.patch('git_cl.Changelist.GetIssue', return_value=123456).start()
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002785 mock.patch(
2786 'git_cl.Changelist.GetCodereviewServer',
2787 return_value='https://chromium-review.googlesource.com').start()
2788 mock.patch(
2789 'git_cl.Changelist._GetGerritHost',
2790 return_value='chromium-review.googlesource.com').start()
2791 mock.patch(
2792 'git_cl.Changelist.GetMostRecentPatchset',
2793 return_value=7).start()
2794 mock.patch(
2795 'git_cl.Changelist.GetRemoteUrl',
2796 return_value='https://chromium.googlesource.com/depot_tools').start()
2797 mock.patch(
2798 'auth.Authenticator',
2799 return_value=AuthenticatorMock()).start()
2800 mock.patch(
2801 'gerrit_util.GetChangeDetail',
2802 return_value=self._CHANGE_DETAIL).start()
2803 mock.patch(
2804 'git_cl._call_buildbucket',
2805 return_value = self._DEFAULT_RESPONSE).start()
Edward Lemurbaaf6be2019-10-09 18:00:44 +00002806 mock.patch('git_common.is_dirty_git_tree', return_value=False).start()
Edward Lemur4c707a22019-09-24 21:13:43 +00002807 self.addCleanup(mock.patch.stopall)
2808
Edward Lemur4c707a22019-09-24 21:13:43 +00002809
Edward Lemurbaaf6be2019-10-09 18:00:44 +00002810class CMDTryResultsTestCase(CMDTestCaseBase):
2811 _DEFAULT_REQUEST = {
2812 'predicate': {
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00002813 "gerritChanges": [{
2814 "project": "depot_tools",
2815 "host": "chromium-review.googlesource.com",
2816 "patchset": 7,
2817 "change": 123456,
2818 }],
Edward Lemurbaaf6be2019-10-09 18:00:44 +00002819 },
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00002820 'fields': ('builds.*.id,builds.*.builder,builds.*.status' +
2821 ',builds.*.createTime,builds.*.tags'),
Edward Lemurbaaf6be2019-10-09 18:00:44 +00002822 }
2823
2824 def testNoJobs(self):
2825 git_cl._call_buildbucket.return_value = {}
2826
2827 self.assertEqual(0, git_cl.main(['try-results']))
2828 self.assertEqual('No tryjobs scheduled.\n', sys.stdout.getvalue())
2829 git_cl._call_buildbucket.assert_called_once_with(
2830 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
2831 self._DEFAULT_REQUEST)
2832
2833 def testPrintToStdout(self):
2834 self.assertEqual(0, git_cl.main(['try-results']))
2835 self.assertEqual([
2836 'Successes:',
2837 ' bot_success https://ci.chromium.org/b/103',
2838 'Infra Failures:',
2839 ' bot_infra_failure https://ci.chromium.org/b/105',
2840 'Failures:',
2841 ' bot_failure https://ci.chromium.org/b/104',
2842 'Canceled:',
2843 ' bot_canceled ',
2844 'Started:',
2845 ' bot_started https://ci.chromium.org/b/102',
2846 'Scheduled:',
2847 ' bot_scheduled id=101',
2848 'Other:',
2849 ' bot_status_unspecified id=100',
2850 'Total: 7 tryjobs',
2851 ], sys.stdout.getvalue().splitlines())
2852 git_cl._call_buildbucket.assert_called_once_with(
2853 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
2854 self._DEFAULT_REQUEST)
2855
2856 def testPrintToStdoutWithMasters(self):
2857 self.assertEqual(0, git_cl.main(['try-results', '--print-master']))
2858 self.assertEqual([
2859 'Successes:',
2860 ' try bot_success https://ci.chromium.org/b/103',
2861 'Infra Failures:',
2862 ' try bot_infra_failure https://ci.chromium.org/b/105',
2863 'Failures:',
2864 ' try bot_failure https://ci.chromium.org/b/104',
2865 'Canceled:',
2866 ' try bot_canceled ',
2867 'Started:',
2868 ' try bot_started https://ci.chromium.org/b/102',
2869 'Scheduled:',
2870 ' try bot_scheduled id=101',
2871 'Other:',
2872 ' try bot_status_unspecified id=100',
2873 'Total: 7 tryjobs',
2874 ], sys.stdout.getvalue().splitlines())
2875 git_cl._call_buildbucket.assert_called_once_with(
2876 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
2877 self._DEFAULT_REQUEST)
2878
2879 @mock.patch('git_cl.write_json')
2880 def testWriteToJson(self, mockJsonDump):
2881 self.assertEqual(0, git_cl.main(['try-results', '--json', 'file.json']))
2882 git_cl._call_buildbucket.assert_called_once_with(
2883 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
2884 self._DEFAULT_REQUEST)
2885 mockJsonDump.assert_called_once_with(
2886 'file.json', self._DEFAULT_RESPONSE['builds'])
2887
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00002888 def test_filter_failed_for_one_simple(self):
2889 self.assertEqual({}, git_cl._filter_failed_for_retry([]))
Edward Lemurbaaf6be2019-10-09 18:00:44 +00002890 self.assertEqual({
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00002891 'chromium/try': {
2892 'bot_failure': [],
2893 'bot_infra_failure': []
2894 },
2895 }, git_cl._filter_failed_for_retry(self._DEFAULT_RESPONSE['builds']))
2896
2897 def test_filter_failed_for_retry_many_builds(self):
2898
2899 def _build(name, created_sec, status, experimental=False):
2900 assert 0 <= created_sec < 100, created_sec
2901 b = {
2902 'id': 112112,
2903 'builder': {
2904 'project': 'chromium',
2905 'bucket': 'try',
2906 'builder': name,
2907 },
2908 'createTime': '2019-10-09T08:00:%02d.854286Z' % created_sec,
2909 'status': status,
2910 'tags': [],
2911 }
2912 if experimental:
2913 b['tags'].append({'key': 'cq_experimental', 'value': 'true'})
2914 return b
2915
2916 builds = [
2917 _build('flaky-last-green', 1, 'FAILURE'),
2918 _build('flaky-last-green', 2, 'SUCCESS'),
2919 _build('flaky', 1, 'SUCCESS'),
2920 _build('flaky', 2, 'FAILURE'),
2921 _build('running', 1, 'FAILED'),
2922 _build('running', 2, 'SCHEDULED'),
2923 _build('yep-still-running', 1, 'STARTED'),
2924 _build('yep-still-running', 2, 'FAILURE'),
2925 _build('cq-experimental', 1, 'SUCCESS', experimental=True),
2926 _build('cq-experimental', 2, 'FAILURE', experimental=True),
2927
2928 # Simulate experimental in CQ builder, which developer decided
2929 # to retry manually which resulted in 2nd build non-experimental.
2930 _build('sometimes-experimental', 1, 'FAILURE', experimental=True),
2931 _build('sometimes-experimental', 2, 'FAILURE', experimental=False),
2932 ]
2933 builds.sort(key=lambda b: b['status']) # ~deterministic shuffle.
2934 self.assertEqual({
2935 'chromium/try': {
2936 'flaky': [],
2937 'sometimes-experimental': []
2938 },
2939 }, git_cl._filter_failed_for_retry(builds))
Edward Lemurbaaf6be2019-10-09 18:00:44 +00002940
2941
2942class CMDTryTestCase(CMDTestCaseBase):
2943
2944 @mock.patch('git_cl.Changelist.SetCQState')
2945 @mock.patch('git_cl._get_bucket_map', return_value={})
2946 def testSetCQDryRunByDefault(self, _mockGetBucketMap, mockSetCQState):
2947 mockSetCQState.return_value = 0
Edward Lemur4c707a22019-09-24 21:13:43 +00002948 self.assertEqual(0, git_cl.main(['try']))
2949 git_cl.Changelist.SetCQState.assert_called_with(git_cl._CQState.DRY_RUN)
2950 self.assertEqual(
2951 sys.stdout.getvalue(),
2952 'Scheduling CQ dry run on: '
2953 'https://chromium-review.googlesource.com/123456\n')
2954
Edward Lemur4c707a22019-09-24 21:13:43 +00002955 @mock.patch('git_cl._call_buildbucket')
Edward Lemurbaaf6be2019-10-09 18:00:44 +00002956 def testScheduleOnBuildbucket(self, mockCallBuildbucket):
Edward Lemur4c707a22019-09-24 21:13:43 +00002957 mockCallBuildbucket.return_value = {}
Edward Lemur4c707a22019-09-24 21:13:43 +00002958
2959 self.assertEqual(0, git_cl.main([
2960 'try', '-B', 'luci.chromium.try', '-b', 'win',
2961 '-p', 'key=val', '-p', 'json=[{"a":1}, null]']))
2962 self.assertIn(
2963 'Scheduling jobs on:\nBucket: luci.chromium.try',
2964 git_cl.sys.stdout.getvalue())
2965
2966 expected_request = {
2967 "requests": [{
2968 "scheduleBuild": {
2969 "requestId": "uuid4",
2970 "builder": {
2971 "project": "chromium",
2972 "builder": "win",
2973 "bucket": "try",
2974 },
2975 "gerritChanges": [{
2976 "project": "depot_tools",
2977 "host": "chromium-review.googlesource.com",
2978 "patchset": 7,
2979 "change": 123456,
2980 }],
2981 "properties": {
2982 "category": "git_cl_try",
2983 "json": [{"a": 1}, None],
2984 "key": "val",
2985 },
2986 "tags": [
2987 {"value": "win", "key": "builder"},
2988 {"value": "git_cl_try", "key": "user_agent"},
2989 ],
2990 },
2991 }],
2992 }
2993 mockCallBuildbucket.assert_called_with(
2994 mock.ANY, 'cr-buildbucket.appspot.com', 'Batch', expected_request)
2995
Anthony Polito1a5fe232020-01-24 23:17:52 +00002996 @mock.patch('git_cl._call_buildbucket')
2997 def testScheduleOnBuildbucketWithRevision(self, mockCallBuildbucket):
2998 mockCallBuildbucket.return_value = {}
2999
3000 self.assertEqual(0, git_cl.main([
3001 'try', '-B', 'luci.chromium.try', '-b', 'win', '-b', 'linux',
3002 '-p', 'key=val', '-p', 'json=[{"a":1}, null]',
3003 '-r', 'beeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeef']))
3004 self.assertIn(
3005 'Scheduling jobs on:\nBucket: luci.chromium.try',
3006 git_cl.sys.stdout.getvalue())
3007
3008 expected_request = {
3009 "requests": [{
3010 "scheduleBuild": {
3011 "requestId": "uuid4",
3012 "builder": {
3013 "project": "chromium",
3014 "builder": "linux",
3015 "bucket": "try",
3016 },
3017 "gerritChanges": [{
3018 "project": "depot_tools",
3019 "host": "chromium-review.googlesource.com",
3020 "patchset": 7,
3021 "change": 123456,
3022 }],
3023 "properties": {
3024 "category": "git_cl_try",
3025 "json": [{"a": 1}, None],
3026 "key": "val",
3027 },
3028 "tags": [
3029 {"value": "linux", "key": "builder"},
3030 {"value": "git_cl_try", "key": "user_agent"},
3031 ],
3032 "gitilesCommit": {
3033 "host": "chromium-review.googlesource.com",
3034 "project": "depot_tools",
3035 "id": "beeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeef",
3036 }
3037 },
3038 },
3039 {
3040 "scheduleBuild": {
3041 "requestId": "uuid4",
3042 "builder": {
3043 "project": "chromium",
3044 "builder": "win",
3045 "bucket": "try",
3046 },
3047 "gerritChanges": [{
3048 "project": "depot_tools",
3049 "host": "chromium-review.googlesource.com",
3050 "patchset": 7,
3051 "change": 123456,
3052 }],
3053 "properties": {
3054 "category": "git_cl_try",
3055 "json": [{"a": 1}, None],
3056 "key": "val",
3057 },
3058 "tags": [
3059 {"value": "win", "key": "builder"},
3060 {"value": "git_cl_try", "key": "user_agent"},
3061 ],
3062 "gitilesCommit": {
3063 "host": "chromium-review.googlesource.com",
3064 "project": "depot_tools",
3065 "id": "beeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeef",
3066 }
3067 },
3068 }],
3069 }
3070 mockCallBuildbucket.assert_called_with(
3071 mock.ANY, 'cr-buildbucket.appspot.com', 'Batch', expected_request)
3072
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003073 def testScheduleOnBuildbucket_WrongBucket(self):
Edward Lemur4c707a22019-09-24 21:13:43 +00003074 self.assertEqual(0, git_cl.main([
3075 'try', '-B', 'not-a-bucket', '-b', 'win',
3076 '-p', 'key=val', '-p', 'json=[{"a":1}, null]']))
3077 self.assertIn(
3078 'WARNING Could not parse bucket "not-a-bucket". Skipping.',
3079 git_cl.sys.stdout.getvalue())
3080
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003081 @mock.patch('git_cl._call_buildbucket')
3082 @mock.patch('git_cl.fetch_try_jobs')
3083 def testScheduleOnBuildbucketRetryFailed(
3084 self, mockFetchTryJobs, mockCallBuildbucket):
3085
3086 git_cl.fetch_try_jobs.side_effect = lambda *_, **kw: {
3087 7: [],
3088 6: [{
3089 'id': 112112,
3090 'builder': {
3091 'project': 'chromium',
3092 'bucket': 'try',
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003093 'builder': 'linux',},
3094 'createTime': '2019-10-09T08:00:01.854286Z',
3095 'tags': [],
3096 'status': 'FAILURE',}],}[kw['patchset']]
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003097 mockCallBuildbucket.return_value = {}
3098
3099 self.assertEqual(0, git_cl.main(['try', '--retry-failed']))
3100 self.assertIn(
3101 'Scheduling jobs on:\nBucket: chromium/try',
3102 git_cl.sys.stdout.getvalue())
3103
3104 expected_request = {
3105 "requests": [{
3106 "scheduleBuild": {
3107 "requestId": "uuid4",
3108 "builder": {
3109 "project": "chromium",
3110 "bucket": "try",
3111 "builder": "linux",
3112 },
3113 "gerritChanges": [{
3114 "project": "depot_tools",
3115 "host": "chromium-review.googlesource.com",
3116 "patchset": 7,
3117 "change": 123456,
3118 }],
3119 "properties": {
3120 "category": "git_cl_try",
3121 },
3122 "tags": [
3123 {"value": "linux", "key": "builder"},
3124 {"value": "git_cl_try", "key": "user_agent"},
3125 {"value": "1", "key": "retry_failed"},
3126 ],
3127 },
3128 }],
3129 }
3130 mockCallBuildbucket.assert_called_with(
3131 mock.ANY, 'cr-buildbucket.appspot.com', 'Batch', expected_request)
3132
Edward Lemur4c707a22019-09-24 21:13:43 +00003133 def test_parse_bucket(self):
3134 test_cases = [
3135 {
3136 'bucket': 'chromium/try',
3137 'result': ('chromium', 'try'),
3138 },
3139 {
3140 'bucket': 'luci.chromium.try',
3141 'result': ('chromium', 'try'),
3142 'has_warning': True,
3143 },
3144 {
3145 'bucket': 'skia.primary',
3146 'result': ('skia', 'skia.primary'),
3147 'has_warning': True,
3148 },
3149 {
3150 'bucket': 'not-a-bucket',
3151 'result': (None, None),
3152 },
3153 ]
3154
3155 for test_case in test_cases:
3156 git_cl.sys.stdout.truncate(0)
3157 self.assertEqual(
3158 test_case['result'], git_cl._parse_bucket(test_case['bucket']))
3159 if test_case.get('has_warning'):
Edward Lemur6215c792019-10-03 21:59:05 +00003160 expected_warning = 'WARNING Please use %s/%s to specify the bucket' % (
3161 test_case['result'])
3162 self.assertIn(expected_warning, git_cl.sys.stdout.getvalue())
Edward Lemur4c707a22019-09-24 21:13:43 +00003163
3164
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003165class CMDUploadTestCase(CMDTestCaseBase):
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003166 def setUp(self):
3167 super(CMDUploadTestCase, self).setUp()
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003168 mock.patch('git_cl.fetch_try_jobs').start()
3169 mock.patch('git_cl._trigger_try_jobs', return_value={}).start()
3170 mock.patch('git_cl.Changelist.CMDUpload', return_value=0).start()
Anthony Polito46689b02019-11-15 20:56:41 +00003171 mock.patch('git_cl.Settings.GetIsGerrit', return_value=True).start()
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003172 self.addCleanup(mock.patch.stopall)
3173
Edward Lesmes7677e5c2020-02-19 20:39:03 +00003174 def testWarmUpChangeDetailCache(self):
3175 self.assertEqual(0, git_cl.main(['upload']))
3176 gerrit_util.GetChangeDetail.assert_called_once_with(
3177 'chromium-review.googlesource.com', 'depot_tools~123456',
3178 frozenset([
3179 'LABELS', 'CURRENT_REVISION', 'DETAILED_ACCOUNTS',
3180 'CURRENT_COMMIT']))
3181
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003182 def testUploadRetryFailed(self):
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003183 # This test mocks out the actual upload part, and just asserts that after
3184 # upload, if --retry-failed is added, then the tool will fetch try jobs
3185 # from the previous patchset and trigger the right builders on the latest
3186 # patchset.
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003187 git_cl.fetch_try_jobs.side_effect = [
3188 # Latest patchset: No builds.
3189 [],
3190 # Patchset before latest: Some builds.
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003191 [{
3192 'id': str(100 + idx),
3193 'builder': {
3194 'project': 'chromium',
3195 'bucket': 'try',
3196 'builder': 'bot_' + status.lower(),
3197 },
3198 'createTime': '2019-10-09T08:00:0%d.854286Z' % (idx % 10),
3199 'tags': [],
3200 'status': status,
3201 } for idx, status in enumerate(self._STATUSES)],
Andrii Shyshkalov1ad58112019-10-08 01:46:14 +00003202 ]
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003203
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003204 self.assertEqual(0, git_cl.main(['upload', '--retry-failed']))
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003205 self.assertEqual([
Edward Lemur5b929a42019-10-21 17:57:39 +00003206 mock.call(mock.ANY, 'cr-buildbucket.appspot.com', patchset=7),
3207 mock.call(mock.ANY, 'cr-buildbucket.appspot.com', patchset=6),
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003208 ], git_cl.fetch_try_jobs.mock_calls)
3209 expected_buckets = {
3210 'chromium/try': {'bot_failure': [], 'bot_infra_failure': []},
3211 }
3212 git_cl._trigger_try_jobs.assert_called_once_with(
Edward Lemur5b929a42019-10-21 17:57:39 +00003213 mock.ANY, expected_buckets, mock.ANY, 8)
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003214
Brian Sheedy59b06a82019-10-14 17:03:29 +00003215
Edward Lemurda4b6c62020-02-13 00:28:40 +00003216class CMDFormatTestCase(unittest.TestCase):
Brian Sheedy59b06a82019-10-14 17:03:29 +00003217
3218 def setUp(self):
3219 super(CMDFormatTestCase, self).setUp()
Jamie Madill5e96ad12020-01-13 16:08:35 +00003220 mock.patch('git_cl.RunCommand').start()
3221 mock.patch('clang_format.FindClangFormatToolInChromiumTree').start()
3222 mock.patch('clang_format.FindClangFormatScriptInChromiumTree').start()
3223 mock.patch('git_cl.settings').start()
Brian Sheedy59b06a82019-10-14 17:03:29 +00003224 self._top_dir = tempfile.mkdtemp()
Jamie Madill5e96ad12020-01-13 16:08:35 +00003225 self.addCleanup(mock.patch.stopall)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003226
3227 def tearDown(self):
3228 shutil.rmtree(self._top_dir)
3229 super(CMDFormatTestCase, self).tearDown()
3230
Jamie Madill5e96ad12020-01-13 16:08:35 +00003231 def _make_temp_file(self, fname, contents):
3232 with open(os.path.join(self._top_dir, fname), 'w') as tf:
3233 tf.write('\n'.join(contents))
3234
Brian Sheedy59b06a82019-10-14 17:03:29 +00003235 def _make_yapfignore(self, contents):
Jamie Madill5e96ad12020-01-13 16:08:35 +00003236 self._make_temp_file('.yapfignore', contents)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003237
Brian Sheedyb4307d52019-12-02 19:18:17 +00003238 def _check_yapf_filtering(self, files, expected):
3239 self.assertEqual(expected, git_cl._FilterYapfIgnoredFiles(
3240 files, git_cl._GetYapfIgnorePatterns(self._top_dir)))
Brian Sheedy59b06a82019-10-14 17:03:29 +00003241
Jamie Madill5e96ad12020-01-13 16:08:35 +00003242 def testClangFormatDiffFull(self):
3243 self._make_temp_file('test.cc', ['// test'])
3244 git_cl.settings.GetFormatFullByDefault.return_value = False
3245 diff_file = [os.path.join(self._top_dir, 'test.cc')]
3246 mock_opts = mock.Mock(full=True, dry_run=True, diff=False)
3247
3248 # Diff
3249 git_cl.RunCommand.return_value = ' // test'
3250 return_value = git_cl._RunClangFormatDiff(mock_opts, diff_file,
3251 self._top_dir, 'HEAD')
3252 self.assertEqual(2, return_value)
3253
3254 # No diff
3255 git_cl.RunCommand.return_value = '// test'
3256 return_value = git_cl._RunClangFormatDiff(mock_opts, diff_file,
3257 self._top_dir, 'HEAD')
3258 self.assertEqual(0, return_value)
3259
3260 def testClangFormatDiff(self):
3261 git_cl.settings.GetFormatFullByDefault.return_value = False
3262 mock_opts = mock.Mock(full=False, dry_run=True, diff=False)
3263
3264 # Diff
3265 git_cl.RunCommand.return_value = 'error'
3266 return_value = git_cl._RunClangFormatDiff(mock_opts, ['.'], self._top_dir,
3267 'HEAD')
3268 self.assertEqual(2, return_value)
3269
3270 # No diff
3271 git_cl.RunCommand.return_value = ''
3272 return_value = git_cl._RunClangFormatDiff(mock_opts, ['.'], self._top_dir,
3273 'HEAD')
3274 self.assertEqual(0, return_value)
3275
Brian Sheedyb4307d52019-12-02 19:18:17 +00003276 def testYapfignoreExplicit(self):
3277 self._make_yapfignore(['foo/bar.py', 'foo/bar/baz.py'])
3278 files = [
3279 'bar.py',
3280 'foo/bar.py',
3281 'foo/baz.py',
3282 'foo/bar/baz.py',
3283 'foo/bar/foobar.py',
3284 ]
3285 expected = [
3286 'bar.py',
3287 'foo/baz.py',
3288 'foo/bar/foobar.py',
3289 ]
3290 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003291
Brian Sheedyb4307d52019-12-02 19:18:17 +00003292 def testYapfignoreSingleWildcards(self):
3293 self._make_yapfignore(['*bar.py', 'foo*', 'baz*.py'])
3294 files = [
3295 'bar.py', # Matched by *bar.py.
3296 'bar.txt',
3297 'foobar.py', # Matched by *bar.py, foo*.
3298 'foobar.txt', # Matched by foo*.
3299 'bazbar.py', # Matched by *bar.py, baz*.py.
3300 'bazbar.txt',
3301 'foo/baz.txt', # Matched by foo*.
3302 'bar/bar.py', # Matched by *bar.py.
3303 'baz/foo.py', # Matched by baz*.py, foo*.
3304 'baz/foo.txt',
3305 ]
3306 expected = [
3307 'bar.txt',
3308 'bazbar.txt',
3309 'baz/foo.txt',
3310 ]
3311 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003312
Brian Sheedyb4307d52019-12-02 19:18:17 +00003313 def testYapfignoreMultiplewildcards(self):
3314 self._make_yapfignore(['*bar*', '*foo*baz.txt'])
3315 files = [
3316 'bar.py', # Matched by *bar*.
3317 'bar.txt', # Matched by *bar*.
3318 'abar.py', # Matched by *bar*.
3319 'foobaz.txt', # Matched by *foo*baz.txt.
3320 'foobaz.py',
3321 'afoobaz.txt', # Matched by *foo*baz.txt.
3322 ]
3323 expected = [
3324 'foobaz.py',
3325 ]
3326 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003327
3328 def testYapfignoreComments(self):
3329 self._make_yapfignore(['test.py', '#test2.py'])
Brian Sheedyb4307d52019-12-02 19:18:17 +00003330 files = [
3331 'test.py',
3332 'test2.py',
3333 ]
3334 expected = [
3335 'test2.py',
3336 ]
3337 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003338
3339 def testYapfignoreBlankLines(self):
3340 self._make_yapfignore(['test.py', '', '', 'test2.py'])
Brian Sheedyb4307d52019-12-02 19:18:17 +00003341 files = [
3342 'test.py',
3343 'test2.py',
3344 'test3.py',
3345 ]
3346 expected = [
3347 'test3.py',
3348 ]
3349 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003350
3351 def testYapfignoreWhitespace(self):
3352 self._make_yapfignore([' test.py '])
Brian Sheedyb4307d52019-12-02 19:18:17 +00003353 files = [
3354 'test.py',
3355 'test2.py',
3356 ]
3357 expected = [
3358 'test2.py',
3359 ]
3360 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003361
Brian Sheedyb4307d52019-12-02 19:18:17 +00003362 def testYapfignoreNoFiles(self):
Brian Sheedy59b06a82019-10-14 17:03:29 +00003363 self._make_yapfignore(['test.py'])
Brian Sheedyb4307d52019-12-02 19:18:17 +00003364 self._check_yapf_filtering([], [])
3365
3366 def testYapfignoreMissingYapfignore(self):
3367 files = [
3368 'test.py',
3369 ]
3370 expected = [
3371 'test.py',
3372 ]
3373 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003374
3375
maruel@chromium.orgddd59412011-11-30 14:20:38 +00003376if __name__ == '__main__':
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +01003377 logging.basicConfig(
3378 level=logging.DEBUG if '-v' in sys.argv else logging.ERROR)
maruel@chromium.orgddd59412011-11-30 14:20:38 +00003379 unittest.main()