Josip Sokcevic | 4de5dea | 2022-03-23 21:15:14 +0000 | [diff] [blame] | 1 | #!/usr/bin/env python3 |
maruel@chromium.org | 3bbf294 | 2012-01-10 16:52:06 +0000 | [diff] [blame] | 2 | # Copyright (c) 2012 The Chromium Authors. All rights reserved. |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 3 | # Use of this source code is governed by a BSD-style license that can be |
| 4 | # found in the LICENSE file. |
| 5 | |
| 6 | """Enables directory-specific presubmit checks to run at upload and/or commit. |
| 7 | """ |
| 8 | |
Raul Tambre | 80ee78e | 2019-05-06 22:41:05 +0000 | [diff] [blame] | 9 | from __future__ import print_function |
| 10 | |
Saagar Sanghavi | 9981690 | 2020-08-11 22:41:25 +0000 | [diff] [blame] | 11 | __version__ = '2.0.0' |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 12 | |
| 13 | # TODO(joi) Add caching where appropriate/needed. The API is designed to allow |
| 14 | # caching (between all different invocations of presubmit scripts for a given |
| 15 | # change). We should add it as our presubmit scripts start feeling slow. |
| 16 | |
Edward Lemur | a5799e3 | 2020-01-17 19:26:51 +0000 | [diff] [blame] | 17 | import argparse |
Takeshi Yoshino | 07a6bea | 2017-08-02 02:44:06 +0900 | [diff] [blame] | 18 | import ast # Exposed through the API. |
iannucci@chromium.org | 8a4a2bc | 2013-03-08 08:13:20 +0000 | [diff] [blame] | 19 | import contextlib |
Yoshisato Yanagisawa | 406de13 | 2018-06-29 05:43:25 +0000 | [diff] [blame] | 20 | import cpplint |
dcheng | 091b7db | 2016-06-16 01:27:51 -0700 | [diff] [blame] | 21 | import fnmatch # Exposed through the API. |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 22 | import glob |
asvitkine@chromium.org | 1516995 | 2011-09-27 14:30:53 +0000 | [diff] [blame] | 23 | import inspect |
machenbach@chromium.org | 58a69cb | 2014-03-01 02:08:29 +0000 | [diff] [blame] | 24 | import itertools |
maruel@chromium.org | 4f6852c | 2012-04-20 20:39:20 +0000 | [diff] [blame] | 25 | import json # Exposed through the API. |
maruel@chromium.org | df1595a | 2009-06-11 02:00:13 +0000 | [diff] [blame] | 26 | import logging |
ilevy@chromium.org | bc11731 | 2013-04-20 03:57:56 +0000 | [diff] [blame] | 27 | import multiprocessing |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 28 | import os # Somewhat exposed through the API. |
maruel@chromium.org | ce8e46b | 2009-06-26 22:31:51 +0000 | [diff] [blame] | 29 | import random |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 30 | import re # Exposed through the API. |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 31 | import signal |
Allen Webb | fe7d709 | 2021-05-18 02:05:49 +0000 | [diff] [blame] | 32 | import six |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 33 | import sys # Parts exposed through API. |
| 34 | import tempfile # Exposed through the API. |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 35 | import threading |
jam@chromium.org | 2a891dc | 2009-08-20 20:33:37 +0000 | [diff] [blame] | 36 | import time |
Edward Lemur | de9e3ca | 2019-10-24 21:13:31 +0000 | [diff] [blame] | 37 | import traceback |
maruel@chromium.org | 1487d53 | 2009-06-06 00:22:57 +0000 | [diff] [blame] | 38 | import unittest # Exposed through the API. |
maruel@chromium.org | cb2985f | 2010-11-03 14:08:31 +0000 | [diff] [blame] | 39 | from warnings import warn |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 40 | |
| 41 | # Local imports. |
maruel@chromium.org | 35625c7 | 2011-03-23 17:34:02 +0000 | [diff] [blame] | 42 | import fix_encoding |
Yoshisato Yanagisawa | 04600b4 | 2019-03-15 03:03:41 +0000 | [diff] [blame] | 43 | import gclient_paths # Exposed through the API |
| 44 | import gclient_utils |
Josip Sokcevic | 7958e30 | 2023-03-01 23:02:21 +0000 | [diff] [blame] | 45 | import git_footers |
tandrii@chromium.org | 015ebae | 2016-04-25 19:37:22 +0000 | [diff] [blame] | 46 | import gerrit_util |
Edward Lesmes | 9ce03f8 | 2021-01-12 20:13:31 +0000 | [diff] [blame] | 47 | import owners_client |
Jochen Eisinger | 76f5fc6 | 2017-04-07 16:27:46 +0200 | [diff] [blame] | 48 | import owners_finder |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 49 | import presubmit_canned_checks |
Saagar Sanghavi | 9949ab7 | 2020-07-20 20:56:40 +0000 | [diff] [blame] | 50 | import rdb_wrapper |
Josip Sokcevic | 7958e30 | 2023-03-01 23:02:21 +0000 | [diff] [blame] | 51 | import scm |
maruel@chromium.org | 84f4fe3 | 2011-04-06 13:26:45 +0000 | [diff] [blame] | 52 | import subprocess2 as subprocess # Exposed through the API. |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 53 | |
Edward Lemur | 16af356 | 2019-10-17 22:11:33 +0000 | [diff] [blame] | 54 | if sys.version_info.major == 2: |
| 55 | # TODO(1009814): Expose urllib2 only through urllib_request and urllib_error |
| 56 | import urllib2 # Exposed through the API. |
| 57 | import urlparse |
| 58 | import urllib2 as urllib_request |
| 59 | import urllib2 as urllib_error |
| 60 | else: |
| 61 | import urllib.parse as urlparse |
| 62 | import urllib.request as urllib_request |
| 63 | import urllib.error as urllib_error |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 64 | |
maruel@chromium.org | ce8e46b | 2009-06-26 22:31:51 +0000 | [diff] [blame] | 65 | # Ask for feedback only once in program lifetime. |
| 66 | _ASKED_FOR_FEEDBACK = False |
| 67 | |
Bruce Dawson | dca14bc | 2022-09-15 20:59:38 +0000 | [diff] [blame] | 68 | # Set if super-verbose mode is requested, for tracking where presubmit messages |
| 69 | # are coming from. |
| 70 | _SHOW_CALLSTACKS = False |
| 71 | |
| 72 | |
Edward Lemur | ecc2707 | 2020-01-06 16:42:34 +0000 | [diff] [blame] | 73 | def time_time(): |
| 74 | # Use this so that it can be mocked in tests without interfering with python |
| 75 | # system machinery. |
| 76 | return time.time() |
| 77 | |
| 78 | |
maruel@chromium.org | 899e1c1 | 2011-04-07 17:03:18 +0000 | [diff] [blame] | 79 | class PresubmitFailure(Exception): |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 80 | pass |
| 81 | |
| 82 | |
maruel@chromium.org | ffeb2f3 | 2013-12-03 13:55:22 +0000 | [diff] [blame] | 83 | class CommandData(object): |
Edward Lemur | 940c282 | 2019-08-23 00:34:25 +0000 | [diff] [blame] | 84 | def __init__(self, name, cmd, kwargs, message, python3=False): |
maruel@chromium.org | ffeb2f3 | 2013-12-03 13:55:22 +0000 | [diff] [blame] | 85 | self.name = name |
| 86 | self.cmd = cmd |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 87 | self.stdin = kwargs.get('stdin', None) |
Edward Lemur | 2d6b67c | 2019-08-23 22:25:41 +0000 | [diff] [blame] | 88 | self.kwargs = kwargs.copy() |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 89 | self.kwargs['stdout'] = subprocess.PIPE |
| 90 | self.kwargs['stderr'] = subprocess.STDOUT |
| 91 | self.kwargs['stdin'] = subprocess.PIPE |
maruel@chromium.org | ffeb2f3 | 2013-12-03 13:55:22 +0000 | [diff] [blame] | 92 | self.message = message |
| 93 | self.info = None |
Edward Lemur | 940c282 | 2019-08-23 00:34:25 +0000 | [diff] [blame] | 94 | self.python3 = python3 |
maruel@chromium.org | ffeb2f3 | 2013-12-03 13:55:22 +0000 | [diff] [blame] | 95 | |
ilevy@chromium.org | bc11731 | 2013-04-20 03:57:56 +0000 | [diff] [blame] | 96 | |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 97 | # Adapted from |
| 98 | # https://github.com/google/gtest-parallel/blob/master/gtest_parallel.py#L37 |
| 99 | # |
| 100 | # An object that catches SIGINT sent to the Python process and notices |
| 101 | # if processes passed to wait() die by SIGINT (we need to look for |
| 102 | # both of those cases, because pressing Ctrl+C can result in either |
| 103 | # the main process or one of the subprocesses getting the signal). |
| 104 | # |
| 105 | # Before a SIGINT is seen, wait(p) will simply call p.wait() and |
| 106 | # return the result. Once a SIGINT has been seen (in the main process |
| 107 | # or a subprocess, including the one the current call is waiting for), |
Edward Lemur | 9a5bb61 | 2019-09-26 02:01:52 +0000 | [diff] [blame] | 108 | # wait(p) will call p.terminate(). |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 109 | class SigintHandler(object): |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 110 | sigint_returncodes = {-signal.SIGINT, # Unix |
| 111 | -1073741510, # Windows |
| 112 | } |
| 113 | def __init__(self): |
| 114 | self.__lock = threading.Lock() |
| 115 | self.__processes = set() |
| 116 | self.__got_sigint = False |
Edward Lemur | 9a5bb61 | 2019-09-26 02:01:52 +0000 | [diff] [blame] | 117 | self.__previous_signal = signal.signal(signal.SIGINT, self.interrupt) |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 118 | |
| 119 | def __on_sigint(self): |
| 120 | self.__got_sigint = True |
| 121 | while self.__processes: |
| 122 | try: |
| 123 | self.__processes.pop().terminate() |
| 124 | except OSError: |
| 125 | pass |
| 126 | |
Edward Lemur | 9a5bb61 | 2019-09-26 02:01:52 +0000 | [diff] [blame] | 127 | def interrupt(self, signal_num, frame): |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 128 | with self.__lock: |
| 129 | self.__on_sigint() |
Edward Lemur | 9a5bb61 | 2019-09-26 02:01:52 +0000 | [diff] [blame] | 130 | self.__previous_signal(signal_num, frame) |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 131 | |
| 132 | def got_sigint(self): |
| 133 | with self.__lock: |
| 134 | return self.__got_sigint |
| 135 | |
| 136 | def wait(self, p, stdin): |
| 137 | with self.__lock: |
| 138 | if self.__got_sigint: |
| 139 | p.terminate() |
| 140 | self.__processes.add(p) |
| 141 | stdout, stderr = p.communicate(stdin) |
| 142 | code = p.returncode |
| 143 | with self.__lock: |
| 144 | self.__processes.discard(p) |
| 145 | if code in self.sigint_returncodes: |
| 146 | self.__on_sigint() |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 147 | return stdout, stderr |
| 148 | |
| 149 | sigint_handler = SigintHandler() |
| 150 | |
| 151 | |
Edward Lemur | ecc2707 | 2020-01-06 16:42:34 +0000 | [diff] [blame] | 152 | class Timer(object): |
| 153 | def __init__(self, timeout, fn): |
| 154 | self.completed = False |
| 155 | self._fn = fn |
| 156 | self._timer = threading.Timer(timeout, self._onTimer) if timeout else None |
| 157 | |
| 158 | def __enter__(self): |
| 159 | if self._timer: |
| 160 | self._timer.start() |
| 161 | return self |
| 162 | |
| 163 | def __exit__(self, _type, _value, _traceback): |
| 164 | if self._timer: |
| 165 | self._timer.cancel() |
| 166 | |
| 167 | def _onTimer(self): |
| 168 | self._fn() |
| 169 | self.completed = True |
| 170 | |
| 171 | |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 172 | class ThreadPool(object): |
Edward Lemur | ecc2707 | 2020-01-06 16:42:34 +0000 | [diff] [blame] | 173 | def __init__(self, pool_size=None, timeout=None): |
| 174 | self.timeout = timeout |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 175 | self._pool_size = pool_size or multiprocessing.cpu_count() |
Bruce Dawson | 8254f06 | 2022-06-17 17:33:08 +0000 | [diff] [blame] | 176 | if sys.platform == 'win32': |
| 177 | # TODO(crbug.com/1190269) - we can't use more than 56 child processes on |
| 178 | # Windows or Python3 may hang. |
| 179 | self._pool_size = min(self._pool_size, 56) |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 180 | self._messages = [] |
| 181 | self._messages_lock = threading.Lock() |
| 182 | self._tests = [] |
| 183 | self._tests_lock = threading.Lock() |
| 184 | self._nonparallel_tests = [] |
| 185 | |
Edward Lemur | ecc2707 | 2020-01-06 16:42:34 +0000 | [diff] [blame] | 186 | def _GetCommand(self, test): |
Edward Lemur | 940c282 | 2019-08-23 00:34:25 +0000 | [diff] [blame] | 187 | vpython = 'vpython' |
| 188 | if test.python3: |
| 189 | vpython += '3' |
| 190 | if sys.platform == 'win32': |
| 191 | vpython += '.bat' |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 192 | |
| 193 | cmd = test.cmd |
| 194 | if cmd[0] == 'python': |
| 195 | cmd = list(cmd) |
| 196 | cmd[0] = vpython |
| 197 | elif cmd[0].endswith('.py'): |
| 198 | cmd = [vpython] + cmd |
| 199 | |
Edward Lemur | 336e51f | 2019-11-14 21:42:04 +0000 | [diff] [blame] | 200 | # On Windows, scripts on the current directory take precedence over PATH, so |
| 201 | # that when testing depot_tools on Windows, calling `vpython.bat` will |
| 202 | # execute the copy of vpython of the depot_tools under test instead of the |
| 203 | # one in the bot. |
| 204 | # As a workaround, we run the tests from the parent directory instead. |
| 205 | if (cmd[0] == vpython and |
| 206 | 'cwd' in test.kwargs and |
| 207 | os.path.basename(test.kwargs['cwd']) == 'depot_tools'): |
| 208 | test.kwargs['cwd'] = os.path.dirname(test.kwargs['cwd']) |
| 209 | cmd[1] = os.path.join('depot_tools', cmd[1]) |
| 210 | |
Edward Lemur | ecc2707 | 2020-01-06 16:42:34 +0000 | [diff] [blame] | 211 | return cmd |
| 212 | |
| 213 | def _RunWithTimeout(self, cmd, stdin, kwargs): |
| 214 | p = subprocess.Popen(cmd, **kwargs) |
| 215 | with Timer(self.timeout, p.terminate) as timer: |
| 216 | stdout, _ = sigint_handler.wait(p, stdin) |
Josip Sokcevic | 6635baf | 2021-11-19 02:04:39 +0000 | [diff] [blame] | 217 | stdout = stdout.decode('utf-8', 'ignore') |
Edward Lemur | ecc2707 | 2020-01-06 16:42:34 +0000 | [diff] [blame] | 218 | if timer.completed: |
| 219 | stdout = 'Process timed out after %ss\n%s' % (self.timeout, stdout) |
Josip Sokcevic | 6635baf | 2021-11-19 02:04:39 +0000 | [diff] [blame] | 220 | return p.returncode, stdout |
Edward Lemur | ecc2707 | 2020-01-06 16:42:34 +0000 | [diff] [blame] | 221 | |
Josip Sokcevic | a4b871e | 2023-05-18 14:27:56 +0000 | [diff] [blame] | 222 | def CallCommand(self, test, show_callstack=None): |
Edward Lemur | ecc2707 | 2020-01-06 16:42:34 +0000 | [diff] [blame] | 223 | """Runs an external program. |
| 224 | |
Edward Lemur | a5799e3 | 2020-01-17 19:26:51 +0000 | [diff] [blame] | 225 | This function converts invocation of .py files and invocations of 'python' |
Edward Lemur | ecc2707 | 2020-01-06 16:42:34 +0000 | [diff] [blame] | 226 | to vpython invocations. |
| 227 | """ |
| 228 | cmd = self._GetCommand(test) |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 229 | try: |
Edward Lemur | ecc2707 | 2020-01-06 16:42:34 +0000 | [diff] [blame] | 230 | start = time_time() |
| 231 | returncode, stdout = self._RunWithTimeout(cmd, test.stdin, test.kwargs) |
| 232 | duration = time_time() - start |
Edward Lemur | 7cf9438 | 2019-11-15 22:36:41 +0000 | [diff] [blame] | 233 | except Exception: |
Edward Lemur | ecc2707 | 2020-01-06 16:42:34 +0000 | [diff] [blame] | 234 | duration = time_time() - start |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 235 | return test.message( |
Josip Sokcevic | a4b871e | 2023-05-18 14:27:56 +0000 | [diff] [blame] | 236 | '%s\n%s exec failure (%4.2fs)\n%s' % |
| 237 | (test.name, ' '.join(cmd), duration, traceback.format_exc()), |
| 238 | show_callstack=show_callstack) |
Edward Lemur | de9e3ca | 2019-10-24 21:13:31 +0000 | [diff] [blame] | 239 | |
Edward Lemur | ecc2707 | 2020-01-06 16:42:34 +0000 | [diff] [blame] | 240 | if returncode != 0: |
Josip Sokcevic | a4b871e | 2023-05-18 14:27:56 +0000 | [diff] [blame] | 241 | return test.message('%s\n%s (%4.2fs) failed\n%s' % |
| 242 | (test.name, ' '.join(cmd), duration, stdout), |
| 243 | show_callstack=show_callstack) |
Edward Lemur | ecc2707 | 2020-01-06 16:42:34 +0000 | [diff] [blame] | 244 | |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 245 | if test.info: |
Josip Sokcevic | a4b871e | 2023-05-18 14:27:56 +0000 | [diff] [blame] | 246 | return test.info('%s\n%s (%4.2fs)' % (test.name, ' '.join(cmd), duration), |
| 247 | show_callstack=show_callstack) |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 248 | |
| 249 | def AddTests(self, tests, parallel=True): |
| 250 | if parallel: |
| 251 | self._tests.extend(tests) |
| 252 | else: |
| 253 | self._nonparallel_tests.extend(tests) |
| 254 | |
| 255 | def RunAsync(self): |
| 256 | self._messages = [] |
| 257 | |
| 258 | def _WorkerFn(): |
| 259 | while True: |
| 260 | test = None |
| 261 | with self._tests_lock: |
| 262 | if not self._tests: |
| 263 | break |
| 264 | test = self._tests.pop() |
Josip Sokcevic | a4b871e | 2023-05-18 14:27:56 +0000 | [diff] [blame] | 265 | result = self.CallCommand(test, show_callstack=False) |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 266 | if result: |
| 267 | with self._messages_lock: |
| 268 | self._messages.append(result) |
| 269 | |
| 270 | def _StartDaemon(): |
| 271 | t = threading.Thread(target=_WorkerFn) |
| 272 | t.daemon = True |
| 273 | t.start() |
| 274 | return t |
| 275 | |
| 276 | while self._nonparallel_tests: |
| 277 | test = self._nonparallel_tests.pop() |
| 278 | result = self.CallCommand(test) |
| 279 | if result: |
| 280 | self._messages.append(result) |
| 281 | |
| 282 | if self._tests: |
| 283 | threads = [_StartDaemon() for _ in range(self._pool_size)] |
| 284 | for worker in threads: |
| 285 | worker.join() |
| 286 | |
| 287 | return self._messages |
| 288 | |
| 289 | |
Josip Sokcevic | a9a7eec | 2023-03-10 03:54:52 +0000 | [diff] [blame] | 290 | def normpath(path): |
| 291 | '''Version of os.path.normpath that also changes backward slashes to |
| 292 | forward slashes when not running on Windows. |
| 293 | ''' |
| 294 | # This is safe to always do because the Windows version of os.path.normpath |
| 295 | # will replace forward slashes with backward slashes. |
| 296 | path = path.replace(os.sep, '/') |
| 297 | return os.path.normpath(path) |
| 298 | |
| 299 | |
Josip Sokcevic | 7958e30 | 2023-03-01 23:02:21 +0000 | [diff] [blame] | 300 | def _RightHandSideLinesImpl(affected_files): |
| 301 | """Implements RightHandSideLines for InputApi and GclChange.""" |
| 302 | for af in affected_files: |
| 303 | lines = af.ChangedContents() |
| 304 | for line in lines: |
| 305 | yield (af, line[0], line[1]) |
| 306 | |
| 307 | |
Edward Lemur | 6eb1d32 | 2020-02-27 22:20:15 +0000 | [diff] [blame] | 308 | def prompt_should_continue(prompt_string): |
| 309 | sys.stdout.write(prompt_string) |
Dirk Pranke | 7288f88 | 2021-06-03 18:01:30 +0000 | [diff] [blame] | 310 | sys.stdout.flush() |
Edward Lemur | 6eb1d32 | 2020-02-27 22:20:15 +0000 | [diff] [blame] | 311 | response = sys.stdin.readline().strip().lower() |
| 312 | return response in ('y', 'yes') |
dpranke@chromium.org | 5ac2101 | 2011-03-16 02:58:25 +0000 | [diff] [blame] | 313 | |
Josip Sokcevic | 967cf67 | 2023-05-10 17:09:58 +0000 | [diff] [blame] | 314 | |
ilevy@chromium.org | bc11731 | 2013-04-20 03:57:56 +0000 | [diff] [blame] | 315 | # Top level object so multiprocessing can pickle |
| 316 | # Public access through OutputApi object. |
| 317 | class _PresubmitResult(object): |
| 318 | """Base class for result objects.""" |
| 319 | fatal = False |
| 320 | should_prompt = False |
| 321 | |
Josip Sokcevic | a4b871e | 2023-05-18 14:27:56 +0000 | [diff] [blame] | 322 | def __init__(self, message, items=None, long_text='', show_callstack=None): |
ilevy@chromium.org | bc11731 | 2013-04-20 03:57:56 +0000 | [diff] [blame] | 323 | """ |
| 324 | message: A short one-line message to indicate errors. |
| 325 | items: A list of short strings to indicate where errors occurred. |
| 326 | long_text: multi-line text output, e.g. from another tool |
| 327 | """ |
Bruce Dawson | db8622b | 2022-04-03 15:38:12 +0000 | [diff] [blame] | 328 | self._message = _PresubmitResult._ensure_str(message) |
ilevy@chromium.org | bc11731 | 2013-04-20 03:57:56 +0000 | [diff] [blame] | 329 | self._items = items or [] |
Tom McKee | 61c7265 | 2021-07-20 11:56:32 +0000 | [diff] [blame] | 330 | self._long_text = _PresubmitResult._ensure_str(long_text.rstrip()) |
Josip Sokcevic | a4b871e | 2023-05-18 14:27:56 +0000 | [diff] [blame] | 331 | if show_callstack is None: |
| 332 | show_callstack = _SHOW_CALLSTACKS |
| 333 | if show_callstack: |
Bruce Dawson | dca14bc | 2022-09-15 20:59:38 +0000 | [diff] [blame] | 334 | self._long_text += 'Presubmit result call stack is:\n' |
| 335 | self._long_text += ''.join(traceback.format_stack(None, 8)) |
Tom McKee | 61c7265 | 2021-07-20 11:56:32 +0000 | [diff] [blame] | 336 | |
| 337 | @staticmethod |
| 338 | def _ensure_str(val): |
| 339 | """ |
| 340 | val: A "stringish" value. Can be any of str, unicode or bytes. |
| 341 | returns: A str after applying encoding/decoding as needed. |
| 342 | Assumes/uses UTF-8 for relevant inputs/outputs. |
| 343 | |
| 344 | We'd prefer to use six.ensure_str but our copy of six is old :( |
| 345 | """ |
| 346 | if isinstance(val, str): |
| 347 | return val |
Aravind Vasudevan | c5f0cbb | 2022-01-24 23:56:57 +0000 | [diff] [blame] | 348 | |
Tom McKee | 61c7265 | 2021-07-20 11:56:32 +0000 | [diff] [blame] | 349 | if six.PY2 and isinstance(val, unicode): |
| 350 | return val.encode() |
Aravind Vasudevan | c5f0cbb | 2022-01-24 23:56:57 +0000 | [diff] [blame] | 351 | |
| 352 | if six.PY3 and isinstance(val, bytes): |
Tom McKee | 61c7265 | 2021-07-20 11:56:32 +0000 | [diff] [blame] | 353 | return val.decode() |
| 354 | raise ValueError("Unknown string type %s" % type(val)) |
ilevy@chromium.org | bc11731 | 2013-04-20 03:57:56 +0000 | [diff] [blame] | 355 | |
Edward Lemur | 6eb1d32 | 2020-02-27 22:20:15 +0000 | [diff] [blame] | 356 | def handle(self): |
| 357 | sys.stdout.write(self._message) |
| 358 | sys.stdout.write('\n') |
Takuto Ikuta | baa7be0 | 2022-08-23 00:19:34 +0000 | [diff] [blame] | 359 | for item in self._items: |
Edward Lemur | 6eb1d32 | 2020-02-27 22:20:15 +0000 | [diff] [blame] | 360 | sys.stdout.write(' ') |
ilevy@chromium.org | bc11731 | 2013-04-20 03:57:56 +0000 | [diff] [blame] | 361 | # Write separately in case it's unicode. |
Edward Lemur | 6eb1d32 | 2020-02-27 22:20:15 +0000 | [diff] [blame] | 362 | sys.stdout.write(str(item)) |
Edward Lemur | 6eb1d32 | 2020-02-27 22:20:15 +0000 | [diff] [blame] | 363 | sys.stdout.write('\n') |
ilevy@chromium.org | bc11731 | 2013-04-20 03:57:56 +0000 | [diff] [blame] | 364 | if self._long_text: |
Edward Lemur | 6eb1d32 | 2020-02-27 22:20:15 +0000 | [diff] [blame] | 365 | sys.stdout.write('\n***************\n') |
ilevy@chromium.org | bc11731 | 2013-04-20 03:57:56 +0000 | [diff] [blame] | 366 | # Write separately in case it's unicode. |
Tom McKee | 61c7265 | 2021-07-20 11:56:32 +0000 | [diff] [blame] | 367 | sys.stdout.write(self._long_text) |
Edward Lemur | 6eb1d32 | 2020-02-27 22:20:15 +0000 | [diff] [blame] | 368 | sys.stdout.write('\n***************\n') |
ilevy@chromium.org | bc11731 | 2013-04-20 03:57:56 +0000 | [diff] [blame] | 369 | |
Debrian Figueroa | dd2737e | 2019-06-21 23:50:13 +0000 | [diff] [blame] | 370 | def json_format(self): |
| 371 | return { |
| 372 | 'message': self._message, |
Debrian Figueroa | 6095d40 | 2019-06-28 18:47:18 +0000 | [diff] [blame] | 373 | 'items': [str(item) for item in self._items], |
Debrian Figueroa | dd2737e | 2019-06-21 23:50:13 +0000 | [diff] [blame] | 374 | 'long_text': self._long_text, |
| 375 | 'fatal': self.fatal |
| 376 | } |
| 377 | |
ilevy@chromium.org | bc11731 | 2013-04-20 03:57:56 +0000 | [diff] [blame] | 378 | |
| 379 | # Top level object so multiprocessing can pickle |
| 380 | # Public access through OutputApi object. |
ilevy@chromium.org | bc11731 | 2013-04-20 03:57:56 +0000 | [diff] [blame] | 381 | class _PresubmitError(_PresubmitResult): |
| 382 | """A hard presubmit error.""" |
| 383 | fatal = True |
| 384 | |
| 385 | |
| 386 | # Top level object so multiprocessing can pickle |
| 387 | # Public access through OutputApi object. |
| 388 | class _PresubmitPromptWarning(_PresubmitResult): |
| 389 | """An warning that prompts the user if they want to continue.""" |
| 390 | should_prompt = True |
| 391 | |
| 392 | |
| 393 | # Top level object so multiprocessing can pickle |
| 394 | # Public access through OutputApi object. |
| 395 | class _PresubmitNotifyResult(_PresubmitResult): |
| 396 | """Just print something to the screen -- but it's not even a warning.""" |
ilevy@chromium.org | bc11731 | 2013-04-20 03:57:56 +0000 | [diff] [blame] | 397 | |
| 398 | |
| 399 | # Top level object so multiprocessing can pickle |
| 400 | # Public access through OutputApi object. |
| 401 | class _MailTextResult(_PresubmitResult): |
| 402 | """A warning that should be included in the review request email.""" |
| 403 | def __init__(self, *args, **kwargs): |
| 404 | super(_MailTextResult, self).__init__() |
| 405 | raise NotImplementedError() |
| 406 | |
tandrii@chromium.org | 37b07a7 | 2016-04-29 16:42:28 +0000 | [diff] [blame] | 407 | class GerritAccessor(object): |
| 408 | """Limited Gerrit functionality for canned presubmit checks to work. |
| 409 | |
| 410 | To avoid excessive Gerrit calls, caches the results. |
| 411 | """ |
| 412 | |
Edward Lesmes | eb1bd62 | 2021-03-01 19:54:07 +0000 | [diff] [blame] | 413 | def __init__(self, url=None, project=None, branch=None): |
| 414 | self.host = urlparse.urlparse(url).netloc if url else None |
| 415 | self.project = project |
| 416 | self.branch = branch |
tandrii@chromium.org | 37b07a7 | 2016-04-29 16:42:28 +0000 | [diff] [blame] | 417 | self.cache = {} |
Edward Lesmes | 8170c29 | 2021-03-19 20:04:43 +0000 | [diff] [blame] | 418 | self.code_owners_enabled = None |
tandrii@chromium.org | 37b07a7 | 2016-04-29 16:42:28 +0000 | [diff] [blame] | 419 | |
| 420 | def _FetchChangeDetail(self, issue): |
| 421 | # Separate function to be easily mocked in tests. |
Andrii Shyshkalov | c6c8b4c | 2016-11-09 20:51:20 +0100 | [diff] [blame] | 422 | try: |
| 423 | return gerrit_util.GetChangeDetail( |
| 424 | self.host, str(issue), |
Aaron Gable | 6f5a8d9 | 2017-04-18 14:49:05 -0700 | [diff] [blame] | 425 | ['ALL_REVISIONS', 'DETAILED_LABELS', 'ALL_COMMITS']) |
Andrii Shyshkalov | c6c8b4c | 2016-11-09 20:51:20 +0100 | [diff] [blame] | 426 | except gerrit_util.GerritError as e: |
| 427 | if e.http_status == 404: |
| 428 | raise Exception('Either Gerrit issue %s doesn\'t exist, or ' |
| 429 | 'no credentials to fetch issue details' % issue) |
| 430 | raise |
tandrii@chromium.org | 37b07a7 | 2016-04-29 16:42:28 +0000 | [diff] [blame] | 431 | |
| 432 | def GetChangeInfo(self, issue): |
| 433 | """Returns labels and all revisions (patchsets) for this issue. |
| 434 | |
| 435 | The result is a dictionary according to Gerrit REST Api. |
| 436 | https://gerrit-review.googlesource.com/Documentation/rest-api.html |
| 437 | |
| 438 | However, API isn't very clear what's inside, so see tests for example. |
| 439 | """ |
| 440 | assert issue |
| 441 | cache_key = int(issue) |
| 442 | if cache_key not in self.cache: |
| 443 | self.cache[cache_key] = self._FetchChangeDetail(issue) |
| 444 | return self.cache[cache_key] |
| 445 | |
| 446 | def GetChangeDescription(self, issue, patchset=None): |
| 447 | """If patchset is none, fetches current patchset.""" |
| 448 | info = self.GetChangeInfo(issue) |
| 449 | # info is a reference to cache. We'll modify it here adding description to |
| 450 | # it to the right patchset, if it is not yet there. |
| 451 | |
| 452 | # Find revision info for the patchset we want. |
| 453 | if patchset is not None: |
Marc-Antoine Ruel | 8e57b4b | 2019-10-11 01:01:36 +0000 | [diff] [blame] | 454 | for rev, rev_info in info['revisions'].items(): |
tandrii@chromium.org | 37b07a7 | 2016-04-29 16:42:28 +0000 | [diff] [blame] | 455 | if str(rev_info['_number']) == str(patchset): |
| 456 | break |
| 457 | else: |
| 458 | raise Exception('patchset %s doesn\'t exist in issue %s' % ( |
| 459 | patchset, issue)) |
| 460 | else: |
| 461 | rev = info['current_revision'] |
| 462 | rev_info = info['revisions'][rev] |
| 463 | |
Andrii Shyshkalov | 9c3a464 | 2017-01-24 17:41:22 +0100 | [diff] [blame] | 464 | return rev_info['commit']['message'] |
tandrii@chromium.org | 37b07a7 | 2016-04-29 16:42:28 +0000 | [diff] [blame] | 465 | |
Mun Yong Jang | 603d01e | 2017-12-19 16:38:30 -0800 | [diff] [blame] | 466 | def GetDestRef(self, issue): |
| 467 | ref = self.GetChangeInfo(issue)['branch'] |
| 468 | if not ref.startswith('refs/'): |
| 469 | # NOTE: it is possible to create 'refs/x' branch, |
| 470 | # aka 'refs/heads/refs/x'. However, this is ill-advised. |
| 471 | ref = 'refs/heads/%s' % ref |
| 472 | return ref |
| 473 | |
Edward Lesmes | 02d4b82 | 2020-11-11 00:37:35 +0000 | [diff] [blame] | 474 | def _GetApproversForLabel(self, issue, label): |
| 475 | change_info = self.GetChangeInfo(issue) |
| 476 | label_info = change_info.get('labels', {}).get(label, {}) |
| 477 | values = label_info.get('values', {}).keys() |
| 478 | if not values: |
| 479 | return [] |
| 480 | max_value = max(int(v) for v in values) |
| 481 | return [v for v in label_info.get('all', []) |
| 482 | if v.get('value', 0) == max_value] |
| 483 | |
Edward Lesmes | c456617 | 2021-03-19 16:55:13 +0000 | [diff] [blame] | 484 | def IsBotCommitApproved(self, issue): |
| 485 | return bool(self._GetApproversForLabel(issue, 'Bot-Commit')) |
| 486 | |
Edward Lesmes | cf49cb8 | 2020-11-11 01:08:36 +0000 | [diff] [blame] | 487 | def IsOwnersOverrideApproved(self, issue): |
| 488 | return bool(self._GetApproversForLabel(issue, 'Owners-Override')) |
| 489 | |
tandrii@chromium.org | 37b07a7 | 2016-04-29 16:42:28 +0000 | [diff] [blame] | 490 | def GetChangeOwner(self, issue): |
| 491 | return self.GetChangeInfo(issue)['owner']['email'] |
| 492 | |
| 493 | def GetChangeReviewers(self, issue, approving_only=True): |
Aaron Gable | 8b478f0 | 2017-07-31 15:33:19 -0700 | [diff] [blame] | 494 | changeinfo = self.GetChangeInfo(issue) |
| 495 | if approving_only: |
Edward Lesmes | 02d4b82 | 2020-11-11 00:37:35 +0000 | [diff] [blame] | 496 | reviewers = self._GetApproversForLabel(issue, 'Code-Review') |
Aaron Gable | 8b478f0 | 2017-07-31 15:33:19 -0700 | [diff] [blame] | 497 | else: |
| 498 | reviewers = changeinfo.get('reviewers', {}).get('REVIEWER', []) |
| 499 | return [r.get('email') for r in reviewers] |
tandrii@chromium.org | 37b07a7 | 2016-04-29 16:42:28 +0000 | [diff] [blame] | 500 | |
Edward Lemur | e4d329c | 2020-02-03 20:41:18 +0000 | [diff] [blame] | 501 | def UpdateDescription(self, description, issue): |
| 502 | gerrit_util.SetCommitMessage(self.host, issue, description, notify='NONE') |
| 503 | |
Edward Lesmes | 8170c29 | 2021-03-19 20:04:43 +0000 | [diff] [blame] | 504 | def IsCodeOwnersEnabledOnRepo(self): |
| 505 | if self.code_owners_enabled is None: |
| 506 | self.code_owners_enabled = gerrit_util.IsCodeOwnersEnabledOnRepo( |
Edward Lesmes | 392c407 | 2021-03-19 21:58:45 +0000 | [diff] [blame] | 507 | self.host, self.project) |
Edward Lesmes | 8170c29 | 2021-03-19 20:04:43 +0000 | [diff] [blame] | 508 | return self.code_owners_enabled |
| 509 | |
ilevy@chromium.org | bc11731 | 2013-04-20 03:57:56 +0000 | [diff] [blame] | 510 | |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 511 | class OutputApi(object): |
wez@chromium.org | a6d011e | 2013-03-26 17:31:49 +0000 | [diff] [blame] | 512 | """An instance of OutputApi gets passed to presubmit scripts so that they |
| 513 | can output various types of results. |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 514 | """ |
ilevy@chromium.org | bc11731 | 2013-04-20 03:57:56 +0000 | [diff] [blame] | 515 | PresubmitResult = _PresubmitResult |
ilevy@chromium.org | bc11731 | 2013-04-20 03:57:56 +0000 | [diff] [blame] | 516 | PresubmitError = _PresubmitError |
| 517 | PresubmitPromptWarning = _PresubmitPromptWarning |
| 518 | PresubmitNotifyResult = _PresubmitNotifyResult |
| 519 | MailTextResult = _MailTextResult |
| 520 | |
wez@chromium.org | a6d011e | 2013-03-26 17:31:49 +0000 | [diff] [blame] | 521 | def __init__(self, is_committing): |
| 522 | self.is_committing = is_committing |
Daniel Cheng | 7227d21 | 2017-11-17 08:12:37 -0800 | [diff] [blame] | 523 | self.more_cc = [] |
| 524 | |
| 525 | def AppendCC(self, cc): |
| 526 | """Appends a user to cc for this change.""" |
Daniel Cheng | 541638f | 2023-05-15 22:00:47 +0000 | [diff] [blame] | 527 | self.more_cc.append(cc) |
wez@chromium.org | a6d011e | 2013-03-26 17:31:49 +0000 | [diff] [blame] | 528 | |
wez@chromium.org | a6d011e | 2013-03-26 17:31:49 +0000 | [diff] [blame] | 529 | def PresubmitPromptOrNotify(self, *args, **kwargs): |
| 530 | """Warn the user when uploading, but only notify if committing.""" |
| 531 | if self.is_committing: |
| 532 | return self.PresubmitNotifyResult(*args, **kwargs) |
| 533 | return self.PresubmitPromptWarning(*args, **kwargs) |
| 534 | |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 535 | |
| 536 | class InputApi(object): |
| 537 | """An instance of this object is passed to presubmit scripts so they can |
| 538 | know stuff about the change they're looking at. |
| 539 | """ |
maruel@chromium.org | b17b55b | 2010-11-03 14:42:37 +0000 | [diff] [blame] | 540 | # Method could be a function |
Quinten Yearsley | b2cc4a9 | 2016-12-15 13:53:26 -0800 | [diff] [blame] | 541 | # pylint: disable=no-self-use |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 542 | |
maruel@chromium.org | 3410d91 | 2009-06-09 20:56:16 +0000 | [diff] [blame] | 543 | # File extensions that are considered source files from a style guide |
| 544 | # perspective. Don't modify this list from a presubmit script! |
maruel@chromium.org | c33455a | 2011-06-24 19:14:18 +0000 | [diff] [blame] | 545 | # |
| 546 | # Files without an extension aren't included in the list. If you want to |
local_bot | 30f774e | 2020-06-25 18:23:34 +0000 | [diff] [blame] | 547 | # filter them as source files, add r'(^|.*?[\\\/])[^.]+$' to the allow list. |
local_bot | 6402141 | 2020-07-08 21:05:39 +0000 | [diff] [blame] | 548 | # Note that ALL CAPS files are skipped in DEFAULT_FILES_TO_SKIP below. |
| 549 | DEFAULT_FILES_TO_CHECK = ( |
maruel@chromium.org | 3410d91 | 2009-06-09 20:56:16 +0000 | [diff] [blame] | 550 | # C++ and friends |
Edward Lemur | a5799e3 | 2020-01-17 19:26:51 +0000 | [diff] [blame] | 551 | r'.+\.c$', r'.+\.cc$', r'.+\.cpp$', r'.+\.h$', r'.+\.m$', r'.+\.mm$', |
| 552 | r'.+\.inl$', r'.+\.asm$', r'.+\.hxx$', r'.+\.hpp$', r'.+\.s$', r'.+\.S$', |
maruel@chromium.org | 3410d91 | 2009-06-09 20:56:16 +0000 | [diff] [blame] | 553 | # Scripts |
dpapad | 443d913 | 2022-05-05 00:17:30 +0000 | [diff] [blame] | 554 | r'.+\.js$', r'.+\.ts$', r'.+\.py$', r'.+\.sh$', r'.+\.rb$', r'.+\.pl$', |
| 555 | r'.+\.pm$', |
maruel@chromium.org | 3410d91 | 2009-06-09 20:56:16 +0000 | [diff] [blame] | 556 | # Other |
Edward Lemur | a5799e3 | 2020-01-17 19:26:51 +0000 | [diff] [blame] | 557 | r'.+\.java$', r'.+\.mk$', r'.+\.am$', r'.+\.css$', r'.+\.mojom$', |
Bruce Dawson | 7a81ebf | 2023-01-03 18:36:18 +0000 | [diff] [blame] | 558 | r'.+\.fidl$', r'.+\.rs$', |
maruel@chromium.org | 3410d91 | 2009-06-09 20:56:16 +0000 | [diff] [blame] | 559 | ) |
| 560 | |
| 561 | # Path regexp that should be excluded from being considered containing source |
| 562 | # files. Don't modify this list from a presubmit script! |
local_bot | 6402141 | 2020-07-08 21:05:39 +0000 | [diff] [blame] | 563 | DEFAULT_FILES_TO_SKIP = ( |
Edward Lemur | a5799e3 | 2020-01-17 19:26:51 +0000 | [diff] [blame] | 564 | r'testing_support[\\\/]google_appengine[\\\/].*', |
| 565 | r'.*\bexperimental[\\\/].*', |
Kent Tamura | 179dd1e | 2018-04-26 15:07:41 +0900 | [diff] [blame] | 566 | # Exclude third_party/.* but NOT third_party/{WebKit,blink} |
| 567 | # (crbug.com/539768 and crbug.com/836555). |
Edward Lemur | a5799e3 | 2020-01-17 19:26:51 +0000 | [diff] [blame] | 568 | r'.*\bthird_party[\\\/](?!(WebKit|blink)[\\\/]).*', |
maruel@chromium.org | 3410d91 | 2009-06-09 20:56:16 +0000 | [diff] [blame] | 569 | # Output directories (just in case) |
Edward Lemur | a5799e3 | 2020-01-17 19:26:51 +0000 | [diff] [blame] | 570 | r'.*\bDebug[\\\/].*', |
| 571 | r'.*\bRelease[\\\/].*', |
| 572 | r'.*\bxcodebuild[\\\/].*', |
| 573 | r'.*\bout[\\\/].*', |
maruel@chromium.org | 3410d91 | 2009-06-09 20:56:16 +0000 | [diff] [blame] | 574 | # All caps files like README and LICENCE. |
Edward Lemur | a5799e3 | 2020-01-17 19:26:51 +0000 | [diff] [blame] | 575 | r'.*\b[A-Z0-9_]{2,}$', |
maruel@chromium.org | df1595a | 2009-06-11 02:00:13 +0000 | [diff] [blame] | 576 | # SCM (can happen in dual SCM configuration). (Slightly over aggressive) |
Edward Lemur | a5799e3 | 2020-01-17 19:26:51 +0000 | [diff] [blame] | 577 | r'(|.*[\\\/])\.git[\\\/].*', |
| 578 | r'(|.*[\\\/])\.svn[\\\/].*', |
maruel@chromium.org | 7ccb4bb | 2011-11-07 20:26:20 +0000 | [diff] [blame] | 579 | # There is no point in processing a patch file. |
Edward Lemur | a5799e3 | 2020-01-17 19:26:51 +0000 | [diff] [blame] | 580 | r'.+\.diff$', |
| 581 | r'.+\.patch$', |
maruel@chromium.org | 3410d91 | 2009-06-09 20:56:16 +0000 | [diff] [blame] | 582 | ) |
| 583 | |
maruel@chromium.org | cc73ad6 | 2011-07-06 17:39:26 +0000 | [diff] [blame] | 584 | def __init__(self, change, presubmit_path, is_committing, |
Bruce Dawson | 09c0c07 | 2022-05-26 20:28:58 +0000 | [diff] [blame] | 585 | verbose, gerrit_obj, dry_run=None, thread_pool=None, parallel=False, |
| 586 | no_diffs=False): |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 587 | """Builds an InputApi object. |
| 588 | |
| 589 | Args: |
maruel@chromium.org | 4ff922a | 2009-06-12 20:20:19 +0000 | [diff] [blame] | 590 | change: A presubmit.Change object. |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 591 | presubmit_path: The path to the presubmit script being processed. |
maruel@chromium.org | d7dccf5 | 2009-06-06 18:51:58 +0000 | [diff] [blame] | 592 | is_committing: True if the change is about to be committed. |
tandrii@chromium.org | 37b07a7 | 2016-04-29 16:42:28 +0000 | [diff] [blame] | 593 | gerrit_obj: provides basic Gerrit codereview functionality. |
| 594 | dry_run: if true, some Checks will be skipped. |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 595 | parallel: if true, all tests reported via input_api.RunTests for all |
| 596 | PRESUBMIT files will be run in parallel. |
Bruce Dawson | 09c0c07 | 2022-05-26 20:28:58 +0000 | [diff] [blame] | 597 | no_diffs: if true, implies that --files or --all was specified so some |
| 598 | checks can be skipped, and some errors will be messages. |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 599 | """ |
maruel@chromium.org | 9711bba | 2009-05-22 23:51:39 +0000 | [diff] [blame] | 600 | # Version number of the presubmit_support script. |
| 601 | self.version = [int(x) for x in __version__.split('.')] |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 602 | self.change = change |
maruel@chromium.org | d7dccf5 | 2009-06-06 18:51:58 +0000 | [diff] [blame] | 603 | self.is_committing = is_committing |
tandrii@chromium.org | 37b07a7 | 2016-04-29 16:42:28 +0000 | [diff] [blame] | 604 | self.gerrit = gerrit_obj |
tandrii@chromium.org | 57bafac | 2016-04-28 05:09:03 +0000 | [diff] [blame] | 605 | self.dry_run = dry_run |
Bruce Dawson | 09c0c07 | 2022-05-26 20:28:58 +0000 | [diff] [blame] | 606 | self.no_diffs = no_diffs |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 607 | |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 608 | self.parallel = parallel |
| 609 | self.thread_pool = thread_pool or ThreadPool() |
| 610 | |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 611 | # We expose various modules and functions as attributes of the input_api |
| 612 | # so that presubmit scripts don't have to import them. |
Takeshi Yoshino | 07a6bea | 2017-08-02 02:44:06 +0900 | [diff] [blame] | 613 | self.ast = ast |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 614 | self.basename = os.path.basename |
enne@chromium.org | e72c5f5 | 2013-04-16 00:36:40 +0000 | [diff] [blame] | 615 | self.cpplint = cpplint |
dcheng | 091b7db | 2016-06-16 01:27:51 -0700 | [diff] [blame] | 616 | self.fnmatch = fnmatch |
Yoshisato Yanagisawa | 04600b4 | 2019-03-15 03:03:41 +0000 | [diff] [blame] | 617 | self.gclient_paths = gclient_paths |
Yoshisato Yanagisawa | 57dd17b | 2019-03-22 09:10:29 +0000 | [diff] [blame] | 618 | # TODO(yyanagisawa): stop exposing this when python3 become default. |
| 619 | # Since python3's tempfile has TemporaryDirectory, we do not need this. |
| 620 | self.temporary_directory = gclient_utils.temporary_directory |
dpranke@chromium.org | 17cc244 | 2012-10-17 21:12:09 +0000 | [diff] [blame] | 621 | self.glob = glob.glob |
maruel@chromium.org | fb11c7b | 2010-03-18 18:22:14 +0000 | [diff] [blame] | 622 | self.json = json |
maruel@chromium.org | 6fba34d | 2011-06-02 13:45:12 +0000 | [diff] [blame] | 623 | self.logging = logging.getLogger('PRESUBMIT') |
maruel@chromium.org | 2b5ce56 | 2011-03-31 16:15:44 +0000 | [diff] [blame] | 624 | self.os_listdir = os.listdir |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 625 | self.os_path = os.path |
pgervais@chromium.org | bd0cace | 2014-10-02 23:23:46 +0000 | [diff] [blame] | 626 | self.os_stat = os.stat |
Yoshisato Yanagisawa | 406de13 | 2018-06-29 05:43:25 +0000 | [diff] [blame] | 627 | self.os_walk = os.walk |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 628 | self.re = re |
| 629 | self.subprocess = subprocess |
Edward Lemur | b983024 | 2019-10-30 22:19:20 +0000 | [diff] [blame] | 630 | self.sys = sys |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 631 | self.tempfile = tempfile |
dpranke@chromium.org | 0d1bdea | 2011-03-24 22:54:38 +0000 | [diff] [blame] | 632 | self.time = time |
maruel@chromium.org | 1487d53 | 2009-06-06 00:22:57 +0000 | [diff] [blame] | 633 | self.unittest = unittest |
Edward Lemur | b983024 | 2019-10-30 22:19:20 +0000 | [diff] [blame] | 634 | if sys.version_info.major == 2: |
| 635 | self.urllib2 = urllib2 |
Edward Lemur | 16af356 | 2019-10-17 22:11:33 +0000 | [diff] [blame] | 636 | self.urllib_request = urllib_request |
| 637 | self.urllib_error = urllib_error |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 638 | |
Robert Iannucci | 5025893 | 2018-03-19 10:30:59 -0700 | [diff] [blame] | 639 | self.is_windows = sys.platform == 'win32' |
| 640 | |
Edward Lemur | b964662 | 2019-10-25 20:57:35 +0000 | [diff] [blame] | 641 | # Set python_executable to 'vpython' in order to allow scripts in other |
| 642 | # repos (e.g. src.git) to automatically pick up that repo's .vpython file, |
| 643 | # instead of inheriting the one in depot_tools. |
| 644 | self.python_executable = 'vpython' |
Erik Staab | 69135d1 | 2021-05-14 22:31:57 +0000 | [diff] [blame] | 645 | # Offer a python 3 executable for use during the migration off of python 2. |
| 646 | self.python3_executable = 'vpython3' |
maruel@chromium.org | c0b2297 | 2009-06-25 16:19:14 +0000 | [diff] [blame] | 647 | self.environ = os.environ |
| 648 | |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 649 | # InputApi.platform is the platform you're currently running on. |
| 650 | self.platform = sys.platform |
| 651 | |
iannucci@chromium.org | 0af3bb3 | 2015-06-12 20:44:35 +0000 | [diff] [blame] | 652 | self.cpu_count = multiprocessing.cpu_count() |
Bruce Dawson | 8254f06 | 2022-06-17 17:33:08 +0000 | [diff] [blame] | 653 | if self.is_windows: |
| 654 | # TODO(crbug.com/1190269) - we can't use more than 56 child processes on |
| 655 | # Windows or Python3 may hang. |
| 656 | self.cpu_count = min(self.cpu_count, 56) |
iannucci@chromium.org | 0af3bb3 | 2015-06-12 20:44:35 +0000 | [diff] [blame] | 657 | |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 658 | # The local path of the currently-being-processed presubmit script. |
maruel@chromium.org | 3d23524 | 2009-05-15 12:40:48 +0000 | [diff] [blame] | 659 | self._current_presubmit_path = os.path.dirname(presubmit_path) |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 660 | |
| 661 | # We carry the canned checks so presubmit scripts can easily use them. |
| 662 | self.canned_checks = presubmit_canned_checks |
| 663 | |
Raphael Kubo da Costa | f2d1615 | 2017-11-10 18:07:58 +0100 | [diff] [blame] | 664 | # Temporary files we must manually remove at the end of a run. |
| 665 | self._named_temporary_files = [] |
Jochen Eisinger | 72606f8 | 2017-04-04 10:44:18 +0200 | [diff] [blame] | 666 | |
Edward Lesmes | dc11c6b | 2021-03-19 19:22:05 +0000 | [diff] [blame] | 667 | self.owners_client = None |
Bruce Dawson | eb8426e | 2022-08-05 23:58:15 +0000 | [diff] [blame] | 668 | if self.gerrit and not 'PRESUBMIT_SKIP_NETWORK' in self.environ: |
Bruce Dawson | 9b9f451 | 2022-04-27 00:56:52 +0000 | [diff] [blame] | 669 | try: |
| 670 | self.owners_client = owners_client.GetCodeOwnersClient( |
Bruce Dawson | 9b9f451 | 2022-04-27 00:56:52 +0000 | [diff] [blame] | 671 | host=self.gerrit.host, |
| 672 | project=self.gerrit.project, |
| 673 | branch=self.gerrit.branch) |
| 674 | except Exception as e: |
| 675 | print('Failed to set owners_client - %s' % str(e)) |
Jochen Eisinger | 76f5fc6 | 2017-04-07 16:27:46 +0200 | [diff] [blame] | 676 | self.owners_finder = owners_finder.OwnersFinder |
maruel@chromium.org | 899e1c1 | 2011-04-07 17:03:18 +0000 | [diff] [blame] | 677 | self.verbose = verbose |
ilevy@chromium.org | bc11731 | 2013-04-20 03:57:56 +0000 | [diff] [blame] | 678 | self.Command = CommandData |
dpranke@chromium.org | 2a00962 | 2011-03-01 02:43:31 +0000 | [diff] [blame] | 679 | |
enne@chromium.org | e72c5f5 | 2013-04-16 00:36:40 +0000 | [diff] [blame] | 680 | # Replace <hash_map> and <hash_set> as headers that need to be included |
Edward Lemur | a5799e3 | 2020-01-17 19:26:51 +0000 | [diff] [blame] | 681 | # with 'base/containers/hash_tables.h' instead. |
enne@chromium.org | e72c5f5 | 2013-04-16 00:36:40 +0000 | [diff] [blame] | 682 | # Access to a protected member _XX of a client class |
Quinten Yearsley | b2cc4a9 | 2016-12-15 13:53:26 -0800 | [diff] [blame] | 683 | # pylint: disable=protected-access |
enne@chromium.org | e72c5f5 | 2013-04-16 00:36:40 +0000 | [diff] [blame] | 684 | self.cpplint._re_pattern_templates = [ |
danakj@chromium.org | 1827852 | 2013-06-11 22:42:32 +0000 | [diff] [blame] | 685 | (a, b, 'base/containers/hash_tables.h') |
enne@chromium.org | e72c5f5 | 2013-04-16 00:36:40 +0000 | [diff] [blame] | 686 | if header in ('<hash_map>', '<hash_set>') else (a, b, header) |
| 687 | for (a, b, header) in cpplint._re_pattern_templates |
| 688 | ] |
| 689 | |
Edward Lemur | ecc2707 | 2020-01-06 16:42:34 +0000 | [diff] [blame] | 690 | def SetTimeout(self, timeout): |
| 691 | self.thread_pool.timeout = timeout |
| 692 | |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 693 | def PresubmitLocalPath(self): |
| 694 | """Returns the local path of the presubmit script currently being run. |
| 695 | |
| 696 | This is useful if you don't want to hard-code absolute paths in the |
| 697 | presubmit script. For example, It can be used to find another file |
| 698 | relative to the PRESUBMIT.py script, so the whole tree can be branched and |
| 699 | the presubmit script still works, without editing its content. |
| 700 | """ |
maruel@chromium.org | 3d23524 | 2009-05-15 12:40:48 +0000 | [diff] [blame] | 701 | return self._current_presubmit_path |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 702 | |
agable | 0b65e73 | 2016-11-22 09:25:46 -0800 | [diff] [blame] | 703 | def AffectedFiles(self, include_deletes=True, file_filter=None): |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 704 | """Same as input_api.change.AffectedFiles() except only lists files |
| 705 | (and optionally directories) in the same directory as the current presubmit |
Bruce Dawson | 7a0b07a | 2020-04-23 17:14:40 +0000 | [diff] [blame] | 706 | script, or subdirectories thereof. Note that files are listed using the OS |
| 707 | path separator, so backslashes are used as separators on Windows. |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 708 | """ |
Josip Sokcevic | a9a7eec | 2023-03-10 03:54:52 +0000 | [diff] [blame] | 709 | dir_with_slash = normpath(self.PresubmitLocalPath()) |
Bruce Dawson | 31bfd51 | 2022-05-10 23:19:39 +0000 | [diff] [blame] | 710 | # normpath strips trailing path separators, so the trailing separator has to |
| 711 | # be added after the normpath call. |
| 712 | if len(dir_with_slash) > 0: |
| 713 | dir_with_slash += os.path.sep |
sail@chromium.org | 5538e02 | 2011-05-12 17:53:16 +0000 | [diff] [blame] | 714 | |
Josip Sokcevic | a9a7eec | 2023-03-10 03:54:52 +0000 | [diff] [blame] | 715 | return list(filter( |
| 716 | lambda x: normpath(x.AbsoluteLocalPath()).startswith(dir_with_slash), |
| 717 | self.change.AffectedFiles(include_deletes, file_filter))) |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 718 | |
agable | 0b65e73 | 2016-11-22 09:25:46 -0800 | [diff] [blame] | 719 | def LocalPaths(self): |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 720 | """Returns local paths of input_api.AffectedFiles().""" |
agable | 0b65e73 | 2016-11-22 09:25:46 -0800 | [diff] [blame] | 721 | paths = [af.LocalPath() for af in self.AffectedFiles()] |
Edward Lemur | a5799e3 | 2020-01-17 19:26:51 +0000 | [diff] [blame] | 722 | logging.debug('LocalPaths: %s', paths) |
pgervais@chromium.org | 2f64f78 | 2014-04-25 00:12:33 +0000 | [diff] [blame] | 723 | return paths |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 724 | |
agable | 0b65e73 | 2016-11-22 09:25:46 -0800 | [diff] [blame] | 725 | def AbsoluteLocalPaths(self): |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 726 | """Returns absolute local paths of input_api.AffectedFiles().""" |
agable | 0b65e73 | 2016-11-22 09:25:46 -0800 | [diff] [blame] | 727 | return [af.AbsoluteLocalPath() for af in self.AffectedFiles()] |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 728 | |
John Budorick | 1616237 | 2018-04-18 10:39:53 -0700 | [diff] [blame] | 729 | def AffectedTestableFiles(self, include_deletes=None, **kwargs): |
agable | 0b65e73 | 2016-11-22 09:25:46 -0800 | [diff] [blame] | 730 | """Same as input_api.change.AffectedTestableFiles() except only lists files |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 731 | in the same directory as the current presubmit script, or subdirectories |
| 732 | thereof. |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 733 | """ |
maruel@chromium.org | 77c4f0f | 2009-05-29 18:53:04 +0000 | [diff] [blame] | 734 | if include_deletes is not None: |
Edward Lemur | a5799e3 | 2020-01-17 19:26:51 +0000 | [diff] [blame] | 735 | warn('AffectedTestableFiles(include_deletes=%s)' |
| 736 | ' is deprecated and ignored' % str(include_deletes), |
maruel@chromium.org | cb2985f | 2010-11-03 14:08:31 +0000 | [diff] [blame] | 737 | category=DeprecationWarning, |
| 738 | stacklevel=2) |
Josip Sokcevic | 4de5dea | 2022-03-23 21:15:14 +0000 | [diff] [blame] | 739 | # pylint: disable=consider-using-generator |
| 740 | return [ |
| 741 | x for x in self.AffectedFiles(include_deletes=False, **kwargs) |
| 742 | if x.IsTestableFile() |
| 743 | ] |
agable | 0b65e73 | 2016-11-22 09:25:46 -0800 | [diff] [blame] | 744 | |
| 745 | def AffectedTextFiles(self, include_deletes=None): |
| 746 | """An alias to AffectedTestableFiles for backwards compatibility.""" |
| 747 | return self.AffectedTestableFiles(include_deletes=include_deletes) |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 748 | |
Josip Sokcevic | 8c95595 | 2021-02-01 21:32:57 +0000 | [diff] [blame] | 749 | def FilterSourceFile(self, |
| 750 | affected_file, |
| 751 | files_to_check=None, |
| 752 | files_to_skip=None, |
| 753 | allow_list=None, |
| 754 | block_list=None): |
Edward Lemur | a5799e3 | 2020-01-17 19:26:51 +0000 | [diff] [blame] | 755 | """Filters out files that aren't considered 'source file'. |
maruel@chromium.org | 3410d91 | 2009-06-09 20:56:16 +0000 | [diff] [blame] | 756 | |
local_bot | 6402141 | 2020-07-08 21:05:39 +0000 | [diff] [blame] | 757 | If files_to_check or files_to_skip is None, InputApi.DEFAULT_FILES_TO_CHECK |
| 758 | and InputApi.DEFAULT_FILES_TO_SKIP is used respectively. |
maruel@chromium.org | 3410d91 | 2009-06-09 20:56:16 +0000 | [diff] [blame] | 759 | |
Bruce Dawson | 635383f | 2022-09-13 16:23:18 +0000 | [diff] [blame] | 760 | affected_file.LocalPath() needs to re.match an entry in the files_to_check |
| 761 | list and not re.match any entries in the files_to_skip list. |
| 762 | '/' path separators should be used in the regular expressions and will work |
| 763 | on Windows as well as other platforms. |
maruel@chromium.org | 3410d91 | 2009-06-09 20:56:16 +0000 | [diff] [blame] | 764 | |
| 765 | Note: Copy-paste this function to suit your needs or use a lambda function. |
| 766 | """ |
local_bot | 6402141 | 2020-07-08 21:05:39 +0000 | [diff] [blame] | 767 | if files_to_check is None: |
| 768 | files_to_check = self.DEFAULT_FILES_TO_CHECK |
| 769 | if files_to_skip is None: |
| 770 | files_to_skip = self.DEFAULT_FILES_TO_SKIP |
local_bot | 30f774e | 2020-06-25 18:23:34 +0000 | [diff] [blame] | 771 | |
maruel@chromium.org | cb2985f | 2010-11-03 14:08:31 +0000 | [diff] [blame] | 772 | def Find(affected_file, items): |
maruel@chromium.org | ab05d58 | 2011-02-09 23:41:22 +0000 | [diff] [blame] | 773 | local_path = affected_file.LocalPath() |
maruel@chromium.org | cb2985f | 2010-11-03 14:08:31 +0000 | [diff] [blame] | 774 | for item in items: |
maruel@chromium.org | df1595a | 2009-06-11 02:00:13 +0000 | [diff] [blame] | 775 | if self.re.match(item, local_path): |
maruel@chromium.org | 3410d91 | 2009-06-09 20:56:16 +0000 | [diff] [blame] | 776 | return True |
Bruce Dawson | a3a014e | 2022-04-27 23:28:17 +0000 | [diff] [blame] | 777 | # Handle the cases where the files regex only handles /, but the local |
| 778 | # path uses \. |
| 779 | if self.is_windows and self.re.match(item, local_path.replace( |
| 780 | '\\', '/')): |
| 781 | return True |
maruel@chromium.org | 3410d91 | 2009-06-09 20:56:16 +0000 | [diff] [blame] | 782 | return False |
local_bot | 6402141 | 2020-07-08 21:05:39 +0000 | [diff] [blame] | 783 | return (Find(affected_file, files_to_check) and |
| 784 | not Find(affected_file, files_to_skip)) |
maruel@chromium.org | 3410d91 | 2009-06-09 20:56:16 +0000 | [diff] [blame] | 785 | |
| 786 | def AffectedSourceFiles(self, source_file): |
agable | 0b65e73 | 2016-11-22 09:25:46 -0800 | [diff] [blame] | 787 | """Filter the list of AffectedTestableFiles by the function source_file. |
maruel@chromium.org | 3410d91 | 2009-06-09 20:56:16 +0000 | [diff] [blame] | 788 | |
| 789 | If source_file is None, InputApi.FilterSourceFile() is used. |
| 790 | """ |
| 791 | if not source_file: |
| 792 | source_file = self.FilterSourceFile |
Edward Lemur | b983024 | 2019-10-30 22:19:20 +0000 | [diff] [blame] | 793 | return list(filter(source_file, self.AffectedTestableFiles())) |
maruel@chromium.org | 3410d91 | 2009-06-09 20:56:16 +0000 | [diff] [blame] | 794 | |
| 795 | def RightHandSideLines(self, source_file_filter=None): |
Edward Lemur | a5799e3 | 2020-01-17 19:26:51 +0000 | [diff] [blame] | 796 | """An iterator over all text lines in 'new' version of changed files. |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 797 | |
| 798 | Only lists lines from new or modified text files in the change that are |
| 799 | contained by the directory of the currently executing presubmit script. |
| 800 | |
| 801 | This is useful for doing line-by-line regex checks, like checking for |
| 802 | trailing whitespace. |
| 803 | |
| 804 | Yields: |
| 805 | a 3 tuple: |
Josip Sokcevic | 7958e30 | 2023-03-01 23:02:21 +0000 | [diff] [blame] | 806 | the AffectedFile instance of the current file; |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 807 | integer line number (1-based); and |
| 808 | the contents of the line as a string. |
maruel@chromium.org | 1487d53 | 2009-06-06 00:22:57 +0000 | [diff] [blame] | 809 | |
nick@chromium.org | 2a3ab7e | 2011-04-27 22:06:27 +0000 | [diff] [blame] | 810 | Note: The carriage return (LF or CR) is stripped off. |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 811 | """ |
maruel@chromium.org | 3410d91 | 2009-06-09 20:56:16 +0000 | [diff] [blame] | 812 | files = self.AffectedSourceFiles(source_file_filter) |
Josip Sokcevic | 7958e30 | 2023-03-01 23:02:21 +0000 | [diff] [blame] | 813 | return _RightHandSideLinesImpl(files) |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 814 | |
maruel@chromium.org | e3608df | 2009-11-10 20:22:57 +0000 | [diff] [blame] | 815 | def ReadFile(self, file_item, mode='r'): |
maruel@chromium.org | 44a17ad | 2009-06-08 14:14:35 +0000 | [diff] [blame] | 816 | """Reads an arbitrary file. |
thestig@chromium.org | da8cddd | 2009-08-13 00:25:55 +0000 | [diff] [blame] | 817 | |
maruel@chromium.org | 44a17ad | 2009-06-08 14:14:35 +0000 | [diff] [blame] | 818 | Deny reading anything outside the repository. |
| 819 | """ |
Josip Sokcevic | 7958e30 | 2023-03-01 23:02:21 +0000 | [diff] [blame] | 820 | if isinstance(file_item, AffectedFile): |
maruel@chromium.org | e3608df | 2009-11-10 20:22:57 +0000 | [diff] [blame] | 821 | file_item = file_item.AbsoluteLocalPath() |
| 822 | if not file_item.startswith(self.change.RepositoryRoot()): |
maruel@chromium.org | 44a17ad | 2009-06-08 14:14:35 +0000 | [diff] [blame] | 823 | raise IOError('Access outside the repository root is denied.') |
maruel@chromium.org | 5aeb7dd | 2009-11-17 18:09:01 +0000 | [diff] [blame] | 824 | return gclient_utils.FileRead(file_item, mode) |
maruel@chromium.org | 44a17ad | 2009-06-08 14:14:35 +0000 | [diff] [blame] | 825 | |
Raphael Kubo da Costa | f2d1615 | 2017-11-10 18:07:58 +0100 | [diff] [blame] | 826 | def CreateTemporaryFile(self, **kwargs): |
| 827 | """Returns a named temporary file that must be removed with a call to |
| 828 | RemoveTemporaryFiles(). |
| 829 | |
| 830 | All keyword arguments are forwarded to tempfile.NamedTemporaryFile(), |
| 831 | except for |delete|, which is always set to False. |
| 832 | |
| 833 | Presubmit checks that need to create a temporary file and pass it for |
| 834 | reading should use this function instead of NamedTemporaryFile(), as |
| 835 | Windows fails to open a file that is already open for writing. |
| 836 | |
| 837 | with input_api.CreateTemporaryFile() as f: |
| 838 | f.write('xyz') |
| 839 | f.close() |
| 840 | input_api.subprocess.check_output(['script-that', '--reads-from', |
| 841 | f.name]) |
| 842 | |
| 843 | |
| 844 | Note that callers of CreateTemporaryFile() should not worry about removing |
| 845 | any temporary file; this is done transparently by the presubmit handling |
| 846 | code. |
| 847 | """ |
| 848 | if 'delete' in kwargs: |
| 849 | # Prevent users from passing |delete|; we take care of file deletion |
| 850 | # ourselves and this prevents unintuitive error messages when we pass |
| 851 | # delete=False and 'delete' is also in kwargs. |
| 852 | raise TypeError('CreateTemporaryFile() does not take a "delete" ' |
| 853 | 'argument, file deletion is handled automatically by ' |
| 854 | 'the same presubmit_support code that creates InputApi ' |
| 855 | 'objects.') |
| 856 | temp_file = self.tempfile.NamedTemporaryFile(delete=False, **kwargs) |
| 857 | self._named_temporary_files.append(temp_file.name) |
| 858 | return temp_file |
| 859 | |
maruel@chromium.org | cc73ad6 | 2011-07-06 17:39:26 +0000 | [diff] [blame] | 860 | @property |
| 861 | def tbr(self): |
| 862 | """Returns if a change is TBR'ed.""" |
Jeremy Roman | dce2250 | 2017-06-20 15:37:29 -0400 | [diff] [blame] | 863 | return 'TBR' in self.change.tags or self.change.TBRsFromDescription() |
maruel@chromium.org | cc73ad6 | 2011-07-06 17:39:26 +0000 | [diff] [blame] | 864 | |
maruel@chromium.org | ffeb2f3 | 2013-12-03 13:55:22 +0000 | [diff] [blame] | 865 | def RunTests(self, tests_mix, parallel=True): |
ilevy@chromium.org | bc11731 | 2013-04-20 03:57:56 +0000 | [diff] [blame] | 866 | tests = [] |
| 867 | msgs = [] |
| 868 | for t in tests_mix: |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 869 | if isinstance(t, OutputApi.PresubmitResult) and t: |
ilevy@chromium.org | bc11731 | 2013-04-20 03:57:56 +0000 | [diff] [blame] | 870 | msgs.append(t) |
| 871 | else: |
| 872 | assert issubclass(t.message, _PresubmitResult) |
| 873 | tests.append(t) |
maruel@chromium.org | ffeb2f3 | 2013-12-03 13:55:22 +0000 | [diff] [blame] | 874 | if self.verbose: |
| 875 | t.info = _PresubmitNotifyResult |
Edward Lemur | 1037c74 | 2018-05-01 18:56:04 -0400 | [diff] [blame] | 876 | if not t.kwargs.get('cwd'): |
| 877 | t.kwargs['cwd'] = self.PresubmitLocalPath() |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 878 | self.thread_pool.AddTests(tests, parallel) |
Edward Lemur | 21000eb | 2019-05-24 23:25:58 +0000 | [diff] [blame] | 879 | # When self.parallel is True (i.e. --parallel is passed as an option) |
| 880 | # RunTests doesn't actually run tests. It adds them to a ThreadPool that |
| 881 | # will run all tests once all PRESUBMIT files are processed. |
| 882 | # Otherwise, it will run them and return the results. |
| 883 | if not self.parallel: |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 884 | msgs.extend(self.thread_pool.RunAsync()) |
| 885 | return msgs |
scottmg | 86099d7 | 2016-09-01 09:16:51 -0700 | [diff] [blame] | 886 | |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 887 | |
Josip Sokcevic | 7958e30 | 2023-03-01 23:02:21 +0000 | [diff] [blame] | 888 | class _DiffCache(object): |
| 889 | """Caches diffs retrieved from a particular SCM.""" |
| 890 | def __init__(self, upstream=None): |
| 891 | """Stores the upstream revision against which all diffs will be computed.""" |
| 892 | self._upstream = upstream |
| 893 | |
| 894 | def GetDiff(self, path, local_root): |
| 895 | """Get the diff for a particular path.""" |
| 896 | raise NotImplementedError() |
| 897 | |
| 898 | def GetOldContents(self, path, local_root): |
| 899 | """Get the old version for a particular path.""" |
| 900 | raise NotImplementedError() |
| 901 | |
| 902 | |
| 903 | class _GitDiffCache(_DiffCache): |
| 904 | """DiffCache implementation for git; gets all file diffs at once.""" |
| 905 | def __init__(self, upstream): |
| 906 | super(_GitDiffCache, self).__init__(upstream=upstream) |
| 907 | self._diffs_by_file = None |
| 908 | |
| 909 | def GetDiff(self, path, local_root): |
| 910 | # Compare against None to distinguish between None and an initialized but |
| 911 | # empty dictionary. |
| 912 | if self._diffs_by_file == None: |
| 913 | # Compute a single diff for all files and parse the output; should |
| 914 | # with git this is much faster than computing one diff for each file. |
| 915 | diffs = {} |
| 916 | |
| 917 | # Don't specify any filenames below, because there are command line length |
| 918 | # limits on some platforms and GenerateDiff would fail. |
| 919 | unified_diff = scm.GIT.GenerateDiff(local_root, files=[], full_move=True, |
| 920 | branch=self._upstream) |
| 921 | |
| 922 | # This regex matches the path twice, separated by a space. Note that |
| 923 | # filename itself may contain spaces. |
| 924 | file_marker = re.compile('^diff --git (?P<filename>.*) (?P=filename)$') |
| 925 | current_diff = [] |
| 926 | keep_line_endings = True |
| 927 | for x in unified_diff.splitlines(keep_line_endings): |
| 928 | match = file_marker.match(x) |
| 929 | if match: |
| 930 | # Marks the start of a new per-file section. |
| 931 | diffs[match.group('filename')] = current_diff = [x] |
| 932 | elif x.startswith('diff --git'): |
| 933 | raise PresubmitFailure('Unexpected diff line: %s' % x) |
| 934 | else: |
| 935 | current_diff.append(x) |
| 936 | |
| 937 | self._diffs_by_file = dict( |
Josip Sokcevic | a9a7eec | 2023-03-10 03:54:52 +0000 | [diff] [blame] | 938 | (normpath(path), ''.join(diff)) for path, diff in diffs.items()) |
Josip Sokcevic | 7958e30 | 2023-03-01 23:02:21 +0000 | [diff] [blame] | 939 | |
| 940 | if path not in self._diffs_by_file: |
| 941 | # SCM didn't have any diff on this file. It could be that the file was not |
| 942 | # modified at all (e.g. user used --all flag in git cl presubmit). |
| 943 | # Intead of failing, return empty string. |
| 944 | # See: https://crbug.com/808346. |
| 945 | return '' |
| 946 | |
| 947 | return self._diffs_by_file[path] |
| 948 | |
| 949 | def GetOldContents(self, path, local_root): |
| 950 | return scm.GIT.GetOldContents(local_root, path, branch=self._upstream) |
| 951 | |
| 952 | |
| 953 | class AffectedFile(object): |
| 954 | """Representation of a file in a change.""" |
| 955 | |
| 956 | DIFF_CACHE = _DiffCache |
| 957 | |
| 958 | # Method could be a function |
| 959 | # pylint: disable=no-self-use |
| 960 | def __init__(self, path, action, repository_root, diff_cache): |
| 961 | self._path = path |
| 962 | self._action = action |
| 963 | self._local_root = repository_root |
| 964 | self._is_directory = None |
| 965 | self._cached_changed_contents = None |
| 966 | self._cached_new_contents = None |
| 967 | self._diff_cache = diff_cache |
| 968 | logging.debug('%s(%s)', self.__class__.__name__, self._path) |
| 969 | |
| 970 | def LocalPath(self): |
| 971 | """Returns the path of this file on the local disk relative to client root. |
| 972 | |
| 973 | This should be used for error messages but not for accessing files, |
| 974 | because presubmit checks are run with CWD=PresubmitLocalPath() (which is |
| 975 | often != client root). |
| 976 | """ |
Josip Sokcevic | a9a7eec | 2023-03-10 03:54:52 +0000 | [diff] [blame] | 977 | return normpath(self._path) |
Josip Sokcevic | 7958e30 | 2023-03-01 23:02:21 +0000 | [diff] [blame] | 978 | |
| 979 | def AbsoluteLocalPath(self): |
| 980 | """Returns the absolute path of this file on the local disk. |
| 981 | """ |
| 982 | return os.path.abspath(os.path.join(self._local_root, self.LocalPath())) |
| 983 | |
| 984 | def Action(self): |
| 985 | """Returns the action on this opened file, e.g. A, M, D, etc.""" |
| 986 | return self._action |
| 987 | |
| 988 | def IsTestableFile(self): |
| 989 | """Returns True if the file is a text file and not a binary file. |
| 990 | |
| 991 | Deleted files are not text file.""" |
| 992 | raise NotImplementedError() # Implement when needed |
| 993 | |
| 994 | def IsTextFile(self): |
| 995 | """An alias to IsTestableFile for backwards compatibility.""" |
| 996 | return self.IsTestableFile() |
| 997 | |
| 998 | def OldContents(self): |
| 999 | """Returns an iterator over the lines in the old version of file. |
| 1000 | |
| 1001 | The old version is the file before any modifications in the user's |
| 1002 | workspace, i.e. the 'left hand side'. |
| 1003 | |
| 1004 | Contents will be empty if the file is a directory or does not exist. |
| 1005 | Note: The carriage returns (LF or CR) are stripped off. |
| 1006 | """ |
| 1007 | return self._diff_cache.GetOldContents(self.LocalPath(), |
| 1008 | self._local_root).splitlines() |
| 1009 | |
| 1010 | def NewContents(self): |
| 1011 | """Returns an iterator over the lines in the new version of file. |
| 1012 | |
| 1013 | The new version is the file in the user's workspace, i.e. the 'right hand |
| 1014 | side'. |
| 1015 | |
| 1016 | Contents will be empty if the file is a directory or does not exist. |
| 1017 | Note: The carriage returns (LF or CR) are stripped off. |
| 1018 | """ |
| 1019 | if self._cached_new_contents is None: |
| 1020 | self._cached_new_contents = [] |
| 1021 | try: |
| 1022 | self._cached_new_contents = gclient_utils.FileRead( |
| 1023 | self.AbsoluteLocalPath(), 'rU').splitlines() |
| 1024 | except IOError: |
| 1025 | pass # File not found? That's fine; maybe it was deleted. |
| 1026 | except UnicodeDecodeError as e: |
| 1027 | # log the filename since we're probably trying to read a binary |
| 1028 | # file, and shouldn't be. |
| 1029 | print('Error reading %s: %s' % (self.AbsoluteLocalPath(), e)) |
| 1030 | raise |
| 1031 | |
| 1032 | return self._cached_new_contents[:] |
| 1033 | |
| 1034 | def ChangedContents(self, keeplinebreaks=False): |
| 1035 | """Returns a list of tuples (line number, line text) of all new lines. |
| 1036 | |
| 1037 | This relies on the scm diff output describing each changed code section |
| 1038 | with a line of the form |
| 1039 | |
| 1040 | ^@@ <old line num>,<old size> <new line num>,<new size> @@$ |
| 1041 | """ |
| 1042 | # Don't return cached results when line breaks are requested. |
| 1043 | if not keeplinebreaks and self._cached_changed_contents is not None: |
| 1044 | return self._cached_changed_contents[:] |
| 1045 | result = [] |
| 1046 | line_num = 0 |
| 1047 | |
| 1048 | # The keeplinebreaks parameter to splitlines must be True or else the |
| 1049 | # CheckForWindowsLineEndings presubmit will be a NOP. |
| 1050 | for line in self.GenerateScmDiff().splitlines(keeplinebreaks): |
| 1051 | m = re.match(r'^@@ [0-9\,\+\-]+ \+([0-9]+)\,[0-9]+ @@', line) |
| 1052 | if m: |
| 1053 | line_num = int(m.groups(1)[0]) |
| 1054 | continue |
| 1055 | if line.startswith('+') and not line.startswith('++'): |
| 1056 | result.append((line_num, line[1:])) |
| 1057 | if not line.startswith('-'): |
| 1058 | line_num += 1 |
| 1059 | # Don't cache results with line breaks. |
| 1060 | if keeplinebreaks: |
| 1061 | return result; |
| 1062 | self._cached_changed_contents = result |
| 1063 | return self._cached_changed_contents[:] |
| 1064 | |
| 1065 | def __str__(self): |
| 1066 | return self.LocalPath() |
| 1067 | |
| 1068 | def GenerateScmDiff(self): |
| 1069 | return self._diff_cache.GetDiff(self.LocalPath(), self._local_root) |
| 1070 | |
| 1071 | |
| 1072 | class GitAffectedFile(AffectedFile): |
| 1073 | """Representation of a file in a change out of a git checkout.""" |
| 1074 | # Method 'NNN' is abstract in class 'NNN' but is not overridden |
| 1075 | # pylint: disable=abstract-method |
| 1076 | |
| 1077 | DIFF_CACHE = _GitDiffCache |
| 1078 | |
| 1079 | def __init__(self, *args, **kwargs): |
| 1080 | AffectedFile.__init__(self, *args, **kwargs) |
| 1081 | self._server_path = None |
| 1082 | self._is_testable_file = None |
| 1083 | |
| 1084 | def IsTestableFile(self): |
| 1085 | if self._is_testable_file is None: |
| 1086 | if self.Action() == 'D': |
| 1087 | # A deleted file is not testable. |
| 1088 | self._is_testable_file = False |
| 1089 | else: |
| 1090 | self._is_testable_file = os.path.isfile(self.AbsoluteLocalPath()) |
| 1091 | return self._is_testable_file |
| 1092 | |
| 1093 | |
| 1094 | class Change(object): |
| 1095 | """Describe a change. |
| 1096 | |
| 1097 | Used directly by the presubmit scripts to query the current change being |
| 1098 | tested. |
| 1099 | |
| 1100 | Instance members: |
| 1101 | tags: Dictionary of KEY=VALUE pairs found in the change description. |
| 1102 | self.KEY: equivalent to tags['KEY'] |
| 1103 | """ |
| 1104 | |
| 1105 | _AFFECTED_FILES = AffectedFile |
| 1106 | |
| 1107 | # Matches key/value (or 'tag') lines in changelist descriptions. |
| 1108 | TAG_LINE_RE = re.compile( |
| 1109 | '^[ \t]*(?P<key>[A-Z][A-Z_0-9]*)[ \t]*=[ \t]*(?P<value>.*?)[ \t]*$') |
| 1110 | scm = '' |
| 1111 | |
| 1112 | def __init__( |
| 1113 | self, name, description, local_root, files, issue, patchset, author, |
| 1114 | upstream=None): |
| 1115 | if files is None: |
| 1116 | files = [] |
| 1117 | self._name = name |
| 1118 | # Convert root into an absolute path. |
| 1119 | self._local_root = os.path.abspath(local_root) |
| 1120 | self._upstream = upstream |
| 1121 | self.issue = issue |
| 1122 | self.patchset = patchset |
| 1123 | self.author_email = author |
| 1124 | |
| 1125 | self._full_description = '' |
| 1126 | self.tags = {} |
| 1127 | self._description_without_tags = '' |
| 1128 | self.SetDescriptionText(description) |
| 1129 | |
| 1130 | assert all( |
| 1131 | (isinstance(f, (list, tuple)) and len(f) == 2) for f in files), files |
| 1132 | |
| 1133 | diff_cache = self._AFFECTED_FILES.DIFF_CACHE(self._upstream) |
| 1134 | self._affected_files = [ |
| 1135 | self._AFFECTED_FILES(path, action.strip(), self._local_root, diff_cache) |
| 1136 | for action, path in files |
| 1137 | ] |
| 1138 | |
| 1139 | def UpstreamBranch(self): |
| 1140 | """Returns the upstream branch for the change.""" |
| 1141 | return self._upstream |
| 1142 | |
| 1143 | def Name(self): |
| 1144 | """Returns the change name.""" |
| 1145 | return self._name |
| 1146 | |
| 1147 | def DescriptionText(self): |
| 1148 | """Returns the user-entered changelist description, minus tags. |
| 1149 | |
| 1150 | Any line in the user-provided description starting with e.g. 'FOO=' |
| 1151 | (whitespace permitted before and around) is considered a tag line. Such |
| 1152 | lines are stripped out of the description this function returns. |
| 1153 | """ |
| 1154 | return self._description_without_tags |
| 1155 | |
| 1156 | def FullDescriptionText(self): |
| 1157 | """Returns the complete changelist description including tags.""" |
| 1158 | return self._full_description |
| 1159 | |
| 1160 | def SetDescriptionText(self, description): |
| 1161 | """Sets the full description text (including tags) to |description|. |
| 1162 | |
| 1163 | Also updates the list of tags.""" |
| 1164 | self._full_description = description |
| 1165 | |
| 1166 | # From the description text, build up a dictionary of key/value pairs |
| 1167 | # plus the description minus all key/value or 'tag' lines. |
| 1168 | description_without_tags = [] |
| 1169 | self.tags = {} |
| 1170 | for line in self._full_description.splitlines(): |
| 1171 | m = self.TAG_LINE_RE.match(line) |
| 1172 | if m: |
| 1173 | self.tags[m.group('key')] = m.group('value') |
| 1174 | else: |
| 1175 | description_without_tags.append(line) |
| 1176 | |
| 1177 | # Change back to text and remove whitespace at end. |
| 1178 | self._description_without_tags = ( |
| 1179 | '\n'.join(description_without_tags).rstrip()) |
| 1180 | |
| 1181 | def AddDescriptionFooter(self, key, value): |
| 1182 | """Adds the given footer to the change description. |
| 1183 | |
| 1184 | Args: |
| 1185 | key: A string with the key for the git footer. It must conform to |
| 1186 | the git footers format (i.e. 'List-Of-Tokens') and will be case |
| 1187 | normalized so that each token is title-cased. |
| 1188 | value: A string with the value for the git footer. |
| 1189 | """ |
| 1190 | description = git_footers.add_footer( |
| 1191 | self.FullDescriptionText(), git_footers.normalize_name(key), value) |
| 1192 | self.SetDescriptionText(description) |
| 1193 | |
| 1194 | def RepositoryRoot(self): |
| 1195 | """Returns the repository (checkout) root directory for this change, |
| 1196 | as an absolute path. |
| 1197 | """ |
| 1198 | return self._local_root |
| 1199 | |
| 1200 | def __getattr__(self, attr): |
| 1201 | """Return tags directly as attributes on the object.""" |
| 1202 | if not re.match(r'^[A-Z_]*$', attr): |
| 1203 | raise AttributeError(self, attr) |
| 1204 | return self.tags.get(attr) |
| 1205 | |
| 1206 | def GitFootersFromDescription(self): |
| 1207 | """Return the git footers present in the description. |
| 1208 | |
| 1209 | Returns: |
| 1210 | footers: A dict of {footer: [values]} containing a multimap of the footers |
| 1211 | in the change description. |
| 1212 | """ |
| 1213 | return git_footers.parse_footers(self.FullDescriptionText()) |
| 1214 | |
| 1215 | def BugsFromDescription(self): |
| 1216 | """Returns all bugs referenced in the commit description.""" |
| 1217 | bug_tags = ['BUG', 'FIXED'] |
| 1218 | |
| 1219 | tags = [] |
| 1220 | for tag in bug_tags: |
| 1221 | values = self.tags.get(tag) |
| 1222 | if values: |
| 1223 | tags += [value.strip() for value in values.split(',')] |
| 1224 | |
| 1225 | footers = [] |
| 1226 | parsed = self.GitFootersFromDescription() |
| 1227 | unsplit_footers = parsed.get('Bug', []) + parsed.get('Fixed', []) |
| 1228 | for unsplit_footer in unsplit_footers: |
| 1229 | footers += [b.strip() for b in unsplit_footer.split(',')] |
| 1230 | return sorted(set(tags + footers)) |
| 1231 | |
| 1232 | def ReviewersFromDescription(self): |
| 1233 | """Returns all reviewers listed in the commit description.""" |
| 1234 | # We don't support a 'R:' git-footer for reviewers; that is in metadata. |
| 1235 | tags = [r.strip() for r in self.tags.get('R', '').split(',') if r.strip()] |
| 1236 | return sorted(set(tags)) |
| 1237 | |
| 1238 | def TBRsFromDescription(self): |
| 1239 | """Returns all TBR reviewers listed in the commit description.""" |
| 1240 | tags = [r.strip() for r in self.tags.get('TBR', '').split(',') if r.strip()] |
| 1241 | # TODO(crbug.com/839208): Remove support for 'Tbr:' when TBRs are |
| 1242 | # programmatically determined by self-CR+1s. |
| 1243 | footers = self.GitFootersFromDescription().get('Tbr', []) |
| 1244 | return sorted(set(tags + footers)) |
| 1245 | |
| 1246 | # TODO(crbug.com/753425): Delete these once we're sure they're unused. |
| 1247 | @property |
| 1248 | def BUG(self): |
| 1249 | return ','.join(self.BugsFromDescription()) |
| 1250 | @property |
| 1251 | def R(self): |
| 1252 | return ','.join(self.ReviewersFromDescription()) |
| 1253 | @property |
| 1254 | def TBR(self): |
| 1255 | return ','.join(self.TBRsFromDescription()) |
| 1256 | |
| 1257 | def AllFiles(self, root=None): |
| 1258 | """List all files under source control in the repo.""" |
| 1259 | raise NotImplementedError() |
| 1260 | |
| 1261 | def AffectedFiles(self, include_deletes=True, file_filter=None): |
| 1262 | """Returns a list of AffectedFile instances for all files in the change. |
| 1263 | |
| 1264 | Args: |
| 1265 | include_deletes: If false, deleted files will be filtered out. |
| 1266 | file_filter: An additional filter to apply. |
| 1267 | |
| 1268 | Returns: |
| 1269 | [AffectedFile(path, action), AffectedFile(path, action)] |
| 1270 | """ |
| 1271 | affected = list(filter(file_filter, self._affected_files)) |
| 1272 | |
| 1273 | if include_deletes: |
| 1274 | return affected |
| 1275 | return list(filter(lambda x: x.Action() != 'D', affected)) |
| 1276 | |
| 1277 | def AffectedTestableFiles(self, include_deletes=None, **kwargs): |
| 1278 | """Return a list of the existing text files in a change.""" |
| 1279 | if include_deletes is not None: |
| 1280 | warn('AffectedTeestableFiles(include_deletes=%s)' |
| 1281 | ' is deprecated and ignored' % str(include_deletes), |
| 1282 | category=DeprecationWarning, |
| 1283 | stacklevel=2) |
| 1284 | return list(filter( |
| 1285 | lambda x: x.IsTestableFile(), |
| 1286 | self.AffectedFiles(include_deletes=False, **kwargs))) |
| 1287 | |
| 1288 | def AffectedTextFiles(self, include_deletes=None): |
| 1289 | """An alias to AffectedTestableFiles for backwards compatibility.""" |
| 1290 | return self.AffectedTestableFiles(include_deletes=include_deletes) |
| 1291 | |
| 1292 | def LocalPaths(self): |
| 1293 | """Convenience function.""" |
| 1294 | return [af.LocalPath() for af in self.AffectedFiles()] |
| 1295 | |
| 1296 | def AbsoluteLocalPaths(self): |
| 1297 | """Convenience function.""" |
| 1298 | return [af.AbsoluteLocalPath() for af in self.AffectedFiles()] |
| 1299 | |
| 1300 | def RightHandSideLines(self): |
| 1301 | """An iterator over all text lines in 'new' version of changed files. |
| 1302 | |
| 1303 | Lists lines from new or modified text files in the change. |
| 1304 | |
| 1305 | This is useful for doing line-by-line regex checks, like checking for |
| 1306 | trailing whitespace. |
| 1307 | |
| 1308 | Yields: |
| 1309 | a 3 tuple: |
| 1310 | the AffectedFile instance of the current file; |
| 1311 | integer line number (1-based); and |
| 1312 | the contents of the line as a string. |
| 1313 | """ |
| 1314 | return _RightHandSideLinesImpl( |
| 1315 | x for x in self.AffectedFiles(include_deletes=False) |
| 1316 | if x.IsTestableFile()) |
| 1317 | |
| 1318 | def OriginalOwnersFiles(self): |
| 1319 | """A map from path names of affected OWNERS files to their old content.""" |
| 1320 | def owners_file_filter(f): |
| 1321 | return 'OWNERS' in os.path.split(f.LocalPath())[1] |
| 1322 | files = self.AffectedFiles(file_filter=owners_file_filter) |
| 1323 | return {f.LocalPath(): f.OldContents() for f in files} |
| 1324 | |
| 1325 | |
| 1326 | class GitChange(Change): |
| 1327 | _AFFECTED_FILES = GitAffectedFile |
| 1328 | scm = 'git' |
| 1329 | |
| 1330 | def AllFiles(self, root=None): |
| 1331 | """List all files under source control in the repo.""" |
| 1332 | root = root or self.RepositoryRoot() |
| 1333 | return subprocess.check_output( |
| 1334 | ['git', '-c', 'core.quotePath=false', 'ls-files', '--', '.'], |
| 1335 | cwd=root).decode('utf-8', 'ignore').splitlines() |
| 1336 | |
| 1337 | |
Josip Sokcevic | a9a7eec | 2023-03-10 03:54:52 +0000 | [diff] [blame] | 1338 | def ListRelevantPresubmitFiles(files, root): |
| 1339 | """Finds all presubmit files that apply to a given set of source files. |
| 1340 | |
| 1341 | If inherit-review-settings-ok is present right under root, looks for |
| 1342 | PRESUBMIT.py in directories enclosing root. |
| 1343 | |
| 1344 | Args: |
| 1345 | files: An iterable container containing file paths. |
| 1346 | root: Path where to stop searching. |
| 1347 | |
| 1348 | Return: |
| 1349 | List of absolute paths of the existing PRESUBMIT.py scripts. |
| 1350 | """ |
| 1351 | files = [normpath(os.path.join(root, f)) for f in files] |
| 1352 | |
| 1353 | # List all the individual directories containing files. |
| 1354 | directories = {os.path.dirname(f) for f in files} |
| 1355 | |
| 1356 | # Ignore root if inherit-review-settings-ok is present. |
| 1357 | if os.path.isfile(os.path.join(root, 'inherit-review-settings-ok')): |
| 1358 | root = None |
| 1359 | |
| 1360 | # Collect all unique directories that may contain PRESUBMIT.py. |
| 1361 | candidates = set() |
| 1362 | for directory in directories: |
| 1363 | while True: |
| 1364 | if directory in candidates: |
| 1365 | break |
| 1366 | candidates.add(directory) |
| 1367 | if directory == root: |
| 1368 | break |
| 1369 | parent_dir = os.path.dirname(directory) |
| 1370 | if parent_dir == directory: |
| 1371 | # We hit the system root directory. |
| 1372 | break |
| 1373 | directory = parent_dir |
| 1374 | |
| 1375 | # Look for PRESUBMIT.py in all candidate directories. |
| 1376 | results = [] |
| 1377 | for directory in sorted(list(candidates)): |
| 1378 | try: |
| 1379 | for f in os.listdir(directory): |
| 1380 | p = os.path.join(directory, f) |
| 1381 | if os.path.isfile(p) and re.match( |
| 1382 | r'PRESUBMIT.*\.py$', f) and not f.startswith('PRESUBMIT_test'): |
| 1383 | results.append(p) |
| 1384 | except OSError: |
| 1385 | pass |
| 1386 | |
| 1387 | logging.debug('Presubmit files: %s', ','.join(results)) |
| 1388 | return results |
| 1389 | |
| 1390 | |
rmistry@google.com | 5626a92 | 2015-02-26 14:03:30 +0000 | [diff] [blame] | 1391 | class GetPostUploadExecuter(object): |
Robert Iannucci | 3d6d2d2 | 2023-05-11 17:25:05 +0000 | [diff] [blame] | 1392 | def __init__(self, change, gerrit_obj): |
Josip Sokcevic | e293d3d | 2022-02-16 22:52:15 +0000 | [diff] [blame] | 1393 | """ |
| 1394 | Args: |
Pavol Marko | 624e7ee | 2023-01-09 09:56:29 +0000 | [diff] [blame] | 1395 | change: The Change object. |
| 1396 | gerrit_obj: provides basic Gerrit codereview functionality. |
Josip Sokcevic | e293d3d | 2022-02-16 22:52:15 +0000 | [diff] [blame] | 1397 | """ |
Pavol Marko | 624e7ee | 2023-01-09 09:56:29 +0000 | [diff] [blame] | 1398 | self.change = change |
| 1399 | self.gerrit = gerrit_obj |
Josip Sokcevic | e293d3d | 2022-02-16 22:52:15 +0000 | [diff] [blame] | 1400 | |
Pavol Marko | 624e7ee | 2023-01-09 09:56:29 +0000 | [diff] [blame] | 1401 | def ExecPresubmitScript(self, script_text, presubmit_path): |
rmistry@google.com | 5626a92 | 2015-02-26 14:03:30 +0000 | [diff] [blame] | 1402 | """Executes PostUploadHook() from a single presubmit script. |
Josip Sokcevic | 632bbc0 | 2022-05-19 05:32:50 +0000 | [diff] [blame] | 1403 | Caller is responsible for validating whether the hook should be executed |
| 1404 | and should only call this function if it should be. |
rmistry@google.com | 5626a92 | 2015-02-26 14:03:30 +0000 | [diff] [blame] | 1405 | |
| 1406 | Args: |
| 1407 | script_text: The text of the presubmit script. |
| 1408 | presubmit_path: Project script to run. |
rmistry@google.com | 5626a92 | 2015-02-26 14:03:30 +0000 | [diff] [blame] | 1409 | |
| 1410 | Return: |
| 1411 | A list of results objects. |
| 1412 | """ |
Pavol Marko | 624e7ee | 2023-01-09 09:56:29 +0000 | [diff] [blame] | 1413 | # Change to the presubmit file's directory to support local imports. |
| 1414 | presubmit_dir = os.path.dirname(presubmit_path) |
| 1415 | main_path = os.getcwd() |
| 1416 | try: |
| 1417 | os.chdir(presubmit_dir) |
| 1418 | return self._execute_with_local_working_directory(script_text, |
| 1419 | presubmit_dir, |
| 1420 | presubmit_path) |
| 1421 | finally: |
| 1422 | # Return the process to the original working directory. |
| 1423 | os.chdir(main_path) |
| 1424 | |
| 1425 | def _execute_with_local_working_directory(self, script_text, presubmit_dir, |
| 1426 | presubmit_path): |
rmistry@google.com | 5626a92 | 2015-02-26 14:03:30 +0000 | [diff] [blame] | 1427 | context = {} |
| 1428 | try: |
Pavol Marko | 624e7ee | 2023-01-09 09:56:29 +0000 | [diff] [blame] | 1429 | exec(compile(script_text, presubmit_path, 'exec', dont_inherit=True), |
Raul Tambre | 09e64b4 | 2019-05-14 01:57:22 +0000 | [diff] [blame] | 1430 | context) |
Raul Tambre | 7c93846 | 2019-05-24 16:35:35 +0000 | [diff] [blame] | 1431 | except Exception as e: |
rmistry@google.com | 5626a92 | 2015-02-26 14:03:30 +0000 | [diff] [blame] | 1432 | raise PresubmitFailure('"%s" had an exception.\n%s' |
| 1433 | % (presubmit_path, e)) |
| 1434 | |
| 1435 | function_name = 'PostUploadHook' |
| 1436 | if function_name not in context: |
| 1437 | return {} |
| 1438 | post_upload_hook = context[function_name] |
| 1439 | if not len(inspect.getargspec(post_upload_hook)[0]) == 3: |
| 1440 | raise PresubmitFailure( |
| 1441 | 'Expected function "PostUploadHook" to take three arguments.') |
Pavol Marko | 624e7ee | 2023-01-09 09:56:29 +0000 | [diff] [blame] | 1442 | return post_upload_hook(self.gerrit, self.change, OutputApi(False)) |
rmistry@google.com | 5626a92 | 2015-02-26 14:03:30 +0000 | [diff] [blame] | 1443 | |
| 1444 | |
machenbach@chromium.org | 58a69cb | 2014-03-01 02:08:29 +0000 | [diff] [blame] | 1445 | def _MergeMasters(masters1, masters2): |
| 1446 | """Merges two master maps. Merges also the tests of each builder.""" |
| 1447 | result = {} |
Marc-Antoine Ruel | 8e57b4b | 2019-10-11 01:01:36 +0000 | [diff] [blame] | 1448 | for (master, builders) in itertools.chain(masters1.items(), |
| 1449 | masters2.items()): |
machenbach@chromium.org | 58a69cb | 2014-03-01 02:08:29 +0000 | [diff] [blame] | 1450 | new_builders = result.setdefault(master, {}) |
Marc-Antoine Ruel | 8e57b4b | 2019-10-11 01:01:36 +0000 | [diff] [blame] | 1451 | for (builder, tests) in builders.items(): |
machenbach@chromium.org | 58a69cb | 2014-03-01 02:08:29 +0000 | [diff] [blame] | 1452 | new_builders.setdefault(builder, set([])).update(tests) |
| 1453 | return result |
| 1454 | |
| 1455 | |
Robert Iannucci | 3d6d2d2 | 2023-05-11 17:25:05 +0000 | [diff] [blame] | 1456 | def DoPostUploadExecuter(change, gerrit_obj, verbose): |
rmistry@google.com | 5626a92 | 2015-02-26 14:03:30 +0000 | [diff] [blame] | 1457 | """Execute the post upload hook. |
| 1458 | |
| 1459 | Args: |
| 1460 | change: The Change object. |
Edward Lemur | 016a087 | 2020-02-04 22:13:28 +0000 | [diff] [blame] | 1461 | gerrit_obj: The GerritAccessor object. |
rmistry@google.com | 5626a92 | 2015-02-26 14:03:30 +0000 | [diff] [blame] | 1462 | verbose: Prints debug info. |
rmistry@google.com | 5626a92 | 2015-02-26 14:03:30 +0000 | [diff] [blame] | 1463 | """ |
Josip Sokcevic | e293d3d | 2022-02-16 22:52:15 +0000 | [diff] [blame] | 1464 | python_version = 'Python %s' % sys.version_info.major |
| 1465 | sys.stdout.write('Running %s post upload checks ...\n' % python_version) |
Josip Sokcevic | a9a7eec | 2023-03-10 03:54:52 +0000 | [diff] [blame] | 1466 | presubmit_files = ListRelevantPresubmitFiles( |
| 1467 | change.LocalPaths(), change.RepositoryRoot()) |
rmistry@google.com | 5626a92 | 2015-02-26 14:03:30 +0000 | [diff] [blame] | 1468 | if not presubmit_files and verbose: |
Edward Lemur | 6eb1d32 | 2020-02-27 22:20:15 +0000 | [diff] [blame] | 1469 | sys.stdout.write('Warning, no PRESUBMIT.py found.\n') |
rmistry@google.com | 5626a92 | 2015-02-26 14:03:30 +0000 | [diff] [blame] | 1470 | results = [] |
Robert Iannucci | 3d6d2d2 | 2023-05-11 17:25:05 +0000 | [diff] [blame] | 1471 | executer = GetPostUploadExecuter(change, gerrit_obj) |
rmistry@google.com | 5626a92 | 2015-02-26 14:03:30 +0000 | [diff] [blame] | 1472 | # The root presubmit file should be executed after the ones in subdirectories. |
| 1473 | # i.e. the specific post upload hooks should run before the general ones. |
Josip Sokcevic | a9a7eec | 2023-03-10 03:54:52 +0000 | [diff] [blame] | 1474 | # Thus, reverse the order provided by ListRelevantPresubmitFiles. |
rmistry@google.com | 5626a92 | 2015-02-26 14:03:30 +0000 | [diff] [blame] | 1475 | presubmit_files.reverse() |
| 1476 | |
| 1477 | for filename in presubmit_files: |
| 1478 | filename = os.path.abspath(filename) |
rmistry@google.com | 5626a92 | 2015-02-26 14:03:30 +0000 | [diff] [blame] | 1479 | # Accept CRLF presubmit script. |
Bruce Dawson | 6e70e86 | 2022-07-01 19:37:01 +0000 | [diff] [blame] | 1480 | presubmit_script = gclient_utils.FileRead(filename).replace('\r\n', '\n') |
Robert Iannucci | 3d6d2d2 | 2023-05-11 17:25:05 +0000 | [diff] [blame] | 1481 | if verbose: |
| 1482 | sys.stdout.write('Running %s\n' % filename) |
| 1483 | results.extend(executer.ExecPresubmitScript(presubmit_script, filename)) |
rmistry@google.com | 5626a92 | 2015-02-26 14:03:30 +0000 | [diff] [blame] | 1484 | |
Edward Lemur | 6eb1d32 | 2020-02-27 22:20:15 +0000 | [diff] [blame] | 1485 | if not results: |
| 1486 | return 0 |
| 1487 | |
| 1488 | sys.stdout.write('\n') |
| 1489 | sys.stdout.write('** Post Upload Hook Messages **\n') |
| 1490 | |
| 1491 | exit_code = 0 |
| 1492 | for result in results: |
| 1493 | if result.fatal: |
| 1494 | exit_code = 1 |
| 1495 | result.handle() |
| 1496 | sys.stdout.write('\n') |
| 1497 | |
| 1498 | return exit_code |
rmistry@google.com | 5626a92 | 2015-02-26 14:03:30 +0000 | [diff] [blame] | 1499 | |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1500 | class PresubmitExecuter(object): |
Saagar Sanghavi | 531d992 | 2020-08-10 20:14:01 +0000 | [diff] [blame] | 1501 | def __init__(self, change, committing, verbose, gerrit_obj, dry_run=None, |
Robert Iannucci | 3d6d2d2 | 2023-05-11 17:25:05 +0000 | [diff] [blame] | 1502 | thread_pool=None, parallel=False, no_diffs=False): |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1503 | """ |
| 1504 | Args: |
maruel@chromium.org | 4ff922a | 2009-06-12 20:20:19 +0000 | [diff] [blame] | 1505 | change: The Change object. |
agable | 92bec4f | 2016-08-24 09:27:27 -0700 | [diff] [blame] | 1506 | committing: True if 'git cl land' is running, False if 'git cl upload' is. |
tandrii@chromium.org | 37b07a7 | 2016-04-29 16:42:28 +0000 | [diff] [blame] | 1507 | gerrit_obj: provides basic Gerrit codereview functionality. |
| 1508 | dry_run: if true, some Checks will be skipped. |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 1509 | parallel: if true, all tests reported via input_api.RunTests for all |
| 1510 | PRESUBMIT files will be run in parallel. |
Bruce Dawson | 09c0c07 | 2022-05-26 20:28:58 +0000 | [diff] [blame] | 1511 | no_diffs: if true, implies that --files or --all was specified so some |
| 1512 | checks can be skipped, and some errors will be messages. |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1513 | """ |
maruel@chromium.org | 4ff922a | 2009-06-12 20:20:19 +0000 | [diff] [blame] | 1514 | self.change = change |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1515 | self.committing = committing |
tandrii@chromium.org | 37b07a7 | 2016-04-29 16:42:28 +0000 | [diff] [blame] | 1516 | self.gerrit = gerrit_obj |
maruel@chromium.org | 899e1c1 | 2011-04-07 17:03:18 +0000 | [diff] [blame] | 1517 | self.verbose = verbose |
tandrii@chromium.org | 57bafac | 2016-04-28 05:09:03 +0000 | [diff] [blame] | 1518 | self.dry_run = dry_run |
Daniel Cheng | 7227d21 | 2017-11-17 08:12:37 -0800 | [diff] [blame] | 1519 | self.more_cc = [] |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 1520 | self.thread_pool = thread_pool |
| 1521 | self.parallel = parallel |
Bruce Dawson | 09c0c07 | 2022-05-26 20:28:58 +0000 | [diff] [blame] | 1522 | self.no_diffs = no_diffs |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1523 | |
| 1524 | def ExecPresubmitScript(self, script_text, presubmit_path): |
| 1525 | """Executes a single presubmit script. |
Josip Sokcevic | 632bbc0 | 2022-05-19 05:32:50 +0000 | [diff] [blame] | 1526 | Caller is responsible for validating whether the hook should be executed |
| 1527 | and should only call this function if it should be. |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1528 | |
| 1529 | Args: |
| 1530 | script_text: The text of the presubmit script. |
| 1531 | presubmit_path: The path to the presubmit file (this will be reported via |
| 1532 | input_api.PresubmitLocalPath()). |
| 1533 | |
| 1534 | Return: |
| 1535 | A list of result objects, empty if no problems. |
| 1536 | """ |
chase@chromium.org | 8e416c8 | 2009-10-06 04:30:44 +0000 | [diff] [blame] | 1537 | # Change to the presubmit file's directory to support local imports. |
Saagar Sanghavi | 98b332f | 2020-07-31 17:19:15 +0000 | [diff] [blame] | 1538 | presubmit_dir = os.path.dirname(presubmit_path) |
Pavol Marko | 624e7ee | 2023-01-09 09:56:29 +0000 | [diff] [blame] | 1539 | main_path = os.getcwd() |
| 1540 | try: |
| 1541 | os.chdir(presubmit_dir) |
| 1542 | return self._execute_with_local_working_directory(script_text, |
| 1543 | presubmit_dir, |
| 1544 | presubmit_path) |
| 1545 | finally: |
| 1546 | # Return the process to the original working directory. |
| 1547 | os.chdir(main_path) |
chase@chromium.org | 8e416c8 | 2009-10-06 04:30:44 +0000 | [diff] [blame] | 1548 | |
Pavol Marko | 624e7ee | 2023-01-09 09:56:29 +0000 | [diff] [blame] | 1549 | def _execute_with_local_working_directory(self, script_text, presubmit_dir, |
| 1550 | presubmit_path): |
chase@chromium.org | 8e416c8 | 2009-10-06 04:30:44 +0000 | [diff] [blame] | 1551 | # Load the presubmit script into context. |
dpranke@chromium.org | 970c522 | 2011-03-12 00:32:24 +0000 | [diff] [blame] | 1552 | input_api = InputApi(self.change, presubmit_path, self.committing, |
Aaron Gable | 668c1d8 | 2018-04-03 10:19:16 -0700 | [diff] [blame] | 1553 | self.verbose, gerrit_obj=self.gerrit, |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 1554 | dry_run=self.dry_run, thread_pool=self.thread_pool, |
Bruce Dawson | 09c0c07 | 2022-05-26 20:28:58 +0000 | [diff] [blame] | 1555 | parallel=self.parallel, no_diffs=self.no_diffs) |
Daniel Cheng | 7227d21 | 2017-11-17 08:12:37 -0800 | [diff] [blame] | 1556 | output_api = OutputApi(self.committing) |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1557 | context = {} |
Saagar Sanghavi | 03b1513 | 2020-08-10 16:43:41 +0000 | [diff] [blame] | 1558 | |
maruel@chromium.org | 899e1c1 | 2011-04-07 17:03:18 +0000 | [diff] [blame] | 1559 | try: |
Bruce Dawson | 0ba2fd4 | 2022-07-21 13:47:21 +0000 | [diff] [blame] | 1560 | exec(compile(script_text, presubmit_path, 'exec', dont_inherit=True), |
Raul Tambre | 09e64b4 | 2019-05-14 01:57:22 +0000 | [diff] [blame] | 1561 | context) |
Raul Tambre | 7c93846 | 2019-05-24 16:35:35 +0000 | [diff] [blame] | 1562 | except Exception as e: |
maruel@chromium.org | 899e1c1 | 2011-04-07 17:03:18 +0000 | [diff] [blame] | 1563 | raise PresubmitFailure('"%s" had an exception.\n%s' % (presubmit_path, e)) |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1564 | |
Saagar Sanghavi | 03b1513 | 2020-08-10 16:43:41 +0000 | [diff] [blame] | 1565 | context['__args'] = (input_api, output_api) |
Ben Pastene | 8351dc1 | 2020-08-06 05:01:35 +0000 | [diff] [blame] | 1566 | |
Saagar Sanghavi | 531d992 | 2020-08-10 20:14:01 +0000 | [diff] [blame] | 1567 | # Get path of presubmit directory relative to repository root. |
Saagar Sanghavi | 03b1513 | 2020-08-10 16:43:41 +0000 | [diff] [blame] | 1568 | # Always use forward slashes, so that path is same in *nix and Windows |
| 1569 | root = input_api.change.RepositoryRoot() |
| 1570 | rel_path = os.path.relpath(presubmit_dir, root) |
| 1571 | rel_path = rel_path.replace(os.path.sep, '/') |
Ben Pastene | 8351dc1 | 2020-08-06 05:01:35 +0000 | [diff] [blame] | 1572 | |
Saagar Sanghavi | 531d992 | 2020-08-10 20:14:01 +0000 | [diff] [blame] | 1573 | # Get the URL of git remote origin and use it to identify host and project |
Edward Lesmes | eb1bd62 | 2021-03-01 19:54:07 +0000 | [diff] [blame] | 1574 | host = project = '' |
| 1575 | if self.gerrit: |
| 1576 | host = self.gerrit.host or '' |
| 1577 | project = self.gerrit.project or '' |
Saagar Sanghavi | 531d992 | 2020-08-10 20:14:01 +0000 | [diff] [blame] | 1578 | |
| 1579 | # Prefix for test names |
| 1580 | prefix = 'presubmit:%s/%s:%s/' % (host, project, rel_path) |
| 1581 | |
Saagar Sanghavi | 03b1513 | 2020-08-10 16:43:41 +0000 | [diff] [blame] | 1582 | # Perform all the desired presubmit checks. |
| 1583 | results = [] |
Ben Pastene | 8351dc1 | 2020-08-06 05:01:35 +0000 | [diff] [blame] | 1584 | |
Saagar Sanghavi | 03b1513 | 2020-08-10 16:43:41 +0000 | [diff] [blame] | 1585 | try: |
Scott Lee | cc2fe9b | 2020-11-19 19:38:06 +0000 | [diff] [blame] | 1586 | version = [ |
| 1587 | int(x) for x in context.get('PRESUBMIT_VERSION', '0.0.0').split('.') |
| 1588 | ] |
Saagar Sanghavi | 03b1513 | 2020-08-10 16:43:41 +0000 | [diff] [blame] | 1589 | |
Scott Lee | cc2fe9b | 2020-11-19 19:38:06 +0000 | [diff] [blame] | 1590 | with rdb_wrapper.client(prefix) as sink: |
| 1591 | if version >= [2, 0, 0]: |
Andrew Grieve | bdfb8f2 | 2022-02-02 21:56:47 +0000 | [diff] [blame] | 1592 | # Copy the keys to prevent "dictionary changed size during iteration" |
| 1593 | # exception if checks add globals to context. E.g. sometimes the |
| 1594 | # Python runtime will add __warningregistry__. |
| 1595 | for function_name in list(context.keys()): |
Scott Lee | cc2fe9b | 2020-11-19 19:38:06 +0000 | [diff] [blame] | 1596 | if not function_name.startswith('Check'): |
| 1597 | continue |
| 1598 | if function_name.endswith('Commit') and not self.committing: |
| 1599 | continue |
| 1600 | if function_name.endswith('Upload') and self.committing: |
| 1601 | continue |
Saagar Sanghavi | 03b1513 | 2020-08-10 16:43:41 +0000 | [diff] [blame] | 1602 | logging.debug('Running %s in %s', function_name, presubmit_path) |
| 1603 | results.extend( |
Bruce Dawson | 8fa42e2 | 2022-03-29 17:05:38 +0000 | [diff] [blame] | 1604 | self._run_check_function(function_name, context, sink, |
| 1605 | presubmit_path)) |
Scott Lee | cc2fe9b | 2020-11-19 19:38:06 +0000 | [diff] [blame] | 1606 | logging.debug('Running %s done.', function_name) |
| 1607 | self.more_cc.extend(output_api.more_cc) |
Daniel Cheng | 541638f | 2023-05-15 22:00:47 +0000 | [diff] [blame] | 1608 | # Clear the CC list between running each presubmit check to prevent |
| 1609 | # CCs from being repeatedly appended. |
| 1610 | output_api.more_cc = [] |
Scott Lee | cc2fe9b | 2020-11-19 19:38:06 +0000 | [diff] [blame] | 1611 | |
| 1612 | else: # Old format |
| 1613 | if self.committing: |
| 1614 | function_name = 'CheckChangeOnCommit' |
| 1615 | else: |
| 1616 | function_name = 'CheckChangeOnUpload' |
Andrew Grieve | bdfb8f2 | 2022-02-02 21:56:47 +0000 | [diff] [blame] | 1617 | if function_name in list(context.keys()): |
Scott Lee | cc2fe9b | 2020-11-19 19:38:06 +0000 | [diff] [blame] | 1618 | logging.debug('Running %s in %s', function_name, presubmit_path) |
| 1619 | results.extend( |
Bruce Dawson | 8fa42e2 | 2022-03-29 17:05:38 +0000 | [diff] [blame] | 1620 | self._run_check_function(function_name, context, sink, |
| 1621 | presubmit_path)) |
Saagar Sanghavi | 03b1513 | 2020-08-10 16:43:41 +0000 | [diff] [blame] | 1622 | logging.debug('Running %s done.', function_name) |
| 1623 | self.more_cc.extend(output_api.more_cc) |
Daniel Cheng | 541638f | 2023-05-15 22:00:47 +0000 | [diff] [blame] | 1624 | # Clear the CC list between running each presubmit check to prevent |
| 1625 | # CCs from being repeatedly appended. |
| 1626 | output_api.more_cc = [] |
Saagar Sanghavi | 03b1513 | 2020-08-10 16:43:41 +0000 | [diff] [blame] | 1627 | |
| 1628 | finally: |
| 1629 | for f in input_api._named_temporary_files: |
| 1630 | os.remove(f) |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1631 | |
Daniel Cheng | 541638f | 2023-05-15 22:00:47 +0000 | [diff] [blame] | 1632 | self.more_cc = sorted(set(self.more_cc)) |
| 1633 | |
Saagar Sanghavi | 03b1513 | 2020-08-10 16:43:41 +0000 | [diff] [blame] | 1634 | return results |
| 1635 | |
Bruce Dawson | 8fa42e2 | 2022-03-29 17:05:38 +0000 | [diff] [blame] | 1636 | def _run_check_function(self, function_name, context, sink, presubmit_path): |
Scott Lee | cc2fe9b | 2020-11-19 19:38:06 +0000 | [diff] [blame] | 1637 | """Evaluates and returns the result of a given presubmit function. |
| 1638 | |
| 1639 | If sink is given, the result of the presubmit function will be reported |
| 1640 | to the ResultSink. |
Saagar Sanghavi | 03b1513 | 2020-08-10 16:43:41 +0000 | [diff] [blame] | 1641 | |
| 1642 | Args: |
Scott Lee | cc2fe9b | 2020-11-19 19:38:06 +0000 | [diff] [blame] | 1643 | function_name: the name of the presubmit function to evaluate |
Saagar Sanghavi | 03b1513 | 2020-08-10 16:43:41 +0000 | [diff] [blame] | 1644 | context: a context dictionary in which the function will be evaluated |
Scott Lee | cc2fe9b | 2020-11-19 19:38:06 +0000 | [diff] [blame] | 1645 | sink: an instance of ResultSink. None, by default. |
| 1646 | Returns: |
| 1647 | the result of the presubmit function call. |
| 1648 | """ |
| 1649 | start_time = time_time() |
| 1650 | try: |
Saagar Sanghavi | 03b1513 | 2020-08-10 16:43:41 +0000 | [diff] [blame] | 1651 | result = eval(function_name + '(*__args)', context) |
| 1652 | self._check_result_type(result) |
Allen Webb | fe7d709 | 2021-05-18 02:05:49 +0000 | [diff] [blame] | 1653 | except Exception: |
Bruce Dawson | 10a8286 | 2022-05-27 19:25:56 +0000 | [diff] [blame] | 1654 | _, e_value, _ = sys.exc_info() |
| 1655 | result = [ |
| 1656 | OutputApi.PresubmitError( |
| 1657 | 'Evaluation of %s failed: %s, %s' % |
| 1658 | (function_name, e_value, traceback.format_exc())) |
| 1659 | ] |
Scott Lee | cc2fe9b | 2020-11-19 19:38:06 +0000 | [diff] [blame] | 1660 | |
Bruce Dawson | 2bdc49f | 2021-05-21 19:13:03 +0000 | [diff] [blame] | 1661 | elapsed_time = time_time() - start_time |
| 1662 | if elapsed_time > 10.0: |
Bruce Dawson | 6757d46 | 2022-07-13 04:04:40 +0000 | [diff] [blame] | 1663 | sys.stdout.write('%6.1fs to run %s from %s.\n' % |
| 1664 | (elapsed_time, function_name, presubmit_path)) |
Scott Lee | cc2fe9b | 2020-11-19 19:38:06 +0000 | [diff] [blame] | 1665 | if sink: |
Erik Staab | 9f38b63 | 2022-10-31 14:05:24 +0000 | [diff] [blame] | 1666 | failure_reason = None |
Scott Lee | cc2fe9b | 2020-11-19 19:38:06 +0000 | [diff] [blame] | 1667 | status = rdb_wrapper.STATUS_PASS |
| 1668 | if any(r.fatal for r in result): |
| 1669 | status = rdb_wrapper.STATUS_FAIL |
Erik Staab | 9f38b63 | 2022-10-31 14:05:24 +0000 | [diff] [blame] | 1670 | failure_reasons = [] |
| 1671 | for r in result: |
| 1672 | fields = r.json_format() |
| 1673 | message = fields['message'] |
| 1674 | items = '\n'.join(' %s' % item for item in fields['items']) |
| 1675 | failure_reasons.append('\n'.join([message, items])) |
| 1676 | if failure_reasons: |
| 1677 | failure_reason = '\n'.join(failure_reasons) |
| 1678 | sink.report(function_name, status, elapsed_time, failure_reason) |
Scott Lee | cc2fe9b | 2020-11-19 19:38:06 +0000 | [diff] [blame] | 1679 | |
| 1680 | return result |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1681 | |
Saagar Sanghavi | 9949ab7 | 2020-07-20 20:56:40 +0000 | [diff] [blame] | 1682 | def _check_result_type(self, result): |
| 1683 | """Helper function which ensures result is a list, and all elements are |
| 1684 | instances of OutputApi.PresubmitResult""" |
| 1685 | if not isinstance(result, (tuple, list)): |
| 1686 | raise PresubmitFailure('Presubmit functions must return a tuple or list') |
| 1687 | if not all(isinstance(res, OutputApi.PresubmitResult) for res in result): |
| 1688 | raise PresubmitFailure( |
| 1689 | 'All presubmit results must be of types derived from ' |
| 1690 | 'output_api.PresubmitResult') |
| 1691 | |
| 1692 | |
maruel@chromium.org | 4ff922a | 2009-06-12 20:20:19 +0000 | [diff] [blame] | 1693 | def DoPresubmitChecks(change, |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1694 | committing, |
| 1695 | verbose, |
maruel@chromium.org | b0dfd35 | 2009-06-10 14:12:54 +0000 | [diff] [blame] | 1696 | default_presubmit, |
dpranke@chromium.org | 970c522 | 2011-03-12 00:32:24 +0000 | [diff] [blame] | 1697 | may_prompt, |
Aaron Gable | 668c1d8 | 2018-04-03 10:19:16 -0700 | [diff] [blame] | 1698 | gerrit_obj, |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 1699 | dry_run=None, |
Debrian Figueroa | dd2737e | 2019-06-21 23:50:13 +0000 | [diff] [blame] | 1700 | parallel=False, |
Dirk Pranke | 6f0df68 | 2021-06-25 00:42:33 +0000 | [diff] [blame] | 1701 | json_output=None, |
Bruce Dawson | 09c0c07 | 2022-05-26 20:28:58 +0000 | [diff] [blame] | 1702 | no_diffs=False): |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1703 | """Runs all presubmit checks that apply to the files in the change. |
| 1704 | |
| 1705 | This finds all PRESUBMIT.py files in directories enclosing the files in the |
| 1706 | change (up to the repository root) and calls the relevant entrypoint function |
| 1707 | depending on whether the change is being committed or uploaded. |
| 1708 | |
| 1709 | Prints errors, warnings and notifications. Prompts the user for warnings |
| 1710 | when needed. |
| 1711 | |
| 1712 | Args: |
maruel@chromium.org | 4ff922a | 2009-06-12 20:20:19 +0000 | [diff] [blame] | 1713 | change: The Change object. |
agable | 92bec4f | 2016-08-24 09:27:27 -0700 | [diff] [blame] | 1714 | committing: True if 'git cl land' is running, False if 'git cl upload' is. |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1715 | verbose: Prints debug info. |
maruel@chromium.org | 0ff1fab | 2009-05-22 13:08:15 +0000 | [diff] [blame] | 1716 | default_presubmit: A default presubmit script to execute in any case. |
Quinten Yearsley | 516fe7f | 2016-12-14 11:50:18 -0800 | [diff] [blame] | 1717 | may_prompt: Enable (y/n) questions on warning or error. If False, |
| 1718 | any questions are answered with yes by default. |
tandrii@chromium.org | 37b07a7 | 2016-04-29 16:42:28 +0000 | [diff] [blame] | 1719 | gerrit_obj: provides basic Gerrit codereview functionality. |
tandrii@chromium.org | 57bafac | 2016-04-28 05:09:03 +0000 | [diff] [blame] | 1720 | dry_run: if true, some Checks will be skipped. |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 1721 | parallel: if true, all tests specified by input_api.RunTests in all |
| 1722 | PRESUBMIT files will be run in parallel. |
Bruce Dawson | 09c0c07 | 2022-05-26 20:28:58 +0000 | [diff] [blame] | 1723 | no_diffs: if true, implies that --files or --all was specified so some |
| 1724 | checks can be skipped, and some errors will be messages. |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1725 | Return: |
Edward Lemur | 6eb1d32 | 2020-02-27 22:20:15 +0000 | [diff] [blame] | 1726 | 1 if presubmit checks failed or 0 otherwise. |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1727 | """ |
maruel@chromium.org | ea7c855 | 2011-04-18 14:12:07 +0000 | [diff] [blame] | 1728 | old_environ = os.environ |
| 1729 | try: |
| 1730 | # Make sure python subprocesses won't generate .pyc files. |
| 1731 | os.environ = os.environ.copy() |
Edward Lemur | b983024 | 2019-10-30 22:19:20 +0000 | [diff] [blame] | 1732 | os.environ['PYTHONDONTWRITEBYTECODE'] = '1' |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1733 | |
Dirk Pranke | 61bf6e8 | 2021-04-23 00:50:21 +0000 | [diff] [blame] | 1734 | python_version = 'Python %s' % sys.version_info.major |
maruel@chromium.org | ea7c855 | 2011-04-18 14:12:07 +0000 | [diff] [blame] | 1735 | if committing: |
Dirk Pranke | 6fc394f | 2021-05-26 23:25:14 +0000 | [diff] [blame] | 1736 | sys.stdout.write('Running %s presubmit commit checks ...\n' % |
Dirk Pranke | 61bf6e8 | 2021-04-23 00:50:21 +0000 | [diff] [blame] | 1737 | python_version) |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1738 | else: |
Dirk Pranke | 61bf6e8 | 2021-04-23 00:50:21 +0000 | [diff] [blame] | 1739 | sys.stdout.write('Running %s presubmit upload checks ...\n' % |
| 1740 | python_version) |
Edward Lemur | ecc2707 | 2020-01-06 16:42:34 +0000 | [diff] [blame] | 1741 | start_time = time_time() |
Josip Sokcevic | a9a7eec | 2023-03-10 03:54:52 +0000 | [diff] [blame] | 1742 | presubmit_files = ListRelevantPresubmitFiles( |
| 1743 | change.AbsoluteLocalPaths(), change.RepositoryRoot()) |
maruel@chromium.org | ea7c855 | 2011-04-18 14:12:07 +0000 | [diff] [blame] | 1744 | if not presubmit_files and verbose: |
Edward Lemur | 6eb1d32 | 2020-02-27 22:20:15 +0000 | [diff] [blame] | 1745 | sys.stdout.write('Warning, no PRESUBMIT.py found.\n') |
maruel@chromium.org | ea7c855 | 2011-04-18 14:12:07 +0000 | [diff] [blame] | 1746 | results = [] |
Bruce Dawson | c9f904f | 2022-10-14 20:59:49 +0000 | [diff] [blame] | 1747 | if sys.platform == 'win32': |
| 1748 | temp = os.environ['TEMP'] |
| 1749 | else: |
| 1750 | temp = '/tmp' |
| 1751 | python2_usage_log_file = os.path.join(temp, 'python2_usage.txt') |
Bruce Dawson | f2b0421 | 2022-06-10 16:42:54 +0000 | [diff] [blame] | 1752 | if os.path.exists(python2_usage_log_file): |
| 1753 | os.remove(python2_usage_log_file) |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 1754 | thread_pool = ThreadPool() |
Edward Lemur | 7e3c67f | 2018-07-20 20:52:49 +0000 | [diff] [blame] | 1755 | executer = PresubmitExecuter(change, committing, verbose, gerrit_obj, |
Robert Iannucci | 3d6d2d2 | 2023-05-11 17:25:05 +0000 | [diff] [blame] | 1756 | dry_run, thread_pool, parallel, no_diffs) |
maruel@chromium.org | ea7c855 | 2011-04-18 14:12:07 +0000 | [diff] [blame] | 1757 | if default_presubmit: |
| 1758 | if verbose: |
Edward Lemur | 6eb1d32 | 2020-02-27 22:20:15 +0000 | [diff] [blame] | 1759 | sys.stdout.write('Running default presubmit script.\n') |
maruel@chromium.org | ea7c855 | 2011-04-18 14:12:07 +0000 | [diff] [blame] | 1760 | fake_path = os.path.join(change.RepositoryRoot(), 'PRESUBMIT.py') |
Robert Iannucci | 3d6d2d2 | 2023-05-11 17:25:05 +0000 | [diff] [blame] | 1761 | results += executer.ExecPresubmitScript(default_presubmit, fake_path) |
maruel@chromium.org | ea7c855 | 2011-04-18 14:12:07 +0000 | [diff] [blame] | 1762 | for filename in presubmit_files: |
| 1763 | filename = os.path.abspath(filename) |
maruel@chromium.org | ea7c855 | 2011-04-18 14:12:07 +0000 | [diff] [blame] | 1764 | # Accept CRLF presubmit script. |
Bruce Dawson | 6e70e86 | 2022-07-01 19:37:01 +0000 | [diff] [blame] | 1765 | presubmit_script = gclient_utils.FileRead(filename).replace('\r\n', '\n') |
Robert Iannucci | 3d6d2d2 | 2023-05-11 17:25:05 +0000 | [diff] [blame] | 1766 | if verbose: |
| 1767 | sys.stdout.write('Running %s\n' % filename) |
| 1768 | results += executer.ExecPresubmitScript(presubmit_script, filename) |
Bruce Dawson | 76fe1a7 | 2022-05-25 20:52:21 +0000 | [diff] [blame] | 1769 | |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 1770 | results += thread_pool.RunAsync() |
| 1771 | |
Bruce Dawson | f2b0421 | 2022-06-10 16:42:54 +0000 | [diff] [blame] | 1772 | if os.path.exists(python2_usage_log_file): |
| 1773 | with open(python2_usage_log_file) as f: |
| 1774 | python2_usage = [x.strip() for x in f.readlines()] |
| 1775 | results.append( |
| 1776 | OutputApi(committing).PresubmitPromptWarning( |
| 1777 | 'Python 2 scripts were run during %s presubmits. Please see ' |
| 1778 | 'https://bugs.chromium.org/p/chromium/issues/detail?id=1313804' |
| 1779 | '#c61 for tips on resolving this.' |
| 1780 | % python_version, |
| 1781 | items=python2_usage)) |
| 1782 | |
Edward Lemur | 6eb1d32 | 2020-02-27 22:20:15 +0000 | [diff] [blame] | 1783 | messages = {} |
| 1784 | should_prompt = False |
| 1785 | presubmits_failed = False |
maruel@chromium.org | ea7c855 | 2011-04-18 14:12:07 +0000 | [diff] [blame] | 1786 | for result in results: |
| 1787 | if result.fatal: |
Edward Lemur | 6eb1d32 | 2020-02-27 22:20:15 +0000 | [diff] [blame] | 1788 | presubmits_failed = True |
| 1789 | messages.setdefault('ERRORS', []).append(result) |
maruel@chromium.org | ea7c855 | 2011-04-18 14:12:07 +0000 | [diff] [blame] | 1790 | elif result.should_prompt: |
Edward Lemur | 6eb1d32 | 2020-02-27 22:20:15 +0000 | [diff] [blame] | 1791 | should_prompt = True |
| 1792 | messages.setdefault('Warnings', []).append(result) |
maruel@chromium.org | ea7c855 | 2011-04-18 14:12:07 +0000 | [diff] [blame] | 1793 | else: |
Edward Lemur | 6eb1d32 | 2020-02-27 22:20:15 +0000 | [diff] [blame] | 1794 | messages.setdefault('Messages', []).append(result) |
pam@chromium.org | ed9a083 | 2009-09-09 22:48:55 +0000 | [diff] [blame] | 1795 | |
Bruce Dawson | 76fe1a7 | 2022-05-25 20:52:21 +0000 | [diff] [blame] | 1796 | # Print the different message types in a consistent order. ERRORS go last |
| 1797 | # so that they will be most visible in the local-presubmit output. |
| 1798 | for name in ['Messages', 'Warnings', 'ERRORS']: |
| 1799 | if name in messages: |
| 1800 | items = messages[name] |
Gavin Mak | d22bf60 | 2022-07-11 21:10:41 +0000 | [diff] [blame] | 1801 | sys.stdout.write('** Presubmit %s: %d **\n' % (name, len(items))) |
Bruce Dawson | 76fe1a7 | 2022-05-25 20:52:21 +0000 | [diff] [blame] | 1802 | for item in items: |
| 1803 | item.handle() |
| 1804 | sys.stdout.write('\n') |
pam@chromium.org | ed9a083 | 2009-09-09 22:48:55 +0000 | [diff] [blame] | 1805 | |
Edward Lemur | ecc2707 | 2020-01-06 16:42:34 +0000 | [diff] [blame] | 1806 | total_time = time_time() - start_time |
maruel@chromium.org | ea7c855 | 2011-04-18 14:12:07 +0000 | [diff] [blame] | 1807 | if total_time > 1.0: |
Edward Lemur | 6eb1d32 | 2020-02-27 22:20:15 +0000 | [diff] [blame] | 1808 | sys.stdout.write( |
Louis Romero | 4ca9e1c | 2022-03-10 10:29:11 +0000 | [diff] [blame] | 1809 | 'Presubmit checks took %.1fs to calculate.\n' % total_time) |
maruel@chromium.org | ce8e46b | 2009-06-26 22:31:51 +0000 | [diff] [blame] | 1810 | |
Edward Lemur | 6eb1d32 | 2020-02-27 22:20:15 +0000 | [diff] [blame] | 1811 | if not should_prompt and not presubmits_failed: |
Louis Romero | 4ca9e1c | 2022-03-10 10:29:11 +0000 | [diff] [blame] | 1812 | sys.stdout.write('%s presubmit checks passed.\n\n' % python_version) |
Josip Sokcevic | 7592e0a | 2022-01-12 00:57:54 +0000 | [diff] [blame] | 1813 | elif should_prompt and not presubmits_failed: |
Dirk Pranke | 61bf6e8 | 2021-04-23 00:50:21 +0000 | [diff] [blame] | 1814 | sys.stdout.write('There were %s presubmit warnings. ' % python_version) |
Quinten Yearsley | 516fe7f | 2016-12-14 11:50:18 -0800 | [diff] [blame] | 1815 | if may_prompt: |
Edward Lemur | 6eb1d32 | 2020-02-27 22:20:15 +0000 | [diff] [blame] | 1816 | presubmits_failed = not prompt_should_continue( |
| 1817 | 'Are you sure you wish to continue? (y/N): ') |
Garrett Beaty | acb807e | 2020-08-28 18:17:24 +0000 | [diff] [blame] | 1818 | else: |
| 1819 | sys.stdout.write('\n') |
Bruce Dawson | 76fe1a7 | 2022-05-25 20:52:21 +0000 | [diff] [blame] | 1820 | else: |
| 1821 | sys.stdout.write('There were %s presubmit errors.\n' % python_version) |
maruel@chromium.org | ea7c855 | 2011-04-18 14:12:07 +0000 | [diff] [blame] | 1822 | |
Edward Lemur | 1dc66e1 | 2020-02-21 21:36:34 +0000 | [diff] [blame] | 1823 | if json_output: |
| 1824 | # Write the presubmit results to json output |
| 1825 | presubmit_results = { |
| 1826 | 'errors': [ |
Edward Lemur | 6eb1d32 | 2020-02-27 22:20:15 +0000 | [diff] [blame] | 1827 | error.json_format() |
| 1828 | for error in messages.get('ERRORS', []) |
Edward Lemur | 1dc66e1 | 2020-02-21 21:36:34 +0000 | [diff] [blame] | 1829 | ], |
| 1830 | 'notifications': [ |
Edward Lemur | 6eb1d32 | 2020-02-27 22:20:15 +0000 | [diff] [blame] | 1831 | notification.json_format() |
| 1832 | for notification in messages.get('Messages', []) |
Edward Lemur | 1dc66e1 | 2020-02-21 21:36:34 +0000 | [diff] [blame] | 1833 | ], |
| 1834 | 'warnings': [ |
Edward Lemur | 6eb1d32 | 2020-02-27 22:20:15 +0000 | [diff] [blame] | 1835 | warning.json_format() |
| 1836 | for warning in messages.get('Warnings', []) |
Edward Lemur | 1dc66e1 | 2020-02-21 21:36:34 +0000 | [diff] [blame] | 1837 | ], |
Edward Lemur | 6eb1d32 | 2020-02-27 22:20:15 +0000 | [diff] [blame] | 1838 | 'more_cc': executer.more_cc, |
Edward Lemur | 1dc66e1 | 2020-02-21 21:36:34 +0000 | [diff] [blame] | 1839 | } |
| 1840 | |
| 1841 | gclient_utils.FileWrite( |
| 1842 | json_output, json.dumps(presubmit_results, sort_keys=True)) |
| 1843 | |
maruel@chromium.org | ea7c855 | 2011-04-18 14:12:07 +0000 | [diff] [blame] | 1844 | global _ASKED_FOR_FEEDBACK |
| 1845 | # Ask for feedback one time out of 5. |
Aravind Vasudevan | c5f0cbb | 2022-01-24 23:56:57 +0000 | [diff] [blame] | 1846 | if (results and random.randint(0, 4) == 0 and not _ASKED_FOR_FEEDBACK): |
Edward Lemur | 6eb1d32 | 2020-02-27 22:20:15 +0000 | [diff] [blame] | 1847 | sys.stdout.write( |
maruel@chromium.org | 1ce8e66 | 2014-01-14 15:23:00 +0000 | [diff] [blame] | 1848 | 'Was the presubmit check useful? If not, run "git cl presubmit -v"\n' |
| 1849 | 'to figure out which PRESUBMIT.py was run, then run git blame\n' |
| 1850 | 'on the file to figure out who to ask for help.\n') |
maruel@chromium.org | ea7c855 | 2011-04-18 14:12:07 +0000 | [diff] [blame] | 1851 | _ASKED_FOR_FEEDBACK = True |
Edward Lemur | 6eb1d32 | 2020-02-27 22:20:15 +0000 | [diff] [blame] | 1852 | |
| 1853 | return 1 if presubmits_failed else 0 |
maruel@chromium.org | ea7c855 | 2011-04-18 14:12:07 +0000 | [diff] [blame] | 1854 | finally: |
| 1855 | os.environ = old_environ |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1856 | |
| 1857 | |
Edward Lemur | 50984a6 | 2020-02-06 18:10:18 +0000 | [diff] [blame] | 1858 | def _scan_sub_dirs(mask, recursive): |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1859 | if not recursive: |
pgervais@chromium.org | e57b09d | 2014-05-07 00:58:13 +0000 | [diff] [blame] | 1860 | return [x for x in glob.glob(mask) if x not in ('.svn', '.git')] |
Lei Zhang | 9611c4c | 2017-04-04 01:41:56 -0700 | [diff] [blame] | 1861 | |
| 1862 | results = [] |
| 1863 | for root, dirs, files in os.walk('.'): |
| 1864 | if '.svn' in dirs: |
| 1865 | dirs.remove('.svn') |
| 1866 | if '.git' in dirs: |
| 1867 | dirs.remove('.git') |
| 1868 | for name in files: |
| 1869 | if fnmatch.fnmatch(name, mask): |
| 1870 | results.append(os.path.join(root, name)) |
| 1871 | return results |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1872 | |
| 1873 | |
Edward Lemur | 50984a6 | 2020-02-06 18:10:18 +0000 | [diff] [blame] | 1874 | def _parse_files(args, recursive): |
tobiasjs | 2836bcf | 2016-08-16 04:08:16 -0700 | [diff] [blame] | 1875 | logging.debug('Searching for %s', args) |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1876 | files = [] |
| 1877 | for arg in args: |
Edward Lemur | 50984a6 | 2020-02-06 18:10:18 +0000 | [diff] [blame] | 1878 | files.extend([('M', f) for f in _scan_sub_dirs(arg, recursive)]) |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1879 | return files |
| 1880 | |
| 1881 | |
Edward Lemur | 50984a6 | 2020-02-06 18:10:18 +0000 | [diff] [blame] | 1882 | def _parse_change(parser, options): |
| 1883 | """Process change options. |
| 1884 | |
| 1885 | Args: |
| 1886 | parser: The parser used to parse the arguments from command line. |
| 1887 | options: The arguments parsed from command line. |
| 1888 | Returns: |
Josip Sokcevic | 7958e30 | 2023-03-01 23:02:21 +0000 | [diff] [blame] | 1889 | A GitChange if the change root is a git repository, or a Change otherwise. |
Edward Lemur | 50984a6 | 2020-02-06 18:10:18 +0000 | [diff] [blame] | 1890 | """ |
| 1891 | if options.files and options.all_files: |
| 1892 | parser.error('<files> cannot be specified when --all-files is set.') |
| 1893 | |
Edward Lesmes | 44ea3ff | 2020-02-05 00:14:30 +0000 | [diff] [blame] | 1894 | change_scm = scm.determine_scm(options.root) |
Edward Lemur | 50984a6 | 2020-02-06 18:10:18 +0000 | [diff] [blame] | 1895 | if change_scm != 'git' and not options.files: |
| 1896 | parser.error('<files> is not optional for unversioned directories.') |
| 1897 | |
| 1898 | if options.files: |
Josip Sokcevic | 017544d | 2022-03-31 23:47:53 +0000 | [diff] [blame] | 1899 | if options.source_controlled_only: |
| 1900 | # Get the filtered set of files from SCM. |
| 1901 | change_files = [] |
| 1902 | for name in scm.GIT.GetAllFiles(options.root): |
| 1903 | for mask in options.files: |
| 1904 | if fnmatch.fnmatch(name, mask): |
| 1905 | change_files.append(('M', name)) |
| 1906 | break |
| 1907 | else: |
| 1908 | # Get the filtered set of files from a directory scan. |
| 1909 | change_files = _parse_files(options.files, options.recursive) |
Edward Lemur | 50984a6 | 2020-02-06 18:10:18 +0000 | [diff] [blame] | 1910 | elif options.all_files: |
| 1911 | change_files = [('M', f) for f in scm.GIT.GetAllFiles(options.root)] |
maruel@chromium.org | 5c8c6de | 2011-03-18 16:20:18 +0000 | [diff] [blame] | 1912 | else: |
Edward Lemur | 50984a6 | 2020-02-06 18:10:18 +0000 | [diff] [blame] | 1913 | change_files = scm.GIT.CaptureStatus( |
Edward Lemur | 7f6dec0 | 2020-02-06 20:23:58 +0000 | [diff] [blame] | 1914 | options.root, options.upstream or None) |
Edward Lemur | 50984a6 | 2020-02-06 18:10:18 +0000 | [diff] [blame] | 1915 | |
| 1916 | logging.info('Found %d file(s).', len(change_files)) |
| 1917 | |
Josip Sokcevic | 7958e30 | 2023-03-01 23:02:21 +0000 | [diff] [blame] | 1918 | change_class = GitChange if change_scm == 'git' else Change |
Edward Lemur | 50984a6 | 2020-02-06 18:10:18 +0000 | [diff] [blame] | 1919 | return change_class( |
| 1920 | options.name, |
| 1921 | options.description, |
| 1922 | options.root, |
| 1923 | change_files, |
| 1924 | options.issue, |
| 1925 | options.patchset, |
| 1926 | options.author, |
| 1927 | upstream=options.upstream) |
| 1928 | |
| 1929 | |
| 1930 | def _parse_gerrit_options(parser, options): |
| 1931 | """Process gerrit options. |
| 1932 | |
| 1933 | SIDE EFFECTS: Modifies options.author and options.description from Gerrit if |
| 1934 | options.gerrit_fetch is set. |
| 1935 | |
| 1936 | Args: |
| 1937 | parser: The parser used to parse the arguments from command line. |
| 1938 | options: The arguments parsed from command line. |
| 1939 | Returns: |
Stephen Martinis | fb09de2 | 2021-02-25 03:41:13 +0000 | [diff] [blame] | 1940 | A GerritAccessor object if options.gerrit_url is set, or None otherwise. |
Edward Lemur | 50984a6 | 2020-02-06 18:10:18 +0000 | [diff] [blame] | 1941 | """ |
| 1942 | gerrit_obj = None |
Stephen Martinis | fb09de2 | 2021-02-25 03:41:13 +0000 | [diff] [blame] | 1943 | if options.gerrit_url: |
Edward Lesmes | eb1bd62 | 2021-03-01 19:54:07 +0000 | [diff] [blame] | 1944 | gerrit_obj = GerritAccessor( |
| 1945 | url=options.gerrit_url, |
| 1946 | project=options.gerrit_project, |
| 1947 | branch=options.gerrit_branch) |
Edward Lemur | 50984a6 | 2020-02-06 18:10:18 +0000 | [diff] [blame] | 1948 | |
| 1949 | if not options.gerrit_fetch: |
| 1950 | return gerrit_obj |
| 1951 | |
| 1952 | if not options.gerrit_url or not options.issue or not options.patchset: |
| 1953 | parser.error( |
| 1954 | '--gerrit_fetch requires --gerrit_url, --issue and --patchset.') |
| 1955 | |
| 1956 | options.author = gerrit_obj.GetChangeOwner(options.issue) |
| 1957 | options.description = gerrit_obj.GetChangeDescription( |
| 1958 | options.issue, options.patchset) |
| 1959 | |
| 1960 | logging.info('Got author: "%s"', options.author) |
| 1961 | logging.info('Got description: """\n%s\n"""', options.description) |
| 1962 | |
| 1963 | return gerrit_obj |
maruel@chromium.org | 5c8c6de | 2011-03-18 16:20:18 +0000 | [diff] [blame] | 1964 | |
| 1965 | |
iannucci@chromium.org | 8a4a2bc | 2013-03-08 08:13:20 +0000 | [diff] [blame] | 1966 | @contextlib.contextmanager |
| 1967 | def canned_check_filter(method_names): |
| 1968 | filtered = {} |
| 1969 | try: |
| 1970 | for method_name in method_names: |
| 1971 | if not hasattr(presubmit_canned_checks, method_name): |
Gavin Mak | e6a6233 | 2020-12-04 21:57:10 +0000 | [diff] [blame] | 1972 | logging.warning('Skipping unknown "canned" check %s' % method_name) |
Aaron Gable | ecee74c | 2018-04-02 15:13:08 -0700 | [diff] [blame] | 1973 | continue |
iannucci@chromium.org | 8a4a2bc | 2013-03-08 08:13:20 +0000 | [diff] [blame] | 1974 | filtered[method_name] = getattr(presubmit_canned_checks, method_name) |
| 1975 | setattr(presubmit_canned_checks, method_name, lambda *_a, **_kw: []) |
| 1976 | yield |
| 1977 | finally: |
Marc-Antoine Ruel | 8e57b4b | 2019-10-11 01:01:36 +0000 | [diff] [blame] | 1978 | for name, method in filtered.items(): |
iannucci@chromium.org | 8a4a2bc | 2013-03-08 08:13:20 +0000 | [diff] [blame] | 1979 | setattr(presubmit_canned_checks, name, method) |
| 1980 | |
maruel@chromium.org | ffeb2f3 | 2013-12-03 13:55:22 +0000 | [diff] [blame] | 1981 | |
sbc@chromium.org | 013731e | 2015-02-26 18:28:43 +0000 | [diff] [blame] | 1982 | def main(argv=None): |
Edward Lemur | a5799e3 | 2020-01-17 19:26:51 +0000 | [diff] [blame] | 1983 | parser = argparse.ArgumentParser(usage='%(prog)s [options] <files...>') |
| 1984 | hooks = parser.add_mutually_exclusive_group() |
| 1985 | hooks.add_argument('-c', '--commit', action='store_true', |
| 1986 | help='Use commit instead of upload checks.') |
| 1987 | hooks.add_argument('-u', '--upload', action='store_false', dest='commit', |
| 1988 | help='Use upload instead of commit checks.') |
Edward Lemur | 7552630 | 2020-02-27 22:31:05 +0000 | [diff] [blame] | 1989 | hooks.add_argument('--post_upload', action='store_true', |
| 1990 | help='Run post-upload commit hooks.') |
Edward Lemur | a5799e3 | 2020-01-17 19:26:51 +0000 | [diff] [blame] | 1991 | parser.add_argument('-r', '--recursive', action='store_true', |
| 1992 | help='Act recursively.') |
| 1993 | parser.add_argument('-v', '--verbose', action='count', default=0, |
| 1994 | help='Use 2 times for more debug info.') |
| 1995 | parser.add_argument('--name', default='no name') |
| 1996 | parser.add_argument('--author') |
Edward Lemur | 227d510 | 2020-02-25 23:45:35 +0000 | [diff] [blame] | 1997 | desc = parser.add_mutually_exclusive_group() |
| 1998 | desc.add_argument('--description', default='', help='The change description.') |
| 1999 | desc.add_argument('--description_file', |
| 2000 | help='File to read change description from.') |
Edward Lemur | a5799e3 | 2020-01-17 19:26:51 +0000 | [diff] [blame] | 2001 | parser.add_argument('--issue', type=int, default=0) |
| 2002 | parser.add_argument('--patchset', type=int, default=0) |
| 2003 | parser.add_argument('--root', default=os.getcwd(), |
| 2004 | help='Search for PRESUBMIT.py up to this directory. ' |
| 2005 | 'If inherit-review-settings-ok is present in this ' |
| 2006 | 'directory, parent directories up to the root file ' |
| 2007 | 'system directories will also be searched.') |
| 2008 | parser.add_argument('--upstream', |
| 2009 | help='Git only: the base ref or upstream branch against ' |
| 2010 | 'which the diff should be computed.') |
| 2011 | parser.add_argument('--default_presubmit') |
| 2012 | parser.add_argument('--may_prompt', action='store_true', default=False) |
| 2013 | parser.add_argument('--skip_canned', action='append', default=[], |
| 2014 | help='A list of checks to skip which appear in ' |
| 2015 | 'presubmit_canned_checks. Can be provided multiple times ' |
| 2016 | 'to skip multiple canned checks.') |
| 2017 | parser.add_argument('--dry_run', action='store_true', help=argparse.SUPPRESS) |
| 2018 | parser.add_argument('--gerrit_url', help=argparse.SUPPRESS) |
Edward Lesmes | eb1bd62 | 2021-03-01 19:54:07 +0000 | [diff] [blame] | 2019 | parser.add_argument('--gerrit_project', help=argparse.SUPPRESS) |
| 2020 | parser.add_argument('--gerrit_branch', help=argparse.SUPPRESS) |
Edward Lemur | a5799e3 | 2020-01-17 19:26:51 +0000 | [diff] [blame] | 2021 | parser.add_argument('--gerrit_fetch', action='store_true', |
| 2022 | help=argparse.SUPPRESS) |
| 2023 | parser.add_argument('--parallel', action='store_true', |
| 2024 | help='Run all tests specified by input_api.RunTests in ' |
| 2025 | 'all PRESUBMIT files in parallel.') |
| 2026 | parser.add_argument('--json_output', |
| 2027 | help='Write presubmit errors to json output.') |
Edward Lemur | 1dc66e1 | 2020-02-21 21:36:34 +0000 | [diff] [blame] | 2028 | parser.add_argument('--all_files', action='store_true', |
Edward Lemur | 50984a6 | 2020-02-06 18:10:18 +0000 | [diff] [blame] | 2029 | help='Mark all files under source control as modified.') |
Bruce Dawson | 09c0c07 | 2022-05-26 20:28:58 +0000 | [diff] [blame] | 2030 | |
Edward Lemur | a5799e3 | 2020-01-17 19:26:51 +0000 | [diff] [blame] | 2031 | parser.add_argument('files', nargs='*', |
| 2032 | help='List of files to be marked as modified when ' |
| 2033 | 'executing presubmit or post-upload hooks. fnmatch ' |
| 2034 | 'wildcards can also be used.') |
Josip Sokcevic | 017544d | 2022-03-31 23:47:53 +0000 | [diff] [blame] | 2035 | parser.add_argument('--source_controlled_only', action='store_true', |
| 2036 | help='Constrain \'files\' to those in source control.') |
Bruce Dawson | 09c0c07 | 2022-05-26 20:28:58 +0000 | [diff] [blame] | 2037 | parser.add_argument('--no_diffs', action='store_true', |
| 2038 | help='Assume that all "modified" files have no diffs.') |
Edward Lemur | a5799e3 | 2020-01-17 19:26:51 +0000 | [diff] [blame] | 2039 | options = parser.parse_args(argv) |
pgervais@chromium.org | 92c3009 | 2014-04-15 00:30:37 +0000 | [diff] [blame] | 2040 | |
Erik Staab | cca5c49 | 2020-04-16 17:40:07 +0000 | [diff] [blame] | 2041 | log_level = logging.ERROR |
maruel@chromium.org | 899e1c1 | 2011-04-07 17:03:18 +0000 | [diff] [blame] | 2042 | if options.verbose >= 2: |
Erik Staab | cca5c49 | 2020-04-16 17:40:07 +0000 | [diff] [blame] | 2043 | log_level = logging.DEBUG |
maruel@chromium.org | 899e1c1 | 2011-04-07 17:03:18 +0000 | [diff] [blame] | 2044 | elif options.verbose: |
Erik Staab | cca5c49 | 2020-04-16 17:40:07 +0000 | [diff] [blame] | 2045 | log_level = logging.INFO |
| 2046 | log_format = ('[%(levelname).1s%(asctime)s %(process)d %(thread)d ' |
| 2047 | '%(filename)s] %(message)s') |
| 2048 | logging.basicConfig(format=log_format, level=log_level) |
pgervais@chromium.org | 92c3009 | 2014-04-15 00:30:37 +0000 | [diff] [blame] | 2049 | |
Bruce Dawson | dca14bc | 2022-09-15 20:59:38 +0000 | [diff] [blame] | 2050 | # Print call stacks when _PresubmitResult objects are created with -v -v is |
| 2051 | # specified. This helps track down where presubmit messages are coming from. |
| 2052 | if options.verbose >= 2: |
| 2053 | global _SHOW_CALLSTACKS |
| 2054 | _SHOW_CALLSTACKS = True |
| 2055 | |
Edward Lemur | 227d510 | 2020-02-25 23:45:35 +0000 | [diff] [blame] | 2056 | if options.description_file: |
| 2057 | options.description = gclient_utils.FileRead(options.description_file) |
Edward Lemur | 50984a6 | 2020-02-06 18:10:18 +0000 | [diff] [blame] | 2058 | gerrit_obj = _parse_gerrit_options(parser, options) |
| 2059 | change = _parse_change(parser, options) |
pgervais@chromium.org | 92c3009 | 2014-04-15 00:30:37 +0000 | [diff] [blame] | 2060 | |
maruel@chromium.org | 899e1c1 | 2011-04-07 17:03:18 +0000 | [diff] [blame] | 2061 | try: |
Edward Lemur | 7552630 | 2020-02-27 22:31:05 +0000 | [diff] [blame] | 2062 | if options.post_upload: |
Robert Iannucci | 3d6d2d2 | 2023-05-11 17:25:05 +0000 | [diff] [blame] | 2063 | return DoPostUploadExecuter(change, gerrit_obj, options.verbose) |
iannucci@chromium.org | 8a4a2bc | 2013-03-08 08:13:20 +0000 | [diff] [blame] | 2064 | with canned_check_filter(options.skip_canned): |
Edward Lemur | 6eb1d32 | 2020-02-27 22:20:15 +0000 | [diff] [blame] | 2065 | return DoPresubmitChecks( |
Edward Lemur | 50984a6 | 2020-02-06 18:10:18 +0000 | [diff] [blame] | 2066 | change, |
iannucci@chromium.org | 8a4a2bc | 2013-03-08 08:13:20 +0000 | [diff] [blame] | 2067 | options.commit, |
| 2068 | options.verbose, |
iannucci@chromium.org | 8a4a2bc | 2013-03-08 08:13:20 +0000 | [diff] [blame] | 2069 | options.default_presubmit, |
| 2070 | options.may_prompt, |
tandrii@chromium.org | 37b07a7 | 2016-04-29 16:42:28 +0000 | [diff] [blame] | 2071 | gerrit_obj, |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 2072 | options.dry_run, |
Debrian Figueroa | dd2737e | 2019-06-21 23:50:13 +0000 | [diff] [blame] | 2073 | options.parallel, |
Dirk Pranke | 6f0df68 | 2021-06-25 00:42:33 +0000 | [diff] [blame] | 2074 | options.json_output, |
Bruce Dawson | 09c0c07 | 2022-05-26 20:28:58 +0000 | [diff] [blame] | 2075 | options.no_diffs) |
Raul Tambre | 7c93846 | 2019-05-24 16:35:35 +0000 | [diff] [blame] | 2076 | except PresubmitFailure as e: |
Josip Sokcevic | a9a7eec | 2023-03-10 03:54:52 +0000 | [diff] [blame] | 2077 | import utils |
Raul Tambre | 80ee78e | 2019-05-06 22:41:05 +0000 | [diff] [blame] | 2078 | print(e, file=sys.stderr) |
| 2079 | print('Maybe your depot_tools is out of date?', file=sys.stderr) |
Josip Sokcevic | 0399e17 | 2022-03-21 23:11:51 +0000 | [diff] [blame] | 2080 | print('depot_tools version: %s' % utils.depot_tools_version(), |
| 2081 | file=sys.stderr) |
maruel@chromium.org | 899e1c1 | 2011-04-07 17:03:18 +0000 | [diff] [blame] | 2082 | return 2 |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 2083 | |
| 2084 | |
| 2085 | if __name__ == '__main__': |
maruel@chromium.org | 35625c7 | 2011-03-23 17:34:02 +0000 | [diff] [blame] | 2086 | fix_encoding.fix_encoding() |
sbc@chromium.org | 013731e | 2015-02-26 18:28:43 +0000 | [diff] [blame] | 2087 | try: |
| 2088 | sys.exit(main()) |
| 2089 | except KeyboardInterrupt: |
| 2090 | sys.stderr.write('interrupted\n') |
sergiyb | f8a3b38 | 2016-07-05 11:21:30 -0700 | [diff] [blame] | 2091 | sys.exit(2) |