blob: 08c06190dfa1e20cba066f18f494e0f7b8a726e6 [file] [log] [blame]
Josip Sokcevic4de5dea2022-03-23 21:15:14 +00001#!/usr/bin/env python3
maruel@chromium.org3bbf2942012-01-10 16:52:06 +00002# Copyright (c) 2012 The Chromium Authors. All rights reserved.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00003# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5
6"""Enables directory-specific presubmit checks to run at upload and/or commit.
7"""
8
Raul Tambre80ee78e2019-05-06 22:41:05 +00009from __future__ import print_function
10
Saagar Sanghavi99816902020-08-11 22:41:25 +000011__version__ = '2.0.0'
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000012
13# TODO(joi) Add caching where appropriate/needed. The API is designed to allow
14# caching (between all different invocations of presubmit scripts for a given
15# change). We should add it as our presubmit scripts start feeling slow.
16
Edward Lemura5799e32020-01-17 19:26:51 +000017import argparse
Takeshi Yoshino07a6bea2017-08-02 02:44:06 +090018import ast # Exposed through the API.
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +000019import contextlib
Yoshisato Yanagisawa406de132018-06-29 05:43:25 +000020import cpplint
dcheng091b7db2016-06-16 01:27:51 -070021import fnmatch # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000022import glob
asvitkine@chromium.org15169952011-09-27 14:30:53 +000023import inspect
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +000024import itertools
maruel@chromium.org4f6852c2012-04-20 20:39:20 +000025import json # Exposed through the API.
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +000026import logging
ilevy@chromium.orgbc117312013-04-20 03:57:56 +000027import multiprocessing
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000028import os # Somewhat exposed through the API.
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +000029import random
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000030import re # Exposed through the API.
Edward Lesmes8e282792018-04-03 18:50:29 -040031import signal
Allen Webbfe7d7092021-05-18 02:05:49 +000032import six
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000033import sys # Parts exposed through API.
34import tempfile # Exposed through the API.
Edward Lesmes8e282792018-04-03 18:50:29 -040035import threading
jam@chromium.org2a891dc2009-08-20 20:33:37 +000036import time
Edward Lemurde9e3ca2019-10-24 21:13:31 +000037import traceback
maruel@chromium.org1487d532009-06-06 00:22:57 +000038import unittest # Exposed through the API.
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +000039from warnings import warn
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000040
41# Local imports.
maruel@chromium.org35625c72011-03-23 17:34:02 +000042import fix_encoding
Yoshisato Yanagisawa04600b42019-03-15 03:03:41 +000043import gclient_paths # Exposed through the API
44import gclient_utils
Josip Sokcevic7958e302023-03-01 23:02:21 +000045import git_footers
tandrii@chromium.org015ebae2016-04-25 19:37:22 +000046import gerrit_util
Edward Lesmes9ce03f82021-01-12 20:13:31 +000047import owners_client
Jochen Eisinger76f5fc62017-04-07 16:27:46 +020048import owners_finder
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000049import presubmit_canned_checks
Saagar Sanghavi9949ab72020-07-20 20:56:40 +000050import rdb_wrapper
Josip Sokcevic7958e302023-03-01 23:02:21 +000051import scm
maruel@chromium.org84f4fe32011-04-06 13:26:45 +000052import subprocess2 as subprocess # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000053
Edward Lemur16af3562019-10-17 22:11:33 +000054if sys.version_info.major == 2:
55 # TODO(1009814): Expose urllib2 only through urllib_request and urllib_error
56 import urllib2 # Exposed through the API.
57 import urlparse
58 import urllib2 as urllib_request
59 import urllib2 as urllib_error
60else:
61 import urllib.parse as urlparse
62 import urllib.request as urllib_request
63 import urllib.error as urllib_error
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000064
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +000065# Ask for feedback only once in program lifetime.
66_ASKED_FOR_FEEDBACK = False
67
Bruce Dawsondca14bc2022-09-15 20:59:38 +000068# Set if super-verbose mode is requested, for tracking where presubmit messages
69# are coming from.
70_SHOW_CALLSTACKS = False
71
72
Edward Lemurecc27072020-01-06 16:42:34 +000073def time_time():
74 # Use this so that it can be mocked in tests without interfering with python
75 # system machinery.
76 return time.time()
77
78
maruel@chromium.org899e1c12011-04-07 17:03:18 +000079class PresubmitFailure(Exception):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000080 pass
81
82
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000083class CommandData(object):
Bruce Dawsonb6cb9e02023-05-18 20:52:43 +000084 def __init__(self, name, cmd, kwargs, message, python3=True):
85 # The python3 argument is ignored but has to be retained because of the many
86 # callers in other repos that pass it in.
87 del python3
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000088 self.name = name
89 self.cmd = cmd
Edward Lesmes8e282792018-04-03 18:50:29 -040090 self.stdin = kwargs.get('stdin', None)
Edward Lemur2d6b67c2019-08-23 22:25:41 +000091 self.kwargs = kwargs.copy()
Edward Lesmes8e282792018-04-03 18:50:29 -040092 self.kwargs['stdout'] = subprocess.PIPE
93 self.kwargs['stderr'] = subprocess.STDOUT
94 self.kwargs['stdin'] = subprocess.PIPE
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000095 self.message = message
96 self.info = None
Bruce Dawsonb6cb9e02023-05-18 20:52:43 +000097
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000098
ilevy@chromium.orgbc117312013-04-20 03:57:56 +000099
Edward Lesmes8e282792018-04-03 18:50:29 -0400100# Adapted from
101# https://github.com/google/gtest-parallel/blob/master/gtest_parallel.py#L37
102#
103# An object that catches SIGINT sent to the Python process and notices
104# if processes passed to wait() die by SIGINT (we need to look for
105# both of those cases, because pressing Ctrl+C can result in either
106# the main process or one of the subprocesses getting the signal).
107#
108# Before a SIGINT is seen, wait(p) will simply call p.wait() and
109# return the result. Once a SIGINT has been seen (in the main process
110# or a subprocess, including the one the current call is waiting for),
Edward Lemur9a5bb612019-09-26 02:01:52 +0000111# wait(p) will call p.terminate().
Edward Lesmes8e282792018-04-03 18:50:29 -0400112class SigintHandler(object):
Edward Lesmes8e282792018-04-03 18:50:29 -0400113 sigint_returncodes = {-signal.SIGINT, # Unix
114 -1073741510, # Windows
115 }
116 def __init__(self):
117 self.__lock = threading.Lock()
118 self.__processes = set()
119 self.__got_sigint = False
Edward Lemur9a5bb612019-09-26 02:01:52 +0000120 self.__previous_signal = signal.signal(signal.SIGINT, self.interrupt)
Edward Lesmes8e282792018-04-03 18:50:29 -0400121
122 def __on_sigint(self):
123 self.__got_sigint = True
124 while self.__processes:
125 try:
126 self.__processes.pop().terminate()
127 except OSError:
128 pass
129
Edward Lemur9a5bb612019-09-26 02:01:52 +0000130 def interrupt(self, signal_num, frame):
Edward Lesmes8e282792018-04-03 18:50:29 -0400131 with self.__lock:
132 self.__on_sigint()
Edward Lemur9a5bb612019-09-26 02:01:52 +0000133 self.__previous_signal(signal_num, frame)
Edward Lesmes8e282792018-04-03 18:50:29 -0400134
135 def got_sigint(self):
136 with self.__lock:
137 return self.__got_sigint
138
139 def wait(self, p, stdin):
140 with self.__lock:
141 if self.__got_sigint:
142 p.terminate()
143 self.__processes.add(p)
144 stdout, stderr = p.communicate(stdin)
145 code = p.returncode
146 with self.__lock:
147 self.__processes.discard(p)
148 if code in self.sigint_returncodes:
149 self.__on_sigint()
Edward Lesmes8e282792018-04-03 18:50:29 -0400150 return stdout, stderr
151
152sigint_handler = SigintHandler()
153
154
Edward Lemurecc27072020-01-06 16:42:34 +0000155class Timer(object):
156 def __init__(self, timeout, fn):
157 self.completed = False
158 self._fn = fn
159 self._timer = threading.Timer(timeout, self._onTimer) if timeout else None
160
161 def __enter__(self):
162 if self._timer:
163 self._timer.start()
164 return self
165
166 def __exit__(self, _type, _value, _traceback):
167 if self._timer:
168 self._timer.cancel()
169
170 def _onTimer(self):
171 self._fn()
172 self.completed = True
173
174
Edward Lesmes8e282792018-04-03 18:50:29 -0400175class ThreadPool(object):
Edward Lemurecc27072020-01-06 16:42:34 +0000176 def __init__(self, pool_size=None, timeout=None):
177 self.timeout = timeout
Edward Lesmes8e282792018-04-03 18:50:29 -0400178 self._pool_size = pool_size or multiprocessing.cpu_count()
Bruce Dawson8254f062022-06-17 17:33:08 +0000179 if sys.platform == 'win32':
180 # TODO(crbug.com/1190269) - we can't use more than 56 child processes on
181 # Windows or Python3 may hang.
182 self._pool_size = min(self._pool_size, 56)
Edward Lesmes8e282792018-04-03 18:50:29 -0400183 self._messages = []
184 self._messages_lock = threading.Lock()
185 self._tests = []
186 self._tests_lock = threading.Lock()
187 self._nonparallel_tests = []
188
Edward Lemurecc27072020-01-06 16:42:34 +0000189 def _GetCommand(self, test):
Bruce Dawsonb6cb9e02023-05-18 20:52:43 +0000190 vpython = 'vpython3'
Edward Lemur940c2822019-08-23 00:34:25 +0000191 if sys.platform == 'win32':
192 vpython += '.bat'
Edward Lesmes8e282792018-04-03 18:50:29 -0400193
194 cmd = test.cmd
195 if cmd[0] == 'python':
196 cmd = list(cmd)
197 cmd[0] = vpython
198 elif cmd[0].endswith('.py'):
199 cmd = [vpython] + cmd
200
Edward Lemur336e51f2019-11-14 21:42:04 +0000201 # On Windows, scripts on the current directory take precedence over PATH, so
202 # that when testing depot_tools on Windows, calling `vpython.bat` will
203 # execute the copy of vpython of the depot_tools under test instead of the
204 # one in the bot.
205 # As a workaround, we run the tests from the parent directory instead.
206 if (cmd[0] == vpython and
207 'cwd' in test.kwargs and
208 os.path.basename(test.kwargs['cwd']) == 'depot_tools'):
209 test.kwargs['cwd'] = os.path.dirname(test.kwargs['cwd'])
210 cmd[1] = os.path.join('depot_tools', cmd[1])
211
Edward Lemurecc27072020-01-06 16:42:34 +0000212 return cmd
213
214 def _RunWithTimeout(self, cmd, stdin, kwargs):
215 p = subprocess.Popen(cmd, **kwargs)
216 with Timer(self.timeout, p.terminate) as timer:
217 stdout, _ = sigint_handler.wait(p, stdin)
Josip Sokcevic6635baf2021-11-19 02:04:39 +0000218 stdout = stdout.decode('utf-8', 'ignore')
Edward Lemurecc27072020-01-06 16:42:34 +0000219 if timer.completed:
220 stdout = 'Process timed out after %ss\n%s' % (self.timeout, stdout)
Josip Sokcevic6635baf2021-11-19 02:04:39 +0000221 return p.returncode, stdout
Edward Lemurecc27072020-01-06 16:42:34 +0000222
Josip Sokcevica4b871e2023-05-18 14:27:56 +0000223 def CallCommand(self, test, show_callstack=None):
Edward Lemurecc27072020-01-06 16:42:34 +0000224 """Runs an external program.
225
Edward Lemura5799e32020-01-17 19:26:51 +0000226 This function converts invocation of .py files and invocations of 'python'
Edward Lemurecc27072020-01-06 16:42:34 +0000227 to vpython invocations.
228 """
229 cmd = self._GetCommand(test)
Edward Lesmes8e282792018-04-03 18:50:29 -0400230 try:
Edward Lemurecc27072020-01-06 16:42:34 +0000231 start = time_time()
232 returncode, stdout = self._RunWithTimeout(cmd, test.stdin, test.kwargs)
233 duration = time_time() - start
Edward Lemur7cf94382019-11-15 22:36:41 +0000234 except Exception:
Edward Lemurecc27072020-01-06 16:42:34 +0000235 duration = time_time() - start
Edward Lesmes8e282792018-04-03 18:50:29 -0400236 return test.message(
Josip Sokcevica4b871e2023-05-18 14:27:56 +0000237 '%s\n%s exec failure (%4.2fs)\n%s' %
238 (test.name, ' '.join(cmd), duration, traceback.format_exc()),
239 show_callstack=show_callstack)
Edward Lemurde9e3ca2019-10-24 21:13:31 +0000240
Edward Lemurecc27072020-01-06 16:42:34 +0000241 if returncode != 0:
Josip Sokcevica4b871e2023-05-18 14:27:56 +0000242 return test.message('%s\n%s (%4.2fs) failed\n%s' %
243 (test.name, ' '.join(cmd), duration, stdout),
244 show_callstack=show_callstack)
Edward Lemurecc27072020-01-06 16:42:34 +0000245
Edward Lesmes8e282792018-04-03 18:50:29 -0400246 if test.info:
Josip Sokcevica4b871e2023-05-18 14:27:56 +0000247 return test.info('%s\n%s (%4.2fs)' % (test.name, ' '.join(cmd), duration),
248 show_callstack=show_callstack)
Edward Lesmes8e282792018-04-03 18:50:29 -0400249
250 def AddTests(self, tests, parallel=True):
251 if parallel:
252 self._tests.extend(tests)
253 else:
254 self._nonparallel_tests.extend(tests)
255
256 def RunAsync(self):
257 self._messages = []
258
259 def _WorkerFn():
260 while True:
261 test = None
262 with self._tests_lock:
263 if not self._tests:
264 break
265 test = self._tests.pop()
Josip Sokcevica4b871e2023-05-18 14:27:56 +0000266 result = self.CallCommand(test, show_callstack=False)
Edward Lesmes8e282792018-04-03 18:50:29 -0400267 if result:
268 with self._messages_lock:
269 self._messages.append(result)
270
271 def _StartDaemon():
272 t = threading.Thread(target=_WorkerFn)
273 t.daemon = True
274 t.start()
275 return t
276
277 while self._nonparallel_tests:
278 test = self._nonparallel_tests.pop()
279 result = self.CallCommand(test)
280 if result:
281 self._messages.append(result)
282
283 if self._tests:
284 threads = [_StartDaemon() for _ in range(self._pool_size)]
285 for worker in threads:
286 worker.join()
287
288 return self._messages
289
290
Josip Sokcevica9a7eec2023-03-10 03:54:52 +0000291def normpath(path):
292 '''Version of os.path.normpath that also changes backward slashes to
293 forward slashes when not running on Windows.
294 '''
295 # This is safe to always do because the Windows version of os.path.normpath
296 # will replace forward slashes with backward slashes.
297 path = path.replace(os.sep, '/')
298 return os.path.normpath(path)
299
300
Josip Sokcevic7958e302023-03-01 23:02:21 +0000301def _RightHandSideLinesImpl(affected_files):
302 """Implements RightHandSideLines for InputApi and GclChange."""
303 for af in affected_files:
304 lines = af.ChangedContents()
305 for line in lines:
306 yield (af, line[0], line[1])
307
308
Edward Lemur6eb1d322020-02-27 22:20:15 +0000309def prompt_should_continue(prompt_string):
310 sys.stdout.write(prompt_string)
Dirk Pranke7288f882021-06-03 18:01:30 +0000311 sys.stdout.flush()
Edward Lemur6eb1d322020-02-27 22:20:15 +0000312 response = sys.stdin.readline().strip().lower()
313 return response in ('y', 'yes')
dpranke@chromium.org5ac21012011-03-16 02:58:25 +0000314
Josip Sokcevic967cf672023-05-10 17:09:58 +0000315
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000316# Top level object so multiprocessing can pickle
317# Public access through OutputApi object.
318class _PresubmitResult(object):
319 """Base class for result objects."""
320 fatal = False
321 should_prompt = False
322
Josip Sokcevica4b871e2023-05-18 14:27:56 +0000323 def __init__(self, message, items=None, long_text='', show_callstack=None):
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000324 """
325 message: A short one-line message to indicate errors.
326 items: A list of short strings to indicate where errors occurred.
327 long_text: multi-line text output, e.g. from another tool
328 """
Bruce Dawsondb8622b2022-04-03 15:38:12 +0000329 self._message = _PresubmitResult._ensure_str(message)
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000330 self._items = items or []
Tom McKee61c72652021-07-20 11:56:32 +0000331 self._long_text = _PresubmitResult._ensure_str(long_text.rstrip())
Josip Sokcevica4b871e2023-05-18 14:27:56 +0000332 if show_callstack is None:
333 show_callstack = _SHOW_CALLSTACKS
334 if show_callstack:
Bruce Dawsondca14bc2022-09-15 20:59:38 +0000335 self._long_text += 'Presubmit result call stack is:\n'
336 self._long_text += ''.join(traceback.format_stack(None, 8))
Tom McKee61c72652021-07-20 11:56:32 +0000337
338 @staticmethod
339 def _ensure_str(val):
340 """
341 val: A "stringish" value. Can be any of str, unicode or bytes.
342 returns: A str after applying encoding/decoding as needed.
343 Assumes/uses UTF-8 for relevant inputs/outputs.
344
345 We'd prefer to use six.ensure_str but our copy of six is old :(
346 """
347 if isinstance(val, str):
348 return val
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +0000349
Tom McKee61c72652021-07-20 11:56:32 +0000350 if six.PY2 and isinstance(val, unicode):
351 return val.encode()
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +0000352
353 if six.PY3 and isinstance(val, bytes):
Tom McKee61c72652021-07-20 11:56:32 +0000354 return val.decode()
355 raise ValueError("Unknown string type %s" % type(val))
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000356
Edward Lemur6eb1d322020-02-27 22:20:15 +0000357 def handle(self):
358 sys.stdout.write(self._message)
359 sys.stdout.write('\n')
Takuto Ikutabaa7be02022-08-23 00:19:34 +0000360 for item in self._items:
Edward Lemur6eb1d322020-02-27 22:20:15 +0000361 sys.stdout.write(' ')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000362 # Write separately in case it's unicode.
Edward Lemur6eb1d322020-02-27 22:20:15 +0000363 sys.stdout.write(str(item))
Edward Lemur6eb1d322020-02-27 22:20:15 +0000364 sys.stdout.write('\n')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000365 if self._long_text:
Edward Lemur6eb1d322020-02-27 22:20:15 +0000366 sys.stdout.write('\n***************\n')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000367 # Write separately in case it's unicode.
Tom McKee61c72652021-07-20 11:56:32 +0000368 sys.stdout.write(self._long_text)
Edward Lemur6eb1d322020-02-27 22:20:15 +0000369 sys.stdout.write('\n***************\n')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000370
Debrian Figueroadd2737e2019-06-21 23:50:13 +0000371 def json_format(self):
372 return {
373 'message': self._message,
Debrian Figueroa6095d402019-06-28 18:47:18 +0000374 'items': [str(item) for item in self._items],
Debrian Figueroadd2737e2019-06-21 23:50:13 +0000375 'long_text': self._long_text,
376 'fatal': self.fatal
377 }
378
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000379
380# Top level object so multiprocessing can pickle
381# Public access through OutputApi object.
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000382class _PresubmitError(_PresubmitResult):
383 """A hard presubmit error."""
384 fatal = True
385
386
387# Top level object so multiprocessing can pickle
388# Public access through OutputApi object.
389class _PresubmitPromptWarning(_PresubmitResult):
390 """An warning that prompts the user if they want to continue."""
391 should_prompt = True
392
393
394# Top level object so multiprocessing can pickle
395# Public access through OutputApi object.
396class _PresubmitNotifyResult(_PresubmitResult):
397 """Just print something to the screen -- but it's not even a warning."""
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000398
399
400# Top level object so multiprocessing can pickle
401# Public access through OutputApi object.
402class _MailTextResult(_PresubmitResult):
403 """A warning that should be included in the review request email."""
404 def __init__(self, *args, **kwargs):
405 super(_MailTextResult, self).__init__()
406 raise NotImplementedError()
407
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000408class GerritAccessor(object):
409 """Limited Gerrit functionality for canned presubmit checks to work.
410
411 To avoid excessive Gerrit calls, caches the results.
412 """
413
Edward Lesmeseb1bd622021-03-01 19:54:07 +0000414 def __init__(self, url=None, project=None, branch=None):
415 self.host = urlparse.urlparse(url).netloc if url else None
416 self.project = project
417 self.branch = branch
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000418 self.cache = {}
Edward Lesmes8170c292021-03-19 20:04:43 +0000419 self.code_owners_enabled = None
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000420
421 def _FetchChangeDetail(self, issue):
422 # Separate function to be easily mocked in tests.
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +0100423 try:
424 return gerrit_util.GetChangeDetail(
425 self.host, str(issue),
Aaron Gable6f5a8d92017-04-18 14:49:05 -0700426 ['ALL_REVISIONS', 'DETAILED_LABELS', 'ALL_COMMITS'])
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +0100427 except gerrit_util.GerritError as e:
428 if e.http_status == 404:
429 raise Exception('Either Gerrit issue %s doesn\'t exist, or '
430 'no credentials to fetch issue details' % issue)
431 raise
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000432
433 def GetChangeInfo(self, issue):
434 """Returns labels and all revisions (patchsets) for this issue.
435
436 The result is a dictionary according to Gerrit REST Api.
437 https://gerrit-review.googlesource.com/Documentation/rest-api.html
438
439 However, API isn't very clear what's inside, so see tests for example.
440 """
441 assert issue
442 cache_key = int(issue)
443 if cache_key not in self.cache:
444 self.cache[cache_key] = self._FetchChangeDetail(issue)
445 return self.cache[cache_key]
446
447 def GetChangeDescription(self, issue, patchset=None):
448 """If patchset is none, fetches current patchset."""
449 info = self.GetChangeInfo(issue)
450 # info is a reference to cache. We'll modify it here adding description to
451 # it to the right patchset, if it is not yet there.
452
453 # Find revision info for the patchset we want.
454 if patchset is not None:
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +0000455 for rev, rev_info in info['revisions'].items():
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000456 if str(rev_info['_number']) == str(patchset):
457 break
458 else:
459 raise Exception('patchset %s doesn\'t exist in issue %s' % (
460 patchset, issue))
461 else:
462 rev = info['current_revision']
463 rev_info = info['revisions'][rev]
464
Andrii Shyshkalov9c3a4642017-01-24 17:41:22 +0100465 return rev_info['commit']['message']
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000466
Mun Yong Jang603d01e2017-12-19 16:38:30 -0800467 def GetDestRef(self, issue):
468 ref = self.GetChangeInfo(issue)['branch']
469 if not ref.startswith('refs/'):
470 # NOTE: it is possible to create 'refs/x' branch,
471 # aka 'refs/heads/refs/x'. However, this is ill-advised.
472 ref = 'refs/heads/%s' % ref
473 return ref
474
Edward Lesmes02d4b822020-11-11 00:37:35 +0000475 def _GetApproversForLabel(self, issue, label):
476 change_info = self.GetChangeInfo(issue)
477 label_info = change_info.get('labels', {}).get(label, {})
478 values = label_info.get('values', {}).keys()
479 if not values:
480 return []
481 max_value = max(int(v) for v in values)
482 return [v for v in label_info.get('all', [])
483 if v.get('value', 0) == max_value]
484
Edward Lesmesc4566172021-03-19 16:55:13 +0000485 def IsBotCommitApproved(self, issue):
486 return bool(self._GetApproversForLabel(issue, 'Bot-Commit'))
487
Edward Lesmescf49cb82020-11-11 01:08:36 +0000488 def IsOwnersOverrideApproved(self, issue):
489 return bool(self._GetApproversForLabel(issue, 'Owners-Override'))
490
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000491 def GetChangeOwner(self, issue):
492 return self.GetChangeInfo(issue)['owner']['email']
493
494 def GetChangeReviewers(self, issue, approving_only=True):
Aaron Gable8b478f02017-07-31 15:33:19 -0700495 changeinfo = self.GetChangeInfo(issue)
496 if approving_only:
Edward Lesmes02d4b822020-11-11 00:37:35 +0000497 reviewers = self._GetApproversForLabel(issue, 'Code-Review')
Aaron Gable8b478f02017-07-31 15:33:19 -0700498 else:
499 reviewers = changeinfo.get('reviewers', {}).get('REVIEWER', [])
500 return [r.get('email') for r in reviewers]
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000501
Edward Lemure4d329c2020-02-03 20:41:18 +0000502 def UpdateDescription(self, description, issue):
503 gerrit_util.SetCommitMessage(self.host, issue, description, notify='NONE')
504
Edward Lesmes8170c292021-03-19 20:04:43 +0000505 def IsCodeOwnersEnabledOnRepo(self):
506 if self.code_owners_enabled is None:
507 self.code_owners_enabled = gerrit_util.IsCodeOwnersEnabledOnRepo(
Edward Lesmes392c4072021-03-19 21:58:45 +0000508 self.host, self.project)
Edward Lesmes8170c292021-03-19 20:04:43 +0000509 return self.code_owners_enabled
510
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000511
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000512class OutputApi(object):
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000513 """An instance of OutputApi gets passed to presubmit scripts so that they
514 can output various types of results.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000515 """
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000516 PresubmitResult = _PresubmitResult
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000517 PresubmitError = _PresubmitError
518 PresubmitPromptWarning = _PresubmitPromptWarning
519 PresubmitNotifyResult = _PresubmitNotifyResult
520 MailTextResult = _MailTextResult
521
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000522 def __init__(self, is_committing):
523 self.is_committing = is_committing
Daniel Cheng7227d212017-11-17 08:12:37 -0800524 self.more_cc = []
525
526 def AppendCC(self, cc):
527 """Appends a user to cc for this change."""
Daniel Cheng541638f2023-05-15 22:00:47 +0000528 self.more_cc.append(cc)
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000529
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000530 def PresubmitPromptOrNotify(self, *args, **kwargs):
531 """Warn the user when uploading, but only notify if committing."""
532 if self.is_committing:
533 return self.PresubmitNotifyResult(*args, **kwargs)
534 return self.PresubmitPromptWarning(*args, **kwargs)
535
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000536
537class InputApi(object):
538 """An instance of this object is passed to presubmit scripts so they can
539 know stuff about the change they're looking at.
540 """
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000541 # Method could be a function
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800542 # pylint: disable=no-self-use
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000543
maruel@chromium.org3410d912009-06-09 20:56:16 +0000544 # File extensions that are considered source files from a style guide
545 # perspective. Don't modify this list from a presubmit script!
maruel@chromium.orgc33455a2011-06-24 19:14:18 +0000546 #
547 # Files without an extension aren't included in the list. If you want to
local_bot30f774e2020-06-25 18:23:34 +0000548 # filter them as source files, add r'(^|.*?[\\\/])[^.]+$' to the allow list.
local_bot64021412020-07-08 21:05:39 +0000549 # Note that ALL CAPS files are skipped in DEFAULT_FILES_TO_SKIP below.
550 DEFAULT_FILES_TO_CHECK = (
maruel@chromium.org3410d912009-06-09 20:56:16 +0000551 # C++ and friends
Edward Lemura5799e32020-01-17 19:26:51 +0000552 r'.+\.c$', r'.+\.cc$', r'.+\.cpp$', r'.+\.h$', r'.+\.m$', r'.+\.mm$',
553 r'.+\.inl$', r'.+\.asm$', r'.+\.hxx$', r'.+\.hpp$', r'.+\.s$', r'.+\.S$',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000554 # Scripts
dpapad443d9132022-05-05 00:17:30 +0000555 r'.+\.js$', r'.+\.ts$', r'.+\.py$', r'.+\.sh$', r'.+\.rb$', r'.+\.pl$',
556 r'.+\.pm$',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000557 # Other
Edward Lemura5799e32020-01-17 19:26:51 +0000558 r'.+\.java$', r'.+\.mk$', r'.+\.am$', r'.+\.css$', r'.+\.mojom$',
Bruce Dawson7a81ebf2023-01-03 18:36:18 +0000559 r'.+\.fidl$', r'.+\.rs$',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000560 )
561
562 # Path regexp that should be excluded from being considered containing source
563 # files. Don't modify this list from a presubmit script!
local_bot64021412020-07-08 21:05:39 +0000564 DEFAULT_FILES_TO_SKIP = (
Edward Lemura5799e32020-01-17 19:26:51 +0000565 r'testing_support[\\\/]google_appengine[\\\/].*',
566 r'.*\bexperimental[\\\/].*',
Kent Tamura179dd1e2018-04-26 15:07:41 +0900567 # Exclude third_party/.* but NOT third_party/{WebKit,blink}
568 # (crbug.com/539768 and crbug.com/836555).
Edward Lemura5799e32020-01-17 19:26:51 +0000569 r'.*\bthird_party[\\\/](?!(WebKit|blink)[\\\/]).*',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000570 # Output directories (just in case)
Edward Lemura5799e32020-01-17 19:26:51 +0000571 r'.*\bDebug[\\\/].*',
572 r'.*\bRelease[\\\/].*',
573 r'.*\bxcodebuild[\\\/].*',
574 r'.*\bout[\\\/].*',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000575 # All caps files like README and LICENCE.
Edward Lemura5799e32020-01-17 19:26:51 +0000576 r'.*\b[A-Z0-9_]{2,}$',
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +0000577 # SCM (can happen in dual SCM configuration). (Slightly over aggressive)
Edward Lemura5799e32020-01-17 19:26:51 +0000578 r'(|.*[\\\/])\.git[\\\/].*',
579 r'(|.*[\\\/])\.svn[\\\/].*',
maruel@chromium.org7ccb4bb2011-11-07 20:26:20 +0000580 # There is no point in processing a patch file.
Edward Lemura5799e32020-01-17 19:26:51 +0000581 r'.+\.diff$',
582 r'.+\.patch$',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000583 )
584
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000585 def __init__(self, change, presubmit_path, is_committing,
Bruce Dawson09c0c072022-05-26 20:28:58 +0000586 verbose, gerrit_obj, dry_run=None, thread_pool=None, parallel=False,
587 no_diffs=False):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000588 """Builds an InputApi object.
589
590 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000591 change: A presubmit.Change object.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000592 presubmit_path: The path to the presubmit script being processed.
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000593 is_committing: True if the change is about to be committed.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000594 gerrit_obj: provides basic Gerrit codereview functionality.
595 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -0400596 parallel: if true, all tests reported via input_api.RunTests for all
597 PRESUBMIT files will be run in parallel.
Bruce Dawson09c0c072022-05-26 20:28:58 +0000598 no_diffs: if true, implies that --files or --all was specified so some
599 checks can be skipped, and some errors will be messages.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000600 """
maruel@chromium.org9711bba2009-05-22 23:51:39 +0000601 # Version number of the presubmit_support script.
602 self.version = [int(x) for x in __version__.split('.')]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000603 self.change = change
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000604 self.is_committing = is_committing
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000605 self.gerrit = gerrit_obj
tandrii@chromium.org57bafac2016-04-28 05:09:03 +0000606 self.dry_run = dry_run
Bruce Dawson09c0c072022-05-26 20:28:58 +0000607 self.no_diffs = no_diffs
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000608
Edward Lesmes8e282792018-04-03 18:50:29 -0400609 self.parallel = parallel
610 self.thread_pool = thread_pool or ThreadPool()
611
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000612 # We expose various modules and functions as attributes of the input_api
613 # so that presubmit scripts don't have to import them.
Takeshi Yoshino07a6bea2017-08-02 02:44:06 +0900614 self.ast = ast
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000615 self.basename = os.path.basename
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000616 self.cpplint = cpplint
dcheng091b7db2016-06-16 01:27:51 -0700617 self.fnmatch = fnmatch
Yoshisato Yanagisawa04600b42019-03-15 03:03:41 +0000618 self.gclient_paths = gclient_paths
Yoshisato Yanagisawa57dd17b2019-03-22 09:10:29 +0000619 # TODO(yyanagisawa): stop exposing this when python3 become default.
620 # Since python3's tempfile has TemporaryDirectory, we do not need this.
621 self.temporary_directory = gclient_utils.temporary_directory
dpranke@chromium.org17cc2442012-10-17 21:12:09 +0000622 self.glob = glob.glob
maruel@chromium.orgfb11c7b2010-03-18 18:22:14 +0000623 self.json = json
maruel@chromium.org6fba34d2011-06-02 13:45:12 +0000624 self.logging = logging.getLogger('PRESUBMIT')
maruel@chromium.org2b5ce562011-03-31 16:15:44 +0000625 self.os_listdir = os.listdir
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000626 self.os_path = os.path
pgervais@chromium.orgbd0cace2014-10-02 23:23:46 +0000627 self.os_stat = os.stat
Yoshisato Yanagisawa406de132018-06-29 05:43:25 +0000628 self.os_walk = os.walk
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000629 self.re = re
630 self.subprocess = subprocess
Edward Lemurb9830242019-10-30 22:19:20 +0000631 self.sys = sys
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000632 self.tempfile = tempfile
dpranke@chromium.org0d1bdea2011-03-24 22:54:38 +0000633 self.time = time
maruel@chromium.org1487d532009-06-06 00:22:57 +0000634 self.unittest = unittest
Edward Lemurb9830242019-10-30 22:19:20 +0000635 if sys.version_info.major == 2:
636 self.urllib2 = urllib2
Edward Lemur16af3562019-10-17 22:11:33 +0000637 self.urllib_request = urllib_request
638 self.urllib_error = urllib_error
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000639
Robert Iannucci50258932018-03-19 10:30:59 -0700640 self.is_windows = sys.platform == 'win32'
641
Bruce Dawsonb6cb9e02023-05-18 20:52:43 +0000642 # Set python_executable to 'vpython3' in order to allow scripts in other
Edward Lemurb9646622019-10-25 20:57:35 +0000643 # repos (e.g. src.git) to automatically pick up that repo's .vpython file,
644 # instead of inheriting the one in depot_tools.
Bruce Dawsonb6cb9e02023-05-18 20:52:43 +0000645 self.python_executable = 'vpython3'
Erik Staab69135d12021-05-14 22:31:57 +0000646 # Offer a python 3 executable for use during the migration off of python 2.
647 self.python3_executable = 'vpython3'
maruel@chromium.orgc0b22972009-06-25 16:19:14 +0000648 self.environ = os.environ
649
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000650 # InputApi.platform is the platform you're currently running on.
651 self.platform = sys.platform
652
iannucci@chromium.org0af3bb32015-06-12 20:44:35 +0000653 self.cpu_count = multiprocessing.cpu_count()
Bruce Dawson8254f062022-06-17 17:33:08 +0000654 if self.is_windows:
655 # TODO(crbug.com/1190269) - we can't use more than 56 child processes on
656 # Windows or Python3 may hang.
657 self.cpu_count = min(self.cpu_count, 56)
iannucci@chromium.org0af3bb32015-06-12 20:44:35 +0000658
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000659 # The local path of the currently-being-processed presubmit script.
maruel@chromium.org3d235242009-05-15 12:40:48 +0000660 self._current_presubmit_path = os.path.dirname(presubmit_path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000661
662 # We carry the canned checks so presubmit scripts can easily use them.
663 self.canned_checks = presubmit_canned_checks
664
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +0100665 # Temporary files we must manually remove at the end of a run.
666 self._named_temporary_files = []
Jochen Eisinger72606f82017-04-04 10:44:18 +0200667
Edward Lesmesdc11c6b2021-03-19 19:22:05 +0000668 self.owners_client = None
Bruce Dawsoneb8426e2022-08-05 23:58:15 +0000669 if self.gerrit and not 'PRESUBMIT_SKIP_NETWORK' in self.environ:
Bruce Dawson9b9f4512022-04-27 00:56:52 +0000670 try:
671 self.owners_client = owners_client.GetCodeOwnersClient(
Bruce Dawson9b9f4512022-04-27 00:56:52 +0000672 host=self.gerrit.host,
673 project=self.gerrit.project,
674 branch=self.gerrit.branch)
675 except Exception as e:
676 print('Failed to set owners_client - %s' % str(e))
Jochen Eisinger76f5fc62017-04-07 16:27:46 +0200677 self.owners_finder = owners_finder.OwnersFinder
maruel@chromium.org899e1c12011-04-07 17:03:18 +0000678 self.verbose = verbose
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000679 self.Command = CommandData
dpranke@chromium.org2a009622011-03-01 02:43:31 +0000680
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000681 # Replace <hash_map> and <hash_set> as headers that need to be included
Edward Lemura5799e32020-01-17 19:26:51 +0000682 # with 'base/containers/hash_tables.h' instead.
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000683 # Access to a protected member _XX of a client class
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800684 # pylint: disable=protected-access
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000685 self.cpplint._re_pattern_templates = [
danakj@chromium.org18278522013-06-11 22:42:32 +0000686 (a, b, 'base/containers/hash_tables.h')
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000687 if header in ('<hash_map>', '<hash_set>') else (a, b, header)
688 for (a, b, header) in cpplint._re_pattern_templates
689 ]
690
Edward Lemurecc27072020-01-06 16:42:34 +0000691 def SetTimeout(self, timeout):
692 self.thread_pool.timeout = timeout
693
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000694 def PresubmitLocalPath(self):
695 """Returns the local path of the presubmit script currently being run.
696
697 This is useful if you don't want to hard-code absolute paths in the
698 presubmit script. For example, It can be used to find another file
699 relative to the PRESUBMIT.py script, so the whole tree can be branched and
700 the presubmit script still works, without editing its content.
701 """
maruel@chromium.org3d235242009-05-15 12:40:48 +0000702 return self._current_presubmit_path
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000703
agable0b65e732016-11-22 09:25:46 -0800704 def AffectedFiles(self, include_deletes=True, file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000705 """Same as input_api.change.AffectedFiles() except only lists files
706 (and optionally directories) in the same directory as the current presubmit
Bruce Dawson7a0b07a2020-04-23 17:14:40 +0000707 script, or subdirectories thereof. Note that files are listed using the OS
708 path separator, so backslashes are used as separators on Windows.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000709 """
Josip Sokcevica9a7eec2023-03-10 03:54:52 +0000710 dir_with_slash = normpath(self.PresubmitLocalPath())
Bruce Dawson31bfd512022-05-10 23:19:39 +0000711 # normpath strips trailing path separators, so the trailing separator has to
712 # be added after the normpath call.
713 if len(dir_with_slash) > 0:
714 dir_with_slash += os.path.sep
sail@chromium.org5538e022011-05-12 17:53:16 +0000715
Josip Sokcevica9a7eec2023-03-10 03:54:52 +0000716 return list(filter(
717 lambda x: normpath(x.AbsoluteLocalPath()).startswith(dir_with_slash),
718 self.change.AffectedFiles(include_deletes, file_filter)))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000719
agable0b65e732016-11-22 09:25:46 -0800720 def LocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000721 """Returns local paths of input_api.AffectedFiles()."""
agable0b65e732016-11-22 09:25:46 -0800722 paths = [af.LocalPath() for af in self.AffectedFiles()]
Edward Lemura5799e32020-01-17 19:26:51 +0000723 logging.debug('LocalPaths: %s', paths)
pgervais@chromium.org2f64f782014-04-25 00:12:33 +0000724 return paths
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000725
agable0b65e732016-11-22 09:25:46 -0800726 def AbsoluteLocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000727 """Returns absolute local paths of input_api.AffectedFiles()."""
agable0b65e732016-11-22 09:25:46 -0800728 return [af.AbsoluteLocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000729
John Budorick16162372018-04-18 10:39:53 -0700730 def AffectedTestableFiles(self, include_deletes=None, **kwargs):
agable0b65e732016-11-22 09:25:46 -0800731 """Same as input_api.change.AffectedTestableFiles() except only lists files
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000732 in the same directory as the current presubmit script, or subdirectories
733 thereof.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000734 """
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000735 if include_deletes is not None:
Edward Lemura5799e32020-01-17 19:26:51 +0000736 warn('AffectedTestableFiles(include_deletes=%s)'
737 ' is deprecated and ignored' % str(include_deletes),
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000738 category=DeprecationWarning,
739 stacklevel=2)
Josip Sokcevic4de5dea2022-03-23 21:15:14 +0000740 # pylint: disable=consider-using-generator
741 return [
742 x for x in self.AffectedFiles(include_deletes=False, **kwargs)
743 if x.IsTestableFile()
744 ]
agable0b65e732016-11-22 09:25:46 -0800745
746 def AffectedTextFiles(self, include_deletes=None):
747 """An alias to AffectedTestableFiles for backwards compatibility."""
748 return self.AffectedTestableFiles(include_deletes=include_deletes)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000749
Josip Sokcevic8c955952021-02-01 21:32:57 +0000750 def FilterSourceFile(self,
751 affected_file,
752 files_to_check=None,
753 files_to_skip=None,
754 allow_list=None,
755 block_list=None):
Edward Lemura5799e32020-01-17 19:26:51 +0000756 """Filters out files that aren't considered 'source file'.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000757
local_bot64021412020-07-08 21:05:39 +0000758 If files_to_check or files_to_skip is None, InputApi.DEFAULT_FILES_TO_CHECK
759 and InputApi.DEFAULT_FILES_TO_SKIP is used respectively.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000760
Bruce Dawson635383f2022-09-13 16:23:18 +0000761 affected_file.LocalPath() needs to re.match an entry in the files_to_check
762 list and not re.match any entries in the files_to_skip list.
763 '/' path separators should be used in the regular expressions and will work
764 on Windows as well as other platforms.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000765
766 Note: Copy-paste this function to suit your needs or use a lambda function.
767 """
local_bot64021412020-07-08 21:05:39 +0000768 if files_to_check is None:
769 files_to_check = self.DEFAULT_FILES_TO_CHECK
770 if files_to_skip is None:
771 files_to_skip = self.DEFAULT_FILES_TO_SKIP
local_bot30f774e2020-06-25 18:23:34 +0000772
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000773 def Find(affected_file, items):
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000774 local_path = affected_file.LocalPath()
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000775 for item in items:
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +0000776 if self.re.match(item, local_path):
maruel@chromium.org3410d912009-06-09 20:56:16 +0000777 return True
Bruce Dawsona3a014e2022-04-27 23:28:17 +0000778 # Handle the cases where the files regex only handles /, but the local
779 # path uses \.
780 if self.is_windows and self.re.match(item, local_path.replace(
781 '\\', '/')):
782 return True
maruel@chromium.org3410d912009-06-09 20:56:16 +0000783 return False
local_bot64021412020-07-08 21:05:39 +0000784 return (Find(affected_file, files_to_check) and
785 not Find(affected_file, files_to_skip))
maruel@chromium.org3410d912009-06-09 20:56:16 +0000786
787 def AffectedSourceFiles(self, source_file):
agable0b65e732016-11-22 09:25:46 -0800788 """Filter the list of AffectedTestableFiles by the function source_file.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000789
790 If source_file is None, InputApi.FilterSourceFile() is used.
791 """
792 if not source_file:
793 source_file = self.FilterSourceFile
Edward Lemurb9830242019-10-30 22:19:20 +0000794 return list(filter(source_file, self.AffectedTestableFiles()))
maruel@chromium.org3410d912009-06-09 20:56:16 +0000795
796 def RightHandSideLines(self, source_file_filter=None):
Edward Lemura5799e32020-01-17 19:26:51 +0000797 """An iterator over all text lines in 'new' version of changed files.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000798
799 Only lists lines from new or modified text files in the change that are
800 contained by the directory of the currently executing presubmit script.
801
802 This is useful for doing line-by-line regex checks, like checking for
803 trailing whitespace.
804
805 Yields:
806 a 3 tuple:
Josip Sokcevic7958e302023-03-01 23:02:21 +0000807 the AffectedFile instance of the current file;
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000808 integer line number (1-based); and
809 the contents of the line as a string.
maruel@chromium.org1487d532009-06-06 00:22:57 +0000810
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000811 Note: The carriage return (LF or CR) is stripped off.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000812 """
maruel@chromium.org3410d912009-06-09 20:56:16 +0000813 files = self.AffectedSourceFiles(source_file_filter)
Josip Sokcevic7958e302023-03-01 23:02:21 +0000814 return _RightHandSideLinesImpl(files)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000815
maruel@chromium.orge3608df2009-11-10 20:22:57 +0000816 def ReadFile(self, file_item, mode='r'):
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000817 """Reads an arbitrary file.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000818
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000819 Deny reading anything outside the repository.
820 """
Josip Sokcevic7958e302023-03-01 23:02:21 +0000821 if isinstance(file_item, AffectedFile):
maruel@chromium.orge3608df2009-11-10 20:22:57 +0000822 file_item = file_item.AbsoluteLocalPath()
823 if not file_item.startswith(self.change.RepositoryRoot()):
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000824 raise IOError('Access outside the repository root is denied.')
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +0000825 return gclient_utils.FileRead(file_item, mode)
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000826
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +0100827 def CreateTemporaryFile(self, **kwargs):
828 """Returns a named temporary file that must be removed with a call to
829 RemoveTemporaryFiles().
830
831 All keyword arguments are forwarded to tempfile.NamedTemporaryFile(),
832 except for |delete|, which is always set to False.
833
834 Presubmit checks that need to create a temporary file and pass it for
835 reading should use this function instead of NamedTemporaryFile(), as
836 Windows fails to open a file that is already open for writing.
837
838 with input_api.CreateTemporaryFile() as f:
839 f.write('xyz')
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +0100840 input_api.subprocess.check_output(['script-that', '--reads-from',
841 f.name])
842
843
844 Note that callers of CreateTemporaryFile() should not worry about removing
845 any temporary file; this is done transparently by the presubmit handling
846 code.
847 """
848 if 'delete' in kwargs:
849 # Prevent users from passing |delete|; we take care of file deletion
850 # ourselves and this prevents unintuitive error messages when we pass
851 # delete=False and 'delete' is also in kwargs.
852 raise TypeError('CreateTemporaryFile() does not take a "delete" '
853 'argument, file deletion is handled automatically by '
854 'the same presubmit_support code that creates InputApi '
855 'objects.')
856 temp_file = self.tempfile.NamedTemporaryFile(delete=False, **kwargs)
857 self._named_temporary_files.append(temp_file.name)
858 return temp_file
859
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000860 @property
861 def tbr(self):
862 """Returns if a change is TBR'ed."""
Jeremy Romandce22502017-06-20 15:37:29 -0400863 return 'TBR' in self.change.tags or self.change.TBRsFromDescription()
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000864
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +0000865 def RunTests(self, tests_mix, parallel=True):
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000866 tests = []
867 msgs = []
868 for t in tests_mix:
Edward Lesmes8e282792018-04-03 18:50:29 -0400869 if isinstance(t, OutputApi.PresubmitResult) and t:
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000870 msgs.append(t)
871 else:
872 assert issubclass(t.message, _PresubmitResult)
873 tests.append(t)
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +0000874 if self.verbose:
875 t.info = _PresubmitNotifyResult
Edward Lemur1037c742018-05-01 18:56:04 -0400876 if not t.kwargs.get('cwd'):
877 t.kwargs['cwd'] = self.PresubmitLocalPath()
Edward Lesmes8e282792018-04-03 18:50:29 -0400878 self.thread_pool.AddTests(tests, parallel)
Edward Lemur21000eb2019-05-24 23:25:58 +0000879 # When self.parallel is True (i.e. --parallel is passed as an option)
880 # RunTests doesn't actually run tests. It adds them to a ThreadPool that
881 # will run all tests once all PRESUBMIT files are processed.
882 # Otherwise, it will run them and return the results.
883 if not self.parallel:
Edward Lesmes8e282792018-04-03 18:50:29 -0400884 msgs.extend(self.thread_pool.RunAsync())
885 return msgs
scottmg86099d72016-09-01 09:16:51 -0700886
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000887
Josip Sokcevic7958e302023-03-01 23:02:21 +0000888class _DiffCache(object):
889 """Caches diffs retrieved from a particular SCM."""
890 def __init__(self, upstream=None):
891 """Stores the upstream revision against which all diffs will be computed."""
892 self._upstream = upstream
893
894 def GetDiff(self, path, local_root):
895 """Get the diff for a particular path."""
896 raise NotImplementedError()
897
898 def GetOldContents(self, path, local_root):
899 """Get the old version for a particular path."""
900 raise NotImplementedError()
901
902
903class _GitDiffCache(_DiffCache):
904 """DiffCache implementation for git; gets all file diffs at once."""
905 def __init__(self, upstream):
906 super(_GitDiffCache, self).__init__(upstream=upstream)
907 self._diffs_by_file = None
908
909 def GetDiff(self, path, local_root):
910 # Compare against None to distinguish between None and an initialized but
911 # empty dictionary.
912 if self._diffs_by_file == None:
913 # Compute a single diff for all files and parse the output; should
914 # with git this is much faster than computing one diff for each file.
915 diffs = {}
916
917 # Don't specify any filenames below, because there are command line length
918 # limits on some platforms and GenerateDiff would fail.
919 unified_diff = scm.GIT.GenerateDiff(local_root, files=[], full_move=True,
920 branch=self._upstream)
921
922 # This regex matches the path twice, separated by a space. Note that
923 # filename itself may contain spaces.
924 file_marker = re.compile('^diff --git (?P<filename>.*) (?P=filename)$')
925 current_diff = []
926 keep_line_endings = True
927 for x in unified_diff.splitlines(keep_line_endings):
928 match = file_marker.match(x)
929 if match:
930 # Marks the start of a new per-file section.
931 diffs[match.group('filename')] = current_diff = [x]
932 elif x.startswith('diff --git'):
933 raise PresubmitFailure('Unexpected diff line: %s' % x)
934 else:
935 current_diff.append(x)
936
937 self._diffs_by_file = dict(
Josip Sokcevica9a7eec2023-03-10 03:54:52 +0000938 (normpath(path), ''.join(diff)) for path, diff in diffs.items())
Josip Sokcevic7958e302023-03-01 23:02:21 +0000939
940 if path not in self._diffs_by_file:
941 # SCM didn't have any diff on this file. It could be that the file was not
942 # modified at all (e.g. user used --all flag in git cl presubmit).
943 # Intead of failing, return empty string.
944 # See: https://crbug.com/808346.
945 return ''
946
947 return self._diffs_by_file[path]
948
949 def GetOldContents(self, path, local_root):
950 return scm.GIT.GetOldContents(local_root, path, branch=self._upstream)
951
952
953class AffectedFile(object):
954 """Representation of a file in a change."""
955
956 DIFF_CACHE = _DiffCache
957
958 # Method could be a function
959 # pylint: disable=no-self-use
960 def __init__(self, path, action, repository_root, diff_cache):
961 self._path = path
962 self._action = action
963 self._local_root = repository_root
964 self._is_directory = None
965 self._cached_changed_contents = None
966 self._cached_new_contents = None
967 self._diff_cache = diff_cache
968 logging.debug('%s(%s)', self.__class__.__name__, self._path)
969
970 def LocalPath(self):
971 """Returns the path of this file on the local disk relative to client root.
972
973 This should be used for error messages but not for accessing files,
974 because presubmit checks are run with CWD=PresubmitLocalPath() (which is
975 often != client root).
976 """
Josip Sokcevica9a7eec2023-03-10 03:54:52 +0000977 return normpath(self._path)
Josip Sokcevic7958e302023-03-01 23:02:21 +0000978
979 def AbsoluteLocalPath(self):
980 """Returns the absolute path of this file on the local disk.
981 """
982 return os.path.abspath(os.path.join(self._local_root, self.LocalPath()))
983
984 def Action(self):
985 """Returns the action on this opened file, e.g. A, M, D, etc."""
986 return self._action
987
988 def IsTestableFile(self):
989 """Returns True if the file is a text file and not a binary file.
990
991 Deleted files are not text file."""
992 raise NotImplementedError() # Implement when needed
993
994 def IsTextFile(self):
995 """An alias to IsTestableFile for backwards compatibility."""
996 return self.IsTestableFile()
997
998 def OldContents(self):
999 """Returns an iterator over the lines in the old version of file.
1000
1001 The old version is the file before any modifications in the user's
1002 workspace, i.e. the 'left hand side'.
1003
1004 Contents will be empty if the file is a directory or does not exist.
1005 Note: The carriage returns (LF or CR) are stripped off.
1006 """
1007 return self._diff_cache.GetOldContents(self.LocalPath(),
1008 self._local_root).splitlines()
1009
1010 def NewContents(self):
1011 """Returns an iterator over the lines in the new version of file.
1012
1013 The new version is the file in the user's workspace, i.e. the 'right hand
1014 side'.
1015
1016 Contents will be empty if the file is a directory or does not exist.
1017 Note: The carriage returns (LF or CR) are stripped off.
1018 """
1019 if self._cached_new_contents is None:
1020 self._cached_new_contents = []
1021 try:
1022 self._cached_new_contents = gclient_utils.FileRead(
1023 self.AbsoluteLocalPath(), 'rU').splitlines()
1024 except IOError:
1025 pass # File not found? That's fine; maybe it was deleted.
1026 except UnicodeDecodeError as e:
1027 # log the filename since we're probably trying to read a binary
1028 # file, and shouldn't be.
1029 print('Error reading %s: %s' % (self.AbsoluteLocalPath(), e))
1030 raise
1031
1032 return self._cached_new_contents[:]
1033
1034 def ChangedContents(self, keeplinebreaks=False):
1035 """Returns a list of tuples (line number, line text) of all new lines.
1036
1037 This relies on the scm diff output describing each changed code section
1038 with a line of the form
1039
1040 ^@@ <old line num>,<old size> <new line num>,<new size> @@$
1041 """
1042 # Don't return cached results when line breaks are requested.
1043 if not keeplinebreaks and self._cached_changed_contents is not None:
1044 return self._cached_changed_contents[:]
1045 result = []
1046 line_num = 0
1047
1048 # The keeplinebreaks parameter to splitlines must be True or else the
1049 # CheckForWindowsLineEndings presubmit will be a NOP.
1050 for line in self.GenerateScmDiff().splitlines(keeplinebreaks):
1051 m = re.match(r'^@@ [0-9\,\+\-]+ \+([0-9]+)\,[0-9]+ @@', line)
1052 if m:
1053 line_num = int(m.groups(1)[0])
1054 continue
1055 if line.startswith('+') and not line.startswith('++'):
1056 result.append((line_num, line[1:]))
1057 if not line.startswith('-'):
1058 line_num += 1
1059 # Don't cache results with line breaks.
1060 if keeplinebreaks:
1061 return result;
1062 self._cached_changed_contents = result
1063 return self._cached_changed_contents[:]
1064
1065 def __str__(self):
1066 return self.LocalPath()
1067
1068 def GenerateScmDiff(self):
1069 return self._diff_cache.GetDiff(self.LocalPath(), self._local_root)
1070
1071
1072class GitAffectedFile(AffectedFile):
1073 """Representation of a file in a change out of a git checkout."""
1074 # Method 'NNN' is abstract in class 'NNN' but is not overridden
1075 # pylint: disable=abstract-method
1076
1077 DIFF_CACHE = _GitDiffCache
1078
1079 def __init__(self, *args, **kwargs):
1080 AffectedFile.__init__(self, *args, **kwargs)
1081 self._server_path = None
1082 self._is_testable_file = None
1083
1084 def IsTestableFile(self):
1085 if self._is_testable_file is None:
1086 if self.Action() == 'D':
1087 # A deleted file is not testable.
1088 self._is_testable_file = False
1089 else:
1090 self._is_testable_file = os.path.isfile(self.AbsoluteLocalPath())
1091 return self._is_testable_file
1092
1093
1094class Change(object):
1095 """Describe a change.
1096
1097 Used directly by the presubmit scripts to query the current change being
1098 tested.
1099
1100 Instance members:
1101 tags: Dictionary of KEY=VALUE pairs found in the change description.
1102 self.KEY: equivalent to tags['KEY']
1103 """
1104
1105 _AFFECTED_FILES = AffectedFile
1106
1107 # Matches key/value (or 'tag') lines in changelist descriptions.
1108 TAG_LINE_RE = re.compile(
1109 '^[ \t]*(?P<key>[A-Z][A-Z_0-9]*)[ \t]*=[ \t]*(?P<value>.*?)[ \t]*$')
1110 scm = ''
1111
1112 def __init__(
1113 self, name, description, local_root, files, issue, patchset, author,
1114 upstream=None):
1115 if files is None:
1116 files = []
1117 self._name = name
1118 # Convert root into an absolute path.
1119 self._local_root = os.path.abspath(local_root)
1120 self._upstream = upstream
1121 self.issue = issue
1122 self.patchset = patchset
1123 self.author_email = author
1124
1125 self._full_description = ''
1126 self.tags = {}
1127 self._description_without_tags = ''
1128 self.SetDescriptionText(description)
1129
1130 assert all(
1131 (isinstance(f, (list, tuple)) and len(f) == 2) for f in files), files
1132
1133 diff_cache = self._AFFECTED_FILES.DIFF_CACHE(self._upstream)
1134 self._affected_files = [
1135 self._AFFECTED_FILES(path, action.strip(), self._local_root, diff_cache)
1136 for action, path in files
1137 ]
1138
1139 def UpstreamBranch(self):
1140 """Returns the upstream branch for the change."""
1141 return self._upstream
1142
1143 def Name(self):
1144 """Returns the change name."""
1145 return self._name
1146
1147 def DescriptionText(self):
1148 """Returns the user-entered changelist description, minus tags.
1149
1150 Any line in the user-provided description starting with e.g. 'FOO='
1151 (whitespace permitted before and around) is considered a tag line. Such
1152 lines are stripped out of the description this function returns.
1153 """
1154 return self._description_without_tags
1155
1156 def FullDescriptionText(self):
1157 """Returns the complete changelist description including tags."""
1158 return self._full_description
1159
1160 def SetDescriptionText(self, description):
1161 """Sets the full description text (including tags) to |description|.
1162
1163 Also updates the list of tags."""
1164 self._full_description = description
1165
1166 # From the description text, build up a dictionary of key/value pairs
1167 # plus the description minus all key/value or 'tag' lines.
1168 description_without_tags = []
1169 self.tags = {}
1170 for line in self._full_description.splitlines():
1171 m = self.TAG_LINE_RE.match(line)
1172 if m:
1173 self.tags[m.group('key')] = m.group('value')
1174 else:
1175 description_without_tags.append(line)
1176
1177 # Change back to text and remove whitespace at end.
1178 self._description_without_tags = (
1179 '\n'.join(description_without_tags).rstrip())
1180
1181 def AddDescriptionFooter(self, key, value):
1182 """Adds the given footer to the change description.
1183
1184 Args:
1185 key: A string with the key for the git footer. It must conform to
1186 the git footers format (i.e. 'List-Of-Tokens') and will be case
1187 normalized so that each token is title-cased.
1188 value: A string with the value for the git footer.
1189 """
1190 description = git_footers.add_footer(
1191 self.FullDescriptionText(), git_footers.normalize_name(key), value)
1192 self.SetDescriptionText(description)
1193
1194 def RepositoryRoot(self):
1195 """Returns the repository (checkout) root directory for this change,
1196 as an absolute path.
1197 """
1198 return self._local_root
1199
1200 def __getattr__(self, attr):
1201 """Return tags directly as attributes on the object."""
1202 if not re.match(r'^[A-Z_]*$', attr):
1203 raise AttributeError(self, attr)
1204 return self.tags.get(attr)
1205
1206 def GitFootersFromDescription(self):
1207 """Return the git footers present in the description.
1208
1209 Returns:
1210 footers: A dict of {footer: [values]} containing a multimap of the footers
1211 in the change description.
1212 """
1213 return git_footers.parse_footers(self.FullDescriptionText())
1214
1215 def BugsFromDescription(self):
1216 """Returns all bugs referenced in the commit description."""
1217 bug_tags = ['BUG', 'FIXED']
1218
1219 tags = []
1220 for tag in bug_tags:
1221 values = self.tags.get(tag)
1222 if values:
1223 tags += [value.strip() for value in values.split(',')]
1224
1225 footers = []
1226 parsed = self.GitFootersFromDescription()
1227 unsplit_footers = parsed.get('Bug', []) + parsed.get('Fixed', [])
1228 for unsplit_footer in unsplit_footers:
1229 footers += [b.strip() for b in unsplit_footer.split(',')]
1230 return sorted(set(tags + footers))
1231
1232 def ReviewersFromDescription(self):
1233 """Returns all reviewers listed in the commit description."""
1234 # We don't support a 'R:' git-footer for reviewers; that is in metadata.
1235 tags = [r.strip() for r in self.tags.get('R', '').split(',') if r.strip()]
1236 return sorted(set(tags))
1237
1238 def TBRsFromDescription(self):
1239 """Returns all TBR reviewers listed in the commit description."""
1240 tags = [r.strip() for r in self.tags.get('TBR', '').split(',') if r.strip()]
1241 # TODO(crbug.com/839208): Remove support for 'Tbr:' when TBRs are
1242 # programmatically determined by self-CR+1s.
1243 footers = self.GitFootersFromDescription().get('Tbr', [])
1244 return sorted(set(tags + footers))
1245
1246 # TODO(crbug.com/753425): Delete these once we're sure they're unused.
1247 @property
1248 def BUG(self):
1249 return ','.join(self.BugsFromDescription())
1250 @property
1251 def R(self):
1252 return ','.join(self.ReviewersFromDescription())
1253 @property
1254 def TBR(self):
1255 return ','.join(self.TBRsFromDescription())
1256
1257 def AllFiles(self, root=None):
1258 """List all files under source control in the repo."""
1259 raise NotImplementedError()
1260
1261 def AffectedFiles(self, include_deletes=True, file_filter=None):
1262 """Returns a list of AffectedFile instances for all files in the change.
1263
1264 Args:
1265 include_deletes: If false, deleted files will be filtered out.
1266 file_filter: An additional filter to apply.
1267
1268 Returns:
1269 [AffectedFile(path, action), AffectedFile(path, action)]
1270 """
1271 affected = list(filter(file_filter, self._affected_files))
1272
1273 if include_deletes:
1274 return affected
1275 return list(filter(lambda x: x.Action() != 'D', affected))
1276
1277 def AffectedTestableFiles(self, include_deletes=None, **kwargs):
1278 """Return a list of the existing text files in a change."""
1279 if include_deletes is not None:
1280 warn('AffectedTeestableFiles(include_deletes=%s)'
1281 ' is deprecated and ignored' % str(include_deletes),
1282 category=DeprecationWarning,
1283 stacklevel=2)
1284 return list(filter(
1285 lambda x: x.IsTestableFile(),
1286 self.AffectedFiles(include_deletes=False, **kwargs)))
1287
1288 def AffectedTextFiles(self, include_deletes=None):
1289 """An alias to AffectedTestableFiles for backwards compatibility."""
1290 return self.AffectedTestableFiles(include_deletes=include_deletes)
1291
1292 def LocalPaths(self):
1293 """Convenience function."""
1294 return [af.LocalPath() for af in self.AffectedFiles()]
1295
1296 def AbsoluteLocalPaths(self):
1297 """Convenience function."""
1298 return [af.AbsoluteLocalPath() for af in self.AffectedFiles()]
1299
1300 def RightHandSideLines(self):
1301 """An iterator over all text lines in 'new' version of changed files.
1302
1303 Lists lines from new or modified text files in the change.
1304
1305 This is useful for doing line-by-line regex checks, like checking for
1306 trailing whitespace.
1307
1308 Yields:
1309 a 3 tuple:
1310 the AffectedFile instance of the current file;
1311 integer line number (1-based); and
1312 the contents of the line as a string.
1313 """
1314 return _RightHandSideLinesImpl(
1315 x for x in self.AffectedFiles(include_deletes=False)
1316 if x.IsTestableFile())
1317
1318 def OriginalOwnersFiles(self):
1319 """A map from path names of affected OWNERS files to their old content."""
1320 def owners_file_filter(f):
1321 return 'OWNERS' in os.path.split(f.LocalPath())[1]
1322 files = self.AffectedFiles(file_filter=owners_file_filter)
1323 return {f.LocalPath(): f.OldContents() for f in files}
1324
1325
1326class GitChange(Change):
1327 _AFFECTED_FILES = GitAffectedFile
1328 scm = 'git'
1329
1330 def AllFiles(self, root=None):
1331 """List all files under source control in the repo."""
1332 root = root or self.RepositoryRoot()
1333 return subprocess.check_output(
1334 ['git', '-c', 'core.quotePath=false', 'ls-files', '--', '.'],
1335 cwd=root).decode('utf-8', 'ignore').splitlines()
1336
1337
Josip Sokcevica9a7eec2023-03-10 03:54:52 +00001338def ListRelevantPresubmitFiles(files, root):
1339 """Finds all presubmit files that apply to a given set of source files.
1340
1341 If inherit-review-settings-ok is present right under root, looks for
1342 PRESUBMIT.py in directories enclosing root.
1343
1344 Args:
1345 files: An iterable container containing file paths.
1346 root: Path where to stop searching.
1347
1348 Return:
1349 List of absolute paths of the existing PRESUBMIT.py scripts.
1350 """
1351 files = [normpath(os.path.join(root, f)) for f in files]
1352
1353 # List all the individual directories containing files.
1354 directories = {os.path.dirname(f) for f in files}
1355
1356 # Ignore root if inherit-review-settings-ok is present.
1357 if os.path.isfile(os.path.join(root, 'inherit-review-settings-ok')):
1358 root = None
1359
1360 # Collect all unique directories that may contain PRESUBMIT.py.
1361 candidates = set()
1362 for directory in directories:
1363 while True:
1364 if directory in candidates:
1365 break
1366 candidates.add(directory)
1367 if directory == root:
1368 break
1369 parent_dir = os.path.dirname(directory)
1370 if parent_dir == directory:
1371 # We hit the system root directory.
1372 break
1373 directory = parent_dir
1374
1375 # Look for PRESUBMIT.py in all candidate directories.
1376 results = []
1377 for directory in sorted(list(candidates)):
1378 try:
1379 for f in os.listdir(directory):
1380 p = os.path.join(directory, f)
1381 if os.path.isfile(p) and re.match(
1382 r'PRESUBMIT.*\.py$', f) and not f.startswith('PRESUBMIT_test'):
1383 results.append(p)
1384 except OSError:
1385 pass
1386
1387 logging.debug('Presubmit files: %s', ','.join(results))
1388 return results
1389
1390
rmistry@google.com5626a922015-02-26 14:03:30 +00001391class GetPostUploadExecuter(object):
Robert Iannucci3d6d2d22023-05-11 17:25:05 +00001392 def __init__(self, change, gerrit_obj):
Josip Sokcevice293d3d2022-02-16 22:52:15 +00001393 """
1394 Args:
Pavol Marko624e7ee2023-01-09 09:56:29 +00001395 change: The Change object.
1396 gerrit_obj: provides basic Gerrit codereview functionality.
Josip Sokcevice293d3d2022-02-16 22:52:15 +00001397 """
Pavol Marko624e7ee2023-01-09 09:56:29 +00001398 self.change = change
1399 self.gerrit = gerrit_obj
Josip Sokcevice293d3d2022-02-16 22:52:15 +00001400
Pavol Marko624e7ee2023-01-09 09:56:29 +00001401 def ExecPresubmitScript(self, script_text, presubmit_path):
rmistry@google.com5626a922015-02-26 14:03:30 +00001402 """Executes PostUploadHook() from a single presubmit script.
Josip Sokcevic632bbc02022-05-19 05:32:50 +00001403 Caller is responsible for validating whether the hook should be executed
1404 and should only call this function if it should be.
rmistry@google.com5626a922015-02-26 14:03:30 +00001405
1406 Args:
1407 script_text: The text of the presubmit script.
1408 presubmit_path: Project script to run.
rmistry@google.com5626a922015-02-26 14:03:30 +00001409
1410 Return:
1411 A list of results objects.
1412 """
Pavol Marko624e7ee2023-01-09 09:56:29 +00001413 # Change to the presubmit file's directory to support local imports.
1414 presubmit_dir = os.path.dirname(presubmit_path)
1415 main_path = os.getcwd()
1416 try:
1417 os.chdir(presubmit_dir)
1418 return self._execute_with_local_working_directory(script_text,
1419 presubmit_dir,
1420 presubmit_path)
1421 finally:
1422 # Return the process to the original working directory.
1423 os.chdir(main_path)
1424
1425 def _execute_with_local_working_directory(self, script_text, presubmit_dir,
1426 presubmit_path):
rmistry@google.com5626a922015-02-26 14:03:30 +00001427 context = {}
1428 try:
Pavol Marko624e7ee2023-01-09 09:56:29 +00001429 exec(compile(script_text, presubmit_path, 'exec', dont_inherit=True),
Raul Tambre09e64b42019-05-14 01:57:22 +00001430 context)
Raul Tambre7c938462019-05-24 16:35:35 +00001431 except Exception as e:
rmistry@google.com5626a922015-02-26 14:03:30 +00001432 raise PresubmitFailure('"%s" had an exception.\n%s'
1433 % (presubmit_path, e))
1434
1435 function_name = 'PostUploadHook'
1436 if function_name not in context:
1437 return {}
1438 post_upload_hook = context[function_name]
Bruce Dawson05ebc9e2023-05-24 19:00:05 +00001439 if not len(inspect.getfullargspec(post_upload_hook)[0]) == 3:
rmistry@google.com5626a922015-02-26 14:03:30 +00001440 raise PresubmitFailure(
1441 'Expected function "PostUploadHook" to take three arguments.')
Pavol Marko624e7ee2023-01-09 09:56:29 +00001442 return post_upload_hook(self.gerrit, self.change, OutputApi(False))
rmistry@google.com5626a922015-02-26 14:03:30 +00001443
1444
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001445def _MergeMasters(masters1, masters2):
1446 """Merges two master maps. Merges also the tests of each builder."""
1447 result = {}
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001448 for (master, builders) in itertools.chain(masters1.items(),
1449 masters2.items()):
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001450 new_builders = result.setdefault(master, {})
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001451 for (builder, tests) in builders.items():
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001452 new_builders.setdefault(builder, set([])).update(tests)
1453 return result
1454
1455
Robert Iannucci3d6d2d22023-05-11 17:25:05 +00001456def DoPostUploadExecuter(change, gerrit_obj, verbose):
rmistry@google.com5626a922015-02-26 14:03:30 +00001457 """Execute the post upload hook.
1458
1459 Args:
1460 change: The Change object.
Edward Lemur016a0872020-02-04 22:13:28 +00001461 gerrit_obj: The GerritAccessor object.
rmistry@google.com5626a922015-02-26 14:03:30 +00001462 verbose: Prints debug info.
rmistry@google.com5626a922015-02-26 14:03:30 +00001463 """
Josip Sokcevice293d3d2022-02-16 22:52:15 +00001464 python_version = 'Python %s' % sys.version_info.major
1465 sys.stdout.write('Running %s post upload checks ...\n' % python_version)
Josip Sokcevica9a7eec2023-03-10 03:54:52 +00001466 presubmit_files = ListRelevantPresubmitFiles(
1467 change.LocalPaths(), change.RepositoryRoot())
rmistry@google.com5626a922015-02-26 14:03:30 +00001468 if not presubmit_files and verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001469 sys.stdout.write('Warning, no PRESUBMIT.py found.\n')
rmistry@google.com5626a922015-02-26 14:03:30 +00001470 results = []
Robert Iannucci3d6d2d22023-05-11 17:25:05 +00001471 executer = GetPostUploadExecuter(change, gerrit_obj)
rmistry@google.com5626a922015-02-26 14:03:30 +00001472 # The root presubmit file should be executed after the ones in subdirectories.
1473 # i.e. the specific post upload hooks should run before the general ones.
Josip Sokcevica9a7eec2023-03-10 03:54:52 +00001474 # Thus, reverse the order provided by ListRelevantPresubmitFiles.
rmistry@google.com5626a922015-02-26 14:03:30 +00001475 presubmit_files.reverse()
1476
1477 for filename in presubmit_files:
1478 filename = os.path.abspath(filename)
rmistry@google.com5626a922015-02-26 14:03:30 +00001479 # Accept CRLF presubmit script.
Bruce Dawson6e70e862022-07-01 19:37:01 +00001480 presubmit_script = gclient_utils.FileRead(filename).replace('\r\n', '\n')
Robert Iannucci3d6d2d22023-05-11 17:25:05 +00001481 if verbose:
1482 sys.stdout.write('Running %s\n' % filename)
1483 results.extend(executer.ExecPresubmitScript(presubmit_script, filename))
rmistry@google.com5626a922015-02-26 14:03:30 +00001484
Edward Lemur6eb1d322020-02-27 22:20:15 +00001485 if not results:
1486 return 0
1487
1488 sys.stdout.write('\n')
1489 sys.stdout.write('** Post Upload Hook Messages **\n')
1490
1491 exit_code = 0
1492 for result in results:
1493 if result.fatal:
1494 exit_code = 1
1495 result.handle()
1496 sys.stdout.write('\n')
1497
1498 return exit_code
rmistry@google.com5626a922015-02-26 14:03:30 +00001499
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001500class PresubmitExecuter(object):
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001501 def __init__(self, change, committing, verbose, gerrit_obj, dry_run=None,
Robert Iannucci3d6d2d22023-05-11 17:25:05 +00001502 thread_pool=None, parallel=False, no_diffs=False):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001503 """
1504 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001505 change: The Change object.
agable92bec4f2016-08-24 09:27:27 -07001506 committing: True if 'git cl land' is running, False if 'git cl upload' is.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001507 gerrit_obj: provides basic Gerrit codereview functionality.
1508 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -04001509 parallel: if true, all tests reported via input_api.RunTests for all
1510 PRESUBMIT files will be run in parallel.
Bruce Dawson09c0c072022-05-26 20:28:58 +00001511 no_diffs: if true, implies that --files or --all was specified so some
1512 checks can be skipped, and some errors will be messages.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001513 """
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001514 self.change = change
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001515 self.committing = committing
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001516 self.gerrit = gerrit_obj
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001517 self.verbose = verbose
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001518 self.dry_run = dry_run
Daniel Cheng7227d212017-11-17 08:12:37 -08001519 self.more_cc = []
Edward Lesmes8e282792018-04-03 18:50:29 -04001520 self.thread_pool = thread_pool
1521 self.parallel = parallel
Bruce Dawson09c0c072022-05-26 20:28:58 +00001522 self.no_diffs = no_diffs
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001523
1524 def ExecPresubmitScript(self, script_text, presubmit_path):
1525 """Executes a single presubmit script.
Josip Sokcevic632bbc02022-05-19 05:32:50 +00001526 Caller is responsible for validating whether the hook should be executed
1527 and should only call this function if it should be.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001528
1529 Args:
1530 script_text: The text of the presubmit script.
1531 presubmit_path: The path to the presubmit file (this will be reported via
1532 input_api.PresubmitLocalPath()).
1533
1534 Return:
1535 A list of result objects, empty if no problems.
1536 """
chase@chromium.org8e416c82009-10-06 04:30:44 +00001537 # Change to the presubmit file's directory to support local imports.
Saagar Sanghavi98b332f2020-07-31 17:19:15 +00001538 presubmit_dir = os.path.dirname(presubmit_path)
Pavol Marko624e7ee2023-01-09 09:56:29 +00001539 main_path = os.getcwd()
1540 try:
1541 os.chdir(presubmit_dir)
1542 return self._execute_with_local_working_directory(script_text,
1543 presubmit_dir,
1544 presubmit_path)
1545 finally:
1546 # Return the process to the original working directory.
1547 os.chdir(main_path)
chase@chromium.org8e416c82009-10-06 04:30:44 +00001548
Pavol Marko624e7ee2023-01-09 09:56:29 +00001549 def _execute_with_local_working_directory(self, script_text, presubmit_dir,
1550 presubmit_path):
chase@chromium.org8e416c82009-10-06 04:30:44 +00001551 # Load the presubmit script into context.
dpranke@chromium.org970c5222011-03-12 00:32:24 +00001552 input_api = InputApi(self.change, presubmit_path, self.committing,
Aaron Gable668c1d82018-04-03 10:19:16 -07001553 self.verbose, gerrit_obj=self.gerrit,
Edward Lesmes8e282792018-04-03 18:50:29 -04001554 dry_run=self.dry_run, thread_pool=self.thread_pool,
Bruce Dawson09c0c072022-05-26 20:28:58 +00001555 parallel=self.parallel, no_diffs=self.no_diffs)
Daniel Cheng7227d212017-11-17 08:12:37 -08001556 output_api = OutputApi(self.committing)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001557 context = {}
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001558
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001559 try:
Bruce Dawson0ba2fd42022-07-21 13:47:21 +00001560 exec(compile(script_text, presubmit_path, 'exec', dont_inherit=True),
Raul Tambre09e64b42019-05-14 01:57:22 +00001561 context)
Raul Tambre7c938462019-05-24 16:35:35 +00001562 except Exception as e:
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001563 raise PresubmitFailure('"%s" had an exception.\n%s' % (presubmit_path, e))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001564
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001565 context['__args'] = (input_api, output_api)
Ben Pastene8351dc12020-08-06 05:01:35 +00001566
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001567 # Get path of presubmit directory relative to repository root.
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001568 # Always use forward slashes, so that path is same in *nix and Windows
1569 root = input_api.change.RepositoryRoot()
1570 rel_path = os.path.relpath(presubmit_dir, root)
1571 rel_path = rel_path.replace(os.path.sep, '/')
Ben Pastene8351dc12020-08-06 05:01:35 +00001572
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001573 # Get the URL of git remote origin and use it to identify host and project
Edward Lesmeseb1bd622021-03-01 19:54:07 +00001574 host = project = ''
1575 if self.gerrit:
1576 host = self.gerrit.host or ''
1577 project = self.gerrit.project or ''
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001578
1579 # Prefix for test names
1580 prefix = 'presubmit:%s/%s:%s/' % (host, project, rel_path)
1581
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001582 # Perform all the desired presubmit checks.
1583 results = []
Ben Pastene8351dc12020-08-06 05:01:35 +00001584
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001585 try:
Scott Leecc2fe9b2020-11-19 19:38:06 +00001586 version = [
1587 int(x) for x in context.get('PRESUBMIT_VERSION', '0.0.0').split('.')
1588 ]
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001589
Scott Leecc2fe9b2020-11-19 19:38:06 +00001590 with rdb_wrapper.client(prefix) as sink:
1591 if version >= [2, 0, 0]:
Andrew Grievebdfb8f22022-02-02 21:56:47 +00001592 # Copy the keys to prevent "dictionary changed size during iteration"
1593 # exception if checks add globals to context. E.g. sometimes the
1594 # Python runtime will add __warningregistry__.
1595 for function_name in list(context.keys()):
Scott Leecc2fe9b2020-11-19 19:38:06 +00001596 if not function_name.startswith('Check'):
1597 continue
1598 if function_name.endswith('Commit') and not self.committing:
1599 continue
1600 if function_name.endswith('Upload') and self.committing:
1601 continue
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001602 logging.debug('Running %s in %s', function_name, presubmit_path)
1603 results.extend(
Bruce Dawson8fa42e22022-03-29 17:05:38 +00001604 self._run_check_function(function_name, context, sink,
1605 presubmit_path))
Scott Leecc2fe9b2020-11-19 19:38:06 +00001606 logging.debug('Running %s done.', function_name)
1607 self.more_cc.extend(output_api.more_cc)
Daniel Cheng541638f2023-05-15 22:00:47 +00001608 # Clear the CC list between running each presubmit check to prevent
1609 # CCs from being repeatedly appended.
1610 output_api.more_cc = []
Scott Leecc2fe9b2020-11-19 19:38:06 +00001611
1612 else: # Old format
1613 if self.committing:
1614 function_name = 'CheckChangeOnCommit'
1615 else:
1616 function_name = 'CheckChangeOnUpload'
Andrew Grievebdfb8f22022-02-02 21:56:47 +00001617 if function_name in list(context.keys()):
Scott Leecc2fe9b2020-11-19 19:38:06 +00001618 logging.debug('Running %s in %s', function_name, presubmit_path)
1619 results.extend(
Bruce Dawson8fa42e22022-03-29 17:05:38 +00001620 self._run_check_function(function_name, context, sink,
1621 presubmit_path))
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001622 logging.debug('Running %s done.', function_name)
1623 self.more_cc.extend(output_api.more_cc)
Daniel Cheng541638f2023-05-15 22:00:47 +00001624 # Clear the CC list between running each presubmit check to prevent
1625 # CCs from being repeatedly appended.
1626 output_api.more_cc = []
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001627
1628 finally:
1629 for f in input_api._named_temporary_files:
1630 os.remove(f)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001631
Daniel Cheng541638f2023-05-15 22:00:47 +00001632 self.more_cc = sorted(set(self.more_cc))
1633
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001634 return results
1635
Bruce Dawson8fa42e22022-03-29 17:05:38 +00001636 def _run_check_function(self, function_name, context, sink, presubmit_path):
Scott Leecc2fe9b2020-11-19 19:38:06 +00001637 """Evaluates and returns the result of a given presubmit function.
1638
1639 If sink is given, the result of the presubmit function will be reported
1640 to the ResultSink.
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001641
1642 Args:
Scott Leecc2fe9b2020-11-19 19:38:06 +00001643 function_name: the name of the presubmit function to evaluate
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001644 context: a context dictionary in which the function will be evaluated
Scott Leecc2fe9b2020-11-19 19:38:06 +00001645 sink: an instance of ResultSink. None, by default.
1646 Returns:
1647 the result of the presubmit function call.
1648 """
1649 start_time = time_time()
1650 try:
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001651 result = eval(function_name + '(*__args)', context)
1652 self._check_result_type(result)
Allen Webbfe7d7092021-05-18 02:05:49 +00001653 except Exception:
Bruce Dawson10a82862022-05-27 19:25:56 +00001654 _, e_value, _ = sys.exc_info()
1655 result = [
1656 OutputApi.PresubmitError(
1657 'Evaluation of %s failed: %s, %s' %
1658 (function_name, e_value, traceback.format_exc()))
1659 ]
Scott Leecc2fe9b2020-11-19 19:38:06 +00001660
Bruce Dawson2bdc49f2021-05-21 19:13:03 +00001661 elapsed_time = time_time() - start_time
1662 if elapsed_time > 10.0:
Bruce Dawson6757d462022-07-13 04:04:40 +00001663 sys.stdout.write('%6.1fs to run %s from %s.\n' %
1664 (elapsed_time, function_name, presubmit_path))
Scott Leecc2fe9b2020-11-19 19:38:06 +00001665 if sink:
Erik Staab9f38b632022-10-31 14:05:24 +00001666 failure_reason = None
Scott Leecc2fe9b2020-11-19 19:38:06 +00001667 status = rdb_wrapper.STATUS_PASS
1668 if any(r.fatal for r in result):
1669 status = rdb_wrapper.STATUS_FAIL
Erik Staab9f38b632022-10-31 14:05:24 +00001670 failure_reasons = []
1671 for r in result:
1672 fields = r.json_format()
1673 message = fields['message']
1674 items = '\n'.join(' %s' % item for item in fields['items'])
1675 failure_reasons.append('\n'.join([message, items]))
1676 if failure_reasons:
1677 failure_reason = '\n'.join(failure_reasons)
1678 sink.report(function_name, status, elapsed_time, failure_reason)
Scott Leecc2fe9b2020-11-19 19:38:06 +00001679
1680 return result
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001681
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00001682 def _check_result_type(self, result):
1683 """Helper function which ensures result is a list, and all elements are
1684 instances of OutputApi.PresubmitResult"""
1685 if not isinstance(result, (tuple, list)):
1686 raise PresubmitFailure('Presubmit functions must return a tuple or list')
1687 if not all(isinstance(res, OutputApi.PresubmitResult) for res in result):
1688 raise PresubmitFailure(
1689 'All presubmit results must be of types derived from '
1690 'output_api.PresubmitResult')
1691
1692
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001693def DoPresubmitChecks(change,
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001694 committing,
1695 verbose,
maruel@chromium.orgb0dfd352009-06-10 14:12:54 +00001696 default_presubmit,
dpranke@chromium.org970c5222011-03-12 00:32:24 +00001697 may_prompt,
Aaron Gable668c1d82018-04-03 10:19:16 -07001698 gerrit_obj,
Edward Lesmes8e282792018-04-03 18:50:29 -04001699 dry_run=None,
Debrian Figueroadd2737e2019-06-21 23:50:13 +00001700 parallel=False,
Dirk Pranke6f0df682021-06-25 00:42:33 +00001701 json_output=None,
Bruce Dawson09c0c072022-05-26 20:28:58 +00001702 no_diffs=False):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001703 """Runs all presubmit checks that apply to the files in the change.
1704
1705 This finds all PRESUBMIT.py files in directories enclosing the files in the
1706 change (up to the repository root) and calls the relevant entrypoint function
1707 depending on whether the change is being committed or uploaded.
1708
1709 Prints errors, warnings and notifications. Prompts the user for warnings
1710 when needed.
1711
1712 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001713 change: The Change object.
agable92bec4f2016-08-24 09:27:27 -07001714 committing: True if 'git cl land' is running, False if 'git cl upload' is.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001715 verbose: Prints debug info.
maruel@chromium.org0ff1fab2009-05-22 13:08:15 +00001716 default_presubmit: A default presubmit script to execute in any case.
Quinten Yearsley516fe7f2016-12-14 11:50:18 -08001717 may_prompt: Enable (y/n) questions on warning or error. If False,
1718 any questions are answered with yes by default.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001719 gerrit_obj: provides basic Gerrit codereview functionality.
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001720 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -04001721 parallel: if true, all tests specified by input_api.RunTests in all
1722 PRESUBMIT files will be run in parallel.
Bruce Dawson09c0c072022-05-26 20:28:58 +00001723 no_diffs: if true, implies that --files or --all was specified so some
1724 checks can be skipped, and some errors will be messages.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001725 Return:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001726 1 if presubmit checks failed or 0 otherwise.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001727 """
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001728 old_environ = os.environ
1729 try:
1730 # Make sure python subprocesses won't generate .pyc files.
1731 os.environ = os.environ.copy()
Edward Lemurb9830242019-10-30 22:19:20 +00001732 os.environ['PYTHONDONTWRITEBYTECODE'] = '1'
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001733
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001734 python_version = 'Python %s' % sys.version_info.major
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001735 if committing:
Dirk Pranke6fc394f2021-05-26 23:25:14 +00001736 sys.stdout.write('Running %s presubmit commit checks ...\n' %
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001737 python_version)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001738 else:
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001739 sys.stdout.write('Running %s presubmit upload checks ...\n' %
1740 python_version)
Edward Lemurecc27072020-01-06 16:42:34 +00001741 start_time = time_time()
Josip Sokcevica9a7eec2023-03-10 03:54:52 +00001742 presubmit_files = ListRelevantPresubmitFiles(
1743 change.AbsoluteLocalPaths(), change.RepositoryRoot())
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001744 if not presubmit_files and verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001745 sys.stdout.write('Warning, no PRESUBMIT.py found.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001746 results = []
Edward Lesmes8e282792018-04-03 18:50:29 -04001747 thread_pool = ThreadPool()
Edward Lemur7e3c67f2018-07-20 20:52:49 +00001748 executer = PresubmitExecuter(change, committing, verbose, gerrit_obj,
Robert Iannucci3d6d2d22023-05-11 17:25:05 +00001749 dry_run, thread_pool, parallel, no_diffs)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001750 if default_presubmit:
1751 if verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001752 sys.stdout.write('Running default presubmit script.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001753 fake_path = os.path.join(change.RepositoryRoot(), 'PRESUBMIT.py')
Robert Iannucci3d6d2d22023-05-11 17:25:05 +00001754 results += executer.ExecPresubmitScript(default_presubmit, fake_path)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001755 for filename in presubmit_files:
1756 filename = os.path.abspath(filename)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001757 # Accept CRLF presubmit script.
Bruce Dawson6e70e862022-07-01 19:37:01 +00001758 presubmit_script = gclient_utils.FileRead(filename).replace('\r\n', '\n')
Robert Iannucci3d6d2d22023-05-11 17:25:05 +00001759 if verbose:
1760 sys.stdout.write('Running %s\n' % filename)
1761 results += executer.ExecPresubmitScript(presubmit_script, filename)
Bruce Dawson76fe1a72022-05-25 20:52:21 +00001762
Edward Lesmes8e282792018-04-03 18:50:29 -04001763 results += thread_pool.RunAsync()
1764
Edward Lemur6eb1d322020-02-27 22:20:15 +00001765 messages = {}
1766 should_prompt = False
1767 presubmits_failed = False
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001768 for result in results:
1769 if result.fatal:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001770 presubmits_failed = True
1771 messages.setdefault('ERRORS', []).append(result)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001772 elif result.should_prompt:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001773 should_prompt = True
1774 messages.setdefault('Warnings', []).append(result)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001775 else:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001776 messages.setdefault('Messages', []).append(result)
pam@chromium.orged9a0832009-09-09 22:48:55 +00001777
Bruce Dawson76fe1a72022-05-25 20:52:21 +00001778 # Print the different message types in a consistent order. ERRORS go last
1779 # so that they will be most visible in the local-presubmit output.
1780 for name in ['Messages', 'Warnings', 'ERRORS']:
1781 if name in messages:
1782 items = messages[name]
Gavin Makd22bf602022-07-11 21:10:41 +00001783 sys.stdout.write('** Presubmit %s: %d **\n' % (name, len(items)))
Bruce Dawson76fe1a72022-05-25 20:52:21 +00001784 for item in items:
1785 item.handle()
1786 sys.stdout.write('\n')
pam@chromium.orged9a0832009-09-09 22:48:55 +00001787
Edward Lemurecc27072020-01-06 16:42:34 +00001788 total_time = time_time() - start_time
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001789 if total_time > 1.0:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001790 sys.stdout.write(
Louis Romero4ca9e1c2022-03-10 10:29:11 +00001791 'Presubmit checks took %.1fs to calculate.\n' % total_time)
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +00001792
Edward Lemur6eb1d322020-02-27 22:20:15 +00001793 if not should_prompt and not presubmits_failed:
Louis Romero4ca9e1c2022-03-10 10:29:11 +00001794 sys.stdout.write('%s presubmit checks passed.\n\n' % python_version)
Josip Sokcevic7592e0a2022-01-12 00:57:54 +00001795 elif should_prompt and not presubmits_failed:
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001796 sys.stdout.write('There were %s presubmit warnings. ' % python_version)
Quinten Yearsley516fe7f2016-12-14 11:50:18 -08001797 if may_prompt:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001798 presubmits_failed = not prompt_should_continue(
1799 'Are you sure you wish to continue? (y/N): ')
Garrett Beatyacb807e2020-08-28 18:17:24 +00001800 else:
1801 sys.stdout.write('\n')
Bruce Dawson76fe1a72022-05-25 20:52:21 +00001802 else:
1803 sys.stdout.write('There were %s presubmit errors.\n' % python_version)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001804
Edward Lemur1dc66e12020-02-21 21:36:34 +00001805 if json_output:
1806 # Write the presubmit results to json output
1807 presubmit_results = {
1808 'errors': [
Edward Lemur6eb1d322020-02-27 22:20:15 +00001809 error.json_format()
1810 for error in messages.get('ERRORS', [])
Edward Lemur1dc66e12020-02-21 21:36:34 +00001811 ],
1812 'notifications': [
Edward Lemur6eb1d322020-02-27 22:20:15 +00001813 notification.json_format()
1814 for notification in messages.get('Messages', [])
Edward Lemur1dc66e12020-02-21 21:36:34 +00001815 ],
1816 'warnings': [
Edward Lemur6eb1d322020-02-27 22:20:15 +00001817 warning.json_format()
1818 for warning in messages.get('Warnings', [])
Edward Lemur1dc66e12020-02-21 21:36:34 +00001819 ],
Edward Lemur6eb1d322020-02-27 22:20:15 +00001820 'more_cc': executer.more_cc,
Edward Lemur1dc66e12020-02-21 21:36:34 +00001821 }
1822
1823 gclient_utils.FileWrite(
1824 json_output, json.dumps(presubmit_results, sort_keys=True))
1825
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001826 global _ASKED_FOR_FEEDBACK
1827 # Ask for feedback one time out of 5.
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +00001828 if (results and random.randint(0, 4) == 0 and not _ASKED_FOR_FEEDBACK):
Edward Lemur6eb1d322020-02-27 22:20:15 +00001829 sys.stdout.write(
maruel@chromium.org1ce8e662014-01-14 15:23:00 +00001830 'Was the presubmit check useful? If not, run "git cl presubmit -v"\n'
1831 'to figure out which PRESUBMIT.py was run, then run git blame\n'
1832 'on the file to figure out who to ask for help.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001833 _ASKED_FOR_FEEDBACK = True
Edward Lemur6eb1d322020-02-27 22:20:15 +00001834
1835 return 1 if presubmits_failed else 0
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001836 finally:
1837 os.environ = old_environ
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001838
1839
Edward Lemur50984a62020-02-06 18:10:18 +00001840def _scan_sub_dirs(mask, recursive):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001841 if not recursive:
pgervais@chromium.orge57b09d2014-05-07 00:58:13 +00001842 return [x for x in glob.glob(mask) if x not in ('.svn', '.git')]
Lei Zhang9611c4c2017-04-04 01:41:56 -07001843
1844 results = []
1845 for root, dirs, files in os.walk('.'):
1846 if '.svn' in dirs:
1847 dirs.remove('.svn')
1848 if '.git' in dirs:
1849 dirs.remove('.git')
1850 for name in files:
1851 if fnmatch.fnmatch(name, mask):
1852 results.append(os.path.join(root, name))
1853 return results
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001854
1855
Edward Lemur50984a62020-02-06 18:10:18 +00001856def _parse_files(args, recursive):
tobiasjs2836bcf2016-08-16 04:08:16 -07001857 logging.debug('Searching for %s', args)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001858 files = []
1859 for arg in args:
Edward Lemur50984a62020-02-06 18:10:18 +00001860 files.extend([('M', f) for f in _scan_sub_dirs(arg, recursive)])
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001861 return files
1862
1863
Edward Lemur50984a62020-02-06 18:10:18 +00001864def _parse_change(parser, options):
1865 """Process change options.
1866
1867 Args:
1868 parser: The parser used to parse the arguments from command line.
1869 options: The arguments parsed from command line.
1870 Returns:
Josip Sokcevic7958e302023-03-01 23:02:21 +00001871 A GitChange if the change root is a git repository, or a Change otherwise.
Edward Lemur50984a62020-02-06 18:10:18 +00001872 """
1873 if options.files and options.all_files:
1874 parser.error('<files> cannot be specified when --all-files is set.')
1875
Edward Lesmes44ea3ff2020-02-05 00:14:30 +00001876 change_scm = scm.determine_scm(options.root)
Edward Lemur50984a62020-02-06 18:10:18 +00001877 if change_scm != 'git' and not options.files:
1878 parser.error('<files> is not optional for unversioned directories.')
1879
1880 if options.files:
Josip Sokcevic017544d2022-03-31 23:47:53 +00001881 if options.source_controlled_only:
1882 # Get the filtered set of files from SCM.
1883 change_files = []
1884 for name in scm.GIT.GetAllFiles(options.root):
1885 for mask in options.files:
1886 if fnmatch.fnmatch(name, mask):
1887 change_files.append(('M', name))
1888 break
1889 else:
1890 # Get the filtered set of files from a directory scan.
1891 change_files = _parse_files(options.files, options.recursive)
Edward Lemur50984a62020-02-06 18:10:18 +00001892 elif options.all_files:
1893 change_files = [('M', f) for f in scm.GIT.GetAllFiles(options.root)]
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001894 else:
Edward Lemur50984a62020-02-06 18:10:18 +00001895 change_files = scm.GIT.CaptureStatus(
Edward Lemur7f6dec02020-02-06 20:23:58 +00001896 options.root, options.upstream or None)
Edward Lemur50984a62020-02-06 18:10:18 +00001897
1898 logging.info('Found %d file(s).', len(change_files))
1899
Josip Sokcevic7958e302023-03-01 23:02:21 +00001900 change_class = GitChange if change_scm == 'git' else Change
Edward Lemur50984a62020-02-06 18:10:18 +00001901 return change_class(
1902 options.name,
1903 options.description,
1904 options.root,
1905 change_files,
1906 options.issue,
1907 options.patchset,
1908 options.author,
1909 upstream=options.upstream)
1910
1911
1912def _parse_gerrit_options(parser, options):
1913 """Process gerrit options.
1914
1915 SIDE EFFECTS: Modifies options.author and options.description from Gerrit if
1916 options.gerrit_fetch is set.
1917
1918 Args:
1919 parser: The parser used to parse the arguments from command line.
1920 options: The arguments parsed from command line.
1921 Returns:
Stephen Martinisfb09de22021-02-25 03:41:13 +00001922 A GerritAccessor object if options.gerrit_url is set, or None otherwise.
Edward Lemur50984a62020-02-06 18:10:18 +00001923 """
1924 gerrit_obj = None
Stephen Martinisfb09de22021-02-25 03:41:13 +00001925 if options.gerrit_url:
Edward Lesmeseb1bd622021-03-01 19:54:07 +00001926 gerrit_obj = GerritAccessor(
1927 url=options.gerrit_url,
1928 project=options.gerrit_project,
1929 branch=options.gerrit_branch)
Edward Lemur50984a62020-02-06 18:10:18 +00001930
1931 if not options.gerrit_fetch:
1932 return gerrit_obj
1933
1934 if not options.gerrit_url or not options.issue or not options.patchset:
1935 parser.error(
1936 '--gerrit_fetch requires --gerrit_url, --issue and --patchset.')
1937
1938 options.author = gerrit_obj.GetChangeOwner(options.issue)
1939 options.description = gerrit_obj.GetChangeDescription(
1940 options.issue, options.patchset)
1941
1942 logging.info('Got author: "%s"', options.author)
1943 logging.info('Got description: """\n%s\n"""', options.description)
1944
1945 return gerrit_obj
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001946
1947
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001948@contextlib.contextmanager
1949def canned_check_filter(method_names):
1950 filtered = {}
1951 try:
1952 for method_name in method_names:
1953 if not hasattr(presubmit_canned_checks, method_name):
Gavin Make6a62332020-12-04 21:57:10 +00001954 logging.warning('Skipping unknown "canned" check %s' % method_name)
Aaron Gableecee74c2018-04-02 15:13:08 -07001955 continue
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001956 filtered[method_name] = getattr(presubmit_canned_checks, method_name)
1957 setattr(presubmit_canned_checks, method_name, lambda *_a, **_kw: [])
1958 yield
1959 finally:
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001960 for name, method in filtered.items():
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001961 setattr(presubmit_canned_checks, name, method)
1962
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +00001963
sbc@chromium.org013731e2015-02-26 18:28:43 +00001964def main(argv=None):
Edward Lemura5799e32020-01-17 19:26:51 +00001965 parser = argparse.ArgumentParser(usage='%(prog)s [options] <files...>')
1966 hooks = parser.add_mutually_exclusive_group()
1967 hooks.add_argument('-c', '--commit', action='store_true',
1968 help='Use commit instead of upload checks.')
1969 hooks.add_argument('-u', '--upload', action='store_false', dest='commit',
1970 help='Use upload instead of commit checks.')
Edward Lemur75526302020-02-27 22:31:05 +00001971 hooks.add_argument('--post_upload', action='store_true',
1972 help='Run post-upload commit hooks.')
Edward Lemura5799e32020-01-17 19:26:51 +00001973 parser.add_argument('-r', '--recursive', action='store_true',
1974 help='Act recursively.')
1975 parser.add_argument('-v', '--verbose', action='count', default=0,
1976 help='Use 2 times for more debug info.')
1977 parser.add_argument('--name', default='no name')
1978 parser.add_argument('--author')
Edward Lemur227d5102020-02-25 23:45:35 +00001979 desc = parser.add_mutually_exclusive_group()
1980 desc.add_argument('--description', default='', help='The change description.')
1981 desc.add_argument('--description_file',
1982 help='File to read change description from.')
Edward Lemura5799e32020-01-17 19:26:51 +00001983 parser.add_argument('--issue', type=int, default=0)
1984 parser.add_argument('--patchset', type=int, default=0)
1985 parser.add_argument('--root', default=os.getcwd(),
1986 help='Search for PRESUBMIT.py up to this directory. '
1987 'If inherit-review-settings-ok is present in this '
1988 'directory, parent directories up to the root file '
1989 'system directories will also be searched.')
1990 parser.add_argument('--upstream',
1991 help='Git only: the base ref or upstream branch against '
1992 'which the diff should be computed.')
1993 parser.add_argument('--default_presubmit')
1994 parser.add_argument('--may_prompt', action='store_true', default=False)
1995 parser.add_argument('--skip_canned', action='append', default=[],
1996 help='A list of checks to skip which appear in '
1997 'presubmit_canned_checks. Can be provided multiple times '
1998 'to skip multiple canned checks.')
1999 parser.add_argument('--dry_run', action='store_true', help=argparse.SUPPRESS)
2000 parser.add_argument('--gerrit_url', help=argparse.SUPPRESS)
Edward Lesmeseb1bd622021-03-01 19:54:07 +00002001 parser.add_argument('--gerrit_project', help=argparse.SUPPRESS)
2002 parser.add_argument('--gerrit_branch', help=argparse.SUPPRESS)
Edward Lemura5799e32020-01-17 19:26:51 +00002003 parser.add_argument('--gerrit_fetch', action='store_true',
2004 help=argparse.SUPPRESS)
2005 parser.add_argument('--parallel', action='store_true',
2006 help='Run all tests specified by input_api.RunTests in '
2007 'all PRESUBMIT files in parallel.')
2008 parser.add_argument('--json_output',
2009 help='Write presubmit errors to json output.')
Edward Lemur1dc66e12020-02-21 21:36:34 +00002010 parser.add_argument('--all_files', action='store_true',
Edward Lemur50984a62020-02-06 18:10:18 +00002011 help='Mark all files under source control as modified.')
Bruce Dawson09c0c072022-05-26 20:28:58 +00002012
Edward Lemura5799e32020-01-17 19:26:51 +00002013 parser.add_argument('files', nargs='*',
2014 help='List of files to be marked as modified when '
2015 'executing presubmit or post-upload hooks. fnmatch '
2016 'wildcards can also be used.')
Josip Sokcevic017544d2022-03-31 23:47:53 +00002017 parser.add_argument('--source_controlled_only', action='store_true',
2018 help='Constrain \'files\' to those in source control.')
Bruce Dawson09c0c072022-05-26 20:28:58 +00002019 parser.add_argument('--no_diffs', action='store_true',
2020 help='Assume that all "modified" files have no diffs.')
Edward Lemura5799e32020-01-17 19:26:51 +00002021 options = parser.parse_args(argv)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00002022
Erik Staabcca5c492020-04-16 17:40:07 +00002023 log_level = logging.ERROR
maruel@chromium.org899e1c12011-04-07 17:03:18 +00002024 if options.verbose >= 2:
Erik Staabcca5c492020-04-16 17:40:07 +00002025 log_level = logging.DEBUG
maruel@chromium.org899e1c12011-04-07 17:03:18 +00002026 elif options.verbose:
Erik Staabcca5c492020-04-16 17:40:07 +00002027 log_level = logging.INFO
2028 log_format = ('[%(levelname).1s%(asctime)s %(process)d %(thread)d '
2029 '%(filename)s] %(message)s')
2030 logging.basicConfig(format=log_format, level=log_level)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00002031
Bruce Dawsondca14bc2022-09-15 20:59:38 +00002032 # Print call stacks when _PresubmitResult objects are created with -v -v is
2033 # specified. This helps track down where presubmit messages are coming from.
2034 if options.verbose >= 2:
2035 global _SHOW_CALLSTACKS
2036 _SHOW_CALLSTACKS = True
2037
Edward Lemur227d5102020-02-25 23:45:35 +00002038 if options.description_file:
2039 options.description = gclient_utils.FileRead(options.description_file)
Edward Lemur50984a62020-02-06 18:10:18 +00002040 gerrit_obj = _parse_gerrit_options(parser, options)
2041 change = _parse_change(parser, options)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00002042
maruel@chromium.org899e1c12011-04-07 17:03:18 +00002043 try:
Edward Lemur75526302020-02-27 22:31:05 +00002044 if options.post_upload:
Robert Iannucci3d6d2d22023-05-11 17:25:05 +00002045 return DoPostUploadExecuter(change, gerrit_obj, options.verbose)
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00002046 with canned_check_filter(options.skip_canned):
Edward Lemur6eb1d322020-02-27 22:20:15 +00002047 return DoPresubmitChecks(
Edward Lemur50984a62020-02-06 18:10:18 +00002048 change,
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00002049 options.commit,
2050 options.verbose,
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00002051 options.default_presubmit,
2052 options.may_prompt,
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00002053 gerrit_obj,
Edward Lesmes8e282792018-04-03 18:50:29 -04002054 options.dry_run,
Debrian Figueroadd2737e2019-06-21 23:50:13 +00002055 options.parallel,
Dirk Pranke6f0df682021-06-25 00:42:33 +00002056 options.json_output,
Bruce Dawson09c0c072022-05-26 20:28:58 +00002057 options.no_diffs)
Raul Tambre7c938462019-05-24 16:35:35 +00002058 except PresubmitFailure as e:
Josip Sokcevica9a7eec2023-03-10 03:54:52 +00002059 import utils
Raul Tambre80ee78e2019-05-06 22:41:05 +00002060 print(e, file=sys.stderr)
2061 print('Maybe your depot_tools is out of date?', file=sys.stderr)
Josip Sokcevic0399e172022-03-21 23:11:51 +00002062 print('depot_tools version: %s' % utils.depot_tools_version(),
2063 file=sys.stderr)
maruel@chromium.org899e1c12011-04-07 17:03:18 +00002064 return 2
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00002065
2066
2067if __name__ == '__main__':
maruel@chromium.org35625c72011-03-23 17:34:02 +00002068 fix_encoding.fix_encoding()
sbc@chromium.org013731e2015-02-26 18:28:43 +00002069 try:
2070 sys.exit(main())
2071 except KeyboardInterrupt:
2072 sys.stderr.write('interrupted\n')
sergiybf8a3b382016-07-05 11:21:30 -07002073 sys.exit(2)