blob: fe6e819aabf4e055e716de23f087e3e7c4327c0b [file] [log] [blame]
Josip Sokcevic4de5dea2022-03-23 21:15:14 +00001#!/usr/bin/env python3
maruel@chromium.org3bbf2942012-01-10 16:52:06 +00002# Copyright (c) 2012 The Chromium Authors. All rights reserved.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00003# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5
6"""Enables directory-specific presubmit checks to run at upload and/or commit.
7"""
8
Raul Tambre80ee78e2019-05-06 22:41:05 +00009from __future__ import print_function
10
Saagar Sanghavi99816902020-08-11 22:41:25 +000011__version__ = '2.0.0'
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000012
13# TODO(joi) Add caching where appropriate/needed. The API is designed to allow
14# caching (between all different invocations of presubmit scripts for a given
15# change). We should add it as our presubmit scripts start feeling slow.
16
Edward Lemura5799e32020-01-17 19:26:51 +000017import argparse
Takeshi Yoshino07a6bea2017-08-02 02:44:06 +090018import ast # Exposed through the API.
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +000019import contextlib
Yoshisato Yanagisawa406de132018-06-29 05:43:25 +000020import cpplint
dcheng091b7db2016-06-16 01:27:51 -070021import fnmatch # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000022import glob
asvitkine@chromium.org15169952011-09-27 14:30:53 +000023import inspect
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +000024import itertools
maruel@chromium.org4f6852c2012-04-20 20:39:20 +000025import json # Exposed through the API.
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +000026import logging
ilevy@chromium.orgbc117312013-04-20 03:57:56 +000027import multiprocessing
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000028import os # Somewhat exposed through the API.
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +000029import random
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000030import re # Exposed through the API.
Edward Lesmes8e282792018-04-03 18:50:29 -040031import signal
Allen Webbfe7d7092021-05-18 02:05:49 +000032import six
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000033import sys # Parts exposed through API.
34import tempfile # Exposed through the API.
Edward Lesmes8e282792018-04-03 18:50:29 -040035import threading
jam@chromium.org2a891dc2009-08-20 20:33:37 +000036import time
Edward Lemurde9e3ca2019-10-24 21:13:31 +000037import traceback
maruel@chromium.org1487d532009-06-06 00:22:57 +000038import unittest # Exposed through the API.
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +000039from warnings import warn
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000040
41# Local imports.
maruel@chromium.org35625c72011-03-23 17:34:02 +000042import fix_encoding
Yoshisato Yanagisawa04600b42019-03-15 03:03:41 +000043import gclient_paths # Exposed through the API
44import gclient_utils
Josip Sokcevic7958e302023-03-01 23:02:21 +000045import git_footers
tandrii@chromium.org015ebae2016-04-25 19:37:22 +000046import gerrit_util
Edward Lesmes9ce03f82021-01-12 20:13:31 +000047import owners_client
Jochen Eisinger76f5fc62017-04-07 16:27:46 +020048import owners_finder
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000049import presubmit_canned_checks
Saagar Sanghavi9949ab72020-07-20 20:56:40 +000050import rdb_wrapper
Josip Sokcevic7958e302023-03-01 23:02:21 +000051import scm
maruel@chromium.org84f4fe32011-04-06 13:26:45 +000052import subprocess2 as subprocess # Exposed through the API.
Josip Sokcevic512fd3b2023-03-01 21:06:41 +000053from lib import utils
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000054
Edward Lemur16af3562019-10-17 22:11:33 +000055if sys.version_info.major == 2:
56 # TODO(1009814): Expose urllib2 only through urllib_request and urllib_error
57 import urllib2 # Exposed through the API.
58 import urlparse
59 import urllib2 as urllib_request
60 import urllib2 as urllib_error
61else:
62 import urllib.parse as urlparse
63 import urllib.request as urllib_request
64 import urllib.error as urllib_error
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000065
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +000066# Ask for feedback only once in program lifetime.
67_ASKED_FOR_FEEDBACK = False
68
Bruce Dawsondca14bc2022-09-15 20:59:38 +000069# Set if super-verbose mode is requested, for tracking where presubmit messages
70# are coming from.
71_SHOW_CALLSTACKS = False
72
Josip Sokcevic512fd3b2023-03-01 21:06:41 +000073_PRESUBMIT_FILE_REGEX = r'PRESUBMIT.*\.py$'
74_PRESUBMIT_FILE_EXCLUDE = r'PRESUBMIT_test'
75
Bruce Dawsondca14bc2022-09-15 20:59:38 +000076
Edward Lemurecc27072020-01-06 16:42:34 +000077def time_time():
78 # Use this so that it can be mocked in tests without interfering with python
79 # system machinery.
80 return time.time()
81
82
maruel@chromium.org899e1c12011-04-07 17:03:18 +000083class PresubmitFailure(Exception):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000084 pass
85
86
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000087class CommandData(object):
Edward Lemur940c2822019-08-23 00:34:25 +000088 def __init__(self, name, cmd, kwargs, message, python3=False):
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000089 self.name = name
90 self.cmd = cmd
Edward Lesmes8e282792018-04-03 18:50:29 -040091 self.stdin = kwargs.get('stdin', None)
Edward Lemur2d6b67c2019-08-23 22:25:41 +000092 self.kwargs = kwargs.copy()
Edward Lesmes8e282792018-04-03 18:50:29 -040093 self.kwargs['stdout'] = subprocess.PIPE
94 self.kwargs['stderr'] = subprocess.STDOUT
95 self.kwargs['stdin'] = subprocess.PIPE
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000096 self.message = message
97 self.info = None
Edward Lemur940c2822019-08-23 00:34:25 +000098 self.python3 = python3
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000099
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000100
Edward Lesmes8e282792018-04-03 18:50:29 -0400101# Adapted from
102# https://github.com/google/gtest-parallel/blob/master/gtest_parallel.py#L37
103#
104# An object that catches SIGINT sent to the Python process and notices
105# if processes passed to wait() die by SIGINT (we need to look for
106# both of those cases, because pressing Ctrl+C can result in either
107# the main process or one of the subprocesses getting the signal).
108#
109# Before a SIGINT is seen, wait(p) will simply call p.wait() and
110# return the result. Once a SIGINT has been seen (in the main process
111# or a subprocess, including the one the current call is waiting for),
Edward Lemur9a5bb612019-09-26 02:01:52 +0000112# wait(p) will call p.terminate().
Edward Lesmes8e282792018-04-03 18:50:29 -0400113class SigintHandler(object):
Edward Lesmes8e282792018-04-03 18:50:29 -0400114 sigint_returncodes = {-signal.SIGINT, # Unix
115 -1073741510, # Windows
116 }
117 def __init__(self):
118 self.__lock = threading.Lock()
119 self.__processes = set()
120 self.__got_sigint = False
Edward Lemur9a5bb612019-09-26 02:01:52 +0000121 self.__previous_signal = signal.signal(signal.SIGINT, self.interrupt)
Edward Lesmes8e282792018-04-03 18:50:29 -0400122
123 def __on_sigint(self):
124 self.__got_sigint = True
125 while self.__processes:
126 try:
127 self.__processes.pop().terminate()
128 except OSError:
129 pass
130
Edward Lemur9a5bb612019-09-26 02:01:52 +0000131 def interrupt(self, signal_num, frame):
Edward Lesmes8e282792018-04-03 18:50:29 -0400132 with self.__lock:
133 self.__on_sigint()
Edward Lemur9a5bb612019-09-26 02:01:52 +0000134 self.__previous_signal(signal_num, frame)
Edward Lesmes8e282792018-04-03 18:50:29 -0400135
136 def got_sigint(self):
137 with self.__lock:
138 return self.__got_sigint
139
140 def wait(self, p, stdin):
141 with self.__lock:
142 if self.__got_sigint:
143 p.terminate()
144 self.__processes.add(p)
145 stdout, stderr = p.communicate(stdin)
146 code = p.returncode
147 with self.__lock:
148 self.__processes.discard(p)
149 if code in self.sigint_returncodes:
150 self.__on_sigint()
Edward Lesmes8e282792018-04-03 18:50:29 -0400151 return stdout, stderr
152
153sigint_handler = SigintHandler()
154
155
Edward Lemurecc27072020-01-06 16:42:34 +0000156class Timer(object):
157 def __init__(self, timeout, fn):
158 self.completed = False
159 self._fn = fn
160 self._timer = threading.Timer(timeout, self._onTimer) if timeout else None
161
162 def __enter__(self):
163 if self._timer:
164 self._timer.start()
165 return self
166
167 def __exit__(self, _type, _value, _traceback):
168 if self._timer:
169 self._timer.cancel()
170
171 def _onTimer(self):
172 self._fn()
173 self.completed = True
174
175
Edward Lesmes8e282792018-04-03 18:50:29 -0400176class ThreadPool(object):
Edward Lemurecc27072020-01-06 16:42:34 +0000177 def __init__(self, pool_size=None, timeout=None):
178 self.timeout = timeout
Edward Lesmes8e282792018-04-03 18:50:29 -0400179 self._pool_size = pool_size or multiprocessing.cpu_count()
Bruce Dawson8254f062022-06-17 17:33:08 +0000180 if sys.platform == 'win32':
181 # TODO(crbug.com/1190269) - we can't use more than 56 child processes on
182 # Windows or Python3 may hang.
183 self._pool_size = min(self._pool_size, 56)
Edward Lesmes8e282792018-04-03 18:50:29 -0400184 self._messages = []
185 self._messages_lock = threading.Lock()
186 self._tests = []
187 self._tests_lock = threading.Lock()
188 self._nonparallel_tests = []
189
Edward Lemurecc27072020-01-06 16:42:34 +0000190 def _GetCommand(self, test):
Edward Lemur940c2822019-08-23 00:34:25 +0000191 vpython = 'vpython'
192 if test.python3:
193 vpython += '3'
194 if sys.platform == 'win32':
195 vpython += '.bat'
Edward Lesmes8e282792018-04-03 18:50:29 -0400196
197 cmd = test.cmd
198 if cmd[0] == 'python':
199 cmd = list(cmd)
200 cmd[0] = vpython
201 elif cmd[0].endswith('.py'):
202 cmd = [vpython] + cmd
203
Edward Lemur336e51f2019-11-14 21:42:04 +0000204 # On Windows, scripts on the current directory take precedence over PATH, so
205 # that when testing depot_tools on Windows, calling `vpython.bat` will
206 # execute the copy of vpython of the depot_tools under test instead of the
207 # one in the bot.
208 # As a workaround, we run the tests from the parent directory instead.
209 if (cmd[0] == vpython and
210 'cwd' in test.kwargs and
211 os.path.basename(test.kwargs['cwd']) == 'depot_tools'):
212 test.kwargs['cwd'] = os.path.dirname(test.kwargs['cwd'])
213 cmd[1] = os.path.join('depot_tools', cmd[1])
214
Edward Lemurecc27072020-01-06 16:42:34 +0000215 return cmd
216
217 def _RunWithTimeout(self, cmd, stdin, kwargs):
218 p = subprocess.Popen(cmd, **kwargs)
219 with Timer(self.timeout, p.terminate) as timer:
220 stdout, _ = sigint_handler.wait(p, stdin)
Josip Sokcevic6635baf2021-11-19 02:04:39 +0000221 stdout = stdout.decode('utf-8', 'ignore')
Edward Lemurecc27072020-01-06 16:42:34 +0000222 if timer.completed:
223 stdout = 'Process timed out after %ss\n%s' % (self.timeout, stdout)
Josip Sokcevic6635baf2021-11-19 02:04:39 +0000224 return p.returncode, stdout
Edward Lemurecc27072020-01-06 16:42:34 +0000225
226 def CallCommand(self, test):
227 """Runs an external program.
228
Edward Lemura5799e32020-01-17 19:26:51 +0000229 This function converts invocation of .py files and invocations of 'python'
Edward Lemurecc27072020-01-06 16:42:34 +0000230 to vpython invocations.
231 """
232 cmd = self._GetCommand(test)
Edward Lesmes8e282792018-04-03 18:50:29 -0400233 try:
Edward Lemurecc27072020-01-06 16:42:34 +0000234 start = time_time()
235 returncode, stdout = self._RunWithTimeout(cmd, test.stdin, test.kwargs)
236 duration = time_time() - start
Edward Lemur7cf94382019-11-15 22:36:41 +0000237 except Exception:
Edward Lemurecc27072020-01-06 16:42:34 +0000238 duration = time_time() - start
Edward Lesmes8e282792018-04-03 18:50:29 -0400239 return test.message(
Edward Lemur7cf94382019-11-15 22:36:41 +0000240 '%s\n%s exec failure (%4.2fs)\n%s' % (
241 test.name, ' '.join(cmd), duration, traceback.format_exc()))
Edward Lemurde9e3ca2019-10-24 21:13:31 +0000242
Edward Lemurecc27072020-01-06 16:42:34 +0000243 if returncode != 0:
Edward Lesmes8e282792018-04-03 18:50:29 -0400244 return test.message(
Edward Lemur7cf94382019-11-15 22:36:41 +0000245 '%s\n%s (%4.2fs) failed\n%s' % (
246 test.name, ' '.join(cmd), duration, stdout))
Edward Lemurecc27072020-01-06 16:42:34 +0000247
Edward Lesmes8e282792018-04-03 18:50:29 -0400248 if test.info:
Edward Lemur7cf94382019-11-15 22:36:41 +0000249 return test.info('%s\n%s (%4.2fs)' % (test.name, ' '.join(cmd), duration))
Edward Lesmes8e282792018-04-03 18:50:29 -0400250
251 def AddTests(self, tests, parallel=True):
252 if parallel:
253 self._tests.extend(tests)
254 else:
255 self._nonparallel_tests.extend(tests)
256
257 def RunAsync(self):
258 self._messages = []
259
260 def _WorkerFn():
261 while True:
262 test = None
263 with self._tests_lock:
264 if not self._tests:
265 break
266 test = self._tests.pop()
267 result = self.CallCommand(test)
268 if result:
269 with self._messages_lock:
270 self._messages.append(result)
271
272 def _StartDaemon():
273 t = threading.Thread(target=_WorkerFn)
274 t.daemon = True
275 t.start()
276 return t
277
278 while self._nonparallel_tests:
279 test = self._nonparallel_tests.pop()
280 result = self.CallCommand(test)
281 if result:
282 self._messages.append(result)
283
284 if self._tests:
285 threads = [_StartDaemon() for _ in range(self._pool_size)]
286 for worker in threads:
287 worker.join()
288
289 return self._messages
290
291
Josip Sokcevic7958e302023-03-01 23:02:21 +0000292def _RightHandSideLinesImpl(affected_files):
293 """Implements RightHandSideLines for InputApi and GclChange."""
294 for af in affected_files:
295 lines = af.ChangedContents()
296 for line in lines:
297 yield (af, line[0], line[1])
298
299
Edward Lemur6eb1d322020-02-27 22:20:15 +0000300def prompt_should_continue(prompt_string):
301 sys.stdout.write(prompt_string)
Dirk Pranke7288f882021-06-03 18:01:30 +0000302 sys.stdout.flush()
Edward Lemur6eb1d322020-02-27 22:20:15 +0000303 response = sys.stdin.readline().strip().lower()
304 return response in ('y', 'yes')
dpranke@chromium.org5ac21012011-03-16 02:58:25 +0000305
Josip Sokcevic48d8e902023-03-09 02:38:26 +0000306
307def _ShouldRunPresubmit(script_text, use_python3):
308 """Try to figure out whether these presubmit checks should be run under
309 python2 or python3. We need to do this without actually trying to
310 compile the text, since the text might compile in one but not the
311 other.
312
313 Args:
314 script_text: The text of the presubmit script.
315 use_python3: if true, will use python3 instead of python2 by default
316 if USE_PYTHON3 is not specified.
317
318 Return:
319 A boolean if presubmit should be executed
320 """
321 if os.getenv('LUCI_OMIT_PYTHON2') == 'true':
322 # If LUCI omits python2, run all presubmits with python3, regardless of
323 # USE_PYTHON3 variable.
324 return True
325
326 m = re.search('^USE_PYTHON3 = (True|False)$', script_text, flags=re.MULTILINE)
327 if m:
328 use_python3 = m.group(1) == 'True'
329
330 return ((sys.version_info.major == 2) and not use_python3) or \
331 ((sys.version_info.major == 3) and use_python3)
332
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000333# Top level object so multiprocessing can pickle
334# Public access through OutputApi object.
335class _PresubmitResult(object):
336 """Base class for result objects."""
337 fatal = False
338 should_prompt = False
339
340 def __init__(self, message, items=None, long_text=''):
341 """
342 message: A short one-line message to indicate errors.
343 items: A list of short strings to indicate where errors occurred.
344 long_text: multi-line text output, e.g. from another tool
345 """
Bruce Dawsondb8622b2022-04-03 15:38:12 +0000346 self._message = _PresubmitResult._ensure_str(message)
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000347 self._items = items or []
Tom McKee61c72652021-07-20 11:56:32 +0000348 self._long_text = _PresubmitResult._ensure_str(long_text.rstrip())
Bruce Dawsondca14bc2022-09-15 20:59:38 +0000349 if _SHOW_CALLSTACKS:
350 self._long_text += 'Presubmit result call stack is:\n'
351 self._long_text += ''.join(traceback.format_stack(None, 8))
Tom McKee61c72652021-07-20 11:56:32 +0000352
353 @staticmethod
354 def _ensure_str(val):
355 """
356 val: A "stringish" value. Can be any of str, unicode or bytes.
357 returns: A str after applying encoding/decoding as needed.
358 Assumes/uses UTF-8 for relevant inputs/outputs.
359
360 We'd prefer to use six.ensure_str but our copy of six is old :(
361 """
362 if isinstance(val, str):
363 return val
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +0000364
Tom McKee61c72652021-07-20 11:56:32 +0000365 if six.PY2 and isinstance(val, unicode):
366 return val.encode()
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +0000367
368 if six.PY3 and isinstance(val, bytes):
Tom McKee61c72652021-07-20 11:56:32 +0000369 return val.decode()
370 raise ValueError("Unknown string type %s" % type(val))
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000371
Edward Lemur6eb1d322020-02-27 22:20:15 +0000372 def handle(self):
373 sys.stdout.write(self._message)
374 sys.stdout.write('\n')
Takuto Ikutabaa7be02022-08-23 00:19:34 +0000375 for item in self._items:
Edward Lemur6eb1d322020-02-27 22:20:15 +0000376 sys.stdout.write(' ')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000377 # Write separately in case it's unicode.
Edward Lemur6eb1d322020-02-27 22:20:15 +0000378 sys.stdout.write(str(item))
Edward Lemur6eb1d322020-02-27 22:20:15 +0000379 sys.stdout.write('\n')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000380 if self._long_text:
Edward Lemur6eb1d322020-02-27 22:20:15 +0000381 sys.stdout.write('\n***************\n')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000382 # Write separately in case it's unicode.
Tom McKee61c72652021-07-20 11:56:32 +0000383 sys.stdout.write(self._long_text)
Edward Lemur6eb1d322020-02-27 22:20:15 +0000384 sys.stdout.write('\n***************\n')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000385
Debrian Figueroadd2737e2019-06-21 23:50:13 +0000386 def json_format(self):
387 return {
388 'message': self._message,
Debrian Figueroa6095d402019-06-28 18:47:18 +0000389 'items': [str(item) for item in self._items],
Debrian Figueroadd2737e2019-06-21 23:50:13 +0000390 'long_text': self._long_text,
391 'fatal': self.fatal
392 }
393
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000394
395# Top level object so multiprocessing can pickle
396# Public access through OutputApi object.
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000397class _PresubmitError(_PresubmitResult):
398 """A hard presubmit error."""
399 fatal = True
400
401
402# Top level object so multiprocessing can pickle
403# Public access through OutputApi object.
404class _PresubmitPromptWarning(_PresubmitResult):
405 """An warning that prompts the user if they want to continue."""
406 should_prompt = True
407
408
409# Top level object so multiprocessing can pickle
410# Public access through OutputApi object.
411class _PresubmitNotifyResult(_PresubmitResult):
412 """Just print something to the screen -- but it's not even a warning."""
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000413
414
415# Top level object so multiprocessing can pickle
416# Public access through OutputApi object.
417class _MailTextResult(_PresubmitResult):
418 """A warning that should be included in the review request email."""
419 def __init__(self, *args, **kwargs):
420 super(_MailTextResult, self).__init__()
421 raise NotImplementedError()
422
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000423class GerritAccessor(object):
424 """Limited Gerrit functionality for canned presubmit checks to work.
425
426 To avoid excessive Gerrit calls, caches the results.
427 """
428
Edward Lesmeseb1bd622021-03-01 19:54:07 +0000429 def __init__(self, url=None, project=None, branch=None):
430 self.host = urlparse.urlparse(url).netloc if url else None
431 self.project = project
432 self.branch = branch
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000433 self.cache = {}
Edward Lesmes8170c292021-03-19 20:04:43 +0000434 self.code_owners_enabled = None
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000435
436 def _FetchChangeDetail(self, issue):
437 # Separate function to be easily mocked in tests.
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +0100438 try:
439 return gerrit_util.GetChangeDetail(
440 self.host, str(issue),
Aaron Gable6f5a8d92017-04-18 14:49:05 -0700441 ['ALL_REVISIONS', 'DETAILED_LABELS', 'ALL_COMMITS'])
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +0100442 except gerrit_util.GerritError as e:
443 if e.http_status == 404:
444 raise Exception('Either Gerrit issue %s doesn\'t exist, or '
445 'no credentials to fetch issue details' % issue)
446 raise
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000447
448 def GetChangeInfo(self, issue):
449 """Returns labels and all revisions (patchsets) for this issue.
450
451 The result is a dictionary according to Gerrit REST Api.
452 https://gerrit-review.googlesource.com/Documentation/rest-api.html
453
454 However, API isn't very clear what's inside, so see tests for example.
455 """
456 assert issue
457 cache_key = int(issue)
458 if cache_key not in self.cache:
459 self.cache[cache_key] = self._FetchChangeDetail(issue)
460 return self.cache[cache_key]
461
462 def GetChangeDescription(self, issue, patchset=None):
463 """If patchset is none, fetches current patchset."""
464 info = self.GetChangeInfo(issue)
465 # info is a reference to cache. We'll modify it here adding description to
466 # it to the right patchset, if it is not yet there.
467
468 # Find revision info for the patchset we want.
469 if patchset is not None:
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +0000470 for rev, rev_info in info['revisions'].items():
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000471 if str(rev_info['_number']) == str(patchset):
472 break
473 else:
474 raise Exception('patchset %s doesn\'t exist in issue %s' % (
475 patchset, issue))
476 else:
477 rev = info['current_revision']
478 rev_info = info['revisions'][rev]
479
Andrii Shyshkalov9c3a4642017-01-24 17:41:22 +0100480 return rev_info['commit']['message']
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000481
Mun Yong Jang603d01e2017-12-19 16:38:30 -0800482 def GetDestRef(self, issue):
483 ref = self.GetChangeInfo(issue)['branch']
484 if not ref.startswith('refs/'):
485 # NOTE: it is possible to create 'refs/x' branch,
486 # aka 'refs/heads/refs/x'. However, this is ill-advised.
487 ref = 'refs/heads/%s' % ref
488 return ref
489
Edward Lesmes02d4b822020-11-11 00:37:35 +0000490 def _GetApproversForLabel(self, issue, label):
491 change_info = self.GetChangeInfo(issue)
492 label_info = change_info.get('labels', {}).get(label, {})
493 values = label_info.get('values', {}).keys()
494 if not values:
495 return []
496 max_value = max(int(v) for v in values)
497 return [v for v in label_info.get('all', [])
498 if v.get('value', 0) == max_value]
499
Edward Lesmesc4566172021-03-19 16:55:13 +0000500 def IsBotCommitApproved(self, issue):
501 return bool(self._GetApproversForLabel(issue, 'Bot-Commit'))
502
Edward Lesmescf49cb82020-11-11 01:08:36 +0000503 def IsOwnersOverrideApproved(self, issue):
504 return bool(self._GetApproversForLabel(issue, 'Owners-Override'))
505
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000506 def GetChangeOwner(self, issue):
507 return self.GetChangeInfo(issue)['owner']['email']
508
509 def GetChangeReviewers(self, issue, approving_only=True):
Aaron Gable8b478f02017-07-31 15:33:19 -0700510 changeinfo = self.GetChangeInfo(issue)
511 if approving_only:
Edward Lesmes02d4b822020-11-11 00:37:35 +0000512 reviewers = self._GetApproversForLabel(issue, 'Code-Review')
Aaron Gable8b478f02017-07-31 15:33:19 -0700513 else:
514 reviewers = changeinfo.get('reviewers', {}).get('REVIEWER', [])
515 return [r.get('email') for r in reviewers]
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000516
Edward Lemure4d329c2020-02-03 20:41:18 +0000517 def UpdateDescription(self, description, issue):
518 gerrit_util.SetCommitMessage(self.host, issue, description, notify='NONE')
519
Edward Lesmes8170c292021-03-19 20:04:43 +0000520 def IsCodeOwnersEnabledOnRepo(self):
521 if self.code_owners_enabled is None:
522 self.code_owners_enabled = gerrit_util.IsCodeOwnersEnabledOnRepo(
Edward Lesmes392c4072021-03-19 21:58:45 +0000523 self.host, self.project)
Edward Lesmes8170c292021-03-19 20:04:43 +0000524 return self.code_owners_enabled
525
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000526
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000527class OutputApi(object):
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000528 """An instance of OutputApi gets passed to presubmit scripts so that they
529 can output various types of results.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000530 """
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000531 PresubmitResult = _PresubmitResult
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000532 PresubmitError = _PresubmitError
533 PresubmitPromptWarning = _PresubmitPromptWarning
534 PresubmitNotifyResult = _PresubmitNotifyResult
535 MailTextResult = _MailTextResult
536
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000537 def __init__(self, is_committing):
538 self.is_committing = is_committing
Daniel Cheng7227d212017-11-17 08:12:37 -0800539 self.more_cc = []
540
541 def AppendCC(self, cc):
542 """Appends a user to cc for this change."""
Daniel Cheng0e9f6682022-10-19 17:42:57 +0000543 if cc not in self.more_cc:
544 self.more_cc.append(cc)
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000545
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000546 def PresubmitPromptOrNotify(self, *args, **kwargs):
547 """Warn the user when uploading, but only notify if committing."""
548 if self.is_committing:
549 return self.PresubmitNotifyResult(*args, **kwargs)
550 return self.PresubmitPromptWarning(*args, **kwargs)
551
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000552
553class InputApi(object):
554 """An instance of this object is passed to presubmit scripts so they can
555 know stuff about the change they're looking at.
556 """
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000557 # Method could be a function
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800558 # pylint: disable=no-self-use
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000559
maruel@chromium.org3410d912009-06-09 20:56:16 +0000560 # File extensions that are considered source files from a style guide
561 # perspective. Don't modify this list from a presubmit script!
maruel@chromium.orgc33455a2011-06-24 19:14:18 +0000562 #
563 # Files without an extension aren't included in the list. If you want to
local_bot30f774e2020-06-25 18:23:34 +0000564 # filter them as source files, add r'(^|.*?[\\\/])[^.]+$' to the allow list.
local_bot64021412020-07-08 21:05:39 +0000565 # Note that ALL CAPS files are skipped in DEFAULT_FILES_TO_SKIP below.
566 DEFAULT_FILES_TO_CHECK = (
maruel@chromium.org3410d912009-06-09 20:56:16 +0000567 # C++ and friends
Edward Lemura5799e32020-01-17 19:26:51 +0000568 r'.+\.c$', r'.+\.cc$', r'.+\.cpp$', r'.+\.h$', r'.+\.m$', r'.+\.mm$',
569 r'.+\.inl$', r'.+\.asm$', r'.+\.hxx$', r'.+\.hpp$', r'.+\.s$', r'.+\.S$',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000570 # Scripts
dpapad443d9132022-05-05 00:17:30 +0000571 r'.+\.js$', r'.+\.ts$', r'.+\.py$', r'.+\.sh$', r'.+\.rb$', r'.+\.pl$',
572 r'.+\.pm$',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000573 # Other
Edward Lemura5799e32020-01-17 19:26:51 +0000574 r'.+\.java$', r'.+\.mk$', r'.+\.am$', r'.+\.css$', r'.+\.mojom$',
Bruce Dawson7a81ebf2023-01-03 18:36:18 +0000575 r'.+\.fidl$', r'.+\.rs$',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000576 )
577
578 # Path regexp that should be excluded from being considered containing source
579 # files. Don't modify this list from a presubmit script!
local_bot64021412020-07-08 21:05:39 +0000580 DEFAULT_FILES_TO_SKIP = (
Edward Lemura5799e32020-01-17 19:26:51 +0000581 r'testing_support[\\\/]google_appengine[\\\/].*',
582 r'.*\bexperimental[\\\/].*',
Kent Tamura179dd1e2018-04-26 15:07:41 +0900583 # Exclude third_party/.* but NOT third_party/{WebKit,blink}
584 # (crbug.com/539768 and crbug.com/836555).
Edward Lemura5799e32020-01-17 19:26:51 +0000585 r'.*\bthird_party[\\\/](?!(WebKit|blink)[\\\/]).*',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000586 # Output directories (just in case)
Edward Lemura5799e32020-01-17 19:26:51 +0000587 r'.*\bDebug[\\\/].*',
588 r'.*\bRelease[\\\/].*',
589 r'.*\bxcodebuild[\\\/].*',
590 r'.*\bout[\\\/].*',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000591 # All caps files like README and LICENCE.
Edward Lemura5799e32020-01-17 19:26:51 +0000592 r'.*\b[A-Z0-9_]{2,}$',
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +0000593 # SCM (can happen in dual SCM configuration). (Slightly over aggressive)
Edward Lemura5799e32020-01-17 19:26:51 +0000594 r'(|.*[\\\/])\.git[\\\/].*',
595 r'(|.*[\\\/])\.svn[\\\/].*',
maruel@chromium.org7ccb4bb2011-11-07 20:26:20 +0000596 # There is no point in processing a patch file.
Edward Lemura5799e32020-01-17 19:26:51 +0000597 r'.+\.diff$',
598 r'.+\.patch$',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000599 )
600
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000601 def __init__(self, change, presubmit_path, is_committing,
Bruce Dawson09c0c072022-05-26 20:28:58 +0000602 verbose, gerrit_obj, dry_run=None, thread_pool=None, parallel=False,
603 no_diffs=False):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000604 """Builds an InputApi object.
605
606 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000607 change: A presubmit.Change object.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000608 presubmit_path: The path to the presubmit script being processed.
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000609 is_committing: True if the change is about to be committed.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000610 gerrit_obj: provides basic Gerrit codereview functionality.
611 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -0400612 parallel: if true, all tests reported via input_api.RunTests for all
613 PRESUBMIT files will be run in parallel.
Bruce Dawson09c0c072022-05-26 20:28:58 +0000614 no_diffs: if true, implies that --files or --all was specified so some
615 checks can be skipped, and some errors will be messages.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000616 """
maruel@chromium.org9711bba2009-05-22 23:51:39 +0000617 # Version number of the presubmit_support script.
618 self.version = [int(x) for x in __version__.split('.')]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000619 self.change = change
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000620 self.is_committing = is_committing
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000621 self.gerrit = gerrit_obj
tandrii@chromium.org57bafac2016-04-28 05:09:03 +0000622 self.dry_run = dry_run
Bruce Dawson09c0c072022-05-26 20:28:58 +0000623 self.no_diffs = no_diffs
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000624
Edward Lesmes8e282792018-04-03 18:50:29 -0400625 self.parallel = parallel
626 self.thread_pool = thread_pool or ThreadPool()
627
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000628 # We expose various modules and functions as attributes of the input_api
629 # so that presubmit scripts don't have to import them.
Takeshi Yoshino07a6bea2017-08-02 02:44:06 +0900630 self.ast = ast
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000631 self.basename = os.path.basename
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000632 self.cpplint = cpplint
dcheng091b7db2016-06-16 01:27:51 -0700633 self.fnmatch = fnmatch
Yoshisato Yanagisawa04600b42019-03-15 03:03:41 +0000634 self.gclient_paths = gclient_paths
Yoshisato Yanagisawa57dd17b2019-03-22 09:10:29 +0000635 # TODO(yyanagisawa): stop exposing this when python3 become default.
636 # Since python3's tempfile has TemporaryDirectory, we do not need this.
637 self.temporary_directory = gclient_utils.temporary_directory
dpranke@chromium.org17cc2442012-10-17 21:12:09 +0000638 self.glob = glob.glob
maruel@chromium.orgfb11c7b2010-03-18 18:22:14 +0000639 self.json = json
maruel@chromium.org6fba34d2011-06-02 13:45:12 +0000640 self.logging = logging.getLogger('PRESUBMIT')
maruel@chromium.org2b5ce562011-03-31 16:15:44 +0000641 self.os_listdir = os.listdir
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000642 self.os_path = os.path
pgervais@chromium.orgbd0cace2014-10-02 23:23:46 +0000643 self.os_stat = os.stat
Yoshisato Yanagisawa406de132018-06-29 05:43:25 +0000644 self.os_walk = os.walk
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000645 self.re = re
646 self.subprocess = subprocess
Edward Lemurb9830242019-10-30 22:19:20 +0000647 self.sys = sys
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000648 self.tempfile = tempfile
dpranke@chromium.org0d1bdea2011-03-24 22:54:38 +0000649 self.time = time
maruel@chromium.org1487d532009-06-06 00:22:57 +0000650 self.unittest = unittest
Edward Lemurb9830242019-10-30 22:19:20 +0000651 if sys.version_info.major == 2:
652 self.urllib2 = urllib2
Edward Lemur16af3562019-10-17 22:11:33 +0000653 self.urllib_request = urllib_request
654 self.urllib_error = urllib_error
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000655
Robert Iannucci50258932018-03-19 10:30:59 -0700656 self.is_windows = sys.platform == 'win32'
657
Edward Lemurb9646622019-10-25 20:57:35 +0000658 # Set python_executable to 'vpython' in order to allow scripts in other
659 # repos (e.g. src.git) to automatically pick up that repo's .vpython file,
660 # instead of inheriting the one in depot_tools.
661 self.python_executable = 'vpython'
Erik Staab69135d12021-05-14 22:31:57 +0000662 # Offer a python 3 executable for use during the migration off of python 2.
663 self.python3_executable = 'vpython3'
maruel@chromium.orgc0b22972009-06-25 16:19:14 +0000664 self.environ = os.environ
665
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000666 # InputApi.platform is the platform you're currently running on.
667 self.platform = sys.platform
668
iannucci@chromium.org0af3bb32015-06-12 20:44:35 +0000669 self.cpu_count = multiprocessing.cpu_count()
Bruce Dawson8254f062022-06-17 17:33:08 +0000670 if self.is_windows:
671 # TODO(crbug.com/1190269) - we can't use more than 56 child processes on
672 # Windows or Python3 may hang.
673 self.cpu_count = min(self.cpu_count, 56)
iannucci@chromium.org0af3bb32015-06-12 20:44:35 +0000674
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000675 # The local path of the currently-being-processed presubmit script.
maruel@chromium.org3d235242009-05-15 12:40:48 +0000676 self._current_presubmit_path = os.path.dirname(presubmit_path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000677
678 # We carry the canned checks so presubmit scripts can easily use them.
679 self.canned_checks = presubmit_canned_checks
680
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +0100681 # Temporary files we must manually remove at the end of a run.
682 self._named_temporary_files = []
Jochen Eisinger72606f82017-04-04 10:44:18 +0200683
Edward Lesmesdc11c6b2021-03-19 19:22:05 +0000684 self.owners_client = None
Bruce Dawsoneb8426e2022-08-05 23:58:15 +0000685 if self.gerrit and not 'PRESUBMIT_SKIP_NETWORK' in self.environ:
Bruce Dawson9b9f4512022-04-27 00:56:52 +0000686 try:
687 self.owners_client = owners_client.GetCodeOwnersClient(
Bruce Dawson9b9f4512022-04-27 00:56:52 +0000688 host=self.gerrit.host,
689 project=self.gerrit.project,
690 branch=self.gerrit.branch)
691 except Exception as e:
692 print('Failed to set owners_client - %s' % str(e))
Jochen Eisinger76f5fc62017-04-07 16:27:46 +0200693 self.owners_finder = owners_finder.OwnersFinder
maruel@chromium.org899e1c12011-04-07 17:03:18 +0000694 self.verbose = verbose
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000695 self.Command = CommandData
dpranke@chromium.org2a009622011-03-01 02:43:31 +0000696
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000697 # Replace <hash_map> and <hash_set> as headers that need to be included
Edward Lemura5799e32020-01-17 19:26:51 +0000698 # with 'base/containers/hash_tables.h' instead.
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000699 # Access to a protected member _XX of a client class
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800700 # pylint: disable=protected-access
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000701 self.cpplint._re_pattern_templates = [
danakj@chromium.org18278522013-06-11 22:42:32 +0000702 (a, b, 'base/containers/hash_tables.h')
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000703 if header in ('<hash_map>', '<hash_set>') else (a, b, header)
704 for (a, b, header) in cpplint._re_pattern_templates
705 ]
706
Edward Lemurecc27072020-01-06 16:42:34 +0000707 def SetTimeout(self, timeout):
708 self.thread_pool.timeout = timeout
709
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000710 def PresubmitLocalPath(self):
711 """Returns the local path of the presubmit script currently being run.
712
713 This is useful if you don't want to hard-code absolute paths in the
714 presubmit script. For example, It can be used to find another file
715 relative to the PRESUBMIT.py script, so the whole tree can be branched and
716 the presubmit script still works, without editing its content.
717 """
maruel@chromium.org3d235242009-05-15 12:40:48 +0000718 return self._current_presubmit_path
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000719
agable0b65e732016-11-22 09:25:46 -0800720 def AffectedFiles(self, include_deletes=True, file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000721 """Same as input_api.change.AffectedFiles() except only lists files
722 (and optionally directories) in the same directory as the current presubmit
Bruce Dawson7a0b07a2020-04-23 17:14:40 +0000723 script, or subdirectories thereof. Note that files are listed using the OS
724 path separator, so backslashes are used as separators on Windows.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000725 """
Josip Sokcevic512fd3b2023-03-01 21:06:41 +0000726 dir_with_slash = utils.normpath(self.PresubmitLocalPath())
Bruce Dawson31bfd512022-05-10 23:19:39 +0000727 # normpath strips trailing path separators, so the trailing separator has to
728 # be added after the normpath call.
729 if len(dir_with_slash) > 0:
730 dir_with_slash += os.path.sep
sail@chromium.org5538e022011-05-12 17:53:16 +0000731
Josip Sokcevic512fd3b2023-03-01 21:06:41 +0000732 return list(
733 filter(
734 lambda x: utils.normpath(x.AbsoluteLocalPath()).startswith(
735 dir_with_slash),
736 self.change.AffectedFiles(include_deletes, file_filter)))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000737
agable0b65e732016-11-22 09:25:46 -0800738 def LocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000739 """Returns local paths of input_api.AffectedFiles()."""
agable0b65e732016-11-22 09:25:46 -0800740 paths = [af.LocalPath() for af in self.AffectedFiles()]
Edward Lemura5799e32020-01-17 19:26:51 +0000741 logging.debug('LocalPaths: %s', paths)
pgervais@chromium.org2f64f782014-04-25 00:12:33 +0000742 return paths
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000743
agable0b65e732016-11-22 09:25:46 -0800744 def AbsoluteLocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000745 """Returns absolute local paths of input_api.AffectedFiles()."""
agable0b65e732016-11-22 09:25:46 -0800746 return [af.AbsoluteLocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000747
John Budorick16162372018-04-18 10:39:53 -0700748 def AffectedTestableFiles(self, include_deletes=None, **kwargs):
agable0b65e732016-11-22 09:25:46 -0800749 """Same as input_api.change.AffectedTestableFiles() except only lists files
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000750 in the same directory as the current presubmit script, or subdirectories
751 thereof.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000752 """
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000753 if include_deletes is not None:
Edward Lemura5799e32020-01-17 19:26:51 +0000754 warn('AffectedTestableFiles(include_deletes=%s)'
755 ' is deprecated and ignored' % str(include_deletes),
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000756 category=DeprecationWarning,
757 stacklevel=2)
Josip Sokcevic4de5dea2022-03-23 21:15:14 +0000758 # pylint: disable=consider-using-generator
759 return [
760 x for x in self.AffectedFiles(include_deletes=False, **kwargs)
761 if x.IsTestableFile()
762 ]
agable0b65e732016-11-22 09:25:46 -0800763
764 def AffectedTextFiles(self, include_deletes=None):
765 """An alias to AffectedTestableFiles for backwards compatibility."""
766 return self.AffectedTestableFiles(include_deletes=include_deletes)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000767
Josip Sokcevic8c955952021-02-01 21:32:57 +0000768 def FilterSourceFile(self,
769 affected_file,
770 files_to_check=None,
771 files_to_skip=None,
772 allow_list=None,
773 block_list=None):
Edward Lemura5799e32020-01-17 19:26:51 +0000774 """Filters out files that aren't considered 'source file'.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000775
local_bot64021412020-07-08 21:05:39 +0000776 If files_to_check or files_to_skip is None, InputApi.DEFAULT_FILES_TO_CHECK
777 and InputApi.DEFAULT_FILES_TO_SKIP is used respectively.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000778
Bruce Dawson635383f2022-09-13 16:23:18 +0000779 affected_file.LocalPath() needs to re.match an entry in the files_to_check
780 list and not re.match any entries in the files_to_skip list.
781 '/' path separators should be used in the regular expressions and will work
782 on Windows as well as other platforms.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000783
784 Note: Copy-paste this function to suit your needs or use a lambda function.
785 """
local_bot64021412020-07-08 21:05:39 +0000786 if files_to_check is None:
787 files_to_check = self.DEFAULT_FILES_TO_CHECK
788 if files_to_skip is None:
789 files_to_skip = self.DEFAULT_FILES_TO_SKIP
local_bot30f774e2020-06-25 18:23:34 +0000790
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000791 def Find(affected_file, items):
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000792 local_path = affected_file.LocalPath()
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000793 for item in items:
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +0000794 if self.re.match(item, local_path):
maruel@chromium.org3410d912009-06-09 20:56:16 +0000795 return True
Bruce Dawsona3a014e2022-04-27 23:28:17 +0000796 # Handle the cases where the files regex only handles /, but the local
797 # path uses \.
798 if self.is_windows and self.re.match(item, local_path.replace(
799 '\\', '/')):
800 return True
maruel@chromium.org3410d912009-06-09 20:56:16 +0000801 return False
local_bot64021412020-07-08 21:05:39 +0000802 return (Find(affected_file, files_to_check) and
803 not Find(affected_file, files_to_skip))
maruel@chromium.org3410d912009-06-09 20:56:16 +0000804
805 def AffectedSourceFiles(self, source_file):
agable0b65e732016-11-22 09:25:46 -0800806 """Filter the list of AffectedTestableFiles by the function source_file.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000807
808 If source_file is None, InputApi.FilterSourceFile() is used.
809 """
810 if not source_file:
811 source_file = self.FilterSourceFile
Edward Lemurb9830242019-10-30 22:19:20 +0000812 return list(filter(source_file, self.AffectedTestableFiles()))
maruel@chromium.org3410d912009-06-09 20:56:16 +0000813
814 def RightHandSideLines(self, source_file_filter=None):
Edward Lemura5799e32020-01-17 19:26:51 +0000815 """An iterator over all text lines in 'new' version of changed files.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000816
817 Only lists lines from new or modified text files in the change that are
818 contained by the directory of the currently executing presubmit script.
819
820 This is useful for doing line-by-line regex checks, like checking for
821 trailing whitespace.
822
823 Yields:
824 a 3 tuple:
Josip Sokcevic7958e302023-03-01 23:02:21 +0000825 the AffectedFile instance of the current file;
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000826 integer line number (1-based); and
827 the contents of the line as a string.
maruel@chromium.org1487d532009-06-06 00:22:57 +0000828
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000829 Note: The carriage return (LF or CR) is stripped off.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000830 """
maruel@chromium.org3410d912009-06-09 20:56:16 +0000831 files = self.AffectedSourceFiles(source_file_filter)
Josip Sokcevic7958e302023-03-01 23:02:21 +0000832 return _RightHandSideLinesImpl(files)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000833
maruel@chromium.orge3608df2009-11-10 20:22:57 +0000834 def ReadFile(self, file_item, mode='r'):
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000835 """Reads an arbitrary file.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000836
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000837 Deny reading anything outside the repository.
838 """
Josip Sokcevic7958e302023-03-01 23:02:21 +0000839 if isinstance(file_item, AffectedFile):
maruel@chromium.orge3608df2009-11-10 20:22:57 +0000840 file_item = file_item.AbsoluteLocalPath()
841 if not file_item.startswith(self.change.RepositoryRoot()):
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000842 raise IOError('Access outside the repository root is denied.')
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +0000843 return gclient_utils.FileRead(file_item, mode)
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000844
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +0100845 def CreateTemporaryFile(self, **kwargs):
846 """Returns a named temporary file that must be removed with a call to
847 RemoveTemporaryFiles().
848
849 All keyword arguments are forwarded to tempfile.NamedTemporaryFile(),
850 except for |delete|, which is always set to False.
851
852 Presubmit checks that need to create a temporary file and pass it for
853 reading should use this function instead of NamedTemporaryFile(), as
854 Windows fails to open a file that is already open for writing.
855
856 with input_api.CreateTemporaryFile() as f:
857 f.write('xyz')
858 f.close()
859 input_api.subprocess.check_output(['script-that', '--reads-from',
860 f.name])
861
862
863 Note that callers of CreateTemporaryFile() should not worry about removing
864 any temporary file; this is done transparently by the presubmit handling
865 code.
866 """
867 if 'delete' in kwargs:
868 # Prevent users from passing |delete|; we take care of file deletion
869 # ourselves and this prevents unintuitive error messages when we pass
870 # delete=False and 'delete' is also in kwargs.
871 raise TypeError('CreateTemporaryFile() does not take a "delete" '
872 'argument, file deletion is handled automatically by '
873 'the same presubmit_support code that creates InputApi '
874 'objects.')
875 temp_file = self.tempfile.NamedTemporaryFile(delete=False, **kwargs)
876 self._named_temporary_files.append(temp_file.name)
877 return temp_file
878
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000879 @property
880 def tbr(self):
881 """Returns if a change is TBR'ed."""
Jeremy Romandce22502017-06-20 15:37:29 -0400882 return 'TBR' in self.change.tags or self.change.TBRsFromDescription()
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000883
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +0000884 def RunTests(self, tests_mix, parallel=True):
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000885 tests = []
886 msgs = []
887 for t in tests_mix:
Edward Lesmes8e282792018-04-03 18:50:29 -0400888 if isinstance(t, OutputApi.PresubmitResult) and t:
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000889 msgs.append(t)
890 else:
891 assert issubclass(t.message, _PresubmitResult)
892 tests.append(t)
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +0000893 if self.verbose:
894 t.info = _PresubmitNotifyResult
Edward Lemur1037c742018-05-01 18:56:04 -0400895 if not t.kwargs.get('cwd'):
896 t.kwargs['cwd'] = self.PresubmitLocalPath()
Edward Lesmes8e282792018-04-03 18:50:29 -0400897 self.thread_pool.AddTests(tests, parallel)
Edward Lemur21000eb2019-05-24 23:25:58 +0000898 # When self.parallel is True (i.e. --parallel is passed as an option)
899 # RunTests doesn't actually run tests. It adds them to a ThreadPool that
900 # will run all tests once all PRESUBMIT files are processed.
901 # Otherwise, it will run them and return the results.
902 if not self.parallel:
Edward Lesmes8e282792018-04-03 18:50:29 -0400903 msgs.extend(self.thread_pool.RunAsync())
904 return msgs
scottmg86099d72016-09-01 09:16:51 -0700905
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000906
Josip Sokcevic7958e302023-03-01 23:02:21 +0000907class _DiffCache(object):
908 """Caches diffs retrieved from a particular SCM."""
909 def __init__(self, upstream=None):
910 """Stores the upstream revision against which all diffs will be computed."""
911 self._upstream = upstream
912
913 def GetDiff(self, path, local_root):
914 """Get the diff for a particular path."""
915 raise NotImplementedError()
916
917 def GetOldContents(self, path, local_root):
918 """Get the old version for a particular path."""
919 raise NotImplementedError()
920
921
922class _GitDiffCache(_DiffCache):
923 """DiffCache implementation for git; gets all file diffs at once."""
924 def __init__(self, upstream):
925 super(_GitDiffCache, self).__init__(upstream=upstream)
926 self._diffs_by_file = None
927
928 def GetDiff(self, path, local_root):
929 # Compare against None to distinguish between None and an initialized but
930 # empty dictionary.
931 if self._diffs_by_file == None:
932 # Compute a single diff for all files and parse the output; should
933 # with git this is much faster than computing one diff for each file.
934 diffs = {}
935
936 # Don't specify any filenames below, because there are command line length
937 # limits on some platforms and GenerateDiff would fail.
938 unified_diff = scm.GIT.GenerateDiff(local_root, files=[], full_move=True,
939 branch=self._upstream)
940
941 # This regex matches the path twice, separated by a space. Note that
942 # filename itself may contain spaces.
943 file_marker = re.compile('^diff --git (?P<filename>.*) (?P=filename)$')
944 current_diff = []
945 keep_line_endings = True
946 for x in unified_diff.splitlines(keep_line_endings):
947 match = file_marker.match(x)
948 if match:
949 # Marks the start of a new per-file section.
950 diffs[match.group('filename')] = current_diff = [x]
951 elif x.startswith('diff --git'):
952 raise PresubmitFailure('Unexpected diff line: %s' % x)
953 else:
954 current_diff.append(x)
955
956 self._diffs_by_file = dict(
957 (utils.normpath(path), ''.join(diff)) for path, diff in diffs.items())
958
959 if path not in self._diffs_by_file:
960 # SCM didn't have any diff on this file. It could be that the file was not
961 # modified at all (e.g. user used --all flag in git cl presubmit).
962 # Intead of failing, return empty string.
963 # See: https://crbug.com/808346.
964 return ''
965
966 return self._diffs_by_file[path]
967
968 def GetOldContents(self, path, local_root):
969 return scm.GIT.GetOldContents(local_root, path, branch=self._upstream)
970
971
972class AffectedFile(object):
973 """Representation of a file in a change."""
974
975 DIFF_CACHE = _DiffCache
976
977 # Method could be a function
978 # pylint: disable=no-self-use
979 def __init__(self, path, action, repository_root, diff_cache):
980 self._path = path
981 self._action = action
982 self._local_root = repository_root
983 self._is_directory = None
984 self._cached_changed_contents = None
985 self._cached_new_contents = None
986 self._diff_cache = diff_cache
987 logging.debug('%s(%s)', self.__class__.__name__, self._path)
988
989 def LocalPath(self):
990 """Returns the path of this file on the local disk relative to client root.
991
992 This should be used for error messages but not for accessing files,
993 because presubmit checks are run with CWD=PresubmitLocalPath() (which is
994 often != client root).
995 """
996 return utils.normpath(self._path)
997
998 def AbsoluteLocalPath(self):
999 """Returns the absolute path of this file on the local disk.
1000 """
1001 return os.path.abspath(os.path.join(self._local_root, self.LocalPath()))
1002
1003 def Action(self):
1004 """Returns the action on this opened file, e.g. A, M, D, etc."""
1005 return self._action
1006
1007 def IsTestableFile(self):
1008 """Returns True if the file is a text file and not a binary file.
1009
1010 Deleted files are not text file."""
1011 raise NotImplementedError() # Implement when needed
1012
1013 def IsTextFile(self):
1014 """An alias to IsTestableFile for backwards compatibility."""
1015 return self.IsTestableFile()
1016
1017 def OldContents(self):
1018 """Returns an iterator over the lines in the old version of file.
1019
1020 The old version is the file before any modifications in the user's
1021 workspace, i.e. the 'left hand side'.
1022
1023 Contents will be empty if the file is a directory or does not exist.
1024 Note: The carriage returns (LF or CR) are stripped off.
1025 """
1026 return self._diff_cache.GetOldContents(self.LocalPath(),
1027 self._local_root).splitlines()
1028
1029 def NewContents(self):
1030 """Returns an iterator over the lines in the new version of file.
1031
1032 The new version is the file in the user's workspace, i.e. the 'right hand
1033 side'.
1034
1035 Contents will be empty if the file is a directory or does not exist.
1036 Note: The carriage returns (LF or CR) are stripped off.
1037 """
1038 if self._cached_new_contents is None:
1039 self._cached_new_contents = []
1040 try:
1041 self._cached_new_contents = gclient_utils.FileRead(
1042 self.AbsoluteLocalPath(), 'rU').splitlines()
1043 except IOError:
1044 pass # File not found? That's fine; maybe it was deleted.
1045 except UnicodeDecodeError as e:
1046 # log the filename since we're probably trying to read a binary
1047 # file, and shouldn't be.
1048 print('Error reading %s: %s' % (self.AbsoluteLocalPath(), e))
1049 raise
1050
1051 return self._cached_new_contents[:]
1052
1053 def ChangedContents(self, keeplinebreaks=False):
1054 """Returns a list of tuples (line number, line text) of all new lines.
1055
1056 This relies on the scm diff output describing each changed code section
1057 with a line of the form
1058
1059 ^@@ <old line num>,<old size> <new line num>,<new size> @@$
1060 """
1061 # Don't return cached results when line breaks are requested.
1062 if not keeplinebreaks and self._cached_changed_contents is not None:
1063 return self._cached_changed_contents[:]
1064 result = []
1065 line_num = 0
1066
1067 # The keeplinebreaks parameter to splitlines must be True or else the
1068 # CheckForWindowsLineEndings presubmit will be a NOP.
1069 for line in self.GenerateScmDiff().splitlines(keeplinebreaks):
1070 m = re.match(r'^@@ [0-9\,\+\-]+ \+([0-9]+)\,[0-9]+ @@', line)
1071 if m:
1072 line_num = int(m.groups(1)[0])
1073 continue
1074 if line.startswith('+') and not line.startswith('++'):
1075 result.append((line_num, line[1:]))
1076 if not line.startswith('-'):
1077 line_num += 1
1078 # Don't cache results with line breaks.
1079 if keeplinebreaks:
1080 return result;
1081 self._cached_changed_contents = result
1082 return self._cached_changed_contents[:]
1083
1084 def __str__(self):
1085 return self.LocalPath()
1086
1087 def GenerateScmDiff(self):
1088 return self._diff_cache.GetDiff(self.LocalPath(), self._local_root)
1089
1090
1091class GitAffectedFile(AffectedFile):
1092 """Representation of a file in a change out of a git checkout."""
1093 # Method 'NNN' is abstract in class 'NNN' but is not overridden
1094 # pylint: disable=abstract-method
1095
1096 DIFF_CACHE = _GitDiffCache
1097
1098 def __init__(self, *args, **kwargs):
1099 AffectedFile.__init__(self, *args, **kwargs)
1100 self._server_path = None
1101 self._is_testable_file = None
1102
1103 def IsTestableFile(self):
1104 if self._is_testable_file is None:
1105 if self.Action() == 'D':
1106 # A deleted file is not testable.
1107 self._is_testable_file = False
1108 else:
1109 self._is_testable_file = os.path.isfile(self.AbsoluteLocalPath())
1110 return self._is_testable_file
1111
1112
1113class Change(object):
1114 """Describe a change.
1115
1116 Used directly by the presubmit scripts to query the current change being
1117 tested.
1118
1119 Instance members:
1120 tags: Dictionary of KEY=VALUE pairs found in the change description.
1121 self.KEY: equivalent to tags['KEY']
1122 """
1123
1124 _AFFECTED_FILES = AffectedFile
1125
1126 # Matches key/value (or 'tag') lines in changelist descriptions.
1127 TAG_LINE_RE = re.compile(
1128 '^[ \t]*(?P<key>[A-Z][A-Z_0-9]*)[ \t]*=[ \t]*(?P<value>.*?)[ \t]*$')
1129 scm = ''
1130
1131 def __init__(
1132 self, name, description, local_root, files, issue, patchset, author,
1133 upstream=None):
1134 if files is None:
1135 files = []
1136 self._name = name
1137 # Convert root into an absolute path.
1138 self._local_root = os.path.abspath(local_root)
1139 self._upstream = upstream
1140 self.issue = issue
1141 self.patchset = patchset
1142 self.author_email = author
1143
1144 self._full_description = ''
1145 self.tags = {}
1146 self._description_without_tags = ''
1147 self.SetDescriptionText(description)
1148
1149 assert all(
1150 (isinstance(f, (list, tuple)) and len(f) == 2) for f in files), files
1151
1152 diff_cache = self._AFFECTED_FILES.DIFF_CACHE(self._upstream)
1153 self._affected_files = [
1154 self._AFFECTED_FILES(path, action.strip(), self._local_root, diff_cache)
1155 for action, path in files
1156 ]
1157
1158 def UpstreamBranch(self):
1159 """Returns the upstream branch for the change."""
1160 return self._upstream
1161
1162 def Name(self):
1163 """Returns the change name."""
1164 return self._name
1165
1166 def DescriptionText(self):
1167 """Returns the user-entered changelist description, minus tags.
1168
1169 Any line in the user-provided description starting with e.g. 'FOO='
1170 (whitespace permitted before and around) is considered a tag line. Such
1171 lines are stripped out of the description this function returns.
1172 """
1173 return self._description_without_tags
1174
1175 def FullDescriptionText(self):
1176 """Returns the complete changelist description including tags."""
1177 return self._full_description
1178
1179 def SetDescriptionText(self, description):
1180 """Sets the full description text (including tags) to |description|.
1181
1182 Also updates the list of tags."""
1183 self._full_description = description
1184
1185 # From the description text, build up a dictionary of key/value pairs
1186 # plus the description minus all key/value or 'tag' lines.
1187 description_without_tags = []
1188 self.tags = {}
1189 for line in self._full_description.splitlines():
1190 m = self.TAG_LINE_RE.match(line)
1191 if m:
1192 self.tags[m.group('key')] = m.group('value')
1193 else:
1194 description_without_tags.append(line)
1195
1196 # Change back to text and remove whitespace at end.
1197 self._description_without_tags = (
1198 '\n'.join(description_without_tags).rstrip())
1199
1200 def AddDescriptionFooter(self, key, value):
1201 """Adds the given footer to the change description.
1202
1203 Args:
1204 key: A string with the key for the git footer. It must conform to
1205 the git footers format (i.e. 'List-Of-Tokens') and will be case
1206 normalized so that each token is title-cased.
1207 value: A string with the value for the git footer.
1208 """
1209 description = git_footers.add_footer(
1210 self.FullDescriptionText(), git_footers.normalize_name(key), value)
1211 self.SetDescriptionText(description)
1212
1213 def RepositoryRoot(self):
1214 """Returns the repository (checkout) root directory for this change,
1215 as an absolute path.
1216 """
1217 return self._local_root
1218
1219 def __getattr__(self, attr):
1220 """Return tags directly as attributes on the object."""
1221 if not re.match(r'^[A-Z_]*$', attr):
1222 raise AttributeError(self, attr)
1223 return self.tags.get(attr)
1224
1225 def GitFootersFromDescription(self):
1226 """Return the git footers present in the description.
1227
1228 Returns:
1229 footers: A dict of {footer: [values]} containing a multimap of the footers
1230 in the change description.
1231 """
1232 return git_footers.parse_footers(self.FullDescriptionText())
1233
1234 def BugsFromDescription(self):
1235 """Returns all bugs referenced in the commit description."""
1236 bug_tags = ['BUG', 'FIXED']
1237
1238 tags = []
1239 for tag in bug_tags:
1240 values = self.tags.get(tag)
1241 if values:
1242 tags += [value.strip() for value in values.split(',')]
1243
1244 footers = []
1245 parsed = self.GitFootersFromDescription()
1246 unsplit_footers = parsed.get('Bug', []) + parsed.get('Fixed', [])
1247 for unsplit_footer in unsplit_footers:
1248 footers += [b.strip() for b in unsplit_footer.split(',')]
1249 return sorted(set(tags + footers))
1250
1251 def ReviewersFromDescription(self):
1252 """Returns all reviewers listed in the commit description."""
1253 # We don't support a 'R:' git-footer for reviewers; that is in metadata.
1254 tags = [r.strip() for r in self.tags.get('R', '').split(',') if r.strip()]
1255 return sorted(set(tags))
1256
1257 def TBRsFromDescription(self):
1258 """Returns all TBR reviewers listed in the commit description."""
1259 tags = [r.strip() for r in self.tags.get('TBR', '').split(',') if r.strip()]
1260 # TODO(crbug.com/839208): Remove support for 'Tbr:' when TBRs are
1261 # programmatically determined by self-CR+1s.
1262 footers = self.GitFootersFromDescription().get('Tbr', [])
1263 return sorted(set(tags + footers))
1264
1265 # TODO(crbug.com/753425): Delete these once we're sure they're unused.
1266 @property
1267 def BUG(self):
1268 return ','.join(self.BugsFromDescription())
1269 @property
1270 def R(self):
1271 return ','.join(self.ReviewersFromDescription())
1272 @property
1273 def TBR(self):
1274 return ','.join(self.TBRsFromDescription())
1275
1276 def AllFiles(self, root=None):
1277 """List all files under source control in the repo."""
1278 raise NotImplementedError()
1279
1280 def AffectedFiles(self, include_deletes=True, file_filter=None):
1281 """Returns a list of AffectedFile instances for all files in the change.
1282
1283 Args:
1284 include_deletes: If false, deleted files will be filtered out.
1285 file_filter: An additional filter to apply.
1286
1287 Returns:
1288 [AffectedFile(path, action), AffectedFile(path, action)]
1289 """
1290 affected = list(filter(file_filter, self._affected_files))
1291
1292 if include_deletes:
1293 return affected
1294 return list(filter(lambda x: x.Action() != 'D', affected))
1295
1296 def AffectedTestableFiles(self, include_deletes=None, **kwargs):
1297 """Return a list of the existing text files in a change."""
1298 if include_deletes is not None:
1299 warn('AffectedTeestableFiles(include_deletes=%s)'
1300 ' is deprecated and ignored' % str(include_deletes),
1301 category=DeprecationWarning,
1302 stacklevel=2)
1303 return list(filter(
1304 lambda x: x.IsTestableFile(),
1305 self.AffectedFiles(include_deletes=False, **kwargs)))
1306
1307 def AffectedTextFiles(self, include_deletes=None):
1308 """An alias to AffectedTestableFiles for backwards compatibility."""
1309 return self.AffectedTestableFiles(include_deletes=include_deletes)
1310
1311 def LocalPaths(self):
1312 """Convenience function."""
1313 return [af.LocalPath() for af in self.AffectedFiles()]
1314
1315 def AbsoluteLocalPaths(self):
1316 """Convenience function."""
1317 return [af.AbsoluteLocalPath() for af in self.AffectedFiles()]
1318
1319 def RightHandSideLines(self):
1320 """An iterator over all text lines in 'new' version of changed files.
1321
1322 Lists lines from new or modified text files in the change.
1323
1324 This is useful for doing line-by-line regex checks, like checking for
1325 trailing whitespace.
1326
1327 Yields:
1328 a 3 tuple:
1329 the AffectedFile instance of the current file;
1330 integer line number (1-based); and
1331 the contents of the line as a string.
1332 """
1333 return _RightHandSideLinesImpl(
1334 x for x in self.AffectedFiles(include_deletes=False)
1335 if x.IsTestableFile())
1336
1337 def OriginalOwnersFiles(self):
1338 """A map from path names of affected OWNERS files to their old content."""
1339 def owners_file_filter(f):
1340 return 'OWNERS' in os.path.split(f.LocalPath())[1]
1341 files = self.AffectedFiles(file_filter=owners_file_filter)
1342 return {f.LocalPath(): f.OldContents() for f in files}
1343
1344
1345class GitChange(Change):
1346 _AFFECTED_FILES = GitAffectedFile
1347 scm = 'git'
1348
1349 def AllFiles(self, root=None):
1350 """List all files under source control in the repo."""
1351 root = root or self.RepositoryRoot()
1352 return subprocess.check_output(
1353 ['git', '-c', 'core.quotePath=false', 'ls-files', '--', '.'],
1354 cwd=root).decode('utf-8', 'ignore').splitlines()
1355
1356
rmistry@google.com5626a922015-02-26 14:03:30 +00001357class GetPostUploadExecuter(object):
Pavol Marko624e7ee2023-01-09 09:56:29 +00001358 def __init__(self, change, gerrit_obj, use_python3):
Josip Sokcevice293d3d2022-02-16 22:52:15 +00001359 """
1360 Args:
Pavol Marko624e7ee2023-01-09 09:56:29 +00001361 change: The Change object.
1362 gerrit_obj: provides basic Gerrit codereview functionality.
Josip Sokcevice293d3d2022-02-16 22:52:15 +00001363 use_python3: if true, will use python3 instead of python2 by default
1364 if USE_PYTHON3 is not specified.
1365 """
Pavol Marko624e7ee2023-01-09 09:56:29 +00001366 self.change = change
1367 self.gerrit = gerrit_obj
Josip Sokcevice293d3d2022-02-16 22:52:15 +00001368 self.use_python3 = use_python3
1369
Pavol Marko624e7ee2023-01-09 09:56:29 +00001370 def ExecPresubmitScript(self, script_text, presubmit_path):
rmistry@google.com5626a922015-02-26 14:03:30 +00001371 """Executes PostUploadHook() from a single presubmit script.
Josip Sokcevic632bbc02022-05-19 05:32:50 +00001372 Caller is responsible for validating whether the hook should be executed
1373 and should only call this function if it should be.
rmistry@google.com5626a922015-02-26 14:03:30 +00001374
1375 Args:
1376 script_text: The text of the presubmit script.
1377 presubmit_path: Project script to run.
rmistry@google.com5626a922015-02-26 14:03:30 +00001378
1379 Return:
1380 A list of results objects.
1381 """
Pavol Marko624e7ee2023-01-09 09:56:29 +00001382 # Change to the presubmit file's directory to support local imports.
1383 presubmit_dir = os.path.dirname(presubmit_path)
1384 main_path = os.getcwd()
1385 try:
1386 os.chdir(presubmit_dir)
1387 return self._execute_with_local_working_directory(script_text,
1388 presubmit_dir,
1389 presubmit_path)
1390 finally:
1391 # Return the process to the original working directory.
1392 os.chdir(main_path)
1393
1394 def _execute_with_local_working_directory(self, script_text, presubmit_dir,
1395 presubmit_path):
rmistry@google.com5626a922015-02-26 14:03:30 +00001396 context = {}
1397 try:
Pavol Marko624e7ee2023-01-09 09:56:29 +00001398 exec(compile(script_text, presubmit_path, 'exec', dont_inherit=True),
Raul Tambre09e64b42019-05-14 01:57:22 +00001399 context)
Raul Tambre7c938462019-05-24 16:35:35 +00001400 except Exception as e:
rmistry@google.com5626a922015-02-26 14:03:30 +00001401 raise PresubmitFailure('"%s" had an exception.\n%s'
1402 % (presubmit_path, e))
1403
1404 function_name = 'PostUploadHook'
1405 if function_name not in context:
1406 return {}
1407 post_upload_hook = context[function_name]
1408 if not len(inspect.getargspec(post_upload_hook)[0]) == 3:
1409 raise PresubmitFailure(
1410 'Expected function "PostUploadHook" to take three arguments.')
Pavol Marko624e7ee2023-01-09 09:56:29 +00001411 return post_upload_hook(self.gerrit, self.change, OutputApi(False))
rmistry@google.com5626a922015-02-26 14:03:30 +00001412
1413
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001414def _MergeMasters(masters1, masters2):
1415 """Merges two master maps. Merges also the tests of each builder."""
1416 result = {}
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001417 for (master, builders) in itertools.chain(masters1.items(),
1418 masters2.items()):
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001419 new_builders = result.setdefault(master, {})
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001420 for (builder, tests) in builders.items():
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001421 new_builders.setdefault(builder, set([])).update(tests)
1422 return result
1423
1424
Josip Sokcevice293d3d2022-02-16 22:52:15 +00001425def DoPostUploadExecuter(change, gerrit_obj, verbose, use_python3=False):
rmistry@google.com5626a922015-02-26 14:03:30 +00001426 """Execute the post upload hook.
1427
1428 Args:
1429 change: The Change object.
Edward Lemur016a0872020-02-04 22:13:28 +00001430 gerrit_obj: The GerritAccessor object.
rmistry@google.com5626a922015-02-26 14:03:30 +00001431 verbose: Prints debug info.
Josip Sokcevice293d3d2022-02-16 22:52:15 +00001432 use_python3: if true, default to using Python3 for presubmit checks
1433 rather than Python2.
rmistry@google.com5626a922015-02-26 14:03:30 +00001434 """
Josip Sokcevice293d3d2022-02-16 22:52:15 +00001435 python_version = 'Python %s' % sys.version_info.major
1436 sys.stdout.write('Running %s post upload checks ...\n' % python_version)
Josip Sokcevic512fd3b2023-03-01 21:06:41 +00001437 presubmit_files = utils.ListRelevantFilesInSourceCheckout(
1438 change.LocalPaths(), change.RepositoryRoot(), _PRESUBMIT_FILE_REGEX,
1439 _PRESUBMIT_FILE_EXCLUDE)
rmistry@google.com5626a922015-02-26 14:03:30 +00001440 if not presubmit_files and verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001441 sys.stdout.write('Warning, no PRESUBMIT.py found.\n')
rmistry@google.com5626a922015-02-26 14:03:30 +00001442 results = []
Pavol Marko624e7ee2023-01-09 09:56:29 +00001443 executer = GetPostUploadExecuter(change, gerrit_obj, use_python3)
rmistry@google.com5626a922015-02-26 14:03:30 +00001444 # The root presubmit file should be executed after the ones in subdirectories.
1445 # i.e. the specific post upload hooks should run before the general ones.
Josip Sokcevic512fd3b2023-03-01 21:06:41 +00001446 # Thus, reverse the order.
rmistry@google.com5626a922015-02-26 14:03:30 +00001447 presubmit_files.reverse()
1448
1449 for filename in presubmit_files:
1450 filename = os.path.abspath(filename)
rmistry@google.com5626a922015-02-26 14:03:30 +00001451 # Accept CRLF presubmit script.
Bruce Dawson6e70e862022-07-01 19:37:01 +00001452 presubmit_script = gclient_utils.FileRead(filename).replace('\r\n', '\n')
Josip Sokcevic48d8e902023-03-09 02:38:26 +00001453 if _ShouldRunPresubmit(presubmit_script, use_python3):
1454 if sys.version_info[0] == 2:
1455 sys.stdout.write(
1456 'Running %s under Python 2. Add USE_PYTHON3 = True to prevent '
1457 'this.\n' % filename)
1458 elif verbose:
1459 sys.stdout.write('Running %s\n' % filename)
1460 results.extend(executer.ExecPresubmitScript(presubmit_script, filename))
rmistry@google.com5626a922015-02-26 14:03:30 +00001461
Edward Lemur6eb1d322020-02-27 22:20:15 +00001462 if not results:
1463 return 0
1464
1465 sys.stdout.write('\n')
1466 sys.stdout.write('** Post Upload Hook Messages **\n')
1467
1468 exit_code = 0
1469 for result in results:
1470 if result.fatal:
1471 exit_code = 1
1472 result.handle()
1473 sys.stdout.write('\n')
1474
1475 return exit_code
rmistry@google.com5626a922015-02-26 14:03:30 +00001476
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001477class PresubmitExecuter(object):
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001478 def __init__(self, change, committing, verbose, gerrit_obj, dry_run=None,
Bruce Dawson09c0c072022-05-26 20:28:58 +00001479 thread_pool=None, parallel=False, use_python3=False,
1480 no_diffs=False):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001481 """
1482 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001483 change: The Change object.
agable92bec4f2016-08-24 09:27:27 -07001484 committing: True if 'git cl land' is running, False if 'git cl upload' is.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001485 gerrit_obj: provides basic Gerrit codereview functionality.
1486 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -04001487 parallel: if true, all tests reported via input_api.RunTests for all
1488 PRESUBMIT files will be run in parallel.
Dirk Pranke6f0df682021-06-25 00:42:33 +00001489 use_python3: if true, will use python3 instead of python2 by default
1490 if USE_PYTHON3 is not specified.
Bruce Dawson09c0c072022-05-26 20:28:58 +00001491 no_diffs: if true, implies that --files or --all was specified so some
1492 checks can be skipped, and some errors will be messages.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001493 """
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001494 self.change = change
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001495 self.committing = committing
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001496 self.gerrit = gerrit_obj
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001497 self.verbose = verbose
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001498 self.dry_run = dry_run
Daniel Cheng7227d212017-11-17 08:12:37 -08001499 self.more_cc = []
Edward Lesmes8e282792018-04-03 18:50:29 -04001500 self.thread_pool = thread_pool
1501 self.parallel = parallel
Dirk Pranke6f0df682021-06-25 00:42:33 +00001502 self.use_python3 = use_python3
Bruce Dawson09c0c072022-05-26 20:28:58 +00001503 self.no_diffs = no_diffs
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001504
1505 def ExecPresubmitScript(self, script_text, presubmit_path):
1506 """Executes a single presubmit script.
Josip Sokcevic632bbc02022-05-19 05:32:50 +00001507 Caller is responsible for validating whether the hook should be executed
1508 and should only call this function if it should be.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001509
1510 Args:
1511 script_text: The text of the presubmit script.
1512 presubmit_path: The path to the presubmit file (this will be reported via
1513 input_api.PresubmitLocalPath()).
1514
1515 Return:
1516 A list of result objects, empty if no problems.
1517 """
chase@chromium.org8e416c82009-10-06 04:30:44 +00001518 # Change to the presubmit file's directory to support local imports.
Saagar Sanghavi98b332f2020-07-31 17:19:15 +00001519 presubmit_dir = os.path.dirname(presubmit_path)
Pavol Marko624e7ee2023-01-09 09:56:29 +00001520 main_path = os.getcwd()
1521 try:
1522 os.chdir(presubmit_dir)
1523 return self._execute_with_local_working_directory(script_text,
1524 presubmit_dir,
1525 presubmit_path)
1526 finally:
1527 # Return the process to the original working directory.
1528 os.chdir(main_path)
chase@chromium.org8e416c82009-10-06 04:30:44 +00001529
Pavol Marko624e7ee2023-01-09 09:56:29 +00001530 def _execute_with_local_working_directory(self, script_text, presubmit_dir,
1531 presubmit_path):
chase@chromium.org8e416c82009-10-06 04:30:44 +00001532 # Load the presubmit script into context.
dpranke@chromium.org970c5222011-03-12 00:32:24 +00001533 input_api = InputApi(self.change, presubmit_path, self.committing,
Aaron Gable668c1d82018-04-03 10:19:16 -07001534 self.verbose, gerrit_obj=self.gerrit,
Edward Lesmes8e282792018-04-03 18:50:29 -04001535 dry_run=self.dry_run, thread_pool=self.thread_pool,
Bruce Dawson09c0c072022-05-26 20:28:58 +00001536 parallel=self.parallel, no_diffs=self.no_diffs)
Daniel Cheng7227d212017-11-17 08:12:37 -08001537 output_api = OutputApi(self.committing)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001538 context = {}
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001539
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001540 try:
Bruce Dawson0ba2fd42022-07-21 13:47:21 +00001541 exec(compile(script_text, presubmit_path, 'exec', dont_inherit=True),
Raul Tambre09e64b42019-05-14 01:57:22 +00001542 context)
Raul Tambre7c938462019-05-24 16:35:35 +00001543 except Exception as e:
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001544 raise PresubmitFailure('"%s" had an exception.\n%s' % (presubmit_path, e))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001545
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001546 context['__args'] = (input_api, output_api)
Ben Pastene8351dc12020-08-06 05:01:35 +00001547
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001548 # Get path of presubmit directory relative to repository root.
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001549 # Always use forward slashes, so that path is same in *nix and Windows
1550 root = input_api.change.RepositoryRoot()
1551 rel_path = os.path.relpath(presubmit_dir, root)
1552 rel_path = rel_path.replace(os.path.sep, '/')
Ben Pastene8351dc12020-08-06 05:01:35 +00001553
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001554 # Get the URL of git remote origin and use it to identify host and project
Edward Lesmeseb1bd622021-03-01 19:54:07 +00001555 host = project = ''
1556 if self.gerrit:
1557 host = self.gerrit.host or ''
1558 project = self.gerrit.project or ''
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001559
1560 # Prefix for test names
1561 prefix = 'presubmit:%s/%s:%s/' % (host, project, rel_path)
1562
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001563 # Perform all the desired presubmit checks.
1564 results = []
Ben Pastene8351dc12020-08-06 05:01:35 +00001565
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001566 try:
Scott Leecc2fe9b2020-11-19 19:38:06 +00001567 version = [
1568 int(x) for x in context.get('PRESUBMIT_VERSION', '0.0.0').split('.')
1569 ]
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001570
Scott Leecc2fe9b2020-11-19 19:38:06 +00001571 with rdb_wrapper.client(prefix) as sink:
1572 if version >= [2, 0, 0]:
Andrew Grievebdfb8f22022-02-02 21:56:47 +00001573 # Copy the keys to prevent "dictionary changed size during iteration"
1574 # exception if checks add globals to context. E.g. sometimes the
1575 # Python runtime will add __warningregistry__.
1576 for function_name in list(context.keys()):
Scott Leecc2fe9b2020-11-19 19:38:06 +00001577 if not function_name.startswith('Check'):
1578 continue
1579 if function_name.endswith('Commit') and not self.committing:
1580 continue
1581 if function_name.endswith('Upload') and self.committing:
1582 continue
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001583 logging.debug('Running %s in %s', function_name, presubmit_path)
1584 results.extend(
Bruce Dawson8fa42e22022-03-29 17:05:38 +00001585 self._run_check_function(function_name, context, sink,
1586 presubmit_path))
Scott Leecc2fe9b2020-11-19 19:38:06 +00001587 logging.debug('Running %s done.', function_name)
1588 self.more_cc.extend(output_api.more_cc)
1589
1590 else: # Old format
1591 if self.committing:
1592 function_name = 'CheckChangeOnCommit'
1593 else:
1594 function_name = 'CheckChangeOnUpload'
Andrew Grievebdfb8f22022-02-02 21:56:47 +00001595 if function_name in list(context.keys()):
Scott Leecc2fe9b2020-11-19 19:38:06 +00001596 logging.debug('Running %s in %s', function_name, presubmit_path)
1597 results.extend(
Bruce Dawson8fa42e22022-03-29 17:05:38 +00001598 self._run_check_function(function_name, context, sink,
1599 presubmit_path))
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001600 logging.debug('Running %s done.', function_name)
1601 self.more_cc.extend(output_api.more_cc)
1602
1603 finally:
1604 for f in input_api._named_temporary_files:
1605 os.remove(f)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001606
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001607 return results
1608
Bruce Dawson8fa42e22022-03-29 17:05:38 +00001609 def _run_check_function(self, function_name, context, sink, presubmit_path):
Scott Leecc2fe9b2020-11-19 19:38:06 +00001610 """Evaluates and returns the result of a given presubmit function.
1611
1612 If sink is given, the result of the presubmit function will be reported
1613 to the ResultSink.
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001614
1615 Args:
Scott Leecc2fe9b2020-11-19 19:38:06 +00001616 function_name: the name of the presubmit function to evaluate
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001617 context: a context dictionary in which the function will be evaluated
Scott Leecc2fe9b2020-11-19 19:38:06 +00001618 sink: an instance of ResultSink. None, by default.
1619 Returns:
1620 the result of the presubmit function call.
1621 """
1622 start_time = time_time()
1623 try:
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001624 result = eval(function_name + '(*__args)', context)
1625 self._check_result_type(result)
Allen Webbfe7d7092021-05-18 02:05:49 +00001626 except Exception:
Bruce Dawson10a82862022-05-27 19:25:56 +00001627 _, e_value, _ = sys.exc_info()
1628 result = [
1629 OutputApi.PresubmitError(
1630 'Evaluation of %s failed: %s, %s' %
1631 (function_name, e_value, traceback.format_exc()))
1632 ]
Scott Leecc2fe9b2020-11-19 19:38:06 +00001633
Bruce Dawson2bdc49f2021-05-21 19:13:03 +00001634 elapsed_time = time_time() - start_time
1635 if elapsed_time > 10.0:
Bruce Dawson6757d462022-07-13 04:04:40 +00001636 sys.stdout.write('%6.1fs to run %s from %s.\n' %
1637 (elapsed_time, function_name, presubmit_path))
Scott Leecc2fe9b2020-11-19 19:38:06 +00001638 if sink:
Erik Staab9f38b632022-10-31 14:05:24 +00001639 failure_reason = None
Scott Leecc2fe9b2020-11-19 19:38:06 +00001640 status = rdb_wrapper.STATUS_PASS
1641 if any(r.fatal for r in result):
1642 status = rdb_wrapper.STATUS_FAIL
Erik Staab9f38b632022-10-31 14:05:24 +00001643 failure_reasons = []
1644 for r in result:
1645 fields = r.json_format()
1646 message = fields['message']
1647 items = '\n'.join(' %s' % item for item in fields['items'])
1648 failure_reasons.append('\n'.join([message, items]))
1649 if failure_reasons:
1650 failure_reason = '\n'.join(failure_reasons)
1651 sink.report(function_name, status, elapsed_time, failure_reason)
Scott Leecc2fe9b2020-11-19 19:38:06 +00001652
1653 return result
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001654
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00001655 def _check_result_type(self, result):
1656 """Helper function which ensures result is a list, and all elements are
1657 instances of OutputApi.PresubmitResult"""
1658 if not isinstance(result, (tuple, list)):
1659 raise PresubmitFailure('Presubmit functions must return a tuple or list')
1660 if not all(isinstance(res, OutputApi.PresubmitResult) for res in result):
1661 raise PresubmitFailure(
1662 'All presubmit results must be of types derived from '
1663 'output_api.PresubmitResult')
1664
1665
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001666def DoPresubmitChecks(change,
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001667 committing,
1668 verbose,
maruel@chromium.orgb0dfd352009-06-10 14:12:54 +00001669 default_presubmit,
dpranke@chromium.org970c5222011-03-12 00:32:24 +00001670 may_prompt,
Aaron Gable668c1d82018-04-03 10:19:16 -07001671 gerrit_obj,
Edward Lesmes8e282792018-04-03 18:50:29 -04001672 dry_run=None,
Debrian Figueroadd2737e2019-06-21 23:50:13 +00001673 parallel=False,
Dirk Pranke6f0df682021-06-25 00:42:33 +00001674 json_output=None,
Bruce Dawson09c0c072022-05-26 20:28:58 +00001675 use_python3=False,
1676 no_diffs=False):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001677 """Runs all presubmit checks that apply to the files in the change.
1678
1679 This finds all PRESUBMIT.py files in directories enclosing the files in the
1680 change (up to the repository root) and calls the relevant entrypoint function
1681 depending on whether the change is being committed or uploaded.
1682
1683 Prints errors, warnings and notifications. Prompts the user for warnings
1684 when needed.
1685
1686 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001687 change: The Change object.
agable92bec4f2016-08-24 09:27:27 -07001688 committing: True if 'git cl land' is running, False if 'git cl upload' is.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001689 verbose: Prints debug info.
maruel@chromium.org0ff1fab2009-05-22 13:08:15 +00001690 default_presubmit: A default presubmit script to execute in any case.
Quinten Yearsley516fe7f2016-12-14 11:50:18 -08001691 may_prompt: Enable (y/n) questions on warning or error. If False,
1692 any questions are answered with yes by default.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001693 gerrit_obj: provides basic Gerrit codereview functionality.
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001694 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -04001695 parallel: if true, all tests specified by input_api.RunTests in all
1696 PRESUBMIT files will be run in parallel.
Dirk Pranke6f0df682021-06-25 00:42:33 +00001697 use_python3: if true, default to using Python3 for presubmit checks
1698 rather than Python2.
Bruce Dawson09c0c072022-05-26 20:28:58 +00001699 no_diffs: if true, implies that --files or --all was specified so some
1700 checks can be skipped, and some errors will be messages.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001701 Return:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001702 1 if presubmit checks failed or 0 otherwise.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001703 """
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001704 old_environ = os.environ
1705 try:
1706 # Make sure python subprocesses won't generate .pyc files.
1707 os.environ = os.environ.copy()
Edward Lemurb9830242019-10-30 22:19:20 +00001708 os.environ['PYTHONDONTWRITEBYTECODE'] = '1'
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001709
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001710 python_version = 'Python %s' % sys.version_info.major
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001711 if committing:
Dirk Pranke6fc394f2021-05-26 23:25:14 +00001712 sys.stdout.write('Running %s presubmit commit checks ...\n' %
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001713 python_version)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001714 else:
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001715 sys.stdout.write('Running %s presubmit upload checks ...\n' %
1716 python_version)
Edward Lemurecc27072020-01-06 16:42:34 +00001717 start_time = time_time()
Josip Sokcevic512fd3b2023-03-01 21:06:41 +00001718 presubmit_files = utils.ListRelevantFilesInSourceCheckout(
1719 change.AbsoluteLocalPaths(), change.RepositoryRoot(),
1720 _PRESUBMIT_FILE_REGEX, _PRESUBMIT_FILE_EXCLUDE)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001721 if not presubmit_files and verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001722 sys.stdout.write('Warning, no PRESUBMIT.py found.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001723 results = []
Bruce Dawsonc9f904f2022-10-14 20:59:49 +00001724 if sys.platform == 'win32':
1725 temp = os.environ['TEMP']
1726 else:
1727 temp = '/tmp'
1728 python2_usage_log_file = os.path.join(temp, 'python2_usage.txt')
Bruce Dawsonf2b04212022-06-10 16:42:54 +00001729 if os.path.exists(python2_usage_log_file):
1730 os.remove(python2_usage_log_file)
Edward Lesmes8e282792018-04-03 18:50:29 -04001731 thread_pool = ThreadPool()
Edward Lemur7e3c67f2018-07-20 20:52:49 +00001732 executer = PresubmitExecuter(change, committing, verbose, gerrit_obj,
Bruce Dawson09c0c072022-05-26 20:28:58 +00001733 dry_run, thread_pool, parallel, use_python3,
1734 no_diffs)
Josip Sokcevic48d8e902023-03-09 02:38:26 +00001735 skipped_count = 0;
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001736 if default_presubmit:
1737 if verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001738 sys.stdout.write('Running default presubmit script.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001739 fake_path = os.path.join(change.RepositoryRoot(), 'PRESUBMIT.py')
Josip Sokcevic48d8e902023-03-09 02:38:26 +00001740 if _ShouldRunPresubmit(default_presubmit, use_python3):
1741 results += executer.ExecPresubmitScript(default_presubmit, fake_path)
1742 else:
1743 skipped_count += 1
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001744 for filename in presubmit_files:
1745 filename = os.path.abspath(filename)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001746 # Accept CRLF presubmit script.
Bruce Dawson6e70e862022-07-01 19:37:01 +00001747 presubmit_script = gclient_utils.FileRead(filename).replace('\r\n', '\n')
Josip Sokcevic48d8e902023-03-09 02:38:26 +00001748 if _ShouldRunPresubmit(presubmit_script, use_python3):
1749 if sys.version_info[0] == 2:
1750 sys.stdout.write(
1751 'Running %s under Python 2. Add USE_PYTHON3 = True to prevent '
1752 'this.\n' % filename)
1753 elif verbose:
1754 sys.stdout.write('Running %s\n' % filename)
1755 results += executer.ExecPresubmitScript(presubmit_script, filename)
1756 else:
1757 skipped_count += 1
Bruce Dawson76fe1a72022-05-25 20:52:21 +00001758
Edward Lesmes8e282792018-04-03 18:50:29 -04001759 results += thread_pool.RunAsync()
1760
Bruce Dawsonf2b04212022-06-10 16:42:54 +00001761 if os.path.exists(python2_usage_log_file):
1762 with open(python2_usage_log_file) as f:
1763 python2_usage = [x.strip() for x in f.readlines()]
1764 results.append(
1765 OutputApi(committing).PresubmitPromptWarning(
1766 'Python 2 scripts were run during %s presubmits. Please see '
1767 'https://bugs.chromium.org/p/chromium/issues/detail?id=1313804'
1768 '#c61 for tips on resolving this.'
1769 % python_version,
1770 items=python2_usage))
1771
Edward Lemur6eb1d322020-02-27 22:20:15 +00001772 messages = {}
1773 should_prompt = False
1774 presubmits_failed = False
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001775 for result in results:
1776 if result.fatal:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001777 presubmits_failed = True
1778 messages.setdefault('ERRORS', []).append(result)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001779 elif result.should_prompt:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001780 should_prompt = True
1781 messages.setdefault('Warnings', []).append(result)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001782 else:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001783 messages.setdefault('Messages', []).append(result)
pam@chromium.orged9a0832009-09-09 22:48:55 +00001784
Bruce Dawson76fe1a72022-05-25 20:52:21 +00001785 # Print the different message types in a consistent order. ERRORS go last
1786 # so that they will be most visible in the local-presubmit output.
1787 for name in ['Messages', 'Warnings', 'ERRORS']:
1788 if name in messages:
1789 items = messages[name]
Gavin Makd22bf602022-07-11 21:10:41 +00001790 sys.stdout.write('** Presubmit %s: %d **\n' % (name, len(items)))
Bruce Dawson76fe1a72022-05-25 20:52:21 +00001791 for item in items:
1792 item.handle()
1793 sys.stdout.write('\n')
pam@chromium.orged9a0832009-09-09 22:48:55 +00001794
Edward Lemurecc27072020-01-06 16:42:34 +00001795 total_time = time_time() - start_time
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001796 if total_time > 1.0:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001797 sys.stdout.write(
Louis Romero4ca9e1c2022-03-10 10:29:11 +00001798 'Presubmit checks took %.1fs to calculate.\n' % total_time)
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +00001799
Edward Lemur6eb1d322020-02-27 22:20:15 +00001800 if not should_prompt and not presubmits_failed:
Louis Romero4ca9e1c2022-03-10 10:29:11 +00001801 sys.stdout.write('%s presubmit checks passed.\n\n' % python_version)
Josip Sokcevic7592e0a2022-01-12 00:57:54 +00001802 elif should_prompt and not presubmits_failed:
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001803 sys.stdout.write('There were %s presubmit warnings. ' % python_version)
Quinten Yearsley516fe7f2016-12-14 11:50:18 -08001804 if may_prompt:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001805 presubmits_failed = not prompt_should_continue(
1806 'Are you sure you wish to continue? (y/N): ')
Garrett Beatyacb807e2020-08-28 18:17:24 +00001807 else:
1808 sys.stdout.write('\n')
Bruce Dawson76fe1a72022-05-25 20:52:21 +00001809 else:
1810 sys.stdout.write('There were %s presubmit errors.\n' % python_version)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001811
Edward Lemur1dc66e12020-02-21 21:36:34 +00001812 if json_output:
1813 # Write the presubmit results to json output
1814 presubmit_results = {
1815 'errors': [
Edward Lemur6eb1d322020-02-27 22:20:15 +00001816 error.json_format()
1817 for error in messages.get('ERRORS', [])
Edward Lemur1dc66e12020-02-21 21:36:34 +00001818 ],
1819 'notifications': [
Edward Lemur6eb1d322020-02-27 22:20:15 +00001820 notification.json_format()
1821 for notification in messages.get('Messages', [])
Edward Lemur1dc66e12020-02-21 21:36:34 +00001822 ],
1823 'warnings': [
Edward Lemur6eb1d322020-02-27 22:20:15 +00001824 warning.json_format()
1825 for warning in messages.get('Warnings', [])
Edward Lemur1dc66e12020-02-21 21:36:34 +00001826 ],
Edward Lemur6eb1d322020-02-27 22:20:15 +00001827 'more_cc': executer.more_cc,
Josip Sokcevic48d8e902023-03-09 02:38:26 +00001828 'skipped_presubmits': skipped_count,
Edward Lemur1dc66e12020-02-21 21:36:34 +00001829 }
1830
1831 gclient_utils.FileWrite(
1832 json_output, json.dumps(presubmit_results, sort_keys=True))
1833
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001834 global _ASKED_FOR_FEEDBACK
1835 # Ask for feedback one time out of 5.
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +00001836 if (results and random.randint(0, 4) == 0 and not _ASKED_FOR_FEEDBACK):
Edward Lemur6eb1d322020-02-27 22:20:15 +00001837 sys.stdout.write(
maruel@chromium.org1ce8e662014-01-14 15:23:00 +00001838 'Was the presubmit check useful? If not, run "git cl presubmit -v"\n'
1839 'to figure out which PRESUBMIT.py was run, then run git blame\n'
1840 'on the file to figure out who to ask for help.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001841 _ASKED_FOR_FEEDBACK = True
Edward Lemur6eb1d322020-02-27 22:20:15 +00001842
1843 return 1 if presubmits_failed else 0
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001844 finally:
1845 os.environ = old_environ
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001846
1847
Edward Lemur50984a62020-02-06 18:10:18 +00001848def _scan_sub_dirs(mask, recursive):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001849 if not recursive:
pgervais@chromium.orge57b09d2014-05-07 00:58:13 +00001850 return [x for x in glob.glob(mask) if x not in ('.svn', '.git')]
Lei Zhang9611c4c2017-04-04 01:41:56 -07001851
1852 results = []
1853 for root, dirs, files in os.walk('.'):
1854 if '.svn' in dirs:
1855 dirs.remove('.svn')
1856 if '.git' in dirs:
1857 dirs.remove('.git')
1858 for name in files:
1859 if fnmatch.fnmatch(name, mask):
1860 results.append(os.path.join(root, name))
1861 return results
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001862
1863
Edward Lemur50984a62020-02-06 18:10:18 +00001864def _parse_files(args, recursive):
tobiasjs2836bcf2016-08-16 04:08:16 -07001865 logging.debug('Searching for %s', args)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001866 files = []
1867 for arg in args:
Edward Lemur50984a62020-02-06 18:10:18 +00001868 files.extend([('M', f) for f in _scan_sub_dirs(arg, recursive)])
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001869 return files
1870
1871
Edward Lemur50984a62020-02-06 18:10:18 +00001872def _parse_change(parser, options):
1873 """Process change options.
1874
1875 Args:
1876 parser: The parser used to parse the arguments from command line.
1877 options: The arguments parsed from command line.
1878 Returns:
Josip Sokcevic7958e302023-03-01 23:02:21 +00001879 A GitChange if the change root is a git repository, or a Change otherwise.
Edward Lemur50984a62020-02-06 18:10:18 +00001880 """
1881 if options.files and options.all_files:
1882 parser.error('<files> cannot be specified when --all-files is set.')
1883
Edward Lesmes44ea3ff2020-02-05 00:14:30 +00001884 change_scm = scm.determine_scm(options.root)
Edward Lemur50984a62020-02-06 18:10:18 +00001885 if change_scm != 'git' and not options.files:
1886 parser.error('<files> is not optional for unversioned directories.')
1887
1888 if options.files:
Josip Sokcevic017544d2022-03-31 23:47:53 +00001889 if options.source_controlled_only:
1890 # Get the filtered set of files from SCM.
1891 change_files = []
1892 for name in scm.GIT.GetAllFiles(options.root):
1893 for mask in options.files:
1894 if fnmatch.fnmatch(name, mask):
1895 change_files.append(('M', name))
1896 break
1897 else:
1898 # Get the filtered set of files from a directory scan.
1899 change_files = _parse_files(options.files, options.recursive)
Edward Lemur50984a62020-02-06 18:10:18 +00001900 elif options.all_files:
1901 change_files = [('M', f) for f in scm.GIT.GetAllFiles(options.root)]
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001902 else:
Edward Lemur50984a62020-02-06 18:10:18 +00001903 change_files = scm.GIT.CaptureStatus(
Edward Lemur7f6dec02020-02-06 20:23:58 +00001904 options.root, options.upstream or None)
Edward Lemur50984a62020-02-06 18:10:18 +00001905
1906 logging.info('Found %d file(s).', len(change_files))
1907
Josip Sokcevic7958e302023-03-01 23:02:21 +00001908 change_class = GitChange if change_scm == 'git' else Change
Edward Lemur50984a62020-02-06 18:10:18 +00001909 return change_class(
1910 options.name,
1911 options.description,
1912 options.root,
1913 change_files,
1914 options.issue,
1915 options.patchset,
1916 options.author,
1917 upstream=options.upstream)
1918
1919
1920def _parse_gerrit_options(parser, options):
1921 """Process gerrit options.
1922
1923 SIDE EFFECTS: Modifies options.author and options.description from Gerrit if
1924 options.gerrit_fetch is set.
1925
1926 Args:
1927 parser: The parser used to parse the arguments from command line.
1928 options: The arguments parsed from command line.
1929 Returns:
Stephen Martinisfb09de22021-02-25 03:41:13 +00001930 A GerritAccessor object if options.gerrit_url is set, or None otherwise.
Edward Lemur50984a62020-02-06 18:10:18 +00001931 """
1932 gerrit_obj = None
Stephen Martinisfb09de22021-02-25 03:41:13 +00001933 if options.gerrit_url:
Edward Lesmeseb1bd622021-03-01 19:54:07 +00001934 gerrit_obj = GerritAccessor(
1935 url=options.gerrit_url,
1936 project=options.gerrit_project,
1937 branch=options.gerrit_branch)
Edward Lemur50984a62020-02-06 18:10:18 +00001938
1939 if not options.gerrit_fetch:
1940 return gerrit_obj
1941
1942 if not options.gerrit_url or not options.issue or not options.patchset:
1943 parser.error(
1944 '--gerrit_fetch requires --gerrit_url, --issue and --patchset.')
1945
1946 options.author = gerrit_obj.GetChangeOwner(options.issue)
1947 options.description = gerrit_obj.GetChangeDescription(
1948 options.issue, options.patchset)
1949
1950 logging.info('Got author: "%s"', options.author)
1951 logging.info('Got description: """\n%s\n"""', options.description)
1952
1953 return gerrit_obj
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001954
1955
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001956@contextlib.contextmanager
1957def canned_check_filter(method_names):
1958 filtered = {}
1959 try:
1960 for method_name in method_names:
1961 if not hasattr(presubmit_canned_checks, method_name):
Gavin Make6a62332020-12-04 21:57:10 +00001962 logging.warning('Skipping unknown "canned" check %s' % method_name)
Aaron Gableecee74c2018-04-02 15:13:08 -07001963 continue
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001964 filtered[method_name] = getattr(presubmit_canned_checks, method_name)
1965 setattr(presubmit_canned_checks, method_name, lambda *_a, **_kw: [])
1966 yield
1967 finally:
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001968 for name, method in filtered.items():
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001969 setattr(presubmit_canned_checks, name, method)
1970
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +00001971
sbc@chromium.org013731e2015-02-26 18:28:43 +00001972def main(argv=None):
Edward Lemura5799e32020-01-17 19:26:51 +00001973 parser = argparse.ArgumentParser(usage='%(prog)s [options] <files...>')
1974 hooks = parser.add_mutually_exclusive_group()
1975 hooks.add_argument('-c', '--commit', action='store_true',
1976 help='Use commit instead of upload checks.')
1977 hooks.add_argument('-u', '--upload', action='store_false', dest='commit',
1978 help='Use upload instead of commit checks.')
Edward Lemur75526302020-02-27 22:31:05 +00001979 hooks.add_argument('--post_upload', action='store_true',
1980 help='Run post-upload commit hooks.')
Edward Lemura5799e32020-01-17 19:26:51 +00001981 parser.add_argument('-r', '--recursive', action='store_true',
1982 help='Act recursively.')
1983 parser.add_argument('-v', '--verbose', action='count', default=0,
1984 help='Use 2 times for more debug info.')
1985 parser.add_argument('--name', default='no name')
1986 parser.add_argument('--author')
Edward Lemur227d5102020-02-25 23:45:35 +00001987 desc = parser.add_mutually_exclusive_group()
1988 desc.add_argument('--description', default='', help='The change description.')
1989 desc.add_argument('--description_file',
1990 help='File to read change description from.')
Edward Lemura5799e32020-01-17 19:26:51 +00001991 parser.add_argument('--issue', type=int, default=0)
1992 parser.add_argument('--patchset', type=int, default=0)
1993 parser.add_argument('--root', default=os.getcwd(),
1994 help='Search for PRESUBMIT.py up to this directory. '
1995 'If inherit-review-settings-ok is present in this '
1996 'directory, parent directories up to the root file '
1997 'system directories will also be searched.')
1998 parser.add_argument('--upstream',
1999 help='Git only: the base ref or upstream branch against '
2000 'which the diff should be computed.')
2001 parser.add_argument('--default_presubmit')
2002 parser.add_argument('--may_prompt', action='store_true', default=False)
2003 parser.add_argument('--skip_canned', action='append', default=[],
2004 help='A list of checks to skip which appear in '
2005 'presubmit_canned_checks. Can be provided multiple times '
2006 'to skip multiple canned checks.')
2007 parser.add_argument('--dry_run', action='store_true', help=argparse.SUPPRESS)
2008 parser.add_argument('--gerrit_url', help=argparse.SUPPRESS)
Edward Lesmeseb1bd622021-03-01 19:54:07 +00002009 parser.add_argument('--gerrit_project', help=argparse.SUPPRESS)
2010 parser.add_argument('--gerrit_branch', help=argparse.SUPPRESS)
Edward Lemura5799e32020-01-17 19:26:51 +00002011 parser.add_argument('--gerrit_fetch', action='store_true',
2012 help=argparse.SUPPRESS)
2013 parser.add_argument('--parallel', action='store_true',
2014 help='Run all tests specified by input_api.RunTests in '
2015 'all PRESUBMIT files in parallel.')
2016 parser.add_argument('--json_output',
2017 help='Write presubmit errors to json output.')
Edward Lemur1dc66e12020-02-21 21:36:34 +00002018 parser.add_argument('--all_files', action='store_true',
Edward Lemur50984a62020-02-06 18:10:18 +00002019 help='Mark all files under source control as modified.')
Bruce Dawson09c0c072022-05-26 20:28:58 +00002020
Edward Lemura5799e32020-01-17 19:26:51 +00002021 parser.add_argument('files', nargs='*',
2022 help='List of files to be marked as modified when '
2023 'executing presubmit or post-upload hooks. fnmatch '
2024 'wildcards can also be used.')
Josip Sokcevic017544d2022-03-31 23:47:53 +00002025 parser.add_argument('--source_controlled_only', action='store_true',
2026 help='Constrain \'files\' to those in source control.')
Dirk Pranke6f0df682021-06-25 00:42:33 +00002027 parser.add_argument('--use-python3', action='store_true',
2028 help='Use python3 for presubmit checks by default')
Bruce Dawson09c0c072022-05-26 20:28:58 +00002029 parser.add_argument('--no_diffs', action='store_true',
2030 help='Assume that all "modified" files have no diffs.')
Edward Lemura5799e32020-01-17 19:26:51 +00002031 options = parser.parse_args(argv)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00002032
Erik Staabcca5c492020-04-16 17:40:07 +00002033 log_level = logging.ERROR
maruel@chromium.org899e1c12011-04-07 17:03:18 +00002034 if options.verbose >= 2:
Erik Staabcca5c492020-04-16 17:40:07 +00002035 log_level = logging.DEBUG
maruel@chromium.org899e1c12011-04-07 17:03:18 +00002036 elif options.verbose:
Erik Staabcca5c492020-04-16 17:40:07 +00002037 log_level = logging.INFO
2038 log_format = ('[%(levelname).1s%(asctime)s %(process)d %(thread)d '
2039 '%(filename)s] %(message)s')
2040 logging.basicConfig(format=log_format, level=log_level)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00002041
Bruce Dawsondca14bc2022-09-15 20:59:38 +00002042 # Print call stacks when _PresubmitResult objects are created with -v -v is
2043 # specified. This helps track down where presubmit messages are coming from.
2044 if options.verbose >= 2:
2045 global _SHOW_CALLSTACKS
2046 _SHOW_CALLSTACKS = True
2047
Edward Lemur227d5102020-02-25 23:45:35 +00002048 if options.description_file:
2049 options.description = gclient_utils.FileRead(options.description_file)
Edward Lemur50984a62020-02-06 18:10:18 +00002050 gerrit_obj = _parse_gerrit_options(parser, options)
2051 change = _parse_change(parser, options)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00002052
maruel@chromium.org899e1c12011-04-07 17:03:18 +00002053 try:
Edward Lemur75526302020-02-27 22:31:05 +00002054 if options.post_upload:
Josip Sokcevice293d3d2022-02-16 22:52:15 +00002055 return DoPostUploadExecuter(change, gerrit_obj, options.verbose,
2056 options.use_python3)
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00002057 with canned_check_filter(options.skip_canned):
Edward Lemur6eb1d322020-02-27 22:20:15 +00002058 return DoPresubmitChecks(
Edward Lemur50984a62020-02-06 18:10:18 +00002059 change,
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00002060 options.commit,
2061 options.verbose,
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00002062 options.default_presubmit,
2063 options.may_prompt,
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00002064 gerrit_obj,
Edward Lesmes8e282792018-04-03 18:50:29 -04002065 options.dry_run,
Debrian Figueroadd2737e2019-06-21 23:50:13 +00002066 options.parallel,
Dirk Pranke6f0df682021-06-25 00:42:33 +00002067 options.json_output,
Bruce Dawson09c0c072022-05-26 20:28:58 +00002068 options.use_python3,
2069 options.no_diffs)
Raul Tambre7c938462019-05-24 16:35:35 +00002070 except PresubmitFailure as e:
Raul Tambre80ee78e2019-05-06 22:41:05 +00002071 print(e, file=sys.stderr)
2072 print('Maybe your depot_tools is out of date?', file=sys.stderr)
Josip Sokcevic0399e172022-03-21 23:11:51 +00002073 print('depot_tools version: %s' % utils.depot_tools_version(),
2074 file=sys.stderr)
maruel@chromium.org899e1c12011-04-07 17:03:18 +00002075 return 2
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00002076
2077
2078if __name__ == '__main__':
maruel@chromium.org35625c72011-03-23 17:34:02 +00002079 fix_encoding.fix_encoding()
sbc@chromium.org013731e2015-02-26 18:28:43 +00002080 try:
2081 sys.exit(main())
2082 except KeyboardInterrupt:
2083 sys.stderr.write('interrupted\n')
sergiybf8a3b382016-07-05 11:21:30 -07002084 sys.exit(2)