Josip Sokcevic | 4de5dea | 2022-03-23 21:15:14 +0000 | [diff] [blame] | 1 | #!/usr/bin/env python3 |
maruel@chromium.org | 3bbf294 | 2012-01-10 16:52:06 +0000 | [diff] [blame] | 2 | # Copyright (c) 2012 The Chromium Authors. All rights reserved. |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 3 | # Use of this source code is governed by a BSD-style license that can be |
| 4 | # found in the LICENSE file. |
| 5 | |
| 6 | """Enables directory-specific presubmit checks to run at upload and/or commit. |
| 7 | """ |
| 8 | |
Raul Tambre | 80ee78e | 2019-05-06 22:41:05 +0000 | [diff] [blame] | 9 | from __future__ import print_function |
| 10 | |
Saagar Sanghavi | 9981690 | 2020-08-11 22:41:25 +0000 | [diff] [blame] | 11 | __version__ = '2.0.0' |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 12 | |
| 13 | # TODO(joi) Add caching where appropriate/needed. The API is designed to allow |
| 14 | # caching (between all different invocations of presubmit scripts for a given |
| 15 | # change). We should add it as our presubmit scripts start feeling slow. |
| 16 | |
Edward Lemur | a5799e3 | 2020-01-17 19:26:51 +0000 | [diff] [blame] | 17 | import argparse |
Takeshi Yoshino | 07a6bea | 2017-08-02 02:44:06 +0900 | [diff] [blame] | 18 | import ast # Exposed through the API. |
iannucci@chromium.org | 8a4a2bc | 2013-03-08 08:13:20 +0000 | [diff] [blame] | 19 | import contextlib |
Yoshisato Yanagisawa | 406de13 | 2018-06-29 05:43:25 +0000 | [diff] [blame] | 20 | import cpplint |
dcheng | 091b7db | 2016-06-16 01:27:51 -0700 | [diff] [blame] | 21 | import fnmatch # Exposed through the API. |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 22 | import glob |
asvitkine@chromium.org | 1516995 | 2011-09-27 14:30:53 +0000 | [diff] [blame] | 23 | import inspect |
machenbach@chromium.org | 58a69cb | 2014-03-01 02:08:29 +0000 | [diff] [blame] | 24 | import itertools |
maruel@chromium.org | 4f6852c | 2012-04-20 20:39:20 +0000 | [diff] [blame] | 25 | import json # Exposed through the API. |
maruel@chromium.org | df1595a | 2009-06-11 02:00:13 +0000 | [diff] [blame] | 26 | import logging |
ilevy@chromium.org | bc11731 | 2013-04-20 03:57:56 +0000 | [diff] [blame] | 27 | import multiprocessing |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 28 | import os # Somewhat exposed through the API. |
maruel@chromium.org | ce8e46b | 2009-06-26 22:31:51 +0000 | [diff] [blame] | 29 | import random |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 30 | import re # Exposed through the API. |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 31 | import signal |
Allen Webb | fe7d709 | 2021-05-18 02:05:49 +0000 | [diff] [blame] | 32 | import six |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 33 | import sys # Parts exposed through API. |
| 34 | import tempfile # Exposed through the API. |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 35 | import threading |
jam@chromium.org | 2a891dc | 2009-08-20 20:33:37 +0000 | [diff] [blame] | 36 | import time |
Edward Lemur | de9e3ca | 2019-10-24 21:13:31 +0000 | [diff] [blame] | 37 | import traceback |
maruel@chromium.org | 1487d53 | 2009-06-06 00:22:57 +0000 | [diff] [blame] | 38 | import unittest # Exposed through the API. |
maruel@chromium.org | cb2985f | 2010-11-03 14:08:31 +0000 | [diff] [blame] | 39 | from warnings import warn |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 40 | |
| 41 | # Local imports. |
maruel@chromium.org | 35625c7 | 2011-03-23 17:34:02 +0000 | [diff] [blame] | 42 | import fix_encoding |
Yoshisato Yanagisawa | 04600b4 | 2019-03-15 03:03:41 +0000 | [diff] [blame] | 43 | import gclient_paths # Exposed through the API |
| 44 | import gclient_utils |
Aaron Gable | b584c4f | 2017-04-26 16:28:08 -0700 | [diff] [blame] | 45 | import git_footers |
tandrii@chromium.org | 015ebae | 2016-04-25 19:37:22 +0000 | [diff] [blame] | 46 | import gerrit_util |
Edward Lesmes | 9ce03f8 | 2021-01-12 20:13:31 +0000 | [diff] [blame] | 47 | import owners_client |
Jochen Eisinger | 76f5fc6 | 2017-04-07 16:27:46 +0200 | [diff] [blame] | 48 | import owners_finder |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 49 | import presubmit_canned_checks |
Saagar Sanghavi | 9949ab7 | 2020-07-20 20:56:40 +0000 | [diff] [blame] | 50 | import rdb_wrapper |
maruel@chromium.org | 5aeb7dd | 2009-11-17 18:09:01 +0000 | [diff] [blame] | 51 | import scm |
maruel@chromium.org | 84f4fe3 | 2011-04-06 13:26:45 +0000 | [diff] [blame] | 52 | import subprocess2 as subprocess # Exposed through the API. |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 53 | |
Edward Lemur | 16af356 | 2019-10-17 22:11:33 +0000 | [diff] [blame] | 54 | if sys.version_info.major == 2: |
| 55 | # TODO(1009814): Expose urllib2 only through urllib_request and urllib_error |
| 56 | import urllib2 # Exposed through the API. |
| 57 | import urlparse |
| 58 | import urllib2 as urllib_request |
| 59 | import urllib2 as urllib_error |
| 60 | else: |
| 61 | import urllib.parse as urlparse |
| 62 | import urllib.request as urllib_request |
| 63 | import urllib.error as urllib_error |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 64 | |
maruel@chromium.org | ce8e46b | 2009-06-26 22:31:51 +0000 | [diff] [blame] | 65 | # Ask for feedback only once in program lifetime. |
| 66 | _ASKED_FOR_FEEDBACK = False |
| 67 | |
Bruce Dawson | dca14bc | 2022-09-15 20:59:38 +0000 | [diff] [blame] | 68 | # Set if super-verbose mode is requested, for tracking where presubmit messages |
| 69 | # are coming from. |
| 70 | _SHOW_CALLSTACKS = False |
| 71 | |
| 72 | |
Edward Lemur | ecc2707 | 2020-01-06 16:42:34 +0000 | [diff] [blame] | 73 | def time_time(): |
| 74 | # Use this so that it can be mocked in tests without interfering with python |
| 75 | # system machinery. |
| 76 | return time.time() |
| 77 | |
| 78 | |
maruel@chromium.org | 899e1c1 | 2011-04-07 17:03:18 +0000 | [diff] [blame] | 79 | class PresubmitFailure(Exception): |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 80 | pass |
| 81 | |
| 82 | |
maruel@chromium.org | ffeb2f3 | 2013-12-03 13:55:22 +0000 | [diff] [blame] | 83 | class CommandData(object): |
Edward Lemur | 940c282 | 2019-08-23 00:34:25 +0000 | [diff] [blame] | 84 | def __init__(self, name, cmd, kwargs, message, python3=False): |
maruel@chromium.org | ffeb2f3 | 2013-12-03 13:55:22 +0000 | [diff] [blame] | 85 | self.name = name |
| 86 | self.cmd = cmd |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 87 | self.stdin = kwargs.get('stdin', None) |
Edward Lemur | 2d6b67c | 2019-08-23 22:25:41 +0000 | [diff] [blame] | 88 | self.kwargs = kwargs.copy() |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 89 | self.kwargs['stdout'] = subprocess.PIPE |
| 90 | self.kwargs['stderr'] = subprocess.STDOUT |
| 91 | self.kwargs['stdin'] = subprocess.PIPE |
maruel@chromium.org | ffeb2f3 | 2013-12-03 13:55:22 +0000 | [diff] [blame] | 92 | self.message = message |
| 93 | self.info = None |
Edward Lemur | 940c282 | 2019-08-23 00:34:25 +0000 | [diff] [blame] | 94 | self.python3 = python3 |
maruel@chromium.org | ffeb2f3 | 2013-12-03 13:55:22 +0000 | [diff] [blame] | 95 | |
ilevy@chromium.org | bc11731 | 2013-04-20 03:57:56 +0000 | [diff] [blame] | 96 | |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 97 | # Adapted from |
| 98 | # https://github.com/google/gtest-parallel/blob/master/gtest_parallel.py#L37 |
| 99 | # |
| 100 | # An object that catches SIGINT sent to the Python process and notices |
| 101 | # if processes passed to wait() die by SIGINT (we need to look for |
| 102 | # both of those cases, because pressing Ctrl+C can result in either |
| 103 | # the main process or one of the subprocesses getting the signal). |
| 104 | # |
| 105 | # Before a SIGINT is seen, wait(p) will simply call p.wait() and |
| 106 | # return the result. Once a SIGINT has been seen (in the main process |
| 107 | # or a subprocess, including the one the current call is waiting for), |
Edward Lemur | 9a5bb61 | 2019-09-26 02:01:52 +0000 | [diff] [blame] | 108 | # wait(p) will call p.terminate(). |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 109 | class SigintHandler(object): |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 110 | sigint_returncodes = {-signal.SIGINT, # Unix |
| 111 | -1073741510, # Windows |
| 112 | } |
| 113 | def __init__(self): |
| 114 | self.__lock = threading.Lock() |
| 115 | self.__processes = set() |
| 116 | self.__got_sigint = False |
Edward Lemur | 9a5bb61 | 2019-09-26 02:01:52 +0000 | [diff] [blame] | 117 | self.__previous_signal = signal.signal(signal.SIGINT, self.interrupt) |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 118 | |
| 119 | def __on_sigint(self): |
| 120 | self.__got_sigint = True |
| 121 | while self.__processes: |
| 122 | try: |
| 123 | self.__processes.pop().terminate() |
| 124 | except OSError: |
| 125 | pass |
| 126 | |
Edward Lemur | 9a5bb61 | 2019-09-26 02:01:52 +0000 | [diff] [blame] | 127 | def interrupt(self, signal_num, frame): |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 128 | with self.__lock: |
| 129 | self.__on_sigint() |
Edward Lemur | 9a5bb61 | 2019-09-26 02:01:52 +0000 | [diff] [blame] | 130 | self.__previous_signal(signal_num, frame) |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 131 | |
| 132 | def got_sigint(self): |
| 133 | with self.__lock: |
| 134 | return self.__got_sigint |
| 135 | |
| 136 | def wait(self, p, stdin): |
| 137 | with self.__lock: |
| 138 | if self.__got_sigint: |
| 139 | p.terminate() |
| 140 | self.__processes.add(p) |
| 141 | stdout, stderr = p.communicate(stdin) |
| 142 | code = p.returncode |
| 143 | with self.__lock: |
| 144 | self.__processes.discard(p) |
| 145 | if code in self.sigint_returncodes: |
| 146 | self.__on_sigint() |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 147 | return stdout, stderr |
| 148 | |
| 149 | sigint_handler = SigintHandler() |
| 150 | |
| 151 | |
Edward Lemur | ecc2707 | 2020-01-06 16:42:34 +0000 | [diff] [blame] | 152 | class Timer(object): |
| 153 | def __init__(self, timeout, fn): |
| 154 | self.completed = False |
| 155 | self._fn = fn |
| 156 | self._timer = threading.Timer(timeout, self._onTimer) if timeout else None |
| 157 | |
| 158 | def __enter__(self): |
| 159 | if self._timer: |
| 160 | self._timer.start() |
| 161 | return self |
| 162 | |
| 163 | def __exit__(self, _type, _value, _traceback): |
| 164 | if self._timer: |
| 165 | self._timer.cancel() |
| 166 | |
| 167 | def _onTimer(self): |
| 168 | self._fn() |
| 169 | self.completed = True |
| 170 | |
| 171 | |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 172 | class ThreadPool(object): |
Edward Lemur | ecc2707 | 2020-01-06 16:42:34 +0000 | [diff] [blame] | 173 | def __init__(self, pool_size=None, timeout=None): |
| 174 | self.timeout = timeout |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 175 | self._pool_size = pool_size or multiprocessing.cpu_count() |
Bruce Dawson | 8254f06 | 2022-06-17 17:33:08 +0000 | [diff] [blame] | 176 | if sys.platform == 'win32': |
| 177 | # TODO(crbug.com/1190269) - we can't use more than 56 child processes on |
| 178 | # Windows or Python3 may hang. |
| 179 | self._pool_size = min(self._pool_size, 56) |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 180 | self._messages = [] |
| 181 | self._messages_lock = threading.Lock() |
| 182 | self._tests = [] |
| 183 | self._tests_lock = threading.Lock() |
| 184 | self._nonparallel_tests = [] |
| 185 | |
Edward Lemur | ecc2707 | 2020-01-06 16:42:34 +0000 | [diff] [blame] | 186 | def _GetCommand(self, test): |
Edward Lemur | 940c282 | 2019-08-23 00:34:25 +0000 | [diff] [blame] | 187 | vpython = 'vpython' |
| 188 | if test.python3: |
| 189 | vpython += '3' |
| 190 | if sys.platform == 'win32': |
| 191 | vpython += '.bat' |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 192 | |
| 193 | cmd = test.cmd |
| 194 | if cmd[0] == 'python': |
| 195 | cmd = list(cmd) |
| 196 | cmd[0] = vpython |
| 197 | elif cmd[0].endswith('.py'): |
| 198 | cmd = [vpython] + cmd |
| 199 | |
Edward Lemur | 336e51f | 2019-11-14 21:42:04 +0000 | [diff] [blame] | 200 | # On Windows, scripts on the current directory take precedence over PATH, so |
| 201 | # that when testing depot_tools on Windows, calling `vpython.bat` will |
| 202 | # execute the copy of vpython of the depot_tools under test instead of the |
| 203 | # one in the bot. |
| 204 | # As a workaround, we run the tests from the parent directory instead. |
| 205 | if (cmd[0] == vpython and |
| 206 | 'cwd' in test.kwargs and |
| 207 | os.path.basename(test.kwargs['cwd']) == 'depot_tools'): |
| 208 | test.kwargs['cwd'] = os.path.dirname(test.kwargs['cwd']) |
| 209 | cmd[1] = os.path.join('depot_tools', cmd[1]) |
| 210 | |
Edward Lemur | ecc2707 | 2020-01-06 16:42:34 +0000 | [diff] [blame] | 211 | return cmd |
| 212 | |
| 213 | def _RunWithTimeout(self, cmd, stdin, kwargs): |
| 214 | p = subprocess.Popen(cmd, **kwargs) |
| 215 | with Timer(self.timeout, p.terminate) as timer: |
| 216 | stdout, _ = sigint_handler.wait(p, stdin) |
Josip Sokcevic | 6635baf | 2021-11-19 02:04:39 +0000 | [diff] [blame] | 217 | stdout = stdout.decode('utf-8', 'ignore') |
Edward Lemur | ecc2707 | 2020-01-06 16:42:34 +0000 | [diff] [blame] | 218 | if timer.completed: |
| 219 | stdout = 'Process timed out after %ss\n%s' % (self.timeout, stdout) |
Josip Sokcevic | 6635baf | 2021-11-19 02:04:39 +0000 | [diff] [blame] | 220 | return p.returncode, stdout |
Edward Lemur | ecc2707 | 2020-01-06 16:42:34 +0000 | [diff] [blame] | 221 | |
| 222 | def CallCommand(self, test): |
| 223 | """Runs an external program. |
| 224 | |
Edward Lemur | a5799e3 | 2020-01-17 19:26:51 +0000 | [diff] [blame] | 225 | This function converts invocation of .py files and invocations of 'python' |
Edward Lemur | ecc2707 | 2020-01-06 16:42:34 +0000 | [diff] [blame] | 226 | to vpython invocations. |
| 227 | """ |
| 228 | cmd = self._GetCommand(test) |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 229 | try: |
Edward Lemur | ecc2707 | 2020-01-06 16:42:34 +0000 | [diff] [blame] | 230 | start = time_time() |
| 231 | returncode, stdout = self._RunWithTimeout(cmd, test.stdin, test.kwargs) |
| 232 | duration = time_time() - start |
Edward Lemur | 7cf9438 | 2019-11-15 22:36:41 +0000 | [diff] [blame] | 233 | except Exception: |
Edward Lemur | ecc2707 | 2020-01-06 16:42:34 +0000 | [diff] [blame] | 234 | duration = time_time() - start |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 235 | return test.message( |
Edward Lemur | 7cf9438 | 2019-11-15 22:36:41 +0000 | [diff] [blame] | 236 | '%s\n%s exec failure (%4.2fs)\n%s' % ( |
| 237 | test.name, ' '.join(cmd), duration, traceback.format_exc())) |
Edward Lemur | de9e3ca | 2019-10-24 21:13:31 +0000 | [diff] [blame] | 238 | |
Edward Lemur | ecc2707 | 2020-01-06 16:42:34 +0000 | [diff] [blame] | 239 | if returncode != 0: |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 240 | return test.message( |
Edward Lemur | 7cf9438 | 2019-11-15 22:36:41 +0000 | [diff] [blame] | 241 | '%s\n%s (%4.2fs) failed\n%s' % ( |
| 242 | test.name, ' '.join(cmd), duration, stdout)) |
Edward Lemur | ecc2707 | 2020-01-06 16:42:34 +0000 | [diff] [blame] | 243 | |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 244 | if test.info: |
Edward Lemur | 7cf9438 | 2019-11-15 22:36:41 +0000 | [diff] [blame] | 245 | return test.info('%s\n%s (%4.2fs)' % (test.name, ' '.join(cmd), duration)) |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 246 | |
| 247 | def AddTests(self, tests, parallel=True): |
| 248 | if parallel: |
| 249 | self._tests.extend(tests) |
| 250 | else: |
| 251 | self._nonparallel_tests.extend(tests) |
| 252 | |
| 253 | def RunAsync(self): |
| 254 | self._messages = [] |
| 255 | |
| 256 | def _WorkerFn(): |
| 257 | while True: |
| 258 | test = None |
| 259 | with self._tests_lock: |
| 260 | if not self._tests: |
| 261 | break |
| 262 | test = self._tests.pop() |
| 263 | result = self.CallCommand(test) |
| 264 | if result: |
| 265 | with self._messages_lock: |
| 266 | self._messages.append(result) |
| 267 | |
| 268 | def _StartDaemon(): |
| 269 | t = threading.Thread(target=_WorkerFn) |
| 270 | t.daemon = True |
| 271 | t.start() |
| 272 | return t |
| 273 | |
| 274 | while self._nonparallel_tests: |
| 275 | test = self._nonparallel_tests.pop() |
| 276 | result = self.CallCommand(test) |
| 277 | if result: |
| 278 | self._messages.append(result) |
| 279 | |
| 280 | if self._tests: |
| 281 | threads = [_StartDaemon() for _ in range(self._pool_size)] |
| 282 | for worker in threads: |
| 283 | worker.join() |
| 284 | |
| 285 | return self._messages |
| 286 | |
| 287 | |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 288 | def normpath(path): |
| 289 | '''Version of os.path.normpath that also changes backward slashes to |
| 290 | forward slashes when not running on Windows. |
| 291 | ''' |
| 292 | # This is safe to always do because the Windows version of os.path.normpath |
| 293 | # will replace forward slashes with backward slashes. |
| 294 | path = path.replace(os.sep, '/') |
| 295 | return os.path.normpath(path) |
| 296 | |
maruel@chromium.org | cb2985f | 2010-11-03 14:08:31 +0000 | [diff] [blame] | 297 | |
maruel@chromium.org | cb2985f | 2010-11-03 14:08:31 +0000 | [diff] [blame] | 298 | def _RightHandSideLinesImpl(affected_files): |
| 299 | """Implements RightHandSideLines for InputApi and GclChange.""" |
| 300 | for af in affected_files: |
maruel@chromium.org | ab05d58 | 2011-02-09 23:41:22 +0000 | [diff] [blame] | 301 | lines = af.ChangedContents() |
maruel@chromium.org | cb2985f | 2010-11-03 14:08:31 +0000 | [diff] [blame] | 302 | for line in lines: |
maruel@chromium.org | ab05d58 | 2011-02-09 23:41:22 +0000 | [diff] [blame] | 303 | yield (af, line[0], line[1]) |
maruel@chromium.org | cb2985f | 2010-11-03 14:08:31 +0000 | [diff] [blame] | 304 | |
| 305 | |
Edward Lemur | 6eb1d32 | 2020-02-27 22:20:15 +0000 | [diff] [blame] | 306 | def prompt_should_continue(prompt_string): |
| 307 | sys.stdout.write(prompt_string) |
Dirk Pranke | 7288f88 | 2021-06-03 18:01:30 +0000 | [diff] [blame] | 308 | sys.stdout.flush() |
Edward Lemur | 6eb1d32 | 2020-02-27 22:20:15 +0000 | [diff] [blame] | 309 | response = sys.stdin.readline().strip().lower() |
| 310 | return response in ('y', 'yes') |
dpranke@chromium.org | 5ac2101 | 2011-03-16 02:58:25 +0000 | [diff] [blame] | 311 | |
| 312 | |
Josip Sokcevic | e293d3d | 2022-02-16 22:52:15 +0000 | [diff] [blame] | 313 | def _ShouldRunPresubmit(script_text, use_python3): |
| 314 | """Try to figure out whether these presubmit checks should be run under |
| 315 | python2 or python3. We need to do this without actually trying to |
| 316 | compile the text, since the text might compile in one but not the |
| 317 | other. |
| 318 | |
| 319 | Args: |
| 320 | script_text: The text of the presubmit script. |
| 321 | use_python3: if true, will use python3 instead of python2 by default |
| 322 | if USE_PYTHON3 is not specified. |
| 323 | |
| 324 | Return: |
| 325 | A boolean if presubmit should be executed |
| 326 | """ |
Josip Sokcevic | 884d716 | 2023-01-19 21:17:56 +0000 | [diff] [blame] | 327 | if os.getenv('LUCI_OMIT_PYTHON2') == 'true': |
| 328 | # If LUCI omits python2, run all presubmits with python3, regardless of |
| 329 | # USE_PYTHON3 variable. |
| 330 | return True |
| 331 | |
Josip Sokcevic | e293d3d | 2022-02-16 22:52:15 +0000 | [diff] [blame] | 332 | m = re.search('^USE_PYTHON3 = (True|False)$', script_text, flags=re.MULTILINE) |
| 333 | if m: |
| 334 | use_python3 = m.group(1) == 'True' |
| 335 | |
| 336 | return ((sys.version_info.major == 2) and not use_python3) or \ |
| 337 | ((sys.version_info.major == 3) and use_python3) |
| 338 | |
ilevy@chromium.org | bc11731 | 2013-04-20 03:57:56 +0000 | [diff] [blame] | 339 | # Top level object so multiprocessing can pickle |
| 340 | # Public access through OutputApi object. |
| 341 | class _PresubmitResult(object): |
| 342 | """Base class for result objects.""" |
| 343 | fatal = False |
| 344 | should_prompt = False |
| 345 | |
| 346 | def __init__(self, message, items=None, long_text=''): |
| 347 | """ |
| 348 | message: A short one-line message to indicate errors. |
| 349 | items: A list of short strings to indicate where errors occurred. |
| 350 | long_text: multi-line text output, e.g. from another tool |
| 351 | """ |
Bruce Dawson | db8622b | 2022-04-03 15:38:12 +0000 | [diff] [blame] | 352 | self._message = _PresubmitResult._ensure_str(message) |
ilevy@chromium.org | bc11731 | 2013-04-20 03:57:56 +0000 | [diff] [blame] | 353 | self._items = items or [] |
Tom McKee | 61c7265 | 2021-07-20 11:56:32 +0000 | [diff] [blame] | 354 | self._long_text = _PresubmitResult._ensure_str(long_text.rstrip()) |
Bruce Dawson | dca14bc | 2022-09-15 20:59:38 +0000 | [diff] [blame] | 355 | if _SHOW_CALLSTACKS: |
| 356 | self._long_text += 'Presubmit result call stack is:\n' |
| 357 | self._long_text += ''.join(traceback.format_stack(None, 8)) |
Tom McKee | 61c7265 | 2021-07-20 11:56:32 +0000 | [diff] [blame] | 358 | |
| 359 | @staticmethod |
| 360 | def _ensure_str(val): |
| 361 | """ |
| 362 | val: A "stringish" value. Can be any of str, unicode or bytes. |
| 363 | returns: A str after applying encoding/decoding as needed. |
| 364 | Assumes/uses UTF-8 for relevant inputs/outputs. |
| 365 | |
| 366 | We'd prefer to use six.ensure_str but our copy of six is old :( |
| 367 | """ |
| 368 | if isinstance(val, str): |
| 369 | return val |
Aravind Vasudevan | c5f0cbb | 2022-01-24 23:56:57 +0000 | [diff] [blame] | 370 | |
Tom McKee | 61c7265 | 2021-07-20 11:56:32 +0000 | [diff] [blame] | 371 | if six.PY2 and isinstance(val, unicode): |
| 372 | return val.encode() |
Aravind Vasudevan | c5f0cbb | 2022-01-24 23:56:57 +0000 | [diff] [blame] | 373 | |
| 374 | if six.PY3 and isinstance(val, bytes): |
Tom McKee | 61c7265 | 2021-07-20 11:56:32 +0000 | [diff] [blame] | 375 | return val.decode() |
| 376 | raise ValueError("Unknown string type %s" % type(val)) |
ilevy@chromium.org | bc11731 | 2013-04-20 03:57:56 +0000 | [diff] [blame] | 377 | |
Edward Lemur | 6eb1d32 | 2020-02-27 22:20:15 +0000 | [diff] [blame] | 378 | def handle(self): |
| 379 | sys.stdout.write(self._message) |
| 380 | sys.stdout.write('\n') |
Takuto Ikuta | baa7be0 | 2022-08-23 00:19:34 +0000 | [diff] [blame] | 381 | for item in self._items: |
Edward Lemur | 6eb1d32 | 2020-02-27 22:20:15 +0000 | [diff] [blame] | 382 | sys.stdout.write(' ') |
ilevy@chromium.org | bc11731 | 2013-04-20 03:57:56 +0000 | [diff] [blame] | 383 | # Write separately in case it's unicode. |
Edward Lemur | 6eb1d32 | 2020-02-27 22:20:15 +0000 | [diff] [blame] | 384 | sys.stdout.write(str(item)) |
Edward Lemur | 6eb1d32 | 2020-02-27 22:20:15 +0000 | [diff] [blame] | 385 | sys.stdout.write('\n') |
ilevy@chromium.org | bc11731 | 2013-04-20 03:57:56 +0000 | [diff] [blame] | 386 | if self._long_text: |
Edward Lemur | 6eb1d32 | 2020-02-27 22:20:15 +0000 | [diff] [blame] | 387 | sys.stdout.write('\n***************\n') |
ilevy@chromium.org | bc11731 | 2013-04-20 03:57:56 +0000 | [diff] [blame] | 388 | # Write separately in case it's unicode. |
Tom McKee | 61c7265 | 2021-07-20 11:56:32 +0000 | [diff] [blame] | 389 | sys.stdout.write(self._long_text) |
Edward Lemur | 6eb1d32 | 2020-02-27 22:20:15 +0000 | [diff] [blame] | 390 | sys.stdout.write('\n***************\n') |
ilevy@chromium.org | bc11731 | 2013-04-20 03:57:56 +0000 | [diff] [blame] | 391 | |
Debrian Figueroa | dd2737e | 2019-06-21 23:50:13 +0000 | [diff] [blame] | 392 | def json_format(self): |
| 393 | return { |
| 394 | 'message': self._message, |
Debrian Figueroa | 6095d40 | 2019-06-28 18:47:18 +0000 | [diff] [blame] | 395 | 'items': [str(item) for item in self._items], |
Debrian Figueroa | dd2737e | 2019-06-21 23:50:13 +0000 | [diff] [blame] | 396 | 'long_text': self._long_text, |
| 397 | 'fatal': self.fatal |
| 398 | } |
| 399 | |
ilevy@chromium.org | bc11731 | 2013-04-20 03:57:56 +0000 | [diff] [blame] | 400 | |
| 401 | # Top level object so multiprocessing can pickle |
| 402 | # Public access through OutputApi object. |
ilevy@chromium.org | bc11731 | 2013-04-20 03:57:56 +0000 | [diff] [blame] | 403 | class _PresubmitError(_PresubmitResult): |
| 404 | """A hard presubmit error.""" |
| 405 | fatal = True |
| 406 | |
| 407 | |
| 408 | # Top level object so multiprocessing can pickle |
| 409 | # Public access through OutputApi object. |
| 410 | class _PresubmitPromptWarning(_PresubmitResult): |
| 411 | """An warning that prompts the user if they want to continue.""" |
| 412 | should_prompt = True |
| 413 | |
| 414 | |
| 415 | # Top level object so multiprocessing can pickle |
| 416 | # Public access through OutputApi object. |
| 417 | class _PresubmitNotifyResult(_PresubmitResult): |
| 418 | """Just print something to the screen -- but it's not even a warning.""" |
ilevy@chromium.org | bc11731 | 2013-04-20 03:57:56 +0000 | [diff] [blame] | 419 | |
| 420 | |
| 421 | # Top level object so multiprocessing can pickle |
| 422 | # Public access through OutputApi object. |
| 423 | class _MailTextResult(_PresubmitResult): |
| 424 | """A warning that should be included in the review request email.""" |
| 425 | def __init__(self, *args, **kwargs): |
| 426 | super(_MailTextResult, self).__init__() |
| 427 | raise NotImplementedError() |
| 428 | |
tandrii@chromium.org | 37b07a7 | 2016-04-29 16:42:28 +0000 | [diff] [blame] | 429 | class GerritAccessor(object): |
| 430 | """Limited Gerrit functionality for canned presubmit checks to work. |
| 431 | |
| 432 | To avoid excessive Gerrit calls, caches the results. |
| 433 | """ |
| 434 | |
Edward Lesmes | eb1bd62 | 2021-03-01 19:54:07 +0000 | [diff] [blame] | 435 | def __init__(self, url=None, project=None, branch=None): |
| 436 | self.host = urlparse.urlparse(url).netloc if url else None |
| 437 | self.project = project |
| 438 | self.branch = branch |
tandrii@chromium.org | 37b07a7 | 2016-04-29 16:42:28 +0000 | [diff] [blame] | 439 | self.cache = {} |
Edward Lesmes | 8170c29 | 2021-03-19 20:04:43 +0000 | [diff] [blame] | 440 | self.code_owners_enabled = None |
tandrii@chromium.org | 37b07a7 | 2016-04-29 16:42:28 +0000 | [diff] [blame] | 441 | |
| 442 | def _FetchChangeDetail(self, issue): |
| 443 | # Separate function to be easily mocked in tests. |
Andrii Shyshkalov | c6c8b4c | 2016-11-09 20:51:20 +0100 | [diff] [blame] | 444 | try: |
| 445 | return gerrit_util.GetChangeDetail( |
| 446 | self.host, str(issue), |
Aaron Gable | 6f5a8d9 | 2017-04-18 14:49:05 -0700 | [diff] [blame] | 447 | ['ALL_REVISIONS', 'DETAILED_LABELS', 'ALL_COMMITS']) |
Andrii Shyshkalov | c6c8b4c | 2016-11-09 20:51:20 +0100 | [diff] [blame] | 448 | except gerrit_util.GerritError as e: |
| 449 | if e.http_status == 404: |
| 450 | raise Exception('Either Gerrit issue %s doesn\'t exist, or ' |
| 451 | 'no credentials to fetch issue details' % issue) |
| 452 | raise |
tandrii@chromium.org | 37b07a7 | 2016-04-29 16:42:28 +0000 | [diff] [blame] | 453 | |
| 454 | def GetChangeInfo(self, issue): |
| 455 | """Returns labels and all revisions (patchsets) for this issue. |
| 456 | |
| 457 | The result is a dictionary according to Gerrit REST Api. |
| 458 | https://gerrit-review.googlesource.com/Documentation/rest-api.html |
| 459 | |
| 460 | However, API isn't very clear what's inside, so see tests for example. |
| 461 | """ |
| 462 | assert issue |
| 463 | cache_key = int(issue) |
| 464 | if cache_key not in self.cache: |
| 465 | self.cache[cache_key] = self._FetchChangeDetail(issue) |
| 466 | return self.cache[cache_key] |
| 467 | |
| 468 | def GetChangeDescription(self, issue, patchset=None): |
| 469 | """If patchset is none, fetches current patchset.""" |
| 470 | info = self.GetChangeInfo(issue) |
| 471 | # info is a reference to cache. We'll modify it here adding description to |
| 472 | # it to the right patchset, if it is not yet there. |
| 473 | |
| 474 | # Find revision info for the patchset we want. |
| 475 | if patchset is not None: |
Marc-Antoine Ruel | 8e57b4b | 2019-10-11 01:01:36 +0000 | [diff] [blame] | 476 | for rev, rev_info in info['revisions'].items(): |
tandrii@chromium.org | 37b07a7 | 2016-04-29 16:42:28 +0000 | [diff] [blame] | 477 | if str(rev_info['_number']) == str(patchset): |
| 478 | break |
| 479 | else: |
| 480 | raise Exception('patchset %s doesn\'t exist in issue %s' % ( |
| 481 | patchset, issue)) |
| 482 | else: |
| 483 | rev = info['current_revision'] |
| 484 | rev_info = info['revisions'][rev] |
| 485 | |
Andrii Shyshkalov | 9c3a464 | 2017-01-24 17:41:22 +0100 | [diff] [blame] | 486 | return rev_info['commit']['message'] |
tandrii@chromium.org | 37b07a7 | 2016-04-29 16:42:28 +0000 | [diff] [blame] | 487 | |
Mun Yong Jang | 603d01e | 2017-12-19 16:38:30 -0800 | [diff] [blame] | 488 | def GetDestRef(self, issue): |
| 489 | ref = self.GetChangeInfo(issue)['branch'] |
| 490 | if not ref.startswith('refs/'): |
| 491 | # NOTE: it is possible to create 'refs/x' branch, |
| 492 | # aka 'refs/heads/refs/x'. However, this is ill-advised. |
| 493 | ref = 'refs/heads/%s' % ref |
| 494 | return ref |
| 495 | |
Edward Lesmes | 02d4b82 | 2020-11-11 00:37:35 +0000 | [diff] [blame] | 496 | def _GetApproversForLabel(self, issue, label): |
| 497 | change_info = self.GetChangeInfo(issue) |
| 498 | label_info = change_info.get('labels', {}).get(label, {}) |
| 499 | values = label_info.get('values', {}).keys() |
| 500 | if not values: |
| 501 | return [] |
| 502 | max_value = max(int(v) for v in values) |
| 503 | return [v for v in label_info.get('all', []) |
| 504 | if v.get('value', 0) == max_value] |
| 505 | |
Edward Lesmes | c456617 | 2021-03-19 16:55:13 +0000 | [diff] [blame] | 506 | def IsBotCommitApproved(self, issue): |
| 507 | return bool(self._GetApproversForLabel(issue, 'Bot-Commit')) |
| 508 | |
Edward Lesmes | cf49cb8 | 2020-11-11 01:08:36 +0000 | [diff] [blame] | 509 | def IsOwnersOverrideApproved(self, issue): |
| 510 | return bool(self._GetApproversForLabel(issue, 'Owners-Override')) |
| 511 | |
tandrii@chromium.org | 37b07a7 | 2016-04-29 16:42:28 +0000 | [diff] [blame] | 512 | def GetChangeOwner(self, issue): |
| 513 | return self.GetChangeInfo(issue)['owner']['email'] |
| 514 | |
| 515 | def GetChangeReviewers(self, issue, approving_only=True): |
Aaron Gable | 8b478f0 | 2017-07-31 15:33:19 -0700 | [diff] [blame] | 516 | changeinfo = self.GetChangeInfo(issue) |
| 517 | if approving_only: |
Edward Lesmes | 02d4b82 | 2020-11-11 00:37:35 +0000 | [diff] [blame] | 518 | reviewers = self._GetApproversForLabel(issue, 'Code-Review') |
Aaron Gable | 8b478f0 | 2017-07-31 15:33:19 -0700 | [diff] [blame] | 519 | else: |
| 520 | reviewers = changeinfo.get('reviewers', {}).get('REVIEWER', []) |
| 521 | return [r.get('email') for r in reviewers] |
tandrii@chromium.org | 37b07a7 | 2016-04-29 16:42:28 +0000 | [diff] [blame] | 522 | |
Edward Lemur | e4d329c | 2020-02-03 20:41:18 +0000 | [diff] [blame] | 523 | def UpdateDescription(self, description, issue): |
| 524 | gerrit_util.SetCommitMessage(self.host, issue, description, notify='NONE') |
| 525 | |
Edward Lesmes | 8170c29 | 2021-03-19 20:04:43 +0000 | [diff] [blame] | 526 | def IsCodeOwnersEnabledOnRepo(self): |
| 527 | if self.code_owners_enabled is None: |
| 528 | self.code_owners_enabled = gerrit_util.IsCodeOwnersEnabledOnRepo( |
Edward Lesmes | 392c407 | 2021-03-19 21:58:45 +0000 | [diff] [blame] | 529 | self.host, self.project) |
Edward Lesmes | 8170c29 | 2021-03-19 20:04:43 +0000 | [diff] [blame] | 530 | return self.code_owners_enabled |
| 531 | |
ilevy@chromium.org | bc11731 | 2013-04-20 03:57:56 +0000 | [diff] [blame] | 532 | |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 533 | class OutputApi(object): |
wez@chromium.org | a6d011e | 2013-03-26 17:31:49 +0000 | [diff] [blame] | 534 | """An instance of OutputApi gets passed to presubmit scripts so that they |
| 535 | can output various types of results. |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 536 | """ |
ilevy@chromium.org | bc11731 | 2013-04-20 03:57:56 +0000 | [diff] [blame] | 537 | PresubmitResult = _PresubmitResult |
ilevy@chromium.org | bc11731 | 2013-04-20 03:57:56 +0000 | [diff] [blame] | 538 | PresubmitError = _PresubmitError |
| 539 | PresubmitPromptWarning = _PresubmitPromptWarning |
| 540 | PresubmitNotifyResult = _PresubmitNotifyResult |
| 541 | MailTextResult = _MailTextResult |
| 542 | |
wez@chromium.org | a6d011e | 2013-03-26 17:31:49 +0000 | [diff] [blame] | 543 | def __init__(self, is_committing): |
| 544 | self.is_committing = is_committing |
Daniel Cheng | 7227d21 | 2017-11-17 08:12:37 -0800 | [diff] [blame] | 545 | self.more_cc = [] |
| 546 | |
| 547 | def AppendCC(self, cc): |
| 548 | """Appends a user to cc for this change.""" |
Daniel Cheng | 0e9f668 | 2022-10-19 17:42:57 +0000 | [diff] [blame] | 549 | if cc not in self.more_cc: |
| 550 | self.more_cc.append(cc) |
wez@chromium.org | a6d011e | 2013-03-26 17:31:49 +0000 | [diff] [blame] | 551 | |
wez@chromium.org | a6d011e | 2013-03-26 17:31:49 +0000 | [diff] [blame] | 552 | def PresubmitPromptOrNotify(self, *args, **kwargs): |
| 553 | """Warn the user when uploading, but only notify if committing.""" |
| 554 | if self.is_committing: |
| 555 | return self.PresubmitNotifyResult(*args, **kwargs) |
| 556 | return self.PresubmitPromptWarning(*args, **kwargs) |
| 557 | |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 558 | |
| 559 | class InputApi(object): |
| 560 | """An instance of this object is passed to presubmit scripts so they can |
| 561 | know stuff about the change they're looking at. |
| 562 | """ |
maruel@chromium.org | b17b55b | 2010-11-03 14:42:37 +0000 | [diff] [blame] | 563 | # Method could be a function |
Quinten Yearsley | b2cc4a9 | 2016-12-15 13:53:26 -0800 | [diff] [blame] | 564 | # pylint: disable=no-self-use |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 565 | |
maruel@chromium.org | 3410d91 | 2009-06-09 20:56:16 +0000 | [diff] [blame] | 566 | # File extensions that are considered source files from a style guide |
| 567 | # perspective. Don't modify this list from a presubmit script! |
maruel@chromium.org | c33455a | 2011-06-24 19:14:18 +0000 | [diff] [blame] | 568 | # |
| 569 | # Files without an extension aren't included in the list. If you want to |
local_bot | 30f774e | 2020-06-25 18:23:34 +0000 | [diff] [blame] | 570 | # filter them as source files, add r'(^|.*?[\\\/])[^.]+$' to the allow list. |
local_bot | 6402141 | 2020-07-08 21:05:39 +0000 | [diff] [blame] | 571 | # Note that ALL CAPS files are skipped in DEFAULT_FILES_TO_SKIP below. |
| 572 | DEFAULT_FILES_TO_CHECK = ( |
maruel@chromium.org | 3410d91 | 2009-06-09 20:56:16 +0000 | [diff] [blame] | 573 | # C++ and friends |
Edward Lemur | a5799e3 | 2020-01-17 19:26:51 +0000 | [diff] [blame] | 574 | r'.+\.c$', r'.+\.cc$', r'.+\.cpp$', r'.+\.h$', r'.+\.m$', r'.+\.mm$', |
| 575 | r'.+\.inl$', r'.+\.asm$', r'.+\.hxx$', r'.+\.hpp$', r'.+\.s$', r'.+\.S$', |
maruel@chromium.org | 3410d91 | 2009-06-09 20:56:16 +0000 | [diff] [blame] | 576 | # Scripts |
dpapad | 443d913 | 2022-05-05 00:17:30 +0000 | [diff] [blame] | 577 | r'.+\.js$', r'.+\.ts$', r'.+\.py$', r'.+\.sh$', r'.+\.rb$', r'.+\.pl$', |
| 578 | r'.+\.pm$', |
maruel@chromium.org | 3410d91 | 2009-06-09 20:56:16 +0000 | [diff] [blame] | 579 | # Other |
Edward Lemur | a5799e3 | 2020-01-17 19:26:51 +0000 | [diff] [blame] | 580 | r'.+\.java$', r'.+\.mk$', r'.+\.am$', r'.+\.css$', r'.+\.mojom$', |
Bruce Dawson | 7a81ebf | 2023-01-03 18:36:18 +0000 | [diff] [blame] | 581 | r'.+\.fidl$', r'.+\.rs$', |
maruel@chromium.org | 3410d91 | 2009-06-09 20:56:16 +0000 | [diff] [blame] | 582 | ) |
| 583 | |
| 584 | # Path regexp that should be excluded from being considered containing source |
| 585 | # files. Don't modify this list from a presubmit script! |
local_bot | 6402141 | 2020-07-08 21:05:39 +0000 | [diff] [blame] | 586 | DEFAULT_FILES_TO_SKIP = ( |
Edward Lemur | a5799e3 | 2020-01-17 19:26:51 +0000 | [diff] [blame] | 587 | r'testing_support[\\\/]google_appengine[\\\/].*', |
| 588 | r'.*\bexperimental[\\\/].*', |
Kent Tamura | 179dd1e | 2018-04-26 15:07:41 +0900 | [diff] [blame] | 589 | # Exclude third_party/.* but NOT third_party/{WebKit,blink} |
| 590 | # (crbug.com/539768 and crbug.com/836555). |
Edward Lemur | a5799e3 | 2020-01-17 19:26:51 +0000 | [diff] [blame] | 591 | r'.*\bthird_party[\\\/](?!(WebKit|blink)[\\\/]).*', |
maruel@chromium.org | 3410d91 | 2009-06-09 20:56:16 +0000 | [diff] [blame] | 592 | # Output directories (just in case) |
Edward Lemur | a5799e3 | 2020-01-17 19:26:51 +0000 | [diff] [blame] | 593 | r'.*\bDebug[\\\/].*', |
| 594 | r'.*\bRelease[\\\/].*', |
| 595 | r'.*\bxcodebuild[\\\/].*', |
| 596 | r'.*\bout[\\\/].*', |
maruel@chromium.org | 3410d91 | 2009-06-09 20:56:16 +0000 | [diff] [blame] | 597 | # All caps files like README and LICENCE. |
Edward Lemur | a5799e3 | 2020-01-17 19:26:51 +0000 | [diff] [blame] | 598 | r'.*\b[A-Z0-9_]{2,}$', |
maruel@chromium.org | df1595a | 2009-06-11 02:00:13 +0000 | [diff] [blame] | 599 | # SCM (can happen in dual SCM configuration). (Slightly over aggressive) |
Edward Lemur | a5799e3 | 2020-01-17 19:26:51 +0000 | [diff] [blame] | 600 | r'(|.*[\\\/])\.git[\\\/].*', |
| 601 | r'(|.*[\\\/])\.svn[\\\/].*', |
maruel@chromium.org | 7ccb4bb | 2011-11-07 20:26:20 +0000 | [diff] [blame] | 602 | # There is no point in processing a patch file. |
Edward Lemur | a5799e3 | 2020-01-17 19:26:51 +0000 | [diff] [blame] | 603 | r'.+\.diff$', |
| 604 | r'.+\.patch$', |
maruel@chromium.org | 3410d91 | 2009-06-09 20:56:16 +0000 | [diff] [blame] | 605 | ) |
| 606 | |
maruel@chromium.org | cc73ad6 | 2011-07-06 17:39:26 +0000 | [diff] [blame] | 607 | def __init__(self, change, presubmit_path, is_committing, |
Bruce Dawson | 09c0c07 | 2022-05-26 20:28:58 +0000 | [diff] [blame] | 608 | verbose, gerrit_obj, dry_run=None, thread_pool=None, parallel=False, |
| 609 | no_diffs=False): |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 610 | """Builds an InputApi object. |
| 611 | |
| 612 | Args: |
maruel@chromium.org | 4ff922a | 2009-06-12 20:20:19 +0000 | [diff] [blame] | 613 | change: A presubmit.Change object. |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 614 | presubmit_path: The path to the presubmit script being processed. |
maruel@chromium.org | d7dccf5 | 2009-06-06 18:51:58 +0000 | [diff] [blame] | 615 | is_committing: True if the change is about to be committed. |
tandrii@chromium.org | 37b07a7 | 2016-04-29 16:42:28 +0000 | [diff] [blame] | 616 | gerrit_obj: provides basic Gerrit codereview functionality. |
| 617 | dry_run: if true, some Checks will be skipped. |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 618 | parallel: if true, all tests reported via input_api.RunTests for all |
| 619 | PRESUBMIT files will be run in parallel. |
Bruce Dawson | 09c0c07 | 2022-05-26 20:28:58 +0000 | [diff] [blame] | 620 | no_diffs: if true, implies that --files or --all was specified so some |
| 621 | checks can be skipped, and some errors will be messages. |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 622 | """ |
maruel@chromium.org | 9711bba | 2009-05-22 23:51:39 +0000 | [diff] [blame] | 623 | # Version number of the presubmit_support script. |
| 624 | self.version = [int(x) for x in __version__.split('.')] |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 625 | self.change = change |
maruel@chromium.org | d7dccf5 | 2009-06-06 18:51:58 +0000 | [diff] [blame] | 626 | self.is_committing = is_committing |
tandrii@chromium.org | 37b07a7 | 2016-04-29 16:42:28 +0000 | [diff] [blame] | 627 | self.gerrit = gerrit_obj |
tandrii@chromium.org | 57bafac | 2016-04-28 05:09:03 +0000 | [diff] [blame] | 628 | self.dry_run = dry_run |
Bruce Dawson | 09c0c07 | 2022-05-26 20:28:58 +0000 | [diff] [blame] | 629 | self.no_diffs = no_diffs |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 630 | |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 631 | self.parallel = parallel |
| 632 | self.thread_pool = thread_pool or ThreadPool() |
| 633 | |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 634 | # We expose various modules and functions as attributes of the input_api |
| 635 | # so that presubmit scripts don't have to import them. |
Takeshi Yoshino | 07a6bea | 2017-08-02 02:44:06 +0900 | [diff] [blame] | 636 | self.ast = ast |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 637 | self.basename = os.path.basename |
enne@chromium.org | e72c5f5 | 2013-04-16 00:36:40 +0000 | [diff] [blame] | 638 | self.cpplint = cpplint |
dcheng | 091b7db | 2016-06-16 01:27:51 -0700 | [diff] [blame] | 639 | self.fnmatch = fnmatch |
Yoshisato Yanagisawa | 04600b4 | 2019-03-15 03:03:41 +0000 | [diff] [blame] | 640 | self.gclient_paths = gclient_paths |
Yoshisato Yanagisawa | 57dd17b | 2019-03-22 09:10:29 +0000 | [diff] [blame] | 641 | # TODO(yyanagisawa): stop exposing this when python3 become default. |
| 642 | # Since python3's tempfile has TemporaryDirectory, we do not need this. |
| 643 | self.temporary_directory = gclient_utils.temporary_directory |
dpranke@chromium.org | 17cc244 | 2012-10-17 21:12:09 +0000 | [diff] [blame] | 644 | self.glob = glob.glob |
maruel@chromium.org | fb11c7b | 2010-03-18 18:22:14 +0000 | [diff] [blame] | 645 | self.json = json |
maruel@chromium.org | 6fba34d | 2011-06-02 13:45:12 +0000 | [diff] [blame] | 646 | self.logging = logging.getLogger('PRESUBMIT') |
maruel@chromium.org | 2b5ce56 | 2011-03-31 16:15:44 +0000 | [diff] [blame] | 647 | self.os_listdir = os.listdir |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 648 | self.os_path = os.path |
pgervais@chromium.org | bd0cace | 2014-10-02 23:23:46 +0000 | [diff] [blame] | 649 | self.os_stat = os.stat |
Yoshisato Yanagisawa | 406de13 | 2018-06-29 05:43:25 +0000 | [diff] [blame] | 650 | self.os_walk = os.walk |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 651 | self.re = re |
| 652 | self.subprocess = subprocess |
Edward Lemur | b983024 | 2019-10-30 22:19:20 +0000 | [diff] [blame] | 653 | self.sys = sys |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 654 | self.tempfile = tempfile |
dpranke@chromium.org | 0d1bdea | 2011-03-24 22:54:38 +0000 | [diff] [blame] | 655 | self.time = time |
maruel@chromium.org | 1487d53 | 2009-06-06 00:22:57 +0000 | [diff] [blame] | 656 | self.unittest = unittest |
Edward Lemur | b983024 | 2019-10-30 22:19:20 +0000 | [diff] [blame] | 657 | if sys.version_info.major == 2: |
| 658 | self.urllib2 = urllib2 |
Edward Lemur | 16af356 | 2019-10-17 22:11:33 +0000 | [diff] [blame] | 659 | self.urllib_request = urllib_request |
| 660 | self.urllib_error = urllib_error |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 661 | |
Robert Iannucci | 5025893 | 2018-03-19 10:30:59 -0700 | [diff] [blame] | 662 | self.is_windows = sys.platform == 'win32' |
| 663 | |
Edward Lemur | b964662 | 2019-10-25 20:57:35 +0000 | [diff] [blame] | 664 | # Set python_executable to 'vpython' in order to allow scripts in other |
| 665 | # repos (e.g. src.git) to automatically pick up that repo's .vpython file, |
| 666 | # instead of inheriting the one in depot_tools. |
| 667 | self.python_executable = 'vpython' |
Erik Staab | 69135d1 | 2021-05-14 22:31:57 +0000 | [diff] [blame] | 668 | # Offer a python 3 executable for use during the migration off of python 2. |
| 669 | self.python3_executable = 'vpython3' |
maruel@chromium.org | c0b2297 | 2009-06-25 16:19:14 +0000 | [diff] [blame] | 670 | self.environ = os.environ |
| 671 | |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 672 | # InputApi.platform is the platform you're currently running on. |
| 673 | self.platform = sys.platform |
| 674 | |
iannucci@chromium.org | 0af3bb3 | 2015-06-12 20:44:35 +0000 | [diff] [blame] | 675 | self.cpu_count = multiprocessing.cpu_count() |
Bruce Dawson | 8254f06 | 2022-06-17 17:33:08 +0000 | [diff] [blame] | 676 | if self.is_windows: |
| 677 | # TODO(crbug.com/1190269) - we can't use more than 56 child processes on |
| 678 | # Windows or Python3 may hang. |
| 679 | self.cpu_count = min(self.cpu_count, 56) |
iannucci@chromium.org | 0af3bb3 | 2015-06-12 20:44:35 +0000 | [diff] [blame] | 680 | |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 681 | # The local path of the currently-being-processed presubmit script. |
maruel@chromium.org | 3d23524 | 2009-05-15 12:40:48 +0000 | [diff] [blame] | 682 | self._current_presubmit_path = os.path.dirname(presubmit_path) |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 683 | |
| 684 | # We carry the canned checks so presubmit scripts can easily use them. |
| 685 | self.canned_checks = presubmit_canned_checks |
| 686 | |
Raphael Kubo da Costa | f2d1615 | 2017-11-10 18:07:58 +0100 | [diff] [blame] | 687 | # Temporary files we must manually remove at the end of a run. |
| 688 | self._named_temporary_files = [] |
Jochen Eisinger | 72606f8 | 2017-04-04 10:44:18 +0200 | [diff] [blame] | 689 | |
Edward Lesmes | dc11c6b | 2021-03-19 19:22:05 +0000 | [diff] [blame] | 690 | self.owners_client = None |
Bruce Dawson | eb8426e | 2022-08-05 23:58:15 +0000 | [diff] [blame] | 691 | if self.gerrit and not 'PRESUBMIT_SKIP_NETWORK' in self.environ: |
Bruce Dawson | 9b9f451 | 2022-04-27 00:56:52 +0000 | [diff] [blame] | 692 | try: |
| 693 | self.owners_client = owners_client.GetCodeOwnersClient( |
Bruce Dawson | 9b9f451 | 2022-04-27 00:56:52 +0000 | [diff] [blame] | 694 | host=self.gerrit.host, |
| 695 | project=self.gerrit.project, |
| 696 | branch=self.gerrit.branch) |
| 697 | except Exception as e: |
| 698 | print('Failed to set owners_client - %s' % str(e)) |
Jochen Eisinger | 76f5fc6 | 2017-04-07 16:27:46 +0200 | [diff] [blame] | 699 | self.owners_finder = owners_finder.OwnersFinder |
maruel@chromium.org | 899e1c1 | 2011-04-07 17:03:18 +0000 | [diff] [blame] | 700 | self.verbose = verbose |
ilevy@chromium.org | bc11731 | 2013-04-20 03:57:56 +0000 | [diff] [blame] | 701 | self.Command = CommandData |
dpranke@chromium.org | 2a00962 | 2011-03-01 02:43:31 +0000 | [diff] [blame] | 702 | |
enne@chromium.org | e72c5f5 | 2013-04-16 00:36:40 +0000 | [diff] [blame] | 703 | # Replace <hash_map> and <hash_set> as headers that need to be included |
Edward Lemur | a5799e3 | 2020-01-17 19:26:51 +0000 | [diff] [blame] | 704 | # with 'base/containers/hash_tables.h' instead. |
enne@chromium.org | e72c5f5 | 2013-04-16 00:36:40 +0000 | [diff] [blame] | 705 | # Access to a protected member _XX of a client class |
Quinten Yearsley | b2cc4a9 | 2016-12-15 13:53:26 -0800 | [diff] [blame] | 706 | # pylint: disable=protected-access |
enne@chromium.org | e72c5f5 | 2013-04-16 00:36:40 +0000 | [diff] [blame] | 707 | self.cpplint._re_pattern_templates = [ |
danakj@chromium.org | 1827852 | 2013-06-11 22:42:32 +0000 | [diff] [blame] | 708 | (a, b, 'base/containers/hash_tables.h') |
enne@chromium.org | e72c5f5 | 2013-04-16 00:36:40 +0000 | [diff] [blame] | 709 | if header in ('<hash_map>', '<hash_set>') else (a, b, header) |
| 710 | for (a, b, header) in cpplint._re_pattern_templates |
| 711 | ] |
| 712 | |
Edward Lemur | ecc2707 | 2020-01-06 16:42:34 +0000 | [diff] [blame] | 713 | def SetTimeout(self, timeout): |
| 714 | self.thread_pool.timeout = timeout |
| 715 | |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 716 | def PresubmitLocalPath(self): |
| 717 | """Returns the local path of the presubmit script currently being run. |
| 718 | |
| 719 | This is useful if you don't want to hard-code absolute paths in the |
| 720 | presubmit script. For example, It can be used to find another file |
| 721 | relative to the PRESUBMIT.py script, so the whole tree can be branched and |
| 722 | the presubmit script still works, without editing its content. |
| 723 | """ |
maruel@chromium.org | 3d23524 | 2009-05-15 12:40:48 +0000 | [diff] [blame] | 724 | return self._current_presubmit_path |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 725 | |
agable | 0b65e73 | 2016-11-22 09:25:46 -0800 | [diff] [blame] | 726 | def AffectedFiles(self, include_deletes=True, file_filter=None): |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 727 | """Same as input_api.change.AffectedFiles() except only lists files |
| 728 | (and optionally directories) in the same directory as the current presubmit |
Bruce Dawson | 7a0b07a | 2020-04-23 17:14:40 +0000 | [diff] [blame] | 729 | script, or subdirectories thereof. Note that files are listed using the OS |
| 730 | path separator, so backslashes are used as separators on Windows. |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 731 | """ |
Bruce Dawson | 31bfd51 | 2022-05-10 23:19:39 +0000 | [diff] [blame] | 732 | dir_with_slash = normpath(self.PresubmitLocalPath()) |
| 733 | # normpath strips trailing path separators, so the trailing separator has to |
| 734 | # be added after the normpath call. |
| 735 | if len(dir_with_slash) > 0: |
| 736 | dir_with_slash += os.path.sep |
sail@chromium.org | 5538e02 | 2011-05-12 17:53:16 +0000 | [diff] [blame] | 737 | |
Edward Lemur | b983024 | 2019-10-30 22:19:20 +0000 | [diff] [blame] | 738 | return list(filter( |
maruel@chromium.org | 4661e0c | 2009-06-04 00:45:26 +0000 | [diff] [blame] | 739 | lambda x: normpath(x.AbsoluteLocalPath()).startswith(dir_with_slash), |
Edward Lemur | b983024 | 2019-10-30 22:19:20 +0000 | [diff] [blame] | 740 | self.change.AffectedFiles(include_deletes, file_filter))) |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 741 | |
agable | 0b65e73 | 2016-11-22 09:25:46 -0800 | [diff] [blame] | 742 | def LocalPaths(self): |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 743 | """Returns local paths of input_api.AffectedFiles().""" |
agable | 0b65e73 | 2016-11-22 09:25:46 -0800 | [diff] [blame] | 744 | paths = [af.LocalPath() for af in self.AffectedFiles()] |
Edward Lemur | a5799e3 | 2020-01-17 19:26:51 +0000 | [diff] [blame] | 745 | logging.debug('LocalPaths: %s', paths) |
pgervais@chromium.org | 2f64f78 | 2014-04-25 00:12:33 +0000 | [diff] [blame] | 746 | return paths |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 747 | |
agable | 0b65e73 | 2016-11-22 09:25:46 -0800 | [diff] [blame] | 748 | def AbsoluteLocalPaths(self): |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 749 | """Returns absolute local paths of input_api.AffectedFiles().""" |
agable | 0b65e73 | 2016-11-22 09:25:46 -0800 | [diff] [blame] | 750 | return [af.AbsoluteLocalPath() for af in self.AffectedFiles()] |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 751 | |
John Budorick | 1616237 | 2018-04-18 10:39:53 -0700 | [diff] [blame] | 752 | def AffectedTestableFiles(self, include_deletes=None, **kwargs): |
agable | 0b65e73 | 2016-11-22 09:25:46 -0800 | [diff] [blame] | 753 | """Same as input_api.change.AffectedTestableFiles() except only lists files |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 754 | in the same directory as the current presubmit script, or subdirectories |
| 755 | thereof. |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 756 | """ |
maruel@chromium.org | 77c4f0f | 2009-05-29 18:53:04 +0000 | [diff] [blame] | 757 | if include_deletes is not None: |
Edward Lemur | a5799e3 | 2020-01-17 19:26:51 +0000 | [diff] [blame] | 758 | warn('AffectedTestableFiles(include_deletes=%s)' |
| 759 | ' is deprecated and ignored' % str(include_deletes), |
maruel@chromium.org | cb2985f | 2010-11-03 14:08:31 +0000 | [diff] [blame] | 760 | category=DeprecationWarning, |
| 761 | stacklevel=2) |
Josip Sokcevic | 4de5dea | 2022-03-23 21:15:14 +0000 | [diff] [blame] | 762 | # pylint: disable=consider-using-generator |
| 763 | return [ |
| 764 | x for x in self.AffectedFiles(include_deletes=False, **kwargs) |
| 765 | if x.IsTestableFile() |
| 766 | ] |
agable | 0b65e73 | 2016-11-22 09:25:46 -0800 | [diff] [blame] | 767 | |
| 768 | def AffectedTextFiles(self, include_deletes=None): |
| 769 | """An alias to AffectedTestableFiles for backwards compatibility.""" |
| 770 | return self.AffectedTestableFiles(include_deletes=include_deletes) |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 771 | |
Josip Sokcevic | 8c95595 | 2021-02-01 21:32:57 +0000 | [diff] [blame] | 772 | def FilterSourceFile(self, |
| 773 | affected_file, |
| 774 | files_to_check=None, |
| 775 | files_to_skip=None, |
| 776 | allow_list=None, |
| 777 | block_list=None): |
Edward Lemur | a5799e3 | 2020-01-17 19:26:51 +0000 | [diff] [blame] | 778 | """Filters out files that aren't considered 'source file'. |
maruel@chromium.org | 3410d91 | 2009-06-09 20:56:16 +0000 | [diff] [blame] | 779 | |
local_bot | 6402141 | 2020-07-08 21:05:39 +0000 | [diff] [blame] | 780 | If files_to_check or files_to_skip is None, InputApi.DEFAULT_FILES_TO_CHECK |
| 781 | and InputApi.DEFAULT_FILES_TO_SKIP is used respectively. |
maruel@chromium.org | 3410d91 | 2009-06-09 20:56:16 +0000 | [diff] [blame] | 782 | |
Bruce Dawson | 635383f | 2022-09-13 16:23:18 +0000 | [diff] [blame] | 783 | affected_file.LocalPath() needs to re.match an entry in the files_to_check |
| 784 | list and not re.match any entries in the files_to_skip list. |
| 785 | '/' path separators should be used in the regular expressions and will work |
| 786 | on Windows as well as other platforms. |
maruel@chromium.org | 3410d91 | 2009-06-09 20:56:16 +0000 | [diff] [blame] | 787 | |
| 788 | Note: Copy-paste this function to suit your needs or use a lambda function. |
| 789 | """ |
local_bot | 6402141 | 2020-07-08 21:05:39 +0000 | [diff] [blame] | 790 | if files_to_check is None: |
| 791 | files_to_check = self.DEFAULT_FILES_TO_CHECK |
| 792 | if files_to_skip is None: |
| 793 | files_to_skip = self.DEFAULT_FILES_TO_SKIP |
local_bot | 30f774e | 2020-06-25 18:23:34 +0000 | [diff] [blame] | 794 | |
maruel@chromium.org | cb2985f | 2010-11-03 14:08:31 +0000 | [diff] [blame] | 795 | def Find(affected_file, items): |
maruel@chromium.org | ab05d58 | 2011-02-09 23:41:22 +0000 | [diff] [blame] | 796 | local_path = affected_file.LocalPath() |
maruel@chromium.org | cb2985f | 2010-11-03 14:08:31 +0000 | [diff] [blame] | 797 | for item in items: |
maruel@chromium.org | df1595a | 2009-06-11 02:00:13 +0000 | [diff] [blame] | 798 | if self.re.match(item, local_path): |
maruel@chromium.org | 3410d91 | 2009-06-09 20:56:16 +0000 | [diff] [blame] | 799 | return True |
Bruce Dawson | a3a014e | 2022-04-27 23:28:17 +0000 | [diff] [blame] | 800 | # Handle the cases where the files regex only handles /, but the local |
| 801 | # path uses \. |
| 802 | if self.is_windows and self.re.match(item, local_path.replace( |
| 803 | '\\', '/')): |
| 804 | return True |
maruel@chromium.org | 3410d91 | 2009-06-09 20:56:16 +0000 | [diff] [blame] | 805 | return False |
local_bot | 6402141 | 2020-07-08 21:05:39 +0000 | [diff] [blame] | 806 | return (Find(affected_file, files_to_check) and |
| 807 | not Find(affected_file, files_to_skip)) |
maruel@chromium.org | 3410d91 | 2009-06-09 20:56:16 +0000 | [diff] [blame] | 808 | |
| 809 | def AffectedSourceFiles(self, source_file): |
agable | 0b65e73 | 2016-11-22 09:25:46 -0800 | [diff] [blame] | 810 | """Filter the list of AffectedTestableFiles by the function source_file. |
maruel@chromium.org | 3410d91 | 2009-06-09 20:56:16 +0000 | [diff] [blame] | 811 | |
| 812 | If source_file is None, InputApi.FilterSourceFile() is used. |
| 813 | """ |
| 814 | if not source_file: |
| 815 | source_file = self.FilterSourceFile |
Edward Lemur | b983024 | 2019-10-30 22:19:20 +0000 | [diff] [blame] | 816 | return list(filter(source_file, self.AffectedTestableFiles())) |
maruel@chromium.org | 3410d91 | 2009-06-09 20:56:16 +0000 | [diff] [blame] | 817 | |
| 818 | def RightHandSideLines(self, source_file_filter=None): |
Edward Lemur | a5799e3 | 2020-01-17 19:26:51 +0000 | [diff] [blame] | 819 | """An iterator over all text lines in 'new' version of changed files. |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 820 | |
| 821 | Only lists lines from new or modified text files in the change that are |
| 822 | contained by the directory of the currently executing presubmit script. |
| 823 | |
| 824 | This is useful for doing line-by-line regex checks, like checking for |
| 825 | trailing whitespace. |
| 826 | |
| 827 | Yields: |
| 828 | a 3 tuple: |
| 829 | the AffectedFile instance of the current file; |
| 830 | integer line number (1-based); and |
| 831 | the contents of the line as a string. |
maruel@chromium.org | 1487d53 | 2009-06-06 00:22:57 +0000 | [diff] [blame] | 832 | |
nick@chromium.org | 2a3ab7e | 2011-04-27 22:06:27 +0000 | [diff] [blame] | 833 | Note: The carriage return (LF or CR) is stripped off. |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 834 | """ |
maruel@chromium.org | 3410d91 | 2009-06-09 20:56:16 +0000 | [diff] [blame] | 835 | files = self.AffectedSourceFiles(source_file_filter) |
maruel@chromium.org | cb2985f | 2010-11-03 14:08:31 +0000 | [diff] [blame] | 836 | return _RightHandSideLinesImpl(files) |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 837 | |
maruel@chromium.org | e3608df | 2009-11-10 20:22:57 +0000 | [diff] [blame] | 838 | def ReadFile(self, file_item, mode='r'): |
maruel@chromium.org | 44a17ad | 2009-06-08 14:14:35 +0000 | [diff] [blame] | 839 | """Reads an arbitrary file. |
thestig@chromium.org | da8cddd | 2009-08-13 00:25:55 +0000 | [diff] [blame] | 840 | |
maruel@chromium.org | 44a17ad | 2009-06-08 14:14:35 +0000 | [diff] [blame] | 841 | Deny reading anything outside the repository. |
| 842 | """ |
maruel@chromium.org | e3608df | 2009-11-10 20:22:57 +0000 | [diff] [blame] | 843 | if isinstance(file_item, AffectedFile): |
| 844 | file_item = file_item.AbsoluteLocalPath() |
| 845 | if not file_item.startswith(self.change.RepositoryRoot()): |
maruel@chromium.org | 44a17ad | 2009-06-08 14:14:35 +0000 | [diff] [blame] | 846 | raise IOError('Access outside the repository root is denied.') |
maruel@chromium.org | 5aeb7dd | 2009-11-17 18:09:01 +0000 | [diff] [blame] | 847 | return gclient_utils.FileRead(file_item, mode) |
maruel@chromium.org | 44a17ad | 2009-06-08 14:14:35 +0000 | [diff] [blame] | 848 | |
Raphael Kubo da Costa | f2d1615 | 2017-11-10 18:07:58 +0100 | [diff] [blame] | 849 | def CreateTemporaryFile(self, **kwargs): |
| 850 | """Returns a named temporary file that must be removed with a call to |
| 851 | RemoveTemporaryFiles(). |
| 852 | |
| 853 | All keyword arguments are forwarded to tempfile.NamedTemporaryFile(), |
| 854 | except for |delete|, which is always set to False. |
| 855 | |
| 856 | Presubmit checks that need to create a temporary file and pass it for |
| 857 | reading should use this function instead of NamedTemporaryFile(), as |
| 858 | Windows fails to open a file that is already open for writing. |
| 859 | |
| 860 | with input_api.CreateTemporaryFile() as f: |
| 861 | f.write('xyz') |
| 862 | f.close() |
| 863 | input_api.subprocess.check_output(['script-that', '--reads-from', |
| 864 | f.name]) |
| 865 | |
| 866 | |
| 867 | Note that callers of CreateTemporaryFile() should not worry about removing |
| 868 | any temporary file; this is done transparently by the presubmit handling |
| 869 | code. |
| 870 | """ |
| 871 | if 'delete' in kwargs: |
| 872 | # Prevent users from passing |delete|; we take care of file deletion |
| 873 | # ourselves and this prevents unintuitive error messages when we pass |
| 874 | # delete=False and 'delete' is also in kwargs. |
| 875 | raise TypeError('CreateTemporaryFile() does not take a "delete" ' |
| 876 | 'argument, file deletion is handled automatically by ' |
| 877 | 'the same presubmit_support code that creates InputApi ' |
| 878 | 'objects.') |
| 879 | temp_file = self.tempfile.NamedTemporaryFile(delete=False, **kwargs) |
| 880 | self._named_temporary_files.append(temp_file.name) |
| 881 | return temp_file |
| 882 | |
maruel@chromium.org | cc73ad6 | 2011-07-06 17:39:26 +0000 | [diff] [blame] | 883 | @property |
| 884 | def tbr(self): |
| 885 | """Returns if a change is TBR'ed.""" |
Jeremy Roman | dce2250 | 2017-06-20 15:37:29 -0400 | [diff] [blame] | 886 | return 'TBR' in self.change.tags or self.change.TBRsFromDescription() |
maruel@chromium.org | cc73ad6 | 2011-07-06 17:39:26 +0000 | [diff] [blame] | 887 | |
maruel@chromium.org | ffeb2f3 | 2013-12-03 13:55:22 +0000 | [diff] [blame] | 888 | def RunTests(self, tests_mix, parallel=True): |
ilevy@chromium.org | bc11731 | 2013-04-20 03:57:56 +0000 | [diff] [blame] | 889 | tests = [] |
| 890 | msgs = [] |
| 891 | for t in tests_mix: |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 892 | if isinstance(t, OutputApi.PresubmitResult) and t: |
ilevy@chromium.org | bc11731 | 2013-04-20 03:57:56 +0000 | [diff] [blame] | 893 | msgs.append(t) |
| 894 | else: |
| 895 | assert issubclass(t.message, _PresubmitResult) |
| 896 | tests.append(t) |
maruel@chromium.org | ffeb2f3 | 2013-12-03 13:55:22 +0000 | [diff] [blame] | 897 | if self.verbose: |
| 898 | t.info = _PresubmitNotifyResult |
Edward Lemur | 1037c74 | 2018-05-01 18:56:04 -0400 | [diff] [blame] | 899 | if not t.kwargs.get('cwd'): |
| 900 | t.kwargs['cwd'] = self.PresubmitLocalPath() |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 901 | self.thread_pool.AddTests(tests, parallel) |
Edward Lemur | 21000eb | 2019-05-24 23:25:58 +0000 | [diff] [blame] | 902 | # When self.parallel is True (i.e. --parallel is passed as an option) |
| 903 | # RunTests doesn't actually run tests. It adds them to a ThreadPool that |
| 904 | # will run all tests once all PRESUBMIT files are processed. |
| 905 | # Otherwise, it will run them and return the results. |
| 906 | if not self.parallel: |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 907 | msgs.extend(self.thread_pool.RunAsync()) |
| 908 | return msgs |
scottmg | 86099d7 | 2016-09-01 09:16:51 -0700 | [diff] [blame] | 909 | |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 910 | |
nick@chromium.org | ff52619 | 2013-06-10 19:30:26 +0000 | [diff] [blame] | 911 | class _DiffCache(object): |
| 912 | """Caches diffs retrieved from a particular SCM.""" |
agable@chromium.org | ea84ef1 | 2014-04-30 19:55:12 +0000 | [diff] [blame] | 913 | def __init__(self, upstream=None): |
| 914 | """Stores the upstream revision against which all diffs will be computed.""" |
| 915 | self._upstream = upstream |
nick@chromium.org | ff52619 | 2013-06-10 19:30:26 +0000 | [diff] [blame] | 916 | |
| 917 | def GetDiff(self, path, local_root): |
| 918 | """Get the diff for a particular path.""" |
| 919 | raise NotImplementedError() |
| 920 | |
Daniel Cheng | 7a1f04d | 2017-03-21 19:12:31 -0700 | [diff] [blame] | 921 | def GetOldContents(self, path, local_root): |
| 922 | """Get the old version for a particular path.""" |
| 923 | raise NotImplementedError() |
| 924 | |
nick@chromium.org | ff52619 | 2013-06-10 19:30:26 +0000 | [diff] [blame] | 925 | |
nick@chromium.org | ff52619 | 2013-06-10 19:30:26 +0000 | [diff] [blame] | 926 | class _GitDiffCache(_DiffCache): |
| 927 | """DiffCache implementation for git; gets all file diffs at once.""" |
agable@chromium.org | ea84ef1 | 2014-04-30 19:55:12 +0000 | [diff] [blame] | 928 | def __init__(self, upstream): |
| 929 | super(_GitDiffCache, self).__init__(upstream=upstream) |
nick@chromium.org | ff52619 | 2013-06-10 19:30:26 +0000 | [diff] [blame] | 930 | self._diffs_by_file = None |
| 931 | |
| 932 | def GetDiff(self, path, local_root): |
Bruce Dawson | 5f63d3c | 2022-04-19 17:02:36 +0000 | [diff] [blame] | 933 | # Compare against None to distinguish between None and an initialized but |
| 934 | # empty dictionary. |
| 935 | if self._diffs_by_file == None: |
nick@chromium.org | ff52619 | 2013-06-10 19:30:26 +0000 | [diff] [blame] | 936 | # Compute a single diff for all files and parse the output; should |
| 937 | # with git this is much faster than computing one diff for each file. |
| 938 | diffs = {} |
| 939 | |
| 940 | # Don't specify any filenames below, because there are command line length |
| 941 | # limits on some platforms and GenerateDiff would fail. |
agable@chromium.org | ea84ef1 | 2014-04-30 19:55:12 +0000 | [diff] [blame] | 942 | unified_diff = scm.GIT.GenerateDiff(local_root, files=[], full_move=True, |
| 943 | branch=self._upstream) |
nick@chromium.org | ff52619 | 2013-06-10 19:30:26 +0000 | [diff] [blame] | 944 | |
| 945 | # This regex matches the path twice, separated by a space. Note that |
| 946 | # filename itself may contain spaces. |
| 947 | file_marker = re.compile('^diff --git (?P<filename>.*) (?P=filename)$') |
| 948 | current_diff = [] |
| 949 | keep_line_endings = True |
| 950 | for x in unified_diff.splitlines(keep_line_endings): |
| 951 | match = file_marker.match(x) |
| 952 | if match: |
| 953 | # Marks the start of a new per-file section. |
| 954 | diffs[match.group('filename')] = current_diff = [x] |
| 955 | elif x.startswith('diff --git'): |
| 956 | raise PresubmitFailure('Unexpected diff line: %s' % x) |
| 957 | else: |
| 958 | current_diff.append(x) |
| 959 | |
| 960 | self._diffs_by_file = dict( |
| 961 | (normpath(path), ''.join(diff)) for path, diff in diffs.items()) |
| 962 | |
| 963 | if path not in self._diffs_by_file: |
Josip Sokcevic | c1ab734 | 2022-02-24 19:02:44 +0000 | [diff] [blame] | 964 | # SCM didn't have any diff on this file. It could be that the file was not |
| 965 | # modified at all (e.g. user used --all flag in git cl presubmit). |
| 966 | # Intead of failing, return empty string. |
| 967 | # See: https://crbug.com/808346. |
Josip Sokcevic | c1ab734 | 2022-02-24 19:02:44 +0000 | [diff] [blame] | 968 | return '' |
nick@chromium.org | ff52619 | 2013-06-10 19:30:26 +0000 | [diff] [blame] | 969 | |
| 970 | return self._diffs_by_file[path] |
| 971 | |
Daniel Cheng | 7a1f04d | 2017-03-21 19:12:31 -0700 | [diff] [blame] | 972 | def GetOldContents(self, path, local_root): |
| 973 | return scm.GIT.GetOldContents(local_root, path, branch=self._upstream) |
| 974 | |
nick@chromium.org | ff52619 | 2013-06-10 19:30:26 +0000 | [diff] [blame] | 975 | |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 976 | class AffectedFile(object): |
| 977 | """Representation of a file in a change.""" |
nick@chromium.org | ff52619 | 2013-06-10 19:30:26 +0000 | [diff] [blame] | 978 | |
| 979 | DIFF_CACHE = _DiffCache |
| 980 | |
maruel@chromium.org | b17b55b | 2010-11-03 14:42:37 +0000 | [diff] [blame] | 981 | # Method could be a function |
Quinten Yearsley | b2cc4a9 | 2016-12-15 13:53:26 -0800 | [diff] [blame] | 982 | # pylint: disable=no-self-use |
agable@chromium.org | ea84ef1 | 2014-04-30 19:55:12 +0000 | [diff] [blame] | 983 | def __init__(self, path, action, repository_root, diff_cache): |
maruel@chromium.org | 15bdffa | 2009-05-29 11:16:29 +0000 | [diff] [blame] | 984 | self._path = path |
| 985 | self._action = action |
maruel@chromium.org | 4ff922a | 2009-06-12 20:20:19 +0000 | [diff] [blame] | 986 | self._local_root = repository_root |
maruel@chromium.org | 15bdffa | 2009-05-29 11:16:29 +0000 | [diff] [blame] | 987 | self._is_directory = None |
nick@chromium.org | 2a3ab7e | 2011-04-27 22:06:27 +0000 | [diff] [blame] | 988 | self._cached_changed_contents = None |
| 989 | self._cached_new_contents = None |
agable@chromium.org | ea84ef1 | 2014-04-30 19:55:12 +0000 | [diff] [blame] | 990 | self._diff_cache = diff_cache |
tobiasjs | 2836bcf | 2016-08-16 04:08:16 -0700 | [diff] [blame] | 991 | logging.debug('%s(%s)', self.__class__.__name__, self._path) |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 992 | |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 993 | def LocalPath(self): |
| 994 | """Returns the path of this file on the local disk relative to client root. |
Andrew Grieve | 92b8b99 | 2017-11-02 09:42:24 -0400 | [diff] [blame] | 995 | |
| 996 | This should be used for error messages but not for accessing files, |
| 997 | because presubmit checks are run with CWD=PresubmitLocalPath() (which is |
| 998 | often != client root). |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 999 | """ |
maruel@chromium.org | 15bdffa | 2009-05-29 11:16:29 +0000 | [diff] [blame] | 1000 | return normpath(self._path) |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1001 | |
| 1002 | def AbsoluteLocalPath(self): |
| 1003 | """Returns the absolute path of this file on the local disk. |
| 1004 | """ |
chase@chromium.org | 8e416c8 | 2009-10-06 04:30:44 +0000 | [diff] [blame] | 1005 | return os.path.abspath(os.path.join(self._local_root, self.LocalPath())) |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1006 | |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1007 | def Action(self): |
| 1008 | """Returns the action on this opened file, e.g. A, M, D, etc.""" |
maruel@chromium.org | 15bdffa | 2009-05-29 11:16:29 +0000 | [diff] [blame] | 1009 | return self._action |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1010 | |
agable | 0b65e73 | 2016-11-22 09:25:46 -0800 | [diff] [blame] | 1011 | def IsTestableFile(self): |
maruel@chromium.org | 77c4f0f | 2009-05-29 18:53:04 +0000 | [diff] [blame] | 1012 | """Returns True if the file is a text file and not a binary file. |
thestig@chromium.org | da8cddd | 2009-08-13 00:25:55 +0000 | [diff] [blame] | 1013 | |
maruel@chromium.org | 77c4f0f | 2009-05-29 18:53:04 +0000 | [diff] [blame] | 1014 | Deleted files are not text file.""" |
maruel@chromium.org | 1e08c00 | 2009-05-28 19:09:33 +0000 | [diff] [blame] | 1015 | raise NotImplementedError() # Implement when needed |
| 1016 | |
agable | 0b65e73 | 2016-11-22 09:25:46 -0800 | [diff] [blame] | 1017 | def IsTextFile(self): |
| 1018 | """An alias to IsTestableFile for backwards compatibility.""" |
| 1019 | return self.IsTestableFile() |
| 1020 | |
Daniel Cheng | 7a1f04d | 2017-03-21 19:12:31 -0700 | [diff] [blame] | 1021 | def OldContents(self): |
| 1022 | """Returns an iterator over the lines in the old version of file. |
| 1023 | |
Daniel Cheng | 2da34fe | 2017-03-21 20:42:12 -0700 | [diff] [blame] | 1024 | The old version is the file before any modifications in the user's |
Edward Lemur | a5799e3 | 2020-01-17 19:26:51 +0000 | [diff] [blame] | 1025 | workspace, i.e. the 'left hand side'. |
Daniel Cheng | 7a1f04d | 2017-03-21 19:12:31 -0700 | [diff] [blame] | 1026 | |
| 1027 | Contents will be empty if the file is a directory or does not exist. |
| 1028 | Note: The carriage returns (LF or CR) are stripped off. |
| 1029 | """ |
| 1030 | return self._diff_cache.GetOldContents(self.LocalPath(), |
| 1031 | self._local_root).splitlines() |
| 1032 | |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1033 | def NewContents(self): |
| 1034 | """Returns an iterator over the lines in the new version of file. |
| 1035 | |
Edward Lemur | a5799e3 | 2020-01-17 19:26:51 +0000 | [diff] [blame] | 1036 | The new version is the file in the user's workspace, i.e. the 'right hand |
| 1037 | side'. |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1038 | |
| 1039 | Contents will be empty if the file is a directory or does not exist. |
nick@chromium.org | 2a3ab7e | 2011-04-27 22:06:27 +0000 | [diff] [blame] | 1040 | Note: The carriage returns (LF or CR) are stripped off. |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1041 | """ |
nick@chromium.org | 2a3ab7e | 2011-04-27 22:06:27 +0000 | [diff] [blame] | 1042 | if self._cached_new_contents is None: |
| 1043 | self._cached_new_contents = [] |
agable | 0b65e73 | 2016-11-22 09:25:46 -0800 | [diff] [blame] | 1044 | try: |
| 1045 | self._cached_new_contents = gclient_utils.FileRead( |
| 1046 | self.AbsoluteLocalPath(), 'rU').splitlines() |
| 1047 | except IOError: |
| 1048 | pass # File not found? That's fine; maybe it was deleted. |
Greg Thompson | 30cde45 | 2021-06-01 16:38:47 +0000 | [diff] [blame] | 1049 | except UnicodeDecodeError as e: |
Dirk Pranke | 6fc394f | 2021-05-26 23:25:14 +0000 | [diff] [blame] | 1050 | # log the filename since we're probably trying to read a binary |
| 1051 | # file, and shouldn't be. |
| 1052 | print('Error reading %s: %s' % (self.AbsoluteLocalPath(), e)) |
| 1053 | raise |
| 1054 | |
nick@chromium.org | 2a3ab7e | 2011-04-27 22:06:27 +0000 | [diff] [blame] | 1055 | return self._cached_new_contents[:] |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1056 | |
Bruce Dawson | f0bcfdd | 2021-05-21 18:10:23 +0000 | [diff] [blame] | 1057 | def ChangedContents(self, keeplinebreaks=False): |
maruel@chromium.org | ab05d58 | 2011-02-09 23:41:22 +0000 | [diff] [blame] | 1058 | """Returns a list of tuples (line number, line text) of all new lines. |
| 1059 | |
| 1060 | This relies on the scm diff output describing each changed code section |
| 1061 | with a line of the form |
| 1062 | |
| 1063 | ^@@ <old line num>,<old size> <new line num>,<new size> @@$ |
| 1064 | """ |
Bruce Dawson | f0bcfdd | 2021-05-21 18:10:23 +0000 | [diff] [blame] | 1065 | # Don't return cached results when line breaks are requested. |
| 1066 | if not keeplinebreaks and self._cached_changed_contents is not None: |
nick@chromium.org | 2a3ab7e | 2011-04-27 22:06:27 +0000 | [diff] [blame] | 1067 | return self._cached_changed_contents[:] |
Bruce Dawson | f0bcfdd | 2021-05-21 18:10:23 +0000 | [diff] [blame] | 1068 | result = [] |
maruel@chromium.org | ab05d58 | 2011-02-09 23:41:22 +0000 | [diff] [blame] | 1069 | line_num = 0 |
| 1070 | |
Bruce Dawson | f0bcfdd | 2021-05-21 18:10:23 +0000 | [diff] [blame] | 1071 | # The keeplinebreaks parameter to splitlines must be True or else the |
| 1072 | # CheckForWindowsLineEndings presubmit will be a NOP. |
| 1073 | for line in self.GenerateScmDiff().splitlines(keeplinebreaks): |
Edward Lemur | ac5c55f | 2020-02-29 00:17:16 +0000 | [diff] [blame] | 1074 | m = re.match(r'^@@ [0-9\,\+\-]+ \+([0-9]+)\,[0-9]+ @@', line) |
| 1075 | if m: |
| 1076 | line_num = int(m.groups(1)[0]) |
maruel@chromium.org | ab05d58 | 2011-02-09 23:41:22 +0000 | [diff] [blame] | 1077 | continue |
| 1078 | if line.startswith('+') and not line.startswith('++'): |
Bruce Dawson | f0bcfdd | 2021-05-21 18:10:23 +0000 | [diff] [blame] | 1079 | result.append((line_num, line[1:])) |
maruel@chromium.org | ab05d58 | 2011-02-09 23:41:22 +0000 | [diff] [blame] | 1080 | if not line.startswith('-'): |
| 1081 | line_num += 1 |
Bruce Dawson | f0bcfdd | 2021-05-21 18:10:23 +0000 | [diff] [blame] | 1082 | # Don't cache results with line breaks. |
| 1083 | if keeplinebreaks: |
| 1084 | return result; |
| 1085 | self._cached_changed_contents = result |
nick@chromium.org | 2a3ab7e | 2011-04-27 22:06:27 +0000 | [diff] [blame] | 1086 | return self._cached_changed_contents[:] |
maruel@chromium.org | ab05d58 | 2011-02-09 23:41:22 +0000 | [diff] [blame] | 1087 | |
maruel@chromium.org | 5de1397 | 2009-06-10 18:16:06 +0000 | [diff] [blame] | 1088 | def __str__(self): |
| 1089 | return self.LocalPath() |
| 1090 | |
maruel@chromium.org | ab05d58 | 2011-02-09 23:41:22 +0000 | [diff] [blame] | 1091 | def GenerateScmDiff(self): |
nick@chromium.org | ff52619 | 2013-06-10 19:30:26 +0000 | [diff] [blame] | 1092 | return self._diff_cache.GetDiff(self.LocalPath(), self._local_root) |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1093 | |
maruel@chromium.org | 58407af | 2011-04-12 23:15:57 +0000 | [diff] [blame] | 1094 | |
maruel@chromium.org | c70a220 | 2009-06-17 12:55:10 +0000 | [diff] [blame] | 1095 | class GitAffectedFile(AffectedFile): |
| 1096 | """Representation of a file in a change out of a git checkout.""" |
maruel@chromium.org | b17b55b | 2010-11-03 14:42:37 +0000 | [diff] [blame] | 1097 | # Method 'NNN' is abstract in class 'NNN' but is not overridden |
Quinten Yearsley | b2cc4a9 | 2016-12-15 13:53:26 -0800 | [diff] [blame] | 1098 | # pylint: disable=abstract-method |
maruel@chromium.org | c70a220 | 2009-06-17 12:55:10 +0000 | [diff] [blame] | 1099 | |
nick@chromium.org | ff52619 | 2013-06-10 19:30:26 +0000 | [diff] [blame] | 1100 | DIFF_CACHE = _GitDiffCache |
| 1101 | |
maruel@chromium.org | c70a220 | 2009-06-17 12:55:10 +0000 | [diff] [blame] | 1102 | def __init__(self, *args, **kwargs): |
| 1103 | AffectedFile.__init__(self, *args, **kwargs) |
| 1104 | self._server_path = None |
agable | 0b65e73 | 2016-11-22 09:25:46 -0800 | [diff] [blame] | 1105 | self._is_testable_file = None |
maruel@chromium.org | c70a220 | 2009-06-17 12:55:10 +0000 | [diff] [blame] | 1106 | |
agable | 0b65e73 | 2016-11-22 09:25:46 -0800 | [diff] [blame] | 1107 | def IsTestableFile(self): |
| 1108 | if self._is_testable_file is None: |
maruel@chromium.org | c70a220 | 2009-06-17 12:55:10 +0000 | [diff] [blame] | 1109 | if self.Action() == 'D': |
agable | 0b65e73 | 2016-11-22 09:25:46 -0800 | [diff] [blame] | 1110 | # A deleted file is not testable. |
| 1111 | self._is_testable_file = False |
maruel@chromium.org | c70a220 | 2009-06-17 12:55:10 +0000 | [diff] [blame] | 1112 | else: |
agable | 0b65e73 | 2016-11-22 09:25:46 -0800 | [diff] [blame] | 1113 | self._is_testable_file = os.path.isfile(self.AbsoluteLocalPath()) |
| 1114 | return self._is_testable_file |
maruel@chromium.org | c70a220 | 2009-06-17 12:55:10 +0000 | [diff] [blame] | 1115 | |
maruel@chromium.org | c193875 | 2011-04-12 23:11:13 +0000 | [diff] [blame] | 1116 | |
maruel@chromium.org | 4ff922a | 2009-06-12 20:20:19 +0000 | [diff] [blame] | 1117 | class Change(object): |
maruel@chromium.org | 6ebe68a | 2009-05-27 23:43:40 +0000 | [diff] [blame] | 1118 | """Describe a change. |
| 1119 | |
| 1120 | Used directly by the presubmit scripts to query the current change being |
| 1121 | tested. |
thestig@chromium.org | da8cddd | 2009-08-13 00:25:55 +0000 | [diff] [blame] | 1122 | |
maruel@chromium.org | 6ebe68a | 2009-05-27 23:43:40 +0000 | [diff] [blame] | 1123 | Instance members: |
nick@chromium.org | ff52619 | 2013-06-10 19:30:26 +0000 | [diff] [blame] | 1124 | tags: Dictionary of KEY=VALUE pairs found in the change description. |
maruel@chromium.org | 6ebe68a | 2009-05-27 23:43:40 +0000 | [diff] [blame] | 1125 | self.KEY: equivalent to tags['KEY'] |
| 1126 | """ |
| 1127 | |
maruel@chromium.org | 4ff922a | 2009-06-12 20:20:19 +0000 | [diff] [blame] | 1128 | _AFFECTED_FILES = AffectedFile |
| 1129 | |
Edward Lemur | a5799e3 | 2020-01-17 19:26:51 +0000 | [diff] [blame] | 1130 | # Matches key/value (or 'tag') lines in changelist descriptions. |
maruel@chromium.org | 428342a | 2011-11-10 15:46:33 +0000 | [diff] [blame] | 1131 | TAG_LINE_RE = re.compile( |
maruel@chromium.org | c6f60e8 | 2013-04-19 17:01:57 +0000 | [diff] [blame] | 1132 | '^[ \t]*(?P<key>[A-Z][A-Z_0-9]*)[ \t]*=[ \t]*(?P<value>.*?)[ \t]*$') |
maruel@chromium.org | c193875 | 2011-04-12 23:11:13 +0000 | [diff] [blame] | 1133 | scm = '' |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1134 | |
maruel@chromium.org | 58407af | 2011-04-12 23:15:57 +0000 | [diff] [blame] | 1135 | def __init__( |
agable@chromium.org | ea84ef1 | 2014-04-30 19:55:12 +0000 | [diff] [blame] | 1136 | self, name, description, local_root, files, issue, patchset, author, |
| 1137 | upstream=None): |
maruel@chromium.org | 4ff922a | 2009-06-12 20:20:19 +0000 | [diff] [blame] | 1138 | if files is None: |
| 1139 | files = [] |
| 1140 | self._name = name |
chase@chromium.org | 8e416c8 | 2009-10-06 04:30:44 +0000 | [diff] [blame] | 1141 | # Convert root into an absolute path. |
| 1142 | self._local_root = os.path.abspath(local_root) |
agable@chromium.org | ea84ef1 | 2014-04-30 19:55:12 +0000 | [diff] [blame] | 1143 | self._upstream = upstream |
maruel@chromium.org | 4ff922a | 2009-06-12 20:20:19 +0000 | [diff] [blame] | 1144 | self.issue = issue |
| 1145 | self.patchset = patchset |
maruel@chromium.org | 58407af | 2011-04-12 23:15:57 +0000 | [diff] [blame] | 1146 | self.author_email = author |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1147 | |
isherman@chromium.org | b5cded6 | 2014-03-25 17:47:57 +0000 | [diff] [blame] | 1148 | self._full_description = '' |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1149 | self.tags = {} |
isherman@chromium.org | b5cded6 | 2014-03-25 17:47:57 +0000 | [diff] [blame] | 1150 | self._description_without_tags = '' |
| 1151 | self.SetDescriptionText(description) |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1152 | |
maruel@chromium.org | e085d81 | 2011-10-10 19:49:15 +0000 | [diff] [blame] | 1153 | assert all( |
| 1154 | (isinstance(f, (list, tuple)) and len(f) == 2) for f in files), files |
| 1155 | |
agable@chromium.org | ea84ef1 | 2014-04-30 19:55:12 +0000 | [diff] [blame] | 1156 | diff_cache = self._AFFECTED_FILES.DIFF_CACHE(self._upstream) |
maruel@chromium.org | 6ebe68a | 2009-05-27 23:43:40 +0000 | [diff] [blame] | 1157 | self._affected_files = [ |
nick@chromium.org | ff52619 | 2013-06-10 19:30:26 +0000 | [diff] [blame] | 1158 | self._AFFECTED_FILES(path, action.strip(), self._local_root, diff_cache) |
| 1159 | for action, path in files |
maruel@chromium.org | dbbeedc | 2009-05-22 20:26:17 +0000 | [diff] [blame] | 1160 | ] |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1161 | |
Edward Lesmes | 9ce03f8 | 2021-01-12 20:13:31 +0000 | [diff] [blame] | 1162 | def UpstreamBranch(self): |
| 1163 | """Returns the upstream branch for the change.""" |
| 1164 | return self._upstream |
| 1165 | |
maruel@chromium.org | 92022ec | 2009-06-11 01:59:28 +0000 | [diff] [blame] | 1166 | def Name(self): |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1167 | """Returns the change name.""" |
maruel@chromium.org | 6ebe68a | 2009-05-27 23:43:40 +0000 | [diff] [blame] | 1168 | return self._name |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1169 | |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1170 | def DescriptionText(self): |
| 1171 | """Returns the user-entered changelist description, minus tags. |
| 1172 | |
Edward Lemur | a5799e3 | 2020-01-17 19:26:51 +0000 | [diff] [blame] | 1173 | Any line in the user-provided description starting with e.g. 'FOO=' |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1174 | (whitespace permitted before and around) is considered a tag line. Such |
| 1175 | lines are stripped out of the description this function returns. |
| 1176 | """ |
maruel@chromium.org | 6ebe68a | 2009-05-27 23:43:40 +0000 | [diff] [blame] | 1177 | return self._description_without_tags |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1178 | |
| 1179 | def FullDescriptionText(self): |
| 1180 | """Returns the complete changelist description including tags.""" |
maruel@chromium.org | 6ebe68a | 2009-05-27 23:43:40 +0000 | [diff] [blame] | 1181 | return self._full_description |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1182 | |
isherman@chromium.org | b5cded6 | 2014-03-25 17:47:57 +0000 | [diff] [blame] | 1183 | def SetDescriptionText(self, description): |
| 1184 | """Sets the full description text (including tags) to |description|. |
pgervais@chromium.org | 92c3009 | 2014-04-15 00:30:37 +0000 | [diff] [blame] | 1185 | |
isherman@chromium.org | b5cded6 | 2014-03-25 17:47:57 +0000 | [diff] [blame] | 1186 | Also updates the list of tags.""" |
| 1187 | self._full_description = description |
| 1188 | |
| 1189 | # From the description text, build up a dictionary of key/value pairs |
Edward Lemur | a5799e3 | 2020-01-17 19:26:51 +0000 | [diff] [blame] | 1190 | # plus the description minus all key/value or 'tag' lines. |
isherman@chromium.org | b5cded6 | 2014-03-25 17:47:57 +0000 | [diff] [blame] | 1191 | description_without_tags = [] |
| 1192 | self.tags = {} |
| 1193 | for line in self._full_description.splitlines(): |
| 1194 | m = self.TAG_LINE_RE.match(line) |
| 1195 | if m: |
| 1196 | self.tags[m.group('key')] = m.group('value') |
| 1197 | else: |
| 1198 | description_without_tags.append(line) |
| 1199 | |
| 1200 | # Change back to text and remove whitespace at end. |
| 1201 | self._description_without_tags = ( |
| 1202 | '\n'.join(description_without_tags).rstrip()) |
| 1203 | |
Edward Lemur | 69bb8be | 2020-02-03 20:37:38 +0000 | [diff] [blame] | 1204 | def AddDescriptionFooter(self, key, value): |
| 1205 | """Adds the given footer to the change description. |
| 1206 | |
| 1207 | Args: |
| 1208 | key: A string with the key for the git footer. It must conform to |
| 1209 | the git footers format (i.e. 'List-Of-Tokens') and will be case |
| 1210 | normalized so that each token is title-cased. |
| 1211 | value: A string with the value for the git footer. |
| 1212 | """ |
| 1213 | description = git_footers.add_footer( |
| 1214 | self.FullDescriptionText(), git_footers.normalize_name(key), value) |
| 1215 | self.SetDescriptionText(description) |
| 1216 | |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1217 | def RepositoryRoot(self): |
maruel@chromium.org | 92022ec | 2009-06-11 01:59:28 +0000 | [diff] [blame] | 1218 | """Returns the repository (checkout) root directory for this change, |
| 1219 | as an absolute path. |
| 1220 | """ |
maruel@chromium.org | 4ff922a | 2009-06-12 20:20:19 +0000 | [diff] [blame] | 1221 | return self._local_root |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1222 | |
| 1223 | def __getattr__(self, attr): |
maruel@chromium.org | 92022ec | 2009-06-11 01:59:28 +0000 | [diff] [blame] | 1224 | """Return tags directly as attributes on the object.""" |
Edward Lemur | a5799e3 | 2020-01-17 19:26:51 +0000 | [diff] [blame] | 1225 | if not re.match(r'^[A-Z_]*$', attr): |
maruel@chromium.org | 92022ec | 2009-06-11 01:59:28 +0000 | [diff] [blame] | 1226 | raise AttributeError(self, attr) |
maruel@chromium.org | e1a524f | 2009-05-27 14:43:46 +0000 | [diff] [blame] | 1227 | return self.tags.get(attr) |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1228 | |
Edward Lemur | 69bb8be | 2020-02-03 20:37:38 +0000 | [diff] [blame] | 1229 | def GitFootersFromDescription(self): |
| 1230 | """Return the git footers present in the description. |
| 1231 | |
| 1232 | Returns: |
| 1233 | footers: A dict of {footer: [values]} containing a multimap of the footers |
| 1234 | in the change description. |
| 1235 | """ |
| 1236 | return git_footers.parse_footers(self.FullDescriptionText()) |
| 1237 | |
Aaron Gable | fc03e67 | 2017-05-15 14:09:42 -0700 | [diff] [blame] | 1238 | def BugsFromDescription(self): |
| 1239 | """Returns all bugs referenced in the commit description.""" |
Sean McAllister | 1e509c5 | 2021-10-25 17:54:25 +0000 | [diff] [blame] | 1240 | bug_tags = ['BUG', 'FIXED'] |
| 1241 | |
| 1242 | tags = [] |
| 1243 | for tag in bug_tags: |
| 1244 | values = self.tags.get(tag) |
| 1245 | if values: |
| 1246 | tags += [value.strip() for value in values.split(',')] |
| 1247 | |
Caleb Rouleau | c0546b9 | 2019-02-22 06:12:57 +0000 | [diff] [blame] | 1248 | footers = [] |
Edward Lemur | 69bb8be | 2020-02-03 20:37:38 +0000 | [diff] [blame] | 1249 | parsed = self.GitFootersFromDescription() |
Dan Beam | 6295404 | 2019-10-03 21:20:33 +0000 | [diff] [blame] | 1250 | unsplit_footers = parsed.get('Bug', []) + parsed.get('Fixed', []) |
Caleb Rouleau | c0546b9 | 2019-02-22 06:12:57 +0000 | [diff] [blame] | 1251 | for unsplit_footer in unsplit_footers: |
| 1252 | footers += [b.strip() for b in unsplit_footer.split(',')] |
Aaron Gable | 12ef501 | 2017-05-15 14:29:00 -0700 | [diff] [blame] | 1253 | return sorted(set(tags + footers)) |
Aaron Gable | fc03e67 | 2017-05-15 14:09:42 -0700 | [diff] [blame] | 1254 | |
| 1255 | def ReviewersFromDescription(self): |
| 1256 | """Returns all reviewers listed in the commit description.""" |
Edward Lemur | a5799e3 | 2020-01-17 19:26:51 +0000 | [diff] [blame] | 1257 | # We don't support a 'R:' git-footer for reviewers; that is in metadata. |
Aaron Gable | 12ef501 | 2017-05-15 14:29:00 -0700 | [diff] [blame] | 1258 | tags = [r.strip() for r in self.tags.get('R', '').split(',') if r.strip()] |
| 1259 | return sorted(set(tags)) |
Aaron Gable | fc03e67 | 2017-05-15 14:09:42 -0700 | [diff] [blame] | 1260 | |
| 1261 | def TBRsFromDescription(self): |
| 1262 | """Returns all TBR reviewers listed in the commit description.""" |
Aaron Gable | 12ef501 | 2017-05-15 14:29:00 -0700 | [diff] [blame] | 1263 | tags = [r.strip() for r in self.tags.get('TBR', '').split(',') if r.strip()] |
Aaron Gable | 6e7ddb6 | 2020-05-27 22:23:29 +0000 | [diff] [blame] | 1264 | # TODO(crbug.com/839208): Remove support for 'Tbr:' when TBRs are |
| 1265 | # programmatically determined by self-CR+1s. |
Edward Lemur | 69bb8be | 2020-02-03 20:37:38 +0000 | [diff] [blame] | 1266 | footers = self.GitFootersFromDescription().get('Tbr', []) |
Aaron Gable | 12ef501 | 2017-05-15 14:29:00 -0700 | [diff] [blame] | 1267 | return sorted(set(tags + footers)) |
Aaron Gable | fc03e67 | 2017-05-15 14:09:42 -0700 | [diff] [blame] | 1268 | |
Aaron Gable | 6e7ddb6 | 2020-05-27 22:23:29 +0000 | [diff] [blame] | 1269 | # TODO(crbug.com/753425): Delete these once we're sure they're unused. |
Aaron Gable | fc03e67 | 2017-05-15 14:09:42 -0700 | [diff] [blame] | 1270 | @property |
| 1271 | def BUG(self): |
| 1272 | return ','.join(self.BugsFromDescription()) |
| 1273 | @property |
| 1274 | def R(self): |
| 1275 | return ','.join(self.ReviewersFromDescription()) |
| 1276 | @property |
| 1277 | def TBR(self): |
| 1278 | return ','.join(self.TBRsFromDescription()) |
| 1279 | |
agable@chromium.org | 40a3d0b | 2014-05-15 01:59:16 +0000 | [diff] [blame] | 1280 | def AllFiles(self, root=None): |
| 1281 | """List all files under source control in the repo.""" |
| 1282 | raise NotImplementedError() |
| 1283 | |
agable | 0b65e73 | 2016-11-22 09:25:46 -0800 | [diff] [blame] | 1284 | def AffectedFiles(self, include_deletes=True, file_filter=None): |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1285 | """Returns a list of AffectedFile instances for all files in the change. |
| 1286 | |
| 1287 | Args: |
| 1288 | include_deletes: If false, deleted files will be filtered out. |
sail@chromium.org | 5538e02 | 2011-05-12 17:53:16 +0000 | [diff] [blame] | 1289 | file_filter: An additional filter to apply. |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1290 | |
| 1291 | Returns: |
| 1292 | [AffectedFile(path, action), AffectedFile(path, action)] |
| 1293 | """ |
Edward Lemur | b983024 | 2019-10-30 22:19:20 +0000 | [diff] [blame] | 1294 | affected = list(filter(file_filter, self._affected_files)) |
sail@chromium.org | 5538e02 | 2011-05-12 17:53:16 +0000 | [diff] [blame] | 1295 | |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1296 | if include_deletes: |
| 1297 | return affected |
Edward Lemur | b983024 | 2019-10-30 22:19:20 +0000 | [diff] [blame] | 1298 | return list(filter(lambda x: x.Action() != 'D', affected)) |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1299 | |
John Budorick | 1616237 | 2018-04-18 10:39:53 -0700 | [diff] [blame] | 1300 | def AffectedTestableFiles(self, include_deletes=None, **kwargs): |
maruel@chromium.org | 77c4f0f | 2009-05-29 18:53:04 +0000 | [diff] [blame] | 1301 | """Return a list of the existing text files in a change.""" |
| 1302 | if include_deletes is not None: |
Edward Lemur | a5799e3 | 2020-01-17 19:26:51 +0000 | [diff] [blame] | 1303 | warn('AffectedTeestableFiles(include_deletes=%s)' |
| 1304 | ' is deprecated and ignored' % str(include_deletes), |
maruel@chromium.org | cb2985f | 2010-11-03 14:08:31 +0000 | [diff] [blame] | 1305 | category=DeprecationWarning, |
| 1306 | stacklevel=2) |
Edward Lemur | b983024 | 2019-10-30 22:19:20 +0000 | [diff] [blame] | 1307 | return list(filter( |
| 1308 | lambda x: x.IsTestableFile(), |
| 1309 | self.AffectedFiles(include_deletes=False, **kwargs))) |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1310 | |
agable | 0b65e73 | 2016-11-22 09:25:46 -0800 | [diff] [blame] | 1311 | def AffectedTextFiles(self, include_deletes=None): |
| 1312 | """An alias to AffectedTestableFiles for backwards compatibility.""" |
| 1313 | return self.AffectedTestableFiles(include_deletes=include_deletes) |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1314 | |
agable | 0b65e73 | 2016-11-22 09:25:46 -0800 | [diff] [blame] | 1315 | def LocalPaths(self): |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1316 | """Convenience function.""" |
agable | 0b65e73 | 2016-11-22 09:25:46 -0800 | [diff] [blame] | 1317 | return [af.LocalPath() for af in self.AffectedFiles()] |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1318 | |
agable | 0b65e73 | 2016-11-22 09:25:46 -0800 | [diff] [blame] | 1319 | def AbsoluteLocalPaths(self): |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1320 | """Convenience function.""" |
agable | 0b65e73 | 2016-11-22 09:25:46 -0800 | [diff] [blame] | 1321 | return [af.AbsoluteLocalPath() for af in self.AffectedFiles()] |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1322 | |
| 1323 | def RightHandSideLines(self): |
Edward Lemur | a5799e3 | 2020-01-17 19:26:51 +0000 | [diff] [blame] | 1324 | """An iterator over all text lines in 'new' version of changed files. |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1325 | |
| 1326 | Lists lines from new or modified text files in the change. |
| 1327 | |
| 1328 | This is useful for doing line-by-line regex checks, like checking for |
| 1329 | trailing whitespace. |
| 1330 | |
| 1331 | Yields: |
| 1332 | a 3 tuple: |
| 1333 | the AffectedFile instance of the current file; |
| 1334 | integer line number (1-based); and |
| 1335 | the contents of the line as a string. |
| 1336 | """ |
maruel@chromium.org | cb2985f | 2010-11-03 14:08:31 +0000 | [diff] [blame] | 1337 | return _RightHandSideLinesImpl( |
| 1338 | x for x in self.AffectedFiles(include_deletes=False) |
agable | 0b65e73 | 2016-11-22 09:25:46 -0800 | [diff] [blame] | 1339 | if x.IsTestableFile()) |
agable@chromium.org | 40a3d0b | 2014-05-15 01:59:16 +0000 | [diff] [blame] | 1340 | |
Jochen Eisinger | d0573ec | 2017-04-13 10:55:06 +0200 | [diff] [blame] | 1341 | def OriginalOwnersFiles(self): |
| 1342 | """A map from path names of affected OWNERS files to their old content.""" |
| 1343 | def owners_file_filter(f): |
| 1344 | return 'OWNERS' in os.path.split(f.LocalPath())[1] |
| 1345 | files = self.AffectedFiles(file_filter=owners_file_filter) |
Aravind Vasudevan | c5f0cbb | 2022-01-24 23:56:57 +0000 | [diff] [blame] | 1346 | return {f.LocalPath(): f.OldContents() for f in files} |
Jochen Eisinger | d0573ec | 2017-04-13 10:55:06 +0200 | [diff] [blame] | 1347 | |
maruel@chromium.org | 4ff922a | 2009-06-12 20:20:19 +0000 | [diff] [blame] | 1348 | |
maruel@chromium.org | c70a220 | 2009-06-17 12:55:10 +0000 | [diff] [blame] | 1349 | class GitChange(Change): |
| 1350 | _AFFECTED_FILES = GitAffectedFile |
maruel@chromium.org | c193875 | 2011-04-12 23:11:13 +0000 | [diff] [blame] | 1351 | scm = 'git' |
thestig@chromium.org | da8cddd | 2009-08-13 00:25:55 +0000 | [diff] [blame] | 1352 | |
agable@chromium.org | 40a3d0b | 2014-05-15 01:59:16 +0000 | [diff] [blame] | 1353 | def AllFiles(self, root=None): |
| 1354 | """List all files under source control in the repo.""" |
| 1355 | root = root or self.RepositoryRoot() |
| 1356 | return subprocess.check_output( |
Aaron Gable | 7817f02 | 2017-12-12 09:43:17 -0800 | [diff] [blame] | 1357 | ['git', '-c', 'core.quotePath=false', 'ls-files', '--', '.'], |
Josip Sokcevic | 0b12346 | 2021-06-08 20:41:32 +0000 | [diff] [blame] | 1358 | cwd=root).decode('utf-8', 'ignore').splitlines() |
agable@chromium.org | 40a3d0b | 2014-05-15 01:59:16 +0000 | [diff] [blame] | 1359 | |
maruel@chromium.org | c70a220 | 2009-06-17 12:55:10 +0000 | [diff] [blame] | 1360 | |
maruel@chromium.org | 4661e0c | 2009-06-04 00:45:26 +0000 | [diff] [blame] | 1361 | def ListRelevantPresubmitFiles(files, root): |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1362 | """Finds all presubmit files that apply to a given set of source files. |
| 1363 | |
maruel@chromium.org | b1901a6 | 2010-06-16 00:18:47 +0000 | [diff] [blame] | 1364 | If inherit-review-settings-ok is present right under root, looks for |
| 1365 | PRESUBMIT.py in directories enclosing root. |
| 1366 | |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1367 | Args: |
| 1368 | files: An iterable container containing file paths. |
maruel@chromium.org | 4661e0c | 2009-06-04 00:45:26 +0000 | [diff] [blame] | 1369 | root: Path where to stop searching. |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1370 | |
| 1371 | Return: |
maruel@chromium.org | 4661e0c | 2009-06-04 00:45:26 +0000 | [diff] [blame] | 1372 | List of absolute paths of the existing PRESUBMIT.py scripts. |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1373 | """ |
maruel@chromium.org | b1901a6 | 2010-06-16 00:18:47 +0000 | [diff] [blame] | 1374 | files = [normpath(os.path.join(root, f)) for f in files] |
| 1375 | |
| 1376 | # List all the individual directories containing files. |
Aravind Vasudevan | c5f0cbb | 2022-01-24 23:56:57 +0000 | [diff] [blame] | 1377 | directories = {os.path.dirname(f) for f in files} |
maruel@chromium.org | b1901a6 | 2010-06-16 00:18:47 +0000 | [diff] [blame] | 1378 | |
| 1379 | # Ignore root if inherit-review-settings-ok is present. |
| 1380 | if os.path.isfile(os.path.join(root, 'inherit-review-settings-ok')): |
| 1381 | root = None |
| 1382 | |
| 1383 | # Collect all unique directories that may contain PRESUBMIT.py. |
| 1384 | candidates = set() |
| 1385 | for directory in directories: |
| 1386 | while True: |
| 1387 | if directory in candidates: |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1388 | break |
maruel@chromium.org | b1901a6 | 2010-06-16 00:18:47 +0000 | [diff] [blame] | 1389 | candidates.add(directory) |
| 1390 | if directory == root: |
maruel@chromium.org | 4661e0c | 2009-06-04 00:45:26 +0000 | [diff] [blame] | 1391 | break |
maruel@chromium.org | b1901a6 | 2010-06-16 00:18:47 +0000 | [diff] [blame] | 1392 | parent_dir = os.path.dirname(directory) |
| 1393 | if parent_dir == directory: |
| 1394 | # We hit the system root directory. |
| 1395 | break |
| 1396 | directory = parent_dir |
| 1397 | |
| 1398 | # Look for PRESUBMIT.py in all candidate directories. |
| 1399 | results = [] |
| 1400 | for directory in sorted(list(candidates)): |
tobiasjs | ff061c0 | 2016-08-17 03:23:57 -0700 | [diff] [blame] | 1401 | try: |
| 1402 | for f in os.listdir(directory): |
| 1403 | p = os.path.join(directory, f) |
| 1404 | if os.path.isfile(p) and re.match( |
| 1405 | r'PRESUBMIT.*\.py$', f) and not f.startswith('PRESUBMIT_test'): |
| 1406 | results.append(p) |
| 1407 | except OSError: |
| 1408 | pass |
maruel@chromium.org | b1901a6 | 2010-06-16 00:18:47 +0000 | [diff] [blame] | 1409 | |
tobiasjs | 2836bcf | 2016-08-16 04:08:16 -0700 | [diff] [blame] | 1410 | logging.debug('Presubmit files: %s', ','.join(results)) |
maruel@chromium.org | b1901a6 | 2010-06-16 00:18:47 +0000 | [diff] [blame] | 1411 | return results |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1412 | |
| 1413 | |
rmistry@google.com | 5626a92 | 2015-02-26 14:03:30 +0000 | [diff] [blame] | 1414 | class GetPostUploadExecuter(object): |
Pavol Marko | 624e7ee | 2023-01-09 09:56:29 +0000 | [diff] [blame] | 1415 | def __init__(self, change, gerrit_obj, use_python3): |
Josip Sokcevic | e293d3d | 2022-02-16 22:52:15 +0000 | [diff] [blame] | 1416 | """ |
| 1417 | Args: |
Pavol Marko | 624e7ee | 2023-01-09 09:56:29 +0000 | [diff] [blame] | 1418 | change: The Change object. |
| 1419 | gerrit_obj: provides basic Gerrit codereview functionality. |
Josip Sokcevic | e293d3d | 2022-02-16 22:52:15 +0000 | [diff] [blame] | 1420 | use_python3: if true, will use python3 instead of python2 by default |
| 1421 | if USE_PYTHON3 is not specified. |
| 1422 | """ |
Pavol Marko | 624e7ee | 2023-01-09 09:56:29 +0000 | [diff] [blame] | 1423 | self.change = change |
| 1424 | self.gerrit = gerrit_obj |
Josip Sokcevic | e293d3d | 2022-02-16 22:52:15 +0000 | [diff] [blame] | 1425 | self.use_python3 = use_python3 |
| 1426 | |
Pavol Marko | 624e7ee | 2023-01-09 09:56:29 +0000 | [diff] [blame] | 1427 | def ExecPresubmitScript(self, script_text, presubmit_path): |
rmistry@google.com | 5626a92 | 2015-02-26 14:03:30 +0000 | [diff] [blame] | 1428 | """Executes PostUploadHook() from a single presubmit script. |
Josip Sokcevic | 632bbc0 | 2022-05-19 05:32:50 +0000 | [diff] [blame] | 1429 | Caller is responsible for validating whether the hook should be executed |
| 1430 | and should only call this function if it should be. |
rmistry@google.com | 5626a92 | 2015-02-26 14:03:30 +0000 | [diff] [blame] | 1431 | |
| 1432 | Args: |
| 1433 | script_text: The text of the presubmit script. |
| 1434 | presubmit_path: Project script to run. |
rmistry@google.com | 5626a92 | 2015-02-26 14:03:30 +0000 | [diff] [blame] | 1435 | |
| 1436 | Return: |
| 1437 | A list of results objects. |
| 1438 | """ |
Pavol Marko | 624e7ee | 2023-01-09 09:56:29 +0000 | [diff] [blame] | 1439 | # Change to the presubmit file's directory to support local imports. |
| 1440 | presubmit_dir = os.path.dirname(presubmit_path) |
| 1441 | main_path = os.getcwd() |
| 1442 | try: |
| 1443 | os.chdir(presubmit_dir) |
| 1444 | return self._execute_with_local_working_directory(script_text, |
| 1445 | presubmit_dir, |
| 1446 | presubmit_path) |
| 1447 | finally: |
| 1448 | # Return the process to the original working directory. |
| 1449 | os.chdir(main_path) |
| 1450 | |
| 1451 | def _execute_with_local_working_directory(self, script_text, presubmit_dir, |
| 1452 | presubmit_path): |
rmistry@google.com | 5626a92 | 2015-02-26 14:03:30 +0000 | [diff] [blame] | 1453 | context = {} |
| 1454 | try: |
Pavol Marko | 624e7ee | 2023-01-09 09:56:29 +0000 | [diff] [blame] | 1455 | exec(compile(script_text, presubmit_path, 'exec', dont_inherit=True), |
Raul Tambre | 09e64b4 | 2019-05-14 01:57:22 +0000 | [diff] [blame] | 1456 | context) |
Raul Tambre | 7c93846 | 2019-05-24 16:35:35 +0000 | [diff] [blame] | 1457 | except Exception as e: |
rmistry@google.com | 5626a92 | 2015-02-26 14:03:30 +0000 | [diff] [blame] | 1458 | raise PresubmitFailure('"%s" had an exception.\n%s' |
| 1459 | % (presubmit_path, e)) |
| 1460 | |
| 1461 | function_name = 'PostUploadHook' |
| 1462 | if function_name not in context: |
| 1463 | return {} |
| 1464 | post_upload_hook = context[function_name] |
| 1465 | if not len(inspect.getargspec(post_upload_hook)[0]) == 3: |
| 1466 | raise PresubmitFailure( |
| 1467 | 'Expected function "PostUploadHook" to take three arguments.') |
Pavol Marko | 624e7ee | 2023-01-09 09:56:29 +0000 | [diff] [blame] | 1468 | return post_upload_hook(self.gerrit, self.change, OutputApi(False)) |
rmistry@google.com | 5626a92 | 2015-02-26 14:03:30 +0000 | [diff] [blame] | 1469 | |
| 1470 | |
machenbach@chromium.org | 58a69cb | 2014-03-01 02:08:29 +0000 | [diff] [blame] | 1471 | def _MergeMasters(masters1, masters2): |
| 1472 | """Merges two master maps. Merges also the tests of each builder.""" |
| 1473 | result = {} |
Marc-Antoine Ruel | 8e57b4b | 2019-10-11 01:01:36 +0000 | [diff] [blame] | 1474 | for (master, builders) in itertools.chain(masters1.items(), |
| 1475 | masters2.items()): |
machenbach@chromium.org | 58a69cb | 2014-03-01 02:08:29 +0000 | [diff] [blame] | 1476 | new_builders = result.setdefault(master, {}) |
Marc-Antoine Ruel | 8e57b4b | 2019-10-11 01:01:36 +0000 | [diff] [blame] | 1477 | for (builder, tests) in builders.items(): |
machenbach@chromium.org | 58a69cb | 2014-03-01 02:08:29 +0000 | [diff] [blame] | 1478 | new_builders.setdefault(builder, set([])).update(tests) |
| 1479 | return result |
| 1480 | |
| 1481 | |
Josip Sokcevic | e293d3d | 2022-02-16 22:52:15 +0000 | [diff] [blame] | 1482 | def DoPostUploadExecuter(change, gerrit_obj, verbose, use_python3=False): |
rmistry@google.com | 5626a92 | 2015-02-26 14:03:30 +0000 | [diff] [blame] | 1483 | """Execute the post upload hook. |
| 1484 | |
| 1485 | Args: |
| 1486 | change: The Change object. |
Edward Lemur | 016a087 | 2020-02-04 22:13:28 +0000 | [diff] [blame] | 1487 | gerrit_obj: The GerritAccessor object. |
rmistry@google.com | 5626a92 | 2015-02-26 14:03:30 +0000 | [diff] [blame] | 1488 | verbose: Prints debug info. |
Josip Sokcevic | e293d3d | 2022-02-16 22:52:15 +0000 | [diff] [blame] | 1489 | use_python3: if true, default to using Python3 for presubmit checks |
| 1490 | rather than Python2. |
rmistry@google.com | 5626a92 | 2015-02-26 14:03:30 +0000 | [diff] [blame] | 1491 | """ |
Josip Sokcevic | e293d3d | 2022-02-16 22:52:15 +0000 | [diff] [blame] | 1492 | python_version = 'Python %s' % sys.version_info.major |
| 1493 | sys.stdout.write('Running %s post upload checks ...\n' % python_version) |
rmistry@google.com | 5626a92 | 2015-02-26 14:03:30 +0000 | [diff] [blame] | 1494 | presubmit_files = ListRelevantPresubmitFiles( |
Edward Lemur | 6eb1d32 | 2020-02-27 22:20:15 +0000 | [diff] [blame] | 1495 | change.LocalPaths(), change.RepositoryRoot()) |
rmistry@google.com | 5626a92 | 2015-02-26 14:03:30 +0000 | [diff] [blame] | 1496 | if not presubmit_files and verbose: |
Edward Lemur | 6eb1d32 | 2020-02-27 22:20:15 +0000 | [diff] [blame] | 1497 | sys.stdout.write('Warning, no PRESUBMIT.py found.\n') |
rmistry@google.com | 5626a92 | 2015-02-26 14:03:30 +0000 | [diff] [blame] | 1498 | results = [] |
Pavol Marko | 624e7ee | 2023-01-09 09:56:29 +0000 | [diff] [blame] | 1499 | executer = GetPostUploadExecuter(change, gerrit_obj, use_python3) |
rmistry@google.com | 5626a92 | 2015-02-26 14:03:30 +0000 | [diff] [blame] | 1500 | # The root presubmit file should be executed after the ones in subdirectories. |
| 1501 | # i.e. the specific post upload hooks should run before the general ones. |
| 1502 | # Thus, reverse the order provided by ListRelevantPresubmitFiles. |
| 1503 | presubmit_files.reverse() |
| 1504 | |
| 1505 | for filename in presubmit_files: |
| 1506 | filename = os.path.abspath(filename) |
rmistry@google.com | 5626a92 | 2015-02-26 14:03:30 +0000 | [diff] [blame] | 1507 | # Accept CRLF presubmit script. |
Bruce Dawson | 6e70e86 | 2022-07-01 19:37:01 +0000 | [diff] [blame] | 1508 | presubmit_script = gclient_utils.FileRead(filename).replace('\r\n', '\n') |
Josip Sokcevic | 632bbc0 | 2022-05-19 05:32:50 +0000 | [diff] [blame] | 1509 | if _ShouldRunPresubmit(presubmit_script, use_python3): |
Bruce Dawson | 8d78bd1 | 2022-08-12 19:17:03 +0000 | [diff] [blame] | 1510 | if sys.version_info[0] == 2: |
Bruce Dawson | 443f985 | 2022-09-08 17:30:59 +0000 | [diff] [blame] | 1511 | sys.stdout.write( |
| 1512 | 'Running %s under Python 2. Add USE_PYTHON3 = True to prevent ' |
| 1513 | 'this.\n' % filename) |
Bruce Dawson | 8d78bd1 | 2022-08-12 19:17:03 +0000 | [diff] [blame] | 1514 | elif verbose: |
| 1515 | sys.stdout.write('Running %s\n' % filename) |
Pavol Marko | 624e7ee | 2023-01-09 09:56:29 +0000 | [diff] [blame] | 1516 | results.extend(executer.ExecPresubmitScript(presubmit_script, filename)) |
rmistry@google.com | 5626a92 | 2015-02-26 14:03:30 +0000 | [diff] [blame] | 1517 | |
Edward Lemur | 6eb1d32 | 2020-02-27 22:20:15 +0000 | [diff] [blame] | 1518 | if not results: |
| 1519 | return 0 |
| 1520 | |
| 1521 | sys.stdout.write('\n') |
| 1522 | sys.stdout.write('** Post Upload Hook Messages **\n') |
| 1523 | |
| 1524 | exit_code = 0 |
| 1525 | for result in results: |
| 1526 | if result.fatal: |
| 1527 | exit_code = 1 |
| 1528 | result.handle() |
| 1529 | sys.stdout.write('\n') |
| 1530 | |
| 1531 | return exit_code |
rmistry@google.com | 5626a92 | 2015-02-26 14:03:30 +0000 | [diff] [blame] | 1532 | |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1533 | class PresubmitExecuter(object): |
Saagar Sanghavi | 531d992 | 2020-08-10 20:14:01 +0000 | [diff] [blame] | 1534 | def __init__(self, change, committing, verbose, gerrit_obj, dry_run=None, |
Bruce Dawson | 09c0c07 | 2022-05-26 20:28:58 +0000 | [diff] [blame] | 1535 | thread_pool=None, parallel=False, use_python3=False, |
| 1536 | no_diffs=False): |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1537 | """ |
| 1538 | Args: |
maruel@chromium.org | 4ff922a | 2009-06-12 20:20:19 +0000 | [diff] [blame] | 1539 | change: The Change object. |
agable | 92bec4f | 2016-08-24 09:27:27 -0700 | [diff] [blame] | 1540 | committing: True if 'git cl land' is running, False if 'git cl upload' is. |
tandrii@chromium.org | 37b07a7 | 2016-04-29 16:42:28 +0000 | [diff] [blame] | 1541 | gerrit_obj: provides basic Gerrit codereview functionality. |
| 1542 | dry_run: if true, some Checks will be skipped. |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 1543 | parallel: if true, all tests reported via input_api.RunTests for all |
| 1544 | PRESUBMIT files will be run in parallel. |
Dirk Pranke | 6f0df68 | 2021-06-25 00:42:33 +0000 | [diff] [blame] | 1545 | use_python3: if true, will use python3 instead of python2 by default |
| 1546 | if USE_PYTHON3 is not specified. |
Bruce Dawson | 09c0c07 | 2022-05-26 20:28:58 +0000 | [diff] [blame] | 1547 | no_diffs: if true, implies that --files or --all was specified so some |
| 1548 | checks can be skipped, and some errors will be messages. |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1549 | """ |
maruel@chromium.org | 4ff922a | 2009-06-12 20:20:19 +0000 | [diff] [blame] | 1550 | self.change = change |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1551 | self.committing = committing |
tandrii@chromium.org | 37b07a7 | 2016-04-29 16:42:28 +0000 | [diff] [blame] | 1552 | self.gerrit = gerrit_obj |
maruel@chromium.org | 899e1c1 | 2011-04-07 17:03:18 +0000 | [diff] [blame] | 1553 | self.verbose = verbose |
tandrii@chromium.org | 57bafac | 2016-04-28 05:09:03 +0000 | [diff] [blame] | 1554 | self.dry_run = dry_run |
Daniel Cheng | 7227d21 | 2017-11-17 08:12:37 -0800 | [diff] [blame] | 1555 | self.more_cc = [] |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 1556 | self.thread_pool = thread_pool |
| 1557 | self.parallel = parallel |
Dirk Pranke | 6f0df68 | 2021-06-25 00:42:33 +0000 | [diff] [blame] | 1558 | self.use_python3 = use_python3 |
Bruce Dawson | 09c0c07 | 2022-05-26 20:28:58 +0000 | [diff] [blame] | 1559 | self.no_diffs = no_diffs |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1560 | |
| 1561 | def ExecPresubmitScript(self, script_text, presubmit_path): |
| 1562 | """Executes a single presubmit script. |
Josip Sokcevic | 632bbc0 | 2022-05-19 05:32:50 +0000 | [diff] [blame] | 1563 | Caller is responsible for validating whether the hook should be executed |
| 1564 | and should only call this function if it should be. |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1565 | |
| 1566 | Args: |
| 1567 | script_text: The text of the presubmit script. |
| 1568 | presubmit_path: The path to the presubmit file (this will be reported via |
| 1569 | input_api.PresubmitLocalPath()). |
| 1570 | |
| 1571 | Return: |
| 1572 | A list of result objects, empty if no problems. |
| 1573 | """ |
chase@chromium.org | 8e416c8 | 2009-10-06 04:30:44 +0000 | [diff] [blame] | 1574 | # Change to the presubmit file's directory to support local imports. |
Saagar Sanghavi | 98b332f | 2020-07-31 17:19:15 +0000 | [diff] [blame] | 1575 | presubmit_dir = os.path.dirname(presubmit_path) |
Pavol Marko | 624e7ee | 2023-01-09 09:56:29 +0000 | [diff] [blame] | 1576 | main_path = os.getcwd() |
| 1577 | try: |
| 1578 | os.chdir(presubmit_dir) |
| 1579 | return self._execute_with_local_working_directory(script_text, |
| 1580 | presubmit_dir, |
| 1581 | presubmit_path) |
| 1582 | finally: |
| 1583 | # Return the process to the original working directory. |
| 1584 | os.chdir(main_path) |
chase@chromium.org | 8e416c8 | 2009-10-06 04:30:44 +0000 | [diff] [blame] | 1585 | |
Pavol Marko | 624e7ee | 2023-01-09 09:56:29 +0000 | [diff] [blame] | 1586 | def _execute_with_local_working_directory(self, script_text, presubmit_dir, |
| 1587 | presubmit_path): |
chase@chromium.org | 8e416c8 | 2009-10-06 04:30:44 +0000 | [diff] [blame] | 1588 | # Load the presubmit script into context. |
dpranke@chromium.org | 970c522 | 2011-03-12 00:32:24 +0000 | [diff] [blame] | 1589 | input_api = InputApi(self.change, presubmit_path, self.committing, |
Aaron Gable | 668c1d8 | 2018-04-03 10:19:16 -0700 | [diff] [blame] | 1590 | self.verbose, gerrit_obj=self.gerrit, |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 1591 | dry_run=self.dry_run, thread_pool=self.thread_pool, |
Bruce Dawson | 09c0c07 | 2022-05-26 20:28:58 +0000 | [diff] [blame] | 1592 | parallel=self.parallel, no_diffs=self.no_diffs) |
Daniel Cheng | 7227d21 | 2017-11-17 08:12:37 -0800 | [diff] [blame] | 1593 | output_api = OutputApi(self.committing) |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1594 | context = {} |
Saagar Sanghavi | 03b1513 | 2020-08-10 16:43:41 +0000 | [diff] [blame] | 1595 | |
maruel@chromium.org | 899e1c1 | 2011-04-07 17:03:18 +0000 | [diff] [blame] | 1596 | try: |
Bruce Dawson | 0ba2fd4 | 2022-07-21 13:47:21 +0000 | [diff] [blame] | 1597 | exec(compile(script_text, presubmit_path, 'exec', dont_inherit=True), |
Raul Tambre | 09e64b4 | 2019-05-14 01:57:22 +0000 | [diff] [blame] | 1598 | context) |
Raul Tambre | 7c93846 | 2019-05-24 16:35:35 +0000 | [diff] [blame] | 1599 | except Exception as e: |
maruel@chromium.org | 899e1c1 | 2011-04-07 17:03:18 +0000 | [diff] [blame] | 1600 | raise PresubmitFailure('"%s" had an exception.\n%s' % (presubmit_path, e)) |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1601 | |
Saagar Sanghavi | 03b1513 | 2020-08-10 16:43:41 +0000 | [diff] [blame] | 1602 | context['__args'] = (input_api, output_api) |
Ben Pastene | 8351dc1 | 2020-08-06 05:01:35 +0000 | [diff] [blame] | 1603 | |
Saagar Sanghavi | 531d992 | 2020-08-10 20:14:01 +0000 | [diff] [blame] | 1604 | # Get path of presubmit directory relative to repository root. |
Saagar Sanghavi | 03b1513 | 2020-08-10 16:43:41 +0000 | [diff] [blame] | 1605 | # Always use forward slashes, so that path is same in *nix and Windows |
| 1606 | root = input_api.change.RepositoryRoot() |
| 1607 | rel_path = os.path.relpath(presubmit_dir, root) |
| 1608 | rel_path = rel_path.replace(os.path.sep, '/') |
Ben Pastene | 8351dc1 | 2020-08-06 05:01:35 +0000 | [diff] [blame] | 1609 | |
Saagar Sanghavi | 531d992 | 2020-08-10 20:14:01 +0000 | [diff] [blame] | 1610 | # Get the URL of git remote origin and use it to identify host and project |
Edward Lesmes | eb1bd62 | 2021-03-01 19:54:07 +0000 | [diff] [blame] | 1611 | host = project = '' |
| 1612 | if self.gerrit: |
| 1613 | host = self.gerrit.host or '' |
| 1614 | project = self.gerrit.project or '' |
Saagar Sanghavi | 531d992 | 2020-08-10 20:14:01 +0000 | [diff] [blame] | 1615 | |
| 1616 | # Prefix for test names |
| 1617 | prefix = 'presubmit:%s/%s:%s/' % (host, project, rel_path) |
| 1618 | |
Saagar Sanghavi | 03b1513 | 2020-08-10 16:43:41 +0000 | [diff] [blame] | 1619 | # Perform all the desired presubmit checks. |
| 1620 | results = [] |
Ben Pastene | 8351dc1 | 2020-08-06 05:01:35 +0000 | [diff] [blame] | 1621 | |
Saagar Sanghavi | 03b1513 | 2020-08-10 16:43:41 +0000 | [diff] [blame] | 1622 | try: |
Scott Lee | cc2fe9b | 2020-11-19 19:38:06 +0000 | [diff] [blame] | 1623 | version = [ |
| 1624 | int(x) for x in context.get('PRESUBMIT_VERSION', '0.0.0').split('.') |
| 1625 | ] |
Saagar Sanghavi | 03b1513 | 2020-08-10 16:43:41 +0000 | [diff] [blame] | 1626 | |
Scott Lee | cc2fe9b | 2020-11-19 19:38:06 +0000 | [diff] [blame] | 1627 | with rdb_wrapper.client(prefix) as sink: |
| 1628 | if version >= [2, 0, 0]: |
Andrew Grieve | bdfb8f2 | 2022-02-02 21:56:47 +0000 | [diff] [blame] | 1629 | # Copy the keys to prevent "dictionary changed size during iteration" |
| 1630 | # exception if checks add globals to context. E.g. sometimes the |
| 1631 | # Python runtime will add __warningregistry__. |
| 1632 | for function_name in list(context.keys()): |
Scott Lee | cc2fe9b | 2020-11-19 19:38:06 +0000 | [diff] [blame] | 1633 | if not function_name.startswith('Check'): |
| 1634 | continue |
| 1635 | if function_name.endswith('Commit') and not self.committing: |
| 1636 | continue |
| 1637 | if function_name.endswith('Upload') and self.committing: |
| 1638 | continue |
Saagar Sanghavi | 03b1513 | 2020-08-10 16:43:41 +0000 | [diff] [blame] | 1639 | logging.debug('Running %s in %s', function_name, presubmit_path) |
| 1640 | results.extend( |
Bruce Dawson | 8fa42e2 | 2022-03-29 17:05:38 +0000 | [diff] [blame] | 1641 | self._run_check_function(function_name, context, sink, |
| 1642 | presubmit_path)) |
Scott Lee | cc2fe9b | 2020-11-19 19:38:06 +0000 | [diff] [blame] | 1643 | logging.debug('Running %s done.', function_name) |
| 1644 | self.more_cc.extend(output_api.more_cc) |
| 1645 | |
| 1646 | else: # Old format |
| 1647 | if self.committing: |
| 1648 | function_name = 'CheckChangeOnCommit' |
| 1649 | else: |
| 1650 | function_name = 'CheckChangeOnUpload' |
Andrew Grieve | bdfb8f2 | 2022-02-02 21:56:47 +0000 | [diff] [blame] | 1651 | if function_name in list(context.keys()): |
Scott Lee | cc2fe9b | 2020-11-19 19:38:06 +0000 | [diff] [blame] | 1652 | logging.debug('Running %s in %s', function_name, presubmit_path) |
| 1653 | results.extend( |
Bruce Dawson | 8fa42e2 | 2022-03-29 17:05:38 +0000 | [diff] [blame] | 1654 | self._run_check_function(function_name, context, sink, |
| 1655 | presubmit_path)) |
Saagar Sanghavi | 03b1513 | 2020-08-10 16:43:41 +0000 | [diff] [blame] | 1656 | logging.debug('Running %s done.', function_name) |
| 1657 | self.more_cc.extend(output_api.more_cc) |
| 1658 | |
| 1659 | finally: |
| 1660 | for f in input_api._named_temporary_files: |
| 1661 | os.remove(f) |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1662 | |
Saagar Sanghavi | 03b1513 | 2020-08-10 16:43:41 +0000 | [diff] [blame] | 1663 | return results |
| 1664 | |
Bruce Dawson | 8fa42e2 | 2022-03-29 17:05:38 +0000 | [diff] [blame] | 1665 | def _run_check_function(self, function_name, context, sink, presubmit_path): |
Scott Lee | cc2fe9b | 2020-11-19 19:38:06 +0000 | [diff] [blame] | 1666 | """Evaluates and returns the result of a given presubmit function. |
| 1667 | |
| 1668 | If sink is given, the result of the presubmit function will be reported |
| 1669 | to the ResultSink. |
Saagar Sanghavi | 03b1513 | 2020-08-10 16:43:41 +0000 | [diff] [blame] | 1670 | |
| 1671 | Args: |
Scott Lee | cc2fe9b | 2020-11-19 19:38:06 +0000 | [diff] [blame] | 1672 | function_name: the name of the presubmit function to evaluate |
Saagar Sanghavi | 03b1513 | 2020-08-10 16:43:41 +0000 | [diff] [blame] | 1673 | context: a context dictionary in which the function will be evaluated |
Scott Lee | cc2fe9b | 2020-11-19 19:38:06 +0000 | [diff] [blame] | 1674 | sink: an instance of ResultSink. None, by default. |
| 1675 | Returns: |
| 1676 | the result of the presubmit function call. |
| 1677 | """ |
| 1678 | start_time = time_time() |
| 1679 | try: |
Saagar Sanghavi | 03b1513 | 2020-08-10 16:43:41 +0000 | [diff] [blame] | 1680 | result = eval(function_name + '(*__args)', context) |
| 1681 | self._check_result_type(result) |
Allen Webb | fe7d709 | 2021-05-18 02:05:49 +0000 | [diff] [blame] | 1682 | except Exception: |
Bruce Dawson | 10a8286 | 2022-05-27 19:25:56 +0000 | [diff] [blame] | 1683 | _, e_value, _ = sys.exc_info() |
| 1684 | result = [ |
| 1685 | OutputApi.PresubmitError( |
| 1686 | 'Evaluation of %s failed: %s, %s' % |
| 1687 | (function_name, e_value, traceback.format_exc())) |
| 1688 | ] |
Scott Lee | cc2fe9b | 2020-11-19 19:38:06 +0000 | [diff] [blame] | 1689 | |
Bruce Dawson | 2bdc49f | 2021-05-21 19:13:03 +0000 | [diff] [blame] | 1690 | elapsed_time = time_time() - start_time |
| 1691 | if elapsed_time > 10.0: |
Bruce Dawson | 6757d46 | 2022-07-13 04:04:40 +0000 | [diff] [blame] | 1692 | sys.stdout.write('%6.1fs to run %s from %s.\n' % |
| 1693 | (elapsed_time, function_name, presubmit_path)) |
Scott Lee | cc2fe9b | 2020-11-19 19:38:06 +0000 | [diff] [blame] | 1694 | if sink: |
Erik Staab | 9f38b63 | 2022-10-31 14:05:24 +0000 | [diff] [blame] | 1695 | failure_reason = None |
Scott Lee | cc2fe9b | 2020-11-19 19:38:06 +0000 | [diff] [blame] | 1696 | status = rdb_wrapper.STATUS_PASS |
| 1697 | if any(r.fatal for r in result): |
| 1698 | status = rdb_wrapper.STATUS_FAIL |
Erik Staab | 9f38b63 | 2022-10-31 14:05:24 +0000 | [diff] [blame] | 1699 | failure_reasons = [] |
| 1700 | for r in result: |
| 1701 | fields = r.json_format() |
| 1702 | message = fields['message'] |
| 1703 | items = '\n'.join(' %s' % item for item in fields['items']) |
| 1704 | failure_reasons.append('\n'.join([message, items])) |
| 1705 | if failure_reasons: |
| 1706 | failure_reason = '\n'.join(failure_reasons) |
| 1707 | sink.report(function_name, status, elapsed_time, failure_reason) |
Scott Lee | cc2fe9b | 2020-11-19 19:38:06 +0000 | [diff] [blame] | 1708 | |
| 1709 | return result |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1710 | |
Saagar Sanghavi | 9949ab7 | 2020-07-20 20:56:40 +0000 | [diff] [blame] | 1711 | def _check_result_type(self, result): |
| 1712 | """Helper function which ensures result is a list, and all elements are |
| 1713 | instances of OutputApi.PresubmitResult""" |
| 1714 | if not isinstance(result, (tuple, list)): |
| 1715 | raise PresubmitFailure('Presubmit functions must return a tuple or list') |
| 1716 | if not all(isinstance(res, OutputApi.PresubmitResult) for res in result): |
| 1717 | raise PresubmitFailure( |
| 1718 | 'All presubmit results must be of types derived from ' |
| 1719 | 'output_api.PresubmitResult') |
| 1720 | |
| 1721 | |
maruel@chromium.org | 4ff922a | 2009-06-12 20:20:19 +0000 | [diff] [blame] | 1722 | def DoPresubmitChecks(change, |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1723 | committing, |
| 1724 | verbose, |
maruel@chromium.org | b0dfd35 | 2009-06-10 14:12:54 +0000 | [diff] [blame] | 1725 | default_presubmit, |
dpranke@chromium.org | 970c522 | 2011-03-12 00:32:24 +0000 | [diff] [blame] | 1726 | may_prompt, |
Aaron Gable | 668c1d8 | 2018-04-03 10:19:16 -0700 | [diff] [blame] | 1727 | gerrit_obj, |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 1728 | dry_run=None, |
Debrian Figueroa | dd2737e | 2019-06-21 23:50:13 +0000 | [diff] [blame] | 1729 | parallel=False, |
Dirk Pranke | 6f0df68 | 2021-06-25 00:42:33 +0000 | [diff] [blame] | 1730 | json_output=None, |
Bruce Dawson | 09c0c07 | 2022-05-26 20:28:58 +0000 | [diff] [blame] | 1731 | use_python3=False, |
| 1732 | no_diffs=False): |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1733 | """Runs all presubmit checks that apply to the files in the change. |
| 1734 | |
| 1735 | This finds all PRESUBMIT.py files in directories enclosing the files in the |
| 1736 | change (up to the repository root) and calls the relevant entrypoint function |
| 1737 | depending on whether the change is being committed or uploaded. |
| 1738 | |
| 1739 | Prints errors, warnings and notifications. Prompts the user for warnings |
| 1740 | when needed. |
| 1741 | |
| 1742 | Args: |
maruel@chromium.org | 4ff922a | 2009-06-12 20:20:19 +0000 | [diff] [blame] | 1743 | change: The Change object. |
agable | 92bec4f | 2016-08-24 09:27:27 -0700 | [diff] [blame] | 1744 | committing: True if 'git cl land' is running, False if 'git cl upload' is. |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1745 | verbose: Prints debug info. |
maruel@chromium.org | 0ff1fab | 2009-05-22 13:08:15 +0000 | [diff] [blame] | 1746 | default_presubmit: A default presubmit script to execute in any case. |
Quinten Yearsley | 516fe7f | 2016-12-14 11:50:18 -0800 | [diff] [blame] | 1747 | may_prompt: Enable (y/n) questions on warning or error. If False, |
| 1748 | any questions are answered with yes by default. |
tandrii@chromium.org | 37b07a7 | 2016-04-29 16:42:28 +0000 | [diff] [blame] | 1749 | gerrit_obj: provides basic Gerrit codereview functionality. |
tandrii@chromium.org | 57bafac | 2016-04-28 05:09:03 +0000 | [diff] [blame] | 1750 | dry_run: if true, some Checks will be skipped. |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 1751 | parallel: if true, all tests specified by input_api.RunTests in all |
| 1752 | PRESUBMIT files will be run in parallel. |
Dirk Pranke | 6f0df68 | 2021-06-25 00:42:33 +0000 | [diff] [blame] | 1753 | use_python3: if true, default to using Python3 for presubmit checks |
| 1754 | rather than Python2. |
Bruce Dawson | 09c0c07 | 2022-05-26 20:28:58 +0000 | [diff] [blame] | 1755 | no_diffs: if true, implies that --files or --all was specified so some |
| 1756 | checks can be skipped, and some errors will be messages. |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1757 | Return: |
Edward Lemur | 6eb1d32 | 2020-02-27 22:20:15 +0000 | [diff] [blame] | 1758 | 1 if presubmit checks failed or 0 otherwise. |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1759 | """ |
maruel@chromium.org | ea7c855 | 2011-04-18 14:12:07 +0000 | [diff] [blame] | 1760 | old_environ = os.environ |
| 1761 | try: |
| 1762 | # Make sure python subprocesses won't generate .pyc files. |
| 1763 | os.environ = os.environ.copy() |
Edward Lemur | b983024 | 2019-10-30 22:19:20 +0000 | [diff] [blame] | 1764 | os.environ['PYTHONDONTWRITEBYTECODE'] = '1' |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1765 | |
Dirk Pranke | 61bf6e8 | 2021-04-23 00:50:21 +0000 | [diff] [blame] | 1766 | python_version = 'Python %s' % sys.version_info.major |
maruel@chromium.org | ea7c855 | 2011-04-18 14:12:07 +0000 | [diff] [blame] | 1767 | if committing: |
Dirk Pranke | 6fc394f | 2021-05-26 23:25:14 +0000 | [diff] [blame] | 1768 | sys.stdout.write('Running %s presubmit commit checks ...\n' % |
Dirk Pranke | 61bf6e8 | 2021-04-23 00:50:21 +0000 | [diff] [blame] | 1769 | python_version) |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1770 | else: |
Dirk Pranke | 61bf6e8 | 2021-04-23 00:50:21 +0000 | [diff] [blame] | 1771 | sys.stdout.write('Running %s presubmit upload checks ...\n' % |
| 1772 | python_version) |
Edward Lemur | ecc2707 | 2020-01-06 16:42:34 +0000 | [diff] [blame] | 1773 | start_time = time_time() |
maruel@chromium.org | ea7c855 | 2011-04-18 14:12:07 +0000 | [diff] [blame] | 1774 | presubmit_files = ListRelevantPresubmitFiles( |
agable | 0b65e73 | 2016-11-22 09:25:46 -0800 | [diff] [blame] | 1775 | change.AbsoluteLocalPaths(), change.RepositoryRoot()) |
maruel@chromium.org | ea7c855 | 2011-04-18 14:12:07 +0000 | [diff] [blame] | 1776 | if not presubmit_files and verbose: |
Edward Lemur | 6eb1d32 | 2020-02-27 22:20:15 +0000 | [diff] [blame] | 1777 | sys.stdout.write('Warning, no PRESUBMIT.py found.\n') |
maruel@chromium.org | ea7c855 | 2011-04-18 14:12:07 +0000 | [diff] [blame] | 1778 | results = [] |
Bruce Dawson | c9f904f | 2022-10-14 20:59:49 +0000 | [diff] [blame] | 1779 | if sys.platform == 'win32': |
| 1780 | temp = os.environ['TEMP'] |
| 1781 | else: |
| 1782 | temp = '/tmp' |
| 1783 | python2_usage_log_file = os.path.join(temp, 'python2_usage.txt') |
Bruce Dawson | f2b0421 | 2022-06-10 16:42:54 +0000 | [diff] [blame] | 1784 | if os.path.exists(python2_usage_log_file): |
| 1785 | os.remove(python2_usage_log_file) |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 1786 | thread_pool = ThreadPool() |
Edward Lemur | 7e3c67f | 2018-07-20 20:52:49 +0000 | [diff] [blame] | 1787 | executer = PresubmitExecuter(change, committing, verbose, gerrit_obj, |
Bruce Dawson | 09c0c07 | 2022-05-26 20:28:58 +0000 | [diff] [blame] | 1788 | dry_run, thread_pool, parallel, use_python3, |
| 1789 | no_diffs) |
Josip Sokcevic | 632bbc0 | 2022-05-19 05:32:50 +0000 | [diff] [blame] | 1790 | skipped_count = 0; |
maruel@chromium.org | ea7c855 | 2011-04-18 14:12:07 +0000 | [diff] [blame] | 1791 | if default_presubmit: |
| 1792 | if verbose: |
Edward Lemur | 6eb1d32 | 2020-02-27 22:20:15 +0000 | [diff] [blame] | 1793 | sys.stdout.write('Running default presubmit script.\n') |
maruel@chromium.org | ea7c855 | 2011-04-18 14:12:07 +0000 | [diff] [blame] | 1794 | fake_path = os.path.join(change.RepositoryRoot(), 'PRESUBMIT.py') |
Josip Sokcevic | 632bbc0 | 2022-05-19 05:32:50 +0000 | [diff] [blame] | 1795 | if _ShouldRunPresubmit(default_presubmit, use_python3): |
| 1796 | results += executer.ExecPresubmitScript(default_presubmit, fake_path) |
| 1797 | else: |
| 1798 | skipped_count += 1 |
maruel@chromium.org | ea7c855 | 2011-04-18 14:12:07 +0000 | [diff] [blame] | 1799 | for filename in presubmit_files: |
| 1800 | filename = os.path.abspath(filename) |
maruel@chromium.org | ea7c855 | 2011-04-18 14:12:07 +0000 | [diff] [blame] | 1801 | # Accept CRLF presubmit script. |
Bruce Dawson | 6e70e86 | 2022-07-01 19:37:01 +0000 | [diff] [blame] | 1802 | presubmit_script = gclient_utils.FileRead(filename).replace('\r\n', '\n') |
Josip Sokcevic | 632bbc0 | 2022-05-19 05:32:50 +0000 | [diff] [blame] | 1803 | if _ShouldRunPresubmit(presubmit_script, use_python3): |
Bruce Dawson | 8d78bd1 | 2022-08-12 19:17:03 +0000 | [diff] [blame] | 1804 | if sys.version_info[0] == 2: |
Bruce Dawson | 443f985 | 2022-09-08 17:30:59 +0000 | [diff] [blame] | 1805 | sys.stdout.write( |
| 1806 | 'Running %s under Python 2. Add USE_PYTHON3 = True to prevent ' |
| 1807 | 'this.\n' % filename) |
Bruce Dawson | 8d78bd1 | 2022-08-12 19:17:03 +0000 | [diff] [blame] | 1808 | elif verbose: |
| 1809 | sys.stdout.write('Running %s\n' % filename) |
Josip Sokcevic | 632bbc0 | 2022-05-19 05:32:50 +0000 | [diff] [blame] | 1810 | results += executer.ExecPresubmitScript(presubmit_script, filename) |
| 1811 | else: |
| 1812 | skipped_count += 1 |
Bruce Dawson | 76fe1a7 | 2022-05-25 20:52:21 +0000 | [diff] [blame] | 1813 | |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 1814 | results += thread_pool.RunAsync() |
| 1815 | |
Bruce Dawson | f2b0421 | 2022-06-10 16:42:54 +0000 | [diff] [blame] | 1816 | if os.path.exists(python2_usage_log_file): |
| 1817 | with open(python2_usage_log_file) as f: |
| 1818 | python2_usage = [x.strip() for x in f.readlines()] |
| 1819 | results.append( |
| 1820 | OutputApi(committing).PresubmitPromptWarning( |
| 1821 | 'Python 2 scripts were run during %s presubmits. Please see ' |
| 1822 | 'https://bugs.chromium.org/p/chromium/issues/detail?id=1313804' |
| 1823 | '#c61 for tips on resolving this.' |
| 1824 | % python_version, |
| 1825 | items=python2_usage)) |
| 1826 | |
Edward Lemur | 6eb1d32 | 2020-02-27 22:20:15 +0000 | [diff] [blame] | 1827 | messages = {} |
| 1828 | should_prompt = False |
| 1829 | presubmits_failed = False |
maruel@chromium.org | ea7c855 | 2011-04-18 14:12:07 +0000 | [diff] [blame] | 1830 | for result in results: |
| 1831 | if result.fatal: |
Edward Lemur | 6eb1d32 | 2020-02-27 22:20:15 +0000 | [diff] [blame] | 1832 | presubmits_failed = True |
| 1833 | messages.setdefault('ERRORS', []).append(result) |
maruel@chromium.org | ea7c855 | 2011-04-18 14:12:07 +0000 | [diff] [blame] | 1834 | elif result.should_prompt: |
Edward Lemur | 6eb1d32 | 2020-02-27 22:20:15 +0000 | [diff] [blame] | 1835 | should_prompt = True |
| 1836 | messages.setdefault('Warnings', []).append(result) |
maruel@chromium.org | ea7c855 | 2011-04-18 14:12:07 +0000 | [diff] [blame] | 1837 | else: |
Edward Lemur | 6eb1d32 | 2020-02-27 22:20:15 +0000 | [diff] [blame] | 1838 | messages.setdefault('Messages', []).append(result) |
pam@chromium.org | ed9a083 | 2009-09-09 22:48:55 +0000 | [diff] [blame] | 1839 | |
Bruce Dawson | 76fe1a7 | 2022-05-25 20:52:21 +0000 | [diff] [blame] | 1840 | # Print the different message types in a consistent order. ERRORS go last |
| 1841 | # so that they will be most visible in the local-presubmit output. |
| 1842 | for name in ['Messages', 'Warnings', 'ERRORS']: |
| 1843 | if name in messages: |
| 1844 | items = messages[name] |
Gavin Mak | d22bf60 | 2022-07-11 21:10:41 +0000 | [diff] [blame] | 1845 | sys.stdout.write('** Presubmit %s: %d **\n' % (name, len(items))) |
Bruce Dawson | 76fe1a7 | 2022-05-25 20:52:21 +0000 | [diff] [blame] | 1846 | for item in items: |
| 1847 | item.handle() |
| 1848 | sys.stdout.write('\n') |
pam@chromium.org | ed9a083 | 2009-09-09 22:48:55 +0000 | [diff] [blame] | 1849 | |
Edward Lemur | ecc2707 | 2020-01-06 16:42:34 +0000 | [diff] [blame] | 1850 | total_time = time_time() - start_time |
maruel@chromium.org | ea7c855 | 2011-04-18 14:12:07 +0000 | [diff] [blame] | 1851 | if total_time > 1.0: |
Edward Lemur | 6eb1d32 | 2020-02-27 22:20:15 +0000 | [diff] [blame] | 1852 | sys.stdout.write( |
Louis Romero | 4ca9e1c | 2022-03-10 10:29:11 +0000 | [diff] [blame] | 1853 | 'Presubmit checks took %.1fs to calculate.\n' % total_time) |
maruel@chromium.org | ce8e46b | 2009-06-26 22:31:51 +0000 | [diff] [blame] | 1854 | |
Edward Lemur | 6eb1d32 | 2020-02-27 22:20:15 +0000 | [diff] [blame] | 1855 | if not should_prompt and not presubmits_failed: |
Louis Romero | 4ca9e1c | 2022-03-10 10:29:11 +0000 | [diff] [blame] | 1856 | sys.stdout.write('%s presubmit checks passed.\n\n' % python_version) |
Josip Sokcevic | 7592e0a | 2022-01-12 00:57:54 +0000 | [diff] [blame] | 1857 | elif should_prompt and not presubmits_failed: |
Dirk Pranke | 61bf6e8 | 2021-04-23 00:50:21 +0000 | [diff] [blame] | 1858 | sys.stdout.write('There were %s presubmit warnings. ' % python_version) |
Quinten Yearsley | 516fe7f | 2016-12-14 11:50:18 -0800 | [diff] [blame] | 1859 | if may_prompt: |
Edward Lemur | 6eb1d32 | 2020-02-27 22:20:15 +0000 | [diff] [blame] | 1860 | presubmits_failed = not prompt_should_continue( |
| 1861 | 'Are you sure you wish to continue? (y/N): ') |
Garrett Beaty | acb807e | 2020-08-28 18:17:24 +0000 | [diff] [blame] | 1862 | else: |
| 1863 | sys.stdout.write('\n') |
Bruce Dawson | 76fe1a7 | 2022-05-25 20:52:21 +0000 | [diff] [blame] | 1864 | else: |
| 1865 | sys.stdout.write('There were %s presubmit errors.\n' % python_version) |
maruel@chromium.org | ea7c855 | 2011-04-18 14:12:07 +0000 | [diff] [blame] | 1866 | |
Edward Lemur | 1dc66e1 | 2020-02-21 21:36:34 +0000 | [diff] [blame] | 1867 | if json_output: |
| 1868 | # Write the presubmit results to json output |
| 1869 | presubmit_results = { |
| 1870 | 'errors': [ |
Edward Lemur | 6eb1d32 | 2020-02-27 22:20:15 +0000 | [diff] [blame] | 1871 | error.json_format() |
| 1872 | for error in messages.get('ERRORS', []) |
Edward Lemur | 1dc66e1 | 2020-02-21 21:36:34 +0000 | [diff] [blame] | 1873 | ], |
| 1874 | 'notifications': [ |
Edward Lemur | 6eb1d32 | 2020-02-27 22:20:15 +0000 | [diff] [blame] | 1875 | notification.json_format() |
| 1876 | for notification in messages.get('Messages', []) |
Edward Lemur | 1dc66e1 | 2020-02-21 21:36:34 +0000 | [diff] [blame] | 1877 | ], |
| 1878 | 'warnings': [ |
Edward Lemur | 6eb1d32 | 2020-02-27 22:20:15 +0000 | [diff] [blame] | 1879 | warning.json_format() |
| 1880 | for warning in messages.get('Warnings', []) |
Edward Lemur | 1dc66e1 | 2020-02-21 21:36:34 +0000 | [diff] [blame] | 1881 | ], |
Edward Lemur | 6eb1d32 | 2020-02-27 22:20:15 +0000 | [diff] [blame] | 1882 | 'more_cc': executer.more_cc, |
Josip Sokcevic | 632bbc0 | 2022-05-19 05:32:50 +0000 | [diff] [blame] | 1883 | 'skipped_presubmits': skipped_count, |
Edward Lemur | 1dc66e1 | 2020-02-21 21:36:34 +0000 | [diff] [blame] | 1884 | } |
| 1885 | |
| 1886 | gclient_utils.FileWrite( |
| 1887 | json_output, json.dumps(presubmit_results, sort_keys=True)) |
| 1888 | |
maruel@chromium.org | ea7c855 | 2011-04-18 14:12:07 +0000 | [diff] [blame] | 1889 | global _ASKED_FOR_FEEDBACK |
| 1890 | # Ask for feedback one time out of 5. |
Aravind Vasudevan | c5f0cbb | 2022-01-24 23:56:57 +0000 | [diff] [blame] | 1891 | if (results and random.randint(0, 4) == 0 and not _ASKED_FOR_FEEDBACK): |
Edward Lemur | 6eb1d32 | 2020-02-27 22:20:15 +0000 | [diff] [blame] | 1892 | sys.stdout.write( |
maruel@chromium.org | 1ce8e66 | 2014-01-14 15:23:00 +0000 | [diff] [blame] | 1893 | 'Was the presubmit check useful? If not, run "git cl presubmit -v"\n' |
| 1894 | 'to figure out which PRESUBMIT.py was run, then run git blame\n' |
| 1895 | 'on the file to figure out who to ask for help.\n') |
maruel@chromium.org | ea7c855 | 2011-04-18 14:12:07 +0000 | [diff] [blame] | 1896 | _ASKED_FOR_FEEDBACK = True |
Edward Lemur | 6eb1d32 | 2020-02-27 22:20:15 +0000 | [diff] [blame] | 1897 | |
| 1898 | return 1 if presubmits_failed else 0 |
maruel@chromium.org | ea7c855 | 2011-04-18 14:12:07 +0000 | [diff] [blame] | 1899 | finally: |
| 1900 | os.environ = old_environ |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1901 | |
| 1902 | |
Edward Lemur | 50984a6 | 2020-02-06 18:10:18 +0000 | [diff] [blame] | 1903 | def _scan_sub_dirs(mask, recursive): |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1904 | if not recursive: |
pgervais@chromium.org | e57b09d | 2014-05-07 00:58:13 +0000 | [diff] [blame] | 1905 | return [x for x in glob.glob(mask) if x not in ('.svn', '.git')] |
Lei Zhang | 9611c4c | 2017-04-04 01:41:56 -0700 | [diff] [blame] | 1906 | |
| 1907 | results = [] |
| 1908 | for root, dirs, files in os.walk('.'): |
| 1909 | if '.svn' in dirs: |
| 1910 | dirs.remove('.svn') |
| 1911 | if '.git' in dirs: |
| 1912 | dirs.remove('.git') |
| 1913 | for name in files: |
| 1914 | if fnmatch.fnmatch(name, mask): |
| 1915 | results.append(os.path.join(root, name)) |
| 1916 | return results |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1917 | |
| 1918 | |
Edward Lemur | 50984a6 | 2020-02-06 18:10:18 +0000 | [diff] [blame] | 1919 | def _parse_files(args, recursive): |
tobiasjs | 2836bcf | 2016-08-16 04:08:16 -0700 | [diff] [blame] | 1920 | logging.debug('Searching for %s', args) |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1921 | files = [] |
| 1922 | for arg in args: |
Edward Lemur | 50984a6 | 2020-02-06 18:10:18 +0000 | [diff] [blame] | 1923 | files.extend([('M', f) for f in _scan_sub_dirs(arg, recursive)]) |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 1924 | return files |
| 1925 | |
| 1926 | |
Edward Lemur | 50984a6 | 2020-02-06 18:10:18 +0000 | [diff] [blame] | 1927 | def _parse_change(parser, options): |
| 1928 | """Process change options. |
| 1929 | |
| 1930 | Args: |
| 1931 | parser: The parser used to parse the arguments from command line. |
| 1932 | options: The arguments parsed from command line. |
| 1933 | Returns: |
| 1934 | A GitChange if the change root is a git repository, or a Change otherwise. |
| 1935 | """ |
| 1936 | if options.files and options.all_files: |
| 1937 | parser.error('<files> cannot be specified when --all-files is set.') |
| 1938 | |
Edward Lesmes | 44ea3ff | 2020-02-05 00:14:30 +0000 | [diff] [blame] | 1939 | change_scm = scm.determine_scm(options.root) |
Edward Lemur | 50984a6 | 2020-02-06 18:10:18 +0000 | [diff] [blame] | 1940 | if change_scm != 'git' and not options.files: |
| 1941 | parser.error('<files> is not optional for unversioned directories.') |
| 1942 | |
| 1943 | if options.files: |
Josip Sokcevic | 017544d | 2022-03-31 23:47:53 +0000 | [diff] [blame] | 1944 | if options.source_controlled_only: |
| 1945 | # Get the filtered set of files from SCM. |
| 1946 | change_files = [] |
| 1947 | for name in scm.GIT.GetAllFiles(options.root): |
| 1948 | for mask in options.files: |
| 1949 | if fnmatch.fnmatch(name, mask): |
| 1950 | change_files.append(('M', name)) |
| 1951 | break |
| 1952 | else: |
| 1953 | # Get the filtered set of files from a directory scan. |
| 1954 | change_files = _parse_files(options.files, options.recursive) |
Edward Lemur | 50984a6 | 2020-02-06 18:10:18 +0000 | [diff] [blame] | 1955 | elif options.all_files: |
| 1956 | change_files = [('M', f) for f in scm.GIT.GetAllFiles(options.root)] |
maruel@chromium.org | 5c8c6de | 2011-03-18 16:20:18 +0000 | [diff] [blame] | 1957 | else: |
Edward Lemur | 50984a6 | 2020-02-06 18:10:18 +0000 | [diff] [blame] | 1958 | change_files = scm.GIT.CaptureStatus( |
Edward Lemur | 7f6dec0 | 2020-02-06 20:23:58 +0000 | [diff] [blame] | 1959 | options.root, options.upstream or None) |
Edward Lemur | 50984a6 | 2020-02-06 18:10:18 +0000 | [diff] [blame] | 1960 | |
| 1961 | logging.info('Found %d file(s).', len(change_files)) |
| 1962 | |
| 1963 | change_class = GitChange if change_scm == 'git' else Change |
| 1964 | return change_class( |
| 1965 | options.name, |
| 1966 | options.description, |
| 1967 | options.root, |
| 1968 | change_files, |
| 1969 | options.issue, |
| 1970 | options.patchset, |
| 1971 | options.author, |
| 1972 | upstream=options.upstream) |
| 1973 | |
| 1974 | |
| 1975 | def _parse_gerrit_options(parser, options): |
| 1976 | """Process gerrit options. |
| 1977 | |
| 1978 | SIDE EFFECTS: Modifies options.author and options.description from Gerrit if |
| 1979 | options.gerrit_fetch is set. |
| 1980 | |
| 1981 | Args: |
| 1982 | parser: The parser used to parse the arguments from command line. |
| 1983 | options: The arguments parsed from command line. |
| 1984 | Returns: |
Stephen Martinis | fb09de2 | 2021-02-25 03:41:13 +0000 | [diff] [blame] | 1985 | A GerritAccessor object if options.gerrit_url is set, or None otherwise. |
Edward Lemur | 50984a6 | 2020-02-06 18:10:18 +0000 | [diff] [blame] | 1986 | """ |
| 1987 | gerrit_obj = None |
Stephen Martinis | fb09de2 | 2021-02-25 03:41:13 +0000 | [diff] [blame] | 1988 | if options.gerrit_url: |
Edward Lesmes | eb1bd62 | 2021-03-01 19:54:07 +0000 | [diff] [blame] | 1989 | gerrit_obj = GerritAccessor( |
| 1990 | url=options.gerrit_url, |
| 1991 | project=options.gerrit_project, |
| 1992 | branch=options.gerrit_branch) |
Edward Lemur | 50984a6 | 2020-02-06 18:10:18 +0000 | [diff] [blame] | 1993 | |
| 1994 | if not options.gerrit_fetch: |
| 1995 | return gerrit_obj |
| 1996 | |
| 1997 | if not options.gerrit_url or not options.issue or not options.patchset: |
| 1998 | parser.error( |
| 1999 | '--gerrit_fetch requires --gerrit_url, --issue and --patchset.') |
| 2000 | |
| 2001 | options.author = gerrit_obj.GetChangeOwner(options.issue) |
| 2002 | options.description = gerrit_obj.GetChangeDescription( |
| 2003 | options.issue, options.patchset) |
| 2004 | |
| 2005 | logging.info('Got author: "%s"', options.author) |
| 2006 | logging.info('Got description: """\n%s\n"""', options.description) |
| 2007 | |
| 2008 | return gerrit_obj |
maruel@chromium.org | 5c8c6de | 2011-03-18 16:20:18 +0000 | [diff] [blame] | 2009 | |
| 2010 | |
iannucci@chromium.org | 8a4a2bc | 2013-03-08 08:13:20 +0000 | [diff] [blame] | 2011 | @contextlib.contextmanager |
| 2012 | def canned_check_filter(method_names): |
| 2013 | filtered = {} |
| 2014 | try: |
| 2015 | for method_name in method_names: |
| 2016 | if not hasattr(presubmit_canned_checks, method_name): |
Gavin Mak | e6a6233 | 2020-12-04 21:57:10 +0000 | [diff] [blame] | 2017 | logging.warning('Skipping unknown "canned" check %s' % method_name) |
Aaron Gable | ecee74c | 2018-04-02 15:13:08 -0700 | [diff] [blame] | 2018 | continue |
iannucci@chromium.org | 8a4a2bc | 2013-03-08 08:13:20 +0000 | [diff] [blame] | 2019 | filtered[method_name] = getattr(presubmit_canned_checks, method_name) |
| 2020 | setattr(presubmit_canned_checks, method_name, lambda *_a, **_kw: []) |
| 2021 | yield |
| 2022 | finally: |
Marc-Antoine Ruel | 8e57b4b | 2019-10-11 01:01:36 +0000 | [diff] [blame] | 2023 | for name, method in filtered.items(): |
iannucci@chromium.org | 8a4a2bc | 2013-03-08 08:13:20 +0000 | [diff] [blame] | 2024 | setattr(presubmit_canned_checks, name, method) |
| 2025 | |
maruel@chromium.org | ffeb2f3 | 2013-12-03 13:55:22 +0000 | [diff] [blame] | 2026 | |
sbc@chromium.org | 013731e | 2015-02-26 18:28:43 +0000 | [diff] [blame] | 2027 | def main(argv=None): |
Edward Lemur | a5799e3 | 2020-01-17 19:26:51 +0000 | [diff] [blame] | 2028 | parser = argparse.ArgumentParser(usage='%(prog)s [options] <files...>') |
| 2029 | hooks = parser.add_mutually_exclusive_group() |
| 2030 | hooks.add_argument('-c', '--commit', action='store_true', |
| 2031 | help='Use commit instead of upload checks.') |
| 2032 | hooks.add_argument('-u', '--upload', action='store_false', dest='commit', |
| 2033 | help='Use upload instead of commit checks.') |
Edward Lemur | 7552630 | 2020-02-27 22:31:05 +0000 | [diff] [blame] | 2034 | hooks.add_argument('--post_upload', action='store_true', |
| 2035 | help='Run post-upload commit hooks.') |
Edward Lemur | a5799e3 | 2020-01-17 19:26:51 +0000 | [diff] [blame] | 2036 | parser.add_argument('-r', '--recursive', action='store_true', |
| 2037 | help='Act recursively.') |
| 2038 | parser.add_argument('-v', '--verbose', action='count', default=0, |
| 2039 | help='Use 2 times for more debug info.') |
| 2040 | parser.add_argument('--name', default='no name') |
| 2041 | parser.add_argument('--author') |
Edward Lemur | 227d510 | 2020-02-25 23:45:35 +0000 | [diff] [blame] | 2042 | desc = parser.add_mutually_exclusive_group() |
| 2043 | desc.add_argument('--description', default='', help='The change description.') |
| 2044 | desc.add_argument('--description_file', |
| 2045 | help='File to read change description from.') |
Edward Lemur | a5799e3 | 2020-01-17 19:26:51 +0000 | [diff] [blame] | 2046 | parser.add_argument('--issue', type=int, default=0) |
| 2047 | parser.add_argument('--patchset', type=int, default=0) |
| 2048 | parser.add_argument('--root', default=os.getcwd(), |
| 2049 | help='Search for PRESUBMIT.py up to this directory. ' |
| 2050 | 'If inherit-review-settings-ok is present in this ' |
| 2051 | 'directory, parent directories up to the root file ' |
| 2052 | 'system directories will also be searched.') |
| 2053 | parser.add_argument('--upstream', |
| 2054 | help='Git only: the base ref or upstream branch against ' |
| 2055 | 'which the diff should be computed.') |
| 2056 | parser.add_argument('--default_presubmit') |
| 2057 | parser.add_argument('--may_prompt', action='store_true', default=False) |
| 2058 | parser.add_argument('--skip_canned', action='append', default=[], |
| 2059 | help='A list of checks to skip which appear in ' |
| 2060 | 'presubmit_canned_checks. Can be provided multiple times ' |
| 2061 | 'to skip multiple canned checks.') |
| 2062 | parser.add_argument('--dry_run', action='store_true', help=argparse.SUPPRESS) |
| 2063 | parser.add_argument('--gerrit_url', help=argparse.SUPPRESS) |
Edward Lesmes | eb1bd62 | 2021-03-01 19:54:07 +0000 | [diff] [blame] | 2064 | parser.add_argument('--gerrit_project', help=argparse.SUPPRESS) |
| 2065 | parser.add_argument('--gerrit_branch', help=argparse.SUPPRESS) |
Edward Lemur | a5799e3 | 2020-01-17 19:26:51 +0000 | [diff] [blame] | 2066 | parser.add_argument('--gerrit_fetch', action='store_true', |
| 2067 | help=argparse.SUPPRESS) |
| 2068 | parser.add_argument('--parallel', action='store_true', |
| 2069 | help='Run all tests specified by input_api.RunTests in ' |
| 2070 | 'all PRESUBMIT files in parallel.') |
| 2071 | parser.add_argument('--json_output', |
| 2072 | help='Write presubmit errors to json output.') |
Edward Lemur | 1dc66e1 | 2020-02-21 21:36:34 +0000 | [diff] [blame] | 2073 | parser.add_argument('--all_files', action='store_true', |
Edward Lemur | 50984a6 | 2020-02-06 18:10:18 +0000 | [diff] [blame] | 2074 | help='Mark all files under source control as modified.') |
Bruce Dawson | 09c0c07 | 2022-05-26 20:28:58 +0000 | [diff] [blame] | 2075 | |
Edward Lemur | a5799e3 | 2020-01-17 19:26:51 +0000 | [diff] [blame] | 2076 | parser.add_argument('files', nargs='*', |
| 2077 | help='List of files to be marked as modified when ' |
| 2078 | 'executing presubmit or post-upload hooks. fnmatch ' |
| 2079 | 'wildcards can also be used.') |
Josip Sokcevic | 017544d | 2022-03-31 23:47:53 +0000 | [diff] [blame] | 2080 | parser.add_argument('--source_controlled_only', action='store_true', |
| 2081 | help='Constrain \'files\' to those in source control.') |
Dirk Pranke | 6f0df68 | 2021-06-25 00:42:33 +0000 | [diff] [blame] | 2082 | parser.add_argument('--use-python3', action='store_true', |
| 2083 | help='Use python3 for presubmit checks by default') |
Bruce Dawson | 09c0c07 | 2022-05-26 20:28:58 +0000 | [diff] [blame] | 2084 | parser.add_argument('--no_diffs', action='store_true', |
| 2085 | help='Assume that all "modified" files have no diffs.') |
Edward Lemur | a5799e3 | 2020-01-17 19:26:51 +0000 | [diff] [blame] | 2086 | options = parser.parse_args(argv) |
pgervais@chromium.org | 92c3009 | 2014-04-15 00:30:37 +0000 | [diff] [blame] | 2087 | |
Erik Staab | cca5c49 | 2020-04-16 17:40:07 +0000 | [diff] [blame] | 2088 | log_level = logging.ERROR |
maruel@chromium.org | 899e1c1 | 2011-04-07 17:03:18 +0000 | [diff] [blame] | 2089 | if options.verbose >= 2: |
Erik Staab | cca5c49 | 2020-04-16 17:40:07 +0000 | [diff] [blame] | 2090 | log_level = logging.DEBUG |
maruel@chromium.org | 899e1c1 | 2011-04-07 17:03:18 +0000 | [diff] [blame] | 2091 | elif options.verbose: |
Erik Staab | cca5c49 | 2020-04-16 17:40:07 +0000 | [diff] [blame] | 2092 | log_level = logging.INFO |
| 2093 | log_format = ('[%(levelname).1s%(asctime)s %(process)d %(thread)d ' |
| 2094 | '%(filename)s] %(message)s') |
| 2095 | logging.basicConfig(format=log_format, level=log_level) |
pgervais@chromium.org | 92c3009 | 2014-04-15 00:30:37 +0000 | [diff] [blame] | 2096 | |
Bruce Dawson | dca14bc | 2022-09-15 20:59:38 +0000 | [diff] [blame] | 2097 | # Print call stacks when _PresubmitResult objects are created with -v -v is |
| 2098 | # specified. This helps track down where presubmit messages are coming from. |
| 2099 | if options.verbose >= 2: |
| 2100 | global _SHOW_CALLSTACKS |
| 2101 | _SHOW_CALLSTACKS = True |
| 2102 | |
Edward Lemur | 227d510 | 2020-02-25 23:45:35 +0000 | [diff] [blame] | 2103 | if options.description_file: |
| 2104 | options.description = gclient_utils.FileRead(options.description_file) |
Edward Lemur | 50984a6 | 2020-02-06 18:10:18 +0000 | [diff] [blame] | 2105 | gerrit_obj = _parse_gerrit_options(parser, options) |
| 2106 | change = _parse_change(parser, options) |
pgervais@chromium.org | 92c3009 | 2014-04-15 00:30:37 +0000 | [diff] [blame] | 2107 | |
maruel@chromium.org | 899e1c1 | 2011-04-07 17:03:18 +0000 | [diff] [blame] | 2108 | try: |
Edward Lemur | 7552630 | 2020-02-27 22:31:05 +0000 | [diff] [blame] | 2109 | if options.post_upload: |
Josip Sokcevic | e293d3d | 2022-02-16 22:52:15 +0000 | [diff] [blame] | 2110 | return DoPostUploadExecuter(change, gerrit_obj, options.verbose, |
| 2111 | options.use_python3) |
iannucci@chromium.org | 8a4a2bc | 2013-03-08 08:13:20 +0000 | [diff] [blame] | 2112 | with canned_check_filter(options.skip_canned): |
Edward Lemur | 6eb1d32 | 2020-02-27 22:20:15 +0000 | [diff] [blame] | 2113 | return DoPresubmitChecks( |
Edward Lemur | 50984a6 | 2020-02-06 18:10:18 +0000 | [diff] [blame] | 2114 | change, |
iannucci@chromium.org | 8a4a2bc | 2013-03-08 08:13:20 +0000 | [diff] [blame] | 2115 | options.commit, |
| 2116 | options.verbose, |
iannucci@chromium.org | 8a4a2bc | 2013-03-08 08:13:20 +0000 | [diff] [blame] | 2117 | options.default_presubmit, |
| 2118 | options.may_prompt, |
tandrii@chromium.org | 37b07a7 | 2016-04-29 16:42:28 +0000 | [diff] [blame] | 2119 | gerrit_obj, |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 2120 | options.dry_run, |
Debrian Figueroa | dd2737e | 2019-06-21 23:50:13 +0000 | [diff] [blame] | 2121 | options.parallel, |
Dirk Pranke | 6f0df68 | 2021-06-25 00:42:33 +0000 | [diff] [blame] | 2122 | options.json_output, |
Bruce Dawson | 09c0c07 | 2022-05-26 20:28:58 +0000 | [diff] [blame] | 2123 | options.use_python3, |
| 2124 | options.no_diffs) |
Raul Tambre | 7c93846 | 2019-05-24 16:35:35 +0000 | [diff] [blame] | 2125 | except PresubmitFailure as e: |
Josip Sokcevic | 0399e17 | 2022-03-21 23:11:51 +0000 | [diff] [blame] | 2126 | import utils |
Raul Tambre | 80ee78e | 2019-05-06 22:41:05 +0000 | [diff] [blame] | 2127 | print(e, file=sys.stderr) |
| 2128 | print('Maybe your depot_tools is out of date?', file=sys.stderr) |
Josip Sokcevic | 0399e17 | 2022-03-21 23:11:51 +0000 | [diff] [blame] | 2129 | print('depot_tools version: %s' % utils.depot_tools_version(), |
| 2130 | file=sys.stderr) |
maruel@chromium.org | 899e1c1 | 2011-04-07 17:03:18 +0000 | [diff] [blame] | 2131 | return 2 |
maruel@google.com | fb2b8eb | 2009-04-23 21:03:42 +0000 | [diff] [blame] | 2132 | |
| 2133 | |
| 2134 | if __name__ == '__main__': |
maruel@chromium.org | 35625c7 | 2011-03-23 17:34:02 +0000 | [diff] [blame] | 2135 | fix_encoding.fix_encoding() |
sbc@chromium.org | 013731e | 2015-02-26 18:28:43 +0000 | [diff] [blame] | 2136 | try: |
| 2137 | sys.exit(main()) |
| 2138 | except KeyboardInterrupt: |
| 2139 | sys.stderr.write('interrupted\n') |
sergiyb | f8a3b38 | 2016-07-05 11:21:30 -0700 | [diff] [blame] | 2140 | sys.exit(2) |