blob: cf15c9de4046151dee6dee3240846287fae0acaf [file] [log] [blame]
Josip Sokcevic4de5dea2022-03-23 21:15:14 +00001#!/usr/bin/env python3
maruel@chromium.org3bbf2942012-01-10 16:52:06 +00002# Copyright (c) 2012 The Chromium Authors. All rights reserved.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00003# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5
6"""Enables directory-specific presubmit checks to run at upload and/or commit.
7"""
8
Raul Tambre80ee78e2019-05-06 22:41:05 +00009from __future__ import print_function
10
Saagar Sanghavi99816902020-08-11 22:41:25 +000011__version__ = '2.0.0'
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000012
13# TODO(joi) Add caching where appropriate/needed. The API is designed to allow
14# caching (between all different invocations of presubmit scripts for a given
15# change). We should add it as our presubmit scripts start feeling slow.
16
Edward Lemura5799e32020-01-17 19:26:51 +000017import argparse
Takeshi Yoshino07a6bea2017-08-02 02:44:06 +090018import ast # Exposed through the API.
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +000019import contextlib
Yoshisato Yanagisawa406de132018-06-29 05:43:25 +000020import cpplint
dcheng091b7db2016-06-16 01:27:51 -070021import fnmatch # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000022import glob
asvitkine@chromium.org15169952011-09-27 14:30:53 +000023import inspect
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +000024import itertools
maruel@chromium.org4f6852c2012-04-20 20:39:20 +000025import json # Exposed through the API.
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +000026import logging
ilevy@chromium.orgbc117312013-04-20 03:57:56 +000027import multiprocessing
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000028import os # Somewhat exposed through the API.
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +000029import random
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000030import re # Exposed through the API.
Edward Lesmes8e282792018-04-03 18:50:29 -040031import signal
Allen Webbfe7d7092021-05-18 02:05:49 +000032import six
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000033import sys # Parts exposed through API.
34import tempfile # Exposed through the API.
Edward Lesmes8e282792018-04-03 18:50:29 -040035import threading
jam@chromium.org2a891dc2009-08-20 20:33:37 +000036import time
Edward Lemurde9e3ca2019-10-24 21:13:31 +000037import traceback
maruel@chromium.org1487d532009-06-06 00:22:57 +000038import unittest # Exposed through the API.
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +000039from warnings import warn
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000040
41# Local imports.
maruel@chromium.org35625c72011-03-23 17:34:02 +000042import fix_encoding
Yoshisato Yanagisawa04600b42019-03-15 03:03:41 +000043import gclient_paths # Exposed through the API
44import gclient_utils
Aaron Gableb584c4f2017-04-26 16:28:08 -070045import git_footers
tandrii@chromium.org015ebae2016-04-25 19:37:22 +000046import gerrit_util
Edward Lesmes9ce03f82021-01-12 20:13:31 +000047import owners_client
Jochen Eisinger76f5fc62017-04-07 16:27:46 +020048import owners_finder
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000049import presubmit_canned_checks
Saagar Sanghavi9949ab72020-07-20 20:56:40 +000050import rdb_wrapper
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +000051import scm
maruel@chromium.org84f4fe32011-04-06 13:26:45 +000052import subprocess2 as subprocess # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000053
Edward Lemur16af3562019-10-17 22:11:33 +000054if sys.version_info.major == 2:
55 # TODO(1009814): Expose urllib2 only through urllib_request and urllib_error
56 import urllib2 # Exposed through the API.
57 import urlparse
58 import urllib2 as urllib_request
59 import urllib2 as urllib_error
60else:
61 import urllib.parse as urlparse
62 import urllib.request as urllib_request
63 import urllib.error as urllib_error
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000064
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +000065# Ask for feedback only once in program lifetime.
66_ASKED_FOR_FEEDBACK = False
67
Edward Lemurecc27072020-01-06 16:42:34 +000068def time_time():
69 # Use this so that it can be mocked in tests without interfering with python
70 # system machinery.
71 return time.time()
72
73
maruel@chromium.org899e1c12011-04-07 17:03:18 +000074class PresubmitFailure(Exception):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000075 pass
76
77
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000078class CommandData(object):
Edward Lemur940c2822019-08-23 00:34:25 +000079 def __init__(self, name, cmd, kwargs, message, python3=False):
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000080 self.name = name
81 self.cmd = cmd
Edward Lesmes8e282792018-04-03 18:50:29 -040082 self.stdin = kwargs.get('stdin', None)
Edward Lemur2d6b67c2019-08-23 22:25:41 +000083 self.kwargs = kwargs.copy()
Edward Lesmes8e282792018-04-03 18:50:29 -040084 self.kwargs['stdout'] = subprocess.PIPE
85 self.kwargs['stderr'] = subprocess.STDOUT
86 self.kwargs['stdin'] = subprocess.PIPE
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000087 self.message = message
88 self.info = None
Edward Lemur940c2822019-08-23 00:34:25 +000089 self.python3 = python3
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000090
ilevy@chromium.orgbc117312013-04-20 03:57:56 +000091
Edward Lesmes8e282792018-04-03 18:50:29 -040092# Adapted from
93# https://github.com/google/gtest-parallel/blob/master/gtest_parallel.py#L37
94#
95# An object that catches SIGINT sent to the Python process and notices
96# if processes passed to wait() die by SIGINT (we need to look for
97# both of those cases, because pressing Ctrl+C can result in either
98# the main process or one of the subprocesses getting the signal).
99#
100# Before a SIGINT is seen, wait(p) will simply call p.wait() and
101# return the result. Once a SIGINT has been seen (in the main process
102# or a subprocess, including the one the current call is waiting for),
Edward Lemur9a5bb612019-09-26 02:01:52 +0000103# wait(p) will call p.terminate().
Edward Lesmes8e282792018-04-03 18:50:29 -0400104class SigintHandler(object):
Edward Lesmes8e282792018-04-03 18:50:29 -0400105 sigint_returncodes = {-signal.SIGINT, # Unix
106 -1073741510, # Windows
107 }
108 def __init__(self):
109 self.__lock = threading.Lock()
110 self.__processes = set()
111 self.__got_sigint = False
Edward Lemur9a5bb612019-09-26 02:01:52 +0000112 self.__previous_signal = signal.signal(signal.SIGINT, self.interrupt)
Edward Lesmes8e282792018-04-03 18:50:29 -0400113
114 def __on_sigint(self):
115 self.__got_sigint = True
116 while self.__processes:
117 try:
118 self.__processes.pop().terminate()
119 except OSError:
120 pass
121
Edward Lemur9a5bb612019-09-26 02:01:52 +0000122 def interrupt(self, signal_num, frame):
Edward Lesmes8e282792018-04-03 18:50:29 -0400123 with self.__lock:
124 self.__on_sigint()
Edward Lemur9a5bb612019-09-26 02:01:52 +0000125 self.__previous_signal(signal_num, frame)
Edward Lesmes8e282792018-04-03 18:50:29 -0400126
127 def got_sigint(self):
128 with self.__lock:
129 return self.__got_sigint
130
131 def wait(self, p, stdin):
132 with self.__lock:
133 if self.__got_sigint:
134 p.terminate()
135 self.__processes.add(p)
136 stdout, stderr = p.communicate(stdin)
137 code = p.returncode
138 with self.__lock:
139 self.__processes.discard(p)
140 if code in self.sigint_returncodes:
141 self.__on_sigint()
Edward Lesmes8e282792018-04-03 18:50:29 -0400142 return stdout, stderr
143
144sigint_handler = SigintHandler()
145
146
Edward Lemurecc27072020-01-06 16:42:34 +0000147class Timer(object):
148 def __init__(self, timeout, fn):
149 self.completed = False
150 self._fn = fn
151 self._timer = threading.Timer(timeout, self._onTimer) if timeout else None
152
153 def __enter__(self):
154 if self._timer:
155 self._timer.start()
156 return self
157
158 def __exit__(self, _type, _value, _traceback):
159 if self._timer:
160 self._timer.cancel()
161
162 def _onTimer(self):
163 self._fn()
164 self.completed = True
165
166
Edward Lesmes8e282792018-04-03 18:50:29 -0400167class ThreadPool(object):
Edward Lemurecc27072020-01-06 16:42:34 +0000168 def __init__(self, pool_size=None, timeout=None):
169 self.timeout = timeout
Edward Lesmes8e282792018-04-03 18:50:29 -0400170 self._pool_size = pool_size or multiprocessing.cpu_count()
Bruce Dawson8254f062022-06-17 17:33:08 +0000171 if sys.platform == 'win32':
172 # TODO(crbug.com/1190269) - we can't use more than 56 child processes on
173 # Windows or Python3 may hang.
174 self._pool_size = min(self._pool_size, 56)
Edward Lesmes8e282792018-04-03 18:50:29 -0400175 self._messages = []
176 self._messages_lock = threading.Lock()
177 self._tests = []
178 self._tests_lock = threading.Lock()
179 self._nonparallel_tests = []
180
Edward Lemurecc27072020-01-06 16:42:34 +0000181 def _GetCommand(self, test):
Edward Lemur940c2822019-08-23 00:34:25 +0000182 vpython = 'vpython'
183 if test.python3:
184 vpython += '3'
185 if sys.platform == 'win32':
186 vpython += '.bat'
Edward Lesmes8e282792018-04-03 18:50:29 -0400187
188 cmd = test.cmd
189 if cmd[0] == 'python':
190 cmd = list(cmd)
191 cmd[0] = vpython
192 elif cmd[0].endswith('.py'):
193 cmd = [vpython] + cmd
194
Edward Lemur336e51f2019-11-14 21:42:04 +0000195 # On Windows, scripts on the current directory take precedence over PATH, so
196 # that when testing depot_tools on Windows, calling `vpython.bat` will
197 # execute the copy of vpython of the depot_tools under test instead of the
198 # one in the bot.
199 # As a workaround, we run the tests from the parent directory instead.
200 if (cmd[0] == vpython and
201 'cwd' in test.kwargs and
202 os.path.basename(test.kwargs['cwd']) == 'depot_tools'):
203 test.kwargs['cwd'] = os.path.dirname(test.kwargs['cwd'])
204 cmd[1] = os.path.join('depot_tools', cmd[1])
205
Edward Lemurecc27072020-01-06 16:42:34 +0000206 return cmd
207
208 def _RunWithTimeout(self, cmd, stdin, kwargs):
209 p = subprocess.Popen(cmd, **kwargs)
210 with Timer(self.timeout, p.terminate) as timer:
211 stdout, _ = sigint_handler.wait(p, stdin)
Josip Sokcevic6635baf2021-11-19 02:04:39 +0000212 stdout = stdout.decode('utf-8', 'ignore')
Edward Lemurecc27072020-01-06 16:42:34 +0000213 if timer.completed:
214 stdout = 'Process timed out after %ss\n%s' % (self.timeout, stdout)
Josip Sokcevic6635baf2021-11-19 02:04:39 +0000215 return p.returncode, stdout
Edward Lemurecc27072020-01-06 16:42:34 +0000216
217 def CallCommand(self, test):
218 """Runs an external program.
219
Edward Lemura5799e32020-01-17 19:26:51 +0000220 This function converts invocation of .py files and invocations of 'python'
Edward Lemurecc27072020-01-06 16:42:34 +0000221 to vpython invocations.
222 """
223 cmd = self._GetCommand(test)
Edward Lesmes8e282792018-04-03 18:50:29 -0400224 try:
Edward Lemurecc27072020-01-06 16:42:34 +0000225 start = time_time()
226 returncode, stdout = self._RunWithTimeout(cmd, test.stdin, test.kwargs)
227 duration = time_time() - start
Edward Lemur7cf94382019-11-15 22:36:41 +0000228 except Exception:
Edward Lemurecc27072020-01-06 16:42:34 +0000229 duration = time_time() - start
Edward Lesmes8e282792018-04-03 18:50:29 -0400230 return test.message(
Edward Lemur7cf94382019-11-15 22:36:41 +0000231 '%s\n%s exec failure (%4.2fs)\n%s' % (
232 test.name, ' '.join(cmd), duration, traceback.format_exc()))
Edward Lemurde9e3ca2019-10-24 21:13:31 +0000233
Edward Lemurecc27072020-01-06 16:42:34 +0000234 if returncode != 0:
Edward Lesmes8e282792018-04-03 18:50:29 -0400235 return test.message(
Edward Lemur7cf94382019-11-15 22:36:41 +0000236 '%s\n%s (%4.2fs) failed\n%s' % (
237 test.name, ' '.join(cmd), duration, stdout))
Edward Lemurecc27072020-01-06 16:42:34 +0000238
Edward Lesmes8e282792018-04-03 18:50:29 -0400239 if test.info:
Edward Lemur7cf94382019-11-15 22:36:41 +0000240 return test.info('%s\n%s (%4.2fs)' % (test.name, ' '.join(cmd), duration))
Edward Lesmes8e282792018-04-03 18:50:29 -0400241
242 def AddTests(self, tests, parallel=True):
243 if parallel:
244 self._tests.extend(tests)
245 else:
246 self._nonparallel_tests.extend(tests)
247
248 def RunAsync(self):
249 self._messages = []
250
251 def _WorkerFn():
252 while True:
253 test = None
254 with self._tests_lock:
255 if not self._tests:
256 break
257 test = self._tests.pop()
258 result = self.CallCommand(test)
259 if result:
260 with self._messages_lock:
261 self._messages.append(result)
262
263 def _StartDaemon():
264 t = threading.Thread(target=_WorkerFn)
265 t.daemon = True
266 t.start()
267 return t
268
269 while self._nonparallel_tests:
270 test = self._nonparallel_tests.pop()
271 result = self.CallCommand(test)
272 if result:
273 self._messages.append(result)
274
275 if self._tests:
276 threads = [_StartDaemon() for _ in range(self._pool_size)]
277 for worker in threads:
278 worker.join()
279
280 return self._messages
281
282
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000283def normpath(path):
284 '''Version of os.path.normpath that also changes backward slashes to
285 forward slashes when not running on Windows.
286 '''
287 # This is safe to always do because the Windows version of os.path.normpath
288 # will replace forward slashes with backward slashes.
289 path = path.replace(os.sep, '/')
290 return os.path.normpath(path)
291
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000292
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000293def _RightHandSideLinesImpl(affected_files):
294 """Implements RightHandSideLines for InputApi and GclChange."""
295 for af in affected_files:
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000296 lines = af.ChangedContents()
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000297 for line in lines:
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000298 yield (af, line[0], line[1])
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000299
300
Edward Lemur6eb1d322020-02-27 22:20:15 +0000301def prompt_should_continue(prompt_string):
302 sys.stdout.write(prompt_string)
Dirk Pranke7288f882021-06-03 18:01:30 +0000303 sys.stdout.flush()
Edward Lemur6eb1d322020-02-27 22:20:15 +0000304 response = sys.stdin.readline().strip().lower()
305 return response in ('y', 'yes')
dpranke@chromium.org5ac21012011-03-16 02:58:25 +0000306
307
Josip Sokcevice293d3d2022-02-16 22:52:15 +0000308def _ShouldRunPresubmit(script_text, use_python3):
309 """Try to figure out whether these presubmit checks should be run under
310 python2 or python3. We need to do this without actually trying to
311 compile the text, since the text might compile in one but not the
312 other.
313
314 Args:
315 script_text: The text of the presubmit script.
316 use_python3: if true, will use python3 instead of python2 by default
317 if USE_PYTHON3 is not specified.
318
319 Return:
320 A boolean if presubmit should be executed
321 """
322 m = re.search('^USE_PYTHON3 = (True|False)$', script_text, flags=re.MULTILINE)
323 if m:
324 use_python3 = m.group(1) == 'True'
325
326 return ((sys.version_info.major == 2) and not use_python3) or \
327 ((sys.version_info.major == 3) and use_python3)
328
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000329# Top level object so multiprocessing can pickle
330# Public access through OutputApi object.
331class _PresubmitResult(object):
332 """Base class for result objects."""
333 fatal = False
334 should_prompt = False
335
336 def __init__(self, message, items=None, long_text=''):
337 """
338 message: A short one-line message to indicate errors.
339 items: A list of short strings to indicate where errors occurred.
340 long_text: multi-line text output, e.g. from another tool
341 """
Bruce Dawsondb8622b2022-04-03 15:38:12 +0000342 self._message = _PresubmitResult._ensure_str(message)
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000343 self._items = items or []
Tom McKee61c72652021-07-20 11:56:32 +0000344 self._long_text = _PresubmitResult._ensure_str(long_text.rstrip())
345
346 @staticmethod
347 def _ensure_str(val):
348 """
349 val: A "stringish" value. Can be any of str, unicode or bytes.
350 returns: A str after applying encoding/decoding as needed.
351 Assumes/uses UTF-8 for relevant inputs/outputs.
352
353 We'd prefer to use six.ensure_str but our copy of six is old :(
354 """
355 if isinstance(val, str):
356 return val
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +0000357
Tom McKee61c72652021-07-20 11:56:32 +0000358 if six.PY2 and isinstance(val, unicode):
359 return val.encode()
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +0000360
361 if six.PY3 and isinstance(val, bytes):
Tom McKee61c72652021-07-20 11:56:32 +0000362 return val.decode()
363 raise ValueError("Unknown string type %s" % type(val))
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000364
Edward Lemur6eb1d322020-02-27 22:20:15 +0000365 def handle(self):
366 sys.stdout.write(self._message)
367 sys.stdout.write('\n')
Takuto Ikutabaa7be02022-08-23 00:19:34 +0000368 for item in self._items:
Edward Lemur6eb1d322020-02-27 22:20:15 +0000369 sys.stdout.write(' ')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000370 # Write separately in case it's unicode.
Edward Lemur6eb1d322020-02-27 22:20:15 +0000371 sys.stdout.write(str(item))
Edward Lemur6eb1d322020-02-27 22:20:15 +0000372 sys.stdout.write('\n')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000373 if self._long_text:
Edward Lemur6eb1d322020-02-27 22:20:15 +0000374 sys.stdout.write('\n***************\n')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000375 # Write separately in case it's unicode.
Tom McKee61c72652021-07-20 11:56:32 +0000376 sys.stdout.write(self._long_text)
Edward Lemur6eb1d322020-02-27 22:20:15 +0000377 sys.stdout.write('\n***************\n')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000378
Debrian Figueroadd2737e2019-06-21 23:50:13 +0000379 def json_format(self):
380 return {
381 'message': self._message,
Debrian Figueroa6095d402019-06-28 18:47:18 +0000382 'items': [str(item) for item in self._items],
Debrian Figueroadd2737e2019-06-21 23:50:13 +0000383 'long_text': self._long_text,
384 'fatal': self.fatal
385 }
386
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000387
388# Top level object so multiprocessing can pickle
389# Public access through OutputApi object.
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000390class _PresubmitError(_PresubmitResult):
391 """A hard presubmit error."""
392 fatal = True
393
394
395# Top level object so multiprocessing can pickle
396# Public access through OutputApi object.
397class _PresubmitPromptWarning(_PresubmitResult):
398 """An warning that prompts the user if they want to continue."""
399 should_prompt = True
400
401
402# Top level object so multiprocessing can pickle
403# Public access through OutputApi object.
404class _PresubmitNotifyResult(_PresubmitResult):
405 """Just print something to the screen -- but it's not even a warning."""
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000406
407
408# Top level object so multiprocessing can pickle
409# Public access through OutputApi object.
410class _MailTextResult(_PresubmitResult):
411 """A warning that should be included in the review request email."""
412 def __init__(self, *args, **kwargs):
413 super(_MailTextResult, self).__init__()
414 raise NotImplementedError()
415
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000416class GerritAccessor(object):
417 """Limited Gerrit functionality for canned presubmit checks to work.
418
419 To avoid excessive Gerrit calls, caches the results.
420 """
421
Edward Lesmeseb1bd622021-03-01 19:54:07 +0000422 def __init__(self, url=None, project=None, branch=None):
423 self.host = urlparse.urlparse(url).netloc if url else None
424 self.project = project
425 self.branch = branch
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000426 self.cache = {}
Edward Lesmes8170c292021-03-19 20:04:43 +0000427 self.code_owners_enabled = None
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000428
429 def _FetchChangeDetail(self, issue):
430 # Separate function to be easily mocked in tests.
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +0100431 try:
432 return gerrit_util.GetChangeDetail(
433 self.host, str(issue),
Aaron Gable6f5a8d92017-04-18 14:49:05 -0700434 ['ALL_REVISIONS', 'DETAILED_LABELS', 'ALL_COMMITS'])
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +0100435 except gerrit_util.GerritError as e:
436 if e.http_status == 404:
437 raise Exception('Either Gerrit issue %s doesn\'t exist, or '
438 'no credentials to fetch issue details' % issue)
439 raise
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000440
441 def GetChangeInfo(self, issue):
442 """Returns labels and all revisions (patchsets) for this issue.
443
444 The result is a dictionary according to Gerrit REST Api.
445 https://gerrit-review.googlesource.com/Documentation/rest-api.html
446
447 However, API isn't very clear what's inside, so see tests for example.
448 """
449 assert issue
450 cache_key = int(issue)
451 if cache_key not in self.cache:
452 self.cache[cache_key] = self._FetchChangeDetail(issue)
453 return self.cache[cache_key]
454
455 def GetChangeDescription(self, issue, patchset=None):
456 """If patchset is none, fetches current patchset."""
457 info = self.GetChangeInfo(issue)
458 # info is a reference to cache. We'll modify it here adding description to
459 # it to the right patchset, if it is not yet there.
460
461 # Find revision info for the patchset we want.
462 if patchset is not None:
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +0000463 for rev, rev_info in info['revisions'].items():
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000464 if str(rev_info['_number']) == str(patchset):
465 break
466 else:
467 raise Exception('patchset %s doesn\'t exist in issue %s' % (
468 patchset, issue))
469 else:
470 rev = info['current_revision']
471 rev_info = info['revisions'][rev]
472
Andrii Shyshkalov9c3a4642017-01-24 17:41:22 +0100473 return rev_info['commit']['message']
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000474
Mun Yong Jang603d01e2017-12-19 16:38:30 -0800475 def GetDestRef(self, issue):
476 ref = self.GetChangeInfo(issue)['branch']
477 if not ref.startswith('refs/'):
478 # NOTE: it is possible to create 'refs/x' branch,
479 # aka 'refs/heads/refs/x'. However, this is ill-advised.
480 ref = 'refs/heads/%s' % ref
481 return ref
482
Edward Lesmes02d4b822020-11-11 00:37:35 +0000483 def _GetApproversForLabel(self, issue, label):
484 change_info = self.GetChangeInfo(issue)
485 label_info = change_info.get('labels', {}).get(label, {})
486 values = label_info.get('values', {}).keys()
487 if not values:
488 return []
489 max_value = max(int(v) for v in values)
490 return [v for v in label_info.get('all', [])
491 if v.get('value', 0) == max_value]
492
Edward Lesmesc4566172021-03-19 16:55:13 +0000493 def IsBotCommitApproved(self, issue):
494 return bool(self._GetApproversForLabel(issue, 'Bot-Commit'))
495
Edward Lesmescf49cb82020-11-11 01:08:36 +0000496 def IsOwnersOverrideApproved(self, issue):
497 return bool(self._GetApproversForLabel(issue, 'Owners-Override'))
498
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000499 def GetChangeOwner(self, issue):
500 return self.GetChangeInfo(issue)['owner']['email']
501
502 def GetChangeReviewers(self, issue, approving_only=True):
Aaron Gable8b478f02017-07-31 15:33:19 -0700503 changeinfo = self.GetChangeInfo(issue)
504 if approving_only:
Edward Lesmes02d4b822020-11-11 00:37:35 +0000505 reviewers = self._GetApproversForLabel(issue, 'Code-Review')
Aaron Gable8b478f02017-07-31 15:33:19 -0700506 else:
507 reviewers = changeinfo.get('reviewers', {}).get('REVIEWER', [])
508 return [r.get('email') for r in reviewers]
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000509
Edward Lemure4d329c2020-02-03 20:41:18 +0000510 def UpdateDescription(self, description, issue):
511 gerrit_util.SetCommitMessage(self.host, issue, description, notify='NONE')
512
Edward Lesmes8170c292021-03-19 20:04:43 +0000513 def IsCodeOwnersEnabledOnRepo(self):
514 if self.code_owners_enabled is None:
515 self.code_owners_enabled = gerrit_util.IsCodeOwnersEnabledOnRepo(
Edward Lesmes392c4072021-03-19 21:58:45 +0000516 self.host, self.project)
Edward Lesmes8170c292021-03-19 20:04:43 +0000517 return self.code_owners_enabled
518
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000519
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000520class OutputApi(object):
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000521 """An instance of OutputApi gets passed to presubmit scripts so that they
522 can output various types of results.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000523 """
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000524 PresubmitResult = _PresubmitResult
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000525 PresubmitError = _PresubmitError
526 PresubmitPromptWarning = _PresubmitPromptWarning
527 PresubmitNotifyResult = _PresubmitNotifyResult
528 MailTextResult = _MailTextResult
529
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000530 def __init__(self, is_committing):
531 self.is_committing = is_committing
Daniel Cheng7227d212017-11-17 08:12:37 -0800532 self.more_cc = []
533
534 def AppendCC(self, cc):
535 """Appends a user to cc for this change."""
536 self.more_cc.append(cc)
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000537
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000538 def PresubmitPromptOrNotify(self, *args, **kwargs):
539 """Warn the user when uploading, but only notify if committing."""
540 if self.is_committing:
541 return self.PresubmitNotifyResult(*args, **kwargs)
542 return self.PresubmitPromptWarning(*args, **kwargs)
543
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000544
545class InputApi(object):
546 """An instance of this object is passed to presubmit scripts so they can
547 know stuff about the change they're looking at.
548 """
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000549 # Method could be a function
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800550 # pylint: disable=no-self-use
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000551
maruel@chromium.org3410d912009-06-09 20:56:16 +0000552 # File extensions that are considered source files from a style guide
553 # perspective. Don't modify this list from a presubmit script!
maruel@chromium.orgc33455a2011-06-24 19:14:18 +0000554 #
555 # Files without an extension aren't included in the list. If you want to
local_bot30f774e2020-06-25 18:23:34 +0000556 # filter them as source files, add r'(^|.*?[\\\/])[^.]+$' to the allow list.
local_bot64021412020-07-08 21:05:39 +0000557 # Note that ALL CAPS files are skipped in DEFAULT_FILES_TO_SKIP below.
558 DEFAULT_FILES_TO_CHECK = (
maruel@chromium.org3410d912009-06-09 20:56:16 +0000559 # C++ and friends
Edward Lemura5799e32020-01-17 19:26:51 +0000560 r'.+\.c$', r'.+\.cc$', r'.+\.cpp$', r'.+\.h$', r'.+\.m$', r'.+\.mm$',
561 r'.+\.inl$', r'.+\.asm$', r'.+\.hxx$', r'.+\.hpp$', r'.+\.s$', r'.+\.S$',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000562 # Scripts
dpapad443d9132022-05-05 00:17:30 +0000563 r'.+\.js$', r'.+\.ts$', r'.+\.py$', r'.+\.sh$', r'.+\.rb$', r'.+\.pl$',
564 r'.+\.pm$',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000565 # Other
Edward Lemura5799e32020-01-17 19:26:51 +0000566 r'.+\.java$', r'.+\.mk$', r'.+\.am$', r'.+\.css$', r'.+\.mojom$',
567 r'.+\.fidl$'
maruel@chromium.org3410d912009-06-09 20:56:16 +0000568 )
569
570 # Path regexp that should be excluded from being considered containing source
571 # files. Don't modify this list from a presubmit script!
local_bot64021412020-07-08 21:05:39 +0000572 DEFAULT_FILES_TO_SKIP = (
Edward Lemura5799e32020-01-17 19:26:51 +0000573 r'testing_support[\\\/]google_appengine[\\\/].*',
574 r'.*\bexperimental[\\\/].*',
Kent Tamura179dd1e2018-04-26 15:07:41 +0900575 # Exclude third_party/.* but NOT third_party/{WebKit,blink}
576 # (crbug.com/539768 and crbug.com/836555).
Edward Lemura5799e32020-01-17 19:26:51 +0000577 r'.*\bthird_party[\\\/](?!(WebKit|blink)[\\\/]).*',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000578 # Output directories (just in case)
Edward Lemura5799e32020-01-17 19:26:51 +0000579 r'.*\bDebug[\\\/].*',
580 r'.*\bRelease[\\\/].*',
581 r'.*\bxcodebuild[\\\/].*',
582 r'.*\bout[\\\/].*',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000583 # All caps files like README and LICENCE.
Edward Lemura5799e32020-01-17 19:26:51 +0000584 r'.*\b[A-Z0-9_]{2,}$',
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +0000585 # SCM (can happen in dual SCM configuration). (Slightly over aggressive)
Edward Lemura5799e32020-01-17 19:26:51 +0000586 r'(|.*[\\\/])\.git[\\\/].*',
587 r'(|.*[\\\/])\.svn[\\\/].*',
maruel@chromium.org7ccb4bb2011-11-07 20:26:20 +0000588 # There is no point in processing a patch file.
Edward Lemura5799e32020-01-17 19:26:51 +0000589 r'.+\.diff$',
590 r'.+\.patch$',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000591 )
592
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000593 def __init__(self, change, presubmit_path, is_committing,
Bruce Dawson09c0c072022-05-26 20:28:58 +0000594 verbose, gerrit_obj, dry_run=None, thread_pool=None, parallel=False,
595 no_diffs=False):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000596 """Builds an InputApi object.
597
598 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000599 change: A presubmit.Change object.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000600 presubmit_path: The path to the presubmit script being processed.
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000601 is_committing: True if the change is about to be committed.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000602 gerrit_obj: provides basic Gerrit codereview functionality.
603 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -0400604 parallel: if true, all tests reported via input_api.RunTests for all
605 PRESUBMIT files will be run in parallel.
Bruce Dawson09c0c072022-05-26 20:28:58 +0000606 no_diffs: if true, implies that --files or --all was specified so some
607 checks can be skipped, and some errors will be messages.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000608 """
maruel@chromium.org9711bba2009-05-22 23:51:39 +0000609 # Version number of the presubmit_support script.
610 self.version = [int(x) for x in __version__.split('.')]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000611 self.change = change
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000612 self.is_committing = is_committing
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000613 self.gerrit = gerrit_obj
tandrii@chromium.org57bafac2016-04-28 05:09:03 +0000614 self.dry_run = dry_run
Bruce Dawson09c0c072022-05-26 20:28:58 +0000615 self.no_diffs = no_diffs
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000616
Edward Lesmes8e282792018-04-03 18:50:29 -0400617 self.parallel = parallel
618 self.thread_pool = thread_pool or ThreadPool()
619
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000620 # We expose various modules and functions as attributes of the input_api
621 # so that presubmit scripts don't have to import them.
Takeshi Yoshino07a6bea2017-08-02 02:44:06 +0900622 self.ast = ast
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000623 self.basename = os.path.basename
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000624 self.cpplint = cpplint
dcheng091b7db2016-06-16 01:27:51 -0700625 self.fnmatch = fnmatch
Yoshisato Yanagisawa04600b42019-03-15 03:03:41 +0000626 self.gclient_paths = gclient_paths
Yoshisato Yanagisawa57dd17b2019-03-22 09:10:29 +0000627 # TODO(yyanagisawa): stop exposing this when python3 become default.
628 # Since python3's tempfile has TemporaryDirectory, we do not need this.
629 self.temporary_directory = gclient_utils.temporary_directory
dpranke@chromium.org17cc2442012-10-17 21:12:09 +0000630 self.glob = glob.glob
maruel@chromium.orgfb11c7b2010-03-18 18:22:14 +0000631 self.json = json
maruel@chromium.org6fba34d2011-06-02 13:45:12 +0000632 self.logging = logging.getLogger('PRESUBMIT')
maruel@chromium.org2b5ce562011-03-31 16:15:44 +0000633 self.os_listdir = os.listdir
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000634 self.os_path = os.path
pgervais@chromium.orgbd0cace2014-10-02 23:23:46 +0000635 self.os_stat = os.stat
Yoshisato Yanagisawa406de132018-06-29 05:43:25 +0000636 self.os_walk = os.walk
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000637 self.re = re
638 self.subprocess = subprocess
Edward Lemurb9830242019-10-30 22:19:20 +0000639 self.sys = sys
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000640 self.tempfile = tempfile
dpranke@chromium.org0d1bdea2011-03-24 22:54:38 +0000641 self.time = time
maruel@chromium.org1487d532009-06-06 00:22:57 +0000642 self.unittest = unittest
Edward Lemurb9830242019-10-30 22:19:20 +0000643 if sys.version_info.major == 2:
644 self.urllib2 = urllib2
Edward Lemur16af3562019-10-17 22:11:33 +0000645 self.urllib_request = urllib_request
646 self.urllib_error = urllib_error
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000647
Robert Iannucci50258932018-03-19 10:30:59 -0700648 self.is_windows = sys.platform == 'win32'
649
Edward Lemurb9646622019-10-25 20:57:35 +0000650 # Set python_executable to 'vpython' in order to allow scripts in other
651 # repos (e.g. src.git) to automatically pick up that repo's .vpython file,
652 # instead of inheriting the one in depot_tools.
653 self.python_executable = 'vpython'
Erik Staab69135d12021-05-14 22:31:57 +0000654 # Offer a python 3 executable for use during the migration off of python 2.
655 self.python3_executable = 'vpython3'
maruel@chromium.orgc0b22972009-06-25 16:19:14 +0000656 self.environ = os.environ
657
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000658 # InputApi.platform is the platform you're currently running on.
659 self.platform = sys.platform
660
iannucci@chromium.org0af3bb32015-06-12 20:44:35 +0000661 self.cpu_count = multiprocessing.cpu_count()
Bruce Dawson8254f062022-06-17 17:33:08 +0000662 if self.is_windows:
663 # TODO(crbug.com/1190269) - we can't use more than 56 child processes on
664 # Windows or Python3 may hang.
665 self.cpu_count = min(self.cpu_count, 56)
iannucci@chromium.org0af3bb32015-06-12 20:44:35 +0000666
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000667 # The local path of the currently-being-processed presubmit script.
maruel@chromium.org3d235242009-05-15 12:40:48 +0000668 self._current_presubmit_path = os.path.dirname(presubmit_path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000669
670 # We carry the canned checks so presubmit scripts can easily use them.
671 self.canned_checks = presubmit_canned_checks
672
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +0100673 # Temporary files we must manually remove at the end of a run.
674 self._named_temporary_files = []
Jochen Eisinger72606f82017-04-04 10:44:18 +0200675
Edward Lesmesdc11c6b2021-03-19 19:22:05 +0000676 self.owners_client = None
Bruce Dawsoneb8426e2022-08-05 23:58:15 +0000677 if self.gerrit and not 'PRESUBMIT_SKIP_NETWORK' in self.environ:
Bruce Dawson9b9f4512022-04-27 00:56:52 +0000678 try:
679 self.owners_client = owners_client.GetCodeOwnersClient(
Bruce Dawson9b9f4512022-04-27 00:56:52 +0000680 host=self.gerrit.host,
681 project=self.gerrit.project,
682 branch=self.gerrit.branch)
683 except Exception as e:
684 print('Failed to set owners_client - %s' % str(e))
Jochen Eisinger76f5fc62017-04-07 16:27:46 +0200685 self.owners_finder = owners_finder.OwnersFinder
maruel@chromium.org899e1c12011-04-07 17:03:18 +0000686 self.verbose = verbose
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000687 self.Command = CommandData
dpranke@chromium.org2a009622011-03-01 02:43:31 +0000688
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000689 # Replace <hash_map> and <hash_set> as headers that need to be included
Edward Lemura5799e32020-01-17 19:26:51 +0000690 # with 'base/containers/hash_tables.h' instead.
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000691 # Access to a protected member _XX of a client class
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800692 # pylint: disable=protected-access
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000693 self.cpplint._re_pattern_templates = [
danakj@chromium.org18278522013-06-11 22:42:32 +0000694 (a, b, 'base/containers/hash_tables.h')
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000695 if header in ('<hash_map>', '<hash_set>') else (a, b, header)
696 for (a, b, header) in cpplint._re_pattern_templates
697 ]
698
Edward Lemurecc27072020-01-06 16:42:34 +0000699 def SetTimeout(self, timeout):
700 self.thread_pool.timeout = timeout
701
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000702 def PresubmitLocalPath(self):
703 """Returns the local path of the presubmit script currently being run.
704
705 This is useful if you don't want to hard-code absolute paths in the
706 presubmit script. For example, It can be used to find another file
707 relative to the PRESUBMIT.py script, so the whole tree can be branched and
708 the presubmit script still works, without editing its content.
709 """
maruel@chromium.org3d235242009-05-15 12:40:48 +0000710 return self._current_presubmit_path
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000711
agable0b65e732016-11-22 09:25:46 -0800712 def AffectedFiles(self, include_deletes=True, file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000713 """Same as input_api.change.AffectedFiles() except only lists files
714 (and optionally directories) in the same directory as the current presubmit
Bruce Dawson7a0b07a2020-04-23 17:14:40 +0000715 script, or subdirectories thereof. Note that files are listed using the OS
716 path separator, so backslashes are used as separators on Windows.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000717 """
Bruce Dawson31bfd512022-05-10 23:19:39 +0000718 dir_with_slash = normpath(self.PresubmitLocalPath())
719 # normpath strips trailing path separators, so the trailing separator has to
720 # be added after the normpath call.
721 if len(dir_with_slash) > 0:
722 dir_with_slash += os.path.sep
sail@chromium.org5538e022011-05-12 17:53:16 +0000723
Edward Lemurb9830242019-10-30 22:19:20 +0000724 return list(filter(
maruel@chromium.org4661e0c2009-06-04 00:45:26 +0000725 lambda x: normpath(x.AbsoluteLocalPath()).startswith(dir_with_slash),
Edward Lemurb9830242019-10-30 22:19:20 +0000726 self.change.AffectedFiles(include_deletes, file_filter)))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000727
agable0b65e732016-11-22 09:25:46 -0800728 def LocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000729 """Returns local paths of input_api.AffectedFiles()."""
agable0b65e732016-11-22 09:25:46 -0800730 paths = [af.LocalPath() for af in self.AffectedFiles()]
Edward Lemura5799e32020-01-17 19:26:51 +0000731 logging.debug('LocalPaths: %s', paths)
pgervais@chromium.org2f64f782014-04-25 00:12:33 +0000732 return paths
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000733
agable0b65e732016-11-22 09:25:46 -0800734 def AbsoluteLocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000735 """Returns absolute local paths of input_api.AffectedFiles()."""
agable0b65e732016-11-22 09:25:46 -0800736 return [af.AbsoluteLocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000737
John Budorick16162372018-04-18 10:39:53 -0700738 def AffectedTestableFiles(self, include_deletes=None, **kwargs):
agable0b65e732016-11-22 09:25:46 -0800739 """Same as input_api.change.AffectedTestableFiles() except only lists files
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000740 in the same directory as the current presubmit script, or subdirectories
741 thereof.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000742 """
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000743 if include_deletes is not None:
Edward Lemura5799e32020-01-17 19:26:51 +0000744 warn('AffectedTestableFiles(include_deletes=%s)'
745 ' is deprecated and ignored' % str(include_deletes),
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000746 category=DeprecationWarning,
747 stacklevel=2)
Josip Sokcevic4de5dea2022-03-23 21:15:14 +0000748 # pylint: disable=consider-using-generator
749 return [
750 x for x in self.AffectedFiles(include_deletes=False, **kwargs)
751 if x.IsTestableFile()
752 ]
agable0b65e732016-11-22 09:25:46 -0800753
754 def AffectedTextFiles(self, include_deletes=None):
755 """An alias to AffectedTestableFiles for backwards compatibility."""
756 return self.AffectedTestableFiles(include_deletes=include_deletes)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000757
Josip Sokcevic8c955952021-02-01 21:32:57 +0000758 def FilterSourceFile(self,
759 affected_file,
760 files_to_check=None,
761 files_to_skip=None,
762 allow_list=None,
763 block_list=None):
Edward Lemura5799e32020-01-17 19:26:51 +0000764 """Filters out files that aren't considered 'source file'.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000765
local_bot64021412020-07-08 21:05:39 +0000766 If files_to_check or files_to_skip is None, InputApi.DEFAULT_FILES_TO_CHECK
767 and InputApi.DEFAULT_FILES_TO_SKIP is used respectively.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000768
Bruce Dawson635383f2022-09-13 16:23:18 +0000769 affected_file.LocalPath() needs to re.match an entry in the files_to_check
770 list and not re.match any entries in the files_to_skip list.
771 '/' path separators should be used in the regular expressions and will work
772 on Windows as well as other platforms.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000773
774 Note: Copy-paste this function to suit your needs or use a lambda function.
775 """
local_bot64021412020-07-08 21:05:39 +0000776 if files_to_check is None:
777 files_to_check = self.DEFAULT_FILES_TO_CHECK
778 if files_to_skip is None:
779 files_to_skip = self.DEFAULT_FILES_TO_SKIP
local_bot30f774e2020-06-25 18:23:34 +0000780
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000781 def Find(affected_file, items):
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000782 local_path = affected_file.LocalPath()
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000783 for item in items:
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +0000784 if self.re.match(item, local_path):
maruel@chromium.org3410d912009-06-09 20:56:16 +0000785 return True
Bruce Dawsona3a014e2022-04-27 23:28:17 +0000786 # Handle the cases where the files regex only handles /, but the local
787 # path uses \.
788 if self.is_windows and self.re.match(item, local_path.replace(
789 '\\', '/')):
790 return True
maruel@chromium.org3410d912009-06-09 20:56:16 +0000791 return False
local_bot64021412020-07-08 21:05:39 +0000792 return (Find(affected_file, files_to_check) and
793 not Find(affected_file, files_to_skip))
maruel@chromium.org3410d912009-06-09 20:56:16 +0000794
795 def AffectedSourceFiles(self, source_file):
agable0b65e732016-11-22 09:25:46 -0800796 """Filter the list of AffectedTestableFiles by the function source_file.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000797
798 If source_file is None, InputApi.FilterSourceFile() is used.
799 """
800 if not source_file:
801 source_file = self.FilterSourceFile
Edward Lemurb9830242019-10-30 22:19:20 +0000802 return list(filter(source_file, self.AffectedTestableFiles()))
maruel@chromium.org3410d912009-06-09 20:56:16 +0000803
804 def RightHandSideLines(self, source_file_filter=None):
Edward Lemura5799e32020-01-17 19:26:51 +0000805 """An iterator over all text lines in 'new' version of changed files.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000806
807 Only lists lines from new or modified text files in the change that are
808 contained by the directory of the currently executing presubmit script.
809
810 This is useful for doing line-by-line regex checks, like checking for
811 trailing whitespace.
812
813 Yields:
814 a 3 tuple:
815 the AffectedFile instance of the current file;
816 integer line number (1-based); and
817 the contents of the line as a string.
maruel@chromium.org1487d532009-06-06 00:22:57 +0000818
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000819 Note: The carriage return (LF or CR) is stripped off.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000820 """
maruel@chromium.org3410d912009-06-09 20:56:16 +0000821 files = self.AffectedSourceFiles(source_file_filter)
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000822 return _RightHandSideLinesImpl(files)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000823
maruel@chromium.orge3608df2009-11-10 20:22:57 +0000824 def ReadFile(self, file_item, mode='r'):
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000825 """Reads an arbitrary file.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000826
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000827 Deny reading anything outside the repository.
828 """
maruel@chromium.orge3608df2009-11-10 20:22:57 +0000829 if isinstance(file_item, AffectedFile):
830 file_item = file_item.AbsoluteLocalPath()
831 if not file_item.startswith(self.change.RepositoryRoot()):
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000832 raise IOError('Access outside the repository root is denied.')
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +0000833 return gclient_utils.FileRead(file_item, mode)
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000834
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +0100835 def CreateTemporaryFile(self, **kwargs):
836 """Returns a named temporary file that must be removed with a call to
837 RemoveTemporaryFiles().
838
839 All keyword arguments are forwarded to tempfile.NamedTemporaryFile(),
840 except for |delete|, which is always set to False.
841
842 Presubmit checks that need to create a temporary file and pass it for
843 reading should use this function instead of NamedTemporaryFile(), as
844 Windows fails to open a file that is already open for writing.
845
846 with input_api.CreateTemporaryFile() as f:
847 f.write('xyz')
848 f.close()
849 input_api.subprocess.check_output(['script-that', '--reads-from',
850 f.name])
851
852
853 Note that callers of CreateTemporaryFile() should not worry about removing
854 any temporary file; this is done transparently by the presubmit handling
855 code.
856 """
857 if 'delete' in kwargs:
858 # Prevent users from passing |delete|; we take care of file deletion
859 # ourselves and this prevents unintuitive error messages when we pass
860 # delete=False and 'delete' is also in kwargs.
861 raise TypeError('CreateTemporaryFile() does not take a "delete" '
862 'argument, file deletion is handled automatically by '
863 'the same presubmit_support code that creates InputApi '
864 'objects.')
865 temp_file = self.tempfile.NamedTemporaryFile(delete=False, **kwargs)
866 self._named_temporary_files.append(temp_file.name)
867 return temp_file
868
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000869 @property
870 def tbr(self):
871 """Returns if a change is TBR'ed."""
Jeremy Romandce22502017-06-20 15:37:29 -0400872 return 'TBR' in self.change.tags or self.change.TBRsFromDescription()
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000873
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +0000874 def RunTests(self, tests_mix, parallel=True):
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000875 tests = []
876 msgs = []
877 for t in tests_mix:
Edward Lesmes8e282792018-04-03 18:50:29 -0400878 if isinstance(t, OutputApi.PresubmitResult) and t:
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000879 msgs.append(t)
880 else:
881 assert issubclass(t.message, _PresubmitResult)
882 tests.append(t)
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +0000883 if self.verbose:
884 t.info = _PresubmitNotifyResult
Edward Lemur1037c742018-05-01 18:56:04 -0400885 if not t.kwargs.get('cwd'):
886 t.kwargs['cwd'] = self.PresubmitLocalPath()
Edward Lesmes8e282792018-04-03 18:50:29 -0400887 self.thread_pool.AddTests(tests, parallel)
Edward Lemur21000eb2019-05-24 23:25:58 +0000888 # When self.parallel is True (i.e. --parallel is passed as an option)
889 # RunTests doesn't actually run tests. It adds them to a ThreadPool that
890 # will run all tests once all PRESUBMIT files are processed.
891 # Otherwise, it will run them and return the results.
892 if not self.parallel:
Edward Lesmes8e282792018-04-03 18:50:29 -0400893 msgs.extend(self.thread_pool.RunAsync())
894 return msgs
scottmg86099d72016-09-01 09:16:51 -0700895
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000896
nick@chromium.orgff526192013-06-10 19:30:26 +0000897class _DiffCache(object):
898 """Caches diffs retrieved from a particular SCM."""
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000899 def __init__(self, upstream=None):
900 """Stores the upstream revision against which all diffs will be computed."""
901 self._upstream = upstream
nick@chromium.orgff526192013-06-10 19:30:26 +0000902
903 def GetDiff(self, path, local_root):
904 """Get the diff for a particular path."""
905 raise NotImplementedError()
906
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700907 def GetOldContents(self, path, local_root):
908 """Get the old version for a particular path."""
909 raise NotImplementedError()
910
nick@chromium.orgff526192013-06-10 19:30:26 +0000911
nick@chromium.orgff526192013-06-10 19:30:26 +0000912class _GitDiffCache(_DiffCache):
913 """DiffCache implementation for git; gets all file diffs at once."""
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000914 def __init__(self, upstream):
915 super(_GitDiffCache, self).__init__(upstream=upstream)
nick@chromium.orgff526192013-06-10 19:30:26 +0000916 self._diffs_by_file = None
917
918 def GetDiff(self, path, local_root):
Bruce Dawson5f63d3c2022-04-19 17:02:36 +0000919 # Compare against None to distinguish between None and an initialized but
920 # empty dictionary.
921 if self._diffs_by_file == None:
nick@chromium.orgff526192013-06-10 19:30:26 +0000922 # Compute a single diff for all files and parse the output; should
923 # with git this is much faster than computing one diff for each file.
924 diffs = {}
925
926 # Don't specify any filenames below, because there are command line length
927 # limits on some platforms and GenerateDiff would fail.
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000928 unified_diff = scm.GIT.GenerateDiff(local_root, files=[], full_move=True,
929 branch=self._upstream)
nick@chromium.orgff526192013-06-10 19:30:26 +0000930
931 # This regex matches the path twice, separated by a space. Note that
932 # filename itself may contain spaces.
933 file_marker = re.compile('^diff --git (?P<filename>.*) (?P=filename)$')
934 current_diff = []
935 keep_line_endings = True
936 for x in unified_diff.splitlines(keep_line_endings):
937 match = file_marker.match(x)
938 if match:
939 # Marks the start of a new per-file section.
940 diffs[match.group('filename')] = current_diff = [x]
941 elif x.startswith('diff --git'):
942 raise PresubmitFailure('Unexpected diff line: %s' % x)
943 else:
944 current_diff.append(x)
945
946 self._diffs_by_file = dict(
947 (normpath(path), ''.join(diff)) for path, diff in diffs.items())
948
949 if path not in self._diffs_by_file:
Josip Sokcevicc1ab7342022-02-24 19:02:44 +0000950 # SCM didn't have any diff on this file. It could be that the file was not
951 # modified at all (e.g. user used --all flag in git cl presubmit).
952 # Intead of failing, return empty string.
953 # See: https://crbug.com/808346.
Josip Sokcevicc1ab7342022-02-24 19:02:44 +0000954 return ''
nick@chromium.orgff526192013-06-10 19:30:26 +0000955
956 return self._diffs_by_file[path]
957
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700958 def GetOldContents(self, path, local_root):
959 return scm.GIT.GetOldContents(local_root, path, branch=self._upstream)
960
nick@chromium.orgff526192013-06-10 19:30:26 +0000961
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000962class AffectedFile(object):
963 """Representation of a file in a change."""
nick@chromium.orgff526192013-06-10 19:30:26 +0000964
965 DIFF_CACHE = _DiffCache
966
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000967 # Method could be a function
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800968 # pylint: disable=no-self-use
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000969 def __init__(self, path, action, repository_root, diff_cache):
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000970 self._path = path
971 self._action = action
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000972 self._local_root = repository_root
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000973 self._is_directory = None
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000974 self._cached_changed_contents = None
975 self._cached_new_contents = None
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000976 self._diff_cache = diff_cache
tobiasjs2836bcf2016-08-16 04:08:16 -0700977 logging.debug('%s(%s)', self.__class__.__name__, self._path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000978
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000979 def LocalPath(self):
980 """Returns the path of this file on the local disk relative to client root.
Andrew Grieve92b8b992017-11-02 09:42:24 -0400981
982 This should be used for error messages but not for accessing files,
983 because presubmit checks are run with CWD=PresubmitLocalPath() (which is
984 often != client root).
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000985 """
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000986 return normpath(self._path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000987
988 def AbsoluteLocalPath(self):
989 """Returns the absolute path of this file on the local disk.
990 """
chase@chromium.org8e416c82009-10-06 04:30:44 +0000991 return os.path.abspath(os.path.join(self._local_root, self.LocalPath()))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000992
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000993 def Action(self):
994 """Returns the action on this opened file, e.g. A, M, D, etc."""
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000995 return self._action
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000996
agable0b65e732016-11-22 09:25:46 -0800997 def IsTestableFile(self):
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000998 """Returns True if the file is a text file and not a binary file.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000999
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +00001000 Deleted files are not text file."""
maruel@chromium.org1e08c002009-05-28 19:09:33 +00001001 raise NotImplementedError() # Implement when needed
1002
agable0b65e732016-11-22 09:25:46 -08001003 def IsTextFile(self):
1004 """An alias to IsTestableFile for backwards compatibility."""
1005 return self.IsTestableFile()
1006
Daniel Cheng7a1f04d2017-03-21 19:12:31 -07001007 def OldContents(self):
1008 """Returns an iterator over the lines in the old version of file.
1009
Daniel Cheng2da34fe2017-03-21 20:42:12 -07001010 The old version is the file before any modifications in the user's
Edward Lemura5799e32020-01-17 19:26:51 +00001011 workspace, i.e. the 'left hand side'.
Daniel Cheng7a1f04d2017-03-21 19:12:31 -07001012
1013 Contents will be empty if the file is a directory or does not exist.
1014 Note: The carriage returns (LF or CR) are stripped off.
1015 """
1016 return self._diff_cache.GetOldContents(self.LocalPath(),
1017 self._local_root).splitlines()
1018
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001019 def NewContents(self):
1020 """Returns an iterator over the lines in the new version of file.
1021
Edward Lemura5799e32020-01-17 19:26:51 +00001022 The new version is the file in the user's workspace, i.e. the 'right hand
1023 side'.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001024
1025 Contents will be empty if the file is a directory or does not exist.
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +00001026 Note: The carriage returns (LF or CR) are stripped off.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001027 """
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +00001028 if self._cached_new_contents is None:
1029 self._cached_new_contents = []
agable0b65e732016-11-22 09:25:46 -08001030 try:
1031 self._cached_new_contents = gclient_utils.FileRead(
1032 self.AbsoluteLocalPath(), 'rU').splitlines()
1033 except IOError:
1034 pass # File not found? That's fine; maybe it was deleted.
Greg Thompson30cde452021-06-01 16:38:47 +00001035 except UnicodeDecodeError as e:
Dirk Pranke6fc394f2021-05-26 23:25:14 +00001036 # log the filename since we're probably trying to read a binary
1037 # file, and shouldn't be.
1038 print('Error reading %s: %s' % (self.AbsoluteLocalPath(), e))
1039 raise
1040
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +00001041 return self._cached_new_contents[:]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001042
Bruce Dawsonf0bcfdd2021-05-21 18:10:23 +00001043 def ChangedContents(self, keeplinebreaks=False):
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001044 """Returns a list of tuples (line number, line text) of all new lines.
1045
1046 This relies on the scm diff output describing each changed code section
1047 with a line of the form
1048
1049 ^@@ <old line num>,<old size> <new line num>,<new size> @@$
1050 """
Bruce Dawsonf0bcfdd2021-05-21 18:10:23 +00001051 # Don't return cached results when line breaks are requested.
1052 if not keeplinebreaks and self._cached_changed_contents is not None:
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +00001053 return self._cached_changed_contents[:]
Bruce Dawsonf0bcfdd2021-05-21 18:10:23 +00001054 result = []
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001055 line_num = 0
1056
Bruce Dawsonf0bcfdd2021-05-21 18:10:23 +00001057 # The keeplinebreaks parameter to splitlines must be True or else the
1058 # CheckForWindowsLineEndings presubmit will be a NOP.
1059 for line in self.GenerateScmDiff().splitlines(keeplinebreaks):
Edward Lemurac5c55f2020-02-29 00:17:16 +00001060 m = re.match(r'^@@ [0-9\,\+\-]+ \+([0-9]+)\,[0-9]+ @@', line)
1061 if m:
1062 line_num = int(m.groups(1)[0])
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001063 continue
1064 if line.startswith('+') and not line.startswith('++'):
Bruce Dawsonf0bcfdd2021-05-21 18:10:23 +00001065 result.append((line_num, line[1:]))
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001066 if not line.startswith('-'):
1067 line_num += 1
Bruce Dawsonf0bcfdd2021-05-21 18:10:23 +00001068 # Don't cache results with line breaks.
1069 if keeplinebreaks:
1070 return result;
1071 self._cached_changed_contents = result
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +00001072 return self._cached_changed_contents[:]
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001073
maruel@chromium.org5de13972009-06-10 18:16:06 +00001074 def __str__(self):
1075 return self.LocalPath()
1076
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001077 def GenerateScmDiff(self):
nick@chromium.orgff526192013-06-10 19:30:26 +00001078 return self._diff_cache.GetDiff(self.LocalPath(), self._local_root)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001079
maruel@chromium.org58407af2011-04-12 23:15:57 +00001080
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001081class GitAffectedFile(AffectedFile):
1082 """Representation of a file in a change out of a git checkout."""
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +00001083 # Method 'NNN' is abstract in class 'NNN' but is not overridden
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -08001084 # pylint: disable=abstract-method
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001085
nick@chromium.orgff526192013-06-10 19:30:26 +00001086 DIFF_CACHE = _GitDiffCache
1087
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001088 def __init__(self, *args, **kwargs):
1089 AffectedFile.__init__(self, *args, **kwargs)
1090 self._server_path = None
agable0b65e732016-11-22 09:25:46 -08001091 self._is_testable_file = None
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001092
agable0b65e732016-11-22 09:25:46 -08001093 def IsTestableFile(self):
1094 if self._is_testable_file is None:
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001095 if self.Action() == 'D':
agable0b65e732016-11-22 09:25:46 -08001096 # A deleted file is not testable.
1097 self._is_testable_file = False
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001098 else:
agable0b65e732016-11-22 09:25:46 -08001099 self._is_testable_file = os.path.isfile(self.AbsoluteLocalPath())
1100 return self._is_testable_file
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001101
maruel@chromium.orgc1938752011-04-12 23:11:13 +00001102
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001103class Change(object):
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001104 """Describe a change.
1105
1106 Used directly by the presubmit scripts to query the current change being
1107 tested.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +00001108
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001109 Instance members:
nick@chromium.orgff526192013-06-10 19:30:26 +00001110 tags: Dictionary of KEY=VALUE pairs found in the change description.
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001111 self.KEY: equivalent to tags['KEY']
1112 """
1113
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001114 _AFFECTED_FILES = AffectedFile
1115
Edward Lemura5799e32020-01-17 19:26:51 +00001116 # Matches key/value (or 'tag') lines in changelist descriptions.
maruel@chromium.org428342a2011-11-10 15:46:33 +00001117 TAG_LINE_RE = re.compile(
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001118 '^[ \t]*(?P<key>[A-Z][A-Z_0-9]*)[ \t]*=[ \t]*(?P<value>.*?)[ \t]*$')
maruel@chromium.orgc1938752011-04-12 23:11:13 +00001119 scm = ''
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001120
maruel@chromium.org58407af2011-04-12 23:15:57 +00001121 def __init__(
agable@chromium.orgea84ef12014-04-30 19:55:12 +00001122 self, name, description, local_root, files, issue, patchset, author,
1123 upstream=None):
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001124 if files is None:
1125 files = []
1126 self._name = name
chase@chromium.org8e416c82009-10-06 04:30:44 +00001127 # Convert root into an absolute path.
1128 self._local_root = os.path.abspath(local_root)
agable@chromium.orgea84ef12014-04-30 19:55:12 +00001129 self._upstream = upstream
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001130 self.issue = issue
1131 self.patchset = patchset
maruel@chromium.org58407af2011-04-12 23:15:57 +00001132 self.author_email = author
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001133
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001134 self._full_description = ''
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001135 self.tags = {}
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001136 self._description_without_tags = ''
1137 self.SetDescriptionText(description)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001138
maruel@chromium.orge085d812011-10-10 19:49:15 +00001139 assert all(
1140 (isinstance(f, (list, tuple)) and len(f) == 2) for f in files), files
1141
agable@chromium.orgea84ef12014-04-30 19:55:12 +00001142 diff_cache = self._AFFECTED_FILES.DIFF_CACHE(self._upstream)
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001143 self._affected_files = [
nick@chromium.orgff526192013-06-10 19:30:26 +00001144 self._AFFECTED_FILES(path, action.strip(), self._local_root, diff_cache)
1145 for action, path in files
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +00001146 ]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001147
Edward Lesmes9ce03f82021-01-12 20:13:31 +00001148 def UpstreamBranch(self):
1149 """Returns the upstream branch for the change."""
1150 return self._upstream
1151
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001152 def Name(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001153 """Returns the change name."""
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001154 return self._name
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001155
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001156 def DescriptionText(self):
1157 """Returns the user-entered changelist description, minus tags.
1158
Edward Lemura5799e32020-01-17 19:26:51 +00001159 Any line in the user-provided description starting with e.g. 'FOO='
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001160 (whitespace permitted before and around) is considered a tag line. Such
1161 lines are stripped out of the description this function returns.
1162 """
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001163 return self._description_without_tags
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001164
1165 def FullDescriptionText(self):
1166 """Returns the complete changelist description including tags."""
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001167 return self._full_description
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001168
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001169 def SetDescriptionText(self, description):
1170 """Sets the full description text (including tags) to |description|.
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001171
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001172 Also updates the list of tags."""
1173 self._full_description = description
1174
1175 # From the description text, build up a dictionary of key/value pairs
Edward Lemura5799e32020-01-17 19:26:51 +00001176 # plus the description minus all key/value or 'tag' lines.
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001177 description_without_tags = []
1178 self.tags = {}
1179 for line in self._full_description.splitlines():
1180 m = self.TAG_LINE_RE.match(line)
1181 if m:
1182 self.tags[m.group('key')] = m.group('value')
1183 else:
1184 description_without_tags.append(line)
1185
1186 # Change back to text and remove whitespace at end.
1187 self._description_without_tags = (
1188 '\n'.join(description_without_tags).rstrip())
1189
Edward Lemur69bb8be2020-02-03 20:37:38 +00001190 def AddDescriptionFooter(self, key, value):
1191 """Adds the given footer to the change description.
1192
1193 Args:
1194 key: A string with the key for the git footer. It must conform to
1195 the git footers format (i.e. 'List-Of-Tokens') and will be case
1196 normalized so that each token is title-cased.
1197 value: A string with the value for the git footer.
1198 """
1199 description = git_footers.add_footer(
1200 self.FullDescriptionText(), git_footers.normalize_name(key), value)
1201 self.SetDescriptionText(description)
1202
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001203 def RepositoryRoot(self):
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001204 """Returns the repository (checkout) root directory for this change,
1205 as an absolute path.
1206 """
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001207 return self._local_root
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001208
1209 def __getattr__(self, attr):
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001210 """Return tags directly as attributes on the object."""
Edward Lemura5799e32020-01-17 19:26:51 +00001211 if not re.match(r'^[A-Z_]*$', attr):
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001212 raise AttributeError(self, attr)
maruel@chromium.orge1a524f2009-05-27 14:43:46 +00001213 return self.tags.get(attr)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001214
Edward Lemur69bb8be2020-02-03 20:37:38 +00001215 def GitFootersFromDescription(self):
1216 """Return the git footers present in the description.
1217
1218 Returns:
1219 footers: A dict of {footer: [values]} containing a multimap of the footers
1220 in the change description.
1221 """
1222 return git_footers.parse_footers(self.FullDescriptionText())
1223
Aaron Gablefc03e672017-05-15 14:09:42 -07001224 def BugsFromDescription(self):
1225 """Returns all bugs referenced in the commit description."""
Sean McAllister1e509c52021-10-25 17:54:25 +00001226 bug_tags = ['BUG', 'FIXED']
1227
1228 tags = []
1229 for tag in bug_tags:
1230 values = self.tags.get(tag)
1231 if values:
1232 tags += [value.strip() for value in values.split(',')]
1233
Caleb Rouleauc0546b92019-02-22 06:12:57 +00001234 footers = []
Edward Lemur69bb8be2020-02-03 20:37:38 +00001235 parsed = self.GitFootersFromDescription()
Dan Beam62954042019-10-03 21:20:33 +00001236 unsplit_footers = parsed.get('Bug', []) + parsed.get('Fixed', [])
Caleb Rouleauc0546b92019-02-22 06:12:57 +00001237 for unsplit_footer in unsplit_footers:
1238 footers += [b.strip() for b in unsplit_footer.split(',')]
Aaron Gable12ef5012017-05-15 14:29:00 -07001239 return sorted(set(tags + footers))
Aaron Gablefc03e672017-05-15 14:09:42 -07001240
1241 def ReviewersFromDescription(self):
1242 """Returns all reviewers listed in the commit description."""
Edward Lemura5799e32020-01-17 19:26:51 +00001243 # We don't support a 'R:' git-footer for reviewers; that is in metadata.
Aaron Gable12ef5012017-05-15 14:29:00 -07001244 tags = [r.strip() for r in self.tags.get('R', '').split(',') if r.strip()]
1245 return sorted(set(tags))
Aaron Gablefc03e672017-05-15 14:09:42 -07001246
1247 def TBRsFromDescription(self):
1248 """Returns all TBR reviewers listed in the commit description."""
Aaron Gable12ef5012017-05-15 14:29:00 -07001249 tags = [r.strip() for r in self.tags.get('TBR', '').split(',') if r.strip()]
Aaron Gable6e7ddb62020-05-27 22:23:29 +00001250 # TODO(crbug.com/839208): Remove support for 'Tbr:' when TBRs are
1251 # programmatically determined by self-CR+1s.
Edward Lemur69bb8be2020-02-03 20:37:38 +00001252 footers = self.GitFootersFromDescription().get('Tbr', [])
Aaron Gable12ef5012017-05-15 14:29:00 -07001253 return sorted(set(tags + footers))
Aaron Gablefc03e672017-05-15 14:09:42 -07001254
Aaron Gable6e7ddb62020-05-27 22:23:29 +00001255 # TODO(crbug.com/753425): Delete these once we're sure they're unused.
Aaron Gablefc03e672017-05-15 14:09:42 -07001256 @property
1257 def BUG(self):
1258 return ','.join(self.BugsFromDescription())
1259 @property
1260 def R(self):
1261 return ','.join(self.ReviewersFromDescription())
1262 @property
1263 def TBR(self):
1264 return ','.join(self.TBRsFromDescription())
1265
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001266 def AllFiles(self, root=None):
1267 """List all files under source control in the repo."""
1268 raise NotImplementedError()
1269
agable0b65e732016-11-22 09:25:46 -08001270 def AffectedFiles(self, include_deletes=True, file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001271 """Returns a list of AffectedFile instances for all files in the change.
1272
1273 Args:
1274 include_deletes: If false, deleted files will be filtered out.
sail@chromium.org5538e022011-05-12 17:53:16 +00001275 file_filter: An additional filter to apply.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001276
1277 Returns:
1278 [AffectedFile(path, action), AffectedFile(path, action)]
1279 """
Edward Lemurb9830242019-10-30 22:19:20 +00001280 affected = list(filter(file_filter, self._affected_files))
sail@chromium.org5538e022011-05-12 17:53:16 +00001281
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001282 if include_deletes:
1283 return affected
Edward Lemurb9830242019-10-30 22:19:20 +00001284 return list(filter(lambda x: x.Action() != 'D', affected))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001285
John Budorick16162372018-04-18 10:39:53 -07001286 def AffectedTestableFiles(self, include_deletes=None, **kwargs):
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +00001287 """Return a list of the existing text files in a change."""
1288 if include_deletes is not None:
Edward Lemura5799e32020-01-17 19:26:51 +00001289 warn('AffectedTeestableFiles(include_deletes=%s)'
1290 ' is deprecated and ignored' % str(include_deletes),
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +00001291 category=DeprecationWarning,
1292 stacklevel=2)
Edward Lemurb9830242019-10-30 22:19:20 +00001293 return list(filter(
1294 lambda x: x.IsTestableFile(),
1295 self.AffectedFiles(include_deletes=False, **kwargs)))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001296
agable0b65e732016-11-22 09:25:46 -08001297 def AffectedTextFiles(self, include_deletes=None):
1298 """An alias to AffectedTestableFiles for backwards compatibility."""
1299 return self.AffectedTestableFiles(include_deletes=include_deletes)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001300
agable0b65e732016-11-22 09:25:46 -08001301 def LocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001302 """Convenience function."""
agable0b65e732016-11-22 09:25:46 -08001303 return [af.LocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001304
agable0b65e732016-11-22 09:25:46 -08001305 def AbsoluteLocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001306 """Convenience function."""
agable0b65e732016-11-22 09:25:46 -08001307 return [af.AbsoluteLocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001308
1309 def RightHandSideLines(self):
Edward Lemura5799e32020-01-17 19:26:51 +00001310 """An iterator over all text lines in 'new' version of changed files.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001311
1312 Lists lines from new or modified text files in the change.
1313
1314 This is useful for doing line-by-line regex checks, like checking for
1315 trailing whitespace.
1316
1317 Yields:
1318 a 3 tuple:
1319 the AffectedFile instance of the current file;
1320 integer line number (1-based); and
1321 the contents of the line as a string.
1322 """
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +00001323 return _RightHandSideLinesImpl(
1324 x for x in self.AffectedFiles(include_deletes=False)
agable0b65e732016-11-22 09:25:46 -08001325 if x.IsTestableFile())
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001326
Jochen Eisingerd0573ec2017-04-13 10:55:06 +02001327 def OriginalOwnersFiles(self):
1328 """A map from path names of affected OWNERS files to their old content."""
1329 def owners_file_filter(f):
1330 return 'OWNERS' in os.path.split(f.LocalPath())[1]
1331 files = self.AffectedFiles(file_filter=owners_file_filter)
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +00001332 return {f.LocalPath(): f.OldContents() for f in files}
Jochen Eisingerd0573ec2017-04-13 10:55:06 +02001333
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001334
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001335class GitChange(Change):
1336 _AFFECTED_FILES = GitAffectedFile
maruel@chromium.orgc1938752011-04-12 23:11:13 +00001337 scm = 'git'
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +00001338
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001339 def AllFiles(self, root=None):
1340 """List all files under source control in the repo."""
1341 root = root or self.RepositoryRoot()
1342 return subprocess.check_output(
Aaron Gable7817f022017-12-12 09:43:17 -08001343 ['git', '-c', 'core.quotePath=false', 'ls-files', '--', '.'],
Josip Sokcevic0b123462021-06-08 20:41:32 +00001344 cwd=root).decode('utf-8', 'ignore').splitlines()
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001345
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001346
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001347def ListRelevantPresubmitFiles(files, root):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001348 """Finds all presubmit files that apply to a given set of source files.
1349
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001350 If inherit-review-settings-ok is present right under root, looks for
1351 PRESUBMIT.py in directories enclosing root.
1352
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001353 Args:
1354 files: An iterable container containing file paths.
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001355 root: Path where to stop searching.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001356
1357 Return:
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001358 List of absolute paths of the existing PRESUBMIT.py scripts.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001359 """
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001360 files = [normpath(os.path.join(root, f)) for f in files]
1361
1362 # List all the individual directories containing files.
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +00001363 directories = {os.path.dirname(f) for f in files}
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001364
1365 # Ignore root if inherit-review-settings-ok is present.
1366 if os.path.isfile(os.path.join(root, 'inherit-review-settings-ok')):
1367 root = None
1368
1369 # Collect all unique directories that may contain PRESUBMIT.py.
1370 candidates = set()
1371 for directory in directories:
1372 while True:
1373 if directory in candidates:
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001374 break
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001375 candidates.add(directory)
1376 if directory == root:
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001377 break
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001378 parent_dir = os.path.dirname(directory)
1379 if parent_dir == directory:
1380 # We hit the system root directory.
1381 break
1382 directory = parent_dir
1383
1384 # Look for PRESUBMIT.py in all candidate directories.
1385 results = []
1386 for directory in sorted(list(candidates)):
tobiasjsff061c02016-08-17 03:23:57 -07001387 try:
1388 for f in os.listdir(directory):
1389 p = os.path.join(directory, f)
1390 if os.path.isfile(p) and re.match(
1391 r'PRESUBMIT.*\.py$', f) and not f.startswith('PRESUBMIT_test'):
1392 results.append(p)
1393 except OSError:
1394 pass
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001395
tobiasjs2836bcf2016-08-16 04:08:16 -07001396 logging.debug('Presubmit files: %s', ','.join(results))
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001397 return results
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001398
1399
rmistry@google.com5626a922015-02-26 14:03:30 +00001400class GetPostUploadExecuter(object):
Josip Sokcevice293d3d2022-02-16 22:52:15 +00001401 def __init__(self, use_python3):
1402 """
1403 Args:
1404 use_python3: if true, will use python3 instead of python2 by default
1405 if USE_PYTHON3 is not specified.
1406 """
1407 self.use_python3 = use_python3
1408
1409 def ExecPresubmitScript(self, script_text, presubmit_path, gerrit_obj,
1410 change):
rmistry@google.com5626a922015-02-26 14:03:30 +00001411 """Executes PostUploadHook() from a single presubmit script.
Josip Sokcevic632bbc02022-05-19 05:32:50 +00001412 Caller is responsible for validating whether the hook should be executed
1413 and should only call this function if it should be.
rmistry@google.com5626a922015-02-26 14:03:30 +00001414
1415 Args:
1416 script_text: The text of the presubmit script.
1417 presubmit_path: Project script to run.
Edward Lemur016a0872020-02-04 22:13:28 +00001418 gerrit_obj: The GerritAccessor object.
rmistry@google.com5626a922015-02-26 14:03:30 +00001419 change: The Change object.
1420
1421 Return:
1422 A list of results objects.
1423 """
1424 context = {}
1425 try:
Raul Tambre09e64b42019-05-14 01:57:22 +00001426 exec(compile(script_text, 'PRESUBMIT.py', 'exec', dont_inherit=True),
1427 context)
Raul Tambre7c938462019-05-24 16:35:35 +00001428 except Exception as e:
rmistry@google.com5626a922015-02-26 14:03:30 +00001429 raise PresubmitFailure('"%s" had an exception.\n%s'
1430 % (presubmit_path, e))
1431
1432 function_name = 'PostUploadHook'
1433 if function_name not in context:
1434 return {}
1435 post_upload_hook = context[function_name]
1436 if not len(inspect.getargspec(post_upload_hook)[0]) == 3:
1437 raise PresubmitFailure(
1438 'Expected function "PostUploadHook" to take three arguments.')
Edward Lemur016a0872020-02-04 22:13:28 +00001439 return post_upload_hook(gerrit_obj, change, OutputApi(False))
rmistry@google.com5626a922015-02-26 14:03:30 +00001440
1441
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001442def _MergeMasters(masters1, masters2):
1443 """Merges two master maps. Merges also the tests of each builder."""
1444 result = {}
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001445 for (master, builders) in itertools.chain(masters1.items(),
1446 masters2.items()):
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001447 new_builders = result.setdefault(master, {})
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001448 for (builder, tests) in builders.items():
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001449 new_builders.setdefault(builder, set([])).update(tests)
1450 return result
1451
1452
Josip Sokcevice293d3d2022-02-16 22:52:15 +00001453def DoPostUploadExecuter(change, gerrit_obj, verbose, use_python3=False):
rmistry@google.com5626a922015-02-26 14:03:30 +00001454 """Execute the post upload hook.
1455
1456 Args:
1457 change: The Change object.
Edward Lemur016a0872020-02-04 22:13:28 +00001458 gerrit_obj: The GerritAccessor object.
rmistry@google.com5626a922015-02-26 14:03:30 +00001459 verbose: Prints debug info.
Josip Sokcevice293d3d2022-02-16 22:52:15 +00001460 use_python3: if true, default to using Python3 for presubmit checks
1461 rather than Python2.
rmistry@google.com5626a922015-02-26 14:03:30 +00001462 """
Josip Sokcevice293d3d2022-02-16 22:52:15 +00001463 python_version = 'Python %s' % sys.version_info.major
1464 sys.stdout.write('Running %s post upload checks ...\n' % python_version)
rmistry@google.com5626a922015-02-26 14:03:30 +00001465 presubmit_files = ListRelevantPresubmitFiles(
Edward Lemur6eb1d322020-02-27 22:20:15 +00001466 change.LocalPaths(), change.RepositoryRoot())
rmistry@google.com5626a922015-02-26 14:03:30 +00001467 if not presubmit_files and verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001468 sys.stdout.write('Warning, no PRESUBMIT.py found.\n')
rmistry@google.com5626a922015-02-26 14:03:30 +00001469 results = []
Josip Sokcevice293d3d2022-02-16 22:52:15 +00001470 executer = GetPostUploadExecuter(use_python3)
rmistry@google.com5626a922015-02-26 14:03:30 +00001471 # The root presubmit file should be executed after the ones in subdirectories.
1472 # i.e. the specific post upload hooks should run before the general ones.
1473 # Thus, reverse the order provided by ListRelevantPresubmitFiles.
1474 presubmit_files.reverse()
1475
1476 for filename in presubmit_files:
1477 filename = os.path.abspath(filename)
rmistry@google.com5626a922015-02-26 14:03:30 +00001478 # Accept CRLF presubmit script.
Bruce Dawson6e70e862022-07-01 19:37:01 +00001479 presubmit_script = gclient_utils.FileRead(filename).replace('\r\n', '\n')
Josip Sokcevic632bbc02022-05-19 05:32:50 +00001480 if _ShouldRunPresubmit(presubmit_script, use_python3):
Bruce Dawson8d78bd12022-08-12 19:17:03 +00001481 if sys.version_info[0] == 2:
Bruce Dawson443f9852022-09-08 17:30:59 +00001482 sys.stdout.write(
1483 'Running %s under Python 2. Add USE_PYTHON3 = True to prevent '
1484 'this.\n' % filename)
Bruce Dawson8d78bd12022-08-12 19:17:03 +00001485 elif verbose:
1486 sys.stdout.write('Running %s\n' % filename)
Josip Sokcevic632bbc02022-05-19 05:32:50 +00001487 results.extend(executer.ExecPresubmitScript(
1488 presubmit_script, filename, gerrit_obj, change))
rmistry@google.com5626a922015-02-26 14:03:30 +00001489
Edward Lemur6eb1d322020-02-27 22:20:15 +00001490 if not results:
1491 return 0
1492
1493 sys.stdout.write('\n')
1494 sys.stdout.write('** Post Upload Hook Messages **\n')
1495
1496 exit_code = 0
1497 for result in results:
1498 if result.fatal:
1499 exit_code = 1
1500 result.handle()
1501 sys.stdout.write('\n')
1502
1503 return exit_code
rmistry@google.com5626a922015-02-26 14:03:30 +00001504
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001505class PresubmitExecuter(object):
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001506 def __init__(self, change, committing, verbose, gerrit_obj, dry_run=None,
Bruce Dawson09c0c072022-05-26 20:28:58 +00001507 thread_pool=None, parallel=False, use_python3=False,
1508 no_diffs=False):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001509 """
1510 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001511 change: The Change object.
agable92bec4f2016-08-24 09:27:27 -07001512 committing: True if 'git cl land' is running, False if 'git cl upload' is.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001513 gerrit_obj: provides basic Gerrit codereview functionality.
1514 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -04001515 parallel: if true, all tests reported via input_api.RunTests for all
1516 PRESUBMIT files will be run in parallel.
Dirk Pranke6f0df682021-06-25 00:42:33 +00001517 use_python3: if true, will use python3 instead of python2 by default
1518 if USE_PYTHON3 is not specified.
Bruce Dawson09c0c072022-05-26 20:28:58 +00001519 no_diffs: if true, implies that --files or --all was specified so some
1520 checks can be skipped, and some errors will be messages.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001521 """
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001522 self.change = change
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001523 self.committing = committing
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001524 self.gerrit = gerrit_obj
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001525 self.verbose = verbose
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001526 self.dry_run = dry_run
Daniel Cheng7227d212017-11-17 08:12:37 -08001527 self.more_cc = []
Edward Lesmes8e282792018-04-03 18:50:29 -04001528 self.thread_pool = thread_pool
1529 self.parallel = parallel
Dirk Pranke6f0df682021-06-25 00:42:33 +00001530 self.use_python3 = use_python3
Bruce Dawson09c0c072022-05-26 20:28:58 +00001531 self.no_diffs = no_diffs
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001532
1533 def ExecPresubmitScript(self, script_text, presubmit_path):
1534 """Executes a single presubmit script.
Josip Sokcevic632bbc02022-05-19 05:32:50 +00001535 Caller is responsible for validating whether the hook should be executed
1536 and should only call this function if it should be.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001537
1538 Args:
1539 script_text: The text of the presubmit script.
1540 presubmit_path: The path to the presubmit file (this will be reported via
1541 input_api.PresubmitLocalPath()).
1542
1543 Return:
1544 A list of result objects, empty if no problems.
1545 """
chase@chromium.org8e416c82009-10-06 04:30:44 +00001546 # Change to the presubmit file's directory to support local imports.
1547 main_path = os.getcwd()
Saagar Sanghavi98b332f2020-07-31 17:19:15 +00001548 presubmit_dir = os.path.dirname(presubmit_path)
1549 os.chdir(presubmit_dir)
chase@chromium.org8e416c82009-10-06 04:30:44 +00001550
1551 # Load the presubmit script into context.
dpranke@chromium.org970c5222011-03-12 00:32:24 +00001552 input_api = InputApi(self.change, presubmit_path, self.committing,
Aaron Gable668c1d82018-04-03 10:19:16 -07001553 self.verbose, gerrit_obj=self.gerrit,
Edward Lesmes8e282792018-04-03 18:50:29 -04001554 dry_run=self.dry_run, thread_pool=self.thread_pool,
Bruce Dawson09c0c072022-05-26 20:28:58 +00001555 parallel=self.parallel, no_diffs=self.no_diffs)
Daniel Cheng7227d212017-11-17 08:12:37 -08001556 output_api = OutputApi(self.committing)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001557 context = {}
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001558
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001559 try:
Bruce Dawson0ba2fd42022-07-21 13:47:21 +00001560 exec(compile(script_text, presubmit_path, 'exec', dont_inherit=True),
Raul Tambre09e64b42019-05-14 01:57:22 +00001561 context)
Raul Tambre7c938462019-05-24 16:35:35 +00001562 except Exception as e:
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001563 raise PresubmitFailure('"%s" had an exception.\n%s' % (presubmit_path, e))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001564
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001565 context['__args'] = (input_api, output_api)
Ben Pastene8351dc12020-08-06 05:01:35 +00001566
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001567 # Get path of presubmit directory relative to repository root.
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001568 # Always use forward slashes, so that path is same in *nix and Windows
1569 root = input_api.change.RepositoryRoot()
1570 rel_path = os.path.relpath(presubmit_dir, root)
1571 rel_path = rel_path.replace(os.path.sep, '/')
Ben Pastene8351dc12020-08-06 05:01:35 +00001572
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001573 # Get the URL of git remote origin and use it to identify host and project
Edward Lesmeseb1bd622021-03-01 19:54:07 +00001574 host = project = ''
1575 if self.gerrit:
1576 host = self.gerrit.host or ''
1577 project = self.gerrit.project or ''
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001578
1579 # Prefix for test names
1580 prefix = 'presubmit:%s/%s:%s/' % (host, project, rel_path)
1581
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001582 # Perform all the desired presubmit checks.
1583 results = []
Ben Pastene8351dc12020-08-06 05:01:35 +00001584
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001585 try:
Scott Leecc2fe9b2020-11-19 19:38:06 +00001586 version = [
1587 int(x) for x in context.get('PRESUBMIT_VERSION', '0.0.0').split('.')
1588 ]
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001589
Scott Leecc2fe9b2020-11-19 19:38:06 +00001590 with rdb_wrapper.client(prefix) as sink:
1591 if version >= [2, 0, 0]:
Andrew Grievebdfb8f22022-02-02 21:56:47 +00001592 # Copy the keys to prevent "dictionary changed size during iteration"
1593 # exception if checks add globals to context. E.g. sometimes the
1594 # Python runtime will add __warningregistry__.
1595 for function_name in list(context.keys()):
Scott Leecc2fe9b2020-11-19 19:38:06 +00001596 if not function_name.startswith('Check'):
1597 continue
1598 if function_name.endswith('Commit') and not self.committing:
1599 continue
1600 if function_name.endswith('Upload') and self.committing:
1601 continue
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001602 logging.debug('Running %s in %s', function_name, presubmit_path)
1603 results.extend(
Bruce Dawson8fa42e22022-03-29 17:05:38 +00001604 self._run_check_function(function_name, context, sink,
1605 presubmit_path))
Scott Leecc2fe9b2020-11-19 19:38:06 +00001606 logging.debug('Running %s done.', function_name)
1607 self.more_cc.extend(output_api.more_cc)
1608
1609 else: # Old format
1610 if self.committing:
1611 function_name = 'CheckChangeOnCommit'
1612 else:
1613 function_name = 'CheckChangeOnUpload'
Andrew Grievebdfb8f22022-02-02 21:56:47 +00001614 if function_name in list(context.keys()):
Scott Leecc2fe9b2020-11-19 19:38:06 +00001615 logging.debug('Running %s in %s', function_name, presubmit_path)
1616 results.extend(
Bruce Dawson8fa42e22022-03-29 17:05:38 +00001617 self._run_check_function(function_name, context, sink,
1618 presubmit_path))
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001619 logging.debug('Running %s done.', function_name)
1620 self.more_cc.extend(output_api.more_cc)
1621
1622 finally:
1623 for f in input_api._named_temporary_files:
1624 os.remove(f)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001625
chase@chromium.org8e416c82009-10-06 04:30:44 +00001626 # Return the process to the original working directory.
1627 os.chdir(main_path)
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001628 return results
1629
Bruce Dawson8fa42e22022-03-29 17:05:38 +00001630 def _run_check_function(self, function_name, context, sink, presubmit_path):
Scott Leecc2fe9b2020-11-19 19:38:06 +00001631 """Evaluates and returns the result of a given presubmit function.
1632
1633 If sink is given, the result of the presubmit function will be reported
1634 to the ResultSink.
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001635
1636 Args:
Scott Leecc2fe9b2020-11-19 19:38:06 +00001637 function_name: the name of the presubmit function to evaluate
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001638 context: a context dictionary in which the function will be evaluated
Scott Leecc2fe9b2020-11-19 19:38:06 +00001639 sink: an instance of ResultSink. None, by default.
1640 Returns:
1641 the result of the presubmit function call.
1642 """
1643 start_time = time_time()
1644 try:
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001645 result = eval(function_name + '(*__args)', context)
1646 self._check_result_type(result)
Allen Webbfe7d7092021-05-18 02:05:49 +00001647 except Exception:
Bruce Dawson10a82862022-05-27 19:25:56 +00001648 _, e_value, _ = sys.exc_info()
1649 result = [
1650 OutputApi.PresubmitError(
1651 'Evaluation of %s failed: %s, %s' %
1652 (function_name, e_value, traceback.format_exc()))
1653 ]
Scott Leecc2fe9b2020-11-19 19:38:06 +00001654
Bruce Dawson2bdc49f2021-05-21 19:13:03 +00001655 elapsed_time = time_time() - start_time
1656 if elapsed_time > 10.0:
Bruce Dawson6757d462022-07-13 04:04:40 +00001657 sys.stdout.write('%6.1fs to run %s from %s.\n' %
1658 (elapsed_time, function_name, presubmit_path))
Scott Leecc2fe9b2020-11-19 19:38:06 +00001659 if sink:
Scott Leecc2fe9b2020-11-19 19:38:06 +00001660 status = rdb_wrapper.STATUS_PASS
1661 if any(r.fatal for r in result):
1662 status = rdb_wrapper.STATUS_FAIL
1663 sink.report(function_name, status, elapsed_time)
1664
1665 return result
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001666
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00001667 def _check_result_type(self, result):
1668 """Helper function which ensures result is a list, and all elements are
1669 instances of OutputApi.PresubmitResult"""
1670 if not isinstance(result, (tuple, list)):
1671 raise PresubmitFailure('Presubmit functions must return a tuple or list')
1672 if not all(isinstance(res, OutputApi.PresubmitResult) for res in result):
1673 raise PresubmitFailure(
1674 'All presubmit results must be of types derived from '
1675 'output_api.PresubmitResult')
1676
1677
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001678def DoPresubmitChecks(change,
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001679 committing,
1680 verbose,
maruel@chromium.orgb0dfd352009-06-10 14:12:54 +00001681 default_presubmit,
dpranke@chromium.org970c5222011-03-12 00:32:24 +00001682 may_prompt,
Aaron Gable668c1d82018-04-03 10:19:16 -07001683 gerrit_obj,
Edward Lesmes8e282792018-04-03 18:50:29 -04001684 dry_run=None,
Debrian Figueroadd2737e2019-06-21 23:50:13 +00001685 parallel=False,
Dirk Pranke6f0df682021-06-25 00:42:33 +00001686 json_output=None,
Bruce Dawson09c0c072022-05-26 20:28:58 +00001687 use_python3=False,
1688 no_diffs=False):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001689 """Runs all presubmit checks that apply to the files in the change.
1690
1691 This finds all PRESUBMIT.py files in directories enclosing the files in the
1692 change (up to the repository root) and calls the relevant entrypoint function
1693 depending on whether the change is being committed or uploaded.
1694
1695 Prints errors, warnings and notifications. Prompts the user for warnings
1696 when needed.
1697
1698 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001699 change: The Change object.
agable92bec4f2016-08-24 09:27:27 -07001700 committing: True if 'git cl land' is running, False if 'git cl upload' is.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001701 verbose: Prints debug info.
maruel@chromium.org0ff1fab2009-05-22 13:08:15 +00001702 default_presubmit: A default presubmit script to execute in any case.
Quinten Yearsley516fe7f2016-12-14 11:50:18 -08001703 may_prompt: Enable (y/n) questions on warning or error. If False,
1704 any questions are answered with yes by default.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001705 gerrit_obj: provides basic Gerrit codereview functionality.
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001706 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -04001707 parallel: if true, all tests specified by input_api.RunTests in all
1708 PRESUBMIT files will be run in parallel.
Dirk Pranke6f0df682021-06-25 00:42:33 +00001709 use_python3: if true, default to using Python3 for presubmit checks
1710 rather than Python2.
Bruce Dawson09c0c072022-05-26 20:28:58 +00001711 no_diffs: if true, implies that --files or --all was specified so some
1712 checks can be skipped, and some errors will be messages.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001713 Return:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001714 1 if presubmit checks failed or 0 otherwise.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001715 """
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001716 old_environ = os.environ
1717 try:
1718 # Make sure python subprocesses won't generate .pyc files.
1719 os.environ = os.environ.copy()
Edward Lemurb9830242019-10-30 22:19:20 +00001720 os.environ['PYTHONDONTWRITEBYTECODE'] = '1'
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001721
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001722 python_version = 'Python %s' % sys.version_info.major
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001723 if committing:
Dirk Pranke6fc394f2021-05-26 23:25:14 +00001724 sys.stdout.write('Running %s presubmit commit checks ...\n' %
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001725 python_version)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001726 else:
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001727 sys.stdout.write('Running %s presubmit upload checks ...\n' %
1728 python_version)
Edward Lemurecc27072020-01-06 16:42:34 +00001729 start_time = time_time()
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001730 presubmit_files = ListRelevantPresubmitFiles(
agable0b65e732016-11-22 09:25:46 -08001731 change.AbsoluteLocalPaths(), change.RepositoryRoot())
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001732 if not presubmit_files and verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001733 sys.stdout.write('Warning, no PRESUBMIT.py found.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001734 results = []
Bruce Dawsonf2b04212022-06-10 16:42:54 +00001735 depot_tools = os.path.dirname(os.path.abspath(__file__))
1736 python2_usage_log_file = os.path.join(depot_tools, 'python2_usage.txt')
1737 if os.path.exists(python2_usage_log_file):
1738 os.remove(python2_usage_log_file)
Edward Lesmes8e282792018-04-03 18:50:29 -04001739 thread_pool = ThreadPool()
Edward Lemur7e3c67f2018-07-20 20:52:49 +00001740 executer = PresubmitExecuter(change, committing, verbose, gerrit_obj,
Bruce Dawson09c0c072022-05-26 20:28:58 +00001741 dry_run, thread_pool, parallel, use_python3,
1742 no_diffs)
Josip Sokcevic632bbc02022-05-19 05:32:50 +00001743 skipped_count = 0;
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001744 if default_presubmit:
1745 if verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001746 sys.stdout.write('Running default presubmit script.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001747 fake_path = os.path.join(change.RepositoryRoot(), 'PRESUBMIT.py')
Josip Sokcevic632bbc02022-05-19 05:32:50 +00001748 if _ShouldRunPresubmit(default_presubmit, use_python3):
1749 results += executer.ExecPresubmitScript(default_presubmit, fake_path)
1750 else:
1751 skipped_count += 1
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001752 for filename in presubmit_files:
1753 filename = os.path.abspath(filename)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001754 # Accept CRLF presubmit script.
Bruce Dawson6e70e862022-07-01 19:37:01 +00001755 presubmit_script = gclient_utils.FileRead(filename).replace('\r\n', '\n')
Josip Sokcevic632bbc02022-05-19 05:32:50 +00001756 if _ShouldRunPresubmit(presubmit_script, use_python3):
Bruce Dawson8d78bd12022-08-12 19:17:03 +00001757 if sys.version_info[0] == 2:
Bruce Dawson443f9852022-09-08 17:30:59 +00001758 sys.stdout.write(
1759 'Running %s under Python 2. Add USE_PYTHON3 = True to prevent '
1760 'this.\n' % filename)
Bruce Dawson8d78bd12022-08-12 19:17:03 +00001761 elif verbose:
1762 sys.stdout.write('Running %s\n' % filename)
Josip Sokcevic632bbc02022-05-19 05:32:50 +00001763 results += executer.ExecPresubmitScript(presubmit_script, filename)
1764 else:
1765 skipped_count += 1
Bruce Dawson76fe1a72022-05-25 20:52:21 +00001766
Edward Lesmes8e282792018-04-03 18:50:29 -04001767 results += thread_pool.RunAsync()
1768
Bruce Dawsonf2b04212022-06-10 16:42:54 +00001769 if os.path.exists(python2_usage_log_file):
1770 with open(python2_usage_log_file) as f:
1771 python2_usage = [x.strip() for x in f.readlines()]
1772 results.append(
1773 OutputApi(committing).PresubmitPromptWarning(
1774 'Python 2 scripts were run during %s presubmits. Please see '
1775 'https://bugs.chromium.org/p/chromium/issues/detail?id=1313804'
1776 '#c61 for tips on resolving this.'
1777 % python_version,
1778 items=python2_usage))
1779
Edward Lemur6eb1d322020-02-27 22:20:15 +00001780 messages = {}
1781 should_prompt = False
1782 presubmits_failed = False
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001783 for result in results:
1784 if result.fatal:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001785 presubmits_failed = True
1786 messages.setdefault('ERRORS', []).append(result)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001787 elif result.should_prompt:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001788 should_prompt = True
1789 messages.setdefault('Warnings', []).append(result)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001790 else:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001791 messages.setdefault('Messages', []).append(result)
pam@chromium.orged9a0832009-09-09 22:48:55 +00001792
Bruce Dawson76fe1a72022-05-25 20:52:21 +00001793 # Print the different message types in a consistent order. ERRORS go last
1794 # so that they will be most visible in the local-presubmit output.
1795 for name in ['Messages', 'Warnings', 'ERRORS']:
1796 if name in messages:
1797 items = messages[name]
Gavin Makd22bf602022-07-11 21:10:41 +00001798 sys.stdout.write('** Presubmit %s: %d **\n' % (name, len(items)))
Bruce Dawson76fe1a72022-05-25 20:52:21 +00001799 for item in items:
1800 item.handle()
1801 sys.stdout.write('\n')
pam@chromium.orged9a0832009-09-09 22:48:55 +00001802
Edward Lemurecc27072020-01-06 16:42:34 +00001803 total_time = time_time() - start_time
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001804 if total_time > 1.0:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001805 sys.stdout.write(
Louis Romero4ca9e1c2022-03-10 10:29:11 +00001806 'Presubmit checks took %.1fs to calculate.\n' % total_time)
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +00001807
Edward Lemur6eb1d322020-02-27 22:20:15 +00001808 if not should_prompt and not presubmits_failed:
Louis Romero4ca9e1c2022-03-10 10:29:11 +00001809 sys.stdout.write('%s presubmit checks passed.\n\n' % python_version)
Josip Sokcevic7592e0a2022-01-12 00:57:54 +00001810 elif should_prompt and not presubmits_failed:
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001811 sys.stdout.write('There were %s presubmit warnings. ' % python_version)
Quinten Yearsley516fe7f2016-12-14 11:50:18 -08001812 if may_prompt:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001813 presubmits_failed = not prompt_should_continue(
1814 'Are you sure you wish to continue? (y/N): ')
Garrett Beatyacb807e2020-08-28 18:17:24 +00001815 else:
1816 sys.stdout.write('\n')
Bruce Dawson76fe1a72022-05-25 20:52:21 +00001817 else:
1818 sys.stdout.write('There were %s presubmit errors.\n' % python_version)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001819
Edward Lemur1dc66e12020-02-21 21:36:34 +00001820 if json_output:
1821 # Write the presubmit results to json output
1822 presubmit_results = {
1823 'errors': [
Edward Lemur6eb1d322020-02-27 22:20:15 +00001824 error.json_format()
1825 for error in messages.get('ERRORS', [])
Edward Lemur1dc66e12020-02-21 21:36:34 +00001826 ],
1827 'notifications': [
Edward Lemur6eb1d322020-02-27 22:20:15 +00001828 notification.json_format()
1829 for notification in messages.get('Messages', [])
Edward Lemur1dc66e12020-02-21 21:36:34 +00001830 ],
1831 'warnings': [
Edward Lemur6eb1d322020-02-27 22:20:15 +00001832 warning.json_format()
1833 for warning in messages.get('Warnings', [])
Edward Lemur1dc66e12020-02-21 21:36:34 +00001834 ],
Edward Lemur6eb1d322020-02-27 22:20:15 +00001835 'more_cc': executer.more_cc,
Josip Sokcevic632bbc02022-05-19 05:32:50 +00001836 'skipped_presubmits': skipped_count,
Edward Lemur1dc66e12020-02-21 21:36:34 +00001837 }
1838
1839 gclient_utils.FileWrite(
1840 json_output, json.dumps(presubmit_results, sort_keys=True))
1841
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001842 global _ASKED_FOR_FEEDBACK
1843 # Ask for feedback one time out of 5.
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +00001844 if (results and random.randint(0, 4) == 0 and not _ASKED_FOR_FEEDBACK):
Edward Lemur6eb1d322020-02-27 22:20:15 +00001845 sys.stdout.write(
maruel@chromium.org1ce8e662014-01-14 15:23:00 +00001846 'Was the presubmit check useful? If not, run "git cl presubmit -v"\n'
1847 'to figure out which PRESUBMIT.py was run, then run git blame\n'
1848 'on the file to figure out who to ask for help.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001849 _ASKED_FOR_FEEDBACK = True
Edward Lemur6eb1d322020-02-27 22:20:15 +00001850
1851 return 1 if presubmits_failed else 0
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001852 finally:
1853 os.environ = old_environ
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001854
1855
Edward Lemur50984a62020-02-06 18:10:18 +00001856def _scan_sub_dirs(mask, recursive):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001857 if not recursive:
pgervais@chromium.orge57b09d2014-05-07 00:58:13 +00001858 return [x for x in glob.glob(mask) if x not in ('.svn', '.git')]
Lei Zhang9611c4c2017-04-04 01:41:56 -07001859
1860 results = []
1861 for root, dirs, files in os.walk('.'):
1862 if '.svn' in dirs:
1863 dirs.remove('.svn')
1864 if '.git' in dirs:
1865 dirs.remove('.git')
1866 for name in files:
1867 if fnmatch.fnmatch(name, mask):
1868 results.append(os.path.join(root, name))
1869 return results
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001870
1871
Edward Lemur50984a62020-02-06 18:10:18 +00001872def _parse_files(args, recursive):
tobiasjs2836bcf2016-08-16 04:08:16 -07001873 logging.debug('Searching for %s', args)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001874 files = []
1875 for arg in args:
Edward Lemur50984a62020-02-06 18:10:18 +00001876 files.extend([('M', f) for f in _scan_sub_dirs(arg, recursive)])
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001877 return files
1878
1879
Edward Lemur50984a62020-02-06 18:10:18 +00001880def _parse_change(parser, options):
1881 """Process change options.
1882
1883 Args:
1884 parser: The parser used to parse the arguments from command line.
1885 options: The arguments parsed from command line.
1886 Returns:
1887 A GitChange if the change root is a git repository, or a Change otherwise.
1888 """
1889 if options.files and options.all_files:
1890 parser.error('<files> cannot be specified when --all-files is set.')
1891
Edward Lesmes44ea3ff2020-02-05 00:14:30 +00001892 change_scm = scm.determine_scm(options.root)
Edward Lemur50984a62020-02-06 18:10:18 +00001893 if change_scm != 'git' and not options.files:
1894 parser.error('<files> is not optional for unversioned directories.')
1895
1896 if options.files:
Josip Sokcevic017544d2022-03-31 23:47:53 +00001897 if options.source_controlled_only:
1898 # Get the filtered set of files from SCM.
1899 change_files = []
1900 for name in scm.GIT.GetAllFiles(options.root):
1901 for mask in options.files:
1902 if fnmatch.fnmatch(name, mask):
1903 change_files.append(('M', name))
1904 break
1905 else:
1906 # Get the filtered set of files from a directory scan.
1907 change_files = _parse_files(options.files, options.recursive)
Edward Lemur50984a62020-02-06 18:10:18 +00001908 elif options.all_files:
1909 change_files = [('M', f) for f in scm.GIT.GetAllFiles(options.root)]
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001910 else:
Edward Lemur50984a62020-02-06 18:10:18 +00001911 change_files = scm.GIT.CaptureStatus(
Edward Lemur7f6dec02020-02-06 20:23:58 +00001912 options.root, options.upstream or None)
Edward Lemur50984a62020-02-06 18:10:18 +00001913
1914 logging.info('Found %d file(s).', len(change_files))
1915
1916 change_class = GitChange if change_scm == 'git' else Change
1917 return change_class(
1918 options.name,
1919 options.description,
1920 options.root,
1921 change_files,
1922 options.issue,
1923 options.patchset,
1924 options.author,
1925 upstream=options.upstream)
1926
1927
1928def _parse_gerrit_options(parser, options):
1929 """Process gerrit options.
1930
1931 SIDE EFFECTS: Modifies options.author and options.description from Gerrit if
1932 options.gerrit_fetch is set.
1933
1934 Args:
1935 parser: The parser used to parse the arguments from command line.
1936 options: The arguments parsed from command line.
1937 Returns:
Stephen Martinisfb09de22021-02-25 03:41:13 +00001938 A GerritAccessor object if options.gerrit_url is set, or None otherwise.
Edward Lemur50984a62020-02-06 18:10:18 +00001939 """
1940 gerrit_obj = None
Stephen Martinisfb09de22021-02-25 03:41:13 +00001941 if options.gerrit_url:
Edward Lesmeseb1bd622021-03-01 19:54:07 +00001942 gerrit_obj = GerritAccessor(
1943 url=options.gerrit_url,
1944 project=options.gerrit_project,
1945 branch=options.gerrit_branch)
Edward Lemur50984a62020-02-06 18:10:18 +00001946
1947 if not options.gerrit_fetch:
1948 return gerrit_obj
1949
1950 if not options.gerrit_url or not options.issue or not options.patchset:
1951 parser.error(
1952 '--gerrit_fetch requires --gerrit_url, --issue and --patchset.')
1953
1954 options.author = gerrit_obj.GetChangeOwner(options.issue)
1955 options.description = gerrit_obj.GetChangeDescription(
1956 options.issue, options.patchset)
1957
1958 logging.info('Got author: "%s"', options.author)
1959 logging.info('Got description: """\n%s\n"""', options.description)
1960
1961 return gerrit_obj
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001962
1963
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001964@contextlib.contextmanager
1965def canned_check_filter(method_names):
1966 filtered = {}
1967 try:
1968 for method_name in method_names:
1969 if not hasattr(presubmit_canned_checks, method_name):
Gavin Make6a62332020-12-04 21:57:10 +00001970 logging.warning('Skipping unknown "canned" check %s' % method_name)
Aaron Gableecee74c2018-04-02 15:13:08 -07001971 continue
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001972 filtered[method_name] = getattr(presubmit_canned_checks, method_name)
1973 setattr(presubmit_canned_checks, method_name, lambda *_a, **_kw: [])
1974 yield
1975 finally:
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001976 for name, method in filtered.items():
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001977 setattr(presubmit_canned_checks, name, method)
1978
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +00001979
sbc@chromium.org013731e2015-02-26 18:28:43 +00001980def main(argv=None):
Edward Lemura5799e32020-01-17 19:26:51 +00001981 parser = argparse.ArgumentParser(usage='%(prog)s [options] <files...>')
1982 hooks = parser.add_mutually_exclusive_group()
1983 hooks.add_argument('-c', '--commit', action='store_true',
1984 help='Use commit instead of upload checks.')
1985 hooks.add_argument('-u', '--upload', action='store_false', dest='commit',
1986 help='Use upload instead of commit checks.')
Edward Lemur75526302020-02-27 22:31:05 +00001987 hooks.add_argument('--post_upload', action='store_true',
1988 help='Run post-upload commit hooks.')
Edward Lemura5799e32020-01-17 19:26:51 +00001989 parser.add_argument('-r', '--recursive', action='store_true',
1990 help='Act recursively.')
1991 parser.add_argument('-v', '--verbose', action='count', default=0,
1992 help='Use 2 times for more debug info.')
1993 parser.add_argument('--name', default='no name')
1994 parser.add_argument('--author')
Edward Lemur227d5102020-02-25 23:45:35 +00001995 desc = parser.add_mutually_exclusive_group()
1996 desc.add_argument('--description', default='', help='The change description.')
1997 desc.add_argument('--description_file',
1998 help='File to read change description from.')
Edward Lemura5799e32020-01-17 19:26:51 +00001999 parser.add_argument('--issue', type=int, default=0)
2000 parser.add_argument('--patchset', type=int, default=0)
2001 parser.add_argument('--root', default=os.getcwd(),
2002 help='Search for PRESUBMIT.py up to this directory. '
2003 'If inherit-review-settings-ok is present in this '
2004 'directory, parent directories up to the root file '
2005 'system directories will also be searched.')
2006 parser.add_argument('--upstream',
2007 help='Git only: the base ref or upstream branch against '
2008 'which the diff should be computed.')
2009 parser.add_argument('--default_presubmit')
2010 parser.add_argument('--may_prompt', action='store_true', default=False)
2011 parser.add_argument('--skip_canned', action='append', default=[],
2012 help='A list of checks to skip which appear in '
2013 'presubmit_canned_checks. Can be provided multiple times '
2014 'to skip multiple canned checks.')
2015 parser.add_argument('--dry_run', action='store_true', help=argparse.SUPPRESS)
2016 parser.add_argument('--gerrit_url', help=argparse.SUPPRESS)
Edward Lesmeseb1bd622021-03-01 19:54:07 +00002017 parser.add_argument('--gerrit_project', help=argparse.SUPPRESS)
2018 parser.add_argument('--gerrit_branch', help=argparse.SUPPRESS)
Edward Lemura5799e32020-01-17 19:26:51 +00002019 parser.add_argument('--gerrit_fetch', action='store_true',
2020 help=argparse.SUPPRESS)
2021 parser.add_argument('--parallel', action='store_true',
2022 help='Run all tests specified by input_api.RunTests in '
2023 'all PRESUBMIT files in parallel.')
2024 parser.add_argument('--json_output',
2025 help='Write presubmit errors to json output.')
Edward Lemur1dc66e12020-02-21 21:36:34 +00002026 parser.add_argument('--all_files', action='store_true',
Edward Lemur50984a62020-02-06 18:10:18 +00002027 help='Mark all files under source control as modified.')
Bruce Dawson09c0c072022-05-26 20:28:58 +00002028
Edward Lemura5799e32020-01-17 19:26:51 +00002029 parser.add_argument('files', nargs='*',
2030 help='List of files to be marked as modified when '
2031 'executing presubmit or post-upload hooks. fnmatch '
2032 'wildcards can also be used.')
Josip Sokcevic017544d2022-03-31 23:47:53 +00002033 parser.add_argument('--source_controlled_only', action='store_true',
2034 help='Constrain \'files\' to those in source control.')
Dirk Pranke6f0df682021-06-25 00:42:33 +00002035 parser.add_argument('--use-python3', action='store_true',
2036 help='Use python3 for presubmit checks by default')
Bruce Dawson09c0c072022-05-26 20:28:58 +00002037 parser.add_argument('--no_diffs', action='store_true',
2038 help='Assume that all "modified" files have no diffs.')
Edward Lemura5799e32020-01-17 19:26:51 +00002039 options = parser.parse_args(argv)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00002040
Erik Staabcca5c492020-04-16 17:40:07 +00002041 log_level = logging.ERROR
maruel@chromium.org899e1c12011-04-07 17:03:18 +00002042 if options.verbose >= 2:
Erik Staabcca5c492020-04-16 17:40:07 +00002043 log_level = logging.DEBUG
maruel@chromium.org899e1c12011-04-07 17:03:18 +00002044 elif options.verbose:
Erik Staabcca5c492020-04-16 17:40:07 +00002045 log_level = logging.INFO
2046 log_format = ('[%(levelname).1s%(asctime)s %(process)d %(thread)d '
2047 '%(filename)s] %(message)s')
2048 logging.basicConfig(format=log_format, level=log_level)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00002049
Edward Lemur227d5102020-02-25 23:45:35 +00002050 if options.description_file:
2051 options.description = gclient_utils.FileRead(options.description_file)
Edward Lemur50984a62020-02-06 18:10:18 +00002052 gerrit_obj = _parse_gerrit_options(parser, options)
2053 change = _parse_change(parser, options)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00002054
maruel@chromium.org899e1c12011-04-07 17:03:18 +00002055 try:
Edward Lemur75526302020-02-27 22:31:05 +00002056 if options.post_upload:
Josip Sokcevice293d3d2022-02-16 22:52:15 +00002057 return DoPostUploadExecuter(change, gerrit_obj, options.verbose,
2058 options.use_python3)
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00002059 with canned_check_filter(options.skip_canned):
Edward Lemur6eb1d322020-02-27 22:20:15 +00002060 return DoPresubmitChecks(
Edward Lemur50984a62020-02-06 18:10:18 +00002061 change,
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00002062 options.commit,
2063 options.verbose,
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00002064 options.default_presubmit,
2065 options.may_prompt,
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00002066 gerrit_obj,
Edward Lesmes8e282792018-04-03 18:50:29 -04002067 options.dry_run,
Debrian Figueroadd2737e2019-06-21 23:50:13 +00002068 options.parallel,
Dirk Pranke6f0df682021-06-25 00:42:33 +00002069 options.json_output,
Bruce Dawson09c0c072022-05-26 20:28:58 +00002070 options.use_python3,
2071 options.no_diffs)
Raul Tambre7c938462019-05-24 16:35:35 +00002072 except PresubmitFailure as e:
Josip Sokcevic0399e172022-03-21 23:11:51 +00002073 import utils
Raul Tambre80ee78e2019-05-06 22:41:05 +00002074 print(e, file=sys.stderr)
2075 print('Maybe your depot_tools is out of date?', file=sys.stderr)
Josip Sokcevic0399e172022-03-21 23:11:51 +00002076 print('depot_tools version: %s' % utils.depot_tools_version(),
2077 file=sys.stderr)
maruel@chromium.org899e1c12011-04-07 17:03:18 +00002078 return 2
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00002079
2080
2081if __name__ == '__main__':
maruel@chromium.org35625c72011-03-23 17:34:02 +00002082 fix_encoding.fix_encoding()
sbc@chromium.org013731e2015-02-26 18:28:43 +00002083 try:
2084 sys.exit(main())
2085 except KeyboardInterrupt:
2086 sys.stderr.write('interrupted\n')
sergiybf8a3b382016-07-05 11:21:30 -07002087 sys.exit(2)