blob: 887783fca70f232ba81c6538cd5827a7dece7e49 [file] [log] [blame]
maruel@chromium.orgddd59412011-11-30 14:20:38 +00001#!/usr/bin/env python
maruel@chromium.orgeb5edbc2012-01-16 17:03:28 +00002# Copyright (c) 2012 The Chromium Authors. All rights reserved.
maruel@chromium.orgddd59412011-11-30 14:20:38 +00003# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5
6"""Unit tests for git_cl.py."""
7
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01008import datetime
tandriide281ae2016-10-12 06:02:30 -07009import json
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +010010import logging
maruel@chromium.orgddd59412011-11-30 14:20:38 +000011import os
Brian Sheedy59b06a82019-10-14 17:03:29 +000012import shutil
maruel@chromium.orga3353652011-11-30 14:26:57 +000013import StringIO
maruel@chromium.orgddd59412011-11-30 14:20:38 +000014import sys
Aaron Gable9a03ae02017-11-03 11:31:07 -070015import tempfile
maruel@chromium.orgddd59412011-11-30 14:20:38 +000016import unittest
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +000017import urlparse
maruel@chromium.orgddd59412011-11-30 14:20:38 +000018
19sys.path.insert(0, os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
20
21from testing_support.auto_stub import TestCase
Edward Lemur4c707a22019-09-24 21:13:43 +000022from third_party import mock
maruel@chromium.orgddd59412011-11-30 14:20:38 +000023
Edward Lemur5ba1e9c2018-07-23 18:19:02 +000024import metrics
25# We have to disable monitoring before importing git_cl.
26metrics.DISABLE_METRICS_COLLECTION = True
27
Eric Boren2fb63102018-10-05 13:05:03 +000028import gerrit_util
maruel@chromium.orgddd59412011-11-30 14:20:38 +000029import git_cl
iannucci@chromium.org9e849272014-04-04 00:31:55 +000030import git_common
tandrii@chromium.org57d86542016-03-04 16:11:32 +000031import git_footers
maruel@chromium.orgddd59412011-11-30 14:20:38 +000032import subprocess2
maruel@chromium.orgddd59412011-11-30 14:20:38 +000033
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +000034
tandrii5d48c322016-08-18 16:19:37 -070035def callError(code=1, cmd='', cwd='', stdout='', stderr=''):
36 return subprocess2.CalledProcessError(code, cmd, cwd, stdout, stderr)
37
38
Edward Lemur4c707a22019-09-24 21:13:43 +000039def _constantFn(return_value):
40 def f(*args, **kwargs):
41 return return_value
42 return f
43
44
tandrii5d48c322016-08-18 16:19:37 -070045CERR1 = callError(1)
46
47
Aaron Gable9a03ae02017-11-03 11:31:07 -070048def MakeNamedTemporaryFileMock(expected_content):
49 class NamedTemporaryFileMock(object):
50 def __init__(self, *args, **kwargs):
51 self.name = '/tmp/named'
52 self.expected_content = expected_content
53
54 def __enter__(self):
55 return self
56
57 def __exit__(self, _type, _value, _tb):
58 pass
59
60 def write(self, content):
61 if self.expected_content:
62 assert content == self.expected_content
63
64 def close(self):
65 pass
66
67 return NamedTemporaryFileMock
68
69
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000070class ChangelistMock(object):
71 # A class variable so we can access it when we don't have access to the
72 # instance that's being set.
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +000073 desc = ''
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000074 def __init__(self, **kwargs):
75 pass
76 def GetIssue(self):
77 return 1
Kenneth Russell61e2ed42017-02-15 11:47:13 -080078 def GetDescription(self, force=False):
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000079 return ChangelistMock.desc
dsansomee2d6fd92016-09-08 00:10:47 -070080 def UpdateDescription(self, desc, force=False):
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000081 ChangelistMock.desc = desc
82
tandrii5d48c322016-08-18 16:19:37 -070083
maruel@chromium.org2e72bb12012-01-17 15:18:35 +000084class PresubmitMock(object):
85 def __init__(self, *args, **kwargs):
86 self.reviewers = []
Daniel Cheng7227d212017-11-17 08:12:37 -080087 self.more_cc = ['chromium-reviews+test-more-cc@chromium.org']
88
maruel@chromium.org2e72bb12012-01-17 15:18:35 +000089 @staticmethod
90 def should_continue():
91 return True
92
93
maruel@chromium.org2e72bb12012-01-17 15:18:35 +000094class WatchlistsMock(object):
95 def __init__(self, _):
96 pass
97 @staticmethod
98 def GetWatchersForPaths(_):
99 return ['joe@example.com']
100
101
Edward Lemur4c707a22019-09-24 21:13:43 +0000102class CodereviewSettingsFileMock(object):
103 def __init__(self):
104 pass
105 # pylint: disable=no-self-use
106 def read(self):
107 return ('CODE_REVIEW_SERVER: gerrit.chromium.org\n' +
108 'GERRIT_HOST: True\n')
109
110
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000111class AuthenticatorMock(object):
112 def __init__(self, *_args):
113 pass
114 def has_cached_credentials(self):
115 return True
tandrii221ab252016-10-06 08:12:04 -0700116 def authorize(self, http):
117 return http
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000118
119
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100120def CookiesAuthenticatorMockFactory(hosts_with_creds=None, same_auth=False):
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000121 """Use to mock Gerrit/Git credentials from ~/.netrc or ~/.gitcookies.
122
123 Usage:
124 >>> self.mock(git_cl.gerrit_util, "CookiesAuthenticator",
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100125 CookiesAuthenticatorMockFactory({'host': ('user', _, 'pass')})
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000126
127 OR
128 >>> self.mock(git_cl.gerrit_util, "CookiesAuthenticator",
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100129 CookiesAuthenticatorMockFactory(
130 same_auth=('user', '', 'pass'))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000131 """
132 class CookiesAuthenticatorMock(git_cl.gerrit_util.CookiesAuthenticator):
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800133 def __init__(self): # pylint: disable=super-init-not-called
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000134 # Intentionally not calling super() because it reads actual cookie files.
135 pass
136 @classmethod
137 def get_gitcookies_path(cls):
138 return '~/.gitcookies'
139 @classmethod
140 def get_netrc_path(cls):
141 return '~/.netrc'
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100142 def _get_auth_for_host(self, host):
143 if same_auth:
144 return same_auth
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000145 return (hosts_with_creds or {}).get(host)
146 return CookiesAuthenticatorMock
147
Aaron Gable9a03ae02017-11-03 11:31:07 -0700148
kmarshall9249e012016-08-23 12:02:16 -0700149class MockChangelistWithBranchAndIssue():
150 def __init__(self, branch, issue):
151 self.branch = branch
152 self.issue = issue
153 def GetBranch(self):
154 return self.branch
155 def GetIssue(self):
156 return self.issue
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000157
tandriic2405f52016-10-10 08:13:15 -0700158
159class SystemExitMock(Exception):
160 pass
161
162
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000163class TestGitClBasic(unittest.TestCase):
Andrii Shyshkalov31863012017-02-08 11:35:12 +0100164 def test_get_description(self):
Edward Lemurf38bc172019-09-03 21:02:13 +0000165 cl = git_cl.Changelist(issue=1, codereview_host='host')
Andrii Shyshkalov31863012017-02-08 11:35:12 +0100166 cl.description = 'x'
167 cl.has_description = True
Edward Lemur125d60a2019-09-13 18:25:41 +0000168 cl.FetchDescription = lambda *a, **kw: 'y'
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +0000169 self.assertEqual(cl.GetDescription(), 'x')
170 self.assertEqual(cl.GetDescription(force=True), 'y')
171 self.assertEqual(cl.GetDescription(), 'y')
Andrii Shyshkalov31863012017-02-08 11:35:12 +0100172
Robert Iannucci09f1f3d2017-03-28 16:54:32 -0700173 def test_description_footers(self):
Edward Lemurf38bc172019-09-03 21:02:13 +0000174 cl = git_cl.Changelist(issue=1, codereview_host='host')
Robert Iannucci09f1f3d2017-03-28 16:54:32 -0700175 cl.description = '\n'.join([
176 'This is some message',
177 '',
178 'It has some lines',
179 'and, also',
180 '',
181 'Some: Really',
182 'Awesome: Footers',
183 ])
184 cl.has_description = True
Edward Lemur125d60a2019-09-13 18:25:41 +0000185 cl.UpdateDescriptionRemote = lambda *a, **kw: 'y'
Robert Iannucci09f1f3d2017-03-28 16:54:32 -0700186 msg, footers = cl.GetDescriptionFooters()
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +0000187 self.assertEqual(
Robert Iannucci09f1f3d2017-03-28 16:54:32 -0700188 msg, ['This is some message', '', 'It has some lines', 'and, also'])
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +0000189 self.assertEqual(footers, [('Some', 'Really'), ('Awesome', 'Footers')])
Robert Iannucci09f1f3d2017-03-28 16:54:32 -0700190
191 msg.append('wut')
192 footers.append(('gnarly-dude', 'beans'))
193 cl.UpdateDescriptionFooters(msg, footers)
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +0000194 self.assertEqual(cl.GetDescription().splitlines(), [
Robert Iannucci09f1f3d2017-03-28 16:54:32 -0700195 'This is some message',
196 '',
197 'It has some lines',
198 'and, also',
199 'wut'
200 '',
201 'Some: Really',
202 'Awesome: Footers',
203 'Gnarly-Dude: beans',
204 ])
205
Andrii Shyshkalov71f0da32019-07-15 22:45:18 +0000206 def test_set_preserve_tryjobs(self):
207 d = git_cl.ChangeDescription('Simple.')
208 d.set_preserve_tryjobs()
209 self.assertEqual(d.description.splitlines(), [
210 'Simple.',
211 '',
212 'Cq-Do-Not-Cancel-Tryjobs: true',
213 ])
214 before = d.description
215 d.set_preserve_tryjobs()
216 self.assertEqual(before, d.description)
217
218 d = git_cl.ChangeDescription('\n'.join([
219 'One is enough',
220 '',
221 'Cq-Do-Not-Cancel-Tryjobs: dups not encouraged, but don\'t hurt',
222 'Change-Id: Ideadbeef',
223 ]))
224 d.set_preserve_tryjobs()
225 self.assertEqual(d.description.splitlines(), [
226 'One is enough',
227 '',
228 'Cq-Do-Not-Cancel-Tryjobs: dups not encouraged, but don\'t hurt',
229 'Change-Id: Ideadbeef',
230 'Cq-Do-Not-Cancel-Tryjobs: true',
231 ])
232
tandriif9aefb72016-07-01 09:06:51 -0700233 def test_get_bug_line_values(self):
234 f = lambda p, bugs: list(git_cl._get_bug_line_values(p, bugs))
235 self.assertEqual(f('', ''), [])
236 self.assertEqual(f('', '123,v8:456'), ['123', 'v8:456'])
237 self.assertEqual(f('v8', '456'), ['v8:456'])
238 self.assertEqual(f('v8', 'chromium:123,456'), ['v8:456', 'chromium:123'])
239 # Not nice, but not worth carying.
240 self.assertEqual(f('v8', 'chromium:123,456,v8:123'),
241 ['v8:456', 'chromium:123', 'v8:123'])
242
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100243 def _test_git_number(self, parent_msg, dest_ref, child_msg,
244 parent_hash='parenthash'):
245 desc = git_cl.ChangeDescription(child_msg)
246 desc.update_with_git_number_footers(parent_hash, parent_msg, dest_ref)
247 return desc.description
248
249 def assertEqualByLine(self, actual, expected):
250 self.assertEqual(actual.splitlines(), expected.splitlines())
251
252 def test_git_number_bad_parent(self):
253 with self.assertRaises(ValueError):
254 self._test_git_number('Parent', 'refs/heads/master', 'Child')
255
256 def test_git_number_bad_parent_footer(self):
257 with self.assertRaises(AssertionError):
258 self._test_git_number(
259 'Parent\n'
260 '\n'
261 'Cr-Commit-Position: wrong',
262 'refs/heads/master', 'Child')
263
264 def test_git_number_bad_lineage_ignored(self):
265 actual = self._test_git_number(
266 'Parent\n'
267 '\n'
268 'Cr-Commit-Position: refs/heads/master@{#1}\n'
269 'Cr-Branched-From: mustBeReal40CharHash-branch@{#pos}',
270 'refs/heads/master', 'Child')
271 self.assertEqualByLine(
272 actual,
273 'Child\n'
274 '\n'
275 'Cr-Commit-Position: refs/heads/master@{#2}\n'
276 'Cr-Branched-From: mustBeReal40CharHash-branch@{#pos}')
277
278 def test_git_number_same_branch(self):
279 actual = self._test_git_number(
280 'Parent\n'
281 '\n'
282 'Cr-Commit-Position: refs/heads/master@{#12}',
283 dest_ref='refs/heads/master',
284 child_msg='Child')
285 self.assertEqualByLine(
286 actual,
287 'Child\n'
288 '\n'
289 'Cr-Commit-Position: refs/heads/master@{#13}')
290
Andrii Shyshkalovde37c012017-07-06 21:06:50 +0200291 def test_git_number_same_branch_mixed_footers(self):
292 actual = self._test_git_number(
293 'Parent\n'
294 '\n'
295 'Cr-Commit-Position: refs/heads/master@{#12}',
296 dest_ref='refs/heads/master',
297 child_msg='Child\n'
298 '\n'
299 'Broken-by: design\n'
300 'BUG=123')
301 self.assertEqualByLine(
302 actual,
303 'Child\n'
304 '\n'
305 'Broken-by: design\n'
306 'BUG=123\n'
307 'Cr-Commit-Position: refs/heads/master@{#13}')
308
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100309 def test_git_number_same_branch_with_originals(self):
310 actual = self._test_git_number(
311 'Parent\n'
312 '\n'
313 'Cr-Commit-Position: refs/heads/master@{#12}',
314 dest_ref='refs/heads/master',
315 child_msg='Child\n'
316 '\n'
317 'Some users are smart and insert their own footers\n'
318 '\n'
319 'Cr-Whatever: value\n'
320 'Cr-Commit-Position: refs/copy/paste@{#22}')
321 self.assertEqualByLine(
322 actual,
323 'Child\n'
324 '\n'
325 'Some users are smart and insert their own footers\n'
326 '\n'
327 'Cr-Original-Whatever: value\n'
328 'Cr-Original-Commit-Position: refs/copy/paste@{#22}\n'
329 'Cr-Commit-Position: refs/heads/master@{#13}')
330
331 def test_git_number_new_branch(self):
332 actual = self._test_git_number(
333 'Parent\n'
334 '\n'
335 'Cr-Commit-Position: refs/heads/master@{#12}',
336 dest_ref='refs/heads/branch',
337 child_msg='Child')
338 self.assertEqualByLine(
339 actual,
340 'Child\n'
341 '\n'
342 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
343 'Cr-Branched-From: parenthash-refs/heads/master@{#12}')
344
345 def test_git_number_lineage(self):
346 actual = self._test_git_number(
347 'Parent\n'
348 '\n'
349 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
350 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
351 dest_ref='refs/heads/branch',
352 child_msg='Child')
353 self.assertEqualByLine(
354 actual,
355 'Child\n'
356 '\n'
357 'Cr-Commit-Position: refs/heads/branch@{#2}\n'
358 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
359
360 def test_git_number_moooooooore_lineage(self):
361 actual = self._test_git_number(
362 'Parent\n'
363 '\n'
364 'Cr-Commit-Position: refs/heads/branch@{#5}\n'
365 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
366 dest_ref='refs/heads/mooore',
367 child_msg='Child')
368 self.assertEqualByLine(
369 actual,
370 'Child\n'
371 '\n'
372 'Cr-Commit-Position: refs/heads/mooore@{#1}\n'
373 'Cr-Branched-From: parenthash-refs/heads/branch@{#5}\n'
374 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
375
Andrii Shyshkalovb5effa12016-12-14 19:35:12 +0100376 def test_git_number_ever_moooooooore_lineage(self):
Robert Iannucci456b0d62018-03-13 19:15:50 -0700377 self.maxDiff = 10000 # pylint: disable=attribute-defined-outside-init
Andrii Shyshkalovb5effa12016-12-14 19:35:12 +0100378 actual = self._test_git_number(
379 'CQ commit on fresh new branch + numbering.\n'
380 '\n'
381 'NOTRY=True\n'
382 'NOPRESUBMIT=True\n'
383 'BUG=\n'
384 '\n'
385 'Review-Url: https://codereview.chromium.org/2577703003\n'
386 'Cr-Commit-Position: refs/heads/gnumb-test/br@{#1}\n'
387 'Cr-Branched-From: 0749ff9edc-refs/heads/gnumb-test/cq@{#4}\n'
388 'Cr-Branched-From: 5c49df2da6-refs/heads/master@{#41618}',
389 dest_ref='refs/heads/gnumb-test/cl',
390 child_msg='git cl on fresh new branch + numbering.\n'
391 '\n'
392 'Review-Url: https://codereview.chromium.org/2575043003 .\n')
393 self.assertEqualByLine(
394 actual,
395 'git cl on fresh new branch + numbering.\n'
396 '\n'
397 'Review-Url: https://codereview.chromium.org/2575043003 .\n'
398 'Cr-Commit-Position: refs/heads/gnumb-test/cl@{#1}\n'
399 'Cr-Branched-From: parenthash-refs/heads/gnumb-test/br@{#1}\n'
400 'Cr-Branched-From: 0749ff9edc-refs/heads/gnumb-test/cq@{#4}\n'
401 'Cr-Branched-From: 5c49df2da6-refs/heads/master@{#41618}')
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100402
403 def test_git_number_cherry_pick(self):
404 actual = self._test_git_number(
405 'Parent\n'
406 '\n'
407 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
408 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
409 dest_ref='refs/heads/branch',
410 child_msg='Child, which is cherry-pick from master\n'
411 '\n'
412 'Cr-Commit-Position: refs/heads/master@{#100}\n'
413 '(cherry picked from commit deadbeef12345678deadbeef12345678deadbeef)')
414 self.assertEqualByLine(
415 actual,
416 'Child, which is cherry-pick from master\n'
417 '\n'
418 '(cherry picked from commit deadbeef12345678deadbeef12345678deadbeef)\n'
419 '\n'
420 'Cr-Original-Commit-Position: refs/heads/master@{#100}\n'
421 'Cr-Commit-Position: refs/heads/branch@{#2}\n'
422 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
423
Andrii Shyshkalovd4c86732018-09-25 04:29:31 +0000424 def test_gerrit_mirror_hack(self):
425 cr = 'chromium-review.googlesource.com'
426 url0 = 'https://%s/a/changes/x?a=b' % cr
427 origMirrors = git_cl.gerrit_util._GERRIT_MIRROR_PREFIXES
428 try:
429 git_cl.gerrit_util._GERRIT_MIRROR_PREFIXES = ['us1', 'us2']
430 url1 = git_cl.gerrit_util._UseGerritMirror(url0, cr)
431 url2 = git_cl.gerrit_util._UseGerritMirror(url1, cr)
432 url3 = git_cl.gerrit_util._UseGerritMirror(url2, cr)
433
434 self.assertNotEqual(url1, url2)
435 self.assertEqual(sorted((url1, url2)), [
436 'https://us1-mirror-chromium-review.googlesource.com/a/changes/x?a=b',
437 'https://us2-mirror-chromium-review.googlesource.com/a/changes/x?a=b'])
438 self.assertEqual(url1, url3)
439 finally:
440 git_cl.gerrit_util._GERRIT_MIRROR_PREFIXES = origMirrors
441
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +0000442 def test_valid_accounts(self):
443 mock_per_account = {
444 'u1': None, # 404, doesn't exist.
445 'u2': {
446 '_account_id': 123124,
447 'avatars': [],
448 'email': 'u2@example.com',
449 'name': 'User Number 2',
450 'status': 'OOO',
451 },
452 'u3': git_cl.gerrit_util.GerritError(500, 'retries didn\'t help :('),
453 }
454 def GetAccountDetailsMock(_, account):
455 # Poor-man's mock library's side_effect.
456 v = mock_per_account.pop(account)
457 if isinstance(v, Exception):
458 raise v
459 return v
460
461 original = git_cl.gerrit_util.GetAccountDetails
462 try:
463 git_cl.gerrit_util.GetAccountDetails = GetAccountDetailsMock
464 actual = git_cl.gerrit_util.ValidAccounts(
465 'host', ['u1', 'u2', 'u3'], max_threads=1)
466 finally:
467 git_cl.gerrit_util.GetAccountDetails = original
468 self.assertEqual(actual, {
469 'u2': {
470 '_account_id': 123124,
471 'avatars': [],
472 'email': 'u2@example.com',
473 'name': 'User Number 2',
474 'status': 'OOO',
475 },
476 })
477
478
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200479class TestParseIssueURL(unittest.TestCase):
480 def _validate(self, parsed, issue=None, patchset=None, hostname=None,
Edward Lemurf38bc172019-09-03 21:02:13 +0000481 fail=False):
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200482 self.assertIsNotNone(parsed)
483 if fail:
484 self.assertFalse(parsed.valid)
485 return
486 self.assertTrue(parsed.valid)
487 self.assertEqual(parsed.issue, issue)
488 self.assertEqual(parsed.patchset, patchset)
489 self.assertEqual(parsed.hostname, hostname)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200490
Edward Lemur678a6842019-10-03 22:25:05 +0000491 def test_ParseIssueNumberArgument(self):
492 def test(arg, *args, **kwargs):
493 self._validate(git_cl.ParseIssueNumberArgument(arg), *args, **kwargs)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200494
Edward Lemur678a6842019-10-03 22:25:05 +0000495 test('123', 123)
496 test('', fail=True)
497 test('abc', fail=True)
498 test('123/1', fail=True)
499 test('123a', fail=True)
500 test('ssh://chrome-review.source.com/#/c/123/4/', fail=True)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200501
Edward Lemur678a6842019-10-03 22:25:05 +0000502 test('https://codereview.source.com/123',
503 123, None, 'codereview.source.com')
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200504 test('http://chrome-review.source.com/c/123',
505 123, None, 'chrome-review.source.com')
506 test('https://chrome-review.source.com/c/123/',
507 123, None, 'chrome-review.source.com')
508 test('https://chrome-review.source.com/c/123/4',
509 123, 4, 'chrome-review.source.com')
510 test('https://chrome-review.source.com/#/c/123/4',
511 123, 4, 'chrome-review.source.com')
512 test('https://chrome-review.source.com/c/123/4',
513 123, 4, 'chrome-review.source.com')
514 test('https://chrome-review.source.com/123',
515 123, None, 'chrome-review.source.com')
516 test('https://chrome-review.source.com/123/4',
517 123, 4, 'chrome-review.source.com')
518
Edward Lemur678a6842019-10-03 22:25:05 +0000519 test('https://chrome-review.source.com/bad/123/4', fail=True)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200520 test('https://chrome-review.source.com/c/123/1/whatisthis', fail=True)
521 test('https://chrome-review.source.com/c/abc/', fail=True)
522 test('ssh://chrome-review.source.com/c/123/1/', fail=True)
523
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200524
525
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100526class GitCookiesCheckerTest(TestCase):
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100527 def setUp(self):
528 super(GitCookiesCheckerTest, self).setUp()
529 self.c = git_cl._GitCookiesChecker()
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100530 self.c._all_hosts = []
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100531
532 def mock_hosts_creds(self, subhost_identity_pairs):
533 def ensure_googlesource(h):
534 if not h.endswith(self.c._GOOGLESOURCE):
535 assert not h.endswith('.')
536 return h + '.' + self.c._GOOGLESOURCE
537 return h
538 self.c._all_hosts = [(ensure_googlesource(h), i, '.gitcookies')
539 for h, i in subhost_identity_pairs]
540
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +0200541 def test_identity_parsing(self):
542 self.assertEqual(self.c._parse_identity('ldap.google.com'),
543 ('ldap', 'google.com'))
544 self.assertEqual(self.c._parse_identity('git-ldap.example.com'),
545 ('ldap', 'example.com'))
546 # Specical case because we know there are no subdomains in chromium.org.
547 self.assertEqual(self.c._parse_identity('git-note.period.chromium.org'),
548 ('note.period', 'chromium.org'))
Lei Zhangd3f769a2017-12-15 15:16:14 -0800549 # Pathological: ".period." can be either username OR domain, more likely
550 # domain.
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +0200551 self.assertEqual(self.c._parse_identity('git-note.period.example.com'),
552 ('note', 'period.example.com'))
553
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100554 def test_analysis_nothing(self):
555 self.c._all_hosts = []
556 self.assertFalse(self.c.has_generic_host())
557 self.assertEqual(set(), self.c.get_conflicting_hosts())
558 self.assertEqual(set(), self.c.get_duplicated_hosts())
559 self.assertEqual(set(), self.c.get_partially_configured_hosts())
560 self.assertEqual(set(), self.c.get_hosts_with_wrong_identities())
561
562 def test_analysis(self):
563 self.mock_hosts_creds([
564 ('.googlesource.com', 'git-example.chromium.org'),
565
566 ('chromium', 'git-example.google.com'),
567 ('chromium-review', 'git-example.google.com'),
568 ('chrome-internal', 'git-example.chromium.org'),
569 ('chrome-internal-review', 'git-example.chromium.org'),
570 ('conflict', 'git-example.google.com'),
571 ('conflict-review', 'git-example.chromium.org'),
572 ('dup', 'git-example.google.com'),
573 ('dup', 'git-example.google.com'),
574 ('dup-review', 'git-example.google.com'),
575 ('partial', 'git-example.google.com'),
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200576 ('gpartial-review', 'git-example.google.com'),
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100577 ])
578 self.assertTrue(self.c.has_generic_host())
579 self.assertEqual(set(['conflict.googlesource.com']),
580 self.c.get_conflicting_hosts())
581 self.assertEqual(set(['dup.googlesource.com']),
582 self.c.get_duplicated_hosts())
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200583 self.assertEqual(set(['partial.googlesource.com',
584 'gpartial-review.googlesource.com']),
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100585 self.c.get_partially_configured_hosts())
586 self.assertEqual(set(['chromium.googlesource.com',
587 'chrome-internal.googlesource.com']),
588 self.c.get_hosts_with_wrong_identities())
589
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100590 def test_report_no_problems(self):
591 self.test_analysis_nothing()
592 self.mock(sys, 'stdout', StringIO.StringIO())
593 self.assertFalse(self.c.find_and_report_problems())
594 self.assertEqual(sys.stdout.getvalue(), '')
595
596 def test_report(self):
597 self.test_analysis()
598 self.mock(sys, 'stdout', StringIO.StringIO())
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200599 self.mock(git_cl.gerrit_util.CookiesAuthenticator, 'get_gitcookies_path',
600 classmethod(lambda _: '~/.gitcookies'))
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100601 self.assertTrue(self.c.find_and_report_problems())
602 with open(os.path.join(os.path.dirname(__file__),
603 'git_cl_creds_check_report.txt')) as f:
604 expected = f.read()
605 def by_line(text):
606 return [l.rstrip() for l in text.rstrip().splitlines()]
Robert Iannucci456b0d62018-03-13 19:15:50 -0700607 self.maxDiff = 10000 # pylint: disable=attribute-defined-outside-init
Andrii Shyshkalov4812e612017-03-27 17:22:57 +0200608 self.assertEqual(by_line(sys.stdout.getvalue().strip()), by_line(expected))
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100609
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -0800610
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000611class TestGitCl(TestCase):
612 def setUp(self):
613 super(TestGitCl, self).setUp()
614 self.calls = []
tandrii9d206752016-06-20 11:32:47 -0700615 self._calls_done = []
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000616 self.mock(git_cl, 'time_time',
617 lambda: self._mocked_call('time.time'))
618 self.mock(git_cl.metrics.collector, 'add_repeated',
619 lambda *a: self._mocked_call('add_repeated', *a))
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000620 self.mock(subprocess2, 'call', self._mocked_call)
621 self.mock(subprocess2, 'check_call', self._mocked_call)
622 self.mock(subprocess2, 'check_output', self._mocked_call)
tandrii5d48c322016-08-18 16:19:37 -0700623 self.mock(subprocess2, 'communicate',
624 lambda *a, **kw: ([self._mocked_call(*a, **kw), ''], 0))
tandrii@chromium.orga342c922016-03-16 07:08:25 +0000625 self.mock(git_cl.gclient_utils, 'CheckCallAndFilter', self._mocked_call)
sbc@chromium.org71437c02015-04-09 19:29:40 +0000626 self.mock(git_common, 'is_dirty_git_tree', lambda x: False)
iannucci@chromium.org9e849272014-04-04 00:31:55 +0000627 self.mock(git_common, 'get_or_create_merge_base',
628 lambda *a: (
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000629 self._mocked_call(['get_or_create_merge_base'] + list(a))))
pgervais@chromium.org8ba38ff2015-06-11 21:41:25 +0000630 self.mock(git_cl, 'BranchExists', lambda _: True)
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000631 self.mock(git_cl, 'FindCodereviewSettingsFile', lambda: '')
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000632 self.mock(git_cl, 'SaveDescriptionBackup', lambda _:
633 self._mocked_call('SaveDescriptionBackup'))
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100634 self.mock(git_cl, 'ask_for_data', lambda *a, **k: self._mocked_call(
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000635 *(['ask_for_data'] + list(a)), **k))
phajdan.jre328cf92016-08-22 04:12:17 -0700636 self.mock(git_cl, 'write_json', lambda path, contents:
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000637 self._mocked_call('write_json', path, contents))
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000638 self.mock(git_cl.presubmit_support, 'DoPresubmitChecks', PresubmitMock)
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000639 self.mock(git_cl.watchlists, 'Watchlists', WatchlistsMock)
Edward Lemurb4a587d2019-10-09 23:56:38 +0000640 self.mock(git_cl.auth, 'get_authenticator', AuthenticatorMock)
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +0100641 self.mock(git_cl.gerrit_util, 'GetChangeDetail',
642 lambda *args, **kwargs: self._mocked_call(
643 'GetChangeDetail', *args, **kwargs))
Aaron Gable0ffdf2d2017-06-05 13:01:17 -0700644 self.mock(git_cl.gerrit_util, 'GetChangeComments',
645 lambda *args, **kwargs: self._mocked_call(
646 'GetChangeComments', *args, **kwargs))
Quinten Yearsley0e617c02019-02-20 00:37:03 +0000647 self.mock(git_cl.gerrit_util, 'GetChangeRobotComments',
648 lambda *args, **kwargs: self._mocked_call(
649 'GetChangeRobotComments', *args, **kwargs))
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +0100650 self.mock(git_cl.gerrit_util, 'AddReviewers',
Aaron Gable6dadfbf2017-05-09 14:27:58 -0700651 lambda h, i, reviewers, ccs, notify: self._mocked_call(
652 'AddReviewers', h, i, reviewers, ccs, notify))
Aaron Gablefd238082017-06-07 13:42:34 -0700653 self.mock(git_cl.gerrit_util, 'SetReview',
Aaron Gablefc62f762017-07-17 11:12:07 -0700654 lambda h, i, msg=None, labels=None, notify=None:
655 self._mocked_call('SetReview', h, i, msg, labels, notify))
Andrii Shyshkalov733d4ec2018-04-19 11:48:58 -0700656 self.mock(git_cl.gerrit_util.LuciContextAuthenticator, 'is_luci',
657 staticmethod(lambda: False))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000658 self.mock(git_cl.gerrit_util.GceAuthenticator, 'is_gce',
659 classmethod(lambda _: False))
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +0000660 self.mock(git_cl.gerrit_util, 'ValidAccounts',
661 lambda host, accounts:
662 self._mocked_call('ValidAccounts', host, accounts))
tandriic2405f52016-10-10 08:13:15 -0700663 self.mock(git_cl, 'DieWithError',
Christopher Lamf732cd52017-01-24 12:40:11 +1100664 lambda msg, change=None: self._mocked_call(['DieWithError', msg]))
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000665 # It's important to reset settings to not have inter-tests interference.
666 git_cl.settings = None
667
668 def tearDown(self):
wychen@chromium.org445c8962015-04-28 23:30:05 +0000669 try:
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +0000670 self.assertEqual([], self.calls)
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100671 except AssertionError:
wychen@chromium.org445c8962015-04-28 23:30:05 +0000672 if not self.has_failed():
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100673 raise
674 # Sadly, has_failed() returns True if this OR any other tests before this
675 # one have failed.
Andrii Shyshkalove05d4882017-04-12 14:34:49 +0200676 git_cl.logging.error(
677 '!!!!!! IF YOU SEE THIS, READ BELOW, IT WILL SAVE YOUR TIME !!!!!\n'
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100678 'There are un-consumed self.calls after this test has finished.\n'
679 'If you don\'t know which test this is, run:\n'
Aaron Gable3a16ed12017-03-23 10:51:55 -0700680 ' tests/git_cl_tests.py -v\n'
Andrii Shyshkalove05d4882017-04-12 14:34:49 +0200681 'If you are already running only this test, then **first** fix the '
682 'problem whose exception is emitted below by unittest runner.\n'
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100683 'Else, to be sure what\'s going on, run this test **alone** with \n'
Aaron Gable3a16ed12017-03-23 10:51:55 -0700684 ' tests/git_cl_tests.py TestGitCl.<name>\n'
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100685 'and follow instructions above.\n' +
686 '=' * 80)
wychen@chromium.org445c8962015-04-28 23:30:05 +0000687 finally:
688 super(TestGitCl, self).tearDown()
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000689
iannucci@chromium.org9e849272014-04-04 00:31:55 +0000690 def _mocked_call(self, *args, **_kwargs):
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000691 self.assertTrue(
692 self.calls,
tandrii9d206752016-06-20 11:32:47 -0700693 '@%d Expected: <Missing> Actual: %r' % (len(self._calls_done), args))
wychen@chromium.orga872e752015-04-28 23:42:18 +0000694 top = self.calls.pop(0)
wychen@chromium.orga872e752015-04-28 23:42:18 +0000695 expected_args, result = top
696
maruel@chromium.orge52678e2013-04-26 18:34:44 +0000697 # Also logs otherwise it could get caught in a try/finally and be hard to
698 # diagnose.
699 if expected_args != args:
tandrii9d206752016-06-20 11:32:47 -0700700 N = 5
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000701 prior_calls = '\n '.join(
tandrii9d206752016-06-20 11:32:47 -0700702 '@%d: %r' % (len(self._calls_done) - N + i, c[0])
703 for i, c in enumerate(self._calls_done[-N:]))
704 following_calls = '\n '.join(
705 '@%d: %r' % (len(self._calls_done) + i + 1, c[0])
706 for i, c in enumerate(self.calls[:N]))
707 extended_msg = (
708 'A few prior calls:\n %s\n\n'
709 'This (expected):\n @%d: %r\n'
710 'This (actual):\n @%d: %r\n\n'
711 'A few following expected calls:\n %s' %
712 (prior_calls, len(self._calls_done), expected_args,
713 len(self._calls_done), args, following_calls))
714 git_cl.logging.error(extended_msg)
715
tandrii99a72f22016-08-17 14:33:24 -0700716 self.fail('@%d\n'
717 ' Expected: %r\n'
718 ' Actual: %r' % (
tandrii9d206752016-06-20 11:32:47 -0700719 len(self._calls_done), expected_args, args))
720
721 self._calls_done.append(top)
tandrii5d48c322016-08-18 16:19:37 -0700722 if isinstance(result, Exception):
723 raise result
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000724 return result
725
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100726 def test_ask_for_explicit_yes_true(self):
727 self.calls = [
728 (('ask_for_data', 'prompt [Yes/No]: '), 'blah'),
729 (('ask_for_data', 'Please, type yes or no: '), 'ye'),
730 ]
731 self.assertTrue(git_cl.ask_for_explicit_yes('prompt'))
732
tandrii48df5812016-10-17 03:55:37 -0700733 def test_LoadCodereviewSettingsFromFile_gerrit(self):
734 codereview_file = StringIO.StringIO('GERRIT_HOST: true')
735 self.calls = [
736 ((['git', 'config', '--unset-all', 'rietveld.cc'],), CERR1),
tandrii48df5812016-10-17 03:55:37 -0700737 ((['git', 'config', '--unset-all', 'rietveld.tree-status-url'],), CERR1),
738 ((['git', 'config', '--unset-all', 'rietveld.viewvc-url'],), CERR1),
739 ((['git', 'config', '--unset-all', 'rietveld.bug-prefix'],), CERR1),
740 ((['git', 'config', '--unset-all', 'rietveld.cpplint-regex'],), CERR1),
tandrii48df5812016-10-17 03:55:37 -0700741 ((['git', 'config', '--unset-all', 'rietveld.cpplint-ignore-regex'],),
742 CERR1),
tandrii48df5812016-10-17 03:55:37 -0700743 ((['git', 'config', '--unset-all', 'rietveld.run-post-upload-hook'],),
744 CERR1),
Jamie Madill812ac222019-10-16 16:43:08 +0000745 ((['git', 'config', '--unset-all', 'rietveld.diff-lines-of-context'],),
746 CERR1),
tandrii48df5812016-10-17 03:55:37 -0700747 ((['git', 'config', 'gerrit.host', 'true'],), ''),
748 ]
749 self.assertIsNone(git_cl.LoadCodereviewSettingsFromFile(codereview_file))
750
maruel@chromium.orga3353652011-11-30 14:26:57 +0000751 @classmethod
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000752 def _is_gerrit_calls(cls, gerrit=False):
753 return [((['git', 'config', 'rietveld.autoupdate'],), ''),
754 ((['git', 'config', 'gerrit.host'],), 'True' if gerrit else '')]
755
756 @classmethod
tandrii@chromium.org1e67bb72016-02-11 12:15:49 +0000757 def _git_post_upload_calls(cls):
758 return [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000759 ((['git', 'rev-parse', 'HEAD'],), 'hash'),
760 ((['git', 'symbolic-ref', 'HEAD'],), 'hash'),
761 ((['git',
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000762 'config', 'branch.hash.last-upload-hash', 'hash'],), ''),
rmistry@google.com5626a922015-02-26 14:03:30 +0000763 ((['git', 'config', 'rietveld.run-post-upload-hook'],), ''),
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000764 ]
765
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000766 @staticmethod
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000767 def _git_sanity_checks(diff_base, working_branch, get_remote_branch=True):
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000768 fake_ancestor = 'fake_ancestor'
769 fake_cl = 'fake_cl_for_patch'
770 return [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000771 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000772 'rev-parse', '--verify', diff_base],), fake_ancestor),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000773 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000774 'merge-base', fake_ancestor, 'HEAD'],), fake_ancestor),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000775 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000776 'rev-list', '^' + fake_ancestor, 'HEAD'],), fake_cl),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000777 # Mock a config miss (error code 1)
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000778 ((['git',
tandrii5d48c322016-08-18 16:19:37 -0700779 'config', 'gitcl.remotebranch'],), CERR1),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000780 ] + ([
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000781 # Call to GetRemoteBranch()
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000782 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000783 'config', 'branch.%s.merge' % working_branch],),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000784 'refs/heads/master'),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000785 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000786 'config', 'branch.%s.remote' % working_branch],), 'origin'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000787 ] if get_remote_branch else []) + [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000788 ((['git', 'rev-list', '^' + fake_ancestor,
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000789 'refs/remotes/origin/master'],), ''),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000790 ]
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000791
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000792 @classmethod
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000793 def _gerrit_ensure_auth_calls(
Edward Lemurf38bc172019-09-03 21:02:13 +0000794 cls, issue=None, skip_auth_check=False, short_hostname='chromium',
795 custom_cl_base=None):
shinyak@chromium.org00dbccd2016-04-15 07:24:43 +0000796 cmd = ['git', 'config', '--bool', 'gerrit.skip-ensure-authenticated']
tandrii@chromium.org28253532016-04-14 13:46:56 +0000797 if skip_auth_check:
798 return [((cmd, ), 'true')]
799
tandrii5d48c322016-08-18 16:19:37 -0700800 calls = [((cmd, ), CERR1)]
Edward Lemurf38bc172019-09-03 21:02:13 +0000801
802 if custom_cl_base:
803 calls += [
804 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
805 ]
806
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000807 calls.extend([
808 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
809 ((['git', 'config', 'branch.master.remote'],), 'origin'),
810 ((['git', 'config', 'remote.origin.url'],),
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000811 'https://%s.googlesource.com/my/repo' % short_hostname),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000812 ])
Edward Lemurf38bc172019-09-03 21:02:13 +0000813
814 calls += [
815 ((['git', 'config', 'branch.master.gerritissue'],),
816 CERR1 if issue is None else str(issue)),
817 ]
818
Daniel Chengcf6269b2019-05-18 01:02:12 +0000819 if issue:
820 calls.extend([
821 ((['git', 'config', 'branch.master.gerritserver'],), CERR1),
822 ])
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000823 return calls
824
825 @classmethod
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100826 def _gerrit_base_calls(cls, issue=None, fetched_description=None,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200827 fetched_status=None, other_cl_owner=None,
Anthony Polito8b955342019-09-24 19:01:36 +0000828 custom_cl_base=None, short_hostname='chromium',
829 change_id=None):
Aaron Gable13101a62018-02-09 13:20:41 -0800830 calls = cls._is_gerrit_calls(True)
Edward Lemurf38bc172019-09-03 21:02:13 +0000831 if not custom_cl_base:
832 calls += [
833 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
834 ]
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200835
836 if custom_cl_base:
837 ancestor_revision = custom_cl_base
838 else:
839 # Determine ancestor_revision to be merge base.
840 ancestor_revision = 'fake_ancestor_sha'
841 calls += [
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000842 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000843 ((['git', 'config', 'branch.master.remote'],), 'origin'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000844 ((['get_or_create_merge_base', 'master',
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200845 'refs/remotes/origin/master'],), ancestor_revision),
846 ]
847
848 # Calls to verify branch point is ancestor
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000849 calls += cls._gerrit_ensure_auth_calls(
Edward Lemurf38bc172019-09-03 21:02:13 +0000850 issue=issue, short_hostname=short_hostname,
851 custom_cl_base=custom_cl_base)
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100852
853 if issue:
854 calls += [
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000855 (('GetChangeDetail', '%s-review.googlesource.com' % short_hostname,
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +0000856 'my%2Frepo~123456',
Andrii Shyshkalovc4a73562018-09-25 18:40:17 +0000857 ['DETAILED_ACCOUNTS', 'CURRENT_REVISION', 'CURRENT_COMMIT', 'LABELS']
858 ),
Andrii Shyshkalov3e631422017-02-16 17:46:44 +0100859 {
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100860 'owner': {'email': (other_cl_owner or 'owner@example.com')},
Anthony Polito8b955342019-09-24 19:01:36 +0000861 'change_id': (change_id or '123456789'),
Andrii Shyshkalov3e631422017-02-16 17:46:44 +0100862 'current_revision': 'sha1_of_current_revision',
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000863 'revisions': {'sha1_of_current_revision': {
Andrii Shyshkalov3e631422017-02-16 17:46:44 +0100864 'commit': {'message': fetched_description},
865 }},
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100866 'status': fetched_status or 'NEW',
Andrii Shyshkalov3e631422017-02-16 17:46:44 +0100867 }),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100868 ]
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100869 if fetched_status == 'ABANDONED':
870 calls += [
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000871 (('DieWithError', 'Change https://%s-review.googlesource.com/'
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100872 '123456 has been abandoned, new uploads are not '
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000873 'allowed' % short_hostname), SystemExitMock()),
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100874 ]
875 return calls
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100876 if other_cl_owner:
877 calls += [
878 (('ask_for_data', 'Press Enter to upload, or Ctrl+C to abort'), ''),
879 ]
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100880
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200881 calls += cls._git_sanity_checks(ancestor_revision, 'master',
882 get_remote_branch=False)
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100883 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200884 ((['git', 'rev-parse', '--show-cdup'],), ''),
885 ((['git', 'rev-parse', 'HEAD'],), '12345'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000886
Aaron Gable7817f022017-12-12 09:43:17 -0800887 ((['git', '-c', 'core.quotePath=false', 'diff', '--name-status',
888 '--no-renames', '-r', ancestor_revision + '...', '.'],),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200889 'M\t.gitignore\n'),
890 ((['git', 'config', 'branch.master.gerritpatchset'],), CERR1),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100891 ]
892
893 if not issue:
894 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200895 ((['git', 'log', '--pretty=format:%s%n%n%b',
896 ancestor_revision + '...'],),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000897 'foo'),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100898 ]
899
900 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200901 ((['git', 'config', 'user.email'],), 'me@example.com'),
Edward Lemur2c48f242019-06-04 16:14:09 +0000902 (('time.time',), 1000,),
903 (('time.time',), 3000,),
904 (('add_repeated', 'sub_commands', {
905 'execution_time': 2000,
906 'command': 'presubmit',
907 'exit_code': 0
908 }), None,),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200909 ((['git', 'diff', '--no-ext-diff', '--stat', '-l100000', '-C50'] +
910 ([custom_cl_base] if custom_cl_base else
911 [ancestor_revision, 'HEAD']),),
912 '+dat'),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100913 ]
914 return calls
ukai@chromium.orge8077812012-02-03 03:41:46 +0000915
tandrii@chromium.org1e67bb72016-02-11 12:15:49 +0000916 @classmethod
917 def _gerrit_upload_calls(cls, description, reviewers, squash,
tandriia60502f2016-06-20 02:01:53 -0700918 squash_mode='default',
tandrii@chromium.org10625002016-03-04 20:03:47 +0000919 expected_upstream_ref='origin/refs/heads/master',
Aaron Gablefd238082017-06-07 13:42:34 -0700920 title=None, notify=False,
Andrii Shyshkalove9c78ff2017-02-06 15:53:13 +0100921 post_amend_description=None, issue=None, cc=None,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000922 custom_cl_base=None, tbr=None,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +0000923 short_hostname='chromium',
Edward Lemur1b52d872019-05-09 21:12:12 +0000924 labels=None, change_id=None, original_title=None,
Anthony Polito8b955342019-09-24 19:01:36 +0000925 final_description=None, gitcookies_exists=True,
926 force=False):
tandrii@chromium.org10625002016-03-04 20:03:47 +0000927 if post_amend_description is None:
928 post_amend_description = description
bradnelsond975b302016-10-23 12:20:23 -0700929 cc = cc or []
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200930 # Determined in `_gerrit_base_calls`.
931 determined_ancestor_revision = custom_cl_base or 'fake_ancestor_sha'
932
933 calls = []
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000934
tandriia60502f2016-06-20 02:01:53 -0700935 if squash_mode == 'default':
936 calls.extend([
937 ((['git', 'config', '--bool', 'gerrit.override-squash-uploads'],), ''),
938 ((['git', 'config', '--bool', 'gerrit.squash-uploads'],), ''),
939 ])
940 elif squash_mode in ('override_squash', 'override_nosquash'):
941 calls.extend([
942 ((['git', 'config', '--bool', 'gerrit.override-squash-uploads'],),
943 'true' if squash_mode == 'override_squash' else 'false'),
944 ])
945 else:
946 assert squash_mode in ('squash', 'nosquash')
947
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000948 # If issue is given, then description is fetched from Gerrit instead.
949 if issue is None:
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000950 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200951 ((['git', 'log', '--pretty=format:%s\n\n%b',
952 ((custom_cl_base + '..') if custom_cl_base else
953 'fake_ancestor_sha..HEAD')],),
954 description),
955 ]
Aaron Gableb56ad332017-01-06 15:24:31 -0800956 if squash:
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +0000957 title = 'Initial_upload'
Aaron Gableb56ad332017-01-06 15:24:31 -0800958 else:
959 if not title:
960 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200961 ((['git', 'show', '-s', '--format=%s', 'HEAD'],), ''),
962 (('ask_for_data', 'Title for patchset []: '), 'User input'),
Aaron Gableb56ad332017-01-06 15:24:31 -0800963 ]
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +0000964 title = 'User_input'
tandrii@chromium.org57d86542016-03-04 16:11:32 +0000965 if not git_footers.get_footer_change_id(description) and not squash:
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +0000966 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200967 (('DownloadGerritHook', False), ''),
968 # Amending of commit message to get the Change-Id.
969 ((['git', 'log', '--pretty=format:%s\n\n%b',
970 determined_ancestor_revision + '..HEAD'],),
971 description),
972 ((['git', 'commit', '--amend', '-m', description],), ''),
973 ((['git', 'log', '--pretty=format:%s\n\n%b',
974 determined_ancestor_revision + '..HEAD'],),
975 post_amend_description)
976 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000977 if squash:
Anthony Polito8b955342019-09-24 19:01:36 +0000978 if force or not issue:
979 if issue:
980 calls += [
981 ((['git', 'config', 'rietveld.bug-prefix'],), ''),
982 ]
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000983 # Prompting to edit description on first upload.
984 calls += [
Jonas Termansend0f79112019-03-22 15:28:26 +0000985 ((['git', 'config', 'rietveld.bug-prefix'],), ''),
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000986 ]
Anthony Polito8b955342019-09-24 19:01:36 +0000987 if not force:
988 calls += [
989 ((['git', 'config', 'core.editor'],), ''),
990 ((['RunEditor'],), description),
991 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000992 ref_to_push = 'abcdef0123456789'
993 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200994 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
995 ((['git', 'config', 'branch.master.remote'],), 'origin'),
996 ]
997
998 if custom_cl_base is None:
999 calls += [
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001000 ((['get_or_create_merge_base', 'master',
1001 'refs/remotes/origin/master'],),
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001002 'origin/master'),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001003 ]
1004 parent = 'origin/master'
1005 else:
1006 calls += [
1007 ((['git', 'merge-base', '--is-ancestor', custom_cl_base,
1008 'refs/remotes/origin/master'],),
1009 callError(1)), # Means not ancenstor.
1010 (('ask_for_data',
1011 'Do you take responsibility for cleaning up potential mess '
1012 'resulting from proceeding with upload? Press Enter to upload, '
1013 'or Ctrl+C to abort'), ''),
1014 ]
1015 parent = custom_cl_base
1016
1017 calls += [
1018 ((['git', 'rev-parse', 'HEAD:'],), # `HEAD:` means HEAD's tree hash.
1019 '0123456789abcdef'),
1020 ((['git', 'commit-tree', '0123456789abcdef', '-p', parent,
Aaron Gable9a03ae02017-11-03 11:31:07 -07001021 '-F', '/tmp/named'],),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001022 ref_to_push),
1023 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001024 else:
1025 ref_to_push = 'HEAD'
1026
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001027 calls += [
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +00001028 (('SaveDescriptionBackup',), None),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001029 ((['git', 'rev-list',
1030 (custom_cl_base if custom_cl_base else expected_upstream_ref) + '..' +
1031 ref_to_push],),
1032 '1hashPerLine\n'),
1033 ]
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001034
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001035 metrics_arguments = []
1036
Aaron Gableafd52772017-06-27 16:40:10 -07001037 if notify:
Aaron Gable844cf292017-06-28 11:32:59 -07001038 ref_suffix = '%ready,notify=ALL'
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001039 metrics_arguments += ['ready', 'notify=ALL']
Aaron Gable844cf292017-06-28 11:32:59 -07001040 else:
Jamie Madill276da0b2018-04-27 14:41:20 -04001041 if not issue and squash:
Aaron Gable844cf292017-06-28 11:32:59 -07001042 ref_suffix = '%wip'
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001043 metrics_arguments.append('wip')
Aaron Gable844cf292017-06-28 11:32:59 -07001044 else:
1045 ref_suffix = '%notify=NONE'
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001046 metrics_arguments.append('notify=NONE')
Aaron Gable9b713dd2016-12-14 16:04:21 -08001047
Aaron Gable70f4e242017-06-26 10:45:59 -07001048 if title:
Aaron Gableafd52772017-06-27 16:40:10 -07001049 ref_suffix += ',m=' + title
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001050 metrics_arguments.append('m')
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001051
Edward Lemur4508b422019-10-03 21:56:35 +00001052 if issue is None:
1053 calls += [
1054 ((['git', 'config', 'rietveld.cc'],), ''),
1055 ]
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001056 if short_hostname == 'chromium':
1057 # All reviwers and ccs get into ref_suffix.
1058 for r in sorted(reviewers):
1059 ref_suffix += ',r=%s' % r
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001060 metrics_arguments.append('r')
Edward Lemur4508b422019-10-03 21:56:35 +00001061 if issue is None:
1062 cc += ['chromium-reviews+test-more-cc@chromium.org', 'joe@example.com']
1063 for c in sorted(cc):
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001064 ref_suffix += ',cc=%s' % c
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001065 metrics_arguments.append('cc')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001066 reviewers, cc = [], []
1067 else:
1068 # TODO(crbug/877717): remove this case.
1069 calls += [
1070 (('ValidAccounts', '%s-review.googlesource.com' % short_hostname,
1071 sorted(reviewers) + ['joe@example.com',
1072 'chromium-reviews+test-more-cc@chromium.org'] + cc),
1073 {
1074 e: {'email': e}
1075 for e in (reviewers + ['joe@example.com'] + cc)
1076 })
1077 ]
1078 for r in sorted(reviewers):
1079 if r != 'bad-account-or-email':
1080 ref_suffix += ',r=%s' % r
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001081 metrics_arguments.append('r')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001082 reviewers.remove(r)
Edward Lemur4508b422019-10-03 21:56:35 +00001083 if issue is None:
1084 cc += ['joe@example.com']
1085 for c in sorted(cc):
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001086 ref_suffix += ',cc=%s' % c
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001087 metrics_arguments.append('cc')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001088 if c in cc:
1089 cc.remove(c)
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00001090
Edward Lemur687ca902018-12-05 02:30:30 +00001091 for k, v in sorted((labels or {}).items()):
1092 ref_suffix += ',l=%s+%d' % (k, v)
1093 metrics_arguments.append('l=%s+%d' % (k, v))
1094
1095 if tbr:
1096 calls += [
1097 (('GetCodeReviewTbrScore',
1098 '%s-review.googlesource.com' % short_hostname,
1099 'my/repo'),
1100 2,),
1101 ]
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001102
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001103 calls += [
1104 (('time.time',), 1000,),
1105 ((['git', 'push',
1106 'https://%s.googlesource.com/my/repo' % short_hostname,
1107 ref_to_push + ':refs/for/refs/heads/master' + ref_suffix],),
1108 (('remote:\n'
1109 'remote: Processing changes: (\)\n'
1110 'remote: Processing changes: (|)\n'
1111 'remote: Processing changes: (/)\n'
1112 'remote: Processing changes: (-)\n'
1113 'remote: Processing changes: new: 1 (/)\n'
1114 'remote: Processing changes: new: 1, done\n'
1115 'remote:\n'
1116 'remote: New Changes:\n'
1117 'remote: https://%s-review.googlesource.com/#/c/my/repo/+/123456'
1118 ' XXX\n'
1119 'remote:\n'
1120 'To https://%s.googlesource.com/my/repo\n'
1121 ' * [new branch] hhhh -> refs/for/refs/heads/master\n'
1122 ) % (short_hostname, short_hostname)),),
1123 (('time.time',), 2000,),
1124 (('add_repeated',
1125 'sub_commands',
1126 {
1127 'execution_time': 1000,
1128 'command': 'git push',
1129 'exit_code': 0,
1130 'arguments': sorted(metrics_arguments),
1131 }),
1132 None,),
1133 ]
1134
Edward Lemur1b52d872019-05-09 21:12:12 +00001135 final_description = final_description or post_amend_description.strip()
1136 original_title = original_title or title or '<untitled>'
1137 # Trace-related calls
1138 calls += [
1139 # Write a description with context for the current trace.
1140 ((['FileWrite', 'TRACES_DIR/20170316T200041.000000-README',
Edward Lemur75391d42019-05-14 23:35:56 +00001141 'Thu Mar 16 20:00:41 2017\n'
1142 '%(short_hostname)s-review.googlesource.com\n'
1143 '%(change_id)s\n'
1144 '%(title)s\n'
1145 '%(description)s\n'
1146 '1000\n'
1147 '0\n'
1148 '%(trace_name)s' % {
Edward Lemur1b52d872019-05-09 21:12:12 +00001149 'short_hostname': short_hostname,
1150 'change_id': change_id,
1151 'description': final_description,
1152 'title': original_title,
Edward Lemur75391d42019-05-14 23:35:56 +00001153 'trace_name': 'TRACES_DIR/20170316T200041.000000',
Edward Lemur1b52d872019-05-09 21:12:12 +00001154 }],),
1155 None,
1156 ),
1157 # Read traces and shorten git hashes.
1158 ((['os.path.isfile', 'TEMP_DIR/trace-packet'],),
1159 True,
1160 ),
1161 ((['FileRead', 'TEMP_DIR/trace-packet'],),
1162 ('git-hash: 0123456789012345678901234567890123456789\n'
1163 'git-hash: abcdeabcdeabcdeabcdeabcdeabcdeabcdeabcde\n'),
1164 ),
1165 ((['FileWrite', 'TEMP_DIR/trace-packet',
1166 'git-hash: 012345\n'
1167 'git-hash: abcdea\n'],),
1168 None,
1169 ),
1170 # Make zip file for the git traces.
1171 ((['make_archive', 'TRACES_DIR/20170316T200041.000000-traces', 'zip',
1172 'TEMP_DIR'],),
1173 None,
1174 ),
1175 # Collect git config and gitcookies.
1176 ((['git', 'config', '-l'],),
1177 'git-config-output',
1178 ),
1179 ((['FileWrite', 'TEMP_DIR/git-config', 'git-config-output'],),
1180 None,
1181 ),
1182 ((['os.path.isfile', '~/.gitcookies'],),
1183 gitcookies_exists,
1184 ),
1185 ]
1186 if gitcookies_exists:
1187 calls += [
1188 ((['FileRead', '~/.gitcookies'],),
1189 'gitcookies 1/SECRET',
1190 ),
1191 ((['FileWrite', 'TEMP_DIR/gitcookies', 'gitcookies REDACTED'],),
1192 None,
1193 ),
1194 ]
1195 calls += [
1196 # Make zip file for the git config and gitcookies.
1197 ((['make_archive', 'TRACES_DIR/20170316T200041.000000-git-info', 'zip',
1198 'TEMP_DIR'],),
1199 None,
1200 ),
1201 ]
1202
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001203 if squash:
1204 calls += [
tandrii33a46ff2016-08-23 05:53:40 -07001205 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
tandrii5d48c322016-08-18 16:19:37 -07001206 ''),
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001207 ((['git', 'config', 'branch.master.gerritserver',
tandrii5d48c322016-08-18 16:19:37 -07001208 'https://chromium-review.googlesource.com'],), ''),
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001209 ((['git', 'config', 'branch.master.gerritsquashhash',
1210 'abcdef0123456789'],), ''),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001211 ]
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001212 # TODO(crbug/877717): this should never be used.
1213 if squash and short_hostname != 'chromium':
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001214 calls += [
1215 (('AddReviewers',
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00001216 'chromium-review.googlesource.com', 'my%2Frepo~123456',
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001217 sorted(reviewers),
Andrii Shyshkalov2f727912018-10-15 17:02:33 +00001218 cc + ['chromium-reviews+test-more-cc@chromium.org'],
1219 notify),
1220 ''),
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001221 ]
tandrii@chromium.org1e67bb72016-02-11 12:15:49 +00001222 calls += cls._git_post_upload_calls()
ukai@chromium.orge8077812012-02-03 03:41:46 +00001223 return calls
1224
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001225 def _run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001226 self,
1227 upload_args,
1228 description,
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00001229 reviewers=None,
tandriia60502f2016-06-20 02:01:53 -07001230 squash=True,
1231 squash_mode=None,
tandrii@chromium.org10625002016-03-04 20:03:47 +00001232 expected_upstream_ref='origin/refs/heads/master',
Aaron Gable9b713dd2016-12-14 16:04:21 -08001233 title=None,
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001234 notify=False,
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001235 post_amend_description=None,
bradnelsond975b302016-10-23 12:20:23 -07001236 issue=None,
Andrii Shyshkalove9c78ff2017-02-06 15:53:13 +01001237 cc=None,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001238 fetched_status=None,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001239 other_cl_owner=None,
Aaron Gablefd238082017-06-07 13:42:34 -07001240 custom_cl_base=None,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001241 tbr=None,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001242 short_hostname='chromium',
Edward Lemur1b52d872019-05-09 21:12:12 +00001243 labels=None,
1244 change_id=None,
1245 original_title=None,
1246 final_description=None,
Anthony Polito8b955342019-09-24 19:01:36 +00001247 gitcookies_exists=True,
1248 force=False,
1249 fetched_description=None):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001250 """Generic gerrit upload test framework."""
tandriia60502f2016-06-20 02:01:53 -07001251 if squash_mode is None:
1252 if '--no-squash' in upload_args:
1253 squash_mode = 'nosquash'
1254 elif '--squash' in upload_args:
1255 squash_mode = 'squash'
1256 else:
1257 squash_mode = 'default'
1258
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00001259 reviewers = reviewers or []
bradnelsond975b302016-10-23 12:20:23 -07001260 cc = cc or []
tandrii@chromium.org28253532016-04-14 13:46:56 +00001261 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
tandrii16e0b4e2016-06-07 10:34:28 -07001262 self.mock(git_cl.gerrit_util, 'CookiesAuthenticator',
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001263 CookiesAuthenticatorMockFactory(
1264 same_auth=('git-owner.example.com', '', 'pass')))
Edward Lemur125d60a2019-09-13 18:25:41 +00001265 self.mock(git_cl.Changelist, '_GerritCommitMsgHookCheck',
tandrii16e0b4e2016-06-07 10:34:28 -07001266 lambda _, offer_removal: None)
tandriia60502f2016-06-20 02:01:53 -07001267 self.mock(git_cl.gclient_utils, 'RunEditor',
1268 lambda *_, **__: self._mocked_call(['RunEditor']))
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001269 self.mock(git_cl, 'DownloadGerritHook', lambda force: self._mocked_call(
1270 'DownloadGerritHook', force))
Edward Lemur1b52d872019-05-09 21:12:12 +00001271 self.mock(git_cl.gclient_utils, 'FileRead',
1272 lambda path: self._mocked_call(['FileRead', path]))
1273 self.mock(git_cl.gclient_utils, 'FileWrite',
1274 lambda path, contents: self._mocked_call(
1275 ['FileWrite', path, contents]))
1276 self.mock(git_cl, 'datetime_now',
1277 lambda: datetime.datetime(2017, 3, 16, 20, 0, 41, 0))
1278 self.mock(git_cl.tempfile, 'mkdtemp', lambda: 'TEMP_DIR')
1279 self.mock(git_cl, 'TRACES_DIR', 'TRACES_DIR')
Edward Lemur75391d42019-05-14 23:35:56 +00001280 self.mock(git_cl, 'TRACES_README_FORMAT',
1281 '%(now)s\n'
1282 '%(gerrit_host)s\n'
1283 '%(change_id)s\n'
1284 '%(title)s\n'
1285 '%(description)s\n'
1286 '%(execution_time)s\n'
1287 '%(exit_code)s\n'
1288 '%(trace_name)s')
Edward Lemur1b52d872019-05-09 21:12:12 +00001289 self.mock(git_cl.shutil, 'make_archive',
1290 lambda *args: self._mocked_call(['make_archive'] + list(args)))
1291 self.mock(os.path, 'isfile',
1292 lambda path: self._mocked_call(['os.path.isfile', path]))
tandriia60502f2016-06-20 02:01:53 -07001293
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001294 self.calls = self._gerrit_base_calls(
1295 issue=issue,
Anthony Polito8b955342019-09-24 19:01:36 +00001296 fetched_description=fetched_description or description,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001297 fetched_status=fetched_status,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001298 other_cl_owner=other_cl_owner,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001299 custom_cl_base=custom_cl_base,
Anthony Polito8b955342019-09-24 19:01:36 +00001300 short_hostname=short_hostname,
1301 change_id=change_id)
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001302 if fetched_status != 'ABANDONED':
Aaron Gable9a03ae02017-11-03 11:31:07 -07001303 self.mock(tempfile, 'NamedTemporaryFile', MakeNamedTemporaryFileMock(
1304 expected_content=description))
1305 self.mock(os, 'remove', lambda _: True)
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001306 self.calls += self._gerrit_upload_calls(
1307 description, reviewers, squash,
1308 squash_mode=squash_mode,
1309 expected_upstream_ref=expected_upstream_ref,
Aaron Gablefd238082017-06-07 13:42:34 -07001310 title=title, notify=notify,
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001311 post_amend_description=post_amend_description,
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00001312 issue=issue, cc=cc,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001313 custom_cl_base=custom_cl_base, tbr=tbr,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001314 short_hostname=short_hostname,
Edward Lemur1b52d872019-05-09 21:12:12 +00001315 labels=labels,
1316 change_id=change_id,
1317 original_title=original_title,
1318 final_description=final_description,
Anthony Polito8b955342019-09-24 19:01:36 +00001319 gitcookies_exists=gitcookies_exists,
1320 force=force)
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +00001321 # Uncomment when debugging.
Raul Tambre80ee78e2019-05-06 22:41:05 +00001322 # print('\n'.join(map(lambda x: '%2i: %s' % x, enumerate(self.calls))))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001323 git_cl.main(['upload'] + upload_args)
1324
Edward Lemur1b52d872019-05-09 21:12:12 +00001325 def test_gerrit_upload_traces_no_gitcookies(self):
1326 self._run_gerrit_upload_test(
1327 ['--no-squash'],
1328 'desc\n\nBUG=\n',
1329 [],
1330 squash=False,
1331 post_amend_description='desc\n\nBUG=\n\nChange-Id: Ixxx',
1332 change_id='Ixxx',
1333 gitcookies_exists=False)
1334
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001335 def test_gerrit_upload_without_change_id(self):
tandriia60502f2016-06-20 02:01:53 -07001336 self._run_gerrit_upload_test(
1337 ['--no-squash'],
1338 'desc\n\nBUG=\n',
1339 [],
1340 squash=False,
Edward Lemur1b52d872019-05-09 21:12:12 +00001341 post_amend_description='desc\n\nBUG=\n\nChange-Id: Ixxx',
1342 change_id='Ixxx')
tandriia60502f2016-06-20 02:01:53 -07001343
1344 def test_gerrit_upload_without_change_id_override_nosquash(self):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001345 self._run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001346 [],
jamesr@chromium.org35d1a842012-07-27 00:20:43 +00001347 'desc\n\nBUG=\n',
tandrii@chromium.org10625002016-03-04 20:03:47 +00001348 [],
tandriia60502f2016-06-20 02:01:53 -07001349 squash=False,
1350 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001351 post_amend_description='desc\n\nBUG=\n\nChange-Id: Ixxx',
1352 change_id='Ixxx')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001353
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001354 def test_gerrit_no_reviewer(self):
1355 self._run_gerrit_upload_test(
1356 [],
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +00001357 'desc\n\nBUG=\n\nChange-Id: I123456789\n',
tandriia60502f2016-06-20 02:01:53 -07001358 [],
1359 squash=False,
Edward Lemur1b52d872019-05-09 21:12:12 +00001360 squash_mode='override_nosquash',
1361 change_id='I123456789')
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001362
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001363 def test_gerrit_no_reviewer_non_chromium_host(self):
1364 # TODO(crbug/877717): remove this test case.
1365 self._run_gerrit_upload_test(
1366 [],
1367 'desc\n\nBUG=\n\nChange-Id: I123456789\n',
1368 [],
1369 squash=False,
1370 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001371 short_hostname='other',
1372 change_id='I123456789')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001373
Nick Carter8692b182017-11-06 16:30:38 -08001374 def test_gerrit_patchset_title_special_chars(self):
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001375 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
1376 self._run_gerrit_upload_test(
Nick Carter8692b182017-11-06 16:30:38 -08001377 ['-f', '-t', 'We\'ll escape ^_ ^ special chars...@{u}'],
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001378 'desc\n\nBUG=\n\nChange-Id: I123456789',
1379 squash=False,
1380 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001381 title='We%27ll_escape_%5E%5F_%5E_special_chars%2E%2E%2E%40%7Bu%7D',
1382 change_id='I123456789',
1383 original_title='We\'ll escape ^_ ^ special chars...@{u}')
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001384
ukai@chromium.orge8077812012-02-03 03:41:46 +00001385 def test_gerrit_reviewers_cmd_line(self):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001386 self._run_gerrit_upload_test(
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001387 ['-r', 'foo@example.com', '--send-mail'],
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +00001388 'desc\n\nBUG=\n\nChange-Id: I123456789',
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001389 ['foo@example.com'],
tandriia60502f2016-06-20 02:01:53 -07001390 squash=False,
1391 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001392 notify=True,
1393 change_id='I123456789',
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001394 final_description=(
1395 'desc\n\nBUG=\nR=foo@example.com\n\nChange-Id: I123456789'))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001396
Anthony Polito8b955342019-09-24 19:01:36 +00001397 def test_gerrit_upload_force_sets_bug(self):
1398 self._run_gerrit_upload_test(
1399 ['-b', '10000', '-f'],
1400 u'desc=\n\nBug: 10000\nChange-Id: Ixxx',
1401 [],
1402 force=True,
1403 expected_upstream_ref='origin/master',
1404 fetched_description='desc=\n\nChange-Id: Ixxx',
1405 original_title='Initial upload',
1406 change_id='Ixxx')
1407
1408 def test_gerrit_upload_force_sets_bug_if_wrong_changeid(self):
1409 self._run_gerrit_upload_test(
1410 ['-b', '10000', '-f', '-m', 'Title'],
1411 u'desc=\n\nChange-Id: Ixxxx\n\nChange-Id: Izzzz\nBug: 10000',
1412 [],
1413 force=True,
1414 issue='123456',
1415 expected_upstream_ref='origin/master',
1416 fetched_description='desc=\n\nChange-Id: Ixxxx',
1417 original_title='Title',
1418 title='Title',
1419 change_id='Izzzz')
1420
Dan Beamd8b04ca2019-10-10 21:23:26 +00001421 def test_gerrit_upload_force_sets_fixed(self):
1422 self._run_gerrit_upload_test(
1423 ['-x', '10000', '-f'],
1424 u'desc=\n\nFixed: 10000\nChange-Id: Ixxx',
1425 [],
1426 force=True,
1427 expected_upstream_ref='origin/master',
1428 fetched_description='desc=\n\nChange-Id: Ixxx',
1429 original_title='Initial upload',
1430 change_id='Ixxx')
1431
ukai@chromium.orge8077812012-02-03 03:41:46 +00001432 def test_gerrit_reviewer_multiple(self):
Edward Lemur687ca902018-12-05 02:30:30 +00001433 self.mock(git_cl.gerrit_util, 'GetCodeReviewTbrScore',
1434 lambda *a: self._mocked_call('GetCodeReviewTbrScore', *a))
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001435 self._run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001436 [],
bradnelsond975b302016-10-23 12:20:23 -07001437 'desc\nTBR=reviewer@example.com\nBUG=\nR=another@example.com\n'
1438 'CC=more@example.com,people@example.com\n\n'
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +09001439 'Change-Id: 123456789',
tandriia60502f2016-06-20 02:01:53 -07001440 ['reviewer@example.com', 'another@example.com'],
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +09001441 expected_upstream_ref='origin/master',
Aaron Gablefd238082017-06-07 13:42:34 -07001442 cc=['more@example.com', 'people@example.com'],
Edward Lemur687ca902018-12-05 02:30:30 +00001443 tbr='reviewer@example.com',
Edward Lemur1b52d872019-05-09 21:12:12 +00001444 labels={'Code-Review': 2},
1445 change_id='123456789',
1446 original_title='Initial upload')
tandriia60502f2016-06-20 02:01:53 -07001447
1448 def test_gerrit_upload_squash_first_is_default(self):
tandriia60502f2016-06-20 02:01:53 -07001449 self._run_gerrit_upload_test(
1450 [],
1451 'desc\nBUG=\n\nChange-Id: 123456789',
1452 [],
Edward Lemur1b52d872019-05-09 21:12:12 +00001453 expected_upstream_ref='origin/master',
1454 change_id='123456789',
1455 original_title='Initial upload')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001456
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001457 def test_gerrit_upload_squash_first(self):
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001458 self._run_gerrit_upload_test(
1459 ['--squash'],
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001460 'desc\nBUG=\n\nChange-Id: 123456789',
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001461 [],
luqui@chromium.org609f3952015-05-04 22:47:04 +00001462 squash=True,
Edward Lemur1b52d872019-05-09 21:12:12 +00001463 expected_upstream_ref='origin/master',
1464 change_id='123456789',
1465 original_title='Initial upload')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001466
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001467 def test_gerrit_upload_squash_first_with_labels(self):
1468 self._run_gerrit_upload_test(
1469 ['--squash', '--cq-dry-run', '--enable-auto-submit'],
1470 'desc\nBUG=\n\nChange-Id: 123456789',
1471 [],
1472 squash=True,
1473 expected_upstream_ref='origin/master',
Edward Lemur1b52d872019-05-09 21:12:12 +00001474 labels={'Commit-Queue': 1, 'Auto-Submit': 1},
1475 change_id='123456789',
1476 original_title='Initial upload')
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001477
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001478 def test_gerrit_upload_squash_first_against_rev(self):
1479 custom_cl_base = 'custom_cl_base_rev_or_branch'
1480 self._run_gerrit_upload_test(
1481 ['--squash', custom_cl_base],
1482 'desc\nBUG=\n\nChange-Id: 123456789',
1483 [],
1484 squash=True,
1485 expected_upstream_ref='origin/master',
Edward Lemur1b52d872019-05-09 21:12:12 +00001486 custom_cl_base=custom_cl_base,
1487 change_id='123456789',
1488 original_title='Initial upload')
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001489 self.assertIn(
1490 'If you proceed with upload, more than 1 CL may be created by Gerrit',
1491 sys.stdout.getvalue())
1492
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001493 def test_gerrit_upload_squash_reupload(self):
1494 description = 'desc\nBUG=\n\nChange-Id: 123456789'
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001495 self._run_gerrit_upload_test(
1496 ['--squash'],
1497 description,
1498 [],
1499 squash=True,
1500 expected_upstream_ref='origin/master',
Edward Lemur1b52d872019-05-09 21:12:12 +00001501 issue=123456,
1502 change_id='123456789',
1503 original_title='User input')
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001504
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001505 def test_gerrit_upload_squash_reupload_to_abandoned(self):
1506 self.mock(git_cl, 'DieWithError',
1507 lambda msg, change=None: self._mocked_call('DieWithError', msg))
1508 description = 'desc\nBUG=\n\nChange-Id: 123456789'
1509 with self.assertRaises(SystemExitMock):
1510 self._run_gerrit_upload_test(
1511 ['--squash'],
1512 description,
1513 [],
1514 squash=True,
1515 expected_upstream_ref='origin/master',
1516 issue=123456,
Edward Lemur1b52d872019-05-09 21:12:12 +00001517 fetched_status='ABANDONED',
1518 change_id='123456789')
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001519
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001520 def test_gerrit_upload_squash_reupload_to_not_owned(self):
1521 self.mock(git_cl.gerrit_util, 'GetAccountDetails',
1522 lambda *_, **__: {'email': 'yet-another@example.com'})
1523 description = 'desc\nBUG=\n\nChange-Id: 123456789'
1524 self._run_gerrit_upload_test(
1525 ['--squash'],
1526 description,
1527 [],
1528 squash=True,
1529 expected_upstream_ref='origin/master',
1530 issue=123456,
Edward Lemur1b52d872019-05-09 21:12:12 +00001531 other_cl_owner='other@example.com',
1532 change_id='123456789',
1533 original_title='User input')
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001534 self.assertIn(
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001535 'WARNING: Change 123456 is owned by other@example.com, but you '
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001536 'authenticate to Gerrit as yet-another@example.com.\n'
1537 'Uploading may fail due to lack of permissions',
1538 git_cl.sys.stdout.getvalue())
1539
rmistry@google.com2dd99862015-06-22 12:22:18 +00001540 def test_upload_branch_deps(self):
tandrii@chromium.org28253532016-04-14 13:46:56 +00001541 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
rmistry@google.com2dd99862015-06-22 12:22:18 +00001542 def mock_run_git(*args, **_kwargs):
1543 if args[0] == ['for-each-ref',
1544 '--format=%(refname:short) %(upstream:short)',
1545 'refs/heads']:
1546 # Create a local branch dependency tree that looks like this:
1547 # test1 -> test2 -> test3 -> test4 -> test5
1548 # -> test3.1
1549 # test6 -> test0
1550 branch_deps = [
1551 'test2 test1', # test1 -> test2
1552 'test3 test2', # test2 -> test3
1553 'test3.1 test2', # test2 -> test3.1
1554 'test4 test3', # test3 -> test4
1555 'test5 test4', # test4 -> test5
1556 'test6 test0', # test0 -> test6
1557 'test7', # test7
1558 ]
1559 return '\n'.join(branch_deps)
1560 self.mock(git_cl, 'RunGit', mock_run_git)
1561
1562 class RecordCalls:
1563 times_called = 0
1564 record_calls = RecordCalls()
1565 def mock_CMDupload(*args, **_kwargs):
1566 record_calls.times_called += 1
1567 return 0
1568 self.mock(git_cl, 'CMDupload', mock_CMDupload)
1569
1570 self.calls = [
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01001571 (('ask_for_data', 'This command will checkout all dependent branches '
1572 'and run "git cl upload". Press Enter to continue, '
1573 'or Ctrl+C to abort'), ''),
1574 ]
rmistry@google.com2dd99862015-06-22 12:22:18 +00001575
1576 class MockChangelist():
1577 def __init__(self):
1578 pass
1579 def GetBranch(self):
1580 return 'test1'
1581 def GetIssue(self):
1582 return '123'
1583 def GetPatchset(self):
1584 return '1001'
tandrii@chromium.org4c72b082016-03-31 22:26:35 +00001585 def IsGerrit(self):
1586 return False
rmistry@google.com2dd99862015-06-22 12:22:18 +00001587
1588 ret = git_cl.upload_branch_deps(MockChangelist(), [])
1589 # CMDupload should have been called 5 times because of 5 dependent branches.
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00001590 self.assertEqual(5, record_calls.times_called)
1591 self.assertEqual(0, ret)
rmistry@google.com2dd99862015-06-22 12:22:18 +00001592
tandrii@chromium.org65874e12016-03-04 12:03:02 +00001593 def test_gerrit_change_id(self):
1594 self.calls = [
1595 ((['git', 'write-tree'], ),
1596 'hashtree'),
1597 ((['git', 'rev-parse', 'HEAD~0'], ),
1598 'branch-parent'),
1599 ((['git', 'var', 'GIT_AUTHOR_IDENT'], ),
1600 'A B <a@b.org> 1456848326 +0100'),
1601 ((['git', 'var', 'GIT_COMMITTER_IDENT'], ),
1602 'C D <c@d.org> 1456858326 +0100'),
1603 ((['git', 'hash-object', '-t', 'commit', '--stdin'], ),
1604 'hashchange'),
1605 ]
1606 change_id = git_cl.GenerateGerritChangeId('line1\nline2\n')
1607 self.assertEqual(change_id, 'Ihashchange')
1608
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00001609 def test_desecription_append_footer(self):
1610 for init_desc, footer_line, expected_desc in [
1611 # Use unique desc first lines for easy test failure identification.
1612 ('foo', 'R=one', 'foo\n\nR=one'),
1613 ('foo\n\nR=one', 'BUG=', 'foo\n\nR=one\nBUG='),
1614 ('foo\n\nR=one', 'Change-Id: Ixx', 'foo\n\nR=one\n\nChange-Id: Ixx'),
1615 ('foo\n\nChange-Id: Ixx', 'R=one', 'foo\n\nR=one\n\nChange-Id: Ixx'),
1616 ('foo\n\nR=one\n\nChange-Id: Ixx', 'TBR=two',
1617 'foo\n\nR=one\nTBR=two\n\nChange-Id: Ixx'),
1618 ('foo\n\nR=one\n\nChange-Id: Ixx', 'Foo-Bar: baz',
1619 'foo\n\nR=one\n\nChange-Id: Ixx\nFoo-Bar: baz'),
1620 ('foo\n\nChange-Id: Ixx', 'Foo-Bak: baz',
1621 'foo\n\nChange-Id: Ixx\nFoo-Bak: baz'),
1622 ('foo', 'Change-Id: Ixx', 'foo\n\nChange-Id: Ixx'),
1623 ]:
1624 desc = git_cl.ChangeDescription(init_desc)
1625 desc.append_footer(footer_line)
1626 self.assertEqual(desc.description, expected_desc)
1627
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001628 def test_update_reviewers(self):
1629 data = [
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001630 ('foo', [], [],
1631 'foo'),
1632 ('foo\nR=xx', [], [],
1633 'foo\nR=xx'),
1634 ('foo\nTBR=xx', [], [],
1635 'foo\nTBR=xx'),
1636 ('foo', ['a@c'], [],
1637 'foo\n\nR=a@c'),
1638 ('foo\nR=xx', ['a@c'], [],
1639 'foo\n\nR=a@c, xx'),
1640 ('foo\nTBR=xx', ['a@c'], [],
1641 'foo\n\nR=a@c\nTBR=xx'),
1642 ('foo\nTBR=xx\nR=yy', ['a@c'], [],
1643 'foo\n\nR=a@c, yy\nTBR=xx'),
1644 ('foo\nBUG=', ['a@c'], [],
1645 'foo\nBUG=\nR=a@c'),
1646 ('foo\nR=xx\nTBR=yy\nR=bar', ['a@c'], [],
1647 'foo\n\nR=a@c, bar, xx\nTBR=yy'),
1648 ('foo', ['a@c', 'b@c'], [],
1649 'foo\n\nR=a@c, b@c'),
1650 ('foo\nBar\n\nR=\nBUG=', ['c@c'], [],
1651 'foo\nBar\n\nR=c@c\nBUG='),
1652 ('foo\nBar\n\nR=\nBUG=\nR=', ['c@c'], [],
1653 'foo\nBar\n\nR=c@c\nBUG='),
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001654 # Same as the line before, but full of whitespaces.
1655 (
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001656 'foo\nBar\n\n R = \n BUG = \n R = ', ['c@c'], [],
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001657 'foo\nBar\n\nR=c@c\n BUG =',
1658 ),
1659 # Whitespaces aren't interpreted as new lines.
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001660 ('foo BUG=allo R=joe ', ['c@c'], [],
1661 'foo BUG=allo R=joe\n\nR=c@c'),
1662 # Redundant TBRs get promoted to Rs
1663 ('foo\n\nR=a@c\nTBR=t@c', ['b@c', 'a@c'], ['a@c', 't@c'],
1664 'foo\n\nR=a@c, b@c\nTBR=t@c'),
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001665 ]
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001666 expected = [i[-1] for i in data]
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001667 actual = []
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001668 for orig, reviewers, tbrs, _expected in data:
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001669 obj = git_cl.ChangeDescription(orig)
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001670 obj.update_reviewers(reviewers, tbrs)
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001671 actual.append(obj.description)
1672 self.assertEqual(expected, actual)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001673
Nodir Turakulov23b82142017-11-16 11:04:25 -08001674 def test_get_hash_tags(self):
1675 cases = [
1676 ('', []),
1677 ('a', []),
1678 ('[a]', ['a']),
1679 ('[aa]', ['aa']),
1680 ('[a ]', ['a']),
1681 ('[a- ]', ['a']),
1682 ('[a- b]', ['a-b']),
1683 ('[a--b]', ['a-b']),
1684 ('[a', []),
1685 ('[a]x', ['a']),
1686 ('[aa]x', ['aa']),
1687 ('[a b]', ['a-b']),
1688 ('[a b]', ['a-b']),
1689 ('[a__b]', ['a-b']),
1690 ('[a] x', ['a']),
1691 ('[a][b]', ['a', 'b']),
1692 ('[a] [b]', ['a', 'b']),
1693 ('[a][b]x', ['a', 'b']),
1694 ('[a][b] x', ['a', 'b']),
1695 ('[a]\n[b]', ['a']),
1696 ('[a\nb]', []),
1697 ('[a][', ['a']),
1698 ('Revert "[a] feature"', ['a']),
1699 ('Reland "[a] feature"', ['a']),
1700 ('Revert: [a] feature', ['a']),
1701 ('Reland: [a] feature', ['a']),
1702 ('Revert "Reland: [a] feature"', ['a']),
1703 ('Foo: feature', ['foo']),
1704 ('Foo Bar: feature', ['foo-bar']),
1705 ('Revert "Foo bar: feature"', ['foo-bar']),
1706 ('Reland "Foo bar: feature"', ['foo-bar']),
1707 ]
1708 for desc, expected in cases:
1709 change_desc = git_cl.ChangeDescription(desc)
1710 actual = change_desc.get_hash_tags()
1711 self.assertEqual(
1712 actual,
1713 expected,
1714 'GetHashTags(%r) == %r, expected %r' % (desc, actual, expected))
1715
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001716 self.assertEqual(None, git_cl.GetTargetRef('origin', None, 'master'))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001717 self.assertEqual(None, git_cl.GetTargetRef(None,
1718 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001719 'master'))
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001720
wittman@chromium.org455dc922015-01-26 20:15:50 +00001721 # Check default target refs for branches.
1722 self.assertEqual('refs/heads/master',
1723 git_cl.GetTargetRef('origin', 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001724 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001725 self.assertEqual('refs/heads/master',
1726 git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkgr',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001727 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001728 self.assertEqual('refs/heads/master',
1729 git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkcr',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001730 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001731 self.assertEqual('refs/branch-heads/123',
1732 git_cl.GetTargetRef('origin',
1733 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001734 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001735 self.assertEqual('refs/diff/test',
1736 git_cl.GetTargetRef('origin',
1737 'refs/remotes/origin/refs/diff/test',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001738 None))
rmistry@google.comc68112d2015-03-03 12:48:06 +00001739 self.assertEqual('refs/heads/chrome/m42',
1740 git_cl.GetTargetRef('origin',
1741 'refs/remotes/origin/chrome/m42',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001742 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001743
1744 # Check target refs for user-specified target branch.
1745 for branch in ('branch-heads/123', 'remotes/branch-heads/123',
1746 'refs/remotes/branch-heads/123'):
1747 self.assertEqual('refs/branch-heads/123',
1748 git_cl.GetTargetRef('origin',
1749 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001750 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001751 for branch in ('origin/master', 'remotes/origin/master',
1752 'refs/remotes/origin/master'):
1753 self.assertEqual('refs/heads/master',
1754 git_cl.GetTargetRef('origin',
1755 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001756 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001757 for branch in ('master', 'heads/master', 'refs/heads/master'):
1758 self.assertEqual('refs/heads/master',
1759 git_cl.GetTargetRef('origin',
1760 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001761 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001762
wychen@chromium.orga872e752015-04-28 23:42:18 +00001763 def test_patch_when_dirty(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001764 # Patch when local tree is dirty.
wychen@chromium.orga872e752015-04-28 23:42:18 +00001765 self.mock(git_common, 'is_dirty_git_tree', lambda x: True)
1766 self.assertNotEqual(git_cl.main(['patch', '123456']), 0)
1767
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001768 @staticmethod
1769 def _get_gerrit_codereview_server_calls(branch, value=None,
1770 git_short_host='host',
Aaron Gable697a91b2018-01-19 15:20:15 -08001771 detect_branch=True,
1772 detect_server=True):
Edward Lemur125d60a2019-09-13 18:25:41 +00001773 """Returns calls executed by Changelist.GetCodereviewServer.
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001774
1775 If value is given, branch.<BRANCH>.gerritcodereview is already set.
1776 """
1777 calls = []
1778 if detect_branch:
1779 calls.append(((['git', 'symbolic-ref', 'HEAD'],), branch))
Aaron Gable697a91b2018-01-19 15:20:15 -08001780 if detect_server:
1781 calls.append(((['git', 'config', 'branch.' + branch + '.gerritserver'],),
1782 CERR1 if value is None else value))
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001783 if value is None:
1784 calls += [
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001785 ((['git', 'config', 'branch.' + branch + '.merge'],),
1786 'refs/heads' + branch),
1787 ((['git', 'config', 'branch.' + branch + '.remote'],),
1788 'origin'),
1789 ((['git', 'config', 'remote.origin.url'],),
1790 'https://%s.googlesource.com/my/repo' % git_short_host),
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001791 ]
1792 return calls
1793
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001794 def _patch_common(self, force_codereview=False,
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001795 new_branch=False, git_short_host='host',
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001796 detect_gerrit_server=False,
1797 actual_codereview=None,
1798 codereview_in_url=False):
tandrii@chromium.org28253532016-04-14 13:46:56 +00001799 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
wychen@chromium.orga872e752015-04-28 23:42:18 +00001800 self.mock(git_cl, 'IsGitVersionAtLeast', lambda *args: True)
1801
tandriidf09a462016-08-18 16:23:55 -07001802 if new_branch:
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001803 self.calls = [((['git', 'new-branch', 'master'],), '')]
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001804
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001805 if codereview_in_url and actual_codereview == 'rietveld':
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001806 self.calls += [
1807 ((['git', 'rev-parse', '--show-cdup'],), ''),
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001808 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001809 ]
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001810
1811 if not force_codereview and not codereview_in_url:
1812 # These calls detect codereview to use.
1813 self.calls += [
1814 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001815 ]
1816 if detect_gerrit_server:
1817 self.calls += self._get_gerrit_codereview_server_calls(
1818 'master', git_short_host=git_short_host,
1819 detect_branch=not new_branch and force_codereview)
1820 actual_codereview = 'gerrit'
1821
1822 if actual_codereview == 'gerrit':
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001823 self.calls += [
1824 (('GetChangeDetail', git_short_host + '-review.googlesource.com',
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001825 'my%2Frepo~123456', ['ALL_REVISIONS', 'CURRENT_COMMIT']),
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001826 {
1827 'current_revision': '7777777777',
1828 'revisions': {
1829 '1111111111': {
1830 '_number': 1,
1831 'fetch': {'http': {
1832 'url': 'https://%s.googlesource.com/my/repo' % git_short_host,
1833 'ref': 'refs/changes/56/123456/1',
1834 }},
1835 },
1836 '7777777777': {
1837 '_number': 7,
1838 'fetch': {'http': {
1839 'url': 'https://%s.googlesource.com/my/repo' % git_short_host,
1840 'ref': 'refs/changes/56/123456/7',
1841 }},
1842 },
1843 },
1844 }),
1845 ]
wychen@chromium.orga872e752015-04-28 23:42:18 +00001846
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001847 def test_patch_gerrit_default(self):
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001848 self._patch_common(git_short_host='chromium', detect_gerrit_server=True)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001849 self.calls += [
1850 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
1851 'refs/changes/56/123456/7'],), ''),
Aaron Gable62619a32017-06-16 08:22:09 -07001852 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001853 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
Aaron Gable697a91b2018-01-19 15:20:15 -08001854 ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001855 ((['git', 'config', 'branch.master.gerritserver',
1856 'https://chromium-review.googlesource.com'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001857 ((['git', 'config', 'branch.master.gerritpatchset', '7'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001858 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1859 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1860 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001861 ]
1862 self.assertEqual(git_cl.main(['patch', '123456']), 0)
1863
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001864 def test_patch_gerrit_new_branch(self):
1865 self._patch_common(
1866 git_short_host='chromium', detect_gerrit_server=True, new_branch=True)
1867 self.calls += [
1868 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
1869 'refs/changes/56/123456/7'],), ''),
1870 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
1871 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
1872 ''),
1873 ((['git', 'config', 'branch.master.gerritserver',
1874 'https://chromium-review.googlesource.com'],), ''),
1875 ((['git', 'config', 'branch.master.gerritpatchset', '7'],), ''),
1876 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1877 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1878 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
1879 ]
1880 self.assertEqual(git_cl.main(['patch', '-b', 'master', '123456']), 0)
1881
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001882 def test_patch_gerrit_force(self):
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001883 self._patch_common(
1884 force_codereview=True, git_short_host='host', detect_gerrit_server=True)
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001885 self.calls += [
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001886 ((['git', 'fetch', 'https://host.googlesource.com/my/repo',
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001887 'refs/changes/56/123456/7'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001888 ((['git', 'reset', '--hard', 'FETCH_HEAD'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001889 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
tandrii5d48c322016-08-18 16:19:37 -07001890 ''),
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001891 ((['git', 'config', 'branch.master.gerritserver',
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001892 'https://host-review.googlesource.com'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001893 ((['git', 'config', 'branch.master.gerritpatchset', '7'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001894 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1895 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1896 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001897 ]
Aaron Gable62619a32017-06-16 08:22:09 -07001898 self.assertEqual(git_cl.main(['patch', '--gerrit', '123456', '--force']), 0)
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001899
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001900 def test_patch_gerrit_guess_by_url(self):
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001901 self.calls += self._get_gerrit_codereview_server_calls(
1902 'master', git_short_host='else', detect_server=False)
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001903 self._patch_common(
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001904 actual_codereview='gerrit', git_short_host='else',
1905 codereview_in_url=True, detect_gerrit_server=False)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001906 self.calls += [
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001907 ((['git', 'fetch', 'https://else.googlesource.com/my/repo',
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001908 'refs/changes/56/123456/1'],), ''),
Aaron Gable62619a32017-06-16 08:22:09 -07001909 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001910 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
tandrii5d48c322016-08-18 16:19:37 -07001911 ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001912 ((['git', 'config', 'branch.master.gerritserver',
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001913 'https://else-review.googlesource.com'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001914 ((['git', 'config', 'branch.master.gerritpatchset', '1'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001915 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1916 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1917 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001918 ]
1919 self.assertEqual(git_cl.main(
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001920 ['patch', 'https://else-review.googlesource.com/#/c/123456/1']), 0)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001921
Aaron Gable697a91b2018-01-19 15:20:15 -08001922 def test_patch_gerrit_guess_by_url_with_repo(self):
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001923 self.calls += self._get_gerrit_codereview_server_calls(
1924 'master', git_short_host='else', detect_server=False)
Aaron Gable697a91b2018-01-19 15:20:15 -08001925 self._patch_common(
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001926 actual_codereview='gerrit', git_short_host='else',
1927 codereview_in_url=True, detect_gerrit_server=False)
Aaron Gable697a91b2018-01-19 15:20:15 -08001928 self.calls += [
1929 ((['git', 'fetch', 'https://else.googlesource.com/my/repo',
1930 'refs/changes/56/123456/1'],), ''),
1931 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
1932 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
1933 ''),
1934 ((['git', 'config', 'branch.master.gerritserver',
1935 'https://else-review.googlesource.com'],), ''),
1936 ((['git', 'config', 'branch.master.gerritpatchset', '1'],), ''),
1937 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1938 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1939 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
1940 ]
1941 self.assertEqual(git_cl.main(
1942 ['patch', 'https://else-review.googlesource.com/c/my/repo/+/123456/1']),
1943 0)
1944
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001945 def test_patch_gerrit_conflict(self):
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001946 self._patch_common(detect_gerrit_server=True, git_short_host='chromium')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001947 self.calls += [
1948 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001949 'refs/changes/56/123456/7'],), ''),
tandrii5d48c322016-08-18 16:19:37 -07001950 ((['git', 'cherry-pick', 'FETCH_HEAD'],), CERR1),
1951 ((['DieWithError', 'Command "git cherry-pick FETCH_HEAD" failed.\n'],),
1952 SystemExitMock()),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001953 ]
1954 with self.assertRaises(SystemExitMock):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001955 git_cl.main(['patch', '123456'])
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001956
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001957 def test_patch_gerrit_not_exists(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001958
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01001959 def notExists(_issue, *_, **kwargs):
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01001960 raise git_cl.gerrit_util.GerritError(404, '')
1961 self.mock(git_cl.gerrit_util, 'GetChangeDetail', notExists)
1962
tandriic2405f52016-10-10 08:13:15 -07001963 self.calls = [
1964 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001965 ((['git', 'config', 'branch.master.gerritserver'],), CERR1),
1966 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
1967 ((['git', 'config', 'branch.master.remote'],), 'origin'),
1968 ((['git', 'config', 'remote.origin.url'],),
1969 'https://chromium.googlesource.com/my/repo'),
1970 ((['DieWithError',
1971 'change 123456 at https://chromium-review.googlesource.com does not '
1972 'exist or you have no access to it'],), SystemExitMock()),
tandriic2405f52016-10-10 08:13:15 -07001973 ]
1974 with self.assertRaises(SystemExitMock):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001975 self.assertEqual(1, git_cl.main(['patch', '123456']))
tandriic2405f52016-10-10 08:13:15 -07001976
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001977 def _checkout_calls(self):
1978 return [
1979 ((['git', 'config', '--local', '--get-regexp',
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001980 'branch\\..*\\.gerritissue'], ),
1981 ('branch.ger-branch.gerritissue 123456\n'
1982 'branch.gbranch654.gerritissue 654321\n')),
1983 ]
1984
1985 def test_checkout_gerrit(self):
1986 """Tests git cl checkout <issue>."""
1987 self.calls = self._checkout_calls()
1988 self.calls += [((['git', 'checkout', 'ger-branch'], ), '')]
1989 self.assertEqual(0, git_cl.main(['checkout', '123456']))
1990
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001991 def test_checkout_not_found(self):
1992 """Tests git cl checkout <issue>."""
tandrii@chromium.org28253532016-04-14 13:46:56 +00001993 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001994 self.calls = self._checkout_calls()
1995 self.assertEqual(1, git_cl.main(['checkout', '99999']))
1996
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001997 def test_checkout_no_branch_issues(self):
1998 """Tests git cl checkout <issue>."""
tandrii@chromium.org28253532016-04-14 13:46:56 +00001999 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00002000 self.calls = [
2001 ((['git', 'config', '--local', '--get-regexp',
tandrii5d48c322016-08-18 16:19:37 -07002002 'branch\\..*\\.gerritissue'], ), CERR1),
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00002003 ]
2004 self.assertEqual(1, git_cl.main(['checkout', '99999']))
2005
tandrii@chromium.org28253532016-04-14 13:46:56 +00002006 def _test_gerrit_ensure_authenticated_common(self, auth,
2007 skip_auth_check=False):
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002008 self.mock(git_cl.gerrit_util, 'CookiesAuthenticator',
2009 CookiesAuthenticatorMockFactory(hosts_with_creds=auth))
2010 self.mock(git_cl, 'DieWithError',
Christopher Lamf732cd52017-01-24 12:40:11 +11002011 lambda msg, change=None: self._mocked_call(['DieWithError', msg]))
tandrii@chromium.org28253532016-04-14 13:46:56 +00002012 self.calls = self._gerrit_ensure_auth_calls(skip_auth_check=skip_auth_check)
Edward Lemurf38bc172019-09-03 21:02:13 +00002013 cl = git_cl.Changelist()
tandrii@chromium.org28253532016-04-14 13:46:56 +00002014 cl.branch = 'master'
2015 cl.branchref = 'refs/heads/master'
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002016 return cl
2017
2018 def test_gerrit_ensure_authenticated_missing(self):
2019 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01002020 'chromium.googlesource.com': ('git-is.ok', '', 'but gerrit is missing'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002021 })
2022 self.calls.append(
2023 ((['DieWithError',
2024 'Credentials for the following hosts are required:\n'
2025 ' chromium-review.googlesource.com\n'
2026 'These are read from ~/.gitcookies (or legacy ~/.netrc)\n'
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01002027 'You can (re)generate your credentials by visiting '
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002028 'https://chromium-review.googlesource.com/new-password'],), ''),)
2029 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2030
2031 def test_gerrit_ensure_authenticated_conflict(self):
tandrii@chromium.org28253532016-04-14 13:46:56 +00002032 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002033 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01002034 'chromium.googlesource.com':
2035 ('git-one.example.com', None, 'secret1'),
2036 'chromium-review.googlesource.com':
2037 ('git-other.example.com', None, 'secret2'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002038 })
2039 self.calls.append(
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002040 (('ask_for_data', 'If you know what you are doing '
2041 'press Enter to continue, or Ctrl+C to abort'), ''))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002042 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2043
2044 def test_gerrit_ensure_authenticated_ok(self):
2045 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01002046 'chromium.googlesource.com':
2047 ('git-same.example.com', None, 'secret'),
2048 'chromium-review.googlesource.com':
2049 ('git-same.example.com', None, 'secret'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002050 })
2051 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2052
tandrii@chromium.org28253532016-04-14 13:46:56 +00002053 def test_gerrit_ensure_authenticated_skipped(self):
2054 cl = self._test_gerrit_ensure_authenticated_common(
2055 auth={}, skip_auth_check=True)
2056 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2057
Eric Boren2fb63102018-10-05 13:05:03 +00002058 def test_gerrit_ensure_authenticated_bearer_token(self):
2059 cl = self._test_gerrit_ensure_authenticated_common(auth={
2060 'chromium.googlesource.com':
2061 ('', None, 'secret'),
2062 'chromium-review.googlesource.com':
2063 ('', None, 'secret'),
2064 })
2065 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2066 header = gerrit_util.CookiesAuthenticator().get_auth_header(
2067 'chromium.googlesource.com')
2068 self.assertTrue('Bearer' in header)
2069
Daniel Chengcf6269b2019-05-18 01:02:12 +00002070 def test_gerrit_ensure_authenticated_non_https(self):
2071 self.calls = [
2072 ((['git', 'config', '--bool',
2073 'gerrit.skip-ensure-authenticated'],), CERR1),
2074 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
2075 ((['git', 'config', 'branch.master.remote'],), 'origin'),
2076 ((['git', 'config', 'remote.origin.url'],), 'custom-scheme://repo'),
2077 ]
2078 self.mock(git_cl.gerrit_util, 'CookiesAuthenticator',
2079 CookiesAuthenticatorMockFactory(hosts_with_creds={}))
Edward Lemurf38bc172019-09-03 21:02:13 +00002080 cl = git_cl.Changelist()
Daniel Chengcf6269b2019-05-18 01:02:12 +00002081 cl.branch = 'master'
2082 cl.branchref = 'refs/heads/master'
2083 cl.lookedup_issue = True
2084 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2085
Andrii Shyshkalov828701b2016-12-09 10:46:47 +01002086 def _cmd_set_commit_gerrit_common(self, vote, notify=None):
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002087 self.mock(git_cl.gerrit_util, 'SetReview',
Andrii Shyshkalov828701b2016-12-09 10:46:47 +01002088 lambda h, i, labels, notify=None:
2089 self._mocked_call(['SetReview', h, i, labels, notify]))
2090
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002091 self.calls = [
2092 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii33a46ff2016-08-23 05:53:40 -07002093 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002094 ((['git', 'config', 'branch.feature.gerritserver'],),
2095 'https://chromium-review.googlesource.com'),
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002096 ((['git', 'config', 'branch.feature.merge'],), 'refs/heads/master'),
2097 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
2098 ((['git', 'config', 'remote.origin.url'],),
2099 'https://chromium.googlesource.com/infra/infra.git'),
2100 ((['SetReview', 'chromium-review.googlesource.com',
2101 'infra%2Finfra~123',
Andrii Shyshkalov828701b2016-12-09 10:46:47 +01002102 {'Commit-Queue': vote}, notify],), ''),
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002103 ]
tandriid9e5ce52016-07-13 02:32:59 -07002104
2105 def test_cmd_set_commit_gerrit_clear(self):
2106 self._cmd_set_commit_gerrit_common(0)
2107 self.assertEqual(0, git_cl.main(['set-commit', '-c']))
2108
2109 def test_cmd_set_commit_gerrit_dry(self):
Aaron Gable75e78722017-06-09 10:40:16 -07002110 self._cmd_set_commit_gerrit_common(1, notify=False)
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002111 self.assertEqual(0, git_cl.main(['set-commit', '-d']))
2112
tandriid9e5ce52016-07-13 02:32:59 -07002113 def test_cmd_set_commit_gerrit(self):
2114 self._cmd_set_commit_gerrit_common(2)
2115 self.assertEqual(0, git_cl.main(['set-commit']))
2116
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002117 def test_description_display(self):
2118 out = StringIO.StringIO()
2119 self.mock(git_cl.sys, 'stdout', out)
2120
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002121 self.mock(git_cl, 'Changelist', ChangelistMock)
2122 ChangelistMock.desc = 'foo\n'
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002123
2124 self.assertEqual(0, git_cl.main(['description', '-d']))
2125 self.assertEqual('foo\n', out.getvalue())
2126
iannucci3c972b92016-08-17 13:24:10 -07002127 def test_StatusFieldOverrideIssueMissingArgs(self):
2128 out = StringIO.StringIO()
2129 self.mock(git_cl.sys, 'stderr', out)
2130
2131 try:
2132 self.assertEqual(git_cl.main(['status', '--issue', '1']), 0)
2133 except SystemExit as ex:
2134 self.assertEqual(ex.code, 2)
Edward Lemurf38bc172019-09-03 21:02:13 +00002135 self.assertRegexpMatches(out.getvalue(), r'--field must be specified')
iannucci3c972b92016-08-17 13:24:10 -07002136
2137 out = StringIO.StringIO()
2138 self.mock(git_cl.sys, 'stderr', out)
2139
2140 try:
Andrii Shyshkalovfeec80e2018-10-16 01:00:47 +00002141 self.assertEqual(git_cl.main(['status', '--issue', '1', '--gerrit']), 0)
iannucci3c972b92016-08-17 13:24:10 -07002142 except SystemExit as ex:
2143 self.assertEqual(ex.code, 2)
iannuccie53c9352016-08-17 14:40:40 -07002144 self.assertRegexpMatches(out.getvalue(), r'--field must be specified')
iannucci3c972b92016-08-17 13:24:10 -07002145
2146 def test_StatusFieldOverrideIssue(self):
2147 out = StringIO.StringIO()
2148 self.mock(git_cl.sys, 'stdout', out)
2149
2150 def assertIssue(cl_self, *_args):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002151 self.assertEqual(cl_self.issue, 1)
iannucci3c972b92016-08-17 13:24:10 -07002152 return 'foobar'
2153
2154 self.mock(git_cl.Changelist, 'GetDescription', assertIssue)
iannuccie53c9352016-08-17 14:40:40 -07002155 self.assertEqual(
Andrii Shyshkalovfeec80e2018-10-16 01:00:47 +00002156 git_cl.main(['status', '--issue', '1', '--gerrit', '--field', 'desc']),
iannuccie53c9352016-08-17 14:40:40 -07002157 0)
iannucci3c972b92016-08-17 13:24:10 -07002158 self.assertEqual(out.getvalue(), 'foobar\n')
2159
iannuccie53c9352016-08-17 14:40:40 -07002160 def test_SetCloseOverrideIssue(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002161
iannuccie53c9352016-08-17 14:40:40 -07002162 def assertIssue(cl_self, *_args):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002163 self.assertEqual(cl_self.issue, 1)
iannuccie53c9352016-08-17 14:40:40 -07002164 return 'foobar'
2165
2166 self.mock(git_cl.Changelist, 'GetDescription', assertIssue)
2167 self.mock(git_cl.Changelist, 'CloseIssue', lambda *_: None)
iannuccie53c9352016-08-17 14:40:40 -07002168 self.assertEqual(
Andrii Shyshkalovfeec80e2018-10-16 01:00:47 +00002169 git_cl.main(['set-close', '--issue', '1', '--gerrit']), 0)
iannuccie53c9352016-08-17 14:40:40 -07002170
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00002171 def test_description(self):
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002172 out = StringIO.StringIO()
2173 self.mock(git_cl.sys, 'stdout', out)
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01002174 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002175 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
2176 ((['git', 'config', 'branch.feature.merge'],), 'feature'),
2177 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
2178 ((['git', 'config', 'remote.origin.url'],),
2179 'https://chromium.googlesource.com/my/repo'),
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00002180 (('GetChangeDetail', 'chromium-review.googlesource.com',
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002181 'my%2Frepo~123123', ['CURRENT_REVISION', 'CURRENT_COMMIT']),
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01002182 {
2183 'current_revision': 'sha1',
2184 'revisions': {'sha1': {
2185 'commit': {'message': 'foobar'},
2186 }},
2187 }),
2188 ]
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002189 self.assertEqual(0, git_cl.main([
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00002190 'description',
2191 'https://chromium-review.googlesource.com/c/my/repo/+/123123',
2192 '-d']))
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002193 self.assertEqual('foobar\n', out.getvalue())
2194
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002195 def test_description_set_raw(self):
2196 out = StringIO.StringIO()
2197 self.mock(git_cl.sys, 'stdout', out)
2198
2199 self.mock(git_cl, 'Changelist', ChangelistMock)
2200 self.mock(git_cl.sys, 'stdin', StringIO.StringIO('hihi'))
2201
2202 self.assertEqual(0, git_cl.main(['description', '-n', 'hihi']))
2203 self.assertEqual('hihi', ChangelistMock.desc)
2204
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002205 def test_description_appends_bug_line(self):
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002206 current_desc = 'Some.\n\nChange-Id: xxx'
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002207
2208 def RunEditor(desc, _, **kwargs):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002209 self.assertEqual(
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002210 '# Enter a description of the change.\n'
2211 '# This will be displayed on the codereview site.\n'
2212 '# The first line will also be used as the subject of the review.\n'
2213 '#--------------------This line is 72 characters long'
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002214 '--------------------\n'
Aaron Gable3a16ed12017-03-23 10:51:55 -07002215 'Some.\n\nChange-Id: xxx\nBug: ',
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002216 desc)
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002217 # Simulate user changing something.
Aaron Gable3a16ed12017-03-23 10:51:55 -07002218 return 'Some.\n\nChange-Id: xxx\nBug: 123'
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002219
dsansomee2d6fd92016-09-08 00:10:47 -07002220 def UpdateDescriptionRemote(_, desc, force=False):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002221 self.assertEqual(desc, 'Some.\n\nChange-Id: xxx\nBug: 123')
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002222
2223 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2224 self.mock(git_cl.Changelist, 'GetDescription',
2225 lambda *args: current_desc)
Edward Lemur125d60a2019-09-13 18:25:41 +00002226 self.mock(git_cl.Changelist, 'UpdateDescriptionRemote',
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002227 UpdateDescriptionRemote)
2228 self.mock(git_cl.gclient_utils, 'RunEditor', RunEditor)
2229
2230 self.calls = [
2231 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii33a46ff2016-08-23 05:53:40 -07002232 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
tandrii5d48c322016-08-18 16:19:37 -07002233 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
2234 ((['git', 'config', 'rietveld.bug-prefix'],), CERR1),
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002235 ((['git', 'config', 'core.editor'],), 'vi'),
2236 ]
2237 self.assertEqual(0, git_cl.main(['description', '--gerrit']))
2238
Dan Beamd8b04ca2019-10-10 21:23:26 +00002239 def test_description_does_not_append_bug_line_if_fixed_is_present(self):
2240 current_desc = 'Some.\n\nFixed: 123\nChange-Id: xxx'
2241
2242 def RunEditor(desc, _, **kwargs):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002243 self.assertEqual(
Dan Beamd8b04ca2019-10-10 21:23:26 +00002244 '# Enter a description of the change.\n'
2245 '# This will be displayed on the codereview site.\n'
2246 '# The first line will also be used as the subject of the review.\n'
2247 '#--------------------This line is 72 characters long'
2248 '--------------------\n'
2249 'Some.\n\nFixed: 123\nChange-Id: xxx',
2250 desc)
2251 return desc
2252
2253 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2254 self.mock(git_cl.Changelist, 'GetDescription',
2255 lambda *args: current_desc)
2256 self.mock(git_cl.gclient_utils, 'RunEditor', RunEditor)
2257
2258 self.calls = [
2259 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
2260 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
2261 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
2262 ((['git', 'config', 'rietveld.bug-prefix'],), CERR1),
2263 ((['git', 'config', 'core.editor'],), 'vi'),
2264 ]
2265 self.assertEqual(0, git_cl.main(['description', '--gerrit']))
2266
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002267 def test_description_set_stdin(self):
2268 out = StringIO.StringIO()
2269 self.mock(git_cl.sys, 'stdout', out)
2270
2271 self.mock(git_cl, 'Changelist', ChangelistMock)
2272 self.mock(git_cl.sys, 'stdin', StringIO.StringIO('hi \r\n\t there\n\nman'))
2273
2274 self.assertEqual(0, git_cl.main(['description', '-n', '-']))
2275 self.assertEqual('hi\n\t there\n\nman', ChangelistMock.desc)
2276
kmarshall3bff56b2016-06-06 18:31:47 -07002277 def test_archive(self):
tandrii1c67da62016-06-10 07:35:53 -07002278 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2279
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002280 self.calls = [
2281 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
Edward Lemurf38bc172019-09-03 21:02:13 +00002282 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002283 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2284 ((['git', 'tag', 'git-cl-archived-456-foo', 'foo'],), ''),
Edward Lemurf38bc172019-09-03 21:02:13 +00002285 ((['git', 'branch', '-D', 'foo'],), '')
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002286 ]
kmarshall3bff56b2016-06-06 18:31:47 -07002287
kmarshall3bff56b2016-06-06 18:31:47 -07002288 self.mock(git_cl, 'get_cl_statuses',
2289 lambda branches, fine_grained, max_processes:
kmarshall9249e012016-08-23 12:02:16 -07002290 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2291 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
2292 (MockChangelistWithBranchAndIssue('bar', 789), 'open')])
kmarshall3bff56b2016-06-06 18:31:47 -07002293
2294 self.assertEqual(0, git_cl.main(['archive', '-f']))
2295
2296 def test_archive_current_branch_fails(self):
tandrii1c67da62016-06-10 07:35:53 -07002297 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002298 self.calls = [
2299 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2300 'refs/heads/master'),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002301 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2302 ]
kmarshall3bff56b2016-06-06 18:31:47 -07002303
kmarshall9249e012016-08-23 12:02:16 -07002304 self.mock(git_cl, 'get_cl_statuses',
2305 lambda branches, fine_grained, max_processes:
2306 [(MockChangelistWithBranchAndIssue('master', 1), 'closed')])
2307
2308 self.assertEqual(1, git_cl.main(['archive', '-f']))
2309
2310 def test_archive_dry_run(self):
2311 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2312
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002313 self.calls = [
2314 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2315 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002316 ((['git', 'symbolic-ref', 'HEAD'],), 'master')
2317 ]
kmarshall3bff56b2016-06-06 18:31:47 -07002318
2319 self.mock(git_cl, 'get_cl_statuses',
2320 lambda branches, fine_grained, max_processes:
kmarshall9249e012016-08-23 12:02:16 -07002321 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2322 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
2323 (MockChangelistWithBranchAndIssue('bar', 789), 'open')])
kmarshall3bff56b2016-06-06 18:31:47 -07002324
kmarshall9249e012016-08-23 12:02:16 -07002325 self.assertEqual(0, git_cl.main(['archive', '-f', '--dry-run']))
2326
2327 def test_archive_no_tags(self):
2328 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2329
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002330 self.calls = [
2331 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2332 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002333 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2334 ((['git', 'branch', '-D', 'foo'],), '')
2335 ]
kmarshall9249e012016-08-23 12:02:16 -07002336
2337 self.mock(git_cl, 'get_cl_statuses',
2338 lambda branches, fine_grained, max_processes:
2339 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2340 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
2341 (MockChangelistWithBranchAndIssue('bar', 789), 'open')])
2342
2343 self.assertEqual(0, git_cl.main(['archive', '-f', '--notags']))
kmarshall3bff56b2016-06-06 18:31:47 -07002344
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002345 def test_cmd_issue_erase_existing(self):
2346 out = StringIO.StringIO()
2347 self.mock(git_cl.sys, 'stdout', out)
2348 self.calls = [
2349 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002350 # Let this command raise exception (retcode=1) - it should be ignored.
2351 ((['git', 'config', '--unset', 'branch.feature.last-upload-hash'],),
tandrii5d48c322016-08-18 16:19:37 -07002352 CERR1),
2353 ((['git', 'config', '--unset', 'branch.feature.gerritissue'],), ''),
2354 ((['git', 'config', '--unset', 'branch.feature.gerritpatchset'],), ''),
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002355 ((['git', 'config', '--unset', 'branch.feature.gerritserver'],), ''),
2356 ((['git', 'config', '--unset', 'branch.feature.gerritsquashhash'],),
2357 ''),
Aaron Gableca01e2c2017-07-19 11:16:02 -07002358 ((['git', 'log', '-1', '--format=%B'],), 'This is a description'),
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002359 ]
2360 self.assertEqual(0, git_cl.main(['issue', '0']))
2361
Aaron Gable400e9892017-07-12 15:31:21 -07002362 def test_cmd_issue_erase_existing_with_change_id(self):
2363 out = StringIO.StringIO()
2364 self.mock(git_cl.sys, 'stdout', out)
2365 self.mock(git_cl.Changelist, 'GetDescription',
2366 lambda _: 'This is a description\n\nChange-Id: Ideadbeef')
2367 self.calls = [
2368 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
Aaron Gable400e9892017-07-12 15:31:21 -07002369 # Let this command raise exception (retcode=1) - it should be ignored.
2370 ((['git', 'config', '--unset', 'branch.feature.last-upload-hash'],),
2371 CERR1),
2372 ((['git', 'config', '--unset', 'branch.feature.gerritissue'],), ''),
2373 ((['git', 'config', '--unset', 'branch.feature.gerritpatchset'],), ''),
2374 ((['git', 'config', '--unset', 'branch.feature.gerritserver'],), ''),
2375 ((['git', 'config', '--unset', 'branch.feature.gerritsquashhash'],),
2376 ''),
Aaron Gableca01e2c2017-07-19 11:16:02 -07002377 ((['git', 'log', '-1', '--format=%B'],),
2378 'This is a description\n\nChange-Id: Ideadbeef'),
2379 ((['git', 'commit', '--amend', '-m', 'This is a description\n'],), ''),
Aaron Gable400e9892017-07-12 15:31:21 -07002380 ]
2381 self.assertEqual(0, git_cl.main(['issue', '0']))
2382
phajdan.jre328cf92016-08-22 04:12:17 -07002383 def test_cmd_issue_json(self):
2384 out = StringIO.StringIO()
2385 self.mock(git_cl.sys, 'stdout', out)
2386 self.calls = [
2387 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
Andrii Shyshkalova185e2e2018-11-21 00:42:55 +00002388 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
2389 ((['git', 'config', 'branch.feature.gerritserver'],),
2390 'https://chromium-review.googlesource.com'),
phajdan.jre328cf92016-08-22 04:12:17 -07002391 (('write_json', 'output.json',
Andrii Shyshkalova185e2e2018-11-21 00:42:55 +00002392 {'issue': 123,
2393 'issue_url': 'https://chromium-review.googlesource.com/123'}),
phajdan.jre328cf92016-08-22 04:12:17 -07002394 ''),
2395 ]
2396 self.assertEqual(0, git_cl.main(['issue', '--json', 'output.json']))
2397
tandrii16e0b4e2016-06-07 10:34:28 -07002398 def _common_GerritCommitMsgHookCheck(self):
2399 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2400 self.mock(git_cl.os.path, 'abspath',
2401 lambda path: self._mocked_call(['abspath', path]))
2402 self.mock(git_cl.os.path, 'exists',
2403 lambda path: self._mocked_call(['exists', path]))
2404 self.mock(git_cl.gclient_utils, 'FileRead',
2405 lambda path: self._mocked_call(['FileRead', path]))
2406 self.mock(git_cl.gclient_utils, 'rm_file_or_tree',
2407 lambda path: self._mocked_call(['rm_file_or_tree', path]))
2408 self.calls = [
2409 ((['git', 'rev-parse', '--show-cdup'],), '../'),
2410 ((['abspath', '../'],), '/abs/git_repo_root'),
2411 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002412 return git_cl.Changelist(issue=123)
tandrii16e0b4e2016-06-07 10:34:28 -07002413
2414 def test_GerritCommitMsgHookCheck_custom_hook(self):
2415 cl = self._common_GerritCommitMsgHookCheck()
2416 self.calls += [
2417 ((['exists', '/abs/git_repo_root/.git/hooks/commit-msg'],), True),
2418 ((['FileRead', '/abs/git_repo_root/.git/hooks/commit-msg'],),
2419 '#!/bin/sh\necho "custom hook"')
2420 ]
Edward Lemur125d60a2019-09-13 18:25:41 +00002421 cl._GerritCommitMsgHookCheck(offer_removal=True)
tandrii16e0b4e2016-06-07 10:34:28 -07002422
2423 def test_GerritCommitMsgHookCheck_not_exists(self):
2424 cl = self._common_GerritCommitMsgHookCheck()
2425 self.calls += [
2426 ((['exists', '/abs/git_repo_root/.git/hooks/commit-msg'],), False),
2427 ]
Edward Lemur125d60a2019-09-13 18:25:41 +00002428 cl._GerritCommitMsgHookCheck(offer_removal=True)
tandrii16e0b4e2016-06-07 10:34:28 -07002429
2430 def test_GerritCommitMsgHookCheck(self):
2431 cl = self._common_GerritCommitMsgHookCheck()
2432 self.calls += [
2433 ((['exists', '/abs/git_repo_root/.git/hooks/commit-msg'],), True),
2434 ((['FileRead', '/abs/git_repo_root/.git/hooks/commit-msg'],),
2435 '...\n# From Gerrit Code Review\n...\nadd_ChangeId()\n'),
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002436 (('ask_for_data', 'Do you want to remove it now? [Yes/No]: '), 'Yes'),
tandrii16e0b4e2016-06-07 10:34:28 -07002437 ((['rm_file_or_tree', '/abs/git_repo_root/.git/hooks/commit-msg'],),
2438 ''),
2439 ]
Edward Lemur125d60a2019-09-13 18:25:41 +00002440 cl._GerritCommitMsgHookCheck(offer_removal=True)
tandrii16e0b4e2016-06-07 10:34:28 -07002441
tandriic4344b52016-08-29 06:04:54 -07002442 def test_GerritCmdLand(self):
2443 self.calls += [
2444 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
2445 ((['git', 'config', 'branch.feature.gerritsquashhash'],),
2446 'deadbeaf'),
2447 ((['git', 'diff', 'deadbeaf'],), ''), # No diff.
2448 ((['git', 'config', 'branch.feature.gerritserver'],),
2449 'chromium-review.googlesource.com'),
2450 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002451 cl = git_cl.Changelist(issue=123)
Edward Lemur125d60a2019-09-13 18:25:41 +00002452 cl._GetChangeDetail = lambda *args, **kwargs: {
tandriic4344b52016-08-29 06:04:54 -07002453 'labels': {},
2454 'current_revision': 'deadbeaf',
2455 }
Edward Lemur125d60a2019-09-13 18:25:41 +00002456 cl._GetChangeCommit = lambda: {
agable32978d92016-11-01 12:55:02 -07002457 'commit': 'deadbeef',
Aaron Gable02cdbb42016-12-13 16:24:25 -08002458 'web_links': [{'name': 'gitiles',
agable32978d92016-11-01 12:55:02 -07002459 'url': 'https://git.googlesource.com/test/+/deadbeef'}],
2460 }
Edward Lemur125d60a2019-09-13 18:25:41 +00002461 cl.SubmitIssue = lambda wait_for_merge: None
tandrii8da412c2016-09-07 16:01:07 -07002462 out = StringIO.StringIO()
2463 self.mock(sys, 'stdout', out)
Olivier Robin75ee7252018-04-13 10:02:56 +02002464 self.assertEqual(0, cl.CMDLand(force=True,
2465 bypass_hooks=True,
2466 verbose=True,
2467 parallel=False))
tandrii8da412c2016-09-07 16:01:07 -07002468 self.assertRegexpMatches(out.getvalue(), 'Issue.*123 has been submitted')
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002469 self.assertRegexpMatches(out.getvalue(), 'Landed as: .*deadbeef')
tandriic4344b52016-08-29 06:04:54 -07002470
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002471 def _mock_gerrit_changes_for_detail_cache(self):
Edward Lemur125d60a2019-09-13 18:25:41 +00002472 self.mock(git_cl.Changelist, '_GetGerritHost', lambda _: 'host')
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002473
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002474 def test_gerrit_change_detail_cache_simple(self):
2475 self._mock_gerrit_changes_for_detail_cache()
2476 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002477 (('GetChangeDetail', 'host', 'my%2Frepo~1', []), 'a'),
2478 (('GetChangeDetail', 'host', 'ab%2Frepo~2', []), 'b'),
2479 (('GetChangeDetail', 'host', 'ab%2Frepo~2', []), 'b2'),
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002480 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002481 cl1 = git_cl.Changelist(issue=1)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002482 cl1._cached_remote_url = (
2483 True, 'https://chromium.googlesource.com/a/my/repo.git/')
Edward Lemurf38bc172019-09-03 21:02:13 +00002484 cl2 = git_cl.Changelist(issue=2)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002485 cl2._cached_remote_url = (
2486 True, 'https://chromium.googlesource.com/ab/repo')
Andrii Shyshkalovb7214602018-08-22 23:20:26 +00002487 self.assertEqual(cl1._GetChangeDetail(), 'a') # Miss.
2488 self.assertEqual(cl1._GetChangeDetail(), 'a')
2489 self.assertEqual(cl2._GetChangeDetail(), 'b') # Miss.
2490 self.assertEqual(cl2._GetChangeDetail(no_cache=True), 'b2') # Miss.
2491 self.assertEqual(cl1._GetChangeDetail(), 'a')
2492 self.assertEqual(cl2._GetChangeDetail(), 'b2')
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002493
2494 def test_gerrit_change_detail_cache_options(self):
2495 self._mock_gerrit_changes_for_detail_cache()
2496 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002497 (('GetChangeDetail', 'host', 'repo~1', ['C', 'A', 'B']), 'cab'),
2498 (('GetChangeDetail', 'host', 'repo~1', ['A', 'D']), 'ad'),
2499 (('GetChangeDetail', 'host', 'repo~1', ['A']), 'a'), # no_cache=True
2500 # no longer in cache.
2501 (('GetChangeDetail', 'host', 'repo~1', ['B']), 'b'),
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002502 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002503 cl = git_cl.Changelist(issue=1)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002504 cl._cached_remote_url = (True, 'https://chromium.googlesource.com/repo/')
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002505 self.assertEqual(cl._GetChangeDetail(options=['C', 'A', 'B']), 'cab')
2506 self.assertEqual(cl._GetChangeDetail(options=['A', 'B', 'C']), 'cab')
2507 self.assertEqual(cl._GetChangeDetail(options=['B', 'A']), 'cab')
2508 self.assertEqual(cl._GetChangeDetail(options=['C']), 'cab')
2509 self.assertEqual(cl._GetChangeDetail(options=['A']), 'cab')
2510 self.assertEqual(cl._GetChangeDetail(), 'cab')
2511
2512 self.assertEqual(cl._GetChangeDetail(options=['A', 'D']), 'ad')
2513 self.assertEqual(cl._GetChangeDetail(options=['A']), 'cab')
2514 self.assertEqual(cl._GetChangeDetail(options=['D']), 'ad')
2515 self.assertEqual(cl._GetChangeDetail(), 'cab')
2516
2517 # Finally, no_cache should invalidate all caches for given change.
2518 self.assertEqual(cl._GetChangeDetail(options=['A'], no_cache=True), 'a')
2519 self.assertEqual(cl._GetChangeDetail(options=['B']), 'b')
2520
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002521 def test_gerrit_description_caching(self):
2522 def gen_detail(rev, desc):
2523 return {
2524 'current_revision': rev,
2525 'revisions': {rev: {'commit': {'message': desc}}}
2526 }
2527 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002528 (('GetChangeDetail', 'host', 'my%2Frepo~1',
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002529 ['CURRENT_REVISION', 'CURRENT_COMMIT']),
2530 gen_detail('rev1', 'desc1')),
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002531 (('GetChangeDetail', 'host', 'my%2Frepo~1',
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002532 ['CURRENT_REVISION', 'CURRENT_COMMIT']),
2533 gen_detail('rev2', 'desc2')),
2534 ]
2535
2536 self._mock_gerrit_changes_for_detail_cache()
Edward Lemurf38bc172019-09-03 21:02:13 +00002537 cl = git_cl.Changelist(issue=1)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002538 cl._cached_remote_url = (
2539 True, 'https://chromium.googlesource.com/a/my/repo.git/')
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002540 self.assertEqual(cl.GetDescription(), 'desc1')
2541 self.assertEqual(cl.GetDescription(), 'desc1') # cache hit.
2542 self.assertEqual(cl.GetDescription(force=True), 'desc2')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002543
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002544 def test_print_current_creds(self):
2545 class CookiesAuthenticatorMock(object):
2546 def __init__(self):
2547 self.gitcookies = {
2548 'host.googlesource.com': ('user', 'pass'),
2549 'host-review.googlesource.com': ('user', 'pass'),
2550 }
2551 self.netrc = self
2552 self.netrc.hosts = {
2553 'github.com': ('user2', None, 'pass2'),
2554 'host2.googlesource.com': ('user3', None, 'pass'),
2555 }
2556 self.mock(git_cl.gerrit_util, 'CookiesAuthenticator',
2557 CookiesAuthenticatorMock)
2558 self.mock(sys, 'stdout', StringIO.StringIO())
2559 git_cl._GitCookiesChecker().print_current_creds(include_netrc=True)
2560 self.assertEqual(list(sys.stdout.getvalue().splitlines()), [
2561 ' Host\t User\t Which file',
2562 '============================\t=====\t===========',
2563 'host-review.googlesource.com\t user\t.gitcookies',
2564 ' host.googlesource.com\t user\t.gitcookies',
2565 ' host2.googlesource.com\tuser3\t .netrc',
2566 ])
2567 sys.stdout.buf = ''
2568 git_cl._GitCookiesChecker().print_current_creds(include_netrc=False)
2569 self.assertEqual(list(sys.stdout.getvalue().splitlines()), [
2570 ' Host\tUser\t Which file',
2571 '============================\t====\t===========',
2572 'host-review.googlesource.com\tuser\t.gitcookies',
2573 ' host.googlesource.com\tuser\t.gitcookies',
2574 ])
2575
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002576 def _common_creds_check_mocks(self):
2577 def exists_mock(path):
2578 dirname = os.path.dirname(path)
2579 if dirname == os.path.expanduser('~'):
2580 dirname = '~'
2581 base = os.path.basename(path)
2582 if base in ('.netrc', '.gitcookies'):
2583 return self._mocked_call('os.path.exists', '%s/%s' % (dirname, base))
2584 # git cl also checks for existence other files not relevant to this test.
2585 return None
2586 self.mock(os.path, 'exists', exists_mock)
2587 self.mock(sys, 'stdout', StringIO.StringIO())
2588
2589 def test_creds_check_gitcookies_not_configured(self):
2590 self._common_creds_check_mocks()
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002591 self.mock(git_cl._GitCookiesChecker, 'get_hosts_with_creds',
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01002592 lambda _, include_netrc=False: [])
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002593 self.calls = [
Aaron Gable8797cab2018-03-06 13:55:00 -08002594 ((['git', 'config', '--path', 'http.cookiefile'],), CERR1),
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002595 ((['git', 'config', '--global', 'http.cookiefile'],), CERR1),
2596 (('os.path.exists', '~/.netrc'), True),
2597 (('ask_for_data', 'Press Enter to setup .gitcookies, '
2598 'or Ctrl+C to abort'), ''),
2599 ((['git', 'config', '--global', 'http.cookiefile',
2600 os.path.expanduser('~/.gitcookies')], ), ''),
2601 ]
2602 self.assertEqual(0, git_cl.main(['creds-check']))
2603 self.assertRegexpMatches(
2604 sys.stdout.getvalue(),
2605 '^You seem to be using outdated .netrc for git credentials:')
2606 self.assertRegexpMatches(
2607 sys.stdout.getvalue(),
2608 '\nConfigured git to use .gitcookies from')
2609
2610 def test_creds_check_gitcookies_configured_custom_broken(self):
2611 self._common_creds_check_mocks()
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002612 self.mock(git_cl._GitCookiesChecker, 'get_hosts_with_creds',
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01002613 lambda _, include_netrc=False: [])
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002614 self.calls = [
Aaron Gable8797cab2018-03-06 13:55:00 -08002615 ((['git', 'config', '--path', 'http.cookiefile'],), CERR1),
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002616 ((['git', 'config', '--global', 'http.cookiefile'],),
2617 '/custom/.gitcookies'),
2618 (('os.path.exists', '/custom/.gitcookies'), False),
2619 (('ask_for_data', 'Reconfigure git to use default .gitcookies? '
2620 'Press Enter to reconfigure, or Ctrl+C to abort'), ''),
2621 ((['git', 'config', '--global', 'http.cookiefile',
2622 os.path.expanduser('~/.gitcookies')], ), ''),
2623 ]
2624 self.assertEqual(0, git_cl.main(['creds-check']))
2625 self.assertRegexpMatches(
2626 sys.stdout.getvalue(),
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002627 'WARNING: You have configured custom path to .gitcookies: ')
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002628 self.assertRegexpMatches(
2629 sys.stdout.getvalue(),
2630 'However, your configured .gitcookies file is missing.')
2631
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002632 def test_git_cl_comment_add_gerrit(self):
2633 self.mock(git_cl.gerrit_util, 'SetReview',
Aaron Gable636b13f2017-07-14 10:42:48 -07002634 lambda host, change, msg, ready:
2635 self._mocked_call('SetReview', host, change, msg, ready))
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002636 self.calls = [
2637 ((['git', 'symbolic-ref', 'HEAD'],), CERR1),
2638 ((['git', 'symbolic-ref', 'HEAD'],), CERR1),
2639 ((['git', 'config', 'rietveld.upstream-branch'],), CERR1),
2640 ((['git', 'branch', '-r'],), 'origin/HEAD -> origin/master\n'
2641 'origin/master'),
2642 ((['git', 'config', 'remote.origin.url'],),
2643 'https://chromium.googlesource.com/infra/infra'),
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002644 (('SetReview', 'chromium-review.googlesource.com', 'infra%2Finfra~10',
2645 'msg', None),
Aaron Gable636b13f2017-07-14 10:42:48 -07002646 None),
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002647 ]
2648 self.assertEqual(0, git_cl.main(['comment', '--gerrit', '-i', '10',
2649 '-a', 'msg']))
2650
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002651 def test_git_cl_comments_fetch_gerrit(self):
2652 self.mock(sys, 'stdout', StringIO.StringIO())
2653 self.calls = [
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002654 ((['git', 'config', 'branch.foo.gerritserver'],), ''),
2655 ((['git', 'config', 'branch.foo.merge'],), ''),
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002656 ((['git', 'config', 'rietveld.upstream-branch'],), CERR1),
2657 ((['git', 'branch', '-r'],), 'origin/HEAD -> origin/master\n'
2658 'origin/master'),
2659 ((['git', 'config', 'remote.origin.url'],),
2660 'https://chromium.googlesource.com/infra/infra'),
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002661 (('GetChangeDetail', 'chromium-review.googlesource.com',
2662 'infra%2Finfra~1',
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002663 ['MESSAGES', 'DETAILED_ACCOUNTS', 'CURRENT_REVISION',
2664 'CURRENT_COMMIT']), {
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002665 'owner': {'email': 'owner@example.com'},
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002666 'current_revision': 'ba5eba11',
2667 'revisions': {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002668 'deadbeaf': {
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002669 '_number': 1,
2670 },
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002671 'ba5eba11': {
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002672 '_number': 2,
2673 },
2674 },
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002675 'messages': [
2676 {
2677 u'_revision_number': 1,
2678 u'author': {
2679 u'_account_id': 1111084,
2680 u'email': u'commit-bot@chromium.org',
2681 u'name': u'Commit Bot'
2682 },
2683 u'date': u'2017-03-15 20:08:45.000000000',
2684 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046dc50b',
Dirk Prankef6a58802017-10-17 12:49:42 -07002685 u'message': u'Patch Set 1:\n\nDry run: CQ is trying the patch...',
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002686 u'tag': u'autogenerated:cq:dry-run'
2687 },
2688 {
2689 u'_revision_number': 2,
2690 u'author': {
2691 u'_account_id': 11151243,
2692 u'email': u'owner@example.com',
2693 u'name': u'owner'
2694 },
2695 u'date': u'2017-03-16 20:00:41.000000000',
2696 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2697 u'message': u'PTAL',
2698 },
2699 {
2700 u'_revision_number': 2,
2701 u'author': {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002702 u'_account_id': 148512,
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002703 u'email': u'reviewer@example.com',
2704 u'name': u'reviewer'
2705 },
2706 u'date': u'2017-03-17 05:19:37.500000000',
2707 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d4568',
2708 u'message': u'Patch Set 2: Code-Review+1',
2709 },
2710 ]
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002711 }),
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002712 (('GetChangeComments', 'chromium-review.googlesource.com',
2713 'infra%2Finfra~1'), {
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002714 '/COMMIT_MSG': [
2715 {
2716 'author': {'email': u'reviewer@example.com'},
2717 'updated': u'2017-03-17 05:19:37.500000000',
2718 'patch_set': 2,
2719 'side': 'REVISION',
2720 'message': 'Please include a bug link',
2721 },
2722 ],
2723 'codereview.settings': [
2724 {
2725 'author': {'email': u'owner@example.com'},
2726 'updated': u'2017-03-16 20:00:41.000000000',
2727 'patch_set': 2,
2728 'side': 'PARENT',
2729 'line': 42,
2730 'message': 'I removed this because it is bad',
2731 },
2732 ]
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002733 }),
2734 (('GetChangeRobotComments', 'chromium-review.googlesource.com',
2735 'infra%2Finfra~1'), {}),
2736 ((['git', 'config', 'branch.foo.gerritpatchset', '2'],), ''),
Leszek Swirski45b20c42018-09-17 17:05:26 +00002737 ] * 2 + [
2738 (('write_json', 'output.json', [
2739 {
2740 u'date': u'2017-03-16 20:00:41.000000',
2741 u'message': (
2742 u'PTAL\n' +
2743 u'\n' +
2744 u'codereview.settings\n' +
2745 u' Base, Line 42: https://chromium-review.googlesource.com/' +
2746 u'c/1/2/codereview.settings#b42\n' +
2747 u' I removed this because it is bad\n'),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002748 u'autogenerated': False,
Leszek Swirski45b20c42018-09-17 17:05:26 +00002749 u'approval': False,
2750 u'disapproval': False,
2751 u'sender': u'owner@example.com'
2752 }, {
2753 u'date': u'2017-03-17 05:19:37.500000',
2754 u'message': (
2755 u'Patch Set 2: Code-Review+1\n' +
2756 u'\n' +
2757 u'/COMMIT_MSG\n' +
2758 u' PS2, File comment: https://chromium-review.googlesource' +
2759 u'.com/c/1/2//COMMIT_MSG#\n' +
2760 u' Please include a bug link\n'),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002761 u'autogenerated': False,
Leszek Swirski45b20c42018-09-17 17:05:26 +00002762 u'approval': False,
2763 u'disapproval': False,
2764 u'sender': u'reviewer@example.com'
2765 }
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002766 ]), '')
Leszek Swirski45b20c42018-09-17 17:05:26 +00002767 ]
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002768 expected_comments_summary = [
2769 git_cl._CommentSummary(
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002770 message=(
2771 u'PTAL\n' +
2772 u'\n' +
2773 u'codereview.settings\n' +
2774 u' Base, Line 42: https://chromium-review.googlesource.com/' +
2775 u'c/1/2/codereview.settings#b42\n' +
2776 u' I removed this because it is bad\n'),
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002777 date=datetime.datetime(2017, 3, 16, 20, 0, 41, 0),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002778 autogenerated=False,
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002779 disapproval=False, approval=False, sender=u'owner@example.com'),
2780 git_cl._CommentSummary(
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002781 message=(
2782 u'Patch Set 2: Code-Review+1\n' +
2783 u'\n' +
2784 u'/COMMIT_MSG\n' +
2785 u' PS2, File comment: https://chromium-review.googlesource.com/' +
2786 u'c/1/2//COMMIT_MSG#\n' +
2787 u' Please include a bug link\n'),
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002788 date=datetime.datetime(2017, 3, 17, 5, 19, 37, 500000),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002789 autogenerated=False,
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002790 disapproval=False, approval=False, sender=u'reviewer@example.com'),
2791 ]
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002792 cl = git_cl.Changelist(
Edward Lemurf38bc172019-09-03 21:02:13 +00002793 issue=1, branchref='refs/heads/foo')
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002794 self.assertEqual(cl.GetCommentsSummary(), expected_comments_summary)
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002795 self.mock(git_cl.Changelist, 'GetBranch', lambda _: 'foo')
2796 self.assertEqual(
2797 0, git_cl.main(['comments', '-i', '1', '-j', 'output.json']))
2798
2799 def test_git_cl_comments_robot_comments(self):
2800 # git cl comments also fetches robot comments (which are considered a type
2801 # of autogenerated comment), and unlike other types of comments, only robot
2802 # comments from the latest patchset are shown.
2803 self.mock(sys, 'stdout', StringIO.StringIO())
2804 self.calls = [
2805 ((['git', 'config', 'branch.foo.gerritserver'],), ''),
2806 ((['git', 'config', 'branch.foo.merge'],), ''),
2807 ((['git', 'config', 'rietveld.upstream-branch'],), CERR1),
2808 ((['git', 'branch', '-r'],), 'origin/HEAD -> origin/master\n'
2809 'origin/master'),
2810 ((['git', 'config', 'remote.origin.url'],),
2811 'https://chromium.googlesource.com/infra/infra'),
2812 (('GetChangeDetail', 'chromium-review.googlesource.com',
2813 'infra%2Finfra~1',
2814 ['MESSAGES', 'DETAILED_ACCOUNTS', 'CURRENT_REVISION',
2815 'CURRENT_COMMIT']), {
2816 'owner': {'email': 'owner@example.com'},
2817 'current_revision': 'ba5eba11',
2818 'revisions': {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002819 'deadbeaf': {
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002820 '_number': 1,
2821 },
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002822 'ba5eba11': {
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002823 '_number': 2,
2824 },
2825 },
2826 'messages': [
2827 {
2828 u'_revision_number': 1,
2829 u'author': {
2830 u'_account_id': 1111084,
2831 u'email': u'commit-bot@chromium.org',
2832 u'name': u'Commit Bot'
2833 },
2834 u'date': u'2017-03-15 20:08:45.000000000',
2835 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046dc50b',
2836 u'message': u'Patch Set 1:\n\nDry run: CQ is trying the patch...',
2837 u'tag': u'autogenerated:cq:dry-run'
2838 },
2839 {
2840 u'_revision_number': 1,
2841 u'author': {
2842 u'_account_id': 123,
2843 u'email': u'tricium@serviceaccount.com',
2844 u'name': u'Tricium'
2845 },
2846 u'date': u'2017-03-16 20:00:41.000000000',
2847 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2848 u'message': u'(1 comment)',
2849 u'tag': u'autogenerated:tricium',
2850 },
2851 {
2852 u'_revision_number': 1,
2853 u'author': {
2854 u'_account_id': 123,
2855 u'email': u'tricium@serviceaccount.com',
2856 u'name': u'Tricium'
2857 },
2858 u'date': u'2017-03-16 20:00:41.000000000',
2859 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2860 u'message': u'(1 comment)',
2861 u'tag': u'autogenerated:tricium',
2862 },
2863 {
2864 u'_revision_number': 2,
2865 u'author': {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002866 u'_account_id': 123,
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002867 u'email': u'tricium@serviceaccount.com',
2868 u'name': u'reviewer'
2869 },
2870 u'date': u'2017-03-17 05:30:37.000000000',
2871 u'tag': u'autogenerated:tricium',
2872 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d4568',
2873 u'message': u'(1 comment)',
2874 },
2875 ]
2876 }),
2877 (('GetChangeComments', 'chromium-review.googlesource.com',
2878 'infra%2Finfra~1'), {}),
2879 (('GetChangeRobotComments', 'chromium-review.googlesource.com',
2880 'infra%2Finfra~1'), {
2881 'codereview.settings': [
2882 {
2883 u'author': {u'email': u'tricium@serviceaccount.com'},
2884 u'updated': u'2017-03-17 05:30:37.000000000',
2885 u'robot_run_id': u'5565031076855808',
2886 u'robot_id': u'Linter/Category',
2887 u'tag': u'autogenerated:tricium',
2888 u'patch_set': 2,
2889 u'side': u'REVISION',
2890 u'message': u'Linter warning message text',
2891 u'line': 32,
2892 },
2893 ],
2894 }),
2895 ((['git', 'config', 'branch.foo.gerritpatchset', '2'],), ''),
2896 ]
2897 expected_comments_summary = [
2898 git_cl._CommentSummary(date=datetime.datetime(2017, 3, 17, 5, 30, 37),
2899 message=(
2900 u'(1 comment)\n\ncodereview.settings\n'
2901 u' PS2, Line 32: https://chromium-review.googlesource.com/'
2902 u'c/1/2/codereview.settings#32\n'
2903 u' Linter warning message text\n'),
2904 sender=u'tricium@serviceaccount.com',
2905 autogenerated=True, approval=False, disapproval=False)
2906 ]
2907 cl = git_cl.Changelist(
Edward Lemurf38bc172019-09-03 21:02:13 +00002908 issue=1, branchref='refs/heads/foo')
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002909 self.assertEqual(cl.GetCommentsSummary(), expected_comments_summary)
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002910
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002911 def test_get_remote_url_with_mirror(self):
2912 original_os_path_isdir = os.path.isdir
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002913
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002914 def selective_os_path_isdir_mock(path):
2915 if path == '/cache/this-dir-exists':
2916 return self._mocked_call('os.path.isdir', path)
2917 return original_os_path_isdir(path)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002918
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002919 self.mock(os.path, 'isdir', selective_os_path_isdir_mock)
2920
2921 url = 'https://chromium.googlesource.com/my/repo'
2922 self.calls = [
2923 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2924 ((['git', 'config', 'branch.master.merge'],), 'master'),
2925 ((['git', 'config', 'branch.master.remote'],), 'origin'),
2926 ((['git', 'config', 'remote.origin.url'],),
2927 '/cache/this-dir-exists'),
2928 (('os.path.isdir', '/cache/this-dir-exists'),
2929 True),
2930 # Runs in /cache/this-dir-exists.
2931 ((['git', 'config', 'remote.origin.url'],),
2932 url),
2933 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002934 cl = git_cl.Changelist(issue=1)
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002935 self.assertEqual(cl.GetRemoteUrl(), url)
2936 self.assertEqual(cl.GetRemoteUrl(), url) # Must be cached.
2937
Edward Lemur298f2cf2019-02-22 21:40:39 +00002938 def test_get_remote_url_non_existing_mirror(self):
2939 original_os_path_isdir = os.path.isdir
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002940
Edward Lemur298f2cf2019-02-22 21:40:39 +00002941 def selective_os_path_isdir_mock(path):
2942 if path == '/cache/this-dir-doesnt-exist':
2943 return self._mocked_call('os.path.isdir', path)
2944 return original_os_path_isdir(path)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002945
Edward Lemur298f2cf2019-02-22 21:40:39 +00002946 self.mock(os.path, 'isdir', selective_os_path_isdir_mock)
2947 self.mock(logging, 'error',
2948 lambda fmt, *a: self._mocked_call('logging.error', fmt % a))
2949
2950 self.calls = [
2951 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2952 ((['git', 'config', 'branch.master.merge'],), 'master'),
2953 ((['git', 'config', 'branch.master.remote'],), 'origin'),
2954 ((['git', 'config', 'remote.origin.url'],),
2955 '/cache/this-dir-doesnt-exist'),
2956 (('os.path.isdir', '/cache/this-dir-doesnt-exist'),
2957 False),
2958 (('logging.error',
Daniel Bratell4a60db42019-09-16 17:02:52 +00002959 'Remote "origin" for branch "master" points to'
2960 ' "/cache/this-dir-doesnt-exist", but it doesn\'t exist.'), None),
Edward Lemur298f2cf2019-02-22 21:40:39 +00002961 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002962 cl = git_cl.Changelist(issue=1)
Edward Lemur298f2cf2019-02-22 21:40:39 +00002963 self.assertIsNone(cl.GetRemoteUrl())
2964
2965 def test_get_remote_url_misconfigured_mirror(self):
2966 original_os_path_isdir = os.path.isdir
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002967
Edward Lemur298f2cf2019-02-22 21:40:39 +00002968 def selective_os_path_isdir_mock(path):
2969 if path == '/cache/this-dir-exists':
2970 return self._mocked_call('os.path.isdir', path)
2971 return original_os_path_isdir(path)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002972
Edward Lemur298f2cf2019-02-22 21:40:39 +00002973 self.mock(os.path, 'isdir', selective_os_path_isdir_mock)
2974 self.mock(logging, 'error',
2975 lambda *a: self._mocked_call('logging.error', *a))
2976
2977 self.calls = [
2978 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2979 ((['git', 'config', 'branch.master.merge'],), 'master'),
2980 ((['git', 'config', 'branch.master.remote'],), 'origin'),
2981 ((['git', 'config', 'remote.origin.url'],),
2982 '/cache/this-dir-exists'),
2983 (('os.path.isdir', '/cache/this-dir-exists'), True),
2984 # Runs in /cache/this-dir-exists.
2985 ((['git', 'config', 'remote.origin.url'],), ''),
2986 (('logging.error',
2987 'Remote "%(remote)s" for branch "%(branch)s" points to '
2988 '"%(cache_path)s", but it is misconfigured.\n'
2989 '"%(cache_path)s" must be a git repo and must have a remote named '
2990 '"%(remote)s" pointing to the git host.', {
2991 'remote': 'origin',
2992 'cache_path': '/cache/this-dir-exists',
2993 'branch': 'master'}
2994 ), None),
2995 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002996 cl = git_cl.Changelist(issue=1)
Edward Lemur298f2cf2019-02-22 21:40:39 +00002997 self.assertIsNone(cl.GetRemoteUrl())
2998
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002999 def test_gerrit_change_identifier_with_project(self):
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00003000 self.calls = [
3001 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
3002 ((['git', 'config', 'branch.master.merge'],), 'master'),
3003 ((['git', 'config', 'branch.master.remote'],), 'origin'),
3004 ((['git', 'config', 'remote.origin.url'],),
3005 'https://chromium.googlesource.com/a/my/repo.git/'),
3006 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00003007 cl = git_cl.Changelist(issue=123456)
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00003008 self.assertEqual(cl._GerritChangeIdentifier(), 'my%2Frepo~123456')
3009
3010 def test_gerrit_change_identifier_without_project(self):
3011 self.calls = [
3012 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
3013 ((['git', 'config', 'branch.master.merge'],), 'master'),
3014 ((['git', 'config', 'branch.master.remote'],), 'origin'),
3015 ((['git', 'config', 'remote.origin.url'],), CERR1),
3016 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00003017 cl = git_cl.Changelist(issue=123456)
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00003018 self.assertEqual(cl._GerritChangeIdentifier(), '123456')
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00003019
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003020
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003021class CMDTestCaseBase(unittest.TestCase):
3022 _STATUSES = [
3023 'STATUS_UNSPECIFIED', 'SCHEDULED', 'STARTED', 'SUCCESS', 'FAILURE',
3024 'INFRA_FAILURE', 'CANCELED',
3025 ]
3026 _CHANGE_DETAIL = {
3027 'project': 'depot_tools',
3028 'status': 'OPEN',
3029 'owner': {'email': 'owner@e.mail'},
3030 'current_revision': 'beeeeeef',
3031 'revisions': {
3032 'deadbeaf': {'_number': 6},
3033 'beeeeeef': {
3034 '_number': 7,
3035 'fetch': {'http': {
3036 'url': 'https://chromium.googlesource.com/depot_tools',
3037 'ref': 'refs/changes/56/123456/7'
3038 }},
3039 },
3040 },
3041 }
3042 _DEFAULT_RESPONSE = {
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003043 'builds': [{
3044 'id': str(100 + idx),
3045 'builder': {
3046 'project': 'chromium',
3047 'bucket': 'try',
3048 'builder': 'bot_' + status.lower(),
3049 },
3050 'createTime': '2019-10-09T08:00:0%d.854286Z' % (idx % 10),
3051 'tags': [],
3052 'status': status,
3053 } for idx, status in enumerate(_STATUSES)]
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003054 }
3055
Edward Lemur4c707a22019-09-24 21:13:43 +00003056 def setUp(self):
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003057 super(CMDTestCaseBase, self).setUp()
Edward Lemur4c707a22019-09-24 21:13:43 +00003058 mock.patch('git_cl.sys.stdout', StringIO.StringIO()).start()
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003059 mock.patch('git_cl.uuid.uuid4', return_value='uuid4').start()
3060 mock.patch('git_cl.Changelist.GetIssue', return_value=123456).start()
Edward Lemur4c707a22019-09-24 21:13:43 +00003061 mock.patch('git_cl.Changelist.GetCodereviewServer',
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003062 return_value='https://chromium-review.googlesource.com').start()
3063 mock.patch('git_cl.Changelist.GetMostRecentPatchset',
3064 return_value=7).start()
Edward Lemurb4a587d2019-10-09 23:56:38 +00003065 mock.patch('git_cl.auth.get_authenticator',
3066 return_value=AuthenticatorMock()).start()
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003067 mock.patch('git_cl.Changelist._GetChangeDetail',
3068 return_value=self._CHANGE_DETAIL).start()
3069 mock.patch('git_cl._call_buildbucket',
3070 return_value = self._DEFAULT_RESPONSE).start()
3071 mock.patch('git_common.is_dirty_git_tree', return_value=False).start()
Edward Lemur4c707a22019-09-24 21:13:43 +00003072 self.addCleanup(mock.patch.stopall)
3073
Edward Lemur4c707a22019-09-24 21:13:43 +00003074
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003075class CMDTryResultsTestCase(CMDTestCaseBase):
3076 _DEFAULT_REQUEST = {
3077 'predicate': {
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003078 "gerritChanges": [{
3079 "project": "depot_tools",
3080 "host": "chromium-review.googlesource.com",
3081 "patchset": 7,
3082 "change": 123456,
3083 }],
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003084 },
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003085 'fields': ('builds.*.id,builds.*.builder,builds.*.status' +
3086 ',builds.*.createTime,builds.*.tags'),
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003087 }
3088
3089 def testNoJobs(self):
3090 git_cl._call_buildbucket.return_value = {}
3091
3092 self.assertEqual(0, git_cl.main(['try-results']))
3093 self.assertEqual('No tryjobs scheduled.\n', sys.stdout.getvalue())
3094 git_cl._call_buildbucket.assert_called_once_with(
3095 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3096 self._DEFAULT_REQUEST)
3097
3098 def testPrintToStdout(self):
3099 self.assertEqual(0, git_cl.main(['try-results']))
3100 self.assertEqual([
3101 'Successes:',
3102 ' bot_success https://ci.chromium.org/b/103',
3103 'Infra Failures:',
3104 ' bot_infra_failure https://ci.chromium.org/b/105',
3105 'Failures:',
3106 ' bot_failure https://ci.chromium.org/b/104',
3107 'Canceled:',
3108 ' bot_canceled ',
3109 'Started:',
3110 ' bot_started https://ci.chromium.org/b/102',
3111 'Scheduled:',
3112 ' bot_scheduled id=101',
3113 'Other:',
3114 ' bot_status_unspecified id=100',
3115 'Total: 7 tryjobs',
3116 ], sys.stdout.getvalue().splitlines())
3117 git_cl._call_buildbucket.assert_called_once_with(
3118 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3119 self._DEFAULT_REQUEST)
3120
3121 def testPrintToStdoutWithMasters(self):
3122 self.assertEqual(0, git_cl.main(['try-results', '--print-master']))
3123 self.assertEqual([
3124 'Successes:',
3125 ' try bot_success https://ci.chromium.org/b/103',
3126 'Infra Failures:',
3127 ' try bot_infra_failure https://ci.chromium.org/b/105',
3128 'Failures:',
3129 ' try bot_failure https://ci.chromium.org/b/104',
3130 'Canceled:',
3131 ' try bot_canceled ',
3132 'Started:',
3133 ' try bot_started https://ci.chromium.org/b/102',
3134 'Scheduled:',
3135 ' try bot_scheduled id=101',
3136 'Other:',
3137 ' try bot_status_unspecified id=100',
3138 'Total: 7 tryjobs',
3139 ], sys.stdout.getvalue().splitlines())
3140 git_cl._call_buildbucket.assert_called_once_with(
3141 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3142 self._DEFAULT_REQUEST)
3143
3144 @mock.patch('git_cl.write_json')
3145 def testWriteToJson(self, mockJsonDump):
3146 self.assertEqual(0, git_cl.main(['try-results', '--json', 'file.json']))
3147 git_cl._call_buildbucket.assert_called_once_with(
3148 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3149 self._DEFAULT_REQUEST)
3150 mockJsonDump.assert_called_once_with(
3151 'file.json', self._DEFAULT_RESPONSE['builds'])
3152
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003153 def test_filter_failed_for_one_simple(self):
3154 self.assertEqual({}, git_cl._filter_failed_for_retry([]))
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003155 self.assertEqual({
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003156 'chromium/try': {
3157 'bot_failure': [],
3158 'bot_infra_failure': []
3159 },
3160 }, git_cl._filter_failed_for_retry(self._DEFAULT_RESPONSE['builds']))
3161
3162 def test_filter_failed_for_retry_many_builds(self):
3163
3164 def _build(name, created_sec, status, experimental=False):
3165 assert 0 <= created_sec < 100, created_sec
3166 b = {
3167 'id': 112112,
3168 'builder': {
3169 'project': 'chromium',
3170 'bucket': 'try',
3171 'builder': name,
3172 },
3173 'createTime': '2019-10-09T08:00:%02d.854286Z' % created_sec,
3174 'status': status,
3175 'tags': [],
3176 }
3177 if experimental:
3178 b['tags'].append({'key': 'cq_experimental', 'value': 'true'})
3179 return b
3180
3181 builds = [
3182 _build('flaky-last-green', 1, 'FAILURE'),
3183 _build('flaky-last-green', 2, 'SUCCESS'),
3184 _build('flaky', 1, 'SUCCESS'),
3185 _build('flaky', 2, 'FAILURE'),
3186 _build('running', 1, 'FAILED'),
3187 _build('running', 2, 'SCHEDULED'),
3188 _build('yep-still-running', 1, 'STARTED'),
3189 _build('yep-still-running', 2, 'FAILURE'),
3190 _build('cq-experimental', 1, 'SUCCESS', experimental=True),
3191 _build('cq-experimental', 2, 'FAILURE', experimental=True),
3192
3193 # Simulate experimental in CQ builder, which developer decided
3194 # to retry manually which resulted in 2nd build non-experimental.
3195 _build('sometimes-experimental', 1, 'FAILURE', experimental=True),
3196 _build('sometimes-experimental', 2, 'FAILURE', experimental=False),
3197 ]
3198 builds.sort(key=lambda b: b['status']) # ~deterministic shuffle.
3199 self.assertEqual({
3200 'chromium/try': {
3201 'flaky': [],
3202 'sometimes-experimental': []
3203 },
3204 }, git_cl._filter_failed_for_retry(builds))
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003205
3206
3207class CMDTryTestCase(CMDTestCaseBase):
3208
3209 @mock.patch('git_cl.Changelist.SetCQState')
3210 @mock.patch('git_cl._get_bucket_map', return_value={})
3211 def testSetCQDryRunByDefault(self, _mockGetBucketMap, mockSetCQState):
3212 mockSetCQState.return_value = 0
Edward Lemur4c707a22019-09-24 21:13:43 +00003213 self.assertEqual(0, git_cl.main(['try']))
3214 git_cl.Changelist.SetCQState.assert_called_with(git_cl._CQState.DRY_RUN)
3215 self.assertEqual(
3216 sys.stdout.getvalue(),
3217 'Scheduling CQ dry run on: '
3218 'https://chromium-review.googlesource.com/123456\n')
3219
Edward Lemur4c707a22019-09-24 21:13:43 +00003220 @mock.patch('git_cl._call_buildbucket')
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003221 def testScheduleOnBuildbucket(self, mockCallBuildbucket):
Edward Lemur4c707a22019-09-24 21:13:43 +00003222 mockCallBuildbucket.return_value = {}
Edward Lemur4c707a22019-09-24 21:13:43 +00003223
3224 self.assertEqual(0, git_cl.main([
3225 'try', '-B', 'luci.chromium.try', '-b', 'win',
3226 '-p', 'key=val', '-p', 'json=[{"a":1}, null]']))
3227 self.assertIn(
3228 'Scheduling jobs on:\nBucket: luci.chromium.try',
3229 git_cl.sys.stdout.getvalue())
3230
3231 expected_request = {
3232 "requests": [{
3233 "scheduleBuild": {
3234 "requestId": "uuid4",
3235 "builder": {
3236 "project": "chromium",
3237 "builder": "win",
3238 "bucket": "try",
3239 },
3240 "gerritChanges": [{
3241 "project": "depot_tools",
3242 "host": "chromium-review.googlesource.com",
3243 "patchset": 7,
3244 "change": 123456,
3245 }],
3246 "properties": {
3247 "category": "git_cl_try",
3248 "json": [{"a": 1}, None],
3249 "key": "val",
3250 },
3251 "tags": [
3252 {"value": "win", "key": "builder"},
3253 {"value": "git_cl_try", "key": "user_agent"},
3254 ],
3255 },
3256 }],
3257 }
3258 mockCallBuildbucket.assert_called_with(
3259 mock.ANY, 'cr-buildbucket.appspot.com', 'Batch', expected_request)
3260
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003261 def testScheduleOnBuildbucket_WrongBucket(self):
Edward Lemur4c707a22019-09-24 21:13:43 +00003262 self.assertEqual(0, git_cl.main([
3263 'try', '-B', 'not-a-bucket', '-b', 'win',
3264 '-p', 'key=val', '-p', 'json=[{"a":1}, null]']))
3265 self.assertIn(
3266 'WARNING Could not parse bucket "not-a-bucket". Skipping.',
3267 git_cl.sys.stdout.getvalue())
3268
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003269 @mock.patch('git_cl._call_buildbucket')
3270 @mock.patch('git_cl.fetch_try_jobs')
3271 def testScheduleOnBuildbucketRetryFailed(
3272 self, mockFetchTryJobs, mockCallBuildbucket):
3273
3274 git_cl.fetch_try_jobs.side_effect = lambda *_, **kw: {
3275 7: [],
3276 6: [{
3277 'id': 112112,
3278 'builder': {
3279 'project': 'chromium',
3280 'bucket': 'try',
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003281 'builder': 'linux',},
3282 'createTime': '2019-10-09T08:00:01.854286Z',
3283 'tags': [],
3284 'status': 'FAILURE',}],}[kw['patchset']]
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003285 mockCallBuildbucket.return_value = {}
3286
3287 self.assertEqual(0, git_cl.main(['try', '--retry-failed']))
3288 self.assertIn(
3289 'Scheduling jobs on:\nBucket: chromium/try',
3290 git_cl.sys.stdout.getvalue())
3291
3292 expected_request = {
3293 "requests": [{
3294 "scheduleBuild": {
3295 "requestId": "uuid4",
3296 "builder": {
3297 "project": "chromium",
3298 "bucket": "try",
3299 "builder": "linux",
3300 },
3301 "gerritChanges": [{
3302 "project": "depot_tools",
3303 "host": "chromium-review.googlesource.com",
3304 "patchset": 7,
3305 "change": 123456,
3306 }],
3307 "properties": {
3308 "category": "git_cl_try",
3309 },
3310 "tags": [
3311 {"value": "linux", "key": "builder"},
3312 {"value": "git_cl_try", "key": "user_agent"},
3313 {"value": "1", "key": "retry_failed"},
3314 ],
3315 },
3316 }],
3317 }
3318 mockCallBuildbucket.assert_called_with(
3319 mock.ANY, 'cr-buildbucket.appspot.com', 'Batch', expected_request)
3320
Edward Lemur4c707a22019-09-24 21:13:43 +00003321 def test_parse_bucket(self):
3322 test_cases = [
3323 {
3324 'bucket': 'chromium/try',
3325 'result': ('chromium', 'try'),
3326 },
3327 {
3328 'bucket': 'luci.chromium.try',
3329 'result': ('chromium', 'try'),
3330 'has_warning': True,
3331 },
3332 {
3333 'bucket': 'skia.primary',
3334 'result': ('skia', 'skia.primary'),
3335 'has_warning': True,
3336 },
3337 {
3338 'bucket': 'not-a-bucket',
3339 'result': (None, None),
3340 },
3341 ]
3342
3343 for test_case in test_cases:
3344 git_cl.sys.stdout.truncate(0)
3345 self.assertEqual(
3346 test_case['result'], git_cl._parse_bucket(test_case['bucket']))
3347 if test_case.get('has_warning'):
Edward Lemur6215c792019-10-03 21:59:05 +00003348 expected_warning = 'WARNING Please use %s/%s to specify the bucket' % (
3349 test_case['result'])
3350 self.assertIn(expected_warning, git_cl.sys.stdout.getvalue())
Edward Lemur4c707a22019-09-24 21:13:43 +00003351
3352
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003353class CMDUploadTestCase(CMDTestCaseBase):
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003354 def setUp(self):
3355 super(CMDUploadTestCase, self).setUp()
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003356 mock.patch('git_cl.fetch_try_jobs').start()
3357 mock.patch('git_cl._trigger_try_jobs', return_value={}).start()
3358 mock.patch('git_cl.Changelist.CMDUpload', return_value=0).start()
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003359 self.addCleanup(mock.patch.stopall)
3360
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003361 def testUploadRetryFailed(self):
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003362 # This test mocks out the actual upload part, and just asserts that after
3363 # upload, if --retry-failed is added, then the tool will fetch try jobs
3364 # from the previous patchset and trigger the right builders on the latest
3365 # patchset.
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003366 git_cl.fetch_try_jobs.side_effect = [
3367 # Latest patchset: No builds.
3368 [],
3369 # Patchset before latest: Some builds.
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003370 [{
3371 'id': str(100 + idx),
3372 'builder': {
3373 'project': 'chromium',
3374 'bucket': 'try',
3375 'builder': 'bot_' + status.lower(),
3376 },
3377 'createTime': '2019-10-09T08:00:0%d.854286Z' % (idx % 10),
3378 'tags': [],
3379 'status': status,
3380 } for idx, status in enumerate(self._STATUSES)],
Andrii Shyshkalov1ad58112019-10-08 01:46:14 +00003381 ]
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003382
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003383 self.assertEqual(0, git_cl.main(['upload', '--retry-failed']))
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003384 self.assertEqual([
Andrii Shyshkalov1ad58112019-10-08 01:46:14 +00003385 mock.call(mock.ANY, mock.ANY, 'cr-buildbucket.appspot.com', patchset=7),
3386 mock.call(mock.ANY, mock.ANY, 'cr-buildbucket.appspot.com', patchset=6),
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003387 ], git_cl.fetch_try_jobs.mock_calls)
3388 expected_buckets = {
3389 'chromium/try': {'bot_failure': [], 'bot_infra_failure': []},
3390 }
3391 git_cl._trigger_try_jobs.assert_called_once_with(
3392 mock.ANY, mock.ANY, expected_buckets, mock.ANY, 8)
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003393
Brian Sheedy59b06a82019-10-14 17:03:29 +00003394
3395class CMDFormatTestCase(TestCase):
3396
3397 def setUp(self):
3398 super(CMDFormatTestCase, self).setUp()
3399 self._top_dir = tempfile.mkdtemp()
3400
3401 def tearDown(self):
3402 shutil.rmtree(self._top_dir)
3403 super(CMDFormatTestCase, self).tearDown()
3404
3405 def _make_yapfignore(self, contents):
3406 with open(os.path.join(self._top_dir, '.yapfignore'), 'w') as yapfignore:
3407 yapfignore.write('\n'.join(contents))
3408
3409 def _make_files(self, file_dict):
3410 for directory, files in file_dict.iteritems():
3411 subdir = os.path.join(self._top_dir, directory)
3412 if not os.path.exists(subdir):
3413 os.makedirs(subdir)
3414 for f in files:
3415 with open(os.path.join(subdir, f), 'w'):
3416 pass
3417
3418 def testYapfignoreBasic(self):
3419 self._make_yapfignore(['test.py', '*/bar.py'])
3420 self._make_files({
3421 '.': ['test.py', 'bar.py'],
3422 'foo': ['bar.py'],
3423 })
3424 self.assertEqual(
3425 set(['test.py', 'foo/bar.py']),
3426 git_cl._GetYapfIgnoreFilepaths(self._top_dir))
3427
3428 def testYapfignoreMissingYapfignore(self):
3429 self.assertEqual(set(), git_cl._GetYapfIgnoreFilepaths(self._top_dir))
3430
3431 def testYapfignoreMissingFile(self):
3432 self._make_yapfignore(['test.py', 'test2.py', 'test3.py'])
3433 self._make_files({
3434 '.': ['test.py', 'test3.py'],
3435 })
3436 self.assertEqual(
3437 set(['test.py', 'test3.py']),
3438 git_cl._GetYapfIgnoreFilepaths(self._top_dir))
3439
3440 def testYapfignoreComments(self):
3441 self._make_yapfignore(['test.py', '#test2.py'])
3442 self._make_files({
3443 '.': ['test.py', 'test2.py'],
3444 })
3445 self.assertEqual(
3446 set(['test.py']), git_cl._GetYapfIgnoreFilepaths(self._top_dir))
3447
3448 def testYapfignoreBlankLines(self):
3449 self._make_yapfignore(['test.py', '', '', 'test2.py'])
3450 self._make_files({'.': ['test.py', 'test2.py']})
3451 self.assertEqual(
3452 set(['test.py', 'test2.py']),
3453 git_cl._GetYapfIgnoreFilepaths(self._top_dir))
3454
3455 def testYapfignoreWhitespace(self):
3456 self._make_yapfignore([' test.py '])
3457 self._make_files({'.': ['test.py']})
3458 self.assertEqual(
3459 set(['test.py']), git_cl._GetYapfIgnoreFilepaths(self._top_dir))
3460
3461 def testYapfignoreMultiWildcard(self):
3462 self._make_yapfignore(['*es*.py'])
3463 self._make_files({
3464 '.': ['test.py', 'test2.py'],
3465 })
3466 self.assertEqual(
3467 set(['test.py', 'test2.py']),
3468 git_cl._GetYapfIgnoreFilepaths(self._top_dir))
3469
3470 def testYapfignoreRestoresDirectory(self):
3471 self._make_yapfignore(['test.py'])
3472 self._make_files({
3473 '.': ['test.py'],
3474 })
3475 old_cwd = os.getcwd()
3476 self.assertEqual(
3477 set(['test.py']), git_cl._GetYapfIgnoreFilepaths(self._top_dir))
3478 self.assertEqual(old_cwd, os.getcwd())
3479
3480
maruel@chromium.orgddd59412011-11-30 14:20:38 +00003481if __name__ == '__main__':
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +01003482 logging.basicConfig(
3483 level=logging.DEBUG if '-v' in sys.argv else logging.ERROR)
maruel@chromium.orgddd59412011-11-30 14:20:38 +00003484 unittest.main()