blob: 3c5c822d385643d824539fecbb0eaa104b75e578 [file] [log] [blame]
Josip Sokcevic4de5dea2022-03-23 21:15:14 +00001#!/usr/bin/env python3
maruel@chromium.org3bbf2942012-01-10 16:52:06 +00002# Copyright (c) 2012 The Chromium Authors. All rights reserved.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00003# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5
6"""Enables directory-specific presubmit checks to run at upload and/or commit.
7"""
8
Raul Tambre80ee78e2019-05-06 22:41:05 +00009from __future__ import print_function
10
Saagar Sanghavi99816902020-08-11 22:41:25 +000011__version__ = '2.0.0'
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000012
13# TODO(joi) Add caching where appropriate/needed. The API is designed to allow
14# caching (between all different invocations of presubmit scripts for a given
15# change). We should add it as our presubmit scripts start feeling slow.
16
Edward Lemura5799e32020-01-17 19:26:51 +000017import argparse
Takeshi Yoshino07a6bea2017-08-02 02:44:06 +090018import ast # Exposed through the API.
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +000019import contextlib
Yoshisato Yanagisawa406de132018-06-29 05:43:25 +000020import cpplint
dcheng091b7db2016-06-16 01:27:51 -070021import fnmatch # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000022import glob
asvitkine@chromium.org15169952011-09-27 14:30:53 +000023import inspect
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +000024import itertools
maruel@chromium.org4f6852c2012-04-20 20:39:20 +000025import json # Exposed through the API.
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +000026import logging
ilevy@chromium.orgbc117312013-04-20 03:57:56 +000027import multiprocessing
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000028import os # Somewhat exposed through the API.
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +000029import random
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000030import re # Exposed through the API.
Edward Lesmes8e282792018-04-03 18:50:29 -040031import signal
Allen Webbfe7d7092021-05-18 02:05:49 +000032import six
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000033import sys # Parts exposed through API.
34import tempfile # Exposed through the API.
Edward Lesmes8e282792018-04-03 18:50:29 -040035import threading
jam@chromium.org2a891dc2009-08-20 20:33:37 +000036import time
Edward Lemurde9e3ca2019-10-24 21:13:31 +000037import traceback
maruel@chromium.org1487d532009-06-06 00:22:57 +000038import unittest # Exposed through the API.
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +000039from warnings import warn
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000040
41# Local imports.
maruel@chromium.org35625c72011-03-23 17:34:02 +000042import fix_encoding
Yoshisato Yanagisawa04600b42019-03-15 03:03:41 +000043import gclient_paths # Exposed through the API
44import gclient_utils
Josip Sokcevic7958e302023-03-01 23:02:21 +000045import git_footers
tandrii@chromium.org015ebae2016-04-25 19:37:22 +000046import gerrit_util
Edward Lesmes9ce03f82021-01-12 20:13:31 +000047import owners_client
Jochen Eisinger76f5fc62017-04-07 16:27:46 +020048import owners_finder
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000049import presubmit_canned_checks
Saagar Sanghavi9949ab72020-07-20 20:56:40 +000050import rdb_wrapper
Josip Sokcevic7958e302023-03-01 23:02:21 +000051import scm
maruel@chromium.org84f4fe32011-04-06 13:26:45 +000052import subprocess2 as subprocess # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000053
Edward Lemur16af3562019-10-17 22:11:33 +000054if sys.version_info.major == 2:
55 # TODO(1009814): Expose urllib2 only through urllib_request and urllib_error
56 import urllib2 # Exposed through the API.
57 import urlparse
58 import urllib2 as urllib_request
59 import urllib2 as urllib_error
60else:
61 import urllib.parse as urlparse
62 import urllib.request as urllib_request
63 import urllib.error as urllib_error
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000064
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +000065# Ask for feedback only once in program lifetime.
66_ASKED_FOR_FEEDBACK = False
67
Bruce Dawsondca14bc2022-09-15 20:59:38 +000068# Set if super-verbose mode is requested, for tracking where presubmit messages
69# are coming from.
70_SHOW_CALLSTACKS = False
71
72
Edward Lemurecc27072020-01-06 16:42:34 +000073def time_time():
74 # Use this so that it can be mocked in tests without interfering with python
75 # system machinery.
76 return time.time()
77
78
maruel@chromium.org899e1c12011-04-07 17:03:18 +000079class PresubmitFailure(Exception):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000080 pass
81
82
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000083class CommandData(object):
Edward Lemur940c2822019-08-23 00:34:25 +000084 def __init__(self, name, cmd, kwargs, message, python3=False):
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000085 self.name = name
86 self.cmd = cmd
Edward Lesmes8e282792018-04-03 18:50:29 -040087 self.stdin = kwargs.get('stdin', None)
Edward Lemur2d6b67c2019-08-23 22:25:41 +000088 self.kwargs = kwargs.copy()
Edward Lesmes8e282792018-04-03 18:50:29 -040089 self.kwargs['stdout'] = subprocess.PIPE
90 self.kwargs['stderr'] = subprocess.STDOUT
91 self.kwargs['stdin'] = subprocess.PIPE
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000092 self.message = message
93 self.info = None
Edward Lemur940c2822019-08-23 00:34:25 +000094 self.python3 = python3
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000095
ilevy@chromium.orgbc117312013-04-20 03:57:56 +000096
Edward Lesmes8e282792018-04-03 18:50:29 -040097# Adapted from
98# https://github.com/google/gtest-parallel/blob/master/gtest_parallel.py#L37
99#
100# An object that catches SIGINT sent to the Python process and notices
101# if processes passed to wait() die by SIGINT (we need to look for
102# both of those cases, because pressing Ctrl+C can result in either
103# the main process or one of the subprocesses getting the signal).
104#
105# Before a SIGINT is seen, wait(p) will simply call p.wait() and
106# return the result. Once a SIGINT has been seen (in the main process
107# or a subprocess, including the one the current call is waiting for),
Edward Lemur9a5bb612019-09-26 02:01:52 +0000108# wait(p) will call p.terminate().
Edward Lesmes8e282792018-04-03 18:50:29 -0400109class SigintHandler(object):
Edward Lesmes8e282792018-04-03 18:50:29 -0400110 sigint_returncodes = {-signal.SIGINT, # Unix
111 -1073741510, # Windows
112 }
113 def __init__(self):
114 self.__lock = threading.Lock()
115 self.__processes = set()
116 self.__got_sigint = False
Edward Lemur9a5bb612019-09-26 02:01:52 +0000117 self.__previous_signal = signal.signal(signal.SIGINT, self.interrupt)
Edward Lesmes8e282792018-04-03 18:50:29 -0400118
119 def __on_sigint(self):
120 self.__got_sigint = True
121 while self.__processes:
122 try:
123 self.__processes.pop().terminate()
124 except OSError:
125 pass
126
Edward Lemur9a5bb612019-09-26 02:01:52 +0000127 def interrupt(self, signal_num, frame):
Edward Lesmes8e282792018-04-03 18:50:29 -0400128 with self.__lock:
129 self.__on_sigint()
Edward Lemur9a5bb612019-09-26 02:01:52 +0000130 self.__previous_signal(signal_num, frame)
Edward Lesmes8e282792018-04-03 18:50:29 -0400131
132 def got_sigint(self):
133 with self.__lock:
134 return self.__got_sigint
135
136 def wait(self, p, stdin):
137 with self.__lock:
138 if self.__got_sigint:
139 p.terminate()
140 self.__processes.add(p)
141 stdout, stderr = p.communicate(stdin)
142 code = p.returncode
143 with self.__lock:
144 self.__processes.discard(p)
145 if code in self.sigint_returncodes:
146 self.__on_sigint()
Edward Lesmes8e282792018-04-03 18:50:29 -0400147 return stdout, stderr
148
149sigint_handler = SigintHandler()
150
151
Edward Lemurecc27072020-01-06 16:42:34 +0000152class Timer(object):
153 def __init__(self, timeout, fn):
154 self.completed = False
155 self._fn = fn
156 self._timer = threading.Timer(timeout, self._onTimer) if timeout else None
157
158 def __enter__(self):
159 if self._timer:
160 self._timer.start()
161 return self
162
163 def __exit__(self, _type, _value, _traceback):
164 if self._timer:
165 self._timer.cancel()
166
167 def _onTimer(self):
168 self._fn()
169 self.completed = True
170
171
Edward Lesmes8e282792018-04-03 18:50:29 -0400172class ThreadPool(object):
Edward Lemurecc27072020-01-06 16:42:34 +0000173 def __init__(self, pool_size=None, timeout=None):
174 self.timeout = timeout
Edward Lesmes8e282792018-04-03 18:50:29 -0400175 self._pool_size = pool_size or multiprocessing.cpu_count()
Bruce Dawson8254f062022-06-17 17:33:08 +0000176 if sys.platform == 'win32':
177 # TODO(crbug.com/1190269) - we can't use more than 56 child processes on
178 # Windows or Python3 may hang.
179 self._pool_size = min(self._pool_size, 56)
Edward Lesmes8e282792018-04-03 18:50:29 -0400180 self._messages = []
181 self._messages_lock = threading.Lock()
182 self._tests = []
183 self._tests_lock = threading.Lock()
184 self._nonparallel_tests = []
185
Edward Lemurecc27072020-01-06 16:42:34 +0000186 def _GetCommand(self, test):
Edward Lemur940c2822019-08-23 00:34:25 +0000187 vpython = 'vpython'
188 if test.python3:
189 vpython += '3'
190 if sys.platform == 'win32':
191 vpython += '.bat'
Edward Lesmes8e282792018-04-03 18:50:29 -0400192
193 cmd = test.cmd
194 if cmd[0] == 'python':
195 cmd = list(cmd)
196 cmd[0] = vpython
197 elif cmd[0].endswith('.py'):
198 cmd = [vpython] + cmd
199
Edward Lemur336e51f2019-11-14 21:42:04 +0000200 # On Windows, scripts on the current directory take precedence over PATH, so
201 # that when testing depot_tools on Windows, calling `vpython.bat` will
202 # execute the copy of vpython of the depot_tools under test instead of the
203 # one in the bot.
204 # As a workaround, we run the tests from the parent directory instead.
205 if (cmd[0] == vpython and
206 'cwd' in test.kwargs and
207 os.path.basename(test.kwargs['cwd']) == 'depot_tools'):
208 test.kwargs['cwd'] = os.path.dirname(test.kwargs['cwd'])
209 cmd[1] = os.path.join('depot_tools', cmd[1])
210
Edward Lemurecc27072020-01-06 16:42:34 +0000211 return cmd
212
213 def _RunWithTimeout(self, cmd, stdin, kwargs):
214 p = subprocess.Popen(cmd, **kwargs)
215 with Timer(self.timeout, p.terminate) as timer:
216 stdout, _ = sigint_handler.wait(p, stdin)
Josip Sokcevic6635baf2021-11-19 02:04:39 +0000217 stdout = stdout.decode('utf-8', 'ignore')
Edward Lemurecc27072020-01-06 16:42:34 +0000218 if timer.completed:
219 stdout = 'Process timed out after %ss\n%s' % (self.timeout, stdout)
Josip Sokcevic6635baf2021-11-19 02:04:39 +0000220 return p.returncode, stdout
Edward Lemurecc27072020-01-06 16:42:34 +0000221
222 def CallCommand(self, test):
223 """Runs an external program.
224
Edward Lemura5799e32020-01-17 19:26:51 +0000225 This function converts invocation of .py files and invocations of 'python'
Edward Lemurecc27072020-01-06 16:42:34 +0000226 to vpython invocations.
227 """
228 cmd = self._GetCommand(test)
Edward Lesmes8e282792018-04-03 18:50:29 -0400229 try:
Edward Lemurecc27072020-01-06 16:42:34 +0000230 start = time_time()
231 returncode, stdout = self._RunWithTimeout(cmd, test.stdin, test.kwargs)
232 duration = time_time() - start
Edward Lemur7cf94382019-11-15 22:36:41 +0000233 except Exception:
Edward Lemurecc27072020-01-06 16:42:34 +0000234 duration = time_time() - start
Edward Lesmes8e282792018-04-03 18:50:29 -0400235 return test.message(
Edward Lemur7cf94382019-11-15 22:36:41 +0000236 '%s\n%s exec failure (%4.2fs)\n%s' % (
237 test.name, ' '.join(cmd), duration, traceback.format_exc()))
Edward Lemurde9e3ca2019-10-24 21:13:31 +0000238
Edward Lemurecc27072020-01-06 16:42:34 +0000239 if returncode != 0:
Edward Lesmes8e282792018-04-03 18:50:29 -0400240 return test.message(
Edward Lemur7cf94382019-11-15 22:36:41 +0000241 '%s\n%s (%4.2fs) failed\n%s' % (
242 test.name, ' '.join(cmd), duration, stdout))
Edward Lemurecc27072020-01-06 16:42:34 +0000243
Edward Lesmes8e282792018-04-03 18:50:29 -0400244 if test.info:
Edward Lemur7cf94382019-11-15 22:36:41 +0000245 return test.info('%s\n%s (%4.2fs)' % (test.name, ' '.join(cmd), duration))
Edward Lesmes8e282792018-04-03 18:50:29 -0400246
247 def AddTests(self, tests, parallel=True):
248 if parallel:
249 self._tests.extend(tests)
250 else:
251 self._nonparallel_tests.extend(tests)
252
253 def RunAsync(self):
254 self._messages = []
255
256 def _WorkerFn():
257 while True:
258 test = None
259 with self._tests_lock:
260 if not self._tests:
261 break
262 test = self._tests.pop()
263 result = self.CallCommand(test)
264 if result:
265 with self._messages_lock:
266 self._messages.append(result)
267
268 def _StartDaemon():
269 t = threading.Thread(target=_WorkerFn)
270 t.daemon = True
271 t.start()
272 return t
273
274 while self._nonparallel_tests:
275 test = self._nonparallel_tests.pop()
276 result = self.CallCommand(test)
277 if result:
278 self._messages.append(result)
279
280 if self._tests:
281 threads = [_StartDaemon() for _ in range(self._pool_size)]
282 for worker in threads:
283 worker.join()
284
285 return self._messages
286
287
Josip Sokcevica9a7eec2023-03-10 03:54:52 +0000288def normpath(path):
289 '''Version of os.path.normpath that also changes backward slashes to
290 forward slashes when not running on Windows.
291 '''
292 # This is safe to always do because the Windows version of os.path.normpath
293 # will replace forward slashes with backward slashes.
294 path = path.replace(os.sep, '/')
295 return os.path.normpath(path)
296
297
Josip Sokcevic7958e302023-03-01 23:02:21 +0000298def _RightHandSideLinesImpl(affected_files):
299 """Implements RightHandSideLines for InputApi and GclChange."""
300 for af in affected_files:
301 lines = af.ChangedContents()
302 for line in lines:
303 yield (af, line[0], line[1])
304
305
Edward Lemur6eb1d322020-02-27 22:20:15 +0000306def prompt_should_continue(prompt_string):
307 sys.stdout.write(prompt_string)
Dirk Pranke7288f882021-06-03 18:01:30 +0000308 sys.stdout.flush()
Edward Lemur6eb1d322020-02-27 22:20:15 +0000309 response = sys.stdin.readline().strip().lower()
310 return response in ('y', 'yes')
dpranke@chromium.org5ac21012011-03-16 02:58:25 +0000311
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000312# Top level object so multiprocessing can pickle
313# Public access through OutputApi object.
314class _PresubmitResult(object):
315 """Base class for result objects."""
316 fatal = False
317 should_prompt = False
318
319 def __init__(self, message, items=None, long_text=''):
320 """
321 message: A short one-line message to indicate errors.
322 items: A list of short strings to indicate where errors occurred.
323 long_text: multi-line text output, e.g. from another tool
324 """
Bruce Dawsondb8622b2022-04-03 15:38:12 +0000325 self._message = _PresubmitResult._ensure_str(message)
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000326 self._items = items or []
Tom McKee61c72652021-07-20 11:56:32 +0000327 self._long_text = _PresubmitResult._ensure_str(long_text.rstrip())
Bruce Dawsondca14bc2022-09-15 20:59:38 +0000328 if _SHOW_CALLSTACKS:
329 self._long_text += 'Presubmit result call stack is:\n'
330 self._long_text += ''.join(traceback.format_stack(None, 8))
Tom McKee61c72652021-07-20 11:56:32 +0000331
332 @staticmethod
333 def _ensure_str(val):
334 """
335 val: A "stringish" value. Can be any of str, unicode or bytes.
336 returns: A str after applying encoding/decoding as needed.
337 Assumes/uses UTF-8 for relevant inputs/outputs.
338
339 We'd prefer to use six.ensure_str but our copy of six is old :(
340 """
341 if isinstance(val, str):
342 return val
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +0000343
Tom McKee61c72652021-07-20 11:56:32 +0000344 if six.PY2 and isinstance(val, unicode):
345 return val.encode()
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +0000346
347 if six.PY3 and isinstance(val, bytes):
Tom McKee61c72652021-07-20 11:56:32 +0000348 return val.decode()
349 raise ValueError("Unknown string type %s" % type(val))
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000350
Edward Lemur6eb1d322020-02-27 22:20:15 +0000351 def handle(self):
352 sys.stdout.write(self._message)
353 sys.stdout.write('\n')
Takuto Ikutabaa7be02022-08-23 00:19:34 +0000354 for item in self._items:
Edward Lemur6eb1d322020-02-27 22:20:15 +0000355 sys.stdout.write(' ')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000356 # Write separately in case it's unicode.
Edward Lemur6eb1d322020-02-27 22:20:15 +0000357 sys.stdout.write(str(item))
Edward Lemur6eb1d322020-02-27 22:20:15 +0000358 sys.stdout.write('\n')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000359 if self._long_text:
Edward Lemur6eb1d322020-02-27 22:20:15 +0000360 sys.stdout.write('\n***************\n')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000361 # Write separately in case it's unicode.
Tom McKee61c72652021-07-20 11:56:32 +0000362 sys.stdout.write(self._long_text)
Edward Lemur6eb1d322020-02-27 22:20:15 +0000363 sys.stdout.write('\n***************\n')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000364
Debrian Figueroadd2737e2019-06-21 23:50:13 +0000365 def json_format(self):
366 return {
367 'message': self._message,
Debrian Figueroa6095d402019-06-28 18:47:18 +0000368 'items': [str(item) for item in self._items],
Debrian Figueroadd2737e2019-06-21 23:50:13 +0000369 'long_text': self._long_text,
370 'fatal': self.fatal
371 }
372
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000373
374# Top level object so multiprocessing can pickle
375# Public access through OutputApi object.
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000376class _PresubmitError(_PresubmitResult):
377 """A hard presubmit error."""
378 fatal = True
379
380
381# Top level object so multiprocessing can pickle
382# Public access through OutputApi object.
383class _PresubmitPromptWarning(_PresubmitResult):
384 """An warning that prompts the user if they want to continue."""
385 should_prompt = True
386
387
388# Top level object so multiprocessing can pickle
389# Public access through OutputApi object.
390class _PresubmitNotifyResult(_PresubmitResult):
391 """Just print something to the screen -- but it's not even a warning."""
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000392
393
394# Top level object so multiprocessing can pickle
395# Public access through OutputApi object.
396class _MailTextResult(_PresubmitResult):
397 """A warning that should be included in the review request email."""
398 def __init__(self, *args, **kwargs):
399 super(_MailTextResult, self).__init__()
400 raise NotImplementedError()
401
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000402class GerritAccessor(object):
403 """Limited Gerrit functionality for canned presubmit checks to work.
404
405 To avoid excessive Gerrit calls, caches the results.
406 """
407
Edward Lesmeseb1bd622021-03-01 19:54:07 +0000408 def __init__(self, url=None, project=None, branch=None):
409 self.host = urlparse.urlparse(url).netloc if url else None
410 self.project = project
411 self.branch = branch
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000412 self.cache = {}
Edward Lesmes8170c292021-03-19 20:04:43 +0000413 self.code_owners_enabled = None
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000414
415 def _FetchChangeDetail(self, issue):
416 # Separate function to be easily mocked in tests.
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +0100417 try:
418 return gerrit_util.GetChangeDetail(
419 self.host, str(issue),
Aaron Gable6f5a8d92017-04-18 14:49:05 -0700420 ['ALL_REVISIONS', 'DETAILED_LABELS', 'ALL_COMMITS'])
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +0100421 except gerrit_util.GerritError as e:
422 if e.http_status == 404:
423 raise Exception('Either Gerrit issue %s doesn\'t exist, or '
424 'no credentials to fetch issue details' % issue)
425 raise
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000426
427 def GetChangeInfo(self, issue):
428 """Returns labels and all revisions (patchsets) for this issue.
429
430 The result is a dictionary according to Gerrit REST Api.
431 https://gerrit-review.googlesource.com/Documentation/rest-api.html
432
433 However, API isn't very clear what's inside, so see tests for example.
434 """
435 assert issue
436 cache_key = int(issue)
437 if cache_key not in self.cache:
438 self.cache[cache_key] = self._FetchChangeDetail(issue)
439 return self.cache[cache_key]
440
441 def GetChangeDescription(self, issue, patchset=None):
442 """If patchset is none, fetches current patchset."""
443 info = self.GetChangeInfo(issue)
444 # info is a reference to cache. We'll modify it here adding description to
445 # it to the right patchset, if it is not yet there.
446
447 # Find revision info for the patchset we want.
448 if patchset is not None:
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +0000449 for rev, rev_info in info['revisions'].items():
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000450 if str(rev_info['_number']) == str(patchset):
451 break
452 else:
453 raise Exception('patchset %s doesn\'t exist in issue %s' % (
454 patchset, issue))
455 else:
456 rev = info['current_revision']
457 rev_info = info['revisions'][rev]
458
Andrii Shyshkalov9c3a4642017-01-24 17:41:22 +0100459 return rev_info['commit']['message']
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000460
Mun Yong Jang603d01e2017-12-19 16:38:30 -0800461 def GetDestRef(self, issue):
462 ref = self.GetChangeInfo(issue)['branch']
463 if not ref.startswith('refs/'):
464 # NOTE: it is possible to create 'refs/x' branch,
465 # aka 'refs/heads/refs/x'. However, this is ill-advised.
466 ref = 'refs/heads/%s' % ref
467 return ref
468
Edward Lesmes02d4b822020-11-11 00:37:35 +0000469 def _GetApproversForLabel(self, issue, label):
470 change_info = self.GetChangeInfo(issue)
471 label_info = change_info.get('labels', {}).get(label, {})
472 values = label_info.get('values', {}).keys()
473 if not values:
474 return []
475 max_value = max(int(v) for v in values)
476 return [v for v in label_info.get('all', [])
477 if v.get('value', 0) == max_value]
478
Edward Lesmesc4566172021-03-19 16:55:13 +0000479 def IsBotCommitApproved(self, issue):
480 return bool(self._GetApproversForLabel(issue, 'Bot-Commit'))
481
Edward Lesmescf49cb82020-11-11 01:08:36 +0000482 def IsOwnersOverrideApproved(self, issue):
483 return bool(self._GetApproversForLabel(issue, 'Owners-Override'))
484
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000485 def GetChangeOwner(self, issue):
486 return self.GetChangeInfo(issue)['owner']['email']
487
488 def GetChangeReviewers(self, issue, approving_only=True):
Aaron Gable8b478f02017-07-31 15:33:19 -0700489 changeinfo = self.GetChangeInfo(issue)
490 if approving_only:
Edward Lesmes02d4b822020-11-11 00:37:35 +0000491 reviewers = self._GetApproversForLabel(issue, 'Code-Review')
Aaron Gable8b478f02017-07-31 15:33:19 -0700492 else:
493 reviewers = changeinfo.get('reviewers', {}).get('REVIEWER', [])
494 return [r.get('email') for r in reviewers]
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000495
Edward Lemure4d329c2020-02-03 20:41:18 +0000496 def UpdateDescription(self, description, issue):
497 gerrit_util.SetCommitMessage(self.host, issue, description, notify='NONE')
498
Edward Lesmes8170c292021-03-19 20:04:43 +0000499 def IsCodeOwnersEnabledOnRepo(self):
500 if self.code_owners_enabled is None:
501 self.code_owners_enabled = gerrit_util.IsCodeOwnersEnabledOnRepo(
Edward Lesmes392c4072021-03-19 21:58:45 +0000502 self.host, self.project)
Edward Lesmes8170c292021-03-19 20:04:43 +0000503 return self.code_owners_enabled
504
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000505
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000506class OutputApi(object):
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000507 """An instance of OutputApi gets passed to presubmit scripts so that they
508 can output various types of results.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000509 """
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000510 PresubmitResult = _PresubmitResult
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000511 PresubmitError = _PresubmitError
512 PresubmitPromptWarning = _PresubmitPromptWarning
513 PresubmitNotifyResult = _PresubmitNotifyResult
514 MailTextResult = _MailTextResult
515
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000516 def __init__(self, is_committing):
517 self.is_committing = is_committing
Daniel Cheng7227d212017-11-17 08:12:37 -0800518 self.more_cc = []
519
520 def AppendCC(self, cc):
521 """Appends a user to cc for this change."""
Daniel Cheng0e9f6682022-10-19 17:42:57 +0000522 if cc not in self.more_cc:
523 self.more_cc.append(cc)
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000524
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000525 def PresubmitPromptOrNotify(self, *args, **kwargs):
526 """Warn the user when uploading, but only notify if committing."""
527 if self.is_committing:
528 return self.PresubmitNotifyResult(*args, **kwargs)
529 return self.PresubmitPromptWarning(*args, **kwargs)
530
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000531
532class InputApi(object):
533 """An instance of this object is passed to presubmit scripts so they can
534 know stuff about the change they're looking at.
535 """
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000536 # Method could be a function
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800537 # pylint: disable=no-self-use
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000538
maruel@chromium.org3410d912009-06-09 20:56:16 +0000539 # File extensions that are considered source files from a style guide
540 # perspective. Don't modify this list from a presubmit script!
maruel@chromium.orgc33455a2011-06-24 19:14:18 +0000541 #
542 # Files without an extension aren't included in the list. If you want to
local_bot30f774e2020-06-25 18:23:34 +0000543 # filter them as source files, add r'(^|.*?[\\\/])[^.]+$' to the allow list.
local_bot64021412020-07-08 21:05:39 +0000544 # Note that ALL CAPS files are skipped in DEFAULT_FILES_TO_SKIP below.
545 DEFAULT_FILES_TO_CHECK = (
maruel@chromium.org3410d912009-06-09 20:56:16 +0000546 # C++ and friends
Edward Lemura5799e32020-01-17 19:26:51 +0000547 r'.+\.c$', r'.+\.cc$', r'.+\.cpp$', r'.+\.h$', r'.+\.m$', r'.+\.mm$',
548 r'.+\.inl$', r'.+\.asm$', r'.+\.hxx$', r'.+\.hpp$', r'.+\.s$', r'.+\.S$',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000549 # Scripts
dpapad443d9132022-05-05 00:17:30 +0000550 r'.+\.js$', r'.+\.ts$', r'.+\.py$', r'.+\.sh$', r'.+\.rb$', r'.+\.pl$',
551 r'.+\.pm$',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000552 # Other
Edward Lemura5799e32020-01-17 19:26:51 +0000553 r'.+\.java$', r'.+\.mk$', r'.+\.am$', r'.+\.css$', r'.+\.mojom$',
Bruce Dawson7a81ebf2023-01-03 18:36:18 +0000554 r'.+\.fidl$', r'.+\.rs$',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000555 )
556
557 # Path regexp that should be excluded from being considered containing source
558 # files. Don't modify this list from a presubmit script!
local_bot64021412020-07-08 21:05:39 +0000559 DEFAULT_FILES_TO_SKIP = (
Edward Lemura5799e32020-01-17 19:26:51 +0000560 r'testing_support[\\\/]google_appengine[\\\/].*',
561 r'.*\bexperimental[\\\/].*',
Kent Tamura179dd1e2018-04-26 15:07:41 +0900562 # Exclude third_party/.* but NOT third_party/{WebKit,blink}
563 # (crbug.com/539768 and crbug.com/836555).
Edward Lemura5799e32020-01-17 19:26:51 +0000564 r'.*\bthird_party[\\\/](?!(WebKit|blink)[\\\/]).*',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000565 # Output directories (just in case)
Edward Lemura5799e32020-01-17 19:26:51 +0000566 r'.*\bDebug[\\\/].*',
567 r'.*\bRelease[\\\/].*',
568 r'.*\bxcodebuild[\\\/].*',
569 r'.*\bout[\\\/].*',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000570 # All caps files like README and LICENCE.
Edward Lemura5799e32020-01-17 19:26:51 +0000571 r'.*\b[A-Z0-9_]{2,}$',
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +0000572 # SCM (can happen in dual SCM configuration). (Slightly over aggressive)
Edward Lemura5799e32020-01-17 19:26:51 +0000573 r'(|.*[\\\/])\.git[\\\/].*',
574 r'(|.*[\\\/])\.svn[\\\/].*',
maruel@chromium.org7ccb4bb2011-11-07 20:26:20 +0000575 # There is no point in processing a patch file.
Edward Lemura5799e32020-01-17 19:26:51 +0000576 r'.+\.diff$',
577 r'.+\.patch$',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000578 )
579
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000580 def __init__(self, change, presubmit_path, is_committing,
Bruce Dawson09c0c072022-05-26 20:28:58 +0000581 verbose, gerrit_obj, dry_run=None, thread_pool=None, parallel=False,
582 no_diffs=False):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000583 """Builds an InputApi object.
584
585 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000586 change: A presubmit.Change object.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000587 presubmit_path: The path to the presubmit script being processed.
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000588 is_committing: True if the change is about to be committed.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000589 gerrit_obj: provides basic Gerrit codereview functionality.
590 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -0400591 parallel: if true, all tests reported via input_api.RunTests for all
592 PRESUBMIT files will be run in parallel.
Bruce Dawson09c0c072022-05-26 20:28:58 +0000593 no_diffs: if true, implies that --files or --all was specified so some
594 checks can be skipped, and some errors will be messages.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000595 """
maruel@chromium.org9711bba2009-05-22 23:51:39 +0000596 # Version number of the presubmit_support script.
597 self.version = [int(x) for x in __version__.split('.')]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000598 self.change = change
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000599 self.is_committing = is_committing
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000600 self.gerrit = gerrit_obj
tandrii@chromium.org57bafac2016-04-28 05:09:03 +0000601 self.dry_run = dry_run
Bruce Dawson09c0c072022-05-26 20:28:58 +0000602 self.no_diffs = no_diffs
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000603
Edward Lesmes8e282792018-04-03 18:50:29 -0400604 self.parallel = parallel
605 self.thread_pool = thread_pool or ThreadPool()
606
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000607 # We expose various modules and functions as attributes of the input_api
608 # so that presubmit scripts don't have to import them.
Takeshi Yoshino07a6bea2017-08-02 02:44:06 +0900609 self.ast = ast
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000610 self.basename = os.path.basename
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000611 self.cpplint = cpplint
dcheng091b7db2016-06-16 01:27:51 -0700612 self.fnmatch = fnmatch
Yoshisato Yanagisawa04600b42019-03-15 03:03:41 +0000613 self.gclient_paths = gclient_paths
Yoshisato Yanagisawa57dd17b2019-03-22 09:10:29 +0000614 # TODO(yyanagisawa): stop exposing this when python3 become default.
615 # Since python3's tempfile has TemporaryDirectory, we do not need this.
616 self.temporary_directory = gclient_utils.temporary_directory
dpranke@chromium.org17cc2442012-10-17 21:12:09 +0000617 self.glob = glob.glob
maruel@chromium.orgfb11c7b2010-03-18 18:22:14 +0000618 self.json = json
maruel@chromium.org6fba34d2011-06-02 13:45:12 +0000619 self.logging = logging.getLogger('PRESUBMIT')
maruel@chromium.org2b5ce562011-03-31 16:15:44 +0000620 self.os_listdir = os.listdir
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000621 self.os_path = os.path
pgervais@chromium.orgbd0cace2014-10-02 23:23:46 +0000622 self.os_stat = os.stat
Yoshisato Yanagisawa406de132018-06-29 05:43:25 +0000623 self.os_walk = os.walk
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000624 self.re = re
625 self.subprocess = subprocess
Edward Lemurb9830242019-10-30 22:19:20 +0000626 self.sys = sys
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000627 self.tempfile = tempfile
dpranke@chromium.org0d1bdea2011-03-24 22:54:38 +0000628 self.time = time
maruel@chromium.org1487d532009-06-06 00:22:57 +0000629 self.unittest = unittest
Edward Lemurb9830242019-10-30 22:19:20 +0000630 if sys.version_info.major == 2:
631 self.urllib2 = urllib2
Edward Lemur16af3562019-10-17 22:11:33 +0000632 self.urllib_request = urllib_request
633 self.urllib_error = urllib_error
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000634
Robert Iannucci50258932018-03-19 10:30:59 -0700635 self.is_windows = sys.platform == 'win32'
636
Edward Lemurb9646622019-10-25 20:57:35 +0000637 # Set python_executable to 'vpython' in order to allow scripts in other
638 # repos (e.g. src.git) to automatically pick up that repo's .vpython file,
639 # instead of inheriting the one in depot_tools.
640 self.python_executable = 'vpython'
Erik Staab69135d12021-05-14 22:31:57 +0000641 # Offer a python 3 executable for use during the migration off of python 2.
642 self.python3_executable = 'vpython3'
maruel@chromium.orgc0b22972009-06-25 16:19:14 +0000643 self.environ = os.environ
644
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000645 # InputApi.platform is the platform you're currently running on.
646 self.platform = sys.platform
647
iannucci@chromium.org0af3bb32015-06-12 20:44:35 +0000648 self.cpu_count = multiprocessing.cpu_count()
Bruce Dawson8254f062022-06-17 17:33:08 +0000649 if self.is_windows:
650 # TODO(crbug.com/1190269) - we can't use more than 56 child processes on
651 # Windows or Python3 may hang.
652 self.cpu_count = min(self.cpu_count, 56)
iannucci@chromium.org0af3bb32015-06-12 20:44:35 +0000653
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000654 # The local path of the currently-being-processed presubmit script.
maruel@chromium.org3d235242009-05-15 12:40:48 +0000655 self._current_presubmit_path = os.path.dirname(presubmit_path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000656
657 # We carry the canned checks so presubmit scripts can easily use them.
658 self.canned_checks = presubmit_canned_checks
659
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +0100660 # Temporary files we must manually remove at the end of a run.
661 self._named_temporary_files = []
Jochen Eisinger72606f82017-04-04 10:44:18 +0200662
Edward Lesmesdc11c6b2021-03-19 19:22:05 +0000663 self.owners_client = None
Bruce Dawsoneb8426e2022-08-05 23:58:15 +0000664 if self.gerrit and not 'PRESUBMIT_SKIP_NETWORK' in self.environ:
Bruce Dawson9b9f4512022-04-27 00:56:52 +0000665 try:
666 self.owners_client = owners_client.GetCodeOwnersClient(
Bruce Dawson9b9f4512022-04-27 00:56:52 +0000667 host=self.gerrit.host,
668 project=self.gerrit.project,
669 branch=self.gerrit.branch)
670 except Exception as e:
671 print('Failed to set owners_client - %s' % str(e))
Jochen Eisinger76f5fc62017-04-07 16:27:46 +0200672 self.owners_finder = owners_finder.OwnersFinder
maruel@chromium.org899e1c12011-04-07 17:03:18 +0000673 self.verbose = verbose
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000674 self.Command = CommandData
dpranke@chromium.org2a009622011-03-01 02:43:31 +0000675
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000676 # Replace <hash_map> and <hash_set> as headers that need to be included
Edward Lemura5799e32020-01-17 19:26:51 +0000677 # with 'base/containers/hash_tables.h' instead.
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000678 # Access to a protected member _XX of a client class
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800679 # pylint: disable=protected-access
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000680 self.cpplint._re_pattern_templates = [
danakj@chromium.org18278522013-06-11 22:42:32 +0000681 (a, b, 'base/containers/hash_tables.h')
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000682 if header in ('<hash_map>', '<hash_set>') else (a, b, header)
683 for (a, b, header) in cpplint._re_pattern_templates
684 ]
685
Edward Lemurecc27072020-01-06 16:42:34 +0000686 def SetTimeout(self, timeout):
687 self.thread_pool.timeout = timeout
688
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000689 def PresubmitLocalPath(self):
690 """Returns the local path of the presubmit script currently being run.
691
692 This is useful if you don't want to hard-code absolute paths in the
693 presubmit script. For example, It can be used to find another file
694 relative to the PRESUBMIT.py script, so the whole tree can be branched and
695 the presubmit script still works, without editing its content.
696 """
maruel@chromium.org3d235242009-05-15 12:40:48 +0000697 return self._current_presubmit_path
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000698
agable0b65e732016-11-22 09:25:46 -0800699 def AffectedFiles(self, include_deletes=True, file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000700 """Same as input_api.change.AffectedFiles() except only lists files
701 (and optionally directories) in the same directory as the current presubmit
Bruce Dawson7a0b07a2020-04-23 17:14:40 +0000702 script, or subdirectories thereof. Note that files are listed using the OS
703 path separator, so backslashes are used as separators on Windows.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000704 """
Josip Sokcevica9a7eec2023-03-10 03:54:52 +0000705 dir_with_slash = normpath(self.PresubmitLocalPath())
Bruce Dawson31bfd512022-05-10 23:19:39 +0000706 # normpath strips trailing path separators, so the trailing separator has to
707 # be added after the normpath call.
708 if len(dir_with_slash) > 0:
709 dir_with_slash += os.path.sep
sail@chromium.org5538e022011-05-12 17:53:16 +0000710
Josip Sokcevica9a7eec2023-03-10 03:54:52 +0000711 return list(filter(
712 lambda x: normpath(x.AbsoluteLocalPath()).startswith(dir_with_slash),
713 self.change.AffectedFiles(include_deletes, file_filter)))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000714
agable0b65e732016-11-22 09:25:46 -0800715 def LocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000716 """Returns local paths of input_api.AffectedFiles()."""
agable0b65e732016-11-22 09:25:46 -0800717 paths = [af.LocalPath() for af in self.AffectedFiles()]
Edward Lemura5799e32020-01-17 19:26:51 +0000718 logging.debug('LocalPaths: %s', paths)
pgervais@chromium.org2f64f782014-04-25 00:12:33 +0000719 return paths
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000720
agable0b65e732016-11-22 09:25:46 -0800721 def AbsoluteLocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000722 """Returns absolute local paths of input_api.AffectedFiles()."""
agable0b65e732016-11-22 09:25:46 -0800723 return [af.AbsoluteLocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000724
John Budorick16162372018-04-18 10:39:53 -0700725 def AffectedTestableFiles(self, include_deletes=None, **kwargs):
agable0b65e732016-11-22 09:25:46 -0800726 """Same as input_api.change.AffectedTestableFiles() except only lists files
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000727 in the same directory as the current presubmit script, or subdirectories
728 thereof.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000729 """
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000730 if include_deletes is not None:
Edward Lemura5799e32020-01-17 19:26:51 +0000731 warn('AffectedTestableFiles(include_deletes=%s)'
732 ' is deprecated and ignored' % str(include_deletes),
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000733 category=DeprecationWarning,
734 stacklevel=2)
Josip Sokcevic4de5dea2022-03-23 21:15:14 +0000735 # pylint: disable=consider-using-generator
736 return [
737 x for x in self.AffectedFiles(include_deletes=False, **kwargs)
738 if x.IsTestableFile()
739 ]
agable0b65e732016-11-22 09:25:46 -0800740
741 def AffectedTextFiles(self, include_deletes=None):
742 """An alias to AffectedTestableFiles for backwards compatibility."""
743 return self.AffectedTestableFiles(include_deletes=include_deletes)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000744
Josip Sokcevic8c955952021-02-01 21:32:57 +0000745 def FilterSourceFile(self,
746 affected_file,
747 files_to_check=None,
748 files_to_skip=None,
749 allow_list=None,
750 block_list=None):
Edward Lemura5799e32020-01-17 19:26:51 +0000751 """Filters out files that aren't considered 'source file'.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000752
local_bot64021412020-07-08 21:05:39 +0000753 If files_to_check or files_to_skip is None, InputApi.DEFAULT_FILES_TO_CHECK
754 and InputApi.DEFAULT_FILES_TO_SKIP is used respectively.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000755
Bruce Dawson635383f2022-09-13 16:23:18 +0000756 affected_file.LocalPath() needs to re.match an entry in the files_to_check
757 list and not re.match any entries in the files_to_skip list.
758 '/' path separators should be used in the regular expressions and will work
759 on Windows as well as other platforms.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000760
761 Note: Copy-paste this function to suit your needs or use a lambda function.
762 """
local_bot64021412020-07-08 21:05:39 +0000763 if files_to_check is None:
764 files_to_check = self.DEFAULT_FILES_TO_CHECK
765 if files_to_skip is None:
766 files_to_skip = self.DEFAULT_FILES_TO_SKIP
local_bot30f774e2020-06-25 18:23:34 +0000767
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000768 def Find(affected_file, items):
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000769 local_path = affected_file.LocalPath()
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000770 for item in items:
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +0000771 if self.re.match(item, local_path):
maruel@chromium.org3410d912009-06-09 20:56:16 +0000772 return True
Bruce Dawsona3a014e2022-04-27 23:28:17 +0000773 # Handle the cases where the files regex only handles /, but the local
774 # path uses \.
775 if self.is_windows and self.re.match(item, local_path.replace(
776 '\\', '/')):
777 return True
maruel@chromium.org3410d912009-06-09 20:56:16 +0000778 return False
local_bot64021412020-07-08 21:05:39 +0000779 return (Find(affected_file, files_to_check) and
780 not Find(affected_file, files_to_skip))
maruel@chromium.org3410d912009-06-09 20:56:16 +0000781
782 def AffectedSourceFiles(self, source_file):
agable0b65e732016-11-22 09:25:46 -0800783 """Filter the list of AffectedTestableFiles by the function source_file.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000784
785 If source_file is None, InputApi.FilterSourceFile() is used.
786 """
787 if not source_file:
788 source_file = self.FilterSourceFile
Edward Lemurb9830242019-10-30 22:19:20 +0000789 return list(filter(source_file, self.AffectedTestableFiles()))
maruel@chromium.org3410d912009-06-09 20:56:16 +0000790
791 def RightHandSideLines(self, source_file_filter=None):
Edward Lemura5799e32020-01-17 19:26:51 +0000792 """An iterator over all text lines in 'new' version of changed files.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000793
794 Only lists lines from new or modified text files in the change that are
795 contained by the directory of the currently executing presubmit script.
796
797 This is useful for doing line-by-line regex checks, like checking for
798 trailing whitespace.
799
800 Yields:
801 a 3 tuple:
Josip Sokcevic7958e302023-03-01 23:02:21 +0000802 the AffectedFile instance of the current file;
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000803 integer line number (1-based); and
804 the contents of the line as a string.
maruel@chromium.org1487d532009-06-06 00:22:57 +0000805
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000806 Note: The carriage return (LF or CR) is stripped off.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000807 """
maruel@chromium.org3410d912009-06-09 20:56:16 +0000808 files = self.AffectedSourceFiles(source_file_filter)
Josip Sokcevic7958e302023-03-01 23:02:21 +0000809 return _RightHandSideLinesImpl(files)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000810
maruel@chromium.orge3608df2009-11-10 20:22:57 +0000811 def ReadFile(self, file_item, mode='r'):
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000812 """Reads an arbitrary file.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000813
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000814 Deny reading anything outside the repository.
815 """
Josip Sokcevic7958e302023-03-01 23:02:21 +0000816 if isinstance(file_item, AffectedFile):
maruel@chromium.orge3608df2009-11-10 20:22:57 +0000817 file_item = file_item.AbsoluteLocalPath()
818 if not file_item.startswith(self.change.RepositoryRoot()):
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000819 raise IOError('Access outside the repository root is denied.')
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +0000820 return gclient_utils.FileRead(file_item, mode)
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000821
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +0100822 def CreateTemporaryFile(self, **kwargs):
823 """Returns a named temporary file that must be removed with a call to
824 RemoveTemporaryFiles().
825
826 All keyword arguments are forwarded to tempfile.NamedTemporaryFile(),
827 except for |delete|, which is always set to False.
828
829 Presubmit checks that need to create a temporary file and pass it for
830 reading should use this function instead of NamedTemporaryFile(), as
831 Windows fails to open a file that is already open for writing.
832
833 with input_api.CreateTemporaryFile() as f:
834 f.write('xyz')
835 f.close()
836 input_api.subprocess.check_output(['script-that', '--reads-from',
837 f.name])
838
839
840 Note that callers of CreateTemporaryFile() should not worry about removing
841 any temporary file; this is done transparently by the presubmit handling
842 code.
843 """
844 if 'delete' in kwargs:
845 # Prevent users from passing |delete|; we take care of file deletion
846 # ourselves and this prevents unintuitive error messages when we pass
847 # delete=False and 'delete' is also in kwargs.
848 raise TypeError('CreateTemporaryFile() does not take a "delete" '
849 'argument, file deletion is handled automatically by '
850 'the same presubmit_support code that creates InputApi '
851 'objects.')
852 temp_file = self.tempfile.NamedTemporaryFile(delete=False, **kwargs)
853 self._named_temporary_files.append(temp_file.name)
854 return temp_file
855
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000856 @property
857 def tbr(self):
858 """Returns if a change is TBR'ed."""
Jeremy Romandce22502017-06-20 15:37:29 -0400859 return 'TBR' in self.change.tags or self.change.TBRsFromDescription()
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000860
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +0000861 def RunTests(self, tests_mix, parallel=True):
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000862 tests = []
863 msgs = []
864 for t in tests_mix:
Edward Lesmes8e282792018-04-03 18:50:29 -0400865 if isinstance(t, OutputApi.PresubmitResult) and t:
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000866 msgs.append(t)
867 else:
868 assert issubclass(t.message, _PresubmitResult)
869 tests.append(t)
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +0000870 if self.verbose:
871 t.info = _PresubmitNotifyResult
Edward Lemur1037c742018-05-01 18:56:04 -0400872 if not t.kwargs.get('cwd'):
873 t.kwargs['cwd'] = self.PresubmitLocalPath()
Edward Lesmes8e282792018-04-03 18:50:29 -0400874 self.thread_pool.AddTests(tests, parallel)
Edward Lemur21000eb2019-05-24 23:25:58 +0000875 # When self.parallel is True (i.e. --parallel is passed as an option)
876 # RunTests doesn't actually run tests. It adds them to a ThreadPool that
877 # will run all tests once all PRESUBMIT files are processed.
878 # Otherwise, it will run them and return the results.
879 if not self.parallel:
Edward Lesmes8e282792018-04-03 18:50:29 -0400880 msgs.extend(self.thread_pool.RunAsync())
881 return msgs
scottmg86099d72016-09-01 09:16:51 -0700882
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000883
Josip Sokcevic7958e302023-03-01 23:02:21 +0000884class _DiffCache(object):
885 """Caches diffs retrieved from a particular SCM."""
886 def __init__(self, upstream=None):
887 """Stores the upstream revision against which all diffs will be computed."""
888 self._upstream = upstream
889
890 def GetDiff(self, path, local_root):
891 """Get the diff for a particular path."""
892 raise NotImplementedError()
893
894 def GetOldContents(self, path, local_root):
895 """Get the old version for a particular path."""
896 raise NotImplementedError()
897
898
899class _GitDiffCache(_DiffCache):
900 """DiffCache implementation for git; gets all file diffs at once."""
901 def __init__(self, upstream):
902 super(_GitDiffCache, self).__init__(upstream=upstream)
903 self._diffs_by_file = None
904
905 def GetDiff(self, path, local_root):
906 # Compare against None to distinguish between None and an initialized but
907 # empty dictionary.
908 if self._diffs_by_file == None:
909 # Compute a single diff for all files and parse the output; should
910 # with git this is much faster than computing one diff for each file.
911 diffs = {}
912
913 # Don't specify any filenames below, because there are command line length
914 # limits on some platforms and GenerateDiff would fail.
915 unified_diff = scm.GIT.GenerateDiff(local_root, files=[], full_move=True,
916 branch=self._upstream)
917
918 # This regex matches the path twice, separated by a space. Note that
919 # filename itself may contain spaces.
920 file_marker = re.compile('^diff --git (?P<filename>.*) (?P=filename)$')
921 current_diff = []
922 keep_line_endings = True
923 for x in unified_diff.splitlines(keep_line_endings):
924 match = file_marker.match(x)
925 if match:
926 # Marks the start of a new per-file section.
927 diffs[match.group('filename')] = current_diff = [x]
928 elif x.startswith('diff --git'):
929 raise PresubmitFailure('Unexpected diff line: %s' % x)
930 else:
931 current_diff.append(x)
932
933 self._diffs_by_file = dict(
Josip Sokcevica9a7eec2023-03-10 03:54:52 +0000934 (normpath(path), ''.join(diff)) for path, diff in diffs.items())
Josip Sokcevic7958e302023-03-01 23:02:21 +0000935
936 if path not in self._diffs_by_file:
937 # SCM didn't have any diff on this file. It could be that the file was not
938 # modified at all (e.g. user used --all flag in git cl presubmit).
939 # Intead of failing, return empty string.
940 # See: https://crbug.com/808346.
941 return ''
942
943 return self._diffs_by_file[path]
944
945 def GetOldContents(self, path, local_root):
946 return scm.GIT.GetOldContents(local_root, path, branch=self._upstream)
947
948
949class AffectedFile(object):
950 """Representation of a file in a change."""
951
952 DIFF_CACHE = _DiffCache
953
954 # Method could be a function
955 # pylint: disable=no-self-use
956 def __init__(self, path, action, repository_root, diff_cache):
957 self._path = path
958 self._action = action
959 self._local_root = repository_root
960 self._is_directory = None
961 self._cached_changed_contents = None
962 self._cached_new_contents = None
963 self._diff_cache = diff_cache
964 logging.debug('%s(%s)', self.__class__.__name__, self._path)
965
966 def LocalPath(self):
967 """Returns the path of this file on the local disk relative to client root.
968
969 This should be used for error messages but not for accessing files,
970 because presubmit checks are run with CWD=PresubmitLocalPath() (which is
971 often != client root).
972 """
Josip Sokcevica9a7eec2023-03-10 03:54:52 +0000973 return normpath(self._path)
Josip Sokcevic7958e302023-03-01 23:02:21 +0000974
975 def AbsoluteLocalPath(self):
976 """Returns the absolute path of this file on the local disk.
977 """
978 return os.path.abspath(os.path.join(self._local_root, self.LocalPath()))
979
980 def Action(self):
981 """Returns the action on this opened file, e.g. A, M, D, etc."""
982 return self._action
983
984 def IsTestableFile(self):
985 """Returns True if the file is a text file and not a binary file.
986
987 Deleted files are not text file."""
988 raise NotImplementedError() # Implement when needed
989
990 def IsTextFile(self):
991 """An alias to IsTestableFile for backwards compatibility."""
992 return self.IsTestableFile()
993
994 def OldContents(self):
995 """Returns an iterator over the lines in the old version of file.
996
997 The old version is the file before any modifications in the user's
998 workspace, i.e. the 'left hand side'.
999
1000 Contents will be empty if the file is a directory or does not exist.
1001 Note: The carriage returns (LF or CR) are stripped off.
1002 """
1003 return self._diff_cache.GetOldContents(self.LocalPath(),
1004 self._local_root).splitlines()
1005
1006 def NewContents(self):
1007 """Returns an iterator over the lines in the new version of file.
1008
1009 The new version is the file in the user's workspace, i.e. the 'right hand
1010 side'.
1011
1012 Contents will be empty if the file is a directory or does not exist.
1013 Note: The carriage returns (LF or CR) are stripped off.
1014 """
1015 if self._cached_new_contents is None:
1016 self._cached_new_contents = []
1017 try:
1018 self._cached_new_contents = gclient_utils.FileRead(
1019 self.AbsoluteLocalPath(), 'rU').splitlines()
1020 except IOError:
1021 pass # File not found? That's fine; maybe it was deleted.
1022 except UnicodeDecodeError as e:
1023 # log the filename since we're probably trying to read a binary
1024 # file, and shouldn't be.
1025 print('Error reading %s: %s' % (self.AbsoluteLocalPath(), e))
1026 raise
1027
1028 return self._cached_new_contents[:]
1029
1030 def ChangedContents(self, keeplinebreaks=False):
1031 """Returns a list of tuples (line number, line text) of all new lines.
1032
1033 This relies on the scm diff output describing each changed code section
1034 with a line of the form
1035
1036 ^@@ <old line num>,<old size> <new line num>,<new size> @@$
1037 """
1038 # Don't return cached results when line breaks are requested.
1039 if not keeplinebreaks and self._cached_changed_contents is not None:
1040 return self._cached_changed_contents[:]
1041 result = []
1042 line_num = 0
1043
1044 # The keeplinebreaks parameter to splitlines must be True or else the
1045 # CheckForWindowsLineEndings presubmit will be a NOP.
1046 for line in self.GenerateScmDiff().splitlines(keeplinebreaks):
1047 m = re.match(r'^@@ [0-9\,\+\-]+ \+([0-9]+)\,[0-9]+ @@', line)
1048 if m:
1049 line_num = int(m.groups(1)[0])
1050 continue
1051 if line.startswith('+') and not line.startswith('++'):
1052 result.append((line_num, line[1:]))
1053 if not line.startswith('-'):
1054 line_num += 1
1055 # Don't cache results with line breaks.
1056 if keeplinebreaks:
1057 return result;
1058 self._cached_changed_contents = result
1059 return self._cached_changed_contents[:]
1060
1061 def __str__(self):
1062 return self.LocalPath()
1063
1064 def GenerateScmDiff(self):
1065 return self._diff_cache.GetDiff(self.LocalPath(), self._local_root)
1066
1067
1068class GitAffectedFile(AffectedFile):
1069 """Representation of a file in a change out of a git checkout."""
1070 # Method 'NNN' is abstract in class 'NNN' but is not overridden
1071 # pylint: disable=abstract-method
1072
1073 DIFF_CACHE = _GitDiffCache
1074
1075 def __init__(self, *args, **kwargs):
1076 AffectedFile.__init__(self, *args, **kwargs)
1077 self._server_path = None
1078 self._is_testable_file = None
1079
1080 def IsTestableFile(self):
1081 if self._is_testable_file is None:
1082 if self.Action() == 'D':
1083 # A deleted file is not testable.
1084 self._is_testable_file = False
1085 else:
1086 self._is_testable_file = os.path.isfile(self.AbsoluteLocalPath())
1087 return self._is_testable_file
1088
1089
1090class Change(object):
1091 """Describe a change.
1092
1093 Used directly by the presubmit scripts to query the current change being
1094 tested.
1095
1096 Instance members:
1097 tags: Dictionary of KEY=VALUE pairs found in the change description.
1098 self.KEY: equivalent to tags['KEY']
1099 """
1100
1101 _AFFECTED_FILES = AffectedFile
1102
1103 # Matches key/value (or 'tag') lines in changelist descriptions.
1104 TAG_LINE_RE = re.compile(
1105 '^[ \t]*(?P<key>[A-Z][A-Z_0-9]*)[ \t]*=[ \t]*(?P<value>.*?)[ \t]*$')
1106 scm = ''
1107
1108 def __init__(
1109 self, name, description, local_root, files, issue, patchset, author,
1110 upstream=None):
1111 if files is None:
1112 files = []
1113 self._name = name
1114 # Convert root into an absolute path.
1115 self._local_root = os.path.abspath(local_root)
1116 self._upstream = upstream
1117 self.issue = issue
1118 self.patchset = patchset
1119 self.author_email = author
1120
1121 self._full_description = ''
1122 self.tags = {}
1123 self._description_without_tags = ''
1124 self.SetDescriptionText(description)
1125
1126 assert all(
1127 (isinstance(f, (list, tuple)) and len(f) == 2) for f in files), files
1128
1129 diff_cache = self._AFFECTED_FILES.DIFF_CACHE(self._upstream)
1130 self._affected_files = [
1131 self._AFFECTED_FILES(path, action.strip(), self._local_root, diff_cache)
1132 for action, path in files
1133 ]
1134
1135 def UpstreamBranch(self):
1136 """Returns the upstream branch for the change."""
1137 return self._upstream
1138
1139 def Name(self):
1140 """Returns the change name."""
1141 return self._name
1142
1143 def DescriptionText(self):
1144 """Returns the user-entered changelist description, minus tags.
1145
1146 Any line in the user-provided description starting with e.g. 'FOO='
1147 (whitespace permitted before and around) is considered a tag line. Such
1148 lines are stripped out of the description this function returns.
1149 """
1150 return self._description_without_tags
1151
1152 def FullDescriptionText(self):
1153 """Returns the complete changelist description including tags."""
1154 return self._full_description
1155
1156 def SetDescriptionText(self, description):
1157 """Sets the full description text (including tags) to |description|.
1158
1159 Also updates the list of tags."""
1160 self._full_description = description
1161
1162 # From the description text, build up a dictionary of key/value pairs
1163 # plus the description minus all key/value or 'tag' lines.
1164 description_without_tags = []
1165 self.tags = {}
1166 for line in self._full_description.splitlines():
1167 m = self.TAG_LINE_RE.match(line)
1168 if m:
1169 self.tags[m.group('key')] = m.group('value')
1170 else:
1171 description_without_tags.append(line)
1172
1173 # Change back to text and remove whitespace at end.
1174 self._description_without_tags = (
1175 '\n'.join(description_without_tags).rstrip())
1176
1177 def AddDescriptionFooter(self, key, value):
1178 """Adds the given footer to the change description.
1179
1180 Args:
1181 key: A string with the key for the git footer. It must conform to
1182 the git footers format (i.e. 'List-Of-Tokens') and will be case
1183 normalized so that each token is title-cased.
1184 value: A string with the value for the git footer.
1185 """
1186 description = git_footers.add_footer(
1187 self.FullDescriptionText(), git_footers.normalize_name(key), value)
1188 self.SetDescriptionText(description)
1189
1190 def RepositoryRoot(self):
1191 """Returns the repository (checkout) root directory for this change,
1192 as an absolute path.
1193 """
1194 return self._local_root
1195
1196 def __getattr__(self, attr):
1197 """Return tags directly as attributes on the object."""
1198 if not re.match(r'^[A-Z_]*$', attr):
1199 raise AttributeError(self, attr)
1200 return self.tags.get(attr)
1201
1202 def GitFootersFromDescription(self):
1203 """Return the git footers present in the description.
1204
1205 Returns:
1206 footers: A dict of {footer: [values]} containing a multimap of the footers
1207 in the change description.
1208 """
1209 return git_footers.parse_footers(self.FullDescriptionText())
1210
1211 def BugsFromDescription(self):
1212 """Returns all bugs referenced in the commit description."""
1213 bug_tags = ['BUG', 'FIXED']
1214
1215 tags = []
1216 for tag in bug_tags:
1217 values = self.tags.get(tag)
1218 if values:
1219 tags += [value.strip() for value in values.split(',')]
1220
1221 footers = []
1222 parsed = self.GitFootersFromDescription()
1223 unsplit_footers = parsed.get('Bug', []) + parsed.get('Fixed', [])
1224 for unsplit_footer in unsplit_footers:
1225 footers += [b.strip() for b in unsplit_footer.split(',')]
1226 return sorted(set(tags + footers))
1227
1228 def ReviewersFromDescription(self):
1229 """Returns all reviewers listed in the commit description."""
1230 # We don't support a 'R:' git-footer for reviewers; that is in metadata.
1231 tags = [r.strip() for r in self.tags.get('R', '').split(',') if r.strip()]
1232 return sorted(set(tags))
1233
1234 def TBRsFromDescription(self):
1235 """Returns all TBR reviewers listed in the commit description."""
1236 tags = [r.strip() for r in self.tags.get('TBR', '').split(',') if r.strip()]
1237 # TODO(crbug.com/839208): Remove support for 'Tbr:' when TBRs are
1238 # programmatically determined by self-CR+1s.
1239 footers = self.GitFootersFromDescription().get('Tbr', [])
1240 return sorted(set(tags + footers))
1241
1242 # TODO(crbug.com/753425): Delete these once we're sure they're unused.
1243 @property
1244 def BUG(self):
1245 return ','.join(self.BugsFromDescription())
1246 @property
1247 def R(self):
1248 return ','.join(self.ReviewersFromDescription())
1249 @property
1250 def TBR(self):
1251 return ','.join(self.TBRsFromDescription())
1252
1253 def AllFiles(self, root=None):
1254 """List all files under source control in the repo."""
1255 raise NotImplementedError()
1256
1257 def AffectedFiles(self, include_deletes=True, file_filter=None):
1258 """Returns a list of AffectedFile instances for all files in the change.
1259
1260 Args:
1261 include_deletes: If false, deleted files will be filtered out.
1262 file_filter: An additional filter to apply.
1263
1264 Returns:
1265 [AffectedFile(path, action), AffectedFile(path, action)]
1266 """
1267 affected = list(filter(file_filter, self._affected_files))
1268
1269 if include_deletes:
1270 return affected
1271 return list(filter(lambda x: x.Action() != 'D', affected))
1272
1273 def AffectedTestableFiles(self, include_deletes=None, **kwargs):
1274 """Return a list of the existing text files in a change."""
1275 if include_deletes is not None:
1276 warn('AffectedTeestableFiles(include_deletes=%s)'
1277 ' is deprecated and ignored' % str(include_deletes),
1278 category=DeprecationWarning,
1279 stacklevel=2)
1280 return list(filter(
1281 lambda x: x.IsTestableFile(),
1282 self.AffectedFiles(include_deletes=False, **kwargs)))
1283
1284 def AffectedTextFiles(self, include_deletes=None):
1285 """An alias to AffectedTestableFiles for backwards compatibility."""
1286 return self.AffectedTestableFiles(include_deletes=include_deletes)
1287
1288 def LocalPaths(self):
1289 """Convenience function."""
1290 return [af.LocalPath() for af in self.AffectedFiles()]
1291
1292 def AbsoluteLocalPaths(self):
1293 """Convenience function."""
1294 return [af.AbsoluteLocalPath() for af in self.AffectedFiles()]
1295
1296 def RightHandSideLines(self):
1297 """An iterator over all text lines in 'new' version of changed files.
1298
1299 Lists lines from new or modified text files in the change.
1300
1301 This is useful for doing line-by-line regex checks, like checking for
1302 trailing whitespace.
1303
1304 Yields:
1305 a 3 tuple:
1306 the AffectedFile instance of the current file;
1307 integer line number (1-based); and
1308 the contents of the line as a string.
1309 """
1310 return _RightHandSideLinesImpl(
1311 x for x in self.AffectedFiles(include_deletes=False)
1312 if x.IsTestableFile())
1313
1314 def OriginalOwnersFiles(self):
1315 """A map from path names of affected OWNERS files to their old content."""
1316 def owners_file_filter(f):
1317 return 'OWNERS' in os.path.split(f.LocalPath())[1]
1318 files = self.AffectedFiles(file_filter=owners_file_filter)
1319 return {f.LocalPath(): f.OldContents() for f in files}
1320
1321
1322class GitChange(Change):
1323 _AFFECTED_FILES = GitAffectedFile
1324 scm = 'git'
1325
1326 def AllFiles(self, root=None):
1327 """List all files under source control in the repo."""
1328 root = root or self.RepositoryRoot()
1329 return subprocess.check_output(
1330 ['git', '-c', 'core.quotePath=false', 'ls-files', '--', '.'],
1331 cwd=root).decode('utf-8', 'ignore').splitlines()
1332
1333
Josip Sokcevica9a7eec2023-03-10 03:54:52 +00001334def ListRelevantPresubmitFiles(files, root):
1335 """Finds all presubmit files that apply to a given set of source files.
1336
1337 If inherit-review-settings-ok is present right under root, looks for
1338 PRESUBMIT.py in directories enclosing root.
1339
1340 Args:
1341 files: An iterable container containing file paths.
1342 root: Path where to stop searching.
1343
1344 Return:
1345 List of absolute paths of the existing PRESUBMIT.py scripts.
1346 """
1347 files = [normpath(os.path.join(root, f)) for f in files]
1348
1349 # List all the individual directories containing files.
1350 directories = {os.path.dirname(f) for f in files}
1351
1352 # Ignore root if inherit-review-settings-ok is present.
1353 if os.path.isfile(os.path.join(root, 'inherit-review-settings-ok')):
1354 root = None
1355
1356 # Collect all unique directories that may contain PRESUBMIT.py.
1357 candidates = set()
1358 for directory in directories:
1359 while True:
1360 if directory in candidates:
1361 break
1362 candidates.add(directory)
1363 if directory == root:
1364 break
1365 parent_dir = os.path.dirname(directory)
1366 if parent_dir == directory:
1367 # We hit the system root directory.
1368 break
1369 directory = parent_dir
1370
1371 # Look for PRESUBMIT.py in all candidate directories.
1372 results = []
1373 for directory in sorted(list(candidates)):
1374 try:
1375 for f in os.listdir(directory):
1376 p = os.path.join(directory, f)
1377 if os.path.isfile(p) and re.match(
1378 r'PRESUBMIT.*\.py$', f) and not f.startswith('PRESUBMIT_test'):
1379 results.append(p)
1380 except OSError:
1381 pass
1382
1383 logging.debug('Presubmit files: %s', ','.join(results))
1384 return results
1385
1386
rmistry@google.com5626a922015-02-26 14:03:30 +00001387class GetPostUploadExecuter(object):
Pavol Marko624e7ee2023-01-09 09:56:29 +00001388 def __init__(self, change, gerrit_obj, use_python3):
Josip Sokcevice293d3d2022-02-16 22:52:15 +00001389 """
1390 Args:
Pavol Marko624e7ee2023-01-09 09:56:29 +00001391 change: The Change object.
1392 gerrit_obj: provides basic Gerrit codereview functionality.
Josip Sokcevice293d3d2022-02-16 22:52:15 +00001393 use_python3: if true, will use python3 instead of python2 by default
1394 if USE_PYTHON3 is not specified.
1395 """
Pavol Marko624e7ee2023-01-09 09:56:29 +00001396 self.change = change
1397 self.gerrit = gerrit_obj
Josip Sokcevice293d3d2022-02-16 22:52:15 +00001398 self.use_python3 = use_python3
1399
Pavol Marko624e7ee2023-01-09 09:56:29 +00001400 def ExecPresubmitScript(self, script_text, presubmit_path):
rmistry@google.com5626a922015-02-26 14:03:30 +00001401 """Executes PostUploadHook() from a single presubmit script.
Josip Sokcevic632bbc02022-05-19 05:32:50 +00001402 Caller is responsible for validating whether the hook should be executed
1403 and should only call this function if it should be.
rmistry@google.com5626a922015-02-26 14:03:30 +00001404
1405 Args:
1406 script_text: The text of the presubmit script.
1407 presubmit_path: Project script to run.
rmistry@google.com5626a922015-02-26 14:03:30 +00001408
1409 Return:
1410 A list of results objects.
1411 """
Pavol Marko624e7ee2023-01-09 09:56:29 +00001412 # Change to the presubmit file's directory to support local imports.
1413 presubmit_dir = os.path.dirname(presubmit_path)
1414 main_path = os.getcwd()
1415 try:
1416 os.chdir(presubmit_dir)
1417 return self._execute_with_local_working_directory(script_text,
1418 presubmit_dir,
1419 presubmit_path)
1420 finally:
1421 # Return the process to the original working directory.
1422 os.chdir(main_path)
1423
1424 def _execute_with_local_working_directory(self, script_text, presubmit_dir,
1425 presubmit_path):
rmistry@google.com5626a922015-02-26 14:03:30 +00001426 context = {}
1427 try:
Pavol Marko624e7ee2023-01-09 09:56:29 +00001428 exec(compile(script_text, presubmit_path, 'exec', dont_inherit=True),
Raul Tambre09e64b42019-05-14 01:57:22 +00001429 context)
Raul Tambre7c938462019-05-24 16:35:35 +00001430 except Exception as e:
rmistry@google.com5626a922015-02-26 14:03:30 +00001431 raise PresubmitFailure('"%s" had an exception.\n%s'
1432 % (presubmit_path, e))
1433
1434 function_name = 'PostUploadHook'
1435 if function_name not in context:
1436 return {}
1437 post_upload_hook = context[function_name]
1438 if not len(inspect.getargspec(post_upload_hook)[0]) == 3:
1439 raise PresubmitFailure(
1440 'Expected function "PostUploadHook" to take three arguments.')
Pavol Marko624e7ee2023-01-09 09:56:29 +00001441 return post_upload_hook(self.gerrit, self.change, OutputApi(False))
rmistry@google.com5626a922015-02-26 14:03:30 +00001442
1443
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001444def _MergeMasters(masters1, masters2):
1445 """Merges two master maps. Merges also the tests of each builder."""
1446 result = {}
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001447 for (master, builders) in itertools.chain(masters1.items(),
1448 masters2.items()):
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001449 new_builders = result.setdefault(master, {})
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001450 for (builder, tests) in builders.items():
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001451 new_builders.setdefault(builder, set([])).update(tests)
1452 return result
1453
1454
Josip Sokcevice293d3d2022-02-16 22:52:15 +00001455def DoPostUploadExecuter(change, gerrit_obj, verbose, use_python3=False):
rmistry@google.com5626a922015-02-26 14:03:30 +00001456 """Execute the post upload hook.
1457
1458 Args:
1459 change: The Change object.
Edward Lemur016a0872020-02-04 22:13:28 +00001460 gerrit_obj: The GerritAccessor object.
rmistry@google.com5626a922015-02-26 14:03:30 +00001461 verbose: Prints debug info.
Josip Sokcevice293d3d2022-02-16 22:52:15 +00001462 use_python3: if true, default to using Python3 for presubmit checks
1463 rather than Python2.
rmistry@google.com5626a922015-02-26 14:03:30 +00001464 """
Josip Sokcevice293d3d2022-02-16 22:52:15 +00001465 python_version = 'Python %s' % sys.version_info.major
1466 sys.stdout.write('Running %s post upload checks ...\n' % python_version)
Josip Sokcevica9a7eec2023-03-10 03:54:52 +00001467 presubmit_files = ListRelevantPresubmitFiles(
1468 change.LocalPaths(), change.RepositoryRoot())
rmistry@google.com5626a922015-02-26 14:03:30 +00001469 if not presubmit_files and verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001470 sys.stdout.write('Warning, no PRESUBMIT.py found.\n')
rmistry@google.com5626a922015-02-26 14:03:30 +00001471 results = []
Pavol Marko624e7ee2023-01-09 09:56:29 +00001472 executer = GetPostUploadExecuter(change, gerrit_obj, use_python3)
rmistry@google.com5626a922015-02-26 14:03:30 +00001473 # The root presubmit file should be executed after the ones in subdirectories.
1474 # i.e. the specific post upload hooks should run before the general ones.
Josip Sokcevica9a7eec2023-03-10 03:54:52 +00001475 # Thus, reverse the order provided by ListRelevantPresubmitFiles.
rmistry@google.com5626a922015-02-26 14:03:30 +00001476 presubmit_files.reverse()
1477
1478 for filename in presubmit_files:
1479 filename = os.path.abspath(filename)
rmistry@google.com5626a922015-02-26 14:03:30 +00001480 # Accept CRLF presubmit script.
Bruce Dawson6e70e862022-07-01 19:37:01 +00001481 presubmit_script = gclient_utils.FileRead(filename).replace('\r\n', '\n')
Bruce Dawson119cff32023-05-09 18:07:19 +00001482 if verbose:
1483 sys.stdout.write('Running %s\n' % filename)
1484 results.extend(executer.ExecPresubmitScript(presubmit_script, filename))
rmistry@google.com5626a922015-02-26 14:03:30 +00001485
Edward Lemur6eb1d322020-02-27 22:20:15 +00001486 if not results:
1487 return 0
1488
1489 sys.stdout.write('\n')
1490 sys.stdout.write('** Post Upload Hook Messages **\n')
1491
1492 exit_code = 0
1493 for result in results:
1494 if result.fatal:
1495 exit_code = 1
1496 result.handle()
1497 sys.stdout.write('\n')
1498
1499 return exit_code
rmistry@google.com5626a922015-02-26 14:03:30 +00001500
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001501class PresubmitExecuter(object):
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001502 def __init__(self, change, committing, verbose, gerrit_obj, dry_run=None,
Bruce Dawson09c0c072022-05-26 20:28:58 +00001503 thread_pool=None, parallel=False, use_python3=False,
1504 no_diffs=False):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001505 """
1506 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001507 change: The Change object.
agable92bec4f2016-08-24 09:27:27 -07001508 committing: True if 'git cl land' is running, False if 'git cl upload' is.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001509 gerrit_obj: provides basic Gerrit codereview functionality.
1510 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -04001511 parallel: if true, all tests reported via input_api.RunTests for all
1512 PRESUBMIT files will be run in parallel.
Dirk Pranke6f0df682021-06-25 00:42:33 +00001513 use_python3: if true, will use python3 instead of python2 by default
1514 if USE_PYTHON3 is not specified.
Bruce Dawson09c0c072022-05-26 20:28:58 +00001515 no_diffs: if true, implies that --files or --all was specified so some
1516 checks can be skipped, and some errors will be messages.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001517 """
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001518 self.change = change
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001519 self.committing = committing
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001520 self.gerrit = gerrit_obj
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001521 self.verbose = verbose
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001522 self.dry_run = dry_run
Daniel Cheng7227d212017-11-17 08:12:37 -08001523 self.more_cc = []
Edward Lesmes8e282792018-04-03 18:50:29 -04001524 self.thread_pool = thread_pool
1525 self.parallel = parallel
Dirk Pranke6f0df682021-06-25 00:42:33 +00001526 self.use_python3 = use_python3
Bruce Dawson09c0c072022-05-26 20:28:58 +00001527 self.no_diffs = no_diffs
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001528
1529 def ExecPresubmitScript(self, script_text, presubmit_path):
1530 """Executes a single presubmit script.
Josip Sokcevic632bbc02022-05-19 05:32:50 +00001531 Caller is responsible for validating whether the hook should be executed
1532 and should only call this function if it should be.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001533
1534 Args:
1535 script_text: The text of the presubmit script.
1536 presubmit_path: The path to the presubmit file (this will be reported via
1537 input_api.PresubmitLocalPath()).
1538
1539 Return:
1540 A list of result objects, empty if no problems.
1541 """
chase@chromium.org8e416c82009-10-06 04:30:44 +00001542 # Change to the presubmit file's directory to support local imports.
Saagar Sanghavi98b332f2020-07-31 17:19:15 +00001543 presubmit_dir = os.path.dirname(presubmit_path)
Pavol Marko624e7ee2023-01-09 09:56:29 +00001544 main_path = os.getcwd()
1545 try:
1546 os.chdir(presubmit_dir)
1547 return self._execute_with_local_working_directory(script_text,
1548 presubmit_dir,
1549 presubmit_path)
1550 finally:
1551 # Return the process to the original working directory.
1552 os.chdir(main_path)
chase@chromium.org8e416c82009-10-06 04:30:44 +00001553
Pavol Marko624e7ee2023-01-09 09:56:29 +00001554 def _execute_with_local_working_directory(self, script_text, presubmit_dir,
1555 presubmit_path):
chase@chromium.org8e416c82009-10-06 04:30:44 +00001556 # Load the presubmit script into context.
dpranke@chromium.org970c5222011-03-12 00:32:24 +00001557 input_api = InputApi(self.change, presubmit_path, self.committing,
Aaron Gable668c1d82018-04-03 10:19:16 -07001558 self.verbose, gerrit_obj=self.gerrit,
Edward Lesmes8e282792018-04-03 18:50:29 -04001559 dry_run=self.dry_run, thread_pool=self.thread_pool,
Bruce Dawson09c0c072022-05-26 20:28:58 +00001560 parallel=self.parallel, no_diffs=self.no_diffs)
Daniel Cheng7227d212017-11-17 08:12:37 -08001561 output_api = OutputApi(self.committing)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001562 context = {}
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001563
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001564 try:
Bruce Dawson0ba2fd42022-07-21 13:47:21 +00001565 exec(compile(script_text, presubmit_path, 'exec', dont_inherit=True),
Raul Tambre09e64b42019-05-14 01:57:22 +00001566 context)
Raul Tambre7c938462019-05-24 16:35:35 +00001567 except Exception as e:
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001568 raise PresubmitFailure('"%s" had an exception.\n%s' % (presubmit_path, e))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001569
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001570 context['__args'] = (input_api, output_api)
Ben Pastene8351dc12020-08-06 05:01:35 +00001571
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001572 # Get path of presubmit directory relative to repository root.
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001573 # Always use forward slashes, so that path is same in *nix and Windows
1574 root = input_api.change.RepositoryRoot()
1575 rel_path = os.path.relpath(presubmit_dir, root)
1576 rel_path = rel_path.replace(os.path.sep, '/')
Ben Pastene8351dc12020-08-06 05:01:35 +00001577
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001578 # Get the URL of git remote origin and use it to identify host and project
Edward Lesmeseb1bd622021-03-01 19:54:07 +00001579 host = project = ''
1580 if self.gerrit:
1581 host = self.gerrit.host or ''
1582 project = self.gerrit.project or ''
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001583
1584 # Prefix for test names
1585 prefix = 'presubmit:%s/%s:%s/' % (host, project, rel_path)
1586
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001587 # Perform all the desired presubmit checks.
1588 results = []
Ben Pastene8351dc12020-08-06 05:01:35 +00001589
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001590 try:
Scott Leecc2fe9b2020-11-19 19:38:06 +00001591 version = [
1592 int(x) for x in context.get('PRESUBMIT_VERSION', '0.0.0').split('.')
1593 ]
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001594
Scott Leecc2fe9b2020-11-19 19:38:06 +00001595 with rdb_wrapper.client(prefix) as sink:
1596 if version >= [2, 0, 0]:
Andrew Grievebdfb8f22022-02-02 21:56:47 +00001597 # Copy the keys to prevent "dictionary changed size during iteration"
1598 # exception if checks add globals to context. E.g. sometimes the
1599 # Python runtime will add __warningregistry__.
1600 for function_name in list(context.keys()):
Scott Leecc2fe9b2020-11-19 19:38:06 +00001601 if not function_name.startswith('Check'):
1602 continue
1603 if function_name.endswith('Commit') and not self.committing:
1604 continue
1605 if function_name.endswith('Upload') and self.committing:
1606 continue
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001607 logging.debug('Running %s in %s', function_name, presubmit_path)
1608 results.extend(
Bruce Dawson8fa42e22022-03-29 17:05:38 +00001609 self._run_check_function(function_name, context, sink,
1610 presubmit_path))
Scott Leecc2fe9b2020-11-19 19:38:06 +00001611 logging.debug('Running %s done.', function_name)
1612 self.more_cc.extend(output_api.more_cc)
1613
1614 else: # Old format
1615 if self.committing:
1616 function_name = 'CheckChangeOnCommit'
1617 else:
1618 function_name = 'CheckChangeOnUpload'
Andrew Grievebdfb8f22022-02-02 21:56:47 +00001619 if function_name in list(context.keys()):
Scott Leecc2fe9b2020-11-19 19:38:06 +00001620 logging.debug('Running %s in %s', function_name, presubmit_path)
1621 results.extend(
Bruce Dawson8fa42e22022-03-29 17:05:38 +00001622 self._run_check_function(function_name, context, sink,
1623 presubmit_path))
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001624 logging.debug('Running %s done.', function_name)
1625 self.more_cc.extend(output_api.more_cc)
1626
1627 finally:
1628 for f in input_api._named_temporary_files:
1629 os.remove(f)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001630
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001631 return results
1632
Bruce Dawson8fa42e22022-03-29 17:05:38 +00001633 def _run_check_function(self, function_name, context, sink, presubmit_path):
Scott Leecc2fe9b2020-11-19 19:38:06 +00001634 """Evaluates and returns the result of a given presubmit function.
1635
1636 If sink is given, the result of the presubmit function will be reported
1637 to the ResultSink.
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001638
1639 Args:
Scott Leecc2fe9b2020-11-19 19:38:06 +00001640 function_name: the name of the presubmit function to evaluate
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001641 context: a context dictionary in which the function will be evaluated
Scott Leecc2fe9b2020-11-19 19:38:06 +00001642 sink: an instance of ResultSink. None, by default.
1643 Returns:
1644 the result of the presubmit function call.
1645 """
1646 start_time = time_time()
1647 try:
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001648 result = eval(function_name + '(*__args)', context)
1649 self._check_result_type(result)
Allen Webbfe7d7092021-05-18 02:05:49 +00001650 except Exception:
Bruce Dawson10a82862022-05-27 19:25:56 +00001651 _, e_value, _ = sys.exc_info()
1652 result = [
1653 OutputApi.PresubmitError(
1654 'Evaluation of %s failed: %s, %s' %
1655 (function_name, e_value, traceback.format_exc()))
1656 ]
Scott Leecc2fe9b2020-11-19 19:38:06 +00001657
Bruce Dawson2bdc49f2021-05-21 19:13:03 +00001658 elapsed_time = time_time() - start_time
1659 if elapsed_time > 10.0:
Bruce Dawson6757d462022-07-13 04:04:40 +00001660 sys.stdout.write('%6.1fs to run %s from %s.\n' %
1661 (elapsed_time, function_name, presubmit_path))
Scott Leecc2fe9b2020-11-19 19:38:06 +00001662 if sink:
Erik Staab9f38b632022-10-31 14:05:24 +00001663 failure_reason = None
Scott Leecc2fe9b2020-11-19 19:38:06 +00001664 status = rdb_wrapper.STATUS_PASS
1665 if any(r.fatal for r in result):
1666 status = rdb_wrapper.STATUS_FAIL
Erik Staab9f38b632022-10-31 14:05:24 +00001667 failure_reasons = []
1668 for r in result:
1669 fields = r.json_format()
1670 message = fields['message']
1671 items = '\n'.join(' %s' % item for item in fields['items'])
1672 failure_reasons.append('\n'.join([message, items]))
1673 if failure_reasons:
1674 failure_reason = '\n'.join(failure_reasons)
1675 sink.report(function_name, status, elapsed_time, failure_reason)
Scott Leecc2fe9b2020-11-19 19:38:06 +00001676
1677 return result
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001678
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00001679 def _check_result_type(self, result):
1680 """Helper function which ensures result is a list, and all elements are
1681 instances of OutputApi.PresubmitResult"""
1682 if not isinstance(result, (tuple, list)):
1683 raise PresubmitFailure('Presubmit functions must return a tuple or list')
1684 if not all(isinstance(res, OutputApi.PresubmitResult) for res in result):
1685 raise PresubmitFailure(
1686 'All presubmit results must be of types derived from '
1687 'output_api.PresubmitResult')
1688
1689
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001690def DoPresubmitChecks(change,
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001691 committing,
1692 verbose,
maruel@chromium.orgb0dfd352009-06-10 14:12:54 +00001693 default_presubmit,
dpranke@chromium.org970c5222011-03-12 00:32:24 +00001694 may_prompt,
Aaron Gable668c1d82018-04-03 10:19:16 -07001695 gerrit_obj,
Edward Lesmes8e282792018-04-03 18:50:29 -04001696 dry_run=None,
Debrian Figueroadd2737e2019-06-21 23:50:13 +00001697 parallel=False,
Dirk Pranke6f0df682021-06-25 00:42:33 +00001698 json_output=None,
Bruce Dawson09c0c072022-05-26 20:28:58 +00001699 use_python3=False,
1700 no_diffs=False):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001701 """Runs all presubmit checks that apply to the files in the change.
1702
1703 This finds all PRESUBMIT.py files in directories enclosing the files in the
1704 change (up to the repository root) and calls the relevant entrypoint function
1705 depending on whether the change is being committed or uploaded.
1706
1707 Prints errors, warnings and notifications. Prompts the user for warnings
1708 when needed.
1709
1710 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001711 change: The Change object.
agable92bec4f2016-08-24 09:27:27 -07001712 committing: True if 'git cl land' is running, False if 'git cl upload' is.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001713 verbose: Prints debug info.
maruel@chromium.org0ff1fab2009-05-22 13:08:15 +00001714 default_presubmit: A default presubmit script to execute in any case.
Quinten Yearsley516fe7f2016-12-14 11:50:18 -08001715 may_prompt: Enable (y/n) questions on warning or error. If False,
1716 any questions are answered with yes by default.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001717 gerrit_obj: provides basic Gerrit codereview functionality.
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001718 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -04001719 parallel: if true, all tests specified by input_api.RunTests in all
1720 PRESUBMIT files will be run in parallel.
Dirk Pranke6f0df682021-06-25 00:42:33 +00001721 use_python3: if true, default to using Python3 for presubmit checks
1722 rather than Python2.
Bruce Dawson09c0c072022-05-26 20:28:58 +00001723 no_diffs: if true, implies that --files or --all was specified so some
1724 checks can be skipped, and some errors will be messages.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001725 Return:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001726 1 if presubmit checks failed or 0 otherwise.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001727 """
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001728 old_environ = os.environ
1729 try:
1730 # Make sure python subprocesses won't generate .pyc files.
1731 os.environ = os.environ.copy()
Edward Lemurb9830242019-10-30 22:19:20 +00001732 os.environ['PYTHONDONTWRITEBYTECODE'] = '1'
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001733
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001734 python_version = 'Python %s' % sys.version_info.major
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001735 if committing:
Dirk Pranke6fc394f2021-05-26 23:25:14 +00001736 sys.stdout.write('Running %s presubmit commit checks ...\n' %
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001737 python_version)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001738 else:
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001739 sys.stdout.write('Running %s presubmit upload checks ...\n' %
1740 python_version)
Edward Lemurecc27072020-01-06 16:42:34 +00001741 start_time = time_time()
Josip Sokcevica9a7eec2023-03-10 03:54:52 +00001742 presubmit_files = ListRelevantPresubmitFiles(
1743 change.AbsoluteLocalPaths(), change.RepositoryRoot())
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001744 if not presubmit_files and verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001745 sys.stdout.write('Warning, no PRESUBMIT.py found.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001746 results = []
Bruce Dawsonc9f904f2022-10-14 20:59:49 +00001747 if sys.platform == 'win32':
1748 temp = os.environ['TEMP']
1749 else:
1750 temp = '/tmp'
1751 python2_usage_log_file = os.path.join(temp, 'python2_usage.txt')
Bruce Dawsonf2b04212022-06-10 16:42:54 +00001752 if os.path.exists(python2_usage_log_file):
1753 os.remove(python2_usage_log_file)
Edward Lesmes8e282792018-04-03 18:50:29 -04001754 thread_pool = ThreadPool()
Edward Lemur7e3c67f2018-07-20 20:52:49 +00001755 executer = PresubmitExecuter(change, committing, verbose, gerrit_obj,
Bruce Dawson09c0c072022-05-26 20:28:58 +00001756 dry_run, thread_pool, parallel, use_python3,
1757 no_diffs)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001758 if default_presubmit:
1759 if verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001760 sys.stdout.write('Running default presubmit script.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001761 fake_path = os.path.join(change.RepositoryRoot(), 'PRESUBMIT.py')
Bruce Dawson119cff32023-05-09 18:07:19 +00001762 results += executer.ExecPresubmitScript(default_presubmit, fake_path)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001763 for filename in presubmit_files:
1764 filename = os.path.abspath(filename)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001765 # Accept CRLF presubmit script.
Bruce Dawson6e70e862022-07-01 19:37:01 +00001766 presubmit_script = gclient_utils.FileRead(filename).replace('\r\n', '\n')
Bruce Dawson119cff32023-05-09 18:07:19 +00001767 if verbose:
1768 sys.stdout.write('Running %s\n' % filename)
1769 results += executer.ExecPresubmitScript(presubmit_script, filename)
Bruce Dawson76fe1a72022-05-25 20:52:21 +00001770
Edward Lesmes8e282792018-04-03 18:50:29 -04001771 results += thread_pool.RunAsync()
1772
Bruce Dawsonf2b04212022-06-10 16:42:54 +00001773 if os.path.exists(python2_usage_log_file):
1774 with open(python2_usage_log_file) as f:
1775 python2_usage = [x.strip() for x in f.readlines()]
1776 results.append(
1777 OutputApi(committing).PresubmitPromptWarning(
1778 'Python 2 scripts were run during %s presubmits. Please see '
1779 'https://bugs.chromium.org/p/chromium/issues/detail?id=1313804'
1780 '#c61 for tips on resolving this.'
1781 % python_version,
1782 items=python2_usage))
1783
Edward Lemur6eb1d322020-02-27 22:20:15 +00001784 messages = {}
1785 should_prompt = False
1786 presubmits_failed = False
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001787 for result in results:
1788 if result.fatal:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001789 presubmits_failed = True
1790 messages.setdefault('ERRORS', []).append(result)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001791 elif result.should_prompt:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001792 should_prompt = True
1793 messages.setdefault('Warnings', []).append(result)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001794 else:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001795 messages.setdefault('Messages', []).append(result)
pam@chromium.orged9a0832009-09-09 22:48:55 +00001796
Bruce Dawson76fe1a72022-05-25 20:52:21 +00001797 # Print the different message types in a consistent order. ERRORS go last
1798 # so that they will be most visible in the local-presubmit output.
1799 for name in ['Messages', 'Warnings', 'ERRORS']:
1800 if name in messages:
1801 items = messages[name]
Gavin Makd22bf602022-07-11 21:10:41 +00001802 sys.stdout.write('** Presubmit %s: %d **\n' % (name, len(items)))
Bruce Dawson76fe1a72022-05-25 20:52:21 +00001803 for item in items:
1804 item.handle()
1805 sys.stdout.write('\n')
pam@chromium.orged9a0832009-09-09 22:48:55 +00001806
Edward Lemurecc27072020-01-06 16:42:34 +00001807 total_time = time_time() - start_time
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001808 if total_time > 1.0:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001809 sys.stdout.write(
Louis Romero4ca9e1c2022-03-10 10:29:11 +00001810 'Presubmit checks took %.1fs to calculate.\n' % total_time)
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +00001811
Edward Lemur6eb1d322020-02-27 22:20:15 +00001812 if not should_prompt and not presubmits_failed:
Louis Romero4ca9e1c2022-03-10 10:29:11 +00001813 sys.stdout.write('%s presubmit checks passed.\n\n' % python_version)
Josip Sokcevic7592e0a2022-01-12 00:57:54 +00001814 elif should_prompt and not presubmits_failed:
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001815 sys.stdout.write('There were %s presubmit warnings. ' % python_version)
Quinten Yearsley516fe7f2016-12-14 11:50:18 -08001816 if may_prompt:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001817 presubmits_failed = not prompt_should_continue(
1818 'Are you sure you wish to continue? (y/N): ')
Garrett Beatyacb807e2020-08-28 18:17:24 +00001819 else:
1820 sys.stdout.write('\n')
Bruce Dawson76fe1a72022-05-25 20:52:21 +00001821 else:
1822 sys.stdout.write('There were %s presubmit errors.\n' % python_version)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001823
Edward Lemur1dc66e12020-02-21 21:36:34 +00001824 if json_output:
1825 # Write the presubmit results to json output
1826 presubmit_results = {
1827 'errors': [
Edward Lemur6eb1d322020-02-27 22:20:15 +00001828 error.json_format()
1829 for error in messages.get('ERRORS', [])
Edward Lemur1dc66e12020-02-21 21:36:34 +00001830 ],
1831 'notifications': [
Edward Lemur6eb1d322020-02-27 22:20:15 +00001832 notification.json_format()
1833 for notification in messages.get('Messages', [])
Edward Lemur1dc66e12020-02-21 21:36:34 +00001834 ],
1835 'warnings': [
Edward Lemur6eb1d322020-02-27 22:20:15 +00001836 warning.json_format()
1837 for warning in messages.get('Warnings', [])
Edward Lemur1dc66e12020-02-21 21:36:34 +00001838 ],
Edward Lemur6eb1d322020-02-27 22:20:15 +00001839 'more_cc': executer.more_cc,
Edward Lemur1dc66e12020-02-21 21:36:34 +00001840 }
1841
1842 gclient_utils.FileWrite(
1843 json_output, json.dumps(presubmit_results, sort_keys=True))
1844
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001845 global _ASKED_FOR_FEEDBACK
1846 # Ask for feedback one time out of 5.
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +00001847 if (results and random.randint(0, 4) == 0 and not _ASKED_FOR_FEEDBACK):
Edward Lemur6eb1d322020-02-27 22:20:15 +00001848 sys.stdout.write(
maruel@chromium.org1ce8e662014-01-14 15:23:00 +00001849 'Was the presubmit check useful? If not, run "git cl presubmit -v"\n'
1850 'to figure out which PRESUBMIT.py was run, then run git blame\n'
1851 'on the file to figure out who to ask for help.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001852 _ASKED_FOR_FEEDBACK = True
Edward Lemur6eb1d322020-02-27 22:20:15 +00001853
1854 return 1 if presubmits_failed else 0
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001855 finally:
1856 os.environ = old_environ
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001857
1858
Edward Lemur50984a62020-02-06 18:10:18 +00001859def _scan_sub_dirs(mask, recursive):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001860 if not recursive:
pgervais@chromium.orge57b09d2014-05-07 00:58:13 +00001861 return [x for x in glob.glob(mask) if x not in ('.svn', '.git')]
Lei Zhang9611c4c2017-04-04 01:41:56 -07001862
1863 results = []
1864 for root, dirs, files in os.walk('.'):
1865 if '.svn' in dirs:
1866 dirs.remove('.svn')
1867 if '.git' in dirs:
1868 dirs.remove('.git')
1869 for name in files:
1870 if fnmatch.fnmatch(name, mask):
1871 results.append(os.path.join(root, name))
1872 return results
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001873
1874
Edward Lemur50984a62020-02-06 18:10:18 +00001875def _parse_files(args, recursive):
tobiasjs2836bcf2016-08-16 04:08:16 -07001876 logging.debug('Searching for %s', args)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001877 files = []
1878 for arg in args:
Edward Lemur50984a62020-02-06 18:10:18 +00001879 files.extend([('M', f) for f in _scan_sub_dirs(arg, recursive)])
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001880 return files
1881
1882
Edward Lemur50984a62020-02-06 18:10:18 +00001883def _parse_change(parser, options):
1884 """Process change options.
1885
1886 Args:
1887 parser: The parser used to parse the arguments from command line.
1888 options: The arguments parsed from command line.
1889 Returns:
Josip Sokcevic7958e302023-03-01 23:02:21 +00001890 A GitChange if the change root is a git repository, or a Change otherwise.
Edward Lemur50984a62020-02-06 18:10:18 +00001891 """
1892 if options.files and options.all_files:
1893 parser.error('<files> cannot be specified when --all-files is set.')
1894
Edward Lesmes44ea3ff2020-02-05 00:14:30 +00001895 change_scm = scm.determine_scm(options.root)
Edward Lemur50984a62020-02-06 18:10:18 +00001896 if change_scm != 'git' and not options.files:
1897 parser.error('<files> is not optional for unversioned directories.')
1898
1899 if options.files:
Josip Sokcevic017544d2022-03-31 23:47:53 +00001900 if options.source_controlled_only:
1901 # Get the filtered set of files from SCM.
1902 change_files = []
1903 for name in scm.GIT.GetAllFiles(options.root):
1904 for mask in options.files:
1905 if fnmatch.fnmatch(name, mask):
1906 change_files.append(('M', name))
1907 break
1908 else:
1909 # Get the filtered set of files from a directory scan.
1910 change_files = _parse_files(options.files, options.recursive)
Edward Lemur50984a62020-02-06 18:10:18 +00001911 elif options.all_files:
1912 change_files = [('M', f) for f in scm.GIT.GetAllFiles(options.root)]
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001913 else:
Edward Lemur50984a62020-02-06 18:10:18 +00001914 change_files = scm.GIT.CaptureStatus(
Edward Lemur7f6dec02020-02-06 20:23:58 +00001915 options.root, options.upstream or None)
Edward Lemur50984a62020-02-06 18:10:18 +00001916
1917 logging.info('Found %d file(s).', len(change_files))
1918
Josip Sokcevic7958e302023-03-01 23:02:21 +00001919 change_class = GitChange if change_scm == 'git' else Change
Edward Lemur50984a62020-02-06 18:10:18 +00001920 return change_class(
1921 options.name,
1922 options.description,
1923 options.root,
1924 change_files,
1925 options.issue,
1926 options.patchset,
1927 options.author,
1928 upstream=options.upstream)
1929
1930
1931def _parse_gerrit_options(parser, options):
1932 """Process gerrit options.
1933
1934 SIDE EFFECTS: Modifies options.author and options.description from Gerrit if
1935 options.gerrit_fetch is set.
1936
1937 Args:
1938 parser: The parser used to parse the arguments from command line.
1939 options: The arguments parsed from command line.
1940 Returns:
Stephen Martinisfb09de22021-02-25 03:41:13 +00001941 A GerritAccessor object if options.gerrit_url is set, or None otherwise.
Edward Lemur50984a62020-02-06 18:10:18 +00001942 """
1943 gerrit_obj = None
Stephen Martinisfb09de22021-02-25 03:41:13 +00001944 if options.gerrit_url:
Edward Lesmeseb1bd622021-03-01 19:54:07 +00001945 gerrit_obj = GerritAccessor(
1946 url=options.gerrit_url,
1947 project=options.gerrit_project,
1948 branch=options.gerrit_branch)
Edward Lemur50984a62020-02-06 18:10:18 +00001949
1950 if not options.gerrit_fetch:
1951 return gerrit_obj
1952
1953 if not options.gerrit_url or not options.issue or not options.patchset:
1954 parser.error(
1955 '--gerrit_fetch requires --gerrit_url, --issue and --patchset.')
1956
1957 options.author = gerrit_obj.GetChangeOwner(options.issue)
1958 options.description = gerrit_obj.GetChangeDescription(
1959 options.issue, options.patchset)
1960
1961 logging.info('Got author: "%s"', options.author)
1962 logging.info('Got description: """\n%s\n"""', options.description)
1963
1964 return gerrit_obj
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001965
1966
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001967@contextlib.contextmanager
1968def canned_check_filter(method_names):
1969 filtered = {}
1970 try:
1971 for method_name in method_names:
1972 if not hasattr(presubmit_canned_checks, method_name):
Gavin Make6a62332020-12-04 21:57:10 +00001973 logging.warning('Skipping unknown "canned" check %s' % method_name)
Aaron Gableecee74c2018-04-02 15:13:08 -07001974 continue
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001975 filtered[method_name] = getattr(presubmit_canned_checks, method_name)
1976 setattr(presubmit_canned_checks, method_name, lambda *_a, **_kw: [])
1977 yield
1978 finally:
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001979 for name, method in filtered.items():
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001980 setattr(presubmit_canned_checks, name, method)
1981
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +00001982
sbc@chromium.org013731e2015-02-26 18:28:43 +00001983def main(argv=None):
Edward Lemura5799e32020-01-17 19:26:51 +00001984 parser = argparse.ArgumentParser(usage='%(prog)s [options] <files...>')
1985 hooks = parser.add_mutually_exclusive_group()
1986 hooks.add_argument('-c', '--commit', action='store_true',
1987 help='Use commit instead of upload checks.')
1988 hooks.add_argument('-u', '--upload', action='store_false', dest='commit',
1989 help='Use upload instead of commit checks.')
Edward Lemur75526302020-02-27 22:31:05 +00001990 hooks.add_argument('--post_upload', action='store_true',
1991 help='Run post-upload commit hooks.')
Edward Lemura5799e32020-01-17 19:26:51 +00001992 parser.add_argument('-r', '--recursive', action='store_true',
1993 help='Act recursively.')
1994 parser.add_argument('-v', '--verbose', action='count', default=0,
1995 help='Use 2 times for more debug info.')
1996 parser.add_argument('--name', default='no name')
1997 parser.add_argument('--author')
Edward Lemur227d5102020-02-25 23:45:35 +00001998 desc = parser.add_mutually_exclusive_group()
1999 desc.add_argument('--description', default='', help='The change description.')
2000 desc.add_argument('--description_file',
2001 help='File to read change description from.')
Edward Lemura5799e32020-01-17 19:26:51 +00002002 parser.add_argument('--issue', type=int, default=0)
2003 parser.add_argument('--patchset', type=int, default=0)
2004 parser.add_argument('--root', default=os.getcwd(),
2005 help='Search for PRESUBMIT.py up to this directory. '
2006 'If inherit-review-settings-ok is present in this '
2007 'directory, parent directories up to the root file '
2008 'system directories will also be searched.')
2009 parser.add_argument('--upstream',
2010 help='Git only: the base ref or upstream branch against '
2011 'which the diff should be computed.')
2012 parser.add_argument('--default_presubmit')
2013 parser.add_argument('--may_prompt', action='store_true', default=False)
2014 parser.add_argument('--skip_canned', action='append', default=[],
2015 help='A list of checks to skip which appear in '
2016 'presubmit_canned_checks. Can be provided multiple times '
2017 'to skip multiple canned checks.')
2018 parser.add_argument('--dry_run', action='store_true', help=argparse.SUPPRESS)
2019 parser.add_argument('--gerrit_url', help=argparse.SUPPRESS)
Edward Lesmeseb1bd622021-03-01 19:54:07 +00002020 parser.add_argument('--gerrit_project', help=argparse.SUPPRESS)
2021 parser.add_argument('--gerrit_branch', help=argparse.SUPPRESS)
Edward Lemura5799e32020-01-17 19:26:51 +00002022 parser.add_argument('--gerrit_fetch', action='store_true',
2023 help=argparse.SUPPRESS)
2024 parser.add_argument('--parallel', action='store_true',
2025 help='Run all tests specified by input_api.RunTests in '
2026 'all PRESUBMIT files in parallel.')
2027 parser.add_argument('--json_output',
2028 help='Write presubmit errors to json output.')
Edward Lemur1dc66e12020-02-21 21:36:34 +00002029 parser.add_argument('--all_files', action='store_true',
Edward Lemur50984a62020-02-06 18:10:18 +00002030 help='Mark all files under source control as modified.')
Bruce Dawson09c0c072022-05-26 20:28:58 +00002031
Edward Lemura5799e32020-01-17 19:26:51 +00002032 parser.add_argument('files', nargs='*',
2033 help='List of files to be marked as modified when '
2034 'executing presubmit or post-upload hooks. fnmatch '
2035 'wildcards can also be used.')
Josip Sokcevic017544d2022-03-31 23:47:53 +00002036 parser.add_argument('--source_controlled_only', action='store_true',
2037 help='Constrain \'files\' to those in source control.')
Dirk Pranke6f0df682021-06-25 00:42:33 +00002038 parser.add_argument('--use-python3', action='store_true',
2039 help='Use python3 for presubmit checks by default')
Bruce Dawson09c0c072022-05-26 20:28:58 +00002040 parser.add_argument('--no_diffs', action='store_true',
2041 help='Assume that all "modified" files have no diffs.')
Edward Lemura5799e32020-01-17 19:26:51 +00002042 options = parser.parse_args(argv)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00002043
Erik Staabcca5c492020-04-16 17:40:07 +00002044 log_level = logging.ERROR
maruel@chromium.org899e1c12011-04-07 17:03:18 +00002045 if options.verbose >= 2:
Erik Staabcca5c492020-04-16 17:40:07 +00002046 log_level = logging.DEBUG
maruel@chromium.org899e1c12011-04-07 17:03:18 +00002047 elif options.verbose:
Erik Staabcca5c492020-04-16 17:40:07 +00002048 log_level = logging.INFO
2049 log_format = ('[%(levelname).1s%(asctime)s %(process)d %(thread)d '
2050 '%(filename)s] %(message)s')
2051 logging.basicConfig(format=log_format, level=log_level)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00002052
Bruce Dawsondca14bc2022-09-15 20:59:38 +00002053 # Print call stacks when _PresubmitResult objects are created with -v -v is
2054 # specified. This helps track down where presubmit messages are coming from.
2055 if options.verbose >= 2:
2056 global _SHOW_CALLSTACKS
2057 _SHOW_CALLSTACKS = True
2058
Edward Lemur227d5102020-02-25 23:45:35 +00002059 if options.description_file:
2060 options.description = gclient_utils.FileRead(options.description_file)
Edward Lemur50984a62020-02-06 18:10:18 +00002061 gerrit_obj = _parse_gerrit_options(parser, options)
2062 change = _parse_change(parser, options)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00002063
maruel@chromium.org899e1c12011-04-07 17:03:18 +00002064 try:
Edward Lemur75526302020-02-27 22:31:05 +00002065 if options.post_upload:
Josip Sokcevice293d3d2022-02-16 22:52:15 +00002066 return DoPostUploadExecuter(change, gerrit_obj, options.verbose,
2067 options.use_python3)
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00002068 with canned_check_filter(options.skip_canned):
Edward Lemur6eb1d322020-02-27 22:20:15 +00002069 return DoPresubmitChecks(
Edward Lemur50984a62020-02-06 18:10:18 +00002070 change,
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00002071 options.commit,
2072 options.verbose,
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00002073 options.default_presubmit,
2074 options.may_prompt,
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00002075 gerrit_obj,
Edward Lesmes8e282792018-04-03 18:50:29 -04002076 options.dry_run,
Debrian Figueroadd2737e2019-06-21 23:50:13 +00002077 options.parallel,
Dirk Pranke6f0df682021-06-25 00:42:33 +00002078 options.json_output,
Bruce Dawson09c0c072022-05-26 20:28:58 +00002079 options.use_python3,
2080 options.no_diffs)
Raul Tambre7c938462019-05-24 16:35:35 +00002081 except PresubmitFailure as e:
Josip Sokcevica9a7eec2023-03-10 03:54:52 +00002082 import utils
Raul Tambre80ee78e2019-05-06 22:41:05 +00002083 print(e, file=sys.stderr)
2084 print('Maybe your depot_tools is out of date?', file=sys.stderr)
Josip Sokcevic0399e172022-03-21 23:11:51 +00002085 print('depot_tools version: %s' % utils.depot_tools_version(),
2086 file=sys.stderr)
maruel@chromium.org899e1c12011-04-07 17:03:18 +00002087 return 2
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00002088
2089
2090if __name__ == '__main__':
maruel@chromium.org35625c72011-03-23 17:34:02 +00002091 fix_encoding.fix_encoding()
sbc@chromium.org013731e2015-02-26 18:28:43 +00002092 try:
2093 sys.exit(main())
2094 except KeyboardInterrupt:
2095 sys.stderr.write('interrupted\n')
sergiybf8a3b382016-07-05 11:21:30 -07002096 sys.exit(2)