blob: 67792a91f21634af8274e8dfeab1f5883ce87907 [file] [log] [blame]
Edward Lemur0db01f02019-11-12 22:01:51 +00001#!/usr/bin/env vpython3
2# coding=utf-8
maruel@chromium.orgeb5edbc2012-01-16 17:03:28 +00003# Copyright (c) 2012 The Chromium Authors. All rights reserved.
maruel@chromium.orgddd59412011-11-30 14:20:38 +00004# Use of this source code is governed by a BSD-style license that can be
5# found in the LICENSE file.
6
7"""Unit tests for git_cl.py."""
8
Edward Lemur0db01f02019-11-12 22:01:51 +00009from __future__ import unicode_literals
10
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +010011import datetime
tandriide281ae2016-10-12 06:02:30 -070012import json
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +010013import logging
maruel@chromium.orgddd59412011-11-30 14:20:38 +000014import os
Brian Sheedy59b06a82019-10-14 17:03:29 +000015import shutil
maruel@chromium.orgddd59412011-11-30 14:20:38 +000016import sys
Aaron Gable9a03ae02017-11-03 11:31:07 -070017import tempfile
maruel@chromium.orgddd59412011-11-30 14:20:38 +000018import unittest
19
Edward Lemura8145022020-01-06 18:47:54 +000020if sys.version_info.major == 2:
21 from StringIO import StringIO
22 import mock
23else:
24 from io import StringIO
25 from unittest import mock
26
maruel@chromium.orgddd59412011-11-30 14:20:38 +000027sys.path.insert(0, os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
28
29from testing_support.auto_stub import TestCase
30
Edward Lemur5ba1e9c2018-07-23 18:19:02 +000031import metrics
32# We have to disable monitoring before importing git_cl.
33metrics.DISABLE_METRICS_COLLECTION = True
34
Jamie Madill5e96ad12020-01-13 16:08:35 +000035import clang_format
Eric Boren2fb63102018-10-05 13:05:03 +000036import gerrit_util
maruel@chromium.orgddd59412011-11-30 14:20:38 +000037import git_cl
iannucci@chromium.org9e849272014-04-04 00:31:55 +000038import git_common
tandrii@chromium.org57d86542016-03-04 16:11:32 +000039import git_footers
maruel@chromium.orgddd59412011-11-30 14:20:38 +000040import subprocess2
maruel@chromium.orgddd59412011-11-30 14:20:38 +000041
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +000042
Edward Lemur0db01f02019-11-12 22:01:51 +000043def callError(code=1, cmd='', cwd='', stdout=b'', stderr=b''):
tandrii5d48c322016-08-18 16:19:37 -070044 return subprocess2.CalledProcessError(code, cmd, cwd, stdout, stderr)
45
46
Edward Lemur4c707a22019-09-24 21:13:43 +000047def _constantFn(return_value):
48 def f(*args, **kwargs):
49 return return_value
50 return f
51
52
tandrii5d48c322016-08-18 16:19:37 -070053CERR1 = callError(1)
54
55
Edward Lemur0db01f02019-11-12 22:01:51 +000056def MakeNamedTemporaryFileMock(test, expected_content):
Aaron Gable9a03ae02017-11-03 11:31:07 -070057 class NamedTemporaryFileMock(object):
58 def __init__(self, *args, **kwargs):
59 self.name = '/tmp/named'
Edward Lemur0db01f02019-11-12 22:01:51 +000060 self.expected_content = expected_content.encode('utf-8', 'replace')
Aaron Gable9a03ae02017-11-03 11:31:07 -070061
62 def __enter__(self):
63 return self
64
65 def __exit__(self, _type, _value, _tb):
66 pass
67
68 def write(self, content):
69 if self.expected_content:
Edward Lemur0db01f02019-11-12 22:01:51 +000070 test.assertEqual(self.expected_content, content)
Aaron Gable9a03ae02017-11-03 11:31:07 -070071
72 def close(self):
73 pass
74
75 return NamedTemporaryFileMock
76
77
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000078class ChangelistMock(object):
79 # A class variable so we can access it when we don't have access to the
80 # instance that's being set.
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +000081 desc = ''
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000082 def __init__(self, **kwargs):
83 pass
84 def GetIssue(self):
85 return 1
Kenneth Russell61e2ed42017-02-15 11:47:13 -080086 def GetDescription(self, force=False):
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000087 return ChangelistMock.desc
dsansomee2d6fd92016-09-08 00:10:47 -070088 def UpdateDescription(self, desc, force=False):
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000089 ChangelistMock.desc = desc
90
tandrii5d48c322016-08-18 16:19:37 -070091
maruel@chromium.org2e72bb12012-01-17 15:18:35 +000092class PresubmitMock(object):
93 def __init__(self, *args, **kwargs):
94 self.reviewers = []
Daniel Cheng7227d212017-11-17 08:12:37 -080095 self.more_cc = ['chromium-reviews+test-more-cc@chromium.org']
96
maruel@chromium.org2e72bb12012-01-17 15:18:35 +000097 @staticmethod
98 def should_continue():
99 return True
100
101
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000102class WatchlistsMock(object):
103 def __init__(self, _):
104 pass
105 @staticmethod
106 def GetWatchersForPaths(_):
107 return ['joe@example.com']
108
109
Edward Lemur4c707a22019-09-24 21:13:43 +0000110class CodereviewSettingsFileMock(object):
111 def __init__(self):
112 pass
113 # pylint: disable=no-self-use
114 def read(self):
115 return ('CODE_REVIEW_SERVER: gerrit.chromium.org\n' +
116 'GERRIT_HOST: True\n')
117
118
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000119class AuthenticatorMock(object):
120 def __init__(self, *_args):
121 pass
122 def has_cached_credentials(self):
123 return True
tandrii221ab252016-10-06 08:12:04 -0700124 def authorize(self, http):
125 return http
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000126
127
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100128def CookiesAuthenticatorMockFactory(hosts_with_creds=None, same_auth=False):
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000129 """Use to mock Gerrit/Git credentials from ~/.netrc or ~/.gitcookies.
130
131 Usage:
132 >>> self.mock(git_cl.gerrit_util, "CookiesAuthenticator",
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100133 CookiesAuthenticatorMockFactory({'host': ('user', _, 'pass')})
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000134
135 OR
136 >>> self.mock(git_cl.gerrit_util, "CookiesAuthenticator",
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100137 CookiesAuthenticatorMockFactory(
138 same_auth=('user', '', 'pass'))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000139 """
140 class CookiesAuthenticatorMock(git_cl.gerrit_util.CookiesAuthenticator):
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800141 def __init__(self): # pylint: disable=super-init-not-called
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000142 # Intentionally not calling super() because it reads actual cookie files.
143 pass
144 @classmethod
145 def get_gitcookies_path(cls):
146 return '~/.gitcookies'
147 @classmethod
148 def get_netrc_path(cls):
149 return '~/.netrc'
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100150 def _get_auth_for_host(self, host):
151 if same_auth:
152 return same_auth
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000153 return (hosts_with_creds or {}).get(host)
154 return CookiesAuthenticatorMock
155
Aaron Gable9a03ae02017-11-03 11:31:07 -0700156
kmarshall9249e012016-08-23 12:02:16 -0700157class MockChangelistWithBranchAndIssue():
158 def __init__(self, branch, issue):
159 self.branch = branch
160 self.issue = issue
161 def GetBranch(self):
162 return self.branch
163 def GetIssue(self):
164 return self.issue
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000165
tandriic2405f52016-10-10 08:13:15 -0700166
167class SystemExitMock(Exception):
168 pass
169
170
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000171class TestGitClBasic(unittest.TestCase):
Andrii Shyshkalov31863012017-02-08 11:35:12 +0100172 def test_get_description(self):
Edward Lemurf38bc172019-09-03 21:02:13 +0000173 cl = git_cl.Changelist(issue=1, codereview_host='host')
Andrii Shyshkalov31863012017-02-08 11:35:12 +0100174 cl.description = 'x'
175 cl.has_description = True
Edward Lemur125d60a2019-09-13 18:25:41 +0000176 cl.FetchDescription = lambda *a, **kw: 'y'
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +0000177 self.assertEqual(cl.GetDescription(), 'x')
178 self.assertEqual(cl.GetDescription(force=True), 'y')
179 self.assertEqual(cl.GetDescription(), 'y')
Andrii Shyshkalov31863012017-02-08 11:35:12 +0100180
Robert Iannucci09f1f3d2017-03-28 16:54:32 -0700181 def test_description_footers(self):
Edward Lemurf38bc172019-09-03 21:02:13 +0000182 cl = git_cl.Changelist(issue=1, codereview_host='host')
Robert Iannucci09f1f3d2017-03-28 16:54:32 -0700183 cl.description = '\n'.join([
184 'This is some message',
185 '',
186 'It has some lines',
187 'and, also',
188 '',
189 'Some: Really',
190 'Awesome: Footers',
191 ])
192 cl.has_description = True
Edward Lemur125d60a2019-09-13 18:25:41 +0000193 cl.UpdateDescriptionRemote = lambda *a, **kw: 'y'
Robert Iannucci09f1f3d2017-03-28 16:54:32 -0700194 msg, footers = cl.GetDescriptionFooters()
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +0000195 self.assertEqual(
Robert Iannucci09f1f3d2017-03-28 16:54:32 -0700196 msg, ['This is some message', '', 'It has some lines', 'and, also'])
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +0000197 self.assertEqual(footers, [('Some', 'Really'), ('Awesome', 'Footers')])
Robert Iannucci09f1f3d2017-03-28 16:54:32 -0700198
199 msg.append('wut')
200 footers.append(('gnarly-dude', 'beans'))
201 cl.UpdateDescriptionFooters(msg, footers)
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +0000202 self.assertEqual(cl.GetDescription().splitlines(), [
Robert Iannucci09f1f3d2017-03-28 16:54:32 -0700203 'This is some message',
204 '',
205 'It has some lines',
206 'and, also',
207 'wut'
208 '',
209 'Some: Really',
210 'Awesome: Footers',
211 'Gnarly-Dude: beans',
212 ])
213
Andrii Shyshkalov71f0da32019-07-15 22:45:18 +0000214 def test_set_preserve_tryjobs(self):
215 d = git_cl.ChangeDescription('Simple.')
216 d.set_preserve_tryjobs()
217 self.assertEqual(d.description.splitlines(), [
218 'Simple.',
219 '',
220 'Cq-Do-Not-Cancel-Tryjobs: true',
221 ])
222 before = d.description
223 d.set_preserve_tryjobs()
224 self.assertEqual(before, d.description)
225
226 d = git_cl.ChangeDescription('\n'.join([
227 'One is enough',
228 '',
229 'Cq-Do-Not-Cancel-Tryjobs: dups not encouraged, but don\'t hurt',
230 'Change-Id: Ideadbeef',
231 ]))
232 d.set_preserve_tryjobs()
233 self.assertEqual(d.description.splitlines(), [
234 'One is enough',
235 '',
236 'Cq-Do-Not-Cancel-Tryjobs: dups not encouraged, but don\'t hurt',
237 'Change-Id: Ideadbeef',
238 'Cq-Do-Not-Cancel-Tryjobs: true',
239 ])
240
tandriif9aefb72016-07-01 09:06:51 -0700241 def test_get_bug_line_values(self):
242 f = lambda p, bugs: list(git_cl._get_bug_line_values(p, bugs))
243 self.assertEqual(f('', ''), [])
244 self.assertEqual(f('', '123,v8:456'), ['123', 'v8:456'])
245 self.assertEqual(f('v8', '456'), ['v8:456'])
246 self.assertEqual(f('v8', 'chromium:123,456'), ['v8:456', 'chromium:123'])
247 # Not nice, but not worth carying.
248 self.assertEqual(f('v8', 'chromium:123,456,v8:123'),
249 ['v8:456', 'chromium:123', 'v8:123'])
250
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100251 def _test_git_number(self, parent_msg, dest_ref, child_msg,
252 parent_hash='parenthash'):
253 desc = git_cl.ChangeDescription(child_msg)
254 desc.update_with_git_number_footers(parent_hash, parent_msg, dest_ref)
255 return desc.description
256
257 def assertEqualByLine(self, actual, expected):
258 self.assertEqual(actual.splitlines(), expected.splitlines())
259
260 def test_git_number_bad_parent(self):
261 with self.assertRaises(ValueError):
262 self._test_git_number('Parent', 'refs/heads/master', 'Child')
263
264 def test_git_number_bad_parent_footer(self):
265 with self.assertRaises(AssertionError):
266 self._test_git_number(
267 'Parent\n'
268 '\n'
269 'Cr-Commit-Position: wrong',
270 'refs/heads/master', 'Child')
271
272 def test_git_number_bad_lineage_ignored(self):
273 actual = self._test_git_number(
274 'Parent\n'
275 '\n'
276 'Cr-Commit-Position: refs/heads/master@{#1}\n'
277 'Cr-Branched-From: mustBeReal40CharHash-branch@{#pos}',
278 'refs/heads/master', 'Child')
279 self.assertEqualByLine(
280 actual,
281 'Child\n'
282 '\n'
283 'Cr-Commit-Position: refs/heads/master@{#2}\n'
284 'Cr-Branched-From: mustBeReal40CharHash-branch@{#pos}')
285
286 def test_git_number_same_branch(self):
287 actual = self._test_git_number(
288 'Parent\n'
289 '\n'
290 'Cr-Commit-Position: refs/heads/master@{#12}',
291 dest_ref='refs/heads/master',
292 child_msg='Child')
293 self.assertEqualByLine(
294 actual,
295 'Child\n'
296 '\n'
297 'Cr-Commit-Position: refs/heads/master@{#13}')
298
Andrii Shyshkalovde37c012017-07-06 21:06:50 +0200299 def test_git_number_same_branch_mixed_footers(self):
300 actual = self._test_git_number(
301 'Parent\n'
302 '\n'
303 'Cr-Commit-Position: refs/heads/master@{#12}',
304 dest_ref='refs/heads/master',
305 child_msg='Child\n'
306 '\n'
307 'Broken-by: design\n'
308 'BUG=123')
309 self.assertEqualByLine(
310 actual,
311 'Child\n'
312 '\n'
313 'Broken-by: design\n'
314 'BUG=123\n'
315 'Cr-Commit-Position: refs/heads/master@{#13}')
316
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100317 def test_git_number_same_branch_with_originals(self):
318 actual = self._test_git_number(
319 'Parent\n'
320 '\n'
321 'Cr-Commit-Position: refs/heads/master@{#12}',
322 dest_ref='refs/heads/master',
323 child_msg='Child\n'
324 '\n'
325 'Some users are smart and insert their own footers\n'
326 '\n'
327 'Cr-Whatever: value\n'
328 'Cr-Commit-Position: refs/copy/paste@{#22}')
329 self.assertEqualByLine(
330 actual,
331 'Child\n'
332 '\n'
333 'Some users are smart and insert their own footers\n'
334 '\n'
335 'Cr-Original-Whatever: value\n'
336 'Cr-Original-Commit-Position: refs/copy/paste@{#22}\n'
337 'Cr-Commit-Position: refs/heads/master@{#13}')
338
339 def test_git_number_new_branch(self):
340 actual = self._test_git_number(
341 'Parent\n'
342 '\n'
343 'Cr-Commit-Position: refs/heads/master@{#12}',
344 dest_ref='refs/heads/branch',
345 child_msg='Child')
346 self.assertEqualByLine(
347 actual,
348 'Child\n'
349 '\n'
350 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
351 'Cr-Branched-From: parenthash-refs/heads/master@{#12}')
352
353 def test_git_number_lineage(self):
354 actual = self._test_git_number(
355 'Parent\n'
356 '\n'
357 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
358 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
359 dest_ref='refs/heads/branch',
360 child_msg='Child')
361 self.assertEqualByLine(
362 actual,
363 'Child\n'
364 '\n'
365 'Cr-Commit-Position: refs/heads/branch@{#2}\n'
366 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
367
368 def test_git_number_moooooooore_lineage(self):
369 actual = self._test_git_number(
370 'Parent\n'
371 '\n'
372 'Cr-Commit-Position: refs/heads/branch@{#5}\n'
373 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
374 dest_ref='refs/heads/mooore',
375 child_msg='Child')
376 self.assertEqualByLine(
377 actual,
378 'Child\n'
379 '\n'
380 'Cr-Commit-Position: refs/heads/mooore@{#1}\n'
381 'Cr-Branched-From: parenthash-refs/heads/branch@{#5}\n'
382 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
383
Andrii Shyshkalovb5effa12016-12-14 19:35:12 +0100384 def test_git_number_ever_moooooooore_lineage(self):
Robert Iannucci456b0d62018-03-13 19:15:50 -0700385 self.maxDiff = 10000 # pylint: disable=attribute-defined-outside-init
Andrii Shyshkalovb5effa12016-12-14 19:35:12 +0100386 actual = self._test_git_number(
387 'CQ commit on fresh new branch + numbering.\n'
388 '\n'
389 'NOTRY=True\n'
390 'NOPRESUBMIT=True\n'
391 'BUG=\n'
392 '\n'
393 'Review-Url: https://codereview.chromium.org/2577703003\n'
394 'Cr-Commit-Position: refs/heads/gnumb-test/br@{#1}\n'
395 'Cr-Branched-From: 0749ff9edc-refs/heads/gnumb-test/cq@{#4}\n'
396 'Cr-Branched-From: 5c49df2da6-refs/heads/master@{#41618}',
397 dest_ref='refs/heads/gnumb-test/cl',
398 child_msg='git cl on fresh new branch + numbering.\n'
399 '\n'
400 'Review-Url: https://codereview.chromium.org/2575043003 .\n')
401 self.assertEqualByLine(
402 actual,
403 'git cl on fresh new branch + numbering.\n'
404 '\n'
405 'Review-Url: https://codereview.chromium.org/2575043003 .\n'
406 'Cr-Commit-Position: refs/heads/gnumb-test/cl@{#1}\n'
407 'Cr-Branched-From: parenthash-refs/heads/gnumb-test/br@{#1}\n'
408 'Cr-Branched-From: 0749ff9edc-refs/heads/gnumb-test/cq@{#4}\n'
409 'Cr-Branched-From: 5c49df2da6-refs/heads/master@{#41618}')
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100410
411 def test_git_number_cherry_pick(self):
412 actual = self._test_git_number(
413 'Parent\n'
414 '\n'
415 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
416 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
417 dest_ref='refs/heads/branch',
418 child_msg='Child, which is cherry-pick from master\n'
419 '\n'
420 'Cr-Commit-Position: refs/heads/master@{#100}\n'
421 '(cherry picked from commit deadbeef12345678deadbeef12345678deadbeef)')
422 self.assertEqualByLine(
423 actual,
424 'Child, which is cherry-pick from master\n'
425 '\n'
426 '(cherry picked from commit deadbeef12345678deadbeef12345678deadbeef)\n'
427 '\n'
428 'Cr-Original-Commit-Position: refs/heads/master@{#100}\n'
429 'Cr-Commit-Position: refs/heads/branch@{#2}\n'
430 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
431
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +0000432 def test_valid_accounts(self):
433 mock_per_account = {
434 'u1': None, # 404, doesn't exist.
435 'u2': {
436 '_account_id': 123124,
437 'avatars': [],
438 'email': 'u2@example.com',
439 'name': 'User Number 2',
440 'status': 'OOO',
441 },
442 'u3': git_cl.gerrit_util.GerritError(500, 'retries didn\'t help :('),
443 }
444 def GetAccountDetailsMock(_, account):
445 # Poor-man's mock library's side_effect.
446 v = mock_per_account.pop(account)
447 if isinstance(v, Exception):
448 raise v
449 return v
450
451 original = git_cl.gerrit_util.GetAccountDetails
452 try:
453 git_cl.gerrit_util.GetAccountDetails = GetAccountDetailsMock
454 actual = git_cl.gerrit_util.ValidAccounts(
455 'host', ['u1', 'u2', 'u3'], max_threads=1)
456 finally:
457 git_cl.gerrit_util.GetAccountDetails = original
458 self.assertEqual(actual, {
459 'u2': {
460 '_account_id': 123124,
461 'avatars': [],
462 'email': 'u2@example.com',
463 'name': 'User Number 2',
464 'status': 'OOO',
465 },
466 })
467
468
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200469class TestParseIssueURL(unittest.TestCase):
470 def _validate(self, parsed, issue=None, patchset=None, hostname=None,
Edward Lemurf38bc172019-09-03 21:02:13 +0000471 fail=False):
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200472 self.assertIsNotNone(parsed)
473 if fail:
474 self.assertFalse(parsed.valid)
475 return
476 self.assertTrue(parsed.valid)
477 self.assertEqual(parsed.issue, issue)
478 self.assertEqual(parsed.patchset, patchset)
479 self.assertEqual(parsed.hostname, hostname)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200480
Edward Lemur678a6842019-10-03 22:25:05 +0000481 def test_ParseIssueNumberArgument(self):
482 def test(arg, *args, **kwargs):
483 self._validate(git_cl.ParseIssueNumberArgument(arg), *args, **kwargs)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200484
Edward Lemur678a6842019-10-03 22:25:05 +0000485 test('123', 123)
486 test('', fail=True)
487 test('abc', fail=True)
488 test('123/1', fail=True)
489 test('123a', fail=True)
490 test('ssh://chrome-review.source.com/#/c/123/4/', fail=True)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200491
Edward Lemur678a6842019-10-03 22:25:05 +0000492 test('https://codereview.source.com/123',
493 123, None, 'codereview.source.com')
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200494 test('http://chrome-review.source.com/c/123',
495 123, None, 'chrome-review.source.com')
496 test('https://chrome-review.source.com/c/123/',
497 123, None, 'chrome-review.source.com')
498 test('https://chrome-review.source.com/c/123/4',
499 123, 4, 'chrome-review.source.com')
500 test('https://chrome-review.source.com/#/c/123/4',
501 123, 4, 'chrome-review.source.com')
502 test('https://chrome-review.source.com/c/123/4',
503 123, 4, 'chrome-review.source.com')
504 test('https://chrome-review.source.com/123',
505 123, None, 'chrome-review.source.com')
506 test('https://chrome-review.source.com/123/4',
507 123, 4, 'chrome-review.source.com')
508
Edward Lemur678a6842019-10-03 22:25:05 +0000509 test('https://chrome-review.source.com/bad/123/4', fail=True)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200510 test('https://chrome-review.source.com/c/123/1/whatisthis', fail=True)
511 test('https://chrome-review.source.com/c/abc/', fail=True)
512 test('ssh://chrome-review.source.com/c/123/1/', fail=True)
513
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200514
515
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100516class GitCookiesCheckerTest(TestCase):
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100517 def setUp(self):
518 super(GitCookiesCheckerTest, self).setUp()
519 self.c = git_cl._GitCookiesChecker()
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100520 self.c._all_hosts = []
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100521
522 def mock_hosts_creds(self, subhost_identity_pairs):
523 def ensure_googlesource(h):
524 if not h.endswith(self.c._GOOGLESOURCE):
525 assert not h.endswith('.')
526 return h + '.' + self.c._GOOGLESOURCE
527 return h
528 self.c._all_hosts = [(ensure_googlesource(h), i, '.gitcookies')
529 for h, i in subhost_identity_pairs]
530
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +0200531 def test_identity_parsing(self):
532 self.assertEqual(self.c._parse_identity('ldap.google.com'),
533 ('ldap', 'google.com'))
534 self.assertEqual(self.c._parse_identity('git-ldap.example.com'),
535 ('ldap', 'example.com'))
536 # Specical case because we know there are no subdomains in chromium.org.
537 self.assertEqual(self.c._parse_identity('git-note.period.chromium.org'),
538 ('note.period', 'chromium.org'))
Lei Zhangd3f769a2017-12-15 15:16:14 -0800539 # Pathological: ".period." can be either username OR domain, more likely
540 # domain.
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +0200541 self.assertEqual(self.c._parse_identity('git-note.period.example.com'),
542 ('note', 'period.example.com'))
543
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100544 def test_analysis_nothing(self):
545 self.c._all_hosts = []
546 self.assertFalse(self.c.has_generic_host())
547 self.assertEqual(set(), self.c.get_conflicting_hosts())
548 self.assertEqual(set(), self.c.get_duplicated_hosts())
549 self.assertEqual(set(), self.c.get_partially_configured_hosts())
550 self.assertEqual(set(), self.c.get_hosts_with_wrong_identities())
551
552 def test_analysis(self):
553 self.mock_hosts_creds([
554 ('.googlesource.com', 'git-example.chromium.org'),
555
556 ('chromium', 'git-example.google.com'),
557 ('chromium-review', 'git-example.google.com'),
558 ('chrome-internal', 'git-example.chromium.org'),
559 ('chrome-internal-review', 'git-example.chromium.org'),
560 ('conflict', 'git-example.google.com'),
561 ('conflict-review', 'git-example.chromium.org'),
562 ('dup', 'git-example.google.com'),
563 ('dup', 'git-example.google.com'),
564 ('dup-review', 'git-example.google.com'),
565 ('partial', 'git-example.google.com'),
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200566 ('gpartial-review', 'git-example.google.com'),
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100567 ])
568 self.assertTrue(self.c.has_generic_host())
569 self.assertEqual(set(['conflict.googlesource.com']),
570 self.c.get_conflicting_hosts())
571 self.assertEqual(set(['dup.googlesource.com']),
572 self.c.get_duplicated_hosts())
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200573 self.assertEqual(set(['partial.googlesource.com',
574 'gpartial-review.googlesource.com']),
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100575 self.c.get_partially_configured_hosts())
576 self.assertEqual(set(['chromium.googlesource.com',
577 'chrome-internal.googlesource.com']),
578 self.c.get_hosts_with_wrong_identities())
579
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100580 def test_report_no_problems(self):
581 self.test_analysis_nothing()
Edward Lemur79d4f992019-11-11 23:49:02 +0000582 self.mock(sys, 'stdout', StringIO())
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100583 self.assertFalse(self.c.find_and_report_problems())
584 self.assertEqual(sys.stdout.getvalue(), '')
585
586 def test_report(self):
587 self.test_analysis()
Edward Lemur79d4f992019-11-11 23:49:02 +0000588 self.mock(sys, 'stdout', StringIO())
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200589 self.mock(git_cl.gerrit_util.CookiesAuthenticator, 'get_gitcookies_path',
590 classmethod(lambda _: '~/.gitcookies'))
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100591 self.assertTrue(self.c.find_and_report_problems())
592 with open(os.path.join(os.path.dirname(__file__),
593 'git_cl_creds_check_report.txt')) as f:
594 expected = f.read()
595 def by_line(text):
596 return [l.rstrip() for l in text.rstrip().splitlines()]
Robert Iannucci456b0d62018-03-13 19:15:50 -0700597 self.maxDiff = 10000 # pylint: disable=attribute-defined-outside-init
Andrii Shyshkalov4812e612017-03-27 17:22:57 +0200598 self.assertEqual(by_line(sys.stdout.getvalue().strip()), by_line(expected))
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100599
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -0800600
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000601class TestGitCl(TestCase):
602 def setUp(self):
603 super(TestGitCl, self).setUp()
604 self.calls = []
tandrii9d206752016-06-20 11:32:47 -0700605 self._calls_done = []
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000606 self.mock(git_cl, 'time_time',
607 lambda: self._mocked_call('time.time'))
608 self.mock(git_cl.metrics.collector, 'add_repeated',
609 lambda *a: self._mocked_call('add_repeated', *a))
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000610 self.mock(subprocess2, 'call', self._mocked_call)
611 self.mock(subprocess2, 'check_call', self._mocked_call)
612 self.mock(subprocess2, 'check_output', self._mocked_call)
tandrii5d48c322016-08-18 16:19:37 -0700613 self.mock(subprocess2, 'communicate',
614 lambda *a, **kw: ([self._mocked_call(*a, **kw), ''], 0))
tandrii@chromium.orga342c922016-03-16 07:08:25 +0000615 self.mock(git_cl.gclient_utils, 'CheckCallAndFilter', self._mocked_call)
sbc@chromium.org71437c02015-04-09 19:29:40 +0000616 self.mock(git_common, 'is_dirty_git_tree', lambda x: False)
iannucci@chromium.org9e849272014-04-04 00:31:55 +0000617 self.mock(git_common, 'get_or_create_merge_base',
618 lambda *a: (
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000619 self._mocked_call(['get_or_create_merge_base'] + list(a))))
pgervais@chromium.org8ba38ff2015-06-11 21:41:25 +0000620 self.mock(git_cl, 'BranchExists', lambda _: True)
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000621 self.mock(git_cl, 'FindCodereviewSettingsFile', lambda: '')
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000622 self.mock(git_cl, 'SaveDescriptionBackup', lambda _:
623 self._mocked_call('SaveDescriptionBackup'))
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100624 self.mock(git_cl, 'ask_for_data', lambda *a, **k: self._mocked_call(
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000625 *(['ask_for_data'] + list(a)), **k))
phajdan.jre328cf92016-08-22 04:12:17 -0700626 self.mock(git_cl, 'write_json', lambda path, contents:
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000627 self._mocked_call('write_json', path, contents))
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000628 self.mock(git_cl.presubmit_support, 'DoPresubmitChecks', PresubmitMock)
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000629 self.mock(git_cl.watchlists, 'Watchlists', WatchlistsMock)
Edward Lemur5b929a42019-10-21 17:57:39 +0000630 self.mock(git_cl.auth, 'Authenticator', AuthenticatorMock)
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +0100631 self.mock(git_cl.gerrit_util, 'GetChangeDetail',
632 lambda *args, **kwargs: self._mocked_call(
633 'GetChangeDetail', *args, **kwargs))
Aaron Gable0ffdf2d2017-06-05 13:01:17 -0700634 self.mock(git_cl.gerrit_util, 'GetChangeComments',
635 lambda *args, **kwargs: self._mocked_call(
636 'GetChangeComments', *args, **kwargs))
Quinten Yearsley0e617c02019-02-20 00:37:03 +0000637 self.mock(git_cl.gerrit_util, 'GetChangeRobotComments',
638 lambda *args, **kwargs: self._mocked_call(
639 'GetChangeRobotComments', *args, **kwargs))
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +0100640 self.mock(git_cl.gerrit_util, 'AddReviewers',
Aaron Gable6dadfbf2017-05-09 14:27:58 -0700641 lambda h, i, reviewers, ccs, notify: self._mocked_call(
642 'AddReviewers', h, i, reviewers, ccs, notify))
Aaron Gablefd238082017-06-07 13:42:34 -0700643 self.mock(git_cl.gerrit_util, 'SetReview',
Aaron Gablefc62f762017-07-17 11:12:07 -0700644 lambda h, i, msg=None, labels=None, notify=None:
645 self._mocked_call('SetReview', h, i, msg, labels, notify))
Andrii Shyshkalov733d4ec2018-04-19 11:48:58 -0700646 self.mock(git_cl.gerrit_util.LuciContextAuthenticator, 'is_luci',
647 staticmethod(lambda: False))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000648 self.mock(git_cl.gerrit_util.GceAuthenticator, 'is_gce',
649 classmethod(lambda _: False))
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +0000650 self.mock(git_cl.gerrit_util, 'ValidAccounts',
651 lambda host, accounts:
652 self._mocked_call('ValidAccounts', host, accounts))
tandriic2405f52016-10-10 08:13:15 -0700653 self.mock(git_cl, 'DieWithError',
Christopher Lamf732cd52017-01-24 12:40:11 +1100654 lambda msg, change=None: self._mocked_call(['DieWithError', msg]))
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000655 # It's important to reset settings to not have inter-tests interference.
656 git_cl.settings = None
657
658 def tearDown(self):
wychen@chromium.org445c8962015-04-28 23:30:05 +0000659 try:
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +0000660 self.assertEqual([], self.calls)
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100661 except AssertionError:
wychen@chromium.org445c8962015-04-28 23:30:05 +0000662 if not self.has_failed():
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100663 raise
664 # Sadly, has_failed() returns True if this OR any other tests before this
665 # one have failed.
Andrii Shyshkalove05d4882017-04-12 14:34:49 +0200666 git_cl.logging.error(
667 '!!!!!! IF YOU SEE THIS, READ BELOW, IT WILL SAVE YOUR TIME !!!!!\n'
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100668 'There are un-consumed self.calls after this test has finished.\n'
669 'If you don\'t know which test this is, run:\n'
Aaron Gable3a16ed12017-03-23 10:51:55 -0700670 ' tests/git_cl_tests.py -v\n'
Andrii Shyshkalove05d4882017-04-12 14:34:49 +0200671 'If you are already running only this test, then **first** fix the '
672 'problem whose exception is emitted below by unittest runner.\n'
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100673 'Else, to be sure what\'s going on, run this test **alone** with \n'
Aaron Gable3a16ed12017-03-23 10:51:55 -0700674 ' tests/git_cl_tests.py TestGitCl.<name>\n'
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100675 'and follow instructions above.\n' +
676 '=' * 80)
wychen@chromium.org445c8962015-04-28 23:30:05 +0000677 finally:
678 super(TestGitCl, self).tearDown()
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000679
iannucci@chromium.org9e849272014-04-04 00:31:55 +0000680 def _mocked_call(self, *args, **_kwargs):
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000681 self.assertTrue(
682 self.calls,
tandrii9d206752016-06-20 11:32:47 -0700683 '@%d Expected: <Missing> Actual: %r' % (len(self._calls_done), args))
wychen@chromium.orga872e752015-04-28 23:42:18 +0000684 top = self.calls.pop(0)
wychen@chromium.orga872e752015-04-28 23:42:18 +0000685 expected_args, result = top
686
maruel@chromium.orge52678e2013-04-26 18:34:44 +0000687 # Also logs otherwise it could get caught in a try/finally and be hard to
688 # diagnose.
689 if expected_args != args:
tandrii9d206752016-06-20 11:32:47 -0700690 N = 5
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000691 prior_calls = '\n '.join(
tandrii9d206752016-06-20 11:32:47 -0700692 '@%d: %r' % (len(self._calls_done) - N + i, c[0])
693 for i, c in enumerate(self._calls_done[-N:]))
694 following_calls = '\n '.join(
695 '@%d: %r' % (len(self._calls_done) + i + 1, c[0])
696 for i, c in enumerate(self.calls[:N]))
697 extended_msg = (
698 'A few prior calls:\n %s\n\n'
699 'This (expected):\n @%d: %r\n'
700 'This (actual):\n @%d: %r\n\n'
701 'A few following expected calls:\n %s' %
702 (prior_calls, len(self._calls_done), expected_args,
703 len(self._calls_done), args, following_calls))
704 git_cl.logging.error(extended_msg)
705
tandrii99a72f22016-08-17 14:33:24 -0700706 self.fail('@%d\n'
707 ' Expected: %r\n'
708 ' Actual: %r' % (
tandrii9d206752016-06-20 11:32:47 -0700709 len(self._calls_done), expected_args, args))
710
711 self._calls_done.append(top)
tandrii5d48c322016-08-18 16:19:37 -0700712 if isinstance(result, Exception):
713 raise result
Edward Lemur0db01f02019-11-12 22:01:51 +0000714 # stdout from git commands is supposed to be a bytestream. Convert it here
715 # instead of converting all test output in this file to bytes.
716 if args[0][0] == 'git' and not isinstance(result, bytes):
717 result = result.encode('utf-8')
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000718 return result
719
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100720 def test_ask_for_explicit_yes_true(self):
721 self.calls = [
722 (('ask_for_data', 'prompt [Yes/No]: '), 'blah'),
723 (('ask_for_data', 'Please, type yes or no: '), 'ye'),
724 ]
725 self.assertTrue(git_cl.ask_for_explicit_yes('prompt'))
726
tandrii48df5812016-10-17 03:55:37 -0700727 def test_LoadCodereviewSettingsFromFile_gerrit(self):
Edward Lemur79d4f992019-11-11 23:49:02 +0000728 codereview_file = StringIO('GERRIT_HOST: true')
tandrii48df5812016-10-17 03:55:37 -0700729 self.calls = [
730 ((['git', 'config', '--unset-all', 'rietveld.cc'],), CERR1),
tandrii48df5812016-10-17 03:55:37 -0700731 ((['git', 'config', '--unset-all', 'rietveld.tree-status-url'],), CERR1),
732 ((['git', 'config', '--unset-all', 'rietveld.viewvc-url'],), CERR1),
733 ((['git', 'config', '--unset-all', 'rietveld.bug-prefix'],), CERR1),
734 ((['git', 'config', '--unset-all', 'rietveld.cpplint-regex'],), CERR1),
tandrii48df5812016-10-17 03:55:37 -0700735 ((['git', 'config', '--unset-all', 'rietveld.cpplint-ignore-regex'],),
736 CERR1),
tandrii48df5812016-10-17 03:55:37 -0700737 ((['git', 'config', '--unset-all', 'rietveld.run-post-upload-hook'],),
738 CERR1),
Jamie Madilldc4d19e2019-10-24 21:50:02 +0000739 ((['git', 'config', '--unset-all', 'rietveld.format-full-by-default'],),
740 CERR1),
tandrii48df5812016-10-17 03:55:37 -0700741 ((['git', 'config', 'gerrit.host', 'true'],), ''),
742 ]
743 self.assertIsNone(git_cl.LoadCodereviewSettingsFromFile(codereview_file))
744
maruel@chromium.orga3353652011-11-30 14:26:57 +0000745 @classmethod
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000746 def _is_gerrit_calls(cls, gerrit=False):
747 return [((['git', 'config', 'rietveld.autoupdate'],), ''),
748 ((['git', 'config', 'gerrit.host'],), 'True' if gerrit else '')]
749
750 @classmethod
tandrii@chromium.org1e67bb72016-02-11 12:15:49 +0000751 def _git_post_upload_calls(cls):
752 return [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000753 ((['git', 'rev-parse', 'HEAD'],), 'hash'),
754 ((['git', 'symbolic-ref', 'HEAD'],), 'hash'),
755 ((['git',
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000756 'config', 'branch.hash.last-upload-hash', 'hash'],), ''),
rmistry@google.com5626a922015-02-26 14:03:30 +0000757 ((['git', 'config', 'rietveld.run-post-upload-hook'],), ''),
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000758 ]
759
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000760 @staticmethod
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000761 def _git_sanity_checks(diff_base, working_branch, get_remote_branch=True):
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000762 fake_ancestor = 'fake_ancestor'
763 fake_cl = 'fake_cl_for_patch'
764 return [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000765 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000766 'rev-parse', '--verify', diff_base],), fake_ancestor),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000767 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000768 'merge-base', fake_ancestor, 'HEAD'],), fake_ancestor),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000769 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000770 'rev-list', '^' + fake_ancestor, 'HEAD'],), fake_cl),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000771 # Mock a config miss (error code 1)
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000772 ((['git',
tandrii5d48c322016-08-18 16:19:37 -0700773 'config', 'gitcl.remotebranch'],), CERR1),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000774 ] + ([
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000775 # Call to GetRemoteBranch()
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000776 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000777 'config', 'branch.%s.merge' % working_branch],),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000778 'refs/heads/master'),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000779 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000780 'config', 'branch.%s.remote' % working_branch],), 'origin'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000781 ] if get_remote_branch else []) + [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000782 ((['git', 'rev-list', '^' + fake_ancestor,
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000783 'refs/remotes/origin/master'],), ''),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000784 ]
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000785
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000786 @classmethod
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000787 def _gerrit_ensure_auth_calls(
Edward Lemurf38bc172019-09-03 21:02:13 +0000788 cls, issue=None, skip_auth_check=False, short_hostname='chromium',
789 custom_cl_base=None):
shinyak@chromium.org00dbccd2016-04-15 07:24:43 +0000790 cmd = ['git', 'config', '--bool', 'gerrit.skip-ensure-authenticated']
tandrii@chromium.org28253532016-04-14 13:46:56 +0000791 if skip_auth_check:
792 return [((cmd, ), 'true')]
793
tandrii5d48c322016-08-18 16:19:37 -0700794 calls = [((cmd, ), CERR1)]
Edward Lemurf38bc172019-09-03 21:02:13 +0000795
796 if custom_cl_base:
797 calls += [
798 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
799 ]
800
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000801 calls.extend([
802 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
803 ((['git', 'config', 'branch.master.remote'],), 'origin'),
804 ((['git', 'config', 'remote.origin.url'],),
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000805 'https://%s.googlesource.com/my/repo' % short_hostname),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000806 ])
Edward Lemurf38bc172019-09-03 21:02:13 +0000807
808 calls += [
809 ((['git', 'config', 'branch.master.gerritissue'],),
810 CERR1 if issue is None else str(issue)),
811 ]
812
Daniel Chengcf6269b2019-05-18 01:02:12 +0000813 if issue:
814 calls.extend([
815 ((['git', 'config', 'branch.master.gerritserver'],), CERR1),
816 ])
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000817 return calls
818
819 @classmethod
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100820 def _gerrit_base_calls(cls, issue=None, fetched_description=None,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200821 fetched_status=None, other_cl_owner=None,
Anthony Polito8b955342019-09-24 19:01:36 +0000822 custom_cl_base=None, short_hostname='chromium',
823 change_id=None):
Aaron Gable13101a62018-02-09 13:20:41 -0800824 calls = cls._is_gerrit_calls(True)
Edward Lemurf38bc172019-09-03 21:02:13 +0000825 if not custom_cl_base:
826 calls += [
827 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
828 ]
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200829
830 if custom_cl_base:
831 ancestor_revision = custom_cl_base
832 else:
833 # Determine ancestor_revision to be merge base.
834 ancestor_revision = 'fake_ancestor_sha'
835 calls += [
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000836 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000837 ((['git', 'config', 'branch.master.remote'],), 'origin'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000838 ((['get_or_create_merge_base', 'master',
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200839 'refs/remotes/origin/master'],), ancestor_revision),
840 ]
841
842 # Calls to verify branch point is ancestor
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000843 calls += cls._gerrit_ensure_auth_calls(
Edward Lemurf38bc172019-09-03 21:02:13 +0000844 issue=issue, short_hostname=short_hostname,
845 custom_cl_base=custom_cl_base)
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100846
847 if issue:
848 calls += [
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000849 (('GetChangeDetail', '%s-review.googlesource.com' % short_hostname,
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +0000850 'my%2Frepo~123456',
Andrii Shyshkalovc4a73562018-09-25 18:40:17 +0000851 ['DETAILED_ACCOUNTS', 'CURRENT_REVISION', 'CURRENT_COMMIT', 'LABELS']
852 ),
Andrii Shyshkalov3e631422017-02-16 17:46:44 +0100853 {
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100854 'owner': {'email': (other_cl_owner or 'owner@example.com')},
Anthony Polito8b955342019-09-24 19:01:36 +0000855 'change_id': (change_id or '123456789'),
Andrii Shyshkalov3e631422017-02-16 17:46:44 +0100856 'current_revision': 'sha1_of_current_revision',
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000857 'revisions': {'sha1_of_current_revision': {
Andrii Shyshkalov3e631422017-02-16 17:46:44 +0100858 'commit': {'message': fetched_description},
859 }},
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100860 'status': fetched_status or 'NEW',
Andrii Shyshkalov3e631422017-02-16 17:46:44 +0100861 }),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100862 ]
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100863 if fetched_status == 'ABANDONED':
864 calls += [
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000865 (('DieWithError', 'Change https://%s-review.googlesource.com/'
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100866 '123456 has been abandoned, new uploads are not '
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000867 'allowed' % short_hostname), SystemExitMock()),
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100868 ]
869 return calls
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100870 if other_cl_owner:
871 calls += [
872 (('ask_for_data', 'Press Enter to upload, or Ctrl+C to abort'), ''),
873 ]
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100874
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200875 calls += cls._git_sanity_checks(ancestor_revision, 'master',
876 get_remote_branch=False)
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100877 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200878 ((['git', 'rev-parse', '--show-cdup'],), ''),
879 ((['git', 'rev-parse', 'HEAD'],), '12345'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000880
Aaron Gable7817f022017-12-12 09:43:17 -0800881 ((['git', '-c', 'core.quotePath=false', 'diff', '--name-status',
882 '--no-renames', '-r', ancestor_revision + '...', '.'],),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200883 'M\t.gitignore\n'),
884 ((['git', 'config', 'branch.master.gerritpatchset'],), CERR1),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100885 ]
886
887 if not issue:
888 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200889 ((['git', 'log', '--pretty=format:%s%n%n%b',
890 ancestor_revision + '...'],),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000891 'foo'),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100892 ]
893
894 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200895 ((['git', 'config', 'user.email'],), 'me@example.com'),
Edward Lemur2c48f242019-06-04 16:14:09 +0000896 (('time.time',), 1000,),
897 (('time.time',), 3000,),
898 (('add_repeated', 'sub_commands', {
899 'execution_time': 2000,
900 'command': 'presubmit',
901 'exit_code': 0
902 }), None,),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200903 ((['git', 'diff', '--no-ext-diff', '--stat', '-l100000', '-C50'] +
904 ([custom_cl_base] if custom_cl_base else
905 [ancestor_revision, 'HEAD']),),
906 '+dat'),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100907 ]
908 return calls
ukai@chromium.orge8077812012-02-03 03:41:46 +0000909
tandrii@chromium.org1e67bb72016-02-11 12:15:49 +0000910 @classmethod
911 def _gerrit_upload_calls(cls, description, reviewers, squash,
tandriia60502f2016-06-20 02:01:53 -0700912 squash_mode='default',
tandrii@chromium.org10625002016-03-04 20:03:47 +0000913 expected_upstream_ref='origin/refs/heads/master',
Aaron Gablefd238082017-06-07 13:42:34 -0700914 title=None, notify=False,
Andrii Shyshkalove9c78ff2017-02-06 15:53:13 +0100915 post_amend_description=None, issue=None, cc=None,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000916 custom_cl_base=None, tbr=None,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +0000917 short_hostname='chromium',
Edward Lemur1b52d872019-05-09 21:12:12 +0000918 labels=None, change_id=None, original_title=None,
Anthony Polito8b955342019-09-24 19:01:36 +0000919 final_description=None, gitcookies_exists=True,
920 force=False):
tandrii@chromium.org10625002016-03-04 20:03:47 +0000921 if post_amend_description is None:
922 post_amend_description = description
bradnelsond975b302016-10-23 12:20:23 -0700923 cc = cc or []
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200924 # Determined in `_gerrit_base_calls`.
925 determined_ancestor_revision = custom_cl_base or 'fake_ancestor_sha'
926
927 calls = []
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000928
tandriia60502f2016-06-20 02:01:53 -0700929 if squash_mode == 'default':
930 calls.extend([
931 ((['git', 'config', '--bool', 'gerrit.override-squash-uploads'],), ''),
932 ((['git', 'config', '--bool', 'gerrit.squash-uploads'],), ''),
933 ])
934 elif squash_mode in ('override_squash', 'override_nosquash'):
935 calls.extend([
936 ((['git', 'config', '--bool', 'gerrit.override-squash-uploads'],),
937 'true' if squash_mode == 'override_squash' else 'false'),
938 ])
939 else:
940 assert squash_mode in ('squash', 'nosquash')
941
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000942 # If issue is given, then description is fetched from Gerrit instead.
943 if issue is None:
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000944 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200945 ((['git', 'log', '--pretty=format:%s\n\n%b',
946 ((custom_cl_base + '..') if custom_cl_base else
947 'fake_ancestor_sha..HEAD')],),
948 description),
949 ]
Aaron Gableb56ad332017-01-06 15:24:31 -0800950 if squash:
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +0000951 title = 'Initial_upload'
Aaron Gableb56ad332017-01-06 15:24:31 -0800952 else:
953 if not title:
954 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200955 ((['git', 'show', '-s', '--format=%s', 'HEAD'],), ''),
956 (('ask_for_data', 'Title for patchset []: '), 'User input'),
Aaron Gableb56ad332017-01-06 15:24:31 -0800957 ]
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +0000958 title = 'User_input'
tandrii@chromium.org57d86542016-03-04 16:11:32 +0000959 if not git_footers.get_footer_change_id(description) and not squash:
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +0000960 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200961 (('DownloadGerritHook', False), ''),
962 # Amending of commit message to get the Change-Id.
963 ((['git', 'log', '--pretty=format:%s\n\n%b',
964 determined_ancestor_revision + '..HEAD'],),
965 description),
966 ((['git', 'commit', '--amend', '-m', description],), ''),
967 ((['git', 'log', '--pretty=format:%s\n\n%b',
968 determined_ancestor_revision + '..HEAD'],),
969 post_amend_description)
970 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000971 if squash:
Anthony Polito8b955342019-09-24 19:01:36 +0000972 if force or not issue:
973 if issue:
974 calls += [
975 ((['git', 'config', 'rietveld.bug-prefix'],), ''),
976 ]
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000977 # Prompting to edit description on first upload.
978 calls += [
Jonas Termansend0f79112019-03-22 15:28:26 +0000979 ((['git', 'config', 'rietveld.bug-prefix'],), ''),
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000980 ]
Anthony Polito8b955342019-09-24 19:01:36 +0000981 if not force:
982 calls += [
983 ((['git', 'config', 'core.editor'],), ''),
984 ((['RunEditor'],), description),
985 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000986 ref_to_push = 'abcdef0123456789'
987 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200988 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
989 ((['git', 'config', 'branch.master.remote'],), 'origin'),
990 ]
991
992 if custom_cl_base is None:
993 calls += [
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000994 ((['get_or_create_merge_base', 'master',
995 'refs/remotes/origin/master'],),
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000996 'origin/master'),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200997 ]
998 parent = 'origin/master'
999 else:
1000 calls += [
1001 ((['git', 'merge-base', '--is-ancestor', custom_cl_base,
1002 'refs/remotes/origin/master'],),
1003 callError(1)), # Means not ancenstor.
1004 (('ask_for_data',
1005 'Do you take responsibility for cleaning up potential mess '
1006 'resulting from proceeding with upload? Press Enter to upload, '
1007 'or Ctrl+C to abort'), ''),
1008 ]
1009 parent = custom_cl_base
1010
1011 calls += [
1012 ((['git', 'rev-parse', 'HEAD:'],), # `HEAD:` means HEAD's tree hash.
1013 '0123456789abcdef'),
1014 ((['git', 'commit-tree', '0123456789abcdef', '-p', parent,
Aaron Gable9a03ae02017-11-03 11:31:07 -07001015 '-F', '/tmp/named'],),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001016 ref_to_push),
1017 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001018 else:
1019 ref_to_push = 'HEAD'
1020
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001021 calls += [
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +00001022 (('SaveDescriptionBackup',), None),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001023 ((['git', 'rev-list',
1024 (custom_cl_base if custom_cl_base else expected_upstream_ref) + '..' +
1025 ref_to_push],),
1026 '1hashPerLine\n'),
1027 ]
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001028
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001029 metrics_arguments = []
1030
Aaron Gableafd52772017-06-27 16:40:10 -07001031 if notify:
Aaron Gable844cf292017-06-28 11:32:59 -07001032 ref_suffix = '%ready,notify=ALL'
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001033 metrics_arguments += ['ready', 'notify=ALL']
Aaron Gable844cf292017-06-28 11:32:59 -07001034 else:
Jamie Madill276da0b2018-04-27 14:41:20 -04001035 if not issue and squash:
Aaron Gable844cf292017-06-28 11:32:59 -07001036 ref_suffix = '%wip'
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001037 metrics_arguments.append('wip')
Aaron Gable844cf292017-06-28 11:32:59 -07001038 else:
1039 ref_suffix = '%notify=NONE'
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001040 metrics_arguments.append('notify=NONE')
Aaron Gable9b713dd2016-12-14 16:04:21 -08001041
Aaron Gable70f4e242017-06-26 10:45:59 -07001042 if title:
Aaron Gableafd52772017-06-27 16:40:10 -07001043 ref_suffix += ',m=' + title
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001044 metrics_arguments.append('m')
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001045
Edward Lemur4508b422019-10-03 21:56:35 +00001046 if issue is None:
1047 calls += [
1048 ((['git', 'config', 'rietveld.cc'],), ''),
1049 ]
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001050 if short_hostname == 'chromium':
1051 # All reviwers and ccs get into ref_suffix.
1052 for r in sorted(reviewers):
1053 ref_suffix += ',r=%s' % r
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001054 metrics_arguments.append('r')
Edward Lemur4508b422019-10-03 21:56:35 +00001055 if issue is None:
1056 cc += ['chromium-reviews+test-more-cc@chromium.org', 'joe@example.com']
1057 for c in sorted(cc):
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001058 ref_suffix += ',cc=%s' % c
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001059 metrics_arguments.append('cc')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001060 reviewers, cc = [], []
1061 else:
1062 # TODO(crbug/877717): remove this case.
1063 calls += [
1064 (('ValidAccounts', '%s-review.googlesource.com' % short_hostname,
1065 sorted(reviewers) + ['joe@example.com',
1066 'chromium-reviews+test-more-cc@chromium.org'] + cc),
1067 {
1068 e: {'email': e}
1069 for e in (reviewers + ['joe@example.com'] + cc)
1070 })
1071 ]
1072 for r in sorted(reviewers):
1073 if r != 'bad-account-or-email':
1074 ref_suffix += ',r=%s' % r
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001075 metrics_arguments.append('r')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001076 reviewers.remove(r)
Edward Lemur4508b422019-10-03 21:56:35 +00001077 if issue is None:
1078 cc += ['joe@example.com']
1079 for c in sorted(cc):
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001080 ref_suffix += ',cc=%s' % c
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001081 metrics_arguments.append('cc')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001082 if c in cc:
1083 cc.remove(c)
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00001084
Edward Lemur687ca902018-12-05 02:30:30 +00001085 for k, v in sorted((labels or {}).items()):
1086 ref_suffix += ',l=%s+%d' % (k, v)
1087 metrics_arguments.append('l=%s+%d' % (k, v))
1088
1089 if tbr:
1090 calls += [
1091 (('GetCodeReviewTbrScore',
1092 '%s-review.googlesource.com' % short_hostname,
1093 'my/repo'),
1094 2,),
1095 ]
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001096
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001097 calls += [
1098 (('time.time',), 1000,),
1099 ((['git', 'push',
1100 'https://%s.googlesource.com/my/repo' % short_hostname,
1101 ref_to_push + ':refs/for/refs/heads/master' + ref_suffix],),
1102 (('remote:\n'
1103 'remote: Processing changes: (\)\n'
1104 'remote: Processing changes: (|)\n'
1105 'remote: Processing changes: (/)\n'
1106 'remote: Processing changes: (-)\n'
1107 'remote: Processing changes: new: 1 (/)\n'
1108 'remote: Processing changes: new: 1, done\n'
1109 'remote:\n'
1110 'remote: New Changes:\n'
1111 'remote: https://%s-review.googlesource.com/#/c/my/repo/+/123456'
1112 ' XXX\n'
1113 'remote:\n'
1114 'To https://%s.googlesource.com/my/repo\n'
1115 ' * [new branch] hhhh -> refs/for/refs/heads/master\n'
1116 ) % (short_hostname, short_hostname)),),
1117 (('time.time',), 2000,),
1118 (('add_repeated',
1119 'sub_commands',
1120 {
1121 'execution_time': 1000,
1122 'command': 'git push',
1123 'exit_code': 0,
1124 'arguments': sorted(metrics_arguments),
1125 }),
1126 None,),
1127 ]
1128
Edward Lemur1b52d872019-05-09 21:12:12 +00001129 final_description = final_description or post_amend_description.strip()
1130 original_title = original_title or title or '<untitled>'
1131 # Trace-related calls
1132 calls += [
1133 # Write a description with context for the current trace.
1134 ((['FileWrite', 'TRACES_DIR/20170316T200041.000000-README',
Edward Lemur75391d42019-05-14 23:35:56 +00001135 'Thu Mar 16 20:00:41 2017\n'
1136 '%(short_hostname)s-review.googlesource.com\n'
1137 '%(change_id)s\n'
1138 '%(title)s\n'
1139 '%(description)s\n'
1140 '1000\n'
1141 '0\n'
1142 '%(trace_name)s' % {
Edward Lemur1b52d872019-05-09 21:12:12 +00001143 'short_hostname': short_hostname,
1144 'change_id': change_id,
1145 'description': final_description,
1146 'title': original_title,
Edward Lemur75391d42019-05-14 23:35:56 +00001147 'trace_name': 'TRACES_DIR/20170316T200041.000000',
Edward Lemur1b52d872019-05-09 21:12:12 +00001148 }],),
1149 None,
1150 ),
1151 # Read traces and shorten git hashes.
1152 ((['os.path.isfile', 'TEMP_DIR/trace-packet'],),
1153 True,
1154 ),
1155 ((['FileRead', 'TEMP_DIR/trace-packet'],),
1156 ('git-hash: 0123456789012345678901234567890123456789\n'
1157 'git-hash: abcdeabcdeabcdeabcdeabcdeabcdeabcdeabcde\n'),
1158 ),
1159 ((['FileWrite', 'TEMP_DIR/trace-packet',
1160 'git-hash: 012345\n'
1161 'git-hash: abcdea\n'],),
1162 None,
1163 ),
1164 # Make zip file for the git traces.
1165 ((['make_archive', 'TRACES_DIR/20170316T200041.000000-traces', 'zip',
1166 'TEMP_DIR'],),
1167 None,
1168 ),
1169 # Collect git config and gitcookies.
1170 ((['git', 'config', '-l'],),
1171 'git-config-output',
1172 ),
1173 ((['FileWrite', 'TEMP_DIR/git-config', 'git-config-output'],),
1174 None,
1175 ),
1176 ((['os.path.isfile', '~/.gitcookies'],),
1177 gitcookies_exists,
1178 ),
1179 ]
1180 if gitcookies_exists:
1181 calls += [
1182 ((['FileRead', '~/.gitcookies'],),
1183 'gitcookies 1/SECRET',
1184 ),
1185 ((['FileWrite', 'TEMP_DIR/gitcookies', 'gitcookies REDACTED'],),
1186 None,
1187 ),
1188 ]
1189 calls += [
1190 # Make zip file for the git config and gitcookies.
1191 ((['make_archive', 'TRACES_DIR/20170316T200041.000000-git-info', 'zip',
1192 'TEMP_DIR'],),
1193 None,
1194 ),
1195 ]
1196
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001197 if squash:
1198 calls += [
tandrii33a46ff2016-08-23 05:53:40 -07001199 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
tandrii5d48c322016-08-18 16:19:37 -07001200 ''),
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001201 ((['git', 'config', 'branch.master.gerritserver',
tandrii5d48c322016-08-18 16:19:37 -07001202 'https://chromium-review.googlesource.com'],), ''),
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001203 ((['git', 'config', 'branch.master.gerritsquashhash',
1204 'abcdef0123456789'],), ''),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001205 ]
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001206 # TODO(crbug/877717): this should never be used.
1207 if squash and short_hostname != 'chromium':
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001208 calls += [
1209 (('AddReviewers',
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00001210 'chromium-review.googlesource.com', 'my%2Frepo~123456',
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001211 sorted(reviewers),
Andrii Shyshkalov2f727912018-10-15 17:02:33 +00001212 cc + ['chromium-reviews+test-more-cc@chromium.org'],
1213 notify),
1214 ''),
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001215 ]
tandrii@chromium.org1e67bb72016-02-11 12:15:49 +00001216 calls += cls._git_post_upload_calls()
ukai@chromium.orge8077812012-02-03 03:41:46 +00001217 return calls
1218
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001219 def _run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001220 self,
1221 upload_args,
1222 description,
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00001223 reviewers=None,
tandriia60502f2016-06-20 02:01:53 -07001224 squash=True,
1225 squash_mode=None,
tandrii@chromium.org10625002016-03-04 20:03:47 +00001226 expected_upstream_ref='origin/refs/heads/master',
Aaron Gable9b713dd2016-12-14 16:04:21 -08001227 title=None,
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001228 notify=False,
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001229 post_amend_description=None,
bradnelsond975b302016-10-23 12:20:23 -07001230 issue=None,
Andrii Shyshkalove9c78ff2017-02-06 15:53:13 +01001231 cc=None,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001232 fetched_status=None,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001233 other_cl_owner=None,
Aaron Gablefd238082017-06-07 13:42:34 -07001234 custom_cl_base=None,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001235 tbr=None,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001236 short_hostname='chromium',
Edward Lemur1b52d872019-05-09 21:12:12 +00001237 labels=None,
1238 change_id=None,
1239 original_title=None,
1240 final_description=None,
Anthony Polito8b955342019-09-24 19:01:36 +00001241 gitcookies_exists=True,
1242 force=False,
1243 fetched_description=None):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001244 """Generic gerrit upload test framework."""
tandriia60502f2016-06-20 02:01:53 -07001245 if squash_mode is None:
1246 if '--no-squash' in upload_args:
1247 squash_mode = 'nosquash'
1248 elif '--squash' in upload_args:
1249 squash_mode = 'squash'
1250 else:
1251 squash_mode = 'default'
1252
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00001253 reviewers = reviewers or []
bradnelsond975b302016-10-23 12:20:23 -07001254 cc = cc or []
Edward Lemur79d4f992019-11-11 23:49:02 +00001255 self.mock(git_cl.sys, 'stdout', StringIO())
tandrii16e0b4e2016-06-07 10:34:28 -07001256 self.mock(git_cl.gerrit_util, 'CookiesAuthenticator',
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001257 CookiesAuthenticatorMockFactory(
1258 same_auth=('git-owner.example.com', '', 'pass')))
Edward Lemur125d60a2019-09-13 18:25:41 +00001259 self.mock(git_cl.Changelist, '_GerritCommitMsgHookCheck',
tandrii16e0b4e2016-06-07 10:34:28 -07001260 lambda _, offer_removal: None)
tandriia60502f2016-06-20 02:01:53 -07001261 self.mock(git_cl.gclient_utils, 'RunEditor',
1262 lambda *_, **__: self._mocked_call(['RunEditor']))
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001263 self.mock(git_cl, 'DownloadGerritHook', lambda force: self._mocked_call(
1264 'DownloadGerritHook', force))
Edward Lemur1b52d872019-05-09 21:12:12 +00001265 self.mock(git_cl.gclient_utils, 'FileRead',
1266 lambda path: self._mocked_call(['FileRead', path]))
1267 self.mock(git_cl.gclient_utils, 'FileWrite',
1268 lambda path, contents: self._mocked_call(
1269 ['FileWrite', path, contents]))
1270 self.mock(git_cl, 'datetime_now',
1271 lambda: datetime.datetime(2017, 3, 16, 20, 0, 41, 0))
1272 self.mock(git_cl.tempfile, 'mkdtemp', lambda: 'TEMP_DIR')
1273 self.mock(git_cl, 'TRACES_DIR', 'TRACES_DIR')
Edward Lemur75391d42019-05-14 23:35:56 +00001274 self.mock(git_cl, 'TRACES_README_FORMAT',
1275 '%(now)s\n'
1276 '%(gerrit_host)s\n'
1277 '%(change_id)s\n'
1278 '%(title)s\n'
1279 '%(description)s\n'
1280 '%(execution_time)s\n'
1281 '%(exit_code)s\n'
1282 '%(trace_name)s')
Edward Lemur1b52d872019-05-09 21:12:12 +00001283 self.mock(git_cl.shutil, 'make_archive',
1284 lambda *args: self._mocked_call(['make_archive'] + list(args)))
1285 self.mock(os.path, 'isfile',
1286 lambda path: self._mocked_call(['os.path.isfile', path]))
tandriia60502f2016-06-20 02:01:53 -07001287
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001288 self.calls = self._gerrit_base_calls(
1289 issue=issue,
Anthony Polito8b955342019-09-24 19:01:36 +00001290 fetched_description=fetched_description or description,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001291 fetched_status=fetched_status,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001292 other_cl_owner=other_cl_owner,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001293 custom_cl_base=custom_cl_base,
Anthony Polito8b955342019-09-24 19:01:36 +00001294 short_hostname=short_hostname,
1295 change_id=change_id)
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001296 if fetched_status != 'ABANDONED':
Aaron Gable9a03ae02017-11-03 11:31:07 -07001297 self.mock(tempfile, 'NamedTemporaryFile', MakeNamedTemporaryFileMock(
Edward Lemur0db01f02019-11-12 22:01:51 +00001298 self, expected_content=description))
Aaron Gable9a03ae02017-11-03 11:31:07 -07001299 self.mock(os, 'remove', lambda _: True)
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001300 self.calls += self._gerrit_upload_calls(
1301 description, reviewers, squash,
1302 squash_mode=squash_mode,
1303 expected_upstream_ref=expected_upstream_ref,
Aaron Gablefd238082017-06-07 13:42:34 -07001304 title=title, notify=notify,
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001305 post_amend_description=post_amend_description,
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00001306 issue=issue, cc=cc,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001307 custom_cl_base=custom_cl_base, tbr=tbr,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001308 short_hostname=short_hostname,
Edward Lemur1b52d872019-05-09 21:12:12 +00001309 labels=labels,
1310 change_id=change_id,
1311 original_title=original_title,
1312 final_description=final_description,
Anthony Polito8b955342019-09-24 19:01:36 +00001313 gitcookies_exists=gitcookies_exists,
1314 force=force)
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +00001315 # Uncomment when debugging.
Raul Tambre80ee78e2019-05-06 22:41:05 +00001316 # print('\n'.join(map(lambda x: '%2i: %s' % x, enumerate(self.calls))))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001317 git_cl.main(['upload'] + upload_args)
1318
Edward Lemur1b52d872019-05-09 21:12:12 +00001319 def test_gerrit_upload_traces_no_gitcookies(self):
1320 self._run_gerrit_upload_test(
1321 ['--no-squash'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001322 'desc ✔\n\nBUG=\n',
Edward Lemur1b52d872019-05-09 21:12:12 +00001323 [],
1324 squash=False,
Edward Lemur0db01f02019-11-12 22:01:51 +00001325 post_amend_description='desc ✔\n\nBUG=\n\nChange-Id: Ixxx',
Edward Lemur1b52d872019-05-09 21:12:12 +00001326 change_id='Ixxx',
1327 gitcookies_exists=False)
1328
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001329 def test_gerrit_upload_without_change_id(self):
tandriia60502f2016-06-20 02:01:53 -07001330 self._run_gerrit_upload_test(
1331 ['--no-squash'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001332 'desc ✔\n\nBUG=\n',
tandriia60502f2016-06-20 02:01:53 -07001333 [],
1334 squash=False,
Edward Lemur0db01f02019-11-12 22:01:51 +00001335 post_amend_description='desc ✔\n\nBUG=\n\nChange-Id: Ixxx',
Edward Lemur1b52d872019-05-09 21:12:12 +00001336 change_id='Ixxx')
tandriia60502f2016-06-20 02:01:53 -07001337
1338 def test_gerrit_upload_without_change_id_override_nosquash(self):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001339 self._run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001340 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001341 'desc ✔\n\nBUG=\n',
tandrii@chromium.org10625002016-03-04 20:03:47 +00001342 [],
tandriia60502f2016-06-20 02:01:53 -07001343 squash=False,
1344 squash_mode='override_nosquash',
Edward Lemur0db01f02019-11-12 22:01:51 +00001345 post_amend_description='desc ✔\n\nBUG=\n\nChange-Id: Ixxx',
Edward Lemur1b52d872019-05-09 21:12:12 +00001346 change_id='Ixxx')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001347
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001348 def test_gerrit_no_reviewer(self):
1349 self._run_gerrit_upload_test(
1350 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001351 'desc ✔\n\nBUG=\n\nChange-Id: I123456789\n',
tandriia60502f2016-06-20 02:01:53 -07001352 [],
1353 squash=False,
Edward Lemur1b52d872019-05-09 21:12:12 +00001354 squash_mode='override_nosquash',
1355 change_id='I123456789')
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001356
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001357 def test_gerrit_no_reviewer_non_chromium_host(self):
1358 # TODO(crbug/877717): remove this test case.
1359 self._run_gerrit_upload_test(
1360 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001361 'desc ✔\n\nBUG=\n\nChange-Id: I123456789\n',
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001362 [],
1363 squash=False,
1364 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001365 short_hostname='other',
1366 change_id='I123456789')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001367
Nick Carter8692b182017-11-06 16:30:38 -08001368 def test_gerrit_patchset_title_special_chars(self):
Edward Lemur79d4f992019-11-11 23:49:02 +00001369 self.mock(git_cl.sys, 'stdout', StringIO())
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001370 self._run_gerrit_upload_test(
Nick Carter8692b182017-11-06 16:30:38 -08001371 ['-f', '-t', 'We\'ll escape ^_ ^ special chars...@{u}'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001372 'desc ✔\n\nBUG=\n\nChange-Id: I123456789',
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001373 squash=False,
1374 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001375 title='We%27ll_escape_%5E%5F_%5E_special_chars%2E%2E%2E%40%7Bu%7D',
1376 change_id='I123456789',
1377 original_title='We\'ll escape ^_ ^ special chars...@{u}')
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001378
ukai@chromium.orge8077812012-02-03 03:41:46 +00001379 def test_gerrit_reviewers_cmd_line(self):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001380 self._run_gerrit_upload_test(
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001381 ['-r', 'foo@example.com', '--send-mail'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001382 'desc ✔\n\nBUG=\n\nChange-Id: I123456789',
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001383 ['foo@example.com'],
tandriia60502f2016-06-20 02:01:53 -07001384 squash=False,
1385 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001386 notify=True,
1387 change_id='I123456789',
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001388 final_description=(
Edward Lemur0db01f02019-11-12 22:01:51 +00001389 'desc ✔\n\nBUG=\nR=foo@example.com\n\nChange-Id: I123456789'))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001390
Anthony Polito8b955342019-09-24 19:01:36 +00001391 def test_gerrit_upload_force_sets_bug(self):
1392 self._run_gerrit_upload_test(
1393 ['-b', '10000', '-f'],
1394 u'desc=\n\nBug: 10000\nChange-Id: Ixxx',
1395 [],
1396 force=True,
1397 expected_upstream_ref='origin/master',
1398 fetched_description='desc=\n\nChange-Id: Ixxx',
1399 original_title='Initial upload',
1400 change_id='Ixxx')
1401
1402 def test_gerrit_upload_force_sets_bug_if_wrong_changeid(self):
1403 self._run_gerrit_upload_test(
1404 ['-b', '10000', '-f', '-m', 'Title'],
1405 u'desc=\n\nChange-Id: Ixxxx\n\nChange-Id: Izzzz\nBug: 10000',
1406 [],
1407 force=True,
1408 issue='123456',
1409 expected_upstream_ref='origin/master',
1410 fetched_description='desc=\n\nChange-Id: Ixxxx',
1411 original_title='Title',
1412 title='Title',
1413 change_id='Izzzz')
1414
Dan Beamd8b04ca2019-10-10 21:23:26 +00001415 def test_gerrit_upload_force_sets_fixed(self):
1416 self._run_gerrit_upload_test(
1417 ['-x', '10000', '-f'],
1418 u'desc=\n\nFixed: 10000\nChange-Id: Ixxx',
1419 [],
1420 force=True,
1421 expected_upstream_ref='origin/master',
1422 fetched_description='desc=\n\nChange-Id: Ixxx',
1423 original_title='Initial upload',
1424 change_id='Ixxx')
1425
ukai@chromium.orge8077812012-02-03 03:41:46 +00001426 def test_gerrit_reviewer_multiple(self):
Edward Lemur687ca902018-12-05 02:30:30 +00001427 self.mock(git_cl.gerrit_util, 'GetCodeReviewTbrScore',
1428 lambda *a: self._mocked_call('GetCodeReviewTbrScore', *a))
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001429 self._run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001430 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001431 'desc ✔\nTBR=reviewer@example.com\nBUG=\nR=another@example.com\n'
bradnelsond975b302016-10-23 12:20:23 -07001432 'CC=more@example.com,people@example.com\n\n'
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +09001433 'Change-Id: 123456789',
tandriia60502f2016-06-20 02:01:53 -07001434 ['reviewer@example.com', 'another@example.com'],
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +09001435 expected_upstream_ref='origin/master',
Aaron Gablefd238082017-06-07 13:42:34 -07001436 cc=['more@example.com', 'people@example.com'],
Edward Lemur687ca902018-12-05 02:30:30 +00001437 tbr='reviewer@example.com',
Edward Lemur1b52d872019-05-09 21:12:12 +00001438 labels={'Code-Review': 2},
1439 change_id='123456789',
1440 original_title='Initial upload')
tandriia60502f2016-06-20 02:01:53 -07001441
1442 def test_gerrit_upload_squash_first_is_default(self):
tandriia60502f2016-06-20 02:01:53 -07001443 self._run_gerrit_upload_test(
1444 [],
Edward Lemur0db01f02019-11-12 22:01:51 +00001445 'desc ✔\nBUG=\n\nChange-Id: 123456789',
tandriia60502f2016-06-20 02:01:53 -07001446 [],
Edward Lemur1b52d872019-05-09 21:12:12 +00001447 expected_upstream_ref='origin/master',
1448 change_id='123456789',
1449 original_title='Initial upload')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001450
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001451 def test_gerrit_upload_squash_first(self):
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001452 self._run_gerrit_upload_test(
1453 ['--squash'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001454 'desc ✔\nBUG=\n\nChange-Id: 123456789',
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001455 [],
luqui@chromium.org609f3952015-05-04 22:47:04 +00001456 squash=True,
Edward Lemur1b52d872019-05-09 21:12:12 +00001457 expected_upstream_ref='origin/master',
1458 change_id='123456789',
1459 original_title='Initial upload')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001460
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001461 def test_gerrit_upload_squash_first_with_labels(self):
1462 self._run_gerrit_upload_test(
1463 ['--squash', '--cq-dry-run', '--enable-auto-submit'],
Edward Lemur0db01f02019-11-12 22:01:51 +00001464 'desc ✔\nBUG=\n\nChange-Id: 123456789',
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001465 [],
1466 squash=True,
1467 expected_upstream_ref='origin/master',
Edward Lemur1b52d872019-05-09 21:12:12 +00001468 labels={'Commit-Queue': 1, 'Auto-Submit': 1},
1469 change_id='123456789',
1470 original_title='Initial upload')
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001471
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001472 def test_gerrit_upload_squash_first_against_rev(self):
1473 custom_cl_base = 'custom_cl_base_rev_or_branch'
1474 self._run_gerrit_upload_test(
1475 ['--squash', custom_cl_base],
Edward Lemur0db01f02019-11-12 22:01:51 +00001476 'desc ✔\nBUG=\n\nChange-Id: 123456789',
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001477 [],
1478 squash=True,
1479 expected_upstream_ref='origin/master',
Edward Lemur1b52d872019-05-09 21:12:12 +00001480 custom_cl_base=custom_cl_base,
1481 change_id='123456789',
1482 original_title='Initial upload')
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001483 self.assertIn(
1484 'If you proceed with upload, more than 1 CL may be created by Gerrit',
1485 sys.stdout.getvalue())
1486
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001487 def test_gerrit_upload_squash_reupload(self):
Edward Lemur0db01f02019-11-12 22:01:51 +00001488 description = 'desc ✔\nBUG=\n\nChange-Id: 123456789'
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001489 self._run_gerrit_upload_test(
1490 ['--squash'],
1491 description,
1492 [],
1493 squash=True,
1494 expected_upstream_ref='origin/master',
Edward Lemur1b52d872019-05-09 21:12:12 +00001495 issue=123456,
1496 change_id='123456789',
1497 original_title='User input')
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001498
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001499 def test_gerrit_upload_squash_reupload_to_abandoned(self):
1500 self.mock(git_cl, 'DieWithError',
1501 lambda msg, change=None: self._mocked_call('DieWithError', msg))
Edward Lemur0db01f02019-11-12 22:01:51 +00001502 description = 'desc ✔\nBUG=\n\nChange-Id: 123456789'
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001503 with self.assertRaises(SystemExitMock):
1504 self._run_gerrit_upload_test(
1505 ['--squash'],
1506 description,
1507 [],
1508 squash=True,
1509 expected_upstream_ref='origin/master',
1510 issue=123456,
Edward Lemur1b52d872019-05-09 21:12:12 +00001511 fetched_status='ABANDONED',
1512 change_id='123456789')
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001513
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001514 def test_gerrit_upload_squash_reupload_to_not_owned(self):
1515 self.mock(git_cl.gerrit_util, 'GetAccountDetails',
1516 lambda *_, **__: {'email': 'yet-another@example.com'})
Edward Lemur0db01f02019-11-12 22:01:51 +00001517 description = 'desc ✔\nBUG=\n\nChange-Id: 123456789'
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001518 self._run_gerrit_upload_test(
1519 ['--squash'],
1520 description,
1521 [],
1522 squash=True,
1523 expected_upstream_ref='origin/master',
1524 issue=123456,
Edward Lemur1b52d872019-05-09 21:12:12 +00001525 other_cl_owner='other@example.com',
1526 change_id='123456789',
1527 original_title='User input')
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001528 self.assertIn(
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001529 'WARNING: Change 123456 is owned by other@example.com, but you '
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001530 'authenticate to Gerrit as yet-another@example.com.\n'
1531 'Uploading may fail due to lack of permissions',
1532 git_cl.sys.stdout.getvalue())
1533
rmistry@google.com2dd99862015-06-22 12:22:18 +00001534 def test_upload_branch_deps(self):
Edward Lemur79d4f992019-11-11 23:49:02 +00001535 self.mock(git_cl.sys, 'stdout', StringIO())
rmistry@google.com2dd99862015-06-22 12:22:18 +00001536 def mock_run_git(*args, **_kwargs):
1537 if args[0] == ['for-each-ref',
1538 '--format=%(refname:short) %(upstream:short)',
1539 'refs/heads']:
1540 # Create a local branch dependency tree that looks like this:
1541 # test1 -> test2 -> test3 -> test4 -> test5
1542 # -> test3.1
1543 # test6 -> test0
1544 branch_deps = [
1545 'test2 test1', # test1 -> test2
1546 'test3 test2', # test2 -> test3
1547 'test3.1 test2', # test2 -> test3.1
1548 'test4 test3', # test3 -> test4
1549 'test5 test4', # test4 -> test5
1550 'test6 test0', # test0 -> test6
1551 'test7', # test7
1552 ]
1553 return '\n'.join(branch_deps)
1554 self.mock(git_cl, 'RunGit', mock_run_git)
1555
1556 class RecordCalls:
1557 times_called = 0
1558 record_calls = RecordCalls()
1559 def mock_CMDupload(*args, **_kwargs):
1560 record_calls.times_called += 1
1561 return 0
1562 self.mock(git_cl, 'CMDupload', mock_CMDupload)
1563
1564 self.calls = [
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01001565 (('ask_for_data', 'This command will checkout all dependent branches '
1566 'and run "git cl upload". Press Enter to continue, '
1567 'or Ctrl+C to abort'), ''),
1568 ]
rmistry@google.com2dd99862015-06-22 12:22:18 +00001569
1570 class MockChangelist():
1571 def __init__(self):
1572 pass
1573 def GetBranch(self):
1574 return 'test1'
1575 def GetIssue(self):
1576 return '123'
1577 def GetPatchset(self):
1578 return '1001'
tandrii@chromium.org4c72b082016-03-31 22:26:35 +00001579 def IsGerrit(self):
1580 return False
rmistry@google.com2dd99862015-06-22 12:22:18 +00001581
1582 ret = git_cl.upload_branch_deps(MockChangelist(), [])
1583 # CMDupload should have been called 5 times because of 5 dependent branches.
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00001584 self.assertEqual(5, record_calls.times_called)
1585 self.assertEqual(0, ret)
rmistry@google.com2dd99862015-06-22 12:22:18 +00001586
tandrii@chromium.org65874e12016-03-04 12:03:02 +00001587 def test_gerrit_change_id(self):
1588 self.calls = [
1589 ((['git', 'write-tree'], ),
1590 'hashtree'),
1591 ((['git', 'rev-parse', 'HEAD~0'], ),
1592 'branch-parent'),
1593 ((['git', 'var', 'GIT_AUTHOR_IDENT'], ),
1594 'A B <a@b.org> 1456848326 +0100'),
1595 ((['git', 'var', 'GIT_COMMITTER_IDENT'], ),
1596 'C D <c@d.org> 1456858326 +0100'),
1597 ((['git', 'hash-object', '-t', 'commit', '--stdin'], ),
1598 'hashchange'),
1599 ]
1600 change_id = git_cl.GenerateGerritChangeId('line1\nline2\n')
1601 self.assertEqual(change_id, 'Ihashchange')
1602
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00001603 def test_desecription_append_footer(self):
1604 for init_desc, footer_line, expected_desc in [
1605 # Use unique desc first lines for easy test failure identification.
1606 ('foo', 'R=one', 'foo\n\nR=one'),
1607 ('foo\n\nR=one', 'BUG=', 'foo\n\nR=one\nBUG='),
1608 ('foo\n\nR=one', 'Change-Id: Ixx', 'foo\n\nR=one\n\nChange-Id: Ixx'),
1609 ('foo\n\nChange-Id: Ixx', 'R=one', 'foo\n\nR=one\n\nChange-Id: Ixx'),
1610 ('foo\n\nR=one\n\nChange-Id: Ixx', 'TBR=two',
1611 'foo\n\nR=one\nTBR=two\n\nChange-Id: Ixx'),
1612 ('foo\n\nR=one\n\nChange-Id: Ixx', 'Foo-Bar: baz',
1613 'foo\n\nR=one\n\nChange-Id: Ixx\nFoo-Bar: baz'),
1614 ('foo\n\nChange-Id: Ixx', 'Foo-Bak: baz',
1615 'foo\n\nChange-Id: Ixx\nFoo-Bak: baz'),
1616 ('foo', 'Change-Id: Ixx', 'foo\n\nChange-Id: Ixx'),
1617 ]:
1618 desc = git_cl.ChangeDescription(init_desc)
1619 desc.append_footer(footer_line)
1620 self.assertEqual(desc.description, expected_desc)
1621
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001622 def test_update_reviewers(self):
1623 data = [
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001624 ('foo', [], [],
1625 'foo'),
1626 ('foo\nR=xx', [], [],
1627 'foo\nR=xx'),
1628 ('foo\nTBR=xx', [], [],
1629 'foo\nTBR=xx'),
1630 ('foo', ['a@c'], [],
1631 'foo\n\nR=a@c'),
1632 ('foo\nR=xx', ['a@c'], [],
1633 'foo\n\nR=a@c, xx'),
1634 ('foo\nTBR=xx', ['a@c'], [],
1635 'foo\n\nR=a@c\nTBR=xx'),
1636 ('foo\nTBR=xx\nR=yy', ['a@c'], [],
1637 'foo\n\nR=a@c, yy\nTBR=xx'),
1638 ('foo\nBUG=', ['a@c'], [],
1639 'foo\nBUG=\nR=a@c'),
1640 ('foo\nR=xx\nTBR=yy\nR=bar', ['a@c'], [],
1641 'foo\n\nR=a@c, bar, xx\nTBR=yy'),
1642 ('foo', ['a@c', 'b@c'], [],
1643 'foo\n\nR=a@c, b@c'),
1644 ('foo\nBar\n\nR=\nBUG=', ['c@c'], [],
1645 'foo\nBar\n\nR=c@c\nBUG='),
1646 ('foo\nBar\n\nR=\nBUG=\nR=', ['c@c'], [],
1647 'foo\nBar\n\nR=c@c\nBUG='),
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001648 # Same as the line before, but full of whitespaces.
1649 (
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001650 'foo\nBar\n\n R = \n BUG = \n R = ', ['c@c'], [],
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001651 'foo\nBar\n\nR=c@c\n BUG =',
1652 ),
1653 # Whitespaces aren't interpreted as new lines.
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001654 ('foo BUG=allo R=joe ', ['c@c'], [],
1655 'foo BUG=allo R=joe\n\nR=c@c'),
1656 # Redundant TBRs get promoted to Rs
1657 ('foo\n\nR=a@c\nTBR=t@c', ['b@c', 'a@c'], ['a@c', 't@c'],
1658 'foo\n\nR=a@c, b@c\nTBR=t@c'),
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001659 ]
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001660 expected = [i[-1] for i in data]
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001661 actual = []
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001662 for orig, reviewers, tbrs, _expected in data:
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001663 obj = git_cl.ChangeDescription(orig)
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001664 obj.update_reviewers(reviewers, tbrs)
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001665 actual.append(obj.description)
1666 self.assertEqual(expected, actual)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001667
Nodir Turakulov23b82142017-11-16 11:04:25 -08001668 def test_get_hash_tags(self):
1669 cases = [
1670 ('', []),
1671 ('a', []),
1672 ('[a]', ['a']),
1673 ('[aa]', ['aa']),
1674 ('[a ]', ['a']),
1675 ('[a- ]', ['a']),
1676 ('[a- b]', ['a-b']),
1677 ('[a--b]', ['a-b']),
1678 ('[a', []),
1679 ('[a]x', ['a']),
1680 ('[aa]x', ['aa']),
1681 ('[a b]', ['a-b']),
1682 ('[a b]', ['a-b']),
1683 ('[a__b]', ['a-b']),
1684 ('[a] x', ['a']),
1685 ('[a][b]', ['a', 'b']),
1686 ('[a] [b]', ['a', 'b']),
1687 ('[a][b]x', ['a', 'b']),
1688 ('[a][b] x', ['a', 'b']),
1689 ('[a]\n[b]', ['a']),
1690 ('[a\nb]', []),
1691 ('[a][', ['a']),
1692 ('Revert "[a] feature"', ['a']),
1693 ('Reland "[a] feature"', ['a']),
1694 ('Revert: [a] feature', ['a']),
1695 ('Reland: [a] feature', ['a']),
1696 ('Revert "Reland: [a] feature"', ['a']),
1697 ('Foo: feature', ['foo']),
1698 ('Foo Bar: feature', ['foo-bar']),
Anthony Polito02b5af32019-12-02 19:49:47 +00001699 ('Change Foo::Bar', []),
1700 ('Foo: Change Foo::Bar', ['foo']),
Nodir Turakulov23b82142017-11-16 11:04:25 -08001701 ('Revert "Foo bar: feature"', ['foo-bar']),
1702 ('Reland "Foo bar: feature"', ['foo-bar']),
1703 ]
1704 for desc, expected in cases:
1705 change_desc = git_cl.ChangeDescription(desc)
1706 actual = change_desc.get_hash_tags()
1707 self.assertEqual(
1708 actual,
1709 expected,
1710 'GetHashTags(%r) == %r, expected %r' % (desc, actual, expected))
1711
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001712 self.assertEqual(None, git_cl.GetTargetRef('origin', None, 'master'))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001713 self.assertEqual(None, git_cl.GetTargetRef(None,
1714 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001715 'master'))
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001716
wittman@chromium.org455dc922015-01-26 20:15:50 +00001717 # Check default target refs for branches.
1718 self.assertEqual('refs/heads/master',
1719 git_cl.GetTargetRef('origin', 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001720 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001721 self.assertEqual('refs/heads/master',
1722 git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkgr',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001723 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001724 self.assertEqual('refs/heads/master',
1725 git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkcr',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001726 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001727 self.assertEqual('refs/branch-heads/123',
1728 git_cl.GetTargetRef('origin',
1729 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001730 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001731 self.assertEqual('refs/diff/test',
1732 git_cl.GetTargetRef('origin',
1733 'refs/remotes/origin/refs/diff/test',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001734 None))
rmistry@google.comc68112d2015-03-03 12:48:06 +00001735 self.assertEqual('refs/heads/chrome/m42',
1736 git_cl.GetTargetRef('origin',
1737 'refs/remotes/origin/chrome/m42',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001738 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001739
1740 # Check target refs for user-specified target branch.
1741 for branch in ('branch-heads/123', 'remotes/branch-heads/123',
1742 'refs/remotes/branch-heads/123'):
1743 self.assertEqual('refs/branch-heads/123',
1744 git_cl.GetTargetRef('origin',
1745 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001746 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001747 for branch in ('origin/master', 'remotes/origin/master',
1748 'refs/remotes/origin/master'):
1749 self.assertEqual('refs/heads/master',
1750 git_cl.GetTargetRef('origin',
1751 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001752 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001753 for branch in ('master', 'heads/master', 'refs/heads/master'):
1754 self.assertEqual('refs/heads/master',
1755 git_cl.GetTargetRef('origin',
1756 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001757 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001758
wychen@chromium.orga872e752015-04-28 23:42:18 +00001759 def test_patch_when_dirty(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001760 # Patch when local tree is dirty.
wychen@chromium.orga872e752015-04-28 23:42:18 +00001761 self.mock(git_common, 'is_dirty_git_tree', lambda x: True)
1762 self.assertNotEqual(git_cl.main(['patch', '123456']), 0)
1763
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001764 @staticmethod
1765 def _get_gerrit_codereview_server_calls(branch, value=None,
1766 git_short_host='host',
Aaron Gable697a91b2018-01-19 15:20:15 -08001767 detect_branch=True,
1768 detect_server=True):
Edward Lemur125d60a2019-09-13 18:25:41 +00001769 """Returns calls executed by Changelist.GetCodereviewServer.
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001770
1771 If value is given, branch.<BRANCH>.gerritcodereview is already set.
1772 """
1773 calls = []
1774 if detect_branch:
1775 calls.append(((['git', 'symbolic-ref', 'HEAD'],), branch))
Aaron Gable697a91b2018-01-19 15:20:15 -08001776 if detect_server:
1777 calls.append(((['git', 'config', 'branch.' + branch + '.gerritserver'],),
1778 CERR1 if value is None else value))
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001779 if value is None:
1780 calls += [
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001781 ((['git', 'config', 'branch.' + branch + '.merge'],),
1782 'refs/heads' + branch),
1783 ((['git', 'config', 'branch.' + branch + '.remote'],),
1784 'origin'),
1785 ((['git', 'config', 'remote.origin.url'],),
1786 'https://%s.googlesource.com/my/repo' % git_short_host),
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001787 ]
1788 return calls
1789
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001790 def _patch_common(self, force_codereview=False,
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001791 new_branch=False, git_short_host='host',
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001792 detect_gerrit_server=False,
1793 actual_codereview=None,
1794 codereview_in_url=False):
Edward Lemur79d4f992019-11-11 23:49:02 +00001795 self.mock(git_cl.sys, 'stdout', StringIO())
wychen@chromium.orga872e752015-04-28 23:42:18 +00001796 self.mock(git_cl, 'IsGitVersionAtLeast', lambda *args: True)
1797
tandriidf09a462016-08-18 16:23:55 -07001798 if new_branch:
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001799 self.calls = [((['git', 'new-branch', 'master'],), '')]
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001800
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001801 if codereview_in_url and actual_codereview == 'rietveld':
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001802 self.calls += [
1803 ((['git', 'rev-parse', '--show-cdup'],), ''),
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001804 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001805 ]
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001806
1807 if not force_codereview and not codereview_in_url:
1808 # These calls detect codereview to use.
1809 self.calls += [
1810 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001811 ]
1812 if detect_gerrit_server:
1813 self.calls += self._get_gerrit_codereview_server_calls(
1814 'master', git_short_host=git_short_host,
1815 detect_branch=not new_branch and force_codereview)
1816 actual_codereview = 'gerrit'
1817
1818 if actual_codereview == 'gerrit':
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001819 self.calls += [
1820 (('GetChangeDetail', git_short_host + '-review.googlesource.com',
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001821 'my%2Frepo~123456', ['ALL_REVISIONS', 'CURRENT_COMMIT']),
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001822 {
1823 'current_revision': '7777777777',
1824 'revisions': {
1825 '1111111111': {
1826 '_number': 1,
1827 'fetch': {'http': {
1828 'url': 'https://%s.googlesource.com/my/repo' % git_short_host,
1829 'ref': 'refs/changes/56/123456/1',
1830 }},
1831 },
1832 '7777777777': {
1833 '_number': 7,
1834 'fetch': {'http': {
1835 'url': 'https://%s.googlesource.com/my/repo' % git_short_host,
1836 'ref': 'refs/changes/56/123456/7',
1837 }},
1838 },
1839 },
1840 }),
1841 ]
wychen@chromium.orga872e752015-04-28 23:42:18 +00001842
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001843 def test_patch_gerrit_default(self):
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001844 self._patch_common(git_short_host='chromium', detect_gerrit_server=True)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001845 self.calls += [
1846 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
1847 'refs/changes/56/123456/7'],), ''),
Aaron Gable62619a32017-06-16 08:22:09 -07001848 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001849 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
Aaron Gable697a91b2018-01-19 15:20:15 -08001850 ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001851 ((['git', 'config', 'branch.master.gerritserver',
1852 'https://chromium-review.googlesource.com'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001853 ((['git', 'config', 'branch.master.gerritpatchset', '7'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001854 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1855 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1856 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001857 ]
1858 self.assertEqual(git_cl.main(['patch', '123456']), 0)
1859
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001860 def test_patch_gerrit_new_branch(self):
1861 self._patch_common(
1862 git_short_host='chromium', detect_gerrit_server=True, new_branch=True)
1863 self.calls += [
1864 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
1865 'refs/changes/56/123456/7'],), ''),
1866 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
1867 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
1868 ''),
1869 ((['git', 'config', 'branch.master.gerritserver',
1870 'https://chromium-review.googlesource.com'],), ''),
1871 ((['git', 'config', 'branch.master.gerritpatchset', '7'],), ''),
1872 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1873 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1874 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
1875 ]
1876 self.assertEqual(git_cl.main(['patch', '-b', 'master', '123456']), 0)
1877
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001878 def test_patch_gerrit_force(self):
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001879 self._patch_common(
1880 force_codereview=True, git_short_host='host', detect_gerrit_server=True)
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001881 self.calls += [
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001882 ((['git', 'fetch', 'https://host.googlesource.com/my/repo',
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001883 'refs/changes/56/123456/7'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001884 ((['git', 'reset', '--hard', 'FETCH_HEAD'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001885 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
tandrii5d48c322016-08-18 16:19:37 -07001886 ''),
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001887 ((['git', 'config', 'branch.master.gerritserver',
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001888 'https://host-review.googlesource.com'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001889 ((['git', 'config', 'branch.master.gerritpatchset', '7'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001890 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1891 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1892 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001893 ]
Aaron Gable62619a32017-06-16 08:22:09 -07001894 self.assertEqual(git_cl.main(['patch', '--gerrit', '123456', '--force']), 0)
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001895
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001896 def test_patch_gerrit_guess_by_url(self):
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001897 self.calls += self._get_gerrit_codereview_server_calls(
1898 'master', git_short_host='else', detect_server=False)
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001899 self._patch_common(
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001900 actual_codereview='gerrit', git_short_host='else',
1901 codereview_in_url=True, detect_gerrit_server=False)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001902 self.calls += [
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001903 ((['git', 'fetch', 'https://else.googlesource.com/my/repo',
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001904 'refs/changes/56/123456/1'],), ''),
Aaron Gable62619a32017-06-16 08:22:09 -07001905 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001906 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
tandrii5d48c322016-08-18 16:19:37 -07001907 ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001908 ((['git', 'config', 'branch.master.gerritserver',
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001909 'https://else-review.googlesource.com'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001910 ((['git', 'config', 'branch.master.gerritpatchset', '1'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001911 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1912 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1913 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001914 ]
1915 self.assertEqual(git_cl.main(
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001916 ['patch', 'https://else-review.googlesource.com/#/c/123456/1']), 0)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001917
Aaron Gable697a91b2018-01-19 15:20:15 -08001918 def test_patch_gerrit_guess_by_url_with_repo(self):
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001919 self.calls += self._get_gerrit_codereview_server_calls(
1920 'master', git_short_host='else', detect_server=False)
Aaron Gable697a91b2018-01-19 15:20:15 -08001921 self._patch_common(
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001922 actual_codereview='gerrit', git_short_host='else',
1923 codereview_in_url=True, detect_gerrit_server=False)
Aaron Gable697a91b2018-01-19 15:20:15 -08001924 self.calls += [
1925 ((['git', 'fetch', 'https://else.googlesource.com/my/repo',
1926 'refs/changes/56/123456/1'],), ''),
1927 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
1928 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
1929 ''),
1930 ((['git', 'config', 'branch.master.gerritserver',
1931 'https://else-review.googlesource.com'],), ''),
1932 ((['git', 'config', 'branch.master.gerritpatchset', '1'],), ''),
1933 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1934 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1935 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
1936 ]
1937 self.assertEqual(git_cl.main(
1938 ['patch', 'https://else-review.googlesource.com/c/my/repo/+/123456/1']),
1939 0)
1940
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001941 def test_patch_gerrit_conflict(self):
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001942 self._patch_common(detect_gerrit_server=True, git_short_host='chromium')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001943 self.calls += [
1944 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001945 'refs/changes/56/123456/7'],), ''),
tandrii5d48c322016-08-18 16:19:37 -07001946 ((['git', 'cherry-pick', 'FETCH_HEAD'],), CERR1),
1947 ((['DieWithError', 'Command "git cherry-pick FETCH_HEAD" failed.\n'],),
1948 SystemExitMock()),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001949 ]
1950 with self.assertRaises(SystemExitMock):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001951 git_cl.main(['patch', '123456'])
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001952
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001953 def test_patch_gerrit_not_exists(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001954
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01001955 def notExists(_issue, *_, **kwargs):
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01001956 raise git_cl.gerrit_util.GerritError(404, '')
1957 self.mock(git_cl.gerrit_util, 'GetChangeDetail', notExists)
1958
tandriic2405f52016-10-10 08:13:15 -07001959 self.calls = [
1960 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001961 ((['git', 'config', 'branch.master.gerritserver'],), CERR1),
1962 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
1963 ((['git', 'config', 'branch.master.remote'],), 'origin'),
1964 ((['git', 'config', 'remote.origin.url'],),
1965 'https://chromium.googlesource.com/my/repo'),
1966 ((['DieWithError',
1967 'change 123456 at https://chromium-review.googlesource.com does not '
1968 'exist or you have no access to it'],), SystemExitMock()),
tandriic2405f52016-10-10 08:13:15 -07001969 ]
1970 with self.assertRaises(SystemExitMock):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001971 self.assertEqual(1, git_cl.main(['patch', '123456']))
tandriic2405f52016-10-10 08:13:15 -07001972
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001973 def _checkout_calls(self):
1974 return [
1975 ((['git', 'config', '--local', '--get-regexp',
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001976 'branch\\..*\\.gerritissue'], ),
1977 ('branch.ger-branch.gerritissue 123456\n'
1978 'branch.gbranch654.gerritissue 654321\n')),
1979 ]
1980
1981 def test_checkout_gerrit(self):
1982 """Tests git cl checkout <issue>."""
1983 self.calls = self._checkout_calls()
1984 self.calls += [((['git', 'checkout', 'ger-branch'], ), '')]
1985 self.assertEqual(0, git_cl.main(['checkout', '123456']))
1986
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001987 def test_checkout_not_found(self):
1988 """Tests git cl checkout <issue>."""
Edward Lemur79d4f992019-11-11 23:49:02 +00001989 self.mock(git_cl.sys, 'stdout', StringIO())
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001990 self.calls = self._checkout_calls()
1991 self.assertEqual(1, git_cl.main(['checkout', '99999']))
1992
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001993 def test_checkout_no_branch_issues(self):
1994 """Tests git cl checkout <issue>."""
Edward Lemur79d4f992019-11-11 23:49:02 +00001995 self.mock(git_cl.sys, 'stdout', StringIO())
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001996 self.calls = [
1997 ((['git', 'config', '--local', '--get-regexp',
tandrii5d48c322016-08-18 16:19:37 -07001998 'branch\\..*\\.gerritissue'], ), CERR1),
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001999 ]
2000 self.assertEqual(1, git_cl.main(['checkout', '99999']))
2001
tandrii@chromium.org28253532016-04-14 13:46:56 +00002002 def _test_gerrit_ensure_authenticated_common(self, auth,
2003 skip_auth_check=False):
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002004 self.mock(git_cl.gerrit_util, 'CookiesAuthenticator',
2005 CookiesAuthenticatorMockFactory(hosts_with_creds=auth))
2006 self.mock(git_cl, 'DieWithError',
Christopher Lamf732cd52017-01-24 12:40:11 +11002007 lambda msg, change=None: self._mocked_call(['DieWithError', msg]))
tandrii@chromium.org28253532016-04-14 13:46:56 +00002008 self.calls = self._gerrit_ensure_auth_calls(skip_auth_check=skip_auth_check)
Edward Lemurf38bc172019-09-03 21:02:13 +00002009 cl = git_cl.Changelist()
tandrii@chromium.org28253532016-04-14 13:46:56 +00002010 cl.branch = 'master'
2011 cl.branchref = 'refs/heads/master'
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002012 return cl
2013
2014 def test_gerrit_ensure_authenticated_missing(self):
2015 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01002016 'chromium.googlesource.com': ('git-is.ok', '', 'but gerrit is missing'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002017 })
2018 self.calls.append(
2019 ((['DieWithError',
2020 'Credentials for the following hosts are required:\n'
2021 ' chromium-review.googlesource.com\n'
2022 'These are read from ~/.gitcookies (or legacy ~/.netrc)\n'
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01002023 'You can (re)generate your credentials by visiting '
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002024 'https://chromium-review.googlesource.com/new-password'],), ''),)
2025 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2026
2027 def test_gerrit_ensure_authenticated_conflict(self):
Edward Lemur79d4f992019-11-11 23:49:02 +00002028 self.mock(git_cl.sys, 'stdout', StringIO())
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002029 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01002030 'chromium.googlesource.com':
2031 ('git-one.example.com', None, 'secret1'),
2032 'chromium-review.googlesource.com':
2033 ('git-other.example.com', None, 'secret2'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002034 })
2035 self.calls.append(
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002036 (('ask_for_data', 'If you know what you are doing '
2037 'press Enter to continue, or Ctrl+C to abort'), ''))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002038 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2039
2040 def test_gerrit_ensure_authenticated_ok(self):
2041 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01002042 'chromium.googlesource.com':
2043 ('git-same.example.com', None, 'secret'),
2044 'chromium-review.googlesource.com':
2045 ('git-same.example.com', None, 'secret'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002046 })
2047 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2048
tandrii@chromium.org28253532016-04-14 13:46:56 +00002049 def test_gerrit_ensure_authenticated_skipped(self):
2050 cl = self._test_gerrit_ensure_authenticated_common(
2051 auth={}, skip_auth_check=True)
2052 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2053
Eric Boren2fb63102018-10-05 13:05:03 +00002054 def test_gerrit_ensure_authenticated_bearer_token(self):
2055 cl = self._test_gerrit_ensure_authenticated_common(auth={
2056 'chromium.googlesource.com':
2057 ('', None, 'secret'),
2058 'chromium-review.googlesource.com':
2059 ('', None, 'secret'),
2060 })
2061 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2062 header = gerrit_util.CookiesAuthenticator().get_auth_header(
2063 'chromium.googlesource.com')
2064 self.assertTrue('Bearer' in header)
2065
Daniel Chengcf6269b2019-05-18 01:02:12 +00002066 def test_gerrit_ensure_authenticated_non_https(self):
2067 self.calls = [
2068 ((['git', 'config', '--bool',
2069 'gerrit.skip-ensure-authenticated'],), CERR1),
2070 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
2071 ((['git', 'config', 'branch.master.remote'],), 'origin'),
2072 ((['git', 'config', 'remote.origin.url'],), 'custom-scheme://repo'),
2073 ]
2074 self.mock(git_cl.gerrit_util, 'CookiesAuthenticator',
2075 CookiesAuthenticatorMockFactory(hosts_with_creds={}))
Edward Lemurf38bc172019-09-03 21:02:13 +00002076 cl = git_cl.Changelist()
Daniel Chengcf6269b2019-05-18 01:02:12 +00002077 cl.branch = 'master'
2078 cl.branchref = 'refs/heads/master'
2079 cl.lookedup_issue = True
2080 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2081
Andrii Shyshkalov828701b2016-12-09 10:46:47 +01002082 def _cmd_set_commit_gerrit_common(self, vote, notify=None):
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002083 self.mock(git_cl.gerrit_util, 'SetReview',
Andrii Shyshkalov828701b2016-12-09 10:46:47 +01002084 lambda h, i, labels, notify=None:
2085 self._mocked_call(['SetReview', h, i, labels, notify]))
2086
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002087 self.calls = [
2088 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii33a46ff2016-08-23 05:53:40 -07002089 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002090 ((['git', 'config', 'branch.feature.gerritserver'],),
2091 'https://chromium-review.googlesource.com'),
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002092 ((['git', 'config', 'branch.feature.merge'],), 'refs/heads/master'),
2093 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
2094 ((['git', 'config', 'remote.origin.url'],),
2095 'https://chromium.googlesource.com/infra/infra.git'),
2096 ((['SetReview', 'chromium-review.googlesource.com',
2097 'infra%2Finfra~123',
Andrii Shyshkalov828701b2016-12-09 10:46:47 +01002098 {'Commit-Queue': vote}, notify],), ''),
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002099 ]
tandriid9e5ce52016-07-13 02:32:59 -07002100
2101 def test_cmd_set_commit_gerrit_clear(self):
2102 self._cmd_set_commit_gerrit_common(0)
2103 self.assertEqual(0, git_cl.main(['set-commit', '-c']))
2104
2105 def test_cmd_set_commit_gerrit_dry(self):
Aaron Gable75e78722017-06-09 10:40:16 -07002106 self._cmd_set_commit_gerrit_common(1, notify=False)
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002107 self.assertEqual(0, git_cl.main(['set-commit', '-d']))
2108
tandriid9e5ce52016-07-13 02:32:59 -07002109 def test_cmd_set_commit_gerrit(self):
2110 self._cmd_set_commit_gerrit_common(2)
2111 self.assertEqual(0, git_cl.main(['set-commit']))
2112
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002113 def test_description_display(self):
Edward Lemur79d4f992019-11-11 23:49:02 +00002114 out = StringIO()
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002115 self.mock(git_cl.sys, 'stdout', out)
2116
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002117 self.mock(git_cl, 'Changelist', ChangelistMock)
2118 ChangelistMock.desc = 'foo\n'
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002119
2120 self.assertEqual(0, git_cl.main(['description', '-d']))
2121 self.assertEqual('foo\n', out.getvalue())
2122
iannucci3c972b92016-08-17 13:24:10 -07002123 def test_StatusFieldOverrideIssueMissingArgs(self):
Edward Lemur79d4f992019-11-11 23:49:02 +00002124 out = StringIO()
iannucci3c972b92016-08-17 13:24:10 -07002125 self.mock(git_cl.sys, 'stderr', out)
2126
2127 try:
2128 self.assertEqual(git_cl.main(['status', '--issue', '1']), 0)
2129 except SystemExit as ex:
2130 self.assertEqual(ex.code, 2)
Edward Lemurf38bc172019-09-03 21:02:13 +00002131 self.assertRegexpMatches(out.getvalue(), r'--field must be specified')
iannucci3c972b92016-08-17 13:24:10 -07002132
Edward Lemur79d4f992019-11-11 23:49:02 +00002133 out = StringIO()
iannucci3c972b92016-08-17 13:24:10 -07002134 self.mock(git_cl.sys, 'stderr', out)
2135
2136 try:
Andrii Shyshkalovfeec80e2018-10-16 01:00:47 +00002137 self.assertEqual(git_cl.main(['status', '--issue', '1', '--gerrit']), 0)
iannucci3c972b92016-08-17 13:24:10 -07002138 except SystemExit as ex:
2139 self.assertEqual(ex.code, 2)
iannuccie53c9352016-08-17 14:40:40 -07002140 self.assertRegexpMatches(out.getvalue(), r'--field must be specified')
iannucci3c972b92016-08-17 13:24:10 -07002141
2142 def test_StatusFieldOverrideIssue(self):
Edward Lemur79d4f992019-11-11 23:49:02 +00002143 out = StringIO()
iannucci3c972b92016-08-17 13:24:10 -07002144 self.mock(git_cl.sys, 'stdout', out)
2145
2146 def assertIssue(cl_self, *_args):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002147 self.assertEqual(cl_self.issue, 1)
iannucci3c972b92016-08-17 13:24:10 -07002148 return 'foobar'
2149
2150 self.mock(git_cl.Changelist, 'GetDescription', assertIssue)
iannuccie53c9352016-08-17 14:40:40 -07002151 self.assertEqual(
Andrii Shyshkalovfeec80e2018-10-16 01:00:47 +00002152 git_cl.main(['status', '--issue', '1', '--gerrit', '--field', 'desc']),
iannuccie53c9352016-08-17 14:40:40 -07002153 0)
iannucci3c972b92016-08-17 13:24:10 -07002154 self.assertEqual(out.getvalue(), 'foobar\n')
2155
iannuccie53c9352016-08-17 14:40:40 -07002156 def test_SetCloseOverrideIssue(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002157
iannuccie53c9352016-08-17 14:40:40 -07002158 def assertIssue(cl_self, *_args):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002159 self.assertEqual(cl_self.issue, 1)
iannuccie53c9352016-08-17 14:40:40 -07002160 return 'foobar'
2161
2162 self.mock(git_cl.Changelist, 'GetDescription', assertIssue)
2163 self.mock(git_cl.Changelist, 'CloseIssue', lambda *_: None)
iannuccie53c9352016-08-17 14:40:40 -07002164 self.assertEqual(
Andrii Shyshkalovfeec80e2018-10-16 01:00:47 +00002165 git_cl.main(['set-close', '--issue', '1', '--gerrit']), 0)
iannuccie53c9352016-08-17 14:40:40 -07002166
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00002167 def test_description(self):
Edward Lemur79d4f992019-11-11 23:49:02 +00002168 out = StringIO()
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002169 self.mock(git_cl.sys, 'stdout', out)
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01002170 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002171 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
2172 ((['git', 'config', 'branch.feature.merge'],), 'feature'),
2173 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
2174 ((['git', 'config', 'remote.origin.url'],),
2175 'https://chromium.googlesource.com/my/repo'),
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00002176 (('GetChangeDetail', 'chromium-review.googlesource.com',
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002177 'my%2Frepo~123123', ['CURRENT_REVISION', 'CURRENT_COMMIT']),
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01002178 {
2179 'current_revision': 'sha1',
2180 'revisions': {'sha1': {
2181 'commit': {'message': 'foobar'},
2182 }},
2183 }),
2184 ]
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002185 self.assertEqual(0, git_cl.main([
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00002186 'description',
2187 'https://chromium-review.googlesource.com/c/my/repo/+/123123',
2188 '-d']))
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002189 self.assertEqual('foobar\n', out.getvalue())
2190
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002191 def test_description_set_raw(self):
Edward Lemur79d4f992019-11-11 23:49:02 +00002192 out = StringIO()
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002193 self.mock(git_cl.sys, 'stdout', out)
2194
2195 self.mock(git_cl, 'Changelist', ChangelistMock)
Edward Lemur79d4f992019-11-11 23:49:02 +00002196 self.mock(git_cl.sys, 'stdin', StringIO('hihi'))
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002197
2198 self.assertEqual(0, git_cl.main(['description', '-n', 'hihi']))
2199 self.assertEqual('hihi', ChangelistMock.desc)
2200
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002201 def test_description_appends_bug_line(self):
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002202 current_desc = 'Some.\n\nChange-Id: xxx'
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002203
2204 def RunEditor(desc, _, **kwargs):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002205 self.assertEqual(
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002206 '# Enter a description of the change.\n'
2207 '# This will be displayed on the codereview site.\n'
2208 '# The first line will also be used as the subject of the review.\n'
2209 '#--------------------This line is 72 characters long'
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002210 '--------------------\n'
Aaron Gable3a16ed12017-03-23 10:51:55 -07002211 'Some.\n\nChange-Id: xxx\nBug: ',
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002212 desc)
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002213 # Simulate user changing something.
Aaron Gable3a16ed12017-03-23 10:51:55 -07002214 return 'Some.\n\nChange-Id: xxx\nBug: 123'
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002215
dsansomee2d6fd92016-09-08 00:10:47 -07002216 def UpdateDescriptionRemote(_, desc, force=False):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002217 self.assertEqual(desc, 'Some.\n\nChange-Id: xxx\nBug: 123')
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002218
Edward Lemur79d4f992019-11-11 23:49:02 +00002219 self.mock(git_cl.sys, 'stdout', StringIO())
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002220 self.mock(git_cl.Changelist, 'GetDescription',
2221 lambda *args: current_desc)
Edward Lemur125d60a2019-09-13 18:25:41 +00002222 self.mock(git_cl.Changelist, 'UpdateDescriptionRemote',
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002223 UpdateDescriptionRemote)
2224 self.mock(git_cl.gclient_utils, 'RunEditor', RunEditor)
2225
2226 self.calls = [
2227 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii33a46ff2016-08-23 05:53:40 -07002228 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
tandrii5d48c322016-08-18 16:19:37 -07002229 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
2230 ((['git', 'config', 'rietveld.bug-prefix'],), CERR1),
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002231 ((['git', 'config', 'core.editor'],), 'vi'),
2232 ]
2233 self.assertEqual(0, git_cl.main(['description', '--gerrit']))
2234
Dan Beamd8b04ca2019-10-10 21:23:26 +00002235 def test_description_does_not_append_bug_line_if_fixed_is_present(self):
2236 current_desc = 'Some.\n\nFixed: 123\nChange-Id: xxx'
2237
2238 def RunEditor(desc, _, **kwargs):
Raphael Kubo da Costae9342a72019-10-14 17:49:39 +00002239 self.assertEqual(
Dan Beamd8b04ca2019-10-10 21:23:26 +00002240 '# Enter a description of the change.\n'
2241 '# This will be displayed on the codereview site.\n'
2242 '# The first line will also be used as the subject of the review.\n'
2243 '#--------------------This line is 72 characters long'
2244 '--------------------\n'
2245 'Some.\n\nFixed: 123\nChange-Id: xxx',
2246 desc)
2247 return desc
2248
Edward Lemur79d4f992019-11-11 23:49:02 +00002249 self.mock(git_cl.sys, 'stdout', StringIO())
Dan Beamd8b04ca2019-10-10 21:23:26 +00002250 self.mock(git_cl.Changelist, 'GetDescription',
2251 lambda *args: current_desc)
2252 self.mock(git_cl.gclient_utils, 'RunEditor', RunEditor)
2253
2254 self.calls = [
2255 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
2256 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
2257 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
2258 ((['git', 'config', 'rietveld.bug-prefix'],), CERR1),
2259 ((['git', 'config', 'core.editor'],), 'vi'),
2260 ]
2261 self.assertEqual(0, git_cl.main(['description', '--gerrit']))
2262
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002263 def test_description_set_stdin(self):
Edward Lemur79d4f992019-11-11 23:49:02 +00002264 out = StringIO()
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002265 self.mock(git_cl.sys, 'stdout', out)
2266
2267 self.mock(git_cl, 'Changelist', ChangelistMock)
Edward Lemur79d4f992019-11-11 23:49:02 +00002268 self.mock(git_cl.sys, 'stdin', StringIO('hi \r\n\t there\n\nman'))
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002269
2270 self.assertEqual(0, git_cl.main(['description', '-n', '-']))
2271 self.assertEqual('hi\n\t there\n\nman', ChangelistMock.desc)
2272
kmarshall3bff56b2016-06-06 18:31:47 -07002273 def test_archive(self):
Edward Lemur79d4f992019-11-11 23:49:02 +00002274 self.mock(git_cl.sys, 'stdout', StringIO())
tandrii1c67da62016-06-10 07:35:53 -07002275
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002276 self.calls = [
2277 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
Edward Lemurf38bc172019-09-03 21:02:13 +00002278 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002279 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002280 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2281 ((['git', 'tag', 'git-cl-archived-456-foo', 'foo'],), ''),
Edward Lemurf38bc172019-09-03 21:02:13 +00002282 ((['git', 'branch', '-D', 'foo'],), '')
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002283 ]
kmarshall3bff56b2016-06-06 18:31:47 -07002284
kmarshall3bff56b2016-06-06 18:31:47 -07002285 self.mock(git_cl, 'get_cl_statuses',
2286 lambda branches, fine_grained, max_processes:
kmarshall9249e012016-08-23 12:02:16 -07002287 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2288 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
2289 (MockChangelistWithBranchAndIssue('bar', 789), 'open')])
kmarshall3bff56b2016-06-06 18:31:47 -07002290
2291 self.assertEqual(0, git_cl.main(['archive', '-f']))
2292
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002293 def test_archive_tag_collision(self):
2294 self.mock(git_cl.sys, 'stdout', StringIO())
2295
2296 self.calls = [
2297 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2298 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
2299 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],),
2300 'refs/tags/git-cl-archived-456-foo'),
2301 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2302 ((['git', 'tag', 'git-cl-archived-456-foo-2', 'foo'],), ''),
2303 ((['git', 'branch', '-D', 'foo'],), '')
2304 ]
2305
2306 self.mock(git_cl, 'get_cl_statuses',
2307 lambda branches, fine_grained, max_processes:
2308 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2309 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
2310 (MockChangelistWithBranchAndIssue('bar', 789), 'open')])
2311
2312 self.assertEqual(0, git_cl.main(['archive', '-f']))
2313
kmarshall3bff56b2016-06-06 18:31:47 -07002314 def test_archive_current_branch_fails(self):
Edward Lemur79d4f992019-11-11 23:49:02 +00002315 self.mock(git_cl.sys, 'stdout', StringIO())
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002316 self.calls = [
2317 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2318 'refs/heads/master'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002319 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002320 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2321 ]
kmarshall3bff56b2016-06-06 18:31:47 -07002322
kmarshall9249e012016-08-23 12:02:16 -07002323 self.mock(git_cl, 'get_cl_statuses',
2324 lambda branches, fine_grained, max_processes:
2325 [(MockChangelistWithBranchAndIssue('master', 1), 'closed')])
2326
2327 self.assertEqual(1, git_cl.main(['archive', '-f']))
2328
2329 def test_archive_dry_run(self):
Edward Lemur79d4f992019-11-11 23:49:02 +00002330 self.mock(git_cl.sys, 'stdout', StringIO())
kmarshall9249e012016-08-23 12:02:16 -07002331
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002332 self.calls = [
2333 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2334 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002335 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002336 ((['git', 'symbolic-ref', 'HEAD'],), 'master')
2337 ]
kmarshall3bff56b2016-06-06 18:31:47 -07002338
2339 self.mock(git_cl, 'get_cl_statuses',
2340 lambda branches, fine_grained, max_processes:
kmarshall9249e012016-08-23 12:02:16 -07002341 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2342 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
2343 (MockChangelistWithBranchAndIssue('bar', 789), 'open')])
kmarshall3bff56b2016-06-06 18:31:47 -07002344
kmarshall9249e012016-08-23 12:02:16 -07002345 self.assertEqual(0, git_cl.main(['archive', '-f', '--dry-run']))
2346
2347 def test_archive_no_tags(self):
Edward Lemur79d4f992019-11-11 23:49:02 +00002348 self.mock(git_cl.sys, 'stdout', StringIO())
kmarshall9249e012016-08-23 12:02:16 -07002349
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002350 self.calls = [
2351 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2352 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002353 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002354 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2355 ((['git', 'branch', '-D', 'foo'],), '')
2356 ]
kmarshall9249e012016-08-23 12:02:16 -07002357
2358 self.mock(git_cl, 'get_cl_statuses',
2359 lambda branches, fine_grained, max_processes:
2360 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2361 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
2362 (MockChangelistWithBranchAndIssue('bar', 789), 'open')])
2363
2364 self.assertEqual(0, git_cl.main(['archive', '-f', '--notags']))
kmarshall3bff56b2016-06-06 18:31:47 -07002365
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00002366 def test_archive_tag_cleanup_on_branch_deletion_error(self):
2367 self.mock(git_cl.sys, 'stdout', StringIO())
2368
2369 self.calls = [
2370 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2371 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
2372 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
2373 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2374 ((['git', 'tag', 'git-cl-archived-456-foo', 'foo'],),
2375 'refs/tags/git-cl-archived-456-foo'),
2376 ((['git', 'branch', '-D', 'foo'],), CERR1),
2377 ((['git', 'tag', '-d', 'git-cl-archived-456-foo'],),
2378 'refs/tags/git-cl-archived-456-foo'),
2379 ]
2380
2381 self.mock(git_cl, 'get_cl_statuses',
2382 lambda branches, fine_grained, max_processes:
2383 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2384 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
2385 (MockChangelistWithBranchAndIssue('bar', 789), 'open')])
2386
2387 self.assertEqual(0, git_cl.main(['archive', '-f']))
2388
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002389 def test_cmd_issue_erase_existing(self):
Edward Lemur79d4f992019-11-11 23:49:02 +00002390 out = StringIO()
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002391 self.mock(git_cl.sys, 'stdout', out)
2392 self.calls = [
2393 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002394 # Let this command raise exception (retcode=1) - it should be ignored.
2395 ((['git', 'config', '--unset', 'branch.feature.last-upload-hash'],),
tandrii5d48c322016-08-18 16:19:37 -07002396 CERR1),
2397 ((['git', 'config', '--unset', 'branch.feature.gerritissue'],), ''),
2398 ((['git', 'config', '--unset', 'branch.feature.gerritpatchset'],), ''),
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002399 ((['git', 'config', '--unset', 'branch.feature.gerritserver'],), ''),
2400 ((['git', 'config', '--unset', 'branch.feature.gerritsquashhash'],),
2401 ''),
Aaron Gableca01e2c2017-07-19 11:16:02 -07002402 ((['git', 'log', '-1', '--format=%B'],), 'This is a description'),
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002403 ]
2404 self.assertEqual(0, git_cl.main(['issue', '0']))
2405
Aaron Gable400e9892017-07-12 15:31:21 -07002406 def test_cmd_issue_erase_existing_with_change_id(self):
Edward Lemur79d4f992019-11-11 23:49:02 +00002407 out = StringIO()
Aaron Gable400e9892017-07-12 15:31:21 -07002408 self.mock(git_cl.sys, 'stdout', out)
2409 self.mock(git_cl.Changelist, 'GetDescription',
2410 lambda _: 'This is a description\n\nChange-Id: Ideadbeef')
2411 self.calls = [
2412 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
Aaron Gable400e9892017-07-12 15:31:21 -07002413 # Let this command raise exception (retcode=1) - it should be ignored.
2414 ((['git', 'config', '--unset', 'branch.feature.last-upload-hash'],),
2415 CERR1),
2416 ((['git', 'config', '--unset', 'branch.feature.gerritissue'],), ''),
2417 ((['git', 'config', '--unset', 'branch.feature.gerritpatchset'],), ''),
2418 ((['git', 'config', '--unset', 'branch.feature.gerritserver'],), ''),
2419 ((['git', 'config', '--unset', 'branch.feature.gerritsquashhash'],),
2420 ''),
Aaron Gableca01e2c2017-07-19 11:16:02 -07002421 ((['git', 'log', '-1', '--format=%B'],),
2422 'This is a description\n\nChange-Id: Ideadbeef'),
2423 ((['git', 'commit', '--amend', '-m', 'This is a description\n'],), ''),
Aaron Gable400e9892017-07-12 15:31:21 -07002424 ]
2425 self.assertEqual(0, git_cl.main(['issue', '0']))
2426
phajdan.jre328cf92016-08-22 04:12:17 -07002427 def test_cmd_issue_json(self):
Edward Lemur79d4f992019-11-11 23:49:02 +00002428 out = StringIO()
phajdan.jre328cf92016-08-22 04:12:17 -07002429 self.mock(git_cl.sys, 'stdout', out)
2430 self.calls = [
2431 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
Andrii Shyshkalova185e2e2018-11-21 00:42:55 +00002432 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
2433 ((['git', 'config', 'branch.feature.gerritserver'],),
2434 'https://chromium-review.googlesource.com'),
phajdan.jre328cf92016-08-22 04:12:17 -07002435 (('write_json', 'output.json',
Andrii Shyshkalova185e2e2018-11-21 00:42:55 +00002436 {'issue': 123,
2437 'issue_url': 'https://chromium-review.googlesource.com/123'}),
phajdan.jre328cf92016-08-22 04:12:17 -07002438 ''),
2439 ]
2440 self.assertEqual(0, git_cl.main(['issue', '--json', 'output.json']))
2441
tandrii16e0b4e2016-06-07 10:34:28 -07002442 def _common_GerritCommitMsgHookCheck(self):
Edward Lemur79d4f992019-11-11 23:49:02 +00002443 self.mock(git_cl.sys, 'stdout', StringIO())
tandrii16e0b4e2016-06-07 10:34:28 -07002444 self.mock(git_cl.os.path, 'abspath',
2445 lambda path: self._mocked_call(['abspath', path]))
2446 self.mock(git_cl.os.path, 'exists',
2447 lambda path: self._mocked_call(['exists', path]))
2448 self.mock(git_cl.gclient_utils, 'FileRead',
2449 lambda path: self._mocked_call(['FileRead', path]))
2450 self.mock(git_cl.gclient_utils, 'rm_file_or_tree',
2451 lambda path: self._mocked_call(['rm_file_or_tree', path]))
2452 self.calls = [
2453 ((['git', 'rev-parse', '--show-cdup'],), '../'),
2454 ((['abspath', '../'],), '/abs/git_repo_root'),
2455 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002456 return git_cl.Changelist(issue=123)
tandrii16e0b4e2016-06-07 10:34:28 -07002457
2458 def test_GerritCommitMsgHookCheck_custom_hook(self):
2459 cl = self._common_GerritCommitMsgHookCheck()
2460 self.calls += [
2461 ((['exists', '/abs/git_repo_root/.git/hooks/commit-msg'],), True),
2462 ((['FileRead', '/abs/git_repo_root/.git/hooks/commit-msg'],),
2463 '#!/bin/sh\necho "custom hook"')
2464 ]
Edward Lemur125d60a2019-09-13 18:25:41 +00002465 cl._GerritCommitMsgHookCheck(offer_removal=True)
tandrii16e0b4e2016-06-07 10:34:28 -07002466
2467 def test_GerritCommitMsgHookCheck_not_exists(self):
2468 cl = self._common_GerritCommitMsgHookCheck()
2469 self.calls += [
2470 ((['exists', '/abs/git_repo_root/.git/hooks/commit-msg'],), False),
2471 ]
Edward Lemur125d60a2019-09-13 18:25:41 +00002472 cl._GerritCommitMsgHookCheck(offer_removal=True)
tandrii16e0b4e2016-06-07 10:34:28 -07002473
2474 def test_GerritCommitMsgHookCheck(self):
2475 cl = self._common_GerritCommitMsgHookCheck()
2476 self.calls += [
2477 ((['exists', '/abs/git_repo_root/.git/hooks/commit-msg'],), True),
2478 ((['FileRead', '/abs/git_repo_root/.git/hooks/commit-msg'],),
2479 '...\n# From Gerrit Code Review\n...\nadd_ChangeId()\n'),
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002480 (('ask_for_data', 'Do you want to remove it now? [Yes/No]: '), 'Yes'),
tandrii16e0b4e2016-06-07 10:34:28 -07002481 ((['rm_file_or_tree', '/abs/git_repo_root/.git/hooks/commit-msg'],),
2482 ''),
2483 ]
Edward Lemur125d60a2019-09-13 18:25:41 +00002484 cl._GerritCommitMsgHookCheck(offer_removal=True)
tandrii16e0b4e2016-06-07 10:34:28 -07002485
tandriic4344b52016-08-29 06:04:54 -07002486 def test_GerritCmdLand(self):
2487 self.calls += [
2488 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
2489 ((['git', 'config', 'branch.feature.gerritsquashhash'],),
2490 'deadbeaf'),
2491 ((['git', 'diff', 'deadbeaf'],), ''), # No diff.
2492 ((['git', 'config', 'branch.feature.gerritserver'],),
2493 'chromium-review.googlesource.com'),
2494 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002495 cl = git_cl.Changelist(issue=123)
Edward Lemur125d60a2019-09-13 18:25:41 +00002496 cl._GetChangeDetail = lambda *args, **kwargs: {
tandriic4344b52016-08-29 06:04:54 -07002497 'labels': {},
2498 'current_revision': 'deadbeaf',
2499 }
Edward Lemur125d60a2019-09-13 18:25:41 +00002500 cl._GetChangeCommit = lambda: {
agable32978d92016-11-01 12:55:02 -07002501 'commit': 'deadbeef',
Aaron Gable02cdbb42016-12-13 16:24:25 -08002502 'web_links': [{'name': 'gitiles',
agable32978d92016-11-01 12:55:02 -07002503 'url': 'https://git.googlesource.com/test/+/deadbeef'}],
2504 }
Edward Lemur125d60a2019-09-13 18:25:41 +00002505 cl.SubmitIssue = lambda wait_for_merge: None
Edward Lemur79d4f992019-11-11 23:49:02 +00002506 out = StringIO()
tandrii8da412c2016-09-07 16:01:07 -07002507 self.mock(sys, 'stdout', out)
Olivier Robin75ee7252018-04-13 10:02:56 +02002508 self.assertEqual(0, cl.CMDLand(force=True,
2509 bypass_hooks=True,
2510 verbose=True,
2511 parallel=False))
tandrii8da412c2016-09-07 16:01:07 -07002512 self.assertRegexpMatches(out.getvalue(), 'Issue.*123 has been submitted')
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002513 self.assertRegexpMatches(out.getvalue(), 'Landed as: .*deadbeef')
tandriic4344b52016-08-29 06:04:54 -07002514
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002515 def _mock_gerrit_changes_for_detail_cache(self):
Edward Lemur125d60a2019-09-13 18:25:41 +00002516 self.mock(git_cl.Changelist, '_GetGerritHost', lambda _: 'host')
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002517
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002518 def test_gerrit_change_detail_cache_simple(self):
2519 self._mock_gerrit_changes_for_detail_cache()
2520 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002521 (('GetChangeDetail', 'host', 'my%2Frepo~1', []), 'a'),
2522 (('GetChangeDetail', 'host', 'ab%2Frepo~2', []), 'b'),
2523 (('GetChangeDetail', 'host', 'ab%2Frepo~2', []), 'b2'),
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002524 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002525 cl1 = git_cl.Changelist(issue=1)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002526 cl1._cached_remote_url = (
2527 True, 'https://chromium.googlesource.com/a/my/repo.git/')
Edward Lemurf38bc172019-09-03 21:02:13 +00002528 cl2 = git_cl.Changelist(issue=2)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002529 cl2._cached_remote_url = (
2530 True, 'https://chromium.googlesource.com/ab/repo')
Andrii Shyshkalovb7214602018-08-22 23:20:26 +00002531 self.assertEqual(cl1._GetChangeDetail(), 'a') # Miss.
2532 self.assertEqual(cl1._GetChangeDetail(), 'a')
2533 self.assertEqual(cl2._GetChangeDetail(), 'b') # Miss.
2534 self.assertEqual(cl2._GetChangeDetail(no_cache=True), 'b2') # Miss.
2535 self.assertEqual(cl1._GetChangeDetail(), 'a')
2536 self.assertEqual(cl2._GetChangeDetail(), 'b2')
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002537
2538 def test_gerrit_change_detail_cache_options(self):
2539 self._mock_gerrit_changes_for_detail_cache()
2540 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002541 (('GetChangeDetail', 'host', 'repo~1', ['C', 'A', 'B']), 'cab'),
2542 (('GetChangeDetail', 'host', 'repo~1', ['A', 'D']), 'ad'),
2543 (('GetChangeDetail', 'host', 'repo~1', ['A']), 'a'), # no_cache=True
2544 # no longer in cache.
2545 (('GetChangeDetail', 'host', 'repo~1', ['B']), 'b'),
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002546 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002547 cl = git_cl.Changelist(issue=1)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002548 cl._cached_remote_url = (True, 'https://chromium.googlesource.com/repo/')
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002549 self.assertEqual(cl._GetChangeDetail(options=['C', 'A', 'B']), 'cab')
2550 self.assertEqual(cl._GetChangeDetail(options=['A', 'B', 'C']), 'cab')
2551 self.assertEqual(cl._GetChangeDetail(options=['B', 'A']), 'cab')
2552 self.assertEqual(cl._GetChangeDetail(options=['C']), 'cab')
2553 self.assertEqual(cl._GetChangeDetail(options=['A']), 'cab')
2554 self.assertEqual(cl._GetChangeDetail(), 'cab')
2555
2556 self.assertEqual(cl._GetChangeDetail(options=['A', 'D']), 'ad')
2557 self.assertEqual(cl._GetChangeDetail(options=['A']), 'cab')
2558 self.assertEqual(cl._GetChangeDetail(options=['D']), 'ad')
2559 self.assertEqual(cl._GetChangeDetail(), 'cab')
2560
2561 # Finally, no_cache should invalidate all caches for given change.
2562 self.assertEqual(cl._GetChangeDetail(options=['A'], no_cache=True), 'a')
2563 self.assertEqual(cl._GetChangeDetail(options=['B']), 'b')
2564
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002565 def test_gerrit_description_caching(self):
2566 def gen_detail(rev, desc):
2567 return {
2568 'current_revision': rev,
2569 'revisions': {rev: {'commit': {'message': desc}}}
2570 }
2571 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002572 (('GetChangeDetail', 'host', 'my%2Frepo~1',
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002573 ['CURRENT_REVISION', 'CURRENT_COMMIT']),
2574 gen_detail('rev1', 'desc1')),
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002575 (('GetChangeDetail', 'host', 'my%2Frepo~1',
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002576 ['CURRENT_REVISION', 'CURRENT_COMMIT']),
2577 gen_detail('rev2', 'desc2')),
2578 ]
2579
2580 self._mock_gerrit_changes_for_detail_cache()
Edward Lemurf38bc172019-09-03 21:02:13 +00002581 cl = git_cl.Changelist(issue=1)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002582 cl._cached_remote_url = (
2583 True, 'https://chromium.googlesource.com/a/my/repo.git/')
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002584 self.assertEqual(cl.GetDescription(), 'desc1')
2585 self.assertEqual(cl.GetDescription(), 'desc1') # cache hit.
2586 self.assertEqual(cl.GetDescription(force=True), 'desc2')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002587
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002588 def test_print_current_creds(self):
2589 class CookiesAuthenticatorMock(object):
2590 def __init__(self):
2591 self.gitcookies = {
2592 'host.googlesource.com': ('user', 'pass'),
2593 'host-review.googlesource.com': ('user', 'pass'),
2594 }
2595 self.netrc = self
2596 self.netrc.hosts = {
2597 'github.com': ('user2', None, 'pass2'),
2598 'host2.googlesource.com': ('user3', None, 'pass'),
2599 }
2600 self.mock(git_cl.gerrit_util, 'CookiesAuthenticator',
2601 CookiesAuthenticatorMock)
Edward Lemur79d4f992019-11-11 23:49:02 +00002602 self.mock(sys, 'stdout', StringIO())
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002603 git_cl._GitCookiesChecker().print_current_creds(include_netrc=True)
2604 self.assertEqual(list(sys.stdout.getvalue().splitlines()), [
2605 ' Host\t User\t Which file',
2606 '============================\t=====\t===========',
2607 'host-review.googlesource.com\t user\t.gitcookies',
2608 ' host.googlesource.com\t user\t.gitcookies',
2609 ' host2.googlesource.com\tuser3\t .netrc',
2610 ])
Edward Lemur79d4f992019-11-11 23:49:02 +00002611 sys.stdout.seek(0)
2612 sys.stdout.truncate(0)
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002613 git_cl._GitCookiesChecker().print_current_creds(include_netrc=False)
2614 self.assertEqual(list(sys.stdout.getvalue().splitlines()), [
2615 ' Host\tUser\t Which file',
2616 '============================\t====\t===========',
2617 'host-review.googlesource.com\tuser\t.gitcookies',
2618 ' host.googlesource.com\tuser\t.gitcookies',
2619 ])
2620
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002621 def _common_creds_check_mocks(self):
2622 def exists_mock(path):
2623 dirname = os.path.dirname(path)
2624 if dirname == os.path.expanduser('~'):
2625 dirname = '~'
2626 base = os.path.basename(path)
2627 if base in ('.netrc', '.gitcookies'):
2628 return self._mocked_call('os.path.exists', '%s/%s' % (dirname, base))
2629 # git cl also checks for existence other files not relevant to this test.
2630 return None
2631 self.mock(os.path, 'exists', exists_mock)
Edward Lemur79d4f992019-11-11 23:49:02 +00002632 self.mock(sys, 'stdout', StringIO())
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002633
2634 def test_creds_check_gitcookies_not_configured(self):
2635 self._common_creds_check_mocks()
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002636 self.mock(git_cl._GitCookiesChecker, 'get_hosts_with_creds',
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01002637 lambda _, include_netrc=False: [])
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002638 self.calls = [
Aaron Gable8797cab2018-03-06 13:55:00 -08002639 ((['git', 'config', '--path', 'http.cookiefile'],), CERR1),
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002640 ((['git', 'config', '--global', 'http.cookiefile'],), CERR1),
2641 (('os.path.exists', '~/.netrc'), True),
2642 (('ask_for_data', 'Press Enter to setup .gitcookies, '
2643 'or Ctrl+C to abort'), ''),
2644 ((['git', 'config', '--global', 'http.cookiefile',
2645 os.path.expanduser('~/.gitcookies')], ), ''),
2646 ]
2647 self.assertEqual(0, git_cl.main(['creds-check']))
2648 self.assertRegexpMatches(
2649 sys.stdout.getvalue(),
2650 '^You seem to be using outdated .netrc for git credentials:')
2651 self.assertRegexpMatches(
2652 sys.stdout.getvalue(),
2653 '\nConfigured git to use .gitcookies from')
2654
2655 def test_creds_check_gitcookies_configured_custom_broken(self):
2656 self._common_creds_check_mocks()
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002657 self.mock(git_cl._GitCookiesChecker, 'get_hosts_with_creds',
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01002658 lambda _, include_netrc=False: [])
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002659 self.calls = [
Aaron Gable8797cab2018-03-06 13:55:00 -08002660 ((['git', 'config', '--path', 'http.cookiefile'],), CERR1),
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002661 ((['git', 'config', '--global', 'http.cookiefile'],),
2662 '/custom/.gitcookies'),
2663 (('os.path.exists', '/custom/.gitcookies'), False),
2664 (('ask_for_data', 'Reconfigure git to use default .gitcookies? '
2665 'Press Enter to reconfigure, or Ctrl+C to abort'), ''),
2666 ((['git', 'config', '--global', 'http.cookiefile',
2667 os.path.expanduser('~/.gitcookies')], ), ''),
2668 ]
2669 self.assertEqual(0, git_cl.main(['creds-check']))
2670 self.assertRegexpMatches(
2671 sys.stdout.getvalue(),
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002672 'WARNING: You have configured custom path to .gitcookies: ')
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002673 self.assertRegexpMatches(
2674 sys.stdout.getvalue(),
2675 'However, your configured .gitcookies file is missing.')
2676
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002677 def test_git_cl_comment_add_gerrit(self):
2678 self.mock(git_cl.gerrit_util, 'SetReview',
Aaron Gable636b13f2017-07-14 10:42:48 -07002679 lambda host, change, msg, ready:
2680 self._mocked_call('SetReview', host, change, msg, ready))
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002681 self.calls = [
2682 ((['git', 'symbolic-ref', 'HEAD'],), CERR1),
2683 ((['git', 'symbolic-ref', 'HEAD'],), CERR1),
2684 ((['git', 'config', 'rietveld.upstream-branch'],), CERR1),
2685 ((['git', 'branch', '-r'],), 'origin/HEAD -> origin/master\n'
2686 'origin/master'),
2687 ((['git', 'config', 'remote.origin.url'],),
2688 'https://chromium.googlesource.com/infra/infra'),
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002689 (('SetReview', 'chromium-review.googlesource.com', 'infra%2Finfra~10',
2690 'msg', None),
Aaron Gable636b13f2017-07-14 10:42:48 -07002691 None),
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002692 ]
2693 self.assertEqual(0, git_cl.main(['comment', '--gerrit', '-i', '10',
2694 '-a', 'msg']))
2695
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002696 def test_git_cl_comments_fetch_gerrit(self):
Edward Lemur79d4f992019-11-11 23:49:02 +00002697 self.mock(sys, 'stdout', StringIO())
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002698 self.calls = [
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002699 ((['git', 'config', 'branch.foo.gerritserver'],), ''),
2700 ((['git', 'config', 'branch.foo.merge'],), ''),
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002701 ((['git', 'config', 'rietveld.upstream-branch'],), CERR1),
2702 ((['git', 'branch', '-r'],), 'origin/HEAD -> origin/master\n'
2703 'origin/master'),
2704 ((['git', 'config', 'remote.origin.url'],),
2705 'https://chromium.googlesource.com/infra/infra'),
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002706 (('GetChangeDetail', 'chromium-review.googlesource.com',
2707 'infra%2Finfra~1',
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002708 ['MESSAGES', 'DETAILED_ACCOUNTS', 'CURRENT_REVISION',
2709 'CURRENT_COMMIT']), {
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002710 'owner': {'email': 'owner@example.com'},
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002711 'current_revision': 'ba5eba11',
2712 'revisions': {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002713 'deadbeaf': {
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002714 '_number': 1,
2715 },
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002716 'ba5eba11': {
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002717 '_number': 2,
2718 },
2719 },
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002720 'messages': [
2721 {
2722 u'_revision_number': 1,
2723 u'author': {
2724 u'_account_id': 1111084,
2725 u'email': u'commit-bot@chromium.org',
2726 u'name': u'Commit Bot'
2727 },
2728 u'date': u'2017-03-15 20:08:45.000000000',
2729 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046dc50b',
Dirk Prankef6a58802017-10-17 12:49:42 -07002730 u'message': u'Patch Set 1:\n\nDry run: CQ is trying the patch...',
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002731 u'tag': u'autogenerated:cq:dry-run'
2732 },
2733 {
2734 u'_revision_number': 2,
2735 u'author': {
2736 u'_account_id': 11151243,
2737 u'email': u'owner@example.com',
2738 u'name': u'owner'
2739 },
2740 u'date': u'2017-03-16 20:00:41.000000000',
2741 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2742 u'message': u'PTAL',
2743 },
2744 {
2745 u'_revision_number': 2,
2746 u'author': {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002747 u'_account_id': 148512,
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002748 u'email': u'reviewer@example.com',
2749 u'name': u'reviewer'
2750 },
2751 u'date': u'2017-03-17 05:19:37.500000000',
2752 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d4568',
2753 u'message': u'Patch Set 2: Code-Review+1',
2754 },
2755 ]
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002756 }),
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002757 (('GetChangeComments', 'chromium-review.googlesource.com',
2758 'infra%2Finfra~1'), {
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002759 '/COMMIT_MSG': [
2760 {
2761 'author': {'email': u'reviewer@example.com'},
2762 'updated': u'2017-03-17 05:19:37.500000000',
2763 'patch_set': 2,
2764 'side': 'REVISION',
2765 'message': 'Please include a bug link',
2766 },
2767 ],
2768 'codereview.settings': [
2769 {
2770 'author': {'email': u'owner@example.com'},
2771 'updated': u'2017-03-16 20:00:41.000000000',
2772 'patch_set': 2,
2773 'side': 'PARENT',
2774 'line': 42,
2775 'message': 'I removed this because it is bad',
2776 },
2777 ]
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002778 }),
2779 (('GetChangeRobotComments', 'chromium-review.googlesource.com',
2780 'infra%2Finfra~1'), {}),
2781 ((['git', 'config', 'branch.foo.gerritpatchset', '2'],), ''),
Leszek Swirski45b20c42018-09-17 17:05:26 +00002782 ] * 2 + [
2783 (('write_json', 'output.json', [
2784 {
2785 u'date': u'2017-03-16 20:00:41.000000',
2786 u'message': (
2787 u'PTAL\n' +
2788 u'\n' +
2789 u'codereview.settings\n' +
2790 u' Base, Line 42: https://chromium-review.googlesource.com/' +
2791 u'c/1/2/codereview.settings#b42\n' +
2792 u' I removed this because it is bad\n'),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002793 u'autogenerated': False,
Leszek Swirski45b20c42018-09-17 17:05:26 +00002794 u'approval': False,
2795 u'disapproval': False,
2796 u'sender': u'owner@example.com'
2797 }, {
2798 u'date': u'2017-03-17 05:19:37.500000',
2799 u'message': (
2800 u'Patch Set 2: Code-Review+1\n' +
2801 u'\n' +
2802 u'/COMMIT_MSG\n' +
2803 u' PS2, File comment: https://chromium-review.googlesource' +
2804 u'.com/c/1/2//COMMIT_MSG#\n' +
2805 u' Please include a bug link\n'),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002806 u'autogenerated': False,
Leszek Swirski45b20c42018-09-17 17:05:26 +00002807 u'approval': False,
2808 u'disapproval': False,
2809 u'sender': u'reviewer@example.com'
2810 }
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002811 ]), '')
Leszek Swirski45b20c42018-09-17 17:05:26 +00002812 ]
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002813 expected_comments_summary = [
2814 git_cl._CommentSummary(
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002815 message=(
2816 u'PTAL\n' +
2817 u'\n' +
2818 u'codereview.settings\n' +
2819 u' Base, Line 42: https://chromium-review.googlesource.com/' +
2820 u'c/1/2/codereview.settings#b42\n' +
2821 u' I removed this because it is bad\n'),
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002822 date=datetime.datetime(2017, 3, 16, 20, 0, 41, 0),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002823 autogenerated=False,
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002824 disapproval=False, approval=False, sender=u'owner@example.com'),
2825 git_cl._CommentSummary(
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002826 message=(
2827 u'Patch Set 2: Code-Review+1\n' +
2828 u'\n' +
2829 u'/COMMIT_MSG\n' +
2830 u' PS2, File comment: https://chromium-review.googlesource.com/' +
2831 u'c/1/2//COMMIT_MSG#\n' +
2832 u' Please include a bug link\n'),
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002833 date=datetime.datetime(2017, 3, 17, 5, 19, 37, 500000),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002834 autogenerated=False,
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002835 disapproval=False, approval=False, sender=u'reviewer@example.com'),
2836 ]
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002837 cl = git_cl.Changelist(
Edward Lemurf38bc172019-09-03 21:02:13 +00002838 issue=1, branchref='refs/heads/foo')
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002839 self.assertEqual(cl.GetCommentsSummary(), expected_comments_summary)
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002840 self.mock(git_cl.Changelist, 'GetBranch', lambda _: 'foo')
2841 self.assertEqual(
2842 0, git_cl.main(['comments', '-i', '1', '-j', 'output.json']))
2843
2844 def test_git_cl_comments_robot_comments(self):
2845 # git cl comments also fetches robot comments (which are considered a type
2846 # of autogenerated comment), and unlike other types of comments, only robot
2847 # comments from the latest patchset are shown.
Edward Lemur79d4f992019-11-11 23:49:02 +00002848 self.mock(sys, 'stdout', StringIO())
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002849 self.calls = [
2850 ((['git', 'config', 'branch.foo.gerritserver'],), ''),
2851 ((['git', 'config', 'branch.foo.merge'],), ''),
2852 ((['git', 'config', 'rietveld.upstream-branch'],), CERR1),
2853 ((['git', 'branch', '-r'],), 'origin/HEAD -> origin/master\n'
2854 'origin/master'),
2855 ((['git', 'config', 'remote.origin.url'],),
2856 'https://chromium.googlesource.com/infra/infra'),
2857 (('GetChangeDetail', 'chromium-review.googlesource.com',
2858 'infra%2Finfra~1',
2859 ['MESSAGES', 'DETAILED_ACCOUNTS', 'CURRENT_REVISION',
2860 'CURRENT_COMMIT']), {
2861 'owner': {'email': 'owner@example.com'},
2862 'current_revision': 'ba5eba11',
2863 'revisions': {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002864 'deadbeaf': {
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002865 '_number': 1,
2866 },
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002867 'ba5eba11': {
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002868 '_number': 2,
2869 },
2870 },
2871 'messages': [
2872 {
2873 u'_revision_number': 1,
2874 u'author': {
2875 u'_account_id': 1111084,
2876 u'email': u'commit-bot@chromium.org',
2877 u'name': u'Commit Bot'
2878 },
2879 u'date': u'2017-03-15 20:08:45.000000000',
2880 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046dc50b',
2881 u'message': u'Patch Set 1:\n\nDry run: CQ is trying the patch...',
2882 u'tag': u'autogenerated:cq:dry-run'
2883 },
2884 {
2885 u'_revision_number': 1,
2886 u'author': {
2887 u'_account_id': 123,
2888 u'email': u'tricium@serviceaccount.com',
2889 u'name': u'Tricium'
2890 },
2891 u'date': u'2017-03-16 20:00:41.000000000',
2892 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2893 u'message': u'(1 comment)',
2894 u'tag': u'autogenerated:tricium',
2895 },
2896 {
2897 u'_revision_number': 1,
2898 u'author': {
2899 u'_account_id': 123,
2900 u'email': u'tricium@serviceaccount.com',
2901 u'name': u'Tricium'
2902 },
2903 u'date': u'2017-03-16 20:00:41.000000000',
2904 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2905 u'message': u'(1 comment)',
2906 u'tag': u'autogenerated:tricium',
2907 },
2908 {
2909 u'_revision_number': 2,
2910 u'author': {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002911 u'_account_id': 123,
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002912 u'email': u'tricium@serviceaccount.com',
2913 u'name': u'reviewer'
2914 },
2915 u'date': u'2017-03-17 05:30:37.000000000',
2916 u'tag': u'autogenerated:tricium',
2917 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d4568',
2918 u'message': u'(1 comment)',
2919 },
2920 ]
2921 }),
2922 (('GetChangeComments', 'chromium-review.googlesource.com',
2923 'infra%2Finfra~1'), {}),
2924 (('GetChangeRobotComments', 'chromium-review.googlesource.com',
2925 'infra%2Finfra~1'), {
2926 'codereview.settings': [
2927 {
2928 u'author': {u'email': u'tricium@serviceaccount.com'},
2929 u'updated': u'2017-03-17 05:30:37.000000000',
2930 u'robot_run_id': u'5565031076855808',
2931 u'robot_id': u'Linter/Category',
2932 u'tag': u'autogenerated:tricium',
2933 u'patch_set': 2,
2934 u'side': u'REVISION',
2935 u'message': u'Linter warning message text',
2936 u'line': 32,
2937 },
2938 ],
2939 }),
2940 ((['git', 'config', 'branch.foo.gerritpatchset', '2'],), ''),
2941 ]
2942 expected_comments_summary = [
2943 git_cl._CommentSummary(date=datetime.datetime(2017, 3, 17, 5, 30, 37),
2944 message=(
2945 u'(1 comment)\n\ncodereview.settings\n'
2946 u' PS2, Line 32: https://chromium-review.googlesource.com/'
2947 u'c/1/2/codereview.settings#32\n'
2948 u' Linter warning message text\n'),
2949 sender=u'tricium@serviceaccount.com',
2950 autogenerated=True, approval=False, disapproval=False)
2951 ]
2952 cl = git_cl.Changelist(
Edward Lemurf38bc172019-09-03 21:02:13 +00002953 issue=1, branchref='refs/heads/foo')
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002954 self.assertEqual(cl.GetCommentsSummary(), expected_comments_summary)
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002955
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002956 def test_get_remote_url_with_mirror(self):
2957 original_os_path_isdir = os.path.isdir
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002958
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002959 def selective_os_path_isdir_mock(path):
2960 if path == '/cache/this-dir-exists':
2961 return self._mocked_call('os.path.isdir', path)
2962 return original_os_path_isdir(path)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002963
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002964 self.mock(os.path, 'isdir', selective_os_path_isdir_mock)
2965
2966 url = 'https://chromium.googlesource.com/my/repo'
2967 self.calls = [
2968 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2969 ((['git', 'config', 'branch.master.merge'],), 'master'),
2970 ((['git', 'config', 'branch.master.remote'],), 'origin'),
2971 ((['git', 'config', 'remote.origin.url'],),
2972 '/cache/this-dir-exists'),
2973 (('os.path.isdir', '/cache/this-dir-exists'),
2974 True),
2975 # Runs in /cache/this-dir-exists.
2976 ((['git', 'config', 'remote.origin.url'],),
2977 url),
2978 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002979 cl = git_cl.Changelist(issue=1)
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002980 self.assertEqual(cl.GetRemoteUrl(), url)
2981 self.assertEqual(cl.GetRemoteUrl(), url) # Must be cached.
2982
Edward Lemur298f2cf2019-02-22 21:40:39 +00002983 def test_get_remote_url_non_existing_mirror(self):
2984 original_os_path_isdir = os.path.isdir
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002985
Edward Lemur298f2cf2019-02-22 21:40:39 +00002986 def selective_os_path_isdir_mock(path):
2987 if path == '/cache/this-dir-doesnt-exist':
2988 return self._mocked_call('os.path.isdir', path)
2989 return original_os_path_isdir(path)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002990
Edward Lemur298f2cf2019-02-22 21:40:39 +00002991 self.mock(os.path, 'isdir', selective_os_path_isdir_mock)
2992 self.mock(logging, 'error',
2993 lambda fmt, *a: self._mocked_call('logging.error', fmt % a))
2994
2995 self.calls = [
2996 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2997 ((['git', 'config', 'branch.master.merge'],), 'master'),
2998 ((['git', 'config', 'branch.master.remote'],), 'origin'),
2999 ((['git', 'config', 'remote.origin.url'],),
3000 '/cache/this-dir-doesnt-exist'),
3001 (('os.path.isdir', '/cache/this-dir-doesnt-exist'),
3002 False),
3003 (('logging.error',
Daniel Bratell4a60db42019-09-16 17:02:52 +00003004 'Remote "origin" for branch "master" points to'
3005 ' "/cache/this-dir-doesnt-exist", but it doesn\'t exist.'), None),
Edward Lemur298f2cf2019-02-22 21:40:39 +00003006 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00003007 cl = git_cl.Changelist(issue=1)
Edward Lemur298f2cf2019-02-22 21:40:39 +00003008 self.assertIsNone(cl.GetRemoteUrl())
3009
3010 def test_get_remote_url_misconfigured_mirror(self):
3011 original_os_path_isdir = os.path.isdir
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003012
Edward Lemur298f2cf2019-02-22 21:40:39 +00003013 def selective_os_path_isdir_mock(path):
3014 if path == '/cache/this-dir-exists':
3015 return self._mocked_call('os.path.isdir', path)
3016 return original_os_path_isdir(path)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003017
Edward Lemur298f2cf2019-02-22 21:40:39 +00003018 self.mock(os.path, 'isdir', selective_os_path_isdir_mock)
3019 self.mock(logging, 'error',
3020 lambda *a: self._mocked_call('logging.error', *a))
3021
3022 self.calls = [
3023 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
3024 ((['git', 'config', 'branch.master.merge'],), 'master'),
3025 ((['git', 'config', 'branch.master.remote'],), 'origin'),
3026 ((['git', 'config', 'remote.origin.url'],),
3027 '/cache/this-dir-exists'),
3028 (('os.path.isdir', '/cache/this-dir-exists'), True),
3029 # Runs in /cache/this-dir-exists.
3030 ((['git', 'config', 'remote.origin.url'],), ''),
3031 (('logging.error',
3032 'Remote "%(remote)s" for branch "%(branch)s" points to '
3033 '"%(cache_path)s", but it is misconfigured.\n'
3034 '"%(cache_path)s" must be a git repo and must have a remote named '
3035 '"%(remote)s" pointing to the git host.', {
3036 'remote': 'origin',
3037 'cache_path': '/cache/this-dir-exists',
3038 'branch': 'master'}
3039 ), None),
3040 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00003041 cl = git_cl.Changelist(issue=1)
Edward Lemur298f2cf2019-02-22 21:40:39 +00003042 self.assertIsNone(cl.GetRemoteUrl())
3043
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00003044 def test_gerrit_change_identifier_with_project(self):
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00003045 self.calls = [
3046 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
3047 ((['git', 'config', 'branch.master.merge'],), 'master'),
3048 ((['git', 'config', 'branch.master.remote'],), 'origin'),
3049 ((['git', 'config', 'remote.origin.url'],),
3050 'https://chromium.googlesource.com/a/my/repo.git/'),
3051 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00003052 cl = git_cl.Changelist(issue=123456)
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00003053 self.assertEqual(cl._GerritChangeIdentifier(), 'my%2Frepo~123456')
3054
3055 def test_gerrit_change_identifier_without_project(self):
3056 self.calls = [
3057 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
3058 ((['git', 'config', 'branch.master.merge'],), 'master'),
3059 ((['git', 'config', 'branch.master.remote'],), 'origin'),
3060 ((['git', 'config', 'remote.origin.url'],), CERR1),
3061 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00003062 cl = git_cl.Changelist(issue=123456)
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00003063 self.assertEqual(cl._GerritChangeIdentifier(), '123456')
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00003064
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003065
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003066class CMDTestCaseBase(unittest.TestCase):
3067 _STATUSES = [
3068 'STATUS_UNSPECIFIED', 'SCHEDULED', 'STARTED', 'SUCCESS', 'FAILURE',
3069 'INFRA_FAILURE', 'CANCELED',
3070 ]
3071 _CHANGE_DETAIL = {
3072 'project': 'depot_tools',
3073 'status': 'OPEN',
3074 'owner': {'email': 'owner@e.mail'},
3075 'current_revision': 'beeeeeef',
3076 'revisions': {
3077 'deadbeaf': {'_number': 6},
3078 'beeeeeef': {
3079 '_number': 7,
3080 'fetch': {'http': {
3081 'url': 'https://chromium.googlesource.com/depot_tools',
3082 'ref': 'refs/changes/56/123456/7'
3083 }},
3084 },
3085 },
3086 }
3087 _DEFAULT_RESPONSE = {
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003088 'builds': [{
3089 'id': str(100 + idx),
3090 'builder': {
3091 'project': 'chromium',
3092 'bucket': 'try',
3093 'builder': 'bot_' + status.lower(),
3094 },
3095 'createTime': '2019-10-09T08:00:0%d.854286Z' % (idx % 10),
3096 'tags': [],
3097 'status': status,
3098 } for idx, status in enumerate(_STATUSES)]
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003099 }
3100
Edward Lemur4c707a22019-09-24 21:13:43 +00003101 def setUp(self):
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003102 super(CMDTestCaseBase, self).setUp()
Edward Lemur79d4f992019-11-11 23:49:02 +00003103 mock.patch('git_cl.sys.stdout', StringIO()).start()
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003104 mock.patch('git_cl.uuid.uuid4', return_value='uuid4').start()
3105 mock.patch('git_cl.Changelist.GetIssue', return_value=123456).start()
Edward Lemur4c707a22019-09-24 21:13:43 +00003106 mock.patch('git_cl.Changelist.GetCodereviewServer',
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003107 return_value='https://chromium-review.googlesource.com').start()
3108 mock.patch('git_cl.Changelist.GetMostRecentPatchset',
3109 return_value=7).start()
Edward Lemur5b929a42019-10-21 17:57:39 +00003110 mock.patch('git_cl.auth.Authenticator',
Edward Lemurb4a587d2019-10-09 23:56:38 +00003111 return_value=AuthenticatorMock()).start()
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003112 mock.patch('git_cl.Changelist._GetChangeDetail',
3113 return_value=self._CHANGE_DETAIL).start()
3114 mock.patch('git_cl._call_buildbucket',
3115 return_value = self._DEFAULT_RESPONSE).start()
3116 mock.patch('git_common.is_dirty_git_tree', return_value=False).start()
Edward Lemur4c707a22019-09-24 21:13:43 +00003117 self.addCleanup(mock.patch.stopall)
3118
Edward Lemur4c707a22019-09-24 21:13:43 +00003119
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003120class CMDTryResultsTestCase(CMDTestCaseBase):
3121 _DEFAULT_REQUEST = {
3122 'predicate': {
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003123 "gerritChanges": [{
3124 "project": "depot_tools",
3125 "host": "chromium-review.googlesource.com",
3126 "patchset": 7,
3127 "change": 123456,
3128 }],
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003129 },
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003130 'fields': ('builds.*.id,builds.*.builder,builds.*.status' +
3131 ',builds.*.createTime,builds.*.tags'),
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003132 }
3133
3134 def testNoJobs(self):
3135 git_cl._call_buildbucket.return_value = {}
3136
3137 self.assertEqual(0, git_cl.main(['try-results']))
3138 self.assertEqual('No tryjobs scheduled.\n', sys.stdout.getvalue())
3139 git_cl._call_buildbucket.assert_called_once_with(
3140 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3141 self._DEFAULT_REQUEST)
3142
3143 def testPrintToStdout(self):
3144 self.assertEqual(0, git_cl.main(['try-results']))
3145 self.assertEqual([
3146 'Successes:',
3147 ' bot_success https://ci.chromium.org/b/103',
3148 'Infra Failures:',
3149 ' bot_infra_failure https://ci.chromium.org/b/105',
3150 'Failures:',
3151 ' bot_failure https://ci.chromium.org/b/104',
3152 'Canceled:',
3153 ' bot_canceled ',
3154 'Started:',
3155 ' bot_started https://ci.chromium.org/b/102',
3156 'Scheduled:',
3157 ' bot_scheduled id=101',
3158 'Other:',
3159 ' bot_status_unspecified id=100',
3160 'Total: 7 tryjobs',
3161 ], sys.stdout.getvalue().splitlines())
3162 git_cl._call_buildbucket.assert_called_once_with(
3163 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3164 self._DEFAULT_REQUEST)
3165
3166 def testPrintToStdoutWithMasters(self):
3167 self.assertEqual(0, git_cl.main(['try-results', '--print-master']))
3168 self.assertEqual([
3169 'Successes:',
3170 ' try bot_success https://ci.chromium.org/b/103',
3171 'Infra Failures:',
3172 ' try bot_infra_failure https://ci.chromium.org/b/105',
3173 'Failures:',
3174 ' try bot_failure https://ci.chromium.org/b/104',
3175 'Canceled:',
3176 ' try bot_canceled ',
3177 'Started:',
3178 ' try bot_started https://ci.chromium.org/b/102',
3179 'Scheduled:',
3180 ' try bot_scheduled id=101',
3181 'Other:',
3182 ' try bot_status_unspecified id=100',
3183 'Total: 7 tryjobs',
3184 ], sys.stdout.getvalue().splitlines())
3185 git_cl._call_buildbucket.assert_called_once_with(
3186 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3187 self._DEFAULT_REQUEST)
3188
3189 @mock.patch('git_cl.write_json')
3190 def testWriteToJson(self, mockJsonDump):
3191 self.assertEqual(0, git_cl.main(['try-results', '--json', 'file.json']))
3192 git_cl._call_buildbucket.assert_called_once_with(
3193 mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
3194 self._DEFAULT_REQUEST)
3195 mockJsonDump.assert_called_once_with(
3196 'file.json', self._DEFAULT_RESPONSE['builds'])
3197
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003198 def test_filter_failed_for_one_simple(self):
3199 self.assertEqual({}, git_cl._filter_failed_for_retry([]))
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003200 self.assertEqual({
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003201 'chromium/try': {
3202 'bot_failure': [],
3203 'bot_infra_failure': []
3204 },
3205 }, git_cl._filter_failed_for_retry(self._DEFAULT_RESPONSE['builds']))
3206
3207 def test_filter_failed_for_retry_many_builds(self):
3208
3209 def _build(name, created_sec, status, experimental=False):
3210 assert 0 <= created_sec < 100, created_sec
3211 b = {
3212 'id': 112112,
3213 'builder': {
3214 'project': 'chromium',
3215 'bucket': 'try',
3216 'builder': name,
3217 },
3218 'createTime': '2019-10-09T08:00:%02d.854286Z' % created_sec,
3219 'status': status,
3220 'tags': [],
3221 }
3222 if experimental:
3223 b['tags'].append({'key': 'cq_experimental', 'value': 'true'})
3224 return b
3225
3226 builds = [
3227 _build('flaky-last-green', 1, 'FAILURE'),
3228 _build('flaky-last-green', 2, 'SUCCESS'),
3229 _build('flaky', 1, 'SUCCESS'),
3230 _build('flaky', 2, 'FAILURE'),
3231 _build('running', 1, 'FAILED'),
3232 _build('running', 2, 'SCHEDULED'),
3233 _build('yep-still-running', 1, 'STARTED'),
3234 _build('yep-still-running', 2, 'FAILURE'),
3235 _build('cq-experimental', 1, 'SUCCESS', experimental=True),
3236 _build('cq-experimental', 2, 'FAILURE', experimental=True),
3237
3238 # Simulate experimental in CQ builder, which developer decided
3239 # to retry manually which resulted in 2nd build non-experimental.
3240 _build('sometimes-experimental', 1, 'FAILURE', experimental=True),
3241 _build('sometimes-experimental', 2, 'FAILURE', experimental=False),
3242 ]
3243 builds.sort(key=lambda b: b['status']) # ~deterministic shuffle.
3244 self.assertEqual({
3245 'chromium/try': {
3246 'flaky': [],
3247 'sometimes-experimental': []
3248 },
3249 }, git_cl._filter_failed_for_retry(builds))
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003250
3251
3252class CMDTryTestCase(CMDTestCaseBase):
3253
3254 @mock.patch('git_cl.Changelist.SetCQState')
3255 @mock.patch('git_cl._get_bucket_map', return_value={})
3256 def testSetCQDryRunByDefault(self, _mockGetBucketMap, mockSetCQState):
3257 mockSetCQState.return_value = 0
Edward Lemur4c707a22019-09-24 21:13:43 +00003258 self.assertEqual(0, git_cl.main(['try']))
3259 git_cl.Changelist.SetCQState.assert_called_with(git_cl._CQState.DRY_RUN)
3260 self.assertEqual(
3261 sys.stdout.getvalue(),
3262 'Scheduling CQ dry run on: '
3263 'https://chromium-review.googlesource.com/123456\n')
3264
Edward Lemur4c707a22019-09-24 21:13:43 +00003265 @mock.patch('git_cl._call_buildbucket')
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003266 def testScheduleOnBuildbucket(self, mockCallBuildbucket):
Edward Lemur4c707a22019-09-24 21:13:43 +00003267 mockCallBuildbucket.return_value = {}
Edward Lemur4c707a22019-09-24 21:13:43 +00003268
3269 self.assertEqual(0, git_cl.main([
3270 'try', '-B', 'luci.chromium.try', '-b', 'win',
3271 '-p', 'key=val', '-p', 'json=[{"a":1}, null]']))
3272 self.assertIn(
3273 'Scheduling jobs on:\nBucket: luci.chromium.try',
3274 git_cl.sys.stdout.getvalue())
3275
3276 expected_request = {
3277 "requests": [{
3278 "scheduleBuild": {
3279 "requestId": "uuid4",
3280 "builder": {
3281 "project": "chromium",
3282 "builder": "win",
3283 "bucket": "try",
3284 },
3285 "gerritChanges": [{
3286 "project": "depot_tools",
3287 "host": "chromium-review.googlesource.com",
3288 "patchset": 7,
3289 "change": 123456,
3290 }],
3291 "properties": {
3292 "category": "git_cl_try",
3293 "json": [{"a": 1}, None],
3294 "key": "val",
3295 },
3296 "tags": [
3297 {"value": "win", "key": "builder"},
3298 {"value": "git_cl_try", "key": "user_agent"},
3299 ],
3300 },
3301 }],
3302 }
3303 mockCallBuildbucket.assert_called_with(
3304 mock.ANY, 'cr-buildbucket.appspot.com', 'Batch', expected_request)
3305
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003306 def testScheduleOnBuildbucket_WrongBucket(self):
Edward Lemur4c707a22019-09-24 21:13:43 +00003307 self.assertEqual(0, git_cl.main([
3308 'try', '-B', 'not-a-bucket', '-b', 'win',
3309 '-p', 'key=val', '-p', 'json=[{"a":1}, null]']))
3310 self.assertIn(
3311 'WARNING Could not parse bucket "not-a-bucket". Skipping.',
3312 git_cl.sys.stdout.getvalue())
3313
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003314 @mock.patch('git_cl._call_buildbucket')
3315 @mock.patch('git_cl.fetch_try_jobs')
3316 def testScheduleOnBuildbucketRetryFailed(
3317 self, mockFetchTryJobs, mockCallBuildbucket):
3318
3319 git_cl.fetch_try_jobs.side_effect = lambda *_, **kw: {
3320 7: [],
3321 6: [{
3322 'id': 112112,
3323 'builder': {
3324 'project': 'chromium',
3325 'bucket': 'try',
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003326 'builder': 'linux',},
3327 'createTime': '2019-10-09T08:00:01.854286Z',
3328 'tags': [],
3329 'status': 'FAILURE',}],}[kw['patchset']]
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00003330 mockCallBuildbucket.return_value = {}
3331
3332 self.assertEqual(0, git_cl.main(['try', '--retry-failed']))
3333 self.assertIn(
3334 'Scheduling jobs on:\nBucket: chromium/try',
3335 git_cl.sys.stdout.getvalue())
3336
3337 expected_request = {
3338 "requests": [{
3339 "scheduleBuild": {
3340 "requestId": "uuid4",
3341 "builder": {
3342 "project": "chromium",
3343 "bucket": "try",
3344 "builder": "linux",
3345 },
3346 "gerritChanges": [{
3347 "project": "depot_tools",
3348 "host": "chromium-review.googlesource.com",
3349 "patchset": 7,
3350 "change": 123456,
3351 }],
3352 "properties": {
3353 "category": "git_cl_try",
3354 },
3355 "tags": [
3356 {"value": "linux", "key": "builder"},
3357 {"value": "git_cl_try", "key": "user_agent"},
3358 {"value": "1", "key": "retry_failed"},
3359 ],
3360 },
3361 }],
3362 }
3363 mockCallBuildbucket.assert_called_with(
3364 mock.ANY, 'cr-buildbucket.appspot.com', 'Batch', expected_request)
3365
Edward Lemur4c707a22019-09-24 21:13:43 +00003366 def test_parse_bucket(self):
3367 test_cases = [
3368 {
3369 'bucket': 'chromium/try',
3370 'result': ('chromium', 'try'),
3371 },
3372 {
3373 'bucket': 'luci.chromium.try',
3374 'result': ('chromium', 'try'),
3375 'has_warning': True,
3376 },
3377 {
3378 'bucket': 'skia.primary',
3379 'result': ('skia', 'skia.primary'),
3380 'has_warning': True,
3381 },
3382 {
3383 'bucket': 'not-a-bucket',
3384 'result': (None, None),
3385 },
3386 ]
3387
3388 for test_case in test_cases:
3389 git_cl.sys.stdout.truncate(0)
3390 self.assertEqual(
3391 test_case['result'], git_cl._parse_bucket(test_case['bucket']))
3392 if test_case.get('has_warning'):
Edward Lemur6215c792019-10-03 21:59:05 +00003393 expected_warning = 'WARNING Please use %s/%s to specify the bucket' % (
3394 test_case['result'])
3395 self.assertIn(expected_warning, git_cl.sys.stdout.getvalue())
Edward Lemur4c707a22019-09-24 21:13:43 +00003396
3397
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003398class CMDUploadTestCase(CMDTestCaseBase):
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003399 def setUp(self):
3400 super(CMDUploadTestCase, self).setUp()
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003401 mock.patch('git_cl.fetch_try_jobs').start()
3402 mock.patch('git_cl._trigger_try_jobs', return_value={}).start()
3403 mock.patch('git_cl.Changelist.CMDUpload', return_value=0).start()
Anthony Polito46689b02019-11-15 20:56:41 +00003404 mock.patch('git_cl.Settings.GetIsGerrit', return_value=True).start()
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003405 self.addCleanup(mock.patch.stopall)
3406
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003407 def testUploadRetryFailed(self):
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003408 # This test mocks out the actual upload part, and just asserts that after
3409 # upload, if --retry-failed is added, then the tool will fetch try jobs
3410 # from the previous patchset and trigger the right builders on the latest
3411 # patchset.
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003412 git_cl.fetch_try_jobs.side_effect = [
3413 # Latest patchset: No builds.
3414 [],
3415 # Patchset before latest: Some builds.
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00003416 [{
3417 'id': str(100 + idx),
3418 'builder': {
3419 'project': 'chromium',
3420 'bucket': 'try',
3421 'builder': 'bot_' + status.lower(),
3422 },
3423 'createTime': '2019-10-09T08:00:0%d.854286Z' % (idx % 10),
3424 'tags': [],
3425 'status': status,
3426 } for idx, status in enumerate(self._STATUSES)],
Andrii Shyshkalov1ad58112019-10-08 01:46:14 +00003427 ]
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003428
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003429 self.assertEqual(0, git_cl.main(['upload', '--retry-failed']))
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003430 self.assertEqual([
Edward Lemur5b929a42019-10-21 17:57:39 +00003431 mock.call(mock.ANY, 'cr-buildbucket.appspot.com', patchset=7),
3432 mock.call(mock.ANY, 'cr-buildbucket.appspot.com', patchset=6),
Edward Lemurbaaf6be2019-10-09 18:00:44 +00003433 ], git_cl.fetch_try_jobs.mock_calls)
3434 expected_buckets = {
3435 'chromium/try': {'bot_failure': [], 'bot_infra_failure': []},
3436 }
3437 git_cl._trigger_try_jobs.assert_called_once_with(
Edward Lemur5b929a42019-10-21 17:57:39 +00003438 mock.ANY, expected_buckets, mock.ANY, 8)
Quinten Yearsleya19d3532019-09-30 21:54:39 +00003439
Brian Sheedy59b06a82019-10-14 17:03:29 +00003440
3441class CMDFormatTestCase(TestCase):
3442
3443 def setUp(self):
3444 super(CMDFormatTestCase, self).setUp()
Jamie Madill5e96ad12020-01-13 16:08:35 +00003445 mock.patch('git_cl.RunCommand').start()
3446 mock.patch('clang_format.FindClangFormatToolInChromiumTree').start()
3447 mock.patch('clang_format.FindClangFormatScriptInChromiumTree').start()
3448 mock.patch('git_cl.settings').start()
Brian Sheedy59b06a82019-10-14 17:03:29 +00003449 self._top_dir = tempfile.mkdtemp()
Jamie Madill5e96ad12020-01-13 16:08:35 +00003450 self.addCleanup(mock.patch.stopall)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003451
3452 def tearDown(self):
3453 shutil.rmtree(self._top_dir)
3454 super(CMDFormatTestCase, self).tearDown()
3455
Jamie Madill5e96ad12020-01-13 16:08:35 +00003456 def _make_temp_file(self, fname, contents):
3457 with open(os.path.join(self._top_dir, fname), 'w') as tf:
3458 tf.write('\n'.join(contents))
3459
Brian Sheedy59b06a82019-10-14 17:03:29 +00003460 def _make_yapfignore(self, contents):
Jamie Madill5e96ad12020-01-13 16:08:35 +00003461 self._make_temp_file('.yapfignore', contents)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003462
Brian Sheedyb4307d52019-12-02 19:18:17 +00003463 def _check_yapf_filtering(self, files, expected):
3464 self.assertEqual(expected, git_cl._FilterYapfIgnoredFiles(
3465 files, git_cl._GetYapfIgnorePatterns(self._top_dir)))
Brian Sheedy59b06a82019-10-14 17:03:29 +00003466
Jamie Madill5e96ad12020-01-13 16:08:35 +00003467 def testClangFormatDiffFull(self):
3468 self._make_temp_file('test.cc', ['// test'])
3469 git_cl.settings.GetFormatFullByDefault.return_value = False
3470 diff_file = [os.path.join(self._top_dir, 'test.cc')]
3471 mock_opts = mock.Mock(full=True, dry_run=True, diff=False)
3472
3473 # Diff
3474 git_cl.RunCommand.return_value = ' // test'
3475 return_value = git_cl._RunClangFormatDiff(mock_opts, diff_file,
3476 self._top_dir, 'HEAD')
3477 self.assertEqual(2, return_value)
3478
3479 # No diff
3480 git_cl.RunCommand.return_value = '// test'
3481 return_value = git_cl._RunClangFormatDiff(mock_opts, diff_file,
3482 self._top_dir, 'HEAD')
3483 self.assertEqual(0, return_value)
3484
3485 def testClangFormatDiff(self):
3486 git_cl.settings.GetFormatFullByDefault.return_value = False
3487 mock_opts = mock.Mock(full=False, dry_run=True, diff=False)
3488
3489 # Diff
3490 git_cl.RunCommand.return_value = 'error'
3491 return_value = git_cl._RunClangFormatDiff(mock_opts, ['.'], self._top_dir,
3492 'HEAD')
3493 self.assertEqual(2, return_value)
3494
3495 # No diff
3496 git_cl.RunCommand.return_value = ''
3497 return_value = git_cl._RunClangFormatDiff(mock_opts, ['.'], self._top_dir,
3498 'HEAD')
3499 self.assertEqual(0, return_value)
3500
Brian Sheedyb4307d52019-12-02 19:18:17 +00003501 def testYapfignoreExplicit(self):
3502 self._make_yapfignore(['foo/bar.py', 'foo/bar/baz.py'])
3503 files = [
3504 'bar.py',
3505 'foo/bar.py',
3506 'foo/baz.py',
3507 'foo/bar/baz.py',
3508 'foo/bar/foobar.py',
3509 ]
3510 expected = [
3511 'bar.py',
3512 'foo/baz.py',
3513 'foo/bar/foobar.py',
3514 ]
3515 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003516
Brian Sheedyb4307d52019-12-02 19:18:17 +00003517 def testYapfignoreSingleWildcards(self):
3518 self._make_yapfignore(['*bar.py', 'foo*', 'baz*.py'])
3519 files = [
3520 'bar.py', # Matched by *bar.py.
3521 'bar.txt',
3522 'foobar.py', # Matched by *bar.py, foo*.
3523 'foobar.txt', # Matched by foo*.
3524 'bazbar.py', # Matched by *bar.py, baz*.py.
3525 'bazbar.txt',
3526 'foo/baz.txt', # Matched by foo*.
3527 'bar/bar.py', # Matched by *bar.py.
3528 'baz/foo.py', # Matched by baz*.py, foo*.
3529 'baz/foo.txt',
3530 ]
3531 expected = [
3532 'bar.txt',
3533 'bazbar.txt',
3534 'baz/foo.txt',
3535 ]
3536 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003537
Brian Sheedyb4307d52019-12-02 19:18:17 +00003538 def testYapfignoreMultiplewildcards(self):
3539 self._make_yapfignore(['*bar*', '*foo*baz.txt'])
3540 files = [
3541 'bar.py', # Matched by *bar*.
3542 'bar.txt', # Matched by *bar*.
3543 'abar.py', # Matched by *bar*.
3544 'foobaz.txt', # Matched by *foo*baz.txt.
3545 'foobaz.py',
3546 'afoobaz.txt', # Matched by *foo*baz.txt.
3547 ]
3548 expected = [
3549 'foobaz.py',
3550 ]
3551 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003552
3553 def testYapfignoreComments(self):
3554 self._make_yapfignore(['test.py', '#test2.py'])
Brian Sheedyb4307d52019-12-02 19:18:17 +00003555 files = [
3556 'test.py',
3557 'test2.py',
3558 ]
3559 expected = [
3560 'test2.py',
3561 ]
3562 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003563
3564 def testYapfignoreBlankLines(self):
3565 self._make_yapfignore(['test.py', '', '', 'test2.py'])
Brian Sheedyb4307d52019-12-02 19:18:17 +00003566 files = [
3567 'test.py',
3568 'test2.py',
3569 'test3.py',
3570 ]
3571 expected = [
3572 'test3.py',
3573 ]
3574 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003575
3576 def testYapfignoreWhitespace(self):
3577 self._make_yapfignore([' test.py '])
Brian Sheedyb4307d52019-12-02 19:18:17 +00003578 files = [
3579 'test.py',
3580 'test2.py',
3581 ]
3582 expected = [
3583 'test2.py',
3584 ]
3585 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003586
Brian Sheedyb4307d52019-12-02 19:18:17 +00003587 def testYapfignoreNoFiles(self):
Brian Sheedy59b06a82019-10-14 17:03:29 +00003588 self._make_yapfignore(['test.py'])
Brian Sheedyb4307d52019-12-02 19:18:17 +00003589 self._check_yapf_filtering([], [])
3590
3591 def testYapfignoreMissingYapfignore(self):
3592 files = [
3593 'test.py',
3594 ]
3595 expected = [
3596 'test.py',
3597 ]
3598 self._check_yapf_filtering(files, expected)
Brian Sheedy59b06a82019-10-14 17:03:29 +00003599
3600
maruel@chromium.orgddd59412011-11-30 14:20:38 +00003601if __name__ == '__main__':
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +01003602 logging.basicConfig(
3603 level=logging.DEBUG if '-v' in sys.argv else logging.ERROR)
maruel@chromium.orgddd59412011-11-30 14:20:38 +00003604 unittest.main()