blob: 93a9e7373f96930bd345b888af5d2f3ee5e59623 [file] [log] [blame]
Josip Sokcevic4de5dea2022-03-23 21:15:14 +00001#!/usr/bin/env python3
maruel@chromium.org3bbf2942012-01-10 16:52:06 +00002# Copyright (c) 2012 The Chromium Authors. All rights reserved.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00003# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5
6"""Enables directory-specific presubmit checks to run at upload and/or commit.
7"""
8
Raul Tambre80ee78e2019-05-06 22:41:05 +00009from __future__ import print_function
10
Saagar Sanghavi99816902020-08-11 22:41:25 +000011__version__ = '2.0.0'
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000012
13# TODO(joi) Add caching where appropriate/needed. The API is designed to allow
14# caching (between all different invocations of presubmit scripts for a given
15# change). We should add it as our presubmit scripts start feeling slow.
16
Edward Lemura5799e32020-01-17 19:26:51 +000017import argparse
Takeshi Yoshino07a6bea2017-08-02 02:44:06 +090018import ast # Exposed through the API.
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +000019import contextlib
Yoshisato Yanagisawa406de132018-06-29 05:43:25 +000020import cpplint
dcheng091b7db2016-06-16 01:27:51 -070021import fnmatch # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000022import glob
asvitkine@chromium.org15169952011-09-27 14:30:53 +000023import inspect
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +000024import itertools
maruel@chromium.org4f6852c2012-04-20 20:39:20 +000025import json # Exposed through the API.
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +000026import logging
ilevy@chromium.orgbc117312013-04-20 03:57:56 +000027import multiprocessing
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000028import os # Somewhat exposed through the API.
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +000029import random
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000030import re # Exposed through the API.
Edward Lesmes8e282792018-04-03 18:50:29 -040031import signal
Allen Webbfe7d7092021-05-18 02:05:49 +000032import six
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000033import sys # Parts exposed through API.
34import tempfile # Exposed through the API.
Edward Lesmes8e282792018-04-03 18:50:29 -040035import threading
jam@chromium.org2a891dc2009-08-20 20:33:37 +000036import time
Edward Lemurde9e3ca2019-10-24 21:13:31 +000037import traceback
maruel@chromium.org1487d532009-06-06 00:22:57 +000038import unittest # Exposed through the API.
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +000039from warnings import warn
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000040
41# Local imports.
maruel@chromium.org35625c72011-03-23 17:34:02 +000042import fix_encoding
Yoshisato Yanagisawa04600b42019-03-15 03:03:41 +000043import gclient_paths # Exposed through the API
44import gclient_utils
Aaron Gableb584c4f2017-04-26 16:28:08 -070045import git_footers
tandrii@chromium.org015ebae2016-04-25 19:37:22 +000046import gerrit_util
Edward Lesmes9ce03f82021-01-12 20:13:31 +000047import owners_client
Jochen Eisinger76f5fc62017-04-07 16:27:46 +020048import owners_finder
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000049import presubmit_canned_checks
Saagar Sanghavi9949ab72020-07-20 20:56:40 +000050import rdb_wrapper
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +000051import scm
maruel@chromium.org84f4fe32011-04-06 13:26:45 +000052import subprocess2 as subprocess # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000053
Edward Lemur16af3562019-10-17 22:11:33 +000054if sys.version_info.major == 2:
55 # TODO(1009814): Expose urllib2 only through urllib_request and urllib_error
56 import urllib2 # Exposed through the API.
57 import urlparse
58 import urllib2 as urllib_request
59 import urllib2 as urllib_error
60else:
61 import urllib.parse as urlparse
62 import urllib.request as urllib_request
63 import urllib.error as urllib_error
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000064
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +000065# Ask for feedback only once in program lifetime.
66_ASKED_FOR_FEEDBACK = False
67
Bruce Dawsondca14bc2022-09-15 20:59:38 +000068# Set if super-verbose mode is requested, for tracking where presubmit messages
69# are coming from.
70_SHOW_CALLSTACKS = False
71
72
Edward Lemurecc27072020-01-06 16:42:34 +000073def time_time():
74 # Use this so that it can be mocked in tests without interfering with python
75 # system machinery.
76 return time.time()
77
78
maruel@chromium.org899e1c12011-04-07 17:03:18 +000079class PresubmitFailure(Exception):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000080 pass
81
82
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000083class CommandData(object):
Edward Lemur940c2822019-08-23 00:34:25 +000084 def __init__(self, name, cmd, kwargs, message, python3=False):
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000085 self.name = name
86 self.cmd = cmd
Edward Lesmes8e282792018-04-03 18:50:29 -040087 self.stdin = kwargs.get('stdin', None)
Edward Lemur2d6b67c2019-08-23 22:25:41 +000088 self.kwargs = kwargs.copy()
Edward Lesmes8e282792018-04-03 18:50:29 -040089 self.kwargs['stdout'] = subprocess.PIPE
90 self.kwargs['stderr'] = subprocess.STDOUT
91 self.kwargs['stdin'] = subprocess.PIPE
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000092 self.message = message
93 self.info = None
Edward Lemur940c2822019-08-23 00:34:25 +000094 self.python3 = python3
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000095
ilevy@chromium.orgbc117312013-04-20 03:57:56 +000096
Edward Lesmes8e282792018-04-03 18:50:29 -040097# Adapted from
98# https://github.com/google/gtest-parallel/blob/master/gtest_parallel.py#L37
99#
100# An object that catches SIGINT sent to the Python process and notices
101# if processes passed to wait() die by SIGINT (we need to look for
102# both of those cases, because pressing Ctrl+C can result in either
103# the main process or one of the subprocesses getting the signal).
104#
105# Before a SIGINT is seen, wait(p) will simply call p.wait() and
106# return the result. Once a SIGINT has been seen (in the main process
107# or a subprocess, including the one the current call is waiting for),
Edward Lemur9a5bb612019-09-26 02:01:52 +0000108# wait(p) will call p.terminate().
Edward Lesmes8e282792018-04-03 18:50:29 -0400109class SigintHandler(object):
Edward Lesmes8e282792018-04-03 18:50:29 -0400110 sigint_returncodes = {-signal.SIGINT, # Unix
111 -1073741510, # Windows
112 }
113 def __init__(self):
114 self.__lock = threading.Lock()
115 self.__processes = set()
116 self.__got_sigint = False
Edward Lemur9a5bb612019-09-26 02:01:52 +0000117 self.__previous_signal = signal.signal(signal.SIGINT, self.interrupt)
Edward Lesmes8e282792018-04-03 18:50:29 -0400118
119 def __on_sigint(self):
120 self.__got_sigint = True
121 while self.__processes:
122 try:
123 self.__processes.pop().terminate()
124 except OSError:
125 pass
126
Edward Lemur9a5bb612019-09-26 02:01:52 +0000127 def interrupt(self, signal_num, frame):
Edward Lesmes8e282792018-04-03 18:50:29 -0400128 with self.__lock:
129 self.__on_sigint()
Edward Lemur9a5bb612019-09-26 02:01:52 +0000130 self.__previous_signal(signal_num, frame)
Edward Lesmes8e282792018-04-03 18:50:29 -0400131
132 def got_sigint(self):
133 with self.__lock:
134 return self.__got_sigint
135
136 def wait(self, p, stdin):
137 with self.__lock:
138 if self.__got_sigint:
139 p.terminate()
140 self.__processes.add(p)
141 stdout, stderr = p.communicate(stdin)
142 code = p.returncode
143 with self.__lock:
144 self.__processes.discard(p)
145 if code in self.sigint_returncodes:
146 self.__on_sigint()
Edward Lesmes8e282792018-04-03 18:50:29 -0400147 return stdout, stderr
148
149sigint_handler = SigintHandler()
150
151
Edward Lemurecc27072020-01-06 16:42:34 +0000152class Timer(object):
153 def __init__(self, timeout, fn):
154 self.completed = False
155 self._fn = fn
156 self._timer = threading.Timer(timeout, self._onTimer) if timeout else None
157
158 def __enter__(self):
159 if self._timer:
160 self._timer.start()
161 return self
162
163 def __exit__(self, _type, _value, _traceback):
164 if self._timer:
165 self._timer.cancel()
166
167 def _onTimer(self):
168 self._fn()
169 self.completed = True
170
171
Edward Lesmes8e282792018-04-03 18:50:29 -0400172class ThreadPool(object):
Edward Lemurecc27072020-01-06 16:42:34 +0000173 def __init__(self, pool_size=None, timeout=None):
174 self.timeout = timeout
Edward Lesmes8e282792018-04-03 18:50:29 -0400175 self._pool_size = pool_size or multiprocessing.cpu_count()
Bruce Dawson8254f062022-06-17 17:33:08 +0000176 if sys.platform == 'win32':
177 # TODO(crbug.com/1190269) - we can't use more than 56 child processes on
178 # Windows or Python3 may hang.
179 self._pool_size = min(self._pool_size, 56)
Edward Lesmes8e282792018-04-03 18:50:29 -0400180 self._messages = []
181 self._messages_lock = threading.Lock()
182 self._tests = []
183 self._tests_lock = threading.Lock()
184 self._nonparallel_tests = []
185
Edward Lemurecc27072020-01-06 16:42:34 +0000186 def _GetCommand(self, test):
Edward Lemur940c2822019-08-23 00:34:25 +0000187 vpython = 'vpython'
188 if test.python3:
189 vpython += '3'
190 if sys.platform == 'win32':
191 vpython += '.bat'
Edward Lesmes8e282792018-04-03 18:50:29 -0400192
193 cmd = test.cmd
194 if cmd[0] == 'python':
195 cmd = list(cmd)
196 cmd[0] = vpython
197 elif cmd[0].endswith('.py'):
198 cmd = [vpython] + cmd
199
Edward Lemur336e51f2019-11-14 21:42:04 +0000200 # On Windows, scripts on the current directory take precedence over PATH, so
201 # that when testing depot_tools on Windows, calling `vpython.bat` will
202 # execute the copy of vpython of the depot_tools under test instead of the
203 # one in the bot.
204 # As a workaround, we run the tests from the parent directory instead.
205 if (cmd[0] == vpython and
206 'cwd' in test.kwargs and
207 os.path.basename(test.kwargs['cwd']) == 'depot_tools'):
208 test.kwargs['cwd'] = os.path.dirname(test.kwargs['cwd'])
209 cmd[1] = os.path.join('depot_tools', cmd[1])
210
Edward Lemurecc27072020-01-06 16:42:34 +0000211 return cmd
212
213 def _RunWithTimeout(self, cmd, stdin, kwargs):
214 p = subprocess.Popen(cmd, **kwargs)
215 with Timer(self.timeout, p.terminate) as timer:
216 stdout, _ = sigint_handler.wait(p, stdin)
Josip Sokcevic6635baf2021-11-19 02:04:39 +0000217 stdout = stdout.decode('utf-8', 'ignore')
Edward Lemurecc27072020-01-06 16:42:34 +0000218 if timer.completed:
219 stdout = 'Process timed out after %ss\n%s' % (self.timeout, stdout)
Josip Sokcevic6635baf2021-11-19 02:04:39 +0000220 return p.returncode, stdout
Edward Lemurecc27072020-01-06 16:42:34 +0000221
222 def CallCommand(self, test):
223 """Runs an external program.
224
Edward Lemura5799e32020-01-17 19:26:51 +0000225 This function converts invocation of .py files and invocations of 'python'
Edward Lemurecc27072020-01-06 16:42:34 +0000226 to vpython invocations.
227 """
228 cmd = self._GetCommand(test)
Edward Lesmes8e282792018-04-03 18:50:29 -0400229 try:
Edward Lemurecc27072020-01-06 16:42:34 +0000230 start = time_time()
231 returncode, stdout = self._RunWithTimeout(cmd, test.stdin, test.kwargs)
232 duration = time_time() - start
Edward Lemur7cf94382019-11-15 22:36:41 +0000233 except Exception:
Edward Lemurecc27072020-01-06 16:42:34 +0000234 duration = time_time() - start
Edward Lesmes8e282792018-04-03 18:50:29 -0400235 return test.message(
Edward Lemur7cf94382019-11-15 22:36:41 +0000236 '%s\n%s exec failure (%4.2fs)\n%s' % (
237 test.name, ' '.join(cmd), duration, traceback.format_exc()))
Edward Lemurde9e3ca2019-10-24 21:13:31 +0000238
Edward Lemurecc27072020-01-06 16:42:34 +0000239 if returncode != 0:
Edward Lesmes8e282792018-04-03 18:50:29 -0400240 return test.message(
Edward Lemur7cf94382019-11-15 22:36:41 +0000241 '%s\n%s (%4.2fs) failed\n%s' % (
242 test.name, ' '.join(cmd), duration, stdout))
Edward Lemurecc27072020-01-06 16:42:34 +0000243
Edward Lesmes8e282792018-04-03 18:50:29 -0400244 if test.info:
Edward Lemur7cf94382019-11-15 22:36:41 +0000245 return test.info('%s\n%s (%4.2fs)' % (test.name, ' '.join(cmd), duration))
Edward Lesmes8e282792018-04-03 18:50:29 -0400246
247 def AddTests(self, tests, parallel=True):
248 if parallel:
249 self._tests.extend(tests)
250 else:
251 self._nonparallel_tests.extend(tests)
252
253 def RunAsync(self):
254 self._messages = []
255
256 def _WorkerFn():
257 while True:
258 test = None
259 with self._tests_lock:
260 if not self._tests:
261 break
262 test = self._tests.pop()
263 result = self.CallCommand(test)
264 if result:
265 with self._messages_lock:
266 self._messages.append(result)
267
268 def _StartDaemon():
269 t = threading.Thread(target=_WorkerFn)
270 t.daemon = True
271 t.start()
272 return t
273
274 while self._nonparallel_tests:
275 test = self._nonparallel_tests.pop()
276 result = self.CallCommand(test)
277 if result:
278 self._messages.append(result)
279
280 if self._tests:
281 threads = [_StartDaemon() for _ in range(self._pool_size)]
282 for worker in threads:
283 worker.join()
284
285 return self._messages
286
287
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000288def normpath(path):
289 '''Version of os.path.normpath that also changes backward slashes to
290 forward slashes when not running on Windows.
291 '''
292 # This is safe to always do because the Windows version of os.path.normpath
293 # will replace forward slashes with backward slashes.
294 path = path.replace(os.sep, '/')
295 return os.path.normpath(path)
296
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000297
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000298def _RightHandSideLinesImpl(affected_files):
299 """Implements RightHandSideLines for InputApi and GclChange."""
300 for af in affected_files:
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000301 lines = af.ChangedContents()
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000302 for line in lines:
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000303 yield (af, line[0], line[1])
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000304
305
Edward Lemur6eb1d322020-02-27 22:20:15 +0000306def prompt_should_continue(prompt_string):
307 sys.stdout.write(prompt_string)
Dirk Pranke7288f882021-06-03 18:01:30 +0000308 sys.stdout.flush()
Edward Lemur6eb1d322020-02-27 22:20:15 +0000309 response = sys.stdin.readline().strip().lower()
310 return response in ('y', 'yes')
dpranke@chromium.org5ac21012011-03-16 02:58:25 +0000311
312
Josip Sokcevice293d3d2022-02-16 22:52:15 +0000313def _ShouldRunPresubmit(script_text, use_python3):
314 """Try to figure out whether these presubmit checks should be run under
315 python2 or python3. We need to do this without actually trying to
316 compile the text, since the text might compile in one but not the
317 other.
318
319 Args:
320 script_text: The text of the presubmit script.
321 use_python3: if true, will use python3 instead of python2 by default
322 if USE_PYTHON3 is not specified.
323
324 Return:
325 A boolean if presubmit should be executed
326 """
327 m = re.search('^USE_PYTHON3 = (True|False)$', script_text, flags=re.MULTILINE)
328 if m:
329 use_python3 = m.group(1) == 'True'
330
331 return ((sys.version_info.major == 2) and not use_python3) or \
332 ((sys.version_info.major == 3) and use_python3)
333
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000334# Top level object so multiprocessing can pickle
335# Public access through OutputApi object.
336class _PresubmitResult(object):
337 """Base class for result objects."""
338 fatal = False
339 should_prompt = False
340
341 def __init__(self, message, items=None, long_text=''):
342 """
343 message: A short one-line message to indicate errors.
344 items: A list of short strings to indicate where errors occurred.
345 long_text: multi-line text output, e.g. from another tool
346 """
Bruce Dawsondb8622b2022-04-03 15:38:12 +0000347 self._message = _PresubmitResult._ensure_str(message)
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000348 self._items = items or []
Tom McKee61c72652021-07-20 11:56:32 +0000349 self._long_text = _PresubmitResult._ensure_str(long_text.rstrip())
Bruce Dawsondca14bc2022-09-15 20:59:38 +0000350 if _SHOW_CALLSTACKS:
351 self._long_text += 'Presubmit result call stack is:\n'
352 self._long_text += ''.join(traceback.format_stack(None, 8))
Tom McKee61c72652021-07-20 11:56:32 +0000353
354 @staticmethod
355 def _ensure_str(val):
356 """
357 val: A "stringish" value. Can be any of str, unicode or bytes.
358 returns: A str after applying encoding/decoding as needed.
359 Assumes/uses UTF-8 for relevant inputs/outputs.
360
361 We'd prefer to use six.ensure_str but our copy of six is old :(
362 """
363 if isinstance(val, str):
364 return val
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +0000365
Tom McKee61c72652021-07-20 11:56:32 +0000366 if six.PY2 and isinstance(val, unicode):
367 return val.encode()
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +0000368
369 if six.PY3 and isinstance(val, bytes):
Tom McKee61c72652021-07-20 11:56:32 +0000370 return val.decode()
371 raise ValueError("Unknown string type %s" % type(val))
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000372
Edward Lemur6eb1d322020-02-27 22:20:15 +0000373 def handle(self):
374 sys.stdout.write(self._message)
375 sys.stdout.write('\n')
Takuto Ikutabaa7be02022-08-23 00:19:34 +0000376 for item in self._items:
Edward Lemur6eb1d322020-02-27 22:20:15 +0000377 sys.stdout.write(' ')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000378 # Write separately in case it's unicode.
Edward Lemur6eb1d322020-02-27 22:20:15 +0000379 sys.stdout.write(str(item))
Edward Lemur6eb1d322020-02-27 22:20:15 +0000380 sys.stdout.write('\n')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000381 if self._long_text:
Edward Lemur6eb1d322020-02-27 22:20:15 +0000382 sys.stdout.write('\n***************\n')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000383 # Write separately in case it's unicode.
Tom McKee61c72652021-07-20 11:56:32 +0000384 sys.stdout.write(self._long_text)
Edward Lemur6eb1d322020-02-27 22:20:15 +0000385 sys.stdout.write('\n***************\n')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000386
Debrian Figueroadd2737e2019-06-21 23:50:13 +0000387 def json_format(self):
388 return {
389 'message': self._message,
Debrian Figueroa6095d402019-06-28 18:47:18 +0000390 'items': [str(item) for item in self._items],
Debrian Figueroadd2737e2019-06-21 23:50:13 +0000391 'long_text': self._long_text,
392 'fatal': self.fatal
393 }
394
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000395
396# Top level object so multiprocessing can pickle
397# Public access through OutputApi object.
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000398class _PresubmitError(_PresubmitResult):
399 """A hard presubmit error."""
400 fatal = True
401
402
403# Top level object so multiprocessing can pickle
404# Public access through OutputApi object.
405class _PresubmitPromptWarning(_PresubmitResult):
406 """An warning that prompts the user if they want to continue."""
407 should_prompt = True
408
409
410# Top level object so multiprocessing can pickle
411# Public access through OutputApi object.
412class _PresubmitNotifyResult(_PresubmitResult):
413 """Just print something to the screen -- but it's not even a warning."""
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000414
415
416# Top level object so multiprocessing can pickle
417# Public access through OutputApi object.
418class _MailTextResult(_PresubmitResult):
419 """A warning that should be included in the review request email."""
420 def __init__(self, *args, **kwargs):
421 super(_MailTextResult, self).__init__()
422 raise NotImplementedError()
423
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000424class GerritAccessor(object):
425 """Limited Gerrit functionality for canned presubmit checks to work.
426
427 To avoid excessive Gerrit calls, caches the results.
428 """
429
Edward Lesmeseb1bd622021-03-01 19:54:07 +0000430 def __init__(self, url=None, project=None, branch=None):
431 self.host = urlparse.urlparse(url).netloc if url else None
432 self.project = project
433 self.branch = branch
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000434 self.cache = {}
Edward Lesmes8170c292021-03-19 20:04:43 +0000435 self.code_owners_enabled = None
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000436
437 def _FetchChangeDetail(self, issue):
438 # Separate function to be easily mocked in tests.
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +0100439 try:
440 return gerrit_util.GetChangeDetail(
441 self.host, str(issue),
Aaron Gable6f5a8d92017-04-18 14:49:05 -0700442 ['ALL_REVISIONS', 'DETAILED_LABELS', 'ALL_COMMITS'])
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +0100443 except gerrit_util.GerritError as e:
444 if e.http_status == 404:
445 raise Exception('Either Gerrit issue %s doesn\'t exist, or '
446 'no credentials to fetch issue details' % issue)
447 raise
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000448
449 def GetChangeInfo(self, issue):
450 """Returns labels and all revisions (patchsets) for this issue.
451
452 The result is a dictionary according to Gerrit REST Api.
453 https://gerrit-review.googlesource.com/Documentation/rest-api.html
454
455 However, API isn't very clear what's inside, so see tests for example.
456 """
457 assert issue
458 cache_key = int(issue)
459 if cache_key not in self.cache:
460 self.cache[cache_key] = self._FetchChangeDetail(issue)
461 return self.cache[cache_key]
462
463 def GetChangeDescription(self, issue, patchset=None):
464 """If patchset is none, fetches current patchset."""
465 info = self.GetChangeInfo(issue)
466 # info is a reference to cache. We'll modify it here adding description to
467 # it to the right patchset, if it is not yet there.
468
469 # Find revision info for the patchset we want.
470 if patchset is not None:
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +0000471 for rev, rev_info in info['revisions'].items():
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000472 if str(rev_info['_number']) == str(patchset):
473 break
474 else:
475 raise Exception('patchset %s doesn\'t exist in issue %s' % (
476 patchset, issue))
477 else:
478 rev = info['current_revision']
479 rev_info = info['revisions'][rev]
480
Andrii Shyshkalov9c3a4642017-01-24 17:41:22 +0100481 return rev_info['commit']['message']
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000482
Mun Yong Jang603d01e2017-12-19 16:38:30 -0800483 def GetDestRef(self, issue):
484 ref = self.GetChangeInfo(issue)['branch']
485 if not ref.startswith('refs/'):
486 # NOTE: it is possible to create 'refs/x' branch,
487 # aka 'refs/heads/refs/x'. However, this is ill-advised.
488 ref = 'refs/heads/%s' % ref
489 return ref
490
Edward Lesmes02d4b822020-11-11 00:37:35 +0000491 def _GetApproversForLabel(self, issue, label):
492 change_info = self.GetChangeInfo(issue)
493 label_info = change_info.get('labels', {}).get(label, {})
494 values = label_info.get('values', {}).keys()
495 if not values:
496 return []
497 max_value = max(int(v) for v in values)
498 return [v for v in label_info.get('all', [])
499 if v.get('value', 0) == max_value]
500
Edward Lesmesc4566172021-03-19 16:55:13 +0000501 def IsBotCommitApproved(self, issue):
502 return bool(self._GetApproversForLabel(issue, 'Bot-Commit'))
503
Edward Lesmescf49cb82020-11-11 01:08:36 +0000504 def IsOwnersOverrideApproved(self, issue):
505 return bool(self._GetApproversForLabel(issue, 'Owners-Override'))
506
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000507 def GetChangeOwner(self, issue):
508 return self.GetChangeInfo(issue)['owner']['email']
509
510 def GetChangeReviewers(self, issue, approving_only=True):
Aaron Gable8b478f02017-07-31 15:33:19 -0700511 changeinfo = self.GetChangeInfo(issue)
512 if approving_only:
Edward Lesmes02d4b822020-11-11 00:37:35 +0000513 reviewers = self._GetApproversForLabel(issue, 'Code-Review')
Aaron Gable8b478f02017-07-31 15:33:19 -0700514 else:
515 reviewers = changeinfo.get('reviewers', {}).get('REVIEWER', [])
516 return [r.get('email') for r in reviewers]
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000517
Edward Lemure4d329c2020-02-03 20:41:18 +0000518 def UpdateDescription(self, description, issue):
519 gerrit_util.SetCommitMessage(self.host, issue, description, notify='NONE')
520
Edward Lesmes8170c292021-03-19 20:04:43 +0000521 def IsCodeOwnersEnabledOnRepo(self):
522 if self.code_owners_enabled is None:
523 self.code_owners_enabled = gerrit_util.IsCodeOwnersEnabledOnRepo(
Edward Lesmes392c4072021-03-19 21:58:45 +0000524 self.host, self.project)
Edward Lesmes8170c292021-03-19 20:04:43 +0000525 return self.code_owners_enabled
526
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000527
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000528class OutputApi(object):
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000529 """An instance of OutputApi gets passed to presubmit scripts so that they
530 can output various types of results.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000531 """
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000532 PresubmitResult = _PresubmitResult
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000533 PresubmitError = _PresubmitError
534 PresubmitPromptWarning = _PresubmitPromptWarning
535 PresubmitNotifyResult = _PresubmitNotifyResult
536 MailTextResult = _MailTextResult
537
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000538 def __init__(self, is_committing):
539 self.is_committing = is_committing
Daniel Cheng7227d212017-11-17 08:12:37 -0800540 self.more_cc = []
541
542 def AppendCC(self, cc):
543 """Appends a user to cc for this change."""
544 self.more_cc.append(cc)
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000545
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000546 def PresubmitPromptOrNotify(self, *args, **kwargs):
547 """Warn the user when uploading, but only notify if committing."""
548 if self.is_committing:
549 return self.PresubmitNotifyResult(*args, **kwargs)
550 return self.PresubmitPromptWarning(*args, **kwargs)
551
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000552
553class InputApi(object):
554 """An instance of this object is passed to presubmit scripts so they can
555 know stuff about the change they're looking at.
556 """
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000557 # Method could be a function
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800558 # pylint: disable=no-self-use
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000559
maruel@chromium.org3410d912009-06-09 20:56:16 +0000560 # File extensions that are considered source files from a style guide
561 # perspective. Don't modify this list from a presubmit script!
maruel@chromium.orgc33455a2011-06-24 19:14:18 +0000562 #
563 # Files without an extension aren't included in the list. If you want to
local_bot30f774e2020-06-25 18:23:34 +0000564 # filter them as source files, add r'(^|.*?[\\\/])[^.]+$' to the allow list.
local_bot64021412020-07-08 21:05:39 +0000565 # Note that ALL CAPS files are skipped in DEFAULT_FILES_TO_SKIP below.
566 DEFAULT_FILES_TO_CHECK = (
maruel@chromium.org3410d912009-06-09 20:56:16 +0000567 # C++ and friends
Edward Lemura5799e32020-01-17 19:26:51 +0000568 r'.+\.c$', r'.+\.cc$', r'.+\.cpp$', r'.+\.h$', r'.+\.m$', r'.+\.mm$',
569 r'.+\.inl$', r'.+\.asm$', r'.+\.hxx$', r'.+\.hpp$', r'.+\.s$', r'.+\.S$',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000570 # Scripts
dpapad443d9132022-05-05 00:17:30 +0000571 r'.+\.js$', r'.+\.ts$', r'.+\.py$', r'.+\.sh$', r'.+\.rb$', r'.+\.pl$',
572 r'.+\.pm$',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000573 # Other
Edward Lemura5799e32020-01-17 19:26:51 +0000574 r'.+\.java$', r'.+\.mk$', r'.+\.am$', r'.+\.css$', r'.+\.mojom$',
575 r'.+\.fidl$'
maruel@chromium.org3410d912009-06-09 20:56:16 +0000576 )
577
578 # Path regexp that should be excluded from being considered containing source
579 # files. Don't modify this list from a presubmit script!
local_bot64021412020-07-08 21:05:39 +0000580 DEFAULT_FILES_TO_SKIP = (
Edward Lemura5799e32020-01-17 19:26:51 +0000581 r'testing_support[\\\/]google_appengine[\\\/].*',
582 r'.*\bexperimental[\\\/].*',
Kent Tamura179dd1e2018-04-26 15:07:41 +0900583 # Exclude third_party/.* but NOT third_party/{WebKit,blink}
584 # (crbug.com/539768 and crbug.com/836555).
Edward Lemura5799e32020-01-17 19:26:51 +0000585 r'.*\bthird_party[\\\/](?!(WebKit|blink)[\\\/]).*',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000586 # Output directories (just in case)
Edward Lemura5799e32020-01-17 19:26:51 +0000587 r'.*\bDebug[\\\/].*',
588 r'.*\bRelease[\\\/].*',
589 r'.*\bxcodebuild[\\\/].*',
590 r'.*\bout[\\\/].*',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000591 # All caps files like README and LICENCE.
Edward Lemura5799e32020-01-17 19:26:51 +0000592 r'.*\b[A-Z0-9_]{2,}$',
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +0000593 # SCM (can happen in dual SCM configuration). (Slightly over aggressive)
Edward Lemura5799e32020-01-17 19:26:51 +0000594 r'(|.*[\\\/])\.git[\\\/].*',
595 r'(|.*[\\\/])\.svn[\\\/].*',
maruel@chromium.org7ccb4bb2011-11-07 20:26:20 +0000596 # There is no point in processing a patch file.
Edward Lemura5799e32020-01-17 19:26:51 +0000597 r'.+\.diff$',
598 r'.+\.patch$',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000599 )
600
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000601 def __init__(self, change, presubmit_path, is_committing,
Bruce Dawson09c0c072022-05-26 20:28:58 +0000602 verbose, gerrit_obj, dry_run=None, thread_pool=None, parallel=False,
603 no_diffs=False):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000604 """Builds an InputApi object.
605
606 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000607 change: A presubmit.Change object.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000608 presubmit_path: The path to the presubmit script being processed.
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000609 is_committing: True if the change is about to be committed.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000610 gerrit_obj: provides basic Gerrit codereview functionality.
611 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -0400612 parallel: if true, all tests reported via input_api.RunTests for all
613 PRESUBMIT files will be run in parallel.
Bruce Dawson09c0c072022-05-26 20:28:58 +0000614 no_diffs: if true, implies that --files or --all was specified so some
615 checks can be skipped, and some errors will be messages.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000616 """
maruel@chromium.org9711bba2009-05-22 23:51:39 +0000617 # Version number of the presubmit_support script.
618 self.version = [int(x) for x in __version__.split('.')]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000619 self.change = change
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000620 self.is_committing = is_committing
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000621 self.gerrit = gerrit_obj
tandrii@chromium.org57bafac2016-04-28 05:09:03 +0000622 self.dry_run = dry_run
Bruce Dawson09c0c072022-05-26 20:28:58 +0000623 self.no_diffs = no_diffs
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000624
Edward Lesmes8e282792018-04-03 18:50:29 -0400625 self.parallel = parallel
626 self.thread_pool = thread_pool or ThreadPool()
627
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000628 # We expose various modules and functions as attributes of the input_api
629 # so that presubmit scripts don't have to import them.
Takeshi Yoshino07a6bea2017-08-02 02:44:06 +0900630 self.ast = ast
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000631 self.basename = os.path.basename
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000632 self.cpplint = cpplint
dcheng091b7db2016-06-16 01:27:51 -0700633 self.fnmatch = fnmatch
Yoshisato Yanagisawa04600b42019-03-15 03:03:41 +0000634 self.gclient_paths = gclient_paths
Yoshisato Yanagisawa57dd17b2019-03-22 09:10:29 +0000635 # TODO(yyanagisawa): stop exposing this when python3 become default.
636 # Since python3's tempfile has TemporaryDirectory, we do not need this.
637 self.temporary_directory = gclient_utils.temporary_directory
dpranke@chromium.org17cc2442012-10-17 21:12:09 +0000638 self.glob = glob.glob
maruel@chromium.orgfb11c7b2010-03-18 18:22:14 +0000639 self.json = json
maruel@chromium.org6fba34d2011-06-02 13:45:12 +0000640 self.logging = logging.getLogger('PRESUBMIT')
maruel@chromium.org2b5ce562011-03-31 16:15:44 +0000641 self.os_listdir = os.listdir
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000642 self.os_path = os.path
pgervais@chromium.orgbd0cace2014-10-02 23:23:46 +0000643 self.os_stat = os.stat
Yoshisato Yanagisawa406de132018-06-29 05:43:25 +0000644 self.os_walk = os.walk
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000645 self.re = re
646 self.subprocess = subprocess
Edward Lemurb9830242019-10-30 22:19:20 +0000647 self.sys = sys
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000648 self.tempfile = tempfile
dpranke@chromium.org0d1bdea2011-03-24 22:54:38 +0000649 self.time = time
maruel@chromium.org1487d532009-06-06 00:22:57 +0000650 self.unittest = unittest
Edward Lemurb9830242019-10-30 22:19:20 +0000651 if sys.version_info.major == 2:
652 self.urllib2 = urllib2
Edward Lemur16af3562019-10-17 22:11:33 +0000653 self.urllib_request = urllib_request
654 self.urllib_error = urllib_error
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000655
Robert Iannucci50258932018-03-19 10:30:59 -0700656 self.is_windows = sys.platform == 'win32'
657
Edward Lemurb9646622019-10-25 20:57:35 +0000658 # Set python_executable to 'vpython' in order to allow scripts in other
659 # repos (e.g. src.git) to automatically pick up that repo's .vpython file,
660 # instead of inheriting the one in depot_tools.
661 self.python_executable = 'vpython'
Erik Staab69135d12021-05-14 22:31:57 +0000662 # Offer a python 3 executable for use during the migration off of python 2.
663 self.python3_executable = 'vpython3'
maruel@chromium.orgc0b22972009-06-25 16:19:14 +0000664 self.environ = os.environ
665
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000666 # InputApi.platform is the platform you're currently running on.
667 self.platform = sys.platform
668
iannucci@chromium.org0af3bb32015-06-12 20:44:35 +0000669 self.cpu_count = multiprocessing.cpu_count()
Bruce Dawson8254f062022-06-17 17:33:08 +0000670 if self.is_windows:
671 # TODO(crbug.com/1190269) - we can't use more than 56 child processes on
672 # Windows or Python3 may hang.
673 self.cpu_count = min(self.cpu_count, 56)
iannucci@chromium.org0af3bb32015-06-12 20:44:35 +0000674
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000675 # The local path of the currently-being-processed presubmit script.
maruel@chromium.org3d235242009-05-15 12:40:48 +0000676 self._current_presubmit_path = os.path.dirname(presubmit_path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000677
678 # We carry the canned checks so presubmit scripts can easily use them.
679 self.canned_checks = presubmit_canned_checks
680
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +0100681 # Temporary files we must manually remove at the end of a run.
682 self._named_temporary_files = []
Jochen Eisinger72606f82017-04-04 10:44:18 +0200683
Edward Lesmesdc11c6b2021-03-19 19:22:05 +0000684 self.owners_client = None
Bruce Dawsoneb8426e2022-08-05 23:58:15 +0000685 if self.gerrit and not 'PRESUBMIT_SKIP_NETWORK' in self.environ:
Bruce Dawson9b9f4512022-04-27 00:56:52 +0000686 try:
687 self.owners_client = owners_client.GetCodeOwnersClient(
Bruce Dawson9b9f4512022-04-27 00:56:52 +0000688 host=self.gerrit.host,
689 project=self.gerrit.project,
690 branch=self.gerrit.branch)
691 except Exception as e:
692 print('Failed to set owners_client - %s' % str(e))
Jochen Eisinger76f5fc62017-04-07 16:27:46 +0200693 self.owners_finder = owners_finder.OwnersFinder
maruel@chromium.org899e1c12011-04-07 17:03:18 +0000694 self.verbose = verbose
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000695 self.Command = CommandData
dpranke@chromium.org2a009622011-03-01 02:43:31 +0000696
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000697 # Replace <hash_map> and <hash_set> as headers that need to be included
Edward Lemura5799e32020-01-17 19:26:51 +0000698 # with 'base/containers/hash_tables.h' instead.
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000699 # Access to a protected member _XX of a client class
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800700 # pylint: disable=protected-access
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000701 self.cpplint._re_pattern_templates = [
danakj@chromium.org18278522013-06-11 22:42:32 +0000702 (a, b, 'base/containers/hash_tables.h')
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000703 if header in ('<hash_map>', '<hash_set>') else (a, b, header)
704 for (a, b, header) in cpplint._re_pattern_templates
705 ]
706
Edward Lemurecc27072020-01-06 16:42:34 +0000707 def SetTimeout(self, timeout):
708 self.thread_pool.timeout = timeout
709
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000710 def PresubmitLocalPath(self):
711 """Returns the local path of the presubmit script currently being run.
712
713 This is useful if you don't want to hard-code absolute paths in the
714 presubmit script. For example, It can be used to find another file
715 relative to the PRESUBMIT.py script, so the whole tree can be branched and
716 the presubmit script still works, without editing its content.
717 """
maruel@chromium.org3d235242009-05-15 12:40:48 +0000718 return self._current_presubmit_path
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000719
agable0b65e732016-11-22 09:25:46 -0800720 def AffectedFiles(self, include_deletes=True, file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000721 """Same as input_api.change.AffectedFiles() except only lists files
722 (and optionally directories) in the same directory as the current presubmit
Bruce Dawson7a0b07a2020-04-23 17:14:40 +0000723 script, or subdirectories thereof. Note that files are listed using the OS
724 path separator, so backslashes are used as separators on Windows.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000725 """
Bruce Dawson31bfd512022-05-10 23:19:39 +0000726 dir_with_slash = normpath(self.PresubmitLocalPath())
727 # normpath strips trailing path separators, so the trailing separator has to
728 # be added after the normpath call.
729 if len(dir_with_slash) > 0:
730 dir_with_slash += os.path.sep
sail@chromium.org5538e022011-05-12 17:53:16 +0000731
Edward Lemurb9830242019-10-30 22:19:20 +0000732 return list(filter(
maruel@chromium.org4661e0c2009-06-04 00:45:26 +0000733 lambda x: normpath(x.AbsoluteLocalPath()).startswith(dir_with_slash),
Edward Lemurb9830242019-10-30 22:19:20 +0000734 self.change.AffectedFiles(include_deletes, file_filter)))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000735
agable0b65e732016-11-22 09:25:46 -0800736 def LocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000737 """Returns local paths of input_api.AffectedFiles()."""
agable0b65e732016-11-22 09:25:46 -0800738 paths = [af.LocalPath() for af in self.AffectedFiles()]
Edward Lemura5799e32020-01-17 19:26:51 +0000739 logging.debug('LocalPaths: %s', paths)
pgervais@chromium.org2f64f782014-04-25 00:12:33 +0000740 return paths
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000741
agable0b65e732016-11-22 09:25:46 -0800742 def AbsoluteLocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000743 """Returns absolute local paths of input_api.AffectedFiles()."""
agable0b65e732016-11-22 09:25:46 -0800744 return [af.AbsoluteLocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000745
John Budorick16162372018-04-18 10:39:53 -0700746 def AffectedTestableFiles(self, include_deletes=None, **kwargs):
agable0b65e732016-11-22 09:25:46 -0800747 """Same as input_api.change.AffectedTestableFiles() except only lists files
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000748 in the same directory as the current presubmit script, or subdirectories
749 thereof.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000750 """
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000751 if include_deletes is not None:
Edward Lemura5799e32020-01-17 19:26:51 +0000752 warn('AffectedTestableFiles(include_deletes=%s)'
753 ' is deprecated and ignored' % str(include_deletes),
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000754 category=DeprecationWarning,
755 stacklevel=2)
Josip Sokcevic4de5dea2022-03-23 21:15:14 +0000756 # pylint: disable=consider-using-generator
757 return [
758 x for x in self.AffectedFiles(include_deletes=False, **kwargs)
759 if x.IsTestableFile()
760 ]
agable0b65e732016-11-22 09:25:46 -0800761
762 def AffectedTextFiles(self, include_deletes=None):
763 """An alias to AffectedTestableFiles for backwards compatibility."""
764 return self.AffectedTestableFiles(include_deletes=include_deletes)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000765
Josip Sokcevic8c955952021-02-01 21:32:57 +0000766 def FilterSourceFile(self,
767 affected_file,
768 files_to_check=None,
769 files_to_skip=None,
770 allow_list=None,
771 block_list=None):
Edward Lemura5799e32020-01-17 19:26:51 +0000772 """Filters out files that aren't considered 'source file'.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000773
local_bot64021412020-07-08 21:05:39 +0000774 If files_to_check or files_to_skip is None, InputApi.DEFAULT_FILES_TO_CHECK
775 and InputApi.DEFAULT_FILES_TO_SKIP is used respectively.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000776
Bruce Dawson635383f2022-09-13 16:23:18 +0000777 affected_file.LocalPath() needs to re.match an entry in the files_to_check
778 list and not re.match any entries in the files_to_skip list.
779 '/' path separators should be used in the regular expressions and will work
780 on Windows as well as other platforms.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000781
782 Note: Copy-paste this function to suit your needs or use a lambda function.
783 """
local_bot64021412020-07-08 21:05:39 +0000784 if files_to_check is None:
785 files_to_check = self.DEFAULT_FILES_TO_CHECK
786 if files_to_skip is None:
787 files_to_skip = self.DEFAULT_FILES_TO_SKIP
local_bot30f774e2020-06-25 18:23:34 +0000788
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000789 def Find(affected_file, items):
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000790 local_path = affected_file.LocalPath()
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000791 for item in items:
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +0000792 if self.re.match(item, local_path):
maruel@chromium.org3410d912009-06-09 20:56:16 +0000793 return True
Bruce Dawsona3a014e2022-04-27 23:28:17 +0000794 # Handle the cases where the files regex only handles /, but the local
795 # path uses \.
796 if self.is_windows and self.re.match(item, local_path.replace(
797 '\\', '/')):
798 return True
maruel@chromium.org3410d912009-06-09 20:56:16 +0000799 return False
local_bot64021412020-07-08 21:05:39 +0000800 return (Find(affected_file, files_to_check) and
801 not Find(affected_file, files_to_skip))
maruel@chromium.org3410d912009-06-09 20:56:16 +0000802
803 def AffectedSourceFiles(self, source_file):
agable0b65e732016-11-22 09:25:46 -0800804 """Filter the list of AffectedTestableFiles by the function source_file.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000805
806 If source_file is None, InputApi.FilterSourceFile() is used.
807 """
808 if not source_file:
809 source_file = self.FilterSourceFile
Edward Lemurb9830242019-10-30 22:19:20 +0000810 return list(filter(source_file, self.AffectedTestableFiles()))
maruel@chromium.org3410d912009-06-09 20:56:16 +0000811
812 def RightHandSideLines(self, source_file_filter=None):
Edward Lemura5799e32020-01-17 19:26:51 +0000813 """An iterator over all text lines in 'new' version of changed files.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000814
815 Only lists lines from new or modified text files in the change that are
816 contained by the directory of the currently executing presubmit script.
817
818 This is useful for doing line-by-line regex checks, like checking for
819 trailing whitespace.
820
821 Yields:
822 a 3 tuple:
823 the AffectedFile instance of the current file;
824 integer line number (1-based); and
825 the contents of the line as a string.
maruel@chromium.org1487d532009-06-06 00:22:57 +0000826
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000827 Note: The carriage return (LF or CR) is stripped off.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000828 """
maruel@chromium.org3410d912009-06-09 20:56:16 +0000829 files = self.AffectedSourceFiles(source_file_filter)
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000830 return _RightHandSideLinesImpl(files)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000831
maruel@chromium.orge3608df2009-11-10 20:22:57 +0000832 def ReadFile(self, file_item, mode='r'):
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000833 """Reads an arbitrary file.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000834
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000835 Deny reading anything outside the repository.
836 """
maruel@chromium.orge3608df2009-11-10 20:22:57 +0000837 if isinstance(file_item, AffectedFile):
838 file_item = file_item.AbsoluteLocalPath()
839 if not file_item.startswith(self.change.RepositoryRoot()):
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000840 raise IOError('Access outside the repository root is denied.')
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +0000841 return gclient_utils.FileRead(file_item, mode)
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000842
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +0100843 def CreateTemporaryFile(self, **kwargs):
844 """Returns a named temporary file that must be removed with a call to
845 RemoveTemporaryFiles().
846
847 All keyword arguments are forwarded to tempfile.NamedTemporaryFile(),
848 except for |delete|, which is always set to False.
849
850 Presubmit checks that need to create a temporary file and pass it for
851 reading should use this function instead of NamedTemporaryFile(), as
852 Windows fails to open a file that is already open for writing.
853
854 with input_api.CreateTemporaryFile() as f:
855 f.write('xyz')
856 f.close()
857 input_api.subprocess.check_output(['script-that', '--reads-from',
858 f.name])
859
860
861 Note that callers of CreateTemporaryFile() should not worry about removing
862 any temporary file; this is done transparently by the presubmit handling
863 code.
864 """
865 if 'delete' in kwargs:
866 # Prevent users from passing |delete|; we take care of file deletion
867 # ourselves and this prevents unintuitive error messages when we pass
868 # delete=False and 'delete' is also in kwargs.
869 raise TypeError('CreateTemporaryFile() does not take a "delete" '
870 'argument, file deletion is handled automatically by '
871 'the same presubmit_support code that creates InputApi '
872 'objects.')
873 temp_file = self.tempfile.NamedTemporaryFile(delete=False, **kwargs)
874 self._named_temporary_files.append(temp_file.name)
875 return temp_file
876
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000877 @property
878 def tbr(self):
879 """Returns if a change is TBR'ed."""
Jeremy Romandce22502017-06-20 15:37:29 -0400880 return 'TBR' in self.change.tags or self.change.TBRsFromDescription()
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000881
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +0000882 def RunTests(self, tests_mix, parallel=True):
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000883 tests = []
884 msgs = []
885 for t in tests_mix:
Edward Lesmes8e282792018-04-03 18:50:29 -0400886 if isinstance(t, OutputApi.PresubmitResult) and t:
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000887 msgs.append(t)
888 else:
889 assert issubclass(t.message, _PresubmitResult)
890 tests.append(t)
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +0000891 if self.verbose:
892 t.info = _PresubmitNotifyResult
Edward Lemur1037c742018-05-01 18:56:04 -0400893 if not t.kwargs.get('cwd'):
894 t.kwargs['cwd'] = self.PresubmitLocalPath()
Edward Lesmes8e282792018-04-03 18:50:29 -0400895 self.thread_pool.AddTests(tests, parallel)
Edward Lemur21000eb2019-05-24 23:25:58 +0000896 # When self.parallel is True (i.e. --parallel is passed as an option)
897 # RunTests doesn't actually run tests. It adds them to a ThreadPool that
898 # will run all tests once all PRESUBMIT files are processed.
899 # Otherwise, it will run them and return the results.
900 if not self.parallel:
Edward Lesmes8e282792018-04-03 18:50:29 -0400901 msgs.extend(self.thread_pool.RunAsync())
902 return msgs
scottmg86099d72016-09-01 09:16:51 -0700903
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000904
nick@chromium.orgff526192013-06-10 19:30:26 +0000905class _DiffCache(object):
906 """Caches diffs retrieved from a particular SCM."""
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000907 def __init__(self, upstream=None):
908 """Stores the upstream revision against which all diffs will be computed."""
909 self._upstream = upstream
nick@chromium.orgff526192013-06-10 19:30:26 +0000910
911 def GetDiff(self, path, local_root):
912 """Get the diff for a particular path."""
913 raise NotImplementedError()
914
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700915 def GetOldContents(self, path, local_root):
916 """Get the old version for a particular path."""
917 raise NotImplementedError()
918
nick@chromium.orgff526192013-06-10 19:30:26 +0000919
nick@chromium.orgff526192013-06-10 19:30:26 +0000920class _GitDiffCache(_DiffCache):
921 """DiffCache implementation for git; gets all file diffs at once."""
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000922 def __init__(self, upstream):
923 super(_GitDiffCache, self).__init__(upstream=upstream)
nick@chromium.orgff526192013-06-10 19:30:26 +0000924 self._diffs_by_file = None
925
926 def GetDiff(self, path, local_root):
Bruce Dawson5f63d3c2022-04-19 17:02:36 +0000927 # Compare against None to distinguish between None and an initialized but
928 # empty dictionary.
929 if self._diffs_by_file == None:
nick@chromium.orgff526192013-06-10 19:30:26 +0000930 # Compute a single diff for all files and parse the output; should
931 # with git this is much faster than computing one diff for each file.
932 diffs = {}
933
934 # Don't specify any filenames below, because there are command line length
935 # limits on some platforms and GenerateDiff would fail.
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000936 unified_diff = scm.GIT.GenerateDiff(local_root, files=[], full_move=True,
937 branch=self._upstream)
nick@chromium.orgff526192013-06-10 19:30:26 +0000938
939 # This regex matches the path twice, separated by a space. Note that
940 # filename itself may contain spaces.
941 file_marker = re.compile('^diff --git (?P<filename>.*) (?P=filename)$')
942 current_diff = []
943 keep_line_endings = True
944 for x in unified_diff.splitlines(keep_line_endings):
945 match = file_marker.match(x)
946 if match:
947 # Marks the start of a new per-file section.
948 diffs[match.group('filename')] = current_diff = [x]
949 elif x.startswith('diff --git'):
950 raise PresubmitFailure('Unexpected diff line: %s' % x)
951 else:
952 current_diff.append(x)
953
954 self._diffs_by_file = dict(
955 (normpath(path), ''.join(diff)) for path, diff in diffs.items())
956
957 if path not in self._diffs_by_file:
Josip Sokcevicc1ab7342022-02-24 19:02:44 +0000958 # SCM didn't have any diff on this file. It could be that the file was not
959 # modified at all (e.g. user used --all flag in git cl presubmit).
960 # Intead of failing, return empty string.
961 # See: https://crbug.com/808346.
Josip Sokcevicc1ab7342022-02-24 19:02:44 +0000962 return ''
nick@chromium.orgff526192013-06-10 19:30:26 +0000963
964 return self._diffs_by_file[path]
965
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700966 def GetOldContents(self, path, local_root):
967 return scm.GIT.GetOldContents(local_root, path, branch=self._upstream)
968
nick@chromium.orgff526192013-06-10 19:30:26 +0000969
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000970class AffectedFile(object):
971 """Representation of a file in a change."""
nick@chromium.orgff526192013-06-10 19:30:26 +0000972
973 DIFF_CACHE = _DiffCache
974
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000975 # Method could be a function
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800976 # pylint: disable=no-self-use
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000977 def __init__(self, path, action, repository_root, diff_cache):
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000978 self._path = path
979 self._action = action
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000980 self._local_root = repository_root
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000981 self._is_directory = None
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000982 self._cached_changed_contents = None
983 self._cached_new_contents = None
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000984 self._diff_cache = diff_cache
tobiasjs2836bcf2016-08-16 04:08:16 -0700985 logging.debug('%s(%s)', self.__class__.__name__, self._path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000986
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000987 def LocalPath(self):
988 """Returns the path of this file on the local disk relative to client root.
Andrew Grieve92b8b992017-11-02 09:42:24 -0400989
990 This should be used for error messages but not for accessing files,
991 because presubmit checks are run with CWD=PresubmitLocalPath() (which is
992 often != client root).
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000993 """
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000994 return normpath(self._path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000995
996 def AbsoluteLocalPath(self):
997 """Returns the absolute path of this file on the local disk.
998 """
chase@chromium.org8e416c82009-10-06 04:30:44 +0000999 return os.path.abspath(os.path.join(self._local_root, self.LocalPath()))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001000
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001001 def Action(self):
1002 """Returns the action on this opened file, e.g. A, M, D, etc."""
maruel@chromium.org15bdffa2009-05-29 11:16:29 +00001003 return self._action
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001004
agable0b65e732016-11-22 09:25:46 -08001005 def IsTestableFile(self):
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +00001006 """Returns True if the file is a text file and not a binary file.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +00001007
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +00001008 Deleted files are not text file."""
maruel@chromium.org1e08c002009-05-28 19:09:33 +00001009 raise NotImplementedError() # Implement when needed
1010
agable0b65e732016-11-22 09:25:46 -08001011 def IsTextFile(self):
1012 """An alias to IsTestableFile for backwards compatibility."""
1013 return self.IsTestableFile()
1014
Daniel Cheng7a1f04d2017-03-21 19:12:31 -07001015 def OldContents(self):
1016 """Returns an iterator over the lines in the old version of file.
1017
Daniel Cheng2da34fe2017-03-21 20:42:12 -07001018 The old version is the file before any modifications in the user's
Edward Lemura5799e32020-01-17 19:26:51 +00001019 workspace, i.e. the 'left hand side'.
Daniel Cheng7a1f04d2017-03-21 19:12:31 -07001020
1021 Contents will be empty if the file is a directory or does not exist.
1022 Note: The carriage returns (LF or CR) are stripped off.
1023 """
1024 return self._diff_cache.GetOldContents(self.LocalPath(),
1025 self._local_root).splitlines()
1026
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001027 def NewContents(self):
1028 """Returns an iterator over the lines in the new version of file.
1029
Edward Lemura5799e32020-01-17 19:26:51 +00001030 The new version is the file in the user's workspace, i.e. the 'right hand
1031 side'.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001032
1033 Contents will be empty if the file is a directory or does not exist.
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +00001034 Note: The carriage returns (LF or CR) are stripped off.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001035 """
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +00001036 if self._cached_new_contents is None:
1037 self._cached_new_contents = []
agable0b65e732016-11-22 09:25:46 -08001038 try:
1039 self._cached_new_contents = gclient_utils.FileRead(
1040 self.AbsoluteLocalPath(), 'rU').splitlines()
1041 except IOError:
1042 pass # File not found? That's fine; maybe it was deleted.
Greg Thompson30cde452021-06-01 16:38:47 +00001043 except UnicodeDecodeError as e:
Dirk Pranke6fc394f2021-05-26 23:25:14 +00001044 # log the filename since we're probably trying to read a binary
1045 # file, and shouldn't be.
1046 print('Error reading %s: %s' % (self.AbsoluteLocalPath(), e))
1047 raise
1048
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +00001049 return self._cached_new_contents[:]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001050
Bruce Dawsonf0bcfdd2021-05-21 18:10:23 +00001051 def ChangedContents(self, keeplinebreaks=False):
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001052 """Returns a list of tuples (line number, line text) of all new lines.
1053
1054 This relies on the scm diff output describing each changed code section
1055 with a line of the form
1056
1057 ^@@ <old line num>,<old size> <new line num>,<new size> @@$
1058 """
Bruce Dawsonf0bcfdd2021-05-21 18:10:23 +00001059 # Don't return cached results when line breaks are requested.
1060 if not keeplinebreaks and self._cached_changed_contents is not None:
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +00001061 return self._cached_changed_contents[:]
Bruce Dawsonf0bcfdd2021-05-21 18:10:23 +00001062 result = []
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001063 line_num = 0
1064
Bruce Dawsonf0bcfdd2021-05-21 18:10:23 +00001065 # The keeplinebreaks parameter to splitlines must be True or else the
1066 # CheckForWindowsLineEndings presubmit will be a NOP.
1067 for line in self.GenerateScmDiff().splitlines(keeplinebreaks):
Edward Lemurac5c55f2020-02-29 00:17:16 +00001068 m = re.match(r'^@@ [0-9\,\+\-]+ \+([0-9]+)\,[0-9]+ @@', line)
1069 if m:
1070 line_num = int(m.groups(1)[0])
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001071 continue
1072 if line.startswith('+') and not line.startswith('++'):
Bruce Dawsonf0bcfdd2021-05-21 18:10:23 +00001073 result.append((line_num, line[1:]))
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001074 if not line.startswith('-'):
1075 line_num += 1
Bruce Dawsonf0bcfdd2021-05-21 18:10:23 +00001076 # Don't cache results with line breaks.
1077 if keeplinebreaks:
1078 return result;
1079 self._cached_changed_contents = result
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +00001080 return self._cached_changed_contents[:]
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001081
maruel@chromium.org5de13972009-06-10 18:16:06 +00001082 def __str__(self):
1083 return self.LocalPath()
1084
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001085 def GenerateScmDiff(self):
nick@chromium.orgff526192013-06-10 19:30:26 +00001086 return self._diff_cache.GetDiff(self.LocalPath(), self._local_root)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001087
maruel@chromium.org58407af2011-04-12 23:15:57 +00001088
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001089class GitAffectedFile(AffectedFile):
1090 """Representation of a file in a change out of a git checkout."""
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +00001091 # Method 'NNN' is abstract in class 'NNN' but is not overridden
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -08001092 # pylint: disable=abstract-method
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001093
nick@chromium.orgff526192013-06-10 19:30:26 +00001094 DIFF_CACHE = _GitDiffCache
1095
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001096 def __init__(self, *args, **kwargs):
1097 AffectedFile.__init__(self, *args, **kwargs)
1098 self._server_path = None
agable0b65e732016-11-22 09:25:46 -08001099 self._is_testable_file = None
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001100
agable0b65e732016-11-22 09:25:46 -08001101 def IsTestableFile(self):
1102 if self._is_testable_file is None:
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001103 if self.Action() == 'D':
agable0b65e732016-11-22 09:25:46 -08001104 # A deleted file is not testable.
1105 self._is_testable_file = False
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001106 else:
agable0b65e732016-11-22 09:25:46 -08001107 self._is_testable_file = os.path.isfile(self.AbsoluteLocalPath())
1108 return self._is_testable_file
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001109
maruel@chromium.orgc1938752011-04-12 23:11:13 +00001110
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001111class Change(object):
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001112 """Describe a change.
1113
1114 Used directly by the presubmit scripts to query the current change being
1115 tested.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +00001116
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001117 Instance members:
nick@chromium.orgff526192013-06-10 19:30:26 +00001118 tags: Dictionary of KEY=VALUE pairs found in the change description.
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001119 self.KEY: equivalent to tags['KEY']
1120 """
1121
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001122 _AFFECTED_FILES = AffectedFile
1123
Edward Lemura5799e32020-01-17 19:26:51 +00001124 # Matches key/value (or 'tag') lines in changelist descriptions.
maruel@chromium.org428342a2011-11-10 15:46:33 +00001125 TAG_LINE_RE = re.compile(
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001126 '^[ \t]*(?P<key>[A-Z][A-Z_0-9]*)[ \t]*=[ \t]*(?P<value>.*?)[ \t]*$')
maruel@chromium.orgc1938752011-04-12 23:11:13 +00001127 scm = ''
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001128
maruel@chromium.org58407af2011-04-12 23:15:57 +00001129 def __init__(
agable@chromium.orgea84ef12014-04-30 19:55:12 +00001130 self, name, description, local_root, files, issue, patchset, author,
1131 upstream=None):
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001132 if files is None:
1133 files = []
1134 self._name = name
chase@chromium.org8e416c82009-10-06 04:30:44 +00001135 # Convert root into an absolute path.
1136 self._local_root = os.path.abspath(local_root)
agable@chromium.orgea84ef12014-04-30 19:55:12 +00001137 self._upstream = upstream
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001138 self.issue = issue
1139 self.patchset = patchset
maruel@chromium.org58407af2011-04-12 23:15:57 +00001140 self.author_email = author
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001141
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001142 self._full_description = ''
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001143 self.tags = {}
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001144 self._description_without_tags = ''
1145 self.SetDescriptionText(description)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001146
maruel@chromium.orge085d812011-10-10 19:49:15 +00001147 assert all(
1148 (isinstance(f, (list, tuple)) and len(f) == 2) for f in files), files
1149
agable@chromium.orgea84ef12014-04-30 19:55:12 +00001150 diff_cache = self._AFFECTED_FILES.DIFF_CACHE(self._upstream)
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001151 self._affected_files = [
nick@chromium.orgff526192013-06-10 19:30:26 +00001152 self._AFFECTED_FILES(path, action.strip(), self._local_root, diff_cache)
1153 for action, path in files
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +00001154 ]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001155
Edward Lesmes9ce03f82021-01-12 20:13:31 +00001156 def UpstreamBranch(self):
1157 """Returns the upstream branch for the change."""
1158 return self._upstream
1159
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001160 def Name(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001161 """Returns the change name."""
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001162 return self._name
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001163
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001164 def DescriptionText(self):
1165 """Returns the user-entered changelist description, minus tags.
1166
Edward Lemura5799e32020-01-17 19:26:51 +00001167 Any line in the user-provided description starting with e.g. 'FOO='
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001168 (whitespace permitted before and around) is considered a tag line. Such
1169 lines are stripped out of the description this function returns.
1170 """
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001171 return self._description_without_tags
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001172
1173 def FullDescriptionText(self):
1174 """Returns the complete changelist description including tags."""
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001175 return self._full_description
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001176
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001177 def SetDescriptionText(self, description):
1178 """Sets the full description text (including tags) to |description|.
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001179
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001180 Also updates the list of tags."""
1181 self._full_description = description
1182
1183 # From the description text, build up a dictionary of key/value pairs
Edward Lemura5799e32020-01-17 19:26:51 +00001184 # plus the description minus all key/value or 'tag' lines.
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001185 description_without_tags = []
1186 self.tags = {}
1187 for line in self._full_description.splitlines():
1188 m = self.TAG_LINE_RE.match(line)
1189 if m:
1190 self.tags[m.group('key')] = m.group('value')
1191 else:
1192 description_without_tags.append(line)
1193
1194 # Change back to text and remove whitespace at end.
1195 self._description_without_tags = (
1196 '\n'.join(description_without_tags).rstrip())
1197
Edward Lemur69bb8be2020-02-03 20:37:38 +00001198 def AddDescriptionFooter(self, key, value):
1199 """Adds the given footer to the change description.
1200
1201 Args:
1202 key: A string with the key for the git footer. It must conform to
1203 the git footers format (i.e. 'List-Of-Tokens') and will be case
1204 normalized so that each token is title-cased.
1205 value: A string with the value for the git footer.
1206 """
1207 description = git_footers.add_footer(
1208 self.FullDescriptionText(), git_footers.normalize_name(key), value)
1209 self.SetDescriptionText(description)
1210
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001211 def RepositoryRoot(self):
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001212 """Returns the repository (checkout) root directory for this change,
1213 as an absolute path.
1214 """
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001215 return self._local_root
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001216
1217 def __getattr__(self, attr):
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001218 """Return tags directly as attributes on the object."""
Edward Lemura5799e32020-01-17 19:26:51 +00001219 if not re.match(r'^[A-Z_]*$', attr):
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001220 raise AttributeError(self, attr)
maruel@chromium.orge1a524f2009-05-27 14:43:46 +00001221 return self.tags.get(attr)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001222
Edward Lemur69bb8be2020-02-03 20:37:38 +00001223 def GitFootersFromDescription(self):
1224 """Return the git footers present in the description.
1225
1226 Returns:
1227 footers: A dict of {footer: [values]} containing a multimap of the footers
1228 in the change description.
1229 """
1230 return git_footers.parse_footers(self.FullDescriptionText())
1231
Aaron Gablefc03e672017-05-15 14:09:42 -07001232 def BugsFromDescription(self):
1233 """Returns all bugs referenced in the commit description."""
Sean McAllister1e509c52021-10-25 17:54:25 +00001234 bug_tags = ['BUG', 'FIXED']
1235
1236 tags = []
1237 for tag in bug_tags:
1238 values = self.tags.get(tag)
1239 if values:
1240 tags += [value.strip() for value in values.split(',')]
1241
Caleb Rouleauc0546b92019-02-22 06:12:57 +00001242 footers = []
Edward Lemur69bb8be2020-02-03 20:37:38 +00001243 parsed = self.GitFootersFromDescription()
Dan Beam62954042019-10-03 21:20:33 +00001244 unsplit_footers = parsed.get('Bug', []) + parsed.get('Fixed', [])
Caleb Rouleauc0546b92019-02-22 06:12:57 +00001245 for unsplit_footer in unsplit_footers:
1246 footers += [b.strip() for b in unsplit_footer.split(',')]
Aaron Gable12ef5012017-05-15 14:29:00 -07001247 return sorted(set(tags + footers))
Aaron Gablefc03e672017-05-15 14:09:42 -07001248
1249 def ReviewersFromDescription(self):
1250 """Returns all reviewers listed in the commit description."""
Edward Lemura5799e32020-01-17 19:26:51 +00001251 # We don't support a 'R:' git-footer for reviewers; that is in metadata.
Aaron Gable12ef5012017-05-15 14:29:00 -07001252 tags = [r.strip() for r in self.tags.get('R', '').split(',') if r.strip()]
1253 return sorted(set(tags))
Aaron Gablefc03e672017-05-15 14:09:42 -07001254
1255 def TBRsFromDescription(self):
1256 """Returns all TBR reviewers listed in the commit description."""
Aaron Gable12ef5012017-05-15 14:29:00 -07001257 tags = [r.strip() for r in self.tags.get('TBR', '').split(',') if r.strip()]
Aaron Gable6e7ddb62020-05-27 22:23:29 +00001258 # TODO(crbug.com/839208): Remove support for 'Tbr:' when TBRs are
1259 # programmatically determined by self-CR+1s.
Edward Lemur69bb8be2020-02-03 20:37:38 +00001260 footers = self.GitFootersFromDescription().get('Tbr', [])
Aaron Gable12ef5012017-05-15 14:29:00 -07001261 return sorted(set(tags + footers))
Aaron Gablefc03e672017-05-15 14:09:42 -07001262
Aaron Gable6e7ddb62020-05-27 22:23:29 +00001263 # TODO(crbug.com/753425): Delete these once we're sure they're unused.
Aaron Gablefc03e672017-05-15 14:09:42 -07001264 @property
1265 def BUG(self):
1266 return ','.join(self.BugsFromDescription())
1267 @property
1268 def R(self):
1269 return ','.join(self.ReviewersFromDescription())
1270 @property
1271 def TBR(self):
1272 return ','.join(self.TBRsFromDescription())
1273
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001274 def AllFiles(self, root=None):
1275 """List all files under source control in the repo."""
1276 raise NotImplementedError()
1277
agable0b65e732016-11-22 09:25:46 -08001278 def AffectedFiles(self, include_deletes=True, file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001279 """Returns a list of AffectedFile instances for all files in the change.
1280
1281 Args:
1282 include_deletes: If false, deleted files will be filtered out.
sail@chromium.org5538e022011-05-12 17:53:16 +00001283 file_filter: An additional filter to apply.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001284
1285 Returns:
1286 [AffectedFile(path, action), AffectedFile(path, action)]
1287 """
Edward Lemurb9830242019-10-30 22:19:20 +00001288 affected = list(filter(file_filter, self._affected_files))
sail@chromium.org5538e022011-05-12 17:53:16 +00001289
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001290 if include_deletes:
1291 return affected
Edward Lemurb9830242019-10-30 22:19:20 +00001292 return list(filter(lambda x: x.Action() != 'D', affected))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001293
John Budorick16162372018-04-18 10:39:53 -07001294 def AffectedTestableFiles(self, include_deletes=None, **kwargs):
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +00001295 """Return a list of the existing text files in a change."""
1296 if include_deletes is not None:
Edward Lemura5799e32020-01-17 19:26:51 +00001297 warn('AffectedTeestableFiles(include_deletes=%s)'
1298 ' is deprecated and ignored' % str(include_deletes),
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +00001299 category=DeprecationWarning,
1300 stacklevel=2)
Edward Lemurb9830242019-10-30 22:19:20 +00001301 return list(filter(
1302 lambda x: x.IsTestableFile(),
1303 self.AffectedFiles(include_deletes=False, **kwargs)))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001304
agable0b65e732016-11-22 09:25:46 -08001305 def AffectedTextFiles(self, include_deletes=None):
1306 """An alias to AffectedTestableFiles for backwards compatibility."""
1307 return self.AffectedTestableFiles(include_deletes=include_deletes)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001308
agable0b65e732016-11-22 09:25:46 -08001309 def LocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001310 """Convenience function."""
agable0b65e732016-11-22 09:25:46 -08001311 return [af.LocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001312
agable0b65e732016-11-22 09:25:46 -08001313 def AbsoluteLocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001314 """Convenience function."""
agable0b65e732016-11-22 09:25:46 -08001315 return [af.AbsoluteLocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001316
1317 def RightHandSideLines(self):
Edward Lemura5799e32020-01-17 19:26:51 +00001318 """An iterator over all text lines in 'new' version of changed files.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001319
1320 Lists lines from new or modified text files in the change.
1321
1322 This is useful for doing line-by-line regex checks, like checking for
1323 trailing whitespace.
1324
1325 Yields:
1326 a 3 tuple:
1327 the AffectedFile instance of the current file;
1328 integer line number (1-based); and
1329 the contents of the line as a string.
1330 """
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +00001331 return _RightHandSideLinesImpl(
1332 x for x in self.AffectedFiles(include_deletes=False)
agable0b65e732016-11-22 09:25:46 -08001333 if x.IsTestableFile())
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001334
Jochen Eisingerd0573ec2017-04-13 10:55:06 +02001335 def OriginalOwnersFiles(self):
1336 """A map from path names of affected OWNERS files to their old content."""
1337 def owners_file_filter(f):
1338 return 'OWNERS' in os.path.split(f.LocalPath())[1]
1339 files = self.AffectedFiles(file_filter=owners_file_filter)
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +00001340 return {f.LocalPath(): f.OldContents() for f in files}
Jochen Eisingerd0573ec2017-04-13 10:55:06 +02001341
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001342
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001343class GitChange(Change):
1344 _AFFECTED_FILES = GitAffectedFile
maruel@chromium.orgc1938752011-04-12 23:11:13 +00001345 scm = 'git'
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +00001346
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001347 def AllFiles(self, root=None):
1348 """List all files under source control in the repo."""
1349 root = root or self.RepositoryRoot()
1350 return subprocess.check_output(
Aaron Gable7817f022017-12-12 09:43:17 -08001351 ['git', '-c', 'core.quotePath=false', 'ls-files', '--', '.'],
Josip Sokcevic0b123462021-06-08 20:41:32 +00001352 cwd=root).decode('utf-8', 'ignore').splitlines()
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001353
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001354
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001355def ListRelevantPresubmitFiles(files, root):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001356 """Finds all presubmit files that apply to a given set of source files.
1357
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001358 If inherit-review-settings-ok is present right under root, looks for
1359 PRESUBMIT.py in directories enclosing root.
1360
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001361 Args:
1362 files: An iterable container containing file paths.
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001363 root: Path where to stop searching.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001364
1365 Return:
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001366 List of absolute paths of the existing PRESUBMIT.py scripts.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001367 """
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001368 files = [normpath(os.path.join(root, f)) for f in files]
1369
1370 # List all the individual directories containing files.
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +00001371 directories = {os.path.dirname(f) for f in files}
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001372
1373 # Ignore root if inherit-review-settings-ok is present.
1374 if os.path.isfile(os.path.join(root, 'inherit-review-settings-ok')):
1375 root = None
1376
1377 # Collect all unique directories that may contain PRESUBMIT.py.
1378 candidates = set()
1379 for directory in directories:
1380 while True:
1381 if directory in candidates:
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001382 break
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001383 candidates.add(directory)
1384 if directory == root:
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001385 break
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001386 parent_dir = os.path.dirname(directory)
1387 if parent_dir == directory:
1388 # We hit the system root directory.
1389 break
1390 directory = parent_dir
1391
1392 # Look for PRESUBMIT.py in all candidate directories.
1393 results = []
1394 for directory in sorted(list(candidates)):
tobiasjsff061c02016-08-17 03:23:57 -07001395 try:
1396 for f in os.listdir(directory):
1397 p = os.path.join(directory, f)
1398 if os.path.isfile(p) and re.match(
1399 r'PRESUBMIT.*\.py$', f) and not f.startswith('PRESUBMIT_test'):
1400 results.append(p)
1401 except OSError:
1402 pass
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001403
tobiasjs2836bcf2016-08-16 04:08:16 -07001404 logging.debug('Presubmit files: %s', ','.join(results))
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001405 return results
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001406
1407
rmistry@google.com5626a922015-02-26 14:03:30 +00001408class GetPostUploadExecuter(object):
Josip Sokcevice293d3d2022-02-16 22:52:15 +00001409 def __init__(self, use_python3):
1410 """
1411 Args:
1412 use_python3: if true, will use python3 instead of python2 by default
1413 if USE_PYTHON3 is not specified.
1414 """
1415 self.use_python3 = use_python3
1416
1417 def ExecPresubmitScript(self, script_text, presubmit_path, gerrit_obj,
1418 change):
rmistry@google.com5626a922015-02-26 14:03:30 +00001419 """Executes PostUploadHook() from a single presubmit script.
Josip Sokcevic632bbc02022-05-19 05:32:50 +00001420 Caller is responsible for validating whether the hook should be executed
1421 and should only call this function if it should be.
rmistry@google.com5626a922015-02-26 14:03:30 +00001422
1423 Args:
1424 script_text: The text of the presubmit script.
1425 presubmit_path: Project script to run.
Edward Lemur016a0872020-02-04 22:13:28 +00001426 gerrit_obj: The GerritAccessor object.
rmistry@google.com5626a922015-02-26 14:03:30 +00001427 change: The Change object.
1428
1429 Return:
1430 A list of results objects.
1431 """
1432 context = {}
1433 try:
Raul Tambre09e64b42019-05-14 01:57:22 +00001434 exec(compile(script_text, 'PRESUBMIT.py', 'exec', dont_inherit=True),
1435 context)
Raul Tambre7c938462019-05-24 16:35:35 +00001436 except Exception as e:
rmistry@google.com5626a922015-02-26 14:03:30 +00001437 raise PresubmitFailure('"%s" had an exception.\n%s'
1438 % (presubmit_path, e))
1439
1440 function_name = 'PostUploadHook'
1441 if function_name not in context:
1442 return {}
1443 post_upload_hook = context[function_name]
1444 if not len(inspect.getargspec(post_upload_hook)[0]) == 3:
1445 raise PresubmitFailure(
1446 'Expected function "PostUploadHook" to take three arguments.')
Edward Lemur016a0872020-02-04 22:13:28 +00001447 return post_upload_hook(gerrit_obj, change, OutputApi(False))
rmistry@google.com5626a922015-02-26 14:03:30 +00001448
1449
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001450def _MergeMasters(masters1, masters2):
1451 """Merges two master maps. Merges also the tests of each builder."""
1452 result = {}
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001453 for (master, builders) in itertools.chain(masters1.items(),
1454 masters2.items()):
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001455 new_builders = result.setdefault(master, {})
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001456 for (builder, tests) in builders.items():
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001457 new_builders.setdefault(builder, set([])).update(tests)
1458 return result
1459
1460
Josip Sokcevice293d3d2022-02-16 22:52:15 +00001461def DoPostUploadExecuter(change, gerrit_obj, verbose, use_python3=False):
rmistry@google.com5626a922015-02-26 14:03:30 +00001462 """Execute the post upload hook.
1463
1464 Args:
1465 change: The Change object.
Edward Lemur016a0872020-02-04 22:13:28 +00001466 gerrit_obj: The GerritAccessor object.
rmistry@google.com5626a922015-02-26 14:03:30 +00001467 verbose: Prints debug info.
Josip Sokcevice293d3d2022-02-16 22:52:15 +00001468 use_python3: if true, default to using Python3 for presubmit checks
1469 rather than Python2.
rmistry@google.com5626a922015-02-26 14:03:30 +00001470 """
Josip Sokcevice293d3d2022-02-16 22:52:15 +00001471 python_version = 'Python %s' % sys.version_info.major
1472 sys.stdout.write('Running %s post upload checks ...\n' % python_version)
rmistry@google.com5626a922015-02-26 14:03:30 +00001473 presubmit_files = ListRelevantPresubmitFiles(
Edward Lemur6eb1d322020-02-27 22:20:15 +00001474 change.LocalPaths(), change.RepositoryRoot())
rmistry@google.com5626a922015-02-26 14:03:30 +00001475 if not presubmit_files and verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001476 sys.stdout.write('Warning, no PRESUBMIT.py found.\n')
rmistry@google.com5626a922015-02-26 14:03:30 +00001477 results = []
Josip Sokcevice293d3d2022-02-16 22:52:15 +00001478 executer = GetPostUploadExecuter(use_python3)
rmistry@google.com5626a922015-02-26 14:03:30 +00001479 # The root presubmit file should be executed after the ones in subdirectories.
1480 # i.e. the specific post upload hooks should run before the general ones.
1481 # Thus, reverse the order provided by ListRelevantPresubmitFiles.
1482 presubmit_files.reverse()
1483
1484 for filename in presubmit_files:
1485 filename = os.path.abspath(filename)
rmistry@google.com5626a922015-02-26 14:03:30 +00001486 # Accept CRLF presubmit script.
Bruce Dawson6e70e862022-07-01 19:37:01 +00001487 presubmit_script = gclient_utils.FileRead(filename).replace('\r\n', '\n')
Josip Sokcevic632bbc02022-05-19 05:32:50 +00001488 if _ShouldRunPresubmit(presubmit_script, use_python3):
Bruce Dawson8d78bd12022-08-12 19:17:03 +00001489 if sys.version_info[0] == 2:
Bruce Dawson443f9852022-09-08 17:30:59 +00001490 sys.stdout.write(
1491 'Running %s under Python 2. Add USE_PYTHON3 = True to prevent '
1492 'this.\n' % filename)
Bruce Dawson8d78bd12022-08-12 19:17:03 +00001493 elif verbose:
1494 sys.stdout.write('Running %s\n' % filename)
Josip Sokcevic632bbc02022-05-19 05:32:50 +00001495 results.extend(executer.ExecPresubmitScript(
1496 presubmit_script, filename, gerrit_obj, change))
rmistry@google.com5626a922015-02-26 14:03:30 +00001497
Edward Lemur6eb1d322020-02-27 22:20:15 +00001498 if not results:
1499 return 0
1500
1501 sys.stdout.write('\n')
1502 sys.stdout.write('** Post Upload Hook Messages **\n')
1503
1504 exit_code = 0
1505 for result in results:
1506 if result.fatal:
1507 exit_code = 1
1508 result.handle()
1509 sys.stdout.write('\n')
1510
1511 return exit_code
rmistry@google.com5626a922015-02-26 14:03:30 +00001512
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001513class PresubmitExecuter(object):
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001514 def __init__(self, change, committing, verbose, gerrit_obj, dry_run=None,
Bruce Dawson09c0c072022-05-26 20:28:58 +00001515 thread_pool=None, parallel=False, use_python3=False,
1516 no_diffs=False):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001517 """
1518 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001519 change: The Change object.
agable92bec4f2016-08-24 09:27:27 -07001520 committing: True if 'git cl land' is running, False if 'git cl upload' is.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001521 gerrit_obj: provides basic Gerrit codereview functionality.
1522 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -04001523 parallel: if true, all tests reported via input_api.RunTests for all
1524 PRESUBMIT files will be run in parallel.
Dirk Pranke6f0df682021-06-25 00:42:33 +00001525 use_python3: if true, will use python3 instead of python2 by default
1526 if USE_PYTHON3 is not specified.
Bruce Dawson09c0c072022-05-26 20:28:58 +00001527 no_diffs: if true, implies that --files or --all was specified so some
1528 checks can be skipped, and some errors will be messages.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001529 """
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001530 self.change = change
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001531 self.committing = committing
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001532 self.gerrit = gerrit_obj
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001533 self.verbose = verbose
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001534 self.dry_run = dry_run
Daniel Cheng7227d212017-11-17 08:12:37 -08001535 self.more_cc = []
Edward Lesmes8e282792018-04-03 18:50:29 -04001536 self.thread_pool = thread_pool
1537 self.parallel = parallel
Dirk Pranke6f0df682021-06-25 00:42:33 +00001538 self.use_python3 = use_python3
Bruce Dawson09c0c072022-05-26 20:28:58 +00001539 self.no_diffs = no_diffs
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001540
1541 def ExecPresubmitScript(self, script_text, presubmit_path):
1542 """Executes a single presubmit script.
Josip Sokcevic632bbc02022-05-19 05:32:50 +00001543 Caller is responsible for validating whether the hook should be executed
1544 and should only call this function if it should be.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001545
1546 Args:
1547 script_text: The text of the presubmit script.
1548 presubmit_path: The path to the presubmit file (this will be reported via
1549 input_api.PresubmitLocalPath()).
1550
1551 Return:
1552 A list of result objects, empty if no problems.
1553 """
chase@chromium.org8e416c82009-10-06 04:30:44 +00001554 # Change to the presubmit file's directory to support local imports.
1555 main_path = os.getcwd()
Saagar Sanghavi98b332f2020-07-31 17:19:15 +00001556 presubmit_dir = os.path.dirname(presubmit_path)
1557 os.chdir(presubmit_dir)
chase@chromium.org8e416c82009-10-06 04:30:44 +00001558
1559 # Load the presubmit script into context.
dpranke@chromium.org970c5222011-03-12 00:32:24 +00001560 input_api = InputApi(self.change, presubmit_path, self.committing,
Aaron Gable668c1d82018-04-03 10:19:16 -07001561 self.verbose, gerrit_obj=self.gerrit,
Edward Lesmes8e282792018-04-03 18:50:29 -04001562 dry_run=self.dry_run, thread_pool=self.thread_pool,
Bruce Dawson09c0c072022-05-26 20:28:58 +00001563 parallel=self.parallel, no_diffs=self.no_diffs)
Daniel Cheng7227d212017-11-17 08:12:37 -08001564 output_api = OutputApi(self.committing)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001565 context = {}
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001566
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001567 try:
Bruce Dawson0ba2fd42022-07-21 13:47:21 +00001568 exec(compile(script_text, presubmit_path, 'exec', dont_inherit=True),
Raul Tambre09e64b42019-05-14 01:57:22 +00001569 context)
Raul Tambre7c938462019-05-24 16:35:35 +00001570 except Exception as e:
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001571 raise PresubmitFailure('"%s" had an exception.\n%s' % (presubmit_path, e))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001572
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001573 context['__args'] = (input_api, output_api)
Ben Pastene8351dc12020-08-06 05:01:35 +00001574
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001575 # Get path of presubmit directory relative to repository root.
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001576 # Always use forward slashes, so that path is same in *nix and Windows
1577 root = input_api.change.RepositoryRoot()
1578 rel_path = os.path.relpath(presubmit_dir, root)
1579 rel_path = rel_path.replace(os.path.sep, '/')
Ben Pastene8351dc12020-08-06 05:01:35 +00001580
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001581 # Get the URL of git remote origin and use it to identify host and project
Edward Lesmeseb1bd622021-03-01 19:54:07 +00001582 host = project = ''
1583 if self.gerrit:
1584 host = self.gerrit.host or ''
1585 project = self.gerrit.project or ''
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001586
1587 # Prefix for test names
1588 prefix = 'presubmit:%s/%s:%s/' % (host, project, rel_path)
1589
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001590 # Perform all the desired presubmit checks.
1591 results = []
Ben Pastene8351dc12020-08-06 05:01:35 +00001592
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001593 try:
Scott Leecc2fe9b2020-11-19 19:38:06 +00001594 version = [
1595 int(x) for x in context.get('PRESUBMIT_VERSION', '0.0.0').split('.')
1596 ]
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001597
Scott Leecc2fe9b2020-11-19 19:38:06 +00001598 with rdb_wrapper.client(prefix) as sink:
1599 if version >= [2, 0, 0]:
Andrew Grievebdfb8f22022-02-02 21:56:47 +00001600 # Copy the keys to prevent "dictionary changed size during iteration"
1601 # exception if checks add globals to context. E.g. sometimes the
1602 # Python runtime will add __warningregistry__.
1603 for function_name in list(context.keys()):
Scott Leecc2fe9b2020-11-19 19:38:06 +00001604 if not function_name.startswith('Check'):
1605 continue
1606 if function_name.endswith('Commit') and not self.committing:
1607 continue
1608 if function_name.endswith('Upload') and self.committing:
1609 continue
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001610 logging.debug('Running %s in %s', function_name, presubmit_path)
1611 results.extend(
Bruce Dawson8fa42e22022-03-29 17:05:38 +00001612 self._run_check_function(function_name, context, sink,
1613 presubmit_path))
Scott Leecc2fe9b2020-11-19 19:38:06 +00001614 logging.debug('Running %s done.', function_name)
1615 self.more_cc.extend(output_api.more_cc)
1616
1617 else: # Old format
1618 if self.committing:
1619 function_name = 'CheckChangeOnCommit'
1620 else:
1621 function_name = 'CheckChangeOnUpload'
Andrew Grievebdfb8f22022-02-02 21:56:47 +00001622 if function_name in list(context.keys()):
Scott Leecc2fe9b2020-11-19 19:38:06 +00001623 logging.debug('Running %s in %s', function_name, presubmit_path)
1624 results.extend(
Bruce Dawson8fa42e22022-03-29 17:05:38 +00001625 self._run_check_function(function_name, context, sink,
1626 presubmit_path))
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001627 logging.debug('Running %s done.', function_name)
1628 self.more_cc.extend(output_api.more_cc)
1629
1630 finally:
1631 for f in input_api._named_temporary_files:
1632 os.remove(f)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001633
chase@chromium.org8e416c82009-10-06 04:30:44 +00001634 # Return the process to the original working directory.
1635 os.chdir(main_path)
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001636 return results
1637
Bruce Dawson8fa42e22022-03-29 17:05:38 +00001638 def _run_check_function(self, function_name, context, sink, presubmit_path):
Scott Leecc2fe9b2020-11-19 19:38:06 +00001639 """Evaluates and returns the result of a given presubmit function.
1640
1641 If sink is given, the result of the presubmit function will be reported
1642 to the ResultSink.
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001643
1644 Args:
Scott Leecc2fe9b2020-11-19 19:38:06 +00001645 function_name: the name of the presubmit function to evaluate
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001646 context: a context dictionary in which the function will be evaluated
Scott Leecc2fe9b2020-11-19 19:38:06 +00001647 sink: an instance of ResultSink. None, by default.
1648 Returns:
1649 the result of the presubmit function call.
1650 """
1651 start_time = time_time()
1652 try:
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001653 result = eval(function_name + '(*__args)', context)
1654 self._check_result_type(result)
Allen Webbfe7d7092021-05-18 02:05:49 +00001655 except Exception:
Bruce Dawson10a82862022-05-27 19:25:56 +00001656 _, e_value, _ = sys.exc_info()
1657 result = [
1658 OutputApi.PresubmitError(
1659 'Evaluation of %s failed: %s, %s' %
1660 (function_name, e_value, traceback.format_exc()))
1661 ]
Scott Leecc2fe9b2020-11-19 19:38:06 +00001662
Bruce Dawson2bdc49f2021-05-21 19:13:03 +00001663 elapsed_time = time_time() - start_time
1664 if elapsed_time > 10.0:
Bruce Dawson6757d462022-07-13 04:04:40 +00001665 sys.stdout.write('%6.1fs to run %s from %s.\n' %
1666 (elapsed_time, function_name, presubmit_path))
Scott Leecc2fe9b2020-11-19 19:38:06 +00001667 if sink:
Scott Leecc2fe9b2020-11-19 19:38:06 +00001668 status = rdb_wrapper.STATUS_PASS
1669 if any(r.fatal for r in result):
1670 status = rdb_wrapper.STATUS_FAIL
1671 sink.report(function_name, status, elapsed_time)
1672
1673 return result
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001674
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00001675 def _check_result_type(self, result):
1676 """Helper function which ensures result is a list, and all elements are
1677 instances of OutputApi.PresubmitResult"""
1678 if not isinstance(result, (tuple, list)):
1679 raise PresubmitFailure('Presubmit functions must return a tuple or list')
1680 if not all(isinstance(res, OutputApi.PresubmitResult) for res in result):
1681 raise PresubmitFailure(
1682 'All presubmit results must be of types derived from '
1683 'output_api.PresubmitResult')
1684
1685
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001686def DoPresubmitChecks(change,
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001687 committing,
1688 verbose,
maruel@chromium.orgb0dfd352009-06-10 14:12:54 +00001689 default_presubmit,
dpranke@chromium.org970c5222011-03-12 00:32:24 +00001690 may_prompt,
Aaron Gable668c1d82018-04-03 10:19:16 -07001691 gerrit_obj,
Edward Lesmes8e282792018-04-03 18:50:29 -04001692 dry_run=None,
Debrian Figueroadd2737e2019-06-21 23:50:13 +00001693 parallel=False,
Dirk Pranke6f0df682021-06-25 00:42:33 +00001694 json_output=None,
Bruce Dawson09c0c072022-05-26 20:28:58 +00001695 use_python3=False,
1696 no_diffs=False):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001697 """Runs all presubmit checks that apply to the files in the change.
1698
1699 This finds all PRESUBMIT.py files in directories enclosing the files in the
1700 change (up to the repository root) and calls the relevant entrypoint function
1701 depending on whether the change is being committed or uploaded.
1702
1703 Prints errors, warnings and notifications. Prompts the user for warnings
1704 when needed.
1705
1706 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001707 change: The Change object.
agable92bec4f2016-08-24 09:27:27 -07001708 committing: True if 'git cl land' is running, False if 'git cl upload' is.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001709 verbose: Prints debug info.
maruel@chromium.org0ff1fab2009-05-22 13:08:15 +00001710 default_presubmit: A default presubmit script to execute in any case.
Quinten Yearsley516fe7f2016-12-14 11:50:18 -08001711 may_prompt: Enable (y/n) questions on warning or error. If False,
1712 any questions are answered with yes by default.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001713 gerrit_obj: provides basic Gerrit codereview functionality.
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001714 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -04001715 parallel: if true, all tests specified by input_api.RunTests in all
1716 PRESUBMIT files will be run in parallel.
Dirk Pranke6f0df682021-06-25 00:42:33 +00001717 use_python3: if true, default to using Python3 for presubmit checks
1718 rather than Python2.
Bruce Dawson09c0c072022-05-26 20:28:58 +00001719 no_diffs: if true, implies that --files or --all was specified so some
1720 checks can be skipped, and some errors will be messages.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001721 Return:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001722 1 if presubmit checks failed or 0 otherwise.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001723 """
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001724 old_environ = os.environ
1725 try:
1726 # Make sure python subprocesses won't generate .pyc files.
1727 os.environ = os.environ.copy()
Edward Lemurb9830242019-10-30 22:19:20 +00001728 os.environ['PYTHONDONTWRITEBYTECODE'] = '1'
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001729
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001730 python_version = 'Python %s' % sys.version_info.major
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001731 if committing:
Dirk Pranke6fc394f2021-05-26 23:25:14 +00001732 sys.stdout.write('Running %s presubmit commit checks ...\n' %
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001733 python_version)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001734 else:
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001735 sys.stdout.write('Running %s presubmit upload checks ...\n' %
1736 python_version)
Edward Lemurecc27072020-01-06 16:42:34 +00001737 start_time = time_time()
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001738 presubmit_files = ListRelevantPresubmitFiles(
agable0b65e732016-11-22 09:25:46 -08001739 change.AbsoluteLocalPaths(), change.RepositoryRoot())
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001740 if not presubmit_files and verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001741 sys.stdout.write('Warning, no PRESUBMIT.py found.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001742 results = []
Bruce Dawsonc9f904f2022-10-14 20:59:49 +00001743 if sys.platform == 'win32':
1744 temp = os.environ['TEMP']
1745 else:
1746 temp = '/tmp'
1747 python2_usage_log_file = os.path.join(temp, 'python2_usage.txt')
Bruce Dawsonf2b04212022-06-10 16:42:54 +00001748 if os.path.exists(python2_usage_log_file):
1749 os.remove(python2_usage_log_file)
Edward Lesmes8e282792018-04-03 18:50:29 -04001750 thread_pool = ThreadPool()
Edward Lemur7e3c67f2018-07-20 20:52:49 +00001751 executer = PresubmitExecuter(change, committing, verbose, gerrit_obj,
Bruce Dawson09c0c072022-05-26 20:28:58 +00001752 dry_run, thread_pool, parallel, use_python3,
1753 no_diffs)
Josip Sokcevic632bbc02022-05-19 05:32:50 +00001754 skipped_count = 0;
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001755 if default_presubmit:
1756 if verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001757 sys.stdout.write('Running default presubmit script.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001758 fake_path = os.path.join(change.RepositoryRoot(), 'PRESUBMIT.py')
Josip Sokcevic632bbc02022-05-19 05:32:50 +00001759 if _ShouldRunPresubmit(default_presubmit, use_python3):
1760 results += executer.ExecPresubmitScript(default_presubmit, fake_path)
1761 else:
1762 skipped_count += 1
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001763 for filename in presubmit_files:
1764 filename = os.path.abspath(filename)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001765 # Accept CRLF presubmit script.
Bruce Dawson6e70e862022-07-01 19:37:01 +00001766 presubmit_script = gclient_utils.FileRead(filename).replace('\r\n', '\n')
Josip Sokcevic632bbc02022-05-19 05:32:50 +00001767 if _ShouldRunPresubmit(presubmit_script, use_python3):
Bruce Dawson8d78bd12022-08-12 19:17:03 +00001768 if sys.version_info[0] == 2:
Bruce Dawson443f9852022-09-08 17:30:59 +00001769 sys.stdout.write(
1770 'Running %s under Python 2. Add USE_PYTHON3 = True to prevent '
1771 'this.\n' % filename)
Bruce Dawson8d78bd12022-08-12 19:17:03 +00001772 elif verbose:
1773 sys.stdout.write('Running %s\n' % filename)
Josip Sokcevic632bbc02022-05-19 05:32:50 +00001774 results += executer.ExecPresubmitScript(presubmit_script, filename)
1775 else:
1776 skipped_count += 1
Bruce Dawson76fe1a72022-05-25 20:52:21 +00001777
Edward Lesmes8e282792018-04-03 18:50:29 -04001778 results += thread_pool.RunAsync()
1779
Bruce Dawsonf2b04212022-06-10 16:42:54 +00001780 if os.path.exists(python2_usage_log_file):
1781 with open(python2_usage_log_file) as f:
1782 python2_usage = [x.strip() for x in f.readlines()]
1783 results.append(
1784 OutputApi(committing).PresubmitPromptWarning(
1785 'Python 2 scripts were run during %s presubmits. Please see '
1786 'https://bugs.chromium.org/p/chromium/issues/detail?id=1313804'
1787 '#c61 for tips on resolving this.'
1788 % python_version,
1789 items=python2_usage))
1790
Edward Lemur6eb1d322020-02-27 22:20:15 +00001791 messages = {}
1792 should_prompt = False
1793 presubmits_failed = False
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001794 for result in results:
1795 if result.fatal:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001796 presubmits_failed = True
1797 messages.setdefault('ERRORS', []).append(result)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001798 elif result.should_prompt:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001799 should_prompt = True
1800 messages.setdefault('Warnings', []).append(result)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001801 else:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001802 messages.setdefault('Messages', []).append(result)
pam@chromium.orged9a0832009-09-09 22:48:55 +00001803
Bruce Dawson76fe1a72022-05-25 20:52:21 +00001804 # Print the different message types in a consistent order. ERRORS go last
1805 # so that they will be most visible in the local-presubmit output.
1806 for name in ['Messages', 'Warnings', 'ERRORS']:
1807 if name in messages:
1808 items = messages[name]
Gavin Makd22bf602022-07-11 21:10:41 +00001809 sys.stdout.write('** Presubmit %s: %d **\n' % (name, len(items)))
Bruce Dawson76fe1a72022-05-25 20:52:21 +00001810 for item in items:
1811 item.handle()
1812 sys.stdout.write('\n')
pam@chromium.orged9a0832009-09-09 22:48:55 +00001813
Edward Lemurecc27072020-01-06 16:42:34 +00001814 total_time = time_time() - start_time
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001815 if total_time > 1.0:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001816 sys.stdout.write(
Louis Romero4ca9e1c2022-03-10 10:29:11 +00001817 'Presubmit checks took %.1fs to calculate.\n' % total_time)
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +00001818
Edward Lemur6eb1d322020-02-27 22:20:15 +00001819 if not should_prompt and not presubmits_failed:
Louis Romero4ca9e1c2022-03-10 10:29:11 +00001820 sys.stdout.write('%s presubmit checks passed.\n\n' % python_version)
Josip Sokcevic7592e0a2022-01-12 00:57:54 +00001821 elif should_prompt and not presubmits_failed:
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001822 sys.stdout.write('There were %s presubmit warnings. ' % python_version)
Quinten Yearsley516fe7f2016-12-14 11:50:18 -08001823 if may_prompt:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001824 presubmits_failed = not prompt_should_continue(
1825 'Are you sure you wish to continue? (y/N): ')
Garrett Beatyacb807e2020-08-28 18:17:24 +00001826 else:
1827 sys.stdout.write('\n')
Bruce Dawson76fe1a72022-05-25 20:52:21 +00001828 else:
1829 sys.stdout.write('There were %s presubmit errors.\n' % python_version)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001830
Edward Lemur1dc66e12020-02-21 21:36:34 +00001831 if json_output:
1832 # Write the presubmit results to json output
1833 presubmit_results = {
1834 'errors': [
Edward Lemur6eb1d322020-02-27 22:20:15 +00001835 error.json_format()
1836 for error in messages.get('ERRORS', [])
Edward Lemur1dc66e12020-02-21 21:36:34 +00001837 ],
1838 'notifications': [
Edward Lemur6eb1d322020-02-27 22:20:15 +00001839 notification.json_format()
1840 for notification in messages.get('Messages', [])
Edward Lemur1dc66e12020-02-21 21:36:34 +00001841 ],
1842 'warnings': [
Edward Lemur6eb1d322020-02-27 22:20:15 +00001843 warning.json_format()
1844 for warning in messages.get('Warnings', [])
Edward Lemur1dc66e12020-02-21 21:36:34 +00001845 ],
Edward Lemur6eb1d322020-02-27 22:20:15 +00001846 'more_cc': executer.more_cc,
Josip Sokcevic632bbc02022-05-19 05:32:50 +00001847 'skipped_presubmits': skipped_count,
Edward Lemur1dc66e12020-02-21 21:36:34 +00001848 }
1849
1850 gclient_utils.FileWrite(
1851 json_output, json.dumps(presubmit_results, sort_keys=True))
1852
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001853 global _ASKED_FOR_FEEDBACK
1854 # Ask for feedback one time out of 5.
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +00001855 if (results and random.randint(0, 4) == 0 and not _ASKED_FOR_FEEDBACK):
Edward Lemur6eb1d322020-02-27 22:20:15 +00001856 sys.stdout.write(
maruel@chromium.org1ce8e662014-01-14 15:23:00 +00001857 'Was the presubmit check useful? If not, run "git cl presubmit -v"\n'
1858 'to figure out which PRESUBMIT.py was run, then run git blame\n'
1859 'on the file to figure out who to ask for help.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001860 _ASKED_FOR_FEEDBACK = True
Edward Lemur6eb1d322020-02-27 22:20:15 +00001861
1862 return 1 if presubmits_failed else 0
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001863 finally:
1864 os.environ = old_environ
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001865
1866
Edward Lemur50984a62020-02-06 18:10:18 +00001867def _scan_sub_dirs(mask, recursive):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001868 if not recursive:
pgervais@chromium.orge57b09d2014-05-07 00:58:13 +00001869 return [x for x in glob.glob(mask) if x not in ('.svn', '.git')]
Lei Zhang9611c4c2017-04-04 01:41:56 -07001870
1871 results = []
1872 for root, dirs, files in os.walk('.'):
1873 if '.svn' in dirs:
1874 dirs.remove('.svn')
1875 if '.git' in dirs:
1876 dirs.remove('.git')
1877 for name in files:
1878 if fnmatch.fnmatch(name, mask):
1879 results.append(os.path.join(root, name))
1880 return results
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001881
1882
Edward Lemur50984a62020-02-06 18:10:18 +00001883def _parse_files(args, recursive):
tobiasjs2836bcf2016-08-16 04:08:16 -07001884 logging.debug('Searching for %s', args)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001885 files = []
1886 for arg in args:
Edward Lemur50984a62020-02-06 18:10:18 +00001887 files.extend([('M', f) for f in _scan_sub_dirs(arg, recursive)])
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001888 return files
1889
1890
Edward Lemur50984a62020-02-06 18:10:18 +00001891def _parse_change(parser, options):
1892 """Process change options.
1893
1894 Args:
1895 parser: The parser used to parse the arguments from command line.
1896 options: The arguments parsed from command line.
1897 Returns:
1898 A GitChange if the change root is a git repository, or a Change otherwise.
1899 """
1900 if options.files and options.all_files:
1901 parser.error('<files> cannot be specified when --all-files is set.')
1902
Edward Lesmes44ea3ff2020-02-05 00:14:30 +00001903 change_scm = scm.determine_scm(options.root)
Edward Lemur50984a62020-02-06 18:10:18 +00001904 if change_scm != 'git' and not options.files:
1905 parser.error('<files> is not optional for unversioned directories.')
1906
1907 if options.files:
Josip Sokcevic017544d2022-03-31 23:47:53 +00001908 if options.source_controlled_only:
1909 # Get the filtered set of files from SCM.
1910 change_files = []
1911 for name in scm.GIT.GetAllFiles(options.root):
1912 for mask in options.files:
1913 if fnmatch.fnmatch(name, mask):
1914 change_files.append(('M', name))
1915 break
1916 else:
1917 # Get the filtered set of files from a directory scan.
1918 change_files = _parse_files(options.files, options.recursive)
Edward Lemur50984a62020-02-06 18:10:18 +00001919 elif options.all_files:
1920 change_files = [('M', f) for f in scm.GIT.GetAllFiles(options.root)]
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001921 else:
Edward Lemur50984a62020-02-06 18:10:18 +00001922 change_files = scm.GIT.CaptureStatus(
Edward Lemur7f6dec02020-02-06 20:23:58 +00001923 options.root, options.upstream or None)
Edward Lemur50984a62020-02-06 18:10:18 +00001924
1925 logging.info('Found %d file(s).', len(change_files))
1926
1927 change_class = GitChange if change_scm == 'git' else Change
1928 return change_class(
1929 options.name,
1930 options.description,
1931 options.root,
1932 change_files,
1933 options.issue,
1934 options.patchset,
1935 options.author,
1936 upstream=options.upstream)
1937
1938
1939def _parse_gerrit_options(parser, options):
1940 """Process gerrit options.
1941
1942 SIDE EFFECTS: Modifies options.author and options.description from Gerrit if
1943 options.gerrit_fetch is set.
1944
1945 Args:
1946 parser: The parser used to parse the arguments from command line.
1947 options: The arguments parsed from command line.
1948 Returns:
Stephen Martinisfb09de22021-02-25 03:41:13 +00001949 A GerritAccessor object if options.gerrit_url is set, or None otherwise.
Edward Lemur50984a62020-02-06 18:10:18 +00001950 """
1951 gerrit_obj = None
Stephen Martinisfb09de22021-02-25 03:41:13 +00001952 if options.gerrit_url:
Edward Lesmeseb1bd622021-03-01 19:54:07 +00001953 gerrit_obj = GerritAccessor(
1954 url=options.gerrit_url,
1955 project=options.gerrit_project,
1956 branch=options.gerrit_branch)
Edward Lemur50984a62020-02-06 18:10:18 +00001957
1958 if not options.gerrit_fetch:
1959 return gerrit_obj
1960
1961 if not options.gerrit_url or not options.issue or not options.patchset:
1962 parser.error(
1963 '--gerrit_fetch requires --gerrit_url, --issue and --patchset.')
1964
1965 options.author = gerrit_obj.GetChangeOwner(options.issue)
1966 options.description = gerrit_obj.GetChangeDescription(
1967 options.issue, options.patchset)
1968
1969 logging.info('Got author: "%s"', options.author)
1970 logging.info('Got description: """\n%s\n"""', options.description)
1971
1972 return gerrit_obj
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001973
1974
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001975@contextlib.contextmanager
1976def canned_check_filter(method_names):
1977 filtered = {}
1978 try:
1979 for method_name in method_names:
1980 if not hasattr(presubmit_canned_checks, method_name):
Gavin Make6a62332020-12-04 21:57:10 +00001981 logging.warning('Skipping unknown "canned" check %s' % method_name)
Aaron Gableecee74c2018-04-02 15:13:08 -07001982 continue
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001983 filtered[method_name] = getattr(presubmit_canned_checks, method_name)
1984 setattr(presubmit_canned_checks, method_name, lambda *_a, **_kw: [])
1985 yield
1986 finally:
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001987 for name, method in filtered.items():
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001988 setattr(presubmit_canned_checks, name, method)
1989
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +00001990
sbc@chromium.org013731e2015-02-26 18:28:43 +00001991def main(argv=None):
Edward Lemura5799e32020-01-17 19:26:51 +00001992 parser = argparse.ArgumentParser(usage='%(prog)s [options] <files...>')
1993 hooks = parser.add_mutually_exclusive_group()
1994 hooks.add_argument('-c', '--commit', action='store_true',
1995 help='Use commit instead of upload checks.')
1996 hooks.add_argument('-u', '--upload', action='store_false', dest='commit',
1997 help='Use upload instead of commit checks.')
Edward Lemur75526302020-02-27 22:31:05 +00001998 hooks.add_argument('--post_upload', action='store_true',
1999 help='Run post-upload commit hooks.')
Edward Lemura5799e32020-01-17 19:26:51 +00002000 parser.add_argument('-r', '--recursive', action='store_true',
2001 help='Act recursively.')
2002 parser.add_argument('-v', '--verbose', action='count', default=0,
2003 help='Use 2 times for more debug info.')
2004 parser.add_argument('--name', default='no name')
2005 parser.add_argument('--author')
Edward Lemur227d5102020-02-25 23:45:35 +00002006 desc = parser.add_mutually_exclusive_group()
2007 desc.add_argument('--description', default='', help='The change description.')
2008 desc.add_argument('--description_file',
2009 help='File to read change description from.')
Edward Lemura5799e32020-01-17 19:26:51 +00002010 parser.add_argument('--issue', type=int, default=0)
2011 parser.add_argument('--patchset', type=int, default=0)
2012 parser.add_argument('--root', default=os.getcwd(),
2013 help='Search for PRESUBMIT.py up to this directory. '
2014 'If inherit-review-settings-ok is present in this '
2015 'directory, parent directories up to the root file '
2016 'system directories will also be searched.')
2017 parser.add_argument('--upstream',
2018 help='Git only: the base ref or upstream branch against '
2019 'which the diff should be computed.')
2020 parser.add_argument('--default_presubmit')
2021 parser.add_argument('--may_prompt', action='store_true', default=False)
2022 parser.add_argument('--skip_canned', action='append', default=[],
2023 help='A list of checks to skip which appear in '
2024 'presubmit_canned_checks. Can be provided multiple times '
2025 'to skip multiple canned checks.')
2026 parser.add_argument('--dry_run', action='store_true', help=argparse.SUPPRESS)
2027 parser.add_argument('--gerrit_url', help=argparse.SUPPRESS)
Edward Lesmeseb1bd622021-03-01 19:54:07 +00002028 parser.add_argument('--gerrit_project', help=argparse.SUPPRESS)
2029 parser.add_argument('--gerrit_branch', help=argparse.SUPPRESS)
Edward Lemura5799e32020-01-17 19:26:51 +00002030 parser.add_argument('--gerrit_fetch', action='store_true',
2031 help=argparse.SUPPRESS)
2032 parser.add_argument('--parallel', action='store_true',
2033 help='Run all tests specified by input_api.RunTests in '
2034 'all PRESUBMIT files in parallel.')
2035 parser.add_argument('--json_output',
2036 help='Write presubmit errors to json output.')
Edward Lemur1dc66e12020-02-21 21:36:34 +00002037 parser.add_argument('--all_files', action='store_true',
Edward Lemur50984a62020-02-06 18:10:18 +00002038 help='Mark all files under source control as modified.')
Bruce Dawson09c0c072022-05-26 20:28:58 +00002039
Edward Lemura5799e32020-01-17 19:26:51 +00002040 parser.add_argument('files', nargs='*',
2041 help='List of files to be marked as modified when '
2042 'executing presubmit or post-upload hooks. fnmatch '
2043 'wildcards can also be used.')
Josip Sokcevic017544d2022-03-31 23:47:53 +00002044 parser.add_argument('--source_controlled_only', action='store_true',
2045 help='Constrain \'files\' to those in source control.')
Dirk Pranke6f0df682021-06-25 00:42:33 +00002046 parser.add_argument('--use-python3', action='store_true',
2047 help='Use python3 for presubmit checks by default')
Bruce Dawson09c0c072022-05-26 20:28:58 +00002048 parser.add_argument('--no_diffs', action='store_true',
2049 help='Assume that all "modified" files have no diffs.')
Edward Lemura5799e32020-01-17 19:26:51 +00002050 options = parser.parse_args(argv)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00002051
Erik Staabcca5c492020-04-16 17:40:07 +00002052 log_level = logging.ERROR
maruel@chromium.org899e1c12011-04-07 17:03:18 +00002053 if options.verbose >= 2:
Erik Staabcca5c492020-04-16 17:40:07 +00002054 log_level = logging.DEBUG
maruel@chromium.org899e1c12011-04-07 17:03:18 +00002055 elif options.verbose:
Erik Staabcca5c492020-04-16 17:40:07 +00002056 log_level = logging.INFO
2057 log_format = ('[%(levelname).1s%(asctime)s %(process)d %(thread)d '
2058 '%(filename)s] %(message)s')
2059 logging.basicConfig(format=log_format, level=log_level)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00002060
Bruce Dawsondca14bc2022-09-15 20:59:38 +00002061 # Print call stacks when _PresubmitResult objects are created with -v -v is
2062 # specified. This helps track down where presubmit messages are coming from.
2063 if options.verbose >= 2:
2064 global _SHOW_CALLSTACKS
2065 _SHOW_CALLSTACKS = True
2066
Edward Lemur227d5102020-02-25 23:45:35 +00002067 if options.description_file:
2068 options.description = gclient_utils.FileRead(options.description_file)
Edward Lemur50984a62020-02-06 18:10:18 +00002069 gerrit_obj = _parse_gerrit_options(parser, options)
2070 change = _parse_change(parser, options)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00002071
maruel@chromium.org899e1c12011-04-07 17:03:18 +00002072 try:
Edward Lemur75526302020-02-27 22:31:05 +00002073 if options.post_upload:
Josip Sokcevice293d3d2022-02-16 22:52:15 +00002074 return DoPostUploadExecuter(change, gerrit_obj, options.verbose,
2075 options.use_python3)
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00002076 with canned_check_filter(options.skip_canned):
Edward Lemur6eb1d322020-02-27 22:20:15 +00002077 return DoPresubmitChecks(
Edward Lemur50984a62020-02-06 18:10:18 +00002078 change,
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00002079 options.commit,
2080 options.verbose,
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00002081 options.default_presubmit,
2082 options.may_prompt,
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00002083 gerrit_obj,
Edward Lesmes8e282792018-04-03 18:50:29 -04002084 options.dry_run,
Debrian Figueroadd2737e2019-06-21 23:50:13 +00002085 options.parallel,
Dirk Pranke6f0df682021-06-25 00:42:33 +00002086 options.json_output,
Bruce Dawson09c0c072022-05-26 20:28:58 +00002087 options.use_python3,
2088 options.no_diffs)
Raul Tambre7c938462019-05-24 16:35:35 +00002089 except PresubmitFailure as e:
Josip Sokcevic0399e172022-03-21 23:11:51 +00002090 import utils
Raul Tambre80ee78e2019-05-06 22:41:05 +00002091 print(e, file=sys.stderr)
2092 print('Maybe your depot_tools is out of date?', file=sys.stderr)
Josip Sokcevic0399e172022-03-21 23:11:51 +00002093 print('depot_tools version: %s' % utils.depot_tools_version(),
2094 file=sys.stderr)
maruel@chromium.org899e1c12011-04-07 17:03:18 +00002095 return 2
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00002096
2097
2098if __name__ == '__main__':
maruel@chromium.org35625c72011-03-23 17:34:02 +00002099 fix_encoding.fix_encoding()
sbc@chromium.org013731e2015-02-26 18:28:43 +00002100 try:
2101 sys.exit(main())
2102 except KeyboardInterrupt:
2103 sys.stderr.write('interrupted\n')
sergiybf8a3b382016-07-05 11:21:30 -07002104 sys.exit(2)