blob: f103d4660e8d48c9bf3309d339f429d8ce6c0733 [file] [log] [blame]
maruel@chromium.orgddd59412011-11-30 14:20:38 +00001#!/usr/bin/env python
maruel@chromium.orgeb5edbc2012-01-16 17:03:28 +00002# Copyright (c) 2012 The Chromium Authors. All rights reserved.
maruel@chromium.orgddd59412011-11-30 14:20:38 +00003# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5
6"""Unit tests for git_cl.py."""
7
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01008import datetime
tandriide281ae2016-10-12 06:02:30 -07009import json
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +010010import logging
maruel@chromium.orgddd59412011-11-30 14:20:38 +000011import os
maruel@chromium.orga3353652011-11-30 14:26:57 +000012import StringIO
maruel@chromium.orgddd59412011-11-30 14:20:38 +000013import sys
Aaron Gable9a03ae02017-11-03 11:31:07 -070014import tempfile
maruel@chromium.orgddd59412011-11-30 14:20:38 +000015import unittest
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +000016import urlparse
maruel@chromium.orgddd59412011-11-30 14:20:38 +000017
18sys.path.insert(0, os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
19
20from testing_support.auto_stub import TestCase
Edward Lemur4c707a22019-09-24 21:13:43 +000021from third_party import mock
maruel@chromium.orgddd59412011-11-30 14:20:38 +000022
Edward Lemur5ba1e9c2018-07-23 18:19:02 +000023import metrics
24# We have to disable monitoring before importing git_cl.
25metrics.DISABLE_METRICS_COLLECTION = True
26
Eric Boren2fb63102018-10-05 13:05:03 +000027import gerrit_util
maruel@chromium.orgddd59412011-11-30 14:20:38 +000028import git_cl
iannucci@chromium.org9e849272014-04-04 00:31:55 +000029import git_common
tandrii@chromium.org57d86542016-03-04 16:11:32 +000030import git_footers
maruel@chromium.orgddd59412011-11-30 14:20:38 +000031import subprocess2
maruel@chromium.orgddd59412011-11-30 14:20:38 +000032
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +000033
tandrii5d48c322016-08-18 16:19:37 -070034def callError(code=1, cmd='', cwd='', stdout='', stderr=''):
35 return subprocess2.CalledProcessError(code, cmd, cwd, stdout, stderr)
36
37
Edward Lemur4c707a22019-09-24 21:13:43 +000038def _constantFn(return_value):
39 def f(*args, **kwargs):
40 return return_value
41 return f
42
43
tandrii5d48c322016-08-18 16:19:37 -070044CERR1 = callError(1)
45
46
Aaron Gable9a03ae02017-11-03 11:31:07 -070047def MakeNamedTemporaryFileMock(expected_content):
48 class NamedTemporaryFileMock(object):
49 def __init__(self, *args, **kwargs):
50 self.name = '/tmp/named'
51 self.expected_content = expected_content
52
53 def __enter__(self):
54 return self
55
56 def __exit__(self, _type, _value, _tb):
57 pass
58
59 def write(self, content):
60 if self.expected_content:
61 assert content == self.expected_content
62
63 def close(self):
64 pass
65
66 return NamedTemporaryFileMock
67
68
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000069class ChangelistMock(object):
70 # A class variable so we can access it when we don't have access to the
71 # instance that's being set.
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +000072 desc = ''
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000073 def __init__(self, **kwargs):
74 pass
75 def GetIssue(self):
76 return 1
Kenneth Russell61e2ed42017-02-15 11:47:13 -080077 def GetDescription(self, force=False):
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000078 return ChangelistMock.desc
dsansomee2d6fd92016-09-08 00:10:47 -070079 def UpdateDescription(self, desc, force=False):
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000080 ChangelistMock.desc = desc
81
tandrii5d48c322016-08-18 16:19:37 -070082
maruel@chromium.org2e72bb12012-01-17 15:18:35 +000083class PresubmitMock(object):
84 def __init__(self, *args, **kwargs):
85 self.reviewers = []
Daniel Cheng7227d212017-11-17 08:12:37 -080086 self.more_cc = ['chromium-reviews+test-more-cc@chromium.org']
87
maruel@chromium.org2e72bb12012-01-17 15:18:35 +000088 @staticmethod
89 def should_continue():
90 return True
91
92
maruel@chromium.org2e72bb12012-01-17 15:18:35 +000093class WatchlistsMock(object):
94 def __init__(self, _):
95 pass
96 @staticmethod
97 def GetWatchersForPaths(_):
98 return ['joe@example.com']
99
100
Edward Lemur4c707a22019-09-24 21:13:43 +0000101class CodereviewSettingsFileMock(object):
102 def __init__(self):
103 pass
104 # pylint: disable=no-self-use
105 def read(self):
106 return ('CODE_REVIEW_SERVER: gerrit.chromium.org\n' +
107 'GERRIT_HOST: True\n')
108
109
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000110class AuthenticatorMock(object):
111 def __init__(self, *_args):
112 pass
113 def has_cached_credentials(self):
114 return True
tandrii221ab252016-10-06 08:12:04 -0700115 def authorize(self, http):
116 return http
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000117
118
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100119def CookiesAuthenticatorMockFactory(hosts_with_creds=None, same_auth=False):
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000120 """Use to mock Gerrit/Git credentials from ~/.netrc or ~/.gitcookies.
121
122 Usage:
123 >>> self.mock(git_cl.gerrit_util, "CookiesAuthenticator",
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100124 CookiesAuthenticatorMockFactory({'host': ('user', _, 'pass')})
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000125
126 OR
127 >>> self.mock(git_cl.gerrit_util, "CookiesAuthenticator",
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100128 CookiesAuthenticatorMockFactory(
129 same_auth=('user', '', 'pass'))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000130 """
131 class CookiesAuthenticatorMock(git_cl.gerrit_util.CookiesAuthenticator):
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800132 def __init__(self): # pylint: disable=super-init-not-called
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000133 # Intentionally not calling super() because it reads actual cookie files.
134 pass
135 @classmethod
136 def get_gitcookies_path(cls):
137 return '~/.gitcookies'
138 @classmethod
139 def get_netrc_path(cls):
140 return '~/.netrc'
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100141 def _get_auth_for_host(self, host):
142 if same_auth:
143 return same_auth
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000144 return (hosts_with_creds or {}).get(host)
145 return CookiesAuthenticatorMock
146
Aaron Gable9a03ae02017-11-03 11:31:07 -0700147
kmarshall9249e012016-08-23 12:02:16 -0700148class MockChangelistWithBranchAndIssue():
149 def __init__(self, branch, issue):
150 self.branch = branch
151 self.issue = issue
152 def GetBranch(self):
153 return self.branch
154 def GetIssue(self):
155 return self.issue
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000156
tandriic2405f52016-10-10 08:13:15 -0700157
158class SystemExitMock(Exception):
159 pass
160
161
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000162class TestGitClBasic(unittest.TestCase):
Andrii Shyshkalov31863012017-02-08 11:35:12 +0100163 def test_get_description(self):
Edward Lemurf38bc172019-09-03 21:02:13 +0000164 cl = git_cl.Changelist(issue=1, codereview_host='host')
Andrii Shyshkalov31863012017-02-08 11:35:12 +0100165 cl.description = 'x'
166 cl.has_description = True
Edward Lemur125d60a2019-09-13 18:25:41 +0000167 cl.FetchDescription = lambda *a, **kw: 'y'
Andrii Shyshkalov31863012017-02-08 11:35:12 +0100168 self.assertEquals(cl.GetDescription(), 'x')
169 self.assertEquals(cl.GetDescription(force=True), 'y')
170 self.assertEquals(cl.GetDescription(), 'y')
171
Robert Iannucci09f1f3d2017-03-28 16:54:32 -0700172 def test_description_footers(self):
Edward Lemurf38bc172019-09-03 21:02:13 +0000173 cl = git_cl.Changelist(issue=1, codereview_host='host')
Robert Iannucci09f1f3d2017-03-28 16:54:32 -0700174 cl.description = '\n'.join([
175 'This is some message',
176 '',
177 'It has some lines',
178 'and, also',
179 '',
180 'Some: Really',
181 'Awesome: Footers',
182 ])
183 cl.has_description = True
Edward Lemur125d60a2019-09-13 18:25:41 +0000184 cl.UpdateDescriptionRemote = lambda *a, **kw: 'y'
Robert Iannucci09f1f3d2017-03-28 16:54:32 -0700185 msg, footers = cl.GetDescriptionFooters()
186 self.assertEquals(
187 msg, ['This is some message', '', 'It has some lines', 'and, also'])
188 self.assertEquals(footers, [('Some', 'Really'), ('Awesome', 'Footers')])
189
190 msg.append('wut')
191 footers.append(('gnarly-dude', 'beans'))
192 cl.UpdateDescriptionFooters(msg, footers)
193 self.assertEquals(cl.GetDescription().splitlines(), [
194 'This is some message',
195 '',
196 'It has some lines',
197 'and, also',
198 'wut'
199 '',
200 'Some: Really',
201 'Awesome: Footers',
202 'Gnarly-Dude: beans',
203 ])
204
Andrii Shyshkalov71f0da32019-07-15 22:45:18 +0000205 def test_set_preserve_tryjobs(self):
206 d = git_cl.ChangeDescription('Simple.')
207 d.set_preserve_tryjobs()
208 self.assertEqual(d.description.splitlines(), [
209 'Simple.',
210 '',
211 'Cq-Do-Not-Cancel-Tryjobs: true',
212 ])
213 before = d.description
214 d.set_preserve_tryjobs()
215 self.assertEqual(before, d.description)
216
217 d = git_cl.ChangeDescription('\n'.join([
218 'One is enough',
219 '',
220 'Cq-Do-Not-Cancel-Tryjobs: dups not encouraged, but don\'t hurt',
221 'Change-Id: Ideadbeef',
222 ]))
223 d.set_preserve_tryjobs()
224 self.assertEqual(d.description.splitlines(), [
225 'One is enough',
226 '',
227 'Cq-Do-Not-Cancel-Tryjobs: dups not encouraged, but don\'t hurt',
228 'Change-Id: Ideadbeef',
229 'Cq-Do-Not-Cancel-Tryjobs: true',
230 ])
231
tandriif9aefb72016-07-01 09:06:51 -0700232 def test_get_bug_line_values(self):
233 f = lambda p, bugs: list(git_cl._get_bug_line_values(p, bugs))
234 self.assertEqual(f('', ''), [])
235 self.assertEqual(f('', '123,v8:456'), ['123', 'v8:456'])
236 self.assertEqual(f('v8', '456'), ['v8:456'])
237 self.assertEqual(f('v8', 'chromium:123,456'), ['v8:456', 'chromium:123'])
238 # Not nice, but not worth carying.
239 self.assertEqual(f('v8', 'chromium:123,456,v8:123'),
240 ['v8:456', 'chromium:123', 'v8:123'])
241
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100242 def _test_git_number(self, parent_msg, dest_ref, child_msg,
243 parent_hash='parenthash'):
244 desc = git_cl.ChangeDescription(child_msg)
245 desc.update_with_git_number_footers(parent_hash, parent_msg, dest_ref)
246 return desc.description
247
248 def assertEqualByLine(self, actual, expected):
249 self.assertEqual(actual.splitlines(), expected.splitlines())
250
251 def test_git_number_bad_parent(self):
252 with self.assertRaises(ValueError):
253 self._test_git_number('Parent', 'refs/heads/master', 'Child')
254
255 def test_git_number_bad_parent_footer(self):
256 with self.assertRaises(AssertionError):
257 self._test_git_number(
258 'Parent\n'
259 '\n'
260 'Cr-Commit-Position: wrong',
261 'refs/heads/master', 'Child')
262
263 def test_git_number_bad_lineage_ignored(self):
264 actual = self._test_git_number(
265 'Parent\n'
266 '\n'
267 'Cr-Commit-Position: refs/heads/master@{#1}\n'
268 'Cr-Branched-From: mustBeReal40CharHash-branch@{#pos}',
269 'refs/heads/master', 'Child')
270 self.assertEqualByLine(
271 actual,
272 'Child\n'
273 '\n'
274 'Cr-Commit-Position: refs/heads/master@{#2}\n'
275 'Cr-Branched-From: mustBeReal40CharHash-branch@{#pos}')
276
277 def test_git_number_same_branch(self):
278 actual = self._test_git_number(
279 'Parent\n'
280 '\n'
281 'Cr-Commit-Position: refs/heads/master@{#12}',
282 dest_ref='refs/heads/master',
283 child_msg='Child')
284 self.assertEqualByLine(
285 actual,
286 'Child\n'
287 '\n'
288 'Cr-Commit-Position: refs/heads/master@{#13}')
289
Andrii Shyshkalovde37c012017-07-06 21:06:50 +0200290 def test_git_number_same_branch_mixed_footers(self):
291 actual = self._test_git_number(
292 'Parent\n'
293 '\n'
294 'Cr-Commit-Position: refs/heads/master@{#12}',
295 dest_ref='refs/heads/master',
296 child_msg='Child\n'
297 '\n'
298 'Broken-by: design\n'
299 'BUG=123')
300 self.assertEqualByLine(
301 actual,
302 'Child\n'
303 '\n'
304 'Broken-by: design\n'
305 'BUG=123\n'
306 'Cr-Commit-Position: refs/heads/master@{#13}')
307
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100308 def test_git_number_same_branch_with_originals(self):
309 actual = self._test_git_number(
310 'Parent\n'
311 '\n'
312 'Cr-Commit-Position: refs/heads/master@{#12}',
313 dest_ref='refs/heads/master',
314 child_msg='Child\n'
315 '\n'
316 'Some users are smart and insert their own footers\n'
317 '\n'
318 'Cr-Whatever: value\n'
319 'Cr-Commit-Position: refs/copy/paste@{#22}')
320 self.assertEqualByLine(
321 actual,
322 'Child\n'
323 '\n'
324 'Some users are smart and insert their own footers\n'
325 '\n'
326 'Cr-Original-Whatever: value\n'
327 'Cr-Original-Commit-Position: refs/copy/paste@{#22}\n'
328 'Cr-Commit-Position: refs/heads/master@{#13}')
329
330 def test_git_number_new_branch(self):
331 actual = self._test_git_number(
332 'Parent\n'
333 '\n'
334 'Cr-Commit-Position: refs/heads/master@{#12}',
335 dest_ref='refs/heads/branch',
336 child_msg='Child')
337 self.assertEqualByLine(
338 actual,
339 'Child\n'
340 '\n'
341 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
342 'Cr-Branched-From: parenthash-refs/heads/master@{#12}')
343
344 def test_git_number_lineage(self):
345 actual = self._test_git_number(
346 'Parent\n'
347 '\n'
348 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
349 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
350 dest_ref='refs/heads/branch',
351 child_msg='Child')
352 self.assertEqualByLine(
353 actual,
354 'Child\n'
355 '\n'
356 'Cr-Commit-Position: refs/heads/branch@{#2}\n'
357 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
358
359 def test_git_number_moooooooore_lineage(self):
360 actual = self._test_git_number(
361 'Parent\n'
362 '\n'
363 'Cr-Commit-Position: refs/heads/branch@{#5}\n'
364 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
365 dest_ref='refs/heads/mooore',
366 child_msg='Child')
367 self.assertEqualByLine(
368 actual,
369 'Child\n'
370 '\n'
371 'Cr-Commit-Position: refs/heads/mooore@{#1}\n'
372 'Cr-Branched-From: parenthash-refs/heads/branch@{#5}\n'
373 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
374
Andrii Shyshkalovb5effa12016-12-14 19:35:12 +0100375 def test_git_number_ever_moooooooore_lineage(self):
Robert Iannucci456b0d62018-03-13 19:15:50 -0700376 self.maxDiff = 10000 # pylint: disable=attribute-defined-outside-init
Andrii Shyshkalovb5effa12016-12-14 19:35:12 +0100377 actual = self._test_git_number(
378 'CQ commit on fresh new branch + numbering.\n'
379 '\n'
380 'NOTRY=True\n'
381 'NOPRESUBMIT=True\n'
382 'BUG=\n'
383 '\n'
384 'Review-Url: https://codereview.chromium.org/2577703003\n'
385 'Cr-Commit-Position: refs/heads/gnumb-test/br@{#1}\n'
386 'Cr-Branched-From: 0749ff9edc-refs/heads/gnumb-test/cq@{#4}\n'
387 'Cr-Branched-From: 5c49df2da6-refs/heads/master@{#41618}',
388 dest_ref='refs/heads/gnumb-test/cl',
389 child_msg='git cl on fresh new branch + numbering.\n'
390 '\n'
391 'Review-Url: https://codereview.chromium.org/2575043003 .\n')
392 self.assertEqualByLine(
393 actual,
394 'git cl on fresh new branch + numbering.\n'
395 '\n'
396 'Review-Url: https://codereview.chromium.org/2575043003 .\n'
397 'Cr-Commit-Position: refs/heads/gnumb-test/cl@{#1}\n'
398 'Cr-Branched-From: parenthash-refs/heads/gnumb-test/br@{#1}\n'
399 'Cr-Branched-From: 0749ff9edc-refs/heads/gnumb-test/cq@{#4}\n'
400 'Cr-Branched-From: 5c49df2da6-refs/heads/master@{#41618}')
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100401
402 def test_git_number_cherry_pick(self):
403 actual = self._test_git_number(
404 'Parent\n'
405 '\n'
406 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
407 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
408 dest_ref='refs/heads/branch',
409 child_msg='Child, which is cherry-pick from master\n'
410 '\n'
411 'Cr-Commit-Position: refs/heads/master@{#100}\n'
412 '(cherry picked from commit deadbeef12345678deadbeef12345678deadbeef)')
413 self.assertEqualByLine(
414 actual,
415 'Child, which is cherry-pick from master\n'
416 '\n'
417 '(cherry picked from commit deadbeef12345678deadbeef12345678deadbeef)\n'
418 '\n'
419 'Cr-Original-Commit-Position: refs/heads/master@{#100}\n'
420 'Cr-Commit-Position: refs/heads/branch@{#2}\n'
421 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
422
Andrii Shyshkalovd4c86732018-09-25 04:29:31 +0000423 def test_gerrit_mirror_hack(self):
424 cr = 'chromium-review.googlesource.com'
425 url0 = 'https://%s/a/changes/x?a=b' % cr
426 origMirrors = git_cl.gerrit_util._GERRIT_MIRROR_PREFIXES
427 try:
428 git_cl.gerrit_util._GERRIT_MIRROR_PREFIXES = ['us1', 'us2']
429 url1 = git_cl.gerrit_util._UseGerritMirror(url0, cr)
430 url2 = git_cl.gerrit_util._UseGerritMirror(url1, cr)
431 url3 = git_cl.gerrit_util._UseGerritMirror(url2, cr)
432
433 self.assertNotEqual(url1, url2)
434 self.assertEqual(sorted((url1, url2)), [
435 'https://us1-mirror-chromium-review.googlesource.com/a/changes/x?a=b',
436 'https://us2-mirror-chromium-review.googlesource.com/a/changes/x?a=b'])
437 self.assertEqual(url1, url3)
438 finally:
439 git_cl.gerrit_util._GERRIT_MIRROR_PREFIXES = origMirrors
440
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +0000441 def test_valid_accounts(self):
442 mock_per_account = {
443 'u1': None, # 404, doesn't exist.
444 'u2': {
445 '_account_id': 123124,
446 'avatars': [],
447 'email': 'u2@example.com',
448 'name': 'User Number 2',
449 'status': 'OOO',
450 },
451 'u3': git_cl.gerrit_util.GerritError(500, 'retries didn\'t help :('),
452 }
453 def GetAccountDetailsMock(_, account):
454 # Poor-man's mock library's side_effect.
455 v = mock_per_account.pop(account)
456 if isinstance(v, Exception):
457 raise v
458 return v
459
460 original = git_cl.gerrit_util.GetAccountDetails
461 try:
462 git_cl.gerrit_util.GetAccountDetails = GetAccountDetailsMock
463 actual = git_cl.gerrit_util.ValidAccounts(
464 'host', ['u1', 'u2', 'u3'], max_threads=1)
465 finally:
466 git_cl.gerrit_util.GetAccountDetails = original
467 self.assertEqual(actual, {
468 'u2': {
469 '_account_id': 123124,
470 'avatars': [],
471 'email': 'u2@example.com',
472 'name': 'User Number 2',
473 'status': 'OOO',
474 },
475 })
476
477
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200478class TestParseIssueURL(unittest.TestCase):
479 def _validate(self, parsed, issue=None, patchset=None, hostname=None,
Edward Lemurf38bc172019-09-03 21:02:13 +0000480 fail=False):
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200481 self.assertIsNotNone(parsed)
482 if fail:
483 self.assertFalse(parsed.valid)
484 return
485 self.assertTrue(parsed.valid)
486 self.assertEqual(parsed.issue, issue)
487 self.assertEqual(parsed.patchset, patchset)
488 self.assertEqual(parsed.hostname, hostname)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200489
490 def _run_and_validate(self, func, url, *args, **kwargs):
491 result = func(urlparse.urlparse(url))
492 if kwargs.pop('fail', False):
493 self.assertIsNone(result)
494 return None
495 self._validate(result, *args, fail=False, **kwargs)
496
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200497 def test_gerrit(self):
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200498 def test(url, *args, **kwargs):
Edward Lemur125d60a2019-09-13 18:25:41 +0000499 self._run_and_validate(git_cl.Changelist.ParseIssueURL, url,
Edward Lemurf38bc172019-09-03 21:02:13 +0000500 *args, **kwargs)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200501
502 test('http://chrome-review.source.com/c/123',
503 123, None, 'chrome-review.source.com')
504 test('https://chrome-review.source.com/c/123/',
505 123, None, 'chrome-review.source.com')
506 test('https://chrome-review.source.com/c/123/4',
507 123, 4, 'chrome-review.source.com')
508 test('https://chrome-review.source.com/#/c/123/4',
509 123, 4, 'chrome-review.source.com')
510 test('https://chrome-review.source.com/c/123/4',
511 123, 4, 'chrome-review.source.com')
512 test('https://chrome-review.source.com/123',
513 123, None, 'chrome-review.source.com')
514 test('https://chrome-review.source.com/123/4',
515 123, 4, 'chrome-review.source.com')
516
517 test('https://chrome-review.source.com/c/123/1/whatisthis', fail=True)
518 test('https://chrome-review.source.com/c/abc/', fail=True)
519 test('ssh://chrome-review.source.com/c/123/1/', fail=True)
520
521 def test_ParseIssueNumberArgument(self):
522 def test(arg, *args, **kwargs):
Edward Lemurf38bc172019-09-03 21:02:13 +0000523 self._validate(git_cl.ParseIssueNumberArgument(arg), *args, **kwargs)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200524
525 test('123', 123)
526 test('', fail=True)
527 test('abc', fail=True)
528 test('123/1', fail=True)
529 test('123a', fail=True)
530 test('ssh://chrome-review.source.com/#/c/123/4/', fail=True)
Andrii Shyshkalovf5569d22018-10-15 03:35:23 +0000531
Andrii Shyshkalovc9712392017-04-11 13:35:21 +0200532 test('https://codereview.source.com/123',
Edward Lemurf38bc172019-09-03 21:02:13 +0000533 123, None, 'codereview.source.com')
Andrii Shyshkalovf5569d22018-10-15 03:35:23 +0000534
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200535 # Gerrrit.
536 test('https://chrome-review.source.com/c/123/4',
Edward Lemurf38bc172019-09-03 21:02:13 +0000537 123, 4, 'chrome-review.source.com')
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200538 test('https://chrome-review.source.com/bad/123/4', fail=True)
539
540
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100541class GitCookiesCheckerTest(TestCase):
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100542 def setUp(self):
543 super(GitCookiesCheckerTest, self).setUp()
544 self.c = git_cl._GitCookiesChecker()
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100545 self.c._all_hosts = []
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100546
547 def mock_hosts_creds(self, subhost_identity_pairs):
548 def ensure_googlesource(h):
549 if not h.endswith(self.c._GOOGLESOURCE):
550 assert not h.endswith('.')
551 return h + '.' + self.c._GOOGLESOURCE
552 return h
553 self.c._all_hosts = [(ensure_googlesource(h), i, '.gitcookies')
554 for h, i in subhost_identity_pairs]
555
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +0200556 def test_identity_parsing(self):
557 self.assertEqual(self.c._parse_identity('ldap.google.com'),
558 ('ldap', 'google.com'))
559 self.assertEqual(self.c._parse_identity('git-ldap.example.com'),
560 ('ldap', 'example.com'))
561 # Specical case because we know there are no subdomains in chromium.org.
562 self.assertEqual(self.c._parse_identity('git-note.period.chromium.org'),
563 ('note.period', 'chromium.org'))
Lei Zhangd3f769a2017-12-15 15:16:14 -0800564 # Pathological: ".period." can be either username OR domain, more likely
565 # domain.
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +0200566 self.assertEqual(self.c._parse_identity('git-note.period.example.com'),
567 ('note', 'period.example.com'))
568
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100569 def test_analysis_nothing(self):
570 self.c._all_hosts = []
571 self.assertFalse(self.c.has_generic_host())
572 self.assertEqual(set(), self.c.get_conflicting_hosts())
573 self.assertEqual(set(), self.c.get_duplicated_hosts())
574 self.assertEqual(set(), self.c.get_partially_configured_hosts())
575 self.assertEqual(set(), self.c.get_hosts_with_wrong_identities())
576
577 def test_analysis(self):
578 self.mock_hosts_creds([
579 ('.googlesource.com', 'git-example.chromium.org'),
580
581 ('chromium', 'git-example.google.com'),
582 ('chromium-review', 'git-example.google.com'),
583 ('chrome-internal', 'git-example.chromium.org'),
584 ('chrome-internal-review', 'git-example.chromium.org'),
585 ('conflict', 'git-example.google.com'),
586 ('conflict-review', 'git-example.chromium.org'),
587 ('dup', 'git-example.google.com'),
588 ('dup', 'git-example.google.com'),
589 ('dup-review', 'git-example.google.com'),
590 ('partial', 'git-example.google.com'),
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200591 ('gpartial-review', 'git-example.google.com'),
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100592 ])
593 self.assertTrue(self.c.has_generic_host())
594 self.assertEqual(set(['conflict.googlesource.com']),
595 self.c.get_conflicting_hosts())
596 self.assertEqual(set(['dup.googlesource.com']),
597 self.c.get_duplicated_hosts())
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200598 self.assertEqual(set(['partial.googlesource.com',
599 'gpartial-review.googlesource.com']),
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100600 self.c.get_partially_configured_hosts())
601 self.assertEqual(set(['chromium.googlesource.com',
602 'chrome-internal.googlesource.com']),
603 self.c.get_hosts_with_wrong_identities())
604
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100605 def test_report_no_problems(self):
606 self.test_analysis_nothing()
607 self.mock(sys, 'stdout', StringIO.StringIO())
608 self.assertFalse(self.c.find_and_report_problems())
609 self.assertEqual(sys.stdout.getvalue(), '')
610
611 def test_report(self):
612 self.test_analysis()
613 self.mock(sys, 'stdout', StringIO.StringIO())
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200614 self.mock(git_cl.gerrit_util.CookiesAuthenticator, 'get_gitcookies_path',
615 classmethod(lambda _: '~/.gitcookies'))
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100616 self.assertTrue(self.c.find_and_report_problems())
617 with open(os.path.join(os.path.dirname(__file__),
618 'git_cl_creds_check_report.txt')) as f:
619 expected = f.read()
620 def by_line(text):
621 return [l.rstrip() for l in text.rstrip().splitlines()]
Robert Iannucci456b0d62018-03-13 19:15:50 -0700622 self.maxDiff = 10000 # pylint: disable=attribute-defined-outside-init
Andrii Shyshkalov4812e612017-03-27 17:22:57 +0200623 self.assertEqual(by_line(sys.stdout.getvalue().strip()), by_line(expected))
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100624
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -0800625
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000626class TestGitCl(TestCase):
627 def setUp(self):
628 super(TestGitCl, self).setUp()
629 self.calls = []
tandrii9d206752016-06-20 11:32:47 -0700630 self._calls_done = []
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000631 self.mock(git_cl, 'time_time',
632 lambda: self._mocked_call('time.time'))
633 self.mock(git_cl.metrics.collector, 'add_repeated',
634 lambda *a: self._mocked_call('add_repeated', *a))
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000635 self.mock(subprocess2, 'call', self._mocked_call)
636 self.mock(subprocess2, 'check_call', self._mocked_call)
637 self.mock(subprocess2, 'check_output', self._mocked_call)
tandrii5d48c322016-08-18 16:19:37 -0700638 self.mock(subprocess2, 'communicate',
639 lambda *a, **kw: ([self._mocked_call(*a, **kw), ''], 0))
tandrii@chromium.orga342c922016-03-16 07:08:25 +0000640 self.mock(git_cl.gclient_utils, 'CheckCallAndFilter', self._mocked_call)
sbc@chromium.org71437c02015-04-09 19:29:40 +0000641 self.mock(git_common, 'is_dirty_git_tree', lambda x: False)
iannucci@chromium.org9e849272014-04-04 00:31:55 +0000642 self.mock(git_common, 'get_or_create_merge_base',
643 lambda *a: (
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000644 self._mocked_call(['get_or_create_merge_base'] + list(a))))
pgervais@chromium.org8ba38ff2015-06-11 21:41:25 +0000645 self.mock(git_cl, 'BranchExists', lambda _: True)
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000646 self.mock(git_cl, 'FindCodereviewSettingsFile', lambda: '')
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000647 self.mock(git_cl, 'SaveDescriptionBackup', lambda _:
648 self._mocked_call('SaveDescriptionBackup'))
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100649 self.mock(git_cl, 'ask_for_data', lambda *a, **k: self._mocked_call(
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000650 *(['ask_for_data'] + list(a)), **k))
phajdan.jre328cf92016-08-22 04:12:17 -0700651 self.mock(git_cl, 'write_json', lambda path, contents:
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000652 self._mocked_call('write_json', path, contents))
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000653 self.mock(git_cl.presubmit_support, 'DoPresubmitChecks', PresubmitMock)
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000654 self.mock(git_cl.watchlists, 'Watchlists', WatchlistsMock)
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000655 self.mock(git_cl.auth, 'get_authenticator_for_host', AuthenticatorMock)
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +0100656 self.mock(git_cl.gerrit_util, 'GetChangeDetail',
657 lambda *args, **kwargs: self._mocked_call(
658 'GetChangeDetail', *args, **kwargs))
Aaron Gable0ffdf2d2017-06-05 13:01:17 -0700659 self.mock(git_cl.gerrit_util, 'GetChangeComments',
660 lambda *args, **kwargs: self._mocked_call(
661 'GetChangeComments', *args, **kwargs))
Quinten Yearsley0e617c02019-02-20 00:37:03 +0000662 self.mock(git_cl.gerrit_util, 'GetChangeRobotComments',
663 lambda *args, **kwargs: self._mocked_call(
664 'GetChangeRobotComments', *args, **kwargs))
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +0100665 self.mock(git_cl.gerrit_util, 'AddReviewers',
Aaron Gable6dadfbf2017-05-09 14:27:58 -0700666 lambda h, i, reviewers, ccs, notify: self._mocked_call(
667 'AddReviewers', h, i, reviewers, ccs, notify))
Aaron Gablefd238082017-06-07 13:42:34 -0700668 self.mock(git_cl.gerrit_util, 'SetReview',
Aaron Gablefc62f762017-07-17 11:12:07 -0700669 lambda h, i, msg=None, labels=None, notify=None:
670 self._mocked_call('SetReview', h, i, msg, labels, notify))
Andrii Shyshkalov733d4ec2018-04-19 11:48:58 -0700671 self.mock(git_cl.gerrit_util.LuciContextAuthenticator, 'is_luci',
672 staticmethod(lambda: False))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000673 self.mock(git_cl.gerrit_util.GceAuthenticator, 'is_gce',
674 classmethod(lambda _: False))
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +0000675 self.mock(git_cl.gerrit_util, 'ValidAccounts',
676 lambda host, accounts:
677 self._mocked_call('ValidAccounts', host, accounts))
tandriic2405f52016-10-10 08:13:15 -0700678 self.mock(git_cl, 'DieWithError',
Christopher Lamf732cd52017-01-24 12:40:11 +1100679 lambda msg, change=None: self._mocked_call(['DieWithError', msg]))
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000680 # It's important to reset settings to not have inter-tests interference.
681 git_cl.settings = None
682
683 def tearDown(self):
wychen@chromium.org445c8962015-04-28 23:30:05 +0000684 try:
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100685 self.assertEquals([], self.calls)
686 except AssertionError:
wychen@chromium.org445c8962015-04-28 23:30:05 +0000687 if not self.has_failed():
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100688 raise
689 # Sadly, has_failed() returns True if this OR any other tests before this
690 # one have failed.
Andrii Shyshkalove05d4882017-04-12 14:34:49 +0200691 git_cl.logging.error(
692 '!!!!!! IF YOU SEE THIS, READ BELOW, IT WILL SAVE YOUR TIME !!!!!\n'
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100693 'There are un-consumed self.calls after this test has finished.\n'
694 'If you don\'t know which test this is, run:\n'
Aaron Gable3a16ed12017-03-23 10:51:55 -0700695 ' tests/git_cl_tests.py -v\n'
Andrii Shyshkalove05d4882017-04-12 14:34:49 +0200696 'If you are already running only this test, then **first** fix the '
697 'problem whose exception is emitted below by unittest runner.\n'
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100698 'Else, to be sure what\'s going on, run this test **alone** with \n'
Aaron Gable3a16ed12017-03-23 10:51:55 -0700699 ' tests/git_cl_tests.py TestGitCl.<name>\n'
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100700 'and follow instructions above.\n' +
701 '=' * 80)
wychen@chromium.org445c8962015-04-28 23:30:05 +0000702 finally:
703 super(TestGitCl, self).tearDown()
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000704
iannucci@chromium.org9e849272014-04-04 00:31:55 +0000705 def _mocked_call(self, *args, **_kwargs):
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000706 self.assertTrue(
707 self.calls,
tandrii9d206752016-06-20 11:32:47 -0700708 '@%d Expected: <Missing> Actual: %r' % (len(self._calls_done), args))
wychen@chromium.orga872e752015-04-28 23:42:18 +0000709 top = self.calls.pop(0)
wychen@chromium.orga872e752015-04-28 23:42:18 +0000710 expected_args, result = top
711
maruel@chromium.orge52678e2013-04-26 18:34:44 +0000712 # Also logs otherwise it could get caught in a try/finally and be hard to
713 # diagnose.
714 if expected_args != args:
tandrii9d206752016-06-20 11:32:47 -0700715 N = 5
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000716 prior_calls = '\n '.join(
tandrii9d206752016-06-20 11:32:47 -0700717 '@%d: %r' % (len(self._calls_done) - N + i, c[0])
718 for i, c in enumerate(self._calls_done[-N:]))
719 following_calls = '\n '.join(
720 '@%d: %r' % (len(self._calls_done) + i + 1, c[0])
721 for i, c in enumerate(self.calls[:N]))
722 extended_msg = (
723 'A few prior calls:\n %s\n\n'
724 'This (expected):\n @%d: %r\n'
725 'This (actual):\n @%d: %r\n\n'
726 'A few following expected calls:\n %s' %
727 (prior_calls, len(self._calls_done), expected_args,
728 len(self._calls_done), args, following_calls))
729 git_cl.logging.error(extended_msg)
730
tandrii99a72f22016-08-17 14:33:24 -0700731 self.fail('@%d\n'
732 ' Expected: %r\n'
733 ' Actual: %r' % (
tandrii9d206752016-06-20 11:32:47 -0700734 len(self._calls_done), expected_args, args))
735
736 self._calls_done.append(top)
tandrii5d48c322016-08-18 16:19:37 -0700737 if isinstance(result, Exception):
738 raise result
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000739 return result
740
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100741 def test_ask_for_explicit_yes_true(self):
742 self.calls = [
743 (('ask_for_data', 'prompt [Yes/No]: '), 'blah'),
744 (('ask_for_data', 'Please, type yes or no: '), 'ye'),
745 ]
746 self.assertTrue(git_cl.ask_for_explicit_yes('prompt'))
747
tandrii48df5812016-10-17 03:55:37 -0700748 def test_LoadCodereviewSettingsFromFile_gerrit(self):
749 codereview_file = StringIO.StringIO('GERRIT_HOST: true')
750 self.calls = [
751 ((['git', 'config', '--unset-all', 'rietveld.cc'],), CERR1),
tandrii48df5812016-10-17 03:55:37 -0700752 ((['git', 'config', '--unset-all', 'rietveld.tree-status-url'],), CERR1),
753 ((['git', 'config', '--unset-all', 'rietveld.viewvc-url'],), CERR1),
754 ((['git', 'config', '--unset-all', 'rietveld.bug-prefix'],), CERR1),
755 ((['git', 'config', '--unset-all', 'rietveld.cpplint-regex'],), CERR1),
tandrii48df5812016-10-17 03:55:37 -0700756 ((['git', 'config', '--unset-all', 'rietveld.cpplint-ignore-regex'],),
757 CERR1),
tandrii48df5812016-10-17 03:55:37 -0700758 ((['git', 'config', '--unset-all', 'rietveld.run-post-upload-hook'],),
759 CERR1),
760 ((['git', 'config', 'gerrit.host', 'true'],), ''),
761 ]
762 self.assertIsNone(git_cl.LoadCodereviewSettingsFromFile(codereview_file))
763
maruel@chromium.orga3353652011-11-30 14:26:57 +0000764 @classmethod
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000765 def _is_gerrit_calls(cls, gerrit=False):
766 return [((['git', 'config', 'rietveld.autoupdate'],), ''),
767 ((['git', 'config', 'gerrit.host'],), 'True' if gerrit else '')]
768
769 @classmethod
tandrii@chromium.org1e67bb72016-02-11 12:15:49 +0000770 def _git_post_upload_calls(cls):
771 return [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000772 ((['git', 'rev-parse', 'HEAD'],), 'hash'),
773 ((['git', 'symbolic-ref', 'HEAD'],), 'hash'),
774 ((['git',
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000775 'config', 'branch.hash.last-upload-hash', 'hash'],), ''),
rmistry@google.com5626a922015-02-26 14:03:30 +0000776 ((['git', 'config', 'rietveld.run-post-upload-hook'],), ''),
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000777 ]
778
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000779 @staticmethod
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000780 def _git_sanity_checks(diff_base, working_branch, get_remote_branch=True):
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000781 fake_ancestor = 'fake_ancestor'
782 fake_cl = 'fake_cl_for_patch'
783 return [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000784 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000785 'rev-parse', '--verify', diff_base],), fake_ancestor),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000786 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000787 'merge-base', fake_ancestor, 'HEAD'],), fake_ancestor),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000788 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000789 'rev-list', '^' + fake_ancestor, 'HEAD'],), fake_cl),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000790 # Mock a config miss (error code 1)
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000791 ((['git',
tandrii5d48c322016-08-18 16:19:37 -0700792 'config', 'gitcl.remotebranch'],), CERR1),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000793 ] + ([
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000794 # Call to GetRemoteBranch()
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000795 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000796 'config', 'branch.%s.merge' % working_branch],),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000797 'refs/heads/master'),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000798 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000799 'config', 'branch.%s.remote' % working_branch],), 'origin'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000800 ] if get_remote_branch else []) + [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000801 ((['git', 'rev-list', '^' + fake_ancestor,
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000802 'refs/remotes/origin/master'],), ''),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000803 ]
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000804
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000805 @classmethod
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000806 def _gerrit_ensure_auth_calls(
Edward Lemurf38bc172019-09-03 21:02:13 +0000807 cls, issue=None, skip_auth_check=False, short_hostname='chromium',
808 custom_cl_base=None):
shinyak@chromium.org00dbccd2016-04-15 07:24:43 +0000809 cmd = ['git', 'config', '--bool', 'gerrit.skip-ensure-authenticated']
tandrii@chromium.org28253532016-04-14 13:46:56 +0000810 if skip_auth_check:
811 return [((cmd, ), 'true')]
812
tandrii5d48c322016-08-18 16:19:37 -0700813 calls = [((cmd, ), CERR1)]
Edward Lemurf38bc172019-09-03 21:02:13 +0000814
815 if custom_cl_base:
816 calls += [
817 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
818 ]
819
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000820 calls.extend([
821 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
822 ((['git', 'config', 'branch.master.remote'],), 'origin'),
823 ((['git', 'config', 'remote.origin.url'],),
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000824 'https://%s.googlesource.com/my/repo' % short_hostname),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000825 ])
Edward Lemurf38bc172019-09-03 21:02:13 +0000826
827 calls += [
828 ((['git', 'config', 'branch.master.gerritissue'],),
829 CERR1 if issue is None else str(issue)),
830 ]
831
Daniel Chengcf6269b2019-05-18 01:02:12 +0000832 if issue:
833 calls.extend([
834 ((['git', 'config', 'branch.master.gerritserver'],), CERR1),
835 ])
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000836 return calls
837
838 @classmethod
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100839 def _gerrit_base_calls(cls, issue=None, fetched_description=None,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200840 fetched_status=None, other_cl_owner=None,
Anthony Polito8b955342019-09-24 19:01:36 +0000841 custom_cl_base=None, short_hostname='chromium',
842 change_id=None):
Aaron Gable13101a62018-02-09 13:20:41 -0800843 calls = cls._is_gerrit_calls(True)
Edward Lemurf38bc172019-09-03 21:02:13 +0000844 if not custom_cl_base:
845 calls += [
846 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
847 ]
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200848
849 if custom_cl_base:
850 ancestor_revision = custom_cl_base
851 else:
852 # Determine ancestor_revision to be merge base.
853 ancestor_revision = 'fake_ancestor_sha'
854 calls += [
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000855 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000856 ((['git', 'config', 'branch.master.remote'],), 'origin'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000857 ((['get_or_create_merge_base', 'master',
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200858 'refs/remotes/origin/master'],), ancestor_revision),
859 ]
860
861 # Calls to verify branch point is ancestor
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000862 calls += cls._gerrit_ensure_auth_calls(
Edward Lemurf38bc172019-09-03 21:02:13 +0000863 issue=issue, short_hostname=short_hostname,
864 custom_cl_base=custom_cl_base)
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100865
866 if issue:
867 calls += [
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000868 (('GetChangeDetail', '%s-review.googlesource.com' % short_hostname,
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +0000869 'my%2Frepo~123456',
Andrii Shyshkalovc4a73562018-09-25 18:40:17 +0000870 ['DETAILED_ACCOUNTS', 'CURRENT_REVISION', 'CURRENT_COMMIT', 'LABELS']
871 ),
Andrii Shyshkalov3e631422017-02-16 17:46:44 +0100872 {
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100873 'owner': {'email': (other_cl_owner or 'owner@example.com')},
Anthony Polito8b955342019-09-24 19:01:36 +0000874 'change_id': (change_id or '123456789'),
Andrii Shyshkalov3e631422017-02-16 17:46:44 +0100875 'current_revision': 'sha1_of_current_revision',
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000876 'revisions': {'sha1_of_current_revision': {
Andrii Shyshkalov3e631422017-02-16 17:46:44 +0100877 'commit': {'message': fetched_description},
878 }},
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100879 'status': fetched_status or 'NEW',
Andrii Shyshkalov3e631422017-02-16 17:46:44 +0100880 }),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100881 ]
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100882 if fetched_status == 'ABANDONED':
883 calls += [
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000884 (('DieWithError', 'Change https://%s-review.googlesource.com/'
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100885 '123456 has been abandoned, new uploads are not '
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000886 'allowed' % short_hostname), SystemExitMock()),
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100887 ]
888 return calls
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100889 if other_cl_owner:
890 calls += [
891 (('ask_for_data', 'Press Enter to upload, or Ctrl+C to abort'), ''),
892 ]
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100893
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200894 calls += cls._git_sanity_checks(ancestor_revision, 'master',
895 get_remote_branch=False)
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100896 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200897 ((['git', 'rev-parse', '--show-cdup'],), ''),
898 ((['git', 'rev-parse', 'HEAD'],), '12345'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000899
Aaron Gable7817f022017-12-12 09:43:17 -0800900 ((['git', '-c', 'core.quotePath=false', 'diff', '--name-status',
901 '--no-renames', '-r', ancestor_revision + '...', '.'],),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200902 'M\t.gitignore\n'),
903 ((['git', 'config', 'branch.master.gerritpatchset'],), CERR1),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100904 ]
905
906 if not issue:
907 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200908 ((['git', 'log', '--pretty=format:%s%n%n%b',
909 ancestor_revision + '...'],),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000910 'foo'),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100911 ]
912
913 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200914 ((['git', 'config', 'user.email'],), 'me@example.com'),
Edward Lemur2c48f242019-06-04 16:14:09 +0000915 (('time.time',), 1000,),
916 (('time.time',), 3000,),
917 (('add_repeated', 'sub_commands', {
918 'execution_time': 2000,
919 'command': 'presubmit',
920 'exit_code': 0
921 }), None,),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200922 ((['git', 'diff', '--no-ext-diff', '--stat', '-l100000', '-C50'] +
923 ([custom_cl_base] if custom_cl_base else
924 [ancestor_revision, 'HEAD']),),
925 '+dat'),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100926 ]
927 return calls
ukai@chromium.orge8077812012-02-03 03:41:46 +0000928
tandrii@chromium.org1e67bb72016-02-11 12:15:49 +0000929 @classmethod
930 def _gerrit_upload_calls(cls, description, reviewers, squash,
tandriia60502f2016-06-20 02:01:53 -0700931 squash_mode='default',
tandrii@chromium.org10625002016-03-04 20:03:47 +0000932 expected_upstream_ref='origin/refs/heads/master',
Aaron Gablefd238082017-06-07 13:42:34 -0700933 title=None, notify=False,
Andrii Shyshkalove9c78ff2017-02-06 15:53:13 +0100934 post_amend_description=None, issue=None, cc=None,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000935 custom_cl_base=None, tbr=None,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +0000936 short_hostname='chromium',
Edward Lemur1b52d872019-05-09 21:12:12 +0000937 labels=None, change_id=None, original_title=None,
Anthony Polito8b955342019-09-24 19:01:36 +0000938 final_description=None, gitcookies_exists=True,
939 force=False):
tandrii@chromium.org10625002016-03-04 20:03:47 +0000940 if post_amend_description is None:
941 post_amend_description = description
bradnelsond975b302016-10-23 12:20:23 -0700942 cc = cc or []
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200943 # Determined in `_gerrit_base_calls`.
944 determined_ancestor_revision = custom_cl_base or 'fake_ancestor_sha'
945
946 calls = []
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000947
tandriia60502f2016-06-20 02:01:53 -0700948 if squash_mode == 'default':
949 calls.extend([
950 ((['git', 'config', '--bool', 'gerrit.override-squash-uploads'],), ''),
951 ((['git', 'config', '--bool', 'gerrit.squash-uploads'],), ''),
952 ])
953 elif squash_mode in ('override_squash', 'override_nosquash'):
954 calls.extend([
955 ((['git', 'config', '--bool', 'gerrit.override-squash-uploads'],),
956 'true' if squash_mode == 'override_squash' else 'false'),
957 ])
958 else:
959 assert squash_mode in ('squash', 'nosquash')
960
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000961 # If issue is given, then description is fetched from Gerrit instead.
962 if issue is None:
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000963 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200964 ((['git', 'log', '--pretty=format:%s\n\n%b',
965 ((custom_cl_base + '..') if custom_cl_base else
966 'fake_ancestor_sha..HEAD')],),
967 description),
968 ]
Aaron Gableb56ad332017-01-06 15:24:31 -0800969 if squash:
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +0000970 title = 'Initial_upload'
Aaron Gableb56ad332017-01-06 15:24:31 -0800971 else:
972 if not title:
973 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200974 ((['git', 'show', '-s', '--format=%s', 'HEAD'],), ''),
975 (('ask_for_data', 'Title for patchset []: '), 'User input'),
Aaron Gableb56ad332017-01-06 15:24:31 -0800976 ]
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +0000977 title = 'User_input'
tandrii@chromium.org57d86542016-03-04 16:11:32 +0000978 if not git_footers.get_footer_change_id(description) and not squash:
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +0000979 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200980 (('DownloadGerritHook', False), ''),
981 # Amending of commit message to get the Change-Id.
982 ((['git', 'log', '--pretty=format:%s\n\n%b',
983 determined_ancestor_revision + '..HEAD'],),
984 description),
985 ((['git', 'commit', '--amend', '-m', description],), ''),
986 ((['git', 'log', '--pretty=format:%s\n\n%b',
987 determined_ancestor_revision + '..HEAD'],),
988 post_amend_description)
989 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000990 if squash:
Anthony Polito8b955342019-09-24 19:01:36 +0000991 if force or not issue:
992 if issue:
993 calls += [
994 ((['git', 'config', 'rietveld.bug-prefix'],), ''),
995 ]
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000996 # Prompting to edit description on first upload.
997 calls += [
Jonas Termansend0f79112019-03-22 15:28:26 +0000998 ((['git', 'config', 'rietveld.bug-prefix'],), ''),
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000999 ]
Anthony Polito8b955342019-09-24 19:01:36 +00001000 if not force:
1001 calls += [
1002 ((['git', 'config', 'core.editor'],), ''),
1003 ((['RunEditor'],), description),
1004 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001005 ref_to_push = 'abcdef0123456789'
1006 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001007 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
1008 ((['git', 'config', 'branch.master.remote'],), 'origin'),
1009 ]
1010
1011 if custom_cl_base is None:
1012 calls += [
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001013 ((['get_or_create_merge_base', 'master',
1014 'refs/remotes/origin/master'],),
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001015 'origin/master'),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001016 ]
1017 parent = 'origin/master'
1018 else:
1019 calls += [
1020 ((['git', 'merge-base', '--is-ancestor', custom_cl_base,
1021 'refs/remotes/origin/master'],),
1022 callError(1)), # Means not ancenstor.
1023 (('ask_for_data',
1024 'Do you take responsibility for cleaning up potential mess '
1025 'resulting from proceeding with upload? Press Enter to upload, '
1026 'or Ctrl+C to abort'), ''),
1027 ]
1028 parent = custom_cl_base
1029
1030 calls += [
1031 ((['git', 'rev-parse', 'HEAD:'],), # `HEAD:` means HEAD's tree hash.
1032 '0123456789abcdef'),
1033 ((['git', 'commit-tree', '0123456789abcdef', '-p', parent,
Aaron Gable9a03ae02017-11-03 11:31:07 -07001034 '-F', '/tmp/named'],),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001035 ref_to_push),
1036 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001037 else:
1038 ref_to_push = 'HEAD'
1039
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001040 calls += [
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +00001041 (('SaveDescriptionBackup',), None),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001042 ((['git', 'rev-list',
1043 (custom_cl_base if custom_cl_base else expected_upstream_ref) + '..' +
1044 ref_to_push],),
1045 '1hashPerLine\n'),
1046 ]
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001047
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001048 metrics_arguments = []
1049
Aaron Gableafd52772017-06-27 16:40:10 -07001050 if notify:
Aaron Gable844cf292017-06-28 11:32:59 -07001051 ref_suffix = '%ready,notify=ALL'
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001052 metrics_arguments += ['ready', 'notify=ALL']
Aaron Gable844cf292017-06-28 11:32:59 -07001053 else:
Jamie Madill276da0b2018-04-27 14:41:20 -04001054 if not issue and squash:
Aaron Gable844cf292017-06-28 11:32:59 -07001055 ref_suffix = '%wip'
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001056 metrics_arguments.append('wip')
Aaron Gable844cf292017-06-28 11:32:59 -07001057 else:
1058 ref_suffix = '%notify=NONE'
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001059 metrics_arguments.append('notify=NONE')
Aaron Gable9b713dd2016-12-14 16:04:21 -08001060
Aaron Gable70f4e242017-06-26 10:45:59 -07001061 if title:
Aaron Gableafd52772017-06-27 16:40:10 -07001062 ref_suffix += ',m=' + title
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001063 metrics_arguments.append('m')
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001064
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00001065 calls += [
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +00001066 ((['git', 'config', 'rietveld.cc'],), ''),
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00001067 ]
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001068 if short_hostname == 'chromium':
1069 # All reviwers and ccs get into ref_suffix.
1070 for r in sorted(reviewers):
1071 ref_suffix += ',r=%s' % r
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001072 metrics_arguments.append('r')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001073 for c in sorted(['chromium-reviews+test-more-cc@chromium.org',
1074 'joe@example.com'] + cc):
1075 ref_suffix += ',cc=%s' % c
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001076 metrics_arguments.append('cc')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001077 reviewers, cc = [], []
1078 else:
1079 # TODO(crbug/877717): remove this case.
1080 calls += [
1081 (('ValidAccounts', '%s-review.googlesource.com' % short_hostname,
1082 sorted(reviewers) + ['joe@example.com',
1083 'chromium-reviews+test-more-cc@chromium.org'] + cc),
1084 {
1085 e: {'email': e}
1086 for e in (reviewers + ['joe@example.com'] + cc)
1087 })
1088 ]
1089 for r in sorted(reviewers):
1090 if r != 'bad-account-or-email':
1091 ref_suffix += ',r=%s' % r
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001092 metrics_arguments.append('r')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001093 reviewers.remove(r)
1094 for c in sorted(['joe@example.com'] + cc):
1095 ref_suffix += ',cc=%s' % c
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001096 metrics_arguments.append('cc')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001097 if c in cc:
1098 cc.remove(c)
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00001099
Edward Lemur687ca902018-12-05 02:30:30 +00001100 for k, v in sorted((labels or {}).items()):
1101 ref_suffix += ',l=%s+%d' % (k, v)
1102 metrics_arguments.append('l=%s+%d' % (k, v))
1103
1104 if tbr:
1105 calls += [
1106 (('GetCodeReviewTbrScore',
1107 '%s-review.googlesource.com' % short_hostname,
1108 'my/repo'),
1109 2,),
1110 ]
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001111
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001112 calls += [
1113 (('time.time',), 1000,),
1114 ((['git', 'push',
1115 'https://%s.googlesource.com/my/repo' % short_hostname,
1116 ref_to_push + ':refs/for/refs/heads/master' + ref_suffix],),
1117 (('remote:\n'
1118 'remote: Processing changes: (\)\n'
1119 'remote: Processing changes: (|)\n'
1120 'remote: Processing changes: (/)\n'
1121 'remote: Processing changes: (-)\n'
1122 'remote: Processing changes: new: 1 (/)\n'
1123 'remote: Processing changes: new: 1, done\n'
1124 'remote:\n'
1125 'remote: New Changes:\n'
1126 'remote: https://%s-review.googlesource.com/#/c/my/repo/+/123456'
1127 ' XXX\n'
1128 'remote:\n'
1129 'To https://%s.googlesource.com/my/repo\n'
1130 ' * [new branch] hhhh -> refs/for/refs/heads/master\n'
1131 ) % (short_hostname, short_hostname)),),
1132 (('time.time',), 2000,),
1133 (('add_repeated',
1134 'sub_commands',
1135 {
1136 'execution_time': 1000,
1137 'command': 'git push',
1138 'exit_code': 0,
1139 'arguments': sorted(metrics_arguments),
1140 }),
1141 None,),
1142 ]
1143
Edward Lemur1b52d872019-05-09 21:12:12 +00001144 final_description = final_description or post_amend_description.strip()
1145 original_title = original_title or title or '<untitled>'
1146 # Trace-related calls
1147 calls += [
1148 # Write a description with context for the current trace.
1149 ((['FileWrite', 'TRACES_DIR/20170316T200041.000000-README',
Edward Lemur75391d42019-05-14 23:35:56 +00001150 'Thu Mar 16 20:00:41 2017\n'
1151 '%(short_hostname)s-review.googlesource.com\n'
1152 '%(change_id)s\n'
1153 '%(title)s\n'
1154 '%(description)s\n'
1155 '1000\n'
1156 '0\n'
1157 '%(trace_name)s' % {
Edward Lemur1b52d872019-05-09 21:12:12 +00001158 'short_hostname': short_hostname,
1159 'change_id': change_id,
1160 'description': final_description,
1161 'title': original_title,
Edward Lemur75391d42019-05-14 23:35:56 +00001162 'trace_name': 'TRACES_DIR/20170316T200041.000000',
Edward Lemur1b52d872019-05-09 21:12:12 +00001163 }],),
1164 None,
1165 ),
1166 # Read traces and shorten git hashes.
1167 ((['os.path.isfile', 'TEMP_DIR/trace-packet'],),
1168 True,
1169 ),
1170 ((['FileRead', 'TEMP_DIR/trace-packet'],),
1171 ('git-hash: 0123456789012345678901234567890123456789\n'
1172 'git-hash: abcdeabcdeabcdeabcdeabcdeabcdeabcdeabcde\n'),
1173 ),
1174 ((['FileWrite', 'TEMP_DIR/trace-packet',
1175 'git-hash: 012345\n'
1176 'git-hash: abcdea\n'],),
1177 None,
1178 ),
1179 # Make zip file for the git traces.
1180 ((['make_archive', 'TRACES_DIR/20170316T200041.000000-traces', 'zip',
1181 'TEMP_DIR'],),
1182 None,
1183 ),
1184 # Collect git config and gitcookies.
1185 ((['git', 'config', '-l'],),
1186 'git-config-output',
1187 ),
1188 ((['FileWrite', 'TEMP_DIR/git-config', 'git-config-output'],),
1189 None,
1190 ),
1191 ((['os.path.isfile', '~/.gitcookies'],),
1192 gitcookies_exists,
1193 ),
1194 ]
1195 if gitcookies_exists:
1196 calls += [
1197 ((['FileRead', '~/.gitcookies'],),
1198 'gitcookies 1/SECRET',
1199 ),
1200 ((['FileWrite', 'TEMP_DIR/gitcookies', 'gitcookies REDACTED'],),
1201 None,
1202 ),
1203 ]
1204 calls += [
1205 # Make zip file for the git config and gitcookies.
1206 ((['make_archive', 'TRACES_DIR/20170316T200041.000000-git-info', 'zip',
1207 'TEMP_DIR'],),
1208 None,
1209 ),
1210 ]
1211
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001212 if squash:
1213 calls += [
tandrii33a46ff2016-08-23 05:53:40 -07001214 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
tandrii5d48c322016-08-18 16:19:37 -07001215 ''),
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001216 ((['git', 'config', 'branch.master.gerritserver',
tandrii5d48c322016-08-18 16:19:37 -07001217 'https://chromium-review.googlesource.com'],), ''),
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001218 ((['git', 'config', 'branch.master.gerritsquashhash',
1219 'abcdef0123456789'],), ''),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001220 ]
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001221 # TODO(crbug/877717): this should never be used.
1222 if squash and short_hostname != 'chromium':
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001223 calls += [
1224 (('AddReviewers',
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00001225 'chromium-review.googlesource.com', 'my%2Frepo~123456',
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001226 sorted(reviewers),
Andrii Shyshkalov2f727912018-10-15 17:02:33 +00001227 cc + ['chromium-reviews+test-more-cc@chromium.org'],
1228 notify),
1229 ''),
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001230 ]
tandrii@chromium.org1e67bb72016-02-11 12:15:49 +00001231 calls += cls._git_post_upload_calls()
ukai@chromium.orge8077812012-02-03 03:41:46 +00001232 return calls
1233
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001234 def _run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001235 self,
1236 upload_args,
1237 description,
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00001238 reviewers=None,
tandriia60502f2016-06-20 02:01:53 -07001239 squash=True,
1240 squash_mode=None,
tandrii@chromium.org10625002016-03-04 20:03:47 +00001241 expected_upstream_ref='origin/refs/heads/master',
Aaron Gable9b713dd2016-12-14 16:04:21 -08001242 title=None,
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001243 notify=False,
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001244 post_amend_description=None,
bradnelsond975b302016-10-23 12:20:23 -07001245 issue=None,
Andrii Shyshkalove9c78ff2017-02-06 15:53:13 +01001246 cc=None,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001247 fetched_status=None,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001248 other_cl_owner=None,
Aaron Gablefd238082017-06-07 13:42:34 -07001249 custom_cl_base=None,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001250 tbr=None,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001251 short_hostname='chromium',
Edward Lemur1b52d872019-05-09 21:12:12 +00001252 labels=None,
1253 change_id=None,
1254 original_title=None,
1255 final_description=None,
Anthony Polito8b955342019-09-24 19:01:36 +00001256 gitcookies_exists=True,
1257 force=False,
1258 fetched_description=None):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001259 """Generic gerrit upload test framework."""
tandriia60502f2016-06-20 02:01:53 -07001260 if squash_mode is None:
1261 if '--no-squash' in upload_args:
1262 squash_mode = 'nosquash'
1263 elif '--squash' in upload_args:
1264 squash_mode = 'squash'
1265 else:
1266 squash_mode = 'default'
1267
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00001268 reviewers = reviewers or []
bradnelsond975b302016-10-23 12:20:23 -07001269 cc = cc or []
tandrii@chromium.org28253532016-04-14 13:46:56 +00001270 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
tandrii16e0b4e2016-06-07 10:34:28 -07001271 self.mock(git_cl.gerrit_util, 'CookiesAuthenticator',
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001272 CookiesAuthenticatorMockFactory(
1273 same_auth=('git-owner.example.com', '', 'pass')))
Edward Lemur125d60a2019-09-13 18:25:41 +00001274 self.mock(git_cl.Changelist, '_GerritCommitMsgHookCheck',
tandrii16e0b4e2016-06-07 10:34:28 -07001275 lambda _, offer_removal: None)
tandriia60502f2016-06-20 02:01:53 -07001276 self.mock(git_cl.gclient_utils, 'RunEditor',
1277 lambda *_, **__: self._mocked_call(['RunEditor']))
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001278 self.mock(git_cl, 'DownloadGerritHook', lambda force: self._mocked_call(
1279 'DownloadGerritHook', force))
Edward Lemur1b52d872019-05-09 21:12:12 +00001280 self.mock(git_cl.gclient_utils, 'FileRead',
1281 lambda path: self._mocked_call(['FileRead', path]))
1282 self.mock(git_cl.gclient_utils, 'FileWrite',
1283 lambda path, contents: self._mocked_call(
1284 ['FileWrite', path, contents]))
1285 self.mock(git_cl, 'datetime_now',
1286 lambda: datetime.datetime(2017, 3, 16, 20, 0, 41, 0))
1287 self.mock(git_cl.tempfile, 'mkdtemp', lambda: 'TEMP_DIR')
1288 self.mock(git_cl, 'TRACES_DIR', 'TRACES_DIR')
Edward Lemur75391d42019-05-14 23:35:56 +00001289 self.mock(git_cl, 'TRACES_README_FORMAT',
1290 '%(now)s\n'
1291 '%(gerrit_host)s\n'
1292 '%(change_id)s\n'
1293 '%(title)s\n'
1294 '%(description)s\n'
1295 '%(execution_time)s\n'
1296 '%(exit_code)s\n'
1297 '%(trace_name)s')
Edward Lemur1b52d872019-05-09 21:12:12 +00001298 self.mock(git_cl.shutil, 'make_archive',
1299 lambda *args: self._mocked_call(['make_archive'] + list(args)))
1300 self.mock(os.path, 'isfile',
1301 lambda path: self._mocked_call(['os.path.isfile', path]))
tandriia60502f2016-06-20 02:01:53 -07001302
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001303 self.calls = self._gerrit_base_calls(
1304 issue=issue,
Anthony Polito8b955342019-09-24 19:01:36 +00001305 fetched_description=fetched_description or description,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001306 fetched_status=fetched_status,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001307 other_cl_owner=other_cl_owner,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001308 custom_cl_base=custom_cl_base,
Anthony Polito8b955342019-09-24 19:01:36 +00001309 short_hostname=short_hostname,
1310 change_id=change_id)
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001311 if fetched_status != 'ABANDONED':
Aaron Gable9a03ae02017-11-03 11:31:07 -07001312 self.mock(tempfile, 'NamedTemporaryFile', MakeNamedTemporaryFileMock(
1313 expected_content=description))
1314 self.mock(os, 'remove', lambda _: True)
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001315 self.calls += self._gerrit_upload_calls(
1316 description, reviewers, squash,
1317 squash_mode=squash_mode,
1318 expected_upstream_ref=expected_upstream_ref,
Aaron Gablefd238082017-06-07 13:42:34 -07001319 title=title, notify=notify,
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001320 post_amend_description=post_amend_description,
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00001321 issue=issue, cc=cc,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001322 custom_cl_base=custom_cl_base, tbr=tbr,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001323 short_hostname=short_hostname,
Edward Lemur1b52d872019-05-09 21:12:12 +00001324 labels=labels,
1325 change_id=change_id,
1326 original_title=original_title,
1327 final_description=final_description,
Anthony Polito8b955342019-09-24 19:01:36 +00001328 gitcookies_exists=gitcookies_exists,
1329 force=force)
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +00001330 # Uncomment when debugging.
Raul Tambre80ee78e2019-05-06 22:41:05 +00001331 # print('\n'.join(map(lambda x: '%2i: %s' % x, enumerate(self.calls))))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001332 git_cl.main(['upload'] + upload_args)
1333
Edward Lemur1b52d872019-05-09 21:12:12 +00001334 def test_gerrit_upload_traces_no_gitcookies(self):
1335 self._run_gerrit_upload_test(
1336 ['--no-squash'],
1337 'desc\n\nBUG=\n',
1338 [],
1339 squash=False,
1340 post_amend_description='desc\n\nBUG=\n\nChange-Id: Ixxx',
1341 change_id='Ixxx',
1342 gitcookies_exists=False)
1343
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001344 def test_gerrit_upload_without_change_id(self):
tandriia60502f2016-06-20 02:01:53 -07001345 self._run_gerrit_upload_test(
1346 ['--no-squash'],
1347 'desc\n\nBUG=\n',
1348 [],
1349 squash=False,
Edward Lemur1b52d872019-05-09 21:12:12 +00001350 post_amend_description='desc\n\nBUG=\n\nChange-Id: Ixxx',
1351 change_id='Ixxx')
tandriia60502f2016-06-20 02:01:53 -07001352
1353 def test_gerrit_upload_without_change_id_override_nosquash(self):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001354 self._run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001355 [],
jamesr@chromium.org35d1a842012-07-27 00:20:43 +00001356 'desc\n\nBUG=\n',
tandrii@chromium.org10625002016-03-04 20:03:47 +00001357 [],
tandriia60502f2016-06-20 02:01:53 -07001358 squash=False,
1359 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001360 post_amend_description='desc\n\nBUG=\n\nChange-Id: Ixxx',
1361 change_id='Ixxx')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001362
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001363 def test_gerrit_no_reviewer(self):
1364 self._run_gerrit_upload_test(
1365 [],
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +00001366 'desc\n\nBUG=\n\nChange-Id: I123456789\n',
tandriia60502f2016-06-20 02:01:53 -07001367 [],
1368 squash=False,
Edward Lemur1b52d872019-05-09 21:12:12 +00001369 squash_mode='override_nosquash',
1370 change_id='I123456789')
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001371
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001372 def test_gerrit_no_reviewer_non_chromium_host(self):
1373 # TODO(crbug/877717): remove this test case.
1374 self._run_gerrit_upload_test(
1375 [],
1376 'desc\n\nBUG=\n\nChange-Id: I123456789\n',
1377 [],
1378 squash=False,
1379 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001380 short_hostname='other',
1381 change_id='I123456789')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001382
Nick Carter8692b182017-11-06 16:30:38 -08001383 def test_gerrit_patchset_title_special_chars(self):
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001384 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
1385 self._run_gerrit_upload_test(
Nick Carter8692b182017-11-06 16:30:38 -08001386 ['-f', '-t', 'We\'ll escape ^_ ^ special chars...@{u}'],
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001387 'desc\n\nBUG=\n\nChange-Id: I123456789',
1388 squash=False,
1389 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001390 title='We%27ll_escape_%5E%5F_%5E_special_chars%2E%2E%2E%40%7Bu%7D',
1391 change_id='I123456789',
1392 original_title='We\'ll escape ^_ ^ special chars...@{u}')
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001393
ukai@chromium.orge8077812012-02-03 03:41:46 +00001394 def test_gerrit_reviewers_cmd_line(self):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001395 self._run_gerrit_upload_test(
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001396 ['-r', 'foo@example.com', '--send-mail'],
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +00001397 'desc\n\nBUG=\n\nChange-Id: I123456789',
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001398 ['foo@example.com'],
tandriia60502f2016-06-20 02:01:53 -07001399 squash=False,
1400 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001401 notify=True,
1402 change_id='I123456789',
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001403 final_description=(
1404 'desc\n\nBUG=\nR=foo@example.com\n\nChange-Id: I123456789'))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001405
Anthony Polito8b955342019-09-24 19:01:36 +00001406 def test_gerrit_upload_force_sets_bug(self):
1407 self._run_gerrit_upload_test(
1408 ['-b', '10000', '-f'],
1409 u'desc=\n\nBug: 10000\nChange-Id: Ixxx',
1410 [],
1411 force=True,
1412 expected_upstream_ref='origin/master',
1413 fetched_description='desc=\n\nChange-Id: Ixxx',
1414 original_title='Initial upload',
1415 change_id='Ixxx')
1416
1417 def test_gerrit_upload_force_sets_bug_if_wrong_changeid(self):
1418 self._run_gerrit_upload_test(
1419 ['-b', '10000', '-f', '-m', 'Title'],
1420 u'desc=\n\nChange-Id: Ixxxx\n\nChange-Id: Izzzz\nBug: 10000',
1421 [],
1422 force=True,
1423 issue='123456',
1424 expected_upstream_ref='origin/master',
1425 fetched_description='desc=\n\nChange-Id: Ixxxx',
1426 original_title='Title',
1427 title='Title',
1428 change_id='Izzzz')
1429
ukai@chromium.orge8077812012-02-03 03:41:46 +00001430 def test_gerrit_reviewer_multiple(self):
Edward Lemur687ca902018-12-05 02:30:30 +00001431 self.mock(git_cl.gerrit_util, 'GetCodeReviewTbrScore',
1432 lambda *a: self._mocked_call('GetCodeReviewTbrScore', *a))
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001433 self._run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001434 [],
bradnelsond975b302016-10-23 12:20:23 -07001435 'desc\nTBR=reviewer@example.com\nBUG=\nR=another@example.com\n'
1436 'CC=more@example.com,people@example.com\n\n'
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +09001437 'Change-Id: 123456789',
tandriia60502f2016-06-20 02:01:53 -07001438 ['reviewer@example.com', 'another@example.com'],
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +09001439 expected_upstream_ref='origin/master',
Aaron Gablefd238082017-06-07 13:42:34 -07001440 cc=['more@example.com', 'people@example.com'],
Edward Lemur687ca902018-12-05 02:30:30 +00001441 tbr='reviewer@example.com',
Edward Lemur1b52d872019-05-09 21:12:12 +00001442 labels={'Code-Review': 2},
1443 change_id='123456789',
1444 original_title='Initial upload')
tandriia60502f2016-06-20 02:01:53 -07001445
1446 def test_gerrit_upload_squash_first_is_default(self):
tandriia60502f2016-06-20 02:01:53 -07001447 self._run_gerrit_upload_test(
1448 [],
1449 'desc\nBUG=\n\nChange-Id: 123456789',
1450 [],
Edward Lemur1b52d872019-05-09 21:12:12 +00001451 expected_upstream_ref='origin/master',
1452 change_id='123456789',
1453 original_title='Initial upload')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001454
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001455 def test_gerrit_upload_squash_first(self):
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001456 self._run_gerrit_upload_test(
1457 ['--squash'],
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001458 'desc\nBUG=\n\nChange-Id: 123456789',
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001459 [],
luqui@chromium.org609f3952015-05-04 22:47:04 +00001460 squash=True,
Edward Lemur1b52d872019-05-09 21:12:12 +00001461 expected_upstream_ref='origin/master',
1462 change_id='123456789',
1463 original_title='Initial upload')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001464
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001465 def test_gerrit_upload_squash_first_with_labels(self):
1466 self._run_gerrit_upload_test(
1467 ['--squash', '--cq-dry-run', '--enable-auto-submit'],
1468 'desc\nBUG=\n\nChange-Id: 123456789',
1469 [],
1470 squash=True,
1471 expected_upstream_ref='origin/master',
Edward Lemur1b52d872019-05-09 21:12:12 +00001472 labels={'Commit-Queue': 1, 'Auto-Submit': 1},
1473 change_id='123456789',
1474 original_title='Initial upload')
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001475
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001476 def test_gerrit_upload_squash_first_against_rev(self):
1477 custom_cl_base = 'custom_cl_base_rev_or_branch'
1478 self._run_gerrit_upload_test(
1479 ['--squash', custom_cl_base],
1480 'desc\nBUG=\n\nChange-Id: 123456789',
1481 [],
1482 squash=True,
1483 expected_upstream_ref='origin/master',
Edward Lemur1b52d872019-05-09 21:12:12 +00001484 custom_cl_base=custom_cl_base,
1485 change_id='123456789',
1486 original_title='Initial upload')
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001487 self.assertIn(
1488 'If you proceed with upload, more than 1 CL may be created by Gerrit',
1489 sys.stdout.getvalue())
1490
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001491 def test_gerrit_upload_squash_reupload(self):
1492 description = 'desc\nBUG=\n\nChange-Id: 123456789'
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001493 self._run_gerrit_upload_test(
1494 ['--squash'],
1495 description,
1496 [],
1497 squash=True,
1498 expected_upstream_ref='origin/master',
Edward Lemur1b52d872019-05-09 21:12:12 +00001499 issue=123456,
1500 change_id='123456789',
1501 original_title='User input')
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001502
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001503 def test_gerrit_upload_squash_reupload_to_abandoned(self):
1504 self.mock(git_cl, 'DieWithError',
1505 lambda msg, change=None: self._mocked_call('DieWithError', msg))
1506 description = 'desc\nBUG=\n\nChange-Id: 123456789'
1507 with self.assertRaises(SystemExitMock):
1508 self._run_gerrit_upload_test(
1509 ['--squash'],
1510 description,
1511 [],
1512 squash=True,
1513 expected_upstream_ref='origin/master',
1514 issue=123456,
Edward Lemur1b52d872019-05-09 21:12:12 +00001515 fetched_status='ABANDONED',
1516 change_id='123456789')
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001517
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001518 def test_gerrit_upload_squash_reupload_to_not_owned(self):
1519 self.mock(git_cl.gerrit_util, 'GetAccountDetails',
1520 lambda *_, **__: {'email': 'yet-another@example.com'})
1521 description = 'desc\nBUG=\n\nChange-Id: 123456789'
1522 self._run_gerrit_upload_test(
1523 ['--squash'],
1524 description,
1525 [],
1526 squash=True,
1527 expected_upstream_ref='origin/master',
1528 issue=123456,
Edward Lemur1b52d872019-05-09 21:12:12 +00001529 other_cl_owner='other@example.com',
1530 change_id='123456789',
1531 original_title='User input')
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001532 self.assertIn(
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001533 'WARNING: Change 123456 is owned by other@example.com, but you '
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001534 'authenticate to Gerrit as yet-another@example.com.\n'
1535 'Uploading may fail due to lack of permissions',
1536 git_cl.sys.stdout.getvalue())
1537
rmistry@google.com2dd99862015-06-22 12:22:18 +00001538 def test_upload_branch_deps(self):
tandrii@chromium.org28253532016-04-14 13:46:56 +00001539 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
rmistry@google.com2dd99862015-06-22 12:22:18 +00001540 def mock_run_git(*args, **_kwargs):
1541 if args[0] == ['for-each-ref',
1542 '--format=%(refname:short) %(upstream:short)',
1543 'refs/heads']:
1544 # Create a local branch dependency tree that looks like this:
1545 # test1 -> test2 -> test3 -> test4 -> test5
1546 # -> test3.1
1547 # test6 -> test0
1548 branch_deps = [
1549 'test2 test1', # test1 -> test2
1550 'test3 test2', # test2 -> test3
1551 'test3.1 test2', # test2 -> test3.1
1552 'test4 test3', # test3 -> test4
1553 'test5 test4', # test4 -> test5
1554 'test6 test0', # test0 -> test6
1555 'test7', # test7
1556 ]
1557 return '\n'.join(branch_deps)
1558 self.mock(git_cl, 'RunGit', mock_run_git)
1559
1560 class RecordCalls:
1561 times_called = 0
1562 record_calls = RecordCalls()
1563 def mock_CMDupload(*args, **_kwargs):
1564 record_calls.times_called += 1
1565 return 0
1566 self.mock(git_cl, 'CMDupload', mock_CMDupload)
1567
1568 self.calls = [
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01001569 (('ask_for_data', 'This command will checkout all dependent branches '
1570 'and run "git cl upload". Press Enter to continue, '
1571 'or Ctrl+C to abort'), ''),
1572 ]
rmistry@google.com2dd99862015-06-22 12:22:18 +00001573
1574 class MockChangelist():
1575 def __init__(self):
1576 pass
1577 def GetBranch(self):
1578 return 'test1'
1579 def GetIssue(self):
1580 return '123'
1581 def GetPatchset(self):
1582 return '1001'
tandrii@chromium.org4c72b082016-03-31 22:26:35 +00001583 def IsGerrit(self):
1584 return False
rmistry@google.com2dd99862015-06-22 12:22:18 +00001585
1586 ret = git_cl.upload_branch_deps(MockChangelist(), [])
1587 # CMDupload should have been called 5 times because of 5 dependent branches.
1588 self.assertEquals(5, record_calls.times_called)
1589 self.assertEquals(0, ret)
1590
tandrii@chromium.org65874e12016-03-04 12:03:02 +00001591 def test_gerrit_change_id(self):
1592 self.calls = [
1593 ((['git', 'write-tree'], ),
1594 'hashtree'),
1595 ((['git', 'rev-parse', 'HEAD~0'], ),
1596 'branch-parent'),
1597 ((['git', 'var', 'GIT_AUTHOR_IDENT'], ),
1598 'A B <a@b.org> 1456848326 +0100'),
1599 ((['git', 'var', 'GIT_COMMITTER_IDENT'], ),
1600 'C D <c@d.org> 1456858326 +0100'),
1601 ((['git', 'hash-object', '-t', 'commit', '--stdin'], ),
1602 'hashchange'),
1603 ]
1604 change_id = git_cl.GenerateGerritChangeId('line1\nline2\n')
1605 self.assertEqual(change_id, 'Ihashchange')
1606
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00001607 def test_desecription_append_footer(self):
1608 for init_desc, footer_line, expected_desc in [
1609 # Use unique desc first lines for easy test failure identification.
1610 ('foo', 'R=one', 'foo\n\nR=one'),
1611 ('foo\n\nR=one', 'BUG=', 'foo\n\nR=one\nBUG='),
1612 ('foo\n\nR=one', 'Change-Id: Ixx', 'foo\n\nR=one\n\nChange-Id: Ixx'),
1613 ('foo\n\nChange-Id: Ixx', 'R=one', 'foo\n\nR=one\n\nChange-Id: Ixx'),
1614 ('foo\n\nR=one\n\nChange-Id: Ixx', 'TBR=two',
1615 'foo\n\nR=one\nTBR=two\n\nChange-Id: Ixx'),
1616 ('foo\n\nR=one\n\nChange-Id: Ixx', 'Foo-Bar: baz',
1617 'foo\n\nR=one\n\nChange-Id: Ixx\nFoo-Bar: baz'),
1618 ('foo\n\nChange-Id: Ixx', 'Foo-Bak: baz',
1619 'foo\n\nChange-Id: Ixx\nFoo-Bak: baz'),
1620 ('foo', 'Change-Id: Ixx', 'foo\n\nChange-Id: Ixx'),
1621 ]:
1622 desc = git_cl.ChangeDescription(init_desc)
1623 desc.append_footer(footer_line)
1624 self.assertEqual(desc.description, expected_desc)
1625
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001626 def test_update_reviewers(self):
1627 data = [
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001628 ('foo', [], [],
1629 'foo'),
1630 ('foo\nR=xx', [], [],
1631 'foo\nR=xx'),
1632 ('foo\nTBR=xx', [], [],
1633 'foo\nTBR=xx'),
1634 ('foo', ['a@c'], [],
1635 'foo\n\nR=a@c'),
1636 ('foo\nR=xx', ['a@c'], [],
1637 'foo\n\nR=a@c, xx'),
1638 ('foo\nTBR=xx', ['a@c'], [],
1639 'foo\n\nR=a@c\nTBR=xx'),
1640 ('foo\nTBR=xx\nR=yy', ['a@c'], [],
1641 'foo\n\nR=a@c, yy\nTBR=xx'),
1642 ('foo\nBUG=', ['a@c'], [],
1643 'foo\nBUG=\nR=a@c'),
1644 ('foo\nR=xx\nTBR=yy\nR=bar', ['a@c'], [],
1645 'foo\n\nR=a@c, bar, xx\nTBR=yy'),
1646 ('foo', ['a@c', 'b@c'], [],
1647 'foo\n\nR=a@c, b@c'),
1648 ('foo\nBar\n\nR=\nBUG=', ['c@c'], [],
1649 'foo\nBar\n\nR=c@c\nBUG='),
1650 ('foo\nBar\n\nR=\nBUG=\nR=', ['c@c'], [],
1651 'foo\nBar\n\nR=c@c\nBUG='),
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001652 # Same as the line before, but full of whitespaces.
1653 (
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001654 'foo\nBar\n\n R = \n BUG = \n R = ', ['c@c'], [],
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001655 'foo\nBar\n\nR=c@c\n BUG =',
1656 ),
1657 # Whitespaces aren't interpreted as new lines.
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001658 ('foo BUG=allo R=joe ', ['c@c'], [],
1659 'foo BUG=allo R=joe\n\nR=c@c'),
1660 # Redundant TBRs get promoted to Rs
1661 ('foo\n\nR=a@c\nTBR=t@c', ['b@c', 'a@c'], ['a@c', 't@c'],
1662 'foo\n\nR=a@c, b@c\nTBR=t@c'),
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001663 ]
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001664 expected = [i[-1] for i in data]
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001665 actual = []
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001666 for orig, reviewers, tbrs, _expected in data:
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001667 obj = git_cl.ChangeDescription(orig)
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001668 obj.update_reviewers(reviewers, tbrs)
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001669 actual.append(obj.description)
1670 self.assertEqual(expected, actual)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001671
Nodir Turakulov23b82142017-11-16 11:04:25 -08001672 def test_get_hash_tags(self):
1673 cases = [
1674 ('', []),
1675 ('a', []),
1676 ('[a]', ['a']),
1677 ('[aa]', ['aa']),
1678 ('[a ]', ['a']),
1679 ('[a- ]', ['a']),
1680 ('[a- b]', ['a-b']),
1681 ('[a--b]', ['a-b']),
1682 ('[a', []),
1683 ('[a]x', ['a']),
1684 ('[aa]x', ['aa']),
1685 ('[a b]', ['a-b']),
1686 ('[a b]', ['a-b']),
1687 ('[a__b]', ['a-b']),
1688 ('[a] x', ['a']),
1689 ('[a][b]', ['a', 'b']),
1690 ('[a] [b]', ['a', 'b']),
1691 ('[a][b]x', ['a', 'b']),
1692 ('[a][b] x', ['a', 'b']),
1693 ('[a]\n[b]', ['a']),
1694 ('[a\nb]', []),
1695 ('[a][', ['a']),
1696 ('Revert "[a] feature"', ['a']),
1697 ('Reland "[a] feature"', ['a']),
1698 ('Revert: [a] feature', ['a']),
1699 ('Reland: [a] feature', ['a']),
1700 ('Revert "Reland: [a] feature"', ['a']),
1701 ('Foo: feature', ['foo']),
1702 ('Foo Bar: feature', ['foo-bar']),
1703 ('Revert "Foo bar: feature"', ['foo-bar']),
1704 ('Reland "Foo bar: feature"', ['foo-bar']),
1705 ]
1706 for desc, expected in cases:
1707 change_desc = git_cl.ChangeDescription(desc)
1708 actual = change_desc.get_hash_tags()
1709 self.assertEqual(
1710 actual,
1711 expected,
1712 'GetHashTags(%r) == %r, expected %r' % (desc, actual, expected))
1713
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001714 self.assertEqual(None, git_cl.GetTargetRef('origin', None, 'master'))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001715 self.assertEqual(None, git_cl.GetTargetRef(None,
1716 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001717 'master'))
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001718
wittman@chromium.org455dc922015-01-26 20:15:50 +00001719 # Check default target refs for branches.
1720 self.assertEqual('refs/heads/master',
1721 git_cl.GetTargetRef('origin', 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001722 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001723 self.assertEqual('refs/heads/master',
1724 git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkgr',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001725 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001726 self.assertEqual('refs/heads/master',
1727 git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkcr',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001728 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001729 self.assertEqual('refs/branch-heads/123',
1730 git_cl.GetTargetRef('origin',
1731 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001732 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001733 self.assertEqual('refs/diff/test',
1734 git_cl.GetTargetRef('origin',
1735 'refs/remotes/origin/refs/diff/test',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001736 None))
rmistry@google.comc68112d2015-03-03 12:48:06 +00001737 self.assertEqual('refs/heads/chrome/m42',
1738 git_cl.GetTargetRef('origin',
1739 'refs/remotes/origin/chrome/m42',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001740 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001741
1742 # Check target refs for user-specified target branch.
1743 for branch in ('branch-heads/123', 'remotes/branch-heads/123',
1744 'refs/remotes/branch-heads/123'):
1745 self.assertEqual('refs/branch-heads/123',
1746 git_cl.GetTargetRef('origin',
1747 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001748 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001749 for branch in ('origin/master', 'remotes/origin/master',
1750 'refs/remotes/origin/master'):
1751 self.assertEqual('refs/heads/master',
1752 git_cl.GetTargetRef('origin',
1753 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001754 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001755 for branch in ('master', 'heads/master', 'refs/heads/master'):
1756 self.assertEqual('refs/heads/master',
1757 git_cl.GetTargetRef('origin',
1758 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001759 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001760
wychen@chromium.orga872e752015-04-28 23:42:18 +00001761 def test_patch_when_dirty(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001762 # Patch when local tree is dirty.
wychen@chromium.orga872e752015-04-28 23:42:18 +00001763 self.mock(git_common, 'is_dirty_git_tree', lambda x: True)
1764 self.assertNotEqual(git_cl.main(['patch', '123456']), 0)
1765
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001766 @staticmethod
1767 def _get_gerrit_codereview_server_calls(branch, value=None,
1768 git_short_host='host',
Aaron Gable697a91b2018-01-19 15:20:15 -08001769 detect_branch=True,
1770 detect_server=True):
Edward Lemur125d60a2019-09-13 18:25:41 +00001771 """Returns calls executed by Changelist.GetCodereviewServer.
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001772
1773 If value is given, branch.<BRANCH>.gerritcodereview is already set.
1774 """
1775 calls = []
1776 if detect_branch:
1777 calls.append(((['git', 'symbolic-ref', 'HEAD'],), branch))
Aaron Gable697a91b2018-01-19 15:20:15 -08001778 if detect_server:
1779 calls.append(((['git', 'config', 'branch.' + branch + '.gerritserver'],),
1780 CERR1 if value is None else value))
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001781 if value is None:
1782 calls += [
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001783 ((['git', 'config', 'branch.' + branch + '.merge'],),
1784 'refs/heads' + branch),
1785 ((['git', 'config', 'branch.' + branch + '.remote'],),
1786 'origin'),
1787 ((['git', 'config', 'remote.origin.url'],),
1788 'https://%s.googlesource.com/my/repo' % git_short_host),
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001789 ]
1790 return calls
1791
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001792 def _patch_common(self, force_codereview=False,
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001793 new_branch=False, git_short_host='host',
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001794 detect_gerrit_server=False,
1795 actual_codereview=None,
1796 codereview_in_url=False):
tandrii@chromium.org28253532016-04-14 13:46:56 +00001797 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
wychen@chromium.orga872e752015-04-28 23:42:18 +00001798 self.mock(git_cl, 'IsGitVersionAtLeast', lambda *args: True)
1799
tandriidf09a462016-08-18 16:23:55 -07001800 if new_branch:
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001801 self.calls = [((['git', 'new-branch', 'master'],), '')]
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001802
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001803 if codereview_in_url and actual_codereview == 'rietveld':
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001804 self.calls += [
1805 ((['git', 'rev-parse', '--show-cdup'],), ''),
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001806 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001807 ]
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001808
1809 if not force_codereview and not codereview_in_url:
1810 # These calls detect codereview to use.
1811 self.calls += [
1812 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001813 ]
1814 if detect_gerrit_server:
1815 self.calls += self._get_gerrit_codereview_server_calls(
1816 'master', git_short_host=git_short_host,
1817 detect_branch=not new_branch and force_codereview)
1818 actual_codereview = 'gerrit'
1819
1820 if actual_codereview == 'gerrit':
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001821 self.calls += [
1822 (('GetChangeDetail', git_short_host + '-review.googlesource.com',
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001823 'my%2Frepo~123456', ['ALL_REVISIONS', 'CURRENT_COMMIT']),
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001824 {
1825 'current_revision': '7777777777',
1826 'revisions': {
1827 '1111111111': {
1828 '_number': 1,
1829 'fetch': {'http': {
1830 'url': 'https://%s.googlesource.com/my/repo' % git_short_host,
1831 'ref': 'refs/changes/56/123456/1',
1832 }},
1833 },
1834 '7777777777': {
1835 '_number': 7,
1836 'fetch': {'http': {
1837 'url': 'https://%s.googlesource.com/my/repo' % git_short_host,
1838 'ref': 'refs/changes/56/123456/7',
1839 }},
1840 },
1841 },
1842 }),
1843 ]
wychen@chromium.orga872e752015-04-28 23:42:18 +00001844
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001845 def test_patch_gerrit_default(self):
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001846 self._patch_common(git_short_host='chromium', detect_gerrit_server=True)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001847 self.calls += [
1848 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
1849 'refs/changes/56/123456/7'],), ''),
Aaron Gable62619a32017-06-16 08:22:09 -07001850 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001851 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
Aaron Gable697a91b2018-01-19 15:20:15 -08001852 ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001853 ((['git', 'config', 'branch.master.gerritserver',
1854 'https://chromium-review.googlesource.com'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001855 ((['git', 'config', 'branch.master.gerritpatchset', '7'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001856 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1857 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1858 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001859 ]
1860 self.assertEqual(git_cl.main(['patch', '123456']), 0)
1861
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001862 def test_patch_gerrit_new_branch(self):
1863 self._patch_common(
1864 git_short_host='chromium', detect_gerrit_server=True, new_branch=True)
1865 self.calls += [
1866 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
1867 'refs/changes/56/123456/7'],), ''),
1868 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
1869 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
1870 ''),
1871 ((['git', 'config', 'branch.master.gerritserver',
1872 'https://chromium-review.googlesource.com'],), ''),
1873 ((['git', 'config', 'branch.master.gerritpatchset', '7'],), ''),
1874 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1875 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1876 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
1877 ]
1878 self.assertEqual(git_cl.main(['patch', '-b', 'master', '123456']), 0)
1879
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001880 def test_patch_gerrit_force(self):
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001881 self._patch_common(
1882 force_codereview=True, git_short_host='host', detect_gerrit_server=True)
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001883 self.calls += [
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001884 ((['git', 'fetch', 'https://host.googlesource.com/my/repo',
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001885 'refs/changes/56/123456/7'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001886 ((['git', 'reset', '--hard', 'FETCH_HEAD'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001887 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
tandrii5d48c322016-08-18 16:19:37 -07001888 ''),
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001889 ((['git', 'config', 'branch.master.gerritserver',
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001890 'https://host-review.googlesource.com'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001891 ((['git', 'config', 'branch.master.gerritpatchset', '7'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001892 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1893 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1894 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001895 ]
Aaron Gable62619a32017-06-16 08:22:09 -07001896 self.assertEqual(git_cl.main(['patch', '--gerrit', '123456', '--force']), 0)
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001897
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001898 def test_patch_gerrit_guess_by_url(self):
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001899 self.calls += self._get_gerrit_codereview_server_calls(
1900 'master', git_short_host='else', detect_server=False)
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001901 self._patch_common(
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001902 actual_codereview='gerrit', git_short_host='else',
1903 codereview_in_url=True, detect_gerrit_server=False)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001904 self.calls += [
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001905 ((['git', 'fetch', 'https://else.googlesource.com/my/repo',
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001906 'refs/changes/56/123456/1'],), ''),
Aaron Gable62619a32017-06-16 08:22:09 -07001907 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001908 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
tandrii5d48c322016-08-18 16:19:37 -07001909 ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001910 ((['git', 'config', 'branch.master.gerritserver',
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001911 'https://else-review.googlesource.com'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001912 ((['git', 'config', 'branch.master.gerritpatchset', '1'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001913 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1914 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1915 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001916 ]
1917 self.assertEqual(git_cl.main(
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001918 ['patch', 'https://else-review.googlesource.com/#/c/123456/1']), 0)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001919
Aaron Gable697a91b2018-01-19 15:20:15 -08001920 def test_patch_gerrit_guess_by_url_with_repo(self):
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001921 self.calls += self._get_gerrit_codereview_server_calls(
1922 'master', git_short_host='else', detect_server=False)
Aaron Gable697a91b2018-01-19 15:20:15 -08001923 self._patch_common(
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001924 actual_codereview='gerrit', git_short_host='else',
1925 codereview_in_url=True, detect_gerrit_server=False)
Aaron Gable697a91b2018-01-19 15:20:15 -08001926 self.calls += [
1927 ((['git', 'fetch', 'https://else.googlesource.com/my/repo',
1928 'refs/changes/56/123456/1'],), ''),
1929 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
1930 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
1931 ''),
1932 ((['git', 'config', 'branch.master.gerritserver',
1933 'https://else-review.googlesource.com'],), ''),
1934 ((['git', 'config', 'branch.master.gerritpatchset', '1'],), ''),
1935 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1936 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1937 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
1938 ]
1939 self.assertEqual(git_cl.main(
1940 ['patch', 'https://else-review.googlesource.com/c/my/repo/+/123456/1']),
1941 0)
1942
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001943 def test_patch_gerrit_conflict(self):
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001944 self._patch_common(detect_gerrit_server=True, git_short_host='chromium')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001945 self.calls += [
1946 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001947 'refs/changes/56/123456/7'],), ''),
tandrii5d48c322016-08-18 16:19:37 -07001948 ((['git', 'cherry-pick', 'FETCH_HEAD'],), CERR1),
1949 ((['DieWithError', 'Command "git cherry-pick FETCH_HEAD" failed.\n'],),
1950 SystemExitMock()),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001951 ]
1952 with self.assertRaises(SystemExitMock):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001953 git_cl.main(['patch', '123456'])
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001954
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001955 def test_patch_gerrit_not_exists(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001956
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01001957 def notExists(_issue, *_, **kwargs):
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01001958 raise git_cl.gerrit_util.GerritError(404, '')
1959 self.mock(git_cl.gerrit_util, 'GetChangeDetail', notExists)
1960
tandriic2405f52016-10-10 08:13:15 -07001961 self.calls = [
1962 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001963 ((['git', 'config', 'branch.master.gerritserver'],), CERR1),
1964 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
1965 ((['git', 'config', 'branch.master.remote'],), 'origin'),
1966 ((['git', 'config', 'remote.origin.url'],),
1967 'https://chromium.googlesource.com/my/repo'),
1968 ((['DieWithError',
1969 'change 123456 at https://chromium-review.googlesource.com does not '
1970 'exist or you have no access to it'],), SystemExitMock()),
tandriic2405f52016-10-10 08:13:15 -07001971 ]
1972 with self.assertRaises(SystemExitMock):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001973 self.assertEqual(1, git_cl.main(['patch', '123456']))
tandriic2405f52016-10-10 08:13:15 -07001974
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001975 def _checkout_calls(self):
1976 return [
1977 ((['git', 'config', '--local', '--get-regexp',
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001978 'branch\\..*\\.gerritissue'], ),
1979 ('branch.ger-branch.gerritissue 123456\n'
1980 'branch.gbranch654.gerritissue 654321\n')),
1981 ]
1982
1983 def test_checkout_gerrit(self):
1984 """Tests git cl checkout <issue>."""
1985 self.calls = self._checkout_calls()
1986 self.calls += [((['git', 'checkout', 'ger-branch'], ), '')]
1987 self.assertEqual(0, git_cl.main(['checkout', '123456']))
1988
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001989 def test_checkout_not_found(self):
1990 """Tests git cl checkout <issue>."""
tandrii@chromium.org28253532016-04-14 13:46:56 +00001991 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001992 self.calls = self._checkout_calls()
1993 self.assertEqual(1, git_cl.main(['checkout', '99999']))
1994
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001995 def test_checkout_no_branch_issues(self):
1996 """Tests git cl checkout <issue>."""
tandrii@chromium.org28253532016-04-14 13:46:56 +00001997 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001998 self.calls = [
1999 ((['git', 'config', '--local', '--get-regexp',
tandrii5d48c322016-08-18 16:19:37 -07002000 'branch\\..*\\.gerritissue'], ), CERR1),
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00002001 ]
2002 self.assertEqual(1, git_cl.main(['checkout', '99999']))
2003
tandrii@chromium.org28253532016-04-14 13:46:56 +00002004 def _test_gerrit_ensure_authenticated_common(self, auth,
2005 skip_auth_check=False):
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002006 self.mock(git_cl.gerrit_util, 'CookiesAuthenticator',
2007 CookiesAuthenticatorMockFactory(hosts_with_creds=auth))
2008 self.mock(git_cl, 'DieWithError',
Christopher Lamf732cd52017-01-24 12:40:11 +11002009 lambda msg, change=None: self._mocked_call(['DieWithError', msg]))
tandrii@chromium.org28253532016-04-14 13:46:56 +00002010 self.calls = self._gerrit_ensure_auth_calls(skip_auth_check=skip_auth_check)
Edward Lemurf38bc172019-09-03 21:02:13 +00002011 cl = git_cl.Changelist()
tandrii@chromium.org28253532016-04-14 13:46:56 +00002012 cl.branch = 'master'
2013 cl.branchref = 'refs/heads/master'
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002014 return cl
2015
2016 def test_gerrit_ensure_authenticated_missing(self):
2017 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01002018 'chromium.googlesource.com': ('git-is.ok', '', 'but gerrit is missing'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002019 })
2020 self.calls.append(
2021 ((['DieWithError',
2022 'Credentials for the following hosts are required:\n'
2023 ' chromium-review.googlesource.com\n'
2024 'These are read from ~/.gitcookies (or legacy ~/.netrc)\n'
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01002025 'You can (re)generate your credentials by visiting '
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002026 'https://chromium-review.googlesource.com/new-password'],), ''),)
2027 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2028
2029 def test_gerrit_ensure_authenticated_conflict(self):
tandrii@chromium.org28253532016-04-14 13:46:56 +00002030 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002031 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01002032 'chromium.googlesource.com':
2033 ('git-one.example.com', None, 'secret1'),
2034 'chromium-review.googlesource.com':
2035 ('git-other.example.com', None, 'secret2'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002036 })
2037 self.calls.append(
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002038 (('ask_for_data', 'If you know what you are doing '
2039 'press Enter to continue, or Ctrl+C to abort'), ''))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002040 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2041
2042 def test_gerrit_ensure_authenticated_ok(self):
2043 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01002044 'chromium.googlesource.com':
2045 ('git-same.example.com', None, 'secret'),
2046 'chromium-review.googlesource.com':
2047 ('git-same.example.com', None, 'secret'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002048 })
2049 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2050
tandrii@chromium.org28253532016-04-14 13:46:56 +00002051 def test_gerrit_ensure_authenticated_skipped(self):
2052 cl = self._test_gerrit_ensure_authenticated_common(
2053 auth={}, skip_auth_check=True)
2054 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2055
Eric Boren2fb63102018-10-05 13:05:03 +00002056 def test_gerrit_ensure_authenticated_bearer_token(self):
2057 cl = self._test_gerrit_ensure_authenticated_common(auth={
2058 'chromium.googlesource.com':
2059 ('', None, 'secret'),
2060 'chromium-review.googlesource.com':
2061 ('', None, 'secret'),
2062 })
2063 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2064 header = gerrit_util.CookiesAuthenticator().get_auth_header(
2065 'chromium.googlesource.com')
2066 self.assertTrue('Bearer' in header)
2067
Daniel Chengcf6269b2019-05-18 01:02:12 +00002068 def test_gerrit_ensure_authenticated_non_https(self):
2069 self.calls = [
2070 ((['git', 'config', '--bool',
2071 'gerrit.skip-ensure-authenticated'],), CERR1),
2072 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
2073 ((['git', 'config', 'branch.master.remote'],), 'origin'),
2074 ((['git', 'config', 'remote.origin.url'],), 'custom-scheme://repo'),
2075 ]
2076 self.mock(git_cl.gerrit_util, 'CookiesAuthenticator',
2077 CookiesAuthenticatorMockFactory(hosts_with_creds={}))
Edward Lemurf38bc172019-09-03 21:02:13 +00002078 cl = git_cl.Changelist()
Daniel Chengcf6269b2019-05-18 01:02:12 +00002079 cl.branch = 'master'
2080 cl.branchref = 'refs/heads/master'
2081 cl.lookedup_issue = True
2082 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2083
Andrii Shyshkalov828701b2016-12-09 10:46:47 +01002084 def _cmd_set_commit_gerrit_common(self, vote, notify=None):
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002085 self.mock(git_cl.gerrit_util, 'SetReview',
Andrii Shyshkalov828701b2016-12-09 10:46:47 +01002086 lambda h, i, labels, notify=None:
2087 self._mocked_call(['SetReview', h, i, labels, notify]))
2088
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002089 self.calls = [
2090 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii33a46ff2016-08-23 05:53:40 -07002091 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002092 ((['git', 'config', 'branch.feature.gerritserver'],),
2093 'https://chromium-review.googlesource.com'),
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002094 ((['git', 'config', 'branch.feature.merge'],), 'refs/heads/master'),
2095 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
2096 ((['git', 'config', 'remote.origin.url'],),
2097 'https://chromium.googlesource.com/infra/infra.git'),
2098 ((['SetReview', 'chromium-review.googlesource.com',
2099 'infra%2Finfra~123',
Andrii Shyshkalov828701b2016-12-09 10:46:47 +01002100 {'Commit-Queue': vote}, notify],), ''),
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002101 ]
tandriid9e5ce52016-07-13 02:32:59 -07002102
2103 def test_cmd_set_commit_gerrit_clear(self):
2104 self._cmd_set_commit_gerrit_common(0)
2105 self.assertEqual(0, git_cl.main(['set-commit', '-c']))
2106
2107 def test_cmd_set_commit_gerrit_dry(self):
Aaron Gable75e78722017-06-09 10:40:16 -07002108 self._cmd_set_commit_gerrit_common(1, notify=False)
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002109 self.assertEqual(0, git_cl.main(['set-commit', '-d']))
2110
tandriid9e5ce52016-07-13 02:32:59 -07002111 def test_cmd_set_commit_gerrit(self):
2112 self._cmd_set_commit_gerrit_common(2)
2113 self.assertEqual(0, git_cl.main(['set-commit']))
2114
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002115 def test_description_display(self):
2116 out = StringIO.StringIO()
2117 self.mock(git_cl.sys, 'stdout', out)
2118
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002119 self.mock(git_cl, 'Changelist', ChangelistMock)
2120 ChangelistMock.desc = 'foo\n'
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002121
2122 self.assertEqual(0, git_cl.main(['description', '-d']))
2123 self.assertEqual('foo\n', out.getvalue())
2124
iannucci3c972b92016-08-17 13:24:10 -07002125 def test_StatusFieldOverrideIssueMissingArgs(self):
2126 out = StringIO.StringIO()
2127 self.mock(git_cl.sys, 'stderr', out)
2128
2129 try:
2130 self.assertEqual(git_cl.main(['status', '--issue', '1']), 0)
2131 except SystemExit as ex:
2132 self.assertEqual(ex.code, 2)
Edward Lemurf38bc172019-09-03 21:02:13 +00002133 self.assertRegexpMatches(out.getvalue(), r'--field must be specified')
iannucci3c972b92016-08-17 13:24:10 -07002134
2135 out = StringIO.StringIO()
2136 self.mock(git_cl.sys, 'stderr', out)
2137
2138 try:
Andrii Shyshkalovfeec80e2018-10-16 01:00:47 +00002139 self.assertEqual(git_cl.main(['status', '--issue', '1', '--gerrit']), 0)
iannucci3c972b92016-08-17 13:24:10 -07002140 except SystemExit as ex:
2141 self.assertEqual(ex.code, 2)
iannuccie53c9352016-08-17 14:40:40 -07002142 self.assertRegexpMatches(out.getvalue(), r'--field must be specified')
iannucci3c972b92016-08-17 13:24:10 -07002143
2144 def test_StatusFieldOverrideIssue(self):
2145 out = StringIO.StringIO()
2146 self.mock(git_cl.sys, 'stdout', out)
2147
2148 def assertIssue(cl_self, *_args):
2149 self.assertEquals(cl_self.issue, 1)
2150 return 'foobar'
2151
2152 self.mock(git_cl.Changelist, 'GetDescription', assertIssue)
iannuccie53c9352016-08-17 14:40:40 -07002153 self.assertEqual(
Andrii Shyshkalovfeec80e2018-10-16 01:00:47 +00002154 git_cl.main(['status', '--issue', '1', '--gerrit', '--field', 'desc']),
iannuccie53c9352016-08-17 14:40:40 -07002155 0)
iannucci3c972b92016-08-17 13:24:10 -07002156 self.assertEqual(out.getvalue(), 'foobar\n')
2157
iannuccie53c9352016-08-17 14:40:40 -07002158 def test_SetCloseOverrideIssue(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002159
iannuccie53c9352016-08-17 14:40:40 -07002160 def assertIssue(cl_self, *_args):
2161 self.assertEquals(cl_self.issue, 1)
2162 return 'foobar'
2163
2164 self.mock(git_cl.Changelist, 'GetDescription', assertIssue)
2165 self.mock(git_cl.Changelist, 'CloseIssue', lambda *_: None)
iannuccie53c9352016-08-17 14:40:40 -07002166 self.assertEqual(
Andrii Shyshkalovfeec80e2018-10-16 01:00:47 +00002167 git_cl.main(['set-close', '--issue', '1', '--gerrit']), 0)
iannuccie53c9352016-08-17 14:40:40 -07002168
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00002169 def test_description(self):
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002170 out = StringIO.StringIO()
2171 self.mock(git_cl.sys, 'stdout', out)
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01002172 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002173 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
2174 ((['git', 'config', 'branch.feature.merge'],), 'feature'),
2175 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
2176 ((['git', 'config', 'remote.origin.url'],),
2177 'https://chromium.googlesource.com/my/repo'),
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00002178 (('GetChangeDetail', 'chromium-review.googlesource.com',
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002179 'my%2Frepo~123123', ['CURRENT_REVISION', 'CURRENT_COMMIT']),
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01002180 {
2181 'current_revision': 'sha1',
2182 'revisions': {'sha1': {
2183 'commit': {'message': 'foobar'},
2184 }},
2185 }),
2186 ]
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002187 self.assertEqual(0, git_cl.main([
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00002188 'description',
2189 'https://chromium-review.googlesource.com/c/my/repo/+/123123',
2190 '-d']))
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002191 self.assertEqual('foobar\n', out.getvalue())
2192
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002193 def test_description_set_raw(self):
2194 out = StringIO.StringIO()
2195 self.mock(git_cl.sys, 'stdout', out)
2196
2197 self.mock(git_cl, 'Changelist', ChangelistMock)
2198 self.mock(git_cl.sys, 'stdin', StringIO.StringIO('hihi'))
2199
2200 self.assertEqual(0, git_cl.main(['description', '-n', 'hihi']))
2201 self.assertEqual('hihi', ChangelistMock.desc)
2202
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002203 def test_description_appends_bug_line(self):
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002204 current_desc = 'Some.\n\nChange-Id: xxx'
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002205
2206 def RunEditor(desc, _, **kwargs):
2207 self.assertEquals(
2208 '# Enter a description of the change.\n'
2209 '# This will be displayed on the codereview site.\n'
2210 '# The first line will also be used as the subject of the review.\n'
2211 '#--------------------This line is 72 characters long'
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002212 '--------------------\n'
Aaron Gable3a16ed12017-03-23 10:51:55 -07002213 'Some.\n\nChange-Id: xxx\nBug: ',
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002214 desc)
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002215 # Simulate user changing something.
Aaron Gable3a16ed12017-03-23 10:51:55 -07002216 return 'Some.\n\nChange-Id: xxx\nBug: 123'
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002217
dsansomee2d6fd92016-09-08 00:10:47 -07002218 def UpdateDescriptionRemote(_, desc, force=False):
Aaron Gable3a16ed12017-03-23 10:51:55 -07002219 self.assertEquals(desc, 'Some.\n\nChange-Id: xxx\nBug: 123')
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002220
2221 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2222 self.mock(git_cl.Changelist, 'GetDescription',
2223 lambda *args: current_desc)
Edward Lemur125d60a2019-09-13 18:25:41 +00002224 self.mock(git_cl.Changelist, 'UpdateDescriptionRemote',
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002225 UpdateDescriptionRemote)
2226 self.mock(git_cl.gclient_utils, 'RunEditor', RunEditor)
2227
2228 self.calls = [
2229 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii33a46ff2016-08-23 05:53:40 -07002230 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
tandrii5d48c322016-08-18 16:19:37 -07002231 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
2232 ((['git', 'config', 'rietveld.bug-prefix'],), CERR1),
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002233 ((['git', 'config', 'core.editor'],), 'vi'),
2234 ]
2235 self.assertEqual(0, git_cl.main(['description', '--gerrit']))
2236
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002237 def test_description_set_stdin(self):
2238 out = StringIO.StringIO()
2239 self.mock(git_cl.sys, 'stdout', out)
2240
2241 self.mock(git_cl, 'Changelist', ChangelistMock)
2242 self.mock(git_cl.sys, 'stdin', StringIO.StringIO('hi \r\n\t there\n\nman'))
2243
2244 self.assertEqual(0, git_cl.main(['description', '-n', '-']))
2245 self.assertEqual('hi\n\t there\n\nman', ChangelistMock.desc)
2246
kmarshall3bff56b2016-06-06 18:31:47 -07002247 def test_archive(self):
tandrii1c67da62016-06-10 07:35:53 -07002248 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2249
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002250 self.calls = [
2251 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
Edward Lemurf38bc172019-09-03 21:02:13 +00002252 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002253 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2254 ((['git', 'tag', 'git-cl-archived-456-foo', 'foo'],), ''),
Edward Lemurf38bc172019-09-03 21:02:13 +00002255 ((['git', 'branch', '-D', 'foo'],), '')
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002256 ]
kmarshall3bff56b2016-06-06 18:31:47 -07002257
kmarshall3bff56b2016-06-06 18:31:47 -07002258 self.mock(git_cl, 'get_cl_statuses',
2259 lambda branches, fine_grained, max_processes:
kmarshall9249e012016-08-23 12:02:16 -07002260 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2261 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
2262 (MockChangelistWithBranchAndIssue('bar', 789), 'open')])
kmarshall3bff56b2016-06-06 18:31:47 -07002263
2264 self.assertEqual(0, git_cl.main(['archive', '-f']))
2265
2266 def test_archive_current_branch_fails(self):
tandrii1c67da62016-06-10 07:35:53 -07002267 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002268 self.calls = [
2269 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2270 'refs/heads/master'),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002271 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2272 ]
kmarshall3bff56b2016-06-06 18:31:47 -07002273
kmarshall9249e012016-08-23 12:02:16 -07002274 self.mock(git_cl, 'get_cl_statuses',
2275 lambda branches, fine_grained, max_processes:
2276 [(MockChangelistWithBranchAndIssue('master', 1), 'closed')])
2277
2278 self.assertEqual(1, git_cl.main(['archive', '-f']))
2279
2280 def test_archive_dry_run(self):
2281 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2282
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002283 self.calls = [
2284 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2285 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002286 ((['git', 'symbolic-ref', 'HEAD'],), 'master')
2287 ]
kmarshall3bff56b2016-06-06 18:31:47 -07002288
2289 self.mock(git_cl, 'get_cl_statuses',
2290 lambda branches, fine_grained, max_processes:
kmarshall9249e012016-08-23 12:02:16 -07002291 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2292 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
2293 (MockChangelistWithBranchAndIssue('bar', 789), 'open')])
kmarshall3bff56b2016-06-06 18:31:47 -07002294
kmarshall9249e012016-08-23 12:02:16 -07002295 self.assertEqual(0, git_cl.main(['archive', '-f', '--dry-run']))
2296
2297 def test_archive_no_tags(self):
2298 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2299
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002300 self.calls = [
2301 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2302 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002303 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2304 ((['git', 'branch', '-D', 'foo'],), '')
2305 ]
kmarshall9249e012016-08-23 12:02:16 -07002306
2307 self.mock(git_cl, 'get_cl_statuses',
2308 lambda branches, fine_grained, max_processes:
2309 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2310 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
2311 (MockChangelistWithBranchAndIssue('bar', 789), 'open')])
2312
2313 self.assertEqual(0, git_cl.main(['archive', '-f', '--notags']))
kmarshall3bff56b2016-06-06 18:31:47 -07002314
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002315 def test_cmd_issue_erase_existing(self):
2316 out = StringIO.StringIO()
2317 self.mock(git_cl.sys, 'stdout', out)
2318 self.calls = [
2319 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002320 # Let this command raise exception (retcode=1) - it should be ignored.
2321 ((['git', 'config', '--unset', 'branch.feature.last-upload-hash'],),
tandrii5d48c322016-08-18 16:19:37 -07002322 CERR1),
2323 ((['git', 'config', '--unset', 'branch.feature.gerritissue'],), ''),
2324 ((['git', 'config', '--unset', 'branch.feature.gerritpatchset'],), ''),
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002325 ((['git', 'config', '--unset', 'branch.feature.gerritserver'],), ''),
2326 ((['git', 'config', '--unset', 'branch.feature.gerritsquashhash'],),
2327 ''),
Aaron Gableca01e2c2017-07-19 11:16:02 -07002328 ((['git', 'log', '-1', '--format=%B'],), 'This is a description'),
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002329 ]
2330 self.assertEqual(0, git_cl.main(['issue', '0']))
2331
Aaron Gable400e9892017-07-12 15:31:21 -07002332 def test_cmd_issue_erase_existing_with_change_id(self):
2333 out = StringIO.StringIO()
2334 self.mock(git_cl.sys, 'stdout', out)
2335 self.mock(git_cl.Changelist, 'GetDescription',
2336 lambda _: 'This is a description\n\nChange-Id: Ideadbeef')
2337 self.calls = [
2338 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
Aaron Gable400e9892017-07-12 15:31:21 -07002339 # Let this command raise exception (retcode=1) - it should be ignored.
2340 ((['git', 'config', '--unset', 'branch.feature.last-upload-hash'],),
2341 CERR1),
2342 ((['git', 'config', '--unset', 'branch.feature.gerritissue'],), ''),
2343 ((['git', 'config', '--unset', 'branch.feature.gerritpatchset'],), ''),
2344 ((['git', 'config', '--unset', 'branch.feature.gerritserver'],), ''),
2345 ((['git', 'config', '--unset', 'branch.feature.gerritsquashhash'],),
2346 ''),
Aaron Gableca01e2c2017-07-19 11:16:02 -07002347 ((['git', 'log', '-1', '--format=%B'],),
2348 'This is a description\n\nChange-Id: Ideadbeef'),
2349 ((['git', 'commit', '--amend', '-m', 'This is a description\n'],), ''),
Aaron Gable400e9892017-07-12 15:31:21 -07002350 ]
2351 self.assertEqual(0, git_cl.main(['issue', '0']))
2352
phajdan.jre328cf92016-08-22 04:12:17 -07002353 def test_cmd_issue_json(self):
2354 out = StringIO.StringIO()
2355 self.mock(git_cl.sys, 'stdout', out)
2356 self.calls = [
2357 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
Andrii Shyshkalova185e2e2018-11-21 00:42:55 +00002358 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
2359 ((['git', 'config', 'branch.feature.gerritserver'],),
2360 'https://chromium-review.googlesource.com'),
phajdan.jre328cf92016-08-22 04:12:17 -07002361 (('write_json', 'output.json',
Andrii Shyshkalova185e2e2018-11-21 00:42:55 +00002362 {'issue': 123,
2363 'issue_url': 'https://chromium-review.googlesource.com/123'}),
phajdan.jre328cf92016-08-22 04:12:17 -07002364 ''),
2365 ]
2366 self.assertEqual(0, git_cl.main(['issue', '--json', 'output.json']))
2367
tandrii16e0b4e2016-06-07 10:34:28 -07002368 def _common_GerritCommitMsgHookCheck(self):
2369 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2370 self.mock(git_cl.os.path, 'abspath',
2371 lambda path: self._mocked_call(['abspath', path]))
2372 self.mock(git_cl.os.path, 'exists',
2373 lambda path: self._mocked_call(['exists', path]))
2374 self.mock(git_cl.gclient_utils, 'FileRead',
2375 lambda path: self._mocked_call(['FileRead', path]))
2376 self.mock(git_cl.gclient_utils, 'rm_file_or_tree',
2377 lambda path: self._mocked_call(['rm_file_or_tree', path]))
2378 self.calls = [
2379 ((['git', 'rev-parse', '--show-cdup'],), '../'),
2380 ((['abspath', '../'],), '/abs/git_repo_root'),
2381 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002382 return git_cl.Changelist(issue=123)
tandrii16e0b4e2016-06-07 10:34:28 -07002383
2384 def test_GerritCommitMsgHookCheck_custom_hook(self):
2385 cl = self._common_GerritCommitMsgHookCheck()
2386 self.calls += [
2387 ((['exists', '/abs/git_repo_root/.git/hooks/commit-msg'],), True),
2388 ((['FileRead', '/abs/git_repo_root/.git/hooks/commit-msg'],),
2389 '#!/bin/sh\necho "custom hook"')
2390 ]
Edward Lemur125d60a2019-09-13 18:25:41 +00002391 cl._GerritCommitMsgHookCheck(offer_removal=True)
tandrii16e0b4e2016-06-07 10:34:28 -07002392
2393 def test_GerritCommitMsgHookCheck_not_exists(self):
2394 cl = self._common_GerritCommitMsgHookCheck()
2395 self.calls += [
2396 ((['exists', '/abs/git_repo_root/.git/hooks/commit-msg'],), False),
2397 ]
Edward Lemur125d60a2019-09-13 18:25:41 +00002398 cl._GerritCommitMsgHookCheck(offer_removal=True)
tandrii16e0b4e2016-06-07 10:34:28 -07002399
2400 def test_GerritCommitMsgHookCheck(self):
2401 cl = self._common_GerritCommitMsgHookCheck()
2402 self.calls += [
2403 ((['exists', '/abs/git_repo_root/.git/hooks/commit-msg'],), True),
2404 ((['FileRead', '/abs/git_repo_root/.git/hooks/commit-msg'],),
2405 '...\n# From Gerrit Code Review\n...\nadd_ChangeId()\n'),
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002406 (('ask_for_data', 'Do you want to remove it now? [Yes/No]: '), 'Yes'),
tandrii16e0b4e2016-06-07 10:34:28 -07002407 ((['rm_file_or_tree', '/abs/git_repo_root/.git/hooks/commit-msg'],),
2408 ''),
2409 ]
Edward Lemur125d60a2019-09-13 18:25:41 +00002410 cl._GerritCommitMsgHookCheck(offer_removal=True)
tandrii16e0b4e2016-06-07 10:34:28 -07002411
tandriic4344b52016-08-29 06:04:54 -07002412 def test_GerritCmdLand(self):
2413 self.calls += [
2414 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
2415 ((['git', 'config', 'branch.feature.gerritsquashhash'],),
2416 'deadbeaf'),
2417 ((['git', 'diff', 'deadbeaf'],), ''), # No diff.
2418 ((['git', 'config', 'branch.feature.gerritserver'],),
2419 'chromium-review.googlesource.com'),
2420 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002421 cl = git_cl.Changelist(issue=123)
Edward Lemur125d60a2019-09-13 18:25:41 +00002422 cl._GetChangeDetail = lambda *args, **kwargs: {
tandriic4344b52016-08-29 06:04:54 -07002423 'labels': {},
2424 'current_revision': 'deadbeaf',
2425 }
Edward Lemur125d60a2019-09-13 18:25:41 +00002426 cl._GetChangeCommit = lambda: {
agable32978d92016-11-01 12:55:02 -07002427 'commit': 'deadbeef',
Aaron Gable02cdbb42016-12-13 16:24:25 -08002428 'web_links': [{'name': 'gitiles',
agable32978d92016-11-01 12:55:02 -07002429 'url': 'https://git.googlesource.com/test/+/deadbeef'}],
2430 }
Edward Lemur125d60a2019-09-13 18:25:41 +00002431 cl.SubmitIssue = lambda wait_for_merge: None
tandrii8da412c2016-09-07 16:01:07 -07002432 out = StringIO.StringIO()
2433 self.mock(sys, 'stdout', out)
Olivier Robin75ee7252018-04-13 10:02:56 +02002434 self.assertEqual(0, cl.CMDLand(force=True,
2435 bypass_hooks=True,
2436 verbose=True,
2437 parallel=False))
tandrii8da412c2016-09-07 16:01:07 -07002438 self.assertRegexpMatches(out.getvalue(), 'Issue.*123 has been submitted')
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002439 self.assertRegexpMatches(out.getvalue(), 'Landed as: .*deadbeef')
tandriic4344b52016-08-29 06:04:54 -07002440
tandrii221ab252016-10-06 08:12:04 -07002441 BUILDBUCKET_BUILDS_MAP = {
Quinten Yearsleya563d722017-12-11 16:36:54 -08002442 '9000': {
2443 'id': '9000',
2444 'bucket': 'master.x.y',
2445 'created_by': 'user:someone@chromium.org',
2446 'created_ts': '147200002222000',
2447 'experimental': False,
2448 'parameters_json': json.dumps({
2449 'builder_name': 'my-bot',
2450 'properties': {'category': 'cq'},
2451 }),
2452 'status': 'STARTED',
2453 'tags': [
2454 'build_address:x.y/my-bot/2',
2455 'builder:my-bot',
2456 'experimental:false',
2457 'user_agent:cq',
2458 ],
2459 'url': 'http://build.cr.org/p/x.y/builders/my-bot/builds/2',
2460 },
2461 '8000': {
2462 'id': '8000',
2463 'bucket': 'master.x.y',
2464 'created_by': 'user:someone@chromium.org',
2465 'created_ts': '147200001111000',
2466 'experimental': False,
2467 'failure_reason': 'BUILD_FAILURE',
2468 'parameters_json': json.dumps({
2469 'builder_name': 'my-bot',
2470 'properties': {'category': 'cq'},
2471 }),
2472 'result_details_json': json.dumps({
2473 'properties': {'buildnumber': 1},
2474 }),
2475 'result': 'FAILURE',
2476 'status': 'COMPLETED',
2477 'tags': [
2478 'build_address:x.y/my-bot/1',
2479 'builder:my-bot',
2480 'experimental:false',
2481 'user_agent:cq',
2482 ],
2483 'url': 'http://build.cr.org/p/x.y/builders/my-bot/builds/1',
2484 },
2485 }
tandrii221ab252016-10-06 08:12:04 -07002486
2487 def test_write_try_results_json(self):
2488 expected_output = [
Quinten Yearsleya563d722017-12-11 16:36:54 -08002489 {
2490 'bucket': 'master.x.y',
2491 'buildbucket_id': '8000',
2492 'builder_name': 'my-bot',
2493 'created_ts': '147200001111000',
2494 'experimental': False,
2495 'failure_reason': 'BUILD_FAILURE',
2496 'result': 'FAILURE',
2497 'status': 'COMPLETED',
2498 'tags': [
2499 'build_address:x.y/my-bot/1',
2500 'builder:my-bot',
2501 'experimental:false',
2502 'user_agent:cq',
2503 ],
2504 'url': 'http://build.cr.org/p/x.y/builders/my-bot/builds/1',
2505 },
2506 {
2507 'bucket': 'master.x.y',
2508 'buildbucket_id': '9000',
2509 'builder_name': 'my-bot',
2510 'created_ts': '147200002222000',
2511 'experimental': False,
2512 'failure_reason': None,
2513 'result': None,
2514 'status': 'STARTED',
2515 'tags': [
2516 'build_address:x.y/my-bot/2',
2517 'builder:my-bot',
2518 'experimental:false',
2519 'user_agent:cq',
2520 ],
2521 'url': 'http://build.cr.org/p/x.y/builders/my-bot/builds/2',
2522 },
tandrii221ab252016-10-06 08:12:04 -07002523 ]
2524 self.calls = [(('write_json', 'output.json', expected_output), '')]
2525 git_cl.write_try_results_json('output.json', self.BUILDBUCKET_BUILDS_MAP)
2526
tandrii45b2a582016-10-11 03:14:16 -07002527 def _setup_fetch_try_jobs(self, most_recent_patchset=20001):
tandrii221ab252016-10-06 08:12:04 -07002528 out = StringIO.StringIO()
2529 self.mock(sys, 'stdout', out)
tandrii45b2a582016-10-11 03:14:16 -07002530 self.mock(git_cl.Changelist, 'GetMostRecentPatchset',
2531 lambda *args: most_recent_patchset)
tandrii221ab252016-10-06 08:12:04 -07002532 self.mock(git_cl.auth, 'get_authenticator_for_host', lambda host, _cfg:
2533 self._mocked_call(['get_authenticator_for_host', host]))
2534 self.mock(git_cl, '_buildbucket_retry', lambda *_, **__:
2535 self._mocked_call(['_buildbucket_retry']))
tandrii45b2a582016-10-11 03:14:16 -07002536
tandrii45b2a582016-10-11 03:14:16 -07002537 def _setup_fetch_try_jobs_gerrit(self, *request_results):
2538 self._setup_fetch_try_jobs(most_recent_patchset=13)
2539 self.calls += [
2540 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii45b2a582016-10-11 03:14:16 -07002541 ((['git', 'config', 'branch.feature.gerritissue'],), '1'),
Ravi Mistryfda50ca2016-11-14 10:19:18 -05002542 # TODO(tandrii): Uncomment the below if we decide to support checking
2543 # patchsets for Gerrit.
tandrii45b2a582016-10-11 03:14:16 -07002544 # Simulate that Gerrit has more patchsets than local.
Ravi Mistryfda50ca2016-11-14 10:19:18 -05002545 # ((['git', 'config', 'branch.feature.gerritpatchset'],), '12'),
tandrii45b2a582016-10-11 03:14:16 -07002546 ((['git', 'config', 'branch.feature.gerritserver'],),
2547 'https://x-review.googlesource.com'),
2548 ((['get_authenticator_for_host', 'x-review.googlesource.com'],),
2549 AuthenticatorMock()),
2550 ] + [((['_buildbucket_retry'],), r) for r in request_results]
2551
2552 def test_fetch_try_jobs_none_gerrit(self):
2553 self._setup_fetch_try_jobs_gerrit({})
2554 self.assertEqual(0, git_cl.main(['try-results']))
Ravi Mistryfda50ca2016-11-14 10:19:18 -05002555 # TODO(tandrii): Uncomment the below if we decide to support checking
2556 # patchsets for Gerrit.
2557 # self.assertRegexpMatches(
2558 # sys.stdout.getvalue(),
2559 # r'Warning: Codereview server has newer patchsets \(13\)')
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002560 self.assertRegexpMatches(sys.stdout.getvalue(), 'No tryjobs')
tandrii45b2a582016-10-11 03:14:16 -07002561
2562 def test_fetch_try_jobs_some_gerrit(self):
2563 self._setup_fetch_try_jobs_gerrit({
2564 'builds': self.BUILDBUCKET_BUILDS_MAP.values(),
2565 })
Ravi Mistryfda50ca2016-11-14 10:19:18 -05002566 # TODO(tandrii): Uncomment the below if we decide to support checking
2567 # patchsets for Gerrit.
2568 # self.calls.remove(
2569 # ((['git', 'config', 'branch.feature.gerritpatchset'],), '12'))
tandrii45b2a582016-10-11 03:14:16 -07002570 self.assertEqual(0, git_cl.main(['try-results', '--patchset', '5']))
2571
2572 # ... and doesn't result in warning.
2573 self.assertNotRegexpMatches(sys.stdout.getvalue(), 'Warning')
2574 self.assertRegexpMatches(sys.stdout.getvalue(), '^Failures:')
tandrii221ab252016-10-06 08:12:04 -07002575 self.assertRegexpMatches(sys.stdout.getvalue(), 'Started:')
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002576 self.assertRegexpMatches(sys.stdout.getvalue(), '2 tryjobs')
tandrii221ab252016-10-06 08:12:04 -07002577
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002578 def _mock_gerrit_changes_for_detail_cache(self):
Edward Lemur125d60a2019-09-13 18:25:41 +00002579 self.mock(git_cl.Changelist, '_GetGerritHost', lambda _: 'host')
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002580
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002581 def test_gerrit_change_detail_cache_simple(self):
2582 self._mock_gerrit_changes_for_detail_cache()
2583 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002584 (('GetChangeDetail', 'host', 'my%2Frepo~1', []), 'a'),
2585 (('GetChangeDetail', 'host', 'ab%2Frepo~2', []), 'b'),
2586 (('GetChangeDetail', 'host', 'ab%2Frepo~2', []), 'b2'),
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002587 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002588 cl1 = git_cl.Changelist(issue=1)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002589 cl1._cached_remote_url = (
2590 True, 'https://chromium.googlesource.com/a/my/repo.git/')
Edward Lemurf38bc172019-09-03 21:02:13 +00002591 cl2 = git_cl.Changelist(issue=2)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002592 cl2._cached_remote_url = (
2593 True, 'https://chromium.googlesource.com/ab/repo')
Andrii Shyshkalovb7214602018-08-22 23:20:26 +00002594 self.assertEqual(cl1._GetChangeDetail(), 'a') # Miss.
2595 self.assertEqual(cl1._GetChangeDetail(), 'a')
2596 self.assertEqual(cl2._GetChangeDetail(), 'b') # Miss.
2597 self.assertEqual(cl2._GetChangeDetail(no_cache=True), 'b2') # Miss.
2598 self.assertEqual(cl1._GetChangeDetail(), 'a')
2599 self.assertEqual(cl2._GetChangeDetail(), 'b2')
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002600
2601 def test_gerrit_change_detail_cache_options(self):
2602 self._mock_gerrit_changes_for_detail_cache()
2603 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002604 (('GetChangeDetail', 'host', 'repo~1', ['C', 'A', 'B']), 'cab'),
2605 (('GetChangeDetail', 'host', 'repo~1', ['A', 'D']), 'ad'),
2606 (('GetChangeDetail', 'host', 'repo~1', ['A']), 'a'), # no_cache=True
2607 # no longer in cache.
2608 (('GetChangeDetail', 'host', 'repo~1', ['B']), 'b'),
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002609 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002610 cl = git_cl.Changelist(issue=1)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002611 cl._cached_remote_url = (True, 'https://chromium.googlesource.com/repo/')
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002612 self.assertEqual(cl._GetChangeDetail(options=['C', 'A', 'B']), 'cab')
2613 self.assertEqual(cl._GetChangeDetail(options=['A', 'B', 'C']), 'cab')
2614 self.assertEqual(cl._GetChangeDetail(options=['B', 'A']), 'cab')
2615 self.assertEqual(cl._GetChangeDetail(options=['C']), 'cab')
2616 self.assertEqual(cl._GetChangeDetail(options=['A']), 'cab')
2617 self.assertEqual(cl._GetChangeDetail(), 'cab')
2618
2619 self.assertEqual(cl._GetChangeDetail(options=['A', 'D']), 'ad')
2620 self.assertEqual(cl._GetChangeDetail(options=['A']), 'cab')
2621 self.assertEqual(cl._GetChangeDetail(options=['D']), 'ad')
2622 self.assertEqual(cl._GetChangeDetail(), 'cab')
2623
2624 # Finally, no_cache should invalidate all caches for given change.
2625 self.assertEqual(cl._GetChangeDetail(options=['A'], no_cache=True), 'a')
2626 self.assertEqual(cl._GetChangeDetail(options=['B']), 'b')
2627
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002628 def test_gerrit_description_caching(self):
2629 def gen_detail(rev, desc):
2630 return {
2631 'current_revision': rev,
2632 'revisions': {rev: {'commit': {'message': desc}}}
2633 }
2634 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002635 (('GetChangeDetail', 'host', 'my%2Frepo~1',
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002636 ['CURRENT_REVISION', 'CURRENT_COMMIT']),
2637 gen_detail('rev1', 'desc1')),
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002638 (('GetChangeDetail', 'host', 'my%2Frepo~1',
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002639 ['CURRENT_REVISION', 'CURRENT_COMMIT']),
2640 gen_detail('rev2', 'desc2')),
2641 ]
2642
2643 self._mock_gerrit_changes_for_detail_cache()
Edward Lemurf38bc172019-09-03 21:02:13 +00002644 cl = git_cl.Changelist(issue=1)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002645 cl._cached_remote_url = (
2646 True, 'https://chromium.googlesource.com/a/my/repo.git/')
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002647 self.assertEqual(cl.GetDescription(), 'desc1')
2648 self.assertEqual(cl.GetDescription(), 'desc1') # cache hit.
2649 self.assertEqual(cl.GetDescription(force=True), 'desc2')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002650
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002651 def test_print_current_creds(self):
2652 class CookiesAuthenticatorMock(object):
2653 def __init__(self):
2654 self.gitcookies = {
2655 'host.googlesource.com': ('user', 'pass'),
2656 'host-review.googlesource.com': ('user', 'pass'),
2657 }
2658 self.netrc = self
2659 self.netrc.hosts = {
2660 'github.com': ('user2', None, 'pass2'),
2661 'host2.googlesource.com': ('user3', None, 'pass'),
2662 }
2663 self.mock(git_cl.gerrit_util, 'CookiesAuthenticator',
2664 CookiesAuthenticatorMock)
2665 self.mock(sys, 'stdout', StringIO.StringIO())
2666 git_cl._GitCookiesChecker().print_current_creds(include_netrc=True)
2667 self.assertEqual(list(sys.stdout.getvalue().splitlines()), [
2668 ' Host\t User\t Which file',
2669 '============================\t=====\t===========',
2670 'host-review.googlesource.com\t user\t.gitcookies',
2671 ' host.googlesource.com\t user\t.gitcookies',
2672 ' host2.googlesource.com\tuser3\t .netrc',
2673 ])
2674 sys.stdout.buf = ''
2675 git_cl._GitCookiesChecker().print_current_creds(include_netrc=False)
2676 self.assertEqual(list(sys.stdout.getvalue().splitlines()), [
2677 ' Host\tUser\t Which file',
2678 '============================\t====\t===========',
2679 'host-review.googlesource.com\tuser\t.gitcookies',
2680 ' host.googlesource.com\tuser\t.gitcookies',
2681 ])
2682
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002683 def _common_creds_check_mocks(self):
2684 def exists_mock(path):
2685 dirname = os.path.dirname(path)
2686 if dirname == os.path.expanduser('~'):
2687 dirname = '~'
2688 base = os.path.basename(path)
2689 if base in ('.netrc', '.gitcookies'):
2690 return self._mocked_call('os.path.exists', '%s/%s' % (dirname, base))
2691 # git cl also checks for existence other files not relevant to this test.
2692 return None
2693 self.mock(os.path, 'exists', exists_mock)
2694 self.mock(sys, 'stdout', StringIO.StringIO())
2695
2696 def test_creds_check_gitcookies_not_configured(self):
2697 self._common_creds_check_mocks()
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002698 self.mock(git_cl._GitCookiesChecker, 'get_hosts_with_creds',
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01002699 lambda _, include_netrc=False: [])
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002700 self.calls = [
Aaron Gable8797cab2018-03-06 13:55:00 -08002701 ((['git', 'config', '--path', 'http.cookiefile'],), CERR1),
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002702 ((['git', 'config', '--global', 'http.cookiefile'],), CERR1),
2703 (('os.path.exists', '~/.netrc'), True),
2704 (('ask_for_data', 'Press Enter to setup .gitcookies, '
2705 'or Ctrl+C to abort'), ''),
2706 ((['git', 'config', '--global', 'http.cookiefile',
2707 os.path.expanduser('~/.gitcookies')], ), ''),
2708 ]
2709 self.assertEqual(0, git_cl.main(['creds-check']))
2710 self.assertRegexpMatches(
2711 sys.stdout.getvalue(),
2712 '^You seem to be using outdated .netrc for git credentials:')
2713 self.assertRegexpMatches(
2714 sys.stdout.getvalue(),
2715 '\nConfigured git to use .gitcookies from')
2716
2717 def test_creds_check_gitcookies_configured_custom_broken(self):
2718 self._common_creds_check_mocks()
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002719 self.mock(git_cl._GitCookiesChecker, 'get_hosts_with_creds',
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01002720 lambda _, include_netrc=False: [])
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002721 self.calls = [
Aaron Gable8797cab2018-03-06 13:55:00 -08002722 ((['git', 'config', '--path', 'http.cookiefile'],), CERR1),
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002723 ((['git', 'config', '--global', 'http.cookiefile'],),
2724 '/custom/.gitcookies'),
2725 (('os.path.exists', '/custom/.gitcookies'), False),
2726 (('ask_for_data', 'Reconfigure git to use default .gitcookies? '
2727 'Press Enter to reconfigure, or Ctrl+C to abort'), ''),
2728 ((['git', 'config', '--global', 'http.cookiefile',
2729 os.path.expanduser('~/.gitcookies')], ), ''),
2730 ]
2731 self.assertEqual(0, git_cl.main(['creds-check']))
2732 self.assertRegexpMatches(
2733 sys.stdout.getvalue(),
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002734 'WARNING: You have configured custom path to .gitcookies: ')
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002735 self.assertRegexpMatches(
2736 sys.stdout.getvalue(),
2737 'However, your configured .gitcookies file is missing.')
2738
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002739 def test_git_cl_comment_add_gerrit(self):
2740 self.mock(git_cl.gerrit_util, 'SetReview',
Aaron Gable636b13f2017-07-14 10:42:48 -07002741 lambda host, change, msg, ready:
2742 self._mocked_call('SetReview', host, change, msg, ready))
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002743 self.calls = [
2744 ((['git', 'symbolic-ref', 'HEAD'],), CERR1),
2745 ((['git', 'symbolic-ref', 'HEAD'],), CERR1),
2746 ((['git', 'config', 'rietveld.upstream-branch'],), CERR1),
2747 ((['git', 'branch', '-r'],), 'origin/HEAD -> origin/master\n'
2748 'origin/master'),
2749 ((['git', 'config', 'remote.origin.url'],),
2750 'https://chromium.googlesource.com/infra/infra'),
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002751 (('SetReview', 'chromium-review.googlesource.com', 'infra%2Finfra~10',
2752 'msg', None),
Aaron Gable636b13f2017-07-14 10:42:48 -07002753 None),
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002754 ]
2755 self.assertEqual(0, git_cl.main(['comment', '--gerrit', '-i', '10',
2756 '-a', 'msg']))
2757
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002758 def test_git_cl_comments_fetch_gerrit(self):
2759 self.mock(sys, 'stdout', StringIO.StringIO())
2760 self.calls = [
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002761 ((['git', 'config', 'branch.foo.gerritserver'],), ''),
2762 ((['git', 'config', 'branch.foo.merge'],), ''),
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002763 ((['git', 'config', 'rietveld.upstream-branch'],), CERR1),
2764 ((['git', 'branch', '-r'],), 'origin/HEAD -> origin/master\n'
2765 'origin/master'),
2766 ((['git', 'config', 'remote.origin.url'],),
2767 'https://chromium.googlesource.com/infra/infra'),
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002768 (('GetChangeDetail', 'chromium-review.googlesource.com',
2769 'infra%2Finfra~1',
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002770 ['MESSAGES', 'DETAILED_ACCOUNTS', 'CURRENT_REVISION',
2771 'CURRENT_COMMIT']), {
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002772 'owner': {'email': 'owner@example.com'},
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002773 'current_revision': 'ba5eba11',
2774 'revisions': {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002775 'deadbeaf': {
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002776 '_number': 1,
2777 },
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002778 'ba5eba11': {
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002779 '_number': 2,
2780 },
2781 },
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002782 'messages': [
2783 {
2784 u'_revision_number': 1,
2785 u'author': {
2786 u'_account_id': 1111084,
2787 u'email': u'commit-bot@chromium.org',
2788 u'name': u'Commit Bot'
2789 },
2790 u'date': u'2017-03-15 20:08:45.000000000',
2791 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046dc50b',
Dirk Prankef6a58802017-10-17 12:49:42 -07002792 u'message': u'Patch Set 1:\n\nDry run: CQ is trying the patch...',
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002793 u'tag': u'autogenerated:cq:dry-run'
2794 },
2795 {
2796 u'_revision_number': 2,
2797 u'author': {
2798 u'_account_id': 11151243,
2799 u'email': u'owner@example.com',
2800 u'name': u'owner'
2801 },
2802 u'date': u'2017-03-16 20:00:41.000000000',
2803 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2804 u'message': u'PTAL',
2805 },
2806 {
2807 u'_revision_number': 2,
2808 u'author': {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002809 u'_account_id': 148512,
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002810 u'email': u'reviewer@example.com',
2811 u'name': u'reviewer'
2812 },
2813 u'date': u'2017-03-17 05:19:37.500000000',
2814 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d4568',
2815 u'message': u'Patch Set 2: Code-Review+1',
2816 },
2817 ]
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002818 }),
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002819 (('GetChangeComments', 'chromium-review.googlesource.com',
2820 'infra%2Finfra~1'), {
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002821 '/COMMIT_MSG': [
2822 {
2823 'author': {'email': u'reviewer@example.com'},
2824 'updated': u'2017-03-17 05:19:37.500000000',
2825 'patch_set': 2,
2826 'side': 'REVISION',
2827 'message': 'Please include a bug link',
2828 },
2829 ],
2830 'codereview.settings': [
2831 {
2832 'author': {'email': u'owner@example.com'},
2833 'updated': u'2017-03-16 20:00:41.000000000',
2834 'patch_set': 2,
2835 'side': 'PARENT',
2836 'line': 42,
2837 'message': 'I removed this because it is bad',
2838 },
2839 ]
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002840 }),
2841 (('GetChangeRobotComments', 'chromium-review.googlesource.com',
2842 'infra%2Finfra~1'), {}),
2843 ((['git', 'config', 'branch.foo.gerritpatchset', '2'],), ''),
Leszek Swirski45b20c42018-09-17 17:05:26 +00002844 ] * 2 + [
2845 (('write_json', 'output.json', [
2846 {
2847 u'date': u'2017-03-16 20:00:41.000000',
2848 u'message': (
2849 u'PTAL\n' +
2850 u'\n' +
2851 u'codereview.settings\n' +
2852 u' Base, Line 42: https://chromium-review.googlesource.com/' +
2853 u'c/1/2/codereview.settings#b42\n' +
2854 u' I removed this because it is bad\n'),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002855 u'autogenerated': False,
Leszek Swirski45b20c42018-09-17 17:05:26 +00002856 u'approval': False,
2857 u'disapproval': False,
2858 u'sender': u'owner@example.com'
2859 }, {
2860 u'date': u'2017-03-17 05:19:37.500000',
2861 u'message': (
2862 u'Patch Set 2: Code-Review+1\n' +
2863 u'\n' +
2864 u'/COMMIT_MSG\n' +
2865 u' PS2, File comment: https://chromium-review.googlesource' +
2866 u'.com/c/1/2//COMMIT_MSG#\n' +
2867 u' Please include a bug link\n'),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002868 u'autogenerated': False,
Leszek Swirski45b20c42018-09-17 17:05:26 +00002869 u'approval': False,
2870 u'disapproval': False,
2871 u'sender': u'reviewer@example.com'
2872 }
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002873 ]), '')
Leszek Swirski45b20c42018-09-17 17:05:26 +00002874 ]
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002875 expected_comments_summary = [
2876 git_cl._CommentSummary(
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002877 message=(
2878 u'PTAL\n' +
2879 u'\n' +
2880 u'codereview.settings\n' +
2881 u' Base, Line 42: https://chromium-review.googlesource.com/' +
2882 u'c/1/2/codereview.settings#b42\n' +
2883 u' I removed this because it is bad\n'),
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002884 date=datetime.datetime(2017, 3, 16, 20, 0, 41, 0),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002885 autogenerated=False,
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002886 disapproval=False, approval=False, sender=u'owner@example.com'),
2887 git_cl._CommentSummary(
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002888 message=(
2889 u'Patch Set 2: Code-Review+1\n' +
2890 u'\n' +
2891 u'/COMMIT_MSG\n' +
2892 u' PS2, File comment: https://chromium-review.googlesource.com/' +
2893 u'c/1/2//COMMIT_MSG#\n' +
2894 u' Please include a bug link\n'),
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002895 date=datetime.datetime(2017, 3, 17, 5, 19, 37, 500000),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002896 autogenerated=False,
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002897 disapproval=False, approval=False, sender=u'reviewer@example.com'),
2898 ]
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002899 cl = git_cl.Changelist(
Edward Lemurf38bc172019-09-03 21:02:13 +00002900 issue=1, branchref='refs/heads/foo')
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002901 self.assertEqual(cl.GetCommentsSummary(), expected_comments_summary)
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002902 self.mock(git_cl.Changelist, 'GetBranch', lambda _: 'foo')
2903 self.assertEqual(
2904 0, git_cl.main(['comments', '-i', '1', '-j', 'output.json']))
2905
2906 def test_git_cl_comments_robot_comments(self):
2907 # git cl comments also fetches robot comments (which are considered a type
2908 # of autogenerated comment), and unlike other types of comments, only robot
2909 # comments from the latest patchset are shown.
2910 self.mock(sys, 'stdout', StringIO.StringIO())
2911 self.calls = [
2912 ((['git', 'config', 'branch.foo.gerritserver'],), ''),
2913 ((['git', 'config', 'branch.foo.merge'],), ''),
2914 ((['git', 'config', 'rietveld.upstream-branch'],), CERR1),
2915 ((['git', 'branch', '-r'],), 'origin/HEAD -> origin/master\n'
2916 'origin/master'),
2917 ((['git', 'config', 'remote.origin.url'],),
2918 'https://chromium.googlesource.com/infra/infra'),
2919 (('GetChangeDetail', 'chromium-review.googlesource.com',
2920 'infra%2Finfra~1',
2921 ['MESSAGES', 'DETAILED_ACCOUNTS', 'CURRENT_REVISION',
2922 'CURRENT_COMMIT']), {
2923 'owner': {'email': 'owner@example.com'},
2924 'current_revision': 'ba5eba11',
2925 'revisions': {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002926 'deadbeaf': {
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002927 '_number': 1,
2928 },
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002929 'ba5eba11': {
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002930 '_number': 2,
2931 },
2932 },
2933 'messages': [
2934 {
2935 u'_revision_number': 1,
2936 u'author': {
2937 u'_account_id': 1111084,
2938 u'email': u'commit-bot@chromium.org',
2939 u'name': u'Commit Bot'
2940 },
2941 u'date': u'2017-03-15 20:08:45.000000000',
2942 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046dc50b',
2943 u'message': u'Patch Set 1:\n\nDry run: CQ is trying the patch...',
2944 u'tag': u'autogenerated:cq:dry-run'
2945 },
2946 {
2947 u'_revision_number': 1,
2948 u'author': {
2949 u'_account_id': 123,
2950 u'email': u'tricium@serviceaccount.com',
2951 u'name': u'Tricium'
2952 },
2953 u'date': u'2017-03-16 20:00:41.000000000',
2954 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2955 u'message': u'(1 comment)',
2956 u'tag': u'autogenerated:tricium',
2957 },
2958 {
2959 u'_revision_number': 1,
2960 u'author': {
2961 u'_account_id': 123,
2962 u'email': u'tricium@serviceaccount.com',
2963 u'name': u'Tricium'
2964 },
2965 u'date': u'2017-03-16 20:00:41.000000000',
2966 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2967 u'message': u'(1 comment)',
2968 u'tag': u'autogenerated:tricium',
2969 },
2970 {
2971 u'_revision_number': 2,
2972 u'author': {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002973 u'_account_id': 123,
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002974 u'email': u'tricium@serviceaccount.com',
2975 u'name': u'reviewer'
2976 },
2977 u'date': u'2017-03-17 05:30:37.000000000',
2978 u'tag': u'autogenerated:tricium',
2979 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d4568',
2980 u'message': u'(1 comment)',
2981 },
2982 ]
2983 }),
2984 (('GetChangeComments', 'chromium-review.googlesource.com',
2985 'infra%2Finfra~1'), {}),
2986 (('GetChangeRobotComments', 'chromium-review.googlesource.com',
2987 'infra%2Finfra~1'), {
2988 'codereview.settings': [
2989 {
2990 u'author': {u'email': u'tricium@serviceaccount.com'},
2991 u'updated': u'2017-03-17 05:30:37.000000000',
2992 u'robot_run_id': u'5565031076855808',
2993 u'robot_id': u'Linter/Category',
2994 u'tag': u'autogenerated:tricium',
2995 u'patch_set': 2,
2996 u'side': u'REVISION',
2997 u'message': u'Linter warning message text',
2998 u'line': 32,
2999 },
3000 ],
3001 }),
3002 ((['git', 'config', 'branch.foo.gerritpatchset', '2'],), ''),
3003 ]
3004 expected_comments_summary = [
3005 git_cl._CommentSummary(date=datetime.datetime(2017, 3, 17, 5, 30, 37),
3006 message=(
3007 u'(1 comment)\n\ncodereview.settings\n'
3008 u' PS2, Line 32: https://chromium-review.googlesource.com/'
3009 u'c/1/2/codereview.settings#32\n'
3010 u' Linter warning message text\n'),
3011 sender=u'tricium@serviceaccount.com',
3012 autogenerated=True, approval=False, disapproval=False)
3013 ]
3014 cl = git_cl.Changelist(
Edward Lemurf38bc172019-09-03 21:02:13 +00003015 issue=1, branchref='refs/heads/foo')
Quinten Yearsley0e617c02019-02-20 00:37:03 +00003016 self.assertEqual(cl.GetCommentsSummary(), expected_comments_summary)
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003017
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00003018 def test_get_remote_url_with_mirror(self):
3019 original_os_path_isdir = os.path.isdir
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003020
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00003021 def selective_os_path_isdir_mock(path):
3022 if path == '/cache/this-dir-exists':
3023 return self._mocked_call('os.path.isdir', path)
3024 return original_os_path_isdir(path)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003025
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00003026 self.mock(os.path, 'isdir', selective_os_path_isdir_mock)
3027
3028 url = 'https://chromium.googlesource.com/my/repo'
3029 self.calls = [
3030 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
3031 ((['git', 'config', 'branch.master.merge'],), 'master'),
3032 ((['git', 'config', 'branch.master.remote'],), 'origin'),
3033 ((['git', 'config', 'remote.origin.url'],),
3034 '/cache/this-dir-exists'),
3035 (('os.path.isdir', '/cache/this-dir-exists'),
3036 True),
3037 # Runs in /cache/this-dir-exists.
3038 ((['git', 'config', 'remote.origin.url'],),
3039 url),
3040 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00003041 cl = git_cl.Changelist(issue=1)
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00003042 self.assertEqual(cl.GetRemoteUrl(), url)
3043 self.assertEqual(cl.GetRemoteUrl(), url) # Must be cached.
3044
Edward Lemur298f2cf2019-02-22 21:40:39 +00003045 def test_get_remote_url_non_existing_mirror(self):
3046 original_os_path_isdir = os.path.isdir
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003047
Edward Lemur298f2cf2019-02-22 21:40:39 +00003048 def selective_os_path_isdir_mock(path):
3049 if path == '/cache/this-dir-doesnt-exist':
3050 return self._mocked_call('os.path.isdir', path)
3051 return original_os_path_isdir(path)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003052
Edward Lemur298f2cf2019-02-22 21:40:39 +00003053 self.mock(os.path, 'isdir', selective_os_path_isdir_mock)
3054 self.mock(logging, 'error',
3055 lambda fmt, *a: self._mocked_call('logging.error', fmt % a))
3056
3057 self.calls = [
3058 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
3059 ((['git', 'config', 'branch.master.merge'],), 'master'),
3060 ((['git', 'config', 'branch.master.remote'],), 'origin'),
3061 ((['git', 'config', 'remote.origin.url'],),
3062 '/cache/this-dir-doesnt-exist'),
3063 (('os.path.isdir', '/cache/this-dir-doesnt-exist'),
3064 False),
3065 (('logging.error',
Daniel Bratell4a60db42019-09-16 17:02:52 +00003066 'Remote "origin" for branch "master" points to'
3067 ' "/cache/this-dir-doesnt-exist", but it doesn\'t exist.'), None),
Edward Lemur298f2cf2019-02-22 21:40:39 +00003068 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00003069 cl = git_cl.Changelist(issue=1)
Edward Lemur298f2cf2019-02-22 21:40:39 +00003070 self.assertIsNone(cl.GetRemoteUrl())
3071
3072 def test_get_remote_url_misconfigured_mirror(self):
3073 original_os_path_isdir = os.path.isdir
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003074
Edward Lemur298f2cf2019-02-22 21:40:39 +00003075 def selective_os_path_isdir_mock(path):
3076 if path == '/cache/this-dir-exists':
3077 return self._mocked_call('os.path.isdir', path)
3078 return original_os_path_isdir(path)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003079
Edward Lemur298f2cf2019-02-22 21:40:39 +00003080 self.mock(os.path, 'isdir', selective_os_path_isdir_mock)
3081 self.mock(logging, 'error',
3082 lambda *a: self._mocked_call('logging.error', *a))
3083
3084 self.calls = [
3085 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
3086 ((['git', 'config', 'branch.master.merge'],), 'master'),
3087 ((['git', 'config', 'branch.master.remote'],), 'origin'),
3088 ((['git', 'config', 'remote.origin.url'],),
3089 '/cache/this-dir-exists'),
3090 (('os.path.isdir', '/cache/this-dir-exists'), True),
3091 # Runs in /cache/this-dir-exists.
3092 ((['git', 'config', 'remote.origin.url'],), ''),
3093 (('logging.error',
3094 'Remote "%(remote)s" for branch "%(branch)s" points to '
3095 '"%(cache_path)s", but it is misconfigured.\n'
3096 '"%(cache_path)s" must be a git repo and must have a remote named '
3097 '"%(remote)s" pointing to the git host.', {
3098 'remote': 'origin',
3099 'cache_path': '/cache/this-dir-exists',
3100 'branch': 'master'}
3101 ), None),
3102 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00003103 cl = git_cl.Changelist(issue=1)
Edward Lemur298f2cf2019-02-22 21:40:39 +00003104 self.assertIsNone(cl.GetRemoteUrl())
3105
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00003106 def test_gerrit_change_identifier_with_project(self):
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00003107 self.calls = [
3108 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
3109 ((['git', 'config', 'branch.master.merge'],), 'master'),
3110 ((['git', 'config', 'branch.master.remote'],), 'origin'),
3111 ((['git', 'config', 'remote.origin.url'],),
3112 'https://chromium.googlesource.com/a/my/repo.git/'),
3113 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00003114 cl = git_cl.Changelist(issue=123456)
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00003115 self.assertEqual(cl._GerritChangeIdentifier(), 'my%2Frepo~123456')
3116
3117 def test_gerrit_change_identifier_without_project(self):
3118 self.calls = [
3119 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
3120 ((['git', 'config', 'branch.master.merge'],), 'master'),
3121 ((['git', 'config', 'branch.master.remote'],), 'origin'),
3122 ((['git', 'config', 'remote.origin.url'],), CERR1),
3123 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00003124 cl = git_cl.Changelist(issue=123456)
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00003125 self.assertEqual(cl._GerritChangeIdentifier(), '123456')
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00003126
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003127
Edward Lemur4c707a22019-09-24 21:13:43 +00003128class CMDTryTestCase(unittest.TestCase):
3129 def setUp(self):
3130 super(CMDTryTestCase, self).setUp()
3131 mock.patch('git_cl.sys.stdout', StringIO.StringIO()).start()
3132 mock.patch('git_cl.uuid.uuid4', _constantFn('uuid4')).start()
3133 mock.patch('git_cl.Changelist.GetIssue', _constantFn(123456)).start()
3134 mock.patch('git_cl.Changelist.GetCodereviewServer',
3135 _constantFn('https://chromium-review.googlesource.com')).start()
3136 mock.patch('git_cl.Changelist.SetPatchset').start()
3137 mock.patch('git_cl.Changelist.GetPatchset', _constantFn(7)).start()
3138 mock.patch('git_cl.auth.get_authenticator_for_host', AuthenticatorMock())
3139 self.addCleanup(mock.patch.stopall)
3140
3141 @mock.patch('git_cl.Changelist._GetChangeDetail')
3142 @mock.patch('git_cl.Changelist.SetCQState')
3143 @mock.patch('git_cl._get_bucket_map', _constantFn({}))
3144 def testSetCQDryRunByDefault(self, mockSetCQState, mockGetChangeDetail):
3145 mockSetCQState.return_value = 0
3146 mockGetChangeDetail.return_value = {
3147 'project': 'depot_tools',
3148 'status': 'OPEN',
3149 'owner': {'email': 'owner@e.mail'},
3150 'current_revision': 'beeeeeef',
3151 'revisions': {
3152 'deadbeaf': {
3153 '_number': 6,
3154 },
3155 'beeeeeef': {
3156 '_number': 7,
3157 'fetch': {'http': {
3158 'url': 'https://chromium.googlesource.com/depot_tools',
3159 'ref': 'refs/changes/56/123456/7'
3160 }},
3161 },
3162 },
3163 }
3164
3165 self.assertEqual(0, git_cl.main(['try']))
3166 git_cl.Changelist.SetCQState.assert_called_with(git_cl._CQState.DRY_RUN)
3167 self.assertEqual(
3168 sys.stdout.getvalue(),
3169 'Scheduling CQ dry run on: '
3170 'https://chromium-review.googlesource.com/123456\n')
3171
3172 @mock.patch('git_cl.Changelist._GetChangeDetail')
3173 @mock.patch('git_cl._call_buildbucket')
3174 def testScheduleOnBuildbucket(self, mockCallBuildbucket, mockGetChangeDetail):
3175 mockCallBuildbucket.return_value = {}
3176 mockGetChangeDetail.return_value = {
3177 'project': 'depot_tools',
3178 'status': 'OPEN',
3179 'owner': {'email': 'owner@e.mail'},
3180 'current_revision': 'beeeeeef',
3181 'revisions': {
3182 'deadbeaf': {
3183 '_number': 6,
3184 },
3185 'beeeeeef': {
3186 '_number': 7,
3187 'fetch': {'http': {
3188 'url': 'https://chromium.googlesource.com/depot_tools',
3189 'ref': 'refs/changes/56/123456/7'
3190 }},
3191 },
3192 },
3193 }
3194
3195 self.assertEqual(0, git_cl.main([
3196 'try', '-B', 'luci.chromium.try', '-b', 'win',
3197 '-p', 'key=val', '-p', 'json=[{"a":1}, null]']))
3198 self.assertIn(
3199 'Scheduling jobs on:\nBucket: luci.chromium.try',
3200 git_cl.sys.stdout.getvalue())
3201
3202 expected_request = {
3203 "requests": [{
3204 "scheduleBuild": {
3205 "requestId": "uuid4",
3206 "builder": {
3207 "project": "chromium",
3208 "builder": "win",
3209 "bucket": "try",
3210 },
3211 "gerritChanges": [{
3212 "project": "depot_tools",
3213 "host": "chromium-review.googlesource.com",
3214 "patchset": 7,
3215 "change": 123456,
3216 }],
3217 "properties": {
3218 "category": "git_cl_try",
3219 "json": [{"a": 1}, None],
3220 "key": "val",
3221 },
3222 "tags": [
3223 {"value": "win", "key": "builder"},
3224 {"value": "git_cl_try", "key": "user_agent"},
3225 ],
3226 },
3227 }],
3228 }
3229 mockCallBuildbucket.assert_called_with(
3230 mock.ANY, 'cr-buildbucket.appspot.com', 'Batch', expected_request)
3231
3232
3233 @mock.patch('git_cl.Changelist._GetChangeDetail')
3234 def testScheduleOnBuildbucket_WrongBucket(self, mockGetChangeDetail):
3235 mockGetChangeDetail.return_value = {
3236 'project': 'depot_tools',
3237 'status': 'OPEN',
3238 'owner': {'email': 'owner@e.mail'},
3239 'current_revision': 'beeeeeef',
3240 'revisions': {
3241 'deadbeaf': {
3242 '_number': 6,
3243 },
3244 'beeeeeef': {
3245 '_number': 7,
3246 'fetch': {'http': {
3247 'url': 'https://chromium.googlesource.com/depot_tools',
3248 'ref': 'refs/changes/56/123456/7'
3249 }},
3250 },
3251 },
3252 }
3253
3254 self.assertEqual(0, git_cl.main([
3255 'try', '-B', 'not-a-bucket', '-b', 'win',
3256 '-p', 'key=val', '-p', 'json=[{"a":1}, null]']))
3257 self.assertIn(
3258 'WARNING Could not parse bucket "not-a-bucket". Skipping.',
3259 git_cl.sys.stdout.getvalue())
3260
3261 def test_parse_bucket(self):
3262 test_cases = [
3263 {
3264 'bucket': 'chromium/try',
3265 'result': ('chromium', 'try'),
3266 },
3267 {
3268 'bucket': 'luci.chromium.try',
3269 'result': ('chromium', 'try'),
3270 'has_warning': True,
3271 },
3272 {
3273 'bucket': 'skia.primary',
3274 'result': ('skia', 'skia.primary'),
3275 'has_warning': True,
3276 },
3277 {
3278 'bucket': 'not-a-bucket',
3279 'result': (None, None),
3280 },
3281 ]
3282
3283 for test_case in test_cases:
3284 git_cl.sys.stdout.truncate(0)
3285 self.assertEqual(
3286 test_case['result'], git_cl._parse_bucket(test_case['bucket']))
3287 if test_case.get('has_warning'):
3288 self.assertIn(
3289 'WARNING Please specify buckets', git_cl.sys.stdout.getvalue())
3290
3291
maruel@chromium.orgddd59412011-11-30 14:20:38 +00003292if __name__ == '__main__':
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +01003293 logging.basicConfig(
3294 level=logging.DEBUG if '-v' in sys.argv else logging.ERROR)
maruel@chromium.orgddd59412011-11-30 14:20:38 +00003295 unittest.main()