blob: 82a06fc69f8146e3db75ab24d95d21a5e3b94541 [file] [log] [blame]
maruel@chromium.orgddd59412011-11-30 14:20:38 +00001#!/usr/bin/env python
maruel@chromium.orgeb5edbc2012-01-16 17:03:28 +00002# Copyright (c) 2012 The Chromium Authors. All rights reserved.
maruel@chromium.orgddd59412011-11-30 14:20:38 +00003# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5
6"""Unit tests for git_cl.py."""
7
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01008import datetime
tandriide281ae2016-10-12 06:02:30 -07009import json
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +010010import logging
maruel@chromium.orgddd59412011-11-30 14:20:38 +000011import os
maruel@chromium.orga3353652011-11-30 14:26:57 +000012import StringIO
maruel@chromium.orgddd59412011-11-30 14:20:38 +000013import sys
Aaron Gable9a03ae02017-11-03 11:31:07 -070014import tempfile
maruel@chromium.orgddd59412011-11-30 14:20:38 +000015import unittest
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +000016import urlparse
maruel@chromium.orgddd59412011-11-30 14:20:38 +000017
18sys.path.insert(0, os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
19
20from testing_support.auto_stub import TestCase
21
Edward Lemur5ba1e9c2018-07-23 18:19:02 +000022import metrics
23# We have to disable monitoring before importing git_cl.
24metrics.DISABLE_METRICS_COLLECTION = True
25
Eric Boren2fb63102018-10-05 13:05:03 +000026import gerrit_util
maruel@chromium.orgddd59412011-11-30 14:20:38 +000027import git_cl
iannucci@chromium.org9e849272014-04-04 00:31:55 +000028import git_common
tandrii@chromium.org57d86542016-03-04 16:11:32 +000029import git_footers
maruel@chromium.orgddd59412011-11-30 14:20:38 +000030import subprocess2
maruel@chromium.orgddd59412011-11-30 14:20:38 +000031
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +000032
tandrii5d48c322016-08-18 16:19:37 -070033def callError(code=1, cmd='', cwd='', stdout='', stderr=''):
34 return subprocess2.CalledProcessError(code, cmd, cwd, stdout, stderr)
35
36
37CERR1 = callError(1)
38
39
Aaron Gable9a03ae02017-11-03 11:31:07 -070040def MakeNamedTemporaryFileMock(expected_content):
41 class NamedTemporaryFileMock(object):
42 def __init__(self, *args, **kwargs):
43 self.name = '/tmp/named'
44 self.expected_content = expected_content
45
46 def __enter__(self):
47 return self
48
49 def __exit__(self, _type, _value, _tb):
50 pass
51
52 def write(self, content):
53 if self.expected_content:
54 assert content == self.expected_content
55
56 def close(self):
57 pass
58
59 return NamedTemporaryFileMock
60
61
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000062class ChangelistMock(object):
63 # A class variable so we can access it when we don't have access to the
64 # instance that's being set.
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +000065 desc = ''
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000066 def __init__(self, **kwargs):
67 pass
68 def GetIssue(self):
69 return 1
Kenneth Russell61e2ed42017-02-15 11:47:13 -080070 def GetDescription(self, force=False):
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000071 return ChangelistMock.desc
dsansomee2d6fd92016-09-08 00:10:47 -070072 def UpdateDescription(self, desc, force=False):
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000073 ChangelistMock.desc = desc
74
tandrii5d48c322016-08-18 16:19:37 -070075
maruel@chromium.org2e72bb12012-01-17 15:18:35 +000076class PresubmitMock(object):
77 def __init__(self, *args, **kwargs):
78 self.reviewers = []
Daniel Cheng7227d212017-11-17 08:12:37 -080079 self.more_cc = ['chromium-reviews+test-more-cc@chromium.org']
80
maruel@chromium.org2e72bb12012-01-17 15:18:35 +000081 @staticmethod
82 def should_continue():
83 return True
84
85
maruel@chromium.org2e72bb12012-01-17 15:18:35 +000086class WatchlistsMock(object):
87 def __init__(self, _):
88 pass
89 @staticmethod
90 def GetWatchersForPaths(_):
91 return ['joe@example.com']
92
93
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +000094class AuthenticatorMock(object):
95 def __init__(self, *_args):
96 pass
97 def has_cached_credentials(self):
98 return True
tandrii221ab252016-10-06 08:12:04 -070099 def authorize(self, http):
100 return http
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000101
102
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100103def CookiesAuthenticatorMockFactory(hosts_with_creds=None, same_auth=False):
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000104 """Use to mock Gerrit/Git credentials from ~/.netrc or ~/.gitcookies.
105
106 Usage:
107 >>> self.mock(git_cl.gerrit_util, "CookiesAuthenticator",
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100108 CookiesAuthenticatorMockFactory({'host': ('user', _, 'pass')})
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000109
110 OR
111 >>> self.mock(git_cl.gerrit_util, "CookiesAuthenticator",
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100112 CookiesAuthenticatorMockFactory(
113 same_auth=('user', '', 'pass'))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000114 """
115 class CookiesAuthenticatorMock(git_cl.gerrit_util.CookiesAuthenticator):
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800116 def __init__(self): # pylint: disable=super-init-not-called
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000117 # Intentionally not calling super() because it reads actual cookie files.
118 pass
119 @classmethod
120 def get_gitcookies_path(cls):
121 return '~/.gitcookies'
122 @classmethod
123 def get_netrc_path(cls):
124 return '~/.netrc'
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100125 def _get_auth_for_host(self, host):
126 if same_auth:
127 return same_auth
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000128 return (hosts_with_creds or {}).get(host)
129 return CookiesAuthenticatorMock
130
Aaron Gable9a03ae02017-11-03 11:31:07 -0700131
kmarshall9249e012016-08-23 12:02:16 -0700132class MockChangelistWithBranchAndIssue():
133 def __init__(self, branch, issue):
134 self.branch = branch
135 self.issue = issue
136 def GetBranch(self):
137 return self.branch
138 def GetIssue(self):
139 return self.issue
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000140
tandriic2405f52016-10-10 08:13:15 -0700141
142class SystemExitMock(Exception):
143 pass
144
145
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000146class TestGitClBasic(unittest.TestCase):
Andrii Shyshkalov31863012017-02-08 11:35:12 +0100147 def test_get_description(self):
Edward Lemurf38bc172019-09-03 21:02:13 +0000148 cl = git_cl.Changelist(issue=1, codereview_host='host')
Andrii Shyshkalov31863012017-02-08 11:35:12 +0100149 cl.description = 'x'
150 cl.has_description = True
Edward Lemur125d60a2019-09-13 18:25:41 +0000151 cl.FetchDescription = lambda *a, **kw: 'y'
Andrii Shyshkalov31863012017-02-08 11:35:12 +0100152 self.assertEquals(cl.GetDescription(), 'x')
153 self.assertEquals(cl.GetDescription(force=True), 'y')
154 self.assertEquals(cl.GetDescription(), 'y')
155
Robert Iannucci09f1f3d2017-03-28 16:54:32 -0700156 def test_description_footers(self):
Edward Lemurf38bc172019-09-03 21:02:13 +0000157 cl = git_cl.Changelist(issue=1, codereview_host='host')
Robert Iannucci09f1f3d2017-03-28 16:54:32 -0700158 cl.description = '\n'.join([
159 'This is some message',
160 '',
161 'It has some lines',
162 'and, also',
163 '',
164 'Some: Really',
165 'Awesome: Footers',
166 ])
167 cl.has_description = True
Edward Lemur125d60a2019-09-13 18:25:41 +0000168 cl.UpdateDescriptionRemote = lambda *a, **kw: 'y'
Robert Iannucci09f1f3d2017-03-28 16:54:32 -0700169 msg, footers = cl.GetDescriptionFooters()
170 self.assertEquals(
171 msg, ['This is some message', '', 'It has some lines', 'and, also'])
172 self.assertEquals(footers, [('Some', 'Really'), ('Awesome', 'Footers')])
173
174 msg.append('wut')
175 footers.append(('gnarly-dude', 'beans'))
176 cl.UpdateDescriptionFooters(msg, footers)
177 self.assertEquals(cl.GetDescription().splitlines(), [
178 'This is some message',
179 '',
180 'It has some lines',
181 'and, also',
182 'wut'
183 '',
184 'Some: Really',
185 'Awesome: Footers',
186 'Gnarly-Dude: beans',
187 ])
188
Andrii Shyshkalov71f0da32019-07-15 22:45:18 +0000189 def test_set_preserve_tryjobs(self):
190 d = git_cl.ChangeDescription('Simple.')
191 d.set_preserve_tryjobs()
192 self.assertEqual(d.description.splitlines(), [
193 'Simple.',
194 '',
195 'Cq-Do-Not-Cancel-Tryjobs: true',
196 ])
197 before = d.description
198 d.set_preserve_tryjobs()
199 self.assertEqual(before, d.description)
200
201 d = git_cl.ChangeDescription('\n'.join([
202 'One is enough',
203 '',
204 'Cq-Do-Not-Cancel-Tryjobs: dups not encouraged, but don\'t hurt',
205 'Change-Id: Ideadbeef',
206 ]))
207 d.set_preserve_tryjobs()
208 self.assertEqual(d.description.splitlines(), [
209 'One is enough',
210 '',
211 'Cq-Do-Not-Cancel-Tryjobs: dups not encouraged, but don\'t hurt',
212 'Change-Id: Ideadbeef',
213 'Cq-Do-Not-Cancel-Tryjobs: true',
214 ])
215
tandriif9aefb72016-07-01 09:06:51 -0700216 def test_get_bug_line_values(self):
217 f = lambda p, bugs: list(git_cl._get_bug_line_values(p, bugs))
218 self.assertEqual(f('', ''), [])
219 self.assertEqual(f('', '123,v8:456'), ['123', 'v8:456'])
220 self.assertEqual(f('v8', '456'), ['v8:456'])
221 self.assertEqual(f('v8', 'chromium:123,456'), ['v8:456', 'chromium:123'])
222 # Not nice, but not worth carying.
223 self.assertEqual(f('v8', 'chromium:123,456,v8:123'),
224 ['v8:456', 'chromium:123', 'v8:123'])
225
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100226 def _test_git_number(self, parent_msg, dest_ref, child_msg,
227 parent_hash='parenthash'):
228 desc = git_cl.ChangeDescription(child_msg)
229 desc.update_with_git_number_footers(parent_hash, parent_msg, dest_ref)
230 return desc.description
231
232 def assertEqualByLine(self, actual, expected):
233 self.assertEqual(actual.splitlines(), expected.splitlines())
234
235 def test_git_number_bad_parent(self):
236 with self.assertRaises(ValueError):
237 self._test_git_number('Parent', 'refs/heads/master', 'Child')
238
239 def test_git_number_bad_parent_footer(self):
240 with self.assertRaises(AssertionError):
241 self._test_git_number(
242 'Parent\n'
243 '\n'
244 'Cr-Commit-Position: wrong',
245 'refs/heads/master', 'Child')
246
247 def test_git_number_bad_lineage_ignored(self):
248 actual = self._test_git_number(
249 'Parent\n'
250 '\n'
251 'Cr-Commit-Position: refs/heads/master@{#1}\n'
252 'Cr-Branched-From: mustBeReal40CharHash-branch@{#pos}',
253 'refs/heads/master', 'Child')
254 self.assertEqualByLine(
255 actual,
256 'Child\n'
257 '\n'
258 'Cr-Commit-Position: refs/heads/master@{#2}\n'
259 'Cr-Branched-From: mustBeReal40CharHash-branch@{#pos}')
260
261 def test_git_number_same_branch(self):
262 actual = self._test_git_number(
263 'Parent\n'
264 '\n'
265 'Cr-Commit-Position: refs/heads/master@{#12}',
266 dest_ref='refs/heads/master',
267 child_msg='Child')
268 self.assertEqualByLine(
269 actual,
270 'Child\n'
271 '\n'
272 'Cr-Commit-Position: refs/heads/master@{#13}')
273
Andrii Shyshkalovde37c012017-07-06 21:06:50 +0200274 def test_git_number_same_branch_mixed_footers(self):
275 actual = self._test_git_number(
276 'Parent\n'
277 '\n'
278 'Cr-Commit-Position: refs/heads/master@{#12}',
279 dest_ref='refs/heads/master',
280 child_msg='Child\n'
281 '\n'
282 'Broken-by: design\n'
283 'BUG=123')
284 self.assertEqualByLine(
285 actual,
286 'Child\n'
287 '\n'
288 'Broken-by: design\n'
289 'BUG=123\n'
290 'Cr-Commit-Position: refs/heads/master@{#13}')
291
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100292 def test_git_number_same_branch_with_originals(self):
293 actual = self._test_git_number(
294 'Parent\n'
295 '\n'
296 'Cr-Commit-Position: refs/heads/master@{#12}',
297 dest_ref='refs/heads/master',
298 child_msg='Child\n'
299 '\n'
300 'Some users are smart and insert their own footers\n'
301 '\n'
302 'Cr-Whatever: value\n'
303 'Cr-Commit-Position: refs/copy/paste@{#22}')
304 self.assertEqualByLine(
305 actual,
306 'Child\n'
307 '\n'
308 'Some users are smart and insert their own footers\n'
309 '\n'
310 'Cr-Original-Whatever: value\n'
311 'Cr-Original-Commit-Position: refs/copy/paste@{#22}\n'
312 'Cr-Commit-Position: refs/heads/master@{#13}')
313
314 def test_git_number_new_branch(self):
315 actual = self._test_git_number(
316 'Parent\n'
317 '\n'
318 'Cr-Commit-Position: refs/heads/master@{#12}',
319 dest_ref='refs/heads/branch',
320 child_msg='Child')
321 self.assertEqualByLine(
322 actual,
323 'Child\n'
324 '\n'
325 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
326 'Cr-Branched-From: parenthash-refs/heads/master@{#12}')
327
328 def test_git_number_lineage(self):
329 actual = self._test_git_number(
330 'Parent\n'
331 '\n'
332 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
333 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
334 dest_ref='refs/heads/branch',
335 child_msg='Child')
336 self.assertEqualByLine(
337 actual,
338 'Child\n'
339 '\n'
340 'Cr-Commit-Position: refs/heads/branch@{#2}\n'
341 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
342
343 def test_git_number_moooooooore_lineage(self):
344 actual = self._test_git_number(
345 'Parent\n'
346 '\n'
347 'Cr-Commit-Position: refs/heads/branch@{#5}\n'
348 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
349 dest_ref='refs/heads/mooore',
350 child_msg='Child')
351 self.assertEqualByLine(
352 actual,
353 'Child\n'
354 '\n'
355 'Cr-Commit-Position: refs/heads/mooore@{#1}\n'
356 'Cr-Branched-From: parenthash-refs/heads/branch@{#5}\n'
357 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
358
Andrii Shyshkalovb5effa12016-12-14 19:35:12 +0100359 def test_git_number_ever_moooooooore_lineage(self):
Robert Iannucci456b0d62018-03-13 19:15:50 -0700360 self.maxDiff = 10000 # pylint: disable=attribute-defined-outside-init
Andrii Shyshkalovb5effa12016-12-14 19:35:12 +0100361 actual = self._test_git_number(
362 'CQ commit on fresh new branch + numbering.\n'
363 '\n'
364 'NOTRY=True\n'
365 'NOPRESUBMIT=True\n'
366 'BUG=\n'
367 '\n'
368 'Review-Url: https://codereview.chromium.org/2577703003\n'
369 'Cr-Commit-Position: refs/heads/gnumb-test/br@{#1}\n'
370 'Cr-Branched-From: 0749ff9edc-refs/heads/gnumb-test/cq@{#4}\n'
371 'Cr-Branched-From: 5c49df2da6-refs/heads/master@{#41618}',
372 dest_ref='refs/heads/gnumb-test/cl',
373 child_msg='git cl on fresh new branch + numbering.\n'
374 '\n'
375 'Review-Url: https://codereview.chromium.org/2575043003 .\n')
376 self.assertEqualByLine(
377 actual,
378 'git cl on fresh new branch + numbering.\n'
379 '\n'
380 'Review-Url: https://codereview.chromium.org/2575043003 .\n'
381 'Cr-Commit-Position: refs/heads/gnumb-test/cl@{#1}\n'
382 'Cr-Branched-From: parenthash-refs/heads/gnumb-test/br@{#1}\n'
383 'Cr-Branched-From: 0749ff9edc-refs/heads/gnumb-test/cq@{#4}\n'
384 'Cr-Branched-From: 5c49df2da6-refs/heads/master@{#41618}')
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100385
386 def test_git_number_cherry_pick(self):
387 actual = self._test_git_number(
388 'Parent\n'
389 '\n'
390 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
391 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
392 dest_ref='refs/heads/branch',
393 child_msg='Child, which is cherry-pick from master\n'
394 '\n'
395 'Cr-Commit-Position: refs/heads/master@{#100}\n'
396 '(cherry picked from commit deadbeef12345678deadbeef12345678deadbeef)')
397 self.assertEqualByLine(
398 actual,
399 'Child, which is cherry-pick from master\n'
400 '\n'
401 '(cherry picked from commit deadbeef12345678deadbeef12345678deadbeef)\n'
402 '\n'
403 'Cr-Original-Commit-Position: refs/heads/master@{#100}\n'
404 'Cr-Commit-Position: refs/heads/branch@{#2}\n'
405 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
406
Andrii Shyshkalovd4c86732018-09-25 04:29:31 +0000407 def test_gerrit_mirror_hack(self):
408 cr = 'chromium-review.googlesource.com'
409 url0 = 'https://%s/a/changes/x?a=b' % cr
410 origMirrors = git_cl.gerrit_util._GERRIT_MIRROR_PREFIXES
411 try:
412 git_cl.gerrit_util._GERRIT_MIRROR_PREFIXES = ['us1', 'us2']
413 url1 = git_cl.gerrit_util._UseGerritMirror(url0, cr)
414 url2 = git_cl.gerrit_util._UseGerritMirror(url1, cr)
415 url3 = git_cl.gerrit_util._UseGerritMirror(url2, cr)
416
417 self.assertNotEqual(url1, url2)
418 self.assertEqual(sorted((url1, url2)), [
419 'https://us1-mirror-chromium-review.googlesource.com/a/changes/x?a=b',
420 'https://us2-mirror-chromium-review.googlesource.com/a/changes/x?a=b'])
421 self.assertEqual(url1, url3)
422 finally:
423 git_cl.gerrit_util._GERRIT_MIRROR_PREFIXES = origMirrors
424
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +0000425 def test_valid_accounts(self):
426 mock_per_account = {
427 'u1': None, # 404, doesn't exist.
428 'u2': {
429 '_account_id': 123124,
430 'avatars': [],
431 'email': 'u2@example.com',
432 'name': 'User Number 2',
433 'status': 'OOO',
434 },
435 'u3': git_cl.gerrit_util.GerritError(500, 'retries didn\'t help :('),
436 }
437 def GetAccountDetailsMock(_, account):
438 # Poor-man's mock library's side_effect.
439 v = mock_per_account.pop(account)
440 if isinstance(v, Exception):
441 raise v
442 return v
443
444 original = git_cl.gerrit_util.GetAccountDetails
445 try:
446 git_cl.gerrit_util.GetAccountDetails = GetAccountDetailsMock
447 actual = git_cl.gerrit_util.ValidAccounts(
448 'host', ['u1', 'u2', 'u3'], max_threads=1)
449 finally:
450 git_cl.gerrit_util.GetAccountDetails = original
451 self.assertEqual(actual, {
452 'u2': {
453 '_account_id': 123124,
454 'avatars': [],
455 'email': 'u2@example.com',
456 'name': 'User Number 2',
457 'status': 'OOO',
458 },
459 })
460
461
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200462class TestParseIssueURL(unittest.TestCase):
463 def _validate(self, parsed, issue=None, patchset=None, hostname=None,
Edward Lemurf38bc172019-09-03 21:02:13 +0000464 fail=False):
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200465 self.assertIsNotNone(parsed)
466 if fail:
467 self.assertFalse(parsed.valid)
468 return
469 self.assertTrue(parsed.valid)
470 self.assertEqual(parsed.issue, issue)
471 self.assertEqual(parsed.patchset, patchset)
472 self.assertEqual(parsed.hostname, hostname)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200473
474 def _run_and_validate(self, func, url, *args, **kwargs):
475 result = func(urlparse.urlparse(url))
476 if kwargs.pop('fail', False):
477 self.assertIsNone(result)
478 return None
479 self._validate(result, *args, fail=False, **kwargs)
480
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200481 def test_gerrit(self):
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200482 def test(url, *args, **kwargs):
Edward Lemur125d60a2019-09-13 18:25:41 +0000483 self._run_and_validate(git_cl.Changelist.ParseIssueURL, url,
Edward Lemurf38bc172019-09-03 21:02:13 +0000484 *args, **kwargs)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200485
486 test('http://chrome-review.source.com/c/123',
487 123, None, 'chrome-review.source.com')
488 test('https://chrome-review.source.com/c/123/',
489 123, None, 'chrome-review.source.com')
490 test('https://chrome-review.source.com/c/123/4',
491 123, 4, 'chrome-review.source.com')
492 test('https://chrome-review.source.com/#/c/123/4',
493 123, 4, 'chrome-review.source.com')
494 test('https://chrome-review.source.com/c/123/4',
495 123, 4, 'chrome-review.source.com')
496 test('https://chrome-review.source.com/123',
497 123, None, 'chrome-review.source.com')
498 test('https://chrome-review.source.com/123/4',
499 123, 4, 'chrome-review.source.com')
500
501 test('https://chrome-review.source.com/c/123/1/whatisthis', fail=True)
502 test('https://chrome-review.source.com/c/abc/', fail=True)
503 test('ssh://chrome-review.source.com/c/123/1/', fail=True)
504
505 def test_ParseIssueNumberArgument(self):
506 def test(arg, *args, **kwargs):
Edward Lemurf38bc172019-09-03 21:02:13 +0000507 self._validate(git_cl.ParseIssueNumberArgument(arg), *args, **kwargs)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200508
509 test('123', 123)
510 test('', fail=True)
511 test('abc', fail=True)
512 test('123/1', fail=True)
513 test('123a', fail=True)
514 test('ssh://chrome-review.source.com/#/c/123/4/', fail=True)
Andrii Shyshkalovf5569d22018-10-15 03:35:23 +0000515
Andrii Shyshkalovc9712392017-04-11 13:35:21 +0200516 test('https://codereview.source.com/123',
Edward Lemurf38bc172019-09-03 21:02:13 +0000517 123, None, 'codereview.source.com')
Andrii Shyshkalovf5569d22018-10-15 03:35:23 +0000518
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200519 # Gerrrit.
520 test('https://chrome-review.source.com/c/123/4',
Edward Lemurf38bc172019-09-03 21:02:13 +0000521 123, 4, 'chrome-review.source.com')
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200522 test('https://chrome-review.source.com/bad/123/4', fail=True)
523
524
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100525class GitCookiesCheckerTest(TestCase):
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100526 def setUp(self):
527 super(GitCookiesCheckerTest, self).setUp()
528 self.c = git_cl._GitCookiesChecker()
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100529 self.c._all_hosts = []
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100530
531 def mock_hosts_creds(self, subhost_identity_pairs):
532 def ensure_googlesource(h):
533 if not h.endswith(self.c._GOOGLESOURCE):
534 assert not h.endswith('.')
535 return h + '.' + self.c._GOOGLESOURCE
536 return h
537 self.c._all_hosts = [(ensure_googlesource(h), i, '.gitcookies')
538 for h, i in subhost_identity_pairs]
539
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +0200540 def test_identity_parsing(self):
541 self.assertEqual(self.c._parse_identity('ldap.google.com'),
542 ('ldap', 'google.com'))
543 self.assertEqual(self.c._parse_identity('git-ldap.example.com'),
544 ('ldap', 'example.com'))
545 # Specical case because we know there are no subdomains in chromium.org.
546 self.assertEqual(self.c._parse_identity('git-note.period.chromium.org'),
547 ('note.period', 'chromium.org'))
Lei Zhangd3f769a2017-12-15 15:16:14 -0800548 # Pathological: ".period." can be either username OR domain, more likely
549 # domain.
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +0200550 self.assertEqual(self.c._parse_identity('git-note.period.example.com'),
551 ('note', 'period.example.com'))
552
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100553 def test_analysis_nothing(self):
554 self.c._all_hosts = []
555 self.assertFalse(self.c.has_generic_host())
556 self.assertEqual(set(), self.c.get_conflicting_hosts())
557 self.assertEqual(set(), self.c.get_duplicated_hosts())
558 self.assertEqual(set(), self.c.get_partially_configured_hosts())
559 self.assertEqual(set(), self.c.get_hosts_with_wrong_identities())
560
561 def test_analysis(self):
562 self.mock_hosts_creds([
563 ('.googlesource.com', 'git-example.chromium.org'),
564
565 ('chromium', 'git-example.google.com'),
566 ('chromium-review', 'git-example.google.com'),
567 ('chrome-internal', 'git-example.chromium.org'),
568 ('chrome-internal-review', 'git-example.chromium.org'),
569 ('conflict', 'git-example.google.com'),
570 ('conflict-review', 'git-example.chromium.org'),
571 ('dup', 'git-example.google.com'),
572 ('dup', 'git-example.google.com'),
573 ('dup-review', 'git-example.google.com'),
574 ('partial', 'git-example.google.com'),
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200575 ('gpartial-review', 'git-example.google.com'),
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100576 ])
577 self.assertTrue(self.c.has_generic_host())
578 self.assertEqual(set(['conflict.googlesource.com']),
579 self.c.get_conflicting_hosts())
580 self.assertEqual(set(['dup.googlesource.com']),
581 self.c.get_duplicated_hosts())
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200582 self.assertEqual(set(['partial.googlesource.com',
583 'gpartial-review.googlesource.com']),
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100584 self.c.get_partially_configured_hosts())
585 self.assertEqual(set(['chromium.googlesource.com',
586 'chrome-internal.googlesource.com']),
587 self.c.get_hosts_with_wrong_identities())
588
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100589 def test_report_no_problems(self):
590 self.test_analysis_nothing()
591 self.mock(sys, 'stdout', StringIO.StringIO())
592 self.assertFalse(self.c.find_and_report_problems())
593 self.assertEqual(sys.stdout.getvalue(), '')
594
595 def test_report(self):
596 self.test_analysis()
597 self.mock(sys, 'stdout', StringIO.StringIO())
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200598 self.mock(git_cl.gerrit_util.CookiesAuthenticator, 'get_gitcookies_path',
599 classmethod(lambda _: '~/.gitcookies'))
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100600 self.assertTrue(self.c.find_and_report_problems())
601 with open(os.path.join(os.path.dirname(__file__),
602 'git_cl_creds_check_report.txt')) as f:
603 expected = f.read()
604 def by_line(text):
605 return [l.rstrip() for l in text.rstrip().splitlines()]
Robert Iannucci456b0d62018-03-13 19:15:50 -0700606 self.maxDiff = 10000 # pylint: disable=attribute-defined-outside-init
Andrii Shyshkalov4812e612017-03-27 17:22:57 +0200607 self.assertEqual(by_line(sys.stdout.getvalue().strip()), by_line(expected))
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100608
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -0800609
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000610class TestGitCl(TestCase):
611 def setUp(self):
612 super(TestGitCl, self).setUp()
613 self.calls = []
tandrii9d206752016-06-20 11:32:47 -0700614 self._calls_done = []
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000615 self.mock(git_cl, 'time_time',
616 lambda: self._mocked_call('time.time'))
617 self.mock(git_cl.metrics.collector, 'add_repeated',
618 lambda *a: self._mocked_call('add_repeated', *a))
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000619 self.mock(subprocess2, 'call', self._mocked_call)
620 self.mock(subprocess2, 'check_call', self._mocked_call)
621 self.mock(subprocess2, 'check_output', self._mocked_call)
tandrii5d48c322016-08-18 16:19:37 -0700622 self.mock(subprocess2, 'communicate',
623 lambda *a, **kw: ([self._mocked_call(*a, **kw), ''], 0))
tandrii@chromium.orga342c922016-03-16 07:08:25 +0000624 self.mock(git_cl.gclient_utils, 'CheckCallAndFilter', self._mocked_call)
sbc@chromium.org71437c02015-04-09 19:29:40 +0000625 self.mock(git_common, 'is_dirty_git_tree', lambda x: False)
iannucci@chromium.org9e849272014-04-04 00:31:55 +0000626 self.mock(git_common, 'get_or_create_merge_base',
627 lambda *a: (
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000628 self._mocked_call(['get_or_create_merge_base'] + list(a))))
pgervais@chromium.org8ba38ff2015-06-11 21:41:25 +0000629 self.mock(git_cl, 'BranchExists', lambda _: True)
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000630 self.mock(git_cl, 'FindCodereviewSettingsFile', lambda: '')
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000631 self.mock(git_cl, 'SaveDescriptionBackup', lambda _:
632 self._mocked_call('SaveDescriptionBackup'))
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100633 self.mock(git_cl, 'ask_for_data', lambda *a, **k: self._mocked_call(
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000634 *(['ask_for_data'] + list(a)), **k))
phajdan.jre328cf92016-08-22 04:12:17 -0700635 self.mock(git_cl, 'write_json', lambda path, contents:
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000636 self._mocked_call('write_json', path, contents))
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000637 self.mock(git_cl.presubmit_support, 'DoPresubmitChecks', PresubmitMock)
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000638 self.mock(git_cl.watchlists, 'Watchlists', WatchlistsMock)
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000639 self.mock(git_cl.auth, 'get_authenticator_for_host', AuthenticatorMock)
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +0100640 self.mock(git_cl.gerrit_util, 'GetChangeDetail',
641 lambda *args, **kwargs: self._mocked_call(
642 'GetChangeDetail', *args, **kwargs))
Aaron Gable0ffdf2d2017-06-05 13:01:17 -0700643 self.mock(git_cl.gerrit_util, 'GetChangeComments',
644 lambda *args, **kwargs: self._mocked_call(
645 'GetChangeComments', *args, **kwargs))
Quinten Yearsley0e617c02019-02-20 00:37:03 +0000646 self.mock(git_cl.gerrit_util, 'GetChangeRobotComments',
647 lambda *args, **kwargs: self._mocked_call(
648 'GetChangeRobotComments', *args, **kwargs))
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +0100649 self.mock(git_cl.gerrit_util, 'AddReviewers',
Aaron Gable6dadfbf2017-05-09 14:27:58 -0700650 lambda h, i, reviewers, ccs, notify: self._mocked_call(
651 'AddReviewers', h, i, reviewers, ccs, notify))
Aaron Gablefd238082017-06-07 13:42:34 -0700652 self.mock(git_cl.gerrit_util, 'SetReview',
Aaron Gablefc62f762017-07-17 11:12:07 -0700653 lambda h, i, msg=None, labels=None, notify=None:
654 self._mocked_call('SetReview', h, i, msg, labels, notify))
Andrii Shyshkalov733d4ec2018-04-19 11:48:58 -0700655 self.mock(git_cl.gerrit_util.LuciContextAuthenticator, 'is_luci',
656 staticmethod(lambda: False))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000657 self.mock(git_cl.gerrit_util.GceAuthenticator, 'is_gce',
658 classmethod(lambda _: False))
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +0000659 self.mock(git_cl.gerrit_util, 'ValidAccounts',
660 lambda host, accounts:
661 self._mocked_call('ValidAccounts', host, accounts))
tandriic2405f52016-10-10 08:13:15 -0700662 self.mock(git_cl, 'DieWithError',
Christopher Lamf732cd52017-01-24 12:40:11 +1100663 lambda msg, change=None: self._mocked_call(['DieWithError', msg]))
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000664 # It's important to reset settings to not have inter-tests interference.
665 git_cl.settings = None
666
667 def tearDown(self):
wychen@chromium.org445c8962015-04-28 23:30:05 +0000668 try:
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100669 self.assertEquals([], self.calls)
670 except AssertionError:
wychen@chromium.org445c8962015-04-28 23:30:05 +0000671 if not self.has_failed():
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100672 raise
673 # Sadly, has_failed() returns True if this OR any other tests before this
674 # one have failed.
Andrii Shyshkalove05d4882017-04-12 14:34:49 +0200675 git_cl.logging.error(
676 '!!!!!! IF YOU SEE THIS, READ BELOW, IT WILL SAVE YOUR TIME !!!!!\n'
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100677 'There are un-consumed self.calls after this test has finished.\n'
678 'If you don\'t know which test this is, run:\n'
Aaron Gable3a16ed12017-03-23 10:51:55 -0700679 ' tests/git_cl_tests.py -v\n'
Andrii Shyshkalove05d4882017-04-12 14:34:49 +0200680 'If you are already running only this test, then **first** fix the '
681 'problem whose exception is emitted below by unittest runner.\n'
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100682 'Else, to be sure what\'s going on, run this test **alone** with \n'
Aaron Gable3a16ed12017-03-23 10:51:55 -0700683 ' tests/git_cl_tests.py TestGitCl.<name>\n'
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100684 'and follow instructions above.\n' +
685 '=' * 80)
wychen@chromium.org445c8962015-04-28 23:30:05 +0000686 finally:
687 super(TestGitCl, self).tearDown()
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000688
iannucci@chromium.org9e849272014-04-04 00:31:55 +0000689 def _mocked_call(self, *args, **_kwargs):
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000690 self.assertTrue(
691 self.calls,
tandrii9d206752016-06-20 11:32:47 -0700692 '@%d Expected: <Missing> Actual: %r' % (len(self._calls_done), args))
wychen@chromium.orga872e752015-04-28 23:42:18 +0000693 top = self.calls.pop(0)
wychen@chromium.orga872e752015-04-28 23:42:18 +0000694 expected_args, result = top
695
maruel@chromium.orge52678e2013-04-26 18:34:44 +0000696 # Also logs otherwise it could get caught in a try/finally and be hard to
697 # diagnose.
698 if expected_args != args:
tandrii9d206752016-06-20 11:32:47 -0700699 N = 5
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000700 prior_calls = '\n '.join(
tandrii9d206752016-06-20 11:32:47 -0700701 '@%d: %r' % (len(self._calls_done) - N + i, c[0])
702 for i, c in enumerate(self._calls_done[-N:]))
703 following_calls = '\n '.join(
704 '@%d: %r' % (len(self._calls_done) + i + 1, c[0])
705 for i, c in enumerate(self.calls[:N]))
706 extended_msg = (
707 'A few prior calls:\n %s\n\n'
708 'This (expected):\n @%d: %r\n'
709 'This (actual):\n @%d: %r\n\n'
710 'A few following expected calls:\n %s' %
711 (prior_calls, len(self._calls_done), expected_args,
712 len(self._calls_done), args, following_calls))
713 git_cl.logging.error(extended_msg)
714
tandrii99a72f22016-08-17 14:33:24 -0700715 self.fail('@%d\n'
716 ' Expected: %r\n'
717 ' Actual: %r' % (
tandrii9d206752016-06-20 11:32:47 -0700718 len(self._calls_done), expected_args, args))
719
720 self._calls_done.append(top)
tandrii5d48c322016-08-18 16:19:37 -0700721 if isinstance(result, Exception):
722 raise result
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000723 return result
724
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100725 def test_ask_for_explicit_yes_true(self):
726 self.calls = [
727 (('ask_for_data', 'prompt [Yes/No]: '), 'blah'),
728 (('ask_for_data', 'Please, type yes or no: '), 'ye'),
729 ]
730 self.assertTrue(git_cl.ask_for_explicit_yes('prompt'))
731
tandrii48df5812016-10-17 03:55:37 -0700732 def test_LoadCodereviewSettingsFromFile_gerrit(self):
733 codereview_file = StringIO.StringIO('GERRIT_HOST: true')
734 self.calls = [
735 ((['git', 'config', '--unset-all', 'rietveld.cc'],), CERR1),
tandrii48df5812016-10-17 03:55:37 -0700736 ((['git', 'config', '--unset-all', 'rietveld.tree-status-url'],), CERR1),
737 ((['git', 'config', '--unset-all', 'rietveld.viewvc-url'],), CERR1),
738 ((['git', 'config', '--unset-all', 'rietveld.bug-prefix'],), CERR1),
739 ((['git', 'config', '--unset-all', 'rietveld.cpplint-regex'],), CERR1),
tandrii48df5812016-10-17 03:55:37 -0700740 ((['git', 'config', '--unset-all', 'rietveld.cpplint-ignore-regex'],),
741 CERR1),
tandrii48df5812016-10-17 03:55:37 -0700742 ((['git', 'config', '--unset-all', 'rietveld.run-post-upload-hook'],),
743 CERR1),
744 ((['git', 'config', 'gerrit.host', 'true'],), ''),
745 ]
746 self.assertIsNone(git_cl.LoadCodereviewSettingsFromFile(codereview_file))
747
maruel@chromium.orga3353652011-11-30 14:26:57 +0000748 @classmethod
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000749 def _is_gerrit_calls(cls, gerrit=False):
750 return [((['git', 'config', 'rietveld.autoupdate'],), ''),
751 ((['git', 'config', 'gerrit.host'],), 'True' if gerrit else '')]
752
753 @classmethod
tandrii@chromium.org1e67bb72016-02-11 12:15:49 +0000754 def _git_post_upload_calls(cls):
755 return [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000756 ((['git', 'rev-parse', 'HEAD'],), 'hash'),
757 ((['git', 'symbolic-ref', 'HEAD'],), 'hash'),
758 ((['git',
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000759 'config', 'branch.hash.last-upload-hash', 'hash'],), ''),
rmistry@google.com5626a922015-02-26 14:03:30 +0000760 ((['git', 'config', 'rietveld.run-post-upload-hook'],), ''),
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000761 ]
762
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000763 @staticmethod
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000764 def _git_sanity_checks(diff_base, working_branch, get_remote_branch=True):
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000765 fake_ancestor = 'fake_ancestor'
766 fake_cl = 'fake_cl_for_patch'
767 return [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000768 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000769 'rev-parse', '--verify', diff_base],), fake_ancestor),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000770 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000771 'merge-base', fake_ancestor, 'HEAD'],), fake_ancestor),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000772 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000773 'rev-list', '^' + fake_ancestor, 'HEAD'],), fake_cl),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000774 # Mock a config miss (error code 1)
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000775 ((['git',
tandrii5d48c322016-08-18 16:19:37 -0700776 'config', 'gitcl.remotebranch'],), CERR1),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000777 ] + ([
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000778 # Call to GetRemoteBranch()
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000779 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000780 'config', 'branch.%s.merge' % working_branch],),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000781 'refs/heads/master'),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000782 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000783 'config', 'branch.%s.remote' % working_branch],), 'origin'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000784 ] if get_remote_branch else []) + [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000785 ((['git', 'rev-list', '^' + fake_ancestor,
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000786 'refs/remotes/origin/master'],), ''),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000787 ]
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000788
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000789 @classmethod
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000790 def _gerrit_ensure_auth_calls(
Edward Lemurf38bc172019-09-03 21:02:13 +0000791 cls, issue=None, skip_auth_check=False, short_hostname='chromium',
792 custom_cl_base=None):
shinyak@chromium.org00dbccd2016-04-15 07:24:43 +0000793 cmd = ['git', 'config', '--bool', 'gerrit.skip-ensure-authenticated']
tandrii@chromium.org28253532016-04-14 13:46:56 +0000794 if skip_auth_check:
795 return [((cmd, ), 'true')]
796
tandrii5d48c322016-08-18 16:19:37 -0700797 calls = [((cmd, ), CERR1)]
Edward Lemurf38bc172019-09-03 21:02:13 +0000798
799 if custom_cl_base:
800 calls += [
801 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
802 ]
803
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000804 calls.extend([
805 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
806 ((['git', 'config', 'branch.master.remote'],), 'origin'),
807 ((['git', 'config', 'remote.origin.url'],),
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000808 'https://%s.googlesource.com/my/repo' % short_hostname),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000809 ])
Edward Lemurf38bc172019-09-03 21:02:13 +0000810
811 calls += [
812 ((['git', 'config', 'branch.master.gerritissue'],),
813 CERR1 if issue is None else str(issue)),
814 ]
815
Daniel Chengcf6269b2019-05-18 01:02:12 +0000816 if issue:
817 calls.extend([
818 ((['git', 'config', 'branch.master.gerritserver'],), CERR1),
819 ])
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000820 return calls
821
822 @classmethod
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100823 def _gerrit_base_calls(cls, issue=None, fetched_description=None,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200824 fetched_status=None, other_cl_owner=None,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000825 custom_cl_base=None, short_hostname='chromium'):
Aaron Gable13101a62018-02-09 13:20:41 -0800826 calls = cls._is_gerrit_calls(True)
Edward Lemurf38bc172019-09-03 21:02:13 +0000827 if not custom_cl_base:
828 calls += [
829 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
830 ]
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200831
832 if custom_cl_base:
833 ancestor_revision = custom_cl_base
834 else:
835 # Determine ancestor_revision to be merge base.
836 ancestor_revision = 'fake_ancestor_sha'
837 calls += [
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000838 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000839 ((['git', 'config', 'branch.master.remote'],), 'origin'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000840 ((['get_or_create_merge_base', 'master',
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200841 'refs/remotes/origin/master'],), ancestor_revision),
842 ]
843
844 # Calls to verify branch point is ancestor
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000845 calls += cls._gerrit_ensure_auth_calls(
Edward Lemurf38bc172019-09-03 21:02:13 +0000846 issue=issue, short_hostname=short_hostname,
847 custom_cl_base=custom_cl_base)
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100848
849 if issue:
850 calls += [
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000851 (('GetChangeDetail', '%s-review.googlesource.com' % short_hostname,
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +0000852 'my%2Frepo~123456',
Andrii Shyshkalovc4a73562018-09-25 18:40:17 +0000853 ['DETAILED_ACCOUNTS', 'CURRENT_REVISION', 'CURRENT_COMMIT', 'LABELS']
854 ),
Andrii Shyshkalov3e631422017-02-16 17:46:44 +0100855 {
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100856 'owner': {'email': (other_cl_owner or 'owner@example.com')},
Andrii Shyshkalov3e631422017-02-16 17:46:44 +0100857 'change_id': '123456789',
858 'current_revision': 'sha1_of_current_revision',
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000859 'revisions': {'sha1_of_current_revision': {
Andrii Shyshkalov3e631422017-02-16 17:46:44 +0100860 'commit': {'message': fetched_description},
861 }},
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100862 'status': fetched_status or 'NEW',
Andrii Shyshkalov3e631422017-02-16 17:46:44 +0100863 }),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100864 ]
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100865 if fetched_status == 'ABANDONED':
866 calls += [
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000867 (('DieWithError', 'Change https://%s-review.googlesource.com/'
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100868 '123456 has been abandoned, new uploads are not '
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000869 'allowed' % short_hostname), SystemExitMock()),
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100870 ]
871 return calls
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100872 if other_cl_owner:
873 calls += [
874 (('ask_for_data', 'Press Enter to upload, or Ctrl+C to abort'), ''),
875 ]
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100876
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200877 calls += cls._git_sanity_checks(ancestor_revision, 'master',
878 get_remote_branch=False)
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100879 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200880 ((['git', 'rev-parse', '--show-cdup'],), ''),
881 ((['git', 'rev-parse', 'HEAD'],), '12345'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000882
Aaron Gable7817f022017-12-12 09:43:17 -0800883 ((['git', '-c', 'core.quotePath=false', 'diff', '--name-status',
884 '--no-renames', '-r', ancestor_revision + '...', '.'],),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200885 'M\t.gitignore\n'),
886 ((['git', 'config', 'branch.master.gerritpatchset'],), CERR1),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100887 ]
888
889 if not issue:
890 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200891 ((['git', 'log', '--pretty=format:%s%n%n%b',
892 ancestor_revision + '...'],),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000893 'foo'),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100894 ]
895
896 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200897 ((['git', 'config', 'user.email'],), 'me@example.com'),
Edward Lemur2c48f242019-06-04 16:14:09 +0000898 (('time.time',), 1000,),
899 (('time.time',), 3000,),
900 (('add_repeated', 'sub_commands', {
901 'execution_time': 2000,
902 'command': 'presubmit',
903 'exit_code': 0
904 }), None,),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200905 ((['git', 'diff', '--no-ext-diff', '--stat', '-l100000', '-C50'] +
906 ([custom_cl_base] if custom_cl_base else
907 [ancestor_revision, 'HEAD']),),
908 '+dat'),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100909 ]
910 return calls
ukai@chromium.orge8077812012-02-03 03:41:46 +0000911
tandrii@chromium.org1e67bb72016-02-11 12:15:49 +0000912 @classmethod
913 def _gerrit_upload_calls(cls, description, reviewers, squash,
tandriia60502f2016-06-20 02:01:53 -0700914 squash_mode='default',
tandrii@chromium.org10625002016-03-04 20:03:47 +0000915 expected_upstream_ref='origin/refs/heads/master',
Aaron Gablefd238082017-06-07 13:42:34 -0700916 title=None, notify=False,
Andrii Shyshkalove9c78ff2017-02-06 15:53:13 +0100917 post_amend_description=None, issue=None, cc=None,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000918 custom_cl_base=None, tbr=None,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +0000919 short_hostname='chromium',
Edward Lemur1b52d872019-05-09 21:12:12 +0000920 labels=None, change_id=None, original_title=None,
921 final_description=None, gitcookies_exists=True):
tandrii@chromium.org10625002016-03-04 20:03:47 +0000922 if post_amend_description is None:
923 post_amend_description = description
bradnelsond975b302016-10-23 12:20:23 -0700924 cc = cc or []
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200925 # Determined in `_gerrit_base_calls`.
926 determined_ancestor_revision = custom_cl_base or 'fake_ancestor_sha'
927
928 calls = []
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000929
tandriia60502f2016-06-20 02:01:53 -0700930 if squash_mode == 'default':
931 calls.extend([
932 ((['git', 'config', '--bool', 'gerrit.override-squash-uploads'],), ''),
933 ((['git', 'config', '--bool', 'gerrit.squash-uploads'],), ''),
934 ])
935 elif squash_mode in ('override_squash', 'override_nosquash'):
936 calls.extend([
937 ((['git', 'config', '--bool', 'gerrit.override-squash-uploads'],),
938 'true' if squash_mode == 'override_squash' else 'false'),
939 ])
940 else:
941 assert squash_mode in ('squash', 'nosquash')
942
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000943 # If issue is given, then description is fetched from Gerrit instead.
944 if issue is None:
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000945 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200946 ((['git', 'log', '--pretty=format:%s\n\n%b',
947 ((custom_cl_base + '..') if custom_cl_base else
948 'fake_ancestor_sha..HEAD')],),
949 description),
950 ]
Aaron Gableb56ad332017-01-06 15:24:31 -0800951 if squash:
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +0000952 title = 'Initial_upload'
Aaron Gableb56ad332017-01-06 15:24:31 -0800953 else:
954 if not title:
955 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200956 ((['git', 'show', '-s', '--format=%s', 'HEAD'],), ''),
957 (('ask_for_data', 'Title for patchset []: '), 'User input'),
Aaron Gableb56ad332017-01-06 15:24:31 -0800958 ]
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +0000959 title = 'User_input'
tandrii@chromium.org57d86542016-03-04 16:11:32 +0000960 if not git_footers.get_footer_change_id(description) and not squash:
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +0000961 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200962 (('DownloadGerritHook', False), ''),
963 # Amending of commit message to get the Change-Id.
964 ((['git', 'log', '--pretty=format:%s\n\n%b',
965 determined_ancestor_revision + '..HEAD'],),
966 description),
967 ((['git', 'commit', '--amend', '-m', description],), ''),
968 ((['git', 'log', '--pretty=format:%s\n\n%b',
969 determined_ancestor_revision + '..HEAD'],),
970 post_amend_description)
971 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000972 if squash:
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000973 if not issue:
974 # Prompting to edit description on first upload.
975 calls += [
Jonas Termansend0f79112019-03-22 15:28:26 +0000976 ((['git', 'config', 'rietveld.bug-prefix'],), ''),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200977 ((['git', 'config', 'core.editor'],), ''),
978 ((['RunEditor'],), description),
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000979 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000980 ref_to_push = 'abcdef0123456789'
981 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200982 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
983 ((['git', 'config', 'branch.master.remote'],), 'origin'),
984 ]
985
986 if custom_cl_base is None:
987 calls += [
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000988 ((['get_or_create_merge_base', 'master',
989 'refs/remotes/origin/master'],),
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000990 'origin/master'),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200991 ]
992 parent = 'origin/master'
993 else:
994 calls += [
995 ((['git', 'merge-base', '--is-ancestor', custom_cl_base,
996 'refs/remotes/origin/master'],),
997 callError(1)), # Means not ancenstor.
998 (('ask_for_data',
999 'Do you take responsibility for cleaning up potential mess '
1000 'resulting from proceeding with upload? Press Enter to upload, '
1001 'or Ctrl+C to abort'), ''),
1002 ]
1003 parent = custom_cl_base
1004
1005 calls += [
1006 ((['git', 'rev-parse', 'HEAD:'],), # `HEAD:` means HEAD's tree hash.
1007 '0123456789abcdef'),
1008 ((['git', 'commit-tree', '0123456789abcdef', '-p', parent,
Aaron Gable9a03ae02017-11-03 11:31:07 -07001009 '-F', '/tmp/named'],),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001010 ref_to_push),
1011 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001012 else:
1013 ref_to_push = 'HEAD'
1014
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001015 calls += [
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +00001016 (('SaveDescriptionBackup',), None),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001017 ((['git', 'rev-list',
1018 (custom_cl_base if custom_cl_base else expected_upstream_ref) + '..' +
1019 ref_to_push],),
1020 '1hashPerLine\n'),
1021 ]
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001022
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001023 metrics_arguments = []
1024
Aaron Gableafd52772017-06-27 16:40:10 -07001025 if notify:
Aaron Gable844cf292017-06-28 11:32:59 -07001026 ref_suffix = '%ready,notify=ALL'
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001027 metrics_arguments += ['ready', 'notify=ALL']
Aaron Gable844cf292017-06-28 11:32:59 -07001028 else:
Jamie Madill276da0b2018-04-27 14:41:20 -04001029 if not issue and squash:
Aaron Gable844cf292017-06-28 11:32:59 -07001030 ref_suffix = '%wip'
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001031 metrics_arguments.append('wip')
Aaron Gable844cf292017-06-28 11:32:59 -07001032 else:
1033 ref_suffix = '%notify=NONE'
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001034 metrics_arguments.append('notify=NONE')
Aaron Gable9b713dd2016-12-14 16:04:21 -08001035
Aaron Gable70f4e242017-06-26 10:45:59 -07001036 if title:
Aaron Gableafd52772017-06-27 16:40:10 -07001037 ref_suffix += ',m=' + title
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001038 metrics_arguments.append('m')
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001039
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00001040 calls += [
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +00001041 ((['git', 'config', 'rietveld.cc'],), ''),
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00001042 ]
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001043 if short_hostname == 'chromium':
1044 # All reviwers and ccs get into ref_suffix.
1045 for r in sorted(reviewers):
1046 ref_suffix += ',r=%s' % r
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001047 metrics_arguments.append('r')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001048 for c in sorted(['chromium-reviews+test-more-cc@chromium.org',
1049 'joe@example.com'] + cc):
1050 ref_suffix += ',cc=%s' % c
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001051 metrics_arguments.append('cc')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001052 reviewers, cc = [], []
1053 else:
1054 # TODO(crbug/877717): remove this case.
1055 calls += [
1056 (('ValidAccounts', '%s-review.googlesource.com' % short_hostname,
1057 sorted(reviewers) + ['joe@example.com',
1058 'chromium-reviews+test-more-cc@chromium.org'] + cc),
1059 {
1060 e: {'email': e}
1061 for e in (reviewers + ['joe@example.com'] + cc)
1062 })
1063 ]
1064 for r in sorted(reviewers):
1065 if r != 'bad-account-or-email':
1066 ref_suffix += ',r=%s' % r
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001067 metrics_arguments.append('r')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001068 reviewers.remove(r)
1069 for c in sorted(['joe@example.com'] + cc):
1070 ref_suffix += ',cc=%s' % c
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001071 metrics_arguments.append('cc')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001072 if c in cc:
1073 cc.remove(c)
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00001074
Edward Lemur687ca902018-12-05 02:30:30 +00001075 for k, v in sorted((labels or {}).items()):
1076 ref_suffix += ',l=%s+%d' % (k, v)
1077 metrics_arguments.append('l=%s+%d' % (k, v))
1078
1079 if tbr:
1080 calls += [
1081 (('GetCodeReviewTbrScore',
1082 '%s-review.googlesource.com' % short_hostname,
1083 'my/repo'),
1084 2,),
1085 ]
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001086
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001087 calls += [
1088 (('time.time',), 1000,),
1089 ((['git', 'push',
1090 'https://%s.googlesource.com/my/repo' % short_hostname,
1091 ref_to_push + ':refs/for/refs/heads/master' + ref_suffix],),
1092 (('remote:\n'
1093 'remote: Processing changes: (\)\n'
1094 'remote: Processing changes: (|)\n'
1095 'remote: Processing changes: (/)\n'
1096 'remote: Processing changes: (-)\n'
1097 'remote: Processing changes: new: 1 (/)\n'
1098 'remote: Processing changes: new: 1, done\n'
1099 'remote:\n'
1100 'remote: New Changes:\n'
1101 'remote: https://%s-review.googlesource.com/#/c/my/repo/+/123456'
1102 ' XXX\n'
1103 'remote:\n'
1104 'To https://%s.googlesource.com/my/repo\n'
1105 ' * [new branch] hhhh -> refs/for/refs/heads/master\n'
1106 ) % (short_hostname, short_hostname)),),
1107 (('time.time',), 2000,),
1108 (('add_repeated',
1109 'sub_commands',
1110 {
1111 'execution_time': 1000,
1112 'command': 'git push',
1113 'exit_code': 0,
1114 'arguments': sorted(metrics_arguments),
1115 }),
1116 None,),
1117 ]
1118
Edward Lemur1b52d872019-05-09 21:12:12 +00001119 final_description = final_description or post_amend_description.strip()
1120 original_title = original_title or title or '<untitled>'
1121 # Trace-related calls
1122 calls += [
1123 # Write a description with context for the current trace.
1124 ((['FileWrite', 'TRACES_DIR/20170316T200041.000000-README',
Edward Lemur75391d42019-05-14 23:35:56 +00001125 'Thu Mar 16 20:00:41 2017\n'
1126 '%(short_hostname)s-review.googlesource.com\n'
1127 '%(change_id)s\n'
1128 '%(title)s\n'
1129 '%(description)s\n'
1130 '1000\n'
1131 '0\n'
1132 '%(trace_name)s' % {
Edward Lemur1b52d872019-05-09 21:12:12 +00001133 'short_hostname': short_hostname,
1134 'change_id': change_id,
1135 'description': final_description,
1136 'title': original_title,
Edward Lemur75391d42019-05-14 23:35:56 +00001137 'trace_name': 'TRACES_DIR/20170316T200041.000000',
Edward Lemur1b52d872019-05-09 21:12:12 +00001138 }],),
1139 None,
1140 ),
1141 # Read traces and shorten git hashes.
1142 ((['os.path.isfile', 'TEMP_DIR/trace-packet'],),
1143 True,
1144 ),
1145 ((['FileRead', 'TEMP_DIR/trace-packet'],),
1146 ('git-hash: 0123456789012345678901234567890123456789\n'
1147 'git-hash: abcdeabcdeabcdeabcdeabcdeabcdeabcdeabcde\n'),
1148 ),
1149 ((['FileWrite', 'TEMP_DIR/trace-packet',
1150 'git-hash: 012345\n'
1151 'git-hash: abcdea\n'],),
1152 None,
1153 ),
1154 # Make zip file for the git traces.
1155 ((['make_archive', 'TRACES_DIR/20170316T200041.000000-traces', 'zip',
1156 'TEMP_DIR'],),
1157 None,
1158 ),
1159 # Collect git config and gitcookies.
1160 ((['git', 'config', '-l'],),
1161 'git-config-output',
1162 ),
1163 ((['FileWrite', 'TEMP_DIR/git-config', 'git-config-output'],),
1164 None,
1165 ),
1166 ((['os.path.isfile', '~/.gitcookies'],),
1167 gitcookies_exists,
1168 ),
1169 ]
1170 if gitcookies_exists:
1171 calls += [
1172 ((['FileRead', '~/.gitcookies'],),
1173 'gitcookies 1/SECRET',
1174 ),
1175 ((['FileWrite', 'TEMP_DIR/gitcookies', 'gitcookies REDACTED'],),
1176 None,
1177 ),
1178 ]
1179 calls += [
1180 # Make zip file for the git config and gitcookies.
1181 ((['make_archive', 'TRACES_DIR/20170316T200041.000000-git-info', 'zip',
1182 'TEMP_DIR'],),
1183 None,
1184 ),
1185 ]
1186
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001187 if squash:
1188 calls += [
tandrii33a46ff2016-08-23 05:53:40 -07001189 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
tandrii5d48c322016-08-18 16:19:37 -07001190 ''),
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001191 ((['git', 'config', 'branch.master.gerritserver',
tandrii5d48c322016-08-18 16:19:37 -07001192 'https://chromium-review.googlesource.com'],), ''),
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001193 ((['git', 'config', 'branch.master.gerritsquashhash',
1194 'abcdef0123456789'],), ''),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001195 ]
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001196 # TODO(crbug/877717): this should never be used.
1197 if squash and short_hostname != 'chromium':
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001198 calls += [
1199 (('AddReviewers',
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00001200 'chromium-review.googlesource.com', 'my%2Frepo~123456',
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001201 sorted(reviewers),
Andrii Shyshkalov2f727912018-10-15 17:02:33 +00001202 cc + ['chromium-reviews+test-more-cc@chromium.org'],
1203 notify),
1204 ''),
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001205 ]
tandrii@chromium.org1e67bb72016-02-11 12:15:49 +00001206 calls += cls._git_post_upload_calls()
ukai@chromium.orge8077812012-02-03 03:41:46 +00001207 return calls
1208
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001209 def _run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001210 self,
1211 upload_args,
1212 description,
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00001213 reviewers=None,
tandriia60502f2016-06-20 02:01:53 -07001214 squash=True,
1215 squash_mode=None,
tandrii@chromium.org10625002016-03-04 20:03:47 +00001216 expected_upstream_ref='origin/refs/heads/master',
Aaron Gable9b713dd2016-12-14 16:04:21 -08001217 title=None,
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001218 notify=False,
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001219 post_amend_description=None,
bradnelsond975b302016-10-23 12:20:23 -07001220 issue=None,
Andrii Shyshkalove9c78ff2017-02-06 15:53:13 +01001221 cc=None,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001222 fetched_status=None,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001223 other_cl_owner=None,
Aaron Gablefd238082017-06-07 13:42:34 -07001224 custom_cl_base=None,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001225 tbr=None,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001226 short_hostname='chromium',
Edward Lemur1b52d872019-05-09 21:12:12 +00001227 labels=None,
1228 change_id=None,
1229 original_title=None,
1230 final_description=None,
1231 gitcookies_exists=True):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001232 """Generic gerrit upload test framework."""
tandriia60502f2016-06-20 02:01:53 -07001233 if squash_mode is None:
1234 if '--no-squash' in upload_args:
1235 squash_mode = 'nosquash'
1236 elif '--squash' in upload_args:
1237 squash_mode = 'squash'
1238 else:
1239 squash_mode = 'default'
1240
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00001241 reviewers = reviewers or []
bradnelsond975b302016-10-23 12:20:23 -07001242 cc = cc or []
tandrii@chromium.org28253532016-04-14 13:46:56 +00001243 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
tandrii16e0b4e2016-06-07 10:34:28 -07001244 self.mock(git_cl.gerrit_util, 'CookiesAuthenticator',
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001245 CookiesAuthenticatorMockFactory(
1246 same_auth=('git-owner.example.com', '', 'pass')))
Edward Lemur125d60a2019-09-13 18:25:41 +00001247 self.mock(git_cl.Changelist, '_GerritCommitMsgHookCheck',
tandrii16e0b4e2016-06-07 10:34:28 -07001248 lambda _, offer_removal: None)
tandriia60502f2016-06-20 02:01:53 -07001249 self.mock(git_cl.gclient_utils, 'RunEditor',
1250 lambda *_, **__: self._mocked_call(['RunEditor']))
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001251 self.mock(git_cl, 'DownloadGerritHook', lambda force: self._mocked_call(
1252 'DownloadGerritHook', force))
Edward Lemur1b52d872019-05-09 21:12:12 +00001253 self.mock(git_cl.gclient_utils, 'FileRead',
1254 lambda path: self._mocked_call(['FileRead', path]))
1255 self.mock(git_cl.gclient_utils, 'FileWrite',
1256 lambda path, contents: self._mocked_call(
1257 ['FileWrite', path, contents]))
1258 self.mock(git_cl, 'datetime_now',
1259 lambda: datetime.datetime(2017, 3, 16, 20, 0, 41, 0))
1260 self.mock(git_cl.tempfile, 'mkdtemp', lambda: 'TEMP_DIR')
1261 self.mock(git_cl, 'TRACES_DIR', 'TRACES_DIR')
Edward Lemur75391d42019-05-14 23:35:56 +00001262 self.mock(git_cl, 'TRACES_README_FORMAT',
1263 '%(now)s\n'
1264 '%(gerrit_host)s\n'
1265 '%(change_id)s\n'
1266 '%(title)s\n'
1267 '%(description)s\n'
1268 '%(execution_time)s\n'
1269 '%(exit_code)s\n'
1270 '%(trace_name)s')
Edward Lemur1b52d872019-05-09 21:12:12 +00001271 self.mock(git_cl.shutil, 'make_archive',
1272 lambda *args: self._mocked_call(['make_archive'] + list(args)))
1273 self.mock(os.path, 'isfile',
1274 lambda path: self._mocked_call(['os.path.isfile', path]))
tandriia60502f2016-06-20 02:01:53 -07001275
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001276 self.calls = self._gerrit_base_calls(
1277 issue=issue,
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001278 fetched_description=description,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001279 fetched_status=fetched_status,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001280 other_cl_owner=other_cl_owner,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001281 custom_cl_base=custom_cl_base,
1282 short_hostname=short_hostname)
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001283 if fetched_status != 'ABANDONED':
Aaron Gable9a03ae02017-11-03 11:31:07 -07001284 self.mock(tempfile, 'NamedTemporaryFile', MakeNamedTemporaryFileMock(
1285 expected_content=description))
1286 self.mock(os, 'remove', lambda _: True)
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001287 self.calls += self._gerrit_upload_calls(
1288 description, reviewers, squash,
1289 squash_mode=squash_mode,
1290 expected_upstream_ref=expected_upstream_ref,
Aaron Gablefd238082017-06-07 13:42:34 -07001291 title=title, notify=notify,
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001292 post_amend_description=post_amend_description,
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00001293 issue=issue, cc=cc,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001294 custom_cl_base=custom_cl_base, tbr=tbr,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001295 short_hostname=short_hostname,
Edward Lemur1b52d872019-05-09 21:12:12 +00001296 labels=labels,
1297 change_id=change_id,
1298 original_title=original_title,
1299 final_description=final_description,
1300 gitcookies_exists=gitcookies_exists)
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +00001301 # Uncomment when debugging.
Raul Tambre80ee78e2019-05-06 22:41:05 +00001302 # print('\n'.join(map(lambda x: '%2i: %s' % x, enumerate(self.calls))))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001303 git_cl.main(['upload'] + upload_args)
1304
Edward Lemur1b52d872019-05-09 21:12:12 +00001305 def test_gerrit_upload_traces_no_gitcookies(self):
1306 self._run_gerrit_upload_test(
1307 ['--no-squash'],
1308 'desc\n\nBUG=\n',
1309 [],
1310 squash=False,
1311 post_amend_description='desc\n\nBUG=\n\nChange-Id: Ixxx',
1312 change_id='Ixxx',
1313 gitcookies_exists=False)
1314
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001315 def test_gerrit_upload_without_change_id(self):
tandriia60502f2016-06-20 02:01:53 -07001316 self._run_gerrit_upload_test(
1317 ['--no-squash'],
1318 'desc\n\nBUG=\n',
1319 [],
1320 squash=False,
Edward Lemur1b52d872019-05-09 21:12:12 +00001321 post_amend_description='desc\n\nBUG=\n\nChange-Id: Ixxx',
1322 change_id='Ixxx')
tandriia60502f2016-06-20 02:01:53 -07001323
1324 def test_gerrit_upload_without_change_id_override_nosquash(self):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001325 self._run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001326 [],
jamesr@chromium.org35d1a842012-07-27 00:20:43 +00001327 'desc\n\nBUG=\n',
tandrii@chromium.org10625002016-03-04 20:03:47 +00001328 [],
tandriia60502f2016-06-20 02:01:53 -07001329 squash=False,
1330 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001331 post_amend_description='desc\n\nBUG=\n\nChange-Id: Ixxx',
1332 change_id='Ixxx')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001333
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001334 def test_gerrit_no_reviewer(self):
1335 self._run_gerrit_upload_test(
1336 [],
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +00001337 'desc\n\nBUG=\n\nChange-Id: I123456789\n',
tandriia60502f2016-06-20 02:01:53 -07001338 [],
1339 squash=False,
Edward Lemur1b52d872019-05-09 21:12:12 +00001340 squash_mode='override_nosquash',
1341 change_id='I123456789')
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001342
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001343 def test_gerrit_no_reviewer_non_chromium_host(self):
1344 # TODO(crbug/877717): remove this test case.
1345 self._run_gerrit_upload_test(
1346 [],
1347 'desc\n\nBUG=\n\nChange-Id: I123456789\n',
1348 [],
1349 squash=False,
1350 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001351 short_hostname='other',
1352 change_id='I123456789')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001353
Nick Carter8692b182017-11-06 16:30:38 -08001354 def test_gerrit_patchset_title_special_chars(self):
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001355 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
1356 self._run_gerrit_upload_test(
Nick Carter8692b182017-11-06 16:30:38 -08001357 ['-f', '-t', 'We\'ll escape ^_ ^ special chars...@{u}'],
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001358 'desc\n\nBUG=\n\nChange-Id: I123456789',
1359 squash=False,
1360 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001361 title='We%27ll_escape_%5E%5F_%5E_special_chars%2E%2E%2E%40%7Bu%7D',
1362 change_id='I123456789',
1363 original_title='We\'ll escape ^_ ^ special chars...@{u}')
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001364
ukai@chromium.orge8077812012-02-03 03:41:46 +00001365 def test_gerrit_reviewers_cmd_line(self):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001366 self._run_gerrit_upload_test(
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001367 ['-r', 'foo@example.com', '--send-mail'],
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +00001368 'desc\n\nBUG=\n\nChange-Id: I123456789',
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001369 ['foo@example.com'],
tandriia60502f2016-06-20 02:01:53 -07001370 squash=False,
1371 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001372 notify=True,
1373 change_id='I123456789',
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001374 final_description=(
1375 'desc\n\nBUG=\nR=foo@example.com\n\nChange-Id: I123456789'))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001376
1377 def test_gerrit_reviewer_multiple(self):
Edward Lemur687ca902018-12-05 02:30:30 +00001378 self.mock(git_cl.gerrit_util, 'GetCodeReviewTbrScore',
1379 lambda *a: self._mocked_call('GetCodeReviewTbrScore', *a))
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001380 self._run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001381 [],
bradnelsond975b302016-10-23 12:20:23 -07001382 'desc\nTBR=reviewer@example.com\nBUG=\nR=another@example.com\n'
1383 'CC=more@example.com,people@example.com\n\n'
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +09001384 'Change-Id: 123456789',
tandriia60502f2016-06-20 02:01:53 -07001385 ['reviewer@example.com', 'another@example.com'],
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +09001386 expected_upstream_ref='origin/master',
Aaron Gablefd238082017-06-07 13:42:34 -07001387 cc=['more@example.com', 'people@example.com'],
Edward Lemur687ca902018-12-05 02:30:30 +00001388 tbr='reviewer@example.com',
Edward Lemur1b52d872019-05-09 21:12:12 +00001389 labels={'Code-Review': 2},
1390 change_id='123456789',
1391 original_title='Initial upload')
tandriia60502f2016-06-20 02:01:53 -07001392
1393 def test_gerrit_upload_squash_first_is_default(self):
tandriia60502f2016-06-20 02:01:53 -07001394 self._run_gerrit_upload_test(
1395 [],
1396 'desc\nBUG=\n\nChange-Id: 123456789',
1397 [],
Edward Lemur1b52d872019-05-09 21:12:12 +00001398 expected_upstream_ref='origin/master',
1399 change_id='123456789',
1400 original_title='Initial upload')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001401
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001402 def test_gerrit_upload_squash_first(self):
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001403 self._run_gerrit_upload_test(
1404 ['--squash'],
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001405 'desc\nBUG=\n\nChange-Id: 123456789',
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001406 [],
luqui@chromium.org609f3952015-05-04 22:47:04 +00001407 squash=True,
Edward Lemur1b52d872019-05-09 21:12:12 +00001408 expected_upstream_ref='origin/master',
1409 change_id='123456789',
1410 original_title='Initial upload')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001411
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001412 def test_gerrit_upload_squash_first_with_labels(self):
1413 self._run_gerrit_upload_test(
1414 ['--squash', '--cq-dry-run', '--enable-auto-submit'],
1415 'desc\nBUG=\n\nChange-Id: 123456789',
1416 [],
1417 squash=True,
1418 expected_upstream_ref='origin/master',
Edward Lemur1b52d872019-05-09 21:12:12 +00001419 labels={'Commit-Queue': 1, 'Auto-Submit': 1},
1420 change_id='123456789',
1421 original_title='Initial upload')
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001422
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001423 def test_gerrit_upload_squash_first_against_rev(self):
1424 custom_cl_base = 'custom_cl_base_rev_or_branch'
1425 self._run_gerrit_upload_test(
1426 ['--squash', custom_cl_base],
1427 'desc\nBUG=\n\nChange-Id: 123456789',
1428 [],
1429 squash=True,
1430 expected_upstream_ref='origin/master',
Edward Lemur1b52d872019-05-09 21:12:12 +00001431 custom_cl_base=custom_cl_base,
1432 change_id='123456789',
1433 original_title='Initial upload')
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001434 self.assertIn(
1435 'If you proceed with upload, more than 1 CL may be created by Gerrit',
1436 sys.stdout.getvalue())
1437
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001438 def test_gerrit_upload_squash_reupload(self):
1439 description = 'desc\nBUG=\n\nChange-Id: 123456789'
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001440 self._run_gerrit_upload_test(
1441 ['--squash'],
1442 description,
1443 [],
1444 squash=True,
1445 expected_upstream_ref='origin/master',
Edward Lemur1b52d872019-05-09 21:12:12 +00001446 issue=123456,
1447 change_id='123456789',
1448 original_title='User input')
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001449
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001450 def test_gerrit_upload_squash_reupload_to_abandoned(self):
1451 self.mock(git_cl, 'DieWithError',
1452 lambda msg, change=None: self._mocked_call('DieWithError', msg))
1453 description = 'desc\nBUG=\n\nChange-Id: 123456789'
1454 with self.assertRaises(SystemExitMock):
1455 self._run_gerrit_upload_test(
1456 ['--squash'],
1457 description,
1458 [],
1459 squash=True,
1460 expected_upstream_ref='origin/master',
1461 issue=123456,
Edward Lemur1b52d872019-05-09 21:12:12 +00001462 fetched_status='ABANDONED',
1463 change_id='123456789')
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001464
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001465 def test_gerrit_upload_squash_reupload_to_not_owned(self):
1466 self.mock(git_cl.gerrit_util, 'GetAccountDetails',
1467 lambda *_, **__: {'email': 'yet-another@example.com'})
1468 description = 'desc\nBUG=\n\nChange-Id: 123456789'
1469 self._run_gerrit_upload_test(
1470 ['--squash'],
1471 description,
1472 [],
1473 squash=True,
1474 expected_upstream_ref='origin/master',
1475 issue=123456,
Edward Lemur1b52d872019-05-09 21:12:12 +00001476 other_cl_owner='other@example.com',
1477 change_id='123456789',
1478 original_title='User input')
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001479 self.assertIn(
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001480 'WARNING: Change 123456 is owned by other@example.com, but you '
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001481 'authenticate to Gerrit as yet-another@example.com.\n'
1482 'Uploading may fail due to lack of permissions',
1483 git_cl.sys.stdout.getvalue())
1484
rmistry@google.com2dd99862015-06-22 12:22:18 +00001485 def test_upload_branch_deps(self):
tandrii@chromium.org28253532016-04-14 13:46:56 +00001486 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
rmistry@google.com2dd99862015-06-22 12:22:18 +00001487 def mock_run_git(*args, **_kwargs):
1488 if args[0] == ['for-each-ref',
1489 '--format=%(refname:short) %(upstream:short)',
1490 'refs/heads']:
1491 # Create a local branch dependency tree that looks like this:
1492 # test1 -> test2 -> test3 -> test4 -> test5
1493 # -> test3.1
1494 # test6 -> test0
1495 branch_deps = [
1496 'test2 test1', # test1 -> test2
1497 'test3 test2', # test2 -> test3
1498 'test3.1 test2', # test2 -> test3.1
1499 'test4 test3', # test3 -> test4
1500 'test5 test4', # test4 -> test5
1501 'test6 test0', # test0 -> test6
1502 'test7', # test7
1503 ]
1504 return '\n'.join(branch_deps)
1505 self.mock(git_cl, 'RunGit', mock_run_git)
1506
1507 class RecordCalls:
1508 times_called = 0
1509 record_calls = RecordCalls()
1510 def mock_CMDupload(*args, **_kwargs):
1511 record_calls.times_called += 1
1512 return 0
1513 self.mock(git_cl, 'CMDupload', mock_CMDupload)
1514
1515 self.calls = [
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01001516 (('ask_for_data', 'This command will checkout all dependent branches '
1517 'and run "git cl upload". Press Enter to continue, '
1518 'or Ctrl+C to abort'), ''),
1519 ]
rmistry@google.com2dd99862015-06-22 12:22:18 +00001520
1521 class MockChangelist():
1522 def __init__(self):
1523 pass
1524 def GetBranch(self):
1525 return 'test1'
1526 def GetIssue(self):
1527 return '123'
1528 def GetPatchset(self):
1529 return '1001'
tandrii@chromium.org4c72b082016-03-31 22:26:35 +00001530 def IsGerrit(self):
1531 return False
rmistry@google.com2dd99862015-06-22 12:22:18 +00001532
1533 ret = git_cl.upload_branch_deps(MockChangelist(), [])
1534 # CMDupload should have been called 5 times because of 5 dependent branches.
1535 self.assertEquals(5, record_calls.times_called)
1536 self.assertEquals(0, ret)
1537
tandrii@chromium.org65874e12016-03-04 12:03:02 +00001538 def test_gerrit_change_id(self):
1539 self.calls = [
1540 ((['git', 'write-tree'], ),
1541 'hashtree'),
1542 ((['git', 'rev-parse', 'HEAD~0'], ),
1543 'branch-parent'),
1544 ((['git', 'var', 'GIT_AUTHOR_IDENT'], ),
1545 'A B <a@b.org> 1456848326 +0100'),
1546 ((['git', 'var', 'GIT_COMMITTER_IDENT'], ),
1547 'C D <c@d.org> 1456858326 +0100'),
1548 ((['git', 'hash-object', '-t', 'commit', '--stdin'], ),
1549 'hashchange'),
1550 ]
1551 change_id = git_cl.GenerateGerritChangeId('line1\nline2\n')
1552 self.assertEqual(change_id, 'Ihashchange')
1553
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00001554 def test_desecription_append_footer(self):
1555 for init_desc, footer_line, expected_desc in [
1556 # Use unique desc first lines for easy test failure identification.
1557 ('foo', 'R=one', 'foo\n\nR=one'),
1558 ('foo\n\nR=one', 'BUG=', 'foo\n\nR=one\nBUG='),
1559 ('foo\n\nR=one', 'Change-Id: Ixx', 'foo\n\nR=one\n\nChange-Id: Ixx'),
1560 ('foo\n\nChange-Id: Ixx', 'R=one', 'foo\n\nR=one\n\nChange-Id: Ixx'),
1561 ('foo\n\nR=one\n\nChange-Id: Ixx', 'TBR=two',
1562 'foo\n\nR=one\nTBR=two\n\nChange-Id: Ixx'),
1563 ('foo\n\nR=one\n\nChange-Id: Ixx', 'Foo-Bar: baz',
1564 'foo\n\nR=one\n\nChange-Id: Ixx\nFoo-Bar: baz'),
1565 ('foo\n\nChange-Id: Ixx', 'Foo-Bak: baz',
1566 'foo\n\nChange-Id: Ixx\nFoo-Bak: baz'),
1567 ('foo', 'Change-Id: Ixx', 'foo\n\nChange-Id: Ixx'),
1568 ]:
1569 desc = git_cl.ChangeDescription(init_desc)
1570 desc.append_footer(footer_line)
1571 self.assertEqual(desc.description, expected_desc)
1572
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001573 def test_update_reviewers(self):
1574 data = [
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001575 ('foo', [], [],
1576 'foo'),
1577 ('foo\nR=xx', [], [],
1578 'foo\nR=xx'),
1579 ('foo\nTBR=xx', [], [],
1580 'foo\nTBR=xx'),
1581 ('foo', ['a@c'], [],
1582 'foo\n\nR=a@c'),
1583 ('foo\nR=xx', ['a@c'], [],
1584 'foo\n\nR=a@c, xx'),
1585 ('foo\nTBR=xx', ['a@c'], [],
1586 'foo\n\nR=a@c\nTBR=xx'),
1587 ('foo\nTBR=xx\nR=yy', ['a@c'], [],
1588 'foo\n\nR=a@c, yy\nTBR=xx'),
1589 ('foo\nBUG=', ['a@c'], [],
1590 'foo\nBUG=\nR=a@c'),
1591 ('foo\nR=xx\nTBR=yy\nR=bar', ['a@c'], [],
1592 'foo\n\nR=a@c, bar, xx\nTBR=yy'),
1593 ('foo', ['a@c', 'b@c'], [],
1594 'foo\n\nR=a@c, b@c'),
1595 ('foo\nBar\n\nR=\nBUG=', ['c@c'], [],
1596 'foo\nBar\n\nR=c@c\nBUG='),
1597 ('foo\nBar\n\nR=\nBUG=\nR=', ['c@c'], [],
1598 'foo\nBar\n\nR=c@c\nBUG='),
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001599 # Same as the line before, but full of whitespaces.
1600 (
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001601 'foo\nBar\n\n R = \n BUG = \n R = ', ['c@c'], [],
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001602 'foo\nBar\n\nR=c@c\n BUG =',
1603 ),
1604 # Whitespaces aren't interpreted as new lines.
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001605 ('foo BUG=allo R=joe ', ['c@c'], [],
1606 'foo BUG=allo R=joe\n\nR=c@c'),
1607 # Redundant TBRs get promoted to Rs
1608 ('foo\n\nR=a@c\nTBR=t@c', ['b@c', 'a@c'], ['a@c', 't@c'],
1609 'foo\n\nR=a@c, b@c\nTBR=t@c'),
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001610 ]
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001611 expected = [i[-1] for i in data]
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001612 actual = []
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001613 for orig, reviewers, tbrs, _expected in data:
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001614 obj = git_cl.ChangeDescription(orig)
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001615 obj.update_reviewers(reviewers, tbrs)
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001616 actual.append(obj.description)
1617 self.assertEqual(expected, actual)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001618
Nodir Turakulov23b82142017-11-16 11:04:25 -08001619 def test_get_hash_tags(self):
1620 cases = [
1621 ('', []),
1622 ('a', []),
1623 ('[a]', ['a']),
1624 ('[aa]', ['aa']),
1625 ('[a ]', ['a']),
1626 ('[a- ]', ['a']),
1627 ('[a- b]', ['a-b']),
1628 ('[a--b]', ['a-b']),
1629 ('[a', []),
1630 ('[a]x', ['a']),
1631 ('[aa]x', ['aa']),
1632 ('[a b]', ['a-b']),
1633 ('[a b]', ['a-b']),
1634 ('[a__b]', ['a-b']),
1635 ('[a] x', ['a']),
1636 ('[a][b]', ['a', 'b']),
1637 ('[a] [b]', ['a', 'b']),
1638 ('[a][b]x', ['a', 'b']),
1639 ('[a][b] x', ['a', 'b']),
1640 ('[a]\n[b]', ['a']),
1641 ('[a\nb]', []),
1642 ('[a][', ['a']),
1643 ('Revert "[a] feature"', ['a']),
1644 ('Reland "[a] feature"', ['a']),
1645 ('Revert: [a] feature', ['a']),
1646 ('Reland: [a] feature', ['a']),
1647 ('Revert "Reland: [a] feature"', ['a']),
1648 ('Foo: feature', ['foo']),
1649 ('Foo Bar: feature', ['foo-bar']),
1650 ('Revert "Foo bar: feature"', ['foo-bar']),
1651 ('Reland "Foo bar: feature"', ['foo-bar']),
1652 ]
1653 for desc, expected in cases:
1654 change_desc = git_cl.ChangeDescription(desc)
1655 actual = change_desc.get_hash_tags()
1656 self.assertEqual(
1657 actual,
1658 expected,
1659 'GetHashTags(%r) == %r, expected %r' % (desc, actual, expected))
1660
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001661 self.assertEqual(None, git_cl.GetTargetRef('origin', None, 'master'))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001662 self.assertEqual(None, git_cl.GetTargetRef(None,
1663 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001664 'master'))
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001665
wittman@chromium.org455dc922015-01-26 20:15:50 +00001666 # Check default target refs for branches.
1667 self.assertEqual('refs/heads/master',
1668 git_cl.GetTargetRef('origin', 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001669 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001670 self.assertEqual('refs/heads/master',
1671 git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkgr',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001672 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001673 self.assertEqual('refs/heads/master',
1674 git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkcr',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001675 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001676 self.assertEqual('refs/branch-heads/123',
1677 git_cl.GetTargetRef('origin',
1678 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001679 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001680 self.assertEqual('refs/diff/test',
1681 git_cl.GetTargetRef('origin',
1682 'refs/remotes/origin/refs/diff/test',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001683 None))
rmistry@google.comc68112d2015-03-03 12:48:06 +00001684 self.assertEqual('refs/heads/chrome/m42',
1685 git_cl.GetTargetRef('origin',
1686 'refs/remotes/origin/chrome/m42',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001687 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001688
1689 # Check target refs for user-specified target branch.
1690 for branch in ('branch-heads/123', 'remotes/branch-heads/123',
1691 'refs/remotes/branch-heads/123'):
1692 self.assertEqual('refs/branch-heads/123',
1693 git_cl.GetTargetRef('origin',
1694 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001695 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001696 for branch in ('origin/master', 'remotes/origin/master',
1697 'refs/remotes/origin/master'):
1698 self.assertEqual('refs/heads/master',
1699 git_cl.GetTargetRef('origin',
1700 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001701 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001702 for branch in ('master', 'heads/master', 'refs/heads/master'):
1703 self.assertEqual('refs/heads/master',
1704 git_cl.GetTargetRef('origin',
1705 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001706 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001707
wychen@chromium.orga872e752015-04-28 23:42:18 +00001708 def test_patch_when_dirty(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001709 # Patch when local tree is dirty.
wychen@chromium.orga872e752015-04-28 23:42:18 +00001710 self.mock(git_common, 'is_dirty_git_tree', lambda x: True)
1711 self.assertNotEqual(git_cl.main(['patch', '123456']), 0)
1712
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001713 @staticmethod
1714 def _get_gerrit_codereview_server_calls(branch, value=None,
1715 git_short_host='host',
Aaron Gable697a91b2018-01-19 15:20:15 -08001716 detect_branch=True,
1717 detect_server=True):
Edward Lemur125d60a2019-09-13 18:25:41 +00001718 """Returns calls executed by Changelist.GetCodereviewServer.
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001719
1720 If value is given, branch.<BRANCH>.gerritcodereview is already set.
1721 """
1722 calls = []
1723 if detect_branch:
1724 calls.append(((['git', 'symbolic-ref', 'HEAD'],), branch))
Aaron Gable697a91b2018-01-19 15:20:15 -08001725 if detect_server:
1726 calls.append(((['git', 'config', 'branch.' + branch + '.gerritserver'],),
1727 CERR1 if value is None else value))
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001728 if value is None:
1729 calls += [
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001730 ((['git', 'config', 'branch.' + branch + '.merge'],),
1731 'refs/heads' + branch),
1732 ((['git', 'config', 'branch.' + branch + '.remote'],),
1733 'origin'),
1734 ((['git', 'config', 'remote.origin.url'],),
1735 'https://%s.googlesource.com/my/repo' % git_short_host),
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001736 ]
1737 return calls
1738
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001739 def _patch_common(self, force_codereview=False,
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001740 new_branch=False, git_short_host='host',
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001741 detect_gerrit_server=False,
1742 actual_codereview=None,
1743 codereview_in_url=False):
tandrii@chromium.org28253532016-04-14 13:46:56 +00001744 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
wychen@chromium.orga872e752015-04-28 23:42:18 +00001745 self.mock(git_cl, 'IsGitVersionAtLeast', lambda *args: True)
1746
tandriidf09a462016-08-18 16:23:55 -07001747 if new_branch:
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001748 self.calls = [((['git', 'new-branch', 'master'],), '')]
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001749
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001750 if codereview_in_url and actual_codereview == 'rietveld':
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001751 self.calls += [
1752 ((['git', 'rev-parse', '--show-cdup'],), ''),
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001753 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001754 ]
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001755
1756 if not force_codereview and not codereview_in_url:
1757 # These calls detect codereview to use.
1758 self.calls += [
1759 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001760 ]
1761 if detect_gerrit_server:
1762 self.calls += self._get_gerrit_codereview_server_calls(
1763 'master', git_short_host=git_short_host,
1764 detect_branch=not new_branch and force_codereview)
1765 actual_codereview = 'gerrit'
1766
1767 if actual_codereview == 'gerrit':
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001768 self.calls += [
1769 (('GetChangeDetail', git_short_host + '-review.googlesource.com',
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001770 'my%2Frepo~123456', ['ALL_REVISIONS', 'CURRENT_COMMIT']),
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001771 {
1772 'current_revision': '7777777777',
1773 'revisions': {
1774 '1111111111': {
1775 '_number': 1,
1776 'fetch': {'http': {
1777 'url': 'https://%s.googlesource.com/my/repo' % git_short_host,
1778 'ref': 'refs/changes/56/123456/1',
1779 }},
1780 },
1781 '7777777777': {
1782 '_number': 7,
1783 'fetch': {'http': {
1784 'url': 'https://%s.googlesource.com/my/repo' % git_short_host,
1785 'ref': 'refs/changes/56/123456/7',
1786 }},
1787 },
1788 },
1789 }),
1790 ]
wychen@chromium.orga872e752015-04-28 23:42:18 +00001791
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001792 def test_patch_gerrit_default(self):
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001793 self._patch_common(git_short_host='chromium', detect_gerrit_server=True)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001794 self.calls += [
1795 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
1796 'refs/changes/56/123456/7'],), ''),
Aaron Gable62619a32017-06-16 08:22:09 -07001797 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001798 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
Aaron Gable697a91b2018-01-19 15:20:15 -08001799 ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001800 ((['git', 'config', 'branch.master.gerritserver',
1801 'https://chromium-review.googlesource.com'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001802 ((['git', 'config', 'branch.master.gerritpatchset', '7'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001803 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1804 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1805 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001806 ]
1807 self.assertEqual(git_cl.main(['patch', '123456']), 0)
1808
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001809 def test_patch_gerrit_new_branch(self):
1810 self._patch_common(
1811 git_short_host='chromium', detect_gerrit_server=True, new_branch=True)
1812 self.calls += [
1813 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
1814 'refs/changes/56/123456/7'],), ''),
1815 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
1816 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
1817 ''),
1818 ((['git', 'config', 'branch.master.gerritserver',
1819 'https://chromium-review.googlesource.com'],), ''),
1820 ((['git', 'config', 'branch.master.gerritpatchset', '7'],), ''),
1821 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1822 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1823 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
1824 ]
1825 self.assertEqual(git_cl.main(['patch', '-b', 'master', '123456']), 0)
1826
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001827 def test_patch_gerrit_force(self):
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001828 self._patch_common(
1829 force_codereview=True, git_short_host='host', detect_gerrit_server=True)
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001830 self.calls += [
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001831 ((['git', 'fetch', 'https://host.googlesource.com/my/repo',
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001832 'refs/changes/56/123456/7'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001833 ((['git', 'reset', '--hard', 'FETCH_HEAD'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001834 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
tandrii5d48c322016-08-18 16:19:37 -07001835 ''),
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001836 ((['git', 'config', 'branch.master.gerritserver',
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001837 'https://host-review.googlesource.com'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001838 ((['git', 'config', 'branch.master.gerritpatchset', '7'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001839 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1840 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1841 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001842 ]
Aaron Gable62619a32017-06-16 08:22:09 -07001843 self.assertEqual(git_cl.main(['patch', '--gerrit', '123456', '--force']), 0)
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001844
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001845 def test_patch_gerrit_guess_by_url(self):
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001846 self.calls += self._get_gerrit_codereview_server_calls(
1847 'master', git_short_host='else', detect_server=False)
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001848 self._patch_common(
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001849 actual_codereview='gerrit', git_short_host='else',
1850 codereview_in_url=True, detect_gerrit_server=False)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001851 self.calls += [
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001852 ((['git', 'fetch', 'https://else.googlesource.com/my/repo',
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001853 'refs/changes/56/123456/1'],), ''),
Aaron Gable62619a32017-06-16 08:22:09 -07001854 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001855 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
tandrii5d48c322016-08-18 16:19:37 -07001856 ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001857 ((['git', 'config', 'branch.master.gerritserver',
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001858 'https://else-review.googlesource.com'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001859 ((['git', 'config', 'branch.master.gerritpatchset', '1'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001860 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1861 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1862 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001863 ]
1864 self.assertEqual(git_cl.main(
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001865 ['patch', 'https://else-review.googlesource.com/#/c/123456/1']), 0)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001866
Aaron Gable697a91b2018-01-19 15:20:15 -08001867 def test_patch_gerrit_guess_by_url_with_repo(self):
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001868 self.calls += self._get_gerrit_codereview_server_calls(
1869 'master', git_short_host='else', detect_server=False)
Aaron Gable697a91b2018-01-19 15:20:15 -08001870 self._patch_common(
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001871 actual_codereview='gerrit', git_short_host='else',
1872 codereview_in_url=True, detect_gerrit_server=False)
Aaron Gable697a91b2018-01-19 15:20:15 -08001873 self.calls += [
1874 ((['git', 'fetch', 'https://else.googlesource.com/my/repo',
1875 'refs/changes/56/123456/1'],), ''),
1876 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
1877 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
1878 ''),
1879 ((['git', 'config', 'branch.master.gerritserver',
1880 'https://else-review.googlesource.com'],), ''),
1881 ((['git', 'config', 'branch.master.gerritpatchset', '1'],), ''),
1882 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1883 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1884 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
1885 ]
1886 self.assertEqual(git_cl.main(
1887 ['patch', 'https://else-review.googlesource.com/c/my/repo/+/123456/1']),
1888 0)
1889
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001890 def test_patch_gerrit_conflict(self):
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001891 self._patch_common(detect_gerrit_server=True, git_short_host='chromium')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001892 self.calls += [
1893 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001894 'refs/changes/56/123456/7'],), ''),
tandrii5d48c322016-08-18 16:19:37 -07001895 ((['git', 'cherry-pick', 'FETCH_HEAD'],), CERR1),
1896 ((['DieWithError', 'Command "git cherry-pick FETCH_HEAD" failed.\n'],),
1897 SystemExitMock()),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001898 ]
1899 with self.assertRaises(SystemExitMock):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001900 git_cl.main(['patch', '123456'])
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001901
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001902 def test_patch_gerrit_not_exists(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001903
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01001904 def notExists(_issue, *_, **kwargs):
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01001905 raise git_cl.gerrit_util.GerritError(404, '')
1906 self.mock(git_cl.gerrit_util, 'GetChangeDetail', notExists)
1907
tandriic2405f52016-10-10 08:13:15 -07001908 self.calls = [
1909 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001910 ((['git', 'config', 'branch.master.gerritserver'],), CERR1),
1911 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
1912 ((['git', 'config', 'branch.master.remote'],), 'origin'),
1913 ((['git', 'config', 'remote.origin.url'],),
1914 'https://chromium.googlesource.com/my/repo'),
1915 ((['DieWithError',
1916 'change 123456 at https://chromium-review.googlesource.com does not '
1917 'exist or you have no access to it'],), SystemExitMock()),
tandriic2405f52016-10-10 08:13:15 -07001918 ]
1919 with self.assertRaises(SystemExitMock):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001920 self.assertEqual(1, git_cl.main(['patch', '123456']))
tandriic2405f52016-10-10 08:13:15 -07001921
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001922 def _checkout_calls(self):
1923 return [
1924 ((['git', 'config', '--local', '--get-regexp',
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001925 'branch\\..*\\.gerritissue'], ),
1926 ('branch.ger-branch.gerritissue 123456\n'
1927 'branch.gbranch654.gerritissue 654321\n')),
1928 ]
1929
1930 def test_checkout_gerrit(self):
1931 """Tests git cl checkout <issue>."""
1932 self.calls = self._checkout_calls()
1933 self.calls += [((['git', 'checkout', 'ger-branch'], ), '')]
1934 self.assertEqual(0, git_cl.main(['checkout', '123456']))
1935
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001936 def test_checkout_not_found(self):
1937 """Tests git cl checkout <issue>."""
tandrii@chromium.org28253532016-04-14 13:46:56 +00001938 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001939 self.calls = self._checkout_calls()
1940 self.assertEqual(1, git_cl.main(['checkout', '99999']))
1941
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001942 def test_checkout_no_branch_issues(self):
1943 """Tests git cl checkout <issue>."""
tandrii@chromium.org28253532016-04-14 13:46:56 +00001944 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001945 self.calls = [
1946 ((['git', 'config', '--local', '--get-regexp',
tandrii5d48c322016-08-18 16:19:37 -07001947 'branch\\..*\\.gerritissue'], ), CERR1),
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001948 ]
1949 self.assertEqual(1, git_cl.main(['checkout', '99999']))
1950
tandrii@chromium.org28253532016-04-14 13:46:56 +00001951 def _test_gerrit_ensure_authenticated_common(self, auth,
1952 skip_auth_check=False):
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001953 self.mock(git_cl.gerrit_util, 'CookiesAuthenticator',
1954 CookiesAuthenticatorMockFactory(hosts_with_creds=auth))
1955 self.mock(git_cl, 'DieWithError',
Christopher Lamf732cd52017-01-24 12:40:11 +11001956 lambda msg, change=None: self._mocked_call(['DieWithError', msg]))
tandrii@chromium.org28253532016-04-14 13:46:56 +00001957 self.calls = self._gerrit_ensure_auth_calls(skip_auth_check=skip_auth_check)
Edward Lemurf38bc172019-09-03 21:02:13 +00001958 cl = git_cl.Changelist()
tandrii@chromium.org28253532016-04-14 13:46:56 +00001959 cl.branch = 'master'
1960 cl.branchref = 'refs/heads/master'
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001961 return cl
1962
1963 def test_gerrit_ensure_authenticated_missing(self):
1964 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001965 'chromium.googlesource.com': ('git-is.ok', '', 'but gerrit is missing'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001966 })
1967 self.calls.append(
1968 ((['DieWithError',
1969 'Credentials for the following hosts are required:\n'
1970 ' chromium-review.googlesource.com\n'
1971 'These are read from ~/.gitcookies (or legacy ~/.netrc)\n'
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01001972 'You can (re)generate your credentials by visiting '
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001973 'https://chromium-review.googlesource.com/new-password'],), ''),)
1974 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1975
1976 def test_gerrit_ensure_authenticated_conflict(self):
tandrii@chromium.org28253532016-04-14 13:46:56 +00001977 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001978 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001979 'chromium.googlesource.com':
1980 ('git-one.example.com', None, 'secret1'),
1981 'chromium-review.googlesource.com':
1982 ('git-other.example.com', None, 'secret2'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001983 })
1984 self.calls.append(
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01001985 (('ask_for_data', 'If you know what you are doing '
1986 'press Enter to continue, or Ctrl+C to abort'), ''))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001987 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1988
1989 def test_gerrit_ensure_authenticated_ok(self):
1990 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001991 'chromium.googlesource.com':
1992 ('git-same.example.com', None, 'secret'),
1993 'chromium-review.googlesource.com':
1994 ('git-same.example.com', None, 'secret'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001995 })
1996 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1997
tandrii@chromium.org28253532016-04-14 13:46:56 +00001998 def test_gerrit_ensure_authenticated_skipped(self):
1999 cl = self._test_gerrit_ensure_authenticated_common(
2000 auth={}, skip_auth_check=True)
2001 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2002
Eric Boren2fb63102018-10-05 13:05:03 +00002003 def test_gerrit_ensure_authenticated_bearer_token(self):
2004 cl = self._test_gerrit_ensure_authenticated_common(auth={
2005 'chromium.googlesource.com':
2006 ('', None, 'secret'),
2007 'chromium-review.googlesource.com':
2008 ('', None, 'secret'),
2009 })
2010 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2011 header = gerrit_util.CookiesAuthenticator().get_auth_header(
2012 'chromium.googlesource.com')
2013 self.assertTrue('Bearer' in header)
2014
Daniel Chengcf6269b2019-05-18 01:02:12 +00002015 def test_gerrit_ensure_authenticated_non_https(self):
2016 self.calls = [
2017 ((['git', 'config', '--bool',
2018 'gerrit.skip-ensure-authenticated'],), CERR1),
2019 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
2020 ((['git', 'config', 'branch.master.remote'],), 'origin'),
2021 ((['git', 'config', 'remote.origin.url'],), 'custom-scheme://repo'),
2022 ]
2023 self.mock(git_cl.gerrit_util, 'CookiesAuthenticator',
2024 CookiesAuthenticatorMockFactory(hosts_with_creds={}))
Edward Lemurf38bc172019-09-03 21:02:13 +00002025 cl = git_cl.Changelist()
Daniel Chengcf6269b2019-05-18 01:02:12 +00002026 cl.branch = 'master'
2027 cl.branchref = 'refs/heads/master'
2028 cl.lookedup_issue = True
2029 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2030
Andrii Shyshkalov828701b2016-12-09 10:46:47 +01002031 def _cmd_set_commit_gerrit_common(self, vote, notify=None):
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002032 self.mock(git_cl.gerrit_util, 'SetReview',
Andrii Shyshkalov828701b2016-12-09 10:46:47 +01002033 lambda h, i, labels, notify=None:
2034 self._mocked_call(['SetReview', h, i, labels, notify]))
2035
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002036 self.calls = [
2037 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii33a46ff2016-08-23 05:53:40 -07002038 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002039 ((['git', 'config', 'branch.feature.gerritserver'],),
2040 'https://chromium-review.googlesource.com'),
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002041 ((['git', 'config', 'branch.feature.merge'],), 'refs/heads/master'),
2042 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
2043 ((['git', 'config', 'remote.origin.url'],),
2044 'https://chromium.googlesource.com/infra/infra.git'),
2045 ((['SetReview', 'chromium-review.googlesource.com',
2046 'infra%2Finfra~123',
Andrii Shyshkalov828701b2016-12-09 10:46:47 +01002047 {'Commit-Queue': vote}, notify],), ''),
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002048 ]
tandriid9e5ce52016-07-13 02:32:59 -07002049
2050 def test_cmd_set_commit_gerrit_clear(self):
2051 self._cmd_set_commit_gerrit_common(0)
2052 self.assertEqual(0, git_cl.main(['set-commit', '-c']))
2053
2054 def test_cmd_set_commit_gerrit_dry(self):
Aaron Gable75e78722017-06-09 10:40:16 -07002055 self._cmd_set_commit_gerrit_common(1, notify=False)
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002056 self.assertEqual(0, git_cl.main(['set-commit', '-d']))
2057
tandriid9e5ce52016-07-13 02:32:59 -07002058 def test_cmd_set_commit_gerrit(self):
2059 self._cmd_set_commit_gerrit_common(2)
2060 self.assertEqual(0, git_cl.main(['set-commit']))
2061
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002062 def test_description_display(self):
2063 out = StringIO.StringIO()
2064 self.mock(git_cl.sys, 'stdout', out)
2065
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002066 self.mock(git_cl, 'Changelist', ChangelistMock)
2067 ChangelistMock.desc = 'foo\n'
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002068
2069 self.assertEqual(0, git_cl.main(['description', '-d']))
2070 self.assertEqual('foo\n', out.getvalue())
2071
iannucci3c972b92016-08-17 13:24:10 -07002072 def test_StatusFieldOverrideIssueMissingArgs(self):
2073 out = StringIO.StringIO()
2074 self.mock(git_cl.sys, 'stderr', out)
2075
2076 try:
2077 self.assertEqual(git_cl.main(['status', '--issue', '1']), 0)
2078 except SystemExit as ex:
2079 self.assertEqual(ex.code, 2)
Edward Lemurf38bc172019-09-03 21:02:13 +00002080 self.assertRegexpMatches(out.getvalue(), r'--field must be specified')
iannucci3c972b92016-08-17 13:24:10 -07002081
2082 out = StringIO.StringIO()
2083 self.mock(git_cl.sys, 'stderr', out)
2084
2085 try:
Andrii Shyshkalovfeec80e2018-10-16 01:00:47 +00002086 self.assertEqual(git_cl.main(['status', '--issue', '1', '--gerrit']), 0)
iannucci3c972b92016-08-17 13:24:10 -07002087 except SystemExit as ex:
2088 self.assertEqual(ex.code, 2)
iannuccie53c9352016-08-17 14:40:40 -07002089 self.assertRegexpMatches(out.getvalue(), r'--field must be specified')
iannucci3c972b92016-08-17 13:24:10 -07002090
2091 def test_StatusFieldOverrideIssue(self):
2092 out = StringIO.StringIO()
2093 self.mock(git_cl.sys, 'stdout', out)
2094
2095 def assertIssue(cl_self, *_args):
2096 self.assertEquals(cl_self.issue, 1)
2097 return 'foobar'
2098
2099 self.mock(git_cl.Changelist, 'GetDescription', assertIssue)
iannuccie53c9352016-08-17 14:40:40 -07002100 self.assertEqual(
Andrii Shyshkalovfeec80e2018-10-16 01:00:47 +00002101 git_cl.main(['status', '--issue', '1', '--gerrit', '--field', 'desc']),
iannuccie53c9352016-08-17 14:40:40 -07002102 0)
iannucci3c972b92016-08-17 13:24:10 -07002103 self.assertEqual(out.getvalue(), 'foobar\n')
2104
iannuccie53c9352016-08-17 14:40:40 -07002105 def test_SetCloseOverrideIssue(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002106
iannuccie53c9352016-08-17 14:40:40 -07002107 def assertIssue(cl_self, *_args):
2108 self.assertEquals(cl_self.issue, 1)
2109 return 'foobar'
2110
2111 self.mock(git_cl.Changelist, 'GetDescription', assertIssue)
2112 self.mock(git_cl.Changelist, 'CloseIssue', lambda *_: None)
iannuccie53c9352016-08-17 14:40:40 -07002113 self.assertEqual(
Andrii Shyshkalovfeec80e2018-10-16 01:00:47 +00002114 git_cl.main(['set-close', '--issue', '1', '--gerrit']), 0)
iannuccie53c9352016-08-17 14:40:40 -07002115
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00002116 def test_description(self):
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002117 out = StringIO.StringIO()
2118 self.mock(git_cl.sys, 'stdout', out)
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01002119 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002120 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
2121 ((['git', 'config', 'branch.feature.merge'],), 'feature'),
2122 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
2123 ((['git', 'config', 'remote.origin.url'],),
2124 'https://chromium.googlesource.com/my/repo'),
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00002125 (('GetChangeDetail', 'chromium-review.googlesource.com',
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002126 'my%2Frepo~123123', ['CURRENT_REVISION', 'CURRENT_COMMIT']),
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01002127 {
2128 'current_revision': 'sha1',
2129 'revisions': {'sha1': {
2130 'commit': {'message': 'foobar'},
2131 }},
2132 }),
2133 ]
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002134 self.assertEqual(0, git_cl.main([
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00002135 'description',
2136 'https://chromium-review.googlesource.com/c/my/repo/+/123123',
2137 '-d']))
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002138 self.assertEqual('foobar\n', out.getvalue())
2139
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002140 def test_description_set_raw(self):
2141 out = StringIO.StringIO()
2142 self.mock(git_cl.sys, 'stdout', out)
2143
2144 self.mock(git_cl, 'Changelist', ChangelistMock)
2145 self.mock(git_cl.sys, 'stdin', StringIO.StringIO('hihi'))
2146
2147 self.assertEqual(0, git_cl.main(['description', '-n', 'hihi']))
2148 self.assertEqual('hihi', ChangelistMock.desc)
2149
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002150 def test_description_appends_bug_line(self):
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002151 current_desc = 'Some.\n\nChange-Id: xxx'
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002152
2153 def RunEditor(desc, _, **kwargs):
2154 self.assertEquals(
2155 '# Enter a description of the change.\n'
2156 '# This will be displayed on the codereview site.\n'
2157 '# The first line will also be used as the subject of the review.\n'
2158 '#--------------------This line is 72 characters long'
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002159 '--------------------\n'
Aaron Gable3a16ed12017-03-23 10:51:55 -07002160 'Some.\n\nChange-Id: xxx\nBug: ',
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002161 desc)
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002162 # Simulate user changing something.
Aaron Gable3a16ed12017-03-23 10:51:55 -07002163 return 'Some.\n\nChange-Id: xxx\nBug: 123'
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002164
dsansomee2d6fd92016-09-08 00:10:47 -07002165 def UpdateDescriptionRemote(_, desc, force=False):
Aaron Gable3a16ed12017-03-23 10:51:55 -07002166 self.assertEquals(desc, 'Some.\n\nChange-Id: xxx\nBug: 123')
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002167
2168 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2169 self.mock(git_cl.Changelist, 'GetDescription',
2170 lambda *args: current_desc)
Edward Lemur125d60a2019-09-13 18:25:41 +00002171 self.mock(git_cl.Changelist, 'UpdateDescriptionRemote',
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002172 UpdateDescriptionRemote)
2173 self.mock(git_cl.gclient_utils, 'RunEditor', RunEditor)
2174
2175 self.calls = [
2176 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii33a46ff2016-08-23 05:53:40 -07002177 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
tandrii5d48c322016-08-18 16:19:37 -07002178 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
2179 ((['git', 'config', 'rietveld.bug-prefix'],), CERR1),
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002180 ((['git', 'config', 'core.editor'],), 'vi'),
2181 ]
2182 self.assertEqual(0, git_cl.main(['description', '--gerrit']))
2183
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002184 def test_description_set_stdin(self):
2185 out = StringIO.StringIO()
2186 self.mock(git_cl.sys, 'stdout', out)
2187
2188 self.mock(git_cl, 'Changelist', ChangelistMock)
2189 self.mock(git_cl.sys, 'stdin', StringIO.StringIO('hi \r\n\t there\n\nman'))
2190
2191 self.assertEqual(0, git_cl.main(['description', '-n', '-']))
2192 self.assertEqual('hi\n\t there\n\nman', ChangelistMock.desc)
2193
kmarshall3bff56b2016-06-06 18:31:47 -07002194 def test_archive(self):
tandrii1c67da62016-06-10 07:35:53 -07002195 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2196
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002197 self.calls = [
2198 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
Edward Lemurf38bc172019-09-03 21:02:13 +00002199 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002200 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2201 ((['git', 'tag', 'git-cl-archived-456-foo', 'foo'],), ''),
Edward Lemurf38bc172019-09-03 21:02:13 +00002202 ((['git', 'branch', '-D', 'foo'],), '')
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002203 ]
kmarshall3bff56b2016-06-06 18:31:47 -07002204
kmarshall3bff56b2016-06-06 18:31:47 -07002205 self.mock(git_cl, 'get_cl_statuses',
2206 lambda branches, fine_grained, max_processes:
kmarshall9249e012016-08-23 12:02:16 -07002207 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2208 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
2209 (MockChangelistWithBranchAndIssue('bar', 789), 'open')])
kmarshall3bff56b2016-06-06 18:31:47 -07002210
2211 self.assertEqual(0, git_cl.main(['archive', '-f']))
2212
2213 def test_archive_current_branch_fails(self):
tandrii1c67da62016-06-10 07:35:53 -07002214 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002215 self.calls = [
2216 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2217 'refs/heads/master'),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002218 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2219 ]
kmarshall3bff56b2016-06-06 18:31:47 -07002220
kmarshall9249e012016-08-23 12:02:16 -07002221 self.mock(git_cl, 'get_cl_statuses',
2222 lambda branches, fine_grained, max_processes:
2223 [(MockChangelistWithBranchAndIssue('master', 1), 'closed')])
2224
2225 self.assertEqual(1, git_cl.main(['archive', '-f']))
2226
2227 def test_archive_dry_run(self):
2228 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2229
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002230 self.calls = [
2231 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2232 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002233 ((['git', 'symbolic-ref', 'HEAD'],), 'master')
2234 ]
kmarshall3bff56b2016-06-06 18:31:47 -07002235
2236 self.mock(git_cl, 'get_cl_statuses',
2237 lambda branches, fine_grained, max_processes:
kmarshall9249e012016-08-23 12:02:16 -07002238 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2239 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
2240 (MockChangelistWithBranchAndIssue('bar', 789), 'open')])
kmarshall3bff56b2016-06-06 18:31:47 -07002241
kmarshall9249e012016-08-23 12:02:16 -07002242 self.assertEqual(0, git_cl.main(['archive', '-f', '--dry-run']))
2243
2244 def test_archive_no_tags(self):
2245 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2246
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002247 self.calls = [
2248 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2249 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002250 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2251 ((['git', 'branch', '-D', 'foo'],), '')
2252 ]
kmarshall9249e012016-08-23 12:02:16 -07002253
2254 self.mock(git_cl, 'get_cl_statuses',
2255 lambda branches, fine_grained, max_processes:
2256 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2257 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
2258 (MockChangelistWithBranchAndIssue('bar', 789), 'open')])
2259
2260 self.assertEqual(0, git_cl.main(['archive', '-f', '--notags']))
kmarshall3bff56b2016-06-06 18:31:47 -07002261
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002262 def test_cmd_issue_erase_existing(self):
2263 out = StringIO.StringIO()
2264 self.mock(git_cl.sys, 'stdout', out)
2265 self.calls = [
2266 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002267 # Let this command raise exception (retcode=1) - it should be ignored.
2268 ((['git', 'config', '--unset', 'branch.feature.last-upload-hash'],),
tandrii5d48c322016-08-18 16:19:37 -07002269 CERR1),
2270 ((['git', 'config', '--unset', 'branch.feature.gerritissue'],), ''),
2271 ((['git', 'config', '--unset', 'branch.feature.gerritpatchset'],), ''),
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002272 ((['git', 'config', '--unset', 'branch.feature.gerritserver'],), ''),
2273 ((['git', 'config', '--unset', 'branch.feature.gerritsquashhash'],),
2274 ''),
Aaron Gableca01e2c2017-07-19 11:16:02 -07002275 ((['git', 'log', '-1', '--format=%B'],), 'This is a description'),
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002276 ]
2277 self.assertEqual(0, git_cl.main(['issue', '0']))
2278
Aaron Gable400e9892017-07-12 15:31:21 -07002279 def test_cmd_issue_erase_existing_with_change_id(self):
2280 out = StringIO.StringIO()
2281 self.mock(git_cl.sys, 'stdout', out)
2282 self.mock(git_cl.Changelist, 'GetDescription',
2283 lambda _: 'This is a description\n\nChange-Id: Ideadbeef')
2284 self.calls = [
2285 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
Aaron Gable400e9892017-07-12 15:31:21 -07002286 # Let this command raise exception (retcode=1) - it should be ignored.
2287 ((['git', 'config', '--unset', 'branch.feature.last-upload-hash'],),
2288 CERR1),
2289 ((['git', 'config', '--unset', 'branch.feature.gerritissue'],), ''),
2290 ((['git', 'config', '--unset', 'branch.feature.gerritpatchset'],), ''),
2291 ((['git', 'config', '--unset', 'branch.feature.gerritserver'],), ''),
2292 ((['git', 'config', '--unset', 'branch.feature.gerritsquashhash'],),
2293 ''),
Aaron Gableca01e2c2017-07-19 11:16:02 -07002294 ((['git', 'log', '-1', '--format=%B'],),
2295 'This is a description\n\nChange-Id: Ideadbeef'),
2296 ((['git', 'commit', '--amend', '-m', 'This is a description\n'],), ''),
Aaron Gable400e9892017-07-12 15:31:21 -07002297 ]
2298 self.assertEqual(0, git_cl.main(['issue', '0']))
2299
phajdan.jre328cf92016-08-22 04:12:17 -07002300 def test_cmd_issue_json(self):
2301 out = StringIO.StringIO()
2302 self.mock(git_cl.sys, 'stdout', out)
2303 self.calls = [
2304 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
Andrii Shyshkalova185e2e2018-11-21 00:42:55 +00002305 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
2306 ((['git', 'config', 'branch.feature.gerritserver'],),
2307 'https://chromium-review.googlesource.com'),
phajdan.jre328cf92016-08-22 04:12:17 -07002308 (('write_json', 'output.json',
Andrii Shyshkalova185e2e2018-11-21 00:42:55 +00002309 {'issue': 123,
2310 'issue_url': 'https://chromium-review.googlesource.com/123'}),
phajdan.jre328cf92016-08-22 04:12:17 -07002311 ''),
2312 ]
2313 self.assertEqual(0, git_cl.main(['issue', '--json', 'output.json']))
2314
tandrii8c5a3532016-11-04 07:52:02 -07002315 def test_git_cl_try_default_cq_dry_run_gerrit(self):
2316 self.mock(git_cl.Changelist, 'GetChange',
2317 lambda _, *a: (
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002318 self._mocked_call(['GetChange'] + list(a))))
tandrii8c5a3532016-11-04 07:52:02 -07002319 self.mock(git_cl.presubmit_support, 'DoGetTryMasters',
2320 lambda *_, **__: (
2321 self._mocked_call(['DoGetTryMasters'])))
Edward Lemur125d60a2019-09-13 18:25:41 +00002322 self.mock(git_cl.Changelist, 'SetCQState',
tandrii8c5a3532016-11-04 07:52:02 -07002323 lambda _, s: self._mocked_call(['SetCQState', s]))
2324
tandrii8c5a3532016-11-04 07:52:02 -07002325 self.calls = [
2326 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii8c5a3532016-11-04 07:52:02 -07002327 ((['git', 'config', 'branch.feature.gerritissue'],), '123456'),
2328 ((['git', 'config', 'branch.feature.gerritserver'],),
2329 'https://chromium-review.googlesource.com'),
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002330 ((['git', 'config', 'branch.feature.merge'],), 'feature'),
2331 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
2332 ((['git', 'config', 'remote.origin.url'],),
2333 'https://chromium.googlesource.com/depot_tools'),
2334 (('GetChangeDetail', 'chromium-review.googlesource.com',
2335 'depot_tools~123456',
Andrii Shyshkaloveadad922017-01-26 09:38:30 +01002336 ['DETAILED_ACCOUNTS', 'ALL_REVISIONS', 'CURRENT_COMMIT']), {
2337 'project': 'depot_tools',
2338 'status': 'OPEN',
2339 'owner': {'email': 'owner@e.mail'},
2340 'revisions': {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002341 'deadbeaf': {
Andrii Shyshkaloveadad922017-01-26 09:38:30 +01002342 '_number': 6,
2343 },
2344 'beeeeeef': {
2345 '_number': 7,
2346 'fetch': {'http': {
2347 'url': 'https://chromium.googlesource.com/depot_tools',
2348 'ref': 'refs/changes/56/123456/7'
2349 }},
2350 },
2351 },
2352 }),
tandrii8c5a3532016-11-04 07:52:02 -07002353 ((['git', 'config', 'branch.feature.merge'],), 'feature'),
2354 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
2355 ((['get_or_create_merge_base', 'feature', 'feature'],),
2356 'fake_ancestor_sha'),
2357 ((['GetChange', 'fake_ancestor_sha', None], ),
2358 git_cl.presubmit_support.GitChange(
2359 '', '', '', '', '', '', '', '')),
2360 ((['git', 'rev-parse', '--show-cdup'],), '../'),
2361 ((['DoGetTryMasters'], ), None),
Edward Lemur125d60a2019-09-13 18:25:41 +00002362 ((['SetCQState', git_cl._CQState.DRY_RUN], ), 0),
tandrii8c5a3532016-11-04 07:52:02 -07002363 ]
2364 out = StringIO.StringIO()
2365 self.mock(git_cl.sys, 'stdout', out)
2366 self.assertEqual(0, git_cl.main(['try']))
2367 self.assertEqual(
2368 out.getvalue(),
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07002369 'Scheduling CQ dry run on: '
tandrii8c5a3532016-11-04 07:52:02 -07002370 'https://chromium-review.googlesource.com/123456\n')
2371
Edward Lemurd4d1ba42019-09-20 21:46:37 +00002372 def test_parse_bucket(self):
2373 self.assertEqual(git_cl._parse_bucket('chromium/try'), ('chromium', 'try'))
2374 self.assertEqual(
2375 git_cl._parse_bucket('luci.chromium.try'), ('chromium', 'try'))
2376 self.assertEqual(git_cl._parse_bucket('not-a-bucket'), (None, None))
2377 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2378 self.assertEqual(
2379 git_cl._parse_bucket('skia.primary'),
2380 ('skia', 'skia.primary'))
2381 self.assertIn(
2382 'WARNING Please specify buckets',
2383 git_cl.sys.stdout.getvalue())
2384
2385 def test_git_cl_try_buildbucket_with_wrong_bucket(self):
tandrii8c5a3532016-11-04 07:52:02 -07002386 self.mock(git_cl.Changelist, 'GetMostRecentPatchset', lambda _: 7)
2387 self.mock(git_cl.uuid, 'uuid4', lambda: 'uuid4')
2388
tandrii8c5a3532016-11-04 07:52:02 -07002389 self.calls = [
2390 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii8c5a3532016-11-04 07:52:02 -07002391 ((['git', 'config', 'branch.feature.gerritissue'],), '123456'),
2392 ((['git', 'config', 'branch.feature.gerritserver'],),
2393 'https://chromium-review.googlesource.com'),
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002394 ((['git', 'config', 'branch.feature.merge'],), 'feature'),
2395 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
2396 ((['git', 'config', 'remote.origin.url'],),
2397 'https://chromium.googlesource.com/depot_tools'),
2398 (('GetChangeDetail', 'chromium-review.googlesource.com',
2399 'depot_tools~123456',
Andrii Shyshkaloveadad922017-01-26 09:38:30 +01002400 ['DETAILED_ACCOUNTS', 'ALL_REVISIONS', 'CURRENT_COMMIT']), {
tandrii8c5a3532016-11-04 07:52:02 -07002401 'project': 'depot_tools',
Andrii Shyshkaloveadad922017-01-26 09:38:30 +01002402 'status': 'OPEN',
2403 'owner': {'email': 'owner@e.mail'},
tandrii8c5a3532016-11-04 07:52:02 -07002404 'revisions': {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002405 'deadbeaf': {
tandrii8c5a3532016-11-04 07:52:02 -07002406 '_number': 6,
2407 },
2408 'beeeeeef': {
2409 '_number': 7,
2410 'fetch': {'http': {
2411 'url': 'https://chromium.googlesource.com/depot_tools',
2412 'ref': 'refs/changes/56/123456/7'
2413 }},
2414 },
2415 },
2416 }),
Edward Lemurd4d1ba42019-09-20 21:46:37 +00002417 ((['git', 'config', 'branch.feature.gerritpatchset'],), '7'),
tandrii8c5a3532016-11-04 07:52:02 -07002418 ]
2419
Edward Lemurd4d1ba42019-09-20 21:46:37 +00002420 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2421 self.assertEqual(0, git_cl.main([
2422 'try', '-B', 'not-a-bucket', '-b', 'win',
2423 '-p', 'key=val', '-p', 'json=[{"a":1}, null]']))
2424 self.assertIn(
2425 'Could not parse bucket "not-a-bucket"',
2426 git_cl.sys.stdout.getvalue())
Edward Lemur2c210a42019-09-16 23:58:35 +00002427
Edward Lemurd4d1ba42019-09-20 21:46:37 +00002428 def test_git_cl_try_buildbucket_with_properties_gerrit(self):
2429 def _mock_call_buildbucket(_http, buildbucket_host, method, request=None):
2430 bb_request = {
2431 "requests": [{
2432 "scheduleBuild": {
2433 "requestId": "uuid4",
2434 "builder": {
2435 "project": "chromium",
2436 "builder": "win",
2437 "bucket": "try",
2438 },
2439 "gerritChanges": [{
2440 "project": "depot_tools",
2441 "host": "chromium-review.googlesource.com",
2442 "patchset": 7,
2443 "change": 123456,
2444 }],
2445 "properties": {
2446 "category": "git_cl_try",
2447 "json": [{"a": 1}, None],
2448 "key": "val",
2449 },
2450 "tags": [
2451 {"value": "win", "key": "builder"},
2452 {"value": "git_cl_try", "key": "user_agent"},
2453 ],
2454 },
2455 }],
2456 }
2457 self.assertEqual(method, 'Batch')
2458 self.assertEqual(buildbucket_host, 'cr-buildbucket.appspot.com')
2459 self.assertEqual(request, bb_request)
2460 return {}
Edward Lemur2c210a42019-09-16 23:58:35 +00002461
Edward Lemurd4d1ba42019-09-20 21:46:37 +00002462 self.mock(git_cl, '_call_buildbucket', _mock_call_buildbucket)
2463 self.mock(git_cl.Changelist, 'GetMostRecentPatchset', lambda _: 7)
2464 self.mock(git_cl.uuid, 'uuid4', lambda: 'uuid4')
2465
2466 self.calls = [
2467 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
2468 ((['git', 'config', 'branch.feature.gerritissue'],), '123456'),
2469 ((['git', 'config', 'branch.feature.gerritserver'],),
2470 'https://chromium-review.googlesource.com'),
2471 ((['git', 'config', 'branch.feature.merge'],), 'feature'),
2472 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
2473 ((['git', 'config', 'remote.origin.url'],),
2474 'https://chromium.googlesource.com/depot_tools'),
2475 (('GetChangeDetail', 'chromium-review.googlesource.com',
2476 'depot_tools~123456',
2477 ['DETAILED_ACCOUNTS', 'ALL_REVISIONS', 'CURRENT_COMMIT']), {
2478 'project': 'depot_tools',
2479 'status': 'OPEN',
2480 'owner': {'email': 'owner@e.mail'},
2481 'revisions': {
2482 'deadbeaf': {
2483 '_number': 6,
2484 },
2485 'beeeeeef': {
2486 '_number': 7,
2487 'fetch': {'http': {
2488 'url': 'https://chromium.googlesource.com/depot_tools',
2489 'ref': 'refs/changes/56/123456/7'
2490 }},
2491 },
2492 },
2493 }),
2494 ((['git', 'config', 'branch.feature.gerritpatchset'],), '7'),
2495 ]
Edward Lemur2c210a42019-09-16 23:58:35 +00002496
tandrii8c5a3532016-11-04 07:52:02 -07002497 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2498 self.assertEqual(0, git_cl.main([
Andrii Shyshkalov03da1502018-10-15 03:42:34 +00002499 'try', '-B', 'luci.chromium.try', '-b', 'win',
tandrii8c5a3532016-11-04 07:52:02 -07002500 '-p', 'key=val', '-p', 'json=[{"a":1}, null]']))
Edward Lemurd4d1ba42019-09-20 21:46:37 +00002501 self.assertIn(
2502 'Scheduling jobs on:\nBucket: luci.chromium.try',
2503 git_cl.sys.stdout.getvalue())
tandriide281ae2016-10-12 06:02:30 -07002504
tandrii16e0b4e2016-06-07 10:34:28 -07002505 def _common_GerritCommitMsgHookCheck(self):
2506 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2507 self.mock(git_cl.os.path, 'abspath',
2508 lambda path: self._mocked_call(['abspath', path]))
2509 self.mock(git_cl.os.path, 'exists',
2510 lambda path: self._mocked_call(['exists', path]))
2511 self.mock(git_cl.gclient_utils, 'FileRead',
2512 lambda path: self._mocked_call(['FileRead', path]))
2513 self.mock(git_cl.gclient_utils, 'rm_file_or_tree',
2514 lambda path: self._mocked_call(['rm_file_or_tree', path]))
2515 self.calls = [
2516 ((['git', 'rev-parse', '--show-cdup'],), '../'),
2517 ((['abspath', '../'],), '/abs/git_repo_root'),
2518 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002519 return git_cl.Changelist(issue=123)
tandrii16e0b4e2016-06-07 10:34:28 -07002520
2521 def test_GerritCommitMsgHookCheck_custom_hook(self):
2522 cl = self._common_GerritCommitMsgHookCheck()
2523 self.calls += [
2524 ((['exists', '/abs/git_repo_root/.git/hooks/commit-msg'],), True),
2525 ((['FileRead', '/abs/git_repo_root/.git/hooks/commit-msg'],),
2526 '#!/bin/sh\necho "custom hook"')
2527 ]
Edward Lemur125d60a2019-09-13 18:25:41 +00002528 cl._GerritCommitMsgHookCheck(offer_removal=True)
tandrii16e0b4e2016-06-07 10:34:28 -07002529
2530 def test_GerritCommitMsgHookCheck_not_exists(self):
2531 cl = self._common_GerritCommitMsgHookCheck()
2532 self.calls += [
2533 ((['exists', '/abs/git_repo_root/.git/hooks/commit-msg'],), False),
2534 ]
Edward Lemur125d60a2019-09-13 18:25:41 +00002535 cl._GerritCommitMsgHookCheck(offer_removal=True)
tandrii16e0b4e2016-06-07 10:34:28 -07002536
2537 def test_GerritCommitMsgHookCheck(self):
2538 cl = self._common_GerritCommitMsgHookCheck()
2539 self.calls += [
2540 ((['exists', '/abs/git_repo_root/.git/hooks/commit-msg'],), True),
2541 ((['FileRead', '/abs/git_repo_root/.git/hooks/commit-msg'],),
2542 '...\n# From Gerrit Code Review\n...\nadd_ChangeId()\n'),
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002543 (('ask_for_data', 'Do you want to remove it now? [Yes/No]: '), 'Yes'),
tandrii16e0b4e2016-06-07 10:34:28 -07002544 ((['rm_file_or_tree', '/abs/git_repo_root/.git/hooks/commit-msg'],),
2545 ''),
2546 ]
Edward Lemur125d60a2019-09-13 18:25:41 +00002547 cl._GerritCommitMsgHookCheck(offer_removal=True)
tandrii16e0b4e2016-06-07 10:34:28 -07002548
tandriic4344b52016-08-29 06:04:54 -07002549 def test_GerritCmdLand(self):
2550 self.calls += [
2551 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
2552 ((['git', 'config', 'branch.feature.gerritsquashhash'],),
2553 'deadbeaf'),
2554 ((['git', 'diff', 'deadbeaf'],), ''), # No diff.
2555 ((['git', 'config', 'branch.feature.gerritserver'],),
2556 'chromium-review.googlesource.com'),
2557 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002558 cl = git_cl.Changelist(issue=123)
Edward Lemur125d60a2019-09-13 18:25:41 +00002559 cl._GetChangeDetail = lambda *args, **kwargs: {
tandriic4344b52016-08-29 06:04:54 -07002560 'labels': {},
2561 'current_revision': 'deadbeaf',
2562 }
Edward Lemur125d60a2019-09-13 18:25:41 +00002563 cl._GetChangeCommit = lambda: {
agable32978d92016-11-01 12:55:02 -07002564 'commit': 'deadbeef',
Aaron Gable02cdbb42016-12-13 16:24:25 -08002565 'web_links': [{'name': 'gitiles',
agable32978d92016-11-01 12:55:02 -07002566 'url': 'https://git.googlesource.com/test/+/deadbeef'}],
2567 }
Edward Lemur125d60a2019-09-13 18:25:41 +00002568 cl.SubmitIssue = lambda wait_for_merge: None
tandrii8da412c2016-09-07 16:01:07 -07002569 out = StringIO.StringIO()
2570 self.mock(sys, 'stdout', out)
Olivier Robin75ee7252018-04-13 10:02:56 +02002571 self.assertEqual(0, cl.CMDLand(force=True,
2572 bypass_hooks=True,
2573 verbose=True,
2574 parallel=False))
tandrii8da412c2016-09-07 16:01:07 -07002575 self.assertRegexpMatches(out.getvalue(), 'Issue.*123 has been submitted')
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002576 self.assertRegexpMatches(out.getvalue(), 'Landed as: .*deadbeef')
tandriic4344b52016-08-29 06:04:54 -07002577
tandrii221ab252016-10-06 08:12:04 -07002578 BUILDBUCKET_BUILDS_MAP = {
Quinten Yearsleya563d722017-12-11 16:36:54 -08002579 '9000': {
2580 'id': '9000',
2581 'bucket': 'master.x.y',
2582 'created_by': 'user:someone@chromium.org',
2583 'created_ts': '147200002222000',
2584 'experimental': False,
2585 'parameters_json': json.dumps({
2586 'builder_name': 'my-bot',
2587 'properties': {'category': 'cq'},
2588 }),
2589 'status': 'STARTED',
2590 'tags': [
2591 'build_address:x.y/my-bot/2',
2592 'builder:my-bot',
2593 'experimental:false',
2594 'user_agent:cq',
2595 ],
2596 'url': 'http://build.cr.org/p/x.y/builders/my-bot/builds/2',
2597 },
2598 '8000': {
2599 'id': '8000',
2600 'bucket': 'master.x.y',
2601 'created_by': 'user:someone@chromium.org',
2602 'created_ts': '147200001111000',
2603 'experimental': False,
2604 'failure_reason': 'BUILD_FAILURE',
2605 'parameters_json': json.dumps({
2606 'builder_name': 'my-bot',
2607 'properties': {'category': 'cq'},
2608 }),
2609 'result_details_json': json.dumps({
2610 'properties': {'buildnumber': 1},
2611 }),
2612 'result': 'FAILURE',
2613 'status': 'COMPLETED',
2614 'tags': [
2615 'build_address:x.y/my-bot/1',
2616 'builder:my-bot',
2617 'experimental:false',
2618 'user_agent:cq',
2619 ],
2620 'url': 'http://build.cr.org/p/x.y/builders/my-bot/builds/1',
2621 },
2622 }
tandrii221ab252016-10-06 08:12:04 -07002623
2624 def test_write_try_results_json(self):
2625 expected_output = [
Quinten Yearsleya563d722017-12-11 16:36:54 -08002626 {
2627 'bucket': 'master.x.y',
2628 'buildbucket_id': '8000',
2629 'builder_name': 'my-bot',
2630 'created_ts': '147200001111000',
2631 'experimental': False,
2632 'failure_reason': 'BUILD_FAILURE',
2633 'result': 'FAILURE',
2634 'status': 'COMPLETED',
2635 'tags': [
2636 'build_address:x.y/my-bot/1',
2637 'builder:my-bot',
2638 'experimental:false',
2639 'user_agent:cq',
2640 ],
2641 'url': 'http://build.cr.org/p/x.y/builders/my-bot/builds/1',
2642 },
2643 {
2644 'bucket': 'master.x.y',
2645 'buildbucket_id': '9000',
2646 'builder_name': 'my-bot',
2647 'created_ts': '147200002222000',
2648 'experimental': False,
2649 'failure_reason': None,
2650 'result': None,
2651 'status': 'STARTED',
2652 'tags': [
2653 'build_address:x.y/my-bot/2',
2654 'builder:my-bot',
2655 'experimental:false',
2656 'user_agent:cq',
2657 ],
2658 'url': 'http://build.cr.org/p/x.y/builders/my-bot/builds/2',
2659 },
tandrii221ab252016-10-06 08:12:04 -07002660 ]
2661 self.calls = [(('write_json', 'output.json', expected_output), '')]
2662 git_cl.write_try_results_json('output.json', self.BUILDBUCKET_BUILDS_MAP)
2663
tandrii45b2a582016-10-11 03:14:16 -07002664 def _setup_fetch_try_jobs(self, most_recent_patchset=20001):
tandrii221ab252016-10-06 08:12:04 -07002665 out = StringIO.StringIO()
2666 self.mock(sys, 'stdout', out)
tandrii45b2a582016-10-11 03:14:16 -07002667 self.mock(git_cl.Changelist, 'GetMostRecentPatchset',
2668 lambda *args: most_recent_patchset)
tandrii221ab252016-10-06 08:12:04 -07002669 self.mock(git_cl.auth, 'get_authenticator_for_host', lambda host, _cfg:
2670 self._mocked_call(['get_authenticator_for_host', host]))
2671 self.mock(git_cl, '_buildbucket_retry', lambda *_, **__:
2672 self._mocked_call(['_buildbucket_retry']))
tandrii45b2a582016-10-11 03:14:16 -07002673
tandrii45b2a582016-10-11 03:14:16 -07002674 def _setup_fetch_try_jobs_gerrit(self, *request_results):
2675 self._setup_fetch_try_jobs(most_recent_patchset=13)
2676 self.calls += [
2677 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii45b2a582016-10-11 03:14:16 -07002678 ((['git', 'config', 'branch.feature.gerritissue'],), '1'),
Ravi Mistryfda50ca2016-11-14 10:19:18 -05002679 # TODO(tandrii): Uncomment the below if we decide to support checking
2680 # patchsets for Gerrit.
tandrii45b2a582016-10-11 03:14:16 -07002681 # Simulate that Gerrit has more patchsets than local.
Ravi Mistryfda50ca2016-11-14 10:19:18 -05002682 # ((['git', 'config', 'branch.feature.gerritpatchset'],), '12'),
tandrii45b2a582016-10-11 03:14:16 -07002683 ((['git', 'config', 'branch.feature.gerritserver'],),
2684 'https://x-review.googlesource.com'),
2685 ((['get_authenticator_for_host', 'x-review.googlesource.com'],),
2686 AuthenticatorMock()),
2687 ] + [((['_buildbucket_retry'],), r) for r in request_results]
2688
2689 def test_fetch_try_jobs_none_gerrit(self):
2690 self._setup_fetch_try_jobs_gerrit({})
2691 self.assertEqual(0, git_cl.main(['try-results']))
Ravi Mistryfda50ca2016-11-14 10:19:18 -05002692 # TODO(tandrii): Uncomment the below if we decide to support checking
2693 # patchsets for Gerrit.
2694 # self.assertRegexpMatches(
2695 # sys.stdout.getvalue(),
2696 # r'Warning: Codereview server has newer patchsets \(13\)')
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002697 self.assertRegexpMatches(sys.stdout.getvalue(), 'No tryjobs')
tandrii45b2a582016-10-11 03:14:16 -07002698
2699 def test_fetch_try_jobs_some_gerrit(self):
2700 self._setup_fetch_try_jobs_gerrit({
2701 'builds': self.BUILDBUCKET_BUILDS_MAP.values(),
2702 })
Ravi Mistryfda50ca2016-11-14 10:19:18 -05002703 # TODO(tandrii): Uncomment the below if we decide to support checking
2704 # patchsets for Gerrit.
2705 # self.calls.remove(
2706 # ((['git', 'config', 'branch.feature.gerritpatchset'],), '12'))
tandrii45b2a582016-10-11 03:14:16 -07002707 self.assertEqual(0, git_cl.main(['try-results', '--patchset', '5']))
2708
2709 # ... and doesn't result in warning.
2710 self.assertNotRegexpMatches(sys.stdout.getvalue(), 'Warning')
2711 self.assertRegexpMatches(sys.stdout.getvalue(), '^Failures:')
tandrii221ab252016-10-06 08:12:04 -07002712 self.assertRegexpMatches(sys.stdout.getvalue(), 'Started:')
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002713 self.assertRegexpMatches(sys.stdout.getvalue(), '2 tryjobs')
tandrii221ab252016-10-06 08:12:04 -07002714
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002715 def _mock_gerrit_changes_for_detail_cache(self):
Edward Lemur125d60a2019-09-13 18:25:41 +00002716 self.mock(git_cl.Changelist, '_GetGerritHost', lambda _: 'host')
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002717
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002718 def test_gerrit_change_detail_cache_simple(self):
2719 self._mock_gerrit_changes_for_detail_cache()
2720 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002721 (('GetChangeDetail', 'host', 'my%2Frepo~1', []), 'a'),
2722 (('GetChangeDetail', 'host', 'ab%2Frepo~2', []), 'b'),
2723 (('GetChangeDetail', 'host', 'ab%2Frepo~2', []), 'b2'),
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002724 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002725 cl1 = git_cl.Changelist(issue=1)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002726 cl1._cached_remote_url = (
2727 True, 'https://chromium.googlesource.com/a/my/repo.git/')
Edward Lemurf38bc172019-09-03 21:02:13 +00002728 cl2 = git_cl.Changelist(issue=2)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002729 cl2._cached_remote_url = (
2730 True, 'https://chromium.googlesource.com/ab/repo')
Andrii Shyshkalovb7214602018-08-22 23:20:26 +00002731 self.assertEqual(cl1._GetChangeDetail(), 'a') # Miss.
2732 self.assertEqual(cl1._GetChangeDetail(), 'a')
2733 self.assertEqual(cl2._GetChangeDetail(), 'b') # Miss.
2734 self.assertEqual(cl2._GetChangeDetail(no_cache=True), 'b2') # Miss.
2735 self.assertEqual(cl1._GetChangeDetail(), 'a')
2736 self.assertEqual(cl2._GetChangeDetail(), 'b2')
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002737
2738 def test_gerrit_change_detail_cache_options(self):
2739 self._mock_gerrit_changes_for_detail_cache()
2740 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002741 (('GetChangeDetail', 'host', 'repo~1', ['C', 'A', 'B']), 'cab'),
2742 (('GetChangeDetail', 'host', 'repo~1', ['A', 'D']), 'ad'),
2743 (('GetChangeDetail', 'host', 'repo~1', ['A']), 'a'), # no_cache=True
2744 # no longer in cache.
2745 (('GetChangeDetail', 'host', 'repo~1', ['B']), 'b'),
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002746 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00002747 cl = git_cl.Changelist(issue=1)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002748 cl._cached_remote_url = (True, 'https://chromium.googlesource.com/repo/')
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002749 self.assertEqual(cl._GetChangeDetail(options=['C', 'A', 'B']), 'cab')
2750 self.assertEqual(cl._GetChangeDetail(options=['A', 'B', 'C']), 'cab')
2751 self.assertEqual(cl._GetChangeDetail(options=['B', 'A']), 'cab')
2752 self.assertEqual(cl._GetChangeDetail(options=['C']), 'cab')
2753 self.assertEqual(cl._GetChangeDetail(options=['A']), 'cab')
2754 self.assertEqual(cl._GetChangeDetail(), 'cab')
2755
2756 self.assertEqual(cl._GetChangeDetail(options=['A', 'D']), 'ad')
2757 self.assertEqual(cl._GetChangeDetail(options=['A']), 'cab')
2758 self.assertEqual(cl._GetChangeDetail(options=['D']), 'ad')
2759 self.assertEqual(cl._GetChangeDetail(), 'cab')
2760
2761 # Finally, no_cache should invalidate all caches for given change.
2762 self.assertEqual(cl._GetChangeDetail(options=['A'], no_cache=True), 'a')
2763 self.assertEqual(cl._GetChangeDetail(options=['B']), 'b')
2764
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002765 def test_gerrit_description_caching(self):
2766 def gen_detail(rev, desc):
2767 return {
2768 'current_revision': rev,
2769 'revisions': {rev: {'commit': {'message': desc}}}
2770 }
2771 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002772 (('GetChangeDetail', 'host', 'my%2Frepo~1',
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002773 ['CURRENT_REVISION', 'CURRENT_COMMIT']),
2774 gen_detail('rev1', 'desc1')),
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002775 (('GetChangeDetail', 'host', 'my%2Frepo~1',
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002776 ['CURRENT_REVISION', 'CURRENT_COMMIT']),
2777 gen_detail('rev2', 'desc2')),
2778 ]
2779
2780 self._mock_gerrit_changes_for_detail_cache()
Edward Lemurf38bc172019-09-03 21:02:13 +00002781 cl = git_cl.Changelist(issue=1)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002782 cl._cached_remote_url = (
2783 True, 'https://chromium.googlesource.com/a/my/repo.git/')
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002784 self.assertEqual(cl.GetDescription(), 'desc1')
2785 self.assertEqual(cl.GetDescription(), 'desc1') # cache hit.
2786 self.assertEqual(cl.GetDescription(force=True), 'desc2')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002787
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002788 def test_print_current_creds(self):
2789 class CookiesAuthenticatorMock(object):
2790 def __init__(self):
2791 self.gitcookies = {
2792 'host.googlesource.com': ('user', 'pass'),
2793 'host-review.googlesource.com': ('user', 'pass'),
2794 }
2795 self.netrc = self
2796 self.netrc.hosts = {
2797 'github.com': ('user2', None, 'pass2'),
2798 'host2.googlesource.com': ('user3', None, 'pass'),
2799 }
2800 self.mock(git_cl.gerrit_util, 'CookiesAuthenticator',
2801 CookiesAuthenticatorMock)
2802 self.mock(sys, 'stdout', StringIO.StringIO())
2803 git_cl._GitCookiesChecker().print_current_creds(include_netrc=True)
2804 self.assertEqual(list(sys.stdout.getvalue().splitlines()), [
2805 ' Host\t User\t Which file',
2806 '============================\t=====\t===========',
2807 'host-review.googlesource.com\t user\t.gitcookies',
2808 ' host.googlesource.com\t user\t.gitcookies',
2809 ' host2.googlesource.com\tuser3\t .netrc',
2810 ])
2811 sys.stdout.buf = ''
2812 git_cl._GitCookiesChecker().print_current_creds(include_netrc=False)
2813 self.assertEqual(list(sys.stdout.getvalue().splitlines()), [
2814 ' Host\tUser\t Which file',
2815 '============================\t====\t===========',
2816 'host-review.googlesource.com\tuser\t.gitcookies',
2817 ' host.googlesource.com\tuser\t.gitcookies',
2818 ])
2819
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002820 def _common_creds_check_mocks(self):
2821 def exists_mock(path):
2822 dirname = os.path.dirname(path)
2823 if dirname == os.path.expanduser('~'):
2824 dirname = '~'
2825 base = os.path.basename(path)
2826 if base in ('.netrc', '.gitcookies'):
2827 return self._mocked_call('os.path.exists', '%s/%s' % (dirname, base))
2828 # git cl also checks for existence other files not relevant to this test.
2829 return None
2830 self.mock(os.path, 'exists', exists_mock)
2831 self.mock(sys, 'stdout', StringIO.StringIO())
2832
2833 def test_creds_check_gitcookies_not_configured(self):
2834 self._common_creds_check_mocks()
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002835 self.mock(git_cl._GitCookiesChecker, 'get_hosts_with_creds',
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01002836 lambda _, include_netrc=False: [])
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002837 self.calls = [
Aaron Gable8797cab2018-03-06 13:55:00 -08002838 ((['git', 'config', '--path', 'http.cookiefile'],), CERR1),
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002839 ((['git', 'config', '--global', 'http.cookiefile'],), CERR1),
2840 (('os.path.exists', '~/.netrc'), True),
2841 (('ask_for_data', 'Press Enter to setup .gitcookies, '
2842 'or Ctrl+C to abort'), ''),
2843 ((['git', 'config', '--global', 'http.cookiefile',
2844 os.path.expanduser('~/.gitcookies')], ), ''),
2845 ]
2846 self.assertEqual(0, git_cl.main(['creds-check']))
2847 self.assertRegexpMatches(
2848 sys.stdout.getvalue(),
2849 '^You seem to be using outdated .netrc for git credentials:')
2850 self.assertRegexpMatches(
2851 sys.stdout.getvalue(),
2852 '\nConfigured git to use .gitcookies from')
2853
2854 def test_creds_check_gitcookies_configured_custom_broken(self):
2855 self._common_creds_check_mocks()
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002856 self.mock(git_cl._GitCookiesChecker, 'get_hosts_with_creds',
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01002857 lambda _, include_netrc=False: [])
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002858 self.calls = [
Aaron Gable8797cab2018-03-06 13:55:00 -08002859 ((['git', 'config', '--path', 'http.cookiefile'],), CERR1),
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002860 ((['git', 'config', '--global', 'http.cookiefile'],),
2861 '/custom/.gitcookies'),
2862 (('os.path.exists', '/custom/.gitcookies'), False),
2863 (('ask_for_data', 'Reconfigure git to use default .gitcookies? '
2864 'Press Enter to reconfigure, or Ctrl+C to abort'), ''),
2865 ((['git', 'config', '--global', 'http.cookiefile',
2866 os.path.expanduser('~/.gitcookies')], ), ''),
2867 ]
2868 self.assertEqual(0, git_cl.main(['creds-check']))
2869 self.assertRegexpMatches(
2870 sys.stdout.getvalue(),
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002871 'WARNING: You have configured custom path to .gitcookies: ')
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002872 self.assertRegexpMatches(
2873 sys.stdout.getvalue(),
2874 'However, your configured .gitcookies file is missing.')
2875
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002876 def test_git_cl_comment_add_gerrit(self):
2877 self.mock(git_cl.gerrit_util, 'SetReview',
Aaron Gable636b13f2017-07-14 10:42:48 -07002878 lambda host, change, msg, ready:
2879 self._mocked_call('SetReview', host, change, msg, ready))
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002880 self.calls = [
2881 ((['git', 'symbolic-ref', 'HEAD'],), CERR1),
2882 ((['git', 'symbolic-ref', 'HEAD'],), CERR1),
2883 ((['git', 'config', 'rietveld.upstream-branch'],), CERR1),
2884 ((['git', 'branch', '-r'],), 'origin/HEAD -> origin/master\n'
2885 'origin/master'),
2886 ((['git', 'config', 'remote.origin.url'],),
2887 'https://chromium.googlesource.com/infra/infra'),
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002888 (('SetReview', 'chromium-review.googlesource.com', 'infra%2Finfra~10',
2889 'msg', None),
Aaron Gable636b13f2017-07-14 10:42:48 -07002890 None),
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002891 ]
2892 self.assertEqual(0, git_cl.main(['comment', '--gerrit', '-i', '10',
2893 '-a', 'msg']))
2894
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002895 def test_git_cl_comments_fetch_gerrit(self):
2896 self.mock(sys, 'stdout', StringIO.StringIO())
2897 self.calls = [
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002898 ((['git', 'config', 'branch.foo.gerritserver'],), ''),
2899 ((['git', 'config', 'branch.foo.merge'],), ''),
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002900 ((['git', 'config', 'rietveld.upstream-branch'],), CERR1),
2901 ((['git', 'branch', '-r'],), 'origin/HEAD -> origin/master\n'
2902 'origin/master'),
2903 ((['git', 'config', 'remote.origin.url'],),
2904 'https://chromium.googlesource.com/infra/infra'),
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002905 (('GetChangeDetail', 'chromium-review.googlesource.com',
2906 'infra%2Finfra~1',
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002907 ['MESSAGES', 'DETAILED_ACCOUNTS', 'CURRENT_REVISION',
2908 'CURRENT_COMMIT']), {
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002909 'owner': {'email': 'owner@example.com'},
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002910 'current_revision': 'ba5eba11',
2911 'revisions': {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002912 'deadbeaf': {
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002913 '_number': 1,
2914 },
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002915 'ba5eba11': {
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002916 '_number': 2,
2917 },
2918 },
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002919 'messages': [
2920 {
2921 u'_revision_number': 1,
2922 u'author': {
2923 u'_account_id': 1111084,
2924 u'email': u'commit-bot@chromium.org',
2925 u'name': u'Commit Bot'
2926 },
2927 u'date': u'2017-03-15 20:08:45.000000000',
2928 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046dc50b',
Dirk Prankef6a58802017-10-17 12:49:42 -07002929 u'message': u'Patch Set 1:\n\nDry run: CQ is trying the patch...',
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002930 u'tag': u'autogenerated:cq:dry-run'
2931 },
2932 {
2933 u'_revision_number': 2,
2934 u'author': {
2935 u'_account_id': 11151243,
2936 u'email': u'owner@example.com',
2937 u'name': u'owner'
2938 },
2939 u'date': u'2017-03-16 20:00:41.000000000',
2940 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2941 u'message': u'PTAL',
2942 },
2943 {
2944 u'_revision_number': 2,
2945 u'author': {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002946 u'_account_id': 148512,
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002947 u'email': u'reviewer@example.com',
2948 u'name': u'reviewer'
2949 },
2950 u'date': u'2017-03-17 05:19:37.500000000',
2951 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d4568',
2952 u'message': u'Patch Set 2: Code-Review+1',
2953 },
2954 ]
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002955 }),
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002956 (('GetChangeComments', 'chromium-review.googlesource.com',
2957 'infra%2Finfra~1'), {
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002958 '/COMMIT_MSG': [
2959 {
2960 'author': {'email': u'reviewer@example.com'},
2961 'updated': u'2017-03-17 05:19:37.500000000',
2962 'patch_set': 2,
2963 'side': 'REVISION',
2964 'message': 'Please include a bug link',
2965 },
2966 ],
2967 'codereview.settings': [
2968 {
2969 'author': {'email': u'owner@example.com'},
2970 'updated': u'2017-03-16 20:00:41.000000000',
2971 'patch_set': 2,
2972 'side': 'PARENT',
2973 'line': 42,
2974 'message': 'I removed this because it is bad',
2975 },
2976 ]
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002977 }),
2978 (('GetChangeRobotComments', 'chromium-review.googlesource.com',
2979 'infra%2Finfra~1'), {}),
2980 ((['git', 'config', 'branch.foo.gerritpatchset', '2'],), ''),
Leszek Swirski45b20c42018-09-17 17:05:26 +00002981 ] * 2 + [
2982 (('write_json', 'output.json', [
2983 {
2984 u'date': u'2017-03-16 20:00:41.000000',
2985 u'message': (
2986 u'PTAL\n' +
2987 u'\n' +
2988 u'codereview.settings\n' +
2989 u' Base, Line 42: https://chromium-review.googlesource.com/' +
2990 u'c/1/2/codereview.settings#b42\n' +
2991 u' I removed this because it is bad\n'),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002992 u'autogenerated': False,
Leszek Swirski45b20c42018-09-17 17:05:26 +00002993 u'approval': False,
2994 u'disapproval': False,
2995 u'sender': u'owner@example.com'
2996 }, {
2997 u'date': u'2017-03-17 05:19:37.500000',
2998 u'message': (
2999 u'Patch Set 2: Code-Review+1\n' +
3000 u'\n' +
3001 u'/COMMIT_MSG\n' +
3002 u' PS2, File comment: https://chromium-review.googlesource' +
3003 u'.com/c/1/2//COMMIT_MSG#\n' +
3004 u' Please include a bug link\n'),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00003005 u'autogenerated': False,
Leszek Swirski45b20c42018-09-17 17:05:26 +00003006 u'approval': False,
3007 u'disapproval': False,
3008 u'sender': u'reviewer@example.com'
3009 }
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003010 ]), '')
Leszek Swirski45b20c42018-09-17 17:05:26 +00003011 ]
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01003012 expected_comments_summary = [
3013 git_cl._CommentSummary(
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07003014 message=(
3015 u'PTAL\n' +
3016 u'\n' +
3017 u'codereview.settings\n' +
3018 u' Base, Line 42: https://chromium-review.googlesource.com/' +
3019 u'c/1/2/codereview.settings#b42\n' +
3020 u' I removed this because it is bad\n'),
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01003021 date=datetime.datetime(2017, 3, 16, 20, 0, 41, 0),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00003022 autogenerated=False,
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01003023 disapproval=False, approval=False, sender=u'owner@example.com'),
3024 git_cl._CommentSummary(
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07003025 message=(
3026 u'Patch Set 2: Code-Review+1\n' +
3027 u'\n' +
3028 u'/COMMIT_MSG\n' +
3029 u' PS2, File comment: https://chromium-review.googlesource.com/' +
3030 u'c/1/2//COMMIT_MSG#\n' +
3031 u' Please include a bug link\n'),
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01003032 date=datetime.datetime(2017, 3, 17, 5, 19, 37, 500000),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00003033 autogenerated=False,
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01003034 disapproval=False, approval=False, sender=u'reviewer@example.com'),
3035 ]
Quinten Yearsley0e617c02019-02-20 00:37:03 +00003036 cl = git_cl.Changelist(
Edward Lemurf38bc172019-09-03 21:02:13 +00003037 issue=1, branchref='refs/heads/foo')
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01003038 self.assertEqual(cl.GetCommentsSummary(), expected_comments_summary)
Quinten Yearsley0e617c02019-02-20 00:37:03 +00003039 self.mock(git_cl.Changelist, 'GetBranch', lambda _: 'foo')
3040 self.assertEqual(
3041 0, git_cl.main(['comments', '-i', '1', '-j', 'output.json']))
3042
3043 def test_git_cl_comments_robot_comments(self):
3044 # git cl comments also fetches robot comments (which are considered a type
3045 # of autogenerated comment), and unlike other types of comments, only robot
3046 # comments from the latest patchset are shown.
3047 self.mock(sys, 'stdout', StringIO.StringIO())
3048 self.calls = [
3049 ((['git', 'config', 'branch.foo.gerritserver'],), ''),
3050 ((['git', 'config', 'branch.foo.merge'],), ''),
3051 ((['git', 'config', 'rietveld.upstream-branch'],), CERR1),
3052 ((['git', 'branch', '-r'],), 'origin/HEAD -> origin/master\n'
3053 'origin/master'),
3054 ((['git', 'config', 'remote.origin.url'],),
3055 'https://chromium.googlesource.com/infra/infra'),
3056 (('GetChangeDetail', 'chromium-review.googlesource.com',
3057 'infra%2Finfra~1',
3058 ['MESSAGES', 'DETAILED_ACCOUNTS', 'CURRENT_REVISION',
3059 'CURRENT_COMMIT']), {
3060 'owner': {'email': 'owner@example.com'},
3061 'current_revision': 'ba5eba11',
3062 'revisions': {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003063 'deadbeaf': {
Quinten Yearsley0e617c02019-02-20 00:37:03 +00003064 '_number': 1,
3065 },
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003066 'ba5eba11': {
Quinten Yearsley0e617c02019-02-20 00:37:03 +00003067 '_number': 2,
3068 },
3069 },
3070 'messages': [
3071 {
3072 u'_revision_number': 1,
3073 u'author': {
3074 u'_account_id': 1111084,
3075 u'email': u'commit-bot@chromium.org',
3076 u'name': u'Commit Bot'
3077 },
3078 u'date': u'2017-03-15 20:08:45.000000000',
3079 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046dc50b',
3080 u'message': u'Patch Set 1:\n\nDry run: CQ is trying the patch...',
3081 u'tag': u'autogenerated:cq:dry-run'
3082 },
3083 {
3084 u'_revision_number': 1,
3085 u'author': {
3086 u'_account_id': 123,
3087 u'email': u'tricium@serviceaccount.com',
3088 u'name': u'Tricium'
3089 },
3090 u'date': u'2017-03-16 20:00:41.000000000',
3091 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
3092 u'message': u'(1 comment)',
3093 u'tag': u'autogenerated:tricium',
3094 },
3095 {
3096 u'_revision_number': 1,
3097 u'author': {
3098 u'_account_id': 123,
3099 u'email': u'tricium@serviceaccount.com',
3100 u'name': u'Tricium'
3101 },
3102 u'date': u'2017-03-16 20:00:41.000000000',
3103 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
3104 u'message': u'(1 comment)',
3105 u'tag': u'autogenerated:tricium',
3106 },
3107 {
3108 u'_revision_number': 2,
3109 u'author': {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003110 u'_account_id': 123,
Quinten Yearsley0e617c02019-02-20 00:37:03 +00003111 u'email': u'tricium@serviceaccount.com',
3112 u'name': u'reviewer'
3113 },
3114 u'date': u'2017-03-17 05:30:37.000000000',
3115 u'tag': u'autogenerated:tricium',
3116 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d4568',
3117 u'message': u'(1 comment)',
3118 },
3119 ]
3120 }),
3121 (('GetChangeComments', 'chromium-review.googlesource.com',
3122 'infra%2Finfra~1'), {}),
3123 (('GetChangeRobotComments', 'chromium-review.googlesource.com',
3124 'infra%2Finfra~1'), {
3125 'codereview.settings': [
3126 {
3127 u'author': {u'email': u'tricium@serviceaccount.com'},
3128 u'updated': u'2017-03-17 05:30:37.000000000',
3129 u'robot_run_id': u'5565031076855808',
3130 u'robot_id': u'Linter/Category',
3131 u'tag': u'autogenerated:tricium',
3132 u'patch_set': 2,
3133 u'side': u'REVISION',
3134 u'message': u'Linter warning message text',
3135 u'line': 32,
3136 },
3137 ],
3138 }),
3139 ((['git', 'config', 'branch.foo.gerritpatchset', '2'],), ''),
3140 ]
3141 expected_comments_summary = [
3142 git_cl._CommentSummary(date=datetime.datetime(2017, 3, 17, 5, 30, 37),
3143 message=(
3144 u'(1 comment)\n\ncodereview.settings\n'
3145 u' PS2, Line 32: https://chromium-review.googlesource.com/'
3146 u'c/1/2/codereview.settings#32\n'
3147 u' Linter warning message text\n'),
3148 sender=u'tricium@serviceaccount.com',
3149 autogenerated=True, approval=False, disapproval=False)
3150 ]
3151 cl = git_cl.Changelist(
Edward Lemurf38bc172019-09-03 21:02:13 +00003152 issue=1, branchref='refs/heads/foo')
Quinten Yearsley0e617c02019-02-20 00:37:03 +00003153 self.assertEqual(cl.GetCommentsSummary(), expected_comments_summary)
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003154
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00003155 def test_get_remote_url_with_mirror(self):
3156 original_os_path_isdir = os.path.isdir
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003157
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00003158 def selective_os_path_isdir_mock(path):
3159 if path == '/cache/this-dir-exists':
3160 return self._mocked_call('os.path.isdir', path)
3161 return original_os_path_isdir(path)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003162
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00003163 self.mock(os.path, 'isdir', selective_os_path_isdir_mock)
3164
3165 url = 'https://chromium.googlesource.com/my/repo'
3166 self.calls = [
3167 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
3168 ((['git', 'config', 'branch.master.merge'],), 'master'),
3169 ((['git', 'config', 'branch.master.remote'],), 'origin'),
3170 ((['git', 'config', 'remote.origin.url'],),
3171 '/cache/this-dir-exists'),
3172 (('os.path.isdir', '/cache/this-dir-exists'),
3173 True),
3174 # Runs in /cache/this-dir-exists.
3175 ((['git', 'config', 'remote.origin.url'],),
3176 url),
3177 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00003178 cl = git_cl.Changelist(issue=1)
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00003179 self.assertEqual(cl.GetRemoteUrl(), url)
3180 self.assertEqual(cl.GetRemoteUrl(), url) # Must be cached.
3181
Edward Lemur298f2cf2019-02-22 21:40:39 +00003182 def test_get_remote_url_non_existing_mirror(self):
3183 original_os_path_isdir = os.path.isdir
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003184
Edward Lemur298f2cf2019-02-22 21:40:39 +00003185 def selective_os_path_isdir_mock(path):
3186 if path == '/cache/this-dir-doesnt-exist':
3187 return self._mocked_call('os.path.isdir', path)
3188 return original_os_path_isdir(path)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003189
Edward Lemur298f2cf2019-02-22 21:40:39 +00003190 self.mock(os.path, 'isdir', selective_os_path_isdir_mock)
3191 self.mock(logging, 'error',
3192 lambda fmt, *a: self._mocked_call('logging.error', fmt % a))
3193
3194 self.calls = [
3195 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
3196 ((['git', 'config', 'branch.master.merge'],), 'master'),
3197 ((['git', 'config', 'branch.master.remote'],), 'origin'),
3198 ((['git', 'config', 'remote.origin.url'],),
3199 '/cache/this-dir-doesnt-exist'),
3200 (('os.path.isdir', '/cache/this-dir-doesnt-exist'),
3201 False),
3202 (('logging.error',
Daniel Bratell4a60db42019-09-16 17:02:52 +00003203 'Remote "origin" for branch "master" points to'
3204 ' "/cache/this-dir-doesnt-exist", but it doesn\'t exist.'), None),
Edward Lemur298f2cf2019-02-22 21:40:39 +00003205 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00003206 cl = git_cl.Changelist(issue=1)
Edward Lemur298f2cf2019-02-22 21:40:39 +00003207 self.assertIsNone(cl.GetRemoteUrl())
3208
3209 def test_get_remote_url_misconfigured_mirror(self):
3210 original_os_path_isdir = os.path.isdir
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003211
Edward Lemur298f2cf2019-02-22 21:40:39 +00003212 def selective_os_path_isdir_mock(path):
3213 if path == '/cache/this-dir-exists':
3214 return self._mocked_call('os.path.isdir', path)
3215 return original_os_path_isdir(path)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003216
Edward Lemur298f2cf2019-02-22 21:40:39 +00003217 self.mock(os.path, 'isdir', selective_os_path_isdir_mock)
3218 self.mock(logging, 'error',
3219 lambda *a: self._mocked_call('logging.error', *a))
3220
3221 self.calls = [
3222 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
3223 ((['git', 'config', 'branch.master.merge'],), 'master'),
3224 ((['git', 'config', 'branch.master.remote'],), 'origin'),
3225 ((['git', 'config', 'remote.origin.url'],),
3226 '/cache/this-dir-exists'),
3227 (('os.path.isdir', '/cache/this-dir-exists'), True),
3228 # Runs in /cache/this-dir-exists.
3229 ((['git', 'config', 'remote.origin.url'],), ''),
3230 (('logging.error',
3231 'Remote "%(remote)s" for branch "%(branch)s" points to '
3232 '"%(cache_path)s", but it is misconfigured.\n'
3233 '"%(cache_path)s" must be a git repo and must have a remote named '
3234 '"%(remote)s" pointing to the git host.', {
3235 'remote': 'origin',
3236 'cache_path': '/cache/this-dir-exists',
3237 'branch': 'master'}
3238 ), None),
3239 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00003240 cl = git_cl.Changelist(issue=1)
Edward Lemur298f2cf2019-02-22 21:40:39 +00003241 self.assertIsNone(cl.GetRemoteUrl())
3242
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00003243 def test_gerrit_change_identifier_with_project(self):
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00003244 self.calls = [
3245 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
3246 ((['git', 'config', 'branch.master.merge'],), 'master'),
3247 ((['git', 'config', 'branch.master.remote'],), 'origin'),
3248 ((['git', 'config', 'remote.origin.url'],),
3249 'https://chromium.googlesource.com/a/my/repo.git/'),
3250 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00003251 cl = git_cl.Changelist(issue=123456)
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00003252 self.assertEqual(cl._GerritChangeIdentifier(), 'my%2Frepo~123456')
3253
3254 def test_gerrit_change_identifier_without_project(self):
3255 self.calls = [
3256 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
3257 ((['git', 'config', 'branch.master.merge'],), 'master'),
3258 ((['git', 'config', 'branch.master.remote'],), 'origin'),
3259 ((['git', 'config', 'remote.origin.url'],), CERR1),
3260 ]
Edward Lemurf38bc172019-09-03 21:02:13 +00003261 cl = git_cl.Changelist(issue=123456)
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00003262 self.assertEqual(cl._GerritChangeIdentifier(), '123456')
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00003263
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003264
maruel@chromium.orgddd59412011-11-30 14:20:38 +00003265if __name__ == '__main__':
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +01003266 logging.basicConfig(
3267 level=logging.DEBUG if '-v' in sys.argv else logging.ERROR)
maruel@chromium.orgddd59412011-11-30 14:20:38 +00003268 unittest.main()