blob: 5c715ad45a98721ae54c1e19d77dac432d4e9d2e [file] [log] [blame]
Josip Sokcevic4de5dea2022-03-23 21:15:14 +00001#!/usr/bin/env python3
maruel@chromium.org3bbf2942012-01-10 16:52:06 +00002# Copyright (c) 2012 The Chromium Authors. All rights reserved.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00003# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5
6"""Enables directory-specific presubmit checks to run at upload and/or commit.
7"""
8
Raul Tambre80ee78e2019-05-06 22:41:05 +00009from __future__ import print_function
10
Saagar Sanghavi99816902020-08-11 22:41:25 +000011__version__ = '2.0.0'
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000012
13# TODO(joi) Add caching where appropriate/needed. The API is designed to allow
14# caching (between all different invocations of presubmit scripts for a given
15# change). We should add it as our presubmit scripts start feeling slow.
16
Edward Lemura5799e32020-01-17 19:26:51 +000017import argparse
Takeshi Yoshino07a6bea2017-08-02 02:44:06 +090018import ast # Exposed through the API.
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +000019import contextlib
Yoshisato Yanagisawa406de132018-06-29 05:43:25 +000020import cpplint
dcheng091b7db2016-06-16 01:27:51 -070021import fnmatch # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000022import glob
asvitkine@chromium.org15169952011-09-27 14:30:53 +000023import inspect
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +000024import itertools
maruel@chromium.org4f6852c2012-04-20 20:39:20 +000025import json # Exposed through the API.
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +000026import logging
ilevy@chromium.orgbc117312013-04-20 03:57:56 +000027import multiprocessing
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000028import os # Somewhat exposed through the API.
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +000029import random
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000030import re # Exposed through the API.
Edward Lesmes8e282792018-04-03 18:50:29 -040031import signal
Allen Webbfe7d7092021-05-18 02:05:49 +000032import six
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000033import sys # Parts exposed through API.
34import tempfile # Exposed through the API.
Edward Lesmes8e282792018-04-03 18:50:29 -040035import threading
jam@chromium.org2a891dc2009-08-20 20:33:37 +000036import time
Edward Lemurde9e3ca2019-10-24 21:13:31 +000037import traceback
maruel@chromium.org1487d532009-06-06 00:22:57 +000038import unittest # Exposed through the API.
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +000039from warnings import warn
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000040
41# Local imports.
maruel@chromium.org35625c72011-03-23 17:34:02 +000042import fix_encoding
Yoshisato Yanagisawa04600b42019-03-15 03:03:41 +000043import gclient_paths # Exposed through the API
44import gclient_utils
Aaron Gableb584c4f2017-04-26 16:28:08 -070045import git_footers
tandrii@chromium.org015ebae2016-04-25 19:37:22 +000046import gerrit_util
Edward Lesmes9ce03f82021-01-12 20:13:31 +000047import owners as owners_db
48import owners_client
Jochen Eisinger76f5fc62017-04-07 16:27:46 +020049import owners_finder
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000050import presubmit_canned_checks
Saagar Sanghavi9949ab72020-07-20 20:56:40 +000051import rdb_wrapper
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +000052import scm
maruel@chromium.org84f4fe32011-04-06 13:26:45 +000053import subprocess2 as subprocess # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000054
Edward Lemur16af3562019-10-17 22:11:33 +000055if sys.version_info.major == 2:
56 # TODO(1009814): Expose urllib2 only through urllib_request and urllib_error
57 import urllib2 # Exposed through the API.
58 import urlparse
59 import urllib2 as urllib_request
60 import urllib2 as urllib_error
61else:
62 import urllib.parse as urlparse
63 import urllib.request as urllib_request
64 import urllib.error as urllib_error
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000065
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +000066# Ask for feedback only once in program lifetime.
67_ASKED_FOR_FEEDBACK = False
68
Edward Lemurecc27072020-01-06 16:42:34 +000069def time_time():
70 # Use this so that it can be mocked in tests without interfering with python
71 # system machinery.
72 return time.time()
73
74
maruel@chromium.org899e1c12011-04-07 17:03:18 +000075class PresubmitFailure(Exception):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000076 pass
77
78
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000079class CommandData(object):
Edward Lemur940c2822019-08-23 00:34:25 +000080 def __init__(self, name, cmd, kwargs, message, python3=False):
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000081 self.name = name
82 self.cmd = cmd
Edward Lesmes8e282792018-04-03 18:50:29 -040083 self.stdin = kwargs.get('stdin', None)
Edward Lemur2d6b67c2019-08-23 22:25:41 +000084 self.kwargs = kwargs.copy()
Edward Lesmes8e282792018-04-03 18:50:29 -040085 self.kwargs['stdout'] = subprocess.PIPE
86 self.kwargs['stderr'] = subprocess.STDOUT
87 self.kwargs['stdin'] = subprocess.PIPE
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000088 self.message = message
89 self.info = None
Edward Lemur940c2822019-08-23 00:34:25 +000090 self.python3 = python3
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000091
ilevy@chromium.orgbc117312013-04-20 03:57:56 +000092
Edward Lesmes8e282792018-04-03 18:50:29 -040093# Adapted from
94# https://github.com/google/gtest-parallel/blob/master/gtest_parallel.py#L37
95#
96# An object that catches SIGINT sent to the Python process and notices
97# if processes passed to wait() die by SIGINT (we need to look for
98# both of those cases, because pressing Ctrl+C can result in either
99# the main process or one of the subprocesses getting the signal).
100#
101# Before a SIGINT is seen, wait(p) will simply call p.wait() and
102# return the result. Once a SIGINT has been seen (in the main process
103# or a subprocess, including the one the current call is waiting for),
Edward Lemur9a5bb612019-09-26 02:01:52 +0000104# wait(p) will call p.terminate().
Edward Lesmes8e282792018-04-03 18:50:29 -0400105class SigintHandler(object):
Edward Lesmes8e282792018-04-03 18:50:29 -0400106 sigint_returncodes = {-signal.SIGINT, # Unix
107 -1073741510, # Windows
108 }
109 def __init__(self):
110 self.__lock = threading.Lock()
111 self.__processes = set()
112 self.__got_sigint = False
Edward Lemur9a5bb612019-09-26 02:01:52 +0000113 self.__previous_signal = signal.signal(signal.SIGINT, self.interrupt)
Edward Lesmes8e282792018-04-03 18:50:29 -0400114
115 def __on_sigint(self):
116 self.__got_sigint = True
117 while self.__processes:
118 try:
119 self.__processes.pop().terminate()
120 except OSError:
121 pass
122
Edward Lemur9a5bb612019-09-26 02:01:52 +0000123 def interrupt(self, signal_num, frame):
Edward Lesmes8e282792018-04-03 18:50:29 -0400124 with self.__lock:
125 self.__on_sigint()
Edward Lemur9a5bb612019-09-26 02:01:52 +0000126 self.__previous_signal(signal_num, frame)
Edward Lesmes8e282792018-04-03 18:50:29 -0400127
128 def got_sigint(self):
129 with self.__lock:
130 return self.__got_sigint
131
132 def wait(self, p, stdin):
133 with self.__lock:
134 if self.__got_sigint:
135 p.terminate()
136 self.__processes.add(p)
137 stdout, stderr = p.communicate(stdin)
138 code = p.returncode
139 with self.__lock:
140 self.__processes.discard(p)
141 if code in self.sigint_returncodes:
142 self.__on_sigint()
Edward Lesmes8e282792018-04-03 18:50:29 -0400143 return stdout, stderr
144
145sigint_handler = SigintHandler()
146
147
Edward Lemurecc27072020-01-06 16:42:34 +0000148class Timer(object):
149 def __init__(self, timeout, fn):
150 self.completed = False
151 self._fn = fn
152 self._timer = threading.Timer(timeout, self._onTimer) if timeout else None
153
154 def __enter__(self):
155 if self._timer:
156 self._timer.start()
157 return self
158
159 def __exit__(self, _type, _value, _traceback):
160 if self._timer:
161 self._timer.cancel()
162
163 def _onTimer(self):
164 self._fn()
165 self.completed = True
166
167
Edward Lesmes8e282792018-04-03 18:50:29 -0400168class ThreadPool(object):
Edward Lemurecc27072020-01-06 16:42:34 +0000169 def __init__(self, pool_size=None, timeout=None):
170 self.timeout = timeout
Edward Lesmes8e282792018-04-03 18:50:29 -0400171 self._pool_size = pool_size or multiprocessing.cpu_count()
172 self._messages = []
173 self._messages_lock = threading.Lock()
174 self._tests = []
175 self._tests_lock = threading.Lock()
176 self._nonparallel_tests = []
177
Edward Lemurecc27072020-01-06 16:42:34 +0000178 def _GetCommand(self, test):
Edward Lemur940c2822019-08-23 00:34:25 +0000179 vpython = 'vpython'
180 if test.python3:
181 vpython += '3'
182 if sys.platform == 'win32':
183 vpython += '.bat'
Edward Lesmes8e282792018-04-03 18:50:29 -0400184
185 cmd = test.cmd
186 if cmd[0] == 'python':
187 cmd = list(cmd)
188 cmd[0] = vpython
189 elif cmd[0].endswith('.py'):
190 cmd = [vpython] + cmd
191
Edward Lemur336e51f2019-11-14 21:42:04 +0000192 # On Windows, scripts on the current directory take precedence over PATH, so
193 # that when testing depot_tools on Windows, calling `vpython.bat` will
194 # execute the copy of vpython of the depot_tools under test instead of the
195 # one in the bot.
196 # As a workaround, we run the tests from the parent directory instead.
197 if (cmd[0] == vpython and
198 'cwd' in test.kwargs and
199 os.path.basename(test.kwargs['cwd']) == 'depot_tools'):
200 test.kwargs['cwd'] = os.path.dirname(test.kwargs['cwd'])
201 cmd[1] = os.path.join('depot_tools', cmd[1])
202
Edward Lemurecc27072020-01-06 16:42:34 +0000203 return cmd
204
205 def _RunWithTimeout(self, cmd, stdin, kwargs):
206 p = subprocess.Popen(cmd, **kwargs)
207 with Timer(self.timeout, p.terminate) as timer:
208 stdout, _ = sigint_handler.wait(p, stdin)
Josip Sokcevic6635baf2021-11-19 02:04:39 +0000209 stdout = stdout.decode('utf-8', 'ignore')
Edward Lemurecc27072020-01-06 16:42:34 +0000210 if timer.completed:
211 stdout = 'Process timed out after %ss\n%s' % (self.timeout, stdout)
Josip Sokcevic6635baf2021-11-19 02:04:39 +0000212 return p.returncode, stdout
Edward Lemurecc27072020-01-06 16:42:34 +0000213
214 def CallCommand(self, test):
215 """Runs an external program.
216
Edward Lemura5799e32020-01-17 19:26:51 +0000217 This function converts invocation of .py files and invocations of 'python'
Edward Lemurecc27072020-01-06 16:42:34 +0000218 to vpython invocations.
219 """
220 cmd = self._GetCommand(test)
Edward Lesmes8e282792018-04-03 18:50:29 -0400221 try:
Edward Lemurecc27072020-01-06 16:42:34 +0000222 start = time_time()
223 returncode, stdout = self._RunWithTimeout(cmd, test.stdin, test.kwargs)
224 duration = time_time() - start
Edward Lemur7cf94382019-11-15 22:36:41 +0000225 except Exception:
Edward Lemurecc27072020-01-06 16:42:34 +0000226 duration = time_time() - start
Edward Lesmes8e282792018-04-03 18:50:29 -0400227 return test.message(
Edward Lemur7cf94382019-11-15 22:36:41 +0000228 '%s\n%s exec failure (%4.2fs)\n%s' % (
229 test.name, ' '.join(cmd), duration, traceback.format_exc()))
Edward Lemurde9e3ca2019-10-24 21:13:31 +0000230
Edward Lemurecc27072020-01-06 16:42:34 +0000231 if returncode != 0:
Edward Lesmes8e282792018-04-03 18:50:29 -0400232 return test.message(
Edward Lemur7cf94382019-11-15 22:36:41 +0000233 '%s\n%s (%4.2fs) failed\n%s' % (
234 test.name, ' '.join(cmd), duration, stdout))
Edward Lemurecc27072020-01-06 16:42:34 +0000235
Edward Lesmes8e282792018-04-03 18:50:29 -0400236 if test.info:
Edward Lemur7cf94382019-11-15 22:36:41 +0000237 return test.info('%s\n%s (%4.2fs)' % (test.name, ' '.join(cmd), duration))
Edward Lesmes8e282792018-04-03 18:50:29 -0400238
239 def AddTests(self, tests, parallel=True):
240 if parallel:
241 self._tests.extend(tests)
242 else:
243 self._nonparallel_tests.extend(tests)
244
245 def RunAsync(self):
246 self._messages = []
247
248 def _WorkerFn():
249 while True:
250 test = None
251 with self._tests_lock:
252 if not self._tests:
253 break
254 test = self._tests.pop()
255 result = self.CallCommand(test)
256 if result:
257 with self._messages_lock:
258 self._messages.append(result)
259
260 def _StartDaemon():
261 t = threading.Thread(target=_WorkerFn)
262 t.daemon = True
263 t.start()
264 return t
265
266 while self._nonparallel_tests:
267 test = self._nonparallel_tests.pop()
268 result = self.CallCommand(test)
269 if result:
270 self._messages.append(result)
271
272 if self._tests:
273 threads = [_StartDaemon() for _ in range(self._pool_size)]
274 for worker in threads:
275 worker.join()
276
277 return self._messages
278
279
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000280def normpath(path):
281 '''Version of os.path.normpath that also changes backward slashes to
282 forward slashes when not running on Windows.
283 '''
284 # This is safe to always do because the Windows version of os.path.normpath
285 # will replace forward slashes with backward slashes.
286 path = path.replace(os.sep, '/')
287 return os.path.normpath(path)
288
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000289
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000290def _RightHandSideLinesImpl(affected_files):
291 """Implements RightHandSideLines for InputApi and GclChange."""
292 for af in affected_files:
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000293 lines = af.ChangedContents()
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000294 for line in lines:
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000295 yield (af, line[0], line[1])
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000296
297
Edward Lemur6eb1d322020-02-27 22:20:15 +0000298def prompt_should_continue(prompt_string):
299 sys.stdout.write(prompt_string)
Dirk Pranke7288f882021-06-03 18:01:30 +0000300 sys.stdout.flush()
Edward Lemur6eb1d322020-02-27 22:20:15 +0000301 response = sys.stdin.readline().strip().lower()
302 return response in ('y', 'yes')
dpranke@chromium.org5ac21012011-03-16 02:58:25 +0000303
304
Josip Sokcevice293d3d2022-02-16 22:52:15 +0000305def _ShouldRunPresubmit(script_text, use_python3):
306 """Try to figure out whether these presubmit checks should be run under
307 python2 or python3. We need to do this without actually trying to
308 compile the text, since the text might compile in one but not the
309 other.
310
311 Args:
312 script_text: The text of the presubmit script.
313 use_python3: if true, will use python3 instead of python2 by default
314 if USE_PYTHON3 is not specified.
315
316 Return:
317 A boolean if presubmit should be executed
318 """
319 m = re.search('^USE_PYTHON3 = (True|False)$', script_text, flags=re.MULTILINE)
320 if m:
321 use_python3 = m.group(1) == 'True'
322
323 return ((sys.version_info.major == 2) and not use_python3) or \
324 ((sys.version_info.major == 3) and use_python3)
325
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000326# Top level object so multiprocessing can pickle
327# Public access through OutputApi object.
328class _PresubmitResult(object):
329 """Base class for result objects."""
330 fatal = False
331 should_prompt = False
332
333 def __init__(self, message, items=None, long_text=''):
334 """
335 message: A short one-line message to indicate errors.
336 items: A list of short strings to indicate where errors occurred.
337 long_text: multi-line text output, e.g. from another tool
338 """
Bruce Dawsondb8622b2022-04-03 15:38:12 +0000339 self._message = _PresubmitResult._ensure_str(message)
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000340 self._items = items or []
Tom McKee61c72652021-07-20 11:56:32 +0000341 self._long_text = _PresubmitResult._ensure_str(long_text.rstrip())
342
343 @staticmethod
344 def _ensure_str(val):
345 """
346 val: A "stringish" value. Can be any of str, unicode or bytes.
347 returns: A str after applying encoding/decoding as needed.
348 Assumes/uses UTF-8 for relevant inputs/outputs.
349
350 We'd prefer to use six.ensure_str but our copy of six is old :(
351 """
352 if isinstance(val, str):
353 return val
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +0000354
Tom McKee61c72652021-07-20 11:56:32 +0000355 if six.PY2 and isinstance(val, unicode):
356 return val.encode()
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +0000357
358 if six.PY3 and isinstance(val, bytes):
Tom McKee61c72652021-07-20 11:56:32 +0000359 return val.decode()
360 raise ValueError("Unknown string type %s" % type(val))
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000361
Edward Lemur6eb1d322020-02-27 22:20:15 +0000362 def handle(self):
363 sys.stdout.write(self._message)
364 sys.stdout.write('\n')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000365 for index, item in enumerate(self._items):
Edward Lemur6eb1d322020-02-27 22:20:15 +0000366 sys.stdout.write(' ')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000367 # Write separately in case it's unicode.
Edward Lemur6eb1d322020-02-27 22:20:15 +0000368 sys.stdout.write(str(item))
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000369 if index < len(self._items) - 1:
Edward Lemur6eb1d322020-02-27 22:20:15 +0000370 sys.stdout.write(' \\')
371 sys.stdout.write('\n')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000372 if self._long_text:
Edward Lemur6eb1d322020-02-27 22:20:15 +0000373 sys.stdout.write('\n***************\n')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000374 # Write separately in case it's unicode.
Tom McKee61c72652021-07-20 11:56:32 +0000375 sys.stdout.write(self._long_text)
Edward Lemur6eb1d322020-02-27 22:20:15 +0000376 sys.stdout.write('\n***************\n')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000377
Debrian Figueroadd2737e2019-06-21 23:50:13 +0000378 def json_format(self):
379 return {
380 'message': self._message,
Debrian Figueroa6095d402019-06-28 18:47:18 +0000381 'items': [str(item) for item in self._items],
Debrian Figueroadd2737e2019-06-21 23:50:13 +0000382 'long_text': self._long_text,
383 'fatal': self.fatal
384 }
385
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000386
387# Top level object so multiprocessing can pickle
388# Public access through OutputApi object.
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000389class _PresubmitError(_PresubmitResult):
390 """A hard presubmit error."""
391 fatal = True
392
393
394# Top level object so multiprocessing can pickle
395# Public access through OutputApi object.
396class _PresubmitPromptWarning(_PresubmitResult):
397 """An warning that prompts the user if they want to continue."""
398 should_prompt = True
399
400
401# Top level object so multiprocessing can pickle
402# Public access through OutputApi object.
403class _PresubmitNotifyResult(_PresubmitResult):
404 """Just print something to the screen -- but it's not even a warning."""
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000405
406
407# Top level object so multiprocessing can pickle
408# Public access through OutputApi object.
409class _MailTextResult(_PresubmitResult):
410 """A warning that should be included in the review request email."""
411 def __init__(self, *args, **kwargs):
412 super(_MailTextResult, self).__init__()
413 raise NotImplementedError()
414
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000415class GerritAccessor(object):
416 """Limited Gerrit functionality for canned presubmit checks to work.
417
418 To avoid excessive Gerrit calls, caches the results.
419 """
420
Edward Lesmeseb1bd622021-03-01 19:54:07 +0000421 def __init__(self, url=None, project=None, branch=None):
422 self.host = urlparse.urlparse(url).netloc if url else None
423 self.project = project
424 self.branch = branch
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000425 self.cache = {}
Edward Lesmes8170c292021-03-19 20:04:43 +0000426 self.code_owners_enabled = None
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000427
428 def _FetchChangeDetail(self, issue):
429 # Separate function to be easily mocked in tests.
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +0100430 try:
431 return gerrit_util.GetChangeDetail(
432 self.host, str(issue),
Aaron Gable6f5a8d92017-04-18 14:49:05 -0700433 ['ALL_REVISIONS', 'DETAILED_LABELS', 'ALL_COMMITS'])
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +0100434 except gerrit_util.GerritError as e:
435 if e.http_status == 404:
436 raise Exception('Either Gerrit issue %s doesn\'t exist, or '
437 'no credentials to fetch issue details' % issue)
438 raise
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000439
440 def GetChangeInfo(self, issue):
441 """Returns labels and all revisions (patchsets) for this issue.
442
443 The result is a dictionary according to Gerrit REST Api.
444 https://gerrit-review.googlesource.com/Documentation/rest-api.html
445
446 However, API isn't very clear what's inside, so see tests for example.
447 """
448 assert issue
449 cache_key = int(issue)
450 if cache_key not in self.cache:
451 self.cache[cache_key] = self._FetchChangeDetail(issue)
452 return self.cache[cache_key]
453
454 def GetChangeDescription(self, issue, patchset=None):
455 """If patchset is none, fetches current patchset."""
456 info = self.GetChangeInfo(issue)
457 # info is a reference to cache. We'll modify it here adding description to
458 # it to the right patchset, if it is not yet there.
459
460 # Find revision info for the patchset we want.
461 if patchset is not None:
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +0000462 for rev, rev_info in info['revisions'].items():
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000463 if str(rev_info['_number']) == str(patchset):
464 break
465 else:
466 raise Exception('patchset %s doesn\'t exist in issue %s' % (
467 patchset, issue))
468 else:
469 rev = info['current_revision']
470 rev_info = info['revisions'][rev]
471
Andrii Shyshkalov9c3a4642017-01-24 17:41:22 +0100472 return rev_info['commit']['message']
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000473
Mun Yong Jang603d01e2017-12-19 16:38:30 -0800474 def GetDestRef(self, issue):
475 ref = self.GetChangeInfo(issue)['branch']
476 if not ref.startswith('refs/'):
477 # NOTE: it is possible to create 'refs/x' branch,
478 # aka 'refs/heads/refs/x'. However, this is ill-advised.
479 ref = 'refs/heads/%s' % ref
480 return ref
481
Edward Lesmes02d4b822020-11-11 00:37:35 +0000482 def _GetApproversForLabel(self, issue, label):
483 change_info = self.GetChangeInfo(issue)
484 label_info = change_info.get('labels', {}).get(label, {})
485 values = label_info.get('values', {}).keys()
486 if not values:
487 return []
488 max_value = max(int(v) for v in values)
489 return [v for v in label_info.get('all', [])
490 if v.get('value', 0) == max_value]
491
Edward Lesmesc4566172021-03-19 16:55:13 +0000492 def IsBotCommitApproved(self, issue):
493 return bool(self._GetApproversForLabel(issue, 'Bot-Commit'))
494
Edward Lesmescf49cb82020-11-11 01:08:36 +0000495 def IsOwnersOverrideApproved(self, issue):
496 return bool(self._GetApproversForLabel(issue, 'Owners-Override'))
497
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000498 def GetChangeOwner(self, issue):
499 return self.GetChangeInfo(issue)['owner']['email']
500
501 def GetChangeReviewers(self, issue, approving_only=True):
Aaron Gable8b478f02017-07-31 15:33:19 -0700502 changeinfo = self.GetChangeInfo(issue)
503 if approving_only:
Edward Lesmes02d4b822020-11-11 00:37:35 +0000504 reviewers = self._GetApproversForLabel(issue, 'Code-Review')
Aaron Gable8b478f02017-07-31 15:33:19 -0700505 else:
506 reviewers = changeinfo.get('reviewers', {}).get('REVIEWER', [])
507 return [r.get('email') for r in reviewers]
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000508
Edward Lemure4d329c2020-02-03 20:41:18 +0000509 def UpdateDescription(self, description, issue):
510 gerrit_util.SetCommitMessage(self.host, issue, description, notify='NONE')
511
Edward Lesmes8170c292021-03-19 20:04:43 +0000512 def IsCodeOwnersEnabledOnRepo(self):
513 if self.code_owners_enabled is None:
514 self.code_owners_enabled = gerrit_util.IsCodeOwnersEnabledOnRepo(
Edward Lesmes392c4072021-03-19 21:58:45 +0000515 self.host, self.project)
Edward Lesmes8170c292021-03-19 20:04:43 +0000516 return self.code_owners_enabled
517
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000518
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000519class OutputApi(object):
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000520 """An instance of OutputApi gets passed to presubmit scripts so that they
521 can output various types of results.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000522 """
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000523 PresubmitResult = _PresubmitResult
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000524 PresubmitError = _PresubmitError
525 PresubmitPromptWarning = _PresubmitPromptWarning
526 PresubmitNotifyResult = _PresubmitNotifyResult
527 MailTextResult = _MailTextResult
528
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000529 def __init__(self, is_committing):
530 self.is_committing = is_committing
Daniel Cheng7227d212017-11-17 08:12:37 -0800531 self.more_cc = []
532
533 def AppendCC(self, cc):
534 """Appends a user to cc for this change."""
535 self.more_cc.append(cc)
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000536
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000537 def PresubmitPromptOrNotify(self, *args, **kwargs):
538 """Warn the user when uploading, but only notify if committing."""
539 if self.is_committing:
540 return self.PresubmitNotifyResult(*args, **kwargs)
541 return self.PresubmitPromptWarning(*args, **kwargs)
542
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000543
544class InputApi(object):
545 """An instance of this object is passed to presubmit scripts so they can
546 know stuff about the change they're looking at.
547 """
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000548 # Method could be a function
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800549 # pylint: disable=no-self-use
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000550
maruel@chromium.org3410d912009-06-09 20:56:16 +0000551 # File extensions that are considered source files from a style guide
552 # perspective. Don't modify this list from a presubmit script!
maruel@chromium.orgc33455a2011-06-24 19:14:18 +0000553 #
554 # Files without an extension aren't included in the list. If you want to
local_bot30f774e2020-06-25 18:23:34 +0000555 # filter them as source files, add r'(^|.*?[\\\/])[^.]+$' to the allow list.
local_bot64021412020-07-08 21:05:39 +0000556 # Note that ALL CAPS files are skipped in DEFAULT_FILES_TO_SKIP below.
557 DEFAULT_FILES_TO_CHECK = (
maruel@chromium.org3410d912009-06-09 20:56:16 +0000558 # C++ and friends
Edward Lemura5799e32020-01-17 19:26:51 +0000559 r'.+\.c$', r'.+\.cc$', r'.+\.cpp$', r'.+\.h$', r'.+\.m$', r'.+\.mm$',
560 r'.+\.inl$', r'.+\.asm$', r'.+\.hxx$', r'.+\.hpp$', r'.+\.s$', r'.+\.S$',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000561 # Scripts
dpapad443d9132022-05-05 00:17:30 +0000562 r'.+\.js$', r'.+\.ts$', r'.+\.py$', r'.+\.sh$', r'.+\.rb$', r'.+\.pl$',
563 r'.+\.pm$',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000564 # Other
Edward Lemura5799e32020-01-17 19:26:51 +0000565 r'.+\.java$', r'.+\.mk$', r'.+\.am$', r'.+\.css$', r'.+\.mojom$',
566 r'.+\.fidl$'
maruel@chromium.org3410d912009-06-09 20:56:16 +0000567 )
568
569 # Path regexp that should be excluded from being considered containing source
570 # files. Don't modify this list from a presubmit script!
local_bot64021412020-07-08 21:05:39 +0000571 DEFAULT_FILES_TO_SKIP = (
Edward Lemura5799e32020-01-17 19:26:51 +0000572 r'testing_support[\\\/]google_appengine[\\\/].*',
573 r'.*\bexperimental[\\\/].*',
Kent Tamura179dd1e2018-04-26 15:07:41 +0900574 # Exclude third_party/.* but NOT third_party/{WebKit,blink}
575 # (crbug.com/539768 and crbug.com/836555).
Edward Lemura5799e32020-01-17 19:26:51 +0000576 r'.*\bthird_party[\\\/](?!(WebKit|blink)[\\\/]).*',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000577 # Output directories (just in case)
Edward Lemura5799e32020-01-17 19:26:51 +0000578 r'.*\bDebug[\\\/].*',
579 r'.*\bRelease[\\\/].*',
580 r'.*\bxcodebuild[\\\/].*',
581 r'.*\bout[\\\/].*',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000582 # All caps files like README and LICENCE.
Edward Lemura5799e32020-01-17 19:26:51 +0000583 r'.*\b[A-Z0-9_]{2,}$',
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +0000584 # SCM (can happen in dual SCM configuration). (Slightly over aggressive)
Edward Lemura5799e32020-01-17 19:26:51 +0000585 r'(|.*[\\\/])\.git[\\\/].*',
586 r'(|.*[\\\/])\.svn[\\\/].*',
maruel@chromium.org7ccb4bb2011-11-07 20:26:20 +0000587 # There is no point in processing a patch file.
Edward Lemura5799e32020-01-17 19:26:51 +0000588 r'.+\.diff$',
589 r'.+\.patch$',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000590 )
591
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000592 def __init__(self, change, presubmit_path, is_committing,
Bruce Dawson09c0c072022-05-26 20:28:58 +0000593 verbose, gerrit_obj, dry_run=None, thread_pool=None, parallel=False,
594 no_diffs=False):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000595 """Builds an InputApi object.
596
597 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000598 change: A presubmit.Change object.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000599 presubmit_path: The path to the presubmit script being processed.
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000600 is_committing: True if the change is about to be committed.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000601 gerrit_obj: provides basic Gerrit codereview functionality.
602 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -0400603 parallel: if true, all tests reported via input_api.RunTests for all
604 PRESUBMIT files will be run in parallel.
Bruce Dawson09c0c072022-05-26 20:28:58 +0000605 no_diffs: if true, implies that --files or --all was specified so some
606 checks can be skipped, and some errors will be messages.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000607 """
maruel@chromium.org9711bba2009-05-22 23:51:39 +0000608 # Version number of the presubmit_support script.
609 self.version = [int(x) for x in __version__.split('.')]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000610 self.change = change
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000611 self.is_committing = is_committing
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000612 self.gerrit = gerrit_obj
tandrii@chromium.org57bafac2016-04-28 05:09:03 +0000613 self.dry_run = dry_run
Bruce Dawson09c0c072022-05-26 20:28:58 +0000614 self.no_diffs = no_diffs
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000615
Edward Lesmes8e282792018-04-03 18:50:29 -0400616 self.parallel = parallel
617 self.thread_pool = thread_pool or ThreadPool()
618
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000619 # We expose various modules and functions as attributes of the input_api
620 # so that presubmit scripts don't have to import them.
Takeshi Yoshino07a6bea2017-08-02 02:44:06 +0900621 self.ast = ast
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000622 self.basename = os.path.basename
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000623 self.cpplint = cpplint
dcheng091b7db2016-06-16 01:27:51 -0700624 self.fnmatch = fnmatch
Yoshisato Yanagisawa04600b42019-03-15 03:03:41 +0000625 self.gclient_paths = gclient_paths
Yoshisato Yanagisawa57dd17b2019-03-22 09:10:29 +0000626 # TODO(yyanagisawa): stop exposing this when python3 become default.
627 # Since python3's tempfile has TemporaryDirectory, we do not need this.
628 self.temporary_directory = gclient_utils.temporary_directory
dpranke@chromium.org17cc2442012-10-17 21:12:09 +0000629 self.glob = glob.glob
maruel@chromium.orgfb11c7b2010-03-18 18:22:14 +0000630 self.json = json
maruel@chromium.org6fba34d2011-06-02 13:45:12 +0000631 self.logging = logging.getLogger('PRESUBMIT')
maruel@chromium.org2b5ce562011-03-31 16:15:44 +0000632 self.os_listdir = os.listdir
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000633 self.os_path = os.path
pgervais@chromium.orgbd0cace2014-10-02 23:23:46 +0000634 self.os_stat = os.stat
Yoshisato Yanagisawa406de132018-06-29 05:43:25 +0000635 self.os_walk = os.walk
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000636 self.re = re
637 self.subprocess = subprocess
Edward Lemurb9830242019-10-30 22:19:20 +0000638 self.sys = sys
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000639 self.tempfile = tempfile
dpranke@chromium.org0d1bdea2011-03-24 22:54:38 +0000640 self.time = time
maruel@chromium.org1487d532009-06-06 00:22:57 +0000641 self.unittest = unittest
Edward Lemurb9830242019-10-30 22:19:20 +0000642 if sys.version_info.major == 2:
643 self.urllib2 = urllib2
Edward Lemur16af3562019-10-17 22:11:33 +0000644 self.urllib_request = urllib_request
645 self.urllib_error = urllib_error
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000646
Robert Iannucci50258932018-03-19 10:30:59 -0700647 self.is_windows = sys.platform == 'win32'
648
Edward Lemurb9646622019-10-25 20:57:35 +0000649 # Set python_executable to 'vpython' in order to allow scripts in other
650 # repos (e.g. src.git) to automatically pick up that repo's .vpython file,
651 # instead of inheriting the one in depot_tools.
652 self.python_executable = 'vpython'
Erik Staab69135d12021-05-14 22:31:57 +0000653 # Offer a python 3 executable for use during the migration off of python 2.
654 self.python3_executable = 'vpython3'
maruel@chromium.orgc0b22972009-06-25 16:19:14 +0000655 self.environ = os.environ
656
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000657 # InputApi.platform is the platform you're currently running on.
658 self.platform = sys.platform
659
iannucci@chromium.org0af3bb32015-06-12 20:44:35 +0000660 self.cpu_count = multiprocessing.cpu_count()
661
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000662 # The local path of the currently-being-processed presubmit script.
maruel@chromium.org3d235242009-05-15 12:40:48 +0000663 self._current_presubmit_path = os.path.dirname(presubmit_path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000664
665 # We carry the canned checks so presubmit scripts can easily use them.
666 self.canned_checks = presubmit_canned_checks
667
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +0100668 # Temporary files we must manually remove at the end of a run.
669 self._named_temporary_files = []
Jochen Eisinger72606f82017-04-04 10:44:18 +0200670
Edward Lesmesdc11c6b2021-03-19 19:22:05 +0000671 self.owners_client = None
672 if self.gerrit:
Bruce Dawson9b9f4512022-04-27 00:56:52 +0000673 try:
674 self.owners_client = owners_client.GetCodeOwnersClient(
675 root=change.RepositoryRoot(),
676 upstream=change.UpstreamBranch(),
677 host=self.gerrit.host,
678 project=self.gerrit.project,
679 branch=self.gerrit.branch)
680 except Exception as e:
681 print('Failed to set owners_client - %s' % str(e))
Edward Lesmes9ce03f82021-01-12 20:13:31 +0000682 self.owners_db = owners_db.Database(
683 change.RepositoryRoot(), fopen=open, os_path=self.os_path)
Jochen Eisinger76f5fc62017-04-07 16:27:46 +0200684 self.owners_finder = owners_finder.OwnersFinder
maruel@chromium.org899e1c12011-04-07 17:03:18 +0000685 self.verbose = verbose
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000686 self.Command = CommandData
dpranke@chromium.org2a009622011-03-01 02:43:31 +0000687
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000688 # Replace <hash_map> and <hash_set> as headers that need to be included
Edward Lemura5799e32020-01-17 19:26:51 +0000689 # with 'base/containers/hash_tables.h' instead.
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000690 # Access to a protected member _XX of a client class
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800691 # pylint: disable=protected-access
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000692 self.cpplint._re_pattern_templates = [
danakj@chromium.org18278522013-06-11 22:42:32 +0000693 (a, b, 'base/containers/hash_tables.h')
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000694 if header in ('<hash_map>', '<hash_set>') else (a, b, header)
695 for (a, b, header) in cpplint._re_pattern_templates
696 ]
697
Edward Lemurecc27072020-01-06 16:42:34 +0000698 def SetTimeout(self, timeout):
699 self.thread_pool.timeout = timeout
700
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000701 def PresubmitLocalPath(self):
702 """Returns the local path of the presubmit script currently being run.
703
704 This is useful if you don't want to hard-code absolute paths in the
705 presubmit script. For example, It can be used to find another file
706 relative to the PRESUBMIT.py script, so the whole tree can be branched and
707 the presubmit script still works, without editing its content.
708 """
maruel@chromium.org3d235242009-05-15 12:40:48 +0000709 return self._current_presubmit_path
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000710
agable0b65e732016-11-22 09:25:46 -0800711 def AffectedFiles(self, include_deletes=True, file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000712 """Same as input_api.change.AffectedFiles() except only lists files
713 (and optionally directories) in the same directory as the current presubmit
Bruce Dawson7a0b07a2020-04-23 17:14:40 +0000714 script, or subdirectories thereof. Note that files are listed using the OS
715 path separator, so backslashes are used as separators on Windows.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000716 """
Bruce Dawson31bfd512022-05-10 23:19:39 +0000717 dir_with_slash = normpath(self.PresubmitLocalPath())
718 # normpath strips trailing path separators, so the trailing separator has to
719 # be added after the normpath call.
720 if len(dir_with_slash) > 0:
721 dir_with_slash += os.path.sep
sail@chromium.org5538e022011-05-12 17:53:16 +0000722
Edward Lemurb9830242019-10-30 22:19:20 +0000723 return list(filter(
maruel@chromium.org4661e0c2009-06-04 00:45:26 +0000724 lambda x: normpath(x.AbsoluteLocalPath()).startswith(dir_with_slash),
Edward Lemurb9830242019-10-30 22:19:20 +0000725 self.change.AffectedFiles(include_deletes, file_filter)))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000726
agable0b65e732016-11-22 09:25:46 -0800727 def LocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000728 """Returns local paths of input_api.AffectedFiles()."""
agable0b65e732016-11-22 09:25:46 -0800729 paths = [af.LocalPath() for af in self.AffectedFiles()]
Edward Lemura5799e32020-01-17 19:26:51 +0000730 logging.debug('LocalPaths: %s', paths)
pgervais@chromium.org2f64f782014-04-25 00:12:33 +0000731 return paths
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000732
agable0b65e732016-11-22 09:25:46 -0800733 def AbsoluteLocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000734 """Returns absolute local paths of input_api.AffectedFiles()."""
agable0b65e732016-11-22 09:25:46 -0800735 return [af.AbsoluteLocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000736
John Budorick16162372018-04-18 10:39:53 -0700737 def AffectedTestableFiles(self, include_deletes=None, **kwargs):
agable0b65e732016-11-22 09:25:46 -0800738 """Same as input_api.change.AffectedTestableFiles() except only lists files
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000739 in the same directory as the current presubmit script, or subdirectories
740 thereof.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000741 """
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000742 if include_deletes is not None:
Edward Lemura5799e32020-01-17 19:26:51 +0000743 warn('AffectedTestableFiles(include_deletes=%s)'
744 ' is deprecated and ignored' % str(include_deletes),
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000745 category=DeprecationWarning,
746 stacklevel=2)
Josip Sokcevic4de5dea2022-03-23 21:15:14 +0000747 # pylint: disable=consider-using-generator
748 return [
749 x for x in self.AffectedFiles(include_deletes=False, **kwargs)
750 if x.IsTestableFile()
751 ]
agable0b65e732016-11-22 09:25:46 -0800752
753 def AffectedTextFiles(self, include_deletes=None):
754 """An alias to AffectedTestableFiles for backwards compatibility."""
755 return self.AffectedTestableFiles(include_deletes=include_deletes)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000756
Josip Sokcevic8c955952021-02-01 21:32:57 +0000757 def FilterSourceFile(self,
758 affected_file,
759 files_to_check=None,
760 files_to_skip=None,
761 allow_list=None,
762 block_list=None):
Edward Lemura5799e32020-01-17 19:26:51 +0000763 """Filters out files that aren't considered 'source file'.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000764
local_bot64021412020-07-08 21:05:39 +0000765 If files_to_check or files_to_skip is None, InputApi.DEFAULT_FILES_TO_CHECK
766 and InputApi.DEFAULT_FILES_TO_SKIP is used respectively.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000767
768 The lists will be compiled as regular expression and
769 AffectedFile.LocalPath() needs to pass both list.
770
771 Note: Copy-paste this function to suit your needs or use a lambda function.
772 """
local_bot64021412020-07-08 21:05:39 +0000773 if files_to_check is None:
774 files_to_check = self.DEFAULT_FILES_TO_CHECK
775 if files_to_skip is None:
776 files_to_skip = self.DEFAULT_FILES_TO_SKIP
local_bot30f774e2020-06-25 18:23:34 +0000777
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000778 def Find(affected_file, items):
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000779 local_path = affected_file.LocalPath()
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000780 for item in items:
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +0000781 if self.re.match(item, local_path):
maruel@chromium.org3410d912009-06-09 20:56:16 +0000782 return True
Bruce Dawsona3a014e2022-04-27 23:28:17 +0000783 # Handle the cases where the files regex only handles /, but the local
784 # path uses \.
785 if self.is_windows and self.re.match(item, local_path.replace(
786 '\\', '/')):
787 return True
maruel@chromium.org3410d912009-06-09 20:56:16 +0000788 return False
local_bot64021412020-07-08 21:05:39 +0000789 return (Find(affected_file, files_to_check) and
790 not Find(affected_file, files_to_skip))
maruel@chromium.org3410d912009-06-09 20:56:16 +0000791
792 def AffectedSourceFiles(self, source_file):
agable0b65e732016-11-22 09:25:46 -0800793 """Filter the list of AffectedTestableFiles by the function source_file.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000794
795 If source_file is None, InputApi.FilterSourceFile() is used.
796 """
797 if not source_file:
798 source_file = self.FilterSourceFile
Edward Lemurb9830242019-10-30 22:19:20 +0000799 return list(filter(source_file, self.AffectedTestableFiles()))
maruel@chromium.org3410d912009-06-09 20:56:16 +0000800
801 def RightHandSideLines(self, source_file_filter=None):
Edward Lemura5799e32020-01-17 19:26:51 +0000802 """An iterator over all text lines in 'new' version of changed files.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000803
804 Only lists lines from new or modified text files in the change that are
805 contained by the directory of the currently executing presubmit script.
806
807 This is useful for doing line-by-line regex checks, like checking for
808 trailing whitespace.
809
810 Yields:
811 a 3 tuple:
812 the AffectedFile instance of the current file;
813 integer line number (1-based); and
814 the contents of the line as a string.
maruel@chromium.org1487d532009-06-06 00:22:57 +0000815
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000816 Note: The carriage return (LF or CR) is stripped off.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000817 """
maruel@chromium.org3410d912009-06-09 20:56:16 +0000818 files = self.AffectedSourceFiles(source_file_filter)
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000819 return _RightHandSideLinesImpl(files)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000820
maruel@chromium.orge3608df2009-11-10 20:22:57 +0000821 def ReadFile(self, file_item, mode='r'):
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000822 """Reads an arbitrary file.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000823
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000824 Deny reading anything outside the repository.
825 """
maruel@chromium.orge3608df2009-11-10 20:22:57 +0000826 if isinstance(file_item, AffectedFile):
827 file_item = file_item.AbsoluteLocalPath()
828 if not file_item.startswith(self.change.RepositoryRoot()):
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000829 raise IOError('Access outside the repository root is denied.')
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +0000830 return gclient_utils.FileRead(file_item, mode)
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000831
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +0100832 def CreateTemporaryFile(self, **kwargs):
833 """Returns a named temporary file that must be removed with a call to
834 RemoveTemporaryFiles().
835
836 All keyword arguments are forwarded to tempfile.NamedTemporaryFile(),
837 except for |delete|, which is always set to False.
838
839 Presubmit checks that need to create a temporary file and pass it for
840 reading should use this function instead of NamedTemporaryFile(), as
841 Windows fails to open a file that is already open for writing.
842
843 with input_api.CreateTemporaryFile() as f:
844 f.write('xyz')
845 f.close()
846 input_api.subprocess.check_output(['script-that', '--reads-from',
847 f.name])
848
849
850 Note that callers of CreateTemporaryFile() should not worry about removing
851 any temporary file; this is done transparently by the presubmit handling
852 code.
853 """
854 if 'delete' in kwargs:
855 # Prevent users from passing |delete|; we take care of file deletion
856 # ourselves and this prevents unintuitive error messages when we pass
857 # delete=False and 'delete' is also in kwargs.
858 raise TypeError('CreateTemporaryFile() does not take a "delete" '
859 'argument, file deletion is handled automatically by '
860 'the same presubmit_support code that creates InputApi '
861 'objects.')
862 temp_file = self.tempfile.NamedTemporaryFile(delete=False, **kwargs)
863 self._named_temporary_files.append(temp_file.name)
864 return temp_file
865
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000866 @property
867 def tbr(self):
868 """Returns if a change is TBR'ed."""
Jeremy Romandce22502017-06-20 15:37:29 -0400869 return 'TBR' in self.change.tags or self.change.TBRsFromDescription()
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000870
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +0000871 def RunTests(self, tests_mix, parallel=True):
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000872 tests = []
873 msgs = []
874 for t in tests_mix:
Edward Lesmes8e282792018-04-03 18:50:29 -0400875 if isinstance(t, OutputApi.PresubmitResult) and t:
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000876 msgs.append(t)
877 else:
878 assert issubclass(t.message, _PresubmitResult)
879 tests.append(t)
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +0000880 if self.verbose:
881 t.info = _PresubmitNotifyResult
Edward Lemur1037c742018-05-01 18:56:04 -0400882 if not t.kwargs.get('cwd'):
883 t.kwargs['cwd'] = self.PresubmitLocalPath()
Edward Lesmes8e282792018-04-03 18:50:29 -0400884 self.thread_pool.AddTests(tests, parallel)
Edward Lemur21000eb2019-05-24 23:25:58 +0000885 # When self.parallel is True (i.e. --parallel is passed as an option)
886 # RunTests doesn't actually run tests. It adds them to a ThreadPool that
887 # will run all tests once all PRESUBMIT files are processed.
888 # Otherwise, it will run them and return the results.
889 if not self.parallel:
Edward Lesmes8e282792018-04-03 18:50:29 -0400890 msgs.extend(self.thread_pool.RunAsync())
891 return msgs
scottmg86099d72016-09-01 09:16:51 -0700892
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000893
nick@chromium.orgff526192013-06-10 19:30:26 +0000894class _DiffCache(object):
895 """Caches diffs retrieved from a particular SCM."""
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000896 def __init__(self, upstream=None):
897 """Stores the upstream revision against which all diffs will be computed."""
898 self._upstream = upstream
nick@chromium.orgff526192013-06-10 19:30:26 +0000899
900 def GetDiff(self, path, local_root):
901 """Get the diff for a particular path."""
902 raise NotImplementedError()
903
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700904 def GetOldContents(self, path, local_root):
905 """Get the old version for a particular path."""
906 raise NotImplementedError()
907
nick@chromium.orgff526192013-06-10 19:30:26 +0000908
nick@chromium.orgff526192013-06-10 19:30:26 +0000909class _GitDiffCache(_DiffCache):
910 """DiffCache implementation for git; gets all file diffs at once."""
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000911 def __init__(self, upstream):
912 super(_GitDiffCache, self).__init__(upstream=upstream)
nick@chromium.orgff526192013-06-10 19:30:26 +0000913 self._diffs_by_file = None
914
915 def GetDiff(self, path, local_root):
Bruce Dawson5f63d3c2022-04-19 17:02:36 +0000916 # Compare against None to distinguish between None and an initialized but
917 # empty dictionary.
918 if self._diffs_by_file == None:
nick@chromium.orgff526192013-06-10 19:30:26 +0000919 # Compute a single diff for all files and parse the output; should
920 # with git this is much faster than computing one diff for each file.
921 diffs = {}
922
923 # Don't specify any filenames below, because there are command line length
924 # limits on some platforms and GenerateDiff would fail.
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000925 unified_diff = scm.GIT.GenerateDiff(local_root, files=[], full_move=True,
926 branch=self._upstream)
nick@chromium.orgff526192013-06-10 19:30:26 +0000927
928 # This regex matches the path twice, separated by a space. Note that
929 # filename itself may contain spaces.
930 file_marker = re.compile('^diff --git (?P<filename>.*) (?P=filename)$')
931 current_diff = []
932 keep_line_endings = True
933 for x in unified_diff.splitlines(keep_line_endings):
934 match = file_marker.match(x)
935 if match:
936 # Marks the start of a new per-file section.
937 diffs[match.group('filename')] = current_diff = [x]
938 elif x.startswith('diff --git'):
939 raise PresubmitFailure('Unexpected diff line: %s' % x)
940 else:
941 current_diff.append(x)
942
943 self._diffs_by_file = dict(
944 (normpath(path), ''.join(diff)) for path, diff in diffs.items())
945
946 if path not in self._diffs_by_file:
Josip Sokcevicc1ab7342022-02-24 19:02:44 +0000947 # SCM didn't have any diff on this file. It could be that the file was not
948 # modified at all (e.g. user used --all flag in git cl presubmit).
949 # Intead of failing, return empty string.
950 # See: https://crbug.com/808346.
Josip Sokcevicc1ab7342022-02-24 19:02:44 +0000951 return ''
nick@chromium.orgff526192013-06-10 19:30:26 +0000952
953 return self._diffs_by_file[path]
954
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700955 def GetOldContents(self, path, local_root):
956 return scm.GIT.GetOldContents(local_root, path, branch=self._upstream)
957
nick@chromium.orgff526192013-06-10 19:30:26 +0000958
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000959class AffectedFile(object):
960 """Representation of a file in a change."""
nick@chromium.orgff526192013-06-10 19:30:26 +0000961
962 DIFF_CACHE = _DiffCache
963
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000964 # Method could be a function
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800965 # pylint: disable=no-self-use
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000966 def __init__(self, path, action, repository_root, diff_cache):
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000967 self._path = path
968 self._action = action
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000969 self._local_root = repository_root
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000970 self._is_directory = None
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000971 self._cached_changed_contents = None
972 self._cached_new_contents = None
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000973 self._diff_cache = diff_cache
tobiasjs2836bcf2016-08-16 04:08:16 -0700974 logging.debug('%s(%s)', self.__class__.__name__, self._path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000975
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000976 def LocalPath(self):
977 """Returns the path of this file on the local disk relative to client root.
Andrew Grieve92b8b992017-11-02 09:42:24 -0400978
979 This should be used for error messages but not for accessing files,
980 because presubmit checks are run with CWD=PresubmitLocalPath() (which is
981 often != client root).
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000982 """
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000983 return normpath(self._path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000984
985 def AbsoluteLocalPath(self):
986 """Returns the absolute path of this file on the local disk.
987 """
chase@chromium.org8e416c82009-10-06 04:30:44 +0000988 return os.path.abspath(os.path.join(self._local_root, self.LocalPath()))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000989
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000990 def Action(self):
991 """Returns the action on this opened file, e.g. A, M, D, etc."""
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000992 return self._action
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000993
agable0b65e732016-11-22 09:25:46 -0800994 def IsTestableFile(self):
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000995 """Returns True if the file is a text file and not a binary file.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000996
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000997 Deleted files are not text file."""
maruel@chromium.org1e08c002009-05-28 19:09:33 +0000998 raise NotImplementedError() # Implement when needed
999
agable0b65e732016-11-22 09:25:46 -08001000 def IsTextFile(self):
1001 """An alias to IsTestableFile for backwards compatibility."""
1002 return self.IsTestableFile()
1003
Daniel Cheng7a1f04d2017-03-21 19:12:31 -07001004 def OldContents(self):
1005 """Returns an iterator over the lines in the old version of file.
1006
Daniel Cheng2da34fe2017-03-21 20:42:12 -07001007 The old version is the file before any modifications in the user's
Edward Lemura5799e32020-01-17 19:26:51 +00001008 workspace, i.e. the 'left hand side'.
Daniel Cheng7a1f04d2017-03-21 19:12:31 -07001009
1010 Contents will be empty if the file is a directory or does not exist.
1011 Note: The carriage returns (LF or CR) are stripped off.
1012 """
1013 return self._diff_cache.GetOldContents(self.LocalPath(),
1014 self._local_root).splitlines()
1015
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001016 def NewContents(self):
1017 """Returns an iterator over the lines in the new version of file.
1018
Edward Lemura5799e32020-01-17 19:26:51 +00001019 The new version is the file in the user's workspace, i.e. the 'right hand
1020 side'.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001021
1022 Contents will be empty if the file is a directory or does not exist.
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +00001023 Note: The carriage returns (LF or CR) are stripped off.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001024 """
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +00001025 if self._cached_new_contents is None:
1026 self._cached_new_contents = []
agable0b65e732016-11-22 09:25:46 -08001027 try:
1028 self._cached_new_contents = gclient_utils.FileRead(
1029 self.AbsoluteLocalPath(), 'rU').splitlines()
1030 except IOError:
1031 pass # File not found? That's fine; maybe it was deleted.
Greg Thompson30cde452021-06-01 16:38:47 +00001032 except UnicodeDecodeError as e:
Dirk Pranke6fc394f2021-05-26 23:25:14 +00001033 # log the filename since we're probably trying to read a binary
1034 # file, and shouldn't be.
1035 print('Error reading %s: %s' % (self.AbsoluteLocalPath(), e))
1036 raise
1037
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +00001038 return self._cached_new_contents[:]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001039
Bruce Dawsonf0bcfdd2021-05-21 18:10:23 +00001040 def ChangedContents(self, keeplinebreaks=False):
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001041 """Returns a list of tuples (line number, line text) of all new lines.
1042
1043 This relies on the scm diff output describing each changed code section
1044 with a line of the form
1045
1046 ^@@ <old line num>,<old size> <new line num>,<new size> @@$
1047 """
Bruce Dawsonf0bcfdd2021-05-21 18:10:23 +00001048 # Don't return cached results when line breaks are requested.
1049 if not keeplinebreaks and self._cached_changed_contents is not None:
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +00001050 return self._cached_changed_contents[:]
Bruce Dawsonf0bcfdd2021-05-21 18:10:23 +00001051 result = []
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001052 line_num = 0
1053
Bruce Dawsonf0bcfdd2021-05-21 18:10:23 +00001054 # The keeplinebreaks parameter to splitlines must be True or else the
1055 # CheckForWindowsLineEndings presubmit will be a NOP.
1056 for line in self.GenerateScmDiff().splitlines(keeplinebreaks):
Edward Lemurac5c55f2020-02-29 00:17:16 +00001057 m = re.match(r'^@@ [0-9\,\+\-]+ \+([0-9]+)\,[0-9]+ @@', line)
1058 if m:
1059 line_num = int(m.groups(1)[0])
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001060 continue
1061 if line.startswith('+') and not line.startswith('++'):
Bruce Dawsonf0bcfdd2021-05-21 18:10:23 +00001062 result.append((line_num, line[1:]))
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001063 if not line.startswith('-'):
1064 line_num += 1
Bruce Dawsonf0bcfdd2021-05-21 18:10:23 +00001065 # Don't cache results with line breaks.
1066 if keeplinebreaks:
1067 return result;
1068 self._cached_changed_contents = result
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +00001069 return self._cached_changed_contents[:]
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001070
maruel@chromium.org5de13972009-06-10 18:16:06 +00001071 def __str__(self):
1072 return self.LocalPath()
1073
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001074 def GenerateScmDiff(self):
nick@chromium.orgff526192013-06-10 19:30:26 +00001075 return self._diff_cache.GetDiff(self.LocalPath(), self._local_root)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001076
maruel@chromium.org58407af2011-04-12 23:15:57 +00001077
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001078class GitAffectedFile(AffectedFile):
1079 """Representation of a file in a change out of a git checkout."""
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +00001080 # Method 'NNN' is abstract in class 'NNN' but is not overridden
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -08001081 # pylint: disable=abstract-method
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001082
nick@chromium.orgff526192013-06-10 19:30:26 +00001083 DIFF_CACHE = _GitDiffCache
1084
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001085 def __init__(self, *args, **kwargs):
1086 AffectedFile.__init__(self, *args, **kwargs)
1087 self._server_path = None
agable0b65e732016-11-22 09:25:46 -08001088 self._is_testable_file = None
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001089
agable0b65e732016-11-22 09:25:46 -08001090 def IsTestableFile(self):
1091 if self._is_testable_file is None:
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001092 if self.Action() == 'D':
agable0b65e732016-11-22 09:25:46 -08001093 # A deleted file is not testable.
1094 self._is_testable_file = False
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001095 else:
agable0b65e732016-11-22 09:25:46 -08001096 self._is_testable_file = os.path.isfile(self.AbsoluteLocalPath())
1097 return self._is_testable_file
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001098
maruel@chromium.orgc1938752011-04-12 23:11:13 +00001099
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001100class Change(object):
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001101 """Describe a change.
1102
1103 Used directly by the presubmit scripts to query the current change being
1104 tested.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +00001105
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001106 Instance members:
nick@chromium.orgff526192013-06-10 19:30:26 +00001107 tags: Dictionary of KEY=VALUE pairs found in the change description.
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001108 self.KEY: equivalent to tags['KEY']
1109 """
1110
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001111 _AFFECTED_FILES = AffectedFile
1112
Edward Lemura5799e32020-01-17 19:26:51 +00001113 # Matches key/value (or 'tag') lines in changelist descriptions.
maruel@chromium.org428342a2011-11-10 15:46:33 +00001114 TAG_LINE_RE = re.compile(
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001115 '^[ \t]*(?P<key>[A-Z][A-Z_0-9]*)[ \t]*=[ \t]*(?P<value>.*?)[ \t]*$')
maruel@chromium.orgc1938752011-04-12 23:11:13 +00001116 scm = ''
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001117
maruel@chromium.org58407af2011-04-12 23:15:57 +00001118 def __init__(
agable@chromium.orgea84ef12014-04-30 19:55:12 +00001119 self, name, description, local_root, files, issue, patchset, author,
1120 upstream=None):
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001121 if files is None:
1122 files = []
1123 self._name = name
chase@chromium.org8e416c82009-10-06 04:30:44 +00001124 # Convert root into an absolute path.
1125 self._local_root = os.path.abspath(local_root)
agable@chromium.orgea84ef12014-04-30 19:55:12 +00001126 self._upstream = upstream
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001127 self.issue = issue
1128 self.patchset = patchset
maruel@chromium.org58407af2011-04-12 23:15:57 +00001129 self.author_email = author
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001130
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001131 self._full_description = ''
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001132 self.tags = {}
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001133 self._description_without_tags = ''
1134 self.SetDescriptionText(description)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001135
maruel@chromium.orge085d812011-10-10 19:49:15 +00001136 assert all(
1137 (isinstance(f, (list, tuple)) and len(f) == 2) for f in files), files
1138
agable@chromium.orgea84ef12014-04-30 19:55:12 +00001139 diff_cache = self._AFFECTED_FILES.DIFF_CACHE(self._upstream)
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001140 self._affected_files = [
nick@chromium.orgff526192013-06-10 19:30:26 +00001141 self._AFFECTED_FILES(path, action.strip(), self._local_root, diff_cache)
1142 for action, path in files
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +00001143 ]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001144
Edward Lesmes9ce03f82021-01-12 20:13:31 +00001145 def UpstreamBranch(self):
1146 """Returns the upstream branch for the change."""
1147 return self._upstream
1148
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001149 def Name(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001150 """Returns the change name."""
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001151 return self._name
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001152
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001153 def DescriptionText(self):
1154 """Returns the user-entered changelist description, minus tags.
1155
Edward Lemura5799e32020-01-17 19:26:51 +00001156 Any line in the user-provided description starting with e.g. 'FOO='
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001157 (whitespace permitted before and around) is considered a tag line. Such
1158 lines are stripped out of the description this function returns.
1159 """
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001160 return self._description_without_tags
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001161
1162 def FullDescriptionText(self):
1163 """Returns the complete changelist description including tags."""
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001164 return self._full_description
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001165
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001166 def SetDescriptionText(self, description):
1167 """Sets the full description text (including tags) to |description|.
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001168
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001169 Also updates the list of tags."""
1170 self._full_description = description
1171
1172 # From the description text, build up a dictionary of key/value pairs
Edward Lemura5799e32020-01-17 19:26:51 +00001173 # plus the description minus all key/value or 'tag' lines.
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001174 description_without_tags = []
1175 self.tags = {}
1176 for line in self._full_description.splitlines():
1177 m = self.TAG_LINE_RE.match(line)
1178 if m:
1179 self.tags[m.group('key')] = m.group('value')
1180 else:
1181 description_without_tags.append(line)
1182
1183 # Change back to text and remove whitespace at end.
1184 self._description_without_tags = (
1185 '\n'.join(description_without_tags).rstrip())
1186
Edward Lemur69bb8be2020-02-03 20:37:38 +00001187 def AddDescriptionFooter(self, key, value):
1188 """Adds the given footer to the change description.
1189
1190 Args:
1191 key: A string with the key for the git footer. It must conform to
1192 the git footers format (i.e. 'List-Of-Tokens') and will be case
1193 normalized so that each token is title-cased.
1194 value: A string with the value for the git footer.
1195 """
1196 description = git_footers.add_footer(
1197 self.FullDescriptionText(), git_footers.normalize_name(key), value)
1198 self.SetDescriptionText(description)
1199
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001200 def RepositoryRoot(self):
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001201 """Returns the repository (checkout) root directory for this change,
1202 as an absolute path.
1203 """
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001204 return self._local_root
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001205
1206 def __getattr__(self, attr):
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001207 """Return tags directly as attributes on the object."""
Edward Lemura5799e32020-01-17 19:26:51 +00001208 if not re.match(r'^[A-Z_]*$', attr):
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001209 raise AttributeError(self, attr)
maruel@chromium.orge1a524f2009-05-27 14:43:46 +00001210 return self.tags.get(attr)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001211
Edward Lemur69bb8be2020-02-03 20:37:38 +00001212 def GitFootersFromDescription(self):
1213 """Return the git footers present in the description.
1214
1215 Returns:
1216 footers: A dict of {footer: [values]} containing a multimap of the footers
1217 in the change description.
1218 """
1219 return git_footers.parse_footers(self.FullDescriptionText())
1220
Aaron Gablefc03e672017-05-15 14:09:42 -07001221 def BugsFromDescription(self):
1222 """Returns all bugs referenced in the commit description."""
Sean McAllister1e509c52021-10-25 17:54:25 +00001223 bug_tags = ['BUG', 'FIXED']
1224
1225 tags = []
1226 for tag in bug_tags:
1227 values = self.tags.get(tag)
1228 if values:
1229 tags += [value.strip() for value in values.split(',')]
1230
Caleb Rouleauc0546b92019-02-22 06:12:57 +00001231 footers = []
Edward Lemur69bb8be2020-02-03 20:37:38 +00001232 parsed = self.GitFootersFromDescription()
Dan Beam62954042019-10-03 21:20:33 +00001233 unsplit_footers = parsed.get('Bug', []) + parsed.get('Fixed', [])
Caleb Rouleauc0546b92019-02-22 06:12:57 +00001234 for unsplit_footer in unsplit_footers:
1235 footers += [b.strip() for b in unsplit_footer.split(',')]
Aaron Gable12ef5012017-05-15 14:29:00 -07001236 return sorted(set(tags + footers))
Aaron Gablefc03e672017-05-15 14:09:42 -07001237
1238 def ReviewersFromDescription(self):
1239 """Returns all reviewers listed in the commit description."""
Edward Lemura5799e32020-01-17 19:26:51 +00001240 # We don't support a 'R:' git-footer for reviewers; that is in metadata.
Aaron Gable12ef5012017-05-15 14:29:00 -07001241 tags = [r.strip() for r in self.tags.get('R', '').split(',') if r.strip()]
1242 return sorted(set(tags))
Aaron Gablefc03e672017-05-15 14:09:42 -07001243
1244 def TBRsFromDescription(self):
1245 """Returns all TBR reviewers listed in the commit description."""
Aaron Gable12ef5012017-05-15 14:29:00 -07001246 tags = [r.strip() for r in self.tags.get('TBR', '').split(',') if r.strip()]
Aaron Gable6e7ddb62020-05-27 22:23:29 +00001247 # TODO(crbug.com/839208): Remove support for 'Tbr:' when TBRs are
1248 # programmatically determined by self-CR+1s.
Edward Lemur69bb8be2020-02-03 20:37:38 +00001249 footers = self.GitFootersFromDescription().get('Tbr', [])
Aaron Gable12ef5012017-05-15 14:29:00 -07001250 return sorted(set(tags + footers))
Aaron Gablefc03e672017-05-15 14:09:42 -07001251
Aaron Gable6e7ddb62020-05-27 22:23:29 +00001252 # TODO(crbug.com/753425): Delete these once we're sure they're unused.
Aaron Gablefc03e672017-05-15 14:09:42 -07001253 @property
1254 def BUG(self):
1255 return ','.join(self.BugsFromDescription())
1256 @property
1257 def R(self):
1258 return ','.join(self.ReviewersFromDescription())
1259 @property
1260 def TBR(self):
1261 return ','.join(self.TBRsFromDescription())
1262
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001263 def AllFiles(self, root=None):
1264 """List all files under source control in the repo."""
1265 raise NotImplementedError()
1266
agable0b65e732016-11-22 09:25:46 -08001267 def AffectedFiles(self, include_deletes=True, file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001268 """Returns a list of AffectedFile instances for all files in the change.
1269
1270 Args:
1271 include_deletes: If false, deleted files will be filtered out.
sail@chromium.org5538e022011-05-12 17:53:16 +00001272 file_filter: An additional filter to apply.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001273
1274 Returns:
1275 [AffectedFile(path, action), AffectedFile(path, action)]
1276 """
Edward Lemurb9830242019-10-30 22:19:20 +00001277 affected = list(filter(file_filter, self._affected_files))
sail@chromium.org5538e022011-05-12 17:53:16 +00001278
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001279 if include_deletes:
1280 return affected
Edward Lemurb9830242019-10-30 22:19:20 +00001281 return list(filter(lambda x: x.Action() != 'D', affected))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001282
John Budorick16162372018-04-18 10:39:53 -07001283 def AffectedTestableFiles(self, include_deletes=None, **kwargs):
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +00001284 """Return a list of the existing text files in a change."""
1285 if include_deletes is not None:
Edward Lemura5799e32020-01-17 19:26:51 +00001286 warn('AffectedTeestableFiles(include_deletes=%s)'
1287 ' is deprecated and ignored' % str(include_deletes),
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +00001288 category=DeprecationWarning,
1289 stacklevel=2)
Edward Lemurb9830242019-10-30 22:19:20 +00001290 return list(filter(
1291 lambda x: x.IsTestableFile(),
1292 self.AffectedFiles(include_deletes=False, **kwargs)))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001293
agable0b65e732016-11-22 09:25:46 -08001294 def AffectedTextFiles(self, include_deletes=None):
1295 """An alias to AffectedTestableFiles for backwards compatibility."""
1296 return self.AffectedTestableFiles(include_deletes=include_deletes)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001297
agable0b65e732016-11-22 09:25:46 -08001298 def LocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001299 """Convenience function."""
agable0b65e732016-11-22 09:25:46 -08001300 return [af.LocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001301
agable0b65e732016-11-22 09:25:46 -08001302 def AbsoluteLocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001303 """Convenience function."""
agable0b65e732016-11-22 09:25:46 -08001304 return [af.AbsoluteLocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001305
1306 def RightHandSideLines(self):
Edward Lemura5799e32020-01-17 19:26:51 +00001307 """An iterator over all text lines in 'new' version of changed files.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001308
1309 Lists lines from new or modified text files in the change.
1310
1311 This is useful for doing line-by-line regex checks, like checking for
1312 trailing whitespace.
1313
1314 Yields:
1315 a 3 tuple:
1316 the AffectedFile instance of the current file;
1317 integer line number (1-based); and
1318 the contents of the line as a string.
1319 """
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +00001320 return _RightHandSideLinesImpl(
1321 x for x in self.AffectedFiles(include_deletes=False)
agable0b65e732016-11-22 09:25:46 -08001322 if x.IsTestableFile())
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001323
Jochen Eisingerd0573ec2017-04-13 10:55:06 +02001324 def OriginalOwnersFiles(self):
1325 """A map from path names of affected OWNERS files to their old content."""
1326 def owners_file_filter(f):
1327 return 'OWNERS' in os.path.split(f.LocalPath())[1]
1328 files = self.AffectedFiles(file_filter=owners_file_filter)
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +00001329 return {f.LocalPath(): f.OldContents() for f in files}
Jochen Eisingerd0573ec2017-04-13 10:55:06 +02001330
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001331
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001332class GitChange(Change):
1333 _AFFECTED_FILES = GitAffectedFile
maruel@chromium.orgc1938752011-04-12 23:11:13 +00001334 scm = 'git'
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +00001335
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001336 def AllFiles(self, root=None):
1337 """List all files under source control in the repo."""
1338 root = root or self.RepositoryRoot()
1339 return subprocess.check_output(
Aaron Gable7817f022017-12-12 09:43:17 -08001340 ['git', '-c', 'core.quotePath=false', 'ls-files', '--', '.'],
Josip Sokcevic0b123462021-06-08 20:41:32 +00001341 cwd=root).decode('utf-8', 'ignore').splitlines()
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001342
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001343
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001344def ListRelevantPresubmitFiles(files, root):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001345 """Finds all presubmit files that apply to a given set of source files.
1346
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001347 If inherit-review-settings-ok is present right under root, looks for
1348 PRESUBMIT.py in directories enclosing root.
1349
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001350 Args:
1351 files: An iterable container containing file paths.
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001352 root: Path where to stop searching.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001353
1354 Return:
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001355 List of absolute paths of the existing PRESUBMIT.py scripts.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001356 """
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001357 files = [normpath(os.path.join(root, f)) for f in files]
1358
1359 # List all the individual directories containing files.
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +00001360 directories = {os.path.dirname(f) for f in files}
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001361
1362 # Ignore root if inherit-review-settings-ok is present.
1363 if os.path.isfile(os.path.join(root, 'inherit-review-settings-ok')):
1364 root = None
1365
1366 # Collect all unique directories that may contain PRESUBMIT.py.
1367 candidates = set()
1368 for directory in directories:
1369 while True:
1370 if directory in candidates:
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001371 break
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001372 candidates.add(directory)
1373 if directory == root:
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001374 break
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001375 parent_dir = os.path.dirname(directory)
1376 if parent_dir == directory:
1377 # We hit the system root directory.
1378 break
1379 directory = parent_dir
1380
1381 # Look for PRESUBMIT.py in all candidate directories.
1382 results = []
1383 for directory in sorted(list(candidates)):
tobiasjsff061c02016-08-17 03:23:57 -07001384 try:
1385 for f in os.listdir(directory):
1386 p = os.path.join(directory, f)
1387 if os.path.isfile(p) and re.match(
1388 r'PRESUBMIT.*\.py$', f) and not f.startswith('PRESUBMIT_test'):
1389 results.append(p)
1390 except OSError:
1391 pass
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001392
tobiasjs2836bcf2016-08-16 04:08:16 -07001393 logging.debug('Presubmit files: %s', ','.join(results))
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001394 return results
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001395
1396
rmistry@google.com5626a922015-02-26 14:03:30 +00001397class GetPostUploadExecuter(object):
Josip Sokcevice293d3d2022-02-16 22:52:15 +00001398 def __init__(self, use_python3):
1399 """
1400 Args:
1401 use_python3: if true, will use python3 instead of python2 by default
1402 if USE_PYTHON3 is not specified.
1403 """
1404 self.use_python3 = use_python3
1405
1406 def ExecPresubmitScript(self, script_text, presubmit_path, gerrit_obj,
1407 change):
rmistry@google.com5626a922015-02-26 14:03:30 +00001408 """Executes PostUploadHook() from a single presubmit script.
Josip Sokcevic632bbc02022-05-19 05:32:50 +00001409 Caller is responsible for validating whether the hook should be executed
1410 and should only call this function if it should be.
rmistry@google.com5626a922015-02-26 14:03:30 +00001411
1412 Args:
1413 script_text: The text of the presubmit script.
1414 presubmit_path: Project script to run.
Edward Lemur016a0872020-02-04 22:13:28 +00001415 gerrit_obj: The GerritAccessor object.
rmistry@google.com5626a922015-02-26 14:03:30 +00001416 change: The Change object.
1417
1418 Return:
1419 A list of results objects.
1420 """
1421 context = {}
1422 try:
Raul Tambre09e64b42019-05-14 01:57:22 +00001423 exec(compile(script_text, 'PRESUBMIT.py', 'exec', dont_inherit=True),
1424 context)
Raul Tambre7c938462019-05-24 16:35:35 +00001425 except Exception as e:
rmistry@google.com5626a922015-02-26 14:03:30 +00001426 raise PresubmitFailure('"%s" had an exception.\n%s'
1427 % (presubmit_path, e))
1428
1429 function_name = 'PostUploadHook'
1430 if function_name not in context:
1431 return {}
1432 post_upload_hook = context[function_name]
1433 if not len(inspect.getargspec(post_upload_hook)[0]) == 3:
1434 raise PresubmitFailure(
1435 'Expected function "PostUploadHook" to take three arguments.')
Edward Lemur016a0872020-02-04 22:13:28 +00001436 return post_upload_hook(gerrit_obj, change, OutputApi(False))
rmistry@google.com5626a922015-02-26 14:03:30 +00001437
1438
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001439def _MergeMasters(masters1, masters2):
1440 """Merges two master maps. Merges also the tests of each builder."""
1441 result = {}
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001442 for (master, builders) in itertools.chain(masters1.items(),
1443 masters2.items()):
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001444 new_builders = result.setdefault(master, {})
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001445 for (builder, tests) in builders.items():
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001446 new_builders.setdefault(builder, set([])).update(tests)
1447 return result
1448
1449
Josip Sokcevice293d3d2022-02-16 22:52:15 +00001450def DoPostUploadExecuter(change, gerrit_obj, verbose, use_python3=False):
rmistry@google.com5626a922015-02-26 14:03:30 +00001451 """Execute the post upload hook.
1452
1453 Args:
1454 change: The Change object.
Edward Lemur016a0872020-02-04 22:13:28 +00001455 gerrit_obj: The GerritAccessor object.
rmistry@google.com5626a922015-02-26 14:03:30 +00001456 verbose: Prints debug info.
Josip Sokcevice293d3d2022-02-16 22:52:15 +00001457 use_python3: if true, default to using Python3 for presubmit checks
1458 rather than Python2.
rmistry@google.com5626a922015-02-26 14:03:30 +00001459 """
Josip Sokcevice293d3d2022-02-16 22:52:15 +00001460 python_version = 'Python %s' % sys.version_info.major
1461 sys.stdout.write('Running %s post upload checks ...\n' % python_version)
rmistry@google.com5626a922015-02-26 14:03:30 +00001462 presubmit_files = ListRelevantPresubmitFiles(
Edward Lemur6eb1d322020-02-27 22:20:15 +00001463 change.LocalPaths(), change.RepositoryRoot())
rmistry@google.com5626a922015-02-26 14:03:30 +00001464 if not presubmit_files and verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001465 sys.stdout.write('Warning, no PRESUBMIT.py found.\n')
rmistry@google.com5626a922015-02-26 14:03:30 +00001466 results = []
Josip Sokcevice293d3d2022-02-16 22:52:15 +00001467 executer = GetPostUploadExecuter(use_python3)
rmistry@google.com5626a922015-02-26 14:03:30 +00001468 # The root presubmit file should be executed after the ones in subdirectories.
1469 # i.e. the specific post upload hooks should run before the general ones.
1470 # Thus, reverse the order provided by ListRelevantPresubmitFiles.
1471 presubmit_files.reverse()
1472
1473 for filename in presubmit_files:
1474 filename = os.path.abspath(filename)
1475 if verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001476 sys.stdout.write('Running %s\n' % filename)
rmistry@google.com5626a922015-02-26 14:03:30 +00001477 # Accept CRLF presubmit script.
1478 presubmit_script = gclient_utils.FileRead(filename, 'rU')
Josip Sokcevic632bbc02022-05-19 05:32:50 +00001479 if _ShouldRunPresubmit(presubmit_script, use_python3):
1480 results.extend(executer.ExecPresubmitScript(
1481 presubmit_script, filename, gerrit_obj, change))
rmistry@google.com5626a922015-02-26 14:03:30 +00001482
Edward Lemur6eb1d322020-02-27 22:20:15 +00001483 if not results:
1484 return 0
1485
1486 sys.stdout.write('\n')
1487 sys.stdout.write('** Post Upload Hook Messages **\n')
1488
1489 exit_code = 0
1490 for result in results:
1491 if result.fatal:
1492 exit_code = 1
1493 result.handle()
1494 sys.stdout.write('\n')
1495
1496 return exit_code
rmistry@google.com5626a922015-02-26 14:03:30 +00001497
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001498class PresubmitExecuter(object):
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001499 def __init__(self, change, committing, verbose, gerrit_obj, dry_run=None,
Bruce Dawson09c0c072022-05-26 20:28:58 +00001500 thread_pool=None, parallel=False, use_python3=False,
1501 no_diffs=False):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001502 """
1503 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001504 change: The Change object.
agable92bec4f2016-08-24 09:27:27 -07001505 committing: True if 'git cl land' is running, False if 'git cl upload' is.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001506 gerrit_obj: provides basic Gerrit codereview functionality.
1507 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -04001508 parallel: if true, all tests reported via input_api.RunTests for all
1509 PRESUBMIT files will be run in parallel.
Dirk Pranke6f0df682021-06-25 00:42:33 +00001510 use_python3: if true, will use python3 instead of python2 by default
1511 if USE_PYTHON3 is not specified.
Bruce Dawson09c0c072022-05-26 20:28:58 +00001512 no_diffs: if true, implies that --files or --all was specified so some
1513 checks can be skipped, and some errors will be messages.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001514 """
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001515 self.change = change
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001516 self.committing = committing
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001517 self.gerrit = gerrit_obj
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001518 self.verbose = verbose
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001519 self.dry_run = dry_run
Daniel Cheng7227d212017-11-17 08:12:37 -08001520 self.more_cc = []
Edward Lesmes8e282792018-04-03 18:50:29 -04001521 self.thread_pool = thread_pool
1522 self.parallel = parallel
Dirk Pranke6f0df682021-06-25 00:42:33 +00001523 self.use_python3 = use_python3
Bruce Dawson09c0c072022-05-26 20:28:58 +00001524 self.no_diffs = no_diffs
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001525
1526 def ExecPresubmitScript(self, script_text, presubmit_path):
1527 """Executes a single presubmit script.
Josip Sokcevic632bbc02022-05-19 05:32:50 +00001528 Caller is responsible for validating whether the hook should be executed
1529 and should only call this function if it should be.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001530
1531 Args:
1532 script_text: The text of the presubmit script.
1533 presubmit_path: The path to the presubmit file (this will be reported via
1534 input_api.PresubmitLocalPath()).
1535
1536 Return:
1537 A list of result objects, empty if no problems.
1538 """
chase@chromium.org8e416c82009-10-06 04:30:44 +00001539 # Change to the presubmit file's directory to support local imports.
1540 main_path = os.getcwd()
Saagar Sanghavi98b332f2020-07-31 17:19:15 +00001541 presubmit_dir = os.path.dirname(presubmit_path)
1542 os.chdir(presubmit_dir)
chase@chromium.org8e416c82009-10-06 04:30:44 +00001543
1544 # Load the presubmit script into context.
dpranke@chromium.org970c5222011-03-12 00:32:24 +00001545 input_api = InputApi(self.change, presubmit_path, self.committing,
Aaron Gable668c1d82018-04-03 10:19:16 -07001546 self.verbose, gerrit_obj=self.gerrit,
Edward Lesmes8e282792018-04-03 18:50:29 -04001547 dry_run=self.dry_run, thread_pool=self.thread_pool,
Bruce Dawson09c0c072022-05-26 20:28:58 +00001548 parallel=self.parallel, no_diffs=self.no_diffs)
Daniel Cheng7227d212017-11-17 08:12:37 -08001549 output_api = OutputApi(self.committing)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001550 context = {}
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001551
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001552 try:
Raul Tambre09e64b42019-05-14 01:57:22 +00001553 exec(compile(script_text, 'PRESUBMIT.py', 'exec', dont_inherit=True),
1554 context)
Raul Tambre7c938462019-05-24 16:35:35 +00001555 except Exception as e:
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001556 raise PresubmitFailure('"%s" had an exception.\n%s' % (presubmit_path, e))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001557
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001558 context['__args'] = (input_api, output_api)
Ben Pastene8351dc12020-08-06 05:01:35 +00001559
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001560 # Get path of presubmit directory relative to repository root.
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001561 # Always use forward slashes, so that path is same in *nix and Windows
1562 root = input_api.change.RepositoryRoot()
1563 rel_path = os.path.relpath(presubmit_dir, root)
1564 rel_path = rel_path.replace(os.path.sep, '/')
Ben Pastene8351dc12020-08-06 05:01:35 +00001565
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001566 # Get the URL of git remote origin and use it to identify host and project
Edward Lesmeseb1bd622021-03-01 19:54:07 +00001567 host = project = ''
1568 if self.gerrit:
1569 host = self.gerrit.host or ''
1570 project = self.gerrit.project or ''
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001571
1572 # Prefix for test names
1573 prefix = 'presubmit:%s/%s:%s/' % (host, project, rel_path)
1574
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001575 # Perform all the desired presubmit checks.
1576 results = []
Ben Pastene8351dc12020-08-06 05:01:35 +00001577
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001578 try:
Scott Leecc2fe9b2020-11-19 19:38:06 +00001579 version = [
1580 int(x) for x in context.get('PRESUBMIT_VERSION', '0.0.0').split('.')
1581 ]
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001582
Scott Leecc2fe9b2020-11-19 19:38:06 +00001583 with rdb_wrapper.client(prefix) as sink:
1584 if version >= [2, 0, 0]:
Andrew Grievebdfb8f22022-02-02 21:56:47 +00001585 # Copy the keys to prevent "dictionary changed size during iteration"
1586 # exception if checks add globals to context. E.g. sometimes the
1587 # Python runtime will add __warningregistry__.
1588 for function_name in list(context.keys()):
Scott Leecc2fe9b2020-11-19 19:38:06 +00001589 if not function_name.startswith('Check'):
1590 continue
1591 if function_name.endswith('Commit') and not self.committing:
1592 continue
1593 if function_name.endswith('Upload') and self.committing:
1594 continue
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001595 logging.debug('Running %s in %s', function_name, presubmit_path)
1596 results.extend(
Bruce Dawson8fa42e22022-03-29 17:05:38 +00001597 self._run_check_function(function_name, context, sink,
1598 presubmit_path))
Scott Leecc2fe9b2020-11-19 19:38:06 +00001599 logging.debug('Running %s done.', function_name)
1600 self.more_cc.extend(output_api.more_cc)
1601
1602 else: # Old format
1603 if self.committing:
1604 function_name = 'CheckChangeOnCommit'
1605 else:
1606 function_name = 'CheckChangeOnUpload'
Andrew Grievebdfb8f22022-02-02 21:56:47 +00001607 if function_name in list(context.keys()):
Scott Leecc2fe9b2020-11-19 19:38:06 +00001608 logging.debug('Running %s in %s', function_name, presubmit_path)
1609 results.extend(
Bruce Dawson8fa42e22022-03-29 17:05:38 +00001610 self._run_check_function(function_name, context, sink,
1611 presubmit_path))
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001612 logging.debug('Running %s done.', function_name)
1613 self.more_cc.extend(output_api.more_cc)
1614
1615 finally:
1616 for f in input_api._named_temporary_files:
1617 os.remove(f)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001618
chase@chromium.org8e416c82009-10-06 04:30:44 +00001619 # Return the process to the original working directory.
1620 os.chdir(main_path)
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001621 return results
1622
Bruce Dawson8fa42e22022-03-29 17:05:38 +00001623 def _run_check_function(self, function_name, context, sink, presubmit_path):
Scott Leecc2fe9b2020-11-19 19:38:06 +00001624 """Evaluates and returns the result of a given presubmit function.
1625
1626 If sink is given, the result of the presubmit function will be reported
1627 to the ResultSink.
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001628
1629 Args:
Scott Leecc2fe9b2020-11-19 19:38:06 +00001630 function_name: the name of the presubmit function to evaluate
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001631 context: a context dictionary in which the function will be evaluated
Scott Leecc2fe9b2020-11-19 19:38:06 +00001632 sink: an instance of ResultSink. None, by default.
1633 Returns:
1634 the result of the presubmit function call.
1635 """
1636 start_time = time_time()
1637 try:
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001638 result = eval(function_name + '(*__args)', context)
1639 self._check_result_type(result)
Allen Webbfe7d7092021-05-18 02:05:49 +00001640 except Exception:
Scott Leecc2fe9b2020-11-19 19:38:06 +00001641 if sink:
1642 elapsed_time = time_time() - start_time
1643 sink.report(function_name, rdb_wrapper.STATUS_FAIL, elapsed_time)
Allen Webbfe7d7092021-05-18 02:05:49 +00001644 # TODO(crbug.com/953884): replace reraise with native py3:
Allen Webbb65bbfe2021-05-11 21:22:01 +00001645 # raise .. from e
Allen Webbfe7d7092021-05-18 02:05:49 +00001646 e_type, e_value, e_tb = sys.exc_info()
Dirk Pranke6fc394f2021-05-26 23:25:14 +00001647 print('Evaluation of %s failed: %s' % (function_name, e_value))
1648 six.reraise(e_type, e_value, e_tb)
Scott Leecc2fe9b2020-11-19 19:38:06 +00001649
Bruce Dawson2bdc49f2021-05-21 19:13:03 +00001650 elapsed_time = time_time() - start_time
1651 if elapsed_time > 10.0:
Bruce Dawson8fa42e22022-03-29 17:05:38 +00001652 sys.stdout.write('%s from %s took %.1fs to run.\n' %
1653 (function_name, presubmit_path, elapsed_time))
Scott Leecc2fe9b2020-11-19 19:38:06 +00001654 if sink:
Scott Leecc2fe9b2020-11-19 19:38:06 +00001655 status = rdb_wrapper.STATUS_PASS
1656 if any(r.fatal for r in result):
1657 status = rdb_wrapper.STATUS_FAIL
1658 sink.report(function_name, status, elapsed_time)
1659
1660 return result
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001661
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00001662 def _check_result_type(self, result):
1663 """Helper function which ensures result is a list, and all elements are
1664 instances of OutputApi.PresubmitResult"""
1665 if not isinstance(result, (tuple, list)):
1666 raise PresubmitFailure('Presubmit functions must return a tuple or list')
1667 if not all(isinstance(res, OutputApi.PresubmitResult) for res in result):
1668 raise PresubmitFailure(
1669 'All presubmit results must be of types derived from '
1670 'output_api.PresubmitResult')
1671
1672
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001673def DoPresubmitChecks(change,
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001674 committing,
1675 verbose,
maruel@chromium.orgb0dfd352009-06-10 14:12:54 +00001676 default_presubmit,
dpranke@chromium.org970c5222011-03-12 00:32:24 +00001677 may_prompt,
Aaron Gable668c1d82018-04-03 10:19:16 -07001678 gerrit_obj,
Edward Lesmes8e282792018-04-03 18:50:29 -04001679 dry_run=None,
Debrian Figueroadd2737e2019-06-21 23:50:13 +00001680 parallel=False,
Dirk Pranke6f0df682021-06-25 00:42:33 +00001681 json_output=None,
Bruce Dawson09c0c072022-05-26 20:28:58 +00001682 use_python3=False,
1683 no_diffs=False):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001684 """Runs all presubmit checks that apply to the files in the change.
1685
1686 This finds all PRESUBMIT.py files in directories enclosing the files in the
1687 change (up to the repository root) and calls the relevant entrypoint function
1688 depending on whether the change is being committed or uploaded.
1689
1690 Prints errors, warnings and notifications. Prompts the user for warnings
1691 when needed.
1692
1693 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001694 change: The Change object.
agable92bec4f2016-08-24 09:27:27 -07001695 committing: True if 'git cl land' is running, False if 'git cl upload' is.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001696 verbose: Prints debug info.
maruel@chromium.org0ff1fab2009-05-22 13:08:15 +00001697 default_presubmit: A default presubmit script to execute in any case.
Quinten Yearsley516fe7f2016-12-14 11:50:18 -08001698 may_prompt: Enable (y/n) questions on warning or error. If False,
1699 any questions are answered with yes by default.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001700 gerrit_obj: provides basic Gerrit codereview functionality.
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001701 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -04001702 parallel: if true, all tests specified by input_api.RunTests in all
1703 PRESUBMIT files will be run in parallel.
Dirk Pranke6f0df682021-06-25 00:42:33 +00001704 use_python3: if true, default to using Python3 for presubmit checks
1705 rather than Python2.
Bruce Dawson09c0c072022-05-26 20:28:58 +00001706 no_diffs: if true, implies that --files or --all was specified so some
1707 checks can be skipped, and some errors will be messages.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001708 Return:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001709 1 if presubmit checks failed or 0 otherwise.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001710 """
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001711 old_environ = os.environ
1712 try:
1713 # Make sure python subprocesses won't generate .pyc files.
1714 os.environ = os.environ.copy()
Edward Lemurb9830242019-10-30 22:19:20 +00001715 os.environ['PYTHONDONTWRITEBYTECODE'] = '1'
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001716
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001717 python_version = 'Python %s' % sys.version_info.major
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001718 if committing:
Dirk Pranke6fc394f2021-05-26 23:25:14 +00001719 sys.stdout.write('Running %s presubmit commit checks ...\n' %
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001720 python_version)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001721 else:
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001722 sys.stdout.write('Running %s presubmit upload checks ...\n' %
1723 python_version)
Edward Lemurecc27072020-01-06 16:42:34 +00001724 start_time = time_time()
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001725 presubmit_files = ListRelevantPresubmitFiles(
agable0b65e732016-11-22 09:25:46 -08001726 change.AbsoluteLocalPaths(), change.RepositoryRoot())
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001727 if not presubmit_files and verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001728 sys.stdout.write('Warning, no PRESUBMIT.py found.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001729 results = []
Edward Lesmes8e282792018-04-03 18:50:29 -04001730 thread_pool = ThreadPool()
Edward Lemur7e3c67f2018-07-20 20:52:49 +00001731 executer = PresubmitExecuter(change, committing, verbose, gerrit_obj,
Bruce Dawson09c0c072022-05-26 20:28:58 +00001732 dry_run, thread_pool, parallel, use_python3,
1733 no_diffs)
Josip Sokcevic632bbc02022-05-19 05:32:50 +00001734 skipped_count = 0;
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001735 if default_presubmit:
1736 if verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001737 sys.stdout.write('Running default presubmit script.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001738 fake_path = os.path.join(change.RepositoryRoot(), 'PRESUBMIT.py')
Josip Sokcevic632bbc02022-05-19 05:32:50 +00001739 if _ShouldRunPresubmit(default_presubmit, use_python3):
1740 results += executer.ExecPresubmitScript(default_presubmit, fake_path)
1741 else:
1742 skipped_count += 1
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001743 for filename in presubmit_files:
1744 filename = os.path.abspath(filename)
1745 if verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001746 sys.stdout.write('Running %s\n' % filename)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001747 # Accept CRLF presubmit script.
1748 presubmit_script = gclient_utils.FileRead(filename, 'rU')
Josip Sokcevic632bbc02022-05-19 05:32:50 +00001749 if _ShouldRunPresubmit(presubmit_script, use_python3):
1750 results += executer.ExecPresubmitScript(presubmit_script, filename)
1751 else:
1752 skipped_count += 1
Bruce Dawson76fe1a72022-05-25 20:52:21 +00001753
Edward Lesmes8e282792018-04-03 18:50:29 -04001754 results += thread_pool.RunAsync()
1755
Edward Lemur6eb1d322020-02-27 22:20:15 +00001756 messages = {}
1757 should_prompt = False
1758 presubmits_failed = False
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001759 for result in results:
1760 if result.fatal:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001761 presubmits_failed = True
1762 messages.setdefault('ERRORS', []).append(result)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001763 elif result.should_prompt:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001764 should_prompt = True
1765 messages.setdefault('Warnings', []).append(result)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001766 else:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001767 messages.setdefault('Messages', []).append(result)
pam@chromium.orged9a0832009-09-09 22:48:55 +00001768
Bruce Dawson76fe1a72022-05-25 20:52:21 +00001769 # Print the different message types in a consistent order. ERRORS go last
1770 # so that they will be most visible in the local-presubmit output.
1771 for name in ['Messages', 'Warnings', 'ERRORS']:
1772 if name in messages:
1773 items = messages[name]
1774 sys.stdout.write('** Presubmit %s **\n' % name)
1775 for item in items:
1776 item.handle()
1777 sys.stdout.write('\n')
pam@chromium.orged9a0832009-09-09 22:48:55 +00001778
Edward Lemurecc27072020-01-06 16:42:34 +00001779 total_time = time_time() - start_time
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001780 if total_time > 1.0:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001781 sys.stdout.write(
Louis Romero4ca9e1c2022-03-10 10:29:11 +00001782 'Presubmit checks took %.1fs to calculate.\n' % total_time)
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +00001783
Edward Lemur6eb1d322020-02-27 22:20:15 +00001784 if not should_prompt and not presubmits_failed:
Louis Romero4ca9e1c2022-03-10 10:29:11 +00001785 sys.stdout.write('%s presubmit checks passed.\n\n' % python_version)
Josip Sokcevic7592e0a2022-01-12 00:57:54 +00001786 elif should_prompt and not presubmits_failed:
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001787 sys.stdout.write('There were %s presubmit warnings. ' % python_version)
Quinten Yearsley516fe7f2016-12-14 11:50:18 -08001788 if may_prompt:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001789 presubmits_failed = not prompt_should_continue(
1790 'Are you sure you wish to continue? (y/N): ')
Garrett Beatyacb807e2020-08-28 18:17:24 +00001791 else:
1792 sys.stdout.write('\n')
Bruce Dawson76fe1a72022-05-25 20:52:21 +00001793 else:
1794 sys.stdout.write('There were %s presubmit errors.\n' % python_version)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001795
Edward Lemur1dc66e12020-02-21 21:36:34 +00001796 if json_output:
1797 # Write the presubmit results to json output
1798 presubmit_results = {
1799 'errors': [
Edward Lemur6eb1d322020-02-27 22:20:15 +00001800 error.json_format()
1801 for error in messages.get('ERRORS', [])
Edward Lemur1dc66e12020-02-21 21:36:34 +00001802 ],
1803 'notifications': [
Edward Lemur6eb1d322020-02-27 22:20:15 +00001804 notification.json_format()
1805 for notification in messages.get('Messages', [])
Edward Lemur1dc66e12020-02-21 21:36:34 +00001806 ],
1807 'warnings': [
Edward Lemur6eb1d322020-02-27 22:20:15 +00001808 warning.json_format()
1809 for warning in messages.get('Warnings', [])
Edward Lemur1dc66e12020-02-21 21:36:34 +00001810 ],
Edward Lemur6eb1d322020-02-27 22:20:15 +00001811 'more_cc': executer.more_cc,
Josip Sokcevic632bbc02022-05-19 05:32:50 +00001812 'skipped_presubmits': skipped_count,
Edward Lemur1dc66e12020-02-21 21:36:34 +00001813 }
1814
1815 gclient_utils.FileWrite(
1816 json_output, json.dumps(presubmit_results, sort_keys=True))
1817
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001818 global _ASKED_FOR_FEEDBACK
1819 # Ask for feedback one time out of 5.
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +00001820 if (results and random.randint(0, 4) == 0 and not _ASKED_FOR_FEEDBACK):
Edward Lemur6eb1d322020-02-27 22:20:15 +00001821 sys.stdout.write(
maruel@chromium.org1ce8e662014-01-14 15:23:00 +00001822 'Was the presubmit check useful? If not, run "git cl presubmit -v"\n'
1823 'to figure out which PRESUBMIT.py was run, then run git blame\n'
1824 'on the file to figure out who to ask for help.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001825 _ASKED_FOR_FEEDBACK = True
Edward Lemur6eb1d322020-02-27 22:20:15 +00001826
1827 return 1 if presubmits_failed else 0
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001828 finally:
1829 os.environ = old_environ
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001830
1831
Edward Lemur50984a62020-02-06 18:10:18 +00001832def _scan_sub_dirs(mask, recursive):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001833 if not recursive:
pgervais@chromium.orge57b09d2014-05-07 00:58:13 +00001834 return [x for x in glob.glob(mask) if x not in ('.svn', '.git')]
Lei Zhang9611c4c2017-04-04 01:41:56 -07001835
1836 results = []
1837 for root, dirs, files in os.walk('.'):
1838 if '.svn' in dirs:
1839 dirs.remove('.svn')
1840 if '.git' in dirs:
1841 dirs.remove('.git')
1842 for name in files:
1843 if fnmatch.fnmatch(name, mask):
1844 results.append(os.path.join(root, name))
1845 return results
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001846
1847
Edward Lemur50984a62020-02-06 18:10:18 +00001848def _parse_files(args, recursive):
tobiasjs2836bcf2016-08-16 04:08:16 -07001849 logging.debug('Searching for %s', args)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001850 files = []
1851 for arg in args:
Edward Lemur50984a62020-02-06 18:10:18 +00001852 files.extend([('M', f) for f in _scan_sub_dirs(arg, recursive)])
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001853 return files
1854
1855
Edward Lemur50984a62020-02-06 18:10:18 +00001856def _parse_change(parser, options):
1857 """Process change options.
1858
1859 Args:
1860 parser: The parser used to parse the arguments from command line.
1861 options: The arguments parsed from command line.
1862 Returns:
1863 A GitChange if the change root is a git repository, or a Change otherwise.
1864 """
1865 if options.files and options.all_files:
1866 parser.error('<files> cannot be specified when --all-files is set.')
1867
Edward Lesmes44ea3ff2020-02-05 00:14:30 +00001868 change_scm = scm.determine_scm(options.root)
Edward Lemur50984a62020-02-06 18:10:18 +00001869 if change_scm != 'git' and not options.files:
1870 parser.error('<files> is not optional for unversioned directories.')
1871
1872 if options.files:
Josip Sokcevic017544d2022-03-31 23:47:53 +00001873 if options.source_controlled_only:
1874 # Get the filtered set of files from SCM.
1875 change_files = []
1876 for name in scm.GIT.GetAllFiles(options.root):
1877 for mask in options.files:
1878 if fnmatch.fnmatch(name, mask):
1879 change_files.append(('M', name))
1880 break
1881 else:
1882 # Get the filtered set of files from a directory scan.
1883 change_files = _parse_files(options.files, options.recursive)
Edward Lemur50984a62020-02-06 18:10:18 +00001884 elif options.all_files:
1885 change_files = [('M', f) for f in scm.GIT.GetAllFiles(options.root)]
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001886 else:
Edward Lemur50984a62020-02-06 18:10:18 +00001887 change_files = scm.GIT.CaptureStatus(
Edward Lemur7f6dec02020-02-06 20:23:58 +00001888 options.root, options.upstream or None)
Edward Lemur50984a62020-02-06 18:10:18 +00001889
1890 logging.info('Found %d file(s).', len(change_files))
1891
1892 change_class = GitChange if change_scm == 'git' else Change
1893 return change_class(
1894 options.name,
1895 options.description,
1896 options.root,
1897 change_files,
1898 options.issue,
1899 options.patchset,
1900 options.author,
1901 upstream=options.upstream)
1902
1903
1904def _parse_gerrit_options(parser, options):
1905 """Process gerrit options.
1906
1907 SIDE EFFECTS: Modifies options.author and options.description from Gerrit if
1908 options.gerrit_fetch is set.
1909
1910 Args:
1911 parser: The parser used to parse the arguments from command line.
1912 options: The arguments parsed from command line.
1913 Returns:
Stephen Martinisfb09de22021-02-25 03:41:13 +00001914 A GerritAccessor object if options.gerrit_url is set, or None otherwise.
Edward Lemur50984a62020-02-06 18:10:18 +00001915 """
1916 gerrit_obj = None
Stephen Martinisfb09de22021-02-25 03:41:13 +00001917 if options.gerrit_url:
Edward Lesmeseb1bd622021-03-01 19:54:07 +00001918 gerrit_obj = GerritAccessor(
1919 url=options.gerrit_url,
1920 project=options.gerrit_project,
1921 branch=options.gerrit_branch)
Edward Lemur50984a62020-02-06 18:10:18 +00001922
1923 if not options.gerrit_fetch:
1924 return gerrit_obj
1925
1926 if not options.gerrit_url or not options.issue or not options.patchset:
1927 parser.error(
1928 '--gerrit_fetch requires --gerrit_url, --issue and --patchset.')
1929
1930 options.author = gerrit_obj.GetChangeOwner(options.issue)
1931 options.description = gerrit_obj.GetChangeDescription(
1932 options.issue, options.patchset)
1933
1934 logging.info('Got author: "%s"', options.author)
1935 logging.info('Got description: """\n%s\n"""', options.description)
1936
1937 return gerrit_obj
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001938
1939
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001940@contextlib.contextmanager
1941def canned_check_filter(method_names):
1942 filtered = {}
1943 try:
1944 for method_name in method_names:
1945 if not hasattr(presubmit_canned_checks, method_name):
Gavin Make6a62332020-12-04 21:57:10 +00001946 logging.warning('Skipping unknown "canned" check %s' % method_name)
Aaron Gableecee74c2018-04-02 15:13:08 -07001947 continue
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001948 filtered[method_name] = getattr(presubmit_canned_checks, method_name)
1949 setattr(presubmit_canned_checks, method_name, lambda *_a, **_kw: [])
1950 yield
1951 finally:
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001952 for name, method in filtered.items():
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001953 setattr(presubmit_canned_checks, name, method)
1954
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +00001955
sbc@chromium.org013731e2015-02-26 18:28:43 +00001956def main(argv=None):
Edward Lemura5799e32020-01-17 19:26:51 +00001957 parser = argparse.ArgumentParser(usage='%(prog)s [options] <files...>')
1958 hooks = parser.add_mutually_exclusive_group()
1959 hooks.add_argument('-c', '--commit', action='store_true',
1960 help='Use commit instead of upload checks.')
1961 hooks.add_argument('-u', '--upload', action='store_false', dest='commit',
1962 help='Use upload instead of commit checks.')
Edward Lemur75526302020-02-27 22:31:05 +00001963 hooks.add_argument('--post_upload', action='store_true',
1964 help='Run post-upload commit hooks.')
Edward Lemura5799e32020-01-17 19:26:51 +00001965 parser.add_argument('-r', '--recursive', action='store_true',
1966 help='Act recursively.')
1967 parser.add_argument('-v', '--verbose', action='count', default=0,
1968 help='Use 2 times for more debug info.')
1969 parser.add_argument('--name', default='no name')
1970 parser.add_argument('--author')
Edward Lemur227d5102020-02-25 23:45:35 +00001971 desc = parser.add_mutually_exclusive_group()
1972 desc.add_argument('--description', default='', help='The change description.')
1973 desc.add_argument('--description_file',
1974 help='File to read change description from.')
Edward Lemura5799e32020-01-17 19:26:51 +00001975 parser.add_argument('--issue', type=int, default=0)
1976 parser.add_argument('--patchset', type=int, default=0)
1977 parser.add_argument('--root', default=os.getcwd(),
1978 help='Search for PRESUBMIT.py up to this directory. '
1979 'If inherit-review-settings-ok is present in this '
1980 'directory, parent directories up to the root file '
1981 'system directories will also be searched.')
1982 parser.add_argument('--upstream',
1983 help='Git only: the base ref or upstream branch against '
1984 'which the diff should be computed.')
1985 parser.add_argument('--default_presubmit')
1986 parser.add_argument('--may_prompt', action='store_true', default=False)
1987 parser.add_argument('--skip_canned', action='append', default=[],
1988 help='A list of checks to skip which appear in '
1989 'presubmit_canned_checks. Can be provided multiple times '
1990 'to skip multiple canned checks.')
1991 parser.add_argument('--dry_run', action='store_true', help=argparse.SUPPRESS)
1992 parser.add_argument('--gerrit_url', help=argparse.SUPPRESS)
Edward Lesmeseb1bd622021-03-01 19:54:07 +00001993 parser.add_argument('--gerrit_project', help=argparse.SUPPRESS)
1994 parser.add_argument('--gerrit_branch', help=argparse.SUPPRESS)
Edward Lemura5799e32020-01-17 19:26:51 +00001995 parser.add_argument('--gerrit_fetch', action='store_true',
1996 help=argparse.SUPPRESS)
1997 parser.add_argument('--parallel', action='store_true',
1998 help='Run all tests specified by input_api.RunTests in '
1999 'all PRESUBMIT files in parallel.')
2000 parser.add_argument('--json_output',
2001 help='Write presubmit errors to json output.')
Edward Lemur1dc66e12020-02-21 21:36:34 +00002002 parser.add_argument('--all_files', action='store_true',
Edward Lemur50984a62020-02-06 18:10:18 +00002003 help='Mark all files under source control as modified.')
Bruce Dawson09c0c072022-05-26 20:28:58 +00002004
Edward Lemura5799e32020-01-17 19:26:51 +00002005 parser.add_argument('files', nargs='*',
2006 help='List of files to be marked as modified when '
2007 'executing presubmit or post-upload hooks. fnmatch '
2008 'wildcards can also be used.')
Josip Sokcevic017544d2022-03-31 23:47:53 +00002009 parser.add_argument('--source_controlled_only', action='store_true',
2010 help='Constrain \'files\' to those in source control.')
Dirk Pranke6f0df682021-06-25 00:42:33 +00002011 parser.add_argument('--use-python3', action='store_true',
2012 help='Use python3 for presubmit checks by default')
Bruce Dawson09c0c072022-05-26 20:28:58 +00002013 parser.add_argument('--no_diffs', action='store_true',
2014 help='Assume that all "modified" files have no diffs.')
Edward Lemura5799e32020-01-17 19:26:51 +00002015 options = parser.parse_args(argv)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00002016
Erik Staabcca5c492020-04-16 17:40:07 +00002017 log_level = logging.ERROR
maruel@chromium.org899e1c12011-04-07 17:03:18 +00002018 if options.verbose >= 2:
Erik Staabcca5c492020-04-16 17:40:07 +00002019 log_level = logging.DEBUG
maruel@chromium.org899e1c12011-04-07 17:03:18 +00002020 elif options.verbose:
Erik Staabcca5c492020-04-16 17:40:07 +00002021 log_level = logging.INFO
2022 log_format = ('[%(levelname).1s%(asctime)s %(process)d %(thread)d '
2023 '%(filename)s] %(message)s')
2024 logging.basicConfig(format=log_format, level=log_level)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00002025
Edward Lemur227d5102020-02-25 23:45:35 +00002026 if options.description_file:
2027 options.description = gclient_utils.FileRead(options.description_file)
Edward Lemur50984a62020-02-06 18:10:18 +00002028 gerrit_obj = _parse_gerrit_options(parser, options)
2029 change = _parse_change(parser, options)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00002030
maruel@chromium.org899e1c12011-04-07 17:03:18 +00002031 try:
Edward Lemur75526302020-02-27 22:31:05 +00002032 if options.post_upload:
Josip Sokcevice293d3d2022-02-16 22:52:15 +00002033 return DoPostUploadExecuter(change, gerrit_obj, options.verbose,
2034 options.use_python3)
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00002035 with canned_check_filter(options.skip_canned):
Edward Lemur6eb1d322020-02-27 22:20:15 +00002036 return DoPresubmitChecks(
Edward Lemur50984a62020-02-06 18:10:18 +00002037 change,
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00002038 options.commit,
2039 options.verbose,
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00002040 options.default_presubmit,
2041 options.may_prompt,
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00002042 gerrit_obj,
Edward Lesmes8e282792018-04-03 18:50:29 -04002043 options.dry_run,
Debrian Figueroadd2737e2019-06-21 23:50:13 +00002044 options.parallel,
Dirk Pranke6f0df682021-06-25 00:42:33 +00002045 options.json_output,
Bruce Dawson09c0c072022-05-26 20:28:58 +00002046 options.use_python3,
2047 options.no_diffs)
Raul Tambre7c938462019-05-24 16:35:35 +00002048 except PresubmitFailure as e:
Josip Sokcevic0399e172022-03-21 23:11:51 +00002049 import utils
Raul Tambre80ee78e2019-05-06 22:41:05 +00002050 print(e, file=sys.stderr)
2051 print('Maybe your depot_tools is out of date?', file=sys.stderr)
Josip Sokcevic0399e172022-03-21 23:11:51 +00002052 print('depot_tools version: %s' % utils.depot_tools_version(),
2053 file=sys.stderr)
maruel@chromium.org899e1c12011-04-07 17:03:18 +00002054 return 2
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00002055
2056
2057if __name__ == '__main__':
maruel@chromium.org35625c72011-03-23 17:34:02 +00002058 fix_encoding.fix_encoding()
sbc@chromium.org013731e2015-02-26 18:28:43 +00002059 try:
2060 sys.exit(main())
2061 except KeyboardInterrupt:
2062 sys.stderr.write('interrupted\n')
sergiybf8a3b382016-07-05 11:21:30 -07002063 sys.exit(2)