blob: 4e1fb2a7f5d75505a673c3ab213b2a95cfa061d8 [file] [log] [blame]
maruel@chromium.org725f1c32011-04-01 20:24:54 +00001#!/usr/bin/env python
maruel@chromium.org3bbf2942012-01-10 16:52:06 +00002# Copyright (c) 2012 The Chromium Authors. All rights reserved.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00003# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5
6"""Enables directory-specific presubmit checks to run at upload and/or commit.
7"""
8
Raul Tambre80ee78e2019-05-06 22:41:05 +00009from __future__ import print_function
10
Saagar Sanghavi99816902020-08-11 22:41:25 +000011__version__ = '2.0.0'
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000012
13# TODO(joi) Add caching where appropriate/needed. The API is designed to allow
14# caching (between all different invocations of presubmit scripts for a given
15# change). We should add it as our presubmit scripts start feeling slow.
16
Edward Lemura5799e32020-01-17 19:26:51 +000017import argparse
Takeshi Yoshino07a6bea2017-08-02 02:44:06 +090018import ast # Exposed through the API.
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +000019import contextlib
Yoshisato Yanagisawa406de132018-06-29 05:43:25 +000020import cpplint
dcheng091b7db2016-06-16 01:27:51 -070021import fnmatch # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000022import glob
asvitkine@chromium.org15169952011-09-27 14:30:53 +000023import inspect
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +000024import itertools
maruel@chromium.org4f6852c2012-04-20 20:39:20 +000025import json # Exposed through the API.
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +000026import logging
ilevy@chromium.orgbc117312013-04-20 03:57:56 +000027import multiprocessing
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000028import os # Somewhat exposed through the API.
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +000029import random
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000030import re # Exposed through the API.
Edward Lesmes8e282792018-04-03 18:50:29 -040031import signal
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000032import sys # Parts exposed through API.
33import tempfile # Exposed through the API.
Edward Lesmes8e282792018-04-03 18:50:29 -040034import threading
jam@chromium.org2a891dc2009-08-20 20:33:37 +000035import time
Edward Lemurde9e3ca2019-10-24 21:13:31 +000036import traceback
maruel@chromium.org1487d532009-06-06 00:22:57 +000037import unittest # Exposed through the API.
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +000038from warnings import warn
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000039
40# Local imports.
maruel@chromium.org35625c72011-03-23 17:34:02 +000041import fix_encoding
Yoshisato Yanagisawa04600b42019-03-15 03:03:41 +000042import gclient_paths # Exposed through the API
43import gclient_utils
Aaron Gableb584c4f2017-04-26 16:28:08 -070044import git_footers
tandrii@chromium.org015ebae2016-04-25 19:37:22 +000045import gerrit_util
Edward Lesmes9ce03f82021-01-12 20:13:31 +000046import owners as owners_db
47import owners_client
Jochen Eisinger76f5fc62017-04-07 16:27:46 +020048import owners_finder
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000049import presubmit_canned_checks
Saagar Sanghavi9949ab72020-07-20 20:56:40 +000050import rdb_wrapper
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +000051import scm
maruel@chromium.org84f4fe32011-04-06 13:26:45 +000052import subprocess2 as subprocess # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000053
Edward Lemur16af3562019-10-17 22:11:33 +000054if sys.version_info.major == 2:
55 # TODO(1009814): Expose urllib2 only through urllib_request and urllib_error
56 import urllib2 # Exposed through the API.
57 import urlparse
58 import urllib2 as urllib_request
59 import urllib2 as urllib_error
60else:
61 import urllib.parse as urlparse
62 import urllib.request as urllib_request
63 import urllib.error as urllib_error
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000064
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +000065# Ask for feedback only once in program lifetime.
66_ASKED_FOR_FEEDBACK = False
67
Edward Lemurecc27072020-01-06 16:42:34 +000068def time_time():
69 # Use this so that it can be mocked in tests without interfering with python
70 # system machinery.
71 return time.time()
72
73
maruel@chromium.org899e1c12011-04-07 17:03:18 +000074class PresubmitFailure(Exception):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000075 pass
76
77
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000078class CommandData(object):
Edward Lemur940c2822019-08-23 00:34:25 +000079 def __init__(self, name, cmd, kwargs, message, python3=False):
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000080 self.name = name
81 self.cmd = cmd
Edward Lesmes8e282792018-04-03 18:50:29 -040082 self.stdin = kwargs.get('stdin', None)
Edward Lemur2d6b67c2019-08-23 22:25:41 +000083 self.kwargs = kwargs.copy()
Edward Lesmes8e282792018-04-03 18:50:29 -040084 self.kwargs['stdout'] = subprocess.PIPE
85 self.kwargs['stderr'] = subprocess.STDOUT
86 self.kwargs['stdin'] = subprocess.PIPE
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000087 self.message = message
88 self.info = None
Edward Lemur940c2822019-08-23 00:34:25 +000089 self.python3 = python3
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000090
ilevy@chromium.orgbc117312013-04-20 03:57:56 +000091
Edward Lesmes8e282792018-04-03 18:50:29 -040092# Adapted from
93# https://github.com/google/gtest-parallel/blob/master/gtest_parallel.py#L37
94#
95# An object that catches SIGINT sent to the Python process and notices
96# if processes passed to wait() die by SIGINT (we need to look for
97# both of those cases, because pressing Ctrl+C can result in either
98# the main process or one of the subprocesses getting the signal).
99#
100# Before a SIGINT is seen, wait(p) will simply call p.wait() and
101# return the result. Once a SIGINT has been seen (in the main process
102# or a subprocess, including the one the current call is waiting for),
Edward Lemur9a5bb612019-09-26 02:01:52 +0000103# wait(p) will call p.terminate().
Edward Lesmes8e282792018-04-03 18:50:29 -0400104class SigintHandler(object):
Edward Lesmes8e282792018-04-03 18:50:29 -0400105 sigint_returncodes = {-signal.SIGINT, # Unix
106 -1073741510, # Windows
107 }
108 def __init__(self):
109 self.__lock = threading.Lock()
110 self.__processes = set()
111 self.__got_sigint = False
Edward Lemur9a5bb612019-09-26 02:01:52 +0000112 self.__previous_signal = signal.signal(signal.SIGINT, self.interrupt)
Edward Lesmes8e282792018-04-03 18:50:29 -0400113
114 def __on_sigint(self):
115 self.__got_sigint = True
116 while self.__processes:
117 try:
118 self.__processes.pop().terminate()
119 except OSError:
120 pass
121
Edward Lemur9a5bb612019-09-26 02:01:52 +0000122 def interrupt(self, signal_num, frame):
Edward Lesmes8e282792018-04-03 18:50:29 -0400123 with self.__lock:
124 self.__on_sigint()
Edward Lemur9a5bb612019-09-26 02:01:52 +0000125 self.__previous_signal(signal_num, frame)
Edward Lesmes8e282792018-04-03 18:50:29 -0400126
127 def got_sigint(self):
128 with self.__lock:
129 return self.__got_sigint
130
131 def wait(self, p, stdin):
132 with self.__lock:
133 if self.__got_sigint:
134 p.terminate()
135 self.__processes.add(p)
136 stdout, stderr = p.communicate(stdin)
137 code = p.returncode
138 with self.__lock:
139 self.__processes.discard(p)
140 if code in self.sigint_returncodes:
141 self.__on_sigint()
Edward Lesmes8e282792018-04-03 18:50:29 -0400142 return stdout, stderr
143
144sigint_handler = SigintHandler()
145
146
Edward Lemurecc27072020-01-06 16:42:34 +0000147class Timer(object):
148 def __init__(self, timeout, fn):
149 self.completed = False
150 self._fn = fn
151 self._timer = threading.Timer(timeout, self._onTimer) if timeout else None
152
153 def __enter__(self):
154 if self._timer:
155 self._timer.start()
156 return self
157
158 def __exit__(self, _type, _value, _traceback):
159 if self._timer:
160 self._timer.cancel()
161
162 def _onTimer(self):
163 self._fn()
164 self.completed = True
165
166
Edward Lesmes8e282792018-04-03 18:50:29 -0400167class ThreadPool(object):
Edward Lemurecc27072020-01-06 16:42:34 +0000168 def __init__(self, pool_size=None, timeout=None):
169 self.timeout = timeout
Edward Lesmes8e282792018-04-03 18:50:29 -0400170 self._pool_size = pool_size or multiprocessing.cpu_count()
171 self._messages = []
172 self._messages_lock = threading.Lock()
173 self._tests = []
174 self._tests_lock = threading.Lock()
175 self._nonparallel_tests = []
176
Edward Lemurecc27072020-01-06 16:42:34 +0000177 def _GetCommand(self, test):
Edward Lemur940c2822019-08-23 00:34:25 +0000178 vpython = 'vpython'
179 if test.python3:
180 vpython += '3'
181 if sys.platform == 'win32':
182 vpython += '.bat'
Edward Lesmes8e282792018-04-03 18:50:29 -0400183
184 cmd = test.cmd
185 if cmd[0] == 'python':
186 cmd = list(cmd)
187 cmd[0] = vpython
188 elif cmd[0].endswith('.py'):
189 cmd = [vpython] + cmd
190
Edward Lemur336e51f2019-11-14 21:42:04 +0000191 # On Windows, scripts on the current directory take precedence over PATH, so
192 # that when testing depot_tools on Windows, calling `vpython.bat` will
193 # execute the copy of vpython of the depot_tools under test instead of the
194 # one in the bot.
195 # As a workaround, we run the tests from the parent directory instead.
196 if (cmd[0] == vpython and
197 'cwd' in test.kwargs and
198 os.path.basename(test.kwargs['cwd']) == 'depot_tools'):
199 test.kwargs['cwd'] = os.path.dirname(test.kwargs['cwd'])
200 cmd[1] = os.path.join('depot_tools', cmd[1])
201
Edward Lemurecc27072020-01-06 16:42:34 +0000202 return cmd
203
204 def _RunWithTimeout(self, cmd, stdin, kwargs):
205 p = subprocess.Popen(cmd, **kwargs)
206 with Timer(self.timeout, p.terminate) as timer:
207 stdout, _ = sigint_handler.wait(p, stdin)
208 if timer.completed:
209 stdout = 'Process timed out after %ss\n%s' % (self.timeout, stdout)
210 return p.returncode, stdout
211
212 def CallCommand(self, test):
213 """Runs an external program.
214
Edward Lemura5799e32020-01-17 19:26:51 +0000215 This function converts invocation of .py files and invocations of 'python'
Edward Lemurecc27072020-01-06 16:42:34 +0000216 to vpython invocations.
217 """
218 cmd = self._GetCommand(test)
Edward Lesmes8e282792018-04-03 18:50:29 -0400219 try:
Edward Lemurecc27072020-01-06 16:42:34 +0000220 start = time_time()
221 returncode, stdout = self._RunWithTimeout(cmd, test.stdin, test.kwargs)
222 duration = time_time() - start
Edward Lemur7cf94382019-11-15 22:36:41 +0000223 except Exception:
Edward Lemurecc27072020-01-06 16:42:34 +0000224 duration = time_time() - start
Edward Lesmes8e282792018-04-03 18:50:29 -0400225 return test.message(
Edward Lemur7cf94382019-11-15 22:36:41 +0000226 '%s\n%s exec failure (%4.2fs)\n%s' % (
227 test.name, ' '.join(cmd), duration, traceback.format_exc()))
Edward Lemurde9e3ca2019-10-24 21:13:31 +0000228
Edward Lemurecc27072020-01-06 16:42:34 +0000229 if returncode != 0:
Edward Lesmes8e282792018-04-03 18:50:29 -0400230 return test.message(
Edward Lemur7cf94382019-11-15 22:36:41 +0000231 '%s\n%s (%4.2fs) failed\n%s' % (
232 test.name, ' '.join(cmd), duration, stdout))
Edward Lemurecc27072020-01-06 16:42:34 +0000233
Edward Lesmes8e282792018-04-03 18:50:29 -0400234 if test.info:
Edward Lemur7cf94382019-11-15 22:36:41 +0000235 return test.info('%s\n%s (%4.2fs)' % (test.name, ' '.join(cmd), duration))
Edward Lesmes8e282792018-04-03 18:50:29 -0400236
237 def AddTests(self, tests, parallel=True):
238 if parallel:
239 self._tests.extend(tests)
240 else:
241 self._nonparallel_tests.extend(tests)
242
243 def RunAsync(self):
244 self._messages = []
245
246 def _WorkerFn():
247 while True:
248 test = None
249 with self._tests_lock:
250 if not self._tests:
251 break
252 test = self._tests.pop()
253 result = self.CallCommand(test)
254 if result:
255 with self._messages_lock:
256 self._messages.append(result)
257
258 def _StartDaemon():
259 t = threading.Thread(target=_WorkerFn)
260 t.daemon = True
261 t.start()
262 return t
263
264 while self._nonparallel_tests:
265 test = self._nonparallel_tests.pop()
266 result = self.CallCommand(test)
267 if result:
268 self._messages.append(result)
269
270 if self._tests:
271 threads = [_StartDaemon() for _ in range(self._pool_size)]
272 for worker in threads:
273 worker.join()
274
275 return self._messages
276
277
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000278def normpath(path):
279 '''Version of os.path.normpath that also changes backward slashes to
280 forward slashes when not running on Windows.
281 '''
282 # This is safe to always do because the Windows version of os.path.normpath
283 # will replace forward slashes with backward slashes.
284 path = path.replace(os.sep, '/')
285 return os.path.normpath(path)
286
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000287
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000288def _RightHandSideLinesImpl(affected_files):
289 """Implements RightHandSideLines for InputApi and GclChange."""
290 for af in affected_files:
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000291 lines = af.ChangedContents()
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000292 for line in lines:
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000293 yield (af, line[0], line[1])
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000294
295
Edward Lemur6eb1d322020-02-27 22:20:15 +0000296def prompt_should_continue(prompt_string):
297 sys.stdout.write(prompt_string)
298 response = sys.stdin.readline().strip().lower()
299 return response in ('y', 'yes')
dpranke@chromium.org5ac21012011-03-16 02:58:25 +0000300
301
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000302# Top level object so multiprocessing can pickle
303# Public access through OutputApi object.
304class _PresubmitResult(object):
305 """Base class for result objects."""
306 fatal = False
307 should_prompt = False
308
309 def __init__(self, message, items=None, long_text=''):
310 """
311 message: A short one-line message to indicate errors.
312 items: A list of short strings to indicate where errors occurred.
313 long_text: multi-line text output, e.g. from another tool
314 """
315 self._message = message
316 self._items = items or []
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000317 self._long_text = long_text.rstrip()
318
Edward Lemur6eb1d322020-02-27 22:20:15 +0000319 def handle(self):
320 sys.stdout.write(self._message)
321 sys.stdout.write('\n')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000322 for index, item in enumerate(self._items):
Edward Lemur6eb1d322020-02-27 22:20:15 +0000323 sys.stdout.write(' ')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000324 # Write separately in case it's unicode.
Edward Lemur6eb1d322020-02-27 22:20:15 +0000325 sys.stdout.write(str(item))
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000326 if index < len(self._items) - 1:
Edward Lemur6eb1d322020-02-27 22:20:15 +0000327 sys.stdout.write(' \\')
328 sys.stdout.write('\n')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000329 if self._long_text:
Edward Lemur6eb1d322020-02-27 22:20:15 +0000330 sys.stdout.write('\n***************\n')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000331 # Write separately in case it's unicode.
Edward Lemur6eb1d322020-02-27 22:20:15 +0000332 sys.stdout.write(self._long_text)
333 sys.stdout.write('\n***************\n')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000334
Debrian Figueroadd2737e2019-06-21 23:50:13 +0000335 def json_format(self):
336 return {
337 'message': self._message,
Debrian Figueroa6095d402019-06-28 18:47:18 +0000338 'items': [str(item) for item in self._items],
Debrian Figueroadd2737e2019-06-21 23:50:13 +0000339 'long_text': self._long_text,
340 'fatal': self.fatal
341 }
342
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000343
344# Top level object so multiprocessing can pickle
345# Public access through OutputApi object.
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000346class _PresubmitError(_PresubmitResult):
347 """A hard presubmit error."""
348 fatal = True
349
350
351# Top level object so multiprocessing can pickle
352# Public access through OutputApi object.
353class _PresubmitPromptWarning(_PresubmitResult):
354 """An warning that prompts the user if they want to continue."""
355 should_prompt = True
356
357
358# Top level object so multiprocessing can pickle
359# Public access through OutputApi object.
360class _PresubmitNotifyResult(_PresubmitResult):
361 """Just print something to the screen -- but it's not even a warning."""
362 pass
363
364
365# Top level object so multiprocessing can pickle
366# Public access through OutputApi object.
367class _MailTextResult(_PresubmitResult):
368 """A warning that should be included in the review request email."""
369 def __init__(self, *args, **kwargs):
370 super(_MailTextResult, self).__init__()
371 raise NotImplementedError()
372
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000373class GerritAccessor(object):
374 """Limited Gerrit functionality for canned presubmit checks to work.
375
376 To avoid excessive Gerrit calls, caches the results.
377 """
378
Edward Lesmeseb1bd622021-03-01 19:54:07 +0000379 def __init__(self, url=None, project=None, branch=None):
380 self.host = urlparse.urlparse(url).netloc if url else None
381 self.project = project
382 self.branch = branch
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000383 self.cache = {}
Edward Lesmes8170c292021-03-19 20:04:43 +0000384 self.code_owners_enabled = None
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000385
386 def _FetchChangeDetail(self, issue):
387 # Separate function to be easily mocked in tests.
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +0100388 try:
389 return gerrit_util.GetChangeDetail(
390 self.host, str(issue),
Aaron Gable6f5a8d92017-04-18 14:49:05 -0700391 ['ALL_REVISIONS', 'DETAILED_LABELS', 'ALL_COMMITS'])
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +0100392 except gerrit_util.GerritError as e:
393 if e.http_status == 404:
394 raise Exception('Either Gerrit issue %s doesn\'t exist, or '
395 'no credentials to fetch issue details' % issue)
396 raise
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000397
398 def GetChangeInfo(self, issue):
399 """Returns labels and all revisions (patchsets) for this issue.
400
401 The result is a dictionary according to Gerrit REST Api.
402 https://gerrit-review.googlesource.com/Documentation/rest-api.html
403
404 However, API isn't very clear what's inside, so see tests for example.
405 """
406 assert issue
407 cache_key = int(issue)
408 if cache_key not in self.cache:
409 self.cache[cache_key] = self._FetchChangeDetail(issue)
410 return self.cache[cache_key]
411
412 def GetChangeDescription(self, issue, patchset=None):
413 """If patchset is none, fetches current patchset."""
414 info = self.GetChangeInfo(issue)
415 # info is a reference to cache. We'll modify it here adding description to
416 # it to the right patchset, if it is not yet there.
417
418 # Find revision info for the patchset we want.
419 if patchset is not None:
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +0000420 for rev, rev_info in info['revisions'].items():
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000421 if str(rev_info['_number']) == str(patchset):
422 break
423 else:
424 raise Exception('patchset %s doesn\'t exist in issue %s' % (
425 patchset, issue))
426 else:
427 rev = info['current_revision']
428 rev_info = info['revisions'][rev]
429
Andrii Shyshkalov9c3a4642017-01-24 17:41:22 +0100430 return rev_info['commit']['message']
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000431
Mun Yong Jang603d01e2017-12-19 16:38:30 -0800432 def GetDestRef(self, issue):
433 ref = self.GetChangeInfo(issue)['branch']
434 if not ref.startswith('refs/'):
435 # NOTE: it is possible to create 'refs/x' branch,
436 # aka 'refs/heads/refs/x'. However, this is ill-advised.
437 ref = 'refs/heads/%s' % ref
438 return ref
439
Edward Lesmes02d4b822020-11-11 00:37:35 +0000440 def _GetApproversForLabel(self, issue, label):
441 change_info = self.GetChangeInfo(issue)
442 label_info = change_info.get('labels', {}).get(label, {})
443 values = label_info.get('values', {}).keys()
444 if not values:
445 return []
446 max_value = max(int(v) for v in values)
447 return [v for v in label_info.get('all', [])
448 if v.get('value', 0) == max_value]
449
Edward Lesmesc4566172021-03-19 16:55:13 +0000450 def IsBotCommitApproved(self, issue):
451 return bool(self._GetApproversForLabel(issue, 'Bot-Commit'))
452
Edward Lesmescf49cb82020-11-11 01:08:36 +0000453 def IsOwnersOverrideApproved(self, issue):
454 return bool(self._GetApproversForLabel(issue, 'Owners-Override'))
455
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000456 def GetChangeOwner(self, issue):
457 return self.GetChangeInfo(issue)['owner']['email']
458
459 def GetChangeReviewers(self, issue, approving_only=True):
Aaron Gable8b478f02017-07-31 15:33:19 -0700460 changeinfo = self.GetChangeInfo(issue)
461 if approving_only:
Edward Lesmes02d4b822020-11-11 00:37:35 +0000462 reviewers = self._GetApproversForLabel(issue, 'Code-Review')
Aaron Gable8b478f02017-07-31 15:33:19 -0700463 else:
464 reviewers = changeinfo.get('reviewers', {}).get('REVIEWER', [])
465 return [r.get('email') for r in reviewers]
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000466
Edward Lemure4d329c2020-02-03 20:41:18 +0000467 def UpdateDescription(self, description, issue):
468 gerrit_util.SetCommitMessage(self.host, issue, description, notify='NONE')
469
Edward Lesmes8170c292021-03-19 20:04:43 +0000470 def IsCodeOwnersEnabledOnRepo(self):
471 if self.code_owners_enabled is None:
472 self.code_owners_enabled = gerrit_util.IsCodeOwnersEnabledOnRepo(
Edward Lesmes392c4072021-03-19 21:58:45 +0000473 self.host, self.project)
Edward Lesmes8170c292021-03-19 20:04:43 +0000474 return self.code_owners_enabled
475
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000476
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000477class OutputApi(object):
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000478 """An instance of OutputApi gets passed to presubmit scripts so that they
479 can output various types of results.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000480 """
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000481 PresubmitResult = _PresubmitResult
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000482 PresubmitError = _PresubmitError
483 PresubmitPromptWarning = _PresubmitPromptWarning
484 PresubmitNotifyResult = _PresubmitNotifyResult
485 MailTextResult = _MailTextResult
486
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000487 def __init__(self, is_committing):
488 self.is_committing = is_committing
Daniel Cheng7227d212017-11-17 08:12:37 -0800489 self.more_cc = []
490
491 def AppendCC(self, cc):
492 """Appends a user to cc for this change."""
493 self.more_cc.append(cc)
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000494
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000495 def PresubmitPromptOrNotify(self, *args, **kwargs):
496 """Warn the user when uploading, but only notify if committing."""
497 if self.is_committing:
498 return self.PresubmitNotifyResult(*args, **kwargs)
499 return self.PresubmitPromptWarning(*args, **kwargs)
500
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000501
502class InputApi(object):
503 """An instance of this object is passed to presubmit scripts so they can
504 know stuff about the change they're looking at.
505 """
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000506 # Method could be a function
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800507 # pylint: disable=no-self-use
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000508
maruel@chromium.org3410d912009-06-09 20:56:16 +0000509 # File extensions that are considered source files from a style guide
510 # perspective. Don't modify this list from a presubmit script!
maruel@chromium.orgc33455a2011-06-24 19:14:18 +0000511 #
512 # Files without an extension aren't included in the list. If you want to
local_bot30f774e2020-06-25 18:23:34 +0000513 # filter them as source files, add r'(^|.*?[\\\/])[^.]+$' to the allow list.
local_bot64021412020-07-08 21:05:39 +0000514 # Note that ALL CAPS files are skipped in DEFAULT_FILES_TO_SKIP below.
515 DEFAULT_FILES_TO_CHECK = (
maruel@chromium.org3410d912009-06-09 20:56:16 +0000516 # C++ and friends
Edward Lemura5799e32020-01-17 19:26:51 +0000517 r'.+\.c$', r'.+\.cc$', r'.+\.cpp$', r'.+\.h$', r'.+\.m$', r'.+\.mm$',
518 r'.+\.inl$', r'.+\.asm$', r'.+\.hxx$', r'.+\.hpp$', r'.+\.s$', r'.+\.S$',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000519 # Scripts
Edward Lemura5799e32020-01-17 19:26:51 +0000520 r'.+\.js$', r'.+\.py$', r'.+\.sh$', r'.+\.rb$', r'.+\.pl$', r'.+\.pm$',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000521 # Other
Edward Lemura5799e32020-01-17 19:26:51 +0000522 r'.+\.java$', r'.+\.mk$', r'.+\.am$', r'.+\.css$', r'.+\.mojom$',
523 r'.+\.fidl$'
maruel@chromium.org3410d912009-06-09 20:56:16 +0000524 )
525
526 # Path regexp that should be excluded from being considered containing source
527 # files. Don't modify this list from a presubmit script!
local_bot64021412020-07-08 21:05:39 +0000528 DEFAULT_FILES_TO_SKIP = (
Edward Lemura5799e32020-01-17 19:26:51 +0000529 r'testing_support[\\\/]google_appengine[\\\/].*',
530 r'.*\bexperimental[\\\/].*',
Kent Tamura179dd1e2018-04-26 15:07:41 +0900531 # Exclude third_party/.* but NOT third_party/{WebKit,blink}
532 # (crbug.com/539768 and crbug.com/836555).
Edward Lemura5799e32020-01-17 19:26:51 +0000533 r'.*\bthird_party[\\\/](?!(WebKit|blink)[\\\/]).*',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000534 # Output directories (just in case)
Edward Lemura5799e32020-01-17 19:26:51 +0000535 r'.*\bDebug[\\\/].*',
536 r'.*\bRelease[\\\/].*',
537 r'.*\bxcodebuild[\\\/].*',
538 r'.*\bout[\\\/].*',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000539 # All caps files like README and LICENCE.
Edward Lemura5799e32020-01-17 19:26:51 +0000540 r'.*\b[A-Z0-9_]{2,}$',
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +0000541 # SCM (can happen in dual SCM configuration). (Slightly over aggressive)
Edward Lemura5799e32020-01-17 19:26:51 +0000542 r'(|.*[\\\/])\.git[\\\/].*',
543 r'(|.*[\\\/])\.svn[\\\/].*',
maruel@chromium.org7ccb4bb2011-11-07 20:26:20 +0000544 # There is no point in processing a patch file.
Edward Lemura5799e32020-01-17 19:26:51 +0000545 r'.+\.diff$',
546 r'.+\.patch$',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000547 )
548
local_bot30f774e2020-06-25 18:23:34 +0000549 # TODO(https://crbug.com/1098562): Remove once no longer used
550 @property
551 def DEFAULT_WHITE_LIST(self):
local_bot64021412020-07-08 21:05:39 +0000552 return self.DEFAULT_FILES_TO_CHECK
local_bot30f774e2020-06-25 18:23:34 +0000553
554 # TODO(https://crbug.com/1098562): Remove once no longer used
local_bot37ce2012020-06-26 17:39:24 +0000555 @DEFAULT_WHITE_LIST.setter
556 def DEFAULT_WHITE_LIST(self, value):
local_bot64021412020-07-08 21:05:39 +0000557 self.DEFAULT_FILES_TO_CHECK = value
558
559 # TODO(https://crbug.com/1098562): Remove once no longer used
560 @property
561 def DEFAULT_ALLOW_LIST(self):
562 return self.DEFAULT_FILES_TO_CHECK
563
564 # TODO(https://crbug.com/1098562): Remove once no longer used
565 @DEFAULT_ALLOW_LIST.setter
566 def DEFAULT_ALLOW_LIST(self, value):
567 self.DEFAULT_FILES_TO_CHECK = value
local_bot37ce2012020-06-26 17:39:24 +0000568
569 # TODO(https://crbug.com/1098562): Remove once no longer used
local_bot30f774e2020-06-25 18:23:34 +0000570 @property
571 def DEFAULT_BLACK_LIST(self):
local_bot64021412020-07-08 21:05:39 +0000572 return self.DEFAULT_FILES_TO_SKIP
local_bot30f774e2020-06-25 18:23:34 +0000573
local_bot37ce2012020-06-26 17:39:24 +0000574 # TODO(https://crbug.com/1098562): Remove once no longer used
575 @DEFAULT_BLACK_LIST.setter
576 def DEFAULT_BLACK_LIST(self, value):
local_bot64021412020-07-08 21:05:39 +0000577 self.DEFAULT_FILES_TO_SKIP = value
578
579 # TODO(https://crbug.com/1098562): Remove once no longer used
580 @property
581 def DEFAULT_BLOCK_LIST(self):
582 return self.DEFAULT_FILES_TO_SKIP
583
584 # TODO(https://crbug.com/1098562): Remove once no longer used
585 @DEFAULT_BLOCK_LIST.setter
586 def DEFAULT_BLOCK_LIST(self, value):
587 self.DEFAULT_FILES_TO_SKIP = value
local_bot37ce2012020-06-26 17:39:24 +0000588
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000589 def __init__(self, change, presubmit_path, is_committing,
Edward Lesmes8e282792018-04-03 18:50:29 -0400590 verbose, gerrit_obj, dry_run=None, thread_pool=None, parallel=False):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000591 """Builds an InputApi object.
592
593 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000594 change: A presubmit.Change object.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000595 presubmit_path: The path to the presubmit script being processed.
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000596 is_committing: True if the change is about to be committed.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000597 gerrit_obj: provides basic Gerrit codereview functionality.
598 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -0400599 parallel: if true, all tests reported via input_api.RunTests for all
600 PRESUBMIT files will be run in parallel.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000601 """
maruel@chromium.org9711bba2009-05-22 23:51:39 +0000602 # Version number of the presubmit_support script.
603 self.version = [int(x) for x in __version__.split('.')]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000604 self.change = change
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000605 self.is_committing = is_committing
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000606 self.gerrit = gerrit_obj
tandrii@chromium.org57bafac2016-04-28 05:09:03 +0000607 self.dry_run = dry_run
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000608
Edward Lesmes8e282792018-04-03 18:50:29 -0400609 self.parallel = parallel
610 self.thread_pool = thread_pool or ThreadPool()
611
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000612 # We expose various modules and functions as attributes of the input_api
613 # so that presubmit scripts don't have to import them.
Takeshi Yoshino07a6bea2017-08-02 02:44:06 +0900614 self.ast = ast
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000615 self.basename = os.path.basename
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000616 self.cpplint = cpplint
dcheng091b7db2016-06-16 01:27:51 -0700617 self.fnmatch = fnmatch
Yoshisato Yanagisawa04600b42019-03-15 03:03:41 +0000618 self.gclient_paths = gclient_paths
Yoshisato Yanagisawa57dd17b2019-03-22 09:10:29 +0000619 # TODO(yyanagisawa): stop exposing this when python3 become default.
620 # Since python3's tempfile has TemporaryDirectory, we do not need this.
621 self.temporary_directory = gclient_utils.temporary_directory
dpranke@chromium.org17cc2442012-10-17 21:12:09 +0000622 self.glob = glob.glob
maruel@chromium.orgfb11c7b2010-03-18 18:22:14 +0000623 self.json = json
maruel@chromium.org6fba34d2011-06-02 13:45:12 +0000624 self.logging = logging.getLogger('PRESUBMIT')
maruel@chromium.org2b5ce562011-03-31 16:15:44 +0000625 self.os_listdir = os.listdir
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000626 self.os_path = os.path
pgervais@chromium.orgbd0cace2014-10-02 23:23:46 +0000627 self.os_stat = os.stat
Yoshisato Yanagisawa406de132018-06-29 05:43:25 +0000628 self.os_walk = os.walk
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000629 self.re = re
630 self.subprocess = subprocess
Edward Lemurb9830242019-10-30 22:19:20 +0000631 self.sys = sys
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000632 self.tempfile = tempfile
dpranke@chromium.org0d1bdea2011-03-24 22:54:38 +0000633 self.time = time
maruel@chromium.org1487d532009-06-06 00:22:57 +0000634 self.unittest = unittest
Edward Lemurb9830242019-10-30 22:19:20 +0000635 if sys.version_info.major == 2:
636 self.urllib2 = urllib2
Edward Lemur16af3562019-10-17 22:11:33 +0000637 self.urllib_request = urllib_request
638 self.urllib_error = urllib_error
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000639
Robert Iannucci50258932018-03-19 10:30:59 -0700640 self.is_windows = sys.platform == 'win32'
641
Edward Lemurb9646622019-10-25 20:57:35 +0000642 # Set python_executable to 'vpython' in order to allow scripts in other
643 # repos (e.g. src.git) to automatically pick up that repo's .vpython file,
644 # instead of inheriting the one in depot_tools.
645 self.python_executable = 'vpython'
maruel@chromium.orgc0b22972009-06-25 16:19:14 +0000646 self.environ = os.environ
647
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000648 # InputApi.platform is the platform you're currently running on.
649 self.platform = sys.platform
650
iannucci@chromium.org0af3bb32015-06-12 20:44:35 +0000651 self.cpu_count = multiprocessing.cpu_count()
652
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000653 # The local path of the currently-being-processed presubmit script.
maruel@chromium.org3d235242009-05-15 12:40:48 +0000654 self._current_presubmit_path = os.path.dirname(presubmit_path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000655
656 # We carry the canned checks so presubmit scripts can easily use them.
657 self.canned_checks = presubmit_canned_checks
658
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +0100659 # Temporary files we must manually remove at the end of a run.
660 self._named_temporary_files = []
Jochen Eisinger72606f82017-04-04 10:44:18 +0200661
Edward Lesmesdc11c6b2021-03-19 19:22:05 +0000662 self.owners_client = None
663 if self.gerrit:
664 self.owners_client = owners_client.GetCodeOwnersClient(
665 root=change.RepositoryRoot(),
666 upstream=change.UpstreamBranch(),
667 host=self.gerrit.host,
668 project=self.gerrit.project,
669 branch=self.gerrit.branch)
Edward Lesmes9ce03f82021-01-12 20:13:31 +0000670 self.owners_db = owners_db.Database(
671 change.RepositoryRoot(), fopen=open, os_path=self.os_path)
Jochen Eisinger76f5fc62017-04-07 16:27:46 +0200672 self.owners_finder = owners_finder.OwnersFinder
maruel@chromium.org899e1c12011-04-07 17:03:18 +0000673 self.verbose = verbose
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000674 self.Command = CommandData
dpranke@chromium.org2a009622011-03-01 02:43:31 +0000675
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000676 # Replace <hash_map> and <hash_set> as headers that need to be included
Edward Lemura5799e32020-01-17 19:26:51 +0000677 # with 'base/containers/hash_tables.h' instead.
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000678 # Access to a protected member _XX of a client class
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800679 # pylint: disable=protected-access
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000680 self.cpplint._re_pattern_templates = [
danakj@chromium.org18278522013-06-11 22:42:32 +0000681 (a, b, 'base/containers/hash_tables.h')
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000682 if header in ('<hash_map>', '<hash_set>') else (a, b, header)
683 for (a, b, header) in cpplint._re_pattern_templates
684 ]
685
Edward Lemurecc27072020-01-06 16:42:34 +0000686 def SetTimeout(self, timeout):
687 self.thread_pool.timeout = timeout
688
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000689 def PresubmitLocalPath(self):
690 """Returns the local path of the presubmit script currently being run.
691
692 This is useful if you don't want to hard-code absolute paths in the
693 presubmit script. For example, It can be used to find another file
694 relative to the PRESUBMIT.py script, so the whole tree can be branched and
695 the presubmit script still works, without editing its content.
696 """
maruel@chromium.org3d235242009-05-15 12:40:48 +0000697 return self._current_presubmit_path
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000698
agable0b65e732016-11-22 09:25:46 -0800699 def AffectedFiles(self, include_deletes=True, file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000700 """Same as input_api.change.AffectedFiles() except only lists files
701 (and optionally directories) in the same directory as the current presubmit
Bruce Dawson7a0b07a2020-04-23 17:14:40 +0000702 script, or subdirectories thereof. Note that files are listed using the OS
703 path separator, so backslashes are used as separators on Windows.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000704 """
Edward Lemura5799e32020-01-17 19:26:51 +0000705 dir_with_slash = normpath('%s/' % self.PresubmitLocalPath())
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000706 if len(dir_with_slash) == 1:
707 dir_with_slash = ''
sail@chromium.org5538e022011-05-12 17:53:16 +0000708
Edward Lemurb9830242019-10-30 22:19:20 +0000709 return list(filter(
maruel@chromium.org4661e0c2009-06-04 00:45:26 +0000710 lambda x: normpath(x.AbsoluteLocalPath()).startswith(dir_with_slash),
Edward Lemurb9830242019-10-30 22:19:20 +0000711 self.change.AffectedFiles(include_deletes, file_filter)))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000712
agable0b65e732016-11-22 09:25:46 -0800713 def LocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000714 """Returns local paths of input_api.AffectedFiles()."""
agable0b65e732016-11-22 09:25:46 -0800715 paths = [af.LocalPath() for af in self.AffectedFiles()]
Edward Lemura5799e32020-01-17 19:26:51 +0000716 logging.debug('LocalPaths: %s', paths)
pgervais@chromium.org2f64f782014-04-25 00:12:33 +0000717 return paths
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000718
agable0b65e732016-11-22 09:25:46 -0800719 def AbsoluteLocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000720 """Returns absolute local paths of input_api.AffectedFiles()."""
agable0b65e732016-11-22 09:25:46 -0800721 return [af.AbsoluteLocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000722
John Budorick16162372018-04-18 10:39:53 -0700723 def AffectedTestableFiles(self, include_deletes=None, **kwargs):
agable0b65e732016-11-22 09:25:46 -0800724 """Same as input_api.change.AffectedTestableFiles() except only lists files
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000725 in the same directory as the current presubmit script, or subdirectories
726 thereof.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000727 """
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000728 if include_deletes is not None:
Edward Lemura5799e32020-01-17 19:26:51 +0000729 warn('AffectedTestableFiles(include_deletes=%s)'
730 ' is deprecated and ignored' % str(include_deletes),
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000731 category=DeprecationWarning,
732 stacklevel=2)
Edward Lemurb9830242019-10-30 22:19:20 +0000733 return list(filter(
734 lambda x: x.IsTestableFile(),
735 self.AffectedFiles(include_deletes=False, **kwargs)))
agable0b65e732016-11-22 09:25:46 -0800736
737 def AffectedTextFiles(self, include_deletes=None):
738 """An alias to AffectedTestableFiles for backwards compatibility."""
739 return self.AffectedTestableFiles(include_deletes=include_deletes)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000740
Josip Sokcevic8c955952021-02-01 21:32:57 +0000741 def FilterSourceFile(self,
742 affected_file,
743 files_to_check=None,
744 files_to_skip=None,
745 allow_list=None,
746 block_list=None):
Edward Lemura5799e32020-01-17 19:26:51 +0000747 """Filters out files that aren't considered 'source file'.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000748
local_bot64021412020-07-08 21:05:39 +0000749 If files_to_check or files_to_skip is None, InputApi.DEFAULT_FILES_TO_CHECK
750 and InputApi.DEFAULT_FILES_TO_SKIP is used respectively.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000751
752 The lists will be compiled as regular expression and
753 AffectedFile.LocalPath() needs to pass both list.
754
755 Note: Copy-paste this function to suit your needs or use a lambda function.
756 """
local_bot64021412020-07-08 21:05:39 +0000757 if files_to_check is None:
758 files_to_check = self.DEFAULT_FILES_TO_CHECK
759 if files_to_skip is None:
760 files_to_skip = self.DEFAULT_FILES_TO_SKIP
local_bot30f774e2020-06-25 18:23:34 +0000761
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000762 def Find(affected_file, items):
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000763 local_path = affected_file.LocalPath()
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000764 for item in items:
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +0000765 if self.re.match(item, local_path):
maruel@chromium.org3410d912009-06-09 20:56:16 +0000766 return True
767 return False
local_bot64021412020-07-08 21:05:39 +0000768 return (Find(affected_file, files_to_check) and
769 not Find(affected_file, files_to_skip))
maruel@chromium.org3410d912009-06-09 20:56:16 +0000770
771 def AffectedSourceFiles(self, source_file):
agable0b65e732016-11-22 09:25:46 -0800772 """Filter the list of AffectedTestableFiles by the function source_file.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000773
774 If source_file is None, InputApi.FilterSourceFile() is used.
775 """
776 if not source_file:
777 source_file = self.FilterSourceFile
Edward Lemurb9830242019-10-30 22:19:20 +0000778 return list(filter(source_file, self.AffectedTestableFiles()))
maruel@chromium.org3410d912009-06-09 20:56:16 +0000779
780 def RightHandSideLines(self, source_file_filter=None):
Edward Lemura5799e32020-01-17 19:26:51 +0000781 """An iterator over all text lines in 'new' version of changed files.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000782
783 Only lists lines from new or modified text files in the change that are
784 contained by the directory of the currently executing presubmit script.
785
786 This is useful for doing line-by-line regex checks, like checking for
787 trailing whitespace.
788
789 Yields:
790 a 3 tuple:
791 the AffectedFile instance of the current file;
792 integer line number (1-based); and
793 the contents of the line as a string.
maruel@chromium.org1487d532009-06-06 00:22:57 +0000794
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000795 Note: The carriage return (LF or CR) is stripped off.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000796 """
maruel@chromium.org3410d912009-06-09 20:56:16 +0000797 files = self.AffectedSourceFiles(source_file_filter)
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000798 return _RightHandSideLinesImpl(files)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000799
maruel@chromium.orge3608df2009-11-10 20:22:57 +0000800 def ReadFile(self, file_item, mode='r'):
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000801 """Reads an arbitrary file.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000802
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000803 Deny reading anything outside the repository.
804 """
maruel@chromium.orge3608df2009-11-10 20:22:57 +0000805 if isinstance(file_item, AffectedFile):
806 file_item = file_item.AbsoluteLocalPath()
807 if not file_item.startswith(self.change.RepositoryRoot()):
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000808 raise IOError('Access outside the repository root is denied.')
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +0000809 return gclient_utils.FileRead(file_item, mode)
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000810
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +0100811 def CreateTemporaryFile(self, **kwargs):
812 """Returns a named temporary file that must be removed with a call to
813 RemoveTemporaryFiles().
814
815 All keyword arguments are forwarded to tempfile.NamedTemporaryFile(),
816 except for |delete|, which is always set to False.
817
818 Presubmit checks that need to create a temporary file and pass it for
819 reading should use this function instead of NamedTemporaryFile(), as
820 Windows fails to open a file that is already open for writing.
821
822 with input_api.CreateTemporaryFile() as f:
823 f.write('xyz')
824 f.close()
825 input_api.subprocess.check_output(['script-that', '--reads-from',
826 f.name])
827
828
829 Note that callers of CreateTemporaryFile() should not worry about removing
830 any temporary file; this is done transparently by the presubmit handling
831 code.
832 """
833 if 'delete' in kwargs:
834 # Prevent users from passing |delete|; we take care of file deletion
835 # ourselves and this prevents unintuitive error messages when we pass
836 # delete=False and 'delete' is also in kwargs.
837 raise TypeError('CreateTemporaryFile() does not take a "delete" '
838 'argument, file deletion is handled automatically by '
839 'the same presubmit_support code that creates InputApi '
840 'objects.')
841 temp_file = self.tempfile.NamedTemporaryFile(delete=False, **kwargs)
842 self._named_temporary_files.append(temp_file.name)
843 return temp_file
844
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000845 @property
846 def tbr(self):
847 """Returns if a change is TBR'ed."""
Jeremy Romandce22502017-06-20 15:37:29 -0400848 return 'TBR' in self.change.tags or self.change.TBRsFromDescription()
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000849
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +0000850 def RunTests(self, tests_mix, parallel=True):
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000851 tests = []
852 msgs = []
853 for t in tests_mix:
Edward Lesmes8e282792018-04-03 18:50:29 -0400854 if isinstance(t, OutputApi.PresubmitResult) and t:
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000855 msgs.append(t)
856 else:
857 assert issubclass(t.message, _PresubmitResult)
858 tests.append(t)
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +0000859 if self.verbose:
860 t.info = _PresubmitNotifyResult
Edward Lemur1037c742018-05-01 18:56:04 -0400861 if not t.kwargs.get('cwd'):
862 t.kwargs['cwd'] = self.PresubmitLocalPath()
Edward Lesmes8e282792018-04-03 18:50:29 -0400863 self.thread_pool.AddTests(tests, parallel)
Edward Lemur21000eb2019-05-24 23:25:58 +0000864 # When self.parallel is True (i.e. --parallel is passed as an option)
865 # RunTests doesn't actually run tests. It adds them to a ThreadPool that
866 # will run all tests once all PRESUBMIT files are processed.
867 # Otherwise, it will run them and return the results.
868 if not self.parallel:
Edward Lesmes8e282792018-04-03 18:50:29 -0400869 msgs.extend(self.thread_pool.RunAsync())
870 return msgs
scottmg86099d72016-09-01 09:16:51 -0700871
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000872
nick@chromium.orgff526192013-06-10 19:30:26 +0000873class _DiffCache(object):
874 """Caches diffs retrieved from a particular SCM."""
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000875 def __init__(self, upstream=None):
876 """Stores the upstream revision against which all diffs will be computed."""
877 self._upstream = upstream
nick@chromium.orgff526192013-06-10 19:30:26 +0000878
879 def GetDiff(self, path, local_root):
880 """Get the diff for a particular path."""
881 raise NotImplementedError()
882
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700883 def GetOldContents(self, path, local_root):
884 """Get the old version for a particular path."""
885 raise NotImplementedError()
886
nick@chromium.orgff526192013-06-10 19:30:26 +0000887
nick@chromium.orgff526192013-06-10 19:30:26 +0000888class _GitDiffCache(_DiffCache):
889 """DiffCache implementation for git; gets all file diffs at once."""
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000890 def __init__(self, upstream):
891 super(_GitDiffCache, self).__init__(upstream=upstream)
nick@chromium.orgff526192013-06-10 19:30:26 +0000892 self._diffs_by_file = None
893
894 def GetDiff(self, path, local_root):
895 if not self._diffs_by_file:
896 # Compute a single diff for all files and parse the output; should
897 # with git this is much faster than computing one diff for each file.
898 diffs = {}
899
900 # Don't specify any filenames below, because there are command line length
901 # limits on some platforms and GenerateDiff would fail.
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000902 unified_diff = scm.GIT.GenerateDiff(local_root, files=[], full_move=True,
903 branch=self._upstream)
nick@chromium.orgff526192013-06-10 19:30:26 +0000904
905 # This regex matches the path twice, separated by a space. Note that
906 # filename itself may contain spaces.
907 file_marker = re.compile('^diff --git (?P<filename>.*) (?P=filename)$')
908 current_diff = []
909 keep_line_endings = True
910 for x in unified_diff.splitlines(keep_line_endings):
911 match = file_marker.match(x)
912 if match:
913 # Marks the start of a new per-file section.
914 diffs[match.group('filename')] = current_diff = [x]
915 elif x.startswith('diff --git'):
916 raise PresubmitFailure('Unexpected diff line: %s' % x)
917 else:
918 current_diff.append(x)
919
920 self._diffs_by_file = dict(
921 (normpath(path), ''.join(diff)) for path, diff in diffs.items())
922
923 if path not in self._diffs_by_file:
924 raise PresubmitFailure(
925 'Unified diff did not contain entry for file %s' % path)
926
927 return self._diffs_by_file[path]
928
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700929 def GetOldContents(self, path, local_root):
930 return scm.GIT.GetOldContents(local_root, path, branch=self._upstream)
931
nick@chromium.orgff526192013-06-10 19:30:26 +0000932
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000933class AffectedFile(object):
934 """Representation of a file in a change."""
nick@chromium.orgff526192013-06-10 19:30:26 +0000935
936 DIFF_CACHE = _DiffCache
937
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000938 # Method could be a function
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800939 # pylint: disable=no-self-use
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000940 def __init__(self, path, action, repository_root, diff_cache):
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000941 self._path = path
942 self._action = action
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000943 self._local_root = repository_root
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000944 self._is_directory = None
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000945 self._cached_changed_contents = None
946 self._cached_new_contents = None
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000947 self._diff_cache = diff_cache
tobiasjs2836bcf2016-08-16 04:08:16 -0700948 logging.debug('%s(%s)', self.__class__.__name__, self._path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000949
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000950 def LocalPath(self):
951 """Returns the path of this file on the local disk relative to client root.
Andrew Grieve92b8b992017-11-02 09:42:24 -0400952
953 This should be used for error messages but not for accessing files,
954 because presubmit checks are run with CWD=PresubmitLocalPath() (which is
955 often != client root).
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000956 """
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000957 return normpath(self._path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000958
959 def AbsoluteLocalPath(self):
960 """Returns the absolute path of this file on the local disk.
961 """
chase@chromium.org8e416c82009-10-06 04:30:44 +0000962 return os.path.abspath(os.path.join(self._local_root, self.LocalPath()))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000963
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000964 def Action(self):
965 """Returns the action on this opened file, e.g. A, M, D, etc."""
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000966 return self._action
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000967
agable0b65e732016-11-22 09:25:46 -0800968 def IsTestableFile(self):
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000969 """Returns True if the file is a text file and not a binary file.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000970
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000971 Deleted files are not text file."""
maruel@chromium.org1e08c002009-05-28 19:09:33 +0000972 raise NotImplementedError() # Implement when needed
973
agable0b65e732016-11-22 09:25:46 -0800974 def IsTextFile(self):
975 """An alias to IsTestableFile for backwards compatibility."""
976 return self.IsTestableFile()
977
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700978 def OldContents(self):
979 """Returns an iterator over the lines in the old version of file.
980
Daniel Cheng2da34fe2017-03-21 20:42:12 -0700981 The old version is the file before any modifications in the user's
Edward Lemura5799e32020-01-17 19:26:51 +0000982 workspace, i.e. the 'left hand side'.
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700983
984 Contents will be empty if the file is a directory or does not exist.
985 Note: The carriage returns (LF or CR) are stripped off.
986 """
987 return self._diff_cache.GetOldContents(self.LocalPath(),
988 self._local_root).splitlines()
989
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000990 def NewContents(self):
991 """Returns an iterator over the lines in the new version of file.
992
Edward Lemura5799e32020-01-17 19:26:51 +0000993 The new version is the file in the user's workspace, i.e. the 'right hand
994 side'.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000995
996 Contents will be empty if the file is a directory or does not exist.
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000997 Note: The carriage returns (LF or CR) are stripped off.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000998 """
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000999 if self._cached_new_contents is None:
1000 self._cached_new_contents = []
agable0b65e732016-11-22 09:25:46 -08001001 try:
1002 self._cached_new_contents = gclient_utils.FileRead(
1003 self.AbsoluteLocalPath(), 'rU').splitlines()
1004 except IOError:
1005 pass # File not found? That's fine; maybe it was deleted.
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +00001006 return self._cached_new_contents[:]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001007
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001008 def ChangedContents(self):
1009 """Returns a list of tuples (line number, line text) of all new lines.
1010
1011 This relies on the scm diff output describing each changed code section
1012 with a line of the form
1013
1014 ^@@ <old line num>,<old size> <new line num>,<new size> @@$
1015 """
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +00001016 if self._cached_changed_contents is not None:
1017 return self._cached_changed_contents[:]
1018 self._cached_changed_contents = []
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001019 line_num = 0
1020
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001021 for line in self.GenerateScmDiff().splitlines():
Edward Lemurac5c55f2020-02-29 00:17:16 +00001022 m = re.match(r'^@@ [0-9\,\+\-]+ \+([0-9]+)\,[0-9]+ @@', line)
1023 if m:
1024 line_num = int(m.groups(1)[0])
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001025 continue
1026 if line.startswith('+') and not line.startswith('++'):
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +00001027 self._cached_changed_contents.append((line_num, line[1:]))
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001028 if not line.startswith('-'):
1029 line_num += 1
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +00001030 return self._cached_changed_contents[:]
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001031
maruel@chromium.org5de13972009-06-10 18:16:06 +00001032 def __str__(self):
1033 return self.LocalPath()
1034
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001035 def GenerateScmDiff(self):
nick@chromium.orgff526192013-06-10 19:30:26 +00001036 return self._diff_cache.GetDiff(self.LocalPath(), self._local_root)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001037
maruel@chromium.org58407af2011-04-12 23:15:57 +00001038
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001039class GitAffectedFile(AffectedFile):
1040 """Representation of a file in a change out of a git checkout."""
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +00001041 # Method 'NNN' is abstract in class 'NNN' but is not overridden
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -08001042 # pylint: disable=abstract-method
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001043
nick@chromium.orgff526192013-06-10 19:30:26 +00001044 DIFF_CACHE = _GitDiffCache
1045
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001046 def __init__(self, *args, **kwargs):
1047 AffectedFile.__init__(self, *args, **kwargs)
1048 self._server_path = None
agable0b65e732016-11-22 09:25:46 -08001049 self._is_testable_file = None
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001050
agable0b65e732016-11-22 09:25:46 -08001051 def IsTestableFile(self):
1052 if self._is_testable_file is None:
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001053 if self.Action() == 'D':
agable0b65e732016-11-22 09:25:46 -08001054 # A deleted file is not testable.
1055 self._is_testable_file = False
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001056 else:
agable0b65e732016-11-22 09:25:46 -08001057 self._is_testable_file = os.path.isfile(self.AbsoluteLocalPath())
1058 return self._is_testable_file
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001059
maruel@chromium.orgc1938752011-04-12 23:11:13 +00001060
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001061class Change(object):
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001062 """Describe a change.
1063
1064 Used directly by the presubmit scripts to query the current change being
1065 tested.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +00001066
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001067 Instance members:
nick@chromium.orgff526192013-06-10 19:30:26 +00001068 tags: Dictionary of KEY=VALUE pairs found in the change description.
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001069 self.KEY: equivalent to tags['KEY']
1070 """
1071
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001072 _AFFECTED_FILES = AffectedFile
1073
Edward Lemura5799e32020-01-17 19:26:51 +00001074 # Matches key/value (or 'tag') lines in changelist descriptions.
maruel@chromium.org428342a2011-11-10 15:46:33 +00001075 TAG_LINE_RE = re.compile(
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001076 '^[ \t]*(?P<key>[A-Z][A-Z_0-9]*)[ \t]*=[ \t]*(?P<value>.*?)[ \t]*$')
maruel@chromium.orgc1938752011-04-12 23:11:13 +00001077 scm = ''
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001078
maruel@chromium.org58407af2011-04-12 23:15:57 +00001079 def __init__(
agable@chromium.orgea84ef12014-04-30 19:55:12 +00001080 self, name, description, local_root, files, issue, patchset, author,
1081 upstream=None):
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001082 if files is None:
1083 files = []
1084 self._name = name
chase@chromium.org8e416c82009-10-06 04:30:44 +00001085 # Convert root into an absolute path.
1086 self._local_root = os.path.abspath(local_root)
agable@chromium.orgea84ef12014-04-30 19:55:12 +00001087 self._upstream = upstream
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001088 self.issue = issue
1089 self.patchset = patchset
maruel@chromium.org58407af2011-04-12 23:15:57 +00001090 self.author_email = author
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001091
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001092 self._full_description = ''
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001093 self.tags = {}
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001094 self._description_without_tags = ''
1095 self.SetDescriptionText(description)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001096
maruel@chromium.orge085d812011-10-10 19:49:15 +00001097 assert all(
1098 (isinstance(f, (list, tuple)) and len(f) == 2) for f in files), files
1099
agable@chromium.orgea84ef12014-04-30 19:55:12 +00001100 diff_cache = self._AFFECTED_FILES.DIFF_CACHE(self._upstream)
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001101 self._affected_files = [
nick@chromium.orgff526192013-06-10 19:30:26 +00001102 self._AFFECTED_FILES(path, action.strip(), self._local_root, diff_cache)
1103 for action, path in files
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +00001104 ]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001105
Edward Lesmes9ce03f82021-01-12 20:13:31 +00001106 def UpstreamBranch(self):
1107 """Returns the upstream branch for the change."""
1108 return self._upstream
1109
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001110 def Name(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001111 """Returns the change name."""
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001112 return self._name
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001113
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001114 def DescriptionText(self):
1115 """Returns the user-entered changelist description, minus tags.
1116
Edward Lemura5799e32020-01-17 19:26:51 +00001117 Any line in the user-provided description starting with e.g. 'FOO='
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001118 (whitespace permitted before and around) is considered a tag line. Such
1119 lines are stripped out of the description this function returns.
1120 """
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001121 return self._description_without_tags
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001122
1123 def FullDescriptionText(self):
1124 """Returns the complete changelist description including tags."""
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001125 return self._full_description
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001126
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001127 def SetDescriptionText(self, description):
1128 """Sets the full description text (including tags) to |description|.
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001129
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001130 Also updates the list of tags."""
1131 self._full_description = description
1132
1133 # From the description text, build up a dictionary of key/value pairs
Edward Lemura5799e32020-01-17 19:26:51 +00001134 # plus the description minus all key/value or 'tag' lines.
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001135 description_without_tags = []
1136 self.tags = {}
1137 for line in self._full_description.splitlines():
1138 m = self.TAG_LINE_RE.match(line)
1139 if m:
1140 self.tags[m.group('key')] = m.group('value')
1141 else:
1142 description_without_tags.append(line)
1143
1144 # Change back to text and remove whitespace at end.
1145 self._description_without_tags = (
1146 '\n'.join(description_without_tags).rstrip())
1147
Edward Lemur69bb8be2020-02-03 20:37:38 +00001148 def AddDescriptionFooter(self, key, value):
1149 """Adds the given footer to the change description.
1150
1151 Args:
1152 key: A string with the key for the git footer. It must conform to
1153 the git footers format (i.e. 'List-Of-Tokens') and will be case
1154 normalized so that each token is title-cased.
1155 value: A string with the value for the git footer.
1156 """
1157 description = git_footers.add_footer(
1158 self.FullDescriptionText(), git_footers.normalize_name(key), value)
1159 self.SetDescriptionText(description)
1160
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001161 def RepositoryRoot(self):
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001162 """Returns the repository (checkout) root directory for this change,
1163 as an absolute path.
1164 """
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001165 return self._local_root
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001166
1167 def __getattr__(self, attr):
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001168 """Return tags directly as attributes on the object."""
Edward Lemura5799e32020-01-17 19:26:51 +00001169 if not re.match(r'^[A-Z_]*$', attr):
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001170 raise AttributeError(self, attr)
maruel@chromium.orge1a524f2009-05-27 14:43:46 +00001171 return self.tags.get(attr)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001172
Edward Lemur69bb8be2020-02-03 20:37:38 +00001173 def GitFootersFromDescription(self):
1174 """Return the git footers present in the description.
1175
1176 Returns:
1177 footers: A dict of {footer: [values]} containing a multimap of the footers
1178 in the change description.
1179 """
1180 return git_footers.parse_footers(self.FullDescriptionText())
1181
Aaron Gablefc03e672017-05-15 14:09:42 -07001182 def BugsFromDescription(self):
1183 """Returns all bugs referenced in the commit description."""
Aaron Gable12ef5012017-05-15 14:29:00 -07001184 tags = [b.strip() for b in self.tags.get('BUG', '').split(',') if b.strip()]
Caleb Rouleauc0546b92019-02-22 06:12:57 +00001185 footers = []
Edward Lemur69bb8be2020-02-03 20:37:38 +00001186 parsed = self.GitFootersFromDescription()
Dan Beam62954042019-10-03 21:20:33 +00001187 unsplit_footers = parsed.get('Bug', []) + parsed.get('Fixed', [])
Caleb Rouleauc0546b92019-02-22 06:12:57 +00001188 for unsplit_footer in unsplit_footers:
1189 footers += [b.strip() for b in unsplit_footer.split(',')]
Aaron Gable12ef5012017-05-15 14:29:00 -07001190 return sorted(set(tags + footers))
Aaron Gablefc03e672017-05-15 14:09:42 -07001191
1192 def ReviewersFromDescription(self):
1193 """Returns all reviewers listed in the commit description."""
Edward Lemura5799e32020-01-17 19:26:51 +00001194 # We don't support a 'R:' git-footer for reviewers; that is in metadata.
Aaron Gable12ef5012017-05-15 14:29:00 -07001195 tags = [r.strip() for r in self.tags.get('R', '').split(',') if r.strip()]
1196 return sorted(set(tags))
Aaron Gablefc03e672017-05-15 14:09:42 -07001197
1198 def TBRsFromDescription(self):
1199 """Returns all TBR reviewers listed in the commit description."""
Aaron Gable12ef5012017-05-15 14:29:00 -07001200 tags = [r.strip() for r in self.tags.get('TBR', '').split(',') if r.strip()]
Aaron Gable6e7ddb62020-05-27 22:23:29 +00001201 # TODO(crbug.com/839208): Remove support for 'Tbr:' when TBRs are
1202 # programmatically determined by self-CR+1s.
Edward Lemur69bb8be2020-02-03 20:37:38 +00001203 footers = self.GitFootersFromDescription().get('Tbr', [])
Aaron Gable12ef5012017-05-15 14:29:00 -07001204 return sorted(set(tags + footers))
Aaron Gablefc03e672017-05-15 14:09:42 -07001205
Aaron Gable6e7ddb62020-05-27 22:23:29 +00001206 # TODO(crbug.com/753425): Delete these once we're sure they're unused.
Aaron Gablefc03e672017-05-15 14:09:42 -07001207 @property
1208 def BUG(self):
1209 return ','.join(self.BugsFromDescription())
1210 @property
1211 def R(self):
1212 return ','.join(self.ReviewersFromDescription())
1213 @property
1214 def TBR(self):
1215 return ','.join(self.TBRsFromDescription())
1216
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001217 def AllFiles(self, root=None):
1218 """List all files under source control in the repo."""
1219 raise NotImplementedError()
1220
agable0b65e732016-11-22 09:25:46 -08001221 def AffectedFiles(self, include_deletes=True, file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001222 """Returns a list of AffectedFile instances for all files in the change.
1223
1224 Args:
1225 include_deletes: If false, deleted files will be filtered out.
sail@chromium.org5538e022011-05-12 17:53:16 +00001226 file_filter: An additional filter to apply.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001227
1228 Returns:
1229 [AffectedFile(path, action), AffectedFile(path, action)]
1230 """
Edward Lemurb9830242019-10-30 22:19:20 +00001231 affected = list(filter(file_filter, self._affected_files))
sail@chromium.org5538e022011-05-12 17:53:16 +00001232
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001233 if include_deletes:
1234 return affected
Edward Lemurb9830242019-10-30 22:19:20 +00001235 return list(filter(lambda x: x.Action() != 'D', affected))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001236
John Budorick16162372018-04-18 10:39:53 -07001237 def AffectedTestableFiles(self, include_deletes=None, **kwargs):
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +00001238 """Return a list of the existing text files in a change."""
1239 if include_deletes is not None:
Edward Lemura5799e32020-01-17 19:26:51 +00001240 warn('AffectedTeestableFiles(include_deletes=%s)'
1241 ' is deprecated and ignored' % str(include_deletes),
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +00001242 category=DeprecationWarning,
1243 stacklevel=2)
Edward Lemurb9830242019-10-30 22:19:20 +00001244 return list(filter(
1245 lambda x: x.IsTestableFile(),
1246 self.AffectedFiles(include_deletes=False, **kwargs)))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001247
agable0b65e732016-11-22 09:25:46 -08001248 def AffectedTextFiles(self, include_deletes=None):
1249 """An alias to AffectedTestableFiles for backwards compatibility."""
1250 return self.AffectedTestableFiles(include_deletes=include_deletes)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001251
agable0b65e732016-11-22 09:25:46 -08001252 def LocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001253 """Convenience function."""
agable0b65e732016-11-22 09:25:46 -08001254 return [af.LocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001255
agable0b65e732016-11-22 09:25:46 -08001256 def AbsoluteLocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001257 """Convenience function."""
agable0b65e732016-11-22 09:25:46 -08001258 return [af.AbsoluteLocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001259
1260 def RightHandSideLines(self):
Edward Lemura5799e32020-01-17 19:26:51 +00001261 """An iterator over all text lines in 'new' version of changed files.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001262
1263 Lists lines from new or modified text files in the change.
1264
1265 This is useful for doing line-by-line regex checks, like checking for
1266 trailing whitespace.
1267
1268 Yields:
1269 a 3 tuple:
1270 the AffectedFile instance of the current file;
1271 integer line number (1-based); and
1272 the contents of the line as a string.
1273 """
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +00001274 return _RightHandSideLinesImpl(
1275 x for x in self.AffectedFiles(include_deletes=False)
agable0b65e732016-11-22 09:25:46 -08001276 if x.IsTestableFile())
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001277
Jochen Eisingerd0573ec2017-04-13 10:55:06 +02001278 def OriginalOwnersFiles(self):
1279 """A map from path names of affected OWNERS files to their old content."""
1280 def owners_file_filter(f):
1281 return 'OWNERS' in os.path.split(f.LocalPath())[1]
1282 files = self.AffectedFiles(file_filter=owners_file_filter)
1283 return dict([(f.LocalPath(), f.OldContents()) for f in files])
1284
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001285
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001286class GitChange(Change):
1287 _AFFECTED_FILES = GitAffectedFile
maruel@chromium.orgc1938752011-04-12 23:11:13 +00001288 scm = 'git'
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +00001289
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001290 def AllFiles(self, root=None):
1291 """List all files under source control in the repo."""
1292 root = root or self.RepositoryRoot()
1293 return subprocess.check_output(
Aaron Gable7817f022017-12-12 09:43:17 -08001294 ['git', '-c', 'core.quotePath=false', 'ls-files', '--', '.'],
1295 cwd=root).splitlines()
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001296
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001297
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001298def ListRelevantPresubmitFiles(files, root):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001299 """Finds all presubmit files that apply to a given set of source files.
1300
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001301 If inherit-review-settings-ok is present right under root, looks for
1302 PRESUBMIT.py in directories enclosing root.
1303
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001304 Args:
1305 files: An iterable container containing file paths.
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001306 root: Path where to stop searching.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001307
1308 Return:
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001309 List of absolute paths of the existing PRESUBMIT.py scripts.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001310 """
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001311 files = [normpath(os.path.join(root, f)) for f in files]
1312
1313 # List all the individual directories containing files.
1314 directories = set([os.path.dirname(f) for f in files])
1315
1316 # Ignore root if inherit-review-settings-ok is present.
1317 if os.path.isfile(os.path.join(root, 'inherit-review-settings-ok')):
1318 root = None
1319
1320 # Collect all unique directories that may contain PRESUBMIT.py.
1321 candidates = set()
1322 for directory in directories:
1323 while True:
1324 if directory in candidates:
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001325 break
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001326 candidates.add(directory)
1327 if directory == root:
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001328 break
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001329 parent_dir = os.path.dirname(directory)
1330 if parent_dir == directory:
1331 # We hit the system root directory.
1332 break
1333 directory = parent_dir
1334
1335 # Look for PRESUBMIT.py in all candidate directories.
1336 results = []
1337 for directory in sorted(list(candidates)):
tobiasjsff061c02016-08-17 03:23:57 -07001338 try:
1339 for f in os.listdir(directory):
1340 p = os.path.join(directory, f)
1341 if os.path.isfile(p) and re.match(
1342 r'PRESUBMIT.*\.py$', f) and not f.startswith('PRESUBMIT_test'):
1343 results.append(p)
1344 except OSError:
1345 pass
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001346
tobiasjs2836bcf2016-08-16 04:08:16 -07001347 logging.debug('Presubmit files: %s', ','.join(results))
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001348 return results
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001349
1350
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001351class GetTryMastersExecuter(object):
1352 @staticmethod
1353 def ExecPresubmitScript(script_text, presubmit_path, project, change):
1354 """Executes GetPreferredTryMasters() from a single presubmit script.
1355
1356 Args:
1357 script_text: The text of the presubmit script.
1358 presubmit_path: Project script to run.
1359 project: Project name to pass to presubmit script for bot selection.
1360
1361 Return:
1362 A map of try masters to map of builders to set of tests.
1363 """
1364 context = {}
1365 try:
Raul Tambre09e64b42019-05-14 01:57:22 +00001366 exec(compile(script_text, 'PRESUBMIT.py', 'exec', dont_inherit=True),
1367 context)
Raul Tambre7c938462019-05-24 16:35:35 +00001368 except Exception as e:
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001369 raise PresubmitFailure('"%s" had an exception.\n%s'
1370 % (presubmit_path, e))
1371
1372 function_name = 'GetPreferredTryMasters'
1373 if function_name not in context:
1374 return {}
1375 get_preferred_try_masters = context[function_name]
1376 if not len(inspect.getargspec(get_preferred_try_masters)[0]) == 2:
1377 raise PresubmitFailure(
1378 'Expected function "GetPreferredTryMasters" to take two arguments.')
1379 return get_preferred_try_masters(project, change)
1380
1381
rmistry@google.com5626a922015-02-26 14:03:30 +00001382class GetPostUploadExecuter(object):
1383 @staticmethod
Edward Lemur016a0872020-02-04 22:13:28 +00001384 def ExecPresubmitScript(script_text, presubmit_path, gerrit_obj, change):
rmistry@google.com5626a922015-02-26 14:03:30 +00001385 """Executes PostUploadHook() from a single presubmit script.
1386
1387 Args:
1388 script_text: The text of the presubmit script.
1389 presubmit_path: Project script to run.
Edward Lemur016a0872020-02-04 22:13:28 +00001390 gerrit_obj: The GerritAccessor object.
rmistry@google.com5626a922015-02-26 14:03:30 +00001391 change: The Change object.
1392
1393 Return:
1394 A list of results objects.
1395 """
1396 context = {}
1397 try:
Raul Tambre09e64b42019-05-14 01:57:22 +00001398 exec(compile(script_text, 'PRESUBMIT.py', 'exec', dont_inherit=True),
1399 context)
Raul Tambre7c938462019-05-24 16:35:35 +00001400 except Exception as e:
rmistry@google.com5626a922015-02-26 14:03:30 +00001401 raise PresubmitFailure('"%s" had an exception.\n%s'
1402 % (presubmit_path, e))
1403
1404 function_name = 'PostUploadHook'
1405 if function_name not in context:
1406 return {}
1407 post_upload_hook = context[function_name]
1408 if not len(inspect.getargspec(post_upload_hook)[0]) == 3:
1409 raise PresubmitFailure(
1410 'Expected function "PostUploadHook" to take three arguments.')
Edward Lemur016a0872020-02-04 22:13:28 +00001411 return post_upload_hook(gerrit_obj, change, OutputApi(False))
rmistry@google.com5626a922015-02-26 14:03:30 +00001412
1413
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001414def _MergeMasters(masters1, masters2):
1415 """Merges two master maps. Merges also the tests of each builder."""
1416 result = {}
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001417 for (master, builders) in itertools.chain(masters1.items(),
1418 masters2.items()):
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001419 new_builders = result.setdefault(master, {})
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001420 for (builder, tests) in builders.items():
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001421 new_builders.setdefault(builder, set([])).update(tests)
1422 return result
1423
1424
1425def DoGetTryMasters(change,
1426 changed_files,
1427 repository_root,
1428 default_presubmit,
1429 project,
1430 verbose,
1431 output_stream):
1432 """Get the list of try masters from the presubmit scripts.
1433
1434 Args:
1435 changed_files: List of modified files.
1436 repository_root: The repository root.
1437 default_presubmit: A default presubmit script to execute in any case.
1438 project: Optional name of a project used in selecting trybots.
1439 verbose: Prints debug info.
1440 output_stream: A stream to write debug output to.
1441
1442 Return:
1443 Map of try masters to map of builders to set of tests.
1444 """
1445 presubmit_files = ListRelevantPresubmitFiles(changed_files, repository_root)
1446 if not presubmit_files and verbose:
Edward Lemura5799e32020-01-17 19:26:51 +00001447 output_stream.write('Warning, no PRESUBMIT.py found.\n')
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001448 results = {}
1449 executer = GetTryMastersExecuter()
1450
1451 if default_presubmit:
1452 if verbose:
Edward Lemura5799e32020-01-17 19:26:51 +00001453 output_stream.write('Running default presubmit script.\n')
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001454 fake_path = os.path.join(repository_root, 'PRESUBMIT.py')
1455 results = _MergeMasters(results, executer.ExecPresubmitScript(
1456 default_presubmit, fake_path, project, change))
1457 for filename in presubmit_files:
1458 filename = os.path.abspath(filename)
1459 if verbose:
Edward Lemura5799e32020-01-17 19:26:51 +00001460 output_stream.write('Running %s\n' % filename)
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001461 # Accept CRLF presubmit script.
1462 presubmit_script = gclient_utils.FileRead(filename, 'rU')
1463 results = _MergeMasters(results, executer.ExecPresubmitScript(
1464 presubmit_script, filename, project, change))
1465
1466 # Make sets to lists again for later JSON serialization.
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001467 for builders in results.values():
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001468 for builder in builders:
1469 builders[builder] = list(builders[builder])
1470
1471 if results and verbose:
1472 output_stream.write('%s\n' % str(results))
1473 return results
1474
1475
rmistry@google.com5626a922015-02-26 14:03:30 +00001476def DoPostUploadExecuter(change,
Edward Lemur016a0872020-02-04 22:13:28 +00001477 gerrit_obj,
Edward Lemur6eb1d322020-02-27 22:20:15 +00001478 verbose):
rmistry@google.com5626a922015-02-26 14:03:30 +00001479 """Execute the post upload hook.
1480
1481 Args:
1482 change: The Change object.
Edward Lemur016a0872020-02-04 22:13:28 +00001483 gerrit_obj: The GerritAccessor object.
rmistry@google.com5626a922015-02-26 14:03:30 +00001484 verbose: Prints debug info.
rmistry@google.com5626a922015-02-26 14:03:30 +00001485 """
1486 presubmit_files = ListRelevantPresubmitFiles(
Edward Lemur6eb1d322020-02-27 22:20:15 +00001487 change.LocalPaths(), change.RepositoryRoot())
rmistry@google.com5626a922015-02-26 14:03:30 +00001488 if not presubmit_files and verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001489 sys.stdout.write('Warning, no PRESUBMIT.py found.\n')
rmistry@google.com5626a922015-02-26 14:03:30 +00001490 results = []
1491 executer = GetPostUploadExecuter()
1492 # The root presubmit file should be executed after the ones in subdirectories.
1493 # i.e. the specific post upload hooks should run before the general ones.
1494 # Thus, reverse the order provided by ListRelevantPresubmitFiles.
1495 presubmit_files.reverse()
1496
1497 for filename in presubmit_files:
1498 filename = os.path.abspath(filename)
1499 if verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001500 sys.stdout.write('Running %s\n' % filename)
rmistry@google.com5626a922015-02-26 14:03:30 +00001501 # Accept CRLF presubmit script.
1502 presubmit_script = gclient_utils.FileRead(filename, 'rU')
1503 results.extend(executer.ExecPresubmitScript(
Edward Lemur016a0872020-02-04 22:13:28 +00001504 presubmit_script, filename, gerrit_obj, change))
rmistry@google.com5626a922015-02-26 14:03:30 +00001505
Edward Lemur6eb1d322020-02-27 22:20:15 +00001506 if not results:
1507 return 0
1508
1509 sys.stdout.write('\n')
1510 sys.stdout.write('** Post Upload Hook Messages **\n')
1511
1512 exit_code = 0
1513 for result in results:
1514 if result.fatal:
1515 exit_code = 1
1516 result.handle()
1517 sys.stdout.write('\n')
1518
1519 return exit_code
rmistry@google.com5626a922015-02-26 14:03:30 +00001520
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001521class PresubmitExecuter(object):
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001522 def __init__(self, change, committing, verbose, gerrit_obj, dry_run=None,
Edward Lesmeseb1bd622021-03-01 19:54:07 +00001523 thread_pool=None, parallel=False):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001524 """
1525 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001526 change: The Change object.
agable92bec4f2016-08-24 09:27:27 -07001527 committing: True if 'git cl land' is running, False if 'git cl upload' is.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001528 gerrit_obj: provides basic Gerrit codereview functionality.
1529 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -04001530 parallel: if true, all tests reported via input_api.RunTests for all
1531 PRESUBMIT files will be run in parallel.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001532 """
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001533 self.change = change
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001534 self.committing = committing
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001535 self.gerrit = gerrit_obj
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001536 self.verbose = verbose
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001537 self.dry_run = dry_run
Daniel Cheng7227d212017-11-17 08:12:37 -08001538 self.more_cc = []
Edward Lesmes8e282792018-04-03 18:50:29 -04001539 self.thread_pool = thread_pool
1540 self.parallel = parallel
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001541
1542 def ExecPresubmitScript(self, script_text, presubmit_path):
1543 """Executes a single presubmit script.
1544
1545 Args:
1546 script_text: The text of the presubmit script.
1547 presubmit_path: The path to the presubmit file (this will be reported via
1548 input_api.PresubmitLocalPath()).
1549
1550 Return:
1551 A list of result objects, empty if no problems.
1552 """
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001553
chase@chromium.org8e416c82009-10-06 04:30:44 +00001554 # Change to the presubmit file's directory to support local imports.
1555 main_path = os.getcwd()
Saagar Sanghavi98b332f2020-07-31 17:19:15 +00001556 presubmit_dir = os.path.dirname(presubmit_path)
1557 os.chdir(presubmit_dir)
chase@chromium.org8e416c82009-10-06 04:30:44 +00001558
1559 # Load the presubmit script into context.
dpranke@chromium.org970c5222011-03-12 00:32:24 +00001560 input_api = InputApi(self.change, presubmit_path, self.committing,
Aaron Gable668c1d82018-04-03 10:19:16 -07001561 self.verbose, gerrit_obj=self.gerrit,
Edward Lesmes8e282792018-04-03 18:50:29 -04001562 dry_run=self.dry_run, thread_pool=self.thread_pool,
1563 parallel=self.parallel)
Daniel Cheng7227d212017-11-17 08:12:37 -08001564 output_api = OutputApi(self.committing)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001565 context = {}
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001566
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001567 # Try to figure out whether these presubmit checks should be run under
1568 # python2 or python3. We need to do this without actually trying to
1569 # compile the text, since the text might compile in one but not the
1570 # other.
1571 m = re.search('^USE_PYTHON3 = True$', script_text, flags=re.MULTILINE)
1572 use_python3 = m is not None
1573 if (((sys.version_info.major == 2) and use_python3) or
1574 ((sys.version_info.major == 3) and not use_python3)):
1575 return []
1576
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001577 try:
Raul Tambre09e64b42019-05-14 01:57:22 +00001578 exec(compile(script_text, 'PRESUBMIT.py', 'exec', dont_inherit=True),
1579 context)
Raul Tambre7c938462019-05-24 16:35:35 +00001580 except Exception as e:
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001581 raise PresubmitFailure('"%s" had an exception.\n%s' % (presubmit_path, e))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001582
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001583 context['__args'] = (input_api, output_api)
Ben Pastene8351dc12020-08-06 05:01:35 +00001584
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001585 # Get path of presubmit directory relative to repository root.
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001586 # Always use forward slashes, so that path is same in *nix and Windows
1587 root = input_api.change.RepositoryRoot()
1588 rel_path = os.path.relpath(presubmit_dir, root)
1589 rel_path = rel_path.replace(os.path.sep, '/')
Ben Pastene8351dc12020-08-06 05:01:35 +00001590
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001591 # Get the URL of git remote origin and use it to identify host and project
Edward Lesmeseb1bd622021-03-01 19:54:07 +00001592 host = project = ''
1593 if self.gerrit:
1594 host = self.gerrit.host or ''
1595 project = self.gerrit.project or ''
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001596
1597 # Prefix for test names
1598 prefix = 'presubmit:%s/%s:%s/' % (host, project, rel_path)
1599
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001600 # Perform all the desired presubmit checks.
1601 results = []
Ben Pastene8351dc12020-08-06 05:01:35 +00001602
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001603 try:
Scott Leecc2fe9b2020-11-19 19:38:06 +00001604 version = [
1605 int(x) for x in context.get('PRESUBMIT_VERSION', '0.0.0').split('.')
1606 ]
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001607
Scott Leecc2fe9b2020-11-19 19:38:06 +00001608 with rdb_wrapper.client(prefix) as sink:
1609 if version >= [2, 0, 0]:
1610 for function_name in context:
1611 if not function_name.startswith('Check'):
1612 continue
1613 if function_name.endswith('Commit') and not self.committing:
1614 continue
1615 if function_name.endswith('Upload') and self.committing:
1616 continue
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001617 logging.debug('Running %s in %s', function_name, presubmit_path)
1618 results.extend(
Scott Leecc2fe9b2020-11-19 19:38:06 +00001619 self._run_check_function(function_name, context, sink))
1620 logging.debug('Running %s done.', function_name)
1621 self.more_cc.extend(output_api.more_cc)
1622
1623 else: # Old format
1624 if self.committing:
1625 function_name = 'CheckChangeOnCommit'
1626 else:
1627 function_name = 'CheckChangeOnUpload'
1628 if function_name in context:
1629 logging.debug('Running %s in %s', function_name, presubmit_path)
1630 results.extend(
1631 self._run_check_function(function_name, context, sink))
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001632 logging.debug('Running %s done.', function_name)
1633 self.more_cc.extend(output_api.more_cc)
1634
1635 finally:
1636 for f in input_api._named_temporary_files:
1637 os.remove(f)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001638
chase@chromium.org8e416c82009-10-06 04:30:44 +00001639 # Return the process to the original working directory.
1640 os.chdir(main_path)
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001641 return results
1642
Scott Leecc2fe9b2020-11-19 19:38:06 +00001643 def _run_check_function(self, function_name, context, sink=None):
1644 """Evaluates and returns the result of a given presubmit function.
1645
1646 If sink is given, the result of the presubmit function will be reported
1647 to the ResultSink.
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001648
1649 Args:
Scott Leecc2fe9b2020-11-19 19:38:06 +00001650 function_name: the name of the presubmit function to evaluate
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001651 context: a context dictionary in which the function will be evaluated
Scott Leecc2fe9b2020-11-19 19:38:06 +00001652 sink: an instance of ResultSink. None, by default.
1653 Returns:
1654 the result of the presubmit function call.
1655 """
1656 start_time = time_time()
1657 try:
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001658 result = eval(function_name + '(*__args)', context)
1659 self._check_result_type(result)
Gavin Mak554187a2021-03-31 20:34:42 +00001660 except Exception as e:
Scott Leecc2fe9b2020-11-19 19:38:06 +00001661 if sink:
1662 elapsed_time = time_time() - start_time
1663 sink.report(function_name, rdb_wrapper.STATUS_FAIL, elapsed_time)
Allen Webbb65bbfe2021-05-11 21:22:01 +00001664 # TODO(crbug.com/953884): replace raise_from with native py3:
1665 # raise .. from e
1666 try:
1667 from future.utils import raise_from
1668 raise_from(type(e)('Evaluation of %s failed: %s' % (function_name, e)),
1669 e)
1670 except ImportError:
1671 if self.verbose:
1672 traceback.print_exc()
1673 raise type(e)('Evaluation of %s failed: %s' % (function_name, e))
Scott Leecc2fe9b2020-11-19 19:38:06 +00001674
1675 if sink:
1676 elapsed_time = time_time() - start_time
1677 status = rdb_wrapper.STATUS_PASS
1678 if any(r.fatal for r in result):
1679 status = rdb_wrapper.STATUS_FAIL
1680 sink.report(function_name, status, elapsed_time)
1681
1682 return result
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001683
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00001684 def _check_result_type(self, result):
1685 """Helper function which ensures result is a list, and all elements are
1686 instances of OutputApi.PresubmitResult"""
1687 if not isinstance(result, (tuple, list)):
1688 raise PresubmitFailure('Presubmit functions must return a tuple or list')
1689 if not all(isinstance(res, OutputApi.PresubmitResult) for res in result):
1690 raise PresubmitFailure(
1691 'All presubmit results must be of types derived from '
1692 'output_api.PresubmitResult')
1693
1694
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001695def DoPresubmitChecks(change,
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001696 committing,
1697 verbose,
maruel@chromium.orgb0dfd352009-06-10 14:12:54 +00001698 default_presubmit,
dpranke@chromium.org970c5222011-03-12 00:32:24 +00001699 may_prompt,
Aaron Gable668c1d82018-04-03 10:19:16 -07001700 gerrit_obj,
Edward Lesmes8e282792018-04-03 18:50:29 -04001701 dry_run=None,
Debrian Figueroadd2737e2019-06-21 23:50:13 +00001702 parallel=False,
Edward Lesmeseb1bd622021-03-01 19:54:07 +00001703 json_output=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001704 """Runs all presubmit checks that apply to the files in the change.
1705
1706 This finds all PRESUBMIT.py files in directories enclosing the files in the
1707 change (up to the repository root) and calls the relevant entrypoint function
1708 depending on whether the change is being committed or uploaded.
1709
1710 Prints errors, warnings and notifications. Prompts the user for warnings
1711 when needed.
1712
1713 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001714 change: The Change object.
agable92bec4f2016-08-24 09:27:27 -07001715 committing: True if 'git cl land' is running, False if 'git cl upload' is.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001716 verbose: Prints debug info.
maruel@chromium.org0ff1fab2009-05-22 13:08:15 +00001717 default_presubmit: A default presubmit script to execute in any case.
Quinten Yearsley516fe7f2016-12-14 11:50:18 -08001718 may_prompt: Enable (y/n) questions on warning or error. If False,
1719 any questions are answered with yes by default.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001720 gerrit_obj: provides basic Gerrit codereview functionality.
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001721 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -04001722 parallel: if true, all tests specified by input_api.RunTests in all
1723 PRESUBMIT files will be run in parallel.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001724
1725 Return:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001726 1 if presubmit checks failed or 0 otherwise.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001727 """
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001728 old_environ = os.environ
1729 try:
1730 # Make sure python subprocesses won't generate .pyc files.
1731 os.environ = os.environ.copy()
Edward Lemurb9830242019-10-30 22:19:20 +00001732 os.environ['PYTHONDONTWRITEBYTECODE'] = '1'
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001733
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001734 python_version = 'Python %s' % sys.version_info.major
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001735 if committing:
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001736 sys.stdout.write('Running %s presubmit commit checks ...\n' %
1737 python_version)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001738 else:
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001739 sys.stdout.write('Running %s presubmit upload checks ...\n' %
1740 python_version)
Edward Lemurecc27072020-01-06 16:42:34 +00001741 start_time = time_time()
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001742 presubmit_files = ListRelevantPresubmitFiles(
agable0b65e732016-11-22 09:25:46 -08001743 change.AbsoluteLocalPaths(), change.RepositoryRoot())
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001744 if not presubmit_files and verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001745 sys.stdout.write('Warning, no PRESUBMIT.py found.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001746 results = []
Edward Lesmes8e282792018-04-03 18:50:29 -04001747 thread_pool = ThreadPool()
Edward Lemur7e3c67f2018-07-20 20:52:49 +00001748 executer = PresubmitExecuter(change, committing, verbose, gerrit_obj,
Edward Lesmeseb1bd622021-03-01 19:54:07 +00001749 dry_run, thread_pool, parallel)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001750 if default_presubmit:
1751 if verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001752 sys.stdout.write('Running default presubmit script.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001753 fake_path = os.path.join(change.RepositoryRoot(), 'PRESUBMIT.py')
1754 results += executer.ExecPresubmitScript(default_presubmit, fake_path)
1755 for filename in presubmit_files:
1756 filename = os.path.abspath(filename)
1757 if verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001758 sys.stdout.write('Running %s\n' % filename)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001759 # Accept CRLF presubmit script.
1760 presubmit_script = gclient_utils.FileRead(filename, 'rU')
1761 results += executer.ExecPresubmitScript(presubmit_script, filename)
Edward Lesmes8e282792018-04-03 18:50:29 -04001762 results += thread_pool.RunAsync()
1763
Edward Lemur6eb1d322020-02-27 22:20:15 +00001764 messages = {}
1765 should_prompt = False
1766 presubmits_failed = False
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001767 for result in results:
1768 if result.fatal:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001769 presubmits_failed = True
1770 messages.setdefault('ERRORS', []).append(result)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001771 elif result.should_prompt:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001772 should_prompt = True
1773 messages.setdefault('Warnings', []).append(result)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001774 else:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001775 messages.setdefault('Messages', []).append(result)
pam@chromium.orged9a0832009-09-09 22:48:55 +00001776
Edward Lemur6eb1d322020-02-27 22:20:15 +00001777 sys.stdout.write('\n')
1778 for name, items in messages.items():
1779 sys.stdout.write('** Presubmit %s **\n' % name)
1780 for item in items:
1781 item.handle()
1782 sys.stdout.write('\n')
pam@chromium.orged9a0832009-09-09 22:48:55 +00001783
Edward Lemurecc27072020-01-06 16:42:34 +00001784 total_time = time_time() - start_time
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001785 if total_time > 1.0:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001786 sys.stdout.write(
1787 'Presubmit checks took %.1fs to calculate.\n\n' % total_time)
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +00001788
Edward Lemur6eb1d322020-02-27 22:20:15 +00001789 if not should_prompt and not presubmits_failed:
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001790 sys.stdout.write('%s presubmit checks passed.\n' % python_version)
Edward Lemur6eb1d322020-02-27 22:20:15 +00001791 elif should_prompt:
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001792 sys.stdout.write('There were %s presubmit warnings. ' % python_version)
Quinten Yearsley516fe7f2016-12-14 11:50:18 -08001793 if may_prompt:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001794 presubmits_failed = not prompt_should_continue(
1795 'Are you sure you wish to continue? (y/N): ')
Garrett Beatyacb807e2020-08-28 18:17:24 +00001796 else:
1797 sys.stdout.write('\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001798
Edward Lemur1dc66e12020-02-21 21:36:34 +00001799 if json_output:
1800 # Write the presubmit results to json output
1801 presubmit_results = {
1802 'errors': [
Edward Lemur6eb1d322020-02-27 22:20:15 +00001803 error.json_format()
1804 for error in messages.get('ERRORS', [])
Edward Lemur1dc66e12020-02-21 21:36:34 +00001805 ],
1806 'notifications': [
Edward Lemur6eb1d322020-02-27 22:20:15 +00001807 notification.json_format()
1808 for notification in messages.get('Messages', [])
Edward Lemur1dc66e12020-02-21 21:36:34 +00001809 ],
1810 'warnings': [
Edward Lemur6eb1d322020-02-27 22:20:15 +00001811 warning.json_format()
1812 for warning in messages.get('Warnings', [])
Edward Lemur1dc66e12020-02-21 21:36:34 +00001813 ],
Edward Lemur6eb1d322020-02-27 22:20:15 +00001814 'more_cc': executer.more_cc,
Edward Lemur1dc66e12020-02-21 21:36:34 +00001815 }
1816
1817 gclient_utils.FileWrite(
1818 json_output, json.dumps(presubmit_results, sort_keys=True))
1819
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001820 global _ASKED_FOR_FEEDBACK
1821 # Ask for feedback one time out of 5.
1822 if (len(results) and random.randint(0, 4) == 0 and not _ASKED_FOR_FEEDBACK):
Edward Lemur6eb1d322020-02-27 22:20:15 +00001823 sys.stdout.write(
maruel@chromium.org1ce8e662014-01-14 15:23:00 +00001824 'Was the presubmit check useful? If not, run "git cl presubmit -v"\n'
1825 'to figure out which PRESUBMIT.py was run, then run git blame\n'
1826 'on the file to figure out who to ask for help.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001827 _ASKED_FOR_FEEDBACK = True
Edward Lemur6eb1d322020-02-27 22:20:15 +00001828
1829 return 1 if presubmits_failed else 0
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001830 finally:
1831 os.environ = old_environ
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001832
1833
Edward Lemur50984a62020-02-06 18:10:18 +00001834def _scan_sub_dirs(mask, recursive):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001835 if not recursive:
pgervais@chromium.orge57b09d2014-05-07 00:58:13 +00001836 return [x for x in glob.glob(mask) if x not in ('.svn', '.git')]
Lei Zhang9611c4c2017-04-04 01:41:56 -07001837
1838 results = []
1839 for root, dirs, files in os.walk('.'):
1840 if '.svn' in dirs:
1841 dirs.remove('.svn')
1842 if '.git' in dirs:
1843 dirs.remove('.git')
1844 for name in files:
1845 if fnmatch.fnmatch(name, mask):
1846 results.append(os.path.join(root, name))
1847 return results
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001848
1849
Edward Lemur50984a62020-02-06 18:10:18 +00001850def _parse_files(args, recursive):
tobiasjs2836bcf2016-08-16 04:08:16 -07001851 logging.debug('Searching for %s', args)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001852 files = []
1853 for arg in args:
Edward Lemur50984a62020-02-06 18:10:18 +00001854 files.extend([('M', f) for f in _scan_sub_dirs(arg, recursive)])
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001855 return files
1856
1857
Edward Lemur50984a62020-02-06 18:10:18 +00001858def _parse_change(parser, options):
1859 """Process change options.
1860
1861 Args:
1862 parser: The parser used to parse the arguments from command line.
1863 options: The arguments parsed from command line.
1864 Returns:
1865 A GitChange if the change root is a git repository, or a Change otherwise.
1866 """
1867 if options.files and options.all_files:
1868 parser.error('<files> cannot be specified when --all-files is set.')
1869
Edward Lesmes44ea3ff2020-02-05 00:14:30 +00001870 change_scm = scm.determine_scm(options.root)
Edward Lemur50984a62020-02-06 18:10:18 +00001871 if change_scm != 'git' and not options.files:
1872 parser.error('<files> is not optional for unversioned directories.')
1873
1874 if options.files:
1875 change_files = _parse_files(options.files, options.recursive)
1876 elif options.all_files:
1877 change_files = [('M', f) for f in scm.GIT.GetAllFiles(options.root)]
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001878 else:
Edward Lemur50984a62020-02-06 18:10:18 +00001879 change_files = scm.GIT.CaptureStatus(
Edward Lemur7f6dec02020-02-06 20:23:58 +00001880 options.root, options.upstream or None)
Edward Lemur50984a62020-02-06 18:10:18 +00001881
1882 logging.info('Found %d file(s).', len(change_files))
1883
1884 change_class = GitChange if change_scm == 'git' else Change
1885 return change_class(
1886 options.name,
1887 options.description,
1888 options.root,
1889 change_files,
1890 options.issue,
1891 options.patchset,
1892 options.author,
1893 upstream=options.upstream)
1894
1895
1896def _parse_gerrit_options(parser, options):
1897 """Process gerrit options.
1898
1899 SIDE EFFECTS: Modifies options.author and options.description from Gerrit if
1900 options.gerrit_fetch is set.
1901
1902 Args:
1903 parser: The parser used to parse the arguments from command line.
1904 options: The arguments parsed from command line.
1905 Returns:
Stephen Martinisfb09de22021-02-25 03:41:13 +00001906 A GerritAccessor object if options.gerrit_url is set, or None otherwise.
Edward Lemur50984a62020-02-06 18:10:18 +00001907 """
1908 gerrit_obj = None
Stephen Martinisfb09de22021-02-25 03:41:13 +00001909 if options.gerrit_url:
Edward Lesmeseb1bd622021-03-01 19:54:07 +00001910 gerrit_obj = GerritAccessor(
1911 url=options.gerrit_url,
1912 project=options.gerrit_project,
1913 branch=options.gerrit_branch)
Edward Lemur50984a62020-02-06 18:10:18 +00001914
1915 if not options.gerrit_fetch:
1916 return gerrit_obj
1917
1918 if not options.gerrit_url or not options.issue or not options.patchset:
1919 parser.error(
1920 '--gerrit_fetch requires --gerrit_url, --issue and --patchset.')
1921
1922 options.author = gerrit_obj.GetChangeOwner(options.issue)
1923 options.description = gerrit_obj.GetChangeDescription(
1924 options.issue, options.patchset)
1925
1926 logging.info('Got author: "%s"', options.author)
1927 logging.info('Got description: """\n%s\n"""', options.description)
1928
1929 return gerrit_obj
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001930
1931
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001932@contextlib.contextmanager
1933def canned_check_filter(method_names):
1934 filtered = {}
1935 try:
1936 for method_name in method_names:
1937 if not hasattr(presubmit_canned_checks, method_name):
Gavin Make6a62332020-12-04 21:57:10 +00001938 logging.warning('Skipping unknown "canned" check %s' % method_name)
Aaron Gableecee74c2018-04-02 15:13:08 -07001939 continue
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001940 filtered[method_name] = getattr(presubmit_canned_checks, method_name)
1941 setattr(presubmit_canned_checks, method_name, lambda *_a, **_kw: [])
1942 yield
1943 finally:
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001944 for name, method in filtered.items():
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001945 setattr(presubmit_canned_checks, name, method)
1946
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +00001947
sbc@chromium.org013731e2015-02-26 18:28:43 +00001948def main(argv=None):
Edward Lemura5799e32020-01-17 19:26:51 +00001949 parser = argparse.ArgumentParser(usage='%(prog)s [options] <files...>')
1950 hooks = parser.add_mutually_exclusive_group()
1951 hooks.add_argument('-c', '--commit', action='store_true',
1952 help='Use commit instead of upload checks.')
1953 hooks.add_argument('-u', '--upload', action='store_false', dest='commit',
1954 help='Use upload instead of commit checks.')
Edward Lemur75526302020-02-27 22:31:05 +00001955 hooks.add_argument('--post_upload', action='store_true',
1956 help='Run post-upload commit hooks.')
Edward Lemura5799e32020-01-17 19:26:51 +00001957 parser.add_argument('-r', '--recursive', action='store_true',
1958 help='Act recursively.')
1959 parser.add_argument('-v', '--verbose', action='count', default=0,
1960 help='Use 2 times for more debug info.')
1961 parser.add_argument('--name', default='no name')
1962 parser.add_argument('--author')
Edward Lemur227d5102020-02-25 23:45:35 +00001963 desc = parser.add_mutually_exclusive_group()
1964 desc.add_argument('--description', default='', help='The change description.')
1965 desc.add_argument('--description_file',
1966 help='File to read change description from.')
Edward Lemura5799e32020-01-17 19:26:51 +00001967 parser.add_argument('--issue', type=int, default=0)
1968 parser.add_argument('--patchset', type=int, default=0)
1969 parser.add_argument('--root', default=os.getcwd(),
1970 help='Search for PRESUBMIT.py up to this directory. '
1971 'If inherit-review-settings-ok is present in this '
1972 'directory, parent directories up to the root file '
1973 'system directories will also be searched.')
1974 parser.add_argument('--upstream',
1975 help='Git only: the base ref or upstream branch against '
1976 'which the diff should be computed.')
1977 parser.add_argument('--default_presubmit')
1978 parser.add_argument('--may_prompt', action='store_true', default=False)
1979 parser.add_argument('--skip_canned', action='append', default=[],
1980 help='A list of checks to skip which appear in '
1981 'presubmit_canned_checks. Can be provided multiple times '
1982 'to skip multiple canned checks.')
1983 parser.add_argument('--dry_run', action='store_true', help=argparse.SUPPRESS)
1984 parser.add_argument('--gerrit_url', help=argparse.SUPPRESS)
Edward Lesmeseb1bd622021-03-01 19:54:07 +00001985 parser.add_argument('--gerrit_project', help=argparse.SUPPRESS)
1986 parser.add_argument('--gerrit_branch', help=argparse.SUPPRESS)
Edward Lemura5799e32020-01-17 19:26:51 +00001987 parser.add_argument('--gerrit_fetch', action='store_true',
1988 help=argparse.SUPPRESS)
1989 parser.add_argument('--parallel', action='store_true',
1990 help='Run all tests specified by input_api.RunTests in '
1991 'all PRESUBMIT files in parallel.')
1992 parser.add_argument('--json_output',
1993 help='Write presubmit errors to json output.')
Edward Lemur1dc66e12020-02-21 21:36:34 +00001994 parser.add_argument('--all_files', action='store_true',
Edward Lemur50984a62020-02-06 18:10:18 +00001995 help='Mark all files under source control as modified.')
Edward Lemura5799e32020-01-17 19:26:51 +00001996 parser.add_argument('files', nargs='*',
1997 help='List of files to be marked as modified when '
1998 'executing presubmit or post-upload hooks. fnmatch '
1999 'wildcards can also be used.')
Edward Lemura5799e32020-01-17 19:26:51 +00002000 options = parser.parse_args(argv)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00002001
Erik Staabcca5c492020-04-16 17:40:07 +00002002 log_level = logging.ERROR
maruel@chromium.org899e1c12011-04-07 17:03:18 +00002003 if options.verbose >= 2:
Erik Staabcca5c492020-04-16 17:40:07 +00002004 log_level = logging.DEBUG
maruel@chromium.org899e1c12011-04-07 17:03:18 +00002005 elif options.verbose:
Erik Staabcca5c492020-04-16 17:40:07 +00002006 log_level = logging.INFO
2007 log_format = ('[%(levelname).1s%(asctime)s %(process)d %(thread)d '
2008 '%(filename)s] %(message)s')
2009 logging.basicConfig(format=log_format, level=log_level)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00002010
Edward Lemur227d5102020-02-25 23:45:35 +00002011 if options.description_file:
2012 options.description = gclient_utils.FileRead(options.description_file)
Edward Lemur50984a62020-02-06 18:10:18 +00002013 gerrit_obj = _parse_gerrit_options(parser, options)
2014 change = _parse_change(parser, options)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00002015
maruel@chromium.org899e1c12011-04-07 17:03:18 +00002016 try:
Edward Lemur75526302020-02-27 22:31:05 +00002017 if options.post_upload:
2018 return DoPostUploadExecuter(
2019 change,
2020 gerrit_obj,
2021 options.verbose)
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00002022 with canned_check_filter(options.skip_canned):
Edward Lemur6eb1d322020-02-27 22:20:15 +00002023 return DoPresubmitChecks(
Edward Lemur50984a62020-02-06 18:10:18 +00002024 change,
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00002025 options.commit,
2026 options.verbose,
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00002027 options.default_presubmit,
2028 options.may_prompt,
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00002029 gerrit_obj,
Edward Lesmes8e282792018-04-03 18:50:29 -04002030 options.dry_run,
Debrian Figueroadd2737e2019-06-21 23:50:13 +00002031 options.parallel,
Edward Lesmeseb1bd622021-03-01 19:54:07 +00002032 options.json_output)
Raul Tambre7c938462019-05-24 16:35:35 +00002033 except PresubmitFailure as e:
Raul Tambre80ee78e2019-05-06 22:41:05 +00002034 print(e, file=sys.stderr)
2035 print('Maybe your depot_tools is out of date?', file=sys.stderr)
maruel@chromium.org899e1c12011-04-07 17:03:18 +00002036 return 2
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00002037
2038
2039if __name__ == '__main__':
maruel@chromium.org35625c72011-03-23 17:34:02 +00002040 fix_encoding.fix_encoding()
sbc@chromium.org013731e2015-02-26 18:28:43 +00002041 try:
2042 sys.exit(main())
2043 except KeyboardInterrupt:
2044 sys.stderr.write('interrupted\n')
sergiybf8a3b382016-07-05 11:21:30 -07002045 sys.exit(2)