blob: 0ddbad94a3a95b0304cdf490cd438fcadb4daeae [file] [log] [blame]
maruel@chromium.orgddd59412011-11-30 14:20:38 +00001#!/usr/bin/env python
maruel@chromium.orgeb5edbc2012-01-16 17:03:28 +00002# Copyright (c) 2012 The Chromium Authors. All rights reserved.
maruel@chromium.orgddd59412011-11-30 14:20:38 +00003# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5
6"""Unit tests for git_cl.py."""
7
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01008import datetime
tandriide281ae2016-10-12 06:02:30 -07009import json
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +010010import logging
maruel@chromium.orgddd59412011-11-30 14:20:38 +000011import os
maruel@chromium.orga3353652011-11-30 14:26:57 +000012import StringIO
maruel@chromium.orgddd59412011-11-30 14:20:38 +000013import sys
Aaron Gable9a03ae02017-11-03 11:31:07 -070014import tempfile
maruel@chromium.orgddd59412011-11-30 14:20:38 +000015import unittest
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +000016import urlparse
maruel@chromium.orgddd59412011-11-30 14:20:38 +000017
18sys.path.insert(0, os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
19
20from testing_support.auto_stub import TestCase
21
Edward Lemur5ba1e9c2018-07-23 18:19:02 +000022import metrics
23# We have to disable monitoring before importing git_cl.
24metrics.DISABLE_METRICS_COLLECTION = True
25
Eric Boren2fb63102018-10-05 13:05:03 +000026import gerrit_util
maruel@chromium.orgddd59412011-11-30 14:20:38 +000027import git_cl
iannucci@chromium.org9e849272014-04-04 00:31:55 +000028import git_common
tandrii@chromium.org57d86542016-03-04 16:11:32 +000029import git_footers
maruel@chromium.orgddd59412011-11-30 14:20:38 +000030import subprocess2
maruel@chromium.orgddd59412011-11-30 14:20:38 +000031
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +000032
tandrii5d48c322016-08-18 16:19:37 -070033def callError(code=1, cmd='', cwd='', stdout='', stderr=''):
34 return subprocess2.CalledProcessError(code, cmd, cwd, stdout, stderr)
35
36
37CERR1 = callError(1)
38
39
Aaron Gable9a03ae02017-11-03 11:31:07 -070040def MakeNamedTemporaryFileMock(expected_content):
41 class NamedTemporaryFileMock(object):
42 def __init__(self, *args, **kwargs):
43 self.name = '/tmp/named'
44 self.expected_content = expected_content
45
46 def __enter__(self):
47 return self
48
49 def __exit__(self, _type, _value, _tb):
50 pass
51
52 def write(self, content):
53 if self.expected_content:
54 assert content == self.expected_content
55
56 def close(self):
57 pass
58
59 return NamedTemporaryFileMock
60
61
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000062class ChangelistMock(object):
63 # A class variable so we can access it when we don't have access to the
64 # instance that's being set.
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +000065 desc = ''
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000066 def __init__(self, **kwargs):
67 pass
68 def GetIssue(self):
69 return 1
Kenneth Russell61e2ed42017-02-15 11:47:13 -080070 def GetDescription(self, force=False):
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000071 return ChangelistMock.desc
dsansomee2d6fd92016-09-08 00:10:47 -070072 def UpdateDescription(self, desc, force=False):
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000073 ChangelistMock.desc = desc
74
tandrii5d48c322016-08-18 16:19:37 -070075
maruel@chromium.org2e72bb12012-01-17 15:18:35 +000076class PresubmitMock(object):
77 def __init__(self, *args, **kwargs):
78 self.reviewers = []
Daniel Cheng7227d212017-11-17 08:12:37 -080079 self.more_cc = ['chromium-reviews+test-more-cc@chromium.org']
80
maruel@chromium.org2e72bb12012-01-17 15:18:35 +000081 @staticmethod
82 def should_continue():
83 return True
84
85
maruel@chromium.org2e72bb12012-01-17 15:18:35 +000086class WatchlistsMock(object):
87 def __init__(self, _):
88 pass
89 @staticmethod
90 def GetWatchersForPaths(_):
91 return ['joe@example.com']
92
93
ukai@chromium.org78c4b982012-02-14 02:20:26 +000094class CodereviewSettingsFileMock(object):
95 def __init__(self):
96 pass
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -080097 # pylint: disable=no-self-use
ukai@chromium.org78c4b982012-02-14 02:20:26 +000098 def read(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +000099 return ('CODE_REVIEW_SERVER: gerrit.chromium.org\n' +
100 'GERRIT_HOST: True\n')
ukai@chromium.org78c4b982012-02-14 02:20:26 +0000101
102
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000103class AuthenticatorMock(object):
104 def __init__(self, *_args):
105 pass
106 def has_cached_credentials(self):
107 return True
tandrii221ab252016-10-06 08:12:04 -0700108 def authorize(self, http):
109 return http
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000110
111
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100112def CookiesAuthenticatorMockFactory(hosts_with_creds=None, same_auth=False):
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000113 """Use to mock Gerrit/Git credentials from ~/.netrc or ~/.gitcookies.
114
115 Usage:
116 >>> self.mock(git_cl.gerrit_util, "CookiesAuthenticator",
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100117 CookiesAuthenticatorMockFactory({'host': ('user', _, 'pass')})
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000118
119 OR
120 >>> self.mock(git_cl.gerrit_util, "CookiesAuthenticator",
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100121 CookiesAuthenticatorMockFactory(
122 same_auth=('user', '', 'pass'))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000123 """
124 class CookiesAuthenticatorMock(git_cl.gerrit_util.CookiesAuthenticator):
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800125 def __init__(self): # pylint: disable=super-init-not-called
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000126 # Intentionally not calling super() because it reads actual cookie files.
127 pass
128 @classmethod
129 def get_gitcookies_path(cls):
130 return '~/.gitcookies'
131 @classmethod
132 def get_netrc_path(cls):
133 return '~/.netrc'
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100134 def _get_auth_for_host(self, host):
135 if same_auth:
136 return same_auth
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000137 return (hosts_with_creds or {}).get(host)
138 return CookiesAuthenticatorMock
139
Aaron Gable9a03ae02017-11-03 11:31:07 -0700140
kmarshall9249e012016-08-23 12:02:16 -0700141class MockChangelistWithBranchAndIssue():
142 def __init__(self, branch, issue):
143 self.branch = branch
144 self.issue = issue
145 def GetBranch(self):
146 return self.branch
147 def GetIssue(self):
148 return self.issue
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000149
tandriic2405f52016-10-10 08:13:15 -0700150
151class SystemExitMock(Exception):
152 pass
153
154
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000155class TestGitClBasic(unittest.TestCase):
Andrii Shyshkalov31863012017-02-08 11:35:12 +0100156 def test_get_description(self):
Andrii Shyshkalovf5569d22018-10-15 03:35:23 +0000157 cl = git_cl.Changelist(issue=1, codereview='gerrit',
Andrii Shyshkalov31863012017-02-08 11:35:12 +0100158 codereview_host='host')
159 cl.description = 'x'
160 cl.has_description = True
Kenneth Russell61e2ed42017-02-15 11:47:13 -0800161 cl._codereview_impl.FetchDescription = lambda *a, **kw: 'y'
Andrii Shyshkalov31863012017-02-08 11:35:12 +0100162 self.assertEquals(cl.GetDescription(), 'x')
163 self.assertEquals(cl.GetDescription(force=True), 'y')
164 self.assertEquals(cl.GetDescription(), 'y')
165
Robert Iannucci09f1f3d2017-03-28 16:54:32 -0700166 def test_description_footers(self):
167 cl = git_cl.Changelist(issue=1, codereview='gerrit',
168 codereview_host='host')
169 cl.description = '\n'.join([
170 'This is some message',
171 '',
172 'It has some lines',
173 'and, also',
174 '',
175 'Some: Really',
176 'Awesome: Footers',
177 ])
178 cl.has_description = True
179 cl._codereview_impl.UpdateDescriptionRemote = lambda *a, **kw: 'y'
180 msg, footers = cl.GetDescriptionFooters()
181 self.assertEquals(
182 msg, ['This is some message', '', 'It has some lines', 'and, also'])
183 self.assertEquals(footers, [('Some', 'Really'), ('Awesome', 'Footers')])
184
185 msg.append('wut')
186 footers.append(('gnarly-dude', 'beans'))
187 cl.UpdateDescriptionFooters(msg, footers)
188 self.assertEquals(cl.GetDescription().splitlines(), [
189 'This is some message',
190 '',
191 'It has some lines',
192 'and, also',
193 'wut'
194 '',
195 'Some: Really',
196 'Awesome: Footers',
197 'Gnarly-Dude: beans',
198 ])
199
Andrii Shyshkalov71f0da32019-07-15 22:45:18 +0000200 def test_set_preserve_tryjobs(self):
201 d = git_cl.ChangeDescription('Simple.')
202 d.set_preserve_tryjobs()
203 self.assertEqual(d.description.splitlines(), [
204 'Simple.',
205 '',
206 'Cq-Do-Not-Cancel-Tryjobs: true',
207 ])
208 before = d.description
209 d.set_preserve_tryjobs()
210 self.assertEqual(before, d.description)
211
212 d = git_cl.ChangeDescription('\n'.join([
213 'One is enough',
214 '',
215 'Cq-Do-Not-Cancel-Tryjobs: dups not encouraged, but don\'t hurt',
216 'Change-Id: Ideadbeef',
217 ]))
218 d.set_preserve_tryjobs()
219 self.assertEqual(d.description.splitlines(), [
220 'One is enough',
221 '',
222 'Cq-Do-Not-Cancel-Tryjobs: dups not encouraged, but don\'t hurt',
223 'Change-Id: Ideadbeef',
224 'Cq-Do-Not-Cancel-Tryjobs: true',
225 ])
226
tandriif9aefb72016-07-01 09:06:51 -0700227 def test_get_bug_line_values(self):
228 f = lambda p, bugs: list(git_cl._get_bug_line_values(p, bugs))
229 self.assertEqual(f('', ''), [])
230 self.assertEqual(f('', '123,v8:456'), ['123', 'v8:456'])
231 self.assertEqual(f('v8', '456'), ['v8:456'])
232 self.assertEqual(f('v8', 'chromium:123,456'), ['v8:456', 'chromium:123'])
233 # Not nice, but not worth carying.
234 self.assertEqual(f('v8', 'chromium:123,456,v8:123'),
235 ['v8:456', 'chromium:123', 'v8:123'])
236
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100237 def _test_git_number(self, parent_msg, dest_ref, child_msg,
238 parent_hash='parenthash'):
239 desc = git_cl.ChangeDescription(child_msg)
240 desc.update_with_git_number_footers(parent_hash, parent_msg, dest_ref)
241 return desc.description
242
243 def assertEqualByLine(self, actual, expected):
244 self.assertEqual(actual.splitlines(), expected.splitlines())
245
246 def test_git_number_bad_parent(self):
247 with self.assertRaises(ValueError):
248 self._test_git_number('Parent', 'refs/heads/master', 'Child')
249
250 def test_git_number_bad_parent_footer(self):
251 with self.assertRaises(AssertionError):
252 self._test_git_number(
253 'Parent\n'
254 '\n'
255 'Cr-Commit-Position: wrong',
256 'refs/heads/master', 'Child')
257
258 def test_git_number_bad_lineage_ignored(self):
259 actual = self._test_git_number(
260 'Parent\n'
261 '\n'
262 'Cr-Commit-Position: refs/heads/master@{#1}\n'
263 'Cr-Branched-From: mustBeReal40CharHash-branch@{#pos}',
264 'refs/heads/master', 'Child')
265 self.assertEqualByLine(
266 actual,
267 'Child\n'
268 '\n'
269 'Cr-Commit-Position: refs/heads/master@{#2}\n'
270 'Cr-Branched-From: mustBeReal40CharHash-branch@{#pos}')
271
272 def test_git_number_same_branch(self):
273 actual = self._test_git_number(
274 'Parent\n'
275 '\n'
276 'Cr-Commit-Position: refs/heads/master@{#12}',
277 dest_ref='refs/heads/master',
278 child_msg='Child')
279 self.assertEqualByLine(
280 actual,
281 'Child\n'
282 '\n'
283 'Cr-Commit-Position: refs/heads/master@{#13}')
284
Andrii Shyshkalovde37c012017-07-06 21:06:50 +0200285 def test_git_number_same_branch_mixed_footers(self):
286 actual = self._test_git_number(
287 'Parent\n'
288 '\n'
289 'Cr-Commit-Position: refs/heads/master@{#12}',
290 dest_ref='refs/heads/master',
291 child_msg='Child\n'
292 '\n'
293 'Broken-by: design\n'
294 'BUG=123')
295 self.assertEqualByLine(
296 actual,
297 'Child\n'
298 '\n'
299 'Broken-by: design\n'
300 'BUG=123\n'
301 'Cr-Commit-Position: refs/heads/master@{#13}')
302
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100303 def test_git_number_same_branch_with_originals(self):
304 actual = self._test_git_number(
305 'Parent\n'
306 '\n'
307 'Cr-Commit-Position: refs/heads/master@{#12}',
308 dest_ref='refs/heads/master',
309 child_msg='Child\n'
310 '\n'
311 'Some users are smart and insert their own footers\n'
312 '\n'
313 'Cr-Whatever: value\n'
314 'Cr-Commit-Position: refs/copy/paste@{#22}')
315 self.assertEqualByLine(
316 actual,
317 'Child\n'
318 '\n'
319 'Some users are smart and insert their own footers\n'
320 '\n'
321 'Cr-Original-Whatever: value\n'
322 'Cr-Original-Commit-Position: refs/copy/paste@{#22}\n'
323 'Cr-Commit-Position: refs/heads/master@{#13}')
324
325 def test_git_number_new_branch(self):
326 actual = self._test_git_number(
327 'Parent\n'
328 '\n'
329 'Cr-Commit-Position: refs/heads/master@{#12}',
330 dest_ref='refs/heads/branch',
331 child_msg='Child')
332 self.assertEqualByLine(
333 actual,
334 'Child\n'
335 '\n'
336 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
337 'Cr-Branched-From: parenthash-refs/heads/master@{#12}')
338
339 def test_git_number_lineage(self):
340 actual = self._test_git_number(
341 'Parent\n'
342 '\n'
343 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
344 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
345 dest_ref='refs/heads/branch',
346 child_msg='Child')
347 self.assertEqualByLine(
348 actual,
349 'Child\n'
350 '\n'
351 'Cr-Commit-Position: refs/heads/branch@{#2}\n'
352 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
353
354 def test_git_number_moooooooore_lineage(self):
355 actual = self._test_git_number(
356 'Parent\n'
357 '\n'
358 'Cr-Commit-Position: refs/heads/branch@{#5}\n'
359 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
360 dest_ref='refs/heads/mooore',
361 child_msg='Child')
362 self.assertEqualByLine(
363 actual,
364 'Child\n'
365 '\n'
366 'Cr-Commit-Position: refs/heads/mooore@{#1}\n'
367 'Cr-Branched-From: parenthash-refs/heads/branch@{#5}\n'
368 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
369
Andrii Shyshkalovb5effa12016-12-14 19:35:12 +0100370 def test_git_number_ever_moooooooore_lineage(self):
Robert Iannucci456b0d62018-03-13 19:15:50 -0700371 self.maxDiff = 10000 # pylint: disable=attribute-defined-outside-init
Andrii Shyshkalovb5effa12016-12-14 19:35:12 +0100372 actual = self._test_git_number(
373 'CQ commit on fresh new branch + numbering.\n'
374 '\n'
375 'NOTRY=True\n'
376 'NOPRESUBMIT=True\n'
377 'BUG=\n'
378 '\n'
379 'Review-Url: https://codereview.chromium.org/2577703003\n'
380 'Cr-Commit-Position: refs/heads/gnumb-test/br@{#1}\n'
381 'Cr-Branched-From: 0749ff9edc-refs/heads/gnumb-test/cq@{#4}\n'
382 'Cr-Branched-From: 5c49df2da6-refs/heads/master@{#41618}',
383 dest_ref='refs/heads/gnumb-test/cl',
384 child_msg='git cl on fresh new branch + numbering.\n'
385 '\n'
386 'Review-Url: https://codereview.chromium.org/2575043003 .\n')
387 self.assertEqualByLine(
388 actual,
389 'git cl on fresh new branch + numbering.\n'
390 '\n'
391 'Review-Url: https://codereview.chromium.org/2575043003 .\n'
392 'Cr-Commit-Position: refs/heads/gnumb-test/cl@{#1}\n'
393 'Cr-Branched-From: parenthash-refs/heads/gnumb-test/br@{#1}\n'
394 'Cr-Branched-From: 0749ff9edc-refs/heads/gnumb-test/cq@{#4}\n'
395 'Cr-Branched-From: 5c49df2da6-refs/heads/master@{#41618}')
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100396
397 def test_git_number_cherry_pick(self):
398 actual = self._test_git_number(
399 'Parent\n'
400 '\n'
401 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
402 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
403 dest_ref='refs/heads/branch',
404 child_msg='Child, which is cherry-pick from master\n'
405 '\n'
406 'Cr-Commit-Position: refs/heads/master@{#100}\n'
407 '(cherry picked from commit deadbeef12345678deadbeef12345678deadbeef)')
408 self.assertEqualByLine(
409 actual,
410 'Child, which is cherry-pick from master\n'
411 '\n'
412 '(cherry picked from commit deadbeef12345678deadbeef12345678deadbeef)\n'
413 '\n'
414 'Cr-Original-Commit-Position: refs/heads/master@{#100}\n'
415 'Cr-Commit-Position: refs/heads/branch@{#2}\n'
416 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
417
Andrii Shyshkalovd4c86732018-09-25 04:29:31 +0000418 def test_gerrit_mirror_hack(self):
419 cr = 'chromium-review.googlesource.com'
420 url0 = 'https://%s/a/changes/x?a=b' % cr
421 origMirrors = git_cl.gerrit_util._GERRIT_MIRROR_PREFIXES
422 try:
423 git_cl.gerrit_util._GERRIT_MIRROR_PREFIXES = ['us1', 'us2']
424 url1 = git_cl.gerrit_util._UseGerritMirror(url0, cr)
425 url2 = git_cl.gerrit_util._UseGerritMirror(url1, cr)
426 url3 = git_cl.gerrit_util._UseGerritMirror(url2, cr)
427
428 self.assertNotEqual(url1, url2)
429 self.assertEqual(sorted((url1, url2)), [
430 'https://us1-mirror-chromium-review.googlesource.com/a/changes/x?a=b',
431 'https://us2-mirror-chromium-review.googlesource.com/a/changes/x?a=b'])
432 self.assertEqual(url1, url3)
433 finally:
434 git_cl.gerrit_util._GERRIT_MIRROR_PREFIXES = origMirrors
435
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +0000436 def test_valid_accounts(self):
437 mock_per_account = {
438 'u1': None, # 404, doesn't exist.
439 'u2': {
440 '_account_id': 123124,
441 'avatars': [],
442 'email': 'u2@example.com',
443 'name': 'User Number 2',
444 'status': 'OOO',
445 },
446 'u3': git_cl.gerrit_util.GerritError(500, 'retries didn\'t help :('),
447 }
448 def GetAccountDetailsMock(_, account):
449 # Poor-man's mock library's side_effect.
450 v = mock_per_account.pop(account)
451 if isinstance(v, Exception):
452 raise v
453 return v
454
455 original = git_cl.gerrit_util.GetAccountDetails
456 try:
457 git_cl.gerrit_util.GetAccountDetails = GetAccountDetailsMock
458 actual = git_cl.gerrit_util.ValidAccounts(
459 'host', ['u1', 'u2', 'u3'], max_threads=1)
460 finally:
461 git_cl.gerrit_util.GetAccountDetails = original
462 self.assertEqual(actual, {
463 'u2': {
464 '_account_id': 123124,
465 'avatars': [],
466 'email': 'u2@example.com',
467 'name': 'User Number 2',
468 'status': 'OOO',
469 },
470 })
471
472
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200473class TestParseIssueURL(unittest.TestCase):
474 def _validate(self, parsed, issue=None, patchset=None, hostname=None,
475 codereview=None, fail=False):
476 self.assertIsNotNone(parsed)
477 if fail:
478 self.assertFalse(parsed.valid)
479 return
480 self.assertTrue(parsed.valid)
481 self.assertEqual(parsed.issue, issue)
482 self.assertEqual(parsed.patchset, patchset)
483 self.assertEqual(parsed.hostname, hostname)
484 self.assertEqual(parsed.codereview, codereview)
485
486 def _run_and_validate(self, func, url, *args, **kwargs):
487 result = func(urlparse.urlparse(url))
488 if kwargs.pop('fail', False):
489 self.assertIsNone(result)
490 return None
491 self._validate(result, *args, fail=False, **kwargs)
492
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200493 def test_gerrit(self):
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200494 def test(url, *args, **kwargs):
495 self._run_and_validate(git_cl._GerritChangelistImpl.ParseIssueURL, url,
496 *args, codereview='gerrit', **kwargs)
497
498 test('http://chrome-review.source.com/c/123',
499 123, None, 'chrome-review.source.com')
500 test('https://chrome-review.source.com/c/123/',
501 123, None, 'chrome-review.source.com')
502 test('https://chrome-review.source.com/c/123/4',
503 123, 4, 'chrome-review.source.com')
504 test('https://chrome-review.source.com/#/c/123/4',
505 123, 4, 'chrome-review.source.com')
506 test('https://chrome-review.source.com/c/123/4',
507 123, 4, 'chrome-review.source.com')
508 test('https://chrome-review.source.com/123',
509 123, None, 'chrome-review.source.com')
510 test('https://chrome-review.source.com/123/4',
511 123, 4, 'chrome-review.source.com')
512
513 test('https://chrome-review.source.com/c/123/1/whatisthis', fail=True)
514 test('https://chrome-review.source.com/c/abc/', fail=True)
515 test('ssh://chrome-review.source.com/c/123/1/', fail=True)
516
517 def test_ParseIssueNumberArgument(self):
518 def test(arg, *args, **kwargs):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +0200519 codereview_hint = kwargs.pop('hint', None)
520 self._validate(git_cl.ParseIssueNumberArgument(arg, codereview_hint),
521 *args, **kwargs)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200522
523 test('123', 123)
524 test('', fail=True)
525 test('abc', fail=True)
526 test('123/1', fail=True)
527 test('123a', fail=True)
528 test('ssh://chrome-review.source.com/#/c/123/4/', fail=True)
Andrii Shyshkalovf5569d22018-10-15 03:35:23 +0000529
530 # Looks like Rietveld and Gerrit, but we should select Gerrit now
531 # w/ or w/o hint.
Andrii Shyshkalovc9712392017-04-11 13:35:21 +0200532 test('https://codereview.source.com/123',
533 123, None, 'codereview.source.com', 'gerrit',
534 hint='gerrit')
Andrii Shyshkalovf5569d22018-10-15 03:35:23 +0000535 test('https://codereview.source.com/123',
536 123, None, 'codereview.source.com', 'gerrit')
537
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200538 # Gerrrit.
539 test('https://chrome-review.source.com/c/123/4',
540 123, 4, 'chrome-review.source.com', 'gerrit')
541 test('https://chrome-review.source.com/bad/123/4', fail=True)
542
543
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100544class GitCookiesCheckerTest(TestCase):
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100545 def setUp(self):
546 super(GitCookiesCheckerTest, self).setUp()
547 self.c = git_cl._GitCookiesChecker()
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100548 self.c._all_hosts = []
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100549
550 def mock_hosts_creds(self, subhost_identity_pairs):
551 def ensure_googlesource(h):
552 if not h.endswith(self.c._GOOGLESOURCE):
553 assert not h.endswith('.')
554 return h + '.' + self.c._GOOGLESOURCE
555 return h
556 self.c._all_hosts = [(ensure_googlesource(h), i, '.gitcookies')
557 for h, i in subhost_identity_pairs]
558
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +0200559 def test_identity_parsing(self):
560 self.assertEqual(self.c._parse_identity('ldap.google.com'),
561 ('ldap', 'google.com'))
562 self.assertEqual(self.c._parse_identity('git-ldap.example.com'),
563 ('ldap', 'example.com'))
564 # Specical case because we know there are no subdomains in chromium.org.
565 self.assertEqual(self.c._parse_identity('git-note.period.chromium.org'),
566 ('note.period', 'chromium.org'))
Lei Zhangd3f769a2017-12-15 15:16:14 -0800567 # Pathological: ".period." can be either username OR domain, more likely
568 # domain.
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +0200569 self.assertEqual(self.c._parse_identity('git-note.period.example.com'),
570 ('note', 'period.example.com'))
571
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100572 def test_analysis_nothing(self):
573 self.c._all_hosts = []
574 self.assertFalse(self.c.has_generic_host())
575 self.assertEqual(set(), self.c.get_conflicting_hosts())
576 self.assertEqual(set(), self.c.get_duplicated_hosts())
577 self.assertEqual(set(), self.c.get_partially_configured_hosts())
578 self.assertEqual(set(), self.c.get_hosts_with_wrong_identities())
579
580 def test_analysis(self):
581 self.mock_hosts_creds([
582 ('.googlesource.com', 'git-example.chromium.org'),
583
584 ('chromium', 'git-example.google.com'),
585 ('chromium-review', 'git-example.google.com'),
586 ('chrome-internal', 'git-example.chromium.org'),
587 ('chrome-internal-review', 'git-example.chromium.org'),
588 ('conflict', 'git-example.google.com'),
589 ('conflict-review', 'git-example.chromium.org'),
590 ('dup', 'git-example.google.com'),
591 ('dup', 'git-example.google.com'),
592 ('dup-review', 'git-example.google.com'),
593 ('partial', 'git-example.google.com'),
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200594 ('gpartial-review', 'git-example.google.com'),
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100595 ])
596 self.assertTrue(self.c.has_generic_host())
597 self.assertEqual(set(['conflict.googlesource.com']),
598 self.c.get_conflicting_hosts())
599 self.assertEqual(set(['dup.googlesource.com']),
600 self.c.get_duplicated_hosts())
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200601 self.assertEqual(set(['partial.googlesource.com',
602 'gpartial-review.googlesource.com']),
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100603 self.c.get_partially_configured_hosts())
604 self.assertEqual(set(['chromium.googlesource.com',
605 'chrome-internal.googlesource.com']),
606 self.c.get_hosts_with_wrong_identities())
607
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100608 def test_report_no_problems(self):
609 self.test_analysis_nothing()
610 self.mock(sys, 'stdout', StringIO.StringIO())
611 self.assertFalse(self.c.find_and_report_problems())
612 self.assertEqual(sys.stdout.getvalue(), '')
613
614 def test_report(self):
615 self.test_analysis()
616 self.mock(sys, 'stdout', StringIO.StringIO())
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200617 self.mock(git_cl.gerrit_util.CookiesAuthenticator, 'get_gitcookies_path',
618 classmethod(lambda _: '~/.gitcookies'))
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100619 self.assertTrue(self.c.find_and_report_problems())
620 with open(os.path.join(os.path.dirname(__file__),
621 'git_cl_creds_check_report.txt')) as f:
622 expected = f.read()
623 def by_line(text):
624 return [l.rstrip() for l in text.rstrip().splitlines()]
Robert Iannucci456b0d62018-03-13 19:15:50 -0700625 self.maxDiff = 10000 # pylint: disable=attribute-defined-outside-init
Andrii Shyshkalov4812e612017-03-27 17:22:57 +0200626 self.assertEqual(by_line(sys.stdout.getvalue().strip()), by_line(expected))
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100627
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -0800628
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000629class TestGitCl(TestCase):
630 def setUp(self):
631 super(TestGitCl, self).setUp()
632 self.calls = []
tandrii9d206752016-06-20 11:32:47 -0700633 self._calls_done = []
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000634 self.mock(git_cl, 'time_time',
635 lambda: self._mocked_call('time.time'))
636 self.mock(git_cl.metrics.collector, 'add_repeated',
637 lambda *a: self._mocked_call('add_repeated', *a))
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000638 self.mock(subprocess2, 'call', self._mocked_call)
639 self.mock(subprocess2, 'check_call', self._mocked_call)
640 self.mock(subprocess2, 'check_output', self._mocked_call)
tandrii5d48c322016-08-18 16:19:37 -0700641 self.mock(subprocess2, 'communicate',
642 lambda *a, **kw: ([self._mocked_call(*a, **kw), ''], 0))
tandrii@chromium.orga342c922016-03-16 07:08:25 +0000643 self.mock(git_cl.gclient_utils, 'CheckCallAndFilter', self._mocked_call)
sbc@chromium.org71437c02015-04-09 19:29:40 +0000644 self.mock(git_common, 'is_dirty_git_tree', lambda x: False)
iannucci@chromium.org9e849272014-04-04 00:31:55 +0000645 self.mock(git_common, 'get_or_create_merge_base',
646 lambda *a: (
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000647 self._mocked_call(['get_or_create_merge_base'] + list(a))))
pgervais@chromium.org8ba38ff2015-06-11 21:41:25 +0000648 self.mock(git_cl, 'BranchExists', lambda _: True)
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000649 self.mock(git_cl, 'FindCodereviewSettingsFile', lambda: '')
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000650 self.mock(git_cl, 'SaveDescriptionBackup', lambda _:
651 self._mocked_call('SaveDescriptionBackup'))
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100652 self.mock(git_cl, 'ask_for_data', lambda *a, **k: self._mocked_call(
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000653 *(['ask_for_data'] + list(a)), **k))
phajdan.jre328cf92016-08-22 04:12:17 -0700654 self.mock(git_cl, 'write_json', lambda path, contents:
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000655 self._mocked_call('write_json', path, contents))
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000656 self.mock(git_cl.presubmit_support, 'DoPresubmitChecks', PresubmitMock)
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000657 self.mock(git_cl.watchlists, 'Watchlists', WatchlistsMock)
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000658 self.mock(git_cl.auth, 'get_authenticator_for_host', AuthenticatorMock)
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +0100659 self.mock(git_cl.gerrit_util, 'GetChangeDetail',
660 lambda *args, **kwargs: self._mocked_call(
661 'GetChangeDetail', *args, **kwargs))
Aaron Gable0ffdf2d2017-06-05 13:01:17 -0700662 self.mock(git_cl.gerrit_util, 'GetChangeComments',
663 lambda *args, **kwargs: self._mocked_call(
664 'GetChangeComments', *args, **kwargs))
Quinten Yearsley0e617c02019-02-20 00:37:03 +0000665 self.mock(git_cl.gerrit_util, 'GetChangeRobotComments',
666 lambda *args, **kwargs: self._mocked_call(
667 'GetChangeRobotComments', *args, **kwargs))
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +0100668 self.mock(git_cl.gerrit_util, 'AddReviewers',
Aaron Gable6dadfbf2017-05-09 14:27:58 -0700669 lambda h, i, reviewers, ccs, notify: self._mocked_call(
670 'AddReviewers', h, i, reviewers, ccs, notify))
Aaron Gablefd238082017-06-07 13:42:34 -0700671 self.mock(git_cl.gerrit_util, 'SetReview',
Aaron Gablefc62f762017-07-17 11:12:07 -0700672 lambda h, i, msg=None, labels=None, notify=None:
673 self._mocked_call('SetReview', h, i, msg, labels, notify))
Andrii Shyshkalov733d4ec2018-04-19 11:48:58 -0700674 self.mock(git_cl.gerrit_util.LuciContextAuthenticator, 'is_luci',
675 staticmethod(lambda: False))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000676 self.mock(git_cl.gerrit_util.GceAuthenticator, 'is_gce',
677 classmethod(lambda _: False))
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +0000678 self.mock(git_cl.gerrit_util, 'ValidAccounts',
679 lambda host, accounts:
680 self._mocked_call('ValidAccounts', host, accounts))
tandriic2405f52016-10-10 08:13:15 -0700681 self.mock(git_cl, 'DieWithError',
Christopher Lamf732cd52017-01-24 12:40:11 +1100682 lambda msg, change=None: self._mocked_call(['DieWithError', msg]))
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000683 # It's important to reset settings to not have inter-tests interference.
684 git_cl.settings = None
685
686 def tearDown(self):
wychen@chromium.org445c8962015-04-28 23:30:05 +0000687 try:
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100688 self.assertEquals([], self.calls)
689 except AssertionError:
wychen@chromium.org445c8962015-04-28 23:30:05 +0000690 if not self.has_failed():
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100691 raise
692 # Sadly, has_failed() returns True if this OR any other tests before this
693 # one have failed.
Andrii Shyshkalove05d4882017-04-12 14:34:49 +0200694 git_cl.logging.error(
695 '!!!!!! IF YOU SEE THIS, READ BELOW, IT WILL SAVE YOUR TIME !!!!!\n'
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100696 'There are un-consumed self.calls after this test has finished.\n'
697 'If you don\'t know which test this is, run:\n'
Aaron Gable3a16ed12017-03-23 10:51:55 -0700698 ' tests/git_cl_tests.py -v\n'
Andrii Shyshkalove05d4882017-04-12 14:34:49 +0200699 'If you are already running only this test, then **first** fix the '
700 'problem whose exception is emitted below by unittest runner.\n'
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100701 'Else, to be sure what\'s going on, run this test **alone** with \n'
Aaron Gable3a16ed12017-03-23 10:51:55 -0700702 ' tests/git_cl_tests.py TestGitCl.<name>\n'
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100703 'and follow instructions above.\n' +
704 '=' * 80)
wychen@chromium.org445c8962015-04-28 23:30:05 +0000705 finally:
706 super(TestGitCl, self).tearDown()
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000707
iannucci@chromium.org9e849272014-04-04 00:31:55 +0000708 def _mocked_call(self, *args, **_kwargs):
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000709 self.assertTrue(
710 self.calls,
tandrii9d206752016-06-20 11:32:47 -0700711 '@%d Expected: <Missing> Actual: %r' % (len(self._calls_done), args))
wychen@chromium.orga872e752015-04-28 23:42:18 +0000712 top = self.calls.pop(0)
wychen@chromium.orga872e752015-04-28 23:42:18 +0000713 expected_args, result = top
714
maruel@chromium.orge52678e2013-04-26 18:34:44 +0000715 # Also logs otherwise it could get caught in a try/finally and be hard to
716 # diagnose.
717 if expected_args != args:
tandrii9d206752016-06-20 11:32:47 -0700718 N = 5
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000719 prior_calls = '\n '.join(
tandrii9d206752016-06-20 11:32:47 -0700720 '@%d: %r' % (len(self._calls_done) - N + i, c[0])
721 for i, c in enumerate(self._calls_done[-N:]))
722 following_calls = '\n '.join(
723 '@%d: %r' % (len(self._calls_done) + i + 1, c[0])
724 for i, c in enumerate(self.calls[:N]))
725 extended_msg = (
726 'A few prior calls:\n %s\n\n'
727 'This (expected):\n @%d: %r\n'
728 'This (actual):\n @%d: %r\n\n'
729 'A few following expected calls:\n %s' %
730 (prior_calls, len(self._calls_done), expected_args,
731 len(self._calls_done), args, following_calls))
732 git_cl.logging.error(extended_msg)
733
tandrii99a72f22016-08-17 14:33:24 -0700734 self.fail('@%d\n'
735 ' Expected: %r\n'
736 ' Actual: %r' % (
tandrii9d206752016-06-20 11:32:47 -0700737 len(self._calls_done), expected_args, args))
738
739 self._calls_done.append(top)
tandrii5d48c322016-08-18 16:19:37 -0700740 if isinstance(result, Exception):
741 raise result
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000742 return result
743
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100744 def test_ask_for_explicit_yes_true(self):
745 self.calls = [
746 (('ask_for_data', 'prompt [Yes/No]: '), 'blah'),
747 (('ask_for_data', 'Please, type yes or no: '), 'ye'),
748 ]
749 self.assertTrue(git_cl.ask_for_explicit_yes('prompt'))
750
tandrii48df5812016-10-17 03:55:37 -0700751 def test_LoadCodereviewSettingsFromFile_gerrit(self):
752 codereview_file = StringIO.StringIO('GERRIT_HOST: true')
753 self.calls = [
754 ((['git', 'config', '--unset-all', 'rietveld.cc'],), CERR1),
tandrii48df5812016-10-17 03:55:37 -0700755 ((['git', 'config', '--unset-all', 'rietveld.tree-status-url'],), CERR1),
756 ((['git', 'config', '--unset-all', 'rietveld.viewvc-url'],), CERR1),
757 ((['git', 'config', '--unset-all', 'rietveld.bug-prefix'],), CERR1),
758 ((['git', 'config', '--unset-all', 'rietveld.cpplint-regex'],), CERR1),
tandrii48df5812016-10-17 03:55:37 -0700759 ((['git', 'config', '--unset-all', 'rietveld.cpplint-ignore-regex'],),
760 CERR1),
tandrii48df5812016-10-17 03:55:37 -0700761 ((['git', 'config', '--unset-all', 'rietveld.run-post-upload-hook'],),
762 CERR1),
763 ((['git', 'config', 'gerrit.host', 'true'],), ''),
764 ]
765 self.assertIsNone(git_cl.LoadCodereviewSettingsFromFile(codereview_file))
766
maruel@chromium.orga3353652011-11-30 14:26:57 +0000767 @classmethod
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000768 def _is_gerrit_calls(cls, gerrit=False):
769 return [((['git', 'config', 'rietveld.autoupdate'],), ''),
770 ((['git', 'config', 'gerrit.host'],), 'True' if gerrit else '')]
771
772 @classmethod
tandrii@chromium.org1e67bb72016-02-11 12:15:49 +0000773 def _git_post_upload_calls(cls):
774 return [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000775 ((['git', 'rev-parse', 'HEAD'],), 'hash'),
776 ((['git', 'symbolic-ref', 'HEAD'],), 'hash'),
777 ((['git',
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000778 'config', 'branch.hash.last-upload-hash', 'hash'],), ''),
rmistry@google.com5626a922015-02-26 14:03:30 +0000779 ((['git', 'config', 'rietveld.run-post-upload-hook'],), ''),
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000780 ]
781
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000782 @staticmethod
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000783 def _git_sanity_checks(diff_base, working_branch, get_remote_branch=True):
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000784 fake_ancestor = 'fake_ancestor'
785 fake_cl = 'fake_cl_for_patch'
786 return [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000787 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000788 'rev-parse', '--verify', diff_base],), fake_ancestor),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000789 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000790 'merge-base', fake_ancestor, 'HEAD'],), fake_ancestor),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000791 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000792 'rev-list', '^' + fake_ancestor, 'HEAD'],), fake_cl),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000793 # Mock a config miss (error code 1)
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000794 ((['git',
tandrii5d48c322016-08-18 16:19:37 -0700795 'config', 'gitcl.remotebranch'],), CERR1),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000796 ] + ([
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000797 # Call to GetRemoteBranch()
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000798 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000799 'config', 'branch.%s.merge' % working_branch],),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000800 'refs/heads/master'),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000801 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000802 'config', 'branch.%s.remote' % working_branch],), 'origin'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000803 ] if get_remote_branch else []) + [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000804 ((['git', 'rev-list', '^' + fake_ancestor,
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000805 'refs/remotes/origin/master'],), ''),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000806 ]
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000807
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000808 @classmethod
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000809 def _gerrit_ensure_auth_calls(
810 cls, issue=None, skip_auth_check=False, short_hostname='chromium'):
shinyak@chromium.org00dbccd2016-04-15 07:24:43 +0000811 cmd = ['git', 'config', '--bool', 'gerrit.skip-ensure-authenticated']
tandrii@chromium.org28253532016-04-14 13:46:56 +0000812 if skip_auth_check:
813 return [((cmd, ), 'true')]
814
tandrii5d48c322016-08-18 16:19:37 -0700815 calls = [((cmd, ), CERR1)]
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000816 calls.extend([
817 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
818 ((['git', 'config', 'branch.master.remote'],), 'origin'),
819 ((['git', 'config', 'remote.origin.url'],),
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000820 'https://%s.googlesource.com/my/repo' % short_hostname),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000821 ])
Daniel Chengcf6269b2019-05-18 01:02:12 +0000822 if issue:
823 calls.extend([
824 ((['git', 'config', 'branch.master.gerritserver'],), CERR1),
825 ])
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000826 return calls
827
828 @classmethod
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100829 def _gerrit_base_calls(cls, issue=None, fetched_description=None,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200830 fetched_status=None, other_cl_owner=None,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000831 custom_cl_base=None, short_hostname='chromium'):
Aaron Gable13101a62018-02-09 13:20:41 -0800832 calls = cls._is_gerrit_calls(True)
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100833 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200834 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200835 ((['git', 'config', 'branch.master.gerritissue'],),
836 CERR1 if issue is None else str(issue)),
837 ]
838
839 if custom_cl_base:
840 ancestor_revision = custom_cl_base
841 else:
842 # Determine ancestor_revision to be merge base.
843 ancestor_revision = 'fake_ancestor_sha'
844 calls += [
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000845 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000846 ((['git', 'config', 'branch.master.remote'],), 'origin'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000847 ((['get_or_create_merge_base', 'master',
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200848 'refs/remotes/origin/master'],), ancestor_revision),
849 ]
850
851 # Calls to verify branch point is ancestor
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000852 calls += cls._gerrit_ensure_auth_calls(
853 issue=issue, short_hostname=short_hostname)
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100854
855 if issue:
856 calls += [
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000857 (('GetChangeDetail', '%s-review.googlesource.com' % short_hostname,
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +0000858 'my%2Frepo~123456',
Andrii Shyshkalovc4a73562018-09-25 18:40:17 +0000859 ['DETAILED_ACCOUNTS', 'CURRENT_REVISION', 'CURRENT_COMMIT', 'LABELS']
860 ),
Andrii Shyshkalov3e631422017-02-16 17:46:44 +0100861 {
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100862 'owner': {'email': (other_cl_owner or 'owner@example.com')},
Andrii Shyshkalov3e631422017-02-16 17:46:44 +0100863 'change_id': '123456789',
864 'current_revision': 'sha1_of_current_revision',
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000865 'revisions': {'sha1_of_current_revision': {
Andrii Shyshkalov3e631422017-02-16 17:46:44 +0100866 'commit': {'message': fetched_description},
867 }},
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100868 'status': fetched_status or 'NEW',
Andrii Shyshkalov3e631422017-02-16 17:46:44 +0100869 }),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100870 ]
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100871 if fetched_status == 'ABANDONED':
872 calls += [
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000873 (('DieWithError', 'Change https://%s-review.googlesource.com/'
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100874 '123456 has been abandoned, new uploads are not '
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000875 'allowed' % short_hostname), SystemExitMock()),
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100876 ]
877 return calls
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100878 if other_cl_owner:
879 calls += [
880 (('ask_for_data', 'Press Enter to upload, or Ctrl+C to abort'), ''),
881 ]
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100882
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200883 calls += cls._git_sanity_checks(ancestor_revision, 'master',
884 get_remote_branch=False)
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100885 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200886 ((['git', 'rev-parse', '--show-cdup'],), ''),
887 ((['git', 'rev-parse', 'HEAD'],), '12345'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000888
Aaron Gable7817f022017-12-12 09:43:17 -0800889 ((['git', '-c', 'core.quotePath=false', 'diff', '--name-status',
890 '--no-renames', '-r', ancestor_revision + '...', '.'],),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200891 'M\t.gitignore\n'),
892 ((['git', 'config', 'branch.master.gerritpatchset'],), CERR1),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100893 ]
894
895 if not issue:
896 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200897 ((['git', 'log', '--pretty=format:%s%n%n%b',
898 ancestor_revision + '...'],),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000899 'foo'),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100900 ]
901
902 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200903 ((['git', 'config', 'user.email'],), 'me@example.com'),
Edward Lemur2c48f242019-06-04 16:14:09 +0000904 (('time.time',), 1000,),
905 (('time.time',), 3000,),
906 (('add_repeated', 'sub_commands', {
907 'execution_time': 2000,
908 'command': 'presubmit',
909 'exit_code': 0
910 }), None,),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200911 ((['git', 'diff', '--no-ext-diff', '--stat', '-l100000', '-C50'] +
912 ([custom_cl_base] if custom_cl_base else
913 [ancestor_revision, 'HEAD']),),
914 '+dat'),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100915 ]
916 return calls
ukai@chromium.orge8077812012-02-03 03:41:46 +0000917
tandrii@chromium.org1e67bb72016-02-11 12:15:49 +0000918 @classmethod
919 def _gerrit_upload_calls(cls, description, reviewers, squash,
tandriia60502f2016-06-20 02:01:53 -0700920 squash_mode='default',
tandrii@chromium.org10625002016-03-04 20:03:47 +0000921 expected_upstream_ref='origin/refs/heads/master',
Aaron Gablefd238082017-06-07 13:42:34 -0700922 title=None, notify=False,
Andrii Shyshkalove9c78ff2017-02-06 15:53:13 +0100923 post_amend_description=None, issue=None, cc=None,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000924 custom_cl_base=None, tbr=None,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +0000925 short_hostname='chromium',
Edward Lemur1b52d872019-05-09 21:12:12 +0000926 labels=None, change_id=None, original_title=None,
927 final_description=None, gitcookies_exists=True):
tandrii@chromium.org10625002016-03-04 20:03:47 +0000928 if post_amend_description is None:
929 post_amend_description = description
bradnelsond975b302016-10-23 12:20:23 -0700930 cc = cc or []
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200931 # Determined in `_gerrit_base_calls`.
932 determined_ancestor_revision = custom_cl_base or 'fake_ancestor_sha'
933
934 calls = []
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000935
tandriia60502f2016-06-20 02:01:53 -0700936 if squash_mode == 'default':
937 calls.extend([
938 ((['git', 'config', '--bool', 'gerrit.override-squash-uploads'],), ''),
939 ((['git', 'config', '--bool', 'gerrit.squash-uploads'],), ''),
940 ])
941 elif squash_mode in ('override_squash', 'override_nosquash'):
942 calls.extend([
943 ((['git', 'config', '--bool', 'gerrit.override-squash-uploads'],),
944 'true' if squash_mode == 'override_squash' else 'false'),
945 ])
946 else:
947 assert squash_mode in ('squash', 'nosquash')
948
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000949 # If issue is given, then description is fetched from Gerrit instead.
950 if issue is None:
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000951 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200952 ((['git', 'log', '--pretty=format:%s\n\n%b',
953 ((custom_cl_base + '..') if custom_cl_base else
954 'fake_ancestor_sha..HEAD')],),
955 description),
956 ]
Aaron Gableb56ad332017-01-06 15:24:31 -0800957 if squash:
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +0000958 title = 'Initial_upload'
Aaron Gableb56ad332017-01-06 15:24:31 -0800959 else:
960 if not title:
961 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200962 ((['git', 'show', '-s', '--format=%s', 'HEAD'],), ''),
963 (('ask_for_data', 'Title for patchset []: '), 'User input'),
Aaron Gableb56ad332017-01-06 15:24:31 -0800964 ]
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +0000965 title = 'User_input'
tandrii@chromium.org57d86542016-03-04 16:11:32 +0000966 if not git_footers.get_footer_change_id(description) and not squash:
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +0000967 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200968 (('DownloadGerritHook', False), ''),
969 # Amending of commit message to get the Change-Id.
970 ((['git', 'log', '--pretty=format:%s\n\n%b',
971 determined_ancestor_revision + '..HEAD'],),
972 description),
973 ((['git', 'commit', '--amend', '-m', description],), ''),
974 ((['git', 'log', '--pretty=format:%s\n\n%b',
975 determined_ancestor_revision + '..HEAD'],),
976 post_amend_description)
977 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000978 if squash:
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000979 if not issue:
980 # Prompting to edit description on first upload.
981 calls += [
Jonas Termansend0f79112019-03-22 15:28:26 +0000982 ((['git', 'config', 'rietveld.bug-prefix'],), ''),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200983 ((['git', 'config', 'core.editor'],), ''),
984 ((['RunEditor'],), description),
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000985 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000986 ref_to_push = 'abcdef0123456789'
987 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200988 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
989 ((['git', 'config', 'branch.master.remote'],), 'origin'),
990 ]
991
992 if custom_cl_base is None:
993 calls += [
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000994 ((['get_or_create_merge_base', 'master',
995 'refs/remotes/origin/master'],),
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000996 'origin/master'),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200997 ]
998 parent = 'origin/master'
999 else:
1000 calls += [
1001 ((['git', 'merge-base', '--is-ancestor', custom_cl_base,
1002 'refs/remotes/origin/master'],),
1003 callError(1)), # Means not ancenstor.
1004 (('ask_for_data',
1005 'Do you take responsibility for cleaning up potential mess '
1006 'resulting from proceeding with upload? Press Enter to upload, '
1007 'or Ctrl+C to abort'), ''),
1008 ]
1009 parent = custom_cl_base
1010
1011 calls += [
1012 ((['git', 'rev-parse', 'HEAD:'],), # `HEAD:` means HEAD's tree hash.
1013 '0123456789abcdef'),
1014 ((['git', 'commit-tree', '0123456789abcdef', '-p', parent,
Aaron Gable9a03ae02017-11-03 11:31:07 -07001015 '-F', '/tmp/named'],),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001016 ref_to_push),
1017 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001018 else:
1019 ref_to_push = 'HEAD'
1020
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001021 calls += [
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +00001022 (('SaveDescriptionBackup',), None),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001023 ((['git', 'rev-list',
1024 (custom_cl_base if custom_cl_base else expected_upstream_ref) + '..' +
1025 ref_to_push],),
1026 '1hashPerLine\n'),
1027 ]
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001028
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001029 metrics_arguments = []
1030
Aaron Gableafd52772017-06-27 16:40:10 -07001031 if notify:
Aaron Gable844cf292017-06-28 11:32:59 -07001032 ref_suffix = '%ready,notify=ALL'
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001033 metrics_arguments += ['ready', 'notify=ALL']
Aaron Gable844cf292017-06-28 11:32:59 -07001034 else:
Jamie Madill276da0b2018-04-27 14:41:20 -04001035 if not issue and squash:
Aaron Gable844cf292017-06-28 11:32:59 -07001036 ref_suffix = '%wip'
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001037 metrics_arguments.append('wip')
Aaron Gable844cf292017-06-28 11:32:59 -07001038 else:
1039 ref_suffix = '%notify=NONE'
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001040 metrics_arguments.append('notify=NONE')
Aaron Gable9b713dd2016-12-14 16:04:21 -08001041
Aaron Gable70f4e242017-06-26 10:45:59 -07001042 if title:
Aaron Gableafd52772017-06-27 16:40:10 -07001043 ref_suffix += ',m=' + title
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001044 metrics_arguments.append('m')
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001045
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00001046 calls += [
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +00001047 ((['git', 'config', 'rietveld.cc'],), ''),
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00001048 ]
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001049 if short_hostname == 'chromium':
1050 # All reviwers and ccs get into ref_suffix.
1051 for r in sorted(reviewers):
1052 ref_suffix += ',r=%s' % r
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001053 metrics_arguments.append('r')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001054 for c in sorted(['chromium-reviews+test-more-cc@chromium.org',
1055 'joe@example.com'] + cc):
1056 ref_suffix += ',cc=%s' % c
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001057 metrics_arguments.append('cc')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001058 reviewers, cc = [], []
1059 else:
1060 # TODO(crbug/877717): remove this case.
1061 calls += [
1062 (('ValidAccounts', '%s-review.googlesource.com' % short_hostname,
1063 sorted(reviewers) + ['joe@example.com',
1064 'chromium-reviews+test-more-cc@chromium.org'] + cc),
1065 {
1066 e: {'email': e}
1067 for e in (reviewers + ['joe@example.com'] + cc)
1068 })
1069 ]
1070 for r in sorted(reviewers):
1071 if r != 'bad-account-or-email':
1072 ref_suffix += ',r=%s' % r
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001073 metrics_arguments.append('r')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001074 reviewers.remove(r)
1075 for c in sorted(['joe@example.com'] + cc):
1076 ref_suffix += ',cc=%s' % c
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001077 metrics_arguments.append('cc')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001078 if c in cc:
1079 cc.remove(c)
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00001080
Edward Lemur687ca902018-12-05 02:30:30 +00001081 for k, v in sorted((labels or {}).items()):
1082 ref_suffix += ',l=%s+%d' % (k, v)
1083 metrics_arguments.append('l=%s+%d' % (k, v))
1084
1085 if tbr:
1086 calls += [
1087 (('GetCodeReviewTbrScore',
1088 '%s-review.googlesource.com' % short_hostname,
1089 'my/repo'),
1090 2,),
1091 ]
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001092
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001093 calls += [
1094 (('time.time',), 1000,),
1095 ((['git', 'push',
1096 'https://%s.googlesource.com/my/repo' % short_hostname,
1097 ref_to_push + ':refs/for/refs/heads/master' + ref_suffix],),
1098 (('remote:\n'
1099 'remote: Processing changes: (\)\n'
1100 'remote: Processing changes: (|)\n'
1101 'remote: Processing changes: (/)\n'
1102 'remote: Processing changes: (-)\n'
1103 'remote: Processing changes: new: 1 (/)\n'
1104 'remote: Processing changes: new: 1, done\n'
1105 'remote:\n'
1106 'remote: New Changes:\n'
1107 'remote: https://%s-review.googlesource.com/#/c/my/repo/+/123456'
1108 ' XXX\n'
1109 'remote:\n'
1110 'To https://%s.googlesource.com/my/repo\n'
1111 ' * [new branch] hhhh -> refs/for/refs/heads/master\n'
1112 ) % (short_hostname, short_hostname)),),
1113 (('time.time',), 2000,),
1114 (('add_repeated',
1115 'sub_commands',
1116 {
1117 'execution_time': 1000,
1118 'command': 'git push',
1119 'exit_code': 0,
1120 'arguments': sorted(metrics_arguments),
1121 }),
1122 None,),
1123 ]
1124
Edward Lemur1b52d872019-05-09 21:12:12 +00001125 final_description = final_description or post_amend_description.strip()
1126 original_title = original_title or title or '<untitled>'
1127 # Trace-related calls
1128 calls += [
1129 # Write a description with context for the current trace.
1130 ((['FileWrite', 'TRACES_DIR/20170316T200041.000000-README',
Edward Lemur75391d42019-05-14 23:35:56 +00001131 'Thu Mar 16 20:00:41 2017\n'
1132 '%(short_hostname)s-review.googlesource.com\n'
1133 '%(change_id)s\n'
1134 '%(title)s\n'
1135 '%(description)s\n'
1136 '1000\n'
1137 '0\n'
1138 '%(trace_name)s' % {
Edward Lemur1b52d872019-05-09 21:12:12 +00001139 'short_hostname': short_hostname,
1140 'change_id': change_id,
1141 'description': final_description,
1142 'title': original_title,
Edward Lemur75391d42019-05-14 23:35:56 +00001143 'trace_name': 'TRACES_DIR/20170316T200041.000000',
Edward Lemur1b52d872019-05-09 21:12:12 +00001144 }],),
1145 None,
1146 ),
1147 # Read traces and shorten git hashes.
1148 ((['os.path.isfile', 'TEMP_DIR/trace-packet'],),
1149 True,
1150 ),
1151 ((['FileRead', 'TEMP_DIR/trace-packet'],),
1152 ('git-hash: 0123456789012345678901234567890123456789\n'
1153 'git-hash: abcdeabcdeabcdeabcdeabcdeabcdeabcdeabcde\n'),
1154 ),
1155 ((['FileWrite', 'TEMP_DIR/trace-packet',
1156 'git-hash: 012345\n'
1157 'git-hash: abcdea\n'],),
1158 None,
1159 ),
1160 # Make zip file for the git traces.
1161 ((['make_archive', 'TRACES_DIR/20170316T200041.000000-traces', 'zip',
1162 'TEMP_DIR'],),
1163 None,
1164 ),
1165 # Collect git config and gitcookies.
1166 ((['git', 'config', '-l'],),
1167 'git-config-output',
1168 ),
1169 ((['FileWrite', 'TEMP_DIR/git-config', 'git-config-output'],),
1170 None,
1171 ),
1172 ((['os.path.isfile', '~/.gitcookies'],),
1173 gitcookies_exists,
1174 ),
1175 ]
1176 if gitcookies_exists:
1177 calls += [
1178 ((['FileRead', '~/.gitcookies'],),
1179 'gitcookies 1/SECRET',
1180 ),
1181 ((['FileWrite', 'TEMP_DIR/gitcookies', 'gitcookies REDACTED'],),
1182 None,
1183 ),
1184 ]
1185 calls += [
1186 # Make zip file for the git config and gitcookies.
1187 ((['make_archive', 'TRACES_DIR/20170316T200041.000000-git-info', 'zip',
1188 'TEMP_DIR'],),
1189 None,
1190 ),
1191 ]
1192
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001193 if squash:
1194 calls += [
tandrii33a46ff2016-08-23 05:53:40 -07001195 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
tandrii5d48c322016-08-18 16:19:37 -07001196 ''),
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001197 ((['git', 'config', 'branch.master.gerritserver',
tandrii5d48c322016-08-18 16:19:37 -07001198 'https://chromium-review.googlesource.com'],), ''),
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001199 ((['git', 'config', 'branch.master.gerritsquashhash',
1200 'abcdef0123456789'],), ''),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001201 ]
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001202 # TODO(crbug/877717): this should never be used.
1203 if squash and short_hostname != 'chromium':
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001204 calls += [
1205 (('AddReviewers',
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00001206 'chromium-review.googlesource.com', 'my%2Frepo~123456',
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001207 sorted(reviewers),
Andrii Shyshkalov2f727912018-10-15 17:02:33 +00001208 cc + ['chromium-reviews+test-more-cc@chromium.org'],
1209 notify),
1210 ''),
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001211 ]
tandrii@chromium.org1e67bb72016-02-11 12:15:49 +00001212 calls += cls._git_post_upload_calls()
ukai@chromium.orge8077812012-02-03 03:41:46 +00001213 return calls
1214
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001215 def _run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001216 self,
1217 upload_args,
1218 description,
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00001219 reviewers=None,
tandriia60502f2016-06-20 02:01:53 -07001220 squash=True,
1221 squash_mode=None,
tandrii@chromium.org10625002016-03-04 20:03:47 +00001222 expected_upstream_ref='origin/refs/heads/master',
Aaron Gable9b713dd2016-12-14 16:04:21 -08001223 title=None,
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001224 notify=False,
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001225 post_amend_description=None,
bradnelsond975b302016-10-23 12:20:23 -07001226 issue=None,
Andrii Shyshkalove9c78ff2017-02-06 15:53:13 +01001227 cc=None,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001228 fetched_status=None,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001229 other_cl_owner=None,
Aaron Gablefd238082017-06-07 13:42:34 -07001230 custom_cl_base=None,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001231 tbr=None,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001232 short_hostname='chromium',
Edward Lemur1b52d872019-05-09 21:12:12 +00001233 labels=None,
1234 change_id=None,
1235 original_title=None,
1236 final_description=None,
1237 gitcookies_exists=True):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001238 """Generic gerrit upload test framework."""
tandriia60502f2016-06-20 02:01:53 -07001239 if squash_mode is None:
1240 if '--no-squash' in upload_args:
1241 squash_mode = 'nosquash'
1242 elif '--squash' in upload_args:
1243 squash_mode = 'squash'
1244 else:
1245 squash_mode = 'default'
1246
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00001247 reviewers = reviewers or []
bradnelsond975b302016-10-23 12:20:23 -07001248 cc = cc or []
tandrii@chromium.org28253532016-04-14 13:46:56 +00001249 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
tandrii16e0b4e2016-06-07 10:34:28 -07001250 self.mock(git_cl.gerrit_util, 'CookiesAuthenticator',
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001251 CookiesAuthenticatorMockFactory(
1252 same_auth=('git-owner.example.com', '', 'pass')))
tandrii16e0b4e2016-06-07 10:34:28 -07001253 self.mock(git_cl._GerritChangelistImpl, '_GerritCommitMsgHookCheck',
1254 lambda _, offer_removal: None)
tandriia60502f2016-06-20 02:01:53 -07001255 self.mock(git_cl.gclient_utils, 'RunEditor',
1256 lambda *_, **__: self._mocked_call(['RunEditor']))
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001257 self.mock(git_cl, 'DownloadGerritHook', lambda force: self._mocked_call(
1258 'DownloadGerritHook', force))
Edward Lemur1b52d872019-05-09 21:12:12 +00001259 self.mock(git_cl.gclient_utils, 'FileRead',
1260 lambda path: self._mocked_call(['FileRead', path]))
1261 self.mock(git_cl.gclient_utils, 'FileWrite',
1262 lambda path, contents: self._mocked_call(
1263 ['FileWrite', path, contents]))
1264 self.mock(git_cl, 'datetime_now',
1265 lambda: datetime.datetime(2017, 3, 16, 20, 0, 41, 0))
1266 self.mock(git_cl.tempfile, 'mkdtemp', lambda: 'TEMP_DIR')
1267 self.mock(git_cl, 'TRACES_DIR', 'TRACES_DIR')
Edward Lemur75391d42019-05-14 23:35:56 +00001268 self.mock(git_cl, 'TRACES_README_FORMAT',
1269 '%(now)s\n'
1270 '%(gerrit_host)s\n'
1271 '%(change_id)s\n'
1272 '%(title)s\n'
1273 '%(description)s\n'
1274 '%(execution_time)s\n'
1275 '%(exit_code)s\n'
1276 '%(trace_name)s')
Edward Lemur1b52d872019-05-09 21:12:12 +00001277 self.mock(git_cl.shutil, 'make_archive',
1278 lambda *args: self._mocked_call(['make_archive'] + list(args)))
1279 self.mock(os.path, 'isfile',
1280 lambda path: self._mocked_call(['os.path.isfile', path]))
tandriia60502f2016-06-20 02:01:53 -07001281
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001282 self.calls = self._gerrit_base_calls(
1283 issue=issue,
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001284 fetched_description=description,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001285 fetched_status=fetched_status,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001286 other_cl_owner=other_cl_owner,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001287 custom_cl_base=custom_cl_base,
1288 short_hostname=short_hostname)
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001289 if fetched_status != 'ABANDONED':
Aaron Gable9a03ae02017-11-03 11:31:07 -07001290 self.mock(tempfile, 'NamedTemporaryFile', MakeNamedTemporaryFileMock(
1291 expected_content=description))
1292 self.mock(os, 'remove', lambda _: True)
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001293 self.calls += self._gerrit_upload_calls(
1294 description, reviewers, squash,
1295 squash_mode=squash_mode,
1296 expected_upstream_ref=expected_upstream_ref,
Aaron Gablefd238082017-06-07 13:42:34 -07001297 title=title, notify=notify,
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001298 post_amend_description=post_amend_description,
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00001299 issue=issue, cc=cc,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001300 custom_cl_base=custom_cl_base, tbr=tbr,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001301 short_hostname=short_hostname,
Edward Lemur1b52d872019-05-09 21:12:12 +00001302 labels=labels,
1303 change_id=change_id,
1304 original_title=original_title,
1305 final_description=final_description,
1306 gitcookies_exists=gitcookies_exists)
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +00001307 # Uncomment when debugging.
Raul Tambre80ee78e2019-05-06 22:41:05 +00001308 # print('\n'.join(map(lambda x: '%2i: %s' % x, enumerate(self.calls))))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001309 git_cl.main(['upload'] + upload_args)
1310
Edward Lemur1b52d872019-05-09 21:12:12 +00001311 def test_gerrit_upload_traces_no_gitcookies(self):
1312 self._run_gerrit_upload_test(
1313 ['--no-squash'],
1314 'desc\n\nBUG=\n',
1315 [],
1316 squash=False,
1317 post_amend_description='desc\n\nBUG=\n\nChange-Id: Ixxx',
1318 change_id='Ixxx',
1319 gitcookies_exists=False)
1320
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001321 def test_gerrit_upload_without_change_id(self):
tandriia60502f2016-06-20 02:01:53 -07001322 self._run_gerrit_upload_test(
1323 ['--no-squash'],
1324 'desc\n\nBUG=\n',
1325 [],
1326 squash=False,
Edward Lemur1b52d872019-05-09 21:12:12 +00001327 post_amend_description='desc\n\nBUG=\n\nChange-Id: Ixxx',
1328 change_id='Ixxx')
tandriia60502f2016-06-20 02:01:53 -07001329
1330 def test_gerrit_upload_without_change_id_override_nosquash(self):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001331 self._run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001332 [],
jamesr@chromium.org35d1a842012-07-27 00:20:43 +00001333 'desc\n\nBUG=\n',
tandrii@chromium.org10625002016-03-04 20:03:47 +00001334 [],
tandriia60502f2016-06-20 02:01:53 -07001335 squash=False,
1336 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001337 post_amend_description='desc\n\nBUG=\n\nChange-Id: Ixxx',
1338 change_id='Ixxx')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001339
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001340 def test_gerrit_no_reviewer(self):
1341 self._run_gerrit_upload_test(
1342 [],
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +00001343 'desc\n\nBUG=\n\nChange-Id: I123456789\n',
tandriia60502f2016-06-20 02:01:53 -07001344 [],
1345 squash=False,
Edward Lemur1b52d872019-05-09 21:12:12 +00001346 squash_mode='override_nosquash',
1347 change_id='I123456789')
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001348
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001349 def test_gerrit_no_reviewer_non_chromium_host(self):
1350 # TODO(crbug/877717): remove this test case.
1351 self._run_gerrit_upload_test(
1352 [],
1353 'desc\n\nBUG=\n\nChange-Id: I123456789\n',
1354 [],
1355 squash=False,
1356 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001357 short_hostname='other',
1358 change_id='I123456789')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001359
Nick Carter8692b182017-11-06 16:30:38 -08001360 def test_gerrit_patchset_title_special_chars(self):
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001361 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
1362 self._run_gerrit_upload_test(
Nick Carter8692b182017-11-06 16:30:38 -08001363 ['-f', '-t', 'We\'ll escape ^_ ^ special chars...@{u}'],
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001364 'desc\n\nBUG=\n\nChange-Id: I123456789',
1365 squash=False,
1366 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001367 title='We%27ll_escape_%5E%5F_%5E_special_chars%2E%2E%2E%40%7Bu%7D',
1368 change_id='I123456789',
1369 original_title='We\'ll escape ^_ ^ special chars...@{u}')
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001370
ukai@chromium.orge8077812012-02-03 03:41:46 +00001371 def test_gerrit_reviewers_cmd_line(self):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001372 self._run_gerrit_upload_test(
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001373 ['-r', 'foo@example.com', '--send-mail'],
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +00001374 'desc\n\nBUG=\n\nChange-Id: I123456789',
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001375 ['foo@example.com'],
tandriia60502f2016-06-20 02:01:53 -07001376 squash=False,
1377 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001378 notify=True,
1379 change_id='I123456789',
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001380 final_description=(
1381 'desc\n\nBUG=\nR=foo@example.com\n\nChange-Id: I123456789'))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001382
1383 def test_gerrit_reviewer_multiple(self):
Edward Lemur687ca902018-12-05 02:30:30 +00001384 self.mock(git_cl.gerrit_util, 'GetCodeReviewTbrScore',
1385 lambda *a: self._mocked_call('GetCodeReviewTbrScore', *a))
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001386 self._run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001387 [],
bradnelsond975b302016-10-23 12:20:23 -07001388 'desc\nTBR=reviewer@example.com\nBUG=\nR=another@example.com\n'
1389 'CC=more@example.com,people@example.com\n\n'
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +09001390 'Change-Id: 123456789',
tandriia60502f2016-06-20 02:01:53 -07001391 ['reviewer@example.com', 'another@example.com'],
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +09001392 expected_upstream_ref='origin/master',
Aaron Gablefd238082017-06-07 13:42:34 -07001393 cc=['more@example.com', 'people@example.com'],
Edward Lemur687ca902018-12-05 02:30:30 +00001394 tbr='reviewer@example.com',
Edward Lemur1b52d872019-05-09 21:12:12 +00001395 labels={'Code-Review': 2},
1396 change_id='123456789',
1397 original_title='Initial upload')
tandriia60502f2016-06-20 02:01:53 -07001398
1399 def test_gerrit_upload_squash_first_is_default(self):
tandriia60502f2016-06-20 02:01:53 -07001400 self._run_gerrit_upload_test(
1401 [],
1402 'desc\nBUG=\n\nChange-Id: 123456789',
1403 [],
Edward Lemur1b52d872019-05-09 21:12:12 +00001404 expected_upstream_ref='origin/master',
1405 change_id='123456789',
1406 original_title='Initial upload')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001407
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001408 def test_gerrit_upload_squash_first(self):
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001409 self._run_gerrit_upload_test(
1410 ['--squash'],
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001411 'desc\nBUG=\n\nChange-Id: 123456789',
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001412 [],
luqui@chromium.org609f3952015-05-04 22:47:04 +00001413 squash=True,
Edward Lemur1b52d872019-05-09 21:12:12 +00001414 expected_upstream_ref='origin/master',
1415 change_id='123456789',
1416 original_title='Initial upload')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001417
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001418 def test_gerrit_upload_squash_first_with_labels(self):
1419 self._run_gerrit_upload_test(
1420 ['--squash', '--cq-dry-run', '--enable-auto-submit'],
1421 'desc\nBUG=\n\nChange-Id: 123456789',
1422 [],
1423 squash=True,
1424 expected_upstream_ref='origin/master',
Edward Lemur1b52d872019-05-09 21:12:12 +00001425 labels={'Commit-Queue': 1, 'Auto-Submit': 1},
1426 change_id='123456789',
1427 original_title='Initial upload')
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001428
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001429 def test_gerrit_upload_squash_first_against_rev(self):
1430 custom_cl_base = 'custom_cl_base_rev_or_branch'
1431 self._run_gerrit_upload_test(
1432 ['--squash', custom_cl_base],
1433 'desc\nBUG=\n\nChange-Id: 123456789',
1434 [],
1435 squash=True,
1436 expected_upstream_ref='origin/master',
Edward Lemur1b52d872019-05-09 21:12:12 +00001437 custom_cl_base=custom_cl_base,
1438 change_id='123456789',
1439 original_title='Initial upload')
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001440 self.assertIn(
1441 'If you proceed with upload, more than 1 CL may be created by Gerrit',
1442 sys.stdout.getvalue())
1443
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001444 def test_gerrit_upload_squash_reupload(self):
1445 description = 'desc\nBUG=\n\nChange-Id: 123456789'
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001446 self._run_gerrit_upload_test(
1447 ['--squash'],
1448 description,
1449 [],
1450 squash=True,
1451 expected_upstream_ref='origin/master',
Edward Lemur1b52d872019-05-09 21:12:12 +00001452 issue=123456,
1453 change_id='123456789',
1454 original_title='User input')
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001455
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001456 def test_gerrit_upload_squash_reupload_to_abandoned(self):
1457 self.mock(git_cl, 'DieWithError',
1458 lambda msg, change=None: self._mocked_call('DieWithError', msg))
1459 description = 'desc\nBUG=\n\nChange-Id: 123456789'
1460 with self.assertRaises(SystemExitMock):
1461 self._run_gerrit_upload_test(
1462 ['--squash'],
1463 description,
1464 [],
1465 squash=True,
1466 expected_upstream_ref='origin/master',
1467 issue=123456,
Edward Lemur1b52d872019-05-09 21:12:12 +00001468 fetched_status='ABANDONED',
1469 change_id='123456789')
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001470
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001471 def test_gerrit_upload_squash_reupload_to_not_owned(self):
1472 self.mock(git_cl.gerrit_util, 'GetAccountDetails',
1473 lambda *_, **__: {'email': 'yet-another@example.com'})
1474 description = 'desc\nBUG=\n\nChange-Id: 123456789'
1475 self._run_gerrit_upload_test(
1476 ['--squash'],
1477 description,
1478 [],
1479 squash=True,
1480 expected_upstream_ref='origin/master',
1481 issue=123456,
Edward Lemur1b52d872019-05-09 21:12:12 +00001482 other_cl_owner='other@example.com',
1483 change_id='123456789',
1484 original_title='User input')
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001485 self.assertIn(
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001486 'WARNING: Change 123456 is owned by other@example.com, but you '
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001487 'authenticate to Gerrit as yet-another@example.com.\n'
1488 'Uploading may fail due to lack of permissions',
1489 git_cl.sys.stdout.getvalue())
1490
rmistry@google.com2dd99862015-06-22 12:22:18 +00001491 def test_upload_branch_deps(self):
tandrii@chromium.org28253532016-04-14 13:46:56 +00001492 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
rmistry@google.com2dd99862015-06-22 12:22:18 +00001493 def mock_run_git(*args, **_kwargs):
1494 if args[0] == ['for-each-ref',
1495 '--format=%(refname:short) %(upstream:short)',
1496 'refs/heads']:
1497 # Create a local branch dependency tree that looks like this:
1498 # test1 -> test2 -> test3 -> test4 -> test5
1499 # -> test3.1
1500 # test6 -> test0
1501 branch_deps = [
1502 'test2 test1', # test1 -> test2
1503 'test3 test2', # test2 -> test3
1504 'test3.1 test2', # test2 -> test3.1
1505 'test4 test3', # test3 -> test4
1506 'test5 test4', # test4 -> test5
1507 'test6 test0', # test0 -> test6
1508 'test7', # test7
1509 ]
1510 return '\n'.join(branch_deps)
1511 self.mock(git_cl, 'RunGit', mock_run_git)
1512
1513 class RecordCalls:
1514 times_called = 0
1515 record_calls = RecordCalls()
1516 def mock_CMDupload(*args, **_kwargs):
1517 record_calls.times_called += 1
1518 return 0
1519 self.mock(git_cl, 'CMDupload', mock_CMDupload)
1520
1521 self.calls = [
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01001522 (('ask_for_data', 'This command will checkout all dependent branches '
1523 'and run "git cl upload". Press Enter to continue, '
1524 'or Ctrl+C to abort'), ''),
1525 ]
rmistry@google.com2dd99862015-06-22 12:22:18 +00001526
1527 class MockChangelist():
1528 def __init__(self):
1529 pass
1530 def GetBranch(self):
1531 return 'test1'
1532 def GetIssue(self):
1533 return '123'
1534 def GetPatchset(self):
1535 return '1001'
tandrii@chromium.org4c72b082016-03-31 22:26:35 +00001536 def IsGerrit(self):
1537 return False
rmistry@google.com2dd99862015-06-22 12:22:18 +00001538
1539 ret = git_cl.upload_branch_deps(MockChangelist(), [])
1540 # CMDupload should have been called 5 times because of 5 dependent branches.
1541 self.assertEquals(5, record_calls.times_called)
1542 self.assertEquals(0, ret)
1543
tandrii@chromium.org65874e12016-03-04 12:03:02 +00001544 def test_gerrit_change_id(self):
1545 self.calls = [
1546 ((['git', 'write-tree'], ),
1547 'hashtree'),
1548 ((['git', 'rev-parse', 'HEAD~0'], ),
1549 'branch-parent'),
1550 ((['git', 'var', 'GIT_AUTHOR_IDENT'], ),
1551 'A B <a@b.org> 1456848326 +0100'),
1552 ((['git', 'var', 'GIT_COMMITTER_IDENT'], ),
1553 'C D <c@d.org> 1456858326 +0100'),
1554 ((['git', 'hash-object', '-t', 'commit', '--stdin'], ),
1555 'hashchange'),
1556 ]
1557 change_id = git_cl.GenerateGerritChangeId('line1\nline2\n')
1558 self.assertEqual(change_id, 'Ihashchange')
1559
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00001560 def test_desecription_append_footer(self):
1561 for init_desc, footer_line, expected_desc in [
1562 # Use unique desc first lines for easy test failure identification.
1563 ('foo', 'R=one', 'foo\n\nR=one'),
1564 ('foo\n\nR=one', 'BUG=', 'foo\n\nR=one\nBUG='),
1565 ('foo\n\nR=one', 'Change-Id: Ixx', 'foo\n\nR=one\n\nChange-Id: Ixx'),
1566 ('foo\n\nChange-Id: Ixx', 'R=one', 'foo\n\nR=one\n\nChange-Id: Ixx'),
1567 ('foo\n\nR=one\n\nChange-Id: Ixx', 'TBR=two',
1568 'foo\n\nR=one\nTBR=two\n\nChange-Id: Ixx'),
1569 ('foo\n\nR=one\n\nChange-Id: Ixx', 'Foo-Bar: baz',
1570 'foo\n\nR=one\n\nChange-Id: Ixx\nFoo-Bar: baz'),
1571 ('foo\n\nChange-Id: Ixx', 'Foo-Bak: baz',
1572 'foo\n\nChange-Id: Ixx\nFoo-Bak: baz'),
1573 ('foo', 'Change-Id: Ixx', 'foo\n\nChange-Id: Ixx'),
1574 ]:
1575 desc = git_cl.ChangeDescription(init_desc)
1576 desc.append_footer(footer_line)
1577 self.assertEqual(desc.description, expected_desc)
1578
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001579 def test_update_reviewers(self):
1580 data = [
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001581 ('foo', [], [],
1582 'foo'),
1583 ('foo\nR=xx', [], [],
1584 'foo\nR=xx'),
1585 ('foo\nTBR=xx', [], [],
1586 'foo\nTBR=xx'),
1587 ('foo', ['a@c'], [],
1588 'foo\n\nR=a@c'),
1589 ('foo\nR=xx', ['a@c'], [],
1590 'foo\n\nR=a@c, xx'),
1591 ('foo\nTBR=xx', ['a@c'], [],
1592 'foo\n\nR=a@c\nTBR=xx'),
1593 ('foo\nTBR=xx\nR=yy', ['a@c'], [],
1594 'foo\n\nR=a@c, yy\nTBR=xx'),
1595 ('foo\nBUG=', ['a@c'], [],
1596 'foo\nBUG=\nR=a@c'),
1597 ('foo\nR=xx\nTBR=yy\nR=bar', ['a@c'], [],
1598 'foo\n\nR=a@c, bar, xx\nTBR=yy'),
1599 ('foo', ['a@c', 'b@c'], [],
1600 'foo\n\nR=a@c, b@c'),
1601 ('foo\nBar\n\nR=\nBUG=', ['c@c'], [],
1602 'foo\nBar\n\nR=c@c\nBUG='),
1603 ('foo\nBar\n\nR=\nBUG=\nR=', ['c@c'], [],
1604 'foo\nBar\n\nR=c@c\nBUG='),
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001605 # Same as the line before, but full of whitespaces.
1606 (
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001607 'foo\nBar\n\n R = \n BUG = \n R = ', ['c@c'], [],
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001608 'foo\nBar\n\nR=c@c\n BUG =',
1609 ),
1610 # Whitespaces aren't interpreted as new lines.
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001611 ('foo BUG=allo R=joe ', ['c@c'], [],
1612 'foo BUG=allo R=joe\n\nR=c@c'),
1613 # Redundant TBRs get promoted to Rs
1614 ('foo\n\nR=a@c\nTBR=t@c', ['b@c', 'a@c'], ['a@c', 't@c'],
1615 'foo\n\nR=a@c, b@c\nTBR=t@c'),
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001616 ]
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001617 expected = [i[-1] for i in data]
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001618 actual = []
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001619 for orig, reviewers, tbrs, _expected in data:
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001620 obj = git_cl.ChangeDescription(orig)
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001621 obj.update_reviewers(reviewers, tbrs)
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001622 actual.append(obj.description)
1623 self.assertEqual(expected, actual)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001624
Nodir Turakulov23b82142017-11-16 11:04:25 -08001625 def test_get_hash_tags(self):
1626 cases = [
1627 ('', []),
1628 ('a', []),
1629 ('[a]', ['a']),
1630 ('[aa]', ['aa']),
1631 ('[a ]', ['a']),
1632 ('[a- ]', ['a']),
1633 ('[a- b]', ['a-b']),
1634 ('[a--b]', ['a-b']),
1635 ('[a', []),
1636 ('[a]x', ['a']),
1637 ('[aa]x', ['aa']),
1638 ('[a b]', ['a-b']),
1639 ('[a b]', ['a-b']),
1640 ('[a__b]', ['a-b']),
1641 ('[a] x', ['a']),
1642 ('[a][b]', ['a', 'b']),
1643 ('[a] [b]', ['a', 'b']),
1644 ('[a][b]x', ['a', 'b']),
1645 ('[a][b] x', ['a', 'b']),
1646 ('[a]\n[b]', ['a']),
1647 ('[a\nb]', []),
1648 ('[a][', ['a']),
1649 ('Revert "[a] feature"', ['a']),
1650 ('Reland "[a] feature"', ['a']),
1651 ('Revert: [a] feature', ['a']),
1652 ('Reland: [a] feature', ['a']),
1653 ('Revert "Reland: [a] feature"', ['a']),
1654 ('Foo: feature', ['foo']),
1655 ('Foo Bar: feature', ['foo-bar']),
1656 ('Revert "Foo bar: feature"', ['foo-bar']),
1657 ('Reland "Foo bar: feature"', ['foo-bar']),
1658 ]
1659 for desc, expected in cases:
1660 change_desc = git_cl.ChangeDescription(desc)
1661 actual = change_desc.get_hash_tags()
1662 self.assertEqual(
1663 actual,
1664 expected,
1665 'GetHashTags(%r) == %r, expected %r' % (desc, actual, expected))
1666
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001667 self.assertEqual(None, git_cl.GetTargetRef('origin', None, 'master'))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001668 self.assertEqual(None, git_cl.GetTargetRef(None,
1669 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001670 'master'))
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001671
wittman@chromium.org455dc922015-01-26 20:15:50 +00001672 # Check default target refs for branches.
1673 self.assertEqual('refs/heads/master',
1674 git_cl.GetTargetRef('origin', 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001675 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001676 self.assertEqual('refs/heads/master',
1677 git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkgr',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001678 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001679 self.assertEqual('refs/heads/master',
1680 git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkcr',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001681 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001682 self.assertEqual('refs/branch-heads/123',
1683 git_cl.GetTargetRef('origin',
1684 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001685 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001686 self.assertEqual('refs/diff/test',
1687 git_cl.GetTargetRef('origin',
1688 'refs/remotes/origin/refs/diff/test',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001689 None))
rmistry@google.comc68112d2015-03-03 12:48:06 +00001690 self.assertEqual('refs/heads/chrome/m42',
1691 git_cl.GetTargetRef('origin',
1692 'refs/remotes/origin/chrome/m42',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001693 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001694
1695 # Check target refs for user-specified target branch.
1696 for branch in ('branch-heads/123', 'remotes/branch-heads/123',
1697 'refs/remotes/branch-heads/123'):
1698 self.assertEqual('refs/branch-heads/123',
1699 git_cl.GetTargetRef('origin',
1700 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001701 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001702 for branch in ('origin/master', 'remotes/origin/master',
1703 'refs/remotes/origin/master'):
1704 self.assertEqual('refs/heads/master',
1705 git_cl.GetTargetRef('origin',
1706 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001707 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001708 for branch in ('master', 'heads/master', 'refs/heads/master'):
1709 self.assertEqual('refs/heads/master',
1710 git_cl.GetTargetRef('origin',
1711 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001712 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001713
wychen@chromium.orga872e752015-04-28 23:42:18 +00001714 def test_patch_when_dirty(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001715 # Patch when local tree is dirty.
wychen@chromium.orga872e752015-04-28 23:42:18 +00001716 self.mock(git_common, 'is_dirty_git_tree', lambda x: True)
1717 self.assertNotEqual(git_cl.main(['patch', '123456']), 0)
1718
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001719 @staticmethod
1720 def _get_gerrit_codereview_server_calls(branch, value=None,
1721 git_short_host='host',
Aaron Gable697a91b2018-01-19 15:20:15 -08001722 detect_branch=True,
1723 detect_server=True):
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001724 """Returns calls executed by _GerritChangelistImpl.GetCodereviewServer.
1725
1726 If value is given, branch.<BRANCH>.gerritcodereview is already set.
1727 """
1728 calls = []
1729 if detect_branch:
1730 calls.append(((['git', 'symbolic-ref', 'HEAD'],), branch))
Aaron Gable697a91b2018-01-19 15:20:15 -08001731 if detect_server:
1732 calls.append(((['git', 'config', 'branch.' + branch + '.gerritserver'],),
1733 CERR1 if value is None else value))
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001734 if value is None:
1735 calls += [
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001736 ((['git', 'config', 'branch.' + branch + '.merge'],),
1737 'refs/heads' + branch),
1738 ((['git', 'config', 'branch.' + branch + '.remote'],),
1739 'origin'),
1740 ((['git', 'config', 'remote.origin.url'],),
1741 'https://%s.googlesource.com/my/repo' % git_short_host),
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001742 ]
1743 return calls
1744
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001745 def _patch_common(self, force_codereview=False,
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001746 new_branch=False, git_short_host='host',
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001747 detect_gerrit_server=False,
1748 actual_codereview=None,
1749 codereview_in_url=False):
tandrii@chromium.org28253532016-04-14 13:46:56 +00001750 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
wychen@chromium.orga872e752015-04-28 23:42:18 +00001751 self.mock(git_cl, 'IsGitVersionAtLeast', lambda *args: True)
1752
tandriidf09a462016-08-18 16:23:55 -07001753 if new_branch:
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001754 self.calls = [((['git', 'new-branch', 'master'],), '')]
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001755
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001756 if codereview_in_url and actual_codereview == 'rietveld':
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001757 self.calls += [
1758 ((['git', 'rev-parse', '--show-cdup'],), ''),
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001759 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001760 ]
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001761
1762 if not force_codereview and not codereview_in_url:
1763 # These calls detect codereview to use.
1764 self.calls += [
1765 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001766 ((['git', 'config', 'branch.master.gerritissue'],), CERR1),
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001767 ]
1768 if detect_gerrit_server:
1769 self.calls += self._get_gerrit_codereview_server_calls(
1770 'master', git_short_host=git_short_host,
1771 detect_branch=not new_branch and force_codereview)
1772 actual_codereview = 'gerrit'
1773
1774 if actual_codereview == 'gerrit':
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001775 self.calls += [
1776 (('GetChangeDetail', git_short_host + '-review.googlesource.com',
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001777 'my%2Frepo~123456', ['ALL_REVISIONS', 'CURRENT_COMMIT']),
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001778 {
1779 'current_revision': '7777777777',
1780 'revisions': {
1781 '1111111111': {
1782 '_number': 1,
1783 'fetch': {'http': {
1784 'url': 'https://%s.googlesource.com/my/repo' % git_short_host,
1785 'ref': 'refs/changes/56/123456/1',
1786 }},
1787 },
1788 '7777777777': {
1789 '_number': 7,
1790 'fetch': {'http': {
1791 'url': 'https://%s.googlesource.com/my/repo' % git_short_host,
1792 'ref': 'refs/changes/56/123456/7',
1793 }},
1794 },
1795 },
1796 }),
1797 ]
wychen@chromium.orga872e752015-04-28 23:42:18 +00001798
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001799 def test_patch_gerrit_default(self):
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001800 self._patch_common(git_short_host='chromium', detect_gerrit_server=True)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001801 self.calls += [
1802 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
1803 'refs/changes/56/123456/7'],), ''),
Aaron Gable62619a32017-06-16 08:22:09 -07001804 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001805 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
Aaron Gable697a91b2018-01-19 15:20:15 -08001806 ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001807 ((['git', 'config', 'branch.master.gerritserver',
1808 'https://chromium-review.googlesource.com'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001809 ((['git', 'config', 'branch.master.gerritpatchset', '7'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001810 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1811 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1812 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001813 ]
1814 self.assertEqual(git_cl.main(['patch', '123456']), 0)
1815
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001816 def test_patch_gerrit_new_branch(self):
1817 self._patch_common(
1818 git_short_host='chromium', detect_gerrit_server=True, new_branch=True)
1819 self.calls += [
1820 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
1821 'refs/changes/56/123456/7'],), ''),
1822 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
1823 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
1824 ''),
1825 ((['git', 'config', 'branch.master.gerritserver',
1826 'https://chromium-review.googlesource.com'],), ''),
1827 ((['git', 'config', 'branch.master.gerritpatchset', '7'],), ''),
1828 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1829 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1830 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
1831 ]
1832 self.assertEqual(git_cl.main(['patch', '-b', 'master', '123456']), 0)
1833
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001834 def test_patch_gerrit_force(self):
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001835 self._patch_common(
1836 force_codereview=True, git_short_host='host', detect_gerrit_server=True)
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001837 self.calls += [
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001838 ((['git', 'fetch', 'https://host.googlesource.com/my/repo',
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001839 'refs/changes/56/123456/7'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001840 ((['git', 'reset', '--hard', 'FETCH_HEAD'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001841 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
tandrii5d48c322016-08-18 16:19:37 -07001842 ''),
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001843 ((['git', 'config', 'branch.master.gerritserver',
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001844 'https://host-review.googlesource.com'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001845 ((['git', 'config', 'branch.master.gerritpatchset', '7'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001846 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1847 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1848 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001849 ]
Aaron Gable62619a32017-06-16 08:22:09 -07001850 self.assertEqual(git_cl.main(['patch', '--gerrit', '123456', '--force']), 0)
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001851
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001852 def test_patch_gerrit_guess_by_url(self):
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001853 self.calls += self._get_gerrit_codereview_server_calls(
1854 'master', git_short_host='else', detect_server=False)
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001855 self._patch_common(
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001856 actual_codereview='gerrit', git_short_host='else',
1857 codereview_in_url=True, detect_gerrit_server=False)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001858 self.calls += [
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001859 ((['git', 'fetch', 'https://else.googlesource.com/my/repo',
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001860 'refs/changes/56/123456/1'],), ''),
Aaron Gable62619a32017-06-16 08:22:09 -07001861 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001862 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
tandrii5d48c322016-08-18 16:19:37 -07001863 ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001864 ((['git', 'config', 'branch.master.gerritserver',
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001865 'https://else-review.googlesource.com'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001866 ((['git', 'config', 'branch.master.gerritpatchset', '1'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001867 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1868 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1869 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001870 ]
1871 self.assertEqual(git_cl.main(
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001872 ['patch', 'https://else-review.googlesource.com/#/c/123456/1']), 0)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001873
Aaron Gable697a91b2018-01-19 15:20:15 -08001874 def test_patch_gerrit_guess_by_url_with_repo(self):
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001875 self.calls += self._get_gerrit_codereview_server_calls(
1876 'master', git_short_host='else', detect_server=False)
Aaron Gable697a91b2018-01-19 15:20:15 -08001877 self._patch_common(
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001878 actual_codereview='gerrit', git_short_host='else',
1879 codereview_in_url=True, detect_gerrit_server=False)
Aaron Gable697a91b2018-01-19 15:20:15 -08001880 self.calls += [
1881 ((['git', 'fetch', 'https://else.googlesource.com/my/repo',
1882 'refs/changes/56/123456/1'],), ''),
1883 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
1884 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
1885 ''),
1886 ((['git', 'config', 'branch.master.gerritserver',
1887 'https://else-review.googlesource.com'],), ''),
1888 ((['git', 'config', 'branch.master.gerritpatchset', '1'],), ''),
1889 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1890 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1891 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
1892 ]
1893 self.assertEqual(git_cl.main(
1894 ['patch', 'https://else-review.googlesource.com/c/my/repo/+/123456/1']),
1895 0)
1896
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001897 def test_patch_gerrit_conflict(self):
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001898 self._patch_common(detect_gerrit_server=True, git_short_host='chromium')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001899 self.calls += [
1900 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001901 'refs/changes/56/123456/7'],), ''),
tandrii5d48c322016-08-18 16:19:37 -07001902 ((['git', 'cherry-pick', 'FETCH_HEAD'],), CERR1),
1903 ((['DieWithError', 'Command "git cherry-pick FETCH_HEAD" failed.\n'],),
1904 SystemExitMock()),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001905 ]
1906 with self.assertRaises(SystemExitMock):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001907 git_cl.main(['patch', '123456'])
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001908
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001909 def test_patch_gerrit_not_exists(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001910
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01001911 def notExists(_issue, *_, **kwargs):
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01001912 raise git_cl.gerrit_util.GerritError(404, '')
1913 self.mock(git_cl.gerrit_util, 'GetChangeDetail', notExists)
1914
tandriic2405f52016-10-10 08:13:15 -07001915 self.calls = [
1916 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
tandriic2405f52016-10-10 08:13:15 -07001917 ((['git', 'config', 'branch.master.gerritissue'],), CERR1),
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001918 ((['git', 'config', 'branch.master.gerritserver'],), CERR1),
1919 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
1920 ((['git', 'config', 'branch.master.remote'],), 'origin'),
1921 ((['git', 'config', 'remote.origin.url'],),
1922 'https://chromium.googlesource.com/my/repo'),
1923 ((['DieWithError',
1924 'change 123456 at https://chromium-review.googlesource.com does not '
1925 'exist or you have no access to it'],), SystemExitMock()),
tandriic2405f52016-10-10 08:13:15 -07001926 ]
1927 with self.assertRaises(SystemExitMock):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001928 self.assertEqual(1, git_cl.main(['patch', '123456']))
tandriic2405f52016-10-10 08:13:15 -07001929
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001930 def _checkout_calls(self):
1931 return [
1932 ((['git', 'config', '--local', '--get-regexp',
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001933 'branch\\..*\\.gerritissue'], ),
1934 ('branch.ger-branch.gerritissue 123456\n'
1935 'branch.gbranch654.gerritissue 654321\n')),
1936 ]
1937
1938 def test_checkout_gerrit(self):
1939 """Tests git cl checkout <issue>."""
1940 self.calls = self._checkout_calls()
1941 self.calls += [((['git', 'checkout', 'ger-branch'], ), '')]
1942 self.assertEqual(0, git_cl.main(['checkout', '123456']))
1943
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001944 def test_checkout_not_found(self):
1945 """Tests git cl checkout <issue>."""
tandrii@chromium.org28253532016-04-14 13:46:56 +00001946 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001947 self.calls = self._checkout_calls()
1948 self.assertEqual(1, git_cl.main(['checkout', '99999']))
1949
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001950 def test_checkout_no_branch_issues(self):
1951 """Tests git cl checkout <issue>."""
tandrii@chromium.org28253532016-04-14 13:46:56 +00001952 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001953 self.calls = [
1954 ((['git', 'config', '--local', '--get-regexp',
tandrii5d48c322016-08-18 16:19:37 -07001955 'branch\\..*\\.gerritissue'], ), CERR1),
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001956 ]
1957 self.assertEqual(1, git_cl.main(['checkout', '99999']))
1958
tandrii@chromium.org28253532016-04-14 13:46:56 +00001959 def _test_gerrit_ensure_authenticated_common(self, auth,
1960 skip_auth_check=False):
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001961 self.mock(git_cl.gerrit_util, 'CookiesAuthenticator',
1962 CookiesAuthenticatorMockFactory(hosts_with_creds=auth))
1963 self.mock(git_cl, 'DieWithError',
Christopher Lamf732cd52017-01-24 12:40:11 +11001964 lambda msg, change=None: self._mocked_call(['DieWithError', msg]))
tandrii@chromium.org28253532016-04-14 13:46:56 +00001965 self.calls = self._gerrit_ensure_auth_calls(skip_auth_check=skip_auth_check)
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001966 cl = git_cl.Changelist(codereview='gerrit')
tandrii@chromium.org28253532016-04-14 13:46:56 +00001967 cl.branch = 'master'
1968 cl.branchref = 'refs/heads/master'
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001969 cl.lookedup_issue = True
1970 return cl
1971
1972 def test_gerrit_ensure_authenticated_missing(self):
1973 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001974 'chromium.googlesource.com': ('git-is.ok', '', 'but gerrit is missing'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001975 })
1976 self.calls.append(
1977 ((['DieWithError',
1978 'Credentials for the following hosts are required:\n'
1979 ' chromium-review.googlesource.com\n'
1980 'These are read from ~/.gitcookies (or legacy ~/.netrc)\n'
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01001981 'You can (re)generate your credentials by visiting '
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001982 'https://chromium-review.googlesource.com/new-password'],), ''),)
1983 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1984
1985 def test_gerrit_ensure_authenticated_conflict(self):
tandrii@chromium.org28253532016-04-14 13:46:56 +00001986 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001987 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001988 'chromium.googlesource.com':
1989 ('git-one.example.com', None, 'secret1'),
1990 'chromium-review.googlesource.com':
1991 ('git-other.example.com', None, 'secret2'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001992 })
1993 self.calls.append(
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01001994 (('ask_for_data', 'If you know what you are doing '
1995 'press Enter to continue, or Ctrl+C to abort'), ''))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001996 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1997
1998 def test_gerrit_ensure_authenticated_ok(self):
1999 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01002000 'chromium.googlesource.com':
2001 ('git-same.example.com', None, 'secret'),
2002 'chromium-review.googlesource.com':
2003 ('git-same.example.com', None, 'secret'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002004 })
2005 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2006
tandrii@chromium.org28253532016-04-14 13:46:56 +00002007 def test_gerrit_ensure_authenticated_skipped(self):
2008 cl = self._test_gerrit_ensure_authenticated_common(
2009 auth={}, skip_auth_check=True)
2010 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2011
Eric Boren2fb63102018-10-05 13:05:03 +00002012 def test_gerrit_ensure_authenticated_bearer_token(self):
2013 cl = self._test_gerrit_ensure_authenticated_common(auth={
2014 'chromium.googlesource.com':
2015 ('', None, 'secret'),
2016 'chromium-review.googlesource.com':
2017 ('', None, 'secret'),
2018 })
2019 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2020 header = gerrit_util.CookiesAuthenticator().get_auth_header(
2021 'chromium.googlesource.com')
2022 self.assertTrue('Bearer' in header)
2023
Daniel Chengcf6269b2019-05-18 01:02:12 +00002024 def test_gerrit_ensure_authenticated_non_https(self):
2025 self.calls = [
2026 ((['git', 'config', '--bool',
2027 'gerrit.skip-ensure-authenticated'],), CERR1),
2028 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
2029 ((['git', 'config', 'branch.master.remote'],), 'origin'),
2030 ((['git', 'config', 'remote.origin.url'],), 'custom-scheme://repo'),
2031 ]
2032 self.mock(git_cl.gerrit_util, 'CookiesAuthenticator',
2033 CookiesAuthenticatorMockFactory(hosts_with_creds={}))
2034 cl = git_cl.Changelist(codereview='gerrit')
2035 cl.branch = 'master'
2036 cl.branchref = 'refs/heads/master'
2037 cl.lookedup_issue = True
2038 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2039
Andrii Shyshkalov828701b2016-12-09 10:46:47 +01002040 def _cmd_set_commit_gerrit_common(self, vote, notify=None):
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002041 self.mock(git_cl.gerrit_util, 'SetReview',
Andrii Shyshkalov828701b2016-12-09 10:46:47 +01002042 lambda h, i, labels, notify=None:
2043 self._mocked_call(['SetReview', h, i, labels, notify]))
2044
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002045 self.calls = [
2046 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii33a46ff2016-08-23 05:53:40 -07002047 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002048 ((['git', 'config', 'branch.feature.gerritserver'],),
2049 'https://chromium-review.googlesource.com'),
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002050 ((['git', 'config', 'branch.feature.merge'],), 'refs/heads/master'),
2051 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
2052 ((['git', 'config', 'remote.origin.url'],),
2053 'https://chromium.googlesource.com/infra/infra.git'),
2054 ((['SetReview', 'chromium-review.googlesource.com',
2055 'infra%2Finfra~123',
Andrii Shyshkalov828701b2016-12-09 10:46:47 +01002056 {'Commit-Queue': vote}, notify],), ''),
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002057 ]
tandriid9e5ce52016-07-13 02:32:59 -07002058
2059 def test_cmd_set_commit_gerrit_clear(self):
2060 self._cmd_set_commit_gerrit_common(0)
2061 self.assertEqual(0, git_cl.main(['set-commit', '-c']))
2062
2063 def test_cmd_set_commit_gerrit_dry(self):
Aaron Gable75e78722017-06-09 10:40:16 -07002064 self._cmd_set_commit_gerrit_common(1, notify=False)
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002065 self.assertEqual(0, git_cl.main(['set-commit', '-d']))
2066
tandriid9e5ce52016-07-13 02:32:59 -07002067 def test_cmd_set_commit_gerrit(self):
2068 self._cmd_set_commit_gerrit_common(2)
2069 self.assertEqual(0, git_cl.main(['set-commit']))
2070
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002071 def test_description_display(self):
2072 out = StringIO.StringIO()
2073 self.mock(git_cl.sys, 'stdout', out)
2074
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002075 self.mock(git_cl, 'Changelist', ChangelistMock)
2076 ChangelistMock.desc = 'foo\n'
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002077
2078 self.assertEqual(0, git_cl.main(['description', '-d']))
2079 self.assertEqual('foo\n', out.getvalue())
2080
iannucci3c972b92016-08-17 13:24:10 -07002081 def test_StatusFieldOverrideIssueMissingArgs(self):
2082 out = StringIO.StringIO()
2083 self.mock(git_cl.sys, 'stderr', out)
2084
2085 try:
2086 self.assertEqual(git_cl.main(['status', '--issue', '1']), 0)
2087 except SystemExit as ex:
2088 self.assertEqual(ex.code, 2)
iannuccie53c9352016-08-17 14:40:40 -07002089 self.assertRegexpMatches(out.getvalue(), r'--issue must be specified')
iannucci3c972b92016-08-17 13:24:10 -07002090
2091 out = StringIO.StringIO()
2092 self.mock(git_cl.sys, 'stderr', out)
2093
2094 try:
Andrii Shyshkalovfeec80e2018-10-16 01:00:47 +00002095 self.assertEqual(git_cl.main(['status', '--issue', '1', '--gerrit']), 0)
iannucci3c972b92016-08-17 13:24:10 -07002096 except SystemExit as ex:
2097 self.assertEqual(ex.code, 2)
iannuccie53c9352016-08-17 14:40:40 -07002098 self.assertRegexpMatches(out.getvalue(), r'--field must be specified')
iannucci3c972b92016-08-17 13:24:10 -07002099
2100 def test_StatusFieldOverrideIssue(self):
2101 out = StringIO.StringIO()
2102 self.mock(git_cl.sys, 'stdout', out)
2103
2104 def assertIssue(cl_self, *_args):
2105 self.assertEquals(cl_self.issue, 1)
2106 return 'foobar'
2107
2108 self.mock(git_cl.Changelist, 'GetDescription', assertIssue)
iannuccie53c9352016-08-17 14:40:40 -07002109 self.assertEqual(
Andrii Shyshkalovfeec80e2018-10-16 01:00:47 +00002110 git_cl.main(['status', '--issue', '1', '--gerrit', '--field', 'desc']),
iannuccie53c9352016-08-17 14:40:40 -07002111 0)
iannucci3c972b92016-08-17 13:24:10 -07002112 self.assertEqual(out.getvalue(), 'foobar\n')
2113
iannuccie53c9352016-08-17 14:40:40 -07002114 def test_SetCloseOverrideIssue(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002115
iannuccie53c9352016-08-17 14:40:40 -07002116 def assertIssue(cl_self, *_args):
2117 self.assertEquals(cl_self.issue, 1)
2118 return 'foobar'
2119
2120 self.mock(git_cl.Changelist, 'GetDescription', assertIssue)
2121 self.mock(git_cl.Changelist, 'CloseIssue', lambda *_: None)
iannuccie53c9352016-08-17 14:40:40 -07002122 self.assertEqual(
Andrii Shyshkalovfeec80e2018-10-16 01:00:47 +00002123 git_cl.main(['set-close', '--issue', '1', '--gerrit']), 0)
iannuccie53c9352016-08-17 14:40:40 -07002124
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00002125 def test_description(self):
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002126 out = StringIO.StringIO()
2127 self.mock(git_cl.sys, 'stdout', out)
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01002128 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002129 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
2130 ((['git', 'config', 'branch.feature.merge'],), 'feature'),
2131 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
2132 ((['git', 'config', 'remote.origin.url'],),
2133 'https://chromium.googlesource.com/my/repo'),
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00002134 (('GetChangeDetail', 'chromium-review.googlesource.com',
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002135 'my%2Frepo~123123', ['CURRENT_REVISION', 'CURRENT_COMMIT']),
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01002136 {
2137 'current_revision': 'sha1',
2138 'revisions': {'sha1': {
2139 'commit': {'message': 'foobar'},
2140 }},
2141 }),
2142 ]
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002143 self.assertEqual(0, git_cl.main([
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00002144 'description',
2145 'https://chromium-review.googlesource.com/c/my/repo/+/123123',
2146 '-d']))
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002147 self.assertEqual('foobar\n', out.getvalue())
2148
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002149 def test_description_set_raw(self):
2150 out = StringIO.StringIO()
2151 self.mock(git_cl.sys, 'stdout', out)
2152
2153 self.mock(git_cl, 'Changelist', ChangelistMock)
2154 self.mock(git_cl.sys, 'stdin', StringIO.StringIO('hihi'))
2155
2156 self.assertEqual(0, git_cl.main(['description', '-n', 'hihi']))
2157 self.assertEqual('hihi', ChangelistMock.desc)
2158
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002159 def test_description_appends_bug_line(self):
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002160 current_desc = 'Some.\n\nChange-Id: xxx'
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002161
2162 def RunEditor(desc, _, **kwargs):
2163 self.assertEquals(
2164 '# Enter a description of the change.\n'
2165 '# This will be displayed on the codereview site.\n'
2166 '# The first line will also be used as the subject of the review.\n'
2167 '#--------------------This line is 72 characters long'
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002168 '--------------------\n'
Aaron Gable3a16ed12017-03-23 10:51:55 -07002169 'Some.\n\nChange-Id: xxx\nBug: ',
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002170 desc)
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002171 # Simulate user changing something.
Aaron Gable3a16ed12017-03-23 10:51:55 -07002172 return 'Some.\n\nChange-Id: xxx\nBug: 123'
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002173
dsansomee2d6fd92016-09-08 00:10:47 -07002174 def UpdateDescriptionRemote(_, desc, force=False):
Aaron Gable3a16ed12017-03-23 10:51:55 -07002175 self.assertEquals(desc, 'Some.\n\nChange-Id: xxx\nBug: 123')
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002176
2177 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2178 self.mock(git_cl.Changelist, 'GetDescription',
2179 lambda *args: current_desc)
2180 self.mock(git_cl._GerritChangelistImpl, 'UpdateDescriptionRemote',
2181 UpdateDescriptionRemote)
2182 self.mock(git_cl.gclient_utils, 'RunEditor', RunEditor)
2183
2184 self.calls = [
2185 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii33a46ff2016-08-23 05:53:40 -07002186 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
tandrii5d48c322016-08-18 16:19:37 -07002187 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
2188 ((['git', 'config', 'rietveld.bug-prefix'],), CERR1),
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002189 ((['git', 'config', 'core.editor'],), 'vi'),
2190 ]
2191 self.assertEqual(0, git_cl.main(['description', '--gerrit']))
2192
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002193 def test_description_set_stdin(self):
2194 out = StringIO.StringIO()
2195 self.mock(git_cl.sys, 'stdout', out)
2196
2197 self.mock(git_cl, 'Changelist', ChangelistMock)
2198 self.mock(git_cl.sys, 'stdin', StringIO.StringIO('hi \r\n\t there\n\nman'))
2199
2200 self.assertEqual(0, git_cl.main(['description', '-n', '-']))
2201 self.assertEqual('hi\n\t there\n\nman', ChangelistMock.desc)
2202
kmarshall3bff56b2016-06-06 18:31:47 -07002203 def test_archive(self):
tandrii1c67da62016-06-10 07:35:53 -07002204 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2205
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002206 self.calls = [
2207 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2208 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
2209 ((['git', 'config', 'branch.master.gerritissue'],), '456'),
2210 ((['git', 'config', 'branch.foo.gerritissue'],), CERR1),
2211 ((['git', 'config', 'branch.bar.gerritissue'],), '789'),
2212 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2213 ((['git', 'tag', 'git-cl-archived-456-foo', 'foo'],), ''),
2214 ((['git', 'branch', '-D', 'foo'],), ''),
2215 ]
kmarshall3bff56b2016-06-06 18:31:47 -07002216
kmarshall3bff56b2016-06-06 18:31:47 -07002217 self.mock(git_cl, 'get_cl_statuses',
2218 lambda branches, fine_grained, max_processes:
kmarshall9249e012016-08-23 12:02:16 -07002219 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2220 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
2221 (MockChangelistWithBranchAndIssue('bar', 789), 'open')])
kmarshall3bff56b2016-06-06 18:31:47 -07002222
2223 self.assertEqual(0, git_cl.main(['archive', '-f']))
2224
2225 def test_archive_current_branch_fails(self):
tandrii1c67da62016-06-10 07:35:53 -07002226 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002227 self.calls = [
2228 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2229 'refs/heads/master'),
2230 ((['git', 'config', 'branch.master.gerritissue'],), '1'),
2231 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2232 ]
kmarshall3bff56b2016-06-06 18:31:47 -07002233
kmarshall9249e012016-08-23 12:02:16 -07002234 self.mock(git_cl, 'get_cl_statuses',
2235 lambda branches, fine_grained, max_processes:
2236 [(MockChangelistWithBranchAndIssue('master', 1), 'closed')])
2237
2238 self.assertEqual(1, git_cl.main(['archive', '-f']))
2239
2240 def test_archive_dry_run(self):
2241 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2242
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002243 self.calls = [
2244 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2245 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
2246 ((['git', 'config', 'branch.master.gerritissue'],), '456'),
2247 ((['git', 'config', 'branch.foo.gerritissue'],), CERR1),
2248 ((['git', 'config', 'branch.bar.gerritissue'],), '789'),
2249 ((['git', 'symbolic-ref', 'HEAD'],), 'master')
2250 ]
kmarshall3bff56b2016-06-06 18:31:47 -07002251
2252 self.mock(git_cl, 'get_cl_statuses',
2253 lambda branches, fine_grained, max_processes:
kmarshall9249e012016-08-23 12:02:16 -07002254 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2255 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
2256 (MockChangelistWithBranchAndIssue('bar', 789), 'open')])
kmarshall3bff56b2016-06-06 18:31:47 -07002257
kmarshall9249e012016-08-23 12:02:16 -07002258 self.assertEqual(0, git_cl.main(['archive', '-f', '--dry-run']))
2259
2260 def test_archive_no_tags(self):
2261 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2262
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002263 self.calls = [
2264 ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2265 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
2266 ((['git', 'config', 'branch.master.gerritissue'],), '1'),
2267 ((['git', 'config', 'branch.foo.gerritissue'],), '456'),
2268 ((['git', 'config', 'branch.bar.gerritissue'],), CERR1),
2269 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2270 ((['git', 'branch', '-D', 'foo'],), '')
2271 ]
kmarshall9249e012016-08-23 12:02:16 -07002272
2273 self.mock(git_cl, 'get_cl_statuses',
2274 lambda branches, fine_grained, max_processes:
2275 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2276 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
2277 (MockChangelistWithBranchAndIssue('bar', 789), 'open')])
2278
2279 self.assertEqual(0, git_cl.main(['archive', '-f', '--notags']))
kmarshall3bff56b2016-06-06 18:31:47 -07002280
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002281 def test_cmd_issue_erase_existing(self):
2282 out = StringIO.StringIO()
2283 self.mock(git_cl.sys, 'stdout', out)
2284 self.calls = [
2285 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii33a46ff2016-08-23 05:53:40 -07002286 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002287 # Let this command raise exception (retcode=1) - it should be ignored.
2288 ((['git', 'config', '--unset', 'branch.feature.last-upload-hash'],),
tandrii5d48c322016-08-18 16:19:37 -07002289 CERR1),
2290 ((['git', 'config', '--unset', 'branch.feature.gerritissue'],), ''),
2291 ((['git', 'config', '--unset', 'branch.feature.gerritpatchset'],), ''),
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002292 ((['git', 'config', '--unset', 'branch.feature.gerritserver'],), ''),
2293 ((['git', 'config', '--unset', 'branch.feature.gerritsquashhash'],),
2294 ''),
Aaron Gableca01e2c2017-07-19 11:16:02 -07002295 ((['git', 'log', '-1', '--format=%B'],), 'This is a description'),
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002296 ]
2297 self.assertEqual(0, git_cl.main(['issue', '0']))
2298
Aaron Gable400e9892017-07-12 15:31:21 -07002299 def test_cmd_issue_erase_existing_with_change_id(self):
2300 out = StringIO.StringIO()
2301 self.mock(git_cl.sys, 'stdout', out)
2302 self.mock(git_cl.Changelist, 'GetDescription',
2303 lambda _: 'This is a description\n\nChange-Id: Ideadbeef')
2304 self.calls = [
2305 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
Aaron Gable400e9892017-07-12 15:31:21 -07002306 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
Aaron Gable400e9892017-07-12 15:31:21 -07002307 # Let this command raise exception (retcode=1) - it should be ignored.
2308 ((['git', 'config', '--unset', 'branch.feature.last-upload-hash'],),
2309 CERR1),
2310 ((['git', 'config', '--unset', 'branch.feature.gerritissue'],), ''),
2311 ((['git', 'config', '--unset', 'branch.feature.gerritpatchset'],), ''),
2312 ((['git', 'config', '--unset', 'branch.feature.gerritserver'],), ''),
2313 ((['git', 'config', '--unset', 'branch.feature.gerritsquashhash'],),
2314 ''),
Aaron Gableca01e2c2017-07-19 11:16:02 -07002315 ((['git', 'log', '-1', '--format=%B'],),
2316 'This is a description\n\nChange-Id: Ideadbeef'),
2317 ((['git', 'commit', '--amend', '-m', 'This is a description\n'],), ''),
Aaron Gable400e9892017-07-12 15:31:21 -07002318 ]
2319 self.assertEqual(0, git_cl.main(['issue', '0']))
2320
phajdan.jre328cf92016-08-22 04:12:17 -07002321 def test_cmd_issue_json(self):
2322 out = StringIO.StringIO()
2323 self.mock(git_cl.sys, 'stdout', out)
2324 self.calls = [
2325 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
Andrii Shyshkalova185e2e2018-11-21 00:42:55 +00002326 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
2327 ((['git', 'config', 'branch.feature.gerritserver'],),
2328 'https://chromium-review.googlesource.com'),
phajdan.jre328cf92016-08-22 04:12:17 -07002329 (('write_json', 'output.json',
Andrii Shyshkalova185e2e2018-11-21 00:42:55 +00002330 {'issue': 123,
2331 'issue_url': 'https://chromium-review.googlesource.com/123'}),
phajdan.jre328cf92016-08-22 04:12:17 -07002332 ''),
2333 ]
2334 self.assertEqual(0, git_cl.main(['issue', '--json', 'output.json']))
2335
tandrii8c5a3532016-11-04 07:52:02 -07002336 def test_git_cl_try_default_cq_dry_run_gerrit(self):
2337 self.mock(git_cl.Changelist, 'GetChange',
2338 lambda _, *a: (
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002339 self._mocked_call(['GetChange'] + list(a))))
tandrii8c5a3532016-11-04 07:52:02 -07002340 self.mock(git_cl.presubmit_support, 'DoGetTryMasters',
2341 lambda *_, **__: (
2342 self._mocked_call(['DoGetTryMasters'])))
2343 self.mock(git_cl._GerritChangelistImpl, 'SetCQState',
2344 lambda _, s: self._mocked_call(['SetCQState', s]))
2345
tandrii8c5a3532016-11-04 07:52:02 -07002346 self.calls = [
2347 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii8c5a3532016-11-04 07:52:02 -07002348 ((['git', 'config', 'branch.feature.gerritissue'],), '123456'),
2349 ((['git', 'config', 'branch.feature.gerritserver'],),
2350 'https://chromium-review.googlesource.com'),
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002351 ((['git', 'config', 'branch.feature.merge'],), 'feature'),
2352 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
2353 ((['git', 'config', 'remote.origin.url'],),
2354 'https://chromium.googlesource.com/depot_tools'),
2355 (('GetChangeDetail', 'chromium-review.googlesource.com',
2356 'depot_tools~123456',
Andrii Shyshkaloveadad922017-01-26 09:38:30 +01002357 ['DETAILED_ACCOUNTS', 'ALL_REVISIONS', 'CURRENT_COMMIT']), {
2358 'project': 'depot_tools',
2359 'status': 'OPEN',
2360 'owner': {'email': 'owner@e.mail'},
2361 'revisions': {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002362 'deadbeaf': {
Andrii Shyshkaloveadad922017-01-26 09:38:30 +01002363 '_number': 6,
2364 },
2365 'beeeeeef': {
2366 '_number': 7,
2367 'fetch': {'http': {
2368 'url': 'https://chromium.googlesource.com/depot_tools',
2369 'ref': 'refs/changes/56/123456/7'
2370 }},
2371 },
2372 },
2373 }),
tandrii8c5a3532016-11-04 07:52:02 -07002374 ((['git', 'config', 'branch.feature.merge'],), 'feature'),
2375 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
2376 ((['get_or_create_merge_base', 'feature', 'feature'],),
2377 'fake_ancestor_sha'),
2378 ((['GetChange', 'fake_ancestor_sha', None], ),
2379 git_cl.presubmit_support.GitChange(
2380 '', '', '', '', '', '', '', '')),
2381 ((['git', 'rev-parse', '--show-cdup'],), '../'),
2382 ((['DoGetTryMasters'], ), None),
2383 ((['SetCQState', git_cl._CQState.DRY_RUN], ), None),
2384 ]
2385 out = StringIO.StringIO()
2386 self.mock(git_cl.sys, 'stdout', out)
2387 self.assertEqual(0, git_cl.main(['try']))
2388 self.assertEqual(
2389 out.getvalue(),
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07002390 'Scheduling CQ dry run on: '
tandrii8c5a3532016-11-04 07:52:02 -07002391 'https://chromium-review.googlesource.com/123456\n')
2392
tandrii8c5a3532016-11-04 07:52:02 -07002393 def test_git_cl_try_buildbucket_with_properties_gerrit(self):
2394 self.mock(git_cl.Changelist, 'GetMostRecentPatchset', lambda _: 7)
2395 self.mock(git_cl.uuid, 'uuid4', lambda: 'uuid4')
2396
tandrii8c5a3532016-11-04 07:52:02 -07002397 self.calls = [
2398 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii8c5a3532016-11-04 07:52:02 -07002399 ((['git', 'config', 'branch.feature.gerritissue'],), '123456'),
2400 ((['git', 'config', 'branch.feature.gerritserver'],),
2401 'https://chromium-review.googlesource.com'),
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002402 ((['git', 'config', 'branch.feature.merge'],), 'feature'),
2403 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
2404 ((['git', 'config', 'remote.origin.url'],),
2405 'https://chromium.googlesource.com/depot_tools'),
2406 (('GetChangeDetail', 'chromium-review.googlesource.com',
2407 'depot_tools~123456',
Andrii Shyshkaloveadad922017-01-26 09:38:30 +01002408 ['DETAILED_ACCOUNTS', 'ALL_REVISIONS', 'CURRENT_COMMIT']), {
tandrii8c5a3532016-11-04 07:52:02 -07002409 'project': 'depot_tools',
Andrii Shyshkaloveadad922017-01-26 09:38:30 +01002410 'status': 'OPEN',
2411 'owner': {'email': 'owner@e.mail'},
tandrii8c5a3532016-11-04 07:52:02 -07002412 'revisions': {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002413 'deadbeaf': {
tandrii8c5a3532016-11-04 07:52:02 -07002414 '_number': 6,
2415 },
2416 'beeeeeef': {
2417 '_number': 7,
2418 'fetch': {'http': {
2419 'url': 'https://chromium.googlesource.com/depot_tools',
2420 'ref': 'refs/changes/56/123456/7'
2421 }},
2422 },
2423 },
2424 }),
2425 ]
2426
2427 def _buildbucket_retry(*_, **kw):
2428 # self.maxDiff = 10000
2429 body = json.loads(kw['body'])
2430 self.assertEqual(len(body['builds']), 1)
2431 build = body['builds'][0]
2432 params = json.loads(build.pop('parameters_json'))
2433 self.assertEqual(params, {
2434 u'builder_name': u'win',
2435 u'changes': [{u'author': {u'email': u'owner@e.mail'},
2436 u'revision': None}],
2437 u'properties': {
2438 u'category': u'git_cl_try',
2439 u'key': u'val',
2440 u'json': [{u'a': 1}, None],
tandrii8c5a3532016-11-04 07:52:02 -07002441
2442 u'patch_gerrit_url':
2443 u'https://chromium-review.googlesource.com',
2444 u'patch_issue': 123456,
2445 u'patch_project': u'depot_tools',
2446 u'patch_ref': u'refs/changes/56/123456/7',
2447 u'patch_repository_url':
2448 u'https://chromium.googlesource.com/depot_tools',
2449 u'patch_set': 7,
2450 u'patch_storage': u'gerrit',
2451 }
2452 })
2453 self.assertEqual(build, {
Andrii Shyshkalov03da1502018-10-15 03:42:34 +00002454 u'bucket': u'luci.chromium.try',
tandrii8c5a3532016-11-04 07:52:02 -07002455 u'client_operation_id': u'uuid4',
2456 u'tags': [
2457 u'builder:win',
2458 u'buildset:patch/gerrit/chromium-review.googlesource.com/123456/7',
2459 u'user_agent:git_cl_try',
Andrii Shyshkalov03da1502018-10-15 03:42:34 +00002460 ],
tandrii8c5a3532016-11-04 07:52:02 -07002461 })
2462
2463 self.mock(git_cl, '_buildbucket_retry', _buildbucket_retry)
2464
2465 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2466 self.assertEqual(0, git_cl.main([
Andrii Shyshkalov03da1502018-10-15 03:42:34 +00002467 'try', '-B', 'luci.chromium.try', '-b', 'win',
tandrii8c5a3532016-11-04 07:52:02 -07002468 '-p', 'key=val', '-p', 'json=[{"a":1}, null]']))
2469 self.assertRegexpMatches(
2470 git_cl.sys.stdout.getvalue(),
Andrii Shyshkalov03da1502018-10-15 03:42:34 +00002471 'Tried jobs on:\nBucket: luci.chromium.try')
tandriide281ae2016-10-12 06:02:30 -07002472
tandrii16e0b4e2016-06-07 10:34:28 -07002473 def _common_GerritCommitMsgHookCheck(self):
2474 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2475 self.mock(git_cl.os.path, 'abspath',
2476 lambda path: self._mocked_call(['abspath', path]))
2477 self.mock(git_cl.os.path, 'exists',
2478 lambda path: self._mocked_call(['exists', path]))
2479 self.mock(git_cl.gclient_utils, 'FileRead',
2480 lambda path: self._mocked_call(['FileRead', path]))
2481 self.mock(git_cl.gclient_utils, 'rm_file_or_tree',
2482 lambda path: self._mocked_call(['rm_file_or_tree', path]))
2483 self.calls = [
2484 ((['git', 'rev-parse', '--show-cdup'],), '../'),
2485 ((['abspath', '../'],), '/abs/git_repo_root'),
2486 ]
2487 return git_cl.Changelist(codereview='gerrit', issue=123)
2488
2489 def test_GerritCommitMsgHookCheck_custom_hook(self):
2490 cl = self._common_GerritCommitMsgHookCheck()
2491 self.calls += [
2492 ((['exists', '/abs/git_repo_root/.git/hooks/commit-msg'],), True),
2493 ((['FileRead', '/abs/git_repo_root/.git/hooks/commit-msg'],),
2494 '#!/bin/sh\necho "custom hook"')
2495 ]
2496 cl._codereview_impl._GerritCommitMsgHookCheck(offer_removal=True)
2497
2498 def test_GerritCommitMsgHookCheck_not_exists(self):
2499 cl = self._common_GerritCommitMsgHookCheck()
2500 self.calls += [
2501 ((['exists', '/abs/git_repo_root/.git/hooks/commit-msg'],), False),
2502 ]
2503 cl._codereview_impl._GerritCommitMsgHookCheck(offer_removal=True)
2504
2505 def test_GerritCommitMsgHookCheck(self):
2506 cl = self._common_GerritCommitMsgHookCheck()
2507 self.calls += [
2508 ((['exists', '/abs/git_repo_root/.git/hooks/commit-msg'],), True),
2509 ((['FileRead', '/abs/git_repo_root/.git/hooks/commit-msg'],),
2510 '...\n# From Gerrit Code Review\n...\nadd_ChangeId()\n'),
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002511 (('ask_for_data', 'Do you want to remove it now? [Yes/No]: '), 'Yes'),
tandrii16e0b4e2016-06-07 10:34:28 -07002512 ((['rm_file_or_tree', '/abs/git_repo_root/.git/hooks/commit-msg'],),
2513 ''),
2514 ]
2515 cl._codereview_impl._GerritCommitMsgHookCheck(offer_removal=True)
2516
tandriic4344b52016-08-29 06:04:54 -07002517 def test_GerritCmdLand(self):
2518 self.calls += [
2519 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
2520 ((['git', 'config', 'branch.feature.gerritsquashhash'],),
2521 'deadbeaf'),
2522 ((['git', 'diff', 'deadbeaf'],), ''), # No diff.
2523 ((['git', 'config', 'branch.feature.gerritserver'],),
2524 'chromium-review.googlesource.com'),
2525 ]
2526 cl = git_cl.Changelist(issue=123, codereview='gerrit')
2527 cl._codereview_impl._GetChangeDetail = lambda _: {
2528 'labels': {},
2529 'current_revision': 'deadbeaf',
2530 }
agable32978d92016-11-01 12:55:02 -07002531 cl._codereview_impl._GetChangeCommit = lambda: {
2532 'commit': 'deadbeef',
Aaron Gable02cdbb42016-12-13 16:24:25 -08002533 'web_links': [{'name': 'gitiles',
agable32978d92016-11-01 12:55:02 -07002534 'url': 'https://git.googlesource.com/test/+/deadbeef'}],
2535 }
tandriic4344b52016-08-29 06:04:54 -07002536 cl._codereview_impl.SubmitIssue = lambda wait_for_merge: None
tandrii8da412c2016-09-07 16:01:07 -07002537 out = StringIO.StringIO()
2538 self.mock(sys, 'stdout', out)
Olivier Robin75ee7252018-04-13 10:02:56 +02002539 self.assertEqual(0, cl.CMDLand(force=True,
2540 bypass_hooks=True,
2541 verbose=True,
2542 parallel=False))
tandrii8da412c2016-09-07 16:01:07 -07002543 self.assertRegexpMatches(out.getvalue(), 'Issue.*123 has been submitted')
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002544 self.assertRegexpMatches(out.getvalue(), 'Landed as: .*deadbeef')
tandriic4344b52016-08-29 06:04:54 -07002545
tandrii221ab252016-10-06 08:12:04 -07002546 BUILDBUCKET_BUILDS_MAP = {
Quinten Yearsleya563d722017-12-11 16:36:54 -08002547 '9000': {
2548 'id': '9000',
2549 'bucket': 'master.x.y',
2550 'created_by': 'user:someone@chromium.org',
2551 'created_ts': '147200002222000',
2552 'experimental': False,
2553 'parameters_json': json.dumps({
2554 'builder_name': 'my-bot',
2555 'properties': {'category': 'cq'},
2556 }),
2557 'status': 'STARTED',
2558 'tags': [
2559 'build_address:x.y/my-bot/2',
2560 'builder:my-bot',
2561 'experimental:false',
2562 'user_agent:cq',
2563 ],
2564 'url': 'http://build.cr.org/p/x.y/builders/my-bot/builds/2',
2565 },
2566 '8000': {
2567 'id': '8000',
2568 'bucket': 'master.x.y',
2569 'created_by': 'user:someone@chromium.org',
2570 'created_ts': '147200001111000',
2571 'experimental': False,
2572 'failure_reason': 'BUILD_FAILURE',
2573 'parameters_json': json.dumps({
2574 'builder_name': 'my-bot',
2575 'properties': {'category': 'cq'},
2576 }),
2577 'result_details_json': json.dumps({
2578 'properties': {'buildnumber': 1},
2579 }),
2580 'result': 'FAILURE',
2581 'status': 'COMPLETED',
2582 'tags': [
2583 'build_address:x.y/my-bot/1',
2584 'builder:my-bot',
2585 'experimental:false',
2586 'user_agent:cq',
2587 ],
2588 'url': 'http://build.cr.org/p/x.y/builders/my-bot/builds/1',
2589 },
2590 }
tandrii221ab252016-10-06 08:12:04 -07002591
2592 def test_write_try_results_json(self):
2593 expected_output = [
Quinten Yearsleya563d722017-12-11 16:36:54 -08002594 {
2595 'bucket': 'master.x.y',
2596 'buildbucket_id': '8000',
2597 'builder_name': 'my-bot',
2598 'created_ts': '147200001111000',
2599 'experimental': False,
2600 'failure_reason': 'BUILD_FAILURE',
2601 'result': 'FAILURE',
2602 'status': 'COMPLETED',
2603 'tags': [
2604 'build_address:x.y/my-bot/1',
2605 'builder:my-bot',
2606 'experimental:false',
2607 'user_agent:cq',
2608 ],
2609 'url': 'http://build.cr.org/p/x.y/builders/my-bot/builds/1',
2610 },
2611 {
2612 'bucket': 'master.x.y',
2613 'buildbucket_id': '9000',
2614 'builder_name': 'my-bot',
2615 'created_ts': '147200002222000',
2616 'experimental': False,
2617 'failure_reason': None,
2618 'result': None,
2619 'status': 'STARTED',
2620 'tags': [
2621 'build_address:x.y/my-bot/2',
2622 'builder:my-bot',
2623 'experimental:false',
2624 'user_agent:cq',
2625 ],
2626 'url': 'http://build.cr.org/p/x.y/builders/my-bot/builds/2',
2627 },
tandrii221ab252016-10-06 08:12:04 -07002628 ]
2629 self.calls = [(('write_json', 'output.json', expected_output), '')]
2630 git_cl.write_try_results_json('output.json', self.BUILDBUCKET_BUILDS_MAP)
2631
tandrii45b2a582016-10-11 03:14:16 -07002632 def _setup_fetch_try_jobs(self, most_recent_patchset=20001):
tandrii221ab252016-10-06 08:12:04 -07002633 out = StringIO.StringIO()
2634 self.mock(sys, 'stdout', out)
tandrii45b2a582016-10-11 03:14:16 -07002635 self.mock(git_cl.Changelist, 'GetMostRecentPatchset',
2636 lambda *args: most_recent_patchset)
tandrii221ab252016-10-06 08:12:04 -07002637 self.mock(git_cl.auth, 'get_authenticator_for_host', lambda host, _cfg:
2638 self._mocked_call(['get_authenticator_for_host', host]))
2639 self.mock(git_cl, '_buildbucket_retry', lambda *_, **__:
2640 self._mocked_call(['_buildbucket_retry']))
tandrii45b2a582016-10-11 03:14:16 -07002641
tandrii45b2a582016-10-11 03:14:16 -07002642 def _setup_fetch_try_jobs_gerrit(self, *request_results):
2643 self._setup_fetch_try_jobs(most_recent_patchset=13)
2644 self.calls += [
2645 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii45b2a582016-10-11 03:14:16 -07002646 ((['git', 'config', 'branch.feature.gerritissue'],), '1'),
Ravi Mistryfda50ca2016-11-14 10:19:18 -05002647 # TODO(tandrii): Uncomment the below if we decide to support checking
2648 # patchsets for Gerrit.
tandrii45b2a582016-10-11 03:14:16 -07002649 # Simulate that Gerrit has more patchsets than local.
Ravi Mistryfda50ca2016-11-14 10:19:18 -05002650 # ((['git', 'config', 'branch.feature.gerritpatchset'],), '12'),
tandrii45b2a582016-10-11 03:14:16 -07002651 ((['git', 'config', 'branch.feature.gerritserver'],),
2652 'https://x-review.googlesource.com'),
2653 ((['get_authenticator_for_host', 'x-review.googlesource.com'],),
2654 AuthenticatorMock()),
2655 ] + [((['_buildbucket_retry'],), r) for r in request_results]
2656
2657 def test_fetch_try_jobs_none_gerrit(self):
2658 self._setup_fetch_try_jobs_gerrit({})
2659 self.assertEqual(0, git_cl.main(['try-results']))
Ravi Mistryfda50ca2016-11-14 10:19:18 -05002660 # TODO(tandrii): Uncomment the below if we decide to support checking
2661 # patchsets for Gerrit.
2662 # self.assertRegexpMatches(
2663 # sys.stdout.getvalue(),
2664 # r'Warning: Codereview server has newer patchsets \(13\)')
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002665 self.assertRegexpMatches(sys.stdout.getvalue(), 'No tryjobs')
tandrii45b2a582016-10-11 03:14:16 -07002666
2667 def test_fetch_try_jobs_some_gerrit(self):
2668 self._setup_fetch_try_jobs_gerrit({
2669 'builds': self.BUILDBUCKET_BUILDS_MAP.values(),
2670 })
Ravi Mistryfda50ca2016-11-14 10:19:18 -05002671 # TODO(tandrii): Uncomment the below if we decide to support checking
2672 # patchsets for Gerrit.
2673 # self.calls.remove(
2674 # ((['git', 'config', 'branch.feature.gerritpatchset'],), '12'))
tandrii45b2a582016-10-11 03:14:16 -07002675 self.assertEqual(0, git_cl.main(['try-results', '--patchset', '5']))
2676
2677 # ... and doesn't result in warning.
2678 self.assertNotRegexpMatches(sys.stdout.getvalue(), 'Warning')
2679 self.assertRegexpMatches(sys.stdout.getvalue(), '^Failures:')
tandrii221ab252016-10-06 08:12:04 -07002680 self.assertRegexpMatches(sys.stdout.getvalue(), 'Started:')
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002681 self.assertRegexpMatches(sys.stdout.getvalue(), '2 tryjobs')
tandrii221ab252016-10-06 08:12:04 -07002682
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002683 def _mock_gerrit_changes_for_detail_cache(self):
2684 self.mock(git_cl._GerritChangelistImpl, '_GetGerritHost', lambda _: 'host')
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002685
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002686 def test_gerrit_change_detail_cache_simple(self):
2687 self._mock_gerrit_changes_for_detail_cache()
2688 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002689 (('GetChangeDetail', 'host', 'my%2Frepo~1', []), 'a'),
2690 (('GetChangeDetail', 'host', 'ab%2Frepo~2', []), 'b'),
2691 (('GetChangeDetail', 'host', 'ab%2Frepo~2', []), 'b2'),
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002692 ]
Andrii Shyshkalovb7214602018-08-22 23:20:26 +00002693 cl1 = git_cl.Changelist(issue=1, codereview='gerrit')
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002694 cl1._cached_remote_url = (
2695 True, 'https://chromium.googlesource.com/a/my/repo.git/')
Andrii Shyshkalovb7214602018-08-22 23:20:26 +00002696 cl2 = git_cl.Changelist(issue=2, codereview='gerrit')
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002697 cl2._cached_remote_url = (
2698 True, 'https://chromium.googlesource.com/ab/repo')
Andrii Shyshkalovb7214602018-08-22 23:20:26 +00002699 self.assertEqual(cl1._GetChangeDetail(), 'a') # Miss.
2700 self.assertEqual(cl1._GetChangeDetail(), 'a')
2701 self.assertEqual(cl2._GetChangeDetail(), 'b') # Miss.
2702 self.assertEqual(cl2._GetChangeDetail(no_cache=True), 'b2') # Miss.
2703 self.assertEqual(cl1._GetChangeDetail(), 'a')
2704 self.assertEqual(cl2._GetChangeDetail(), 'b2')
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002705
2706 def test_gerrit_change_detail_cache_options(self):
2707 self._mock_gerrit_changes_for_detail_cache()
2708 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002709 (('GetChangeDetail', 'host', 'repo~1', ['C', 'A', 'B']), 'cab'),
2710 (('GetChangeDetail', 'host', 'repo~1', ['A', 'D']), 'ad'),
2711 (('GetChangeDetail', 'host', 'repo~1', ['A']), 'a'), # no_cache=True
2712 # no longer in cache.
2713 (('GetChangeDetail', 'host', 'repo~1', ['B']), 'b'),
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002714 ]
2715 cl = git_cl.Changelist(issue=1, codereview='gerrit')
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002716 cl._cached_remote_url = (True, 'https://chromium.googlesource.com/repo/')
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002717 self.assertEqual(cl._GetChangeDetail(options=['C', 'A', 'B']), 'cab')
2718 self.assertEqual(cl._GetChangeDetail(options=['A', 'B', 'C']), 'cab')
2719 self.assertEqual(cl._GetChangeDetail(options=['B', 'A']), 'cab')
2720 self.assertEqual(cl._GetChangeDetail(options=['C']), 'cab')
2721 self.assertEqual(cl._GetChangeDetail(options=['A']), 'cab')
2722 self.assertEqual(cl._GetChangeDetail(), 'cab')
2723
2724 self.assertEqual(cl._GetChangeDetail(options=['A', 'D']), 'ad')
2725 self.assertEqual(cl._GetChangeDetail(options=['A']), 'cab')
2726 self.assertEqual(cl._GetChangeDetail(options=['D']), 'ad')
2727 self.assertEqual(cl._GetChangeDetail(), 'cab')
2728
2729 # Finally, no_cache should invalidate all caches for given change.
2730 self.assertEqual(cl._GetChangeDetail(options=['A'], no_cache=True), 'a')
2731 self.assertEqual(cl._GetChangeDetail(options=['B']), 'b')
2732
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002733 def test_gerrit_description_caching(self):
2734 def gen_detail(rev, desc):
2735 return {
2736 'current_revision': rev,
2737 'revisions': {rev: {'commit': {'message': desc}}}
2738 }
2739 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002740 (('GetChangeDetail', 'host', 'my%2Frepo~1',
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002741 ['CURRENT_REVISION', 'CURRENT_COMMIT']),
2742 gen_detail('rev1', 'desc1')),
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002743 (('GetChangeDetail', 'host', 'my%2Frepo~1',
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002744 ['CURRENT_REVISION', 'CURRENT_COMMIT']),
2745 gen_detail('rev2', 'desc2')),
2746 ]
2747
2748 self._mock_gerrit_changes_for_detail_cache()
2749 cl = git_cl.Changelist(issue=1, codereview='gerrit')
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002750 cl._cached_remote_url = (
2751 True, 'https://chromium.googlesource.com/a/my/repo.git/')
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002752 self.assertEqual(cl.GetDescription(), 'desc1')
2753 self.assertEqual(cl.GetDescription(), 'desc1') # cache hit.
2754 self.assertEqual(cl.GetDescription(force=True), 'desc2')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002755
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002756 def test_print_current_creds(self):
2757 class CookiesAuthenticatorMock(object):
2758 def __init__(self):
2759 self.gitcookies = {
2760 'host.googlesource.com': ('user', 'pass'),
2761 'host-review.googlesource.com': ('user', 'pass'),
2762 }
2763 self.netrc = self
2764 self.netrc.hosts = {
2765 'github.com': ('user2', None, 'pass2'),
2766 'host2.googlesource.com': ('user3', None, 'pass'),
2767 }
2768 self.mock(git_cl.gerrit_util, 'CookiesAuthenticator',
2769 CookiesAuthenticatorMock)
2770 self.mock(sys, 'stdout', StringIO.StringIO())
2771 git_cl._GitCookiesChecker().print_current_creds(include_netrc=True)
2772 self.assertEqual(list(sys.stdout.getvalue().splitlines()), [
2773 ' Host\t User\t Which file',
2774 '============================\t=====\t===========',
2775 'host-review.googlesource.com\t user\t.gitcookies',
2776 ' host.googlesource.com\t user\t.gitcookies',
2777 ' host2.googlesource.com\tuser3\t .netrc',
2778 ])
2779 sys.stdout.buf = ''
2780 git_cl._GitCookiesChecker().print_current_creds(include_netrc=False)
2781 self.assertEqual(list(sys.stdout.getvalue().splitlines()), [
2782 ' Host\tUser\t Which file',
2783 '============================\t====\t===========',
2784 'host-review.googlesource.com\tuser\t.gitcookies',
2785 ' host.googlesource.com\tuser\t.gitcookies',
2786 ])
2787
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002788 def _common_creds_check_mocks(self):
2789 def exists_mock(path):
2790 dirname = os.path.dirname(path)
2791 if dirname == os.path.expanduser('~'):
2792 dirname = '~'
2793 base = os.path.basename(path)
2794 if base in ('.netrc', '.gitcookies'):
2795 return self._mocked_call('os.path.exists', '%s/%s' % (dirname, base))
2796 # git cl also checks for existence other files not relevant to this test.
2797 return None
2798 self.mock(os.path, 'exists', exists_mock)
2799 self.mock(sys, 'stdout', StringIO.StringIO())
2800
2801 def test_creds_check_gitcookies_not_configured(self):
2802 self._common_creds_check_mocks()
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002803 self.mock(git_cl._GitCookiesChecker, 'get_hosts_with_creds',
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01002804 lambda _, include_netrc=False: [])
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002805 self.calls = [
Aaron Gable8797cab2018-03-06 13:55:00 -08002806 ((['git', 'config', '--path', 'http.cookiefile'],), CERR1),
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002807 ((['git', 'config', '--global', 'http.cookiefile'],), CERR1),
2808 (('os.path.exists', '~/.netrc'), True),
2809 (('ask_for_data', 'Press Enter to setup .gitcookies, '
2810 'or Ctrl+C to abort'), ''),
2811 ((['git', 'config', '--global', 'http.cookiefile',
2812 os.path.expanduser('~/.gitcookies')], ), ''),
2813 ]
2814 self.assertEqual(0, git_cl.main(['creds-check']))
2815 self.assertRegexpMatches(
2816 sys.stdout.getvalue(),
2817 '^You seem to be using outdated .netrc for git credentials:')
2818 self.assertRegexpMatches(
2819 sys.stdout.getvalue(),
2820 '\nConfigured git to use .gitcookies from')
2821
2822 def test_creds_check_gitcookies_configured_custom_broken(self):
2823 self._common_creds_check_mocks()
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002824 self.mock(git_cl._GitCookiesChecker, 'get_hosts_with_creds',
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01002825 lambda _, include_netrc=False: [])
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002826 self.calls = [
Aaron Gable8797cab2018-03-06 13:55:00 -08002827 ((['git', 'config', '--path', 'http.cookiefile'],), CERR1),
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002828 ((['git', 'config', '--global', 'http.cookiefile'],),
2829 '/custom/.gitcookies'),
2830 (('os.path.exists', '/custom/.gitcookies'), False),
2831 (('ask_for_data', 'Reconfigure git to use default .gitcookies? '
2832 'Press Enter to reconfigure, or Ctrl+C to abort'), ''),
2833 ((['git', 'config', '--global', 'http.cookiefile',
2834 os.path.expanduser('~/.gitcookies')], ), ''),
2835 ]
2836 self.assertEqual(0, git_cl.main(['creds-check']))
2837 self.assertRegexpMatches(
2838 sys.stdout.getvalue(),
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002839 'WARNING: You have configured custom path to .gitcookies: ')
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002840 self.assertRegexpMatches(
2841 sys.stdout.getvalue(),
2842 'However, your configured .gitcookies file is missing.')
2843
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002844 def test_git_cl_comment_add_gerrit(self):
2845 self.mock(git_cl.gerrit_util, 'SetReview',
Aaron Gable636b13f2017-07-14 10:42:48 -07002846 lambda host, change, msg, ready:
2847 self._mocked_call('SetReview', host, change, msg, ready))
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002848 self.calls = [
2849 ((['git', 'symbolic-ref', 'HEAD'],), CERR1),
2850 ((['git', 'symbolic-ref', 'HEAD'],), CERR1),
2851 ((['git', 'config', 'rietveld.upstream-branch'],), CERR1),
2852 ((['git', 'branch', '-r'],), 'origin/HEAD -> origin/master\n'
2853 'origin/master'),
2854 ((['git', 'config', 'remote.origin.url'],),
2855 'https://chromium.googlesource.com/infra/infra'),
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002856 (('SetReview', 'chromium-review.googlesource.com', 'infra%2Finfra~10',
2857 'msg', None),
Aaron Gable636b13f2017-07-14 10:42:48 -07002858 None),
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002859 ]
2860 self.assertEqual(0, git_cl.main(['comment', '--gerrit', '-i', '10',
2861 '-a', 'msg']))
2862
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002863 def test_git_cl_comments_fetch_gerrit(self):
2864 self.mock(sys, 'stdout', StringIO.StringIO())
2865 self.calls = [
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002866 ((['git', 'config', 'branch.foo.gerritserver'],), ''),
2867 ((['git', 'config', 'branch.foo.merge'],), ''),
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002868 ((['git', 'config', 'rietveld.upstream-branch'],), CERR1),
2869 ((['git', 'branch', '-r'],), 'origin/HEAD -> origin/master\n'
2870 'origin/master'),
2871 ((['git', 'config', 'remote.origin.url'],),
2872 'https://chromium.googlesource.com/infra/infra'),
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002873 (('GetChangeDetail', 'chromium-review.googlesource.com',
2874 'infra%2Finfra~1',
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002875 ['MESSAGES', 'DETAILED_ACCOUNTS', 'CURRENT_REVISION',
2876 'CURRENT_COMMIT']), {
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002877 'owner': {'email': 'owner@example.com'},
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002878 'current_revision': 'ba5eba11',
2879 'revisions': {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002880 'deadbeaf': {
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002881 '_number': 1,
2882 },
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002883 'ba5eba11': {
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002884 '_number': 2,
2885 },
2886 },
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002887 'messages': [
2888 {
2889 u'_revision_number': 1,
2890 u'author': {
2891 u'_account_id': 1111084,
2892 u'email': u'commit-bot@chromium.org',
2893 u'name': u'Commit Bot'
2894 },
2895 u'date': u'2017-03-15 20:08:45.000000000',
2896 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046dc50b',
Dirk Prankef6a58802017-10-17 12:49:42 -07002897 u'message': u'Patch Set 1:\n\nDry run: CQ is trying the patch...',
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002898 u'tag': u'autogenerated:cq:dry-run'
2899 },
2900 {
2901 u'_revision_number': 2,
2902 u'author': {
2903 u'_account_id': 11151243,
2904 u'email': u'owner@example.com',
2905 u'name': u'owner'
2906 },
2907 u'date': u'2017-03-16 20:00:41.000000000',
2908 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2909 u'message': u'PTAL',
2910 },
2911 {
2912 u'_revision_number': 2,
2913 u'author': {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002914 u'_account_id': 148512,
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002915 u'email': u'reviewer@example.com',
2916 u'name': u'reviewer'
2917 },
2918 u'date': u'2017-03-17 05:19:37.500000000',
2919 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d4568',
2920 u'message': u'Patch Set 2: Code-Review+1',
2921 },
2922 ]
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002923 }),
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002924 (('GetChangeComments', 'chromium-review.googlesource.com',
2925 'infra%2Finfra~1'), {
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002926 '/COMMIT_MSG': [
2927 {
2928 'author': {'email': u'reviewer@example.com'},
2929 'updated': u'2017-03-17 05:19:37.500000000',
2930 'patch_set': 2,
2931 'side': 'REVISION',
2932 'message': 'Please include a bug link',
2933 },
2934 ],
2935 'codereview.settings': [
2936 {
2937 'author': {'email': u'owner@example.com'},
2938 'updated': u'2017-03-16 20:00:41.000000000',
2939 'patch_set': 2,
2940 'side': 'PARENT',
2941 'line': 42,
2942 'message': 'I removed this because it is bad',
2943 },
2944 ]
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002945 }),
2946 (('GetChangeRobotComments', 'chromium-review.googlesource.com',
2947 'infra%2Finfra~1'), {}),
2948 ((['git', 'config', 'branch.foo.gerritpatchset', '2'],), ''),
Leszek Swirski45b20c42018-09-17 17:05:26 +00002949 ] * 2 + [
2950 (('write_json', 'output.json', [
2951 {
2952 u'date': u'2017-03-16 20:00:41.000000',
2953 u'message': (
2954 u'PTAL\n' +
2955 u'\n' +
2956 u'codereview.settings\n' +
2957 u' Base, Line 42: https://chromium-review.googlesource.com/' +
2958 u'c/1/2/codereview.settings#b42\n' +
2959 u' I removed this because it is bad\n'),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002960 u'autogenerated': False,
Leszek Swirski45b20c42018-09-17 17:05:26 +00002961 u'approval': False,
2962 u'disapproval': False,
2963 u'sender': u'owner@example.com'
2964 }, {
2965 u'date': u'2017-03-17 05:19:37.500000',
2966 u'message': (
2967 u'Patch Set 2: Code-Review+1\n' +
2968 u'\n' +
2969 u'/COMMIT_MSG\n' +
2970 u' PS2, File comment: https://chromium-review.googlesource' +
2971 u'.com/c/1/2//COMMIT_MSG#\n' +
2972 u' Please include a bug link\n'),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002973 u'autogenerated': False,
Leszek Swirski45b20c42018-09-17 17:05:26 +00002974 u'approval': False,
2975 u'disapproval': False,
2976 u'sender': u'reviewer@example.com'
2977 }
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002978 ]), '')
Leszek Swirski45b20c42018-09-17 17:05:26 +00002979 ]
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002980 expected_comments_summary = [
2981 git_cl._CommentSummary(
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002982 message=(
2983 u'PTAL\n' +
2984 u'\n' +
2985 u'codereview.settings\n' +
2986 u' Base, Line 42: https://chromium-review.googlesource.com/' +
2987 u'c/1/2/codereview.settings#b42\n' +
2988 u' I removed this because it is bad\n'),
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002989 date=datetime.datetime(2017, 3, 16, 20, 0, 41, 0),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002990 autogenerated=False,
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002991 disapproval=False, approval=False, sender=u'owner@example.com'),
2992 git_cl._CommentSummary(
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002993 message=(
2994 u'Patch Set 2: Code-Review+1\n' +
2995 u'\n' +
2996 u'/COMMIT_MSG\n' +
2997 u' PS2, File comment: https://chromium-review.googlesource.com/' +
2998 u'c/1/2//COMMIT_MSG#\n' +
2999 u' Please include a bug link\n'),
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01003000 date=datetime.datetime(2017, 3, 17, 5, 19, 37, 500000),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00003001 autogenerated=False,
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01003002 disapproval=False, approval=False, sender=u'reviewer@example.com'),
3003 ]
Quinten Yearsley0e617c02019-02-20 00:37:03 +00003004 cl = git_cl.Changelist(
3005 codereview='gerrit', issue=1, branchref='refs/heads/foo')
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01003006 self.assertEqual(cl.GetCommentsSummary(), expected_comments_summary)
Quinten Yearsley0e617c02019-02-20 00:37:03 +00003007 self.mock(git_cl.Changelist, 'GetBranch', lambda _: 'foo')
3008 self.assertEqual(
3009 0, git_cl.main(['comments', '-i', '1', '-j', 'output.json']))
3010
3011 def test_git_cl_comments_robot_comments(self):
3012 # git cl comments also fetches robot comments (which are considered a type
3013 # of autogenerated comment), and unlike other types of comments, only robot
3014 # comments from the latest patchset are shown.
3015 self.mock(sys, 'stdout', StringIO.StringIO())
3016 self.calls = [
3017 ((['git', 'config', 'branch.foo.gerritserver'],), ''),
3018 ((['git', 'config', 'branch.foo.merge'],), ''),
3019 ((['git', 'config', 'rietveld.upstream-branch'],), CERR1),
3020 ((['git', 'branch', '-r'],), 'origin/HEAD -> origin/master\n'
3021 'origin/master'),
3022 ((['git', 'config', 'remote.origin.url'],),
3023 'https://chromium.googlesource.com/infra/infra'),
3024 (('GetChangeDetail', 'chromium-review.googlesource.com',
3025 'infra%2Finfra~1',
3026 ['MESSAGES', 'DETAILED_ACCOUNTS', 'CURRENT_REVISION',
3027 'CURRENT_COMMIT']), {
3028 'owner': {'email': 'owner@example.com'},
3029 'current_revision': 'ba5eba11',
3030 'revisions': {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003031 'deadbeaf': {
Quinten Yearsley0e617c02019-02-20 00:37:03 +00003032 '_number': 1,
3033 },
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003034 'ba5eba11': {
Quinten Yearsley0e617c02019-02-20 00:37:03 +00003035 '_number': 2,
3036 },
3037 },
3038 'messages': [
3039 {
3040 u'_revision_number': 1,
3041 u'author': {
3042 u'_account_id': 1111084,
3043 u'email': u'commit-bot@chromium.org',
3044 u'name': u'Commit Bot'
3045 },
3046 u'date': u'2017-03-15 20:08:45.000000000',
3047 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046dc50b',
3048 u'message': u'Patch Set 1:\n\nDry run: CQ is trying the patch...',
3049 u'tag': u'autogenerated:cq:dry-run'
3050 },
3051 {
3052 u'_revision_number': 1,
3053 u'author': {
3054 u'_account_id': 123,
3055 u'email': u'tricium@serviceaccount.com',
3056 u'name': u'Tricium'
3057 },
3058 u'date': u'2017-03-16 20:00:41.000000000',
3059 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
3060 u'message': u'(1 comment)',
3061 u'tag': u'autogenerated:tricium',
3062 },
3063 {
3064 u'_revision_number': 1,
3065 u'author': {
3066 u'_account_id': 123,
3067 u'email': u'tricium@serviceaccount.com',
3068 u'name': u'Tricium'
3069 },
3070 u'date': u'2017-03-16 20:00:41.000000000',
3071 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
3072 u'message': u'(1 comment)',
3073 u'tag': u'autogenerated:tricium',
3074 },
3075 {
3076 u'_revision_number': 2,
3077 u'author': {
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003078 u'_account_id': 123,
Quinten Yearsley0e617c02019-02-20 00:37:03 +00003079 u'email': u'tricium@serviceaccount.com',
3080 u'name': u'reviewer'
3081 },
3082 u'date': u'2017-03-17 05:30:37.000000000',
3083 u'tag': u'autogenerated:tricium',
3084 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d4568',
3085 u'message': u'(1 comment)',
3086 },
3087 ]
3088 }),
3089 (('GetChangeComments', 'chromium-review.googlesource.com',
3090 'infra%2Finfra~1'), {}),
3091 (('GetChangeRobotComments', 'chromium-review.googlesource.com',
3092 'infra%2Finfra~1'), {
3093 'codereview.settings': [
3094 {
3095 u'author': {u'email': u'tricium@serviceaccount.com'},
3096 u'updated': u'2017-03-17 05:30:37.000000000',
3097 u'robot_run_id': u'5565031076855808',
3098 u'robot_id': u'Linter/Category',
3099 u'tag': u'autogenerated:tricium',
3100 u'patch_set': 2,
3101 u'side': u'REVISION',
3102 u'message': u'Linter warning message text',
3103 u'line': 32,
3104 },
3105 ],
3106 }),
3107 ((['git', 'config', 'branch.foo.gerritpatchset', '2'],), ''),
3108 ]
3109 expected_comments_summary = [
3110 git_cl._CommentSummary(date=datetime.datetime(2017, 3, 17, 5, 30, 37),
3111 message=(
3112 u'(1 comment)\n\ncodereview.settings\n'
3113 u' PS2, Line 32: https://chromium-review.googlesource.com/'
3114 u'c/1/2/codereview.settings#32\n'
3115 u' Linter warning message text\n'),
3116 sender=u'tricium@serviceaccount.com',
3117 autogenerated=True, approval=False, disapproval=False)
3118 ]
3119 cl = git_cl.Changelist(
3120 codereview='gerrit', issue=1, branchref='refs/heads/foo')
3121 self.assertEqual(cl.GetCommentsSummary(), expected_comments_summary)
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003122
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00003123 def test_get_remote_url_with_mirror(self):
3124 original_os_path_isdir = os.path.isdir
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003125
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00003126 def selective_os_path_isdir_mock(path):
3127 if path == '/cache/this-dir-exists':
3128 return self._mocked_call('os.path.isdir', path)
3129 return original_os_path_isdir(path)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003130
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00003131 self.mock(os.path, 'isdir', selective_os_path_isdir_mock)
3132
3133 url = 'https://chromium.googlesource.com/my/repo'
3134 self.calls = [
3135 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
3136 ((['git', 'config', 'branch.master.merge'],), 'master'),
3137 ((['git', 'config', 'branch.master.remote'],), 'origin'),
3138 ((['git', 'config', 'remote.origin.url'],),
3139 '/cache/this-dir-exists'),
3140 (('os.path.isdir', '/cache/this-dir-exists'),
3141 True),
3142 # Runs in /cache/this-dir-exists.
3143 ((['git', 'config', 'remote.origin.url'],),
3144 url),
3145 ]
3146 cl = git_cl.Changelist(codereview='gerrit', issue=1)
3147 self.assertEqual(cl.GetRemoteUrl(), url)
3148 self.assertEqual(cl.GetRemoteUrl(), url) # Must be cached.
3149
Edward Lemur298f2cf2019-02-22 21:40:39 +00003150 def test_get_remote_url_non_existing_mirror(self):
3151 original_os_path_isdir = os.path.isdir
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003152
Edward Lemur298f2cf2019-02-22 21:40:39 +00003153 def selective_os_path_isdir_mock(path):
3154 if path == '/cache/this-dir-doesnt-exist':
3155 return self._mocked_call('os.path.isdir', path)
3156 return original_os_path_isdir(path)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003157
Edward Lemur298f2cf2019-02-22 21:40:39 +00003158 self.mock(os.path, 'isdir', selective_os_path_isdir_mock)
3159 self.mock(logging, 'error',
3160 lambda fmt, *a: self._mocked_call('logging.error', fmt % a))
3161
3162 self.calls = [
3163 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
3164 ((['git', 'config', 'branch.master.merge'],), 'master'),
3165 ((['git', 'config', 'branch.master.remote'],), 'origin'),
3166 ((['git', 'config', 'remote.origin.url'],),
3167 '/cache/this-dir-doesnt-exist'),
3168 (('os.path.isdir', '/cache/this-dir-doesnt-exist'),
3169 False),
3170 (('logging.error',
3171 'Remote "origin" for branch "/cache/this-dir-doesnt-exist" points to'
3172 ' "master", but it doesn\'t exist.'), None),
3173 ]
3174 cl = git_cl.Changelist(codereview='gerrit', issue=1)
3175 self.assertIsNone(cl.GetRemoteUrl())
3176
3177 def test_get_remote_url_misconfigured_mirror(self):
3178 original_os_path_isdir = os.path.isdir
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003179
Edward Lemur298f2cf2019-02-22 21:40:39 +00003180 def selective_os_path_isdir_mock(path):
3181 if path == '/cache/this-dir-exists':
3182 return self._mocked_call('os.path.isdir', path)
3183 return original_os_path_isdir(path)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003184
Edward Lemur298f2cf2019-02-22 21:40:39 +00003185 self.mock(os.path, 'isdir', selective_os_path_isdir_mock)
3186 self.mock(logging, 'error',
3187 lambda *a: self._mocked_call('logging.error', *a))
3188
3189 self.calls = [
3190 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
3191 ((['git', 'config', 'branch.master.merge'],), 'master'),
3192 ((['git', 'config', 'branch.master.remote'],), 'origin'),
3193 ((['git', 'config', 'remote.origin.url'],),
3194 '/cache/this-dir-exists'),
3195 (('os.path.isdir', '/cache/this-dir-exists'), True),
3196 # Runs in /cache/this-dir-exists.
3197 ((['git', 'config', 'remote.origin.url'],), ''),
3198 (('logging.error',
3199 'Remote "%(remote)s" for branch "%(branch)s" points to '
3200 '"%(cache_path)s", but it is misconfigured.\n'
3201 '"%(cache_path)s" must be a git repo and must have a remote named '
3202 '"%(remote)s" pointing to the git host.', {
3203 'remote': 'origin',
3204 'cache_path': '/cache/this-dir-exists',
3205 'branch': 'master'}
3206 ), None),
3207 ]
3208 cl = git_cl.Changelist(codereview='gerrit', issue=1)
3209 self.assertIsNone(cl.GetRemoteUrl())
3210
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00003211 def test_gerrit_change_identifier_with_project(self):
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00003212 self.calls = [
3213 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
3214 ((['git', 'config', 'branch.master.merge'],), 'master'),
3215 ((['git', 'config', 'branch.master.remote'],), 'origin'),
3216 ((['git', 'config', 'remote.origin.url'],),
3217 'https://chromium.googlesource.com/a/my/repo.git/'),
3218 ]
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00003219 cl = git_cl.Changelist(codereview='gerrit', issue=123456)
3220 self.assertEqual(cl._GerritChangeIdentifier(), 'my%2Frepo~123456')
3221
3222 def test_gerrit_change_identifier_without_project(self):
3223 self.calls = [
3224 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
3225 ((['git', 'config', 'branch.master.merge'],), 'master'),
3226 ((['git', 'config', 'branch.master.remote'],), 'origin'),
3227 ((['git', 'config', 'remote.origin.url'],), CERR1),
3228 ]
3229 cl = git_cl.Changelist(codereview='gerrit', issue=123456)
3230 self.assertEqual(cl._GerritChangeIdentifier(), '123456')
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00003231
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003232
maruel@chromium.orgddd59412011-11-30 14:20:38 +00003233if __name__ == '__main__':
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +01003234 logging.basicConfig(
3235 level=logging.DEBUG if '-v' in sys.argv else logging.ERROR)
maruel@chromium.orgddd59412011-11-30 14:20:38 +00003236 unittest.main()