blob: 5d37c6c83a2a4544c59ea4660f9dd0be44486672 [file] [log] [blame]
Josip Sokcevic4de5dea2022-03-23 21:15:14 +00001#!/usr/bin/env vpython3
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +02002# Copyright (c) 2013 The Chromium Authors. All rights reserved.
maruel@chromium.org725f1c32011-04-01 20:24:54 +00003# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00006# Copyright (C) 2008 Evan Martin <martine@danga.com>
7
Andrii Shyshkalov03da1502018-10-15 03:42:34 +00008"""A git-command for integrating reviews on Gerrit."""
maruel@chromium.org725f1c32011-04-01 20:24:54 +00009
vapiera7fbd5a2016-06-16 09:17:49 -070010from __future__ import print_function
11
thakis@chromium.org3421c992014-11-02 02:20:32 +000012import base64
rmistry@google.com2dd99862015-06-22 12:22:18 +000013import collections
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +010014import datetime
Brian Sheedyb4307d52019-12-02 19:18:17 +000015import fnmatch
Edward Lemur202c5592019-10-21 22:44:52 +000016import httplib2
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +010017import itertools
maruel@chromium.org4f6852c2012-04-20 20:39:20 +000018import json
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000019import logging
calamity@chromium.orgcf197482016-04-29 20:15:53 +000020import multiprocessing
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000021import optparse
22import os
23import re
Andrii Shyshkalov353637c2017-03-14 16:52:18 +010024import shutil
ukai@chromium.org78c4b982012-02-14 02:20:26 +000025import stat
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000026import sys
Aaron Gable9a03ae02017-11-03 11:31:07 -070027import tempfile
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000028import textwrap
Edward Lemurfec80c42018-11-01 23:14:14 +000029import time
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +000030import uuid
thestig@chromium.org00858c82013-12-02 23:08:03 +000031import webbrowser
thakis@chromium.org3421c992014-11-02 02:20:32 +000032import zlib
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000033
maruel@chromium.org2e23ce32013-05-07 12:42:28 +000034from third_party import colorama
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +000035import auth
nick@chromium.org3ac1c4e2014-01-16 02:44:42 +000036import clang_format
maruel@chromium.org6f09cd92011-04-01 16:38:12 +000037import fix_encoding
maruel@chromium.org0e0436a2011-10-25 13:32:41 +000038import gclient_utils
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +000039import gerrit_util
iannucci@chromium.org9e849272014-04-04 00:31:55 +000040import git_common
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +000041import git_footers
Edward Lemur85153282020-02-14 22:06:29 +000042import git_new_branch
Edward Lemur5ba1e9c2018-07-23 18:19:02 +000043import metrics
Edward Lesmes93277a72018-10-18 22:04:26 +000044import metrics_utils
Edward Lesmeseeca9c62020-11-20 00:00:17 +000045import owners_client
iannucci@chromium.org9e849272014-04-04 00:31:55 +000046import owners_finder
Lei Zhangb8c62cf2020-07-15 20:09:37 +000047import presubmit_canned_checks
maruel@chromium.org2a74d372011-03-29 19:05:50 +000048import presubmit_support
Lukasz Anforowiczb4d39542021-09-30 23:39:25 +000049import rustfmt
maruel@chromium.org2a74d372011-03-29 19:05:50 +000050import scm
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +000051import setup_color
Francois Dorayd42c6812017-05-30 15:10:20 -040052import split_cl
maruel@chromium.org0633fb42013-08-16 20:06:14 +000053import subcommand
maruel@chromium.org32f9f5e2011-09-14 13:41:47 +000054import subprocess2
Olivier Robin0a6b5442022-04-07 07:25:04 +000055import swift_format
maruel@chromium.org2a74d372011-03-29 19:05:50 +000056import watchlists
57
Edward Lemur79d4f992019-11-11 23:49:02 +000058from third_party import six
59from six.moves import urllib
60
61
62if sys.version_info.major == 3:
63 basestring = (str,) # pylint: disable=redefined-builtin
64
Edward Lemurb9830242019-10-30 22:19:20 +000065
tandrii7400cf02016-06-21 08:48:07 -070066__version__ = '2.0'
maruel@chromium.org2a74d372011-03-29 19:05:50 +000067
Edward Lemur0f58ae42019-04-30 17:24:12 +000068# Traces for git push will be stored in a traces directory inside the
69# depot_tools checkout.
70DEPOT_TOOLS = os.path.dirname(os.path.abspath(__file__))
71TRACES_DIR = os.path.join(DEPOT_TOOLS, 'traces')
Edward Lemur227d5102020-02-25 23:45:35 +000072PRESUBMIT_SUPPORT = os.path.join(DEPOT_TOOLS, 'presubmit_support.py')
Edward Lemur0f58ae42019-04-30 17:24:12 +000073
74# When collecting traces, Git hashes will be reduced to 6 characters to reduce
75# the size after compression.
76GIT_HASH_RE = re.compile(r'\b([a-f0-9]{6})[a-f0-9]{34}\b', flags=re.I)
77# Used to redact the cookies from the gitcookies file.
78GITCOOKIES_REDACT_RE = re.compile(r'1/.*')
79
Edward Lemurd4d1ba42019-09-20 21:46:37 +000080MAX_ATTEMPTS = 3
81
Edward Lemur1b52d872019-05-09 21:12:12 +000082# The maximum number of traces we will keep. Multiplied by 3 since we store
83# 3 files per trace.
84MAX_TRACES = 3 * 10
Edward Lemur5737f022019-05-17 01:24:00 +000085# Message to be displayed to the user to inform where to find the traces for a
86# git-cl upload execution.
Edward Lemur0f58ae42019-04-30 17:24:12 +000087TRACES_MESSAGE = (
Edward Lemur1b52d872019-05-09 21:12:12 +000088'\n'
Edward Lemur5737f022019-05-17 01:24:00 +000089'The traces of this git-cl execution have been recorded at:\n'
Edward Lemur1b52d872019-05-09 21:12:12 +000090' %(trace_name)s-traces.zip\n'
Edward Lemur5737f022019-05-17 01:24:00 +000091'Copies of your gitcookies file and git config have been recorded at:\n'
92' %(trace_name)s-git-info.zip\n')
Edward Lemur1b52d872019-05-09 21:12:12 +000093# Format of the message to be stored as part of the traces to give developers a
94# better context when they go through traces.
95TRACES_README_FORMAT = (
96'Date: %(now)s\n'
97'\n'
98'Change: https://%(gerrit_host)s/q/%(change_id)s\n'
99'Title: %(title)s\n'
100'\n'
101'%(description)s\n'
102'\n'
103'Execution time: %(execution_time)s\n'
104'Exit code: %(exit_code)s\n') + TRACES_MESSAGE
Edward Lemur0f58ae42019-04-30 17:24:12 +0000105
Aaron Gable1bc7bfe2016-12-19 10:08:14 -0800106POSTUPSTREAM_HOOK = '.git/hooks/post-cl-land'
Henrique Ferreiroff249622019-11-28 23:19:29 +0000107DESCRIPTION_BACKUP_FILE = '.git_cl_description_backup'
rmistry@google.comc68112d2015-03-03 12:48:06 +0000108REFS_THAT_ALIAS_TO_OTHER_REFS = {
Josip Sokcevic7e133ff2021-07-13 17:44:53 +0000109 'refs/remotes/origin/lkgr': 'refs/remotes/origin/main',
110 'refs/remotes/origin/lkcr': 'refs/remotes/origin/main',
rmistry@google.comc68112d2015-03-03 12:48:06 +0000111}
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000112
Josip Sokcevicc39ab992020-09-24 20:09:15 +0000113DEFAULT_OLD_BRANCH = 'refs/remotes/origin/master'
114DEFAULT_NEW_BRANCH = 'refs/remotes/origin/main'
115
Joanna Wanga8db0cb2023-01-24 15:43:17 +0000116DEFAULT_BUILDBUCKET_HOST = 'cr-buildbucket.appspot.com'
117
thestig@chromium.org44202a22014-03-11 19:22:18 +0000118# Valid extensions for files we want to lint.
119DEFAULT_LINT_REGEX = r"(.*\.cpp|.*\.cc|.*\.h)"
120DEFAULT_LINT_IGNORE_REGEX = r"$^"
121
Aiden Bennerc08566e2018-10-03 17:52:42 +0000122# File name for yapf style config files.
123YAPF_CONFIG_FILENAME = '.style.yapf'
124
Edward Lesmes50da7702020-03-30 19:23:43 +0000125# The issue, patchset and codereview server are stored on git config for each
126# branch under branch.<branch-name>.<config-key>.
127ISSUE_CONFIG_KEY = 'gerritissue'
128PATCHSET_CONFIG_KEY = 'gerritpatchset'
129CODEREVIEW_SERVER_CONFIG_KEY = 'gerritserver'
Gavin Makbe2e9262022-11-08 23:41:55 +0000130# When using squash workflow, _CMDUploadChange doesn't simply push the commit(s)
131# you make to Gerrit. Instead, it creates a new commit object that contains all
132# changes you've made, diffed against a parent/merge base.
133# This is the hash of the new squashed commit and you can find this on Gerrit.
134GERRIT_SQUASH_HASH_CONFIG_KEY = 'gerritsquashhash'
135# This is the latest uploaded local commit hash.
136LAST_UPLOAD_HASH_CONFIG_KEY = 'last-upload-hash'
Edward Lesmes50da7702020-03-30 19:23:43 +0000137
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000138# Shortcut since it quickly becomes repetitive.
maruel@chromium.org2e23ce32013-05-07 12:42:28 +0000139Fore = colorama.Fore
maruel@chromium.org90541732011-04-01 17:54:18 +0000140
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000141# Initialized in main()
142settings = None
143
Andrii Shyshkalov768f1d82016-12-08 15:10:13 +0100144# Used by tests/git_cl_test.py to add extra logging.
145# Inside the weirdly failing test, add this:
146# >>> self.mock(git_cl, '_IS_BEING_TESTED', True)
Quinten Yearsley0c62da92017-05-31 13:39:42 -0700147# And scroll up to see the stack trace printed.
Andrii Shyshkalov768f1d82016-12-08 15:10:13 +0100148_IS_BEING_TESTED = False
149
Garrett Beaty08bb5c42022-09-21 17:34:20 +0000150_GOOGLESOURCE = 'googlesource.com'
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000151
Andrii Shyshkalov1ee78cd2020-03-12 01:31:53 +0000152_KNOWN_GERRIT_TO_SHORT_URLS = {
153 'https://chrome-internal-review.googlesource.com': 'https://crrev.com/i',
154 'https://chromium-review.googlesource.com': 'https://crrev.com/c',
155}
Andrii Shyshkalov8aebb602020-04-16 22:10:27 +0000156assert len(_KNOWN_GERRIT_TO_SHORT_URLS) == len(
157 set(_KNOWN_GERRIT_TO_SHORT_URLS.values())), 'must have unique values'
Andrii Shyshkalov1ee78cd2020-03-12 01:31:53 +0000158
159
Joanna Wang18de1f62023-01-21 01:24:24 +0000160# Maximum number of branches in a stack that can be traversed and uploaded
161# at once. Picked arbitrarily.
162_MAX_STACKED_BRANCHES_UPLOAD = 20
163
164
Josip Sokcevicf736cab2020-10-20 23:41:38 +0000165class GitPushError(Exception):
166 pass
167
168
Christopher Lamf732cd52017-01-24 12:40:11 +1100169def DieWithError(message, change_desc=None):
170 if change_desc:
171 SaveDescriptionBackup(change_desc)
Josip Sokcevic953278a2020-02-28 19:46:36 +0000172 print('\n ** Content of CL description **\n' +
173 '='*72 + '\n' +
174 change_desc.description + '\n' +
175 '='*72 + '\n')
Christopher Lamf732cd52017-01-24 12:40:11 +1100176
vapiera7fbd5a2016-06-16 09:17:49 -0700177 print(message, file=sys.stderr)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000178 sys.exit(1)
179
180
Christopher Lamf732cd52017-01-24 12:40:11 +1100181def SaveDescriptionBackup(change_desc):
Henrique Ferreiro5ae48172019-11-29 16:14:42 +0000182 backup_path = os.path.join(DEPOT_TOOLS, DESCRIPTION_BACKUP_FILE)
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000183 print('\nsaving CL description to %s\n' % backup_path)
sokcevic07152802021-08-18 00:06:34 +0000184 with open(backup_path, 'wb') as backup_file:
185 backup_file.write(change_desc.description.encode('utf-8'))
Christopher Lamf732cd52017-01-24 12:40:11 +1100186
187
thestig@chromium.org8b0553c2014-02-11 00:33:37 +0000188def GetNoGitPagerEnv():
189 env = os.environ.copy()
190 # 'cat' is a magical git string that disables pagers on all platforms.
191 env['GIT_PAGER'] = 'cat'
192 return env
193
vadimsh@chromium.org566a02a2014-08-22 01:34:13 +0000194
bsep@chromium.org627d9002016-04-29 00:00:52 +0000195def RunCommand(args, error_ok=False, error_message=None, shell=False, **kwargs):
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000196 try:
Edward Lemur79d4f992019-11-11 23:49:02 +0000197 stdout = subprocess2.check_output(args, shell=shell, **kwargs)
198 return stdout.decode('utf-8', 'replace')
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000199 except subprocess2.CalledProcessError as e:
200 logging.debug('Failed running %s', args)
maruel@chromium.org32f9f5e2011-09-14 13:41:47 +0000201 if not error_ok:
Alan Cutter594fd332020-07-21 23:55:27 +0000202 message = error_message or e.stdout.decode('utf-8', 'replace') or ''
203 DieWithError('Command "%s" failed.\n%s' % (' '.join(args), message))
Josip Sokcevic673e8ed2021-10-27 23:46:18 +0000204 out = e.stdout.decode('utf-8', 'replace')
205 if e.stderr:
206 out += e.stderr.decode('utf-8', 'replace')
207 return out
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000208
209
210def RunGit(args, **kwargs):
maruel@chromium.org32f9f5e2011-09-14 13:41:47 +0000211 """Returns stdout."""
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000212 return RunCommand(['git'] + args, **kwargs)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000213
214
enne@chromium.org3b7e15c2014-01-21 17:44:47 +0000215def RunGitWithCode(args, suppress_stderr=False):
maruel@chromium.org32f9f5e2011-09-14 13:41:47 +0000216 """Returns return code and stdout."""
tandrii5d48c322016-08-18 16:19:37 -0700217 if suppress_stderr:
Edward Lesmescf06cad2020-12-14 22:03:23 +0000218 stderr = subprocess2.DEVNULL
tandrii5d48c322016-08-18 16:19:37 -0700219 else:
220 stderr = sys.stderr
szager@chromium.org9bb85e22012-06-13 20:28:23 +0000221 try:
tandrii5d48c322016-08-18 16:19:37 -0700222 (out, _), code = subprocess2.communicate(['git'] + args,
223 env=GetNoGitPagerEnv(),
224 stdout=subprocess2.PIPE,
225 stderr=stderr)
Edward Lemur79d4f992019-11-11 23:49:02 +0000226 return code, out.decode('utf-8', 'replace')
tandrii5d48c322016-08-18 16:19:37 -0700227 except subprocess2.CalledProcessError as e:
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +0900228 logging.debug('Failed running %s', ['git'] + args)
Edward Lemur79d4f992019-11-11 23:49:02 +0000229 return e.returncode, e.stdout.decode('utf-8', 'replace')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000230
231
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000232def RunGitSilent(args):
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +0000233 """Returns stdout, suppresses stderr and ignores the return code."""
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000234 return RunGitWithCode(args, suppress_stderr=True)[1]
235
236
tandrii2a16b952016-10-19 07:09:44 -0700237def time_sleep(seconds):
238 # Use this so that it can be mocked in tests without interfering with python
239 # system machinery.
tandrii2a16b952016-10-19 07:09:44 -0700240 return time.sleep(seconds)
241
242
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000243def time_time():
244 # Use this so that it can be mocked in tests without interfering with python
245 # system machinery.
246 return time.time()
247
248
Edward Lemur1b52d872019-05-09 21:12:12 +0000249def datetime_now():
250 # Use this so that it can be mocked in tests without interfering with python
251 # system machinery.
252 return datetime.datetime.now()
253
254
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100255def confirm_or_exit(prefix='', action='confirm'):
256 """Asks user to press enter to continue or press Ctrl+C to abort."""
257 if not prefix or prefix.endswith('\n'):
258 mid = 'Press'
Andrii Shyshkalov353637c2017-03-14 16:52:18 +0100259 elif prefix.endswith('.') or prefix.endswith('?'):
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100260 mid = ' Press'
261 elif prefix.endswith(' '):
262 mid = 'press'
263 else:
264 mid = ' press'
Edward Lesmesae3586b2020-03-23 21:21:14 +0000265 gclient_utils.AskForData(
266 '%s%s Enter to %s, or Ctrl+C to abort' % (prefix, mid, action))
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100267
268
269def ask_for_explicit_yes(prompt):
Quinten Yearsleyd242ed72019-07-25 17:17:55 +0000270 """Returns whether user typed 'y' or 'yes' to confirm the given prompt."""
Edward Lesmesae3586b2020-03-23 21:21:14 +0000271 result = gclient_utils.AskForData(prompt + ' [Yes/No]: ').lower()
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100272 while True:
273 if 'yes'.startswith(result):
274 return True
275 if 'no'.startswith(result):
276 return False
Edward Lesmesae3586b2020-03-23 21:21:14 +0000277 result = gclient_utils.AskForData('Please, type yes or no: ').lower()
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100278
279
machenbach@chromium.org45453142015-09-15 08:45:22 +0000280def _get_properties_from_options(options):
Quinten Yearsleya19d3532019-09-30 21:54:39 +0000281 prop_list = getattr(options, 'properties', [])
282 properties = dict(x.split('=', 1) for x in prop_list)
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +0000283 for key, val in properties.items():
machenbach@chromium.org45453142015-09-15 08:45:22 +0000284 try:
285 properties[key] = json.loads(val)
286 except ValueError:
287 pass # If a value couldn't be evaluated, treat it as a string.
288 return properties
289
290
Edward Lemur4c707a22019-09-24 21:13:43 +0000291def _call_buildbucket(http, buildbucket_host, method, request):
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000292 """Calls a buildbucket v2 method and returns the parsed json response."""
293 headers = {
294 'Accept': 'application/json',
295 'Content-Type': 'application/json',
296 }
297 request = json.dumps(request)
298 url = 'https://%s/prpc/buildbucket.v2.Builds/%s' % (buildbucket_host, method)
299
300 logging.info('POST %s with %s' % (url, request))
301
302 attempts = 1
303 time_to_sleep = 1
304 while True:
305 response, content = http.request(url, 'POST', body=request, headers=headers)
306 if response.status == 200:
307 return json.loads(content[4:])
308 if attempts >= MAX_ATTEMPTS or 400 <= response.status < 500:
309 msg = '%s error when calling POST %s with %s: %s' % (
310 response.status, url, request, content)
311 raise BuildbucketResponseException(msg)
312 logging.debug(
313 '%s error when calling POST %s with %s. '
314 'Sleeping for %d seconds and retrying...' % (
315 response.status, url, request, time_to_sleep))
316 time.sleep(time_to_sleep)
317 time_to_sleep *= 2
318 attempts += 1
319
320 assert False, 'unreachable'
321
322
Edward Lemur6215c792019-10-03 21:59:05 +0000323def _parse_bucket(raw_bucket):
324 legacy = True
325 project = bucket = None
326 if '/' in raw_bucket:
327 legacy = False
328 project, bucket = raw_bucket.split('/', 1)
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000329 # Assume luci.<project>.<bucket>.
Edward Lemur6215c792019-10-03 21:59:05 +0000330 elif raw_bucket.startswith('luci.'):
331 project, bucket = raw_bucket[len('luci.'):].split('.', 1)
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000332 # Otherwise, assume prefix is also the project name.
Edward Lemur6215c792019-10-03 21:59:05 +0000333 elif '.' in raw_bucket:
334 project = raw_bucket.split('.')[0]
335 bucket = raw_bucket
336 # Legacy buckets.
Edward Lemur45768512020-03-02 19:03:14 +0000337 if legacy and project and bucket:
Edward Lemur6215c792019-10-03 21:59:05 +0000338 print('WARNING Please use %s/%s to specify the bucket.' % (project, bucket))
339 return project, bucket
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000340
341
Garrett Beaty08bb5c42022-09-21 17:34:20 +0000342def _canonical_git_googlesource_host(host):
343 """Normalizes Gerrit hosts (with '-review') to Git host."""
344 assert host.endswith(_GOOGLESOURCE)
345 # Prefix doesn't include '.' at the end.
346 prefix = host[:-(1 + len(_GOOGLESOURCE))]
347 if prefix.endswith('-review'):
348 prefix = prefix[:-len('-review')]
349 return prefix + '.' + _GOOGLESOURCE
350
351
352def _canonical_gerrit_googlesource_host(host):
353 git_host = _canonical_git_googlesource_host(host)
354 prefix = git_host.split('.', 1)[0]
355 return prefix + '-review.' + _GOOGLESOURCE
356
357
358def _get_counterpart_host(host):
359 assert host.endswith(_GOOGLESOURCE)
360 git = _canonical_git_googlesource_host(host)
361 gerrit = _canonical_gerrit_googlesource_host(git)
362 return git if gerrit == host else gerrit
363
364
Quinten Yearsley777660f2020-03-04 23:37:06 +0000365def _trigger_tryjobs(changelist, jobs, options, patchset):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000366 """Sends a request to Buildbucket to trigger tryjobs for a changelist.
qyearsley1fdfcb62016-10-24 13:22:03 -0700367
368 Args:
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000369 changelist: Changelist that the tryjobs are associated with.
Edward Lemur45768512020-03-02 19:03:14 +0000370 jobs: A list of (project, bucket, builder).
qyearsley1fdfcb62016-10-24 13:22:03 -0700371 options: Command-line options.
372 """
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000373 print('Scheduling jobs on:')
Edward Lemur45768512020-03-02 19:03:14 +0000374 for project, bucket, builder in jobs:
375 print(' %s/%s: %s' % (project, bucket, builder))
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000376 print('To see results here, run: git cl try-results')
377 print('To see results in browser, run: git cl web')
tandriide281ae2016-10-12 06:02:30 -0700378
Quinten Yearsley777660f2020-03-04 23:37:06 +0000379 requests = _make_tryjob_schedule_requests(changelist, jobs, options, patchset)
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +0000380 if not requests:
381 return
382
Edward Lemur5b929a42019-10-21 17:57:39 +0000383 http = auth.Authenticator().authorize(httplib2.Http())
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +0000384 http.force_exception_to_status_code = True
385
386 batch_request = {'requests': requests}
Joanna Wanga8db0cb2023-01-24 15:43:17 +0000387 batch_response = _call_buildbucket(http, DEFAULT_BUILDBUCKET_HOST, 'Batch',
388 batch_request)
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +0000389
390 errors = [
391 ' ' + response['error']['message']
392 for response in batch_response.get('responses', [])
393 if 'error' in response
394 ]
395 if errors:
396 raise BuildbucketResponseException(
397 'Failed to schedule builds for some bots:\n%s' % '\n'.join(errors))
398
399
Quinten Yearsley777660f2020-03-04 23:37:06 +0000400def _make_tryjob_schedule_requests(changelist, jobs, options, patchset):
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +0000401 """Constructs requests for Buildbucket to trigger tryjobs."""
Edward Lemurf0faf482019-09-25 20:40:17 +0000402 gerrit_changes = [changelist.GetGerritChange(patchset)]
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +0000403 shared_properties = {
404 'category': options.ensure_value('category', 'git_cl_try')
405 }
406 if options.ensure_value('clobber', False):
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000407 shared_properties['clobber'] = True
408 shared_properties.update(_get_properties_from_options(options) or {})
409
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +0000410 shared_tags = [{'key': 'user_agent', 'value': 'git_cl_try'}]
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +0000411 if options.ensure_value('retry_failed', False):
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +0000412 shared_tags.append({'key': 'retry_failed',
413 'value': '1'})
414
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000415 requests = []
Edward Lemur45768512020-03-02 19:03:14 +0000416 for (project, bucket, builder) in jobs:
417 properties = shared_properties.copy()
418 if 'presubmit' in builder.lower():
419 properties['dry_run'] = 'true'
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000420
Edward Lemur45768512020-03-02 19:03:14 +0000421 requests.append({
422 'scheduleBuild': {
423 'requestId': str(uuid.uuid4()),
424 'builder': {
425 'project': getattr(options, 'project', None) or project,
426 'bucket': bucket,
427 'builder': builder,
428 },
429 'gerritChanges': gerrit_changes,
430 'properties': properties,
431 'tags': [
432 {'key': 'builder', 'value': builder},
433 ] + shared_tags,
434 }
435 })
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000436
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +0000437 if options.ensure_value('revision', None):
Josip Sokcevic9011a5b2021-02-12 18:59:44 +0000438 remote, remote_branch = changelist.GetRemoteBranch()
Edward Lemur45768512020-03-02 19:03:14 +0000439 requests[-1]['scheduleBuild']['gitilesCommit'] = {
Garrett Beaty08bb5c42022-09-21 17:34:20 +0000440 'host': _canonical_git_googlesource_host(gerrit_changes[0]['host']),
Edward Lemur45768512020-03-02 19:03:14 +0000441 'project': gerrit_changes[0]['project'],
Josip Sokcevic9011a5b2021-02-12 18:59:44 +0000442 'id': options.revision,
443 'ref': GetTargetRef(remote, remote_branch, None)
Garrett Beaty08bb5c42022-09-21 17:34:20 +0000444 }
Anthony Polito1a5fe232020-01-24 23:17:52 +0000445
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +0000446 return requests
kjellander@chromium.org44424542015-06-02 18:35:29 +0000447
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000448
Quinten Yearsley777660f2020-03-04 23:37:06 +0000449def _fetch_tryjobs(changelist, buildbucket_host, patchset=None):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000450 """Fetches tryjobs from buildbucket.
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000451
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000452 Returns list of buildbucket.v2.Build with the try jobs for the changelist.
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000453 """
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +0000454 fields = ['id', 'builder', 'status', 'createTime', 'tags']
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000455 request = {
456 'predicate': {
457 'gerritChanges': [changelist.GetGerritChange(patchset)],
458 },
459 'fields': ','.join('builds.*.' + field for field in fields),
460 }
tandrii221ab252016-10-06 08:12:04 -0700461
Edward Lemur5b929a42019-10-21 17:57:39 +0000462 authenticator = auth.Authenticator()
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000463 if authenticator.has_cached_credentials():
464 http = authenticator.authorize(httplib2.Http())
465 else:
vapiera7fbd5a2016-06-16 09:17:49 -0700466 print('Warning: Some results might be missing because %s' %
467 # Get the message on how to login.
Andrii Shyshkalov2517afd2021-01-19 17:07:43 +0000468 (str(auth.LoginRequiredError()),))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000469 http = httplib2.Http()
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000470 http.force_exception_to_status_code = True
471
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000472 response = _call_buildbucket(http, buildbucket_host, 'SearchBuilds', request)
473 return response.get('builds', [])
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000474
Edward Lemur45768512020-03-02 19:03:14 +0000475
Edward Lemur5b929a42019-10-21 17:57:39 +0000476def _fetch_latest_builds(changelist, buildbucket_host, latest_patchset=None):
Quinten Yearsley983111f2019-09-26 17:18:48 +0000477 """Fetches builds from the latest patchset that has builds (within
478 the last few patchsets).
479
480 Args:
Quinten Yearsley983111f2019-09-26 17:18:48 +0000481 changelist (Changelist): The CL to fetch builds for
482 buildbucket_host (str): Buildbucket host, e.g. "cr-buildbucket.appspot.com"
Andrii Shyshkalov1ad58112019-10-08 01:46:14 +0000483 lastest_patchset(int|NoneType): the patchset to start fetching builds from.
484 If None (default), starts with the latest available patchset.
Quinten Yearsley983111f2019-09-26 17:18:48 +0000485 Returns:
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000486 A tuple (builds, patchset) where builds is a list of buildbucket.v2.Build,
487 and patchset is the patchset number where those builds came from.
Quinten Yearsley983111f2019-09-26 17:18:48 +0000488 """
489 assert buildbucket_host
490 assert changelist.GetIssue(), 'CL must be uploaded first'
491 assert changelist.GetCodereviewServer(), 'CL must be uploaded first'
Andrii Shyshkalov1ad58112019-10-08 01:46:14 +0000492 if latest_patchset is None:
493 assert changelist.GetMostRecentPatchset()
494 ps = changelist.GetMostRecentPatchset()
495 else:
496 assert latest_patchset > 0, latest_patchset
497 ps = latest_patchset
498
Quinten Yearsley983111f2019-09-26 17:18:48 +0000499 min_ps = max(1, ps - 5)
500 while ps >= min_ps:
Quinten Yearsley777660f2020-03-04 23:37:06 +0000501 builds = _fetch_tryjobs(changelist, buildbucket_host, patchset=ps)
Quinten Yearsley983111f2019-09-26 17:18:48 +0000502 if len(builds):
503 return builds, ps
504 ps -= 1
505 return [], 0
506
507
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +0000508def _filter_failed_for_retry(all_builds):
509 """Returns a list of buckets/builders that are worth retrying.
Quinten Yearsley983111f2019-09-26 17:18:48 +0000510
511 Args:
Quinten Yearsley777660f2020-03-04 23:37:06 +0000512 all_builds (list): Builds, in the format returned by _fetch_tryjobs,
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000513 i.e. a list of buildbucket.v2.Builds which includes status and builder
514 info.
Quinten Yearsley983111f2019-09-26 17:18:48 +0000515
516 Returns:
Edward Lemur45768512020-03-02 19:03:14 +0000517 A dict {(proj, bucket): [builders]}. This is the same format accepted by
Quinten Yearsley777660f2020-03-04 23:37:06 +0000518 _trigger_tryjobs.
Quinten Yearsley983111f2019-09-26 17:18:48 +0000519 """
Edward Lemur45768512020-03-02 19:03:14 +0000520 grouped = {}
521 for build in all_builds:
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +0000522 builder = build['builder']
Edward Lemur45768512020-03-02 19:03:14 +0000523 key = (builder['project'], builder['bucket'], builder['builder'])
524 grouped.setdefault(key, []).append(build)
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +0000525
Edward Lemur45768512020-03-02 19:03:14 +0000526 jobs = []
527 for (project, bucket, builder), builds in grouped.items():
528 if 'triggered' in builder:
529 print('WARNING: Not scheduling %s. Triggered bots require an initial job '
530 'from a parent. Please schedule a manual job for the parent '
531 'instead.')
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +0000532 continue
533 if any(b['status'] in ('STARTED', 'SCHEDULED') for b in builds):
534 # Don't retry if any are running.
535 continue
Edward Lemur45768512020-03-02 19:03:14 +0000536 # If builder had several builds, retry only if the last one failed.
537 # This is a bit different from CQ, which would re-use *any* SUCCESS-full
538 # build, but in case of retrying failed jobs retrying a flaky one makes
539 # sense.
540 builds = sorted(builds, key=lambda b: b['createTime'])
541 if builds[-1]['status'] not in ('FAILURE', 'INFRA_FAILURE'):
542 continue
543 # Don't retry experimental build previously triggered by CQ.
544 if any(t['key'] == 'cq_experimental' and t['value'] == 'true'
545 for t in builds[-1]['tags']):
546 continue
547 jobs.append((project, bucket, builder))
548
549 # Sort the jobs to make testing easier.
550 return sorted(jobs)
Quinten Yearsley983111f2019-09-26 17:18:48 +0000551
552
Quinten Yearsley777660f2020-03-04 23:37:06 +0000553def _print_tryjobs(options, builds):
554 """Prints nicely result of _fetch_tryjobs."""
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000555 if not builds:
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000556 print('No tryjobs scheduled.')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000557 return
558
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000559 longest_builder = max(len(b['builder']['builder']) for b in builds)
560 name_fmt = '{builder:<%d}' % longest_builder
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000561 if options.print_master:
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000562 longest_bucket = max(len(b['builder']['bucket']) for b in builds)
563 name_fmt = ('{bucket:>%d} ' % longest_bucket) + name_fmt
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000564
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000565 builds_by_status = {}
566 for b in builds:
567 builds_by_status.setdefault(b['status'], []).append({
568 'id': b['id'],
569 'name': name_fmt.format(
570 builder=b['builder']['builder'], bucket=b['builder']['bucket']),
571 })
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000572
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000573 sort_key = lambda b: (b['name'], b['id'])
574
575 def print_builds(title, builds, fmt=None, color=None):
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000576 """Pop matching builds from `builds` dict and print them."""
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000577 if not builds:
578 return
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000579
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000580 fmt = fmt or '{name} https://ci.chromium.org/b/{id}'
tandrii@chromium.org6cf98c82016-03-15 11:56:00 +0000581 if not options.color or color is None:
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000582 colorize = lambda x: x
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000583 else:
584 colorize = lambda x: '%s%s%s' % (color, x, Fore.RESET)
585
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000586 print(colorize(title))
587 for b in sorted(builds, key=sort_key):
588 print(' ', colorize(fmt.format(**b)))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000589
590 total = len(builds)
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000591 print_builds(
592 'Successes:', builds_by_status.pop('SUCCESS', []), color=Fore.GREEN)
593 print_builds(
594 'Infra Failures:', builds_by_status.pop('INFRA_FAILURE', []),
595 color=Fore.MAGENTA)
596 print_builds('Failures:', builds_by_status.pop('FAILURE', []), color=Fore.RED)
597 print_builds('Canceled:', builds_by_status.pop('CANCELED', []), fmt='{name}',
598 color=Fore.MAGENTA)
Andrii Shyshkalov792630c2020-10-19 16:47:44 +0000599 print_builds('Started:', builds_by_status.pop('STARTED', []),
600 color=Fore.YELLOW)
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000601 print_builds(
602 'Scheduled:', builds_by_status.pop('SCHEDULED', []), fmt='{name} id={id}')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000603 # The last section is just in case buildbucket API changes OR there is a bug.
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000604 print_builds(
605 'Other:', sum(builds_by_status.values(), []), fmt='{name} id={id}')
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000606 print('Total: %d tryjobs' % total)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000607
608
Aiden Bennerc08566e2018-10-03 17:52:42 +0000609def _ComputeDiffLineRanges(files, upstream_commit):
610 """Gets the changed line ranges for each file since upstream_commit.
611
612 Parses a git diff on provided files and returns a dict that maps a file name
613 to an ordered list of range tuples in the form (start_line, count).
614 Ranges are in the same format as a git diff.
615 """
616 # If files is empty then diff_output will be a full diff.
617 if len(files) == 0:
618 return {}
619
Aiden Benner6c18a1a2018-11-23 20:18:23 +0000620 # Take the git diff and find the line ranges where there are changes.
Jamie Madill3671a6a2019-10-24 15:13:21 +0000621 diff_cmd = BuildGitDiffCmd('-U0', upstream_commit, files, allow_prefix=True)
Aiden Bennerc08566e2018-10-03 17:52:42 +0000622 diff_output = RunGit(diff_cmd)
623
624 pattern = r'(?:^diff --git a/(?:.*) b/(.*))|(?:^@@.*\+(.*) @@)'
625 # 2 capture groups
626 # 0 == fname of diff file
627 # 1 == 'diff_start,diff_count' or 'diff_start'
628 # will match each of
629 # diff --git a/foo.foo b/foo.py
630 # @@ -12,2 +14,3 @@
631 # @@ -12,2 +17 @@
632 # running re.findall on the above string with pattern will give
633 # [('foo.py', ''), ('', '14,3'), ('', '17')]
634
635 curr_file = None
636 line_diffs = {}
637 for match in re.findall(pattern, diff_output, flags=re.MULTILINE):
638 if match[0] != '':
639 # Will match the second filename in diff --git a/a.py b/b.py.
640 curr_file = match[0]
641 line_diffs[curr_file] = []
642 else:
643 # Matches +14,3
644 if ',' in match[1]:
645 diff_start, diff_count = match[1].split(',')
646 else:
647 # Single line changes are of the form +12 instead of +12,1.
648 diff_start = match[1]
649 diff_count = 1
650
651 diff_start = int(diff_start)
652 diff_count = int(diff_count)
653
654 # If diff_count == 0 this is a removal we can ignore.
655 line_diffs[curr_file].append((diff_start, diff_count))
656
657 return line_diffs
658
659
Aiden Benner99b0ccb2018-11-20 19:53:31 +0000660def _FindYapfConfigFile(fpath, yapf_config_cache, top_dir=None):
Aiden Bennerc08566e2018-10-03 17:52:42 +0000661 """Checks if a yapf file is in any parent directory of fpath until top_dir.
662
Aiden Benner99b0ccb2018-11-20 19:53:31 +0000663 Recursively checks parent directories to find yapf file and if no yapf file
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000664 is found returns None. Uses yapf_config_cache as a cache for previously found
665 configs.
Aiden Bennerc08566e2018-10-03 17:52:42 +0000666 """
Aiden Benner99b0ccb2018-11-20 19:53:31 +0000667 fpath = os.path.abspath(fpath)
Aiden Bennerc08566e2018-10-03 17:52:42 +0000668 # Return result if we've already computed it.
669 if fpath in yapf_config_cache:
670 return yapf_config_cache[fpath]
671
Aiden Benner99b0ccb2018-11-20 19:53:31 +0000672 parent_dir = os.path.dirname(fpath)
673 if os.path.isfile(fpath):
674 ret = _FindYapfConfigFile(parent_dir, yapf_config_cache, top_dir)
Aiden Bennerc08566e2018-10-03 17:52:42 +0000675 else:
Aiden Benner99b0ccb2018-11-20 19:53:31 +0000676 # Otherwise fpath is a directory
677 yapf_file = os.path.join(fpath, YAPF_CONFIG_FILENAME)
678 if os.path.isfile(yapf_file):
679 ret = yapf_file
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +0000680 elif fpath in (top_dir, parent_dir):
Aiden Benner99b0ccb2018-11-20 19:53:31 +0000681 # If we're at the top level directory, or if we're at root
682 # there is no provided style.
683 ret = None
684 else:
685 # Otherwise recurse on the current directory.
686 ret = _FindYapfConfigFile(parent_dir, yapf_config_cache, top_dir)
Aiden Bennerc08566e2018-10-03 17:52:42 +0000687 yapf_config_cache[fpath] = ret
688 return ret
689
690
Brian Sheedyb4307d52019-12-02 19:18:17 +0000691def _GetYapfIgnorePatterns(top_dir):
692 """Returns all patterns in the .yapfignore file.
Brian Sheedy59b06a82019-10-14 17:03:29 +0000693
694 yapf is supposed to handle the ignoring of files listed in .yapfignore itself,
695 but this functionality appears to break when explicitly passing files to
696 yapf for formatting. According to
Josip Sokcevicc39ab992020-09-24 20:09:15 +0000697 https://github.com/google/yapf/blob/HEAD/README.rst#excluding-files-from-formatting-yapfignore,
Brian Sheedy59b06a82019-10-14 17:03:29 +0000698 the .yapfignore file should be in the directory that yapf is invoked from,
699 which we assume to be the top level directory in this case.
700
701 Args:
702 top_dir: The top level directory for the repository being formatted.
703
704 Returns:
Brian Sheedyb4307d52019-12-02 19:18:17 +0000705 A set of all fnmatch patterns to be ignored.
Brian Sheedy59b06a82019-10-14 17:03:29 +0000706 """
707 yapfignore_file = os.path.join(top_dir, '.yapfignore')
Brian Sheedyb4307d52019-12-02 19:18:17 +0000708 ignore_patterns = set()
Brian Sheedy59b06a82019-10-14 17:03:29 +0000709 if not os.path.exists(yapfignore_file):
Brian Sheedyb4307d52019-12-02 19:18:17 +0000710 return ignore_patterns
Brian Sheedy59b06a82019-10-14 17:03:29 +0000711
Anthony Politoc64e3902021-04-30 21:55:25 +0000712 for line in gclient_utils.FileRead(yapfignore_file).split('\n'):
713 stripped_line = line.strip()
714 # Comments and blank lines should be ignored.
715 if stripped_line.startswith('#') or stripped_line == '':
716 continue
717 ignore_patterns.add(stripped_line)
Brian Sheedyb4307d52019-12-02 19:18:17 +0000718 return ignore_patterns
719
720
721def _FilterYapfIgnoredFiles(filepaths, patterns):
722 """Filters out any filepaths that match any of the given patterns.
723
724 Args:
725 filepaths: An iterable of strings containing filepaths to filter.
726 patterns: An iterable of strings containing fnmatch patterns to filter on.
727
728 Returns:
729 A list of strings containing all the elements of |filepaths| that did not
730 match any of the patterns in |patterns|.
731 """
732 # Not inlined so that tests can use the same implementation.
733 return [f for f in filepaths
734 if not any(fnmatch.fnmatch(f, p) for p in patterns)]
Brian Sheedy59b06a82019-10-14 17:03:29 +0000735
736
Aaron Gable13101a62018-02-09 13:20:41 -0800737def print_stats(args):
maruel@chromium.org49e3d802012-07-18 23:54:45 +0000738 """Prints statistics about the change to the user."""
739 # --no-ext-diff is broken in some versions of Git, so try to work around
740 # this by overriding the environment (but there is still a problem if the
741 # git config key "diff.external" is used).
thestig@chromium.org8b0553c2014-02-11 00:33:37 +0000742 env = GetNoGitPagerEnv()
maruel@chromium.org49e3d802012-07-18 23:54:45 +0000743 if 'GIT_EXTERNAL_DIFF' in env:
744 del env['GIT_EXTERNAL_DIFF']
iannucci@chromium.org79540052012-10-19 23:15:26 +0000745
maruel@chromium.org49e3d802012-07-18 23:54:45 +0000746 return subprocess2.call(
Aaron Gable13101a62018-02-09 13:20:41 -0800747 ['git', 'diff', '--no-ext-diff', '--stat', '-l100000', '-C50'] + args,
Edward Lemur0db01f02019-11-12 22:01:51 +0000748 env=env)
maruel@chromium.org49e3d802012-07-18 23:54:45 +0000749
750
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000751class BuildbucketResponseException(Exception):
752 pass
753
754
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000755class Settings(object):
756 def __init__(self):
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000757 self.cc = None
thestig@chromium.org7a54e812014-02-11 19:57:22 +0000758 self.root = None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000759 self.tree_status_url = None
760 self.viewvc_url = None
761 self.updated = False
ukai@chromium.orge8077812012-02-03 03:41:46 +0000762 self.is_gerrit = None
bauerb@chromium.org54b400c2016-01-14 10:08:25 +0000763 self.squash_gerrit_uploads = None
tandrii@chromium.org28253532016-04-14 13:46:56 +0000764 self.gerrit_skip_ensure_authenticated = None
jbroman@chromium.org615a2622013-05-03 13:20:14 +0000765 self.git_editor = None
Jamie Madilldc4d19e2019-10-24 21:50:02 +0000766 self.format_full_by_default = None
Sigurd Schneider1bfda8e2021-06-30 14:46:25 +0000767 self.is_status_commit_order_by_date = None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000768
Edward Lemur26964072020-02-19 19:18:51 +0000769 def _LazyUpdateIfNeeded(self):
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000770 """Updates the settings from a codereview.settings file, if available."""
Edward Lemur26964072020-02-19 19:18:51 +0000771 if self.updated:
772 return
pgervais@chromium.org87884cc2014-01-03 22:23:41 +0000773
Edward Lemur26964072020-02-19 19:18:51 +0000774 # The only value that actually changes the behavior is
775 # autoupdate = "false". Everything else means "true".
776 autoupdate = (
777 scm.GIT.GetConfig(self.GetRoot(), 'rietveld.autoupdate', '').lower())
778
779 cr_settings_file = FindCodereviewSettingsFile()
780 if autoupdate != 'false' and cr_settings_file:
781 LoadCodereviewSettingsFromFile(cr_settings_file)
782 cr_settings_file.close()
783
784 self.updated = True
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000785
thestig@chromium.org7a54e812014-02-11 19:57:22 +0000786 @staticmethod
787 def GetRelativeRoot():
Edward Lesmes50da7702020-03-30 19:23:43 +0000788 return scm.GIT.GetCheckoutRoot('.')
thestig@chromium.org8b0553c2014-02-11 00:33:37 +0000789
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000790 def GetRoot(self):
thestig@chromium.org7a54e812014-02-11 19:57:22 +0000791 if self.root is None:
792 self.root = os.path.abspath(self.GetRelativeRoot())
793 return self.root
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000794
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000795 def GetTreeStatusUrl(self, error_ok=False):
796 if not self.tree_status_url:
Edward Lemur26964072020-02-19 19:18:51 +0000797 self.tree_status_url = self._GetConfig('rietveld.tree-status-url')
798 if self.tree_status_url is None and not error_ok:
799 DieWithError(
800 'You must configure your tree status URL by running '
801 '"git cl config".')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000802 return self.tree_status_url
803
804 def GetViewVCUrl(self):
805 if not self.viewvc_url:
Edward Lemur26964072020-02-19 19:18:51 +0000806 self.viewvc_url = self._GetConfig('rietveld.viewvc-url')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000807 return self.viewvc_url
808
rmistry@google.com90752582014-01-14 21:04:50 +0000809 def GetBugPrefix(self):
Edward Lemur26964072020-02-19 19:18:51 +0000810 return self._GetConfig('rietveld.bug-prefix')
rmistry@google.com78948ed2015-07-08 23:09:57 +0000811
rmistry@google.com5626a922015-02-26 14:03:30 +0000812 def GetRunPostUploadHook(self):
Edward Lemur61ea3072018-12-01 00:34:36 +0000813 run_post_upload_hook = self._GetConfig(
Edward Lemur26964072020-02-19 19:18:51 +0000814 'rietveld.run-post-upload-hook')
rmistry@google.com5626a922015-02-26 14:03:30 +0000815 return run_post_upload_hook == "True"
816
Joanna Wangc8f23e22023-01-19 21:18:10 +0000817 def GetDefaultCCList(self):
818 return self._GetConfig('rietveld.cc')
819
Dirk Pranke6f0df682021-06-25 00:42:33 +0000820 def GetUsePython3(self):
821 return self._GetConfig('rietveld.use-python3')
822
bauerb@chromium.org54b400c2016-01-14 10:08:25 +0000823 def GetSquashGerritUploads(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000824 """Returns True if uploads to Gerrit should be squashed by default."""
bauerb@chromium.org54b400c2016-01-14 10:08:25 +0000825 if self.squash_gerrit_uploads is None:
Edward Lesmes4de54132020-05-05 19:41:33 +0000826 self.squash_gerrit_uploads = self.GetSquashGerritUploadsOverride()
827 if self.squash_gerrit_uploads is None:
Edward Lemur26964072020-02-19 19:18:51 +0000828 # Default is squash now (http://crbug.com/611892#c23).
829 self.squash_gerrit_uploads = self._GetConfig(
830 'gerrit.squash-uploads').lower() != 'false'
bauerb@chromium.org54b400c2016-01-14 10:08:25 +0000831 return self.squash_gerrit_uploads
832
Edward Lesmes4de54132020-05-05 19:41:33 +0000833 def GetSquashGerritUploadsOverride(self):
834 """Return True or False if codereview.settings should be overridden.
835
836 Returns None if no override has been defined.
837 """
838 # See also http://crbug.com/611892#c23
839 result = self._GetConfig('gerrit.override-squash-uploads').lower()
840 if result == 'true':
841 return True
842 if result == 'false':
843 return False
844 return None
845
Aleksey Khoroshilov35ef5ad2022-06-03 18:29:25 +0000846 def GetIsGerrit(self):
847 """Return True if gerrit.host is set."""
848 if self.is_gerrit is None:
849 self.is_gerrit = bool(self._GetConfig('gerrit.host', False))
850 return self.is_gerrit
851
tandrii@chromium.org28253532016-04-14 13:46:56 +0000852 def GetGerritSkipEnsureAuthenticated(self):
853 """Return True if EnsureAuthenticated should not be done for Gerrit
854 uploads."""
855 if self.gerrit_skip_ensure_authenticated is None:
Edward Lemur26964072020-02-19 19:18:51 +0000856 self.gerrit_skip_ensure_authenticated = self._GetConfig(
857 'gerrit.skip-ensure-authenticated').lower() == 'true'
tandrii@chromium.org28253532016-04-14 13:46:56 +0000858 return self.gerrit_skip_ensure_authenticated
859
jbroman@chromium.org615a2622013-05-03 13:20:14 +0000860 def GetGitEditor(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000861 """Returns the editor specified in the git config, or None if none is."""
jbroman@chromium.org615a2622013-05-03 13:20:14 +0000862 if self.git_editor is None:
Raul Tambre5a525872019-02-12 19:08:08 +0000863 # Git requires single quotes for paths with spaces. We need to replace
864 # them with double quotes for Windows to treat such paths as a single
865 # path.
Edward Lemur26964072020-02-19 19:18:51 +0000866 self.git_editor = self._GetConfig('core.editor').replace('\'', '"')
jbroman@chromium.org615a2622013-05-03 13:20:14 +0000867 return self.git_editor or None
868
thestig@chromium.org44202a22014-03-11 19:22:18 +0000869 def GetLintRegex(self):
Edward Lemur26964072020-02-19 19:18:51 +0000870 return self._GetConfig('rietveld.cpplint-regex', DEFAULT_LINT_REGEX)
thestig@chromium.org44202a22014-03-11 19:22:18 +0000871
872 def GetLintIgnoreRegex(self):
Edward Lemur26964072020-02-19 19:18:51 +0000873 return self._GetConfig(
874 'rietveld.cpplint-ignore-regex', DEFAULT_LINT_IGNORE_REGEX)
thestig@chromium.org44202a22014-03-11 19:22:18 +0000875
Jamie Madilldc4d19e2019-10-24 21:50:02 +0000876 def GetFormatFullByDefault(self):
877 if self.format_full_by_default is None:
Jamie Madillac6f6232021-07-07 20:54:08 +0000878 self._LazyUpdateIfNeeded()
Jamie Madilldc4d19e2019-10-24 21:50:02 +0000879 result = (
880 RunGit(['config', '--bool', 'rietveld.format-full-by-default'],
881 error_ok=True).strip())
882 self.format_full_by_default = (result == 'true')
883 return self.format_full_by_default
884
Sigurd Schneider1bfda8e2021-06-30 14:46:25 +0000885 def IsStatusCommitOrderByDate(self):
886 if self.is_status_commit_order_by_date is None:
887 result = (RunGit(['config', '--bool', 'cl.date-order'],
888 error_ok=True).strip())
889 self.is_status_commit_order_by_date = (result == 'true')
890 return self.is_status_commit_order_by_date
891
Edward Lemur26964072020-02-19 19:18:51 +0000892 def _GetConfig(self, key, default=''):
893 self._LazyUpdateIfNeeded()
894 return scm.GIT.GetConfig(self.GetRoot(), key, default)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000895
896
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +0000897class _CQState(object):
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +0000898 """Enum for states of CL with respect to CQ."""
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +0000899 NONE = 'none'
Greg Gutermanbe5fccd2021-06-14 17:58:20 +0000900 QUICK_RUN = 'quick_run'
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +0000901 DRY_RUN = 'dry_run'
902 COMMIT = 'commit'
903
Greg Gutermanbe5fccd2021-06-14 17:58:20 +0000904 ALL_STATES = [NONE, QUICK_RUN, DRY_RUN, COMMIT]
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +0000905
906
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000907class _ParsedIssueNumberArgument(object):
Edward Lemurf38bc172019-09-03 21:02:13 +0000908 def __init__(self, issue=None, patchset=None, hostname=None):
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000909 self.issue = issue
910 self.patchset = patchset
911 self.hostname = hostname
912
913 @property
914 def valid(self):
915 return self.issue is not None
916
917
Edward Lemurf38bc172019-09-03 21:02:13 +0000918def ParseIssueNumberArgument(arg):
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000919 """Parses the issue argument and returns _ParsedIssueNumberArgument."""
920 fail_result = _ParsedIssueNumberArgument()
921
Edward Lemur678a6842019-10-03 22:25:05 +0000922 if isinstance(arg, int):
923 return _ParsedIssueNumberArgument(issue=arg)
924 if not isinstance(arg, basestring):
925 return fail_result
926
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000927 if arg.isdigit():
Edward Lemurf38bc172019-09-03 21:02:13 +0000928 return _ParsedIssueNumberArgument(issue=int(arg))
Aaron Gableaee6c852017-06-26 12:49:01 -0700929
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000930 url = gclient_utils.UpgradeToHttps(arg)
Alex Turner30ae6372022-01-04 02:32:52 +0000931 if not url.startswith('http'):
932 return fail_result
Andrii Shyshkalov8aebb602020-04-16 22:10:27 +0000933 for gerrit_url, short_url in _KNOWN_GERRIT_TO_SHORT_URLS.items():
934 if url.startswith(short_url):
935 url = gerrit_url + url[len(short_url):]
936 break
937
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000938 try:
Edward Lemur79d4f992019-11-11 23:49:02 +0000939 parsed_url = urllib.parse.urlparse(url)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000940 except ValueError:
941 return fail_result
Andrii Shyshkalov28d840e2017-04-10 15:45:09 +0200942
Alex Turner30ae6372022-01-04 02:32:52 +0000943 # If "https://" was automatically added, fail if `arg` looks unlikely to be a
944 # URL.
945 if not arg.startswith('http') and '.' not in parsed_url.netloc:
946 return fail_result
947
Edward Lemur678a6842019-10-03 22:25:05 +0000948 # Gerrit's new UI is https://domain/c/project/+/<issue_number>[/[patchset]]
949 # But old GWT UI is https://domain/#/c/project/+/<issue_number>[/[patchset]]
950 # Short urls like https://domain/<issue_number> can be used, but don't allow
951 # specifying the patchset (you'd 404), but we allow that here.
952 if parsed_url.path == '/':
953 part = parsed_url.fragment
954 else:
955 part = parsed_url.path
956
957 match = re.match(
958 r'(/c(/.*/\+)?)?/(?P<issue>\d+)(/(?P<patchset>\d+)?/?)?$', part)
959 if not match:
960 return fail_result
961
962 issue = int(match.group('issue'))
963 patchset = match.group('patchset')
964 return _ParsedIssueNumberArgument(
965 issue=issue,
966 patchset=int(patchset) if patchset else None,
967 hostname=parsed_url.netloc)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000968
969
Andrii Shyshkalovb07575f2018-10-16 06:16:21 +0000970def _create_description_from_log(args):
971 """Pulls out the commit log to use as a base for the CL description."""
972 log_args = []
Bruce Dawson13acea32022-05-03 22:13:08 +0000973 if len(args) == 1 and args[0] == None:
974 # Handle the case where None is passed as the branch.
975 return ''
Andrii Shyshkalovb07575f2018-10-16 06:16:21 +0000976 if len(args) == 1 and not args[0].endswith('.'):
977 log_args = [args[0] + '..']
978 elif len(args) == 1 and args[0].endswith('...'):
979 log_args = [args[0][:-1]]
980 elif len(args) == 2:
981 log_args = [args[0] + '..' + args[1]]
982 else:
983 log_args = args[:] # Hope for the best!
Manh Nguyene3644862020-08-05 18:25:46 +0000984 return RunGit(['log', '--pretty=format:%B%n'] + log_args)
Andrii Shyshkalovb07575f2018-10-16 06:16:21 +0000985
986
Aaron Gablea45ee112016-11-22 15:14:38 -0800987class GerritChangeNotExists(Exception):
tandriic2405f52016-10-10 08:13:15 -0700988 def __init__(self, issue, url):
989 self.issue = issue
990 self.url = url
Aaron Gablea45ee112016-11-22 15:14:38 -0800991 super(GerritChangeNotExists, self).__init__()
tandriic2405f52016-10-10 08:13:15 -0700992
993 def __str__(self):
Aaron Gablea45ee112016-11-22 15:14:38 -0800994 return 'change %s at %s does not exist or you have no access to it' % (
tandriic2405f52016-10-10 08:13:15 -0700995 self.issue, self.url)
996
997
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +0100998_CommentSummary = collections.namedtuple(
Quinten Yearsley0e617c02019-02-20 00:37:03 +0000999 '_CommentSummary', ['date', 'message', 'sender', 'autogenerated',
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01001000 # TODO(tandrii): these two aren't known in Gerrit.
1001 'approval', 'disapproval'])
1002
1003
Joanna Wange8523912023-01-21 02:05:40 +00001004_NewUpload = collections.namedtuple('NewUpload', [
Joanna Wang40497912023-01-24 21:18:16 +00001005 'reviewers', 'ccs', 'commit_to_push', 'new_last_uploaded_commit', 'parent',
Joanna Wange8523912023-01-21 02:05:40 +00001006 'change_desc'
1007])
1008
1009
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001010class Changelist(object):
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001011 """Changelist works with one changelist in local branch.
1012
tandrii@chromium.org8930b3d2016-04-13 14:47:02 +00001013 Notes:
1014 * Not safe for concurrent multi-{thread,process} use.
1015 * Caches values from current branch. Therefore, re-use after branch change
tandrii5d48c322016-08-18 16:19:37 -07001016 with great care.
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001017 """
1018
Sigurd Schneider9abde8c2020-11-17 08:44:52 +00001019 def __init__(self,
1020 branchref=None,
1021 issue=None,
1022 codereview_host=None,
1023 commit_date=None):
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001024 """Create a new ChangeList instance.
1025
Edward Lemurf38bc172019-09-03 21:02:13 +00001026 **kwargs will be passed directly to Gerrit implementation.
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001027 """
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001028 # Poke settings so we get the "configure your server" message if necessary.
maruel@chromium.org379d07a2011-11-30 14:58:10 +00001029 global settings
1030 if not settings:
1031 # Happens when git_cl.py is used as a utility library.
1032 settings = Settings()
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001033
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001034 self.branchref = branchref
1035 if self.branchref:
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00001036 assert branchref.startswith('refs/heads/')
Edward Lemur85153282020-02-14 22:06:29 +00001037 self.branch = scm.GIT.ShortBranchName(self.branchref)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001038 else:
1039 self.branch = None
Sigurd Schneider9abde8c2020-11-17 08:44:52 +00001040 self.commit_date = commit_date
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001041 self.upstream_branch = None
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001042 self.lookedup_issue = False
1043 self.issue = issue or None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001044 self.description = None
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001045 self.lookedup_patchset = False
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001046 self.patchset = None
bauerb@chromium.orgae6df352011-04-06 17:40:39 +00001047 self.cc = None
Daniel Cheng7227d212017-11-17 08:12:37 -08001048 self.more_cc = []
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00001049 self._remote = None
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00001050 self._cached_remote_url = (False, None) # (is_cached, value)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00001051
Edward Lemur125d60a2019-09-13 18:25:41 +00001052 # Lazily cached values.
1053 self._gerrit_host = None # e.g. chromium-review.googlesource.com
1054 self._gerrit_server = None # e.g. https://chromium-review.googlesource.com
Edward Lesmese1576912021-02-16 21:53:34 +00001055 self._owners_client = None
Edward Lemur125d60a2019-09-13 18:25:41 +00001056 # Map from change number (issue) to its detail cache.
1057 self._detail_cache = {}
1058
1059 if codereview_host is not None:
1060 assert not codereview_host.startswith('https://'), codereview_host
1061 self._gerrit_host = codereview_host
1062 self._gerrit_server = 'https://%s' % codereview_host
bauerb@chromium.orgae6df352011-04-06 17:40:39 +00001063
Edward Lesmese1576912021-02-16 21:53:34 +00001064 @property
1065 def owners_client(self):
1066 if self._owners_client is None:
1067 remote, remote_branch = self.GetRemoteBranch()
1068 branch = GetTargetRef(remote, remote_branch, None)
1069 self._owners_client = owners_client.GetCodeOwnersClient(
Edward Lesmese1576912021-02-16 21:53:34 +00001070 host=self.GetGerritHost(),
1071 project=self.GetGerritProject(),
1072 branch=branch)
1073 return self._owners_client
1074
bauerb@chromium.orgae6df352011-04-06 17:40:39 +00001075 def GetCCList(self):
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001076 """Returns the users cc'd on this CL.
bauerb@chromium.orgae6df352011-04-06 17:40:39 +00001077
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001078 The return value is a string suitable for passing to git cl with the --cc
1079 flag.
bauerb@chromium.orgae6df352011-04-06 17:40:39 +00001080 """
1081 if self.cc is None:
Joanna Wangc8f23e22023-01-19 21:18:10 +00001082 base_cc = settings.GetDefaultCCList()
1083 more_cc = ','.join(self.more_cc)
1084 self.cc = ','.join(filter(None, (base_cc, more_cc))) or ''
bauerb@chromium.orgae6df352011-04-06 17:40:39 +00001085 return self.cc
1086
Daniel Cheng7227d212017-11-17 08:12:37 -08001087 def ExtendCC(self, more_cc):
1088 """Extends the list of users to cc on this CL based on the changed files."""
1089 self.more_cc.extend(more_cc)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001090
Sigurd Schneider9abde8c2020-11-17 08:44:52 +00001091 def GetCommitDate(self):
1092 """Returns the commit date as provided in the constructor"""
1093 return self.commit_date
1094
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001095 def GetBranch(self):
Josip Sokcevicc39ab992020-09-24 20:09:15 +00001096 """Returns the short branch name, e.g. 'main'."""
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001097 if not self.branch:
Edward Lemur85153282020-02-14 22:06:29 +00001098 branchref = scm.GIT.GetBranchRef(settings.GetRoot())
szager@chromium.orgd62c61f2014-10-20 22:33:21 +00001099 if not branchref:
1100 return None
1101 self.branchref = branchref
Edward Lemur85153282020-02-14 22:06:29 +00001102 self.branch = scm.GIT.ShortBranchName(self.branchref)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001103 return self.branch
1104
1105 def GetBranchRef(self):
Josip Sokcevicc39ab992020-09-24 20:09:15 +00001106 """Returns the full branch name, e.g. 'refs/heads/main'."""
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001107 self.GetBranch() # Poke the lazy loader.
1108 return self.branchref
1109
Edward Lemur85153282020-02-14 22:06:29 +00001110 def _GitGetBranchConfigValue(self, key, default=None):
1111 return scm.GIT.GetBranchConfig(
1112 settings.GetRoot(), self.GetBranch(), key, default)
tandrii5d48c322016-08-18 16:19:37 -07001113
Edward Lemur85153282020-02-14 22:06:29 +00001114 def _GitSetBranchConfigValue(self, key, value):
1115 action = 'set %s to %r' % (key, value)
1116 if not value:
1117 action = 'unset %s' % key
1118 assert self.GetBranch(), 'a branch is needed to ' + action
1119 return scm.GIT.SetBranchConfig(
1120 settings.GetRoot(), self.GetBranch(), key, value)
tandrii5d48c322016-08-18 16:19:37 -07001121
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001122 @staticmethod
1123 def FetchUpstreamTuple(branch):
pgervais@chromium.orgd6617f32013-11-19 00:34:54 +00001124 """Returns a tuple containing remote and remote ref,
Josip Sokcevicc39ab992020-09-24 20:09:15 +00001125 e.g. 'origin', 'refs/heads/main'
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001126 """
Edward Lemur15a9b8c2020-02-13 00:52:30 +00001127 remote, upstream_branch = scm.GIT.FetchUpstreamTuple(
1128 settings.GetRoot(), branch)
1129 if not remote or not upstream_branch:
1130 DieWithError(
1131 'Unable to determine default branch to diff against.\n'
Josip Sokcevicb038f722021-01-06 18:28:11 +00001132 'Verify this branch is set up to track another \n'
1133 '(via the --track argument to "git checkout -b ..."). \n'
1134 'or pass complete "git diff"-style arguments if supported, like\n'
1135 ' git cl upload origin/main\n')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001136
1137 return remote, upstream_branch
1138
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00001139 def GetCommonAncestorWithUpstream(self):
pgervais@chromium.org8ba38ff2015-06-11 21:41:25 +00001140 upstream_branch = self.GetUpstreamBranch()
Edward Lesmes50da7702020-03-30 19:23:43 +00001141 if not scm.GIT.IsValidRevision(settings.GetRoot(), upstream_branch):
pgervais@chromium.org8ba38ff2015-06-11 21:41:25 +00001142 DieWithError('The upstream for the current branch (%s) does not exist '
1143 'anymore.\nPlease fix it and try again.' % self.GetBranch())
iannucci@chromium.org9e849272014-04-04 00:31:55 +00001144 return git_common.get_or_create_merge_base(self.GetBranch(),
pgervais@chromium.org8ba38ff2015-06-11 21:41:25 +00001145 upstream_branch)
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00001146
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001147 def GetUpstreamBranch(self):
1148 if self.upstream_branch is None:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001149 remote, upstream_branch = self.FetchUpstreamTuple(self.GetBranch())
Raul Tambrefe1dbe12019-05-02 04:43:57 +00001150 if remote != '.':
mmoss@chromium.orge7585452014-08-24 01:41:11 +00001151 upstream_branch = upstream_branch.replace('refs/heads/',
1152 'refs/remotes/%s/' % remote)
1153 upstream_branch = upstream_branch.replace('refs/branch-heads/',
1154 'refs/remotes/branch-heads/')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001155 self.upstream_branch = upstream_branch
1156 return self.upstream_branch
1157
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001158 def GetRemoteBranch(self):
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001159 if not self._remote:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001160 remote, branch = None, self.GetBranch()
1161 seen_branches = set()
1162 while branch not in seen_branches:
1163 seen_branches.add(branch)
1164 remote, branch = self.FetchUpstreamTuple(branch)
Edward Lemur85153282020-02-14 22:06:29 +00001165 branch = scm.GIT.ShortBranchName(branch)
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001166 if remote != '.' or branch.startswith('refs/remotes'):
1167 break
1168 else:
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001169 remotes = RunGit(['remote'], error_ok=True).split()
1170 if len(remotes) == 1:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001171 remote, = remotes
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001172 elif 'origin' in remotes:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001173 remote = 'origin'
Gavin Make6a62332020-12-04 21:57:10 +00001174 logging.warning('Could not determine which remote this change is '
1175 'associated with, so defaulting to "%s".' %
1176 self._remote)
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001177 else:
Gavin Make6a62332020-12-04 21:57:10 +00001178 logging.warning('Could not determine which remote this change is '
1179 'associated with.')
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001180 branch = 'HEAD'
1181 if branch.startswith('refs/remotes'):
1182 self._remote = (remote, branch)
mmoss@chromium.orge7585452014-08-24 01:41:11 +00001183 elif branch.startswith('refs/branch-heads/'):
1184 self._remote = (remote, branch.replace('refs/', 'refs/remotes/'))
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001185 else:
1186 self._remote = (remote, 'refs/remotes/%s/%s' % (remote, branch))
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001187 return self._remote
1188
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001189 def GetRemoteUrl(self):
1190 """Return the configured remote URL, e.g. 'git://example.org/foo.git/'.
1191
1192 Returns None if there is no remote.
1193 """
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00001194 is_cached, value = self._cached_remote_url
1195 if is_cached:
1196 return value
1197
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001198 remote, _ = self.GetRemoteBranch()
Edward Lemur26964072020-02-19 19:18:51 +00001199 url = scm.GIT.GetConfig(settings.GetRoot(), 'remote.%s.url' % remote, '')
dyen@chromium.org2a13d4f2014-06-13 00:06:37 +00001200
Edward Lemur298f2cf2019-02-22 21:40:39 +00001201 # Check if the remote url can be parsed as an URL.
Edward Lemur79d4f992019-11-11 23:49:02 +00001202 host = urllib.parse.urlparse(url).netloc
Edward Lemur298f2cf2019-02-22 21:40:39 +00001203 if host:
1204 self._cached_remote_url = (True, url)
1205 return url
1206
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001207 # If it cannot be parsed as an url, assume it is a local directory,
1208 # probably a git cache.
Edward Lemur298f2cf2019-02-22 21:40:39 +00001209 logging.warning('"%s" doesn\'t appear to point to a git host. '
1210 'Interpreting it as a local directory.', url)
1211 if not os.path.isdir(url):
1212 logging.error(
Josip906bfde2020-01-31 22:38:49 +00001213 'Remote "%(remote)s" for branch "%(branch)s" points to "%(url)s", '
1214 'but it doesn\'t exist.',
1215 {'remote': remote, 'branch': self.GetBranch(), 'url': url})
Edward Lemur298f2cf2019-02-22 21:40:39 +00001216 return None
1217
1218 cache_path = url
Edward Lemur26964072020-02-19 19:18:51 +00001219 url = scm.GIT.GetConfig(url, 'remote.%s.url' % remote, '')
Edward Lemur298f2cf2019-02-22 21:40:39 +00001220
Edward Lemur79d4f992019-11-11 23:49:02 +00001221 host = urllib.parse.urlparse(url).netloc
Edward Lemur298f2cf2019-02-22 21:40:39 +00001222 if not host:
1223 logging.error(
1224 'Remote "%(remote)s" for branch "%(branch)s" points to '
1225 '"%(cache_path)s", but it is misconfigured.\n'
1226 '"%(cache_path)s" must be a git repo and must have a remote named '
1227 '"%(remote)s" pointing to the git host.', {
1228 'remote': remote,
1229 'cache_path': cache_path,
1230 'branch': self.GetBranch()})
1231 return None
1232
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00001233 self._cached_remote_url = (True, url)
dyen@chromium.org2a13d4f2014-06-13 00:06:37 +00001234 return url
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001235
tandrii@chromium.org87985d22016-03-24 17:33:33 +00001236 def GetIssue(self):
maruel@chromium.org52424302012-08-29 15:14:30 +00001237 """Returns the issue number as a int or None if not set."""
tandrii@chromium.org87985d22016-03-24 17:33:33 +00001238 if self.issue is None and not self.lookedup_issue:
Bruce Dawson13acea32022-05-03 22:13:08 +00001239 if self.GetBranch():
1240 self.issue = self._GitGetBranchConfigValue(ISSUE_CONFIG_KEY)
Edward Lemur85153282020-02-14 22:06:29 +00001241 if self.issue is not None:
1242 self.issue = int(self.issue)
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001243 self.lookedup_issue = True
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001244 return self.issue
1245
Andrii Shyshkalov1ee78cd2020-03-12 01:31:53 +00001246 def GetIssueURL(self, short=False):
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001247 """Get the URL for a particular issue."""
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001248 issue = self.GetIssue()
1249 if not issue:
dbeam@chromium.org015fd3d2013-06-18 19:02:50 +00001250 return None
Andrii Shyshkalov1ee78cd2020-03-12 01:31:53 +00001251 server = self.GetCodereviewServer()
1252 if short:
1253 server = _KNOWN_GERRIT_TO_SHORT_URLS.get(server, server)
1254 return '%s/%s' % (server, issue)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001255
Dirk Pranke6f0df682021-06-25 00:42:33 +00001256 def GetUsePython3(self):
Josip Sokcevic340edc32021-07-08 17:01:46 +00001257 return settings.GetUsePython3()
Dirk Pranke6f0df682021-06-25 00:42:33 +00001258
Edward Lemur6c6827c2020-02-06 21:15:18 +00001259 def FetchDescription(self, pretty=False):
1260 assert self.GetIssue(), 'issue is required to query Gerrit'
1261
Edward Lemur9aa1a962020-02-25 00:58:38 +00001262 if self.description is None:
Edward Lemur6c6827c2020-02-06 21:15:18 +00001263 data = self._GetChangeDetail(['CURRENT_REVISION', 'CURRENT_COMMIT'])
1264 current_rev = data['current_revision']
1265 self.description = data['revisions'][current_rev]['commit']['message']
Edward Lemur6c6827c2020-02-06 21:15:18 +00001266
1267 if not pretty:
1268 return self.description
1269
1270 # Set width to 72 columns + 2 space indent.
1271 wrapper = textwrap.TextWrapper(width=74, replace_whitespace=True)
1272 wrapper.initial_indent = wrapper.subsequent_indent = ' '
1273 lines = self.description.splitlines()
1274 return '\n'.join([wrapper.fill(line) for line in lines])
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001275
1276 def GetPatchset(self):
maruel@chromium.org52424302012-08-29 15:14:30 +00001277 """Returns the patchset number as a int or None if not set."""
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001278 if self.patchset is None and not self.lookedup_patchset:
Bruce Dawson13acea32022-05-03 22:13:08 +00001279 if self.GetBranch():
1280 self.patchset = self._GitGetBranchConfigValue(PATCHSET_CONFIG_KEY)
Edward Lemur85153282020-02-14 22:06:29 +00001281 if self.patchset is not None:
1282 self.patchset = int(self.patchset)
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001283 self.lookedup_patchset = True
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001284 return self.patchset
1285
Edward Lemur9aa1a962020-02-25 00:58:38 +00001286 def GetAuthor(self):
1287 return scm.GIT.GetConfig(settings.GetRoot(), 'user.email')
1288
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001289 def SetPatchset(self, patchset):
tandrii5d48c322016-08-18 16:19:37 -07001290 """Set this branch's patchset. If patchset=0, clears the patchset."""
1291 assert self.GetBranch()
1292 if not patchset:
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001293 self.patchset = None
tandrii5d48c322016-08-18 16:19:37 -07001294 else:
1295 self.patchset = int(patchset)
Edward Lesmes50da7702020-03-30 19:23:43 +00001296 self._GitSetBranchConfigValue(PATCHSET_CONFIG_KEY, str(self.patchset))
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001297
tandrii@chromium.orga342c922016-03-16 07:08:25 +00001298 def SetIssue(self, issue=None):
tandrii5d48c322016-08-18 16:19:37 -07001299 """Set this branch's issue. If issue isn't given, clears the issue."""
1300 assert self.GetBranch()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001301 if issue:
tandrii5d48c322016-08-18 16:19:37 -07001302 issue = int(issue)
Edward Lesmes50da7702020-03-30 19:23:43 +00001303 self._GitSetBranchConfigValue(ISSUE_CONFIG_KEY, str(issue))
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001304 self.issue = issue
Edward Lemur125d60a2019-09-13 18:25:41 +00001305 codereview_server = self.GetCodereviewServer()
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001306 if codereview_server:
tandrii5d48c322016-08-18 16:19:37 -07001307 self._GitSetBranchConfigValue(
Edward Lesmes50da7702020-03-30 19:23:43 +00001308 CODEREVIEW_SERVER_CONFIG_KEY, codereview_server)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001309 else:
tandrii5d48c322016-08-18 16:19:37 -07001310 # Reset all of these just to be clean.
1311 reset_suffixes = [
Gavin Makbe2e9262022-11-08 23:41:55 +00001312 LAST_UPLOAD_HASH_CONFIG_KEY,
Edward Lesmes50da7702020-03-30 19:23:43 +00001313 ISSUE_CONFIG_KEY,
1314 PATCHSET_CONFIG_KEY,
1315 CODEREVIEW_SERVER_CONFIG_KEY,
Gavin Makbe2e9262022-11-08 23:41:55 +00001316 GERRIT_SQUASH_HASH_CONFIG_KEY,
Edward Lesmes50da7702020-03-30 19:23:43 +00001317 ]
tandrii5d48c322016-08-18 16:19:37 -07001318 for prop in reset_suffixes:
Edward Lemur85153282020-02-14 22:06:29 +00001319 try:
1320 self._GitSetBranchConfigValue(prop, None)
1321 except subprocess2.CalledProcessError:
1322 pass
Aaron Gableca01e2c2017-07-19 11:16:02 -07001323 msg = RunGit(['log', '-1', '--format=%B']).strip()
1324 if msg and git_footers.get_footer_change_id(msg):
1325 print('WARNING: The change patched into this branch has a Change-Id. '
1326 'Removing it.')
1327 RunGit(['commit', '--amend', '-m',
1328 git_footers.remove_footer(msg, 'Change-Id')])
Edward Lemurf38bc172019-09-03 21:02:13 +00001329 self.lookedup_issue = True
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001330 self.issue = None
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00001331 self.patchset = None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001332
Joanna Wangb46232e2023-01-21 01:58:46 +00001333 def GetAffectedFiles(self, upstream, end_commit=None):
1334 # type: (str, Optional[str]) -> Sequence[str]
1335 """Returns the list of affected files for the given commit range."""
maruel@chromium.org2b38e9c2011-10-19 00:04:35 +00001336 try:
Joanna Wangb46232e2023-01-21 01:58:46 +00001337 return [
1338 f for _, f in scm.GIT.CaptureStatus(
1339 settings.GetRoot(), upstream, end_commit=end_commit)
1340 ]
maruel@chromium.org2b38e9c2011-10-19 00:04:35 +00001341 except subprocess2.CalledProcessError:
1342 DieWithError(
pgervais@chromium.orgd6617f32013-11-19 00:34:54 +00001343 ('\nFailed to diff against upstream branch %s\n\n'
maruel@chromium.org2b38e9c2011-10-19 00:04:35 +00001344 'This branch probably doesn\'t exist anymore. To reset the\n'
1345 'tracking branch, please run\n'
Josip Sokcevicc39ab992020-09-24 20:09:15 +00001346 ' git branch --set-upstream-to origin/main %s\n'
1347 'or replace origin/main with the relevant branch') %
Edward Lemur2c62b332020-03-12 22:12:33 +00001348 (upstream, self.GetBranch()))
bauerb@chromium.org6fb99c62011-04-18 15:57:28 +00001349
dsansomee2d6fd92016-09-08 00:10:47 -07001350 def UpdateDescription(self, description, force=False):
Edward Lemur6c6827c2020-02-06 21:15:18 +00001351 assert self.GetIssue(), 'issue is required to update description'
1352
1353 if gerrit_util.HasPendingChangeEdit(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001354 self.GetGerritHost(), self._GerritChangeIdentifier()):
Edward Lemur6c6827c2020-02-06 21:15:18 +00001355 if not force:
1356 confirm_or_exit(
1357 'The description cannot be modified while the issue has a pending '
1358 'unpublished edit. Either publish the edit in the Gerrit web UI '
1359 'or delete it.\n\n', action='delete the unpublished edit')
1360
1361 gerrit_util.DeletePendingChangeEdit(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001362 self.GetGerritHost(), self._GerritChangeIdentifier())
Edward Lemur6c6827c2020-02-06 21:15:18 +00001363 gerrit_util.SetCommitMessage(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001364 self.GetGerritHost(), self._GerritChangeIdentifier(),
Edward Lemur6c6827c2020-02-06 21:15:18 +00001365 description, notify='NONE')
1366
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001367 self.description = description
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001368
Edward Lemur75526302020-02-27 22:31:05 +00001369 def _GetCommonPresubmitArgs(self, verbose, upstream):
Edward Lemur227d5102020-02-25 23:45:35 +00001370 args = [
Edward Lemur227d5102020-02-25 23:45:35 +00001371 '--root', settings.GetRoot(),
1372 '--upstream', upstream,
1373 ]
1374
1375 args.extend(['--verbose'] * verbose)
1376
Edward Lesmeseb1bd622021-03-01 19:54:07 +00001377 remote, remote_branch = self.GetRemoteBranch()
1378 target_ref = GetTargetRef(remote, remote_branch, None)
Aleksey Khoroshilov35ef5ad2022-06-03 18:29:25 +00001379 if settings.GetIsGerrit():
1380 args.extend(['--gerrit_url', self.GetCodereviewServer()])
1381 args.extend(['--gerrit_project', self.GetGerritProject()])
1382 args.extend(['--gerrit_branch', target_ref])
Edward Lesmeseb1bd622021-03-01 19:54:07 +00001383
Edward Lemur99df04e2020-03-05 19:39:43 +00001384 author = self.GetAuthor()
Edward Lemur227d5102020-02-25 23:45:35 +00001385 issue = self.GetIssue()
1386 patchset = self.GetPatchset()
Edward Lemur99df04e2020-03-05 19:39:43 +00001387 if author:
1388 args.extend(['--author', author])
Edward Lemur227d5102020-02-25 23:45:35 +00001389 if issue:
1390 args.extend(['--issue', str(issue)])
1391 if patchset:
1392 args.extend(['--patchset', str(patchset)])
Edward Lemur227d5102020-02-25 23:45:35 +00001393
Edward Lemur75526302020-02-27 22:31:05 +00001394 return args
1395
Josip Sokcevic017544d2022-03-31 23:47:53 +00001396 def RunHook(self,
1397 committing,
1398 may_prompt,
1399 verbose,
1400 parallel,
1401 upstream,
1402 description,
1403 all_files,
1404 files=None,
1405 resultdb=False,
1406 realm=None):
Edward Lemur75526302020-02-27 22:31:05 +00001407 """Calls sys.exit() if the hook fails; returns a HookResults otherwise."""
1408 args = self._GetCommonPresubmitArgs(verbose, upstream)
1409 args.append('--commit' if committing else '--upload')
Edward Lemur227d5102020-02-25 23:45:35 +00001410 if may_prompt:
1411 args.append('--may_prompt')
1412 if parallel:
1413 args.append('--parallel')
1414 if all_files:
1415 args.append('--all_files')
Josip Sokcevic017544d2022-03-31 23:47:53 +00001416 if files:
1417 args.extend(files.split(';'))
1418 args.append('--source_controlled_only')
Bruce Dawson09c0c072022-05-26 20:28:58 +00001419 if files or all_files:
1420 args.append('--no_diffs')
Edward Lemur227d5102020-02-25 23:45:35 +00001421
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001422 if resultdb and not realm:
1423 # TODO (crbug.com/1113463): store realm somewhere and look it up so
1424 # it is not required to pass the realm flag
1425 print('Note: ResultDB reporting will NOT be performed because --realm'
1426 ' was not specified. To enable ResultDB, please run the command'
1427 ' again with the --realm argument to specify the LUCI realm.')
1428
Joanna Wanga8db0cb2023-01-24 15:43:17 +00001429 py3_results = self._RunPresubmit(args,
1430 description,
1431 use_python3=True,
1432 resultdb=resultdb,
1433 realm=realm)
Josip Sokcevic632bbc02022-05-19 05:32:50 +00001434 if py3_results.get('skipped_presubmits', 1) == 0:
1435 print('No more presubmits to run - skipping Python 2 presubmits.')
1436 return py3_results
1437
Joanna Wanga8db0cb2023-01-24 15:43:17 +00001438 py2_results = self._RunPresubmit(args,
1439 description,
1440 use_python3=False,
1441 resultdb=resultdb,
1442 realm=realm)
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001443 return self._MergePresubmitResults(py2_results, py3_results)
1444
Joanna Wanga8db0cb2023-01-24 15:43:17 +00001445 def _RunPresubmit(self,
1446 args,
1447 description,
1448 use_python3,
1449 resultdb=None,
1450 realm=None):
1451 # type: (Sequence[str], str, bool, Optional[bool], Optional[str]
1452 # ) -> Mapping[str, Any]
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001453 args = args[:]
1454 vpython = 'vpython3' if use_python3 else 'vpython'
1455
Edward Lemur227d5102020-02-25 23:45:35 +00001456 with gclient_utils.temporary_file() as description_file:
1457 with gclient_utils.temporary_file() as json_output:
Edward Lemur1a83da12020-03-04 21:18:36 +00001458 gclient_utils.FileWrite(description_file, description)
Edward Lemur227d5102020-02-25 23:45:35 +00001459 args.extend(['--json_output', json_output])
1460 args.extend(['--description_file', description_file])
Dirk Pranke6f0df682021-06-25 00:42:33 +00001461 if self.GetUsePython3():
1462 args.append('--use-python3')
Edward Lemur227d5102020-02-25 23:45:35 +00001463 start = time_time()
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001464 cmd = [vpython, PRESUBMIT_SUPPORT] + args
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001465 if resultdb and realm:
1466 cmd = ['rdb', 'stream', '-new', '-realm', realm, '--'] + cmd
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00001467
1468 p = subprocess2.Popen(cmd)
Edward Lemur227d5102020-02-25 23:45:35 +00001469 exit_code = p.wait()
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00001470
Edward Lemur227d5102020-02-25 23:45:35 +00001471 metrics.collector.add_repeated('sub_commands', {
1472 'command': 'presubmit',
1473 'execution_time': time_time() - start,
1474 'exit_code': exit_code,
1475 })
1476
1477 if exit_code:
1478 sys.exit(exit_code)
1479
1480 json_results = gclient_utils.FileRead(json_output)
1481 return json.loads(json_results)
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001482
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001483 def _MergePresubmitResults(self, py2_results, py3_results):
1484 return {
1485 'more_cc': sorted(set(py2_results.get('more_cc', []) +
1486 py3_results.get('more_cc', []))),
1487 'errors': (
1488 py2_results.get('errors', []) + py3_results.get('errors', [])),
1489 'notifications': (
1490 py2_results.get('notifications', []) +
1491 py3_results.get('notifications', [])),
1492 'warnings': (
1493 py2_results.get('warnings', []) + py3_results.get('warnings', []))
1494 }
1495
Brian Sheedy7326ca22022-11-02 18:36:17 +00001496 def RunPostUploadHook(self, verbose, upstream, description, py3_only):
Edward Lemur75526302020-02-27 22:31:05 +00001497 args = self._GetCommonPresubmitArgs(verbose, upstream)
1498 args.append('--post_upload')
1499
1500 with gclient_utils.temporary_file() as description_file:
Edward Lemur1a83da12020-03-04 21:18:36 +00001501 gclient_utils.FileWrite(description_file, description)
Edward Lemur75526302020-02-27 22:31:05 +00001502 args.extend(['--description_file', description_file])
Brian Sheedy7326ca22022-11-02 18:36:17 +00001503 if not py3_only:
1504 p_py2 = subprocess2.Popen(['vpython', PRESUBMIT_SUPPORT] + args)
Josip Sokcevice293d3d2022-02-16 22:52:15 +00001505 p_py3 = subprocess2.Popen(['vpython3', PRESUBMIT_SUPPORT] + args +
1506 ['--use-python3'])
Brian Sheedy7326ca22022-11-02 18:36:17 +00001507 if not py3_only:
1508 p_py2.wait()
Josip Sokcevice293d3d2022-02-16 22:52:15 +00001509 p_py3.wait()
Edward Lemur75526302020-02-27 22:31:05 +00001510
Edward Lemur5a644f82020-03-18 16:44:57 +00001511 def _GetDescriptionForUpload(self, options, git_diff_args, files):
Joanna Wangb46232e2023-01-21 01:58:46 +00001512 # type: (optparse.Values, Sequence[str], Sequence[str]
1513 # ) -> ChangeDescription
1514 """Get description message for upload."""
Edward Lemur5a644f82020-03-18 16:44:57 +00001515 if self.GetIssue():
1516 description = self.FetchDescription()
1517 elif options.message:
1518 description = options.message
1519 else:
1520 description = _create_description_from_log(git_diff_args)
1521 if options.title and options.squash:
Edward Lesmes0dd54822020-03-26 18:24:25 +00001522 description = options.title + '\n\n' + description
Edward Lemur5a644f82020-03-18 16:44:57 +00001523
Edward Lemur5a644f82020-03-18 16:44:57 +00001524 bug = options.bug
1525 fixed = options.fixed
Josip Sokcevic340edc32021-07-08 17:01:46 +00001526 if not self.GetIssue():
1527 # Extract bug number from branch name, but only if issue is being created.
1528 # It must start with bug or fix, followed by _ or - and number.
1529 # Optionally, it may contain _ or - after number with arbitrary text.
1530 # Examples:
1531 # bug-123
1532 # bug_123
1533 # fix-123
1534 # fix-123-some-description
mlcui7a0b4cb2023-01-23 23:14:55 +00001535 branch = self.GetBranch()
1536 if branch is not None:
1537 match = re.match(
1538 r'^(?P<type>bug|fix(?:e[sd])?)[_-]?(?P<bugnum>\d+)([-_]|$)', branch)
1539 if not bug and not fixed and match:
1540 if match.group('type') == 'bug':
1541 bug = match.group('bugnum')
1542 else:
1543 fixed = match.group('bugnum')
Edward Lemur5a644f82020-03-18 16:44:57 +00001544
1545 change_description = ChangeDescription(description, bug, fixed)
1546
Joanna Wang39811b12023-01-20 23:09:48 +00001547 # Fill gaps in OWNERS coverage to reviewers if requested.
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001548 if options.add_owners_to:
Joanna Wang39811b12023-01-20 23:09:48 +00001549 assert options.add_owners_to in ('R'), options.add_owners_to
Edward Lesmese1576912021-02-16 21:53:34 +00001550 status = self.owners_client.GetFilesApprovalStatus(
Joanna Wang39811b12023-01-20 23:09:48 +00001551 files, [], options.reviewers)
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001552 missing_files = [
1553 f for f in files
Edward Lesmese1576912021-02-16 21:53:34 +00001554 if status[f] == self._owners_client.INSUFFICIENT_REVIEWERS
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001555 ]
Edward Lesmese1576912021-02-16 21:53:34 +00001556 owners = self.owners_client.SuggestOwners(
1557 missing_files, exclude=[self.GetAuthor()])
Joanna Wang39811b12023-01-20 23:09:48 +00001558 assert isinstance(options.reviewers, list), options.reviewers
1559 options.reviewers.extend(owners)
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001560
Edward Lemur5a644f82020-03-18 16:44:57 +00001561 # Set the reviewer list now so that presubmit checks can access it.
Joanna Wang39811b12023-01-20 23:09:48 +00001562 if options.reviewers:
1563 change_description.update_reviewers(options.reviewers)
Edward Lemur5a644f82020-03-18 16:44:57 +00001564
1565 return change_description
1566
Joanna Wanga1abbed2023-01-24 01:41:05 +00001567 def _GetTitleForUpload(self, options, multi_change_upload=False):
1568 # type: (optparse.Values, Optional[bool]) -> str
1569
1570 # Getting titles for multipl commits is not supported so we return the
1571 # default.
1572 if not options.squash or multi_change_upload or options.title:
Edward Lemur5a644f82020-03-18 16:44:57 +00001573 return options.title
1574
1575 # On first upload, patchset title is always this string, while options.title
1576 # gets converted to first line of message.
1577 if not self.GetIssue():
1578 return 'Initial upload'
1579
1580 # When uploading subsequent patchsets, options.message is taken as the title
1581 # if options.title is not provided.
Edward Lemur5a644f82020-03-18 16:44:57 +00001582 if options.message:
1583 return options.message.strip()
1584
1585 # Use the subject of the last commit as title by default.
Edward Lesmes50da7702020-03-30 19:23:43 +00001586 title = RunGit(['show', '-s', '--format=%s', 'HEAD']).strip()
Mario Bianuccicebfb4e2020-07-22 23:08:16 +00001587 if options.force or options.skip_title:
Edward Lemur5a644f82020-03-18 16:44:57 +00001588 return title
Edward Lesmesae3586b2020-03-23 21:21:14 +00001589 user_title = gclient_utils.AskForData('Title for patchset [%s]: ' % title)
mlcui3da91712021-05-05 10:00:30 +00001590
1591 # Use the default title if the user confirms the default with a 'y'.
1592 if user_title.lower() == 'y':
1593 return title
Edward Lesmesae3586b2020-03-23 21:21:14 +00001594 return user_title or title
Edward Lemur5a644f82020-03-18 16:44:57 +00001595
Joanna Wang562481d2023-01-26 21:57:14 +00001596 def _GetRefSpecOptions(self,
1597 options,
1598 change_desc,
1599 multi_change_upload=False,
1600 dogfood_path=False):
1601 # type: (optparse.Values, Sequence[Changelist], Optional[bool],
1602 # Optional[bool]) -> Sequence[str]
Joanna Wanga1abbed2023-01-24 01:41:05 +00001603
1604 # Extra options that can be specified at push time. Doc:
1605 # https://gerrit-review.googlesource.com/Documentation/user-upload.html
1606 refspec_opts = []
1607
1608 # By default, new changes are started in WIP mode, and subsequent patchsets
1609 # don't send email. At any time, passing --send-mail or --send-email will
1610 # mark the change ready and send email for that particular patch.
1611 if options.send_mail:
1612 refspec_opts.append('ready')
1613 refspec_opts.append('notify=ALL')
Joanna Wang562481d2023-01-26 21:57:14 +00001614 elif (not self.GetIssue() and options.squash and not dogfood_path):
Joanna Wanga1abbed2023-01-24 01:41:05 +00001615 refspec_opts.append('wip')
1616 else:
1617 refspec_opts.append('notify=NONE')
1618
1619 # TODO(tandrii): options.message should be posted as a comment if
1620 # --send-mail or --send-email is set on non-initial upload as Rietveld used
1621 # to do it.
1622
1623 # Set options.title in case user was prompted in _GetTitleForUpload and
1624 # _CMDUploadChange needs to be called again.
1625 options.title = self._GetTitleForUpload(
1626 options, multi_change_upload=multi_change_upload)
1627
1628 if options.title:
1629 # Punctuation and whitespace in |title| must be percent-encoded.
1630 refspec_opts.append('m=' +
1631 gerrit_util.PercentEncodeForGitRef(options.title))
1632
1633 if options.private:
1634 refspec_opts.append('private')
1635
1636 if options.topic:
1637 # Documentation on Gerrit topics is here:
1638 # https://gerrit-review.googlesource.com/Documentation/user-upload.html#topic
1639 refspec_opts.append('topic=%s' % options.topic)
1640
1641 if options.enable_auto_submit:
1642 refspec_opts.append('l=Auto-Submit+1')
1643 if options.set_bot_commit:
1644 refspec_opts.append('l=Bot-Commit+1')
1645 if options.use_commit_queue:
1646 refspec_opts.append('l=Commit-Queue+2')
1647 elif options.cq_dry_run:
1648 refspec_opts.append('l=Commit-Queue+1')
1649 elif options.cq_quick_run:
1650 refspec_opts.append('l=Commit-Queue+1')
1651 refspec_opts.append('l=Quick-Run+1')
1652
1653 if change_desc.get_reviewers(tbr_only=True):
1654 score = gerrit_util.GetCodeReviewTbrScore(self.GetGerritHost(),
1655 self.GetGerritProject())
1656 refspec_opts.append('l=Code-Review+%s' % score)
1657
Joanna Wang40497912023-01-24 21:18:16 +00001658 # Gerrit sorts hashtags, so order is not important.
1659 hashtags = {change_desc.sanitize_hash_tag(t) for t in options.hashtags}
1660 # We check GetIssue because we only add hashtags from the
1661 # description on the first upload.
Joanna Wang562481d2023-01-26 21:57:14 +00001662 # TODO(b/265929888): When we fully launch the new path:
1663 # 1) remove fetching hashtags from description alltogether
1664 # 2) Or use descrtiption hashtags for:
1665 # `not (self.GetIssue() and multi_change_upload)`
1666 # 3) Or enabled change description tags for multi and single changes
1667 # by adding them post `git push`.
1668 if not (self.GetIssue() and dogfood_path):
Joanna Wang40497912023-01-24 21:18:16 +00001669 hashtags.update(change_desc.get_hash_tags())
1670 refspec_opts.extend(['hashtag=%s' % t for t in hashtags])
Joanna Wang40497912023-01-24 21:18:16 +00001671
1672 # Note: Reviewers, and ccs are handled individually for each
Joanna Wanga1abbed2023-01-24 01:41:05 +00001673 # branch/change.
1674 return refspec_opts
1675
Joanna Wangb88a4342023-01-24 01:28:22 +00001676 def PrepareSquashedCommit(self, options, parent=None, end_commit=None):
1677 # type: (optparse.Values, Optional[str], Optional[str]) -> _NewUpload()
1678 """Create a squashed commit to upload."""
1679 if parent is None:
1680 origin, upstream_branch_ref = self.FetchUpstreamTuple(self.GetBranch())
1681 upstream_branch = scm.GIT.ShortBranchName(upstream_branch_ref)
1682 if origin == '.':
1683 # upstream is another local branch.
1684 # Assume we want to upload from upstream's last upload.
1685 parent = scm.GIT.GetBranchConfig(settings.GetRoot(), upstream_branch,
1686 GERRIT_SQUASH_HASH_CONFIG_KEY)
1687 assert parent, ('upstream branch %s not configured correctly. '
1688 'Could not fetch latest gerrit upload from git '
1689 'config.')
1690 else:
1691 # upstream is the root of the tree.
1692 parent = self.GetCommonAncestorWithUpstream()
1693
1694 if end_commit is None:
1695 end_commit = RunGit(['rev-parse', self.branchref]).strip()
1696
1697 reviewers, ccs, change_desc = self._PrepareChange(options, parent,
1698 end_commit)
1699 latest_tree = RunGit(['rev-parse', end_commit + ':']).strip()
1700 with gclient_utils.temporary_file() as desc_tempfile:
1701 gclient_utils.FileWrite(desc_tempfile, change_desc.description)
1702 commit_to_push = RunGit(
1703 ['commit-tree', latest_tree, '-p', parent, '-F',
1704 desc_tempfile]).strip()
1705
Joanna Wang40497912023-01-24 21:18:16 +00001706 return _NewUpload(reviewers, ccs, commit_to_push, end_commit, parent,
1707 change_desc)
Joanna Wangb88a4342023-01-24 01:28:22 +00001708
Joanna Wange8523912023-01-21 02:05:40 +00001709 def PrepareCherryPickSquashedCommit(self, options):
1710 # type: (optparse.Values) -> _NewUpload()
1711 """Create a commit cherry-picked on parent to push."""
1712
1713 parent = self.GetCommonAncestorWithUpstream()
1714 reviewers, ccs, change_desc = self._PrepareChange(options, parent,
1715 self.branchref)
1716
1717 new_upload_hash = RunGit(['rev-parse', self.branchref]).strip()
1718 latest_tree = RunGit(['rev-parse', self.branchref + ':']).strip()
1719 with gclient_utils.temporary_file() as desc_tempfile:
1720 gclient_utils.FileWrite(desc_tempfile, change_desc.description)
1721 commit_to_cp = RunGit(
1722 ['commit-tree', latest_tree, '-p', parent, '-F',
1723 desc_tempfile]).strip()
1724
1725 _, upstream_branch_ref = self.FetchUpstreamTuple(self.GetBranch())
1726
1727 upstream_branch = scm.GIT.ShortBranchName(upstream_branch_ref)
1728 upstream_squashed_upload = scm.GIT.GetBranchConfig(
1729 settings.GetRoot(), upstream_branch, GERRIT_SQUASH_HASH_CONFIG_KEY)
1730
1731 RunGit(['checkout', '-q', upstream_squashed_upload])
1732 ret, _out = RunGitWithCode(['cherry-pick', commit_to_cp])
1733 if ret:
1734 RunGit(['cherry-pick', '--abort'])
1735 RunGit(['checkout', '-q', self.branch])
1736 DieWithError('Could not cleanly cherry-pick')
1737
1738 commit_to_push = RunGit(['rev-parse', 'HEAD'])
1739 RunGit(['checkout', '-q', self.branch])
1740
Joanna Wang40497912023-01-24 21:18:16 +00001741 return _NewUpload(reviewers, ccs, commit_to_push, new_upload_hash, parent,
Joanna Wange8523912023-01-21 02:05:40 +00001742 change_desc)
1743
Joanna Wangb46232e2023-01-21 01:58:46 +00001744 def _PrepareChange(self, options, parent, end_commit):
1745 # type: (optparse.Values, str, str) ->
1746 # Tuple[Sequence[str], Sequence[str], ChangeDescription]
1747 """Prepares the change to be uploaded."""
1748 self.EnsureCanUploadPatchset(options.force)
1749
1750 files = self.GetAffectedFiles(parent, end_commit=end_commit)
1751 change_desc = self._GetDescriptionForUpload(options, [parent, end_commit],
1752 files)
1753
1754 watchlist = watchlists.Watchlists(settings.GetRoot())
1755 self.ExtendCC(watchlist.GetWatchersForPaths(files))
1756 if not options.bypass_hooks:
1757 hook_results = self.RunHook(committing=False,
1758 may_prompt=not options.force,
1759 verbose=options.verbose,
1760 parallel=options.parallel,
1761 upstream=parent,
1762 description=change_desc.description,
1763 all_files=False)
1764 self.ExtendCC(hook_results['more_cc'])
1765
1766 # Update the change description and ensure we have a Change Id.
1767 if self.GetIssue():
1768 if options.edit_description:
1769 change_desc.prompt()
1770 change_detail = self._GetChangeDetail(['CURRENT_REVISION'])
1771 change_id = change_detail['change_id']
1772 change_desc.ensure_change_id(change_id)
1773
1774 # TODO(b/265929888): Pull in external changes for the current branch
1775 # only. No clear way to pull in external changes for upstream branches
1776 # yet. Potentially offer a separate command to pull in external changes.
1777 else: # No change issue. First time uploading
1778 if not options.force and not options.message_file:
1779 change_desc.prompt()
1780
1781 # Check if user added a change_id in the descripiton.
1782 change_ids = git_footers.get_footer_change_id(change_desc.description)
1783 if len(change_ids) == 1:
1784 change_id = change_ids[0]
1785 else:
1786 change_id = GenerateGerritChangeId(change_desc.description)
1787 change_desc.ensure_change_id(change_id)
1788
1789 if options.preserve_tryjobs:
1790 change_desc.set_preserve_tryjobs()
1791
1792 SaveDescriptionBackup(change_desc)
1793
1794 # Add ccs
1795 ccs = []
1796 # Add default, watchlist, presubmit ccs if this is an existing change
1797 # and CL is not private and auto-ccing has not been disabled.
1798 if self.GetIssue() and not (options.private and options.no_autocc):
1799 ccs = self.GetCCList().split(',')
1800 if len(ccs) > 100:
1801 lsc = ('https://chromium.googlesource.com/chromium/src/+/HEAD/docs/'
1802 'process/lsc/lsc_workflow.md')
1803 print('WARNING: This will auto-CC %s users.' % len(ccs))
1804 print('LSC may be more appropriate: %s' % lsc)
1805 print('You can also use the --no-autocc flag to disable auto-CC.')
1806 confirm_or_exit(action='continue')
1807
1808 # Add ccs from the --cc flag.
1809 if options.cc:
1810 ccs.extend(options.cc)
1811
1812 ccs = [email.strip() for email in ccs if email.strip()]
1813 if change_desc.get_cced():
1814 ccs.extend(change_desc.get_cced())
1815
1816 return change_desc.get_reviewers(), ccs, change_desc
1817
Joanna Wang40497912023-01-24 21:18:16 +00001818 def PostUploadUpdates(self, options, new_upload, change_number):
1819 # type: (optparse.Values, _NewUpload, change_number) -> None
1820 """Makes necessary post upload changes to the local and remote cl."""
1821 if not self.GetIssue():
1822 self.SetIssue(change_number)
1823
1824 self._GitSetBranchConfigValue(GERRIT_SQUASH_HASH_CONFIG_KEY,
1825 new_upload.commit_to_push)
1826 self._GitSetBranchConfigValue(LAST_UPLOAD_HASH_CONFIG_KEY,
1827 new_upload.new_last_uploaded_commit)
1828
1829 if settings.GetRunPostUploadHook():
1830 self.RunPostUploadHook(options.verbose, new_upload.parent,
1831 new_upload.change_desc.description,
1832 options.no_python2_post_upload_hooks)
1833
1834 if new_upload.reviewers or new_upload.ccs:
1835 gerrit_util.AddReviewers(self.GetGerritHost(),
1836 self._GerritChangeIdentifier(),
1837 reviewers=new_upload.reviewers,
1838 ccs=new_upload.ccs,
1839 notify=bool(options.send_mail))
1840
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001841 def CMDUpload(self, options, git_diff_args, orig_args):
1842 """Uploads a change to codereview."""
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001843 custom_cl_base = None
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001844 if git_diff_args:
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001845 custom_cl_base = base_branch = git_diff_args[0]
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001846 else:
1847 if self.GetBranch() is None:
1848 DieWithError('Can\'t upload from detached HEAD state. Get on a branch!')
1849
1850 # Default to diffing against common ancestor of upstream branch
1851 base_branch = self.GetCommonAncestorWithUpstream()
1852 git_diff_args = [base_branch, 'HEAD']
1853
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001854 # Fast best-effort checks to abort before running potentially expensive
1855 # hooks if uploading is likely to fail anyway. Passing these checks does
1856 # not guarantee that uploading will not fail.
Edward Lemur125d60a2019-09-13 18:25:41 +00001857 self.EnsureAuthenticated(force=options.force)
1858 self.EnsureCanUploadPatchset(force=options.force)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001859
1860 # Apply watchlists on upload.
Edward Lemur2c62b332020-03-12 22:12:33 +00001861 watchlist = watchlists.Watchlists(settings.GetRoot())
1862 files = self.GetAffectedFiles(base_branch)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001863 if not options.bypass_watchlists:
Daniel Cheng7227d212017-11-17 08:12:37 -08001864 self.ExtendCC(watchlist.GetWatchersForPaths(files))
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001865
Edward Lemur5a644f82020-03-18 16:44:57 +00001866 change_desc = self._GetDescriptionForUpload(options, git_diff_args, files)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001867 if not options.bypass_hooks:
Joanna Wanga8db0cb2023-01-24 15:43:17 +00001868 hook_results = self.RunHook(committing=False,
1869 may_prompt=not options.force,
1870 verbose=options.verbose,
1871 parallel=options.parallel,
1872 upstream=base_branch,
1873 description=change_desc.description,
1874 all_files=False)
Edward Lemur227d5102020-02-25 23:45:35 +00001875 self.ExtendCC(hook_results['more_cc'])
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001876
Aaron Gable13101a62018-02-09 13:20:41 -08001877 print_stats(git_diff_args)
Edward Lemura12175c2020-03-09 16:58:26 +00001878 ret = self.CMDUploadChange(
Edward Lemur5a644f82020-03-18 16:44:57 +00001879 options, git_diff_args, custom_cl_base, change_desc)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001880 if not ret:
mlcui7a0b4cb2023-01-23 23:14:55 +00001881 if self.GetBranch() is not None:
1882 self._GitSetBranchConfigValue(
1883 LAST_UPLOAD_HASH_CONFIG_KEY,
1884 scm.GIT.ResolveCommit(settings.GetRoot(), 'HEAD'))
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001885 # Run post upload hooks, if specified.
1886 if settings.GetRunPostUploadHook():
Brian Sheedy7326ca22022-11-02 18:36:17 +00001887 self.RunPostUploadHook(options.verbose, base_branch,
1888 change_desc.description,
1889 options.no_python2_post_upload_hooks)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001890
1891 # Upload all dependencies if specified.
1892 if options.dependencies:
vapiera7fbd5a2016-06-16 09:17:49 -07001893 print()
1894 print('--dependencies has been specified.')
1895 print('All dependent local branches will be re-uploaded.')
1896 print()
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001897 # Remove the dependencies flag from args so that we do not end up in a
1898 # loop.
1899 orig_args.remove('--dependencies')
Jose Lopes3863fc52020-04-07 17:00:25 +00001900 ret = upload_branch_deps(self, orig_args, options.force)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001901 return ret
1902
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001903 def SetCQState(self, new_state):
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07001904 """Updates the CQ state for the latest patchset.
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001905
Greg Gutermanbe5fccd2021-06-14 17:58:20 +00001906 Issue must have been already uploaded and known. Optionally allows for
1907 updating Quick-Run (QR) state.
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001908 """
1909 assert new_state in _CQState.ALL_STATES
1910 assert self.GetIssue()
qyearsley1fdfcb62016-10-24 13:22:03 -07001911 try:
Edward Lemur125d60a2019-09-13 18:25:41 +00001912 vote_map = {
1913 _CQState.NONE: 0,
Greg Gutermanbe5fccd2021-06-14 17:58:20 +00001914 _CQState.QUICK_RUN: 1,
Edward Lemur125d60a2019-09-13 18:25:41 +00001915 _CQState.DRY_RUN: 1,
1916 _CQState.COMMIT: 2,
1917 }
Greg Gutermanbe5fccd2021-06-14 17:58:20 +00001918 if new_state == _CQState.QUICK_RUN:
1919 labels = {
1920 'Commit-Queue': vote_map[_CQState.DRY_RUN],
1921 'Quick-Run': vote_map[_CQState.QUICK_RUN],
1922 }
1923 else:
1924 labels = {'Commit-Queue': vote_map[new_state]}
Edward Lemur125d60a2019-09-13 18:25:41 +00001925 notify = False if new_state == _CQState.DRY_RUN else None
1926 gerrit_util.SetReview(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001927 self.GetGerritHost(), self._GerritChangeIdentifier(),
Edward Lemur125d60a2019-09-13 18:25:41 +00001928 labels=labels, notify=notify)
qyearsley1fdfcb62016-10-24 13:22:03 -07001929 return 0
1930 except KeyboardInterrupt:
1931 raise
1932 except:
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07001933 print('WARNING: Failed to %s.\n'
qyearsley1fdfcb62016-10-24 13:22:03 -07001934 'Either:\n'
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07001935 ' * Your project has no CQ,\n'
1936 ' * You don\'t have permission to change the CQ state,\n'
1937 ' * There\'s a bug in this code (see stack trace below).\n'
1938 'Consider specifying which bots to trigger manually or asking your '
1939 'project owners for permissions or contacting Chrome Infra at:\n'
1940 'https://www.chromium.org/infra\n\n' %
1941 ('cancel CQ' if new_state == _CQState.NONE else 'trigger CQ'))
qyearsley1fdfcb62016-10-24 13:22:03 -07001942 # Still raise exception so that stack trace is printed.
1943 raise
1944
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001945 def GetGerritHost(self):
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001946 # Lazy load of configs.
1947 self.GetCodereviewServer()
tandriie32e3ea2016-06-22 02:52:48 -07001948 if self._gerrit_host and '.' not in self._gerrit_host:
1949 # Abbreviated domain like "chromium" instead of chromium.googlesource.com.
1950 # This happens for internal stuff http://crbug.com/614312.
Edward Lemur79d4f992019-11-11 23:49:02 +00001951 parsed = urllib.parse.urlparse(self.GetRemoteUrl())
tandriie32e3ea2016-06-22 02:52:48 -07001952 if parsed.scheme == 'sso':
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001953 print('WARNING: using non-https URLs for remote is likely broken\n'
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001954 ' Your current remote is: %s' % self.GetRemoteUrl())
tandriie32e3ea2016-06-22 02:52:48 -07001955 self._gerrit_host = '%s.googlesource.com' % self._gerrit_host
1956 self._gerrit_server = 'https://%s' % self._gerrit_host
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001957 return self._gerrit_host
1958
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001959 def _GetGitHost(self):
1960 """Returns git host to be used when uploading change to Gerrit."""
Edward Lemur298f2cf2019-02-22 21:40:39 +00001961 remote_url = self.GetRemoteUrl()
1962 if not remote_url:
1963 return None
Edward Lemur79d4f992019-11-11 23:49:02 +00001964 return urllib.parse.urlparse(remote_url).netloc
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001965
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001966 def GetCodereviewServer(self):
1967 if not self._gerrit_server:
1968 # If we're on a branch then get the server potentially associated
1969 # with that branch.
Edward Lemur85153282020-02-14 22:06:29 +00001970 if self.GetIssue() and self.GetBranch():
tandrii5d48c322016-08-18 16:19:37 -07001971 self._gerrit_server = self._GitGetBranchConfigValue(
Edward Lesmes50da7702020-03-30 19:23:43 +00001972 CODEREVIEW_SERVER_CONFIG_KEY)
tandrii5d48c322016-08-18 16:19:37 -07001973 if self._gerrit_server:
Edward Lemur79d4f992019-11-11 23:49:02 +00001974 self._gerrit_host = urllib.parse.urlparse(self._gerrit_server).netloc
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001975 if not self._gerrit_server:
1976 # We assume repo to be hosted on Gerrit, and hence Gerrit server
1977 # has "-review" suffix for lowest level subdomain.
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001978 parts = self._GetGitHost().split('.')
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001979 parts[0] = parts[0] + '-review'
1980 self._gerrit_host = '.'.join(parts)
1981 self._gerrit_server = 'https://%s' % self._gerrit_host
1982 return self._gerrit_server
1983
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001984 def GetGerritProject(self):
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001985 """Returns Gerrit project name based on remote git URL."""
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00001986 remote_url = self.GetRemoteUrl()
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001987 if remote_url is None:
Josip906bfde2020-01-31 22:38:49 +00001988 logging.warning('can\'t detect Gerrit project.')
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00001989 return None
Edward Lemur79d4f992019-11-11 23:49:02 +00001990 project = urllib.parse.urlparse(remote_url).path.strip('/')
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001991 if project.endswith('.git'):
1992 project = project[:-len('.git')]
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00001993 # *.googlesource.com hosts ensure that Git/Gerrit projects don't start with
1994 # 'a/' prefix, because 'a/' prefix is used to force authentication in
1995 # gitiles/git-over-https protocol. E.g.,
1996 # https://chromium.googlesource.com/a/v8/v8 refers to the same repo/project
1997 # as
1998 # https://chromium.googlesource.com/v8/v8
1999 if project.startswith('a/'):
2000 project = project[len('a/'):]
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00002001 return project
2002
Andrii Shyshkalovd06cc782018-08-23 17:24:19 +00002003 def _GerritChangeIdentifier(self):
2004 """Handy method for gerrit_util.ChangeIdentifier for a given CL.
2005
2006 Not to be confused by value of "Change-Id:" footer.
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002007 If Gerrit project can be determined, this will speed up Gerrit HTTP API RPC.
Andrii Shyshkalovd06cc782018-08-23 17:24:19 +00002008 """
Edward Lesmeseeca9c62020-11-20 00:00:17 +00002009 project = self.GetGerritProject()
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00002010 if project:
2011 return gerrit_util.ChangeIdentifier(project, self.GetIssue())
2012 # Fall back on still unique, but less efficient change number.
2013 return str(self.GetIssue())
Andrii Shyshkalovd06cc782018-08-23 17:24:19 +00002014
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01002015 def EnsureAuthenticated(self, force, refresh=None):
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00002016 """Best effort check that user is authenticated with Gerrit server."""
tandrii@chromium.org28253532016-04-14 13:46:56 +00002017 if settings.GetGerritSkipEnsureAuthenticated():
2018 # For projects with unusual authentication schemes.
2019 # See http://crbug.com/603378.
2020 return
Vadim Shtayurab250ec12018-10-04 00:21:08 +00002021
2022 # Check presence of cookies only if using cookies-based auth method.
2023 cookie_auth = gerrit_util.Authenticator.get()
2024 if not isinstance(cookie_auth, gerrit_util.CookiesAuthenticator):
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002025 return
Vadim Shtayurab250ec12018-10-04 00:21:08 +00002026
Florian Mayerae510e82020-01-30 21:04:48 +00002027 remote_url = self.GetRemoteUrl()
2028 if remote_url is None:
Josip906bfde2020-01-31 22:38:49 +00002029 logging.warning('invalid remote')
Florian Mayerae510e82020-01-30 21:04:48 +00002030 return
Joanna Wang46ffd1b2022-09-16 20:44:44 +00002031 if urllib.parse.urlparse(remote_url).scheme not in ['https', 'sso']:
2032 logging.warning(
2033 'Ignoring branch %(branch)s with non-https/sso remote '
2034 '%(remote)s', {
2035 'branch': self.branch,
2036 'remote': self.GetRemoteUrl()
2037 })
Daniel Chengcf6269b2019-05-18 01:02:12 +00002038 return
2039
Vadim Shtayurab250ec12018-10-04 00:21:08 +00002040 # Lazy-loader to identify Gerrit and Git hosts.
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002041 self.GetCodereviewServer()
2042 git_host = self._GetGitHost()
Edward Lemur298f2cf2019-02-22 21:40:39 +00002043 assert self._gerrit_server and self._gerrit_host and git_host
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002044
2045 gerrit_auth = cookie_auth.get_auth_header(self._gerrit_host)
2046 git_auth = cookie_auth.get_auth_header(git_host)
2047 if gerrit_auth and git_auth:
2048 if gerrit_auth == git_auth:
2049 return
Andrii Shyshkalov354e1d22017-06-09 19:31:33 +02002050 all_gsrc = cookie_auth.get_auth_header('d0esN0tEx1st.googlesource.com')
Raul Tambre80ee78e2019-05-06 22:41:05 +00002051 print(
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002052 'WARNING: You have different credentials for Gerrit and git hosts:\n'
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002053 ' %s\n'
2054 ' %s\n'
Andrii Shyshkalov51acef92017-04-11 17:19:59 +02002055 ' Consider running the following command:\n'
2056 ' git cl creds-check\n'
Andrii Shyshkalov354e1d22017-06-09 19:31:33 +02002057 ' %s\n'
Raul Tambre80ee78e2019-05-06 22:41:05 +00002058 ' %s' %
Andrii Shyshkalov51acef92017-04-11 17:19:59 +02002059 (git_host, self._gerrit_host,
Andrii Shyshkalov354e1d22017-06-09 19:31:33 +02002060 ('Hint: delete creds for .googlesource.com' if all_gsrc else ''),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002061 cookie_auth.get_new_password_message(git_host)))
2062 if not force:
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002063 confirm_or_exit('If you know what you are doing', action='continue')
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002064 return
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +00002065
2066 missing = (
2067 ([] if gerrit_auth else [self._gerrit_host]) +
2068 ([] if git_auth else [git_host]))
2069 DieWithError('Credentials for the following hosts are required:\n'
2070 ' %s\n'
2071 'These are read from %s (or legacy %s)\n'
2072 '%s' % (
2073 '\n '.join(missing),
2074 cookie_auth.get_gitcookies_path(),
2075 cookie_auth.get_netrc_path(),
2076 cookie_auth.get_new_password_message(git_host)))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002077
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01002078 def EnsureCanUploadPatchset(self, force):
Andrii Shyshkalov3e631422017-02-16 17:46:44 +01002079 if not self.GetIssue():
2080 return
2081
Andrii Shyshkalov3e631422017-02-16 17:46:44 +01002082 status = self._GetChangeDetail()['status']
Joanna Wang583ca662022-04-27 21:17:17 +00002083 if status == 'ABANDONED':
Bruce Dawsoneb8426e2022-08-05 23:58:15 +00002084 DieWithError(
2085 'Change %s has been abandoned, new uploads are not allowed' %
2086 (self.GetIssueURL()))
Joanna Wang583ca662022-04-27 21:17:17 +00002087 if status == 'MERGED':
2088 answer = gclient_utils.AskForData(
2089 'Change %s has been submitted, new uploads are not allowed. '
2090 'Would you like to start a new change (Y/n)?' % self.GetIssueURL()
2091 ).lower()
2092 if answer not in ('y', ''):
2093 DieWithError('New uploads are not allowed.')
2094 self.SetIssue()
2095 return
Andrii Shyshkalov3e631422017-02-16 17:46:44 +01002096
Vadim Shtayurab250ec12018-10-04 00:21:08 +00002097 # TODO(vadimsh): For some reason the chunk of code below was skipped if
2098 # 'is_gce' is True. I'm just refactoring it to be 'skip if not cookies'.
2099 # Apparently this check is not very important? Otherwise get_auth_email
2100 # could have been added to other implementations of Authenticator.
2101 cookies_auth = gerrit_util.Authenticator.get()
2102 if not isinstance(cookies_auth, gerrit_util.CookiesAuthenticator):
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01002103 return
Vadim Shtayurab250ec12018-10-04 00:21:08 +00002104
Edward Lesmeseeca9c62020-11-20 00:00:17 +00002105 cookies_user = cookies_auth.get_auth_email(self.GetGerritHost())
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01002106 if self.GetIssueOwner() == cookies_user:
2107 return
2108 logging.debug('change %s owner is %s, cookies user is %s',
2109 self.GetIssue(), self.GetIssueOwner(), cookies_user)
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002110 # Maybe user has linked accounts or something like that,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01002111 # so ask what Gerrit thinks of this user.
Edward Lesmeseeca9c62020-11-20 00:00:17 +00002112 details = gerrit_util.GetAccountDetails(self.GetGerritHost(), 'self')
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01002113 if details['email'] == self.GetIssueOwner():
2114 return
2115 if not force:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002116 print('WARNING: Change %s is owned by %s, but you authenticate to Gerrit '
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01002117 'as %s.\n'
2118 'Uploading may fail due to lack of permissions.' %
2119 (self.GetIssue(), self.GetIssueOwner(), details['email']))
2120 confirm_or_exit(action='upload')
2121
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00002122 def GetStatus(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002123 """Applies a rough heuristic to give a simple summary of an issue's review
tandrii@chromium.org013a2802016-03-29 09:52:33 +00002124 or CQ status, assuming adherence to a common workflow.
2125
2126 Returns None if no issue for this branch, or one of the following keywords:
Aaron Gable9ab38c62017-04-06 14:36:33 -07002127 * 'error' - error from review tool (including deleted issues)
2128 * 'unsent' - no reviewers added
2129 * 'waiting' - waiting for review
2130 * 'reply' - waiting for uploader to reply to review
2131 * 'lgtm' - Code-Review label has been set
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +00002132 * 'dry-run' - dry-running in the CQ
2133 * 'commit' - in the CQ
Aaron Gable9ab38c62017-04-06 14:36:33 -07002134 * 'closed' - successfully submitted or abandoned
tandrii@chromium.org013a2802016-03-29 09:52:33 +00002135 """
2136 if not self.GetIssue():
2137 return None
2138
2139 try:
Aaron Gable9ab38c62017-04-06 14:36:33 -07002140 data = self._GetChangeDetail([
2141 'DETAILED_LABELS', 'CURRENT_REVISION', 'SUBMITTABLE'])
Edward Lemur79d4f992019-11-11 23:49:02 +00002142 except GerritChangeNotExists:
tandrii@chromium.org013a2802016-03-29 09:52:33 +00002143 return 'error'
2144
tandrii@chromium.org5e1bf382016-05-17 08:43:24 +00002145 if data['status'] in ('ABANDONED', 'MERGED'):
tandrii@chromium.org013a2802016-03-29 09:52:33 +00002146 return 'closed'
2147
Andrii Shyshkalovb8268ca2019-04-03 23:33:44 +00002148 cq_label = data['labels'].get('Commit-Queue', {})
2149 max_cq_vote = 0
2150 for vote in cq_label.get('all', []):
2151 max_cq_vote = max(max_cq_vote, vote.get('value', 0))
2152 if max_cq_vote == 2:
Aaron Gable9ab38c62017-04-06 14:36:33 -07002153 return 'commit'
Andrii Shyshkalovb8268ca2019-04-03 23:33:44 +00002154 if max_cq_vote == 1:
2155 return 'dry-run'
tandrii@chromium.org013a2802016-03-29 09:52:33 +00002156
Aaron Gable9ab38c62017-04-06 14:36:33 -07002157 if data['labels'].get('Code-Review', {}).get('approved'):
2158 return 'lgtm'
tandrii@chromium.org013a2802016-03-29 09:52:33 +00002159
2160 if not data.get('reviewers', {}).get('REVIEWER', []):
2161 return 'unsent'
2162
Andrii Shyshkalov33e88a42017-01-27 14:45:30 +01002163 owner = data['owner'].get('_account_id')
Edward Lemur79d4f992019-11-11 23:49:02 +00002164 messages = sorted(data.get('messages', []), key=lambda m: m.get('date'))
Andrii Shyshkalov8aa9d622020-03-10 19:15:35 +00002165 while messages:
2166 m = messages.pop()
Andrii Shyshkalov899785a2021-07-09 12:45:37 +00002167 if (m.get('tag', '').startswith('autogenerated:cq') or
2168 m.get('tag', '').startswith('autogenerated:cv')):
2169 # Ignore replies from LUCI CV/CQ.
Andrii Shyshkalov33e88a42017-01-27 14:45:30 +01002170 continue
Andrii Shyshkalov8aa9d622020-03-10 19:15:35 +00002171 if m.get('author', {}).get('_account_id') == owner:
Aaron Gable9ab38c62017-04-06 14:36:33 -07002172 # Most recent message was by owner.
2173 return 'waiting'
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +00002174
2175 # Some reply from non-owner.
2176 return 'reply'
Aaron Gable9ab38c62017-04-06 14:36:33 -07002177
2178 # Somehow there are no messages even though there are reviewers.
2179 return 'unsent'
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00002180
Gavin Mak4e5e3992022-11-14 22:40:12 +00002181 def GetMostRecentPatchset(self, update=True):
Edward Lemur6c6827c2020-02-06 21:15:18 +00002182 if not self.GetIssue():
2183 return None
2184
tandrii@chromium.org013a2802016-03-29 09:52:33 +00002185 data = self._GetChangeDetail(['CURRENT_REVISION'])
Aaron Gablee8856ee2017-12-07 12:41:46 -08002186 patchset = data['revisions'][data['current_revision']]['_number']
Gavin Mak4e5e3992022-11-14 22:40:12 +00002187 if update:
2188 self.SetPatchset(patchset)
Aaron Gablee8856ee2017-12-07 12:41:46 -08002189 return patchset
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00002190
Gavin Makf35a9eb2022-11-17 18:34:36 +00002191 def _IsPatchsetRangeSignificant(self, lower, upper):
2192 """Returns True if the inclusive range of patchsets contains any reworks or
2193 rebases."""
2194 if not self.GetIssue():
2195 return False
2196
2197 data = self._GetChangeDetail(['ALL_REVISIONS'])
2198 ps_kind = {}
2199 for rev_info in data.get('revisions', {}).values():
2200 ps_kind[rev_info['_number']] = rev_info.get('kind', '')
2201
2202 for ps in range(lower, upper + 1):
2203 assert ps in ps_kind, 'expected patchset %d in change detail' % ps
2204 if ps_kind[ps] not in ('NO_CHANGE', 'NO_CODE_CHANGE'):
2205 return True
2206 return False
2207
Gavin Make61ccc52020-11-13 00:12:57 +00002208 def GetMostRecentDryRunPatchset(self):
2209 """Get patchsets equivalent to the most recent patchset and return
2210 the patchset with the latest dry run. If none have been dry run, return
2211 the latest patchset."""
2212 if not self.GetIssue():
2213 return None
2214
2215 data = self._GetChangeDetail(['ALL_REVISIONS'])
2216 patchset = data['revisions'][data['current_revision']]['_number']
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +00002217 dry_run = {int(m['_revision_number'])
2218 for m in data.get('messages', [])
2219 if m.get('tag', '').endswith('dry-run')}
Gavin Make61ccc52020-11-13 00:12:57 +00002220
2221 for revision_info in sorted(data.get('revisions', {}).values(),
2222 key=lambda c: c['_number'], reverse=True):
2223 if revision_info['_number'] in dry_run:
2224 patchset = revision_info['_number']
2225 break
2226 if revision_info.get('kind', '') not in \
2227 ('NO_CHANGE', 'NO_CODE_CHANGE', 'TRIVIAL_REBASE'):
2228 break
2229 self.SetPatchset(patchset)
2230 return patchset
2231
Aaron Gable636b13f2017-07-14 10:42:48 -07002232 def AddComment(self, message, publish=None):
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002233 gerrit_util.SetReview(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00002234 self.GetGerritHost(), self._GerritChangeIdentifier(),
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002235 msg=message, ready=publish)
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002236
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002237 def GetCommentsSummary(self, readable=True):
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002238 # DETAILED_ACCOUNTS is to get emails in accounts.
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002239 # CURRENT_REVISION is included to get the latest patchset so that
2240 # only the robot comments from the latest patchset can be shown.
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002241 messages = self._GetChangeDetail(
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002242 options=['MESSAGES', 'DETAILED_ACCOUNTS',
2243 'CURRENT_REVISION']).get('messages', [])
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002244 file_comments = gerrit_util.GetChangeComments(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00002245 self.GetGerritHost(), self._GerritChangeIdentifier())
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002246 robot_file_comments = gerrit_util.GetChangeRobotComments(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00002247 self.GetGerritHost(), self._GerritChangeIdentifier())
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002248
2249 # Add the robot comments onto the list of comments, but only
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00002250 # keep those that are from the latest patchset.
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002251 latest_patch_set = self.GetMostRecentPatchset()
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00002252 for path, robot_comments in robot_file_comments.items():
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002253 line_comments = file_comments.setdefault(path, [])
2254 line_comments.extend(
2255 [c for c in robot_comments if c['patch_set'] == latest_patch_set])
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002256
2257 # Build dictionary of file comments for easy access and sorting later.
2258 # {author+date: {path: {patchset: {line: url+message}}}}
2259 comments = collections.defaultdict(
2260 lambda: collections.defaultdict(lambda: collections.defaultdict(dict)))
Andrii Shyshkalova3762a92020-11-25 10:20:42 +00002261
2262 server = self.GetCodereviewServer()
2263 if server in _KNOWN_GERRIT_TO_SHORT_URLS:
2264 # /c/ is automatically added by short URL server.
2265 url_prefix = '%s/%s' % (_KNOWN_GERRIT_TO_SHORT_URLS[server],
2266 self.GetIssue())
2267 else:
2268 url_prefix = '%s/c/%s' % (server, self.GetIssue())
2269
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00002270 for path, line_comments in file_comments.items():
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002271 for comment in line_comments:
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002272 tag = comment.get('tag', '')
2273 if tag.startswith('autogenerated') and 'robot_id' not in comment:
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002274 continue
2275 key = (comment['author']['email'], comment['updated'])
2276 if comment.get('side', 'REVISION') == 'PARENT':
2277 patchset = 'Base'
2278 else:
2279 patchset = 'PS%d' % comment['patch_set']
2280 line = comment.get('line', 0)
Andrii Shyshkalova3762a92020-11-25 10:20:42 +00002281 url = ('%s/%s/%s#%s%s' %
2282 (url_prefix, comment['patch_set'], path,
2283 'b' if comment.get('side') == 'PARENT' else '',
2284 str(line) if line else ''))
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002285 comments[key][path][patchset][line] = (url, comment['message'])
2286
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002287 summaries = []
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002288 for msg in messages:
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002289 summary = self._BuildCommentSummary(msg, comments, readable)
2290 if summary:
2291 summaries.append(summary)
2292 return summaries
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002293
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002294 @staticmethod
2295 def _BuildCommentSummary(msg, comments, readable):
Josip Sokcevic266129c2021-11-09 00:22:00 +00002296 if 'email' not in msg['author']:
2297 # Some bot accounts may not have an email associated.
2298 return None
2299
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002300 key = (msg['author']['email'], msg['date'])
2301 # Don't bother showing autogenerated messages that don't have associated
2302 # file or line comments. this will filter out most autogenerated
2303 # messages, but will keep robot comments like those from Tricium.
2304 is_autogenerated = msg.get('tag', '').startswith('autogenerated')
2305 if is_autogenerated and not comments.get(key):
2306 return None
2307 message = msg['message']
2308 # Gerrit spits out nanoseconds.
2309 assert len(msg['date'].split('.')[-1]) == 9
2310 date = datetime.datetime.strptime(msg['date'][:-3],
2311 '%Y-%m-%d %H:%M:%S.%f')
2312 if key in comments:
2313 message += '\n'
2314 for path, patchsets in sorted(comments.get(key, {}).items()):
2315 if readable:
2316 message += '\n%s' % path
2317 for patchset, lines in sorted(patchsets.items()):
2318 for line, (url, content) in sorted(lines.items()):
2319 if line:
2320 line_str = 'Line %d' % line
2321 path_str = '%s:%d:' % (path, line)
2322 else:
2323 line_str = 'File comment'
2324 path_str = '%s:0:' % path
2325 if readable:
2326 message += '\n %s, %s: %s' % (patchset, line_str, url)
2327 message += '\n %s\n' % content
2328 else:
2329 message += '\n%s ' % path_str
2330 message += '\n%s\n' % content
2331
2332 return _CommentSummary(
2333 date=date,
2334 message=message,
2335 sender=msg['author']['email'],
2336 autogenerated=is_autogenerated,
2337 # These could be inferred from the text messages and correlated with
2338 # Code-Review label maximum, however this is not reliable.
2339 # Leaving as is until the need arises.
2340 approval=False,
2341 disapproval=False,
2342 )
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01002343
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00002344 def CloseIssue(self):
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002345 gerrit_util.AbandonChange(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00002346 self.GetGerritHost(), self._GerritChangeIdentifier(), msg='')
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00002347
Xinan Lin1bd4ffa2021-07-28 00:54:22 +00002348 def SubmitIssue(self):
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002349 gerrit_util.SubmitChange(
Xinan Lin1bd4ffa2021-07-28 00:54:22 +00002350 self.GetGerritHost(), self._GerritChangeIdentifier())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00002351
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002352 def _GetChangeDetail(self, options=None):
2353 """Returns details of associated Gerrit change and caching results."""
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002354 options = options or []
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002355 assert self.GetIssue(), 'issue is required to query Gerrit'
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002356
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01002357 # Optimization to avoid multiple RPCs:
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002358 if 'CURRENT_REVISION' in options or 'ALL_REVISIONS' in options:
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01002359 options.append('CURRENT_COMMIT')
2360
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002361 # Normalize issue and options for consistent keys in cache.
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002362 cache_key = str(self.GetIssue())
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002363 options_set = frozenset(o.upper() for o in options)
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002364
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002365 for cached_options_set, data in self._detail_cache.get(cache_key, []):
2366 # Assumption: data fetched before with extra options is suitable
2367 # for return for a smaller set of options.
2368 # For example, if we cached data for
2369 # options=[CURRENT_REVISION, DETAILED_FOOTERS]
2370 # and request is for options=[CURRENT_REVISION],
2371 # THEN we can return prior cached data.
2372 if options_set.issubset(cached_options_set):
2373 return data
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002374
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01002375 try:
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002376 data = gerrit_util.GetChangeDetail(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00002377 self.GetGerritHost(), self._GerritChangeIdentifier(), options_set)
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01002378 except gerrit_util.GerritError as e:
2379 if e.http_status == 404:
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002380 raise GerritChangeNotExists(self.GetIssue(), self.GetCodereviewServer())
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01002381 raise
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002382
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002383 self._detail_cache.setdefault(cache_key, []).append((options_set, data))
tandriic2405f52016-10-10 08:13:15 -07002384 return data
tandrii@chromium.org013a2802016-03-29 09:52:33 +00002385
Gavin Mak4e5e3992022-11-14 22:40:12 +00002386 def _GetChangeCommit(self, revision='current'):
Andrii Shyshkalove2633162018-08-27 23:50:31 +00002387 assert self.GetIssue(), 'issue must be set to query Gerrit'
Aaron Gable6f5a8d92017-04-18 14:49:05 -07002388 try:
Gavin Mak4e5e3992022-11-14 22:40:12 +00002389 data = gerrit_util.GetChangeCommit(self.GetGerritHost(),
2390 self._GerritChangeIdentifier(),
2391 revision)
Aaron Gable6f5a8d92017-04-18 14:49:05 -07002392 except gerrit_util.GerritError as e:
2393 if e.http_status == 404:
Andrii Shyshkalove2633162018-08-27 23:50:31 +00002394 raise GerritChangeNotExists(self.GetIssue(), self.GetCodereviewServer())
Aaron Gable6f5a8d92017-04-18 14:49:05 -07002395 raise
agable32978d92016-11-01 12:55:02 -07002396 return data
2397
Karen Qian40c19422019-03-13 21:28:29 +00002398 def _IsCqConfigured(self):
2399 detail = self._GetChangeDetail(['LABELS'])
Andrii Shyshkalov8effa4d2020-01-21 13:23:36 +00002400 return u'Commit-Queue' in detail.get('labels', {})
Karen Qian40c19422019-03-13 21:28:29 +00002401
Saagar Sanghavi03b15132020-08-10 16:43:41 +00002402 def CMDLand(self, force, bypass_hooks, verbose, parallel, resultdb, realm):
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002403 if git_common.is_dirty_git_tree('land'):
2404 return 1
Karen Qian40c19422019-03-13 21:28:29 +00002405
tandriid60367b2016-06-22 05:25:12 -07002406 detail = self._GetChangeDetail(['CURRENT_REVISION', 'LABELS'])
Karen Qian40c19422019-03-13 21:28:29 +00002407 if not force and self._IsCqConfigured():
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +00002408 confirm_or_exit('\nIt seems this repository has a CQ, '
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002409 'which can test and land changes for you. '
2410 'Are you sure you wish to bypass it?\n',
2411 action='bypass CQ')
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002412 differs = True
Gavin Makbe2e9262022-11-08 23:41:55 +00002413 last_upload = self._GitGetBranchConfigValue(GERRIT_SQUASH_HASH_CONFIG_KEY)
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002414 # Note: git diff outputs nothing if there is no diff.
2415 if not last_upload or RunGit(['diff', last_upload]).strip():
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002416 print('WARNING: Some changes from local branch haven\'t been uploaded.')
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002417 else:
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002418 if detail['current_revision'] == last_upload:
2419 differs = False
2420 else:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002421 print('WARNING: Local branch contents differ from latest uploaded '
2422 'patchset.')
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002423 if differs:
2424 if not force:
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002425 confirm_or_exit(
2426 'Do you want to submit latest Gerrit patchset and bypass hooks?\n',
2427 action='submit')
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002428 print('WARNING: Bypassing hooks and submitting latest uploaded patchset.')
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002429 elif not bypass_hooks:
Edward Lemur227d5102020-02-25 23:45:35 +00002430 upstream = self.GetCommonAncestorWithUpstream()
2431 if self.GetIssue():
2432 description = self.FetchDescription()
2433 else:
Edward Lemura12175c2020-03-09 16:58:26 +00002434 description = _create_description_from_log([upstream])
Edward Lemur227d5102020-02-25 23:45:35 +00002435 self.RunHook(
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002436 committing=True,
2437 may_prompt=not force,
2438 verbose=verbose,
Edward Lemur227d5102020-02-25 23:45:35 +00002439 parallel=parallel,
2440 upstream=upstream,
2441 description=description,
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00002442 all_files=False,
Saagar Sanghavi03b15132020-08-10 16:43:41 +00002443 resultdb=resultdb,
2444 realm=realm)
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002445
Xinan Lin1bd4ffa2021-07-28 00:54:22 +00002446 self.SubmitIssue()
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002447 print('Issue %s has been submitted.' % self.GetIssueURL())
agable32978d92016-11-01 12:55:02 -07002448 links = self._GetChangeCommit().get('web_links', [])
2449 for link in links:
Michael Mosse371c642021-09-29 16:41:04 +00002450 if link.get('name') in ['gitiles', 'browse'] and link.get('url'):
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002451 print('Landed as: %s' % link.get('url'))
agable32978d92016-11-01 12:55:02 -07002452 break
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002453 return 0
2454
Bruce Dawsonf362f6f2021-02-18 23:15:17 +00002455 def CMDPatchWithParsedIssue(self, parsed_issue_arg, nocommit, force,
2456 newbranch):
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002457 assert parsed_issue_arg.valid
2458
Edward Lemur125d60a2019-09-13 18:25:41 +00002459 self.issue = parsed_issue_arg.issue
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002460
2461 if parsed_issue_arg.hostname:
2462 self._gerrit_host = parsed_issue_arg.hostname
2463 self._gerrit_server = 'https://%s' % self._gerrit_host
2464
tandriic2405f52016-10-10 08:13:15 -07002465 try:
2466 detail = self._GetChangeDetail(['ALL_REVISIONS'])
Aaron Gablea45ee112016-11-22 15:14:38 -08002467 except GerritChangeNotExists as e:
tandriic2405f52016-10-10 08:13:15 -07002468 DieWithError(str(e))
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002469
2470 if not parsed_issue_arg.patchset:
2471 # Use current revision by default.
2472 revision_info = detail['revisions'][detail['current_revision']]
2473 patchset = int(revision_info['_number'])
2474 else:
2475 patchset = parsed_issue_arg.patchset
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00002476 for revision_info in detail['revisions'].values():
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002477 if int(revision_info['_number']) == parsed_issue_arg.patchset:
2478 break
2479 else:
Aaron Gablea45ee112016-11-22 15:14:38 -08002480 DieWithError('Couldn\'t find patchset %i in change %i' %
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002481 (parsed_issue_arg.patchset, self.GetIssue()))
2482
Edward Lemur125d60a2019-09-13 18:25:41 +00002483 remote_url = self.GetRemoteUrl()
Aaron Gable697a91b2018-01-19 15:20:15 -08002484 if remote_url.endswith('.git'):
2485 remote_url = remote_url[:-len('.git')]
erikchen0d14d0d2018-08-28 18:57:09 +00002486 remote_url = remote_url.rstrip('/')
2487
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002488 fetch_info = revision_info['fetch']['http']
erikchen0d14d0d2018-08-28 18:57:09 +00002489 fetch_info['url'] = fetch_info['url'].rstrip('/')
Aaron Gable697a91b2018-01-19 15:20:15 -08002490
2491 if remote_url != fetch_info['url']:
2492 DieWithError('Trying to patch a change from %s but this repo appears '
2493 'to be %s.' % (fetch_info['url'], remote_url))
2494
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002495 RunGit(['fetch', fetch_info['url'], fetch_info['ref']])
Aaron Gable9387b4f2017-06-08 10:50:03 -07002496
Joanna Wangc023a632023-01-26 17:59:25 +00002497 # Set issue immediately in case the cherry-pick fails, which happens
2498 # when resolving conflicts.
2499 if self.GetBranch():
Bruce Dawsonf362f6f2021-02-18 23:15:17 +00002500 self.SetIssue(parsed_issue_arg.issue)
2501
Aaron Gable62619a32017-06-16 08:22:09 -07002502 if force:
2503 RunGit(['reset', '--hard', 'FETCH_HEAD'])
2504 print('Checked out commit for change %i patchset %i locally' %
2505 (parsed_issue_arg.issue, patchset))
Stefan Zager2d5f0392017-10-10 15:17:53 -07002506 elif nocommit:
2507 RunGit(['cherry-pick', '--no-commit', 'FETCH_HEAD'])
2508 print('Patch applied to index.')
Aaron Gable62619a32017-06-16 08:22:09 -07002509 else:
Aaron Gable9387b4f2017-06-08 10:50:03 -07002510 RunGit(['cherry-pick', 'FETCH_HEAD'])
2511 print('Committed patch for change %i patchset %i locally.' %
Aaron Gable62619a32017-06-16 08:22:09 -07002512 (parsed_issue_arg.issue, patchset))
2513 print('Note: this created a local commit which does not have '
2514 'the same hash as the one uploaded for review. This will make '
2515 'uploading changes based on top of this branch difficult.\n'
2516 'If you want to do that, use "git cl patch --force" instead.')
2517
Stefan Zagerd08043c2017-10-12 12:07:02 -07002518 if self.GetBranch():
Stefan Zagerd08043c2017-10-12 12:07:02 -07002519 self.SetPatchset(patchset)
Edward Lesmes50da7702020-03-30 19:23:43 +00002520 fetched_hash = scm.GIT.ResolveCommit(settings.GetRoot(), 'FETCH_HEAD')
Gavin Makbe2e9262022-11-08 23:41:55 +00002521 self._GitSetBranchConfigValue(LAST_UPLOAD_HASH_CONFIG_KEY, fetched_hash)
2522 self._GitSetBranchConfigValue(GERRIT_SQUASH_HASH_CONFIG_KEY, fetched_hash)
Stefan Zagerd08043c2017-10-12 12:07:02 -07002523 else:
2524 print('WARNING: You are in detached HEAD state.\n'
2525 'The patch has been applied to your checkout, but you will not be '
2526 'able to upload a new patch set to the gerrit issue.\n'
2527 'Try using the \'-b\' option if you would like to work on a '
2528 'branch and/or upload a new patch set.')
2529
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002530 return 0
2531
Joanna Wang18de1f62023-01-21 01:24:24 +00002532 @staticmethod
2533 def _GerritCommitMsgHookCheck(offer_removal):
2534 # type: (bool) -> None
2535 """Checks for the gerrit's commit-msg hook and removes it if necessary."""
tandrii16e0b4e2016-06-07 10:34:28 -07002536 hook = os.path.join(settings.GetRoot(), '.git', 'hooks', 'commit-msg')
2537 if not os.path.exists(hook):
2538 return
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002539 # Crude attempt to distinguish Gerrit Codereview hook from a potentially
2540 # custom developer-made one.
tandrii16e0b4e2016-06-07 10:34:28 -07002541 data = gclient_utils.FileRead(hook)
2542 if not('From Gerrit Code Review' in data and 'add_ChangeId()' in data):
2543 return
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002544 print('WARNING: You have Gerrit commit-msg hook installed.\n'
qyearsley12fa6ff2016-08-24 09:18:40 -07002545 'It is not necessary for uploading with git cl in squash mode, '
tandrii16e0b4e2016-06-07 10:34:28 -07002546 'and may interfere with it in subtle ways.\n'
2547 'We recommend you remove the commit-msg hook.')
2548 if offer_removal:
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002549 if ask_for_explicit_yes('Do you want to remove it now?'):
tandrii16e0b4e2016-06-07 10:34:28 -07002550 gclient_utils.rm_file_or_tree(hook)
2551 print('Gerrit commit-msg hook removed.')
2552 else:
2553 print('OK, will keep Gerrit commit-msg hook in place.')
2554
Edward Lemur1b52d872019-05-09 21:12:12 +00002555 def _CleanUpOldTraces(self):
2556 """Keep only the last |MAX_TRACES| traces."""
2557 try:
2558 traces = sorted([
2559 os.path.join(TRACES_DIR, f)
2560 for f in os.listdir(TRACES_DIR)
2561 if (os.path.isfile(os.path.join(TRACES_DIR, f))
2562 and not f.startswith('tmp'))
2563 ])
2564 traces_to_delete = traces[:-MAX_TRACES]
2565 for trace in traces_to_delete:
Daniel Chengcf6269b2019-05-18 01:02:12 +00002566 os.remove(trace)
Edward Lemur1b52d872019-05-09 21:12:12 +00002567 except OSError:
2568 print('WARNING: Failed to remove old git traces from\n'
2569 ' %s'
2570 'Consider removing them manually.' % TRACES_DIR)
Edward Lemurdc8e23d2019-05-07 00:45:48 +00002571
Edward Lemur5737f022019-05-17 01:24:00 +00002572 def _WriteGitPushTraces(self, trace_name, traces_dir, git_push_metadata):
Edward Lemur1b52d872019-05-09 21:12:12 +00002573 """Zip and write the git push traces stored in traces_dir."""
2574 gclient_utils.safe_makedirs(TRACES_DIR)
Edward Lemur1b52d872019-05-09 21:12:12 +00002575 traces_zip = trace_name + '-traces'
2576 traces_readme = trace_name + '-README'
Michael Mosse7f0b4c2019-05-08 04:36:24 +00002577 # Create a temporary dir to store git config and gitcookies in. It will be
2578 # compressed and stored next to the traces.
2579 git_info_dir = tempfile.mkdtemp()
Edward Lemur1b52d872019-05-09 21:12:12 +00002580 git_info_zip = trace_name + '-git-info'
2581
Josip Sokcevic5e18b602020-04-23 21:47:00 +00002582 git_push_metadata['now'] = datetime_now().strftime('%Y-%m-%dT%H:%M:%S.%f')
sangwoo.ko7a614332019-05-22 02:46:19 +00002583
Edward Lemur1b52d872019-05-09 21:12:12 +00002584 git_push_metadata['trace_name'] = trace_name
2585 gclient_utils.FileWrite(
2586 traces_readme, TRACES_README_FORMAT % git_push_metadata)
2587
2588 # Keep only the first 6 characters of the git hashes on the packet
2589 # trace. This greatly decreases size after compression.
2590 packet_traces = os.path.join(traces_dir, 'trace-packet')
2591 if os.path.isfile(packet_traces):
2592 contents = gclient_utils.FileRead(packet_traces)
2593 gclient_utils.FileWrite(
2594 packet_traces, GIT_HASH_RE.sub(r'\1', contents))
2595 shutil.make_archive(traces_zip, 'zip', traces_dir)
2596
2597 # Collect and compress the git config and gitcookies.
2598 git_config = RunGit(['config', '-l'])
2599 gclient_utils.FileWrite(
2600 os.path.join(git_info_dir, 'git-config'),
2601 git_config)
2602
2603 cookie_auth = gerrit_util.Authenticator.get()
2604 if isinstance(cookie_auth, gerrit_util.CookiesAuthenticator):
2605 gitcookies_path = cookie_auth.get_gitcookies_path()
2606 if os.path.isfile(gitcookies_path):
2607 gitcookies = gclient_utils.FileRead(gitcookies_path)
2608 gclient_utils.FileWrite(
2609 os.path.join(git_info_dir, 'gitcookies'),
2610 GITCOOKIES_REDACT_RE.sub('REDACTED', gitcookies))
2611 shutil.make_archive(git_info_zip, 'zip', git_info_dir)
2612
Edward Lemur1b52d872019-05-09 21:12:12 +00002613 gclient_utils.rmtree(git_info_dir)
2614
Josip Sokcevicf2cfd3d2021-03-30 18:39:18 +00002615 def _RunGitPushWithTraces(self,
2616 refspec,
2617 refspec_opts,
2618 git_push_metadata,
2619 git_push_options=None):
Edward Lemur1b52d872019-05-09 21:12:12 +00002620 """Run git push and collect the traces resulting from the execution."""
2621 # Create a temporary directory to store traces in. Traces will be compressed
2622 # and stored in a 'traces' dir inside depot_tools.
2623 traces_dir = tempfile.mkdtemp()
Edward Lemur5737f022019-05-17 01:24:00 +00002624 trace_name = os.path.join(
2625 TRACES_DIR, datetime_now().strftime('%Y%m%dT%H%M%S.%f'))
Edward Lemur0f58ae42019-04-30 17:24:12 +00002626
2627 env = os.environ.copy()
2628 env['GIT_REDACT_COOKIES'] = 'o,SSO,GSSO_Uberproxy'
2629 env['GIT_TR2_EVENT'] = os.path.join(traces_dir, 'tr2-event')
Jonathan Nieder9779b142019-05-29 23:19:29 +00002630 env['GIT_TRACE2_EVENT'] = os.path.join(traces_dir, 'tr2-event')
Edward Lemur0f58ae42019-04-30 17:24:12 +00002631 env['GIT_TRACE_CURL'] = os.path.join(traces_dir, 'trace-curl')
2632 env['GIT_TRACE_CURL_NO_DATA'] = '1'
2633 env['GIT_TRACE_PACKET'] = os.path.join(traces_dir, 'trace-packet')
2634
2635 try:
2636 push_returncode = 0
Edward Lemur1b52d872019-05-09 21:12:12 +00002637 remote_url = self.GetRemoteUrl()
Edward Lemur0f58ae42019-04-30 17:24:12 +00002638 before_push = time_time()
Josip Sokcevicf2cfd3d2021-03-30 18:39:18 +00002639 push_cmd = ['git', 'push', remote_url, refspec]
2640 if git_push_options:
2641 for opt in git_push_options:
2642 push_cmd.extend(['-o', opt])
2643
Edward Lemur0f58ae42019-04-30 17:24:12 +00002644 push_stdout = gclient_utils.CheckCallAndFilter(
Josip Sokcevicf2cfd3d2021-03-30 18:39:18 +00002645 push_cmd,
Edward Lemur0f58ae42019-04-30 17:24:12 +00002646 env=env,
2647 print_stdout=True,
2648 # Flush after every line: useful for seeing progress when running as
2649 # recipe.
2650 filter_fn=lambda _: sys.stdout.flush())
Edward Lemur79d4f992019-11-11 23:49:02 +00002651 push_stdout = push_stdout.decode('utf-8', 'replace')
Edward Lemur0f58ae42019-04-30 17:24:12 +00002652 except subprocess2.CalledProcessError as e:
2653 push_returncode = e.returncode
Aravind Vasudevanc9508582022-10-18 03:07:41 +00002654 if 'blocked keyword' in str(e.stdout) or 'banned word' in str(e.stdout):
Josip Sokcevic740825e2021-05-12 18:28:34 +00002655 raise GitPushError(
2656 'Failed to create a change, very likely due to blocked keyword. '
2657 'Please examine output above for the reason of the failure.\n'
2658 'If this is a false positive, you can try to bypass blocked '
2659 'keyword by using push option '
2660 '-o uploadvalidator~skip, e.g.:\n'
2661 'git cl upload -o uploadvalidator~skip\n\n'
2662 'If git-cl is not working correctly, file a bug under the '
2663 'Infra>SDK component.')
Josip Sokcevic54e30e72022-02-10 22:32:24 +00002664 if 'git push -o nokeycheck' in str(e.stdout):
2665 raise GitPushError(
2666 'Failed to create a change, very likely due to a private key being '
2667 'detected. Please examine output above for the reason of the '
2668 'failure.\n'
2669 'If this is a false positive, you can try to bypass private key '
2670 'detection by using push option '
2671 '-o nokeycheck, e.g.:\n'
2672 'git cl upload -o nokeycheck\n\n'
2673 'If git-cl is not working correctly, file a bug under the '
2674 'Infra>SDK component.')
Josip Sokcevic740825e2021-05-12 18:28:34 +00002675
Josip Sokcevicf736cab2020-10-20 23:41:38 +00002676 raise GitPushError(
2677 'Failed to create a change. Please examine output above for the '
2678 'reason of the failure.\n'
Josip Sokcevic7386a1e2021-02-12 19:00:34 +00002679 'For emergencies, Googlers can escalate to '
2680 'go/gob-support or go/notify#gob\n'
Josip Sokcevicf736cab2020-10-20 23:41:38 +00002681 'Hint: run command below to diagnose common Git/Gerrit '
2682 'credential problems:\n'
2683 ' git cl creds-check\n'
2684 '\n'
2685 'If git-cl is not working correctly, file a bug under the Infra>SDK '
2686 'component including the files below.\n'
2687 'Review the files before upload, since they might contain sensitive '
2688 'information.\n'
2689 'Set the Restrict-View-Google label so that they are not publicly '
2690 'accessible.\n' + TRACES_MESSAGE % {'trace_name': trace_name})
Edward Lemur0f58ae42019-04-30 17:24:12 +00002691 finally:
2692 execution_time = time_time() - before_push
2693 metrics.collector.add_repeated('sub_commands', {
2694 'command': 'git push',
2695 'execution_time': execution_time,
2696 'exit_code': push_returncode,
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +00002697 'arguments': metrics_utils.extract_known_subcommand_args(refspec_opts),
Edward Lemur0f58ae42019-04-30 17:24:12 +00002698 })
2699
Edward Lemur1b52d872019-05-09 21:12:12 +00002700 git_push_metadata['execution_time'] = execution_time
2701 git_push_metadata['exit_code'] = push_returncode
Edward Lemur5737f022019-05-17 01:24:00 +00002702 self._WriteGitPushTraces(trace_name, traces_dir, git_push_metadata)
Edward Lemur0f58ae42019-04-30 17:24:12 +00002703
Edward Lemur1b52d872019-05-09 21:12:12 +00002704 self._CleanUpOldTraces()
Edward Lemur0f58ae42019-04-30 17:24:12 +00002705 gclient_utils.rmtree(traces_dir)
2706
2707 return push_stdout
2708
Josip Sokcevicf736cab2020-10-20 23:41:38 +00002709 def CMDUploadChange(self, options, git_diff_args, custom_cl_base,
2710 change_desc):
2711 """Upload the current branch to Gerrit, retry if new remote HEAD is
2712 found. options and change_desc may be mutated."""
Josip Sokcevicb631a882021-01-06 18:18:10 +00002713 remote, remote_branch = self.GetRemoteBranch()
2714 branch = GetTargetRef(remote, remote_branch, options.target_branch)
2715
Josip Sokcevicf736cab2020-10-20 23:41:38 +00002716 try:
2717 return self._CMDUploadChange(options, git_diff_args, custom_cl_base,
Josip Sokcevicb631a882021-01-06 18:18:10 +00002718 change_desc, branch)
Josip Sokcevicf736cab2020-10-20 23:41:38 +00002719 except GitPushError as e:
Josip Sokcevicb631a882021-01-06 18:18:10 +00002720 # Repository might be in the middle of transition to main branch as
2721 # default, and uploads to old default might be blocked.
2722 if remote_branch not in [DEFAULT_OLD_BRANCH, DEFAULT_NEW_BRANCH]:
Josip Sokcevicf736cab2020-10-20 23:41:38 +00002723 DieWithError(str(e), change_desc)
2724
Josip Sokcevicb631a882021-01-06 18:18:10 +00002725 project_head = gerrit_util.GetProjectHead(self._gerrit_host,
2726 self.GetGerritProject())
2727 if project_head == branch:
2728 DieWithError(str(e), change_desc)
2729 branch = project_head
2730
2731 print("WARNING: Fetching remote state and retrying upload to default "
2732 "branch...")
2733 RunGit(['fetch', '--prune', remote])
Josip Sokcevicf736cab2020-10-20 23:41:38 +00002734 options.edit_description = False
2735 options.force = True
2736 try:
Josip Sokcevicb631a882021-01-06 18:18:10 +00002737 self._CMDUploadChange(options, git_diff_args, custom_cl_base,
2738 change_desc, branch)
Josip Sokcevicf736cab2020-10-20 23:41:38 +00002739 except GitPushError as e:
2740 DieWithError(str(e), change_desc)
2741
2742 def _CMDUploadChange(self, options, git_diff_args, custom_cl_base,
Josip Sokcevicb631a882021-01-06 18:18:10 +00002743 change_desc, branch):
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002744 """Upload the current branch to Gerrit."""
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002745 if options.squash:
tandrii16e0b4e2016-06-07 10:34:28 -07002746 self._GerritCommitMsgHookCheck(offer_removal=not options.force)
Gavin Mak4e5e3992022-11-14 22:40:12 +00002747 external_parent = None
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002748 if self.GetIssue():
Josipe827b0f2020-01-30 00:07:20 +00002749 # User requested to change description
2750 if options.edit_description:
Josipe827b0f2020-01-30 00:07:20 +00002751 change_desc.prompt()
Gavin Mak4e5e3992022-11-14 22:40:12 +00002752 change_detail = self._GetChangeDetail(['CURRENT_REVISION'])
2753 change_id = change_detail['change_id']
Edward Lemur5a644f82020-03-18 16:44:57 +00002754 change_desc.ensure_change_id(change_id)
Gavin Mak4e5e3992022-11-14 22:40:12 +00002755
2756 # Check if changes outside of this workspace have been uploaded.
2757 current_rev = change_detail['current_revision']
2758 last_uploaded_rev = self._GitGetBranchConfigValue(
2759 GERRIT_SQUASH_HASH_CONFIG_KEY)
2760 if last_uploaded_rev and current_rev != last_uploaded_rev:
2761 external_parent = self._UpdateWithExternalChanges()
Aaron Gableb56ad332017-01-06 15:24:31 -08002762 else: # if not self.GetIssue()
Gavin Mak68e6cf32021-01-25 18:24:08 +00002763 if not options.force and not options.message_file:
Anthony Polito8b955342019-09-24 19:01:36 +00002764 change_desc.prompt()
Andrii Shyshkalov8c90d032017-04-19 21:27:26 +02002765 change_ids = git_footers.get_footer_change_id(change_desc.description)
Edward Lemur5a644f82020-03-18 16:44:57 +00002766 if len(change_ids) == 1:
2767 change_id = change_ids[0]
2768 else:
2769 change_id = GenerateGerritChangeId(change_desc.description)
2770 change_desc.ensure_change_id(change_id)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002771
Andrii Shyshkalov71f0da32019-07-15 22:45:18 +00002772 if options.preserve_tryjobs:
2773 change_desc.set_preserve_tryjobs()
Robert Iannuccidb02dd02017-04-19 12:18:20 -07002774
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002775 remote, upstream_branch = self.FetchUpstreamTuple(self.GetBranch())
Gavin Mak4e5e3992022-11-14 22:40:12 +00002776 parent = external_parent or self._ComputeParent(
Edward Lemur5a644f82020-03-18 16:44:57 +00002777 remote, upstream_branch, custom_cl_base, options.force, change_desc)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002778 tree = RunGit(['rev-parse', 'HEAD:']).strip()
Edward Lemur1773f372020-02-22 00:27:14 +00002779 with gclient_utils.temporary_file() as desc_tempfile:
2780 gclient_utils.FileWrite(desc_tempfile, change_desc.description)
2781 ref_to_push = RunGit(
2782 ['commit-tree', tree, '-p', parent, '-F', desc_tempfile]).strip()
Anthony Polito8b955342019-09-24 19:01:36 +00002783 else: # if not options.squash
Gregory Nisbet48d9e1e2021-04-15 23:35:54 +00002784 if options.no_add_changeid:
2785 pass
2786 else: # adding Change-Ids is okay.
2787 if not git_footers.get_footer_change_id(change_desc.description):
2788 DownloadGerritHook(False)
2789 change_desc.set_description(
2790 self._AddChangeIdToCommitMessage(change_desc.description,
2791 git_diff_args))
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002792 ref_to_push = 'HEAD'
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002793 # For no-squash mode, we assume the remote called "origin" is the one we
2794 # want. It is not worthwhile to support different workflows for
2795 # no-squash mode.
2796 parent = 'origin/%s' % branch
Gregory Nisbet48d9e1e2021-04-15 23:35:54 +00002797 # attempt to extract the changeid from the current description
2798 # fail informatively if not possible.
2799 change_id_candidates = git_footers.get_footer_change_id(
2800 change_desc.description)
2801 if not change_id_candidates:
2802 DieWithError("Unable to extract change-id from message.")
2803 change_id = change_id_candidates[0]
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002804
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +00002805 SaveDescriptionBackup(change_desc)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002806 commits = RunGitSilent(['rev-list', '%s..%s' % (parent,
2807 ref_to_push)]).splitlines()
2808 if len(commits) > 1:
2809 print('WARNING: This will upload %d commits. Run the following command '
2810 'to see which commits will be uploaded: ' % len(commits))
2811 print('git log %s..%s' % (parent, ref_to_push))
2812 print('You can also use `git squash-branch` to squash these into a '
2813 'single commit.')
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002814 confirm_or_exit(action='upload')
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002815
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00002816 reviewers = sorted(change_desc.get_reviewers())
Edward Lemur4508b422019-10-03 21:56:35 +00002817 cc = []
Joanna Wangc8f23e22023-01-19 21:18:10 +00002818 # Add CCs from WATCHLISTS and rietveld.cc git config unless this is
Edward Lemur4508b422019-10-03 21:56:35 +00002819 # the initial upload, the CL is private, or auto-CCing has ben disabled.
2820 if not (self.GetIssue() or options.private or options.no_autocc):
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00002821 cc = self.GetCCList().split(',')
Gavin Makb1c08f62021-04-01 18:05:58 +00002822 if len(cc) > 100:
2823 lsc = ('https://chromium.googlesource.com/chromium/src/+/HEAD/docs/'
2824 'process/lsc/lsc_workflow.md')
2825 print('WARNING: This will auto-CC %s users.' % len(cc))
2826 print('LSC may be more appropriate: %s' % lsc)
2827 print('You can also use the --no-autocc flag to disable auto-CC.')
2828 confirm_or_exit(action='continue')
Edward Lemur4508b422019-10-03 21:56:35 +00002829 # Add cc's from the --cc flag.
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00002830 if options.cc:
2831 cc.extend(options.cc)
Edward Lemur79d4f992019-11-11 23:49:02 +00002832 cc = [email.strip() for email in cc if email.strip()]
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00002833 if change_desc.get_cced():
2834 cc.extend(change_desc.get_cced())
Edward Lesmeseeca9c62020-11-20 00:00:17 +00002835 if self.GetGerritHost() == 'chromium-review.googlesource.com':
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00002836 valid_accounts = set(reviewers + cc)
2837 # TODO(crbug/877717): relax this for all hosts.
2838 else:
2839 valid_accounts = gerrit_util.ValidAccounts(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00002840 self.GetGerritHost(), reviewers + cc)
Andrii Shyshkalovf170af42018-10-30 07:00:44 +00002841 logging.info('accounts %s are recognized, %s invalid',
2842 sorted(valid_accounts),
2843 set(reviewers + cc).difference(set(valid_accounts)))
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00002844
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00002845 # Extra options that can be specified at push time. Doc:
2846 # https://gerrit-review.googlesource.com/Documentation/user-upload.html
Joanna Wanga1abbed2023-01-24 01:41:05 +00002847 refspec_opts = self._GetRefSpecOptions(options, change_desc)
agablec6787972016-09-09 16:13:34 -07002848
Andrii Shyshkalov2f727912018-10-15 17:02:33 +00002849 for r in sorted(reviewers):
2850 if r in valid_accounts:
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +00002851 refspec_opts.append('r=%s' % r)
Andrii Shyshkalov2f727912018-10-15 17:02:33 +00002852 reviewers.remove(r)
2853 else:
2854 # TODO(tandrii): this should probably be a hard failure.
2855 print('WARNING: reviewer %s doesn\'t have a Gerrit account, skipping'
2856 % r)
2857 for c in sorted(cc):
2858 # refspec option will be rejected if cc doesn't correspond to an
2859 # account, even though REST call to add such arbitrary cc may succeed.
2860 if c in valid_accounts:
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +00002861 refspec_opts.append('cc=%s' % c)
Andrii Shyshkalov2f727912018-10-15 17:02:33 +00002862 cc.remove(c)
2863
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +00002864 refspec_suffix = ''
2865 if refspec_opts:
2866 refspec_suffix = '%' + ','.join(refspec_opts)
2867 assert ' ' not in refspec_suffix, (
2868 'spaces not allowed in refspec: "%s"' % refspec_suffix)
2869 refspec = '%s:refs/for/%s%s' % (ref_to_push, branch, refspec_suffix)
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00002870
Edward Lemur1b52d872019-05-09 21:12:12 +00002871 git_push_metadata = {
Edward Lesmeseeca9c62020-11-20 00:00:17 +00002872 'gerrit_host': self.GetGerritHost(),
Josip Sokcevicf736cab2020-10-20 23:41:38 +00002873 'title': options.title or '<untitled>',
Edward Lemur1b52d872019-05-09 21:12:12 +00002874 'change_id': change_id,
2875 'description': change_desc.description,
2876 }
Josip Sokcevicf2cfd3d2021-03-30 18:39:18 +00002877
Gavin Mak4e5e3992022-11-14 22:40:12 +00002878 # Gerrit may or may not update fast enough to return the correct patchset
2879 # number after we push. Get the pre-upload patchset and increment later.
2880 latest_ps = self.GetMostRecentPatchset(update=False) or 0
2881
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +00002882 push_stdout = self._RunGitPushWithTraces(refspec, refspec_opts,
Josip Sokcevicf2cfd3d2021-03-30 18:39:18 +00002883 git_push_metadata,
2884 options.push_options)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002885
2886 if options.squash:
Aaron Gable289b4312017-09-13 14:06:16 -07002887 regex = re.compile(r'remote:\s+https?://[\w\-\.\+\/#]*/(\d+)\s.*')
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002888 change_numbers = [m.group(1)
2889 for m in map(regex.match, push_stdout.splitlines())
2890 if m]
2891 if len(change_numbers) != 1:
2892 DieWithError(
2893 ('Created|Updated %d issues on Gerrit, but only 1 expected.\n'
Christopher Lamf732cd52017-01-24 12:40:11 +11002894 'Change-Id: %s') % (len(change_numbers), change_id), change_desc)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002895 self.SetIssue(change_numbers[0])
Gavin Mak4e5e3992022-11-14 22:40:12 +00002896 self.SetPatchset(latest_ps + 1)
Gavin Makbe2e9262022-11-08 23:41:55 +00002897 self._GitSetBranchConfigValue(GERRIT_SQUASH_HASH_CONFIG_KEY, ref_to_push)
tandrii88189772016-09-29 04:29:57 -07002898
Andrii Shyshkalov2f727912018-10-15 17:02:33 +00002899 if self.GetIssue() and (reviewers or cc):
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00002900 # GetIssue() is not set in case of non-squash uploads according to tests.
Aaron Gable6e7ddb62020-05-27 22:23:29 +00002901 # TODO(crbug.com/751901): non-squash uploads in git cl should be removed.
Thiago Perrottab0fb8d52022-08-30 21:26:19 +00002902 gerrit_util.AddReviewers(self.GetGerritHost(),
2903 self._GerritChangeIdentifier(),
2904 reviewers,
2905 cc,
2906 notify=bool(options.send_mail))
Aaron Gable6dadfbf2017-05-09 14:27:58 -07002907
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002908 return 0
2909
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002910 def _ComputeParent(self, remote, upstream_branch, custom_cl_base, force,
2911 change_desc):
2912 """Computes parent of the generated commit to be uploaded to Gerrit.
2913
2914 Returns revision or a ref name.
2915 """
2916 if custom_cl_base:
2917 # Try to avoid creating additional unintended CLs when uploading, unless
2918 # user wants to take this risk.
2919 local_ref_of_target_remote = self.GetRemoteBranch()[1]
2920 code, _ = RunGitWithCode(['merge-base', '--is-ancestor', custom_cl_base,
2921 local_ref_of_target_remote])
2922 if code == 1:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002923 print('\nWARNING: Manually specified base of this CL `%s` '
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002924 'doesn\'t seem to belong to target remote branch `%s`.\n\n'
2925 'If you proceed with upload, more than 1 CL may be created by '
2926 'Gerrit as a result, in turn confusing or crashing git cl.\n\n'
2927 'If you are certain that specified base `%s` has already been '
2928 'uploaded to Gerrit as another CL, you may proceed.\n' %
2929 (custom_cl_base, local_ref_of_target_remote, custom_cl_base))
2930 if not force:
2931 confirm_or_exit(
2932 'Do you take responsibility for cleaning up potential mess '
2933 'resulting from proceeding with upload?',
2934 action='upload')
2935 return custom_cl_base
2936
Aaron Gablef97e33d2017-03-30 15:44:27 -07002937 if remote != '.':
2938 return self.GetCommonAncestorWithUpstream()
2939
2940 # If our upstream branch is local, we base our squashed commit on its
2941 # squashed version.
2942 upstream_branch_name = scm.GIT.ShortBranchName(upstream_branch)
2943
Aaron Gablef97e33d2017-03-30 15:44:27 -07002944 if upstream_branch_name == 'master':
Aaron Gable0bbd1c22017-05-08 14:37:08 -07002945 return self.GetCommonAncestorWithUpstream()
Glen Robertson7d98e222020-08-27 17:53:11 +00002946 if upstream_branch_name == 'main':
2947 return self.GetCommonAncestorWithUpstream()
Aaron Gablef97e33d2017-03-30 15:44:27 -07002948
2949 # Check the squashed hash of the parent.
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002950 # TODO(tandrii): consider checking parent change in Gerrit and using its
2951 # hash if tree hash of latest parent revision (patchset) in Gerrit matches
2952 # the tree hash of the parent branch. The upside is less likely bogus
2953 # requests to reupload parent change just because it's uploadhash is
2954 # missing, yet the downside likely exists, too (albeit unknown to me yet).
Gavin Makbe2e9262022-11-08 23:41:55 +00002955 parent = scm.GIT.GetBranchConfig(settings.GetRoot(), upstream_branch_name,
2956 GERRIT_SQUASH_HASH_CONFIG_KEY)
Aaron Gablef97e33d2017-03-30 15:44:27 -07002957 # Verify that the upstream branch has been uploaded too, otherwise
2958 # Gerrit will create additional CLs when uploading.
2959 if not parent or (RunGitSilent(['rev-parse', upstream_branch + ':']) !=
2960 RunGitSilent(['rev-parse', parent + ':'])):
2961 DieWithError(
2962 '\nUpload upstream branch %s first.\n'
2963 'It is likely that this branch has been rebased since its last '
2964 'upload, so you just need to upload it again.\n'
2965 '(If you uploaded it with --no-squash, then branch dependencies '
2966 'are not supported, and you should reupload with --squash.)'
2967 % upstream_branch_name,
2968 change_desc)
2969 return parent
2970
Gavin Mak4e5e3992022-11-14 22:40:12 +00002971 def _UpdateWithExternalChanges(self):
2972 """Updates workspace with external changes.
2973
2974 Returns the commit hash that should be used as the merge base on upload.
2975 """
2976 local_ps = self.GetPatchset()
2977 if local_ps is None:
2978 return
2979
2980 external_ps = self.GetMostRecentPatchset(update=False)
Gavin Makf35a9eb2022-11-17 18:34:36 +00002981 if external_ps is None or local_ps == external_ps or \
2982 not self._IsPatchsetRangeSignificant(local_ps + 1, external_ps):
Gavin Mak4e5e3992022-11-14 22:40:12 +00002983 return
2984
2985 num_changes = external_ps - local_ps
Gavin Mak6f905472023-01-06 21:01:36 +00002986 if num_changes > 1:
2987 change_words = 'changes were'
2988 else:
2989 change_words = 'change was'
2990 print('\n%d external %s published to %s:\n' %
2991 (num_changes, change_words, self.GetIssueURL(short=True)))
2992
2993 # Print an overview of external changes.
2994 ps_to_commit = {}
2995 ps_to_info = {}
2996 revisions = self._GetChangeDetail(['ALL_REVISIONS'])
2997 for commit_id, revision_info in revisions.get('revisions', {}).items():
2998 ps_num = revision_info['_number']
2999 ps_to_commit[ps_num] = commit_id
3000 ps_to_info[ps_num] = revision_info
3001
3002 for ps in range(external_ps, local_ps, -1):
3003 commit = ps_to_commit[ps][:8]
3004 desc = ps_to_info[ps].get('description', '')
3005 print('Patchset %d [%s] %s' % (ps, commit, desc))
3006
3007 if not ask_for_explicit_yes('\nUploading as-is will override them. '
3008 'Get the latest changes and apply?'):
Gavin Mak4e5e3992022-11-14 22:40:12 +00003009 return
3010
3011 # Get latest Gerrit merge base. Use the first parent even if multiple exist.
3012 external_parent = self._GetChangeCommit(revision=external_ps)['parents'][0]
3013 external_base = external_parent['commit']
3014
3015 branch = git_common.current_branch()
3016 local_base = self.GetCommonAncestorWithUpstream()
3017 if local_base != external_base:
3018 print('\nLocal merge base %s is different from Gerrit %s.\n' %
3019 (local_base, external_base))
3020 if git_common.upstream(branch):
3021 DieWithError('Upstream branch set. Consider using `git rebase-update` '
3022 'to make these the same.')
3023 print('No upstream branch set. Consider setting it and using '
3024 '`git rebase-update`.\nContinuing upload with Gerrit merge base.')
3025
3026 # Fetch Gerrit's CL base if it doesn't exist locally.
3027 remote, _ = self.GetRemoteBranch()
3028 if not scm.GIT.IsValidRevision(settings.GetRoot(), external_base):
3029 RunGitSilent(['fetch', remote, external_base])
3030
3031 # Get the diff between local_ps and external_ps.
3032 issue = self.GetIssue()
Gavin Mak591ebaf2022-12-06 18:05:07 +00003033 changes_ref = 'refs/changes/%02d/%d/' % (issue % 100, issue)
Gavin Mak4e5e3992022-11-14 22:40:12 +00003034 RunGitSilent(['fetch', remote, changes_ref + str(local_ps)])
3035 last_uploaded = RunGitSilent(['rev-parse', 'FETCH_HEAD']).strip()
3036 RunGitSilent(['fetch', remote, changes_ref + str(external_ps)])
3037 latest_external = RunGitSilent(['rev-parse', 'FETCH_HEAD']).strip()
3038 diff = RunGitSilent(['diff', '%s..%s' % (last_uploaded, latest_external)])
3039
3040 # Diff can be empty in the case of trivial rebases.
3041 if not diff:
3042 return external_base
3043
3044 # Apply the diff.
3045 with gclient_utils.temporary_file() as diff_tempfile:
3046 gclient_utils.FileWrite(diff_tempfile, diff)
3047 clean_patch = RunGitWithCode(['apply', '--check', diff_tempfile])[0] == 0
3048 RunGitSilent(['apply', '-3', '--intent-to-add', diff_tempfile])
3049 if not clean_patch:
3050 # Normally patchset is set after upload. But because we exit, that never
3051 # happens. Updating here makes sure that subsequent uploads don't need
3052 # to fetch/apply the same diff again.
3053 self.SetPatchset(external_ps)
3054 DieWithError('\nPatch did not apply cleanly. Please resolve any '
3055 'conflicts and reupload.')
3056
3057 message = 'Incorporate external changes from '
3058 if num_changes == 1:
3059 message += 'patchset %d' % external_ps
3060 else:
3061 message += 'patchsets %d to %d' % (local_ps + 1, external_ps)
3062 RunGitSilent(['commit', '-am', message])
3063 # TODO(crbug.com/1382528): Use the previous commit's message as a default
3064 # patchset title instead of this 'Incorporate' message.
3065 return external_base
3066
Edward Lemura12175c2020-03-09 16:58:26 +00003067 def _AddChangeIdToCommitMessage(self, log_desc, args):
tandrii@chromium.org8930b3d2016-04-13 14:47:02 +00003068 """Re-commits using the current message, assumes the commit hook is in
3069 place.
3070 """
Edward Lemura12175c2020-03-09 16:58:26 +00003071 RunGit(['commit', '--amend', '-m', log_desc])
Andrii Shyshkalovb07575f2018-10-16 06:16:21 +00003072 new_log_desc = _create_description_from_log(args)
tandrii@chromium.org8930b3d2016-04-13 14:47:02 +00003073 if git_footers.get_footer_change_id(new_log_desc):
vapiera7fbd5a2016-06-16 09:17:49 -07003074 print('git-cl: Added Change-Id to commit message.')
tandrii@chromium.org8930b3d2016-04-13 14:47:02 +00003075 return new_log_desc
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +00003076
3077 DieWithError('ERROR: Gerrit commit-msg hook not installed.')
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00003078
tandriie113dfd2016-10-11 10:20:12 -07003079 def CannotTriggerTryJobReason(self):
tandrii8c5a3532016-11-04 07:52:02 -07003080 try:
3081 data = self._GetChangeDetail()
Aaron Gablea45ee112016-11-22 15:14:38 -08003082 except GerritChangeNotExists:
3083 return 'Gerrit doesn\'t know about your change %s' % self.GetIssue()
tandrii8c5a3532016-11-04 07:52:02 -07003084
3085 if data['status'] in ('ABANDONED', 'MERGED'):
3086 return 'CL %s is closed' % self.GetIssue()
3087
Edward Lemurd4d1ba42019-09-20 21:46:37 +00003088 def GetGerritChange(self, patchset=None):
3089 """Returns a buildbucket.v2.GerritChange message for the current issue."""
Edward Lemur79d4f992019-11-11 23:49:02 +00003090 host = urllib.parse.urlparse(self.GetCodereviewServer()).hostname
Edward Lemurd4d1ba42019-09-20 21:46:37 +00003091 issue = self.GetIssue()
Edward Lemur2c210a42019-09-16 23:58:35 +00003092 patchset = int(patchset or self.GetPatchset())
Edward Lemurd4d1ba42019-09-20 21:46:37 +00003093 data = self._GetChangeDetail(['ALL_REVISIONS'])
3094
3095 assert host and issue and patchset, 'CL must be uploaded first'
3096
3097 has_patchset = any(
3098 int(revision_data['_number']) == patchset
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00003099 for revision_data in data['revisions'].values())
Edward Lemurd4d1ba42019-09-20 21:46:37 +00003100 if not has_patchset:
Aaron Gablea45ee112016-11-22 15:14:38 -08003101 raise Exception('Patchset %d is not known in Gerrit change %d' %
tandrii8c5a3532016-11-04 07:52:02 -07003102 (patchset, self.GetIssue()))
Edward Lemurd4d1ba42019-09-20 21:46:37 +00003103
tandrii8c5a3532016-11-04 07:52:02 -07003104 return {
Edward Lemurd4d1ba42019-09-20 21:46:37 +00003105 'host': host,
3106 'change': issue,
3107 'project': data['project'],
3108 'patchset': patchset,
tandrii8c5a3532016-11-04 07:52:02 -07003109 }
tandriie113dfd2016-10-11 10:20:12 -07003110
tandriide281ae2016-10-12 06:02:30 -07003111 def GetIssueOwner(self):
tandrii8c5a3532016-11-04 07:52:02 -07003112 return self._GetChangeDetail(['DETAILED_ACCOUNTS'])['owner']['email']
tandriide281ae2016-10-12 06:02:30 -07003113
Edward Lemur707d70b2018-02-07 00:50:14 +01003114 def GetReviewers(self):
3115 details = self._GetChangeDetail(['DETAILED_ACCOUNTS'])
Mohamed Heikal171c0742018-11-09 20:38:51 +00003116 return [r['email'] for r in details['reviewers'].get('REVIEWER', [])]
Edward Lemur707d70b2018-02-07 00:50:14 +01003117
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00003118
Lei Zhang8a0efc12020-08-05 19:58:45 +00003119def _get_bug_line_values(default_project_prefix, bugs):
3120 """Given default_project_prefix and comma separated list of bugs, yields bug
3121 line values.
tandriif9aefb72016-07-01 09:06:51 -07003122
3123 Each bug can be either:
Lei Zhang8a0efc12020-08-05 19:58:45 +00003124 * a number, which is combined with default_project_prefix
tandriif9aefb72016-07-01 09:06:51 -07003125 * string, which is left as is.
3126
3127 This function may produce more than one line, because bugdroid expects one
3128 project per line.
3129
Lei Zhang8a0efc12020-08-05 19:58:45 +00003130 >>> list(_get_bug_line_values('v8:', '123,chromium:789'))
tandriif9aefb72016-07-01 09:06:51 -07003131 ['v8:123', 'chromium:789']
3132 """
3133 default_bugs = []
3134 others = []
3135 for bug in bugs.split(','):
3136 bug = bug.strip()
3137 if bug:
3138 try:
3139 default_bugs.append(int(bug))
3140 except ValueError:
3141 others.append(bug)
3142
3143 if default_bugs:
3144 default_bugs = ','.join(map(str, default_bugs))
Lei Zhang8a0efc12020-08-05 19:58:45 +00003145 if default_project_prefix:
3146 if not default_project_prefix.endswith(':'):
3147 default_project_prefix += ':'
3148 yield '%s%s' % (default_project_prefix, default_bugs)
tandriif9aefb72016-07-01 09:06:51 -07003149 else:
3150 yield default_bugs
3151 for other in sorted(others):
3152 # Don't bother finding common prefixes, CLs with >2 bugs are very very rare.
3153 yield other
3154
3155
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00003156class ChangeDescription(object):
3157 """Contains a parsed form of the change description."""
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00003158 R_LINE = r'^[ \t]*(TBR|R)[ \t]*=[ \t]*(.*?)[ \t]*$'
bradnelsond975b302016-10-23 12:20:23 -07003159 CC_LINE = r'^[ \t]*(CC)[ \t]*=[ \t]*(.*?)[ \t]*$'
Aaron Gable3a16ed12017-03-23 10:51:55 -07003160 BUG_LINE = r'^[ \t]*(?:(BUG)[ \t]*=|Bug:)[ \t]*(.*?)[ \t]*$'
Dan Beamd8b04ca2019-10-10 21:23:26 +00003161 FIXED_LINE = r'^[ \t]*Fixed[ \t]*:[ \t]*(.*?)[ \t]*$'
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01003162 CHERRY_PICK_LINE = r'^\(cherry picked from commit [a-fA-F0-9]{40}\)$'
Nodir Turakulov23b82142017-11-16 11:04:25 -08003163 STRIP_HASH_TAG_PREFIX = r'^(\s*(revert|reland)( "|:)?\s*)*'
3164 BRACKET_HASH_TAG = r'\s*\[([^\[\]]+)\]'
Anthony Polito02b5af32019-12-02 19:49:47 +00003165 COLON_SEPARATED_HASH_TAG = r'^([a-zA-Z0-9_\- ]+):($|[^:])'
Nodir Turakulov23b82142017-11-16 11:04:25 -08003166 BAD_HASH_TAG_CHUNK = r'[^a-zA-Z0-9]+'
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00003167
Dan Beamd8b04ca2019-10-10 21:23:26 +00003168 def __init__(self, description, bug=None, fixed=None):
agable@chromium.org42c20792013-09-12 17:34:49 +00003169 self._description_lines = (description or '').strip().splitlines()
Anthony Polito8b955342019-09-24 19:01:36 +00003170 if bug:
3171 regexp = re.compile(self.BUG_LINE)
3172 prefix = settings.GetBugPrefix()
3173 if not any((regexp.match(line) for line in self._description_lines)):
3174 values = list(_get_bug_line_values(prefix, bug))
3175 self.append_footer('Bug: %s' % ', '.join(values))
Dan Beamd8b04ca2019-10-10 21:23:26 +00003176 if fixed:
3177 regexp = re.compile(self.FIXED_LINE)
3178 prefix = settings.GetBugPrefix()
3179 if not any((regexp.match(line) for line in self._description_lines)):
3180 values = list(_get_bug_line_values(prefix, fixed))
3181 self.append_footer('Fixed: %s' % ', '.join(values))
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003182
agable@chromium.org42c20792013-09-12 17:34:49 +00003183 @property # www.logilab.org/ticket/89786
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -08003184 def description(self): # pylint: disable=method-hidden
agable@chromium.org42c20792013-09-12 17:34:49 +00003185 return '\n'.join(self._description_lines)
3186
3187 def set_description(self, desc):
3188 if isinstance(desc, basestring):
3189 lines = desc.splitlines()
3190 else:
3191 lines = [line.rstrip() for line in desc]
3192 while lines and not lines[0]:
3193 lines.pop(0)
3194 while lines and not lines[-1]:
3195 lines.pop(-1)
3196 self._description_lines = lines
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003197
Edward Lemur5a644f82020-03-18 16:44:57 +00003198 def ensure_change_id(self, change_id):
3199 description = self.description
3200 footer_change_ids = git_footers.get_footer_change_id(description)
3201 # Make sure that the Change-Id in the description matches the given one.
3202 if footer_change_ids != [change_id]:
3203 if footer_change_ids:
3204 # Remove any existing Change-Id footers since they don't match the
3205 # expected change_id footer.
3206 description = git_footers.remove_footer(description, 'Change-Id')
3207 print('WARNING: Change-Id has been set to %s. Use `git cl issue 0` '
3208 'if you want to set a new one.')
3209 # Add the expected Change-Id footer.
3210 description = git_footers.add_footer_change_id(description, change_id)
3211 self.set_description(description)
3212
Joanna Wang39811b12023-01-20 23:09:48 +00003213 def update_reviewers(self, reviewers):
3214 """Rewrites the R= line(s) as a single line each.
Robert Iannucci6c98dc62017-04-18 11:38:00 -07003215
3216 Args:
3217 reviewers (list(str)) - list of additional emails to use for reviewers.
Robert Iannucci6c98dc62017-04-18 11:38:00 -07003218 """
Joanna Wang39811b12023-01-20 23:09:48 +00003219 if not reviewers:
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003220 return
Robert Iannucci6c98dc62017-04-18 11:38:00 -07003221
3222 reviewers = set(reviewers)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003223
Joanna Wang39811b12023-01-20 23:09:48 +00003224 # Get the set of R= lines and remove them from the description.
agable@chromium.org42c20792013-09-12 17:34:49 +00003225 regexp = re.compile(self.R_LINE)
3226 matches = [regexp.match(line) for line in self._description_lines]
3227 new_desc = [l for i, l in enumerate(self._description_lines)
3228 if not matches[i]]
3229 self.set_description(new_desc)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003230
Joanna Wang39811b12023-01-20 23:09:48 +00003231 # Construct new unified R= lines.
Robert Iannucci6c98dc62017-04-18 11:38:00 -07003232
Joanna Wang39811b12023-01-20 23:09:48 +00003233 # First, update reviewers with names from the R= lines (if any).
agable@chromium.org42c20792013-09-12 17:34:49 +00003234 for match in matches:
3235 if not match:
3236 continue
Joanna Wang39811b12023-01-20 23:09:48 +00003237 reviewers.update(cleanup_list([match.group(2).strip()]))
Robert Iannucci6c98dc62017-04-18 11:38:00 -07003238
Joanna Wang39811b12023-01-20 23:09:48 +00003239 new_r_line = 'R=' + ', '.join(sorted(reviewers))
agable@chromium.org42c20792013-09-12 17:34:49 +00003240
3241 # Put the new lines in the description where the old first R= line was.
3242 line_loc = next((i for i, match in enumerate(matches) if match), -1)
3243 if 0 <= line_loc < len(self._description_lines):
Joanna Wang39811b12023-01-20 23:09:48 +00003244 self._description_lines.insert(line_loc, new_r_line)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003245 else:
Joanna Wang39811b12023-01-20 23:09:48 +00003246 self.append_footer(new_r_line)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003247
Andrii Shyshkalov71f0da32019-07-15 22:45:18 +00003248 def set_preserve_tryjobs(self):
3249 """Ensures description footer contains 'Cq-Do-Not-Cancel-Tryjobs: true'."""
3250 footers = git_footers.parse_footers(self.description)
3251 for v in footers.get('Cq-Do-Not-Cancel-Tryjobs', []):
3252 if v.lower() == 'true':
3253 return
3254 self.append_footer('Cq-Do-Not-Cancel-Tryjobs: true')
3255
Anthony Polito8b955342019-09-24 19:01:36 +00003256 def prompt(self):
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003257 """Asks the user to update the description."""
agable@chromium.org42c20792013-09-12 17:34:49 +00003258 self.set_description([
3259 '# Enter a description of the change.',
3260 '# This will be displayed on the codereview site.',
3261 '# The first line will also be used as the subject of the review.',
alancutter@chromium.orgbd1073e2013-06-01 00:34:38 +00003262 '#--------------------This line is 72 characters long'
agable@chromium.org42c20792013-09-12 17:34:49 +00003263 '--------------------',
3264 ] + self._description_lines)
Dan Beamd8b04ca2019-10-10 21:23:26 +00003265 bug_regexp = re.compile(self.BUG_LINE)
3266 fixed_regexp = re.compile(self.FIXED_LINE)
Jonas Termansend0f79112019-03-22 15:28:26 +00003267 prefix = settings.GetBugPrefix()
Sigurd Schneider8630bb12020-11-11 14:02:49 +00003268 has_issue = lambda l: bug_regexp.match(l) or fixed_regexp.match(l)
Sigurd Schneider9abde8c2020-11-17 08:44:52 +00003269
Dan Beamd8b04ca2019-10-10 21:23:26 +00003270 if not any((has_issue(line) for line in self._description_lines)):
Anthony Polito8b955342019-09-24 19:01:36 +00003271 self.append_footer('Bug: %s' % prefix)
tandriif9aefb72016-07-01 09:06:51 -07003272
Bruce Dawsonfc487042020-10-27 19:11:37 +00003273 print('Waiting for editor...')
agable@chromium.org42c20792013-09-12 17:34:49 +00003274 content = gclient_utils.RunEditor(self.description, True,
Edward Lemur79d4f992019-11-11 23:49:02 +00003275 git_editor=settings.GetGitEditor())
maruel@chromium.org0e0436a2011-10-25 13:32:41 +00003276 if not content:
3277 DieWithError('Running editor failed')
agable@chromium.org42c20792013-09-12 17:34:49 +00003278 lines = content.splitlines()
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003279
Bruce Dawson2377b012018-01-11 16:46:49 -08003280 # Strip off comments and default inserted "Bug:" line.
3281 clean_lines = [line.rstrip() for line in lines if not
Jonas Termansend0f79112019-03-22 15:28:26 +00003282 (line.startswith('#') or
3283 line.rstrip() == "Bug:" or
3284 line.rstrip() == "Bug: " + prefix)]
agable@chromium.org42c20792013-09-12 17:34:49 +00003285 if not clean_lines:
maruel@chromium.org0e0436a2011-10-25 13:32:41 +00003286 DieWithError('No CL description, aborting')
agable@chromium.org42c20792013-09-12 17:34:49 +00003287 self.set_description(clean_lines)
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00003288
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003289 def append_footer(self, line):
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00003290 """Adds a footer line to the description.
3291
3292 Differentiates legacy "KEY=xxx" footers (used to be called tags) and
3293 Gerrit's footers in the form of "Footer-Key: footer any value" and ensures
3294 that Gerrit footers are always at the end.
3295 """
3296 parsed_footer_line = git_footers.parse_footer(line)
3297 if parsed_footer_line:
3298 # Line is a gerrit footer in the form: Footer-Key: any value.
3299 # Thus, must be appended observing Gerrit footer rules.
3300 self.set_description(
3301 git_footers.add_footer(self.description,
3302 key=parsed_footer_line[0],
3303 value=parsed_footer_line[1]))
3304 return
3305
3306 if not self._description_lines:
3307 self._description_lines.append(line)
3308 return
3309
3310 top_lines, gerrit_footers, _ = git_footers.split_footers(self.description)
3311 if gerrit_footers:
3312 # git_footers.split_footers ensures that there is an empty line before
3313 # actual (gerrit) footers, if any. We have to keep it that way.
3314 assert top_lines and top_lines[-1] == ''
3315 top_lines, separator = top_lines[:-1], top_lines[-1:]
3316 else:
3317 separator = [] # No need for separator if there are no gerrit_footers.
3318
3319 prev_line = top_lines[-1] if top_lines else ''
3320 if (not presubmit_support.Change.TAG_LINE_RE.match(prev_line) or
3321 not presubmit_support.Change.TAG_LINE_RE.match(line)):
3322 top_lines.append('')
3323 top_lines.append(line)
3324 self._description_lines = top_lines + separator + gerrit_footers
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00003325
tandrii99a72f22016-08-17 14:33:24 -07003326 def get_reviewers(self, tbr_only=False):
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003327 """Retrieves the list of reviewers."""
agable@chromium.org42c20792013-09-12 17:34:49 +00003328 matches = [re.match(self.R_LINE, line) for line in self._description_lines]
tandrii99a72f22016-08-17 14:33:24 -07003329 reviewers = [match.group(2).strip()
3330 for match in matches
3331 if match and (not tbr_only or match.group(1).upper() == 'TBR')]
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003332 return cleanup_list(reviewers)
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00003333
bradnelsond975b302016-10-23 12:20:23 -07003334 def get_cced(self):
3335 """Retrieves the list of reviewers."""
3336 matches = [re.match(self.CC_LINE, line) for line in self._description_lines]
3337 cced = [match.group(2).strip() for match in matches if match]
3338 return cleanup_list(cced)
3339
Nodir Turakulov23b82142017-11-16 11:04:25 -08003340 def get_hash_tags(self):
3341 """Extracts and sanitizes a list of Gerrit hashtags."""
3342 subject = (self._description_lines or ('',))[0]
3343 subject = re.sub(
3344 self.STRIP_HASH_TAG_PREFIX, '', subject, flags=re.IGNORECASE)
3345
3346 tags = []
3347 start = 0
3348 bracket_exp = re.compile(self.BRACKET_HASH_TAG)
3349 while True:
3350 m = bracket_exp.match(subject, start)
3351 if not m:
3352 break
3353 tags.append(self.sanitize_hash_tag(m.group(1)))
3354 start = m.end()
3355
3356 if not tags:
3357 # Try "Tag: " prefix.
3358 m = re.match(self.COLON_SEPARATED_HASH_TAG, subject)
3359 if m:
3360 tags.append(self.sanitize_hash_tag(m.group(1)))
3361 return tags
3362
3363 @classmethod
3364 def sanitize_hash_tag(cls, tag):
3365 """Returns a sanitized Gerrit hash tag.
3366
3367 A sanitized hashtag can be used as a git push refspec parameter value.
3368 """
3369 return re.sub(cls.BAD_HASH_TAG_CHUNK, '-', tag).strip('-').lower()
3370
maruel@chromium.orge52678e2013-04-26 18:34:44 +00003371
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003372def FindCodereviewSettingsFile(filename='codereview.settings'):
3373 """Finds the given file starting in the cwd and going up.
3374
3375 Only looks up to the top of the repository unless an
3376 'inherit-review-settings-ok' file exists in the root of the repository.
3377 """
3378 inherit_ok_file = 'inherit-review-settings-ok'
3379 cwd = os.getcwd()
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00003380 root = settings.GetRoot()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003381 if os.path.isfile(os.path.join(root, inherit_ok_file)):
Aleksey Khoroshilov2a229712022-06-02 16:24:11 +00003382 root = None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003383 while True:
Aleksey Khoroshilov2a229712022-06-02 16:24:11 +00003384 if os.path.isfile(os.path.join(cwd, filename)):
3385 return open(os.path.join(cwd, filename))
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003386 if cwd == root:
3387 break
Aleksey Khoroshilov2a229712022-06-02 16:24:11 +00003388 parent_dir = os.path.dirname(cwd)
3389 if parent_dir == cwd:
3390 # We hit the system root directory.
3391 break
3392 cwd = parent_dir
3393 return None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003394
3395
3396def LoadCodereviewSettingsFromFile(fileobj):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003397 """Parses a codereview.settings file and updates hooks."""
maruel@chromium.org99ac1c52012-01-16 14:52:12 +00003398 keyvals = gclient_utils.ParseCodereviewSettingsContent(fileobj.read())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003399
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003400 def SetProperty(name, setting, unset_error_ok=False):
3401 fullname = 'rietveld.' + name
3402 if setting in keyvals:
3403 RunGit(['config', fullname, keyvals[setting]])
3404 else:
3405 RunGit(['config', '--unset-all', fullname], error_ok=unset_error_ok)
3406
tandrii48df5812016-10-17 03:55:37 -07003407 if not keyvals.get('GERRIT_HOST', False):
3408 SetProperty('server', 'CODE_REVIEW_SERVER')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003409 # Only server setting is required. Other settings can be absent.
3410 # In that case, we ignore errors raised during option deletion attempt.
Joanna Wangc8f23e22023-01-19 21:18:10 +00003411 SetProperty('cc', 'CC_LIST', unset_error_ok=True)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003412 SetProperty('tree-status-url', 'STATUS', unset_error_ok=True)
3413 SetProperty('viewvc-url', 'VIEW_VC', unset_error_ok=True)
rmistry@google.com90752582014-01-14 21:04:50 +00003414 SetProperty('bug-prefix', 'BUG_PREFIX', unset_error_ok=True)
thestig@chromium.org44202a22014-03-11 19:22:18 +00003415 SetProperty('cpplint-regex', 'LINT_REGEX', unset_error_ok=True)
3416 SetProperty('cpplint-ignore-regex', 'LINT_IGNORE_REGEX', unset_error_ok=True)
rmistry@google.com5626a922015-02-26 14:03:30 +00003417 SetProperty('run-post-upload-hook', 'RUN_POST_UPLOAD_HOOK',
3418 unset_error_ok=True)
Jamie Madilldc4d19e2019-10-24 21:50:02 +00003419 SetProperty(
3420 'format-full-by-default', 'FORMAT_FULL_BY_DEFAULT', unset_error_ok=True)
Dirk Pranke6f0df682021-06-25 00:42:33 +00003421 SetProperty('use-python3', 'USE_PYTHON3', unset_error_ok=True)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003422
ukai@chromium.org7044efc2013-11-28 01:51:21 +00003423 if 'GERRIT_HOST' in keyvals:
ukai@chromium.orge8077812012-02-03 03:41:46 +00003424 RunGit(['config', 'gerrit.host', keyvals['GERRIT_HOST']])
ukai@chromium.orge8077812012-02-03 03:41:46 +00003425
bauerb@chromium.org54b400c2016-01-14 10:08:25 +00003426 if 'GERRIT_SQUASH_UPLOADS' in keyvals:
Edward Lesmes4de54132020-05-05 19:41:33 +00003427 RunGit(['config', 'gerrit.squash-uploads',
3428 keyvals['GERRIT_SQUASH_UPLOADS']])
bauerb@chromium.org54b400c2016-01-14 10:08:25 +00003429
tandrii@chromium.org28253532016-04-14 13:46:56 +00003430 if 'GERRIT_SKIP_ENSURE_AUTHENTICATED' in keyvals:
shinyak@chromium.org00dbccd2016-04-15 07:24:43 +00003431 RunGit(['config', 'gerrit.skip-ensure-authenticated',
tandrii@chromium.org28253532016-04-14 13:46:56 +00003432 keyvals['GERRIT_SKIP_ENSURE_AUTHENTICATED']])
3433
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003434 if 'PUSH_URL_CONFIG' in keyvals and 'ORIGIN_URL_CONFIG' in keyvals:
Andrii Shyshkalov18975322017-01-25 16:44:13 +01003435 # should be of the form
3436 # PUSH_URL_CONFIG: url.ssh://gitrw.chromium.org.pushinsteadof
3437 # ORIGIN_URL_CONFIG: http://src.chromium.org/git
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003438 RunGit(['config', keyvals['PUSH_URL_CONFIG'],
3439 keyvals['ORIGIN_URL_CONFIG']])
3440
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003441
joshua.lock@intel.com426f69b2012-08-02 23:41:49 +00003442def urlretrieve(source, destination):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003443 """Downloads a network object to a local file, like urllib.urlretrieve.
3444
3445 This is necessary because urllib is broken for SSL connections via a proxy.
3446 """
Vadim Shtayuraf7b8f8f2021-11-15 19:10:05 +00003447 with open(destination, 'wb') as f:
Edward Lemur79d4f992019-11-11 23:49:02 +00003448 f.write(urllib.request.urlopen(source).read())
joshua.lock@intel.com426f69b2012-08-02 23:41:49 +00003449
3450
ukai@chromium.org712d6102013-11-27 00:52:58 +00003451def hasSheBang(fname):
3452 """Checks fname is a #! script."""
3453 with open(fname) as f:
3454 return f.read(2).startswith('#!')
3455
3456
tandrii@chromium.org18630d62016-03-04 12:06:02 +00003457def DownloadGerritHook(force):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003458 """Downloads and installs a Gerrit commit-msg hook.
ukai@chromium.org78c4b982012-02-14 02:20:26 +00003459
3460 Args:
3461 force: True to update hooks. False to install hooks if not present.
3462 """
ukai@chromium.org712d6102013-11-27 00:52:58 +00003463 src = 'https://gerrit-review.googlesource.com/tools/hooks/commit-msg'
ukai@chromium.org78c4b982012-02-14 02:20:26 +00003464 dst = os.path.join(settings.GetRoot(), '.git', 'hooks', 'commit-msg')
3465 if not os.access(dst, os.X_OK):
3466 if os.path.exists(dst):
3467 if not force:
3468 return
ukai@chromium.org78c4b982012-02-14 02:20:26 +00003469 try:
joshua.lock@intel.com426f69b2012-08-02 23:41:49 +00003470 urlretrieve(src, dst)
ukai@chromium.org712d6102013-11-27 00:52:58 +00003471 if not hasSheBang(dst):
3472 DieWithError('Not a script: %s\n'
3473 'You need to download from\n%s\n'
3474 'into .git/hooks/commit-msg and '
3475 'chmod +x .git/hooks/commit-msg' % (dst, src))
ukai@chromium.org78c4b982012-02-14 02:20:26 +00003476 os.chmod(dst, stat.S_IRUSR | stat.S_IWUSR | stat.S_IXUSR)
3477 except Exception:
3478 if os.path.exists(dst):
3479 os.remove(dst)
ukai@chromium.org712d6102013-11-27 00:52:58 +00003480 DieWithError('\nFailed to download hooks.\n'
3481 'You need to download from\n%s\n'
3482 'into .git/hooks/commit-msg and '
3483 'chmod +x .git/hooks/commit-msg' % src)
ukai@chromium.org78c4b982012-02-14 02:20:26 +00003484
3485
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003486class _GitCookiesChecker(object):
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003487 """Provides facilities for validating and suggesting fixes to .gitcookies."""
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003488
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003489 def __init__(self):
3490 # Cached list of [host, identity, source], where source is either
3491 # .gitcookies or .netrc.
3492 self._all_hosts = None
3493
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003494 def ensure_configured_gitcookies(self):
3495 """Runs checks and suggests fixes to make git use .gitcookies from default
3496 path."""
3497 default = gerrit_util.CookiesAuthenticator.get_gitcookies_path()
3498 configured_path = RunGitSilent(
3499 ['config', '--global', 'http.cookiefile']).strip()
Andrii Shyshkalov1e250cd2017-05-10 15:39:31 +02003500 configured_path = os.path.expanduser(configured_path)
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003501 if configured_path:
3502 self._ensure_default_gitcookies_path(configured_path, default)
3503 else:
3504 self._configure_gitcookies_path(default)
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003505
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003506 @staticmethod
3507 def _ensure_default_gitcookies_path(configured_path, default_path):
3508 assert configured_path
3509 if configured_path == default_path:
3510 print('git is already configured to use your .gitcookies from %s' %
3511 configured_path)
3512 return
3513
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003514 print('WARNING: You have configured custom path to .gitcookies: %s\n'
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003515 'Gerrit and other depot_tools expect .gitcookies at %s\n' %
3516 (configured_path, default_path))
3517
3518 if not os.path.exists(configured_path):
3519 print('However, your configured .gitcookies file is missing.')
3520 confirm_or_exit('Reconfigure git to use default .gitcookies?',
3521 action='reconfigure')
3522 RunGit(['config', '--global', 'http.cookiefile', default_path])
3523 return
3524
3525 if os.path.exists(default_path):
3526 print('WARNING: default .gitcookies file already exists %s' %
3527 default_path)
3528 DieWithError('Please delete %s manually and re-run git cl creds-check' %
3529 default_path)
3530
3531 confirm_or_exit('Move existing .gitcookies to default location?',
3532 action='move')
3533 shutil.move(configured_path, default_path)
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003534 RunGit(['config', '--global', 'http.cookiefile', default_path])
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003535 print('Moved and reconfigured git to use .gitcookies from %s' %
3536 default_path)
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003537
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003538 @staticmethod
3539 def _configure_gitcookies_path(default_path):
3540 netrc_path = gerrit_util.CookiesAuthenticator.get_netrc_path()
3541 if os.path.exists(netrc_path):
3542 print('You seem to be using outdated .netrc for git credentials: %s' %
3543 netrc_path)
3544 print('This tool will guide you through setting up recommended '
3545 '.gitcookies store for git credentials.\n'
3546 '\n'
3547 'IMPORTANT: If something goes wrong and you decide to go back, do:\n'
3548 ' git config --global --unset http.cookiefile\n'
3549 ' mv %s %s.backup\n\n' % (default_path, default_path))
3550 confirm_or_exit(action='setup .gitcookies')
3551 RunGit(['config', '--global', 'http.cookiefile', default_path])
3552 print('Configured git to use .gitcookies from %s' % default_path)
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003553
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003554 def get_hosts_with_creds(self, include_netrc=False):
3555 if self._all_hosts is None:
3556 a = gerrit_util.CookiesAuthenticator()
Garrett Beaty08bb5c42022-09-21 17:34:20 +00003557 self._all_hosts = [(h, u, s) for h, u, s in itertools.chain((
3558 (h, u, '.netrc') for h, (u, _, _) in a.netrc.hosts.items()), (
3559 (h, u, '.gitcookies') for h, (u, _) in a.gitcookies.items()))
3560 if h.endswith(_GOOGLESOURCE)]
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003561
3562 if include_netrc:
3563 return self._all_hosts
3564 return [(h, u, s) for h, u, s in self._all_hosts if s != '.netrc']
3565
3566 def print_current_creds(self, include_netrc=False):
3567 hosts = sorted(self.get_hosts_with_creds(include_netrc=include_netrc))
3568 if not hosts:
3569 print('No Git/Gerrit credentials found')
3570 return
Edward Lemur79d4f992019-11-11 23:49:02 +00003571 lengths = [max(map(len, (row[i] for row in hosts))) for i in range(3)]
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003572 header = [('Host', 'User', 'Which file'),
3573 ['=' * l for l in lengths]]
3574 for row in (header + hosts):
3575 print('\t'.join((('%%+%ds' % l) % s)
3576 for l, s in zip(lengths, row)))
3577
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003578 @staticmethod
3579 def _parse_identity(identity):
Lei Zhangd3f769a2017-12-15 15:16:14 -08003580 """Parses identity "git-<username>.domain" into <username> and domain."""
3581 # Special case: usernames that contain ".", which are generally not
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +02003582 # distinguishable from sub-domains. But we do know typical domains:
3583 if identity.endswith('.chromium.org'):
3584 domain = 'chromium.org'
3585 username = identity[:-len('.chromium.org')]
3586 else:
3587 username, domain = identity.split('.', 1)
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003588 if username.startswith('git-'):
3589 username = username[len('git-'):]
3590 return username, domain
3591
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003592 def has_generic_host(self):
3593 """Returns whether generic .googlesource.com has been configured.
3594
3595 Chrome Infra recommends to use explicit ${host}.googlesource.com instead.
3596 """
3597 for host, _, _ in self.get_hosts_with_creds(include_netrc=False):
Garrett Beaty08bb5c42022-09-21 17:34:20 +00003598 if host == '.' + _GOOGLESOURCE:
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003599 return True
3600 return False
3601
3602 def _get_git_gerrit_identity_pairs(self):
3603 """Returns map from canonic host to pair of identities (Git, Gerrit).
3604
3605 One of identities might be None, meaning not configured.
3606 """
3607 host_to_identity_pairs = {}
3608 for host, identity, _ in self.get_hosts_with_creds():
Garrett Beaty08bb5c42022-09-21 17:34:20 +00003609 canonical = _canonical_git_googlesource_host(host)
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003610 pair = host_to_identity_pairs.setdefault(canonical, [None, None])
3611 idx = 0 if canonical == host else 1
3612 pair[idx] = identity
3613 return host_to_identity_pairs
3614
3615 def get_partially_configured_hosts(self):
3616 return set(
Garrett Beaty08bb5c42022-09-21 17:34:20 +00003617 (host if i1 else _canonical_gerrit_googlesource_host(host))
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00003618 for host, (i1, i2) in self._get_git_gerrit_identity_pairs().items()
Garrett Beaty08bb5c42022-09-21 17:34:20 +00003619 if None in (i1, i2) and host != '.' + _GOOGLESOURCE)
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003620
3621 def get_conflicting_hosts(self):
3622 return set(
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003623 host
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00003624 for host, (i1, i2) in self._get_git_gerrit_identity_pairs().items()
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003625 if None not in (i1, i2) and i1 != i2)
3626
3627 def get_duplicated_hosts(self):
3628 counters = collections.Counter(h for h, _, _ in self.get_hosts_with_creds())
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00003629 return set(host for host, count in counters.items() if count > 1)
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003630
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003631
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003632 @staticmethod
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003633 def _format_hosts(hosts, extra_column_func=None):
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003634 hosts = sorted(hosts)
3635 assert hosts
3636 if extra_column_func is None:
3637 extras = [''] * len(hosts)
3638 else:
3639 extras = [extra_column_func(host) for host in hosts]
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003640 tmpl = '%%-%ds %%-%ds' % (max(map(len, hosts)), max(map(len, extras)))
3641 lines = []
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003642 for he in zip(hosts, extras):
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003643 lines.append(tmpl % he)
3644 return lines
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003645
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003646 def _find_problems(self):
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003647 if self.has_generic_host():
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003648 yield ('.googlesource.com wildcard record detected',
3649 ['Chrome Infrastructure team recommends to list full host names '
3650 'explicitly.'],
3651 None)
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003652
3653 dups = self.get_duplicated_hosts()
3654 if dups:
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003655 yield ('The following hosts were defined twice',
3656 self._format_hosts(dups),
3657 None)
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003658
3659 partial = self.get_partially_configured_hosts()
3660 if partial:
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003661 yield ('Credentials should come in pairs for Git and Gerrit hosts. '
3662 'These hosts are missing',
Garrett Beaty08bb5c42022-09-21 17:34:20 +00003663 self._format_hosts(
3664 partial, lambda host: 'but %s defined' % _get_counterpart_host(
3665 host)), partial)
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003666
3667 conflicting = self.get_conflicting_hosts()
3668 if conflicting:
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003669 yield ('The following Git hosts have differing credentials from their '
3670 'Gerrit counterparts',
3671 self._format_hosts(conflicting, lambda host: '%s vs %s' %
3672 tuple(self._get_git_gerrit_identity_pairs()[host])),
3673 conflicting)
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003674
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003675 def find_and_report_problems(self):
3676 """Returns True if there was at least one problem, else False."""
3677 found = False
3678 bad_hosts = set()
3679 for title, sublines, hosts in self._find_problems():
3680 if not found:
3681 found = True
3682 print('\n\n.gitcookies problem report:\n')
3683 bad_hosts.update(hosts or [])
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003684 print(' %s%s' % (title, (':' if sublines else '')))
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003685 if sublines:
3686 print()
3687 print(' %s' % '\n '.join(sublines))
3688 print()
3689
3690 if bad_hosts:
3691 assert found
3692 print(' You can manually remove corresponding lines in your %s file and '
3693 'visit the following URLs with correct account to generate '
3694 'correct credential lines:\n' %
3695 gerrit_util.CookiesAuthenticator.get_gitcookies_path())
Garrett Beaty08bb5c42022-09-21 17:34:20 +00003696 print(' %s' % '\n '.join(
3697 sorted(
3698 set(gerrit_util.CookiesAuthenticator().get_new_password_url(
3699 _canonical_git_googlesource_host(host))
3700 for host in bad_hosts))))
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003701 return found
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003702
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003703
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003704@metrics.collector.collect_metrics('git cl creds-check')
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003705def CMDcreds_check(parser, args):
3706 """Checks credentials and suggests changes."""
3707 _, _ = parser.parse_args(args)
3708
Vadim Shtayurab250ec12018-10-04 00:21:08 +00003709 # Code below checks .gitcookies. Abort if using something else.
3710 authn = gerrit_util.Authenticator.get()
3711 if not isinstance(authn, gerrit_util.CookiesAuthenticator):
Edward Lemur57d47422020-03-06 20:43:07 +00003712 message = (
Vadim Shtayurab250ec12018-10-04 00:21:08 +00003713 'This command is not designed for bot environment. It checks '
3714 '~/.gitcookies file not generally used on bots.')
Edward Lemur57d47422020-03-06 20:43:07 +00003715 # TODO(crbug.com/1059384): Automatically detect when running on cloudtop.
3716 if isinstance(authn, gerrit_util.GceAuthenticator):
3717 message += (
3718 '\n'
3719 'If you need to run this on GCE or a cloudtop instance, '
3720 'export SKIP_GCE_AUTH_FOR_GIT=1 in your env.')
3721 DieWithError(message)
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003722
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003723 checker = _GitCookiesChecker()
3724 checker.ensure_configured_gitcookies()
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003725
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003726 print('Your .netrc and .gitcookies have credentials for these hosts:')
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003727 checker.print_current_creds(include_netrc=True)
3728
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003729 if not checker.find_and_report_problems():
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003730 print('\nNo problems detected in your .gitcookies file.')
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003731 return 0
3732 return 1
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003733
3734
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003735@metrics.collector.collect_metrics('git cl baseurl')
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00003736def CMDbaseurl(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00003737 """Gets or sets base-url for this branch."""
Thiago Perrotta16d08f02022-07-20 18:18:50 +00003738 _, args = parser.parse_args(args)
Edward Lesmes50da7702020-03-30 19:23:43 +00003739 branchref = scm.GIT.GetBranchRef(settings.GetRoot())
Edward Lemur85153282020-02-14 22:06:29 +00003740 branch = scm.GIT.ShortBranchName(branchref)
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00003741 if not args:
vapiera7fbd5a2016-06-16 09:17:49 -07003742 print('Current base-url:')
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00003743 return RunGit(['config', 'branch.%s.base-url' % branch],
3744 error_ok=False).strip()
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +00003745
3746 print('Setting base-url to %s' % args[0])
3747 return RunGit(['config', 'branch.%s.base-url' % branch, args[0]],
3748 error_ok=False).strip()
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00003749
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003750
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00003751def color_for_status(status):
3752 """Maps a Changelist status to color, for CMDstatus and other tools."""
Bruce Dawsonb73f8a92020-03-27 22:03:08 +00003753 BOLD = '\033[1m'
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00003754 return {
Bruce Dawsonb73f8a92020-03-27 22:03:08 +00003755 'unsent': BOLD + Fore.YELLOW,
3756 'waiting': BOLD + Fore.RED,
3757 'reply': BOLD + Fore.YELLOW,
3758 'not lgtm': BOLD + Fore.RED,
3759 'lgtm': BOLD + Fore.GREEN,
3760 'commit': BOLD + Fore.MAGENTA,
3761 'closed': BOLD + Fore.CYAN,
3762 'error': BOLD + Fore.WHITE,
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00003763 }.get(status, Fore.WHITE)
3764
tandrii@chromium.org04ea8462016-04-25 19:51:21 +00003765
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003766def get_cl_statuses(changes, fine_grained, max_processes=None):
3767 """Returns a blocking iterable of (cl, status) for given branches.
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00003768
3769 If fine_grained is true, this will fetch CL statuses from the server.
3770 Otherwise, simply indicate if there's a matching url for the given branches.
3771
3772 If max_processes is specified, it is used as the maximum number of processes
3773 to spawn to fetch CL status from the server. Otherwise 1 process per branch is
3774 spawned.
calamity@chromium.orgcf197482016-04-29 20:15:53 +00003775
3776 See GetStatus() for a list of possible statuses.
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00003777 """
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01003778 if not changes:
Edward Lemur61bf4172020-02-24 23:22:37 +00003779 return
calamity@chromium.orgcf197482016-04-29 20:15:53 +00003780
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01003781 if not fine_grained:
3782 # Fast path which doesn't involve querying codereview servers.
Aaron Gablea1bab272017-04-11 16:38:18 -07003783 # Do not use get_approving_reviewers(), since it requires an HTTP request.
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003784 for cl in changes:
3785 yield (cl, 'waiting' if cl.GetIssueURL() else 'error')
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01003786 return
3787
3788 # First, sort out authentication issues.
3789 logging.debug('ensuring credentials exist')
3790 for cl in changes:
3791 cl.EnsureAuthenticated(force=False, refresh=True)
3792
3793 def fetch(cl):
3794 try:
3795 return (cl, cl.GetStatus())
3796 except:
3797 # See http://crbug.com/629863.
Andrii Shyshkalov98824232018-04-19 11:37:15 -07003798 logging.exception('failed to fetch status for cl %s:', cl.GetIssue())
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01003799 raise
3800
3801 threads_count = len(changes)
3802 if max_processes:
3803 threads_count = max(1, min(threads_count, max_processes))
3804 logging.debug('querying %d CLs using %d threads', len(changes), threads_count)
3805
Edward Lemur61bf4172020-02-24 23:22:37 +00003806 pool = multiprocessing.pool.ThreadPool(threads_count)
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01003807 fetched_cls = set()
3808 try:
3809 it = pool.imap_unordered(fetch, changes).__iter__()
3810 while True:
3811 try:
3812 cl, status = it.next(timeout=5)
Edward Lemur61bf4172020-02-24 23:22:37 +00003813 except (multiprocessing.TimeoutError, StopIteration):
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01003814 break
3815 fetched_cls.add(cl)
3816 yield cl, status
3817 finally:
3818 pool.close()
3819
3820 # Add any branches that failed to fetch.
3821 for cl in set(changes) - fetched_cls:
3822 yield (cl, 'error')
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00003823
rmistry@google.com2dd99862015-06-22 12:22:18 +00003824
Jose Lopes3863fc52020-04-07 17:00:25 +00003825def upload_branch_deps(cl, args, force=False):
rmistry@google.com2dd99862015-06-22 12:22:18 +00003826 """Uploads CLs of local branches that are dependents of the current branch.
3827
3828 If the local branch dependency tree looks like:
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003829
3830 test1 -> test2.1 -> test3.1
3831 -> test3.2
3832 -> test2.2 -> test3.3
rmistry@google.com2dd99862015-06-22 12:22:18 +00003833
3834 and you run "git cl upload --dependencies" from test1 then "git cl upload" is
3835 run on the dependent branches in this order:
3836 test2.1, test3.1, test3.2, test2.2, test3.3
3837
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003838 Note: This function does not rebase your local dependent branches. Use it
3839 when you make a change to the parent branch that will not conflict
3840 with its dependent branches, and you would like their dependencies
3841 updated in Rietveld.
rmistry@google.com2dd99862015-06-22 12:22:18 +00003842 """
3843 if git_common.is_dirty_git_tree('upload-branch-deps'):
3844 return 1
3845
3846 root_branch = cl.GetBranch()
3847 if root_branch is None:
3848 DieWithError('Can\'t find dependent branches from detached HEAD state. '
3849 'Get on a branch!')
Andrii Shyshkalov9f274432018-10-15 16:40:23 +00003850 if not cl.GetIssue():
rmistry@google.com2dd99862015-06-22 12:22:18 +00003851 DieWithError('Current branch does not have an uploaded CL. We cannot set '
3852 'patchset dependencies without an uploaded CL.')
3853
3854 branches = RunGit(['for-each-ref',
3855 '--format=%(refname:short) %(upstream:short)',
3856 'refs/heads'])
3857 if not branches:
3858 print('No local branches found.')
3859 return 0
3860
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003861 # Create a dictionary of all local branches to the branches that are
3862 # dependent on it.
rmistry@google.com2dd99862015-06-22 12:22:18 +00003863 tracked_to_dependents = collections.defaultdict(list)
3864 for b in branches.splitlines():
3865 tokens = b.split()
3866 if len(tokens) == 2:
3867 branch_name, tracked = tokens
3868 tracked_to_dependents[tracked].append(branch_name)
3869
vapiera7fbd5a2016-06-16 09:17:49 -07003870 print()
3871 print('The dependent local branches of %s are:' % root_branch)
rmistry@google.com2dd99862015-06-22 12:22:18 +00003872 dependents = []
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003873
rmistry@google.com2dd99862015-06-22 12:22:18 +00003874 def traverse_dependents_preorder(branch, padding=''):
3875 dependents_to_process = tracked_to_dependents.get(branch, [])
3876 padding += ' '
3877 for dependent in dependents_to_process:
vapiera7fbd5a2016-06-16 09:17:49 -07003878 print('%s%s' % (padding, dependent))
rmistry@google.com2dd99862015-06-22 12:22:18 +00003879 dependents.append(dependent)
3880 traverse_dependents_preorder(dependent, padding)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003881
rmistry@google.com2dd99862015-06-22 12:22:18 +00003882 traverse_dependents_preorder(root_branch)
vapiera7fbd5a2016-06-16 09:17:49 -07003883 print()
rmistry@google.com2dd99862015-06-22 12:22:18 +00003884
3885 if not dependents:
vapiera7fbd5a2016-06-16 09:17:49 -07003886 print('There are no dependent local branches for %s' % root_branch)
rmistry@google.com2dd99862015-06-22 12:22:18 +00003887 return 0
3888
Jose Lopes3863fc52020-04-07 17:00:25 +00003889 if not force:
3890 confirm_or_exit('This command will checkout all dependent branches and run '
3891 '"git cl upload".', action='continue')
rmistry@google.com2dd99862015-06-22 12:22:18 +00003892
rmistry@google.com2dd99862015-06-22 12:22:18 +00003893 # Record all dependents that failed to upload.
3894 failures = {}
3895 # Go through all dependents, checkout the branch and upload.
3896 try:
3897 for dependent_branch in dependents:
vapiera7fbd5a2016-06-16 09:17:49 -07003898 print()
3899 print('--------------------------------------')
3900 print('Running "git cl upload" from %s:' % dependent_branch)
rmistry@google.com2dd99862015-06-22 12:22:18 +00003901 RunGit(['checkout', '-q', dependent_branch])
vapiera7fbd5a2016-06-16 09:17:49 -07003902 print()
rmistry@google.com2dd99862015-06-22 12:22:18 +00003903 try:
3904 if CMDupload(OptionParser(), args) != 0:
vapiera7fbd5a2016-06-16 09:17:49 -07003905 print('Upload failed for %s!' % dependent_branch)
rmistry@google.com2dd99862015-06-22 12:22:18 +00003906 failures[dependent_branch] = 1
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -08003907 except: # pylint: disable=bare-except
rmistry@google.com2dd99862015-06-22 12:22:18 +00003908 failures[dependent_branch] = 1
vapiera7fbd5a2016-06-16 09:17:49 -07003909 print()
rmistry@google.com2dd99862015-06-22 12:22:18 +00003910 finally:
3911 # Swap back to the original root branch.
3912 RunGit(['checkout', '-q', root_branch])
3913
vapiera7fbd5a2016-06-16 09:17:49 -07003914 print()
3915 print('Upload complete for dependent branches!')
rmistry@google.com2dd99862015-06-22 12:22:18 +00003916 for dependent_branch in dependents:
3917 upload_status = 'failed' if failures.get(dependent_branch) else 'succeeded'
vapiera7fbd5a2016-06-16 09:17:49 -07003918 print(' %s : %s' % (dependent_branch, upload_status))
3919 print()
rmistry@google.com2dd99862015-06-22 12:22:18 +00003920
3921 return 0
3922
3923
Tibor Goldschwendt7c5efb22020-03-25 01:23:54 +00003924def GetArchiveTagForBranch(issue_num, branch_name, existing_tags, pattern):
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00003925 """Given a proposed tag name, returns a tag name that is guaranteed to be
3926 unique. If 'foo' is proposed but already exists, then 'foo-2' is used,
3927 or 'foo-3', and so on."""
3928
Tibor Goldschwendt7c5efb22020-03-25 01:23:54 +00003929 proposed_tag = pattern.format(**{'issue': issue_num, 'branch': branch_name})
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00003930 for suffix_num in itertools.count(1):
3931 if suffix_num == 1:
3932 to_check = proposed_tag
3933 else:
3934 to_check = '%s-%d' % (proposed_tag, suffix_num)
3935
3936 if to_check not in existing_tags:
3937 return to_check
3938
3939
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003940@metrics.collector.collect_metrics('git cl archive')
kmarshall3bff56b2016-06-06 18:31:47 -07003941def CMDarchive(parser, args):
3942 """Archives and deletes branches associated with closed changelists."""
3943 parser.add_option(
3944 '-j', '--maxjobs', action='store', type=int,
kmarshall9249e012016-08-23 12:02:16 -07003945 help='The maximum number of jobs to use when retrieving review status.')
kmarshall3bff56b2016-06-06 18:31:47 -07003946 parser.add_option(
3947 '-f', '--force', action='store_true',
3948 help='Bypasses the confirmation prompt.')
kmarshall9249e012016-08-23 12:02:16 -07003949 parser.add_option(
3950 '-d', '--dry-run', action='store_true',
3951 help='Skip the branch tagging and removal steps.')
3952 parser.add_option(
3953 '-t', '--notags', action='store_true',
3954 help='Do not tag archived branches. '
3955 'Note: local commit history may be lost.')
Tibor Goldschwendt7c5efb22020-03-25 01:23:54 +00003956 parser.add_option(
3957 '-p',
3958 '--pattern',
3959 default='git-cl-archived-{issue}-{branch}',
3960 help='Format string for archive tags. '
3961 'E.g. \'archived-{issue}-{branch}\'.')
kmarshall3bff56b2016-06-06 18:31:47 -07003962
kmarshall3bff56b2016-06-06 18:31:47 -07003963 options, args = parser.parse_args(args)
3964 if args:
3965 parser.error('Unsupported args: %s' % ' '.join(args))
kmarshall3bff56b2016-06-06 18:31:47 -07003966
3967 branches = RunGit(['for-each-ref', '--format=%(refname)', 'refs/heads'])
3968 if not branches:
3969 return 0
3970
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00003971 tags = RunGit(['for-each-ref', '--format=%(refname)',
3972 'refs/tags']).splitlines() or []
3973 tags = [t.split('/')[-1] for t in tags]
3974
vapiera7fbd5a2016-06-16 09:17:49 -07003975 print('Finding all branches associated with closed issues...')
Edward Lemur934836a2019-09-09 20:16:54 +00003976 changes = [Changelist(branchref=b)
3977 for b in branches.splitlines()]
kmarshall3bff56b2016-06-06 18:31:47 -07003978 alignment = max(5, max(len(c.GetBranch()) for c in changes))
3979 statuses = get_cl_statuses(changes,
3980 fine_grained=True,
3981 max_processes=options.maxjobs)
3982 proposal = [(cl.GetBranch(),
Tibor Goldschwendt7c5efb22020-03-25 01:23:54 +00003983 GetArchiveTagForBranch(cl.GetIssue(), cl.GetBranch(), tags,
3984 options.pattern))
kmarshall3bff56b2016-06-06 18:31:47 -07003985 for cl, status in statuses
Andrii Shyshkalov51bdf8c2018-10-18 01:07:58 +00003986 if status in ('closed', 'rietveld-not-supported')]
kmarshall3bff56b2016-06-06 18:31:47 -07003987 proposal.sort()
3988
3989 if not proposal:
vapiera7fbd5a2016-06-16 09:17:49 -07003990 print('No branches with closed codereview issues found.')
kmarshall3bff56b2016-06-06 18:31:47 -07003991 return 0
3992
Edward Lemur85153282020-02-14 22:06:29 +00003993 current_branch = scm.GIT.GetBranch(settings.GetRoot())
kmarshall3bff56b2016-06-06 18:31:47 -07003994
vapiera7fbd5a2016-06-16 09:17:49 -07003995 print('\nBranches with closed issues that will be archived:\n')
kmarshall9249e012016-08-23 12:02:16 -07003996 if options.notags:
3997 for next_item in proposal:
3998 print(' ' + next_item[0])
3999 else:
4000 print('%*s | %s' % (alignment, 'Branch name', 'Archival tag name'))
4001 for next_item in proposal:
4002 print('%*s %s' % (alignment, next_item[0], next_item[1]))
kmarshall3bff56b2016-06-06 18:31:47 -07004003
kmarshall9249e012016-08-23 12:02:16 -07004004 # Quit now on precondition failure or if instructed by the user, either
4005 # via an interactive prompt or by command line flags.
4006 if options.dry_run:
4007 print('\nNo changes were made (dry run).\n')
4008 return 0
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +00004009
4010 if any(branch == current_branch for branch, _ in proposal):
kmarshall3bff56b2016-06-06 18:31:47 -07004011 print('You are currently on a branch \'%s\' which is associated with a '
4012 'closed codereview issue, so archive cannot proceed. Please '
4013 'checkout another branch and run this command again.' %
4014 current_branch)
4015 return 1
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +00004016
4017 if not options.force:
Edward Lesmesae3586b2020-03-23 21:21:14 +00004018 answer = gclient_utils.AskForData('\nProceed with deletion (Y/n)? ').lower()
sergiyb4a5ecbe2016-06-20 09:46:00 -07004019 if answer not in ('y', ''):
vapiera7fbd5a2016-06-16 09:17:49 -07004020 print('Aborted.')
kmarshall3bff56b2016-06-06 18:31:47 -07004021 return 1
4022
4023 for branch, tagname in proposal:
kmarshall9249e012016-08-23 12:02:16 -07004024 if not options.notags:
4025 RunGit(['tag', tagname, branch])
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00004026
4027 if RunGitWithCode(['branch', '-D', branch])[0] != 0:
4028 # Clean up the tag if we failed to delete the branch.
4029 RunGit(['tag', '-d', tagname])
kmarshall9249e012016-08-23 12:02:16 -07004030
vapiera7fbd5a2016-06-16 09:17:49 -07004031 print('\nJob\'s done!')
kmarshall3bff56b2016-06-06 18:31:47 -07004032
4033 return 0
4034
4035
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004036@metrics.collector.collect_metrics('git cl status')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004037def CMDstatus(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004038 """Show status of changelists.
4039
4040 Colors are used to tell the state of the CL unless --fast is used:
jsbell@chromium.orgaeab41a2013-12-10 20:01:22 +00004041 - Blue waiting for review
Aaron Gable9ab38c62017-04-06 14:36:33 -07004042 - Yellow waiting for you to reply to review, or not yet sent
jsbell@chromium.orgaeab41a2013-12-10 20:01:22 +00004043 - Green LGTM'ed
Aaron Gable9ab38c62017-04-06 14:36:33 -07004044 - Red 'not LGTM'ed
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +00004045 - Magenta in the CQ
jsbell@chromium.orgaeab41a2013-12-10 20:01:22 +00004046 - Cyan was committed, branch can be deleted
Aaron Gable9ab38c62017-04-06 14:36:33 -07004047 - White error, or unknown status
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004048
4049 Also see 'git cl comments'.
4050 """
Alan Cuttera3be9a52019-03-04 18:50:33 +00004051 parser.add_option(
4052 '--no-branch-color',
4053 action='store_true',
4054 help='Disable colorized branch names')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004055 parser.add_option('--field',
phajdan.jr289d03e2016-08-16 08:21:06 -07004056 help='print only specific field (desc|id|patch|status|url)')
maruel@chromium.org1033efd2013-07-23 23:25:09 +00004057 parser.add_option('-f', '--fast', action='store_true',
4058 help='Do not retrieve review status')
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00004059 parser.add_option(
4060 '-j', '--maxjobs', action='store', type=int,
4061 help='The maximum number of jobs to use when retrieving review status')
Edward Lemur52969c92020-02-06 18:15:28 +00004062 parser.add_option(
4063 '-i', '--issue', type=int,
4064 help='Operate on this issue instead of the current branch\'s implicit '
4065 'issue. Requires --field to be set.')
Sigurd Schneider9abde8c2020-11-17 08:44:52 +00004066 parser.add_option('-d',
4067 '--date-order',
4068 action='store_true',
4069 help='Order branches by committer date.')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004070 options, args = parser.parse_args(args)
maruel@chromium.org39c0b222013-08-17 16:57:01 +00004071 if args:
4072 parser.error('Unsupported args: %s' % args)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004073
iannuccie53c9352016-08-17 14:40:40 -07004074 if options.issue is not None and not options.field:
Edward Lemur6c6827c2020-02-06 21:15:18 +00004075 parser.error('--field must be given when --issue is set.')
iannucci3c972b92016-08-17 13:24:10 -07004076
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004077 if options.field:
Edward Lemur934836a2019-09-09 20:16:54 +00004078 cl = Changelist(issue=options.issue)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004079 if options.field.startswith('desc'):
Edward Lemur6c6827c2020-02-06 21:15:18 +00004080 if cl.GetIssue():
4081 print(cl.FetchDescription())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004082 elif options.field == 'id':
4083 issueid = cl.GetIssue()
4084 if issueid:
vapiera7fbd5a2016-06-16 09:17:49 -07004085 print(issueid)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004086 elif options.field == 'patch':
Aaron Gablee8856ee2017-12-07 12:41:46 -08004087 patchset = cl.GetMostRecentPatchset()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004088 if patchset:
vapiera7fbd5a2016-06-16 09:17:49 -07004089 print(patchset)
phajdan.jr289d03e2016-08-16 08:21:06 -07004090 elif options.field == 'status':
4091 print(cl.GetStatus())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004092 elif options.field == 'url':
4093 url = cl.GetIssueURL()
4094 if url:
vapiera7fbd5a2016-06-16 09:17:49 -07004095 print(url)
maruel@chromium.orge25c75b2013-07-23 18:30:56 +00004096 return 0
4097
Sigurd Schneider9abde8c2020-11-17 08:44:52 +00004098 branches = RunGit([
4099 'for-each-ref', '--format=%(refname) %(committerdate:unix)', 'refs/heads'
4100 ])
maruel@chromium.orge25c75b2013-07-23 18:30:56 +00004101 if not branches:
4102 print('No local branch found.')
4103 return 0
4104
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00004105 changes = [
Sigurd Schneider9abde8c2020-11-17 08:44:52 +00004106 Changelist(branchref=b, commit_date=ct)
4107 for b, ct in map(lambda line: line.split(' '), branches.splitlines())
4108 ]
vapiera7fbd5a2016-06-16 09:17:49 -07004109 print('Branches associated with reviews:')
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00004110 output = get_cl_statuses(changes,
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00004111 fine_grained=not options.fast,
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00004112 max_processes=options.maxjobs)
maruel@chromium.org1033efd2013-07-23 23:25:09 +00004113
Edward Lemur85153282020-02-14 22:06:29 +00004114 current_branch = scm.GIT.GetBranch(settings.GetRoot())
Daniel McArdlea23bf592019-02-12 00:25:12 +00004115
4116 def FormatBranchName(branch, colorize=False):
4117 """Simulates 'git branch' behavior. Colorizes and prefixes branch name with
4118 an asterisk when it is the current branch."""
4119
4120 asterisk = ""
4121 color = Fore.RESET
4122 if branch == current_branch:
4123 asterisk = "* "
4124 color = Fore.GREEN
Edward Lemur85153282020-02-14 22:06:29 +00004125 branch_name = scm.GIT.ShortBranchName(branch)
Daniel McArdlea23bf592019-02-12 00:25:12 +00004126
4127 if colorize:
4128 return asterisk + color + branch_name + Fore.RESET
Daniel McArdle452a49f2019-02-14 17:28:31 +00004129 return asterisk + branch_name
4130
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00004131 branch_statuses = {}
Daniel McArdlea23bf592019-02-12 00:25:12 +00004132
4133 alignment = max(5, max(len(FormatBranchName(c.GetBranch())) for c in changes))
Sigurd Schneider1bfda8e2021-06-30 14:46:25 +00004134
4135 if options.date_order or settings.IsStatusCommitOrderByDate():
Sigurd Schneider9abde8c2020-11-17 08:44:52 +00004136 sorted_changes = sorted(changes,
4137 key=lambda c: c.GetCommitDate(),
4138 reverse=True)
4139 else:
4140 sorted_changes = sorted(changes, key=lambda c: c.GetBranch())
4141 for cl in sorted_changes:
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00004142 branch = cl.GetBranch()
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00004143 while branch not in branch_statuses:
Edward Lemur79d4f992019-11-11 23:49:02 +00004144 c, status = next(output)
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00004145 branch_statuses[c.GetBranch()] = status
4146 status = branch_statuses.pop(branch)
Andrii Shyshkalov1ee78cd2020-03-12 01:31:53 +00004147 url = cl.GetIssueURL(short=True)
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00004148 if url and (not status or status == 'error'):
4149 # The issue probably doesn't exist anymore.
4150 url += ' (broken)'
4151
nodir@chromium.orga6de1f42015-06-10 04:23:17 +00004152 color = color_for_status(status)
Bruce Dawsonb73f8a92020-03-27 22:03:08 +00004153 # Turn off bold as well as colors.
4154 END = '\033[0m'
4155 reset = Fore.RESET + END
iannucci@chromium.org596cd5c2016-04-04 21:34:39 +00004156 if not setup_color.IS_TTY:
maruel@chromium.org885f6512013-07-27 02:17:26 +00004157 color = ''
4158 reset = ''
nodir@chromium.orga6de1f42015-06-10 04:23:17 +00004159 status_str = '(%s)' % status if status else ''
Daniel McArdle452a49f2019-02-14 17:28:31 +00004160
Alan Cuttera3be9a52019-03-04 18:50:33 +00004161 branch_display = FormatBranchName(branch)
4162 padding = ' ' * (alignment - len(branch_display))
4163 if not options.no_branch_color:
4164 branch_display = FormatBranchName(branch, colorize=True)
Daniel McArdle452a49f2019-02-14 17:28:31 +00004165
Alan Cuttera3be9a52019-03-04 18:50:33 +00004166 print(' %s : %s%s %s%s' % (padding + branch_display, color, url,
4167 status_str, reset))
Andrii Shyshkalovd0e1d9d2017-01-24 17:10:51 +01004168
vapiera7fbd5a2016-06-16 09:17:49 -07004169 print()
Daniel McArdlea23bf592019-02-12 00:25:12 +00004170 print('Current branch: %s' % current_branch)
Andrii Shyshkalovd0e1d9d2017-01-24 17:10:51 +01004171 for cl in changes:
Daniel McArdlea23bf592019-02-12 00:25:12 +00004172 if cl.GetBranch() == current_branch:
Andrii Shyshkalovd0e1d9d2017-01-24 17:10:51 +01004173 break
dpranke@chromium.orgee87f582015-07-31 18:46:25 +00004174 if not cl.GetIssue():
vapiera7fbd5a2016-06-16 09:17:49 -07004175 print('No issue assigned.')
dpranke@chromium.orgee87f582015-07-31 18:46:25 +00004176 return 0
vapiera7fbd5a2016-06-16 09:17:49 -07004177 print('Issue number: %s (%s)' % (cl.GetIssue(), cl.GetIssueURL()))
maruel@chromium.org85616e02014-07-28 15:37:55 +00004178 if not options.fast:
vapiera7fbd5a2016-06-16 09:17:49 -07004179 print('Issue description:')
Edward Lemur6c6827c2020-02-06 21:15:18 +00004180 print(cl.FetchDescription(pretty=True))
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004181 return 0
4182
4183
maruel@chromium.org39c0b222013-08-17 16:57:01 +00004184def colorize_CMDstatus_doc():
4185 """To be called once in main() to add colors to git cl status help."""
4186 colors = [i for i in dir(Fore) if i[0].isupper()]
4187
4188 def colorize_line(line):
4189 for color in colors:
4190 if color in line.upper():
Quinten Yearsley0c62da92017-05-31 13:39:42 -07004191 # Extract whitespace first and the leading '-'.
maruel@chromium.org39c0b222013-08-17 16:57:01 +00004192 indent = len(line) - len(line.lstrip(' ')) + 1
4193 return line[:indent] + getattr(Fore, color) + line[indent:] + Fore.RESET
4194 return line
4195
4196 lines = CMDstatus.__doc__.splitlines()
4197 CMDstatus.__doc__ = '\n'.join(colorize_line(l) for l in lines)
4198
4199
phajdan.jre328cf92016-08-22 04:12:17 -07004200def write_json(path, contents):
Stefan Zager1306bd02017-06-22 19:26:46 -07004201 if path == '-':
4202 json.dump(contents, sys.stdout)
4203 else:
4204 with open(path, 'w') as f:
4205 json.dump(contents, f)
phajdan.jre328cf92016-08-22 04:12:17 -07004206
4207
maruel@chromium.org0633fb42013-08-16 20:06:14 +00004208@subcommand.usage('[issue_number]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004209@metrics.collector.collect_metrics('git cl issue')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004210def CMDissue(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004211 """Sets or displays the current code review issue number.
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004212
4213 Pass issue number 0 to clear the current issue.
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004214 """
dnj@chromium.org406c4402015-03-03 17:22:28 +00004215 parser.add_option('-r', '--reverse', action='store_true',
4216 help='Lookup the branch(es) for the specified issues. If '
4217 'no issues are specified, all branches with mapped '
4218 'issues will be listed.')
Stefan Zager1306bd02017-06-22 19:26:46 -07004219 parser.add_option('--json',
4220 help='Path to JSON output file, or "-" for stdout.')
dnj@chromium.org406c4402015-03-03 17:22:28 +00004221 options, args = parser.parse_args(args)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004222
dnj@chromium.org406c4402015-03-03 17:22:28 +00004223 if options.reverse:
4224 branches = RunGit(['for-each-ref', 'refs/heads',
Aaron Gablead64abd2017-12-04 09:49:13 -08004225 '--format=%(refname)']).splitlines()
dnj@chromium.org406c4402015-03-03 17:22:28 +00004226 # Reverse issue lookup.
4227 issue_branch_map = {}
Daniel Bratellb56a43a2018-09-06 15:49:03 +00004228
4229 git_config = {}
4230 for config in RunGit(['config', '--get-regexp',
4231 r'branch\..*issue']).splitlines():
4232 name, _space, val = config.partition(' ')
4233 git_config[name] = val
4234
dnj@chromium.org406c4402015-03-03 17:22:28 +00004235 for branch in branches:
Edward Lesmes50da7702020-03-30 19:23:43 +00004236 issue = git_config.get(
4237 'branch.%s.%s' % (scm.GIT.ShortBranchName(branch), ISSUE_CONFIG_KEY))
Edward Lemur52969c92020-02-06 18:15:28 +00004238 if issue:
4239 issue_branch_map.setdefault(int(issue), []).append(branch)
dnj@chromium.org406c4402015-03-03 17:22:28 +00004240 if not args:
Carlos Caballero81923d62020-07-06 18:22:27 +00004241 args = sorted(issue_branch_map.keys())
phajdan.jre328cf92016-08-22 04:12:17 -07004242 result = {}
dnj@chromium.org406c4402015-03-03 17:22:28 +00004243 for issue in args:
Lei Zhang5a368d42019-03-25 23:18:19 +00004244 try:
4245 issue_num = int(issue)
4246 except ValueError:
4247 print('ERROR cannot parse issue number: %s' % issue, file=sys.stderr)
dnj@chromium.org406c4402015-03-03 17:22:28 +00004248 continue
Lei Zhang5a368d42019-03-25 23:18:19 +00004249 result[issue_num] = issue_branch_map.get(issue_num)
vapiera7fbd5a2016-06-16 09:17:49 -07004250 print('Branch for issue number %s: %s' % (
Lei Zhang5a368d42019-03-25 23:18:19 +00004251 issue, ', '.join(issue_branch_map.get(issue_num) or ('None',))))
phajdan.jre328cf92016-08-22 04:12:17 -07004252 if options.json:
4253 write_json(options.json, result)
Aaron Gable78753da2017-06-15 10:35:49 -07004254 return 0
4255
4256 if len(args) > 0:
Edward Lemurf38bc172019-09-03 21:02:13 +00004257 issue = ParseIssueNumberArgument(args[0])
Aaron Gable78753da2017-06-15 10:35:49 -07004258 if not issue.valid:
4259 DieWithError('Pass a url or number to set the issue, 0 to unset it, '
4260 'or no argument to list it.\n'
4261 'Maybe you want to run git cl status?')
Edward Lemurf38bc172019-09-03 21:02:13 +00004262 cl = Changelist()
Aaron Gable78753da2017-06-15 10:35:49 -07004263 cl.SetIssue(issue.issue)
dnj@chromium.org406c4402015-03-03 17:22:28 +00004264 else:
Edward Lemurf38bc172019-09-03 21:02:13 +00004265 cl = Changelist()
Aaron Gable78753da2017-06-15 10:35:49 -07004266 print('Issue number: %s (%s)' % (cl.GetIssue(), cl.GetIssueURL()))
4267 if options.json:
4268 write_json(options.json, {
Nodir Turakulov27379632021-03-17 18:53:29 +00004269 'gerrit_host': cl.GetGerritHost(),
4270 'gerrit_project': cl.GetGerritProject(),
Aaron Gable78753da2017-06-15 10:35:49 -07004271 'issue_url': cl.GetIssueURL(),
Nodir Turakulov27379632021-03-17 18:53:29 +00004272 'issue': cl.GetIssue(),
Aaron Gable78753da2017-06-15 10:35:49 -07004273 })
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004274 return 0
4275
4276
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004277@metrics.collector.collect_metrics('git cl comments')
maruel@chromium.org9977a2e2012-06-06 22:30:56 +00004278def CMDcomments(parser, args):
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00004279 """Shows or posts review comments for any changelist."""
4280 parser.add_option('-a', '--add-comment', dest='comment',
4281 help='comment to add to an issue')
Sergiy Byelozyorovcb629a42018-10-28 19:20:39 +00004282 parser.add_option('-p', '--publish', action='store_true',
4283 help='marks CL as ready and sends comment to reviewers')
Andrii Shyshkalov0d6b46e2017-03-17 22:23:22 +01004284 parser.add_option('-i', '--issue', dest='issue',
Edward Lemurf38bc172019-09-03 21:02:13 +00004285 help='review issue id (defaults to current issue).')
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07004286 parser.add_option('-m', '--machine-readable', dest='readable',
4287 action='store_false', default=True,
4288 help='output comments in a format compatible with '
4289 'editor parsing')
smut@google.comc85ac942015-09-15 16:34:43 +00004290 parser.add_option('-j', '--json-file',
Stefan Zager1306bd02017-06-22 19:26:46 -07004291 help='File to write JSON summary to, or "-" for stdout')
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00004292 options, args = parser.parse_args(args)
maruel@chromium.org9977a2e2012-06-06 22:30:56 +00004293
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00004294 issue = None
4295 if options.issue:
4296 try:
4297 issue = int(options.issue)
4298 except ValueError:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004299 DieWithError('A review issue ID is expected to be a number.')
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00004300
Edward Lemur934836a2019-09-09 20:16:54 +00004301 cl = Changelist(issue=issue)
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00004302
4303 if options.comment:
Sergiy Byelozyorovcb629a42018-10-28 19:20:39 +00004304 cl.AddComment(options.comment, options.publish)
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00004305 return 0
4306
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07004307 summary = sorted(cl.GetCommentsSummary(readable=options.readable),
4308 key=lambda c: c.date)
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01004309 for comment in summary:
4310 if comment.disapproval:
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00004311 color = Fore.RED
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01004312 elif comment.approval:
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00004313 color = Fore.GREEN
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01004314 elif comment.sender == cl.GetIssueOwner():
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00004315 color = Fore.MAGENTA
Quinten Yearsley0e617c02019-02-20 00:37:03 +00004316 elif comment.autogenerated:
4317 color = Fore.CYAN
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00004318 else:
4319 color = Fore.BLUE
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01004320 print('\n%s%s %s%s\n%s' % (
4321 color,
4322 comment.date.strftime('%Y-%m-%d %H:%M:%S UTC'),
4323 comment.sender,
4324 Fore.RESET,
4325 '\n'.join(' ' + l for l in comment.message.strip().splitlines())))
4326
smut@google.comc85ac942015-09-15 16:34:43 +00004327 if options.json_file:
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01004328 def pre_serialize(c):
Edward Lemur79d4f992019-11-11 23:49:02 +00004329 dct = c._asdict().copy()
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01004330 dct['date'] = dct['date'].strftime('%Y-%m-%d %H:%M:%S.%f')
4331 return dct
Edward Lemur79d4f992019-11-11 23:49:02 +00004332 write_json(options.json_file, [pre_serialize(x) for x in summary])
maruel@chromium.org9977a2e2012-06-06 22:30:56 +00004333 return 0
4334
4335
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00004336@subcommand.usage('[codereview url or issue id]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004337@metrics.collector.collect_metrics('git cl description')
rsesek@chromium.orgeec76592013-05-20 16:27:57 +00004338def CMDdescription(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004339 """Brings up the editor for the current CL's description."""
smut@google.com34fb6b12015-07-13 20:03:26 +00004340 parser.add_option('-d', '--display', action='store_true',
4341 help='Display the description instead of opening an editor')
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00004342 parser.add_option('-n', '--new-description',
dnjba1b0f32016-09-02 12:37:42 -07004343 help='New description to set for this issue (- for stdin, '
4344 '+ to load from local commit HEAD)')
dsansomee2d6fd92016-09-08 00:10:47 -07004345 parser.add_option('-f', '--force', action='store_true',
4346 help='Delete any unpublished Gerrit edits for this issue '
4347 'without prompting')
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00004348
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00004349 options, args = parser.parse_args(args)
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00004350
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01004351 target_issue_arg = None
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00004352 if len(args) > 0:
Edward Lemurf38bc172019-09-03 21:02:13 +00004353 target_issue_arg = ParseIssueNumberArgument(args[0])
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01004354 if not target_issue_arg.valid:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004355 parser.error('Invalid issue ID or URL.')
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00004356
Edward Lemur934836a2019-09-09 20:16:54 +00004357 kwargs = {}
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01004358 if target_issue_arg:
4359 kwargs['issue'] = target_issue_arg.issue
4360 kwargs['codereview_host'] = target_issue_arg.hostname
martiniss6eda05f2016-06-30 10:18:35 -07004361
4362 cl = Changelist(**kwargs)
rsesek@chromium.orgeec76592013-05-20 16:27:57 +00004363 if not cl.GetIssue():
4364 DieWithError('This branch has no associated changelist.')
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004365
Edward Lemur678a6842019-10-03 22:25:05 +00004366 if args and not args[0].isdigit():
Edward Lemurf38bc172019-09-03 21:02:13 +00004367 logging.info('canonical issue/change URL: %s\n', cl.GetIssueURL())
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004368
Edward Lemur6c6827c2020-02-06 21:15:18 +00004369 description = ChangeDescription(cl.FetchDescription())
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00004370
smut@google.com34fb6b12015-07-13 20:03:26 +00004371 if options.display:
vapiera7fbd5a2016-06-16 09:17:49 -07004372 print(description.description)
smut@google.com34fb6b12015-07-13 20:03:26 +00004373 return 0
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00004374
4375 if options.new_description:
4376 text = options.new_description
4377 if text == '-':
4378 text = '\n'.join(l.rstrip() for l in sys.stdin)
dnjba1b0f32016-09-02 12:37:42 -07004379 elif text == '+':
4380 base_branch = cl.GetCommonAncestorWithUpstream()
Edward Lemura12175c2020-03-09 16:58:26 +00004381 text = _create_description_from_log([base_branch])
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00004382
4383 description.set_description(text)
4384 else:
Edward Lemurf38bc172019-09-03 21:02:13 +00004385 description.prompt()
Edward Lemur6c6827c2020-02-06 21:15:18 +00004386 if cl.FetchDescription().strip() != description.description:
dsansomee2d6fd92016-09-08 00:10:47 -07004387 cl.UpdateDescription(description.description, force=options.force)
rsesek@chromium.orgeec76592013-05-20 16:27:57 +00004388 return 0
4389
4390
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004391@metrics.collector.collect_metrics('git cl lint')
thestig@chromium.org44202a22014-03-11 19:22:18 +00004392def CMDlint(parser, args):
4393 """Runs cpplint on the current changelist."""
tzik@chromium.orgf204d4b2014-03-13 07:40:55 +00004394 parser.add_option('--filter', action='append', metavar='-x,+y',
4395 help='Comma-separated list of cpplint\'s category-filters')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004396 options, args = parser.parse_args(args)
thestig@chromium.org44202a22014-03-11 19:22:18 +00004397
4398 # Access to a protected member _XX of a client class
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -08004399 # pylint: disable=protected-access
thestig@chromium.org44202a22014-03-11 19:22:18 +00004400 try:
4401 import cpplint
4402 import cpplint_chromium
4403 except ImportError:
vapiera7fbd5a2016-06-16 09:17:49 -07004404 print('Your depot_tools is missing cpplint.py and/or cpplint_chromium.py.')
thestig@chromium.org44202a22014-03-11 19:22:18 +00004405 return 1
4406
4407 # Change the current working directory before calling lint so that it
4408 # shows the correct base.
4409 previous_cwd = os.getcwd()
4410 os.chdir(settings.GetRoot())
4411 try:
Edward Lemur934836a2019-09-09 20:16:54 +00004412 cl = Changelist()
Edward Lemur2c62b332020-03-12 22:12:33 +00004413 files = cl.GetAffectedFiles(cl.GetCommonAncestorWithUpstream())
thestig@chromium.org5839eb52014-05-30 16:20:51 +00004414 if not files:
vapiera7fbd5a2016-06-16 09:17:49 -07004415 print('Cannot lint an empty CL')
thestig@chromium.org5839eb52014-05-30 16:20:51 +00004416 return 1
thestig@chromium.org44202a22014-03-11 19:22:18 +00004417
Lei Zhangb8c62cf2020-07-15 20:09:37 +00004418 # Process cpplint arguments, if any.
4419 filters = presubmit_canned_checks.GetCppLintFilters(options.filter)
4420 command = ['--filter=' + ','.join(filters)] + args + files
tzik@chromium.orgf204d4b2014-03-13 07:40:55 +00004421 filenames = cpplint.ParseArguments(command)
thestig@chromium.org44202a22014-03-11 19:22:18 +00004422
Lei Zhang379d1ad2020-07-15 19:40:06 +00004423 include_regex = re.compile(settings.GetLintRegex())
4424 ignore_regex = re.compile(settings.GetLintIgnoreRegex())
thestig@chromium.org44202a22014-03-11 19:22:18 +00004425 extra_check_functions = [cpplint_chromium.CheckPointerDeclarationWhitespace]
4426 for filename in filenames:
Lei Zhang379d1ad2020-07-15 19:40:06 +00004427 if not include_regex.match(filename):
vapiera7fbd5a2016-06-16 09:17:49 -07004428 print('Skipping file %s' % filename)
Lei Zhang379d1ad2020-07-15 19:40:06 +00004429 continue
4430
4431 if ignore_regex.match(filename):
4432 print('Ignoring file %s' % filename)
4433 continue
4434
4435 cpplint.ProcessFile(filename, cpplint._cpplint_state.verbose_level,
4436 extra_check_functions)
thestig@chromium.org44202a22014-03-11 19:22:18 +00004437 finally:
4438 os.chdir(previous_cwd)
vapiera7fbd5a2016-06-16 09:17:49 -07004439 print('Total errors found: %d\n' % cpplint._cpplint_state.error_count)
thestig@chromium.org44202a22014-03-11 19:22:18 +00004440 if cpplint._cpplint_state.error_count != 0:
4441 return 1
4442 return 0
4443
4444
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004445@metrics.collector.collect_metrics('git cl presubmit')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004446def CMDpresubmit(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004447 """Runs presubmit tests on the current changelist."""
ilevy@chromium.org375a9022013-01-07 01:12:05 +00004448 parser.add_option('-u', '--upload', action='store_true',
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004449 help='Run upload hook instead of the push hook')
ilevy@chromium.org375a9022013-01-07 01:12:05 +00004450 parser.add_option('-f', '--force', action='store_true',
sbc@chromium.org495ad152012-09-04 23:07:42 +00004451 help='Run checks even if tree is dirty')
Aaron Gable8076c282017-11-29 14:39:41 -08004452 parser.add_option('--all', action='store_true',
4453 help='Run checks against all files, not just modified ones')
Josip Sokcevic017544d2022-03-31 23:47:53 +00004454 parser.add_option('--files',
4455 nargs=1,
4456 help='Semicolon-separated list of files to be marked as '
4457 'modified when executing presubmit or post-upload hooks. '
4458 'fnmatch wildcards can also be used.')
Edward Lesmes8e282792018-04-03 18:50:29 -04004459 parser.add_option('--parallel', action='store_true',
4460 help='Run all tests specified by input_api.RunTests in all '
4461 'PRESUBMIT files in parallel.')
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00004462 parser.add_option('--resultdb', action='store_true',
4463 help='Run presubmit checks in the ResultSink environment '
4464 'and send results to the ResultDB database.')
Saagar Sanghavi03b15132020-08-10 16:43:41 +00004465 parser.add_option('--realm', help='LUCI realm if reporting to ResultDB')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004466 options, args = parser.parse_args(args)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004467
sbc@chromium.org71437c02015-04-09 19:29:40 +00004468 if not options.force and git_common.is_dirty_git_tree('presubmit'):
vapiera7fbd5a2016-06-16 09:17:49 -07004469 print('use --force to check even if tree is dirty.')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004470 return 1
4471
Edward Lemur934836a2019-09-09 20:16:54 +00004472 cl = Changelist()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004473 if args:
4474 base_branch = args[0]
4475 else:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00004476 # Default to diffing against the common ancestor of the upstream branch.
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00004477 base_branch = cl.GetCommonAncestorWithUpstream()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004478
Bruce Dawsoneb8426e2022-08-05 23:58:15 +00004479 start = time.time()
4480 try:
4481 if not 'PRESUBMIT_SKIP_NETWORK' in os.environ and cl.GetIssue():
4482 description = cl.FetchDescription()
4483 else:
4484 description = _create_description_from_log([base_branch])
4485 except Exception as e:
4486 print('Failed to fetch CL description - %s' % str(e))
Edward Lemura12175c2020-03-09 16:58:26 +00004487 description = _create_description_from_log([base_branch])
Bruce Dawsoneb8426e2022-08-05 23:58:15 +00004488 elapsed = time.time() - start
4489 if elapsed > 5:
4490 print('%.1f s to get CL description.' % elapsed)
Aaron Gable8076c282017-11-29 14:39:41 -08004491
Bruce Dawson13acea32022-05-03 22:13:08 +00004492 if not base_branch:
4493 if not options.force:
4494 print('use --force to check even when not on a branch.')
4495 return 1
4496 base_branch = 'HEAD'
4497
Josip Sokcevic017544d2022-03-31 23:47:53 +00004498 cl.RunHook(committing=not options.upload,
4499 may_prompt=False,
4500 verbose=options.verbose,
4501 parallel=options.parallel,
4502 upstream=base_branch,
4503 description=description,
4504 all_files=options.all,
4505 files=options.files,
4506 resultdb=options.resultdb,
4507 realm=options.realm)
dpranke@chromium.org0a2bb372011-03-25 01:16:22 +00004508 return 0
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004509
4510
tandrii@chromium.org65874e12016-03-04 12:03:02 +00004511def GenerateGerritChangeId(message):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004512 """Returns the Change ID footer value (Ixxxxxx...xxx).
tandrii@chromium.org65874e12016-03-04 12:03:02 +00004513
4514 Works the same way as
4515 https://gerrit-review.googlesource.com/tools/hooks/commit-msg
4516 but can be called on demand on all platforms.
4517
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004518 The basic idea is to generate git hash of a state of the tree, original
4519 commit message, author/committer info and timestamps.
tandrii@chromium.org65874e12016-03-04 12:03:02 +00004520 """
4521 lines = []
4522 tree_hash = RunGitSilent(['write-tree'])
4523 lines.append('tree %s' % tree_hash.strip())
4524 code, parent = RunGitWithCode(['rev-parse', 'HEAD~0'], suppress_stderr=False)
4525 if code == 0:
4526 lines.append('parent %s' % parent.strip())
4527 author = RunGitSilent(['var', 'GIT_AUTHOR_IDENT'])
4528 lines.append('author %s' % author.strip())
4529 committer = RunGitSilent(['var', 'GIT_COMMITTER_IDENT'])
4530 lines.append('committer %s' % committer.strip())
4531 lines.append('')
4532 # Note: Gerrit's commit-hook actually cleans message of some lines and
4533 # whitespace. This code is not doing this, but it clearly won't decrease
4534 # entropy.
4535 lines.append(message)
4536 change_hash = RunCommand(['git', 'hash-object', '-t', 'commit', '--stdin'],
Raul Tambreb946b232019-03-26 14:48:46 +00004537 stdin=('\n'.join(lines)).encode())
tandrii@chromium.org65874e12016-03-04 12:03:02 +00004538 return 'I%s' % change_hash.strip()
4539
4540
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01004541def GetTargetRef(remote, remote_branch, target_branch):
wittman@chromium.org455dc922015-01-26 20:15:50 +00004542 """Computes the remote branch ref to use for the CL.
4543
4544 Args:
4545 remote (str): The git remote for the CL.
4546 remote_branch (str): The git remote branch for the CL.
4547 target_branch (str): The target branch specified by the user.
wittman@chromium.org455dc922015-01-26 20:15:50 +00004548 """
4549 if not (remote and remote_branch):
4550 return None
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00004551
wittman@chromium.org455dc922015-01-26 20:15:50 +00004552 if target_branch:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07004553 # Canonicalize branch references to the equivalent local full symbolic
wittman@chromium.org455dc922015-01-26 20:15:50 +00004554 # refs, which are then translated into the remote full symbolic refs
4555 # below.
4556 if '/' not in target_branch:
4557 remote_branch = 'refs/remotes/%s/%s' % (remote, target_branch)
4558 else:
4559 prefix_replacements = (
4560 ('^((refs/)?remotes/)?branch-heads/', 'refs/remotes/branch-heads/'),
4561 ('^((refs/)?remotes/)?%s/' % remote, 'refs/remotes/%s/' % remote),
4562 ('^(refs/)?heads/', 'refs/remotes/%s/' % remote),
4563 )
4564 match = None
4565 for regex, replacement in prefix_replacements:
4566 match = re.search(regex, target_branch)
4567 if match:
4568 remote_branch = target_branch.replace(match.group(0), replacement)
4569 break
4570 if not match:
4571 # This is a branch path but not one we recognize; use as-is.
4572 remote_branch = target_branch
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +00004573 # pylint: disable=consider-using-get
rmistry@google.comc68112d2015-03-03 12:48:06 +00004574 elif remote_branch in REFS_THAT_ALIAS_TO_OTHER_REFS:
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +00004575 # pylint: enable=consider-using-get
rmistry@google.comc68112d2015-03-03 12:48:06 +00004576 # Handle the refs that need to land in different refs.
4577 remote_branch = REFS_THAT_ALIAS_TO_OTHER_REFS[remote_branch]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00004578
wittman@chromium.org455dc922015-01-26 20:15:50 +00004579 # Create the true path to the remote branch.
4580 # Does the following translation:
4581 # * refs/remotes/origin/refs/diff/test -> refs/diff/test
Josip Sokcevicc39ab992020-09-24 20:09:15 +00004582 # * refs/remotes/origin/main -> refs/heads/main
wittman@chromium.org455dc922015-01-26 20:15:50 +00004583 # * refs/remotes/branch-heads/test -> refs/branch-heads/test
4584 if remote_branch.startswith('refs/remotes/%s/refs/' % remote):
4585 remote_branch = remote_branch.replace('refs/remotes/%s/' % remote, '')
4586 elif remote_branch.startswith('refs/remotes/%s/' % remote):
4587 remote_branch = remote_branch.replace('refs/remotes/%s/' % remote,
4588 'refs/heads/')
4589 elif remote_branch.startswith('refs/remotes/branch-heads'):
4590 remote_branch = remote_branch.replace('refs/remotes/', 'refs/')
Andrii Shyshkalov768f1d82016-12-08 15:10:13 +01004591
wittman@chromium.org455dc922015-01-26 20:15:50 +00004592 return remote_branch
4593
4594
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00004595def cleanup_list(l):
4596 """Fixes a list so that comma separated items are put as individual items.
4597
4598 So that "--reviewers joe@c,john@c --reviewers joa@c" results in
4599 options.reviewers == sorted(['joe@c', 'john@c', 'joa@c']).
4600 """
4601 items = sum((i.split(',') for i in l), [])
4602 stripped_items = (i.strip() for i in items)
4603 return sorted(filter(None, stripped_items))
4604
4605
Aaron Gable4db38df2017-11-03 14:59:07 -07004606@subcommand.usage('[flags]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004607@metrics.collector.collect_metrics('git cl upload')
ukai@chromium.orge8077812012-02-03 03:41:46 +00004608def CMDupload(parser, args):
rmistry@google.com78948ed2015-07-08 23:09:57 +00004609 """Uploads the current changelist to codereview.
4610
4611 Can skip dependency patchset uploads for a branch by running:
4612 git config branch.branch_name.skip-deps-uploads True
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004613 To unset, run:
rmistry@google.com78948ed2015-07-08 23:09:57 +00004614 git config --unset branch.branch_name.skip-deps-uploads
4615 Can also set the above globally by using the --global flag.
Dominic Battre7d1c4842017-10-27 09:17:28 +02004616
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004617 If the name of the checked out branch starts with "bug-" or "fix-" followed
4618 by a bug number, this bug number is automatically populated in the CL
Dominic Battre7d1c4842017-10-27 09:17:28 +02004619 description.
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004620
4621 If subject contains text in square brackets or has "<text>: " prefix, such
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004622 text(s) is treated as Gerrit hashtags. For example, CLs with subjects:
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004623 [git-cl] add support for hashtags
4624 Foo bar: implement foo
4625 will be hashtagged with "git-cl" and "foo-bar" respectively.
rmistry@google.com78948ed2015-07-08 23:09:57 +00004626 """
ukai@chromium.orge8077812012-02-03 03:41:46 +00004627 parser.add_option('--bypass-hooks', action='store_true', dest='bypass_hooks',
4628 help='bypass upload presubmit hook')
brettw@chromium.orgb65c43c2013-06-10 22:04:49 +00004629 parser.add_option('--bypass-watchlists', action='store_true',
4630 dest='bypass_watchlists',
4631 help='bypass watchlists auto CC-ing reviewers')
Aaron Gablef7543cd2017-07-20 14:26:31 -07004632 parser.add_option('-f', '--force', action='store_true', dest='force',
ukai@chromium.orge8077812012-02-03 03:41:46 +00004633 help="force yes to questions (don't prompt)")
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004634 parser.add_option('--message', '-m', dest='message',
4635 help='message for patchset')
tandriif9aefb72016-07-01 09:06:51 -07004636 parser.add_option('-b', '--bug',
4637 help='pre-populate the bug number(s) for this issue. '
4638 'If several, separate with commas')
tandriib80458a2016-06-23 12:20:07 -07004639 parser.add_option('--message-file', dest='message_file',
4640 help='file which contains message for patchset')
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004641 parser.add_option('--title', '-t', dest='title',
4642 help='title for patchset')
Mario Bianuccicebfb4e2020-07-22 23:08:16 +00004643 parser.add_option('-T', '--skip-title', action='store_true',
4644 dest='skip_title',
4645 help='Use the most recent commit message as the title of '
4646 'the patchset')
ukai@chromium.orge8077812012-02-03 03:41:46 +00004647 parser.add_option('-r', '--reviewers',
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00004648 action='append', default=[],
ukai@chromium.orge8077812012-02-03 03:41:46 +00004649 help='reviewer email addresses')
4650 parser.add_option('--cc',
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00004651 action='append', default=[],
ukai@chromium.orge8077812012-02-03 03:41:46 +00004652 help='cc email addresses')
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004653 parser.add_option('--hashtag', dest='hashtags',
4654 action='append', default=[],
4655 help=('Gerrit hashtag for new CL; '
4656 'can be applied multiple times'))
Thiago Perrottab0fb8d52022-08-30 21:26:19 +00004657 parser.add_option('-s',
4658 '--send-mail',
4659 '--send-email',
4660 dest='send_mail',
4661 action='store_true',
Aaron Gable59f48512017-01-12 10:54:46 -08004662 help='send email to reviewer(s) and cc(s) immediately')
ukai@chromium.org8ef7ab22012-11-28 04:24:52 +00004663 parser.add_option('--target_branch',
pgervais@chromium.orgb9f27512014-08-08 15:52:33 +00004664 '--target-branch',
wittman@chromium.org455dc922015-01-26 20:15:50 +00004665 metavar='TARGET',
4666 help='Apply CL to remote ref TARGET. ' +
Josip Sokcevicc39ab992020-09-24 20:09:15 +00004667 'Default: remote branch head, or main')
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00004668 parser.add_option('--squash', action='store_true',
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004669 help='Squash multiple commits into one')
Mike Frysingera989d552019-08-14 20:51:23 +00004670 parser.add_option('--no-squash', action='store_false', dest='squash',
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004671 help='Don\'t squash multiple commits into one')
rmistry9eadede2016-09-19 11:22:43 -07004672 parser.add_option('--topic', default=None,
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004673 help='Topic to specify when uploading')
Robert Iannuccif2708bd2017-04-17 15:49:02 -07004674 parser.add_option('--r-owners', dest='add_owners_to', action='store_const',
4675 const='R', help='add a set of OWNERS to R')
Thiago Perrottab0fb8d52022-08-30 21:26:19 +00004676 parser.add_option('-c',
4677 '--use-commit-queue',
4678 action='store_true',
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004679 default=False,
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +00004680 help='tell the CQ to commit this patchset; '
Thiago Perrottab0fb8d52022-08-30 21:26:19 +00004681 'implies --send-mail')
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004682 parser.add_option('-d', '--cq-dry-run',
4683 action='store_true', default=False,
rmistry@google.comef966222015-04-07 11:15:01 +00004684 help='Send the patchset to do a CQ dry run right after '
4685 'upload.')
Greg Gutermanbe5fccd2021-06-14 17:58:20 +00004686 parser.add_option(
4687 '-q',
4688 '--cq-quick-run',
4689 action='store_true',
4690 default=False,
4691 help='Send the patchset to do a CQ quick run right after '
4692 'upload (https://source.chromium.org/chromium/chromium/src/+/main:do'
4693 'cs/cq_quick_run.md) (chromium only).')
Edward Lesmes10c3dd62021-02-08 21:13:57 +00004694 parser.add_option('--set-bot-commit', action='store_true',
4695 help=optparse.SUPPRESS_HELP)
Andrii Shyshkalov71f0da32019-07-15 22:45:18 +00004696 parser.add_option('--preserve-tryjobs', action='store_true',
4697 help='instruct the CQ to let tryjobs running even after '
4698 'new patchsets are uploaded instead of canceling '
4699 'prior patchset\' tryjobs')
rmistry@google.com2dd99862015-06-22 12:22:18 +00004700 parser.add_option('--dependencies', action='store_true',
4701 help='Uploads CLs of all the local branches that depend on '
4702 'the current branch')
Ravi Mistry31e7d562018-04-02 12:53:57 -04004703 parser.add_option('-a', '--enable-auto-submit', action='store_true',
4704 help='Sends your change to the CQ after an approval. Only '
4705 'works on repos that have the Auto-Submit label '
4706 'enabled')
Edward Lesmes8e282792018-04-03 18:50:29 -04004707 parser.add_option('--parallel', action='store_true',
4708 help='Run all tests specified by input_api.RunTests in all '
4709 'PRESUBMIT files in parallel.')
Sergiy Byelozyorov1aa405f2018-09-18 17:38:43 +00004710 parser.add_option('--no-autocc', action='store_true',
4711 help='Disables automatic addition of CC emails')
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004712 parser.add_option('--private', action='store_true',
Sergiy Byelozyorov1aa405f2018-09-18 17:38:43 +00004713 help='Set the review private. This implies --no-autocc.')
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004714 parser.add_option('-R', '--retry-failed', action='store_true',
4715 help='Retry failed tryjobs from old patchset immediately '
4716 'after uploading new patchset. Cannot be used with '
4717 '--use-commit-queue or --cq-dry-run.')
Dan Beamd8b04ca2019-10-10 21:23:26 +00004718 parser.add_option('--fixed', '-x',
4719 help='List of bugs that will be commented on and marked '
4720 'fixed (pre-populates "Fixed:" tag). Same format as '
4721 '-b option / "Bug:" tag. If fixing several issues, '
4722 'separate with commas.')
Josipe827b0f2020-01-30 00:07:20 +00004723 parser.add_option('--edit-description', action='store_true', default=False,
4724 help='Modify description before upload. Cannot be used '
4725 'with --force. It is a noop when --no-squash is set '
4726 'or a new commit is created.')
Ng Zhi Ancdaf0be2020-05-27 20:57:28 +00004727 parser.add_option('--git-completion-helper', action="store_true",
4728 help=optparse.SUPPRESS_HELP)
Josip Sokcevicf2cfd3d2021-03-30 18:39:18 +00004729 parser.add_option('-o',
4730 '--push-options',
4731 action='append',
4732 default=[],
4733 help='Transmit the given string to the server when '
4734 'performing git push (pass-through). See git-push '
4735 'documentation for more details.')
Gregory Nisbet48d9e1e2021-04-15 23:35:54 +00004736 parser.add_option('--no-add-changeid',
4737 action='store_true',
4738 dest='no_add_changeid',
4739 help='Do not add change-ids to messages.')
Brian Sheedy7326ca22022-11-02 18:36:17 +00004740 parser.add_option('--no-python2-post-upload-hooks',
4741 action='store_true',
4742 help='Only run post-upload hooks in Python 3.')
Joanna Wang18de1f62023-01-21 01:24:24 +00004743 parser.add_option('--stacked-exp',
4744 action='store_true',
4745 help=optparse.SUPPRESS_HELP)
Joanna Wanga1abbed2023-01-24 01:41:05 +00004746 # TODO(b/265929888): Add --wip option of --cl-status option.
Sergiy Byelozyorov1aa405f2018-09-18 17:38:43 +00004747
rmistry@google.com2dd99862015-06-22 12:22:18 +00004748 orig_args = args
ukai@chromium.orge8077812012-02-03 03:41:46 +00004749 (options, args) = parser.parse_args(args)
4750
Ng Zhi Ancdaf0be2020-05-27 20:57:28 +00004751 if options.git_completion_helper:
Edward Lesmesb7db1832020-06-22 20:22:27 +00004752 print(' '.join(opt.get_opt_string() for opt in parser.option_list
4753 if opt.help != optparse.SUPPRESS_HELP))
4754 return
Ng Zhi Ancdaf0be2020-05-27 20:57:28 +00004755
sbc@chromium.org71437c02015-04-09 19:29:40 +00004756 if git_common.is_dirty_git_tree('upload'):
ukai@chromium.orge8077812012-02-03 03:41:46 +00004757 return 1
4758
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00004759 options.reviewers = cleanup_list(options.reviewers)
4760 options.cc = cleanup_list(options.cc)
4761
Josipe827b0f2020-01-30 00:07:20 +00004762 if options.edit_description and options.force:
4763 parser.error('Only one of --force and --edit-description allowed')
4764
tandriib80458a2016-06-23 12:20:07 -07004765 if options.message_file:
4766 if options.message:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004767 parser.error('Only one of --message and --message-file allowed.')
tandriib80458a2016-06-23 12:20:07 -07004768 options.message = gclient_utils.FileRead(options.message_file)
tandriib80458a2016-06-23 12:20:07 -07004769
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004770 if ([options.cq_dry_run,
Greg Gutermanbe5fccd2021-06-14 17:58:20 +00004771 options.cq_quick_run,
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004772 options.use_commit_queue,
4773 options.retry_failed].count(True) > 1):
Greg Gutermanbe5fccd2021-06-14 17:58:20 +00004774 parser.error('Only one of --use-commit-queue, --cq-dry-run, --cq-quick-run '
4775 'or --retry-failed is allowed.')
tandrii4d0545a2016-07-06 03:56:49 -07004776
Mario Bianuccicebfb4e2020-07-22 23:08:16 +00004777 if options.skip_title and options.title:
4778 parser.error('Only one of --title and --skip-title allowed.')
4779
Aaron Gableedbc4132017-09-11 13:22:28 -07004780 if options.use_commit_queue:
4781 options.send_mail = True
4782
Edward Lesmes0dd54822020-03-26 18:24:25 +00004783 if options.squash is None:
4784 # Load default for user, repo, squash=true, in this order.
4785 options.squash = settings.GetSquashGerritUploads()
4786
Joanna Wangdd12deb2023-01-26 20:43:28 +00004787 if os.environ.get('DOGFOOD_STACKED_CHANGES') == '1':
4788 if options.dependencies:
4789 parser.error('--dependencies is not available for this workflow.')
Joanna Wang18de1f62023-01-21 01:24:24 +00004790
4791 UploadAllSquashed(options, orig_args)
4792 return 0
4793
Josip Sokcevic1cabb172021-04-08 19:15:35 +00004794 cl = Changelist(branchref=options.target_branch)
Edward Lesmes7677e5c2020-02-19 20:39:03 +00004795 # Warm change details cache now to avoid RPCs later, reducing latency for
4796 # developers.
4797 if cl.GetIssue():
4798 cl._GetChangeDetail(
4799 ['DETAILED_ACCOUNTS', 'CURRENT_REVISION', 'CURRENT_COMMIT', 'LABELS'])
4800
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004801 if options.retry_failed and not cl.GetIssue():
4802 print('No previous patchsets, so --retry-failed has no effect.')
4803 options.retry_failed = False
Edward Lesmes7677e5c2020-02-19 20:39:03 +00004804
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004805 # cl.GetMostRecentPatchset uses cached information, and can return the last
4806 # patchset before upload. Calling it here makes it clear that it's the
4807 # last patchset before upload. Note that GetMostRecentPatchset will fail
4808 # if no CL has been uploaded yet.
4809 if options.retry_failed:
4810 patchset = cl.GetMostRecentPatchset()
Andrii Shyshkalov9f274432018-10-15 16:40:23 +00004811
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004812 ret = cl.CMDUpload(options, args, orig_args)
4813
4814 if options.retry_failed:
4815 if ret != 0:
4816 print('Upload failed, so --retry-failed has no effect.')
4817 return ret
Joanna Wanga8db0cb2023-01-24 15:43:17 +00004818 builds, _ = _fetch_latest_builds(cl,
4819 DEFAULT_BUILDBUCKET_HOST,
4820 latest_patchset=patchset)
Edward Lemur45768512020-03-02 19:03:14 +00004821 jobs = _filter_failed_for_retry(builds)
4822 if len(jobs) == 0:
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004823 print('No failed tryjobs, so --retry-failed has no effect.')
4824 return ret
Quinten Yearsley777660f2020-03-04 23:37:06 +00004825 _trigger_tryjobs(cl, jobs, options, patchset + 1)
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004826
4827 return ret
ukai@chromium.orge8077812012-02-03 03:41:46 +00004828
4829
Joanna Wang18de1f62023-01-21 01:24:24 +00004830def UploadAllSquashed(options, orig_args):
4831 # type: (optparse.Values, Sequence[str]) -> Tuple[Sequence[Changelist], bool]
4832 """Uploads the current and upstream branches (if necessary)."""
Joanna Wangc710e2d2023-01-25 14:53:22 +00004833 cls, cherry_pick_current = _UploadAllPrecheck(options, orig_args)
Joanna Wang18de1f62023-01-21 01:24:24 +00004834
Joanna Wangc710e2d2023-01-25 14:53:22 +00004835 # Create commits.
4836 uploads_by_cl = [] #type: Sequence[Tuple[Changelist, _NewUpload]]
4837 if cherry_pick_current:
4838 parent = cls[1]._GitGetBranchConfigValue(GERRIT_SQUASH_HASH_CONFIG_KEY)
4839 new_upload = cls[0].PrepareCherryPickSquashedCommit(options, parent)
4840 uploads_by_cl.append((cls[0], new_upload))
4841 else:
4842 parent = None
4843 ordered_cls = list(reversed(cls))
4844
4845 for i, cl in enumerate(ordered_cls):
4846 # If we're in the middle of the stack, set end_commit to downstream's
4847 # direct ancestor.
4848 if i + 1 < len(ordered_cls):
4849 child_base_commit = ordered_cls[i + 1].GetCommonAncestorWithUpstream()
4850 else:
4851 child_base_commit = None
4852 new_upload = cl.PrepareSquashedCommit(options,
4853 parent=parent,
4854 end_commit=child_base_commit)
4855 uploads_by_cl.append((cl, new_upload))
4856
4857 parent = new_upload.commit_to_push
4858
4859 # Create refspec options
4860 cl, new_upload = uploads_by_cl[-1]
4861 refspec_opts = cl._GetRefSpecOptions(
4862 options,
4863 new_upload.change_desc,
Joanna Wang562481d2023-01-26 21:57:14 +00004864 multi_change_upload=len(uploads_by_cl) > 1,
4865 dogfood_path=True)
Joanna Wangc710e2d2023-01-25 14:53:22 +00004866 refspec_suffix = ''
4867 if refspec_opts:
4868 refspec_suffix = '%' + ','.join(refspec_opts)
4869 assert ' ' not in refspec_suffix, ('spaces not allowed in refspec: "%s"' %
4870 refspec_suffix)
4871
4872 remote, remote_branch = cl.GetRemoteBranch()
4873 branch = GetTargetRef(remote, remote_branch, options.target_branch)
4874 refspec = '%s:refs/for/%s%s' % (new_upload.commit_to_push, branch,
4875 refspec_suffix)
4876
4877 # Git push
4878 git_push_metadata = {
4879 'gerrit_host':
4880 cl.GetGerritHost(),
4881 'title':
4882 options.title or '<untitled>',
4883 'change_id':
4884 git_footers.get_footer_change_id(new_upload.change_desc.description),
4885 'description':
4886 new_upload.change_desc.description,
4887 }
4888 push_stdout = cl._RunGitPushWithTraces(refspec, refspec_opts,
4889 git_push_metadata)
4890
4891 # Post push updates
4892 regex = re.compile(r'remote:\s+https?://[\w\-\.\+\/#]*/(\d+)\s.*')
4893 change_numbers = [
4894 m.group(1) for m in map(regex.match, push_stdout.splitlines()) if m
4895 ]
4896
4897 for i, (cl, new_upload) in enumerate(uploads_by_cl):
4898 cl.PostUploadUpdates(options, new_upload, change_numbers[i])
4899
4900 return 0
Joanna Wang18de1f62023-01-21 01:24:24 +00004901
4902
4903def _UploadAllPrecheck(options, orig_args):
4904 # type: (optparse.Values, Sequence[str]) -> Tuple[Sequence[Changelist], bool]
4905 """Checks the state of the tree and gives the user uploading options
4906
4907 Returns: A tuple of the ordered list of changes that have new commits
4908 since their last upload and a boolean of whether the user wants to
4909 cherry-pick and upload the current branch instead of uploading all cls.
4910 """
4911 branch_ref = None
4912 cls = []
4913 must_upload_upstream = False
4914
4915 Changelist._GerritCommitMsgHookCheck(offer_removal=not options.force)
4916
4917 while True:
4918 if len(cls) > _MAX_STACKED_BRANCHES_UPLOAD:
4919 DieWithError(
4920 'More than %s branches in the stack have not been uploaded.\n'
4921 'Are your branches in a misconfigured state?\n'
4922 'If not, please upload some upstream changes first.' %
4923 (_MAX_STACKED_BRANCHES_UPLOAD))
4924
4925 cl = Changelist(branchref=branch_ref)
4926 cls.append(cl)
4927
4928 origin, upstream_branch_ref = Changelist.FetchUpstreamTuple(cl.GetBranch())
4929 upstream_branch = scm.GIT.ShortBranchName(upstream_branch_ref)
4930 branch_ref = upstream_branch_ref # set branch for next run.
4931
4932 # Case 1: We've reached the beginning of the tree.
4933 if origin != '.':
4934 break
4935
4936 upstream_last_upload = scm.GIT.GetBranchConfig(settings.GetRoot(),
4937 upstream_branch,
4938 LAST_UPLOAD_HASH_CONFIG_KEY)
4939
4940 # Case 2: If any upstream branches have never been uploaded,
4941 # the user MUST upload them.
4942 if not upstream_last_upload:
4943 must_upload_upstream = True
4944 continue
4945
4946 base_commit = cl.GetCommonAncestorWithUpstream()
4947
4948 # Case 3: If upstream's last_upload == cl.base_commit we do
4949 # not need to upload any more upstreams from this point on.
4950 # (Even if there may be diverged branches higher up the tree)
4951 if base_commit == upstream_last_upload:
4952 break
4953
4954 # Case 4: If upstream's last_upload < cl.base_commit we are
4955 # uploading cl and upstream_cl.
4956 # Continue up the tree to check other branch relations.
Joanna Wangab9c6ba2023-01-21 01:46:36 +00004957 if scm.GIT.IsAncestor(upstream_last_upload, base_commit):
Joanna Wang18de1f62023-01-21 01:24:24 +00004958 continue
4959
4960 # Case 5: If cl.base_commit < upstream's last_upload the user
4961 # must rebase before uploading.
Joanna Wangab9c6ba2023-01-21 01:46:36 +00004962 if scm.GIT.IsAncestor(base_commit, upstream_last_upload):
Joanna Wang18de1f62023-01-21 01:24:24 +00004963 DieWithError(
4964 'At least one branch in the stack has diverged from its upstream '
4965 'branch and does not contain its upstream\'s last upload.\n'
4966 'Please rebase the stack with `git rebase-update` before uploading.')
4967
4968 # The tree went through a rebase. LAST_UPLOAD_HASH_CONFIG_KEY no longer has
4969 # any relation to commits in the tree. Continue up the tree until we hit
4970 # the root.
4971
4972 # We assume all cls in the stack have the same auth requirements and only
4973 # check this once.
4974 cls[0].EnsureAuthenticated(force=options.force)
4975
4976 cherry_pick = False
4977 if len(cls) > 1:
4978 message = ''
4979 if len(orig_args):
4980 message = ('options %s will be used for all uploads.\n' % orig_args)
4981 if must_upload_upstream:
4982 confirm_or_exit('\n' + message +
4983 'There are upstream branches that must be uploaded.\n')
4984 else:
4985 answer = gclient_utils.AskForData(
4986 '\n' + message +
4987 'Press enter to update branches %s.\nOr type `n` to upload only '
4988 '`%s` cherry-picked on %s\'s last upload:' %
4989 ([cl.branch for cl in cls], cls[0].branch, cls[1].branch))
4990 if answer.lower() == 'n':
4991 cherry_pick = True
4992 return cls, cherry_pick
4993
4994
Francois Dorayd42c6812017-05-30 15:10:20 -04004995@subcommand.usage('--description=<description file>')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004996@metrics.collector.collect_metrics('git cl split')
Francois Dorayd42c6812017-05-30 15:10:20 -04004997def CMDsplit(parser, args):
4998 """Splits a branch into smaller branches and uploads CLs.
4999
5000 Creates a branch and uploads a CL for each group of files modified in the
5001 current branch that share a common OWNERS file. In the CL description and
Edward Lemurac5c55f2020-02-29 00:17:16 +00005002 comment, the string '$directory', is replaced with the directory containing
5003 the shared OWNERS file.
Francois Dorayd42c6812017-05-30 15:10:20 -04005004 """
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005005 parser.add_option('-d', '--description', dest='description_file',
5006 help='A text file containing a CL description in which '
5007 '$directory will be replaced by each CL\'s directory.')
5008 parser.add_option('-c', '--comment', dest='comment_file',
5009 help='A text file containing a CL comment.')
5010 parser.add_option('-n', '--dry-run', dest='dry_run', action='store_true',
Chris Watkinsba28e462017-12-13 11:22:17 +11005011 default=False,
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005012 help='List the files and reviewers for each CL that would '
5013 'be created, but don\'t create branches or CLs.')
5014 parser.add_option('--cq-dry-run', action='store_true',
5015 help='If set, will do a cq dry run for each uploaded CL. '
5016 'Please be careful when doing this; more than ~10 CLs '
5017 'has the potential to overload our build '
5018 'infrastructure. Try to upload these not during high '
5019 'load times (usually 11-3 Mountain View time). Email '
5020 'infra-dev@chromium.org with any questions.')
Takuto Ikuta51eca592019-02-14 19:40:52 +00005021 parser.add_option('-a', '--enable-auto-submit', action='store_true',
5022 default=True,
5023 help='Sends your change to the CQ after an approval. Only '
5024 'works on repos that have the Auto-Submit label '
5025 'enabled')
Daniel Cheng403c44e2022-10-05 22:24:58 +00005026 parser.add_option('--max-depth',
5027 type='int',
5028 default=0,
5029 help='The max depth to look for OWNERS files. Useful for '
5030 'controlling the granularity of the split CLs, e.g. '
5031 '--max-depth=1 will only split by top-level '
5032 'directory. Specifying a value less than 1 means no '
5033 'limit on max depth.')
Francois Dorayd42c6812017-05-30 15:10:20 -04005034 options, _ = parser.parse_args(args)
5035
5036 if not options.description_file:
5037 parser.error('No --description flag specified.')
5038
5039 def WrappedCMDupload(args):
5040 return CMDupload(OptionParser(), args)
5041
Daniel Cheng403c44e2022-10-05 22:24:58 +00005042 return split_cl.SplitCl(options.description_file, options.comment_file,
5043 Changelist, WrappedCMDupload, options.dry_run,
5044 options.cq_dry_run, options.enable_auto_submit,
5045 options.max_depth, settings.GetRoot())
Francois Dorayd42c6812017-05-30 15:10:20 -04005046
5047
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08005048@subcommand.usage('DEPRECATED')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005049@metrics.collector.collect_metrics('git cl commit')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005050def CMDdcommit(parser, args):
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08005051 """DEPRECATED: Used to commit the current changelist via git-svn."""
5052 message = ('git-cl no longer supports committing to SVN repositories via '
5053 'git-svn. You probably want to use `git cl land` instead.')
5054 print(message)
5055 return 1
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005056
5057
maruel@chromium.org0633fb42013-08-16 20:06:14 +00005058@subcommand.usage('[upstream branch to apply against]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005059@metrics.collector.collect_metrics('git cl land')
pgervais@chromium.orgcee6dc42014-05-07 17:04:03 +00005060def CMDland(parser, args):
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08005061 """Commits the current changelist via git.
5062
5063 In case of Gerrit, uses Gerrit REST api to "submit" the issue, which pushes
5064 upstream and closes the issue automatically and atomically.
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08005065 """
5066 parser.add_option('--bypass-hooks', action='store_true', dest='bypass_hooks',
5067 help='bypass upload presubmit hook')
Aaron Gablef7543cd2017-07-20 14:26:31 -07005068 parser.add_option('-f', '--force', action='store_true', dest='force',
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08005069 help="force yes to questions (don't prompt)")
Edward Lesmes67b3faa2018-04-13 17:50:52 -04005070 parser.add_option('--parallel', action='store_true',
5071 help='Run all tests specified by input_api.RunTests in all '
5072 'PRESUBMIT files in parallel.')
Saagar Sanghavi03b15132020-08-10 16:43:41 +00005073 parser.add_option('--resultdb', action='store_true',
5074 help='Run presubmit checks in the ResultSink environment '
5075 'and send results to the ResultDB database.')
5076 parser.add_option('--realm', help='LUCI realm if reporting to ResultDB')
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08005077 (options, args) = parser.parse_args(args)
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08005078
Edward Lemur934836a2019-09-09 20:16:54 +00005079 cl = Changelist()
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08005080
Robert Iannucci2e73d432018-03-14 01:10:47 -07005081 if not cl.GetIssue():
5082 DieWithError('You must upload the change first to Gerrit.\n'
5083 ' If you would rather have `git cl land` upload '
5084 'automatically for you, see http://crbug.com/642759')
Saagar Sanghavi03b15132020-08-10 16:43:41 +00005085 return cl.CMDLand(options.force, options.bypass_hooks, options.verbose,
5086 options.parallel, options.resultdb, options.realm)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005087
5088
dsinclair@chromium.orgfbed6562015-09-25 21:22:36 +00005089@subcommand.usage('<patch url or issue id or issue url>')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005090@metrics.collector.collect_metrics('git cl patch')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005091def CMDpatch(parser, args):
marq@chromium.orge5e59002013-10-02 23:21:25 +00005092 """Patches in a code review."""
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005093 parser.add_option('-b', dest='newbranch',
5094 help='create a new branch off trunk for the patch')
qsr@chromium.org1ef44af2013-10-16 16:24:32 +00005095 parser.add_option('-f', '--force', action='store_true',
Aaron Gable62619a32017-06-16 08:22:09 -07005096 help='overwrite state on the current or chosen branch')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005097 parser.add_option('-n', '--no-commit', action='store_true', dest='nocommit',
Edward Lemurf38bc172019-09-03 21:02:13 +00005098 help='don\'t commit after patch applies.')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00005099
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00005100 group = optparse.OptionGroup(
5101 parser,
5102 'Options for continuing work on the current issue uploaded from a '
5103 'different clone (e.g. different machine). Must be used independently '
5104 'from the other options. No issue number should be specified, and the '
5105 'branch must have an issue number associated with it')
5106 group.add_option('--reapply', action='store_true', dest='reapply',
5107 help='Reset the branch and reapply the issue.\n'
5108 'CAUTION: This will undo any local changes in this '
5109 'branch')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00005110
5111 group.add_option('--pull', action='store_true', dest='pull',
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00005112 help='Performs a pull before reapplying.')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00005113 parser.add_option_group(group)
5114
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005115 (options, args) = parser.parse_args(args)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00005116
Andrii Shyshkalov18975322017-01-25 16:44:13 +01005117 if options.reapply:
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00005118 if options.newbranch:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00005119 parser.error('--reapply works on the current branch only.')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00005120 if len(args) > 0:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00005121 parser.error('--reapply implies no additional arguments.')
dsinclair@chromium.orgfbed6562015-09-25 21:22:36 +00005122
Edward Lemur934836a2019-09-09 20:16:54 +00005123 cl = Changelist()
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00005124 if not cl.GetIssue():
Quinten Yearsleyc4202212019-07-22 23:34:40 +00005125 parser.error('Current branch must have an associated issue.')
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00005126
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00005127 upstream = cl.GetUpstreamBranch()
Andrii Shyshkalov18975322017-01-25 16:44:13 +01005128 if upstream is None:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00005129 parser.error('No upstream branch specified. Cannot reset branch.')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00005130
5131 RunGit(['reset', '--hard', upstream])
5132 if options.pull:
5133 RunGit(['pull'])
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00005134
Edward Lemur678a6842019-10-03 22:25:05 +00005135 target_issue_arg = ParseIssueNumberArgument(cl.GetIssue())
Joanna Wang44e9bee2023-01-25 21:51:42 +00005136 return cl.CMDPatchWithParsedIssue(target_issue_arg, options.nocommit,
5137 options.force, False)
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00005138
5139 if len(args) != 1 or not args[0]:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00005140 parser.error('Must specify issue number or URL.')
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00005141
Edward Lemurf38bc172019-09-03 21:02:13 +00005142 target_issue_arg = ParseIssueNumberArgument(args[0])
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02005143 if not target_issue_arg.valid:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00005144 parser.error('Invalid issue ID or URL.')
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02005145
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00005146 # We don't want uncommitted changes mixed up with the patch.
5147 if git_common.is_dirty_git_tree('patch'):
dsinclair@chromium.orgfbed6562015-09-25 21:22:36 +00005148 return 1
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005149
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00005150 if options.newbranch:
5151 if options.force:
5152 RunGit(['branch', '-D', options.newbranch],
5153 stderr=subprocess2.PIPE, error_ok=True)
Edward Lemur84101642020-02-21 21:40:34 +00005154 git_new_branch.create_new_branch(options.newbranch)
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00005155
Edward Lemur678a6842019-10-03 22:25:05 +00005156 cl = Changelist(
5157 codereview_host=target_issue_arg.hostname, issue=target_issue_arg.issue)
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00005158
Edward Lemur678a6842019-10-03 22:25:05 +00005159 if not args[0].isdigit():
Edward Lemurf38bc172019-09-03 21:02:13 +00005160 print('canonical issue/change URL: %s\n' % cl.GetIssueURL())
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02005161
Bruce Dawsonf362f6f2021-02-18 23:15:17 +00005162 return cl.CMDPatchWithParsedIssue(target_issue_arg, options.nocommit,
5163 options.force, options.newbranch)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005164
5165
jochen@chromium.org3ec0d542014-01-14 20:00:03 +00005166def GetTreeStatus(url=None):
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005167 """Fetches the tree status and returns either 'open', 'closed',
5168 'unknown' or 'unset'."""
jochen@chromium.org3ec0d542014-01-14 20:00:03 +00005169 url = url or settings.GetTreeStatusUrl(error_ok=True)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005170 if url:
Daniel McArdle8b4eeff2020-07-20 17:02:47 +00005171 status = str(urllib.request.urlopen(url).read().lower())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005172 if status.find('closed') != -1 or status == '0':
5173 return 'closed'
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +00005174
5175 if status.find('open') != -1 or status == '1':
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005176 return 'open'
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +00005177
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005178 return 'unknown'
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005179 return 'unset'
5180
dpranke@chromium.org970c5222011-03-12 00:32:24 +00005181
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005182def GetTreeStatusReason():
5183 """Fetches the tree status from a json url and returns the message
5184 with the reason for the tree to be opened or closed."""
msb@chromium.orgbf1a7ba2011-02-01 16:21:46 +00005185 url = settings.GetTreeStatusUrl()
Daniel McArdle8b4eeff2020-07-20 17:02:47 +00005186 json_url = urllib.parse.urljoin(url, '/current?format=json')
Edward Lemur79d4f992019-11-11 23:49:02 +00005187 connection = urllib.request.urlopen(json_url)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005188 status = json.loads(connection.read())
5189 connection.close()
5190 return status['message']
5191
dpranke@chromium.org970c5222011-03-12 00:32:24 +00005192
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005193@metrics.collector.collect_metrics('git cl tree')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005194def CMDtree(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005195 """Shows the status of the tree."""
dpranke@chromium.org97ae58e2011-03-18 00:29:20 +00005196 _, args = parser.parse_args(args)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005197 status = GetTreeStatus()
5198 if 'unset' == status:
vapiera7fbd5a2016-06-16 09:17:49 -07005199 print('You must configure your tree status URL by running "git cl config".')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005200 return 2
5201
vapiera7fbd5a2016-06-16 09:17:49 -07005202 print('The tree is %s' % status)
5203 print()
5204 print(GetTreeStatusReason())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005205 if status != 'open':
5206 return 1
5207 return 0
5208
5209
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005210@metrics.collector.collect_metrics('git cl try')
maruel@chromium.org15192402012-09-06 12:38:29 +00005211def CMDtry(parser, args):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005212 """Triggers tryjobs using either Buildbucket or CQ dry run."""
5213 group = optparse.OptionGroup(parser, 'Tryjob options')
maruel@chromium.org15192402012-09-06 12:38:29 +00005214 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07005215 '-b', '--bot', action='append',
5216 help=('IMPORTANT: specify ONE builder per --bot flag. Use it multiple '
5217 'times to specify multiple builders. ex: '
5218 '"-b win_rel -b win_layout". See '
5219 'the try server waterfall for the builders name and the tests '
5220 'available.'))
maruel@chromium.org15192402012-09-06 12:38:29 +00005221 group.add_option(
borenet6c0efe62016-10-19 08:13:29 -07005222 '-B', '--bucket', default='',
Ben Pastene08a30b22022-05-04 17:46:38 +00005223 help=('Buildbucket bucket to send the try requests. Format: '
5224 '"luci.$LUCI_PROJECT.$LUCI_BUCKET". eg: "luci.chromium.try"'))
borenet6c0efe62016-10-19 08:13:29 -07005225 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07005226 '-r', '--revision',
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005227 help='Revision to use for the tryjob; default: the revision will '
tandriif7b29d42016-10-07 08:45:41 -07005228 'be determined by the try recipe that builder runs, which usually '
Josip Sokcevicc39ab992020-09-24 20:09:15 +00005229 'defaults to HEAD of origin/master or origin/main')
maruel@chromium.org15192402012-09-06 12:38:29 +00005230 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07005231 '-c', '--clobber', action='store_true', default=False,
tandriif7b29d42016-10-07 08:45:41 -07005232 help='Force a clobber before building; that is don\'t do an '
tandrii1838bad2016-10-06 00:10:52 -07005233 'incremental build')
maruel@chromium.org15192402012-09-06 12:38:29 +00005234 group.add_option(
Greg Gutermanbe5fccd2021-06-14 17:58:20 +00005235 '-q',
5236 '--quick-run',
5237 action='store_true',
5238 default=False,
5239 help='trigger in quick run mode '
5240 '(https://source.chromium.org/chromium/chromium/src/+/main:docs/cq_q'
5241 'uick_run.md) (chromium only).')
5242 group.add_option(
Andrii Shyshkalovf9648b52018-02-21 22:32:42 -08005243 '--category', default='git_cl_try', help='Specify custom build category.')
5244 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07005245 '--project',
5246 help='Override which project to use. Projects are defined '
tandriif7b29d42016-10-07 08:45:41 -07005247 'in recipe to determine to which repository or directory to '
5248 'apply the patch')
maruel@chromium.org15192402012-09-06 12:38:29 +00005249 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07005250 '-p', '--property', dest='properties', action='append', default=[],
5251 help='Specify generic properties in the form -p key1=value1 -p '
tandriif7b29d42016-10-07 08:45:41 -07005252 'key2=value2 etc. The value will be treated as '
5253 'json if decodable, or as string otherwise. '
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005254 'NOTE: using this may make your tryjob not usable for CQ, '
5255 'which will then schedule another tryjob with default properties')
sheyang@chromium.orgdb375572015-08-17 19:22:23 +00005256 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07005257 '--buildbucket-host', default='cr-buildbucket.appspot.com',
5258 help='Host of buildbucket. The default host is %default.')
maruel@chromium.org15192402012-09-06 12:38:29 +00005259 parser.add_option_group(group)
Quinten Yearsley983111f2019-09-26 17:18:48 +00005260 parser.add_option(
5261 '-R', '--retry-failed', action='store_true', default=False,
5262 help='Retry failed jobs from the latest set of tryjobs. '
5263 'Not allowed with --bucket and --bot options.')
Edward Lemur52969c92020-02-06 18:15:28 +00005264 parser.add_option(
5265 '-i', '--issue', type=int,
5266 help='Operate on this issue instead of the current branch\'s implicit '
5267 'issue.')
maruel@chromium.org15192402012-09-06 12:38:29 +00005268 options, args = parser.parse_args(args)
5269
machenbach@chromium.org45453142015-09-15 08:45:22 +00005270 # Make sure that all properties are prop=value pairs.
5271 bad_params = [x for x in options.properties if '=' not in x]
5272 if bad_params:
5273 parser.error('Got properties with missing "=": %s' % bad_params)
5274
maruel@chromium.org15192402012-09-06 12:38:29 +00005275 if args:
5276 parser.error('Unknown arguments: %s' % args)
5277
Edward Lemur934836a2019-09-09 20:16:54 +00005278 cl = Changelist(issue=options.issue)
maruel@chromium.org15192402012-09-06 12:38:29 +00005279 if not cl.GetIssue():
Quinten Yearsleyc4202212019-07-22 23:34:40 +00005280 parser.error('Need to upload first.')
maruel@chromium.org15192402012-09-06 12:38:29 +00005281
Edward Lemurf38bc172019-09-03 21:02:13 +00005282 # HACK: warm up Gerrit change detail cache to save on RPCs.
Edward Lemur125d60a2019-09-13 18:25:41 +00005283 cl._GetChangeDetail(['DETAILED_ACCOUNTS', 'ALL_REVISIONS'])
Andrii Shyshkaloveadad922017-01-26 09:38:30 +01005284
tandriie113dfd2016-10-11 10:20:12 -07005285 error_message = cl.CannotTriggerTryJobReason()
5286 if error_message:
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005287 parser.error('Can\'t trigger tryjobs: %s' % error_message)
jrobbins@chromium.org16f10f72014-06-24 22:14:36 +00005288
Edward Lemur45768512020-03-02 19:03:14 +00005289 if options.bot:
5290 if options.retry_failed:
5291 parser.error('--bot is not compatible with --retry-failed.')
5292 if not options.bucket:
5293 parser.error('A bucket (e.g. "chromium/try") is required.')
5294
5295 triggered = [b for b in options.bot if 'triggered' in b]
5296 if triggered:
5297 parser.error(
5298 'Cannot schedule builds on triggered bots: %s.\n'
5299 'This type of bot requires an initial job from a parent (usually a '
5300 'builder). Schedule a job on the parent instead.\n' % triggered)
5301
5302 if options.bucket.startswith('.master'):
5303 parser.error('Buildbot masters are not supported.')
5304
5305 project, bucket = _parse_bucket(options.bucket)
5306 if project is None or bucket is None:
5307 parser.error('Invalid bucket: %s.' % options.bucket)
5308 jobs = sorted((project, bucket, bot) for bot in options.bot)
5309 elif options.retry_failed:
Quinten Yearsley983111f2019-09-26 17:18:48 +00005310 print('Searching for failed tryjobs...')
Joanna Wanga8db0cb2023-01-24 15:43:17 +00005311 builds, patchset = _fetch_latest_builds(cl, DEFAULT_BUILDBUCKET_HOST)
Quinten Yearsley983111f2019-09-26 17:18:48 +00005312 if options.verbose:
5313 print('Got %d builds in patchset #%d' % (len(builds), patchset))
Edward Lemur45768512020-03-02 19:03:14 +00005314 jobs = _filter_failed_for_retry(builds)
5315 if not jobs:
Quinten Yearsley983111f2019-09-26 17:18:48 +00005316 print('There are no failed jobs in the latest set of jobs '
5317 '(patchset #%d), doing nothing.' % patchset)
5318 return 0
Edward Lemur45768512020-03-02 19:03:14 +00005319 num_builders = len(jobs)
Quinten Yearsley983111f2019-09-26 17:18:48 +00005320 if num_builders > 10:
5321 confirm_or_exit('There are %d builders with failed builds.'
5322 % num_builders, action='continue')
Greg Gutermanbe5fccd2021-06-14 17:58:20 +00005323 elif options.quick_run:
5324 print('Scheduling CQ quick run on: %s' % cl.GetIssueURL())
5325 return cl.SetCQState(_CQState.QUICK_RUN)
Quinten Yearsley983111f2019-09-26 17:18:48 +00005326 else:
qyearsley1fdfcb62016-10-24 13:22:03 -07005327 if options.verbose:
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07005328 print('git cl try with no bots now defaults to CQ dry run.')
5329 print('Scheduling CQ dry run on: %s' % cl.GetIssueURL())
5330 return cl.SetCQState(_CQState.DRY_RUN)
stip@chromium.org43064fd2013-12-18 20:07:44 +00005331
ilevy@chromium.org36e420b2013-08-06 23:21:12 +00005332 patchset = cl.GetMostRecentPatchset()
Edward Lemur2c210a42019-09-16 23:58:35 +00005333 try:
Quinten Yearsley777660f2020-03-04 23:37:06 +00005334 _trigger_tryjobs(cl, jobs, options, patchset)
Edward Lemur2c210a42019-09-16 23:58:35 +00005335 except BuildbucketResponseException as ex:
5336 print('ERROR: %s' % ex)
5337 return 1
5338 return 0
maruel@chromium.org15192402012-09-06 12:38:29 +00005339
5340
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005341@metrics.collector.collect_metrics('git cl try-results')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00005342def CMDtry_results(parser, args):
Quinten Yearsleyd242ed72019-07-25 17:17:55 +00005343 """Prints info about results for tryjobs associated with the current CL."""
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005344 group = optparse.OptionGroup(parser, 'Tryjob results options')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00005345 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07005346 '-p', '--patchset', type=int, help='patchset number if not current.')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00005347 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07005348 '--print-master', action='store_true', help='print master name as well.')
tandrii@chromium.org6cf98c82016-03-15 11:56:00 +00005349 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07005350 '--color', action='store_true', default=setup_color.IS_TTY,
5351 help='force color output, useful when piping output.')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00005352 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07005353 '--buildbucket-host', default='cr-buildbucket.appspot.com',
5354 help='Host of buildbucket. The default host is %default.')
qyearsley53f48a12016-09-01 10:45:13 -07005355 group.add_option(
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005356 '--json', help=('Path of JSON output file to write tryjob results to,'
Stefan Zager1306bd02017-06-22 19:26:46 -07005357 'or "-" for stdout.'))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00005358 parser.add_option_group(group)
Edward Lemur52969c92020-02-06 18:15:28 +00005359 parser.add_option(
5360 '-i', '--issue', type=int,
5361 help='Operate on this issue instead of the current branch\'s implicit '
5362 'issue.')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00005363 options, args = parser.parse_args(args)
5364 if args:
5365 parser.error('Unrecognized args: %s' % ' '.join(args))
5366
Edward Lemur934836a2019-09-09 20:16:54 +00005367 cl = Changelist(issue=options.issue)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00005368 if not cl.GetIssue():
Quinten Yearsleyc4202212019-07-22 23:34:40 +00005369 parser.error('Need to upload first.')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00005370
tandrii221ab252016-10-06 08:12:04 -07005371 patchset = options.patchset
5372 if not patchset:
Gavin Make61ccc52020-11-13 00:12:57 +00005373 patchset = cl.GetMostRecentDryRunPatchset()
tandrii221ab252016-10-06 08:12:04 -07005374 if not patchset:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00005375 parser.error('Code review host doesn\'t know about issue %s. '
tandrii221ab252016-10-06 08:12:04 -07005376 'No access to issue or wrong issue number?\n'
Quinten Yearsleyc4202212019-07-22 23:34:40 +00005377 'Either upload first, or pass --patchset explicitly.' %
tandrii221ab252016-10-06 08:12:04 -07005378 cl.GetIssue())
5379
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00005380 try:
Joanna Wanga8db0cb2023-01-24 15:43:17 +00005381 jobs = _fetch_tryjobs(cl, DEFAULT_BUILDBUCKET_HOST, patchset)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00005382 except BuildbucketResponseException as ex:
vapiera7fbd5a2016-06-16 09:17:49 -07005383 print('Buildbucket error: %s' % ex)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00005384 return 1
qyearsley53f48a12016-09-01 10:45:13 -07005385 if options.json:
Edward Lemurbaaf6be2019-10-09 18:00:44 +00005386 write_json(options.json, jobs)
qyearsley53f48a12016-09-01 10:45:13 -07005387 else:
Quinten Yearsley777660f2020-03-04 23:37:06 +00005388 _print_tryjobs(options, jobs)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00005389 return 0
5390
5391
maruel@chromium.org0633fb42013-08-16 20:06:14 +00005392@subcommand.usage('[new upstream branch]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005393@metrics.collector.collect_metrics('git cl upstream')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005394def CMDupstream(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005395 """Prints or sets the name of the upstream branch, if any."""
dpranke@chromium.org97ae58e2011-03-18 00:29:20 +00005396 _, args = parser.parse_args(args)
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00005397 if len(args) > 1:
maruel@chromium.org27bb3872011-05-30 20:33:19 +00005398 parser.error('Unrecognized args: %s' % ' '.join(args))
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00005399
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005400 cl = Changelist()
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00005401 if args:
5402 # One arg means set upstream branch.
bauerb@chromium.orgc9cf90a2014-04-28 20:32:31 +00005403 branch = cl.GetBranch()
stip7a3dd352016-09-22 17:32:28 -07005404 RunGit(['branch', '--set-upstream-to', args[0], branch])
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00005405 cl = Changelist()
vapiera7fbd5a2016-06-16 09:17:49 -07005406 print('Upstream branch set to %s' % (cl.GetUpstreamBranch(),))
bauerb@chromium.orgc9cf90a2014-04-28 20:32:31 +00005407
5408 # Clear configured merge-base, if there is one.
5409 git_common.remove_merge_base(branch)
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00005410 else:
vapiera7fbd5a2016-06-16 09:17:49 -07005411 print(cl.GetUpstreamBranch())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005412 return 0
5413
5414
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005415@metrics.collector.collect_metrics('git cl web')
thestig@chromium.org00858c82013-12-02 23:08:03 +00005416def CMDweb(parser, args):
5417 """Opens the current CL in the web browser."""
Orr Bernstein0b960582022-12-22 20:16:18 +00005418 parser.add_option('-p',
5419 '--print-only',
5420 action='store_true',
5421 dest='print_only',
5422 help='Only print the Gerrit URL, don\'t open it in the '
5423 'browser.')
5424 (options, args) = parser.parse_args(args)
thestig@chromium.org00858c82013-12-02 23:08:03 +00005425 if args:
5426 parser.error('Unrecognized args: %s' % ' '.join(args))
5427
5428 issue_url = Changelist().GetIssueURL()
5429 if not issue_url:
vapiera7fbd5a2016-06-16 09:17:49 -07005430 print('ERROR No issue to open', file=sys.stderr)
thestig@chromium.org00858c82013-12-02 23:08:03 +00005431 return 1
5432
Orr Bernstein0b960582022-12-22 20:16:18 +00005433 if options.print_only:
5434 print(issue_url)
5435 return 0
5436
Sergiy Byelozyorov2b718322018-10-24 17:43:31 +00005437 # Redirect I/O before invoking browser to hide its output. For example, this
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005438 # allows us to hide the "Created new window in existing browser session."
5439 # message from Chrome. Based on https://stackoverflow.com/a/2323563.
Sergiy Byelozyorov2b718322018-10-24 17:43:31 +00005440 saved_stdout = os.dup(1)
Sergiy Belozorov06684032019-03-06 16:53:08 +00005441 saved_stderr = os.dup(2)
Sergiy Byelozyorov2b718322018-10-24 17:43:31 +00005442 os.close(1)
Sergiy Belozorov06684032019-03-06 16:53:08 +00005443 os.close(2)
Sergiy Byelozyorov2b718322018-10-24 17:43:31 +00005444 os.open(os.devnull, os.O_RDWR)
5445 try:
5446 webbrowser.open(issue_url)
5447 finally:
5448 os.dup2(saved_stdout, 1)
Sergiy Belozorov06684032019-03-06 16:53:08 +00005449 os.dup2(saved_stderr, 2)
thestig@chromium.org00858c82013-12-02 23:08:03 +00005450 return 0
5451
5452
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005453@metrics.collector.collect_metrics('git cl set-commit')
maruel@chromium.org27bb3872011-05-30 20:33:19 +00005454def CMDset_commit(parser, args):
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +00005455 """Sets the commit bit to trigger the CQ."""
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00005456 parser.add_option('-d', '--dry-run', action='store_true',
5457 help='trigger in dry run mode')
Greg Gutermanbe5fccd2021-06-14 17:58:20 +00005458 parser.add_option(
5459 '-q',
5460 '--quick-run',
5461 action='store_true',
5462 help='trigger in quick run mode '
5463 '(https://source.chromium.org/chromium/chromium/src/+/main:docs/cq_qu'
5464 'ick_run.md) (chromium only).')
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00005465 parser.add_option('-c', '--clear', action='store_true',
5466 help='stop CQ run, if any')
Edward Lemur52969c92020-02-06 18:15:28 +00005467 parser.add_option(
5468 '-i', '--issue', type=int,
5469 help='Operate on this issue instead of the current branch\'s implicit '
5470 'issue.')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00005471 options, args = parser.parse_args(args)
maruel@chromium.org27bb3872011-05-30 20:33:19 +00005472 if args:
5473 parser.error('Unrecognized args: %s' % ' '.join(args))
Greg Gutermanbe5fccd2021-06-14 17:58:20 +00005474 if [options.dry_run, options.quick_run, options.clear].count(True) > 1:
5475 parser.error('Only one of --dry-run, --quick-run, and --clear are allowed.')
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00005476
Edward Lemur934836a2019-09-09 20:16:54 +00005477 cl = Changelist(issue=options.issue)
Greg Gutermanbe5fccd2021-06-14 17:58:20 +00005478 if not cl.GetIssue():
5479 parser.error('Must upload the issue first.')
5480
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00005481 if options.clear:
tandriid9e5ce52016-07-13 02:32:59 -07005482 state = _CQState.NONE
Greg Gutermanbe5fccd2021-06-14 17:58:20 +00005483 elif options.quick_run:
5484 state = _CQState.QUICK_RUN
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00005485 elif options.dry_run:
5486 state = _CQState.DRY_RUN
5487 else:
5488 state = _CQState.COMMIT
tandrii9de9ec62016-07-13 03:01:59 -07005489 cl.SetCQState(state)
maruel@chromium.org27bb3872011-05-30 20:33:19 +00005490 return 0
5491
5492
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005493@metrics.collector.collect_metrics('git cl set-close')
groby@chromium.org411034a2013-02-26 15:12:01 +00005494def CMDset_close(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005495 """Closes the issue."""
Edward Lemur52969c92020-02-06 18:15:28 +00005496 parser.add_option(
5497 '-i', '--issue', type=int,
5498 help='Operate on this issue instead of the current branch\'s implicit '
5499 'issue.')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00005500 options, args = parser.parse_args(args)
groby@chromium.org411034a2013-02-26 15:12:01 +00005501 if args:
5502 parser.error('Unrecognized args: %s' % ' '.join(args))
Edward Lemur934836a2019-09-09 20:16:54 +00005503 cl = Changelist(issue=options.issue)
groby@chromium.org411034a2013-02-26 15:12:01 +00005504 # Ensure there actually is an issue to close.
Aaron Gable7139a4e2017-09-05 17:53:09 -07005505 if not cl.GetIssue():
Quinten Yearsleyc4202212019-07-22 23:34:40 +00005506 DieWithError('ERROR: No issue to close.')
groby@chromium.org411034a2013-02-26 15:12:01 +00005507 cl.CloseIssue()
5508 return 0
5509
5510
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005511@metrics.collector.collect_metrics('git cl diff')
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00005512def CMDdiff(parser, args):
wychen@chromium.org37b2ec02015-04-03 00:49:15 +00005513 """Shows differences between local tree and last upload."""
thomasanderson074beb22016-08-29 14:03:20 -07005514 parser.add_option(
5515 '--stat',
5516 action='store_true',
5517 dest='stat',
5518 help='Generate a diffstat')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00005519 options, args = parser.parse_args(args)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00005520 if args:
5521 parser.error('Unrecognized args: %s' % ' '.join(args))
wychen@chromium.org46309bf2015-04-03 21:04:49 +00005522
Edward Lemur934836a2019-09-09 20:16:54 +00005523 cl = Changelist()
sbc@chromium.org78dc9842013-11-25 18:43:44 +00005524 issue = cl.GetIssue()
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00005525 branch = cl.GetBranch()
sbc@chromium.org78dc9842013-11-25 18:43:44 +00005526 if not issue:
5527 DieWithError('No issue found for current branch (%s)' % branch)
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00005528
Gavin Makbe2e9262022-11-08 23:41:55 +00005529 base = cl._GitGetBranchConfigValue(LAST_UPLOAD_HASH_CONFIG_KEY)
Aaron Gablea718c3e2017-08-28 17:47:28 -07005530 if not base:
Gavin Makbe2e9262022-11-08 23:41:55 +00005531 base = cl._GitGetBranchConfigValue(GERRIT_SQUASH_HASH_CONFIG_KEY)
Aaron Gablea718c3e2017-08-28 17:47:28 -07005532 if not base:
5533 detail = cl._GetChangeDetail(['CURRENT_REVISION', 'CURRENT_COMMIT'])
5534 revision_info = detail['revisions'][detail['current_revision']]
5535 fetch_info = revision_info['fetch']['http']
5536 RunGit(['fetch', fetch_info['url'], fetch_info['ref']])
5537 base = 'FETCH_HEAD'
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00005538
Aaron Gablea718c3e2017-08-28 17:47:28 -07005539 cmd = ['git', 'diff']
5540 if options.stat:
5541 cmd.append('--stat')
5542 cmd.append(base)
5543 subprocess2.check_call(cmd)
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00005544
5545 return 0
5546
5547
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005548@metrics.collector.collect_metrics('git cl owners')
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005549def CMDowners(parser, args):
Dirk Prankebf980882017-09-02 15:08:00 -07005550 """Finds potential owners for reviewing."""
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005551 parser.add_option(
Sidney San Martín8e6f58c2018-06-08 01:02:56 +00005552 '--ignore-current',
5553 action='store_true',
5554 help='Ignore the CL\'s current reviewers and start from scratch.')
5555 parser.add_option(
Sylvain Defresneb1f865d2019-02-12 12:38:22 +00005556 '--ignore-self',
5557 action='store_true',
5558 help='Do not consider CL\'s author as an owners.')
5559 parser.add_option(
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005560 '--no-color',
5561 action='store_true',
5562 help='Use this option to disable color output')
Dirk Prankebf980882017-09-02 15:08:00 -07005563 parser.add_option(
5564 '--batch',
5565 action='store_true',
5566 help='Do not run interactively, just suggest some')
Yang Guo6e269a02019-06-26 11:17:02 +00005567 # TODO: Consider moving this to another command, since other
5568 # git-cl owners commands deal with owners for a given CL.
5569 parser.add_option(
5570 '--show-all',
5571 action='store_true',
5572 help='Show all owners for a particular file')
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005573 options, args = parser.parse_args(args)
5574
Edward Lemur934836a2019-09-09 20:16:54 +00005575 cl = Changelist()
Edward Lesmes50da7702020-03-30 19:23:43 +00005576 author = cl.GetAuthor()
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005577
Yang Guo6e269a02019-06-26 11:17:02 +00005578 if options.show_all:
Bruce Dawson97ed44a2020-05-06 17:04:03 +00005579 if len(args) == 0:
5580 print('No files specified for --show-all. Nothing to do.')
5581 return 0
Edward Lesmese1576912021-02-16 21:53:34 +00005582 owners_by_path = cl.owners_client.BatchListOwners(args)
Edward Lesmes0e4e5ae2021-01-08 18:28:46 +00005583 for path in args:
5584 print('Owners for %s:' % path)
5585 print('\n'.join(
5586 ' - %s' % owner
5587 for owner in owners_by_path.get(path, ['No owners found'])))
Yang Guo6e269a02019-06-26 11:17:02 +00005588 return 0
5589
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005590 if args:
5591 if len(args) > 1:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00005592 parser.error('Unknown args.')
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005593 base_branch = args[0]
5594 else:
5595 # Default to diffing against the common ancestor of the upstream branch.
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00005596 base_branch = cl.GetCommonAncestorWithUpstream()
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005597
Edward Lemur2c62b332020-03-12 22:12:33 +00005598 affected_files = cl.GetAffectedFiles(base_branch)
Dirk Prankebf980882017-09-02 15:08:00 -07005599
5600 if options.batch:
Edward Lesmese1576912021-02-16 21:53:34 +00005601 owners = cl.owners_client.SuggestOwners(affected_files, exclude=[author])
5602 print('\n'.join(owners))
Dirk Prankebf980882017-09-02 15:08:00 -07005603 return 0
5604
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005605 return owners_finder.OwnersFinder(
Dirk Prankebf980882017-09-02 15:08:00 -07005606 affected_files,
Edward Lemur707d70b2018-02-07 00:50:14 +01005607 author,
Sidney San Martín8e6f58c2018-06-08 01:02:56 +00005608 [] if options.ignore_current else cl.GetReviewers(),
Edward Lesmes5cd75472021-02-19 00:34:25 +00005609 cl.owners_client,
Jochen Eisingerd0573ec2017-04-13 10:55:06 +02005610 disable_color=options.no_color,
Sylvain Defresneb1f865d2019-02-12 12:38:22 +00005611 ignore_author=options.ignore_self).run()
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005612
5613
Aiden Bennerc08566e2018-10-03 17:52:42 +00005614def BuildGitDiffCmd(diff_type, upstream_commit, args, allow_prefix=False):
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005615 """Generates a diff command."""
5616 # Generate diff for the current branch's changes.
Aiden Bennerc08566e2018-10-03 17:52:42 +00005617 diff_cmd = ['-c', 'core.quotePath=false', 'diff', '--no-ext-diff']
5618
Aiden Benner6c18a1a2018-11-23 20:18:23 +00005619 if allow_prefix:
5620 # explicitly setting --src-prefix and --dst-prefix is necessary in the
5621 # case that diff.noprefix is set in the user's git config.
5622 diff_cmd += ['--src-prefix=a/', '--dst-prefix=b/']
5623 else:
Aiden Bennerc08566e2018-10-03 17:52:42 +00005624 diff_cmd += ['--no-prefix']
5625
5626 diff_cmd += [diff_type, upstream_commit, '--']
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005627
5628 if args:
5629 for arg in args:
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005630 if os.path.isdir(arg) or os.path.isfile(arg):
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005631 diff_cmd.append(arg)
5632 else:
5633 DieWithError('Argument "%s" is not a file or a directory' % arg)
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005634
5635 return diff_cmd
5636
Andrii Shyshkalov18975322017-01-25 16:44:13 +01005637
Jamie Madill5e96ad12020-01-13 16:08:35 +00005638def _RunClangFormatDiff(opts, clang_diff_files, top_dir, upstream_commit):
5639 """Runs clang-format-diff and sets a return value if necessary."""
5640
5641 if not clang_diff_files:
5642 return 0
5643
5644 # Set to 2 to signal to CheckPatchFormatted() that this patch isn't
5645 # formatted. This is used to block during the presubmit.
5646 return_value = 0
5647
5648 # Locate the clang-format binary in the checkout
5649 try:
5650 clang_format_tool = clang_format.FindClangFormatToolInChromiumTree()
5651 except clang_format.NotFoundError as e:
5652 DieWithError(e)
5653
5654 if opts.full or settings.GetFormatFullByDefault():
5655 cmd = [clang_format_tool]
5656 if not opts.dry_run and not opts.diff:
5657 cmd.append('-i')
5658 if opts.dry_run:
5659 for diff_file in clang_diff_files:
5660 with open(diff_file, 'r') as myfile:
5661 code = myfile.read().replace('\r\n', '\n')
5662 stdout = RunCommand(cmd + [diff_file], cwd=top_dir)
5663 stdout = stdout.replace('\r\n', '\n')
5664 if opts.diff:
5665 sys.stdout.write(stdout)
5666 if code != stdout:
5667 return_value = 2
5668 else:
5669 stdout = RunCommand(cmd + clang_diff_files, cwd=top_dir)
5670 if opts.diff:
5671 sys.stdout.write(stdout)
5672 else:
Jamie Madill5e96ad12020-01-13 16:08:35 +00005673 try:
5674 script = clang_format.FindClangFormatScriptInChromiumTree(
5675 'clang-format-diff.py')
5676 except clang_format.NotFoundError as e:
5677 DieWithError(e)
5678
Josip Sokcevic2a827fc2022-03-04 17:51:47 +00005679 cmd = ['vpython3', script, '-p0']
Jamie Madill5e96ad12020-01-13 16:08:35 +00005680 if not opts.dry_run and not opts.diff:
5681 cmd.append('-i')
5682
5683 diff_cmd = BuildGitDiffCmd('-U0', upstream_commit, clang_diff_files)
Edward Lemur1a83da12020-03-04 21:18:36 +00005684 diff_output = RunGit(diff_cmd).encode('utf-8')
Jamie Madill5e96ad12020-01-13 16:08:35 +00005685
Edward Lesmes89624cd2020-04-06 17:51:56 +00005686 env = os.environ.copy()
5687 env['PATH'] = (
5688 str(os.path.dirname(clang_format_tool)) + os.pathsep + env['PATH'])
5689 stdout = RunCommand(
5690 cmd, stdin=diff_output, cwd=top_dir, env=env,
Ilya Sherman7aed4bb2020-05-20 22:34:14 +00005691 shell=sys.platform.startswith('win32'))
Jamie Madill5e96ad12020-01-13 16:08:35 +00005692 if opts.diff:
5693 sys.stdout.write(stdout)
5694 if opts.dry_run and len(stdout) > 0:
5695 return_value = 2
5696
5697 return return_value
5698
5699
Lukasz Anforowiczb4d39542021-09-30 23:39:25 +00005700def _RunRustFmt(opts, rust_diff_files, top_dir, upstream_commit):
5701 """Runs rustfmt. Just like _RunClangFormatDiff returns 2 to indicate that
5702 presubmit checks have failed (and returns 0 otherwise)."""
5703
5704 if not rust_diff_files:
5705 return 0
5706
5707 # Locate the rustfmt binary.
5708 try:
5709 rustfmt_tool = rustfmt.FindRustfmtToolInChromiumTree()
5710 except rustfmt.NotFoundError as e:
5711 DieWithError(e)
5712
5713 # TODO(crbug.com/1231317): Support formatting only the changed lines
5714 # if `opts.full or settings.GetFormatFullByDefault()` is False. See also:
5715 # https://github.com/emilio/rustfmt-format-diff
5716 cmd = [rustfmt_tool]
5717 if opts.dry_run:
5718 cmd.append('--check')
5719 cmd += rust_diff_files
5720 rustfmt_exitcode = subprocess2.call(cmd)
5721
5722 if opts.presubmit and rustfmt_exitcode != 0:
5723 return 2
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +00005724
5725 return 0
Lukasz Anforowiczb4d39542021-09-30 23:39:25 +00005726
5727
Olivier Robin0a6b5442022-04-07 07:25:04 +00005728def _RunSwiftFormat(opts, swift_diff_files, top_dir, upstream_commit):
5729 """Runs swift-format. Just like _RunClangFormatDiff returns 2 to indicate
5730 that presubmit checks have failed (and returns 0 otherwise)."""
5731
5732 if not swift_diff_files:
5733 return 0
5734
5735 # Locate the swift-format binary.
5736 try:
5737 swift_format_tool = swift_format.FindSwiftFormatToolInChromiumTree()
5738 except swift_format.NotFoundError as e:
5739 DieWithError(e)
5740
5741 cmd = [swift_format_tool]
5742 if opts.dry_run:
Olivier Robin7f39e3d2022-04-28 08:20:49 +00005743 cmd += ['lint', '-s']
Olivier Robin0a6b5442022-04-07 07:25:04 +00005744 else:
5745 cmd += ['format', '-i']
5746 cmd += swift_diff_files
5747 swift_format_exitcode = subprocess2.call(cmd)
5748
5749 if opts.presubmit and swift_format_exitcode != 0:
5750 return 2
5751
5752 return 0
5753
5754
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005755def MatchingFileType(file_name, extensions):
Quinten Yearsleyd242ed72019-07-25 17:17:55 +00005756 """Returns True if the file name ends with one of the given extensions."""
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005757 return bool([ext for ext in extensions if file_name.lower().endswith(ext)])
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005758
Andrii Shyshkalov18975322017-01-25 16:44:13 +01005759
enne@chromium.org555cfe42014-01-29 18:21:39 +00005760@subcommand.usage('[files or directories to diff]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005761@metrics.collector.collect_metrics('git cl format')
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005762def CMDformat(parser, args):
sbc@chromium.org9d0644d2015-06-05 23:16:54 +00005763 """Runs auto-formatting tools (clang-format etc.) on the diff."""
Christopher Lamc5ba6922017-01-24 11:19:14 +11005764 CLANG_EXTS = ['.cc', '.cpp', '.h', '.m', '.mm', '.proto', '.java']
kylechar58edce22016-06-17 06:07:51 -07005765 GN_EXTS = ['.gn', '.gni', '.typemap']
Lukasz Anforowiczb4d39542021-09-30 23:39:25 +00005766 RUST_EXTS = ['.rs']
Olivier Robin0a6b5442022-04-07 07:25:04 +00005767 SWIFT_EXTS = ['.swift']
enne@chromium.org3b7e15c2014-01-21 17:44:47 +00005768 parser.add_option('--full', action='store_true',
5769 help='Reformat the full content of all touched files')
Tomasz Åšniatowski58194462021-08-27 17:36:16 +00005770 parser.add_option('--upstream', help='Branch to check against')
enne@chromium.org3b7e15c2014-01-21 17:44:47 +00005771 parser.add_option('--dry-run', action='store_true',
5772 help='Don\'t modify any file on disk.')
Aiden Benner99b0ccb2018-11-20 19:53:31 +00005773 parser.add_option(
Garrett Beatyed0cc5f2020-01-06 17:26:13 +00005774 '--no-clang-format',
5775 dest='clang_format',
5776 action='store_false',
5777 default=True,
5778 help='Disables formatting of various file types using clang-format.')
5779 parser.add_option(
Aiden Benner99b0ccb2018-11-20 19:53:31 +00005780 '--python',
5781 action='store_true',
5782 default=None,
5783 help='Enables python formatting on all python files.')
5784 parser.add_option(
5785 '--no-python',
5786 action='store_true',
Garrett Beaty91a6f332020-01-06 16:57:24 +00005787 default=False,
Aiden Benner99b0ccb2018-11-20 19:53:31 +00005788 help='Disables python formatting on all python files. '
Garrett Beaty91a6f332020-01-06 16:57:24 +00005789 'If neither --python or --no-python are set, python files that have a '
5790 '.style.yapf file in an ancestor directory will be formatted. '
5791 'It is an error to set both.')
Garrett Beatyed0cc5f2020-01-06 17:26:13 +00005792 parser.add_option(
5793 '--js',
5794 action='store_true',
5795 help='Format javascript code with clang-format. '
5796 'Has no effect if --no-clang-format is set.')
wittman@chromium.org04d5a222014-03-07 18:30:42 +00005797 parser.add_option('--diff', action='store_true',
5798 help='Print diff to stdout rather than modifying files.')
Ilya Shermane081cbe2017-08-15 17:51:04 -07005799 parser.add_option('--presubmit', action='store_true',
5800 help='Used when running the script from a presubmit.')
Lukasz Anforowiczb4d39542021-09-30 23:39:25 +00005801
5802 parser.add_option('--rust-fmt',
5803 dest='use_rust_fmt',
5804 action='store_true',
5805 default=rustfmt.IsRustfmtSupported(),
5806 help='Enables formatting of Rust file types using rustfmt.')
5807 parser.add_option(
5808 '--no-rust-fmt',
5809 dest='use_rust_fmt',
5810 action='store_false',
5811 help='Disables formatting of Rust file types using rustfmt.')
5812
Olivier Robin0a6b5442022-04-07 07:25:04 +00005813 parser.add_option(
5814 '--swift-format',
5815 dest='use_swift_format',
5816 action='store_true',
Olivier Robin7f39e3d2022-04-28 08:20:49 +00005817 default=swift_format.IsSwiftFormatSupported(),
Olivier Robin0a6b5442022-04-07 07:25:04 +00005818 help='Enables formatting of Swift file types using swift-format '
5819 '(macOS host only).')
5820 parser.add_option(
5821 '--no-swift-format',
5822 dest='use_swift_format',
5823 action='store_false',
5824 help='Disables formatting of Swift file types using swift-format.')
5825
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005826 opts, args = parser.parse_args(args)
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005827
Garrett Beaty91a6f332020-01-06 16:57:24 +00005828 if opts.python is not None and opts.no_python:
5829 raise parser.error('Cannot set both --python and --no-python')
5830 if opts.no_python:
5831 opts.python = False
5832
Daniel Chengc55eecf2016-12-30 03:11:02 -08005833 # Normalize any remaining args against the current path, so paths relative to
5834 # the current directory are still resolved as expected.
5835 args = [os.path.join(os.getcwd(), arg) for arg in args]
5836
enne@chromium.orgff7a1fb2013-12-10 19:21:41 +00005837 # git diff generates paths against the root of the repository. Change
5838 # to that directory so clang-format can find files even within subdirs.
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00005839 rel_base_path = settings.GetRelativeRoot()
enne@chromium.orgff7a1fb2013-12-10 19:21:41 +00005840 if rel_base_path:
5841 os.chdir(rel_base_path)
5842
digit@chromium.org29e47272013-05-17 17:01:46 +00005843 # Grab the merge-base commit, i.e. the upstream commit of the current
5844 # branch when it was created or the last time it was rebased. This is
5845 # to cover the case where the user may have called "git fetch origin",
5846 # moving the origin branch to a newer commit, but hasn't rebased yet.
5847 upstream_commit = None
Tomasz Åšniatowski58194462021-08-27 17:36:16 +00005848 upstream_branch = opts.upstream
5849 if not upstream_branch:
5850 cl = Changelist()
5851 upstream_branch = cl.GetUpstreamBranch()
digit@chromium.org29e47272013-05-17 17:01:46 +00005852 if upstream_branch:
5853 upstream_commit = RunGit(['merge-base', 'HEAD', upstream_branch])
5854 upstream_commit = upstream_commit.strip()
5855
5856 if not upstream_commit:
5857 DieWithError('Could not find base commit for this branch. '
5858 'Are you in detached state?')
5859
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005860 changed_files_cmd = BuildGitDiffCmd('--name-only', upstream_commit, args)
5861 diff_output = RunGit(changed_files_cmd)
5862 diff_files = diff_output.splitlines()
jkarlin@chromium.orgad21b922016-01-28 17:48:42 +00005863 # Filter out files deleted by this CL
5864 diff_files = [x for x in diff_files if os.path.isfile(x)]
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005865
Andreas Haas417d89c2020-02-06 10:24:27 +00005866 if opts.js:
Deepanjan Roy605dd312018-07-02 17:48:54 +00005867 CLANG_EXTS.extend(['.js', '.ts'])
Christopher Lamc5ba6922017-01-24 11:19:14 +11005868
Garrett Beatyed0cc5f2020-01-06 17:26:13 +00005869 clang_diff_files = []
5870 if opts.clang_format:
5871 clang_diff_files = [
5872 x for x in diff_files if MatchingFileType(x, CLANG_EXTS)
5873 ]
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005874 python_diff_files = [x for x in diff_files if MatchingFileType(x, ['.py'])]
Lukasz Anforowiczb4d39542021-09-30 23:39:25 +00005875 rust_diff_files = [x for x in diff_files if MatchingFileType(x, RUST_EXTS)]
Olivier Robin0a6b5442022-04-07 07:25:04 +00005876 swift_diff_files = [x for x in diff_files if MatchingFileType(x, SWIFT_EXTS)]
kylechar@chromium.org8b61f112016-02-05 13:28:58 +00005877 gn_diff_files = [x for x in diff_files if MatchingFileType(x, GN_EXTS)]
digit@chromium.org29e47272013-05-17 17:01:46 +00005878
Edward Lesmes50da7702020-03-30 19:23:43 +00005879 top_dir = settings.GetRoot()
nick@chromium.org3ac1c4e2014-01-16 02:44:42 +00005880
Jamie Madill5e96ad12020-01-13 16:08:35 +00005881 return_value = _RunClangFormatDiff(opts, clang_diff_files, top_dir,
5882 upstream_commit)
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005883
Lukasz Anforowiczb4d39542021-09-30 23:39:25 +00005884 if opts.use_rust_fmt:
5885 rust_fmt_return_value = _RunRustFmt(opts, rust_diff_files, top_dir,
5886 upstream_commit)
5887 if rust_fmt_return_value == 2:
5888 return_value = 2
5889
Olivier Robin0a6b5442022-04-07 07:25:04 +00005890 if opts.use_swift_format:
5891 if sys.platform != 'darwin':
5892 DieWithError('swift-format is only supported on macOS.')
5893 swift_format_return_value = _RunSwiftFormat(opts, swift_diff_files, top_dir,
5894 upstream_commit)
5895 if swift_format_return_value == 2:
5896 return_value = 2
5897
sbc@chromium.org9d0644d2015-06-05 23:16:54 +00005898 # Similar code to above, but using yapf on .py files rather than clang-format
5899 # on C/C++ files
Aiden Benner99b0ccb2018-11-20 19:53:31 +00005900 py_explicitly_disabled = opts.python is not None and not opts.python
5901 if python_diff_files and not py_explicitly_disabled:
Aiden Bennere47ac152018-11-20 16:44:03 +00005902 depot_tools_path = os.path.dirname(os.path.abspath(__file__))
5903 yapf_tool = os.path.join(depot_tools_path, 'yapf')
sbc@chromium.org9d0644d2015-06-05 23:16:54 +00005904
Aiden Bennerc08566e2018-10-03 17:52:42 +00005905 # Used for caching.
5906 yapf_configs = {}
5907 for f in python_diff_files:
5908 # Find the yapf style config for the current file, defaults to depot
5909 # tools default.
Aiden Benner99b0ccb2018-11-20 19:53:31 +00005910 _FindYapfConfigFile(f, yapf_configs, top_dir)
5911
5912 # Turn on python formatting by default if a yapf config is specified.
5913 # This breaks in the case of this repo though since the specified
5914 # style file is also the global default.
5915 if opts.python is None:
5916 filtered_py_files = []
5917 for f in python_diff_files:
5918 if _FindYapfConfigFile(f, yapf_configs, top_dir) is not None:
5919 filtered_py_files.append(f)
5920 else:
5921 filtered_py_files = python_diff_files
5922
5923 # Note: yapf still seems to fix indentation of the entire file
5924 # even if line ranges are specified.
5925 # See https://github.com/google/yapf/issues/499
5926 if not opts.full and filtered_py_files:
5927 py_line_diffs = _ComputeDiffLineRanges(filtered_py_files, upstream_commit)
5928
Brian Sheedyb4307d52019-12-02 19:18:17 +00005929 yapfignore_patterns = _GetYapfIgnorePatterns(top_dir)
5930 filtered_py_files = _FilterYapfIgnoredFiles(filtered_py_files,
5931 yapfignore_patterns)
Brian Sheedy59b06a82019-10-14 17:03:29 +00005932
Aiden Benner99b0ccb2018-11-20 19:53:31 +00005933 for f in filtered_py_files:
Andrew Grievefa40bfa2020-01-07 02:32:57 +00005934 yapf_style = _FindYapfConfigFile(f, yapf_configs, top_dir)
5935 # Default to pep8 if not .style.yapf is found.
5936 if not yapf_style:
5937 yapf_style = 'pep8'
Aiden Bennerc08566e2018-10-03 17:52:42 +00005938
Peter Wend9399922020-06-17 17:33:49 +00005939 with open(f, 'r') as py_f:
Andrew Grieveb9e694c2021-11-15 19:04:46 +00005940 if 'python2' in py_f.readline():
Peter Wend9399922020-06-17 17:33:49 +00005941 vpython_script = 'vpython'
Andrew Grieveb9e694c2021-11-15 19:04:46 +00005942 else:
5943 vpython_script = 'vpython3'
Peter Wend9399922020-06-17 17:33:49 +00005944
5945 cmd = [vpython_script, yapf_tool, '--style', yapf_style, f]
Aiden Bennerc08566e2018-10-03 17:52:42 +00005946
5947 has_formattable_lines = False
5948 if not opts.full:
5949 # Only run yapf over changed line ranges.
5950 for diff_start, diff_len in py_line_diffs[f]:
5951 diff_end = diff_start + diff_len - 1
5952 # Yapf errors out if diff_end < diff_start but this
5953 # is a valid line range diff for a removal.
5954 if diff_end >= diff_start:
5955 has_formattable_lines = True
5956 cmd += ['-l', '{}-{}'.format(diff_start, diff_end)]
5957 # If all line diffs were removals we have nothing to format.
5958 if not has_formattable_lines:
5959 continue
5960
5961 if opts.diff or opts.dry_run:
5962 cmd += ['--diff']
5963 # Will return non-zero exit code if non-empty diff.
Edward Lesmesb7db1832020-06-22 20:22:27 +00005964 stdout = RunCommand(cmd,
5965 error_ok=True,
Josip Sokcevic673e8ed2021-10-27 23:46:18 +00005966 stderr=subprocess2.PIPE,
Edward Lesmesb7db1832020-06-22 20:22:27 +00005967 cwd=top_dir,
5968 shell=sys.platform.startswith('win32'))
Aiden Bennerc08566e2018-10-03 17:52:42 +00005969 if opts.diff:
5970 sys.stdout.write(stdout)
5971 elif len(stdout) > 0:
5972 return_value = 2
5973 else:
5974 cmd += ['-i']
Edward Lesmesb7db1832020-06-22 20:22:27 +00005975 RunCommand(cmd, cwd=top_dir, shell=sys.platform.startswith('win32'))
sbc@chromium.org9d0644d2015-06-05 23:16:54 +00005976
kylechar@chromium.org8b61f112016-02-05 13:28:58 +00005977 # Format GN build files. Always run on full build files for canonical form.
5978 if gn_diff_files:
Andrii Shyshkalov18975322017-01-25 16:44:13 +01005979 cmd = ['gn', 'format']
brettw4b8ed592016-08-05 16:19:12 -07005980 if opts.dry_run or opts.diff:
5981 cmd.append('--dry-run')
kylechar@chromium.org8b61f112016-02-05 13:28:58 +00005982 for gn_diff_file in gn_diff_files:
brettw4b8ed592016-08-05 16:19:12 -07005983 gn_ret = subprocess2.call(cmd + [gn_diff_file],
Ilya Sherman7aed4bb2020-05-20 22:34:14 +00005984 shell=sys.platform.startswith('win'),
brettw4b8ed592016-08-05 16:19:12 -07005985 cwd=top_dir)
5986 if opts.dry_run and gn_ret == 2:
5987 return_value = 2 # Not formatted.
5988 elif opts.diff and gn_ret == 2:
5989 # TODO this should compute and print the actual diff.
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005990 print('This change has GN build file diff for ' + gn_diff_file)
brettw4b8ed592016-08-05 16:19:12 -07005991 elif gn_ret != 0:
5992 # For non-dry run cases (and non-2 return values for dry-run), a
5993 # nonzero error code indicates a failure, probably because the file
5994 # doesn't parse.
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005995 DieWithError('gn format failed on ' + gn_diff_file +
5996 '\nTry running `gn format` on this file manually.')
kylechar@chromium.org8b61f112016-02-05 13:28:58 +00005997
Ilya Shermane081cbe2017-08-15 17:51:04 -07005998 # Skip the metrics formatting from the global presubmit hook. These files have
5999 # a separate presubmit hook that issues an error if the files need formatting,
6000 # whereas the top-level presubmit script merely issues a warning. Formatting
6001 # these files is somewhat slow, so it's important not to duplicate the work.
6002 if not opts.presubmit:
Wenhan (Han) Zhang3bd3c992020-08-14 16:27:39 +00006003 for diff_xml in GetDiffXMLs(diff_files):
6004 xml_dir = GetMetricsDir(diff_xml)
6005 if not xml_dir:
6006 continue
6007
Ilya Shermane081cbe2017-08-15 17:51:04 -07006008 tool_dir = os.path.join(top_dir, xml_dir)
Ilya Sherman7aed4bb2020-05-20 22:34:14 +00006009 pretty_print_tool = os.path.join(tool_dir, 'pretty_print.py')
Fabrice de Gansecfab092022-09-15 20:59:01 +00006010 cmd = ['vpython3', pretty_print_tool, '--non-interactive']
Wenhan (Han) Zhang3bd3c992020-08-14 16:27:39 +00006011
6012 # If the XML file is histograms.xml or enums.xml, add the xml path to the
6013 # command as histograms/pretty_print.py now needs a relative path argument
6014 # after splitting the histograms into multiple directories.
6015 # For example, in tools/metrics/ukm, pretty-print could be run using:
6016 # $ python pretty_print.py
6017 # But in tools/metrics/histogrmas, pretty-print should be run with an
6018 # additional relative path argument, like:
Peter Kastingee088882021-08-03 17:57:00 +00006019 # $ python pretty_print.py metadata/UMA/histograms.xml
Wenhan (Han) Zhang3bd3c992020-08-14 16:27:39 +00006020 # $ python pretty_print.py enums.xml
6021
Weilun Shib92c4b72020-08-27 17:45:11 +00006022 if (diff_xml.endswith('histograms.xml') or diff_xml.endswith('enums.xml')
Weilun Shi4f50adb2023-01-17 20:43:17 +00006023 or diff_xml.endswith('histogram_suffixes_list.xml')):
Wenhan (Han) Zhang3bd3c992020-08-14 16:27:39 +00006024 cmd.append(diff_xml)
6025
Ilya Shermane081cbe2017-08-15 17:51:04 -07006026 if opts.dry_run or opts.diff:
6027 cmd.append('--diff')
Wenhan (Han) Zhang3bd3c992020-08-14 16:27:39 +00006028
Ilya Sherman7aed4bb2020-05-20 22:34:14 +00006029 # TODO(isherman): Once this file runs only on Python 3.3+, drop the
6030 # `shell` param and instead replace `'vpython'` with
6031 # `shutil.which('frob')` above: https://stackoverflow.com/a/32799942
Wenhan (Han) Zhang3bd3c992020-08-14 16:27:39 +00006032 stdout = RunCommand(cmd,
6033 cwd=top_dir,
Ilya Sherman7aed4bb2020-05-20 22:34:14 +00006034 shell=sys.platform.startswith('win32'))
Ilya Shermane081cbe2017-08-15 17:51:04 -07006035 if opts.diff:
6036 sys.stdout.write(stdout)
6037 if opts.dry_run and stdout:
6038 return_value = 2 # Not formatted.
Alexei Svitkinef3cac412017-02-06 11:08:50 -05006039
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00006040 return return_value
agable@chromium.orgfab8f822013-05-06 17:43:09 +00006041
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00006042
Wenhan (Han) Zhang3bd3c992020-08-14 16:27:39 +00006043def GetDiffXMLs(diff_files):
6044 return [
6045 os.path.normpath(x) for x in diff_files if MatchingFileType(x, ['.xml'])
6046 ]
6047
6048
6049def GetMetricsDir(diff_xml):
Steven Holte2e664bf2017-04-21 13:10:47 -07006050 metrics_xml_dirs = [
6051 os.path.join('tools', 'metrics', 'actions'),
6052 os.path.join('tools', 'metrics', 'histograms'),
6053 os.path.join('tools', 'metrics', 'rappor'),
Ilya Shermanb67e60c2020-05-20 22:27:03 +00006054 os.path.join('tools', 'metrics', 'structured'),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00006055 os.path.join('tools', 'metrics', 'ukm'),
6056 ]
Steven Holte2e664bf2017-04-21 13:10:47 -07006057 for xml_dir in metrics_xml_dirs:
Wenhan (Han) Zhang3bd3c992020-08-14 16:27:39 +00006058 if diff_xml.startswith(xml_dir):
6059 return xml_dir
6060 return None
Steven Holte2e664bf2017-04-21 13:10:47 -07006061
agable@chromium.orgfab8f822013-05-06 17:43:09 +00006062
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00006063@subcommand.usage('<codereview url or issue id>')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00006064@metrics.collector.collect_metrics('git cl checkout')
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00006065def CMDcheckout(parser, args):
Edward Lemurf38bc172019-09-03 21:02:13 +00006066 """Checks out a branch associated with a given Gerrit issue."""
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00006067 _, args = parser.parse_args(args)
6068
6069 if len(args) != 1:
6070 parser.print_help()
6071 return 1
6072
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00006073 issue_arg = ParseIssueNumberArgument(args[0])
tandrii@chromium.orgde6c9a12016-04-11 15:33:53 +00006074 if not issue_arg.valid:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00006075 parser.error('Invalid issue ID or URL.')
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02006076
tandrii@chromium.orgabd27e52016-04-11 15:43:32 +00006077 target_issue = str(issue_arg.issue)
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00006078
Edward Lemur52969c92020-02-06 18:15:28 +00006079 output = RunGit(['config', '--local', '--get-regexp',
Edward Lesmes50da7702020-03-30 19:23:43 +00006080 r'branch\..*\.' + ISSUE_CONFIG_KEY],
Edward Lemur52969c92020-02-06 18:15:28 +00006081 error_ok=True)
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00006082
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00006083 branches = []
Edward Lemur52969c92020-02-06 18:15:28 +00006084 for key, issue in [x.split() for x in output.splitlines()]:
6085 if issue == target_issue:
Edward Lesmes50da7702020-03-30 19:23:43 +00006086 branches.append(re.sub(r'branch\.(.*)\.' + ISSUE_CONFIG_KEY, r'\1', key))
Edward Lemur52969c92020-02-06 18:15:28 +00006087
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00006088 if len(branches) == 0:
vapiera7fbd5a2016-06-16 09:17:49 -07006089 print('No branch found for issue %s.' % target_issue)
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00006090 return 1
6091 if len(branches) == 1:
6092 RunGit(['checkout', branches[0]])
6093 else:
vapiera7fbd5a2016-06-16 09:17:49 -07006094 print('Multiple branches match issue %s:' % target_issue)
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00006095 for i in range(len(branches)):
vapiera7fbd5a2016-06-16 09:17:49 -07006096 print('%d: %s' % (i, branches[i]))
Edward Lesmesae3586b2020-03-23 21:21:14 +00006097 which = gclient_utils.AskForData('Choose by index: ')
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00006098 try:
6099 RunGit(['checkout', branches[int(which)]])
6100 except (IndexError, ValueError):
vapiera7fbd5a2016-06-16 09:17:49 -07006101 print('Invalid selection, not checking out any branch.')
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00006102 return 1
6103
6104 return 0
6105
6106
maruel@chromium.org29404b52014-09-08 22:58:00 +00006107def CMDlol(parser, args):
6108 # This command is intentionally undocumented.
vapiera7fbd5a2016-06-16 09:17:49 -07006109 print(zlib.decompress(base64.b64decode(
thakis@chromium.org3421c992014-11-02 02:20:32 +00006110 'eNptkLEOwyAMRHe+wupCIqW57v0Vq84WqWtXyrcXnCBsmgMJ+/SSAxMZgRB6NzE'
6111 'E2ObgCKJooYdu4uAQVffUEoE1sRQLxAcqzd7uK2gmStrll1ucV3uZyaY5sXyDd9'
6112 'JAnN+lAXsOMJ90GANAi43mq5/VeeacylKVgi8o6F1SC63FxnagHfJUTfUYdCR/W'
Gavin Mak18f45d22020-12-04 21:45:10 +00006113 'Ofe+0dHL7PicpytKP750Fh1q2qnLVof4w8OZWNY')).decode('utf-8'))
maruel@chromium.org29404b52014-09-08 22:58:00 +00006114 return 0
6115
6116
Josip Sokcevic0399e172022-03-21 23:11:51 +00006117def CMDversion(parser, args):
6118 import utils
6119 print(utils.depot_tools_version())
6120
6121
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00006122class OptionParser(optparse.OptionParser):
6123 """Creates the option parse and add --verbose support."""
Sigurd Schneider9abde8c2020-11-17 08:44:52 +00006124
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00006125 def __init__(self, *args, **kwargs):
maruel@chromium.org0633fb42013-08-16 20:06:14 +00006126 optparse.OptionParser.__init__(
6127 self, *args, prog='git cl', version=__version__, **kwargs)
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00006128 self.add_option(
6129 '-v', '--verbose', action='count', default=0,
6130 help='Use 2 times for more debugging info')
6131
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00006132 def parse_args(self, args=None, _values=None):
Andrii Shyshkalov46f20cd2018-10-30 06:42:54 +00006133 try:
6134 return self._parse_args(args)
6135 finally:
6136 # Regardless of success or failure of args parsing, we want to report
6137 # metrics, but only after logging has been initialized (if parsing
6138 # succeeded).
6139 global settings
6140 settings = Settings()
6141
Edward Lesmes9c349062021-05-06 20:02:39 +00006142 if metrics.collector.config.should_collect_metrics:
Andrii Shyshkalov46f20cd2018-10-30 06:42:54 +00006143 # GetViewVCUrl ultimately calls logging method.
6144 project_url = settings.GetViewVCUrl().strip('/+')
6145 if project_url in metrics_utils.KNOWN_PROJECT_URLS:
6146 metrics.collector.add('project_urls', [project_url])
6147
6148 def _parse_args(self, args=None):
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00006149 # Create an optparse.Values object that will store only the actual passed
6150 # options, without the defaults.
6151 actual_options = optparse.Values()
6152 _, args = optparse.OptionParser.parse_args(self, args, actual_options)
6153 # Create an optparse.Values object with the default options.
6154 options = optparse.Values(self.get_default_values().__dict__)
6155 # Update it with the options passed by the user.
6156 options._update_careful(actual_options.__dict__)
6157 # Store the options passed by the user in an _actual_options attribute.
6158 # We store only the keys, and not the values, since the values can contain
6159 # arbitrary information, which might be PII.
Edward Lemur79d4f992019-11-11 23:49:02 +00006160 metrics.collector.add('arguments', list(actual_options.__dict__.keys()))
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00006161
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00006162 levels = [logging.WARNING, logging.INFO, logging.DEBUG]
Andrii Shyshkalov5b04a572017-01-23 17:44:41 +01006163 logging.basicConfig(
6164 level=levels[min(options.verbose, len(levels) - 1)],
6165 format='[%(levelname).1s%(asctime)s %(process)d %(thread)d '
6166 '%(filename)s] %(message)s')
Edward Lemur83bd7f42018-10-10 00:14:21 +00006167
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00006168 return options, args
6169
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00006170
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00006171def main(argv):
maruel@chromium.org82798cb2012-02-23 18:16:12 +00006172 if sys.hexversion < 0x02060000:
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00006173 print('\nYour Python version %s is unsupported, please upgrade.\n' %
vapiera7fbd5a2016-06-16 09:17:49 -07006174 (sys.version.split(' ', 1)[0],), file=sys.stderr)
maruel@chromium.org82798cb2012-02-23 18:16:12 +00006175 return 2
maruel@chromium.org2e23ce32013-05-07 12:42:28 +00006176
maruel@chromium.org39c0b222013-08-17 16:57:01 +00006177 colorize_CMDstatus_doc()
maruel@chromium.org0633fb42013-08-16 20:06:14 +00006178 dispatcher = subcommand.CommandDispatcher(__name__)
6179 try:
6180 return dispatcher.execute(OptionParser(), argv)
Edward Lemur5b929a42019-10-21 17:57:39 +00006181 except auth.LoginRequiredError as e:
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +00006182 DieWithError(str(e))
Edward Lemur79d4f992019-11-11 23:49:02 +00006183 except urllib.error.HTTPError as e:
maruel@chromium.org0633fb42013-08-16 20:06:14 +00006184 if e.code != 500:
6185 raise
6186 DieWithError(
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00006187 ('App Engine is misbehaving and returned HTTP %d, again. Keep faith '
Quinten Yearsleyc4202212019-07-22 23:34:40 +00006188 'and retry or visit go/isgaeup.\n%s') % (e.code, str(e)))
sbc@chromium.org013731e2015-02-26 18:28:43 +00006189 return 0
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00006190
6191
6192if __name__ == '__main__':
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00006193 # These affect sys.stdout, so do it outside of main() to simplify mocks in
6194 # the unit tests.
maruel@chromium.org6f09cd92011-04-01 16:38:12 +00006195 fix_encoding.fix_encoding()
iannucci@chromium.org596cd5c2016-04-04 21:34:39 +00006196 setup_color.init()
Edward Lemur6f812e12018-07-31 22:45:57 +00006197 with metrics.collector.print_notice_and_exit():
sbc@chromium.org013731e2015-02-26 18:28:43 +00006198 sys.exit(main(sys.argv[1:]))