blob: b1383a8bd8eff18e3360adc56e709f7c9a416bc1 [file] [log] [blame]
iannucci@chromium.org405b87e2015-11-12 18:08:34 +00001#!/usr/bin/env python
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +02002# Copyright (c) 2013 The Chromium Authors. All rights reserved.
maruel@chromium.org725f1c32011-04-01 20:24:54 +00003# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00006# Copyright (C) 2008 Evan Martin <martine@danga.com>
7
Andrii Shyshkalov03da1502018-10-15 03:42:34 +00008"""A git-command for integrating reviews on Gerrit."""
maruel@chromium.org725f1c32011-04-01 20:24:54 +00009
vapiera7fbd5a2016-06-16 09:17:49 -070010from __future__ import print_function
11
tapted@chromium.org6a0b07c2013-07-10 01:29:19 +000012from distutils.version import LooseVersion
calamity@chromium.orgffde55c2015-03-12 00:44:17 +000013from multiprocessing.pool import ThreadPool
thakis@chromium.org3421c992014-11-02 02:20:32 +000014import base64
rmistry@google.com2dd99862015-06-22 12:22:18 +000015import collections
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +010016import contextlib
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +010017import datetime
Andrii Shyshkalovcd6a9362016-12-07 12:04:12 +010018import fnmatch
sheyang@google.com6ebaf782015-05-12 19:17:54 +000019import httplib
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +010020import itertools
maruel@chromium.org4f6852c2012-04-20 20:39:20 +000021import json
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000022import logging
calamity@chromium.orgcf197482016-04-29 20:15:53 +000023import multiprocessing
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000024import optparse
25import os
26import re
Andrii Shyshkalov353637c2017-03-14 16:52:18 +010027import shutil
ukai@chromium.org78c4b982012-02-14 02:20:26 +000028import stat
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000029import sys
Aaron Gable9a03ae02017-11-03 11:31:07 -070030import tempfile
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000031import textwrap
Edward Lemurfec80c42018-11-01 23:14:14 +000032import time
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +000033import urllib
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000034import urllib2
maruel@chromium.org967c0a82013-06-17 22:52:24 +000035import urlparse
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +000036import uuid
thestig@chromium.org00858c82013-12-02 23:08:03 +000037import webbrowser
thakis@chromium.org3421c992014-11-02 02:20:32 +000038import zlib
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000039
40try:
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -080041 import readline # pylint: disable=import-error,W0611
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000042except ImportError:
43 pass
44
maruel@chromium.org2e23ce32013-05-07 12:42:28 +000045from third_party import colorama
sheyang@google.com6ebaf782015-05-12 19:17:54 +000046from third_party import httplib2
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +000047import auth
skobes6468b902016-10-24 08:45:10 -070048import checkout
nick@chromium.org3ac1c4e2014-01-16 02:44:42 +000049import clang_format
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +000050import dart_format
iannucci@chromium.org596cd5c2016-04-04 21:34:39 +000051import setup_color
maruel@chromium.org6f09cd92011-04-01 16:38:12 +000052import fix_encoding
maruel@chromium.org0e0436a2011-10-25 13:32:41 +000053import gclient_utils
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +000054import gerrit_util
szager@chromium.org151ebcf2016-03-09 01:08:25 +000055import git_cache
iannucci@chromium.org9e849272014-04-04 00:31:55 +000056import git_common
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +000057import git_footers
Edward Lemur5ba1e9c2018-07-23 18:19:02 +000058import metrics
Edward Lesmes93277a72018-10-18 22:04:26 +000059import metrics_utils
piman@chromium.org336f9122014-09-04 02:16:55 +000060import owners
iannucci@chromium.org9e849272014-04-04 00:31:55 +000061import owners_finder
maruel@chromium.org2a74d372011-03-29 19:05:50 +000062import presubmit_support
63import scm
Francois Dorayd42c6812017-05-30 15:10:20 -040064import split_cl
maruel@chromium.org0633fb42013-08-16 20:06:14 +000065import subcommand
maruel@chromium.org32f9f5e2011-09-14 13:41:47 +000066import subprocess2
maruel@chromium.org2a74d372011-03-29 19:05:50 +000067import watchlists
68
tandrii7400cf02016-06-21 08:48:07 -070069__version__ = '2.0'
maruel@chromium.org2a74d372011-03-29 19:05:50 +000070
tandrii9d2c7a32016-06-22 03:42:45 -070071COMMIT_BOT_EMAIL = 'commit-bot@chromium.org'
Aaron Gable1bc7bfe2016-12-19 10:08:14 -080072POSTUPSTREAM_HOOK = '.git/hooks/post-cl-land'
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000073DESCRIPTION_BACKUP_FILE = '~/.git_cl_description_backup'
rmistry@google.comc68112d2015-03-03 12:48:06 +000074REFS_THAT_ALIAS_TO_OTHER_REFS = {
75 'refs/remotes/origin/lkgr': 'refs/remotes/origin/master',
76 'refs/remotes/origin/lkcr': 'refs/remotes/origin/master',
77}
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000078
thestig@chromium.org44202a22014-03-11 19:22:18 +000079# Valid extensions for files we want to lint.
80DEFAULT_LINT_REGEX = r"(.*\.cpp|.*\.cc|.*\.h)"
81DEFAULT_LINT_IGNORE_REGEX = r"$^"
82
Aiden Bennerc08566e2018-10-03 17:52:42 +000083# File name for yapf style config files.
84YAPF_CONFIG_FILENAME = '.style.yapf'
85
borenet6c0efe62016-10-19 08:13:29 -070086# Buildbucket master name prefix.
87MASTER_PREFIX = 'master.'
88
maruel@chromium.org2e23ce32013-05-07 12:42:28 +000089# Shortcut since it quickly becomes redundant.
90Fore = colorama.Fore
maruel@chromium.org90541732011-04-01 17:54:18 +000091
maruel@chromium.orgddd59412011-11-30 14:20:38 +000092# Initialized in main()
93settings = None
94
Andrii Shyshkalov768f1d82016-12-08 15:10:13 +010095# Used by tests/git_cl_test.py to add extra logging.
96# Inside the weirdly failing test, add this:
97# >>> self.mock(git_cl, '_IS_BEING_TESTED', True)
Quinten Yearsley0c62da92017-05-31 13:39:42 -070098# And scroll up to see the stack trace printed.
Andrii Shyshkalov768f1d82016-12-08 15:10:13 +010099_IS_BEING_TESTED = False
100
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000101
Christopher Lamf732cd52017-01-24 12:40:11 +1100102def DieWithError(message, change_desc=None):
103 if change_desc:
104 SaveDescriptionBackup(change_desc)
105
vapiera7fbd5a2016-06-16 09:17:49 -0700106 print(message, file=sys.stderr)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000107 sys.exit(1)
108
109
Christopher Lamf732cd52017-01-24 12:40:11 +1100110def SaveDescriptionBackup(change_desc):
111 backup_path = os.path.expanduser(DESCRIPTION_BACKUP_FILE)
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000112 print('\nsaving CL description to %s\n' % backup_path)
Christopher Lamf732cd52017-01-24 12:40:11 +1100113 backup_file = open(backup_path, 'w')
114 backup_file.write(change_desc.description)
115 backup_file.close()
116
117
thestig@chromium.org8b0553c2014-02-11 00:33:37 +0000118def GetNoGitPagerEnv():
119 env = os.environ.copy()
120 # 'cat' is a magical git string that disables pagers on all platforms.
121 env['GIT_PAGER'] = 'cat'
122 return env
123
vadimsh@chromium.org566a02a2014-08-22 01:34:13 +0000124
bsep@chromium.org627d9002016-04-29 00:00:52 +0000125def RunCommand(args, error_ok=False, error_message=None, shell=False, **kwargs):
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000126 try:
bsep@chromium.org627d9002016-04-29 00:00:52 +0000127 return subprocess2.check_output(args, shell=shell, **kwargs)
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000128 except subprocess2.CalledProcessError as e:
129 logging.debug('Failed running %s', args)
maruel@chromium.org32f9f5e2011-09-14 13:41:47 +0000130 if not error_ok:
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000131 DieWithError(
maruel@chromium.org32f9f5e2011-09-14 13:41:47 +0000132 'Command "%s" failed.\n%s' % (
133 ' '.join(args), error_message or e.stdout or ''))
134 return e.stdout
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000135
136
137def RunGit(args, **kwargs):
maruel@chromium.org32f9f5e2011-09-14 13:41:47 +0000138 """Returns stdout."""
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000139 return RunCommand(['git'] + args, **kwargs)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000140
141
enne@chromium.org3b7e15c2014-01-21 17:44:47 +0000142def RunGitWithCode(args, suppress_stderr=False):
maruel@chromium.org32f9f5e2011-09-14 13:41:47 +0000143 """Returns return code and stdout."""
tandrii5d48c322016-08-18 16:19:37 -0700144 if suppress_stderr:
145 stderr = subprocess2.VOID
146 else:
147 stderr = sys.stderr
szager@chromium.org9bb85e22012-06-13 20:28:23 +0000148 try:
tandrii5d48c322016-08-18 16:19:37 -0700149 (out, _), code = subprocess2.communicate(['git'] + args,
150 env=GetNoGitPagerEnv(),
151 stdout=subprocess2.PIPE,
152 stderr=stderr)
153 return code, out
154 except subprocess2.CalledProcessError as e:
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +0900155 logging.debug('Failed running %s', ['git'] + args)
tandrii5d48c322016-08-18 16:19:37 -0700156 return e.returncode, e.stdout
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000157
158
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000159def RunGitSilent(args):
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +0000160 """Returns stdout, suppresses stderr and ignores the return code."""
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000161 return RunGitWithCode(args, suppress_stderr=True)[1]
162
163
tapted@chromium.org6a0b07c2013-07-10 01:29:19 +0000164def IsGitVersionAtLeast(min_version):
ilevy@chromium.orgcc56ee42013-07-10 22:16:29 +0000165 prefix = 'git version '
tapted@chromium.org6a0b07c2013-07-10 01:29:19 +0000166 version = RunGit(['--version']).strip()
ilevy@chromium.orgcc56ee42013-07-10 22:16:29 +0000167 return (version.startswith(prefix) and
168 LooseVersion(version[len(prefix):]) >= LooseVersion(min_version))
tapted@chromium.org6a0b07c2013-07-10 01:29:19 +0000169
170
pgervais@chromium.org8ba38ff2015-06-11 21:41:25 +0000171def BranchExists(branch):
172 """Return True if specified branch exists."""
173 code, _ = RunGitWithCode(['rev-parse', '--verify', branch],
174 suppress_stderr=True)
175 return not code
176
177
tandrii2a16b952016-10-19 07:09:44 -0700178def time_sleep(seconds):
179 # Use this so that it can be mocked in tests without interfering with python
180 # system machinery.
tandrii2a16b952016-10-19 07:09:44 -0700181 return time.sleep(seconds)
182
183
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000184def time_time():
185 # Use this so that it can be mocked in tests without interfering with python
186 # system machinery.
187 return time.time()
188
189
maruel@chromium.org90541732011-04-01 17:54:18 +0000190def ask_for_data(prompt):
191 try:
192 return raw_input(prompt)
193 except KeyboardInterrupt:
194 # Hide the exception.
195 sys.exit(1)
196
197
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100198def confirm_or_exit(prefix='', action='confirm'):
199 """Asks user to press enter to continue or press Ctrl+C to abort."""
200 if not prefix or prefix.endswith('\n'):
201 mid = 'Press'
Andrii Shyshkalov353637c2017-03-14 16:52:18 +0100202 elif prefix.endswith('.') or prefix.endswith('?'):
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100203 mid = ' Press'
204 elif prefix.endswith(' '):
205 mid = 'press'
206 else:
207 mid = ' press'
208 ask_for_data('%s%s Enter to %s, or Ctrl+C to abort' % (prefix, mid, action))
209
210
211def ask_for_explicit_yes(prompt):
212 """Returns whether user typed 'y' or 'yes' to confirm the given prompt"""
213 result = ask_for_data(prompt + ' [Yes/No]: ').lower()
214 while True:
215 if 'yes'.startswith(result):
216 return True
217 if 'no'.startswith(result):
218 return False
219 result = ask_for_data('Please, type yes or no: ').lower()
220
221
tandrii5d48c322016-08-18 16:19:37 -0700222def _git_branch_config_key(branch, key):
223 """Helper method to return Git config key for a branch."""
224 assert branch, 'branch name is required to set git config for it'
225 return 'branch.%s.%s' % (branch, key)
226
227
228def _git_get_branch_config_value(key, default=None, value_type=str,
229 branch=False):
230 """Returns git config value of given or current branch if any.
231
232 Returns default in all other cases.
233 """
234 assert value_type in (int, str, bool)
235 if branch is False: # Distinguishing default arg value from None.
236 branch = GetCurrentBranch()
237
rogerta@chromium.orgcaa16552013-03-18 20:45:05 +0000238 if not branch:
tandrii5d48c322016-08-18 16:19:37 -0700239 return default
rogerta@chromium.orgcaa16552013-03-18 20:45:05 +0000240
tandrii5d48c322016-08-18 16:19:37 -0700241 args = ['config']
tandrii33a46ff2016-08-23 05:53:40 -0700242 if value_type == bool:
tandrii5d48c322016-08-18 16:19:37 -0700243 args.append('--bool')
tandrii33a46ff2016-08-23 05:53:40 -0700244 # git config also has --int, but apparently git config suffers from integer
245 # overflows (http://crbug.com/640115), so don't use it.
tandrii5d48c322016-08-18 16:19:37 -0700246 args.append(_git_branch_config_key(branch, key))
247 code, out = RunGitWithCode(args)
248 if code == 0:
249 value = out.strip()
250 if value_type == int:
251 return int(value)
252 if value_type == bool:
253 return bool(value.lower() == 'true')
254 return value
iannucci@chromium.org79540052012-10-19 23:15:26 +0000255 return default
256
257
tandrii5d48c322016-08-18 16:19:37 -0700258def _git_set_branch_config_value(key, value, branch=None, **kwargs):
259 """Sets the value or unsets if it's None of a git branch config.
260
261 Valid, though not necessarily existing, branch must be provided,
262 otherwise currently checked out branch is used.
263 """
264 if not branch:
265 branch = GetCurrentBranch()
266 assert branch, 'a branch name OR currently checked out branch is required'
267 args = ['config']
qyearsley12fa6ff2016-08-24 09:18:40 -0700268 # Check for boolean first, because bool is int, but int is not bool.
tandrii5d48c322016-08-18 16:19:37 -0700269 if value is None:
270 args.append('--unset')
271 elif isinstance(value, bool):
272 args.append('--bool')
273 value = str(value).lower()
tandrii5d48c322016-08-18 16:19:37 -0700274 else:
tandrii33a46ff2016-08-23 05:53:40 -0700275 # git config also has --int, but apparently git config suffers from integer
276 # overflows (http://crbug.com/640115), so don't use it.
tandrii5d48c322016-08-18 16:19:37 -0700277 value = str(value)
278 args.append(_git_branch_config_key(branch, key))
279 if value is not None:
280 args.append(value)
281 RunGit(args, **kwargs)
282
283
Andrii Shyshkalova6695812016-12-06 17:47:09 +0100284def _get_committer_timestamp(commit):
Quinten Yearsley0c62da92017-05-31 13:39:42 -0700285 """Returns Unix timestamp as integer of a committer in a commit.
Andrii Shyshkalova6695812016-12-06 17:47:09 +0100286
287 Commit can be whatever git show would recognize, such as HEAD, sha1 or ref.
288 """
289 # Git also stores timezone offset, but it only affects visual display,
290 # actual point in time is defined by this timestamp only.
291 return int(RunGit(['show', '-s', '--format=%ct', commit]).strip())
292
293
294def _git_amend_head(message, committer_timestamp):
295 """Amends commit with new message and desired committer_timestamp.
296
297 Sets committer timezone to UTC.
298 """
299 env = os.environ.copy()
300 env['GIT_COMMITTER_DATE'] = '%d+0000' % committer_timestamp
301 return RunGit(['commit', '--amend', '-m', message], env=env)
302
303
machenbach@chromium.org45453142015-09-15 08:45:22 +0000304def _get_properties_from_options(options):
305 properties = dict(x.split('=', 1) for x in options.properties)
306 for key, val in properties.iteritems():
307 try:
308 properties[key] = json.loads(val)
309 except ValueError:
310 pass # If a value couldn't be evaluated, treat it as a string.
311 return properties
312
313
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000314def _prefix_master(master):
315 """Convert user-specified master name to full master name.
316
317 Buildbucket uses full master name(master.tryserver.chromium.linux) as bucket
318 name, while the developers always use shortened master name
319 (tryserver.chromium.linux) by stripping off the prefix 'master.'. This
320 function does the conversion for buildbucket migration.
321 """
borenet6c0efe62016-10-19 08:13:29 -0700322 if master.startswith(MASTER_PREFIX):
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000323 return master
borenet6c0efe62016-10-19 08:13:29 -0700324 return '%s%s' % (MASTER_PREFIX, master)
325
326
327def _unprefix_master(bucket):
328 """Convert bucket name to shortened master name.
329
330 Buildbucket uses full master name(master.tryserver.chromium.linux) as bucket
331 name, while the developers always use shortened master name
332 (tryserver.chromium.linux) by stripping off the prefix 'master.'. This
333 function does the conversion for buildbucket migration.
334 """
335 if bucket.startswith(MASTER_PREFIX):
336 return bucket[len(MASTER_PREFIX):]
337 return bucket
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000338
339
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000340def _buildbucket_retry(operation_name, http, *args, **kwargs):
341 """Retries requests to buildbucket service and returns parsed json content."""
342 try_count = 0
343 while True:
344 response, content = http.request(*args, **kwargs)
345 try:
346 content_json = json.loads(content)
347 except ValueError:
348 content_json = None
349
350 # Buildbucket could return an error even if status==200.
351 if content_json and content_json.get('error'):
nodir@chromium.orgbaff4e12016-03-08 00:33:57 +0000352 error = content_json.get('error')
353 if error.get('code') == 403:
354 raise BuildbucketResponseException(
355 'Access denied: %s' % error.get('message', ''))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000356 msg = 'Error in response. Reason: %s. Message: %s.' % (
nodir@chromium.orgbaff4e12016-03-08 00:33:57 +0000357 error.get('reason', ''), error.get('message', ''))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000358 raise BuildbucketResponseException(msg)
359
360 if response.status == 200:
Nodir Turakulov23d75d22018-06-04 12:37:32 -0700361 if content_json is None:
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000362 raise BuildbucketResponseException(
363 'Buildbucket returns invalid json content: %s.\n'
Nodir Turakulov9ac59792018-06-04 12:34:14 -0700364 'Please file bugs at http://crbug.com, '
365 'component "Infra>Platform>BuildBucket".' %
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000366 content)
367 return content_json
368 if response.status < 500 or try_count >= 2:
369 raise httplib2.HttpLib2Error(content)
370
371 # status >= 500 means transient failures.
372 logging.debug('Transient errors when %s. Will retry.', operation_name)
tandrii2a16b952016-10-19 07:09:44 -0700373 time_sleep(0.5 + 1.5*try_count)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000374 try_count += 1
375 assert False, 'unreachable'
376
377
qyearsley1fdfcb62016-10-24 13:22:03 -0700378def _get_bucket_map(changelist, options, option_parser):
qyearsleydd49f942016-10-28 11:57:22 -0700379 """Returns a dict mapping bucket names to builders and tests,
380 for triggering try jobs.
qyearsley1fdfcb62016-10-24 13:22:03 -0700381 """
qyearsleydd49f942016-10-28 11:57:22 -0700382 # If no bots are listed, we try to get a set of builders and tests based
383 # on GetPreferredTryMasters functions in PRESUBMIT.py files.
qyearsley1fdfcb62016-10-24 13:22:03 -0700384 if not options.bot:
385 change = changelist.GetChange(
386 changelist.GetCommonAncestorWithUpstream(), None)
qyearsley136b49f2016-10-31 09:02:26 -0700387 # Get try masters from PRESUBMIT.py files.
nodire4f0fe02016-11-04 16:23:30 -0700388 masters = presubmit_support.DoGetTryMasters(
qyearsley1fdfcb62016-10-24 13:22:03 -0700389 change=change,
390 changed_files=change.LocalPaths(),
391 repository_root=settings.GetRoot(),
392 default_presubmit=None,
393 project=None,
394 verbose=options.verbose,
395 output_stream=sys.stdout)
nodire4f0fe02016-11-04 16:23:30 -0700396 if masters is None:
397 return None
Sergiy Byelozyorov935b93f2016-11-28 20:41:56 +0100398 return {_prefix_master(m): b for m, b in masters.iteritems()}
qyearsley1fdfcb62016-10-24 13:22:03 -0700399
qyearsley1fdfcb62016-10-24 13:22:03 -0700400 if options.bucket:
401 return {options.bucket: {b: [] for b in options.bot}}
qyearsleydd49f942016-10-28 11:57:22 -0700402 if options.master:
403 return {_prefix_master(options.master): {b: [] for b in options.bot}}
qyearsley1fdfcb62016-10-24 13:22:03 -0700404
qyearsleydd49f942016-10-28 11:57:22 -0700405 # If bots are listed but no master or bucket, then we need to find out
406 # the corresponding master for each bot.
407 bucket_map, error_message = _get_bucket_map_for_builders(options.bot)
408 if error_message:
409 option_parser.error(
410 'Tryserver master cannot be found because: %s\n'
411 'Please manually specify the tryserver master, e.g. '
412 '"-m tryserver.chromium.linux".' % error_message)
413 return bucket_map
qyearsley1fdfcb62016-10-24 13:22:03 -0700414
415
qyearsley123a4682016-10-26 09:12:17 -0700416def _get_bucket_map_for_builders(builders):
417 """Returns a map of buckets to builders for the given builders."""
qyearsley1fdfcb62016-10-24 13:22:03 -0700418 map_url = 'https://builders-map.appspot.com/'
419 try:
qyearsley123a4682016-10-26 09:12:17 -0700420 builders_map = json.load(urllib2.urlopen(map_url))
qyearsley1fdfcb62016-10-24 13:22:03 -0700421 except urllib2.URLError as e:
422 return None, ('Failed to fetch builder-to-master map from %s. Error: %s.' %
423 (map_url, e))
424 except ValueError as e:
425 return None, ('Invalid json string from %s. Error: %s.' % (map_url, e))
qyearsley123a4682016-10-26 09:12:17 -0700426 if not builders_map:
qyearsley1fdfcb62016-10-24 13:22:03 -0700427 return None, 'Failed to build master map.'
428
qyearsley123a4682016-10-26 09:12:17 -0700429 bucket_map = {}
430 for builder in builders:
Nodir Turakulovb422e682018-02-20 22:51:30 -0800431 bucket = builders_map.get(builder, {}).get('bucket')
432 if bucket:
433 bucket_map.setdefault(bucket, {})[builder] = []
qyearsley123a4682016-10-26 09:12:17 -0700434 return bucket_map, None
qyearsley1fdfcb62016-10-24 13:22:03 -0700435
436
Andrii Shyshkalovf9648b52018-02-21 22:32:42 -0800437def _trigger_try_jobs(auth_config, changelist, buckets, options, patchset):
qyearsley1fdfcb62016-10-24 13:22:03 -0700438 """Sends a request to Buildbucket to trigger try jobs for a changelist.
439
440 Args:
Aaron Gablefb28d482018-04-02 13:08:06 -0700441 auth_config: AuthConfig for Buildbucket.
qyearsley1fdfcb62016-10-24 13:22:03 -0700442 changelist: Changelist that the try jobs are associated with.
443 buckets: A nested dict mapping bucket names to builders to tests.
444 options: Command-line options.
445 """
tandriide281ae2016-10-12 06:02:30 -0700446 assert changelist.GetIssue(), 'CL must be uploaded first'
447 codereview_url = changelist.GetCodereviewServer()
448 assert codereview_url, 'CL must be uploaded first'
449 patchset = patchset or changelist.GetMostRecentPatchset()
450 assert patchset, 'CL must be uploaded first'
451
452 codereview_host = urlparse.urlparse(codereview_url).hostname
Aaron Gablefb28d482018-04-02 13:08:06 -0700453 # Cache the buildbucket credentials under the codereview host key, so that
454 # users can use different credentials for different buckets.
tandriide281ae2016-10-12 06:02:30 -0700455 authenticator = auth.get_authenticator_for_host(codereview_host, auth_config)
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000456 http = authenticator.authorize(httplib2.Http())
457 http.force_exception_to_status_code = True
tandriide281ae2016-10-12 06:02:30 -0700458
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000459 buildbucket_put_url = (
460 'https://{hostname}/_ah/api/buildbucket/v1/builds/batch'.format(
sheyang@chromium.orgdb375572015-08-17 19:22:23 +0000461 hostname=options.buildbucket_host))
Andrii Shyshkalov03da1502018-10-15 03:42:34 +0000462 buildset = 'patch/gerrit/{hostname}/{issue}/{patch}'.format(
tandriide281ae2016-10-12 06:02:30 -0700463 hostname=codereview_host,
464 issue=changelist.GetIssue(),
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000465 patch=patchset)
tandrii8c5a3532016-11-04 07:52:02 -0700466
Quinten Yearsley0c62da92017-05-31 13:39:42 -0700467 shared_parameters_properties = changelist.GetTryJobProperties(patchset)
Andrii Shyshkalovf9648b52018-02-21 22:32:42 -0800468 shared_parameters_properties['category'] = options.category
tandrii8c5a3532016-11-04 07:52:02 -0700469 if options.clobber:
470 shared_parameters_properties['clobber'] = True
tandriide281ae2016-10-12 06:02:30 -0700471 extra_properties = _get_properties_from_options(options)
tandrii8c5a3532016-11-04 07:52:02 -0700472 if extra_properties:
473 shared_parameters_properties.update(extra_properties)
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000474
475 batch_req_body = {'builds': []}
476 print_text = []
477 print_text.append('Tried jobs on:')
borenet6c0efe62016-10-19 08:13:29 -0700478 for bucket, builders_and_tests in sorted(buckets.iteritems()):
479 print_text.append('Bucket: %s' % bucket)
480 master = None
481 if bucket.startswith(MASTER_PREFIX):
482 master = _unprefix_master(bucket)
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000483 for builder, tests in sorted(builders_and_tests.iteritems()):
484 print_text.append(' %s: %s' % (builder, tests))
485 parameters = {
486 'builder_name': builder,
nodir@chromium.orgd2217312015-09-21 15:51:21 +0000487 'changes': [{
Andrii Shyshkaloveadad922017-01-26 09:38:30 +0100488 'author': {'email': changelist.GetIssueOwner()},
nodir@chromium.orgd2217312015-09-21 15:51:21 +0000489 'revision': options.revision,
490 }],
tandrii8c5a3532016-11-04 07:52:02 -0700491 'properties': shared_parameters_properties.copy(),
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000492 }
machenbach@chromium.org2403e802016-04-29 12:34:42 +0000493 if 'presubmit' in builder.lower():
494 parameters['properties']['dry_run'] = 'true'
tandrii@chromium.org3764fa22015-10-21 16:40:40 +0000495 if tests:
496 parameters['properties']['testfilter'] = tests
borenet6c0efe62016-10-19 08:13:29 -0700497
498 tags = [
499 'builder:%s' % builder,
500 'buildset:%s' % buildset,
501 'user_agent:git_cl_try',
502 ]
503 if master:
504 parameters['properties']['master'] = master
505 tags.append('master:%s' % master)
506
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000507 batch_req_body['builds'].append(
508 {
509 'bucket': bucket,
510 'parameters_json': json.dumps(parameters),
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000511 'client_operation_id': str(uuid.uuid4()),
borenet6c0efe62016-10-19 08:13:29 -0700512 'tags': tags,
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000513 }
514 )
515
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000516 _buildbucket_retry(
qyearsleyeab3c042016-08-24 09:18:28 -0700517 'triggering try jobs',
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000518 http,
519 buildbucket_put_url,
520 'PUT',
521 body=json.dumps(batch_req_body),
522 headers={'Content-Type': 'application/json'}
523 )
tandrii@chromium.org35c61452016-02-26 15:24:57 +0000524 print_text.append('To see results here, run: git cl try-results')
525 print_text.append('To see results in browser, run: git cl web')
vapiera7fbd5a2016-06-16 09:17:49 -0700526 print('\n'.join(print_text))
kjellander@chromium.org44424542015-06-02 18:35:29 +0000527
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000528
tandrii221ab252016-10-06 08:12:04 -0700529def fetch_try_jobs(auth_config, changelist, buildbucket_host,
530 patchset=None):
qyearsleyeab3c042016-08-24 09:18:28 -0700531 """Fetches try jobs from buildbucket.
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000532
qyearsley53f48a12016-09-01 10:45:13 -0700533 Returns a map from build id to build info as a dictionary.
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000534 """
tandrii221ab252016-10-06 08:12:04 -0700535 assert buildbucket_host
536 assert changelist.GetIssue(), 'CL must be uploaded first'
537 assert changelist.GetCodereviewServer(), 'CL must be uploaded first'
538 patchset = patchset or changelist.GetMostRecentPatchset()
539 assert patchset, 'CL must be uploaded first'
540
541 codereview_url = changelist.GetCodereviewServer()
542 codereview_host = urlparse.urlparse(codereview_url).hostname
543 authenticator = auth.get_authenticator_for_host(codereview_host, auth_config)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000544 if authenticator.has_cached_credentials():
545 http = authenticator.authorize(httplib2.Http())
546 else:
vapiera7fbd5a2016-06-16 09:17:49 -0700547 print('Warning: Some results might be missing because %s' %
548 # Get the message on how to login.
tandrii221ab252016-10-06 08:12:04 -0700549 (auth.LoginRequiredError(codereview_host).message,))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000550 http = httplib2.Http()
551
552 http.force_exception_to_status_code = True
553
Andrii Shyshkalov03da1502018-10-15 03:42:34 +0000554 buildset = 'patch/gerrit/{hostname}/{issue}/{patch}'.format(
tandrii221ab252016-10-06 08:12:04 -0700555 hostname=codereview_host,
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000556 issue=changelist.GetIssue(),
tandrii221ab252016-10-06 08:12:04 -0700557 patch=patchset)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000558 params = {'tag': 'buildset:%s' % buildset}
559
560 builds = {}
561 while True:
562 url = 'https://{hostname}/_ah/api/buildbucket/v1/search?{params}'.format(
tandrii221ab252016-10-06 08:12:04 -0700563 hostname=buildbucket_host,
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000564 params=urllib.urlencode(params))
qyearsleyeab3c042016-08-24 09:18:28 -0700565 content = _buildbucket_retry('fetching try jobs', http, url, 'GET')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000566 for build in content.get('builds', []):
567 builds[build['id']] = build
568 if 'next_cursor' in content:
569 params['start_cursor'] = content['next_cursor']
570 else:
571 break
572 return builds
573
574
qyearsleyeab3c042016-08-24 09:18:28 -0700575def print_try_jobs(options, builds):
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000576 """Prints nicely result of fetch_try_jobs."""
577 if not builds:
Quinten Yearsley0c62da92017-05-31 13:39:42 -0700578 print('No try jobs scheduled.')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000579 return
580
581 # Make a copy, because we'll be modifying builds dictionary.
582 builds = builds.copy()
583 builder_names_cache = {}
584
585 def get_builder(b):
586 try:
587 return builder_names_cache[b['id']]
588 except KeyError:
589 try:
590 parameters = json.loads(b['parameters_json'])
591 name = parameters['builder_name']
592 except (ValueError, KeyError) as error:
Quinten Yearsley0c62da92017-05-31 13:39:42 -0700593 print('WARNING: Failed to get builder name for build %s: %s' % (
vapiera7fbd5a2016-06-16 09:17:49 -0700594 b['id'], error))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000595 name = None
596 builder_names_cache[b['id']] = name
597 return name
598
599 def get_bucket(b):
600 bucket = b['bucket']
601 if bucket.startswith('master.'):
602 return bucket[len('master.'):]
603 return bucket
604
605 if options.print_master:
606 name_fmt = '%%-%ds %%-%ds' % (
607 max(len(str(get_bucket(b))) for b in builds.itervalues()),
608 max(len(str(get_builder(b))) for b in builds.itervalues()))
609 def get_name(b):
610 return name_fmt % (get_bucket(b), get_builder(b))
611 else:
612 name_fmt = '%%-%ds' % (
613 max(len(str(get_builder(b))) for b in builds.itervalues()))
614 def get_name(b):
615 return name_fmt % get_builder(b)
616
617 def sort_key(b):
618 return b['status'], b.get('result'), get_name(b), b.get('url')
619
620 def pop(title, f, color=None, **kwargs):
621 """Pop matching builds from `builds` dict and print them."""
622
tandrii@chromium.org6cf98c82016-03-15 11:56:00 +0000623 if not options.color or color is None:
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000624 colorize = str
625 else:
626 colorize = lambda x: '%s%s%s' % (color, x, Fore.RESET)
627
628 result = []
629 for b in builds.values():
630 if all(b.get(k) == v for k, v in kwargs.iteritems()):
631 builds.pop(b['id'])
632 result.append(b)
633 if result:
vapiera7fbd5a2016-06-16 09:17:49 -0700634 print(colorize(title))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000635 for b in sorted(result, key=sort_key):
vapiera7fbd5a2016-06-16 09:17:49 -0700636 print(' ', colorize('\t'.join(map(str, f(b)))))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000637
638 total = len(builds)
639 pop(status='COMPLETED', result='SUCCESS',
640 title='Successes:', color=Fore.GREEN,
641 f=lambda b: (get_name(b), b.get('url')))
642 pop(status='COMPLETED', result='FAILURE', failure_reason='INFRA_FAILURE',
643 title='Infra Failures:', color=Fore.MAGENTA,
644 f=lambda b: (get_name(b), b.get('url')))
645 pop(status='COMPLETED', result='FAILURE', failure_reason='BUILD_FAILURE',
646 title='Failures:', color=Fore.RED,
647 f=lambda b: (get_name(b), b.get('url')))
648 pop(status='COMPLETED', result='CANCELED',
649 title='Canceled:', color=Fore.MAGENTA,
650 f=lambda b: (get_name(b),))
651 pop(status='COMPLETED', result='FAILURE',
652 failure_reason='INVALID_BUILD_DEFINITION',
653 title='Wrong master/builder name:', color=Fore.MAGENTA,
654 f=lambda b: (get_name(b),))
655 pop(status='COMPLETED', result='FAILURE',
656 title='Other failures:',
657 f=lambda b: (get_name(b), b.get('failure_reason'), b.get('url')))
658 pop(status='COMPLETED',
659 title='Other finished:',
660 f=lambda b: (get_name(b), b.get('result'), b.get('url')))
661 pop(status='STARTED',
662 title='Started:', color=Fore.YELLOW,
663 f=lambda b: (get_name(b), b.get('url')))
664 pop(status='SCHEDULED',
665 title='Scheduled:',
666 f=lambda b: (get_name(b), 'id=%s' % b['id']))
667 # The last section is just in case buildbucket API changes OR there is a bug.
668 pop(title='Other:',
669 f=lambda b: (get_name(b), 'id=%s' % b['id']))
670 assert len(builds) == 0
qyearsleyeab3c042016-08-24 09:18:28 -0700671 print('Total: %d try jobs' % total)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000672
673
Aiden Bennerc08566e2018-10-03 17:52:42 +0000674def _ComputeDiffLineRanges(files, upstream_commit):
675 """Gets the changed line ranges for each file since upstream_commit.
676
677 Parses a git diff on provided files and returns a dict that maps a file name
678 to an ordered list of range tuples in the form (start_line, count).
679 Ranges are in the same format as a git diff.
680 """
681 # If files is empty then diff_output will be a full diff.
682 if len(files) == 0:
683 return {}
684
Aiden Benner6c18a1a2018-11-23 20:18:23 +0000685 # Take the git diff and find the line ranges where there are changes.
Aiden Bennerc08566e2018-10-03 17:52:42 +0000686 diff_cmd = BuildGitDiffCmd('-U0', upstream_commit, files, allow_prefix=True)
687 diff_output = RunGit(diff_cmd)
688
689 pattern = r'(?:^diff --git a/(?:.*) b/(.*))|(?:^@@.*\+(.*) @@)'
690 # 2 capture groups
691 # 0 == fname of diff file
692 # 1 == 'diff_start,diff_count' or 'diff_start'
693 # will match each of
694 # diff --git a/foo.foo b/foo.py
695 # @@ -12,2 +14,3 @@
696 # @@ -12,2 +17 @@
697 # running re.findall on the above string with pattern will give
698 # [('foo.py', ''), ('', '14,3'), ('', '17')]
699
700 curr_file = None
701 line_diffs = {}
702 for match in re.findall(pattern, diff_output, flags=re.MULTILINE):
703 if match[0] != '':
704 # Will match the second filename in diff --git a/a.py b/b.py.
705 curr_file = match[0]
706 line_diffs[curr_file] = []
707 else:
708 # Matches +14,3
709 if ',' in match[1]:
710 diff_start, diff_count = match[1].split(',')
711 else:
712 # Single line changes are of the form +12 instead of +12,1.
713 diff_start = match[1]
714 diff_count = 1
715
716 diff_start = int(diff_start)
717 diff_count = int(diff_count)
718
719 # If diff_count == 0 this is a removal we can ignore.
720 line_diffs[curr_file].append((diff_start, diff_count))
721
722 return line_diffs
723
724
Aiden Benner99b0ccb2018-11-20 19:53:31 +0000725def _FindYapfConfigFile(fpath, yapf_config_cache, top_dir=None):
Aiden Bennerc08566e2018-10-03 17:52:42 +0000726 """Checks if a yapf file is in any parent directory of fpath until top_dir.
727
Aiden Benner99b0ccb2018-11-20 19:53:31 +0000728 Recursively checks parent directories to find yapf file and if no yapf file
729 is found returns None. Uses yapf_config_cache as a cache for
730 previously found configs.
Aiden Bennerc08566e2018-10-03 17:52:42 +0000731 """
Aiden Benner99b0ccb2018-11-20 19:53:31 +0000732 fpath = os.path.abspath(fpath)
Aiden Bennerc08566e2018-10-03 17:52:42 +0000733 # Return result if we've already computed it.
734 if fpath in yapf_config_cache:
735 return yapf_config_cache[fpath]
736
Aiden Benner99b0ccb2018-11-20 19:53:31 +0000737 parent_dir = os.path.dirname(fpath)
738 if os.path.isfile(fpath):
739 ret = _FindYapfConfigFile(parent_dir, yapf_config_cache, top_dir)
Aiden Bennerc08566e2018-10-03 17:52:42 +0000740 else:
Aiden Benner99b0ccb2018-11-20 19:53:31 +0000741 # Otherwise fpath is a directory
742 yapf_file = os.path.join(fpath, YAPF_CONFIG_FILENAME)
743 if os.path.isfile(yapf_file):
744 ret = yapf_file
745 elif fpath == top_dir or parent_dir == fpath:
746 # If we're at the top level directory, or if we're at root
747 # there is no provided style.
748 ret = None
749 else:
750 # Otherwise recurse on the current directory.
751 ret = _FindYapfConfigFile(parent_dir, yapf_config_cache, top_dir)
Aiden Bennerc08566e2018-10-03 17:52:42 +0000752 yapf_config_cache[fpath] = ret
753 return ret
754
755
qyearsley53f48a12016-09-01 10:45:13 -0700756def write_try_results_json(output_file, builds):
757 """Writes a subset of the data from fetch_try_jobs to a file as JSON.
758
759 The input |builds| dict is assumed to be generated by Buildbucket.
760 Buildbucket documentation: http://goo.gl/G0s101
761 """
762
763 def convert_build_dict(build):
Quinten Yearsleya563d722017-12-11 16:36:54 -0800764 """Extracts some of the information from one build dict."""
765 parameters = json.loads(build.get('parameters_json', '{}')) or {}
qyearsley53f48a12016-09-01 10:45:13 -0700766 return {
767 'buildbucket_id': build.get('id'),
qyearsley53f48a12016-09-01 10:45:13 -0700768 'bucket': build.get('bucket'),
Quinten Yearsleya563d722017-12-11 16:36:54 -0800769 'builder_name': parameters.get('builder_name'),
770 'created_ts': build.get('created_ts'),
771 'experimental': build.get('experimental'),
qyearsley53f48a12016-09-01 10:45:13 -0700772 'failure_reason': build.get('failure_reason'),
Quinten Yearsleya563d722017-12-11 16:36:54 -0800773 'result': build.get('result'),
774 'status': build.get('status'),
775 'tags': build.get('tags'),
qyearsley53f48a12016-09-01 10:45:13 -0700776 'url': build.get('url'),
777 }
778
779 converted = []
780 for _, build in sorted(builds.items()):
Aiden Bennerc08566e2018-10-03 17:52:42 +0000781 converted.append(convert_build_dict(build))
qyearsley53f48a12016-09-01 10:45:13 -0700782 write_json(output_file, converted)
783
784
Aaron Gable13101a62018-02-09 13:20:41 -0800785def print_stats(args):
maruel@chromium.org49e3d802012-07-18 23:54:45 +0000786 """Prints statistics about the change to the user."""
787 # --no-ext-diff is broken in some versions of Git, so try to work around
788 # this by overriding the environment (but there is still a problem if the
789 # git config key "diff.external" is used).
thestig@chromium.org8b0553c2014-02-11 00:33:37 +0000790 env = GetNoGitPagerEnv()
maruel@chromium.org49e3d802012-07-18 23:54:45 +0000791 if 'GIT_EXTERNAL_DIFF' in env:
792 del env['GIT_EXTERNAL_DIFF']
iannucci@chromium.org79540052012-10-19 23:15:26 +0000793
szager@chromium.orgd057f9a2014-05-29 21:09:36 +0000794 try:
795 stdout = sys.stdout.fileno()
796 except AttributeError:
797 stdout = None
maruel@chromium.org49e3d802012-07-18 23:54:45 +0000798 return subprocess2.call(
Aaron Gable13101a62018-02-09 13:20:41 -0800799 ['git', 'diff', '--no-ext-diff', '--stat', '-l100000', '-C50'] + args,
szager@chromium.orgd057f9a2014-05-29 21:09:36 +0000800 stdout=stdout, env=env)
maruel@chromium.org49e3d802012-07-18 23:54:45 +0000801
802
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000803class BuildbucketResponseException(Exception):
804 pass
805
806
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000807class Settings(object):
808 def __init__(self):
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000809 self.cc = None
thestig@chromium.org7a54e812014-02-11 19:57:22 +0000810 self.root = None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000811 self.tree_status_url = None
812 self.viewvc_url = None
813 self.updated = False
ukai@chromium.orge8077812012-02-03 03:41:46 +0000814 self.is_gerrit = None
bauerb@chromium.org54b400c2016-01-14 10:08:25 +0000815 self.squash_gerrit_uploads = None
tandrii@chromium.org28253532016-04-14 13:46:56 +0000816 self.gerrit_skip_ensure_authenticated = None
jbroman@chromium.org615a2622013-05-03 13:20:14 +0000817 self.git_editor = None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000818
819 def LazyUpdateIfNeeded(self):
820 """Updates the settings from a codereview.settings file, if available."""
821 if not self.updated:
pgervais@chromium.org87884cc2014-01-03 22:23:41 +0000822 # The only value that actually changes the behavior is
823 # autoupdate = "false". Everything else means "true".
nick@chromium.org3ac1c4e2014-01-16 02:44:42 +0000824 autoupdate = RunGit(['config', 'rietveld.autoupdate'],
pgervais@chromium.org87884cc2014-01-03 22:23:41 +0000825 error_ok=True
826 ).strip().lower()
827
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000828 cr_settings_file = FindCodereviewSettingsFile()
pgervais@chromium.org87884cc2014-01-03 22:23:41 +0000829 if autoupdate != 'false' and cr_settings_file:
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000830 LoadCodereviewSettingsFromFile(cr_settings_file)
831 self.updated = True
832
thestig@chromium.org7a54e812014-02-11 19:57:22 +0000833 @staticmethod
834 def GetRelativeRoot():
835 return RunGit(['rev-parse', '--show-cdup']).strip()
thestig@chromium.org8b0553c2014-02-11 00:33:37 +0000836
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000837 def GetRoot(self):
thestig@chromium.org7a54e812014-02-11 19:57:22 +0000838 if self.root is None:
839 self.root = os.path.abspath(self.GetRelativeRoot())
840 return self.root
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000841
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000842 def GetTreeStatusUrl(self, error_ok=False):
843 if not self.tree_status_url:
844 error_message = ('You must configure your tree status URL by running '
845 '"git cl config".')
Edward Lemur61ea3072018-12-01 00:34:36 +0000846 self.tree_status_url = self._GetConfig(
847 'rietveld.tree-status-url', error_ok=error_ok,
848 error_message=error_message)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000849 return self.tree_status_url
850
851 def GetViewVCUrl(self):
852 if not self.viewvc_url:
Edward Lemur61ea3072018-12-01 00:34:36 +0000853 self.viewvc_url = self._GetConfig('rietveld.viewvc-url', error_ok=True)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000854 return self.viewvc_url
855
rmistry@google.com90752582014-01-14 21:04:50 +0000856 def GetBugPrefix(self):
Edward Lemur61ea3072018-12-01 00:34:36 +0000857 return self._GetConfig('rietveld.bug-prefix', error_ok=True)
rmistry@google.com78948ed2015-07-08 23:09:57 +0000858
rmistry@google.com5626a922015-02-26 14:03:30 +0000859 def GetRunPostUploadHook(self):
Edward Lemur61ea3072018-12-01 00:34:36 +0000860 run_post_upload_hook = self._GetConfig(
861 'rietveld.run-post-upload-hook', error_ok=True)
rmistry@google.com5626a922015-02-26 14:03:30 +0000862 return run_post_upload_hook == "True"
863
bauerb@chromium.orgae6df352011-04-06 17:40:39 +0000864 def GetDefaultCCList(self):
Edward Lemur61ea3072018-12-01 00:34:36 +0000865 return self._GetConfig('rietveld.cc', error_ok=True)
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000866
ukai@chromium.orge8077812012-02-03 03:41:46 +0000867 def GetIsGerrit(self):
Quinten Yearsley0c62da92017-05-31 13:39:42 -0700868 """Return true if this repo is associated with gerrit code review system."""
ukai@chromium.orge8077812012-02-03 03:41:46 +0000869 if self.is_gerrit is None:
Aaron Gable9b465272017-05-12 10:53:51 -0700870 self.is_gerrit = (
871 self._GetConfig('gerrit.host', error_ok=True).lower() == 'true')
ukai@chromium.orge8077812012-02-03 03:41:46 +0000872 return self.is_gerrit
873
bauerb@chromium.org54b400c2016-01-14 10:08:25 +0000874 def GetSquashGerritUploads(self):
875 """Return true if uploads to Gerrit should be squashed by default."""
876 if self.squash_gerrit_uploads is None:
tandriia60502f2016-06-20 02:01:53 -0700877 self.squash_gerrit_uploads = self.GetSquashGerritUploadsOverride()
878 if self.squash_gerrit_uploads is None:
879 # Default is squash now (http://crbug.com/611892#c23).
880 self.squash_gerrit_uploads = not (
881 RunGit(['config', '--bool', 'gerrit.squash-uploads'],
882 error_ok=True).strip() == 'false')
bauerb@chromium.org54b400c2016-01-14 10:08:25 +0000883 return self.squash_gerrit_uploads
884
tandriia60502f2016-06-20 02:01:53 -0700885 def GetSquashGerritUploadsOverride(self):
886 """Return True or False if codereview.settings should be overridden.
887
888 Returns None if no override has been defined.
889 """
890 # See also http://crbug.com/611892#c23
891 result = RunGit(['config', '--bool', 'gerrit.override-squash-uploads'],
892 error_ok=True).strip()
893 if result == 'true':
894 return True
895 if result == 'false':
896 return False
897 return None
898
tandrii@chromium.org28253532016-04-14 13:46:56 +0000899 def GetGerritSkipEnsureAuthenticated(self):
900 """Return True if EnsureAuthenticated should not be done for Gerrit
901 uploads."""
902 if self.gerrit_skip_ensure_authenticated is None:
903 self.gerrit_skip_ensure_authenticated = (
shinyak@chromium.org00dbccd2016-04-15 07:24:43 +0000904 RunGit(['config', '--bool', 'gerrit.skip-ensure-authenticated'],
tandrii@chromium.org28253532016-04-14 13:46:56 +0000905 error_ok=True).strip() == 'true')
906 return self.gerrit_skip_ensure_authenticated
907
jbroman@chromium.org615a2622013-05-03 13:20:14 +0000908 def GetGitEditor(self):
909 """Return the editor specified in the git config, or None if none is."""
910 if self.git_editor is None:
Raul Tambre5a525872019-02-12 19:08:08 +0000911 # Git requires single quotes for paths with spaces. We need to replace
912 # them with double quotes for Windows to treat such paths as a single
913 # path.
914 self.git_editor = self._GetConfig(
915 'core.editor', error_ok=True).replace('\'', '"')
jbroman@chromium.org615a2622013-05-03 13:20:14 +0000916 return self.git_editor or None
917
thestig@chromium.org44202a22014-03-11 19:22:18 +0000918 def GetLintRegex(self):
Edward Lemur61ea3072018-12-01 00:34:36 +0000919 return (self._GetConfig('rietveld.cpplint-regex', error_ok=True) or
thestig@chromium.org44202a22014-03-11 19:22:18 +0000920 DEFAULT_LINT_REGEX)
921
922 def GetLintIgnoreRegex(self):
Edward Lemur61ea3072018-12-01 00:34:36 +0000923 return (self._GetConfig('rietveld.cpplint-ignore-regex', error_ok=True) or
thestig@chromium.org44202a22014-03-11 19:22:18 +0000924 DEFAULT_LINT_IGNORE_REGEX)
925
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000926 def _GetConfig(self, param, **kwargs):
927 self.LazyUpdateIfNeeded()
928 return RunGit(['config', param], **kwargs).strip()
929
930
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +0100931@contextlib.contextmanager
932def _get_gerrit_project_config_file(remote_url):
933 """Context manager to fetch and store Gerrit's project.config from
934 refs/meta/config branch and store it in temp file.
935
936 Provides a temporary filename or None if there was error.
937 """
938 error, _ = RunGitWithCode([
939 'fetch', remote_url,
940 '+refs/meta/config:refs/git_cl/meta/config'])
941 if error:
942 # Ref doesn't exist or isn't accessible to current user.
Quinten Yearsley0c62da92017-05-31 13:39:42 -0700943 print('WARNING: Failed to fetch project config for %s: %s' %
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +0100944 (remote_url, error))
945 yield None
946 return
947
948 error, project_config_data = RunGitWithCode(
949 ['show', 'refs/git_cl/meta/config:project.config'])
950 if error:
951 print('WARNING: project.config file not found')
952 yield None
953 return
954
955 with gclient_utils.temporary_directory() as tempdir:
956 project_config_file = os.path.join(tempdir, 'project.config')
957 gclient_utils.FileWrite(project_config_file, project_config_data)
958 yield project_config_file
959
960
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000961def ShortBranchName(branch):
962 """Convert a name like 'refs/heads/foo' to just 'foo'."""
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +0000963 return branch.replace('refs/heads/', '', 1)
964
965
966def GetCurrentBranchRef():
967 """Returns branch ref (e.g., refs/heads/master) or None."""
968 return RunGit(['symbolic-ref', 'HEAD'],
969 stderr=subprocess2.VOID, error_ok=True).strip() or None
970
971
972def GetCurrentBranch():
973 """Returns current branch or None.
974
975 For refs/heads/* branches, returns just last part. For others, full ref.
976 """
977 branchref = GetCurrentBranchRef()
978 if branchref:
979 return ShortBranchName(branchref)
980 return None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000981
982
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +0000983class _CQState(object):
984 """Enum for states of CL with respect to Commit Queue."""
985 NONE = 'none'
986 DRY_RUN = 'dry_run'
987 COMMIT = 'commit'
988
989 ALL_STATES = [NONE, DRY_RUN, COMMIT]
990
991
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000992class _ParsedIssueNumberArgument(object):
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200993 def __init__(self, issue=None, patchset=None, hostname=None, codereview=None):
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000994 self.issue = issue
995 self.patchset = patchset
996 self.hostname = hostname
Andrii Shyshkalovf5569d22018-10-15 03:35:23 +0000997 assert codereview in (None, 'gerrit', 'rietveld')
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200998 self.codereview = codereview
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000999
1000 @property
1001 def valid(self):
1002 return self.issue is not None
1003
1004
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001005def ParseIssueNumberArgument(arg, codereview=None):
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001006 """Parses the issue argument and returns _ParsedIssueNumberArgument."""
1007 fail_result = _ParsedIssueNumberArgument()
1008
1009 if arg.isdigit():
Aaron Gableaee6c852017-06-26 12:49:01 -07001010 return _ParsedIssueNumberArgument(issue=int(arg), codereview=codereview)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001011 if not arg.startswith('http'):
1012 return fail_result
Aaron Gableaee6c852017-06-26 12:49:01 -07001013
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001014 url = gclient_utils.UpgradeToHttps(arg)
1015 try:
1016 parsed_url = urlparse.urlparse(url)
1017 except ValueError:
1018 return fail_result
Andrii Shyshkalov28d840e2017-04-10 15:45:09 +02001019
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001020 if codereview is not None:
1021 parsed = _CODEREVIEW_IMPLEMENTATIONS[codereview].ParseIssueURL(parsed_url)
1022 return parsed or fail_result
1023
Andrii Shyshkalov0a264d82018-11-21 00:36:16 +00001024 return _GerritChangelistImpl.ParseIssueURL(parsed_url) or fail_result
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001025
1026
Andrii Shyshkalovb07575f2018-10-16 06:16:21 +00001027def _create_description_from_log(args):
1028 """Pulls out the commit log to use as a base for the CL description."""
1029 log_args = []
1030 if len(args) == 1 and not args[0].endswith('.'):
1031 log_args = [args[0] + '..']
1032 elif len(args) == 1 and args[0].endswith('...'):
1033 log_args = [args[0][:-1]]
1034 elif len(args) == 2:
1035 log_args = [args[0] + '..' + args[1]]
1036 else:
1037 log_args = args[:] # Hope for the best!
1038 return RunGit(['log', '--pretty=format:%s\n\n%b'] + log_args)
1039
1040
Aaron Gablea45ee112016-11-22 15:14:38 -08001041class GerritChangeNotExists(Exception):
tandriic2405f52016-10-10 08:13:15 -07001042 def __init__(self, issue, url):
1043 self.issue = issue
1044 self.url = url
Aaron Gablea45ee112016-11-22 15:14:38 -08001045 super(GerritChangeNotExists, self).__init__()
tandriic2405f52016-10-10 08:13:15 -07001046
1047 def __str__(self):
Aaron Gablea45ee112016-11-22 15:14:38 -08001048 return 'change %s at %s does not exist or you have no access to it' % (
tandriic2405f52016-10-10 08:13:15 -07001049 self.issue, self.url)
1050
1051
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01001052_CommentSummary = collections.namedtuple(
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001053 '_CommentSummary', ['date', 'message', 'sender', 'autogenerated',
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01001054 # TODO(tandrii): these two aren't known in Gerrit.
1055 'approval', 'disapproval'])
1056
1057
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001058class Changelist(object):
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001059 """Changelist works with one changelist in local branch.
1060
1061 Supports two codereview backends: Rietveld or Gerrit, selected at object
1062 creation.
1063
tandrii@chromium.org8930b3d2016-04-13 14:47:02 +00001064 Notes:
1065 * Not safe for concurrent multi-{thread,process} use.
1066 * Caches values from current branch. Therefore, re-use after branch change
tandrii5d48c322016-08-18 16:19:37 -07001067 with great care.
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001068 """
1069
1070 def __init__(self, branchref=None, issue=None, codereview=None, **kwargs):
1071 """Create a new ChangeList instance.
1072
1073 If issue is given, the codereview must be given too.
1074
1075 If `codereview` is given, it must be 'rietveld' or 'gerrit'.
1076 Otherwise, it's decided based on current configuration of the local branch,
1077 with default being 'rietveld' for backwards compatibility.
1078 See _load_codereview_impl for more details.
1079
1080 **kwargs will be passed directly to codereview implementation.
1081 """
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001082 # Poke settings so we get the "configure your server" message if necessary.
maruel@chromium.org379d07a2011-11-30 14:58:10 +00001083 global settings
1084 if not settings:
1085 # Happens when git_cl.py is used as a utility library.
1086 settings = Settings()
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001087
1088 if issue:
1089 assert codereview, 'codereview must be known, if issue is known'
1090
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001091 self.branchref = branchref
1092 if self.branchref:
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00001093 assert branchref.startswith('refs/heads/')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001094 self.branch = ShortBranchName(self.branchref)
1095 else:
1096 self.branch = None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001097 self.upstream_branch = None
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001098 self.lookedup_issue = False
1099 self.issue = issue or None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001100 self.has_description = False
1101 self.description = None
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001102 self.lookedup_patchset = False
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001103 self.patchset = None
bauerb@chromium.orgae6df352011-04-06 17:40:39 +00001104 self.cc = None
Daniel Cheng7227d212017-11-17 08:12:37 -08001105 self.more_cc = []
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00001106 self._remote = None
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00001107 self._cached_remote_url = (False, None) # (is_cached, value)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00001108
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001109 self._codereview_impl = None
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00001110 self._codereview = None
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001111 self._load_codereview_impl(codereview, **kwargs)
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00001112 assert self._codereview_impl
1113 assert self._codereview in _CODEREVIEW_IMPLEMENTATIONS
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001114
1115 def _load_codereview_impl(self, codereview=None, **kwargs):
1116 if codereview:
Joe Masond87b0962018-12-03 21:04:46 +00001117 assert codereview in _CODEREVIEW_IMPLEMENTATIONS, (
1118 'codereview {} not in {}'.format(codereview,
1119 _CODEREVIEW_IMPLEMENTATIONS))
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00001120 cls = _CODEREVIEW_IMPLEMENTATIONS[codereview]
1121 self._codereview = codereview
1122 self._codereview_impl = cls(self, **kwargs)
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001123 return
1124
1125 # Automatic selection based on issue number set for a current branch.
1126 # Rietveld takes precedence over Gerrit.
1127 assert not self.issue
1128 # Whether we find issue or not, we are doing the lookup.
1129 self.lookedup_issue = True
tandrii5d48c322016-08-18 16:19:37 -07001130 if self.GetBranch():
1131 for codereview, cls in _CODEREVIEW_IMPLEMENTATIONS.iteritems():
1132 issue = _git_get_branch_config_value(
1133 cls.IssueConfigKey(), value_type=int, branch=self.GetBranch())
1134 if issue:
1135 self._codereview = codereview
1136 self._codereview_impl = cls(self, **kwargs)
1137 self.issue = int(issue)
1138 return
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001139
Bryce Thomascfc97122018-12-13 20:21:47 +00001140 # No issue is set for this branch, so default to gerrit.
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001141 return self._load_codereview_impl(
Bryce Thomascfc97122018-12-13 20:21:47 +00001142 codereview='gerrit',
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001143 **kwargs)
1144
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00001145 def IsGerrit(self):
1146 return self._codereview == 'gerrit'
bauerb@chromium.orgae6df352011-04-06 17:40:39 +00001147
1148 def GetCCList(self):
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001149 """Returns the users cc'd on this CL.
bauerb@chromium.orgae6df352011-04-06 17:40:39 +00001150
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001151 The return value is a string suitable for passing to git cl with the --cc
1152 flag.
bauerb@chromium.orgae6df352011-04-06 17:40:39 +00001153 """
1154 if self.cc is None:
tyoshino@chromium.org99918ab2013-09-30 06:17:28 +00001155 base_cc = settings.GetDefaultCCList()
Daniel Cheng7227d212017-11-17 08:12:37 -08001156 more_cc = ','.join(self.more_cc)
bauerb@chromium.orgae6df352011-04-06 17:40:39 +00001157 self.cc = ','.join(filter(None, (base_cc, more_cc))) or ''
1158 return self.cc
1159
tyoshino@chromium.org99918ab2013-09-30 06:17:28 +00001160 def GetCCListWithoutDefault(self):
1161 """Return the users cc'd on this CL excluding default ones."""
1162 if self.cc is None:
Daniel Cheng7227d212017-11-17 08:12:37 -08001163 self.cc = ','.join(self.more_cc)
tyoshino@chromium.org99918ab2013-09-30 06:17:28 +00001164 return self.cc
1165
Daniel Cheng7227d212017-11-17 08:12:37 -08001166 def ExtendCC(self, more_cc):
1167 """Extends the list of users to cc on this CL based on the changed files."""
1168 self.more_cc.extend(more_cc)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001169
1170 def GetBranch(self):
1171 """Returns the short branch name, e.g. 'master'."""
1172 if not self.branch:
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001173 branchref = GetCurrentBranchRef()
szager@chromium.orgd62c61f2014-10-20 22:33:21 +00001174 if not branchref:
1175 return None
1176 self.branchref = branchref
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001177 self.branch = ShortBranchName(self.branchref)
1178 return self.branch
1179
1180 def GetBranchRef(self):
1181 """Returns the full branch name, e.g. 'refs/heads/master'."""
1182 self.GetBranch() # Poke the lazy loader.
1183 return self.branchref
1184
tandrii@chromium.org534f67a2016-04-07 18:47:05 +00001185 def ClearBranch(self):
1186 """Clears cached branch data of this object."""
1187 self.branch = self.branchref = None
1188
tandrii5d48c322016-08-18 16:19:37 -07001189 def _GitGetBranchConfigValue(self, key, default=None, **kwargs):
1190 assert 'branch' not in kwargs, 'this CL branch is used automatically'
1191 kwargs['branch'] = self.GetBranch()
1192 return _git_get_branch_config_value(key, default, **kwargs)
1193
1194 def _GitSetBranchConfigValue(self, key, value, **kwargs):
1195 assert 'branch' not in kwargs, 'this CL branch is used automatically'
1196 assert self.GetBranch(), (
1197 'this CL must have an associated branch to %sset %s%s' %
1198 ('un' if value is None else '',
1199 key,
1200 '' if value is None else ' to %r' % value))
1201 kwargs['branch'] = self.GetBranch()
1202 return _git_set_branch_config_value(key, value, **kwargs)
1203
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001204 @staticmethod
1205 def FetchUpstreamTuple(branch):
pgervais@chromium.orgd6617f32013-11-19 00:34:54 +00001206 """Returns a tuple containing remote and remote ref,
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001207 e.g. 'origin', 'refs/heads/master'
1208 """
1209 remote = '.'
tandrii5d48c322016-08-18 16:19:37 -07001210 upstream_branch = _git_get_branch_config_value('merge', branch=branch)
1211
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001212 if upstream_branch:
tandrii5d48c322016-08-18 16:19:37 -07001213 remote = _git_get_branch_config_value('remote', branch=branch)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001214 else:
bauerb@chromium.orgade368c2011-03-01 08:57:50 +00001215 upstream_branch = RunGit(['config', 'rietveld.upstream-branch'],
1216 error_ok=True).strip()
1217 if upstream_branch:
1218 remote = RunGit(['config', 'rietveld.upstream-remote']).strip()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001219 else:
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08001220 # Else, try to guess the origin remote.
1221 remote_branches = RunGit(['branch', '-r']).split()
1222 if 'origin/master' in remote_branches:
1223 # Fall back on origin/master if it exits.
1224 remote = 'origin'
1225 upstream_branch = 'refs/heads/master'
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001226 else:
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08001227 DieWithError(
1228 'Unable to determine default branch to diff against.\n'
1229 'Either pass complete "git diff"-style arguments, like\n'
1230 ' git cl upload origin/master\n'
1231 'or verify this branch is set up to track another \n'
1232 '(via the --track argument to "git checkout -b ...").')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001233
1234 return remote, upstream_branch
1235
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00001236 def GetCommonAncestorWithUpstream(self):
pgervais@chromium.org8ba38ff2015-06-11 21:41:25 +00001237 upstream_branch = self.GetUpstreamBranch()
1238 if not BranchExists(upstream_branch):
1239 DieWithError('The upstream for the current branch (%s) does not exist '
1240 'anymore.\nPlease fix it and try again.' % self.GetBranch())
iannucci@chromium.org9e849272014-04-04 00:31:55 +00001241 return git_common.get_or_create_merge_base(self.GetBranch(),
pgervais@chromium.org8ba38ff2015-06-11 21:41:25 +00001242 upstream_branch)
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00001243
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001244 def GetUpstreamBranch(self):
1245 if self.upstream_branch is None:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001246 remote, upstream_branch = self.FetchUpstreamTuple(self.GetBranch())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001247 if remote is not '.':
mmoss@chromium.orge7585452014-08-24 01:41:11 +00001248 upstream_branch = upstream_branch.replace('refs/heads/',
1249 'refs/remotes/%s/' % remote)
1250 upstream_branch = upstream_branch.replace('refs/branch-heads/',
1251 'refs/remotes/branch-heads/')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001252 self.upstream_branch = upstream_branch
1253 return self.upstream_branch
1254
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001255 def GetRemoteBranch(self):
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001256 if not self._remote:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001257 remote, branch = None, self.GetBranch()
1258 seen_branches = set()
1259 while branch not in seen_branches:
1260 seen_branches.add(branch)
1261 remote, branch = self.FetchUpstreamTuple(branch)
1262 branch = ShortBranchName(branch)
1263 if remote != '.' or branch.startswith('refs/remotes'):
1264 break
1265 else:
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001266 remotes = RunGit(['remote'], error_ok=True).split()
1267 if len(remotes) == 1:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001268 remote, = remotes
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001269 elif 'origin' in remotes:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001270 remote = 'origin'
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08001271 logging.warn('Could not determine which remote this change is '
1272 'associated with, so defaulting to "%s".' % self._remote)
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001273 else:
1274 logging.warn('Could not determine which remote this change is '
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08001275 'associated with.')
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001276 branch = 'HEAD'
1277 if branch.startswith('refs/remotes'):
1278 self._remote = (remote, branch)
mmoss@chromium.orge7585452014-08-24 01:41:11 +00001279 elif branch.startswith('refs/branch-heads/'):
1280 self._remote = (remote, branch.replace('refs/', 'refs/remotes/'))
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001281 else:
1282 self._remote = (remote, 'refs/remotes/%s/%s' % (remote, branch))
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001283 return self._remote
1284
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001285 def GitSanityChecks(self, upstream_git_obj):
1286 """Checks git repo status and ensures diff is from local commits."""
1287
sbc@chromium.org79706062015-01-14 21:18:12 +00001288 if upstream_git_obj is None:
1289 if self.GetBranch() is None:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001290 print('ERROR: Unable to determine current branch (detached HEAD?)',
vapiera7fbd5a2016-06-16 09:17:49 -07001291 file=sys.stderr)
sbc@chromium.org79706062015-01-14 21:18:12 +00001292 else:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001293 print('ERROR: No upstream branch.', file=sys.stderr)
sbc@chromium.org79706062015-01-14 21:18:12 +00001294 return False
1295
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001296 # Verify the commit we're diffing against is in our current branch.
1297 upstream_sha = RunGit(['rev-parse', '--verify', upstream_git_obj]).strip()
1298 common_ancestor = RunGit(['merge-base', upstream_sha, 'HEAD']).strip()
1299 if upstream_sha != common_ancestor:
vapiera7fbd5a2016-06-16 09:17:49 -07001300 print('ERROR: %s is not in the current branch. You may need to rebase '
1301 'your tracking branch' % upstream_sha, file=sys.stderr)
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001302 return False
1303
1304 # List the commits inside the diff, and verify they are all local.
1305 commits_in_diff = RunGit(
1306 ['rev-list', '^%s' % upstream_sha, 'HEAD']).splitlines()
1307 code, remote_branch = RunGitWithCode(['config', 'gitcl.remotebranch'])
1308 remote_branch = remote_branch.strip()
1309 if code != 0:
1310 _, remote_branch = self.GetRemoteBranch()
1311
1312 commits_in_remote = RunGit(
1313 ['rev-list', '^%s' % upstream_sha, remote_branch]).splitlines()
1314
1315 common_commits = set(commits_in_diff) & set(commits_in_remote)
1316 if common_commits:
vapiera7fbd5a2016-06-16 09:17:49 -07001317 print('ERROR: Your diff contains %d commits already in %s.\n'
1318 'Run "git log --oneline %s..HEAD" to get a list of commits in '
1319 'the diff. If you are using a custom git flow, you can override'
1320 ' the reference used for this check with "git config '
1321 'gitcl.remotebranch <git-ref>".' % (
1322 len(common_commits), remote_branch, upstream_git_obj),
1323 file=sys.stderr)
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001324 return False
1325 return True
1326
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00001327 def GetGitBaseUrlFromConfig(self):
sheyang@chromium.orga656e702014-05-15 20:43:05 +00001328 """Return the configured base URL from branch.<branchname>.baseurl.
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00001329
1330 Returns None if it is not set.
1331 """
tandrii5d48c322016-08-18 16:19:37 -07001332 return self._GitGetBranchConfigValue('base-url')
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001333
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001334 def GetRemoteUrl(self):
1335 """Return the configured remote URL, e.g. 'git://example.org/foo.git/'.
1336
1337 Returns None if there is no remote.
1338 """
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00001339 is_cached, value = self._cached_remote_url
1340 if is_cached:
1341 return value
1342
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001343 remote, _ = self.GetRemoteBranch()
dyen@chromium.org2a13d4f2014-06-13 00:06:37 +00001344 url = RunGit(['config', 'remote.%s.url' % remote], error_ok=True).strip()
1345
Edward Lemur298f2cf2019-02-22 21:40:39 +00001346 # Check if the remote url can be parsed as an URL.
1347 host = urlparse.urlparse(url).netloc
1348 if host:
1349 self._cached_remote_url = (True, url)
1350 return url
1351
1352 # If it cannot be parsed as an url, assume it is a local directory, probably
1353 # a git cache.
1354 logging.warning('"%s" doesn\'t appear to point to a git host. '
1355 'Interpreting it as a local directory.', url)
1356 if not os.path.isdir(url):
1357 logging.error(
1358 'Remote "%s" for branch "%s" points to "%s", but it doesn\'t exist.',
1359 remote, url, self.GetBranch())
1360 return None
1361
1362 cache_path = url
1363 url = RunGit(['config', 'remote.%s.url' % remote],
1364 error_ok=True,
1365 cwd=url).strip()
1366
1367 host = urlparse.urlparse(url).netloc
1368 if not host:
1369 logging.error(
1370 'Remote "%(remote)s" for branch "%(branch)s" points to '
1371 '"%(cache_path)s", but it is misconfigured.\n'
1372 '"%(cache_path)s" must be a git repo and must have a remote named '
1373 '"%(remote)s" pointing to the git host.', {
1374 'remote': remote,
1375 'cache_path': cache_path,
1376 'branch': self.GetBranch()})
1377 return None
1378
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00001379 self._cached_remote_url = (True, url)
dyen@chromium.org2a13d4f2014-06-13 00:06:37 +00001380 return url
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001381
tandrii@chromium.org87985d22016-03-24 17:33:33 +00001382 def GetIssue(self):
maruel@chromium.org52424302012-08-29 15:14:30 +00001383 """Returns the issue number as a int or None if not set."""
tandrii@chromium.org87985d22016-03-24 17:33:33 +00001384 if self.issue is None and not self.lookedup_issue:
tandrii5d48c322016-08-18 16:19:37 -07001385 self.issue = self._GitGetBranchConfigValue(
1386 self._codereview_impl.IssueConfigKey(), value_type=int)
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001387 self.lookedup_issue = True
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001388 return self.issue
1389
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001390 def GetIssueURL(self):
1391 """Get the URL for a particular issue."""
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001392 issue = self.GetIssue()
1393 if not issue:
dbeam@chromium.org015fd3d2013-06-18 19:02:50 +00001394 return None
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001395 return '%s/%s' % (self._codereview_impl.GetCodereviewServer(), issue)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001396
Andrii Shyshkalov31863012017-02-08 11:35:12 +01001397 def GetDescription(self, pretty=False, force=False):
1398 if not self.has_description or force:
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001399 if self.GetIssue():
Kenneth Russell61e2ed42017-02-15 11:47:13 -08001400 self.description = self._codereview_impl.FetchDescription(force=force)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001401 self.has_description = True
1402 if pretty:
Asanka Herath7c61dcb2016-12-14 13:01:58 -05001403 # Set width to 72 columns + 2 space indent.
1404 wrapper = textwrap.TextWrapper(width=74, replace_whitespace=True)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001405 wrapper.initial_indent = wrapper.subsequent_indent = ' '
Asanka Herath7c61dcb2016-12-14 13:01:58 -05001406 lines = self.description.splitlines()
1407 return '\n'.join([wrapper.fill(line) for line in lines])
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001408 return self.description
1409
Robert Iannucci09f1f3d2017-03-28 16:54:32 -07001410 def GetDescriptionFooters(self):
1411 """Returns (non_footer_lines, footers) for the commit message.
1412
1413 Returns:
1414 non_footer_lines (list(str)) - Simple list of description lines without
1415 any footer. The lines do not contain newlines, nor does the list contain
1416 the empty line between the message and the footers.
1417 footers (list(tuple(KEY, VALUE))) - List of parsed footers, e.g.
1418 [("Change-Id", "Ideadbeef...."), ...]
1419 """
1420 raw_description = self.GetDescription()
1421 msg_lines, _, footers = git_footers.split_footers(raw_description)
1422 if footers:
1423 msg_lines = msg_lines[:len(msg_lines)-1]
1424 return msg_lines, footers
1425
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001426 def GetPatchset(self):
maruel@chromium.org52424302012-08-29 15:14:30 +00001427 """Returns the patchset number as a int or None if not set."""
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001428 if self.patchset is None and not self.lookedup_patchset:
tandrii5d48c322016-08-18 16:19:37 -07001429 self.patchset = self._GitGetBranchConfigValue(
1430 self._codereview_impl.PatchsetConfigKey(), value_type=int)
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001431 self.lookedup_patchset = True
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001432 return self.patchset
1433
1434 def SetPatchset(self, patchset):
tandrii5d48c322016-08-18 16:19:37 -07001435 """Set this branch's patchset. If patchset=0, clears the patchset."""
1436 assert self.GetBranch()
1437 if not patchset:
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001438 self.patchset = None
tandrii5d48c322016-08-18 16:19:37 -07001439 else:
1440 self.patchset = int(patchset)
1441 self._GitSetBranchConfigValue(
1442 self._codereview_impl.PatchsetConfigKey(), self.patchset)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001443
tandrii@chromium.orga342c922016-03-16 07:08:25 +00001444 def SetIssue(self, issue=None):
tandrii5d48c322016-08-18 16:19:37 -07001445 """Set this branch's issue. If issue isn't given, clears the issue."""
1446 assert self.GetBranch()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001447 if issue:
tandrii5d48c322016-08-18 16:19:37 -07001448 issue = int(issue)
1449 self._GitSetBranchConfigValue(
1450 self._codereview_impl.IssueConfigKey(), issue)
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001451 self.issue = issue
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001452 codereview_server = self._codereview_impl.GetCodereviewServer()
1453 if codereview_server:
tandrii5d48c322016-08-18 16:19:37 -07001454 self._GitSetBranchConfigValue(
1455 self._codereview_impl.CodereviewServerConfigKey(),
1456 codereview_server)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001457 else:
tandrii5d48c322016-08-18 16:19:37 -07001458 # Reset all of these just to be clean.
1459 reset_suffixes = [
1460 'last-upload-hash',
1461 self._codereview_impl.IssueConfigKey(),
1462 self._codereview_impl.PatchsetConfigKey(),
1463 self._codereview_impl.CodereviewServerConfigKey(),
1464 ] + self._PostUnsetIssueProperties()
1465 for prop in reset_suffixes:
1466 self._GitSetBranchConfigValue(prop, None, error_ok=True)
Aaron Gableca01e2c2017-07-19 11:16:02 -07001467 msg = RunGit(['log', '-1', '--format=%B']).strip()
1468 if msg and git_footers.get_footer_change_id(msg):
1469 print('WARNING: The change patched into this branch has a Change-Id. '
1470 'Removing it.')
1471 RunGit(['commit', '--amend', '-m',
1472 git_footers.remove_footer(msg, 'Change-Id')])
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001473 self.issue = None
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00001474 self.patchset = None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001475
dnjba1b0f32016-09-02 12:37:42 -07001476 def GetChange(self, upstream_branch, author, local_description=False):
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001477 if not self.GitSanityChecks(upstream_branch):
1478 DieWithError('\nGit sanity check failure')
1479
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00001480 root = settings.GetRelativeRoot()
bratell@opera.comf267b0e2013-05-02 09:11:43 +00001481 if not root:
1482 root = '.'
bauerb@chromium.org512f1ef2011-04-20 15:17:57 +00001483 absroot = os.path.abspath(root)
bauerb@chromium.org6fb99c62011-04-18 15:57:28 +00001484
1485 # We use the sha1 of HEAD as a name of this change.
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00001486 name = RunGitWithCode(['rev-parse', 'HEAD'])[1].strip()
bauerb@chromium.org512f1ef2011-04-20 15:17:57 +00001487 # Need to pass a relative path for msysgit.
maruel@chromium.org2b38e9c2011-10-19 00:04:35 +00001488 try:
maruel@chromium.org80a9ef12011-12-13 20:44:10 +00001489 files = scm.GIT.CaptureStatus([root], '.', upstream_branch)
maruel@chromium.org2b38e9c2011-10-19 00:04:35 +00001490 except subprocess2.CalledProcessError:
1491 DieWithError(
pgervais@chromium.orgd6617f32013-11-19 00:34:54 +00001492 ('\nFailed to diff against upstream branch %s\n\n'
maruel@chromium.org2b38e9c2011-10-19 00:04:35 +00001493 'This branch probably doesn\'t exist anymore. To reset the\n'
1494 'tracking branch, please run\n'
stip7a3dd352016-09-22 17:32:28 -07001495 ' git branch --set-upstream-to origin/master %s\n'
1496 'or replace origin/master with the relevant branch') %
maruel@chromium.org2b38e9c2011-10-19 00:04:35 +00001497 (upstream_branch, self.GetBranch()))
bauerb@chromium.org6fb99c62011-04-18 15:57:28 +00001498
maruel@chromium.org52424302012-08-29 15:14:30 +00001499 issue = self.GetIssue()
1500 patchset = self.GetPatchset()
dnjba1b0f32016-09-02 12:37:42 -07001501 if issue and not local_description:
bauerb@chromium.org6fb99c62011-04-18 15:57:28 +00001502 description = self.GetDescription()
1503 else:
1504 # If the change was never uploaded, use the log messages of all commits
1505 # up to the branch point, as git cl upload will prefill the description
1506 # with these log messages.
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00001507 args = ['log', '--pretty=format:%s%n%n%b', '%s...' % (upstream_branch)]
1508 description = RunGitWithCode(args)[1].strip()
maruel@chromium.org03b3bdc2011-06-14 13:04:12 +00001509
1510 if not author:
maruel@chromium.org13f623c2011-07-22 16:02:23 +00001511 author = RunGit(['config', 'user.email']).strip() or None
asvitkine@chromium.org15169952011-09-27 14:30:53 +00001512 return presubmit_support.GitChange(
bauerb@chromium.org6fb99c62011-04-18 15:57:28 +00001513 name,
1514 description,
1515 absroot,
1516 files,
1517 issue,
1518 patchset,
agable@chromium.orgea84ef12014-04-30 19:55:12 +00001519 author,
1520 upstream=upstream_branch)
bauerb@chromium.org6fb99c62011-04-18 15:57:28 +00001521
dsansomee2d6fd92016-09-08 00:10:47 -07001522 def UpdateDescription(self, description, force=False):
Andrii Shyshkalov83051152017-02-07 23:47:29 +01001523 self._codereview_impl.UpdateDescriptionRemote(description, force=force)
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001524 self.description = description
Andrii Shyshkalov83051152017-02-07 23:47:29 +01001525 self.has_description = True
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001526
Robert Iannucci09f1f3d2017-03-28 16:54:32 -07001527 def UpdateDescriptionFooters(self, description_lines, footers, force=False):
1528 """Sets the description for this CL remotely.
1529
1530 You can get description_lines and footers with GetDescriptionFooters.
1531
1532 Args:
1533 description_lines (list(str)) - List of CL description lines without
1534 newline characters.
1535 footers (list(tuple(KEY, VALUE))) - List of footers, as returned by
1536 GetDescriptionFooters. Key must conform to the git footers format (i.e.
1537 `List-Of-Tokens`). It will be case-normalized so that each token is
1538 title-cased.
1539 """
1540 new_description = '\n'.join(description_lines)
1541 if footers:
1542 new_description += '\n'
1543 for k, v in footers:
1544 foot = '%s: %s' % (git_footers.normalize_name(k), v)
1545 if not git_footers.FOOTER_PATTERN.match(foot):
1546 raise ValueError('Invalid footer %r' % foot)
1547 new_description += foot + '\n'
1548 self.UpdateDescription(new_description, force)
1549
Edward Lesmes8e282792018-04-03 18:50:29 -04001550 def RunHook(self, committing, may_prompt, verbose, change, parallel):
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001551 """Calls sys.exit() if the hook fails; returns a HookResults otherwise."""
1552 try:
1553 return presubmit_support.DoPresubmitChecks(change, committing,
1554 verbose=verbose, output_stream=sys.stdout, input_stream=sys.stdin,
1555 default_presubmit=None, may_prompt=may_prompt,
Edward Lesmes8e282792018-04-03 18:50:29 -04001556 gerrit_obj=self._codereview_impl.GetGerritObjForPresubmit(),
1557 parallel=parallel)
vapierfd77ac72016-06-16 08:33:57 -07001558 except presubmit_support.PresubmitFailure as e:
Aaron Gable5d5f22c2018-02-02 09:12:41 -08001559 DieWithError('%s\nMaybe your depot_tools is out of date?' % e)
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001560
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001561 def CMDPatchIssue(self, issue_arg, reject, nocommit, directory):
1562 """Fetches and applies the issue patch from codereview to local branch."""
tandrii@chromium.orgef7c68c2016-04-07 09:39:39 +00001563 if isinstance(issue_arg, (int, long)) or issue_arg.isdigit():
1564 parsed_issue_arg = _ParsedIssueNumberArgument(int(issue_arg))
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001565 else:
1566 # Assume url.
1567 parsed_issue_arg = self._codereview_impl.ParseIssueURL(
1568 urlparse.urlparse(issue_arg))
1569 if not parsed_issue_arg or not parsed_issue_arg.valid:
1570 DieWithError('Failed to parse issue argument "%s". '
1571 'Must be an issue number or a valid URL.' % issue_arg)
1572 return self._codereview_impl.CMDPatchWithParsedIssue(
Aaron Gable62619a32017-06-16 08:22:09 -07001573 parsed_issue_arg, reject, nocommit, directory, False)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001574
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001575 def CMDUpload(self, options, git_diff_args, orig_args):
1576 """Uploads a change to codereview."""
Andrii Shyshkalov9f274432018-10-15 16:40:23 +00001577 assert self.IsGerrit()
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001578 custom_cl_base = None
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001579 if git_diff_args:
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001580 custom_cl_base = base_branch = git_diff_args[0]
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001581 else:
1582 if self.GetBranch() is None:
1583 DieWithError('Can\'t upload from detached HEAD state. Get on a branch!')
1584
1585 # Default to diffing against common ancestor of upstream branch
1586 base_branch = self.GetCommonAncestorWithUpstream()
1587 git_diff_args = [base_branch, 'HEAD']
1588
Aaron Gablec4c40d12017-05-22 11:49:53 -07001589
Andrii Shyshkalov3e631422017-02-16 17:46:44 +01001590 # Fast best-effort checks to abort before running potentially
1591 # expensive hooks if uploading is likely to fail anyway. Passing these
1592 # checks does not guarantee that uploading will not fail.
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001593 self._codereview_impl.EnsureAuthenticated(force=options.force)
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001594 self._codereview_impl.EnsureCanUploadPatchset(force=options.force)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001595
1596 # Apply watchlists on upload.
1597 change = self.GetChange(base_branch, None)
1598 watchlist = watchlists.Watchlists(change.RepositoryRoot())
1599 files = [f.LocalPath() for f in change.AffectedFiles()]
1600 if not options.bypass_watchlists:
Daniel Cheng7227d212017-11-17 08:12:37 -08001601 self.ExtendCC(watchlist.GetWatchersForPaths(files))
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001602
1603 if not options.bypass_hooks:
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001604 if options.reviewers or options.tbrs or options.add_owners_to:
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001605 # Set the reviewer list now so that presubmit checks can access it.
1606 change_description = ChangeDescription(change.FullDescriptionText())
1607 change_description.update_reviewers(options.reviewers,
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001608 options.tbrs,
Robert Iannuccif2708bd2017-04-17 15:49:02 -07001609 options.add_owners_to,
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001610 change)
1611 change.SetDescriptionText(change_description.description)
1612 hook_results = self.RunHook(committing=False,
Edward Lesmes8e282792018-04-03 18:50:29 -04001613 may_prompt=not options.force,
1614 verbose=options.verbose,
1615 change=change, parallel=options.parallel)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001616 if not hook_results.should_continue():
1617 return 1
1618 if not options.reviewers and hook_results.reviewers:
1619 options.reviewers = hook_results.reviewers.split(',')
Daniel Cheng7227d212017-11-17 08:12:37 -08001620 self.ExtendCC(hook_results.more_cc)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001621
Aaron Gable13101a62018-02-09 13:20:41 -08001622 print_stats(git_diff_args)
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001623 ret = self.CMDUploadChange(options, git_diff_args, custom_cl_base, change)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001624 if not ret:
tandrii5d48c322016-08-18 16:19:37 -07001625 _git_set_branch_config_value('last-upload-hash',
1626 RunGit(['rev-parse', 'HEAD']).strip())
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001627 # Run post upload hooks, if specified.
1628 if settings.GetRunPostUploadHook():
1629 presubmit_support.DoPostUploadExecuter(
1630 change,
1631 self,
1632 settings.GetRoot(),
1633 options.verbose,
1634 sys.stdout)
1635
1636 # Upload all dependencies if specified.
1637 if options.dependencies:
vapiera7fbd5a2016-06-16 09:17:49 -07001638 print()
1639 print('--dependencies has been specified.')
1640 print('All dependent local branches will be re-uploaded.')
1641 print()
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001642 # Remove the dependencies flag from args so that we do not end up in a
1643 # loop.
1644 orig_args.remove('--dependencies')
1645 ret = upload_branch_deps(self, orig_args)
1646 return ret
1647
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001648 def SetCQState(self, new_state):
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07001649 """Updates the CQ state for the latest patchset.
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001650
1651 Issue must have been already uploaded and known.
1652 """
1653 assert new_state in _CQState.ALL_STATES
1654 assert self.GetIssue()
qyearsley1fdfcb62016-10-24 13:22:03 -07001655 try:
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07001656 self._codereview_impl.SetCQState(new_state)
qyearsley1fdfcb62016-10-24 13:22:03 -07001657 return 0
1658 except KeyboardInterrupt:
1659 raise
1660 except:
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07001661 print('WARNING: Failed to %s.\n'
qyearsley1fdfcb62016-10-24 13:22:03 -07001662 'Either:\n'
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07001663 ' * Your project has no CQ,\n'
1664 ' * You don\'t have permission to change the CQ state,\n'
1665 ' * There\'s a bug in this code (see stack trace below).\n'
1666 'Consider specifying which bots to trigger manually or asking your '
1667 'project owners for permissions or contacting Chrome Infra at:\n'
1668 'https://www.chromium.org/infra\n\n' %
1669 ('cancel CQ' if new_state == _CQState.NONE else 'trigger CQ'))
qyearsley1fdfcb62016-10-24 13:22:03 -07001670 # Still raise exception so that stack trace is printed.
1671 raise
1672
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001673 # Forward methods to codereview specific implementation.
1674
Aaron Gable636b13f2017-07-14 10:42:48 -07001675 def AddComment(self, message, publish=None):
1676 return self._codereview_impl.AddComment(message, publish=publish)
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01001677
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001678 def GetCommentsSummary(self, readable=True):
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01001679 """Returns list of _CommentSummary for each comment.
1680
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001681 args:
1682 readable: determines whether the output is designed for a human or a machine
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01001683 """
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001684 return self._codereview_impl.GetCommentsSummary(readable)
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01001685
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001686 def CloseIssue(self):
1687 return self._codereview_impl.CloseIssue()
1688
1689 def GetStatus(self):
1690 return self._codereview_impl.GetStatus()
1691
1692 def GetCodereviewServer(self):
1693 return self._codereview_impl.GetCodereviewServer()
1694
tandriide281ae2016-10-12 06:02:30 -07001695 def GetIssueOwner(self):
1696 """Get owner from codereview, which may differ from this checkout."""
1697 return self._codereview_impl.GetIssueOwner()
1698
Edward Lemur707d70b2018-02-07 00:50:14 +01001699 def GetReviewers(self):
1700 return self._codereview_impl.GetReviewers()
1701
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001702 def GetMostRecentPatchset(self):
1703 return self._codereview_impl.GetMostRecentPatchset()
1704
tandriide281ae2016-10-12 06:02:30 -07001705 def CannotTriggerTryJobReason(self):
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001706 """Returns reason (str) if unable trigger try jobs on this CL or None."""
tandriide281ae2016-10-12 06:02:30 -07001707 return self._codereview_impl.CannotTriggerTryJobReason()
1708
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001709 def GetTryJobProperties(self, patchset=None):
1710 """Returns dictionary of properties to launch try job."""
1711 return self._codereview_impl.GetTryJobProperties(patchset=patchset)
tandrii8c5a3532016-11-04 07:52:02 -07001712
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001713 def __getattr__(self, attr):
1714 # This is because lots of untested code accesses Rietveld-specific stuff
1715 # directly, and it's hard to fix for sure. So, just let it work, and fix
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00001716 # on a case by case basis.
tandrii4d895502016-08-18 08:26:19 -07001717 # Note that child method defines __getattr__ as well, and forwards it here,
1718 # because _RietveldChangelistImpl is not cleaned up yet, and given
1719 # deprecation of Rietveld, it should probably be just removed.
1720 # Until that time, avoid infinite recursion by bypassing __getattr__
1721 # of implementation class.
1722 return self._codereview_impl.__getattribute__(attr)
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001723
1724
1725class _ChangelistCodereviewBase(object):
1726 """Abstract base class encapsulating codereview specifics of a changelist."""
1727 def __init__(self, changelist):
1728 self._changelist = changelist # instance of Changelist
1729
1730 def __getattr__(self, attr):
1731 # Forward methods to changelist.
1732 # TODO(tandrii): maybe clean up _GerritChangelistImpl and
1733 # _RietveldChangelistImpl to avoid this hack?
1734 return getattr(self._changelist, attr)
1735
1736 def GetStatus(self):
1737 """Apply a rough heuristic to give a simple summary of an issue's review
1738 or CQ status, assuming adherence to a common workflow.
1739
1740 Returns None if no issue for this branch, or specific string keywords.
1741 """
1742 raise NotImplementedError()
1743
1744 def GetCodereviewServer(self):
1745 """Returns server URL without end slash, like "https://codereview.com"."""
1746 raise NotImplementedError()
1747
Kenneth Russell61e2ed42017-02-15 11:47:13 -08001748 def FetchDescription(self, force=False):
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001749 """Fetches and returns description from the codereview server."""
1750 raise NotImplementedError()
1751
tandrii5d48c322016-08-18 16:19:37 -07001752 @classmethod
1753 def IssueConfigKey(cls):
1754 """Returns branch setting storing issue number."""
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001755 raise NotImplementedError()
1756
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001757 @classmethod
tandrii5d48c322016-08-18 16:19:37 -07001758 def PatchsetConfigKey(cls):
1759 """Returns branch setting storing patchset number."""
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001760 raise NotImplementedError()
1761
tandrii5d48c322016-08-18 16:19:37 -07001762 @classmethod
1763 def CodereviewServerConfigKey(cls):
1764 """Returns branch setting storing codereview server."""
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001765 raise NotImplementedError()
1766
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00001767 def _PostUnsetIssueProperties(self):
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001768 """Which branch-specific properties to erase when unsetting issue."""
tandrii5d48c322016-08-18 16:19:37 -07001769 return []
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00001770
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001771 def GetGerritObjForPresubmit(self):
1772 # None is valid return value, otherwise presubmit_support.GerritAccessor.
1773 return None
1774
dsansomee2d6fd92016-09-08 00:10:47 -07001775 def UpdateDescriptionRemote(self, description, force=False):
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001776 """Update the description on codereview site."""
1777 raise NotImplementedError()
1778
Aaron Gable636b13f2017-07-14 10:42:48 -07001779 def AddComment(self, message, publish=None):
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01001780 """Posts a comment to the codereview site."""
1781 raise NotImplementedError()
1782
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001783 def GetCommentsSummary(self, readable=True):
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01001784 raise NotImplementedError()
1785
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001786 def CloseIssue(self):
1787 """Closes the issue."""
1788 raise NotImplementedError()
1789
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001790 def GetMostRecentPatchset(self):
1791 """Returns the most recent patchset number from the codereview site."""
1792 raise NotImplementedError()
1793
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001794 def CMDPatchWithParsedIssue(self, parsed_issue_arg, reject, nocommit,
Aaron Gable62619a32017-06-16 08:22:09 -07001795 directory, force):
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001796 """Fetches and applies the issue.
1797
1798 Arguments:
1799 parsed_issue_arg: instance of _ParsedIssueNumberArgument.
1800 reject: if True, reject the failed patch instead of switching to 3-way
1801 merge. Rietveld only.
1802 nocommit: do not commit the patch, thus leave the tree dirty. Rietveld
1803 only.
1804 directory: switch to directory before applying the patch. Rietveld only.
Aaron Gable62619a32017-06-16 08:22:09 -07001805 force: if true, overwrites existing local state.
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001806 """
1807 raise NotImplementedError()
1808
1809 @staticmethod
1810 def ParseIssueURL(parsed_url):
1811 """Parses url and returns instance of _ParsedIssueNumberArgument or None if
1812 failed."""
1813 raise NotImplementedError()
1814
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01001815 def EnsureAuthenticated(self, force, refresh=False):
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001816 """Best effort check that user is authenticated with codereview server.
1817
1818 Arguments:
1819 force: whether to skip confirmation questions.
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01001820 refresh: whether to attempt to refresh credentials. Ignored if not
1821 applicable.
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001822 """
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001823 raise NotImplementedError()
1824
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001825 def EnsureCanUploadPatchset(self, force):
Andrii Shyshkalov3e631422017-02-16 17:46:44 +01001826 """Best effort check that uploading isn't supposed to fail for predictable
1827 reasons.
1828
1829 This method should raise informative exception if uploading shouldn't
1830 proceed.
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001831
1832 Arguments:
1833 force: whether to skip confirmation questions.
Andrii Shyshkalov3e631422017-02-16 17:46:44 +01001834 """
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001835 raise NotImplementedError()
Andrii Shyshkalov3e631422017-02-16 17:46:44 +01001836
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001837 def CMDUploadChange(self, options, git_diff_args, custom_cl_base, change):
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00001838 """Uploads a change to codereview."""
1839 raise NotImplementedError()
1840
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001841 def SetCQState(self, new_state):
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001842 """Updates the CQ state for the latest patchset.
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001843
1844 Issue must have been already uploaded and known.
1845 """
1846 raise NotImplementedError()
1847
tandriie113dfd2016-10-11 10:20:12 -07001848 def CannotTriggerTryJobReason(self):
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001849 """Returns reason (str) if unable trigger try jobs on this CL or None."""
tandriie113dfd2016-10-11 10:20:12 -07001850 raise NotImplementedError()
1851
tandriide281ae2016-10-12 06:02:30 -07001852 def GetIssueOwner(self):
1853 raise NotImplementedError()
1854
Edward Lemur707d70b2018-02-07 00:50:14 +01001855 def GetReviewers(self):
1856 raise NotImplementedError()
1857
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001858 def GetTryJobProperties(self, patchset=None):
tandriide281ae2016-10-12 06:02:30 -07001859 raise NotImplementedError()
1860
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001861
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001862class _GerritChangelistImpl(_ChangelistCodereviewBase):
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01001863 def __init__(self, changelist, auth_config=None, codereview_host=None):
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001864 # auth_config is Rietveld thing, kept here to preserve interface only.
1865 super(_GerritChangelistImpl, self).__init__(changelist)
1866 self._change_id = None
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001867 # Lazily cached values.
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001868 self._gerrit_host = None # e.g. chromium-review.googlesource.com
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01001869 self._gerrit_server = None # e.g. https://chromium-review.googlesource.com
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01001870 # Map from change number (issue) to its detail cache.
1871 self._detail_cache = {}
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001872
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01001873 if codereview_host is not None:
1874 assert not codereview_host.startswith('https://'), codereview_host
1875 self._gerrit_host = codereview_host
1876 self._gerrit_server = 'https://%s' % codereview_host
1877
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001878 def _GetGerritHost(self):
1879 # Lazy load of configs.
1880 self.GetCodereviewServer()
tandriie32e3ea2016-06-22 02:52:48 -07001881 if self._gerrit_host and '.' not in self._gerrit_host:
1882 # Abbreviated domain like "chromium" instead of chromium.googlesource.com.
1883 # This happens for internal stuff http://crbug.com/614312.
1884 parsed = urlparse.urlparse(self.GetRemoteUrl())
1885 if parsed.scheme == 'sso':
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001886 print('WARNING: using non-https URLs for remote is likely broken\n'
tandriie32e3ea2016-06-22 02:52:48 -07001887 ' Your current remote is: %s' % self.GetRemoteUrl())
1888 self._gerrit_host = '%s.googlesource.com' % self._gerrit_host
1889 self._gerrit_server = 'https://%s' % self._gerrit_host
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001890 return self._gerrit_host
1891
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001892 def _GetGitHost(self):
1893 """Returns git host to be used when uploading change to Gerrit."""
Edward Lemur298f2cf2019-02-22 21:40:39 +00001894 remote_url = self.GetRemoteUrl()
1895 if not remote_url:
1896 return None
1897 return urlparse.urlparse(remote_url).netloc
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001898
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001899 def GetCodereviewServer(self):
1900 if not self._gerrit_server:
1901 # If we're on a branch then get the server potentially associated
1902 # with that branch.
1903 if self.GetIssue():
tandrii5d48c322016-08-18 16:19:37 -07001904 self._gerrit_server = self._GitGetBranchConfigValue(
1905 self.CodereviewServerConfigKey())
1906 if self._gerrit_server:
1907 self._gerrit_host = urlparse.urlparse(self._gerrit_server).netloc
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001908 if not self._gerrit_server:
1909 # We assume repo to be hosted on Gerrit, and hence Gerrit server
1910 # has "-review" suffix for lowest level subdomain.
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001911 parts = self._GetGitHost().split('.')
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001912 parts[0] = parts[0] + '-review'
1913 self._gerrit_host = '.'.join(parts)
1914 self._gerrit_server = 'https://%s' % self._gerrit_host
1915 return self._gerrit_server
1916
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00001917 def _GetGerritProject(self):
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001918 """Returns Gerrit project name based on remote git URL."""
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00001919 remote_url = self.GetRemoteUrl()
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001920 if remote_url is None:
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00001921 logging.warn('can\'t detect Gerrit project.')
1922 return None
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001923 project = urlparse.urlparse(remote_url).path.strip('/')
1924 if project.endswith('.git'):
1925 project = project[:-len('.git')]
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00001926 # *.googlesource.com hosts ensure that Git/Gerrit projects don't start with
1927 # 'a/' prefix, because 'a/' prefix is used to force authentication in
1928 # gitiles/git-over-https protocol. E.g.,
1929 # https://chromium.googlesource.com/a/v8/v8 refers to the same repo/project
1930 # as
1931 # https://chromium.googlesource.com/v8/v8
1932 if project.startswith('a/'):
1933 project = project[len('a/'):]
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001934 return project
1935
Andrii Shyshkalovd06cc782018-08-23 17:24:19 +00001936 def _GerritChangeIdentifier(self):
1937 """Handy method for gerrit_util.ChangeIdentifier for a given CL.
1938
1939 Not to be confused by value of "Change-Id:" footer.
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00001940 If Gerrit project can be determined, this will speed up Gerrit HTTP API RPC.
Andrii Shyshkalovd06cc782018-08-23 17:24:19 +00001941 """
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00001942 project = self._GetGerritProject()
1943 if project:
1944 return gerrit_util.ChangeIdentifier(project, self.GetIssue())
1945 # Fall back on still unique, but less efficient change number.
1946 return str(self.GetIssue())
Andrii Shyshkalovd06cc782018-08-23 17:24:19 +00001947
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001948 @classmethod
tandrii5d48c322016-08-18 16:19:37 -07001949 def IssueConfigKey(cls):
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001950 return 'gerritissue'
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001951
tandrii5d48c322016-08-18 16:19:37 -07001952 @classmethod
1953 def PatchsetConfigKey(cls):
1954 return 'gerritpatchset'
1955
1956 @classmethod
1957 def CodereviewServerConfigKey(cls):
1958 return 'gerritserver'
1959
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01001960 def EnsureAuthenticated(self, force, refresh=None):
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001961 """Best effort check that user is authenticated with Gerrit server."""
tandrii@chromium.org28253532016-04-14 13:46:56 +00001962 if settings.GetGerritSkipEnsureAuthenticated():
1963 # For projects with unusual authentication schemes.
1964 # See http://crbug.com/603378.
1965 return
Vadim Shtayurab250ec12018-10-04 00:21:08 +00001966
1967 # Check presence of cookies only if using cookies-based auth method.
1968 cookie_auth = gerrit_util.Authenticator.get()
1969 if not isinstance(cookie_auth, gerrit_util.CookiesAuthenticator):
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001970 return
Vadim Shtayurab250ec12018-10-04 00:21:08 +00001971
1972 # Lazy-loader to identify Gerrit and Git hosts.
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001973 self.GetCodereviewServer()
1974 git_host = self._GetGitHost()
Edward Lemur298f2cf2019-02-22 21:40:39 +00001975 assert self._gerrit_server and self._gerrit_host and git_host
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001976
1977 gerrit_auth = cookie_auth.get_auth_header(self._gerrit_host)
1978 git_auth = cookie_auth.get_auth_header(git_host)
1979 if gerrit_auth and git_auth:
1980 if gerrit_auth == git_auth:
1981 return
Andrii Shyshkalov354e1d22017-06-09 19:31:33 +02001982 all_gsrc = cookie_auth.get_auth_header('d0esN0tEx1st.googlesource.com')
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001983 print((
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001984 'WARNING: You have different credentials for Gerrit and git hosts:\n'
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001985 ' %s\n'
1986 ' %s\n'
Andrii Shyshkalov51acef92017-04-11 17:19:59 +02001987 ' Consider running the following command:\n'
1988 ' git cl creds-check\n'
Andrii Shyshkalov354e1d22017-06-09 19:31:33 +02001989 ' %s\n'
Andrii Shyshkalov8e4576f2017-05-10 15:46:53 +02001990 ' %s') %
Andrii Shyshkalov51acef92017-04-11 17:19:59 +02001991 (git_host, self._gerrit_host,
Andrii Shyshkalov354e1d22017-06-09 19:31:33 +02001992 ('Hint: delete creds for .googlesource.com' if all_gsrc else ''),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001993 cookie_auth.get_new_password_message(git_host)))
1994 if not force:
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01001995 confirm_or_exit('If you know what you are doing', action='continue')
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001996 return
1997 else:
1998 missing = (
Anna Henningsen4e891442017-07-06 21:40:58 +02001999 ([] if gerrit_auth else [self._gerrit_host]) +
2000 ([] if git_auth else [git_host]))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002001 DieWithError('Credentials for the following hosts are required:\n'
2002 ' %s\n'
2003 'These are read from %s (or legacy %s)\n'
2004 '%s' % (
2005 '\n '.join(missing),
2006 cookie_auth.get_gitcookies_path(),
2007 cookie_auth.get_netrc_path(),
2008 cookie_auth.get_new_password_message(git_host)))
2009
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01002010 def EnsureCanUploadPatchset(self, force):
Andrii Shyshkalov3e631422017-02-16 17:46:44 +01002011 if not self.GetIssue():
2012 return
2013
2014 # Warm change details cache now to avoid RPCs later, reducing latency for
2015 # developers.
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01002016 self._GetChangeDetail(
Andrii Shyshkalovc4a73562018-09-25 18:40:17 +00002017 ['DETAILED_ACCOUNTS', 'CURRENT_REVISION', 'CURRENT_COMMIT', 'LABELS'])
Andrii Shyshkalov3e631422017-02-16 17:46:44 +01002018
2019 status = self._GetChangeDetail()['status']
2020 if status in ('MERGED', 'ABANDONED'):
2021 DieWithError('Change %s has been %s, new uploads are not allowed' %
2022 (self.GetIssueURL(),
2023 'submitted' if status == 'MERGED' else 'abandoned'))
2024
Vadim Shtayurab250ec12018-10-04 00:21:08 +00002025 # TODO(vadimsh): For some reason the chunk of code below was skipped if
2026 # 'is_gce' is True. I'm just refactoring it to be 'skip if not cookies'.
2027 # Apparently this check is not very important? Otherwise get_auth_email
2028 # could have been added to other implementations of Authenticator.
2029 cookies_auth = gerrit_util.Authenticator.get()
2030 if not isinstance(cookies_auth, gerrit_util.CookiesAuthenticator):
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01002031 return
Vadim Shtayurab250ec12018-10-04 00:21:08 +00002032
2033 cookies_user = cookies_auth.get_auth_email(self._GetGerritHost())
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01002034 if self.GetIssueOwner() == cookies_user:
2035 return
2036 logging.debug('change %s owner is %s, cookies user is %s',
2037 self.GetIssue(), self.GetIssueOwner(), cookies_user)
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002038 # Maybe user has linked accounts or something like that,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01002039 # so ask what Gerrit thinks of this user.
2040 details = gerrit_util.GetAccountDetails(self._GetGerritHost(), 'self')
2041 if details['email'] == self.GetIssueOwner():
2042 return
2043 if not force:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002044 print('WARNING: Change %s is owned by %s, but you authenticate to Gerrit '
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01002045 'as %s.\n'
2046 'Uploading may fail due to lack of permissions.' %
2047 (self.GetIssue(), self.GetIssueOwner(), details['email']))
2048 confirm_or_exit(action='upload')
2049
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002050 def _PostUnsetIssueProperties(self):
2051 """Which branch-specific properties to erase when unsetting issue."""
tandrii5d48c322016-08-18 16:19:37 -07002052 return ['gerritsquashhash']
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002053
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00002054 def GetGerritObjForPresubmit(self):
2055 return presubmit_support.GerritAccessor(self._GetGerritHost())
2056
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00002057 def GetStatus(self):
tandrii@chromium.org013a2802016-03-29 09:52:33 +00002058 """Apply a rough heuristic to give a simple summary of an issue's review
2059 or CQ status, assuming adherence to a common workflow.
2060
2061 Returns None if no issue for this branch, or one of the following keywords:
Aaron Gable9ab38c62017-04-06 14:36:33 -07002062 * 'error' - error from review tool (including deleted issues)
2063 * 'unsent' - no reviewers added
2064 * 'waiting' - waiting for review
2065 * 'reply' - waiting for uploader to reply to review
2066 * 'lgtm' - Code-Review label has been set
2067 * 'commit' - in the commit queue
2068 * 'closed' - successfully submitted or abandoned
tandrii@chromium.org013a2802016-03-29 09:52:33 +00002069 """
2070 if not self.GetIssue():
2071 return None
2072
2073 try:
Aaron Gable9ab38c62017-04-06 14:36:33 -07002074 data = self._GetChangeDetail([
2075 'DETAILED_LABELS', 'CURRENT_REVISION', 'SUBMITTABLE'])
Aaron Gablea45ee112016-11-22 15:14:38 -08002076 except (httplib.HTTPException, GerritChangeNotExists):
tandrii@chromium.org013a2802016-03-29 09:52:33 +00002077 return 'error'
2078
tandrii@chromium.org5e1bf382016-05-17 08:43:24 +00002079 if data['status'] in ('ABANDONED', 'MERGED'):
tandrii@chromium.org013a2802016-03-29 09:52:33 +00002080 return 'closed'
2081
Aaron Gable9ab38c62017-04-06 14:36:33 -07002082 if data['labels'].get('Commit-Queue', {}).get('approved'):
2083 # The section will have an "approved" subsection if anyone has voted
2084 # the maximum value on the label.
2085 return 'commit'
tandrii@chromium.org013a2802016-03-29 09:52:33 +00002086
Aaron Gable9ab38c62017-04-06 14:36:33 -07002087 if data['labels'].get('Code-Review', {}).get('approved'):
2088 return 'lgtm'
tandrii@chromium.org013a2802016-03-29 09:52:33 +00002089
2090 if not data.get('reviewers', {}).get('REVIEWER', []):
2091 return 'unsent'
2092
Andrii Shyshkalov33e88a42017-01-27 14:45:30 +01002093 owner = data['owner'].get('_account_id')
Aaron Gable9ab38c62017-04-06 14:36:33 -07002094 messages = sorted(data.get('messages', []), key=lambda m: m.get('updated'))
2095 last_message_author = messages.pop().get('author', {})
2096 while last_message_author:
Andrii Shyshkalov33e88a42017-01-27 14:45:30 +01002097 if last_message_author.get('email') == COMMIT_BOT_EMAIL:
2098 # Ignore replies from CQ.
Aaron Gable9ab38c62017-04-06 14:36:33 -07002099 last_message_author = messages.pop().get('author', {})
Andrii Shyshkalov33e88a42017-01-27 14:45:30 +01002100 continue
Aaron Gable9ab38c62017-04-06 14:36:33 -07002101 if last_message_author.get('_account_id') == owner:
2102 # Most recent message was by owner.
2103 return 'waiting'
2104 else:
tandrii@chromium.org013a2802016-03-29 09:52:33 +00002105 # Some reply from non-owner.
2106 return 'reply'
Aaron Gable9ab38c62017-04-06 14:36:33 -07002107
2108 # Somehow there are no messages even though there are reviewers.
2109 return 'unsent'
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00002110
2111 def GetMostRecentPatchset(self):
tandrii@chromium.org013a2802016-03-29 09:52:33 +00002112 data = self._GetChangeDetail(['CURRENT_REVISION'])
Aaron Gablee8856ee2017-12-07 12:41:46 -08002113 patchset = data['revisions'][data['current_revision']]['_number']
2114 self.SetPatchset(patchset)
2115 return patchset
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00002116
Kenneth Russell61e2ed42017-02-15 11:47:13 -08002117 def FetchDescription(self, force=False):
2118 data = self._GetChangeDetail(['CURRENT_REVISION', 'CURRENT_COMMIT'],
2119 no_cache=force)
tandrii@chromium.org2d3da632016-04-25 19:23:27 +00002120 current_rev = data['current_revision']
Dan Beamcf6df902018-11-08 01:48:37 +00002121 return data['revisions'][current_rev]['commit']['message'].encode(
2122 'utf-8', 'ignore')
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00002123
dsansomee2d6fd92016-09-08 00:10:47 -07002124 def UpdateDescriptionRemote(self, description, force=False):
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002125 if gerrit_util.HasPendingChangeEdit(
2126 self._GetGerritHost(), self._GerritChangeIdentifier()):
dsansomee2d6fd92016-09-08 00:10:47 -07002127 if not force:
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002128 confirm_or_exit(
dsansomee2d6fd92016-09-08 00:10:47 -07002129 'The description cannot be modified while the issue has a pending '
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002130 'unpublished edit. Either publish the edit in the Gerrit web UI '
2131 'or delete it.\n\n', action='delete the unpublished edit')
dsansomee2d6fd92016-09-08 00:10:47 -07002132
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002133 gerrit_util.DeletePendingChangeEdit(
2134 self._GetGerritHost(), self._GerritChangeIdentifier())
2135 gerrit_util.SetCommitMessage(
2136 self._GetGerritHost(), self._GerritChangeIdentifier(),
2137 description, notify='NONE')
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00002138
Aaron Gable636b13f2017-07-14 10:42:48 -07002139 def AddComment(self, message, publish=None):
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002140 gerrit_util.SetReview(
2141 self._GetGerritHost(), self._GerritChangeIdentifier(),
2142 msg=message, ready=publish)
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002143
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002144 def GetCommentsSummary(self, readable=True):
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002145 # DETAILED_ACCOUNTS is to get emails in accounts.
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002146 # CURRENT_REVISION is included to get the latest patchset so that
2147 # only the robot comments from the latest patchset can be shown.
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002148 messages = self._GetChangeDetail(
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002149 options=['MESSAGES', 'DETAILED_ACCOUNTS',
2150 'CURRENT_REVISION']).get('messages', [])
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002151 file_comments = gerrit_util.GetChangeComments(
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002152 self._GetGerritHost(), self._GerritChangeIdentifier())
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002153 robot_file_comments = gerrit_util.GetChangeRobotComments(
2154 self._GetGerritHost(), self._GerritChangeIdentifier())
2155
2156 # Add the robot comments onto the list of comments, but only
2157 # keep those that are from the latest pachset.
2158 latest_patch_set = self.GetMostRecentPatchset()
2159 for path, robot_comments in robot_file_comments.iteritems():
2160 line_comments = file_comments.setdefault(path, [])
2161 line_comments.extend(
2162 [c for c in robot_comments if c['patch_set'] == latest_patch_set])
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002163
2164 # Build dictionary of file comments for easy access and sorting later.
2165 # {author+date: {path: {patchset: {line: url+message}}}}
2166 comments = collections.defaultdict(
2167 lambda: collections.defaultdict(lambda: collections.defaultdict(dict)))
2168 for path, line_comments in file_comments.iteritems():
2169 for comment in line_comments:
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002170 tag = comment.get('tag', '')
2171 if tag.startswith('autogenerated') and 'robot_id' not in comment:
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002172 continue
2173 key = (comment['author']['email'], comment['updated'])
2174 if comment.get('side', 'REVISION') == 'PARENT':
2175 patchset = 'Base'
2176 else:
2177 patchset = 'PS%d' % comment['patch_set']
2178 line = comment.get('line', 0)
2179 url = ('https://%s/c/%s/%s/%s#%s%s' %
2180 (self._GetGerritHost(), self.GetIssue(), comment['patch_set'], path,
2181 'b' if comment.get('side') == 'PARENT' else '',
2182 str(line) if line else ''))
2183 comments[key][path][patchset][line] = (url, comment['message'])
2184
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002185 summaries = []
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002186 for msg in messages:
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002187 summary = self._BuildCommentSummary(msg, comments, readable)
2188 if summary:
2189 summaries.append(summary)
2190 return summaries
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002191
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002192 @staticmethod
2193 def _BuildCommentSummary(msg, comments, readable):
2194 key = (msg['author']['email'], msg['date'])
2195 # Don't bother showing autogenerated messages that don't have associated
2196 # file or line comments. this will filter out most autogenerated
2197 # messages, but will keep robot comments like those from Tricium.
2198 is_autogenerated = msg.get('tag', '').startswith('autogenerated')
2199 if is_autogenerated and not comments.get(key):
2200 return None
2201 message = msg['message']
2202 # Gerrit spits out nanoseconds.
2203 assert len(msg['date'].split('.')[-1]) == 9
2204 date = datetime.datetime.strptime(msg['date'][:-3],
2205 '%Y-%m-%d %H:%M:%S.%f')
2206 if key in comments:
2207 message += '\n'
2208 for path, patchsets in sorted(comments.get(key, {}).items()):
2209 if readable:
2210 message += '\n%s' % path
2211 for patchset, lines in sorted(patchsets.items()):
2212 for line, (url, content) in sorted(lines.items()):
2213 if line:
2214 line_str = 'Line %d' % line
2215 path_str = '%s:%d:' % (path, line)
2216 else:
2217 line_str = 'File comment'
2218 path_str = '%s:0:' % path
2219 if readable:
2220 message += '\n %s, %s: %s' % (patchset, line_str, url)
2221 message += '\n %s\n' % content
2222 else:
2223 message += '\n%s ' % path_str
2224 message += '\n%s\n' % content
2225
2226 return _CommentSummary(
2227 date=date,
2228 message=message,
2229 sender=msg['author']['email'],
2230 autogenerated=is_autogenerated,
2231 # These could be inferred from the text messages and correlated with
2232 # Code-Review label maximum, however this is not reliable.
2233 # Leaving as is until the need arises.
2234 approval=False,
2235 disapproval=False,
2236 )
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01002237
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00002238 def CloseIssue(self):
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002239 gerrit_util.AbandonChange(
2240 self._GetGerritHost(), self._GerritChangeIdentifier(), msg='')
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00002241
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002242 def SubmitIssue(self, wait_for_merge=True):
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002243 gerrit_util.SubmitChange(
2244 self._GetGerritHost(), self._GerritChangeIdentifier(),
2245 wait_for_merge=wait_for_merge)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00002246
Andrii Shyshkalovb7214602018-08-22 23:20:26 +00002247 def _GetChangeDetail(self, options=None, no_cache=False):
2248 """Returns details of associated Gerrit change and caching results.
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002249
2250 If fresh data is needed, set no_cache=True which will clear cache and
2251 thus new data will be fetched from Gerrit.
2252 """
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002253 options = options or []
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002254 assert self.GetIssue(), 'issue is required to query Gerrit'
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002255
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01002256 # Optimization to avoid multiple RPCs:
2257 if (('CURRENT_REVISION' in options or 'ALL_REVISIONS' in options) and
2258 'CURRENT_COMMIT' not in options):
2259 options.append('CURRENT_COMMIT')
2260
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002261 # Normalize issue and options for consistent keys in cache.
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002262 cache_key = str(self.GetIssue())
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002263 options = [o.upper() for o in options]
2264
2265 # Check in cache first unless no_cache is True.
2266 if no_cache:
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002267 self._detail_cache.pop(cache_key, None)
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002268 else:
2269 options_set = frozenset(options)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002270 for cached_options_set, data in self._detail_cache.get(cache_key, []):
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002271 # Assumption: data fetched before with extra options is suitable
2272 # for return for a smaller set of options.
2273 # For example, if we cached data for
2274 # options=[CURRENT_REVISION, DETAILED_FOOTERS]
2275 # and request is for options=[CURRENT_REVISION],
2276 # THEN we can return prior cached data.
2277 if options_set.issubset(cached_options_set):
2278 return data
2279
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01002280 try:
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002281 data = gerrit_util.GetChangeDetail(
2282 self._GetGerritHost(), self._GerritChangeIdentifier(), options)
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01002283 except gerrit_util.GerritError as e:
2284 if e.http_status == 404:
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002285 raise GerritChangeNotExists(self.GetIssue(), self.GetCodereviewServer())
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01002286 raise
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002287
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002288 self._detail_cache.setdefault(cache_key, []).append(
2289 (frozenset(options), data))
tandriic2405f52016-10-10 08:13:15 -07002290 return data
tandrii@chromium.org013a2802016-03-29 09:52:33 +00002291
Andrii Shyshkalovcc5f17e2018-08-22 23:35:59 +00002292 def _GetChangeCommit(self):
Andrii Shyshkalove2633162018-08-27 23:50:31 +00002293 assert self.GetIssue(), 'issue must be set to query Gerrit'
Aaron Gable6f5a8d92017-04-18 14:49:05 -07002294 try:
Andrii Shyshkalove2633162018-08-27 23:50:31 +00002295 data = gerrit_util.GetChangeCommit(
2296 self._GetGerritHost(), self._GerritChangeIdentifier())
Aaron Gable6f5a8d92017-04-18 14:49:05 -07002297 except gerrit_util.GerritError as e:
2298 if e.http_status == 404:
Andrii Shyshkalove2633162018-08-27 23:50:31 +00002299 raise GerritChangeNotExists(self.GetIssue(), self.GetCodereviewServer())
Aaron Gable6f5a8d92017-04-18 14:49:05 -07002300 raise
agable32978d92016-11-01 12:55:02 -07002301 return data
2302
Karen Qian40c19422019-03-13 21:28:29 +00002303 def _IsCqConfigured(self):
2304 detail = self._GetChangeDetail(['LABELS'])
2305 if not u'Commit-Queue' in detail.get('labels', {}):
2306 return False
2307 # TODO(crbug/753213): Remove temporary hack
2308 if ('https://chromium.googlesource.com/chromium/src' ==
2309 self._changelist.GetRemoteUrl() and
2310 detail['branch'].startswith('refs/branch-heads/')):
2311 return False
2312 return True
2313
Olivier Robin75ee7252018-04-13 10:02:56 +02002314 def CMDLand(self, force, bypass_hooks, verbose, parallel):
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002315 if git_common.is_dirty_git_tree('land'):
2316 return 1
Karen Qian40c19422019-03-13 21:28:29 +00002317
tandriid60367b2016-06-22 05:25:12 -07002318 detail = self._GetChangeDetail(['CURRENT_REVISION', 'LABELS'])
Karen Qian40c19422019-03-13 21:28:29 +00002319 if not force and self._IsCqConfigured():
2320 confirm_or_exit('\nIt seems this repository has a Commit Queue, '
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002321 'which can test and land changes for you. '
2322 'Are you sure you wish to bypass it?\n',
2323 action='bypass CQ')
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002324 differs = True
tandriic4344b52016-08-29 06:04:54 -07002325 last_upload = self._GitGetBranchConfigValue('gerritsquashhash')
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002326 # Note: git diff outputs nothing if there is no diff.
2327 if not last_upload or RunGit(['diff', last_upload]).strip():
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002328 print('WARNING: Some changes from local branch haven\'t been uploaded.')
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002329 else:
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002330 if detail['current_revision'] == last_upload:
2331 differs = False
2332 else:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002333 print('WARNING: Local branch contents differ from latest uploaded '
2334 'patchset.')
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002335 if differs:
2336 if not force:
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002337 confirm_or_exit(
2338 'Do you want to submit latest Gerrit patchset and bypass hooks?\n',
2339 action='submit')
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002340 print('WARNING: Bypassing hooks and submitting latest uploaded patchset.')
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002341 elif not bypass_hooks:
2342 hook_results = self.RunHook(
2343 committing=True,
2344 may_prompt=not force,
2345 verbose=verbose,
Olivier Robin75ee7252018-04-13 10:02:56 +02002346 change=self.GetChange(self.GetCommonAncestorWithUpstream(), None),
2347 parallel=parallel)
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002348 if not hook_results.should_continue():
2349 return 1
2350
2351 self.SubmitIssue(wait_for_merge=True)
2352 print('Issue %s has been submitted.' % self.GetIssueURL())
agable32978d92016-11-01 12:55:02 -07002353 links = self._GetChangeCommit().get('web_links', [])
2354 for link in links:
Aaron Gable02cdbb42016-12-13 16:24:25 -08002355 if link.get('name') == 'gitiles' and link.get('url'):
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002356 print('Landed as: %s' % link.get('url'))
agable32978d92016-11-01 12:55:02 -07002357 break
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002358 return 0
2359
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002360 def CMDPatchWithParsedIssue(self, parsed_issue_arg, reject, nocommit,
Aaron Gable62619a32017-06-16 08:22:09 -07002361 directory, force):
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002362 assert not reject
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002363 assert not directory
2364 assert parsed_issue_arg.valid
2365
2366 self._changelist.issue = parsed_issue_arg.issue
2367
2368 if parsed_issue_arg.hostname:
2369 self._gerrit_host = parsed_issue_arg.hostname
2370 self._gerrit_server = 'https://%s' % self._gerrit_host
2371
tandriic2405f52016-10-10 08:13:15 -07002372 try:
2373 detail = self._GetChangeDetail(['ALL_REVISIONS'])
Aaron Gablea45ee112016-11-22 15:14:38 -08002374 except GerritChangeNotExists as e:
tandriic2405f52016-10-10 08:13:15 -07002375 DieWithError(str(e))
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002376
2377 if not parsed_issue_arg.patchset:
2378 # Use current revision by default.
2379 revision_info = detail['revisions'][detail['current_revision']]
2380 patchset = int(revision_info['_number'])
2381 else:
2382 patchset = parsed_issue_arg.patchset
2383 for revision_info in detail['revisions'].itervalues():
2384 if int(revision_info['_number']) == parsed_issue_arg.patchset:
2385 break
2386 else:
Aaron Gablea45ee112016-11-22 15:14:38 -08002387 DieWithError('Couldn\'t find patchset %i in change %i' %
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002388 (parsed_issue_arg.patchset, self.GetIssue()))
2389
Aaron Gable697a91b2018-01-19 15:20:15 -08002390 remote_url = self._changelist.GetRemoteUrl()
2391 if remote_url.endswith('.git'):
2392 remote_url = remote_url[:-len('.git')]
erikchen0d14d0d2018-08-28 18:57:09 +00002393 remote_url = remote_url.rstrip('/')
2394
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002395 fetch_info = revision_info['fetch']['http']
erikchen0d14d0d2018-08-28 18:57:09 +00002396 fetch_info['url'] = fetch_info['url'].rstrip('/')
Aaron Gable697a91b2018-01-19 15:20:15 -08002397
2398 if remote_url != fetch_info['url']:
2399 DieWithError('Trying to patch a change from %s but this repo appears '
2400 'to be %s.' % (fetch_info['url'], remote_url))
2401
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002402 RunGit(['fetch', fetch_info['url'], fetch_info['ref']])
Aaron Gable9387b4f2017-06-08 10:50:03 -07002403
Aaron Gable62619a32017-06-16 08:22:09 -07002404 if force:
2405 RunGit(['reset', '--hard', 'FETCH_HEAD'])
2406 print('Checked out commit for change %i patchset %i locally' %
2407 (parsed_issue_arg.issue, patchset))
Stefan Zager2d5f0392017-10-10 15:17:53 -07002408 elif nocommit:
2409 RunGit(['cherry-pick', '--no-commit', 'FETCH_HEAD'])
2410 print('Patch applied to index.')
Aaron Gable62619a32017-06-16 08:22:09 -07002411 else:
Aaron Gable9387b4f2017-06-08 10:50:03 -07002412 RunGit(['cherry-pick', 'FETCH_HEAD'])
2413 print('Committed patch for change %i patchset %i locally.' %
Aaron Gable62619a32017-06-16 08:22:09 -07002414 (parsed_issue_arg.issue, patchset))
2415 print('Note: this created a local commit which does not have '
2416 'the same hash as the one uploaded for review. This will make '
2417 'uploading changes based on top of this branch difficult.\n'
2418 'If you want to do that, use "git cl patch --force" instead.')
2419
Stefan Zagerd08043c2017-10-12 12:07:02 -07002420 if self.GetBranch():
2421 self.SetIssue(parsed_issue_arg.issue)
2422 self.SetPatchset(patchset)
2423 fetched_hash = RunGit(['rev-parse', 'FETCH_HEAD']).strip()
2424 self._GitSetBranchConfigValue('last-upload-hash', fetched_hash)
2425 self._GitSetBranchConfigValue('gerritsquashhash', fetched_hash)
2426 else:
2427 print('WARNING: You are in detached HEAD state.\n'
2428 'The patch has been applied to your checkout, but you will not be '
2429 'able to upload a new patch set to the gerrit issue.\n'
2430 'Try using the \'-b\' option if you would like to work on a '
2431 'branch and/or upload a new patch set.')
2432
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002433 return 0
2434
2435 @staticmethod
2436 def ParseIssueURL(parsed_url):
2437 if not parsed_url.scheme or not parsed_url.scheme.startswith('http'):
2438 return None
Aaron Gable01b91062017-08-24 17:48:40 -07002439 # Gerrit's new UI is https://domain/c/project/+/<issue_number>[/[patchset]]
2440 # But old GWT UI is https://domain/#/c/project/+/<issue_number>[/[patchset]]
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002441 # Short urls like https://domain/<issue_number> can be used, but don't allow
2442 # specifying the patchset (you'd 404), but we allow that here.
2443 if parsed_url.path == '/':
2444 part = parsed_url.fragment
2445 else:
2446 part = parsed_url.path
Aaron Gable01b91062017-08-24 17:48:40 -07002447 match = re.match('(/c(/.*/\+)?)?/(\d+)(/(\d+)?/?)?$', part)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002448 if match:
2449 return _ParsedIssueNumberArgument(
Aaron Gable01b91062017-08-24 17:48:40 -07002450 issue=int(match.group(3)),
2451 patchset=int(match.group(5)) if match.group(5) else None,
Andrii Shyshkalov90f31922017-04-10 16:10:21 +02002452 hostname=parsed_url.netloc,
2453 codereview='gerrit')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002454 return None
2455
tandrii16e0b4e2016-06-07 10:34:28 -07002456 def _GerritCommitMsgHookCheck(self, offer_removal):
2457 hook = os.path.join(settings.GetRoot(), '.git', 'hooks', 'commit-msg')
2458 if not os.path.exists(hook):
2459 return
2460 # Crude attempt to distinguish Gerrit Codereview hook from potentially
2461 # custom developer made one.
2462 data = gclient_utils.FileRead(hook)
2463 if not('From Gerrit Code Review' in data and 'add_ChangeId()' in data):
2464 return
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002465 print('WARNING: You have Gerrit commit-msg hook installed.\n'
qyearsley12fa6ff2016-08-24 09:18:40 -07002466 'It is not necessary for uploading with git cl in squash mode, '
tandrii16e0b4e2016-06-07 10:34:28 -07002467 'and may interfere with it in subtle ways.\n'
2468 'We recommend you remove the commit-msg hook.')
2469 if offer_removal:
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002470 if ask_for_explicit_yes('Do you want to remove it now?'):
tandrii16e0b4e2016-06-07 10:34:28 -07002471 gclient_utils.rm_file_or_tree(hook)
2472 print('Gerrit commit-msg hook removed.')
2473 else:
2474 print('OK, will keep Gerrit commit-msg hook in place.')
2475
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002476 def CMDUploadChange(self, options, git_diff_args, custom_cl_base, change):
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002477 """Upload the current branch to Gerrit."""
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00002478 if options.squash and options.no_squash:
2479 DieWithError('Can only use one of --squash or --no-squash')
tandriia60502f2016-06-20 02:01:53 -07002480
2481 if not options.squash and not options.no_squash:
2482 # Load default for user, repo, squash=true, in this order.
2483 options.squash = settings.GetSquashGerritUploads()
2484 elif options.no_squash:
2485 options.squash = False
tandrii26f3e4e2016-06-10 08:37:04 -07002486
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002487 remote, remote_branch = self.GetRemoteBranch()
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01002488 branch = GetTargetRef(remote, remote_branch, options.target_branch)
Aaron Gableb56ad332017-01-06 15:24:31 -08002489 # This may be None; default fallback value is determined in logic below.
2490 title = options.title
2491
Dominic Battre7d1c4842017-10-27 09:17:28 +02002492 # Extract bug number from branch name.
2493 bug = options.bug
2494 match = re.match(r'(?:bug|fix)[_-]?(\d+)', self.GetBranch())
2495 if not bug and match:
2496 bug = match.group(1)
2497
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002498 if options.squash:
tandrii16e0b4e2016-06-07 10:34:28 -07002499 self._GerritCommitMsgHookCheck(offer_removal=not options.force)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002500 if self.GetIssue():
2501 # Try to get the message from a previous upload.
2502 message = self.GetDescription()
2503 if not message:
2504 DieWithError(
Aaron Gablea45ee112016-11-22 15:14:38 -08002505 'failed to fetch description from current Gerrit change %d\n'
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002506 '%s' % (self.GetIssue(), self.GetIssueURL()))
Aaron Gableb56ad332017-01-06 15:24:31 -08002507 if not title:
Andrii Shyshkalov2d8a2072017-04-10 15:02:18 +02002508 if options.message:
Aaron Gable7303dcb2017-06-07 14:17:32 -07002509 # When uploading a subsequent patchset, -m|--message is taken
2510 # as the patchset title if --title was not provided.
2511 title = options.message.strip()
Andrii Shyshkalov2d8a2072017-04-10 15:02:18 +02002512 else:
2513 default_title = RunGit(
2514 ['show', '-s', '--format=%s', 'HEAD']).strip()
Aaron Gable7303dcb2017-06-07 14:17:32 -07002515 if options.force:
2516 title = default_title
2517 else:
2518 title = ask_for_data(
2519 'Title for patchset [%s]: ' % default_title) or default_title
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002520 change_id = self._GetChangeDetail()['change_id']
2521 while True:
2522 footer_change_ids = git_footers.get_footer_change_id(message)
2523 if footer_change_ids == [change_id]:
2524 break
2525 if not footer_change_ids:
2526 message = git_footers.add_footer_change_id(message, change_id)
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002527 print('WARNING: appended missing Change-Id to change description.')
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002528 continue
2529 # There is already a valid footer but with different or several ids.
2530 # Doing this automatically is non-trivial as we don't want to lose
2531 # existing other footers, yet we want to append just 1 desired
2532 # Change-Id. Thus, just create a new footer, but let user verify the
2533 # new description.
2534 message = '%s\n\nChange-Id: %s' % (message, change_id)
2535 print(
Aaron Gablea45ee112016-11-22 15:14:38 -08002536 'WARNING: change %s has Change-Id footer(s):\n'
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002537 ' %s\n'
Aaron Gablea45ee112016-11-22 15:14:38 -08002538 'but change has Change-Id %s, according to Gerrit.\n'
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002539 'Please, check the proposed correction to the description, '
2540 'and edit it if necessary but keep the "Change-Id: %s" footer\n'
2541 % (self.GetIssue(), '\n '.join(footer_change_ids), change_id,
2542 change_id))
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002543 confirm_or_exit(action='edit')
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002544 if not options.force:
2545 change_desc = ChangeDescription(message)
Dominic Battre7d1c4842017-10-27 09:17:28 +02002546 change_desc.prompt(bug=bug)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002547 message = change_desc.description
2548 if not message:
2549 DieWithError("Description is empty. Aborting...")
2550 # Continue the while loop.
2551 # Sanity check of this code - we should end up with proper message
2552 # footer.
2553 assert [change_id] == git_footers.get_footer_change_id(message)
2554 change_desc = ChangeDescription(message)
Aaron Gableb56ad332017-01-06 15:24:31 -08002555 else: # if not self.GetIssue()
2556 if options.message:
2557 message = options.message
2558 else:
Andrii Shyshkalovb07575f2018-10-16 06:16:21 +00002559 message = _create_description_from_log(git_diff_args)
Aaron Gableb56ad332017-01-06 15:24:31 -08002560 if options.title:
2561 message = options.title + '\n\n' + message
2562 change_desc = ChangeDescription(message)
Andrii Shyshkalov8c90d032017-04-19 21:27:26 +02002563
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002564 if not options.force:
Dominic Battre7d1c4842017-10-27 09:17:28 +02002565 change_desc.prompt(bug=bug)
Aaron Gableb56ad332017-01-06 15:24:31 -08002566 # On first upload, patchset title is always this string, while
2567 # --title flag gets converted to first line of message.
2568 title = 'Initial upload'
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002569 if not change_desc.description:
2570 DieWithError("Description is empty. Aborting...")
Andrii Shyshkalov8c90d032017-04-19 21:27:26 +02002571 change_ids = git_footers.get_footer_change_id(change_desc.description)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002572 if len(change_ids) > 1:
2573 DieWithError('too many Change-Id footers, at most 1 allowed.')
2574 if not change_ids:
2575 # Generate the Change-Id automatically.
Andrii Shyshkalov8c90d032017-04-19 21:27:26 +02002576 change_desc.set_description(git_footers.add_footer_change_id(
2577 change_desc.description,
2578 GenerateGerritChangeId(change_desc.description)))
2579 change_ids = git_footers.get_footer_change_id(change_desc.description)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002580 assert len(change_ids) == 1
2581 change_id = change_ids[0]
2582
Robert Iannuccidb02dd02017-04-19 12:18:20 -07002583 if options.reviewers or options.tbrs or options.add_owners_to:
2584 change_desc.update_reviewers(options.reviewers, options.tbrs,
2585 options.add_owners_to, change)
2586
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002587 remote, upstream_branch = self.FetchUpstreamTuple(self.GetBranch())
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002588 parent = self._ComputeParent(remote, upstream_branch, custom_cl_base,
2589 options.force, change_desc)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002590 tree = RunGit(['rev-parse', 'HEAD:']).strip()
Aaron Gable9a03ae02017-11-03 11:31:07 -07002591 with tempfile.NamedTemporaryFile(delete=False) as desc_tempfile:
2592 desc_tempfile.write(change_desc.description)
2593 desc_tempfile.close()
2594 ref_to_push = RunGit(['commit-tree', tree, '-p', parent,
2595 '-F', desc_tempfile.name]).strip()
2596 os.remove(desc_tempfile.name)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002597 else:
2598 change_desc = ChangeDescription(
Andrii Shyshkalovb07575f2018-10-16 06:16:21 +00002599 options.message or _create_description_from_log(git_diff_args))
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002600 if not change_desc.description:
2601 DieWithError("Description is empty. Aborting...")
2602
2603 if not git_footers.get_footer_change_id(change_desc.description):
2604 DownloadGerritHook(False)
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002605 change_desc.set_description(
2606 self._AddChangeIdToCommitMessage(options, git_diff_args))
Robert Iannuccidb02dd02017-04-19 12:18:20 -07002607 if options.reviewers or options.tbrs or options.add_owners_to:
2608 change_desc.update_reviewers(options.reviewers, options.tbrs,
2609 options.add_owners_to, change)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002610 ref_to_push = 'HEAD'
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002611 # For no-squash mode, we assume the remote called "origin" is the one we
2612 # want. It is not worthwhile to support different workflows for
2613 # no-squash mode.
2614 parent = 'origin/%s' % branch
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002615 change_id = git_footers.get_footer_change_id(change_desc.description)[0]
2616
2617 assert change_desc
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +00002618 SaveDescriptionBackup(change_desc)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002619 commits = RunGitSilent(['rev-list', '%s..%s' % (parent,
2620 ref_to_push)]).splitlines()
2621 if len(commits) > 1:
2622 print('WARNING: This will upload %d commits. Run the following command '
2623 'to see which commits will be uploaded: ' % len(commits))
2624 print('git log %s..%s' % (parent, ref_to_push))
2625 print('You can also use `git squash-branch` to squash these into a '
2626 'single commit.')
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002627 confirm_or_exit(action='upload')
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002628
Aaron Gable6dadfbf2017-05-09 14:27:58 -07002629 if options.reviewers or options.tbrs or options.add_owners_to:
2630 change_desc.update_reviewers(options.reviewers, options.tbrs,
2631 options.add_owners_to, change)
2632
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00002633 reviewers = sorted(change_desc.get_reviewers())
2634 # Add cc's from the CC_LIST and --cc flag (if any).
2635 if not options.private and not options.no_autocc:
2636 cc = self.GetCCList().split(',')
2637 else:
2638 cc = []
2639 if options.cc:
2640 cc.extend(options.cc)
2641 cc = filter(None, [email.strip() for email in cc])
2642 if change_desc.get_cced():
2643 cc.extend(change_desc.get_cced())
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00002644 if self._GetGerritHost() == 'chromium-review.googlesource.com':
2645 valid_accounts = set(reviewers + cc)
2646 # TODO(crbug/877717): relax this for all hosts.
2647 else:
2648 valid_accounts = gerrit_util.ValidAccounts(
2649 self._GetGerritHost(), reviewers + cc)
Andrii Shyshkalovf170af42018-10-30 07:00:44 +00002650 logging.info('accounts %s are recognized, %s invalid',
2651 sorted(valid_accounts),
2652 set(reviewers + cc).difference(set(valid_accounts)))
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00002653
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00002654 # Extra options that can be specified at push time. Doc:
2655 # https://gerrit-review.googlesource.com/Documentation/user-upload.html
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00002656 refspec_opts = []
Andrii Shyshkalov2d8a2072017-04-10 15:02:18 +02002657
Aaron Gable844cf292017-06-28 11:32:59 -07002658 # By default, new changes are started in WIP mode, and subsequent patchsets
2659 # don't send email. At any time, passing --send-mail will mark the change
2660 # ready and send email for that particular patch.
Aaron Gableafd52772017-06-27 16:40:10 -07002661 if options.send_mail:
2662 refspec_opts.append('ready')
Aaron Gable844cf292017-06-28 11:32:59 -07002663 refspec_opts.append('notify=ALL')
Jamie Madill276da0b2018-04-27 14:41:20 -04002664 elif not self.GetIssue() and options.squash:
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08002665 refspec_opts.append('wip')
Aaron Gableafd52772017-06-27 16:40:10 -07002666 else:
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08002667 refspec_opts.append('notify=NONE')
Aaron Gable70f4e242017-06-26 10:45:59 -07002668
Andrii Shyshkalov2d8a2072017-04-10 15:02:18 +02002669 # TODO(tandrii): options.message should be posted as a comment
Aaron Gablee5adf612017-07-14 10:43:58 -07002670 # if --send-mail is set on non-initial upload as Rietveld used to do it.
Andrii Shyshkalov2d8a2072017-04-10 15:02:18 +02002671
Aaron Gable9b713dd2016-12-14 16:04:21 -08002672 if title:
Nick Carter8692b182017-11-06 16:30:38 -08002673 # Punctuation and whitespace in |title| must be percent-encoded.
2674 refspec_opts.append('m=' + gerrit_util.PercentEncodeForGitRef(title))
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00002675
agablec6787972016-09-09 16:13:34 -07002676 if options.private:
Aaron Gableb02daf02017-05-23 11:53:46 -07002677 refspec_opts.append('private')
agablec6787972016-09-09 16:13:34 -07002678
Andrii Shyshkalov2f727912018-10-15 17:02:33 +00002679 for r in sorted(reviewers):
2680 if r in valid_accounts:
2681 refspec_opts.append('r=%s' % r)
2682 reviewers.remove(r)
2683 else:
2684 # TODO(tandrii): this should probably be a hard failure.
2685 print('WARNING: reviewer %s doesn\'t have a Gerrit account, skipping'
2686 % r)
2687 for c in sorted(cc):
2688 # refspec option will be rejected if cc doesn't correspond to an
2689 # account, even though REST call to add such arbitrary cc may succeed.
2690 if c in valid_accounts:
2691 refspec_opts.append('cc=%s' % c)
2692 cc.remove(c)
2693
rmistry9eadede2016-09-19 11:22:43 -07002694 if options.topic:
2695 # Documentation on Gerrit topics is here:
2696 # https://gerrit-review.googlesource.com/Documentation/user-upload.html#topic
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00002697 refspec_opts.append('topic=%s' % options.topic)
rmistry9eadede2016-09-19 11:22:43 -07002698
Edward Lemur687ca902018-12-05 02:30:30 +00002699 if options.enable_auto_submit:
2700 refspec_opts.append('l=Auto-Submit+1')
2701 if options.use_commit_queue:
2702 refspec_opts.append('l=Commit-Queue+2')
2703 elif options.cq_dry_run:
2704 refspec_opts.append('l=Commit-Queue+1')
2705
2706 if change_desc.get_reviewers(tbr_only=True):
2707 score = gerrit_util.GetCodeReviewTbrScore(
2708 self._GetGerritHost(),
2709 self._GetGerritProject())
2710 refspec_opts.append('l=Code-Review+%s' % score)
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00002711
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08002712 # Gerrit sorts hashtags, so order is not important.
Nodir Turakulov23b82142017-11-16 11:04:25 -08002713 hashtags = {change_desc.sanitize_hash_tag(t) for t in options.hashtags}
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08002714 if not self.GetIssue():
Nodir Turakulov23b82142017-11-16 11:04:25 -08002715 hashtags.update(change_desc.get_hash_tags())
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08002716 refspec_opts += ['hashtag=%s' % t for t in sorted(hashtags)]
2717
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00002718 refspec_suffix = ''
2719 if refspec_opts:
2720 refspec_suffix = '%' + ','.join(refspec_opts)
2721 assert ' ' not in refspec_suffix, (
2722 'spaces not allowed in refspec: "%s"' % refspec_suffix)
2723 refspec = '%s:refs/for/%s%s' % (ref_to_push, branch, refspec_suffix)
2724
Andrii Shyshkalov7d518832016-12-15 20:48:21 +01002725 try:
Raul Tambreba35c7f2019-03-24 06:11:18 +00002726 push_returncode = 0
Edward Lemur01f4a4f2018-11-03 00:40:38 +00002727 before_push = time_time()
Andrii Shyshkalov7d518832016-12-15 20:48:21 +01002728 push_stdout = gclient_utils.CheckCallAndFilter(
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00002729 ['git', 'push', self.GetRemoteUrl(), refspec],
Edward Lemuredcefdc2018-11-08 14:41:42 +00002730 print_stdout=True,
Edward Lemur49c8eaf2018-11-07 22:13:12 +00002731 # Flush after every line: useful for seeing progress when running as
2732 # recipe.
2733 filter_fn=lambda _: sys.stdout.flush())
Edward Lemurfec80c42018-11-01 23:14:14 +00002734 except subprocess2.CalledProcessError as e:
2735 push_returncode = e.returncode
Andrii Shyshkalov7d518832016-12-15 20:48:21 +01002736 DieWithError('Failed to create a change. Please examine output above '
Andrii Shyshkalov9d932212017-04-10 14:28:23 +02002737 'for the reason of the failure.\n'
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002738 'Hint: run command below to diagnose common Git/Gerrit '
Andrii Shyshkalov9d932212017-04-10 14:28:23 +02002739 'credential problems:\n'
2740 ' git cl creds-check\n',
2741 change_desc)
Edward Lemurfec80c42018-11-01 23:14:14 +00002742 finally:
2743 metrics.collector.add_repeated('sub_commands', {
2744 'command': 'git push',
Edward Lemur01f4a4f2018-11-03 00:40:38 +00002745 'execution_time': time_time() - before_push,
Edward Lemurfec80c42018-11-01 23:14:14 +00002746 'exit_code': push_returncode,
2747 'arguments': metrics_utils.extract_known_subcommand_args(refspec_opts),
2748 })
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002749
2750 if options.squash:
Aaron Gable289b4312017-09-13 14:06:16 -07002751 regex = re.compile(r'remote:\s+https?://[\w\-\.\+\/#]*/(\d+)\s.*')
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002752 change_numbers = [m.group(1)
2753 for m in map(regex.match, push_stdout.splitlines())
2754 if m]
2755 if len(change_numbers) != 1:
2756 DieWithError(
2757 ('Created|Updated %d issues on Gerrit, but only 1 expected.\n'
Christopher Lamf732cd52017-01-24 12:40:11 +11002758 'Change-Id: %s') % (len(change_numbers), change_id), change_desc)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002759 self.SetIssue(change_numbers[0])
tandrii5d48c322016-08-18 16:19:37 -07002760 self._GitSetBranchConfigValue('gerritsquashhash', ref_to_push)
tandrii88189772016-09-29 04:29:57 -07002761
Andrii Shyshkalov2f727912018-10-15 17:02:33 +00002762 if self.GetIssue() and (reviewers or cc):
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00002763 # GetIssue() is not set in case of non-squash uploads according to tests.
2764 # TODO(agable): non-squash uploads in git cl should be removed.
2765 gerrit_util.AddReviewers(
2766 self._GetGerritHost(),
Andrii Shyshkalovd06cc782018-08-23 17:24:19 +00002767 self._GerritChangeIdentifier(),
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00002768 reviewers, cc,
2769 notify=bool(options.send_mail))
Aaron Gable6dadfbf2017-05-09 14:27:58 -07002770
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002771 return 0
2772
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002773 def _ComputeParent(self, remote, upstream_branch, custom_cl_base, force,
2774 change_desc):
2775 """Computes parent of the generated commit to be uploaded to Gerrit.
2776
2777 Returns revision or a ref name.
2778 """
2779 if custom_cl_base:
2780 # Try to avoid creating additional unintended CLs when uploading, unless
2781 # user wants to take this risk.
2782 local_ref_of_target_remote = self.GetRemoteBranch()[1]
2783 code, _ = RunGitWithCode(['merge-base', '--is-ancestor', custom_cl_base,
2784 local_ref_of_target_remote])
2785 if code == 1:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002786 print('\nWARNING: Manually specified base of this CL `%s` '
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002787 'doesn\'t seem to belong to target remote branch `%s`.\n\n'
2788 'If you proceed with upload, more than 1 CL may be created by '
2789 'Gerrit as a result, in turn confusing or crashing git cl.\n\n'
2790 'If you are certain that specified base `%s` has already been '
2791 'uploaded to Gerrit as another CL, you may proceed.\n' %
2792 (custom_cl_base, local_ref_of_target_remote, custom_cl_base))
2793 if not force:
2794 confirm_or_exit(
2795 'Do you take responsibility for cleaning up potential mess '
2796 'resulting from proceeding with upload?',
2797 action='upload')
2798 return custom_cl_base
2799
Aaron Gablef97e33d2017-03-30 15:44:27 -07002800 if remote != '.':
2801 return self.GetCommonAncestorWithUpstream()
2802
2803 # If our upstream branch is local, we base our squashed commit on its
2804 # squashed version.
2805 upstream_branch_name = scm.GIT.ShortBranchName(upstream_branch)
2806
Aaron Gablef97e33d2017-03-30 15:44:27 -07002807 if upstream_branch_name == 'master':
Aaron Gable0bbd1c22017-05-08 14:37:08 -07002808 return self.GetCommonAncestorWithUpstream()
Aaron Gablef97e33d2017-03-30 15:44:27 -07002809
2810 # Check the squashed hash of the parent.
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002811 # TODO(tandrii): consider checking parent change in Gerrit and using its
2812 # hash if tree hash of latest parent revision (patchset) in Gerrit matches
2813 # the tree hash of the parent branch. The upside is less likely bogus
2814 # requests to reupload parent change just because it's uploadhash is
2815 # missing, yet the downside likely exists, too (albeit unknown to me yet).
Aaron Gablef97e33d2017-03-30 15:44:27 -07002816 parent = RunGit(['config',
2817 'branch.%s.gerritsquashhash' % upstream_branch_name],
2818 error_ok=True).strip()
2819 # Verify that the upstream branch has been uploaded too, otherwise
2820 # Gerrit will create additional CLs when uploading.
2821 if not parent or (RunGitSilent(['rev-parse', upstream_branch + ':']) !=
2822 RunGitSilent(['rev-parse', parent + ':'])):
2823 DieWithError(
2824 '\nUpload upstream branch %s first.\n'
2825 'It is likely that this branch has been rebased since its last '
2826 'upload, so you just need to upload it again.\n'
2827 '(If you uploaded it with --no-squash, then branch dependencies '
2828 'are not supported, and you should reupload with --squash.)'
2829 % upstream_branch_name,
2830 change_desc)
2831 return parent
2832
tandrii@chromium.org8930b3d2016-04-13 14:47:02 +00002833 def _AddChangeIdToCommitMessage(self, options, args):
2834 """Re-commits using the current message, assumes the commit hook is in
2835 place.
2836 """
Andrii Shyshkalovb07575f2018-10-16 06:16:21 +00002837 log_desc = options.message or _create_description_from_log(args)
tandrii@chromium.org8930b3d2016-04-13 14:47:02 +00002838 git_command = ['commit', '--amend', '-m', log_desc]
2839 RunGit(git_command)
Andrii Shyshkalovb07575f2018-10-16 06:16:21 +00002840 new_log_desc = _create_description_from_log(args)
tandrii@chromium.org8930b3d2016-04-13 14:47:02 +00002841 if git_footers.get_footer_change_id(new_log_desc):
vapiera7fbd5a2016-06-16 09:17:49 -07002842 print('git-cl: Added Change-Id to commit message.')
tandrii@chromium.org8930b3d2016-04-13 14:47:02 +00002843 return new_log_desc
2844 else:
tandrii@chromium.orgb067ec52016-05-31 15:24:44 +00002845 DieWithError('ERROR: Gerrit commit-msg hook not installed.')
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002846
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002847 def SetCQState(self, new_state):
2848 """Sets the Commit-Queue label assuming canonical CQ config for Gerrit."""
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002849 vote_map = {
2850 _CQState.NONE: 0,
2851 _CQState.DRY_RUN: 1,
Andrii Shyshkalov18975322017-01-25 16:44:13 +01002852 _CQState.COMMIT: 2,
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002853 }
Aaron Gablefc62f762017-07-17 11:12:07 -07002854 labels = {'Commit-Queue': vote_map[new_state]}
2855 notify = False if new_state == _CQState.DRY_RUN else None
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002856 gerrit_util.SetReview(
2857 self._GetGerritHost(), self._GerritChangeIdentifier(),
2858 labels=labels, notify=notify)
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002859
tandriie113dfd2016-10-11 10:20:12 -07002860 def CannotTriggerTryJobReason(self):
tandrii8c5a3532016-11-04 07:52:02 -07002861 try:
2862 data = self._GetChangeDetail()
Aaron Gablea45ee112016-11-22 15:14:38 -08002863 except GerritChangeNotExists:
2864 return 'Gerrit doesn\'t know about your change %s' % self.GetIssue()
tandrii8c5a3532016-11-04 07:52:02 -07002865
2866 if data['status'] in ('ABANDONED', 'MERGED'):
2867 return 'CL %s is closed' % self.GetIssue()
2868
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002869 def GetTryJobProperties(self, patchset=None):
2870 """Returns dictionary of properties to launch try job."""
tandrii8c5a3532016-11-04 07:52:02 -07002871 data = self._GetChangeDetail(['ALL_REVISIONS'])
2872 patchset = int(patchset or self.GetPatchset())
2873 assert patchset
2874 revision_data = None # Pylint wants it to be defined.
2875 for revision_data in data['revisions'].itervalues():
2876 if int(revision_data['_number']) == patchset:
2877 break
2878 else:
Aaron Gablea45ee112016-11-22 15:14:38 -08002879 raise Exception('Patchset %d is not known in Gerrit change %d' %
tandrii8c5a3532016-11-04 07:52:02 -07002880 (patchset, self.GetIssue()))
2881 return {
2882 'patch_issue': self.GetIssue(),
2883 'patch_set': patchset or self.GetPatchset(),
2884 'patch_project': data['project'],
2885 'patch_storage': 'gerrit',
2886 'patch_ref': revision_data['fetch']['http']['ref'],
2887 'patch_repository_url': revision_data['fetch']['http']['url'],
2888 'patch_gerrit_url': self.GetCodereviewServer(),
2889 }
tandriie113dfd2016-10-11 10:20:12 -07002890
tandriide281ae2016-10-12 06:02:30 -07002891 def GetIssueOwner(self):
tandrii8c5a3532016-11-04 07:52:02 -07002892 return self._GetChangeDetail(['DETAILED_ACCOUNTS'])['owner']['email']
tandriide281ae2016-10-12 06:02:30 -07002893
Edward Lemur707d70b2018-02-07 00:50:14 +01002894 def GetReviewers(self):
2895 details = self._GetChangeDetail(['DETAILED_ACCOUNTS'])
Mohamed Heikal171c0742018-11-09 20:38:51 +00002896 return [r['email'] for r in details['reviewers'].get('REVIEWER', [])]
Edward Lemur707d70b2018-02-07 00:50:14 +01002897
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002898
2899_CODEREVIEW_IMPLEMENTATIONS = {
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002900 'gerrit': _GerritChangelistImpl,
2901}
2902
tandrii@chromium.org013a2802016-03-29 09:52:33 +00002903
iannuccie53c9352016-08-17 14:40:40 -07002904def _add_codereview_issue_select_options(parser, extra=""):
2905 _add_codereview_select_options(parser)
2906
2907 text = ('Operate on this issue number instead of the current branch\'s '
2908 'implicit issue.')
2909 if extra:
2910 text += ' '+extra
2911 parser.add_option('-i', '--issue', type=int, help=text)
2912
2913
2914def _process_codereview_issue_select_options(parser, options):
2915 _process_codereview_select_options(parser, options)
2916 if options.issue is not None and not options.forced_codereview:
2917 parser.error('--issue must be specified with either --rietveld or --gerrit')
2918
2919
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00002920def _add_codereview_select_options(parser):
2921 """Appends --gerrit and --rietveld options to force specific codereview."""
2922 parser.codereview_group = optparse.OptionGroup(
2923 parser, 'EXPERIMENTAL! Codereview override options')
2924 parser.add_option_group(parser.codereview_group)
2925 parser.codereview_group.add_option(
2926 '--gerrit', action='store_true',
2927 help='Force the use of Gerrit for codereview')
2928 parser.codereview_group.add_option(
2929 '--rietveld', action='store_true',
2930 help='Force the use of Rietveld for codereview')
2931
2932
2933def _process_codereview_select_options(parser, options):
Andrii Shyshkalovfeec80e2018-10-16 01:00:47 +00002934 if options.rietveld:
2935 parser.error('--rietveld is no longer supported')
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00002936 options.forced_codereview = None
2937 if options.gerrit:
2938 options.forced_codereview = 'gerrit'
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00002939
2940
tandriif9aefb72016-07-01 09:06:51 -07002941def _get_bug_line_values(default_project, bugs):
2942 """Given default_project and comma separated list of bugs, yields bug line
2943 values.
2944
2945 Each bug can be either:
2946 * a number, which is combined with default_project
2947 * string, which is left as is.
2948
2949 This function may produce more than one line, because bugdroid expects one
2950 project per line.
2951
2952 >>> list(_get_bug_line_values('v8', '123,chromium:789'))
2953 ['v8:123', 'chromium:789']
2954 """
2955 default_bugs = []
2956 others = []
2957 for bug in bugs.split(','):
2958 bug = bug.strip()
2959 if bug:
2960 try:
2961 default_bugs.append(int(bug))
2962 except ValueError:
2963 others.append(bug)
2964
2965 if default_bugs:
2966 default_bugs = ','.join(map(str, default_bugs))
2967 if default_project:
2968 yield '%s:%s' % (default_project, default_bugs)
2969 else:
2970 yield default_bugs
2971 for other in sorted(others):
2972 # Don't bother finding common prefixes, CLs with >2 bugs are very very rare.
2973 yield other
2974
2975
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00002976class ChangeDescription(object):
2977 """Contains a parsed form of the change description."""
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00002978 R_LINE = r'^[ \t]*(TBR|R)[ \t]*=[ \t]*(.*?)[ \t]*$'
bradnelsond975b302016-10-23 12:20:23 -07002979 CC_LINE = r'^[ \t]*(CC)[ \t]*=[ \t]*(.*?)[ \t]*$'
Aaron Gable3a16ed12017-03-23 10:51:55 -07002980 BUG_LINE = r'^[ \t]*(?:(BUG)[ \t]*=|Bug:)[ \t]*(.*?)[ \t]*$'
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01002981 CHERRY_PICK_LINE = r'^\(cherry picked from commit [a-fA-F0-9]{40}\)$'
Nodir Turakulov23b82142017-11-16 11:04:25 -08002982 STRIP_HASH_TAG_PREFIX = r'^(\s*(revert|reland)( "|:)?\s*)*'
2983 BRACKET_HASH_TAG = r'\s*\[([^\[\]]+)\]'
2984 COLON_SEPARATED_HASH_TAG = r'^([a-zA-Z0-9_\- ]+):'
2985 BAD_HASH_TAG_CHUNK = r'[^a-zA-Z0-9]+'
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00002986
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002987 def __init__(self, description):
agable@chromium.org42c20792013-09-12 17:34:49 +00002988 self._description_lines = (description or '').strip().splitlines()
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002989
agable@chromium.org42c20792013-09-12 17:34:49 +00002990 @property # www.logilab.org/ticket/89786
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -08002991 def description(self): # pylint: disable=method-hidden
agable@chromium.org42c20792013-09-12 17:34:49 +00002992 return '\n'.join(self._description_lines)
2993
2994 def set_description(self, desc):
2995 if isinstance(desc, basestring):
2996 lines = desc.splitlines()
2997 else:
2998 lines = [line.rstrip() for line in desc]
2999 while lines and not lines[0]:
3000 lines.pop(0)
3001 while lines and not lines[-1]:
3002 lines.pop(-1)
3003 self._description_lines = lines
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003004
Robert Iannucci6c98dc62017-04-18 11:38:00 -07003005 def update_reviewers(self, reviewers, tbrs, add_owners_to=None, change=None):
3006 """Rewrites the R=/TBR= line(s) as a single line each.
3007
3008 Args:
3009 reviewers (list(str)) - list of additional emails to use for reviewers.
3010 tbrs (list(str)) - list of additional emails to use for TBRs.
3011 add_owners_to (None|'R'|'TBR') - Pass to do an OWNERS lookup for files in
3012 the change that are missing OWNER coverage. If this is not None, you
3013 must also pass a value for `change`.
3014 change (Change) - The Change that should be used for OWNERS lookups.
3015 """
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003016 assert isinstance(reviewers, list), reviewers
Robert Iannucci6c98dc62017-04-18 11:38:00 -07003017 assert isinstance(tbrs, list), tbrs
3018
Robert Iannuccif2708bd2017-04-17 15:49:02 -07003019 assert add_owners_to in (None, 'TBR', 'R'), add_owners_to
Robert Iannuccia28592e2017-04-18 13:14:49 -07003020 assert not add_owners_to or change, add_owners_to
Robert Iannucci6c98dc62017-04-18 11:38:00 -07003021
3022 if not reviewers and not tbrs and not add_owners_to:
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003023 return
Robert Iannucci6c98dc62017-04-18 11:38:00 -07003024
3025 reviewers = set(reviewers)
3026 tbrs = set(tbrs)
3027 LOOKUP = {
3028 'TBR': tbrs,
3029 'R': reviewers,
3030 }
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003031
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003032 # Get the set of R= and TBR= lines and remove them from the description.
agable@chromium.org42c20792013-09-12 17:34:49 +00003033 regexp = re.compile(self.R_LINE)
3034 matches = [regexp.match(line) for line in self._description_lines]
3035 new_desc = [l for i, l in enumerate(self._description_lines)
3036 if not matches[i]]
3037 self.set_description(new_desc)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003038
agable@chromium.org42c20792013-09-12 17:34:49 +00003039 # Construct new unified R= and TBR= lines.
Robert Iannucci6c98dc62017-04-18 11:38:00 -07003040
3041 # First, update tbrs/reviewers with names from the R=/TBR= lines (if any).
agable@chromium.org42c20792013-09-12 17:34:49 +00003042 for match in matches:
3043 if not match:
3044 continue
Robert Iannucci6c98dc62017-04-18 11:38:00 -07003045 LOOKUP[match.group(1)].update(cleanup_list([match.group(2).strip()]))
3046
3047 # Next, maybe fill in OWNERS coverage gaps to either tbrs/reviewers.
Robert Iannuccif2708bd2017-04-17 15:49:02 -07003048 if add_owners_to:
piman@chromium.org336f9122014-09-04 02:16:55 +00003049 owners_db = owners.Database(change.RepositoryRoot(),
Jochen Eisinger72606f82017-04-04 10:44:18 +02003050 fopen=file, os_path=os.path)
piman@chromium.org336f9122014-09-04 02:16:55 +00003051 missing_files = owners_db.files_not_covered_by(change.LocalPaths(),
Robert Iannucci100aa212017-04-18 17:28:26 -07003052 (tbrs | reviewers))
Robert Iannucci6c98dc62017-04-18 11:38:00 -07003053 LOOKUP[add_owners_to].update(
3054 owners_db.reviewers_for(missing_files, change.author_email))
Robert Iannuccif2708bd2017-04-17 15:49:02 -07003055
Robert Iannucci6c98dc62017-04-18 11:38:00 -07003056 # If any folks ended up in both groups, remove them from tbrs.
3057 tbrs -= reviewers
Robert Iannuccif2708bd2017-04-17 15:49:02 -07003058
Robert Iannucci6c98dc62017-04-18 11:38:00 -07003059 new_r_line = 'R=' + ', '.join(sorted(reviewers)) if reviewers else None
3060 new_tbr_line = 'TBR=' + ', '.join(sorted(tbrs)) if tbrs else None
agable@chromium.org42c20792013-09-12 17:34:49 +00003061
3062 # Put the new lines in the description where the old first R= line was.
3063 line_loc = next((i for i, match in enumerate(matches) if match), -1)
3064 if 0 <= line_loc < len(self._description_lines):
3065 if new_tbr_line:
3066 self._description_lines.insert(line_loc, new_tbr_line)
3067 if new_r_line:
3068 self._description_lines.insert(line_loc, new_r_line)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003069 else:
agable@chromium.org42c20792013-09-12 17:34:49 +00003070 if new_r_line:
3071 self.append_footer(new_r_line)
3072 if new_tbr_line:
3073 self.append_footer(new_tbr_line)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003074
Aaron Gable3a16ed12017-03-23 10:51:55 -07003075 def prompt(self, bug=None, git_footer=True):
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003076 """Asks the user to update the description."""
agable@chromium.org42c20792013-09-12 17:34:49 +00003077 self.set_description([
3078 '# Enter a description of the change.',
3079 '# This will be displayed on the codereview site.',
3080 '# The first line will also be used as the subject of the review.',
alancutter@chromium.orgbd1073e2013-06-01 00:34:38 +00003081 '#--------------------This line is 72 characters long'
agable@chromium.org42c20792013-09-12 17:34:49 +00003082 '--------------------',
3083 ] + self._description_lines)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003084
agable@chromium.org42c20792013-09-12 17:34:49 +00003085 regexp = re.compile(self.BUG_LINE)
Jonas Termansend0f79112019-03-22 15:28:26 +00003086 prefix = settings.GetBugPrefix()
agable@chromium.org42c20792013-09-12 17:34:49 +00003087 if not any((regexp.match(line) for line in self._description_lines)):
tandriif9aefb72016-07-01 09:06:51 -07003088 values = list(_get_bug_line_values(prefix, bug or '')) or [prefix]
Aaron Gable3a16ed12017-03-23 10:51:55 -07003089 if git_footer:
3090 self.append_footer('Bug: %s' % ', '.join(values))
3091 else:
3092 for value in values:
3093 self.append_footer('BUG=%s' % value)
tandriif9aefb72016-07-01 09:06:51 -07003094
agable@chromium.org42c20792013-09-12 17:34:49 +00003095 content = gclient_utils.RunEditor(self.description, True,
jbroman@chromium.org615a2622013-05-03 13:20:14 +00003096 git_editor=settings.GetGitEditor())
maruel@chromium.org0e0436a2011-10-25 13:32:41 +00003097 if not content:
3098 DieWithError('Running editor failed')
agable@chromium.org42c20792013-09-12 17:34:49 +00003099 lines = content.splitlines()
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003100
Bruce Dawson2377b012018-01-11 16:46:49 -08003101 # Strip off comments and default inserted "Bug:" line.
3102 clean_lines = [line.rstrip() for line in lines if not
Jonas Termansend0f79112019-03-22 15:28:26 +00003103 (line.startswith('#') or
3104 line.rstrip() == "Bug:" or
3105 line.rstrip() == "Bug: " + prefix)]
agable@chromium.org42c20792013-09-12 17:34:49 +00003106 if not clean_lines:
maruel@chromium.org0e0436a2011-10-25 13:32:41 +00003107 DieWithError('No CL description, aborting')
agable@chromium.org42c20792013-09-12 17:34:49 +00003108 self.set_description(clean_lines)
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00003109
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003110 def append_footer(self, line):
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00003111 """Adds a footer line to the description.
3112
3113 Differentiates legacy "KEY=xxx" footers (used to be called tags) and
3114 Gerrit's footers in the form of "Footer-Key: footer any value" and ensures
3115 that Gerrit footers are always at the end.
3116 """
3117 parsed_footer_line = git_footers.parse_footer(line)
3118 if parsed_footer_line:
3119 # Line is a gerrit footer in the form: Footer-Key: any value.
3120 # Thus, must be appended observing Gerrit footer rules.
3121 self.set_description(
3122 git_footers.add_footer(self.description,
3123 key=parsed_footer_line[0],
3124 value=parsed_footer_line[1]))
3125 return
3126
3127 if not self._description_lines:
3128 self._description_lines.append(line)
3129 return
3130
3131 top_lines, gerrit_footers, _ = git_footers.split_footers(self.description)
3132 if gerrit_footers:
3133 # git_footers.split_footers ensures that there is an empty line before
3134 # actual (gerrit) footers, if any. We have to keep it that way.
3135 assert top_lines and top_lines[-1] == ''
3136 top_lines, separator = top_lines[:-1], top_lines[-1:]
3137 else:
3138 separator = [] # No need for separator if there are no gerrit_footers.
3139
3140 prev_line = top_lines[-1] if top_lines else ''
3141 if (not presubmit_support.Change.TAG_LINE_RE.match(prev_line) or
3142 not presubmit_support.Change.TAG_LINE_RE.match(line)):
3143 top_lines.append('')
3144 top_lines.append(line)
3145 self._description_lines = top_lines + separator + gerrit_footers
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00003146
tandrii99a72f22016-08-17 14:33:24 -07003147 def get_reviewers(self, tbr_only=False):
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003148 """Retrieves the list of reviewers."""
agable@chromium.org42c20792013-09-12 17:34:49 +00003149 matches = [re.match(self.R_LINE, line) for line in self._description_lines]
tandrii99a72f22016-08-17 14:33:24 -07003150 reviewers = [match.group(2).strip()
3151 for match in matches
3152 if match and (not tbr_only or match.group(1).upper() == 'TBR')]
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003153 return cleanup_list(reviewers)
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00003154
bradnelsond975b302016-10-23 12:20:23 -07003155 def get_cced(self):
3156 """Retrieves the list of reviewers."""
3157 matches = [re.match(self.CC_LINE, line) for line in self._description_lines]
3158 cced = [match.group(2).strip() for match in matches if match]
3159 return cleanup_list(cced)
3160
Nodir Turakulov23b82142017-11-16 11:04:25 -08003161 def get_hash_tags(self):
3162 """Extracts and sanitizes a list of Gerrit hashtags."""
3163 subject = (self._description_lines or ('',))[0]
3164 subject = re.sub(
3165 self.STRIP_HASH_TAG_PREFIX, '', subject, flags=re.IGNORECASE)
3166
3167 tags = []
3168 start = 0
3169 bracket_exp = re.compile(self.BRACKET_HASH_TAG)
3170 while True:
3171 m = bracket_exp.match(subject, start)
3172 if not m:
3173 break
3174 tags.append(self.sanitize_hash_tag(m.group(1)))
3175 start = m.end()
3176
3177 if not tags:
3178 # Try "Tag: " prefix.
3179 m = re.match(self.COLON_SEPARATED_HASH_TAG, subject)
3180 if m:
3181 tags.append(self.sanitize_hash_tag(m.group(1)))
3182 return tags
3183
3184 @classmethod
3185 def sanitize_hash_tag(cls, tag):
3186 """Returns a sanitized Gerrit hash tag.
3187
3188 A sanitized hashtag can be used as a git push refspec parameter value.
3189 """
3190 return re.sub(cls.BAD_HASH_TAG_CHUNK, '-', tag).strip('-').lower()
3191
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01003192 def update_with_git_number_footers(self, parent_hash, parent_msg, dest_ref):
3193 """Updates this commit description given the parent.
3194
3195 This is essentially what Gnumbd used to do.
3196 Consult https://goo.gl/WMmpDe for more details.
3197 """
3198 assert parent_msg # No, orphan branch creation isn't supported.
3199 assert parent_hash
3200 assert dest_ref
3201 parent_footer_map = git_footers.parse_footers(parent_msg)
3202 # This will also happily parse svn-position, which GnumbD is no longer
3203 # supporting. While we'd generate correct footers, the verifier plugin
3204 # installed in Gerrit will block such commit (ie git push below will fail).
3205 parent_position = git_footers.get_position(parent_footer_map)
3206
3207 # Cherry-picks may have last line obscuring their prior footers,
3208 # from git_footers perspective. This is also what Gnumbd did.
3209 cp_line = None
3210 if (self._description_lines and
3211 re.match(self.CHERRY_PICK_LINE, self._description_lines[-1])):
3212 cp_line = self._description_lines.pop()
3213
Andrii Shyshkalovde37c012017-07-06 21:06:50 +02003214 top_lines, footer_lines, _ = git_footers.split_footers(self.description)
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01003215
3216 # Original-ify all Cr- footers, to avoid re-lands, cherry-picks, or just
3217 # user interference with actual footers we'd insert below.
Andrii Shyshkalovde37c012017-07-06 21:06:50 +02003218 for i, line in enumerate(footer_lines):
3219 k, v = git_footers.parse_footer(line) or (None, None)
3220 if k and k.startswith('Cr-'):
3221 footer_lines[i] = '%s: %s' % ('Cr-Original-' + k[len('Cr-'):], v)
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01003222
3223 # Add Position and Lineage footers based on the parent.
Andrii Shyshkalovb5effa12016-12-14 19:35:12 +01003224 lineage = list(reversed(parent_footer_map.get('Cr-Branched-From', [])))
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01003225 if parent_position[0] == dest_ref:
3226 # Same branch as parent.
3227 number = int(parent_position[1]) + 1
3228 else:
3229 number = 1 # New branch, and extra lineage.
3230 lineage.insert(0, '%s-%s@{#%d}' % (parent_hash, parent_position[0],
3231 int(parent_position[1])))
3232
Andrii Shyshkalovde37c012017-07-06 21:06:50 +02003233 footer_lines.append('Cr-Commit-Position: %s@{#%d}' % (dest_ref, number))
3234 footer_lines.extend('Cr-Branched-From: %s' % v for v in lineage)
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01003235
3236 self._description_lines = top_lines
3237 if cp_line:
3238 self._description_lines.append(cp_line)
3239 if self._description_lines[-1] != '':
3240 self._description_lines.append('') # Ensure footer separator.
Andrii Shyshkalovde37c012017-07-06 21:06:50 +02003241 self._description_lines.extend(footer_lines)
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01003242
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00003243
Aaron Gablea1bab272017-04-11 16:38:18 -07003244def get_approving_reviewers(props, disapproval=False):
maruel@chromium.orge52678e2013-04-26 18:34:44 +00003245 """Retrieves the reviewers that approved a CL from the issue properties with
3246 messages.
3247
3248 Note that the list may contain reviewers that are not committer, thus are not
3249 considered by the CQ.
Aaron Gablea1bab272017-04-11 16:38:18 -07003250
3251 If disapproval is True, instead returns reviewers who 'not lgtm'd the CL.
maruel@chromium.orge52678e2013-04-26 18:34:44 +00003252 """
Aaron Gablea1bab272017-04-11 16:38:18 -07003253 approval_type = 'disapproval' if disapproval else 'approval'
maruel@chromium.orge52678e2013-04-26 18:34:44 +00003254 return sorted(
3255 set(
3256 message['sender']
3257 for message in props['messages']
Aaron Gablea1bab272017-04-11 16:38:18 -07003258 if message[approval_type] and message['sender'] in props['reviewers']
maruel@chromium.orge52678e2013-04-26 18:34:44 +00003259 )
3260 )
3261
3262
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003263def FindCodereviewSettingsFile(filename='codereview.settings'):
3264 """Finds the given file starting in the cwd and going up.
3265
3266 Only looks up to the top of the repository unless an
3267 'inherit-review-settings-ok' file exists in the root of the repository.
3268 """
3269 inherit_ok_file = 'inherit-review-settings-ok'
3270 cwd = os.getcwd()
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00003271 root = settings.GetRoot()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003272 if os.path.isfile(os.path.join(root, inherit_ok_file)):
3273 root = '/'
3274 while True:
3275 if filename in os.listdir(cwd):
3276 if os.path.isfile(os.path.join(cwd, filename)):
3277 return open(os.path.join(cwd, filename))
3278 if cwd == root:
3279 break
3280 cwd = os.path.dirname(cwd)
3281
3282
3283def LoadCodereviewSettingsFromFile(fileobj):
3284 """Parse a codereview.settings file and updates hooks."""
maruel@chromium.org99ac1c52012-01-16 14:52:12 +00003285 keyvals = gclient_utils.ParseCodereviewSettingsContent(fileobj.read())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003286
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003287 def SetProperty(name, setting, unset_error_ok=False):
3288 fullname = 'rietveld.' + name
3289 if setting in keyvals:
3290 RunGit(['config', fullname, keyvals[setting]])
3291 else:
3292 RunGit(['config', '--unset-all', fullname], error_ok=unset_error_ok)
3293
tandrii48df5812016-10-17 03:55:37 -07003294 if not keyvals.get('GERRIT_HOST', False):
3295 SetProperty('server', 'CODE_REVIEW_SERVER')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003296 # Only server setting is required. Other settings can be absent.
3297 # In that case, we ignore errors raised during option deletion attempt.
3298 SetProperty('cc', 'CC_LIST', unset_error_ok=True)
3299 SetProperty('tree-status-url', 'STATUS', unset_error_ok=True)
3300 SetProperty('viewvc-url', 'VIEW_VC', unset_error_ok=True)
rmistry@google.com90752582014-01-14 21:04:50 +00003301 SetProperty('bug-prefix', 'BUG_PREFIX', unset_error_ok=True)
thestig@chromium.org44202a22014-03-11 19:22:18 +00003302 SetProperty('cpplint-regex', 'LINT_REGEX', unset_error_ok=True)
3303 SetProperty('cpplint-ignore-regex', 'LINT_IGNORE_REGEX', unset_error_ok=True)
rmistry@google.com5626a922015-02-26 14:03:30 +00003304 SetProperty('run-post-upload-hook', 'RUN_POST_UPLOAD_HOOK',
3305 unset_error_ok=True)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003306
ukai@chromium.org7044efc2013-11-28 01:51:21 +00003307 if 'GERRIT_HOST' in keyvals:
ukai@chromium.orge8077812012-02-03 03:41:46 +00003308 RunGit(['config', 'gerrit.host', keyvals['GERRIT_HOST']])
ukai@chromium.orge8077812012-02-03 03:41:46 +00003309
bauerb@chromium.org54b400c2016-01-14 10:08:25 +00003310 if 'GERRIT_SQUASH_UPLOADS' in keyvals:
tandrii8dd81ea2016-06-16 13:24:23 -07003311 RunGit(['config', 'gerrit.squash-uploads',
3312 keyvals['GERRIT_SQUASH_UPLOADS']])
bauerb@chromium.org54b400c2016-01-14 10:08:25 +00003313
tandrii@chromium.org28253532016-04-14 13:46:56 +00003314 if 'GERRIT_SKIP_ENSURE_AUTHENTICATED' in keyvals:
shinyak@chromium.org00dbccd2016-04-15 07:24:43 +00003315 RunGit(['config', 'gerrit.skip-ensure-authenticated',
tandrii@chromium.org28253532016-04-14 13:46:56 +00003316 keyvals['GERRIT_SKIP_ENSURE_AUTHENTICATED']])
3317
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003318 if 'PUSH_URL_CONFIG' in keyvals and 'ORIGIN_URL_CONFIG' in keyvals:
Andrii Shyshkalov18975322017-01-25 16:44:13 +01003319 # should be of the form
3320 # PUSH_URL_CONFIG: url.ssh://gitrw.chromium.org.pushinsteadof
3321 # ORIGIN_URL_CONFIG: http://src.chromium.org/git
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003322 RunGit(['config', keyvals['PUSH_URL_CONFIG'],
3323 keyvals['ORIGIN_URL_CONFIG']])
3324
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003325
joshua.lock@intel.com426f69b2012-08-02 23:41:49 +00003326def urlretrieve(source, destination):
3327 """urllib is broken for SSL connections via a proxy therefore we
3328 can't use urllib.urlretrieve()."""
3329 with open(destination, 'w') as f:
3330 f.write(urllib2.urlopen(source).read())
3331
3332
ukai@chromium.org712d6102013-11-27 00:52:58 +00003333def hasSheBang(fname):
3334 """Checks fname is a #! script."""
3335 with open(fname) as f:
3336 return f.read(2).startswith('#!')
3337
3338
bpastene@chromium.org917f0ff2016-04-05 00:45:30 +00003339# TODO(bpastene) Remove once a cleaner fix to crbug.com/600473 presents itself.
3340def DownloadHooks(*args, **kwargs):
3341 pass
3342
3343
tandrii@chromium.org18630d62016-03-04 12:06:02 +00003344def DownloadGerritHook(force):
3345 """Download and install Gerrit commit-msg hook.
ukai@chromium.org78c4b982012-02-14 02:20:26 +00003346
3347 Args:
3348 force: True to update hooks. False to install hooks if not present.
3349 """
3350 if not settings.GetIsGerrit():
3351 return
ukai@chromium.org712d6102013-11-27 00:52:58 +00003352 src = 'https://gerrit-review.googlesource.com/tools/hooks/commit-msg'
ukai@chromium.org78c4b982012-02-14 02:20:26 +00003353 dst = os.path.join(settings.GetRoot(), '.git', 'hooks', 'commit-msg')
3354 if not os.access(dst, os.X_OK):
3355 if os.path.exists(dst):
3356 if not force:
3357 return
ukai@chromium.org78c4b982012-02-14 02:20:26 +00003358 try:
joshua.lock@intel.com426f69b2012-08-02 23:41:49 +00003359 urlretrieve(src, dst)
ukai@chromium.org712d6102013-11-27 00:52:58 +00003360 if not hasSheBang(dst):
3361 DieWithError('Not a script: %s\n'
3362 'You need to download from\n%s\n'
3363 'into .git/hooks/commit-msg and '
3364 'chmod +x .git/hooks/commit-msg' % (dst, src))
ukai@chromium.org78c4b982012-02-14 02:20:26 +00003365 os.chmod(dst, stat.S_IRUSR | stat.S_IWUSR | stat.S_IXUSR)
3366 except Exception:
3367 if os.path.exists(dst):
3368 os.remove(dst)
ukai@chromium.org712d6102013-11-27 00:52:58 +00003369 DieWithError('\nFailed to download hooks.\n'
3370 'You need to download from\n%s\n'
3371 'into .git/hooks/commit-msg and '
3372 'chmod +x .git/hooks/commit-msg' % src)
ukai@chromium.org78c4b982012-02-14 02:20:26 +00003373
3374
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003375class _GitCookiesChecker(object):
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003376 """Provides facilities for validating and suggesting fixes to .gitcookies."""
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003377
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003378 _GOOGLESOURCE = 'googlesource.com'
3379
3380 def __init__(self):
3381 # Cached list of [host, identity, source], where source is either
3382 # .gitcookies or .netrc.
3383 self._all_hosts = None
3384
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003385 def ensure_configured_gitcookies(self):
3386 """Runs checks and suggests fixes to make git use .gitcookies from default
3387 path."""
3388 default = gerrit_util.CookiesAuthenticator.get_gitcookies_path()
3389 configured_path = RunGitSilent(
3390 ['config', '--global', 'http.cookiefile']).strip()
Andrii Shyshkalov1e250cd2017-05-10 15:39:31 +02003391 configured_path = os.path.expanduser(configured_path)
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003392 if configured_path:
3393 self._ensure_default_gitcookies_path(configured_path, default)
3394 else:
3395 self._configure_gitcookies_path(default)
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003396
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003397 @staticmethod
3398 def _ensure_default_gitcookies_path(configured_path, default_path):
3399 assert configured_path
3400 if configured_path == default_path:
3401 print('git is already configured to use your .gitcookies from %s' %
3402 configured_path)
3403 return
3404
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003405 print('WARNING: You have configured custom path to .gitcookies: %s\n'
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003406 'Gerrit and other depot_tools expect .gitcookies at %s\n' %
3407 (configured_path, default_path))
3408
3409 if not os.path.exists(configured_path):
3410 print('However, your configured .gitcookies file is missing.')
3411 confirm_or_exit('Reconfigure git to use default .gitcookies?',
3412 action='reconfigure')
3413 RunGit(['config', '--global', 'http.cookiefile', default_path])
3414 return
3415
3416 if os.path.exists(default_path):
3417 print('WARNING: default .gitcookies file already exists %s' %
3418 default_path)
3419 DieWithError('Please delete %s manually and re-run git cl creds-check' %
3420 default_path)
3421
3422 confirm_or_exit('Move existing .gitcookies to default location?',
3423 action='move')
3424 shutil.move(configured_path, default_path)
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003425 RunGit(['config', '--global', 'http.cookiefile', default_path])
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003426 print('Moved and reconfigured git to use .gitcookies from %s' %
3427 default_path)
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003428
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003429 @staticmethod
3430 def _configure_gitcookies_path(default_path):
3431 netrc_path = gerrit_util.CookiesAuthenticator.get_netrc_path()
3432 if os.path.exists(netrc_path):
3433 print('You seem to be using outdated .netrc for git credentials: %s' %
3434 netrc_path)
3435 print('This tool will guide you through setting up recommended '
3436 '.gitcookies store for git credentials.\n'
3437 '\n'
3438 'IMPORTANT: If something goes wrong and you decide to go back, do:\n'
3439 ' git config --global --unset http.cookiefile\n'
3440 ' mv %s %s.backup\n\n' % (default_path, default_path))
3441 confirm_or_exit(action='setup .gitcookies')
3442 RunGit(['config', '--global', 'http.cookiefile', default_path])
3443 print('Configured git to use .gitcookies from %s' % default_path)
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003444
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003445 def get_hosts_with_creds(self, include_netrc=False):
3446 if self._all_hosts is None:
3447 a = gerrit_util.CookiesAuthenticator()
3448 self._all_hosts = [
3449 (h, u, s)
3450 for h, u, s in itertools.chain(
3451 ((h, u, '.netrc') for h, (u, _, _) in a.netrc.hosts.iteritems()),
3452 ((h, u, '.gitcookies') for h, (u, _) in a.gitcookies.iteritems())
3453 )
3454 if h.endswith(self._GOOGLESOURCE)
3455 ]
3456
3457 if include_netrc:
3458 return self._all_hosts
3459 return [(h, u, s) for h, u, s in self._all_hosts if s != '.netrc']
3460
3461 def print_current_creds(self, include_netrc=False):
3462 hosts = sorted(self.get_hosts_with_creds(include_netrc=include_netrc))
3463 if not hosts:
3464 print('No Git/Gerrit credentials found')
3465 return
3466 lengths = [max(map(len, (row[i] for row in hosts))) for i in xrange(3)]
3467 header = [('Host', 'User', 'Which file'),
3468 ['=' * l for l in lengths]]
3469 for row in (header + hosts):
3470 print('\t'.join((('%%+%ds' % l) % s)
3471 for l, s in zip(lengths, row)))
3472
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003473 @staticmethod
3474 def _parse_identity(identity):
Lei Zhangd3f769a2017-12-15 15:16:14 -08003475 """Parses identity "git-<username>.domain" into <username> and domain."""
3476 # Special case: usernames that contain ".", which are generally not
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +02003477 # distinguishable from sub-domains. But we do know typical domains:
3478 if identity.endswith('.chromium.org'):
3479 domain = 'chromium.org'
3480 username = identity[:-len('.chromium.org')]
3481 else:
3482 username, domain = identity.split('.', 1)
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003483 if username.startswith('git-'):
3484 username = username[len('git-'):]
3485 return username, domain
3486
3487 def _get_usernames_of_domain(self, domain):
3488 """Returns list of usernames referenced by .gitcookies in a given domain."""
3489 identities_by_domain = {}
3490 for _, identity, _ in self.get_hosts_with_creds():
3491 username, domain = self._parse_identity(identity)
3492 identities_by_domain.setdefault(domain, []).append(username)
3493 return identities_by_domain.get(domain)
3494
3495 def _canonical_git_googlesource_host(self, host):
3496 """Normalizes Gerrit hosts (with '-review') to Git host."""
3497 assert host.endswith(self._GOOGLESOURCE)
3498 # Prefix doesn't include '.' at the end.
3499 prefix = host[:-(1 + len(self._GOOGLESOURCE))]
3500 if prefix.endswith('-review'):
3501 prefix = prefix[:-len('-review')]
3502 return prefix + '.' + self._GOOGLESOURCE
3503
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003504 def _canonical_gerrit_googlesource_host(self, host):
3505 git_host = self._canonical_git_googlesource_host(host)
3506 prefix = git_host.split('.', 1)[0]
3507 return prefix + '-review.' + self._GOOGLESOURCE
3508
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003509 def _get_counterpart_host(self, host):
3510 assert host.endswith(self._GOOGLESOURCE)
3511 git = self._canonical_git_googlesource_host(host)
3512 gerrit = self._canonical_gerrit_googlesource_host(git)
3513 return git if gerrit == host else gerrit
3514
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003515 def has_generic_host(self):
3516 """Returns whether generic .googlesource.com has been configured.
3517
3518 Chrome Infra recommends to use explicit ${host}.googlesource.com instead.
3519 """
3520 for host, _, _ in self.get_hosts_with_creds(include_netrc=False):
3521 if host == '.' + self._GOOGLESOURCE:
3522 return True
3523 return False
3524
3525 def _get_git_gerrit_identity_pairs(self):
3526 """Returns map from canonic host to pair of identities (Git, Gerrit).
3527
3528 One of identities might be None, meaning not configured.
3529 """
3530 host_to_identity_pairs = {}
3531 for host, identity, _ in self.get_hosts_with_creds():
3532 canonical = self._canonical_git_googlesource_host(host)
3533 pair = host_to_identity_pairs.setdefault(canonical, [None, None])
3534 idx = 0 if canonical == host else 1
3535 pair[idx] = identity
3536 return host_to_identity_pairs
3537
3538 def get_partially_configured_hosts(self):
3539 return set(
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003540 (host if i1 else self._canonical_gerrit_googlesource_host(host))
3541 for host, (i1, i2) in self._get_git_gerrit_identity_pairs().iteritems()
3542 if None in (i1, i2) and host != '.' + self._GOOGLESOURCE)
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003543
3544 def get_conflicting_hosts(self):
3545 return set(
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003546 host
3547 for host, (i1, i2) in self._get_git_gerrit_identity_pairs().iteritems()
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003548 if None not in (i1, i2) and i1 != i2)
3549
3550 def get_duplicated_hosts(self):
3551 counters = collections.Counter(h for h, _, _ in self.get_hosts_with_creds())
3552 return set(host for host, count in counters.iteritems() if count > 1)
3553
3554 _EXPECTED_HOST_IDENTITY_DOMAINS = {
3555 'chromium.googlesource.com': 'chromium.org',
3556 'chrome-internal.googlesource.com': 'google.com',
3557 }
3558
3559 def get_hosts_with_wrong_identities(self):
3560 """Finds hosts which **likely** reference wrong identities.
3561
3562 Note: skips hosts which have conflicting identities for Git and Gerrit.
3563 """
3564 hosts = set()
3565 for host, expected in self._EXPECTED_HOST_IDENTITY_DOMAINS.iteritems():
3566 pair = self._get_git_gerrit_identity_pairs().get(host)
3567 if pair and pair[0] == pair[1]:
3568 _, domain = self._parse_identity(pair[0])
3569 if domain != expected:
3570 hosts.add(host)
3571 return hosts
3572
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003573 @staticmethod
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003574 def _format_hosts(hosts, extra_column_func=None):
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003575 hosts = sorted(hosts)
3576 assert hosts
3577 if extra_column_func is None:
3578 extras = [''] * len(hosts)
3579 else:
3580 extras = [extra_column_func(host) for host in hosts]
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003581 tmpl = '%%-%ds %%-%ds' % (max(map(len, hosts)), max(map(len, extras)))
3582 lines = []
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003583 for he in zip(hosts, extras):
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003584 lines.append(tmpl % he)
3585 return lines
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003586
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003587 def _find_problems(self):
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003588 if self.has_generic_host():
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003589 yield ('.googlesource.com wildcard record detected',
3590 ['Chrome Infrastructure team recommends to list full host names '
3591 'explicitly.'],
3592 None)
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003593
3594 dups = self.get_duplicated_hosts()
3595 if dups:
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003596 yield ('The following hosts were defined twice',
3597 self._format_hosts(dups),
3598 None)
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003599
3600 partial = self.get_partially_configured_hosts()
3601 if partial:
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003602 yield ('Credentials should come in pairs for Git and Gerrit hosts. '
3603 'These hosts are missing',
3604 self._format_hosts(partial, lambda host: 'but %s defined' %
3605 self._get_counterpart_host(host)),
3606 partial)
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003607
3608 conflicting = self.get_conflicting_hosts()
3609 if conflicting:
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003610 yield ('The following Git hosts have differing credentials from their '
3611 'Gerrit counterparts',
3612 self._format_hosts(conflicting, lambda host: '%s vs %s' %
3613 tuple(self._get_git_gerrit_identity_pairs()[host])),
3614 conflicting)
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003615
3616 wrong = self.get_hosts_with_wrong_identities()
3617 if wrong:
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003618 yield ('These hosts likely use wrong identity',
3619 self._format_hosts(wrong, lambda host: '%s but %s recommended' %
3620 (self._get_git_gerrit_identity_pairs()[host][0],
3621 self._EXPECTED_HOST_IDENTITY_DOMAINS[host])),
3622 wrong)
3623
3624 def find_and_report_problems(self):
3625 """Returns True if there was at least one problem, else False."""
3626 found = False
3627 bad_hosts = set()
3628 for title, sublines, hosts in self._find_problems():
3629 if not found:
3630 found = True
3631 print('\n\n.gitcookies problem report:\n')
3632 bad_hosts.update(hosts or [])
3633 print(' %s%s' % (title , (':' if sublines else '')))
3634 if sublines:
3635 print()
3636 print(' %s' % '\n '.join(sublines))
3637 print()
3638
3639 if bad_hosts:
3640 assert found
3641 print(' You can manually remove corresponding lines in your %s file and '
3642 'visit the following URLs with correct account to generate '
3643 'correct credential lines:\n' %
3644 gerrit_util.CookiesAuthenticator.get_gitcookies_path())
3645 print(' %s' % '\n '.join(sorted(set(
3646 gerrit_util.CookiesAuthenticator().get_new_password_url(
3647 self._canonical_git_googlesource_host(host))
3648 for host in bad_hosts
3649 ))))
3650 return found
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003651
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003652
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003653@metrics.collector.collect_metrics('git cl creds-check')
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003654def CMDcreds_check(parser, args):
3655 """Checks credentials and suggests changes."""
3656 _, _ = parser.parse_args(args)
3657
Vadim Shtayurab250ec12018-10-04 00:21:08 +00003658 # Code below checks .gitcookies. Abort if using something else.
3659 authn = gerrit_util.Authenticator.get()
3660 if not isinstance(authn, gerrit_util.CookiesAuthenticator):
3661 if isinstance(authn, gerrit_util.GceAuthenticator):
3662 DieWithError(
3663 'This command is not designed for GCE, are you on a bot?\n'
3664 'If you need to run this on GCE, export SKIP_GCE_AUTH_FOR_GIT=1 '
3665 'in your env.')
Aaron Gabled10ca0e2017-09-11 11:24:10 -07003666 DieWithError(
Vadim Shtayurab250ec12018-10-04 00:21:08 +00003667 'This command is not designed for bot environment. It checks '
3668 '~/.gitcookies file not generally used on bots.')
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003669
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003670 checker = _GitCookiesChecker()
3671 checker.ensure_configured_gitcookies()
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003672
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003673 print('Your .netrc and .gitcookies have credentials for these hosts:')
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003674 checker.print_current_creds(include_netrc=True)
3675
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003676 if not checker.find_and_report_problems():
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003677 print('\nNo problems detected in your .gitcookies file.')
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003678 return 0
3679 return 1
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003680
3681
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003682@metrics.collector.collect_metrics('git cl baseurl')
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00003683def CMDbaseurl(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00003684 """Gets or sets base-url for this branch."""
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00003685 branchref = RunGit(['symbolic-ref', 'HEAD']).strip()
3686 branch = ShortBranchName(branchref)
3687 _, args = parser.parse_args(args)
3688 if not args:
vapiera7fbd5a2016-06-16 09:17:49 -07003689 print('Current base-url:')
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00003690 return RunGit(['config', 'branch.%s.base-url' % branch],
3691 error_ok=False).strip()
3692 else:
vapiera7fbd5a2016-06-16 09:17:49 -07003693 print('Setting base-url to %s' % args[0])
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00003694 return RunGit(['config', 'branch.%s.base-url' % branch, args[0]],
3695 error_ok=False).strip()
3696
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00003697def color_for_status(status):
3698 """Maps a Changelist status to color, for CMDstatus and other tools."""
3699 return {
Aaron Gable9ab38c62017-04-06 14:36:33 -07003700 'unsent': Fore.YELLOW,
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00003701 'waiting': Fore.BLUE,
3702 'reply': Fore.YELLOW,
Aaron Gable9ab38c62017-04-06 14:36:33 -07003703 'not lgtm': Fore.RED,
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00003704 'lgtm': Fore.GREEN,
3705 'commit': Fore.MAGENTA,
3706 'closed': Fore.CYAN,
3707 'error': Fore.WHITE,
3708 }.get(status, Fore.WHITE)
3709
tandrii@chromium.org04ea8462016-04-25 19:51:21 +00003710
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003711def get_cl_statuses(changes, fine_grained, max_processes=None):
3712 """Returns a blocking iterable of (cl, status) for given branches.
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00003713
3714 If fine_grained is true, this will fetch CL statuses from the server.
3715 Otherwise, simply indicate if there's a matching url for the given branches.
3716
3717 If max_processes is specified, it is used as the maximum number of processes
3718 to spawn to fetch CL status from the server. Otherwise 1 process per branch is
3719 spawned.
calamity@chromium.orgcf197482016-04-29 20:15:53 +00003720
3721 See GetStatus() for a list of possible statuses.
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00003722 """
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01003723 if not changes:
3724 raise StopIteration()
calamity@chromium.orgcf197482016-04-29 20:15:53 +00003725
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01003726 if not fine_grained:
3727 # Fast path which doesn't involve querying codereview servers.
Aaron Gablea1bab272017-04-11 16:38:18 -07003728 # Do not use get_approving_reviewers(), since it requires an HTTP request.
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003729 for cl in changes:
3730 yield (cl, 'waiting' if cl.GetIssueURL() else 'error')
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01003731 return
3732
3733 # First, sort out authentication issues.
3734 logging.debug('ensuring credentials exist')
3735 for cl in changes:
3736 cl.EnsureAuthenticated(force=False, refresh=True)
3737
3738 def fetch(cl):
3739 try:
3740 return (cl, cl.GetStatus())
3741 except:
3742 # See http://crbug.com/629863.
Andrii Shyshkalov98824232018-04-19 11:37:15 -07003743 logging.exception('failed to fetch status for cl %s:', cl.GetIssue())
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01003744 raise
3745
3746 threads_count = len(changes)
3747 if max_processes:
3748 threads_count = max(1, min(threads_count, max_processes))
3749 logging.debug('querying %d CLs using %d threads', len(changes), threads_count)
3750
3751 pool = ThreadPool(threads_count)
3752 fetched_cls = set()
3753 try:
3754 it = pool.imap_unordered(fetch, changes).__iter__()
3755 while True:
3756 try:
3757 cl, status = it.next(timeout=5)
3758 except multiprocessing.TimeoutError:
3759 break
3760 fetched_cls.add(cl)
3761 yield cl, status
3762 finally:
3763 pool.close()
3764
3765 # Add any branches that failed to fetch.
3766 for cl in set(changes) - fetched_cls:
3767 yield (cl, 'error')
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00003768
rmistry@google.com2dd99862015-06-22 12:22:18 +00003769
3770def upload_branch_deps(cl, args):
3771 """Uploads CLs of local branches that are dependents of the current branch.
3772
3773 If the local branch dependency tree looks like:
3774 test1 -> test2.1 -> test3.1
3775 -> test3.2
3776 -> test2.2 -> test3.3
3777
3778 and you run "git cl upload --dependencies" from test1 then "git cl upload" is
3779 run on the dependent branches in this order:
3780 test2.1, test3.1, test3.2, test2.2, test3.3
3781
3782 Note: This function does not rebase your local dependent branches. Use it when
3783 you make a change to the parent branch that will not conflict with its
3784 dependent branches, and you would like their dependencies updated in
3785 Rietveld.
3786 """
3787 if git_common.is_dirty_git_tree('upload-branch-deps'):
3788 return 1
3789
3790 root_branch = cl.GetBranch()
3791 if root_branch is None:
3792 DieWithError('Can\'t find dependent branches from detached HEAD state. '
3793 'Get on a branch!')
Andrii Shyshkalov9f274432018-10-15 16:40:23 +00003794 if not cl.GetIssue():
rmistry@google.com2dd99862015-06-22 12:22:18 +00003795 DieWithError('Current branch does not have an uploaded CL. We cannot set '
3796 'patchset dependencies without an uploaded CL.')
3797
3798 branches = RunGit(['for-each-ref',
3799 '--format=%(refname:short) %(upstream:short)',
3800 'refs/heads'])
3801 if not branches:
3802 print('No local branches found.')
3803 return 0
3804
3805 # Create a dictionary of all local branches to the branches that are dependent
3806 # on it.
3807 tracked_to_dependents = collections.defaultdict(list)
3808 for b in branches.splitlines():
3809 tokens = b.split()
3810 if len(tokens) == 2:
3811 branch_name, tracked = tokens
3812 tracked_to_dependents[tracked].append(branch_name)
3813
vapiera7fbd5a2016-06-16 09:17:49 -07003814 print()
3815 print('The dependent local branches of %s are:' % root_branch)
rmistry@google.com2dd99862015-06-22 12:22:18 +00003816 dependents = []
3817 def traverse_dependents_preorder(branch, padding=''):
3818 dependents_to_process = tracked_to_dependents.get(branch, [])
3819 padding += ' '
3820 for dependent in dependents_to_process:
vapiera7fbd5a2016-06-16 09:17:49 -07003821 print('%s%s' % (padding, dependent))
rmistry@google.com2dd99862015-06-22 12:22:18 +00003822 dependents.append(dependent)
3823 traverse_dependents_preorder(dependent, padding)
3824 traverse_dependents_preorder(root_branch)
vapiera7fbd5a2016-06-16 09:17:49 -07003825 print()
rmistry@google.com2dd99862015-06-22 12:22:18 +00003826
3827 if not dependents:
vapiera7fbd5a2016-06-16 09:17:49 -07003828 print('There are no dependent local branches for %s' % root_branch)
rmistry@google.com2dd99862015-06-22 12:22:18 +00003829 return 0
3830
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01003831 confirm_or_exit('This command will checkout all dependent branches and run '
3832 '"git cl upload".', action='continue')
rmistry@google.com2dd99862015-06-22 12:22:18 +00003833
rmistry@google.com2dd99862015-06-22 12:22:18 +00003834 # Record all dependents that failed to upload.
3835 failures = {}
3836 # Go through all dependents, checkout the branch and upload.
3837 try:
3838 for dependent_branch in dependents:
vapiera7fbd5a2016-06-16 09:17:49 -07003839 print()
3840 print('--------------------------------------')
3841 print('Running "git cl upload" from %s:' % dependent_branch)
rmistry@google.com2dd99862015-06-22 12:22:18 +00003842 RunGit(['checkout', '-q', dependent_branch])
vapiera7fbd5a2016-06-16 09:17:49 -07003843 print()
rmistry@google.com2dd99862015-06-22 12:22:18 +00003844 try:
3845 if CMDupload(OptionParser(), args) != 0:
vapiera7fbd5a2016-06-16 09:17:49 -07003846 print('Upload failed for %s!' % dependent_branch)
rmistry@google.com2dd99862015-06-22 12:22:18 +00003847 failures[dependent_branch] = 1
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -08003848 except: # pylint: disable=bare-except
rmistry@google.com2dd99862015-06-22 12:22:18 +00003849 failures[dependent_branch] = 1
vapiera7fbd5a2016-06-16 09:17:49 -07003850 print()
rmistry@google.com2dd99862015-06-22 12:22:18 +00003851 finally:
3852 # Swap back to the original root branch.
3853 RunGit(['checkout', '-q', root_branch])
3854
vapiera7fbd5a2016-06-16 09:17:49 -07003855 print()
3856 print('Upload complete for dependent branches!')
rmistry@google.com2dd99862015-06-22 12:22:18 +00003857 for dependent_branch in dependents:
3858 upload_status = 'failed' if failures.get(dependent_branch) else 'succeeded'
vapiera7fbd5a2016-06-16 09:17:49 -07003859 print(' %s : %s' % (dependent_branch, upload_status))
3860 print()
rmistry@google.com2dd99862015-06-22 12:22:18 +00003861
3862 return 0
3863
3864
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003865@metrics.collector.collect_metrics('git cl archive')
kmarshall3bff56b2016-06-06 18:31:47 -07003866def CMDarchive(parser, args):
3867 """Archives and deletes branches associated with closed changelists."""
3868 parser.add_option(
3869 '-j', '--maxjobs', action='store', type=int,
kmarshall9249e012016-08-23 12:02:16 -07003870 help='The maximum number of jobs to use when retrieving review status.')
kmarshall3bff56b2016-06-06 18:31:47 -07003871 parser.add_option(
3872 '-f', '--force', action='store_true',
3873 help='Bypasses the confirmation prompt.')
kmarshall9249e012016-08-23 12:02:16 -07003874 parser.add_option(
3875 '-d', '--dry-run', action='store_true',
3876 help='Skip the branch tagging and removal steps.')
3877 parser.add_option(
3878 '-t', '--notags', action='store_true',
3879 help='Do not tag archived branches. '
3880 'Note: local commit history may be lost.')
kmarshall3bff56b2016-06-06 18:31:47 -07003881
3882 auth.add_auth_options(parser)
3883 options, args = parser.parse_args(args)
3884 if args:
3885 parser.error('Unsupported args: %s' % ' '.join(args))
3886 auth_config = auth.extract_auth_config_from_options(options)
3887
3888 branches = RunGit(['for-each-ref', '--format=%(refname)', 'refs/heads'])
3889 if not branches:
3890 return 0
3891
vapiera7fbd5a2016-06-16 09:17:49 -07003892 print('Finding all branches associated with closed issues...')
kmarshall3bff56b2016-06-06 18:31:47 -07003893 changes = [Changelist(branchref=b, auth_config=auth_config)
3894 for b in branches.splitlines()]
3895 alignment = max(5, max(len(c.GetBranch()) for c in changes))
3896 statuses = get_cl_statuses(changes,
3897 fine_grained=True,
3898 max_processes=options.maxjobs)
3899 proposal = [(cl.GetBranch(),
3900 'git-cl-archived-%s-%s' % (cl.GetIssue(), cl.GetBranch()))
3901 for cl, status in statuses
Andrii Shyshkalov51bdf8c2018-10-18 01:07:58 +00003902 if status in ('closed', 'rietveld-not-supported')]
kmarshall3bff56b2016-06-06 18:31:47 -07003903 proposal.sort()
3904
3905 if not proposal:
vapiera7fbd5a2016-06-16 09:17:49 -07003906 print('No branches with closed codereview issues found.')
kmarshall3bff56b2016-06-06 18:31:47 -07003907 return 0
3908
3909 current_branch = GetCurrentBranch()
3910
vapiera7fbd5a2016-06-16 09:17:49 -07003911 print('\nBranches with closed issues that will be archived:\n')
kmarshall9249e012016-08-23 12:02:16 -07003912 if options.notags:
3913 for next_item in proposal:
3914 print(' ' + next_item[0])
3915 else:
3916 print('%*s | %s' % (alignment, 'Branch name', 'Archival tag name'))
3917 for next_item in proposal:
3918 print('%*s %s' % (alignment, next_item[0], next_item[1]))
kmarshall3bff56b2016-06-06 18:31:47 -07003919
kmarshall9249e012016-08-23 12:02:16 -07003920 # Quit now on precondition failure or if instructed by the user, either
3921 # via an interactive prompt or by command line flags.
3922 if options.dry_run:
3923 print('\nNo changes were made (dry run).\n')
3924 return 0
3925 elif any(branch == current_branch for branch, _ in proposal):
kmarshall3bff56b2016-06-06 18:31:47 -07003926 print('You are currently on a branch \'%s\' which is associated with a '
3927 'closed codereview issue, so archive cannot proceed. Please '
3928 'checkout another branch and run this command again.' %
3929 current_branch)
3930 return 1
kmarshall9249e012016-08-23 12:02:16 -07003931 elif not options.force:
sergiyb4a5ecbe2016-06-20 09:46:00 -07003932 answer = ask_for_data('\nProceed with deletion (Y/n)? ').lower()
3933 if answer not in ('y', ''):
vapiera7fbd5a2016-06-16 09:17:49 -07003934 print('Aborted.')
kmarshall3bff56b2016-06-06 18:31:47 -07003935 return 1
3936
3937 for branch, tagname in proposal:
kmarshall9249e012016-08-23 12:02:16 -07003938 if not options.notags:
3939 RunGit(['tag', tagname, branch])
kmarshall3bff56b2016-06-06 18:31:47 -07003940 RunGit(['branch', '-D', branch])
kmarshall9249e012016-08-23 12:02:16 -07003941
vapiera7fbd5a2016-06-16 09:17:49 -07003942 print('\nJob\'s done!')
kmarshall3bff56b2016-06-06 18:31:47 -07003943
3944 return 0
3945
3946
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003947@metrics.collector.collect_metrics('git cl status')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003948def CMDstatus(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00003949 """Show status of changelists.
3950
3951 Colors are used to tell the state of the CL unless --fast is used:
jsbell@chromium.orgaeab41a2013-12-10 20:01:22 +00003952 - Blue waiting for review
Aaron Gable9ab38c62017-04-06 14:36:33 -07003953 - Yellow waiting for you to reply to review, or not yet sent
jsbell@chromium.orgaeab41a2013-12-10 20:01:22 +00003954 - Green LGTM'ed
Aaron Gable9ab38c62017-04-06 14:36:33 -07003955 - Red 'not LGTM'ed
jsbell@chromium.orgaeab41a2013-12-10 20:01:22 +00003956 - Magenta in the commit queue
3957 - Cyan was committed, branch can be deleted
Aaron Gable9ab38c62017-04-06 14:36:33 -07003958 - White error, or unknown status
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00003959
3960 Also see 'git cl comments'.
3961 """
Alan Cuttera3be9a52019-03-04 18:50:33 +00003962 parser.add_option(
3963 '--no-branch-color',
3964 action='store_true',
3965 help='Disable colorized branch names')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003966 parser.add_option('--field',
phajdan.jr289d03e2016-08-16 08:21:06 -07003967 help='print only specific field (desc|id|patch|status|url)')
maruel@chromium.org1033efd2013-07-23 23:25:09 +00003968 parser.add_option('-f', '--fast', action='store_true',
3969 help='Do not retrieve review status')
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00003970 parser.add_option(
3971 '-j', '--maxjobs', action='store', type=int,
3972 help='The maximum number of jobs to use when retrieving review status')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00003973
3974 auth.add_auth_options(parser)
iannuccie53c9352016-08-17 14:40:40 -07003975 _add_codereview_issue_select_options(
3976 parser, 'Must be in conjunction with --field.')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00003977 options, args = parser.parse_args(args)
iannuccie53c9352016-08-17 14:40:40 -07003978 _process_codereview_issue_select_options(parser, options)
maruel@chromium.org39c0b222013-08-17 16:57:01 +00003979 if args:
3980 parser.error('Unsupported args: %s' % args)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00003981 auth_config = auth.extract_auth_config_from_options(options)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003982
iannuccie53c9352016-08-17 14:40:40 -07003983 if options.issue is not None and not options.field:
3984 parser.error('--field must be specified with --issue')
iannucci3c972b92016-08-17 13:24:10 -07003985
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003986 if options.field:
iannucci3c972b92016-08-17 13:24:10 -07003987 cl = Changelist(auth_config=auth_config, issue=options.issue,
3988 codereview=options.forced_codereview)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003989 if options.field.startswith('desc'):
vapiera7fbd5a2016-06-16 09:17:49 -07003990 print(cl.GetDescription())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003991 elif options.field == 'id':
3992 issueid = cl.GetIssue()
3993 if issueid:
vapiera7fbd5a2016-06-16 09:17:49 -07003994 print(issueid)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003995 elif options.field == 'patch':
Aaron Gablee8856ee2017-12-07 12:41:46 -08003996 patchset = cl.GetMostRecentPatchset()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003997 if patchset:
vapiera7fbd5a2016-06-16 09:17:49 -07003998 print(patchset)
phajdan.jr289d03e2016-08-16 08:21:06 -07003999 elif options.field == 'status':
4000 print(cl.GetStatus())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004001 elif options.field == 'url':
4002 url = cl.GetIssueURL()
4003 if url:
vapiera7fbd5a2016-06-16 09:17:49 -07004004 print(url)
maruel@chromium.orge25c75b2013-07-23 18:30:56 +00004005 return 0
4006
4007 branches = RunGit(['for-each-ref', '--format=%(refname)', 'refs/heads'])
4008 if not branches:
4009 print('No local branch found.')
4010 return 0
4011
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00004012 changes = [
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004013 Changelist(branchref=b, auth_config=auth_config)
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00004014 for b in branches.splitlines()]
vapiera7fbd5a2016-06-16 09:17:49 -07004015 print('Branches associated with reviews:')
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00004016 output = get_cl_statuses(changes,
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00004017 fine_grained=not options.fast,
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00004018 max_processes=options.maxjobs)
maruel@chromium.org1033efd2013-07-23 23:25:09 +00004019
Daniel McArdlea23bf592019-02-12 00:25:12 +00004020 current_branch = GetCurrentBranch()
4021
4022 def FormatBranchName(branch, colorize=False):
4023 """Simulates 'git branch' behavior. Colorizes and prefixes branch name with
4024 an asterisk when it is the current branch."""
4025
4026 asterisk = ""
4027 color = Fore.RESET
4028 if branch == current_branch:
4029 asterisk = "* "
4030 color = Fore.GREEN
4031 branch_name = ShortBranchName(branch)
4032
4033 if colorize:
4034 return asterisk + color + branch_name + Fore.RESET
Daniel McArdle452a49f2019-02-14 17:28:31 +00004035 return asterisk + branch_name
4036
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00004037 branch_statuses = {}
Daniel McArdlea23bf592019-02-12 00:25:12 +00004038
4039 alignment = max(5, max(len(FormatBranchName(c.GetBranch())) for c in changes))
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00004040 for cl in sorted(changes, key=lambda c: c.GetBranch()):
4041 branch = cl.GetBranch()
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00004042 while branch not in branch_statuses:
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00004043 c, status = output.next()
4044 branch_statuses[c.GetBranch()] = status
4045 status = branch_statuses.pop(branch)
4046 url = cl.GetIssueURL()
4047 if url and (not status or status == 'error'):
4048 # The issue probably doesn't exist anymore.
4049 url += ' (broken)'
4050
nodir@chromium.orga6de1f42015-06-10 04:23:17 +00004051 color = color_for_status(status)
maruel@chromium.org885f6512013-07-27 02:17:26 +00004052 reset = Fore.RESET
iannucci@chromium.org596cd5c2016-04-04 21:34:39 +00004053 if not setup_color.IS_TTY:
maruel@chromium.org885f6512013-07-27 02:17:26 +00004054 color = ''
4055 reset = ''
nodir@chromium.orga6de1f42015-06-10 04:23:17 +00004056 status_str = '(%s)' % status if status else ''
Daniel McArdle452a49f2019-02-14 17:28:31 +00004057
Alan Cuttera3be9a52019-03-04 18:50:33 +00004058 branch_display = FormatBranchName(branch)
4059 padding = ' ' * (alignment - len(branch_display))
4060 if not options.no_branch_color:
4061 branch_display = FormatBranchName(branch, colorize=True)
Daniel McArdle452a49f2019-02-14 17:28:31 +00004062
Alan Cuttera3be9a52019-03-04 18:50:33 +00004063 print(' %s : %s%s %s%s' % (padding + branch_display, color, url,
4064 status_str, reset))
Andrii Shyshkalovd0e1d9d2017-01-24 17:10:51 +01004065
vapiera7fbd5a2016-06-16 09:17:49 -07004066 print()
Daniel McArdlea23bf592019-02-12 00:25:12 +00004067 print('Current branch: %s' % current_branch)
Andrii Shyshkalovd0e1d9d2017-01-24 17:10:51 +01004068 for cl in changes:
Daniel McArdlea23bf592019-02-12 00:25:12 +00004069 if cl.GetBranch() == current_branch:
Andrii Shyshkalovd0e1d9d2017-01-24 17:10:51 +01004070 break
dpranke@chromium.orgee87f582015-07-31 18:46:25 +00004071 if not cl.GetIssue():
vapiera7fbd5a2016-06-16 09:17:49 -07004072 print('No issue assigned.')
dpranke@chromium.orgee87f582015-07-31 18:46:25 +00004073 return 0
vapiera7fbd5a2016-06-16 09:17:49 -07004074 print('Issue number: %s (%s)' % (cl.GetIssue(), cl.GetIssueURL()))
maruel@chromium.org85616e02014-07-28 15:37:55 +00004075 if not options.fast:
vapiera7fbd5a2016-06-16 09:17:49 -07004076 print('Issue description:')
4077 print(cl.GetDescription(pretty=True))
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004078 return 0
4079
4080
maruel@chromium.org39c0b222013-08-17 16:57:01 +00004081def colorize_CMDstatus_doc():
4082 """To be called once in main() to add colors to git cl status help."""
4083 colors = [i for i in dir(Fore) if i[0].isupper()]
4084
4085 def colorize_line(line):
4086 for color in colors:
4087 if color in line.upper():
Quinten Yearsley0c62da92017-05-31 13:39:42 -07004088 # Extract whitespace first and the leading '-'.
maruel@chromium.org39c0b222013-08-17 16:57:01 +00004089 indent = len(line) - len(line.lstrip(' ')) + 1
4090 return line[:indent] + getattr(Fore, color) + line[indent:] + Fore.RESET
4091 return line
4092
4093 lines = CMDstatus.__doc__.splitlines()
4094 CMDstatus.__doc__ = '\n'.join(colorize_line(l) for l in lines)
4095
4096
phajdan.jre328cf92016-08-22 04:12:17 -07004097def write_json(path, contents):
Stefan Zager1306bd02017-06-22 19:26:46 -07004098 if path == '-':
4099 json.dump(contents, sys.stdout)
4100 else:
4101 with open(path, 'w') as f:
4102 json.dump(contents, f)
phajdan.jre328cf92016-08-22 04:12:17 -07004103
4104
maruel@chromium.org0633fb42013-08-16 20:06:14 +00004105@subcommand.usage('[issue_number]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004106@metrics.collector.collect_metrics('git cl issue')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004107def CMDissue(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004108 """Sets or displays the current code review issue number.
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004109
4110 Pass issue number 0 to clear the current issue.
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004111 """
dnj@chromium.org406c4402015-03-03 17:22:28 +00004112 parser.add_option('-r', '--reverse', action='store_true',
4113 help='Lookup the branch(es) for the specified issues. If '
4114 'no issues are specified, all branches with mapped '
4115 'issues will be listed.')
Stefan Zager1306bd02017-06-22 19:26:46 -07004116 parser.add_option('--json',
4117 help='Path to JSON output file, or "-" for stdout.')
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00004118 _add_codereview_select_options(parser)
dnj@chromium.org406c4402015-03-03 17:22:28 +00004119 options, args = parser.parse_args(args)
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00004120 _process_codereview_select_options(parser, options)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004121
dnj@chromium.org406c4402015-03-03 17:22:28 +00004122 if options.reverse:
4123 branches = RunGit(['for-each-ref', 'refs/heads',
Aaron Gablead64abd2017-12-04 09:49:13 -08004124 '--format=%(refname)']).splitlines()
dnj@chromium.org406c4402015-03-03 17:22:28 +00004125 # Reverse issue lookup.
4126 issue_branch_map = {}
Daniel Bratellb56a43a2018-09-06 15:49:03 +00004127
4128 git_config = {}
4129 for config in RunGit(['config', '--get-regexp',
4130 r'branch\..*issue']).splitlines():
4131 name, _space, val = config.partition(' ')
4132 git_config[name] = val
4133
dnj@chromium.org406c4402015-03-03 17:22:28 +00004134 for branch in branches:
Daniel Bratellb56a43a2018-09-06 15:49:03 +00004135 for cls in _CODEREVIEW_IMPLEMENTATIONS.values():
4136 config_key = _git_branch_config_key(ShortBranchName(branch),
4137 cls.IssueConfigKey())
4138 issue = git_config.get(config_key)
4139 if issue:
4140 issue_branch_map.setdefault(int(issue), []).append(branch)
dnj@chromium.org406c4402015-03-03 17:22:28 +00004141 if not args:
4142 args = sorted(issue_branch_map.iterkeys())
phajdan.jre328cf92016-08-22 04:12:17 -07004143 result = {}
dnj@chromium.org406c4402015-03-03 17:22:28 +00004144 for issue in args:
Lei Zhang5a368d42019-03-25 23:18:19 +00004145 try:
4146 issue_num = int(issue)
4147 except ValueError:
4148 print('ERROR cannot parse issue number: %s' % issue, file=sys.stderr)
dnj@chromium.org406c4402015-03-03 17:22:28 +00004149 continue
Lei Zhang5a368d42019-03-25 23:18:19 +00004150 result[issue_num] = issue_branch_map.get(issue_num)
vapiera7fbd5a2016-06-16 09:17:49 -07004151 print('Branch for issue number %s: %s' % (
Lei Zhang5a368d42019-03-25 23:18:19 +00004152 issue, ', '.join(issue_branch_map.get(issue_num) or ('None',))))
phajdan.jre328cf92016-08-22 04:12:17 -07004153 if options.json:
4154 write_json(options.json, result)
Aaron Gable78753da2017-06-15 10:35:49 -07004155 return 0
4156
4157 if len(args) > 0:
4158 issue = ParseIssueNumberArgument(args[0], options.forced_codereview)
4159 if not issue.valid:
4160 DieWithError('Pass a url or number to set the issue, 0 to unset it, '
4161 'or no argument to list it.\n'
4162 'Maybe you want to run git cl status?')
4163 cl = Changelist(codereview=issue.codereview)
4164 cl.SetIssue(issue.issue)
dnj@chromium.org406c4402015-03-03 17:22:28 +00004165 else:
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00004166 cl = Changelist(codereview=options.forced_codereview)
Aaron Gable78753da2017-06-15 10:35:49 -07004167 print('Issue number: %s (%s)' % (cl.GetIssue(), cl.GetIssueURL()))
4168 if options.json:
4169 write_json(options.json, {
4170 'issue': cl.GetIssue(),
4171 'issue_url': cl.GetIssueURL(),
4172 })
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004173 return 0
4174
4175
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004176@metrics.collector.collect_metrics('git cl comments')
maruel@chromium.org9977a2e2012-06-06 22:30:56 +00004177def CMDcomments(parser, args):
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00004178 """Shows or posts review comments for any changelist."""
4179 parser.add_option('-a', '--add-comment', dest='comment',
4180 help='comment to add to an issue')
Sergiy Byelozyorovcb629a42018-10-28 19:20:39 +00004181 parser.add_option('-p', '--publish', action='store_true',
4182 help='marks CL as ready and sends comment to reviewers')
Andrii Shyshkalov0d6b46e2017-03-17 22:23:22 +01004183 parser.add_option('-i', '--issue', dest='issue',
4184 help='review issue id (defaults to current issue). '
4185 'If given, requires --rietveld or --gerrit')
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07004186 parser.add_option('-m', '--machine-readable', dest='readable',
4187 action='store_false', default=True,
4188 help='output comments in a format compatible with '
4189 'editor parsing')
smut@google.comc85ac942015-09-15 16:34:43 +00004190 parser.add_option('-j', '--json-file',
Stefan Zager1306bd02017-06-22 19:26:46 -07004191 help='File to write JSON summary to, or "-" for stdout')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004192 auth.add_auth_options(parser)
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01004193 _add_codereview_select_options(parser)
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00004194 options, args = parser.parse_args(args)
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01004195 _process_codereview_select_options(parser, options)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004196 auth_config = auth.extract_auth_config_from_options(options)
maruel@chromium.org9977a2e2012-06-06 22:30:56 +00004197
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00004198 issue = None
4199 if options.issue:
4200 try:
4201 issue = int(options.issue)
4202 except ValueError:
4203 DieWithError('A review issue id is expected to be a number')
4204
Andrii Shyshkalov642641d2018-10-16 05:54:41 +00004205 cl = Changelist(issue=issue, codereview='gerrit', auth_config=auth_config)
4206
4207 if not cl.IsGerrit():
4208 parser.error('rietveld is not supported')
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00004209
4210 if options.comment:
Sergiy Byelozyorovcb629a42018-10-28 19:20:39 +00004211 cl.AddComment(options.comment, options.publish)
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00004212 return 0
4213
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07004214 summary = sorted(cl.GetCommentsSummary(readable=options.readable),
4215 key=lambda c: c.date)
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01004216 for comment in summary:
4217 if comment.disapproval:
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00004218 color = Fore.RED
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01004219 elif comment.approval:
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00004220 color = Fore.GREEN
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01004221 elif comment.sender == cl.GetIssueOwner():
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00004222 color = Fore.MAGENTA
Quinten Yearsley0e617c02019-02-20 00:37:03 +00004223 elif comment.autogenerated:
4224 color = Fore.CYAN
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00004225 else:
4226 color = Fore.BLUE
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01004227 print('\n%s%s %s%s\n%s' % (
4228 color,
4229 comment.date.strftime('%Y-%m-%d %H:%M:%S UTC'),
4230 comment.sender,
4231 Fore.RESET,
4232 '\n'.join(' ' + l for l in comment.message.strip().splitlines())))
4233
smut@google.comc85ac942015-09-15 16:34:43 +00004234 if options.json_file:
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01004235 def pre_serialize(c):
4236 dct = c.__dict__.copy()
4237 dct['date'] = dct['date'].strftime('%Y-%m-%d %H:%M:%S.%f')
4238 return dct
Leszek Swirski45b20c42018-09-17 17:05:26 +00004239 write_json(options.json_file, map(pre_serialize, summary))
maruel@chromium.org9977a2e2012-06-06 22:30:56 +00004240 return 0
4241
4242
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00004243@subcommand.usage('[codereview url or issue id]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004244@metrics.collector.collect_metrics('git cl description')
rsesek@chromium.orgeec76592013-05-20 16:27:57 +00004245def CMDdescription(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004246 """Brings up the editor for the current CL's description."""
smut@google.com34fb6b12015-07-13 20:03:26 +00004247 parser.add_option('-d', '--display', action='store_true',
4248 help='Display the description instead of opening an editor')
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00004249 parser.add_option('-n', '--new-description',
dnjba1b0f32016-09-02 12:37:42 -07004250 help='New description to set for this issue (- for stdin, '
4251 '+ to load from local commit HEAD)')
dsansomee2d6fd92016-09-08 00:10:47 -07004252 parser.add_option('-f', '--force', action='store_true',
4253 help='Delete any unpublished Gerrit edits for this issue '
4254 'without prompting')
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00004255
4256 _add_codereview_select_options(parser)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004257 auth.add_auth_options(parser)
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00004258 options, args = parser.parse_args(args)
4259 _process_codereview_select_options(parser, options)
4260
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01004261 target_issue_arg = None
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00004262 if len(args) > 0:
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004263 target_issue_arg = ParseIssueNumberArgument(args[0],
4264 options.forced_codereview)
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01004265 if not target_issue_arg.valid:
Andrii Shyshkalov28d840e2017-04-10 15:45:09 +02004266 parser.error('invalid codereview url or CL id')
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00004267
martiniss6eda05f2016-06-30 10:18:35 -07004268 kwargs = {
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00004269 'auth_config': auth.extract_auth_config_from_options(options),
4270 'codereview': options.forced_codereview,
martiniss6eda05f2016-06-30 10:18:35 -07004271 }
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004272 detected_codereview_from_url = False
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01004273 if target_issue_arg:
4274 kwargs['issue'] = target_issue_arg.issue
4275 kwargs['codereview_host'] = target_issue_arg.hostname
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004276 if target_issue_arg.codereview and not options.forced_codereview:
4277 detected_codereview_from_url = True
4278 kwargs['codereview'] = target_issue_arg.codereview
martiniss6eda05f2016-06-30 10:18:35 -07004279
4280 cl = Changelist(**kwargs)
rsesek@chromium.orgeec76592013-05-20 16:27:57 +00004281 if not cl.GetIssue():
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004282 assert not detected_codereview_from_url
rsesek@chromium.orgeec76592013-05-20 16:27:57 +00004283 DieWithError('This branch has no associated changelist.')
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004284
4285 if detected_codereview_from_url:
4286 logging.info('canonical issue/change URL: %s (type: %s)\n',
4287 cl.GetIssueURL(), target_issue_arg.codereview)
4288
rsesek@chromium.orgeec76592013-05-20 16:27:57 +00004289 description = ChangeDescription(cl.GetDescription())
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00004290
smut@google.com34fb6b12015-07-13 20:03:26 +00004291 if options.display:
vapiera7fbd5a2016-06-16 09:17:49 -07004292 print(description.description)
smut@google.com34fb6b12015-07-13 20:03:26 +00004293 return 0
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00004294
4295 if options.new_description:
4296 text = options.new_description
4297 if text == '-':
4298 text = '\n'.join(l.rstrip() for l in sys.stdin)
dnjba1b0f32016-09-02 12:37:42 -07004299 elif text == '+':
4300 base_branch = cl.GetCommonAncestorWithUpstream()
4301 change = cl.GetChange(base_branch, None, local_description=True)
4302 text = change.FullDescriptionText()
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00004303
4304 description.set_description(text)
4305 else:
Aaron Gable3a16ed12017-03-23 10:51:55 -07004306 description.prompt(git_footer=cl.IsGerrit())
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00004307
Andrii Shyshkalov680253d2017-03-15 21:07:36 +01004308 if cl.GetDescription().strip() != description.description:
dsansomee2d6fd92016-09-08 00:10:47 -07004309 cl.UpdateDescription(description.description, force=options.force)
rsesek@chromium.orgeec76592013-05-20 16:27:57 +00004310 return 0
4311
4312
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004313@metrics.collector.collect_metrics('git cl lint')
thestig@chromium.org44202a22014-03-11 19:22:18 +00004314def CMDlint(parser, args):
4315 """Runs cpplint on the current changelist."""
tzik@chromium.orgf204d4b2014-03-13 07:40:55 +00004316 parser.add_option('--filter', action='append', metavar='-x,+y',
4317 help='Comma-separated list of cpplint\'s category-filters')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004318 auth.add_auth_options(parser)
4319 options, args = parser.parse_args(args)
4320 auth_config = auth.extract_auth_config_from_options(options)
thestig@chromium.org44202a22014-03-11 19:22:18 +00004321
4322 # Access to a protected member _XX of a client class
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -08004323 # pylint: disable=protected-access
thestig@chromium.org44202a22014-03-11 19:22:18 +00004324 try:
4325 import cpplint
4326 import cpplint_chromium
4327 except ImportError:
vapiera7fbd5a2016-06-16 09:17:49 -07004328 print('Your depot_tools is missing cpplint.py and/or cpplint_chromium.py.')
thestig@chromium.org44202a22014-03-11 19:22:18 +00004329 return 1
4330
4331 # Change the current working directory before calling lint so that it
4332 # shows the correct base.
4333 previous_cwd = os.getcwd()
4334 os.chdir(settings.GetRoot())
4335 try:
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004336 cl = Changelist(auth_config=auth_config)
thestig@chromium.org44202a22014-03-11 19:22:18 +00004337 change = cl.GetChange(cl.GetCommonAncestorWithUpstream(), None)
4338 files = [f.LocalPath() for f in change.AffectedFiles()]
thestig@chromium.org5839eb52014-05-30 16:20:51 +00004339 if not files:
vapiera7fbd5a2016-06-16 09:17:49 -07004340 print('Cannot lint an empty CL')
thestig@chromium.org5839eb52014-05-30 16:20:51 +00004341 return 1
thestig@chromium.org44202a22014-03-11 19:22:18 +00004342
4343 # Process cpplints arguments if any.
tzik@chromium.orgf204d4b2014-03-13 07:40:55 +00004344 command = args + files
4345 if options.filter:
4346 command = ['--filter=' + ','.join(options.filter)] + command
4347 filenames = cpplint.ParseArguments(command)
thestig@chromium.org44202a22014-03-11 19:22:18 +00004348
4349 white_regex = re.compile(settings.GetLintRegex())
4350 black_regex = re.compile(settings.GetLintIgnoreRegex())
4351 extra_check_functions = [cpplint_chromium.CheckPointerDeclarationWhitespace]
4352 for filename in filenames:
4353 if white_regex.match(filename):
4354 if black_regex.match(filename):
vapiera7fbd5a2016-06-16 09:17:49 -07004355 print('Ignoring file %s' % filename)
thestig@chromium.org44202a22014-03-11 19:22:18 +00004356 else:
4357 cpplint.ProcessFile(filename, cpplint._cpplint_state.verbose_level,
4358 extra_check_functions)
4359 else:
vapiera7fbd5a2016-06-16 09:17:49 -07004360 print('Skipping file %s' % filename)
thestig@chromium.org44202a22014-03-11 19:22:18 +00004361 finally:
4362 os.chdir(previous_cwd)
vapiera7fbd5a2016-06-16 09:17:49 -07004363 print('Total errors found: %d\n' % cpplint._cpplint_state.error_count)
thestig@chromium.org44202a22014-03-11 19:22:18 +00004364 if cpplint._cpplint_state.error_count != 0:
4365 return 1
4366 return 0
4367
4368
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004369@metrics.collector.collect_metrics('git cl presubmit')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004370def CMDpresubmit(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004371 """Runs presubmit tests on the current changelist."""
ilevy@chromium.org375a9022013-01-07 01:12:05 +00004372 parser.add_option('-u', '--upload', action='store_true',
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004373 help='Run upload hook instead of the push hook')
ilevy@chromium.org375a9022013-01-07 01:12:05 +00004374 parser.add_option('-f', '--force', action='store_true',
sbc@chromium.org495ad152012-09-04 23:07:42 +00004375 help='Run checks even if tree is dirty')
Aaron Gable8076c282017-11-29 14:39:41 -08004376 parser.add_option('--all', action='store_true',
4377 help='Run checks against all files, not just modified ones')
Edward Lesmes8e282792018-04-03 18:50:29 -04004378 parser.add_option('--parallel', action='store_true',
4379 help='Run all tests specified by input_api.RunTests in all '
4380 'PRESUBMIT files in parallel.')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004381 auth.add_auth_options(parser)
4382 options, args = parser.parse_args(args)
4383 auth_config = auth.extract_auth_config_from_options(options)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004384
sbc@chromium.org71437c02015-04-09 19:29:40 +00004385 if not options.force and git_common.is_dirty_git_tree('presubmit'):
vapiera7fbd5a2016-06-16 09:17:49 -07004386 print('use --force to check even if tree is dirty.')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004387 return 1
4388
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004389 cl = Changelist(auth_config=auth_config)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004390 if args:
4391 base_branch = args[0]
4392 else:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00004393 # Default to diffing against the common ancestor of the upstream branch.
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00004394 base_branch = cl.GetCommonAncestorWithUpstream()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004395
Aaron Gable8076c282017-11-29 14:39:41 -08004396 if options.all:
4397 base_change = cl.GetChange(base_branch, None)
4398 files = [('M', f) for f in base_change.AllFiles()]
4399 change = presubmit_support.GitChange(
4400 base_change.Name(),
4401 base_change.FullDescriptionText(),
4402 base_change.RepositoryRoot(),
4403 files,
4404 base_change.issue,
4405 base_change.patchset,
4406 base_change.author_email,
4407 base_change._upstream)
4408 else:
4409 change = cl.GetChange(base_branch, None)
4410
ilevy@chromium.org051ad0e2013-03-04 21:57:34 +00004411 cl.RunHook(
4412 committing=not options.upload,
4413 may_prompt=False,
4414 verbose=options.verbose,
Edward Lesmes8e282792018-04-03 18:50:29 -04004415 change=change,
4416 parallel=options.parallel)
dpranke@chromium.org0a2bb372011-03-25 01:16:22 +00004417 return 0
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004418
4419
tandrii@chromium.org65874e12016-03-04 12:03:02 +00004420def GenerateGerritChangeId(message):
4421 """Returns Ixxxxxx...xxx change id.
4422
4423 Works the same way as
4424 https://gerrit-review.googlesource.com/tools/hooks/commit-msg
4425 but can be called on demand on all platforms.
4426
4427 The basic idea is to generate git hash of a state of the tree, original commit
4428 message, author/committer info and timestamps.
4429 """
4430 lines = []
4431 tree_hash = RunGitSilent(['write-tree'])
4432 lines.append('tree %s' % tree_hash.strip())
4433 code, parent = RunGitWithCode(['rev-parse', 'HEAD~0'], suppress_stderr=False)
4434 if code == 0:
4435 lines.append('parent %s' % parent.strip())
4436 author = RunGitSilent(['var', 'GIT_AUTHOR_IDENT'])
4437 lines.append('author %s' % author.strip())
4438 committer = RunGitSilent(['var', 'GIT_COMMITTER_IDENT'])
4439 lines.append('committer %s' % committer.strip())
4440 lines.append('')
4441 # Note: Gerrit's commit-hook actually cleans message of some lines and
4442 # whitespace. This code is not doing this, but it clearly won't decrease
4443 # entropy.
4444 lines.append(message)
4445 change_hash = RunCommand(['git', 'hash-object', '-t', 'commit', '--stdin'],
4446 stdin='\n'.join(lines))
4447 return 'I%s' % change_hash.strip()
4448
4449
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01004450def GetTargetRef(remote, remote_branch, target_branch):
wittman@chromium.org455dc922015-01-26 20:15:50 +00004451 """Computes the remote branch ref to use for the CL.
4452
4453 Args:
4454 remote (str): The git remote for the CL.
4455 remote_branch (str): The git remote branch for the CL.
4456 target_branch (str): The target branch specified by the user.
wittman@chromium.org455dc922015-01-26 20:15:50 +00004457 """
4458 if not (remote and remote_branch):
4459 return None
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00004460
wittman@chromium.org455dc922015-01-26 20:15:50 +00004461 if target_branch:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07004462 # Canonicalize branch references to the equivalent local full symbolic
wittman@chromium.org455dc922015-01-26 20:15:50 +00004463 # refs, which are then translated into the remote full symbolic refs
4464 # below.
4465 if '/' not in target_branch:
4466 remote_branch = 'refs/remotes/%s/%s' % (remote, target_branch)
4467 else:
4468 prefix_replacements = (
4469 ('^((refs/)?remotes/)?branch-heads/', 'refs/remotes/branch-heads/'),
4470 ('^((refs/)?remotes/)?%s/' % remote, 'refs/remotes/%s/' % remote),
4471 ('^(refs/)?heads/', 'refs/remotes/%s/' % remote),
4472 )
4473 match = None
4474 for regex, replacement in prefix_replacements:
4475 match = re.search(regex, target_branch)
4476 if match:
4477 remote_branch = target_branch.replace(match.group(0), replacement)
4478 break
4479 if not match:
4480 # This is a branch path but not one we recognize; use as-is.
4481 remote_branch = target_branch
rmistry@google.comc68112d2015-03-03 12:48:06 +00004482 elif remote_branch in REFS_THAT_ALIAS_TO_OTHER_REFS:
4483 # Handle the refs that need to land in different refs.
4484 remote_branch = REFS_THAT_ALIAS_TO_OTHER_REFS[remote_branch]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00004485
wittman@chromium.org455dc922015-01-26 20:15:50 +00004486 # Create the true path to the remote branch.
4487 # Does the following translation:
4488 # * refs/remotes/origin/refs/diff/test -> refs/diff/test
4489 # * refs/remotes/origin/master -> refs/heads/master
4490 # * refs/remotes/branch-heads/test -> refs/branch-heads/test
4491 if remote_branch.startswith('refs/remotes/%s/refs/' % remote):
4492 remote_branch = remote_branch.replace('refs/remotes/%s/' % remote, '')
4493 elif remote_branch.startswith('refs/remotes/%s/' % remote):
4494 remote_branch = remote_branch.replace('refs/remotes/%s/' % remote,
4495 'refs/heads/')
4496 elif remote_branch.startswith('refs/remotes/branch-heads'):
4497 remote_branch = remote_branch.replace('refs/remotes/', 'refs/')
Andrii Shyshkalov768f1d82016-12-08 15:10:13 +01004498
wittman@chromium.org455dc922015-01-26 20:15:50 +00004499 return remote_branch
4500
4501
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00004502def cleanup_list(l):
4503 """Fixes a list so that comma separated items are put as individual items.
4504
4505 So that "--reviewers joe@c,john@c --reviewers joa@c" results in
4506 options.reviewers == sorted(['joe@c', 'john@c', 'joa@c']).
4507 """
4508 items = sum((i.split(',') for i in l), [])
4509 stripped_items = (i.strip() for i in items)
4510 return sorted(filter(None, stripped_items))
4511
4512
Aaron Gable4db38df2017-11-03 14:59:07 -07004513@subcommand.usage('[flags]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004514@metrics.collector.collect_metrics('git cl upload')
ukai@chromium.orge8077812012-02-03 03:41:46 +00004515def CMDupload(parser, args):
rmistry@google.com78948ed2015-07-08 23:09:57 +00004516 """Uploads the current changelist to codereview.
4517
4518 Can skip dependency patchset uploads for a branch by running:
4519 git config branch.branch_name.skip-deps-uploads True
4520 To unset run:
4521 git config --unset branch.branch_name.skip-deps-uploads
4522 Can also set the above globally by using the --global flag.
Dominic Battre7d1c4842017-10-27 09:17:28 +02004523
4524 If the name of the checked out branch starts with "bug-" or "fix-" followed by
4525 a bug number, this bug number is automatically populated in the CL
4526 description.
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004527
4528 If subject contains text in square brackets or has "<text>: " prefix, such
4529 text(s) is treated as Gerrit hashtags. For example, CLs with subjects
4530 [git-cl] add support for hashtags
4531 Foo bar: implement foo
4532 will be hashtagged with "git-cl" and "foo-bar" respectively.
rmistry@google.com78948ed2015-07-08 23:09:57 +00004533 """
ukai@chromium.orge8077812012-02-03 03:41:46 +00004534 parser.add_option('--bypass-hooks', action='store_true', dest='bypass_hooks',
4535 help='bypass upload presubmit hook')
brettw@chromium.orgb65c43c2013-06-10 22:04:49 +00004536 parser.add_option('--bypass-watchlists', action='store_true',
4537 dest='bypass_watchlists',
4538 help='bypass watchlists auto CC-ing reviewers')
Aaron Gablef7543cd2017-07-20 14:26:31 -07004539 parser.add_option('-f', '--force', action='store_true', dest='force',
ukai@chromium.orge8077812012-02-03 03:41:46 +00004540 help="force yes to questions (don't prompt)")
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004541 parser.add_option('--message', '-m', dest='message',
4542 help='message for patchset')
tandriif9aefb72016-07-01 09:06:51 -07004543 parser.add_option('-b', '--bug',
4544 help='pre-populate the bug number(s) for this issue. '
4545 'If several, separate with commas')
tandriib80458a2016-06-23 12:20:07 -07004546 parser.add_option('--message-file', dest='message_file',
4547 help='file which contains message for patchset')
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004548 parser.add_option('--title', '-t', dest='title',
4549 help='title for patchset')
ukai@chromium.orge8077812012-02-03 03:41:46 +00004550 parser.add_option('-r', '--reviewers',
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00004551 action='append', default=[],
ukai@chromium.orge8077812012-02-03 03:41:46 +00004552 help='reviewer email addresses')
Robert Iannucci6c98dc62017-04-18 11:38:00 -07004553 parser.add_option('--tbrs',
4554 action='append', default=[],
4555 help='TBR email addresses')
ukai@chromium.orge8077812012-02-03 03:41:46 +00004556 parser.add_option('--cc',
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00004557 action='append', default=[],
ukai@chromium.orge8077812012-02-03 03:41:46 +00004558 help='cc email addresses')
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004559 parser.add_option('--hashtag', dest='hashtags',
4560 action='append', default=[],
4561 help=('Gerrit hashtag for new CL; '
4562 'can be applied multiple times'))
adamk@chromium.org36f47302013-04-05 01:08:31 +00004563 parser.add_option('-s', '--send-mail', action='store_true',
Aaron Gable59f48512017-01-12 10:54:46 -08004564 help='send email to reviewer(s) and cc(s) immediately')
ukai@chromium.orge8077812012-02-03 03:41:46 +00004565 parser.add_option('-c', '--use-commit-queue', action='store_true',
Aaron Gableedbc4132017-09-11 13:22:28 -07004566 help='tell the commit queue to commit this patchset; '
4567 'implies --send-mail')
ukai@chromium.org8ef7ab22012-11-28 04:24:52 +00004568 parser.add_option('--target_branch',
pgervais@chromium.orgb9f27512014-08-08 15:52:33 +00004569 '--target-branch',
wittman@chromium.org455dc922015-01-26 20:15:50 +00004570 metavar='TARGET',
4571 help='Apply CL to remote ref TARGET. ' +
4572 'Default: remote branch head, or master')
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00004573 parser.add_option('--squash', action='store_true',
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004574 help='Squash multiple commits into one')
bauerb@chromium.org54b400c2016-01-14 10:08:25 +00004575 parser.add_option('--no-squash', action='store_true',
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004576 help='Don\'t squash multiple commits into one')
rmistry9eadede2016-09-19 11:22:43 -07004577 parser.add_option('--topic', default=None,
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004578 help='Topic to specify when uploading')
Robert Iannuccif2708bd2017-04-17 15:49:02 -07004579 parser.add_option('--tbr-owners', dest='add_owners_to', action='store_const',
4580 const='TBR', help='add a set of OWNERS to TBR')
4581 parser.add_option('--r-owners', dest='add_owners_to', action='store_const',
4582 const='R', help='add a set of OWNERS to R')
tandrii@chromium.orgd50452a2015-11-23 16:38:15 +00004583 parser.add_option('-d', '--cq-dry-run', dest='cq_dry_run',
4584 action='store_true',
rmistry@google.comef966222015-04-07 11:15:01 +00004585 help='Send the patchset to do a CQ dry run right after '
4586 'upload.')
rmistry@google.com2dd99862015-06-22 12:22:18 +00004587 parser.add_option('--dependencies', action='store_true',
4588 help='Uploads CLs of all the local branches that depend on '
4589 'the current branch')
Ravi Mistry31e7d562018-04-02 12:53:57 -04004590 parser.add_option('-a', '--enable-auto-submit', action='store_true',
4591 help='Sends your change to the CQ after an approval. Only '
4592 'works on repos that have the Auto-Submit label '
4593 'enabled')
Edward Lesmes8e282792018-04-03 18:50:29 -04004594 parser.add_option('--parallel', action='store_true',
4595 help='Run all tests specified by input_api.RunTests in all '
4596 'PRESUBMIT files in parallel.')
pgervais@chromium.org91141372014-01-09 23:27:20 +00004597
Sergiy Byelozyorov1aa405f2018-09-18 17:38:43 +00004598 parser.add_option('--no-autocc', action='store_true',
4599 help='Disables automatic addition of CC emails')
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004600 parser.add_option('--private', action='store_true',
Sergiy Byelozyorov1aa405f2018-09-18 17:38:43 +00004601 help='Set the review private. This implies --no-autocc.')
4602
rmistry@google.com2dd99862015-06-22 12:22:18 +00004603 orig_args = args
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004604 auth.add_auth_options(parser)
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00004605 _add_codereview_select_options(parser)
ukai@chromium.orge8077812012-02-03 03:41:46 +00004606 (options, args) = parser.parse_args(args)
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00004607 _process_codereview_select_options(parser, options)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004608 auth_config = auth.extract_auth_config_from_options(options)
ukai@chromium.orge8077812012-02-03 03:41:46 +00004609
sbc@chromium.org71437c02015-04-09 19:29:40 +00004610 if git_common.is_dirty_git_tree('upload'):
ukai@chromium.orge8077812012-02-03 03:41:46 +00004611 return 1
4612
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00004613 options.reviewers = cleanup_list(options.reviewers)
Robert Iannucci6c98dc62017-04-18 11:38:00 -07004614 options.tbrs = cleanup_list(options.tbrs)
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00004615 options.cc = cleanup_list(options.cc)
4616
tandriib80458a2016-06-23 12:20:07 -07004617 if options.message_file:
4618 if options.message:
4619 parser.error('only one of --message and --message-file allowed.')
4620 options.message = gclient_utils.FileRead(options.message_file)
4621 options.message_file = None
4622
tandrii4d0545a2016-07-06 03:56:49 -07004623 if options.cq_dry_run and options.use_commit_queue:
4624 parser.error('only one of --use-commit-queue and --cq-dry-run allowed.')
4625
Aaron Gableedbc4132017-09-11 13:22:28 -07004626 if options.use_commit_queue:
4627 options.send_mail = True
4628
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00004629 # For sanity of test expectations, do this otherwise lazy-loading *now*.
4630 settings.GetIsGerrit()
4631
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00004632 cl = Changelist(auth_config=auth_config, codereview=options.forced_codereview)
Andrii Shyshkalov9f274432018-10-15 16:40:23 +00004633 if not cl.IsGerrit():
4634 # Error out with instructions for repos not yet configured for Gerrit.
4635 print('=====================================')
4636 print('NOTICE: Rietveld is no longer supported. '
4637 'You can upload changes to Gerrit with')
4638 print(' git cl upload --gerrit')
4639 print('or set Gerrit to be your default code review tool with')
4640 print(' git config gerrit.host true')
4641 print('=====================================')
4642 return 1
4643
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00004644 return cl.CMDUpload(options, args, orig_args)
ukai@chromium.orge8077812012-02-03 03:41:46 +00004645
4646
Francois Dorayd42c6812017-05-30 15:10:20 -04004647@subcommand.usage('--description=<description file>')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004648@metrics.collector.collect_metrics('git cl split')
Francois Dorayd42c6812017-05-30 15:10:20 -04004649def CMDsplit(parser, args):
4650 """Splits a branch into smaller branches and uploads CLs.
4651
4652 Creates a branch and uploads a CL for each group of files modified in the
4653 current branch that share a common OWNERS file. In the CL description and
Quinten Yearsley0c62da92017-05-31 13:39:42 -07004654 comment, the string '$directory', is replaced with the directory containing
Francois Dorayd42c6812017-05-30 15:10:20 -04004655 the shared OWNERS file.
4656 """
4657 parser.add_option("-d", "--description", dest="description_file",
Gabriel Charette02b5ee82017-11-08 16:36:05 -05004658 help="A text file containing a CL description in which "
4659 "$directory will be replaced by each CL's directory.")
Francois Dorayd42c6812017-05-30 15:10:20 -04004660 parser.add_option("-c", "--comment", dest="comment_file",
4661 help="A text file containing a CL comment.")
Chris Watkinsba28e462017-12-13 11:22:17 +11004662 parser.add_option("-n", "--dry-run", dest="dry_run", action='store_true',
4663 default=False,
4664 help="List the files and reviewers for each CL that would "
4665 "be created, but don't create branches or CLs.")
Stephen Martiniscb326682018-08-29 21:06:30 +00004666 parser.add_option("--cq-dry-run", action='store_true',
4667 help="If set, will do a cq dry run for each uploaded CL. "
4668 "Please be careful when doing this; more than ~10 CLs "
4669 "has the potential to overload our build "
4670 "infrastructure. Try to upload these not during high "
4671 "load times (usually 11-3 Mountain View time). Email "
4672 "infra-dev@chromium.org with any questions.")
Takuto Ikuta51eca592019-02-14 19:40:52 +00004673 parser.add_option('-a', '--enable-auto-submit', action='store_true',
4674 default=True,
4675 help='Sends your change to the CQ after an approval. Only '
4676 'works on repos that have the Auto-Submit label '
4677 'enabled')
Francois Dorayd42c6812017-05-30 15:10:20 -04004678 options, _ = parser.parse_args(args)
4679
4680 if not options.description_file:
4681 parser.error('No --description flag specified.')
4682
4683 def WrappedCMDupload(args):
4684 return CMDupload(OptionParser(), args)
4685
4686 return split_cl.SplitCl(options.description_file, options.comment_file,
Stephen Martiniscb326682018-08-29 21:06:30 +00004687 Changelist, WrappedCMDupload, options.dry_run,
Takuto Ikuta51eca592019-02-14 19:40:52 +00004688 options.cq_dry_run, options.enable_auto_submit)
Francois Dorayd42c6812017-05-30 15:10:20 -04004689
4690
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004691@subcommand.usage('DEPRECATED')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004692@metrics.collector.collect_metrics('git cl commit')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004693def CMDdcommit(parser, args):
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004694 """DEPRECATED: Used to commit the current changelist via git-svn."""
4695 message = ('git-cl no longer supports committing to SVN repositories via '
4696 'git-svn. You probably want to use `git cl land` instead.')
4697 print(message)
4698 return 1
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004699
4700
Andrii Shyshkalovaa31b972017-03-24 16:16:33 +01004701# Two special branches used by git cl land.
4702MERGE_BRANCH = 'git-cl-commit'
4703CHERRY_PICK_BRANCH = 'git-cl-cherry-pick'
4704
4705
maruel@chromium.org0633fb42013-08-16 20:06:14 +00004706@subcommand.usage('[upstream branch to apply against]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004707@metrics.collector.collect_metrics('git cl land')
pgervais@chromium.orgcee6dc42014-05-07 17:04:03 +00004708def CMDland(parser, args):
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004709 """Commits the current changelist via git.
4710
4711 In case of Gerrit, uses Gerrit REST api to "submit" the issue, which pushes
4712 upstream and closes the issue automatically and atomically.
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004713 """
4714 parser.add_option('--bypass-hooks', action='store_true', dest='bypass_hooks',
4715 help='bypass upload presubmit hook')
Aaron Gablef7543cd2017-07-20 14:26:31 -07004716 parser.add_option('-f', '--force', action='store_true', dest='force',
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004717 help="force yes to questions (don't prompt)")
Edward Lesmes67b3faa2018-04-13 17:50:52 -04004718 parser.add_option('--parallel', action='store_true',
4719 help='Run all tests specified by input_api.RunTests in all '
4720 'PRESUBMIT files in parallel.')
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004721 auth.add_auth_options(parser)
4722 (options, args) = parser.parse_args(args)
4723 auth_config = auth.extract_auth_config_from_options(options)
4724
4725 cl = Changelist(auth_config=auth_config)
4726
Robert Iannucci2e73d432018-03-14 01:10:47 -07004727 if not cl.IsGerrit():
4728 parser.error('rietveld is not supported')
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004729
Robert Iannucci2e73d432018-03-14 01:10:47 -07004730 if not cl.GetIssue():
4731 DieWithError('You must upload the change first to Gerrit.\n'
4732 ' If you would rather have `git cl land` upload '
4733 'automatically for you, see http://crbug.com/642759')
4734 return cl._codereview_impl.CMDLand(options.force, options.bypass_hooks,
Olivier Robin75ee7252018-04-13 10:02:56 +02004735 options.verbose, options.parallel)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004736
4737
dsinclair@chromium.orgfbed6562015-09-25 21:22:36 +00004738@subcommand.usage('<patch url or issue id or issue url>')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004739@metrics.collector.collect_metrics('git cl patch')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004740def CMDpatch(parser, args):
marq@chromium.orge5e59002013-10-02 23:21:25 +00004741 """Patches in a code review."""
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004742 parser.add_option('-b', dest='newbranch',
4743 help='create a new branch off trunk for the patch')
qsr@chromium.org1ef44af2013-10-16 16:24:32 +00004744 parser.add_option('-f', '--force', action='store_true',
Aaron Gable62619a32017-06-16 08:22:09 -07004745 help='overwrite state on the current or chosen branch')
qsr@chromium.org1ef44af2013-10-16 16:24:32 +00004746 parser.add_option('-d', '--directory', action='store', metavar='DIR',
Aaron Gable62619a32017-06-16 08:22:09 -07004747 help='change to the directory DIR immediately, '
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00004748 'before doing anything else. Rietveld only.')
qsr@chromium.org1ef44af2013-10-16 16:24:32 +00004749 parser.add_option('--reject', action='store_true',
tapted@chromium.org6a0b07c2013-07-10 01:29:19 +00004750 help='failed patches spew .rej files rather than '
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00004751 'attempting a 3-way merge. Rietveld only.')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004752 parser.add_option('-n', '--no-commit', action='store_true', dest='nocommit',
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00004753 help='don\'t commit after patch applies. Rietveld only.')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004754
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00004755
4756 group = optparse.OptionGroup(
4757 parser,
4758 'Options for continuing work on the current issue uploaded from a '
4759 'different clone (e.g. different machine). Must be used independently '
4760 'from the other options. No issue number should be specified, and the '
4761 'branch must have an issue number associated with it')
4762 group.add_option('--reapply', action='store_true', dest='reapply',
4763 help='Reset the branch and reapply the issue.\n'
4764 'CAUTION: This will undo any local changes in this '
4765 'branch')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004766
4767 group.add_option('--pull', action='store_true', dest='pull',
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00004768 help='Performs a pull before reapplying.')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004769 parser.add_option_group(group)
4770
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004771 auth.add_auth_options(parser)
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00004772 _add_codereview_select_options(parser)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004773 (options, args) = parser.parse_args(args)
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00004774 _process_codereview_select_options(parser, options)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004775 auth_config = auth.extract_auth_config_from_options(options)
4776
Andrii Shyshkalov18975322017-01-25 16:44:13 +01004777 if options.reapply:
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004778 if options.newbranch:
4779 parser.error('--reapply works on the current branch only')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004780 if len(args) > 0:
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004781 parser.error('--reapply implies no additional arguments')
dsinclair@chromium.orgfbed6562015-09-25 21:22:36 +00004782
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004783 cl = Changelist(auth_config=auth_config,
4784 codereview=options.forced_codereview)
4785 if not cl.GetIssue():
4786 parser.error('current branch must have an associated issue')
4787
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004788 upstream = cl.GetUpstreamBranch()
Andrii Shyshkalov18975322017-01-25 16:44:13 +01004789 if upstream is None:
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00004790 parser.error('No upstream branch specified. Cannot reset branch')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004791
4792 RunGit(['reset', '--hard', upstream])
4793 if options.pull:
4794 RunGit(['pull'])
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004795
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004796 return cl.CMDPatchIssue(cl.GetIssue(), options.reject, options.nocommit,
4797 options.directory)
4798
4799 if len(args) != 1 or not args[0]:
4800 parser.error('Must specify issue number or url')
4801
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004802 target_issue_arg = ParseIssueNumberArgument(args[0],
4803 options.forced_codereview)
4804 if not target_issue_arg.valid:
4805 parser.error('invalid codereview url or CL id')
4806
4807 cl_kwargs = {
4808 'auth_config': auth_config,
4809 'codereview_host': target_issue_arg.hostname,
4810 'codereview': options.forced_codereview,
4811 }
4812 detected_codereview_from_url = False
4813 if target_issue_arg.codereview and not options.forced_codereview:
4814 detected_codereview_from_url = True
4815 cl_kwargs['codereview'] = target_issue_arg.codereview
4816 cl_kwargs['issue'] = target_issue_arg.issue
4817
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004818 # We don't want uncommitted changes mixed up with the patch.
4819 if git_common.is_dirty_git_tree('patch'):
dsinclair@chromium.orgfbed6562015-09-25 21:22:36 +00004820 return 1
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004821
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004822 if options.newbranch:
4823 if options.force:
4824 RunGit(['branch', '-D', options.newbranch],
4825 stderr=subprocess2.PIPE, error_ok=True)
4826 RunGit(['new-branch', options.newbranch])
4827
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004828 cl = Changelist(**cl_kwargs)
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004829
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00004830 if cl.IsGerrit():
4831 if options.reject:
4832 parser.error('--reject is not supported with Gerrit codereview.')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00004833 if options.directory:
4834 parser.error('--directory is not supported with Gerrit codereview.')
4835
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004836 if detected_codereview_from_url:
4837 print('canonical issue/change URL: %s (type: %s)\n' %
4838 (cl.GetIssueURL(), target_issue_arg.codereview))
4839
4840 return cl.CMDPatchWithParsedIssue(target_issue_arg, options.reject,
Aaron Gable62619a32017-06-16 08:22:09 -07004841 options.nocommit, options.directory,
4842 options.force)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004843
4844
jochen@chromium.org3ec0d542014-01-14 20:00:03 +00004845def GetTreeStatus(url=None):
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004846 """Fetches the tree status and returns either 'open', 'closed',
4847 'unknown' or 'unset'."""
jochen@chromium.org3ec0d542014-01-14 20:00:03 +00004848 url = url or settings.GetTreeStatusUrl(error_ok=True)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004849 if url:
4850 status = urllib2.urlopen(url).read().lower()
4851 if status.find('closed') != -1 or status == '0':
4852 return 'closed'
4853 elif status.find('open') != -1 or status == '1':
4854 return 'open'
4855 return 'unknown'
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004856 return 'unset'
4857
dpranke@chromium.org970c5222011-03-12 00:32:24 +00004858
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004859def GetTreeStatusReason():
4860 """Fetches the tree status from a json url and returns the message
4861 with the reason for the tree to be opened or closed."""
msb@chromium.orgbf1a7ba2011-02-01 16:21:46 +00004862 url = settings.GetTreeStatusUrl()
4863 json_url = urlparse.urljoin(url, '/current?format=json')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004864 connection = urllib2.urlopen(json_url)
4865 status = json.loads(connection.read())
4866 connection.close()
4867 return status['message']
4868
dpranke@chromium.org970c5222011-03-12 00:32:24 +00004869
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004870@metrics.collector.collect_metrics('git cl tree')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004871def CMDtree(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004872 """Shows the status of the tree."""
dpranke@chromium.org97ae58e2011-03-18 00:29:20 +00004873 _, args = parser.parse_args(args)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004874 status = GetTreeStatus()
4875 if 'unset' == status:
vapiera7fbd5a2016-06-16 09:17:49 -07004876 print('You must configure your tree status URL by running "git cl config".')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004877 return 2
4878
vapiera7fbd5a2016-06-16 09:17:49 -07004879 print('The tree is %s' % status)
4880 print()
4881 print(GetTreeStatusReason())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004882 if status != 'open':
4883 return 1
4884 return 0
4885
4886
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004887@metrics.collector.collect_metrics('git cl try')
maruel@chromium.org15192402012-09-06 12:38:29 +00004888def CMDtry(parser, args):
qyearsley1fdfcb62016-10-24 13:22:03 -07004889 """Triggers try jobs using either BuildBucket or CQ dry run."""
tandrii1838bad2016-10-06 00:10:52 -07004890 group = optparse.OptionGroup(parser, 'Try job options')
maruel@chromium.org15192402012-09-06 12:38:29 +00004891 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004892 '-b', '--bot', action='append',
4893 help=('IMPORTANT: specify ONE builder per --bot flag. Use it multiple '
4894 'times to specify multiple builders. ex: '
4895 '"-b win_rel -b win_layout". See '
4896 'the try server waterfall for the builders name and the tests '
4897 'available.'))
maruel@chromium.org15192402012-09-06 12:38:29 +00004898 group.add_option(
borenet6c0efe62016-10-19 08:13:29 -07004899 '-B', '--bucket', default='',
4900 help=('Buildbucket bucket to send the try requests.'))
4901 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004902 '-m', '--master', default='',
Nodir Turakulovf6929a12017-10-09 12:34:44 -07004903 help=('DEPRECATED, use -B. The try master where to run the builds.'))
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00004904 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004905 '-r', '--revision',
tandriif7b29d42016-10-07 08:45:41 -07004906 help='Revision to use for the try job; default: the revision will '
4907 'be determined by the try recipe that builder runs, which usually '
4908 'defaults to HEAD of origin/master')
maruel@chromium.org15192402012-09-06 12:38:29 +00004909 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004910 '-c', '--clobber', action='store_true', default=False,
tandriif7b29d42016-10-07 08:45:41 -07004911 help='Force a clobber before building; that is don\'t do an '
tandrii1838bad2016-10-06 00:10:52 -07004912 'incremental build')
maruel@chromium.org15192402012-09-06 12:38:29 +00004913 group.add_option(
Andrii Shyshkalovf9648b52018-02-21 22:32:42 -08004914 '--category', default='git_cl_try', help='Specify custom build category.')
4915 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004916 '--project',
4917 help='Override which project to use. Projects are defined '
tandriif7b29d42016-10-07 08:45:41 -07004918 'in recipe to determine to which repository or directory to '
4919 'apply the patch')
maruel@chromium.org15192402012-09-06 12:38:29 +00004920 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004921 '-p', '--property', dest='properties', action='append', default=[],
4922 help='Specify generic properties in the form -p key1=value1 -p '
tandriif7b29d42016-10-07 08:45:41 -07004923 'key2=value2 etc. The value will be treated as '
4924 'json if decodable, or as string otherwise. '
4925 'NOTE: using this may make your try job not usable for CQ, '
4926 'which will then schedule another try job with default properties')
sheyang@chromium.orgdb375572015-08-17 19:22:23 +00004927 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004928 '--buildbucket-host', default='cr-buildbucket.appspot.com',
4929 help='Host of buildbucket. The default host is %default.')
maruel@chromium.org15192402012-09-06 12:38:29 +00004930 parser.add_option_group(group)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004931 auth.add_auth_options(parser)
Koji Ishii31c14782018-01-08 17:17:33 +09004932 _add_codereview_issue_select_options(parser)
maruel@chromium.org15192402012-09-06 12:38:29 +00004933 options, args = parser.parse_args(args)
Koji Ishii31c14782018-01-08 17:17:33 +09004934 _process_codereview_issue_select_options(parser, options)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004935 auth_config = auth.extract_auth_config_from_options(options)
maruel@chromium.org15192402012-09-06 12:38:29 +00004936
Nodir Turakulovf6929a12017-10-09 12:34:44 -07004937 if options.master and options.master.startswith('luci.'):
4938 parser.error(
4939 '-m option does not support LUCI. Please pass -B %s' % options.master)
machenbach@chromium.org45453142015-09-15 08:45:22 +00004940 # Make sure that all properties are prop=value pairs.
4941 bad_params = [x for x in options.properties if '=' not in x]
4942 if bad_params:
4943 parser.error('Got properties with missing "=": %s' % bad_params)
4944
maruel@chromium.org15192402012-09-06 12:38:29 +00004945 if args:
4946 parser.error('Unknown arguments: %s' % args)
4947
Koji Ishii31c14782018-01-08 17:17:33 +09004948 cl = Changelist(auth_config=auth_config, issue=options.issue,
4949 codereview=options.forced_codereview)
maruel@chromium.org15192402012-09-06 12:38:29 +00004950 if not cl.GetIssue():
4951 parser.error('Need to upload first')
4952
Andrii Shyshkaloveadad922017-01-26 09:38:30 +01004953 if cl.IsGerrit():
4954 # HACK: warm up Gerrit change detail cache to save on RPCs.
4955 cl._codereview_impl._GetChangeDetail(['DETAILED_ACCOUNTS', 'ALL_REVISIONS'])
4956
tandriie113dfd2016-10-11 10:20:12 -07004957 error_message = cl.CannotTriggerTryJobReason()
4958 if error_message:
qyearsley99e2cdf2016-10-23 12:51:41 -07004959 parser.error('Can\'t trigger try jobs: %s' % error_message)
jrobbins@chromium.org16f10f72014-06-24 22:14:36 +00004960
borenet6c0efe62016-10-19 08:13:29 -07004961 if options.bucket and options.master:
4962 parser.error('Only one of --bucket and --master may be used.')
4963
qyearsley1fdfcb62016-10-24 13:22:03 -07004964 buckets = _get_bucket_map(cl, options, parser)
phajdan.jr@chromium.org8da7f272014-03-14 01:28:39 +00004965
qyearsleydd49f942016-10-28 11:57:22 -07004966 # If no bots are listed and we couldn't get a list based on PRESUBMIT files,
4967 # then we default to triggering a CQ dry run (see http://crbug.com/625697).
qyearsley1fdfcb62016-10-24 13:22:03 -07004968 if not buckets:
qyearsley1fdfcb62016-10-24 13:22:03 -07004969 if options.verbose:
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07004970 print('git cl try with no bots now defaults to CQ dry run.')
4971 print('Scheduling CQ dry run on: %s' % cl.GetIssueURL())
4972 return cl.SetCQState(_CQState.DRY_RUN)
stip@chromium.org43064fd2013-12-18 20:07:44 +00004973
borenet6c0efe62016-10-19 08:13:29 -07004974 for builders in buckets.itervalues():
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00004975 if any('triggered' in b for b in builders):
vapiera7fbd5a2016-06-16 09:17:49 -07004976 print('ERROR You are trying to send a job to a triggered bot. This type '
tandriide281ae2016-10-12 06:02:30 -07004977 'of bot requires an initial job from a parent (usually a builder). '
4978 'Instead send your job to the parent.\n'
vapiera7fbd5a2016-06-16 09:17:49 -07004979 'Bot list: %s' % builders, file=sys.stderr)
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00004980 return 1
ilevy@chromium.orgf3b21232012-09-24 20:48:55 +00004981
ilevy@chromium.org36e420b2013-08-06 23:21:12 +00004982 patchset = cl.GetMostRecentPatchset()
tandrii568043b2016-10-11 07:49:18 -07004983 try:
Andrii Shyshkalovf9648b52018-02-21 22:32:42 -08004984 _trigger_try_jobs(auth_config, cl, buckets, options, patchset)
tandrii568043b2016-10-11 07:49:18 -07004985 except BuildbucketResponseException as ex:
4986 print('ERROR: %s' % ex)
4987 return 1
maruel@chromium.org15192402012-09-06 12:38:29 +00004988 return 0
4989
4990
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004991@metrics.collector.collect_metrics('git cl try-results')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004992def CMDtry_results(parser, args):
tandrii1838bad2016-10-06 00:10:52 -07004993 """Prints info about try jobs associated with current CL."""
4994 group = optparse.OptionGroup(parser, 'Try job results options')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004995 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004996 '-p', '--patchset', type=int, help='patchset number if not current.')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004997 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004998 '--print-master', action='store_true', help='print master name as well.')
tandrii@chromium.org6cf98c82016-03-15 11:56:00 +00004999 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07005000 '--color', action='store_true', default=setup_color.IS_TTY,
5001 help='force color output, useful when piping output.')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00005002 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07005003 '--buildbucket-host', default='cr-buildbucket.appspot.com',
5004 help='Host of buildbucket. The default host is %default.')
qyearsley53f48a12016-09-01 10:45:13 -07005005 group.add_option(
Stefan Zager1306bd02017-06-22 19:26:46 -07005006 '--json', help=('Path of JSON output file to write try job results to,'
5007 'or "-" for stdout.'))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00005008 parser.add_option_group(group)
5009 auth.add_auth_options(parser)
Stefan Zager27db3f22017-10-10 15:15:01 -07005010 _add_codereview_issue_select_options(parser)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00005011 options, args = parser.parse_args(args)
Stefan Zager27db3f22017-10-10 15:15:01 -07005012 _process_codereview_issue_select_options(parser, options)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00005013 if args:
5014 parser.error('Unrecognized args: %s' % ' '.join(args))
5015
5016 auth_config = auth.extract_auth_config_from_options(options)
Stefan Zager27db3f22017-10-10 15:15:01 -07005017 cl = Changelist(
5018 issue=options.issue, codereview=options.forced_codereview,
5019 auth_config=auth_config)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00005020 if not cl.GetIssue():
5021 parser.error('Need to upload first')
5022
tandrii221ab252016-10-06 08:12:04 -07005023 patchset = options.patchset
5024 if not patchset:
5025 patchset = cl.GetMostRecentPatchset()
5026 if not patchset:
5027 parser.error('Codereview doesn\'t know about issue %s. '
5028 'No access to issue or wrong issue number?\n'
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01005029 'Either upload first, or pass --patchset explicitly' %
tandrii221ab252016-10-06 08:12:04 -07005030 cl.GetIssue())
5031
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00005032 try:
tandrii221ab252016-10-06 08:12:04 -07005033 jobs = fetch_try_jobs(auth_config, cl, options.buildbucket_host, patchset)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00005034 except BuildbucketResponseException as ex:
vapiera7fbd5a2016-06-16 09:17:49 -07005035 print('Buildbucket error: %s' % ex)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00005036 return 1
qyearsley53f48a12016-09-01 10:45:13 -07005037 if options.json:
5038 write_try_results_json(options.json, jobs)
5039 else:
5040 print_try_jobs(options, jobs)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00005041 return 0
5042
5043
maruel@chromium.org0633fb42013-08-16 20:06:14 +00005044@subcommand.usage('[new upstream branch]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005045@metrics.collector.collect_metrics('git cl upstream')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005046def CMDupstream(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005047 """Prints or sets the name of the upstream branch, if any."""
dpranke@chromium.org97ae58e2011-03-18 00:29:20 +00005048 _, args = parser.parse_args(args)
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00005049 if len(args) > 1:
maruel@chromium.org27bb3872011-05-30 20:33:19 +00005050 parser.error('Unrecognized args: %s' % ' '.join(args))
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00005051
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005052 cl = Changelist()
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00005053 if args:
5054 # One arg means set upstream branch.
bauerb@chromium.orgc9cf90a2014-04-28 20:32:31 +00005055 branch = cl.GetBranch()
stip7a3dd352016-09-22 17:32:28 -07005056 RunGit(['branch', '--set-upstream-to', args[0], branch])
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00005057 cl = Changelist()
vapiera7fbd5a2016-06-16 09:17:49 -07005058 print('Upstream branch set to %s' % (cl.GetUpstreamBranch(),))
bauerb@chromium.orgc9cf90a2014-04-28 20:32:31 +00005059
5060 # Clear configured merge-base, if there is one.
5061 git_common.remove_merge_base(branch)
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00005062 else:
vapiera7fbd5a2016-06-16 09:17:49 -07005063 print(cl.GetUpstreamBranch())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005064 return 0
5065
5066
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005067@metrics.collector.collect_metrics('git cl web')
thestig@chromium.org00858c82013-12-02 23:08:03 +00005068def CMDweb(parser, args):
5069 """Opens the current CL in the web browser."""
5070 _, args = parser.parse_args(args)
5071 if args:
5072 parser.error('Unrecognized args: %s' % ' '.join(args))
5073
5074 issue_url = Changelist().GetIssueURL()
5075 if not issue_url:
vapiera7fbd5a2016-06-16 09:17:49 -07005076 print('ERROR No issue to open', file=sys.stderr)
thestig@chromium.org00858c82013-12-02 23:08:03 +00005077 return 1
5078
Sergiy Byelozyorov2b718322018-10-24 17:43:31 +00005079 # Redirect I/O before invoking browser to hide its output. For example, this
5080 # allows to hide "Created new window in existing browser session." message
5081 # from Chrome. Based on https://stackoverflow.com/a/2323563.
5082 saved_stdout = os.dup(1)
Sergiy Belozorov06684032019-03-06 16:53:08 +00005083 saved_stderr = os.dup(2)
Sergiy Byelozyorov2b718322018-10-24 17:43:31 +00005084 os.close(1)
Sergiy Belozorov06684032019-03-06 16:53:08 +00005085 os.close(2)
Sergiy Byelozyorov2b718322018-10-24 17:43:31 +00005086 os.open(os.devnull, os.O_RDWR)
5087 try:
5088 webbrowser.open(issue_url)
5089 finally:
5090 os.dup2(saved_stdout, 1)
Sergiy Belozorov06684032019-03-06 16:53:08 +00005091 os.dup2(saved_stderr, 2)
thestig@chromium.org00858c82013-12-02 23:08:03 +00005092 return 0
5093
5094
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005095@metrics.collector.collect_metrics('git cl set-commit')
maruel@chromium.org27bb3872011-05-30 20:33:19 +00005096def CMDset_commit(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005097 """Sets the commit bit to trigger the Commit Queue."""
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00005098 parser.add_option('-d', '--dry-run', action='store_true',
5099 help='trigger in dry run mode')
5100 parser.add_option('-c', '--clear', action='store_true',
5101 help='stop CQ run, if any')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00005102 auth.add_auth_options(parser)
iannuccie53c9352016-08-17 14:40:40 -07005103 _add_codereview_issue_select_options(parser)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00005104 options, args = parser.parse_args(args)
iannuccie53c9352016-08-17 14:40:40 -07005105 _process_codereview_issue_select_options(parser, options)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00005106 auth_config = auth.extract_auth_config_from_options(options)
maruel@chromium.org27bb3872011-05-30 20:33:19 +00005107 if args:
5108 parser.error('Unrecognized args: %s' % ' '.join(args))
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00005109 if options.dry_run and options.clear:
5110 parser.error('Make up your mind: both --dry-run and --clear not allowed')
5111
iannuccie53c9352016-08-17 14:40:40 -07005112 cl = Changelist(auth_config=auth_config, issue=options.issue,
5113 codereview=options.forced_codereview)
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00005114 if options.clear:
tandriid9e5ce52016-07-13 02:32:59 -07005115 state = _CQState.NONE
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00005116 elif options.dry_run:
5117 state = _CQState.DRY_RUN
5118 else:
5119 state = _CQState.COMMIT
5120 if not cl.GetIssue():
5121 parser.error('Must upload the issue first')
tandrii9de9ec62016-07-13 03:01:59 -07005122 cl.SetCQState(state)
maruel@chromium.org27bb3872011-05-30 20:33:19 +00005123 return 0
5124
5125
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005126@metrics.collector.collect_metrics('git cl set-close')
groby@chromium.org411034a2013-02-26 15:12:01 +00005127def CMDset_close(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005128 """Closes the issue."""
iannuccie53c9352016-08-17 14:40:40 -07005129 _add_codereview_issue_select_options(parser)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00005130 auth.add_auth_options(parser)
5131 options, args = parser.parse_args(args)
iannuccie53c9352016-08-17 14:40:40 -07005132 _process_codereview_issue_select_options(parser, options)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00005133 auth_config = auth.extract_auth_config_from_options(options)
groby@chromium.org411034a2013-02-26 15:12:01 +00005134 if args:
5135 parser.error('Unrecognized args: %s' % ' '.join(args))
iannuccie53c9352016-08-17 14:40:40 -07005136 cl = Changelist(auth_config=auth_config, issue=options.issue,
5137 codereview=options.forced_codereview)
groby@chromium.org411034a2013-02-26 15:12:01 +00005138 # Ensure there actually is an issue to close.
Aaron Gable7139a4e2017-09-05 17:53:09 -07005139 if not cl.GetIssue():
5140 DieWithError('ERROR No issue to close')
groby@chromium.org411034a2013-02-26 15:12:01 +00005141 cl.CloseIssue()
5142 return 0
5143
5144
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005145@metrics.collector.collect_metrics('git cl diff')
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00005146def CMDdiff(parser, args):
wychen@chromium.org37b2ec02015-04-03 00:49:15 +00005147 """Shows differences between local tree and last upload."""
thomasanderson074beb22016-08-29 14:03:20 -07005148 parser.add_option(
5149 '--stat',
5150 action='store_true',
5151 dest='stat',
5152 help='Generate a diffstat')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00005153 auth.add_auth_options(parser)
5154 options, args = parser.parse_args(args)
5155 auth_config = auth.extract_auth_config_from_options(options)
5156 if args:
5157 parser.error('Unrecognized args: %s' % ' '.join(args))
wychen@chromium.org46309bf2015-04-03 21:04:49 +00005158
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00005159 cl = Changelist(auth_config=auth_config)
sbc@chromium.org78dc9842013-11-25 18:43:44 +00005160 issue = cl.GetIssue()
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00005161 branch = cl.GetBranch()
sbc@chromium.org78dc9842013-11-25 18:43:44 +00005162 if not issue:
5163 DieWithError('No issue found for current branch (%s)' % branch)
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00005164
Aaron Gablea718c3e2017-08-28 17:47:28 -07005165 base = cl._GitGetBranchConfigValue('last-upload-hash')
5166 if not base:
5167 base = cl._GitGetBranchConfigValue('gerritsquashhash')
5168 if not base:
5169 detail = cl._GetChangeDetail(['CURRENT_REVISION', 'CURRENT_COMMIT'])
5170 revision_info = detail['revisions'][detail['current_revision']]
5171 fetch_info = revision_info['fetch']['http']
5172 RunGit(['fetch', fetch_info['url'], fetch_info['ref']])
5173 base = 'FETCH_HEAD'
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00005174
Aaron Gablea718c3e2017-08-28 17:47:28 -07005175 cmd = ['git', 'diff']
5176 if options.stat:
5177 cmd.append('--stat')
5178 cmd.append(base)
5179 subprocess2.check_call(cmd)
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00005180
5181 return 0
5182
5183
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005184@metrics.collector.collect_metrics('git cl owners')
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005185def CMDowners(parser, args):
Dirk Prankebf980882017-09-02 15:08:00 -07005186 """Finds potential owners for reviewing."""
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005187 parser.add_option(
Sidney San Martín8e6f58c2018-06-08 01:02:56 +00005188 '--ignore-current',
5189 action='store_true',
5190 help='Ignore the CL\'s current reviewers and start from scratch.')
5191 parser.add_option(
Sylvain Defresneb1f865d2019-02-12 12:38:22 +00005192 '--ignore-self',
5193 action='store_true',
5194 help='Do not consider CL\'s author as an owners.')
5195 parser.add_option(
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005196 '--no-color',
5197 action='store_true',
5198 help='Use this option to disable color output')
Dirk Prankebf980882017-09-02 15:08:00 -07005199 parser.add_option(
5200 '--batch',
5201 action='store_true',
5202 help='Do not run interactively, just suggest some')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00005203 auth.add_auth_options(parser)
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005204 options, args = parser.parse_args(args)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00005205 auth_config = auth.extract_auth_config_from_options(options)
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005206
5207 author = RunGit(['config', 'user.email']).strip() or None
5208
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00005209 cl = Changelist(auth_config=auth_config)
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005210
5211 if args:
5212 if len(args) > 1:
5213 parser.error('Unknown args')
5214 base_branch = args[0]
5215 else:
5216 # Default to diffing against the common ancestor of the upstream branch.
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00005217 base_branch = cl.GetCommonAncestorWithUpstream()
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005218
5219 change = cl.GetChange(base_branch, None)
Dirk Prankebf980882017-09-02 15:08:00 -07005220 affected_files = [f.LocalPath() for f in change.AffectedFiles()]
5221
5222 if options.batch:
5223 db = owners.Database(change.RepositoryRoot(), file, os.path)
5224 print('\n'.join(db.reviewers_for(affected_files, author)))
5225 return 0
5226
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005227 return owners_finder.OwnersFinder(
Dirk Prankebf980882017-09-02 15:08:00 -07005228 affected_files,
Jochen Eisinger72606f82017-04-04 10:44:18 +02005229 change.RepositoryRoot(),
Edward Lemur707d70b2018-02-07 00:50:14 +01005230 author,
Sidney San Martín8e6f58c2018-06-08 01:02:56 +00005231 [] if options.ignore_current else cl.GetReviewers(),
Edward Lemur707d70b2018-02-07 00:50:14 +01005232 fopen=file, os_path=os.path,
Jochen Eisingerd0573ec2017-04-13 10:55:06 +02005233 disable_color=options.no_color,
Sylvain Defresneb1f865d2019-02-12 12:38:22 +00005234 override_files=change.OriginalOwnersFiles(),
5235 ignore_author=options.ignore_self).run()
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005236
5237
Aiden Bennerc08566e2018-10-03 17:52:42 +00005238def BuildGitDiffCmd(diff_type, upstream_commit, args, allow_prefix=False):
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005239 """Generates a diff command."""
5240 # Generate diff for the current branch's changes.
Aiden Bennerc08566e2018-10-03 17:52:42 +00005241 diff_cmd = ['-c', 'core.quotePath=false', 'diff', '--no-ext-diff']
5242
Aiden Benner6c18a1a2018-11-23 20:18:23 +00005243 if allow_prefix:
5244 # explicitly setting --src-prefix and --dst-prefix is necessary in the
5245 # case that diff.noprefix is set in the user's git config.
5246 diff_cmd += ['--src-prefix=a/', '--dst-prefix=b/']
5247 else:
Aiden Bennerc08566e2018-10-03 17:52:42 +00005248 diff_cmd += ['--no-prefix']
5249
5250 diff_cmd += [diff_type, upstream_commit, '--']
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005251
5252 if args:
5253 for arg in args:
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005254 if os.path.isdir(arg) or os.path.isfile(arg):
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005255 diff_cmd.append(arg)
5256 else:
5257 DieWithError('Argument "%s" is not a file or a directory' % arg)
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005258
5259 return diff_cmd
5260
Andrii Shyshkalov18975322017-01-25 16:44:13 +01005261
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005262def MatchingFileType(file_name, extensions):
5263 """Returns true if the file name ends with one of the given extensions."""
5264 return bool([ext for ext in extensions if file_name.lower().endswith(ext)])
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005265
Andrii Shyshkalov18975322017-01-25 16:44:13 +01005266
enne@chromium.org555cfe42014-01-29 18:21:39 +00005267@subcommand.usage('[files or directories to diff]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005268@metrics.collector.collect_metrics('git cl format')
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005269def CMDformat(parser, args):
sbc@chromium.org9d0644d2015-06-05 23:16:54 +00005270 """Runs auto-formatting tools (clang-format etc.) on the diff."""
Christopher Lamc5ba6922017-01-24 11:19:14 +11005271 CLANG_EXTS = ['.cc', '.cpp', '.h', '.m', '.mm', '.proto', '.java']
kylechar58edce22016-06-17 06:07:51 -07005272 GN_EXTS = ['.gn', '.gni', '.typemap']
enne@chromium.org3b7e15c2014-01-21 17:44:47 +00005273 parser.add_option('--full', action='store_true',
5274 help='Reformat the full content of all touched files')
5275 parser.add_option('--dry-run', action='store_true',
5276 help='Don\'t modify any file on disk.')
Aiden Benner99b0ccb2018-11-20 19:53:31 +00005277 parser.add_option(
5278 '--python',
5279 action='store_true',
5280 default=None,
5281 help='Enables python formatting on all python files.')
5282 parser.add_option(
5283 '--no-python',
5284 action='store_true',
5285 dest='python',
5286 help='Disables python formatting on all python files. '
5287 'Takes precedence over --python. '
5288 'If neither --python or --no-python are set, python '
5289 'files that have a .style.yapf file in an ancestor '
5290 'directory will be formatted.')
Christopher Lamc5ba6922017-01-24 11:19:14 +11005291 parser.add_option('--js', action='store_true',
5292 help='Format javascript code with clang-format.')
wittman@chromium.org04d5a222014-03-07 18:30:42 +00005293 parser.add_option('--diff', action='store_true',
5294 help='Print diff to stdout rather than modifying files.')
Ilya Shermane081cbe2017-08-15 17:51:04 -07005295 parser.add_option('--presubmit', action='store_true',
5296 help='Used when running the script from a presubmit.')
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005297 opts, args = parser.parse_args(args)
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005298
Daniel Chengc55eecf2016-12-30 03:11:02 -08005299 # Normalize any remaining args against the current path, so paths relative to
5300 # the current directory are still resolved as expected.
5301 args = [os.path.join(os.getcwd(), arg) for arg in args]
5302
enne@chromium.orgff7a1fb2013-12-10 19:21:41 +00005303 # git diff generates paths against the root of the repository. Change
5304 # to that directory so clang-format can find files even within subdirs.
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00005305 rel_base_path = settings.GetRelativeRoot()
enne@chromium.orgff7a1fb2013-12-10 19:21:41 +00005306 if rel_base_path:
5307 os.chdir(rel_base_path)
5308
digit@chromium.org29e47272013-05-17 17:01:46 +00005309 # Grab the merge-base commit, i.e. the upstream commit of the current
5310 # branch when it was created or the last time it was rebased. This is
5311 # to cover the case where the user may have called "git fetch origin",
5312 # moving the origin branch to a newer commit, but hasn't rebased yet.
5313 upstream_commit = None
5314 cl = Changelist()
5315 upstream_branch = cl.GetUpstreamBranch()
5316 if upstream_branch:
5317 upstream_commit = RunGit(['merge-base', 'HEAD', upstream_branch])
5318 upstream_commit = upstream_commit.strip()
5319
5320 if not upstream_commit:
5321 DieWithError('Could not find base commit for this branch. '
5322 'Are you in detached state?')
5323
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005324 changed_files_cmd = BuildGitDiffCmd('--name-only', upstream_commit, args)
5325 diff_output = RunGit(changed_files_cmd)
5326 diff_files = diff_output.splitlines()
jkarlin@chromium.orgad21b922016-01-28 17:48:42 +00005327 # Filter out files deleted by this CL
5328 diff_files = [x for x in diff_files if os.path.isfile(x)]
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005329
Christopher Lamc5ba6922017-01-24 11:19:14 +11005330 if opts.js:
Deepanjan Roy605dd312018-07-02 17:48:54 +00005331 CLANG_EXTS.extend(['.js', '.ts'])
Christopher Lamc5ba6922017-01-24 11:19:14 +11005332
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005333 clang_diff_files = [x for x in diff_files if MatchingFileType(x, CLANG_EXTS)]
5334 python_diff_files = [x for x in diff_files if MatchingFileType(x, ['.py'])]
5335 dart_diff_files = [x for x in diff_files if MatchingFileType(x, ['.dart'])]
kylechar@chromium.org8b61f112016-02-05 13:28:58 +00005336 gn_diff_files = [x for x in diff_files if MatchingFileType(x, GN_EXTS)]
digit@chromium.org29e47272013-05-17 17:01:46 +00005337
nick@chromium.org3ac1c4e2014-01-16 02:44:42 +00005338 top_dir = os.path.normpath(
5339 RunGit(["rev-parse", "--show-toplevel"]).rstrip('\n'))
5340
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005341 # Set to 2 to signal to CheckPatchFormatted() that this patch isn't
5342 # formatted. This is used to block during the presubmit.
5343 return_value = 0
5344
sammc@chromium.org0b35f5d2016-02-25 22:39:23 +00005345 if clang_diff_files:
techtonik@gmail.com5573df12016-04-12 18:34:10 +00005346 # Locate the clang-format binary in the checkout
5347 try:
5348 clang_format_tool = clang_format.FindClangFormatToolInChromiumTree()
vapierfd77ac72016-06-16 08:33:57 -07005349 except clang_format.NotFoundError as e:
techtonik@gmail.com5573df12016-04-12 18:34:10 +00005350 DieWithError(e)
5351
sammc@chromium.org0b35f5d2016-02-25 22:39:23 +00005352 if opts.full:
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005353 cmd = [clang_format_tool]
5354 if not opts.dry_run and not opts.diff:
5355 cmd.append('-i')
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005356 stdout = RunCommand(cmd + clang_diff_files, cwd=top_dir)
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005357 if opts.diff:
5358 sys.stdout.write(stdout)
sammc@chromium.org0b35f5d2016-02-25 22:39:23 +00005359 else:
5360 env = os.environ.copy()
5361 env['PATH'] = str(os.path.dirname(clang_format_tool))
5362 try:
5363 script = clang_format.FindClangFormatScriptInChromiumTree(
5364 'clang-format-diff.py')
vapierfd77ac72016-06-16 08:33:57 -07005365 except clang_format.NotFoundError as e:
sammc@chromium.org0b35f5d2016-02-25 22:39:23 +00005366 DieWithError(e)
digit@chromium.orgd6ddc1c2013-10-25 15:36:32 +00005367
sammc@chromium.org0b35f5d2016-02-25 22:39:23 +00005368 cmd = [sys.executable, script, '-p0']
5369 if not opts.dry_run and not opts.diff:
5370 cmd.append('-i')
digit@chromium.orgd6ddc1c2013-10-25 15:36:32 +00005371
sammc@chromium.org0b35f5d2016-02-25 22:39:23 +00005372 diff_cmd = BuildGitDiffCmd('-U0', upstream_commit, clang_diff_files)
5373 diff_output = RunGit(diff_cmd)
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005374
sammc@chromium.org0b35f5d2016-02-25 22:39:23 +00005375 stdout = RunCommand(cmd, stdin=diff_output, cwd=top_dir, env=env)
5376 if opts.diff:
5377 sys.stdout.write(stdout)
5378 if opts.dry_run and len(stdout) > 0:
5379 return_value = 2
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005380
sbc@chromium.org9d0644d2015-06-05 23:16:54 +00005381 # Similar code to above, but using yapf on .py files rather than clang-format
5382 # on C/C++ files
Aiden Benner99b0ccb2018-11-20 19:53:31 +00005383 py_explicitly_disabled = opts.python is not None and not opts.python
5384 if python_diff_files and not py_explicitly_disabled:
Aiden Bennere47ac152018-11-20 16:44:03 +00005385 depot_tools_path = os.path.dirname(os.path.abspath(__file__))
5386 yapf_tool = os.path.join(depot_tools_path, 'yapf')
5387 if sys.platform.startswith('win'):
5388 yapf_tool += '.bat'
sbc@chromium.org9d0644d2015-06-05 23:16:54 +00005389
Aiden Bennerc08566e2018-10-03 17:52:42 +00005390 # If we couldn't find a yapf file we'll default to the chromium style
5391 # specified in depot_tools.
Aiden Bennerc08566e2018-10-03 17:52:42 +00005392 chromium_default_yapf_style = os.path.join(depot_tools_path,
5393 YAPF_CONFIG_FILENAME)
Aiden Bennerc08566e2018-10-03 17:52:42 +00005394 # Used for caching.
5395 yapf_configs = {}
5396 for f in python_diff_files:
5397 # Find the yapf style config for the current file, defaults to depot
5398 # tools default.
Aiden Benner99b0ccb2018-11-20 19:53:31 +00005399 _FindYapfConfigFile(f, yapf_configs, top_dir)
5400
5401 # Turn on python formatting by default if a yapf config is specified.
5402 # This breaks in the case of this repo though since the specified
5403 # style file is also the global default.
5404 if opts.python is None:
5405 filtered_py_files = []
5406 for f in python_diff_files:
5407 if _FindYapfConfigFile(f, yapf_configs, top_dir) is not None:
5408 filtered_py_files.append(f)
5409 else:
5410 filtered_py_files = python_diff_files
5411
5412 # Note: yapf still seems to fix indentation of the entire file
5413 # even if line ranges are specified.
5414 # See https://github.com/google/yapf/issues/499
5415 if not opts.full and filtered_py_files:
5416 py_line_diffs = _ComputeDiffLineRanges(filtered_py_files, upstream_commit)
5417
5418 for f in filtered_py_files:
5419 yapf_config = _FindYapfConfigFile(f, yapf_configs, top_dir)
5420 if yapf_config is None:
5421 yapf_config = chromium_default_yapf_style
Aiden Bennerc08566e2018-10-03 17:52:42 +00005422
5423 cmd = [yapf_tool, '--style', yapf_config, f]
5424
5425 has_formattable_lines = False
5426 if not opts.full:
5427 # Only run yapf over changed line ranges.
5428 for diff_start, diff_len in py_line_diffs[f]:
5429 diff_end = diff_start + diff_len - 1
5430 # Yapf errors out if diff_end < diff_start but this
5431 # is a valid line range diff for a removal.
5432 if diff_end >= diff_start:
5433 has_formattable_lines = True
5434 cmd += ['-l', '{}-{}'.format(diff_start, diff_end)]
5435 # If all line diffs were removals we have nothing to format.
5436 if not has_formattable_lines:
5437 continue
5438
5439 if opts.diff or opts.dry_run:
5440 cmd += ['--diff']
5441 # Will return non-zero exit code if non-empty diff.
5442 stdout = RunCommand(cmd, error_ok=True, cwd=top_dir)
5443 if opts.diff:
5444 sys.stdout.write(stdout)
5445 elif len(stdout) > 0:
5446 return_value = 2
5447 else:
5448 cmd += ['-i']
5449 RunCommand(cmd, cwd=top_dir)
sbc@chromium.org9d0644d2015-06-05 23:16:54 +00005450
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005451 # Dart's formatter does not have the nice property of only operating on
5452 # modified chunks, so hard code full.
5453 if dart_diff_files:
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005454 try:
5455 command = [dart_format.FindDartFmtToolInChromiumTree()]
5456 if not opts.dry_run and not opts.diff:
5457 command.append('-w')
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005458 command.extend(dart_diff_files)
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005459
ppi@chromium.org6593d932016-03-03 15:41:15 +00005460 stdout = RunCommand(command, cwd=top_dir)
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005461 if opts.dry_run and stdout:
5462 return_value = 2
5463 except dart_format.NotFoundError as e:
vapiera7fbd5a2016-06-16 09:17:49 -07005464 print('Warning: Unable to check Dart code formatting. Dart SDK not '
5465 'found in this checkout. Files in other languages are still '
5466 'formatted.')
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005467
kylechar@chromium.org8b61f112016-02-05 13:28:58 +00005468 # Format GN build files. Always run on full build files for canonical form.
5469 if gn_diff_files:
Andrii Shyshkalov18975322017-01-25 16:44:13 +01005470 cmd = ['gn', 'format']
brettw4b8ed592016-08-05 16:19:12 -07005471 if opts.dry_run or opts.diff:
5472 cmd.append('--dry-run')
kylechar@chromium.org8b61f112016-02-05 13:28:58 +00005473 for gn_diff_file in gn_diff_files:
brettw4b8ed592016-08-05 16:19:12 -07005474 gn_ret = subprocess2.call(cmd + [gn_diff_file],
5475 shell=sys.platform == 'win32',
5476 cwd=top_dir)
5477 if opts.dry_run and gn_ret == 2:
5478 return_value = 2 # Not formatted.
5479 elif opts.diff and gn_ret == 2:
5480 # TODO this should compute and print the actual diff.
5481 print("This change has GN build file diff for " + gn_diff_file)
5482 elif gn_ret != 0:
5483 # For non-dry run cases (and non-2 return values for dry-run), a
5484 # nonzero error code indicates a failure, probably because the file
5485 # doesn't parse.
5486 DieWithError("gn format failed on " + gn_diff_file +
5487 "\nTry running 'gn format' on this file manually.")
kylechar@chromium.org8b61f112016-02-05 13:28:58 +00005488
Ilya Shermane081cbe2017-08-15 17:51:04 -07005489 # Skip the metrics formatting from the global presubmit hook. These files have
5490 # a separate presubmit hook that issues an error if the files need formatting,
5491 # whereas the top-level presubmit script merely issues a warning. Formatting
5492 # these files is somewhat slow, so it's important not to duplicate the work.
5493 if not opts.presubmit:
5494 for xml_dir in GetDirtyMetricsDirs(diff_files):
5495 tool_dir = os.path.join(top_dir, xml_dir)
5496 cmd = [os.path.join(tool_dir, 'pretty_print.py'), '--non-interactive']
5497 if opts.dry_run or opts.diff:
5498 cmd.append('--diff')
Ilya Sherman235b70d2017-08-22 17:46:38 -07005499 stdout = RunCommand(cmd, cwd=top_dir)
Ilya Shermane081cbe2017-08-15 17:51:04 -07005500 if opts.diff:
5501 sys.stdout.write(stdout)
5502 if opts.dry_run and stdout:
5503 return_value = 2 # Not formatted.
Alexei Svitkinef3cac412017-02-06 11:08:50 -05005504
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005505 return return_value
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005506
Steven Holte2e664bf2017-04-21 13:10:47 -07005507def GetDirtyMetricsDirs(diff_files):
5508 xml_diff_files = [x for x in diff_files if MatchingFileType(x, ['.xml'])]
5509 metrics_xml_dirs = [
5510 os.path.join('tools', 'metrics', 'actions'),
5511 os.path.join('tools', 'metrics', 'histograms'),
5512 os.path.join('tools', 'metrics', 'rappor'),
5513 os.path.join('tools', 'metrics', 'ukm')]
5514 for xml_dir in metrics_xml_dirs:
5515 if any(file.startswith(xml_dir) for file in xml_diff_files):
5516 yield xml_dir
5517
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005518
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005519@subcommand.usage('<codereview url or issue id>')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005520@metrics.collector.collect_metrics('git cl checkout')
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005521def CMDcheckout(parser, args):
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00005522 """Checks out a branch associated with a given Rietveld or Gerrit issue."""
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005523 _, args = parser.parse_args(args)
5524
5525 if len(args) != 1:
5526 parser.print_help()
5527 return 1
5528
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00005529 issue_arg = ParseIssueNumberArgument(args[0])
tandrii@chromium.orgde6c9a12016-04-11 15:33:53 +00005530 if not issue_arg.valid:
Andrii Shyshkalov28d840e2017-04-10 15:45:09 +02005531 parser.error('invalid codereview url or CL id')
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02005532
tandrii@chromium.orgabd27e52016-04-11 15:43:32 +00005533 target_issue = str(issue_arg.issue)
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005534
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00005535 def find_issues(issueprefix):
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00005536 output = RunGit(['config', '--local', '--get-regexp',
5537 r'branch\..*\.%s' % issueprefix],
5538 error_ok=True)
5539 for key, issue in [x.split() for x in output.splitlines()]:
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00005540 if issue == target_issue:
5541 yield re.sub(r'branch\.(.*)\.%s' % issueprefix, r'\1', key)
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005542
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00005543 branches = []
5544 for cls in _CODEREVIEW_IMPLEMENTATIONS.values():
tandrii5d48c322016-08-18 16:19:37 -07005545 branches.extend(find_issues(cls.IssueConfigKey()))
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005546 if len(branches) == 0:
vapiera7fbd5a2016-06-16 09:17:49 -07005547 print('No branch found for issue %s.' % target_issue)
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005548 return 1
5549 if len(branches) == 1:
5550 RunGit(['checkout', branches[0]])
5551 else:
vapiera7fbd5a2016-06-16 09:17:49 -07005552 print('Multiple branches match issue %s:' % target_issue)
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005553 for i in range(len(branches)):
vapiera7fbd5a2016-06-16 09:17:49 -07005554 print('%d: %s' % (i, branches[i]))
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005555 which = raw_input('Choose by index: ')
5556 try:
5557 RunGit(['checkout', branches[int(which)]])
5558 except (IndexError, ValueError):
vapiera7fbd5a2016-06-16 09:17:49 -07005559 print('Invalid selection, not checking out any branch.')
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005560 return 1
5561
5562 return 0
5563
5564
maruel@chromium.org29404b52014-09-08 22:58:00 +00005565def CMDlol(parser, args):
5566 # This command is intentionally undocumented.
vapiera7fbd5a2016-06-16 09:17:49 -07005567 print(zlib.decompress(base64.b64decode(
thakis@chromium.org3421c992014-11-02 02:20:32 +00005568 'eNptkLEOwyAMRHe+wupCIqW57v0Vq84WqWtXyrcXnCBsmgMJ+/SSAxMZgRB6NzE'
5569 'E2ObgCKJooYdu4uAQVffUEoE1sRQLxAcqzd7uK2gmStrll1ucV3uZyaY5sXyDd9'
5570 'JAnN+lAXsOMJ90GANAi43mq5/VeeacylKVgi8o6F1SC63FxnagHfJUTfUYdCR/W'
vapiera7fbd5a2016-06-16 09:17:49 -07005571 'Ofe+0dHL7PicpytKP750Fh1q2qnLVof4w8OZWNY')))
maruel@chromium.org29404b52014-09-08 22:58:00 +00005572 return 0
5573
5574
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005575class OptionParser(optparse.OptionParser):
5576 """Creates the option parse and add --verbose support."""
5577 def __init__(self, *args, **kwargs):
maruel@chromium.org0633fb42013-08-16 20:06:14 +00005578 optparse.OptionParser.__init__(
5579 self, *args, prog='git cl', version=__version__, **kwargs)
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005580 self.add_option(
5581 '-v', '--verbose', action='count', default=0,
5582 help='Use 2 times for more debugging info')
5583
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005584 def parse_args(self, args=None, _values=None):
Andrii Shyshkalov46f20cd2018-10-30 06:42:54 +00005585 try:
5586 return self._parse_args(args)
5587 finally:
5588 # Regardless of success or failure of args parsing, we want to report
5589 # metrics, but only after logging has been initialized (if parsing
5590 # succeeded).
5591 global settings
5592 settings = Settings()
5593
5594 if not metrics.DISABLE_METRICS_COLLECTION:
5595 # GetViewVCUrl ultimately calls logging method.
5596 project_url = settings.GetViewVCUrl().strip('/+')
5597 if project_url in metrics_utils.KNOWN_PROJECT_URLS:
5598 metrics.collector.add('project_urls', [project_url])
5599
5600 def _parse_args(self, args=None):
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005601 # Create an optparse.Values object that will store only the actual passed
5602 # options, without the defaults.
5603 actual_options = optparse.Values()
5604 _, args = optparse.OptionParser.parse_args(self, args, actual_options)
5605 # Create an optparse.Values object with the default options.
5606 options = optparse.Values(self.get_default_values().__dict__)
5607 # Update it with the options passed by the user.
5608 options._update_careful(actual_options.__dict__)
5609 # Store the options passed by the user in an _actual_options attribute.
5610 # We store only the keys, and not the values, since the values can contain
5611 # arbitrary information, which might be PII.
5612 metrics.collector.add('arguments', actual_options.__dict__.keys())
5613
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005614 levels = [logging.WARNING, logging.INFO, logging.DEBUG]
Andrii Shyshkalov5b04a572017-01-23 17:44:41 +01005615 logging.basicConfig(
5616 level=levels[min(options.verbose, len(levels) - 1)],
5617 format='[%(levelname).1s%(asctime)s %(process)d %(thread)d '
5618 '%(filename)s] %(message)s')
Edward Lemur83bd7f42018-10-10 00:14:21 +00005619
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005620 return options, args
5621
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005622
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005623def main(argv):
maruel@chromium.org82798cb2012-02-23 18:16:12 +00005624 if sys.hexversion < 0x02060000:
vapiera7fbd5a2016-06-16 09:17:49 -07005625 print('\nYour python version %s is unsupported, please upgrade.\n' %
5626 (sys.version.split(' ', 1)[0],), file=sys.stderr)
maruel@chromium.org82798cb2012-02-23 18:16:12 +00005627 return 2
maruel@chromium.org2e23ce32013-05-07 12:42:28 +00005628
maruel@chromium.org39c0b222013-08-17 16:57:01 +00005629 colorize_CMDstatus_doc()
maruel@chromium.org0633fb42013-08-16 20:06:14 +00005630 dispatcher = subcommand.CommandDispatcher(__name__)
5631 try:
5632 return dispatcher.execute(OptionParser(), argv)
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +00005633 except auth.AuthenticationError as e:
5634 DieWithError(str(e))
vapierfd77ac72016-06-16 08:33:57 -07005635 except urllib2.HTTPError as e:
maruel@chromium.org0633fb42013-08-16 20:06:14 +00005636 if e.code != 500:
5637 raise
5638 DieWithError(
5639 ('AppEngine is misbehaving and returned HTTP %d, again. Keep faith '
5640 'and retry or visit go/isgaeup.\n%s') % (e.code, str(e)))
sbc@chromium.org013731e2015-02-26 18:28:43 +00005641 return 0
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005642
5643
5644if __name__ == '__main__':
maruel@chromium.org2e23ce32013-05-07 12:42:28 +00005645 # These affect sys.stdout so do it outside of main() to simplify mocks in
5646 # unit testing.
maruel@chromium.org6f09cd92011-04-01 16:38:12 +00005647 fix_encoding.fix_encoding()
iannucci@chromium.org596cd5c2016-04-04 21:34:39 +00005648 setup_color.init()
Edward Lemur6f812e12018-07-31 22:45:57 +00005649 with metrics.collector.print_notice_and_exit():
sbc@chromium.org013731e2015-02-26 18:28:43 +00005650 sys.exit(main(sys.argv[1:]))