commit d87b09662ee8a8b50b2dd36630e9a9c4df562d1c
author Joe Mason <joenotcharles@google.com> Mon Dec 03 21:04:46 2018 +0000
committer Commit Bot <commit-bot@chromium.org> Mon Dec 03 21:04:46 2018 +0000
tree 8a7c52304cb7fbee49dbb78e14a9600fc5a5bda5
parent 7808a519be73aaf96b50acde8a3b80dd6213d1a0

More context when _load_codereview_impl asserts

Bug: 908466
Change-Id: I715633c64fff343d07dbcf50c261e686d77e8c44
Reviewed-on: https://chromium-review.googlesource.com/c/1351511
Reviewed-by: Andy Perelson <ajp@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Joe Mason <joenotcharles@google.com>

git_cl.py

diff --git a/git_cl.py b/git_cl.py
index c076d87..a981b6e 100755
--- a/git_cl.py
+++ b/git_cl.py
@@ -1110,7 +1110,9 @@
 
   def _load_codereview_impl(self, codereview=None, **kwargs):
     if codereview:
-      assert codereview in _CODEREVIEW_IMPLEMENTATIONS
+      assert codereview in _CODEREVIEW_IMPLEMENTATIONS, (
+          'codereview {} not in {}'.format(codereview,
+                                           _CODEREVIEW_IMPLEMENTATIONS))
       cls = _CODEREVIEW_IMPLEMENTATIONS[codereview]
       self._codereview = codereview
       self._codereview_impl = cls(self, **kwargs)