commit 707d70b91e5f60ac78b194d04866ebfb55359061
author Edward Lemur <ehmaldonado@chromium.org> Wed Feb 07 00:50:14 2018 +0100
committer Commit Bot <commit-bot@chromium.org> Wed Feb 07 20:34:44 2018 +0000
tree 77f1cf1d810643f80c7039529235caa5a0ce8c43
parent 4a92cc9a1f7ced74f01473c7040992a97c1a4079

Skip files owned by reviewers when quering for missing owners.

Bug: 728298
Change-Id: If813ff41b1668a2cab6c26b65e424fbe574e629c
Reviewed-on: https://chromium-review.googlesource.com/899086
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>

git_cl.py

diff --git a/git_cl.py b/git_cl.py
index 07cf9f3..5a9db7e 100755
--- a/git_cl.py
+++ b/git_cl.py
@@ -1750,6 +1750,9 @@
     """Get owner from codereview, which may differ from this checkout."""
     return self._codereview_impl.GetIssueOwner()
 
+  def GetReviewers(self):
+    return self._codereview_impl.GetReviewers()
+
   def GetMostRecentPatchset(self):
     return self._codereview_impl.GetMostRecentPatchset()
 
@@ -1908,6 +1911,9 @@
   def GetIssueOwner(self):
     raise NotImplementedError()
 
+  def GetReviewers(self):
+    raise NotImplementedError()
+
   def GetTryJobProperties(self, patchset=None):
     raise NotImplementedError()
 
@@ -2010,6 +2016,9 @@
   def GetIssueOwner(self):
     return (self.GetIssueProperties() or {}).get('owner_email')
 
+  def GetReviewers(self):
+    return (self.GetIssueProperties() or {}).get('reviewers')
+
   def AddComment(self, message, publish=None):
     return self.RpcServer().add_comment(self.GetIssue(), message)
 
@@ -3278,6 +3287,10 @@
   def GetIssueOwner(self):
     return self._GetChangeDetail(['DETAILED_ACCOUNTS'])['owner']['email']
 
+  def GetReviewers(self):
+    details = self._GetChangeDetail(['DETAILED_ACCOUNTS'])
+    return [reviewer['email'] for reviewer in details['reviewers']['REVIEWER']]
+
 
 _CODEREVIEW_IMPLEMENTATIONS = {
   'rietveld': _RietveldChangelistImpl,
@@ -5896,7 +5909,9 @@
   return owners_finder.OwnersFinder(
       affected_files,
       change.RepositoryRoot(),
-      author, fopen=file, os_path=os.path,
+      author,
+      cl.GetReviewers(),
+      fopen=file, os_path=os.path,
       disable_color=options.no_color,
       override_files=change.OriginalOwnersFiles()).run()