blob: 756b683e36f8fdb1ecef386bf3a8e4ccc07af459 [file] [log] [blame]
iannucci@chromium.org405b87e2015-11-12 18:08:34 +00001#!/usr/bin/env python
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +02002# Copyright (c) 2013 The Chromium Authors. All rights reserved.
maruel@chromium.org725f1c32011-04-01 20:24:54 +00003# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00006# Copyright (C) 2008 Evan Martin <martine@danga.com>
7
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00008"""A git-command for integrating reviews on Rietveld and Gerrit."""
maruel@chromium.org725f1c32011-04-01 20:24:54 +00009
vapiera7fbd5a2016-06-16 09:17:49 -070010from __future__ import print_function
11
tapted@chromium.org6a0b07c2013-07-10 01:29:19 +000012from distutils.version import LooseVersion
calamity@chromium.orgffde55c2015-03-12 00:44:17 +000013from multiprocessing.pool import ThreadPool
thakis@chromium.org3421c992014-11-02 02:20:32 +000014import base64
rmistry@google.com2dd99862015-06-22 12:22:18 +000015import collections
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +010016import contextlib
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +010017import datetime
Andrii Shyshkalovcd6a9362016-12-07 12:04:12 +010018import fnmatch
sheyang@google.com6ebaf782015-05-12 19:17:54 +000019import httplib
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +010020import itertools
maruel@chromium.org4f6852c2012-04-20 20:39:20 +000021import json
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000022import logging
calamity@chromium.orgcf197482016-04-29 20:15:53 +000023import multiprocessing
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000024import optparse
25import os
26import re
Andrii Shyshkalov353637c2017-03-14 16:52:18 +010027import shutil
ukai@chromium.org78c4b982012-02-14 02:20:26 +000028import stat
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000029import sys
Aaron Gable9a03ae02017-11-03 11:31:07 -070030import tempfile
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000031import textwrap
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +000032import urllib
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000033import urllib2
maruel@chromium.org967c0a82013-06-17 22:52:24 +000034import urlparse
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +000035import uuid
thestig@chromium.org00858c82013-12-02 23:08:03 +000036import webbrowser
thakis@chromium.org3421c992014-11-02 02:20:32 +000037import zlib
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000038
39try:
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -080040 import readline # pylint: disable=import-error,W0611
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000041except ImportError:
42 pass
43
maruel@chromium.org2e23ce32013-05-07 12:42:28 +000044from third_party import colorama
sheyang@google.com6ebaf782015-05-12 19:17:54 +000045from third_party import httplib2
maruel@chromium.org2a74d372011-03-29 19:05:50 +000046from third_party import upload
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +000047import auth
skobes6468b902016-10-24 08:45:10 -070048import checkout
nick@chromium.org3ac1c4e2014-01-16 02:44:42 +000049import clang_format
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +000050import dart_format
iannucci@chromium.org596cd5c2016-04-04 21:34:39 +000051import setup_color
maruel@chromium.org6f09cd92011-04-01 16:38:12 +000052import fix_encoding
maruel@chromium.org0e0436a2011-10-25 13:32:41 +000053import gclient_utils
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +000054import gerrit_util
szager@chromium.org151ebcf2016-03-09 01:08:25 +000055import git_cache
iannucci@chromium.org9e849272014-04-04 00:31:55 +000056import git_common
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +000057import git_footers
Edward Lemur5ba1e9c2018-07-23 18:19:02 +000058import metrics
piman@chromium.org336f9122014-09-04 02:16:55 +000059import owners
iannucci@chromium.org9e849272014-04-04 00:31:55 +000060import owners_finder
maruel@chromium.org2a74d372011-03-29 19:05:50 +000061import presubmit_support
maruel@chromium.orgcab38e92011-04-09 00:30:51 +000062import rietveld
maruel@chromium.org2a74d372011-03-29 19:05:50 +000063import scm
Francois Dorayd42c6812017-05-30 15:10:20 -040064import split_cl
maruel@chromium.org0633fb42013-08-16 20:06:14 +000065import subcommand
maruel@chromium.org32f9f5e2011-09-14 13:41:47 +000066import subprocess2
maruel@chromium.org2a74d372011-03-29 19:05:50 +000067import watchlists
68
tandrii7400cf02016-06-21 08:48:07 -070069__version__ = '2.0'
maruel@chromium.org2a74d372011-03-29 19:05:50 +000070
tandrii9d2c7a32016-06-22 03:42:45 -070071COMMIT_BOT_EMAIL = 'commit-bot@chromium.org'
iannuccie7f68952016-08-15 17:45:29 -070072DEFAULT_SERVER = 'https://codereview.chromium.org'
Aaron Gable1bc7bfe2016-12-19 10:08:14 -080073POSTUPSTREAM_HOOK = '.git/hooks/post-cl-land'
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000074DESCRIPTION_BACKUP_FILE = '~/.git_cl_description_backup'
rmistry@google.comc68112d2015-03-03 12:48:06 +000075REFS_THAT_ALIAS_TO_OTHER_REFS = {
76 'refs/remotes/origin/lkgr': 'refs/remotes/origin/master',
77 'refs/remotes/origin/lkcr': 'refs/remotes/origin/master',
78}
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000079
thestig@chromium.org44202a22014-03-11 19:22:18 +000080# Valid extensions for files we want to lint.
81DEFAULT_LINT_REGEX = r"(.*\.cpp|.*\.cc|.*\.h)"
82DEFAULT_LINT_IGNORE_REGEX = r"$^"
83
borenet6c0efe62016-10-19 08:13:29 -070084# Buildbucket master name prefix.
85MASTER_PREFIX = 'master.'
86
maruel@chromium.org2e23ce32013-05-07 12:42:28 +000087# Shortcut since it quickly becomes redundant.
88Fore = colorama.Fore
maruel@chromium.org90541732011-04-01 17:54:18 +000089
maruel@chromium.orgddd59412011-11-30 14:20:38 +000090# Initialized in main()
91settings = None
92
Andrii Shyshkalov768f1d82016-12-08 15:10:13 +010093# Used by tests/git_cl_test.py to add extra logging.
94# Inside the weirdly failing test, add this:
95# >>> self.mock(git_cl, '_IS_BEING_TESTED', True)
Quinten Yearsley0c62da92017-05-31 13:39:42 -070096# And scroll up to see the stack trace printed.
Andrii Shyshkalov768f1d82016-12-08 15:10:13 +010097_IS_BEING_TESTED = False
98
maruel@chromium.orgddd59412011-11-30 14:20:38 +000099
Christopher Lamf732cd52017-01-24 12:40:11 +1100100def DieWithError(message, change_desc=None):
101 if change_desc:
102 SaveDescriptionBackup(change_desc)
103
vapiera7fbd5a2016-06-16 09:17:49 -0700104 print(message, file=sys.stderr)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000105 sys.exit(1)
106
107
Christopher Lamf732cd52017-01-24 12:40:11 +1100108def SaveDescriptionBackup(change_desc):
109 backup_path = os.path.expanduser(DESCRIPTION_BACKUP_FILE)
110 print('\nError after CL description prompt -- saving description to %s\n' %
111 backup_path)
112 backup_file = open(backup_path, 'w')
113 backup_file.write(change_desc.description)
114 backup_file.close()
115
116
thestig@chromium.org8b0553c2014-02-11 00:33:37 +0000117def GetNoGitPagerEnv():
118 env = os.environ.copy()
119 # 'cat' is a magical git string that disables pagers on all platforms.
120 env['GIT_PAGER'] = 'cat'
121 return env
122
vadimsh@chromium.org566a02a2014-08-22 01:34:13 +0000123
bsep@chromium.org627d9002016-04-29 00:00:52 +0000124def RunCommand(args, error_ok=False, error_message=None, shell=False, **kwargs):
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000125 try:
bsep@chromium.org627d9002016-04-29 00:00:52 +0000126 return subprocess2.check_output(args, shell=shell, **kwargs)
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000127 except subprocess2.CalledProcessError as e:
128 logging.debug('Failed running %s', args)
maruel@chromium.org32f9f5e2011-09-14 13:41:47 +0000129 if not error_ok:
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000130 DieWithError(
maruel@chromium.org32f9f5e2011-09-14 13:41:47 +0000131 'Command "%s" failed.\n%s' % (
132 ' '.join(args), error_message or e.stdout or ''))
133 return e.stdout
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000134
135
136def RunGit(args, **kwargs):
maruel@chromium.org32f9f5e2011-09-14 13:41:47 +0000137 """Returns stdout."""
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000138 return RunCommand(['git'] + args, **kwargs)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000139
140
enne@chromium.org3b7e15c2014-01-21 17:44:47 +0000141def RunGitWithCode(args, suppress_stderr=False):
maruel@chromium.org32f9f5e2011-09-14 13:41:47 +0000142 """Returns return code and stdout."""
tandrii5d48c322016-08-18 16:19:37 -0700143 if suppress_stderr:
144 stderr = subprocess2.VOID
145 else:
146 stderr = sys.stderr
szager@chromium.org9bb85e22012-06-13 20:28:23 +0000147 try:
tandrii5d48c322016-08-18 16:19:37 -0700148 (out, _), code = subprocess2.communicate(['git'] + args,
149 env=GetNoGitPagerEnv(),
150 stdout=subprocess2.PIPE,
151 stderr=stderr)
152 return code, out
153 except subprocess2.CalledProcessError as e:
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +0900154 logging.debug('Failed running %s', ['git'] + args)
tandrii5d48c322016-08-18 16:19:37 -0700155 return e.returncode, e.stdout
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000156
157
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000158def RunGitSilent(args):
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +0000159 """Returns stdout, suppresses stderr and ignores the return code."""
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000160 return RunGitWithCode(args, suppress_stderr=True)[1]
161
162
tapted@chromium.org6a0b07c2013-07-10 01:29:19 +0000163def IsGitVersionAtLeast(min_version):
ilevy@chromium.orgcc56ee42013-07-10 22:16:29 +0000164 prefix = 'git version '
tapted@chromium.org6a0b07c2013-07-10 01:29:19 +0000165 version = RunGit(['--version']).strip()
ilevy@chromium.orgcc56ee42013-07-10 22:16:29 +0000166 return (version.startswith(prefix) and
167 LooseVersion(version[len(prefix):]) >= LooseVersion(min_version))
tapted@chromium.org6a0b07c2013-07-10 01:29:19 +0000168
169
pgervais@chromium.org8ba38ff2015-06-11 21:41:25 +0000170def BranchExists(branch):
171 """Return True if specified branch exists."""
172 code, _ = RunGitWithCode(['rev-parse', '--verify', branch],
173 suppress_stderr=True)
174 return not code
175
176
tandrii2a16b952016-10-19 07:09:44 -0700177def time_sleep(seconds):
178 # Use this so that it can be mocked in tests without interfering with python
179 # system machinery.
180 import time # Local import to discourage others from importing time globally.
181 return time.sleep(seconds)
182
183
maruel@chromium.org90541732011-04-01 17:54:18 +0000184def ask_for_data(prompt):
185 try:
186 return raw_input(prompt)
187 except KeyboardInterrupt:
188 # Hide the exception.
189 sys.exit(1)
190
191
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100192def confirm_or_exit(prefix='', action='confirm'):
193 """Asks user to press enter to continue or press Ctrl+C to abort."""
194 if not prefix or prefix.endswith('\n'):
195 mid = 'Press'
Andrii Shyshkalov353637c2017-03-14 16:52:18 +0100196 elif prefix.endswith('.') or prefix.endswith('?'):
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100197 mid = ' Press'
198 elif prefix.endswith(' '):
199 mid = 'press'
200 else:
201 mid = ' press'
202 ask_for_data('%s%s Enter to %s, or Ctrl+C to abort' % (prefix, mid, action))
203
204
205def ask_for_explicit_yes(prompt):
206 """Returns whether user typed 'y' or 'yes' to confirm the given prompt"""
207 result = ask_for_data(prompt + ' [Yes/No]: ').lower()
208 while True:
209 if 'yes'.startswith(result):
210 return True
211 if 'no'.startswith(result):
212 return False
213 result = ask_for_data('Please, type yes or no: ').lower()
214
215
tandrii5d48c322016-08-18 16:19:37 -0700216def _git_branch_config_key(branch, key):
217 """Helper method to return Git config key for a branch."""
218 assert branch, 'branch name is required to set git config for it'
219 return 'branch.%s.%s' % (branch, key)
220
221
222def _git_get_branch_config_value(key, default=None, value_type=str,
223 branch=False):
224 """Returns git config value of given or current branch if any.
225
226 Returns default in all other cases.
227 """
228 assert value_type in (int, str, bool)
229 if branch is False: # Distinguishing default arg value from None.
230 branch = GetCurrentBranch()
231
rogerta@chromium.orgcaa16552013-03-18 20:45:05 +0000232 if not branch:
tandrii5d48c322016-08-18 16:19:37 -0700233 return default
rogerta@chromium.orgcaa16552013-03-18 20:45:05 +0000234
tandrii5d48c322016-08-18 16:19:37 -0700235 args = ['config']
tandrii33a46ff2016-08-23 05:53:40 -0700236 if value_type == bool:
tandrii5d48c322016-08-18 16:19:37 -0700237 args.append('--bool')
tandrii33a46ff2016-08-23 05:53:40 -0700238 # git config also has --int, but apparently git config suffers from integer
239 # overflows (http://crbug.com/640115), so don't use it.
tandrii5d48c322016-08-18 16:19:37 -0700240 args.append(_git_branch_config_key(branch, key))
241 code, out = RunGitWithCode(args)
242 if code == 0:
243 value = out.strip()
244 if value_type == int:
245 return int(value)
246 if value_type == bool:
247 return bool(value.lower() == 'true')
248 return value
iannucci@chromium.org79540052012-10-19 23:15:26 +0000249 return default
250
251
tandrii5d48c322016-08-18 16:19:37 -0700252def _git_set_branch_config_value(key, value, branch=None, **kwargs):
253 """Sets the value or unsets if it's None of a git branch config.
254
255 Valid, though not necessarily existing, branch must be provided,
256 otherwise currently checked out branch is used.
257 """
258 if not branch:
259 branch = GetCurrentBranch()
260 assert branch, 'a branch name OR currently checked out branch is required'
261 args = ['config']
qyearsley12fa6ff2016-08-24 09:18:40 -0700262 # Check for boolean first, because bool is int, but int is not bool.
tandrii5d48c322016-08-18 16:19:37 -0700263 if value is None:
264 args.append('--unset')
265 elif isinstance(value, bool):
266 args.append('--bool')
267 value = str(value).lower()
tandrii5d48c322016-08-18 16:19:37 -0700268 else:
tandrii33a46ff2016-08-23 05:53:40 -0700269 # git config also has --int, but apparently git config suffers from integer
270 # overflows (http://crbug.com/640115), so don't use it.
tandrii5d48c322016-08-18 16:19:37 -0700271 value = str(value)
272 args.append(_git_branch_config_key(branch, key))
273 if value is not None:
274 args.append(value)
275 RunGit(args, **kwargs)
276
277
Andrii Shyshkalova6695812016-12-06 17:47:09 +0100278def _get_committer_timestamp(commit):
Quinten Yearsley0c62da92017-05-31 13:39:42 -0700279 """Returns Unix timestamp as integer of a committer in a commit.
Andrii Shyshkalova6695812016-12-06 17:47:09 +0100280
281 Commit can be whatever git show would recognize, such as HEAD, sha1 or ref.
282 """
283 # Git also stores timezone offset, but it only affects visual display,
284 # actual point in time is defined by this timestamp only.
285 return int(RunGit(['show', '-s', '--format=%ct', commit]).strip())
286
287
288def _git_amend_head(message, committer_timestamp):
289 """Amends commit with new message and desired committer_timestamp.
290
291 Sets committer timezone to UTC.
292 """
293 env = os.environ.copy()
294 env['GIT_COMMITTER_DATE'] = '%d+0000' % committer_timestamp
295 return RunGit(['commit', '--amend', '-m', message], env=env)
296
297
machenbach@chromium.org45453142015-09-15 08:45:22 +0000298def _get_properties_from_options(options):
299 properties = dict(x.split('=', 1) for x in options.properties)
300 for key, val in properties.iteritems():
301 try:
302 properties[key] = json.loads(val)
303 except ValueError:
304 pass # If a value couldn't be evaluated, treat it as a string.
305 return properties
306
307
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000308def _prefix_master(master):
309 """Convert user-specified master name to full master name.
310
311 Buildbucket uses full master name(master.tryserver.chromium.linux) as bucket
312 name, while the developers always use shortened master name
313 (tryserver.chromium.linux) by stripping off the prefix 'master.'. This
314 function does the conversion for buildbucket migration.
315 """
borenet6c0efe62016-10-19 08:13:29 -0700316 if master.startswith(MASTER_PREFIX):
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000317 return master
borenet6c0efe62016-10-19 08:13:29 -0700318 return '%s%s' % (MASTER_PREFIX, master)
319
320
321def _unprefix_master(bucket):
322 """Convert bucket name to shortened master name.
323
324 Buildbucket uses full master name(master.tryserver.chromium.linux) as bucket
325 name, while the developers always use shortened master name
326 (tryserver.chromium.linux) by stripping off the prefix 'master.'. This
327 function does the conversion for buildbucket migration.
328 """
329 if bucket.startswith(MASTER_PREFIX):
330 return bucket[len(MASTER_PREFIX):]
331 return bucket
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000332
333
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000334def _buildbucket_retry(operation_name, http, *args, **kwargs):
335 """Retries requests to buildbucket service and returns parsed json content."""
336 try_count = 0
337 while True:
338 response, content = http.request(*args, **kwargs)
339 try:
340 content_json = json.loads(content)
341 except ValueError:
342 content_json = None
343
344 # Buildbucket could return an error even if status==200.
345 if content_json and content_json.get('error'):
nodir@chromium.orgbaff4e12016-03-08 00:33:57 +0000346 error = content_json.get('error')
347 if error.get('code') == 403:
348 raise BuildbucketResponseException(
349 'Access denied: %s' % error.get('message', ''))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000350 msg = 'Error in response. Reason: %s. Message: %s.' % (
nodir@chromium.orgbaff4e12016-03-08 00:33:57 +0000351 error.get('reason', ''), error.get('message', ''))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000352 raise BuildbucketResponseException(msg)
353
354 if response.status == 200:
Nodir Turakulov23d75d22018-06-04 12:37:32 -0700355 if content_json is None:
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000356 raise BuildbucketResponseException(
357 'Buildbucket returns invalid json content: %s.\n'
Nodir Turakulov9ac59792018-06-04 12:34:14 -0700358 'Please file bugs at http://crbug.com, '
359 'component "Infra>Platform>BuildBucket".' %
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000360 content)
361 return content_json
362 if response.status < 500 or try_count >= 2:
363 raise httplib2.HttpLib2Error(content)
364
365 # status >= 500 means transient failures.
366 logging.debug('Transient errors when %s. Will retry.', operation_name)
tandrii2a16b952016-10-19 07:09:44 -0700367 time_sleep(0.5 + 1.5*try_count)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000368 try_count += 1
369 assert False, 'unreachable'
370
371
qyearsley1fdfcb62016-10-24 13:22:03 -0700372def _get_bucket_map(changelist, options, option_parser):
qyearsleydd49f942016-10-28 11:57:22 -0700373 """Returns a dict mapping bucket names to builders and tests,
374 for triggering try jobs.
qyearsley1fdfcb62016-10-24 13:22:03 -0700375 """
qyearsleydd49f942016-10-28 11:57:22 -0700376 # If no bots are listed, we try to get a set of builders and tests based
377 # on GetPreferredTryMasters functions in PRESUBMIT.py files.
qyearsley1fdfcb62016-10-24 13:22:03 -0700378 if not options.bot:
379 change = changelist.GetChange(
380 changelist.GetCommonAncestorWithUpstream(), None)
qyearsley136b49f2016-10-31 09:02:26 -0700381 # Get try masters from PRESUBMIT.py files.
nodire4f0fe02016-11-04 16:23:30 -0700382 masters = presubmit_support.DoGetTryMasters(
qyearsley1fdfcb62016-10-24 13:22:03 -0700383 change=change,
384 changed_files=change.LocalPaths(),
385 repository_root=settings.GetRoot(),
386 default_presubmit=None,
387 project=None,
388 verbose=options.verbose,
389 output_stream=sys.stdout)
nodire4f0fe02016-11-04 16:23:30 -0700390 if masters is None:
391 return None
Sergiy Byelozyorov935b93f2016-11-28 20:41:56 +0100392 return {_prefix_master(m): b for m, b in masters.iteritems()}
qyearsley1fdfcb62016-10-24 13:22:03 -0700393
qyearsley1fdfcb62016-10-24 13:22:03 -0700394 if options.bucket:
395 return {options.bucket: {b: [] for b in options.bot}}
qyearsleydd49f942016-10-28 11:57:22 -0700396 if options.master:
397 return {_prefix_master(options.master): {b: [] for b in options.bot}}
qyearsley1fdfcb62016-10-24 13:22:03 -0700398
qyearsleydd49f942016-10-28 11:57:22 -0700399 # If bots are listed but no master or bucket, then we need to find out
400 # the corresponding master for each bot.
401 bucket_map, error_message = _get_bucket_map_for_builders(options.bot)
402 if error_message:
403 option_parser.error(
404 'Tryserver master cannot be found because: %s\n'
405 'Please manually specify the tryserver master, e.g. '
406 '"-m tryserver.chromium.linux".' % error_message)
407 return bucket_map
qyearsley1fdfcb62016-10-24 13:22:03 -0700408
409
qyearsley123a4682016-10-26 09:12:17 -0700410def _get_bucket_map_for_builders(builders):
411 """Returns a map of buckets to builders for the given builders."""
qyearsley1fdfcb62016-10-24 13:22:03 -0700412 map_url = 'https://builders-map.appspot.com/'
413 try:
qyearsley123a4682016-10-26 09:12:17 -0700414 builders_map = json.load(urllib2.urlopen(map_url))
qyearsley1fdfcb62016-10-24 13:22:03 -0700415 except urllib2.URLError as e:
416 return None, ('Failed to fetch builder-to-master map from %s. Error: %s.' %
417 (map_url, e))
418 except ValueError as e:
419 return None, ('Invalid json string from %s. Error: %s.' % (map_url, e))
qyearsley123a4682016-10-26 09:12:17 -0700420 if not builders_map:
qyearsley1fdfcb62016-10-24 13:22:03 -0700421 return None, 'Failed to build master map.'
422
qyearsley123a4682016-10-26 09:12:17 -0700423 bucket_map = {}
424 for builder in builders:
Nodir Turakulovb422e682018-02-20 22:51:30 -0800425 bucket = builders_map.get(builder, {}).get('bucket')
426 if bucket:
427 bucket_map.setdefault(bucket, {})[builder] = []
qyearsley123a4682016-10-26 09:12:17 -0700428 return bucket_map, None
qyearsley1fdfcb62016-10-24 13:22:03 -0700429
430
Andrii Shyshkalovf9648b52018-02-21 22:32:42 -0800431def _trigger_try_jobs(auth_config, changelist, buckets, options, patchset):
qyearsley1fdfcb62016-10-24 13:22:03 -0700432 """Sends a request to Buildbucket to trigger try jobs for a changelist.
433
434 Args:
Aaron Gablefb28d482018-04-02 13:08:06 -0700435 auth_config: AuthConfig for Buildbucket.
qyearsley1fdfcb62016-10-24 13:22:03 -0700436 changelist: Changelist that the try jobs are associated with.
437 buckets: A nested dict mapping bucket names to builders to tests.
438 options: Command-line options.
439 """
tandriide281ae2016-10-12 06:02:30 -0700440 assert changelist.GetIssue(), 'CL must be uploaded first'
441 codereview_url = changelist.GetCodereviewServer()
442 assert codereview_url, 'CL must be uploaded first'
443 patchset = patchset or changelist.GetMostRecentPatchset()
444 assert patchset, 'CL must be uploaded first'
445
446 codereview_host = urlparse.urlparse(codereview_url).hostname
Aaron Gablefb28d482018-04-02 13:08:06 -0700447 # Cache the buildbucket credentials under the codereview host key, so that
448 # users can use different credentials for different buckets.
tandriide281ae2016-10-12 06:02:30 -0700449 authenticator = auth.get_authenticator_for_host(codereview_host, auth_config)
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000450 http = authenticator.authorize(httplib2.Http())
451 http.force_exception_to_status_code = True
tandriide281ae2016-10-12 06:02:30 -0700452
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000453 buildbucket_put_url = (
454 'https://{hostname}/_ah/api/buildbucket/v1/builds/batch'.format(
sheyang@chromium.orgdb375572015-08-17 19:22:23 +0000455 hostname=options.buildbucket_host))
tandriide281ae2016-10-12 06:02:30 -0700456 buildset = 'patch/{codereview}/{hostname}/{issue}/{patch}'.format(
457 codereview='gerrit' if changelist.IsGerrit() else 'rietveld',
458 hostname=codereview_host,
459 issue=changelist.GetIssue(),
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000460 patch=patchset)
tandrii8c5a3532016-11-04 07:52:02 -0700461
Quinten Yearsley0c62da92017-05-31 13:39:42 -0700462 shared_parameters_properties = changelist.GetTryJobProperties(patchset)
Andrii Shyshkalovf9648b52018-02-21 22:32:42 -0800463 shared_parameters_properties['category'] = options.category
tandrii8c5a3532016-11-04 07:52:02 -0700464 if options.clobber:
465 shared_parameters_properties['clobber'] = True
tandriide281ae2016-10-12 06:02:30 -0700466 extra_properties = _get_properties_from_options(options)
tandrii8c5a3532016-11-04 07:52:02 -0700467 if extra_properties:
468 shared_parameters_properties.update(extra_properties)
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000469
470 batch_req_body = {'builds': []}
471 print_text = []
472 print_text.append('Tried jobs on:')
borenet6c0efe62016-10-19 08:13:29 -0700473 for bucket, builders_and_tests in sorted(buckets.iteritems()):
474 print_text.append('Bucket: %s' % bucket)
475 master = None
476 if bucket.startswith(MASTER_PREFIX):
477 master = _unprefix_master(bucket)
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000478 for builder, tests in sorted(builders_and_tests.iteritems()):
479 print_text.append(' %s: %s' % (builder, tests))
480 parameters = {
481 'builder_name': builder,
nodir@chromium.orgd2217312015-09-21 15:51:21 +0000482 'changes': [{
Andrii Shyshkaloveadad922017-01-26 09:38:30 +0100483 'author': {'email': changelist.GetIssueOwner()},
nodir@chromium.orgd2217312015-09-21 15:51:21 +0000484 'revision': options.revision,
485 }],
tandrii8c5a3532016-11-04 07:52:02 -0700486 'properties': shared_parameters_properties.copy(),
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000487 }
machenbach@chromium.org2403e802016-04-29 12:34:42 +0000488 if 'presubmit' in builder.lower():
489 parameters['properties']['dry_run'] = 'true'
tandrii@chromium.org3764fa22015-10-21 16:40:40 +0000490 if tests:
491 parameters['properties']['testfilter'] = tests
borenet6c0efe62016-10-19 08:13:29 -0700492
493 tags = [
494 'builder:%s' % builder,
495 'buildset:%s' % buildset,
496 'user_agent:git_cl_try',
497 ]
498 if master:
499 parameters['properties']['master'] = master
500 tags.append('master:%s' % master)
501
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000502 batch_req_body['builds'].append(
503 {
504 'bucket': bucket,
505 'parameters_json': json.dumps(parameters),
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000506 'client_operation_id': str(uuid.uuid4()),
borenet6c0efe62016-10-19 08:13:29 -0700507 'tags': tags,
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000508 }
509 )
510
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000511 _buildbucket_retry(
qyearsleyeab3c042016-08-24 09:18:28 -0700512 'triggering try jobs',
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000513 http,
514 buildbucket_put_url,
515 'PUT',
516 body=json.dumps(batch_req_body),
517 headers={'Content-Type': 'application/json'}
518 )
tandrii@chromium.org35c61452016-02-26 15:24:57 +0000519 print_text.append('To see results here, run: git cl try-results')
520 print_text.append('To see results in browser, run: git cl web')
vapiera7fbd5a2016-06-16 09:17:49 -0700521 print('\n'.join(print_text))
kjellander@chromium.org44424542015-06-02 18:35:29 +0000522
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000523
tandrii221ab252016-10-06 08:12:04 -0700524def fetch_try_jobs(auth_config, changelist, buildbucket_host,
525 patchset=None):
qyearsleyeab3c042016-08-24 09:18:28 -0700526 """Fetches try jobs from buildbucket.
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000527
qyearsley53f48a12016-09-01 10:45:13 -0700528 Returns a map from build id to build info as a dictionary.
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000529 """
tandrii221ab252016-10-06 08:12:04 -0700530 assert buildbucket_host
531 assert changelist.GetIssue(), 'CL must be uploaded first'
532 assert changelist.GetCodereviewServer(), 'CL must be uploaded first'
533 patchset = patchset or changelist.GetMostRecentPatchset()
534 assert patchset, 'CL must be uploaded first'
535
536 codereview_url = changelist.GetCodereviewServer()
537 codereview_host = urlparse.urlparse(codereview_url).hostname
538 authenticator = auth.get_authenticator_for_host(codereview_host, auth_config)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000539 if authenticator.has_cached_credentials():
540 http = authenticator.authorize(httplib2.Http())
541 else:
vapiera7fbd5a2016-06-16 09:17:49 -0700542 print('Warning: Some results might be missing because %s' %
543 # Get the message on how to login.
tandrii221ab252016-10-06 08:12:04 -0700544 (auth.LoginRequiredError(codereview_host).message,))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000545 http = httplib2.Http()
546
547 http.force_exception_to_status_code = True
548
tandrii221ab252016-10-06 08:12:04 -0700549 buildset = 'patch/{codereview}/{hostname}/{issue}/{patch}'.format(
550 codereview='gerrit' if changelist.IsGerrit() else 'rietveld',
551 hostname=codereview_host,
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000552 issue=changelist.GetIssue(),
tandrii221ab252016-10-06 08:12:04 -0700553 patch=patchset)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000554 params = {'tag': 'buildset:%s' % buildset}
555
556 builds = {}
557 while True:
558 url = 'https://{hostname}/_ah/api/buildbucket/v1/search?{params}'.format(
tandrii221ab252016-10-06 08:12:04 -0700559 hostname=buildbucket_host,
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000560 params=urllib.urlencode(params))
qyearsleyeab3c042016-08-24 09:18:28 -0700561 content = _buildbucket_retry('fetching try jobs', http, url, 'GET')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000562 for build in content.get('builds', []):
563 builds[build['id']] = build
564 if 'next_cursor' in content:
565 params['start_cursor'] = content['next_cursor']
566 else:
567 break
568 return builds
569
570
qyearsleyeab3c042016-08-24 09:18:28 -0700571def print_try_jobs(options, builds):
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000572 """Prints nicely result of fetch_try_jobs."""
573 if not builds:
Quinten Yearsley0c62da92017-05-31 13:39:42 -0700574 print('No try jobs scheduled.')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000575 return
576
577 # Make a copy, because we'll be modifying builds dictionary.
578 builds = builds.copy()
579 builder_names_cache = {}
580
581 def get_builder(b):
582 try:
583 return builder_names_cache[b['id']]
584 except KeyError:
585 try:
586 parameters = json.loads(b['parameters_json'])
587 name = parameters['builder_name']
588 except (ValueError, KeyError) as error:
Quinten Yearsley0c62da92017-05-31 13:39:42 -0700589 print('WARNING: Failed to get builder name for build %s: %s' % (
vapiera7fbd5a2016-06-16 09:17:49 -0700590 b['id'], error))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000591 name = None
592 builder_names_cache[b['id']] = name
593 return name
594
595 def get_bucket(b):
596 bucket = b['bucket']
597 if bucket.startswith('master.'):
598 return bucket[len('master.'):]
599 return bucket
600
601 if options.print_master:
602 name_fmt = '%%-%ds %%-%ds' % (
603 max(len(str(get_bucket(b))) for b in builds.itervalues()),
604 max(len(str(get_builder(b))) for b in builds.itervalues()))
605 def get_name(b):
606 return name_fmt % (get_bucket(b), get_builder(b))
607 else:
608 name_fmt = '%%-%ds' % (
609 max(len(str(get_builder(b))) for b in builds.itervalues()))
610 def get_name(b):
611 return name_fmt % get_builder(b)
612
613 def sort_key(b):
614 return b['status'], b.get('result'), get_name(b), b.get('url')
615
616 def pop(title, f, color=None, **kwargs):
617 """Pop matching builds from `builds` dict and print them."""
618
tandrii@chromium.org6cf98c82016-03-15 11:56:00 +0000619 if not options.color or color is None:
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000620 colorize = str
621 else:
622 colorize = lambda x: '%s%s%s' % (color, x, Fore.RESET)
623
624 result = []
625 for b in builds.values():
626 if all(b.get(k) == v for k, v in kwargs.iteritems()):
627 builds.pop(b['id'])
628 result.append(b)
629 if result:
vapiera7fbd5a2016-06-16 09:17:49 -0700630 print(colorize(title))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000631 for b in sorted(result, key=sort_key):
vapiera7fbd5a2016-06-16 09:17:49 -0700632 print(' ', colorize('\t'.join(map(str, f(b)))))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000633
634 total = len(builds)
635 pop(status='COMPLETED', result='SUCCESS',
636 title='Successes:', color=Fore.GREEN,
637 f=lambda b: (get_name(b), b.get('url')))
638 pop(status='COMPLETED', result='FAILURE', failure_reason='INFRA_FAILURE',
639 title='Infra Failures:', color=Fore.MAGENTA,
640 f=lambda b: (get_name(b), b.get('url')))
641 pop(status='COMPLETED', result='FAILURE', failure_reason='BUILD_FAILURE',
642 title='Failures:', color=Fore.RED,
643 f=lambda b: (get_name(b), b.get('url')))
644 pop(status='COMPLETED', result='CANCELED',
645 title='Canceled:', color=Fore.MAGENTA,
646 f=lambda b: (get_name(b),))
647 pop(status='COMPLETED', result='FAILURE',
648 failure_reason='INVALID_BUILD_DEFINITION',
649 title='Wrong master/builder name:', color=Fore.MAGENTA,
650 f=lambda b: (get_name(b),))
651 pop(status='COMPLETED', result='FAILURE',
652 title='Other failures:',
653 f=lambda b: (get_name(b), b.get('failure_reason'), b.get('url')))
654 pop(status='COMPLETED',
655 title='Other finished:',
656 f=lambda b: (get_name(b), b.get('result'), b.get('url')))
657 pop(status='STARTED',
658 title='Started:', color=Fore.YELLOW,
659 f=lambda b: (get_name(b), b.get('url')))
660 pop(status='SCHEDULED',
661 title='Scheduled:',
662 f=lambda b: (get_name(b), 'id=%s' % b['id']))
663 # The last section is just in case buildbucket API changes OR there is a bug.
664 pop(title='Other:',
665 f=lambda b: (get_name(b), 'id=%s' % b['id']))
666 assert len(builds) == 0
qyearsleyeab3c042016-08-24 09:18:28 -0700667 print('Total: %d try jobs' % total)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000668
669
qyearsley53f48a12016-09-01 10:45:13 -0700670def write_try_results_json(output_file, builds):
671 """Writes a subset of the data from fetch_try_jobs to a file as JSON.
672
673 The input |builds| dict is assumed to be generated by Buildbucket.
674 Buildbucket documentation: http://goo.gl/G0s101
675 """
676
677 def convert_build_dict(build):
Quinten Yearsleya563d722017-12-11 16:36:54 -0800678 """Extracts some of the information from one build dict."""
679 parameters = json.loads(build.get('parameters_json', '{}')) or {}
qyearsley53f48a12016-09-01 10:45:13 -0700680 return {
681 'buildbucket_id': build.get('id'),
qyearsley53f48a12016-09-01 10:45:13 -0700682 'bucket': build.get('bucket'),
Quinten Yearsleya563d722017-12-11 16:36:54 -0800683 'builder_name': parameters.get('builder_name'),
684 'created_ts': build.get('created_ts'),
685 'experimental': build.get('experimental'),
qyearsley53f48a12016-09-01 10:45:13 -0700686 'failure_reason': build.get('failure_reason'),
Quinten Yearsleya563d722017-12-11 16:36:54 -0800687 'result': build.get('result'),
688 'status': build.get('status'),
689 'tags': build.get('tags'),
qyearsley53f48a12016-09-01 10:45:13 -0700690 'url': build.get('url'),
691 }
692
693 converted = []
694 for _, build in sorted(builds.items()):
695 converted.append(convert_build_dict(build))
696 write_json(output_file, converted)
697
698
Aaron Gable13101a62018-02-09 13:20:41 -0800699def print_stats(args):
maruel@chromium.org49e3d802012-07-18 23:54:45 +0000700 """Prints statistics about the change to the user."""
701 # --no-ext-diff is broken in some versions of Git, so try to work around
702 # this by overriding the environment (but there is still a problem if the
703 # git config key "diff.external" is used).
thestig@chromium.org8b0553c2014-02-11 00:33:37 +0000704 env = GetNoGitPagerEnv()
maruel@chromium.org49e3d802012-07-18 23:54:45 +0000705 if 'GIT_EXTERNAL_DIFF' in env:
706 del env['GIT_EXTERNAL_DIFF']
iannucci@chromium.org79540052012-10-19 23:15:26 +0000707
szager@chromium.orgd057f9a2014-05-29 21:09:36 +0000708 try:
709 stdout = sys.stdout.fileno()
710 except AttributeError:
711 stdout = None
maruel@chromium.org49e3d802012-07-18 23:54:45 +0000712 return subprocess2.call(
Aaron Gable13101a62018-02-09 13:20:41 -0800713 ['git', 'diff', '--no-ext-diff', '--stat', '-l100000', '-C50'] + args,
szager@chromium.orgd057f9a2014-05-29 21:09:36 +0000714 stdout=stdout, env=env)
maruel@chromium.org49e3d802012-07-18 23:54:45 +0000715
716
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000717class BuildbucketResponseException(Exception):
718 pass
719
720
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000721class Settings(object):
722 def __init__(self):
723 self.default_server = None
724 self.cc = None
thestig@chromium.org7a54e812014-02-11 19:57:22 +0000725 self.root = None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000726 self.tree_status_url = None
727 self.viewvc_url = None
728 self.updated = False
ukai@chromium.orge8077812012-02-03 03:41:46 +0000729 self.is_gerrit = None
bauerb@chromium.org54b400c2016-01-14 10:08:25 +0000730 self.squash_gerrit_uploads = None
tandrii@chromium.org28253532016-04-14 13:46:56 +0000731 self.gerrit_skip_ensure_authenticated = None
jbroman@chromium.org615a2622013-05-03 13:20:14 +0000732 self.git_editor = None
sheyang@chromium.org152cf832014-06-11 21:37:49 +0000733 self.project = None
kjellander@chromium.org6abc6522014-12-02 07:34:49 +0000734 self.force_https_commit_url = None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000735
736 def LazyUpdateIfNeeded(self):
737 """Updates the settings from a codereview.settings file, if available."""
738 if not self.updated:
pgervais@chromium.org87884cc2014-01-03 22:23:41 +0000739 # The only value that actually changes the behavior is
740 # autoupdate = "false". Everything else means "true".
nick@chromium.org3ac1c4e2014-01-16 02:44:42 +0000741 autoupdate = RunGit(['config', 'rietveld.autoupdate'],
pgervais@chromium.org87884cc2014-01-03 22:23:41 +0000742 error_ok=True
743 ).strip().lower()
744
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000745 cr_settings_file = FindCodereviewSettingsFile()
pgervais@chromium.org87884cc2014-01-03 22:23:41 +0000746 if autoupdate != 'false' and cr_settings_file:
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000747 LoadCodereviewSettingsFromFile(cr_settings_file)
748 self.updated = True
749
750 def GetDefaultServerUrl(self, error_ok=False):
751 if not self.default_server:
752 self.LazyUpdateIfNeeded()
maruel@chromium.orgeb5edbc2012-01-16 17:03:28 +0000753 self.default_server = gclient_utils.UpgradeToHttps(
thestig@chromium.org8b0553c2014-02-11 00:33:37 +0000754 self._GetRietveldConfig('server', error_ok=True))
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000755 if error_ok:
756 return self.default_server
757 if not self.default_server:
758 error_message = ('Could not find settings file. You must configure '
759 'your review setup by running "git cl config".')
maruel@chromium.orgeb5edbc2012-01-16 17:03:28 +0000760 self.default_server = gclient_utils.UpgradeToHttps(
thestig@chromium.org8b0553c2014-02-11 00:33:37 +0000761 self._GetRietveldConfig('server', error_message=error_message))
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000762 return self.default_server
763
thestig@chromium.org7a54e812014-02-11 19:57:22 +0000764 @staticmethod
765 def GetRelativeRoot():
766 return RunGit(['rev-parse', '--show-cdup']).strip()
thestig@chromium.org8b0553c2014-02-11 00:33:37 +0000767
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000768 def GetRoot(self):
thestig@chromium.org7a54e812014-02-11 19:57:22 +0000769 if self.root is None:
770 self.root = os.path.abspath(self.GetRelativeRoot())
771 return self.root
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000772
szager@chromium.org151ebcf2016-03-09 01:08:25 +0000773 def GetGitMirror(self, remote='origin'):
774 """If this checkout is from a local git mirror, return a Mirror object."""
szager@chromium.org81593742016-03-09 20:27:58 +0000775 local_url = RunGit(['config', '--get', 'remote.%s.url' % remote]).strip()
szager@chromium.org151ebcf2016-03-09 01:08:25 +0000776 if not os.path.isdir(local_url):
777 return None
778 git_cache.Mirror.SetCachePath(os.path.dirname(local_url))
779 remote_url = git_cache.Mirror.CacheDirToUrl(local_url)
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +0100780 # Use the /dev/null print_func to avoid terminal spew.
Andrii Shyshkalov18975322017-01-25 16:44:13 +0100781 mirror = git_cache.Mirror(remote_url, print_func=lambda *args: None)
szager@chromium.org151ebcf2016-03-09 01:08:25 +0000782 if mirror.exists():
783 return mirror
784 return None
785
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000786 def GetTreeStatusUrl(self, error_ok=False):
787 if not self.tree_status_url:
788 error_message = ('You must configure your tree status URL by running '
789 '"git cl config".')
thestig@chromium.org8b0553c2014-02-11 00:33:37 +0000790 self.tree_status_url = self._GetRietveldConfig(
791 'tree-status-url', error_ok=error_ok, error_message=error_message)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000792 return self.tree_status_url
793
794 def GetViewVCUrl(self):
795 if not self.viewvc_url:
thestig@chromium.org8b0553c2014-02-11 00:33:37 +0000796 self.viewvc_url = self._GetRietveldConfig('viewvc-url', error_ok=True)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000797 return self.viewvc_url
798
rmistry@google.com90752582014-01-14 21:04:50 +0000799 def GetBugPrefix(self):
thestig@chromium.org8b0553c2014-02-11 00:33:37 +0000800 return self._GetRietveldConfig('bug-prefix', error_ok=True)
rmistry@google.com90752582014-01-14 21:04:50 +0000801
rmistry@google.com78948ed2015-07-08 23:09:57 +0000802 def GetIsSkipDependencyUpload(self, branch_name):
803 """Returns true if specified branch should skip dep uploads."""
804 return self._GetBranchConfig(branch_name, 'skip-deps-uploads',
805 error_ok=True)
806
rmistry@google.com5626a922015-02-26 14:03:30 +0000807 def GetRunPostUploadHook(self):
808 run_post_upload_hook = self._GetRietveldConfig(
809 'run-post-upload-hook', error_ok=True)
810 return run_post_upload_hook == "True"
811
bauerb@chromium.orgae6df352011-04-06 17:40:39 +0000812 def GetDefaultCCList(self):
thestig@chromium.org8b0553c2014-02-11 00:33:37 +0000813 return self._GetRietveldConfig('cc', error_ok=True)
bauerb@chromium.orgae6df352011-04-06 17:40:39 +0000814
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000815 def GetDefaultPrivateFlag(self):
thestig@chromium.org8b0553c2014-02-11 00:33:37 +0000816 return self._GetRietveldConfig('private', error_ok=True)
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000817
ukai@chromium.orge8077812012-02-03 03:41:46 +0000818 def GetIsGerrit(self):
Quinten Yearsley0c62da92017-05-31 13:39:42 -0700819 """Return true if this repo is associated with gerrit code review system."""
ukai@chromium.orge8077812012-02-03 03:41:46 +0000820 if self.is_gerrit is None:
Aaron Gable9b465272017-05-12 10:53:51 -0700821 self.is_gerrit = (
822 self._GetConfig('gerrit.host', error_ok=True).lower() == 'true')
ukai@chromium.orge8077812012-02-03 03:41:46 +0000823 return self.is_gerrit
824
bauerb@chromium.org54b400c2016-01-14 10:08:25 +0000825 def GetSquashGerritUploads(self):
826 """Return true if uploads to Gerrit should be squashed by default."""
827 if self.squash_gerrit_uploads is None:
tandriia60502f2016-06-20 02:01:53 -0700828 self.squash_gerrit_uploads = self.GetSquashGerritUploadsOverride()
829 if self.squash_gerrit_uploads is None:
830 # Default is squash now (http://crbug.com/611892#c23).
831 self.squash_gerrit_uploads = not (
832 RunGit(['config', '--bool', 'gerrit.squash-uploads'],
833 error_ok=True).strip() == 'false')
bauerb@chromium.org54b400c2016-01-14 10:08:25 +0000834 return self.squash_gerrit_uploads
835
tandriia60502f2016-06-20 02:01:53 -0700836 def GetSquashGerritUploadsOverride(self):
837 """Return True or False if codereview.settings should be overridden.
838
839 Returns None if no override has been defined.
840 """
841 # See also http://crbug.com/611892#c23
842 result = RunGit(['config', '--bool', 'gerrit.override-squash-uploads'],
843 error_ok=True).strip()
844 if result == 'true':
845 return True
846 if result == 'false':
847 return False
848 return None
849
tandrii@chromium.org28253532016-04-14 13:46:56 +0000850 def GetGerritSkipEnsureAuthenticated(self):
851 """Return True if EnsureAuthenticated should not be done for Gerrit
852 uploads."""
853 if self.gerrit_skip_ensure_authenticated is None:
854 self.gerrit_skip_ensure_authenticated = (
shinyak@chromium.org00dbccd2016-04-15 07:24:43 +0000855 RunGit(['config', '--bool', 'gerrit.skip-ensure-authenticated'],
tandrii@chromium.org28253532016-04-14 13:46:56 +0000856 error_ok=True).strip() == 'true')
857 return self.gerrit_skip_ensure_authenticated
858
jbroman@chromium.org615a2622013-05-03 13:20:14 +0000859 def GetGitEditor(self):
860 """Return the editor specified in the git config, or None if none is."""
861 if self.git_editor is None:
862 self.git_editor = self._GetConfig('core.editor', error_ok=True)
863 return self.git_editor or None
864
thestig@chromium.org44202a22014-03-11 19:22:18 +0000865 def GetLintRegex(self):
866 return (self._GetRietveldConfig('cpplint-regex', error_ok=True) or
867 DEFAULT_LINT_REGEX)
868
869 def GetLintIgnoreRegex(self):
870 return (self._GetRietveldConfig('cpplint-ignore-regex', error_ok=True) or
871 DEFAULT_LINT_IGNORE_REGEX)
872
sheyang@chromium.org152cf832014-06-11 21:37:49 +0000873 def GetProject(self):
874 if not self.project:
875 self.project = self._GetRietveldConfig('project', error_ok=True)
876 return self.project
877
thestig@chromium.org8b0553c2014-02-11 00:33:37 +0000878 def _GetRietveldConfig(self, param, **kwargs):
879 return self._GetConfig('rietveld.' + param, **kwargs)
880
rmistry@google.com78948ed2015-07-08 23:09:57 +0000881 def _GetBranchConfig(self, branch_name, param, **kwargs):
882 return self._GetConfig('branch.' + branch_name + '.' + param, **kwargs)
883
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000884 def _GetConfig(self, param, **kwargs):
885 self.LazyUpdateIfNeeded()
886 return RunGit(['config', param], **kwargs).strip()
887
888
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +0100889@contextlib.contextmanager
890def _get_gerrit_project_config_file(remote_url):
891 """Context manager to fetch and store Gerrit's project.config from
892 refs/meta/config branch and store it in temp file.
893
894 Provides a temporary filename or None if there was error.
895 """
896 error, _ = RunGitWithCode([
897 'fetch', remote_url,
898 '+refs/meta/config:refs/git_cl/meta/config'])
899 if error:
900 # Ref doesn't exist or isn't accessible to current user.
Quinten Yearsley0c62da92017-05-31 13:39:42 -0700901 print('WARNING: Failed to fetch project config for %s: %s' %
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +0100902 (remote_url, error))
903 yield None
904 return
905
906 error, project_config_data = RunGitWithCode(
907 ['show', 'refs/git_cl/meta/config:project.config'])
908 if error:
909 print('WARNING: project.config file not found')
910 yield None
911 return
912
913 with gclient_utils.temporary_directory() as tempdir:
914 project_config_file = os.path.join(tempdir, 'project.config')
915 gclient_utils.FileWrite(project_config_file, project_config_data)
916 yield project_config_file
917
918
919def _is_git_numberer_enabled(remote_url, remote_ref):
920 """Returns True if Git Numberer is enabled on this ref."""
921 # TODO(tandrii): this should be deleted once repos below are 100% on Gerrit.
Andrii Shyshkalovcd6a9362016-12-07 12:04:12 +0100922 KNOWN_PROJECTS_WHITELIST = [
923 'chromium/src',
924 'external/webrtc',
925 'v8/v8',
Andrii Shyshkalovaa31b972017-03-24 16:16:33 +0100926 'infra/experimental',
Edward Lemur32357d32017-09-11 20:22:45 +0200927 # For webrtc.googlesource.com/src.
928 'src',
Andrii Shyshkalovcd6a9362016-12-07 12:04:12 +0100929 ]
930
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +0100931 assert remote_ref and remote_ref.startswith('refs/'), remote_ref
932 url_parts = urlparse.urlparse(remote_url)
933 project_name = url_parts.path.lstrip('/').rstrip('git./')
934 for known in KNOWN_PROJECTS_WHITELIST:
935 if project_name.endswith(known):
936 break
937 else:
938 # Early exit to avoid extra fetches for repos that aren't using Git
939 # Numberer.
940 return False
Andrii Shyshkalovcd6a9362016-12-07 12:04:12 +0100941
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +0100942 with _get_gerrit_project_config_file(remote_url) as project_config_file:
943 if project_config_file is None:
944 # Failed to fetch project.config, which shouldn't happen on open source
945 # repos KNOWN_PROJECTS_WHITELIST.
Andrii Shyshkalovcd6a9362016-12-07 12:04:12 +0100946 return False
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +0100947 def get_opts(x):
948 code, out = RunGitWithCode(
949 ['config', '-f', project_config_file, '--get-all',
950 'plugin.git-numberer.validate-%s-refglob' % x])
951 if code == 0:
952 return out.strip().splitlines()
953 return []
954 enabled, disabled = map(get_opts, ['enabled', 'disabled'])
Andrii Shyshkalovcd6a9362016-12-07 12:04:12 +0100955
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +0100956 logging.info('validator config enabled %s disabled %s refglobs for '
957 '(this ref: %s)', enabled, disabled, remote_ref)
Andrii Shyshkalov351c61d2017-01-21 20:40:16 +0000958
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +0100959 def match_refglobs(refglobs):
Andrii Shyshkalovcd6a9362016-12-07 12:04:12 +0100960 for refglob in refglobs:
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +0100961 if remote_ref == refglob or fnmatch.fnmatch(remote_ref, refglob):
Andrii Shyshkalovcd6a9362016-12-07 12:04:12 +0100962 return True
963 return False
964
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +0100965 if match_refglobs(disabled):
966 return False
967 return match_refglobs(enabled)
Andrii Shyshkalovcd6a9362016-12-07 12:04:12 +0100968
969
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000970def ShortBranchName(branch):
971 """Convert a name like 'refs/heads/foo' to just 'foo'."""
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +0000972 return branch.replace('refs/heads/', '', 1)
973
974
975def GetCurrentBranchRef():
976 """Returns branch ref (e.g., refs/heads/master) or None."""
977 return RunGit(['symbolic-ref', 'HEAD'],
978 stderr=subprocess2.VOID, error_ok=True).strip() or None
979
980
981def GetCurrentBranch():
982 """Returns current branch or None.
983
984 For refs/heads/* branches, returns just last part. For others, full ref.
985 """
986 branchref = GetCurrentBranchRef()
987 if branchref:
988 return ShortBranchName(branchref)
989 return None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000990
991
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +0000992class _CQState(object):
993 """Enum for states of CL with respect to Commit Queue."""
994 NONE = 'none'
995 DRY_RUN = 'dry_run'
996 COMMIT = 'commit'
997
998 ALL_STATES = [NONE, DRY_RUN, COMMIT]
999
1000
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001001class _ParsedIssueNumberArgument(object):
Andrii Shyshkalov90f31922017-04-10 16:10:21 +02001002 def __init__(self, issue=None, patchset=None, hostname=None, codereview=None):
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001003 self.issue = issue
1004 self.patchset = patchset
1005 self.hostname = hostname
Andrii Shyshkalov90f31922017-04-10 16:10:21 +02001006 assert codereview in (None, 'rietveld', 'gerrit')
1007 self.codereview = codereview
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001008
1009 @property
1010 def valid(self):
1011 return self.issue is not None
1012
1013
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001014def ParseIssueNumberArgument(arg, codereview=None):
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001015 """Parses the issue argument and returns _ParsedIssueNumberArgument."""
1016 fail_result = _ParsedIssueNumberArgument()
1017
1018 if arg.isdigit():
Aaron Gableaee6c852017-06-26 12:49:01 -07001019 return _ParsedIssueNumberArgument(issue=int(arg), codereview=codereview)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001020 if not arg.startswith('http'):
1021 return fail_result
Aaron Gableaee6c852017-06-26 12:49:01 -07001022
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001023 url = gclient_utils.UpgradeToHttps(arg)
1024 try:
1025 parsed_url = urlparse.urlparse(url)
1026 except ValueError:
1027 return fail_result
Andrii Shyshkalov28d840e2017-04-10 15:45:09 +02001028
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001029 if codereview is not None:
1030 parsed = _CODEREVIEW_IMPLEMENTATIONS[codereview].ParseIssueURL(parsed_url)
1031 return parsed or fail_result
1032
Andrii Shyshkalov28d840e2017-04-10 15:45:09 +02001033 results = {}
1034 for name, cls in _CODEREVIEW_IMPLEMENTATIONS.iteritems():
1035 parsed = cls.ParseIssueURL(parsed_url)
1036 if parsed is not None:
1037 results[name] = parsed
1038
1039 if not results:
1040 return fail_result
1041 if len(results) == 1:
1042 return results.values()[0]
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001043
1044 if parsed_url.netloc and parsed_url.netloc.split('.')[0].endswith('-review'):
1045 # This is likely Gerrit.
1046 return results['gerrit']
1047 # Choose Rietveld as before if URL can parsed by either.
Andrii Shyshkalov28d840e2017-04-10 15:45:09 +02001048 return results['rietveld']
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001049
1050
Aaron Gablea45ee112016-11-22 15:14:38 -08001051class GerritChangeNotExists(Exception):
tandriic2405f52016-10-10 08:13:15 -07001052 def __init__(self, issue, url):
1053 self.issue = issue
1054 self.url = url
Aaron Gablea45ee112016-11-22 15:14:38 -08001055 super(GerritChangeNotExists, self).__init__()
tandriic2405f52016-10-10 08:13:15 -07001056
1057 def __str__(self):
Aaron Gablea45ee112016-11-22 15:14:38 -08001058 return 'change %s at %s does not exist or you have no access to it' % (
tandriic2405f52016-10-10 08:13:15 -07001059 self.issue, self.url)
1060
1061
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01001062_CommentSummary = collections.namedtuple(
1063 '_CommentSummary', ['date', 'message', 'sender',
1064 # TODO(tandrii): these two aren't known in Gerrit.
1065 'approval', 'disapproval'])
1066
1067
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001068class Changelist(object):
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001069 """Changelist works with one changelist in local branch.
1070
1071 Supports two codereview backends: Rietveld or Gerrit, selected at object
1072 creation.
1073
tandrii@chromium.org8930b3d2016-04-13 14:47:02 +00001074 Notes:
1075 * Not safe for concurrent multi-{thread,process} use.
1076 * Caches values from current branch. Therefore, re-use after branch change
tandrii5d48c322016-08-18 16:19:37 -07001077 with great care.
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001078 """
1079
1080 def __init__(self, branchref=None, issue=None, codereview=None, **kwargs):
1081 """Create a new ChangeList instance.
1082
1083 If issue is given, the codereview must be given too.
1084
1085 If `codereview` is given, it must be 'rietveld' or 'gerrit'.
1086 Otherwise, it's decided based on current configuration of the local branch,
1087 with default being 'rietveld' for backwards compatibility.
1088 See _load_codereview_impl for more details.
1089
1090 **kwargs will be passed directly to codereview implementation.
1091 """
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001092 # Poke settings so we get the "configure your server" message if necessary.
maruel@chromium.org379d07a2011-11-30 14:58:10 +00001093 global settings
1094 if not settings:
1095 # Happens when git_cl.py is used as a utility library.
1096 settings = Settings()
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001097
1098 if issue:
1099 assert codereview, 'codereview must be known, if issue is known'
1100
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001101 self.branchref = branchref
1102 if self.branchref:
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00001103 assert branchref.startswith('refs/heads/')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001104 self.branch = ShortBranchName(self.branchref)
1105 else:
1106 self.branch = None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001107 self.upstream_branch = None
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001108 self.lookedup_issue = False
1109 self.issue = issue or None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001110 self.has_description = False
1111 self.description = None
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001112 self.lookedup_patchset = False
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001113 self.patchset = None
bauerb@chromium.orgae6df352011-04-06 17:40:39 +00001114 self.cc = None
Daniel Cheng7227d212017-11-17 08:12:37 -08001115 self.more_cc = []
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00001116 self._remote = None
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00001117
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001118 self._codereview_impl = None
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00001119 self._codereview = None
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001120 self._load_codereview_impl(codereview, **kwargs)
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00001121 assert self._codereview_impl
1122 assert self._codereview in _CODEREVIEW_IMPLEMENTATIONS
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001123
1124 def _load_codereview_impl(self, codereview=None, **kwargs):
1125 if codereview:
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00001126 assert codereview in _CODEREVIEW_IMPLEMENTATIONS
1127 cls = _CODEREVIEW_IMPLEMENTATIONS[codereview]
1128 self._codereview = codereview
1129 self._codereview_impl = cls(self, **kwargs)
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001130 return
1131
1132 # Automatic selection based on issue number set for a current branch.
1133 # Rietveld takes precedence over Gerrit.
1134 assert not self.issue
1135 # Whether we find issue or not, we are doing the lookup.
1136 self.lookedup_issue = True
tandrii5d48c322016-08-18 16:19:37 -07001137 if self.GetBranch():
1138 for codereview, cls in _CODEREVIEW_IMPLEMENTATIONS.iteritems():
1139 issue = _git_get_branch_config_value(
1140 cls.IssueConfigKey(), value_type=int, branch=self.GetBranch())
1141 if issue:
1142 self._codereview = codereview
1143 self._codereview_impl = cls(self, **kwargs)
1144 self.issue = int(issue)
1145 return
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001146
1147 # No issue is set for this branch, so decide based on repo-wide settings.
1148 return self._load_codereview_impl(
1149 codereview='gerrit' if settings.GetIsGerrit() else 'rietveld',
1150 **kwargs)
1151
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00001152 def IsGerrit(self):
1153 return self._codereview == 'gerrit'
bauerb@chromium.orgae6df352011-04-06 17:40:39 +00001154
1155 def GetCCList(self):
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001156 """Returns the users cc'd on this CL.
bauerb@chromium.orgae6df352011-04-06 17:40:39 +00001157
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001158 The return value is a string suitable for passing to git cl with the --cc
1159 flag.
bauerb@chromium.orgae6df352011-04-06 17:40:39 +00001160 """
1161 if self.cc is None:
tyoshino@chromium.org99918ab2013-09-30 06:17:28 +00001162 base_cc = settings.GetDefaultCCList()
Daniel Cheng7227d212017-11-17 08:12:37 -08001163 more_cc = ','.join(self.more_cc)
bauerb@chromium.orgae6df352011-04-06 17:40:39 +00001164 self.cc = ','.join(filter(None, (base_cc, more_cc))) or ''
1165 return self.cc
1166
tyoshino@chromium.org99918ab2013-09-30 06:17:28 +00001167 def GetCCListWithoutDefault(self):
1168 """Return the users cc'd on this CL excluding default ones."""
1169 if self.cc is None:
Daniel Cheng7227d212017-11-17 08:12:37 -08001170 self.cc = ','.join(self.more_cc)
tyoshino@chromium.org99918ab2013-09-30 06:17:28 +00001171 return self.cc
1172
Daniel Cheng7227d212017-11-17 08:12:37 -08001173 def ExtendCC(self, more_cc):
1174 """Extends the list of users to cc on this CL based on the changed files."""
1175 self.more_cc.extend(more_cc)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001176
1177 def GetBranch(self):
1178 """Returns the short branch name, e.g. 'master'."""
1179 if not self.branch:
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001180 branchref = GetCurrentBranchRef()
szager@chromium.orgd62c61f2014-10-20 22:33:21 +00001181 if not branchref:
1182 return None
1183 self.branchref = branchref
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001184 self.branch = ShortBranchName(self.branchref)
1185 return self.branch
1186
1187 def GetBranchRef(self):
1188 """Returns the full branch name, e.g. 'refs/heads/master'."""
1189 self.GetBranch() # Poke the lazy loader.
1190 return self.branchref
1191
tandrii@chromium.org534f67a2016-04-07 18:47:05 +00001192 def ClearBranch(self):
1193 """Clears cached branch data of this object."""
1194 self.branch = self.branchref = None
1195
tandrii5d48c322016-08-18 16:19:37 -07001196 def _GitGetBranchConfigValue(self, key, default=None, **kwargs):
1197 assert 'branch' not in kwargs, 'this CL branch is used automatically'
1198 kwargs['branch'] = self.GetBranch()
1199 return _git_get_branch_config_value(key, default, **kwargs)
1200
1201 def _GitSetBranchConfigValue(self, key, value, **kwargs):
1202 assert 'branch' not in kwargs, 'this CL branch is used automatically'
1203 assert self.GetBranch(), (
1204 'this CL must have an associated branch to %sset %s%s' %
1205 ('un' if value is None else '',
1206 key,
1207 '' if value is None else ' to %r' % value))
1208 kwargs['branch'] = self.GetBranch()
1209 return _git_set_branch_config_value(key, value, **kwargs)
1210
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001211 @staticmethod
1212 def FetchUpstreamTuple(branch):
pgervais@chromium.orgd6617f32013-11-19 00:34:54 +00001213 """Returns a tuple containing remote and remote ref,
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001214 e.g. 'origin', 'refs/heads/master'
1215 """
1216 remote = '.'
tandrii5d48c322016-08-18 16:19:37 -07001217 upstream_branch = _git_get_branch_config_value('merge', branch=branch)
1218
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001219 if upstream_branch:
tandrii5d48c322016-08-18 16:19:37 -07001220 remote = _git_get_branch_config_value('remote', branch=branch)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001221 else:
bauerb@chromium.orgade368c2011-03-01 08:57:50 +00001222 upstream_branch = RunGit(['config', 'rietveld.upstream-branch'],
1223 error_ok=True).strip()
1224 if upstream_branch:
1225 remote = RunGit(['config', 'rietveld.upstream-remote']).strip()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001226 else:
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08001227 # Else, try to guess the origin remote.
1228 remote_branches = RunGit(['branch', '-r']).split()
1229 if 'origin/master' in remote_branches:
1230 # Fall back on origin/master if it exits.
1231 remote = 'origin'
1232 upstream_branch = 'refs/heads/master'
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001233 else:
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08001234 DieWithError(
1235 'Unable to determine default branch to diff against.\n'
1236 'Either pass complete "git diff"-style arguments, like\n'
1237 ' git cl upload origin/master\n'
1238 'or verify this branch is set up to track another \n'
1239 '(via the --track argument to "git checkout -b ...").')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001240
1241 return remote, upstream_branch
1242
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00001243 def GetCommonAncestorWithUpstream(self):
pgervais@chromium.org8ba38ff2015-06-11 21:41:25 +00001244 upstream_branch = self.GetUpstreamBranch()
1245 if not BranchExists(upstream_branch):
1246 DieWithError('The upstream for the current branch (%s) does not exist '
1247 'anymore.\nPlease fix it and try again.' % self.GetBranch())
iannucci@chromium.org9e849272014-04-04 00:31:55 +00001248 return git_common.get_or_create_merge_base(self.GetBranch(),
pgervais@chromium.org8ba38ff2015-06-11 21:41:25 +00001249 upstream_branch)
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00001250
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001251 def GetUpstreamBranch(self):
1252 if self.upstream_branch is None:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001253 remote, upstream_branch = self.FetchUpstreamTuple(self.GetBranch())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001254 if remote is not '.':
mmoss@chromium.orge7585452014-08-24 01:41:11 +00001255 upstream_branch = upstream_branch.replace('refs/heads/',
1256 'refs/remotes/%s/' % remote)
1257 upstream_branch = upstream_branch.replace('refs/branch-heads/',
1258 'refs/remotes/branch-heads/')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001259 self.upstream_branch = upstream_branch
1260 return self.upstream_branch
1261
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001262 def GetRemoteBranch(self):
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001263 if not self._remote:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001264 remote, branch = None, self.GetBranch()
1265 seen_branches = set()
1266 while branch not in seen_branches:
1267 seen_branches.add(branch)
1268 remote, branch = self.FetchUpstreamTuple(branch)
1269 branch = ShortBranchName(branch)
1270 if remote != '.' or branch.startswith('refs/remotes'):
1271 break
1272 else:
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001273 remotes = RunGit(['remote'], error_ok=True).split()
1274 if len(remotes) == 1:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001275 remote, = remotes
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001276 elif 'origin' in remotes:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001277 remote = 'origin'
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08001278 logging.warn('Could not determine which remote this change is '
1279 'associated with, so defaulting to "%s".' % self._remote)
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001280 else:
1281 logging.warn('Could not determine which remote this change is '
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08001282 'associated with.')
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001283 branch = 'HEAD'
1284 if branch.startswith('refs/remotes'):
1285 self._remote = (remote, branch)
mmoss@chromium.orge7585452014-08-24 01:41:11 +00001286 elif branch.startswith('refs/branch-heads/'):
1287 self._remote = (remote, branch.replace('refs/', 'refs/remotes/'))
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001288 else:
1289 self._remote = (remote, 'refs/remotes/%s/%s' % (remote, branch))
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001290 return self._remote
1291
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001292 def GitSanityChecks(self, upstream_git_obj):
1293 """Checks git repo status and ensures diff is from local commits."""
1294
sbc@chromium.org79706062015-01-14 21:18:12 +00001295 if upstream_git_obj is None:
1296 if self.GetBranch() is None:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001297 print('ERROR: Unable to determine current branch (detached HEAD?)',
vapiera7fbd5a2016-06-16 09:17:49 -07001298 file=sys.stderr)
sbc@chromium.org79706062015-01-14 21:18:12 +00001299 else:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001300 print('ERROR: No upstream branch.', file=sys.stderr)
sbc@chromium.org79706062015-01-14 21:18:12 +00001301 return False
1302
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001303 # Verify the commit we're diffing against is in our current branch.
1304 upstream_sha = RunGit(['rev-parse', '--verify', upstream_git_obj]).strip()
1305 common_ancestor = RunGit(['merge-base', upstream_sha, 'HEAD']).strip()
1306 if upstream_sha != common_ancestor:
vapiera7fbd5a2016-06-16 09:17:49 -07001307 print('ERROR: %s is not in the current branch. You may need to rebase '
1308 'your tracking branch' % upstream_sha, file=sys.stderr)
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001309 return False
1310
1311 # List the commits inside the diff, and verify they are all local.
1312 commits_in_diff = RunGit(
1313 ['rev-list', '^%s' % upstream_sha, 'HEAD']).splitlines()
1314 code, remote_branch = RunGitWithCode(['config', 'gitcl.remotebranch'])
1315 remote_branch = remote_branch.strip()
1316 if code != 0:
1317 _, remote_branch = self.GetRemoteBranch()
1318
1319 commits_in_remote = RunGit(
1320 ['rev-list', '^%s' % upstream_sha, remote_branch]).splitlines()
1321
1322 common_commits = set(commits_in_diff) & set(commits_in_remote)
1323 if common_commits:
vapiera7fbd5a2016-06-16 09:17:49 -07001324 print('ERROR: Your diff contains %d commits already in %s.\n'
1325 'Run "git log --oneline %s..HEAD" to get a list of commits in '
1326 'the diff. If you are using a custom git flow, you can override'
1327 ' the reference used for this check with "git config '
1328 'gitcl.remotebranch <git-ref>".' % (
1329 len(common_commits), remote_branch, upstream_git_obj),
1330 file=sys.stderr)
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001331 return False
1332 return True
1333
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00001334 def GetGitBaseUrlFromConfig(self):
sheyang@chromium.orga656e702014-05-15 20:43:05 +00001335 """Return the configured base URL from branch.<branchname>.baseurl.
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00001336
1337 Returns None if it is not set.
1338 """
tandrii5d48c322016-08-18 16:19:37 -07001339 return self._GitGetBranchConfigValue('base-url')
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001340
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001341 def GetRemoteUrl(self):
1342 """Return the configured remote URL, e.g. 'git://example.org/foo.git/'.
1343
1344 Returns None if there is no remote.
1345 """
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001346 remote, _ = self.GetRemoteBranch()
dyen@chromium.org2a13d4f2014-06-13 00:06:37 +00001347 url = RunGit(['config', 'remote.%s.url' % remote], error_ok=True).strip()
1348
1349 # If URL is pointing to a local directory, it is probably a git cache.
1350 if os.path.isdir(url):
1351 url = RunGit(['config', 'remote.%s.url' % remote],
1352 error_ok=True,
1353 cwd=url).strip()
1354 return url
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001355
tandrii@chromium.org87985d22016-03-24 17:33:33 +00001356 def GetIssue(self):
maruel@chromium.org52424302012-08-29 15:14:30 +00001357 """Returns the issue number as a int or None if not set."""
tandrii@chromium.org87985d22016-03-24 17:33:33 +00001358 if self.issue is None and not self.lookedup_issue:
tandrii5d48c322016-08-18 16:19:37 -07001359 self.issue = self._GitGetBranchConfigValue(
1360 self._codereview_impl.IssueConfigKey(), value_type=int)
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001361 self.lookedup_issue = True
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001362 return self.issue
1363
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001364 def GetIssueURL(self):
1365 """Get the URL for a particular issue."""
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001366 issue = self.GetIssue()
1367 if not issue:
dbeam@chromium.org015fd3d2013-06-18 19:02:50 +00001368 return None
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001369 return '%s/%s' % (self._codereview_impl.GetCodereviewServer(), issue)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001370
Andrii Shyshkalov31863012017-02-08 11:35:12 +01001371 def GetDescription(self, pretty=False, force=False):
1372 if not self.has_description or force:
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001373 if self.GetIssue():
Kenneth Russell61e2ed42017-02-15 11:47:13 -08001374 self.description = self._codereview_impl.FetchDescription(force=force)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001375 self.has_description = True
1376 if pretty:
Asanka Herath7c61dcb2016-12-14 13:01:58 -05001377 # Set width to 72 columns + 2 space indent.
1378 wrapper = textwrap.TextWrapper(width=74, replace_whitespace=True)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001379 wrapper.initial_indent = wrapper.subsequent_indent = ' '
Asanka Herath7c61dcb2016-12-14 13:01:58 -05001380 lines = self.description.splitlines()
1381 return '\n'.join([wrapper.fill(line) for line in lines])
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001382 return self.description
1383
Robert Iannucci09f1f3d2017-03-28 16:54:32 -07001384 def GetDescriptionFooters(self):
1385 """Returns (non_footer_lines, footers) for the commit message.
1386
1387 Returns:
1388 non_footer_lines (list(str)) - Simple list of description lines without
1389 any footer. The lines do not contain newlines, nor does the list contain
1390 the empty line between the message and the footers.
1391 footers (list(tuple(KEY, VALUE))) - List of parsed footers, e.g.
1392 [("Change-Id", "Ideadbeef...."), ...]
1393 """
1394 raw_description = self.GetDescription()
1395 msg_lines, _, footers = git_footers.split_footers(raw_description)
1396 if footers:
1397 msg_lines = msg_lines[:len(msg_lines)-1]
1398 return msg_lines, footers
1399
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001400 def GetPatchset(self):
maruel@chromium.org52424302012-08-29 15:14:30 +00001401 """Returns the patchset number as a int or None if not set."""
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001402 if self.patchset is None and not self.lookedup_patchset:
tandrii5d48c322016-08-18 16:19:37 -07001403 self.patchset = self._GitGetBranchConfigValue(
1404 self._codereview_impl.PatchsetConfigKey(), value_type=int)
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001405 self.lookedup_patchset = True
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001406 return self.patchset
1407
1408 def SetPatchset(self, patchset):
tandrii5d48c322016-08-18 16:19:37 -07001409 """Set this branch's patchset. If patchset=0, clears the patchset."""
1410 assert self.GetBranch()
1411 if not patchset:
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001412 self.patchset = None
tandrii5d48c322016-08-18 16:19:37 -07001413 else:
1414 self.patchset = int(patchset)
1415 self._GitSetBranchConfigValue(
1416 self._codereview_impl.PatchsetConfigKey(), self.patchset)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001417
tandrii@chromium.orga342c922016-03-16 07:08:25 +00001418 def SetIssue(self, issue=None):
tandrii5d48c322016-08-18 16:19:37 -07001419 """Set this branch's issue. If issue isn't given, clears the issue."""
1420 assert self.GetBranch()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001421 if issue:
tandrii5d48c322016-08-18 16:19:37 -07001422 issue = int(issue)
1423 self._GitSetBranchConfigValue(
1424 self._codereview_impl.IssueConfigKey(), issue)
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001425 self.issue = issue
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001426 codereview_server = self._codereview_impl.GetCodereviewServer()
1427 if codereview_server:
tandrii5d48c322016-08-18 16:19:37 -07001428 self._GitSetBranchConfigValue(
1429 self._codereview_impl.CodereviewServerConfigKey(),
1430 codereview_server)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001431 else:
tandrii5d48c322016-08-18 16:19:37 -07001432 # Reset all of these just to be clean.
1433 reset_suffixes = [
1434 'last-upload-hash',
1435 self._codereview_impl.IssueConfigKey(),
1436 self._codereview_impl.PatchsetConfigKey(),
1437 self._codereview_impl.CodereviewServerConfigKey(),
1438 ] + self._PostUnsetIssueProperties()
1439 for prop in reset_suffixes:
1440 self._GitSetBranchConfigValue(prop, None, error_ok=True)
Aaron Gableca01e2c2017-07-19 11:16:02 -07001441 msg = RunGit(['log', '-1', '--format=%B']).strip()
1442 if msg and git_footers.get_footer_change_id(msg):
1443 print('WARNING: The change patched into this branch has a Change-Id. '
1444 'Removing it.')
1445 RunGit(['commit', '--amend', '-m',
1446 git_footers.remove_footer(msg, 'Change-Id')])
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001447 self.issue = None
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00001448 self.patchset = None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001449
dnjba1b0f32016-09-02 12:37:42 -07001450 def GetChange(self, upstream_branch, author, local_description=False):
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001451 if not self.GitSanityChecks(upstream_branch):
1452 DieWithError('\nGit sanity check failure')
1453
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00001454 root = settings.GetRelativeRoot()
bratell@opera.comf267b0e2013-05-02 09:11:43 +00001455 if not root:
1456 root = '.'
bauerb@chromium.org512f1ef2011-04-20 15:17:57 +00001457 absroot = os.path.abspath(root)
bauerb@chromium.org6fb99c62011-04-18 15:57:28 +00001458
1459 # We use the sha1 of HEAD as a name of this change.
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00001460 name = RunGitWithCode(['rev-parse', 'HEAD'])[1].strip()
bauerb@chromium.org512f1ef2011-04-20 15:17:57 +00001461 # Need to pass a relative path for msysgit.
maruel@chromium.org2b38e9c2011-10-19 00:04:35 +00001462 try:
maruel@chromium.org80a9ef12011-12-13 20:44:10 +00001463 files = scm.GIT.CaptureStatus([root], '.', upstream_branch)
maruel@chromium.org2b38e9c2011-10-19 00:04:35 +00001464 except subprocess2.CalledProcessError:
1465 DieWithError(
pgervais@chromium.orgd6617f32013-11-19 00:34:54 +00001466 ('\nFailed to diff against upstream branch %s\n\n'
maruel@chromium.org2b38e9c2011-10-19 00:04:35 +00001467 'This branch probably doesn\'t exist anymore. To reset the\n'
1468 'tracking branch, please run\n'
stip7a3dd352016-09-22 17:32:28 -07001469 ' git branch --set-upstream-to origin/master %s\n'
1470 'or replace origin/master with the relevant branch') %
maruel@chromium.org2b38e9c2011-10-19 00:04:35 +00001471 (upstream_branch, self.GetBranch()))
bauerb@chromium.org6fb99c62011-04-18 15:57:28 +00001472
maruel@chromium.org52424302012-08-29 15:14:30 +00001473 issue = self.GetIssue()
1474 patchset = self.GetPatchset()
dnjba1b0f32016-09-02 12:37:42 -07001475 if issue and not local_description:
bauerb@chromium.org6fb99c62011-04-18 15:57:28 +00001476 description = self.GetDescription()
1477 else:
1478 # If the change was never uploaded, use the log messages of all commits
1479 # up to the branch point, as git cl upload will prefill the description
1480 # with these log messages.
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00001481 args = ['log', '--pretty=format:%s%n%n%b', '%s...' % (upstream_branch)]
1482 description = RunGitWithCode(args)[1].strip()
maruel@chromium.org03b3bdc2011-06-14 13:04:12 +00001483
1484 if not author:
maruel@chromium.org13f623c2011-07-22 16:02:23 +00001485 author = RunGit(['config', 'user.email']).strip() or None
asvitkine@chromium.org15169952011-09-27 14:30:53 +00001486 return presubmit_support.GitChange(
bauerb@chromium.org6fb99c62011-04-18 15:57:28 +00001487 name,
1488 description,
1489 absroot,
1490 files,
1491 issue,
1492 patchset,
agable@chromium.orgea84ef12014-04-30 19:55:12 +00001493 author,
1494 upstream=upstream_branch)
bauerb@chromium.org6fb99c62011-04-18 15:57:28 +00001495
dsansomee2d6fd92016-09-08 00:10:47 -07001496 def UpdateDescription(self, description, force=False):
Andrii Shyshkalov83051152017-02-07 23:47:29 +01001497 self._codereview_impl.UpdateDescriptionRemote(description, force=force)
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001498 self.description = description
Andrii Shyshkalov83051152017-02-07 23:47:29 +01001499 self.has_description = True
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001500
Robert Iannucci09f1f3d2017-03-28 16:54:32 -07001501 def UpdateDescriptionFooters(self, description_lines, footers, force=False):
1502 """Sets the description for this CL remotely.
1503
1504 You can get description_lines and footers with GetDescriptionFooters.
1505
1506 Args:
1507 description_lines (list(str)) - List of CL description lines without
1508 newline characters.
1509 footers (list(tuple(KEY, VALUE))) - List of footers, as returned by
1510 GetDescriptionFooters. Key must conform to the git footers format (i.e.
1511 `List-Of-Tokens`). It will be case-normalized so that each token is
1512 title-cased.
1513 """
1514 new_description = '\n'.join(description_lines)
1515 if footers:
1516 new_description += '\n'
1517 for k, v in footers:
1518 foot = '%s: %s' % (git_footers.normalize_name(k), v)
1519 if not git_footers.FOOTER_PATTERN.match(foot):
1520 raise ValueError('Invalid footer %r' % foot)
1521 new_description += foot + '\n'
1522 self.UpdateDescription(new_description, force)
1523
Edward Lesmes8e282792018-04-03 18:50:29 -04001524 def RunHook(self, committing, may_prompt, verbose, change, parallel):
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001525 """Calls sys.exit() if the hook fails; returns a HookResults otherwise."""
1526 try:
1527 return presubmit_support.DoPresubmitChecks(change, committing,
1528 verbose=verbose, output_stream=sys.stdout, input_stream=sys.stdin,
1529 default_presubmit=None, may_prompt=may_prompt,
Edward Lesmes8e282792018-04-03 18:50:29 -04001530 gerrit_obj=self._codereview_impl.GetGerritObjForPresubmit(),
1531 parallel=parallel)
vapierfd77ac72016-06-16 08:33:57 -07001532 except presubmit_support.PresubmitFailure as e:
Aaron Gable5d5f22c2018-02-02 09:12:41 -08001533 DieWithError('%s\nMaybe your depot_tools is out of date?' % e)
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001534
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001535 def CMDPatchIssue(self, issue_arg, reject, nocommit, directory):
1536 """Fetches and applies the issue patch from codereview to local branch."""
tandrii@chromium.orgef7c68c2016-04-07 09:39:39 +00001537 if isinstance(issue_arg, (int, long)) or issue_arg.isdigit():
1538 parsed_issue_arg = _ParsedIssueNumberArgument(int(issue_arg))
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001539 else:
1540 # Assume url.
1541 parsed_issue_arg = self._codereview_impl.ParseIssueURL(
1542 urlparse.urlparse(issue_arg))
1543 if not parsed_issue_arg or not parsed_issue_arg.valid:
1544 DieWithError('Failed to parse issue argument "%s". '
1545 'Must be an issue number or a valid URL.' % issue_arg)
1546 return self._codereview_impl.CMDPatchWithParsedIssue(
Aaron Gable62619a32017-06-16 08:22:09 -07001547 parsed_issue_arg, reject, nocommit, directory, False)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001548
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001549 def CMDUpload(self, options, git_diff_args, orig_args):
1550 """Uploads a change to codereview."""
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001551 custom_cl_base = None
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001552 if git_diff_args:
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001553 custom_cl_base = base_branch = git_diff_args[0]
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001554 else:
1555 if self.GetBranch() is None:
1556 DieWithError('Can\'t upload from detached HEAD state. Get on a branch!')
1557
1558 # Default to diffing against common ancestor of upstream branch
1559 base_branch = self.GetCommonAncestorWithUpstream()
1560 git_diff_args = [base_branch, 'HEAD']
1561
Aaron Gablec4c40d12017-05-22 11:49:53 -07001562 # Warn about Rietveld deprecation for initial uploads to Rietveld.
1563 if not self.IsGerrit() and not self.GetIssue():
1564 print('=====================================')
1565 print('NOTICE: Rietveld is being deprecated. '
1566 'You can upload changes to Gerrit with')
1567 print(' git cl upload --gerrit')
1568 print('or set Gerrit to be your default code review tool with')
1569 print(' git config gerrit.host true')
1570 print('=====================================')
1571
Andrii Shyshkalov3e631422017-02-16 17:46:44 +01001572 # Fast best-effort checks to abort before running potentially
1573 # expensive hooks if uploading is likely to fail anyway. Passing these
1574 # checks does not guarantee that uploading will not fail.
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001575 self._codereview_impl.EnsureAuthenticated(force=options.force)
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001576 self._codereview_impl.EnsureCanUploadPatchset(force=options.force)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001577
1578 # Apply watchlists on upload.
1579 change = self.GetChange(base_branch, None)
1580 watchlist = watchlists.Watchlists(change.RepositoryRoot())
1581 files = [f.LocalPath() for f in change.AffectedFiles()]
1582 if not options.bypass_watchlists:
Daniel Cheng7227d212017-11-17 08:12:37 -08001583 self.ExtendCC(watchlist.GetWatchersForPaths(files))
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001584
1585 if not options.bypass_hooks:
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001586 if options.reviewers or options.tbrs or options.add_owners_to:
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001587 # Set the reviewer list now so that presubmit checks can access it.
1588 change_description = ChangeDescription(change.FullDescriptionText())
1589 change_description.update_reviewers(options.reviewers,
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001590 options.tbrs,
Robert Iannuccif2708bd2017-04-17 15:49:02 -07001591 options.add_owners_to,
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001592 change)
1593 change.SetDescriptionText(change_description.description)
1594 hook_results = self.RunHook(committing=False,
Edward Lesmes8e282792018-04-03 18:50:29 -04001595 may_prompt=not options.force,
1596 verbose=options.verbose,
1597 change=change, parallel=options.parallel)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001598 if not hook_results.should_continue():
1599 return 1
1600 if not options.reviewers and hook_results.reviewers:
1601 options.reviewers = hook_results.reviewers.split(',')
Daniel Cheng7227d212017-11-17 08:12:37 -08001602 self.ExtendCC(hook_results.more_cc)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001603
Ravi Mistryfda50ca2016-11-14 10:19:18 -05001604 # TODO(tandrii): Checking local patchset against remote patchset is only
1605 # supported for Rietveld. Extend it to Gerrit or remove it completely.
1606 if self.GetIssue() and not self.IsGerrit():
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001607 latest_patchset = self.GetMostRecentPatchset()
1608 local_patchset = self.GetPatchset()
1609 if (latest_patchset and local_patchset and
1610 local_patchset != latest_patchset):
vapiera7fbd5a2016-06-16 09:17:49 -07001611 print('The last upload made from this repository was patchset #%d but '
1612 'the most recent patchset on the server is #%d.'
1613 % (local_patchset, latest_patchset))
1614 print('Uploading will still work, but if you\'ve uploaded to this '
1615 'issue from another machine or branch the patch you\'re '
1616 'uploading now might not include those changes.')
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01001617 confirm_or_exit(action='upload')
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001618
Aaron Gable13101a62018-02-09 13:20:41 -08001619 print_stats(git_diff_args)
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001620 ret = self.CMDUploadChange(options, git_diff_args, custom_cl_base, change)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001621 if not ret:
Ravi Mistry31e7d562018-04-02 12:53:57 -04001622 if self.IsGerrit():
1623 self.SetLabels(options.enable_auto_submit, options.use_commit_queue,
1624 options.cq_dry_run);
1625 else:
1626 if options.use_commit_queue:
1627 self.SetCQState(_CQState.COMMIT)
1628 elif options.cq_dry_run:
1629 self.SetCQState(_CQState.DRY_RUN)
tandrii4d0545a2016-07-06 03:56:49 -07001630
tandrii5d48c322016-08-18 16:19:37 -07001631 _git_set_branch_config_value('last-upload-hash',
1632 RunGit(['rev-parse', 'HEAD']).strip())
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001633 # Run post upload hooks, if specified.
1634 if settings.GetRunPostUploadHook():
1635 presubmit_support.DoPostUploadExecuter(
1636 change,
1637 self,
1638 settings.GetRoot(),
1639 options.verbose,
1640 sys.stdout)
1641
1642 # Upload all dependencies if specified.
1643 if options.dependencies:
vapiera7fbd5a2016-06-16 09:17:49 -07001644 print()
1645 print('--dependencies has been specified.')
1646 print('All dependent local branches will be re-uploaded.')
1647 print()
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001648 # Remove the dependencies flag from args so that we do not end up in a
1649 # loop.
1650 orig_args.remove('--dependencies')
1651 ret = upload_branch_deps(self, orig_args)
1652 return ret
1653
Ravi Mistry31e7d562018-04-02 12:53:57 -04001654 def SetLabels(self, enable_auto_submit, use_commit_queue, cq_dry_run):
1655 """Sets labels on the change based on the provided flags.
1656
1657 Sets labels if issue is already uploaded and known, else returns without
1658 doing anything.
1659
1660 Args:
1661 enable_auto_submit: Sets Auto-Submit+1 on the change.
1662 use_commit_queue: Sets Commit-Queue+2 on the change.
1663 cq_dry_run: Sets Commit-Queue+1 on the change. Overrides Commit-Queue+2 if
1664 both use_commit_queue and cq_dry_run are true.
1665 """
1666 if not self.GetIssue():
1667 return
1668 try:
1669 self._codereview_impl.SetLabels(enable_auto_submit, use_commit_queue,
1670 cq_dry_run)
1671 return 0
1672 except KeyboardInterrupt:
1673 raise
1674 except:
1675 labels = []
1676 if enable_auto_submit:
1677 labels.append('Auto-Submit')
1678 if use_commit_queue or cq_dry_run:
1679 labels.append('Commit-Queue')
1680 print('WARNING: Failed to set label(s) on your change: %s\n'
1681 'Either:\n'
1682 ' * Your project does not have the above label(s),\n'
1683 ' * You don\'t have permission to set the above label(s),\n'
1684 ' * There\'s a bug in this code (see stack trace below).\n' %
1685 (', '.join(labels)))
1686 # Still raise exception so that stack trace is printed.
1687 raise
1688
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001689 def SetCQState(self, new_state):
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07001690 """Updates the CQ state for the latest patchset.
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001691
1692 Issue must have been already uploaded and known.
1693 """
1694 assert new_state in _CQState.ALL_STATES
1695 assert self.GetIssue()
qyearsley1fdfcb62016-10-24 13:22:03 -07001696 try:
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07001697 self._codereview_impl.SetCQState(new_state)
qyearsley1fdfcb62016-10-24 13:22:03 -07001698 return 0
1699 except KeyboardInterrupt:
1700 raise
1701 except:
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07001702 print('WARNING: Failed to %s.\n'
qyearsley1fdfcb62016-10-24 13:22:03 -07001703 'Either:\n'
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07001704 ' * Your project has no CQ,\n'
1705 ' * You don\'t have permission to change the CQ state,\n'
1706 ' * There\'s a bug in this code (see stack trace below).\n'
1707 'Consider specifying which bots to trigger manually or asking your '
1708 'project owners for permissions or contacting Chrome Infra at:\n'
1709 'https://www.chromium.org/infra\n\n' %
1710 ('cancel CQ' if new_state == _CQState.NONE else 'trigger CQ'))
qyearsley1fdfcb62016-10-24 13:22:03 -07001711 # Still raise exception so that stack trace is printed.
1712 raise
1713
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001714 # Forward methods to codereview specific implementation.
1715
Aaron Gable636b13f2017-07-14 10:42:48 -07001716 def AddComment(self, message, publish=None):
1717 return self._codereview_impl.AddComment(message, publish=publish)
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01001718
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001719 def GetCommentsSummary(self, readable=True):
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01001720 """Returns list of _CommentSummary for each comment.
1721
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001722 args:
1723 readable: determines whether the output is designed for a human or a machine
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01001724 """
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001725 return self._codereview_impl.GetCommentsSummary(readable)
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01001726
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001727 def CloseIssue(self):
1728 return self._codereview_impl.CloseIssue()
1729
1730 def GetStatus(self):
1731 return self._codereview_impl.GetStatus()
1732
1733 def GetCodereviewServer(self):
1734 return self._codereview_impl.GetCodereviewServer()
1735
tandriide281ae2016-10-12 06:02:30 -07001736 def GetIssueOwner(self):
1737 """Get owner from codereview, which may differ from this checkout."""
1738 return self._codereview_impl.GetIssueOwner()
1739
Edward Lemur707d70b2018-02-07 00:50:14 +01001740 def GetReviewers(self):
1741 return self._codereview_impl.GetReviewers()
1742
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001743 def GetMostRecentPatchset(self):
1744 return self._codereview_impl.GetMostRecentPatchset()
1745
tandriide281ae2016-10-12 06:02:30 -07001746 def CannotTriggerTryJobReason(self):
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001747 """Returns reason (str) if unable trigger try jobs on this CL or None."""
tandriide281ae2016-10-12 06:02:30 -07001748 return self._codereview_impl.CannotTriggerTryJobReason()
1749
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001750 def GetTryJobProperties(self, patchset=None):
1751 """Returns dictionary of properties to launch try job."""
1752 return self._codereview_impl.GetTryJobProperties(patchset=patchset)
tandrii8c5a3532016-11-04 07:52:02 -07001753
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001754 def __getattr__(self, attr):
1755 # This is because lots of untested code accesses Rietveld-specific stuff
1756 # directly, and it's hard to fix for sure. So, just let it work, and fix
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00001757 # on a case by case basis.
tandrii4d895502016-08-18 08:26:19 -07001758 # Note that child method defines __getattr__ as well, and forwards it here,
1759 # because _RietveldChangelistImpl is not cleaned up yet, and given
1760 # deprecation of Rietveld, it should probably be just removed.
1761 # Until that time, avoid infinite recursion by bypassing __getattr__
1762 # of implementation class.
1763 return self._codereview_impl.__getattribute__(attr)
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001764
1765
1766class _ChangelistCodereviewBase(object):
1767 """Abstract base class encapsulating codereview specifics of a changelist."""
1768 def __init__(self, changelist):
1769 self._changelist = changelist # instance of Changelist
1770
1771 def __getattr__(self, attr):
1772 # Forward methods to changelist.
1773 # TODO(tandrii): maybe clean up _GerritChangelistImpl and
1774 # _RietveldChangelistImpl to avoid this hack?
1775 return getattr(self._changelist, attr)
1776
1777 def GetStatus(self):
1778 """Apply a rough heuristic to give a simple summary of an issue's review
1779 or CQ status, assuming adherence to a common workflow.
1780
1781 Returns None if no issue for this branch, or specific string keywords.
1782 """
1783 raise NotImplementedError()
1784
1785 def GetCodereviewServer(self):
1786 """Returns server URL without end slash, like "https://codereview.com"."""
1787 raise NotImplementedError()
1788
Kenneth Russell61e2ed42017-02-15 11:47:13 -08001789 def FetchDescription(self, force=False):
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001790 """Fetches and returns description from the codereview server."""
1791 raise NotImplementedError()
1792
tandrii5d48c322016-08-18 16:19:37 -07001793 @classmethod
1794 def IssueConfigKey(cls):
1795 """Returns branch setting storing issue number."""
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001796 raise NotImplementedError()
1797
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001798 @classmethod
tandrii5d48c322016-08-18 16:19:37 -07001799 def PatchsetConfigKey(cls):
1800 """Returns branch setting storing patchset number."""
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001801 raise NotImplementedError()
1802
tandrii5d48c322016-08-18 16:19:37 -07001803 @classmethod
1804 def CodereviewServerConfigKey(cls):
1805 """Returns branch setting storing codereview server."""
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001806 raise NotImplementedError()
1807
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00001808 def _PostUnsetIssueProperties(self):
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001809 """Which branch-specific properties to erase when unsetting issue."""
tandrii5d48c322016-08-18 16:19:37 -07001810 return []
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00001811
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001812 def GetGerritObjForPresubmit(self):
1813 # None is valid return value, otherwise presubmit_support.GerritAccessor.
1814 return None
1815
dsansomee2d6fd92016-09-08 00:10:47 -07001816 def UpdateDescriptionRemote(self, description, force=False):
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001817 """Update the description on codereview site."""
1818 raise NotImplementedError()
1819
Aaron Gable636b13f2017-07-14 10:42:48 -07001820 def AddComment(self, message, publish=None):
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01001821 """Posts a comment to the codereview site."""
1822 raise NotImplementedError()
1823
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001824 def GetCommentsSummary(self, readable=True):
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01001825 raise NotImplementedError()
1826
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001827 def CloseIssue(self):
1828 """Closes the issue."""
1829 raise NotImplementedError()
1830
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001831 def GetMostRecentPatchset(self):
1832 """Returns the most recent patchset number from the codereview site."""
1833 raise NotImplementedError()
1834
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001835 def CMDPatchWithParsedIssue(self, parsed_issue_arg, reject, nocommit,
Aaron Gable62619a32017-06-16 08:22:09 -07001836 directory, force):
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001837 """Fetches and applies the issue.
1838
1839 Arguments:
1840 parsed_issue_arg: instance of _ParsedIssueNumberArgument.
1841 reject: if True, reject the failed patch instead of switching to 3-way
1842 merge. Rietveld only.
1843 nocommit: do not commit the patch, thus leave the tree dirty. Rietveld
1844 only.
1845 directory: switch to directory before applying the patch. Rietveld only.
Aaron Gable62619a32017-06-16 08:22:09 -07001846 force: if true, overwrites existing local state.
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001847 """
1848 raise NotImplementedError()
1849
1850 @staticmethod
1851 def ParseIssueURL(parsed_url):
1852 """Parses url and returns instance of _ParsedIssueNumberArgument or None if
1853 failed."""
1854 raise NotImplementedError()
1855
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01001856 def EnsureAuthenticated(self, force, refresh=False):
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001857 """Best effort check that user is authenticated with codereview server.
1858
1859 Arguments:
1860 force: whether to skip confirmation questions.
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01001861 refresh: whether to attempt to refresh credentials. Ignored if not
1862 applicable.
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001863 """
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001864 raise NotImplementedError()
1865
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001866 def EnsureCanUploadPatchset(self, force):
Andrii Shyshkalov3e631422017-02-16 17:46:44 +01001867 """Best effort check that uploading isn't supposed to fail for predictable
1868 reasons.
1869
1870 This method should raise informative exception if uploading shouldn't
1871 proceed.
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001872
1873 Arguments:
1874 force: whether to skip confirmation questions.
Andrii Shyshkalov3e631422017-02-16 17:46:44 +01001875 """
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001876 raise NotImplementedError()
Andrii Shyshkalov3e631422017-02-16 17:46:44 +01001877
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001878 def CMDUploadChange(self, options, git_diff_args, custom_cl_base, change):
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00001879 """Uploads a change to codereview."""
1880 raise NotImplementedError()
1881
Ravi Mistry31e7d562018-04-02 12:53:57 -04001882 def SetLabels(self, enable_auto_submit, use_commit_queue, cq_dry_run):
1883 """Sets labels on the change based on the provided flags.
1884
1885 Issue must have been already uploaded and known.
1886 """
1887 raise NotImplementedError()
1888
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001889 def SetCQState(self, new_state):
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001890 """Updates the CQ state for the latest patchset.
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001891
1892 Issue must have been already uploaded and known.
1893 """
1894 raise NotImplementedError()
1895
tandriie113dfd2016-10-11 10:20:12 -07001896 def CannotTriggerTryJobReason(self):
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001897 """Returns reason (str) if unable trigger try jobs on this CL or None."""
tandriie113dfd2016-10-11 10:20:12 -07001898 raise NotImplementedError()
1899
tandriide281ae2016-10-12 06:02:30 -07001900 def GetIssueOwner(self):
1901 raise NotImplementedError()
1902
Edward Lemur707d70b2018-02-07 00:50:14 +01001903 def GetReviewers(self):
1904 raise NotImplementedError()
1905
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001906 def GetTryJobProperties(self, patchset=None):
tandriide281ae2016-10-12 06:02:30 -07001907 raise NotImplementedError()
1908
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001909
1910class _RietveldChangelistImpl(_ChangelistCodereviewBase):
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001911
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01001912 def __init__(self, changelist, auth_config=None, codereview_host=None):
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001913 super(_RietveldChangelistImpl, self).__init__(changelist)
1914 assert settings, 'must be initialized in _ChangelistCodereviewBase'
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01001915 if not codereview_host:
martiniss6eda05f2016-06-30 10:18:35 -07001916 settings.GetDefaultServerUrl()
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001917
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01001918 self._rietveld_server = codereview_host
Andrii Shyshkalov98cef572017-01-25 13:57:52 +01001919 self._auth_config = auth_config or auth.make_auth_config()
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001920 self._props = None
1921 self._rpc_server = None
1922
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001923 def GetCodereviewServer(self):
1924 if not self._rietveld_server:
1925 # If we're on a branch then get the server potentially associated
1926 # with that branch.
1927 if self.GetIssue():
tandrii5d48c322016-08-18 16:19:37 -07001928 self._rietveld_server = gclient_utils.UpgradeToHttps(
1929 self._GitGetBranchConfigValue(self.CodereviewServerConfigKey()))
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001930 if not self._rietveld_server:
1931 self._rietveld_server = settings.GetDefaultServerUrl()
1932 return self._rietveld_server
1933
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01001934 def EnsureAuthenticated(self, force, refresh=False):
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001935 """Best effort check that user is authenticated with Rietveld server."""
1936 if self._auth_config.use_oauth2:
1937 authenticator = auth.get_authenticator_for_host(
1938 self.GetCodereviewServer(), self._auth_config)
1939 if not authenticator.has_cached_credentials():
1940 raise auth.LoginRequiredError(self.GetCodereviewServer())
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01001941 if refresh:
1942 authenticator.get_access_token()
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001943
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001944 def EnsureCanUploadPatchset(self, force):
1945 # No checks for Rietveld because we are deprecating Rietveld.
1946 pass
1947
Kenneth Russell61e2ed42017-02-15 11:47:13 -08001948 def FetchDescription(self, force=False):
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001949 issue = self.GetIssue()
1950 assert issue
1951 try:
Kenneth Russell61e2ed42017-02-15 11:47:13 -08001952 return self.RpcServer().get_description(issue, force=force).strip()
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001953 except urllib2.HTTPError as e:
1954 if e.code == 404:
1955 DieWithError(
1956 ('\nWhile fetching the description for issue %d, received a '
1957 '404 (not found)\n'
1958 'error. It is likely that you deleted this '
1959 'issue on the server. If this is the\n'
1960 'case, please run\n\n'
1961 ' git cl issue 0\n\n'
1962 'to clear the association with the deleted issue. Then run '
1963 'this command again.') % issue)
1964 else:
1965 DieWithError(
1966 '\nFailed to fetch issue description. HTTP error %d' % e.code)
1967 except urllib2.URLError as e:
vapiera7fbd5a2016-06-16 09:17:49 -07001968 print('Warning: Failed to retrieve CL description due to network '
1969 'failure.', file=sys.stderr)
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001970 return ''
1971
1972 def GetMostRecentPatchset(self):
1973 return self.GetIssueProperties()['patchsets'][-1]
1974
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001975 def GetIssueProperties(self):
1976 if self._props is None:
1977 issue = self.GetIssue()
1978 if not issue:
1979 self._props = {}
1980 else:
1981 self._props = self.RpcServer().get_issue_properties(issue, True)
1982 return self._props
1983
tandriie113dfd2016-10-11 10:20:12 -07001984 def CannotTriggerTryJobReason(self):
1985 props = self.GetIssueProperties()
1986 if not props:
1987 return 'Rietveld doesn\'t know about your issue %s' % self.GetIssue()
1988 if props.get('closed'):
1989 return 'CL %s is closed' % self.GetIssue()
1990 if props.get('private'):
1991 return 'CL %s is private' % self.GetIssue()
1992 return None
1993
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001994 def GetTryJobProperties(self, patchset=None):
1995 """Returns dictionary of properties to launch try job."""
tandrii8c5a3532016-11-04 07:52:02 -07001996 project = (self.GetIssueProperties() or {}).get('project')
1997 return {
1998 'issue': self.GetIssue(),
1999 'patch_project': project,
2000 'patch_storage': 'rietveld',
2001 'patchset': patchset or self.GetPatchset(),
2002 'rietveld': self.GetCodereviewServer(),
2003 }
2004
tandriide281ae2016-10-12 06:02:30 -07002005 def GetIssueOwner(self):
2006 return (self.GetIssueProperties() or {}).get('owner_email')
2007
Edward Lemur707d70b2018-02-07 00:50:14 +01002008 def GetReviewers(self):
2009 return (self.GetIssueProperties() or {}).get('reviewers')
2010
Aaron Gable636b13f2017-07-14 10:42:48 -07002011 def AddComment(self, message, publish=None):
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00002012 return self.RpcServer().add_comment(self.GetIssue(), message)
2013
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002014 def GetCommentsSummary(self, _readable=True):
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01002015 summary = []
2016 for message in self.GetIssueProperties().get('messages', []):
2017 date = datetime.datetime.strptime(message['date'], '%Y-%m-%d %H:%M:%S.%f')
2018 summary.append(_CommentSummary(
2019 date=date,
2020 disapproval=bool(message['disapproval']),
2021 approval=bool(message['approval']),
2022 sender=message['sender'],
2023 message=message['text'],
2024 ))
2025 return summary
2026
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00002027 def GetStatus(self):
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002028 """Applies a rough heuristic to give a simple summary of an issue's review
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00002029 or CQ status, assuming adherence to a common workflow.
2030
2031 Returns None if no issue for this branch, or one of the following keywords:
Aaron Gablea1bab272017-04-11 16:38:18 -07002032 * 'error' - error from review tool (including deleted issues)
2033 * 'unsent' - not sent for review
2034 * 'waiting' - waiting for review
2035 * 'reply' - waiting for owner to reply to review
2036 * 'not lgtm' - Code-Review label has been set negatively
2037 * 'lgtm' - LGTM from at least one approved reviewer
2038 * 'commit' - in the commit queue
2039 * 'closed' - closed
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00002040 """
2041 if not self.GetIssue():
2042 return None
2043
2044 try:
2045 props = self.GetIssueProperties()
2046 except urllib2.HTTPError:
2047 return 'error'
2048
2049 if props.get('closed'):
2050 # Issue is closed.
2051 return 'closed'
tandrii@chromium.orgb4f6a222016-03-03 01:11:04 +00002052 if props.get('commit') and not props.get('cq_dry_run', False):
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00002053 # Issue is in the commit queue.
2054 return 'commit'
2055
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00002056 messages = props.get('messages') or []
Aaron Gablea1bab272017-04-11 16:38:18 -07002057 if not messages:
2058 # No message was sent.
2059 return 'unsent'
2060
2061 if get_approving_reviewers(props):
2062 return 'lgtm'
2063 elif get_approving_reviewers(props, disapproval=True):
2064 return 'not lgtm'
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00002065
tandrii9d2c7a32016-06-22 03:42:45 -07002066 # Skip CQ messages that don't require owner's action.
2067 while messages and messages[-1]['sender'] == COMMIT_BOT_EMAIL:
2068 if 'Dry run:' in messages[-1]['text']:
2069 messages.pop()
2070 elif 'The CQ bit was unchecked' in messages[-1]['text']:
2071 # This message always follows prior messages from CQ,
2072 # so skip this too.
2073 messages.pop()
2074 else:
2075 # This is probably a CQ messages warranting user attention.
2076 break
2077
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00002078 if messages[-1]['sender'] != props.get('owner_email'):
tandrii9d2c7a32016-06-22 03:42:45 -07002079 # Non-LGTM reply from non-owner and not CQ bot.
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00002080 return 'reply'
2081 return 'waiting'
2082
dsansomee2d6fd92016-09-08 00:10:47 -07002083 def UpdateDescriptionRemote(self, description, force=False):
Andrii Shyshkalov83051152017-02-07 23:47:29 +01002084 self.RpcServer().update_description(self.GetIssue(), description)
maruel@chromium.orgb021b322013-04-08 17:57:29 +00002085
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00002086 def CloseIssue(self):
maruel@chromium.orgb021b322013-04-08 17:57:29 +00002087 return self.RpcServer().close_issue(self.GetIssue())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00002088
maruel@chromium.org27bb3872011-05-30 20:33:19 +00002089 def SetFlag(self, flag, value):
tandrii4b233bd2016-07-06 03:50:29 -07002090 return self.SetFlags({flag: value})
2091
2092 def SetFlags(self, flags):
2093 """Sets flags on this CL/patchset in Rietveld.
tandrii4b233bd2016-07-06 03:50:29 -07002094 """
phajdan.jr68598232016-08-10 03:28:28 -07002095 patchset = self.GetPatchset() or self.GetMostRecentPatchset()
maruel@chromium.org27bb3872011-05-30 20:33:19 +00002096 try:
tandrii4b233bd2016-07-06 03:50:29 -07002097 return self.RpcServer().set_flags(
phajdan.jr68598232016-08-10 03:28:28 -07002098 self.GetIssue(), patchset, flags)
vapierfd77ac72016-06-16 08:33:57 -07002099 except urllib2.HTTPError as e:
maruel@chromium.org27bb3872011-05-30 20:33:19 +00002100 if e.code == 404:
2101 DieWithError('The issue %s doesn\'t exist.' % self.GetIssue())
2102 if e.code == 403:
2103 DieWithError(
2104 ('Access denied to issue %s. Maybe the patchset %s doesn\'t '
phajdan.jr68598232016-08-10 03:28:28 -07002105 'match?') % (self.GetIssue(), patchset))
maruel@chromium.org27bb3872011-05-30 20:33:19 +00002106 raise
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00002107
maruel@chromium.orgcab38e92011-04-09 00:30:51 +00002108 def RpcServer(self):
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00002109 """Returns an upload.RpcServer() to access this review's rietveld instance.
2110 """
maruel@chromium.orge77ebbf2011-03-29 20:35:38 +00002111 if not self._rpc_server:
maruel@chromium.org4bac4b52012-11-27 20:33:52 +00002112 self._rpc_server = rietveld.CachingRietveld(
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00002113 self.GetCodereviewServer(),
Andrii Shyshkalov98cef572017-01-25 13:57:52 +01002114 self._auth_config)
maruel@chromium.orge77ebbf2011-03-29 20:35:38 +00002115 return self._rpc_server
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00002116
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00002117 @classmethod
tandrii5d48c322016-08-18 16:19:37 -07002118 def IssueConfigKey(cls):
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00002119 return 'rietveldissue'
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00002120
tandrii5d48c322016-08-18 16:19:37 -07002121 @classmethod
2122 def PatchsetConfigKey(cls):
2123 return 'rietveldpatchset'
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00002124
tandrii5d48c322016-08-18 16:19:37 -07002125 @classmethod
2126 def CodereviewServerConfigKey(cls):
2127 return 'rietveldserver'
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002128
Ravi Mistry31e7d562018-04-02 12:53:57 -04002129 def SetLabels(self, enable_auto_submit, use_commit_queue, cq_dry_run):
2130 raise NotImplementedError()
2131
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002132 def SetCQState(self, new_state):
2133 props = self.GetIssueProperties()
2134 if props.get('private'):
2135 DieWithError('Cannot set-commit on private issue')
2136
2137 if new_state == _CQState.COMMIT:
tandrii4d843592016-07-27 08:22:56 -07002138 self.SetFlags({'commit': '1', 'cq_dry_run': '0'})
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002139 elif new_state == _CQState.NONE:
tandrii4b233bd2016-07-06 03:50:29 -07002140 self.SetFlags({'commit': '0', 'cq_dry_run': '0'})
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002141 else:
tandrii4b233bd2016-07-06 03:50:29 -07002142 assert new_state == _CQState.DRY_RUN
2143 self.SetFlags({'commit': '1', 'cq_dry_run': '1'})
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002144
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002145 def CMDPatchWithParsedIssue(self, parsed_issue_arg, reject, nocommit,
Aaron Gable62619a32017-06-16 08:22:09 -07002146 directory, force):
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002147 # PatchIssue should never be called with a dirty tree. It is up to the
2148 # caller to check this, but just in case we assert here since the
2149 # consequences of the caller not checking this could be dire.
2150 assert(not git_common.is_dirty_git_tree('apply'))
2151 assert(parsed_issue_arg.valid)
2152 self._changelist.issue = parsed_issue_arg.issue
2153 if parsed_issue_arg.hostname:
2154 self._rietveld_server = 'https://%s' % parsed_issue_arg.hostname
2155
skobes6468b902016-10-24 08:45:10 -07002156 patchset = parsed_issue_arg.patchset or self.GetMostRecentPatchset()
2157 patchset_object = self.RpcServer().get_patch(self.GetIssue(), patchset)
2158 scm_obj = checkout.GitCheckout(settings.GetRoot(), None, None, None, None)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002159 try:
skobes6468b902016-10-24 08:45:10 -07002160 scm_obj.apply_patch(patchset_object)
2161 except Exception as e:
2162 print(str(e))
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002163 return 1
2164
2165 # If we had an issue, commit the current state and register the issue.
2166 if not nocommit:
Aaron Gabled343c632017-03-15 11:02:26 -07002167 self.SetIssue(self.GetIssue())
2168 self.SetPatchset(patchset)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002169 RunGit(['commit', '-m', (self.GetDescription() + '\n\n' +
2170 'patch from issue %(i)s at patchset '
2171 '%(p)s (http://crrev.com/%(i)s#ps%(p)s)'
2172 % {'i': self.GetIssue(), 'p': patchset})])
vapiera7fbd5a2016-06-16 09:17:49 -07002173 print('Committed patch locally.')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002174 else:
vapiera7fbd5a2016-06-16 09:17:49 -07002175 print('Patch applied to index.')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002176 return 0
2177
2178 @staticmethod
2179 def ParseIssueURL(parsed_url):
2180 if not parsed_url.scheme or not parsed_url.scheme.startswith('http'):
2181 return None
wychen3c1c1722016-08-04 11:46:36 -07002182 # Rietveld patch: https://domain/<number>/#ps<patchset>
2183 match = re.match(r'/(\d+)/$', parsed_url.path)
2184 match2 = re.match(r'ps(\d+)$', parsed_url.fragment)
2185 if match and match2:
skobes6468b902016-10-24 08:45:10 -07002186 return _ParsedIssueNumberArgument(
wychen3c1c1722016-08-04 11:46:36 -07002187 issue=int(match.group(1)),
2188 patchset=int(match2.group(1)),
Andrii Shyshkalov90f31922017-04-10 16:10:21 +02002189 hostname=parsed_url.netloc,
2190 codereview='rietveld')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002191 # Typical url: https://domain/<issue_number>[/[other]]
2192 match = re.match('/(\d+)(/.*)?$', parsed_url.path)
2193 if match:
skobes6468b902016-10-24 08:45:10 -07002194 return _ParsedIssueNumberArgument(
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002195 issue=int(match.group(1)),
Andrii Shyshkalov90f31922017-04-10 16:10:21 +02002196 hostname=parsed_url.netloc,
2197 codereview='rietveld')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002198 # Rietveld patch: https://domain/download/issue<number>_<patchset>.diff
2199 match = re.match(r'/download/issue(\d+)_(\d+).diff$', parsed_url.path)
2200 if match:
skobes6468b902016-10-24 08:45:10 -07002201 return _ParsedIssueNumberArgument(
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002202 issue=int(match.group(1)),
2203 patchset=int(match.group(2)),
Andrii Shyshkalov90f31922017-04-10 16:10:21 +02002204 hostname=parsed_url.netloc,
2205 codereview='rietveld')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002206 return None
2207
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002208 def CMDUploadChange(self, options, args, custom_cl_base, change):
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002209 """Upload the patch to Rietveld."""
2210 upload_args = ['--assume_yes'] # Don't ask about untracked files.
2211 upload_args.extend(['--server', self.GetCodereviewServer()])
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002212 upload_args.extend(auth.auth_config_to_command_options(self._auth_config))
2213 if options.emulate_svn_auto_props:
2214 upload_args.append('--emulate_svn_auto_props')
2215
2216 change_desc = None
2217
2218 if options.email is not None:
2219 upload_args.extend(['--email', options.email])
2220
2221 if self.GetIssue():
nodirca166002016-06-27 10:59:51 -07002222 if options.title is not None:
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002223 upload_args.extend(['--title', options.title])
2224 if options.message:
2225 upload_args.extend(['--message', options.message])
2226 upload_args.extend(['--issue', str(self.GetIssue())])
vapiera7fbd5a2016-06-16 09:17:49 -07002227 print('This branch is associated with issue %s. '
2228 'Adding patch to that issue.' % self.GetIssue())
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002229 else:
nodirca166002016-06-27 10:59:51 -07002230 if options.title is not None:
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002231 upload_args.extend(['--title', options.title])
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08002232 if options.message:
2233 message = options.message
2234 else:
2235 message = CreateDescriptionFromLog(args)
2236 if options.title:
2237 message = options.title + '\n\n' + message
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002238 change_desc = ChangeDescription(message)
Robert Iannuccif2708bd2017-04-17 15:49:02 -07002239 if options.reviewers or options.add_owners_to:
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002240 change_desc.update_reviewers(options.reviewers, options.tbrs,
2241 options.add_owners_to, change)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002242 if not options.force:
Aaron Gable3a16ed12017-03-23 10:51:55 -07002243 change_desc.prompt(bug=options.bug, git_footer=False)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002244
2245 if not change_desc.description:
vapiera7fbd5a2016-06-16 09:17:49 -07002246 print('Description is empty; aborting.')
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002247 return 1
2248
2249 upload_args.extend(['--message', change_desc.description])
2250 if change_desc.get_reviewers():
2251 upload_args.append('--reviewers=%s' % ','.join(
2252 change_desc.get_reviewers()))
2253 if options.send_mail:
2254 if not change_desc.get_reviewers():
Christopher Lamf732cd52017-01-24 12:40:11 +11002255 DieWithError("Must specify reviewers to send email.", change_desc)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002256 upload_args.append('--send_mail')
2257
2258 # We check this before applying rietveld.private assuming that in
2259 # rietveld.cc only addresses which we can send private CLs to are listed
2260 # if rietveld.private is set, and so we should ignore rietveld.cc only
2261 # when --private is specified explicitly on the command line.
2262 if options.private:
2263 logging.warn('rietveld.cc is ignored since private flag is specified. '
2264 'You need to review and add them manually if necessary.')
2265 cc = self.GetCCListWithoutDefault()
2266 else:
2267 cc = self.GetCCList()
2268 cc = ','.join(filter(None, (cc, ','.join(options.cc))))
bradnelsond975b302016-10-23 12:20:23 -07002269 if change_desc.get_cced():
2270 cc = ','.join(filter(None, (cc, ','.join(change_desc.get_cced()))))
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002271 if cc:
2272 upload_args.extend(['--cc', cc])
2273
2274 if options.private or settings.GetDefaultPrivateFlag() == "True":
2275 upload_args.append('--private')
2276
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002277 # Include the upstream repo's URL in the change -- this is useful for
2278 # projects that have their source spread across multiple repos.
2279 remote_url = self.GetGitBaseUrlFromConfig()
2280 if not remote_url:
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08002281 if self.GetRemoteUrl() and '/' in self.GetUpstreamBranch():
2282 remote_url = '%s@%s' % (self.GetRemoteUrl(),
2283 self.GetUpstreamBranch().split('/')[-1])
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002284 if remote_url:
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002285 remote, remote_branch = self.GetRemoteBranch()
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01002286 target_ref = GetTargetRef(remote, remote_branch, options.target_branch)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002287 if target_ref:
2288 upload_args.extend(['--target_ref', target_ref])
2289
2290 # Look for dependent patchsets. See crbug.com/480453 for more details.
2291 remote, upstream_branch = self.FetchUpstreamTuple(self.GetBranch())
2292 upstream_branch = ShortBranchName(upstream_branch)
2293 if remote is '.':
2294 # A local branch is being tracked.
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00002295 local_branch = upstream_branch
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002296 if settings.GetIsSkipDependencyUpload(local_branch):
vapiera7fbd5a2016-06-16 09:17:49 -07002297 print()
2298 print('Skipping dependency patchset upload because git config '
2299 'branch.%s.skip-deps-uploads is set to True.' % local_branch)
2300 print()
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002301 else:
2302 auth_config = auth.extract_auth_config_from_options(options)
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00002303 branch_cl = Changelist(branchref='refs/heads/'+local_branch,
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002304 auth_config=auth_config)
2305 branch_cl_issue_url = branch_cl.GetIssueURL()
2306 branch_cl_issue = branch_cl.GetIssue()
2307 branch_cl_patchset = branch_cl.GetPatchset()
2308 if branch_cl_issue_url and branch_cl_issue and branch_cl_patchset:
2309 upload_args.extend(
2310 ['--depends_on_patchset', '%s:%s' % (
2311 branch_cl_issue, branch_cl_patchset)])
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00002312 print(
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002313 '\n'
2314 'The current branch (%s) is tracking a local branch (%s) with '
2315 'an associated CL.\n'
2316 'Adding %s/#ps%s as a dependency patchset.\n'
2317 '\n' % (self.GetBranch(), local_branch, branch_cl_issue_url,
2318 branch_cl_patchset))
2319
2320 project = settings.GetProject()
2321 if project:
2322 upload_args.extend(['--project', project])
Aaron Gable665a4392017-06-29 10:53:46 -07002323 else:
2324 print()
2325 print('WARNING: Uploading without a project specified. Please ensure '
2326 'your repo\'s codereview.settings has a "PROJECT: foo" line.')
2327 print()
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002328
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002329 try:
2330 upload_args = ['upload'] + upload_args + args
2331 logging.info('upload.RealMain(%s)', upload_args)
2332 issue, patchset = upload.RealMain(upload_args)
2333 issue = int(issue)
2334 patchset = int(patchset)
2335 except KeyboardInterrupt:
2336 sys.exit(1)
2337 except:
2338 # If we got an exception after the user typed a description for their
2339 # change, back up the description before re-raising.
2340 if change_desc:
Christopher Lamf732cd52017-01-24 12:40:11 +11002341 SaveDescriptionBackup(change_desc)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002342 raise
2343
2344 if not self.GetIssue():
2345 self.SetIssue(issue)
2346 self.SetPatchset(patchset)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002347 return 0
2348
Andrii Shyshkalov18975322017-01-25 16:44:13 +01002349
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00002350class _GerritChangelistImpl(_ChangelistCodereviewBase):
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01002351 def __init__(self, changelist, auth_config=None, codereview_host=None):
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00002352 # auth_config is Rietveld thing, kept here to preserve interface only.
2353 super(_GerritChangelistImpl, self).__init__(changelist)
2354 self._change_id = None
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002355 # Lazily cached values.
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002356 self._gerrit_host = None # e.g. chromium-review.googlesource.com
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01002357 self._gerrit_server = None # e.g. https://chromium-review.googlesource.com
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002358 # Map from change number (issue) to its detail cache.
2359 self._detail_cache = {}
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00002360
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01002361 if codereview_host is not None:
2362 assert not codereview_host.startswith('https://'), codereview_host
2363 self._gerrit_host = codereview_host
2364 self._gerrit_server = 'https://%s' % codereview_host
2365
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00002366 def _GetGerritHost(self):
2367 # Lazy load of configs.
2368 self.GetCodereviewServer()
tandriie32e3ea2016-06-22 02:52:48 -07002369 if self._gerrit_host and '.' not in self._gerrit_host:
2370 # Abbreviated domain like "chromium" instead of chromium.googlesource.com.
2371 # This happens for internal stuff http://crbug.com/614312.
2372 parsed = urlparse.urlparse(self.GetRemoteUrl())
2373 if parsed.scheme == 'sso':
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002374 print('WARNING: using non-https URLs for remote is likely broken\n'
tandriie32e3ea2016-06-22 02:52:48 -07002375 ' Your current remote is: %s' % self.GetRemoteUrl())
2376 self._gerrit_host = '%s.googlesource.com' % self._gerrit_host
2377 self._gerrit_server = 'https://%s' % self._gerrit_host
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00002378 return self._gerrit_host
2379
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002380 def _GetGitHost(self):
2381 """Returns git host to be used when uploading change to Gerrit."""
2382 return urlparse.urlparse(self.GetRemoteUrl()).netloc
2383
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00002384 def GetCodereviewServer(self):
2385 if not self._gerrit_server:
2386 # If we're on a branch then get the server potentially associated
2387 # with that branch.
2388 if self.GetIssue():
tandrii5d48c322016-08-18 16:19:37 -07002389 self._gerrit_server = self._GitGetBranchConfigValue(
2390 self.CodereviewServerConfigKey())
2391 if self._gerrit_server:
2392 self._gerrit_host = urlparse.urlparse(self._gerrit_server).netloc
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00002393 if not self._gerrit_server:
2394 # We assume repo to be hosted on Gerrit, and hence Gerrit server
2395 # has "-review" suffix for lowest level subdomain.
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002396 parts = self._GetGitHost().split('.')
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00002397 parts[0] = parts[0] + '-review'
2398 self._gerrit_host = '.'.join(parts)
2399 self._gerrit_server = 'https://%s' % self._gerrit_host
2400 return self._gerrit_server
2401
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00002402 @classmethod
tandrii5d48c322016-08-18 16:19:37 -07002403 def IssueConfigKey(cls):
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00002404 return 'gerritissue'
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00002405
tandrii5d48c322016-08-18 16:19:37 -07002406 @classmethod
2407 def PatchsetConfigKey(cls):
2408 return 'gerritpatchset'
2409
2410 @classmethod
2411 def CodereviewServerConfigKey(cls):
2412 return 'gerritserver'
2413
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01002414 def EnsureAuthenticated(self, force, refresh=None):
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00002415 """Best effort check that user is authenticated with Gerrit server."""
tandrii@chromium.org28253532016-04-14 13:46:56 +00002416 if settings.GetGerritSkipEnsureAuthenticated():
2417 # For projects with unusual authentication schemes.
2418 # See http://crbug.com/603378.
2419 return
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002420 # Lazy-loader to identify Gerrit and Git hosts.
2421 if gerrit_util.GceAuthenticator.is_gce():
2422 return
2423 self.GetCodereviewServer()
2424 git_host = self._GetGitHost()
2425 assert self._gerrit_server and self._gerrit_host
2426 cookie_auth = gerrit_util.CookiesAuthenticator()
2427
2428 gerrit_auth = cookie_auth.get_auth_header(self._gerrit_host)
2429 git_auth = cookie_auth.get_auth_header(git_host)
2430 if gerrit_auth and git_auth:
2431 if gerrit_auth == git_auth:
2432 return
Andrii Shyshkalov354e1d22017-06-09 19:31:33 +02002433 all_gsrc = cookie_auth.get_auth_header('d0esN0tEx1st.googlesource.com')
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002434 print((
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002435 'WARNING: You have different credentials for Gerrit and git hosts:\n'
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002436 ' %s\n'
2437 ' %s\n'
Andrii Shyshkalov51acef92017-04-11 17:19:59 +02002438 ' Consider running the following command:\n'
2439 ' git cl creds-check\n'
Andrii Shyshkalov354e1d22017-06-09 19:31:33 +02002440 ' %s\n'
Andrii Shyshkalov8e4576f2017-05-10 15:46:53 +02002441 ' %s') %
Andrii Shyshkalov51acef92017-04-11 17:19:59 +02002442 (git_host, self._gerrit_host,
Andrii Shyshkalov354e1d22017-06-09 19:31:33 +02002443 ('Hint: delete creds for .googlesource.com' if all_gsrc else ''),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002444 cookie_auth.get_new_password_message(git_host)))
2445 if not force:
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002446 confirm_or_exit('If you know what you are doing', action='continue')
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002447 return
2448 else:
2449 missing = (
Anna Henningsen4e891442017-07-06 21:40:58 +02002450 ([] if gerrit_auth else [self._gerrit_host]) +
2451 ([] if git_auth else [git_host]))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002452 DieWithError('Credentials for the following hosts are required:\n'
2453 ' %s\n'
2454 'These are read from %s (or legacy %s)\n'
2455 '%s' % (
2456 '\n '.join(missing),
2457 cookie_auth.get_gitcookies_path(),
2458 cookie_auth.get_netrc_path(),
2459 cookie_auth.get_new_password_message(git_host)))
2460
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01002461 def EnsureCanUploadPatchset(self, force):
Andrii Shyshkalov3e631422017-02-16 17:46:44 +01002462 if not self.GetIssue():
2463 return
2464
2465 # Warm change details cache now to avoid RPCs later, reducing latency for
2466 # developers.
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01002467 self._GetChangeDetail(
2468 ['DETAILED_ACCOUNTS', 'CURRENT_REVISION', 'CURRENT_COMMIT'])
Andrii Shyshkalov3e631422017-02-16 17:46:44 +01002469
2470 status = self._GetChangeDetail()['status']
2471 if status in ('MERGED', 'ABANDONED'):
2472 DieWithError('Change %s has been %s, new uploads are not allowed' %
2473 (self.GetIssueURL(),
2474 'submitted' if status == 'MERGED' else 'abandoned'))
2475
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01002476 if gerrit_util.GceAuthenticator.is_gce():
2477 return
2478 cookies_user = gerrit_util.CookiesAuthenticator().get_auth_email(
2479 self._GetGerritHost())
2480 if self.GetIssueOwner() == cookies_user:
2481 return
2482 logging.debug('change %s owner is %s, cookies user is %s',
2483 self.GetIssue(), self.GetIssueOwner(), cookies_user)
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002484 # Maybe user has linked accounts or something like that,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01002485 # so ask what Gerrit thinks of this user.
2486 details = gerrit_util.GetAccountDetails(self._GetGerritHost(), 'self')
2487 if details['email'] == self.GetIssueOwner():
2488 return
2489 if not force:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002490 print('WARNING: Change %s is owned by %s, but you authenticate to Gerrit '
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01002491 'as %s.\n'
2492 'Uploading may fail due to lack of permissions.' %
2493 (self.GetIssue(), self.GetIssueOwner(), details['email']))
2494 confirm_or_exit(action='upload')
2495
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002496 def _PostUnsetIssueProperties(self):
2497 """Which branch-specific properties to erase when unsetting issue."""
tandrii5d48c322016-08-18 16:19:37 -07002498 return ['gerritsquashhash']
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002499
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00002500 def GetGerritObjForPresubmit(self):
2501 return presubmit_support.GerritAccessor(self._GetGerritHost())
2502
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00002503 def GetStatus(self):
tandrii@chromium.org013a2802016-03-29 09:52:33 +00002504 """Apply a rough heuristic to give a simple summary of an issue's review
2505 or CQ status, assuming adherence to a common workflow.
2506
2507 Returns None if no issue for this branch, or one of the following keywords:
Aaron Gable9ab38c62017-04-06 14:36:33 -07002508 * 'error' - error from review tool (including deleted issues)
2509 * 'unsent' - no reviewers added
2510 * 'waiting' - waiting for review
2511 * 'reply' - waiting for uploader to reply to review
2512 * 'lgtm' - Code-Review label has been set
2513 * 'commit' - in the commit queue
2514 * 'closed' - successfully submitted or abandoned
tandrii@chromium.org013a2802016-03-29 09:52:33 +00002515 """
2516 if not self.GetIssue():
2517 return None
2518
2519 try:
Aaron Gable9ab38c62017-04-06 14:36:33 -07002520 data = self._GetChangeDetail([
2521 'DETAILED_LABELS', 'CURRENT_REVISION', 'SUBMITTABLE'])
Aaron Gablea45ee112016-11-22 15:14:38 -08002522 except (httplib.HTTPException, GerritChangeNotExists):
tandrii@chromium.org013a2802016-03-29 09:52:33 +00002523 return 'error'
2524
tandrii@chromium.org5e1bf382016-05-17 08:43:24 +00002525 if data['status'] in ('ABANDONED', 'MERGED'):
tandrii@chromium.org013a2802016-03-29 09:52:33 +00002526 return 'closed'
2527
Aaron Gable9ab38c62017-04-06 14:36:33 -07002528 if data['labels'].get('Commit-Queue', {}).get('approved'):
2529 # The section will have an "approved" subsection if anyone has voted
2530 # the maximum value on the label.
2531 return 'commit'
tandrii@chromium.org013a2802016-03-29 09:52:33 +00002532
Aaron Gable9ab38c62017-04-06 14:36:33 -07002533 if data['labels'].get('Code-Review', {}).get('approved'):
2534 return 'lgtm'
tandrii@chromium.org013a2802016-03-29 09:52:33 +00002535
2536 if not data.get('reviewers', {}).get('REVIEWER', []):
2537 return 'unsent'
2538
Andrii Shyshkalov33e88a42017-01-27 14:45:30 +01002539 owner = data['owner'].get('_account_id')
Aaron Gable9ab38c62017-04-06 14:36:33 -07002540 messages = sorted(data.get('messages', []), key=lambda m: m.get('updated'))
2541 last_message_author = messages.pop().get('author', {})
2542 while last_message_author:
Andrii Shyshkalov33e88a42017-01-27 14:45:30 +01002543 if last_message_author.get('email') == COMMIT_BOT_EMAIL:
2544 # Ignore replies from CQ.
Aaron Gable9ab38c62017-04-06 14:36:33 -07002545 last_message_author = messages.pop().get('author', {})
Andrii Shyshkalov33e88a42017-01-27 14:45:30 +01002546 continue
Aaron Gable9ab38c62017-04-06 14:36:33 -07002547 if last_message_author.get('_account_id') == owner:
2548 # Most recent message was by owner.
2549 return 'waiting'
2550 else:
tandrii@chromium.org013a2802016-03-29 09:52:33 +00002551 # Some reply from non-owner.
2552 return 'reply'
Aaron Gable9ab38c62017-04-06 14:36:33 -07002553
2554 # Somehow there are no messages even though there are reviewers.
2555 return 'unsent'
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00002556
2557 def GetMostRecentPatchset(self):
tandrii@chromium.org013a2802016-03-29 09:52:33 +00002558 data = self._GetChangeDetail(['CURRENT_REVISION'])
Aaron Gablee8856ee2017-12-07 12:41:46 -08002559 patchset = data['revisions'][data['current_revision']]['_number']
2560 self.SetPatchset(patchset)
2561 return patchset
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00002562
Kenneth Russell61e2ed42017-02-15 11:47:13 -08002563 def FetchDescription(self, force=False):
2564 data = self._GetChangeDetail(['CURRENT_REVISION', 'CURRENT_COMMIT'],
2565 no_cache=force)
tandrii@chromium.org2d3da632016-04-25 19:23:27 +00002566 current_rev = data['current_revision']
Andrii Shyshkalov9c3a4642017-01-24 17:41:22 +01002567 return data['revisions'][current_rev]['commit']['message']
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00002568
dsansomee2d6fd92016-09-08 00:10:47 -07002569 def UpdateDescriptionRemote(self, description, force=False):
2570 if gerrit_util.HasPendingChangeEdit(self._GetGerritHost(), self.GetIssue()):
2571 if not force:
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002572 confirm_or_exit(
dsansomee2d6fd92016-09-08 00:10:47 -07002573 'The description cannot be modified while the issue has a pending '
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002574 'unpublished edit. Either publish the edit in the Gerrit web UI '
2575 'or delete it.\n\n', action='delete the unpublished edit')
dsansomee2d6fd92016-09-08 00:10:47 -07002576
2577 gerrit_util.DeletePendingChangeEdit(self._GetGerritHost(),
2578 self.GetIssue())
scottmg@chromium.org6d1266e2016-04-26 11:12:26 +00002579 gerrit_util.SetCommitMessage(self._GetGerritHost(), self.GetIssue(),
Andrii Shyshkalovea4fc832016-12-01 14:53:23 +01002580 description, notify='NONE')
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00002581
Aaron Gable636b13f2017-07-14 10:42:48 -07002582 def AddComment(self, message, publish=None):
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002583 gerrit_util.SetReview(self._GetGerritHost(), self.GetIssue(),
Aaron Gable636b13f2017-07-14 10:42:48 -07002584 msg=message, ready=publish)
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002585
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002586 def GetCommentsSummary(self, readable=True):
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002587 # DETAILED_ACCOUNTS is to get emails in accounts.
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002588 messages = self._GetChangeDetail(
2589 options=['MESSAGES', 'DETAILED_ACCOUNTS']).get('messages', [])
2590 file_comments = gerrit_util.GetChangeComments(
2591 self._GetGerritHost(), self.GetIssue())
2592
2593 # Build dictionary of file comments for easy access and sorting later.
2594 # {author+date: {path: {patchset: {line: url+message}}}}
2595 comments = collections.defaultdict(
2596 lambda: collections.defaultdict(lambda: collections.defaultdict(dict)))
2597 for path, line_comments in file_comments.iteritems():
2598 for comment in line_comments:
2599 if comment.get('tag', '').startswith('autogenerated'):
2600 continue
2601 key = (comment['author']['email'], comment['updated'])
2602 if comment.get('side', 'REVISION') == 'PARENT':
2603 patchset = 'Base'
2604 else:
2605 patchset = 'PS%d' % comment['patch_set']
2606 line = comment.get('line', 0)
2607 url = ('https://%s/c/%s/%s/%s#%s%s' %
2608 (self._GetGerritHost(), self.GetIssue(), comment['patch_set'], path,
2609 'b' if comment.get('side') == 'PARENT' else '',
2610 str(line) if line else ''))
2611 comments[key][path][patchset][line] = (url, comment['message'])
2612
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002613 summary = []
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002614 for msg in messages:
2615 # Don't bother showing autogenerated messages.
2616 if msg.get('tag') and msg.get('tag').startswith('autogenerated'):
2617 continue
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002618 # Gerrit spits out nanoseconds.
2619 assert len(msg['date'].split('.')[-1]) == 9
2620 date = datetime.datetime.strptime(msg['date'][:-3],
2621 '%Y-%m-%d %H:%M:%S.%f')
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002622 message = msg['message']
2623 key = (msg['author']['email'], msg['date'])
2624 if key in comments:
2625 message += '\n'
2626 for path, patchsets in sorted(comments.get(key, {}).items()):
2627 if readable:
2628 message += '\n%s' % path
2629 for patchset, lines in sorted(patchsets.items()):
2630 for line, (url, content) in sorted(lines.items()):
2631 if line:
2632 line_str = 'Line %d' % line
2633 path_str = '%s:%d:' % (path, line)
2634 else:
2635 line_str = 'File comment'
2636 path_str = '%s:0:' % path
2637 if readable:
2638 message += '\n %s, %s: %s' % (patchset, line_str, url)
2639 message += '\n %s\n' % content
2640 else:
2641 message += '\n%s ' % path_str
2642 message += '\n%s\n' % content
2643
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002644 summary.append(_CommentSummary(
2645 date=date,
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002646 message=message,
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002647 sender=msg['author']['email'],
2648 # These could be inferred from the text messages and correlated with
2649 # Code-Review label maximum, however this is not reliable.
2650 # Leaving as is until the need arises.
2651 approval=False,
2652 disapproval=False,
2653 ))
2654 return summary
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01002655
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00002656 def CloseIssue(self):
2657 gerrit_util.AbandonChange(self._GetGerritHost(), self.GetIssue(), msg='')
2658
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002659 def SubmitIssue(self, wait_for_merge=True):
2660 gerrit_util.SubmitChange(self._GetGerritHost(), self.GetIssue(),
2661 wait_for_merge=wait_for_merge)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00002662
Andrii Shyshkalovb7214602018-08-22 23:20:26 +00002663 def _GetChangeDetail(self, options=None, no_cache=False):
2664 """Returns details of associated Gerrit change and caching results.
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002665
2666 If fresh data is needed, set no_cache=True which will clear cache and
2667 thus new data will be fetched from Gerrit.
2668 """
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002669 options = options or []
Andrii Shyshkalovb7214602018-08-22 23:20:26 +00002670 issue = self.GetIssue()
tandriic2405f52016-10-10 08:13:15 -07002671 assert issue, 'issue is required to query Gerrit'
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002672
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01002673 # Optimization to avoid multiple RPCs:
2674 if (('CURRENT_REVISION' in options or 'ALL_REVISIONS' in options) and
2675 'CURRENT_COMMIT' not in options):
2676 options.append('CURRENT_COMMIT')
2677
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002678 # Normalize issue and options for consistent keys in cache.
Andrii Shyshkalovb7214602018-08-22 23:20:26 +00002679 issue = str(self.GetIssue())
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002680 options = [o.upper() for o in options]
2681
2682 # Check in cache first unless no_cache is True.
2683 if no_cache:
2684 self._detail_cache.pop(issue, None)
2685 else:
2686 options_set = frozenset(options)
2687 for cached_options_set, data in self._detail_cache.get(issue, []):
2688 # Assumption: data fetched before with extra options is suitable
2689 # for return for a smaller set of options.
2690 # For example, if we cached data for
2691 # options=[CURRENT_REVISION, DETAILED_FOOTERS]
2692 # and request is for options=[CURRENT_REVISION],
2693 # THEN we can return prior cached data.
2694 if options_set.issubset(cached_options_set):
2695 return data
2696
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01002697 try:
Andrii Shyshkalovb7214602018-08-22 23:20:26 +00002698 data = gerrit_util.GetChangeDetail(self._GetGerritHost(), issue, options)
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01002699 except gerrit_util.GerritError as e:
2700 if e.http_status == 404:
Aaron Gablea45ee112016-11-22 15:14:38 -08002701 raise GerritChangeNotExists(issue, self.GetCodereviewServer())
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01002702 raise
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002703
2704 self._detail_cache.setdefault(issue, []).append((frozenset(options), data))
tandriic2405f52016-10-10 08:13:15 -07002705 return data
tandrii@chromium.org013a2802016-03-29 09:52:33 +00002706
agable32978d92016-11-01 12:55:02 -07002707 def _GetChangeCommit(self, issue=None):
2708 issue = issue or self.GetIssue()
2709 assert issue, 'issue is required to query Gerrit'
Aaron Gable6f5a8d92017-04-18 14:49:05 -07002710 try:
2711 data = gerrit_util.GetChangeCommit(self._GetGerritHost(), str(issue))
2712 except gerrit_util.GerritError as e:
2713 if e.http_status == 404:
2714 raise GerritChangeNotExists(issue, self.GetCodereviewServer())
2715 raise
agable32978d92016-11-01 12:55:02 -07002716 return data
2717
Olivier Robin75ee7252018-04-13 10:02:56 +02002718 def CMDLand(self, force, bypass_hooks, verbose, parallel):
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002719 if git_common.is_dirty_git_tree('land'):
2720 return 1
tandriid60367b2016-06-22 05:25:12 -07002721 detail = self._GetChangeDetail(['CURRENT_REVISION', 'LABELS'])
2722 if u'Commit-Queue' in detail.get('labels', {}):
2723 if not force:
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002724 confirm_or_exit('\nIt seems this repository has a Commit Queue, '
2725 'which can test and land changes for you. '
2726 'Are you sure you wish to bypass it?\n',
2727 action='bypass CQ')
tandriid60367b2016-06-22 05:25:12 -07002728
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002729 differs = True
tandriic4344b52016-08-29 06:04:54 -07002730 last_upload = self._GitGetBranchConfigValue('gerritsquashhash')
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002731 # Note: git diff outputs nothing if there is no diff.
2732 if not last_upload or RunGit(['diff', last_upload]).strip():
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002733 print('WARNING: Some changes from local branch haven\'t been uploaded.')
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002734 else:
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002735 if detail['current_revision'] == last_upload:
2736 differs = False
2737 else:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002738 print('WARNING: Local branch contents differ from latest uploaded '
2739 'patchset.')
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002740 if differs:
2741 if not force:
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002742 confirm_or_exit(
2743 'Do you want to submit latest Gerrit patchset and bypass hooks?\n',
2744 action='submit')
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002745 print('WARNING: Bypassing hooks and submitting latest uploaded patchset.')
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002746 elif not bypass_hooks:
2747 hook_results = self.RunHook(
2748 committing=True,
2749 may_prompt=not force,
2750 verbose=verbose,
Olivier Robin75ee7252018-04-13 10:02:56 +02002751 change=self.GetChange(self.GetCommonAncestorWithUpstream(), None),
2752 parallel=parallel)
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002753 if not hook_results.should_continue():
2754 return 1
2755
2756 self.SubmitIssue(wait_for_merge=True)
2757 print('Issue %s has been submitted.' % self.GetIssueURL())
agable32978d92016-11-01 12:55:02 -07002758 links = self._GetChangeCommit().get('web_links', [])
2759 for link in links:
Aaron Gable02cdbb42016-12-13 16:24:25 -08002760 if link.get('name') == 'gitiles' and link.get('url'):
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002761 print('Landed as: %s' % link.get('url'))
agable32978d92016-11-01 12:55:02 -07002762 break
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002763 return 0
2764
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002765 def CMDPatchWithParsedIssue(self, parsed_issue_arg, reject, nocommit,
Aaron Gable62619a32017-06-16 08:22:09 -07002766 directory, force):
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002767 assert not reject
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002768 assert not directory
2769 assert parsed_issue_arg.valid
2770
2771 self._changelist.issue = parsed_issue_arg.issue
2772
2773 if parsed_issue_arg.hostname:
2774 self._gerrit_host = parsed_issue_arg.hostname
2775 self._gerrit_server = 'https://%s' % self._gerrit_host
2776
tandriic2405f52016-10-10 08:13:15 -07002777 try:
2778 detail = self._GetChangeDetail(['ALL_REVISIONS'])
Aaron Gablea45ee112016-11-22 15:14:38 -08002779 except GerritChangeNotExists as e:
tandriic2405f52016-10-10 08:13:15 -07002780 DieWithError(str(e))
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002781
2782 if not parsed_issue_arg.patchset:
2783 # Use current revision by default.
2784 revision_info = detail['revisions'][detail['current_revision']]
2785 patchset = int(revision_info['_number'])
2786 else:
2787 patchset = parsed_issue_arg.patchset
2788 for revision_info in detail['revisions'].itervalues():
2789 if int(revision_info['_number']) == parsed_issue_arg.patchset:
2790 break
2791 else:
Aaron Gablea45ee112016-11-22 15:14:38 -08002792 DieWithError('Couldn\'t find patchset %i in change %i' %
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002793 (parsed_issue_arg.patchset, self.GetIssue()))
2794
Aaron Gable697a91b2018-01-19 15:20:15 -08002795 remote_url = self._changelist.GetRemoteUrl()
2796 if remote_url.endswith('.git'):
2797 remote_url = remote_url[:-len('.git')]
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002798 fetch_info = revision_info['fetch']['http']
Aaron Gable697a91b2018-01-19 15:20:15 -08002799
2800 if remote_url != fetch_info['url']:
2801 DieWithError('Trying to patch a change from %s but this repo appears '
2802 'to be %s.' % (fetch_info['url'], remote_url))
2803
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002804 RunGit(['fetch', fetch_info['url'], fetch_info['ref']])
Aaron Gable9387b4f2017-06-08 10:50:03 -07002805
Aaron Gable62619a32017-06-16 08:22:09 -07002806 if force:
2807 RunGit(['reset', '--hard', 'FETCH_HEAD'])
2808 print('Checked out commit for change %i patchset %i locally' %
2809 (parsed_issue_arg.issue, patchset))
Stefan Zager2d5f0392017-10-10 15:17:53 -07002810 elif nocommit:
2811 RunGit(['cherry-pick', '--no-commit', 'FETCH_HEAD'])
2812 print('Patch applied to index.')
Aaron Gable62619a32017-06-16 08:22:09 -07002813 else:
Aaron Gable9387b4f2017-06-08 10:50:03 -07002814 RunGit(['cherry-pick', 'FETCH_HEAD'])
2815 print('Committed patch for change %i patchset %i locally.' %
Aaron Gable62619a32017-06-16 08:22:09 -07002816 (parsed_issue_arg.issue, patchset))
2817 print('Note: this created a local commit which does not have '
2818 'the same hash as the one uploaded for review. This will make '
2819 'uploading changes based on top of this branch difficult.\n'
2820 'If you want to do that, use "git cl patch --force" instead.')
2821
Stefan Zagerd08043c2017-10-12 12:07:02 -07002822 if self.GetBranch():
2823 self.SetIssue(parsed_issue_arg.issue)
2824 self.SetPatchset(patchset)
2825 fetched_hash = RunGit(['rev-parse', 'FETCH_HEAD']).strip()
2826 self._GitSetBranchConfigValue('last-upload-hash', fetched_hash)
2827 self._GitSetBranchConfigValue('gerritsquashhash', fetched_hash)
2828 else:
2829 print('WARNING: You are in detached HEAD state.\n'
2830 'The patch has been applied to your checkout, but you will not be '
2831 'able to upload a new patch set to the gerrit issue.\n'
2832 'Try using the \'-b\' option if you would like to work on a '
2833 'branch and/or upload a new patch set.')
2834
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002835 return 0
2836
2837 @staticmethod
2838 def ParseIssueURL(parsed_url):
2839 if not parsed_url.scheme or not parsed_url.scheme.startswith('http'):
2840 return None
Aaron Gable01b91062017-08-24 17:48:40 -07002841 # Gerrit's new UI is https://domain/c/project/+/<issue_number>[/[patchset]]
2842 # But old GWT UI is https://domain/#/c/project/+/<issue_number>[/[patchset]]
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002843 # Short urls like https://domain/<issue_number> can be used, but don't allow
2844 # specifying the patchset (you'd 404), but we allow that here.
2845 if parsed_url.path == '/':
2846 part = parsed_url.fragment
2847 else:
2848 part = parsed_url.path
Aaron Gable01b91062017-08-24 17:48:40 -07002849 match = re.match('(/c(/.*/\+)?)?/(\d+)(/(\d+)?/?)?$', part)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002850 if match:
2851 return _ParsedIssueNumberArgument(
Aaron Gable01b91062017-08-24 17:48:40 -07002852 issue=int(match.group(3)),
2853 patchset=int(match.group(5)) if match.group(5) else None,
Andrii Shyshkalov90f31922017-04-10 16:10:21 +02002854 hostname=parsed_url.netloc,
2855 codereview='gerrit')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002856 return None
2857
tandrii16e0b4e2016-06-07 10:34:28 -07002858 def _GerritCommitMsgHookCheck(self, offer_removal):
2859 hook = os.path.join(settings.GetRoot(), '.git', 'hooks', 'commit-msg')
2860 if not os.path.exists(hook):
2861 return
2862 # Crude attempt to distinguish Gerrit Codereview hook from potentially
2863 # custom developer made one.
2864 data = gclient_utils.FileRead(hook)
2865 if not('From Gerrit Code Review' in data and 'add_ChangeId()' in data):
2866 return
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002867 print('WARNING: You have Gerrit commit-msg hook installed.\n'
qyearsley12fa6ff2016-08-24 09:18:40 -07002868 'It is not necessary for uploading with git cl in squash mode, '
tandrii16e0b4e2016-06-07 10:34:28 -07002869 'and may interfere with it in subtle ways.\n'
2870 'We recommend you remove the commit-msg hook.')
2871 if offer_removal:
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002872 if ask_for_explicit_yes('Do you want to remove it now?'):
tandrii16e0b4e2016-06-07 10:34:28 -07002873 gclient_utils.rm_file_or_tree(hook)
2874 print('Gerrit commit-msg hook removed.')
2875 else:
2876 print('OK, will keep Gerrit commit-msg hook in place.')
2877
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002878 def CMDUploadChange(self, options, git_diff_args, custom_cl_base, change):
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002879 """Upload the current branch to Gerrit."""
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00002880 if options.squash and options.no_squash:
2881 DieWithError('Can only use one of --squash or --no-squash')
tandriia60502f2016-06-20 02:01:53 -07002882
2883 if not options.squash and not options.no_squash:
2884 # Load default for user, repo, squash=true, in this order.
2885 options.squash = settings.GetSquashGerritUploads()
2886 elif options.no_squash:
2887 options.squash = False
tandrii26f3e4e2016-06-10 08:37:04 -07002888
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002889 remote, remote_branch = self.GetRemoteBranch()
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01002890 branch = GetTargetRef(remote, remote_branch, options.target_branch)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002891
Aaron Gableb56ad332017-01-06 15:24:31 -08002892 # This may be None; default fallback value is determined in logic below.
2893 title = options.title
2894
Dominic Battre7d1c4842017-10-27 09:17:28 +02002895 # Extract bug number from branch name.
2896 bug = options.bug
2897 match = re.match(r'(?:bug|fix)[_-]?(\d+)', self.GetBranch())
2898 if not bug and match:
2899 bug = match.group(1)
2900
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002901 if options.squash:
tandrii16e0b4e2016-06-07 10:34:28 -07002902 self._GerritCommitMsgHookCheck(offer_removal=not options.force)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002903 if self.GetIssue():
2904 # Try to get the message from a previous upload.
2905 message = self.GetDescription()
2906 if not message:
2907 DieWithError(
Aaron Gablea45ee112016-11-22 15:14:38 -08002908 'failed to fetch description from current Gerrit change %d\n'
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002909 '%s' % (self.GetIssue(), self.GetIssueURL()))
Aaron Gableb56ad332017-01-06 15:24:31 -08002910 if not title:
Andrii Shyshkalov2d8a2072017-04-10 15:02:18 +02002911 if options.message:
Aaron Gable7303dcb2017-06-07 14:17:32 -07002912 # When uploading a subsequent patchset, -m|--message is taken
2913 # as the patchset title if --title was not provided.
2914 title = options.message.strip()
Andrii Shyshkalov2d8a2072017-04-10 15:02:18 +02002915 else:
2916 default_title = RunGit(
2917 ['show', '-s', '--format=%s', 'HEAD']).strip()
Aaron Gable7303dcb2017-06-07 14:17:32 -07002918 if options.force:
2919 title = default_title
2920 else:
2921 title = ask_for_data(
2922 'Title for patchset [%s]: ' % default_title) or default_title
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002923 change_id = self._GetChangeDetail()['change_id']
2924 while True:
2925 footer_change_ids = git_footers.get_footer_change_id(message)
2926 if footer_change_ids == [change_id]:
2927 break
2928 if not footer_change_ids:
2929 message = git_footers.add_footer_change_id(message, change_id)
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002930 print('WARNING: appended missing Change-Id to change description.')
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002931 continue
2932 # There is already a valid footer but with different or several ids.
2933 # Doing this automatically is non-trivial as we don't want to lose
2934 # existing other footers, yet we want to append just 1 desired
2935 # Change-Id. Thus, just create a new footer, but let user verify the
2936 # new description.
2937 message = '%s\n\nChange-Id: %s' % (message, change_id)
2938 print(
Aaron Gablea45ee112016-11-22 15:14:38 -08002939 'WARNING: change %s has Change-Id footer(s):\n'
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002940 ' %s\n'
Aaron Gablea45ee112016-11-22 15:14:38 -08002941 'but change has Change-Id %s, according to Gerrit.\n'
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002942 'Please, check the proposed correction to the description, '
2943 'and edit it if necessary but keep the "Change-Id: %s" footer\n'
2944 % (self.GetIssue(), '\n '.join(footer_change_ids), change_id,
2945 change_id))
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002946 confirm_or_exit(action='edit')
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002947 if not options.force:
2948 change_desc = ChangeDescription(message)
Dominic Battre7d1c4842017-10-27 09:17:28 +02002949 change_desc.prompt(bug=bug)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002950 message = change_desc.description
2951 if not message:
2952 DieWithError("Description is empty. Aborting...")
2953 # Continue the while loop.
2954 # Sanity check of this code - we should end up with proper message
2955 # footer.
2956 assert [change_id] == git_footers.get_footer_change_id(message)
2957 change_desc = ChangeDescription(message)
Aaron Gableb56ad332017-01-06 15:24:31 -08002958 else: # if not self.GetIssue()
2959 if options.message:
2960 message = options.message
2961 else:
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002962 message = CreateDescriptionFromLog(git_diff_args)
Aaron Gableb56ad332017-01-06 15:24:31 -08002963 if options.title:
2964 message = options.title + '\n\n' + message
2965 change_desc = ChangeDescription(message)
Andrii Shyshkalov8c90d032017-04-19 21:27:26 +02002966
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002967 if not options.force:
Dominic Battre7d1c4842017-10-27 09:17:28 +02002968 change_desc.prompt(bug=bug)
Aaron Gableb56ad332017-01-06 15:24:31 -08002969 # On first upload, patchset title is always this string, while
2970 # --title flag gets converted to first line of message.
2971 title = 'Initial upload'
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002972 if not change_desc.description:
2973 DieWithError("Description is empty. Aborting...")
Andrii Shyshkalov8c90d032017-04-19 21:27:26 +02002974 change_ids = git_footers.get_footer_change_id(change_desc.description)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002975 if len(change_ids) > 1:
2976 DieWithError('too many Change-Id footers, at most 1 allowed.')
2977 if not change_ids:
2978 # Generate the Change-Id automatically.
Andrii Shyshkalov8c90d032017-04-19 21:27:26 +02002979 change_desc.set_description(git_footers.add_footer_change_id(
2980 change_desc.description,
2981 GenerateGerritChangeId(change_desc.description)))
2982 change_ids = git_footers.get_footer_change_id(change_desc.description)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002983 assert len(change_ids) == 1
2984 change_id = change_ids[0]
2985
Robert Iannuccidb02dd02017-04-19 12:18:20 -07002986 if options.reviewers or options.tbrs or options.add_owners_to:
2987 change_desc.update_reviewers(options.reviewers, options.tbrs,
2988 options.add_owners_to, change)
2989
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002990 remote, upstream_branch = self.FetchUpstreamTuple(self.GetBranch())
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002991 parent = self._ComputeParent(remote, upstream_branch, custom_cl_base,
2992 options.force, change_desc)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002993 tree = RunGit(['rev-parse', 'HEAD:']).strip()
Aaron Gable9a03ae02017-11-03 11:31:07 -07002994 with tempfile.NamedTemporaryFile(delete=False) as desc_tempfile:
2995 desc_tempfile.write(change_desc.description)
2996 desc_tempfile.close()
2997 ref_to_push = RunGit(['commit-tree', tree, '-p', parent,
2998 '-F', desc_tempfile.name]).strip()
2999 os.remove(desc_tempfile.name)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00003000 else:
3001 change_desc = ChangeDescription(
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02003002 options.message or CreateDescriptionFromLog(git_diff_args))
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00003003 if not change_desc.description:
3004 DieWithError("Description is empty. Aborting...")
3005
3006 if not git_footers.get_footer_change_id(change_desc.description):
3007 DownloadGerritHook(False)
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02003008 change_desc.set_description(
3009 self._AddChangeIdToCommitMessage(options, git_diff_args))
Robert Iannuccidb02dd02017-04-19 12:18:20 -07003010 if options.reviewers or options.tbrs or options.add_owners_to:
3011 change_desc.update_reviewers(options.reviewers, options.tbrs,
3012 options.add_owners_to, change)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00003013 ref_to_push = 'HEAD'
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02003014 # For no-squash mode, we assume the remote called "origin" is the one we
3015 # want. It is not worthwhile to support different workflows for
3016 # no-squash mode.
3017 parent = 'origin/%s' % branch
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00003018 change_id = git_footers.get_footer_change_id(change_desc.description)[0]
3019
3020 assert change_desc
3021 commits = RunGitSilent(['rev-list', '%s..%s' % (parent,
3022 ref_to_push)]).splitlines()
3023 if len(commits) > 1:
3024 print('WARNING: This will upload %d commits. Run the following command '
3025 'to see which commits will be uploaded: ' % len(commits))
3026 print('git log %s..%s' % (parent, ref_to_push))
3027 print('You can also use `git squash-branch` to squash these into a '
3028 'single commit.')
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01003029 confirm_or_exit(action='upload')
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00003030
Aaron Gable6dadfbf2017-05-09 14:27:58 -07003031 if options.reviewers or options.tbrs or options.add_owners_to:
3032 change_desc.update_reviewers(options.reviewers, options.tbrs,
3033 options.add_owners_to, change)
3034
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00003035 # Extra options that can be specified at push time. Doc:
3036 # https://gerrit-review.googlesource.com/Documentation/user-upload.html
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00003037 refspec_opts = []
Andrii Shyshkalov2d8a2072017-04-10 15:02:18 +02003038
Aaron Gable844cf292017-06-28 11:32:59 -07003039 # By default, new changes are started in WIP mode, and subsequent patchsets
3040 # don't send email. At any time, passing --send-mail will mark the change
3041 # ready and send email for that particular patch.
Aaron Gableafd52772017-06-27 16:40:10 -07003042 if options.send_mail:
3043 refspec_opts.append('ready')
Aaron Gable844cf292017-06-28 11:32:59 -07003044 refspec_opts.append('notify=ALL')
Jamie Madill276da0b2018-04-27 14:41:20 -04003045 elif not self.GetIssue() and options.squash:
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08003046 refspec_opts.append('wip')
Aaron Gableafd52772017-06-27 16:40:10 -07003047 else:
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08003048 refspec_opts.append('notify=NONE')
Aaron Gable70f4e242017-06-26 10:45:59 -07003049
Andrii Shyshkalov2d8a2072017-04-10 15:02:18 +02003050 # TODO(tandrii): options.message should be posted as a comment
Aaron Gablee5adf612017-07-14 10:43:58 -07003051 # if --send-mail is set on non-initial upload as Rietveld used to do it.
Andrii Shyshkalov2d8a2072017-04-10 15:02:18 +02003052
Aaron Gable9b713dd2016-12-14 16:04:21 -08003053 if title:
Nick Carter8692b182017-11-06 16:30:38 -08003054 # Punctuation and whitespace in |title| must be percent-encoded.
3055 refspec_opts.append('m=' + gerrit_util.PercentEncodeForGitRef(title))
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00003056
agablec6787972016-09-09 16:13:34 -07003057 if options.private:
Aaron Gableb02daf02017-05-23 11:53:46 -07003058 refspec_opts.append('private')
agablec6787972016-09-09 16:13:34 -07003059
rmistry9eadede2016-09-19 11:22:43 -07003060 if options.topic:
3061 # Documentation on Gerrit topics is here:
3062 # https://gerrit-review.googlesource.com/Documentation/user-upload.html#topic
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00003063 refspec_opts.append('topic=%s' % options.topic)
rmistry9eadede2016-09-19 11:22:43 -07003064
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08003065 # Gerrit sorts hashtags, so order is not important.
Nodir Turakulov23b82142017-11-16 11:04:25 -08003066 hashtags = {change_desc.sanitize_hash_tag(t) for t in options.hashtags}
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08003067 if not self.GetIssue():
Nodir Turakulov23b82142017-11-16 11:04:25 -08003068 hashtags.update(change_desc.get_hash_tags())
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08003069 refspec_opts += ['hashtag=%s' % t for t in sorted(hashtags)]
3070
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00003071 refspec_suffix = ''
3072 if refspec_opts:
3073 refspec_suffix = '%' + ','.join(refspec_opts)
3074 assert ' ' not in refspec_suffix, (
3075 'spaces not allowed in refspec: "%s"' % refspec_suffix)
3076 refspec = '%s:refs/for/%s%s' % (ref_to_push, branch, refspec_suffix)
3077
Andrii Shyshkalov7d518832016-12-15 20:48:21 +01003078 try:
3079 push_stdout = gclient_utils.CheckCallAndFilter(
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00003080 ['git', 'push', self.GetRemoteUrl(), refspec],
3081 print_stdout=True,
Andrii Shyshkalov7d518832016-12-15 20:48:21 +01003082 # Flush after every line: useful for seeing progress when running as
3083 # recipe.
3084 filter_fn=lambda _: sys.stdout.flush())
3085 except subprocess2.CalledProcessError:
3086 DieWithError('Failed to create a change. Please examine output above '
Andrii Shyshkalov9d932212017-04-10 14:28:23 +02003087 'for the reason of the failure.\n'
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003088 'Hint: run command below to diagnose common Git/Gerrit '
Andrii Shyshkalov9d932212017-04-10 14:28:23 +02003089 'credential problems:\n'
3090 ' git cl creds-check\n',
3091 change_desc)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00003092
3093 if options.squash:
Aaron Gable289b4312017-09-13 14:06:16 -07003094 regex = re.compile(r'remote:\s+https?://[\w\-\.\+\/#]*/(\d+)\s.*')
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00003095 change_numbers = [m.group(1)
3096 for m in map(regex.match, push_stdout.splitlines())
3097 if m]
3098 if len(change_numbers) != 1:
3099 DieWithError(
3100 ('Created|Updated %d issues on Gerrit, but only 1 expected.\n'
Christopher Lamf732cd52017-01-24 12:40:11 +11003101 'Change-Id: %s') % (len(change_numbers), change_id), change_desc)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00003102 self.SetIssue(change_numbers[0])
tandrii5d48c322016-08-18 16:19:37 -07003103 self._GitSetBranchConfigValue('gerritsquashhash', ref_to_push)
tandrii88189772016-09-29 04:29:57 -07003104
Aaron Gable6dadfbf2017-05-09 14:27:58 -07003105 reviewers = sorted(change_desc.get_reviewers())
3106
tandrii88189772016-09-29 04:29:57 -07003107 # Add cc's from the CC_LIST and --cc flag (if any).
Aaron Gabled1052492017-05-15 15:05:34 -07003108 if not options.private:
3109 cc = self.GetCCList().split(',')
3110 else:
3111 cc = []
tandrii88189772016-09-29 04:29:57 -07003112 if options.cc:
3113 cc.extend(options.cc)
3114 cc = filter(None, [email.strip() for email in cc])
bradnelsond975b302016-10-23 12:20:23 -07003115 if change_desc.get_cced():
3116 cc.extend(change_desc.get_cced())
Aaron Gable6dadfbf2017-05-09 14:27:58 -07003117
3118 gerrit_util.AddReviewers(
3119 self._GetGerritHost(), self.GetIssue(), reviewers, cc,
3120 notify=bool(options.send_mail))
3121
Aaron Gablefd238082017-06-07 13:42:34 -07003122 if change_desc.get_reviewers(tbr_only=True):
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +09003123 labels = self._GetChangeDetail(['LABELS']).get('labels', {})
3124 score = 1
3125 if 'Code-Review' in labels and 'values' in labels['Code-Review']:
3126 score = max([int(x) for x in labels['Code-Review']['values'].keys()])
3127 print('Adding self-LGTM (Code-Review +%d) because of TBRs.' % score)
Aaron Gablefd238082017-06-07 13:42:34 -07003128 gerrit_util.SetReview(
3129 self._GetGerritHost(), self.GetIssue(),
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +09003130 msg='Self-approving for TBR',
3131 labels={'Code-Review': score})
Aaron Gablefd238082017-06-07 13:42:34 -07003132
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00003133 return 0
3134
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02003135 def _ComputeParent(self, remote, upstream_branch, custom_cl_base, force,
3136 change_desc):
3137 """Computes parent of the generated commit to be uploaded to Gerrit.
3138
3139 Returns revision or a ref name.
3140 """
3141 if custom_cl_base:
3142 # Try to avoid creating additional unintended CLs when uploading, unless
3143 # user wants to take this risk.
3144 local_ref_of_target_remote = self.GetRemoteBranch()[1]
3145 code, _ = RunGitWithCode(['merge-base', '--is-ancestor', custom_cl_base,
3146 local_ref_of_target_remote])
3147 if code == 1:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003148 print('\nWARNING: Manually specified base of this CL `%s` '
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02003149 'doesn\'t seem to belong to target remote branch `%s`.\n\n'
3150 'If you proceed with upload, more than 1 CL may be created by '
3151 'Gerrit as a result, in turn confusing or crashing git cl.\n\n'
3152 'If you are certain that specified base `%s` has already been '
3153 'uploaded to Gerrit as another CL, you may proceed.\n' %
3154 (custom_cl_base, local_ref_of_target_remote, custom_cl_base))
3155 if not force:
3156 confirm_or_exit(
3157 'Do you take responsibility for cleaning up potential mess '
3158 'resulting from proceeding with upload?',
3159 action='upload')
3160 return custom_cl_base
3161
Aaron Gablef97e33d2017-03-30 15:44:27 -07003162 if remote != '.':
3163 return self.GetCommonAncestorWithUpstream()
3164
3165 # If our upstream branch is local, we base our squashed commit on its
3166 # squashed version.
3167 upstream_branch_name = scm.GIT.ShortBranchName(upstream_branch)
3168
Aaron Gablef97e33d2017-03-30 15:44:27 -07003169 if upstream_branch_name == 'master':
Aaron Gable0bbd1c22017-05-08 14:37:08 -07003170 return self.GetCommonAncestorWithUpstream()
Aaron Gablef97e33d2017-03-30 15:44:27 -07003171
3172 # Check the squashed hash of the parent.
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02003173 # TODO(tandrii): consider checking parent change in Gerrit and using its
3174 # hash if tree hash of latest parent revision (patchset) in Gerrit matches
3175 # the tree hash of the parent branch. The upside is less likely bogus
3176 # requests to reupload parent change just because it's uploadhash is
3177 # missing, yet the downside likely exists, too (albeit unknown to me yet).
Aaron Gablef97e33d2017-03-30 15:44:27 -07003178 parent = RunGit(['config',
3179 'branch.%s.gerritsquashhash' % upstream_branch_name],
3180 error_ok=True).strip()
3181 # Verify that the upstream branch has been uploaded too, otherwise
3182 # Gerrit will create additional CLs when uploading.
3183 if not parent or (RunGitSilent(['rev-parse', upstream_branch + ':']) !=
3184 RunGitSilent(['rev-parse', parent + ':'])):
3185 DieWithError(
3186 '\nUpload upstream branch %s first.\n'
3187 'It is likely that this branch has been rebased since its last '
3188 'upload, so you just need to upload it again.\n'
3189 '(If you uploaded it with --no-squash, then branch dependencies '
3190 'are not supported, and you should reupload with --squash.)'
3191 % upstream_branch_name,
3192 change_desc)
3193 return parent
3194
tandrii@chromium.org8930b3d2016-04-13 14:47:02 +00003195 def _AddChangeIdToCommitMessage(self, options, args):
3196 """Re-commits using the current message, assumes the commit hook is in
3197 place.
3198 """
3199 log_desc = options.message or CreateDescriptionFromLog(args)
3200 git_command = ['commit', '--amend', '-m', log_desc]
3201 RunGit(git_command)
3202 new_log_desc = CreateDescriptionFromLog(args)
3203 if git_footers.get_footer_change_id(new_log_desc):
vapiera7fbd5a2016-06-16 09:17:49 -07003204 print('git-cl: Added Change-Id to commit message.')
tandrii@chromium.org8930b3d2016-04-13 14:47:02 +00003205 return new_log_desc
3206 else:
tandrii@chromium.orgb067ec52016-05-31 15:24:44 +00003207 DieWithError('ERROR: Gerrit commit-msg hook not installed.')
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00003208
Ravi Mistry31e7d562018-04-02 12:53:57 -04003209 def SetLabels(self, enable_auto_submit, use_commit_queue, cq_dry_run):
3210 """Sets labels on the change based on the provided flags."""
3211 labels = {}
3212 notify = None;
3213 if enable_auto_submit:
3214 labels['Auto-Submit'] = 1
3215 if use_commit_queue:
3216 labels['Commit-Queue'] = 2
3217 elif cq_dry_run:
3218 labels['Commit-Queue'] = 1
3219 notify = False
3220 if labels:
3221 gerrit_util.SetReview(self._GetGerritHost(), self.GetIssue(),
3222 labels=labels, notify=notify)
3223
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00003224 def SetCQState(self, new_state):
3225 """Sets the Commit-Queue label assuming canonical CQ config for Gerrit."""
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00003226 vote_map = {
3227 _CQState.NONE: 0,
3228 _CQState.DRY_RUN: 1,
Andrii Shyshkalov18975322017-01-25 16:44:13 +01003229 _CQState.COMMIT: 2,
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00003230 }
Aaron Gablefc62f762017-07-17 11:12:07 -07003231 labels = {'Commit-Queue': vote_map[new_state]}
3232 notify = False if new_state == _CQState.DRY_RUN else None
3233 gerrit_util.SetReview(self._GetGerritHost(), self.GetIssue(),
3234 labels=labels, notify=notify)
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00003235
tandriie113dfd2016-10-11 10:20:12 -07003236 def CannotTriggerTryJobReason(self):
tandrii8c5a3532016-11-04 07:52:02 -07003237 try:
3238 data = self._GetChangeDetail()
Aaron Gablea45ee112016-11-22 15:14:38 -08003239 except GerritChangeNotExists:
3240 return 'Gerrit doesn\'t know about your change %s' % self.GetIssue()
tandrii8c5a3532016-11-04 07:52:02 -07003241
3242 if data['status'] in ('ABANDONED', 'MERGED'):
3243 return 'CL %s is closed' % self.GetIssue()
3244
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003245 def GetTryJobProperties(self, patchset=None):
3246 """Returns dictionary of properties to launch try job."""
tandrii8c5a3532016-11-04 07:52:02 -07003247 data = self._GetChangeDetail(['ALL_REVISIONS'])
3248 patchset = int(patchset or self.GetPatchset())
3249 assert patchset
3250 revision_data = None # Pylint wants it to be defined.
3251 for revision_data in data['revisions'].itervalues():
3252 if int(revision_data['_number']) == patchset:
3253 break
3254 else:
Aaron Gablea45ee112016-11-22 15:14:38 -08003255 raise Exception('Patchset %d is not known in Gerrit change %d' %
tandrii8c5a3532016-11-04 07:52:02 -07003256 (patchset, self.GetIssue()))
3257 return {
3258 'patch_issue': self.GetIssue(),
3259 'patch_set': patchset or self.GetPatchset(),
3260 'patch_project': data['project'],
3261 'patch_storage': 'gerrit',
3262 'patch_ref': revision_data['fetch']['http']['ref'],
3263 'patch_repository_url': revision_data['fetch']['http']['url'],
3264 'patch_gerrit_url': self.GetCodereviewServer(),
3265 }
tandriie113dfd2016-10-11 10:20:12 -07003266
tandriide281ae2016-10-12 06:02:30 -07003267 def GetIssueOwner(self):
tandrii8c5a3532016-11-04 07:52:02 -07003268 return self._GetChangeDetail(['DETAILED_ACCOUNTS'])['owner']['email']
tandriide281ae2016-10-12 06:02:30 -07003269
Edward Lemur707d70b2018-02-07 00:50:14 +01003270 def GetReviewers(self):
3271 details = self._GetChangeDetail(['DETAILED_ACCOUNTS'])
3272 return [reviewer['email'] for reviewer in details['reviewers']['REVIEWER']]
3273
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00003274
3275_CODEREVIEW_IMPLEMENTATIONS = {
3276 'rietveld': _RietveldChangelistImpl,
3277 'gerrit': _GerritChangelistImpl,
3278}
3279
tandrii@chromium.org013a2802016-03-29 09:52:33 +00003280
iannuccie53c9352016-08-17 14:40:40 -07003281def _add_codereview_issue_select_options(parser, extra=""):
3282 _add_codereview_select_options(parser)
3283
3284 text = ('Operate on this issue number instead of the current branch\'s '
3285 'implicit issue.')
3286 if extra:
3287 text += ' '+extra
3288 parser.add_option('-i', '--issue', type=int, help=text)
3289
3290
3291def _process_codereview_issue_select_options(parser, options):
3292 _process_codereview_select_options(parser, options)
3293 if options.issue is not None and not options.forced_codereview:
3294 parser.error('--issue must be specified with either --rietveld or --gerrit')
3295
3296
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00003297def _add_codereview_select_options(parser):
3298 """Appends --gerrit and --rietveld options to force specific codereview."""
3299 parser.codereview_group = optparse.OptionGroup(
3300 parser, 'EXPERIMENTAL! Codereview override options')
3301 parser.add_option_group(parser.codereview_group)
3302 parser.codereview_group.add_option(
3303 '--gerrit', action='store_true',
3304 help='Force the use of Gerrit for codereview')
3305 parser.codereview_group.add_option(
3306 '--rietveld', action='store_true',
3307 help='Force the use of Rietveld for codereview')
3308
3309
3310def _process_codereview_select_options(parser, options):
3311 if options.gerrit and options.rietveld:
3312 parser.error('Options --gerrit and --rietveld are mutually exclusive')
3313 options.forced_codereview = None
3314 if options.gerrit:
3315 options.forced_codereview = 'gerrit'
3316 elif options.rietveld:
3317 options.forced_codereview = 'rietveld'
3318
3319
tandriif9aefb72016-07-01 09:06:51 -07003320def _get_bug_line_values(default_project, bugs):
3321 """Given default_project and comma separated list of bugs, yields bug line
3322 values.
3323
3324 Each bug can be either:
3325 * a number, which is combined with default_project
3326 * string, which is left as is.
3327
3328 This function may produce more than one line, because bugdroid expects one
3329 project per line.
3330
3331 >>> list(_get_bug_line_values('v8', '123,chromium:789'))
3332 ['v8:123', 'chromium:789']
3333 """
3334 default_bugs = []
3335 others = []
3336 for bug in bugs.split(','):
3337 bug = bug.strip()
3338 if bug:
3339 try:
3340 default_bugs.append(int(bug))
3341 except ValueError:
3342 others.append(bug)
3343
3344 if default_bugs:
3345 default_bugs = ','.join(map(str, default_bugs))
3346 if default_project:
3347 yield '%s:%s' % (default_project, default_bugs)
3348 else:
3349 yield default_bugs
3350 for other in sorted(others):
3351 # Don't bother finding common prefixes, CLs with >2 bugs are very very rare.
3352 yield other
3353
3354
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00003355class ChangeDescription(object):
3356 """Contains a parsed form of the change description."""
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00003357 R_LINE = r'^[ \t]*(TBR|R)[ \t]*=[ \t]*(.*?)[ \t]*$'
bradnelsond975b302016-10-23 12:20:23 -07003358 CC_LINE = r'^[ \t]*(CC)[ \t]*=[ \t]*(.*?)[ \t]*$'
Aaron Gable3a16ed12017-03-23 10:51:55 -07003359 BUG_LINE = r'^[ \t]*(?:(BUG)[ \t]*=|Bug:)[ \t]*(.*?)[ \t]*$'
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01003360 CHERRY_PICK_LINE = r'^\(cherry picked from commit [a-fA-F0-9]{40}\)$'
Nodir Turakulov23b82142017-11-16 11:04:25 -08003361 STRIP_HASH_TAG_PREFIX = r'^(\s*(revert|reland)( "|:)?\s*)*'
3362 BRACKET_HASH_TAG = r'\s*\[([^\[\]]+)\]'
3363 COLON_SEPARATED_HASH_TAG = r'^([a-zA-Z0-9_\- ]+):'
3364 BAD_HASH_TAG_CHUNK = r'[^a-zA-Z0-9]+'
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00003365
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003366 def __init__(self, description):
agable@chromium.org42c20792013-09-12 17:34:49 +00003367 self._description_lines = (description or '').strip().splitlines()
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003368
agable@chromium.org42c20792013-09-12 17:34:49 +00003369 @property # www.logilab.org/ticket/89786
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -08003370 def description(self): # pylint: disable=method-hidden
agable@chromium.org42c20792013-09-12 17:34:49 +00003371 return '\n'.join(self._description_lines)
3372
3373 def set_description(self, desc):
3374 if isinstance(desc, basestring):
3375 lines = desc.splitlines()
3376 else:
3377 lines = [line.rstrip() for line in desc]
3378 while lines and not lines[0]:
3379 lines.pop(0)
3380 while lines and not lines[-1]:
3381 lines.pop(-1)
3382 self._description_lines = lines
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003383
Robert Iannucci6c98dc62017-04-18 11:38:00 -07003384 def update_reviewers(self, reviewers, tbrs, add_owners_to=None, change=None):
3385 """Rewrites the R=/TBR= line(s) as a single line each.
3386
3387 Args:
3388 reviewers (list(str)) - list of additional emails to use for reviewers.
3389 tbrs (list(str)) - list of additional emails to use for TBRs.
3390 add_owners_to (None|'R'|'TBR') - Pass to do an OWNERS lookup for files in
3391 the change that are missing OWNER coverage. If this is not None, you
3392 must also pass a value for `change`.
3393 change (Change) - The Change that should be used for OWNERS lookups.
3394 """
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003395 assert isinstance(reviewers, list), reviewers
Robert Iannucci6c98dc62017-04-18 11:38:00 -07003396 assert isinstance(tbrs, list), tbrs
3397
Robert Iannuccif2708bd2017-04-17 15:49:02 -07003398 assert add_owners_to in (None, 'TBR', 'R'), add_owners_to
Robert Iannuccia28592e2017-04-18 13:14:49 -07003399 assert not add_owners_to or change, add_owners_to
Robert Iannucci6c98dc62017-04-18 11:38:00 -07003400
3401 if not reviewers and not tbrs and not add_owners_to:
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003402 return
Robert Iannucci6c98dc62017-04-18 11:38:00 -07003403
3404 reviewers = set(reviewers)
3405 tbrs = set(tbrs)
3406 LOOKUP = {
3407 'TBR': tbrs,
3408 'R': reviewers,
3409 }
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003410
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003411 # Get the set of R= and TBR= lines and remove them from the description.
agable@chromium.org42c20792013-09-12 17:34:49 +00003412 regexp = re.compile(self.R_LINE)
3413 matches = [regexp.match(line) for line in self._description_lines]
3414 new_desc = [l for i, l in enumerate(self._description_lines)
3415 if not matches[i]]
3416 self.set_description(new_desc)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003417
agable@chromium.org42c20792013-09-12 17:34:49 +00003418 # Construct new unified R= and TBR= lines.
Robert Iannucci6c98dc62017-04-18 11:38:00 -07003419
3420 # First, update tbrs/reviewers with names from the R=/TBR= lines (if any).
agable@chromium.org42c20792013-09-12 17:34:49 +00003421 for match in matches:
3422 if not match:
3423 continue
Robert Iannucci6c98dc62017-04-18 11:38:00 -07003424 LOOKUP[match.group(1)].update(cleanup_list([match.group(2).strip()]))
3425
3426 # Next, maybe fill in OWNERS coverage gaps to either tbrs/reviewers.
Robert Iannuccif2708bd2017-04-17 15:49:02 -07003427 if add_owners_to:
piman@chromium.org336f9122014-09-04 02:16:55 +00003428 owners_db = owners.Database(change.RepositoryRoot(),
Jochen Eisinger72606f82017-04-04 10:44:18 +02003429 fopen=file, os_path=os.path)
piman@chromium.org336f9122014-09-04 02:16:55 +00003430 missing_files = owners_db.files_not_covered_by(change.LocalPaths(),
Robert Iannucci100aa212017-04-18 17:28:26 -07003431 (tbrs | reviewers))
Robert Iannucci6c98dc62017-04-18 11:38:00 -07003432 LOOKUP[add_owners_to].update(
3433 owners_db.reviewers_for(missing_files, change.author_email))
Robert Iannuccif2708bd2017-04-17 15:49:02 -07003434
Robert Iannucci6c98dc62017-04-18 11:38:00 -07003435 # If any folks ended up in both groups, remove them from tbrs.
3436 tbrs -= reviewers
Robert Iannuccif2708bd2017-04-17 15:49:02 -07003437
Robert Iannucci6c98dc62017-04-18 11:38:00 -07003438 new_r_line = 'R=' + ', '.join(sorted(reviewers)) if reviewers else None
3439 new_tbr_line = 'TBR=' + ', '.join(sorted(tbrs)) if tbrs else None
agable@chromium.org42c20792013-09-12 17:34:49 +00003440
3441 # Put the new lines in the description where the old first R= line was.
3442 line_loc = next((i for i, match in enumerate(matches) if match), -1)
3443 if 0 <= line_loc < len(self._description_lines):
3444 if new_tbr_line:
3445 self._description_lines.insert(line_loc, new_tbr_line)
3446 if new_r_line:
3447 self._description_lines.insert(line_loc, new_r_line)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003448 else:
agable@chromium.org42c20792013-09-12 17:34:49 +00003449 if new_r_line:
3450 self.append_footer(new_r_line)
3451 if new_tbr_line:
3452 self.append_footer(new_tbr_line)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003453
Aaron Gable3a16ed12017-03-23 10:51:55 -07003454 def prompt(self, bug=None, git_footer=True):
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003455 """Asks the user to update the description."""
agable@chromium.org42c20792013-09-12 17:34:49 +00003456 self.set_description([
3457 '# Enter a description of the change.',
3458 '# This will be displayed on the codereview site.',
3459 '# The first line will also be used as the subject of the review.',
alancutter@chromium.orgbd1073e2013-06-01 00:34:38 +00003460 '#--------------------This line is 72 characters long'
agable@chromium.org42c20792013-09-12 17:34:49 +00003461 '--------------------',
3462 ] + self._description_lines)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003463
agable@chromium.org42c20792013-09-12 17:34:49 +00003464 regexp = re.compile(self.BUG_LINE)
3465 if not any((regexp.match(line) for line in self._description_lines)):
tandriif9aefb72016-07-01 09:06:51 -07003466 prefix = settings.GetBugPrefix()
3467 values = list(_get_bug_line_values(prefix, bug or '')) or [prefix]
Aaron Gable3a16ed12017-03-23 10:51:55 -07003468 if git_footer:
3469 self.append_footer('Bug: %s' % ', '.join(values))
3470 else:
3471 for value in values:
3472 self.append_footer('BUG=%s' % value)
tandriif9aefb72016-07-01 09:06:51 -07003473
agable@chromium.org42c20792013-09-12 17:34:49 +00003474 content = gclient_utils.RunEditor(self.description, True,
jbroman@chromium.org615a2622013-05-03 13:20:14 +00003475 git_editor=settings.GetGitEditor())
maruel@chromium.org0e0436a2011-10-25 13:32:41 +00003476 if not content:
3477 DieWithError('Running editor failed')
agable@chromium.org42c20792013-09-12 17:34:49 +00003478 lines = content.splitlines()
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003479
Bruce Dawson2377b012018-01-11 16:46:49 -08003480 # Strip off comments and default inserted "Bug:" line.
3481 clean_lines = [line.rstrip() for line in lines if not
3482 (line.startswith('#') or line.rstrip() == "Bug:")]
agable@chromium.org42c20792013-09-12 17:34:49 +00003483 if not clean_lines:
maruel@chromium.org0e0436a2011-10-25 13:32:41 +00003484 DieWithError('No CL description, aborting')
agable@chromium.org42c20792013-09-12 17:34:49 +00003485 self.set_description(clean_lines)
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00003486
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003487 def append_footer(self, line):
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00003488 """Adds a footer line to the description.
3489
3490 Differentiates legacy "KEY=xxx" footers (used to be called tags) and
3491 Gerrit's footers in the form of "Footer-Key: footer any value" and ensures
3492 that Gerrit footers are always at the end.
3493 """
3494 parsed_footer_line = git_footers.parse_footer(line)
3495 if parsed_footer_line:
3496 # Line is a gerrit footer in the form: Footer-Key: any value.
3497 # Thus, must be appended observing Gerrit footer rules.
3498 self.set_description(
3499 git_footers.add_footer(self.description,
3500 key=parsed_footer_line[0],
3501 value=parsed_footer_line[1]))
3502 return
3503
3504 if not self._description_lines:
3505 self._description_lines.append(line)
3506 return
3507
3508 top_lines, gerrit_footers, _ = git_footers.split_footers(self.description)
3509 if gerrit_footers:
3510 # git_footers.split_footers ensures that there is an empty line before
3511 # actual (gerrit) footers, if any. We have to keep it that way.
3512 assert top_lines and top_lines[-1] == ''
3513 top_lines, separator = top_lines[:-1], top_lines[-1:]
3514 else:
3515 separator = [] # No need for separator if there are no gerrit_footers.
3516
3517 prev_line = top_lines[-1] if top_lines else ''
3518 if (not presubmit_support.Change.TAG_LINE_RE.match(prev_line) or
3519 not presubmit_support.Change.TAG_LINE_RE.match(line)):
3520 top_lines.append('')
3521 top_lines.append(line)
3522 self._description_lines = top_lines + separator + gerrit_footers
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00003523
tandrii99a72f22016-08-17 14:33:24 -07003524 def get_reviewers(self, tbr_only=False):
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003525 """Retrieves the list of reviewers."""
agable@chromium.org42c20792013-09-12 17:34:49 +00003526 matches = [re.match(self.R_LINE, line) for line in self._description_lines]
tandrii99a72f22016-08-17 14:33:24 -07003527 reviewers = [match.group(2).strip()
3528 for match in matches
3529 if match and (not tbr_only or match.group(1).upper() == 'TBR')]
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003530 return cleanup_list(reviewers)
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00003531
bradnelsond975b302016-10-23 12:20:23 -07003532 def get_cced(self):
3533 """Retrieves the list of reviewers."""
3534 matches = [re.match(self.CC_LINE, line) for line in self._description_lines]
3535 cced = [match.group(2).strip() for match in matches if match]
3536 return cleanup_list(cced)
3537
Nodir Turakulov23b82142017-11-16 11:04:25 -08003538 def get_hash_tags(self):
3539 """Extracts and sanitizes a list of Gerrit hashtags."""
3540 subject = (self._description_lines or ('',))[0]
3541 subject = re.sub(
3542 self.STRIP_HASH_TAG_PREFIX, '', subject, flags=re.IGNORECASE)
3543
3544 tags = []
3545 start = 0
3546 bracket_exp = re.compile(self.BRACKET_HASH_TAG)
3547 while True:
3548 m = bracket_exp.match(subject, start)
3549 if not m:
3550 break
3551 tags.append(self.sanitize_hash_tag(m.group(1)))
3552 start = m.end()
3553
3554 if not tags:
3555 # Try "Tag: " prefix.
3556 m = re.match(self.COLON_SEPARATED_HASH_TAG, subject)
3557 if m:
3558 tags.append(self.sanitize_hash_tag(m.group(1)))
3559 return tags
3560
3561 @classmethod
3562 def sanitize_hash_tag(cls, tag):
3563 """Returns a sanitized Gerrit hash tag.
3564
3565 A sanitized hashtag can be used as a git push refspec parameter value.
3566 """
3567 return re.sub(cls.BAD_HASH_TAG_CHUNK, '-', tag).strip('-').lower()
3568
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01003569 def update_with_git_number_footers(self, parent_hash, parent_msg, dest_ref):
3570 """Updates this commit description given the parent.
3571
3572 This is essentially what Gnumbd used to do.
3573 Consult https://goo.gl/WMmpDe for more details.
3574 """
3575 assert parent_msg # No, orphan branch creation isn't supported.
3576 assert parent_hash
3577 assert dest_ref
3578 parent_footer_map = git_footers.parse_footers(parent_msg)
3579 # This will also happily parse svn-position, which GnumbD is no longer
3580 # supporting. While we'd generate correct footers, the verifier plugin
3581 # installed in Gerrit will block such commit (ie git push below will fail).
3582 parent_position = git_footers.get_position(parent_footer_map)
3583
3584 # Cherry-picks may have last line obscuring their prior footers,
3585 # from git_footers perspective. This is also what Gnumbd did.
3586 cp_line = None
3587 if (self._description_lines and
3588 re.match(self.CHERRY_PICK_LINE, self._description_lines[-1])):
3589 cp_line = self._description_lines.pop()
3590
Andrii Shyshkalovde37c012017-07-06 21:06:50 +02003591 top_lines, footer_lines, _ = git_footers.split_footers(self.description)
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01003592
3593 # Original-ify all Cr- footers, to avoid re-lands, cherry-picks, or just
3594 # user interference with actual footers we'd insert below.
Andrii Shyshkalovde37c012017-07-06 21:06:50 +02003595 for i, line in enumerate(footer_lines):
3596 k, v = git_footers.parse_footer(line) or (None, None)
3597 if k and k.startswith('Cr-'):
3598 footer_lines[i] = '%s: %s' % ('Cr-Original-' + k[len('Cr-'):], v)
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01003599
3600 # Add Position and Lineage footers based on the parent.
Andrii Shyshkalovb5effa12016-12-14 19:35:12 +01003601 lineage = list(reversed(parent_footer_map.get('Cr-Branched-From', [])))
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01003602 if parent_position[0] == dest_ref:
3603 # Same branch as parent.
3604 number = int(parent_position[1]) + 1
3605 else:
3606 number = 1 # New branch, and extra lineage.
3607 lineage.insert(0, '%s-%s@{#%d}' % (parent_hash, parent_position[0],
3608 int(parent_position[1])))
3609
Andrii Shyshkalovde37c012017-07-06 21:06:50 +02003610 footer_lines.append('Cr-Commit-Position: %s@{#%d}' % (dest_ref, number))
3611 footer_lines.extend('Cr-Branched-From: %s' % v for v in lineage)
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01003612
3613 self._description_lines = top_lines
3614 if cp_line:
3615 self._description_lines.append(cp_line)
3616 if self._description_lines[-1] != '':
3617 self._description_lines.append('') # Ensure footer separator.
Andrii Shyshkalovde37c012017-07-06 21:06:50 +02003618 self._description_lines.extend(footer_lines)
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01003619
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00003620
Aaron Gablea1bab272017-04-11 16:38:18 -07003621def get_approving_reviewers(props, disapproval=False):
maruel@chromium.orge52678e2013-04-26 18:34:44 +00003622 """Retrieves the reviewers that approved a CL from the issue properties with
3623 messages.
3624
3625 Note that the list may contain reviewers that are not committer, thus are not
3626 considered by the CQ.
Aaron Gablea1bab272017-04-11 16:38:18 -07003627
3628 If disapproval is True, instead returns reviewers who 'not lgtm'd the CL.
maruel@chromium.orge52678e2013-04-26 18:34:44 +00003629 """
Aaron Gablea1bab272017-04-11 16:38:18 -07003630 approval_type = 'disapproval' if disapproval else 'approval'
maruel@chromium.orge52678e2013-04-26 18:34:44 +00003631 return sorted(
3632 set(
3633 message['sender']
3634 for message in props['messages']
Aaron Gablea1bab272017-04-11 16:38:18 -07003635 if message[approval_type] and message['sender'] in props['reviewers']
maruel@chromium.orge52678e2013-04-26 18:34:44 +00003636 )
3637 )
3638
3639
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003640def FindCodereviewSettingsFile(filename='codereview.settings'):
3641 """Finds the given file starting in the cwd and going up.
3642
3643 Only looks up to the top of the repository unless an
3644 'inherit-review-settings-ok' file exists in the root of the repository.
3645 """
3646 inherit_ok_file = 'inherit-review-settings-ok'
3647 cwd = os.getcwd()
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00003648 root = settings.GetRoot()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003649 if os.path.isfile(os.path.join(root, inherit_ok_file)):
3650 root = '/'
3651 while True:
3652 if filename in os.listdir(cwd):
3653 if os.path.isfile(os.path.join(cwd, filename)):
3654 return open(os.path.join(cwd, filename))
3655 if cwd == root:
3656 break
3657 cwd = os.path.dirname(cwd)
3658
3659
3660def LoadCodereviewSettingsFromFile(fileobj):
3661 """Parse a codereview.settings file and updates hooks."""
maruel@chromium.org99ac1c52012-01-16 14:52:12 +00003662 keyvals = gclient_utils.ParseCodereviewSettingsContent(fileobj.read())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003663
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003664 def SetProperty(name, setting, unset_error_ok=False):
3665 fullname = 'rietveld.' + name
3666 if setting in keyvals:
3667 RunGit(['config', fullname, keyvals[setting]])
3668 else:
3669 RunGit(['config', '--unset-all', fullname], error_ok=unset_error_ok)
3670
tandrii48df5812016-10-17 03:55:37 -07003671 if not keyvals.get('GERRIT_HOST', False):
3672 SetProperty('server', 'CODE_REVIEW_SERVER')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003673 # Only server setting is required. Other settings can be absent.
3674 # In that case, we ignore errors raised during option deletion attempt.
3675 SetProperty('cc', 'CC_LIST', unset_error_ok=True)
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +00003676 SetProperty('private', 'PRIVATE', unset_error_ok=True)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003677 SetProperty('tree-status-url', 'STATUS', unset_error_ok=True)
3678 SetProperty('viewvc-url', 'VIEW_VC', unset_error_ok=True)
rmistry@google.com90752582014-01-14 21:04:50 +00003679 SetProperty('bug-prefix', 'BUG_PREFIX', unset_error_ok=True)
thestig@chromium.org44202a22014-03-11 19:22:18 +00003680 SetProperty('cpplint-regex', 'LINT_REGEX', unset_error_ok=True)
3681 SetProperty('cpplint-ignore-regex', 'LINT_IGNORE_REGEX', unset_error_ok=True)
sheyang@chromium.org152cf832014-06-11 21:37:49 +00003682 SetProperty('project', 'PROJECT', unset_error_ok=True)
rmistry@google.com5626a922015-02-26 14:03:30 +00003683 SetProperty('run-post-upload-hook', 'RUN_POST_UPLOAD_HOOK',
3684 unset_error_ok=True)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003685
ukai@chromium.org7044efc2013-11-28 01:51:21 +00003686 if 'GERRIT_HOST' in keyvals:
ukai@chromium.orge8077812012-02-03 03:41:46 +00003687 RunGit(['config', 'gerrit.host', keyvals['GERRIT_HOST']])
ukai@chromium.orge8077812012-02-03 03:41:46 +00003688
bauerb@chromium.org54b400c2016-01-14 10:08:25 +00003689 if 'GERRIT_SQUASH_UPLOADS' in keyvals:
tandrii8dd81ea2016-06-16 13:24:23 -07003690 RunGit(['config', 'gerrit.squash-uploads',
3691 keyvals['GERRIT_SQUASH_UPLOADS']])
bauerb@chromium.org54b400c2016-01-14 10:08:25 +00003692
tandrii@chromium.org28253532016-04-14 13:46:56 +00003693 if 'GERRIT_SKIP_ENSURE_AUTHENTICATED' in keyvals:
shinyak@chromium.org00dbccd2016-04-15 07:24:43 +00003694 RunGit(['config', 'gerrit.skip-ensure-authenticated',
tandrii@chromium.org28253532016-04-14 13:46:56 +00003695 keyvals['GERRIT_SKIP_ENSURE_AUTHENTICATED']])
3696
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003697 if 'PUSH_URL_CONFIG' in keyvals and 'ORIGIN_URL_CONFIG' in keyvals:
Andrii Shyshkalov18975322017-01-25 16:44:13 +01003698 # should be of the form
3699 # PUSH_URL_CONFIG: url.ssh://gitrw.chromium.org.pushinsteadof
3700 # ORIGIN_URL_CONFIG: http://src.chromium.org/git
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003701 RunGit(['config', keyvals['PUSH_URL_CONFIG'],
3702 keyvals['ORIGIN_URL_CONFIG']])
3703
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003704
joshua.lock@intel.com426f69b2012-08-02 23:41:49 +00003705def urlretrieve(source, destination):
3706 """urllib is broken for SSL connections via a proxy therefore we
3707 can't use urllib.urlretrieve()."""
3708 with open(destination, 'w') as f:
3709 f.write(urllib2.urlopen(source).read())
3710
3711
ukai@chromium.org712d6102013-11-27 00:52:58 +00003712def hasSheBang(fname):
3713 """Checks fname is a #! script."""
3714 with open(fname) as f:
3715 return f.read(2).startswith('#!')
3716
3717
bpastene@chromium.org917f0ff2016-04-05 00:45:30 +00003718# TODO(bpastene) Remove once a cleaner fix to crbug.com/600473 presents itself.
3719def DownloadHooks(*args, **kwargs):
3720 pass
3721
3722
tandrii@chromium.org18630d62016-03-04 12:06:02 +00003723def DownloadGerritHook(force):
3724 """Download and install Gerrit commit-msg hook.
ukai@chromium.org78c4b982012-02-14 02:20:26 +00003725
3726 Args:
3727 force: True to update hooks. False to install hooks if not present.
3728 """
3729 if not settings.GetIsGerrit():
3730 return
ukai@chromium.org712d6102013-11-27 00:52:58 +00003731 src = 'https://gerrit-review.googlesource.com/tools/hooks/commit-msg'
ukai@chromium.org78c4b982012-02-14 02:20:26 +00003732 dst = os.path.join(settings.GetRoot(), '.git', 'hooks', 'commit-msg')
3733 if not os.access(dst, os.X_OK):
3734 if os.path.exists(dst):
3735 if not force:
3736 return
ukai@chromium.org78c4b982012-02-14 02:20:26 +00003737 try:
joshua.lock@intel.com426f69b2012-08-02 23:41:49 +00003738 urlretrieve(src, dst)
ukai@chromium.org712d6102013-11-27 00:52:58 +00003739 if not hasSheBang(dst):
3740 DieWithError('Not a script: %s\n'
3741 'You need to download from\n%s\n'
3742 'into .git/hooks/commit-msg and '
3743 'chmod +x .git/hooks/commit-msg' % (dst, src))
ukai@chromium.org78c4b982012-02-14 02:20:26 +00003744 os.chmod(dst, stat.S_IRUSR | stat.S_IWUSR | stat.S_IXUSR)
3745 except Exception:
3746 if os.path.exists(dst):
3747 os.remove(dst)
ukai@chromium.org712d6102013-11-27 00:52:58 +00003748 DieWithError('\nFailed to download hooks.\n'
3749 'You need to download from\n%s\n'
3750 'into .git/hooks/commit-msg and '
3751 'chmod +x .git/hooks/commit-msg' % src)
ukai@chromium.org78c4b982012-02-14 02:20:26 +00003752
3753
tandrii@chromium.orge7d3d162016-03-15 14:15:57 +00003754def GetRietveldCodereviewSettingsInteractively():
3755 """Prompt the user for settings."""
3756 server = settings.GetDefaultServerUrl(error_ok=True)
3757 prompt = 'Rietveld server (host[:port])'
3758 prompt += ' [%s]' % (server or DEFAULT_SERVER)
3759 newserver = ask_for_data(prompt + ':')
3760 if not server and not newserver:
3761 newserver = DEFAULT_SERVER
3762 if newserver:
3763 newserver = gclient_utils.UpgradeToHttps(newserver)
3764 if newserver != server:
3765 RunGit(['config', 'rietveld.server', newserver])
3766
3767 def SetProperty(initial, caption, name, is_url):
3768 prompt = caption
3769 if initial:
3770 prompt += ' ("x" to clear) [%s]' % initial
3771 new_val = ask_for_data(prompt + ':')
3772 if new_val == 'x':
3773 RunGit(['config', '--unset-all', 'rietveld.' + name], error_ok=True)
3774 elif new_val:
3775 if is_url:
3776 new_val = gclient_utils.UpgradeToHttps(new_val)
3777 if new_val != initial:
3778 RunGit(['config', 'rietveld.' + name, new_val])
3779
3780 SetProperty(settings.GetDefaultCCList(), 'CC list', 'cc', False)
3781 SetProperty(settings.GetDefaultPrivateFlag(),
3782 'Private flag (rietveld only)', 'private', False)
3783 SetProperty(settings.GetTreeStatusUrl(error_ok=True), 'Tree status URL',
3784 'tree-status-url', False)
3785 SetProperty(settings.GetViewVCUrl(), 'ViewVC URL', 'viewvc-url', True)
3786 SetProperty(settings.GetBugPrefix(), 'Bug Prefix', 'bug-prefix', False)
3787 SetProperty(settings.GetRunPostUploadHook(), 'Run Post Upload Hook',
3788 'run-post-upload-hook', False)
3789
Andrii Shyshkalov18975322017-01-25 16:44:13 +01003790
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003791class _GitCookiesChecker(object):
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003792 """Provides facilities for validating and suggesting fixes to .gitcookies."""
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003793
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003794 _GOOGLESOURCE = 'googlesource.com'
3795
3796 def __init__(self):
3797 # Cached list of [host, identity, source], where source is either
3798 # .gitcookies or .netrc.
3799 self._all_hosts = None
3800
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003801 def ensure_configured_gitcookies(self):
3802 """Runs checks and suggests fixes to make git use .gitcookies from default
3803 path."""
3804 default = gerrit_util.CookiesAuthenticator.get_gitcookies_path()
3805 configured_path = RunGitSilent(
3806 ['config', '--global', 'http.cookiefile']).strip()
Andrii Shyshkalov1e250cd2017-05-10 15:39:31 +02003807 configured_path = os.path.expanduser(configured_path)
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003808 if configured_path:
3809 self._ensure_default_gitcookies_path(configured_path, default)
3810 else:
3811 self._configure_gitcookies_path(default)
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003812
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003813 @staticmethod
3814 def _ensure_default_gitcookies_path(configured_path, default_path):
3815 assert configured_path
3816 if configured_path == default_path:
3817 print('git is already configured to use your .gitcookies from %s' %
3818 configured_path)
3819 return
3820
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003821 print('WARNING: You have configured custom path to .gitcookies: %s\n'
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003822 'Gerrit and other depot_tools expect .gitcookies at %s\n' %
3823 (configured_path, default_path))
3824
3825 if not os.path.exists(configured_path):
3826 print('However, your configured .gitcookies file is missing.')
3827 confirm_or_exit('Reconfigure git to use default .gitcookies?',
3828 action='reconfigure')
3829 RunGit(['config', '--global', 'http.cookiefile', default_path])
3830 return
3831
3832 if os.path.exists(default_path):
3833 print('WARNING: default .gitcookies file already exists %s' %
3834 default_path)
3835 DieWithError('Please delete %s manually and re-run git cl creds-check' %
3836 default_path)
3837
3838 confirm_or_exit('Move existing .gitcookies to default location?',
3839 action='move')
3840 shutil.move(configured_path, default_path)
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003841 RunGit(['config', '--global', 'http.cookiefile', default_path])
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003842 print('Moved and reconfigured git to use .gitcookies from %s' %
3843 default_path)
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003844
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003845 @staticmethod
3846 def _configure_gitcookies_path(default_path):
3847 netrc_path = gerrit_util.CookiesAuthenticator.get_netrc_path()
3848 if os.path.exists(netrc_path):
3849 print('You seem to be using outdated .netrc for git credentials: %s' %
3850 netrc_path)
3851 print('This tool will guide you through setting up recommended '
3852 '.gitcookies store for git credentials.\n'
3853 '\n'
3854 'IMPORTANT: If something goes wrong and you decide to go back, do:\n'
3855 ' git config --global --unset http.cookiefile\n'
3856 ' mv %s %s.backup\n\n' % (default_path, default_path))
3857 confirm_or_exit(action='setup .gitcookies')
3858 RunGit(['config', '--global', 'http.cookiefile', default_path])
3859 print('Configured git to use .gitcookies from %s' % default_path)
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003860
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003861 def get_hosts_with_creds(self, include_netrc=False):
3862 if self._all_hosts is None:
3863 a = gerrit_util.CookiesAuthenticator()
3864 self._all_hosts = [
3865 (h, u, s)
3866 for h, u, s in itertools.chain(
3867 ((h, u, '.netrc') for h, (u, _, _) in a.netrc.hosts.iteritems()),
3868 ((h, u, '.gitcookies') for h, (u, _) in a.gitcookies.iteritems())
3869 )
3870 if h.endswith(self._GOOGLESOURCE)
3871 ]
3872
3873 if include_netrc:
3874 return self._all_hosts
3875 return [(h, u, s) for h, u, s in self._all_hosts if s != '.netrc']
3876
3877 def print_current_creds(self, include_netrc=False):
3878 hosts = sorted(self.get_hosts_with_creds(include_netrc=include_netrc))
3879 if not hosts:
3880 print('No Git/Gerrit credentials found')
3881 return
3882 lengths = [max(map(len, (row[i] for row in hosts))) for i in xrange(3)]
3883 header = [('Host', 'User', 'Which file'),
3884 ['=' * l for l in lengths]]
3885 for row in (header + hosts):
3886 print('\t'.join((('%%+%ds' % l) % s)
3887 for l, s in zip(lengths, row)))
3888
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003889 @staticmethod
3890 def _parse_identity(identity):
Lei Zhangd3f769a2017-12-15 15:16:14 -08003891 """Parses identity "git-<username>.domain" into <username> and domain."""
3892 # Special case: usernames that contain ".", which are generally not
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +02003893 # distinguishable from sub-domains. But we do know typical domains:
3894 if identity.endswith('.chromium.org'):
3895 domain = 'chromium.org'
3896 username = identity[:-len('.chromium.org')]
3897 else:
3898 username, domain = identity.split('.', 1)
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003899 if username.startswith('git-'):
3900 username = username[len('git-'):]
3901 return username, domain
3902
3903 def _get_usernames_of_domain(self, domain):
3904 """Returns list of usernames referenced by .gitcookies in a given domain."""
3905 identities_by_domain = {}
3906 for _, identity, _ in self.get_hosts_with_creds():
3907 username, domain = self._parse_identity(identity)
3908 identities_by_domain.setdefault(domain, []).append(username)
3909 return identities_by_domain.get(domain)
3910
3911 def _canonical_git_googlesource_host(self, host):
3912 """Normalizes Gerrit hosts (with '-review') to Git host."""
3913 assert host.endswith(self._GOOGLESOURCE)
3914 # Prefix doesn't include '.' at the end.
3915 prefix = host[:-(1 + len(self._GOOGLESOURCE))]
3916 if prefix.endswith('-review'):
3917 prefix = prefix[:-len('-review')]
3918 return prefix + '.' + self._GOOGLESOURCE
3919
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003920 def _canonical_gerrit_googlesource_host(self, host):
3921 git_host = self._canonical_git_googlesource_host(host)
3922 prefix = git_host.split('.', 1)[0]
3923 return prefix + '-review.' + self._GOOGLESOURCE
3924
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003925 def _get_counterpart_host(self, host):
3926 assert host.endswith(self._GOOGLESOURCE)
3927 git = self._canonical_git_googlesource_host(host)
3928 gerrit = self._canonical_gerrit_googlesource_host(git)
3929 return git if gerrit == host else gerrit
3930
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003931 def has_generic_host(self):
3932 """Returns whether generic .googlesource.com has been configured.
3933
3934 Chrome Infra recommends to use explicit ${host}.googlesource.com instead.
3935 """
3936 for host, _, _ in self.get_hosts_with_creds(include_netrc=False):
3937 if host == '.' + self._GOOGLESOURCE:
3938 return True
3939 return False
3940
3941 def _get_git_gerrit_identity_pairs(self):
3942 """Returns map from canonic host to pair of identities (Git, Gerrit).
3943
3944 One of identities might be None, meaning not configured.
3945 """
3946 host_to_identity_pairs = {}
3947 for host, identity, _ in self.get_hosts_with_creds():
3948 canonical = self._canonical_git_googlesource_host(host)
3949 pair = host_to_identity_pairs.setdefault(canonical, [None, None])
3950 idx = 0 if canonical == host else 1
3951 pair[idx] = identity
3952 return host_to_identity_pairs
3953
3954 def get_partially_configured_hosts(self):
3955 return set(
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003956 (host if i1 else self._canonical_gerrit_googlesource_host(host))
3957 for host, (i1, i2) in self._get_git_gerrit_identity_pairs().iteritems()
3958 if None in (i1, i2) and host != '.' + self._GOOGLESOURCE)
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003959
3960 def get_conflicting_hosts(self):
3961 return set(
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003962 host
3963 for host, (i1, i2) in self._get_git_gerrit_identity_pairs().iteritems()
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003964 if None not in (i1, i2) and i1 != i2)
3965
3966 def get_duplicated_hosts(self):
3967 counters = collections.Counter(h for h, _, _ in self.get_hosts_with_creds())
3968 return set(host for host, count in counters.iteritems() if count > 1)
3969
3970 _EXPECTED_HOST_IDENTITY_DOMAINS = {
3971 'chromium.googlesource.com': 'chromium.org',
3972 'chrome-internal.googlesource.com': 'google.com',
3973 }
3974
3975 def get_hosts_with_wrong_identities(self):
3976 """Finds hosts which **likely** reference wrong identities.
3977
3978 Note: skips hosts which have conflicting identities for Git and Gerrit.
3979 """
3980 hosts = set()
3981 for host, expected in self._EXPECTED_HOST_IDENTITY_DOMAINS.iteritems():
3982 pair = self._get_git_gerrit_identity_pairs().get(host)
3983 if pair and pair[0] == pair[1]:
3984 _, domain = self._parse_identity(pair[0])
3985 if domain != expected:
3986 hosts.add(host)
3987 return hosts
3988
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003989 @staticmethod
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003990 def _format_hosts(hosts, extra_column_func=None):
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003991 hosts = sorted(hosts)
3992 assert hosts
3993 if extra_column_func is None:
3994 extras = [''] * len(hosts)
3995 else:
3996 extras = [extra_column_func(host) for host in hosts]
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003997 tmpl = '%%-%ds %%-%ds' % (max(map(len, hosts)), max(map(len, extras)))
3998 lines = []
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003999 for he in zip(hosts, extras):
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02004000 lines.append(tmpl % he)
4001 return lines
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01004002
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02004003 def _find_problems(self):
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01004004 if self.has_generic_host():
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02004005 yield ('.googlesource.com wildcard record detected',
4006 ['Chrome Infrastructure team recommends to list full host names '
4007 'explicitly.'],
4008 None)
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01004009
4010 dups = self.get_duplicated_hosts()
4011 if dups:
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02004012 yield ('The following hosts were defined twice',
4013 self._format_hosts(dups),
4014 None)
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01004015
4016 partial = self.get_partially_configured_hosts()
4017 if partial:
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02004018 yield ('Credentials should come in pairs for Git and Gerrit hosts. '
4019 'These hosts are missing',
4020 self._format_hosts(partial, lambda host: 'but %s defined' %
4021 self._get_counterpart_host(host)),
4022 partial)
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01004023
4024 conflicting = self.get_conflicting_hosts()
4025 if conflicting:
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02004026 yield ('The following Git hosts have differing credentials from their '
4027 'Gerrit counterparts',
4028 self._format_hosts(conflicting, lambda host: '%s vs %s' %
4029 tuple(self._get_git_gerrit_identity_pairs()[host])),
4030 conflicting)
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01004031
4032 wrong = self.get_hosts_with_wrong_identities()
4033 if wrong:
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02004034 yield ('These hosts likely use wrong identity',
4035 self._format_hosts(wrong, lambda host: '%s but %s recommended' %
4036 (self._get_git_gerrit_identity_pairs()[host][0],
4037 self._EXPECTED_HOST_IDENTITY_DOMAINS[host])),
4038 wrong)
4039
4040 def find_and_report_problems(self):
4041 """Returns True if there was at least one problem, else False."""
4042 found = False
4043 bad_hosts = set()
4044 for title, sublines, hosts in self._find_problems():
4045 if not found:
4046 found = True
4047 print('\n\n.gitcookies problem report:\n')
4048 bad_hosts.update(hosts or [])
4049 print(' %s%s' % (title , (':' if sublines else '')))
4050 if sublines:
4051 print()
4052 print(' %s' % '\n '.join(sublines))
4053 print()
4054
4055 if bad_hosts:
4056 assert found
4057 print(' You can manually remove corresponding lines in your %s file and '
4058 'visit the following URLs with correct account to generate '
4059 'correct credential lines:\n' %
4060 gerrit_util.CookiesAuthenticator.get_gitcookies_path())
4061 print(' %s' % '\n '.join(sorted(set(
4062 gerrit_util.CookiesAuthenticator().get_new_password_url(
4063 self._canonical_git_googlesource_host(host))
4064 for host in bad_hosts
4065 ))))
4066 return found
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01004067
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01004068
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004069@metrics.collector.collect_metrics('git cl creds-check')
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01004070def CMDcreds_check(parser, args):
4071 """Checks credentials and suggests changes."""
4072 _, _ = parser.parse_args(args)
4073
4074 if gerrit_util.GceAuthenticator.is_gce():
Aaron Gabled10ca0e2017-09-11 11:24:10 -07004075 DieWithError(
4076 'This command is not designed for GCE, are you on a bot?\n'
4077 'If you need to run this, export SKIP_GCE_AUTH_FOR_GIT=1 in your env.')
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01004078
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01004079 checker = _GitCookiesChecker()
4080 checker.ensure_configured_gitcookies()
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01004081
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01004082 print('Your .netrc and .gitcookies have credentials for these hosts:')
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01004083 checker.print_current_creds(include_netrc=True)
4084
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01004085 if not checker.find_and_report_problems():
Quinten Yearsley0c62da92017-05-31 13:39:42 -07004086 print('\nNo problems detected in your .gitcookies file.')
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01004087 return 0
4088 return 1
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01004089
4090
maruel@chromium.org0633fb42013-08-16 20:06:14 +00004091@subcommand.usage('[repo root containing codereview.settings]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004092@metrics.collector.collect_metrics('git cl config')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004093def CMDconfig(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004094 """Edits configuration for this tree."""
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004095
Quinten Yearsley0c62da92017-05-31 13:39:42 -07004096 print('WARNING: git cl config works for Rietveld only.')
tandrii5d0a0422016-09-14 06:24:35 -07004097 # TODO(tandrii): remove this once we switch to Gerrit.
4098 # See bugs http://crbug.com/637561 and http://crbug.com/600469.
pgervais@chromium.org87884cc2014-01-03 22:23:41 +00004099 parser.add_option('--activate-update', action='store_true',
4100 help='activate auto-updating [rietveld] section in '
4101 '.git/config')
4102 parser.add_option('--deactivate-update', action='store_true',
4103 help='deactivate auto-updating [rietveld] section in '
4104 '.git/config')
4105 options, args = parser.parse_args(args)
4106
4107 if options.deactivate_update:
4108 RunGit(['config', 'rietveld.autoupdate', 'false'])
4109 return
4110
4111 if options.activate_update:
4112 RunGit(['config', '--unset', 'rietveld.autoupdate'])
4113 return
4114
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004115 if len(args) == 0:
tandrii@chromium.orge7d3d162016-03-15 14:15:57 +00004116 GetRietveldCodereviewSettingsInteractively()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004117 return 0
4118
4119 url = args[0]
4120 if not url.endswith('codereview.settings'):
4121 url = os.path.join(url, 'codereview.settings')
4122
4123 # Load code review settings and download hooks (if available).
4124 LoadCodereviewSettingsFromFile(urllib2.urlopen(url))
4125 return 0
4126
4127
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004128@metrics.collector.collect_metrics('git cl baseurl')
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00004129def CMDbaseurl(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004130 """Gets or sets base-url for this branch."""
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00004131 branchref = RunGit(['symbolic-ref', 'HEAD']).strip()
4132 branch = ShortBranchName(branchref)
4133 _, args = parser.parse_args(args)
4134 if not args:
vapiera7fbd5a2016-06-16 09:17:49 -07004135 print('Current base-url:')
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00004136 return RunGit(['config', 'branch.%s.base-url' % branch],
4137 error_ok=False).strip()
4138 else:
vapiera7fbd5a2016-06-16 09:17:49 -07004139 print('Setting base-url to %s' % args[0])
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00004140 return RunGit(['config', 'branch.%s.base-url' % branch, args[0]],
4141 error_ok=False).strip()
4142
4143
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00004144def color_for_status(status):
4145 """Maps a Changelist status to color, for CMDstatus and other tools."""
4146 return {
Aaron Gable9ab38c62017-04-06 14:36:33 -07004147 'unsent': Fore.YELLOW,
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00004148 'waiting': Fore.BLUE,
4149 'reply': Fore.YELLOW,
Aaron Gable9ab38c62017-04-06 14:36:33 -07004150 'not lgtm': Fore.RED,
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00004151 'lgtm': Fore.GREEN,
4152 'commit': Fore.MAGENTA,
4153 'closed': Fore.CYAN,
4154 'error': Fore.WHITE,
4155 }.get(status, Fore.WHITE)
4156
tandrii@chromium.org04ea8462016-04-25 19:51:21 +00004157
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00004158def get_cl_statuses(changes, fine_grained, max_processes=None):
4159 """Returns a blocking iterable of (cl, status) for given branches.
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00004160
4161 If fine_grained is true, this will fetch CL statuses from the server.
4162 Otherwise, simply indicate if there's a matching url for the given branches.
4163
4164 If max_processes is specified, it is used as the maximum number of processes
4165 to spawn to fetch CL status from the server. Otherwise 1 process per branch is
4166 spawned.
calamity@chromium.orgcf197482016-04-29 20:15:53 +00004167
4168 See GetStatus() for a list of possible statuses.
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00004169 """
qyearsley12fa6ff2016-08-24 09:18:40 -07004170 # Silence upload.py otherwise it becomes unwieldy.
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00004171 upload.verbosity = 0
4172
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01004173 if not changes:
4174 raise StopIteration()
calamity@chromium.orgcf197482016-04-29 20:15:53 +00004175
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01004176 if not fine_grained:
4177 # Fast path which doesn't involve querying codereview servers.
Aaron Gablea1bab272017-04-11 16:38:18 -07004178 # Do not use get_approving_reviewers(), since it requires an HTTP request.
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00004179 for cl in changes:
4180 yield (cl, 'waiting' if cl.GetIssueURL() else 'error')
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01004181 return
4182
4183 # First, sort out authentication issues.
4184 logging.debug('ensuring credentials exist')
4185 for cl in changes:
4186 cl.EnsureAuthenticated(force=False, refresh=True)
4187
4188 def fetch(cl):
4189 try:
4190 return (cl, cl.GetStatus())
4191 except:
4192 # See http://crbug.com/629863.
Andrii Shyshkalov98824232018-04-19 11:37:15 -07004193 logging.exception('failed to fetch status for cl %s:', cl.GetIssue())
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01004194 raise
4195
4196 threads_count = len(changes)
4197 if max_processes:
4198 threads_count = max(1, min(threads_count, max_processes))
4199 logging.debug('querying %d CLs using %d threads', len(changes), threads_count)
4200
4201 pool = ThreadPool(threads_count)
4202 fetched_cls = set()
4203 try:
4204 it = pool.imap_unordered(fetch, changes).__iter__()
4205 while True:
4206 try:
4207 cl, status = it.next(timeout=5)
4208 except multiprocessing.TimeoutError:
4209 break
4210 fetched_cls.add(cl)
4211 yield cl, status
4212 finally:
4213 pool.close()
4214
4215 # Add any branches that failed to fetch.
4216 for cl in set(changes) - fetched_cls:
4217 yield (cl, 'error')
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00004218
rmistry@google.com2dd99862015-06-22 12:22:18 +00004219
4220def upload_branch_deps(cl, args):
4221 """Uploads CLs of local branches that are dependents of the current branch.
4222
4223 If the local branch dependency tree looks like:
4224 test1 -> test2.1 -> test3.1
4225 -> test3.2
4226 -> test2.2 -> test3.3
4227
4228 and you run "git cl upload --dependencies" from test1 then "git cl upload" is
4229 run on the dependent branches in this order:
4230 test2.1, test3.1, test3.2, test2.2, test3.3
4231
4232 Note: This function does not rebase your local dependent branches. Use it when
4233 you make a change to the parent branch that will not conflict with its
4234 dependent branches, and you would like their dependencies updated in
4235 Rietveld.
4236 """
4237 if git_common.is_dirty_git_tree('upload-branch-deps'):
4238 return 1
4239
4240 root_branch = cl.GetBranch()
4241 if root_branch is None:
4242 DieWithError('Can\'t find dependent branches from detached HEAD state. '
4243 'Get on a branch!')
Andrii Shyshkalov1090fd52017-01-26 09:37:54 +01004244 if not cl.GetIssue() or (not cl.IsGerrit() and not cl.GetPatchset()):
rmistry@google.com2dd99862015-06-22 12:22:18 +00004245 DieWithError('Current branch does not have an uploaded CL. We cannot set '
4246 'patchset dependencies without an uploaded CL.')
4247
4248 branches = RunGit(['for-each-ref',
4249 '--format=%(refname:short) %(upstream:short)',
4250 'refs/heads'])
4251 if not branches:
4252 print('No local branches found.')
4253 return 0
4254
4255 # Create a dictionary of all local branches to the branches that are dependent
4256 # on it.
4257 tracked_to_dependents = collections.defaultdict(list)
4258 for b in branches.splitlines():
4259 tokens = b.split()
4260 if len(tokens) == 2:
4261 branch_name, tracked = tokens
4262 tracked_to_dependents[tracked].append(branch_name)
4263
vapiera7fbd5a2016-06-16 09:17:49 -07004264 print()
4265 print('The dependent local branches of %s are:' % root_branch)
rmistry@google.com2dd99862015-06-22 12:22:18 +00004266 dependents = []
4267 def traverse_dependents_preorder(branch, padding=''):
4268 dependents_to_process = tracked_to_dependents.get(branch, [])
4269 padding += ' '
4270 for dependent in dependents_to_process:
vapiera7fbd5a2016-06-16 09:17:49 -07004271 print('%s%s' % (padding, dependent))
rmistry@google.com2dd99862015-06-22 12:22:18 +00004272 dependents.append(dependent)
4273 traverse_dependents_preorder(dependent, padding)
4274 traverse_dependents_preorder(root_branch)
vapiera7fbd5a2016-06-16 09:17:49 -07004275 print()
rmistry@google.com2dd99862015-06-22 12:22:18 +00004276
4277 if not dependents:
vapiera7fbd5a2016-06-16 09:17:49 -07004278 print('There are no dependent local branches for %s' % root_branch)
rmistry@google.com2dd99862015-06-22 12:22:18 +00004279 return 0
4280
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01004281 confirm_or_exit('This command will checkout all dependent branches and run '
4282 '"git cl upload".', action='continue')
rmistry@google.com2dd99862015-06-22 12:22:18 +00004283
andybons@chromium.org962f9462016-02-03 20:00:42 +00004284 # Add a default patchset title to all upload calls in Rietveld.
tandrii@chromium.org4c72b082016-03-31 22:26:35 +00004285 if not cl.IsGerrit():
andybons@chromium.org962f9462016-02-03 20:00:42 +00004286 args.extend(['-t', 'Updated patchset dependency'])
4287
rmistry@google.com2dd99862015-06-22 12:22:18 +00004288 # Record all dependents that failed to upload.
4289 failures = {}
4290 # Go through all dependents, checkout the branch and upload.
4291 try:
4292 for dependent_branch in dependents:
vapiera7fbd5a2016-06-16 09:17:49 -07004293 print()
4294 print('--------------------------------------')
4295 print('Running "git cl upload" from %s:' % dependent_branch)
rmistry@google.com2dd99862015-06-22 12:22:18 +00004296 RunGit(['checkout', '-q', dependent_branch])
vapiera7fbd5a2016-06-16 09:17:49 -07004297 print()
rmistry@google.com2dd99862015-06-22 12:22:18 +00004298 try:
4299 if CMDupload(OptionParser(), args) != 0:
vapiera7fbd5a2016-06-16 09:17:49 -07004300 print('Upload failed for %s!' % dependent_branch)
rmistry@google.com2dd99862015-06-22 12:22:18 +00004301 failures[dependent_branch] = 1
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -08004302 except: # pylint: disable=bare-except
rmistry@google.com2dd99862015-06-22 12:22:18 +00004303 failures[dependent_branch] = 1
vapiera7fbd5a2016-06-16 09:17:49 -07004304 print()
rmistry@google.com2dd99862015-06-22 12:22:18 +00004305 finally:
4306 # Swap back to the original root branch.
4307 RunGit(['checkout', '-q', root_branch])
4308
vapiera7fbd5a2016-06-16 09:17:49 -07004309 print()
4310 print('Upload complete for dependent branches!')
rmistry@google.com2dd99862015-06-22 12:22:18 +00004311 for dependent_branch in dependents:
4312 upload_status = 'failed' if failures.get(dependent_branch) else 'succeeded'
vapiera7fbd5a2016-06-16 09:17:49 -07004313 print(' %s : %s' % (dependent_branch, upload_status))
4314 print()
rmistry@google.com2dd99862015-06-22 12:22:18 +00004315
4316 return 0
4317
4318
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004319@metrics.collector.collect_metrics('git cl archive')
kmarshall3bff56b2016-06-06 18:31:47 -07004320def CMDarchive(parser, args):
4321 """Archives and deletes branches associated with closed changelists."""
4322 parser.add_option(
4323 '-j', '--maxjobs', action='store', type=int,
kmarshall9249e012016-08-23 12:02:16 -07004324 help='The maximum number of jobs to use when retrieving review status.')
kmarshall3bff56b2016-06-06 18:31:47 -07004325 parser.add_option(
4326 '-f', '--force', action='store_true',
4327 help='Bypasses the confirmation prompt.')
kmarshall9249e012016-08-23 12:02:16 -07004328 parser.add_option(
4329 '-d', '--dry-run', action='store_true',
4330 help='Skip the branch tagging and removal steps.')
4331 parser.add_option(
4332 '-t', '--notags', action='store_true',
4333 help='Do not tag archived branches. '
4334 'Note: local commit history may be lost.')
kmarshall3bff56b2016-06-06 18:31:47 -07004335
4336 auth.add_auth_options(parser)
4337 options, args = parser.parse_args(args)
4338 if args:
4339 parser.error('Unsupported args: %s' % ' '.join(args))
4340 auth_config = auth.extract_auth_config_from_options(options)
4341
4342 branches = RunGit(['for-each-ref', '--format=%(refname)', 'refs/heads'])
4343 if not branches:
4344 return 0
4345
vapiera7fbd5a2016-06-16 09:17:49 -07004346 print('Finding all branches associated with closed issues...')
kmarshall3bff56b2016-06-06 18:31:47 -07004347 changes = [Changelist(branchref=b, auth_config=auth_config)
4348 for b in branches.splitlines()]
4349 alignment = max(5, max(len(c.GetBranch()) for c in changes))
4350 statuses = get_cl_statuses(changes,
4351 fine_grained=True,
4352 max_processes=options.maxjobs)
4353 proposal = [(cl.GetBranch(),
4354 'git-cl-archived-%s-%s' % (cl.GetIssue(), cl.GetBranch()))
4355 for cl, status in statuses
4356 if status == 'closed']
4357 proposal.sort()
4358
4359 if not proposal:
vapiera7fbd5a2016-06-16 09:17:49 -07004360 print('No branches with closed codereview issues found.')
kmarshall3bff56b2016-06-06 18:31:47 -07004361 return 0
4362
4363 current_branch = GetCurrentBranch()
4364
vapiera7fbd5a2016-06-16 09:17:49 -07004365 print('\nBranches with closed issues that will be archived:\n')
kmarshall9249e012016-08-23 12:02:16 -07004366 if options.notags:
4367 for next_item in proposal:
4368 print(' ' + next_item[0])
4369 else:
4370 print('%*s | %s' % (alignment, 'Branch name', 'Archival tag name'))
4371 for next_item in proposal:
4372 print('%*s %s' % (alignment, next_item[0], next_item[1]))
kmarshall3bff56b2016-06-06 18:31:47 -07004373
kmarshall9249e012016-08-23 12:02:16 -07004374 # Quit now on precondition failure or if instructed by the user, either
4375 # via an interactive prompt or by command line flags.
4376 if options.dry_run:
4377 print('\nNo changes were made (dry run).\n')
4378 return 0
4379 elif any(branch == current_branch for branch, _ in proposal):
kmarshall3bff56b2016-06-06 18:31:47 -07004380 print('You are currently on a branch \'%s\' which is associated with a '
4381 'closed codereview issue, so archive cannot proceed. Please '
4382 'checkout another branch and run this command again.' %
4383 current_branch)
4384 return 1
kmarshall9249e012016-08-23 12:02:16 -07004385 elif not options.force:
sergiyb4a5ecbe2016-06-20 09:46:00 -07004386 answer = ask_for_data('\nProceed with deletion (Y/n)? ').lower()
4387 if answer not in ('y', ''):
vapiera7fbd5a2016-06-16 09:17:49 -07004388 print('Aborted.')
kmarshall3bff56b2016-06-06 18:31:47 -07004389 return 1
4390
4391 for branch, tagname in proposal:
kmarshall9249e012016-08-23 12:02:16 -07004392 if not options.notags:
4393 RunGit(['tag', tagname, branch])
kmarshall3bff56b2016-06-06 18:31:47 -07004394 RunGit(['branch', '-D', branch])
kmarshall9249e012016-08-23 12:02:16 -07004395
vapiera7fbd5a2016-06-16 09:17:49 -07004396 print('\nJob\'s done!')
kmarshall3bff56b2016-06-06 18:31:47 -07004397
4398 return 0
4399
4400
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004401@metrics.collector.collect_metrics('git cl status')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004402def CMDstatus(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004403 """Show status of changelists.
4404
4405 Colors are used to tell the state of the CL unless --fast is used:
jsbell@chromium.orgaeab41a2013-12-10 20:01:22 +00004406 - Blue waiting for review
Aaron Gable9ab38c62017-04-06 14:36:33 -07004407 - Yellow waiting for you to reply to review, or not yet sent
jsbell@chromium.orgaeab41a2013-12-10 20:01:22 +00004408 - Green LGTM'ed
Aaron Gable9ab38c62017-04-06 14:36:33 -07004409 - Red 'not LGTM'ed
jsbell@chromium.orgaeab41a2013-12-10 20:01:22 +00004410 - Magenta in the commit queue
4411 - Cyan was committed, branch can be deleted
Aaron Gable9ab38c62017-04-06 14:36:33 -07004412 - White error, or unknown status
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004413
4414 Also see 'git cl comments'.
4415 """
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004416 parser.add_option('--field',
phajdan.jr289d03e2016-08-16 08:21:06 -07004417 help='print only specific field (desc|id|patch|status|url)')
maruel@chromium.org1033efd2013-07-23 23:25:09 +00004418 parser.add_option('-f', '--fast', action='store_true',
4419 help='Do not retrieve review status')
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00004420 parser.add_option(
4421 '-j', '--maxjobs', action='store', type=int,
4422 help='The maximum number of jobs to use when retrieving review status')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004423
4424 auth.add_auth_options(parser)
iannuccie53c9352016-08-17 14:40:40 -07004425 _add_codereview_issue_select_options(
4426 parser, 'Must be in conjunction with --field.')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004427 options, args = parser.parse_args(args)
iannuccie53c9352016-08-17 14:40:40 -07004428 _process_codereview_issue_select_options(parser, options)
maruel@chromium.org39c0b222013-08-17 16:57:01 +00004429 if args:
4430 parser.error('Unsupported args: %s' % args)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004431 auth_config = auth.extract_auth_config_from_options(options)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004432
iannuccie53c9352016-08-17 14:40:40 -07004433 if options.issue is not None and not options.field:
4434 parser.error('--field must be specified with --issue')
iannucci3c972b92016-08-17 13:24:10 -07004435
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004436 if options.field:
iannucci3c972b92016-08-17 13:24:10 -07004437 cl = Changelist(auth_config=auth_config, issue=options.issue,
4438 codereview=options.forced_codereview)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004439 if options.field.startswith('desc'):
vapiera7fbd5a2016-06-16 09:17:49 -07004440 print(cl.GetDescription())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004441 elif options.field == 'id':
4442 issueid = cl.GetIssue()
4443 if issueid:
vapiera7fbd5a2016-06-16 09:17:49 -07004444 print(issueid)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004445 elif options.field == 'patch':
Aaron Gablee8856ee2017-12-07 12:41:46 -08004446 patchset = cl.GetMostRecentPatchset()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004447 if patchset:
vapiera7fbd5a2016-06-16 09:17:49 -07004448 print(patchset)
phajdan.jr289d03e2016-08-16 08:21:06 -07004449 elif options.field == 'status':
4450 print(cl.GetStatus())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004451 elif options.field == 'url':
4452 url = cl.GetIssueURL()
4453 if url:
vapiera7fbd5a2016-06-16 09:17:49 -07004454 print(url)
maruel@chromium.orge25c75b2013-07-23 18:30:56 +00004455 return 0
4456
4457 branches = RunGit(['for-each-ref', '--format=%(refname)', 'refs/heads'])
4458 if not branches:
4459 print('No local branch found.')
4460 return 0
4461
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00004462 changes = [
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004463 Changelist(branchref=b, auth_config=auth_config)
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00004464 for b in branches.splitlines()]
vapiera7fbd5a2016-06-16 09:17:49 -07004465 print('Branches associated with reviews:')
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00004466 output = get_cl_statuses(changes,
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00004467 fine_grained=not options.fast,
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00004468 max_processes=options.maxjobs)
maruel@chromium.org1033efd2013-07-23 23:25:09 +00004469
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00004470 branch_statuses = {}
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00004471 alignment = max(5, max(len(ShortBranchName(c.GetBranch())) for c in changes))
4472 for cl in sorted(changes, key=lambda c: c.GetBranch()):
4473 branch = cl.GetBranch()
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00004474 while branch not in branch_statuses:
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00004475 c, status = output.next()
4476 branch_statuses[c.GetBranch()] = status
4477 status = branch_statuses.pop(branch)
4478 url = cl.GetIssueURL()
4479 if url and (not status or status == 'error'):
4480 # The issue probably doesn't exist anymore.
4481 url += ' (broken)'
4482
nodir@chromium.orga6de1f42015-06-10 04:23:17 +00004483 color = color_for_status(status)
maruel@chromium.org885f6512013-07-27 02:17:26 +00004484 reset = Fore.RESET
iannucci@chromium.org596cd5c2016-04-04 21:34:39 +00004485 if not setup_color.IS_TTY:
maruel@chromium.org885f6512013-07-27 02:17:26 +00004486 color = ''
4487 reset = ''
nodir@chromium.orga6de1f42015-06-10 04:23:17 +00004488 status_str = '(%s)' % status if status else ''
vapiera7fbd5a2016-06-16 09:17:49 -07004489 print(' %*s : %s%s %s%s' % (
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00004490 alignment, ShortBranchName(branch), color, url,
vapiera7fbd5a2016-06-16 09:17:49 -07004491 status_str, reset))
maruel@chromium.org1033efd2013-07-23 23:25:09 +00004492
Andrii Shyshkalovd0e1d9d2017-01-24 17:10:51 +01004493
4494 branch = GetCurrentBranch()
vapiera7fbd5a2016-06-16 09:17:49 -07004495 print()
Andrii Shyshkalovd0e1d9d2017-01-24 17:10:51 +01004496 print('Current branch: %s' % branch)
4497 for cl in changes:
4498 if cl.GetBranch() == branch:
4499 break
dpranke@chromium.orgee87f582015-07-31 18:46:25 +00004500 if not cl.GetIssue():
vapiera7fbd5a2016-06-16 09:17:49 -07004501 print('No issue assigned.')
dpranke@chromium.orgee87f582015-07-31 18:46:25 +00004502 return 0
vapiera7fbd5a2016-06-16 09:17:49 -07004503 print('Issue number: %s (%s)' % (cl.GetIssue(), cl.GetIssueURL()))
maruel@chromium.org85616e02014-07-28 15:37:55 +00004504 if not options.fast:
vapiera7fbd5a2016-06-16 09:17:49 -07004505 print('Issue description:')
4506 print(cl.GetDescription(pretty=True))
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004507 return 0
4508
4509
maruel@chromium.org39c0b222013-08-17 16:57:01 +00004510def colorize_CMDstatus_doc():
4511 """To be called once in main() to add colors to git cl status help."""
4512 colors = [i for i in dir(Fore) if i[0].isupper()]
4513
4514 def colorize_line(line):
4515 for color in colors:
4516 if color in line.upper():
Quinten Yearsley0c62da92017-05-31 13:39:42 -07004517 # Extract whitespace first and the leading '-'.
maruel@chromium.org39c0b222013-08-17 16:57:01 +00004518 indent = len(line) - len(line.lstrip(' ')) + 1
4519 return line[:indent] + getattr(Fore, color) + line[indent:] + Fore.RESET
4520 return line
4521
4522 lines = CMDstatus.__doc__.splitlines()
4523 CMDstatus.__doc__ = '\n'.join(colorize_line(l) for l in lines)
4524
4525
phajdan.jre328cf92016-08-22 04:12:17 -07004526def write_json(path, contents):
Stefan Zager1306bd02017-06-22 19:26:46 -07004527 if path == '-':
4528 json.dump(contents, sys.stdout)
4529 else:
4530 with open(path, 'w') as f:
4531 json.dump(contents, f)
phajdan.jre328cf92016-08-22 04:12:17 -07004532
4533
maruel@chromium.org0633fb42013-08-16 20:06:14 +00004534@subcommand.usage('[issue_number]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004535@metrics.collector.collect_metrics('git cl issue')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004536def CMDissue(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004537 """Sets or displays the current code review issue number.
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004538
4539 Pass issue number 0 to clear the current issue.
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004540 """
dnj@chromium.org406c4402015-03-03 17:22:28 +00004541 parser.add_option('-r', '--reverse', action='store_true',
4542 help='Lookup the branch(es) for the specified issues. If '
4543 'no issues are specified, all branches with mapped '
4544 'issues will be listed.')
Stefan Zager1306bd02017-06-22 19:26:46 -07004545 parser.add_option('--json',
4546 help='Path to JSON output file, or "-" for stdout.')
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00004547 _add_codereview_select_options(parser)
dnj@chromium.org406c4402015-03-03 17:22:28 +00004548 options, args = parser.parse_args(args)
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00004549 _process_codereview_select_options(parser, options)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004550
dnj@chromium.org406c4402015-03-03 17:22:28 +00004551 if options.reverse:
4552 branches = RunGit(['for-each-ref', 'refs/heads',
Aaron Gablead64abd2017-12-04 09:49:13 -08004553 '--format=%(refname)']).splitlines()
dnj@chromium.org406c4402015-03-03 17:22:28 +00004554 # Reverse issue lookup.
4555 issue_branch_map = {}
4556 for branch in branches:
4557 cl = Changelist(branchref=branch)
4558 issue_branch_map.setdefault(cl.GetIssue(), []).append(branch)
4559 if not args:
4560 args = sorted(issue_branch_map.iterkeys())
phajdan.jre328cf92016-08-22 04:12:17 -07004561 result = {}
dnj@chromium.org406c4402015-03-03 17:22:28 +00004562 for issue in args:
4563 if not issue:
4564 continue
phajdan.jre328cf92016-08-22 04:12:17 -07004565 result[int(issue)] = issue_branch_map.get(int(issue))
vapiera7fbd5a2016-06-16 09:17:49 -07004566 print('Branch for issue number %s: %s' % (
4567 issue, ', '.join(issue_branch_map.get(int(issue)) or ('None',))))
phajdan.jre328cf92016-08-22 04:12:17 -07004568 if options.json:
4569 write_json(options.json, result)
Aaron Gable78753da2017-06-15 10:35:49 -07004570 return 0
4571
4572 if len(args) > 0:
4573 issue = ParseIssueNumberArgument(args[0], options.forced_codereview)
4574 if not issue.valid:
4575 DieWithError('Pass a url or number to set the issue, 0 to unset it, '
4576 'or no argument to list it.\n'
4577 'Maybe you want to run git cl status?')
4578 cl = Changelist(codereview=issue.codereview)
4579 cl.SetIssue(issue.issue)
dnj@chromium.org406c4402015-03-03 17:22:28 +00004580 else:
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00004581 cl = Changelist(codereview=options.forced_codereview)
Aaron Gable78753da2017-06-15 10:35:49 -07004582 print('Issue number: %s (%s)' % (cl.GetIssue(), cl.GetIssueURL()))
4583 if options.json:
4584 write_json(options.json, {
4585 'issue': cl.GetIssue(),
4586 'issue_url': cl.GetIssueURL(),
4587 })
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004588 return 0
4589
4590
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004591@metrics.collector.collect_metrics('git cl comments')
maruel@chromium.org9977a2e2012-06-06 22:30:56 +00004592def CMDcomments(parser, args):
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00004593 """Shows or posts review comments for any changelist."""
4594 parser.add_option('-a', '--add-comment', dest='comment',
4595 help='comment to add to an issue')
Andrii Shyshkalov0d6b46e2017-03-17 22:23:22 +01004596 parser.add_option('-i', '--issue', dest='issue',
4597 help='review issue id (defaults to current issue). '
4598 'If given, requires --rietveld or --gerrit')
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07004599 parser.add_option('-m', '--machine-readable', dest='readable',
4600 action='store_false', default=True,
4601 help='output comments in a format compatible with '
4602 'editor parsing')
smut@google.comc85ac942015-09-15 16:34:43 +00004603 parser.add_option('-j', '--json-file',
Stefan Zager1306bd02017-06-22 19:26:46 -07004604 help='File to write JSON summary to, or "-" for stdout')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004605 auth.add_auth_options(parser)
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01004606 _add_codereview_select_options(parser)
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00004607 options, args = parser.parse_args(args)
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01004608 _process_codereview_select_options(parser, options)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004609 auth_config = auth.extract_auth_config_from_options(options)
maruel@chromium.org9977a2e2012-06-06 22:30:56 +00004610
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00004611 issue = None
4612 if options.issue:
4613 try:
4614 issue = int(options.issue)
4615 except ValueError:
4616 DieWithError('A review issue id is expected to be a number')
Andrii Shyshkalov0d6b46e2017-03-17 22:23:22 +01004617 if not options.forced_codereview:
4618 parser.error('--gerrit or --rietveld is required if --issue is specified')
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00004619
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01004620 cl = Changelist(issue=issue,
Andrii Shyshkalov70909e12017-04-10 14:38:32 +02004621 codereview=options.forced_codereview,
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01004622 auth_config=auth_config)
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00004623
4624 if options.comment:
4625 cl.AddComment(options.comment)
4626 return 0
4627
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07004628 summary = sorted(cl.GetCommentsSummary(readable=options.readable),
4629 key=lambda c: c.date)
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01004630 for comment in summary:
4631 if comment.disapproval:
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00004632 color = Fore.RED
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01004633 elif comment.approval:
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00004634 color = Fore.GREEN
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01004635 elif comment.sender == cl.GetIssueOwner():
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00004636 color = Fore.MAGENTA
4637 else:
4638 color = Fore.BLUE
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01004639 print('\n%s%s %s%s\n%s' % (
4640 color,
4641 comment.date.strftime('%Y-%m-%d %H:%M:%S UTC'),
4642 comment.sender,
4643 Fore.RESET,
4644 '\n'.join(' ' + l for l in comment.message.strip().splitlines())))
4645
smut@google.comc85ac942015-09-15 16:34:43 +00004646 if options.json_file:
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01004647 def pre_serialize(c):
4648 dct = c.__dict__.copy()
4649 dct['date'] = dct['date'].strftime('%Y-%m-%d %H:%M:%S.%f')
4650 return dct
smut@google.comc85ac942015-09-15 16:34:43 +00004651 with open(options.json_file, 'wb') as f:
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01004652 json.dump(map(pre_serialize, summary), f)
maruel@chromium.org9977a2e2012-06-06 22:30:56 +00004653 return 0
4654
4655
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00004656@subcommand.usage('[codereview url or issue id]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004657@metrics.collector.collect_metrics('git cl description')
rsesek@chromium.orgeec76592013-05-20 16:27:57 +00004658def CMDdescription(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004659 """Brings up the editor for the current CL's description."""
smut@google.com34fb6b12015-07-13 20:03:26 +00004660 parser.add_option('-d', '--display', action='store_true',
4661 help='Display the description instead of opening an editor')
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00004662 parser.add_option('-n', '--new-description',
dnjba1b0f32016-09-02 12:37:42 -07004663 help='New description to set for this issue (- for stdin, '
4664 '+ to load from local commit HEAD)')
dsansomee2d6fd92016-09-08 00:10:47 -07004665 parser.add_option('-f', '--force', action='store_true',
4666 help='Delete any unpublished Gerrit edits for this issue '
4667 'without prompting')
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00004668
4669 _add_codereview_select_options(parser)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004670 auth.add_auth_options(parser)
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00004671 options, args = parser.parse_args(args)
4672 _process_codereview_select_options(parser, options)
4673
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01004674 target_issue_arg = None
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00004675 if len(args) > 0:
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004676 target_issue_arg = ParseIssueNumberArgument(args[0],
4677 options.forced_codereview)
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01004678 if not target_issue_arg.valid:
Andrii Shyshkalov28d840e2017-04-10 15:45:09 +02004679 parser.error('invalid codereview url or CL id')
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00004680
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004681 auth_config = auth.extract_auth_config_from_options(options)
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00004682
martiniss6eda05f2016-06-30 10:18:35 -07004683 kwargs = {
4684 'auth_config': auth_config,
4685 'codereview': options.forced_codereview,
4686 }
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004687 detected_codereview_from_url = False
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01004688 if target_issue_arg:
4689 kwargs['issue'] = target_issue_arg.issue
4690 kwargs['codereview_host'] = target_issue_arg.hostname
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004691 if target_issue_arg.codereview and not options.forced_codereview:
4692 detected_codereview_from_url = True
4693 kwargs['codereview'] = target_issue_arg.codereview
martiniss6eda05f2016-06-30 10:18:35 -07004694
4695 cl = Changelist(**kwargs)
rsesek@chromium.orgeec76592013-05-20 16:27:57 +00004696 if not cl.GetIssue():
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004697 assert not detected_codereview_from_url
rsesek@chromium.orgeec76592013-05-20 16:27:57 +00004698 DieWithError('This branch has no associated changelist.')
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004699
4700 if detected_codereview_from_url:
4701 logging.info('canonical issue/change URL: %s (type: %s)\n',
4702 cl.GetIssueURL(), target_issue_arg.codereview)
4703
rsesek@chromium.orgeec76592013-05-20 16:27:57 +00004704 description = ChangeDescription(cl.GetDescription())
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00004705
smut@google.com34fb6b12015-07-13 20:03:26 +00004706 if options.display:
vapiera7fbd5a2016-06-16 09:17:49 -07004707 print(description.description)
smut@google.com34fb6b12015-07-13 20:03:26 +00004708 return 0
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00004709
4710 if options.new_description:
4711 text = options.new_description
4712 if text == '-':
4713 text = '\n'.join(l.rstrip() for l in sys.stdin)
dnjba1b0f32016-09-02 12:37:42 -07004714 elif text == '+':
4715 base_branch = cl.GetCommonAncestorWithUpstream()
4716 change = cl.GetChange(base_branch, None, local_description=True)
4717 text = change.FullDescriptionText()
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00004718
4719 description.set_description(text)
4720 else:
Aaron Gable3a16ed12017-03-23 10:51:55 -07004721 description.prompt(git_footer=cl.IsGerrit())
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00004722
Andrii Shyshkalov680253d2017-03-15 21:07:36 +01004723 if cl.GetDescription().strip() != description.description:
dsansomee2d6fd92016-09-08 00:10:47 -07004724 cl.UpdateDescription(description.description, force=options.force)
rsesek@chromium.orgeec76592013-05-20 16:27:57 +00004725 return 0
4726
4727
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004728def CreateDescriptionFromLog(args):
4729 """Pulls out the commit log to use as a base for the CL description."""
4730 log_args = []
4731 if len(args) == 1 and not args[0].endswith('.'):
4732 log_args = [args[0] + '..']
4733 elif len(args) == 1 and args[0].endswith('...'):
4734 log_args = [args[0][:-1]]
4735 elif len(args) == 2:
4736 log_args = [args[0] + '..' + args[1]]
4737 else:
4738 log_args = args[:] # Hope for the best!
maruel@chromium.org373af802012-05-25 21:07:33 +00004739 return RunGit(['log', '--pretty=format:%s\n\n%b'] + log_args)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004740
4741
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004742@metrics.collector.collect_metrics('git cl lint')
thestig@chromium.org44202a22014-03-11 19:22:18 +00004743def CMDlint(parser, args):
4744 """Runs cpplint on the current changelist."""
tzik@chromium.orgf204d4b2014-03-13 07:40:55 +00004745 parser.add_option('--filter', action='append', metavar='-x,+y',
4746 help='Comma-separated list of cpplint\'s category-filters')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004747 auth.add_auth_options(parser)
4748 options, args = parser.parse_args(args)
4749 auth_config = auth.extract_auth_config_from_options(options)
thestig@chromium.org44202a22014-03-11 19:22:18 +00004750
4751 # Access to a protected member _XX of a client class
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -08004752 # pylint: disable=protected-access
thestig@chromium.org44202a22014-03-11 19:22:18 +00004753 try:
4754 import cpplint
4755 import cpplint_chromium
4756 except ImportError:
vapiera7fbd5a2016-06-16 09:17:49 -07004757 print('Your depot_tools is missing cpplint.py and/or cpplint_chromium.py.')
thestig@chromium.org44202a22014-03-11 19:22:18 +00004758 return 1
4759
4760 # Change the current working directory before calling lint so that it
4761 # shows the correct base.
4762 previous_cwd = os.getcwd()
4763 os.chdir(settings.GetRoot())
4764 try:
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004765 cl = Changelist(auth_config=auth_config)
thestig@chromium.org44202a22014-03-11 19:22:18 +00004766 change = cl.GetChange(cl.GetCommonAncestorWithUpstream(), None)
4767 files = [f.LocalPath() for f in change.AffectedFiles()]
thestig@chromium.org5839eb52014-05-30 16:20:51 +00004768 if not files:
vapiera7fbd5a2016-06-16 09:17:49 -07004769 print('Cannot lint an empty CL')
thestig@chromium.org5839eb52014-05-30 16:20:51 +00004770 return 1
thestig@chromium.org44202a22014-03-11 19:22:18 +00004771
4772 # Process cpplints arguments if any.
tzik@chromium.orgf204d4b2014-03-13 07:40:55 +00004773 command = args + files
4774 if options.filter:
4775 command = ['--filter=' + ','.join(options.filter)] + command
4776 filenames = cpplint.ParseArguments(command)
thestig@chromium.org44202a22014-03-11 19:22:18 +00004777
4778 white_regex = re.compile(settings.GetLintRegex())
4779 black_regex = re.compile(settings.GetLintIgnoreRegex())
4780 extra_check_functions = [cpplint_chromium.CheckPointerDeclarationWhitespace]
4781 for filename in filenames:
4782 if white_regex.match(filename):
4783 if black_regex.match(filename):
vapiera7fbd5a2016-06-16 09:17:49 -07004784 print('Ignoring file %s' % filename)
thestig@chromium.org44202a22014-03-11 19:22:18 +00004785 else:
4786 cpplint.ProcessFile(filename, cpplint._cpplint_state.verbose_level,
4787 extra_check_functions)
4788 else:
vapiera7fbd5a2016-06-16 09:17:49 -07004789 print('Skipping file %s' % filename)
thestig@chromium.org44202a22014-03-11 19:22:18 +00004790 finally:
4791 os.chdir(previous_cwd)
vapiera7fbd5a2016-06-16 09:17:49 -07004792 print('Total errors found: %d\n' % cpplint._cpplint_state.error_count)
thestig@chromium.org44202a22014-03-11 19:22:18 +00004793 if cpplint._cpplint_state.error_count != 0:
4794 return 1
4795 return 0
4796
4797
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004798@metrics.collector.collect_metrics('git cl presubmit')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004799def CMDpresubmit(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004800 """Runs presubmit tests on the current changelist."""
ilevy@chromium.org375a9022013-01-07 01:12:05 +00004801 parser.add_option('-u', '--upload', action='store_true',
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004802 help='Run upload hook instead of the push hook')
ilevy@chromium.org375a9022013-01-07 01:12:05 +00004803 parser.add_option('-f', '--force', action='store_true',
sbc@chromium.org495ad152012-09-04 23:07:42 +00004804 help='Run checks even if tree is dirty')
Aaron Gable8076c282017-11-29 14:39:41 -08004805 parser.add_option('--all', action='store_true',
4806 help='Run checks against all files, not just modified ones')
Edward Lesmes8e282792018-04-03 18:50:29 -04004807 parser.add_option('--parallel', action='store_true',
4808 help='Run all tests specified by input_api.RunTests in all '
4809 'PRESUBMIT files in parallel.')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004810 auth.add_auth_options(parser)
4811 options, args = parser.parse_args(args)
4812 auth_config = auth.extract_auth_config_from_options(options)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004813
sbc@chromium.org71437c02015-04-09 19:29:40 +00004814 if not options.force and git_common.is_dirty_git_tree('presubmit'):
vapiera7fbd5a2016-06-16 09:17:49 -07004815 print('use --force to check even if tree is dirty.')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004816 return 1
4817
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004818 cl = Changelist(auth_config=auth_config)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004819 if args:
4820 base_branch = args[0]
4821 else:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00004822 # Default to diffing against the common ancestor of the upstream branch.
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00004823 base_branch = cl.GetCommonAncestorWithUpstream()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004824
Aaron Gable8076c282017-11-29 14:39:41 -08004825 if options.all:
4826 base_change = cl.GetChange(base_branch, None)
4827 files = [('M', f) for f in base_change.AllFiles()]
4828 change = presubmit_support.GitChange(
4829 base_change.Name(),
4830 base_change.FullDescriptionText(),
4831 base_change.RepositoryRoot(),
4832 files,
4833 base_change.issue,
4834 base_change.patchset,
4835 base_change.author_email,
4836 base_change._upstream)
4837 else:
4838 change = cl.GetChange(base_branch, None)
4839
ilevy@chromium.org051ad0e2013-03-04 21:57:34 +00004840 cl.RunHook(
4841 committing=not options.upload,
4842 may_prompt=False,
4843 verbose=options.verbose,
Edward Lesmes8e282792018-04-03 18:50:29 -04004844 change=change,
4845 parallel=options.parallel)
dpranke@chromium.org0a2bb372011-03-25 01:16:22 +00004846 return 0
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004847
4848
tandrii@chromium.org65874e12016-03-04 12:03:02 +00004849def GenerateGerritChangeId(message):
4850 """Returns Ixxxxxx...xxx change id.
4851
4852 Works the same way as
4853 https://gerrit-review.googlesource.com/tools/hooks/commit-msg
4854 but can be called on demand on all platforms.
4855
4856 The basic idea is to generate git hash of a state of the tree, original commit
4857 message, author/committer info and timestamps.
4858 """
4859 lines = []
4860 tree_hash = RunGitSilent(['write-tree'])
4861 lines.append('tree %s' % tree_hash.strip())
4862 code, parent = RunGitWithCode(['rev-parse', 'HEAD~0'], suppress_stderr=False)
4863 if code == 0:
4864 lines.append('parent %s' % parent.strip())
4865 author = RunGitSilent(['var', 'GIT_AUTHOR_IDENT'])
4866 lines.append('author %s' % author.strip())
4867 committer = RunGitSilent(['var', 'GIT_COMMITTER_IDENT'])
4868 lines.append('committer %s' % committer.strip())
4869 lines.append('')
4870 # Note: Gerrit's commit-hook actually cleans message of some lines and
4871 # whitespace. This code is not doing this, but it clearly won't decrease
4872 # entropy.
4873 lines.append(message)
4874 change_hash = RunCommand(['git', 'hash-object', '-t', 'commit', '--stdin'],
4875 stdin='\n'.join(lines))
4876 return 'I%s' % change_hash.strip()
4877
4878
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01004879def GetTargetRef(remote, remote_branch, target_branch):
wittman@chromium.org455dc922015-01-26 20:15:50 +00004880 """Computes the remote branch ref to use for the CL.
4881
4882 Args:
4883 remote (str): The git remote for the CL.
4884 remote_branch (str): The git remote branch for the CL.
4885 target_branch (str): The target branch specified by the user.
wittman@chromium.org455dc922015-01-26 20:15:50 +00004886 """
4887 if not (remote and remote_branch):
4888 return None
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00004889
wittman@chromium.org455dc922015-01-26 20:15:50 +00004890 if target_branch:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07004891 # Canonicalize branch references to the equivalent local full symbolic
wittman@chromium.org455dc922015-01-26 20:15:50 +00004892 # refs, which are then translated into the remote full symbolic refs
4893 # below.
4894 if '/' not in target_branch:
4895 remote_branch = 'refs/remotes/%s/%s' % (remote, target_branch)
4896 else:
4897 prefix_replacements = (
4898 ('^((refs/)?remotes/)?branch-heads/', 'refs/remotes/branch-heads/'),
4899 ('^((refs/)?remotes/)?%s/' % remote, 'refs/remotes/%s/' % remote),
4900 ('^(refs/)?heads/', 'refs/remotes/%s/' % remote),
4901 )
4902 match = None
4903 for regex, replacement in prefix_replacements:
4904 match = re.search(regex, target_branch)
4905 if match:
4906 remote_branch = target_branch.replace(match.group(0), replacement)
4907 break
4908 if not match:
4909 # This is a branch path but not one we recognize; use as-is.
4910 remote_branch = target_branch
rmistry@google.comc68112d2015-03-03 12:48:06 +00004911 elif remote_branch in REFS_THAT_ALIAS_TO_OTHER_REFS:
4912 # Handle the refs that need to land in different refs.
4913 remote_branch = REFS_THAT_ALIAS_TO_OTHER_REFS[remote_branch]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00004914
wittman@chromium.org455dc922015-01-26 20:15:50 +00004915 # Create the true path to the remote branch.
4916 # Does the following translation:
4917 # * refs/remotes/origin/refs/diff/test -> refs/diff/test
4918 # * refs/remotes/origin/master -> refs/heads/master
4919 # * refs/remotes/branch-heads/test -> refs/branch-heads/test
4920 if remote_branch.startswith('refs/remotes/%s/refs/' % remote):
4921 remote_branch = remote_branch.replace('refs/remotes/%s/' % remote, '')
4922 elif remote_branch.startswith('refs/remotes/%s/' % remote):
4923 remote_branch = remote_branch.replace('refs/remotes/%s/' % remote,
4924 'refs/heads/')
4925 elif remote_branch.startswith('refs/remotes/branch-heads'):
4926 remote_branch = remote_branch.replace('refs/remotes/', 'refs/')
Andrii Shyshkalov768f1d82016-12-08 15:10:13 +01004927
wittman@chromium.org455dc922015-01-26 20:15:50 +00004928 return remote_branch
4929
4930
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00004931def cleanup_list(l):
4932 """Fixes a list so that comma separated items are put as individual items.
4933
4934 So that "--reviewers joe@c,john@c --reviewers joa@c" results in
4935 options.reviewers == sorted(['joe@c', 'john@c', 'joa@c']).
4936 """
4937 items = sum((i.split(',') for i in l), [])
4938 stripped_items = (i.strip() for i in items)
4939 return sorted(filter(None, stripped_items))
4940
4941
Aaron Gable4db38df2017-11-03 14:59:07 -07004942@subcommand.usage('[flags]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004943@metrics.collector.collect_metrics('git cl upload')
ukai@chromium.orge8077812012-02-03 03:41:46 +00004944def CMDupload(parser, args):
rmistry@google.com78948ed2015-07-08 23:09:57 +00004945 """Uploads the current changelist to codereview.
4946
4947 Can skip dependency patchset uploads for a branch by running:
4948 git config branch.branch_name.skip-deps-uploads True
4949 To unset run:
4950 git config --unset branch.branch_name.skip-deps-uploads
4951 Can also set the above globally by using the --global flag.
Dominic Battre7d1c4842017-10-27 09:17:28 +02004952
4953 If the name of the checked out branch starts with "bug-" or "fix-" followed by
4954 a bug number, this bug number is automatically populated in the CL
4955 description.
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004956
4957 If subject contains text in square brackets or has "<text>: " prefix, such
4958 text(s) is treated as Gerrit hashtags. For example, CLs with subjects
4959 [git-cl] add support for hashtags
4960 Foo bar: implement foo
4961 will be hashtagged with "git-cl" and "foo-bar" respectively.
rmistry@google.com78948ed2015-07-08 23:09:57 +00004962 """
ukai@chromium.orge8077812012-02-03 03:41:46 +00004963 parser.add_option('--bypass-hooks', action='store_true', dest='bypass_hooks',
4964 help='bypass upload presubmit hook')
brettw@chromium.orgb65c43c2013-06-10 22:04:49 +00004965 parser.add_option('--bypass-watchlists', action='store_true',
4966 dest='bypass_watchlists',
4967 help='bypass watchlists auto CC-ing reviewers')
Aaron Gablef7543cd2017-07-20 14:26:31 -07004968 parser.add_option('-f', '--force', action='store_true', dest='force',
ukai@chromium.orge8077812012-02-03 03:41:46 +00004969 help="force yes to questions (don't prompt)")
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004970 parser.add_option('--message', '-m', dest='message',
4971 help='message for patchset')
tandriif9aefb72016-07-01 09:06:51 -07004972 parser.add_option('-b', '--bug',
4973 help='pre-populate the bug number(s) for this issue. '
4974 'If several, separate with commas')
tandriib80458a2016-06-23 12:20:07 -07004975 parser.add_option('--message-file', dest='message_file',
4976 help='file which contains message for patchset')
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004977 parser.add_option('--title', '-t', dest='title',
4978 help='title for patchset')
ukai@chromium.orge8077812012-02-03 03:41:46 +00004979 parser.add_option('-r', '--reviewers',
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00004980 action='append', default=[],
ukai@chromium.orge8077812012-02-03 03:41:46 +00004981 help='reviewer email addresses')
Robert Iannucci6c98dc62017-04-18 11:38:00 -07004982 parser.add_option('--tbrs',
4983 action='append', default=[],
4984 help='TBR email addresses')
ukai@chromium.orge8077812012-02-03 03:41:46 +00004985 parser.add_option('--cc',
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00004986 action='append', default=[],
ukai@chromium.orge8077812012-02-03 03:41:46 +00004987 help='cc email addresses')
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004988 parser.add_option('--hashtag', dest='hashtags',
4989 action='append', default=[],
4990 help=('Gerrit hashtag for new CL; '
4991 'can be applied multiple times'))
adamk@chromium.org36f47302013-04-05 01:08:31 +00004992 parser.add_option('-s', '--send-mail', action='store_true',
Aaron Gable59f48512017-01-12 10:54:46 -08004993 help='send email to reviewer(s) and cc(s) immediately')
pgervais@chromium.orgb9f27512014-08-08 15:52:33 +00004994 parser.add_option('--emulate_svn_auto_props',
4995 '--emulate-svn-auto-props',
4996 action="store_true",
ukai@chromium.orge8077812012-02-03 03:41:46 +00004997 dest="emulate_svn_auto_props",
4998 help="Emulate Subversion's auto properties feature.")
ukai@chromium.orge8077812012-02-03 03:41:46 +00004999 parser.add_option('-c', '--use-commit-queue', action='store_true',
Aaron Gableedbc4132017-09-11 13:22:28 -07005000 help='tell the commit queue to commit this patchset; '
5001 'implies --send-mail')
ukai@chromium.org8ef7ab22012-11-28 04:24:52 +00005002 parser.add_option('--target_branch',
pgervais@chromium.orgb9f27512014-08-08 15:52:33 +00005003 '--target-branch',
wittman@chromium.org455dc922015-01-26 20:15:50 +00005004 metavar='TARGET',
5005 help='Apply CL to remote ref TARGET. ' +
5006 'Default: remote branch head, or master')
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00005007 parser.add_option('--squash', action='store_true',
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08005008 help='Squash multiple commits into one')
bauerb@chromium.org54b400c2016-01-14 10:08:25 +00005009 parser.add_option('--no-squash', action='store_true',
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08005010 help='Don\'t squash multiple commits into one')
rmistry9eadede2016-09-19 11:22:43 -07005011 parser.add_option('--topic', default=None,
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08005012 help='Topic to specify when uploading')
Robert Iannuccif2708bd2017-04-17 15:49:02 -07005013 parser.add_option('--tbr-owners', dest='add_owners_to', action='store_const',
5014 const='TBR', help='add a set of OWNERS to TBR')
5015 parser.add_option('--r-owners', dest='add_owners_to', action='store_const',
5016 const='R', help='add a set of OWNERS to R')
tandrii@chromium.orgd50452a2015-11-23 16:38:15 +00005017 parser.add_option('-d', '--cq-dry-run', dest='cq_dry_run',
5018 action='store_true',
rmistry@google.comef966222015-04-07 11:15:01 +00005019 help='Send the patchset to do a CQ dry run right after '
5020 'upload.')
rmistry@google.com2dd99862015-06-22 12:22:18 +00005021 parser.add_option('--dependencies', action='store_true',
5022 help='Uploads CLs of all the local branches that depend on '
5023 'the current branch')
Ravi Mistry31e7d562018-04-02 12:53:57 -04005024 parser.add_option('-a', '--enable-auto-submit', action='store_true',
5025 help='Sends your change to the CQ after an approval. Only '
5026 'works on repos that have the Auto-Submit label '
5027 'enabled')
Edward Lesmes8e282792018-04-03 18:50:29 -04005028 parser.add_option('--parallel', action='store_true',
5029 help='Run all tests specified by input_api.RunTests in all '
5030 'PRESUBMIT files in parallel.')
pgervais@chromium.org91141372014-01-09 23:27:20 +00005031
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08005032 # TODO: remove Rietveld flags
5033 parser.add_option('--private', action='store_true',
5034 help='set the review private (rietveld only)')
5035 parser.add_option('--email', default=None,
5036 help='email address to use to connect to Rietveld')
5037
rmistry@google.com2dd99862015-06-22 12:22:18 +00005038 orig_args = args
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00005039 auth.add_auth_options(parser)
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00005040 _add_codereview_select_options(parser)
ukai@chromium.orge8077812012-02-03 03:41:46 +00005041 (options, args) = parser.parse_args(args)
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00005042 _process_codereview_select_options(parser, options)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00005043 auth_config = auth.extract_auth_config_from_options(options)
ukai@chromium.orge8077812012-02-03 03:41:46 +00005044
sbc@chromium.org71437c02015-04-09 19:29:40 +00005045 if git_common.is_dirty_git_tree('upload'):
ukai@chromium.orge8077812012-02-03 03:41:46 +00005046 return 1
5047
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00005048 options.reviewers = cleanup_list(options.reviewers)
Robert Iannucci6c98dc62017-04-18 11:38:00 -07005049 options.tbrs = cleanup_list(options.tbrs)
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00005050 options.cc = cleanup_list(options.cc)
5051
tandriib80458a2016-06-23 12:20:07 -07005052 if options.message_file:
5053 if options.message:
5054 parser.error('only one of --message and --message-file allowed.')
5055 options.message = gclient_utils.FileRead(options.message_file)
5056 options.message_file = None
5057
tandrii4d0545a2016-07-06 03:56:49 -07005058 if options.cq_dry_run and options.use_commit_queue:
5059 parser.error('only one of --use-commit-queue and --cq-dry-run allowed.')
5060
Aaron Gableedbc4132017-09-11 13:22:28 -07005061 if options.use_commit_queue:
5062 options.send_mail = True
5063
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00005064 # For sanity of test expectations, do this otherwise lazy-loading *now*.
5065 settings.GetIsGerrit()
5066
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00005067 cl = Changelist(auth_config=auth_config, codereview=options.forced_codereview)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00005068 return cl.CMDUpload(options, args, orig_args)
ukai@chromium.orge8077812012-02-03 03:41:46 +00005069
5070
Francois Dorayd42c6812017-05-30 15:10:20 -04005071@subcommand.usage('--description=<description file>')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005072@metrics.collector.collect_metrics('git cl split')
Francois Dorayd42c6812017-05-30 15:10:20 -04005073def CMDsplit(parser, args):
5074 """Splits a branch into smaller branches and uploads CLs.
5075
5076 Creates a branch and uploads a CL for each group of files modified in the
5077 current branch that share a common OWNERS file. In the CL description and
Quinten Yearsley0c62da92017-05-31 13:39:42 -07005078 comment, the string '$directory', is replaced with the directory containing
Francois Dorayd42c6812017-05-30 15:10:20 -04005079 the shared OWNERS file.
5080 """
5081 parser.add_option("-d", "--description", dest="description_file",
Gabriel Charette02b5ee82017-11-08 16:36:05 -05005082 help="A text file containing a CL description in which "
5083 "$directory will be replaced by each CL's directory.")
Francois Dorayd42c6812017-05-30 15:10:20 -04005084 parser.add_option("-c", "--comment", dest="comment_file",
5085 help="A text file containing a CL comment.")
Chris Watkinsba28e462017-12-13 11:22:17 +11005086 parser.add_option("-n", "--dry-run", dest="dry_run", action='store_true',
5087 default=False,
5088 help="List the files and reviewers for each CL that would "
5089 "be created, but don't create branches or CLs.")
Francois Dorayd42c6812017-05-30 15:10:20 -04005090 options, _ = parser.parse_args(args)
5091
5092 if not options.description_file:
5093 parser.error('No --description flag specified.')
5094
5095 def WrappedCMDupload(args):
5096 return CMDupload(OptionParser(), args)
5097
5098 return split_cl.SplitCl(options.description_file, options.comment_file,
Chris Watkinsba28e462017-12-13 11:22:17 +11005099 Changelist, WrappedCMDupload, options.dry_run)
Francois Dorayd42c6812017-05-30 15:10:20 -04005100
5101
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08005102@subcommand.usage('DEPRECATED')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005103@metrics.collector.collect_metrics('git cl commit')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005104def CMDdcommit(parser, args):
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08005105 """DEPRECATED: Used to commit the current changelist via git-svn."""
5106 message = ('git-cl no longer supports committing to SVN repositories via '
5107 'git-svn. You probably want to use `git cl land` instead.')
5108 print(message)
5109 return 1
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005110
5111
Andrii Shyshkalovaa31b972017-03-24 16:16:33 +01005112# Two special branches used by git cl land.
5113MERGE_BRANCH = 'git-cl-commit'
5114CHERRY_PICK_BRANCH = 'git-cl-cherry-pick'
5115
5116
maruel@chromium.org0633fb42013-08-16 20:06:14 +00005117@subcommand.usage('[upstream branch to apply against]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005118@metrics.collector.collect_metrics('git cl land')
pgervais@chromium.orgcee6dc42014-05-07 17:04:03 +00005119def CMDland(parser, args):
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08005120 """Commits the current changelist via git.
5121
5122 In case of Gerrit, uses Gerrit REST api to "submit" the issue, which pushes
5123 upstream and closes the issue automatically and atomically.
5124
5125 Otherwise (in case of Rietveld):
5126 Squashes branch into a single commit.
5127 Updates commit message with metadata (e.g. pointer to review).
5128 Pushes the code upstream.
5129 Updates review and closes.
5130 """
5131 parser.add_option('--bypass-hooks', action='store_true', dest='bypass_hooks',
5132 help='bypass upload presubmit hook')
5133 parser.add_option('-m', dest='message',
5134 help="override review description")
Aaron Gablef7543cd2017-07-20 14:26:31 -07005135 parser.add_option('-f', '--force', action='store_true', dest='force',
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08005136 help="force yes to questions (don't prompt)")
5137 parser.add_option('-c', dest='contributor',
5138 help="external contributor for patch (appended to " +
5139 "description and used as author for git). Should be " +
5140 "formatted as 'First Last <email@example.com>'")
Edward Lesmes67b3faa2018-04-13 17:50:52 -04005141 parser.add_option('--parallel', action='store_true',
5142 help='Run all tests specified by input_api.RunTests in all '
5143 'PRESUBMIT files in parallel.')
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08005144 auth.add_auth_options(parser)
5145 (options, args) = parser.parse_args(args)
5146 auth_config = auth.extract_auth_config_from_options(options)
5147
5148 cl = Changelist(auth_config=auth_config)
5149
Robert Iannucci2e73d432018-03-14 01:10:47 -07005150 if not cl.IsGerrit():
5151 parser.error('rietveld is not supported')
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08005152
Robert Iannucci2e73d432018-03-14 01:10:47 -07005153 if options.message:
5154 # This could be implemented, but it requires sending a new patch to
5155 # Gerrit, as Gerrit unlike Rietveld versions messages with patchsets.
5156 # Besides, Gerrit has the ability to change the commit message on submit
5157 # automatically, thus there is no need to support this option (so far?).
5158 parser.error('-m MESSAGE option is not supported for Gerrit.')
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08005159 if options.contributor:
Robert Iannucci2e73d432018-03-14 01:10:47 -07005160 parser.error(
5161 '-c CONTRIBUTOR option is not supported for Gerrit.\n'
5162 'Before uploading a commit to Gerrit, ensure it\'s author field is '
5163 'the contributor\'s "name <email>". If you can\'t upload such a '
5164 'commit for review, contact your repository admin and request'
5165 '"Forge-Author" permission.')
5166 if not cl.GetIssue():
5167 DieWithError('You must upload the change first to Gerrit.\n'
5168 ' If you would rather have `git cl land` upload '
5169 'automatically for you, see http://crbug.com/642759')
5170 return cl._codereview_impl.CMDLand(options.force, options.bypass_hooks,
Olivier Robin75ee7252018-04-13 10:02:56 +02005171 options.verbose, options.parallel)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005172
5173
Andrii Shyshkalovaa31b972017-03-24 16:16:33 +01005174def PushToGitWithAutoRebase(remote, branch, original_description,
5175 git_numberer_enabled, max_attempts=3):
5176 """Pushes current HEAD commit on top of remote's branch.
5177
5178 Attempts to fetch and autorebase on push failures.
5179 Adds git number footers on the fly.
5180
5181 Returns integer code from last command.
5182 """
5183 cherry = RunGit(['rev-parse', 'HEAD']).strip()
5184 code = 0
5185 attempts_left = max_attempts
5186 while attempts_left:
5187 attempts_left -= 1
5188 print('Attempt %d of %d' % (max_attempts - attempts_left, max_attempts))
5189
5190 # Fetch remote/branch into local cherry_pick_branch, overriding the latter.
5191 # If fetch fails, retry.
5192 print('Fetching %s/%s...' % (remote, branch))
5193 code, out = RunGitWithCode(
5194 ['retry', 'fetch', remote,
5195 '+%s:refs/heads/%s' % (branch, CHERRY_PICK_BRANCH)])
5196 if code:
5197 print('Fetch failed with exit code %d.' % code)
5198 print(out.strip())
5199 continue
5200
5201 print('Cherry-picking commit on top of latest %s' % branch)
5202 RunGitWithCode(['checkout', 'refs/heads/%s' % CHERRY_PICK_BRANCH],
5203 suppress_stderr=True)
5204 parent_hash = RunGit(['rev-parse', 'HEAD']).strip()
5205 code, out = RunGitWithCode(['cherry-pick', cherry])
5206 if code:
5207 print('Your patch doesn\'t apply cleanly to \'%s\' HEAD @ %s, '
5208 'the following files have merge conflicts:' %
5209 (branch, parent_hash))
Aaron Gable7817f022017-12-12 09:43:17 -08005210 print(RunGit(['-c', 'core.quotePath=false', 'diff',
5211 '--name-status', '--diff-filter=U']).strip())
Andrii Shyshkalovaa31b972017-03-24 16:16:33 +01005212 print('Please rebase your patch and try again.')
5213 RunGitWithCode(['cherry-pick', '--abort'])
5214 break
5215
5216 commit_desc = ChangeDescription(original_description)
5217 if git_numberer_enabled:
5218 logging.debug('Adding git number footers')
5219 parent_msg = RunGit(['show', '-s', '--format=%B', parent_hash]).strip()
5220 commit_desc.update_with_git_number_footers(parent_hash, parent_msg,
5221 branch)
5222 # Ensure timestamps are monotonically increasing.
5223 timestamp = max(1 + _get_committer_timestamp(parent_hash),
5224 _get_committer_timestamp('HEAD'))
5225 _git_amend_head(commit_desc.description, timestamp)
5226
5227 code, out = RunGitWithCode(
5228 ['push', '--porcelain', remote, 'HEAD:%s' % branch])
5229 print(out)
5230 if code == 0:
5231 break
5232 if IsFatalPushFailure(out):
5233 print('Fatal push error. Make sure your .netrc credentials and git '
Andrii Shyshkalov9d932212017-04-10 14:28:23 +02005234 'user.email are correct and you have push access to the repo.\n'
5235 'Hint: run command below to diangose common Git/Gerrit credential '
5236 'problems:\n'
5237 ' git cl creds-check\n')
Andrii Shyshkalovaa31b972017-03-24 16:16:33 +01005238 break
5239 return code
5240
5241
5242def IsFatalPushFailure(push_stdout):
5243 """True if retrying push won't help."""
5244 return '(prohibited by Gerrit)' in push_stdout
5245
5246
dsinclair@chromium.orgfbed6562015-09-25 21:22:36 +00005247@subcommand.usage('<patch url or issue id or issue url>')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005248@metrics.collector.collect_metrics('git cl patch')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005249def CMDpatch(parser, args):
marq@chromium.orge5e59002013-10-02 23:21:25 +00005250 """Patches in a code review."""
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005251 parser.add_option('-b', dest='newbranch',
5252 help='create a new branch off trunk for the patch')
qsr@chromium.org1ef44af2013-10-16 16:24:32 +00005253 parser.add_option('-f', '--force', action='store_true',
Aaron Gable62619a32017-06-16 08:22:09 -07005254 help='overwrite state on the current or chosen branch')
qsr@chromium.org1ef44af2013-10-16 16:24:32 +00005255 parser.add_option('-d', '--directory', action='store', metavar='DIR',
Aaron Gable62619a32017-06-16 08:22:09 -07005256 help='change to the directory DIR immediately, '
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00005257 'before doing anything else. Rietveld only.')
qsr@chromium.org1ef44af2013-10-16 16:24:32 +00005258 parser.add_option('--reject', action='store_true',
tapted@chromium.org6a0b07c2013-07-10 01:29:19 +00005259 help='failed patches spew .rej files rather than '
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00005260 'attempting a 3-way merge. Rietveld only.')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005261 parser.add_option('-n', '--no-commit', action='store_true', dest='nocommit',
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00005262 help='don\'t commit after patch applies. Rietveld only.')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00005263
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00005264
5265 group = optparse.OptionGroup(
5266 parser,
5267 'Options for continuing work on the current issue uploaded from a '
5268 'different clone (e.g. different machine). Must be used independently '
5269 'from the other options. No issue number should be specified, and the '
5270 'branch must have an issue number associated with it')
5271 group.add_option('--reapply', action='store_true', dest='reapply',
5272 help='Reset the branch and reapply the issue.\n'
5273 'CAUTION: This will undo any local changes in this '
5274 'branch')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00005275
5276 group.add_option('--pull', action='store_true', dest='pull',
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00005277 help='Performs a pull before reapplying.')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00005278 parser.add_option_group(group)
5279
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00005280 auth.add_auth_options(parser)
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00005281 _add_codereview_select_options(parser)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005282 (options, args) = parser.parse_args(args)
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00005283 _process_codereview_select_options(parser, options)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00005284 auth_config = auth.extract_auth_config_from_options(options)
5285
Andrii Shyshkalov18975322017-01-25 16:44:13 +01005286 if options.reapply:
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00005287 if options.newbranch:
5288 parser.error('--reapply works on the current branch only')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00005289 if len(args) > 0:
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00005290 parser.error('--reapply implies no additional arguments')
dsinclair@chromium.orgfbed6562015-09-25 21:22:36 +00005291
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00005292 cl = Changelist(auth_config=auth_config,
5293 codereview=options.forced_codereview)
5294 if not cl.GetIssue():
5295 parser.error('current branch must have an associated issue')
5296
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00005297 upstream = cl.GetUpstreamBranch()
Andrii Shyshkalov18975322017-01-25 16:44:13 +01005298 if upstream is None:
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00005299 parser.error('No upstream branch specified. Cannot reset branch')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00005300
5301 RunGit(['reset', '--hard', upstream])
5302 if options.pull:
5303 RunGit(['pull'])
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00005304
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00005305 return cl.CMDPatchIssue(cl.GetIssue(), options.reject, options.nocommit,
5306 options.directory)
5307
5308 if len(args) != 1 or not args[0]:
5309 parser.error('Must specify issue number or url')
5310
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02005311 target_issue_arg = ParseIssueNumberArgument(args[0],
5312 options.forced_codereview)
5313 if not target_issue_arg.valid:
5314 parser.error('invalid codereview url or CL id')
5315
5316 cl_kwargs = {
5317 'auth_config': auth_config,
5318 'codereview_host': target_issue_arg.hostname,
5319 'codereview': options.forced_codereview,
5320 }
5321 detected_codereview_from_url = False
5322 if target_issue_arg.codereview and not options.forced_codereview:
5323 detected_codereview_from_url = True
5324 cl_kwargs['codereview'] = target_issue_arg.codereview
5325 cl_kwargs['issue'] = target_issue_arg.issue
5326
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00005327 # We don't want uncommitted changes mixed up with the patch.
5328 if git_common.is_dirty_git_tree('patch'):
dsinclair@chromium.orgfbed6562015-09-25 21:22:36 +00005329 return 1
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005330
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00005331 if options.newbranch:
5332 if options.force:
5333 RunGit(['branch', '-D', options.newbranch],
5334 stderr=subprocess2.PIPE, error_ok=True)
5335 RunGit(['new-branch', options.newbranch])
5336
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02005337 cl = Changelist(**cl_kwargs)
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00005338
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00005339 if cl.IsGerrit():
5340 if options.reject:
5341 parser.error('--reject is not supported with Gerrit codereview.')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00005342 if options.directory:
5343 parser.error('--directory is not supported with Gerrit codereview.')
5344
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02005345 if detected_codereview_from_url:
5346 print('canonical issue/change URL: %s (type: %s)\n' %
5347 (cl.GetIssueURL(), target_issue_arg.codereview))
5348
5349 return cl.CMDPatchWithParsedIssue(target_issue_arg, options.reject,
Aaron Gable62619a32017-06-16 08:22:09 -07005350 options.nocommit, options.directory,
5351 options.force)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005352
5353
jochen@chromium.org3ec0d542014-01-14 20:00:03 +00005354def GetTreeStatus(url=None):
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005355 """Fetches the tree status and returns either 'open', 'closed',
5356 'unknown' or 'unset'."""
jochen@chromium.org3ec0d542014-01-14 20:00:03 +00005357 url = url or settings.GetTreeStatusUrl(error_ok=True)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005358 if url:
5359 status = urllib2.urlopen(url).read().lower()
5360 if status.find('closed') != -1 or status == '0':
5361 return 'closed'
5362 elif status.find('open') != -1 or status == '1':
5363 return 'open'
5364 return 'unknown'
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005365 return 'unset'
5366
dpranke@chromium.org970c5222011-03-12 00:32:24 +00005367
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005368def GetTreeStatusReason():
5369 """Fetches the tree status from a json url and returns the message
5370 with the reason for the tree to be opened or closed."""
msb@chromium.orgbf1a7ba2011-02-01 16:21:46 +00005371 url = settings.GetTreeStatusUrl()
5372 json_url = urlparse.urljoin(url, '/current?format=json')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005373 connection = urllib2.urlopen(json_url)
5374 status = json.loads(connection.read())
5375 connection.close()
5376 return status['message']
5377
dpranke@chromium.org970c5222011-03-12 00:32:24 +00005378
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005379@metrics.collector.collect_metrics('git cl tree')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005380def CMDtree(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005381 """Shows the status of the tree."""
dpranke@chromium.org97ae58e2011-03-18 00:29:20 +00005382 _, args = parser.parse_args(args)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005383 status = GetTreeStatus()
5384 if 'unset' == status:
vapiera7fbd5a2016-06-16 09:17:49 -07005385 print('You must configure your tree status URL by running "git cl config".')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005386 return 2
5387
vapiera7fbd5a2016-06-16 09:17:49 -07005388 print('The tree is %s' % status)
5389 print()
5390 print(GetTreeStatusReason())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005391 if status != 'open':
5392 return 1
5393 return 0
5394
5395
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005396@metrics.collector.collect_metrics('git cl try')
maruel@chromium.org15192402012-09-06 12:38:29 +00005397def CMDtry(parser, args):
qyearsley1fdfcb62016-10-24 13:22:03 -07005398 """Triggers try jobs using either BuildBucket or CQ dry run."""
tandrii1838bad2016-10-06 00:10:52 -07005399 group = optparse.OptionGroup(parser, 'Try job options')
maruel@chromium.org15192402012-09-06 12:38:29 +00005400 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07005401 '-b', '--bot', action='append',
5402 help=('IMPORTANT: specify ONE builder per --bot flag. Use it multiple '
5403 'times to specify multiple builders. ex: '
5404 '"-b win_rel -b win_layout". See '
5405 'the try server waterfall for the builders name and the tests '
5406 'available.'))
maruel@chromium.org15192402012-09-06 12:38:29 +00005407 group.add_option(
borenet6c0efe62016-10-19 08:13:29 -07005408 '-B', '--bucket', default='',
5409 help=('Buildbucket bucket to send the try requests.'))
5410 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07005411 '-m', '--master', default='',
Nodir Turakulovf6929a12017-10-09 12:34:44 -07005412 help=('DEPRECATED, use -B. The try master where to run the builds.'))
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00005413 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07005414 '-r', '--revision',
tandriif7b29d42016-10-07 08:45:41 -07005415 help='Revision to use for the try job; default: the revision will '
5416 'be determined by the try recipe that builder runs, which usually '
5417 'defaults to HEAD of origin/master')
maruel@chromium.org15192402012-09-06 12:38:29 +00005418 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07005419 '-c', '--clobber', action='store_true', default=False,
tandriif7b29d42016-10-07 08:45:41 -07005420 help='Force a clobber before building; that is don\'t do an '
tandrii1838bad2016-10-06 00:10:52 -07005421 'incremental build')
maruel@chromium.org15192402012-09-06 12:38:29 +00005422 group.add_option(
Andrii Shyshkalovf9648b52018-02-21 22:32:42 -08005423 '--category', default='git_cl_try', help='Specify custom build category.')
5424 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07005425 '--project',
5426 help='Override which project to use. Projects are defined '
tandriif7b29d42016-10-07 08:45:41 -07005427 'in recipe to determine to which repository or directory to '
5428 'apply the patch')
maruel@chromium.org15192402012-09-06 12:38:29 +00005429 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07005430 '-p', '--property', dest='properties', action='append', default=[],
5431 help='Specify generic properties in the form -p key1=value1 -p '
tandriif7b29d42016-10-07 08:45:41 -07005432 'key2=value2 etc. The value will be treated as '
5433 'json if decodable, or as string otherwise. '
5434 'NOTE: using this may make your try job not usable for CQ, '
5435 'which will then schedule another try job with default properties')
sheyang@chromium.orgdb375572015-08-17 19:22:23 +00005436 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07005437 '--buildbucket-host', default='cr-buildbucket.appspot.com',
5438 help='Host of buildbucket. The default host is %default.')
maruel@chromium.org15192402012-09-06 12:38:29 +00005439 parser.add_option_group(group)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00005440 auth.add_auth_options(parser)
Koji Ishii31c14782018-01-08 17:17:33 +09005441 _add_codereview_issue_select_options(parser)
maruel@chromium.org15192402012-09-06 12:38:29 +00005442 options, args = parser.parse_args(args)
Koji Ishii31c14782018-01-08 17:17:33 +09005443 _process_codereview_issue_select_options(parser, options)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00005444 auth_config = auth.extract_auth_config_from_options(options)
maruel@chromium.org15192402012-09-06 12:38:29 +00005445
Nodir Turakulovf6929a12017-10-09 12:34:44 -07005446 if options.master and options.master.startswith('luci.'):
5447 parser.error(
5448 '-m option does not support LUCI. Please pass -B %s' % options.master)
machenbach@chromium.org45453142015-09-15 08:45:22 +00005449 # Make sure that all properties are prop=value pairs.
5450 bad_params = [x for x in options.properties if '=' not in x]
5451 if bad_params:
5452 parser.error('Got properties with missing "=": %s' % bad_params)
5453
maruel@chromium.org15192402012-09-06 12:38:29 +00005454 if args:
5455 parser.error('Unknown arguments: %s' % args)
5456
Koji Ishii31c14782018-01-08 17:17:33 +09005457 cl = Changelist(auth_config=auth_config, issue=options.issue,
5458 codereview=options.forced_codereview)
maruel@chromium.org15192402012-09-06 12:38:29 +00005459 if not cl.GetIssue():
5460 parser.error('Need to upload first')
5461
Andrii Shyshkaloveadad922017-01-26 09:38:30 +01005462 if cl.IsGerrit():
5463 # HACK: warm up Gerrit change detail cache to save on RPCs.
5464 cl._codereview_impl._GetChangeDetail(['DETAILED_ACCOUNTS', 'ALL_REVISIONS'])
5465
tandriie113dfd2016-10-11 10:20:12 -07005466 error_message = cl.CannotTriggerTryJobReason()
5467 if error_message:
qyearsley99e2cdf2016-10-23 12:51:41 -07005468 parser.error('Can\'t trigger try jobs: %s' % error_message)
jrobbins@chromium.org16f10f72014-06-24 22:14:36 +00005469
borenet6c0efe62016-10-19 08:13:29 -07005470 if options.bucket and options.master:
5471 parser.error('Only one of --bucket and --master may be used.')
5472
qyearsley1fdfcb62016-10-24 13:22:03 -07005473 buckets = _get_bucket_map(cl, options, parser)
phajdan.jr@chromium.org8da7f272014-03-14 01:28:39 +00005474
qyearsleydd49f942016-10-28 11:57:22 -07005475 # If no bots are listed and we couldn't get a list based on PRESUBMIT files,
5476 # then we default to triggering a CQ dry run (see http://crbug.com/625697).
qyearsley1fdfcb62016-10-24 13:22:03 -07005477 if not buckets:
qyearsley1fdfcb62016-10-24 13:22:03 -07005478 if options.verbose:
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07005479 print('git cl try with no bots now defaults to CQ dry run.')
5480 print('Scheduling CQ dry run on: %s' % cl.GetIssueURL())
5481 return cl.SetCQState(_CQState.DRY_RUN)
stip@chromium.org43064fd2013-12-18 20:07:44 +00005482
borenet6c0efe62016-10-19 08:13:29 -07005483 for builders in buckets.itervalues():
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00005484 if any('triggered' in b for b in builders):
vapiera7fbd5a2016-06-16 09:17:49 -07005485 print('ERROR You are trying to send a job to a triggered bot. This type '
tandriide281ae2016-10-12 06:02:30 -07005486 'of bot requires an initial job from a parent (usually a builder). '
5487 'Instead send your job to the parent.\n'
vapiera7fbd5a2016-06-16 09:17:49 -07005488 'Bot list: %s' % builders, file=sys.stderr)
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00005489 return 1
ilevy@chromium.orgf3b21232012-09-24 20:48:55 +00005490
ilevy@chromium.org36e420b2013-08-06 23:21:12 +00005491 patchset = cl.GetMostRecentPatchset()
Ravi Mistryfda50ca2016-11-14 10:19:18 -05005492 # TODO(tandrii): Checking local patchset against remote patchset is only
5493 # supported for Rietveld. Extend it to Gerrit or remove it completely.
5494 if not cl.IsGerrit() and patchset != cl.GetPatchset():
tandriide281ae2016-10-12 06:02:30 -07005495 print('Warning: Codereview server has newer patchsets (%s) than most '
5496 'recent upload from local checkout (%s). Did a previous upload '
5497 'fail?\n'
5498 'By default, git cl try uses the latest patchset from '
5499 'codereview, continuing to use patchset %s.\n' %
5500 (patchset, cl.GetPatchset(), patchset))
qyearsley1fdfcb62016-10-24 13:22:03 -07005501
tandrii568043b2016-10-11 07:49:18 -07005502 try:
Andrii Shyshkalovf9648b52018-02-21 22:32:42 -08005503 _trigger_try_jobs(auth_config, cl, buckets, options, patchset)
tandrii568043b2016-10-11 07:49:18 -07005504 except BuildbucketResponseException as ex:
5505 print('ERROR: %s' % ex)
5506 return 1
maruel@chromium.org15192402012-09-06 12:38:29 +00005507 return 0
5508
5509
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005510@metrics.collector.collect_metrics('git cl try-results')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00005511def CMDtry_results(parser, args):
tandrii1838bad2016-10-06 00:10:52 -07005512 """Prints info about try jobs associated with current CL."""
5513 group = optparse.OptionGroup(parser, 'Try job results options')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00005514 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07005515 '-p', '--patchset', type=int, help='patchset number if not current.')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00005516 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07005517 '--print-master', action='store_true', help='print master name as well.')
tandrii@chromium.org6cf98c82016-03-15 11:56:00 +00005518 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07005519 '--color', action='store_true', default=setup_color.IS_TTY,
5520 help='force color output, useful when piping output.')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00005521 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07005522 '--buildbucket-host', default='cr-buildbucket.appspot.com',
5523 help='Host of buildbucket. The default host is %default.')
qyearsley53f48a12016-09-01 10:45:13 -07005524 group.add_option(
Stefan Zager1306bd02017-06-22 19:26:46 -07005525 '--json', help=('Path of JSON output file to write try job results to,'
5526 'or "-" for stdout.'))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00005527 parser.add_option_group(group)
5528 auth.add_auth_options(parser)
Stefan Zager27db3f22017-10-10 15:15:01 -07005529 _add_codereview_issue_select_options(parser)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00005530 options, args = parser.parse_args(args)
Stefan Zager27db3f22017-10-10 15:15:01 -07005531 _process_codereview_issue_select_options(parser, options)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00005532 if args:
5533 parser.error('Unrecognized args: %s' % ' '.join(args))
5534
5535 auth_config = auth.extract_auth_config_from_options(options)
Stefan Zager27db3f22017-10-10 15:15:01 -07005536 cl = Changelist(
5537 issue=options.issue, codereview=options.forced_codereview,
5538 auth_config=auth_config)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00005539 if not cl.GetIssue():
5540 parser.error('Need to upload first')
5541
tandrii221ab252016-10-06 08:12:04 -07005542 patchset = options.patchset
5543 if not patchset:
5544 patchset = cl.GetMostRecentPatchset()
5545 if not patchset:
5546 parser.error('Codereview doesn\'t know about issue %s. '
5547 'No access to issue or wrong issue number?\n'
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01005548 'Either upload first, or pass --patchset explicitly' %
tandrii221ab252016-10-06 08:12:04 -07005549 cl.GetIssue())
5550
Ravi Mistryfda50ca2016-11-14 10:19:18 -05005551 # TODO(tandrii): Checking local patchset against remote patchset is only
5552 # supported for Rietveld. Extend it to Gerrit or remove it completely.
5553 if not cl.IsGerrit() and patchset != cl.GetPatchset():
tandrii45b2a582016-10-11 03:14:16 -07005554 print('Warning: Codereview server has newer patchsets (%s) than most '
5555 'recent upload from local checkout (%s). Did a previous upload '
5556 'fail?\n'
tandriide281ae2016-10-12 06:02:30 -07005557 'By default, git cl try-results uses the latest patchset from '
5558 'codereview, continuing to use patchset %s.\n' %
tandrii45b2a582016-10-11 03:14:16 -07005559 (patchset, cl.GetPatchset(), patchset))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00005560 try:
tandrii221ab252016-10-06 08:12:04 -07005561 jobs = fetch_try_jobs(auth_config, cl, options.buildbucket_host, patchset)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00005562 except BuildbucketResponseException as ex:
vapiera7fbd5a2016-06-16 09:17:49 -07005563 print('Buildbucket error: %s' % ex)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00005564 return 1
qyearsley53f48a12016-09-01 10:45:13 -07005565 if options.json:
5566 write_try_results_json(options.json, jobs)
5567 else:
5568 print_try_jobs(options, jobs)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00005569 return 0
5570
5571
maruel@chromium.org0633fb42013-08-16 20:06:14 +00005572@subcommand.usage('[new upstream branch]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005573@metrics.collector.collect_metrics('git cl upstream')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005574def CMDupstream(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005575 """Prints or sets the name of the upstream branch, if any."""
dpranke@chromium.org97ae58e2011-03-18 00:29:20 +00005576 _, args = parser.parse_args(args)
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00005577 if len(args) > 1:
maruel@chromium.org27bb3872011-05-30 20:33:19 +00005578 parser.error('Unrecognized args: %s' % ' '.join(args))
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00005579
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005580 cl = Changelist()
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00005581 if args:
5582 # One arg means set upstream branch.
bauerb@chromium.orgc9cf90a2014-04-28 20:32:31 +00005583 branch = cl.GetBranch()
stip7a3dd352016-09-22 17:32:28 -07005584 RunGit(['branch', '--set-upstream-to', args[0], branch])
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00005585 cl = Changelist()
vapiera7fbd5a2016-06-16 09:17:49 -07005586 print('Upstream branch set to %s' % (cl.GetUpstreamBranch(),))
bauerb@chromium.orgc9cf90a2014-04-28 20:32:31 +00005587
5588 # Clear configured merge-base, if there is one.
5589 git_common.remove_merge_base(branch)
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00005590 else:
vapiera7fbd5a2016-06-16 09:17:49 -07005591 print(cl.GetUpstreamBranch())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005592 return 0
5593
5594
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005595@metrics.collector.collect_metrics('git cl web')
thestig@chromium.org00858c82013-12-02 23:08:03 +00005596def CMDweb(parser, args):
5597 """Opens the current CL in the web browser."""
5598 _, args = parser.parse_args(args)
5599 if args:
5600 parser.error('Unrecognized args: %s' % ' '.join(args))
5601
5602 issue_url = Changelist().GetIssueURL()
5603 if not issue_url:
vapiera7fbd5a2016-06-16 09:17:49 -07005604 print('ERROR No issue to open', file=sys.stderr)
thestig@chromium.org00858c82013-12-02 23:08:03 +00005605 return 1
5606
5607 webbrowser.open(issue_url)
5608 return 0
5609
5610
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005611@metrics.collector.collect_metrics('git cl set-commit')
maruel@chromium.org27bb3872011-05-30 20:33:19 +00005612def CMDset_commit(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005613 """Sets the commit bit to trigger the Commit Queue."""
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00005614 parser.add_option('-d', '--dry-run', action='store_true',
5615 help='trigger in dry run mode')
5616 parser.add_option('-c', '--clear', action='store_true',
5617 help='stop CQ run, if any')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00005618 auth.add_auth_options(parser)
iannuccie53c9352016-08-17 14:40:40 -07005619 _add_codereview_issue_select_options(parser)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00005620 options, args = parser.parse_args(args)
iannuccie53c9352016-08-17 14:40:40 -07005621 _process_codereview_issue_select_options(parser, options)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00005622 auth_config = auth.extract_auth_config_from_options(options)
maruel@chromium.org27bb3872011-05-30 20:33:19 +00005623 if args:
5624 parser.error('Unrecognized args: %s' % ' '.join(args))
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00005625 if options.dry_run and options.clear:
5626 parser.error('Make up your mind: both --dry-run and --clear not allowed')
5627
iannuccie53c9352016-08-17 14:40:40 -07005628 cl = Changelist(auth_config=auth_config, issue=options.issue,
5629 codereview=options.forced_codereview)
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00005630 if options.clear:
tandriid9e5ce52016-07-13 02:32:59 -07005631 state = _CQState.NONE
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00005632 elif options.dry_run:
5633 state = _CQState.DRY_RUN
5634 else:
5635 state = _CQState.COMMIT
5636 if not cl.GetIssue():
5637 parser.error('Must upload the issue first')
tandrii9de9ec62016-07-13 03:01:59 -07005638 cl.SetCQState(state)
maruel@chromium.org27bb3872011-05-30 20:33:19 +00005639 return 0
5640
5641
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005642@metrics.collector.collect_metrics('git cl set-close')
groby@chromium.org411034a2013-02-26 15:12:01 +00005643def CMDset_close(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005644 """Closes the issue."""
iannuccie53c9352016-08-17 14:40:40 -07005645 _add_codereview_issue_select_options(parser)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00005646 auth.add_auth_options(parser)
5647 options, args = parser.parse_args(args)
iannuccie53c9352016-08-17 14:40:40 -07005648 _process_codereview_issue_select_options(parser, options)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00005649 auth_config = auth.extract_auth_config_from_options(options)
groby@chromium.org411034a2013-02-26 15:12:01 +00005650 if args:
5651 parser.error('Unrecognized args: %s' % ' '.join(args))
iannuccie53c9352016-08-17 14:40:40 -07005652 cl = Changelist(auth_config=auth_config, issue=options.issue,
5653 codereview=options.forced_codereview)
groby@chromium.org411034a2013-02-26 15:12:01 +00005654 # Ensure there actually is an issue to close.
Aaron Gable7139a4e2017-09-05 17:53:09 -07005655 if not cl.GetIssue():
5656 DieWithError('ERROR No issue to close')
groby@chromium.org411034a2013-02-26 15:12:01 +00005657 cl.CloseIssue()
5658 return 0
5659
5660
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005661@metrics.collector.collect_metrics('git cl diff')
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00005662def CMDdiff(parser, args):
wychen@chromium.org37b2ec02015-04-03 00:49:15 +00005663 """Shows differences between local tree and last upload."""
thomasanderson074beb22016-08-29 14:03:20 -07005664 parser.add_option(
5665 '--stat',
5666 action='store_true',
5667 dest='stat',
5668 help='Generate a diffstat')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00005669 auth.add_auth_options(parser)
5670 options, args = parser.parse_args(args)
5671 auth_config = auth.extract_auth_config_from_options(options)
5672 if args:
5673 parser.error('Unrecognized args: %s' % ' '.join(args))
wychen@chromium.org46309bf2015-04-03 21:04:49 +00005674
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00005675 cl = Changelist(auth_config=auth_config)
sbc@chromium.org78dc9842013-11-25 18:43:44 +00005676 issue = cl.GetIssue()
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00005677 branch = cl.GetBranch()
sbc@chromium.org78dc9842013-11-25 18:43:44 +00005678 if not issue:
5679 DieWithError('No issue found for current branch (%s)' % branch)
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00005680
Aaron Gablea718c3e2017-08-28 17:47:28 -07005681 base = cl._GitGetBranchConfigValue('last-upload-hash')
5682 if not base:
5683 base = cl._GitGetBranchConfigValue('gerritsquashhash')
5684 if not base:
5685 detail = cl._GetChangeDetail(['CURRENT_REVISION', 'CURRENT_COMMIT'])
5686 revision_info = detail['revisions'][detail['current_revision']]
5687 fetch_info = revision_info['fetch']['http']
5688 RunGit(['fetch', fetch_info['url'], fetch_info['ref']])
5689 base = 'FETCH_HEAD'
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00005690
Aaron Gablea718c3e2017-08-28 17:47:28 -07005691 cmd = ['git', 'diff']
5692 if options.stat:
5693 cmd.append('--stat')
5694 cmd.append(base)
5695 subprocess2.check_call(cmd)
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00005696
5697 return 0
5698
5699
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005700@metrics.collector.collect_metrics('git cl owners')
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005701def CMDowners(parser, args):
Dirk Prankebf980882017-09-02 15:08:00 -07005702 """Finds potential owners for reviewing."""
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005703 parser.add_option(
Sidney San Martín8e6f58c2018-06-08 01:02:56 +00005704 '--ignore-current',
5705 action='store_true',
5706 help='Ignore the CL\'s current reviewers and start from scratch.')
5707 parser.add_option(
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005708 '--no-color',
5709 action='store_true',
5710 help='Use this option to disable color output')
Dirk Prankebf980882017-09-02 15:08:00 -07005711 parser.add_option(
5712 '--batch',
5713 action='store_true',
5714 help='Do not run interactively, just suggest some')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00005715 auth.add_auth_options(parser)
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005716 options, args = parser.parse_args(args)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00005717 auth_config = auth.extract_auth_config_from_options(options)
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005718
5719 author = RunGit(['config', 'user.email']).strip() or None
5720
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00005721 cl = Changelist(auth_config=auth_config)
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005722
5723 if args:
5724 if len(args) > 1:
5725 parser.error('Unknown args')
5726 base_branch = args[0]
5727 else:
5728 # Default to diffing against the common ancestor of the upstream branch.
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00005729 base_branch = cl.GetCommonAncestorWithUpstream()
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005730
5731 change = cl.GetChange(base_branch, None)
Dirk Prankebf980882017-09-02 15:08:00 -07005732 affected_files = [f.LocalPath() for f in change.AffectedFiles()]
5733
5734 if options.batch:
5735 db = owners.Database(change.RepositoryRoot(), file, os.path)
5736 print('\n'.join(db.reviewers_for(affected_files, author)))
5737 return 0
5738
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005739 return owners_finder.OwnersFinder(
Dirk Prankebf980882017-09-02 15:08:00 -07005740 affected_files,
Jochen Eisinger72606f82017-04-04 10:44:18 +02005741 change.RepositoryRoot(),
Edward Lemur707d70b2018-02-07 00:50:14 +01005742 author,
Sidney San Martín8e6f58c2018-06-08 01:02:56 +00005743 [] if options.ignore_current else cl.GetReviewers(),
Edward Lemur707d70b2018-02-07 00:50:14 +01005744 fopen=file, os_path=os.path,
Jochen Eisingerd0573ec2017-04-13 10:55:06 +02005745 disable_color=options.no_color,
5746 override_files=change.OriginalOwnersFiles()).run()
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005747
5748
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005749def BuildGitDiffCmd(diff_type, upstream_commit, args):
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005750 """Generates a diff command."""
5751 # Generate diff for the current branch's changes.
Aaron Gablef4068aa2017-12-12 15:14:09 -08005752 diff_cmd = ['-c', 'core.quotePath=false', 'diff',
5753 '--no-ext-diff', '--no-prefix', diff_type,
Andrii Shyshkalov18975322017-01-25 16:44:13 +01005754 upstream_commit, '--']
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005755
5756 if args:
5757 for arg in args:
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005758 if os.path.isdir(arg) or os.path.isfile(arg):
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005759 diff_cmd.append(arg)
5760 else:
5761 DieWithError('Argument "%s" is not a file or a directory' % arg)
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005762
5763 return diff_cmd
5764
Andrii Shyshkalov18975322017-01-25 16:44:13 +01005765
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005766def MatchingFileType(file_name, extensions):
5767 """Returns true if the file name ends with one of the given extensions."""
5768 return bool([ext for ext in extensions if file_name.lower().endswith(ext)])
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005769
Andrii Shyshkalov18975322017-01-25 16:44:13 +01005770
enne@chromium.org555cfe42014-01-29 18:21:39 +00005771@subcommand.usage('[files or directories to diff]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005772@metrics.collector.collect_metrics('git cl format')
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005773def CMDformat(parser, args):
sbc@chromium.org9d0644d2015-06-05 23:16:54 +00005774 """Runs auto-formatting tools (clang-format etc.) on the diff."""
Christopher Lamc5ba6922017-01-24 11:19:14 +11005775 CLANG_EXTS = ['.cc', '.cpp', '.h', '.m', '.mm', '.proto', '.java']
kylechar58edce22016-06-17 06:07:51 -07005776 GN_EXTS = ['.gn', '.gni', '.typemap']
enne@chromium.org3b7e15c2014-01-21 17:44:47 +00005777 parser.add_option('--full', action='store_true',
5778 help='Reformat the full content of all touched files')
5779 parser.add_option('--dry-run', action='store_true',
5780 help='Don\'t modify any file on disk.')
sbc@chromium.org9d0644d2015-06-05 23:16:54 +00005781 parser.add_option('--python', action='store_true',
5782 help='Format python code with yapf (experimental).')
Christopher Lamc5ba6922017-01-24 11:19:14 +11005783 parser.add_option('--js', action='store_true',
5784 help='Format javascript code with clang-format.')
wittman@chromium.org04d5a222014-03-07 18:30:42 +00005785 parser.add_option('--diff', action='store_true',
5786 help='Print diff to stdout rather than modifying files.')
Ilya Shermane081cbe2017-08-15 17:51:04 -07005787 parser.add_option('--presubmit', action='store_true',
5788 help='Used when running the script from a presubmit.')
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005789 opts, args = parser.parse_args(args)
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005790
Daniel Chengc55eecf2016-12-30 03:11:02 -08005791 # Normalize any remaining args against the current path, so paths relative to
5792 # the current directory are still resolved as expected.
5793 args = [os.path.join(os.getcwd(), arg) for arg in args]
5794
enne@chromium.orgff7a1fb2013-12-10 19:21:41 +00005795 # git diff generates paths against the root of the repository. Change
5796 # to that directory so clang-format can find files even within subdirs.
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00005797 rel_base_path = settings.GetRelativeRoot()
enne@chromium.orgff7a1fb2013-12-10 19:21:41 +00005798 if rel_base_path:
5799 os.chdir(rel_base_path)
5800
digit@chromium.org29e47272013-05-17 17:01:46 +00005801 # Grab the merge-base commit, i.e. the upstream commit of the current
5802 # branch when it was created or the last time it was rebased. This is
5803 # to cover the case where the user may have called "git fetch origin",
5804 # moving the origin branch to a newer commit, but hasn't rebased yet.
5805 upstream_commit = None
5806 cl = Changelist()
5807 upstream_branch = cl.GetUpstreamBranch()
5808 if upstream_branch:
5809 upstream_commit = RunGit(['merge-base', 'HEAD', upstream_branch])
5810 upstream_commit = upstream_commit.strip()
5811
5812 if not upstream_commit:
5813 DieWithError('Could not find base commit for this branch. '
5814 'Are you in detached state?')
5815
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005816 changed_files_cmd = BuildGitDiffCmd('--name-only', upstream_commit, args)
5817 diff_output = RunGit(changed_files_cmd)
5818 diff_files = diff_output.splitlines()
jkarlin@chromium.orgad21b922016-01-28 17:48:42 +00005819 # Filter out files deleted by this CL
5820 diff_files = [x for x in diff_files if os.path.isfile(x)]
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005821
Christopher Lamc5ba6922017-01-24 11:19:14 +11005822 if opts.js:
Deepanjan Roy605dd312018-07-02 17:48:54 +00005823 CLANG_EXTS.extend(['.js', '.ts'])
Christopher Lamc5ba6922017-01-24 11:19:14 +11005824
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005825 clang_diff_files = [x for x in diff_files if MatchingFileType(x, CLANG_EXTS)]
5826 python_diff_files = [x for x in diff_files if MatchingFileType(x, ['.py'])]
5827 dart_diff_files = [x for x in diff_files if MatchingFileType(x, ['.dart'])]
kylechar@chromium.org8b61f112016-02-05 13:28:58 +00005828 gn_diff_files = [x for x in diff_files if MatchingFileType(x, GN_EXTS)]
digit@chromium.org29e47272013-05-17 17:01:46 +00005829
nick@chromium.org3ac1c4e2014-01-16 02:44:42 +00005830 top_dir = os.path.normpath(
5831 RunGit(["rev-parse", "--show-toplevel"]).rstrip('\n'))
5832
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005833 # Set to 2 to signal to CheckPatchFormatted() that this patch isn't
5834 # formatted. This is used to block during the presubmit.
5835 return_value = 0
5836
sammc@chromium.org0b35f5d2016-02-25 22:39:23 +00005837 if clang_diff_files:
techtonik@gmail.com5573df12016-04-12 18:34:10 +00005838 # Locate the clang-format binary in the checkout
5839 try:
5840 clang_format_tool = clang_format.FindClangFormatToolInChromiumTree()
vapierfd77ac72016-06-16 08:33:57 -07005841 except clang_format.NotFoundError as e:
techtonik@gmail.com5573df12016-04-12 18:34:10 +00005842 DieWithError(e)
5843
sammc@chromium.org0b35f5d2016-02-25 22:39:23 +00005844 if opts.full:
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005845 cmd = [clang_format_tool]
5846 if not opts.dry_run and not opts.diff:
5847 cmd.append('-i')
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005848 stdout = RunCommand(cmd + clang_diff_files, cwd=top_dir)
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005849 if opts.diff:
5850 sys.stdout.write(stdout)
sammc@chromium.org0b35f5d2016-02-25 22:39:23 +00005851 else:
5852 env = os.environ.copy()
5853 env['PATH'] = str(os.path.dirname(clang_format_tool))
5854 try:
5855 script = clang_format.FindClangFormatScriptInChromiumTree(
5856 'clang-format-diff.py')
vapierfd77ac72016-06-16 08:33:57 -07005857 except clang_format.NotFoundError as e:
sammc@chromium.org0b35f5d2016-02-25 22:39:23 +00005858 DieWithError(e)
digit@chromium.orgd6ddc1c2013-10-25 15:36:32 +00005859
sammc@chromium.org0b35f5d2016-02-25 22:39:23 +00005860 cmd = [sys.executable, script, '-p0']
5861 if not opts.dry_run and not opts.diff:
5862 cmd.append('-i')
digit@chromium.orgd6ddc1c2013-10-25 15:36:32 +00005863
sammc@chromium.org0b35f5d2016-02-25 22:39:23 +00005864 diff_cmd = BuildGitDiffCmd('-U0', upstream_commit, clang_diff_files)
5865 diff_output = RunGit(diff_cmd)
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005866
sammc@chromium.org0b35f5d2016-02-25 22:39:23 +00005867 stdout = RunCommand(cmd, stdin=diff_output, cwd=top_dir, env=env)
5868 if opts.diff:
5869 sys.stdout.write(stdout)
5870 if opts.dry_run and len(stdout) > 0:
5871 return_value = 2
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005872
sbc@chromium.org9d0644d2015-06-05 23:16:54 +00005873 # Similar code to above, but using yapf on .py files rather than clang-format
5874 # on C/C++ files
5875 if opts.python:
sbc@chromium.org9d0644d2015-06-05 23:16:54 +00005876 yapf_tool = gclient_utils.FindExecutable('yapf')
5877 if yapf_tool is None:
5878 DieWithError('yapf not found in PATH')
5879
5880 if opts.full:
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005881 if python_diff_files:
Nodir Turakulovaf43f402018-05-31 14:54:24 -07005882 if opts.dry_run or opts.diff:
5883 cmd = [yapf_tool, '--diff'] + python_diff_files
5884 stdout = RunCommand(cmd, error_ok=True, cwd=top_dir)
5885 if opts.diff:
5886 sys.stdout.write(stdout)
5887 elif len(stdout) > 0:
5888 return_value = 2
5889 else:
5890 RunCommand([yapf_tool, '-i'] + python_diff_files, cwd=top_dir)
sbc@chromium.org9d0644d2015-06-05 23:16:54 +00005891 else:
5892 # TODO(sbc): yapf --lines mode still has some issues.
5893 # https://github.com/google/yapf/issues/154
5894 DieWithError('--python currently only works with --full')
5895
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005896 # Dart's formatter does not have the nice property of only operating on
5897 # modified chunks, so hard code full.
5898 if dart_diff_files:
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005899 try:
5900 command = [dart_format.FindDartFmtToolInChromiumTree()]
5901 if not opts.dry_run and not opts.diff:
5902 command.append('-w')
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005903 command.extend(dart_diff_files)
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005904
ppi@chromium.org6593d932016-03-03 15:41:15 +00005905 stdout = RunCommand(command, cwd=top_dir)
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005906 if opts.dry_run and stdout:
5907 return_value = 2
5908 except dart_format.NotFoundError as e:
vapiera7fbd5a2016-06-16 09:17:49 -07005909 print('Warning: Unable to check Dart code formatting. Dart SDK not '
5910 'found in this checkout. Files in other languages are still '
5911 'formatted.')
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005912
kylechar@chromium.org8b61f112016-02-05 13:28:58 +00005913 # Format GN build files. Always run on full build files for canonical form.
5914 if gn_diff_files:
Andrii Shyshkalov18975322017-01-25 16:44:13 +01005915 cmd = ['gn', 'format']
brettw4b8ed592016-08-05 16:19:12 -07005916 if opts.dry_run or opts.diff:
5917 cmd.append('--dry-run')
kylechar@chromium.org8b61f112016-02-05 13:28:58 +00005918 for gn_diff_file in gn_diff_files:
brettw4b8ed592016-08-05 16:19:12 -07005919 gn_ret = subprocess2.call(cmd + [gn_diff_file],
5920 shell=sys.platform == 'win32',
5921 cwd=top_dir)
5922 if opts.dry_run and gn_ret == 2:
5923 return_value = 2 # Not formatted.
5924 elif opts.diff and gn_ret == 2:
5925 # TODO this should compute and print the actual diff.
5926 print("This change has GN build file diff for " + gn_diff_file)
5927 elif gn_ret != 0:
5928 # For non-dry run cases (and non-2 return values for dry-run), a
5929 # nonzero error code indicates a failure, probably because the file
5930 # doesn't parse.
5931 DieWithError("gn format failed on " + gn_diff_file +
5932 "\nTry running 'gn format' on this file manually.")
kylechar@chromium.org8b61f112016-02-05 13:28:58 +00005933
Ilya Shermane081cbe2017-08-15 17:51:04 -07005934 # Skip the metrics formatting from the global presubmit hook. These files have
5935 # a separate presubmit hook that issues an error if the files need formatting,
5936 # whereas the top-level presubmit script merely issues a warning. Formatting
5937 # these files is somewhat slow, so it's important not to duplicate the work.
5938 if not opts.presubmit:
5939 for xml_dir in GetDirtyMetricsDirs(diff_files):
5940 tool_dir = os.path.join(top_dir, xml_dir)
5941 cmd = [os.path.join(tool_dir, 'pretty_print.py'), '--non-interactive']
5942 if opts.dry_run or opts.diff:
5943 cmd.append('--diff')
Ilya Sherman235b70d2017-08-22 17:46:38 -07005944 stdout = RunCommand(cmd, cwd=top_dir)
Ilya Shermane081cbe2017-08-15 17:51:04 -07005945 if opts.diff:
5946 sys.stdout.write(stdout)
5947 if opts.dry_run and stdout:
5948 return_value = 2 # Not formatted.
Alexei Svitkinef3cac412017-02-06 11:08:50 -05005949
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005950 return return_value
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005951
Steven Holte2e664bf2017-04-21 13:10:47 -07005952def GetDirtyMetricsDirs(diff_files):
5953 xml_diff_files = [x for x in diff_files if MatchingFileType(x, ['.xml'])]
5954 metrics_xml_dirs = [
5955 os.path.join('tools', 'metrics', 'actions'),
5956 os.path.join('tools', 'metrics', 'histograms'),
5957 os.path.join('tools', 'metrics', 'rappor'),
5958 os.path.join('tools', 'metrics', 'ukm')]
5959 for xml_dir in metrics_xml_dirs:
5960 if any(file.startswith(xml_dir) for file in xml_diff_files):
5961 yield xml_dir
5962
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005963
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005964@subcommand.usage('<codereview url or issue id>')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005965@metrics.collector.collect_metrics('git cl checkout')
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005966def CMDcheckout(parser, args):
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00005967 """Checks out a branch associated with a given Rietveld or Gerrit issue."""
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005968 _, args = parser.parse_args(args)
5969
5970 if len(args) != 1:
5971 parser.print_help()
5972 return 1
5973
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00005974 issue_arg = ParseIssueNumberArgument(args[0])
tandrii@chromium.orgde6c9a12016-04-11 15:33:53 +00005975 if not issue_arg.valid:
Andrii Shyshkalov28d840e2017-04-10 15:45:09 +02005976 parser.error('invalid codereview url or CL id')
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02005977
tandrii@chromium.orgabd27e52016-04-11 15:43:32 +00005978 target_issue = str(issue_arg.issue)
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005979
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00005980 def find_issues(issueprefix):
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00005981 output = RunGit(['config', '--local', '--get-regexp',
5982 r'branch\..*\.%s' % issueprefix],
5983 error_ok=True)
5984 for key, issue in [x.split() for x in output.splitlines()]:
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00005985 if issue == target_issue:
5986 yield re.sub(r'branch\.(.*)\.%s' % issueprefix, r'\1', key)
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005987
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00005988 branches = []
5989 for cls in _CODEREVIEW_IMPLEMENTATIONS.values():
tandrii5d48c322016-08-18 16:19:37 -07005990 branches.extend(find_issues(cls.IssueConfigKey()))
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005991 if len(branches) == 0:
vapiera7fbd5a2016-06-16 09:17:49 -07005992 print('No branch found for issue %s.' % target_issue)
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005993 return 1
5994 if len(branches) == 1:
5995 RunGit(['checkout', branches[0]])
5996 else:
vapiera7fbd5a2016-06-16 09:17:49 -07005997 print('Multiple branches match issue %s:' % target_issue)
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005998 for i in range(len(branches)):
vapiera7fbd5a2016-06-16 09:17:49 -07005999 print('%d: %s' % (i, branches[i]))
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00006000 which = raw_input('Choose by index: ')
6001 try:
6002 RunGit(['checkout', branches[int(which)]])
6003 except (IndexError, ValueError):
vapiera7fbd5a2016-06-16 09:17:49 -07006004 print('Invalid selection, not checking out any branch.')
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00006005 return 1
6006
6007 return 0
6008
6009
maruel@chromium.org29404b52014-09-08 22:58:00 +00006010def CMDlol(parser, args):
6011 # This command is intentionally undocumented.
vapiera7fbd5a2016-06-16 09:17:49 -07006012 print(zlib.decompress(base64.b64decode(
thakis@chromium.org3421c992014-11-02 02:20:32 +00006013 'eNptkLEOwyAMRHe+wupCIqW57v0Vq84WqWtXyrcXnCBsmgMJ+/SSAxMZgRB6NzE'
6014 'E2ObgCKJooYdu4uAQVffUEoE1sRQLxAcqzd7uK2gmStrll1ucV3uZyaY5sXyDd9'
6015 'JAnN+lAXsOMJ90GANAi43mq5/VeeacylKVgi8o6F1SC63FxnagHfJUTfUYdCR/W'
vapiera7fbd5a2016-06-16 09:17:49 -07006016 'Ofe+0dHL7PicpytKP750Fh1q2qnLVof4w8OZWNY')))
maruel@chromium.org29404b52014-09-08 22:58:00 +00006017 return 0
6018
6019
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00006020class OptionParser(optparse.OptionParser):
6021 """Creates the option parse and add --verbose support."""
6022 def __init__(self, *args, **kwargs):
maruel@chromium.org0633fb42013-08-16 20:06:14 +00006023 optparse.OptionParser.__init__(
6024 self, *args, prog='git cl', version=__version__, **kwargs)
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00006025 self.add_option(
6026 '-v', '--verbose', action='count', default=0,
6027 help='Use 2 times for more debugging info')
6028
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00006029 def parse_args(self, args=None, _values=None):
6030 # Create an optparse.Values object that will store only the actual passed
6031 # options, without the defaults.
6032 actual_options = optparse.Values()
6033 _, args = optparse.OptionParser.parse_args(self, args, actual_options)
6034 # Create an optparse.Values object with the default options.
6035 options = optparse.Values(self.get_default_values().__dict__)
6036 # Update it with the options passed by the user.
6037 options._update_careful(actual_options.__dict__)
6038 # Store the options passed by the user in an _actual_options attribute.
6039 # We store only the keys, and not the values, since the values can contain
6040 # arbitrary information, which might be PII.
6041 metrics.collector.add('arguments', actual_options.__dict__.keys())
6042
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00006043 levels = [logging.WARNING, logging.INFO, logging.DEBUG]
Andrii Shyshkalov5b04a572017-01-23 17:44:41 +01006044 logging.basicConfig(
6045 level=levels[min(options.verbose, len(levels) - 1)],
6046 format='[%(levelname).1s%(asctime)s %(process)d %(thread)d '
6047 '%(filename)s] %(message)s')
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00006048 return options, args
6049
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00006050
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00006051def main(argv):
maruel@chromium.org82798cb2012-02-23 18:16:12 +00006052 if sys.hexversion < 0x02060000:
vapiera7fbd5a2016-06-16 09:17:49 -07006053 print('\nYour python version %s is unsupported, please upgrade.\n' %
6054 (sys.version.split(' ', 1)[0],), file=sys.stderr)
maruel@chromium.org82798cb2012-02-23 18:16:12 +00006055 return 2
maruel@chromium.org2e23ce32013-05-07 12:42:28 +00006056
maruel@chromium.orgddd59412011-11-30 14:20:38 +00006057 # Reload settings.
6058 global settings
6059 settings = Settings()
6060
Edward Lemurad463c92018-07-25 21:31:23 +00006061 if not metrics.DISABLE_METRICS_COLLECTION:
6062 metrics.collector.add('project_urls', [settings.GetViewVCUrl().strip('/+')])
maruel@chromium.org39c0b222013-08-17 16:57:01 +00006063 colorize_CMDstatus_doc()
maruel@chromium.org0633fb42013-08-16 20:06:14 +00006064 dispatcher = subcommand.CommandDispatcher(__name__)
6065 try:
6066 return dispatcher.execute(OptionParser(), argv)
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +00006067 except auth.AuthenticationError as e:
6068 DieWithError(str(e))
vapierfd77ac72016-06-16 08:33:57 -07006069 except urllib2.HTTPError as e:
maruel@chromium.org0633fb42013-08-16 20:06:14 +00006070 if e.code != 500:
6071 raise
6072 DieWithError(
6073 ('AppEngine is misbehaving and returned HTTP %d, again. Keep faith '
6074 'and retry or visit go/isgaeup.\n%s') % (e.code, str(e)))
sbc@chromium.org013731e2015-02-26 18:28:43 +00006075 return 0
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00006076
6077
6078if __name__ == '__main__':
maruel@chromium.org2e23ce32013-05-07 12:42:28 +00006079 # These affect sys.stdout so do it outside of main() to simplify mocks in
6080 # unit testing.
maruel@chromium.org6f09cd92011-04-01 16:38:12 +00006081 fix_encoding.fix_encoding()
iannucci@chromium.org596cd5c2016-04-04 21:34:39 +00006082 setup_color.init()
Edward Lemur6f812e12018-07-31 22:45:57 +00006083 with metrics.collector.print_notice_and_exit():
sbc@chromium.org013731e2015-02-26 18:28:43 +00006084 sys.exit(main(sys.argv[1:]))