commit d105249ddaa338aa8b4d090646c05102f9169f3b
author Aaron Gable <agable@chromium.org> Mon May 15 15:05:34 2017 -0700
committer Commit Bot <commit-bot@chromium.org> Tue May 16 21:25:45 2017 +0000
tree b30c9f5fb9cf4636182f104b59f8ec9f8215ee3b
parent 704be878162e5e0f776d77b182f4969103aa886b

Don't add WATCHLIST CCs on private CLs

Many WATCHLIST and codereview.settings files contain
large public email lists, which defeats the purpose
of private reviews.

R=tandrii@chromium.org

Bug: 721880
Change-Id: Ibb3f314f735b783e628f8cc1fc22c74e0df59f1c
Reviewed-on: https://chromium-review.googlesource.com/506489
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>

git_cl.py

diff --git a/git_cl.py b/git_cl.py
index 3f1752f..390f4b4 100755
--- a/git_cl.py
+++ b/git_cl.py
@@ -3018,7 +3018,10 @@
     reviewers = sorted(change_desc.get_reviewers())
 
     # Add cc's from the CC_LIST and --cc flag (if any).
-    cc = self.GetCCList().split(',')
+    if not options.private:
+      cc = self.GetCCList().split(',')
+    else:
+      cc = []
     if options.cc:
       cc.extend(options.cc)
     cc = filter(None, [email.strip() for email in cc])