commit 90f3192799a37026cf58b8d52f8ac2771f0cba80
author Andrii Shyshkalov <tandrii@chromium.org> Mon Apr 10 16:10:21 2017 +0200
committer Commit Bot <commit-bot@chromium.org> Mon Apr 10 14:14:00 2017 +0000
tree 1616d15a37822bbaaae7f2c44234c7a57dfc99e9
parent 2cd3c14ef72a306bfacbb0dc961d61c238a85244

git cl: remember codereview type when parsing issue/change URL.

R=jochen@chromium.org
BUG=706406

Change-Id: I477d1cf629bb0bccebead6e5c0189830ea76be7e
Reviewed-on: https://chromium-review.googlesource.com/472867
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>

git_cl.py

diff --git a/git_cl.py b/git_cl.py
index c556efd..0a94470 100755
--- a/git_cl.py
+++ b/git_cl.py
@@ -1038,10 +1038,12 @@
 
 
 class _ParsedIssueNumberArgument(object):
-  def __init__(self, issue=None, patchset=None, hostname=None):
+  def __init__(self, issue=None, patchset=None, hostname=None, codereview=None):
     self.issue = issue
     self.patchset = patchset
     self.hostname = hostname
+    assert codereview in (None, 'rietveld', 'gerrit')
+    self.codereview = codereview
 
   @property
   def valid(self):
@@ -2172,20 +2174,23 @@
       return _ParsedIssueNumberArgument(
           issue=int(match.group(1)),
           patchset=int(match2.group(1)),
-          hostname=parsed_url.netloc)
+          hostname=parsed_url.netloc,
+          codereview='rietveld')
     # Typical url: https://domain/<issue_number>[/[other]]
     match = re.match('/(\d+)(/.*)?$', parsed_url.path)
     if match:
       return _ParsedIssueNumberArgument(
           issue=int(match.group(1)),
-          hostname=parsed_url.netloc)
+          hostname=parsed_url.netloc,
+          codereview='rietveld')
     # Rietveld patch: https://domain/download/issue<number>_<patchset>.diff
     match = re.match(r'/download/issue(\d+)_(\d+).diff$', parsed_url.path)
     if match:
       return _ParsedIssueNumberArgument(
           issue=int(match.group(1)),
           patchset=int(match.group(2)),
-          hostname=parsed_url.netloc)
+          hostname=parsed_url.netloc,
+          codereview='rietveld')
     return None
 
   def CMDUploadChange(self, options, args, change):
@@ -2780,7 +2785,8 @@
       return _ParsedIssueNumberArgument(
           issue=int(match.group(2)),
           patchset=int(match.group(4)) if match.group(4) else None,
-          hostname=parsed_url.netloc)
+          hostname=parsed_url.netloc,
+          codereview='gerrit')
     return None
 
   def _GerritCommitMsgHookCheck(self, offer_removal):