iannucci@chromium.org | 405b87e | 2015-11-12 18:08:34 +0000 | [diff] [blame] | 1 | #!/usr/bin/env python |
miket@chromium.org | 183df1a | 2012-01-04 19:44:55 +0000 | [diff] [blame] | 2 | # Copyright (c) 2012 The Chromium Authors. All rights reserved. |
maruel@chromium.org | 725f1c3 | 2011-04-01 20:24:54 +0000 | [diff] [blame] | 3 | # Use of this source code is governed by a BSD-style license that can be |
| 4 | # found in the LICENSE file. |
| 5 | |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 6 | # Copyright (C) 2008 Evan Martin <martine@danga.com> |
| 7 | |
maruel@chromium.org | 725f1c3 | 2011-04-01 20:24:54 +0000 | [diff] [blame] | 8 | """A git-command for integrating reviews on Rietveld.""" |
| 9 | |
tapted@chromium.org | 6a0b07c | 2013-07-10 01:29:19 +0000 | [diff] [blame] | 10 | from distutils.version import LooseVersion |
calamity@chromium.org | ffde55c | 2015-03-12 00:44:17 +0000 | [diff] [blame] | 11 | from multiprocessing.pool import ThreadPool |
thakis@chromium.org | 3421c99 | 2014-11-02 02:20:32 +0000 | [diff] [blame] | 12 | import base64 |
rmistry@google.com | 2dd9986 | 2015-06-22 12:22:18 +0000 | [diff] [blame] | 13 | import collections |
ikarienator@chromium.org | faf3fdf | 2013-09-20 02:11:48 +0000 | [diff] [blame] | 14 | import glob |
sheyang@google.com | 6ebaf78 | 2015-05-12 19:17:54 +0000 | [diff] [blame] | 15 | import httplib |
maruel@chromium.org | 4f6852c | 2012-04-20 20:39:20 +0000 | [diff] [blame] | 16 | import json |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 17 | import logging |
| 18 | import optparse |
| 19 | import os |
maruel@chromium.org | 1033efd | 2013-07-23 23:25:09 +0000 | [diff] [blame] | 20 | import Queue |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 21 | import re |
ukai@chromium.org | 78c4b98 | 2012-02-14 02:20:26 +0000 | [diff] [blame] | 22 | import stat |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 23 | import sys |
bauerb@chromium.org | 27386dd | 2015-02-16 10:45:39 +0000 | [diff] [blame] | 24 | import tempfile |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 25 | import textwrap |
sheyang@google.com | 6ebaf78 | 2015-05-12 19:17:54 +0000 | [diff] [blame] | 26 | import time |
| 27 | import traceback |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 28 | import urllib2 |
maruel@chromium.org | 967c0a8 | 2013-06-17 22:52:24 +0000 | [diff] [blame] | 29 | import urlparse |
thestig@chromium.org | 00858c8 | 2013-12-02 23:08:03 +0000 | [diff] [blame] | 30 | import webbrowser |
thakis@chromium.org | 3421c99 | 2014-11-02 02:20:32 +0000 | [diff] [blame] | 31 | import zlib |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 32 | |
| 33 | try: |
maruel@chromium.org | c98c0c5 | 2011-04-06 13:39:43 +0000 | [diff] [blame] | 34 | import readline # pylint: disable=F0401,W0611 |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 35 | except ImportError: |
| 36 | pass |
| 37 | |
maruel@chromium.org | 2e23ce3 | 2013-05-07 12:42:28 +0000 | [diff] [blame] | 38 | from third_party import colorama |
sheyang@google.com | 6ebaf78 | 2015-05-12 19:17:54 +0000 | [diff] [blame] | 39 | from third_party import httplib2 |
maruel@chromium.org | 2a74d37 | 2011-03-29 19:05:50 +0000 | [diff] [blame] | 40 | from third_party import upload |
vadimsh@chromium.org | cf6a5d2 | 2015-04-09 22:02:00 +0000 | [diff] [blame] | 41 | import auth |
hinoka@chromium.org | feb9e2a | 2015-09-25 19:11:09 +0000 | [diff] [blame] | 42 | from luci_hacks import trigger_luci_job as luci_trigger |
maruel@chromium.org | 2a74d37 | 2011-03-29 19:05:50 +0000 | [diff] [blame] | 43 | import breakpad # pylint: disable=W0611 |
nick@chromium.org | 3ac1c4e | 2014-01-16 02:44:42 +0000 | [diff] [blame] | 44 | import clang_format |
tandrii@chromium.org | 71184c0 | 2016-01-13 15:18:44 +0000 | [diff] [blame] | 45 | import commit_queue |
erg@chromium.org | e0a7c5d | 2015-02-23 20:30:08 +0000 | [diff] [blame] | 46 | import dart_format |
maruel@chromium.org | 6f09cd9 | 2011-04-01 16:38:12 +0000 | [diff] [blame] | 47 | import fix_encoding |
maruel@chromium.org | 0e0436a | 2011-10-25 13:32:41 +0000 | [diff] [blame] | 48 | import gclient_utils |
iannucci@chromium.org | 9e84927 | 2014-04-04 00:31:55 +0000 | [diff] [blame] | 49 | import git_common |
mmoss@chromium.org | f0e4152 | 2015-06-10 19:52:01 +0000 | [diff] [blame] | 50 | from git_footers import get_footer_svn_id |
piman@chromium.org | 336f912 | 2014-09-04 02:16:55 +0000 | [diff] [blame] | 51 | import owners |
iannucci@chromium.org | 9e84927 | 2014-04-04 00:31:55 +0000 | [diff] [blame] | 52 | import owners_finder |
maruel@chromium.org | 2a74d37 | 2011-03-29 19:05:50 +0000 | [diff] [blame] | 53 | import presubmit_support |
maruel@chromium.org | cab38e9 | 2011-04-09 00:30:51 +0000 | [diff] [blame] | 54 | import rietveld |
maruel@chromium.org | 2a74d37 | 2011-03-29 19:05:50 +0000 | [diff] [blame] | 55 | import scm |
maruel@chromium.org | 0633fb4 | 2013-08-16 20:06:14 +0000 | [diff] [blame] | 56 | import subcommand |
maruel@chromium.org | 32f9f5e | 2011-09-14 13:41:47 +0000 | [diff] [blame] | 57 | import subprocess2 |
maruel@chromium.org | 2a74d37 | 2011-03-29 19:05:50 +0000 | [diff] [blame] | 58 | import watchlists |
| 59 | |
maruel@chromium.org | 0633fb4 | 2013-08-16 20:06:14 +0000 | [diff] [blame] | 60 | __version__ = '1.0' |
maruel@chromium.org | 2a74d37 | 2011-03-29 19:05:50 +0000 | [diff] [blame] | 61 | |
maruel@chromium.org | eb5edbc | 2012-01-16 17:03:28 +0000 | [diff] [blame] | 62 | DEFAULT_SERVER = 'https://codereview.appspot.com' |
maruel@chromium.org | 0ba7f96 | 2011-01-11 22:13:58 +0000 | [diff] [blame] | 63 | POSTUPSTREAM_HOOK_PATTERN = '.git/hooks/post-cl-%s' |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 64 | DESCRIPTION_BACKUP_FILE = '~/.git_cl_description_backup' |
pgervais@chromium.org | d6617f3 | 2013-11-19 00:34:54 +0000 | [diff] [blame] | 65 | GIT_INSTRUCTIONS_URL = 'http://code.google.com/p/chromium/wiki/UsingGit' |
sivachandra@chromium.org | aebe87f | 2012-10-22 20:34:21 +0000 | [diff] [blame] | 66 | CHANGE_ID = 'Change-Id:' |
rmistry@google.com | c68112d | 2015-03-03 12:48:06 +0000 | [diff] [blame] | 67 | REFS_THAT_ALIAS_TO_OTHER_REFS = { |
| 68 | 'refs/remotes/origin/lkgr': 'refs/remotes/origin/master', |
| 69 | 'refs/remotes/origin/lkcr': 'refs/remotes/origin/master', |
| 70 | } |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 71 | |
thestig@chromium.org | 44202a2 | 2014-03-11 19:22:18 +0000 | [diff] [blame] | 72 | # Valid extensions for files we want to lint. |
| 73 | DEFAULT_LINT_REGEX = r"(.*\.cpp|.*\.cc|.*\.h)" |
| 74 | DEFAULT_LINT_IGNORE_REGEX = r"$^" |
| 75 | |
maruel@chromium.org | 2e23ce3 | 2013-05-07 12:42:28 +0000 | [diff] [blame] | 76 | # Shortcut since it quickly becomes redundant. |
| 77 | Fore = colorama.Fore |
maruel@chromium.org | 9054173 | 2011-04-01 17:54:18 +0000 | [diff] [blame] | 78 | |
maruel@chromium.org | ddd5941 | 2011-11-30 14:20:38 +0000 | [diff] [blame] | 79 | # Initialized in main() |
| 80 | settings = None |
| 81 | |
| 82 | |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 83 | def DieWithError(message): |
dpranke@chromium.org | 970c522 | 2011-03-12 00:32:24 +0000 | [diff] [blame] | 84 | print >> sys.stderr, message |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 85 | sys.exit(1) |
| 86 | |
| 87 | |
thestig@chromium.org | 8b0553c | 2014-02-11 00:33:37 +0000 | [diff] [blame] | 88 | def GetNoGitPagerEnv(): |
| 89 | env = os.environ.copy() |
| 90 | # 'cat' is a magical git string that disables pagers on all platforms. |
| 91 | env['GIT_PAGER'] = 'cat' |
| 92 | return env |
| 93 | |
vadimsh@chromium.org | 566a02a | 2014-08-22 01:34:13 +0000 | [diff] [blame] | 94 | |
maruel@chromium.org | 32f9f5e | 2011-09-14 13:41:47 +0000 | [diff] [blame] | 95 | def RunCommand(args, error_ok=False, error_message=None, **kwargs): |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 96 | try: |
maruel@chromium.org | 373af80 | 2012-05-25 21:07:33 +0000 | [diff] [blame] | 97 | return subprocess2.check_output(args, shell=False, **kwargs) |
maruel@chromium.org | 78936cb | 2013-04-11 00:17:52 +0000 | [diff] [blame] | 98 | except subprocess2.CalledProcessError as e: |
| 99 | logging.debug('Failed running %s', args) |
maruel@chromium.org | 32f9f5e | 2011-09-14 13:41:47 +0000 | [diff] [blame] | 100 | if not error_ok: |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 101 | DieWithError( |
maruel@chromium.org | 32f9f5e | 2011-09-14 13:41:47 +0000 | [diff] [blame] | 102 | 'Command "%s" failed.\n%s' % ( |
| 103 | ' '.join(args), error_message or e.stdout or '')) |
| 104 | return e.stdout |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 105 | |
| 106 | |
| 107 | def RunGit(args, **kwargs): |
maruel@chromium.org | 32f9f5e | 2011-09-14 13:41:47 +0000 | [diff] [blame] | 108 | """Returns stdout.""" |
bratell@opera.com | 82b91cd | 2013-07-09 06:33:41 +0000 | [diff] [blame] | 109 | return RunCommand(['git'] + args, **kwargs) |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 110 | |
| 111 | |
enne@chromium.org | 3b7e15c | 2014-01-21 17:44:47 +0000 | [diff] [blame] | 112 | def RunGitWithCode(args, suppress_stderr=False): |
maruel@chromium.org | 32f9f5e | 2011-09-14 13:41:47 +0000 | [diff] [blame] | 113 | """Returns return code and stdout.""" |
szager@chromium.org | 9bb85e2 | 2012-06-13 20:28:23 +0000 | [diff] [blame] | 114 | try: |
enne@chromium.org | 3b7e15c | 2014-01-21 17:44:47 +0000 | [diff] [blame] | 115 | if suppress_stderr: |
| 116 | stderr = subprocess2.VOID |
| 117 | else: |
| 118 | stderr = sys.stderr |
bratell@opera.com | 82b91cd | 2013-07-09 06:33:41 +0000 | [diff] [blame] | 119 | out, code = subprocess2.communicate(['git'] + args, |
thestig@chromium.org | 8b0553c | 2014-02-11 00:33:37 +0000 | [diff] [blame] | 120 | env=GetNoGitPagerEnv(), |
enne@chromium.org | 3b7e15c | 2014-01-21 17:44:47 +0000 | [diff] [blame] | 121 | stdout=subprocess2.PIPE, |
| 122 | stderr=stderr) |
szager@chromium.org | 9bb85e2 | 2012-06-13 20:28:23 +0000 | [diff] [blame] | 123 | return code, out[0] |
| 124 | except ValueError: |
| 125 | # When the subprocess fails, it returns None. That triggers a ValueError |
| 126 | # when trying to unpack the return value into (out, code). |
| 127 | return 1, '' |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 128 | |
| 129 | |
bauerb@chromium.org | 27386dd | 2015-02-16 10:45:39 +0000 | [diff] [blame] | 130 | def RunGitSilent(args): |
| 131 | """Returns stdout, suppresses stderr and ingores the return code.""" |
| 132 | return RunGitWithCode(args, suppress_stderr=True)[1] |
| 133 | |
| 134 | |
tapted@chromium.org | 6a0b07c | 2013-07-10 01:29:19 +0000 | [diff] [blame] | 135 | def IsGitVersionAtLeast(min_version): |
ilevy@chromium.org | cc56ee4 | 2013-07-10 22:16:29 +0000 | [diff] [blame] | 136 | prefix = 'git version ' |
tapted@chromium.org | 6a0b07c | 2013-07-10 01:29:19 +0000 | [diff] [blame] | 137 | version = RunGit(['--version']).strip() |
ilevy@chromium.org | cc56ee4 | 2013-07-10 22:16:29 +0000 | [diff] [blame] | 138 | return (version.startswith(prefix) and |
| 139 | LooseVersion(version[len(prefix):]) >= LooseVersion(min_version)) |
tapted@chromium.org | 6a0b07c | 2013-07-10 01:29:19 +0000 | [diff] [blame] | 140 | |
| 141 | |
pgervais@chromium.org | 8ba38ff | 2015-06-11 21:41:25 +0000 | [diff] [blame] | 142 | def BranchExists(branch): |
| 143 | """Return True if specified branch exists.""" |
| 144 | code, _ = RunGitWithCode(['rev-parse', '--verify', branch], |
| 145 | suppress_stderr=True) |
| 146 | return not code |
| 147 | |
| 148 | |
maruel@chromium.org | 9054173 | 2011-04-01 17:54:18 +0000 | [diff] [blame] | 149 | def ask_for_data(prompt): |
| 150 | try: |
| 151 | return raw_input(prompt) |
| 152 | except KeyboardInterrupt: |
| 153 | # Hide the exception. |
| 154 | sys.exit(1) |
| 155 | |
| 156 | |
iannucci@chromium.org | 7954005 | 2012-10-19 23:15:26 +0000 | [diff] [blame] | 157 | def git_set_branch_value(key, value): |
| 158 | branch = Changelist().GetBranch() |
rogerta@chromium.org | caa1655 | 2013-03-18 20:45:05 +0000 | [diff] [blame] | 159 | if not branch: |
| 160 | return |
| 161 | |
| 162 | cmd = ['config'] |
| 163 | if isinstance(value, int): |
| 164 | cmd.append('--int') |
| 165 | git_key = 'branch.%s.%s' % (branch, key) |
| 166 | RunGit(cmd + [git_key, str(value)]) |
iannucci@chromium.org | 7954005 | 2012-10-19 23:15:26 +0000 | [diff] [blame] | 167 | |
| 168 | |
| 169 | def git_get_branch_default(key, default): |
| 170 | branch = Changelist().GetBranch() |
| 171 | if branch: |
| 172 | git_key = 'branch.%s.%s' % (branch, key) |
| 173 | (_, stdout) = RunGitWithCode(['config', '--int', '--get', git_key]) |
| 174 | try: |
| 175 | return int(stdout.strip()) |
| 176 | except ValueError: |
| 177 | pass |
| 178 | return default |
| 179 | |
| 180 | |
iannucci@chromium.org | 53937ba | 2012-10-02 18:20:43 +0000 | [diff] [blame] | 181 | def add_git_similarity(parser): |
| 182 | parser.add_option( |
iannucci@chromium.org | 7954005 | 2012-10-19 23:15:26 +0000 | [diff] [blame] | 183 | '--similarity', metavar='SIM', type='int', action='store', |
iannucci@chromium.org | 53937ba | 2012-10-02 18:20:43 +0000 | [diff] [blame] | 184 | help='Sets the percentage that a pair of files need to match in order to' |
| 185 | ' be considered copies (default 50)') |
iannucci@chromium.org | 7954005 | 2012-10-19 23:15:26 +0000 | [diff] [blame] | 186 | parser.add_option( |
| 187 | '--find-copies', action='store_true', |
| 188 | help='Allows git to look for copies.') |
| 189 | parser.add_option( |
| 190 | '--no-find-copies', action='store_false', dest='find_copies', |
| 191 | help='Disallows git from looking for copies.') |
iannucci@chromium.org | 53937ba | 2012-10-02 18:20:43 +0000 | [diff] [blame] | 192 | |
| 193 | old_parser_args = parser.parse_args |
| 194 | def Parse(args): |
| 195 | options, args = old_parser_args(args) |
| 196 | |
iannucci@chromium.org | 53937ba | 2012-10-02 18:20:43 +0000 | [diff] [blame] | 197 | if options.similarity is None: |
iannucci@chromium.org | 7954005 | 2012-10-19 23:15:26 +0000 | [diff] [blame] | 198 | options.similarity = git_get_branch_default('git-cl-similarity', 50) |
iannucci@chromium.org | 53937ba | 2012-10-02 18:20:43 +0000 | [diff] [blame] | 199 | else: |
iannucci@chromium.org | 7954005 | 2012-10-19 23:15:26 +0000 | [diff] [blame] | 200 | print('Note: Saving similarity of %d%% in git config.' |
| 201 | % options.similarity) |
| 202 | git_set_branch_value('git-cl-similarity', options.similarity) |
iannucci@chromium.org | 53937ba | 2012-10-02 18:20:43 +0000 | [diff] [blame] | 203 | |
iannucci@chromium.org | 7954005 | 2012-10-19 23:15:26 +0000 | [diff] [blame] | 204 | options.similarity = max(0, min(options.similarity, 100)) |
| 205 | |
| 206 | if options.find_copies is None: |
| 207 | options.find_copies = bool( |
| 208 | git_get_branch_default('git-find-copies', True)) |
| 209 | else: |
| 210 | git_set_branch_value('git-find-copies', int(options.find_copies)) |
iannucci@chromium.org | 53937ba | 2012-10-02 18:20:43 +0000 | [diff] [blame] | 211 | |
| 212 | print('Using %d%% similarity for rename/copy detection. ' |
| 213 | 'Override with --similarity.' % options.similarity) |
| 214 | |
| 215 | return options, args |
| 216 | parser.parse_args = Parse |
| 217 | |
| 218 | |
machenbach@chromium.org | 4545314 | 2015-09-15 08:45:22 +0000 | [diff] [blame] | 219 | def _get_properties_from_options(options): |
| 220 | properties = dict(x.split('=', 1) for x in options.properties) |
| 221 | for key, val in properties.iteritems(): |
| 222 | try: |
| 223 | properties[key] = json.loads(val) |
| 224 | except ValueError: |
| 225 | pass # If a value couldn't be evaluated, treat it as a string. |
| 226 | return properties |
| 227 | |
| 228 | |
sheyang@google.com | 6ebaf78 | 2015-05-12 19:17:54 +0000 | [diff] [blame] | 229 | def _prefix_master(master): |
| 230 | """Convert user-specified master name to full master name. |
| 231 | |
| 232 | Buildbucket uses full master name(master.tryserver.chromium.linux) as bucket |
| 233 | name, while the developers always use shortened master name |
| 234 | (tryserver.chromium.linux) by stripping off the prefix 'master.'. This |
| 235 | function does the conversion for buildbucket migration. |
| 236 | """ |
| 237 | prefix = 'master.' |
| 238 | if master.startswith(prefix): |
| 239 | return master |
| 240 | return '%s%s' % (prefix, master) |
| 241 | |
| 242 | |
hinoka@chromium.org | feb9e2a | 2015-09-25 19:11:09 +0000 | [diff] [blame] | 243 | def trigger_luci_job(changelist, masters, options): |
| 244 | """Send a job to run on LUCI.""" |
| 245 | issue_props = changelist.GetIssueProperties() |
| 246 | issue = changelist.GetIssue() |
| 247 | patchset = changelist.GetMostRecentPatchset() |
| 248 | for builders_and_tests in sorted(masters.itervalues()): |
tandrii@chromium.org | 3764fa2 | 2015-10-21 16:40:40 +0000 | [diff] [blame] | 249 | # TODO(hinoka et al): add support for other properties. |
| 250 | # Currently, this completely ignores testfilter and other properties. |
| 251 | for builder in sorted(builders_and_tests): |
hinoka@chromium.org | feb9e2a | 2015-09-25 19:11:09 +0000 | [diff] [blame] | 252 | luci_trigger.trigger( |
| 253 | builder, 'HEAD', issue, patchset, issue_props['project']) |
| 254 | |
| 255 | |
machenbach@chromium.org | 4545314 | 2015-09-15 08:45:22 +0000 | [diff] [blame] | 256 | def trigger_try_jobs(auth_config, changelist, options, masters, category): |
sheyang@google.com | 6ebaf78 | 2015-05-12 19:17:54 +0000 | [diff] [blame] | 257 | rietveld_url = settings.GetDefaultServerUrl() |
| 258 | rietveld_host = urlparse.urlparse(rietveld_url).hostname |
| 259 | authenticator = auth.get_authenticator_for_host(rietveld_host, auth_config) |
| 260 | http = authenticator.authorize(httplib2.Http()) |
| 261 | http.force_exception_to_status_code = True |
| 262 | issue_props = changelist.GetIssueProperties() |
| 263 | issue = changelist.GetIssue() |
| 264 | patchset = changelist.GetMostRecentPatchset() |
machenbach@chromium.org | 4545314 | 2015-09-15 08:45:22 +0000 | [diff] [blame] | 265 | properties = _get_properties_from_options(options) |
sheyang@google.com | 6ebaf78 | 2015-05-12 19:17:54 +0000 | [diff] [blame] | 266 | |
| 267 | buildbucket_put_url = ( |
| 268 | 'https://{hostname}/_ah/api/buildbucket/v1/builds/batch'.format( |
sheyang@chromium.org | db37557 | 2015-08-17 19:22:23 +0000 | [diff] [blame] | 269 | hostname=options.buildbucket_host)) |
sheyang@google.com | 6ebaf78 | 2015-05-12 19:17:54 +0000 | [diff] [blame] | 270 | buildset = 'patch/rietveld/{hostname}/{issue}/{patch}'.format( |
| 271 | hostname=rietveld_host, |
| 272 | issue=issue, |
| 273 | patch=patchset) |
| 274 | |
| 275 | batch_req_body = {'builds': []} |
| 276 | print_text = [] |
| 277 | print_text.append('Tried jobs on:') |
| 278 | for master, builders_and_tests in sorted(masters.iteritems()): |
| 279 | print_text.append('Master: %s' % master) |
| 280 | bucket = _prefix_master(master) |
| 281 | for builder, tests in sorted(builders_and_tests.iteritems()): |
| 282 | print_text.append(' %s: %s' % (builder, tests)) |
| 283 | parameters = { |
| 284 | 'builder_name': builder, |
nodir@chromium.org | d221731 | 2015-09-21 15:51:21 +0000 | [diff] [blame] | 285 | 'changes': [{ |
| 286 | 'author': {'email': issue_props['owner_email']}, |
| 287 | 'revision': options.revision, |
| 288 | }], |
sheyang@google.com | 6ebaf78 | 2015-05-12 19:17:54 +0000 | [diff] [blame] | 289 | 'properties': { |
| 290 | 'category': category, |
| 291 | 'issue': issue, |
| 292 | 'master': master, |
| 293 | 'patch_project': issue_props['project'], |
| 294 | 'patch_storage': 'rietveld', |
| 295 | 'patchset': patchset, |
| 296 | 'reason': options.name, |
sheyang@google.com | 6ebaf78 | 2015-05-12 19:17:54 +0000 | [diff] [blame] | 297 | 'rietveld': rietveld_url, |
sheyang@google.com | 6ebaf78 | 2015-05-12 19:17:54 +0000 | [diff] [blame] | 298 | }, |
| 299 | } |
tandrii@chromium.org | 3764fa2 | 2015-10-21 16:40:40 +0000 | [diff] [blame] | 300 | if tests: |
| 301 | parameters['properties']['testfilter'] = tests |
machenbach@chromium.org | 4545314 | 2015-09-15 08:45:22 +0000 | [diff] [blame] | 302 | if properties: |
| 303 | parameters['properties'].update(properties) |
sheyang@google.com | 6ebaf78 | 2015-05-12 19:17:54 +0000 | [diff] [blame] | 304 | if options.clobber: |
| 305 | parameters['properties']['clobber'] = True |
| 306 | batch_req_body['builds'].append( |
| 307 | { |
| 308 | 'bucket': bucket, |
| 309 | 'parameters_json': json.dumps(parameters), |
| 310 | 'tags': ['builder:%s' % builder, |
| 311 | 'buildset:%s' % buildset, |
| 312 | 'master:%s' % master, |
| 313 | 'user_agent:git_cl_try'] |
| 314 | } |
| 315 | ) |
| 316 | |
| 317 | for try_count in xrange(3): |
| 318 | response, content = http.request( |
| 319 | buildbucket_put_url, |
| 320 | 'PUT', |
| 321 | body=json.dumps(batch_req_body), |
| 322 | headers={'Content-Type': 'application/json'}, |
| 323 | ) |
| 324 | content_json = None |
| 325 | try: |
| 326 | content_json = json.loads(content) |
| 327 | except ValueError: |
| 328 | pass |
| 329 | |
| 330 | # Buildbucket could return an error even if status==200. |
| 331 | if content_json and content_json.get('error'): |
| 332 | msg = 'Error in response. Code: %d. Reason: %s. Message: %s.' % ( |
| 333 | content_json['error'].get('code', ''), |
| 334 | content_json['error'].get('reason', ''), |
| 335 | content_json['error'].get('message', '')) |
| 336 | raise BuildbucketResponseException(msg) |
| 337 | |
| 338 | if response.status == 200: |
| 339 | if not content_json: |
| 340 | raise BuildbucketResponseException( |
| 341 | 'Buildbucket returns invalid json content: %s.\n' |
| 342 | 'Please file bugs at crbug.com, label "Infra-BuildBucket".' % |
| 343 | content) |
| 344 | break |
| 345 | if response.status < 500 or try_count >= 2: |
| 346 | raise httplib2.HttpLib2Error(content) |
| 347 | |
| 348 | # status >= 500 means transient failures. |
| 349 | logging.debug('Transient errors when triggering tryjobs. Will retry.') |
| 350 | time.sleep(0.5 + 1.5*try_count) |
| 351 | |
| 352 | print '\n'.join(print_text) |
kjellander@chromium.org | 4442454 | 2015-06-02 18:35:29 +0000 | [diff] [blame] | 353 | |
sheyang@google.com | 6ebaf78 | 2015-05-12 19:17:54 +0000 | [diff] [blame] | 354 | |
bauerb@chromium.org | 866276c | 2011-03-18 20:09:31 +0000 | [diff] [blame] | 355 | def MatchSvnGlob(url, base_url, glob_spec, allow_wildcards): |
| 356 | """Return the corresponding git ref if |base_url| together with |glob_spec| |
| 357 | matches the full |url|. |
| 358 | |
| 359 | If |allow_wildcards| is true, |glob_spec| can contain wildcards (see below). |
| 360 | """ |
| 361 | fetch_suburl, as_ref = glob_spec.split(':') |
| 362 | if allow_wildcards: |
| 363 | glob_match = re.match('(.+/)?(\*|{[^/]*})(/.+)?', fetch_suburl) |
| 364 | if glob_match: |
| 365 | # Parse specs like "branches/*/src:refs/remotes/svn/*" or |
| 366 | # "branches/{472,597,648}/src:refs/remotes/svn/*". |
| 367 | branch_re = re.escape(base_url) |
| 368 | if glob_match.group(1): |
| 369 | branch_re += '/' + re.escape(glob_match.group(1)) |
| 370 | wildcard = glob_match.group(2) |
| 371 | if wildcard == '*': |
| 372 | branch_re += '([^/]*)' |
| 373 | else: |
| 374 | # Escape and replace surrounding braces with parentheses and commas |
| 375 | # with pipe symbols. |
| 376 | wildcard = re.escape(wildcard) |
| 377 | wildcard = re.sub('^\\\\{', '(', wildcard) |
| 378 | wildcard = re.sub('\\\\,', '|', wildcard) |
| 379 | wildcard = re.sub('\\\\}$', ')', wildcard) |
| 380 | branch_re += wildcard |
| 381 | if glob_match.group(3): |
| 382 | branch_re += re.escape(glob_match.group(3)) |
| 383 | match = re.match(branch_re, url) |
| 384 | if match: |
| 385 | return re.sub('\*$', match.group(1), as_ref) |
| 386 | |
| 387 | # Parse specs like "trunk/src:refs/remotes/origin/trunk". |
| 388 | if fetch_suburl: |
| 389 | full_url = base_url + '/' + fetch_suburl |
| 390 | else: |
| 391 | full_url = base_url |
| 392 | if full_url == url: |
| 393 | return as_ref |
| 394 | return None |
| 395 | |
maruel@chromium.org | 32f9f5e | 2011-09-14 13:41:47 +0000 | [diff] [blame] | 396 | |
iannucci@chromium.org | 7954005 | 2012-10-19 23:15:26 +0000 | [diff] [blame] | 397 | def print_stats(similarity, find_copies, args): |
maruel@chromium.org | 49e3d80 | 2012-07-18 23:54:45 +0000 | [diff] [blame] | 398 | """Prints statistics about the change to the user.""" |
| 399 | # --no-ext-diff is broken in some versions of Git, so try to work around |
| 400 | # this by overriding the environment (but there is still a problem if the |
| 401 | # git config key "diff.external" is used). |
thestig@chromium.org | 8b0553c | 2014-02-11 00:33:37 +0000 | [diff] [blame] | 402 | env = GetNoGitPagerEnv() |
maruel@chromium.org | 49e3d80 | 2012-07-18 23:54:45 +0000 | [diff] [blame] | 403 | if 'GIT_EXTERNAL_DIFF' in env: |
| 404 | del env['GIT_EXTERNAL_DIFF'] |
iannucci@chromium.org | 7954005 | 2012-10-19 23:15:26 +0000 | [diff] [blame] | 405 | |
| 406 | if find_copies: |
| 407 | similarity_options = ['--find-copies-harder', '-l100000', |
| 408 | '-C%s' % similarity] |
| 409 | else: |
| 410 | similarity_options = ['-M%s' % similarity] |
| 411 | |
szager@chromium.org | d057f9a | 2014-05-29 21:09:36 +0000 | [diff] [blame] | 412 | try: |
| 413 | stdout = sys.stdout.fileno() |
| 414 | except AttributeError: |
| 415 | stdout = None |
maruel@chromium.org | 49e3d80 | 2012-07-18 23:54:45 +0000 | [diff] [blame] | 416 | return subprocess2.call( |
bratell@opera.com | 82b91cd | 2013-07-09 06:33:41 +0000 | [diff] [blame] | 417 | ['git', |
bratell@opera.com | f267b0e | 2013-05-02 09:11:43 +0000 | [diff] [blame] | 418 | 'diff', '--no-ext-diff', '--stat'] + similarity_options + args, |
szager@chromium.org | d057f9a | 2014-05-29 21:09:36 +0000 | [diff] [blame] | 419 | stdout=stdout, env=env) |
maruel@chromium.org | 49e3d80 | 2012-07-18 23:54:45 +0000 | [diff] [blame] | 420 | |
| 421 | |
sheyang@google.com | 6ebaf78 | 2015-05-12 19:17:54 +0000 | [diff] [blame] | 422 | class BuildbucketResponseException(Exception): |
| 423 | pass |
| 424 | |
| 425 | |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 426 | class Settings(object): |
| 427 | def __init__(self): |
| 428 | self.default_server = None |
| 429 | self.cc = None |
thestig@chromium.org | 7a54e81 | 2014-02-11 19:57:22 +0000 | [diff] [blame] | 430 | self.root = None |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 431 | self.is_git_svn = None |
| 432 | self.svn_branch = None |
| 433 | self.tree_status_url = None |
| 434 | self.viewvc_url = None |
| 435 | self.updated = False |
ukai@chromium.org | e807781 | 2012-02-03 03:41:46 +0000 | [diff] [blame] | 436 | self.is_gerrit = None |
bauerb@chromium.org | 54b400c | 2016-01-14 10:08:25 +0000 | [diff] [blame] | 437 | self.squash_gerrit_uploads = None |
jbroman@chromium.org | 615a262 | 2013-05-03 13:20:14 +0000 | [diff] [blame] | 438 | self.git_editor = None |
sheyang@chromium.org | 152cf83 | 2014-06-11 21:37:49 +0000 | [diff] [blame] | 439 | self.project = None |
kjellander@chromium.org | 6abc652 | 2014-12-02 07:34:49 +0000 | [diff] [blame] | 440 | self.force_https_commit_url = None |
vadimsh@chromium.org | 566a02a | 2014-08-22 01:34:13 +0000 | [diff] [blame] | 441 | self.pending_ref_prefix = None |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 442 | |
| 443 | def LazyUpdateIfNeeded(self): |
| 444 | """Updates the settings from a codereview.settings file, if available.""" |
| 445 | if not self.updated: |
pgervais@chromium.org | 87884cc | 2014-01-03 22:23:41 +0000 | [diff] [blame] | 446 | # The only value that actually changes the behavior is |
| 447 | # autoupdate = "false". Everything else means "true". |
nick@chromium.org | 3ac1c4e | 2014-01-16 02:44:42 +0000 | [diff] [blame] | 448 | autoupdate = RunGit(['config', 'rietveld.autoupdate'], |
pgervais@chromium.org | 87884cc | 2014-01-03 22:23:41 +0000 | [diff] [blame] | 449 | error_ok=True |
| 450 | ).strip().lower() |
| 451 | |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 452 | cr_settings_file = FindCodereviewSettingsFile() |
pgervais@chromium.org | 87884cc | 2014-01-03 22:23:41 +0000 | [diff] [blame] | 453 | if autoupdate != 'false' and cr_settings_file: |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 454 | LoadCodereviewSettingsFromFile(cr_settings_file) |
pgervais@chromium.org | 87884cc | 2014-01-03 22:23:41 +0000 | [diff] [blame] | 455 | # set updated to True to avoid infinite calling loop |
| 456 | # through DownloadHooks |
ukai@chromium.org | 78c4b98 | 2012-02-14 02:20:26 +0000 | [diff] [blame] | 457 | self.updated = True |
| 458 | DownloadHooks(False) |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 459 | self.updated = True |
| 460 | |
| 461 | def GetDefaultServerUrl(self, error_ok=False): |
| 462 | if not self.default_server: |
| 463 | self.LazyUpdateIfNeeded() |
maruel@chromium.org | eb5edbc | 2012-01-16 17:03:28 +0000 | [diff] [blame] | 464 | self.default_server = gclient_utils.UpgradeToHttps( |
thestig@chromium.org | 8b0553c | 2014-02-11 00:33:37 +0000 | [diff] [blame] | 465 | self._GetRietveldConfig('server', error_ok=True)) |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 466 | if error_ok: |
| 467 | return self.default_server |
| 468 | if not self.default_server: |
| 469 | error_message = ('Could not find settings file. You must configure ' |
| 470 | 'your review setup by running "git cl config".') |
maruel@chromium.org | eb5edbc | 2012-01-16 17:03:28 +0000 | [diff] [blame] | 471 | self.default_server = gclient_utils.UpgradeToHttps( |
thestig@chromium.org | 8b0553c | 2014-02-11 00:33:37 +0000 | [diff] [blame] | 472 | self._GetRietveldConfig('server', error_message=error_message)) |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 473 | return self.default_server |
| 474 | |
thestig@chromium.org | 7a54e81 | 2014-02-11 19:57:22 +0000 | [diff] [blame] | 475 | @staticmethod |
| 476 | def GetRelativeRoot(): |
| 477 | return RunGit(['rev-parse', '--show-cdup']).strip() |
thestig@chromium.org | 8b0553c | 2014-02-11 00:33:37 +0000 | [diff] [blame] | 478 | |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 479 | def GetRoot(self): |
thestig@chromium.org | 7a54e81 | 2014-02-11 19:57:22 +0000 | [diff] [blame] | 480 | if self.root is None: |
| 481 | self.root = os.path.abspath(self.GetRelativeRoot()) |
| 482 | return self.root |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 483 | |
| 484 | def GetIsGitSvn(self): |
| 485 | """Return true if this repo looks like it's using git-svn.""" |
| 486 | if self.is_git_svn is None: |
vadimsh@chromium.org | 566a02a | 2014-08-22 01:34:13 +0000 | [diff] [blame] | 487 | if self.GetPendingRefPrefix(): |
| 488 | # If PENDING_REF_PREFIX is set then it's a pure git repo no matter what. |
| 489 | self.is_git_svn = False |
| 490 | else: |
| 491 | # If you have any "svn-remote.*" config keys, we think you're using svn. |
| 492 | self.is_git_svn = RunGitWithCode( |
| 493 | ['config', '--local', '--get-regexp', r'^svn-remote\.'])[0] == 0 |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 494 | return self.is_git_svn |
| 495 | |
| 496 | def GetSVNBranch(self): |
| 497 | if self.svn_branch is None: |
| 498 | if not self.GetIsGitSvn(): |
| 499 | DieWithError('Repo doesn\'t appear to be a git-svn repo.') |
| 500 | |
| 501 | # Try to figure out which remote branch we're based on. |
| 502 | # Strategy: |
bauerb@chromium.org | ade368c | 2011-03-01 08:57:50 +0000 | [diff] [blame] | 503 | # 1) iterate through our branch history and find the svn URL. |
| 504 | # 2) find the svn-remote that fetches from the URL. |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 505 | |
| 506 | # regexp matching the git-svn line that contains the URL. |
| 507 | git_svn_re = re.compile(r'^\s*git-svn-id: (\S+)@', re.MULTILINE) |
| 508 | |
bauerb@chromium.org | ade368c | 2011-03-01 08:57:50 +0000 | [diff] [blame] | 509 | # We don't want to go through all of history, so read a line from the |
| 510 | # pipe at a time. |
| 511 | # The -100 is an arbitrary limit so we don't search forever. |
bratell@opera.com | 82b91cd | 2013-07-09 06:33:41 +0000 | [diff] [blame] | 512 | cmd = ['git', 'log', '-100', '--pretty=medium'] |
thestig@chromium.org | 8b0553c | 2014-02-11 00:33:37 +0000 | [diff] [blame] | 513 | proc = subprocess2.Popen(cmd, stdout=subprocess2.PIPE, |
| 514 | env=GetNoGitPagerEnv()) |
maruel@chromium.org | 740f9d7 | 2011-06-10 18:33:10 +0000 | [diff] [blame] | 515 | url = None |
bauerb@chromium.org | ade368c | 2011-03-01 08:57:50 +0000 | [diff] [blame] | 516 | for line in proc.stdout: |
| 517 | match = git_svn_re.match(line) |
| 518 | if match: |
| 519 | url = match.group(1) |
| 520 | proc.stdout.close() # Cut pipe. |
| 521 | break |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 522 | |
bauerb@chromium.org | ade368c | 2011-03-01 08:57:50 +0000 | [diff] [blame] | 523 | if url: |
| 524 | svn_remote_re = re.compile(r'^svn-remote\.([^.]+)\.url (.*)$') |
| 525 | remotes = RunGit(['config', '--get-regexp', |
| 526 | r'^svn-remote\..*\.url']).splitlines() |
| 527 | for remote in remotes: |
| 528 | match = svn_remote_re.match(remote) |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 529 | if match: |
bauerb@chromium.org | ade368c | 2011-03-01 08:57:50 +0000 | [diff] [blame] | 530 | remote = match.group(1) |
| 531 | base_url = match.group(2) |
szager@chromium.org | 4ac2553 | 2013-12-16 22:07:02 +0000 | [diff] [blame] | 532 | rewrite_root = RunGit( |
| 533 | ['config', 'svn-remote.%s.rewriteRoot' % remote], |
| 534 | error_ok=True).strip() |
| 535 | if rewrite_root: |
| 536 | base_url = rewrite_root |
bauerb@chromium.org | ade368c | 2011-03-01 08:57:50 +0000 | [diff] [blame] | 537 | fetch_spec = RunGit( |
bauerb@chromium.org | 866276c | 2011-03-18 20:09:31 +0000 | [diff] [blame] | 538 | ['config', 'svn-remote.%s.fetch' % remote], |
| 539 | error_ok=True).strip() |
| 540 | if fetch_spec: |
| 541 | self.svn_branch = MatchSvnGlob(url, base_url, fetch_spec, False) |
| 542 | if self.svn_branch: |
| 543 | break |
| 544 | branch_spec = RunGit( |
| 545 | ['config', 'svn-remote.%s.branches' % remote], |
| 546 | error_ok=True).strip() |
| 547 | if branch_spec: |
| 548 | self.svn_branch = MatchSvnGlob(url, base_url, branch_spec, True) |
| 549 | if self.svn_branch: |
| 550 | break |
| 551 | tag_spec = RunGit( |
| 552 | ['config', 'svn-remote.%s.tags' % remote], |
| 553 | error_ok=True).strip() |
| 554 | if tag_spec: |
| 555 | self.svn_branch = MatchSvnGlob(url, base_url, tag_spec, True) |
| 556 | if self.svn_branch: |
| 557 | break |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 558 | |
| 559 | if not self.svn_branch: |
| 560 | DieWithError('Can\'t guess svn branch -- try specifying it on the ' |
| 561 | 'command line') |
| 562 | |
| 563 | return self.svn_branch |
| 564 | |
| 565 | def GetTreeStatusUrl(self, error_ok=False): |
| 566 | if not self.tree_status_url: |
| 567 | error_message = ('You must configure your tree status URL by running ' |
| 568 | '"git cl config".') |
thestig@chromium.org | 8b0553c | 2014-02-11 00:33:37 +0000 | [diff] [blame] | 569 | self.tree_status_url = self._GetRietveldConfig( |
| 570 | 'tree-status-url', error_ok=error_ok, error_message=error_message) |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 571 | return self.tree_status_url |
| 572 | |
| 573 | def GetViewVCUrl(self): |
| 574 | if not self.viewvc_url: |
thestig@chromium.org | 8b0553c | 2014-02-11 00:33:37 +0000 | [diff] [blame] | 575 | self.viewvc_url = self._GetRietveldConfig('viewvc-url', error_ok=True) |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 576 | return self.viewvc_url |
| 577 | |
rmistry@google.com | 9075258 | 2014-01-14 21:04:50 +0000 | [diff] [blame] | 578 | def GetBugPrefix(self): |
thestig@chromium.org | 8b0553c | 2014-02-11 00:33:37 +0000 | [diff] [blame] | 579 | return self._GetRietveldConfig('bug-prefix', error_ok=True) |
rmistry@google.com | 9075258 | 2014-01-14 21:04:50 +0000 | [diff] [blame] | 580 | |
rmistry@google.com | 78948ed | 2015-07-08 23:09:57 +0000 | [diff] [blame] | 581 | def GetIsSkipDependencyUpload(self, branch_name): |
| 582 | """Returns true if specified branch should skip dep uploads.""" |
| 583 | return self._GetBranchConfig(branch_name, 'skip-deps-uploads', |
| 584 | error_ok=True) |
| 585 | |
rmistry@google.com | 5626a92 | 2015-02-26 14:03:30 +0000 | [diff] [blame] | 586 | def GetRunPostUploadHook(self): |
| 587 | run_post_upload_hook = self._GetRietveldConfig( |
| 588 | 'run-post-upload-hook', error_ok=True) |
| 589 | return run_post_upload_hook == "True" |
| 590 | |
bauerb@chromium.org | ae6df35 | 2011-04-06 17:40:39 +0000 | [diff] [blame] | 591 | def GetDefaultCCList(self): |
thestig@chromium.org | 8b0553c | 2014-02-11 00:33:37 +0000 | [diff] [blame] | 592 | return self._GetRietveldConfig('cc', error_ok=True) |
bauerb@chromium.org | ae6df35 | 2011-04-06 17:40:39 +0000 | [diff] [blame] | 593 | |
tyoshino@chromium.org | c1737d0 | 2013-05-29 14:17:28 +0000 | [diff] [blame] | 594 | def GetDefaultPrivateFlag(self): |
thestig@chromium.org | 8b0553c | 2014-02-11 00:33:37 +0000 | [diff] [blame] | 595 | return self._GetRietveldConfig('private', error_ok=True) |
tyoshino@chromium.org | c1737d0 | 2013-05-29 14:17:28 +0000 | [diff] [blame] | 596 | |
ukai@chromium.org | e807781 | 2012-02-03 03:41:46 +0000 | [diff] [blame] | 597 | def GetIsGerrit(self): |
| 598 | """Return true if this repo is assosiated with gerrit code review system.""" |
| 599 | if self.is_gerrit is None: |
| 600 | self.is_gerrit = self._GetConfig('gerrit.host', error_ok=True) |
| 601 | return self.is_gerrit |
| 602 | |
bauerb@chromium.org | 54b400c | 2016-01-14 10:08:25 +0000 | [diff] [blame] | 603 | def GetSquashGerritUploads(self): |
| 604 | """Return true if uploads to Gerrit should be squashed by default.""" |
| 605 | if self.squash_gerrit_uploads is None: |
| 606 | self.squash_gerrit_uploads = ( |
| 607 | RunGit(['config', '--bool', 'gerrit.squash-uploads'], |
| 608 | error_ok=True).strip() == 'true') |
| 609 | return self.squash_gerrit_uploads |
| 610 | |
jbroman@chromium.org | 615a262 | 2013-05-03 13:20:14 +0000 | [diff] [blame] | 611 | def GetGitEditor(self): |
| 612 | """Return the editor specified in the git config, or None if none is.""" |
| 613 | if self.git_editor is None: |
| 614 | self.git_editor = self._GetConfig('core.editor', error_ok=True) |
| 615 | return self.git_editor or None |
| 616 | |
thestig@chromium.org | 44202a2 | 2014-03-11 19:22:18 +0000 | [diff] [blame] | 617 | def GetLintRegex(self): |
| 618 | return (self._GetRietveldConfig('cpplint-regex', error_ok=True) or |
| 619 | DEFAULT_LINT_REGEX) |
| 620 | |
| 621 | def GetLintIgnoreRegex(self): |
| 622 | return (self._GetRietveldConfig('cpplint-ignore-regex', error_ok=True) or |
| 623 | DEFAULT_LINT_IGNORE_REGEX) |
| 624 | |
sheyang@chromium.org | 152cf83 | 2014-06-11 21:37:49 +0000 | [diff] [blame] | 625 | def GetProject(self): |
| 626 | if not self.project: |
| 627 | self.project = self._GetRietveldConfig('project', error_ok=True) |
| 628 | return self.project |
| 629 | |
kjellander@chromium.org | 6abc652 | 2014-12-02 07:34:49 +0000 | [diff] [blame] | 630 | def GetForceHttpsCommitUrl(self): |
| 631 | if not self.force_https_commit_url: |
| 632 | self.force_https_commit_url = self._GetRietveldConfig( |
| 633 | 'force-https-commit-url', error_ok=True) |
| 634 | return self.force_https_commit_url |
| 635 | |
vadimsh@chromium.org | 566a02a | 2014-08-22 01:34:13 +0000 | [diff] [blame] | 636 | def GetPendingRefPrefix(self): |
| 637 | if not self.pending_ref_prefix: |
| 638 | self.pending_ref_prefix = self._GetRietveldConfig( |
| 639 | 'pending-ref-prefix', error_ok=True) |
| 640 | return self.pending_ref_prefix |
| 641 | |
thestig@chromium.org | 8b0553c | 2014-02-11 00:33:37 +0000 | [diff] [blame] | 642 | def _GetRietveldConfig(self, param, **kwargs): |
| 643 | return self._GetConfig('rietveld.' + param, **kwargs) |
| 644 | |
rmistry@google.com | 78948ed | 2015-07-08 23:09:57 +0000 | [diff] [blame] | 645 | def _GetBranchConfig(self, branch_name, param, **kwargs): |
| 646 | return self._GetConfig('branch.' + branch_name + '.' + param, **kwargs) |
| 647 | |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 648 | def _GetConfig(self, param, **kwargs): |
| 649 | self.LazyUpdateIfNeeded() |
| 650 | return RunGit(['config', param], **kwargs).strip() |
| 651 | |
| 652 | |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 653 | def ShortBranchName(branch): |
| 654 | """Convert a name like 'refs/heads/foo' to just 'foo'.""" |
| 655 | return branch.replace('refs/heads/', '') |
| 656 | |
| 657 | |
| 658 | class Changelist(object): |
vadimsh@chromium.org | cf6a5d2 | 2015-04-09 22:02:00 +0000 | [diff] [blame] | 659 | def __init__(self, branchref=None, issue=None, auth_config=None): |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 660 | # Poke settings so we get the "configure your server" message if necessary. |
maruel@chromium.org | 379d07a | 2011-11-30 14:58:10 +0000 | [diff] [blame] | 661 | global settings |
| 662 | if not settings: |
| 663 | # Happens when git_cl.py is used as a utility library. |
| 664 | settings = Settings() |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 665 | settings.GetDefaultServerUrl() |
| 666 | self.branchref = branchref |
| 667 | if self.branchref: |
| 668 | self.branch = ShortBranchName(self.branchref) |
| 669 | else: |
| 670 | self.branch = None |
| 671 | self.rietveld_server = None |
| 672 | self.upstream_branch = None |
maruel@chromium.org | 1033efd | 2013-07-23 23:25:09 +0000 | [diff] [blame] | 673 | self.lookedup_issue = False |
| 674 | self.issue = issue or None |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 675 | self.has_description = False |
| 676 | self.description = None |
maruel@chromium.org | 1033efd | 2013-07-23 23:25:09 +0000 | [diff] [blame] | 677 | self.lookedup_patchset = False |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 678 | self.patchset = None |
bauerb@chromium.org | ae6df35 | 2011-04-06 17:40:39 +0000 | [diff] [blame] | 679 | self.cc = None |
| 680 | self.watchers = () |
vadimsh@chromium.org | cf6a5d2 | 2015-04-09 22:02:00 +0000 | [diff] [blame] | 681 | self._auth_config = auth_config |
maruel@chromium.org | 1033efd | 2013-07-23 23:25:09 +0000 | [diff] [blame] | 682 | self._props = None |
vadimsh@chromium.org | cf6a5d2 | 2015-04-09 22:02:00 +0000 | [diff] [blame] | 683 | self._remote = None |
| 684 | self._rpc_server = None |
| 685 | |
| 686 | @property |
| 687 | def auth_config(self): |
| 688 | return self._auth_config |
bauerb@chromium.org | ae6df35 | 2011-04-06 17:40:39 +0000 | [diff] [blame] | 689 | |
| 690 | def GetCCList(self): |
| 691 | """Return the users cc'd on this CL. |
| 692 | |
| 693 | Return is a string suitable for passing to gcl with the --cc flag. |
| 694 | """ |
| 695 | if self.cc is None: |
tyoshino@chromium.org | 99918ab | 2013-09-30 06:17:28 +0000 | [diff] [blame] | 696 | base_cc = settings.GetDefaultCCList() |
bauerb@chromium.org | ae6df35 | 2011-04-06 17:40:39 +0000 | [diff] [blame] | 697 | more_cc = ','.join(self.watchers) |
| 698 | self.cc = ','.join(filter(None, (base_cc, more_cc))) or '' |
| 699 | return self.cc |
| 700 | |
tyoshino@chromium.org | 99918ab | 2013-09-30 06:17:28 +0000 | [diff] [blame] | 701 | def GetCCListWithoutDefault(self): |
| 702 | """Return the users cc'd on this CL excluding default ones.""" |
| 703 | if self.cc is None: |
| 704 | self.cc = ','.join(self.watchers) |
| 705 | return self.cc |
| 706 | |
bauerb@chromium.org | ae6df35 | 2011-04-06 17:40:39 +0000 | [diff] [blame] | 707 | def SetWatchers(self, watchers): |
| 708 | """Set the list of email addresses that should be cc'd based on the changed |
| 709 | files in this CL. |
| 710 | """ |
| 711 | self.watchers = watchers |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 712 | |
| 713 | def GetBranch(self): |
| 714 | """Returns the short branch name, e.g. 'master'.""" |
| 715 | if not self.branch: |
szager@chromium.org | d62c61f | 2014-10-20 22:33:21 +0000 | [diff] [blame] | 716 | branchref = RunGit(['symbolic-ref', 'HEAD'], |
| 717 | stderr=subprocess2.VOID, error_ok=True).strip() |
| 718 | if not branchref: |
| 719 | return None |
| 720 | self.branchref = branchref |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 721 | self.branch = ShortBranchName(self.branchref) |
| 722 | return self.branch |
| 723 | |
| 724 | def GetBranchRef(self): |
| 725 | """Returns the full branch name, e.g. 'refs/heads/master'.""" |
| 726 | self.GetBranch() # Poke the lazy loader. |
| 727 | return self.branchref |
| 728 | |
ilevy@chromium.org | 0f58fa8 | 2012-11-05 01:45:20 +0000 | [diff] [blame] | 729 | @staticmethod |
| 730 | def FetchUpstreamTuple(branch): |
pgervais@chromium.org | d6617f3 | 2013-11-19 00:34:54 +0000 | [diff] [blame] | 731 | """Returns a tuple containing remote and remote ref, |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 732 | e.g. 'origin', 'refs/heads/master' |
| 733 | """ |
| 734 | remote = '.' |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 735 | upstream_branch = RunGit(['config', 'branch.%s.merge' % branch], |
| 736 | error_ok=True).strip() |
| 737 | if upstream_branch: |
| 738 | remote = RunGit(['config', 'branch.%s.remote' % branch]).strip() |
| 739 | else: |
bauerb@chromium.org | ade368c | 2011-03-01 08:57:50 +0000 | [diff] [blame] | 740 | upstream_branch = RunGit(['config', 'rietveld.upstream-branch'], |
| 741 | error_ok=True).strip() |
| 742 | if upstream_branch: |
| 743 | remote = RunGit(['config', 'rietveld.upstream-remote']).strip() |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 744 | else: |
bauerb@chromium.org | ade368c | 2011-03-01 08:57:50 +0000 | [diff] [blame] | 745 | # Fall back on trying a git-svn upstream branch. |
| 746 | if settings.GetIsGitSvn(): |
| 747 | upstream_branch = settings.GetSVNBranch() |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 748 | else: |
bauerb@chromium.org | ade368c | 2011-03-01 08:57:50 +0000 | [diff] [blame] | 749 | # Else, try to guess the origin remote. |
| 750 | remote_branches = RunGit(['branch', '-r']).split() |
| 751 | if 'origin/master' in remote_branches: |
| 752 | # Fall back on origin/master if it exits. |
| 753 | remote = 'origin' |
| 754 | upstream_branch = 'refs/heads/master' |
| 755 | elif 'origin/trunk' in remote_branches: |
| 756 | # Fall back on origin/trunk if it exists. Generally a shared |
| 757 | # git-svn clone |
| 758 | remote = 'origin' |
| 759 | upstream_branch = 'refs/heads/trunk' |
| 760 | else: |
| 761 | DieWithError("""Unable to determine default branch to diff against. |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 762 | Either pass complete "git diff"-style arguments, like |
| 763 | git cl upload origin/master |
| 764 | or verify this branch is set up to track another (via the --track argument to |
| 765 | "git checkout -b ...").""") |
| 766 | |
| 767 | return remote, upstream_branch |
| 768 | |
thestig@chromium.org | 8b0553c | 2014-02-11 00:33:37 +0000 | [diff] [blame] | 769 | def GetCommonAncestorWithUpstream(self): |
pgervais@chromium.org | 8ba38ff | 2015-06-11 21:41:25 +0000 | [diff] [blame] | 770 | upstream_branch = self.GetUpstreamBranch() |
| 771 | if not BranchExists(upstream_branch): |
| 772 | DieWithError('The upstream for the current branch (%s) does not exist ' |
| 773 | 'anymore.\nPlease fix it and try again.' % self.GetBranch()) |
iannucci@chromium.org | 9e84927 | 2014-04-04 00:31:55 +0000 | [diff] [blame] | 774 | return git_common.get_or_create_merge_base(self.GetBranch(), |
pgervais@chromium.org | 8ba38ff | 2015-06-11 21:41:25 +0000 | [diff] [blame] | 775 | upstream_branch) |
thestig@chromium.org | 8b0553c | 2014-02-11 00:33:37 +0000 | [diff] [blame] | 776 | |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 777 | def GetUpstreamBranch(self): |
| 778 | if self.upstream_branch is None: |
ilevy@chromium.org | 0f58fa8 | 2012-11-05 01:45:20 +0000 | [diff] [blame] | 779 | remote, upstream_branch = self.FetchUpstreamTuple(self.GetBranch()) |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 780 | if remote is not '.': |
mmoss@chromium.org | e758545 | 2014-08-24 01:41:11 +0000 | [diff] [blame] | 781 | upstream_branch = upstream_branch.replace('refs/heads/', |
| 782 | 'refs/remotes/%s/' % remote) |
| 783 | upstream_branch = upstream_branch.replace('refs/branch-heads/', |
| 784 | 'refs/remotes/branch-heads/') |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 785 | self.upstream_branch = upstream_branch |
| 786 | return self.upstream_branch |
| 787 | |
ilevy@chromium.org | 0f58fa8 | 2012-11-05 01:45:20 +0000 | [diff] [blame] | 788 | def GetRemoteBranch(self): |
jmbaker@chromium.org | a2cbbbb | 2012-03-22 20:40:40 +0000 | [diff] [blame] | 789 | if not self._remote: |
ilevy@chromium.org | 0f58fa8 | 2012-11-05 01:45:20 +0000 | [diff] [blame] | 790 | remote, branch = None, self.GetBranch() |
| 791 | seen_branches = set() |
| 792 | while branch not in seen_branches: |
| 793 | seen_branches.add(branch) |
| 794 | remote, branch = self.FetchUpstreamTuple(branch) |
| 795 | branch = ShortBranchName(branch) |
| 796 | if remote != '.' or branch.startswith('refs/remotes'): |
| 797 | break |
| 798 | else: |
jmbaker@chromium.org | a2cbbbb | 2012-03-22 20:40:40 +0000 | [diff] [blame] | 799 | remotes = RunGit(['remote'], error_ok=True).split() |
| 800 | if len(remotes) == 1: |
ilevy@chromium.org | 0f58fa8 | 2012-11-05 01:45:20 +0000 | [diff] [blame] | 801 | remote, = remotes |
jmbaker@chromium.org | a2cbbbb | 2012-03-22 20:40:40 +0000 | [diff] [blame] | 802 | elif 'origin' in remotes: |
ilevy@chromium.org | 0f58fa8 | 2012-11-05 01:45:20 +0000 | [diff] [blame] | 803 | remote = 'origin' |
jmbaker@chromium.org | a2cbbbb | 2012-03-22 20:40:40 +0000 | [diff] [blame] | 804 | logging.warning('Could not determine which remote this change is ' |
| 805 | 'associated with, so defaulting to "%s". This may ' |
| 806 | 'not be what you want. You may prevent this message ' |
| 807 | 'by running "git svn info" as documented here: %s', |
| 808 | self._remote, |
| 809 | GIT_INSTRUCTIONS_URL) |
| 810 | else: |
| 811 | logging.warn('Could not determine which remote this change is ' |
| 812 | 'associated with. You may prevent this message by ' |
| 813 | 'running "git svn info" as documented here: %s', |
| 814 | GIT_INSTRUCTIONS_URL) |
ilevy@chromium.org | 0f58fa8 | 2012-11-05 01:45:20 +0000 | [diff] [blame] | 815 | branch = 'HEAD' |
| 816 | if branch.startswith('refs/remotes'): |
| 817 | self._remote = (remote, branch) |
mmoss@chromium.org | e758545 | 2014-08-24 01:41:11 +0000 | [diff] [blame] | 818 | elif branch.startswith('refs/branch-heads/'): |
| 819 | self._remote = (remote, branch.replace('refs/', 'refs/remotes/')) |
ilevy@chromium.org | 0f58fa8 | 2012-11-05 01:45:20 +0000 | [diff] [blame] | 820 | else: |
| 821 | self._remote = (remote, 'refs/remotes/%s/%s' % (remote, branch)) |
jmbaker@chromium.org | a2cbbbb | 2012-03-22 20:40:40 +0000 | [diff] [blame] | 822 | return self._remote |
| 823 | |
ilevy@chromium.org | 0f58fa8 | 2012-11-05 01:45:20 +0000 | [diff] [blame] | 824 | def GitSanityChecks(self, upstream_git_obj): |
| 825 | """Checks git repo status and ensures diff is from local commits.""" |
| 826 | |
sbc@chromium.org | 7970606 | 2015-01-14 21:18:12 +0000 | [diff] [blame] | 827 | if upstream_git_obj is None: |
| 828 | if self.GetBranch() is None: |
| 829 | print >> sys.stderr, ( |
dpranke@chromium.org | ee87f58 | 2015-07-31 18:46:25 +0000 | [diff] [blame] | 830 | 'ERROR: unable to determine current branch (detached HEAD?)') |
sbc@chromium.org | 7970606 | 2015-01-14 21:18:12 +0000 | [diff] [blame] | 831 | else: |
| 832 | print >> sys.stderr, ( |
| 833 | 'ERROR: no upstream branch') |
| 834 | return False |
| 835 | |
ilevy@chromium.org | 0f58fa8 | 2012-11-05 01:45:20 +0000 | [diff] [blame] | 836 | # Verify the commit we're diffing against is in our current branch. |
| 837 | upstream_sha = RunGit(['rev-parse', '--verify', upstream_git_obj]).strip() |
| 838 | common_ancestor = RunGit(['merge-base', upstream_sha, 'HEAD']).strip() |
| 839 | if upstream_sha != common_ancestor: |
| 840 | print >> sys.stderr, ( |
| 841 | 'ERROR: %s is not in the current branch. You may need to rebase ' |
| 842 | 'your tracking branch' % upstream_sha) |
| 843 | return False |
| 844 | |
| 845 | # List the commits inside the diff, and verify they are all local. |
| 846 | commits_in_diff = RunGit( |
| 847 | ['rev-list', '^%s' % upstream_sha, 'HEAD']).splitlines() |
| 848 | code, remote_branch = RunGitWithCode(['config', 'gitcl.remotebranch']) |
| 849 | remote_branch = remote_branch.strip() |
| 850 | if code != 0: |
| 851 | _, remote_branch = self.GetRemoteBranch() |
| 852 | |
| 853 | commits_in_remote = RunGit( |
| 854 | ['rev-list', '^%s' % upstream_sha, remote_branch]).splitlines() |
| 855 | |
| 856 | common_commits = set(commits_in_diff) & set(commits_in_remote) |
| 857 | if common_commits: |
| 858 | print >> sys.stderr, ( |
| 859 | 'ERROR: Your diff contains %d commits already in %s.\n' |
| 860 | 'Run "git log --oneline %s..HEAD" to get a list of commits in ' |
| 861 | 'the diff. If you are using a custom git flow, you can override' |
| 862 | ' the reference used for this check with "git config ' |
| 863 | 'gitcl.remotebranch <git-ref>".' % ( |
| 864 | len(common_commits), remote_branch, upstream_git_obj)) |
| 865 | return False |
| 866 | return True |
| 867 | |
kalmard@homejinni.com | 6b0051e | 2012-04-03 15:45:08 +0000 | [diff] [blame] | 868 | def GetGitBaseUrlFromConfig(self): |
sheyang@chromium.org | a656e70 | 2014-05-15 20:43:05 +0000 | [diff] [blame] | 869 | """Return the configured base URL from branch.<branchname>.baseurl. |
kalmard@homejinni.com | 6b0051e | 2012-04-03 15:45:08 +0000 | [diff] [blame] | 870 | |
| 871 | Returns None if it is not set. |
| 872 | """ |
sheyang@chromium.org | a656e70 | 2014-05-15 20:43:05 +0000 | [diff] [blame] | 873 | return RunGit(['config', 'branch.%s.base-url' % self.GetBranch()], |
| 874 | error_ok=True).strip() |
jmbaker@chromium.org | a2cbbbb | 2012-03-22 20:40:40 +0000 | [diff] [blame] | 875 | |
kjellander@chromium.org | 6abc652 | 2014-12-02 07:34:49 +0000 | [diff] [blame] | 876 | def GetGitSvnRemoteUrl(self): |
| 877 | """Return the configured git-svn remote URL parsed from git svn info. |
| 878 | |
| 879 | Returns None if it is not set. |
| 880 | """ |
| 881 | # URL is dependent on the current directory. |
| 882 | data = RunGit(['svn', 'info'], cwd=settings.GetRoot()) |
| 883 | if data: |
| 884 | keys = dict(line.split(': ', 1) for line in data.splitlines() |
| 885 | if ': ' in line) |
| 886 | return keys.get('URL', None) |
| 887 | return None |
| 888 | |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 889 | def GetRemoteUrl(self): |
| 890 | """Return the configured remote URL, e.g. 'git://example.org/foo.git/'. |
| 891 | |
| 892 | Returns None if there is no remote. |
| 893 | """ |
ilevy@chromium.org | 0f58fa8 | 2012-11-05 01:45:20 +0000 | [diff] [blame] | 894 | remote, _ = self.GetRemoteBranch() |
dyen@chromium.org | 2a13d4f | 2014-06-13 00:06:37 +0000 | [diff] [blame] | 895 | url = RunGit(['config', 'remote.%s.url' % remote], error_ok=True).strip() |
| 896 | |
| 897 | # If URL is pointing to a local directory, it is probably a git cache. |
| 898 | if os.path.isdir(url): |
| 899 | url = RunGit(['config', 'remote.%s.url' % remote], |
| 900 | error_ok=True, |
| 901 | cwd=url).strip() |
| 902 | return url |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 903 | |
| 904 | def GetIssue(self): |
maruel@chromium.org | 5242430 | 2012-08-29 15:14:30 +0000 | [diff] [blame] | 905 | """Returns the issue number as a int or None if not set.""" |
maruel@chromium.org | 1033efd | 2013-07-23 23:25:09 +0000 | [diff] [blame] | 906 | if self.issue is None and not self.lookedup_issue: |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 907 | issue = RunGit(['config', self._IssueSetting()], error_ok=True).strip() |
maruel@chromium.org | 1033efd | 2013-07-23 23:25:09 +0000 | [diff] [blame] | 908 | self.issue = int(issue) or None if issue else None |
| 909 | self.lookedup_issue = True |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 910 | return self.issue |
| 911 | |
| 912 | def GetRietveldServer(self): |
evan@chromium.org | 0af9b70 | 2012-02-11 00:42:16 +0000 | [diff] [blame] | 913 | if not self.rietveld_server: |
| 914 | # If we're on a branch then get the server potentially associated |
| 915 | # with that branch. |
| 916 | if self.GetIssue(): |
szager@chromium.org | d62c61f | 2014-10-20 22:33:21 +0000 | [diff] [blame] | 917 | rietveld_server_config = self._RietveldServer() |
| 918 | if rietveld_server_config: |
| 919 | self.rietveld_server = gclient_utils.UpgradeToHttps(RunGit( |
| 920 | ['config', rietveld_server_config], error_ok=True).strip()) |
evan@chromium.org | 0af9b70 | 2012-02-11 00:42:16 +0000 | [diff] [blame] | 921 | if not self.rietveld_server: |
| 922 | self.rietveld_server = settings.GetDefaultServerUrl() |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 923 | return self.rietveld_server |
| 924 | |
| 925 | def GetIssueURL(self): |
| 926 | """Get the URL for a particular issue.""" |
dbeam@chromium.org | 015fd3d | 2013-06-18 19:02:50 +0000 | [diff] [blame] | 927 | if not self.GetIssue(): |
| 928 | return None |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 929 | return '%s/%s' % (self.GetRietveldServer(), self.GetIssue()) |
| 930 | |
| 931 | def GetDescription(self, pretty=False): |
| 932 | if not self.has_description: |
| 933 | if self.GetIssue(): |
maruel@chromium.org | 5242430 | 2012-08-29 15:14:30 +0000 | [diff] [blame] | 934 | issue = self.GetIssue() |
miket@chromium.org | 183df1a | 2012-01-04 19:44:55 +0000 | [diff] [blame] | 935 | try: |
| 936 | self.description = self.RpcServer().get_description(issue).strip() |
maruel@chromium.org | 85616e0 | 2014-07-28 15:37:55 +0000 | [diff] [blame] | 937 | except urllib2.HTTPError as e: |
miket@chromium.org | 183df1a | 2012-01-04 19:44:55 +0000 | [diff] [blame] | 938 | if e.code == 404: |
| 939 | DieWithError( |
| 940 | ('\nWhile fetching the description for issue %d, received a ' |
| 941 | '404 (not found)\n' |
| 942 | 'error. It is likely that you deleted this ' |
| 943 | 'issue on the server. If this is the\n' |
| 944 | 'case, please run\n\n' |
| 945 | ' git cl issue 0\n\n' |
| 946 | 'to clear the association with the deleted issue. Then run ' |
| 947 | 'this command again.') % issue) |
| 948 | else: |
| 949 | DieWithError( |
yujie.mao@intel.com | daee1d3 | 2013-12-18 11:55:03 +0000 | [diff] [blame] | 950 | '\nFailed to fetch issue description. HTTP error %d' % e.code) |
maruel@chromium.org | 85616e0 | 2014-07-28 15:37:55 +0000 | [diff] [blame] | 951 | except urllib2.URLError as e: |
| 952 | print >> sys.stderr, ( |
| 953 | 'Warning: Failed to retrieve CL description due to network ' |
| 954 | 'failure.') |
| 955 | self.description = '' |
| 956 | |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 957 | self.has_description = True |
| 958 | if pretty: |
| 959 | wrapper = textwrap.TextWrapper() |
| 960 | wrapper.initial_indent = wrapper.subsequent_indent = ' ' |
| 961 | return wrapper.fill(self.description) |
| 962 | return self.description |
| 963 | |
| 964 | def GetPatchset(self): |
maruel@chromium.org | 5242430 | 2012-08-29 15:14:30 +0000 | [diff] [blame] | 965 | """Returns the patchset number as a int or None if not set.""" |
maruel@chromium.org | 1033efd | 2013-07-23 23:25:09 +0000 | [diff] [blame] | 966 | if self.patchset is None and not self.lookedup_patchset: |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 967 | patchset = RunGit(['config', self._PatchsetSetting()], |
| 968 | error_ok=True).strip() |
maruel@chromium.org | 1033efd | 2013-07-23 23:25:09 +0000 | [diff] [blame] | 969 | self.patchset = int(patchset) or None if patchset else None |
| 970 | self.lookedup_patchset = True |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 971 | return self.patchset |
| 972 | |
| 973 | def SetPatchset(self, patchset): |
| 974 | """Set this branch's patchset. If patchset=0, clears the patchset.""" |
| 975 | if patchset: |
| 976 | RunGit(['config', self._PatchsetSetting(), str(patchset)]) |
maruel@chromium.org | 1033efd | 2013-07-23 23:25:09 +0000 | [diff] [blame] | 977 | self.patchset = patchset |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 978 | else: |
| 979 | RunGit(['config', '--unset', self._PatchsetSetting()], |
maruel@chromium.org | 32f9f5e | 2011-09-14 13:41:47 +0000 | [diff] [blame] | 980 | stderr=subprocess2.PIPE, error_ok=True) |
maruel@chromium.org | 1033efd | 2013-07-23 23:25:09 +0000 | [diff] [blame] | 981 | self.patchset = None |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 982 | |
maruel@chromium.org | 1033efd | 2013-07-23 23:25:09 +0000 | [diff] [blame] | 983 | def GetMostRecentPatchset(self): |
| 984 | return self.GetIssueProperties()['patchsets'][-1] |
binji@chromium.org | 0281f52 | 2012-09-14 13:37:59 +0000 | [diff] [blame] | 985 | |
| 986 | def GetPatchSetDiff(self, issue, patchset): |
maruel@chromium.org | 27bb387 | 2011-05-30 20:33:19 +0000 | [diff] [blame] | 987 | return self.RpcServer().get( |
maruel@chromium.org | e77ebbf | 2011-03-29 20:35:38 +0000 | [diff] [blame] | 988 | '/download/issue%s_%s.diff' % (issue, patchset)) |
| 989 | |
maruel@chromium.org | 1033efd | 2013-07-23 23:25:09 +0000 | [diff] [blame] | 990 | def GetIssueProperties(self): |
| 991 | if self._props is None: |
| 992 | issue = self.GetIssue() |
| 993 | if not issue: |
| 994 | self._props = {} |
| 995 | else: |
| 996 | self._props = self.RpcServer().get_issue_properties(issue, True) |
| 997 | return self._props |
| 998 | |
maruel@chromium.org | cf08778 | 2013-07-23 13:08:48 +0000 | [diff] [blame] | 999 | def GetApprovingReviewers(self): |
maruel@chromium.org | 1033efd | 2013-07-23 23:25:09 +0000 | [diff] [blame] | 1000 | return get_approving_reviewers(self.GetIssueProperties()) |
maruel@chromium.org | e52678e | 2013-04-26 18:34:44 +0000 | [diff] [blame] | 1001 | |
apavlov@chromium.org | e4efd51 | 2014-11-05 09:05:29 +0000 | [diff] [blame] | 1002 | def AddComment(self, message): |
| 1003 | return self.RpcServer().add_comment(self.GetIssue(), message) |
| 1004 | |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 1005 | def SetIssue(self, issue): |
| 1006 | """Set this branch's issue. If issue=0, clears the issue.""" |
| 1007 | if issue: |
maruel@chromium.org | 1033efd | 2013-07-23 23:25:09 +0000 | [diff] [blame] | 1008 | self.issue = issue |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 1009 | RunGit(['config', self._IssueSetting(), str(issue)]) |
| 1010 | if self.rietveld_server: |
| 1011 | RunGit(['config', self._RietveldServer(), self.rietveld_server]) |
| 1012 | else: |
teravest@chromium.org | d79d4b8 | 2013-10-23 20:09:08 +0000 | [diff] [blame] | 1013 | current_issue = self.GetIssue() |
| 1014 | if current_issue: |
| 1015 | RunGit(['config', '--unset', self._IssueSetting()]) |
maruel@chromium.org | 1033efd | 2013-07-23 23:25:09 +0000 | [diff] [blame] | 1016 | self.issue = None |
| 1017 | self.SetPatchset(None) |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 1018 | |
asvitkine@chromium.org | 1516995 | 2011-09-27 14:30:53 +0000 | [diff] [blame] | 1019 | def GetChange(self, upstream_branch, author): |
ilevy@chromium.org | 0f58fa8 | 2012-11-05 01:45:20 +0000 | [diff] [blame] | 1020 | if not self.GitSanityChecks(upstream_branch): |
| 1021 | DieWithError('\nGit sanity check failure') |
| 1022 | |
thestig@chromium.org | 8b0553c | 2014-02-11 00:33:37 +0000 | [diff] [blame] | 1023 | root = settings.GetRelativeRoot() |
bratell@opera.com | f267b0e | 2013-05-02 09:11:43 +0000 | [diff] [blame] | 1024 | if not root: |
| 1025 | root = '.' |
bauerb@chromium.org | 512f1ef | 2011-04-20 15:17:57 +0000 | [diff] [blame] | 1026 | absroot = os.path.abspath(root) |
bauerb@chromium.org | 6fb99c6 | 2011-04-18 15:57:28 +0000 | [diff] [blame] | 1027 | |
| 1028 | # We use the sha1 of HEAD as a name of this change. |
thestig@chromium.org | 8b0553c | 2014-02-11 00:33:37 +0000 | [diff] [blame] | 1029 | name = RunGitWithCode(['rev-parse', 'HEAD'])[1].strip() |
bauerb@chromium.org | 512f1ef | 2011-04-20 15:17:57 +0000 | [diff] [blame] | 1030 | # Need to pass a relative path for msysgit. |
maruel@chromium.org | 2b38e9c | 2011-10-19 00:04:35 +0000 | [diff] [blame] | 1031 | try: |
maruel@chromium.org | 80a9ef1 | 2011-12-13 20:44:10 +0000 | [diff] [blame] | 1032 | files = scm.GIT.CaptureStatus([root], '.', upstream_branch) |
maruel@chromium.org | 2b38e9c | 2011-10-19 00:04:35 +0000 | [diff] [blame] | 1033 | except subprocess2.CalledProcessError: |
| 1034 | DieWithError( |
pgervais@chromium.org | d6617f3 | 2013-11-19 00:34:54 +0000 | [diff] [blame] | 1035 | ('\nFailed to diff against upstream branch %s\n\n' |
maruel@chromium.org | 2b38e9c | 2011-10-19 00:04:35 +0000 | [diff] [blame] | 1036 | 'This branch probably doesn\'t exist anymore. To reset the\n' |
| 1037 | 'tracking branch, please run\n' |
| 1038 | ' git branch --set-upstream %s trunk\n' |
| 1039 | 'replacing trunk with origin/master or the relevant branch') % |
| 1040 | (upstream_branch, self.GetBranch())) |
bauerb@chromium.org | 6fb99c6 | 2011-04-18 15:57:28 +0000 | [diff] [blame] | 1041 | |
maruel@chromium.org | 5242430 | 2012-08-29 15:14:30 +0000 | [diff] [blame] | 1042 | issue = self.GetIssue() |
| 1043 | patchset = self.GetPatchset() |
bauerb@chromium.org | 6fb99c6 | 2011-04-18 15:57:28 +0000 | [diff] [blame] | 1044 | if issue: |
| 1045 | description = self.GetDescription() |
| 1046 | else: |
| 1047 | # If the change was never uploaded, use the log messages of all commits |
| 1048 | # up to the branch point, as git cl upload will prefill the description |
| 1049 | # with these log messages. |
thestig@chromium.org | 8b0553c | 2014-02-11 00:33:37 +0000 | [diff] [blame] | 1050 | args = ['log', '--pretty=format:%s%n%n%b', '%s...' % (upstream_branch)] |
| 1051 | description = RunGitWithCode(args)[1].strip() |
maruel@chromium.org | 03b3bdc | 2011-06-14 13:04:12 +0000 | [diff] [blame] | 1052 | |
| 1053 | if not author: |
maruel@chromium.org | 13f623c | 2011-07-22 16:02:23 +0000 | [diff] [blame] | 1054 | author = RunGit(['config', 'user.email']).strip() or None |
asvitkine@chromium.org | 1516995 | 2011-09-27 14:30:53 +0000 | [diff] [blame] | 1055 | return presubmit_support.GitChange( |
bauerb@chromium.org | 6fb99c6 | 2011-04-18 15:57:28 +0000 | [diff] [blame] | 1056 | name, |
| 1057 | description, |
| 1058 | absroot, |
| 1059 | files, |
| 1060 | issue, |
| 1061 | patchset, |
agable@chromium.org | ea84ef1 | 2014-04-30 19:55:12 +0000 | [diff] [blame] | 1062 | author, |
| 1063 | upstream=upstream_branch) |
bauerb@chromium.org | 6fb99c6 | 2011-04-18 15:57:28 +0000 | [diff] [blame] | 1064 | |
jsbell@chromium.org | b99fbd9 | 2014-09-11 17:29:28 +0000 | [diff] [blame] | 1065 | def GetStatus(self): |
| 1066 | """Apply a rough heuristic to give a simple summary of an issue's review |
| 1067 | or CQ status, assuming adherence to a common workflow. |
| 1068 | |
| 1069 | Returns None if no issue for this branch, or one of the following keywords: |
| 1070 | * 'error' - error from review tool (including deleted issues) |
| 1071 | * 'unsent' - not sent for review |
| 1072 | * 'waiting' - waiting for review |
| 1073 | * 'reply' - waiting for owner to reply to review |
| 1074 | * 'lgtm' - LGTM from at least one approved reviewer |
| 1075 | * 'commit' - in the commit queue |
| 1076 | * 'closed' - closed |
| 1077 | """ |
| 1078 | if not self.GetIssue(): |
| 1079 | return None |
| 1080 | |
| 1081 | try: |
| 1082 | props = self.GetIssueProperties() |
| 1083 | except urllib2.HTTPError: |
| 1084 | return 'error' |
| 1085 | |
| 1086 | if props.get('closed'): |
| 1087 | # Issue is closed. |
| 1088 | return 'closed' |
| 1089 | if props.get('commit'): |
| 1090 | # Issue is in the commit queue. |
| 1091 | return 'commit' |
| 1092 | |
| 1093 | try: |
| 1094 | reviewers = self.GetApprovingReviewers() |
| 1095 | except urllib2.HTTPError: |
| 1096 | return 'error' |
| 1097 | |
| 1098 | if reviewers: |
| 1099 | # Was LGTM'ed. |
| 1100 | return 'lgtm' |
| 1101 | |
| 1102 | messages = props.get('messages') or [] |
| 1103 | |
| 1104 | if not messages: |
| 1105 | # No message was sent. |
| 1106 | return 'unsent' |
| 1107 | if messages[-1]['sender'] != props.get('owner_email'): |
| 1108 | # Non-LGTM reply from non-owner |
| 1109 | return 'reply' |
| 1110 | return 'waiting' |
| 1111 | |
ilevy@chromium.org | 051ad0e | 2013-03-04 21:57:34 +0000 | [diff] [blame] | 1112 | def RunHook(self, committing, may_prompt, verbose, change): |
asvitkine@chromium.org | 1516995 | 2011-09-27 14:30:53 +0000 | [diff] [blame] | 1113 | """Calls sys.exit() if the hook fails; returns a HookResults otherwise.""" |
bauerb@chromium.org | 6fb99c6 | 2011-04-18 15:57:28 +0000 | [diff] [blame] | 1114 | |
| 1115 | try: |
maruel@chromium.org | b0a6391 | 2012-01-17 18:10:16 +0000 | [diff] [blame] | 1116 | return presubmit_support.DoPresubmitChecks(change, committing, |
bauerb@chromium.org | 6fb99c6 | 2011-04-18 15:57:28 +0000 | [diff] [blame] | 1117 | verbose=verbose, output_stream=sys.stdout, input_stream=sys.stdin, |
maruel@chromium.org | cc73ad6 | 2011-07-06 17:39:26 +0000 | [diff] [blame] | 1118 | default_presubmit=None, may_prompt=may_prompt, |
maruel@chromium.org | 239f411 | 2011-06-03 20:08:23 +0000 | [diff] [blame] | 1119 | rietveld_obj=self.RpcServer()) |
bauerb@chromium.org | 6fb99c6 | 2011-04-18 15:57:28 +0000 | [diff] [blame] | 1120 | except presubmit_support.PresubmitFailure, e: |
| 1121 | DieWithError( |
| 1122 | ('%s\nMaybe your depot_tools is out of date?\n' |
| 1123 | 'If all fails, contact maruel@') % e) |
| 1124 | |
maruel@chromium.org | b021b32 | 2013-04-08 17:57:29 +0000 | [diff] [blame] | 1125 | def UpdateDescription(self, description): |
| 1126 | self.description = description |
| 1127 | return self.RpcServer().update_description( |
| 1128 | self.GetIssue(), self.description) |
| 1129 | |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 1130 | def CloseIssue(self): |
maruel@chromium.org | 607bb1b | 2011-06-01 23:43:11 +0000 | [diff] [blame] | 1131 | """Updates the description and closes the issue.""" |
maruel@chromium.org | b021b32 | 2013-04-08 17:57:29 +0000 | [diff] [blame] | 1132 | return self.RpcServer().close_issue(self.GetIssue()) |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 1133 | |
maruel@chromium.org | 27bb387 | 2011-05-30 20:33:19 +0000 | [diff] [blame] | 1134 | def SetFlag(self, flag, value): |
| 1135 | """Patchset must match.""" |
| 1136 | if not self.GetPatchset(): |
| 1137 | DieWithError('The patchset needs to match. Send another patchset.') |
| 1138 | try: |
| 1139 | return self.RpcServer().set_flag( |
maruel@chromium.org | 5242430 | 2012-08-29 15:14:30 +0000 | [diff] [blame] | 1140 | self.GetIssue(), self.GetPatchset(), flag, value) |
maruel@chromium.org | 27bb387 | 2011-05-30 20:33:19 +0000 | [diff] [blame] | 1141 | except urllib2.HTTPError, e: |
| 1142 | if e.code == 404: |
| 1143 | DieWithError('The issue %s doesn\'t exist.' % self.GetIssue()) |
| 1144 | if e.code == 403: |
| 1145 | DieWithError( |
| 1146 | ('Access denied to issue %s. Maybe the patchset %s doesn\'t ' |
| 1147 | 'match?') % (self.GetIssue(), self.GetPatchset())) |
| 1148 | raise |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 1149 | |
maruel@chromium.org | cab38e9 | 2011-04-09 00:30:51 +0000 | [diff] [blame] | 1150 | def RpcServer(self): |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 1151 | """Returns an upload.RpcServer() to access this review's rietveld instance. |
| 1152 | """ |
maruel@chromium.org | e77ebbf | 2011-03-29 20:35:38 +0000 | [diff] [blame] | 1153 | if not self._rpc_server: |
maruel@chromium.org | 4bac4b5 | 2012-11-27 20:33:52 +0000 | [diff] [blame] | 1154 | self._rpc_server = rietveld.CachingRietveld( |
vadimsh@chromium.org | cf6a5d2 | 2015-04-09 22:02:00 +0000 | [diff] [blame] | 1155 | self.GetRietveldServer(), |
| 1156 | self._auth_config or auth.make_auth_config()) |
maruel@chromium.org | e77ebbf | 2011-03-29 20:35:38 +0000 | [diff] [blame] | 1157 | return self._rpc_server |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 1158 | |
| 1159 | def _IssueSetting(self): |
| 1160 | """Return the git setting that stores this change's issue.""" |
| 1161 | return 'branch.%s.rietveldissue' % self.GetBranch() |
| 1162 | |
| 1163 | def _PatchsetSetting(self): |
| 1164 | """Return the git setting that stores this change's most recent patchset.""" |
| 1165 | return 'branch.%s.rietveldpatchset' % self.GetBranch() |
| 1166 | |
| 1167 | def _RietveldServer(self): |
| 1168 | """Returns the git setting that stores this change's rietveld server.""" |
szager@chromium.org | d62c61f | 2014-10-20 22:33:21 +0000 | [diff] [blame] | 1169 | branch = self.GetBranch() |
| 1170 | if branch: |
| 1171 | return 'branch.%s.rietveldserver' % branch |
| 1172 | return None |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 1173 | |
| 1174 | |
| 1175 | def GetCodereviewSettingsInteractively(): |
| 1176 | """Prompt the user for settings.""" |
ukai@chromium.org | e807781 | 2012-02-03 03:41:46 +0000 | [diff] [blame] | 1177 | # TODO(ukai): ask code review system is rietveld or gerrit? |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 1178 | server = settings.GetDefaultServerUrl(error_ok=True) |
| 1179 | prompt = 'Rietveld server (host[:port])' |
| 1180 | prompt += ' [%s]' % (server or DEFAULT_SERVER) |
maruel@chromium.org | 9054173 | 2011-04-01 17:54:18 +0000 | [diff] [blame] | 1181 | newserver = ask_for_data(prompt + ':') |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 1182 | if not server and not newserver: |
| 1183 | newserver = DEFAULT_SERVER |
maruel@chromium.org | eb5edbc | 2012-01-16 17:03:28 +0000 | [diff] [blame] | 1184 | if newserver: |
| 1185 | newserver = gclient_utils.UpgradeToHttps(newserver) |
| 1186 | if newserver != server: |
| 1187 | RunGit(['config', 'rietveld.server', newserver]) |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 1188 | |
maruel@chromium.org | eb5edbc | 2012-01-16 17:03:28 +0000 | [diff] [blame] | 1189 | def SetProperty(initial, caption, name, is_url): |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 1190 | prompt = caption |
| 1191 | if initial: |
| 1192 | prompt += ' ("x" to clear) [%s]' % initial |
maruel@chromium.org | 9054173 | 2011-04-01 17:54:18 +0000 | [diff] [blame] | 1193 | new_val = ask_for_data(prompt + ':') |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 1194 | if new_val == 'x': |
| 1195 | RunGit(['config', '--unset-all', 'rietveld.' + name], error_ok=True) |
maruel@chromium.org | eb5edbc | 2012-01-16 17:03:28 +0000 | [diff] [blame] | 1196 | elif new_val: |
| 1197 | if is_url: |
| 1198 | new_val = gclient_utils.UpgradeToHttps(new_val) |
| 1199 | if new_val != initial: |
| 1200 | RunGit(['config', 'rietveld.' + name, new_val]) |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 1201 | |
maruel@chromium.org | eb5edbc | 2012-01-16 17:03:28 +0000 | [diff] [blame] | 1202 | SetProperty(settings.GetDefaultCCList(), 'CC list', 'cc', False) |
tyoshino@chromium.org | c1737d0 | 2013-05-29 14:17:28 +0000 | [diff] [blame] | 1203 | SetProperty(settings.GetDefaultPrivateFlag(), |
| 1204 | 'Private flag (rietveld only)', 'private', False) |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 1205 | SetProperty(settings.GetTreeStatusUrl(error_ok=True), 'Tree status URL', |
maruel@chromium.org | eb5edbc | 2012-01-16 17:03:28 +0000 | [diff] [blame] | 1206 | 'tree-status-url', False) |
| 1207 | SetProperty(settings.GetViewVCUrl(), 'ViewVC URL', 'viewvc-url', True) |
rmistry@google.com | 9075258 | 2014-01-14 21:04:50 +0000 | [diff] [blame] | 1208 | SetProperty(settings.GetBugPrefix(), 'Bug Prefix', 'bug-prefix', False) |
rmistry@google.com | 5626a92 | 2015-02-26 14:03:30 +0000 | [diff] [blame] | 1209 | SetProperty(settings.GetRunPostUploadHook(), 'Run Post Upload Hook', |
| 1210 | 'run-post-upload-hook', False) |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 1211 | |
| 1212 | # TODO: configure a default branch to diff against, rather than this |
| 1213 | # svn-based hackery. |
| 1214 | |
| 1215 | |
dpranke@chromium.org | 20254fc | 2011-03-22 18:28:59 +0000 | [diff] [blame] | 1216 | class ChangeDescription(object): |
| 1217 | """Contains a parsed form of the change description.""" |
maruel@chromium.org | c6f60e8 | 2013-04-19 17:01:57 +0000 | [diff] [blame] | 1218 | R_LINE = r'^[ \t]*(TBR|R)[ \t]*=[ \t]*(.*?)[ \t]*$' |
agable@chromium.org | 42c2079 | 2013-09-12 17:34:49 +0000 | [diff] [blame] | 1219 | BUG_LINE = r'^[ \t]*(BUG)[ \t]*=[ \t]*(.*?)[ \t]*$' |
dpranke@chromium.org | 20254fc | 2011-03-22 18:28:59 +0000 | [diff] [blame] | 1220 | |
maruel@chromium.org | 78936cb | 2013-04-11 00:17:52 +0000 | [diff] [blame] | 1221 | def __init__(self, description): |
agable@chromium.org | 42c2079 | 2013-09-12 17:34:49 +0000 | [diff] [blame] | 1222 | self._description_lines = (description or '').strip().splitlines() |
maruel@chromium.org | 78936cb | 2013-04-11 00:17:52 +0000 | [diff] [blame] | 1223 | |
agable@chromium.org | 42c2079 | 2013-09-12 17:34:49 +0000 | [diff] [blame] | 1224 | @property # www.logilab.org/ticket/89786 |
| 1225 | def description(self): # pylint: disable=E0202 |
| 1226 | return '\n'.join(self._description_lines) |
| 1227 | |
| 1228 | def set_description(self, desc): |
| 1229 | if isinstance(desc, basestring): |
| 1230 | lines = desc.splitlines() |
| 1231 | else: |
| 1232 | lines = [line.rstrip() for line in desc] |
| 1233 | while lines and not lines[0]: |
| 1234 | lines.pop(0) |
| 1235 | while lines and not lines[-1]: |
| 1236 | lines.pop(-1) |
| 1237 | self._description_lines = lines |
maruel@chromium.org | 78936cb | 2013-04-11 00:17:52 +0000 | [diff] [blame] | 1238 | |
piman@chromium.org | 336f912 | 2014-09-04 02:16:55 +0000 | [diff] [blame] | 1239 | def update_reviewers(self, reviewers, add_owners_tbr=False, change=None): |
agable@chromium.org | 42c2079 | 2013-09-12 17:34:49 +0000 | [diff] [blame] | 1240 | """Rewrites the R=/TBR= line(s) as a single line each.""" |
maruel@chromium.org | 78936cb | 2013-04-11 00:17:52 +0000 | [diff] [blame] | 1241 | assert isinstance(reviewers, list), reviewers |
piman@chromium.org | 336f912 | 2014-09-04 02:16:55 +0000 | [diff] [blame] | 1242 | if not reviewers and not add_owners_tbr: |
maruel@chromium.org | 78936cb | 2013-04-11 00:17:52 +0000 | [diff] [blame] | 1243 | return |
agable@chromium.org | 42c2079 | 2013-09-12 17:34:49 +0000 | [diff] [blame] | 1244 | reviewers = reviewers[:] |
maruel@chromium.org | 78936cb | 2013-04-11 00:17:52 +0000 | [diff] [blame] | 1245 | |
agable@chromium.org | 42c2079 | 2013-09-12 17:34:49 +0000 | [diff] [blame] | 1246 | # Get the set of R= and TBR= lines and remove them from the desciption. |
| 1247 | regexp = re.compile(self.R_LINE) |
| 1248 | matches = [regexp.match(line) for line in self._description_lines] |
| 1249 | new_desc = [l for i, l in enumerate(self._description_lines) |
| 1250 | if not matches[i]] |
| 1251 | self.set_description(new_desc) |
maruel@chromium.org | 78936cb | 2013-04-11 00:17:52 +0000 | [diff] [blame] | 1252 | |
agable@chromium.org | 42c2079 | 2013-09-12 17:34:49 +0000 | [diff] [blame] | 1253 | # Construct new unified R= and TBR= lines. |
| 1254 | r_names = [] |
| 1255 | tbr_names = [] |
| 1256 | for match in matches: |
| 1257 | if not match: |
| 1258 | continue |
| 1259 | people = cleanup_list([match.group(2).strip()]) |
| 1260 | if match.group(1) == 'TBR': |
| 1261 | tbr_names.extend(people) |
| 1262 | else: |
| 1263 | r_names.extend(people) |
| 1264 | for name in r_names: |
| 1265 | if name not in reviewers: |
| 1266 | reviewers.append(name) |
piman@chromium.org | 336f912 | 2014-09-04 02:16:55 +0000 | [diff] [blame] | 1267 | if add_owners_tbr: |
| 1268 | owners_db = owners.Database(change.RepositoryRoot(), |
| 1269 | fopen=file, os_path=os.path, glob=glob.glob) |
| 1270 | all_reviewers = set(tbr_names + reviewers) |
| 1271 | missing_files = owners_db.files_not_covered_by(change.LocalPaths(), |
| 1272 | all_reviewers) |
| 1273 | tbr_names.extend(owners_db.reviewers_for(missing_files, |
| 1274 | change.author_email)) |
agable@chromium.org | 42c2079 | 2013-09-12 17:34:49 +0000 | [diff] [blame] | 1275 | new_r_line = 'R=' + ', '.join(reviewers) if reviewers else None |
| 1276 | new_tbr_line = 'TBR=' + ', '.join(tbr_names) if tbr_names else None |
| 1277 | |
| 1278 | # Put the new lines in the description where the old first R= line was. |
| 1279 | line_loc = next((i for i, match in enumerate(matches) if match), -1) |
| 1280 | if 0 <= line_loc < len(self._description_lines): |
| 1281 | if new_tbr_line: |
| 1282 | self._description_lines.insert(line_loc, new_tbr_line) |
| 1283 | if new_r_line: |
| 1284 | self._description_lines.insert(line_loc, new_r_line) |
maruel@chromium.org | 78936cb | 2013-04-11 00:17:52 +0000 | [diff] [blame] | 1285 | else: |
agable@chromium.org | 42c2079 | 2013-09-12 17:34:49 +0000 | [diff] [blame] | 1286 | if new_r_line: |
| 1287 | self.append_footer(new_r_line) |
| 1288 | if new_tbr_line: |
| 1289 | self.append_footer(new_tbr_line) |
maruel@chromium.org | 78936cb | 2013-04-11 00:17:52 +0000 | [diff] [blame] | 1290 | |
| 1291 | def prompt(self): |
| 1292 | """Asks the user to update the description.""" |
agable@chromium.org | 42c2079 | 2013-09-12 17:34:49 +0000 | [diff] [blame] | 1293 | self.set_description([ |
| 1294 | '# Enter a description of the change.', |
| 1295 | '# This will be displayed on the codereview site.', |
| 1296 | '# The first line will also be used as the subject of the review.', |
alancutter@chromium.org | bd1073e | 2013-06-01 00:34:38 +0000 | [diff] [blame] | 1297 | '#--------------------This line is 72 characters long' |
agable@chromium.org | 42c2079 | 2013-09-12 17:34:49 +0000 | [diff] [blame] | 1298 | '--------------------', |
| 1299 | ] + self._description_lines) |
maruel@chromium.org | 78936cb | 2013-04-11 00:17:52 +0000 | [diff] [blame] | 1300 | |
agable@chromium.org | 42c2079 | 2013-09-12 17:34:49 +0000 | [diff] [blame] | 1301 | regexp = re.compile(self.BUG_LINE) |
| 1302 | if not any((regexp.match(line) for line in self._description_lines)): |
rmistry@google.com | 9075258 | 2014-01-14 21:04:50 +0000 | [diff] [blame] | 1303 | self.append_footer('BUG=%s' % settings.GetBugPrefix()) |
agable@chromium.org | 42c2079 | 2013-09-12 17:34:49 +0000 | [diff] [blame] | 1304 | content = gclient_utils.RunEditor(self.description, True, |
jbroman@chromium.org | 615a262 | 2013-05-03 13:20:14 +0000 | [diff] [blame] | 1305 | git_editor=settings.GetGitEditor()) |
maruel@chromium.org | 0e0436a | 2011-10-25 13:32:41 +0000 | [diff] [blame] | 1306 | if not content: |
| 1307 | DieWithError('Running editor failed') |
agable@chromium.org | 42c2079 | 2013-09-12 17:34:49 +0000 | [diff] [blame] | 1308 | lines = content.splitlines() |
maruel@chromium.org | 78936cb | 2013-04-11 00:17:52 +0000 | [diff] [blame] | 1309 | |
| 1310 | # Strip off comments. |
agable@chromium.org | 42c2079 | 2013-09-12 17:34:49 +0000 | [diff] [blame] | 1311 | clean_lines = [line.rstrip() for line in lines if not line.startswith('#')] |
| 1312 | if not clean_lines: |
maruel@chromium.org | 0e0436a | 2011-10-25 13:32:41 +0000 | [diff] [blame] | 1313 | DieWithError('No CL description, aborting') |
agable@chromium.org | 42c2079 | 2013-09-12 17:34:49 +0000 | [diff] [blame] | 1314 | self.set_description(clean_lines) |
dpranke@chromium.org | 20254fc | 2011-03-22 18:28:59 +0000 | [diff] [blame] | 1315 | |
maruel@chromium.org | 78936cb | 2013-04-11 00:17:52 +0000 | [diff] [blame] | 1316 | def append_footer(self, line): |
agable@chromium.org | 42c2079 | 2013-09-12 17:34:49 +0000 | [diff] [blame] | 1317 | if self._description_lines: |
| 1318 | # Add an empty line if either the last line or the new line isn't a tag. |
| 1319 | last_line = self._description_lines[-1] |
| 1320 | if (not presubmit_support.Change.TAG_LINE_RE.match(last_line) or |
| 1321 | not presubmit_support.Change.TAG_LINE_RE.match(line)): |
| 1322 | self._description_lines.append('') |
| 1323 | self._description_lines.append(line) |
dpranke@chromium.org | 20254fc | 2011-03-22 18:28:59 +0000 | [diff] [blame] | 1324 | |
maruel@chromium.org | 78936cb | 2013-04-11 00:17:52 +0000 | [diff] [blame] | 1325 | def get_reviewers(self): |
| 1326 | """Retrieves the list of reviewers.""" |
agable@chromium.org | 42c2079 | 2013-09-12 17:34:49 +0000 | [diff] [blame] | 1327 | matches = [re.match(self.R_LINE, line) for line in self._description_lines] |
| 1328 | reviewers = [match.group(2).strip() for match in matches if match] |
maruel@chromium.org | 78936cb | 2013-04-11 00:17:52 +0000 | [diff] [blame] | 1329 | return cleanup_list(reviewers) |
dpranke@chromium.org | 20254fc | 2011-03-22 18:28:59 +0000 | [diff] [blame] | 1330 | |
| 1331 | |
maruel@chromium.org | e52678e | 2013-04-26 18:34:44 +0000 | [diff] [blame] | 1332 | def get_approving_reviewers(props): |
| 1333 | """Retrieves the reviewers that approved a CL from the issue properties with |
| 1334 | messages. |
| 1335 | |
| 1336 | Note that the list may contain reviewers that are not committer, thus are not |
| 1337 | considered by the CQ. |
| 1338 | """ |
| 1339 | return sorted( |
| 1340 | set( |
| 1341 | message['sender'] |
| 1342 | for message in props['messages'] |
| 1343 | if message['approval'] and message['sender'] in props['reviewers'] |
| 1344 | ) |
| 1345 | ) |
| 1346 | |
| 1347 | |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 1348 | def FindCodereviewSettingsFile(filename='codereview.settings'): |
| 1349 | """Finds the given file starting in the cwd and going up. |
| 1350 | |
| 1351 | Only looks up to the top of the repository unless an |
| 1352 | 'inherit-review-settings-ok' file exists in the root of the repository. |
| 1353 | """ |
| 1354 | inherit_ok_file = 'inherit-review-settings-ok' |
| 1355 | cwd = os.getcwd() |
thestig@chromium.org | 8b0553c | 2014-02-11 00:33:37 +0000 | [diff] [blame] | 1356 | root = settings.GetRoot() |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 1357 | if os.path.isfile(os.path.join(root, inherit_ok_file)): |
| 1358 | root = '/' |
| 1359 | while True: |
| 1360 | if filename in os.listdir(cwd): |
| 1361 | if os.path.isfile(os.path.join(cwd, filename)): |
| 1362 | return open(os.path.join(cwd, filename)) |
| 1363 | if cwd == root: |
| 1364 | break |
| 1365 | cwd = os.path.dirname(cwd) |
| 1366 | |
| 1367 | |
| 1368 | def LoadCodereviewSettingsFromFile(fileobj): |
| 1369 | """Parse a codereview.settings file and updates hooks.""" |
maruel@chromium.org | 99ac1c5 | 2012-01-16 14:52:12 +0000 | [diff] [blame] | 1370 | keyvals = gclient_utils.ParseCodereviewSettingsContent(fileobj.read()) |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 1371 | |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 1372 | def SetProperty(name, setting, unset_error_ok=False): |
| 1373 | fullname = 'rietveld.' + name |
| 1374 | if setting in keyvals: |
| 1375 | RunGit(['config', fullname, keyvals[setting]]) |
| 1376 | else: |
| 1377 | RunGit(['config', '--unset-all', fullname], error_ok=unset_error_ok) |
| 1378 | |
| 1379 | SetProperty('server', 'CODE_REVIEW_SERVER') |
| 1380 | # Only server setting is required. Other settings can be absent. |
| 1381 | # In that case, we ignore errors raised during option deletion attempt. |
| 1382 | SetProperty('cc', 'CC_LIST', unset_error_ok=True) |
tyoshino@chromium.org | c1737d0 | 2013-05-29 14:17:28 +0000 | [diff] [blame] | 1383 | SetProperty('private', 'PRIVATE', unset_error_ok=True) |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 1384 | SetProperty('tree-status-url', 'STATUS', unset_error_ok=True) |
| 1385 | SetProperty('viewvc-url', 'VIEW_VC', unset_error_ok=True) |
rmistry@google.com | 9075258 | 2014-01-14 21:04:50 +0000 | [diff] [blame] | 1386 | SetProperty('bug-prefix', 'BUG_PREFIX', unset_error_ok=True) |
thestig@chromium.org | 44202a2 | 2014-03-11 19:22:18 +0000 | [diff] [blame] | 1387 | SetProperty('cpplint-regex', 'LINT_REGEX', unset_error_ok=True) |
kjellander@chromium.org | 6abc652 | 2014-12-02 07:34:49 +0000 | [diff] [blame] | 1388 | SetProperty('force-https-commit-url', 'FORCE_HTTPS_COMMIT_URL', |
| 1389 | unset_error_ok=True) |
thestig@chromium.org | 44202a2 | 2014-03-11 19:22:18 +0000 | [diff] [blame] | 1390 | SetProperty('cpplint-ignore-regex', 'LINT_IGNORE_REGEX', unset_error_ok=True) |
sheyang@chromium.org | 152cf83 | 2014-06-11 21:37:49 +0000 | [diff] [blame] | 1391 | SetProperty('project', 'PROJECT', unset_error_ok=True) |
vadimsh@chromium.org | 566a02a | 2014-08-22 01:34:13 +0000 | [diff] [blame] | 1392 | SetProperty('pending-ref-prefix', 'PENDING_REF_PREFIX', unset_error_ok=True) |
rmistry@google.com | 5626a92 | 2015-02-26 14:03:30 +0000 | [diff] [blame] | 1393 | SetProperty('run-post-upload-hook', 'RUN_POST_UPLOAD_HOOK', |
| 1394 | unset_error_ok=True) |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 1395 | |
ukai@chromium.org | 7044efc | 2013-11-28 01:51:21 +0000 | [diff] [blame] | 1396 | if 'GERRIT_HOST' in keyvals: |
ukai@chromium.org | e807781 | 2012-02-03 03:41:46 +0000 | [diff] [blame] | 1397 | RunGit(['config', 'gerrit.host', keyvals['GERRIT_HOST']]) |
ukai@chromium.org | e807781 | 2012-02-03 03:41:46 +0000 | [diff] [blame] | 1398 | |
bauerb@chromium.org | 54b400c | 2016-01-14 10:08:25 +0000 | [diff] [blame] | 1399 | if 'GERRIT_SQUASH_UPLOADS' in keyvals: |
| 1400 | RunGit(['config', 'gerrit.squash-uploads', |
| 1401 | keyvals['GERRIT_SQUASH_UPLOADS']]) |
| 1402 | |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 1403 | if 'PUSH_URL_CONFIG' in keyvals and 'ORIGIN_URL_CONFIG' in keyvals: |
| 1404 | #should be of the form |
| 1405 | #PUSH_URL_CONFIG: url.ssh://gitrw.chromium.org.pushinsteadof |
| 1406 | #ORIGIN_URL_CONFIG: http://src.chromium.org/git |
| 1407 | RunGit(['config', keyvals['PUSH_URL_CONFIG'], |
| 1408 | keyvals['ORIGIN_URL_CONFIG']]) |
| 1409 | |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 1410 | |
joshua.lock@intel.com | 426f69b | 2012-08-02 23:41:49 +0000 | [diff] [blame] | 1411 | def urlretrieve(source, destination): |
| 1412 | """urllib is broken for SSL connections via a proxy therefore we |
| 1413 | can't use urllib.urlretrieve().""" |
| 1414 | with open(destination, 'w') as f: |
| 1415 | f.write(urllib2.urlopen(source).read()) |
| 1416 | |
| 1417 | |
ukai@chromium.org | 712d610 | 2013-11-27 00:52:58 +0000 | [diff] [blame] | 1418 | def hasSheBang(fname): |
| 1419 | """Checks fname is a #! script.""" |
| 1420 | with open(fname) as f: |
| 1421 | return f.read(2).startswith('#!') |
| 1422 | |
| 1423 | |
ukai@chromium.org | 78c4b98 | 2012-02-14 02:20:26 +0000 | [diff] [blame] | 1424 | def DownloadHooks(force): |
| 1425 | """downloads hooks |
| 1426 | |
| 1427 | Args: |
| 1428 | force: True to update hooks. False to install hooks if not present. |
| 1429 | """ |
| 1430 | if not settings.GetIsGerrit(): |
| 1431 | return |
ukai@chromium.org | 712d610 | 2013-11-27 00:52:58 +0000 | [diff] [blame] | 1432 | src = 'https://gerrit-review.googlesource.com/tools/hooks/commit-msg' |
ukai@chromium.org | 78c4b98 | 2012-02-14 02:20:26 +0000 | [diff] [blame] | 1433 | dst = os.path.join(settings.GetRoot(), '.git', 'hooks', 'commit-msg') |
| 1434 | if not os.access(dst, os.X_OK): |
| 1435 | if os.path.exists(dst): |
| 1436 | if not force: |
| 1437 | return |
ukai@chromium.org | 78c4b98 | 2012-02-14 02:20:26 +0000 | [diff] [blame] | 1438 | try: |
joshua.lock@intel.com | 426f69b | 2012-08-02 23:41:49 +0000 | [diff] [blame] | 1439 | urlretrieve(src, dst) |
ukai@chromium.org | 712d610 | 2013-11-27 00:52:58 +0000 | [diff] [blame] | 1440 | if not hasSheBang(dst): |
| 1441 | DieWithError('Not a script: %s\n' |
| 1442 | 'You need to download from\n%s\n' |
| 1443 | 'into .git/hooks/commit-msg and ' |
| 1444 | 'chmod +x .git/hooks/commit-msg' % (dst, src)) |
ukai@chromium.org | 78c4b98 | 2012-02-14 02:20:26 +0000 | [diff] [blame] | 1445 | os.chmod(dst, stat.S_IRUSR | stat.S_IWUSR | stat.S_IXUSR) |
| 1446 | except Exception: |
| 1447 | if os.path.exists(dst): |
| 1448 | os.remove(dst) |
ukai@chromium.org | 712d610 | 2013-11-27 00:52:58 +0000 | [diff] [blame] | 1449 | DieWithError('\nFailed to download hooks.\n' |
| 1450 | 'You need to download from\n%s\n' |
| 1451 | 'into .git/hooks/commit-msg and ' |
| 1452 | 'chmod +x .git/hooks/commit-msg' % src) |
ukai@chromium.org | 78c4b98 | 2012-02-14 02:20:26 +0000 | [diff] [blame] | 1453 | |
| 1454 | |
maruel@chromium.org | 0633fb4 | 2013-08-16 20:06:14 +0000 | [diff] [blame] | 1455 | @subcommand.usage('[repo root containing codereview.settings]') |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 1456 | def CMDconfig(parser, args): |
iannucci@chromium.org | d9c1b20 | 2013-07-24 23:52:11 +0000 | [diff] [blame] | 1457 | """Edits configuration for this tree.""" |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 1458 | |
pgervais@chromium.org | 87884cc | 2014-01-03 22:23:41 +0000 | [diff] [blame] | 1459 | parser.add_option('--activate-update', action='store_true', |
| 1460 | help='activate auto-updating [rietveld] section in ' |
| 1461 | '.git/config') |
| 1462 | parser.add_option('--deactivate-update', action='store_true', |
| 1463 | help='deactivate auto-updating [rietveld] section in ' |
| 1464 | '.git/config') |
| 1465 | options, args = parser.parse_args(args) |
| 1466 | |
| 1467 | if options.deactivate_update: |
| 1468 | RunGit(['config', 'rietveld.autoupdate', 'false']) |
| 1469 | return |
| 1470 | |
| 1471 | if options.activate_update: |
| 1472 | RunGit(['config', '--unset', 'rietveld.autoupdate']) |
| 1473 | return |
| 1474 | |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 1475 | if len(args) == 0: |
| 1476 | GetCodereviewSettingsInteractively() |
ukai@chromium.org | 78c4b98 | 2012-02-14 02:20:26 +0000 | [diff] [blame] | 1477 | DownloadHooks(True) |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 1478 | return 0 |
| 1479 | |
| 1480 | url = args[0] |
| 1481 | if not url.endswith('codereview.settings'): |
| 1482 | url = os.path.join(url, 'codereview.settings') |
| 1483 | |
| 1484 | # Load code review settings and download hooks (if available). |
| 1485 | LoadCodereviewSettingsFromFile(urllib2.urlopen(url)) |
ukai@chromium.org | 78c4b98 | 2012-02-14 02:20:26 +0000 | [diff] [blame] | 1486 | DownloadHooks(True) |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 1487 | return 0 |
| 1488 | |
| 1489 | |
kalmard@homejinni.com | 6b0051e | 2012-04-03 15:45:08 +0000 | [diff] [blame] | 1490 | def CMDbaseurl(parser, args): |
iannucci@chromium.org | d9c1b20 | 2013-07-24 23:52:11 +0000 | [diff] [blame] | 1491 | """Gets or sets base-url for this branch.""" |
kalmard@homejinni.com | 6b0051e | 2012-04-03 15:45:08 +0000 | [diff] [blame] | 1492 | branchref = RunGit(['symbolic-ref', 'HEAD']).strip() |
| 1493 | branch = ShortBranchName(branchref) |
| 1494 | _, args = parser.parse_args(args) |
| 1495 | if not args: |
| 1496 | print("Current base-url:") |
| 1497 | return RunGit(['config', 'branch.%s.base-url' % branch], |
| 1498 | error_ok=False).strip() |
| 1499 | else: |
| 1500 | print("Setting base-url to %s" % args[0]) |
| 1501 | return RunGit(['config', 'branch.%s.base-url' % branch, args[0]], |
| 1502 | error_ok=False).strip() |
| 1503 | |
| 1504 | |
jsbell@chromium.org | b99fbd9 | 2014-09-11 17:29:28 +0000 | [diff] [blame] | 1505 | def color_for_status(status): |
| 1506 | """Maps a Changelist status to color, for CMDstatus and other tools.""" |
| 1507 | return { |
| 1508 | 'unsent': Fore.RED, |
| 1509 | 'waiting': Fore.BLUE, |
| 1510 | 'reply': Fore.YELLOW, |
| 1511 | 'lgtm': Fore.GREEN, |
| 1512 | 'commit': Fore.MAGENTA, |
| 1513 | 'closed': Fore.CYAN, |
| 1514 | 'error': Fore.WHITE, |
| 1515 | }.get(status, Fore.WHITE) |
| 1516 | |
nodir@chromium.org | a6de1f4 | 2015-06-10 04:23:17 +0000 | [diff] [blame] | 1517 | def fetch_cl_status(branch, auth_config=None): |
| 1518 | """Fetches information for an issue and returns (branch, issue, status).""" |
| 1519 | cl = Changelist(branchref=branch, auth_config=auth_config) |
| 1520 | url = cl.GetIssueURL() |
| 1521 | status = cl.GetStatus() |
calamity@chromium.org | ffde55c | 2015-03-12 00:44:17 +0000 | [diff] [blame] | 1522 | |
nodir@chromium.org | a6de1f4 | 2015-06-10 04:23:17 +0000 | [diff] [blame] | 1523 | if url and (not status or status == 'error'): |
calamity@chromium.org | ffde55c | 2015-03-12 00:44:17 +0000 | [diff] [blame] | 1524 | # The issue probably doesn't exist anymore. |
nodir@chromium.org | a6de1f4 | 2015-06-10 04:23:17 +0000 | [diff] [blame] | 1525 | url += ' (broken)' |
calamity@chromium.org | ffde55c | 2015-03-12 00:44:17 +0000 | [diff] [blame] | 1526 | |
nodir@chromium.org | a6de1f4 | 2015-06-10 04:23:17 +0000 | [diff] [blame] | 1527 | return (branch, url, status) |
calamity@chromium.org | ffde55c | 2015-03-12 00:44:17 +0000 | [diff] [blame] | 1528 | |
vadimsh@chromium.org | cf6a5d2 | 2015-04-09 22:02:00 +0000 | [diff] [blame] | 1529 | def get_cl_statuses( |
| 1530 | branches, fine_grained, max_processes=None, auth_config=None): |
calamity@chromium.org | ffde55c | 2015-03-12 00:44:17 +0000 | [diff] [blame] | 1531 | """Returns a blocking iterable of (branch, issue, color) for given branches. |
| 1532 | |
| 1533 | If fine_grained is true, this will fetch CL statuses from the server. |
| 1534 | Otherwise, simply indicate if there's a matching url for the given branches. |
| 1535 | |
| 1536 | If max_processes is specified, it is used as the maximum number of processes |
| 1537 | to spawn to fetch CL status from the server. Otherwise 1 process per branch is |
| 1538 | spawned. |
| 1539 | """ |
| 1540 | # Silence upload.py otherwise it becomes unwieldly. |
| 1541 | upload.verbosity = 0 |
| 1542 | |
| 1543 | if fine_grained: |
| 1544 | # Process one branch synchronously to work through authentication, then |
| 1545 | # spawn processes to process all the other branches in parallel. |
| 1546 | if branches: |
vadimsh@chromium.org | cf6a5d2 | 2015-04-09 22:02:00 +0000 | [diff] [blame] | 1547 | fetch = lambda branch: fetch_cl_status(branch, auth_config=auth_config) |
| 1548 | yield fetch(branches[0]) |
calamity@chromium.org | ffde55c | 2015-03-12 00:44:17 +0000 | [diff] [blame] | 1549 | |
| 1550 | branches_to_fetch = branches[1:] |
| 1551 | pool = ThreadPool( |
| 1552 | min(max_processes, len(branches_to_fetch)) |
| 1553 | if max_processes is not None |
| 1554 | else len(branches_to_fetch)) |
vadimsh@chromium.org | cf6a5d2 | 2015-04-09 22:02:00 +0000 | [diff] [blame] | 1555 | for x in pool.imap_unordered(fetch, branches_to_fetch): |
calamity@chromium.org | ffde55c | 2015-03-12 00:44:17 +0000 | [diff] [blame] | 1556 | yield x |
| 1557 | else: |
| 1558 | # Do not use GetApprovingReviewers(), since it requires an HTTP request. |
| 1559 | for b in branches: |
nodir@chromium.org | a6de1f4 | 2015-06-10 04:23:17 +0000 | [diff] [blame] | 1560 | cl = Changelist(branchref=b, auth_config=auth_config) |
| 1561 | url = cl.GetIssueURL() |
| 1562 | yield (b, url, 'waiting' if url else 'error') |
jsbell@chromium.org | b99fbd9 | 2014-09-11 17:29:28 +0000 | [diff] [blame] | 1563 | |
rmistry@google.com | 2dd9986 | 2015-06-22 12:22:18 +0000 | [diff] [blame] | 1564 | |
| 1565 | def upload_branch_deps(cl, args): |
| 1566 | """Uploads CLs of local branches that are dependents of the current branch. |
| 1567 | |
| 1568 | If the local branch dependency tree looks like: |
| 1569 | test1 -> test2.1 -> test3.1 |
| 1570 | -> test3.2 |
| 1571 | -> test2.2 -> test3.3 |
| 1572 | |
| 1573 | and you run "git cl upload --dependencies" from test1 then "git cl upload" is |
| 1574 | run on the dependent branches in this order: |
| 1575 | test2.1, test3.1, test3.2, test2.2, test3.3 |
| 1576 | |
| 1577 | Note: This function does not rebase your local dependent branches. Use it when |
| 1578 | you make a change to the parent branch that will not conflict with its |
| 1579 | dependent branches, and you would like their dependencies updated in |
| 1580 | Rietveld. |
| 1581 | """ |
| 1582 | if git_common.is_dirty_git_tree('upload-branch-deps'): |
| 1583 | return 1 |
| 1584 | |
| 1585 | root_branch = cl.GetBranch() |
| 1586 | if root_branch is None: |
| 1587 | DieWithError('Can\'t find dependent branches from detached HEAD state. ' |
| 1588 | 'Get on a branch!') |
| 1589 | if not cl.GetIssue() or not cl.GetPatchset(): |
| 1590 | DieWithError('Current branch does not have an uploaded CL. We cannot set ' |
| 1591 | 'patchset dependencies without an uploaded CL.') |
| 1592 | |
| 1593 | branches = RunGit(['for-each-ref', |
| 1594 | '--format=%(refname:short) %(upstream:short)', |
| 1595 | 'refs/heads']) |
| 1596 | if not branches: |
| 1597 | print('No local branches found.') |
| 1598 | return 0 |
| 1599 | |
| 1600 | # Create a dictionary of all local branches to the branches that are dependent |
| 1601 | # on it. |
| 1602 | tracked_to_dependents = collections.defaultdict(list) |
| 1603 | for b in branches.splitlines(): |
| 1604 | tokens = b.split() |
| 1605 | if len(tokens) == 2: |
| 1606 | branch_name, tracked = tokens |
| 1607 | tracked_to_dependents[tracked].append(branch_name) |
| 1608 | |
| 1609 | print |
| 1610 | print 'The dependent local branches of %s are:' % root_branch |
| 1611 | dependents = [] |
| 1612 | def traverse_dependents_preorder(branch, padding=''): |
| 1613 | dependents_to_process = tracked_to_dependents.get(branch, []) |
| 1614 | padding += ' ' |
| 1615 | for dependent in dependents_to_process: |
| 1616 | print '%s%s' % (padding, dependent) |
| 1617 | dependents.append(dependent) |
| 1618 | traverse_dependents_preorder(dependent, padding) |
| 1619 | traverse_dependents_preorder(root_branch) |
| 1620 | print |
| 1621 | |
| 1622 | if not dependents: |
| 1623 | print 'There are no dependent local branches for %s' % root_branch |
| 1624 | return 0 |
| 1625 | |
| 1626 | print ('This command will checkout all dependent branches and run ' |
| 1627 | '"git cl upload".') |
| 1628 | ask_for_data('[Press enter to continue or ctrl-C to quit]') |
| 1629 | |
| 1630 | # Add a default patchset title to all upload calls. |
| 1631 | args.extend(['-t', 'Updated patchset dependency']) |
| 1632 | # Record all dependents that failed to upload. |
| 1633 | failures = {} |
| 1634 | # Go through all dependents, checkout the branch and upload. |
| 1635 | try: |
| 1636 | for dependent_branch in dependents: |
| 1637 | print |
| 1638 | print '--------------------------------------' |
| 1639 | print 'Running "git cl upload" from %s:' % dependent_branch |
| 1640 | RunGit(['checkout', '-q', dependent_branch]) |
| 1641 | print |
| 1642 | try: |
| 1643 | if CMDupload(OptionParser(), args) != 0: |
| 1644 | print 'Upload failed for %s!' % dependent_branch |
| 1645 | failures[dependent_branch] = 1 |
| 1646 | except: # pylint: disable=W0702 |
| 1647 | failures[dependent_branch] = 1 |
| 1648 | print |
| 1649 | finally: |
| 1650 | # Swap back to the original root branch. |
| 1651 | RunGit(['checkout', '-q', root_branch]) |
| 1652 | |
| 1653 | print |
| 1654 | print 'Upload complete for dependent branches!' |
| 1655 | for dependent_branch in dependents: |
| 1656 | upload_status = 'failed' if failures.get(dependent_branch) else 'succeeded' |
| 1657 | print ' %s : %s' % (dependent_branch, upload_status) |
| 1658 | print |
| 1659 | |
| 1660 | return 0 |
| 1661 | |
| 1662 | |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 1663 | def CMDstatus(parser, args): |
iannucci@chromium.org | d9c1b20 | 2013-07-24 23:52:11 +0000 | [diff] [blame] | 1664 | """Show status of changelists. |
| 1665 | |
| 1666 | Colors are used to tell the state of the CL unless --fast is used: |
jsbell@chromium.org | aeab41a | 2013-12-10 20:01:22 +0000 | [diff] [blame] | 1667 | - Red not sent for review or broken |
| 1668 | - Blue waiting for review |
| 1669 | - Yellow waiting for you to reply to review |
| 1670 | - Green LGTM'ed |
| 1671 | - Magenta in the commit queue |
| 1672 | - Cyan was committed, branch can be deleted |
iannucci@chromium.org | d9c1b20 | 2013-07-24 23:52:11 +0000 | [diff] [blame] | 1673 | |
| 1674 | Also see 'git cl comments'. |
| 1675 | """ |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 1676 | parser.add_option('--field', |
| 1677 | help='print only specific field (desc|id|patch|url)') |
maruel@chromium.org | 1033efd | 2013-07-23 23:25:09 +0000 | [diff] [blame] | 1678 | parser.add_option('-f', '--fast', action='store_true', |
| 1679 | help='Do not retrieve review status') |
calamity@chromium.org | ffde55c | 2015-03-12 00:44:17 +0000 | [diff] [blame] | 1680 | parser.add_option( |
| 1681 | '-j', '--maxjobs', action='store', type=int, |
| 1682 | help='The maximum number of jobs to use when retrieving review status') |
vadimsh@chromium.org | cf6a5d2 | 2015-04-09 22:02:00 +0000 | [diff] [blame] | 1683 | |
| 1684 | auth.add_auth_options(parser) |
| 1685 | options, args = parser.parse_args(args) |
maruel@chromium.org | 39c0b22 | 2013-08-17 16:57:01 +0000 | [diff] [blame] | 1686 | if args: |
| 1687 | parser.error('Unsupported args: %s' % args) |
vadimsh@chromium.org | cf6a5d2 | 2015-04-09 22:02:00 +0000 | [diff] [blame] | 1688 | auth_config = auth.extract_auth_config_from_options(options) |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 1689 | |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 1690 | if options.field: |
vadimsh@chromium.org | cf6a5d2 | 2015-04-09 22:02:00 +0000 | [diff] [blame] | 1691 | cl = Changelist(auth_config=auth_config) |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 1692 | if options.field.startswith('desc'): |
| 1693 | print cl.GetDescription() |
| 1694 | elif options.field == 'id': |
| 1695 | issueid = cl.GetIssue() |
| 1696 | if issueid: |
| 1697 | print issueid |
| 1698 | elif options.field == 'patch': |
| 1699 | patchset = cl.GetPatchset() |
| 1700 | if patchset: |
| 1701 | print patchset |
| 1702 | elif options.field == 'url': |
| 1703 | url = cl.GetIssueURL() |
| 1704 | if url: |
| 1705 | print url |
maruel@chromium.org | e25c75b | 2013-07-23 18:30:56 +0000 | [diff] [blame] | 1706 | return 0 |
| 1707 | |
| 1708 | branches = RunGit(['for-each-ref', '--format=%(refname)', 'refs/heads']) |
| 1709 | if not branches: |
| 1710 | print('No local branch found.') |
| 1711 | return 0 |
| 1712 | |
vadimsh@chromium.org | cf6a5d2 | 2015-04-09 22:02:00 +0000 | [diff] [blame] | 1713 | changes = ( |
| 1714 | Changelist(branchref=b, auth_config=auth_config) |
| 1715 | for b in branches.splitlines()) |
jrobbins@chromium.org | a4c0305 | 2014-04-25 19:06:36 +0000 | [diff] [blame] | 1716 | branches = [c.GetBranch() for c in changes] |
maruel@chromium.org | e25c75b | 2013-07-23 18:30:56 +0000 | [diff] [blame] | 1717 | alignment = max(5, max(len(b) for b in branches)) |
| 1718 | print 'Branches associated with reviews:' |
calamity@chromium.org | ffde55c | 2015-03-12 00:44:17 +0000 | [diff] [blame] | 1719 | output = get_cl_statuses(branches, |
| 1720 | fine_grained=not options.fast, |
vadimsh@chromium.org | cf6a5d2 | 2015-04-09 22:02:00 +0000 | [diff] [blame] | 1721 | max_processes=options.maxjobs, |
| 1722 | auth_config=auth_config) |
maruel@chromium.org | 1033efd | 2013-07-23 23:25:09 +0000 | [diff] [blame] | 1723 | |
calamity@chromium.org | ffde55c | 2015-03-12 00:44:17 +0000 | [diff] [blame] | 1724 | branch_statuses = {} |
maruel@chromium.org | 1033efd | 2013-07-23 23:25:09 +0000 | [diff] [blame] | 1725 | alignment = max(5, max(len(ShortBranchName(b)) for b in branches)) |
maruel@chromium.org | e25c75b | 2013-07-23 18:30:56 +0000 | [diff] [blame] | 1726 | for branch in sorted(branches): |
calamity@chromium.org | ffde55c | 2015-03-12 00:44:17 +0000 | [diff] [blame] | 1727 | while branch not in branch_statuses: |
nodir@chromium.org | a6de1f4 | 2015-06-10 04:23:17 +0000 | [diff] [blame] | 1728 | b, i, status = output.next() |
| 1729 | branch_statuses[b] = (i, status) |
| 1730 | issue_url, status = branch_statuses.pop(branch) |
| 1731 | color = color_for_status(status) |
maruel@chromium.org | 885f651 | 2013-07-27 02:17:26 +0000 | [diff] [blame] | 1732 | reset = Fore.RESET |
| 1733 | if not sys.stdout.isatty(): |
| 1734 | color = '' |
| 1735 | reset = '' |
nodir@chromium.org | a6de1f4 | 2015-06-10 04:23:17 +0000 | [diff] [blame] | 1736 | status_str = '(%s)' % status if status else '' |
| 1737 | print ' %*s : %s%s %s%s' % ( |
| 1738 | alignment, ShortBranchName(branch), color, issue_url, status_str, |
| 1739 | reset) |
maruel@chromium.org | 1033efd | 2013-07-23 23:25:09 +0000 | [diff] [blame] | 1740 | |
vadimsh@chromium.org | cf6a5d2 | 2015-04-09 22:02:00 +0000 | [diff] [blame] | 1741 | cl = Changelist(auth_config=auth_config) |
maruel@chromium.org | e25c75b | 2013-07-23 18:30:56 +0000 | [diff] [blame] | 1742 | print |
| 1743 | print 'Current branch:', |
maruel@chromium.org | e25c75b | 2013-07-23 18:30:56 +0000 | [diff] [blame] | 1744 | print cl.GetBranch() |
dpranke@chromium.org | ee87f58 | 2015-07-31 18:46:25 +0000 | [diff] [blame] | 1745 | if not cl.GetIssue(): |
| 1746 | print 'No issue assigned.' |
| 1747 | return 0 |
maruel@chromium.org | e25c75b | 2013-07-23 18:30:56 +0000 | [diff] [blame] | 1748 | print 'Issue number: %s (%s)' % (cl.GetIssue(), cl.GetIssueURL()) |
maruel@chromium.org | 85616e0 | 2014-07-28 15:37:55 +0000 | [diff] [blame] | 1749 | if not options.fast: |
| 1750 | print 'Issue description:' |
| 1751 | print cl.GetDescription(pretty=True) |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 1752 | return 0 |
| 1753 | |
| 1754 | |
maruel@chromium.org | 39c0b22 | 2013-08-17 16:57:01 +0000 | [diff] [blame] | 1755 | def colorize_CMDstatus_doc(): |
| 1756 | """To be called once in main() to add colors to git cl status help.""" |
| 1757 | colors = [i for i in dir(Fore) if i[0].isupper()] |
| 1758 | |
| 1759 | def colorize_line(line): |
| 1760 | for color in colors: |
| 1761 | if color in line.upper(): |
| 1762 | # Extract whitespaces first and the leading '-'. |
| 1763 | indent = len(line) - len(line.lstrip(' ')) + 1 |
| 1764 | return line[:indent] + getattr(Fore, color) + line[indent:] + Fore.RESET |
| 1765 | return line |
| 1766 | |
| 1767 | lines = CMDstatus.__doc__.splitlines() |
| 1768 | CMDstatus.__doc__ = '\n'.join(colorize_line(l) for l in lines) |
| 1769 | |
| 1770 | |
maruel@chromium.org | 0633fb4 | 2013-08-16 20:06:14 +0000 | [diff] [blame] | 1771 | @subcommand.usage('[issue_number]') |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 1772 | def CMDissue(parser, args): |
iannucci@chromium.org | d9c1b20 | 2013-07-24 23:52:11 +0000 | [diff] [blame] | 1773 | """Sets or displays the current code review issue number. |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 1774 | |
| 1775 | Pass issue number 0 to clear the current issue. |
iannucci@chromium.org | d9c1b20 | 2013-07-24 23:52:11 +0000 | [diff] [blame] | 1776 | """ |
dnj@chromium.org | 406c440 | 2015-03-03 17:22:28 +0000 | [diff] [blame] | 1777 | parser.add_option('-r', '--reverse', action='store_true', |
| 1778 | help='Lookup the branch(es) for the specified issues. If ' |
| 1779 | 'no issues are specified, all branches with mapped ' |
| 1780 | 'issues will be listed.') |
| 1781 | options, args = parser.parse_args(args) |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 1782 | |
dnj@chromium.org | 406c440 | 2015-03-03 17:22:28 +0000 | [diff] [blame] | 1783 | if options.reverse: |
| 1784 | branches = RunGit(['for-each-ref', 'refs/heads', |
| 1785 | '--format=%(refname:short)']).splitlines() |
| 1786 | |
| 1787 | # Reverse issue lookup. |
| 1788 | issue_branch_map = {} |
| 1789 | for branch in branches: |
| 1790 | cl = Changelist(branchref=branch) |
| 1791 | issue_branch_map.setdefault(cl.GetIssue(), []).append(branch) |
| 1792 | if not args: |
| 1793 | args = sorted(issue_branch_map.iterkeys()) |
| 1794 | for issue in args: |
| 1795 | if not issue: |
| 1796 | continue |
| 1797 | print 'Branch for issue number %s: %s' % ( |
| 1798 | issue, ', '.join(issue_branch_map.get(int(issue)) or ('None',))) |
| 1799 | else: |
| 1800 | cl = Changelist() |
| 1801 | if len(args) > 0: |
| 1802 | try: |
| 1803 | issue = int(args[0]) |
| 1804 | except ValueError: |
| 1805 | DieWithError('Pass a number to set the issue or none to list it.\n' |
| 1806 | 'Maybe you want to run git cl status?') |
| 1807 | cl.SetIssue(issue) |
| 1808 | print 'Issue number: %s (%s)' % (cl.GetIssue(), cl.GetIssueURL()) |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 1809 | return 0 |
| 1810 | |
| 1811 | |
maruel@chromium.org | 9977a2e | 2012-06-06 22:30:56 +0000 | [diff] [blame] | 1812 | def CMDcomments(parser, args): |
apavlov@chromium.org | e4efd51 | 2014-11-05 09:05:29 +0000 | [diff] [blame] | 1813 | """Shows or posts review comments for any changelist.""" |
| 1814 | parser.add_option('-a', '--add-comment', dest='comment', |
| 1815 | help='comment to add to an issue') |
| 1816 | parser.add_option('-i', dest='issue', |
| 1817 | help="review issue id (defaults to current issue)") |
smut@google.com | c85ac94 | 2015-09-15 16:34:43 +0000 | [diff] [blame] | 1818 | parser.add_option('-j', '--json-file', |
| 1819 | help='File to write JSON summary to') |
vadimsh@chromium.org | cf6a5d2 | 2015-04-09 22:02:00 +0000 | [diff] [blame] | 1820 | auth.add_auth_options(parser) |
apavlov@chromium.org | e4efd51 | 2014-11-05 09:05:29 +0000 | [diff] [blame] | 1821 | options, args = parser.parse_args(args) |
vadimsh@chromium.org | cf6a5d2 | 2015-04-09 22:02:00 +0000 | [diff] [blame] | 1822 | auth_config = auth.extract_auth_config_from_options(options) |
maruel@chromium.org | 9977a2e | 2012-06-06 22:30:56 +0000 | [diff] [blame] | 1823 | |
apavlov@chromium.org | e4efd51 | 2014-11-05 09:05:29 +0000 | [diff] [blame] | 1824 | issue = None |
| 1825 | if options.issue: |
| 1826 | try: |
| 1827 | issue = int(options.issue) |
| 1828 | except ValueError: |
| 1829 | DieWithError('A review issue id is expected to be a number') |
| 1830 | |
vadimsh@chromium.org | cf6a5d2 | 2015-04-09 22:02:00 +0000 | [diff] [blame] | 1831 | cl = Changelist(issue=issue, auth_config=auth_config) |
apavlov@chromium.org | e4efd51 | 2014-11-05 09:05:29 +0000 | [diff] [blame] | 1832 | |
| 1833 | if options.comment: |
| 1834 | cl.AddComment(options.comment) |
| 1835 | return 0 |
| 1836 | |
| 1837 | data = cl.GetIssueProperties() |
smut@google.com | c85ac94 | 2015-09-15 16:34:43 +0000 | [diff] [blame] | 1838 | summary = [] |
maruel@chromium.org | 5cab2d3 | 2014-11-11 18:32:41 +0000 | [diff] [blame] | 1839 | for message in sorted(data.get('messages', []), key=lambda x: x['date']): |
smut@google.com | c85ac94 | 2015-09-15 16:34:43 +0000 | [diff] [blame] | 1840 | summary.append({ |
| 1841 | 'date': message['date'], |
| 1842 | 'lgtm': False, |
| 1843 | 'message': message['text'], |
| 1844 | 'not_lgtm': False, |
| 1845 | 'sender': message['sender'], |
| 1846 | }) |
apavlov@chromium.org | e4efd51 | 2014-11-05 09:05:29 +0000 | [diff] [blame] | 1847 | if message['disapproval']: |
| 1848 | color = Fore.RED |
smut@google.com | c85ac94 | 2015-09-15 16:34:43 +0000 | [diff] [blame] | 1849 | summary[-1]['not lgtm'] = True |
apavlov@chromium.org | e4efd51 | 2014-11-05 09:05:29 +0000 | [diff] [blame] | 1850 | elif message['approval']: |
| 1851 | color = Fore.GREEN |
smut@google.com | c85ac94 | 2015-09-15 16:34:43 +0000 | [diff] [blame] | 1852 | summary[-1]['lgtm'] = True |
apavlov@chromium.org | e4efd51 | 2014-11-05 09:05:29 +0000 | [diff] [blame] | 1853 | elif message['sender'] == data['owner_email']: |
| 1854 | color = Fore.MAGENTA |
| 1855 | else: |
| 1856 | color = Fore.BLUE |
| 1857 | print '\n%s%s %s%s' % ( |
| 1858 | color, message['date'].split('.', 1)[0], message['sender'], |
| 1859 | Fore.RESET) |
| 1860 | if message['text'].strip(): |
| 1861 | print '\n'.join(' ' + l for l in message['text'].splitlines()) |
smut@google.com | c85ac94 | 2015-09-15 16:34:43 +0000 | [diff] [blame] | 1862 | if options.json_file: |
| 1863 | with open(options.json_file, 'wb') as f: |
| 1864 | json.dump(summary, f) |
maruel@chromium.org | 9977a2e | 2012-06-06 22:30:56 +0000 | [diff] [blame] | 1865 | return 0 |
| 1866 | |
| 1867 | |
rsesek@chromium.org | eec7659 | 2013-05-20 16:27:57 +0000 | [diff] [blame] | 1868 | def CMDdescription(parser, args): |
iannucci@chromium.org | d9c1b20 | 2013-07-24 23:52:11 +0000 | [diff] [blame] | 1869 | """Brings up the editor for the current CL's description.""" |
smut@google.com | 34fb6b1 | 2015-07-13 20:03:26 +0000 | [diff] [blame] | 1870 | parser.add_option('-d', '--display', action='store_true', |
| 1871 | help='Display the description instead of opening an editor') |
vadimsh@chromium.org | cf6a5d2 | 2015-04-09 22:02:00 +0000 | [diff] [blame] | 1872 | auth.add_auth_options(parser) |
| 1873 | options, _ = parser.parse_args(args) |
| 1874 | auth_config = auth.extract_auth_config_from_options(options) |
| 1875 | cl = Changelist(auth_config=auth_config) |
rsesek@chromium.org | eec7659 | 2013-05-20 16:27:57 +0000 | [diff] [blame] | 1876 | if not cl.GetIssue(): |
| 1877 | DieWithError('This branch has no associated changelist.') |
| 1878 | description = ChangeDescription(cl.GetDescription()) |
smut@google.com | 34fb6b1 | 2015-07-13 20:03:26 +0000 | [diff] [blame] | 1879 | if options.display: |
| 1880 | print description.description |
| 1881 | return 0 |
rsesek@chromium.org | eec7659 | 2013-05-20 16:27:57 +0000 | [diff] [blame] | 1882 | description.prompt() |
wychen@chromium.org | 063e4e5 | 2015-04-03 06:51:44 +0000 | [diff] [blame] | 1883 | if cl.GetDescription() != description.description: |
| 1884 | cl.UpdateDescription(description.description) |
rsesek@chromium.org | eec7659 | 2013-05-20 16:27:57 +0000 | [diff] [blame] | 1885 | return 0 |
| 1886 | |
| 1887 | |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 1888 | def CreateDescriptionFromLog(args): |
| 1889 | """Pulls out the commit log to use as a base for the CL description.""" |
| 1890 | log_args = [] |
| 1891 | if len(args) == 1 and not args[0].endswith('.'): |
| 1892 | log_args = [args[0] + '..'] |
| 1893 | elif len(args) == 1 and args[0].endswith('...'): |
| 1894 | log_args = [args[0][:-1]] |
| 1895 | elif len(args) == 2: |
| 1896 | log_args = [args[0] + '..' + args[1]] |
| 1897 | else: |
| 1898 | log_args = args[:] # Hope for the best! |
maruel@chromium.org | 373af80 | 2012-05-25 21:07:33 +0000 | [diff] [blame] | 1899 | return RunGit(['log', '--pretty=format:%s\n\n%b'] + log_args) |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 1900 | |
| 1901 | |
thestig@chromium.org | 44202a2 | 2014-03-11 19:22:18 +0000 | [diff] [blame] | 1902 | def CMDlint(parser, args): |
| 1903 | """Runs cpplint on the current changelist.""" |
tzik@chromium.org | f204d4b | 2014-03-13 07:40:55 +0000 | [diff] [blame] | 1904 | parser.add_option('--filter', action='append', metavar='-x,+y', |
| 1905 | help='Comma-separated list of cpplint\'s category-filters') |
vadimsh@chromium.org | cf6a5d2 | 2015-04-09 22:02:00 +0000 | [diff] [blame] | 1906 | auth.add_auth_options(parser) |
| 1907 | options, args = parser.parse_args(args) |
| 1908 | auth_config = auth.extract_auth_config_from_options(options) |
thestig@chromium.org | 44202a2 | 2014-03-11 19:22:18 +0000 | [diff] [blame] | 1909 | |
| 1910 | # Access to a protected member _XX of a client class |
| 1911 | # pylint: disable=W0212 |
| 1912 | try: |
| 1913 | import cpplint |
| 1914 | import cpplint_chromium |
| 1915 | except ImportError: |
| 1916 | print "Your depot_tools is missing cpplint.py and/or cpplint_chromium.py." |
| 1917 | return 1 |
| 1918 | |
| 1919 | # Change the current working directory before calling lint so that it |
| 1920 | # shows the correct base. |
| 1921 | previous_cwd = os.getcwd() |
| 1922 | os.chdir(settings.GetRoot()) |
| 1923 | try: |
vadimsh@chromium.org | cf6a5d2 | 2015-04-09 22:02:00 +0000 | [diff] [blame] | 1924 | cl = Changelist(auth_config=auth_config) |
thestig@chromium.org | 44202a2 | 2014-03-11 19:22:18 +0000 | [diff] [blame] | 1925 | change = cl.GetChange(cl.GetCommonAncestorWithUpstream(), None) |
| 1926 | files = [f.LocalPath() for f in change.AffectedFiles()] |
thestig@chromium.org | 5839eb5 | 2014-05-30 16:20:51 +0000 | [diff] [blame] | 1927 | if not files: |
| 1928 | print "Cannot lint an empty CL" |
| 1929 | return 1 |
thestig@chromium.org | 44202a2 | 2014-03-11 19:22:18 +0000 | [diff] [blame] | 1930 | |
| 1931 | # Process cpplints arguments if any. |
tzik@chromium.org | f204d4b | 2014-03-13 07:40:55 +0000 | [diff] [blame] | 1932 | command = args + files |
| 1933 | if options.filter: |
| 1934 | command = ['--filter=' + ','.join(options.filter)] + command |
| 1935 | filenames = cpplint.ParseArguments(command) |
thestig@chromium.org | 44202a2 | 2014-03-11 19:22:18 +0000 | [diff] [blame] | 1936 | |
| 1937 | white_regex = re.compile(settings.GetLintRegex()) |
| 1938 | black_regex = re.compile(settings.GetLintIgnoreRegex()) |
| 1939 | extra_check_functions = [cpplint_chromium.CheckPointerDeclarationWhitespace] |
| 1940 | for filename in filenames: |
| 1941 | if white_regex.match(filename): |
| 1942 | if black_regex.match(filename): |
| 1943 | print "Ignoring file %s" % filename |
| 1944 | else: |
| 1945 | cpplint.ProcessFile(filename, cpplint._cpplint_state.verbose_level, |
| 1946 | extra_check_functions) |
| 1947 | else: |
| 1948 | print "Skipping file %s" % filename |
| 1949 | finally: |
| 1950 | os.chdir(previous_cwd) |
| 1951 | print "Total errors found: %d\n" % cpplint._cpplint_state.error_count |
| 1952 | if cpplint._cpplint_state.error_count != 0: |
| 1953 | return 1 |
| 1954 | return 0 |
| 1955 | |
| 1956 | |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 1957 | def CMDpresubmit(parser, args): |
iannucci@chromium.org | d9c1b20 | 2013-07-24 23:52:11 +0000 | [diff] [blame] | 1958 | """Runs presubmit tests on the current changelist.""" |
ilevy@chromium.org | 375a902 | 2013-01-07 01:12:05 +0000 | [diff] [blame] | 1959 | parser.add_option('-u', '--upload', action='store_true', |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 1960 | help='Run upload hook instead of the push/dcommit hook') |
ilevy@chromium.org | 375a902 | 2013-01-07 01:12:05 +0000 | [diff] [blame] | 1961 | parser.add_option('-f', '--force', action='store_true', |
sbc@chromium.org | 495ad15 | 2012-09-04 23:07:42 +0000 | [diff] [blame] | 1962 | help='Run checks even if tree is dirty') |
vadimsh@chromium.org | cf6a5d2 | 2015-04-09 22:02:00 +0000 | [diff] [blame] | 1963 | auth.add_auth_options(parser) |
| 1964 | options, args = parser.parse_args(args) |
| 1965 | auth_config = auth.extract_auth_config_from_options(options) |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 1966 | |
sbc@chromium.org | 71437c0 | 2015-04-09 19:29:40 +0000 | [diff] [blame] | 1967 | if not options.force and git_common.is_dirty_git_tree('presubmit'): |
ukai@chromium.org | 259e468 | 2012-10-25 07:36:33 +0000 | [diff] [blame] | 1968 | print 'use --force to check even if tree is dirty.' |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 1969 | return 1 |
| 1970 | |
vadimsh@chromium.org | cf6a5d2 | 2015-04-09 22:02:00 +0000 | [diff] [blame] | 1971 | cl = Changelist(auth_config=auth_config) |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 1972 | if args: |
| 1973 | base_branch = args[0] |
| 1974 | else: |
ilevy@chromium.org | 0f58fa8 | 2012-11-05 01:45:20 +0000 | [diff] [blame] | 1975 | # Default to diffing against the common ancestor of the upstream branch. |
thestig@chromium.org | 8b0553c | 2014-02-11 00:33:37 +0000 | [diff] [blame] | 1976 | base_branch = cl.GetCommonAncestorWithUpstream() |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 1977 | |
ilevy@chromium.org | 051ad0e | 2013-03-04 21:57:34 +0000 | [diff] [blame] | 1978 | cl.RunHook( |
| 1979 | committing=not options.upload, |
| 1980 | may_prompt=False, |
| 1981 | verbose=options.verbose, |
| 1982 | change=cl.GetChange(base_branch, None)) |
dpranke@chromium.org | 0a2bb37 | 2011-03-25 01:16:22 +0000 | [diff] [blame] | 1983 | return 0 |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 1984 | |
| 1985 | |
sivachandra@chromium.org | aebe87f | 2012-10-22 20:34:21 +0000 | [diff] [blame] | 1986 | def AddChangeIdToCommitMessage(options, args): |
| 1987 | """Re-commits using the current message, assumes the commit hook is in |
| 1988 | place. |
| 1989 | """ |
| 1990 | log_desc = options.message or CreateDescriptionFromLog(args) |
| 1991 | git_command = ['commit', '--amend', '-m', log_desc] |
| 1992 | RunGit(git_command) |
| 1993 | new_log_desc = CreateDescriptionFromLog(args) |
| 1994 | if CHANGE_ID in new_log_desc: |
| 1995 | print 'git-cl: Added Change-Id to commit message.' |
| 1996 | else: |
| 1997 | print >> sys.stderr, 'ERROR: Gerrit commit-msg hook not available.' |
| 1998 | |
| 1999 | |
piman@chromium.org | 336f912 | 2014-09-04 02:16:55 +0000 | [diff] [blame] | 2000 | def GerritUpload(options, args, cl, change): |
ukai@chromium.org | e807781 | 2012-02-03 03:41:46 +0000 | [diff] [blame] | 2001 | """upload the current branch to gerrit.""" |
| 2002 | # We assume the remote called "origin" is the one we want. |
| 2003 | # It is probably not worthwhile to support different workflows. |
bauerb@chromium.org | 27386dd | 2015-02-16 10:45:39 +0000 | [diff] [blame] | 2004 | gerrit_remote = 'origin' |
luqui@chromium.org | 609f395 | 2015-05-04 22:47:04 +0000 | [diff] [blame] | 2005 | |
| 2006 | remote, remote_branch = cl.GetRemoteBranch() |
| 2007 | branch = GetTargetRef(remote, remote_branch, options.target_branch, |
| 2008 | pending_prefix='') |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 2009 | |
maruel@chromium.org | 78936cb | 2013-04-11 00:17:52 +0000 | [diff] [blame] | 2010 | change_desc = ChangeDescription( |
| 2011 | options.message or CreateDescriptionFromLog(args)) |
| 2012 | if not change_desc.description: |
ukai@chromium.org | e807781 | 2012-02-03 03:41:46 +0000 | [diff] [blame] | 2013 | print "Description is empty; aborting." |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 2014 | return 1 |
bauerb@chromium.org | f75c230 | 2014-05-01 08:19:30 +0000 | [diff] [blame] | 2015 | |
bauerb@chromium.org | 27386dd | 2015-02-16 10:45:39 +0000 | [diff] [blame] | 2016 | if options.squash: |
| 2017 | # Try to get the message from a previous upload. |
| 2018 | shadow_branch = 'refs/heads/git_cl_uploads/' + cl.GetBranch() |
| 2019 | message = RunGitSilent(['show', '--format=%s\n\n%b', '-s', shadow_branch]) |
| 2020 | if not message: |
| 2021 | if not options.force: |
| 2022 | change_desc.prompt() |
| 2023 | |
| 2024 | if CHANGE_ID not in change_desc.description: |
| 2025 | # Run the commit-msg hook without modifying the head commit by writing |
| 2026 | # the commit message to a temporary file and running the hook over it, |
| 2027 | # then reading the file back in. |
| 2028 | commit_msg_hook = os.path.join(settings.GetRoot(), '.git', 'hooks', |
| 2029 | 'commit-msg') |
| 2030 | file_handle, msg_file = tempfile.mkstemp(text=True, |
| 2031 | prefix='commit_msg') |
tandrii@chromium.org | a83663a | 2016-01-14 16:01:00 +0000 | [diff] [blame] | 2032 | logging.debug("%s %s", file_handle, msg_file) |
bauerb@chromium.org | 27386dd | 2015-02-16 10:45:39 +0000 | [diff] [blame] | 2033 | try: |
| 2034 | try: |
tandrii@chromium.org | a83663a | 2016-01-14 16:01:00 +0000 | [diff] [blame] | 2035 | try: |
| 2036 | fileobj = os.fdopen(file_handle, 'w') |
| 2037 | except OSError: |
| 2038 | # if fdopen fails, file_handle remains open. |
| 2039 | # See https://docs.python.org/2/library/os.html#os.fdopen. |
| 2040 | os.close(file_handle) |
| 2041 | raise |
| 2042 | with fileobj: |
| 2043 | # This will close the file_handle. |
bauerb@chromium.org | 27386dd | 2015-02-16 10:45:39 +0000 | [diff] [blame] | 2044 | fileobj.write(change_desc.description) |
tandrii@chromium.org | a83663a | 2016-01-14 16:01:00 +0000 | [diff] [blame] | 2045 | logging.debug("%s %s finish editing", file_handle, msg_file) |
bauerb@chromium.org | 27386dd | 2015-02-16 10:45:39 +0000 | [diff] [blame] | 2046 | finally: |
bauerb@chromium.org | 27386dd | 2015-02-16 10:45:39 +0000 | [diff] [blame] | 2047 | RunCommand([commit_msg_hook, msg_file]) |
| 2048 | change_desc.set_description(gclient_utils.FileRead(msg_file)) |
| 2049 | finally: |
| 2050 | os.remove(msg_file) |
| 2051 | |
| 2052 | if not change_desc.description: |
| 2053 | print "Description is empty; aborting." |
| 2054 | return 1 |
| 2055 | |
| 2056 | message = change_desc.description |
| 2057 | |
| 2058 | remote, upstream_branch = cl.FetchUpstreamTuple(cl.GetBranch()) |
| 2059 | if remote is '.': |
| 2060 | # If our upstream branch is local, we base our squashed commit on its |
| 2061 | # squashed version. |
| 2062 | parent = ('refs/heads/git_cl_uploads/' + |
| 2063 | scm.GIT.ShortBranchName(upstream_branch)) |
| 2064 | |
| 2065 | # Verify that the upstream branch has been uploaded too, otherwise Gerrit |
| 2066 | # will create additional CLs when uploading. |
| 2067 | if (RunGitSilent(['rev-parse', upstream_branch + ':']) != |
| 2068 | RunGitSilent(['rev-parse', parent + ':'])): |
| 2069 | print 'Upload upstream branch ' + upstream_branch + ' first.' |
| 2070 | return 1 |
| 2071 | else: |
| 2072 | parent = cl.GetCommonAncestorWithUpstream() |
| 2073 | |
| 2074 | tree = RunGit(['rev-parse', 'HEAD:']).strip() |
| 2075 | ref_to_push = RunGit(['commit-tree', tree, '-p', parent, |
| 2076 | '-m', message]).strip() |
| 2077 | else: |
| 2078 | if CHANGE_ID not in change_desc.description: |
| 2079 | AddChangeIdToCommitMessage(options, args) |
| 2080 | ref_to_push = 'HEAD' |
| 2081 | parent = '%s/%s' % (gerrit_remote, branch) |
| 2082 | |
| 2083 | commits = RunGitSilent(['rev-list', '%s..%s' % (parent, |
| 2084 | ref_to_push)]).splitlines() |
bauerb@chromium.org | f75c230 | 2014-05-01 08:19:30 +0000 | [diff] [blame] | 2085 | if len(commits) > 1: |
| 2086 | print('WARNING: This will upload %d commits. Run the following command ' |
| 2087 | 'to see which commits will be uploaded: ' % len(commits)) |
bauerb@chromium.org | 27386dd | 2015-02-16 10:45:39 +0000 | [diff] [blame] | 2088 | print('git log %s..%s' % (parent, ref_to_push)) |
| 2089 | print('You can also use `git squash-branch` to squash these into a single ' |
bauerb@chromium.org | f75c230 | 2014-05-01 08:19:30 +0000 | [diff] [blame] | 2090 | 'commit.') |
| 2091 | ask_for_data('About to upload; enter to confirm.') |
| 2092 | |
piman@chromium.org | 336f912 | 2014-09-04 02:16:55 +0000 | [diff] [blame] | 2093 | if options.reviewers or options.tbr_owners: |
| 2094 | change_desc.update_reviewers(options.reviewers, options.tbr_owners, change) |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 2095 | |
ukai@chromium.org | e807781 | 2012-02-03 03:41:46 +0000 | [diff] [blame] | 2096 | receive_options = [] |
| 2097 | cc = cl.GetCCList().split(',') |
| 2098 | if options.cc: |
maruel@chromium.org | eb52a5c | 2013-04-10 23:17:09 +0000 | [diff] [blame] | 2099 | cc.extend(options.cc) |
ukai@chromium.org | e807781 | 2012-02-03 03:41:46 +0000 | [diff] [blame] | 2100 | cc = filter(None, cc) |
| 2101 | if cc: |
| 2102 | receive_options += ['--cc=' + email for email in cc] |
maruel@chromium.org | 78936cb | 2013-04-11 00:17:52 +0000 | [diff] [blame] | 2103 | if change_desc.get_reviewers(): |
| 2104 | receive_options.extend( |
| 2105 | '--reviewer=' + email for email in change_desc.get_reviewers()) |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 2106 | |
ukai@chromium.org | e807781 | 2012-02-03 03:41:46 +0000 | [diff] [blame] | 2107 | git_command = ['push'] |
| 2108 | if receive_options: |
ukai@chromium.org | 19bbfa2 | 2012-02-03 16:18:11 +0000 | [diff] [blame] | 2109 | git_command.append('--receive-pack=git receive-pack %s' % |
ukai@chromium.org | e807781 | 2012-02-03 03:41:46 +0000 | [diff] [blame] | 2110 | ' '.join(receive_options)) |
bauerb@chromium.org | 27386dd | 2015-02-16 10:45:39 +0000 | [diff] [blame] | 2111 | git_command += [gerrit_remote, ref_to_push + ':refs/for/' + branch] |
ukai@chromium.org | e807781 | 2012-02-03 03:41:46 +0000 | [diff] [blame] | 2112 | RunGit(git_command) |
bauerb@chromium.org | 27386dd | 2015-02-16 10:45:39 +0000 | [diff] [blame] | 2113 | |
| 2114 | if options.squash: |
| 2115 | head = RunGit(['rev-parse', 'HEAD']).strip() |
| 2116 | RunGit(['update-ref', '-m', 'Uploaded ' + head, shadow_branch, ref_to_push]) |
| 2117 | |
ukai@chromium.org | e807781 | 2012-02-03 03:41:46 +0000 | [diff] [blame] | 2118 | # TODO(ukai): parse Change-Id: and set issue number? |
| 2119 | return 0 |
dpranke@chromium.org | 970c522 | 2011-03-12 00:32:24 +0000 | [diff] [blame] | 2120 | |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 2121 | |
wittman@chromium.org | 455dc92 | 2015-01-26 20:15:50 +0000 | [diff] [blame] | 2122 | def GetTargetRef(remote, remote_branch, target_branch, pending_prefix): |
| 2123 | """Computes the remote branch ref to use for the CL. |
| 2124 | |
| 2125 | Args: |
| 2126 | remote (str): The git remote for the CL. |
| 2127 | remote_branch (str): The git remote branch for the CL. |
| 2128 | target_branch (str): The target branch specified by the user. |
| 2129 | pending_prefix (str): The pending prefix from the settings. |
| 2130 | """ |
| 2131 | if not (remote and remote_branch): |
| 2132 | return None |
bauerb@chromium.org | 27386dd | 2015-02-16 10:45:39 +0000 | [diff] [blame] | 2133 | |
wittman@chromium.org | 455dc92 | 2015-01-26 20:15:50 +0000 | [diff] [blame] | 2134 | if target_branch: |
| 2135 | # Cannonicalize branch references to the equivalent local full symbolic |
| 2136 | # refs, which are then translated into the remote full symbolic refs |
| 2137 | # below. |
| 2138 | if '/' not in target_branch: |
| 2139 | remote_branch = 'refs/remotes/%s/%s' % (remote, target_branch) |
| 2140 | else: |
| 2141 | prefix_replacements = ( |
| 2142 | ('^((refs/)?remotes/)?branch-heads/', 'refs/remotes/branch-heads/'), |
| 2143 | ('^((refs/)?remotes/)?%s/' % remote, 'refs/remotes/%s/' % remote), |
| 2144 | ('^(refs/)?heads/', 'refs/remotes/%s/' % remote), |
| 2145 | ) |
| 2146 | match = None |
| 2147 | for regex, replacement in prefix_replacements: |
| 2148 | match = re.search(regex, target_branch) |
| 2149 | if match: |
| 2150 | remote_branch = target_branch.replace(match.group(0), replacement) |
| 2151 | break |
| 2152 | if not match: |
| 2153 | # This is a branch path but not one we recognize; use as-is. |
| 2154 | remote_branch = target_branch |
rmistry@google.com | c68112d | 2015-03-03 12:48:06 +0000 | [diff] [blame] | 2155 | elif remote_branch in REFS_THAT_ALIAS_TO_OTHER_REFS: |
| 2156 | # Handle the refs that need to land in different refs. |
| 2157 | remote_branch = REFS_THAT_ALIAS_TO_OTHER_REFS[remote_branch] |
bauerb@chromium.org | 27386dd | 2015-02-16 10:45:39 +0000 | [diff] [blame] | 2158 | |
wittman@chromium.org | 455dc92 | 2015-01-26 20:15:50 +0000 | [diff] [blame] | 2159 | # Create the true path to the remote branch. |
| 2160 | # Does the following translation: |
| 2161 | # * refs/remotes/origin/refs/diff/test -> refs/diff/test |
| 2162 | # * refs/remotes/origin/master -> refs/heads/master |
| 2163 | # * refs/remotes/branch-heads/test -> refs/branch-heads/test |
| 2164 | if remote_branch.startswith('refs/remotes/%s/refs/' % remote): |
| 2165 | remote_branch = remote_branch.replace('refs/remotes/%s/' % remote, '') |
| 2166 | elif remote_branch.startswith('refs/remotes/%s/' % remote): |
| 2167 | remote_branch = remote_branch.replace('refs/remotes/%s/' % remote, |
| 2168 | 'refs/heads/') |
| 2169 | elif remote_branch.startswith('refs/remotes/branch-heads'): |
| 2170 | remote_branch = remote_branch.replace('refs/remotes/', 'refs/') |
| 2171 | # If a pending prefix exists then replace refs/ with it. |
| 2172 | if pending_prefix: |
| 2173 | remote_branch = remote_branch.replace('refs/', pending_prefix) |
| 2174 | return remote_branch |
| 2175 | |
| 2176 | |
piman@chromium.org | 336f912 | 2014-09-04 02:16:55 +0000 | [diff] [blame] | 2177 | def RietveldUpload(options, args, cl, change): |
ukai@chromium.org | e807781 | 2012-02-03 03:41:46 +0000 | [diff] [blame] | 2178 | """upload the patch to rietveld.""" |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 2179 | upload_args = ['--assume_yes'] # Don't ask about untracked files. |
| 2180 | upload_args.extend(['--server', cl.GetRietveldServer()]) |
vadimsh@chromium.org | cf6a5d2 | 2015-04-09 22:02:00 +0000 | [diff] [blame] | 2181 | upload_args.extend(auth.auth_config_to_command_options(cl.auth_config)) |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 2182 | if options.emulate_svn_auto_props: |
| 2183 | upload_args.append('--emulate_svn_auto_props') |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 2184 | |
| 2185 | change_desc = None |
| 2186 | |
pgervais@chromium.org | 9114137 | 2014-01-09 23:27:20 +0000 | [diff] [blame] | 2187 | if options.email is not None: |
| 2188 | upload_args.extend(['--email', options.email]) |
| 2189 | |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 2190 | if cl.GetIssue(): |
rogerta@chromium.org | 420d3b8 | 2012-05-14 18:41:38 +0000 | [diff] [blame] | 2191 | if options.title: |
| 2192 | upload_args.extend(['--title', options.title]) |
rogerta@chromium.org | afadfca | 2013-05-29 14:15:53 +0000 | [diff] [blame] | 2193 | if options.message: |
| 2194 | upload_args.extend(['--message', options.message]) |
maruel@chromium.org | 5242430 | 2012-08-29 15:14:30 +0000 | [diff] [blame] | 2195 | upload_args.extend(['--issue', str(cl.GetIssue())]) |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 2196 | print ("This branch is associated with issue %s. " |
| 2197 | "Adding patch to that issue." % cl.GetIssue()) |
| 2198 | else: |
rogerta@chromium.org | 420d3b8 | 2012-05-14 18:41:38 +0000 | [diff] [blame] | 2199 | if options.title: |
| 2200 | upload_args.extend(['--title', options.title]) |
rogerta@chromium.org | 43e34f0 | 2013-03-25 14:52:48 +0000 | [diff] [blame] | 2201 | message = options.title or options.message or CreateDescriptionFromLog(args) |
maruel@chromium.org | 78936cb | 2013-04-11 00:17:52 +0000 | [diff] [blame] | 2202 | change_desc = ChangeDescription(message) |
piman@chromium.org | 336f912 | 2014-09-04 02:16:55 +0000 | [diff] [blame] | 2203 | if options.reviewers or options.tbr_owners: |
| 2204 | change_desc.update_reviewers(options.reviewers, |
| 2205 | options.tbr_owners, |
| 2206 | change) |
maruel@chromium.org | 71e12a9 | 2012-02-14 02:34:15 +0000 | [diff] [blame] | 2207 | if not options.force: |
maruel@chromium.org | 78936cb | 2013-04-11 00:17:52 +0000 | [diff] [blame] | 2208 | change_desc.prompt() |
dpranke@chromium.org | 970c522 | 2011-03-12 00:32:24 +0000 | [diff] [blame] | 2209 | |
maruel@chromium.org | 78936cb | 2013-04-11 00:17:52 +0000 | [diff] [blame] | 2210 | if not change_desc.description: |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 2211 | print "Description is empty; aborting." |
| 2212 | return 1 |
dpranke@chromium.org | 970c522 | 2011-03-12 00:32:24 +0000 | [diff] [blame] | 2213 | |
maruel@chromium.org | 71e12a9 | 2012-02-14 02:34:15 +0000 | [diff] [blame] | 2214 | upload_args.extend(['--message', change_desc.description]) |
maruel@chromium.org | 78936cb | 2013-04-11 00:17:52 +0000 | [diff] [blame] | 2215 | if change_desc.get_reviewers(): |
| 2216 | upload_args.append('--reviewers=' + ','.join(change_desc.get_reviewers())) |
maruel@chromium.org | a335365 | 2011-11-30 14:26:57 +0000 | [diff] [blame] | 2217 | if options.send_mail: |
maruel@chromium.org | 78936cb | 2013-04-11 00:17:52 +0000 | [diff] [blame] | 2218 | if not change_desc.get_reviewers(): |
maruel@chromium.org | a335365 | 2011-11-30 14:26:57 +0000 | [diff] [blame] | 2219 | DieWithError("Must specify reviewers to send email.") |
| 2220 | upload_args.append('--send_mail') |
tyoshino@chromium.org | 99918ab | 2013-09-30 06:17:28 +0000 | [diff] [blame] | 2221 | |
| 2222 | # We check this before applying rietveld.private assuming that in |
| 2223 | # rietveld.cc only addresses which we can send private CLs to are listed |
| 2224 | # if rietveld.private is set, and so we should ignore rietveld.cc only when |
| 2225 | # --private is specified explicitly on the command line. |
| 2226 | if options.private: |
| 2227 | logging.warn('rietveld.cc is ignored since private flag is specified. ' |
| 2228 | 'You need to review and add them manually if necessary.') |
| 2229 | cc = cl.GetCCListWithoutDefault() |
| 2230 | else: |
| 2231 | cc = cl.GetCCList() |
| 2232 | cc = ','.join(filter(None, (cc, ','.join(options.cc)))) |
maruel@chromium.org | b2a7c33 | 2011-02-25 20:30:37 +0000 | [diff] [blame] | 2233 | if cc: |
| 2234 | upload_args.extend(['--cc', cc]) |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 2235 | |
tyoshino@chromium.org | c1737d0 | 2013-05-29 14:17:28 +0000 | [diff] [blame] | 2236 | if options.private or settings.GetDefaultPrivateFlag() == "True": |
| 2237 | upload_args.append('--private') |
| 2238 | |
iannucci@chromium.org | 53937ba | 2012-10-02 18:20:43 +0000 | [diff] [blame] | 2239 | upload_args.extend(['--git_similarity', str(options.similarity)]) |
iannucci@chromium.org | 7954005 | 2012-10-19 23:15:26 +0000 | [diff] [blame] | 2240 | if not options.find_copies: |
| 2241 | upload_args.extend(['--git_no_find_copies']) |
iannucci@chromium.org | 53937ba | 2012-10-02 18:20:43 +0000 | [diff] [blame] | 2242 | |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 2243 | # Include the upstream repo's URL in the change -- this is useful for |
| 2244 | # projects that have their source spread across multiple repos. |
kalmard@homejinni.com | 6b0051e | 2012-04-03 15:45:08 +0000 | [diff] [blame] | 2245 | remote_url = cl.GetGitBaseUrlFromConfig() |
| 2246 | if not remote_url: |
| 2247 | if settings.GetIsGitSvn(): |
kjellander@chromium.org | 6abc652 | 2014-12-02 07:34:49 +0000 | [diff] [blame] | 2248 | remote_url = cl.GetGitSvnRemoteUrl() |
kalmard@homejinni.com | 6b0051e | 2012-04-03 15:45:08 +0000 | [diff] [blame] | 2249 | else: |
jam@chromium.org | 80c51ae | 2014-10-17 18:43:02 +0000 | [diff] [blame] | 2250 | if cl.GetRemoteUrl() and '/' in cl.GetUpstreamBranch(): |
| 2251 | remote_url = (cl.GetRemoteUrl() + '@' |
| 2252 | + cl.GetUpstreamBranch().split('/')[-1]) |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 2253 | if remote_url: |
| 2254 | upload_args.extend(['--base_url', remote_url]) |
rmistry@google.com | d1e3758 | 2014-12-10 20:58:24 +0000 | [diff] [blame] | 2255 | remote, remote_branch = cl.GetRemoteBranch() |
wittman@chromium.org | 455dc92 | 2015-01-26 20:15:50 +0000 | [diff] [blame] | 2256 | target_ref = GetTargetRef(remote, remote_branch, options.target_branch, |
| 2257 | settings.GetPendingRefPrefix()) |
| 2258 | if target_ref: |
| 2259 | upload_args.extend(['--target_ref', target_ref]) |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 2260 | |
rmistry@google.com | d91b7e3 | 2015-06-23 11:24:07 +0000 | [diff] [blame] | 2261 | # Look for dependent patchsets. See crbug.com/480453 for more details. |
| 2262 | remote, upstream_branch = cl.FetchUpstreamTuple(cl.GetBranch()) |
| 2263 | upstream_branch = ShortBranchName(upstream_branch) |
| 2264 | if remote is '.': |
| 2265 | # A local branch is being tracked. |
| 2266 | local_branch = ShortBranchName(upstream_branch) |
rmistry@google.com | 78948ed | 2015-07-08 23:09:57 +0000 | [diff] [blame] | 2267 | if settings.GetIsSkipDependencyUpload(local_branch): |
rmistry@google.com | d91b7e3 | 2015-06-23 11:24:07 +0000 | [diff] [blame] | 2268 | print |
rmistry@google.com | 78948ed | 2015-07-08 23:09:57 +0000 | [diff] [blame] | 2269 | print ('Skipping dependency patchset upload because git config ' |
| 2270 | 'branch.%s.skip-deps-uploads is set to True.' % local_branch) |
rmistry@google.com | d91b7e3 | 2015-06-23 11:24:07 +0000 | [diff] [blame] | 2271 | print |
rmistry@google.com | 78948ed | 2015-07-08 23:09:57 +0000 | [diff] [blame] | 2272 | else: |
| 2273 | auth_config = auth.extract_auth_config_from_options(options) |
| 2274 | branch_cl = Changelist(branchref=local_branch, auth_config=auth_config) |
| 2275 | branch_cl_issue_url = branch_cl.GetIssueURL() |
| 2276 | branch_cl_issue = branch_cl.GetIssue() |
| 2277 | branch_cl_patchset = branch_cl.GetPatchset() |
| 2278 | if branch_cl_issue_url and branch_cl_issue and branch_cl_patchset: |
| 2279 | upload_args.extend( |
| 2280 | ['--depends_on_patchset', '%s:%s' % ( |
| 2281 | branch_cl_issue, branch_cl_patchset)]) |
| 2282 | print |
| 2283 | print ('The current branch (%s) is tracking a local branch (%s) with ' |
| 2284 | 'an associated CL.') % (cl.GetBranch(), local_branch) |
| 2285 | print 'Adding %s/#ps%s as a dependency patchset.' % ( |
| 2286 | branch_cl_issue_url, branch_cl_patchset) |
| 2287 | print |
rmistry@google.com | d91b7e3 | 2015-06-23 11:24:07 +0000 | [diff] [blame] | 2288 | |
sheyang@chromium.org | 152cf83 | 2014-06-11 21:37:49 +0000 | [diff] [blame] | 2289 | project = settings.GetProject() |
| 2290 | if project: |
| 2291 | upload_args.extend(['--project', project]) |
| 2292 | |
rmistry@google.com | ef96622 | 2015-04-07 11:15:01 +0000 | [diff] [blame] | 2293 | if options.cq_dry_run: |
| 2294 | upload_args.extend(['--cq_dry_run']) |
| 2295 | |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 2296 | try: |
ilevy@chromium.org | 8288019 | 2012-11-26 15:41:57 +0000 | [diff] [blame] | 2297 | upload_args = ['upload'] + upload_args + args |
| 2298 | logging.info('upload.RealMain(%s)', upload_args) |
| 2299 | issue, patchset = upload.RealMain(upload_args) |
maruel@chromium.org | 911fce1 | 2013-07-29 23:01:13 +0000 | [diff] [blame] | 2300 | issue = int(issue) |
| 2301 | patchset = int(patchset) |
maruel@chromium.org | 9ce0dff | 2011-04-04 17:56:50 +0000 | [diff] [blame] | 2302 | except KeyboardInterrupt: |
| 2303 | sys.exit(1) |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 2304 | except: |
| 2305 | # If we got an exception after the user typed a description for their |
| 2306 | # change, back up the description before re-raising. |
| 2307 | if change_desc: |
| 2308 | backup_path = os.path.expanduser(DESCRIPTION_BACKUP_FILE) |
| 2309 | print '\nGot exception while uploading -- saving description to %s\n' \ |
| 2310 | % backup_path |
| 2311 | backup_file = open(backup_path, 'w') |
dpranke@chromium.org | 970c522 | 2011-03-12 00:32:24 +0000 | [diff] [blame] | 2312 | backup_file.write(change_desc.description) |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 2313 | backup_file.close() |
| 2314 | raise |
| 2315 | |
| 2316 | if not cl.GetIssue(): |
| 2317 | cl.SetIssue(issue) |
| 2318 | cl.SetPatchset(patchset) |
maruel@chromium.org | 27bb387 | 2011-05-30 20:33:19 +0000 | [diff] [blame] | 2319 | |
| 2320 | if options.use_commit_queue: |
| 2321 | cl.SetFlag('commit', '1') |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 2322 | return 0 |
| 2323 | |
| 2324 | |
maruel@chromium.org | eb52a5c | 2013-04-10 23:17:09 +0000 | [diff] [blame] | 2325 | def cleanup_list(l): |
| 2326 | """Fixes a list so that comma separated items are put as individual items. |
| 2327 | |
| 2328 | So that "--reviewers joe@c,john@c --reviewers joa@c" results in |
| 2329 | options.reviewers == sorted(['joe@c', 'john@c', 'joa@c']). |
| 2330 | """ |
| 2331 | items = sum((i.split(',') for i in l), []) |
| 2332 | stripped_items = (i.strip() for i in items) |
| 2333 | return sorted(filter(None, stripped_items)) |
| 2334 | |
| 2335 | |
maruel@chromium.org | 0633fb4 | 2013-08-16 20:06:14 +0000 | [diff] [blame] | 2336 | @subcommand.usage('[args to "git diff"]') |
ukai@chromium.org | e807781 | 2012-02-03 03:41:46 +0000 | [diff] [blame] | 2337 | def CMDupload(parser, args): |
rmistry@google.com | 78948ed | 2015-07-08 23:09:57 +0000 | [diff] [blame] | 2338 | """Uploads the current changelist to codereview. |
| 2339 | |
| 2340 | Can skip dependency patchset uploads for a branch by running: |
| 2341 | git config branch.branch_name.skip-deps-uploads True |
| 2342 | To unset run: |
| 2343 | git config --unset branch.branch_name.skip-deps-uploads |
| 2344 | Can also set the above globally by using the --global flag. |
| 2345 | """ |
ukai@chromium.org | e807781 | 2012-02-03 03:41:46 +0000 | [diff] [blame] | 2346 | parser.add_option('--bypass-hooks', action='store_true', dest='bypass_hooks', |
| 2347 | help='bypass upload presubmit hook') |
brettw@chromium.org | b65c43c | 2013-06-10 22:04:49 +0000 | [diff] [blame] | 2348 | parser.add_option('--bypass-watchlists', action='store_true', |
| 2349 | dest='bypass_watchlists', |
| 2350 | help='bypass watchlists auto CC-ing reviewers') |
ukai@chromium.org | e807781 | 2012-02-03 03:41:46 +0000 | [diff] [blame] | 2351 | parser.add_option('-f', action='store_true', dest='force', |
| 2352 | help="force yes to questions (don't prompt)") |
rogerta@chromium.org | 420d3b8 | 2012-05-14 18:41:38 +0000 | [diff] [blame] | 2353 | parser.add_option('-m', dest='message', help='message for patchset') |
| 2354 | parser.add_option('-t', dest='title', help='title for patchset') |
ukai@chromium.org | e807781 | 2012-02-03 03:41:46 +0000 | [diff] [blame] | 2355 | parser.add_option('-r', '--reviewers', |
maruel@chromium.org | eb52a5c | 2013-04-10 23:17:09 +0000 | [diff] [blame] | 2356 | action='append', default=[], |
ukai@chromium.org | e807781 | 2012-02-03 03:41:46 +0000 | [diff] [blame] | 2357 | help='reviewer email addresses') |
| 2358 | parser.add_option('--cc', |
maruel@chromium.org | eb52a5c | 2013-04-10 23:17:09 +0000 | [diff] [blame] | 2359 | action='append', default=[], |
ukai@chromium.org | e807781 | 2012-02-03 03:41:46 +0000 | [diff] [blame] | 2360 | help='cc email addresses') |
adamk@chromium.org | 36f4730 | 2013-04-05 01:08:31 +0000 | [diff] [blame] | 2361 | parser.add_option('-s', '--send-mail', action='store_true', |
ukai@chromium.org | e807781 | 2012-02-03 03:41:46 +0000 | [diff] [blame] | 2362 | help='send email to reviewer immediately') |
pgervais@chromium.org | b9f2751 | 2014-08-08 15:52:33 +0000 | [diff] [blame] | 2363 | parser.add_option('--emulate_svn_auto_props', |
| 2364 | '--emulate-svn-auto-props', |
| 2365 | action="store_true", |
ukai@chromium.org | e807781 | 2012-02-03 03:41:46 +0000 | [diff] [blame] | 2366 | dest="emulate_svn_auto_props", |
| 2367 | help="Emulate Subversion's auto properties feature.") |
ukai@chromium.org | e807781 | 2012-02-03 03:41:46 +0000 | [diff] [blame] | 2368 | parser.add_option('-c', '--use-commit-queue', action='store_true', |
| 2369 | help='tell the commit queue to commit this patchset') |
tyoshino@chromium.org | c1737d0 | 2013-05-29 14:17:28 +0000 | [diff] [blame] | 2370 | parser.add_option('--private', action='store_true', |
| 2371 | help='set the review private (rietveld only)') |
ukai@chromium.org | 8ef7ab2 | 2012-11-28 04:24:52 +0000 | [diff] [blame] | 2372 | parser.add_option('--target_branch', |
pgervais@chromium.org | b9f2751 | 2014-08-08 15:52:33 +0000 | [diff] [blame] | 2373 | '--target-branch', |
wittman@chromium.org | 455dc92 | 2015-01-26 20:15:50 +0000 | [diff] [blame] | 2374 | metavar='TARGET', |
| 2375 | help='Apply CL to remote ref TARGET. ' + |
| 2376 | 'Default: remote branch head, or master') |
bauerb@chromium.org | 27386dd | 2015-02-16 10:45:39 +0000 | [diff] [blame] | 2377 | parser.add_option('--squash', action='store_true', |
| 2378 | help='Squash multiple commits into one (Gerrit only)') |
bauerb@chromium.org | 54b400c | 2016-01-14 10:08:25 +0000 | [diff] [blame] | 2379 | parser.add_option('--no-squash', action='store_true', |
| 2380 | help='Don\'t squash multiple commits into one ' + |
| 2381 | '(Gerrit only)') |
pgervais@chromium.org | 9114137 | 2014-01-09 23:27:20 +0000 | [diff] [blame] | 2382 | parser.add_option('--email', default=None, |
| 2383 | help='email address to use to connect to Rietveld') |
piman@chromium.org | 336f912 | 2014-09-04 02:16:55 +0000 | [diff] [blame] | 2384 | parser.add_option('--tbr-owners', dest='tbr_owners', action='store_true', |
| 2385 | help='add a set of OWNERS to TBR') |
tandrii@chromium.org | d50452a | 2015-11-23 16:38:15 +0000 | [diff] [blame] | 2386 | parser.add_option('-d', '--cq-dry-run', dest='cq_dry_run', |
| 2387 | action='store_true', |
rmistry@google.com | ef96622 | 2015-04-07 11:15:01 +0000 | [diff] [blame] | 2388 | help='Send the patchset to do a CQ dry run right after ' |
| 2389 | 'upload.') |
rmistry@google.com | 2dd9986 | 2015-06-22 12:22:18 +0000 | [diff] [blame] | 2390 | parser.add_option('--dependencies', action='store_true', |
| 2391 | help='Uploads CLs of all the local branches that depend on ' |
| 2392 | 'the current branch') |
pgervais@chromium.org | 9114137 | 2014-01-09 23:27:20 +0000 | [diff] [blame] | 2393 | |
rmistry@google.com | 2dd9986 | 2015-06-22 12:22:18 +0000 | [diff] [blame] | 2394 | orig_args = args |
iannucci@chromium.org | 53937ba | 2012-10-02 18:20:43 +0000 | [diff] [blame] | 2395 | add_git_similarity(parser) |
vadimsh@chromium.org | cf6a5d2 | 2015-04-09 22:02:00 +0000 | [diff] [blame] | 2396 | auth.add_auth_options(parser) |
ukai@chromium.org | e807781 | 2012-02-03 03:41:46 +0000 | [diff] [blame] | 2397 | (options, args) = parser.parse_args(args) |
vadimsh@chromium.org | cf6a5d2 | 2015-04-09 22:02:00 +0000 | [diff] [blame] | 2398 | auth_config = auth.extract_auth_config_from_options(options) |
ukai@chromium.org | e807781 | 2012-02-03 03:41:46 +0000 | [diff] [blame] | 2399 | |
sbc@chromium.org | 71437c0 | 2015-04-09 19:29:40 +0000 | [diff] [blame] | 2400 | if git_common.is_dirty_git_tree('upload'): |
ukai@chromium.org | e807781 | 2012-02-03 03:41:46 +0000 | [diff] [blame] | 2401 | return 1 |
| 2402 | |
maruel@chromium.org | eb52a5c | 2013-04-10 23:17:09 +0000 | [diff] [blame] | 2403 | options.reviewers = cleanup_list(options.reviewers) |
| 2404 | options.cc = cleanup_list(options.cc) |
| 2405 | |
vadimsh@chromium.org | cf6a5d2 | 2015-04-09 22:02:00 +0000 | [diff] [blame] | 2406 | cl = Changelist(auth_config=auth_config) |
ukai@chromium.org | e807781 | 2012-02-03 03:41:46 +0000 | [diff] [blame] | 2407 | if args: |
| 2408 | # TODO(ukai): is it ok for gerrit case? |
| 2409 | base_branch = args[0] |
| 2410 | else: |
luqui@chromium.org | 64e1436 | 2015-01-07 00:29:29 +0000 | [diff] [blame] | 2411 | if cl.GetBranch() is None: |
| 2412 | DieWithError('Can\'t upload from detached HEAD state. Get on a branch!') |
| 2413 | |
ilevy@chromium.org | 0f58fa8 | 2012-11-05 01:45:20 +0000 | [diff] [blame] | 2414 | # Default to diffing against common ancestor of upstream branch |
thestig@chromium.org | 8b0553c | 2014-02-11 00:33:37 +0000 | [diff] [blame] | 2415 | base_branch = cl.GetCommonAncestorWithUpstream() |
sbc@chromium.org | 5e07e06 | 2013-02-28 23:55:44 +0000 | [diff] [blame] | 2416 | args = [base_branch, 'HEAD'] |
ukai@chromium.org | e807781 | 2012-02-03 03:41:46 +0000 | [diff] [blame] | 2417 | |
vadimsh@chromium.org | eed4df3 | 2015-04-10 21:30:20 +0000 | [diff] [blame] | 2418 | # Make sure authenticated to Rietveld before running expensive hooks. It is |
| 2419 | # a fast, best efforts check. Rietveld still can reject the authentication |
| 2420 | # during the actual upload. |
| 2421 | if not settings.GetIsGerrit() and auth_config.use_oauth2: |
| 2422 | authenticator = auth.get_authenticator_for_host( |
| 2423 | cl.GetRietveldServer(), auth_config) |
| 2424 | if not authenticator.has_cached_credentials(): |
| 2425 | raise auth.LoginRequiredError(cl.GetRietveldServer()) |
| 2426 | |
ilevy@chromium.org | 051ad0e | 2013-03-04 21:57:34 +0000 | [diff] [blame] | 2427 | # Apply watchlists on upload. |
| 2428 | change = cl.GetChange(base_branch, None) |
| 2429 | watchlist = watchlists.Watchlists(change.RepositoryRoot()) |
| 2430 | files = [f.LocalPath() for f in change.AffectedFiles()] |
brettw@chromium.org | b65c43c | 2013-06-10 22:04:49 +0000 | [diff] [blame] | 2431 | if not options.bypass_watchlists: |
| 2432 | cl.SetWatchers(watchlist.GetWatchersForPaths(files)) |
ilevy@chromium.org | 051ad0e | 2013-03-04 21:57:34 +0000 | [diff] [blame] | 2433 | |
ukai@chromium.org | e807781 | 2012-02-03 03:41:46 +0000 | [diff] [blame] | 2434 | if not options.bypass_hooks: |
piman@chromium.org | 336f912 | 2014-09-04 02:16:55 +0000 | [diff] [blame] | 2435 | if options.reviewers or options.tbr_owners: |
isherman@chromium.org | b5cded6 | 2014-03-25 17:47:57 +0000 | [diff] [blame] | 2436 | # Set the reviewer list now so that presubmit checks can access it. |
| 2437 | change_description = ChangeDescription(change.FullDescriptionText()) |
piman@chromium.org | 336f912 | 2014-09-04 02:16:55 +0000 | [diff] [blame] | 2438 | change_description.update_reviewers(options.reviewers, |
| 2439 | options.tbr_owners, |
| 2440 | change) |
isherman@chromium.org | b5cded6 | 2014-03-25 17:47:57 +0000 | [diff] [blame] | 2441 | change.SetDescriptionText(change_description.description) |
ilevy@chromium.org | 051ad0e | 2013-03-04 21:57:34 +0000 | [diff] [blame] | 2442 | hook_results = cl.RunHook(committing=False, |
ukai@chromium.org | e807781 | 2012-02-03 03:41:46 +0000 | [diff] [blame] | 2443 | may_prompt=not options.force, |
| 2444 | verbose=options.verbose, |
ilevy@chromium.org | 051ad0e | 2013-03-04 21:57:34 +0000 | [diff] [blame] | 2445 | change=change) |
ukai@chromium.org | e807781 | 2012-02-03 03:41:46 +0000 | [diff] [blame] | 2446 | if not hook_results.should_continue(): |
| 2447 | return 1 |
| 2448 | if not options.reviewers and hook_results.reviewers: |
maruel@chromium.org | eb52a5c | 2013-04-10 23:17:09 +0000 | [diff] [blame] | 2449 | options.reviewers = hook_results.reviewers.split(',') |
ukai@chromium.org | e807781 | 2012-02-03 03:41:46 +0000 | [diff] [blame] | 2450 | |
koz@chromium.org | 5974d7a | 2013-04-02 20:50:37 +0000 | [diff] [blame] | 2451 | if cl.GetIssue(): |
maruel@chromium.org | 1033efd | 2013-07-23 23:25:09 +0000 | [diff] [blame] | 2452 | latest_patchset = cl.GetMostRecentPatchset() |
koz@chromium.org | 5974d7a | 2013-04-02 20:50:37 +0000 | [diff] [blame] | 2453 | local_patchset = cl.GetPatchset() |
dmikurube@chromium.org | 07d149f | 2013-04-03 11:40:23 +0000 | [diff] [blame] | 2454 | if latest_patchset and local_patchset and local_patchset != latest_patchset: |
koz@chromium.org | 5974d7a | 2013-04-02 20:50:37 +0000 | [diff] [blame] | 2455 | print ('The last upload made from this repository was patchset #%d but ' |
| 2456 | 'the most recent patchset on the server is #%d.' |
| 2457 | % (local_patchset, latest_patchset)) |
koz@chromium.org | c719278 | 2013-04-09 23:28:46 +0000 | [diff] [blame] | 2458 | print ('Uploading will still work, but if you\'ve uploaded to this issue ' |
| 2459 | 'from another machine or branch the patch you\'re uploading now ' |
| 2460 | 'might not include those changes.') |
koz@chromium.org | 5974d7a | 2013-04-02 20:50:37 +0000 | [diff] [blame] | 2461 | ask_for_data('About to upload; enter to confirm.') |
| 2462 | |
iannucci@chromium.org | 7954005 | 2012-10-19 23:15:26 +0000 | [diff] [blame] | 2463 | print_stats(options.similarity, options.find_copies, args) |
ukai@chromium.org | e807781 | 2012-02-03 03:41:46 +0000 | [diff] [blame] | 2464 | if settings.GetIsGerrit(): |
bauerb@chromium.org | 54b400c | 2016-01-14 10:08:25 +0000 | [diff] [blame] | 2465 | if options.squash and options.no_squash: |
| 2466 | DieWithError('Can only use one of --squash or --no-squash') |
| 2467 | |
| 2468 | options.squash = ((settings.GetSquashGerritUploads() or options.squash) and |
| 2469 | not options.no_squash) |
| 2470 | |
piman@chromium.org | 336f912 | 2014-09-04 02:16:55 +0000 | [diff] [blame] | 2471 | return GerritUpload(options, args, cl, change) |
| 2472 | ret = RietveldUpload(options, args, cl, change) |
rogerta@chromium.org | caa1655 | 2013-03-18 20:45:05 +0000 | [diff] [blame] | 2473 | if not ret: |
rogerta@chromium.org | 4a6cd04 | 2013-04-12 15:40:42 +0000 | [diff] [blame] | 2474 | git_set_branch_value('last-upload-hash', |
| 2475 | RunGit(['rev-parse', 'HEAD']).strip()) |
rmistry@google.com | 5626a92 | 2015-02-26 14:03:30 +0000 | [diff] [blame] | 2476 | # Run post upload hooks, if specified. |
| 2477 | if settings.GetRunPostUploadHook(): |
| 2478 | presubmit_support.DoPostUploadExecuter( |
| 2479 | change, |
| 2480 | cl, |
| 2481 | settings.GetRoot(), |
| 2482 | options.verbose, |
| 2483 | sys.stdout) |
rogerta@chromium.org | caa1655 | 2013-03-18 20:45:05 +0000 | [diff] [blame] | 2484 | |
rmistry@google.com | 2dd9986 | 2015-06-22 12:22:18 +0000 | [diff] [blame] | 2485 | # Upload all dependencies if specified. |
| 2486 | if options.dependencies: |
| 2487 | print |
| 2488 | print '--dependencies has been specified.' |
| 2489 | print 'All dependent local branches will be re-uploaded.' |
| 2490 | print |
| 2491 | # Remove the dependencies flag from args so that we do not end up in a |
| 2492 | # loop. |
| 2493 | orig_args.remove('--dependencies') |
| 2494 | upload_branch_deps(cl, orig_args) |
rogerta@chromium.org | caa1655 | 2013-03-18 20:45:05 +0000 | [diff] [blame] | 2495 | return ret |
ukai@chromium.org | e807781 | 2012-02-03 03:41:46 +0000 | [diff] [blame] | 2496 | |
| 2497 | |
szager@chromium.org | 9bb85e2 | 2012-06-13 20:28:23 +0000 | [diff] [blame] | 2498 | def IsSubmoduleMergeCommit(ref): |
| 2499 | # When submodules are added to the repo, we expect there to be a single |
| 2500 | # non-git-svn merge commit at remote HEAD with a signature comment. |
| 2501 | pattern = '^SVN changes up to revision [0-9]*$' |
szager@chromium.org | e84b754 | 2012-06-15 21:26:58 +0000 | [diff] [blame] | 2502 | cmd = ['rev-list', '--merges', '--grep=%s' % pattern, '%s^!' % ref] |
szager@chromium.org | 9bb85e2 | 2012-06-13 20:28:23 +0000 | [diff] [blame] | 2503 | return RunGit(cmd) != '' |
| 2504 | |
| 2505 | |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 2506 | def SendUpstream(parser, args, cmd): |
pgervais@chromium.org | cee6dc4 | 2014-05-07 17:04:03 +0000 | [diff] [blame] | 2507 | """Common code for CMDland and CmdDCommit |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 2508 | |
iannucci@chromium.org | 5724c96 | 2014-04-11 09:32:56 +0000 | [diff] [blame] | 2509 | Squashes branch into a single commit. |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 2510 | Updates changelog with metadata (e.g. pointer to review). |
| 2511 | Pushes/dcommits the code upstream. |
| 2512 | Updates review and closes. |
| 2513 | """ |
| 2514 | parser.add_option('--bypass-hooks', action='store_true', dest='bypass_hooks', |
| 2515 | help='bypass upload presubmit hook') |
| 2516 | parser.add_option('-m', dest='message', |
| 2517 | help="override review description") |
| 2518 | parser.add_option('-f', action='store_true', dest='force', |
| 2519 | help="force yes to questions (don't prompt)") |
| 2520 | parser.add_option('-c', dest='contributor', |
| 2521 | help="external contributor for patch (appended to " + |
| 2522 | "description and used as author for git). Should be " + |
| 2523 | "formatted as 'First Last <email@example.com>'") |
iannucci@chromium.org | 53937ba | 2012-10-02 18:20:43 +0000 | [diff] [blame] | 2524 | add_git_similarity(parser) |
vadimsh@chromium.org | cf6a5d2 | 2015-04-09 22:02:00 +0000 | [diff] [blame] | 2525 | auth.add_auth_options(parser) |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 2526 | (options, args) = parser.parse_args(args) |
vadimsh@chromium.org | cf6a5d2 | 2015-04-09 22:02:00 +0000 | [diff] [blame] | 2527 | auth_config = auth.extract_auth_config_from_options(options) |
| 2528 | |
| 2529 | cl = Changelist(auth_config=auth_config) |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 2530 | |
iannucci@chromium.org | 5724c96 | 2014-04-11 09:32:56 +0000 | [diff] [blame] | 2531 | current = cl.GetBranch() |
| 2532 | remote, upstream_branch = cl.FetchUpstreamTuple(cl.GetBranch()) |
| 2533 | if not settings.GetIsGitSvn() and remote == '.': |
| 2534 | print |
| 2535 | print 'Attempting to push branch %r into another local branch!' % current |
| 2536 | print |
| 2537 | print 'Either reparent this branch on top of origin/master:' |
| 2538 | print ' git reparent-branch --root' |
| 2539 | print |
| 2540 | print 'OR run `git rebase-update` if you think the parent branch is already' |
| 2541 | print 'committed.' |
| 2542 | print |
| 2543 | print ' Current parent: %r' % upstream_branch |
| 2544 | return 1 |
| 2545 | |
vadimsh@chromium.org | 566a02a | 2014-08-22 01:34:13 +0000 | [diff] [blame] | 2546 | if not args or cmd == 'land': |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 2547 | # Default to merging against our best guess of the upstream branch. |
| 2548 | args = [cl.GetUpstreamBranch()] |
| 2549 | |
maruel@chromium.org | 13f623c | 2011-07-22 16:02:23 +0000 | [diff] [blame] | 2550 | if options.contributor: |
| 2551 | if not re.match('^.*\s<\S+@\S+>$', options.contributor): |
| 2552 | print "Please provide contibutor as 'First Last <email@example.com>'" |
| 2553 | return 1 |
| 2554 | |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 2555 | base_branch = args[0] |
szager@chromium.org | 9bb85e2 | 2012-06-13 20:28:23 +0000 | [diff] [blame] | 2556 | base_has_submodules = IsSubmoduleMergeCommit(base_branch) |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 2557 | |
sbc@chromium.org | 71437c0 | 2015-04-09 19:29:40 +0000 | [diff] [blame] | 2558 | if git_common.is_dirty_git_tree(cmd): |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 2559 | return 1 |
| 2560 | |
| 2561 | # This rev-list syntax means "show all commits not in my branch that |
| 2562 | # are in base_branch". |
| 2563 | upstream_commits = RunGit(['rev-list', '^' + cl.GetBranchRef(), |
| 2564 | base_branch]).splitlines() |
| 2565 | if upstream_commits: |
| 2566 | print ('Base branch "%s" has %d commits ' |
| 2567 | 'not in this branch.' % (base_branch, len(upstream_commits))) |
| 2568 | print 'Run "git merge %s" before attempting to %s.' % (base_branch, cmd) |
| 2569 | return 1 |
| 2570 | |
szager@chromium.org | 9bb85e2 | 2012-06-13 20:28:23 +0000 | [diff] [blame] | 2571 | # This is the revision `svn dcommit` will commit on top of. |
vadimsh@chromium.org | 566a02a | 2014-08-22 01:34:13 +0000 | [diff] [blame] | 2572 | svn_head = None |
| 2573 | if cmd == 'dcommit' or base_has_submodules: |
| 2574 | svn_head = RunGit(['log', '--grep=^git-svn-id:', '-1', |
| 2575 | '--pretty=format:%H']) |
szager@chromium.org | 9bb85e2 | 2012-06-13 20:28:23 +0000 | [diff] [blame] | 2576 | |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 2577 | if cmd == 'dcommit': |
szager@chromium.org | 9bb85e2 | 2012-06-13 20:28:23 +0000 | [diff] [blame] | 2578 | # If the base_head is a submodule merge commit, the first parent of the |
| 2579 | # base_head should be a git-svn commit, which is what we're interested in. |
| 2580 | base_svn_head = base_branch |
| 2581 | if base_has_submodules: |
| 2582 | base_svn_head += '^1' |
| 2583 | |
| 2584 | extra_commits = RunGit(['rev-list', '^' + svn_head, base_svn_head]) |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 2585 | if extra_commits: |
| 2586 | print ('This branch has %d additional commits not upstreamed yet.' |
| 2587 | % len(extra_commits.splitlines())) |
| 2588 | print ('Upstream "%s" or rebase this branch on top of the upstream trunk ' |
| 2589 | 'before attempting to %s.' % (base_branch, cmd)) |
| 2590 | return 1 |
| 2591 | |
iannucci@chromium.org | e6896b5 | 2014-08-29 01:38:03 +0000 | [diff] [blame] | 2592 | merge_base = RunGit(['merge-base', base_branch, 'HEAD']).strip() |
maruel@chromium.org | b0a6391 | 2012-01-17 18:10:16 +0000 | [diff] [blame] | 2593 | if not options.bypass_hooks: |
maruel@chromium.org | 13f623c | 2011-07-22 16:02:23 +0000 | [diff] [blame] | 2594 | author = None |
| 2595 | if options.contributor: |
| 2596 | author = re.search(r'\<(.*)\>', options.contributor).group(1) |
maruel@chromium.org | b0a6391 | 2012-01-17 18:10:16 +0000 | [diff] [blame] | 2597 | hook_results = cl.RunHook( |
| 2598 | committing=True, |
maruel@chromium.org | b0a6391 | 2012-01-17 18:10:16 +0000 | [diff] [blame] | 2599 | may_prompt=not options.force, |
| 2600 | verbose=options.verbose, |
iannucci@chromium.org | e6896b5 | 2014-08-29 01:38:03 +0000 | [diff] [blame] | 2601 | change=cl.GetChange(merge_base, author)) |
maruel@chromium.org | b0a6391 | 2012-01-17 18:10:16 +0000 | [diff] [blame] | 2602 | if not hook_results.should_continue(): |
| 2603 | return 1 |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 2604 | |
vadimsh@chromium.org | 566a02a | 2014-08-22 01:34:13 +0000 | [diff] [blame] | 2605 | # Check the tree status if the tree status URL is set. |
| 2606 | status = GetTreeStatus() |
| 2607 | if 'closed' == status: |
| 2608 | print('The tree is closed. Please wait for it to reopen. Use ' |
| 2609 | '"git cl %s --bypass-hooks" to commit on a closed tree.' % cmd) |
| 2610 | return 1 |
| 2611 | elif 'unknown' == status: |
| 2612 | print('Unable to determine tree status. Please verify manually and ' |
| 2613 | 'use "git cl %s --bypass-hooks" to commit on a closed tree.' % cmd) |
| 2614 | return 1 |
maruel@chromium.org | ac63715 | 2012-01-16 14:19:54 +0000 | [diff] [blame] | 2615 | else: |
| 2616 | breakpad.SendStack( |
| 2617 | 'GitClHooksBypassedCommit', |
jochen@chromium.org | 3ec0d54 | 2014-01-14 20:00:03 +0000 | [diff] [blame] | 2618 | 'Issue %s/%s bypassed hook when committing (tree status was "%s")' % |
| 2619 | (cl.GetRietveldServer(), cl.GetIssue(), GetTreeStatus()), |
maruel@chromium.org | 2e72bb1 | 2012-01-17 15:18:35 +0000 | [diff] [blame] | 2620 | verbose=False) |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 2621 | |
maruel@chromium.org | 78936cb | 2013-04-11 00:17:52 +0000 | [diff] [blame] | 2622 | change_desc = ChangeDescription(options.message) |
| 2623 | if not change_desc.description and cl.GetIssue(): |
| 2624 | change_desc = ChangeDescription(cl.GetDescription()) |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 2625 | |
maruel@chromium.org | 78936cb | 2013-04-11 00:17:52 +0000 | [diff] [blame] | 2626 | if not change_desc.description: |
erg@chromium.org | 1a17398 | 2012-08-29 20:43:05 +0000 | [diff] [blame] | 2627 | if not cl.GetIssue() and options.bypass_hooks: |
iannucci@chromium.org | e6896b5 | 2014-08-29 01:38:03 +0000 | [diff] [blame] | 2628 | change_desc = ChangeDescription(CreateDescriptionFromLog([merge_base])) |
erg@chromium.org | 1a17398 | 2012-08-29 20:43:05 +0000 | [diff] [blame] | 2629 | else: |
| 2630 | print 'No description set.' |
| 2631 | print 'Visit %s/edit to set it.' % (cl.GetIssueURL()) |
| 2632 | return 1 |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 2633 | |
maruel@chromium.org | 78936cb | 2013-04-11 00:17:52 +0000 | [diff] [blame] | 2634 | # Keep a separate copy for the commit message, because the commit message |
| 2635 | # contains the link to the Rietveld issue, while the Rietveld message contains |
| 2636 | # the commit viewvc url. |
maruel@chromium.org | e52678e | 2013-04-26 18:34:44 +0000 | [diff] [blame] | 2637 | # Keep a separate copy for the commit message. |
| 2638 | if cl.GetIssue(): |
maruel@chromium.org | cf08778 | 2013-07-23 13:08:48 +0000 | [diff] [blame] | 2639 | change_desc.update_reviewers(cl.GetApprovingReviewers()) |
maruel@chromium.org | e52678e | 2013-04-26 18:34:44 +0000 | [diff] [blame] | 2640 | |
maruel@chromium.org | 78936cb | 2013-04-11 00:17:52 +0000 | [diff] [blame] | 2641 | commit_desc = ChangeDescription(change_desc.description) |
maruel@chromium.org | cc73ad6 | 2011-07-06 17:39:26 +0000 | [diff] [blame] | 2642 | if cl.GetIssue(): |
smut@google.com | 4c61dcc | 2015-06-08 22:31:29 +0000 | [diff] [blame] | 2643 | # Xcode won't linkify this URL unless there is a non-whitespace character |
sergiyb@chromium.org | 4b39c5f | 2015-07-07 10:33:12 +0000 | [diff] [blame] | 2644 | # after it. Add a period on a new line to circumvent this. Also add a space |
| 2645 | # before the period to make sure that Gitiles continues to correctly resolve |
| 2646 | # the URL. |
| 2647 | commit_desc.append_footer('Review URL: %s .' % cl.GetIssueURL()) |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 2648 | if options.contributor: |
maruel@chromium.org | 78936cb | 2013-04-11 00:17:52 +0000 | [diff] [blame] | 2649 | commit_desc.append_footer('Patch from %s.' % options.contributor) |
| 2650 | |
agable@chromium.org | eec3ea3 | 2013-08-15 20:31:39 +0000 | [diff] [blame] | 2651 | print('Description:') |
| 2652 | print(commit_desc.description) |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 2653 | |
iannucci@chromium.org | e6896b5 | 2014-08-29 01:38:03 +0000 | [diff] [blame] | 2654 | branches = [merge_base, cl.GetBranchRef()] |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 2655 | if not options.force: |
iannucci@chromium.org | 7954005 | 2012-10-19 23:15:26 +0000 | [diff] [blame] | 2656 | print_stats(options.similarity, options.find_copies, branches) |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 2657 | |
szager@chromium.org | 9bb85e2 | 2012-06-13 20:28:23 +0000 | [diff] [blame] | 2658 | # We want to squash all this branch's commits into one commit with the proper |
| 2659 | # description. We do this by doing a "reset --soft" to the base branch (which |
| 2660 | # keeps the working copy the same), then dcommitting that. If origin/master |
| 2661 | # has a submodule merge commit, we'll also need to cherry-pick the squashed |
| 2662 | # commit onto a branch based on the git-svn head. |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 2663 | MERGE_BRANCH = 'git-cl-commit' |
szager@chromium.org | 9bb85e2 | 2012-06-13 20:28:23 +0000 | [diff] [blame] | 2664 | CHERRY_PICK_BRANCH = 'git-cl-cherry-pick' |
| 2665 | # Delete the branches if they exist. |
| 2666 | for branch in [MERGE_BRANCH, CHERRY_PICK_BRANCH]: |
| 2667 | showref_cmd = ['show-ref', '--quiet', '--verify', 'refs/heads/%s' % branch] |
| 2668 | result = RunGitWithCode(showref_cmd) |
| 2669 | if result[0] == 0: |
| 2670 | RunGit(['branch', '-D', branch]) |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 2671 | |
| 2672 | # We might be in a directory that's present in this branch but not in the |
| 2673 | # trunk. Move up to the top of the tree so that git commands that expect a |
| 2674 | # valid CWD won't fail after we check out the merge branch. |
thestig@chromium.org | 8b0553c | 2014-02-11 00:33:37 +0000 | [diff] [blame] | 2675 | rel_base_path = settings.GetRelativeRoot() |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 2676 | if rel_base_path: |
| 2677 | os.chdir(rel_base_path) |
| 2678 | |
| 2679 | # Stuff our change into the merge branch. |
| 2680 | # We wrap in a try...finally block so if anything goes wrong, |
| 2681 | # we clean up the branches. |
maruel@chromium.org | 0ba7f96 | 2011-01-11 22:13:58 +0000 | [diff] [blame] | 2682 | retcode = -1 |
iannucci@chromium.org | e6896b5 | 2014-08-29 01:38:03 +0000 | [diff] [blame] | 2683 | pushed_to_pending = False |
vadimsh@chromium.org | 566a02a | 2014-08-22 01:34:13 +0000 | [diff] [blame] | 2684 | pending_ref = None |
iannucci@chromium.org | e6896b5 | 2014-08-29 01:38:03 +0000 | [diff] [blame] | 2685 | revision = None |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 2686 | try: |
bauerb@chromium.org | b4a75c4 | 2011-03-08 08:35:38 +0000 | [diff] [blame] | 2687 | RunGit(['checkout', '-q', '-b', MERGE_BRANCH]) |
iannucci@chromium.org | e6896b5 | 2014-08-29 01:38:03 +0000 | [diff] [blame] | 2688 | RunGit(['reset', '--soft', merge_base]) |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 2689 | if options.contributor: |
maruel@chromium.org | 78936cb | 2013-04-11 00:17:52 +0000 | [diff] [blame] | 2690 | RunGit( |
| 2691 | [ |
| 2692 | 'commit', '--author', options.contributor, |
| 2693 | '-m', commit_desc.description, |
| 2694 | ]) |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 2695 | else: |
maruel@chromium.org | 78936cb | 2013-04-11 00:17:52 +0000 | [diff] [blame] | 2696 | RunGit(['commit', '-m', commit_desc.description]) |
szager@chromium.org | 9bb85e2 | 2012-06-13 20:28:23 +0000 | [diff] [blame] | 2697 | if base_has_submodules: |
| 2698 | cherry_pick_commit = RunGit(['rev-list', 'HEAD^!']).rstrip() |
| 2699 | RunGit(['branch', CHERRY_PICK_BRANCH, svn_head]) |
| 2700 | RunGit(['checkout', CHERRY_PICK_BRANCH]) |
| 2701 | RunGit(['cherry-pick', cherry_pick_commit]) |
vadimsh@chromium.org | 566a02a | 2014-08-22 01:34:13 +0000 | [diff] [blame] | 2702 | if cmd == 'land': |
ilevy@chromium.org | 0f58fa8 | 2012-11-05 01:45:20 +0000 | [diff] [blame] | 2703 | remote, branch = cl.FetchUpstreamTuple(cl.GetBranch()) |
vadimsh@chromium.org | 566a02a | 2014-08-22 01:34:13 +0000 | [diff] [blame] | 2704 | pending_prefix = settings.GetPendingRefPrefix() |
| 2705 | if not pending_prefix or branch.startswith(pending_prefix): |
| 2706 | # If not using refs/pending/heads/* at all, or target ref is already set |
| 2707 | # to pending, then push to the target ref directly. |
| 2708 | retcode, output = RunGitWithCode( |
| 2709 | ['push', '--porcelain', remote, 'HEAD:%s' % branch]) |
iannucci@chromium.org | e6896b5 | 2014-08-29 01:38:03 +0000 | [diff] [blame] | 2710 | pushed_to_pending = pending_prefix and branch.startswith(pending_prefix) |
vadimsh@chromium.org | 566a02a | 2014-08-22 01:34:13 +0000 | [diff] [blame] | 2711 | else: |
| 2712 | # Cherry-pick the change on top of pending ref and then push it. |
| 2713 | assert branch.startswith('refs/'), branch |
| 2714 | assert pending_prefix[-1] == '/', pending_prefix |
| 2715 | pending_ref = pending_prefix + branch[len('refs/'):] |
| 2716 | retcode, output = PushToGitPending(remote, pending_ref, branch) |
iannucci@chromium.org | e6896b5 | 2014-08-29 01:38:03 +0000 | [diff] [blame] | 2717 | pushed_to_pending = (retcode == 0) |
iannucci@chromium.org | 34504a1 | 2014-08-29 23:51:37 +0000 | [diff] [blame] | 2718 | if retcode == 0: |
| 2719 | revision = RunGit(['rev-parse', 'HEAD']).strip() |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 2720 | else: |
| 2721 | # dcommit the merge branch. |
iannucci@chromium.org | a1950c4 | 2014-12-05 22:15:56 +0000 | [diff] [blame] | 2722 | cmd_args = [ |
kjellander@chromium.org | 6abc652 | 2014-12-02 07:34:49 +0000 | [diff] [blame] | 2723 | 'svn', 'dcommit', |
| 2724 | '-C%s' % options.similarity, |
| 2725 | '--no-rebase', '--rmdir', |
| 2726 | ] |
| 2727 | if settings.GetForceHttpsCommitUrl(): |
| 2728 | # Allow forcing https commit URLs for some projects that don't allow |
| 2729 | # committing to http URLs (like Google Code). |
| 2730 | remote_url = cl.GetGitSvnRemoteUrl() |
| 2731 | if urlparse.urlparse(remote_url).scheme == 'http': |
| 2732 | remote_url = remote_url.replace('http://', 'https://') |
iannucci@chromium.org | a1950c4 | 2014-12-05 22:15:56 +0000 | [diff] [blame] | 2733 | cmd_args.append('--commit-url=%s' % remote_url) |
| 2734 | _, output = RunGitWithCode(cmd_args) |
iannucci@chromium.org | 34504a1 | 2014-08-29 23:51:37 +0000 | [diff] [blame] | 2735 | if 'Committed r' in output: |
| 2736 | revision = re.match( |
| 2737 | '.*?\nCommitted r(\\d+)', output, re.DOTALL).group(1) |
| 2738 | logging.debug(output) |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 2739 | finally: |
| 2740 | # And then swap back to the original branch and clean up. |
| 2741 | RunGit(['checkout', '-q', cl.GetBranch()]) |
| 2742 | RunGit(['branch', '-D', MERGE_BRANCH]) |
szager@chromium.org | 9bb85e2 | 2012-06-13 20:28:23 +0000 | [diff] [blame] | 2743 | if base_has_submodules: |
| 2744 | RunGit(['branch', '-D', CHERRY_PICK_BRANCH]) |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 2745 | |
iannucci@chromium.org | 34504a1 | 2014-08-29 23:51:37 +0000 | [diff] [blame] | 2746 | if not revision: |
iannucci@chromium.org | 6c217b1 | 2014-08-29 22:10:59 +0000 | [diff] [blame] | 2747 | print 'Failed to push. If this persists, please file a bug.' |
iannucci@chromium.org | 34504a1 | 2014-08-29 23:51:37 +0000 | [diff] [blame] | 2748 | return 1 |
iannucci@chromium.org | 6c217b1 | 2014-08-29 22:10:59 +0000 | [diff] [blame] | 2749 | |
iannucci@chromium.org | bbe9cc5 | 2014-09-05 18:25:51 +0000 | [diff] [blame] | 2750 | killed = False |
iannucci@chromium.org | 6c217b1 | 2014-08-29 22:10:59 +0000 | [diff] [blame] | 2751 | if pushed_to_pending: |
iannucci@chromium.org | e6896b5 | 2014-08-29 01:38:03 +0000 | [diff] [blame] | 2752 | try: |
| 2753 | revision = WaitForRealCommit(remote, revision, base_branch, branch) |
| 2754 | # We set pushed_to_pending to False, since it made it all the way to the |
| 2755 | # real ref. |
| 2756 | pushed_to_pending = False |
| 2757 | except KeyboardInterrupt: |
iannucci@chromium.org | bbe9cc5 | 2014-09-05 18:25:51 +0000 | [diff] [blame] | 2758 | killed = True |
iannucci@chromium.org | e6896b5 | 2014-08-29 01:38:03 +0000 | [diff] [blame] | 2759 | |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 2760 | if cl.GetIssue(): |
iannucci@chromium.org | e6896b5 | 2014-08-29 01:38:03 +0000 | [diff] [blame] | 2761 | to_pending = ' to pending queue' if pushed_to_pending else '' |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 2762 | viewvc_url = settings.GetViewVCUrl() |
iannucci@chromium.org | e6896b5 | 2014-08-29 01:38:03 +0000 | [diff] [blame] | 2763 | if not to_pending: |
| 2764 | if viewvc_url and revision: |
| 2765 | change_desc.append_footer( |
| 2766 | 'Committed: %s%s' % (viewvc_url, revision)) |
| 2767 | elif revision: |
| 2768 | change_desc.append_footer('Committed: %s' % (revision,)) |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 2769 | print ('Closing issue ' |
| 2770 | '(you may be prompted for your codereview password)...') |
maruel@chromium.org | 78936cb | 2013-04-11 00:17:52 +0000 | [diff] [blame] | 2771 | cl.UpdateDescription(change_desc.description) |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 2772 | cl.CloseIssue() |
maruel@chromium.org | 1033efd | 2013-07-23 23:25:09 +0000 | [diff] [blame] | 2773 | props = cl.GetIssueProperties() |
sadrul@chromium.org | 34b5d82 | 2013-02-18 01:39:24 +0000 | [diff] [blame] | 2774 | patch_num = len(props['patchsets']) |
rmistry@google.com | 52d224a | 2014-08-27 14:44:41 +0000 | [diff] [blame] | 2775 | comment = "Committed patchset #%d (id:%d)%s manually as %s" % ( |
mark@chromium.org | 782570c | 2014-09-26 21:48:02 +0000 | [diff] [blame] | 2776 | patch_num, props['patchsets'][-1], to_pending, revision) |
jochen@chromium.org | 3ec0d54 | 2014-01-14 20:00:03 +0000 | [diff] [blame] | 2777 | if options.bypass_hooks: |
| 2778 | comment += ' (tree was closed).' if GetTreeStatus() == 'closed' else '.' |
| 2779 | else: |
| 2780 | comment += ' (presubmit successful).' |
iannucci@chromium.org | b85a316 | 2013-01-26 01:11:13 +0000 | [diff] [blame] | 2781 | cl.RpcServer().add_comment(cl.GetIssue(), comment) |
maruel@chromium.org | 1033efd | 2013-07-23 23:25:09 +0000 | [diff] [blame] | 2782 | cl.SetIssue(None) |
maruel@chromium.org | 0ba7f96 | 2011-01-11 22:13:58 +0000 | [diff] [blame] | 2783 | |
iannucci@chromium.org | 6c217b1 | 2014-08-29 22:10:59 +0000 | [diff] [blame] | 2784 | if pushed_to_pending: |
vadimsh@chromium.org | 566a02a | 2014-08-22 01:34:13 +0000 | [diff] [blame] | 2785 | _, branch = cl.FetchUpstreamTuple(cl.GetBranch()) |
| 2786 | print 'The commit is in the pending queue (%s).' % pending_ref |
| 2787 | print ( |
thakis@chromium.org | 5f32a96 | 2014-09-05 21:33:23 +0000 | [diff] [blame] | 2788 | 'It will show up on %s in ~1 min, once it gets a Cr-Commit-Position ' |
vadimsh@chromium.org | 566a02a | 2014-08-22 01:34:13 +0000 | [diff] [blame] | 2789 | 'footer.' % branch) |
| 2790 | |
iannucci@chromium.org | 6c217b1 | 2014-08-29 22:10:59 +0000 | [diff] [blame] | 2791 | hook = POSTUPSTREAM_HOOK_PATTERN % cmd |
| 2792 | if os.path.isfile(hook): |
| 2793 | RunCommand([hook, merge_base], error_ok=True) |
maruel@chromium.org | 0ba7f96 | 2011-01-11 22:13:58 +0000 | [diff] [blame] | 2794 | |
iannucci@chromium.org | bbe9cc5 | 2014-09-05 18:25:51 +0000 | [diff] [blame] | 2795 | return 1 if killed else 0 |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 2796 | |
| 2797 | |
iannucci@chromium.org | e6896b5 | 2014-08-29 01:38:03 +0000 | [diff] [blame] | 2798 | def WaitForRealCommit(remote, pushed_commit, local_base_ref, real_ref): |
| 2799 | print |
| 2800 | print 'Waiting for commit to be landed on %s...' % real_ref |
| 2801 | print '(If you are impatient, you may Ctrl-C once without harm)' |
| 2802 | target_tree = RunGit(['rev-parse', '%s:' % pushed_commit]).strip() |
| 2803 | current_rev = RunGit(['rev-parse', local_base_ref]).strip() |
| 2804 | |
| 2805 | loop = 0 |
| 2806 | while True: |
| 2807 | sys.stdout.write('fetching (%d)... \r' % loop) |
| 2808 | sys.stdout.flush() |
| 2809 | loop += 1 |
| 2810 | |
| 2811 | RunGit(['retry', 'fetch', remote, real_ref], stderr=subprocess2.VOID) |
| 2812 | to_rev = RunGit(['rev-parse', 'FETCH_HEAD']).strip() |
| 2813 | commits = RunGit(['rev-list', '%s..%s' % (current_rev, to_rev)]) |
| 2814 | for commit in commits.splitlines(): |
| 2815 | if RunGit(['rev-parse', '%s:' % commit]).strip() == target_tree: |
| 2816 | print 'Found commit on %s' % real_ref |
| 2817 | return commit |
| 2818 | |
| 2819 | current_rev = to_rev |
| 2820 | |
| 2821 | |
vadimsh@chromium.org | 566a02a | 2014-08-22 01:34:13 +0000 | [diff] [blame] | 2822 | def PushToGitPending(remote, pending_ref, upstream_ref): |
| 2823 | """Fetches pending_ref, cherry-picks current HEAD on top of it, pushes. |
| 2824 | |
| 2825 | Returns: |
| 2826 | (retcode of last operation, output log of last operation). |
| 2827 | """ |
| 2828 | assert pending_ref.startswith('refs/'), pending_ref |
| 2829 | local_pending_ref = 'refs/git-cl/' + pending_ref[len('refs/'):] |
| 2830 | cherry = RunGit(['rev-parse', 'HEAD']).strip() |
| 2831 | code = 0 |
| 2832 | out = '' |
vadimsh@chromium.org | 749fbd9 | 2014-08-26 21:57:53 +0000 | [diff] [blame] | 2833 | max_attempts = 3 |
| 2834 | attempts_left = max_attempts |
| 2835 | while attempts_left: |
| 2836 | if attempts_left != max_attempts: |
| 2837 | print 'Retrying, %d attempts left...' % (attempts_left - 1,) |
| 2838 | attempts_left -= 1 |
vadimsh@chromium.org | 566a02a | 2014-08-22 01:34:13 +0000 | [diff] [blame] | 2839 | |
| 2840 | # Fetch. Retry fetch errors. |
vadimsh@chromium.org | 749fbd9 | 2014-08-26 21:57:53 +0000 | [diff] [blame] | 2841 | print 'Fetching pending ref %s...' % pending_ref |
vadimsh@chromium.org | 566a02a | 2014-08-22 01:34:13 +0000 | [diff] [blame] | 2842 | code, out = RunGitWithCode( |
vadimsh@chromium.org | 749fbd9 | 2014-08-26 21:57:53 +0000 | [diff] [blame] | 2843 | ['retry', 'fetch', remote, '+%s:%s' % (pending_ref, local_pending_ref)]) |
vadimsh@chromium.org | 566a02a | 2014-08-22 01:34:13 +0000 | [diff] [blame] | 2844 | if code: |
vadimsh@chromium.org | 749fbd9 | 2014-08-26 21:57:53 +0000 | [diff] [blame] | 2845 | print 'Fetch failed with exit code %d.' % code |
| 2846 | if out.strip(): |
| 2847 | print out.strip() |
vadimsh@chromium.org | 566a02a | 2014-08-22 01:34:13 +0000 | [diff] [blame] | 2848 | continue |
| 2849 | |
| 2850 | # Try to cherry pick. Abort on merge conflicts. |
vadimsh@chromium.org | 749fbd9 | 2014-08-26 21:57:53 +0000 | [diff] [blame] | 2851 | print 'Cherry-picking commit on top of pending ref...' |
vadimsh@chromium.org | 566a02a | 2014-08-22 01:34:13 +0000 | [diff] [blame] | 2852 | RunGitWithCode(['checkout', local_pending_ref], suppress_stderr=True) |
vadimsh@chromium.org | 749fbd9 | 2014-08-26 21:57:53 +0000 | [diff] [blame] | 2853 | code, out = RunGitWithCode(['cherry-pick', cherry]) |
vadimsh@chromium.org | 566a02a | 2014-08-22 01:34:13 +0000 | [diff] [blame] | 2854 | if code: |
| 2855 | print ( |
vadimsh@chromium.org | 749fbd9 | 2014-08-26 21:57:53 +0000 | [diff] [blame] | 2856 | 'Your patch doesn\'t apply cleanly to ref \'%s\', ' |
| 2857 | 'the following files have merge conflicts:' % pending_ref) |
vadimsh@chromium.org | 566a02a | 2014-08-22 01:34:13 +0000 | [diff] [blame] | 2858 | print RunGit(['diff', '--name-status', '--diff-filter=U']).strip() |
| 2859 | print 'Please rebase your patch and try again.' |
vadimsh@chromium.org | 749fbd9 | 2014-08-26 21:57:53 +0000 | [diff] [blame] | 2860 | RunGitWithCode(['cherry-pick', '--abort']) |
vadimsh@chromium.org | 566a02a | 2014-08-22 01:34:13 +0000 | [diff] [blame] | 2861 | return code, out |
| 2862 | |
| 2863 | # Applied cleanly, try to push now. Retry on error (flake or non-ff push). |
vadimsh@chromium.org | 749fbd9 | 2014-08-26 21:57:53 +0000 | [diff] [blame] | 2864 | print 'Pushing commit to %s... It can take a while.' % pending_ref |
vadimsh@chromium.org | 566a02a | 2014-08-22 01:34:13 +0000 | [diff] [blame] | 2865 | code, out = RunGitWithCode( |
| 2866 | ['retry', 'push', '--porcelain', remote, 'HEAD:%s' % pending_ref]) |
| 2867 | if code == 0: |
| 2868 | # Success. |
iannucci@chromium.org | e6896b5 | 2014-08-29 01:38:03 +0000 | [diff] [blame] | 2869 | print 'Commit pushed to pending ref successfully!' |
vadimsh@chromium.org | 566a02a | 2014-08-22 01:34:13 +0000 | [diff] [blame] | 2870 | return code, out |
| 2871 | |
vadimsh@chromium.org | 749fbd9 | 2014-08-26 21:57:53 +0000 | [diff] [blame] | 2872 | print 'Push failed with exit code %d.' % code |
| 2873 | if out.strip(): |
| 2874 | print out.strip() |
| 2875 | if IsFatalPushFailure(out): |
| 2876 | print ( |
| 2877 | 'Fatal push error. Make sure your .netrc credentials and git ' |
| 2878 | 'user.email are correct and you have push access to the repo.') |
| 2879 | return code, out |
| 2880 | |
| 2881 | print 'All attempts to push to pending ref failed.' |
vadimsh@chromium.org | 566a02a | 2014-08-22 01:34:13 +0000 | [diff] [blame] | 2882 | return code, out |
| 2883 | |
| 2884 | |
vadimsh@chromium.org | 749fbd9 | 2014-08-26 21:57:53 +0000 | [diff] [blame] | 2885 | def IsFatalPushFailure(push_stdout): |
| 2886 | """True if retrying push won't help.""" |
| 2887 | return '(prohibited by Gerrit)' in push_stdout |
| 2888 | |
| 2889 | |
maruel@chromium.org | 0633fb4 | 2013-08-16 20:06:14 +0000 | [diff] [blame] | 2890 | @subcommand.usage('[upstream branch to apply against]') |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 2891 | def CMDdcommit(parser, args): |
iannucci@chromium.org | d9c1b20 | 2013-07-24 23:52:11 +0000 | [diff] [blame] | 2892 | """Commits the current changelist via git-svn.""" |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 2893 | if not settings.GetIsGitSvn(): |
mmoss@chromium.org | f0e4152 | 2015-06-10 19:52:01 +0000 | [diff] [blame] | 2894 | if get_footer_svn_id(): |
| 2895 | # If it looks like previous commits were mirrored with git-svn. |
| 2896 | message = """This repository appears to be a git-svn mirror, but no |
| 2897 | upstream SVN master is set. You probably need to run 'git auto-svn' once.""" |
| 2898 | else: |
| 2899 | message = """This doesn't appear to be an SVN repository. |
| 2900 | If your project has a true, writeable git repository, you probably want to run |
| 2901 | 'git cl land' instead. |
| 2902 | If your project has a git mirror of an upstream SVN master, you probably need |
| 2903 | to run 'git svn init'. |
| 2904 | |
| 2905 | Using the wrong command might cause your commit to appear to succeed, and the |
| 2906 | review to be closed, without actually landing upstream. If you choose to |
| 2907 | proceed, please verify that the commit lands upstream as expected.""" |
thakis@chromium.org | cde3bb6 | 2011-01-20 01:16:14 +0000 | [diff] [blame] | 2908 | print(message) |
maruel@chromium.org | 9054173 | 2011-04-01 17:54:18 +0000 | [diff] [blame] | 2909 | ask_for_data('[Press enter to dcommit or ctrl-C to quit]') |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 2910 | return SendUpstream(parser, args, 'dcommit') |
| 2911 | |
| 2912 | |
maruel@chromium.org | 0633fb4 | 2013-08-16 20:06:14 +0000 | [diff] [blame] | 2913 | @subcommand.usage('[upstream branch to apply against]') |
pgervais@chromium.org | cee6dc4 | 2014-05-07 17:04:03 +0000 | [diff] [blame] | 2914 | def CMDland(parser, args): |
iannucci@chromium.org | d9c1b20 | 2013-07-24 23:52:11 +0000 | [diff] [blame] | 2915 | """Commits the current changelist via git.""" |
mmoss@chromium.org | f0e4152 | 2015-06-10 19:52:01 +0000 | [diff] [blame] | 2916 | if settings.GetIsGitSvn() or get_footer_svn_id(): |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 2917 | print('This appears to be an SVN repository.') |
| 2918 | print('Are you sure you didn\'t mean \'git cl dcommit\'?') |
mmoss@chromium.org | f0e4152 | 2015-06-10 19:52:01 +0000 | [diff] [blame] | 2919 | print('(Ignore if this is the first commit after migrating from svn->git)') |
maruel@chromium.org | 9054173 | 2011-04-01 17:54:18 +0000 | [diff] [blame] | 2920 | ask_for_data('[Press enter to push or ctrl-C to quit]') |
vadimsh@chromium.org | 566a02a | 2014-08-22 01:34:13 +0000 | [diff] [blame] | 2921 | return SendUpstream(parser, args, 'land') |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 2922 | |
| 2923 | |
dsinclair@chromium.org | fbed656 | 2015-09-25 21:22:36 +0000 | [diff] [blame] | 2924 | def ParseIssueNum(arg): |
| 2925 | """Parses the issue number from args if present otherwise returns None.""" |
| 2926 | if re.match(r'\d+', arg): |
| 2927 | return arg |
| 2928 | if arg.startswith('http'): |
| 2929 | return re.sub(r'.*/(\d+)/?', r'\1', arg) |
| 2930 | return None |
| 2931 | |
| 2932 | |
| 2933 | @subcommand.usage('<patch url or issue id or issue url>') |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 2934 | def CMDpatch(parser, args): |
marq@chromium.org | e5e5900 | 2013-10-02 23:21:25 +0000 | [diff] [blame] | 2935 | """Patches in a code review.""" |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 2936 | parser.add_option('-b', dest='newbranch', |
| 2937 | help='create a new branch off trunk for the patch') |
qsr@chromium.org | 1ef44af | 2013-10-16 16:24:32 +0000 | [diff] [blame] | 2938 | parser.add_option('-f', '--force', action='store_true', |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 2939 | help='with -b, clobber any existing branch') |
qsr@chromium.org | 1ef44af | 2013-10-16 16:24:32 +0000 | [diff] [blame] | 2940 | parser.add_option('-d', '--directory', action='store', metavar='DIR', |
| 2941 | help='Change to the directory DIR immediately, ' |
| 2942 | 'before doing anything else.') |
| 2943 | parser.add_option('--reject', action='store_true', |
tapted@chromium.org | 6a0b07c | 2013-07-10 01:29:19 +0000 | [diff] [blame] | 2944 | help='failed patches spew .rej files rather than ' |
| 2945 | 'attempting a 3-way merge') |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 2946 | parser.add_option('-n', '--no-commit', action='store_true', dest='nocommit', |
| 2947 | help="don't commit after patch applies") |
vadimsh@chromium.org | cf6a5d2 | 2015-04-09 22:02:00 +0000 | [diff] [blame] | 2948 | auth.add_auth_options(parser) |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 2949 | (options, args) = parser.parse_args(args) |
vadimsh@chromium.org | cf6a5d2 | 2015-04-09 22:02:00 +0000 | [diff] [blame] | 2950 | auth_config = auth.extract_auth_config_from_options(options) |
| 2951 | |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 2952 | if len(args) != 1: |
| 2953 | parser.print_help() |
| 2954 | return 1 |
dsinclair@chromium.org | fbed656 | 2015-09-25 21:22:36 +0000 | [diff] [blame] | 2955 | |
| 2956 | issue_arg = ParseIssueNum(args[0]) |
| 2957 | # The patch URL works because ParseIssueNum won't do any substitution |
| 2958 | # as the re.sub pattern fails to match and just returns it. |
| 2959 | if issue_arg == None: |
| 2960 | parser.print_help() |
| 2961 | return 1 |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 2962 | |
wychen@chromium.org | 46309bf | 2015-04-03 21:04:49 +0000 | [diff] [blame] | 2963 | # We don't want uncommitted changes mixed up with the patch. |
sbc@chromium.org | 71437c0 | 2015-04-09 19:29:40 +0000 | [diff] [blame] | 2964 | if git_common.is_dirty_git_tree('patch'): |
wychen@chromium.org | 46309bf | 2015-04-03 21:04:49 +0000 | [diff] [blame] | 2965 | return 1 |
| 2966 | |
maruel@chromium.org | 27bb387 | 2011-05-30 20:33:19 +0000 | [diff] [blame] | 2967 | # TODO(maruel): Use apply_issue.py |
ukai@chromium.org | e807781 | 2012-02-03 03:41:46 +0000 | [diff] [blame] | 2968 | # TODO(ukai): use gerrit-cherry-pick for gerrit repository? |
maruel@chromium.org | 27bb387 | 2011-05-30 20:33:19 +0000 | [diff] [blame] | 2969 | |
sbc@chromium.org | 87b9bf0 | 2013-09-26 20:35:15 +0000 | [diff] [blame] | 2970 | if options.newbranch: |
| 2971 | if options.force: |
| 2972 | RunGit(['branch', '-D', options.newbranch], |
| 2973 | stderr=subprocess2.PIPE, error_ok=True) |
| 2974 | RunGit(['checkout', '-b', options.newbranch, |
| 2975 | Changelist().GetUpstreamBranch()]) |
| 2976 | |
qsr@chromium.org | 1ef44af | 2013-10-16 16:24:32 +0000 | [diff] [blame] | 2977 | return PatchIssue(issue_arg, options.reject, options.nocommit, |
vadimsh@chromium.org | cf6a5d2 | 2015-04-09 22:02:00 +0000 | [diff] [blame] | 2978 | options.directory, auth_config) |
sbc@chromium.org | 87b9bf0 | 2013-09-26 20:35:15 +0000 | [diff] [blame] | 2979 | |
| 2980 | |
vadimsh@chromium.org | cf6a5d2 | 2015-04-09 22:02:00 +0000 | [diff] [blame] | 2981 | def PatchIssue(issue_arg, reject, nocommit, directory, auth_config): |
wychen@chromium.org | a872e75 | 2015-04-28 23:42:18 +0000 | [diff] [blame] | 2982 | # PatchIssue should never be called with a dirty tree. It is up to the |
| 2983 | # caller to check this, but just in case we assert here since the |
| 2984 | # consequences of the caller not checking this could be dire. |
sbc@chromium.org | 71437c0 | 2015-04-09 19:29:40 +0000 | [diff] [blame] | 2985 | assert(not git_common.is_dirty_git_tree('apply')) |
wychen@chromium.org | 46309bf | 2015-04-03 21:04:49 +0000 | [diff] [blame] | 2986 | |
sbc@chromium.org | 87b9bf0 | 2013-09-26 20:35:15 +0000 | [diff] [blame] | 2987 | if type(issue_arg) is int or issue_arg.isdigit(): |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 2988 | # Input is an issue id. Figure out the URL. |
maruel@chromium.org | 5242430 | 2012-08-29 15:14:30 +0000 | [diff] [blame] | 2989 | issue = int(issue_arg) |
vadimsh@chromium.org | cf6a5d2 | 2015-04-09 22:02:00 +0000 | [diff] [blame] | 2990 | cl = Changelist(issue=issue, auth_config=auth_config) |
maruel@chromium.org | 1033efd | 2013-07-23 23:25:09 +0000 | [diff] [blame] | 2991 | patchset = cl.GetMostRecentPatchset() |
binji@chromium.org | 0281f52 | 2012-09-14 13:37:59 +0000 | [diff] [blame] | 2992 | patch_data = cl.GetPatchSetDiff(issue, patchset) |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 2993 | else: |
maruel@chromium.org | eb5edbc | 2012-01-16 17:03:28 +0000 | [diff] [blame] | 2994 | # Assume it's a URL to the patch. Default to https. |
| 2995 | issue_url = gclient_utils.UpgradeToHttps(issue_arg) |
kjellander@chromium.org | 4442454 | 2015-06-02 18:35:29 +0000 | [diff] [blame] | 2996 | match = re.match(r'(.*?)/download/issue(\d+)_(\d+).diff', issue_url) |
maruel@chromium.org | e77ebbf | 2011-03-29 20:35:38 +0000 | [diff] [blame] | 2997 | if not match: |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 2998 | DieWithError('Must pass an issue ID or full URL for ' |
| 2999 | '\'Download raw patch set\'') |
kjellander@chromium.org | 4442454 | 2015-06-02 18:35:29 +0000 | [diff] [blame] | 3000 | issue = int(match.group(2)) |
| 3001 | cl = Changelist(issue=issue, auth_config=auth_config) |
| 3002 | cl.rietveld_server = match.group(1) |
| 3003 | patchset = int(match.group(3)) |
maruel@chromium.org | e77ebbf | 2011-03-29 20:35:38 +0000 | [diff] [blame] | 3004 | patch_data = urllib2.urlopen(issue_arg).read() |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 3005 | |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 3006 | # Switch up to the top-level directory, if necessary, in preparation for |
| 3007 | # applying the patch. |
thestig@chromium.org | 8b0553c | 2014-02-11 00:33:37 +0000 | [diff] [blame] | 3008 | top = settings.GetRelativeRoot() |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 3009 | if top: |
| 3010 | os.chdir(top) |
| 3011 | |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 3012 | # Git patches have a/ at the beginning of source paths. We strip that out |
| 3013 | # with a sed script rather than the -p flag to patch so we can feed either |
| 3014 | # Git or svn-style patches into the same apply command. |
| 3015 | # re.sub() should be used but flags=re.MULTILINE is only in python 2.7. |
maruel@chromium.org | 32f9f5e | 2011-09-14 13:41:47 +0000 | [diff] [blame] | 3016 | try: |
| 3017 | patch_data = subprocess2.check_output( |
| 3018 | ['sed', '-e', 's|^--- a/|--- |; s|^+++ b/|+++ |'], stdin=patch_data) |
| 3019 | except subprocess2.CalledProcessError: |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 3020 | DieWithError('Git patch mungling failed.') |
| 3021 | logging.info(patch_data) |
bratell@opera.com | 82b91cd | 2013-07-09 06:33:41 +0000 | [diff] [blame] | 3022 | |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 3023 | # We use "git apply" to apply the patch instead of "patch" so that we can |
| 3024 | # pick up file adds. |
| 3025 | # The --index flag means: also insert into the index (so we catch adds). |
bratell@opera.com | 82b91cd | 2013-07-09 06:33:41 +0000 | [diff] [blame] | 3026 | cmd = ['git', 'apply', '--index', '-p0'] |
qsr@chromium.org | 1ef44af | 2013-10-16 16:24:32 +0000 | [diff] [blame] | 3027 | if directory: |
| 3028 | cmd.extend(('--directory', directory)) |
sbc@chromium.org | 87b9bf0 | 2013-09-26 20:35:15 +0000 | [diff] [blame] | 3029 | if reject: |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 3030 | cmd.append('--reject') |
tapted@chromium.org | 6a0b07c | 2013-07-10 01:29:19 +0000 | [diff] [blame] | 3031 | elif IsGitVersionAtLeast('1.7.12'): |
| 3032 | cmd.append('--3way') |
maruel@chromium.org | 32f9f5e | 2011-09-14 13:41:47 +0000 | [diff] [blame] | 3033 | try: |
thestig@chromium.org | 8b0553c | 2014-02-11 00:33:37 +0000 | [diff] [blame] | 3034 | subprocess2.check_call(cmd, env=GetNoGitPagerEnv(), |
bratell@opera.com | 82b91cd | 2013-07-09 06:33:41 +0000 | [diff] [blame] | 3035 | stdin=patch_data, stdout=subprocess2.VOID) |
maruel@chromium.org | 32f9f5e | 2011-09-14 13:41:47 +0000 | [diff] [blame] | 3036 | except subprocess2.CalledProcessError: |
wychen@chromium.org | a872e75 | 2015-04-28 23:42:18 +0000 | [diff] [blame] | 3037 | print 'Failed to apply the patch' |
| 3038 | return 1 |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 3039 | |
| 3040 | # If we had an issue, commit the current state and register the issue. |
sbc@chromium.org | 87b9bf0 | 2013-09-26 20:35:15 +0000 | [diff] [blame] | 3041 | if not nocommit: |
wychen@chromium.org | 5b3bebb | 2015-05-28 21:41:43 +0000 | [diff] [blame] | 3042 | RunGit(['commit', '-m', (cl.GetDescription() + '\n\n' + |
| 3043 | 'patch from issue %(i)s at patchset ' |
carlosk@chromium.org | 71284d9 | 2014-11-14 18:12:50 +0000 | [diff] [blame] | 3044 | '%(p)s (http://crrev.com/%(i)s#ps%(p)s)' |
| 3045 | % {'i': issue, 'p': patchset})]) |
vadimsh@chromium.org | cf6a5d2 | 2015-04-09 22:02:00 +0000 | [diff] [blame] | 3046 | cl = Changelist(auth_config=auth_config) |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 3047 | cl.SetIssue(issue) |
binji@chromium.org | 0281f52 | 2012-09-14 13:37:59 +0000 | [diff] [blame] | 3048 | cl.SetPatchset(patchset) |
pdr@chromium.org | 98ca662 | 2013-04-09 20:58:40 +0000 | [diff] [blame] | 3049 | print "Committed patch locally." |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 3050 | else: |
| 3051 | print "Patch applied to index." |
| 3052 | return 0 |
| 3053 | |
| 3054 | |
| 3055 | def CMDrebase(parser, args): |
iannucci@chromium.org | d9c1b20 | 2013-07-24 23:52:11 +0000 | [diff] [blame] | 3056 | """Rebases current branch on top of svn repo.""" |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 3057 | # Provide a wrapper for git svn rebase to help avoid accidental |
| 3058 | # git svn dcommit. |
| 3059 | # It's the only command that doesn't use parser at all since we just defer |
| 3060 | # execution to git-svn. |
bratell@opera.com | 82b91cd | 2013-07-09 06:33:41 +0000 | [diff] [blame] | 3061 | |
thestig@chromium.org | 8b0553c | 2014-02-11 00:33:37 +0000 | [diff] [blame] | 3062 | return RunGitWithCode(['svn', 'rebase'] + args)[1] |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 3063 | |
| 3064 | |
jochen@chromium.org | 3ec0d54 | 2014-01-14 20:00:03 +0000 | [diff] [blame] | 3065 | def GetTreeStatus(url=None): |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 3066 | """Fetches the tree status and returns either 'open', 'closed', |
| 3067 | 'unknown' or 'unset'.""" |
jochen@chromium.org | 3ec0d54 | 2014-01-14 20:00:03 +0000 | [diff] [blame] | 3068 | url = url or settings.GetTreeStatusUrl(error_ok=True) |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 3069 | if url: |
| 3070 | status = urllib2.urlopen(url).read().lower() |
| 3071 | if status.find('closed') != -1 or status == '0': |
| 3072 | return 'closed' |
| 3073 | elif status.find('open') != -1 or status == '1': |
| 3074 | return 'open' |
| 3075 | return 'unknown' |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 3076 | return 'unset' |
| 3077 | |
dpranke@chromium.org | 970c522 | 2011-03-12 00:32:24 +0000 | [diff] [blame] | 3078 | |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 3079 | def GetTreeStatusReason(): |
| 3080 | """Fetches the tree status from a json url and returns the message |
| 3081 | with the reason for the tree to be opened or closed.""" |
msb@chromium.org | bf1a7ba | 2011-02-01 16:21:46 +0000 | [diff] [blame] | 3082 | url = settings.GetTreeStatusUrl() |
| 3083 | json_url = urlparse.urljoin(url, '/current?format=json') |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 3084 | connection = urllib2.urlopen(json_url) |
| 3085 | status = json.loads(connection.read()) |
| 3086 | connection.close() |
| 3087 | return status['message'] |
| 3088 | |
dpranke@chromium.org | 970c522 | 2011-03-12 00:32:24 +0000 | [diff] [blame] | 3089 | |
sheyang@chromium.org | 2b34d55 | 2014-08-14 22:18:42 +0000 | [diff] [blame] | 3090 | def GetBuilderMaster(bot_list): |
| 3091 | """For a given builder, fetch the master from AE if available.""" |
| 3092 | map_url = 'https://builders-map.appspot.com/' |
| 3093 | try: |
| 3094 | master_map = json.load(urllib2.urlopen(map_url)) |
| 3095 | except urllib2.URLError as e: |
| 3096 | return None, ('Failed to fetch builder-to-master map from %s. Error: %s.' % |
| 3097 | (map_url, e)) |
| 3098 | except ValueError as e: |
| 3099 | return None, ('Invalid json string from %s. Error: %s.' % (map_url, e)) |
| 3100 | if not master_map: |
| 3101 | return None, 'Failed to build master map.' |
| 3102 | |
| 3103 | result_master = '' |
| 3104 | for bot in bot_list: |
| 3105 | builder = bot.split(':', 1)[0] |
| 3106 | master_list = master_map.get(builder, []) |
| 3107 | if not master_list: |
| 3108 | return None, ('No matching master for builder %s.' % builder) |
| 3109 | elif len(master_list) > 1: |
| 3110 | return None, ('The builder name %s exists in multiple masters %s.' % |
| 3111 | (builder, master_list)) |
| 3112 | else: |
| 3113 | cur_master = master_list[0] |
| 3114 | if not result_master: |
| 3115 | result_master = cur_master |
| 3116 | elif result_master != cur_master: |
| 3117 | return None, 'The builders do not belong to the same master.' |
| 3118 | return result_master, None |
| 3119 | |
| 3120 | |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 3121 | def CMDtree(parser, args): |
iannucci@chromium.org | d9c1b20 | 2013-07-24 23:52:11 +0000 | [diff] [blame] | 3122 | """Shows the status of the tree.""" |
dpranke@chromium.org | 97ae58e | 2011-03-18 00:29:20 +0000 | [diff] [blame] | 3123 | _, args = parser.parse_args(args) |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 3124 | status = GetTreeStatus() |
| 3125 | if 'unset' == status: |
| 3126 | print 'You must configure your tree status URL by running "git cl config".' |
| 3127 | return 2 |
| 3128 | |
| 3129 | print "The tree is %s" % status |
| 3130 | print |
| 3131 | print GetTreeStatusReason() |
| 3132 | if status != 'open': |
| 3133 | return 1 |
| 3134 | return 0 |
| 3135 | |
| 3136 | |
maruel@chromium.org | 1519240 | 2012-09-06 12:38:29 +0000 | [diff] [blame] | 3137 | def CMDtry(parser, args): |
sheyang@chromium.org | db37557 | 2015-08-17 19:22:23 +0000 | [diff] [blame] | 3138 | """Triggers a try job through BuildBucket.""" |
maruel@chromium.org | 1519240 | 2012-09-06 12:38:29 +0000 | [diff] [blame] | 3139 | group = optparse.OptionGroup(parser, "Try job options") |
| 3140 | group.add_option( |
| 3141 | "-b", "--bot", action="append", |
| 3142 | help=("IMPORTANT: specify ONE builder per --bot flag. Use it multiple " |
| 3143 | "times to specify multiple builders. ex: " |
phajdan.jr@chromium.org | 5291413 | 2015-01-22 10:37:09 +0000 | [diff] [blame] | 3144 | "'-b win_rel -b win_layout'. See " |
maruel@chromium.org | 1519240 | 2012-09-06 12:38:29 +0000 | [diff] [blame] | 3145 | "the try server waterfall for the builders name and the tests " |
phajdan.jr@chromium.org | 5291413 | 2015-01-22 10:37:09 +0000 | [diff] [blame] | 3146 | "available.")) |
maruel@chromium.org | 1519240 | 2012-09-06 12:38:29 +0000 | [diff] [blame] | 3147 | group.add_option( |
machenbach@chromium.org | 58a69cb | 2014-03-01 02:08:29 +0000 | [diff] [blame] | 3148 | "-m", "--master", default='', |
iannucci@chromium.org | 9e84927 | 2014-04-04 00:31:55 +0000 | [diff] [blame] | 3149 | help=("Specify a try master where to run the tries.")) |
hinoka@chromium.org | feb9e2a | 2015-09-25 19:11:09 +0000 | [diff] [blame] | 3150 | group.add_option( "--luci", action='store_true') |
machenbach@chromium.org | 58a69cb | 2014-03-01 02:08:29 +0000 | [diff] [blame] | 3151 | group.add_option( |
maruel@chromium.org | 1519240 | 2012-09-06 12:38:29 +0000 | [diff] [blame] | 3152 | "-r", "--revision", |
| 3153 | help="Revision to use for the try job; default: the " |
| 3154 | "revision will be determined by the try server; see " |
| 3155 | "its waterfall for more info") |
| 3156 | group.add_option( |
| 3157 | "-c", "--clobber", action="store_true", default=False, |
| 3158 | help="Force a clobber before building; e.g. don't do an " |
| 3159 | "incremental build") |
| 3160 | group.add_option( |
| 3161 | "--project", |
| 3162 | help="Override which project to use. Projects are defined " |
| 3163 | "server-side to define what default bot set to use") |
| 3164 | group.add_option( |
machenbach@chromium.org | 4545314 | 2015-09-15 08:45:22 +0000 | [diff] [blame] | 3165 | "-p", "--property", dest="properties", action="append", default=[], |
| 3166 | help="Specify generic properties in the form -p key1=value1 -p " |
| 3167 | "key2=value2 etc (buildbucket only). The value will be treated as " |
| 3168 | "json if decodable, or as string otherwise.") |
| 3169 | group.add_option( |
maruel@chromium.org | 1519240 | 2012-09-06 12:38:29 +0000 | [diff] [blame] | 3170 | "-n", "--name", help="Try job name; default to current branch name") |
sheyang@google.com | 6ebaf78 | 2015-05-12 19:17:54 +0000 | [diff] [blame] | 3171 | group.add_option( |
sheyang@chromium.org | db37557 | 2015-08-17 19:22:23 +0000 | [diff] [blame] | 3172 | "--use-rietveld", action="store_true", default=False, |
| 3173 | help="Use Rietveld to trigger try jobs.") |
| 3174 | group.add_option( |
| 3175 | "--buildbucket-host", default='cr-buildbucket.appspot.com', |
| 3176 | help="Host of buildbucket. The default host is %default.") |
maruel@chromium.org | 1519240 | 2012-09-06 12:38:29 +0000 | [diff] [blame] | 3177 | parser.add_option_group(group) |
vadimsh@chromium.org | cf6a5d2 | 2015-04-09 22:02:00 +0000 | [diff] [blame] | 3178 | auth.add_auth_options(parser) |
maruel@chromium.org | 1519240 | 2012-09-06 12:38:29 +0000 | [diff] [blame] | 3179 | options, args = parser.parse_args(args) |
vadimsh@chromium.org | cf6a5d2 | 2015-04-09 22:02:00 +0000 | [diff] [blame] | 3180 | auth_config = auth.extract_auth_config_from_options(options) |
maruel@chromium.org | 1519240 | 2012-09-06 12:38:29 +0000 | [diff] [blame] | 3181 | |
machenbach@chromium.org | 4545314 | 2015-09-15 08:45:22 +0000 | [diff] [blame] | 3182 | if options.use_rietveld and options.properties: |
| 3183 | parser.error('Properties can only be specified with buildbucket') |
| 3184 | |
| 3185 | # Make sure that all properties are prop=value pairs. |
| 3186 | bad_params = [x for x in options.properties if '=' not in x] |
| 3187 | if bad_params: |
| 3188 | parser.error('Got properties with missing "=": %s' % bad_params) |
| 3189 | |
maruel@chromium.org | 1519240 | 2012-09-06 12:38:29 +0000 | [diff] [blame] | 3190 | if args: |
| 3191 | parser.error('Unknown arguments: %s' % args) |
| 3192 | |
vadimsh@chromium.org | cf6a5d2 | 2015-04-09 22:02:00 +0000 | [diff] [blame] | 3193 | cl = Changelist(auth_config=auth_config) |
maruel@chromium.org | 1519240 | 2012-09-06 12:38:29 +0000 | [diff] [blame] | 3194 | if not cl.GetIssue(): |
| 3195 | parser.error('Need to upload first') |
| 3196 | |
jrobbins@chromium.org | 16f10f7 | 2014-06-24 22:14:36 +0000 | [diff] [blame] | 3197 | props = cl.GetIssueProperties() |
agable@chromium.org | 787e306 | 2014-08-20 16:31:19 +0000 | [diff] [blame] | 3198 | if props.get('closed'): |
| 3199 | parser.error('Cannot send tryjobs for a closed CL') |
| 3200 | |
jrobbins@chromium.org | 16f10f7 | 2014-06-24 22:14:36 +0000 | [diff] [blame] | 3201 | if props.get('private'): |
| 3202 | parser.error('Cannot use trybots with private issue') |
| 3203 | |
maruel@chromium.org | 1519240 | 2012-09-06 12:38:29 +0000 | [diff] [blame] | 3204 | if not options.name: |
| 3205 | options.name = cl.GetBranch() |
| 3206 | |
phajdan.jr@chromium.org | 8da7f27 | 2014-03-14 01:28:39 +0000 | [diff] [blame] | 3207 | if options.bot and not options.master: |
sheyang@chromium.org | 2b34d55 | 2014-08-14 22:18:42 +0000 | [diff] [blame] | 3208 | options.master, err_msg = GetBuilderMaster(options.bot) |
| 3209 | if err_msg: |
| 3210 | parser.error('Tryserver master cannot be found because: %s\n' |
| 3211 | 'Please manually specify the tryserver master' |
| 3212 | ', e.g. "-m tryserver.chromium.linux".' % err_msg) |
phajdan.jr@chromium.org | 8da7f27 | 2014-03-14 01:28:39 +0000 | [diff] [blame] | 3213 | |
machenbach@chromium.org | 58a69cb | 2014-03-01 02:08:29 +0000 | [diff] [blame] | 3214 | def GetMasterMap(): |
phajdan.jr@chromium.org | 5291413 | 2015-01-22 10:37:09 +0000 | [diff] [blame] | 3215 | # Process --bot. |
machenbach@chromium.org | 58a69cb | 2014-03-01 02:08:29 +0000 | [diff] [blame] | 3216 | if not options.bot: |
| 3217 | change = cl.GetChange(cl.GetCommonAncestorWithUpstream(), None) |
maruel@chromium.org | 1519240 | 2012-09-06 12:38:29 +0000 | [diff] [blame] | 3218 | |
machenbach@chromium.org | 58a69cb | 2014-03-01 02:08:29 +0000 | [diff] [blame] | 3219 | # Get try masters from PRESUBMIT.py files. |
| 3220 | masters = presubmit_support.DoGetTryMasters( |
| 3221 | change, |
| 3222 | change.LocalPaths(), |
| 3223 | settings.GetRoot(), |
| 3224 | None, |
| 3225 | None, |
| 3226 | options.verbose, |
| 3227 | sys.stdout) |
| 3228 | if masters: |
| 3229 | return masters |
stip@chromium.org | 43064fd | 2013-12-18 20:07:44 +0000 | [diff] [blame] | 3230 | |
machenbach@chromium.org | 58a69cb | 2014-03-01 02:08:29 +0000 | [diff] [blame] | 3231 | # Fall back to deprecated method: get try slaves from PRESUBMIT.py files. |
| 3232 | options.bot = presubmit_support.DoGetTrySlaves( |
| 3233 | change, |
| 3234 | change.LocalPaths(), |
| 3235 | settings.GetRoot(), |
| 3236 | None, |
| 3237 | None, |
| 3238 | options.verbose, |
| 3239 | sys.stdout) |
tandrii@chromium.org | 71184c0 | 2016-01-13 15:18:44 +0000 | [diff] [blame] | 3240 | |
| 3241 | if not options.bot: |
| 3242 | # Get try masters from cq.cfg if any. |
| 3243 | # TODO(tandrii): some (but very few) projects store cq.cfg in different |
| 3244 | # location. |
| 3245 | cq_cfg = os.path.join(change.RepositoryRoot(), |
| 3246 | 'infra', 'config', 'cq.cfg') |
| 3247 | if os.path.exists(cq_cfg): |
| 3248 | masters = {} |
machenbach@chromium.org | 5999480 | 2016-01-14 10:10:33 +0000 | [diff] [blame] | 3249 | cq_masters = commit_queue.get_master_builder_map( |
| 3250 | cq_cfg, include_experimental=False, include_triggered=False) |
tandrii@chromium.org | 71184c0 | 2016-01-13 15:18:44 +0000 | [diff] [blame] | 3251 | for master, builders in cq_masters.iteritems(): |
| 3252 | for builder in builders: |
| 3253 | # Skip presubmit builders, because these will fail without LGTM. |
| 3254 | if 'presubmit' not in builder.lower(): |
| 3255 | masters.setdefault(master, {})[builder] = ['defaulttests'] |
| 3256 | if masters: |
| 3257 | return masters |
| 3258 | |
machenbach@chromium.org | 58a69cb | 2014-03-01 02:08:29 +0000 | [diff] [blame] | 3259 | if not options.bot: |
| 3260 | parser.error('No default try builder to try, use --bot') |
maruel@chromium.org | 1519240 | 2012-09-06 12:38:29 +0000 | [diff] [blame] | 3261 | |
machenbach@chromium.org | 58a69cb | 2014-03-01 02:08:29 +0000 | [diff] [blame] | 3262 | builders_and_tests = {} |
| 3263 | # TODO(machenbach): The old style command-line options don't support |
| 3264 | # multiple try masters yet. |
| 3265 | old_style = filter(lambda x: isinstance(x, basestring), options.bot) |
| 3266 | new_style = filter(lambda x: isinstance(x, tuple), options.bot) |
| 3267 | |
| 3268 | for bot in old_style: |
| 3269 | if ':' in bot: |
phajdan.jr@chromium.org | 5291413 | 2015-01-22 10:37:09 +0000 | [diff] [blame] | 3270 | parser.error('Specifying testfilter is no longer supported') |
machenbach@chromium.org | 58a69cb | 2014-03-01 02:08:29 +0000 | [diff] [blame] | 3271 | elif ',' in bot: |
| 3272 | parser.error('Specify one bot per --bot flag') |
| 3273 | else: |
tandrii@chromium.org | 3764fa2 | 2015-10-21 16:40:40 +0000 | [diff] [blame] | 3274 | builders_and_tests.setdefault(bot, []) |
machenbach@chromium.org | 58a69cb | 2014-03-01 02:08:29 +0000 | [diff] [blame] | 3275 | |
| 3276 | for bot, tests in new_style: |
| 3277 | builders_and_tests.setdefault(bot, []).extend(tests) |
| 3278 | |
| 3279 | # Return a master map with one master to be backwards compatible. The |
| 3280 | # master name defaults to an empty string, which will cause the master |
| 3281 | # not to be set on rietveld (deprecated). |
| 3282 | return {options.master: builders_and_tests} |
| 3283 | |
| 3284 | masters = GetMasterMap() |
stip@chromium.org | 43064fd | 2013-12-18 20:07:44 +0000 | [diff] [blame] | 3285 | |
machenbach@chromium.org | 58a69cb | 2014-03-01 02:08:29 +0000 | [diff] [blame] | 3286 | for builders in masters.itervalues(): |
| 3287 | if any('triggered' in b for b in builders): |
| 3288 | print >> sys.stderr, ( |
| 3289 | 'ERROR You are trying to send a job to a triggered bot. This type of' |
| 3290 | ' bot requires an\ninitial job from a parent (usually a builder). ' |
| 3291 | 'Instead send your job to the parent.\n' |
| 3292 | 'Bot list: %s' % builders) |
| 3293 | return 1 |
ilevy@chromium.org | f3b2123 | 2012-09-24 20:48:55 +0000 | [diff] [blame] | 3294 | |
ilevy@chromium.org | 36e420b | 2013-08-06 23:21:12 +0000 | [diff] [blame] | 3295 | patchset = cl.GetMostRecentPatchset() |
| 3296 | if patchset and patchset != cl.GetPatchset(): |
| 3297 | print( |
| 3298 | '\nWARNING Mismatch between local config and server. Did a previous ' |
| 3299 | 'upload fail?\ngit-cl try always uses latest patchset from rietveld. ' |
| 3300 | 'Continuing using\npatchset %s.\n' % patchset) |
hinoka@chromium.org | feb9e2a | 2015-09-25 19:11:09 +0000 | [diff] [blame] | 3301 | if options.luci: |
| 3302 | trigger_luci_job(cl, masters, options) |
| 3303 | elif not options.use_rietveld: |
sheyang@google.com | 6ebaf78 | 2015-05-12 19:17:54 +0000 | [diff] [blame] | 3304 | try: |
| 3305 | trigger_try_jobs(auth_config, cl, options, masters, 'git_cl_try') |
| 3306 | except BuildbucketResponseException as ex: |
| 3307 | print 'ERROR: %s' % ex |
fischman@chromium.org | d246c97 | 2013-12-21 22:47:38 +0000 | [diff] [blame] | 3308 | return 1 |
sheyang@google.com | 6ebaf78 | 2015-05-12 19:17:54 +0000 | [diff] [blame] | 3309 | except Exception as e: |
| 3310 | stacktrace = (''.join(traceback.format_stack()) + traceback.format_exc()) |
| 3311 | print 'ERROR: Exception when trying to trigger tryjobs: %s\n%s' % ( |
| 3312 | e, stacktrace) |
| 3313 | return 1 |
| 3314 | else: |
| 3315 | try: |
| 3316 | cl.RpcServer().trigger_distributed_try_jobs( |
| 3317 | cl.GetIssue(), patchset, options.name, options.clobber, |
| 3318 | options.revision, masters) |
| 3319 | except urllib2.HTTPError as e: |
| 3320 | if e.code == 404: |
| 3321 | print('404 from rietveld; ' |
| 3322 | 'did you mean to use "git try" instead of "git cl try"?') |
| 3323 | return 1 |
| 3324 | print('Tried jobs on:') |
machenbach@chromium.org | 58a69cb | 2014-03-01 02:08:29 +0000 | [diff] [blame] | 3325 | |
sheyang@google.com | 6ebaf78 | 2015-05-12 19:17:54 +0000 | [diff] [blame] | 3326 | for (master, builders) in sorted(masters.iteritems()): |
| 3327 | if master: |
| 3328 | print 'Master: %s' % master |
| 3329 | length = max(len(builder) for builder in builders) |
| 3330 | for builder in sorted(builders): |
| 3331 | print ' %*s: %s' % (length, builder, ','.join(builders[builder])) |
maruel@chromium.org | 1519240 | 2012-09-06 12:38:29 +0000 | [diff] [blame] | 3332 | return 0 |
| 3333 | |
| 3334 | |
maruel@chromium.org | 0633fb4 | 2013-08-16 20:06:14 +0000 | [diff] [blame] | 3335 | @subcommand.usage('[new upstream branch]') |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 3336 | def CMDupstream(parser, args): |
iannucci@chromium.org | d9c1b20 | 2013-07-24 23:52:11 +0000 | [diff] [blame] | 3337 | """Prints or sets the name of the upstream branch, if any.""" |
dpranke@chromium.org | 97ae58e | 2011-03-18 00:29:20 +0000 | [diff] [blame] | 3338 | _, args = parser.parse_args(args) |
brettw@chromium.org | ac0ba33 | 2012-08-09 23:42:53 +0000 | [diff] [blame] | 3339 | if len(args) > 1: |
maruel@chromium.org | 27bb387 | 2011-05-30 20:33:19 +0000 | [diff] [blame] | 3340 | parser.error('Unrecognized args: %s' % ' '.join(args)) |
brettw@chromium.org | ac0ba33 | 2012-08-09 23:42:53 +0000 | [diff] [blame] | 3341 | |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 3342 | cl = Changelist() |
brettw@chromium.org | ac0ba33 | 2012-08-09 23:42:53 +0000 | [diff] [blame] | 3343 | if args: |
| 3344 | # One arg means set upstream branch. |
bauerb@chromium.org | c9cf90a | 2014-04-28 20:32:31 +0000 | [diff] [blame] | 3345 | branch = cl.GetBranch() |
| 3346 | RunGit(['branch', '--set-upstream', branch, args[0]]) |
brettw@chromium.org | ac0ba33 | 2012-08-09 23:42:53 +0000 | [diff] [blame] | 3347 | cl = Changelist() |
| 3348 | print "Upstream branch set to " + cl.GetUpstreamBranch() |
bauerb@chromium.org | c9cf90a | 2014-04-28 20:32:31 +0000 | [diff] [blame] | 3349 | |
| 3350 | # Clear configured merge-base, if there is one. |
| 3351 | git_common.remove_merge_base(branch) |
brettw@chromium.org | ac0ba33 | 2012-08-09 23:42:53 +0000 | [diff] [blame] | 3352 | else: |
| 3353 | print cl.GetUpstreamBranch() |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 3354 | return 0 |
| 3355 | |
| 3356 | |
thestig@chromium.org | 00858c8 | 2013-12-02 23:08:03 +0000 | [diff] [blame] | 3357 | def CMDweb(parser, args): |
| 3358 | """Opens the current CL in the web browser.""" |
| 3359 | _, args = parser.parse_args(args) |
| 3360 | if args: |
| 3361 | parser.error('Unrecognized args: %s' % ' '.join(args)) |
| 3362 | |
| 3363 | issue_url = Changelist().GetIssueURL() |
| 3364 | if not issue_url: |
| 3365 | print >> sys.stderr, 'ERROR No issue to open' |
| 3366 | return 1 |
| 3367 | |
| 3368 | webbrowser.open(issue_url) |
| 3369 | return 0 |
| 3370 | |
| 3371 | |
maruel@chromium.org | 27bb387 | 2011-05-30 20:33:19 +0000 | [diff] [blame] | 3372 | def CMDset_commit(parser, args): |
iannucci@chromium.org | d9c1b20 | 2013-07-24 23:52:11 +0000 | [diff] [blame] | 3373 | """Sets the commit bit to trigger the Commit Queue.""" |
vadimsh@chromium.org | cf6a5d2 | 2015-04-09 22:02:00 +0000 | [diff] [blame] | 3374 | auth.add_auth_options(parser) |
| 3375 | options, args = parser.parse_args(args) |
| 3376 | auth_config = auth.extract_auth_config_from_options(options) |
maruel@chromium.org | 27bb387 | 2011-05-30 20:33:19 +0000 | [diff] [blame] | 3377 | if args: |
| 3378 | parser.error('Unrecognized args: %s' % ' '.join(args)) |
vadimsh@chromium.org | cf6a5d2 | 2015-04-09 22:02:00 +0000 | [diff] [blame] | 3379 | cl = Changelist(auth_config=auth_config) |
jrobbins@chromium.org | 16f10f7 | 2014-06-24 22:14:36 +0000 | [diff] [blame] | 3380 | props = cl.GetIssueProperties() |
| 3381 | if props.get('private'): |
| 3382 | parser.error('Cannot set commit on private issue') |
maruel@chromium.org | 27bb387 | 2011-05-30 20:33:19 +0000 | [diff] [blame] | 3383 | cl.SetFlag('commit', '1') |
| 3384 | return 0 |
| 3385 | |
| 3386 | |
groby@chromium.org | 411034a | 2013-02-26 15:12:01 +0000 | [diff] [blame] | 3387 | def CMDset_close(parser, args): |
iannucci@chromium.org | d9c1b20 | 2013-07-24 23:52:11 +0000 | [diff] [blame] | 3388 | """Closes the issue.""" |
vadimsh@chromium.org | cf6a5d2 | 2015-04-09 22:02:00 +0000 | [diff] [blame] | 3389 | auth.add_auth_options(parser) |
| 3390 | options, args = parser.parse_args(args) |
| 3391 | auth_config = auth.extract_auth_config_from_options(options) |
groby@chromium.org | 411034a | 2013-02-26 15:12:01 +0000 | [diff] [blame] | 3392 | if args: |
| 3393 | parser.error('Unrecognized args: %s' % ' '.join(args)) |
vadimsh@chromium.org | cf6a5d2 | 2015-04-09 22:02:00 +0000 | [diff] [blame] | 3394 | cl = Changelist(auth_config=auth_config) |
groby@chromium.org | 411034a | 2013-02-26 15:12:01 +0000 | [diff] [blame] | 3395 | # Ensure there actually is an issue to close. |
| 3396 | cl.GetDescription() |
| 3397 | cl.CloseIssue() |
| 3398 | return 0 |
| 3399 | |
| 3400 | |
sbc@chromium.org | 87b9bf0 | 2013-09-26 20:35:15 +0000 | [diff] [blame] | 3401 | def CMDdiff(parser, args): |
wychen@chromium.org | 37b2ec0 | 2015-04-03 00:49:15 +0000 | [diff] [blame] | 3402 | """Shows differences between local tree and last upload.""" |
vadimsh@chromium.org | cf6a5d2 | 2015-04-09 22:02:00 +0000 | [diff] [blame] | 3403 | auth.add_auth_options(parser) |
| 3404 | options, args = parser.parse_args(args) |
| 3405 | auth_config = auth.extract_auth_config_from_options(options) |
| 3406 | if args: |
| 3407 | parser.error('Unrecognized args: %s' % ' '.join(args)) |
wychen@chromium.org | 46309bf | 2015-04-03 21:04:49 +0000 | [diff] [blame] | 3408 | |
| 3409 | # Uncommitted (staged and unstaged) changes will be destroyed by |
| 3410 | # "git reset --hard" if there are merging conflicts in PatchIssue(). |
| 3411 | # Staged changes would be committed along with the patch from last |
| 3412 | # upload, hence counted toward the "last upload" side in the final |
| 3413 | # diff output, and this is not what we want. |
sbc@chromium.org | 71437c0 | 2015-04-09 19:29:40 +0000 | [diff] [blame] | 3414 | if git_common.is_dirty_git_tree('diff'): |
wychen@chromium.org | 46309bf | 2015-04-03 21:04:49 +0000 | [diff] [blame] | 3415 | return 1 |
| 3416 | |
vadimsh@chromium.org | cf6a5d2 | 2015-04-09 22:02:00 +0000 | [diff] [blame] | 3417 | cl = Changelist(auth_config=auth_config) |
sbc@chromium.org | 78dc984 | 2013-11-25 18:43:44 +0000 | [diff] [blame] | 3418 | issue = cl.GetIssue() |
sbc@chromium.org | 87b9bf0 | 2013-09-26 20:35:15 +0000 | [diff] [blame] | 3419 | branch = cl.GetBranch() |
sbc@chromium.org | 78dc984 | 2013-11-25 18:43:44 +0000 | [diff] [blame] | 3420 | if not issue: |
| 3421 | DieWithError('No issue found for current branch (%s)' % branch) |
sbc@chromium.org | 87b9bf0 | 2013-09-26 20:35:15 +0000 | [diff] [blame] | 3422 | TMP_BRANCH = 'git-cl-diff' |
thestig@chromium.org | 8b0553c | 2014-02-11 00:33:37 +0000 | [diff] [blame] | 3423 | base_branch = cl.GetCommonAncestorWithUpstream() |
sbc@chromium.org | 87b9bf0 | 2013-09-26 20:35:15 +0000 | [diff] [blame] | 3424 | |
| 3425 | # Create a new branch based on the merge-base |
| 3426 | RunGit(['checkout', '-q', '-b', TMP_BRANCH, base_branch]) |
| 3427 | try: |
| 3428 | # Patch in the latest changes from rietveld. |
vadimsh@chromium.org | cf6a5d2 | 2015-04-09 22:02:00 +0000 | [diff] [blame] | 3429 | rtn = PatchIssue(issue, False, False, None, auth_config) |
sbc@chromium.org | 87b9bf0 | 2013-09-26 20:35:15 +0000 | [diff] [blame] | 3430 | if rtn != 0: |
wychen@chromium.org | a872e75 | 2015-04-28 23:42:18 +0000 | [diff] [blame] | 3431 | RunGit(['reset', '--hard']) |
sbc@chromium.org | 87b9bf0 | 2013-09-26 20:35:15 +0000 | [diff] [blame] | 3432 | return rtn |
| 3433 | |
wychen@chromium.org | 0692853 | 2015-02-03 02:11:29 +0000 | [diff] [blame] | 3434 | # Switch back to starting branch and diff against the temporary |
sbc@chromium.org | 87b9bf0 | 2013-09-26 20:35:15 +0000 | [diff] [blame] | 3435 | # branch containing the latest rietveld patch. |
wychen@chromium.org | 0692853 | 2015-02-03 02:11:29 +0000 | [diff] [blame] | 3436 | subprocess2.check_call(['git', 'diff', TMP_BRANCH, branch, '--']) |
sbc@chromium.org | 87b9bf0 | 2013-09-26 20:35:15 +0000 | [diff] [blame] | 3437 | finally: |
| 3438 | RunGit(['checkout', '-q', branch]) |
| 3439 | RunGit(['branch', '-D', TMP_BRANCH]) |
| 3440 | |
| 3441 | return 0 |
| 3442 | |
| 3443 | |
ikarienator@chromium.org | faf3fdf | 2013-09-20 02:11:48 +0000 | [diff] [blame] | 3444 | def CMDowners(parser, args): |
wychen@chromium.org | 37b2ec0 | 2015-04-03 00:49:15 +0000 | [diff] [blame] | 3445 | """Interactively find the owners for reviewing.""" |
ikarienator@chromium.org | faf3fdf | 2013-09-20 02:11:48 +0000 | [diff] [blame] | 3446 | parser.add_option( |
| 3447 | '--no-color', |
| 3448 | action='store_true', |
| 3449 | help='Use this option to disable color output') |
vadimsh@chromium.org | cf6a5d2 | 2015-04-09 22:02:00 +0000 | [diff] [blame] | 3450 | auth.add_auth_options(parser) |
ikarienator@chromium.org | faf3fdf | 2013-09-20 02:11:48 +0000 | [diff] [blame] | 3451 | options, args = parser.parse_args(args) |
vadimsh@chromium.org | cf6a5d2 | 2015-04-09 22:02:00 +0000 | [diff] [blame] | 3452 | auth_config = auth.extract_auth_config_from_options(options) |
ikarienator@chromium.org | faf3fdf | 2013-09-20 02:11:48 +0000 | [diff] [blame] | 3453 | |
| 3454 | author = RunGit(['config', 'user.email']).strip() or None |
| 3455 | |
vadimsh@chromium.org | cf6a5d2 | 2015-04-09 22:02:00 +0000 | [diff] [blame] | 3456 | cl = Changelist(auth_config=auth_config) |
ikarienator@chromium.org | faf3fdf | 2013-09-20 02:11:48 +0000 | [diff] [blame] | 3457 | |
| 3458 | if args: |
| 3459 | if len(args) > 1: |
| 3460 | parser.error('Unknown args') |
| 3461 | base_branch = args[0] |
| 3462 | else: |
| 3463 | # Default to diffing against the common ancestor of the upstream branch. |
thestig@chromium.org | 8b0553c | 2014-02-11 00:33:37 +0000 | [diff] [blame] | 3464 | base_branch = cl.GetCommonAncestorWithUpstream() |
ikarienator@chromium.org | faf3fdf | 2013-09-20 02:11:48 +0000 | [diff] [blame] | 3465 | |
| 3466 | change = cl.GetChange(base_branch, None) |
| 3467 | return owners_finder.OwnersFinder( |
| 3468 | [f.LocalPath() for f in |
| 3469 | cl.GetChange(base_branch, None).AffectedFiles()], |
| 3470 | change.RepositoryRoot(), author, |
| 3471 | fopen=file, os_path=os.path, glob=glob.glob, |
| 3472 | disable_color=options.no_color).run() |
| 3473 | |
| 3474 | |
jkarlin@chromium.org | 6f7fa5e | 2016-01-20 19:32:21 +0000 | [diff] [blame] | 3475 | def BuildGitDiffCmd(diff_type, upstream_commit, args): |
erg@chromium.org | e0a7c5d | 2015-02-23 20:30:08 +0000 | [diff] [blame] | 3476 | """Generates a diff command.""" |
| 3477 | # Generate diff for the current branch's changes. |
| 3478 | diff_cmd = ['diff', '--no-ext-diff', '--no-prefix', diff_type, |
| 3479 | upstream_commit, '--' ] |
| 3480 | |
| 3481 | if args: |
| 3482 | for arg in args: |
jkarlin@chromium.org | 6f7fa5e | 2016-01-20 19:32:21 +0000 | [diff] [blame] | 3483 | if os.path.isdir(arg) or os.path.isfile(arg): |
erg@chromium.org | e0a7c5d | 2015-02-23 20:30:08 +0000 | [diff] [blame] | 3484 | diff_cmd.append(arg) |
| 3485 | else: |
| 3486 | DieWithError('Argument "%s" is not a file or a directory' % arg) |
erg@chromium.org | e0a7c5d | 2015-02-23 20:30:08 +0000 | [diff] [blame] | 3487 | |
| 3488 | return diff_cmd |
| 3489 | |
jkarlin@chromium.org | 6f7fa5e | 2016-01-20 19:32:21 +0000 | [diff] [blame] | 3490 | def MatchingFileType(file_name, extensions): |
| 3491 | """Returns true if the file name ends with one of the given extensions.""" |
| 3492 | return bool([ext for ext in extensions if file_name.lower().endswith(ext)]) |
erg@chromium.org | e0a7c5d | 2015-02-23 20:30:08 +0000 | [diff] [blame] | 3493 | |
enne@chromium.org | 555cfe4 | 2014-01-29 18:21:39 +0000 | [diff] [blame] | 3494 | @subcommand.usage('[files or directories to diff]') |
agable@chromium.org | fab8f82 | 2013-05-06 17:43:09 +0000 | [diff] [blame] | 3495 | def CMDformat(parser, args): |
sbc@chromium.org | 9d0644d | 2015-06-05 23:16:54 +0000 | [diff] [blame] | 3496 | """Runs auto-formatting tools (clang-format etc.) on the diff.""" |
thakis@chromium.org | 9819b1b | 2014-12-09 21:21:53 +0000 | [diff] [blame] | 3497 | CLANG_EXTS = ['.cc', '.cpp', '.h', '.mm', '.proto', '.java'] |
enne@chromium.org | 3b7e15c | 2014-01-21 17:44:47 +0000 | [diff] [blame] | 3498 | parser.add_option('--full', action='store_true', |
| 3499 | help='Reformat the full content of all touched files') |
| 3500 | parser.add_option('--dry-run', action='store_true', |
| 3501 | help='Don\'t modify any file on disk.') |
sbc@chromium.org | 9d0644d | 2015-06-05 23:16:54 +0000 | [diff] [blame] | 3502 | parser.add_option('--python', action='store_true', |
| 3503 | help='Format python code with yapf (experimental).') |
wittman@chromium.org | 04d5a22 | 2014-03-07 18:30:42 +0000 | [diff] [blame] | 3504 | parser.add_option('--diff', action='store_true', |
| 3505 | help='Print diff to stdout rather than modifying files.') |
agable@chromium.org | fab8f82 | 2013-05-06 17:43:09 +0000 | [diff] [blame] | 3506 | opts, args = parser.parse_args(args) |
agable@chromium.org | fab8f82 | 2013-05-06 17:43:09 +0000 | [diff] [blame] | 3507 | |
enne@chromium.org | ff7a1fb | 2013-12-10 19:21:41 +0000 | [diff] [blame] | 3508 | # git diff generates paths against the root of the repository. Change |
| 3509 | # to that directory so clang-format can find files even within subdirs. |
thestig@chromium.org | 8b0553c | 2014-02-11 00:33:37 +0000 | [diff] [blame] | 3510 | rel_base_path = settings.GetRelativeRoot() |
enne@chromium.org | ff7a1fb | 2013-12-10 19:21:41 +0000 | [diff] [blame] | 3511 | if rel_base_path: |
| 3512 | os.chdir(rel_base_path) |
| 3513 | |
digit@chromium.org | 29e4727 | 2013-05-17 17:01:46 +0000 | [diff] [blame] | 3514 | # Grab the merge-base commit, i.e. the upstream commit of the current |
| 3515 | # branch when it was created or the last time it was rebased. This is |
| 3516 | # to cover the case where the user may have called "git fetch origin", |
| 3517 | # moving the origin branch to a newer commit, but hasn't rebased yet. |
| 3518 | upstream_commit = None |
| 3519 | cl = Changelist() |
| 3520 | upstream_branch = cl.GetUpstreamBranch() |
| 3521 | if upstream_branch: |
| 3522 | upstream_commit = RunGit(['merge-base', 'HEAD', upstream_branch]) |
| 3523 | upstream_commit = upstream_commit.strip() |
| 3524 | |
| 3525 | if not upstream_commit: |
| 3526 | DieWithError('Could not find base commit for this branch. ' |
| 3527 | 'Are you in detached state?') |
| 3528 | |
jkarlin@chromium.org | 6f7fa5e | 2016-01-20 19:32:21 +0000 | [diff] [blame] | 3529 | changed_files_cmd = BuildGitDiffCmd('--name-only', upstream_commit, args) |
| 3530 | diff_output = RunGit(changed_files_cmd) |
| 3531 | diff_files = diff_output.splitlines() |
jkarlin@chromium.org | ad21b92 | 2016-01-28 17:48:42 +0000 | [diff] [blame^] | 3532 | # Filter out files deleted by this CL |
| 3533 | diff_files = [x for x in diff_files if os.path.isfile(x)] |
erg@chromium.org | e0a7c5d | 2015-02-23 20:30:08 +0000 | [diff] [blame] | 3534 | |
jkarlin@chromium.org | 6f7fa5e | 2016-01-20 19:32:21 +0000 | [diff] [blame] | 3535 | clang_diff_files = [x for x in diff_files if MatchingFileType(x, CLANG_EXTS)] |
| 3536 | python_diff_files = [x for x in diff_files if MatchingFileType(x, ['.py'])] |
| 3537 | dart_diff_files = [x for x in diff_files if MatchingFileType(x, ['.dart'])] |
digit@chromium.org | 29e4727 | 2013-05-17 17:01:46 +0000 | [diff] [blame] | 3538 | |
nick@chromium.org | 3ac1c4e | 2014-01-16 02:44:42 +0000 | [diff] [blame] | 3539 | top_dir = os.path.normpath( |
| 3540 | RunGit(["rev-parse", "--show-toplevel"]).rstrip('\n')) |
| 3541 | |
| 3542 | # Locate the clang-format binary in the checkout |
| 3543 | try: |
| 3544 | clang_format_tool = clang_format.FindClangFormatToolInChromiumTree() |
| 3545 | except clang_format.NotFoundError, e: |
| 3546 | DieWithError(e) |
mdempsky@google.com | c3b3dc0 | 2013-08-05 23:09:49 +0000 | [diff] [blame] | 3547 | |
erg@chromium.org | e0a7c5d | 2015-02-23 20:30:08 +0000 | [diff] [blame] | 3548 | # Set to 2 to signal to CheckPatchFormatted() that this patch isn't |
| 3549 | # formatted. This is used to block during the presubmit. |
| 3550 | return_value = 0 |
| 3551 | |
digit@chromium.org | 29e4727 | 2013-05-17 17:01:46 +0000 | [diff] [blame] | 3552 | if opts.full: |
jkarlin@chromium.org | 6f7fa5e | 2016-01-20 19:32:21 +0000 | [diff] [blame] | 3553 | if clang_diff_files: |
erg@chromium.org | e0a7c5d | 2015-02-23 20:30:08 +0000 | [diff] [blame] | 3554 | cmd = [clang_format_tool] |
| 3555 | if not opts.dry_run and not opts.diff: |
| 3556 | cmd.append('-i') |
jkarlin@chromium.org | 6f7fa5e | 2016-01-20 19:32:21 +0000 | [diff] [blame] | 3557 | stdout = RunCommand(cmd + clang_diff_files, cwd=top_dir) |
erg@chromium.org | e0a7c5d | 2015-02-23 20:30:08 +0000 | [diff] [blame] | 3558 | if opts.diff: |
| 3559 | sys.stdout.write(stdout) |
agable@chromium.org | fab8f82 | 2013-05-06 17:43:09 +0000 | [diff] [blame] | 3560 | else: |
nick@chromium.org | 3ac1c4e | 2014-01-16 02:44:42 +0000 | [diff] [blame] | 3561 | env = os.environ.copy() |
thakis@chromium.org | bd2a9b9 | 2014-09-05 18:54:22 +0000 | [diff] [blame] | 3562 | env['PATH'] = str(os.path.dirname(clang_format_tool)) |
nick@chromium.org | 3ac1c4e | 2014-01-16 02:44:42 +0000 | [diff] [blame] | 3563 | try: |
| 3564 | script = clang_format.FindClangFormatScriptInChromiumTree( |
| 3565 | 'clang-format-diff.py') |
| 3566 | except clang_format.NotFoundError, e: |
| 3567 | DieWithError(e) |
digit@chromium.org | d6ddc1c | 2013-10-25 15:36:32 +0000 | [diff] [blame] | 3568 | |
enne@chromium.org | 3b7e15c | 2014-01-21 17:44:47 +0000 | [diff] [blame] | 3569 | cmd = [sys.executable, script, '-p0'] |
wittman@chromium.org | 04d5a22 | 2014-03-07 18:30:42 +0000 | [diff] [blame] | 3570 | if not opts.dry_run and not opts.diff: |
enne@chromium.org | 3b7e15c | 2014-01-21 17:44:47 +0000 | [diff] [blame] | 3571 | cmd.append('-i') |
digit@chromium.org | d6ddc1c | 2013-10-25 15:36:32 +0000 | [diff] [blame] | 3572 | |
jkarlin@chromium.org | 6f7fa5e | 2016-01-20 19:32:21 +0000 | [diff] [blame] | 3573 | diff_cmd = BuildGitDiffCmd('-U0', upstream_commit, clang_diff_files) |
| 3574 | diff_output = RunGit(diff_cmd) |
| 3575 | |
enne@chromium.org | 3b7e15c | 2014-01-21 17:44:47 +0000 | [diff] [blame] | 3576 | stdout = RunCommand(cmd, stdin=diff_output, cwd=top_dir, env=env) |
wittman@chromium.org | 04d5a22 | 2014-03-07 18:30:42 +0000 | [diff] [blame] | 3577 | if opts.diff: |
| 3578 | sys.stdout.write(stdout) |
enne@chromium.org | 3b7e15c | 2014-01-21 17:44:47 +0000 | [diff] [blame] | 3579 | if opts.dry_run and len(stdout) > 0: |
erg@chromium.org | e0a7c5d | 2015-02-23 20:30:08 +0000 | [diff] [blame] | 3580 | return_value = 2 |
agable@chromium.org | fab8f82 | 2013-05-06 17:43:09 +0000 | [diff] [blame] | 3581 | |
sbc@chromium.org | 9d0644d | 2015-06-05 23:16:54 +0000 | [diff] [blame] | 3582 | # Similar code to above, but using yapf on .py files rather than clang-format |
| 3583 | # on C/C++ files |
| 3584 | if opts.python: |
sbc@chromium.org | 9d0644d | 2015-06-05 23:16:54 +0000 | [diff] [blame] | 3585 | yapf_tool = gclient_utils.FindExecutable('yapf') |
| 3586 | if yapf_tool is None: |
| 3587 | DieWithError('yapf not found in PATH') |
| 3588 | |
| 3589 | if opts.full: |
jkarlin@chromium.org | 6f7fa5e | 2016-01-20 19:32:21 +0000 | [diff] [blame] | 3590 | if python_diff_files: |
sbc@chromium.org | 9d0644d | 2015-06-05 23:16:54 +0000 | [diff] [blame] | 3591 | cmd = [yapf_tool] |
| 3592 | if not opts.dry_run and not opts.diff: |
| 3593 | cmd.append('-i') |
jkarlin@chromium.org | 6f7fa5e | 2016-01-20 19:32:21 +0000 | [diff] [blame] | 3594 | stdout = RunCommand(cmd + python_diff_files, cwd=top_dir) |
sbc@chromium.org | 9d0644d | 2015-06-05 23:16:54 +0000 | [diff] [blame] | 3595 | if opts.diff: |
| 3596 | sys.stdout.write(stdout) |
| 3597 | else: |
| 3598 | # TODO(sbc): yapf --lines mode still has some issues. |
| 3599 | # https://github.com/google/yapf/issues/154 |
| 3600 | DieWithError('--python currently only works with --full') |
| 3601 | |
jkarlin@chromium.org | 6f7fa5e | 2016-01-20 19:32:21 +0000 | [diff] [blame] | 3602 | # Dart's formatter does not have the nice property of only operating on |
| 3603 | # modified chunks, so hard code full. |
| 3604 | if dart_diff_files: |
erg@chromium.org | e0a7c5d | 2015-02-23 20:30:08 +0000 | [diff] [blame] | 3605 | try: |
| 3606 | command = [dart_format.FindDartFmtToolInChromiumTree()] |
| 3607 | if not opts.dry_run and not opts.diff: |
| 3608 | command.append('-w') |
jkarlin@chromium.org | 6f7fa5e | 2016-01-20 19:32:21 +0000 | [diff] [blame] | 3609 | command.extend(dart_diff_files) |
erg@chromium.org | e0a7c5d | 2015-02-23 20:30:08 +0000 | [diff] [blame] | 3610 | |
| 3611 | stdout = RunCommand(command, cwd=top_dir, env=env) |
| 3612 | if opts.dry_run and stdout: |
| 3613 | return_value = 2 |
| 3614 | except dart_format.NotFoundError as e: |
erikcorry@chromium.org | 3e44502 | 2015-12-17 09:07:26 +0000 | [diff] [blame] | 3615 | print ('Warning: Unable to check Dart code formatting. Dart SDK not ' + |
| 3616 | 'found in this checkout. Files in other languages are still ' + |
| 3617 | 'formatted.') |
erg@chromium.org | e0a7c5d | 2015-02-23 20:30:08 +0000 | [diff] [blame] | 3618 | |
| 3619 | return return_value |
agable@chromium.org | fab8f82 | 2013-05-06 17:43:09 +0000 | [diff] [blame] | 3620 | |
| 3621 | |
scottmg@chromium.org | 84a80c4 | 2015-09-22 20:40:37 +0000 | [diff] [blame] | 3622 | @subcommand.usage('<codereview url or issue id>') |
| 3623 | def CMDcheckout(parser, args): |
| 3624 | """Checks out a branch associated with a given Rietveld issue.""" |
| 3625 | _, args = parser.parse_args(args) |
| 3626 | |
| 3627 | if len(args) != 1: |
| 3628 | parser.print_help() |
| 3629 | return 1 |
| 3630 | |
dsinclair@chromium.org | fbed656 | 2015-09-25 21:22:36 +0000 | [diff] [blame] | 3631 | target_issue = ParseIssueNum(args[0]) |
| 3632 | if target_issue == None: |
scottmg@chromium.org | 84a80c4 | 2015-09-22 20:40:37 +0000 | [diff] [blame] | 3633 | parser.print_help() |
| 3634 | return 1 |
| 3635 | |
| 3636 | key_and_issues = [x.split() for x in RunGit( |
| 3637 | ['config', '--local', '--get-regexp', r'branch\..*\.rietveldissue']) |
| 3638 | .splitlines()] |
| 3639 | branches = [] |
| 3640 | for key, issue in key_and_issues: |
| 3641 | if issue == target_issue: |
| 3642 | branches.append(re.sub(r'branch\.(.*)\.rietveldissue', r'\1', key)) |
| 3643 | |
| 3644 | if len(branches) == 0: |
| 3645 | print 'No branch found for issue %s.' % target_issue |
| 3646 | return 1 |
| 3647 | if len(branches) == 1: |
| 3648 | RunGit(['checkout', branches[0]]) |
| 3649 | else: |
| 3650 | print 'Multiple branches match issue %s:' % target_issue |
| 3651 | for i in range(len(branches)): |
| 3652 | print '%d: %s' % (i, branches[i]) |
| 3653 | which = raw_input('Choose by index: ') |
| 3654 | try: |
| 3655 | RunGit(['checkout', branches[int(which)]]) |
| 3656 | except (IndexError, ValueError): |
| 3657 | print 'Invalid selection, not checking out any branch.' |
| 3658 | return 1 |
| 3659 | |
| 3660 | return 0 |
| 3661 | |
| 3662 | |
maruel@chromium.org | 29404b5 | 2014-09-08 22:58:00 +0000 | [diff] [blame] | 3663 | def CMDlol(parser, args): |
| 3664 | # This command is intentionally undocumented. |
thakis@chromium.org | 3421c99 | 2014-11-02 02:20:32 +0000 | [diff] [blame] | 3665 | print zlib.decompress(base64.b64decode( |
| 3666 | 'eNptkLEOwyAMRHe+wupCIqW57v0Vq84WqWtXyrcXnCBsmgMJ+/SSAxMZgRB6NzE' |
| 3667 | 'E2ObgCKJooYdu4uAQVffUEoE1sRQLxAcqzd7uK2gmStrll1ucV3uZyaY5sXyDd9' |
| 3668 | 'JAnN+lAXsOMJ90GANAi43mq5/VeeacylKVgi8o6F1SC63FxnagHfJUTfUYdCR/W' |
| 3669 | 'Ofe+0dHL7PicpytKP750Fh1q2qnLVof4w8OZWNY')) |
maruel@chromium.org | 29404b5 | 2014-09-08 22:58:00 +0000 | [diff] [blame] | 3670 | return 0 |
| 3671 | |
| 3672 | |
iannucci@chromium.org | d9c1b20 | 2013-07-24 23:52:11 +0000 | [diff] [blame] | 3673 | class OptionParser(optparse.OptionParser): |
| 3674 | """Creates the option parse and add --verbose support.""" |
| 3675 | def __init__(self, *args, **kwargs): |
maruel@chromium.org | 0633fb4 | 2013-08-16 20:06:14 +0000 | [diff] [blame] | 3676 | optparse.OptionParser.__init__( |
| 3677 | self, *args, prog='git cl', version=__version__, **kwargs) |
iannucci@chromium.org | d9c1b20 | 2013-07-24 23:52:11 +0000 | [diff] [blame] | 3678 | self.add_option( |
| 3679 | '-v', '--verbose', action='count', default=0, |
| 3680 | help='Use 2 times for more debugging info') |
| 3681 | |
| 3682 | def parse_args(self, args=None, values=None): |
| 3683 | options, args = optparse.OptionParser.parse_args(self, args, values) |
| 3684 | levels = [logging.WARNING, logging.INFO, logging.DEBUG] |
| 3685 | logging.basicConfig(level=levels[min(options.verbose, len(levels) - 1)]) |
| 3686 | return options, args |
| 3687 | |
iannucci@chromium.org | d9c1b20 | 2013-07-24 23:52:11 +0000 | [diff] [blame] | 3688 | |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 3689 | def main(argv): |
maruel@chromium.org | 82798cb | 2012-02-23 18:16:12 +0000 | [diff] [blame] | 3690 | if sys.hexversion < 0x02060000: |
| 3691 | print >> sys.stderr, ( |
| 3692 | '\nYour python version %s is unsupported, please upgrade.\n' % |
| 3693 | sys.version.split(' ', 1)[0]) |
| 3694 | return 2 |
maruel@chromium.org | 2e23ce3 | 2013-05-07 12:42:28 +0000 | [diff] [blame] | 3695 | |
maruel@chromium.org | ddd5941 | 2011-11-30 14:20:38 +0000 | [diff] [blame] | 3696 | # Reload settings. |
| 3697 | global settings |
| 3698 | settings = Settings() |
| 3699 | |
maruel@chromium.org | 39c0b22 | 2013-08-17 16:57:01 +0000 | [diff] [blame] | 3700 | colorize_CMDstatus_doc() |
maruel@chromium.org | 0633fb4 | 2013-08-16 20:06:14 +0000 | [diff] [blame] | 3701 | dispatcher = subcommand.CommandDispatcher(__name__) |
| 3702 | try: |
| 3703 | return dispatcher.execute(OptionParser(), argv) |
vadimsh@chromium.org | eed4df3 | 2015-04-10 21:30:20 +0000 | [diff] [blame] | 3704 | except auth.AuthenticationError as e: |
| 3705 | DieWithError(str(e)) |
maruel@chromium.org | 0633fb4 | 2013-08-16 20:06:14 +0000 | [diff] [blame] | 3706 | except urllib2.HTTPError, e: |
| 3707 | if e.code != 500: |
| 3708 | raise |
| 3709 | DieWithError( |
| 3710 | ('AppEngine is misbehaving and returned HTTP %d, again. Keep faith ' |
| 3711 | 'and retry or visit go/isgaeup.\n%s') % (e.code, str(e))) |
sbc@chromium.org | 013731e | 2015-02-26 18:28:43 +0000 | [diff] [blame] | 3712 | return 0 |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 3713 | |
| 3714 | |
| 3715 | if __name__ == '__main__': |
maruel@chromium.org | 2e23ce3 | 2013-05-07 12:42:28 +0000 | [diff] [blame] | 3716 | # These affect sys.stdout so do it outside of main() to simplify mocks in |
| 3717 | # unit testing. |
maruel@chromium.org | 6f09cd9 | 2011-04-01 16:38:12 +0000 | [diff] [blame] | 3718 | fix_encoding.fix_encoding() |
maruel@chromium.org | 2e23ce3 | 2013-05-07 12:42:28 +0000 | [diff] [blame] | 3719 | colorama.init() |
sbc@chromium.org | 013731e | 2015-02-26 18:28:43 +0000 | [diff] [blame] | 3720 | try: |
| 3721 | sys.exit(main(sys.argv[1:])) |
| 3722 | except KeyboardInterrupt: |
| 3723 | sys.stderr.write('interrupted\n') |
| 3724 | sys.exit(1) |