Do not systematically update the description on CL close.
This is not always necessary, like for "git cl set_close".
R=dpranke@chromium.org
BUG=
Review URL: https://chromiumcodereview.appspot.com/13741014
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@192829 0039d316-1c4b-4281-b951-d872f2087c98
diff --git a/git_cl.py b/git_cl.py
index 338dd93..16a6e0c 100755
--- a/git_cl.py
+++ b/git_cl.py
@@ -713,11 +713,14 @@
('%s\nMaybe your depot_tools is out of date?\n'
'If all fails, contact maruel@') % e)
+ def UpdateDescription(self, description):
+ self.description = description
+ return self.RpcServer().update_description(
+ self.GetIssue(), self.description)
+
def CloseIssue(self):
"""Updates the description and closes the issue."""
- issue = self.GetIssue()
- self.RpcServer().update_description(issue, self.description)
- return self.RpcServer().close_issue(issue)
+ return self.RpcServer().close_issue(self.GetIssue())
def SetFlag(self, flag, value):
"""Patchset must match."""
@@ -1512,6 +1515,7 @@
cl.description += ('\n\nCommitted: ' + revision)
print ('Closing issue '
'(you may be prompted for your codereview password)...')
+ cl.UpdateDescription(cl.description)
cl.CloseIssue()
props = cl.RpcServer().get_issue_properties(cl.GetIssue(), False)
patch_num = len(props['patchsets'])