commit 171c07458e2f624b26c3f82d70e51676ffa9a31f
author Mohamed Heikal <mheikal@chromium.org> Fri Nov 09 20:38:51 2018 +0000
committer Commit Bot <commit-bot@chromium.org> Fri Nov 09 20:38:51 2018 +0000
tree d23eb6e804a6fce02d9b33ddc85b03e1ab29a49e
parent e28390cc438f6206082894048801aea07964f603

Fix crash were CL has no reviewers

Currently git cl owners tries to fetch the current reviewers of a CL
from gerrit. However, this fails with a KeyError when there are no
reviewers currently. This cl fixes that bug.

Bug: 895722
Change-Id: I78a998ee234d207523aa2cef4b5058ba7cfecbc2
Reviewed-on: https://chromium-review.googlesource.com/c/1330122
Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>

git_cl.py

diff --git a/git_cl.py b/git_cl.py
index e8f7e55..4dd1cd3 100755
--- a/git_cl.py
+++ b/git_cl.py
@@ -3156,7 +3156,7 @@
 
   def GetReviewers(self):
     details = self._GetChangeDetail(['DETAILED_ACCOUNTS'])
-    return [reviewer['email'] for reviewer in details['reviewers']['REVIEWER']]
+    return [r['email'] for r in details['reviewers'].get('REVIEWER', [])]
 
 
 _CODEREVIEW_IMPLEMENTATIONS = {