blob: 1aaf6bf457c6337fad98ce0225f25f799d56a7b5 [file] [log] [blame]
Edward Lemur1f3bafb2019-10-08 17:56:33 +00001#!/usr/bin/env vpython
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +02002# Copyright (c) 2013 The Chromium Authors. All rights reserved.
maruel@chromium.org725f1c32011-04-01 20:24:54 +00003# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00006# Copyright (C) 2008 Evan Martin <martine@danga.com>
7
Andrii Shyshkalov03da1502018-10-15 03:42:34 +00008"""A git-command for integrating reviews on Gerrit."""
maruel@chromium.org725f1c32011-04-01 20:24:54 +00009
vapiera7fbd5a2016-06-16 09:17:49 -070010from __future__ import print_function
11
thakis@chromium.org3421c992014-11-02 02:20:32 +000012import base64
rmistry@google.com2dd99862015-06-22 12:22:18 +000013import collections
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +010014import datetime
Brian Sheedyb4307d52019-12-02 19:18:17 +000015import fnmatch
Edward Lemur202c5592019-10-21 22:44:52 +000016import httplib2
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +010017import itertools
maruel@chromium.org4f6852c2012-04-20 20:39:20 +000018import json
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000019import logging
calamity@chromium.orgcf197482016-04-29 20:15:53 +000020import multiprocessing
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000021import optparse
22import os
23import re
Andrii Shyshkalov353637c2017-03-14 16:52:18 +010024import shutil
ukai@chromium.org78c4b982012-02-14 02:20:26 +000025import stat
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000026import sys
Aaron Gable9a03ae02017-11-03 11:31:07 -070027import tempfile
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000028import textwrap
Edward Lemurfec80c42018-11-01 23:14:14 +000029import time
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +000030import uuid
thestig@chromium.org00858c82013-12-02 23:08:03 +000031import webbrowser
thakis@chromium.org3421c992014-11-02 02:20:32 +000032import zlib
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000033
maruel@chromium.org2e23ce32013-05-07 12:42:28 +000034from third_party import colorama
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +000035import auth
nick@chromium.org3ac1c4e2014-01-16 02:44:42 +000036import clang_format
maruel@chromium.org6f09cd92011-04-01 16:38:12 +000037import fix_encoding
maruel@chromium.org0e0436a2011-10-25 13:32:41 +000038import gclient_utils
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +000039import gerrit_util
iannucci@chromium.org9e849272014-04-04 00:31:55 +000040import git_common
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +000041import git_footers
Edward Lemur85153282020-02-14 22:06:29 +000042import git_new_branch
Edward Lemur5ba1e9c2018-07-23 18:19:02 +000043import metrics
Edward Lesmes93277a72018-10-18 22:04:26 +000044import metrics_utils
Edward Lesmeseeca9c62020-11-20 00:00:17 +000045import owners_client
iannucci@chromium.org9e849272014-04-04 00:31:55 +000046import owners_finder
Lei Zhangb8c62cf2020-07-15 20:09:37 +000047import presubmit_canned_checks
maruel@chromium.org2a74d372011-03-29 19:05:50 +000048import presubmit_support
49import scm
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +000050import setup_color
Francois Dorayd42c6812017-05-30 15:10:20 -040051import split_cl
maruel@chromium.org0633fb42013-08-16 20:06:14 +000052import subcommand
maruel@chromium.org32f9f5e2011-09-14 13:41:47 +000053import subprocess2
maruel@chromium.org2a74d372011-03-29 19:05:50 +000054import watchlists
55
Edward Lemur79d4f992019-11-11 23:49:02 +000056from third_party import six
57from six.moves import urllib
58
59
60if sys.version_info.major == 3:
61 basestring = (str,) # pylint: disable=redefined-builtin
62
Edward Lemurb9830242019-10-30 22:19:20 +000063
tandrii7400cf02016-06-21 08:48:07 -070064__version__ = '2.0'
maruel@chromium.org2a74d372011-03-29 19:05:50 +000065
Edward Lemur0f58ae42019-04-30 17:24:12 +000066# Traces for git push will be stored in a traces directory inside the
67# depot_tools checkout.
68DEPOT_TOOLS = os.path.dirname(os.path.abspath(__file__))
69TRACES_DIR = os.path.join(DEPOT_TOOLS, 'traces')
Edward Lemur227d5102020-02-25 23:45:35 +000070PRESUBMIT_SUPPORT = os.path.join(DEPOT_TOOLS, 'presubmit_support.py')
Edward Lemur0f58ae42019-04-30 17:24:12 +000071
72# When collecting traces, Git hashes will be reduced to 6 characters to reduce
73# the size after compression.
74GIT_HASH_RE = re.compile(r'\b([a-f0-9]{6})[a-f0-9]{34}\b', flags=re.I)
75# Used to redact the cookies from the gitcookies file.
76GITCOOKIES_REDACT_RE = re.compile(r'1/.*')
77
Edward Lemurd4d1ba42019-09-20 21:46:37 +000078MAX_ATTEMPTS = 3
79
Edward Lemur1b52d872019-05-09 21:12:12 +000080# The maximum number of traces we will keep. Multiplied by 3 since we store
81# 3 files per trace.
82MAX_TRACES = 3 * 10
Edward Lemur5737f022019-05-17 01:24:00 +000083# Message to be displayed to the user to inform where to find the traces for a
84# git-cl upload execution.
Edward Lemur0f58ae42019-04-30 17:24:12 +000085TRACES_MESSAGE = (
Edward Lemur1b52d872019-05-09 21:12:12 +000086'\n'
Edward Lemur5737f022019-05-17 01:24:00 +000087'The traces of this git-cl execution have been recorded at:\n'
Edward Lemur1b52d872019-05-09 21:12:12 +000088' %(trace_name)s-traces.zip\n'
Edward Lemur5737f022019-05-17 01:24:00 +000089'Copies of your gitcookies file and git config have been recorded at:\n'
90' %(trace_name)s-git-info.zip\n')
Edward Lemur1b52d872019-05-09 21:12:12 +000091# Format of the message to be stored as part of the traces to give developers a
92# better context when they go through traces.
93TRACES_README_FORMAT = (
94'Date: %(now)s\n'
95'\n'
96'Change: https://%(gerrit_host)s/q/%(change_id)s\n'
97'Title: %(title)s\n'
98'\n'
99'%(description)s\n'
100'\n'
101'Execution time: %(execution_time)s\n'
102'Exit code: %(exit_code)s\n') + TRACES_MESSAGE
Edward Lemur0f58ae42019-04-30 17:24:12 +0000103
Aaron Gable1bc7bfe2016-12-19 10:08:14 -0800104POSTUPSTREAM_HOOK = '.git/hooks/post-cl-land'
Henrique Ferreiroff249622019-11-28 23:19:29 +0000105DESCRIPTION_BACKUP_FILE = '.git_cl_description_backup'
rmistry@google.comc68112d2015-03-03 12:48:06 +0000106REFS_THAT_ALIAS_TO_OTHER_REFS = {
107 'refs/remotes/origin/lkgr': 'refs/remotes/origin/master',
108 'refs/remotes/origin/lkcr': 'refs/remotes/origin/master',
109}
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000110
Josip Sokcevicc39ab992020-09-24 20:09:15 +0000111DEFAULT_OLD_BRANCH = 'refs/remotes/origin/master'
112DEFAULT_NEW_BRANCH = 'refs/remotes/origin/main'
113
thestig@chromium.org44202a22014-03-11 19:22:18 +0000114# Valid extensions for files we want to lint.
115DEFAULT_LINT_REGEX = r"(.*\.cpp|.*\.cc|.*\.h)"
116DEFAULT_LINT_IGNORE_REGEX = r"$^"
117
Aiden Bennerc08566e2018-10-03 17:52:42 +0000118# File name for yapf style config files.
119YAPF_CONFIG_FILENAME = '.style.yapf'
120
Edward Lesmes50da7702020-03-30 19:23:43 +0000121# The issue, patchset and codereview server are stored on git config for each
122# branch under branch.<branch-name>.<config-key>.
123ISSUE_CONFIG_KEY = 'gerritissue'
124PATCHSET_CONFIG_KEY = 'gerritpatchset'
125CODEREVIEW_SERVER_CONFIG_KEY = 'gerritserver'
126
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000127# Shortcut since it quickly becomes repetitive.
maruel@chromium.org2e23ce32013-05-07 12:42:28 +0000128Fore = colorama.Fore
maruel@chromium.org90541732011-04-01 17:54:18 +0000129
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000130# Initialized in main()
131settings = None
132
Andrii Shyshkalov768f1d82016-12-08 15:10:13 +0100133# Used by tests/git_cl_test.py to add extra logging.
134# Inside the weirdly failing test, add this:
135# >>> self.mock(git_cl, '_IS_BEING_TESTED', True)
Quinten Yearsley0c62da92017-05-31 13:39:42 -0700136# And scroll up to see the stack trace printed.
Andrii Shyshkalov768f1d82016-12-08 15:10:13 +0100137_IS_BEING_TESTED = False
138
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000139
Andrii Shyshkalov1ee78cd2020-03-12 01:31:53 +0000140_KNOWN_GERRIT_TO_SHORT_URLS = {
141 'https://chrome-internal-review.googlesource.com': 'https://crrev.com/i',
142 'https://chromium-review.googlesource.com': 'https://crrev.com/c',
143}
Andrii Shyshkalov8aebb602020-04-16 22:10:27 +0000144assert len(_KNOWN_GERRIT_TO_SHORT_URLS) == len(
145 set(_KNOWN_GERRIT_TO_SHORT_URLS.values())), 'must have unique values'
Andrii Shyshkalov1ee78cd2020-03-12 01:31:53 +0000146
147
Josip Sokcevicf736cab2020-10-20 23:41:38 +0000148class GitPushError(Exception):
149 pass
150
151
Christopher Lamf732cd52017-01-24 12:40:11 +1100152def DieWithError(message, change_desc=None):
153 if change_desc:
154 SaveDescriptionBackup(change_desc)
Josip Sokcevic953278a2020-02-28 19:46:36 +0000155 print('\n ** Content of CL description **\n' +
156 '='*72 + '\n' +
157 change_desc.description + '\n' +
158 '='*72 + '\n')
Christopher Lamf732cd52017-01-24 12:40:11 +1100159
vapiera7fbd5a2016-06-16 09:17:49 -0700160 print(message, file=sys.stderr)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000161 sys.exit(1)
162
163
Christopher Lamf732cd52017-01-24 12:40:11 +1100164def SaveDescriptionBackup(change_desc):
Henrique Ferreiro5ae48172019-11-29 16:14:42 +0000165 backup_path = os.path.join(DEPOT_TOOLS, DESCRIPTION_BACKUP_FILE)
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000166 print('\nsaving CL description to %s\n' % backup_path)
Josip906bfde2020-01-31 22:38:49 +0000167 with open(backup_path, 'w') as backup_file:
168 backup_file.write(change_desc.description)
Christopher Lamf732cd52017-01-24 12:40:11 +1100169
170
thestig@chromium.org8b0553c2014-02-11 00:33:37 +0000171def GetNoGitPagerEnv():
172 env = os.environ.copy()
173 # 'cat' is a magical git string that disables pagers on all platforms.
174 env['GIT_PAGER'] = 'cat'
175 return env
176
vadimsh@chromium.org566a02a2014-08-22 01:34:13 +0000177
bsep@chromium.org627d9002016-04-29 00:00:52 +0000178def RunCommand(args, error_ok=False, error_message=None, shell=False, **kwargs):
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000179 try:
Edward Lemur79d4f992019-11-11 23:49:02 +0000180 stdout = subprocess2.check_output(args, shell=shell, **kwargs)
181 return stdout.decode('utf-8', 'replace')
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000182 except subprocess2.CalledProcessError as e:
183 logging.debug('Failed running %s', args)
maruel@chromium.org32f9f5e2011-09-14 13:41:47 +0000184 if not error_ok:
Alan Cutter594fd332020-07-21 23:55:27 +0000185 message = error_message or e.stdout.decode('utf-8', 'replace') or ''
186 DieWithError('Command "%s" failed.\n%s' % (' '.join(args), message))
Edward Lemur79d4f992019-11-11 23:49:02 +0000187 return e.stdout.decode('utf-8', 'replace')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000188
189
190def RunGit(args, **kwargs):
maruel@chromium.org32f9f5e2011-09-14 13:41:47 +0000191 """Returns stdout."""
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000192 return RunCommand(['git'] + args, **kwargs)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000193
194
enne@chromium.org3b7e15c2014-01-21 17:44:47 +0000195def RunGitWithCode(args, suppress_stderr=False):
maruel@chromium.org32f9f5e2011-09-14 13:41:47 +0000196 """Returns return code and stdout."""
tandrii5d48c322016-08-18 16:19:37 -0700197 if suppress_stderr:
Edward Lesmescf06cad2020-12-14 22:03:23 +0000198 stderr = subprocess2.DEVNULL
tandrii5d48c322016-08-18 16:19:37 -0700199 else:
200 stderr = sys.stderr
szager@chromium.org9bb85e22012-06-13 20:28:23 +0000201 try:
tandrii5d48c322016-08-18 16:19:37 -0700202 (out, _), code = subprocess2.communicate(['git'] + args,
203 env=GetNoGitPagerEnv(),
204 stdout=subprocess2.PIPE,
205 stderr=stderr)
Edward Lemur79d4f992019-11-11 23:49:02 +0000206 return code, out.decode('utf-8', 'replace')
tandrii5d48c322016-08-18 16:19:37 -0700207 except subprocess2.CalledProcessError as e:
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +0900208 logging.debug('Failed running %s', ['git'] + args)
Edward Lemur79d4f992019-11-11 23:49:02 +0000209 return e.returncode, e.stdout.decode('utf-8', 'replace')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000210
211
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000212def RunGitSilent(args):
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +0000213 """Returns stdout, suppresses stderr and ignores the return code."""
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000214 return RunGitWithCode(args, suppress_stderr=True)[1]
215
216
tandrii2a16b952016-10-19 07:09:44 -0700217def time_sleep(seconds):
218 # Use this so that it can be mocked in tests without interfering with python
219 # system machinery.
tandrii2a16b952016-10-19 07:09:44 -0700220 return time.sleep(seconds)
221
222
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000223def time_time():
224 # Use this so that it can be mocked in tests without interfering with python
225 # system machinery.
226 return time.time()
227
228
Edward Lemur1b52d872019-05-09 21:12:12 +0000229def datetime_now():
230 # Use this so that it can be mocked in tests without interfering with python
231 # system machinery.
232 return datetime.datetime.now()
233
234
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100235def confirm_or_exit(prefix='', action='confirm'):
236 """Asks user to press enter to continue or press Ctrl+C to abort."""
237 if not prefix or prefix.endswith('\n'):
238 mid = 'Press'
Andrii Shyshkalov353637c2017-03-14 16:52:18 +0100239 elif prefix.endswith('.') or prefix.endswith('?'):
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100240 mid = ' Press'
241 elif prefix.endswith(' '):
242 mid = 'press'
243 else:
244 mid = ' press'
Edward Lesmesae3586b2020-03-23 21:21:14 +0000245 gclient_utils.AskForData(
246 '%s%s Enter to %s, or Ctrl+C to abort' % (prefix, mid, action))
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100247
248
249def ask_for_explicit_yes(prompt):
Quinten Yearsleyd242ed72019-07-25 17:17:55 +0000250 """Returns whether user typed 'y' or 'yes' to confirm the given prompt."""
Edward Lesmesae3586b2020-03-23 21:21:14 +0000251 result = gclient_utils.AskForData(prompt + ' [Yes/No]: ').lower()
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100252 while True:
253 if 'yes'.startswith(result):
254 return True
255 if 'no'.startswith(result):
256 return False
Edward Lesmesae3586b2020-03-23 21:21:14 +0000257 result = gclient_utils.AskForData('Please, type yes or no: ').lower()
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100258
259
machenbach@chromium.org45453142015-09-15 08:45:22 +0000260def _get_properties_from_options(options):
Quinten Yearsleya19d3532019-09-30 21:54:39 +0000261 prop_list = getattr(options, 'properties', [])
262 properties = dict(x.split('=', 1) for x in prop_list)
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +0000263 for key, val in properties.items():
machenbach@chromium.org45453142015-09-15 08:45:22 +0000264 try:
265 properties[key] = json.loads(val)
266 except ValueError:
267 pass # If a value couldn't be evaluated, treat it as a string.
268 return properties
269
270
Edward Lemur4c707a22019-09-24 21:13:43 +0000271def _call_buildbucket(http, buildbucket_host, method, request):
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000272 """Calls a buildbucket v2 method and returns the parsed json response."""
273 headers = {
274 'Accept': 'application/json',
275 'Content-Type': 'application/json',
276 }
277 request = json.dumps(request)
278 url = 'https://%s/prpc/buildbucket.v2.Builds/%s' % (buildbucket_host, method)
279
280 logging.info('POST %s with %s' % (url, request))
281
282 attempts = 1
283 time_to_sleep = 1
284 while True:
285 response, content = http.request(url, 'POST', body=request, headers=headers)
286 if response.status == 200:
287 return json.loads(content[4:])
288 if attempts >= MAX_ATTEMPTS or 400 <= response.status < 500:
289 msg = '%s error when calling POST %s with %s: %s' % (
290 response.status, url, request, content)
291 raise BuildbucketResponseException(msg)
292 logging.debug(
293 '%s error when calling POST %s with %s. '
294 'Sleeping for %d seconds and retrying...' % (
295 response.status, url, request, time_to_sleep))
296 time.sleep(time_to_sleep)
297 time_to_sleep *= 2
298 attempts += 1
299
300 assert False, 'unreachable'
301
302
Edward Lemur6215c792019-10-03 21:59:05 +0000303def _parse_bucket(raw_bucket):
304 legacy = True
305 project = bucket = None
306 if '/' in raw_bucket:
307 legacy = False
308 project, bucket = raw_bucket.split('/', 1)
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000309 # Assume luci.<project>.<bucket>.
Edward Lemur6215c792019-10-03 21:59:05 +0000310 elif raw_bucket.startswith('luci.'):
311 project, bucket = raw_bucket[len('luci.'):].split('.', 1)
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000312 # Otherwise, assume prefix is also the project name.
Edward Lemur6215c792019-10-03 21:59:05 +0000313 elif '.' in raw_bucket:
314 project = raw_bucket.split('.')[0]
315 bucket = raw_bucket
316 # Legacy buckets.
Edward Lemur45768512020-03-02 19:03:14 +0000317 if legacy and project and bucket:
Edward Lemur6215c792019-10-03 21:59:05 +0000318 print('WARNING Please use %s/%s to specify the bucket.' % (project, bucket))
319 return project, bucket
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000320
321
Quinten Yearsley777660f2020-03-04 23:37:06 +0000322def _trigger_tryjobs(changelist, jobs, options, patchset):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000323 """Sends a request to Buildbucket to trigger tryjobs for a changelist.
qyearsley1fdfcb62016-10-24 13:22:03 -0700324
325 Args:
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000326 changelist: Changelist that the tryjobs are associated with.
Edward Lemur45768512020-03-02 19:03:14 +0000327 jobs: A list of (project, bucket, builder).
qyearsley1fdfcb62016-10-24 13:22:03 -0700328 options: Command-line options.
329 """
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000330 print('Scheduling jobs on:')
Edward Lemur45768512020-03-02 19:03:14 +0000331 for project, bucket, builder in jobs:
332 print(' %s/%s: %s' % (project, bucket, builder))
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000333 print('To see results here, run: git cl try-results')
334 print('To see results in browser, run: git cl web')
tandriide281ae2016-10-12 06:02:30 -0700335
Quinten Yearsley777660f2020-03-04 23:37:06 +0000336 requests = _make_tryjob_schedule_requests(changelist, jobs, options, patchset)
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +0000337 if not requests:
338 return
339
Edward Lemur5b929a42019-10-21 17:57:39 +0000340 http = auth.Authenticator().authorize(httplib2.Http())
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +0000341 http.force_exception_to_status_code = True
342
343 batch_request = {'requests': requests}
344 batch_response = _call_buildbucket(
345 http, options.buildbucket_host, 'Batch', batch_request)
346
347 errors = [
348 ' ' + response['error']['message']
349 for response in batch_response.get('responses', [])
350 if 'error' in response
351 ]
352 if errors:
353 raise BuildbucketResponseException(
354 'Failed to schedule builds for some bots:\n%s' % '\n'.join(errors))
355
356
Quinten Yearsley777660f2020-03-04 23:37:06 +0000357def _make_tryjob_schedule_requests(changelist, jobs, options, patchset):
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +0000358 """Constructs requests for Buildbucket to trigger tryjobs."""
Edward Lemurf0faf482019-09-25 20:40:17 +0000359 gerrit_changes = [changelist.GetGerritChange(patchset)]
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +0000360 shared_properties = {
361 'category': options.ensure_value('category', 'git_cl_try')
362 }
363 if options.ensure_value('clobber', False):
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000364 shared_properties['clobber'] = True
365 shared_properties.update(_get_properties_from_options(options) or {})
366
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +0000367 shared_tags = [{'key': 'user_agent', 'value': 'git_cl_try'}]
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +0000368 if options.ensure_value('retry_failed', False):
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +0000369 shared_tags.append({'key': 'retry_failed',
370 'value': '1'})
371
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000372 requests = []
Edward Lemur45768512020-03-02 19:03:14 +0000373 for (project, bucket, builder) in jobs:
374 properties = shared_properties.copy()
375 if 'presubmit' in builder.lower():
376 properties['dry_run'] = 'true'
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000377
Edward Lemur45768512020-03-02 19:03:14 +0000378 requests.append({
379 'scheduleBuild': {
380 'requestId': str(uuid.uuid4()),
381 'builder': {
382 'project': getattr(options, 'project', None) or project,
383 'bucket': bucket,
384 'builder': builder,
385 },
386 'gerritChanges': gerrit_changes,
387 'properties': properties,
388 'tags': [
389 {'key': 'builder', 'value': builder},
390 ] + shared_tags,
391 }
392 })
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000393
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +0000394 if options.ensure_value('revision', None):
Josip Sokcevic9011a5b2021-02-12 18:59:44 +0000395 remote, remote_branch = changelist.GetRemoteBranch()
Edward Lemur45768512020-03-02 19:03:14 +0000396 requests[-1]['scheduleBuild']['gitilesCommit'] = {
397 'host': gerrit_changes[0]['host'],
398 'project': gerrit_changes[0]['project'],
Josip Sokcevic9011a5b2021-02-12 18:59:44 +0000399 'id': options.revision,
400 'ref': GetTargetRef(remote, remote_branch, None)
Edward Lemur45768512020-03-02 19:03:14 +0000401 }
Anthony Polito1a5fe232020-01-24 23:17:52 +0000402
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +0000403 return requests
kjellander@chromium.org44424542015-06-02 18:35:29 +0000404
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000405
Quinten Yearsley777660f2020-03-04 23:37:06 +0000406def _fetch_tryjobs(changelist, buildbucket_host, patchset=None):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000407 """Fetches tryjobs from buildbucket.
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000408
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000409 Returns list of buildbucket.v2.Build with the try jobs for the changelist.
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000410 """
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +0000411 fields = ['id', 'builder', 'status', 'createTime', 'tags']
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000412 request = {
413 'predicate': {
414 'gerritChanges': [changelist.GetGerritChange(patchset)],
415 },
416 'fields': ','.join('builds.*.' + field for field in fields),
417 }
tandrii221ab252016-10-06 08:12:04 -0700418
Edward Lemur5b929a42019-10-21 17:57:39 +0000419 authenticator = auth.Authenticator()
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000420 if authenticator.has_cached_credentials():
421 http = authenticator.authorize(httplib2.Http())
422 else:
vapiera7fbd5a2016-06-16 09:17:49 -0700423 print('Warning: Some results might be missing because %s' %
424 # Get the message on how to login.
Andrii Shyshkalov2517afd2021-01-19 17:07:43 +0000425 (str(auth.LoginRequiredError()),))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000426 http = httplib2.Http()
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000427 http.force_exception_to_status_code = True
428
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000429 response = _call_buildbucket(http, buildbucket_host, 'SearchBuilds', request)
430 return response.get('builds', [])
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000431
Edward Lemur45768512020-03-02 19:03:14 +0000432
Edward Lemur5b929a42019-10-21 17:57:39 +0000433def _fetch_latest_builds(changelist, buildbucket_host, latest_patchset=None):
Quinten Yearsley983111f2019-09-26 17:18:48 +0000434 """Fetches builds from the latest patchset that has builds (within
435 the last few patchsets).
436
437 Args:
Quinten Yearsley983111f2019-09-26 17:18:48 +0000438 changelist (Changelist): The CL to fetch builds for
439 buildbucket_host (str): Buildbucket host, e.g. "cr-buildbucket.appspot.com"
Andrii Shyshkalov1ad58112019-10-08 01:46:14 +0000440 lastest_patchset(int|NoneType): the patchset to start fetching builds from.
441 If None (default), starts with the latest available patchset.
Quinten Yearsley983111f2019-09-26 17:18:48 +0000442 Returns:
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000443 A tuple (builds, patchset) where builds is a list of buildbucket.v2.Build,
444 and patchset is the patchset number where those builds came from.
Quinten Yearsley983111f2019-09-26 17:18:48 +0000445 """
446 assert buildbucket_host
447 assert changelist.GetIssue(), 'CL must be uploaded first'
448 assert changelist.GetCodereviewServer(), 'CL must be uploaded first'
Andrii Shyshkalov1ad58112019-10-08 01:46:14 +0000449 if latest_patchset is None:
450 assert changelist.GetMostRecentPatchset()
451 ps = changelist.GetMostRecentPatchset()
452 else:
453 assert latest_patchset > 0, latest_patchset
454 ps = latest_patchset
455
Quinten Yearsley983111f2019-09-26 17:18:48 +0000456 min_ps = max(1, ps - 5)
457 while ps >= min_ps:
Quinten Yearsley777660f2020-03-04 23:37:06 +0000458 builds = _fetch_tryjobs(changelist, buildbucket_host, patchset=ps)
Quinten Yearsley983111f2019-09-26 17:18:48 +0000459 if len(builds):
460 return builds, ps
461 ps -= 1
462 return [], 0
463
464
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +0000465def _filter_failed_for_retry(all_builds):
466 """Returns a list of buckets/builders that are worth retrying.
Quinten Yearsley983111f2019-09-26 17:18:48 +0000467
468 Args:
Quinten Yearsley777660f2020-03-04 23:37:06 +0000469 all_builds (list): Builds, in the format returned by _fetch_tryjobs,
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000470 i.e. a list of buildbucket.v2.Builds which includes status and builder
471 info.
Quinten Yearsley983111f2019-09-26 17:18:48 +0000472
473 Returns:
Edward Lemur45768512020-03-02 19:03:14 +0000474 A dict {(proj, bucket): [builders]}. This is the same format accepted by
Quinten Yearsley777660f2020-03-04 23:37:06 +0000475 _trigger_tryjobs.
Quinten Yearsley983111f2019-09-26 17:18:48 +0000476 """
Edward Lemur45768512020-03-02 19:03:14 +0000477 grouped = {}
478 for build in all_builds:
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +0000479 builder = build['builder']
Edward Lemur45768512020-03-02 19:03:14 +0000480 key = (builder['project'], builder['bucket'], builder['builder'])
481 grouped.setdefault(key, []).append(build)
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +0000482
Edward Lemur45768512020-03-02 19:03:14 +0000483 jobs = []
484 for (project, bucket, builder), builds in grouped.items():
485 if 'triggered' in builder:
486 print('WARNING: Not scheduling %s. Triggered bots require an initial job '
487 'from a parent. Please schedule a manual job for the parent '
488 'instead.')
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +0000489 continue
490 if any(b['status'] in ('STARTED', 'SCHEDULED') for b in builds):
491 # Don't retry if any are running.
492 continue
Edward Lemur45768512020-03-02 19:03:14 +0000493 # If builder had several builds, retry only if the last one failed.
494 # This is a bit different from CQ, which would re-use *any* SUCCESS-full
495 # build, but in case of retrying failed jobs retrying a flaky one makes
496 # sense.
497 builds = sorted(builds, key=lambda b: b['createTime'])
498 if builds[-1]['status'] not in ('FAILURE', 'INFRA_FAILURE'):
499 continue
500 # Don't retry experimental build previously triggered by CQ.
501 if any(t['key'] == 'cq_experimental' and t['value'] == 'true'
502 for t in builds[-1]['tags']):
503 continue
504 jobs.append((project, bucket, builder))
505
506 # Sort the jobs to make testing easier.
507 return sorted(jobs)
Quinten Yearsley983111f2019-09-26 17:18:48 +0000508
509
Quinten Yearsley777660f2020-03-04 23:37:06 +0000510def _print_tryjobs(options, builds):
511 """Prints nicely result of _fetch_tryjobs."""
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000512 if not builds:
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000513 print('No tryjobs scheduled.')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000514 return
515
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000516 longest_builder = max(len(b['builder']['builder']) for b in builds)
517 name_fmt = '{builder:<%d}' % longest_builder
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000518 if options.print_master:
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000519 longest_bucket = max(len(b['builder']['bucket']) for b in builds)
520 name_fmt = ('{bucket:>%d} ' % longest_bucket) + name_fmt
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000521
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000522 builds_by_status = {}
523 for b in builds:
524 builds_by_status.setdefault(b['status'], []).append({
525 'id': b['id'],
526 'name': name_fmt.format(
527 builder=b['builder']['builder'], bucket=b['builder']['bucket']),
528 })
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000529
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000530 sort_key = lambda b: (b['name'], b['id'])
531
532 def print_builds(title, builds, fmt=None, color=None):
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000533 """Pop matching builds from `builds` dict and print them."""
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000534 if not builds:
535 return
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000536
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000537 fmt = fmt or '{name} https://ci.chromium.org/b/{id}'
tandrii@chromium.org6cf98c82016-03-15 11:56:00 +0000538 if not options.color or color is None:
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000539 colorize = lambda x: x
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000540 else:
541 colorize = lambda x: '%s%s%s' % (color, x, Fore.RESET)
542
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000543 print(colorize(title))
544 for b in sorted(builds, key=sort_key):
545 print(' ', colorize(fmt.format(**b)))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000546
547 total = len(builds)
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000548 print_builds(
549 'Successes:', builds_by_status.pop('SUCCESS', []), color=Fore.GREEN)
550 print_builds(
551 'Infra Failures:', builds_by_status.pop('INFRA_FAILURE', []),
552 color=Fore.MAGENTA)
553 print_builds('Failures:', builds_by_status.pop('FAILURE', []), color=Fore.RED)
554 print_builds('Canceled:', builds_by_status.pop('CANCELED', []), fmt='{name}',
555 color=Fore.MAGENTA)
Andrii Shyshkalov792630c2020-10-19 16:47:44 +0000556 print_builds('Started:', builds_by_status.pop('STARTED', []),
557 color=Fore.YELLOW)
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000558 print_builds(
559 'Scheduled:', builds_by_status.pop('SCHEDULED', []), fmt='{name} id={id}')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000560 # The last section is just in case buildbucket API changes OR there is a bug.
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000561 print_builds(
562 'Other:', sum(builds_by_status.values(), []), fmt='{name} id={id}')
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000563 print('Total: %d tryjobs' % total)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000564
565
Aiden Bennerc08566e2018-10-03 17:52:42 +0000566def _ComputeDiffLineRanges(files, upstream_commit):
567 """Gets the changed line ranges for each file since upstream_commit.
568
569 Parses a git diff on provided files and returns a dict that maps a file name
570 to an ordered list of range tuples in the form (start_line, count).
571 Ranges are in the same format as a git diff.
572 """
573 # If files is empty then diff_output will be a full diff.
574 if len(files) == 0:
575 return {}
576
Aiden Benner6c18a1a2018-11-23 20:18:23 +0000577 # Take the git diff and find the line ranges where there are changes.
Jamie Madill3671a6a2019-10-24 15:13:21 +0000578 diff_cmd = BuildGitDiffCmd('-U0', upstream_commit, files, allow_prefix=True)
Aiden Bennerc08566e2018-10-03 17:52:42 +0000579 diff_output = RunGit(diff_cmd)
580
581 pattern = r'(?:^diff --git a/(?:.*) b/(.*))|(?:^@@.*\+(.*) @@)'
582 # 2 capture groups
583 # 0 == fname of diff file
584 # 1 == 'diff_start,diff_count' or 'diff_start'
585 # will match each of
586 # diff --git a/foo.foo b/foo.py
587 # @@ -12,2 +14,3 @@
588 # @@ -12,2 +17 @@
589 # running re.findall on the above string with pattern will give
590 # [('foo.py', ''), ('', '14,3'), ('', '17')]
591
592 curr_file = None
593 line_diffs = {}
594 for match in re.findall(pattern, diff_output, flags=re.MULTILINE):
595 if match[0] != '':
596 # Will match the second filename in diff --git a/a.py b/b.py.
597 curr_file = match[0]
598 line_diffs[curr_file] = []
599 else:
600 # Matches +14,3
601 if ',' in match[1]:
602 diff_start, diff_count = match[1].split(',')
603 else:
604 # Single line changes are of the form +12 instead of +12,1.
605 diff_start = match[1]
606 diff_count = 1
607
608 diff_start = int(diff_start)
609 diff_count = int(diff_count)
610
611 # If diff_count == 0 this is a removal we can ignore.
612 line_diffs[curr_file].append((diff_start, diff_count))
613
614 return line_diffs
615
616
Aiden Benner99b0ccb2018-11-20 19:53:31 +0000617def _FindYapfConfigFile(fpath, yapf_config_cache, top_dir=None):
Aiden Bennerc08566e2018-10-03 17:52:42 +0000618 """Checks if a yapf file is in any parent directory of fpath until top_dir.
619
Aiden Benner99b0ccb2018-11-20 19:53:31 +0000620 Recursively checks parent directories to find yapf file and if no yapf file
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000621 is found returns None. Uses yapf_config_cache as a cache for previously found
622 configs.
Aiden Bennerc08566e2018-10-03 17:52:42 +0000623 """
Aiden Benner99b0ccb2018-11-20 19:53:31 +0000624 fpath = os.path.abspath(fpath)
Aiden Bennerc08566e2018-10-03 17:52:42 +0000625 # Return result if we've already computed it.
626 if fpath in yapf_config_cache:
627 return yapf_config_cache[fpath]
628
Aiden Benner99b0ccb2018-11-20 19:53:31 +0000629 parent_dir = os.path.dirname(fpath)
630 if os.path.isfile(fpath):
631 ret = _FindYapfConfigFile(parent_dir, yapf_config_cache, top_dir)
Aiden Bennerc08566e2018-10-03 17:52:42 +0000632 else:
Aiden Benner99b0ccb2018-11-20 19:53:31 +0000633 # Otherwise fpath is a directory
634 yapf_file = os.path.join(fpath, YAPF_CONFIG_FILENAME)
635 if os.path.isfile(yapf_file):
636 ret = yapf_file
637 elif fpath == top_dir or parent_dir == fpath:
638 # If we're at the top level directory, or if we're at root
639 # there is no provided style.
640 ret = None
641 else:
642 # Otherwise recurse on the current directory.
643 ret = _FindYapfConfigFile(parent_dir, yapf_config_cache, top_dir)
Aiden Bennerc08566e2018-10-03 17:52:42 +0000644 yapf_config_cache[fpath] = ret
645 return ret
646
647
Brian Sheedyb4307d52019-12-02 19:18:17 +0000648def _GetYapfIgnorePatterns(top_dir):
649 """Returns all patterns in the .yapfignore file.
Brian Sheedy59b06a82019-10-14 17:03:29 +0000650
651 yapf is supposed to handle the ignoring of files listed in .yapfignore itself,
652 but this functionality appears to break when explicitly passing files to
653 yapf for formatting. According to
Josip Sokcevicc39ab992020-09-24 20:09:15 +0000654 https://github.com/google/yapf/blob/HEAD/README.rst#excluding-files-from-formatting-yapfignore,
Brian Sheedy59b06a82019-10-14 17:03:29 +0000655 the .yapfignore file should be in the directory that yapf is invoked from,
656 which we assume to be the top level directory in this case.
657
658 Args:
659 top_dir: The top level directory for the repository being formatted.
660
661 Returns:
Brian Sheedyb4307d52019-12-02 19:18:17 +0000662 A set of all fnmatch patterns to be ignored.
Brian Sheedy59b06a82019-10-14 17:03:29 +0000663 """
664 yapfignore_file = os.path.join(top_dir, '.yapfignore')
Brian Sheedyb4307d52019-12-02 19:18:17 +0000665 ignore_patterns = set()
Brian Sheedy59b06a82019-10-14 17:03:29 +0000666 if not os.path.exists(yapfignore_file):
Brian Sheedyb4307d52019-12-02 19:18:17 +0000667 return ignore_patterns
Brian Sheedy59b06a82019-10-14 17:03:29 +0000668
Anthony Politoc64e3902021-04-30 21:55:25 +0000669 for line in gclient_utils.FileRead(yapfignore_file).split('\n'):
670 stripped_line = line.strip()
671 # Comments and blank lines should be ignored.
672 if stripped_line.startswith('#') or stripped_line == '':
673 continue
674 ignore_patterns.add(stripped_line)
Brian Sheedyb4307d52019-12-02 19:18:17 +0000675 return ignore_patterns
676
677
678def _FilterYapfIgnoredFiles(filepaths, patterns):
679 """Filters out any filepaths that match any of the given patterns.
680
681 Args:
682 filepaths: An iterable of strings containing filepaths to filter.
683 patterns: An iterable of strings containing fnmatch patterns to filter on.
684
685 Returns:
686 A list of strings containing all the elements of |filepaths| that did not
687 match any of the patterns in |patterns|.
688 """
689 # Not inlined so that tests can use the same implementation.
690 return [f for f in filepaths
691 if not any(fnmatch.fnmatch(f, p) for p in patterns)]
Brian Sheedy59b06a82019-10-14 17:03:29 +0000692
693
Aaron Gable13101a62018-02-09 13:20:41 -0800694def print_stats(args):
maruel@chromium.org49e3d802012-07-18 23:54:45 +0000695 """Prints statistics about the change to the user."""
696 # --no-ext-diff is broken in some versions of Git, so try to work around
697 # this by overriding the environment (but there is still a problem if the
698 # git config key "diff.external" is used).
thestig@chromium.org8b0553c2014-02-11 00:33:37 +0000699 env = GetNoGitPagerEnv()
maruel@chromium.org49e3d802012-07-18 23:54:45 +0000700 if 'GIT_EXTERNAL_DIFF' in env:
701 del env['GIT_EXTERNAL_DIFF']
iannucci@chromium.org79540052012-10-19 23:15:26 +0000702
maruel@chromium.org49e3d802012-07-18 23:54:45 +0000703 return subprocess2.call(
Aaron Gable13101a62018-02-09 13:20:41 -0800704 ['git', 'diff', '--no-ext-diff', '--stat', '-l100000', '-C50'] + args,
Edward Lemur0db01f02019-11-12 22:01:51 +0000705 env=env)
maruel@chromium.org49e3d802012-07-18 23:54:45 +0000706
707
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000708class BuildbucketResponseException(Exception):
709 pass
710
711
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000712class Settings(object):
713 def __init__(self):
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000714 self.cc = None
thestig@chromium.org7a54e812014-02-11 19:57:22 +0000715 self.root = None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000716 self.tree_status_url = None
717 self.viewvc_url = None
718 self.updated = False
ukai@chromium.orge8077812012-02-03 03:41:46 +0000719 self.is_gerrit = None
bauerb@chromium.org54b400c2016-01-14 10:08:25 +0000720 self.squash_gerrit_uploads = None
tandrii@chromium.org28253532016-04-14 13:46:56 +0000721 self.gerrit_skip_ensure_authenticated = None
jbroman@chromium.org615a2622013-05-03 13:20:14 +0000722 self.git_editor = None
Jamie Madilldc4d19e2019-10-24 21:50:02 +0000723 self.format_full_by_default = None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000724
Edward Lemur26964072020-02-19 19:18:51 +0000725 def _LazyUpdateIfNeeded(self):
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000726 """Updates the settings from a codereview.settings file, if available."""
Edward Lemur26964072020-02-19 19:18:51 +0000727 if self.updated:
728 return
pgervais@chromium.org87884cc2014-01-03 22:23:41 +0000729
Edward Lemur26964072020-02-19 19:18:51 +0000730 # The only value that actually changes the behavior is
731 # autoupdate = "false". Everything else means "true".
732 autoupdate = (
733 scm.GIT.GetConfig(self.GetRoot(), 'rietveld.autoupdate', '').lower())
734
735 cr_settings_file = FindCodereviewSettingsFile()
736 if autoupdate != 'false' and cr_settings_file:
737 LoadCodereviewSettingsFromFile(cr_settings_file)
738 cr_settings_file.close()
739
740 self.updated = True
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000741
thestig@chromium.org7a54e812014-02-11 19:57:22 +0000742 @staticmethod
743 def GetRelativeRoot():
Edward Lesmes50da7702020-03-30 19:23:43 +0000744 return scm.GIT.GetCheckoutRoot('.')
thestig@chromium.org8b0553c2014-02-11 00:33:37 +0000745
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000746 def GetRoot(self):
thestig@chromium.org7a54e812014-02-11 19:57:22 +0000747 if self.root is None:
748 self.root = os.path.abspath(self.GetRelativeRoot())
749 return self.root
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000750
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000751 def GetTreeStatusUrl(self, error_ok=False):
752 if not self.tree_status_url:
Edward Lemur26964072020-02-19 19:18:51 +0000753 self.tree_status_url = self._GetConfig('rietveld.tree-status-url')
754 if self.tree_status_url is None and not error_ok:
755 DieWithError(
756 'You must configure your tree status URL by running '
757 '"git cl config".')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000758 return self.tree_status_url
759
760 def GetViewVCUrl(self):
761 if not self.viewvc_url:
Edward Lemur26964072020-02-19 19:18:51 +0000762 self.viewvc_url = self._GetConfig('rietveld.viewvc-url')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000763 return self.viewvc_url
764
rmistry@google.com90752582014-01-14 21:04:50 +0000765 def GetBugPrefix(self):
Edward Lemur26964072020-02-19 19:18:51 +0000766 return self._GetConfig('rietveld.bug-prefix')
rmistry@google.com78948ed2015-07-08 23:09:57 +0000767
rmistry@google.com5626a922015-02-26 14:03:30 +0000768 def GetRunPostUploadHook(self):
Edward Lemur61ea3072018-12-01 00:34:36 +0000769 run_post_upload_hook = self._GetConfig(
Edward Lemur26964072020-02-19 19:18:51 +0000770 'rietveld.run-post-upload-hook')
rmistry@google.com5626a922015-02-26 14:03:30 +0000771 return run_post_upload_hook == "True"
772
bauerb@chromium.orgae6df352011-04-06 17:40:39 +0000773 def GetDefaultCCList(self):
Edward Lemur26964072020-02-19 19:18:51 +0000774 return self._GetConfig('rietveld.cc')
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000775
Dirk Pranke6f0df682021-06-25 00:42:33 +0000776 def GetUsePython3(self):
777 return self._GetConfig('rietveld.use-python3')
778
bauerb@chromium.org54b400c2016-01-14 10:08:25 +0000779 def GetSquashGerritUploads(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000780 """Returns True if uploads to Gerrit should be squashed by default."""
bauerb@chromium.org54b400c2016-01-14 10:08:25 +0000781 if self.squash_gerrit_uploads is None:
Edward Lesmes4de54132020-05-05 19:41:33 +0000782 self.squash_gerrit_uploads = self.GetSquashGerritUploadsOverride()
783 if self.squash_gerrit_uploads is None:
Edward Lemur26964072020-02-19 19:18:51 +0000784 # Default is squash now (http://crbug.com/611892#c23).
785 self.squash_gerrit_uploads = self._GetConfig(
786 'gerrit.squash-uploads').lower() != 'false'
bauerb@chromium.org54b400c2016-01-14 10:08:25 +0000787 return self.squash_gerrit_uploads
788
Edward Lesmes4de54132020-05-05 19:41:33 +0000789 def GetSquashGerritUploadsOverride(self):
790 """Return True or False if codereview.settings should be overridden.
791
792 Returns None if no override has been defined.
793 """
794 # See also http://crbug.com/611892#c23
795 result = self._GetConfig('gerrit.override-squash-uploads').lower()
796 if result == 'true':
797 return True
798 if result == 'false':
799 return False
800 return None
801
tandrii@chromium.org28253532016-04-14 13:46:56 +0000802 def GetGerritSkipEnsureAuthenticated(self):
803 """Return True if EnsureAuthenticated should not be done for Gerrit
804 uploads."""
805 if self.gerrit_skip_ensure_authenticated is None:
Edward Lemur26964072020-02-19 19:18:51 +0000806 self.gerrit_skip_ensure_authenticated = self._GetConfig(
807 'gerrit.skip-ensure-authenticated').lower() == 'true'
tandrii@chromium.org28253532016-04-14 13:46:56 +0000808 return self.gerrit_skip_ensure_authenticated
809
jbroman@chromium.org615a2622013-05-03 13:20:14 +0000810 def GetGitEditor(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000811 """Returns the editor specified in the git config, or None if none is."""
jbroman@chromium.org615a2622013-05-03 13:20:14 +0000812 if self.git_editor is None:
Raul Tambre5a525872019-02-12 19:08:08 +0000813 # Git requires single quotes for paths with spaces. We need to replace
814 # them with double quotes for Windows to treat such paths as a single
815 # path.
Edward Lemur26964072020-02-19 19:18:51 +0000816 self.git_editor = self._GetConfig('core.editor').replace('\'', '"')
jbroman@chromium.org615a2622013-05-03 13:20:14 +0000817 return self.git_editor or None
818
thestig@chromium.org44202a22014-03-11 19:22:18 +0000819 def GetLintRegex(self):
Edward Lemur26964072020-02-19 19:18:51 +0000820 return self._GetConfig('rietveld.cpplint-regex', DEFAULT_LINT_REGEX)
thestig@chromium.org44202a22014-03-11 19:22:18 +0000821
822 def GetLintIgnoreRegex(self):
Edward Lemur26964072020-02-19 19:18:51 +0000823 return self._GetConfig(
824 'rietveld.cpplint-ignore-regex', DEFAULT_LINT_IGNORE_REGEX)
thestig@chromium.org44202a22014-03-11 19:22:18 +0000825
Jamie Madilldc4d19e2019-10-24 21:50:02 +0000826 def GetFormatFullByDefault(self):
827 if self.format_full_by_default is None:
828 result = (
829 RunGit(['config', '--bool', 'rietveld.format-full-by-default'],
830 error_ok=True).strip())
831 self.format_full_by_default = (result == 'true')
832 return self.format_full_by_default
833
Edward Lemur26964072020-02-19 19:18:51 +0000834 def _GetConfig(self, key, default=''):
835 self._LazyUpdateIfNeeded()
836 return scm.GIT.GetConfig(self.GetRoot(), key, default)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000837
838
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +0000839class _CQState(object):
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +0000840 """Enum for states of CL with respect to CQ."""
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +0000841 NONE = 'none'
Greg Gutermanbe5fccd2021-06-14 17:58:20 +0000842 QUICK_RUN = 'quick_run'
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +0000843 DRY_RUN = 'dry_run'
844 COMMIT = 'commit'
845
Greg Gutermanbe5fccd2021-06-14 17:58:20 +0000846 ALL_STATES = [NONE, QUICK_RUN, DRY_RUN, COMMIT]
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +0000847
848
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000849class _ParsedIssueNumberArgument(object):
Edward Lemurf38bc172019-09-03 21:02:13 +0000850 def __init__(self, issue=None, patchset=None, hostname=None):
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000851 self.issue = issue
852 self.patchset = patchset
853 self.hostname = hostname
854
855 @property
856 def valid(self):
857 return self.issue is not None
858
859
Edward Lemurf38bc172019-09-03 21:02:13 +0000860def ParseIssueNumberArgument(arg):
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000861 """Parses the issue argument and returns _ParsedIssueNumberArgument."""
862 fail_result = _ParsedIssueNumberArgument()
863
Edward Lemur678a6842019-10-03 22:25:05 +0000864 if isinstance(arg, int):
865 return _ParsedIssueNumberArgument(issue=arg)
866 if not isinstance(arg, basestring):
867 return fail_result
868
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000869 if arg.isdigit():
Edward Lemurf38bc172019-09-03 21:02:13 +0000870 return _ParsedIssueNumberArgument(issue=int(arg))
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000871 if not arg.startswith('http'):
872 return fail_result
Aaron Gableaee6c852017-06-26 12:49:01 -0700873
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000874 url = gclient_utils.UpgradeToHttps(arg)
Andrii Shyshkalov8aebb602020-04-16 22:10:27 +0000875 for gerrit_url, short_url in _KNOWN_GERRIT_TO_SHORT_URLS.items():
876 if url.startswith(short_url):
877 url = gerrit_url + url[len(short_url):]
878 break
879
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000880 try:
Edward Lemur79d4f992019-11-11 23:49:02 +0000881 parsed_url = urllib.parse.urlparse(url)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000882 except ValueError:
883 return fail_result
Andrii Shyshkalov28d840e2017-04-10 15:45:09 +0200884
Edward Lemur678a6842019-10-03 22:25:05 +0000885 # Gerrit's new UI is https://domain/c/project/+/<issue_number>[/[patchset]]
886 # But old GWT UI is https://domain/#/c/project/+/<issue_number>[/[patchset]]
887 # Short urls like https://domain/<issue_number> can be used, but don't allow
888 # specifying the patchset (you'd 404), but we allow that here.
889 if parsed_url.path == '/':
890 part = parsed_url.fragment
891 else:
892 part = parsed_url.path
893
894 match = re.match(
895 r'(/c(/.*/\+)?)?/(?P<issue>\d+)(/(?P<patchset>\d+)?/?)?$', part)
896 if not match:
897 return fail_result
898
899 issue = int(match.group('issue'))
900 patchset = match.group('patchset')
901 return _ParsedIssueNumberArgument(
902 issue=issue,
903 patchset=int(patchset) if patchset else None,
904 hostname=parsed_url.netloc)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000905
906
Andrii Shyshkalovb07575f2018-10-16 06:16:21 +0000907def _create_description_from_log(args):
908 """Pulls out the commit log to use as a base for the CL description."""
909 log_args = []
910 if len(args) == 1 and not args[0].endswith('.'):
911 log_args = [args[0] + '..']
912 elif len(args) == 1 and args[0].endswith('...'):
913 log_args = [args[0][:-1]]
914 elif len(args) == 2:
915 log_args = [args[0] + '..' + args[1]]
916 else:
917 log_args = args[:] # Hope for the best!
Manh Nguyene3644862020-08-05 18:25:46 +0000918 return RunGit(['log', '--pretty=format:%B%n'] + log_args)
Andrii Shyshkalovb07575f2018-10-16 06:16:21 +0000919
920
Aaron Gablea45ee112016-11-22 15:14:38 -0800921class GerritChangeNotExists(Exception):
tandriic2405f52016-10-10 08:13:15 -0700922 def __init__(self, issue, url):
923 self.issue = issue
924 self.url = url
Aaron Gablea45ee112016-11-22 15:14:38 -0800925 super(GerritChangeNotExists, self).__init__()
tandriic2405f52016-10-10 08:13:15 -0700926
927 def __str__(self):
Aaron Gablea45ee112016-11-22 15:14:38 -0800928 return 'change %s at %s does not exist or you have no access to it' % (
tandriic2405f52016-10-10 08:13:15 -0700929 self.issue, self.url)
930
931
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +0100932_CommentSummary = collections.namedtuple(
Quinten Yearsley0e617c02019-02-20 00:37:03 +0000933 '_CommentSummary', ['date', 'message', 'sender', 'autogenerated',
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +0100934 # TODO(tandrii): these two aren't known in Gerrit.
935 'approval', 'disapproval'])
936
937
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000938class Changelist(object):
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +0000939 """Changelist works with one changelist in local branch.
940
tandrii@chromium.org8930b3d2016-04-13 14:47:02 +0000941 Notes:
942 * Not safe for concurrent multi-{thread,process} use.
943 * Caches values from current branch. Therefore, re-use after branch change
tandrii5d48c322016-08-18 16:19:37 -0700944 with great care.
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +0000945 """
946
Sigurd Schneider9abde8c2020-11-17 08:44:52 +0000947 def __init__(self,
948 branchref=None,
949 issue=None,
950 codereview_host=None,
951 commit_date=None):
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +0000952 """Create a new ChangeList instance.
953
Edward Lemurf38bc172019-09-03 21:02:13 +0000954 **kwargs will be passed directly to Gerrit implementation.
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +0000955 """
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000956 # Poke settings so we get the "configure your server" message if necessary.
maruel@chromium.org379d07a2011-11-30 14:58:10 +0000957 global settings
958 if not settings:
959 # Happens when git_cl.py is used as a utility library.
960 settings = Settings()
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +0000961
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000962 self.branchref = branchref
963 if self.branchref:
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +0000964 assert branchref.startswith('refs/heads/')
Edward Lemur85153282020-02-14 22:06:29 +0000965 self.branch = scm.GIT.ShortBranchName(self.branchref)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000966 else:
967 self.branch = None
Sigurd Schneider9abde8c2020-11-17 08:44:52 +0000968 self.commit_date = commit_date
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000969 self.upstream_branch = None
maruel@chromium.org1033efd2013-07-23 23:25:09 +0000970 self.lookedup_issue = False
971 self.issue = issue or None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000972 self.description = None
maruel@chromium.org1033efd2013-07-23 23:25:09 +0000973 self.lookedup_patchset = False
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000974 self.patchset = None
bauerb@chromium.orgae6df352011-04-06 17:40:39 +0000975 self.cc = None
Daniel Cheng7227d212017-11-17 08:12:37 -0800976 self.more_cc = []
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +0000977 self._remote = None
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +0000978 self._cached_remote_url = (False, None) # (is_cached, value)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +0000979
Edward Lemur125d60a2019-09-13 18:25:41 +0000980 # Lazily cached values.
981 self._gerrit_host = None # e.g. chromium-review.googlesource.com
982 self._gerrit_server = None # e.g. https://chromium-review.googlesource.com
Edward Lesmese1576912021-02-16 21:53:34 +0000983 self._owners_client = None
Edward Lemur125d60a2019-09-13 18:25:41 +0000984 # Map from change number (issue) to its detail cache.
985 self._detail_cache = {}
986
987 if codereview_host is not None:
988 assert not codereview_host.startswith('https://'), codereview_host
989 self._gerrit_host = codereview_host
990 self._gerrit_server = 'https://%s' % codereview_host
bauerb@chromium.orgae6df352011-04-06 17:40:39 +0000991
Edward Lesmese1576912021-02-16 21:53:34 +0000992 @property
993 def owners_client(self):
994 if self._owners_client is None:
995 remote, remote_branch = self.GetRemoteBranch()
996 branch = GetTargetRef(remote, remote_branch, None)
997 self._owners_client = owners_client.GetCodeOwnersClient(
998 root=settings.GetRoot(),
Edward Lesmes1eaaab52021-03-02 23:52:54 +0000999 upstream=self.GetCommonAncestorWithUpstream(),
Edward Lesmese1576912021-02-16 21:53:34 +00001000 host=self.GetGerritHost(),
1001 project=self.GetGerritProject(),
1002 branch=branch)
1003 return self._owners_client
1004
bauerb@chromium.orgae6df352011-04-06 17:40:39 +00001005 def GetCCList(self):
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001006 """Returns the users cc'd on this CL.
bauerb@chromium.orgae6df352011-04-06 17:40:39 +00001007
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001008 The return value is a string suitable for passing to git cl with the --cc
1009 flag.
bauerb@chromium.orgae6df352011-04-06 17:40:39 +00001010 """
1011 if self.cc is None:
tyoshino@chromium.org99918ab2013-09-30 06:17:28 +00001012 base_cc = settings.GetDefaultCCList()
Daniel Cheng7227d212017-11-17 08:12:37 -08001013 more_cc = ','.join(self.more_cc)
bauerb@chromium.orgae6df352011-04-06 17:40:39 +00001014 self.cc = ','.join(filter(None, (base_cc, more_cc))) or ''
1015 return self.cc
1016
Daniel Cheng7227d212017-11-17 08:12:37 -08001017 def ExtendCC(self, more_cc):
1018 """Extends the list of users to cc on this CL based on the changed files."""
1019 self.more_cc.extend(more_cc)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001020
Sigurd Schneider9abde8c2020-11-17 08:44:52 +00001021 def GetCommitDate(self):
1022 """Returns the commit date as provided in the constructor"""
1023 return self.commit_date
1024
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001025 def GetBranch(self):
Josip Sokcevicc39ab992020-09-24 20:09:15 +00001026 """Returns the short branch name, e.g. 'main'."""
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001027 if not self.branch:
Edward Lemur85153282020-02-14 22:06:29 +00001028 branchref = scm.GIT.GetBranchRef(settings.GetRoot())
szager@chromium.orgd62c61f2014-10-20 22:33:21 +00001029 if not branchref:
1030 return None
1031 self.branchref = branchref
Edward Lemur85153282020-02-14 22:06:29 +00001032 self.branch = scm.GIT.ShortBranchName(self.branchref)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001033 return self.branch
1034
1035 def GetBranchRef(self):
Josip Sokcevicc39ab992020-09-24 20:09:15 +00001036 """Returns the full branch name, e.g. 'refs/heads/main'."""
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001037 self.GetBranch() # Poke the lazy loader.
1038 return self.branchref
1039
Edward Lemur85153282020-02-14 22:06:29 +00001040 def _GitGetBranchConfigValue(self, key, default=None):
1041 return scm.GIT.GetBranchConfig(
1042 settings.GetRoot(), self.GetBranch(), key, default)
tandrii5d48c322016-08-18 16:19:37 -07001043
Edward Lemur85153282020-02-14 22:06:29 +00001044 def _GitSetBranchConfigValue(self, key, value):
1045 action = 'set %s to %r' % (key, value)
1046 if not value:
1047 action = 'unset %s' % key
1048 assert self.GetBranch(), 'a branch is needed to ' + action
1049 return scm.GIT.SetBranchConfig(
1050 settings.GetRoot(), self.GetBranch(), key, value)
tandrii5d48c322016-08-18 16:19:37 -07001051
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001052 @staticmethod
1053 def FetchUpstreamTuple(branch):
pgervais@chromium.orgd6617f32013-11-19 00:34:54 +00001054 """Returns a tuple containing remote and remote ref,
Josip Sokcevicc39ab992020-09-24 20:09:15 +00001055 e.g. 'origin', 'refs/heads/main'
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001056 """
Edward Lemur15a9b8c2020-02-13 00:52:30 +00001057 remote, upstream_branch = scm.GIT.FetchUpstreamTuple(
1058 settings.GetRoot(), branch)
1059 if not remote or not upstream_branch:
1060 DieWithError(
1061 'Unable to determine default branch to diff against.\n'
Josip Sokcevicb038f722021-01-06 18:28:11 +00001062 'Verify this branch is set up to track another \n'
1063 '(via the --track argument to "git checkout -b ..."). \n'
1064 'or pass complete "git diff"-style arguments if supported, like\n'
1065 ' git cl upload origin/main\n')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001066
1067 return remote, upstream_branch
1068
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00001069 def GetCommonAncestorWithUpstream(self):
pgervais@chromium.org8ba38ff2015-06-11 21:41:25 +00001070 upstream_branch = self.GetUpstreamBranch()
Edward Lesmes50da7702020-03-30 19:23:43 +00001071 if not scm.GIT.IsValidRevision(settings.GetRoot(), upstream_branch):
pgervais@chromium.org8ba38ff2015-06-11 21:41:25 +00001072 DieWithError('The upstream for the current branch (%s) does not exist '
1073 'anymore.\nPlease fix it and try again.' % self.GetBranch())
iannucci@chromium.org9e849272014-04-04 00:31:55 +00001074 return git_common.get_or_create_merge_base(self.GetBranch(),
pgervais@chromium.org8ba38ff2015-06-11 21:41:25 +00001075 upstream_branch)
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00001076
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001077 def GetUpstreamBranch(self):
1078 if self.upstream_branch is None:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001079 remote, upstream_branch = self.FetchUpstreamTuple(self.GetBranch())
Raul Tambrefe1dbe12019-05-02 04:43:57 +00001080 if remote != '.':
mmoss@chromium.orge7585452014-08-24 01:41:11 +00001081 upstream_branch = upstream_branch.replace('refs/heads/',
1082 'refs/remotes/%s/' % remote)
1083 upstream_branch = upstream_branch.replace('refs/branch-heads/',
1084 'refs/remotes/branch-heads/')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001085 self.upstream_branch = upstream_branch
1086 return self.upstream_branch
1087
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001088 def GetRemoteBranch(self):
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001089 if not self._remote:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001090 remote, branch = None, self.GetBranch()
1091 seen_branches = set()
1092 while branch not in seen_branches:
1093 seen_branches.add(branch)
1094 remote, branch = self.FetchUpstreamTuple(branch)
Edward Lemur85153282020-02-14 22:06:29 +00001095 branch = scm.GIT.ShortBranchName(branch)
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001096 if remote != '.' or branch.startswith('refs/remotes'):
1097 break
1098 else:
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001099 remotes = RunGit(['remote'], error_ok=True).split()
1100 if len(remotes) == 1:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001101 remote, = remotes
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001102 elif 'origin' in remotes:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001103 remote = 'origin'
Gavin Make6a62332020-12-04 21:57:10 +00001104 logging.warning('Could not determine which remote this change is '
1105 'associated with, so defaulting to "%s".' %
1106 self._remote)
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001107 else:
Gavin Make6a62332020-12-04 21:57:10 +00001108 logging.warning('Could not determine which remote this change is '
1109 'associated with.')
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001110 branch = 'HEAD'
1111 if branch.startswith('refs/remotes'):
1112 self._remote = (remote, branch)
mmoss@chromium.orge7585452014-08-24 01:41:11 +00001113 elif branch.startswith('refs/branch-heads/'):
1114 self._remote = (remote, branch.replace('refs/', 'refs/remotes/'))
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001115 else:
1116 self._remote = (remote, 'refs/remotes/%s/%s' % (remote, branch))
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001117 return self._remote
1118
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001119 def GetRemoteUrl(self):
1120 """Return the configured remote URL, e.g. 'git://example.org/foo.git/'.
1121
1122 Returns None if there is no remote.
1123 """
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00001124 is_cached, value = self._cached_remote_url
1125 if is_cached:
1126 return value
1127
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001128 remote, _ = self.GetRemoteBranch()
Edward Lemur26964072020-02-19 19:18:51 +00001129 url = scm.GIT.GetConfig(settings.GetRoot(), 'remote.%s.url' % remote, '')
dyen@chromium.org2a13d4f2014-06-13 00:06:37 +00001130
Edward Lemur298f2cf2019-02-22 21:40:39 +00001131 # Check if the remote url can be parsed as an URL.
Edward Lemur79d4f992019-11-11 23:49:02 +00001132 host = urllib.parse.urlparse(url).netloc
Edward Lemur298f2cf2019-02-22 21:40:39 +00001133 if host:
1134 self._cached_remote_url = (True, url)
1135 return url
1136
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001137 # If it cannot be parsed as an url, assume it is a local directory,
1138 # probably a git cache.
Edward Lemur298f2cf2019-02-22 21:40:39 +00001139 logging.warning('"%s" doesn\'t appear to point to a git host. '
1140 'Interpreting it as a local directory.', url)
1141 if not os.path.isdir(url):
1142 logging.error(
Josip906bfde2020-01-31 22:38:49 +00001143 'Remote "%(remote)s" for branch "%(branch)s" points to "%(url)s", '
1144 'but it doesn\'t exist.',
1145 {'remote': remote, 'branch': self.GetBranch(), 'url': url})
Edward Lemur298f2cf2019-02-22 21:40:39 +00001146 return None
1147
1148 cache_path = url
Edward Lemur26964072020-02-19 19:18:51 +00001149 url = scm.GIT.GetConfig(url, 'remote.%s.url' % remote, '')
Edward Lemur298f2cf2019-02-22 21:40:39 +00001150
Edward Lemur79d4f992019-11-11 23:49:02 +00001151 host = urllib.parse.urlparse(url).netloc
Edward Lemur298f2cf2019-02-22 21:40:39 +00001152 if not host:
1153 logging.error(
1154 'Remote "%(remote)s" for branch "%(branch)s" points to '
1155 '"%(cache_path)s", but it is misconfigured.\n'
1156 '"%(cache_path)s" must be a git repo and must have a remote named '
1157 '"%(remote)s" pointing to the git host.', {
1158 'remote': remote,
1159 'cache_path': cache_path,
1160 'branch': self.GetBranch()})
1161 return None
1162
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00001163 self._cached_remote_url = (True, url)
dyen@chromium.org2a13d4f2014-06-13 00:06:37 +00001164 return url
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001165
tandrii@chromium.org87985d22016-03-24 17:33:33 +00001166 def GetIssue(self):
maruel@chromium.org52424302012-08-29 15:14:30 +00001167 """Returns the issue number as a int or None if not set."""
tandrii@chromium.org87985d22016-03-24 17:33:33 +00001168 if self.issue is None and not self.lookedup_issue:
Edward Lesmes50da7702020-03-30 19:23:43 +00001169 self.issue = self._GitGetBranchConfigValue(ISSUE_CONFIG_KEY)
Edward Lemur85153282020-02-14 22:06:29 +00001170 if self.issue is not None:
1171 self.issue = int(self.issue)
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001172 self.lookedup_issue = True
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001173 return self.issue
1174
Andrii Shyshkalov1ee78cd2020-03-12 01:31:53 +00001175 def GetIssueURL(self, short=False):
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001176 """Get the URL for a particular issue."""
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001177 issue = self.GetIssue()
1178 if not issue:
dbeam@chromium.org015fd3d2013-06-18 19:02:50 +00001179 return None
Andrii Shyshkalov1ee78cd2020-03-12 01:31:53 +00001180 server = self.GetCodereviewServer()
1181 if short:
1182 server = _KNOWN_GERRIT_TO_SHORT_URLS.get(server, server)
1183 return '%s/%s' % (server, issue)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001184
Dirk Pranke6f0df682021-06-25 00:42:33 +00001185 def GetUsePython3(self):
1186 return settings.GetUsePython3()
1187
Edward Lemur6c6827c2020-02-06 21:15:18 +00001188 def FetchDescription(self, pretty=False):
1189 assert self.GetIssue(), 'issue is required to query Gerrit'
1190
Edward Lemur9aa1a962020-02-25 00:58:38 +00001191 if self.description is None:
Edward Lemur6c6827c2020-02-06 21:15:18 +00001192 data = self._GetChangeDetail(['CURRENT_REVISION', 'CURRENT_COMMIT'])
1193 current_rev = data['current_revision']
1194 self.description = data['revisions'][current_rev]['commit']['message']
Edward Lemur6c6827c2020-02-06 21:15:18 +00001195
1196 if not pretty:
1197 return self.description
1198
1199 # Set width to 72 columns + 2 space indent.
1200 wrapper = textwrap.TextWrapper(width=74, replace_whitespace=True)
1201 wrapper.initial_indent = wrapper.subsequent_indent = ' '
1202 lines = self.description.splitlines()
1203 return '\n'.join([wrapper.fill(line) for line in lines])
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001204
1205 def GetPatchset(self):
maruel@chromium.org52424302012-08-29 15:14:30 +00001206 """Returns the patchset number as a int or None if not set."""
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001207 if self.patchset is None and not self.lookedup_patchset:
Edward Lesmes50da7702020-03-30 19:23:43 +00001208 self.patchset = self._GitGetBranchConfigValue(PATCHSET_CONFIG_KEY)
Edward Lemur85153282020-02-14 22:06:29 +00001209 if self.patchset is not None:
1210 self.patchset = int(self.patchset)
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001211 self.lookedup_patchset = True
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001212 return self.patchset
1213
Edward Lemur9aa1a962020-02-25 00:58:38 +00001214 def GetAuthor(self):
1215 return scm.GIT.GetConfig(settings.GetRoot(), 'user.email')
1216
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001217 def SetPatchset(self, patchset):
tandrii5d48c322016-08-18 16:19:37 -07001218 """Set this branch's patchset. If patchset=0, clears the patchset."""
1219 assert self.GetBranch()
1220 if not patchset:
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001221 self.patchset = None
tandrii5d48c322016-08-18 16:19:37 -07001222 else:
1223 self.patchset = int(patchset)
Edward Lesmes50da7702020-03-30 19:23:43 +00001224 self._GitSetBranchConfigValue(PATCHSET_CONFIG_KEY, str(self.patchset))
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001225
tandrii@chromium.orga342c922016-03-16 07:08:25 +00001226 def SetIssue(self, issue=None):
tandrii5d48c322016-08-18 16:19:37 -07001227 """Set this branch's issue. If issue isn't given, clears the issue."""
1228 assert self.GetBranch()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001229 if issue:
tandrii5d48c322016-08-18 16:19:37 -07001230 issue = int(issue)
Edward Lesmes50da7702020-03-30 19:23:43 +00001231 self._GitSetBranchConfigValue(ISSUE_CONFIG_KEY, str(issue))
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001232 self.issue = issue
Edward Lemur125d60a2019-09-13 18:25:41 +00001233 codereview_server = self.GetCodereviewServer()
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001234 if codereview_server:
tandrii5d48c322016-08-18 16:19:37 -07001235 self._GitSetBranchConfigValue(
Edward Lesmes50da7702020-03-30 19:23:43 +00001236 CODEREVIEW_SERVER_CONFIG_KEY, codereview_server)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001237 else:
tandrii5d48c322016-08-18 16:19:37 -07001238 # Reset all of these just to be clean.
1239 reset_suffixes = [
1240 'last-upload-hash',
Edward Lesmes50da7702020-03-30 19:23:43 +00001241 ISSUE_CONFIG_KEY,
1242 PATCHSET_CONFIG_KEY,
1243 CODEREVIEW_SERVER_CONFIG_KEY,
1244 'gerritsquashhash',
1245 ]
tandrii5d48c322016-08-18 16:19:37 -07001246 for prop in reset_suffixes:
Edward Lemur85153282020-02-14 22:06:29 +00001247 try:
1248 self._GitSetBranchConfigValue(prop, None)
1249 except subprocess2.CalledProcessError:
1250 pass
Aaron Gableca01e2c2017-07-19 11:16:02 -07001251 msg = RunGit(['log', '-1', '--format=%B']).strip()
1252 if msg and git_footers.get_footer_change_id(msg):
1253 print('WARNING: The change patched into this branch has a Change-Id. '
1254 'Removing it.')
1255 RunGit(['commit', '--amend', '-m',
1256 git_footers.remove_footer(msg, 'Change-Id')])
Edward Lemurf38bc172019-09-03 21:02:13 +00001257 self.lookedup_issue = True
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001258 self.issue = None
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00001259 self.patchset = None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001260
Edward Lemur2c62b332020-03-12 22:12:33 +00001261 def GetAffectedFiles(self, upstream):
maruel@chromium.org2b38e9c2011-10-19 00:04:35 +00001262 try:
Edward Lemur2c62b332020-03-12 22:12:33 +00001263 return [f for _, f in scm.GIT.CaptureStatus(settings.GetRoot(), upstream)]
maruel@chromium.org2b38e9c2011-10-19 00:04:35 +00001264 except subprocess2.CalledProcessError:
1265 DieWithError(
pgervais@chromium.orgd6617f32013-11-19 00:34:54 +00001266 ('\nFailed to diff against upstream branch %s\n\n'
maruel@chromium.org2b38e9c2011-10-19 00:04:35 +00001267 'This branch probably doesn\'t exist anymore. To reset the\n'
1268 'tracking branch, please run\n'
Josip Sokcevicc39ab992020-09-24 20:09:15 +00001269 ' git branch --set-upstream-to origin/main %s\n'
1270 'or replace origin/main with the relevant branch') %
Edward Lemur2c62b332020-03-12 22:12:33 +00001271 (upstream, self.GetBranch()))
bauerb@chromium.org6fb99c62011-04-18 15:57:28 +00001272
dsansomee2d6fd92016-09-08 00:10:47 -07001273 def UpdateDescription(self, description, force=False):
Edward Lemur6c6827c2020-02-06 21:15:18 +00001274 assert self.GetIssue(), 'issue is required to update description'
1275
1276 if gerrit_util.HasPendingChangeEdit(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001277 self.GetGerritHost(), self._GerritChangeIdentifier()):
Edward Lemur6c6827c2020-02-06 21:15:18 +00001278 if not force:
1279 confirm_or_exit(
1280 'The description cannot be modified while the issue has a pending '
1281 'unpublished edit. Either publish the edit in the Gerrit web UI '
1282 'or delete it.\n\n', action='delete the unpublished edit')
1283
1284 gerrit_util.DeletePendingChangeEdit(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001285 self.GetGerritHost(), self._GerritChangeIdentifier())
Edward Lemur6c6827c2020-02-06 21:15:18 +00001286 gerrit_util.SetCommitMessage(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001287 self.GetGerritHost(), self._GerritChangeIdentifier(),
Edward Lemur6c6827c2020-02-06 21:15:18 +00001288 description, notify='NONE')
1289
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001290 self.description = description
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001291
Edward Lemur75526302020-02-27 22:31:05 +00001292 def _GetCommonPresubmitArgs(self, verbose, upstream):
Edward Lemur227d5102020-02-25 23:45:35 +00001293 args = [
Edward Lemur227d5102020-02-25 23:45:35 +00001294 '--root', settings.GetRoot(),
1295 '--upstream', upstream,
1296 ]
1297
1298 args.extend(['--verbose'] * verbose)
1299
Edward Lesmeseb1bd622021-03-01 19:54:07 +00001300 remote, remote_branch = self.GetRemoteBranch()
1301 target_ref = GetTargetRef(remote, remote_branch, None)
1302 args.extend(['--gerrit_url', self.GetCodereviewServer()])
1303 args.extend(['--gerrit_project', self.GetGerritProject()])
1304 args.extend(['--gerrit_branch', target_ref])
1305
Edward Lemur99df04e2020-03-05 19:39:43 +00001306 author = self.GetAuthor()
Edward Lemur227d5102020-02-25 23:45:35 +00001307 issue = self.GetIssue()
1308 patchset = self.GetPatchset()
Edward Lemur99df04e2020-03-05 19:39:43 +00001309 if author:
1310 args.extend(['--author', author])
Edward Lemur227d5102020-02-25 23:45:35 +00001311 if issue:
1312 args.extend(['--issue', str(issue)])
1313 if patchset:
1314 args.extend(['--patchset', str(patchset)])
Edward Lemur227d5102020-02-25 23:45:35 +00001315
Edward Lemur75526302020-02-27 22:31:05 +00001316 return args
1317
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00001318 def RunHook(self, committing, may_prompt, verbose, parallel, upstream,
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001319 description, all_files, resultdb=False, realm=None):
Edward Lemur75526302020-02-27 22:31:05 +00001320 """Calls sys.exit() if the hook fails; returns a HookResults otherwise."""
1321 args = self._GetCommonPresubmitArgs(verbose, upstream)
1322 args.append('--commit' if committing else '--upload')
Edward Lemur227d5102020-02-25 23:45:35 +00001323 if may_prompt:
1324 args.append('--may_prompt')
1325 if parallel:
1326 args.append('--parallel')
1327 if all_files:
1328 args.append('--all_files')
1329
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001330 if resultdb and not realm:
1331 # TODO (crbug.com/1113463): store realm somewhere and look it up so
1332 # it is not required to pass the realm flag
1333 print('Note: ResultDB reporting will NOT be performed because --realm'
1334 ' was not specified. To enable ResultDB, please run the command'
1335 ' again with the --realm argument to specify the LUCI realm.')
1336
1337 py2_results = self._RunPresubmit(args, resultdb, realm, description,
1338 use_python3=False)
1339 py3_results = self._RunPresubmit(args, resultdb, realm, description,
1340 use_python3=True)
1341 return self._MergePresubmitResults(py2_results, py3_results)
1342
1343 def _RunPresubmit(self, args, resultdb, realm, description, use_python3):
1344 args = args[:]
1345 vpython = 'vpython3' if use_python3 else 'vpython'
1346
Edward Lemur227d5102020-02-25 23:45:35 +00001347 with gclient_utils.temporary_file() as description_file:
1348 with gclient_utils.temporary_file() as json_output:
Edward Lemur1a83da12020-03-04 21:18:36 +00001349 gclient_utils.FileWrite(description_file, description)
Edward Lemur227d5102020-02-25 23:45:35 +00001350 args.extend(['--json_output', json_output])
1351 args.extend(['--description_file', description_file])
Dirk Pranke6f0df682021-06-25 00:42:33 +00001352 if self.GetUsePython3():
1353 args.append('--use-python3')
Edward Lemur227d5102020-02-25 23:45:35 +00001354 start = time_time()
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001355 cmd = [vpython, PRESUBMIT_SUPPORT] + args
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001356 if resultdb and realm:
1357 cmd = ['rdb', 'stream', '-new', '-realm', realm, '--'] + cmd
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00001358
1359 p = subprocess2.Popen(cmd)
Edward Lemur227d5102020-02-25 23:45:35 +00001360 exit_code = p.wait()
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00001361
Edward Lemur227d5102020-02-25 23:45:35 +00001362 metrics.collector.add_repeated('sub_commands', {
1363 'command': 'presubmit',
1364 'execution_time': time_time() - start,
1365 'exit_code': exit_code,
1366 })
1367
1368 if exit_code:
1369 sys.exit(exit_code)
1370
1371 json_results = gclient_utils.FileRead(json_output)
1372 return json.loads(json_results)
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001373
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001374 def _MergePresubmitResults(self, py2_results, py3_results):
1375 return {
1376 'more_cc': sorted(set(py2_results.get('more_cc', []) +
1377 py3_results.get('more_cc', []))),
1378 'errors': (
1379 py2_results.get('errors', []) + py3_results.get('errors', [])),
1380 'notifications': (
1381 py2_results.get('notifications', []) +
1382 py3_results.get('notifications', [])),
1383 'warnings': (
1384 py2_results.get('warnings', []) + py3_results.get('warnings', []))
1385 }
1386
Edward Lemur75526302020-02-27 22:31:05 +00001387 def RunPostUploadHook(self, verbose, upstream, description):
1388 args = self._GetCommonPresubmitArgs(verbose, upstream)
1389 args.append('--post_upload')
1390
1391 with gclient_utils.temporary_file() as description_file:
Edward Lemur1a83da12020-03-04 21:18:36 +00001392 gclient_utils.FileWrite(description_file, description)
Edward Lemur75526302020-02-27 22:31:05 +00001393 args.extend(['--description_file', description_file])
1394 p = subprocess2.Popen(['vpython', PRESUBMIT_SUPPORT] + args)
1395 p.wait()
1396
Edward Lemur5a644f82020-03-18 16:44:57 +00001397 def _GetDescriptionForUpload(self, options, git_diff_args, files):
1398 # Get description message for upload.
1399 if self.GetIssue():
1400 description = self.FetchDescription()
1401 elif options.message:
1402 description = options.message
1403 else:
1404 description = _create_description_from_log(git_diff_args)
1405 if options.title and options.squash:
Edward Lesmes0dd54822020-03-26 18:24:25 +00001406 description = options.title + '\n\n' + description
Edward Lemur5a644f82020-03-18 16:44:57 +00001407
1408 # Extract bug number from branch name.
1409 bug = options.bug
1410 fixed = options.fixed
1411 match = re.match(r'(?P<type>bug|fix(?:e[sd])?)[_-]?(?P<bugnum>\d+)',
1412 self.GetBranch())
1413 if not bug and not fixed and match:
1414 if match.group('type') == 'bug':
1415 bug = match.group('bugnum')
1416 else:
1417 fixed = match.group('bugnum')
1418
1419 change_description = ChangeDescription(description, bug, fixed)
1420
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001421 # Fill gaps in OWNERS coverage to tbrs/reviewers if requested.
1422 if options.add_owners_to:
1423 assert options.add_owners_to in ('TBR', 'R'), options.add_owners_to
Edward Lesmese1576912021-02-16 21:53:34 +00001424 status = self.owners_client.GetFilesApprovalStatus(
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001425 files, [], options.tbrs + options.reviewers)
1426 missing_files = [
1427 f for f in files
Edward Lesmese1576912021-02-16 21:53:34 +00001428 if status[f] == self._owners_client.INSUFFICIENT_REVIEWERS
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001429 ]
Edward Lesmese1576912021-02-16 21:53:34 +00001430 owners = self.owners_client.SuggestOwners(
1431 missing_files, exclude=[self.GetAuthor()])
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001432 if options.add_owners_to == 'TBR':
1433 assert isinstance(options.tbrs, list), options.tbrs
1434 options.tbrs.extend(owners)
1435 else:
1436 assert isinstance(options.reviewers, list), options.reviewers
1437 options.reviewers.extend(owners)
1438
Edward Lemur5a644f82020-03-18 16:44:57 +00001439 # Set the reviewer list now so that presubmit checks can access it.
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001440 if options.reviewers or options.tbrs:
1441 change_description.update_reviewers(options.reviewers, options.tbrs)
Edward Lemur5a644f82020-03-18 16:44:57 +00001442
1443 return change_description
1444
1445 def _GetTitleForUpload(self, options):
1446 # When not squashing, just return options.title.
1447 if not options.squash:
1448 return options.title
1449
1450 # On first upload, patchset title is always this string, while options.title
1451 # gets converted to first line of message.
1452 if not self.GetIssue():
1453 return 'Initial upload'
1454
1455 # When uploading subsequent patchsets, options.message is taken as the title
1456 # if options.title is not provided.
1457 if options.title:
1458 return options.title
1459 if options.message:
1460 return options.message.strip()
1461
1462 # Use the subject of the last commit as title by default.
Edward Lesmes50da7702020-03-30 19:23:43 +00001463 title = RunGit(['show', '-s', '--format=%s', 'HEAD']).strip()
Mario Bianuccicebfb4e2020-07-22 23:08:16 +00001464 if options.force or options.skip_title:
Edward Lemur5a644f82020-03-18 16:44:57 +00001465 return title
Edward Lesmesae3586b2020-03-23 21:21:14 +00001466 user_title = gclient_utils.AskForData('Title for patchset [%s]: ' % title)
mlcui3da91712021-05-05 10:00:30 +00001467
1468 # Use the default title if the user confirms the default with a 'y'.
1469 if user_title.lower() == 'y':
1470 return title
Edward Lesmesae3586b2020-03-23 21:21:14 +00001471 return user_title or title
Edward Lemur5a644f82020-03-18 16:44:57 +00001472
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001473 def CMDUpload(self, options, git_diff_args, orig_args):
1474 """Uploads a change to codereview."""
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001475 custom_cl_base = None
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001476 if git_diff_args:
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001477 custom_cl_base = base_branch = git_diff_args[0]
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001478 else:
1479 if self.GetBranch() is None:
1480 DieWithError('Can\'t upload from detached HEAD state. Get on a branch!')
1481
1482 # Default to diffing against common ancestor of upstream branch
1483 base_branch = self.GetCommonAncestorWithUpstream()
1484 git_diff_args = [base_branch, 'HEAD']
1485
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001486 # Fast best-effort checks to abort before running potentially expensive
1487 # hooks if uploading is likely to fail anyway. Passing these checks does
1488 # not guarantee that uploading will not fail.
Edward Lemur125d60a2019-09-13 18:25:41 +00001489 self.EnsureAuthenticated(force=options.force)
1490 self.EnsureCanUploadPatchset(force=options.force)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001491
1492 # Apply watchlists on upload.
Edward Lemur2c62b332020-03-12 22:12:33 +00001493 watchlist = watchlists.Watchlists(settings.GetRoot())
1494 files = self.GetAffectedFiles(base_branch)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001495 if not options.bypass_watchlists:
Daniel Cheng7227d212017-11-17 08:12:37 -08001496 self.ExtendCC(watchlist.GetWatchersForPaths(files))
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001497
Edward Lemur5a644f82020-03-18 16:44:57 +00001498 change_desc = self._GetDescriptionForUpload(options, git_diff_args, files)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001499 if not options.bypass_hooks:
Edward Lemur2c62b332020-03-12 22:12:33 +00001500 hook_results = self.RunHook(
1501 committing=False,
1502 may_prompt=not options.force,
1503 verbose=options.verbose,
1504 parallel=options.parallel,
1505 upstream=base_branch,
Edward Lemur5a644f82020-03-18 16:44:57 +00001506 description=change_desc.description,
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00001507 all_files=False,
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001508 resultdb=options.resultdb,
1509 realm=options.realm)
Edward Lemur227d5102020-02-25 23:45:35 +00001510 self.ExtendCC(hook_results['more_cc'])
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001511
Aaron Gable13101a62018-02-09 13:20:41 -08001512 print_stats(git_diff_args)
Edward Lemura12175c2020-03-09 16:58:26 +00001513 ret = self.CMDUploadChange(
Edward Lemur5a644f82020-03-18 16:44:57 +00001514 options, git_diff_args, custom_cl_base, change_desc)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001515 if not ret:
Edward Lemur85153282020-02-14 22:06:29 +00001516 self._GitSetBranchConfigValue(
Edward Lesmes50da7702020-03-30 19:23:43 +00001517 'last-upload-hash', scm.GIT.ResolveCommit(settings.GetRoot(), 'HEAD'))
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001518 # Run post upload hooks, if specified.
1519 if settings.GetRunPostUploadHook():
Edward Lemur5a644f82020-03-18 16:44:57 +00001520 self.RunPostUploadHook(
1521 options.verbose, base_branch, change_desc.description)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001522
1523 # Upload all dependencies if specified.
1524 if options.dependencies:
vapiera7fbd5a2016-06-16 09:17:49 -07001525 print()
1526 print('--dependencies has been specified.')
1527 print('All dependent local branches will be re-uploaded.')
1528 print()
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001529 # Remove the dependencies flag from args so that we do not end up in a
1530 # loop.
1531 orig_args.remove('--dependencies')
Jose Lopes3863fc52020-04-07 17:00:25 +00001532 ret = upload_branch_deps(self, orig_args, options.force)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001533 return ret
1534
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001535 def SetCQState(self, new_state):
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07001536 """Updates the CQ state for the latest patchset.
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001537
Greg Gutermanbe5fccd2021-06-14 17:58:20 +00001538 Issue must have been already uploaded and known. Optionally allows for
1539 updating Quick-Run (QR) state.
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001540 """
1541 assert new_state in _CQState.ALL_STATES
1542 assert self.GetIssue()
qyearsley1fdfcb62016-10-24 13:22:03 -07001543 try:
Edward Lemur125d60a2019-09-13 18:25:41 +00001544 vote_map = {
1545 _CQState.NONE: 0,
Greg Gutermanbe5fccd2021-06-14 17:58:20 +00001546 _CQState.QUICK_RUN: 1,
Edward Lemur125d60a2019-09-13 18:25:41 +00001547 _CQState.DRY_RUN: 1,
1548 _CQState.COMMIT: 2,
1549 }
Greg Gutermanbe5fccd2021-06-14 17:58:20 +00001550 if new_state == _CQState.QUICK_RUN:
1551 labels = {
1552 'Commit-Queue': vote_map[_CQState.DRY_RUN],
1553 'Quick-Run': vote_map[_CQState.QUICK_RUN],
1554 }
1555 else:
1556 labels = {'Commit-Queue': vote_map[new_state]}
Edward Lemur125d60a2019-09-13 18:25:41 +00001557 notify = False if new_state == _CQState.DRY_RUN else None
1558 gerrit_util.SetReview(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001559 self.GetGerritHost(), self._GerritChangeIdentifier(),
Edward Lemur125d60a2019-09-13 18:25:41 +00001560 labels=labels, notify=notify)
qyearsley1fdfcb62016-10-24 13:22:03 -07001561 return 0
1562 except KeyboardInterrupt:
1563 raise
1564 except:
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07001565 print('WARNING: Failed to %s.\n'
qyearsley1fdfcb62016-10-24 13:22:03 -07001566 'Either:\n'
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07001567 ' * Your project has no CQ,\n'
1568 ' * You don\'t have permission to change the CQ state,\n'
1569 ' * There\'s a bug in this code (see stack trace below).\n'
1570 'Consider specifying which bots to trigger manually or asking your '
1571 'project owners for permissions or contacting Chrome Infra at:\n'
1572 'https://www.chromium.org/infra\n\n' %
1573 ('cancel CQ' if new_state == _CQState.NONE else 'trigger CQ'))
qyearsley1fdfcb62016-10-24 13:22:03 -07001574 # Still raise exception so that stack trace is printed.
1575 raise
1576
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001577 def GetGerritHost(self):
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001578 # Lazy load of configs.
1579 self.GetCodereviewServer()
tandriie32e3ea2016-06-22 02:52:48 -07001580 if self._gerrit_host and '.' not in self._gerrit_host:
1581 # Abbreviated domain like "chromium" instead of chromium.googlesource.com.
1582 # This happens for internal stuff http://crbug.com/614312.
Edward Lemur79d4f992019-11-11 23:49:02 +00001583 parsed = urllib.parse.urlparse(self.GetRemoteUrl())
tandriie32e3ea2016-06-22 02:52:48 -07001584 if parsed.scheme == 'sso':
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001585 print('WARNING: using non-https URLs for remote is likely broken\n'
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001586 ' Your current remote is: %s' % self.GetRemoteUrl())
tandriie32e3ea2016-06-22 02:52:48 -07001587 self._gerrit_host = '%s.googlesource.com' % self._gerrit_host
1588 self._gerrit_server = 'https://%s' % self._gerrit_host
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001589 return self._gerrit_host
1590
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001591 def _GetGitHost(self):
1592 """Returns git host to be used when uploading change to Gerrit."""
Edward Lemur298f2cf2019-02-22 21:40:39 +00001593 remote_url = self.GetRemoteUrl()
1594 if not remote_url:
1595 return None
Edward Lemur79d4f992019-11-11 23:49:02 +00001596 return urllib.parse.urlparse(remote_url).netloc
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001597
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001598 def GetCodereviewServer(self):
1599 if not self._gerrit_server:
1600 # If we're on a branch then get the server potentially associated
1601 # with that branch.
Edward Lemur85153282020-02-14 22:06:29 +00001602 if self.GetIssue() and self.GetBranch():
tandrii5d48c322016-08-18 16:19:37 -07001603 self._gerrit_server = self._GitGetBranchConfigValue(
Edward Lesmes50da7702020-03-30 19:23:43 +00001604 CODEREVIEW_SERVER_CONFIG_KEY)
tandrii5d48c322016-08-18 16:19:37 -07001605 if self._gerrit_server:
Edward Lemur79d4f992019-11-11 23:49:02 +00001606 self._gerrit_host = urllib.parse.urlparse(self._gerrit_server).netloc
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001607 if not self._gerrit_server:
1608 # We assume repo to be hosted on Gerrit, and hence Gerrit server
1609 # has "-review" suffix for lowest level subdomain.
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001610 parts = self._GetGitHost().split('.')
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001611 parts[0] = parts[0] + '-review'
1612 self._gerrit_host = '.'.join(parts)
1613 self._gerrit_server = 'https://%s' % self._gerrit_host
1614 return self._gerrit_server
1615
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001616 def GetGerritProject(self):
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001617 """Returns Gerrit project name based on remote git URL."""
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00001618 remote_url = self.GetRemoteUrl()
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001619 if remote_url is None:
Josip906bfde2020-01-31 22:38:49 +00001620 logging.warning('can\'t detect Gerrit project.')
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00001621 return None
Edward Lemur79d4f992019-11-11 23:49:02 +00001622 project = urllib.parse.urlparse(remote_url).path.strip('/')
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001623 if project.endswith('.git'):
1624 project = project[:-len('.git')]
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00001625 # *.googlesource.com hosts ensure that Git/Gerrit projects don't start with
1626 # 'a/' prefix, because 'a/' prefix is used to force authentication in
1627 # gitiles/git-over-https protocol. E.g.,
1628 # https://chromium.googlesource.com/a/v8/v8 refers to the same repo/project
1629 # as
1630 # https://chromium.googlesource.com/v8/v8
1631 if project.startswith('a/'):
1632 project = project[len('a/'):]
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001633 return project
1634
Andrii Shyshkalovd06cc782018-08-23 17:24:19 +00001635 def _GerritChangeIdentifier(self):
1636 """Handy method for gerrit_util.ChangeIdentifier for a given CL.
1637
1638 Not to be confused by value of "Change-Id:" footer.
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00001639 If Gerrit project can be determined, this will speed up Gerrit HTTP API RPC.
Andrii Shyshkalovd06cc782018-08-23 17:24:19 +00001640 """
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001641 project = self.GetGerritProject()
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00001642 if project:
1643 return gerrit_util.ChangeIdentifier(project, self.GetIssue())
1644 # Fall back on still unique, but less efficient change number.
1645 return str(self.GetIssue())
Andrii Shyshkalovd06cc782018-08-23 17:24:19 +00001646
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01001647 def EnsureAuthenticated(self, force, refresh=None):
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001648 """Best effort check that user is authenticated with Gerrit server."""
tandrii@chromium.org28253532016-04-14 13:46:56 +00001649 if settings.GetGerritSkipEnsureAuthenticated():
1650 # For projects with unusual authentication schemes.
1651 # See http://crbug.com/603378.
1652 return
Vadim Shtayurab250ec12018-10-04 00:21:08 +00001653
1654 # Check presence of cookies only if using cookies-based auth method.
1655 cookie_auth = gerrit_util.Authenticator.get()
1656 if not isinstance(cookie_auth, gerrit_util.CookiesAuthenticator):
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001657 return
Vadim Shtayurab250ec12018-10-04 00:21:08 +00001658
Florian Mayerae510e82020-01-30 21:04:48 +00001659 remote_url = self.GetRemoteUrl()
1660 if remote_url is None:
Josip906bfde2020-01-31 22:38:49 +00001661 logging.warning('invalid remote')
Florian Mayerae510e82020-01-30 21:04:48 +00001662 return
1663 if urllib.parse.urlparse(remote_url).scheme != 'https':
Josip906bfde2020-01-31 22:38:49 +00001664 logging.warning('Ignoring branch %(branch)s with non-https remote '
1665 '%(remote)s', {
1666 'branch': self.branch,
1667 'remote': self.GetRemoteUrl()
1668 })
Daniel Chengcf6269b2019-05-18 01:02:12 +00001669 return
1670
Vadim Shtayurab250ec12018-10-04 00:21:08 +00001671 # Lazy-loader to identify Gerrit and Git hosts.
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001672 self.GetCodereviewServer()
1673 git_host = self._GetGitHost()
Edward Lemur298f2cf2019-02-22 21:40:39 +00001674 assert self._gerrit_server and self._gerrit_host and git_host
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001675
1676 gerrit_auth = cookie_auth.get_auth_header(self._gerrit_host)
1677 git_auth = cookie_auth.get_auth_header(git_host)
1678 if gerrit_auth and git_auth:
1679 if gerrit_auth == git_auth:
1680 return
Andrii Shyshkalov354e1d22017-06-09 19:31:33 +02001681 all_gsrc = cookie_auth.get_auth_header('d0esN0tEx1st.googlesource.com')
Raul Tambre80ee78e2019-05-06 22:41:05 +00001682 print(
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001683 'WARNING: You have different credentials for Gerrit and git hosts:\n'
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001684 ' %s\n'
1685 ' %s\n'
Andrii Shyshkalov51acef92017-04-11 17:19:59 +02001686 ' Consider running the following command:\n'
1687 ' git cl creds-check\n'
Andrii Shyshkalov354e1d22017-06-09 19:31:33 +02001688 ' %s\n'
Raul Tambre80ee78e2019-05-06 22:41:05 +00001689 ' %s' %
Andrii Shyshkalov51acef92017-04-11 17:19:59 +02001690 (git_host, self._gerrit_host,
Andrii Shyshkalov354e1d22017-06-09 19:31:33 +02001691 ('Hint: delete creds for .googlesource.com' if all_gsrc else ''),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001692 cookie_auth.get_new_password_message(git_host)))
1693 if not force:
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01001694 confirm_or_exit('If you know what you are doing', action='continue')
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001695 return
1696 else:
1697 missing = (
Anna Henningsen4e891442017-07-06 21:40:58 +02001698 ([] if gerrit_auth else [self._gerrit_host]) +
1699 ([] if git_auth else [git_host]))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001700 DieWithError('Credentials for the following hosts are required:\n'
1701 ' %s\n'
1702 'These are read from %s (or legacy %s)\n'
1703 '%s' % (
1704 '\n '.join(missing),
1705 cookie_auth.get_gitcookies_path(),
1706 cookie_auth.get_netrc_path(),
1707 cookie_auth.get_new_password_message(git_host)))
1708
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001709 def EnsureCanUploadPatchset(self, force):
Andrii Shyshkalov3e631422017-02-16 17:46:44 +01001710 if not self.GetIssue():
1711 return
1712
Andrii Shyshkalov3e631422017-02-16 17:46:44 +01001713 status = self._GetChangeDetail()['status']
1714 if status in ('MERGED', 'ABANDONED'):
1715 DieWithError('Change %s has been %s, new uploads are not allowed' %
1716 (self.GetIssueURL(),
1717 'submitted' if status == 'MERGED' else 'abandoned'))
1718
Vadim Shtayurab250ec12018-10-04 00:21:08 +00001719 # TODO(vadimsh): For some reason the chunk of code below was skipped if
1720 # 'is_gce' is True. I'm just refactoring it to be 'skip if not cookies'.
1721 # Apparently this check is not very important? Otherwise get_auth_email
1722 # could have been added to other implementations of Authenticator.
1723 cookies_auth = gerrit_util.Authenticator.get()
1724 if not isinstance(cookies_auth, gerrit_util.CookiesAuthenticator):
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001725 return
Vadim Shtayurab250ec12018-10-04 00:21:08 +00001726
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001727 cookies_user = cookies_auth.get_auth_email(self.GetGerritHost())
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001728 if self.GetIssueOwner() == cookies_user:
1729 return
1730 logging.debug('change %s owner is %s, cookies user is %s',
1731 self.GetIssue(), self.GetIssueOwner(), cookies_user)
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001732 # Maybe user has linked accounts or something like that,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001733 # so ask what Gerrit thinks of this user.
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001734 details = gerrit_util.GetAccountDetails(self.GetGerritHost(), 'self')
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001735 if details['email'] == self.GetIssueOwner():
1736 return
1737 if not force:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001738 print('WARNING: Change %s is owned by %s, but you authenticate to Gerrit '
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001739 'as %s.\n'
1740 'Uploading may fail due to lack of permissions.' %
1741 (self.GetIssue(), self.GetIssueOwner(), details['email']))
1742 confirm_or_exit(action='upload')
1743
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001744 def GetStatus(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001745 """Applies a rough heuristic to give a simple summary of an issue's review
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001746 or CQ status, assuming adherence to a common workflow.
1747
1748 Returns None if no issue for this branch, or one of the following keywords:
Aaron Gable9ab38c62017-04-06 14:36:33 -07001749 * 'error' - error from review tool (including deleted issues)
1750 * 'unsent' - no reviewers added
1751 * 'waiting' - waiting for review
1752 * 'reply' - waiting for uploader to reply to review
1753 * 'lgtm' - Code-Review label has been set
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +00001754 * 'dry-run' - dry-running in the CQ
1755 * 'commit' - in the CQ
Aaron Gable9ab38c62017-04-06 14:36:33 -07001756 * 'closed' - successfully submitted or abandoned
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001757 """
1758 if not self.GetIssue():
1759 return None
1760
1761 try:
Aaron Gable9ab38c62017-04-06 14:36:33 -07001762 data = self._GetChangeDetail([
1763 'DETAILED_LABELS', 'CURRENT_REVISION', 'SUBMITTABLE'])
Edward Lemur79d4f992019-11-11 23:49:02 +00001764 except GerritChangeNotExists:
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001765 return 'error'
1766
tandrii@chromium.org5e1bf382016-05-17 08:43:24 +00001767 if data['status'] in ('ABANDONED', 'MERGED'):
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001768 return 'closed'
1769
Andrii Shyshkalovb8268ca2019-04-03 23:33:44 +00001770 cq_label = data['labels'].get('Commit-Queue', {})
1771 max_cq_vote = 0
1772 for vote in cq_label.get('all', []):
1773 max_cq_vote = max(max_cq_vote, vote.get('value', 0))
1774 if max_cq_vote == 2:
Aaron Gable9ab38c62017-04-06 14:36:33 -07001775 return 'commit'
Andrii Shyshkalovb8268ca2019-04-03 23:33:44 +00001776 if max_cq_vote == 1:
1777 return 'dry-run'
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001778
Aaron Gable9ab38c62017-04-06 14:36:33 -07001779 if data['labels'].get('Code-Review', {}).get('approved'):
1780 return 'lgtm'
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001781
1782 if not data.get('reviewers', {}).get('REVIEWER', []):
1783 return 'unsent'
1784
Andrii Shyshkalov33e88a42017-01-27 14:45:30 +01001785 owner = data['owner'].get('_account_id')
Edward Lemur79d4f992019-11-11 23:49:02 +00001786 messages = sorted(data.get('messages', []), key=lambda m: m.get('date'))
Andrii Shyshkalov8aa9d622020-03-10 19:15:35 +00001787 while messages:
1788 m = messages.pop()
1789 if m.get('tag', '').startswith('autogenerated:cq:'):
Andrii Shyshkalov33e88a42017-01-27 14:45:30 +01001790 # Ignore replies from CQ.
1791 continue
Andrii Shyshkalov8aa9d622020-03-10 19:15:35 +00001792 if m.get('author', {}).get('_account_id') == owner:
Aaron Gable9ab38c62017-04-06 14:36:33 -07001793 # Most recent message was by owner.
1794 return 'waiting'
1795 else:
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001796 # Some reply from non-owner.
1797 return 'reply'
Aaron Gable9ab38c62017-04-06 14:36:33 -07001798
1799 # Somehow there are no messages even though there are reviewers.
1800 return 'unsent'
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001801
1802 def GetMostRecentPatchset(self):
Edward Lemur6c6827c2020-02-06 21:15:18 +00001803 if not self.GetIssue():
1804 return None
1805
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001806 data = self._GetChangeDetail(['CURRENT_REVISION'])
Aaron Gablee8856ee2017-12-07 12:41:46 -08001807 patchset = data['revisions'][data['current_revision']]['_number']
1808 self.SetPatchset(patchset)
1809 return patchset
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001810
Gavin Make61ccc52020-11-13 00:12:57 +00001811 def GetMostRecentDryRunPatchset(self):
1812 """Get patchsets equivalent to the most recent patchset and return
1813 the patchset with the latest dry run. If none have been dry run, return
1814 the latest patchset."""
1815 if not self.GetIssue():
1816 return None
1817
1818 data = self._GetChangeDetail(['ALL_REVISIONS'])
1819 patchset = data['revisions'][data['current_revision']]['_number']
1820 dry_run = set([int(m['_revision_number'])
1821 for m in data.get('messages', [])
1822 if m.get('tag', '').endswith('dry-run')])
1823
1824 for revision_info in sorted(data.get('revisions', {}).values(),
1825 key=lambda c: c['_number'], reverse=True):
1826 if revision_info['_number'] in dry_run:
1827 patchset = revision_info['_number']
1828 break
1829 if revision_info.get('kind', '') not in \
1830 ('NO_CHANGE', 'NO_CODE_CHANGE', 'TRIVIAL_REBASE'):
1831 break
1832 self.SetPatchset(patchset)
1833 return patchset
1834
Aaron Gable636b13f2017-07-14 10:42:48 -07001835 def AddComment(self, message, publish=None):
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00001836 gerrit_util.SetReview(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001837 self.GetGerritHost(), self._GerritChangeIdentifier(),
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00001838 msg=message, ready=publish)
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01001839
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001840 def GetCommentsSummary(self, readable=True):
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01001841 # DETAILED_ACCOUNTS is to get emails in accounts.
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001842 # CURRENT_REVISION is included to get the latest patchset so that
1843 # only the robot comments from the latest patchset can be shown.
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001844 messages = self._GetChangeDetail(
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001845 options=['MESSAGES', 'DETAILED_ACCOUNTS',
1846 'CURRENT_REVISION']).get('messages', [])
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001847 file_comments = gerrit_util.GetChangeComments(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001848 self.GetGerritHost(), self._GerritChangeIdentifier())
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001849 robot_file_comments = gerrit_util.GetChangeRobotComments(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001850 self.GetGerritHost(), self._GerritChangeIdentifier())
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001851
1852 # Add the robot comments onto the list of comments, but only
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00001853 # keep those that are from the latest patchset.
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001854 latest_patch_set = self.GetMostRecentPatchset()
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001855 for path, robot_comments in robot_file_comments.items():
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001856 line_comments = file_comments.setdefault(path, [])
1857 line_comments.extend(
1858 [c for c in robot_comments if c['patch_set'] == latest_patch_set])
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001859
1860 # Build dictionary of file comments for easy access and sorting later.
1861 # {author+date: {path: {patchset: {line: url+message}}}}
1862 comments = collections.defaultdict(
1863 lambda: collections.defaultdict(lambda: collections.defaultdict(dict)))
Andrii Shyshkalova3762a92020-11-25 10:20:42 +00001864
1865 server = self.GetCodereviewServer()
1866 if server in _KNOWN_GERRIT_TO_SHORT_URLS:
1867 # /c/ is automatically added by short URL server.
1868 url_prefix = '%s/%s' % (_KNOWN_GERRIT_TO_SHORT_URLS[server],
1869 self.GetIssue())
1870 else:
1871 url_prefix = '%s/c/%s' % (server, self.GetIssue())
1872
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001873 for path, line_comments in file_comments.items():
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001874 for comment in line_comments:
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001875 tag = comment.get('tag', '')
1876 if tag.startswith('autogenerated') and 'robot_id' not in comment:
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001877 continue
1878 key = (comment['author']['email'], comment['updated'])
1879 if comment.get('side', 'REVISION') == 'PARENT':
1880 patchset = 'Base'
1881 else:
1882 patchset = 'PS%d' % comment['patch_set']
1883 line = comment.get('line', 0)
Andrii Shyshkalova3762a92020-11-25 10:20:42 +00001884 url = ('%s/%s/%s#%s%s' %
1885 (url_prefix, comment['patch_set'], path,
1886 'b' if comment.get('side') == 'PARENT' else '',
1887 str(line) if line else ''))
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001888 comments[key][path][patchset][line] = (url, comment['message'])
1889
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001890 summaries = []
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001891 for msg in messages:
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001892 summary = self._BuildCommentSummary(msg, comments, readable)
1893 if summary:
1894 summaries.append(summary)
1895 return summaries
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001896
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001897 @staticmethod
1898 def _BuildCommentSummary(msg, comments, readable):
1899 key = (msg['author']['email'], msg['date'])
1900 # Don't bother showing autogenerated messages that don't have associated
1901 # file or line comments. this will filter out most autogenerated
1902 # messages, but will keep robot comments like those from Tricium.
1903 is_autogenerated = msg.get('tag', '').startswith('autogenerated')
1904 if is_autogenerated and not comments.get(key):
1905 return None
1906 message = msg['message']
1907 # Gerrit spits out nanoseconds.
1908 assert len(msg['date'].split('.')[-1]) == 9
1909 date = datetime.datetime.strptime(msg['date'][:-3],
1910 '%Y-%m-%d %H:%M:%S.%f')
1911 if key in comments:
1912 message += '\n'
1913 for path, patchsets in sorted(comments.get(key, {}).items()):
1914 if readable:
1915 message += '\n%s' % path
1916 for patchset, lines in sorted(patchsets.items()):
1917 for line, (url, content) in sorted(lines.items()):
1918 if line:
1919 line_str = 'Line %d' % line
1920 path_str = '%s:%d:' % (path, line)
1921 else:
1922 line_str = 'File comment'
1923 path_str = '%s:0:' % path
1924 if readable:
1925 message += '\n %s, %s: %s' % (patchset, line_str, url)
1926 message += '\n %s\n' % content
1927 else:
1928 message += '\n%s ' % path_str
1929 message += '\n%s\n' % content
1930
1931 return _CommentSummary(
1932 date=date,
1933 message=message,
1934 sender=msg['author']['email'],
1935 autogenerated=is_autogenerated,
1936 # These could be inferred from the text messages and correlated with
1937 # Code-Review label maximum, however this is not reliable.
1938 # Leaving as is until the need arises.
1939 approval=False,
1940 disapproval=False,
1941 )
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01001942
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001943 def CloseIssue(self):
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00001944 gerrit_util.AbandonChange(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001945 self.GetGerritHost(), self._GerritChangeIdentifier(), msg='')
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001946
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00001947 def SubmitIssue(self, wait_for_merge=True):
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00001948 gerrit_util.SubmitChange(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001949 self.GetGerritHost(), self._GerritChangeIdentifier(),
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00001950 wait_for_merge=wait_for_merge)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001951
Edward Lesmes7677e5c2020-02-19 20:39:03 +00001952 def _GetChangeDetail(self, options=None):
1953 """Returns details of associated Gerrit change and caching results."""
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00001954 options = options or []
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001955 assert self.GetIssue(), 'issue is required to query Gerrit'
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01001956
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01001957 # Optimization to avoid multiple RPCs:
Edward Lesmes7677e5c2020-02-19 20:39:03 +00001958 if 'CURRENT_REVISION' in options or 'ALL_REVISIONS' in options:
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01001959 options.append('CURRENT_COMMIT')
1960
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01001961 # Normalize issue and options for consistent keys in cache.
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001962 cache_key = str(self.GetIssue())
Edward Lesmes7677e5c2020-02-19 20:39:03 +00001963 options_set = frozenset(o.upper() for o in options)
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01001964
Edward Lesmes7677e5c2020-02-19 20:39:03 +00001965 for cached_options_set, data in self._detail_cache.get(cache_key, []):
1966 # Assumption: data fetched before with extra options is suitable
1967 # for return for a smaller set of options.
1968 # For example, if we cached data for
1969 # options=[CURRENT_REVISION, DETAILED_FOOTERS]
1970 # and request is for options=[CURRENT_REVISION],
1971 # THEN we can return prior cached data.
1972 if options_set.issubset(cached_options_set):
1973 return data
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01001974
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01001975 try:
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001976 data = gerrit_util.GetChangeDetail(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001977 self.GetGerritHost(), self._GerritChangeIdentifier(), options_set)
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01001978 except gerrit_util.GerritError as e:
1979 if e.http_status == 404:
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001980 raise GerritChangeNotExists(self.GetIssue(), self.GetCodereviewServer())
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01001981 raise
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01001982
Edward Lesmes7677e5c2020-02-19 20:39:03 +00001983 self._detail_cache.setdefault(cache_key, []).append((options_set, data))
tandriic2405f52016-10-10 08:13:15 -07001984 return data
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001985
Andrii Shyshkalovcc5f17e2018-08-22 23:35:59 +00001986 def _GetChangeCommit(self):
Andrii Shyshkalove2633162018-08-27 23:50:31 +00001987 assert self.GetIssue(), 'issue must be set to query Gerrit'
Aaron Gable6f5a8d92017-04-18 14:49:05 -07001988 try:
Andrii Shyshkalove2633162018-08-27 23:50:31 +00001989 data = gerrit_util.GetChangeCommit(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001990 self.GetGerritHost(), self._GerritChangeIdentifier())
Aaron Gable6f5a8d92017-04-18 14:49:05 -07001991 except gerrit_util.GerritError as e:
1992 if e.http_status == 404:
Andrii Shyshkalove2633162018-08-27 23:50:31 +00001993 raise GerritChangeNotExists(self.GetIssue(), self.GetCodereviewServer())
Aaron Gable6f5a8d92017-04-18 14:49:05 -07001994 raise
agable32978d92016-11-01 12:55:02 -07001995 return data
1996
Karen Qian40c19422019-03-13 21:28:29 +00001997 def _IsCqConfigured(self):
1998 detail = self._GetChangeDetail(['LABELS'])
Andrii Shyshkalov8effa4d2020-01-21 13:23:36 +00001999 return u'Commit-Queue' in detail.get('labels', {})
Karen Qian40c19422019-03-13 21:28:29 +00002000
Saagar Sanghavi03b15132020-08-10 16:43:41 +00002001 def CMDLand(self, force, bypass_hooks, verbose, parallel, resultdb, realm):
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002002 if git_common.is_dirty_git_tree('land'):
2003 return 1
Karen Qian40c19422019-03-13 21:28:29 +00002004
tandriid60367b2016-06-22 05:25:12 -07002005 detail = self._GetChangeDetail(['CURRENT_REVISION', 'LABELS'])
Karen Qian40c19422019-03-13 21:28:29 +00002006 if not force and self._IsCqConfigured():
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +00002007 confirm_or_exit('\nIt seems this repository has a CQ, '
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002008 'which can test and land changes for you. '
2009 'Are you sure you wish to bypass it?\n',
2010 action='bypass CQ')
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002011 differs = True
tandriic4344b52016-08-29 06:04:54 -07002012 last_upload = self._GitGetBranchConfigValue('gerritsquashhash')
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002013 # Note: git diff outputs nothing if there is no diff.
2014 if not last_upload or RunGit(['diff', last_upload]).strip():
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002015 print('WARNING: Some changes from local branch haven\'t been uploaded.')
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002016 else:
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002017 if detail['current_revision'] == last_upload:
2018 differs = False
2019 else:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002020 print('WARNING: Local branch contents differ from latest uploaded '
2021 'patchset.')
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002022 if differs:
2023 if not force:
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002024 confirm_or_exit(
2025 'Do you want to submit latest Gerrit patchset and bypass hooks?\n',
2026 action='submit')
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002027 print('WARNING: Bypassing hooks and submitting latest uploaded patchset.')
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002028 elif not bypass_hooks:
Edward Lemur227d5102020-02-25 23:45:35 +00002029 upstream = self.GetCommonAncestorWithUpstream()
2030 if self.GetIssue():
2031 description = self.FetchDescription()
2032 else:
Edward Lemura12175c2020-03-09 16:58:26 +00002033 description = _create_description_from_log([upstream])
Edward Lemur227d5102020-02-25 23:45:35 +00002034 self.RunHook(
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002035 committing=True,
2036 may_prompt=not force,
2037 verbose=verbose,
Edward Lemur227d5102020-02-25 23:45:35 +00002038 parallel=parallel,
2039 upstream=upstream,
2040 description=description,
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00002041 all_files=False,
Saagar Sanghavi03b15132020-08-10 16:43:41 +00002042 resultdb=resultdb,
2043 realm=realm)
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002044
2045 self.SubmitIssue(wait_for_merge=True)
2046 print('Issue %s has been submitted.' % self.GetIssueURL())
agable32978d92016-11-01 12:55:02 -07002047 links = self._GetChangeCommit().get('web_links', [])
2048 for link in links:
Aaron Gable02cdbb42016-12-13 16:24:25 -08002049 if link.get('name') == 'gitiles' and link.get('url'):
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002050 print('Landed as: %s' % link.get('url'))
agable32978d92016-11-01 12:55:02 -07002051 break
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002052 return 0
2053
Bruce Dawsonf362f6f2021-02-18 23:15:17 +00002054 def CMDPatchWithParsedIssue(self, parsed_issue_arg, nocommit, force,
2055 newbranch):
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002056 assert parsed_issue_arg.valid
2057
Edward Lemur125d60a2019-09-13 18:25:41 +00002058 self.issue = parsed_issue_arg.issue
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002059
2060 if parsed_issue_arg.hostname:
2061 self._gerrit_host = parsed_issue_arg.hostname
2062 self._gerrit_server = 'https://%s' % self._gerrit_host
2063
tandriic2405f52016-10-10 08:13:15 -07002064 try:
2065 detail = self._GetChangeDetail(['ALL_REVISIONS'])
Aaron Gablea45ee112016-11-22 15:14:38 -08002066 except GerritChangeNotExists as e:
tandriic2405f52016-10-10 08:13:15 -07002067 DieWithError(str(e))
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002068
2069 if not parsed_issue_arg.patchset:
2070 # Use current revision by default.
2071 revision_info = detail['revisions'][detail['current_revision']]
2072 patchset = int(revision_info['_number'])
2073 else:
2074 patchset = parsed_issue_arg.patchset
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00002075 for revision_info in detail['revisions'].values():
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002076 if int(revision_info['_number']) == parsed_issue_arg.patchset:
2077 break
2078 else:
Aaron Gablea45ee112016-11-22 15:14:38 -08002079 DieWithError('Couldn\'t find patchset %i in change %i' %
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002080 (parsed_issue_arg.patchset, self.GetIssue()))
2081
Edward Lemur125d60a2019-09-13 18:25:41 +00002082 remote_url = self.GetRemoteUrl()
Aaron Gable697a91b2018-01-19 15:20:15 -08002083 if remote_url.endswith('.git'):
2084 remote_url = remote_url[:-len('.git')]
erikchen0d14d0d2018-08-28 18:57:09 +00002085 remote_url = remote_url.rstrip('/')
2086
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002087 fetch_info = revision_info['fetch']['http']
erikchen0d14d0d2018-08-28 18:57:09 +00002088 fetch_info['url'] = fetch_info['url'].rstrip('/')
Aaron Gable697a91b2018-01-19 15:20:15 -08002089
2090 if remote_url != fetch_info['url']:
2091 DieWithError('Trying to patch a change from %s but this repo appears '
2092 'to be %s.' % (fetch_info['url'], remote_url))
2093
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002094 RunGit(['fetch', fetch_info['url'], fetch_info['ref']])
Aaron Gable9387b4f2017-06-08 10:50:03 -07002095
Bruce Dawsonf362f6f2021-02-18 23:15:17 +00002096 # If we have created a new branch then do the "set issue" immediately in
2097 # case the cherry-pick fails, which happens when resolving conflicts.
2098 if newbranch:
2099 self.SetIssue(parsed_issue_arg.issue)
2100
Aaron Gable62619a32017-06-16 08:22:09 -07002101 if force:
2102 RunGit(['reset', '--hard', 'FETCH_HEAD'])
2103 print('Checked out commit for change %i patchset %i locally' %
2104 (parsed_issue_arg.issue, patchset))
Stefan Zager2d5f0392017-10-10 15:17:53 -07002105 elif nocommit:
2106 RunGit(['cherry-pick', '--no-commit', 'FETCH_HEAD'])
2107 print('Patch applied to index.')
Aaron Gable62619a32017-06-16 08:22:09 -07002108 else:
Aaron Gable9387b4f2017-06-08 10:50:03 -07002109 RunGit(['cherry-pick', 'FETCH_HEAD'])
2110 print('Committed patch for change %i patchset %i locally.' %
Aaron Gable62619a32017-06-16 08:22:09 -07002111 (parsed_issue_arg.issue, patchset))
2112 print('Note: this created a local commit which does not have '
2113 'the same hash as the one uploaded for review. This will make '
2114 'uploading changes based on top of this branch difficult.\n'
2115 'If you want to do that, use "git cl patch --force" instead.')
2116
Stefan Zagerd08043c2017-10-12 12:07:02 -07002117 if self.GetBranch():
2118 self.SetIssue(parsed_issue_arg.issue)
2119 self.SetPatchset(patchset)
Edward Lesmes50da7702020-03-30 19:23:43 +00002120 fetched_hash = scm.GIT.ResolveCommit(settings.GetRoot(), 'FETCH_HEAD')
Stefan Zagerd08043c2017-10-12 12:07:02 -07002121 self._GitSetBranchConfigValue('last-upload-hash', fetched_hash)
2122 self._GitSetBranchConfigValue('gerritsquashhash', fetched_hash)
2123 else:
2124 print('WARNING: You are in detached HEAD state.\n'
2125 'The patch has been applied to your checkout, but you will not be '
2126 'able to upload a new patch set to the gerrit issue.\n'
2127 'Try using the \'-b\' option if you would like to work on a '
2128 'branch and/or upload a new patch set.')
2129
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002130 return 0
2131
tandrii16e0b4e2016-06-07 10:34:28 -07002132 def _GerritCommitMsgHookCheck(self, offer_removal):
2133 hook = os.path.join(settings.GetRoot(), '.git', 'hooks', 'commit-msg')
2134 if not os.path.exists(hook):
2135 return
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002136 # Crude attempt to distinguish Gerrit Codereview hook from a potentially
2137 # custom developer-made one.
tandrii16e0b4e2016-06-07 10:34:28 -07002138 data = gclient_utils.FileRead(hook)
2139 if not('From Gerrit Code Review' in data and 'add_ChangeId()' in data):
2140 return
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002141 print('WARNING: You have Gerrit commit-msg hook installed.\n'
qyearsley12fa6ff2016-08-24 09:18:40 -07002142 'It is not necessary for uploading with git cl in squash mode, '
tandrii16e0b4e2016-06-07 10:34:28 -07002143 'and may interfere with it in subtle ways.\n'
2144 'We recommend you remove the commit-msg hook.')
2145 if offer_removal:
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002146 if ask_for_explicit_yes('Do you want to remove it now?'):
tandrii16e0b4e2016-06-07 10:34:28 -07002147 gclient_utils.rm_file_or_tree(hook)
2148 print('Gerrit commit-msg hook removed.')
2149 else:
2150 print('OK, will keep Gerrit commit-msg hook in place.')
2151
Edward Lemur1b52d872019-05-09 21:12:12 +00002152 def _CleanUpOldTraces(self):
2153 """Keep only the last |MAX_TRACES| traces."""
2154 try:
2155 traces = sorted([
2156 os.path.join(TRACES_DIR, f)
2157 for f in os.listdir(TRACES_DIR)
2158 if (os.path.isfile(os.path.join(TRACES_DIR, f))
2159 and not f.startswith('tmp'))
2160 ])
2161 traces_to_delete = traces[:-MAX_TRACES]
2162 for trace in traces_to_delete:
Daniel Chengcf6269b2019-05-18 01:02:12 +00002163 os.remove(trace)
Edward Lemur1b52d872019-05-09 21:12:12 +00002164 except OSError:
2165 print('WARNING: Failed to remove old git traces from\n'
2166 ' %s'
2167 'Consider removing them manually.' % TRACES_DIR)
Edward Lemurdc8e23d2019-05-07 00:45:48 +00002168
Edward Lemur5737f022019-05-17 01:24:00 +00002169 def _WriteGitPushTraces(self, trace_name, traces_dir, git_push_metadata):
Edward Lemur1b52d872019-05-09 21:12:12 +00002170 """Zip and write the git push traces stored in traces_dir."""
2171 gclient_utils.safe_makedirs(TRACES_DIR)
Edward Lemur1b52d872019-05-09 21:12:12 +00002172 traces_zip = trace_name + '-traces'
2173 traces_readme = trace_name + '-README'
Michael Mosse7f0b4c2019-05-08 04:36:24 +00002174 # Create a temporary dir to store git config and gitcookies in. It will be
2175 # compressed and stored next to the traces.
2176 git_info_dir = tempfile.mkdtemp()
Edward Lemur1b52d872019-05-09 21:12:12 +00002177 git_info_zip = trace_name + '-git-info'
2178
Josip Sokcevic5e18b602020-04-23 21:47:00 +00002179 git_push_metadata['now'] = datetime_now().strftime('%Y-%m-%dT%H:%M:%S.%f')
sangwoo.ko7a614332019-05-22 02:46:19 +00002180
Edward Lemur1b52d872019-05-09 21:12:12 +00002181 git_push_metadata['trace_name'] = trace_name
2182 gclient_utils.FileWrite(
2183 traces_readme, TRACES_README_FORMAT % git_push_metadata)
2184
2185 # Keep only the first 6 characters of the git hashes on the packet
2186 # trace. This greatly decreases size after compression.
2187 packet_traces = os.path.join(traces_dir, 'trace-packet')
2188 if os.path.isfile(packet_traces):
2189 contents = gclient_utils.FileRead(packet_traces)
2190 gclient_utils.FileWrite(
2191 packet_traces, GIT_HASH_RE.sub(r'\1', contents))
2192 shutil.make_archive(traces_zip, 'zip', traces_dir)
2193
2194 # Collect and compress the git config and gitcookies.
2195 git_config = RunGit(['config', '-l'])
2196 gclient_utils.FileWrite(
2197 os.path.join(git_info_dir, 'git-config'),
2198 git_config)
2199
2200 cookie_auth = gerrit_util.Authenticator.get()
2201 if isinstance(cookie_auth, gerrit_util.CookiesAuthenticator):
2202 gitcookies_path = cookie_auth.get_gitcookies_path()
2203 if os.path.isfile(gitcookies_path):
2204 gitcookies = gclient_utils.FileRead(gitcookies_path)
2205 gclient_utils.FileWrite(
2206 os.path.join(git_info_dir, 'gitcookies'),
2207 GITCOOKIES_REDACT_RE.sub('REDACTED', gitcookies))
2208 shutil.make_archive(git_info_zip, 'zip', git_info_dir)
2209
Edward Lemur1b52d872019-05-09 21:12:12 +00002210 gclient_utils.rmtree(git_info_dir)
2211
Josip Sokcevicf2cfd3d2021-03-30 18:39:18 +00002212 def _RunGitPushWithTraces(self,
2213 refspec,
2214 refspec_opts,
2215 git_push_metadata,
2216 git_push_options=None):
Edward Lemur1b52d872019-05-09 21:12:12 +00002217 """Run git push and collect the traces resulting from the execution."""
2218 # Create a temporary directory to store traces in. Traces will be compressed
2219 # and stored in a 'traces' dir inside depot_tools.
2220 traces_dir = tempfile.mkdtemp()
Edward Lemur5737f022019-05-17 01:24:00 +00002221 trace_name = os.path.join(
2222 TRACES_DIR, datetime_now().strftime('%Y%m%dT%H%M%S.%f'))
Edward Lemur0f58ae42019-04-30 17:24:12 +00002223
2224 env = os.environ.copy()
2225 env['GIT_REDACT_COOKIES'] = 'o,SSO,GSSO_Uberproxy'
2226 env['GIT_TR2_EVENT'] = os.path.join(traces_dir, 'tr2-event')
Jonathan Nieder9779b142019-05-29 23:19:29 +00002227 env['GIT_TRACE2_EVENT'] = os.path.join(traces_dir, 'tr2-event')
Edward Lemur0f58ae42019-04-30 17:24:12 +00002228 env['GIT_TRACE_CURL'] = os.path.join(traces_dir, 'trace-curl')
2229 env['GIT_TRACE_CURL_NO_DATA'] = '1'
2230 env['GIT_TRACE_PACKET'] = os.path.join(traces_dir, 'trace-packet')
2231
2232 try:
2233 push_returncode = 0
Edward Lemur1b52d872019-05-09 21:12:12 +00002234 remote_url = self.GetRemoteUrl()
Edward Lemur0f58ae42019-04-30 17:24:12 +00002235 before_push = time_time()
Josip Sokcevicf2cfd3d2021-03-30 18:39:18 +00002236 push_cmd = ['git', 'push', remote_url, refspec]
2237 if git_push_options:
2238 for opt in git_push_options:
2239 push_cmd.extend(['-o', opt])
2240
Edward Lemur0f58ae42019-04-30 17:24:12 +00002241 push_stdout = gclient_utils.CheckCallAndFilter(
Josip Sokcevicf2cfd3d2021-03-30 18:39:18 +00002242 push_cmd,
Edward Lemur0f58ae42019-04-30 17:24:12 +00002243 env=env,
2244 print_stdout=True,
2245 # Flush after every line: useful for seeing progress when running as
2246 # recipe.
2247 filter_fn=lambda _: sys.stdout.flush())
Edward Lemur79d4f992019-11-11 23:49:02 +00002248 push_stdout = push_stdout.decode('utf-8', 'replace')
Edward Lemur0f58ae42019-04-30 17:24:12 +00002249 except subprocess2.CalledProcessError as e:
2250 push_returncode = e.returncode
Josip Sokcevic740825e2021-05-12 18:28:34 +00002251 if 'blocked keyword' in str(e.stdout):
2252 raise GitPushError(
2253 'Failed to create a change, very likely due to blocked keyword. '
2254 'Please examine output above for the reason of the failure.\n'
2255 'If this is a false positive, you can try to bypass blocked '
2256 'keyword by using push option '
2257 '-o uploadvalidator~skip, e.g.:\n'
2258 'git cl upload -o uploadvalidator~skip\n\n'
2259 'If git-cl is not working correctly, file a bug under the '
2260 'Infra>SDK component.')
2261
Josip Sokcevicf736cab2020-10-20 23:41:38 +00002262 raise GitPushError(
2263 'Failed to create a change. Please examine output above for the '
2264 'reason of the failure.\n'
Josip Sokcevic7386a1e2021-02-12 19:00:34 +00002265 'For emergencies, Googlers can escalate to '
2266 'go/gob-support or go/notify#gob\n'
Josip Sokcevicf736cab2020-10-20 23:41:38 +00002267 'Hint: run command below to diagnose common Git/Gerrit '
2268 'credential problems:\n'
2269 ' git cl creds-check\n'
2270 '\n'
2271 'If git-cl is not working correctly, file a bug under the Infra>SDK '
2272 'component including the files below.\n'
2273 'Review the files before upload, since they might contain sensitive '
2274 'information.\n'
2275 'Set the Restrict-View-Google label so that they are not publicly '
2276 'accessible.\n' + TRACES_MESSAGE % {'trace_name': trace_name})
Edward Lemur0f58ae42019-04-30 17:24:12 +00002277 finally:
2278 execution_time = time_time() - before_push
2279 metrics.collector.add_repeated('sub_commands', {
2280 'command': 'git push',
2281 'execution_time': execution_time,
2282 'exit_code': push_returncode,
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +00002283 'arguments': metrics_utils.extract_known_subcommand_args(refspec_opts),
Edward Lemur0f58ae42019-04-30 17:24:12 +00002284 })
2285
Edward Lemur1b52d872019-05-09 21:12:12 +00002286 git_push_metadata['execution_time'] = execution_time
2287 git_push_metadata['exit_code'] = push_returncode
Edward Lemur5737f022019-05-17 01:24:00 +00002288 self._WriteGitPushTraces(trace_name, traces_dir, git_push_metadata)
Edward Lemur0f58ae42019-04-30 17:24:12 +00002289
Edward Lemur1b52d872019-05-09 21:12:12 +00002290 self._CleanUpOldTraces()
Edward Lemur0f58ae42019-04-30 17:24:12 +00002291 gclient_utils.rmtree(traces_dir)
2292
2293 return push_stdout
2294
Josip Sokcevicf736cab2020-10-20 23:41:38 +00002295 def CMDUploadChange(self, options, git_diff_args, custom_cl_base,
2296 change_desc):
2297 """Upload the current branch to Gerrit, retry if new remote HEAD is
2298 found. options and change_desc may be mutated."""
Josip Sokcevicb631a882021-01-06 18:18:10 +00002299 remote, remote_branch = self.GetRemoteBranch()
2300 branch = GetTargetRef(remote, remote_branch, options.target_branch)
2301
Josip Sokcevicf736cab2020-10-20 23:41:38 +00002302 try:
2303 return self._CMDUploadChange(options, git_diff_args, custom_cl_base,
Josip Sokcevicb631a882021-01-06 18:18:10 +00002304 change_desc, branch)
Josip Sokcevicf736cab2020-10-20 23:41:38 +00002305 except GitPushError as e:
Josip Sokcevicb631a882021-01-06 18:18:10 +00002306 # Repository might be in the middle of transition to main branch as
2307 # default, and uploads to old default might be blocked.
2308 if remote_branch not in [DEFAULT_OLD_BRANCH, DEFAULT_NEW_BRANCH]:
Josip Sokcevicf736cab2020-10-20 23:41:38 +00002309 DieWithError(str(e), change_desc)
2310
Josip Sokcevicb631a882021-01-06 18:18:10 +00002311 project_head = gerrit_util.GetProjectHead(self._gerrit_host,
2312 self.GetGerritProject())
2313 if project_head == branch:
2314 DieWithError(str(e), change_desc)
2315 branch = project_head
2316
2317 print("WARNING: Fetching remote state and retrying upload to default "
2318 "branch...")
2319 RunGit(['fetch', '--prune', remote])
Josip Sokcevicf736cab2020-10-20 23:41:38 +00002320 options.edit_description = False
2321 options.force = True
2322 try:
Josip Sokcevicb631a882021-01-06 18:18:10 +00002323 self._CMDUploadChange(options, git_diff_args, custom_cl_base,
2324 change_desc, branch)
Josip Sokcevicf736cab2020-10-20 23:41:38 +00002325 except GitPushError as e:
2326 DieWithError(str(e), change_desc)
2327
2328 def _CMDUploadChange(self, options, git_diff_args, custom_cl_base,
Josip Sokcevicb631a882021-01-06 18:18:10 +00002329 change_desc, branch):
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002330 """Upload the current branch to Gerrit."""
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002331 if options.squash:
tandrii16e0b4e2016-06-07 10:34:28 -07002332 self._GerritCommitMsgHookCheck(offer_removal=not options.force)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002333 if self.GetIssue():
Josipe827b0f2020-01-30 00:07:20 +00002334 # User requested to change description
2335 if options.edit_description:
Josipe827b0f2020-01-30 00:07:20 +00002336 change_desc.prompt()
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002337 change_id = self._GetChangeDetail()['change_id']
Edward Lemur5a644f82020-03-18 16:44:57 +00002338 change_desc.ensure_change_id(change_id)
Aaron Gableb56ad332017-01-06 15:24:31 -08002339 else: # if not self.GetIssue()
Gavin Mak68e6cf32021-01-25 18:24:08 +00002340 if not options.force and not options.message_file:
Anthony Polito8b955342019-09-24 19:01:36 +00002341 change_desc.prompt()
Andrii Shyshkalov8c90d032017-04-19 21:27:26 +02002342 change_ids = git_footers.get_footer_change_id(change_desc.description)
Edward Lemur5a644f82020-03-18 16:44:57 +00002343 if len(change_ids) == 1:
2344 change_id = change_ids[0]
2345 else:
2346 change_id = GenerateGerritChangeId(change_desc.description)
2347 change_desc.ensure_change_id(change_id)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002348
Andrii Shyshkalov71f0da32019-07-15 22:45:18 +00002349 if options.preserve_tryjobs:
2350 change_desc.set_preserve_tryjobs()
Robert Iannuccidb02dd02017-04-19 12:18:20 -07002351
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002352 remote, upstream_branch = self.FetchUpstreamTuple(self.GetBranch())
Edward Lemur5a644f82020-03-18 16:44:57 +00002353 parent = self._ComputeParent(
2354 remote, upstream_branch, custom_cl_base, options.force, change_desc)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002355 tree = RunGit(['rev-parse', 'HEAD:']).strip()
Edward Lemur1773f372020-02-22 00:27:14 +00002356 with gclient_utils.temporary_file() as desc_tempfile:
2357 gclient_utils.FileWrite(desc_tempfile, change_desc.description)
2358 ref_to_push = RunGit(
2359 ['commit-tree', tree, '-p', parent, '-F', desc_tempfile]).strip()
Anthony Polito8b955342019-09-24 19:01:36 +00002360 else: # if not options.squash
Gregory Nisbet48d9e1e2021-04-15 23:35:54 +00002361 if options.no_add_changeid:
2362 pass
2363 else: # adding Change-Ids is okay.
2364 if not git_footers.get_footer_change_id(change_desc.description):
2365 DownloadGerritHook(False)
2366 change_desc.set_description(
2367 self._AddChangeIdToCommitMessage(change_desc.description,
2368 git_diff_args))
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002369 ref_to_push = 'HEAD'
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002370 # For no-squash mode, we assume the remote called "origin" is the one we
2371 # want. It is not worthwhile to support different workflows for
2372 # no-squash mode.
2373 parent = 'origin/%s' % branch
Gregory Nisbet48d9e1e2021-04-15 23:35:54 +00002374 # attempt to extract the changeid from the current description
2375 # fail informatively if not possible.
2376 change_id_candidates = git_footers.get_footer_change_id(
2377 change_desc.description)
2378 if not change_id_candidates:
2379 DieWithError("Unable to extract change-id from message.")
2380 change_id = change_id_candidates[0]
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002381
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +00002382 SaveDescriptionBackup(change_desc)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002383 commits = RunGitSilent(['rev-list', '%s..%s' % (parent,
2384 ref_to_push)]).splitlines()
2385 if len(commits) > 1:
2386 print('WARNING: This will upload %d commits. Run the following command '
2387 'to see which commits will be uploaded: ' % len(commits))
2388 print('git log %s..%s' % (parent, ref_to_push))
2389 print('You can also use `git squash-branch` to squash these into a '
2390 'single commit.')
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002391 confirm_or_exit(action='upload')
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002392
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00002393 reviewers = sorted(change_desc.get_reviewers())
Edward Lemur4508b422019-10-03 21:56:35 +00002394 cc = []
2395 # Add CCs from WATCHLISTS and rietveld.cc git config unless this is
2396 # the initial upload, the CL is private, or auto-CCing has ben disabled.
2397 if not (self.GetIssue() or options.private or options.no_autocc):
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00002398 cc = self.GetCCList().split(',')
Gavin Makb1c08f62021-04-01 18:05:58 +00002399 if len(cc) > 100:
2400 lsc = ('https://chromium.googlesource.com/chromium/src/+/HEAD/docs/'
2401 'process/lsc/lsc_workflow.md')
2402 print('WARNING: This will auto-CC %s users.' % len(cc))
2403 print('LSC may be more appropriate: %s' % lsc)
2404 print('You can also use the --no-autocc flag to disable auto-CC.')
2405 confirm_or_exit(action='continue')
Edward Lemur4508b422019-10-03 21:56:35 +00002406 # Add cc's from the --cc flag.
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00002407 if options.cc:
2408 cc.extend(options.cc)
Edward Lemur79d4f992019-11-11 23:49:02 +00002409 cc = [email.strip() for email in cc if email.strip()]
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00002410 if change_desc.get_cced():
2411 cc.extend(change_desc.get_cced())
Edward Lesmeseeca9c62020-11-20 00:00:17 +00002412 if self.GetGerritHost() == 'chromium-review.googlesource.com':
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00002413 valid_accounts = set(reviewers + cc)
2414 # TODO(crbug/877717): relax this for all hosts.
2415 else:
2416 valid_accounts = gerrit_util.ValidAccounts(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00002417 self.GetGerritHost(), reviewers + cc)
Andrii Shyshkalovf170af42018-10-30 07:00:44 +00002418 logging.info('accounts %s are recognized, %s invalid',
2419 sorted(valid_accounts),
2420 set(reviewers + cc).difference(set(valid_accounts)))
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00002421
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00002422 # Extra options that can be specified at push time. Doc:
2423 # https://gerrit-review.googlesource.com/Documentation/user-upload.html
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +00002424 refspec_opts = []
Andrii Shyshkalov2d8a2072017-04-10 15:02:18 +02002425
Aaron Gable844cf292017-06-28 11:32:59 -07002426 # By default, new changes are started in WIP mode, and subsequent patchsets
2427 # don't send email. At any time, passing --send-mail will mark the change
2428 # ready and send email for that particular patch.
Aaron Gableafd52772017-06-27 16:40:10 -07002429 if options.send_mail:
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +00002430 refspec_opts.append('ready')
2431 refspec_opts.append('notify=ALL')
Jamie Madill276da0b2018-04-27 14:41:20 -04002432 elif not self.GetIssue() and options.squash:
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +00002433 refspec_opts.append('wip')
Aaron Gableafd52772017-06-27 16:40:10 -07002434 else:
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +00002435 refspec_opts.append('notify=NONE')
Aaron Gable70f4e242017-06-26 10:45:59 -07002436
Andrii Shyshkalov2d8a2072017-04-10 15:02:18 +02002437 # TODO(tandrii): options.message should be posted as a comment
Aaron Gablee5adf612017-07-14 10:43:58 -07002438 # if --send-mail is set on non-initial upload as Rietveld used to do it.
Andrii Shyshkalov2d8a2072017-04-10 15:02:18 +02002439
Josip Sokcevicf736cab2020-10-20 23:41:38 +00002440 # Set options.title in case user was prompted in _GetTitleForUpload and
2441 # _CMDUploadChange needs to be called again.
2442 options.title = self._GetTitleForUpload(options)
2443 if options.title:
Nick Carter8692b182017-11-06 16:30:38 -08002444 # Punctuation and whitespace in |title| must be percent-encoded.
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +00002445 refspec_opts.append(
Josip Sokcevicf736cab2020-10-20 23:41:38 +00002446 'm=' + gerrit_util.PercentEncodeForGitRef(options.title))
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00002447
agablec6787972016-09-09 16:13:34 -07002448 if options.private:
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +00002449 refspec_opts.append('private')
agablec6787972016-09-09 16:13:34 -07002450
Andrii Shyshkalov2f727912018-10-15 17:02:33 +00002451 for r in sorted(reviewers):
2452 if r in valid_accounts:
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +00002453 refspec_opts.append('r=%s' % r)
Andrii Shyshkalov2f727912018-10-15 17:02:33 +00002454 reviewers.remove(r)
2455 else:
2456 # TODO(tandrii): this should probably be a hard failure.
2457 print('WARNING: reviewer %s doesn\'t have a Gerrit account, skipping'
2458 % r)
2459 for c in sorted(cc):
2460 # refspec option will be rejected if cc doesn't correspond to an
2461 # account, even though REST call to add such arbitrary cc may succeed.
2462 if c in valid_accounts:
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +00002463 refspec_opts.append('cc=%s' % c)
Andrii Shyshkalov2f727912018-10-15 17:02:33 +00002464 cc.remove(c)
2465
rmistry9eadede2016-09-19 11:22:43 -07002466 if options.topic:
2467 # Documentation on Gerrit topics is here:
2468 # https://gerrit-review.googlesource.com/Documentation/user-upload.html#topic
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +00002469 refspec_opts.append('topic=%s' % options.topic)
rmistry9eadede2016-09-19 11:22:43 -07002470
Edward Lemur687ca902018-12-05 02:30:30 +00002471 if options.enable_auto_submit:
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +00002472 refspec_opts.append('l=Auto-Submit+1')
Edward Lesmes10c3dd62021-02-08 21:13:57 +00002473 if options.set_bot_commit:
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +00002474 refspec_opts.append('l=Bot-Commit+1')
Edward Lemur687ca902018-12-05 02:30:30 +00002475 if options.use_commit_queue:
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +00002476 refspec_opts.append('l=Commit-Queue+2')
Edward Lemur687ca902018-12-05 02:30:30 +00002477 elif options.cq_dry_run:
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +00002478 refspec_opts.append('l=Commit-Queue+1')
Greg Gutermanbe5fccd2021-06-14 17:58:20 +00002479 elif options.cq_quick_run:
2480 refspec_opts.append('l=Commit-Queue+1')
2481 refspec_opts.append('l=Quick-Run+1')
Edward Lemur687ca902018-12-05 02:30:30 +00002482
2483 if change_desc.get_reviewers(tbr_only=True):
2484 score = gerrit_util.GetCodeReviewTbrScore(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00002485 self.GetGerritHost(),
2486 self.GetGerritProject())
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +00002487 refspec_opts.append('l=Code-Review+%s' % score)
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00002488
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08002489 # Gerrit sorts hashtags, so order is not important.
Nodir Turakulov23b82142017-11-16 11:04:25 -08002490 hashtags = {change_desc.sanitize_hash_tag(t) for t in options.hashtags}
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08002491 if not self.GetIssue():
Nodir Turakulov23b82142017-11-16 11:04:25 -08002492 hashtags.update(change_desc.get_hash_tags())
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +00002493 refspec_opts += ['hashtag=%s' % t for t in sorted(hashtags)]
2494
2495 refspec_suffix = ''
2496 if refspec_opts:
2497 refspec_suffix = '%' + ','.join(refspec_opts)
2498 assert ' ' not in refspec_suffix, (
2499 'spaces not allowed in refspec: "%s"' % refspec_suffix)
2500 refspec = '%s:refs/for/%s%s' % (ref_to_push, branch, refspec_suffix)
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00002501
Edward Lemur1b52d872019-05-09 21:12:12 +00002502 git_push_metadata = {
Edward Lesmeseeca9c62020-11-20 00:00:17 +00002503 'gerrit_host': self.GetGerritHost(),
Josip Sokcevicf736cab2020-10-20 23:41:38 +00002504 'title': options.title or '<untitled>',
Edward Lemur1b52d872019-05-09 21:12:12 +00002505 'change_id': change_id,
2506 'description': change_desc.description,
2507 }
Josip Sokcevicf2cfd3d2021-03-30 18:39:18 +00002508
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +00002509 push_stdout = self._RunGitPushWithTraces(refspec, refspec_opts,
Josip Sokcevicf2cfd3d2021-03-30 18:39:18 +00002510 git_push_metadata,
2511 options.push_options)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002512
2513 if options.squash:
Aaron Gable289b4312017-09-13 14:06:16 -07002514 regex = re.compile(r'remote:\s+https?://[\w\-\.\+\/#]*/(\d+)\s.*')
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002515 change_numbers = [m.group(1)
2516 for m in map(regex.match, push_stdout.splitlines())
2517 if m]
2518 if len(change_numbers) != 1:
2519 DieWithError(
2520 ('Created|Updated %d issues on Gerrit, but only 1 expected.\n'
Christopher Lamf732cd52017-01-24 12:40:11 +11002521 'Change-Id: %s') % (len(change_numbers), change_id), change_desc)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002522 self.SetIssue(change_numbers[0])
tandrii5d48c322016-08-18 16:19:37 -07002523 self._GitSetBranchConfigValue('gerritsquashhash', ref_to_push)
tandrii88189772016-09-29 04:29:57 -07002524
Andrii Shyshkalov2f727912018-10-15 17:02:33 +00002525 if self.GetIssue() and (reviewers or cc):
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00002526 # GetIssue() is not set in case of non-squash uploads according to tests.
Aaron Gable6e7ddb62020-05-27 22:23:29 +00002527 # TODO(crbug.com/751901): non-squash uploads in git cl should be removed.
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00002528 gerrit_util.AddReviewers(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00002529 self.GetGerritHost(),
Andrii Shyshkalovd06cc782018-08-23 17:24:19 +00002530 self._GerritChangeIdentifier(),
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00002531 reviewers, cc,
2532 notify=bool(options.send_mail))
Aaron Gable6dadfbf2017-05-09 14:27:58 -07002533
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002534 return 0
2535
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002536 def _ComputeParent(self, remote, upstream_branch, custom_cl_base, force,
2537 change_desc):
2538 """Computes parent of the generated commit to be uploaded to Gerrit.
2539
2540 Returns revision or a ref name.
2541 """
2542 if custom_cl_base:
2543 # Try to avoid creating additional unintended CLs when uploading, unless
2544 # user wants to take this risk.
2545 local_ref_of_target_remote = self.GetRemoteBranch()[1]
2546 code, _ = RunGitWithCode(['merge-base', '--is-ancestor', custom_cl_base,
2547 local_ref_of_target_remote])
2548 if code == 1:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002549 print('\nWARNING: Manually specified base of this CL `%s` '
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002550 'doesn\'t seem to belong to target remote branch `%s`.\n\n'
2551 'If you proceed with upload, more than 1 CL may be created by '
2552 'Gerrit as a result, in turn confusing or crashing git cl.\n\n'
2553 'If you are certain that specified base `%s` has already been '
2554 'uploaded to Gerrit as another CL, you may proceed.\n' %
2555 (custom_cl_base, local_ref_of_target_remote, custom_cl_base))
2556 if not force:
2557 confirm_or_exit(
2558 'Do you take responsibility for cleaning up potential mess '
2559 'resulting from proceeding with upload?',
2560 action='upload')
2561 return custom_cl_base
2562
Aaron Gablef97e33d2017-03-30 15:44:27 -07002563 if remote != '.':
2564 return self.GetCommonAncestorWithUpstream()
2565
2566 # If our upstream branch is local, we base our squashed commit on its
2567 # squashed version.
2568 upstream_branch_name = scm.GIT.ShortBranchName(upstream_branch)
2569
Aaron Gablef97e33d2017-03-30 15:44:27 -07002570 if upstream_branch_name == 'master':
Aaron Gable0bbd1c22017-05-08 14:37:08 -07002571 return self.GetCommonAncestorWithUpstream()
Glen Robertson7d98e222020-08-27 17:53:11 +00002572 if upstream_branch_name == 'main':
2573 return self.GetCommonAncestorWithUpstream()
Aaron Gablef97e33d2017-03-30 15:44:27 -07002574
2575 # Check the squashed hash of the parent.
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002576 # TODO(tandrii): consider checking parent change in Gerrit and using its
2577 # hash if tree hash of latest parent revision (patchset) in Gerrit matches
2578 # the tree hash of the parent branch. The upside is less likely bogus
2579 # requests to reupload parent change just because it's uploadhash is
2580 # missing, yet the downside likely exists, too (albeit unknown to me yet).
Edward Lesmesa680c232020-03-31 18:26:44 +00002581 parent = scm.GIT.GetBranchConfig(
2582 settings.GetRoot(), upstream_branch_name, 'gerritsquashhash')
Aaron Gablef97e33d2017-03-30 15:44:27 -07002583 # Verify that the upstream branch has been uploaded too, otherwise
2584 # Gerrit will create additional CLs when uploading.
2585 if not parent or (RunGitSilent(['rev-parse', upstream_branch + ':']) !=
2586 RunGitSilent(['rev-parse', parent + ':'])):
2587 DieWithError(
2588 '\nUpload upstream branch %s first.\n'
2589 'It is likely that this branch has been rebased since its last '
2590 'upload, so you just need to upload it again.\n'
2591 '(If you uploaded it with --no-squash, then branch dependencies '
2592 'are not supported, and you should reupload with --squash.)'
2593 % upstream_branch_name,
2594 change_desc)
2595 return parent
2596
Edward Lemura12175c2020-03-09 16:58:26 +00002597 def _AddChangeIdToCommitMessage(self, log_desc, args):
tandrii@chromium.org8930b3d2016-04-13 14:47:02 +00002598 """Re-commits using the current message, assumes the commit hook is in
2599 place.
2600 """
Edward Lemura12175c2020-03-09 16:58:26 +00002601 RunGit(['commit', '--amend', '-m', log_desc])
Andrii Shyshkalovb07575f2018-10-16 06:16:21 +00002602 new_log_desc = _create_description_from_log(args)
tandrii@chromium.org8930b3d2016-04-13 14:47:02 +00002603 if git_footers.get_footer_change_id(new_log_desc):
vapiera7fbd5a2016-06-16 09:17:49 -07002604 print('git-cl: Added Change-Id to commit message.')
tandrii@chromium.org8930b3d2016-04-13 14:47:02 +00002605 return new_log_desc
2606 else:
tandrii@chromium.orgb067ec52016-05-31 15:24:44 +00002607 DieWithError('ERROR: Gerrit commit-msg hook not installed.')
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002608
tandriie113dfd2016-10-11 10:20:12 -07002609 def CannotTriggerTryJobReason(self):
tandrii8c5a3532016-11-04 07:52:02 -07002610 try:
2611 data = self._GetChangeDetail()
Aaron Gablea45ee112016-11-22 15:14:38 -08002612 except GerritChangeNotExists:
2613 return 'Gerrit doesn\'t know about your change %s' % self.GetIssue()
tandrii8c5a3532016-11-04 07:52:02 -07002614
2615 if data['status'] in ('ABANDONED', 'MERGED'):
2616 return 'CL %s is closed' % self.GetIssue()
2617
Edward Lemurd4d1ba42019-09-20 21:46:37 +00002618 def GetGerritChange(self, patchset=None):
2619 """Returns a buildbucket.v2.GerritChange message for the current issue."""
Edward Lemur79d4f992019-11-11 23:49:02 +00002620 host = urllib.parse.urlparse(self.GetCodereviewServer()).hostname
Edward Lemurd4d1ba42019-09-20 21:46:37 +00002621 issue = self.GetIssue()
Edward Lemur2c210a42019-09-16 23:58:35 +00002622 patchset = int(patchset or self.GetPatchset())
Edward Lemurd4d1ba42019-09-20 21:46:37 +00002623 data = self._GetChangeDetail(['ALL_REVISIONS'])
2624
2625 assert host and issue and patchset, 'CL must be uploaded first'
2626
2627 has_patchset = any(
2628 int(revision_data['_number']) == patchset
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00002629 for revision_data in data['revisions'].values())
Edward Lemurd4d1ba42019-09-20 21:46:37 +00002630 if not has_patchset:
Aaron Gablea45ee112016-11-22 15:14:38 -08002631 raise Exception('Patchset %d is not known in Gerrit change %d' %
tandrii8c5a3532016-11-04 07:52:02 -07002632 (patchset, self.GetIssue()))
Edward Lemurd4d1ba42019-09-20 21:46:37 +00002633
tandrii8c5a3532016-11-04 07:52:02 -07002634 return {
Edward Lemurd4d1ba42019-09-20 21:46:37 +00002635 'host': host,
2636 'change': issue,
2637 'project': data['project'],
2638 'patchset': patchset,
tandrii8c5a3532016-11-04 07:52:02 -07002639 }
tandriie113dfd2016-10-11 10:20:12 -07002640
tandriide281ae2016-10-12 06:02:30 -07002641 def GetIssueOwner(self):
tandrii8c5a3532016-11-04 07:52:02 -07002642 return self._GetChangeDetail(['DETAILED_ACCOUNTS'])['owner']['email']
tandriide281ae2016-10-12 06:02:30 -07002643
Edward Lemur707d70b2018-02-07 00:50:14 +01002644 def GetReviewers(self):
2645 details = self._GetChangeDetail(['DETAILED_ACCOUNTS'])
Mohamed Heikal171c0742018-11-09 20:38:51 +00002646 return [r['email'] for r in details['reviewers'].get('REVIEWER', [])]
Edward Lemur707d70b2018-02-07 00:50:14 +01002647
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002648
Lei Zhang8a0efc12020-08-05 19:58:45 +00002649def _get_bug_line_values(default_project_prefix, bugs):
2650 """Given default_project_prefix and comma separated list of bugs, yields bug
2651 line values.
tandriif9aefb72016-07-01 09:06:51 -07002652
2653 Each bug can be either:
Lei Zhang8a0efc12020-08-05 19:58:45 +00002654 * a number, which is combined with default_project_prefix
tandriif9aefb72016-07-01 09:06:51 -07002655 * string, which is left as is.
2656
2657 This function may produce more than one line, because bugdroid expects one
2658 project per line.
2659
Lei Zhang8a0efc12020-08-05 19:58:45 +00002660 >>> list(_get_bug_line_values('v8:', '123,chromium:789'))
tandriif9aefb72016-07-01 09:06:51 -07002661 ['v8:123', 'chromium:789']
2662 """
2663 default_bugs = []
2664 others = []
2665 for bug in bugs.split(','):
2666 bug = bug.strip()
2667 if bug:
2668 try:
2669 default_bugs.append(int(bug))
2670 except ValueError:
2671 others.append(bug)
2672
2673 if default_bugs:
2674 default_bugs = ','.join(map(str, default_bugs))
Lei Zhang8a0efc12020-08-05 19:58:45 +00002675 if default_project_prefix:
2676 if not default_project_prefix.endswith(':'):
2677 default_project_prefix += ':'
2678 yield '%s%s' % (default_project_prefix, default_bugs)
tandriif9aefb72016-07-01 09:06:51 -07002679 else:
2680 yield default_bugs
2681 for other in sorted(others):
2682 # Don't bother finding common prefixes, CLs with >2 bugs are very very rare.
2683 yield other
2684
2685
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00002686class ChangeDescription(object):
2687 """Contains a parsed form of the change description."""
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00002688 R_LINE = r'^[ \t]*(TBR|R)[ \t]*=[ \t]*(.*?)[ \t]*$'
bradnelsond975b302016-10-23 12:20:23 -07002689 CC_LINE = r'^[ \t]*(CC)[ \t]*=[ \t]*(.*?)[ \t]*$'
Aaron Gable3a16ed12017-03-23 10:51:55 -07002690 BUG_LINE = r'^[ \t]*(?:(BUG)[ \t]*=|Bug:)[ \t]*(.*?)[ \t]*$'
Dan Beamd8b04ca2019-10-10 21:23:26 +00002691 FIXED_LINE = r'^[ \t]*Fixed[ \t]*:[ \t]*(.*?)[ \t]*$'
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01002692 CHERRY_PICK_LINE = r'^\(cherry picked from commit [a-fA-F0-9]{40}\)$'
Nodir Turakulov23b82142017-11-16 11:04:25 -08002693 STRIP_HASH_TAG_PREFIX = r'^(\s*(revert|reland)( "|:)?\s*)*'
2694 BRACKET_HASH_TAG = r'\s*\[([^\[\]]+)\]'
Anthony Polito02b5af32019-12-02 19:49:47 +00002695 COLON_SEPARATED_HASH_TAG = r'^([a-zA-Z0-9_\- ]+):($|[^:])'
Nodir Turakulov23b82142017-11-16 11:04:25 -08002696 BAD_HASH_TAG_CHUNK = r'[^a-zA-Z0-9]+'
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00002697
Dan Beamd8b04ca2019-10-10 21:23:26 +00002698 def __init__(self, description, bug=None, fixed=None):
agable@chromium.org42c20792013-09-12 17:34:49 +00002699 self._description_lines = (description or '').strip().splitlines()
Anthony Polito8b955342019-09-24 19:01:36 +00002700 if bug:
2701 regexp = re.compile(self.BUG_LINE)
2702 prefix = settings.GetBugPrefix()
2703 if not any((regexp.match(line) for line in self._description_lines)):
2704 values = list(_get_bug_line_values(prefix, bug))
2705 self.append_footer('Bug: %s' % ', '.join(values))
Dan Beamd8b04ca2019-10-10 21:23:26 +00002706 if fixed:
2707 regexp = re.compile(self.FIXED_LINE)
2708 prefix = settings.GetBugPrefix()
2709 if not any((regexp.match(line) for line in self._description_lines)):
2710 values = list(_get_bug_line_values(prefix, fixed))
2711 self.append_footer('Fixed: %s' % ', '.join(values))
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002712
agable@chromium.org42c20792013-09-12 17:34:49 +00002713 @property # www.logilab.org/ticket/89786
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -08002714 def description(self): # pylint: disable=method-hidden
agable@chromium.org42c20792013-09-12 17:34:49 +00002715 return '\n'.join(self._description_lines)
2716
2717 def set_description(self, desc):
2718 if isinstance(desc, basestring):
2719 lines = desc.splitlines()
2720 else:
2721 lines = [line.rstrip() for line in desc]
2722 while lines and not lines[0]:
2723 lines.pop(0)
2724 while lines and not lines[-1]:
2725 lines.pop(-1)
2726 self._description_lines = lines
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002727
Edward Lemur5a644f82020-03-18 16:44:57 +00002728 def ensure_change_id(self, change_id):
2729 description = self.description
2730 footer_change_ids = git_footers.get_footer_change_id(description)
2731 # Make sure that the Change-Id in the description matches the given one.
2732 if footer_change_ids != [change_id]:
2733 if footer_change_ids:
2734 # Remove any existing Change-Id footers since they don't match the
2735 # expected change_id footer.
2736 description = git_footers.remove_footer(description, 'Change-Id')
2737 print('WARNING: Change-Id has been set to %s. Use `git cl issue 0` '
2738 'if you want to set a new one.')
2739 # Add the expected Change-Id footer.
2740 description = git_footers.add_footer_change_id(description, change_id)
2741 self.set_description(description)
2742
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00002743 def update_reviewers(self, reviewers, tbrs):
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002744 """Rewrites the R=/TBR= line(s) as a single line each.
2745
2746 Args:
2747 reviewers (list(str)) - list of additional emails to use for reviewers.
2748 tbrs (list(str)) - list of additional emails to use for TBRs.
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002749 """
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00002750 if not reviewers and not tbrs:
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002751 return
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002752
2753 reviewers = set(reviewers)
2754 tbrs = set(tbrs)
2755 LOOKUP = {
2756 'TBR': tbrs,
2757 'R': reviewers,
2758 }
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002759
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002760 # Get the set of R= and TBR= lines and remove them from the description.
agable@chromium.org42c20792013-09-12 17:34:49 +00002761 regexp = re.compile(self.R_LINE)
2762 matches = [regexp.match(line) for line in self._description_lines]
2763 new_desc = [l for i, l in enumerate(self._description_lines)
2764 if not matches[i]]
2765 self.set_description(new_desc)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002766
agable@chromium.org42c20792013-09-12 17:34:49 +00002767 # Construct new unified R= and TBR= lines.
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002768
2769 # First, update tbrs/reviewers with names from the R=/TBR= lines (if any).
agable@chromium.org42c20792013-09-12 17:34:49 +00002770 for match in matches:
2771 if not match:
2772 continue
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002773 LOOKUP[match.group(1)].update(cleanup_list([match.group(2).strip()]))
2774
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002775 # If any folks ended up in both groups, remove them from tbrs.
2776 tbrs -= reviewers
Robert Iannuccif2708bd2017-04-17 15:49:02 -07002777
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002778 new_r_line = 'R=' + ', '.join(sorted(reviewers)) if reviewers else None
2779 new_tbr_line = 'TBR=' + ', '.join(sorted(tbrs)) if tbrs else None
agable@chromium.org42c20792013-09-12 17:34:49 +00002780
2781 # Put the new lines in the description where the old first R= line was.
2782 line_loc = next((i for i, match in enumerate(matches) if match), -1)
2783 if 0 <= line_loc < len(self._description_lines):
2784 if new_tbr_line:
2785 self._description_lines.insert(line_loc, new_tbr_line)
2786 if new_r_line:
2787 self._description_lines.insert(line_loc, new_r_line)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002788 else:
agable@chromium.org42c20792013-09-12 17:34:49 +00002789 if new_r_line:
2790 self.append_footer(new_r_line)
2791 if new_tbr_line:
2792 self.append_footer(new_tbr_line)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002793
Andrii Shyshkalov71f0da32019-07-15 22:45:18 +00002794 def set_preserve_tryjobs(self):
2795 """Ensures description footer contains 'Cq-Do-Not-Cancel-Tryjobs: true'."""
2796 footers = git_footers.parse_footers(self.description)
2797 for v in footers.get('Cq-Do-Not-Cancel-Tryjobs', []):
2798 if v.lower() == 'true':
2799 return
2800 self.append_footer('Cq-Do-Not-Cancel-Tryjobs: true')
2801
Anthony Polito8b955342019-09-24 19:01:36 +00002802 def prompt(self):
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002803 """Asks the user to update the description."""
agable@chromium.org42c20792013-09-12 17:34:49 +00002804 self.set_description([
2805 '# Enter a description of the change.',
2806 '# This will be displayed on the codereview site.',
2807 '# The first line will also be used as the subject of the review.',
alancutter@chromium.orgbd1073e2013-06-01 00:34:38 +00002808 '#--------------------This line is 72 characters long'
agable@chromium.org42c20792013-09-12 17:34:49 +00002809 '--------------------',
2810 ] + self._description_lines)
Dan Beamd8b04ca2019-10-10 21:23:26 +00002811 bug_regexp = re.compile(self.BUG_LINE)
2812 fixed_regexp = re.compile(self.FIXED_LINE)
Jonas Termansend0f79112019-03-22 15:28:26 +00002813 prefix = settings.GetBugPrefix()
Sigurd Schneider8630bb12020-11-11 14:02:49 +00002814 has_issue = lambda l: bug_regexp.match(l) or fixed_regexp.match(l)
Sigurd Schneider9abde8c2020-11-17 08:44:52 +00002815
Dan Beamd8b04ca2019-10-10 21:23:26 +00002816 if not any((has_issue(line) for line in self._description_lines)):
Anthony Polito8b955342019-09-24 19:01:36 +00002817 self.append_footer('Bug: %s' % prefix)
tandriif9aefb72016-07-01 09:06:51 -07002818
Bruce Dawsonfc487042020-10-27 19:11:37 +00002819 print('Waiting for editor...')
agable@chromium.org42c20792013-09-12 17:34:49 +00002820 content = gclient_utils.RunEditor(self.description, True,
Edward Lemur79d4f992019-11-11 23:49:02 +00002821 git_editor=settings.GetGitEditor())
maruel@chromium.org0e0436a2011-10-25 13:32:41 +00002822 if not content:
2823 DieWithError('Running editor failed')
agable@chromium.org42c20792013-09-12 17:34:49 +00002824 lines = content.splitlines()
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002825
Bruce Dawson2377b012018-01-11 16:46:49 -08002826 # Strip off comments and default inserted "Bug:" line.
2827 clean_lines = [line.rstrip() for line in lines if not
Jonas Termansend0f79112019-03-22 15:28:26 +00002828 (line.startswith('#') or
2829 line.rstrip() == "Bug:" or
2830 line.rstrip() == "Bug: " + prefix)]
agable@chromium.org42c20792013-09-12 17:34:49 +00002831 if not clean_lines:
maruel@chromium.org0e0436a2011-10-25 13:32:41 +00002832 DieWithError('No CL description, aborting')
agable@chromium.org42c20792013-09-12 17:34:49 +00002833 self.set_description(clean_lines)
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00002834
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002835 def append_footer(self, line):
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002836 """Adds a footer line to the description.
2837
2838 Differentiates legacy "KEY=xxx" footers (used to be called tags) and
2839 Gerrit's footers in the form of "Footer-Key: footer any value" and ensures
2840 that Gerrit footers are always at the end.
2841 """
2842 parsed_footer_line = git_footers.parse_footer(line)
2843 if parsed_footer_line:
2844 # Line is a gerrit footer in the form: Footer-Key: any value.
2845 # Thus, must be appended observing Gerrit footer rules.
2846 self.set_description(
2847 git_footers.add_footer(self.description,
2848 key=parsed_footer_line[0],
2849 value=parsed_footer_line[1]))
2850 return
2851
2852 if not self._description_lines:
2853 self._description_lines.append(line)
2854 return
2855
2856 top_lines, gerrit_footers, _ = git_footers.split_footers(self.description)
2857 if gerrit_footers:
2858 # git_footers.split_footers ensures that there is an empty line before
2859 # actual (gerrit) footers, if any. We have to keep it that way.
2860 assert top_lines and top_lines[-1] == ''
2861 top_lines, separator = top_lines[:-1], top_lines[-1:]
2862 else:
2863 separator = [] # No need for separator if there are no gerrit_footers.
2864
2865 prev_line = top_lines[-1] if top_lines else ''
2866 if (not presubmit_support.Change.TAG_LINE_RE.match(prev_line) or
2867 not presubmit_support.Change.TAG_LINE_RE.match(line)):
2868 top_lines.append('')
2869 top_lines.append(line)
2870 self._description_lines = top_lines + separator + gerrit_footers
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00002871
tandrii99a72f22016-08-17 14:33:24 -07002872 def get_reviewers(self, tbr_only=False):
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002873 """Retrieves the list of reviewers."""
agable@chromium.org42c20792013-09-12 17:34:49 +00002874 matches = [re.match(self.R_LINE, line) for line in self._description_lines]
tandrii99a72f22016-08-17 14:33:24 -07002875 reviewers = [match.group(2).strip()
2876 for match in matches
2877 if match and (not tbr_only or match.group(1).upper() == 'TBR')]
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002878 return cleanup_list(reviewers)
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00002879
bradnelsond975b302016-10-23 12:20:23 -07002880 def get_cced(self):
2881 """Retrieves the list of reviewers."""
2882 matches = [re.match(self.CC_LINE, line) for line in self._description_lines]
2883 cced = [match.group(2).strip() for match in matches if match]
2884 return cleanup_list(cced)
2885
Nodir Turakulov23b82142017-11-16 11:04:25 -08002886 def get_hash_tags(self):
2887 """Extracts and sanitizes a list of Gerrit hashtags."""
2888 subject = (self._description_lines or ('',))[0]
2889 subject = re.sub(
2890 self.STRIP_HASH_TAG_PREFIX, '', subject, flags=re.IGNORECASE)
2891
2892 tags = []
2893 start = 0
2894 bracket_exp = re.compile(self.BRACKET_HASH_TAG)
2895 while True:
2896 m = bracket_exp.match(subject, start)
2897 if not m:
2898 break
2899 tags.append(self.sanitize_hash_tag(m.group(1)))
2900 start = m.end()
2901
2902 if not tags:
2903 # Try "Tag: " prefix.
2904 m = re.match(self.COLON_SEPARATED_HASH_TAG, subject)
2905 if m:
2906 tags.append(self.sanitize_hash_tag(m.group(1)))
2907 return tags
2908
2909 @classmethod
2910 def sanitize_hash_tag(cls, tag):
2911 """Returns a sanitized Gerrit hash tag.
2912
2913 A sanitized hashtag can be used as a git push refspec parameter value.
2914 """
2915 return re.sub(cls.BAD_HASH_TAG_CHUNK, '-', tag).strip('-').lower()
2916
maruel@chromium.orge52678e2013-04-26 18:34:44 +00002917
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00002918def FindCodereviewSettingsFile(filename='codereview.settings'):
2919 """Finds the given file starting in the cwd and going up.
2920
2921 Only looks up to the top of the repository unless an
2922 'inherit-review-settings-ok' file exists in the root of the repository.
2923 """
2924 inherit_ok_file = 'inherit-review-settings-ok'
2925 cwd = os.getcwd()
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00002926 root = settings.GetRoot()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00002927 if os.path.isfile(os.path.join(root, inherit_ok_file)):
2928 root = '/'
2929 while True:
2930 if filename in os.listdir(cwd):
2931 if os.path.isfile(os.path.join(cwd, filename)):
2932 return open(os.path.join(cwd, filename))
2933 if cwd == root:
2934 break
2935 cwd = os.path.dirname(cwd)
2936
2937
2938def LoadCodereviewSettingsFromFile(fileobj):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002939 """Parses a codereview.settings file and updates hooks."""
maruel@chromium.org99ac1c52012-01-16 14:52:12 +00002940 keyvals = gclient_utils.ParseCodereviewSettingsContent(fileobj.read())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00002941
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00002942 def SetProperty(name, setting, unset_error_ok=False):
2943 fullname = 'rietveld.' + name
2944 if setting in keyvals:
2945 RunGit(['config', fullname, keyvals[setting]])
2946 else:
2947 RunGit(['config', '--unset-all', fullname], error_ok=unset_error_ok)
2948
tandrii48df5812016-10-17 03:55:37 -07002949 if not keyvals.get('GERRIT_HOST', False):
2950 SetProperty('server', 'CODE_REVIEW_SERVER')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00002951 # Only server setting is required. Other settings can be absent.
2952 # In that case, we ignore errors raised during option deletion attempt.
2953 SetProperty('cc', 'CC_LIST', unset_error_ok=True)
2954 SetProperty('tree-status-url', 'STATUS', unset_error_ok=True)
2955 SetProperty('viewvc-url', 'VIEW_VC', unset_error_ok=True)
rmistry@google.com90752582014-01-14 21:04:50 +00002956 SetProperty('bug-prefix', 'BUG_PREFIX', unset_error_ok=True)
thestig@chromium.org44202a22014-03-11 19:22:18 +00002957 SetProperty('cpplint-regex', 'LINT_REGEX', unset_error_ok=True)
2958 SetProperty('cpplint-ignore-regex', 'LINT_IGNORE_REGEX', unset_error_ok=True)
rmistry@google.com5626a922015-02-26 14:03:30 +00002959 SetProperty('run-post-upload-hook', 'RUN_POST_UPLOAD_HOOK',
2960 unset_error_ok=True)
Jamie Madilldc4d19e2019-10-24 21:50:02 +00002961 SetProperty(
2962 'format-full-by-default', 'FORMAT_FULL_BY_DEFAULT', unset_error_ok=True)
Dirk Pranke6f0df682021-06-25 00:42:33 +00002963 SetProperty('use-python3', 'USE_PYTHON3', unset_error_ok=True)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00002964
ukai@chromium.org7044efc2013-11-28 01:51:21 +00002965 if 'GERRIT_HOST' in keyvals:
ukai@chromium.orge8077812012-02-03 03:41:46 +00002966 RunGit(['config', 'gerrit.host', keyvals['GERRIT_HOST']])
ukai@chromium.orge8077812012-02-03 03:41:46 +00002967
bauerb@chromium.org54b400c2016-01-14 10:08:25 +00002968 if 'GERRIT_SQUASH_UPLOADS' in keyvals:
Edward Lesmes4de54132020-05-05 19:41:33 +00002969 RunGit(['config', 'gerrit.squash-uploads',
2970 keyvals['GERRIT_SQUASH_UPLOADS']])
bauerb@chromium.org54b400c2016-01-14 10:08:25 +00002971
tandrii@chromium.org28253532016-04-14 13:46:56 +00002972 if 'GERRIT_SKIP_ENSURE_AUTHENTICATED' in keyvals:
shinyak@chromium.org00dbccd2016-04-15 07:24:43 +00002973 RunGit(['config', 'gerrit.skip-ensure-authenticated',
tandrii@chromium.org28253532016-04-14 13:46:56 +00002974 keyvals['GERRIT_SKIP_ENSURE_AUTHENTICATED']])
2975
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00002976 if 'PUSH_URL_CONFIG' in keyvals and 'ORIGIN_URL_CONFIG' in keyvals:
Andrii Shyshkalov18975322017-01-25 16:44:13 +01002977 # should be of the form
2978 # PUSH_URL_CONFIG: url.ssh://gitrw.chromium.org.pushinsteadof
2979 # ORIGIN_URL_CONFIG: http://src.chromium.org/git
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00002980 RunGit(['config', keyvals['PUSH_URL_CONFIG'],
2981 keyvals['ORIGIN_URL_CONFIG']])
2982
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00002983
joshua.lock@intel.com426f69b2012-08-02 23:41:49 +00002984def urlretrieve(source, destination):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002985 """Downloads a network object to a local file, like urllib.urlretrieve.
2986
2987 This is necessary because urllib is broken for SSL connections via a proxy.
2988 """
joshua.lock@intel.com426f69b2012-08-02 23:41:49 +00002989 with open(destination, 'w') as f:
Edward Lemur79d4f992019-11-11 23:49:02 +00002990 f.write(urllib.request.urlopen(source).read())
joshua.lock@intel.com426f69b2012-08-02 23:41:49 +00002991
2992
ukai@chromium.org712d6102013-11-27 00:52:58 +00002993def hasSheBang(fname):
2994 """Checks fname is a #! script."""
2995 with open(fname) as f:
2996 return f.read(2).startswith('#!')
2997
2998
tandrii@chromium.org18630d62016-03-04 12:06:02 +00002999def DownloadGerritHook(force):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003000 """Downloads and installs a Gerrit commit-msg hook.
ukai@chromium.org78c4b982012-02-14 02:20:26 +00003001
3002 Args:
3003 force: True to update hooks. False to install hooks if not present.
3004 """
ukai@chromium.org712d6102013-11-27 00:52:58 +00003005 src = 'https://gerrit-review.googlesource.com/tools/hooks/commit-msg'
ukai@chromium.org78c4b982012-02-14 02:20:26 +00003006 dst = os.path.join(settings.GetRoot(), '.git', 'hooks', 'commit-msg')
3007 if not os.access(dst, os.X_OK):
3008 if os.path.exists(dst):
3009 if not force:
3010 return
ukai@chromium.org78c4b982012-02-14 02:20:26 +00003011 try:
joshua.lock@intel.com426f69b2012-08-02 23:41:49 +00003012 urlretrieve(src, dst)
ukai@chromium.org712d6102013-11-27 00:52:58 +00003013 if not hasSheBang(dst):
3014 DieWithError('Not a script: %s\n'
3015 'You need to download from\n%s\n'
3016 'into .git/hooks/commit-msg and '
3017 'chmod +x .git/hooks/commit-msg' % (dst, src))
ukai@chromium.org78c4b982012-02-14 02:20:26 +00003018 os.chmod(dst, stat.S_IRUSR | stat.S_IWUSR | stat.S_IXUSR)
3019 except Exception:
3020 if os.path.exists(dst):
3021 os.remove(dst)
ukai@chromium.org712d6102013-11-27 00:52:58 +00003022 DieWithError('\nFailed to download hooks.\n'
3023 'You need to download from\n%s\n'
3024 'into .git/hooks/commit-msg and '
3025 'chmod +x .git/hooks/commit-msg' % src)
ukai@chromium.org78c4b982012-02-14 02:20:26 +00003026
3027
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003028class _GitCookiesChecker(object):
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003029 """Provides facilities for validating and suggesting fixes to .gitcookies."""
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003030
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003031 _GOOGLESOURCE = 'googlesource.com'
3032
3033 def __init__(self):
3034 # Cached list of [host, identity, source], where source is either
3035 # .gitcookies or .netrc.
3036 self._all_hosts = None
3037
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003038 def ensure_configured_gitcookies(self):
3039 """Runs checks and suggests fixes to make git use .gitcookies from default
3040 path."""
3041 default = gerrit_util.CookiesAuthenticator.get_gitcookies_path()
3042 configured_path = RunGitSilent(
3043 ['config', '--global', 'http.cookiefile']).strip()
Andrii Shyshkalov1e250cd2017-05-10 15:39:31 +02003044 configured_path = os.path.expanduser(configured_path)
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003045 if configured_path:
3046 self._ensure_default_gitcookies_path(configured_path, default)
3047 else:
3048 self._configure_gitcookies_path(default)
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003049
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003050 @staticmethod
3051 def _ensure_default_gitcookies_path(configured_path, default_path):
3052 assert configured_path
3053 if configured_path == default_path:
3054 print('git is already configured to use your .gitcookies from %s' %
3055 configured_path)
3056 return
3057
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003058 print('WARNING: You have configured custom path to .gitcookies: %s\n'
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003059 'Gerrit and other depot_tools expect .gitcookies at %s\n' %
3060 (configured_path, default_path))
3061
3062 if not os.path.exists(configured_path):
3063 print('However, your configured .gitcookies file is missing.')
3064 confirm_or_exit('Reconfigure git to use default .gitcookies?',
3065 action='reconfigure')
3066 RunGit(['config', '--global', 'http.cookiefile', default_path])
3067 return
3068
3069 if os.path.exists(default_path):
3070 print('WARNING: default .gitcookies file already exists %s' %
3071 default_path)
3072 DieWithError('Please delete %s manually and re-run git cl creds-check' %
3073 default_path)
3074
3075 confirm_or_exit('Move existing .gitcookies to default location?',
3076 action='move')
3077 shutil.move(configured_path, default_path)
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003078 RunGit(['config', '--global', 'http.cookiefile', default_path])
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003079 print('Moved and reconfigured git to use .gitcookies from %s' %
3080 default_path)
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003081
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003082 @staticmethod
3083 def _configure_gitcookies_path(default_path):
3084 netrc_path = gerrit_util.CookiesAuthenticator.get_netrc_path()
3085 if os.path.exists(netrc_path):
3086 print('You seem to be using outdated .netrc for git credentials: %s' %
3087 netrc_path)
3088 print('This tool will guide you through setting up recommended '
3089 '.gitcookies store for git credentials.\n'
3090 '\n'
3091 'IMPORTANT: If something goes wrong and you decide to go back, do:\n'
3092 ' git config --global --unset http.cookiefile\n'
3093 ' mv %s %s.backup\n\n' % (default_path, default_path))
3094 confirm_or_exit(action='setup .gitcookies')
3095 RunGit(['config', '--global', 'http.cookiefile', default_path])
3096 print('Configured git to use .gitcookies from %s' % default_path)
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003097
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003098 def get_hosts_with_creds(self, include_netrc=False):
3099 if self._all_hosts is None:
3100 a = gerrit_util.CookiesAuthenticator()
3101 self._all_hosts = [
3102 (h, u, s)
3103 for h, u, s in itertools.chain(
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00003104 ((h, u, '.netrc') for h, (u, _, _) in a.netrc.hosts.items()),
3105 ((h, u, '.gitcookies') for h, (u, _) in a.gitcookies.items())
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003106 )
3107 if h.endswith(self._GOOGLESOURCE)
3108 ]
3109
3110 if include_netrc:
3111 return self._all_hosts
3112 return [(h, u, s) for h, u, s in self._all_hosts if s != '.netrc']
3113
3114 def print_current_creds(self, include_netrc=False):
3115 hosts = sorted(self.get_hosts_with_creds(include_netrc=include_netrc))
3116 if not hosts:
3117 print('No Git/Gerrit credentials found')
3118 return
Edward Lemur79d4f992019-11-11 23:49:02 +00003119 lengths = [max(map(len, (row[i] for row in hosts))) for i in range(3)]
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003120 header = [('Host', 'User', 'Which file'),
3121 ['=' * l for l in lengths]]
3122 for row in (header + hosts):
3123 print('\t'.join((('%%+%ds' % l) % s)
3124 for l, s in zip(lengths, row)))
3125
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003126 @staticmethod
3127 def _parse_identity(identity):
Lei Zhangd3f769a2017-12-15 15:16:14 -08003128 """Parses identity "git-<username>.domain" into <username> and domain."""
3129 # Special case: usernames that contain ".", which are generally not
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +02003130 # distinguishable from sub-domains. But we do know typical domains:
3131 if identity.endswith('.chromium.org'):
3132 domain = 'chromium.org'
3133 username = identity[:-len('.chromium.org')]
3134 else:
3135 username, domain = identity.split('.', 1)
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003136 if username.startswith('git-'):
3137 username = username[len('git-'):]
3138 return username, domain
3139
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003140 def _canonical_git_googlesource_host(self, host):
3141 """Normalizes Gerrit hosts (with '-review') to Git host."""
3142 assert host.endswith(self._GOOGLESOURCE)
3143 # Prefix doesn't include '.' at the end.
3144 prefix = host[:-(1 + len(self._GOOGLESOURCE))]
3145 if prefix.endswith('-review'):
3146 prefix = prefix[:-len('-review')]
3147 return prefix + '.' + self._GOOGLESOURCE
3148
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003149 def _canonical_gerrit_googlesource_host(self, host):
3150 git_host = self._canonical_git_googlesource_host(host)
3151 prefix = git_host.split('.', 1)[0]
3152 return prefix + '-review.' + self._GOOGLESOURCE
3153
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003154 def _get_counterpart_host(self, host):
3155 assert host.endswith(self._GOOGLESOURCE)
3156 git = self._canonical_git_googlesource_host(host)
3157 gerrit = self._canonical_gerrit_googlesource_host(git)
3158 return git if gerrit == host else gerrit
3159
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003160 def has_generic_host(self):
3161 """Returns whether generic .googlesource.com has been configured.
3162
3163 Chrome Infra recommends to use explicit ${host}.googlesource.com instead.
3164 """
3165 for host, _, _ in self.get_hosts_with_creds(include_netrc=False):
3166 if host == '.' + self._GOOGLESOURCE:
3167 return True
3168 return False
3169
3170 def _get_git_gerrit_identity_pairs(self):
3171 """Returns map from canonic host to pair of identities (Git, Gerrit).
3172
3173 One of identities might be None, meaning not configured.
3174 """
3175 host_to_identity_pairs = {}
3176 for host, identity, _ in self.get_hosts_with_creds():
3177 canonical = self._canonical_git_googlesource_host(host)
3178 pair = host_to_identity_pairs.setdefault(canonical, [None, None])
3179 idx = 0 if canonical == host else 1
3180 pair[idx] = identity
3181 return host_to_identity_pairs
3182
3183 def get_partially_configured_hosts(self):
3184 return set(
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003185 (host if i1 else self._canonical_gerrit_googlesource_host(host))
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00003186 for host, (i1, i2) in self._get_git_gerrit_identity_pairs().items()
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003187 if None in (i1, i2) and host != '.' + self._GOOGLESOURCE)
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003188
3189 def get_conflicting_hosts(self):
3190 return set(
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003191 host
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00003192 for host, (i1, i2) in self._get_git_gerrit_identity_pairs().items()
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003193 if None not in (i1, i2) and i1 != i2)
3194
3195 def get_duplicated_hosts(self):
3196 counters = collections.Counter(h for h, _, _ in self.get_hosts_with_creds())
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00003197 return set(host for host, count in counters.items() if count > 1)
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003198
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003199
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003200 @staticmethod
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003201 def _format_hosts(hosts, extra_column_func=None):
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003202 hosts = sorted(hosts)
3203 assert hosts
3204 if extra_column_func is None:
3205 extras = [''] * len(hosts)
3206 else:
3207 extras = [extra_column_func(host) for host in hosts]
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003208 tmpl = '%%-%ds %%-%ds' % (max(map(len, hosts)), max(map(len, extras)))
3209 lines = []
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003210 for he in zip(hosts, extras):
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003211 lines.append(tmpl % he)
3212 return lines
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003213
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003214 def _find_problems(self):
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003215 if self.has_generic_host():
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003216 yield ('.googlesource.com wildcard record detected',
3217 ['Chrome Infrastructure team recommends to list full host names '
3218 'explicitly.'],
3219 None)
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003220
3221 dups = self.get_duplicated_hosts()
3222 if dups:
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003223 yield ('The following hosts were defined twice',
3224 self._format_hosts(dups),
3225 None)
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003226
3227 partial = self.get_partially_configured_hosts()
3228 if partial:
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003229 yield ('Credentials should come in pairs for Git and Gerrit hosts. '
3230 'These hosts are missing',
3231 self._format_hosts(partial, lambda host: 'but %s defined' %
3232 self._get_counterpart_host(host)),
3233 partial)
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003234
3235 conflicting = self.get_conflicting_hosts()
3236 if conflicting:
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003237 yield ('The following Git hosts have differing credentials from their '
3238 'Gerrit counterparts',
3239 self._format_hosts(conflicting, lambda host: '%s vs %s' %
3240 tuple(self._get_git_gerrit_identity_pairs()[host])),
3241 conflicting)
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003242
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003243 def find_and_report_problems(self):
3244 """Returns True if there was at least one problem, else False."""
3245 found = False
3246 bad_hosts = set()
3247 for title, sublines, hosts in self._find_problems():
3248 if not found:
3249 found = True
3250 print('\n\n.gitcookies problem report:\n')
3251 bad_hosts.update(hosts or [])
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003252 print(' %s%s' % (title, (':' if sublines else '')))
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003253 if sublines:
3254 print()
3255 print(' %s' % '\n '.join(sublines))
3256 print()
3257
3258 if bad_hosts:
3259 assert found
3260 print(' You can manually remove corresponding lines in your %s file and '
3261 'visit the following URLs with correct account to generate '
3262 'correct credential lines:\n' %
3263 gerrit_util.CookiesAuthenticator.get_gitcookies_path())
3264 print(' %s' % '\n '.join(sorted(set(
3265 gerrit_util.CookiesAuthenticator().get_new_password_url(
3266 self._canonical_git_googlesource_host(host))
3267 for host in bad_hosts
3268 ))))
3269 return found
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003270
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003271
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003272@metrics.collector.collect_metrics('git cl creds-check')
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003273def CMDcreds_check(parser, args):
3274 """Checks credentials and suggests changes."""
3275 _, _ = parser.parse_args(args)
3276
Vadim Shtayurab250ec12018-10-04 00:21:08 +00003277 # Code below checks .gitcookies. Abort if using something else.
3278 authn = gerrit_util.Authenticator.get()
3279 if not isinstance(authn, gerrit_util.CookiesAuthenticator):
Edward Lemur57d47422020-03-06 20:43:07 +00003280 message = (
Vadim Shtayurab250ec12018-10-04 00:21:08 +00003281 'This command is not designed for bot environment. It checks '
3282 '~/.gitcookies file not generally used on bots.')
Edward Lemur57d47422020-03-06 20:43:07 +00003283 # TODO(crbug.com/1059384): Automatically detect when running on cloudtop.
3284 if isinstance(authn, gerrit_util.GceAuthenticator):
3285 message += (
3286 '\n'
3287 'If you need to run this on GCE or a cloudtop instance, '
3288 'export SKIP_GCE_AUTH_FOR_GIT=1 in your env.')
3289 DieWithError(message)
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003290
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003291 checker = _GitCookiesChecker()
3292 checker.ensure_configured_gitcookies()
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003293
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003294 print('Your .netrc and .gitcookies have credentials for these hosts:')
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003295 checker.print_current_creds(include_netrc=True)
3296
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003297 if not checker.find_and_report_problems():
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003298 print('\nNo problems detected in your .gitcookies file.')
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003299 return 0
3300 return 1
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003301
3302
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003303@metrics.collector.collect_metrics('git cl baseurl')
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00003304def CMDbaseurl(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00003305 """Gets or sets base-url for this branch."""
Edward Lesmes50da7702020-03-30 19:23:43 +00003306 branchref = scm.GIT.GetBranchRef(settings.GetRoot())
Edward Lemur85153282020-02-14 22:06:29 +00003307 branch = scm.GIT.ShortBranchName(branchref)
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00003308 _, args = parser.parse_args(args)
3309 if not args:
vapiera7fbd5a2016-06-16 09:17:49 -07003310 print('Current base-url:')
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00003311 return RunGit(['config', 'branch.%s.base-url' % branch],
3312 error_ok=False).strip()
3313 else:
vapiera7fbd5a2016-06-16 09:17:49 -07003314 print('Setting base-url to %s' % args[0])
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00003315 return RunGit(['config', 'branch.%s.base-url' % branch, args[0]],
3316 error_ok=False).strip()
3317
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003318
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00003319def color_for_status(status):
3320 """Maps a Changelist status to color, for CMDstatus and other tools."""
Bruce Dawsonb73f8a92020-03-27 22:03:08 +00003321 BOLD = '\033[1m'
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00003322 return {
Bruce Dawsonb73f8a92020-03-27 22:03:08 +00003323 'unsent': BOLD + Fore.YELLOW,
3324 'waiting': BOLD + Fore.RED,
3325 'reply': BOLD + Fore.YELLOW,
3326 'not lgtm': BOLD + Fore.RED,
3327 'lgtm': BOLD + Fore.GREEN,
3328 'commit': BOLD + Fore.MAGENTA,
3329 'closed': BOLD + Fore.CYAN,
3330 'error': BOLD + Fore.WHITE,
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00003331 }.get(status, Fore.WHITE)
3332
tandrii@chromium.org04ea8462016-04-25 19:51:21 +00003333
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003334def get_cl_statuses(changes, fine_grained, max_processes=None):
3335 """Returns a blocking iterable of (cl, status) for given branches.
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00003336
3337 If fine_grained is true, this will fetch CL statuses from the server.
3338 Otherwise, simply indicate if there's a matching url for the given branches.
3339
3340 If max_processes is specified, it is used as the maximum number of processes
3341 to spawn to fetch CL status from the server. Otherwise 1 process per branch is
3342 spawned.
calamity@chromium.orgcf197482016-04-29 20:15:53 +00003343
3344 See GetStatus() for a list of possible statuses.
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00003345 """
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01003346 if not changes:
Edward Lemur61bf4172020-02-24 23:22:37 +00003347 return
calamity@chromium.orgcf197482016-04-29 20:15:53 +00003348
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01003349 if not fine_grained:
3350 # Fast path which doesn't involve querying codereview servers.
Aaron Gablea1bab272017-04-11 16:38:18 -07003351 # Do not use get_approving_reviewers(), since it requires an HTTP request.
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003352 for cl in changes:
3353 yield (cl, 'waiting' if cl.GetIssueURL() else 'error')
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01003354 return
3355
3356 # First, sort out authentication issues.
3357 logging.debug('ensuring credentials exist')
3358 for cl in changes:
3359 cl.EnsureAuthenticated(force=False, refresh=True)
3360
3361 def fetch(cl):
3362 try:
3363 return (cl, cl.GetStatus())
3364 except:
3365 # See http://crbug.com/629863.
Andrii Shyshkalov98824232018-04-19 11:37:15 -07003366 logging.exception('failed to fetch status for cl %s:', cl.GetIssue())
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01003367 raise
3368
3369 threads_count = len(changes)
3370 if max_processes:
3371 threads_count = max(1, min(threads_count, max_processes))
3372 logging.debug('querying %d CLs using %d threads', len(changes), threads_count)
3373
Edward Lemur61bf4172020-02-24 23:22:37 +00003374 pool = multiprocessing.pool.ThreadPool(threads_count)
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01003375 fetched_cls = set()
3376 try:
3377 it = pool.imap_unordered(fetch, changes).__iter__()
3378 while True:
3379 try:
3380 cl, status = it.next(timeout=5)
Edward Lemur61bf4172020-02-24 23:22:37 +00003381 except (multiprocessing.TimeoutError, StopIteration):
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01003382 break
3383 fetched_cls.add(cl)
3384 yield cl, status
3385 finally:
3386 pool.close()
3387
3388 # Add any branches that failed to fetch.
3389 for cl in set(changes) - fetched_cls:
3390 yield (cl, 'error')
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00003391
rmistry@google.com2dd99862015-06-22 12:22:18 +00003392
Jose Lopes3863fc52020-04-07 17:00:25 +00003393def upload_branch_deps(cl, args, force=False):
rmistry@google.com2dd99862015-06-22 12:22:18 +00003394 """Uploads CLs of local branches that are dependents of the current branch.
3395
3396 If the local branch dependency tree looks like:
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003397
3398 test1 -> test2.1 -> test3.1
3399 -> test3.2
3400 -> test2.2 -> test3.3
rmistry@google.com2dd99862015-06-22 12:22:18 +00003401
3402 and you run "git cl upload --dependencies" from test1 then "git cl upload" is
3403 run on the dependent branches in this order:
3404 test2.1, test3.1, test3.2, test2.2, test3.3
3405
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003406 Note: This function does not rebase your local dependent branches. Use it
3407 when you make a change to the parent branch that will not conflict
3408 with its dependent branches, and you would like their dependencies
3409 updated in Rietveld.
rmistry@google.com2dd99862015-06-22 12:22:18 +00003410 """
3411 if git_common.is_dirty_git_tree('upload-branch-deps'):
3412 return 1
3413
3414 root_branch = cl.GetBranch()
3415 if root_branch is None:
3416 DieWithError('Can\'t find dependent branches from detached HEAD state. '
3417 'Get on a branch!')
Andrii Shyshkalov9f274432018-10-15 16:40:23 +00003418 if not cl.GetIssue():
rmistry@google.com2dd99862015-06-22 12:22:18 +00003419 DieWithError('Current branch does not have an uploaded CL. We cannot set '
3420 'patchset dependencies without an uploaded CL.')
3421
3422 branches = RunGit(['for-each-ref',
3423 '--format=%(refname:short) %(upstream:short)',
3424 'refs/heads'])
3425 if not branches:
3426 print('No local branches found.')
3427 return 0
3428
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003429 # Create a dictionary of all local branches to the branches that are
3430 # dependent on it.
rmistry@google.com2dd99862015-06-22 12:22:18 +00003431 tracked_to_dependents = collections.defaultdict(list)
3432 for b in branches.splitlines():
3433 tokens = b.split()
3434 if len(tokens) == 2:
3435 branch_name, tracked = tokens
3436 tracked_to_dependents[tracked].append(branch_name)
3437
vapiera7fbd5a2016-06-16 09:17:49 -07003438 print()
3439 print('The dependent local branches of %s are:' % root_branch)
rmistry@google.com2dd99862015-06-22 12:22:18 +00003440 dependents = []
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003441
rmistry@google.com2dd99862015-06-22 12:22:18 +00003442 def traverse_dependents_preorder(branch, padding=''):
3443 dependents_to_process = tracked_to_dependents.get(branch, [])
3444 padding += ' '
3445 for dependent in dependents_to_process:
vapiera7fbd5a2016-06-16 09:17:49 -07003446 print('%s%s' % (padding, dependent))
rmistry@google.com2dd99862015-06-22 12:22:18 +00003447 dependents.append(dependent)
3448 traverse_dependents_preorder(dependent, padding)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003449
rmistry@google.com2dd99862015-06-22 12:22:18 +00003450 traverse_dependents_preorder(root_branch)
vapiera7fbd5a2016-06-16 09:17:49 -07003451 print()
rmistry@google.com2dd99862015-06-22 12:22:18 +00003452
3453 if not dependents:
vapiera7fbd5a2016-06-16 09:17:49 -07003454 print('There are no dependent local branches for %s' % root_branch)
rmistry@google.com2dd99862015-06-22 12:22:18 +00003455 return 0
3456
Jose Lopes3863fc52020-04-07 17:00:25 +00003457 if not force:
3458 confirm_or_exit('This command will checkout all dependent branches and run '
3459 '"git cl upload".', action='continue')
rmistry@google.com2dd99862015-06-22 12:22:18 +00003460
rmistry@google.com2dd99862015-06-22 12:22:18 +00003461 # Record all dependents that failed to upload.
3462 failures = {}
3463 # Go through all dependents, checkout the branch and upload.
3464 try:
3465 for dependent_branch in dependents:
vapiera7fbd5a2016-06-16 09:17:49 -07003466 print()
3467 print('--------------------------------------')
3468 print('Running "git cl upload" from %s:' % dependent_branch)
rmistry@google.com2dd99862015-06-22 12:22:18 +00003469 RunGit(['checkout', '-q', dependent_branch])
vapiera7fbd5a2016-06-16 09:17:49 -07003470 print()
rmistry@google.com2dd99862015-06-22 12:22:18 +00003471 try:
3472 if CMDupload(OptionParser(), args) != 0:
vapiera7fbd5a2016-06-16 09:17:49 -07003473 print('Upload failed for %s!' % dependent_branch)
rmistry@google.com2dd99862015-06-22 12:22:18 +00003474 failures[dependent_branch] = 1
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -08003475 except: # pylint: disable=bare-except
rmistry@google.com2dd99862015-06-22 12:22:18 +00003476 failures[dependent_branch] = 1
vapiera7fbd5a2016-06-16 09:17:49 -07003477 print()
rmistry@google.com2dd99862015-06-22 12:22:18 +00003478 finally:
3479 # Swap back to the original root branch.
3480 RunGit(['checkout', '-q', root_branch])
3481
vapiera7fbd5a2016-06-16 09:17:49 -07003482 print()
3483 print('Upload complete for dependent branches!')
rmistry@google.com2dd99862015-06-22 12:22:18 +00003484 for dependent_branch in dependents:
3485 upload_status = 'failed' if failures.get(dependent_branch) else 'succeeded'
vapiera7fbd5a2016-06-16 09:17:49 -07003486 print(' %s : %s' % (dependent_branch, upload_status))
3487 print()
rmistry@google.com2dd99862015-06-22 12:22:18 +00003488
3489 return 0
3490
3491
Tibor Goldschwendt7c5efb22020-03-25 01:23:54 +00003492def GetArchiveTagForBranch(issue_num, branch_name, existing_tags, pattern):
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00003493 """Given a proposed tag name, returns a tag name that is guaranteed to be
3494 unique. If 'foo' is proposed but already exists, then 'foo-2' is used,
3495 or 'foo-3', and so on."""
3496
Tibor Goldschwendt7c5efb22020-03-25 01:23:54 +00003497 proposed_tag = pattern.format(**{'issue': issue_num, 'branch': branch_name})
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00003498 for suffix_num in itertools.count(1):
3499 if suffix_num == 1:
3500 to_check = proposed_tag
3501 else:
3502 to_check = '%s-%d' % (proposed_tag, suffix_num)
3503
3504 if to_check not in existing_tags:
3505 return to_check
3506
3507
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003508@metrics.collector.collect_metrics('git cl archive')
kmarshall3bff56b2016-06-06 18:31:47 -07003509def CMDarchive(parser, args):
3510 """Archives and deletes branches associated with closed changelists."""
3511 parser.add_option(
3512 '-j', '--maxjobs', action='store', type=int,
kmarshall9249e012016-08-23 12:02:16 -07003513 help='The maximum number of jobs to use when retrieving review status.')
kmarshall3bff56b2016-06-06 18:31:47 -07003514 parser.add_option(
3515 '-f', '--force', action='store_true',
3516 help='Bypasses the confirmation prompt.')
kmarshall9249e012016-08-23 12:02:16 -07003517 parser.add_option(
3518 '-d', '--dry-run', action='store_true',
3519 help='Skip the branch tagging and removal steps.')
3520 parser.add_option(
3521 '-t', '--notags', action='store_true',
3522 help='Do not tag archived branches. '
3523 'Note: local commit history may be lost.')
Tibor Goldschwendt7c5efb22020-03-25 01:23:54 +00003524 parser.add_option(
3525 '-p',
3526 '--pattern',
3527 default='git-cl-archived-{issue}-{branch}',
3528 help='Format string for archive tags. '
3529 'E.g. \'archived-{issue}-{branch}\'.')
kmarshall3bff56b2016-06-06 18:31:47 -07003530
kmarshall3bff56b2016-06-06 18:31:47 -07003531 options, args = parser.parse_args(args)
3532 if args:
3533 parser.error('Unsupported args: %s' % ' '.join(args))
kmarshall3bff56b2016-06-06 18:31:47 -07003534
3535 branches = RunGit(['for-each-ref', '--format=%(refname)', 'refs/heads'])
3536 if not branches:
3537 return 0
3538
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00003539 tags = RunGit(['for-each-ref', '--format=%(refname)',
3540 'refs/tags']).splitlines() or []
3541 tags = [t.split('/')[-1] for t in tags]
3542
vapiera7fbd5a2016-06-16 09:17:49 -07003543 print('Finding all branches associated with closed issues...')
Edward Lemur934836a2019-09-09 20:16:54 +00003544 changes = [Changelist(branchref=b)
3545 for b in branches.splitlines()]
kmarshall3bff56b2016-06-06 18:31:47 -07003546 alignment = max(5, max(len(c.GetBranch()) for c in changes))
3547 statuses = get_cl_statuses(changes,
3548 fine_grained=True,
3549 max_processes=options.maxjobs)
3550 proposal = [(cl.GetBranch(),
Tibor Goldschwendt7c5efb22020-03-25 01:23:54 +00003551 GetArchiveTagForBranch(cl.GetIssue(), cl.GetBranch(), tags,
3552 options.pattern))
kmarshall3bff56b2016-06-06 18:31:47 -07003553 for cl, status in statuses
Andrii Shyshkalov51bdf8c2018-10-18 01:07:58 +00003554 if status in ('closed', 'rietveld-not-supported')]
kmarshall3bff56b2016-06-06 18:31:47 -07003555 proposal.sort()
3556
3557 if not proposal:
vapiera7fbd5a2016-06-16 09:17:49 -07003558 print('No branches with closed codereview issues found.')
kmarshall3bff56b2016-06-06 18:31:47 -07003559 return 0
3560
Edward Lemur85153282020-02-14 22:06:29 +00003561 current_branch = scm.GIT.GetBranch(settings.GetRoot())
kmarshall3bff56b2016-06-06 18:31:47 -07003562
vapiera7fbd5a2016-06-16 09:17:49 -07003563 print('\nBranches with closed issues that will be archived:\n')
kmarshall9249e012016-08-23 12:02:16 -07003564 if options.notags:
3565 for next_item in proposal:
3566 print(' ' + next_item[0])
3567 else:
3568 print('%*s | %s' % (alignment, 'Branch name', 'Archival tag name'))
3569 for next_item in proposal:
3570 print('%*s %s' % (alignment, next_item[0], next_item[1]))
kmarshall3bff56b2016-06-06 18:31:47 -07003571
kmarshall9249e012016-08-23 12:02:16 -07003572 # Quit now on precondition failure or if instructed by the user, either
3573 # via an interactive prompt or by command line flags.
3574 if options.dry_run:
3575 print('\nNo changes were made (dry run).\n')
3576 return 0
3577 elif any(branch == current_branch for branch, _ in proposal):
kmarshall3bff56b2016-06-06 18:31:47 -07003578 print('You are currently on a branch \'%s\' which is associated with a '
3579 'closed codereview issue, so archive cannot proceed. Please '
3580 'checkout another branch and run this command again.' %
3581 current_branch)
3582 return 1
kmarshall9249e012016-08-23 12:02:16 -07003583 elif not options.force:
Edward Lesmesae3586b2020-03-23 21:21:14 +00003584 answer = gclient_utils.AskForData('\nProceed with deletion (Y/n)? ').lower()
sergiyb4a5ecbe2016-06-20 09:46:00 -07003585 if answer not in ('y', ''):
vapiera7fbd5a2016-06-16 09:17:49 -07003586 print('Aborted.')
kmarshall3bff56b2016-06-06 18:31:47 -07003587 return 1
3588
3589 for branch, tagname in proposal:
kmarshall9249e012016-08-23 12:02:16 -07003590 if not options.notags:
3591 RunGit(['tag', tagname, branch])
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00003592
3593 if RunGitWithCode(['branch', '-D', branch])[0] != 0:
3594 # Clean up the tag if we failed to delete the branch.
3595 RunGit(['tag', '-d', tagname])
kmarshall9249e012016-08-23 12:02:16 -07003596
vapiera7fbd5a2016-06-16 09:17:49 -07003597 print('\nJob\'s done!')
kmarshall3bff56b2016-06-06 18:31:47 -07003598
3599 return 0
3600
3601
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003602@metrics.collector.collect_metrics('git cl status')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003603def CMDstatus(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00003604 """Show status of changelists.
3605
3606 Colors are used to tell the state of the CL unless --fast is used:
jsbell@chromium.orgaeab41a2013-12-10 20:01:22 +00003607 - Blue waiting for review
Aaron Gable9ab38c62017-04-06 14:36:33 -07003608 - Yellow waiting for you to reply to review, or not yet sent
jsbell@chromium.orgaeab41a2013-12-10 20:01:22 +00003609 - Green LGTM'ed
Aaron Gable9ab38c62017-04-06 14:36:33 -07003610 - Red 'not LGTM'ed
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +00003611 - Magenta in the CQ
jsbell@chromium.orgaeab41a2013-12-10 20:01:22 +00003612 - Cyan was committed, branch can be deleted
Aaron Gable9ab38c62017-04-06 14:36:33 -07003613 - White error, or unknown status
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00003614
3615 Also see 'git cl comments'.
3616 """
Alan Cuttera3be9a52019-03-04 18:50:33 +00003617 parser.add_option(
3618 '--no-branch-color',
3619 action='store_true',
3620 help='Disable colorized branch names')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003621 parser.add_option('--field',
phajdan.jr289d03e2016-08-16 08:21:06 -07003622 help='print only specific field (desc|id|patch|status|url)')
maruel@chromium.org1033efd2013-07-23 23:25:09 +00003623 parser.add_option('-f', '--fast', action='store_true',
3624 help='Do not retrieve review status')
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00003625 parser.add_option(
3626 '-j', '--maxjobs', action='store', type=int,
3627 help='The maximum number of jobs to use when retrieving review status')
Edward Lemur52969c92020-02-06 18:15:28 +00003628 parser.add_option(
3629 '-i', '--issue', type=int,
3630 help='Operate on this issue instead of the current branch\'s implicit '
3631 'issue. Requires --field to be set.')
Sigurd Schneider9abde8c2020-11-17 08:44:52 +00003632 parser.add_option('-d',
3633 '--date-order',
3634 action='store_true',
3635 help='Order branches by committer date.')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00003636 options, args = parser.parse_args(args)
maruel@chromium.org39c0b222013-08-17 16:57:01 +00003637 if args:
3638 parser.error('Unsupported args: %s' % args)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003639
iannuccie53c9352016-08-17 14:40:40 -07003640 if options.issue is not None and not options.field:
Edward Lemur6c6827c2020-02-06 21:15:18 +00003641 parser.error('--field must be given when --issue is set.')
iannucci3c972b92016-08-17 13:24:10 -07003642
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003643 if options.field:
Edward Lemur934836a2019-09-09 20:16:54 +00003644 cl = Changelist(issue=options.issue)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003645 if options.field.startswith('desc'):
Edward Lemur6c6827c2020-02-06 21:15:18 +00003646 if cl.GetIssue():
3647 print(cl.FetchDescription())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003648 elif options.field == 'id':
3649 issueid = cl.GetIssue()
3650 if issueid:
vapiera7fbd5a2016-06-16 09:17:49 -07003651 print(issueid)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003652 elif options.field == 'patch':
Aaron Gablee8856ee2017-12-07 12:41:46 -08003653 patchset = cl.GetMostRecentPatchset()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003654 if patchset:
vapiera7fbd5a2016-06-16 09:17:49 -07003655 print(patchset)
phajdan.jr289d03e2016-08-16 08:21:06 -07003656 elif options.field == 'status':
3657 print(cl.GetStatus())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003658 elif options.field == 'url':
3659 url = cl.GetIssueURL()
3660 if url:
vapiera7fbd5a2016-06-16 09:17:49 -07003661 print(url)
maruel@chromium.orge25c75b2013-07-23 18:30:56 +00003662 return 0
3663
Sigurd Schneider9abde8c2020-11-17 08:44:52 +00003664 branches = RunGit([
3665 'for-each-ref', '--format=%(refname) %(committerdate:unix)', 'refs/heads'
3666 ])
maruel@chromium.orge25c75b2013-07-23 18:30:56 +00003667 if not branches:
3668 print('No local branch found.')
3669 return 0
3670
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003671 changes = [
Sigurd Schneider9abde8c2020-11-17 08:44:52 +00003672 Changelist(branchref=b, commit_date=ct)
3673 for b, ct in map(lambda line: line.split(' '), branches.splitlines())
3674 ]
vapiera7fbd5a2016-06-16 09:17:49 -07003675 print('Branches associated with reviews:')
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003676 output = get_cl_statuses(changes,
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00003677 fine_grained=not options.fast,
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003678 max_processes=options.maxjobs)
maruel@chromium.org1033efd2013-07-23 23:25:09 +00003679
Edward Lemur85153282020-02-14 22:06:29 +00003680 current_branch = scm.GIT.GetBranch(settings.GetRoot())
Daniel McArdlea23bf592019-02-12 00:25:12 +00003681
3682 def FormatBranchName(branch, colorize=False):
3683 """Simulates 'git branch' behavior. Colorizes and prefixes branch name with
3684 an asterisk when it is the current branch."""
3685
3686 asterisk = ""
3687 color = Fore.RESET
3688 if branch == current_branch:
3689 asterisk = "* "
3690 color = Fore.GREEN
Edward Lemur85153282020-02-14 22:06:29 +00003691 branch_name = scm.GIT.ShortBranchName(branch)
Daniel McArdlea23bf592019-02-12 00:25:12 +00003692
3693 if colorize:
3694 return asterisk + color + branch_name + Fore.RESET
Daniel McArdle452a49f2019-02-14 17:28:31 +00003695 return asterisk + branch_name
3696
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00003697 branch_statuses = {}
Daniel McArdlea23bf592019-02-12 00:25:12 +00003698
3699 alignment = max(5, max(len(FormatBranchName(c.GetBranch())) for c in changes))
Sigurd Schneider9abde8c2020-11-17 08:44:52 +00003700 if options.date_order:
3701 sorted_changes = sorted(changes,
3702 key=lambda c: c.GetCommitDate(),
3703 reverse=True)
3704 else:
3705 sorted_changes = sorted(changes, key=lambda c: c.GetBranch())
3706 for cl in sorted_changes:
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003707 branch = cl.GetBranch()
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00003708 while branch not in branch_statuses:
Edward Lemur79d4f992019-11-11 23:49:02 +00003709 c, status = next(output)
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003710 branch_statuses[c.GetBranch()] = status
3711 status = branch_statuses.pop(branch)
Andrii Shyshkalov1ee78cd2020-03-12 01:31:53 +00003712 url = cl.GetIssueURL(short=True)
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003713 if url and (not status or status == 'error'):
3714 # The issue probably doesn't exist anymore.
3715 url += ' (broken)'
3716
nodir@chromium.orga6de1f42015-06-10 04:23:17 +00003717 color = color_for_status(status)
Bruce Dawsonb73f8a92020-03-27 22:03:08 +00003718 # Turn off bold as well as colors.
3719 END = '\033[0m'
3720 reset = Fore.RESET + END
iannucci@chromium.org596cd5c2016-04-04 21:34:39 +00003721 if not setup_color.IS_TTY:
maruel@chromium.org885f6512013-07-27 02:17:26 +00003722 color = ''
3723 reset = ''
nodir@chromium.orga6de1f42015-06-10 04:23:17 +00003724 status_str = '(%s)' % status if status else ''
Daniel McArdle452a49f2019-02-14 17:28:31 +00003725
Alan Cuttera3be9a52019-03-04 18:50:33 +00003726 branch_display = FormatBranchName(branch)
3727 padding = ' ' * (alignment - len(branch_display))
3728 if not options.no_branch_color:
3729 branch_display = FormatBranchName(branch, colorize=True)
Daniel McArdle452a49f2019-02-14 17:28:31 +00003730
Alan Cuttera3be9a52019-03-04 18:50:33 +00003731 print(' %s : %s%s %s%s' % (padding + branch_display, color, url,
3732 status_str, reset))
Andrii Shyshkalovd0e1d9d2017-01-24 17:10:51 +01003733
vapiera7fbd5a2016-06-16 09:17:49 -07003734 print()
Daniel McArdlea23bf592019-02-12 00:25:12 +00003735 print('Current branch: %s' % current_branch)
Andrii Shyshkalovd0e1d9d2017-01-24 17:10:51 +01003736 for cl in changes:
Daniel McArdlea23bf592019-02-12 00:25:12 +00003737 if cl.GetBranch() == current_branch:
Andrii Shyshkalovd0e1d9d2017-01-24 17:10:51 +01003738 break
dpranke@chromium.orgee87f582015-07-31 18:46:25 +00003739 if not cl.GetIssue():
vapiera7fbd5a2016-06-16 09:17:49 -07003740 print('No issue assigned.')
dpranke@chromium.orgee87f582015-07-31 18:46:25 +00003741 return 0
vapiera7fbd5a2016-06-16 09:17:49 -07003742 print('Issue number: %s (%s)' % (cl.GetIssue(), cl.GetIssueURL()))
maruel@chromium.org85616e02014-07-28 15:37:55 +00003743 if not options.fast:
vapiera7fbd5a2016-06-16 09:17:49 -07003744 print('Issue description:')
Edward Lemur6c6827c2020-02-06 21:15:18 +00003745 print(cl.FetchDescription(pretty=True))
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003746 return 0
3747
3748
maruel@chromium.org39c0b222013-08-17 16:57:01 +00003749def colorize_CMDstatus_doc():
3750 """To be called once in main() to add colors to git cl status help."""
3751 colors = [i for i in dir(Fore) if i[0].isupper()]
3752
3753 def colorize_line(line):
3754 for color in colors:
3755 if color in line.upper():
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003756 # Extract whitespace first and the leading '-'.
maruel@chromium.org39c0b222013-08-17 16:57:01 +00003757 indent = len(line) - len(line.lstrip(' ')) + 1
3758 return line[:indent] + getattr(Fore, color) + line[indent:] + Fore.RESET
3759 return line
3760
3761 lines = CMDstatus.__doc__.splitlines()
3762 CMDstatus.__doc__ = '\n'.join(colorize_line(l) for l in lines)
3763
3764
phajdan.jre328cf92016-08-22 04:12:17 -07003765def write_json(path, contents):
Stefan Zager1306bd02017-06-22 19:26:46 -07003766 if path == '-':
3767 json.dump(contents, sys.stdout)
3768 else:
3769 with open(path, 'w') as f:
3770 json.dump(contents, f)
phajdan.jre328cf92016-08-22 04:12:17 -07003771
3772
maruel@chromium.org0633fb42013-08-16 20:06:14 +00003773@subcommand.usage('[issue_number]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003774@metrics.collector.collect_metrics('git cl issue')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003775def CMDissue(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00003776 """Sets or displays the current code review issue number.
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003777
3778 Pass issue number 0 to clear the current issue.
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00003779 """
dnj@chromium.org406c4402015-03-03 17:22:28 +00003780 parser.add_option('-r', '--reverse', action='store_true',
3781 help='Lookup the branch(es) for the specified issues. If '
3782 'no issues are specified, all branches with mapped '
3783 'issues will be listed.')
Stefan Zager1306bd02017-06-22 19:26:46 -07003784 parser.add_option('--json',
3785 help='Path to JSON output file, or "-" for stdout.')
dnj@chromium.org406c4402015-03-03 17:22:28 +00003786 options, args = parser.parse_args(args)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003787
dnj@chromium.org406c4402015-03-03 17:22:28 +00003788 if options.reverse:
3789 branches = RunGit(['for-each-ref', 'refs/heads',
Aaron Gablead64abd2017-12-04 09:49:13 -08003790 '--format=%(refname)']).splitlines()
dnj@chromium.org406c4402015-03-03 17:22:28 +00003791 # Reverse issue lookup.
3792 issue_branch_map = {}
Daniel Bratellb56a43a2018-09-06 15:49:03 +00003793
3794 git_config = {}
3795 for config in RunGit(['config', '--get-regexp',
3796 r'branch\..*issue']).splitlines():
3797 name, _space, val = config.partition(' ')
3798 git_config[name] = val
3799
dnj@chromium.org406c4402015-03-03 17:22:28 +00003800 for branch in branches:
Edward Lesmes50da7702020-03-30 19:23:43 +00003801 issue = git_config.get(
3802 'branch.%s.%s' % (scm.GIT.ShortBranchName(branch), ISSUE_CONFIG_KEY))
Edward Lemur52969c92020-02-06 18:15:28 +00003803 if issue:
3804 issue_branch_map.setdefault(int(issue), []).append(branch)
dnj@chromium.org406c4402015-03-03 17:22:28 +00003805 if not args:
Carlos Caballero81923d62020-07-06 18:22:27 +00003806 args = sorted(issue_branch_map.keys())
phajdan.jre328cf92016-08-22 04:12:17 -07003807 result = {}
dnj@chromium.org406c4402015-03-03 17:22:28 +00003808 for issue in args:
Lei Zhang5a368d42019-03-25 23:18:19 +00003809 try:
3810 issue_num = int(issue)
3811 except ValueError:
3812 print('ERROR cannot parse issue number: %s' % issue, file=sys.stderr)
dnj@chromium.org406c4402015-03-03 17:22:28 +00003813 continue
Lei Zhang5a368d42019-03-25 23:18:19 +00003814 result[issue_num] = issue_branch_map.get(issue_num)
vapiera7fbd5a2016-06-16 09:17:49 -07003815 print('Branch for issue number %s: %s' % (
Lei Zhang5a368d42019-03-25 23:18:19 +00003816 issue, ', '.join(issue_branch_map.get(issue_num) or ('None',))))
phajdan.jre328cf92016-08-22 04:12:17 -07003817 if options.json:
3818 write_json(options.json, result)
Aaron Gable78753da2017-06-15 10:35:49 -07003819 return 0
3820
3821 if len(args) > 0:
Edward Lemurf38bc172019-09-03 21:02:13 +00003822 issue = ParseIssueNumberArgument(args[0])
Aaron Gable78753da2017-06-15 10:35:49 -07003823 if not issue.valid:
3824 DieWithError('Pass a url or number to set the issue, 0 to unset it, '
3825 'or no argument to list it.\n'
3826 'Maybe you want to run git cl status?')
Edward Lemurf38bc172019-09-03 21:02:13 +00003827 cl = Changelist()
Aaron Gable78753da2017-06-15 10:35:49 -07003828 cl.SetIssue(issue.issue)
dnj@chromium.org406c4402015-03-03 17:22:28 +00003829 else:
Edward Lemurf38bc172019-09-03 21:02:13 +00003830 cl = Changelist()
Aaron Gable78753da2017-06-15 10:35:49 -07003831 print('Issue number: %s (%s)' % (cl.GetIssue(), cl.GetIssueURL()))
3832 if options.json:
3833 write_json(options.json, {
Nodir Turakulov27379632021-03-17 18:53:29 +00003834 'gerrit_host': cl.GetGerritHost(),
3835 'gerrit_project': cl.GetGerritProject(),
Aaron Gable78753da2017-06-15 10:35:49 -07003836 'issue_url': cl.GetIssueURL(),
Nodir Turakulov27379632021-03-17 18:53:29 +00003837 'issue': cl.GetIssue(),
Aaron Gable78753da2017-06-15 10:35:49 -07003838 })
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003839 return 0
3840
3841
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003842@metrics.collector.collect_metrics('git cl comments')
maruel@chromium.org9977a2e2012-06-06 22:30:56 +00003843def CMDcomments(parser, args):
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003844 """Shows or posts review comments for any changelist."""
3845 parser.add_option('-a', '--add-comment', dest='comment',
3846 help='comment to add to an issue')
Sergiy Byelozyorovcb629a42018-10-28 19:20:39 +00003847 parser.add_option('-p', '--publish', action='store_true',
3848 help='marks CL as ready and sends comment to reviewers')
Andrii Shyshkalov0d6b46e2017-03-17 22:23:22 +01003849 parser.add_option('-i', '--issue', dest='issue',
Edward Lemurf38bc172019-09-03 21:02:13 +00003850 help='review issue id (defaults to current issue).')
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07003851 parser.add_option('-m', '--machine-readable', dest='readable',
3852 action='store_false', default=True,
3853 help='output comments in a format compatible with '
3854 'editor parsing')
smut@google.comc85ac942015-09-15 16:34:43 +00003855 parser.add_option('-j', '--json-file',
Stefan Zager1306bd02017-06-22 19:26:46 -07003856 help='File to write JSON summary to, or "-" for stdout')
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003857 options, args = parser.parse_args(args)
maruel@chromium.org9977a2e2012-06-06 22:30:56 +00003858
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003859 issue = None
3860 if options.issue:
3861 try:
3862 issue = int(options.issue)
3863 except ValueError:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00003864 DieWithError('A review issue ID is expected to be a number.')
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003865
Edward Lemur934836a2019-09-09 20:16:54 +00003866 cl = Changelist(issue=issue)
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003867
3868 if options.comment:
Sergiy Byelozyorovcb629a42018-10-28 19:20:39 +00003869 cl.AddComment(options.comment, options.publish)
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003870 return 0
3871
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07003872 summary = sorted(cl.GetCommentsSummary(readable=options.readable),
3873 key=lambda c: c.date)
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01003874 for comment in summary:
3875 if comment.disapproval:
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003876 color = Fore.RED
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01003877 elif comment.approval:
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003878 color = Fore.GREEN
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01003879 elif comment.sender == cl.GetIssueOwner():
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003880 color = Fore.MAGENTA
Quinten Yearsley0e617c02019-02-20 00:37:03 +00003881 elif comment.autogenerated:
3882 color = Fore.CYAN
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003883 else:
3884 color = Fore.BLUE
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01003885 print('\n%s%s %s%s\n%s' % (
3886 color,
3887 comment.date.strftime('%Y-%m-%d %H:%M:%S UTC'),
3888 comment.sender,
3889 Fore.RESET,
3890 '\n'.join(' ' + l for l in comment.message.strip().splitlines())))
3891
smut@google.comc85ac942015-09-15 16:34:43 +00003892 if options.json_file:
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01003893 def pre_serialize(c):
Edward Lemur79d4f992019-11-11 23:49:02 +00003894 dct = c._asdict().copy()
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01003895 dct['date'] = dct['date'].strftime('%Y-%m-%d %H:%M:%S.%f')
3896 return dct
Edward Lemur79d4f992019-11-11 23:49:02 +00003897 write_json(options.json_file, [pre_serialize(x) for x in summary])
maruel@chromium.org9977a2e2012-06-06 22:30:56 +00003898 return 0
3899
3900
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00003901@subcommand.usage('[codereview url or issue id]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003902@metrics.collector.collect_metrics('git cl description')
rsesek@chromium.orgeec76592013-05-20 16:27:57 +00003903def CMDdescription(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00003904 """Brings up the editor for the current CL's description."""
smut@google.com34fb6b12015-07-13 20:03:26 +00003905 parser.add_option('-d', '--display', action='store_true',
3906 help='Display the description instead of opening an editor')
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00003907 parser.add_option('-n', '--new-description',
dnjba1b0f32016-09-02 12:37:42 -07003908 help='New description to set for this issue (- for stdin, '
3909 '+ to load from local commit HEAD)')
dsansomee2d6fd92016-09-08 00:10:47 -07003910 parser.add_option('-f', '--force', action='store_true',
3911 help='Delete any unpublished Gerrit edits for this issue '
3912 'without prompting')
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00003913
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00003914 options, args = parser.parse_args(args)
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00003915
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01003916 target_issue_arg = None
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00003917 if len(args) > 0:
Edward Lemurf38bc172019-09-03 21:02:13 +00003918 target_issue_arg = ParseIssueNumberArgument(args[0])
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01003919 if not target_issue_arg.valid:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00003920 parser.error('Invalid issue ID or URL.')
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00003921
Edward Lemur934836a2019-09-09 20:16:54 +00003922 kwargs = {}
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01003923 if target_issue_arg:
3924 kwargs['issue'] = target_issue_arg.issue
3925 kwargs['codereview_host'] = target_issue_arg.hostname
martiniss6eda05f2016-06-30 10:18:35 -07003926
3927 cl = Changelist(**kwargs)
rsesek@chromium.orgeec76592013-05-20 16:27:57 +00003928 if not cl.GetIssue():
3929 DieWithError('This branch has no associated changelist.')
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02003930
Edward Lemur678a6842019-10-03 22:25:05 +00003931 if args and not args[0].isdigit():
Edward Lemurf38bc172019-09-03 21:02:13 +00003932 logging.info('canonical issue/change URL: %s\n', cl.GetIssueURL())
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02003933
Edward Lemur6c6827c2020-02-06 21:15:18 +00003934 description = ChangeDescription(cl.FetchDescription())
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00003935
smut@google.com34fb6b12015-07-13 20:03:26 +00003936 if options.display:
vapiera7fbd5a2016-06-16 09:17:49 -07003937 print(description.description)
smut@google.com34fb6b12015-07-13 20:03:26 +00003938 return 0
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00003939
3940 if options.new_description:
3941 text = options.new_description
3942 if text == '-':
3943 text = '\n'.join(l.rstrip() for l in sys.stdin)
dnjba1b0f32016-09-02 12:37:42 -07003944 elif text == '+':
3945 base_branch = cl.GetCommonAncestorWithUpstream()
Edward Lemura12175c2020-03-09 16:58:26 +00003946 text = _create_description_from_log([base_branch])
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00003947
3948 description.set_description(text)
3949 else:
Edward Lemurf38bc172019-09-03 21:02:13 +00003950 description.prompt()
Edward Lemur6c6827c2020-02-06 21:15:18 +00003951 if cl.FetchDescription().strip() != description.description:
dsansomee2d6fd92016-09-08 00:10:47 -07003952 cl.UpdateDescription(description.description, force=options.force)
rsesek@chromium.orgeec76592013-05-20 16:27:57 +00003953 return 0
3954
3955
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003956@metrics.collector.collect_metrics('git cl lint')
thestig@chromium.org44202a22014-03-11 19:22:18 +00003957def CMDlint(parser, args):
3958 """Runs cpplint on the current changelist."""
tzik@chromium.orgf204d4b2014-03-13 07:40:55 +00003959 parser.add_option('--filter', action='append', metavar='-x,+y',
3960 help='Comma-separated list of cpplint\'s category-filters')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00003961 options, args = parser.parse_args(args)
thestig@chromium.org44202a22014-03-11 19:22:18 +00003962
3963 # Access to a protected member _XX of a client class
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -08003964 # pylint: disable=protected-access
thestig@chromium.org44202a22014-03-11 19:22:18 +00003965 try:
3966 import cpplint
3967 import cpplint_chromium
3968 except ImportError:
vapiera7fbd5a2016-06-16 09:17:49 -07003969 print('Your depot_tools is missing cpplint.py and/or cpplint_chromium.py.')
thestig@chromium.org44202a22014-03-11 19:22:18 +00003970 return 1
3971
3972 # Change the current working directory before calling lint so that it
3973 # shows the correct base.
3974 previous_cwd = os.getcwd()
3975 os.chdir(settings.GetRoot())
3976 try:
Edward Lemur934836a2019-09-09 20:16:54 +00003977 cl = Changelist()
Edward Lemur2c62b332020-03-12 22:12:33 +00003978 files = cl.GetAffectedFiles(cl.GetCommonAncestorWithUpstream())
thestig@chromium.org5839eb52014-05-30 16:20:51 +00003979 if not files:
vapiera7fbd5a2016-06-16 09:17:49 -07003980 print('Cannot lint an empty CL')
thestig@chromium.org5839eb52014-05-30 16:20:51 +00003981 return 1
thestig@chromium.org44202a22014-03-11 19:22:18 +00003982
Lei Zhangb8c62cf2020-07-15 20:09:37 +00003983 # Process cpplint arguments, if any.
3984 filters = presubmit_canned_checks.GetCppLintFilters(options.filter)
3985 command = ['--filter=' + ','.join(filters)] + args + files
tzik@chromium.orgf204d4b2014-03-13 07:40:55 +00003986 filenames = cpplint.ParseArguments(command)
thestig@chromium.org44202a22014-03-11 19:22:18 +00003987
Lei Zhang379d1ad2020-07-15 19:40:06 +00003988 include_regex = re.compile(settings.GetLintRegex())
3989 ignore_regex = re.compile(settings.GetLintIgnoreRegex())
thestig@chromium.org44202a22014-03-11 19:22:18 +00003990 extra_check_functions = [cpplint_chromium.CheckPointerDeclarationWhitespace]
3991 for filename in filenames:
Lei Zhang379d1ad2020-07-15 19:40:06 +00003992 if not include_regex.match(filename):
vapiera7fbd5a2016-06-16 09:17:49 -07003993 print('Skipping file %s' % filename)
Lei Zhang379d1ad2020-07-15 19:40:06 +00003994 continue
3995
3996 if ignore_regex.match(filename):
3997 print('Ignoring file %s' % filename)
3998 continue
3999
4000 cpplint.ProcessFile(filename, cpplint._cpplint_state.verbose_level,
4001 extra_check_functions)
thestig@chromium.org44202a22014-03-11 19:22:18 +00004002 finally:
4003 os.chdir(previous_cwd)
vapiera7fbd5a2016-06-16 09:17:49 -07004004 print('Total errors found: %d\n' % cpplint._cpplint_state.error_count)
thestig@chromium.org44202a22014-03-11 19:22:18 +00004005 if cpplint._cpplint_state.error_count != 0:
4006 return 1
4007 return 0
4008
4009
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004010@metrics.collector.collect_metrics('git cl presubmit')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004011def CMDpresubmit(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004012 """Runs presubmit tests on the current changelist."""
ilevy@chromium.org375a9022013-01-07 01:12:05 +00004013 parser.add_option('-u', '--upload', action='store_true',
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004014 help='Run upload hook instead of the push hook')
ilevy@chromium.org375a9022013-01-07 01:12:05 +00004015 parser.add_option('-f', '--force', action='store_true',
sbc@chromium.org495ad152012-09-04 23:07:42 +00004016 help='Run checks even if tree is dirty')
Aaron Gable8076c282017-11-29 14:39:41 -08004017 parser.add_option('--all', action='store_true',
4018 help='Run checks against all files, not just modified ones')
Edward Lesmes8e282792018-04-03 18:50:29 -04004019 parser.add_option('--parallel', action='store_true',
4020 help='Run all tests specified by input_api.RunTests in all '
4021 'PRESUBMIT files in parallel.')
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00004022 parser.add_option('--resultdb', action='store_true',
4023 help='Run presubmit checks in the ResultSink environment '
4024 'and send results to the ResultDB database.')
Saagar Sanghavi03b15132020-08-10 16:43:41 +00004025 parser.add_option('--realm', help='LUCI realm if reporting to ResultDB')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004026 options, args = parser.parse_args(args)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004027
sbc@chromium.org71437c02015-04-09 19:29:40 +00004028 if not options.force and git_common.is_dirty_git_tree('presubmit'):
vapiera7fbd5a2016-06-16 09:17:49 -07004029 print('use --force to check even if tree is dirty.')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004030 return 1
4031
Edward Lemur934836a2019-09-09 20:16:54 +00004032 cl = Changelist()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004033 if args:
4034 base_branch = args[0]
4035 else:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00004036 # Default to diffing against the common ancestor of the upstream branch.
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00004037 base_branch = cl.GetCommonAncestorWithUpstream()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004038
Gregory Nisbet29d5cf82020-02-27 08:16:58 +00004039 if cl.GetIssue():
4040 description = cl.FetchDescription()
Aaron Gable8076c282017-11-29 14:39:41 -08004041 else:
Edward Lemura12175c2020-03-09 16:58:26 +00004042 description = _create_description_from_log([base_branch])
Aaron Gable8076c282017-11-29 14:39:41 -08004043
ilevy@chromium.org051ad0e2013-03-04 21:57:34 +00004044 cl.RunHook(
4045 committing=not options.upload,
4046 may_prompt=False,
4047 verbose=options.verbose,
Edward Lemur227d5102020-02-25 23:45:35 +00004048 parallel=options.parallel,
4049 upstream=base_branch,
4050 description=description,
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00004051 all_files=options.all,
Saagar Sanghavi03b15132020-08-10 16:43:41 +00004052 resultdb=options.resultdb,
4053 realm=options.realm)
dpranke@chromium.org0a2bb372011-03-25 01:16:22 +00004054 return 0
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004055
4056
tandrii@chromium.org65874e12016-03-04 12:03:02 +00004057def GenerateGerritChangeId(message):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004058 """Returns the Change ID footer value (Ixxxxxx...xxx).
tandrii@chromium.org65874e12016-03-04 12:03:02 +00004059
4060 Works the same way as
4061 https://gerrit-review.googlesource.com/tools/hooks/commit-msg
4062 but can be called on demand on all platforms.
4063
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004064 The basic idea is to generate git hash of a state of the tree, original
4065 commit message, author/committer info and timestamps.
tandrii@chromium.org65874e12016-03-04 12:03:02 +00004066 """
4067 lines = []
4068 tree_hash = RunGitSilent(['write-tree'])
4069 lines.append('tree %s' % tree_hash.strip())
4070 code, parent = RunGitWithCode(['rev-parse', 'HEAD~0'], suppress_stderr=False)
4071 if code == 0:
4072 lines.append('parent %s' % parent.strip())
4073 author = RunGitSilent(['var', 'GIT_AUTHOR_IDENT'])
4074 lines.append('author %s' % author.strip())
4075 committer = RunGitSilent(['var', 'GIT_COMMITTER_IDENT'])
4076 lines.append('committer %s' % committer.strip())
4077 lines.append('')
4078 # Note: Gerrit's commit-hook actually cleans message of some lines and
4079 # whitespace. This code is not doing this, but it clearly won't decrease
4080 # entropy.
4081 lines.append(message)
4082 change_hash = RunCommand(['git', 'hash-object', '-t', 'commit', '--stdin'],
Raul Tambreb946b232019-03-26 14:48:46 +00004083 stdin=('\n'.join(lines)).encode())
tandrii@chromium.org65874e12016-03-04 12:03:02 +00004084 return 'I%s' % change_hash.strip()
4085
4086
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01004087def GetTargetRef(remote, remote_branch, target_branch):
wittman@chromium.org455dc922015-01-26 20:15:50 +00004088 """Computes the remote branch ref to use for the CL.
4089
4090 Args:
4091 remote (str): The git remote for the CL.
4092 remote_branch (str): The git remote branch for the CL.
4093 target_branch (str): The target branch specified by the user.
wittman@chromium.org455dc922015-01-26 20:15:50 +00004094 """
4095 if not (remote and remote_branch):
4096 return None
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00004097
wittman@chromium.org455dc922015-01-26 20:15:50 +00004098 if target_branch:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07004099 # Canonicalize branch references to the equivalent local full symbolic
wittman@chromium.org455dc922015-01-26 20:15:50 +00004100 # refs, which are then translated into the remote full symbolic refs
4101 # below.
4102 if '/' not in target_branch:
4103 remote_branch = 'refs/remotes/%s/%s' % (remote, target_branch)
4104 else:
4105 prefix_replacements = (
4106 ('^((refs/)?remotes/)?branch-heads/', 'refs/remotes/branch-heads/'),
4107 ('^((refs/)?remotes/)?%s/' % remote, 'refs/remotes/%s/' % remote),
4108 ('^(refs/)?heads/', 'refs/remotes/%s/' % remote),
4109 )
4110 match = None
4111 for regex, replacement in prefix_replacements:
4112 match = re.search(regex, target_branch)
4113 if match:
4114 remote_branch = target_branch.replace(match.group(0), replacement)
4115 break
4116 if not match:
4117 # This is a branch path but not one we recognize; use as-is.
4118 remote_branch = target_branch
rmistry@google.comc68112d2015-03-03 12:48:06 +00004119 elif remote_branch in REFS_THAT_ALIAS_TO_OTHER_REFS:
4120 # Handle the refs that need to land in different refs.
4121 remote_branch = REFS_THAT_ALIAS_TO_OTHER_REFS[remote_branch]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00004122
Josip Sokcevicc39ab992020-09-24 20:09:15 +00004123 # Migration to new default branch, only if available on remote.
4124 allow_push_on_master = bool(os.environ.get("ALLOW_PUSH_TO_MASTER", None))
4125 if remote_branch == DEFAULT_OLD_BRANCH and not allow_push_on_master:
4126 if RunGit(['show-branch', DEFAULT_NEW_BRANCH], error_ok=True,
4127 stderr=subprocess2.PIPE):
4128 # TODO(crbug.com/ID): Print location to local git migration script.
4129 print("WARNING: Using new branch name %s instead of %s" % (
4130 DEFAULT_NEW_BRANCH, DEFAULT_OLD_BRANCH))
4131 remote_branch = DEFAULT_NEW_BRANCH
4132
wittman@chromium.org455dc922015-01-26 20:15:50 +00004133 # Create the true path to the remote branch.
4134 # Does the following translation:
4135 # * refs/remotes/origin/refs/diff/test -> refs/diff/test
Josip Sokcevicc39ab992020-09-24 20:09:15 +00004136 # * refs/remotes/origin/main -> refs/heads/main
wittman@chromium.org455dc922015-01-26 20:15:50 +00004137 # * refs/remotes/branch-heads/test -> refs/branch-heads/test
4138 if remote_branch.startswith('refs/remotes/%s/refs/' % remote):
4139 remote_branch = remote_branch.replace('refs/remotes/%s/' % remote, '')
4140 elif remote_branch.startswith('refs/remotes/%s/' % remote):
4141 remote_branch = remote_branch.replace('refs/remotes/%s/' % remote,
4142 'refs/heads/')
4143 elif remote_branch.startswith('refs/remotes/branch-heads'):
4144 remote_branch = remote_branch.replace('refs/remotes/', 'refs/')
Andrii Shyshkalov768f1d82016-12-08 15:10:13 +01004145
wittman@chromium.org455dc922015-01-26 20:15:50 +00004146 return remote_branch
4147
4148
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00004149def cleanup_list(l):
4150 """Fixes a list so that comma separated items are put as individual items.
4151
4152 So that "--reviewers joe@c,john@c --reviewers joa@c" results in
4153 options.reviewers == sorted(['joe@c', 'john@c', 'joa@c']).
4154 """
4155 items = sum((i.split(',') for i in l), [])
4156 stripped_items = (i.strip() for i in items)
4157 return sorted(filter(None, stripped_items))
4158
4159
Aaron Gable4db38df2017-11-03 14:59:07 -07004160@subcommand.usage('[flags]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004161@metrics.collector.collect_metrics('git cl upload')
ukai@chromium.orge8077812012-02-03 03:41:46 +00004162def CMDupload(parser, args):
rmistry@google.com78948ed2015-07-08 23:09:57 +00004163 """Uploads the current changelist to codereview.
4164
4165 Can skip dependency patchset uploads for a branch by running:
4166 git config branch.branch_name.skip-deps-uploads True
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004167 To unset, run:
rmistry@google.com78948ed2015-07-08 23:09:57 +00004168 git config --unset branch.branch_name.skip-deps-uploads
4169 Can also set the above globally by using the --global flag.
Dominic Battre7d1c4842017-10-27 09:17:28 +02004170
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004171 If the name of the checked out branch starts with "bug-" or "fix-" followed
4172 by a bug number, this bug number is automatically populated in the CL
Dominic Battre7d1c4842017-10-27 09:17:28 +02004173 description.
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004174
4175 If subject contains text in square brackets or has "<text>: " prefix, such
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004176 text(s) is treated as Gerrit hashtags. For example, CLs with subjects:
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004177 [git-cl] add support for hashtags
4178 Foo bar: implement foo
4179 will be hashtagged with "git-cl" and "foo-bar" respectively.
rmistry@google.com78948ed2015-07-08 23:09:57 +00004180 """
ukai@chromium.orge8077812012-02-03 03:41:46 +00004181 parser.add_option('--bypass-hooks', action='store_true', dest='bypass_hooks',
4182 help='bypass upload presubmit hook')
brettw@chromium.orgb65c43c2013-06-10 22:04:49 +00004183 parser.add_option('--bypass-watchlists', action='store_true',
4184 dest='bypass_watchlists',
4185 help='bypass watchlists auto CC-ing reviewers')
Aaron Gablef7543cd2017-07-20 14:26:31 -07004186 parser.add_option('-f', '--force', action='store_true', dest='force',
ukai@chromium.orge8077812012-02-03 03:41:46 +00004187 help="force yes to questions (don't prompt)")
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004188 parser.add_option('--message', '-m', dest='message',
4189 help='message for patchset')
tandriif9aefb72016-07-01 09:06:51 -07004190 parser.add_option('-b', '--bug',
4191 help='pre-populate the bug number(s) for this issue. '
4192 'If several, separate with commas')
tandriib80458a2016-06-23 12:20:07 -07004193 parser.add_option('--message-file', dest='message_file',
4194 help='file which contains message for patchset')
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004195 parser.add_option('--title', '-t', dest='title',
4196 help='title for patchset')
Mario Bianuccicebfb4e2020-07-22 23:08:16 +00004197 parser.add_option('-T', '--skip-title', action='store_true',
4198 dest='skip_title',
4199 help='Use the most recent commit message as the title of '
4200 'the patchset')
ukai@chromium.orge8077812012-02-03 03:41:46 +00004201 parser.add_option('-r', '--reviewers',
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00004202 action='append', default=[],
ukai@chromium.orge8077812012-02-03 03:41:46 +00004203 help='reviewer email addresses')
Robert Iannucci6c98dc62017-04-18 11:38:00 -07004204 parser.add_option('--tbrs',
4205 action='append', default=[],
4206 help='TBR email addresses')
ukai@chromium.orge8077812012-02-03 03:41:46 +00004207 parser.add_option('--cc',
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00004208 action='append', default=[],
ukai@chromium.orge8077812012-02-03 03:41:46 +00004209 help='cc email addresses')
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004210 parser.add_option('--hashtag', dest='hashtags',
4211 action='append', default=[],
4212 help=('Gerrit hashtag for new CL; '
4213 'can be applied multiple times'))
adamk@chromium.org36f47302013-04-05 01:08:31 +00004214 parser.add_option('-s', '--send-mail', action='store_true',
Aaron Gable59f48512017-01-12 10:54:46 -08004215 help='send email to reviewer(s) and cc(s) immediately')
ukai@chromium.org8ef7ab22012-11-28 04:24:52 +00004216 parser.add_option('--target_branch',
pgervais@chromium.orgb9f27512014-08-08 15:52:33 +00004217 '--target-branch',
wittman@chromium.org455dc922015-01-26 20:15:50 +00004218 metavar='TARGET',
4219 help='Apply CL to remote ref TARGET. ' +
Josip Sokcevicc39ab992020-09-24 20:09:15 +00004220 'Default: remote branch head, or main')
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00004221 parser.add_option('--squash', action='store_true',
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004222 help='Squash multiple commits into one')
Mike Frysingera989d552019-08-14 20:51:23 +00004223 parser.add_option('--no-squash', action='store_false', dest='squash',
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004224 help='Don\'t squash multiple commits into one')
rmistry9eadede2016-09-19 11:22:43 -07004225 parser.add_option('--topic', default=None,
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004226 help='Topic to specify when uploading')
Robert Iannuccif2708bd2017-04-17 15:49:02 -07004227 parser.add_option('--tbr-owners', dest='add_owners_to', action='store_const',
4228 const='TBR', help='add a set of OWNERS to TBR')
4229 parser.add_option('--r-owners', dest='add_owners_to', action='store_const',
4230 const='R', help='add a set of OWNERS to R')
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +00004231 parser.add_option('-c', '--use-commit-queue', action='store_true',
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004232 default=False,
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +00004233 help='tell the CQ to commit this patchset; '
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004234 'implies --send-mail')
4235 parser.add_option('-d', '--cq-dry-run',
4236 action='store_true', default=False,
rmistry@google.comef966222015-04-07 11:15:01 +00004237 help='Send the patchset to do a CQ dry run right after '
4238 'upload.')
Greg Gutermanbe5fccd2021-06-14 17:58:20 +00004239 parser.add_option(
4240 '-q',
4241 '--cq-quick-run',
4242 action='store_true',
4243 default=False,
4244 help='Send the patchset to do a CQ quick run right after '
4245 'upload (https://source.chromium.org/chromium/chromium/src/+/main:do'
4246 'cs/cq_quick_run.md) (chromium only).')
Edward Lesmes10c3dd62021-02-08 21:13:57 +00004247 parser.add_option('--set-bot-commit', action='store_true',
4248 help=optparse.SUPPRESS_HELP)
Andrii Shyshkalov71f0da32019-07-15 22:45:18 +00004249 parser.add_option('--preserve-tryjobs', action='store_true',
4250 help='instruct the CQ to let tryjobs running even after '
4251 'new patchsets are uploaded instead of canceling '
4252 'prior patchset\' tryjobs')
rmistry@google.com2dd99862015-06-22 12:22:18 +00004253 parser.add_option('--dependencies', action='store_true',
4254 help='Uploads CLs of all the local branches that depend on '
4255 'the current branch')
Ravi Mistry31e7d562018-04-02 12:53:57 -04004256 parser.add_option('-a', '--enable-auto-submit', action='store_true',
4257 help='Sends your change to the CQ after an approval. Only '
4258 'works on repos that have the Auto-Submit label '
4259 'enabled')
Edward Lesmes8e282792018-04-03 18:50:29 -04004260 parser.add_option('--parallel', action='store_true',
4261 help='Run all tests specified by input_api.RunTests in all '
4262 'PRESUBMIT files in parallel.')
Sergiy Byelozyorov1aa405f2018-09-18 17:38:43 +00004263 parser.add_option('--no-autocc', action='store_true',
4264 help='Disables automatic addition of CC emails')
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004265 parser.add_option('--private', action='store_true',
Sergiy Byelozyorov1aa405f2018-09-18 17:38:43 +00004266 help='Set the review private. This implies --no-autocc.')
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004267 parser.add_option('-R', '--retry-failed', action='store_true',
4268 help='Retry failed tryjobs from old patchset immediately '
4269 'after uploading new patchset. Cannot be used with '
4270 '--use-commit-queue or --cq-dry-run.')
4271 parser.add_option('--buildbucket-host', default='cr-buildbucket.appspot.com',
4272 help='Host of buildbucket. The default host is %default.')
Dan Beamd8b04ca2019-10-10 21:23:26 +00004273 parser.add_option('--fixed', '-x',
4274 help='List of bugs that will be commented on and marked '
4275 'fixed (pre-populates "Fixed:" tag). Same format as '
4276 '-b option / "Bug:" tag. If fixing several issues, '
4277 'separate with commas.')
Josipe827b0f2020-01-30 00:07:20 +00004278 parser.add_option('--edit-description', action='store_true', default=False,
4279 help='Modify description before upload. Cannot be used '
4280 'with --force. It is a noop when --no-squash is set '
4281 'or a new commit is created.')
Ng Zhi Ancdaf0be2020-05-27 20:57:28 +00004282 parser.add_option('--git-completion-helper', action="store_true",
4283 help=optparse.SUPPRESS_HELP)
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00004284 parser.add_option('--resultdb', action='store_true',
4285 help='Run presubmit checks in the ResultSink environment '
4286 'and send results to the ResultDB database.')
Saagar Sanghavi03b15132020-08-10 16:43:41 +00004287 parser.add_option('--realm', help='LUCI realm if reporting to ResultDB')
Josip Sokcevicf2cfd3d2021-03-30 18:39:18 +00004288 parser.add_option('-o',
4289 '--push-options',
4290 action='append',
4291 default=[],
4292 help='Transmit the given string to the server when '
4293 'performing git push (pass-through). See git-push '
4294 'documentation for more details.')
Gregory Nisbet48d9e1e2021-04-15 23:35:54 +00004295 parser.add_option('--no-add-changeid',
4296 action='store_true',
4297 dest='no_add_changeid',
4298 help='Do not add change-ids to messages.')
Sergiy Byelozyorov1aa405f2018-09-18 17:38:43 +00004299
rmistry@google.com2dd99862015-06-22 12:22:18 +00004300 orig_args = args
ukai@chromium.orge8077812012-02-03 03:41:46 +00004301 (options, args) = parser.parse_args(args)
4302
Ng Zhi Ancdaf0be2020-05-27 20:57:28 +00004303 if options.git_completion_helper:
Edward Lesmesb7db1832020-06-22 20:22:27 +00004304 print(' '.join(opt.get_opt_string() for opt in parser.option_list
4305 if opt.help != optparse.SUPPRESS_HELP))
4306 return
Ng Zhi Ancdaf0be2020-05-27 20:57:28 +00004307
sbc@chromium.org71437c02015-04-09 19:29:40 +00004308 if git_common.is_dirty_git_tree('upload'):
ukai@chromium.orge8077812012-02-03 03:41:46 +00004309 return 1
4310
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00004311 options.reviewers = cleanup_list(options.reviewers)
Robert Iannucci6c98dc62017-04-18 11:38:00 -07004312 options.tbrs = cleanup_list(options.tbrs)
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00004313 options.cc = cleanup_list(options.cc)
4314
Josipe827b0f2020-01-30 00:07:20 +00004315 if options.edit_description and options.force:
4316 parser.error('Only one of --force and --edit-description allowed')
4317
tandriib80458a2016-06-23 12:20:07 -07004318 if options.message_file:
4319 if options.message:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004320 parser.error('Only one of --message and --message-file allowed.')
tandriib80458a2016-06-23 12:20:07 -07004321 options.message = gclient_utils.FileRead(options.message_file)
tandriib80458a2016-06-23 12:20:07 -07004322
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004323 if ([options.cq_dry_run,
Greg Gutermanbe5fccd2021-06-14 17:58:20 +00004324 options.cq_quick_run,
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004325 options.use_commit_queue,
4326 options.retry_failed].count(True) > 1):
Greg Gutermanbe5fccd2021-06-14 17:58:20 +00004327 parser.error('Only one of --use-commit-queue, --cq-dry-run, --cq-quick-run '
4328 'or --retry-failed is allowed.')
tandrii4d0545a2016-07-06 03:56:49 -07004329
Mario Bianuccicebfb4e2020-07-22 23:08:16 +00004330 if options.skip_title and options.title:
4331 parser.error('Only one of --title and --skip-title allowed.')
4332
Aaron Gableedbc4132017-09-11 13:22:28 -07004333 if options.use_commit_queue:
4334 options.send_mail = True
4335
Edward Lesmes0dd54822020-03-26 18:24:25 +00004336 if options.squash is None:
4337 # Load default for user, repo, squash=true, in this order.
4338 options.squash = settings.GetSquashGerritUploads()
4339
Josip Sokcevic1cabb172021-04-08 19:15:35 +00004340 cl = Changelist(branchref=options.target_branch)
Edward Lesmes7677e5c2020-02-19 20:39:03 +00004341 # Warm change details cache now to avoid RPCs later, reducing latency for
4342 # developers.
4343 if cl.GetIssue():
4344 cl._GetChangeDetail(
4345 ['DETAILED_ACCOUNTS', 'CURRENT_REVISION', 'CURRENT_COMMIT', 'LABELS'])
4346
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004347 if options.retry_failed and not cl.GetIssue():
4348 print('No previous patchsets, so --retry-failed has no effect.')
4349 options.retry_failed = False
Edward Lesmes7677e5c2020-02-19 20:39:03 +00004350
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004351 # cl.GetMostRecentPatchset uses cached information, and can return the last
4352 # patchset before upload. Calling it here makes it clear that it's the
4353 # last patchset before upload. Note that GetMostRecentPatchset will fail
4354 # if no CL has been uploaded yet.
4355 if options.retry_failed:
4356 patchset = cl.GetMostRecentPatchset()
Andrii Shyshkalov9f274432018-10-15 16:40:23 +00004357
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004358 ret = cl.CMDUpload(options, args, orig_args)
4359
4360 if options.retry_failed:
4361 if ret != 0:
4362 print('Upload failed, so --retry-failed has no effect.')
4363 return ret
Andrii Shyshkalov1ad58112019-10-08 01:46:14 +00004364 builds, _ = _fetch_latest_builds(
Edward Lemur5b929a42019-10-21 17:57:39 +00004365 cl, options.buildbucket_host, latest_patchset=patchset)
Edward Lemur45768512020-03-02 19:03:14 +00004366 jobs = _filter_failed_for_retry(builds)
4367 if len(jobs) == 0:
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004368 print('No failed tryjobs, so --retry-failed has no effect.')
4369 return ret
Quinten Yearsley777660f2020-03-04 23:37:06 +00004370 _trigger_tryjobs(cl, jobs, options, patchset + 1)
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004371
4372 return ret
ukai@chromium.orge8077812012-02-03 03:41:46 +00004373
4374
Francois Dorayd42c6812017-05-30 15:10:20 -04004375@subcommand.usage('--description=<description file>')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004376@metrics.collector.collect_metrics('git cl split')
Francois Dorayd42c6812017-05-30 15:10:20 -04004377def CMDsplit(parser, args):
4378 """Splits a branch into smaller branches and uploads CLs.
4379
4380 Creates a branch and uploads a CL for each group of files modified in the
4381 current branch that share a common OWNERS file. In the CL description and
Edward Lemurac5c55f2020-02-29 00:17:16 +00004382 comment, the string '$directory', is replaced with the directory containing
4383 the shared OWNERS file.
Francois Dorayd42c6812017-05-30 15:10:20 -04004384 """
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004385 parser.add_option('-d', '--description', dest='description_file',
4386 help='A text file containing a CL description in which '
4387 '$directory will be replaced by each CL\'s directory.')
4388 parser.add_option('-c', '--comment', dest='comment_file',
4389 help='A text file containing a CL comment.')
4390 parser.add_option('-n', '--dry-run', dest='dry_run', action='store_true',
Chris Watkinsba28e462017-12-13 11:22:17 +11004391 default=False,
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004392 help='List the files and reviewers for each CL that would '
4393 'be created, but don\'t create branches or CLs.')
4394 parser.add_option('--cq-dry-run', action='store_true',
4395 help='If set, will do a cq dry run for each uploaded CL. '
4396 'Please be careful when doing this; more than ~10 CLs '
4397 'has the potential to overload our build '
4398 'infrastructure. Try to upload these not during high '
4399 'load times (usually 11-3 Mountain View time). Email '
4400 'infra-dev@chromium.org with any questions.')
Takuto Ikuta51eca592019-02-14 19:40:52 +00004401 parser.add_option('-a', '--enable-auto-submit', action='store_true',
4402 default=True,
4403 help='Sends your change to the CQ after an approval. Only '
4404 'works on repos that have the Auto-Submit label '
4405 'enabled')
Francois Dorayd42c6812017-05-30 15:10:20 -04004406 options, _ = parser.parse_args(args)
4407
4408 if not options.description_file:
4409 parser.error('No --description flag specified.')
4410
4411 def WrappedCMDupload(args):
4412 return CMDupload(OptionParser(), args)
4413
Edward Lemur2c62b332020-03-12 22:12:33 +00004414 return split_cl.SplitCl(
4415 options.description_file, options.comment_file, Changelist,
4416 WrappedCMDupload, options.dry_run, options.cq_dry_run,
4417 options.enable_auto_submit, settings.GetRoot())
Francois Dorayd42c6812017-05-30 15:10:20 -04004418
4419
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004420@subcommand.usage('DEPRECATED')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004421@metrics.collector.collect_metrics('git cl commit')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004422def CMDdcommit(parser, args):
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004423 """DEPRECATED: Used to commit the current changelist via git-svn."""
4424 message = ('git-cl no longer supports committing to SVN repositories via '
4425 'git-svn. You probably want to use `git cl land` instead.')
4426 print(message)
4427 return 1
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004428
4429
maruel@chromium.org0633fb42013-08-16 20:06:14 +00004430@subcommand.usage('[upstream branch to apply against]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004431@metrics.collector.collect_metrics('git cl land')
pgervais@chromium.orgcee6dc42014-05-07 17:04:03 +00004432def CMDland(parser, args):
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004433 """Commits the current changelist via git.
4434
4435 In case of Gerrit, uses Gerrit REST api to "submit" the issue, which pushes
4436 upstream and closes the issue automatically and atomically.
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004437 """
4438 parser.add_option('--bypass-hooks', action='store_true', dest='bypass_hooks',
4439 help='bypass upload presubmit hook')
Aaron Gablef7543cd2017-07-20 14:26:31 -07004440 parser.add_option('-f', '--force', action='store_true', dest='force',
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004441 help="force yes to questions (don't prompt)")
Edward Lesmes67b3faa2018-04-13 17:50:52 -04004442 parser.add_option('--parallel', action='store_true',
4443 help='Run all tests specified by input_api.RunTests in all '
4444 'PRESUBMIT files in parallel.')
Saagar Sanghavi03b15132020-08-10 16:43:41 +00004445 parser.add_option('--resultdb', action='store_true',
4446 help='Run presubmit checks in the ResultSink environment '
4447 'and send results to the ResultDB database.')
4448 parser.add_option('--realm', help='LUCI realm if reporting to ResultDB')
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004449 (options, args) = parser.parse_args(args)
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004450
Edward Lemur934836a2019-09-09 20:16:54 +00004451 cl = Changelist()
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004452
Robert Iannucci2e73d432018-03-14 01:10:47 -07004453 if not cl.GetIssue():
4454 DieWithError('You must upload the change first to Gerrit.\n'
4455 ' If you would rather have `git cl land` upload '
4456 'automatically for you, see http://crbug.com/642759')
Saagar Sanghavi03b15132020-08-10 16:43:41 +00004457 return cl.CMDLand(options.force, options.bypass_hooks, options.verbose,
4458 options.parallel, options.resultdb, options.realm)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004459
4460
dsinclair@chromium.orgfbed6562015-09-25 21:22:36 +00004461@subcommand.usage('<patch url or issue id or issue url>')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004462@metrics.collector.collect_metrics('git cl patch')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004463def CMDpatch(parser, args):
marq@chromium.orge5e59002013-10-02 23:21:25 +00004464 """Patches in a code review."""
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004465 parser.add_option('-b', dest='newbranch',
4466 help='create a new branch off trunk for the patch')
qsr@chromium.org1ef44af2013-10-16 16:24:32 +00004467 parser.add_option('-f', '--force', action='store_true',
Aaron Gable62619a32017-06-16 08:22:09 -07004468 help='overwrite state on the current or chosen branch')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004469 parser.add_option('-n', '--no-commit', action='store_true', dest='nocommit',
Edward Lemurf38bc172019-09-03 21:02:13 +00004470 help='don\'t commit after patch applies.')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004471
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00004472 group = optparse.OptionGroup(
4473 parser,
4474 'Options for continuing work on the current issue uploaded from a '
4475 'different clone (e.g. different machine). Must be used independently '
4476 'from the other options. No issue number should be specified, and the '
4477 'branch must have an issue number associated with it')
4478 group.add_option('--reapply', action='store_true', dest='reapply',
4479 help='Reset the branch and reapply the issue.\n'
4480 'CAUTION: This will undo any local changes in this '
4481 'branch')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004482
4483 group.add_option('--pull', action='store_true', dest='pull',
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00004484 help='Performs a pull before reapplying.')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004485 parser.add_option_group(group)
4486
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004487 (options, args) = parser.parse_args(args)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004488
Andrii Shyshkalov18975322017-01-25 16:44:13 +01004489 if options.reapply:
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004490 if options.newbranch:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004491 parser.error('--reapply works on the current branch only.')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004492 if len(args) > 0:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004493 parser.error('--reapply implies no additional arguments.')
dsinclair@chromium.orgfbed6562015-09-25 21:22:36 +00004494
Edward Lemur934836a2019-09-09 20:16:54 +00004495 cl = Changelist()
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004496 if not cl.GetIssue():
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004497 parser.error('Current branch must have an associated issue.')
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004498
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004499 upstream = cl.GetUpstreamBranch()
Andrii Shyshkalov18975322017-01-25 16:44:13 +01004500 if upstream is None:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004501 parser.error('No upstream branch specified. Cannot reset branch.')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004502
4503 RunGit(['reset', '--hard', upstream])
4504 if options.pull:
4505 RunGit(['pull'])
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004506
Edward Lemur678a6842019-10-03 22:25:05 +00004507 target_issue_arg = ParseIssueNumberArgument(cl.GetIssue())
Bruce Dawsonf362f6f2021-02-18 23:15:17 +00004508 return cl.CMDPatchWithParsedIssue(target_issue_arg, options.nocommit, False,
4509 False)
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004510
4511 if len(args) != 1 or not args[0]:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004512 parser.error('Must specify issue number or URL.')
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004513
Edward Lemurf38bc172019-09-03 21:02:13 +00004514 target_issue_arg = ParseIssueNumberArgument(args[0])
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004515 if not target_issue_arg.valid:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004516 parser.error('Invalid issue ID or URL.')
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004517
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004518 # We don't want uncommitted changes mixed up with the patch.
4519 if git_common.is_dirty_git_tree('patch'):
dsinclair@chromium.orgfbed6562015-09-25 21:22:36 +00004520 return 1
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004521
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004522 if options.newbranch:
4523 if options.force:
4524 RunGit(['branch', '-D', options.newbranch],
4525 stderr=subprocess2.PIPE, error_ok=True)
Edward Lemur84101642020-02-21 21:40:34 +00004526 git_new_branch.create_new_branch(options.newbranch)
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004527
Edward Lemur678a6842019-10-03 22:25:05 +00004528 cl = Changelist(
4529 codereview_host=target_issue_arg.hostname, issue=target_issue_arg.issue)
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004530
Edward Lemur678a6842019-10-03 22:25:05 +00004531 if not args[0].isdigit():
Edward Lemurf38bc172019-09-03 21:02:13 +00004532 print('canonical issue/change URL: %s\n' % cl.GetIssueURL())
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004533
Bruce Dawsonf362f6f2021-02-18 23:15:17 +00004534 return cl.CMDPatchWithParsedIssue(target_issue_arg, options.nocommit,
4535 options.force, options.newbranch)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004536
4537
jochen@chromium.org3ec0d542014-01-14 20:00:03 +00004538def GetTreeStatus(url=None):
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004539 """Fetches the tree status and returns either 'open', 'closed',
4540 'unknown' or 'unset'."""
jochen@chromium.org3ec0d542014-01-14 20:00:03 +00004541 url = url or settings.GetTreeStatusUrl(error_ok=True)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004542 if url:
Daniel McArdle8b4eeff2020-07-20 17:02:47 +00004543 status = str(urllib.request.urlopen(url).read().lower())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004544 if status.find('closed') != -1 or status == '0':
4545 return 'closed'
4546 elif status.find('open') != -1 or status == '1':
4547 return 'open'
4548 return 'unknown'
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004549 return 'unset'
4550
dpranke@chromium.org970c5222011-03-12 00:32:24 +00004551
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004552def GetTreeStatusReason():
4553 """Fetches the tree status from a json url and returns the message
4554 with the reason for the tree to be opened or closed."""
msb@chromium.orgbf1a7ba2011-02-01 16:21:46 +00004555 url = settings.GetTreeStatusUrl()
Daniel McArdle8b4eeff2020-07-20 17:02:47 +00004556 json_url = urllib.parse.urljoin(url, '/current?format=json')
Edward Lemur79d4f992019-11-11 23:49:02 +00004557 connection = urllib.request.urlopen(json_url)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004558 status = json.loads(connection.read())
4559 connection.close()
4560 return status['message']
4561
dpranke@chromium.org970c5222011-03-12 00:32:24 +00004562
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004563@metrics.collector.collect_metrics('git cl tree')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004564def CMDtree(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004565 """Shows the status of the tree."""
dpranke@chromium.org97ae58e2011-03-18 00:29:20 +00004566 _, args = parser.parse_args(args)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004567 status = GetTreeStatus()
4568 if 'unset' == status:
vapiera7fbd5a2016-06-16 09:17:49 -07004569 print('You must configure your tree status URL by running "git cl config".')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004570 return 2
4571
vapiera7fbd5a2016-06-16 09:17:49 -07004572 print('The tree is %s' % status)
4573 print()
4574 print(GetTreeStatusReason())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004575 if status != 'open':
4576 return 1
4577 return 0
4578
4579
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004580@metrics.collector.collect_metrics('git cl try')
maruel@chromium.org15192402012-09-06 12:38:29 +00004581def CMDtry(parser, args):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004582 """Triggers tryjobs using either Buildbucket or CQ dry run."""
4583 group = optparse.OptionGroup(parser, 'Tryjob options')
maruel@chromium.org15192402012-09-06 12:38:29 +00004584 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004585 '-b', '--bot', action='append',
4586 help=('IMPORTANT: specify ONE builder per --bot flag. Use it multiple '
4587 'times to specify multiple builders. ex: '
4588 '"-b win_rel -b win_layout". See '
4589 'the try server waterfall for the builders name and the tests '
4590 'available.'))
maruel@chromium.org15192402012-09-06 12:38:29 +00004591 group.add_option(
borenet6c0efe62016-10-19 08:13:29 -07004592 '-B', '--bucket', default='',
4593 help=('Buildbucket bucket to send the try requests.'))
4594 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004595 '-r', '--revision',
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004596 help='Revision to use for the tryjob; default: the revision will '
tandriif7b29d42016-10-07 08:45:41 -07004597 'be determined by the try recipe that builder runs, which usually '
Josip Sokcevicc39ab992020-09-24 20:09:15 +00004598 'defaults to HEAD of origin/master or origin/main')
maruel@chromium.org15192402012-09-06 12:38:29 +00004599 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004600 '-c', '--clobber', action='store_true', default=False,
tandriif7b29d42016-10-07 08:45:41 -07004601 help='Force a clobber before building; that is don\'t do an '
tandrii1838bad2016-10-06 00:10:52 -07004602 'incremental build')
maruel@chromium.org15192402012-09-06 12:38:29 +00004603 group.add_option(
Greg Gutermanbe5fccd2021-06-14 17:58:20 +00004604 '-q',
4605 '--quick-run',
4606 action='store_true',
4607 default=False,
4608 help='trigger in quick run mode '
4609 '(https://source.chromium.org/chromium/chromium/src/+/main:docs/cq_q'
4610 'uick_run.md) (chromium only).')
4611 group.add_option(
Andrii Shyshkalovf9648b52018-02-21 22:32:42 -08004612 '--category', default='git_cl_try', help='Specify custom build category.')
4613 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004614 '--project',
4615 help='Override which project to use. Projects are defined '
tandriif7b29d42016-10-07 08:45:41 -07004616 'in recipe to determine to which repository or directory to '
4617 'apply the patch')
maruel@chromium.org15192402012-09-06 12:38:29 +00004618 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004619 '-p', '--property', dest='properties', action='append', default=[],
4620 help='Specify generic properties in the form -p key1=value1 -p '
tandriif7b29d42016-10-07 08:45:41 -07004621 'key2=value2 etc. The value will be treated as '
4622 'json if decodable, or as string otherwise. '
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004623 'NOTE: using this may make your tryjob not usable for CQ, '
4624 'which will then schedule another tryjob with default properties')
sheyang@chromium.orgdb375572015-08-17 19:22:23 +00004625 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004626 '--buildbucket-host', default='cr-buildbucket.appspot.com',
4627 help='Host of buildbucket. The default host is %default.')
maruel@chromium.org15192402012-09-06 12:38:29 +00004628 parser.add_option_group(group)
Quinten Yearsley983111f2019-09-26 17:18:48 +00004629 parser.add_option(
4630 '-R', '--retry-failed', action='store_true', default=False,
4631 help='Retry failed jobs from the latest set of tryjobs. '
4632 'Not allowed with --bucket and --bot options.')
Edward Lemur52969c92020-02-06 18:15:28 +00004633 parser.add_option(
4634 '-i', '--issue', type=int,
4635 help='Operate on this issue instead of the current branch\'s implicit '
4636 'issue.')
maruel@chromium.org15192402012-09-06 12:38:29 +00004637 options, args = parser.parse_args(args)
4638
machenbach@chromium.org45453142015-09-15 08:45:22 +00004639 # Make sure that all properties are prop=value pairs.
4640 bad_params = [x for x in options.properties if '=' not in x]
4641 if bad_params:
4642 parser.error('Got properties with missing "=": %s' % bad_params)
4643
maruel@chromium.org15192402012-09-06 12:38:29 +00004644 if args:
4645 parser.error('Unknown arguments: %s' % args)
4646
Edward Lemur934836a2019-09-09 20:16:54 +00004647 cl = Changelist(issue=options.issue)
maruel@chromium.org15192402012-09-06 12:38:29 +00004648 if not cl.GetIssue():
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004649 parser.error('Need to upload first.')
maruel@chromium.org15192402012-09-06 12:38:29 +00004650
Edward Lemurf38bc172019-09-03 21:02:13 +00004651 # HACK: warm up Gerrit change detail cache to save on RPCs.
Edward Lemur125d60a2019-09-13 18:25:41 +00004652 cl._GetChangeDetail(['DETAILED_ACCOUNTS', 'ALL_REVISIONS'])
Andrii Shyshkaloveadad922017-01-26 09:38:30 +01004653
tandriie113dfd2016-10-11 10:20:12 -07004654 error_message = cl.CannotTriggerTryJobReason()
4655 if error_message:
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004656 parser.error('Can\'t trigger tryjobs: %s' % error_message)
jrobbins@chromium.org16f10f72014-06-24 22:14:36 +00004657
Edward Lemur45768512020-03-02 19:03:14 +00004658 if options.bot:
4659 if options.retry_failed:
4660 parser.error('--bot is not compatible with --retry-failed.')
4661 if not options.bucket:
4662 parser.error('A bucket (e.g. "chromium/try") is required.')
4663
4664 triggered = [b for b in options.bot if 'triggered' in b]
4665 if triggered:
4666 parser.error(
4667 'Cannot schedule builds on triggered bots: %s.\n'
4668 'This type of bot requires an initial job from a parent (usually a '
4669 'builder). Schedule a job on the parent instead.\n' % triggered)
4670
4671 if options.bucket.startswith('.master'):
4672 parser.error('Buildbot masters are not supported.')
4673
4674 project, bucket = _parse_bucket(options.bucket)
4675 if project is None or bucket is None:
4676 parser.error('Invalid bucket: %s.' % options.bucket)
4677 jobs = sorted((project, bucket, bot) for bot in options.bot)
4678 elif options.retry_failed:
Quinten Yearsley983111f2019-09-26 17:18:48 +00004679 print('Searching for failed tryjobs...')
Edward Lemur5b929a42019-10-21 17:57:39 +00004680 builds, patchset = _fetch_latest_builds(cl, options.buildbucket_host)
Quinten Yearsley983111f2019-09-26 17:18:48 +00004681 if options.verbose:
4682 print('Got %d builds in patchset #%d' % (len(builds), patchset))
Edward Lemur45768512020-03-02 19:03:14 +00004683 jobs = _filter_failed_for_retry(builds)
4684 if not jobs:
Quinten Yearsley983111f2019-09-26 17:18:48 +00004685 print('There are no failed jobs in the latest set of jobs '
4686 '(patchset #%d), doing nothing.' % patchset)
4687 return 0
Edward Lemur45768512020-03-02 19:03:14 +00004688 num_builders = len(jobs)
Quinten Yearsley983111f2019-09-26 17:18:48 +00004689 if num_builders > 10:
4690 confirm_or_exit('There are %d builders with failed builds.'
4691 % num_builders, action='continue')
Greg Gutermanbe5fccd2021-06-14 17:58:20 +00004692 elif options.quick_run:
4693 print('Scheduling CQ quick run on: %s' % cl.GetIssueURL())
4694 return cl.SetCQState(_CQState.QUICK_RUN)
Quinten Yearsley983111f2019-09-26 17:18:48 +00004695 else:
qyearsley1fdfcb62016-10-24 13:22:03 -07004696 if options.verbose:
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07004697 print('git cl try with no bots now defaults to CQ dry run.')
4698 print('Scheduling CQ dry run on: %s' % cl.GetIssueURL())
4699 return cl.SetCQState(_CQState.DRY_RUN)
stip@chromium.org43064fd2013-12-18 20:07:44 +00004700
ilevy@chromium.org36e420b2013-08-06 23:21:12 +00004701 patchset = cl.GetMostRecentPatchset()
Edward Lemur2c210a42019-09-16 23:58:35 +00004702 try:
Quinten Yearsley777660f2020-03-04 23:37:06 +00004703 _trigger_tryjobs(cl, jobs, options, patchset)
Edward Lemur2c210a42019-09-16 23:58:35 +00004704 except BuildbucketResponseException as ex:
4705 print('ERROR: %s' % ex)
4706 return 1
4707 return 0
maruel@chromium.org15192402012-09-06 12:38:29 +00004708
4709
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004710@metrics.collector.collect_metrics('git cl try-results')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004711def CMDtry_results(parser, args):
Quinten Yearsleyd242ed72019-07-25 17:17:55 +00004712 """Prints info about results for tryjobs associated with the current CL."""
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004713 group = optparse.OptionGroup(parser, 'Tryjob results options')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004714 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004715 '-p', '--patchset', type=int, help='patchset number if not current.')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004716 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004717 '--print-master', action='store_true', help='print master name as well.')
tandrii@chromium.org6cf98c82016-03-15 11:56:00 +00004718 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004719 '--color', action='store_true', default=setup_color.IS_TTY,
4720 help='force color output, useful when piping output.')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004721 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004722 '--buildbucket-host', default='cr-buildbucket.appspot.com',
4723 help='Host of buildbucket. The default host is %default.')
qyearsley53f48a12016-09-01 10:45:13 -07004724 group.add_option(
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004725 '--json', help=('Path of JSON output file to write tryjob results to,'
Stefan Zager1306bd02017-06-22 19:26:46 -07004726 'or "-" for stdout.'))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004727 parser.add_option_group(group)
Edward Lemur52969c92020-02-06 18:15:28 +00004728 parser.add_option(
4729 '-i', '--issue', type=int,
4730 help='Operate on this issue instead of the current branch\'s implicit '
4731 'issue.')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004732 options, args = parser.parse_args(args)
4733 if args:
4734 parser.error('Unrecognized args: %s' % ' '.join(args))
4735
Edward Lemur934836a2019-09-09 20:16:54 +00004736 cl = Changelist(issue=options.issue)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004737 if not cl.GetIssue():
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004738 parser.error('Need to upload first.')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004739
tandrii221ab252016-10-06 08:12:04 -07004740 patchset = options.patchset
4741 if not patchset:
Gavin Make61ccc52020-11-13 00:12:57 +00004742 patchset = cl.GetMostRecentDryRunPatchset()
tandrii221ab252016-10-06 08:12:04 -07004743 if not patchset:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004744 parser.error('Code review host doesn\'t know about issue %s. '
tandrii221ab252016-10-06 08:12:04 -07004745 'No access to issue or wrong issue number?\n'
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004746 'Either upload first, or pass --patchset explicitly.' %
tandrii221ab252016-10-06 08:12:04 -07004747 cl.GetIssue())
4748
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004749 try:
Quinten Yearsley777660f2020-03-04 23:37:06 +00004750 jobs = _fetch_tryjobs(cl, options.buildbucket_host, patchset)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004751 except BuildbucketResponseException as ex:
vapiera7fbd5a2016-06-16 09:17:49 -07004752 print('Buildbucket error: %s' % ex)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004753 return 1
qyearsley53f48a12016-09-01 10:45:13 -07004754 if options.json:
Edward Lemurbaaf6be2019-10-09 18:00:44 +00004755 write_json(options.json, jobs)
qyearsley53f48a12016-09-01 10:45:13 -07004756 else:
Quinten Yearsley777660f2020-03-04 23:37:06 +00004757 _print_tryjobs(options, jobs)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004758 return 0
4759
4760
maruel@chromium.org0633fb42013-08-16 20:06:14 +00004761@subcommand.usage('[new upstream branch]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004762@metrics.collector.collect_metrics('git cl upstream')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004763def CMDupstream(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004764 """Prints or sets the name of the upstream branch, if any."""
dpranke@chromium.org97ae58e2011-03-18 00:29:20 +00004765 _, args = parser.parse_args(args)
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00004766 if len(args) > 1:
maruel@chromium.org27bb3872011-05-30 20:33:19 +00004767 parser.error('Unrecognized args: %s' % ' '.join(args))
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00004768
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004769 cl = Changelist()
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00004770 if args:
4771 # One arg means set upstream branch.
bauerb@chromium.orgc9cf90a2014-04-28 20:32:31 +00004772 branch = cl.GetBranch()
stip7a3dd352016-09-22 17:32:28 -07004773 RunGit(['branch', '--set-upstream-to', args[0], branch])
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00004774 cl = Changelist()
vapiera7fbd5a2016-06-16 09:17:49 -07004775 print('Upstream branch set to %s' % (cl.GetUpstreamBranch(),))
bauerb@chromium.orgc9cf90a2014-04-28 20:32:31 +00004776
4777 # Clear configured merge-base, if there is one.
4778 git_common.remove_merge_base(branch)
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00004779 else:
vapiera7fbd5a2016-06-16 09:17:49 -07004780 print(cl.GetUpstreamBranch())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004781 return 0
4782
4783
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004784@metrics.collector.collect_metrics('git cl web')
thestig@chromium.org00858c82013-12-02 23:08:03 +00004785def CMDweb(parser, args):
4786 """Opens the current CL in the web browser."""
4787 _, args = parser.parse_args(args)
4788 if args:
4789 parser.error('Unrecognized args: %s' % ' '.join(args))
4790
4791 issue_url = Changelist().GetIssueURL()
4792 if not issue_url:
vapiera7fbd5a2016-06-16 09:17:49 -07004793 print('ERROR No issue to open', file=sys.stderr)
thestig@chromium.org00858c82013-12-02 23:08:03 +00004794 return 1
4795
Sergiy Byelozyorov2b718322018-10-24 17:43:31 +00004796 # Redirect I/O before invoking browser to hide its output. For example, this
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004797 # allows us to hide the "Created new window in existing browser session."
4798 # message from Chrome. Based on https://stackoverflow.com/a/2323563.
Sergiy Byelozyorov2b718322018-10-24 17:43:31 +00004799 saved_stdout = os.dup(1)
Sergiy Belozorov06684032019-03-06 16:53:08 +00004800 saved_stderr = os.dup(2)
Sergiy Byelozyorov2b718322018-10-24 17:43:31 +00004801 os.close(1)
Sergiy Belozorov06684032019-03-06 16:53:08 +00004802 os.close(2)
Sergiy Byelozyorov2b718322018-10-24 17:43:31 +00004803 os.open(os.devnull, os.O_RDWR)
4804 try:
4805 webbrowser.open(issue_url)
4806 finally:
4807 os.dup2(saved_stdout, 1)
Sergiy Belozorov06684032019-03-06 16:53:08 +00004808 os.dup2(saved_stderr, 2)
thestig@chromium.org00858c82013-12-02 23:08:03 +00004809 return 0
4810
4811
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004812@metrics.collector.collect_metrics('git cl set-commit')
maruel@chromium.org27bb3872011-05-30 20:33:19 +00004813def CMDset_commit(parser, args):
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +00004814 """Sets the commit bit to trigger the CQ."""
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00004815 parser.add_option('-d', '--dry-run', action='store_true',
4816 help='trigger in dry run mode')
Greg Gutermanbe5fccd2021-06-14 17:58:20 +00004817 parser.add_option(
4818 '-q',
4819 '--quick-run',
4820 action='store_true',
4821 help='trigger in quick run mode '
4822 '(https://source.chromium.org/chromium/chromium/src/+/main:docs/cq_qu'
4823 'ick_run.md) (chromium only).')
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00004824 parser.add_option('-c', '--clear', action='store_true',
4825 help='stop CQ run, if any')
Edward Lemur52969c92020-02-06 18:15:28 +00004826 parser.add_option(
4827 '-i', '--issue', type=int,
4828 help='Operate on this issue instead of the current branch\'s implicit '
4829 'issue.')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004830 options, args = parser.parse_args(args)
maruel@chromium.org27bb3872011-05-30 20:33:19 +00004831 if args:
4832 parser.error('Unrecognized args: %s' % ' '.join(args))
Greg Gutermanbe5fccd2021-06-14 17:58:20 +00004833 if [options.dry_run, options.quick_run, options.clear].count(True) > 1:
4834 parser.error('Only one of --dry-run, --quick-run, and --clear are allowed.')
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00004835
Edward Lemur934836a2019-09-09 20:16:54 +00004836 cl = Changelist(issue=options.issue)
Greg Gutermanbe5fccd2021-06-14 17:58:20 +00004837 if not cl.GetIssue():
4838 parser.error('Must upload the issue first.')
4839
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00004840 if options.clear:
tandriid9e5ce52016-07-13 02:32:59 -07004841 state = _CQState.NONE
Greg Gutermanbe5fccd2021-06-14 17:58:20 +00004842 elif options.quick_run:
4843 state = _CQState.QUICK_RUN
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00004844 elif options.dry_run:
4845 state = _CQState.DRY_RUN
4846 else:
4847 state = _CQState.COMMIT
tandrii9de9ec62016-07-13 03:01:59 -07004848 cl.SetCQState(state)
maruel@chromium.org27bb3872011-05-30 20:33:19 +00004849 return 0
4850
4851
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004852@metrics.collector.collect_metrics('git cl set-close')
groby@chromium.org411034a2013-02-26 15:12:01 +00004853def CMDset_close(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004854 """Closes the issue."""
Edward Lemur52969c92020-02-06 18:15:28 +00004855 parser.add_option(
4856 '-i', '--issue', type=int,
4857 help='Operate on this issue instead of the current branch\'s implicit '
4858 'issue.')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004859 options, args = parser.parse_args(args)
groby@chromium.org411034a2013-02-26 15:12:01 +00004860 if args:
4861 parser.error('Unrecognized args: %s' % ' '.join(args))
Edward Lemur934836a2019-09-09 20:16:54 +00004862 cl = Changelist(issue=options.issue)
groby@chromium.org411034a2013-02-26 15:12:01 +00004863 # Ensure there actually is an issue to close.
Aaron Gable7139a4e2017-09-05 17:53:09 -07004864 if not cl.GetIssue():
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004865 DieWithError('ERROR: No issue to close.')
groby@chromium.org411034a2013-02-26 15:12:01 +00004866 cl.CloseIssue()
4867 return 0
4868
4869
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004870@metrics.collector.collect_metrics('git cl diff')
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00004871def CMDdiff(parser, args):
wychen@chromium.org37b2ec02015-04-03 00:49:15 +00004872 """Shows differences between local tree and last upload."""
thomasanderson074beb22016-08-29 14:03:20 -07004873 parser.add_option(
4874 '--stat',
4875 action='store_true',
4876 dest='stat',
4877 help='Generate a diffstat')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004878 options, args = parser.parse_args(args)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004879 if args:
4880 parser.error('Unrecognized args: %s' % ' '.join(args))
wychen@chromium.org46309bf2015-04-03 21:04:49 +00004881
Edward Lemur934836a2019-09-09 20:16:54 +00004882 cl = Changelist()
sbc@chromium.org78dc9842013-11-25 18:43:44 +00004883 issue = cl.GetIssue()
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00004884 branch = cl.GetBranch()
sbc@chromium.org78dc9842013-11-25 18:43:44 +00004885 if not issue:
4886 DieWithError('No issue found for current branch (%s)' % branch)
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00004887
Aaron Gablea718c3e2017-08-28 17:47:28 -07004888 base = cl._GitGetBranchConfigValue('last-upload-hash')
4889 if not base:
4890 base = cl._GitGetBranchConfigValue('gerritsquashhash')
4891 if not base:
4892 detail = cl._GetChangeDetail(['CURRENT_REVISION', 'CURRENT_COMMIT'])
4893 revision_info = detail['revisions'][detail['current_revision']]
4894 fetch_info = revision_info['fetch']['http']
4895 RunGit(['fetch', fetch_info['url'], fetch_info['ref']])
4896 base = 'FETCH_HEAD'
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00004897
Aaron Gablea718c3e2017-08-28 17:47:28 -07004898 cmd = ['git', 'diff']
4899 if options.stat:
4900 cmd.append('--stat')
4901 cmd.append(base)
4902 subprocess2.check_call(cmd)
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00004903
4904 return 0
4905
4906
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004907@metrics.collector.collect_metrics('git cl owners')
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00004908def CMDowners(parser, args):
Dirk Prankebf980882017-09-02 15:08:00 -07004909 """Finds potential owners for reviewing."""
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00004910 parser.add_option(
Sidney San Martín8e6f58c2018-06-08 01:02:56 +00004911 '--ignore-current',
4912 action='store_true',
4913 help='Ignore the CL\'s current reviewers and start from scratch.')
4914 parser.add_option(
Sylvain Defresneb1f865d2019-02-12 12:38:22 +00004915 '--ignore-self',
4916 action='store_true',
4917 help='Do not consider CL\'s author as an owners.')
4918 parser.add_option(
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00004919 '--no-color',
4920 action='store_true',
4921 help='Use this option to disable color output')
Dirk Prankebf980882017-09-02 15:08:00 -07004922 parser.add_option(
4923 '--batch',
4924 action='store_true',
4925 help='Do not run interactively, just suggest some')
Yang Guo6e269a02019-06-26 11:17:02 +00004926 # TODO: Consider moving this to another command, since other
4927 # git-cl owners commands deal with owners for a given CL.
4928 parser.add_option(
4929 '--show-all',
4930 action='store_true',
4931 help='Show all owners for a particular file')
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00004932 options, args = parser.parse_args(args)
4933
Edward Lemur934836a2019-09-09 20:16:54 +00004934 cl = Changelist()
Edward Lesmes50da7702020-03-30 19:23:43 +00004935 author = cl.GetAuthor()
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00004936
Yang Guo6e269a02019-06-26 11:17:02 +00004937 if options.show_all:
Bruce Dawson97ed44a2020-05-06 17:04:03 +00004938 if len(args) == 0:
4939 print('No files specified for --show-all. Nothing to do.')
4940 return 0
Edward Lesmese1576912021-02-16 21:53:34 +00004941 owners_by_path = cl.owners_client.BatchListOwners(args)
Edward Lesmes0e4e5ae2021-01-08 18:28:46 +00004942 for path in args:
4943 print('Owners for %s:' % path)
4944 print('\n'.join(
4945 ' - %s' % owner
4946 for owner in owners_by_path.get(path, ['No owners found'])))
Yang Guo6e269a02019-06-26 11:17:02 +00004947 return 0
4948
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00004949 if args:
4950 if len(args) > 1:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004951 parser.error('Unknown args.')
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00004952 base_branch = args[0]
4953 else:
4954 # Default to diffing against the common ancestor of the upstream branch.
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00004955 base_branch = cl.GetCommonAncestorWithUpstream()
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00004956
Edward Lemur2c62b332020-03-12 22:12:33 +00004957 affected_files = cl.GetAffectedFiles(base_branch)
Dirk Prankebf980882017-09-02 15:08:00 -07004958
4959 if options.batch:
Edward Lesmese1576912021-02-16 21:53:34 +00004960 owners = cl.owners_client.SuggestOwners(affected_files, exclude=[author])
4961 print('\n'.join(owners))
Dirk Prankebf980882017-09-02 15:08:00 -07004962 return 0
4963
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00004964 return owners_finder.OwnersFinder(
Dirk Prankebf980882017-09-02 15:08:00 -07004965 affected_files,
Edward Lemur707d70b2018-02-07 00:50:14 +01004966 author,
Sidney San Martín8e6f58c2018-06-08 01:02:56 +00004967 [] if options.ignore_current else cl.GetReviewers(),
Edward Lesmes5cd75472021-02-19 00:34:25 +00004968 cl.owners_client,
Jochen Eisingerd0573ec2017-04-13 10:55:06 +02004969 disable_color=options.no_color,
Sylvain Defresneb1f865d2019-02-12 12:38:22 +00004970 ignore_author=options.ignore_self).run()
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00004971
4972
Aiden Bennerc08566e2018-10-03 17:52:42 +00004973def BuildGitDiffCmd(diff_type, upstream_commit, args, allow_prefix=False):
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00004974 """Generates a diff command."""
4975 # Generate diff for the current branch's changes.
Aiden Bennerc08566e2018-10-03 17:52:42 +00004976 diff_cmd = ['-c', 'core.quotePath=false', 'diff', '--no-ext-diff']
4977
Aiden Benner6c18a1a2018-11-23 20:18:23 +00004978 if allow_prefix:
4979 # explicitly setting --src-prefix and --dst-prefix is necessary in the
4980 # case that diff.noprefix is set in the user's git config.
4981 diff_cmd += ['--src-prefix=a/', '--dst-prefix=b/']
4982 else:
Aiden Bennerc08566e2018-10-03 17:52:42 +00004983 diff_cmd += ['--no-prefix']
4984
4985 diff_cmd += [diff_type, upstream_commit, '--']
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00004986
4987 if args:
4988 for arg in args:
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00004989 if os.path.isdir(arg) or os.path.isfile(arg):
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00004990 diff_cmd.append(arg)
4991 else:
4992 DieWithError('Argument "%s" is not a file or a directory' % arg)
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00004993
4994 return diff_cmd
4995
Andrii Shyshkalov18975322017-01-25 16:44:13 +01004996
Jamie Madill5e96ad12020-01-13 16:08:35 +00004997def _RunClangFormatDiff(opts, clang_diff_files, top_dir, upstream_commit):
4998 """Runs clang-format-diff and sets a return value if necessary."""
4999
5000 if not clang_diff_files:
5001 return 0
5002
5003 # Set to 2 to signal to CheckPatchFormatted() that this patch isn't
5004 # formatted. This is used to block during the presubmit.
5005 return_value = 0
5006
5007 # Locate the clang-format binary in the checkout
5008 try:
5009 clang_format_tool = clang_format.FindClangFormatToolInChromiumTree()
5010 except clang_format.NotFoundError as e:
5011 DieWithError(e)
5012
5013 if opts.full or settings.GetFormatFullByDefault():
5014 cmd = [clang_format_tool]
5015 if not opts.dry_run and not opts.diff:
5016 cmd.append('-i')
5017 if opts.dry_run:
5018 for diff_file in clang_diff_files:
5019 with open(diff_file, 'r') as myfile:
5020 code = myfile.read().replace('\r\n', '\n')
5021 stdout = RunCommand(cmd + [diff_file], cwd=top_dir)
5022 stdout = stdout.replace('\r\n', '\n')
5023 if opts.diff:
5024 sys.stdout.write(stdout)
5025 if code != stdout:
5026 return_value = 2
5027 else:
5028 stdout = RunCommand(cmd + clang_diff_files, cwd=top_dir)
5029 if opts.diff:
5030 sys.stdout.write(stdout)
5031 else:
Jamie Madill5e96ad12020-01-13 16:08:35 +00005032 try:
5033 script = clang_format.FindClangFormatScriptInChromiumTree(
5034 'clang-format-diff.py')
5035 except clang_format.NotFoundError as e:
5036 DieWithError(e)
5037
Edward Lesmes89624cd2020-04-06 17:51:56 +00005038 cmd = ['vpython', script, '-p0']
Jamie Madill5e96ad12020-01-13 16:08:35 +00005039 if not opts.dry_run and not opts.diff:
5040 cmd.append('-i')
5041
5042 diff_cmd = BuildGitDiffCmd('-U0', upstream_commit, clang_diff_files)
Edward Lemur1a83da12020-03-04 21:18:36 +00005043 diff_output = RunGit(diff_cmd).encode('utf-8')
Jamie Madill5e96ad12020-01-13 16:08:35 +00005044
Edward Lesmes89624cd2020-04-06 17:51:56 +00005045 env = os.environ.copy()
5046 env['PATH'] = (
5047 str(os.path.dirname(clang_format_tool)) + os.pathsep + env['PATH'])
5048 stdout = RunCommand(
5049 cmd, stdin=diff_output, cwd=top_dir, env=env,
Ilya Sherman7aed4bb2020-05-20 22:34:14 +00005050 shell=sys.platform.startswith('win32'))
Jamie Madill5e96ad12020-01-13 16:08:35 +00005051 if opts.diff:
5052 sys.stdout.write(stdout)
5053 if opts.dry_run and len(stdout) > 0:
5054 return_value = 2
5055
5056 return return_value
5057
5058
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005059def MatchingFileType(file_name, extensions):
Quinten Yearsleyd242ed72019-07-25 17:17:55 +00005060 """Returns True if the file name ends with one of the given extensions."""
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005061 return bool([ext for ext in extensions if file_name.lower().endswith(ext)])
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005062
Andrii Shyshkalov18975322017-01-25 16:44:13 +01005063
enne@chromium.org555cfe42014-01-29 18:21:39 +00005064@subcommand.usage('[files or directories to diff]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005065@metrics.collector.collect_metrics('git cl format')
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005066def CMDformat(parser, args):
sbc@chromium.org9d0644d2015-06-05 23:16:54 +00005067 """Runs auto-formatting tools (clang-format etc.) on the diff."""
Christopher Lamc5ba6922017-01-24 11:19:14 +11005068 CLANG_EXTS = ['.cc', '.cpp', '.h', '.m', '.mm', '.proto', '.java']
kylechar58edce22016-06-17 06:07:51 -07005069 GN_EXTS = ['.gn', '.gni', '.typemap']
enne@chromium.org3b7e15c2014-01-21 17:44:47 +00005070 parser.add_option('--full', action='store_true',
5071 help='Reformat the full content of all touched files')
5072 parser.add_option('--dry-run', action='store_true',
5073 help='Don\'t modify any file on disk.')
Aiden Benner99b0ccb2018-11-20 19:53:31 +00005074 parser.add_option(
Garrett Beatyed0cc5f2020-01-06 17:26:13 +00005075 '--no-clang-format',
5076 dest='clang_format',
5077 action='store_false',
5078 default=True,
5079 help='Disables formatting of various file types using clang-format.')
5080 parser.add_option(
Aiden Benner99b0ccb2018-11-20 19:53:31 +00005081 '--python',
5082 action='store_true',
5083 default=None,
5084 help='Enables python formatting on all python files.')
5085 parser.add_option(
5086 '--no-python',
5087 action='store_true',
Garrett Beaty91a6f332020-01-06 16:57:24 +00005088 default=False,
Aiden Benner99b0ccb2018-11-20 19:53:31 +00005089 help='Disables python formatting on all python files. '
Garrett Beaty91a6f332020-01-06 16:57:24 +00005090 'If neither --python or --no-python are set, python files that have a '
5091 '.style.yapf file in an ancestor directory will be formatted. '
5092 'It is an error to set both.')
Garrett Beatyed0cc5f2020-01-06 17:26:13 +00005093 parser.add_option(
5094 '--js',
5095 action='store_true',
5096 help='Format javascript code with clang-format. '
5097 'Has no effect if --no-clang-format is set.')
wittman@chromium.org04d5a222014-03-07 18:30:42 +00005098 parser.add_option('--diff', action='store_true',
5099 help='Print diff to stdout rather than modifying files.')
Ilya Shermane081cbe2017-08-15 17:51:04 -07005100 parser.add_option('--presubmit', action='store_true',
5101 help='Used when running the script from a presubmit.')
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005102 opts, args = parser.parse_args(args)
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005103
Garrett Beaty91a6f332020-01-06 16:57:24 +00005104 if opts.python is not None and opts.no_python:
5105 raise parser.error('Cannot set both --python and --no-python')
5106 if opts.no_python:
5107 opts.python = False
5108
Daniel Chengc55eecf2016-12-30 03:11:02 -08005109 # Normalize any remaining args against the current path, so paths relative to
5110 # the current directory are still resolved as expected.
5111 args = [os.path.join(os.getcwd(), arg) for arg in args]
5112
enne@chromium.orgff7a1fb2013-12-10 19:21:41 +00005113 # git diff generates paths against the root of the repository. Change
5114 # to that directory so clang-format can find files even within subdirs.
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00005115 rel_base_path = settings.GetRelativeRoot()
enne@chromium.orgff7a1fb2013-12-10 19:21:41 +00005116 if rel_base_path:
5117 os.chdir(rel_base_path)
5118
digit@chromium.org29e47272013-05-17 17:01:46 +00005119 # Grab the merge-base commit, i.e. the upstream commit of the current
5120 # branch when it was created or the last time it was rebased. This is
5121 # to cover the case where the user may have called "git fetch origin",
5122 # moving the origin branch to a newer commit, but hasn't rebased yet.
5123 upstream_commit = None
5124 cl = Changelist()
5125 upstream_branch = cl.GetUpstreamBranch()
5126 if upstream_branch:
5127 upstream_commit = RunGit(['merge-base', 'HEAD', upstream_branch])
5128 upstream_commit = upstream_commit.strip()
5129
5130 if not upstream_commit:
5131 DieWithError('Could not find base commit for this branch. '
5132 'Are you in detached state?')
5133
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005134 changed_files_cmd = BuildGitDiffCmd('--name-only', upstream_commit, args)
5135 diff_output = RunGit(changed_files_cmd)
5136 diff_files = diff_output.splitlines()
jkarlin@chromium.orgad21b922016-01-28 17:48:42 +00005137 # Filter out files deleted by this CL
5138 diff_files = [x for x in diff_files if os.path.isfile(x)]
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005139
Andreas Haas417d89c2020-02-06 10:24:27 +00005140 if opts.js:
Deepanjan Roy605dd312018-07-02 17:48:54 +00005141 CLANG_EXTS.extend(['.js', '.ts'])
Christopher Lamc5ba6922017-01-24 11:19:14 +11005142
Garrett Beatyed0cc5f2020-01-06 17:26:13 +00005143 clang_diff_files = []
5144 if opts.clang_format:
5145 clang_diff_files = [
5146 x for x in diff_files if MatchingFileType(x, CLANG_EXTS)
5147 ]
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005148 python_diff_files = [x for x in diff_files if MatchingFileType(x, ['.py'])]
kylechar@chromium.org8b61f112016-02-05 13:28:58 +00005149 gn_diff_files = [x for x in diff_files if MatchingFileType(x, GN_EXTS)]
digit@chromium.org29e47272013-05-17 17:01:46 +00005150
Edward Lesmes50da7702020-03-30 19:23:43 +00005151 top_dir = settings.GetRoot()
nick@chromium.org3ac1c4e2014-01-16 02:44:42 +00005152
Jamie Madill5e96ad12020-01-13 16:08:35 +00005153 return_value = _RunClangFormatDiff(opts, clang_diff_files, top_dir,
5154 upstream_commit)
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005155
sbc@chromium.org9d0644d2015-06-05 23:16:54 +00005156 # Similar code to above, but using yapf on .py files rather than clang-format
5157 # on C/C++ files
Aiden Benner99b0ccb2018-11-20 19:53:31 +00005158 py_explicitly_disabled = opts.python is not None and not opts.python
5159 if python_diff_files and not py_explicitly_disabled:
Aiden Bennere47ac152018-11-20 16:44:03 +00005160 depot_tools_path = os.path.dirname(os.path.abspath(__file__))
5161 yapf_tool = os.path.join(depot_tools_path, 'yapf')
sbc@chromium.org9d0644d2015-06-05 23:16:54 +00005162
Aiden Bennerc08566e2018-10-03 17:52:42 +00005163 # Used for caching.
5164 yapf_configs = {}
5165 for f in python_diff_files:
5166 # Find the yapf style config for the current file, defaults to depot
5167 # tools default.
Aiden Benner99b0ccb2018-11-20 19:53:31 +00005168 _FindYapfConfigFile(f, yapf_configs, top_dir)
5169
5170 # Turn on python formatting by default if a yapf config is specified.
5171 # This breaks in the case of this repo though since the specified
5172 # style file is also the global default.
5173 if opts.python is None:
5174 filtered_py_files = []
5175 for f in python_diff_files:
5176 if _FindYapfConfigFile(f, yapf_configs, top_dir) is not None:
5177 filtered_py_files.append(f)
5178 else:
5179 filtered_py_files = python_diff_files
5180
5181 # Note: yapf still seems to fix indentation of the entire file
5182 # even if line ranges are specified.
5183 # See https://github.com/google/yapf/issues/499
5184 if not opts.full and filtered_py_files:
5185 py_line_diffs = _ComputeDiffLineRanges(filtered_py_files, upstream_commit)
5186
Brian Sheedyb4307d52019-12-02 19:18:17 +00005187 yapfignore_patterns = _GetYapfIgnorePatterns(top_dir)
5188 filtered_py_files = _FilterYapfIgnoredFiles(filtered_py_files,
5189 yapfignore_patterns)
Brian Sheedy59b06a82019-10-14 17:03:29 +00005190
Aiden Benner99b0ccb2018-11-20 19:53:31 +00005191 for f in filtered_py_files:
Andrew Grievefa40bfa2020-01-07 02:32:57 +00005192 yapf_style = _FindYapfConfigFile(f, yapf_configs, top_dir)
5193 # Default to pep8 if not .style.yapf is found.
5194 if not yapf_style:
5195 yapf_style = 'pep8'
Aiden Bennerc08566e2018-10-03 17:52:42 +00005196
Peter Wend9399922020-06-17 17:33:49 +00005197 with open(f, 'r') as py_f:
5198 if 'python3' in py_f.readline():
5199 vpython_script = 'vpython3'
5200 else:
5201 vpython_script = 'vpython'
5202
5203 cmd = [vpython_script, yapf_tool, '--style', yapf_style, f]
Aiden Bennerc08566e2018-10-03 17:52:42 +00005204
5205 has_formattable_lines = False
5206 if not opts.full:
5207 # Only run yapf over changed line ranges.
5208 for diff_start, diff_len in py_line_diffs[f]:
5209 diff_end = diff_start + diff_len - 1
5210 # Yapf errors out if diff_end < diff_start but this
5211 # is a valid line range diff for a removal.
5212 if diff_end >= diff_start:
5213 has_formattable_lines = True
5214 cmd += ['-l', '{}-{}'.format(diff_start, diff_end)]
5215 # If all line diffs were removals we have nothing to format.
5216 if not has_formattable_lines:
5217 continue
5218
5219 if opts.diff or opts.dry_run:
5220 cmd += ['--diff']
5221 # Will return non-zero exit code if non-empty diff.
Edward Lesmesb7db1832020-06-22 20:22:27 +00005222 stdout = RunCommand(cmd,
5223 error_ok=True,
5224 cwd=top_dir,
5225 shell=sys.platform.startswith('win32'))
Aiden Bennerc08566e2018-10-03 17:52:42 +00005226 if opts.diff:
5227 sys.stdout.write(stdout)
5228 elif len(stdout) > 0:
5229 return_value = 2
5230 else:
5231 cmd += ['-i']
Edward Lesmesb7db1832020-06-22 20:22:27 +00005232 RunCommand(cmd, cwd=top_dir, shell=sys.platform.startswith('win32'))
sbc@chromium.org9d0644d2015-06-05 23:16:54 +00005233
kylechar@chromium.org8b61f112016-02-05 13:28:58 +00005234 # Format GN build files. Always run on full build files for canonical form.
5235 if gn_diff_files:
Andrii Shyshkalov18975322017-01-25 16:44:13 +01005236 cmd = ['gn', 'format']
brettw4b8ed592016-08-05 16:19:12 -07005237 if opts.dry_run or opts.diff:
5238 cmd.append('--dry-run')
kylechar@chromium.org8b61f112016-02-05 13:28:58 +00005239 for gn_diff_file in gn_diff_files:
brettw4b8ed592016-08-05 16:19:12 -07005240 gn_ret = subprocess2.call(cmd + [gn_diff_file],
Ilya Sherman7aed4bb2020-05-20 22:34:14 +00005241 shell=sys.platform.startswith('win'),
brettw4b8ed592016-08-05 16:19:12 -07005242 cwd=top_dir)
5243 if opts.dry_run and gn_ret == 2:
5244 return_value = 2 # Not formatted.
5245 elif opts.diff and gn_ret == 2:
5246 # TODO this should compute and print the actual diff.
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005247 print('This change has GN build file diff for ' + gn_diff_file)
brettw4b8ed592016-08-05 16:19:12 -07005248 elif gn_ret != 0:
5249 # For non-dry run cases (and non-2 return values for dry-run), a
5250 # nonzero error code indicates a failure, probably because the file
5251 # doesn't parse.
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005252 DieWithError('gn format failed on ' + gn_diff_file +
5253 '\nTry running `gn format` on this file manually.')
kylechar@chromium.org8b61f112016-02-05 13:28:58 +00005254
Ilya Shermane081cbe2017-08-15 17:51:04 -07005255 # Skip the metrics formatting from the global presubmit hook. These files have
5256 # a separate presubmit hook that issues an error if the files need formatting,
5257 # whereas the top-level presubmit script merely issues a warning. Formatting
5258 # these files is somewhat slow, so it's important not to duplicate the work.
5259 if not opts.presubmit:
Wenhan (Han) Zhang3bd3c992020-08-14 16:27:39 +00005260 for diff_xml in GetDiffXMLs(diff_files):
5261 xml_dir = GetMetricsDir(diff_xml)
5262 if not xml_dir:
5263 continue
5264
Ilya Shermane081cbe2017-08-15 17:51:04 -07005265 tool_dir = os.path.join(top_dir, xml_dir)
Ilya Sherman7aed4bb2020-05-20 22:34:14 +00005266 pretty_print_tool = os.path.join(tool_dir, 'pretty_print.py')
5267 cmd = ['vpython', pretty_print_tool, '--non-interactive']
Wenhan (Han) Zhang3bd3c992020-08-14 16:27:39 +00005268
5269 # If the XML file is histograms.xml or enums.xml, add the xml path to the
5270 # command as histograms/pretty_print.py now needs a relative path argument
5271 # after splitting the histograms into multiple directories.
5272 # For example, in tools/metrics/ukm, pretty-print could be run using:
5273 # $ python pretty_print.py
5274 # But in tools/metrics/histogrmas, pretty-print should be run with an
5275 # additional relative path argument, like:
5276 # $ python pretty_print.py histograms_xml/UMA/histograms.xml
5277 # $ python pretty_print.py enums.xml
5278
5279 # TODO (crbug/1116488): Remove this check after ensuring that the updated
5280 # version of histograms/pretty_print.py is released.
5281 filepath_required = os.path.exists(
5282 os.path.join(tool_dir, 'validate_prefix.py'))
5283
Weilun Shib92c4b72020-08-27 17:45:11 +00005284 if (diff_xml.endswith('histograms.xml') or diff_xml.endswith('enums.xml')
5285 or diff_xml.endswith('histogram_suffixes_list.xml')
5286 ) and filepath_required:
Wenhan (Han) Zhang3bd3c992020-08-14 16:27:39 +00005287 cmd.append(diff_xml)
5288
Ilya Shermane081cbe2017-08-15 17:51:04 -07005289 if opts.dry_run or opts.diff:
5290 cmd.append('--diff')
Wenhan (Han) Zhang3bd3c992020-08-14 16:27:39 +00005291
Ilya Sherman7aed4bb2020-05-20 22:34:14 +00005292 # TODO(isherman): Once this file runs only on Python 3.3+, drop the
5293 # `shell` param and instead replace `'vpython'` with
5294 # `shutil.which('frob')` above: https://stackoverflow.com/a/32799942
Wenhan (Han) Zhang3bd3c992020-08-14 16:27:39 +00005295 stdout = RunCommand(cmd,
5296 cwd=top_dir,
Ilya Sherman7aed4bb2020-05-20 22:34:14 +00005297 shell=sys.platform.startswith('win32'))
Ilya Shermane081cbe2017-08-15 17:51:04 -07005298 if opts.diff:
5299 sys.stdout.write(stdout)
5300 if opts.dry_run and stdout:
5301 return_value = 2 # Not formatted.
Alexei Svitkinef3cac412017-02-06 11:08:50 -05005302
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005303 return return_value
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005304
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005305
Wenhan (Han) Zhang3bd3c992020-08-14 16:27:39 +00005306def GetDiffXMLs(diff_files):
5307 return [
5308 os.path.normpath(x) for x in diff_files if MatchingFileType(x, ['.xml'])
5309 ]
5310
5311
5312def GetMetricsDir(diff_xml):
Steven Holte2e664bf2017-04-21 13:10:47 -07005313 metrics_xml_dirs = [
5314 os.path.join('tools', 'metrics', 'actions'),
5315 os.path.join('tools', 'metrics', 'histograms'),
5316 os.path.join('tools', 'metrics', 'rappor'),
Ilya Shermanb67e60c2020-05-20 22:27:03 +00005317 os.path.join('tools', 'metrics', 'structured'),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005318 os.path.join('tools', 'metrics', 'ukm'),
5319 ]
Steven Holte2e664bf2017-04-21 13:10:47 -07005320 for xml_dir in metrics_xml_dirs:
Wenhan (Han) Zhang3bd3c992020-08-14 16:27:39 +00005321 if diff_xml.startswith(xml_dir):
5322 return xml_dir
5323 return None
Steven Holte2e664bf2017-04-21 13:10:47 -07005324
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005325
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005326@subcommand.usage('<codereview url or issue id>')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005327@metrics.collector.collect_metrics('git cl checkout')
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005328def CMDcheckout(parser, args):
Edward Lemurf38bc172019-09-03 21:02:13 +00005329 """Checks out a branch associated with a given Gerrit issue."""
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005330 _, args = parser.parse_args(args)
5331
5332 if len(args) != 1:
5333 parser.print_help()
5334 return 1
5335
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00005336 issue_arg = ParseIssueNumberArgument(args[0])
tandrii@chromium.orgde6c9a12016-04-11 15:33:53 +00005337 if not issue_arg.valid:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00005338 parser.error('Invalid issue ID or URL.')
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02005339
tandrii@chromium.orgabd27e52016-04-11 15:43:32 +00005340 target_issue = str(issue_arg.issue)
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005341
Edward Lemur52969c92020-02-06 18:15:28 +00005342 output = RunGit(['config', '--local', '--get-regexp',
Edward Lesmes50da7702020-03-30 19:23:43 +00005343 r'branch\..*\.' + ISSUE_CONFIG_KEY],
Edward Lemur52969c92020-02-06 18:15:28 +00005344 error_ok=True)
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005345
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00005346 branches = []
Edward Lemur52969c92020-02-06 18:15:28 +00005347 for key, issue in [x.split() for x in output.splitlines()]:
5348 if issue == target_issue:
Edward Lesmes50da7702020-03-30 19:23:43 +00005349 branches.append(re.sub(r'branch\.(.*)\.' + ISSUE_CONFIG_KEY, r'\1', key))
Edward Lemur52969c92020-02-06 18:15:28 +00005350
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005351 if len(branches) == 0:
vapiera7fbd5a2016-06-16 09:17:49 -07005352 print('No branch found for issue %s.' % target_issue)
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005353 return 1
5354 if len(branches) == 1:
5355 RunGit(['checkout', branches[0]])
5356 else:
vapiera7fbd5a2016-06-16 09:17:49 -07005357 print('Multiple branches match issue %s:' % target_issue)
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005358 for i in range(len(branches)):
vapiera7fbd5a2016-06-16 09:17:49 -07005359 print('%d: %s' % (i, branches[i]))
Edward Lesmesae3586b2020-03-23 21:21:14 +00005360 which = gclient_utils.AskForData('Choose by index: ')
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005361 try:
5362 RunGit(['checkout', branches[int(which)]])
5363 except (IndexError, ValueError):
vapiera7fbd5a2016-06-16 09:17:49 -07005364 print('Invalid selection, not checking out any branch.')
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005365 return 1
5366
5367 return 0
5368
5369
maruel@chromium.org29404b52014-09-08 22:58:00 +00005370def CMDlol(parser, args):
5371 # This command is intentionally undocumented.
vapiera7fbd5a2016-06-16 09:17:49 -07005372 print(zlib.decompress(base64.b64decode(
thakis@chromium.org3421c992014-11-02 02:20:32 +00005373 'eNptkLEOwyAMRHe+wupCIqW57v0Vq84WqWtXyrcXnCBsmgMJ+/SSAxMZgRB6NzE'
5374 'E2ObgCKJooYdu4uAQVffUEoE1sRQLxAcqzd7uK2gmStrll1ucV3uZyaY5sXyDd9'
5375 'JAnN+lAXsOMJ90GANAi43mq5/VeeacylKVgi8o6F1SC63FxnagHfJUTfUYdCR/W'
Gavin Mak18f45d22020-12-04 21:45:10 +00005376 'Ofe+0dHL7PicpytKP750Fh1q2qnLVof4w8OZWNY')).decode('utf-8'))
maruel@chromium.org29404b52014-09-08 22:58:00 +00005377 return 0
5378
5379
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005380class OptionParser(optparse.OptionParser):
5381 """Creates the option parse and add --verbose support."""
Sigurd Schneider9abde8c2020-11-17 08:44:52 +00005382
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005383 def __init__(self, *args, **kwargs):
maruel@chromium.org0633fb42013-08-16 20:06:14 +00005384 optparse.OptionParser.__init__(
5385 self, *args, prog='git cl', version=__version__, **kwargs)
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005386 self.add_option(
5387 '-v', '--verbose', action='count', default=0,
5388 help='Use 2 times for more debugging info')
5389
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005390 def parse_args(self, args=None, _values=None):
Andrii Shyshkalov46f20cd2018-10-30 06:42:54 +00005391 try:
5392 return self._parse_args(args)
5393 finally:
5394 # Regardless of success or failure of args parsing, we want to report
5395 # metrics, but only after logging has been initialized (if parsing
5396 # succeeded).
5397 global settings
5398 settings = Settings()
5399
Edward Lesmes9c349062021-05-06 20:02:39 +00005400 if metrics.collector.config.should_collect_metrics:
Andrii Shyshkalov46f20cd2018-10-30 06:42:54 +00005401 # GetViewVCUrl ultimately calls logging method.
5402 project_url = settings.GetViewVCUrl().strip('/+')
5403 if project_url in metrics_utils.KNOWN_PROJECT_URLS:
5404 metrics.collector.add('project_urls', [project_url])
5405
5406 def _parse_args(self, args=None):
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005407 # Create an optparse.Values object that will store only the actual passed
5408 # options, without the defaults.
5409 actual_options = optparse.Values()
5410 _, args = optparse.OptionParser.parse_args(self, args, actual_options)
5411 # Create an optparse.Values object with the default options.
5412 options = optparse.Values(self.get_default_values().__dict__)
5413 # Update it with the options passed by the user.
5414 options._update_careful(actual_options.__dict__)
5415 # Store the options passed by the user in an _actual_options attribute.
5416 # We store only the keys, and not the values, since the values can contain
5417 # arbitrary information, which might be PII.
Edward Lemur79d4f992019-11-11 23:49:02 +00005418 metrics.collector.add('arguments', list(actual_options.__dict__.keys()))
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005419
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005420 levels = [logging.WARNING, logging.INFO, logging.DEBUG]
Andrii Shyshkalov5b04a572017-01-23 17:44:41 +01005421 logging.basicConfig(
5422 level=levels[min(options.verbose, len(levels) - 1)],
5423 format='[%(levelname).1s%(asctime)s %(process)d %(thread)d '
5424 '%(filename)s] %(message)s')
Edward Lemur83bd7f42018-10-10 00:14:21 +00005425
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005426 return options, args
5427
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005428
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005429def main(argv):
maruel@chromium.org82798cb2012-02-23 18:16:12 +00005430 if sys.hexversion < 0x02060000:
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005431 print('\nYour Python version %s is unsupported, please upgrade.\n' %
vapiera7fbd5a2016-06-16 09:17:49 -07005432 (sys.version.split(' ', 1)[0],), file=sys.stderr)
maruel@chromium.org82798cb2012-02-23 18:16:12 +00005433 return 2
maruel@chromium.org2e23ce32013-05-07 12:42:28 +00005434
maruel@chromium.org39c0b222013-08-17 16:57:01 +00005435 colorize_CMDstatus_doc()
maruel@chromium.org0633fb42013-08-16 20:06:14 +00005436 dispatcher = subcommand.CommandDispatcher(__name__)
5437 try:
5438 return dispatcher.execute(OptionParser(), argv)
Edward Lemur5b929a42019-10-21 17:57:39 +00005439 except auth.LoginRequiredError as e:
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +00005440 DieWithError(str(e))
Edward Lemur79d4f992019-11-11 23:49:02 +00005441 except urllib.error.HTTPError as e:
maruel@chromium.org0633fb42013-08-16 20:06:14 +00005442 if e.code != 500:
5443 raise
5444 DieWithError(
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005445 ('App Engine is misbehaving and returned HTTP %d, again. Keep faith '
Quinten Yearsleyc4202212019-07-22 23:34:40 +00005446 'and retry or visit go/isgaeup.\n%s') % (e.code, str(e)))
sbc@chromium.org013731e2015-02-26 18:28:43 +00005447 return 0
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005448
5449
5450if __name__ == '__main__':
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005451 # These affect sys.stdout, so do it outside of main() to simplify mocks in
5452 # the unit tests.
maruel@chromium.org6f09cd92011-04-01 16:38:12 +00005453 fix_encoding.fix_encoding()
iannucci@chromium.org596cd5c2016-04-04 21:34:39 +00005454 setup_color.init()
Edward Lemur6f812e12018-07-31 22:45:57 +00005455 with metrics.collector.print_notice_and_exit():
sbc@chromium.org013731e2015-02-26 18:28:43 +00005456 sys.exit(main(sys.argv[1:]))