blob: 7c0b703a33af20b9c698577dc21fac3f6e49610e [file] [log] [blame]
Edward Lesmes98eda3f2019-08-12 21:09:53 +00001#!/usr/bin/env python
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +02002# Copyright (c) 2013 The Chromium Authors. All rights reserved.
maruel@chromium.org725f1c32011-04-01 20:24:54 +00003# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00006# Copyright (C) 2008 Evan Martin <martine@danga.com>
7
Andrii Shyshkalov03da1502018-10-15 03:42:34 +00008"""A git-command for integrating reviews on Gerrit."""
maruel@chromium.org725f1c32011-04-01 20:24:54 +00009
vapiera7fbd5a2016-06-16 09:17:49 -070010from __future__ import print_function
11
tapted@chromium.org6a0b07c2013-07-10 01:29:19 +000012from distutils.version import LooseVersion
calamity@chromium.orgffde55c2015-03-12 00:44:17 +000013from multiprocessing.pool import ThreadPool
thakis@chromium.org3421c992014-11-02 02:20:32 +000014import base64
rmistry@google.com2dd99862015-06-22 12:22:18 +000015import collections
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +010016import datetime
sheyang@google.com6ebaf782015-05-12 19:17:54 +000017import httplib
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +010018import itertools
maruel@chromium.org4f6852c2012-04-20 20:39:20 +000019import json
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000020import logging
calamity@chromium.orgcf197482016-04-29 20:15:53 +000021import multiprocessing
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000022import optparse
23import os
24import re
Andrii Shyshkalov353637c2017-03-14 16:52:18 +010025import shutil
ukai@chromium.org78c4b982012-02-14 02:20:26 +000026import stat
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000027import sys
Aaron Gable9a03ae02017-11-03 11:31:07 -070028import tempfile
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000029import textwrap
Edward Lemurfec80c42018-11-01 23:14:14 +000030import time
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +000031import urllib
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000032import urllib2
maruel@chromium.org967c0a82013-06-17 22:52:24 +000033import urlparse
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +000034import uuid
thestig@chromium.org00858c82013-12-02 23:08:03 +000035import webbrowser
thakis@chromium.org3421c992014-11-02 02:20:32 +000036import zlib
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000037
maruel@chromium.org2e23ce32013-05-07 12:42:28 +000038from third_party import colorama
sheyang@google.com6ebaf782015-05-12 19:17:54 +000039from third_party import httplib2
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +000040import auth
nick@chromium.org3ac1c4e2014-01-16 02:44:42 +000041import clang_format
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +000042import dart_format
maruel@chromium.org6f09cd92011-04-01 16:38:12 +000043import fix_encoding
maruel@chromium.org0e0436a2011-10-25 13:32:41 +000044import gclient_utils
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +000045import gerrit_util
iannucci@chromium.org9e849272014-04-04 00:31:55 +000046import git_common
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +000047import git_footers
Edward Lemur5ba1e9c2018-07-23 18:19:02 +000048import metrics
Edward Lesmes93277a72018-10-18 22:04:26 +000049import metrics_utils
piman@chromium.org336f9122014-09-04 02:16:55 +000050import owners
iannucci@chromium.org9e849272014-04-04 00:31:55 +000051import owners_finder
maruel@chromium.org2a74d372011-03-29 19:05:50 +000052import presubmit_support
53import scm
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +000054import setup_color
Francois Dorayd42c6812017-05-30 15:10:20 -040055import split_cl
maruel@chromium.org0633fb42013-08-16 20:06:14 +000056import subcommand
maruel@chromium.org32f9f5e2011-09-14 13:41:47 +000057import subprocess2
maruel@chromium.org2a74d372011-03-29 19:05:50 +000058import watchlists
59
tandrii7400cf02016-06-21 08:48:07 -070060__version__ = '2.0'
maruel@chromium.org2a74d372011-03-29 19:05:50 +000061
Edward Lemur0f58ae42019-04-30 17:24:12 +000062# Traces for git push will be stored in a traces directory inside the
63# depot_tools checkout.
64DEPOT_TOOLS = os.path.dirname(os.path.abspath(__file__))
65TRACES_DIR = os.path.join(DEPOT_TOOLS, 'traces')
66
67# When collecting traces, Git hashes will be reduced to 6 characters to reduce
68# the size after compression.
69GIT_HASH_RE = re.compile(r'\b([a-f0-9]{6})[a-f0-9]{34}\b', flags=re.I)
70# Used to redact the cookies from the gitcookies file.
71GITCOOKIES_REDACT_RE = re.compile(r'1/.*')
72
Edward Lemurd4d1ba42019-09-20 21:46:37 +000073MAX_ATTEMPTS = 3
74
Edward Lemur1b52d872019-05-09 21:12:12 +000075# The maximum number of traces we will keep. Multiplied by 3 since we store
76# 3 files per trace.
77MAX_TRACES = 3 * 10
Edward Lemur5737f022019-05-17 01:24:00 +000078# Message to be displayed to the user to inform where to find the traces for a
79# git-cl upload execution.
Edward Lemur0f58ae42019-04-30 17:24:12 +000080TRACES_MESSAGE = (
Edward Lemur1b52d872019-05-09 21:12:12 +000081'\n'
Edward Lemur5737f022019-05-17 01:24:00 +000082'The traces of this git-cl execution have been recorded at:\n'
Edward Lemur1b52d872019-05-09 21:12:12 +000083' %(trace_name)s-traces.zip\n'
Edward Lemur5737f022019-05-17 01:24:00 +000084'Copies of your gitcookies file and git config have been recorded at:\n'
85' %(trace_name)s-git-info.zip\n')
Edward Lemur1b52d872019-05-09 21:12:12 +000086# Format of the message to be stored as part of the traces to give developers a
87# better context when they go through traces.
88TRACES_README_FORMAT = (
89'Date: %(now)s\n'
90'\n'
91'Change: https://%(gerrit_host)s/q/%(change_id)s\n'
92'Title: %(title)s\n'
93'\n'
94'%(description)s\n'
95'\n'
96'Execution time: %(execution_time)s\n'
97'Exit code: %(exit_code)s\n') + TRACES_MESSAGE
Edward Lemur0f58ae42019-04-30 17:24:12 +000098
tandrii9d2c7a32016-06-22 03:42:45 -070099COMMIT_BOT_EMAIL = 'commit-bot@chromium.org'
Aaron Gable1bc7bfe2016-12-19 10:08:14 -0800100POSTUPSTREAM_HOOK = '.git/hooks/post-cl-land'
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000101DESCRIPTION_BACKUP_FILE = '~/.git_cl_description_backup'
rmistry@google.comc68112d2015-03-03 12:48:06 +0000102REFS_THAT_ALIAS_TO_OTHER_REFS = {
103 'refs/remotes/origin/lkgr': 'refs/remotes/origin/master',
104 'refs/remotes/origin/lkcr': 'refs/remotes/origin/master',
105}
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000106
thestig@chromium.org44202a22014-03-11 19:22:18 +0000107# Valid extensions for files we want to lint.
108DEFAULT_LINT_REGEX = r"(.*\.cpp|.*\.cc|.*\.h)"
109DEFAULT_LINT_IGNORE_REGEX = r"$^"
110
Aiden Bennerc08566e2018-10-03 17:52:42 +0000111# File name for yapf style config files.
112YAPF_CONFIG_FILENAME = '.style.yapf'
113
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000114# Shortcut since it quickly becomes repetitive.
maruel@chromium.org2e23ce32013-05-07 12:42:28 +0000115Fore = colorama.Fore
maruel@chromium.org90541732011-04-01 17:54:18 +0000116
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000117# Initialized in main()
118settings = None
119
Andrii Shyshkalov768f1d82016-12-08 15:10:13 +0100120# Used by tests/git_cl_test.py to add extra logging.
121# Inside the weirdly failing test, add this:
122# >>> self.mock(git_cl, '_IS_BEING_TESTED', True)
Quinten Yearsley0c62da92017-05-31 13:39:42 -0700123# And scroll up to see the stack trace printed.
Andrii Shyshkalov768f1d82016-12-08 15:10:13 +0100124_IS_BEING_TESTED = False
125
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000126
Christopher Lamf732cd52017-01-24 12:40:11 +1100127def DieWithError(message, change_desc=None):
128 if change_desc:
129 SaveDescriptionBackup(change_desc)
130
vapiera7fbd5a2016-06-16 09:17:49 -0700131 print(message, file=sys.stderr)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000132 sys.exit(1)
133
134
Christopher Lamf732cd52017-01-24 12:40:11 +1100135def SaveDescriptionBackup(change_desc):
136 backup_path = os.path.expanduser(DESCRIPTION_BACKUP_FILE)
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000137 print('\nsaving CL description to %s\n' % backup_path)
Christopher Lamf732cd52017-01-24 12:40:11 +1100138 backup_file = open(backup_path, 'w')
139 backup_file.write(change_desc.description)
140 backup_file.close()
141
142
thestig@chromium.org8b0553c2014-02-11 00:33:37 +0000143def GetNoGitPagerEnv():
144 env = os.environ.copy()
145 # 'cat' is a magical git string that disables pagers on all platforms.
146 env['GIT_PAGER'] = 'cat'
147 return env
148
vadimsh@chromium.org566a02a2014-08-22 01:34:13 +0000149
bsep@chromium.org627d9002016-04-29 00:00:52 +0000150def RunCommand(args, error_ok=False, error_message=None, shell=False, **kwargs):
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000151 try:
bsep@chromium.org627d9002016-04-29 00:00:52 +0000152 return subprocess2.check_output(args, shell=shell, **kwargs)
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000153 except subprocess2.CalledProcessError as e:
154 logging.debug('Failed running %s', args)
maruel@chromium.org32f9f5e2011-09-14 13:41:47 +0000155 if not error_ok:
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000156 DieWithError(
maruel@chromium.org32f9f5e2011-09-14 13:41:47 +0000157 'Command "%s" failed.\n%s' % (
158 ' '.join(args), error_message or e.stdout or ''))
159 return e.stdout
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000160
161
162def RunGit(args, **kwargs):
maruel@chromium.org32f9f5e2011-09-14 13:41:47 +0000163 """Returns stdout."""
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000164 return RunCommand(['git'] + args, **kwargs)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000165
166
enne@chromium.org3b7e15c2014-01-21 17:44:47 +0000167def RunGitWithCode(args, suppress_stderr=False):
maruel@chromium.org32f9f5e2011-09-14 13:41:47 +0000168 """Returns return code and stdout."""
tandrii5d48c322016-08-18 16:19:37 -0700169 if suppress_stderr:
170 stderr = subprocess2.VOID
171 else:
172 stderr = sys.stderr
szager@chromium.org9bb85e22012-06-13 20:28:23 +0000173 try:
tandrii5d48c322016-08-18 16:19:37 -0700174 (out, _), code = subprocess2.communicate(['git'] + args,
175 env=GetNoGitPagerEnv(),
176 stdout=subprocess2.PIPE,
177 stderr=stderr)
178 return code, out
179 except subprocess2.CalledProcessError as e:
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +0900180 logging.debug('Failed running %s', ['git'] + args)
tandrii5d48c322016-08-18 16:19:37 -0700181 return e.returncode, e.stdout
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000182
183
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000184def RunGitSilent(args):
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +0000185 """Returns stdout, suppresses stderr and ignores the return code."""
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000186 return RunGitWithCode(args, suppress_stderr=True)[1]
187
188
tapted@chromium.org6a0b07c2013-07-10 01:29:19 +0000189def IsGitVersionAtLeast(min_version):
ilevy@chromium.orgcc56ee42013-07-10 22:16:29 +0000190 prefix = 'git version '
tapted@chromium.org6a0b07c2013-07-10 01:29:19 +0000191 version = RunGit(['--version']).strip()
ilevy@chromium.orgcc56ee42013-07-10 22:16:29 +0000192 return (version.startswith(prefix) and
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000193 LooseVersion(version[len(prefix):]) >= LooseVersion(min_version))
tapted@chromium.org6a0b07c2013-07-10 01:29:19 +0000194
195
pgervais@chromium.org8ba38ff2015-06-11 21:41:25 +0000196def BranchExists(branch):
197 """Return True if specified branch exists."""
198 code, _ = RunGitWithCode(['rev-parse', '--verify', branch],
199 suppress_stderr=True)
200 return not code
201
202
tandrii2a16b952016-10-19 07:09:44 -0700203def time_sleep(seconds):
204 # Use this so that it can be mocked in tests without interfering with python
205 # system machinery.
tandrii2a16b952016-10-19 07:09:44 -0700206 return time.sleep(seconds)
207
208
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000209def time_time():
210 # Use this so that it can be mocked in tests without interfering with python
211 # system machinery.
212 return time.time()
213
214
Edward Lemur1b52d872019-05-09 21:12:12 +0000215def datetime_now():
216 # Use this so that it can be mocked in tests without interfering with python
217 # system machinery.
218 return datetime.datetime.now()
219
220
maruel@chromium.org90541732011-04-01 17:54:18 +0000221def ask_for_data(prompt):
222 try:
223 return raw_input(prompt)
224 except KeyboardInterrupt:
225 # Hide the exception.
226 sys.exit(1)
227
228
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100229def confirm_or_exit(prefix='', action='confirm'):
230 """Asks user to press enter to continue or press Ctrl+C to abort."""
231 if not prefix or prefix.endswith('\n'):
232 mid = 'Press'
Andrii Shyshkalov353637c2017-03-14 16:52:18 +0100233 elif prefix.endswith('.') or prefix.endswith('?'):
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100234 mid = ' Press'
235 elif prefix.endswith(' '):
236 mid = 'press'
237 else:
238 mid = ' press'
239 ask_for_data('%s%s Enter to %s, or Ctrl+C to abort' % (prefix, mid, action))
240
241
242def ask_for_explicit_yes(prompt):
Quinten Yearsleyd242ed72019-07-25 17:17:55 +0000243 """Returns whether user typed 'y' or 'yes' to confirm the given prompt."""
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100244 result = ask_for_data(prompt + ' [Yes/No]: ').lower()
245 while True:
246 if 'yes'.startswith(result):
247 return True
248 if 'no'.startswith(result):
249 return False
250 result = ask_for_data('Please, type yes or no: ').lower()
251
252
tandrii5d48c322016-08-18 16:19:37 -0700253def _git_branch_config_key(branch, key):
254 """Helper method to return Git config key for a branch."""
255 assert branch, 'branch name is required to set git config for it'
256 return 'branch.%s.%s' % (branch, key)
257
258
259def _git_get_branch_config_value(key, default=None, value_type=str,
260 branch=False):
261 """Returns git config value of given or current branch if any.
262
263 Returns default in all other cases.
264 """
265 assert value_type in (int, str, bool)
266 if branch is False: # Distinguishing default arg value from None.
267 branch = GetCurrentBranch()
268
rogerta@chromium.orgcaa16552013-03-18 20:45:05 +0000269 if not branch:
tandrii5d48c322016-08-18 16:19:37 -0700270 return default
rogerta@chromium.orgcaa16552013-03-18 20:45:05 +0000271
tandrii5d48c322016-08-18 16:19:37 -0700272 args = ['config']
tandrii33a46ff2016-08-23 05:53:40 -0700273 if value_type == bool:
tandrii5d48c322016-08-18 16:19:37 -0700274 args.append('--bool')
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000275 # `git config` also has --int, but apparently git config suffers from integer
tandrii33a46ff2016-08-23 05:53:40 -0700276 # overflows (http://crbug.com/640115), so don't use it.
tandrii5d48c322016-08-18 16:19:37 -0700277 args.append(_git_branch_config_key(branch, key))
278 code, out = RunGitWithCode(args)
279 if code == 0:
280 value = out.strip()
281 if value_type == int:
282 return int(value)
283 if value_type == bool:
284 return bool(value.lower() == 'true')
285 return value
iannucci@chromium.org79540052012-10-19 23:15:26 +0000286 return default
287
288
tandrii5d48c322016-08-18 16:19:37 -0700289def _git_set_branch_config_value(key, value, branch=None, **kwargs):
Quinten Yearsleyd242ed72019-07-25 17:17:55 +0000290 """Sets or unsets the git branch config value.
tandrii5d48c322016-08-18 16:19:37 -0700291
Quinten Yearsleyd242ed72019-07-25 17:17:55 +0000292 If value is None, the key will be unset, otherwise it will be set.
293 If no branch is given, the currently checked out branch is used.
tandrii5d48c322016-08-18 16:19:37 -0700294 """
295 if not branch:
296 branch = GetCurrentBranch()
297 assert branch, 'a branch name OR currently checked out branch is required'
298 args = ['config']
qyearsley12fa6ff2016-08-24 09:18:40 -0700299 # Check for boolean first, because bool is int, but int is not bool.
tandrii5d48c322016-08-18 16:19:37 -0700300 if value is None:
301 args.append('--unset')
302 elif isinstance(value, bool):
303 args.append('--bool')
304 value = str(value).lower()
tandrii5d48c322016-08-18 16:19:37 -0700305 else:
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000306 # `git config` also has --int, but apparently git config suffers from
307 # integer overflows (http://crbug.com/640115), so don't use it.
tandrii5d48c322016-08-18 16:19:37 -0700308 value = str(value)
309 args.append(_git_branch_config_key(branch, key))
310 if value is not None:
311 args.append(value)
312 RunGit(args, **kwargs)
313
314
machenbach@chromium.org45453142015-09-15 08:45:22 +0000315def _get_properties_from_options(options):
Quinten Yearsleya19d3532019-09-30 21:54:39 +0000316 prop_list = getattr(options, 'properties', [])
317 properties = dict(x.split('=', 1) for x in prop_list)
machenbach@chromium.org45453142015-09-15 08:45:22 +0000318 for key, val in properties.iteritems():
319 try:
320 properties[key] = json.loads(val)
321 except ValueError:
322 pass # If a value couldn't be evaluated, treat it as a string.
323 return properties
324
325
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000326# TODO(crbug.com/976104): Remove this function once git-cl try-results has
327# migrated to use buildbucket v2
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000328def _buildbucket_retry(operation_name, http, *args, **kwargs):
329 """Retries requests to buildbucket service and returns parsed json content."""
330 try_count = 0
331 while True:
332 response, content = http.request(*args, **kwargs)
333 try:
334 content_json = json.loads(content)
335 except ValueError:
336 content_json = None
337
338 # Buildbucket could return an error even if status==200.
339 if content_json and content_json.get('error'):
nodir@chromium.orgbaff4e12016-03-08 00:33:57 +0000340 error = content_json.get('error')
341 if error.get('code') == 403:
342 raise BuildbucketResponseException(
343 'Access denied: %s' % error.get('message', ''))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000344 msg = 'Error in response. Reason: %s. Message: %s.' % (
nodir@chromium.orgbaff4e12016-03-08 00:33:57 +0000345 error.get('reason', ''), error.get('message', ''))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000346 raise BuildbucketResponseException(msg)
347
348 if response.status == 200:
Nodir Turakulov23d75d22018-06-04 12:37:32 -0700349 if content_json is None:
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000350 raise BuildbucketResponseException(
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000351 'Buildbucket returned invalid JSON content: %s.\n'
Nodir Turakulov9ac59792018-06-04 12:34:14 -0700352 'Please file bugs at http://crbug.com, '
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000353 'component "Infra>Platform>Buildbucket".' %
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000354 content)
355 return content_json
356 if response.status < 500 or try_count >= 2:
357 raise httplib2.HttpLib2Error(content)
358
359 # status >= 500 means transient failures.
360 logging.debug('Transient errors when %s. Will retry.', operation_name)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000361 time_sleep(0.5 + (1.5 * try_count))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000362 try_count += 1
363 assert False, 'unreachable'
364
365
Edward Lemur4c707a22019-09-24 21:13:43 +0000366def _call_buildbucket(http, buildbucket_host, method, request):
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000367 """Calls a buildbucket v2 method and returns the parsed json response."""
368 headers = {
369 'Accept': 'application/json',
370 'Content-Type': 'application/json',
371 }
372 request = json.dumps(request)
373 url = 'https://%s/prpc/buildbucket.v2.Builds/%s' % (buildbucket_host, method)
374
375 logging.info('POST %s with %s' % (url, request))
376
377 attempts = 1
378 time_to_sleep = 1
379 while True:
380 response, content = http.request(url, 'POST', body=request, headers=headers)
381 if response.status == 200:
382 return json.loads(content[4:])
383 if attempts >= MAX_ATTEMPTS or 400 <= response.status < 500:
384 msg = '%s error when calling POST %s with %s: %s' % (
385 response.status, url, request, content)
386 raise BuildbucketResponseException(msg)
387 logging.debug(
388 '%s error when calling POST %s with %s. '
389 'Sleeping for %d seconds and retrying...' % (
390 response.status, url, request, time_to_sleep))
391 time.sleep(time_to_sleep)
392 time_to_sleep *= 2
393 attempts += 1
394
395 assert False, 'unreachable'
396
397
qyearsley1fdfcb62016-10-24 13:22:03 -0700398def _get_bucket_map(changelist, options, option_parser):
qyearsleydd49f942016-10-28 11:57:22 -0700399 """Returns a dict mapping bucket names to builders and tests,
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000400 for triggering tryjobs.
qyearsley1fdfcb62016-10-24 13:22:03 -0700401 """
qyearsleydd49f942016-10-28 11:57:22 -0700402 # If no bots are listed, we try to get a set of builders and tests based
403 # on GetPreferredTryMasters functions in PRESUBMIT.py files.
qyearsley1fdfcb62016-10-24 13:22:03 -0700404 if not options.bot:
405 change = changelist.GetChange(
406 changelist.GetCommonAncestorWithUpstream(), None)
qyearsley136b49f2016-10-31 09:02:26 -0700407 # Get try masters from PRESUBMIT.py files.
nodire4f0fe02016-11-04 16:23:30 -0700408 masters = presubmit_support.DoGetTryMasters(
qyearsley1fdfcb62016-10-24 13:22:03 -0700409 change=change,
410 changed_files=change.LocalPaths(),
411 repository_root=settings.GetRoot(),
412 default_presubmit=None,
413 project=None,
414 verbose=options.verbose,
415 output_stream=sys.stdout)
nodire4f0fe02016-11-04 16:23:30 -0700416 if masters is None:
417 return None
Edward Lemurc8b67ed2019-09-12 20:28:58 +0000418 return {m: b for m, b in masters.iteritems()}
qyearsley1fdfcb62016-10-24 13:22:03 -0700419
qyearsley1fdfcb62016-10-24 13:22:03 -0700420 if options.bucket:
421 return {options.bucket: {b: [] for b in options.bot}}
Andrii Shyshkalov75424372019-08-30 22:48:15 +0000422 option_parser.error(
423 'Please specify the bucket, e.g. "-B luci.chromium.try".')
qyearsley1fdfcb62016-10-24 13:22:03 -0700424
425
Edward Lemur6215c792019-10-03 21:59:05 +0000426def _parse_bucket(raw_bucket):
427 legacy = True
428 project = bucket = None
429 if '/' in raw_bucket:
430 legacy = False
431 project, bucket = raw_bucket.split('/', 1)
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000432 # Assume luci.<project>.<bucket>.
Edward Lemur6215c792019-10-03 21:59:05 +0000433 elif raw_bucket.startswith('luci.'):
434 project, bucket = raw_bucket[len('luci.'):].split('.', 1)
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000435 # Otherwise, assume prefix is also the project name.
Edward Lemur6215c792019-10-03 21:59:05 +0000436 elif '.' in raw_bucket:
437 project = raw_bucket.split('.')[0]
438 bucket = raw_bucket
439 # Legacy buckets.
440 if legacy:
441 print('WARNING Please use %s/%s to specify the bucket.' % (project, bucket))
442 return project, bucket
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000443
444
Andrii Shyshkalovf9648b52018-02-21 22:32:42 -0800445def _trigger_try_jobs(auth_config, changelist, buckets, options, patchset):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000446 """Sends a request to Buildbucket to trigger tryjobs for a changelist.
qyearsley1fdfcb62016-10-24 13:22:03 -0700447
448 Args:
Aaron Gablefb28d482018-04-02 13:08:06 -0700449 auth_config: AuthConfig for Buildbucket.
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000450 changelist: Changelist that the tryjobs are associated with.
qyearsley1fdfcb62016-10-24 13:22:03 -0700451 buckets: A nested dict mapping bucket names to builders to tests.
452 options: Command-line options.
453 """
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000454 print('Scheduling jobs on:')
455 for bucket, builders_and_tests in sorted(buckets.iteritems()):
456 print('Bucket:', bucket)
457 print('\n'.join(
458 ' %s: %s' % (builder, tests)
459 for builder, tests in sorted(builders_and_tests.iteritems())))
460 print('To see results here, run: git cl try-results')
461 print('To see results in browser, run: git cl web')
tandriide281ae2016-10-12 06:02:30 -0700462
Edward Lemurf0faf482019-09-25 20:40:17 +0000463 gerrit_changes = [changelist.GetGerritChange(patchset)]
Quinten Yearsleya19d3532019-09-30 21:54:39 +0000464 shared_properties = {'category': getattr(options, 'category', 'git_cl_try')}
Edward Lemurf0faf482019-09-25 20:40:17 +0000465 shared_properties.update(changelist.GetLegacyProperties(patchset))
Quinten Yearsleya19d3532019-09-30 21:54:39 +0000466 if getattr(options, 'clobber', False):
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000467 shared_properties['clobber'] = True
468 shared_properties.update(_get_properties_from_options(options) or {})
469
470 requests = []
471 for raw_bucket, builders_and_tests in sorted(buckets.iteritems()):
472 project, bucket = _parse_bucket(raw_bucket)
473 if not project or not bucket:
474 print('WARNING Could not parse bucket "%s". Skipping.' % raw_bucket)
475 continue
476
477 for builder, tests in sorted(builders_and_tests.iteritems()):
478 properties = shared_properties.copy()
479 if 'presubmit' in builder.lower():
480 properties['dry_run'] = 'true'
481 if tests:
482 properties['testfilter'] = tests
483
484 requests.append({
485 'scheduleBuild': {
486 'requestId': str(uuid.uuid4()),
487 'builder': {
Quinten Yearsleya19d3532019-09-30 21:54:39 +0000488 'project': getattr(options, 'project', None) or project,
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000489 'bucket': bucket,
490 'builder': builder,
491 },
492 'gerritChanges': gerrit_changes,
493 'properties': properties,
494 'tags': [
495 {'key': 'builder', 'value': builder},
496 {'key': 'user_agent', 'value': 'git_cl_try'},
497 ],
498 }
499 })
500
501 if not requests:
502 return
503
504 codereview_url = changelist.GetCodereviewServer()
Edward Lemur2c210a42019-09-16 23:58:35 +0000505 codereview_host = urlparse.urlparse(codereview_url).hostname
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000506
Edward Lemur2c210a42019-09-16 23:58:35 +0000507 authenticator = auth.get_authenticator_for_host(codereview_host, auth_config)
508 http = authenticator.authorize(httplib2.Http())
509 http.force_exception_to_status_code = True
510
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000511 batch_request = {'requests': requests}
512 batch_response = _call_buildbucket(
Edward Lemur4c707a22019-09-24 21:13:43 +0000513 http, options.buildbucket_host, 'Batch', batch_request)
Edward Lemur2c210a42019-09-16 23:58:35 +0000514
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000515 errors = [
516 ' ' + response['error']['message']
517 for response in batch_response.get('responses', [])
518 if 'error' in response
519 ]
520 if errors:
521 raise BuildbucketResponseException(
522 'Failed to schedule builds for some bots:\n%s' % '\n'.join(errors))
kjellander@chromium.org44424542015-06-02 18:35:29 +0000523
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000524
tandrii221ab252016-10-06 08:12:04 -0700525def fetch_try_jobs(auth_config, changelist, buildbucket_host,
526 patchset=None):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000527 """Fetches tryjobs from buildbucket.
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000528
Quinten Yearsley983111f2019-09-26 17:18:48 +0000529 Returns a map from build ID to build info as a dictionary.
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000530 """
tandrii221ab252016-10-06 08:12:04 -0700531 assert buildbucket_host
532 assert changelist.GetIssue(), 'CL must be uploaded first'
533 assert changelist.GetCodereviewServer(), 'CL must be uploaded first'
534 patchset = patchset or changelist.GetMostRecentPatchset()
535 assert patchset, 'CL must be uploaded first'
536
537 codereview_url = changelist.GetCodereviewServer()
538 codereview_host = urlparse.urlparse(codereview_url).hostname
539 authenticator = auth.get_authenticator_for_host(codereview_host, auth_config)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000540 if authenticator.has_cached_credentials():
541 http = authenticator.authorize(httplib2.Http())
542 else:
vapiera7fbd5a2016-06-16 09:17:49 -0700543 print('Warning: Some results might be missing because %s' %
544 # Get the message on how to login.
Edward Lemurba5bc992019-09-23 22:59:17 +0000545 (auth.LoginRequiredError().message,))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000546 http = httplib2.Http()
547
548 http.force_exception_to_status_code = True
549
Andrii Shyshkalov03da1502018-10-15 03:42:34 +0000550 buildset = 'patch/gerrit/{hostname}/{issue}/{patch}'.format(
tandrii221ab252016-10-06 08:12:04 -0700551 hostname=codereview_host,
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000552 issue=changelist.GetIssue(),
tandrii221ab252016-10-06 08:12:04 -0700553 patch=patchset)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000554 params = {'tag': 'buildset:%s' % buildset}
555
556 builds = {}
557 while True:
558 url = 'https://{hostname}/_ah/api/buildbucket/v1/search?{params}'.format(
tandrii221ab252016-10-06 08:12:04 -0700559 hostname=buildbucket_host,
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000560 params=urllib.urlencode(params))
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000561 content = _buildbucket_retry('fetching tryjobs', http, url, 'GET')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000562 for build in content.get('builds', []):
563 builds[build['id']] = build
564 if 'next_cursor' in content:
565 params['start_cursor'] = content['next_cursor']
566 else:
567 break
568 return builds
569
570
Quinten Yearsley983111f2019-09-26 17:18:48 +0000571def _fetch_latest_builds(auth_config, changelist, buildbucket_host):
572 """Fetches builds from the latest patchset that has builds (within
573 the last few patchsets).
574
575 Args:
576 auth_config (auth.AuthConfig): Auth info for Buildbucket
577 changelist (Changelist): The CL to fetch builds for
578 buildbucket_host (str): Buildbucket host, e.g. "cr-buildbucket.appspot.com"
579
580 Returns:
581 A tuple (builds, patchset) where builds is a dict mapping from build ID to
582 build info from Buildbucket, and patchset is the patchset number where
583 those builds came from.
584 """
585 assert buildbucket_host
586 assert changelist.GetIssue(), 'CL must be uploaded first'
587 assert changelist.GetCodereviewServer(), 'CL must be uploaded first'
588 assert changelist.GetMostRecentPatchset()
589 ps = changelist.GetMostRecentPatchset()
590 min_ps = max(1, ps - 5)
591 while ps >= min_ps:
592 builds = fetch_try_jobs(
593 auth_config, changelist, buildbucket_host, patchset=ps)
594 if len(builds):
595 return builds, ps
596 ps -= 1
597 return [], 0
598
599
600def _filter_failed(builds):
601 """Returns a list of buckets/builders that had failed builds.
602
603 Args:
604 builds (dict): Builds, in the format returned by fetch_try_jobs,
605 i.e. a dict mapping build ID to build info dict, which includes
606 the keys status, result, bucket, and builder_name.
607
608 Returns:
609 A dict of bucket to builder to tests (empty list). This is the same format
610 accepted by _trigger_try_jobs and returned by _get_bucket_map.
611 """
612 buckets = collections.defaultdict(dict)
613 for build in builds.values():
614 if build['status'] == 'COMPLETED' and build['result'] == 'FAILURE':
615 project = build['project']
616 bucket = build['bucket']
617 if bucket.startswith('luci.'):
618 # Assume legacy bucket name luci.<project>.<bucket>.
619 bucket = bucket.split('.')[2]
620 builder = _get_builder_from_build(build)
621 buckets[project + '/' + bucket][builder] = []
622 return buckets
623
624
qyearsleyeab3c042016-08-24 09:18:28 -0700625def print_try_jobs(options, builds):
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000626 """Prints nicely result of fetch_try_jobs."""
627 if not builds:
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000628 print('No tryjobs scheduled.')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000629 return
630
631 # Make a copy, because we'll be modifying builds dictionary.
632 builds = builds.copy()
633 builder_names_cache = {}
634
635 def get_builder(b):
636 try:
637 return builder_names_cache[b['id']]
638 except KeyError:
Quinten Yearsley983111f2019-09-26 17:18:48 +0000639 name = _get_builder_from_build(b)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000640 builder_names_cache[b['id']] = name
641 return name
642
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000643 if options.print_master:
644 name_fmt = '%%-%ds %%-%ds' % (
Edward Lemurc8b67ed2019-09-12 20:28:58 +0000645 max(len(str(b['bucket'])) for b in builds.itervalues()),
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000646 max(len(str(get_builder(b))) for b in builds.itervalues()))
647 def get_name(b):
Edward Lemurc8b67ed2019-09-12 20:28:58 +0000648 return name_fmt % (b['bucket'], get_builder(b))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000649 else:
650 name_fmt = '%%-%ds' % (
651 max(len(str(get_builder(b))) for b in builds.itervalues()))
652 def get_name(b):
653 return name_fmt % get_builder(b)
654
655 def sort_key(b):
656 return b['status'], b.get('result'), get_name(b), b.get('url')
657
658 def pop(title, f, color=None, **kwargs):
659 """Pop matching builds from `builds` dict and print them."""
660
tandrii@chromium.org6cf98c82016-03-15 11:56:00 +0000661 if not options.color or color is None:
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000662 colorize = str
663 else:
664 colorize = lambda x: '%s%s%s' % (color, x, Fore.RESET)
665
666 result = []
667 for b in builds.values():
668 if all(b.get(k) == v for k, v in kwargs.iteritems()):
669 builds.pop(b['id'])
670 result.append(b)
671 if result:
vapiera7fbd5a2016-06-16 09:17:49 -0700672 print(colorize(title))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000673 for b in sorted(result, key=sort_key):
vapiera7fbd5a2016-06-16 09:17:49 -0700674 print(' ', colorize('\t'.join(map(str, f(b)))))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000675
676 total = len(builds)
677 pop(status='COMPLETED', result='SUCCESS',
678 title='Successes:', color=Fore.GREEN,
679 f=lambda b: (get_name(b), b.get('url')))
680 pop(status='COMPLETED', result='FAILURE', failure_reason='INFRA_FAILURE',
681 title='Infra Failures:', color=Fore.MAGENTA,
682 f=lambda b: (get_name(b), b.get('url')))
683 pop(status='COMPLETED', result='FAILURE', failure_reason='BUILD_FAILURE',
684 title='Failures:', color=Fore.RED,
685 f=lambda b: (get_name(b), b.get('url')))
686 pop(status='COMPLETED', result='CANCELED',
687 title='Canceled:', color=Fore.MAGENTA,
688 f=lambda b: (get_name(b),))
689 pop(status='COMPLETED', result='FAILURE',
690 failure_reason='INVALID_BUILD_DEFINITION',
691 title='Wrong master/builder name:', color=Fore.MAGENTA,
692 f=lambda b: (get_name(b),))
693 pop(status='COMPLETED', result='FAILURE',
694 title='Other failures:',
695 f=lambda b: (get_name(b), b.get('failure_reason'), b.get('url')))
696 pop(status='COMPLETED',
697 title='Other finished:',
698 f=lambda b: (get_name(b), b.get('result'), b.get('url')))
699 pop(status='STARTED',
700 title='Started:', color=Fore.YELLOW,
701 f=lambda b: (get_name(b), b.get('url')))
702 pop(status='SCHEDULED',
703 title='Scheduled:',
704 f=lambda b: (get_name(b), 'id=%s' % b['id']))
705 # The last section is just in case buildbucket API changes OR there is a bug.
706 pop(title='Other:',
707 f=lambda b: (get_name(b), 'id=%s' % b['id']))
708 assert len(builds) == 0
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000709 print('Total: %d tryjobs' % total)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000710
711
Quinten Yearsley983111f2019-09-26 17:18:48 +0000712def _get_builder_from_build(build):
713 """Returns a builder name from a BB v1 build info dict."""
714 try:
715 parameters = json.loads(build['parameters_json'])
716 name = parameters['builder_name']
717 except (ValueError, KeyError) as error:
718 print('WARNING: Failed to get builder name for build %s: %s' % (
719 build['id'], error))
720 name = None
721 return name
722
723
Aiden Bennerc08566e2018-10-03 17:52:42 +0000724def _ComputeDiffLineRanges(files, upstream_commit):
725 """Gets the changed line ranges for each file since upstream_commit.
726
727 Parses a git diff on provided files and returns a dict that maps a file name
728 to an ordered list of range tuples in the form (start_line, count).
729 Ranges are in the same format as a git diff.
730 """
731 # If files is empty then diff_output will be a full diff.
732 if len(files) == 0:
733 return {}
734
Aiden Benner6c18a1a2018-11-23 20:18:23 +0000735 # Take the git diff and find the line ranges where there are changes.
Aiden Bennerc08566e2018-10-03 17:52:42 +0000736 diff_cmd = BuildGitDiffCmd('-U0', upstream_commit, files, allow_prefix=True)
737 diff_output = RunGit(diff_cmd)
738
739 pattern = r'(?:^diff --git a/(?:.*) b/(.*))|(?:^@@.*\+(.*) @@)'
740 # 2 capture groups
741 # 0 == fname of diff file
742 # 1 == 'diff_start,diff_count' or 'diff_start'
743 # will match each of
744 # diff --git a/foo.foo b/foo.py
745 # @@ -12,2 +14,3 @@
746 # @@ -12,2 +17 @@
747 # running re.findall on the above string with pattern will give
748 # [('foo.py', ''), ('', '14,3'), ('', '17')]
749
750 curr_file = None
751 line_diffs = {}
752 for match in re.findall(pattern, diff_output, flags=re.MULTILINE):
753 if match[0] != '':
754 # Will match the second filename in diff --git a/a.py b/b.py.
755 curr_file = match[0]
756 line_diffs[curr_file] = []
757 else:
758 # Matches +14,3
759 if ',' in match[1]:
760 diff_start, diff_count = match[1].split(',')
761 else:
762 # Single line changes are of the form +12 instead of +12,1.
763 diff_start = match[1]
764 diff_count = 1
765
766 diff_start = int(diff_start)
767 diff_count = int(diff_count)
768
769 # If diff_count == 0 this is a removal we can ignore.
770 line_diffs[curr_file].append((diff_start, diff_count))
771
772 return line_diffs
773
774
Aiden Benner99b0ccb2018-11-20 19:53:31 +0000775def _FindYapfConfigFile(fpath, yapf_config_cache, top_dir=None):
Aiden Bennerc08566e2018-10-03 17:52:42 +0000776 """Checks if a yapf file is in any parent directory of fpath until top_dir.
777
Aiden Benner99b0ccb2018-11-20 19:53:31 +0000778 Recursively checks parent directories to find yapf file and if no yapf file
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000779 is found returns None. Uses yapf_config_cache as a cache for previously found
780 configs.
Aiden Bennerc08566e2018-10-03 17:52:42 +0000781 """
Aiden Benner99b0ccb2018-11-20 19:53:31 +0000782 fpath = os.path.abspath(fpath)
Aiden Bennerc08566e2018-10-03 17:52:42 +0000783 # Return result if we've already computed it.
784 if fpath in yapf_config_cache:
785 return yapf_config_cache[fpath]
786
Aiden Benner99b0ccb2018-11-20 19:53:31 +0000787 parent_dir = os.path.dirname(fpath)
788 if os.path.isfile(fpath):
789 ret = _FindYapfConfigFile(parent_dir, yapf_config_cache, top_dir)
Aiden Bennerc08566e2018-10-03 17:52:42 +0000790 else:
Aiden Benner99b0ccb2018-11-20 19:53:31 +0000791 # Otherwise fpath is a directory
792 yapf_file = os.path.join(fpath, YAPF_CONFIG_FILENAME)
793 if os.path.isfile(yapf_file):
794 ret = yapf_file
795 elif fpath == top_dir or parent_dir == fpath:
796 # If we're at the top level directory, or if we're at root
797 # there is no provided style.
798 ret = None
799 else:
800 # Otherwise recurse on the current directory.
801 ret = _FindYapfConfigFile(parent_dir, yapf_config_cache, top_dir)
Aiden Bennerc08566e2018-10-03 17:52:42 +0000802 yapf_config_cache[fpath] = ret
803 return ret
804
805
qyearsley53f48a12016-09-01 10:45:13 -0700806def write_try_results_json(output_file, builds):
807 """Writes a subset of the data from fetch_try_jobs to a file as JSON.
808
809 The input |builds| dict is assumed to be generated by Buildbucket.
810 Buildbucket documentation: http://goo.gl/G0s101
811 """
812
813 def convert_build_dict(build):
Quinten Yearsleya563d722017-12-11 16:36:54 -0800814 """Extracts some of the information from one build dict."""
815 parameters = json.loads(build.get('parameters_json', '{}')) or {}
qyearsley53f48a12016-09-01 10:45:13 -0700816 return {
817 'buildbucket_id': build.get('id'),
qyearsley53f48a12016-09-01 10:45:13 -0700818 'bucket': build.get('bucket'),
Quinten Yearsleya563d722017-12-11 16:36:54 -0800819 'builder_name': parameters.get('builder_name'),
820 'created_ts': build.get('created_ts'),
821 'experimental': build.get('experimental'),
qyearsley53f48a12016-09-01 10:45:13 -0700822 'failure_reason': build.get('failure_reason'),
Quinten Yearsleya563d722017-12-11 16:36:54 -0800823 'result': build.get('result'),
824 'status': build.get('status'),
825 'tags': build.get('tags'),
qyearsley53f48a12016-09-01 10:45:13 -0700826 'url': build.get('url'),
827 }
828
829 converted = []
830 for _, build in sorted(builds.items()):
Aiden Bennerc08566e2018-10-03 17:52:42 +0000831 converted.append(convert_build_dict(build))
qyearsley53f48a12016-09-01 10:45:13 -0700832 write_json(output_file, converted)
833
834
Aaron Gable13101a62018-02-09 13:20:41 -0800835def print_stats(args):
maruel@chromium.org49e3d802012-07-18 23:54:45 +0000836 """Prints statistics about the change to the user."""
837 # --no-ext-diff is broken in some versions of Git, so try to work around
838 # this by overriding the environment (but there is still a problem if the
839 # git config key "diff.external" is used).
thestig@chromium.org8b0553c2014-02-11 00:33:37 +0000840 env = GetNoGitPagerEnv()
maruel@chromium.org49e3d802012-07-18 23:54:45 +0000841 if 'GIT_EXTERNAL_DIFF' in env:
842 del env['GIT_EXTERNAL_DIFF']
iannucci@chromium.org79540052012-10-19 23:15:26 +0000843
szager@chromium.orgd057f9a2014-05-29 21:09:36 +0000844 try:
845 stdout = sys.stdout.fileno()
846 except AttributeError:
847 stdout = None
maruel@chromium.org49e3d802012-07-18 23:54:45 +0000848 return subprocess2.call(
Aaron Gable13101a62018-02-09 13:20:41 -0800849 ['git', 'diff', '--no-ext-diff', '--stat', '-l100000', '-C50'] + args,
szager@chromium.orgd057f9a2014-05-29 21:09:36 +0000850 stdout=stdout, env=env)
maruel@chromium.org49e3d802012-07-18 23:54:45 +0000851
852
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000853class BuildbucketResponseException(Exception):
854 pass
855
856
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000857class Settings(object):
858 def __init__(self):
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000859 self.cc = None
thestig@chromium.org7a54e812014-02-11 19:57:22 +0000860 self.root = None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000861 self.tree_status_url = None
862 self.viewvc_url = None
863 self.updated = False
ukai@chromium.orge8077812012-02-03 03:41:46 +0000864 self.is_gerrit = None
bauerb@chromium.org54b400c2016-01-14 10:08:25 +0000865 self.squash_gerrit_uploads = None
tandrii@chromium.org28253532016-04-14 13:46:56 +0000866 self.gerrit_skip_ensure_authenticated = None
jbroman@chromium.org615a2622013-05-03 13:20:14 +0000867 self.git_editor = None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000868
869 def LazyUpdateIfNeeded(self):
870 """Updates the settings from a codereview.settings file, if available."""
871 if not self.updated:
pgervais@chromium.org87884cc2014-01-03 22:23:41 +0000872 # The only value that actually changes the behavior is
873 # autoupdate = "false". Everything else means "true".
nick@chromium.org3ac1c4e2014-01-16 02:44:42 +0000874 autoupdate = RunGit(['config', 'rietveld.autoupdate'],
pgervais@chromium.org87884cc2014-01-03 22:23:41 +0000875 error_ok=True
876 ).strip().lower()
877
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000878 cr_settings_file = FindCodereviewSettingsFile()
pgervais@chromium.org87884cc2014-01-03 22:23:41 +0000879 if autoupdate != 'false' and cr_settings_file:
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000880 LoadCodereviewSettingsFromFile(cr_settings_file)
881 self.updated = True
882
thestig@chromium.org7a54e812014-02-11 19:57:22 +0000883 @staticmethod
884 def GetRelativeRoot():
885 return RunGit(['rev-parse', '--show-cdup']).strip()
thestig@chromium.org8b0553c2014-02-11 00:33:37 +0000886
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000887 def GetRoot(self):
thestig@chromium.org7a54e812014-02-11 19:57:22 +0000888 if self.root is None:
889 self.root = os.path.abspath(self.GetRelativeRoot())
890 return self.root
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000891
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000892 def GetTreeStatusUrl(self, error_ok=False):
893 if not self.tree_status_url:
894 error_message = ('You must configure your tree status URL by running '
895 '"git cl config".')
Edward Lemur61ea3072018-12-01 00:34:36 +0000896 self.tree_status_url = self._GetConfig(
897 'rietveld.tree-status-url', error_ok=error_ok,
898 error_message=error_message)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000899 return self.tree_status_url
900
901 def GetViewVCUrl(self):
902 if not self.viewvc_url:
Edward Lemur61ea3072018-12-01 00:34:36 +0000903 self.viewvc_url = self._GetConfig('rietveld.viewvc-url', error_ok=True)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000904 return self.viewvc_url
905
rmistry@google.com90752582014-01-14 21:04:50 +0000906 def GetBugPrefix(self):
Edward Lemur61ea3072018-12-01 00:34:36 +0000907 return self._GetConfig('rietveld.bug-prefix', error_ok=True)
rmistry@google.com78948ed2015-07-08 23:09:57 +0000908
rmistry@google.com5626a922015-02-26 14:03:30 +0000909 def GetRunPostUploadHook(self):
Edward Lemur61ea3072018-12-01 00:34:36 +0000910 run_post_upload_hook = self._GetConfig(
911 'rietveld.run-post-upload-hook', error_ok=True)
rmistry@google.com5626a922015-02-26 14:03:30 +0000912 return run_post_upload_hook == "True"
913
bauerb@chromium.orgae6df352011-04-06 17:40:39 +0000914 def GetDefaultCCList(self):
Edward Lemur61ea3072018-12-01 00:34:36 +0000915 return self._GetConfig('rietveld.cc', error_ok=True)
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000916
ukai@chromium.orge8077812012-02-03 03:41:46 +0000917 def GetIsGerrit(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000918 """Returns True if this repo is associated with Gerrit."""
ukai@chromium.orge8077812012-02-03 03:41:46 +0000919 if self.is_gerrit is None:
Aaron Gable9b465272017-05-12 10:53:51 -0700920 self.is_gerrit = (
921 self._GetConfig('gerrit.host', error_ok=True).lower() == 'true')
ukai@chromium.orge8077812012-02-03 03:41:46 +0000922 return self.is_gerrit
923
bauerb@chromium.org54b400c2016-01-14 10:08:25 +0000924 def GetSquashGerritUploads(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000925 """Returns True if uploads to Gerrit should be squashed by default."""
bauerb@chromium.org54b400c2016-01-14 10:08:25 +0000926 if self.squash_gerrit_uploads is None:
tandriia60502f2016-06-20 02:01:53 -0700927 self.squash_gerrit_uploads = self.GetSquashGerritUploadsOverride()
928 if self.squash_gerrit_uploads is None:
929 # Default is squash now (http://crbug.com/611892#c23).
930 self.squash_gerrit_uploads = not (
931 RunGit(['config', '--bool', 'gerrit.squash-uploads'],
932 error_ok=True).strip() == 'false')
bauerb@chromium.org54b400c2016-01-14 10:08:25 +0000933 return self.squash_gerrit_uploads
934
tandriia60502f2016-06-20 02:01:53 -0700935 def GetSquashGerritUploadsOverride(self):
936 """Return True or False if codereview.settings should be overridden.
937
938 Returns None if no override has been defined.
939 """
940 # See also http://crbug.com/611892#c23
941 result = RunGit(['config', '--bool', 'gerrit.override-squash-uploads'],
942 error_ok=True).strip()
943 if result == 'true':
944 return True
945 if result == 'false':
946 return False
947 return None
948
tandrii@chromium.org28253532016-04-14 13:46:56 +0000949 def GetGerritSkipEnsureAuthenticated(self):
950 """Return True if EnsureAuthenticated should not be done for Gerrit
951 uploads."""
952 if self.gerrit_skip_ensure_authenticated is None:
953 self.gerrit_skip_ensure_authenticated = (
shinyak@chromium.org00dbccd2016-04-15 07:24:43 +0000954 RunGit(['config', '--bool', 'gerrit.skip-ensure-authenticated'],
tandrii@chromium.org28253532016-04-14 13:46:56 +0000955 error_ok=True).strip() == 'true')
956 return self.gerrit_skip_ensure_authenticated
957
jbroman@chromium.org615a2622013-05-03 13:20:14 +0000958 def GetGitEditor(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000959 """Returns the editor specified in the git config, or None if none is."""
jbroman@chromium.org615a2622013-05-03 13:20:14 +0000960 if self.git_editor is None:
Raul Tambre5a525872019-02-12 19:08:08 +0000961 # Git requires single quotes for paths with spaces. We need to replace
962 # them with double quotes for Windows to treat such paths as a single
963 # path.
964 self.git_editor = self._GetConfig(
965 'core.editor', error_ok=True).replace('\'', '"')
jbroman@chromium.org615a2622013-05-03 13:20:14 +0000966 return self.git_editor or None
967
thestig@chromium.org44202a22014-03-11 19:22:18 +0000968 def GetLintRegex(self):
Edward Lemur61ea3072018-12-01 00:34:36 +0000969 return (self._GetConfig('rietveld.cpplint-regex', error_ok=True) or
thestig@chromium.org44202a22014-03-11 19:22:18 +0000970 DEFAULT_LINT_REGEX)
971
972 def GetLintIgnoreRegex(self):
Edward Lemur61ea3072018-12-01 00:34:36 +0000973 return (self._GetConfig('rietveld.cpplint-ignore-regex', error_ok=True) or
thestig@chromium.org44202a22014-03-11 19:22:18 +0000974 DEFAULT_LINT_IGNORE_REGEX)
975
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000976 def _GetConfig(self, param, **kwargs):
977 self.LazyUpdateIfNeeded()
978 return RunGit(['config', param], **kwargs).strip()
979
980
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000981def ShortBranchName(branch):
982 """Convert a name like 'refs/heads/foo' to just 'foo'."""
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +0000983 return branch.replace('refs/heads/', '', 1)
984
985
986def GetCurrentBranchRef():
987 """Returns branch ref (e.g., refs/heads/master) or None."""
988 return RunGit(['symbolic-ref', 'HEAD'],
989 stderr=subprocess2.VOID, error_ok=True).strip() or None
990
991
992def GetCurrentBranch():
993 """Returns current branch or None.
994
995 For refs/heads/* branches, returns just last part. For others, full ref.
996 """
997 branchref = GetCurrentBranchRef()
998 if branchref:
999 return ShortBranchName(branchref)
1000 return None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001001
1002
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001003class _CQState(object):
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +00001004 """Enum for states of CL with respect to CQ."""
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001005 NONE = 'none'
1006 DRY_RUN = 'dry_run'
1007 COMMIT = 'commit'
1008
1009 ALL_STATES = [NONE, DRY_RUN, COMMIT]
1010
1011
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001012class _ParsedIssueNumberArgument(object):
Edward Lemurf38bc172019-09-03 21:02:13 +00001013 def __init__(self, issue=None, patchset=None, hostname=None):
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001014 self.issue = issue
1015 self.patchset = patchset
1016 self.hostname = hostname
1017
1018 @property
1019 def valid(self):
1020 return self.issue is not None
1021
1022
Edward Lemurf38bc172019-09-03 21:02:13 +00001023def ParseIssueNumberArgument(arg):
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001024 """Parses the issue argument and returns _ParsedIssueNumberArgument."""
1025 fail_result = _ParsedIssueNumberArgument()
1026
1027 if arg.isdigit():
Edward Lemurf38bc172019-09-03 21:02:13 +00001028 return _ParsedIssueNumberArgument(issue=int(arg))
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001029 if not arg.startswith('http'):
1030 return fail_result
Aaron Gableaee6c852017-06-26 12:49:01 -07001031
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001032 url = gclient_utils.UpgradeToHttps(arg)
1033 try:
1034 parsed_url = urlparse.urlparse(url)
1035 except ValueError:
1036 return fail_result
Andrii Shyshkalov28d840e2017-04-10 15:45:09 +02001037
Edward Lemur125d60a2019-09-13 18:25:41 +00001038 return Changelist.ParseIssueURL(parsed_url) or fail_result
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001039
1040
Andrii Shyshkalovb07575f2018-10-16 06:16:21 +00001041def _create_description_from_log(args):
1042 """Pulls out the commit log to use as a base for the CL description."""
1043 log_args = []
1044 if len(args) == 1 and not args[0].endswith('.'):
1045 log_args = [args[0] + '..']
1046 elif len(args) == 1 and args[0].endswith('...'):
1047 log_args = [args[0][:-1]]
1048 elif len(args) == 2:
1049 log_args = [args[0] + '..' + args[1]]
1050 else:
1051 log_args = args[:] # Hope for the best!
1052 return RunGit(['log', '--pretty=format:%s\n\n%b'] + log_args)
1053
1054
Aaron Gablea45ee112016-11-22 15:14:38 -08001055class GerritChangeNotExists(Exception):
tandriic2405f52016-10-10 08:13:15 -07001056 def __init__(self, issue, url):
1057 self.issue = issue
1058 self.url = url
Aaron Gablea45ee112016-11-22 15:14:38 -08001059 super(GerritChangeNotExists, self).__init__()
tandriic2405f52016-10-10 08:13:15 -07001060
1061 def __str__(self):
Aaron Gablea45ee112016-11-22 15:14:38 -08001062 return 'change %s at %s does not exist or you have no access to it' % (
tandriic2405f52016-10-10 08:13:15 -07001063 self.issue, self.url)
1064
1065
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01001066_CommentSummary = collections.namedtuple(
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001067 '_CommentSummary', ['date', 'message', 'sender', 'autogenerated',
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01001068 # TODO(tandrii): these two aren't known in Gerrit.
1069 'approval', 'disapproval'])
1070
1071
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001072class Changelist(object):
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001073 """Changelist works with one changelist in local branch.
1074
tandrii@chromium.org8930b3d2016-04-13 14:47:02 +00001075 Notes:
1076 * Not safe for concurrent multi-{thread,process} use.
1077 * Caches values from current branch. Therefore, re-use after branch change
tandrii5d48c322016-08-18 16:19:37 -07001078 with great care.
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001079 """
1080
Edward Lemur125d60a2019-09-13 18:25:41 +00001081 def __init__(self, branchref=None, issue=None, codereview_host=None):
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001082 """Create a new ChangeList instance.
1083
Edward Lemurf38bc172019-09-03 21:02:13 +00001084 **kwargs will be passed directly to Gerrit implementation.
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001085 """
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001086 # Poke settings so we get the "configure your server" message if necessary.
maruel@chromium.org379d07a2011-11-30 14:58:10 +00001087 global settings
1088 if not settings:
1089 # Happens when git_cl.py is used as a utility library.
1090 settings = Settings()
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001091
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001092 self.branchref = branchref
1093 if self.branchref:
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00001094 assert branchref.startswith('refs/heads/')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001095 self.branch = ShortBranchName(self.branchref)
1096 else:
1097 self.branch = None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001098 self.upstream_branch = None
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001099 self.lookedup_issue = False
1100 self.issue = issue or None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001101 self.has_description = False
1102 self.description = None
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001103 self.lookedup_patchset = False
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001104 self.patchset = None
bauerb@chromium.orgae6df352011-04-06 17:40:39 +00001105 self.cc = None
Daniel Cheng7227d212017-11-17 08:12:37 -08001106 self.more_cc = []
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00001107 self._remote = None
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00001108 self._cached_remote_url = (False, None) # (is_cached, value)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00001109
Edward Lemur125d60a2019-09-13 18:25:41 +00001110 # Lazily cached values.
1111 self._gerrit_host = None # e.g. chromium-review.googlesource.com
1112 self._gerrit_server = None # e.g. https://chromium-review.googlesource.com
1113 # Map from change number (issue) to its detail cache.
1114 self._detail_cache = {}
1115
1116 if codereview_host is not None:
1117 assert not codereview_host.startswith('https://'), codereview_host
1118 self._gerrit_host = codereview_host
1119 self._gerrit_server = 'https://%s' % codereview_host
bauerb@chromium.orgae6df352011-04-06 17:40:39 +00001120
1121 def GetCCList(self):
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001122 """Returns the users cc'd on this CL.
bauerb@chromium.orgae6df352011-04-06 17:40:39 +00001123
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001124 The return value is a string suitable for passing to git cl with the --cc
1125 flag.
bauerb@chromium.orgae6df352011-04-06 17:40:39 +00001126 """
1127 if self.cc is None:
tyoshino@chromium.org99918ab2013-09-30 06:17:28 +00001128 base_cc = settings.GetDefaultCCList()
Daniel Cheng7227d212017-11-17 08:12:37 -08001129 more_cc = ','.join(self.more_cc)
bauerb@chromium.orgae6df352011-04-06 17:40:39 +00001130 self.cc = ','.join(filter(None, (base_cc, more_cc))) or ''
1131 return self.cc
1132
tyoshino@chromium.org99918ab2013-09-30 06:17:28 +00001133 def GetCCListWithoutDefault(self):
1134 """Return the users cc'd on this CL excluding default ones."""
1135 if self.cc is None:
Daniel Cheng7227d212017-11-17 08:12:37 -08001136 self.cc = ','.join(self.more_cc)
tyoshino@chromium.org99918ab2013-09-30 06:17:28 +00001137 return self.cc
1138
Daniel Cheng7227d212017-11-17 08:12:37 -08001139 def ExtendCC(self, more_cc):
1140 """Extends the list of users to cc on this CL based on the changed files."""
1141 self.more_cc.extend(more_cc)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001142
1143 def GetBranch(self):
1144 """Returns the short branch name, e.g. 'master'."""
1145 if not self.branch:
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001146 branchref = GetCurrentBranchRef()
szager@chromium.orgd62c61f2014-10-20 22:33:21 +00001147 if not branchref:
1148 return None
1149 self.branchref = branchref
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001150 self.branch = ShortBranchName(self.branchref)
1151 return self.branch
1152
1153 def GetBranchRef(self):
1154 """Returns the full branch name, e.g. 'refs/heads/master'."""
1155 self.GetBranch() # Poke the lazy loader.
1156 return self.branchref
1157
tandrii@chromium.org534f67a2016-04-07 18:47:05 +00001158 def ClearBranch(self):
1159 """Clears cached branch data of this object."""
1160 self.branch = self.branchref = None
1161
tandrii5d48c322016-08-18 16:19:37 -07001162 def _GitGetBranchConfigValue(self, key, default=None, **kwargs):
1163 assert 'branch' not in kwargs, 'this CL branch is used automatically'
1164 kwargs['branch'] = self.GetBranch()
1165 return _git_get_branch_config_value(key, default, **kwargs)
1166
1167 def _GitSetBranchConfigValue(self, key, value, **kwargs):
1168 assert 'branch' not in kwargs, 'this CL branch is used automatically'
1169 assert self.GetBranch(), (
1170 'this CL must have an associated branch to %sset %s%s' %
1171 ('un' if value is None else '',
1172 key,
1173 '' if value is None else ' to %r' % value))
1174 kwargs['branch'] = self.GetBranch()
1175 return _git_set_branch_config_value(key, value, **kwargs)
1176
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001177 @staticmethod
1178 def FetchUpstreamTuple(branch):
pgervais@chromium.orgd6617f32013-11-19 00:34:54 +00001179 """Returns a tuple containing remote and remote ref,
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001180 e.g. 'origin', 'refs/heads/master'
1181 """
1182 remote = '.'
tandrii5d48c322016-08-18 16:19:37 -07001183 upstream_branch = _git_get_branch_config_value('merge', branch=branch)
1184
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001185 if upstream_branch:
tandrii5d48c322016-08-18 16:19:37 -07001186 remote = _git_get_branch_config_value('remote', branch=branch)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001187 else:
bauerb@chromium.orgade368c2011-03-01 08:57:50 +00001188 upstream_branch = RunGit(['config', 'rietveld.upstream-branch'],
1189 error_ok=True).strip()
1190 if upstream_branch:
1191 remote = RunGit(['config', 'rietveld.upstream-remote']).strip()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001192 else:
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08001193 # Else, try to guess the origin remote.
1194 remote_branches = RunGit(['branch', '-r']).split()
1195 if 'origin/master' in remote_branches:
1196 # Fall back on origin/master if it exits.
1197 remote = 'origin'
1198 upstream_branch = 'refs/heads/master'
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001199 else:
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08001200 DieWithError(
1201 'Unable to determine default branch to diff against.\n'
1202 'Either pass complete "git diff"-style arguments, like\n'
1203 ' git cl upload origin/master\n'
1204 'or verify this branch is set up to track another \n'
1205 '(via the --track argument to "git checkout -b ...").')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001206
1207 return remote, upstream_branch
1208
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00001209 def GetCommonAncestorWithUpstream(self):
pgervais@chromium.org8ba38ff2015-06-11 21:41:25 +00001210 upstream_branch = self.GetUpstreamBranch()
1211 if not BranchExists(upstream_branch):
1212 DieWithError('The upstream for the current branch (%s) does not exist '
1213 'anymore.\nPlease fix it and try again.' % self.GetBranch())
iannucci@chromium.org9e849272014-04-04 00:31:55 +00001214 return git_common.get_or_create_merge_base(self.GetBranch(),
pgervais@chromium.org8ba38ff2015-06-11 21:41:25 +00001215 upstream_branch)
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00001216
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001217 def GetUpstreamBranch(self):
1218 if self.upstream_branch is None:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001219 remote, upstream_branch = self.FetchUpstreamTuple(self.GetBranch())
Raul Tambrefe1dbe12019-05-02 04:43:57 +00001220 if remote != '.':
mmoss@chromium.orge7585452014-08-24 01:41:11 +00001221 upstream_branch = upstream_branch.replace('refs/heads/',
1222 'refs/remotes/%s/' % remote)
1223 upstream_branch = upstream_branch.replace('refs/branch-heads/',
1224 'refs/remotes/branch-heads/')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001225 self.upstream_branch = upstream_branch
1226 return self.upstream_branch
1227
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001228 def GetRemoteBranch(self):
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001229 if not self._remote:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001230 remote, branch = None, self.GetBranch()
1231 seen_branches = set()
1232 while branch not in seen_branches:
1233 seen_branches.add(branch)
1234 remote, branch = self.FetchUpstreamTuple(branch)
1235 branch = ShortBranchName(branch)
1236 if remote != '.' or branch.startswith('refs/remotes'):
1237 break
1238 else:
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001239 remotes = RunGit(['remote'], error_ok=True).split()
1240 if len(remotes) == 1:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001241 remote, = remotes
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001242 elif 'origin' in remotes:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001243 remote = 'origin'
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08001244 logging.warn('Could not determine which remote this change is '
1245 'associated with, so defaulting to "%s".' % self._remote)
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001246 else:
1247 logging.warn('Could not determine which remote this change is '
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08001248 'associated with.')
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001249 branch = 'HEAD'
1250 if branch.startswith('refs/remotes'):
1251 self._remote = (remote, branch)
mmoss@chromium.orge7585452014-08-24 01:41:11 +00001252 elif branch.startswith('refs/branch-heads/'):
1253 self._remote = (remote, branch.replace('refs/', 'refs/remotes/'))
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001254 else:
1255 self._remote = (remote, 'refs/remotes/%s/%s' % (remote, branch))
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001256 return self._remote
1257
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001258 def GitSanityChecks(self, upstream_git_obj):
1259 """Checks git repo status and ensures diff is from local commits."""
1260
sbc@chromium.org79706062015-01-14 21:18:12 +00001261 if upstream_git_obj is None:
1262 if self.GetBranch() is None:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001263 print('ERROR: Unable to determine current branch (detached HEAD?)',
vapiera7fbd5a2016-06-16 09:17:49 -07001264 file=sys.stderr)
sbc@chromium.org79706062015-01-14 21:18:12 +00001265 else:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001266 print('ERROR: No upstream branch.', file=sys.stderr)
sbc@chromium.org79706062015-01-14 21:18:12 +00001267 return False
1268
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001269 # Verify the commit we're diffing against is in our current branch.
1270 upstream_sha = RunGit(['rev-parse', '--verify', upstream_git_obj]).strip()
1271 common_ancestor = RunGit(['merge-base', upstream_sha, 'HEAD']).strip()
1272 if upstream_sha != common_ancestor:
vapiera7fbd5a2016-06-16 09:17:49 -07001273 print('ERROR: %s is not in the current branch. You may need to rebase '
1274 'your tracking branch' % upstream_sha, file=sys.stderr)
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001275 return False
1276
1277 # List the commits inside the diff, and verify they are all local.
1278 commits_in_diff = RunGit(
1279 ['rev-list', '^%s' % upstream_sha, 'HEAD']).splitlines()
1280 code, remote_branch = RunGitWithCode(['config', 'gitcl.remotebranch'])
1281 remote_branch = remote_branch.strip()
1282 if code != 0:
1283 _, remote_branch = self.GetRemoteBranch()
1284
1285 commits_in_remote = RunGit(
1286 ['rev-list', '^%s' % upstream_sha, remote_branch]).splitlines()
1287
1288 common_commits = set(commits_in_diff) & set(commits_in_remote)
1289 if common_commits:
vapiera7fbd5a2016-06-16 09:17:49 -07001290 print('ERROR: Your diff contains %d commits already in %s.\n'
1291 'Run "git log --oneline %s..HEAD" to get a list of commits in '
1292 'the diff. If you are using a custom git flow, you can override'
1293 ' the reference used for this check with "git config '
1294 'gitcl.remotebranch <git-ref>".' % (
1295 len(common_commits), remote_branch, upstream_git_obj),
1296 file=sys.stderr)
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001297 return False
1298 return True
1299
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00001300 def GetGitBaseUrlFromConfig(self):
sheyang@chromium.orga656e702014-05-15 20:43:05 +00001301 """Return the configured base URL from branch.<branchname>.baseurl.
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00001302
1303 Returns None if it is not set.
1304 """
tandrii5d48c322016-08-18 16:19:37 -07001305 return self._GitGetBranchConfigValue('base-url')
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001306
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001307 def GetRemoteUrl(self):
1308 """Return the configured remote URL, e.g. 'git://example.org/foo.git/'.
1309
1310 Returns None if there is no remote.
1311 """
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00001312 is_cached, value = self._cached_remote_url
1313 if is_cached:
1314 return value
1315
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001316 remote, _ = self.GetRemoteBranch()
dyen@chromium.org2a13d4f2014-06-13 00:06:37 +00001317 url = RunGit(['config', 'remote.%s.url' % remote], error_ok=True).strip()
1318
Edward Lemur298f2cf2019-02-22 21:40:39 +00001319 # Check if the remote url can be parsed as an URL.
1320 host = urlparse.urlparse(url).netloc
1321 if host:
1322 self._cached_remote_url = (True, url)
1323 return url
1324
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001325 # If it cannot be parsed as an url, assume it is a local directory,
1326 # probably a git cache.
Edward Lemur298f2cf2019-02-22 21:40:39 +00001327 logging.warning('"%s" doesn\'t appear to point to a git host. '
1328 'Interpreting it as a local directory.', url)
1329 if not os.path.isdir(url):
1330 logging.error(
1331 'Remote "%s" for branch "%s" points to "%s", but it doesn\'t exist.',
Daniel Bratell4a60db42019-09-16 17:02:52 +00001332 remote, self.GetBranch(), url)
Edward Lemur298f2cf2019-02-22 21:40:39 +00001333 return None
1334
1335 cache_path = url
1336 url = RunGit(['config', 'remote.%s.url' % remote],
1337 error_ok=True,
1338 cwd=url).strip()
1339
1340 host = urlparse.urlparse(url).netloc
1341 if not host:
1342 logging.error(
1343 'Remote "%(remote)s" for branch "%(branch)s" points to '
1344 '"%(cache_path)s", but it is misconfigured.\n'
1345 '"%(cache_path)s" must be a git repo and must have a remote named '
1346 '"%(remote)s" pointing to the git host.', {
1347 'remote': remote,
1348 'cache_path': cache_path,
1349 'branch': self.GetBranch()})
1350 return None
1351
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00001352 self._cached_remote_url = (True, url)
dyen@chromium.org2a13d4f2014-06-13 00:06:37 +00001353 return url
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001354
tandrii@chromium.org87985d22016-03-24 17:33:33 +00001355 def GetIssue(self):
maruel@chromium.org52424302012-08-29 15:14:30 +00001356 """Returns the issue number as a int or None if not set."""
tandrii@chromium.org87985d22016-03-24 17:33:33 +00001357 if self.issue is None and not self.lookedup_issue:
tandrii5d48c322016-08-18 16:19:37 -07001358 self.issue = self._GitGetBranchConfigValue(
Edward Lemur125d60a2019-09-13 18:25:41 +00001359 self.IssueConfigKey(), value_type=int)
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001360 self.lookedup_issue = True
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001361 return self.issue
1362
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001363 def GetIssueURL(self):
1364 """Get the URL for a particular issue."""
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001365 issue = self.GetIssue()
1366 if not issue:
dbeam@chromium.org015fd3d2013-06-18 19:02:50 +00001367 return None
Edward Lemur125d60a2019-09-13 18:25:41 +00001368 return '%s/%s' % (self.GetCodereviewServer(), issue)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001369
Andrii Shyshkalov31863012017-02-08 11:35:12 +01001370 def GetDescription(self, pretty=False, force=False):
1371 if not self.has_description or force:
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001372 if self.GetIssue():
Edward Lemur125d60a2019-09-13 18:25:41 +00001373 self.description = self.FetchDescription(force=force)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001374 self.has_description = True
1375 if pretty:
Asanka Herath7c61dcb2016-12-14 13:01:58 -05001376 # Set width to 72 columns + 2 space indent.
1377 wrapper = textwrap.TextWrapper(width=74, replace_whitespace=True)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001378 wrapper.initial_indent = wrapper.subsequent_indent = ' '
Asanka Herath7c61dcb2016-12-14 13:01:58 -05001379 lines = self.description.splitlines()
1380 return '\n'.join([wrapper.fill(line) for line in lines])
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001381 return self.description
1382
Robert Iannucci09f1f3d2017-03-28 16:54:32 -07001383 def GetDescriptionFooters(self):
1384 """Returns (non_footer_lines, footers) for the commit message.
1385
1386 Returns:
1387 non_footer_lines (list(str)) - Simple list of description lines without
1388 any footer. The lines do not contain newlines, nor does the list contain
1389 the empty line between the message and the footers.
1390 footers (list(tuple(KEY, VALUE))) - List of parsed footers, e.g.
1391 [("Change-Id", "Ideadbeef...."), ...]
1392 """
1393 raw_description = self.GetDescription()
1394 msg_lines, _, footers = git_footers.split_footers(raw_description)
1395 if footers:
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001396 msg_lines = msg_lines[:len(msg_lines) - 1]
Robert Iannucci09f1f3d2017-03-28 16:54:32 -07001397 return msg_lines, footers
1398
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001399 def GetPatchset(self):
maruel@chromium.org52424302012-08-29 15:14:30 +00001400 """Returns the patchset number as a int or None if not set."""
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001401 if self.patchset is None and not self.lookedup_patchset:
tandrii5d48c322016-08-18 16:19:37 -07001402 self.patchset = self._GitGetBranchConfigValue(
Edward Lemur125d60a2019-09-13 18:25:41 +00001403 self.PatchsetConfigKey(), value_type=int)
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001404 self.lookedup_patchset = True
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001405 return self.patchset
1406
1407 def SetPatchset(self, patchset):
tandrii5d48c322016-08-18 16:19:37 -07001408 """Set this branch's patchset. If patchset=0, clears the patchset."""
1409 assert self.GetBranch()
1410 if not patchset:
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001411 self.patchset = None
tandrii5d48c322016-08-18 16:19:37 -07001412 else:
1413 self.patchset = int(patchset)
1414 self._GitSetBranchConfigValue(
Edward Lemur125d60a2019-09-13 18:25:41 +00001415 self.PatchsetConfigKey(), self.patchset)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001416
tandrii@chromium.orga342c922016-03-16 07:08:25 +00001417 def SetIssue(self, issue=None):
tandrii5d48c322016-08-18 16:19:37 -07001418 """Set this branch's issue. If issue isn't given, clears the issue."""
1419 assert self.GetBranch()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001420 if issue:
tandrii5d48c322016-08-18 16:19:37 -07001421 issue = int(issue)
1422 self._GitSetBranchConfigValue(
Edward Lemur125d60a2019-09-13 18:25:41 +00001423 self.IssueConfigKey(), issue)
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001424 self.issue = issue
Edward Lemur125d60a2019-09-13 18:25:41 +00001425 codereview_server = self.GetCodereviewServer()
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001426 if codereview_server:
tandrii5d48c322016-08-18 16:19:37 -07001427 self._GitSetBranchConfigValue(
Edward Lemur125d60a2019-09-13 18:25:41 +00001428 self.CodereviewServerConfigKey(),
tandrii5d48c322016-08-18 16:19:37 -07001429 codereview_server)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001430 else:
tandrii5d48c322016-08-18 16:19:37 -07001431 # Reset all of these just to be clean.
1432 reset_suffixes = [
1433 'last-upload-hash',
Edward Lemur125d60a2019-09-13 18:25:41 +00001434 self.IssueConfigKey(),
1435 self.PatchsetConfigKey(),
1436 self.CodereviewServerConfigKey(),
tandrii5d48c322016-08-18 16:19:37 -07001437 ] + self._PostUnsetIssueProperties()
1438 for prop in reset_suffixes:
1439 self._GitSetBranchConfigValue(prop, None, error_ok=True)
Aaron Gableca01e2c2017-07-19 11:16:02 -07001440 msg = RunGit(['log', '-1', '--format=%B']).strip()
1441 if msg and git_footers.get_footer_change_id(msg):
1442 print('WARNING: The change patched into this branch has a Change-Id. '
1443 'Removing it.')
1444 RunGit(['commit', '--amend', '-m',
1445 git_footers.remove_footer(msg, 'Change-Id')])
Edward Lemurf38bc172019-09-03 21:02:13 +00001446 self.lookedup_issue = True
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001447 self.issue = None
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00001448 self.patchset = None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001449
dnjba1b0f32016-09-02 12:37:42 -07001450 def GetChange(self, upstream_branch, author, local_description=False):
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001451 if not self.GitSanityChecks(upstream_branch):
1452 DieWithError('\nGit sanity check failure')
1453
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00001454 root = settings.GetRelativeRoot()
bratell@opera.comf267b0e2013-05-02 09:11:43 +00001455 if not root:
1456 root = '.'
bauerb@chromium.org512f1ef2011-04-20 15:17:57 +00001457 absroot = os.path.abspath(root)
bauerb@chromium.org6fb99c62011-04-18 15:57:28 +00001458
1459 # We use the sha1 of HEAD as a name of this change.
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00001460 name = RunGitWithCode(['rev-parse', 'HEAD'])[1].strip()
bauerb@chromium.org512f1ef2011-04-20 15:17:57 +00001461 # Need to pass a relative path for msysgit.
maruel@chromium.org2b38e9c2011-10-19 00:04:35 +00001462 try:
maruel@chromium.org80a9ef12011-12-13 20:44:10 +00001463 files = scm.GIT.CaptureStatus([root], '.', upstream_branch)
maruel@chromium.org2b38e9c2011-10-19 00:04:35 +00001464 except subprocess2.CalledProcessError:
1465 DieWithError(
pgervais@chromium.orgd6617f32013-11-19 00:34:54 +00001466 ('\nFailed to diff against upstream branch %s\n\n'
maruel@chromium.org2b38e9c2011-10-19 00:04:35 +00001467 'This branch probably doesn\'t exist anymore. To reset the\n'
1468 'tracking branch, please run\n'
stip7a3dd352016-09-22 17:32:28 -07001469 ' git branch --set-upstream-to origin/master %s\n'
1470 'or replace origin/master with the relevant branch') %
maruel@chromium.org2b38e9c2011-10-19 00:04:35 +00001471 (upstream_branch, self.GetBranch()))
bauerb@chromium.org6fb99c62011-04-18 15:57:28 +00001472
maruel@chromium.org52424302012-08-29 15:14:30 +00001473 issue = self.GetIssue()
1474 patchset = self.GetPatchset()
dnjba1b0f32016-09-02 12:37:42 -07001475 if issue and not local_description:
bauerb@chromium.org6fb99c62011-04-18 15:57:28 +00001476 description = self.GetDescription()
1477 else:
1478 # If the change was never uploaded, use the log messages of all commits
1479 # up to the branch point, as git cl upload will prefill the description
1480 # with these log messages.
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00001481 args = ['log', '--pretty=format:%s%n%n%b', '%s...' % (upstream_branch)]
1482 description = RunGitWithCode(args)[1].strip()
maruel@chromium.org03b3bdc2011-06-14 13:04:12 +00001483
1484 if not author:
maruel@chromium.org13f623c2011-07-22 16:02:23 +00001485 author = RunGit(['config', 'user.email']).strip() or None
asvitkine@chromium.org15169952011-09-27 14:30:53 +00001486 return presubmit_support.GitChange(
bauerb@chromium.org6fb99c62011-04-18 15:57:28 +00001487 name,
1488 description,
1489 absroot,
1490 files,
1491 issue,
1492 patchset,
agable@chromium.orgea84ef12014-04-30 19:55:12 +00001493 author,
1494 upstream=upstream_branch)
bauerb@chromium.org6fb99c62011-04-18 15:57:28 +00001495
dsansomee2d6fd92016-09-08 00:10:47 -07001496 def UpdateDescription(self, description, force=False):
Edward Lemur125d60a2019-09-13 18:25:41 +00001497 self.UpdateDescriptionRemote(description, force=force)
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001498 self.description = description
Andrii Shyshkalov83051152017-02-07 23:47:29 +01001499 self.has_description = True
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001500
Robert Iannucci09f1f3d2017-03-28 16:54:32 -07001501 def UpdateDescriptionFooters(self, description_lines, footers, force=False):
1502 """Sets the description for this CL remotely.
1503
1504 You can get description_lines and footers with GetDescriptionFooters.
1505
1506 Args:
1507 description_lines (list(str)) - List of CL description lines without
1508 newline characters.
1509 footers (list(tuple(KEY, VALUE))) - List of footers, as returned by
1510 GetDescriptionFooters. Key must conform to the git footers format (i.e.
1511 `List-Of-Tokens`). It will be case-normalized so that each token is
1512 title-cased.
1513 """
1514 new_description = '\n'.join(description_lines)
1515 if footers:
1516 new_description += '\n'
1517 for k, v in footers:
1518 foot = '%s: %s' % (git_footers.normalize_name(k), v)
1519 if not git_footers.FOOTER_PATTERN.match(foot):
1520 raise ValueError('Invalid footer %r' % foot)
1521 new_description += foot + '\n'
1522 self.UpdateDescription(new_description, force)
1523
Edward Lesmes8e282792018-04-03 18:50:29 -04001524 def RunHook(self, committing, may_prompt, verbose, change, parallel):
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001525 """Calls sys.exit() if the hook fails; returns a HookResults otherwise."""
1526 try:
Edward Lemur2c48f242019-06-04 16:14:09 +00001527 start = time_time()
1528 result = presubmit_support.DoPresubmitChecks(change, committing,
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001529 verbose=verbose, output_stream=sys.stdout, input_stream=sys.stdin,
1530 default_presubmit=None, may_prompt=may_prompt,
Edward Lemur125d60a2019-09-13 18:25:41 +00001531 gerrit_obj=self.GetGerritObjForPresubmit(),
Edward Lesmes8e282792018-04-03 18:50:29 -04001532 parallel=parallel)
Edward Lemur2c48f242019-06-04 16:14:09 +00001533 metrics.collector.add_repeated('sub_commands', {
1534 'command': 'presubmit',
1535 'execution_time': time_time() - start,
1536 'exit_code': 0 if result.should_continue() else 1,
1537 })
1538 return result
vapierfd77ac72016-06-16 08:33:57 -07001539 except presubmit_support.PresubmitFailure as e:
Aaron Gable5d5f22c2018-02-02 09:12:41 -08001540 DieWithError('%s\nMaybe your depot_tools is out of date?' % e)
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001541
Edward Lemurf38bc172019-09-03 21:02:13 +00001542 def CMDPatchIssue(self, issue_arg, nocommit):
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001543 """Fetches and applies the issue patch from codereview to local branch."""
tandrii@chromium.orgef7c68c2016-04-07 09:39:39 +00001544 if isinstance(issue_arg, (int, long)) or issue_arg.isdigit():
1545 parsed_issue_arg = _ParsedIssueNumberArgument(int(issue_arg))
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001546 else:
1547 # Assume url.
Edward Lemur125d60a2019-09-13 18:25:41 +00001548 parsed_issue_arg = self.ParseIssueURL(
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001549 urlparse.urlparse(issue_arg))
1550 if not parsed_issue_arg or not parsed_issue_arg.valid:
1551 DieWithError('Failed to parse issue argument "%s". '
1552 'Must be an issue number or a valid URL.' % issue_arg)
Edward Lemur125d60a2019-09-13 18:25:41 +00001553 return self.CMDPatchWithParsedIssue(
Edward Lemurf38bc172019-09-03 21:02:13 +00001554 parsed_issue_arg, nocommit, False)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001555
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001556 def CMDUpload(self, options, git_diff_args, orig_args):
1557 """Uploads a change to codereview."""
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001558 custom_cl_base = None
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001559 if git_diff_args:
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001560 custom_cl_base = base_branch = git_diff_args[0]
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001561 else:
1562 if self.GetBranch() is None:
1563 DieWithError('Can\'t upload from detached HEAD state. Get on a branch!')
1564
1565 # Default to diffing against common ancestor of upstream branch
1566 base_branch = self.GetCommonAncestorWithUpstream()
1567 git_diff_args = [base_branch, 'HEAD']
1568
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001569 # Fast best-effort checks to abort before running potentially expensive
1570 # hooks if uploading is likely to fail anyway. Passing these checks does
1571 # not guarantee that uploading will not fail.
Edward Lemur125d60a2019-09-13 18:25:41 +00001572 self.EnsureAuthenticated(force=options.force)
1573 self.EnsureCanUploadPatchset(force=options.force)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001574
1575 # Apply watchlists on upload.
1576 change = self.GetChange(base_branch, None)
1577 watchlist = watchlists.Watchlists(change.RepositoryRoot())
1578 files = [f.LocalPath() for f in change.AffectedFiles()]
1579 if not options.bypass_watchlists:
Daniel Cheng7227d212017-11-17 08:12:37 -08001580 self.ExtendCC(watchlist.GetWatchersForPaths(files))
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001581
1582 if not options.bypass_hooks:
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001583 if options.reviewers or options.tbrs or options.add_owners_to:
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001584 # Set the reviewer list now so that presubmit checks can access it.
1585 change_description = ChangeDescription(change.FullDescriptionText())
1586 change_description.update_reviewers(options.reviewers,
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001587 options.tbrs,
Robert Iannuccif2708bd2017-04-17 15:49:02 -07001588 options.add_owners_to,
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001589 change)
1590 change.SetDescriptionText(change_description.description)
1591 hook_results = self.RunHook(committing=False,
Edward Lesmes8e282792018-04-03 18:50:29 -04001592 may_prompt=not options.force,
1593 verbose=options.verbose,
1594 change=change, parallel=options.parallel)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001595 if not hook_results.should_continue():
1596 return 1
1597 if not options.reviewers and hook_results.reviewers:
1598 options.reviewers = hook_results.reviewers.split(',')
Daniel Cheng7227d212017-11-17 08:12:37 -08001599 self.ExtendCC(hook_results.more_cc)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001600
Aaron Gable13101a62018-02-09 13:20:41 -08001601 print_stats(git_diff_args)
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001602 ret = self.CMDUploadChange(options, git_diff_args, custom_cl_base, change)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001603 if not ret:
tandrii5d48c322016-08-18 16:19:37 -07001604 _git_set_branch_config_value('last-upload-hash',
1605 RunGit(['rev-parse', 'HEAD']).strip())
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001606 # Run post upload hooks, if specified.
1607 if settings.GetRunPostUploadHook():
1608 presubmit_support.DoPostUploadExecuter(
1609 change,
1610 self,
1611 settings.GetRoot(),
1612 options.verbose,
1613 sys.stdout)
1614
1615 # Upload all dependencies if specified.
1616 if options.dependencies:
vapiera7fbd5a2016-06-16 09:17:49 -07001617 print()
1618 print('--dependencies has been specified.')
1619 print('All dependent local branches will be re-uploaded.')
1620 print()
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001621 # Remove the dependencies flag from args so that we do not end up in a
1622 # loop.
1623 orig_args.remove('--dependencies')
1624 ret = upload_branch_deps(self, orig_args)
1625 return ret
1626
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001627 def SetCQState(self, new_state):
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07001628 """Updates the CQ state for the latest patchset.
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001629
1630 Issue must have been already uploaded and known.
1631 """
1632 assert new_state in _CQState.ALL_STATES
1633 assert self.GetIssue()
qyearsley1fdfcb62016-10-24 13:22:03 -07001634 try:
Edward Lemur125d60a2019-09-13 18:25:41 +00001635 vote_map = {
1636 _CQState.NONE: 0,
1637 _CQState.DRY_RUN: 1,
1638 _CQState.COMMIT: 2,
1639 }
1640 labels = {'Commit-Queue': vote_map[new_state]}
1641 notify = False if new_state == _CQState.DRY_RUN else None
1642 gerrit_util.SetReview(
1643 self._GetGerritHost(), self._GerritChangeIdentifier(),
1644 labels=labels, notify=notify)
qyearsley1fdfcb62016-10-24 13:22:03 -07001645 return 0
1646 except KeyboardInterrupt:
1647 raise
1648 except:
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07001649 print('WARNING: Failed to %s.\n'
qyearsley1fdfcb62016-10-24 13:22:03 -07001650 'Either:\n'
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07001651 ' * Your project has no CQ,\n'
1652 ' * You don\'t have permission to change the CQ state,\n'
1653 ' * There\'s a bug in this code (see stack trace below).\n'
1654 'Consider specifying which bots to trigger manually or asking your '
1655 'project owners for permissions or contacting Chrome Infra at:\n'
1656 'https://www.chromium.org/infra\n\n' %
1657 ('cancel CQ' if new_state == _CQState.NONE else 'trigger CQ'))
qyearsley1fdfcb62016-10-24 13:22:03 -07001658 # Still raise exception so that stack trace is printed.
1659 raise
1660
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001661 def _GetGerritHost(self):
1662 # Lazy load of configs.
1663 self.GetCodereviewServer()
tandriie32e3ea2016-06-22 02:52:48 -07001664 if self._gerrit_host and '.' not in self._gerrit_host:
1665 # Abbreviated domain like "chromium" instead of chromium.googlesource.com.
1666 # This happens for internal stuff http://crbug.com/614312.
1667 parsed = urlparse.urlparse(self.GetRemoteUrl())
1668 if parsed.scheme == 'sso':
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001669 print('WARNING: using non-https URLs for remote is likely broken\n'
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001670 ' Your current remote is: %s' % self.GetRemoteUrl())
tandriie32e3ea2016-06-22 02:52:48 -07001671 self._gerrit_host = '%s.googlesource.com' % self._gerrit_host
1672 self._gerrit_server = 'https://%s' % self._gerrit_host
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001673 return self._gerrit_host
1674
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001675 def _GetGitHost(self):
1676 """Returns git host to be used when uploading change to Gerrit."""
Edward Lemur298f2cf2019-02-22 21:40:39 +00001677 remote_url = self.GetRemoteUrl()
1678 if not remote_url:
1679 return None
1680 return urlparse.urlparse(remote_url).netloc
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001681
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001682 def GetCodereviewServer(self):
1683 if not self._gerrit_server:
1684 # If we're on a branch then get the server potentially associated
1685 # with that branch.
1686 if self.GetIssue():
tandrii5d48c322016-08-18 16:19:37 -07001687 self._gerrit_server = self._GitGetBranchConfigValue(
1688 self.CodereviewServerConfigKey())
1689 if self._gerrit_server:
1690 self._gerrit_host = urlparse.urlparse(self._gerrit_server).netloc
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001691 if not self._gerrit_server:
1692 # We assume repo to be hosted on Gerrit, and hence Gerrit server
1693 # has "-review" suffix for lowest level subdomain.
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001694 parts = self._GetGitHost().split('.')
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001695 parts[0] = parts[0] + '-review'
1696 self._gerrit_host = '.'.join(parts)
1697 self._gerrit_server = 'https://%s' % self._gerrit_host
1698 return self._gerrit_server
1699
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00001700 def _GetGerritProject(self):
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001701 """Returns Gerrit project name based on remote git URL."""
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00001702 remote_url = self.GetRemoteUrl()
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001703 if remote_url is None:
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00001704 logging.warn('can\'t detect Gerrit project.')
1705 return None
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001706 project = urlparse.urlparse(remote_url).path.strip('/')
1707 if project.endswith('.git'):
1708 project = project[:-len('.git')]
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00001709 # *.googlesource.com hosts ensure that Git/Gerrit projects don't start with
1710 # 'a/' prefix, because 'a/' prefix is used to force authentication in
1711 # gitiles/git-over-https protocol. E.g.,
1712 # https://chromium.googlesource.com/a/v8/v8 refers to the same repo/project
1713 # as
1714 # https://chromium.googlesource.com/v8/v8
1715 if project.startswith('a/'):
1716 project = project[len('a/'):]
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001717 return project
1718
Andrii Shyshkalovd06cc782018-08-23 17:24:19 +00001719 def _GerritChangeIdentifier(self):
1720 """Handy method for gerrit_util.ChangeIdentifier for a given CL.
1721
1722 Not to be confused by value of "Change-Id:" footer.
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00001723 If Gerrit project can be determined, this will speed up Gerrit HTTP API RPC.
Andrii Shyshkalovd06cc782018-08-23 17:24:19 +00001724 """
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00001725 project = self._GetGerritProject()
1726 if project:
1727 return gerrit_util.ChangeIdentifier(project, self.GetIssue())
1728 # Fall back on still unique, but less efficient change number.
1729 return str(self.GetIssue())
Andrii Shyshkalovd06cc782018-08-23 17:24:19 +00001730
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001731 @classmethod
tandrii5d48c322016-08-18 16:19:37 -07001732 def IssueConfigKey(cls):
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001733 return 'gerritissue'
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001734
tandrii5d48c322016-08-18 16:19:37 -07001735 @classmethod
1736 def PatchsetConfigKey(cls):
1737 return 'gerritpatchset'
1738
1739 @classmethod
1740 def CodereviewServerConfigKey(cls):
1741 return 'gerritserver'
1742
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01001743 def EnsureAuthenticated(self, force, refresh=None):
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001744 """Best effort check that user is authenticated with Gerrit server."""
tandrii@chromium.org28253532016-04-14 13:46:56 +00001745 if settings.GetGerritSkipEnsureAuthenticated():
1746 # For projects with unusual authentication schemes.
1747 # See http://crbug.com/603378.
1748 return
Vadim Shtayurab250ec12018-10-04 00:21:08 +00001749
1750 # Check presence of cookies only if using cookies-based auth method.
1751 cookie_auth = gerrit_util.Authenticator.get()
1752 if not isinstance(cookie_auth, gerrit_util.CookiesAuthenticator):
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001753 return
Vadim Shtayurab250ec12018-10-04 00:21:08 +00001754
Daniel Chengcf6269b2019-05-18 01:02:12 +00001755 if urlparse.urlparse(self.GetRemoteUrl()).scheme != 'https':
1756 print('WARNING: Ignoring branch %s with non-https remote %s' %
Edward Lemur125d60a2019-09-13 18:25:41 +00001757 (self.branch, self.GetRemoteUrl()))
Daniel Chengcf6269b2019-05-18 01:02:12 +00001758 return
1759
Vadim Shtayurab250ec12018-10-04 00:21:08 +00001760 # Lazy-loader to identify Gerrit and Git hosts.
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001761 self.GetCodereviewServer()
1762 git_host = self._GetGitHost()
Edward Lemur298f2cf2019-02-22 21:40:39 +00001763 assert self._gerrit_server and self._gerrit_host and git_host
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001764
1765 gerrit_auth = cookie_auth.get_auth_header(self._gerrit_host)
1766 git_auth = cookie_auth.get_auth_header(git_host)
1767 if gerrit_auth and git_auth:
1768 if gerrit_auth == git_auth:
1769 return
Andrii Shyshkalov354e1d22017-06-09 19:31:33 +02001770 all_gsrc = cookie_auth.get_auth_header('d0esN0tEx1st.googlesource.com')
Raul Tambre80ee78e2019-05-06 22:41:05 +00001771 print(
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001772 'WARNING: You have different credentials for Gerrit and git hosts:\n'
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001773 ' %s\n'
1774 ' %s\n'
Andrii Shyshkalov51acef92017-04-11 17:19:59 +02001775 ' Consider running the following command:\n'
1776 ' git cl creds-check\n'
Andrii Shyshkalov354e1d22017-06-09 19:31:33 +02001777 ' %s\n'
Raul Tambre80ee78e2019-05-06 22:41:05 +00001778 ' %s' %
Andrii Shyshkalov51acef92017-04-11 17:19:59 +02001779 (git_host, self._gerrit_host,
Andrii Shyshkalov354e1d22017-06-09 19:31:33 +02001780 ('Hint: delete creds for .googlesource.com' if all_gsrc else ''),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001781 cookie_auth.get_new_password_message(git_host)))
1782 if not force:
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01001783 confirm_or_exit('If you know what you are doing', action='continue')
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001784 return
1785 else:
1786 missing = (
Anna Henningsen4e891442017-07-06 21:40:58 +02001787 ([] if gerrit_auth else [self._gerrit_host]) +
1788 ([] if git_auth else [git_host]))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001789 DieWithError('Credentials for the following hosts are required:\n'
1790 ' %s\n'
1791 'These are read from %s (or legacy %s)\n'
1792 '%s' % (
1793 '\n '.join(missing),
1794 cookie_auth.get_gitcookies_path(),
1795 cookie_auth.get_netrc_path(),
1796 cookie_auth.get_new_password_message(git_host)))
1797
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001798 def EnsureCanUploadPatchset(self, force):
Andrii Shyshkalov3e631422017-02-16 17:46:44 +01001799 if not self.GetIssue():
1800 return
1801
1802 # Warm change details cache now to avoid RPCs later, reducing latency for
1803 # developers.
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001804 self._GetChangeDetail(
Andrii Shyshkalovc4a73562018-09-25 18:40:17 +00001805 ['DETAILED_ACCOUNTS', 'CURRENT_REVISION', 'CURRENT_COMMIT', 'LABELS'])
Andrii Shyshkalov3e631422017-02-16 17:46:44 +01001806
1807 status = self._GetChangeDetail()['status']
1808 if status in ('MERGED', 'ABANDONED'):
1809 DieWithError('Change %s has been %s, new uploads are not allowed' %
1810 (self.GetIssueURL(),
1811 'submitted' if status == 'MERGED' else 'abandoned'))
1812
Vadim Shtayurab250ec12018-10-04 00:21:08 +00001813 # TODO(vadimsh): For some reason the chunk of code below was skipped if
1814 # 'is_gce' is True. I'm just refactoring it to be 'skip if not cookies'.
1815 # Apparently this check is not very important? Otherwise get_auth_email
1816 # could have been added to other implementations of Authenticator.
1817 cookies_auth = gerrit_util.Authenticator.get()
1818 if not isinstance(cookies_auth, gerrit_util.CookiesAuthenticator):
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001819 return
Vadim Shtayurab250ec12018-10-04 00:21:08 +00001820
1821 cookies_user = cookies_auth.get_auth_email(self._GetGerritHost())
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001822 if self.GetIssueOwner() == cookies_user:
1823 return
1824 logging.debug('change %s owner is %s, cookies user is %s',
1825 self.GetIssue(), self.GetIssueOwner(), cookies_user)
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001826 # Maybe user has linked accounts or something like that,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001827 # so ask what Gerrit thinks of this user.
1828 details = gerrit_util.GetAccountDetails(self._GetGerritHost(), 'self')
1829 if details['email'] == self.GetIssueOwner():
1830 return
1831 if not force:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001832 print('WARNING: Change %s is owned by %s, but you authenticate to Gerrit '
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001833 'as %s.\n'
1834 'Uploading may fail due to lack of permissions.' %
1835 (self.GetIssue(), self.GetIssueOwner(), details['email']))
1836 confirm_or_exit(action='upload')
1837
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00001838 def _PostUnsetIssueProperties(self):
1839 """Which branch-specific properties to erase when unsetting issue."""
tandrii5d48c322016-08-18 16:19:37 -07001840 return ['gerritsquashhash']
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00001841
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001842 def GetGerritObjForPresubmit(self):
1843 return presubmit_support.GerritAccessor(self._GetGerritHost())
1844
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001845 def GetStatus(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001846 """Applies a rough heuristic to give a simple summary of an issue's review
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001847 or CQ status, assuming adherence to a common workflow.
1848
1849 Returns None if no issue for this branch, or one of the following keywords:
Aaron Gable9ab38c62017-04-06 14:36:33 -07001850 * 'error' - error from review tool (including deleted issues)
1851 * 'unsent' - no reviewers added
1852 * 'waiting' - waiting for review
1853 * 'reply' - waiting for uploader to reply to review
1854 * 'lgtm' - Code-Review label has been set
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +00001855 * 'dry-run' - dry-running in the CQ
1856 * 'commit' - in the CQ
Aaron Gable9ab38c62017-04-06 14:36:33 -07001857 * 'closed' - successfully submitted or abandoned
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001858 """
1859 if not self.GetIssue():
1860 return None
1861
1862 try:
Aaron Gable9ab38c62017-04-06 14:36:33 -07001863 data = self._GetChangeDetail([
1864 'DETAILED_LABELS', 'CURRENT_REVISION', 'SUBMITTABLE'])
Aaron Gablea45ee112016-11-22 15:14:38 -08001865 except (httplib.HTTPException, GerritChangeNotExists):
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001866 return 'error'
1867
tandrii@chromium.org5e1bf382016-05-17 08:43:24 +00001868 if data['status'] in ('ABANDONED', 'MERGED'):
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001869 return 'closed'
1870
Andrii Shyshkalovb8268ca2019-04-03 23:33:44 +00001871 cq_label = data['labels'].get('Commit-Queue', {})
1872 max_cq_vote = 0
1873 for vote in cq_label.get('all', []):
1874 max_cq_vote = max(max_cq_vote, vote.get('value', 0))
1875 if max_cq_vote == 2:
Aaron Gable9ab38c62017-04-06 14:36:33 -07001876 return 'commit'
Andrii Shyshkalovb8268ca2019-04-03 23:33:44 +00001877 if max_cq_vote == 1:
1878 return 'dry-run'
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001879
Aaron Gable9ab38c62017-04-06 14:36:33 -07001880 if data['labels'].get('Code-Review', {}).get('approved'):
1881 return 'lgtm'
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001882
1883 if not data.get('reviewers', {}).get('REVIEWER', []):
1884 return 'unsent'
1885
Andrii Shyshkalov33e88a42017-01-27 14:45:30 +01001886 owner = data['owner'].get('_account_id')
Aaron Gable9ab38c62017-04-06 14:36:33 -07001887 messages = sorted(data.get('messages', []), key=lambda m: m.get('updated'))
1888 last_message_author = messages.pop().get('author', {})
1889 while last_message_author:
Andrii Shyshkalov33e88a42017-01-27 14:45:30 +01001890 if last_message_author.get('email') == COMMIT_BOT_EMAIL:
1891 # Ignore replies from CQ.
Aaron Gable9ab38c62017-04-06 14:36:33 -07001892 last_message_author = messages.pop().get('author', {})
Andrii Shyshkalov33e88a42017-01-27 14:45:30 +01001893 continue
Aaron Gable9ab38c62017-04-06 14:36:33 -07001894 if last_message_author.get('_account_id') == owner:
1895 # Most recent message was by owner.
1896 return 'waiting'
1897 else:
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001898 # Some reply from non-owner.
1899 return 'reply'
Aaron Gable9ab38c62017-04-06 14:36:33 -07001900
1901 # Somehow there are no messages even though there are reviewers.
1902 return 'unsent'
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001903
1904 def GetMostRecentPatchset(self):
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001905 data = self._GetChangeDetail(['CURRENT_REVISION'])
Aaron Gablee8856ee2017-12-07 12:41:46 -08001906 patchset = data['revisions'][data['current_revision']]['_number']
1907 self.SetPatchset(patchset)
1908 return patchset
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001909
Kenneth Russell61e2ed42017-02-15 11:47:13 -08001910 def FetchDescription(self, force=False):
1911 data = self._GetChangeDetail(['CURRENT_REVISION', 'CURRENT_COMMIT'],
1912 no_cache=force)
tandrii@chromium.org2d3da632016-04-25 19:23:27 +00001913 current_rev = data['current_revision']
Dan Beamcf6df902018-11-08 01:48:37 +00001914 return data['revisions'][current_rev]['commit']['message'].encode(
1915 'utf-8', 'ignore')
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001916
dsansomee2d6fd92016-09-08 00:10:47 -07001917 def UpdateDescriptionRemote(self, description, force=False):
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00001918 if gerrit_util.HasPendingChangeEdit(
1919 self._GetGerritHost(), self._GerritChangeIdentifier()):
dsansomee2d6fd92016-09-08 00:10:47 -07001920 if not force:
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01001921 confirm_or_exit(
dsansomee2d6fd92016-09-08 00:10:47 -07001922 'The description cannot be modified while the issue has a pending '
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01001923 'unpublished edit. Either publish the edit in the Gerrit web UI '
1924 'or delete it.\n\n', action='delete the unpublished edit')
dsansomee2d6fd92016-09-08 00:10:47 -07001925
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00001926 gerrit_util.DeletePendingChangeEdit(
1927 self._GetGerritHost(), self._GerritChangeIdentifier())
1928 gerrit_util.SetCommitMessage(
1929 self._GetGerritHost(), self._GerritChangeIdentifier(),
1930 description, notify='NONE')
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001931
Aaron Gable636b13f2017-07-14 10:42:48 -07001932 def AddComment(self, message, publish=None):
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00001933 gerrit_util.SetReview(
1934 self._GetGerritHost(), self._GerritChangeIdentifier(),
1935 msg=message, ready=publish)
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01001936
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001937 def GetCommentsSummary(self, readable=True):
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01001938 # DETAILED_ACCOUNTS is to get emails in accounts.
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001939 # CURRENT_REVISION is included to get the latest patchset so that
1940 # only the robot comments from the latest patchset can be shown.
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001941 messages = self._GetChangeDetail(
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001942 options=['MESSAGES', 'DETAILED_ACCOUNTS',
1943 'CURRENT_REVISION']).get('messages', [])
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001944 file_comments = gerrit_util.GetChangeComments(
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00001945 self._GetGerritHost(), self._GerritChangeIdentifier())
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001946 robot_file_comments = gerrit_util.GetChangeRobotComments(
1947 self._GetGerritHost(), self._GerritChangeIdentifier())
1948
1949 # Add the robot comments onto the list of comments, but only
1950 # keep those that are from the latest pachset.
1951 latest_patch_set = self.GetMostRecentPatchset()
1952 for path, robot_comments in robot_file_comments.iteritems():
1953 line_comments = file_comments.setdefault(path, [])
1954 line_comments.extend(
1955 [c for c in robot_comments if c['patch_set'] == latest_patch_set])
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001956
1957 # Build dictionary of file comments for easy access and sorting later.
1958 # {author+date: {path: {patchset: {line: url+message}}}}
1959 comments = collections.defaultdict(
1960 lambda: collections.defaultdict(lambda: collections.defaultdict(dict)))
1961 for path, line_comments in file_comments.iteritems():
1962 for comment in line_comments:
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001963 tag = comment.get('tag', '')
1964 if tag.startswith('autogenerated') and 'robot_id' not in comment:
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001965 continue
1966 key = (comment['author']['email'], comment['updated'])
1967 if comment.get('side', 'REVISION') == 'PARENT':
1968 patchset = 'Base'
1969 else:
1970 patchset = 'PS%d' % comment['patch_set']
1971 line = comment.get('line', 0)
1972 url = ('https://%s/c/%s/%s/%s#%s%s' %
1973 (self._GetGerritHost(), self.GetIssue(), comment['patch_set'], path,
1974 'b' if comment.get('side') == 'PARENT' else '',
1975 str(line) if line else ''))
1976 comments[key][path][patchset][line] = (url, comment['message'])
1977
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001978 summaries = []
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001979 for msg in messages:
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001980 summary = self._BuildCommentSummary(msg, comments, readable)
1981 if summary:
1982 summaries.append(summary)
1983 return summaries
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001984
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001985 @staticmethod
1986 def _BuildCommentSummary(msg, comments, readable):
1987 key = (msg['author']['email'], msg['date'])
1988 # Don't bother showing autogenerated messages that don't have associated
1989 # file or line comments. this will filter out most autogenerated
1990 # messages, but will keep robot comments like those from Tricium.
1991 is_autogenerated = msg.get('tag', '').startswith('autogenerated')
1992 if is_autogenerated and not comments.get(key):
1993 return None
1994 message = msg['message']
1995 # Gerrit spits out nanoseconds.
1996 assert len(msg['date'].split('.')[-1]) == 9
1997 date = datetime.datetime.strptime(msg['date'][:-3],
1998 '%Y-%m-%d %H:%M:%S.%f')
1999 if key in comments:
2000 message += '\n'
2001 for path, patchsets in sorted(comments.get(key, {}).items()):
2002 if readable:
2003 message += '\n%s' % path
2004 for patchset, lines in sorted(patchsets.items()):
2005 for line, (url, content) in sorted(lines.items()):
2006 if line:
2007 line_str = 'Line %d' % line
2008 path_str = '%s:%d:' % (path, line)
2009 else:
2010 line_str = 'File comment'
2011 path_str = '%s:0:' % path
2012 if readable:
2013 message += '\n %s, %s: %s' % (patchset, line_str, url)
2014 message += '\n %s\n' % content
2015 else:
2016 message += '\n%s ' % path_str
2017 message += '\n%s\n' % content
2018
2019 return _CommentSummary(
2020 date=date,
2021 message=message,
2022 sender=msg['author']['email'],
2023 autogenerated=is_autogenerated,
2024 # These could be inferred from the text messages and correlated with
2025 # Code-Review label maximum, however this is not reliable.
2026 # Leaving as is until the need arises.
2027 approval=False,
2028 disapproval=False,
2029 )
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01002030
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00002031 def CloseIssue(self):
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002032 gerrit_util.AbandonChange(
2033 self._GetGerritHost(), self._GerritChangeIdentifier(), msg='')
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00002034
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002035 def SubmitIssue(self, wait_for_merge=True):
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002036 gerrit_util.SubmitChange(
2037 self._GetGerritHost(), self._GerritChangeIdentifier(),
2038 wait_for_merge=wait_for_merge)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00002039
Andrii Shyshkalovb7214602018-08-22 23:20:26 +00002040 def _GetChangeDetail(self, options=None, no_cache=False):
2041 """Returns details of associated Gerrit change and caching results.
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002042
2043 If fresh data is needed, set no_cache=True which will clear cache and
2044 thus new data will be fetched from Gerrit.
2045 """
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002046 options = options or []
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002047 assert self.GetIssue(), 'issue is required to query Gerrit'
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002048
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01002049 # Optimization to avoid multiple RPCs:
2050 if (('CURRENT_REVISION' in options or 'ALL_REVISIONS' in options) and
2051 'CURRENT_COMMIT' not in options):
2052 options.append('CURRENT_COMMIT')
2053
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002054 # Normalize issue and options for consistent keys in cache.
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002055 cache_key = str(self.GetIssue())
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002056 options = [o.upper() for o in options]
2057
2058 # Check in cache first unless no_cache is True.
2059 if no_cache:
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002060 self._detail_cache.pop(cache_key, None)
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002061 else:
2062 options_set = frozenset(options)
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002063 for cached_options_set, data in self._detail_cache.get(cache_key, []):
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002064 # Assumption: data fetched before with extra options is suitable
2065 # for return for a smaller set of options.
2066 # For example, if we cached data for
2067 # options=[CURRENT_REVISION, DETAILED_FOOTERS]
2068 # and request is for options=[CURRENT_REVISION],
2069 # THEN we can return prior cached data.
2070 if options_set.issubset(cached_options_set):
2071 return data
2072
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01002073 try:
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002074 data = gerrit_util.GetChangeDetail(
2075 self._GetGerritHost(), self._GerritChangeIdentifier(), options)
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01002076 except gerrit_util.GerritError as e:
2077 if e.http_status == 404:
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002078 raise GerritChangeNotExists(self.GetIssue(), self.GetCodereviewServer())
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01002079 raise
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002080
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002081 self._detail_cache.setdefault(cache_key, []).append(
2082 (frozenset(options), data))
tandriic2405f52016-10-10 08:13:15 -07002083 return data
tandrii@chromium.org013a2802016-03-29 09:52:33 +00002084
Andrii Shyshkalovcc5f17e2018-08-22 23:35:59 +00002085 def _GetChangeCommit(self):
Andrii Shyshkalove2633162018-08-27 23:50:31 +00002086 assert self.GetIssue(), 'issue must be set to query Gerrit'
Aaron Gable6f5a8d92017-04-18 14:49:05 -07002087 try:
Andrii Shyshkalove2633162018-08-27 23:50:31 +00002088 data = gerrit_util.GetChangeCommit(
2089 self._GetGerritHost(), self._GerritChangeIdentifier())
Aaron Gable6f5a8d92017-04-18 14:49:05 -07002090 except gerrit_util.GerritError as e:
2091 if e.http_status == 404:
Andrii Shyshkalove2633162018-08-27 23:50:31 +00002092 raise GerritChangeNotExists(self.GetIssue(), self.GetCodereviewServer())
Aaron Gable6f5a8d92017-04-18 14:49:05 -07002093 raise
agable32978d92016-11-01 12:55:02 -07002094 return data
2095
Karen Qian40c19422019-03-13 21:28:29 +00002096 def _IsCqConfigured(self):
2097 detail = self._GetChangeDetail(['LABELS'])
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002098 if u'Commit-Queue' not in detail.get('labels', {}):
Karen Qian40c19422019-03-13 21:28:29 +00002099 return False
2100 # TODO(crbug/753213): Remove temporary hack
2101 if ('https://chromium.googlesource.com/chromium/src' ==
Edward Lemur125d60a2019-09-13 18:25:41 +00002102 self.GetRemoteUrl() and
Karen Qian40c19422019-03-13 21:28:29 +00002103 detail['branch'].startswith('refs/branch-heads/')):
2104 return False
2105 return True
2106
Olivier Robin75ee7252018-04-13 10:02:56 +02002107 def CMDLand(self, force, bypass_hooks, verbose, parallel):
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002108 if git_common.is_dirty_git_tree('land'):
2109 return 1
Karen Qian40c19422019-03-13 21:28:29 +00002110
tandriid60367b2016-06-22 05:25:12 -07002111 detail = self._GetChangeDetail(['CURRENT_REVISION', 'LABELS'])
Karen Qian40c19422019-03-13 21:28:29 +00002112 if not force and self._IsCqConfigured():
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +00002113 confirm_or_exit('\nIt seems this repository has a CQ, '
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002114 'which can test and land changes for you. '
2115 'Are you sure you wish to bypass it?\n',
2116 action='bypass CQ')
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002117 differs = True
tandriic4344b52016-08-29 06:04:54 -07002118 last_upload = self._GitGetBranchConfigValue('gerritsquashhash')
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002119 # Note: git diff outputs nothing if there is no diff.
2120 if not last_upload or RunGit(['diff', last_upload]).strip():
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002121 print('WARNING: Some changes from local branch haven\'t been uploaded.')
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002122 else:
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002123 if detail['current_revision'] == last_upload:
2124 differs = False
2125 else:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002126 print('WARNING: Local branch contents differ from latest uploaded '
2127 'patchset.')
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002128 if differs:
2129 if not force:
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002130 confirm_or_exit(
2131 'Do you want to submit latest Gerrit patchset and bypass hooks?\n',
2132 action='submit')
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002133 print('WARNING: Bypassing hooks and submitting latest uploaded patchset.')
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002134 elif not bypass_hooks:
2135 hook_results = self.RunHook(
2136 committing=True,
2137 may_prompt=not force,
2138 verbose=verbose,
Olivier Robin75ee7252018-04-13 10:02:56 +02002139 change=self.GetChange(self.GetCommonAncestorWithUpstream(), None),
2140 parallel=parallel)
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002141 if not hook_results.should_continue():
2142 return 1
2143
2144 self.SubmitIssue(wait_for_merge=True)
2145 print('Issue %s has been submitted.' % self.GetIssueURL())
agable32978d92016-11-01 12:55:02 -07002146 links = self._GetChangeCommit().get('web_links', [])
2147 for link in links:
Aaron Gable02cdbb42016-12-13 16:24:25 -08002148 if link.get('name') == 'gitiles' and link.get('url'):
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002149 print('Landed as: %s' % link.get('url'))
agable32978d92016-11-01 12:55:02 -07002150 break
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002151 return 0
2152
Edward Lemurf38bc172019-09-03 21:02:13 +00002153 def CMDPatchWithParsedIssue(self, parsed_issue_arg, nocommit, force):
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002154 assert parsed_issue_arg.valid
2155
Edward Lemur125d60a2019-09-13 18:25:41 +00002156 self.issue = parsed_issue_arg.issue
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002157
2158 if parsed_issue_arg.hostname:
2159 self._gerrit_host = parsed_issue_arg.hostname
2160 self._gerrit_server = 'https://%s' % self._gerrit_host
2161
tandriic2405f52016-10-10 08:13:15 -07002162 try:
2163 detail = self._GetChangeDetail(['ALL_REVISIONS'])
Aaron Gablea45ee112016-11-22 15:14:38 -08002164 except GerritChangeNotExists as e:
tandriic2405f52016-10-10 08:13:15 -07002165 DieWithError(str(e))
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002166
2167 if not parsed_issue_arg.patchset:
2168 # Use current revision by default.
2169 revision_info = detail['revisions'][detail['current_revision']]
2170 patchset = int(revision_info['_number'])
2171 else:
2172 patchset = parsed_issue_arg.patchset
2173 for revision_info in detail['revisions'].itervalues():
2174 if int(revision_info['_number']) == parsed_issue_arg.patchset:
2175 break
2176 else:
Aaron Gablea45ee112016-11-22 15:14:38 -08002177 DieWithError('Couldn\'t find patchset %i in change %i' %
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002178 (parsed_issue_arg.patchset, self.GetIssue()))
2179
Edward Lemur125d60a2019-09-13 18:25:41 +00002180 remote_url = self.GetRemoteUrl()
Aaron Gable697a91b2018-01-19 15:20:15 -08002181 if remote_url.endswith('.git'):
2182 remote_url = remote_url[:-len('.git')]
erikchen0d14d0d2018-08-28 18:57:09 +00002183 remote_url = remote_url.rstrip('/')
2184
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002185 fetch_info = revision_info['fetch']['http']
erikchen0d14d0d2018-08-28 18:57:09 +00002186 fetch_info['url'] = fetch_info['url'].rstrip('/')
Aaron Gable697a91b2018-01-19 15:20:15 -08002187
2188 if remote_url != fetch_info['url']:
2189 DieWithError('Trying to patch a change from %s but this repo appears '
2190 'to be %s.' % (fetch_info['url'], remote_url))
2191
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002192 RunGit(['fetch', fetch_info['url'], fetch_info['ref']])
Aaron Gable9387b4f2017-06-08 10:50:03 -07002193
Aaron Gable62619a32017-06-16 08:22:09 -07002194 if force:
2195 RunGit(['reset', '--hard', 'FETCH_HEAD'])
2196 print('Checked out commit for change %i patchset %i locally' %
2197 (parsed_issue_arg.issue, patchset))
Stefan Zager2d5f0392017-10-10 15:17:53 -07002198 elif nocommit:
2199 RunGit(['cherry-pick', '--no-commit', 'FETCH_HEAD'])
2200 print('Patch applied to index.')
Aaron Gable62619a32017-06-16 08:22:09 -07002201 else:
Aaron Gable9387b4f2017-06-08 10:50:03 -07002202 RunGit(['cherry-pick', 'FETCH_HEAD'])
2203 print('Committed patch for change %i patchset %i locally.' %
Aaron Gable62619a32017-06-16 08:22:09 -07002204 (parsed_issue_arg.issue, patchset))
2205 print('Note: this created a local commit which does not have '
2206 'the same hash as the one uploaded for review. This will make '
2207 'uploading changes based on top of this branch difficult.\n'
2208 'If you want to do that, use "git cl patch --force" instead.')
2209
Stefan Zagerd08043c2017-10-12 12:07:02 -07002210 if self.GetBranch():
2211 self.SetIssue(parsed_issue_arg.issue)
2212 self.SetPatchset(patchset)
2213 fetched_hash = RunGit(['rev-parse', 'FETCH_HEAD']).strip()
2214 self._GitSetBranchConfigValue('last-upload-hash', fetched_hash)
2215 self._GitSetBranchConfigValue('gerritsquashhash', fetched_hash)
2216 else:
2217 print('WARNING: You are in detached HEAD state.\n'
2218 'The patch has been applied to your checkout, but you will not be '
2219 'able to upload a new patch set to the gerrit issue.\n'
2220 'Try using the \'-b\' option if you would like to work on a '
2221 'branch and/or upload a new patch set.')
2222
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002223 return 0
2224
2225 @staticmethod
2226 def ParseIssueURL(parsed_url):
2227 if not parsed_url.scheme or not parsed_url.scheme.startswith('http'):
2228 return None
Aaron Gable01b91062017-08-24 17:48:40 -07002229 # Gerrit's new UI is https://domain/c/project/+/<issue_number>[/[patchset]]
2230 # But old GWT UI is https://domain/#/c/project/+/<issue_number>[/[patchset]]
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002231 # Short urls like https://domain/<issue_number> can be used, but don't allow
2232 # specifying the patchset (you'd 404), but we allow that here.
2233 if parsed_url.path == '/':
2234 part = parsed_url.fragment
2235 else:
2236 part = parsed_url.path
Bruce Dawson9c062012019-05-02 19:20:28 +00002237 match = re.match(r'(/c(/.*/\+)?)?/(\d+)(/(\d+)?/?)?$', part)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002238 if match:
2239 return _ParsedIssueNumberArgument(
Aaron Gable01b91062017-08-24 17:48:40 -07002240 issue=int(match.group(3)),
2241 patchset=int(match.group(5)) if match.group(5) else None,
Edward Lemurf38bc172019-09-03 21:02:13 +00002242 hostname=parsed_url.netloc)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002243 return None
2244
tandrii16e0b4e2016-06-07 10:34:28 -07002245 def _GerritCommitMsgHookCheck(self, offer_removal):
2246 hook = os.path.join(settings.GetRoot(), '.git', 'hooks', 'commit-msg')
2247 if not os.path.exists(hook):
2248 return
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002249 # Crude attempt to distinguish Gerrit Codereview hook from a potentially
2250 # custom developer-made one.
tandrii16e0b4e2016-06-07 10:34:28 -07002251 data = gclient_utils.FileRead(hook)
2252 if not('From Gerrit Code Review' in data and 'add_ChangeId()' in data):
2253 return
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002254 print('WARNING: You have Gerrit commit-msg hook installed.\n'
qyearsley12fa6ff2016-08-24 09:18:40 -07002255 'It is not necessary for uploading with git cl in squash mode, '
tandrii16e0b4e2016-06-07 10:34:28 -07002256 'and may interfere with it in subtle ways.\n'
2257 'We recommend you remove the commit-msg hook.')
2258 if offer_removal:
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002259 if ask_for_explicit_yes('Do you want to remove it now?'):
tandrii16e0b4e2016-06-07 10:34:28 -07002260 gclient_utils.rm_file_or_tree(hook)
2261 print('Gerrit commit-msg hook removed.')
2262 else:
2263 print('OK, will keep Gerrit commit-msg hook in place.')
2264
Edward Lemur1b52d872019-05-09 21:12:12 +00002265 def _CleanUpOldTraces(self):
2266 """Keep only the last |MAX_TRACES| traces."""
2267 try:
2268 traces = sorted([
2269 os.path.join(TRACES_DIR, f)
2270 for f in os.listdir(TRACES_DIR)
2271 if (os.path.isfile(os.path.join(TRACES_DIR, f))
2272 and not f.startswith('tmp'))
2273 ])
2274 traces_to_delete = traces[:-MAX_TRACES]
2275 for trace in traces_to_delete:
Daniel Chengcf6269b2019-05-18 01:02:12 +00002276 os.remove(trace)
Edward Lemur1b52d872019-05-09 21:12:12 +00002277 except OSError:
2278 print('WARNING: Failed to remove old git traces from\n'
2279 ' %s'
2280 'Consider removing them manually.' % TRACES_DIR)
Edward Lemurdc8e23d2019-05-07 00:45:48 +00002281
Edward Lemur5737f022019-05-17 01:24:00 +00002282 def _WriteGitPushTraces(self, trace_name, traces_dir, git_push_metadata):
Edward Lemur1b52d872019-05-09 21:12:12 +00002283 """Zip and write the git push traces stored in traces_dir."""
2284 gclient_utils.safe_makedirs(TRACES_DIR)
Edward Lemur1b52d872019-05-09 21:12:12 +00002285 traces_zip = trace_name + '-traces'
2286 traces_readme = trace_name + '-README'
Michael Mosse7f0b4c2019-05-08 04:36:24 +00002287 # Create a temporary dir to store git config and gitcookies in. It will be
2288 # compressed and stored next to the traces.
2289 git_info_dir = tempfile.mkdtemp()
Edward Lemur1b52d872019-05-09 21:12:12 +00002290 git_info_zip = trace_name + '-git-info'
2291
Edward Lemur5737f022019-05-17 01:24:00 +00002292 git_push_metadata['now'] = datetime_now().strftime('%c')
Eric Boren67c48202019-05-30 16:52:51 +00002293 if sys.stdin.encoding and sys.stdin.encoding != 'utf-8':
sangwoo.ko7a614332019-05-22 02:46:19 +00002294 git_push_metadata['now'] = git_push_metadata['now'].decode(
2295 sys.stdin.encoding)
2296
Edward Lemur1b52d872019-05-09 21:12:12 +00002297 git_push_metadata['trace_name'] = trace_name
2298 gclient_utils.FileWrite(
2299 traces_readme, TRACES_README_FORMAT % git_push_metadata)
2300
2301 # Keep only the first 6 characters of the git hashes on the packet
2302 # trace. This greatly decreases size after compression.
2303 packet_traces = os.path.join(traces_dir, 'trace-packet')
2304 if os.path.isfile(packet_traces):
2305 contents = gclient_utils.FileRead(packet_traces)
2306 gclient_utils.FileWrite(
2307 packet_traces, GIT_HASH_RE.sub(r'\1', contents))
2308 shutil.make_archive(traces_zip, 'zip', traces_dir)
2309
2310 # Collect and compress the git config and gitcookies.
2311 git_config = RunGit(['config', '-l'])
2312 gclient_utils.FileWrite(
2313 os.path.join(git_info_dir, 'git-config'),
2314 git_config)
2315
2316 cookie_auth = gerrit_util.Authenticator.get()
2317 if isinstance(cookie_auth, gerrit_util.CookiesAuthenticator):
2318 gitcookies_path = cookie_auth.get_gitcookies_path()
2319 if os.path.isfile(gitcookies_path):
2320 gitcookies = gclient_utils.FileRead(gitcookies_path)
2321 gclient_utils.FileWrite(
2322 os.path.join(git_info_dir, 'gitcookies'),
2323 GITCOOKIES_REDACT_RE.sub('REDACTED', gitcookies))
2324 shutil.make_archive(git_info_zip, 'zip', git_info_dir)
2325
Edward Lemur1b52d872019-05-09 21:12:12 +00002326 gclient_utils.rmtree(git_info_dir)
2327
2328 def _RunGitPushWithTraces(
2329 self, change_desc, refspec, refspec_opts, git_push_metadata):
2330 """Run git push and collect the traces resulting from the execution."""
2331 # Create a temporary directory to store traces in. Traces will be compressed
2332 # and stored in a 'traces' dir inside depot_tools.
2333 traces_dir = tempfile.mkdtemp()
Edward Lemur5737f022019-05-17 01:24:00 +00002334 trace_name = os.path.join(
2335 TRACES_DIR, datetime_now().strftime('%Y%m%dT%H%M%S.%f'))
Edward Lemur0f58ae42019-04-30 17:24:12 +00002336
2337 env = os.environ.copy()
2338 env['GIT_REDACT_COOKIES'] = 'o,SSO,GSSO_Uberproxy'
2339 env['GIT_TR2_EVENT'] = os.path.join(traces_dir, 'tr2-event')
Jonathan Nieder9779b142019-05-29 23:19:29 +00002340 env['GIT_TRACE2_EVENT'] = os.path.join(traces_dir, 'tr2-event')
Edward Lemur0f58ae42019-04-30 17:24:12 +00002341 env['GIT_TRACE_CURL'] = os.path.join(traces_dir, 'trace-curl')
2342 env['GIT_TRACE_CURL_NO_DATA'] = '1'
2343 env['GIT_TRACE_PACKET'] = os.path.join(traces_dir, 'trace-packet')
2344
2345 try:
2346 push_returncode = 0
Edward Lemur1b52d872019-05-09 21:12:12 +00002347 remote_url = self.GetRemoteUrl()
Edward Lemur0f58ae42019-04-30 17:24:12 +00002348 before_push = time_time()
2349 push_stdout = gclient_utils.CheckCallAndFilter(
Edward Lemur1b52d872019-05-09 21:12:12 +00002350 ['git', 'push', remote_url, refspec],
Edward Lemur0f58ae42019-04-30 17:24:12 +00002351 env=env,
2352 print_stdout=True,
2353 # Flush after every line: useful for seeing progress when running as
2354 # recipe.
2355 filter_fn=lambda _: sys.stdout.flush())
2356 except subprocess2.CalledProcessError as e:
2357 push_returncode = e.returncode
2358 DieWithError('Failed to create a change. Please examine output above '
2359 'for the reason of the failure.\n'
2360 'Hint: run command below to diagnose common Git/Gerrit '
2361 'credential problems:\n'
Edward Lemur5737f022019-05-17 01:24:00 +00002362 ' git cl creds-check\n'
2363 '\n'
2364 'If git-cl is not working correctly, file a bug under the '
2365 'Infra>SDK component including the files below.\n'
2366 'Review the files before upload, since they might contain '
2367 'sensitive information.\n'
2368 'Set the Restrict-View-Google label so that they are not '
2369 'publicly accessible.\n'
2370 + TRACES_MESSAGE % {'trace_name': trace_name},
Edward Lemur0f58ae42019-04-30 17:24:12 +00002371 change_desc)
2372 finally:
2373 execution_time = time_time() - before_push
2374 metrics.collector.add_repeated('sub_commands', {
2375 'command': 'git push',
2376 'execution_time': execution_time,
2377 'exit_code': push_returncode,
2378 'arguments': metrics_utils.extract_known_subcommand_args(refspec_opts),
2379 })
2380
Edward Lemur1b52d872019-05-09 21:12:12 +00002381 git_push_metadata['execution_time'] = execution_time
2382 git_push_metadata['exit_code'] = push_returncode
Edward Lemur5737f022019-05-17 01:24:00 +00002383 self._WriteGitPushTraces(trace_name, traces_dir, git_push_metadata)
Edward Lemur0f58ae42019-04-30 17:24:12 +00002384
Edward Lemur1b52d872019-05-09 21:12:12 +00002385 self._CleanUpOldTraces()
Edward Lemur0f58ae42019-04-30 17:24:12 +00002386 gclient_utils.rmtree(traces_dir)
2387
2388 return push_stdout
2389
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002390 def CMDUploadChange(self, options, git_diff_args, custom_cl_base, change):
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002391 """Upload the current branch to Gerrit."""
Mike Frysingera989d552019-08-14 20:51:23 +00002392 if options.squash is None:
tandriia60502f2016-06-20 02:01:53 -07002393 # Load default for user, repo, squash=true, in this order.
2394 options.squash = settings.GetSquashGerritUploads()
tandrii26f3e4e2016-06-10 08:37:04 -07002395
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002396 remote, remote_branch = self.GetRemoteBranch()
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01002397 branch = GetTargetRef(remote, remote_branch, options.target_branch)
Aaron Gableb56ad332017-01-06 15:24:31 -08002398 # This may be None; default fallback value is determined in logic below.
2399 title = options.title
2400
Dominic Battre7d1c4842017-10-27 09:17:28 +02002401 # Extract bug number from branch name.
2402 bug = options.bug
2403 match = re.match(r'(?:bug|fix)[_-]?(\d+)', self.GetBranch())
2404 if not bug and match:
2405 bug = match.group(1)
2406
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002407 if options.squash:
tandrii16e0b4e2016-06-07 10:34:28 -07002408 self._GerritCommitMsgHookCheck(offer_removal=not options.force)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002409 if self.GetIssue():
2410 # Try to get the message from a previous upload.
2411 message = self.GetDescription()
2412 if not message:
2413 DieWithError(
Aaron Gablea45ee112016-11-22 15:14:38 -08002414 'failed to fetch description from current Gerrit change %d\n'
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002415 '%s' % (self.GetIssue(), self.GetIssueURL()))
Aaron Gableb56ad332017-01-06 15:24:31 -08002416 if not title:
Andrii Shyshkalov2d8a2072017-04-10 15:02:18 +02002417 if options.message:
Aaron Gable7303dcb2017-06-07 14:17:32 -07002418 # When uploading a subsequent patchset, -m|--message is taken
2419 # as the patchset title if --title was not provided.
2420 title = options.message.strip()
Andrii Shyshkalov2d8a2072017-04-10 15:02:18 +02002421 else:
2422 default_title = RunGit(
2423 ['show', '-s', '--format=%s', 'HEAD']).strip()
Aaron Gable7303dcb2017-06-07 14:17:32 -07002424 if options.force:
2425 title = default_title
2426 else:
2427 title = ask_for_data(
2428 'Title for patchset [%s]: ' % default_title) or default_title
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002429 change_id = self._GetChangeDetail()['change_id']
2430 while True:
2431 footer_change_ids = git_footers.get_footer_change_id(message)
2432 if footer_change_ids == [change_id]:
2433 break
2434 if not footer_change_ids:
2435 message = git_footers.add_footer_change_id(message, change_id)
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002436 print('WARNING: appended missing Change-Id to change description.')
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002437 continue
2438 # There is already a valid footer but with different or several ids.
2439 # Doing this automatically is non-trivial as we don't want to lose
2440 # existing other footers, yet we want to append just 1 desired
2441 # Change-Id. Thus, just create a new footer, but let user verify the
2442 # new description.
2443 message = '%s\n\nChange-Id: %s' % (message, change_id)
Anthony Polito8b955342019-09-24 19:01:36 +00002444 change_desc = ChangeDescription(message, bug=bug)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002445 if not options.force:
Anthony Polito8b955342019-09-24 19:01:36 +00002446 print(
2447 'WARNING: change %s has Change-Id footer(s):\n'
2448 ' %s\n'
2449 'but change has Change-Id %s, according to Gerrit.\n'
2450 'Please, check the proposed correction to the description, '
2451 'and edit it if necessary but keep the "Change-Id: %s" footer\n'
2452 % (self.GetIssue(), '\n '.join(footer_change_ids), change_id,
2453 change_id))
2454 confirm_or_exit(action='edit')
2455 change_desc.prompt()
2456
2457 message = change_desc.description
2458 if not message:
2459 DieWithError("Description is empty. Aborting...")
2460
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002461 # Continue the while loop.
2462 # Sanity check of this code - we should end up with proper message
2463 # footer.
2464 assert [change_id] == git_footers.get_footer_change_id(message)
Anthony Polito8b955342019-09-24 19:01:36 +00002465 change_desc = ChangeDescription(message, bug=bug)
Aaron Gableb56ad332017-01-06 15:24:31 -08002466 else: # if not self.GetIssue()
2467 if options.message:
2468 message = options.message
2469 else:
Andrii Shyshkalovb07575f2018-10-16 06:16:21 +00002470 message = _create_description_from_log(git_diff_args)
Aaron Gableb56ad332017-01-06 15:24:31 -08002471 if options.title:
2472 message = options.title + '\n\n' + message
Anthony Polito8b955342019-09-24 19:01:36 +00002473 change_desc = ChangeDescription(message, bug=bug)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002474 if not options.force:
Anthony Polito8b955342019-09-24 19:01:36 +00002475 change_desc.prompt()
2476
Aaron Gableb56ad332017-01-06 15:24:31 -08002477 # On first upload, patchset title is always this string, while
2478 # --title flag gets converted to first line of message.
2479 title = 'Initial upload'
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002480 if not change_desc.description:
2481 DieWithError("Description is empty. Aborting...")
Andrii Shyshkalov8c90d032017-04-19 21:27:26 +02002482 change_ids = git_footers.get_footer_change_id(change_desc.description)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002483 if len(change_ids) > 1:
2484 DieWithError('too many Change-Id footers, at most 1 allowed.')
2485 if not change_ids:
2486 # Generate the Change-Id automatically.
Andrii Shyshkalov8c90d032017-04-19 21:27:26 +02002487 change_desc.set_description(git_footers.add_footer_change_id(
2488 change_desc.description,
2489 GenerateGerritChangeId(change_desc.description)))
2490 change_ids = git_footers.get_footer_change_id(change_desc.description)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002491 assert len(change_ids) == 1
2492 change_id = change_ids[0]
2493
Robert Iannuccidb02dd02017-04-19 12:18:20 -07002494 if options.reviewers or options.tbrs or options.add_owners_to:
2495 change_desc.update_reviewers(options.reviewers, options.tbrs,
2496 options.add_owners_to, change)
Andrii Shyshkalov71f0da32019-07-15 22:45:18 +00002497 if options.preserve_tryjobs:
2498 change_desc.set_preserve_tryjobs()
Robert Iannuccidb02dd02017-04-19 12:18:20 -07002499
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002500 remote, upstream_branch = self.FetchUpstreamTuple(self.GetBranch())
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002501 parent = self._ComputeParent(remote, upstream_branch, custom_cl_base,
2502 options.force, change_desc)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002503 tree = RunGit(['rev-parse', 'HEAD:']).strip()
Aaron Gable9a03ae02017-11-03 11:31:07 -07002504 with tempfile.NamedTemporaryFile(delete=False) as desc_tempfile:
2505 desc_tempfile.write(change_desc.description)
2506 desc_tempfile.close()
2507 ref_to_push = RunGit(['commit-tree', tree, '-p', parent,
2508 '-F', desc_tempfile.name]).strip()
2509 os.remove(desc_tempfile.name)
Anthony Polito8b955342019-09-24 19:01:36 +00002510 else: # if not options.squash
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002511 change_desc = ChangeDescription(
Andrii Shyshkalovb07575f2018-10-16 06:16:21 +00002512 options.message or _create_description_from_log(git_diff_args))
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002513 if not change_desc.description:
2514 DieWithError("Description is empty. Aborting...")
2515
2516 if not git_footers.get_footer_change_id(change_desc.description):
2517 DownloadGerritHook(False)
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002518 change_desc.set_description(
2519 self._AddChangeIdToCommitMessage(options, git_diff_args))
Robert Iannuccidb02dd02017-04-19 12:18:20 -07002520 if options.reviewers or options.tbrs or options.add_owners_to:
2521 change_desc.update_reviewers(options.reviewers, options.tbrs,
2522 options.add_owners_to, change)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002523 ref_to_push = 'HEAD'
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002524 # For no-squash mode, we assume the remote called "origin" is the one we
2525 # want. It is not worthwhile to support different workflows for
2526 # no-squash mode.
2527 parent = 'origin/%s' % branch
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002528 change_id = git_footers.get_footer_change_id(change_desc.description)[0]
2529
2530 assert change_desc
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +00002531 SaveDescriptionBackup(change_desc)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002532 commits = RunGitSilent(['rev-list', '%s..%s' % (parent,
2533 ref_to_push)]).splitlines()
2534 if len(commits) > 1:
2535 print('WARNING: This will upload %d commits. Run the following command '
2536 'to see which commits will be uploaded: ' % len(commits))
2537 print('git log %s..%s' % (parent, ref_to_push))
2538 print('You can also use `git squash-branch` to squash these into a '
2539 'single commit.')
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002540 confirm_or_exit(action='upload')
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002541
Aaron Gable6dadfbf2017-05-09 14:27:58 -07002542 if options.reviewers or options.tbrs or options.add_owners_to:
2543 change_desc.update_reviewers(options.reviewers, options.tbrs,
2544 options.add_owners_to, change)
2545
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00002546 reviewers = sorted(change_desc.get_reviewers())
Edward Lemur4508b422019-10-03 21:56:35 +00002547 cc = []
2548 # Add CCs from WATCHLISTS and rietveld.cc git config unless this is
2549 # the initial upload, the CL is private, or auto-CCing has ben disabled.
2550 if not (self.GetIssue() or options.private or options.no_autocc):
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00002551 cc = self.GetCCList().split(',')
Edward Lemur4508b422019-10-03 21:56:35 +00002552 # Add cc's from the --cc flag.
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00002553 if options.cc:
2554 cc.extend(options.cc)
2555 cc = filter(None, [email.strip() for email in cc])
2556 if change_desc.get_cced():
2557 cc.extend(change_desc.get_cced())
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00002558 if self._GetGerritHost() == 'chromium-review.googlesource.com':
2559 valid_accounts = set(reviewers + cc)
2560 # TODO(crbug/877717): relax this for all hosts.
2561 else:
2562 valid_accounts = gerrit_util.ValidAccounts(
2563 self._GetGerritHost(), reviewers + cc)
Andrii Shyshkalovf170af42018-10-30 07:00:44 +00002564 logging.info('accounts %s are recognized, %s invalid',
2565 sorted(valid_accounts),
2566 set(reviewers + cc).difference(set(valid_accounts)))
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00002567
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00002568 # Extra options that can be specified at push time. Doc:
2569 # https://gerrit-review.googlesource.com/Documentation/user-upload.html
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00002570 refspec_opts = []
Andrii Shyshkalov2d8a2072017-04-10 15:02:18 +02002571
Aaron Gable844cf292017-06-28 11:32:59 -07002572 # By default, new changes are started in WIP mode, and subsequent patchsets
2573 # don't send email. At any time, passing --send-mail will mark the change
2574 # ready and send email for that particular patch.
Aaron Gableafd52772017-06-27 16:40:10 -07002575 if options.send_mail:
2576 refspec_opts.append('ready')
Aaron Gable844cf292017-06-28 11:32:59 -07002577 refspec_opts.append('notify=ALL')
Jamie Madill276da0b2018-04-27 14:41:20 -04002578 elif not self.GetIssue() and options.squash:
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08002579 refspec_opts.append('wip')
Aaron Gableafd52772017-06-27 16:40:10 -07002580 else:
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08002581 refspec_opts.append('notify=NONE')
Aaron Gable70f4e242017-06-26 10:45:59 -07002582
Andrii Shyshkalov2d8a2072017-04-10 15:02:18 +02002583 # TODO(tandrii): options.message should be posted as a comment
Aaron Gablee5adf612017-07-14 10:43:58 -07002584 # if --send-mail is set on non-initial upload as Rietveld used to do it.
Andrii Shyshkalov2d8a2072017-04-10 15:02:18 +02002585
Aaron Gable9b713dd2016-12-14 16:04:21 -08002586 if title:
Nick Carter8692b182017-11-06 16:30:38 -08002587 # Punctuation and whitespace in |title| must be percent-encoded.
2588 refspec_opts.append('m=' + gerrit_util.PercentEncodeForGitRef(title))
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00002589
agablec6787972016-09-09 16:13:34 -07002590 if options.private:
Aaron Gableb02daf02017-05-23 11:53:46 -07002591 refspec_opts.append('private')
agablec6787972016-09-09 16:13:34 -07002592
Andrii Shyshkalov2f727912018-10-15 17:02:33 +00002593 for r in sorted(reviewers):
2594 if r in valid_accounts:
2595 refspec_opts.append('r=%s' % r)
2596 reviewers.remove(r)
2597 else:
2598 # TODO(tandrii): this should probably be a hard failure.
2599 print('WARNING: reviewer %s doesn\'t have a Gerrit account, skipping'
2600 % r)
2601 for c in sorted(cc):
2602 # refspec option will be rejected if cc doesn't correspond to an
2603 # account, even though REST call to add such arbitrary cc may succeed.
2604 if c in valid_accounts:
2605 refspec_opts.append('cc=%s' % c)
2606 cc.remove(c)
2607
rmistry9eadede2016-09-19 11:22:43 -07002608 if options.topic:
2609 # Documentation on Gerrit topics is here:
2610 # https://gerrit-review.googlesource.com/Documentation/user-upload.html#topic
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00002611 refspec_opts.append('topic=%s' % options.topic)
rmistry9eadede2016-09-19 11:22:43 -07002612
Edward Lemur687ca902018-12-05 02:30:30 +00002613 if options.enable_auto_submit:
2614 refspec_opts.append('l=Auto-Submit+1')
2615 if options.use_commit_queue:
2616 refspec_opts.append('l=Commit-Queue+2')
2617 elif options.cq_dry_run:
2618 refspec_opts.append('l=Commit-Queue+1')
2619
2620 if change_desc.get_reviewers(tbr_only=True):
2621 score = gerrit_util.GetCodeReviewTbrScore(
2622 self._GetGerritHost(),
2623 self._GetGerritProject())
2624 refspec_opts.append('l=Code-Review+%s' % score)
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00002625
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08002626 # Gerrit sorts hashtags, so order is not important.
Nodir Turakulov23b82142017-11-16 11:04:25 -08002627 hashtags = {change_desc.sanitize_hash_tag(t) for t in options.hashtags}
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08002628 if not self.GetIssue():
Nodir Turakulov23b82142017-11-16 11:04:25 -08002629 hashtags.update(change_desc.get_hash_tags())
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08002630 refspec_opts += ['hashtag=%s' % t for t in sorted(hashtags)]
2631
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00002632 refspec_suffix = ''
2633 if refspec_opts:
2634 refspec_suffix = '%' + ','.join(refspec_opts)
2635 assert ' ' not in refspec_suffix, (
2636 'spaces not allowed in refspec: "%s"' % refspec_suffix)
2637 refspec = '%s:refs/for/%s%s' % (ref_to_push, branch, refspec_suffix)
2638
Edward Lemur1b52d872019-05-09 21:12:12 +00002639 git_push_metadata = {
2640 'gerrit_host': self._GetGerritHost(),
2641 'title': title or '<untitled>',
2642 'change_id': change_id,
2643 'description': change_desc.description,
2644 }
2645 push_stdout = self._RunGitPushWithTraces(
2646 change_desc, refspec, refspec_opts, git_push_metadata)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002647
2648 if options.squash:
Aaron Gable289b4312017-09-13 14:06:16 -07002649 regex = re.compile(r'remote:\s+https?://[\w\-\.\+\/#]*/(\d+)\s.*')
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002650 change_numbers = [m.group(1)
2651 for m in map(regex.match, push_stdout.splitlines())
2652 if m]
2653 if len(change_numbers) != 1:
2654 DieWithError(
2655 ('Created|Updated %d issues on Gerrit, but only 1 expected.\n'
Christopher Lamf732cd52017-01-24 12:40:11 +11002656 'Change-Id: %s') % (len(change_numbers), change_id), change_desc)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002657 self.SetIssue(change_numbers[0])
tandrii5d48c322016-08-18 16:19:37 -07002658 self._GitSetBranchConfigValue('gerritsquashhash', ref_to_push)
tandrii88189772016-09-29 04:29:57 -07002659
Andrii Shyshkalov2f727912018-10-15 17:02:33 +00002660 if self.GetIssue() and (reviewers or cc):
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00002661 # GetIssue() is not set in case of non-squash uploads according to tests.
2662 # TODO(agable): non-squash uploads in git cl should be removed.
2663 gerrit_util.AddReviewers(
2664 self._GetGerritHost(),
Andrii Shyshkalovd06cc782018-08-23 17:24:19 +00002665 self._GerritChangeIdentifier(),
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00002666 reviewers, cc,
2667 notify=bool(options.send_mail))
Aaron Gable6dadfbf2017-05-09 14:27:58 -07002668
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002669 return 0
2670
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002671 def _ComputeParent(self, remote, upstream_branch, custom_cl_base, force,
2672 change_desc):
2673 """Computes parent of the generated commit to be uploaded to Gerrit.
2674
2675 Returns revision or a ref name.
2676 """
2677 if custom_cl_base:
2678 # Try to avoid creating additional unintended CLs when uploading, unless
2679 # user wants to take this risk.
2680 local_ref_of_target_remote = self.GetRemoteBranch()[1]
2681 code, _ = RunGitWithCode(['merge-base', '--is-ancestor', custom_cl_base,
2682 local_ref_of_target_remote])
2683 if code == 1:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002684 print('\nWARNING: Manually specified base of this CL `%s` '
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002685 'doesn\'t seem to belong to target remote branch `%s`.\n\n'
2686 'If you proceed with upload, more than 1 CL may be created by '
2687 'Gerrit as a result, in turn confusing or crashing git cl.\n\n'
2688 'If you are certain that specified base `%s` has already been '
2689 'uploaded to Gerrit as another CL, you may proceed.\n' %
2690 (custom_cl_base, local_ref_of_target_remote, custom_cl_base))
2691 if not force:
2692 confirm_or_exit(
2693 'Do you take responsibility for cleaning up potential mess '
2694 'resulting from proceeding with upload?',
2695 action='upload')
2696 return custom_cl_base
2697
Aaron Gablef97e33d2017-03-30 15:44:27 -07002698 if remote != '.':
2699 return self.GetCommonAncestorWithUpstream()
2700
2701 # If our upstream branch is local, we base our squashed commit on its
2702 # squashed version.
2703 upstream_branch_name = scm.GIT.ShortBranchName(upstream_branch)
2704
Aaron Gablef97e33d2017-03-30 15:44:27 -07002705 if upstream_branch_name == 'master':
Aaron Gable0bbd1c22017-05-08 14:37:08 -07002706 return self.GetCommonAncestorWithUpstream()
Aaron Gablef97e33d2017-03-30 15:44:27 -07002707
2708 # Check the squashed hash of the parent.
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002709 # TODO(tandrii): consider checking parent change in Gerrit and using its
2710 # hash if tree hash of latest parent revision (patchset) in Gerrit matches
2711 # the tree hash of the parent branch. The upside is less likely bogus
2712 # requests to reupload parent change just because it's uploadhash is
2713 # missing, yet the downside likely exists, too (albeit unknown to me yet).
Aaron Gablef97e33d2017-03-30 15:44:27 -07002714 parent = RunGit(['config',
2715 'branch.%s.gerritsquashhash' % upstream_branch_name],
2716 error_ok=True).strip()
2717 # Verify that the upstream branch has been uploaded too, otherwise
2718 # Gerrit will create additional CLs when uploading.
2719 if not parent or (RunGitSilent(['rev-parse', upstream_branch + ':']) !=
2720 RunGitSilent(['rev-parse', parent + ':'])):
2721 DieWithError(
2722 '\nUpload upstream branch %s first.\n'
2723 'It is likely that this branch has been rebased since its last '
2724 'upload, so you just need to upload it again.\n'
2725 '(If you uploaded it with --no-squash, then branch dependencies '
2726 'are not supported, and you should reupload with --squash.)'
2727 % upstream_branch_name,
2728 change_desc)
2729 return parent
2730
tandrii@chromium.org8930b3d2016-04-13 14:47:02 +00002731 def _AddChangeIdToCommitMessage(self, options, args):
2732 """Re-commits using the current message, assumes the commit hook is in
2733 place.
2734 """
Andrii Shyshkalovb07575f2018-10-16 06:16:21 +00002735 log_desc = options.message or _create_description_from_log(args)
tandrii@chromium.org8930b3d2016-04-13 14:47:02 +00002736 git_command = ['commit', '--amend', '-m', log_desc]
2737 RunGit(git_command)
Andrii Shyshkalovb07575f2018-10-16 06:16:21 +00002738 new_log_desc = _create_description_from_log(args)
tandrii@chromium.org8930b3d2016-04-13 14:47:02 +00002739 if git_footers.get_footer_change_id(new_log_desc):
vapiera7fbd5a2016-06-16 09:17:49 -07002740 print('git-cl: Added Change-Id to commit message.')
tandrii@chromium.org8930b3d2016-04-13 14:47:02 +00002741 return new_log_desc
2742 else:
tandrii@chromium.orgb067ec52016-05-31 15:24:44 +00002743 DieWithError('ERROR: Gerrit commit-msg hook not installed.')
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002744
tandriie113dfd2016-10-11 10:20:12 -07002745 def CannotTriggerTryJobReason(self):
tandrii8c5a3532016-11-04 07:52:02 -07002746 try:
2747 data = self._GetChangeDetail()
Aaron Gablea45ee112016-11-22 15:14:38 -08002748 except GerritChangeNotExists:
2749 return 'Gerrit doesn\'t know about your change %s' % self.GetIssue()
tandrii8c5a3532016-11-04 07:52:02 -07002750
2751 if data['status'] in ('ABANDONED', 'MERGED'):
2752 return 'CL %s is closed' % self.GetIssue()
2753
Edward Lemurf0faf482019-09-25 20:40:17 +00002754 # TODO(1004447): Remove on Oct 9th, 2019.
2755 def GetLegacyProperties(self, patchset=None):
2756 host = self.GetCodereviewServer()
2757 issue = self.GetIssue()
2758 patchset = int(patchset or self.GetPatchset())
2759 data = self._GetChangeDetail(['ALL_REVISIONS'])
2760
2761 assert host and issue and patchset, 'CL must be uploaded first'
2762
2763 revision_data = None # Pylint wants it to be defined.
2764 for revision_data in data['revisions'].itervalues():
2765 if int(revision_data['_number']) == patchset:
2766 break
2767 else:
2768 raise Exception('Patchset %d is not known in Gerrit change %d' %
2769 (patchset, issue))
2770
2771 return {
2772 'patch_issue': issue,
2773 'patch_set': patchset,
2774 'patch_project': data['project'],
2775 'patch_storage': 'gerrit',
2776 'patch_ref': revision_data['fetch']['http']['ref'],
2777 'patch_repository_url': revision_data['fetch']['http']['url'],
2778 'patch_gerrit_url': host,
2779 }
2780
2781
Edward Lemurd4d1ba42019-09-20 21:46:37 +00002782 def GetGerritChange(self, patchset=None):
2783 """Returns a buildbucket.v2.GerritChange message for the current issue."""
2784 host = urlparse.urlparse(self.GetCodereviewServer()).hostname
2785 issue = self.GetIssue()
Edward Lemur2c210a42019-09-16 23:58:35 +00002786 patchset = int(patchset or self.GetPatchset())
Edward Lemurd4d1ba42019-09-20 21:46:37 +00002787 data = self._GetChangeDetail(['ALL_REVISIONS'])
2788
2789 assert host and issue and patchset, 'CL must be uploaded first'
2790
2791 has_patchset = any(
2792 int(revision_data['_number']) == patchset
2793 for revision_data in data['revisions'].itervalues())
2794 if not has_patchset:
Aaron Gablea45ee112016-11-22 15:14:38 -08002795 raise Exception('Patchset %d is not known in Gerrit change %d' %
tandrii8c5a3532016-11-04 07:52:02 -07002796 (patchset, self.GetIssue()))
Edward Lemurd4d1ba42019-09-20 21:46:37 +00002797
tandrii8c5a3532016-11-04 07:52:02 -07002798 return {
Edward Lemurd4d1ba42019-09-20 21:46:37 +00002799 'host': host,
2800 'change': issue,
2801 'project': data['project'],
2802 'patchset': patchset,
tandrii8c5a3532016-11-04 07:52:02 -07002803 }
tandriie113dfd2016-10-11 10:20:12 -07002804
tandriide281ae2016-10-12 06:02:30 -07002805 def GetIssueOwner(self):
tandrii8c5a3532016-11-04 07:52:02 -07002806 return self._GetChangeDetail(['DETAILED_ACCOUNTS'])['owner']['email']
tandriide281ae2016-10-12 06:02:30 -07002807
Edward Lemur707d70b2018-02-07 00:50:14 +01002808 def GetReviewers(self):
2809 details = self._GetChangeDetail(['DETAILED_ACCOUNTS'])
Mohamed Heikal171c0742018-11-09 20:38:51 +00002810 return [r['email'] for r in details['reviewers'].get('REVIEWER', [])]
Edward Lemur707d70b2018-02-07 00:50:14 +01002811
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002812
2813_CODEREVIEW_IMPLEMENTATIONS = {
Edward Lemur125d60a2019-09-13 18:25:41 +00002814 'gerrit': Changelist,
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002815}
2816
tandrii@chromium.org013a2802016-03-29 09:52:33 +00002817
iannuccie53c9352016-08-17 14:40:40 -07002818def _add_codereview_issue_select_options(parser, extra=""):
2819 _add_codereview_select_options(parser)
2820
2821 text = ('Operate on this issue number instead of the current branch\'s '
2822 'implicit issue.')
2823 if extra:
2824 text += ' '+extra
2825 parser.add_option('-i', '--issue', type=int, help=text)
2826
2827
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00002828def _add_codereview_select_options(parser):
Edward Lemurf38bc172019-09-03 21:02:13 +00002829 """Appends --gerrit option to force specific codereview."""
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00002830 parser.codereview_group = optparse.OptionGroup(
Edward Lemurf38bc172019-09-03 21:02:13 +00002831 parser, 'DEPRECATED! Codereview override options')
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00002832 parser.add_option_group(parser.codereview_group)
2833 parser.codereview_group.add_option(
2834 '--gerrit', action='store_true',
Edward Lemurf38bc172019-09-03 21:02:13 +00002835 help='Deprecated. Noop. Do not use.')
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00002836
2837
2838def _process_codereview_select_options(parser, options):
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00002839 options.forced_codereview = None
2840 if options.gerrit:
2841 options.forced_codereview = 'gerrit'
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00002842
2843
tandriif9aefb72016-07-01 09:06:51 -07002844def _get_bug_line_values(default_project, bugs):
2845 """Given default_project and comma separated list of bugs, yields bug line
2846 values.
2847
2848 Each bug can be either:
2849 * a number, which is combined with default_project
2850 * string, which is left as is.
2851
2852 This function may produce more than one line, because bugdroid expects one
2853 project per line.
2854
2855 >>> list(_get_bug_line_values('v8', '123,chromium:789'))
2856 ['v8:123', 'chromium:789']
2857 """
2858 default_bugs = []
2859 others = []
2860 for bug in bugs.split(','):
2861 bug = bug.strip()
2862 if bug:
2863 try:
2864 default_bugs.append(int(bug))
2865 except ValueError:
2866 others.append(bug)
2867
2868 if default_bugs:
2869 default_bugs = ','.join(map(str, default_bugs))
2870 if default_project:
2871 yield '%s:%s' % (default_project, default_bugs)
2872 else:
2873 yield default_bugs
2874 for other in sorted(others):
2875 # Don't bother finding common prefixes, CLs with >2 bugs are very very rare.
2876 yield other
2877
2878
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00002879class ChangeDescription(object):
2880 """Contains a parsed form of the change description."""
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00002881 R_LINE = r'^[ \t]*(TBR|R)[ \t]*=[ \t]*(.*?)[ \t]*$'
bradnelsond975b302016-10-23 12:20:23 -07002882 CC_LINE = r'^[ \t]*(CC)[ \t]*=[ \t]*(.*?)[ \t]*$'
Aaron Gable3a16ed12017-03-23 10:51:55 -07002883 BUG_LINE = r'^[ \t]*(?:(BUG)[ \t]*=|Bug:)[ \t]*(.*?)[ \t]*$'
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01002884 CHERRY_PICK_LINE = r'^\(cherry picked from commit [a-fA-F0-9]{40}\)$'
Nodir Turakulov23b82142017-11-16 11:04:25 -08002885 STRIP_HASH_TAG_PREFIX = r'^(\s*(revert|reland)( "|:)?\s*)*'
2886 BRACKET_HASH_TAG = r'\s*\[([^\[\]]+)\]'
2887 COLON_SEPARATED_HASH_TAG = r'^([a-zA-Z0-9_\- ]+):'
2888 BAD_HASH_TAG_CHUNK = r'[^a-zA-Z0-9]+'
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00002889
Anthony Polito8b955342019-09-24 19:01:36 +00002890 def __init__(self, description, bug=None):
agable@chromium.org42c20792013-09-12 17:34:49 +00002891 self._description_lines = (description or '').strip().splitlines()
Anthony Polito8b955342019-09-24 19:01:36 +00002892 if bug:
2893 regexp = re.compile(self.BUG_LINE)
2894 prefix = settings.GetBugPrefix()
2895 if not any((regexp.match(line) for line in self._description_lines)):
2896 values = list(_get_bug_line_values(prefix, bug))
2897 self.append_footer('Bug: %s' % ', '.join(values))
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002898
agable@chromium.org42c20792013-09-12 17:34:49 +00002899 @property # www.logilab.org/ticket/89786
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -08002900 def description(self): # pylint: disable=method-hidden
agable@chromium.org42c20792013-09-12 17:34:49 +00002901 return '\n'.join(self._description_lines)
2902
2903 def set_description(self, desc):
2904 if isinstance(desc, basestring):
2905 lines = desc.splitlines()
2906 else:
2907 lines = [line.rstrip() for line in desc]
2908 while lines and not lines[0]:
2909 lines.pop(0)
2910 while lines and not lines[-1]:
2911 lines.pop(-1)
2912 self._description_lines = lines
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002913
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002914 def update_reviewers(self, reviewers, tbrs, add_owners_to=None, change=None):
2915 """Rewrites the R=/TBR= line(s) as a single line each.
2916
2917 Args:
2918 reviewers (list(str)) - list of additional emails to use for reviewers.
2919 tbrs (list(str)) - list of additional emails to use for TBRs.
2920 add_owners_to (None|'R'|'TBR') - Pass to do an OWNERS lookup for files in
2921 the change that are missing OWNER coverage. If this is not None, you
2922 must also pass a value for `change`.
2923 change (Change) - The Change that should be used for OWNERS lookups.
2924 """
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002925 assert isinstance(reviewers, list), reviewers
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002926 assert isinstance(tbrs, list), tbrs
2927
Robert Iannuccif2708bd2017-04-17 15:49:02 -07002928 assert add_owners_to in (None, 'TBR', 'R'), add_owners_to
Robert Iannuccia28592e2017-04-18 13:14:49 -07002929 assert not add_owners_to or change, add_owners_to
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002930
2931 if not reviewers and not tbrs and not add_owners_to:
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002932 return
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002933
2934 reviewers = set(reviewers)
2935 tbrs = set(tbrs)
2936 LOOKUP = {
2937 'TBR': tbrs,
2938 'R': reviewers,
2939 }
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002940
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002941 # Get the set of R= and TBR= lines and remove them from the description.
agable@chromium.org42c20792013-09-12 17:34:49 +00002942 regexp = re.compile(self.R_LINE)
2943 matches = [regexp.match(line) for line in self._description_lines]
2944 new_desc = [l for i, l in enumerate(self._description_lines)
2945 if not matches[i]]
2946 self.set_description(new_desc)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002947
agable@chromium.org42c20792013-09-12 17:34:49 +00002948 # Construct new unified R= and TBR= lines.
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002949
2950 # First, update tbrs/reviewers with names from the R=/TBR= lines (if any).
agable@chromium.org42c20792013-09-12 17:34:49 +00002951 for match in matches:
2952 if not match:
2953 continue
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002954 LOOKUP[match.group(1)].update(cleanup_list([match.group(2).strip()]))
2955
2956 # Next, maybe fill in OWNERS coverage gaps to either tbrs/reviewers.
Robert Iannuccif2708bd2017-04-17 15:49:02 -07002957 if add_owners_to:
piman@chromium.org336f9122014-09-04 02:16:55 +00002958 owners_db = owners.Database(change.RepositoryRoot(),
Jochen Eisinger72606f82017-04-04 10:44:18 +02002959 fopen=file, os_path=os.path)
piman@chromium.org336f9122014-09-04 02:16:55 +00002960 missing_files = owners_db.files_not_covered_by(change.LocalPaths(),
Robert Iannucci100aa212017-04-18 17:28:26 -07002961 (tbrs | reviewers))
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002962 LOOKUP[add_owners_to].update(
2963 owners_db.reviewers_for(missing_files, change.author_email))
Robert Iannuccif2708bd2017-04-17 15:49:02 -07002964
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002965 # If any folks ended up in both groups, remove them from tbrs.
2966 tbrs -= reviewers
Robert Iannuccif2708bd2017-04-17 15:49:02 -07002967
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002968 new_r_line = 'R=' + ', '.join(sorted(reviewers)) if reviewers else None
2969 new_tbr_line = 'TBR=' + ', '.join(sorted(tbrs)) if tbrs else None
agable@chromium.org42c20792013-09-12 17:34:49 +00002970
2971 # Put the new lines in the description where the old first R= line was.
2972 line_loc = next((i for i, match in enumerate(matches) if match), -1)
2973 if 0 <= line_loc < len(self._description_lines):
2974 if new_tbr_line:
2975 self._description_lines.insert(line_loc, new_tbr_line)
2976 if new_r_line:
2977 self._description_lines.insert(line_loc, new_r_line)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002978 else:
agable@chromium.org42c20792013-09-12 17:34:49 +00002979 if new_r_line:
2980 self.append_footer(new_r_line)
2981 if new_tbr_line:
2982 self.append_footer(new_tbr_line)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002983
Andrii Shyshkalov71f0da32019-07-15 22:45:18 +00002984 def set_preserve_tryjobs(self):
2985 """Ensures description footer contains 'Cq-Do-Not-Cancel-Tryjobs: true'."""
2986 footers = git_footers.parse_footers(self.description)
2987 for v in footers.get('Cq-Do-Not-Cancel-Tryjobs', []):
2988 if v.lower() == 'true':
2989 return
2990 self.append_footer('Cq-Do-Not-Cancel-Tryjobs: true')
2991
Anthony Polito8b955342019-09-24 19:01:36 +00002992 def prompt(self):
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002993 """Asks the user to update the description."""
agable@chromium.org42c20792013-09-12 17:34:49 +00002994 self.set_description([
2995 '# Enter a description of the change.',
2996 '# This will be displayed on the codereview site.',
2997 '# The first line will also be used as the subject of the review.',
alancutter@chromium.orgbd1073e2013-06-01 00:34:38 +00002998 '#--------------------This line is 72 characters long'
agable@chromium.org42c20792013-09-12 17:34:49 +00002999 '--------------------',
3000 ] + self._description_lines)
agable@chromium.org42c20792013-09-12 17:34:49 +00003001 regexp = re.compile(self.BUG_LINE)
Jonas Termansend0f79112019-03-22 15:28:26 +00003002 prefix = settings.GetBugPrefix()
agable@chromium.org42c20792013-09-12 17:34:49 +00003003 if not any((regexp.match(line) for line in self._description_lines)):
Anthony Polito8b955342019-09-24 19:01:36 +00003004 self.append_footer('Bug: %s' % prefix)
tandriif9aefb72016-07-01 09:06:51 -07003005
agable@chromium.org42c20792013-09-12 17:34:49 +00003006 content = gclient_utils.RunEditor(self.description, True,
Anthony Polito8b955342019-09-24 19:01:36 +00003007 git_editor=settings.GetGitEditor())
maruel@chromium.org0e0436a2011-10-25 13:32:41 +00003008 if not content:
3009 DieWithError('Running editor failed')
agable@chromium.org42c20792013-09-12 17:34:49 +00003010 lines = content.splitlines()
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003011
Bruce Dawson2377b012018-01-11 16:46:49 -08003012 # Strip off comments and default inserted "Bug:" line.
3013 clean_lines = [line.rstrip() for line in lines if not
Jonas Termansend0f79112019-03-22 15:28:26 +00003014 (line.startswith('#') or
3015 line.rstrip() == "Bug:" or
3016 line.rstrip() == "Bug: " + prefix)]
agable@chromium.org42c20792013-09-12 17:34:49 +00003017 if not clean_lines:
maruel@chromium.org0e0436a2011-10-25 13:32:41 +00003018 DieWithError('No CL description, aborting')
agable@chromium.org42c20792013-09-12 17:34:49 +00003019 self.set_description(clean_lines)
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00003020
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003021 def append_footer(self, line):
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00003022 """Adds a footer line to the description.
3023
3024 Differentiates legacy "KEY=xxx" footers (used to be called tags) and
3025 Gerrit's footers in the form of "Footer-Key: footer any value" and ensures
3026 that Gerrit footers are always at the end.
3027 """
3028 parsed_footer_line = git_footers.parse_footer(line)
3029 if parsed_footer_line:
3030 # Line is a gerrit footer in the form: Footer-Key: any value.
3031 # Thus, must be appended observing Gerrit footer rules.
3032 self.set_description(
3033 git_footers.add_footer(self.description,
3034 key=parsed_footer_line[0],
3035 value=parsed_footer_line[1]))
3036 return
3037
3038 if not self._description_lines:
3039 self._description_lines.append(line)
3040 return
3041
3042 top_lines, gerrit_footers, _ = git_footers.split_footers(self.description)
3043 if gerrit_footers:
3044 # git_footers.split_footers ensures that there is an empty line before
3045 # actual (gerrit) footers, if any. We have to keep it that way.
3046 assert top_lines and top_lines[-1] == ''
3047 top_lines, separator = top_lines[:-1], top_lines[-1:]
3048 else:
3049 separator = [] # No need for separator if there are no gerrit_footers.
3050
3051 prev_line = top_lines[-1] if top_lines else ''
3052 if (not presubmit_support.Change.TAG_LINE_RE.match(prev_line) or
3053 not presubmit_support.Change.TAG_LINE_RE.match(line)):
3054 top_lines.append('')
3055 top_lines.append(line)
3056 self._description_lines = top_lines + separator + gerrit_footers
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00003057
tandrii99a72f22016-08-17 14:33:24 -07003058 def get_reviewers(self, tbr_only=False):
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003059 """Retrieves the list of reviewers."""
agable@chromium.org42c20792013-09-12 17:34:49 +00003060 matches = [re.match(self.R_LINE, line) for line in self._description_lines]
tandrii99a72f22016-08-17 14:33:24 -07003061 reviewers = [match.group(2).strip()
3062 for match in matches
3063 if match and (not tbr_only or match.group(1).upper() == 'TBR')]
maruel@chromium.org78936cb2013-04-11 00:17:52 +00003064 return cleanup_list(reviewers)
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00003065
bradnelsond975b302016-10-23 12:20:23 -07003066 def get_cced(self):
3067 """Retrieves the list of reviewers."""
3068 matches = [re.match(self.CC_LINE, line) for line in self._description_lines]
3069 cced = [match.group(2).strip() for match in matches if match]
3070 return cleanup_list(cced)
3071
Nodir Turakulov23b82142017-11-16 11:04:25 -08003072 def get_hash_tags(self):
3073 """Extracts and sanitizes a list of Gerrit hashtags."""
3074 subject = (self._description_lines or ('',))[0]
3075 subject = re.sub(
3076 self.STRIP_HASH_TAG_PREFIX, '', subject, flags=re.IGNORECASE)
3077
3078 tags = []
3079 start = 0
3080 bracket_exp = re.compile(self.BRACKET_HASH_TAG)
3081 while True:
3082 m = bracket_exp.match(subject, start)
3083 if not m:
3084 break
3085 tags.append(self.sanitize_hash_tag(m.group(1)))
3086 start = m.end()
3087
3088 if not tags:
3089 # Try "Tag: " prefix.
3090 m = re.match(self.COLON_SEPARATED_HASH_TAG, subject)
3091 if m:
3092 tags.append(self.sanitize_hash_tag(m.group(1)))
3093 return tags
3094
3095 @classmethod
3096 def sanitize_hash_tag(cls, tag):
3097 """Returns a sanitized Gerrit hash tag.
3098
3099 A sanitized hashtag can be used as a git push refspec parameter value.
3100 """
3101 return re.sub(cls.BAD_HASH_TAG_CHUNK, '-', tag).strip('-').lower()
3102
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01003103 def update_with_git_number_footers(self, parent_hash, parent_msg, dest_ref):
3104 """Updates this commit description given the parent.
3105
3106 This is essentially what Gnumbd used to do.
3107 Consult https://goo.gl/WMmpDe for more details.
3108 """
3109 assert parent_msg # No, orphan branch creation isn't supported.
3110 assert parent_hash
3111 assert dest_ref
3112 parent_footer_map = git_footers.parse_footers(parent_msg)
3113 # This will also happily parse svn-position, which GnumbD is no longer
3114 # supporting. While we'd generate correct footers, the verifier plugin
3115 # installed in Gerrit will block such commit (ie git push below will fail).
3116 parent_position = git_footers.get_position(parent_footer_map)
3117
3118 # Cherry-picks may have last line obscuring their prior footers,
3119 # from git_footers perspective. This is also what Gnumbd did.
3120 cp_line = None
3121 if (self._description_lines and
3122 re.match(self.CHERRY_PICK_LINE, self._description_lines[-1])):
3123 cp_line = self._description_lines.pop()
3124
Andrii Shyshkalovde37c012017-07-06 21:06:50 +02003125 top_lines, footer_lines, _ = git_footers.split_footers(self.description)
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01003126
3127 # Original-ify all Cr- footers, to avoid re-lands, cherry-picks, or just
3128 # user interference with actual footers we'd insert below.
Andrii Shyshkalovde37c012017-07-06 21:06:50 +02003129 for i, line in enumerate(footer_lines):
3130 k, v = git_footers.parse_footer(line) or (None, None)
3131 if k and k.startswith('Cr-'):
3132 footer_lines[i] = '%s: %s' % ('Cr-Original-' + k[len('Cr-'):], v)
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01003133
3134 # Add Position and Lineage footers based on the parent.
Andrii Shyshkalovb5effa12016-12-14 19:35:12 +01003135 lineage = list(reversed(parent_footer_map.get('Cr-Branched-From', [])))
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01003136 if parent_position[0] == dest_ref:
3137 # Same branch as parent.
3138 number = int(parent_position[1]) + 1
3139 else:
3140 number = 1 # New branch, and extra lineage.
3141 lineage.insert(0, '%s-%s@{#%d}' % (parent_hash, parent_position[0],
3142 int(parent_position[1])))
3143
Andrii Shyshkalovde37c012017-07-06 21:06:50 +02003144 footer_lines.append('Cr-Commit-Position: %s@{#%d}' % (dest_ref, number))
3145 footer_lines.extend('Cr-Branched-From: %s' % v for v in lineage)
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01003146
3147 self._description_lines = top_lines
3148 if cp_line:
3149 self._description_lines.append(cp_line)
3150 if self._description_lines[-1] != '':
3151 self._description_lines.append('') # Ensure footer separator.
Andrii Shyshkalovde37c012017-07-06 21:06:50 +02003152 self._description_lines.extend(footer_lines)
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01003153
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00003154
Aaron Gablea1bab272017-04-11 16:38:18 -07003155def get_approving_reviewers(props, disapproval=False):
maruel@chromium.orge52678e2013-04-26 18:34:44 +00003156 """Retrieves the reviewers that approved a CL from the issue properties with
3157 messages.
3158
3159 Note that the list may contain reviewers that are not committer, thus are not
3160 considered by the CQ.
Aaron Gablea1bab272017-04-11 16:38:18 -07003161
3162 If disapproval is True, instead returns reviewers who 'not lgtm'd the CL.
maruel@chromium.orge52678e2013-04-26 18:34:44 +00003163 """
Aaron Gablea1bab272017-04-11 16:38:18 -07003164 approval_type = 'disapproval' if disapproval else 'approval'
maruel@chromium.orge52678e2013-04-26 18:34:44 +00003165 return sorted(
3166 set(
3167 message['sender']
3168 for message in props['messages']
Aaron Gablea1bab272017-04-11 16:38:18 -07003169 if message[approval_type] and message['sender'] in props['reviewers']
maruel@chromium.orge52678e2013-04-26 18:34:44 +00003170 )
3171 )
3172
3173
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003174def FindCodereviewSettingsFile(filename='codereview.settings'):
3175 """Finds the given file starting in the cwd and going up.
3176
3177 Only looks up to the top of the repository unless an
3178 'inherit-review-settings-ok' file exists in the root of the repository.
3179 """
3180 inherit_ok_file = 'inherit-review-settings-ok'
3181 cwd = os.getcwd()
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00003182 root = settings.GetRoot()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003183 if os.path.isfile(os.path.join(root, inherit_ok_file)):
3184 root = '/'
3185 while True:
3186 if filename in os.listdir(cwd):
3187 if os.path.isfile(os.path.join(cwd, filename)):
3188 return open(os.path.join(cwd, filename))
3189 if cwd == root:
3190 break
3191 cwd = os.path.dirname(cwd)
3192
3193
3194def LoadCodereviewSettingsFromFile(fileobj):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003195 """Parses a codereview.settings file and updates hooks."""
maruel@chromium.org99ac1c52012-01-16 14:52:12 +00003196 keyvals = gclient_utils.ParseCodereviewSettingsContent(fileobj.read())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003197
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003198 def SetProperty(name, setting, unset_error_ok=False):
3199 fullname = 'rietveld.' + name
3200 if setting in keyvals:
3201 RunGit(['config', fullname, keyvals[setting]])
3202 else:
3203 RunGit(['config', '--unset-all', fullname], error_ok=unset_error_ok)
3204
tandrii48df5812016-10-17 03:55:37 -07003205 if not keyvals.get('GERRIT_HOST', False):
3206 SetProperty('server', 'CODE_REVIEW_SERVER')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003207 # Only server setting is required. Other settings can be absent.
3208 # In that case, we ignore errors raised during option deletion attempt.
3209 SetProperty('cc', 'CC_LIST', unset_error_ok=True)
3210 SetProperty('tree-status-url', 'STATUS', unset_error_ok=True)
3211 SetProperty('viewvc-url', 'VIEW_VC', unset_error_ok=True)
rmistry@google.com90752582014-01-14 21:04:50 +00003212 SetProperty('bug-prefix', 'BUG_PREFIX', unset_error_ok=True)
thestig@chromium.org44202a22014-03-11 19:22:18 +00003213 SetProperty('cpplint-regex', 'LINT_REGEX', unset_error_ok=True)
3214 SetProperty('cpplint-ignore-regex', 'LINT_IGNORE_REGEX', unset_error_ok=True)
rmistry@google.com5626a922015-02-26 14:03:30 +00003215 SetProperty('run-post-upload-hook', 'RUN_POST_UPLOAD_HOOK',
3216 unset_error_ok=True)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003217
ukai@chromium.org7044efc2013-11-28 01:51:21 +00003218 if 'GERRIT_HOST' in keyvals:
ukai@chromium.orge8077812012-02-03 03:41:46 +00003219 RunGit(['config', 'gerrit.host', keyvals['GERRIT_HOST']])
ukai@chromium.orge8077812012-02-03 03:41:46 +00003220
bauerb@chromium.org54b400c2016-01-14 10:08:25 +00003221 if 'GERRIT_SQUASH_UPLOADS' in keyvals:
tandrii8dd81ea2016-06-16 13:24:23 -07003222 RunGit(['config', 'gerrit.squash-uploads',
3223 keyvals['GERRIT_SQUASH_UPLOADS']])
bauerb@chromium.org54b400c2016-01-14 10:08:25 +00003224
tandrii@chromium.org28253532016-04-14 13:46:56 +00003225 if 'GERRIT_SKIP_ENSURE_AUTHENTICATED' in keyvals:
shinyak@chromium.org00dbccd2016-04-15 07:24:43 +00003226 RunGit(['config', 'gerrit.skip-ensure-authenticated',
tandrii@chromium.org28253532016-04-14 13:46:56 +00003227 keyvals['GERRIT_SKIP_ENSURE_AUTHENTICATED']])
3228
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003229 if 'PUSH_URL_CONFIG' in keyvals and 'ORIGIN_URL_CONFIG' in keyvals:
Andrii Shyshkalov18975322017-01-25 16:44:13 +01003230 # should be of the form
3231 # PUSH_URL_CONFIG: url.ssh://gitrw.chromium.org.pushinsteadof
3232 # ORIGIN_URL_CONFIG: http://src.chromium.org/git
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003233 RunGit(['config', keyvals['PUSH_URL_CONFIG'],
3234 keyvals['ORIGIN_URL_CONFIG']])
3235
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003236
joshua.lock@intel.com426f69b2012-08-02 23:41:49 +00003237def urlretrieve(source, destination):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003238 """Downloads a network object to a local file, like urllib.urlretrieve.
3239
3240 This is necessary because urllib is broken for SSL connections via a proxy.
3241 """
joshua.lock@intel.com426f69b2012-08-02 23:41:49 +00003242 with open(destination, 'w') as f:
3243 f.write(urllib2.urlopen(source).read())
3244
3245
ukai@chromium.org712d6102013-11-27 00:52:58 +00003246def hasSheBang(fname):
3247 """Checks fname is a #! script."""
3248 with open(fname) as f:
3249 return f.read(2).startswith('#!')
3250
3251
bpastene@chromium.org917f0ff2016-04-05 00:45:30 +00003252# TODO(bpastene) Remove once a cleaner fix to crbug.com/600473 presents itself.
3253def DownloadHooks(*args, **kwargs):
3254 pass
3255
3256
tandrii@chromium.org18630d62016-03-04 12:06:02 +00003257def DownloadGerritHook(force):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003258 """Downloads and installs a Gerrit commit-msg hook.
ukai@chromium.org78c4b982012-02-14 02:20:26 +00003259
3260 Args:
3261 force: True to update hooks. False to install hooks if not present.
3262 """
3263 if not settings.GetIsGerrit():
3264 return
ukai@chromium.org712d6102013-11-27 00:52:58 +00003265 src = 'https://gerrit-review.googlesource.com/tools/hooks/commit-msg'
ukai@chromium.org78c4b982012-02-14 02:20:26 +00003266 dst = os.path.join(settings.GetRoot(), '.git', 'hooks', 'commit-msg')
3267 if not os.access(dst, os.X_OK):
3268 if os.path.exists(dst):
3269 if not force:
3270 return
ukai@chromium.org78c4b982012-02-14 02:20:26 +00003271 try:
joshua.lock@intel.com426f69b2012-08-02 23:41:49 +00003272 urlretrieve(src, dst)
ukai@chromium.org712d6102013-11-27 00:52:58 +00003273 if not hasSheBang(dst):
3274 DieWithError('Not a script: %s\n'
3275 'You need to download from\n%s\n'
3276 'into .git/hooks/commit-msg and '
3277 'chmod +x .git/hooks/commit-msg' % (dst, src))
ukai@chromium.org78c4b982012-02-14 02:20:26 +00003278 os.chmod(dst, stat.S_IRUSR | stat.S_IWUSR | stat.S_IXUSR)
3279 except Exception:
3280 if os.path.exists(dst):
3281 os.remove(dst)
ukai@chromium.org712d6102013-11-27 00:52:58 +00003282 DieWithError('\nFailed to download hooks.\n'
3283 'You need to download from\n%s\n'
3284 'into .git/hooks/commit-msg and '
3285 'chmod +x .git/hooks/commit-msg' % src)
ukai@chromium.org78c4b982012-02-14 02:20:26 +00003286
3287
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003288class _GitCookiesChecker(object):
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003289 """Provides facilities for validating and suggesting fixes to .gitcookies."""
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003290
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003291 _GOOGLESOURCE = 'googlesource.com'
3292
3293 def __init__(self):
3294 # Cached list of [host, identity, source], where source is either
3295 # .gitcookies or .netrc.
3296 self._all_hosts = None
3297
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003298 def ensure_configured_gitcookies(self):
3299 """Runs checks and suggests fixes to make git use .gitcookies from default
3300 path."""
3301 default = gerrit_util.CookiesAuthenticator.get_gitcookies_path()
3302 configured_path = RunGitSilent(
3303 ['config', '--global', 'http.cookiefile']).strip()
Andrii Shyshkalov1e250cd2017-05-10 15:39:31 +02003304 configured_path = os.path.expanduser(configured_path)
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003305 if configured_path:
3306 self._ensure_default_gitcookies_path(configured_path, default)
3307 else:
3308 self._configure_gitcookies_path(default)
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003309
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003310 @staticmethod
3311 def _ensure_default_gitcookies_path(configured_path, default_path):
3312 assert configured_path
3313 if configured_path == default_path:
3314 print('git is already configured to use your .gitcookies from %s' %
3315 configured_path)
3316 return
3317
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003318 print('WARNING: You have configured custom path to .gitcookies: %s\n'
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003319 'Gerrit and other depot_tools expect .gitcookies at %s\n' %
3320 (configured_path, default_path))
3321
3322 if not os.path.exists(configured_path):
3323 print('However, your configured .gitcookies file is missing.')
3324 confirm_or_exit('Reconfigure git to use default .gitcookies?',
3325 action='reconfigure')
3326 RunGit(['config', '--global', 'http.cookiefile', default_path])
3327 return
3328
3329 if os.path.exists(default_path):
3330 print('WARNING: default .gitcookies file already exists %s' %
3331 default_path)
3332 DieWithError('Please delete %s manually and re-run git cl creds-check' %
3333 default_path)
3334
3335 confirm_or_exit('Move existing .gitcookies to default location?',
3336 action='move')
3337 shutil.move(configured_path, default_path)
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003338 RunGit(['config', '--global', 'http.cookiefile', default_path])
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003339 print('Moved and reconfigured git to use .gitcookies from %s' %
3340 default_path)
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003341
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003342 @staticmethod
3343 def _configure_gitcookies_path(default_path):
3344 netrc_path = gerrit_util.CookiesAuthenticator.get_netrc_path()
3345 if os.path.exists(netrc_path):
3346 print('You seem to be using outdated .netrc for git credentials: %s' %
3347 netrc_path)
3348 print('This tool will guide you through setting up recommended '
3349 '.gitcookies store for git credentials.\n'
3350 '\n'
3351 'IMPORTANT: If something goes wrong and you decide to go back, do:\n'
3352 ' git config --global --unset http.cookiefile\n'
3353 ' mv %s %s.backup\n\n' % (default_path, default_path))
3354 confirm_or_exit(action='setup .gitcookies')
3355 RunGit(['config', '--global', 'http.cookiefile', default_path])
3356 print('Configured git to use .gitcookies from %s' % default_path)
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003357
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003358 def get_hosts_with_creds(self, include_netrc=False):
3359 if self._all_hosts is None:
3360 a = gerrit_util.CookiesAuthenticator()
3361 self._all_hosts = [
3362 (h, u, s)
3363 for h, u, s in itertools.chain(
3364 ((h, u, '.netrc') for h, (u, _, _) in a.netrc.hosts.iteritems()),
3365 ((h, u, '.gitcookies') for h, (u, _) in a.gitcookies.iteritems())
3366 )
3367 if h.endswith(self._GOOGLESOURCE)
3368 ]
3369
3370 if include_netrc:
3371 return self._all_hosts
3372 return [(h, u, s) for h, u, s in self._all_hosts if s != '.netrc']
3373
3374 def print_current_creds(self, include_netrc=False):
3375 hosts = sorted(self.get_hosts_with_creds(include_netrc=include_netrc))
3376 if not hosts:
3377 print('No Git/Gerrit credentials found')
3378 return
3379 lengths = [max(map(len, (row[i] for row in hosts))) for i in xrange(3)]
3380 header = [('Host', 'User', 'Which file'),
3381 ['=' * l for l in lengths]]
3382 for row in (header + hosts):
3383 print('\t'.join((('%%+%ds' % l) % s)
3384 for l, s in zip(lengths, row)))
3385
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003386 @staticmethod
3387 def _parse_identity(identity):
Lei Zhangd3f769a2017-12-15 15:16:14 -08003388 """Parses identity "git-<username>.domain" into <username> and domain."""
3389 # Special case: usernames that contain ".", which are generally not
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +02003390 # distinguishable from sub-domains. But we do know typical domains:
3391 if identity.endswith('.chromium.org'):
3392 domain = 'chromium.org'
3393 username = identity[:-len('.chromium.org')]
3394 else:
3395 username, domain = identity.split('.', 1)
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003396 if username.startswith('git-'):
3397 username = username[len('git-'):]
3398 return username, domain
3399
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003400 def _canonical_git_googlesource_host(self, host):
3401 """Normalizes Gerrit hosts (with '-review') to Git host."""
3402 assert host.endswith(self._GOOGLESOURCE)
3403 # Prefix doesn't include '.' at the end.
3404 prefix = host[:-(1 + len(self._GOOGLESOURCE))]
3405 if prefix.endswith('-review'):
3406 prefix = prefix[:-len('-review')]
3407 return prefix + '.' + self._GOOGLESOURCE
3408
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003409 def _canonical_gerrit_googlesource_host(self, host):
3410 git_host = self._canonical_git_googlesource_host(host)
3411 prefix = git_host.split('.', 1)[0]
3412 return prefix + '-review.' + self._GOOGLESOURCE
3413
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003414 def _get_counterpart_host(self, host):
3415 assert host.endswith(self._GOOGLESOURCE)
3416 git = self._canonical_git_googlesource_host(host)
3417 gerrit = self._canonical_gerrit_googlesource_host(git)
3418 return git if gerrit == host else gerrit
3419
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003420 def has_generic_host(self):
3421 """Returns whether generic .googlesource.com has been configured.
3422
3423 Chrome Infra recommends to use explicit ${host}.googlesource.com instead.
3424 """
3425 for host, _, _ in self.get_hosts_with_creds(include_netrc=False):
3426 if host == '.' + self._GOOGLESOURCE:
3427 return True
3428 return False
3429
3430 def _get_git_gerrit_identity_pairs(self):
3431 """Returns map from canonic host to pair of identities (Git, Gerrit).
3432
3433 One of identities might be None, meaning not configured.
3434 """
3435 host_to_identity_pairs = {}
3436 for host, identity, _ in self.get_hosts_with_creds():
3437 canonical = self._canonical_git_googlesource_host(host)
3438 pair = host_to_identity_pairs.setdefault(canonical, [None, None])
3439 idx = 0 if canonical == host else 1
3440 pair[idx] = identity
3441 return host_to_identity_pairs
3442
3443 def get_partially_configured_hosts(self):
3444 return set(
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003445 (host if i1 else self._canonical_gerrit_googlesource_host(host))
3446 for host, (i1, i2) in self._get_git_gerrit_identity_pairs().iteritems()
3447 if None in (i1, i2) and host != '.' + self._GOOGLESOURCE)
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003448
3449 def get_conflicting_hosts(self):
3450 return set(
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003451 host
3452 for host, (i1, i2) in self._get_git_gerrit_identity_pairs().iteritems()
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003453 if None not in (i1, i2) and i1 != i2)
3454
3455 def get_duplicated_hosts(self):
3456 counters = collections.Counter(h for h, _, _ in self.get_hosts_with_creds())
3457 return set(host for host, count in counters.iteritems() if count > 1)
3458
3459 _EXPECTED_HOST_IDENTITY_DOMAINS = {
3460 'chromium.googlesource.com': 'chromium.org',
3461 'chrome-internal.googlesource.com': 'google.com',
3462 }
3463
3464 def get_hosts_with_wrong_identities(self):
3465 """Finds hosts which **likely** reference wrong identities.
3466
3467 Note: skips hosts which have conflicting identities for Git and Gerrit.
3468 """
3469 hosts = set()
3470 for host, expected in self._EXPECTED_HOST_IDENTITY_DOMAINS.iteritems():
3471 pair = self._get_git_gerrit_identity_pairs().get(host)
3472 if pair and pair[0] == pair[1]:
3473 _, domain = self._parse_identity(pair[0])
3474 if domain != expected:
3475 hosts.add(host)
3476 return hosts
3477
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003478 @staticmethod
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003479 def _format_hosts(hosts, extra_column_func=None):
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003480 hosts = sorted(hosts)
3481 assert hosts
3482 if extra_column_func is None:
3483 extras = [''] * len(hosts)
3484 else:
3485 extras = [extra_column_func(host) for host in hosts]
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003486 tmpl = '%%-%ds %%-%ds' % (max(map(len, hosts)), max(map(len, extras)))
3487 lines = []
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003488 for he in zip(hosts, extras):
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003489 lines.append(tmpl % he)
3490 return lines
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003491
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003492 def _find_problems(self):
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003493 if self.has_generic_host():
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003494 yield ('.googlesource.com wildcard record detected',
3495 ['Chrome Infrastructure team recommends to list full host names '
3496 'explicitly.'],
3497 None)
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003498
3499 dups = self.get_duplicated_hosts()
3500 if dups:
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003501 yield ('The following hosts were defined twice',
3502 self._format_hosts(dups),
3503 None)
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003504
3505 partial = self.get_partially_configured_hosts()
3506 if partial:
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003507 yield ('Credentials should come in pairs for Git and Gerrit hosts. '
3508 'These hosts are missing',
3509 self._format_hosts(partial, lambda host: 'but %s defined' %
3510 self._get_counterpart_host(host)),
3511 partial)
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003512
3513 conflicting = self.get_conflicting_hosts()
3514 if conflicting:
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003515 yield ('The following Git hosts have differing credentials from their '
3516 'Gerrit counterparts',
3517 self._format_hosts(conflicting, lambda host: '%s vs %s' %
3518 tuple(self._get_git_gerrit_identity_pairs()[host])),
3519 conflicting)
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003520
3521 wrong = self.get_hosts_with_wrong_identities()
3522 if wrong:
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003523 yield ('These hosts likely use wrong identity',
3524 self._format_hosts(wrong, lambda host: '%s but %s recommended' %
3525 (self._get_git_gerrit_identity_pairs()[host][0],
3526 self._EXPECTED_HOST_IDENTITY_DOMAINS[host])),
3527 wrong)
3528
3529 def find_and_report_problems(self):
3530 """Returns True if there was at least one problem, else False."""
3531 found = False
3532 bad_hosts = set()
3533 for title, sublines, hosts in self._find_problems():
3534 if not found:
3535 found = True
3536 print('\n\n.gitcookies problem report:\n')
3537 bad_hosts.update(hosts or [])
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003538 print(' %s%s' % (title, (':' if sublines else '')))
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003539 if sublines:
3540 print()
3541 print(' %s' % '\n '.join(sublines))
3542 print()
3543
3544 if bad_hosts:
3545 assert found
3546 print(' You can manually remove corresponding lines in your %s file and '
3547 'visit the following URLs with correct account to generate '
3548 'correct credential lines:\n' %
3549 gerrit_util.CookiesAuthenticator.get_gitcookies_path())
3550 print(' %s' % '\n '.join(sorted(set(
3551 gerrit_util.CookiesAuthenticator().get_new_password_url(
3552 self._canonical_git_googlesource_host(host))
3553 for host in bad_hosts
3554 ))))
3555 return found
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003556
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003557
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003558@metrics.collector.collect_metrics('git cl creds-check')
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003559def CMDcreds_check(parser, args):
3560 """Checks credentials and suggests changes."""
3561 _, _ = parser.parse_args(args)
3562
Vadim Shtayurab250ec12018-10-04 00:21:08 +00003563 # Code below checks .gitcookies. Abort if using something else.
3564 authn = gerrit_util.Authenticator.get()
3565 if not isinstance(authn, gerrit_util.CookiesAuthenticator):
3566 if isinstance(authn, gerrit_util.GceAuthenticator):
3567 DieWithError(
3568 'This command is not designed for GCE, are you on a bot?\n'
3569 'If you need to run this on GCE, export SKIP_GCE_AUTH_FOR_GIT=1 '
3570 'in your env.')
Aaron Gabled10ca0e2017-09-11 11:24:10 -07003571 DieWithError(
Vadim Shtayurab250ec12018-10-04 00:21:08 +00003572 'This command is not designed for bot environment. It checks '
3573 '~/.gitcookies file not generally used on bots.')
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003574
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003575 checker = _GitCookiesChecker()
3576 checker.ensure_configured_gitcookies()
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003577
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003578 print('Your .netrc and .gitcookies have credentials for these hosts:')
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003579 checker.print_current_creds(include_netrc=True)
3580
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003581 if not checker.find_and_report_problems():
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003582 print('\nNo problems detected in your .gitcookies file.')
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003583 return 0
3584 return 1
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003585
3586
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003587@metrics.collector.collect_metrics('git cl baseurl')
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00003588def CMDbaseurl(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00003589 """Gets or sets base-url for this branch."""
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00003590 branchref = RunGit(['symbolic-ref', 'HEAD']).strip()
3591 branch = ShortBranchName(branchref)
3592 _, args = parser.parse_args(args)
3593 if not args:
vapiera7fbd5a2016-06-16 09:17:49 -07003594 print('Current base-url:')
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00003595 return RunGit(['config', 'branch.%s.base-url' % branch],
3596 error_ok=False).strip()
3597 else:
vapiera7fbd5a2016-06-16 09:17:49 -07003598 print('Setting base-url to %s' % args[0])
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00003599 return RunGit(['config', 'branch.%s.base-url' % branch, args[0]],
3600 error_ok=False).strip()
3601
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003602
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00003603def color_for_status(status):
3604 """Maps a Changelist status to color, for CMDstatus and other tools."""
3605 return {
Aaron Gable9ab38c62017-04-06 14:36:33 -07003606 'unsent': Fore.YELLOW,
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00003607 'waiting': Fore.BLUE,
3608 'reply': Fore.YELLOW,
Aaron Gable9ab38c62017-04-06 14:36:33 -07003609 'not lgtm': Fore.RED,
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00003610 'lgtm': Fore.GREEN,
3611 'commit': Fore.MAGENTA,
3612 'closed': Fore.CYAN,
3613 'error': Fore.WHITE,
3614 }.get(status, Fore.WHITE)
3615
tandrii@chromium.org04ea8462016-04-25 19:51:21 +00003616
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003617def get_cl_statuses(changes, fine_grained, max_processes=None):
3618 """Returns a blocking iterable of (cl, status) for given branches.
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00003619
3620 If fine_grained is true, this will fetch CL statuses from the server.
3621 Otherwise, simply indicate if there's a matching url for the given branches.
3622
3623 If max_processes is specified, it is used as the maximum number of processes
3624 to spawn to fetch CL status from the server. Otherwise 1 process per branch is
3625 spawned.
calamity@chromium.orgcf197482016-04-29 20:15:53 +00003626
3627 See GetStatus() for a list of possible statuses.
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00003628 """
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01003629 if not changes:
3630 raise StopIteration()
calamity@chromium.orgcf197482016-04-29 20:15:53 +00003631
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01003632 if not fine_grained:
3633 # Fast path which doesn't involve querying codereview servers.
Aaron Gablea1bab272017-04-11 16:38:18 -07003634 # Do not use get_approving_reviewers(), since it requires an HTTP request.
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003635 for cl in changes:
3636 yield (cl, 'waiting' if cl.GetIssueURL() else 'error')
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01003637 return
3638
3639 # First, sort out authentication issues.
3640 logging.debug('ensuring credentials exist')
3641 for cl in changes:
3642 cl.EnsureAuthenticated(force=False, refresh=True)
3643
3644 def fetch(cl):
3645 try:
3646 return (cl, cl.GetStatus())
3647 except:
3648 # See http://crbug.com/629863.
Andrii Shyshkalov98824232018-04-19 11:37:15 -07003649 logging.exception('failed to fetch status for cl %s:', cl.GetIssue())
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01003650 raise
3651
3652 threads_count = len(changes)
3653 if max_processes:
3654 threads_count = max(1, min(threads_count, max_processes))
3655 logging.debug('querying %d CLs using %d threads', len(changes), threads_count)
3656
3657 pool = ThreadPool(threads_count)
3658 fetched_cls = set()
3659 try:
3660 it = pool.imap_unordered(fetch, changes).__iter__()
3661 while True:
3662 try:
3663 cl, status = it.next(timeout=5)
3664 except multiprocessing.TimeoutError:
3665 break
3666 fetched_cls.add(cl)
3667 yield cl, status
3668 finally:
3669 pool.close()
3670
3671 # Add any branches that failed to fetch.
3672 for cl in set(changes) - fetched_cls:
3673 yield (cl, 'error')
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00003674
rmistry@google.com2dd99862015-06-22 12:22:18 +00003675
3676def upload_branch_deps(cl, args):
3677 """Uploads CLs of local branches that are dependents of the current branch.
3678
3679 If the local branch dependency tree looks like:
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003680
3681 test1 -> test2.1 -> test3.1
3682 -> test3.2
3683 -> test2.2 -> test3.3
rmistry@google.com2dd99862015-06-22 12:22:18 +00003684
3685 and you run "git cl upload --dependencies" from test1 then "git cl upload" is
3686 run on the dependent branches in this order:
3687 test2.1, test3.1, test3.2, test2.2, test3.3
3688
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003689 Note: This function does not rebase your local dependent branches. Use it
3690 when you make a change to the parent branch that will not conflict
3691 with its dependent branches, and you would like their dependencies
3692 updated in Rietveld.
rmistry@google.com2dd99862015-06-22 12:22:18 +00003693 """
3694 if git_common.is_dirty_git_tree('upload-branch-deps'):
3695 return 1
3696
3697 root_branch = cl.GetBranch()
3698 if root_branch is None:
3699 DieWithError('Can\'t find dependent branches from detached HEAD state. '
3700 'Get on a branch!')
Andrii Shyshkalov9f274432018-10-15 16:40:23 +00003701 if not cl.GetIssue():
rmistry@google.com2dd99862015-06-22 12:22:18 +00003702 DieWithError('Current branch does not have an uploaded CL. We cannot set '
3703 'patchset dependencies without an uploaded CL.')
3704
3705 branches = RunGit(['for-each-ref',
3706 '--format=%(refname:short) %(upstream:short)',
3707 'refs/heads'])
3708 if not branches:
3709 print('No local branches found.')
3710 return 0
3711
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003712 # Create a dictionary of all local branches to the branches that are
3713 # dependent on it.
rmistry@google.com2dd99862015-06-22 12:22:18 +00003714 tracked_to_dependents = collections.defaultdict(list)
3715 for b in branches.splitlines():
3716 tokens = b.split()
3717 if len(tokens) == 2:
3718 branch_name, tracked = tokens
3719 tracked_to_dependents[tracked].append(branch_name)
3720
vapiera7fbd5a2016-06-16 09:17:49 -07003721 print()
3722 print('The dependent local branches of %s are:' % root_branch)
rmistry@google.com2dd99862015-06-22 12:22:18 +00003723 dependents = []
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003724
rmistry@google.com2dd99862015-06-22 12:22:18 +00003725 def traverse_dependents_preorder(branch, padding=''):
3726 dependents_to_process = tracked_to_dependents.get(branch, [])
3727 padding += ' '
3728 for dependent in dependents_to_process:
vapiera7fbd5a2016-06-16 09:17:49 -07003729 print('%s%s' % (padding, dependent))
rmistry@google.com2dd99862015-06-22 12:22:18 +00003730 dependents.append(dependent)
3731 traverse_dependents_preorder(dependent, padding)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003732
rmistry@google.com2dd99862015-06-22 12:22:18 +00003733 traverse_dependents_preorder(root_branch)
vapiera7fbd5a2016-06-16 09:17:49 -07003734 print()
rmistry@google.com2dd99862015-06-22 12:22:18 +00003735
3736 if not dependents:
vapiera7fbd5a2016-06-16 09:17:49 -07003737 print('There are no dependent local branches for %s' % root_branch)
rmistry@google.com2dd99862015-06-22 12:22:18 +00003738 return 0
3739
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01003740 confirm_or_exit('This command will checkout all dependent branches and run '
3741 '"git cl upload".', action='continue')
rmistry@google.com2dd99862015-06-22 12:22:18 +00003742
rmistry@google.com2dd99862015-06-22 12:22:18 +00003743 # Record all dependents that failed to upload.
3744 failures = {}
3745 # Go through all dependents, checkout the branch and upload.
3746 try:
3747 for dependent_branch in dependents:
vapiera7fbd5a2016-06-16 09:17:49 -07003748 print()
3749 print('--------------------------------------')
3750 print('Running "git cl upload" from %s:' % dependent_branch)
rmistry@google.com2dd99862015-06-22 12:22:18 +00003751 RunGit(['checkout', '-q', dependent_branch])
vapiera7fbd5a2016-06-16 09:17:49 -07003752 print()
rmistry@google.com2dd99862015-06-22 12:22:18 +00003753 try:
3754 if CMDupload(OptionParser(), args) != 0:
vapiera7fbd5a2016-06-16 09:17:49 -07003755 print('Upload failed for %s!' % dependent_branch)
rmistry@google.com2dd99862015-06-22 12:22:18 +00003756 failures[dependent_branch] = 1
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -08003757 except: # pylint: disable=bare-except
rmistry@google.com2dd99862015-06-22 12:22:18 +00003758 failures[dependent_branch] = 1
vapiera7fbd5a2016-06-16 09:17:49 -07003759 print()
rmistry@google.com2dd99862015-06-22 12:22:18 +00003760 finally:
3761 # Swap back to the original root branch.
3762 RunGit(['checkout', '-q', root_branch])
3763
vapiera7fbd5a2016-06-16 09:17:49 -07003764 print()
3765 print('Upload complete for dependent branches!')
rmistry@google.com2dd99862015-06-22 12:22:18 +00003766 for dependent_branch in dependents:
3767 upload_status = 'failed' if failures.get(dependent_branch) else 'succeeded'
vapiera7fbd5a2016-06-16 09:17:49 -07003768 print(' %s : %s' % (dependent_branch, upload_status))
3769 print()
rmistry@google.com2dd99862015-06-22 12:22:18 +00003770
3771 return 0
3772
3773
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003774@metrics.collector.collect_metrics('git cl archive')
kmarshall3bff56b2016-06-06 18:31:47 -07003775def CMDarchive(parser, args):
3776 """Archives and deletes branches associated with closed changelists."""
3777 parser.add_option(
3778 '-j', '--maxjobs', action='store', type=int,
kmarshall9249e012016-08-23 12:02:16 -07003779 help='The maximum number of jobs to use when retrieving review status.')
kmarshall3bff56b2016-06-06 18:31:47 -07003780 parser.add_option(
3781 '-f', '--force', action='store_true',
3782 help='Bypasses the confirmation prompt.')
kmarshall9249e012016-08-23 12:02:16 -07003783 parser.add_option(
3784 '-d', '--dry-run', action='store_true',
3785 help='Skip the branch tagging and removal steps.')
3786 parser.add_option(
3787 '-t', '--notags', action='store_true',
3788 help='Do not tag archived branches. '
3789 'Note: local commit history may be lost.')
kmarshall3bff56b2016-06-06 18:31:47 -07003790
kmarshall3bff56b2016-06-06 18:31:47 -07003791 options, args = parser.parse_args(args)
3792 if args:
3793 parser.error('Unsupported args: %s' % ' '.join(args))
kmarshall3bff56b2016-06-06 18:31:47 -07003794
3795 branches = RunGit(['for-each-ref', '--format=%(refname)', 'refs/heads'])
3796 if not branches:
3797 return 0
3798
vapiera7fbd5a2016-06-16 09:17:49 -07003799 print('Finding all branches associated with closed issues...')
Edward Lemur934836a2019-09-09 20:16:54 +00003800 changes = [Changelist(branchref=b)
3801 for b in branches.splitlines()]
kmarshall3bff56b2016-06-06 18:31:47 -07003802 alignment = max(5, max(len(c.GetBranch()) for c in changes))
3803 statuses = get_cl_statuses(changes,
3804 fine_grained=True,
3805 max_processes=options.maxjobs)
3806 proposal = [(cl.GetBranch(),
3807 'git-cl-archived-%s-%s' % (cl.GetIssue(), cl.GetBranch()))
3808 for cl, status in statuses
Andrii Shyshkalov51bdf8c2018-10-18 01:07:58 +00003809 if status in ('closed', 'rietveld-not-supported')]
kmarshall3bff56b2016-06-06 18:31:47 -07003810 proposal.sort()
3811
3812 if not proposal:
vapiera7fbd5a2016-06-16 09:17:49 -07003813 print('No branches with closed codereview issues found.')
kmarshall3bff56b2016-06-06 18:31:47 -07003814 return 0
3815
3816 current_branch = GetCurrentBranch()
3817
vapiera7fbd5a2016-06-16 09:17:49 -07003818 print('\nBranches with closed issues that will be archived:\n')
kmarshall9249e012016-08-23 12:02:16 -07003819 if options.notags:
3820 for next_item in proposal:
3821 print(' ' + next_item[0])
3822 else:
3823 print('%*s | %s' % (alignment, 'Branch name', 'Archival tag name'))
3824 for next_item in proposal:
3825 print('%*s %s' % (alignment, next_item[0], next_item[1]))
kmarshall3bff56b2016-06-06 18:31:47 -07003826
kmarshall9249e012016-08-23 12:02:16 -07003827 # Quit now on precondition failure or if instructed by the user, either
3828 # via an interactive prompt or by command line flags.
3829 if options.dry_run:
3830 print('\nNo changes were made (dry run).\n')
3831 return 0
3832 elif any(branch == current_branch for branch, _ in proposal):
kmarshall3bff56b2016-06-06 18:31:47 -07003833 print('You are currently on a branch \'%s\' which is associated with a '
3834 'closed codereview issue, so archive cannot proceed. Please '
3835 'checkout another branch and run this command again.' %
3836 current_branch)
3837 return 1
kmarshall9249e012016-08-23 12:02:16 -07003838 elif not options.force:
sergiyb4a5ecbe2016-06-20 09:46:00 -07003839 answer = ask_for_data('\nProceed with deletion (Y/n)? ').lower()
3840 if answer not in ('y', ''):
vapiera7fbd5a2016-06-16 09:17:49 -07003841 print('Aborted.')
kmarshall3bff56b2016-06-06 18:31:47 -07003842 return 1
3843
3844 for branch, tagname in proposal:
kmarshall9249e012016-08-23 12:02:16 -07003845 if not options.notags:
3846 RunGit(['tag', tagname, branch])
kmarshall3bff56b2016-06-06 18:31:47 -07003847 RunGit(['branch', '-D', branch])
kmarshall9249e012016-08-23 12:02:16 -07003848
vapiera7fbd5a2016-06-16 09:17:49 -07003849 print('\nJob\'s done!')
kmarshall3bff56b2016-06-06 18:31:47 -07003850
3851 return 0
3852
3853
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003854@metrics.collector.collect_metrics('git cl status')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003855def CMDstatus(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00003856 """Show status of changelists.
3857
3858 Colors are used to tell the state of the CL unless --fast is used:
jsbell@chromium.orgaeab41a2013-12-10 20:01:22 +00003859 - Blue waiting for review
Aaron Gable9ab38c62017-04-06 14:36:33 -07003860 - Yellow waiting for you to reply to review, or not yet sent
jsbell@chromium.orgaeab41a2013-12-10 20:01:22 +00003861 - Green LGTM'ed
Aaron Gable9ab38c62017-04-06 14:36:33 -07003862 - Red 'not LGTM'ed
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +00003863 - Magenta in the CQ
jsbell@chromium.orgaeab41a2013-12-10 20:01:22 +00003864 - Cyan was committed, branch can be deleted
Aaron Gable9ab38c62017-04-06 14:36:33 -07003865 - White error, or unknown status
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00003866
3867 Also see 'git cl comments'.
3868 """
Alan Cuttera3be9a52019-03-04 18:50:33 +00003869 parser.add_option(
3870 '--no-branch-color',
3871 action='store_true',
3872 help='Disable colorized branch names')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003873 parser.add_option('--field',
phajdan.jr289d03e2016-08-16 08:21:06 -07003874 help='print only specific field (desc|id|patch|status|url)')
maruel@chromium.org1033efd2013-07-23 23:25:09 +00003875 parser.add_option('-f', '--fast', action='store_true',
3876 help='Do not retrieve review status')
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00003877 parser.add_option(
3878 '-j', '--maxjobs', action='store', type=int,
3879 help='The maximum number of jobs to use when retrieving review status')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00003880
iannuccie53c9352016-08-17 14:40:40 -07003881 _add_codereview_issue_select_options(
3882 parser, 'Must be in conjunction with --field.')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00003883 options, args = parser.parse_args(args)
Edward Lemurf38bc172019-09-03 21:02:13 +00003884 _process_codereview_select_options(parser, options)
maruel@chromium.org39c0b222013-08-17 16:57:01 +00003885 if args:
3886 parser.error('Unsupported args: %s' % args)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003887
iannuccie53c9352016-08-17 14:40:40 -07003888 if options.issue is not None and not options.field:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00003889 parser.error('--field must be specified with --issue.')
iannucci3c972b92016-08-17 13:24:10 -07003890
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003891 if options.field:
Edward Lemur934836a2019-09-09 20:16:54 +00003892 cl = Changelist(issue=options.issue)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003893 if options.field.startswith('desc'):
vapiera7fbd5a2016-06-16 09:17:49 -07003894 print(cl.GetDescription())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003895 elif options.field == 'id':
3896 issueid = cl.GetIssue()
3897 if issueid:
vapiera7fbd5a2016-06-16 09:17:49 -07003898 print(issueid)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003899 elif options.field == 'patch':
Aaron Gablee8856ee2017-12-07 12:41:46 -08003900 patchset = cl.GetMostRecentPatchset()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003901 if patchset:
vapiera7fbd5a2016-06-16 09:17:49 -07003902 print(patchset)
phajdan.jr289d03e2016-08-16 08:21:06 -07003903 elif options.field == 'status':
3904 print(cl.GetStatus())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003905 elif options.field == 'url':
3906 url = cl.GetIssueURL()
3907 if url:
vapiera7fbd5a2016-06-16 09:17:49 -07003908 print(url)
maruel@chromium.orge25c75b2013-07-23 18:30:56 +00003909 return 0
3910
3911 branches = RunGit(['for-each-ref', '--format=%(refname)', 'refs/heads'])
3912 if not branches:
3913 print('No local branch found.')
3914 return 0
3915
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003916 changes = [
Edward Lemur934836a2019-09-09 20:16:54 +00003917 Changelist(branchref=b)
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003918 for b in branches.splitlines()]
vapiera7fbd5a2016-06-16 09:17:49 -07003919 print('Branches associated with reviews:')
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003920 output = get_cl_statuses(changes,
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00003921 fine_grained=not options.fast,
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003922 max_processes=options.maxjobs)
maruel@chromium.org1033efd2013-07-23 23:25:09 +00003923
Daniel McArdlea23bf592019-02-12 00:25:12 +00003924 current_branch = GetCurrentBranch()
3925
3926 def FormatBranchName(branch, colorize=False):
3927 """Simulates 'git branch' behavior. Colorizes and prefixes branch name with
3928 an asterisk when it is the current branch."""
3929
3930 asterisk = ""
3931 color = Fore.RESET
3932 if branch == current_branch:
3933 asterisk = "* "
3934 color = Fore.GREEN
3935 branch_name = ShortBranchName(branch)
3936
3937 if colorize:
3938 return asterisk + color + branch_name + Fore.RESET
Daniel McArdle452a49f2019-02-14 17:28:31 +00003939 return asterisk + branch_name
3940
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00003941 branch_statuses = {}
Daniel McArdlea23bf592019-02-12 00:25:12 +00003942
3943 alignment = max(5, max(len(FormatBranchName(c.GetBranch())) for c in changes))
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003944 for cl in sorted(changes, key=lambda c: c.GetBranch()):
3945 branch = cl.GetBranch()
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00003946 while branch not in branch_statuses:
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003947 c, status = output.next()
3948 branch_statuses[c.GetBranch()] = status
3949 status = branch_statuses.pop(branch)
3950 url = cl.GetIssueURL()
3951 if url and (not status or status == 'error'):
3952 # The issue probably doesn't exist anymore.
3953 url += ' (broken)'
3954
nodir@chromium.orga6de1f42015-06-10 04:23:17 +00003955 color = color_for_status(status)
maruel@chromium.org885f6512013-07-27 02:17:26 +00003956 reset = Fore.RESET
iannucci@chromium.org596cd5c2016-04-04 21:34:39 +00003957 if not setup_color.IS_TTY:
maruel@chromium.org885f6512013-07-27 02:17:26 +00003958 color = ''
3959 reset = ''
nodir@chromium.orga6de1f42015-06-10 04:23:17 +00003960 status_str = '(%s)' % status if status else ''
Daniel McArdle452a49f2019-02-14 17:28:31 +00003961
Alan Cuttera3be9a52019-03-04 18:50:33 +00003962 branch_display = FormatBranchName(branch)
3963 padding = ' ' * (alignment - len(branch_display))
3964 if not options.no_branch_color:
3965 branch_display = FormatBranchName(branch, colorize=True)
Daniel McArdle452a49f2019-02-14 17:28:31 +00003966
Alan Cuttera3be9a52019-03-04 18:50:33 +00003967 print(' %s : %s%s %s%s' % (padding + branch_display, color, url,
3968 status_str, reset))
Andrii Shyshkalovd0e1d9d2017-01-24 17:10:51 +01003969
vapiera7fbd5a2016-06-16 09:17:49 -07003970 print()
Daniel McArdlea23bf592019-02-12 00:25:12 +00003971 print('Current branch: %s' % current_branch)
Andrii Shyshkalovd0e1d9d2017-01-24 17:10:51 +01003972 for cl in changes:
Daniel McArdlea23bf592019-02-12 00:25:12 +00003973 if cl.GetBranch() == current_branch:
Andrii Shyshkalovd0e1d9d2017-01-24 17:10:51 +01003974 break
dpranke@chromium.orgee87f582015-07-31 18:46:25 +00003975 if not cl.GetIssue():
vapiera7fbd5a2016-06-16 09:17:49 -07003976 print('No issue assigned.')
dpranke@chromium.orgee87f582015-07-31 18:46:25 +00003977 return 0
vapiera7fbd5a2016-06-16 09:17:49 -07003978 print('Issue number: %s (%s)' % (cl.GetIssue(), cl.GetIssueURL()))
maruel@chromium.org85616e02014-07-28 15:37:55 +00003979 if not options.fast:
vapiera7fbd5a2016-06-16 09:17:49 -07003980 print('Issue description:')
3981 print(cl.GetDescription(pretty=True))
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003982 return 0
3983
3984
maruel@chromium.org39c0b222013-08-17 16:57:01 +00003985def colorize_CMDstatus_doc():
3986 """To be called once in main() to add colors to git cl status help."""
3987 colors = [i for i in dir(Fore) if i[0].isupper()]
3988
3989 def colorize_line(line):
3990 for color in colors:
3991 if color in line.upper():
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003992 # Extract whitespace first and the leading '-'.
maruel@chromium.org39c0b222013-08-17 16:57:01 +00003993 indent = len(line) - len(line.lstrip(' ')) + 1
3994 return line[:indent] + getattr(Fore, color) + line[indent:] + Fore.RESET
3995 return line
3996
3997 lines = CMDstatus.__doc__.splitlines()
3998 CMDstatus.__doc__ = '\n'.join(colorize_line(l) for l in lines)
3999
4000
phajdan.jre328cf92016-08-22 04:12:17 -07004001def write_json(path, contents):
Stefan Zager1306bd02017-06-22 19:26:46 -07004002 if path == '-':
4003 json.dump(contents, sys.stdout)
4004 else:
4005 with open(path, 'w') as f:
4006 json.dump(contents, f)
phajdan.jre328cf92016-08-22 04:12:17 -07004007
4008
maruel@chromium.org0633fb42013-08-16 20:06:14 +00004009@subcommand.usage('[issue_number]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004010@metrics.collector.collect_metrics('git cl issue')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004011def CMDissue(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004012 """Sets or displays the current code review issue number.
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004013
4014 Pass issue number 0 to clear the current issue.
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004015 """
dnj@chromium.org406c4402015-03-03 17:22:28 +00004016 parser.add_option('-r', '--reverse', action='store_true',
4017 help='Lookup the branch(es) for the specified issues. If '
4018 'no issues are specified, all branches with mapped '
4019 'issues will be listed.')
Stefan Zager1306bd02017-06-22 19:26:46 -07004020 parser.add_option('--json',
4021 help='Path to JSON output file, or "-" for stdout.')
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00004022 _add_codereview_select_options(parser)
dnj@chromium.org406c4402015-03-03 17:22:28 +00004023 options, args = parser.parse_args(args)
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00004024 _process_codereview_select_options(parser, options)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004025
dnj@chromium.org406c4402015-03-03 17:22:28 +00004026 if options.reverse:
4027 branches = RunGit(['for-each-ref', 'refs/heads',
Aaron Gablead64abd2017-12-04 09:49:13 -08004028 '--format=%(refname)']).splitlines()
dnj@chromium.org406c4402015-03-03 17:22:28 +00004029 # Reverse issue lookup.
4030 issue_branch_map = {}
Daniel Bratellb56a43a2018-09-06 15:49:03 +00004031
4032 git_config = {}
4033 for config in RunGit(['config', '--get-regexp',
4034 r'branch\..*issue']).splitlines():
4035 name, _space, val = config.partition(' ')
4036 git_config[name] = val
4037
dnj@chromium.org406c4402015-03-03 17:22:28 +00004038 for branch in branches:
Daniel Bratellb56a43a2018-09-06 15:49:03 +00004039 for cls in _CODEREVIEW_IMPLEMENTATIONS.values():
4040 config_key = _git_branch_config_key(ShortBranchName(branch),
4041 cls.IssueConfigKey())
4042 issue = git_config.get(config_key)
4043 if issue:
4044 issue_branch_map.setdefault(int(issue), []).append(branch)
dnj@chromium.org406c4402015-03-03 17:22:28 +00004045 if not args:
4046 args = sorted(issue_branch_map.iterkeys())
phajdan.jre328cf92016-08-22 04:12:17 -07004047 result = {}
dnj@chromium.org406c4402015-03-03 17:22:28 +00004048 for issue in args:
Lei Zhang5a368d42019-03-25 23:18:19 +00004049 try:
4050 issue_num = int(issue)
4051 except ValueError:
4052 print('ERROR cannot parse issue number: %s' % issue, file=sys.stderr)
dnj@chromium.org406c4402015-03-03 17:22:28 +00004053 continue
Lei Zhang5a368d42019-03-25 23:18:19 +00004054 result[issue_num] = issue_branch_map.get(issue_num)
vapiera7fbd5a2016-06-16 09:17:49 -07004055 print('Branch for issue number %s: %s' % (
Lei Zhang5a368d42019-03-25 23:18:19 +00004056 issue, ', '.join(issue_branch_map.get(issue_num) or ('None',))))
phajdan.jre328cf92016-08-22 04:12:17 -07004057 if options.json:
4058 write_json(options.json, result)
Aaron Gable78753da2017-06-15 10:35:49 -07004059 return 0
4060
4061 if len(args) > 0:
Edward Lemurf38bc172019-09-03 21:02:13 +00004062 issue = ParseIssueNumberArgument(args[0])
Aaron Gable78753da2017-06-15 10:35:49 -07004063 if not issue.valid:
4064 DieWithError('Pass a url or number to set the issue, 0 to unset it, '
4065 'or no argument to list it.\n'
4066 'Maybe you want to run git cl status?')
Edward Lemurf38bc172019-09-03 21:02:13 +00004067 cl = Changelist()
Aaron Gable78753da2017-06-15 10:35:49 -07004068 cl.SetIssue(issue.issue)
dnj@chromium.org406c4402015-03-03 17:22:28 +00004069 else:
Edward Lemurf38bc172019-09-03 21:02:13 +00004070 cl = Changelist()
Aaron Gable78753da2017-06-15 10:35:49 -07004071 print('Issue number: %s (%s)' % (cl.GetIssue(), cl.GetIssueURL()))
4072 if options.json:
4073 write_json(options.json, {
4074 'issue': cl.GetIssue(),
4075 'issue_url': cl.GetIssueURL(),
4076 })
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004077 return 0
4078
4079
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004080@metrics.collector.collect_metrics('git cl comments')
maruel@chromium.org9977a2e2012-06-06 22:30:56 +00004081def CMDcomments(parser, args):
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00004082 """Shows or posts review comments for any changelist."""
4083 parser.add_option('-a', '--add-comment', dest='comment',
4084 help='comment to add to an issue')
Sergiy Byelozyorovcb629a42018-10-28 19:20:39 +00004085 parser.add_option('-p', '--publish', action='store_true',
4086 help='marks CL as ready and sends comment to reviewers')
Andrii Shyshkalov0d6b46e2017-03-17 22:23:22 +01004087 parser.add_option('-i', '--issue', dest='issue',
Edward Lemurf38bc172019-09-03 21:02:13 +00004088 help='review issue id (defaults to current issue).')
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07004089 parser.add_option('-m', '--machine-readable', dest='readable',
4090 action='store_false', default=True,
4091 help='output comments in a format compatible with '
4092 'editor parsing')
smut@google.comc85ac942015-09-15 16:34:43 +00004093 parser.add_option('-j', '--json-file',
Stefan Zager1306bd02017-06-22 19:26:46 -07004094 help='File to write JSON summary to, or "-" for stdout')
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01004095 _add_codereview_select_options(parser)
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00004096 options, args = parser.parse_args(args)
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01004097 _process_codereview_select_options(parser, options)
maruel@chromium.org9977a2e2012-06-06 22:30:56 +00004098
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00004099 issue = None
4100 if options.issue:
4101 try:
4102 issue = int(options.issue)
4103 except ValueError:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004104 DieWithError('A review issue ID is expected to be a number.')
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00004105
Edward Lemur934836a2019-09-09 20:16:54 +00004106 cl = Changelist(issue=issue)
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00004107
4108 if options.comment:
Sergiy Byelozyorovcb629a42018-10-28 19:20:39 +00004109 cl.AddComment(options.comment, options.publish)
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00004110 return 0
4111
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07004112 summary = sorted(cl.GetCommentsSummary(readable=options.readable),
4113 key=lambda c: c.date)
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01004114 for comment in summary:
4115 if comment.disapproval:
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00004116 color = Fore.RED
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01004117 elif comment.approval:
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00004118 color = Fore.GREEN
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01004119 elif comment.sender == cl.GetIssueOwner():
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00004120 color = Fore.MAGENTA
Quinten Yearsley0e617c02019-02-20 00:37:03 +00004121 elif comment.autogenerated:
4122 color = Fore.CYAN
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00004123 else:
4124 color = Fore.BLUE
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01004125 print('\n%s%s %s%s\n%s' % (
4126 color,
4127 comment.date.strftime('%Y-%m-%d %H:%M:%S UTC'),
4128 comment.sender,
4129 Fore.RESET,
4130 '\n'.join(' ' + l for l in comment.message.strip().splitlines())))
4131
smut@google.comc85ac942015-09-15 16:34:43 +00004132 if options.json_file:
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01004133 def pre_serialize(c):
4134 dct = c.__dict__.copy()
4135 dct['date'] = dct['date'].strftime('%Y-%m-%d %H:%M:%S.%f')
4136 return dct
Leszek Swirski45b20c42018-09-17 17:05:26 +00004137 write_json(options.json_file, map(pre_serialize, summary))
maruel@chromium.org9977a2e2012-06-06 22:30:56 +00004138 return 0
4139
4140
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00004141@subcommand.usage('[codereview url or issue id]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004142@metrics.collector.collect_metrics('git cl description')
rsesek@chromium.orgeec76592013-05-20 16:27:57 +00004143def CMDdescription(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004144 """Brings up the editor for the current CL's description."""
smut@google.com34fb6b12015-07-13 20:03:26 +00004145 parser.add_option('-d', '--display', action='store_true',
4146 help='Display the description instead of opening an editor')
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00004147 parser.add_option('-n', '--new-description',
dnjba1b0f32016-09-02 12:37:42 -07004148 help='New description to set for this issue (- for stdin, '
4149 '+ to load from local commit HEAD)')
dsansomee2d6fd92016-09-08 00:10:47 -07004150 parser.add_option('-f', '--force', action='store_true',
4151 help='Delete any unpublished Gerrit edits for this issue '
4152 'without prompting')
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00004153
4154 _add_codereview_select_options(parser)
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00004155 options, args = parser.parse_args(args)
4156 _process_codereview_select_options(parser, options)
4157
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01004158 target_issue_arg = None
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00004159 if len(args) > 0:
Edward Lemurf38bc172019-09-03 21:02:13 +00004160 target_issue_arg = ParseIssueNumberArgument(args[0])
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01004161 if not target_issue_arg.valid:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004162 parser.error('Invalid issue ID or URL.')
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00004163
Edward Lemur934836a2019-09-09 20:16:54 +00004164 kwargs = {}
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004165 detected_codereview_from_url = False
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01004166 if target_issue_arg:
4167 kwargs['issue'] = target_issue_arg.issue
4168 kwargs['codereview_host'] = target_issue_arg.hostname
Edward Lemurf38bc172019-09-03 21:02:13 +00004169 if not args[0].isdigit() and not options.forced_codereview:
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004170 detected_codereview_from_url = True
martiniss6eda05f2016-06-30 10:18:35 -07004171
4172 cl = Changelist(**kwargs)
rsesek@chromium.orgeec76592013-05-20 16:27:57 +00004173 if not cl.GetIssue():
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004174 assert not detected_codereview_from_url
rsesek@chromium.orgeec76592013-05-20 16:27:57 +00004175 DieWithError('This branch has no associated changelist.')
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004176
4177 if detected_codereview_from_url:
Edward Lemurf38bc172019-09-03 21:02:13 +00004178 logging.info('canonical issue/change URL: %s\n', cl.GetIssueURL())
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004179
rsesek@chromium.orgeec76592013-05-20 16:27:57 +00004180 description = ChangeDescription(cl.GetDescription())
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00004181
smut@google.com34fb6b12015-07-13 20:03:26 +00004182 if options.display:
vapiera7fbd5a2016-06-16 09:17:49 -07004183 print(description.description)
smut@google.com34fb6b12015-07-13 20:03:26 +00004184 return 0
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00004185
4186 if options.new_description:
4187 text = options.new_description
4188 if text == '-':
4189 text = '\n'.join(l.rstrip() for l in sys.stdin)
dnjba1b0f32016-09-02 12:37:42 -07004190 elif text == '+':
4191 base_branch = cl.GetCommonAncestorWithUpstream()
4192 change = cl.GetChange(base_branch, None, local_description=True)
4193 text = change.FullDescriptionText()
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00004194
4195 description.set_description(text)
4196 else:
Edward Lemurf38bc172019-09-03 21:02:13 +00004197 description.prompt()
Andrii Shyshkalov680253d2017-03-15 21:07:36 +01004198 if cl.GetDescription().strip() != description.description:
dsansomee2d6fd92016-09-08 00:10:47 -07004199 cl.UpdateDescription(description.description, force=options.force)
rsesek@chromium.orgeec76592013-05-20 16:27:57 +00004200 return 0
4201
4202
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004203@metrics.collector.collect_metrics('git cl lint')
thestig@chromium.org44202a22014-03-11 19:22:18 +00004204def CMDlint(parser, args):
4205 """Runs cpplint on the current changelist."""
tzik@chromium.orgf204d4b2014-03-13 07:40:55 +00004206 parser.add_option('--filter', action='append', metavar='-x,+y',
4207 help='Comma-separated list of cpplint\'s category-filters')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004208 options, args = parser.parse_args(args)
thestig@chromium.org44202a22014-03-11 19:22:18 +00004209
4210 # Access to a protected member _XX of a client class
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -08004211 # pylint: disable=protected-access
thestig@chromium.org44202a22014-03-11 19:22:18 +00004212 try:
4213 import cpplint
4214 import cpplint_chromium
4215 except ImportError:
vapiera7fbd5a2016-06-16 09:17:49 -07004216 print('Your depot_tools is missing cpplint.py and/or cpplint_chromium.py.')
thestig@chromium.org44202a22014-03-11 19:22:18 +00004217 return 1
4218
4219 # Change the current working directory before calling lint so that it
4220 # shows the correct base.
4221 previous_cwd = os.getcwd()
4222 os.chdir(settings.GetRoot())
4223 try:
Edward Lemur934836a2019-09-09 20:16:54 +00004224 cl = Changelist()
thestig@chromium.org44202a22014-03-11 19:22:18 +00004225 change = cl.GetChange(cl.GetCommonAncestorWithUpstream(), None)
4226 files = [f.LocalPath() for f in change.AffectedFiles()]
thestig@chromium.org5839eb52014-05-30 16:20:51 +00004227 if not files:
vapiera7fbd5a2016-06-16 09:17:49 -07004228 print('Cannot lint an empty CL')
thestig@chromium.org5839eb52014-05-30 16:20:51 +00004229 return 1
thestig@chromium.org44202a22014-03-11 19:22:18 +00004230
4231 # Process cpplints arguments if any.
tzik@chromium.orgf204d4b2014-03-13 07:40:55 +00004232 command = args + files
4233 if options.filter:
4234 command = ['--filter=' + ','.join(options.filter)] + command
4235 filenames = cpplint.ParseArguments(command)
thestig@chromium.org44202a22014-03-11 19:22:18 +00004236
4237 white_regex = re.compile(settings.GetLintRegex())
4238 black_regex = re.compile(settings.GetLintIgnoreRegex())
4239 extra_check_functions = [cpplint_chromium.CheckPointerDeclarationWhitespace]
4240 for filename in filenames:
4241 if white_regex.match(filename):
4242 if black_regex.match(filename):
vapiera7fbd5a2016-06-16 09:17:49 -07004243 print('Ignoring file %s' % filename)
thestig@chromium.org44202a22014-03-11 19:22:18 +00004244 else:
4245 cpplint.ProcessFile(filename, cpplint._cpplint_state.verbose_level,
4246 extra_check_functions)
4247 else:
vapiera7fbd5a2016-06-16 09:17:49 -07004248 print('Skipping file %s' % filename)
thestig@chromium.org44202a22014-03-11 19:22:18 +00004249 finally:
4250 os.chdir(previous_cwd)
vapiera7fbd5a2016-06-16 09:17:49 -07004251 print('Total errors found: %d\n' % cpplint._cpplint_state.error_count)
thestig@chromium.org44202a22014-03-11 19:22:18 +00004252 if cpplint._cpplint_state.error_count != 0:
4253 return 1
4254 return 0
4255
4256
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004257@metrics.collector.collect_metrics('git cl presubmit')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004258def CMDpresubmit(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004259 """Runs presubmit tests on the current changelist."""
ilevy@chromium.org375a9022013-01-07 01:12:05 +00004260 parser.add_option('-u', '--upload', action='store_true',
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004261 help='Run upload hook instead of the push hook')
ilevy@chromium.org375a9022013-01-07 01:12:05 +00004262 parser.add_option('-f', '--force', action='store_true',
sbc@chromium.org495ad152012-09-04 23:07:42 +00004263 help='Run checks even if tree is dirty')
Aaron Gable8076c282017-11-29 14:39:41 -08004264 parser.add_option('--all', action='store_true',
4265 help='Run checks against all files, not just modified ones')
Edward Lesmes8e282792018-04-03 18:50:29 -04004266 parser.add_option('--parallel', action='store_true',
4267 help='Run all tests specified by input_api.RunTests in all '
4268 'PRESUBMIT files in parallel.')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004269 options, args = parser.parse_args(args)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004270
sbc@chromium.org71437c02015-04-09 19:29:40 +00004271 if not options.force and git_common.is_dirty_git_tree('presubmit'):
vapiera7fbd5a2016-06-16 09:17:49 -07004272 print('use --force to check even if tree is dirty.')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004273 return 1
4274
Edward Lemur934836a2019-09-09 20:16:54 +00004275 cl = Changelist()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004276 if args:
4277 base_branch = args[0]
4278 else:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00004279 # Default to diffing against the common ancestor of the upstream branch.
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00004280 base_branch = cl.GetCommonAncestorWithUpstream()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004281
Aaron Gable8076c282017-11-29 14:39:41 -08004282 if options.all:
4283 base_change = cl.GetChange(base_branch, None)
4284 files = [('M', f) for f in base_change.AllFiles()]
4285 change = presubmit_support.GitChange(
4286 base_change.Name(),
4287 base_change.FullDescriptionText(),
4288 base_change.RepositoryRoot(),
4289 files,
4290 base_change.issue,
4291 base_change.patchset,
4292 base_change.author_email,
4293 base_change._upstream)
4294 else:
4295 change = cl.GetChange(base_branch, None)
4296
ilevy@chromium.org051ad0e2013-03-04 21:57:34 +00004297 cl.RunHook(
4298 committing=not options.upload,
4299 may_prompt=False,
4300 verbose=options.verbose,
Edward Lesmes8e282792018-04-03 18:50:29 -04004301 change=change,
4302 parallel=options.parallel)
dpranke@chromium.org0a2bb372011-03-25 01:16:22 +00004303 return 0
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004304
4305
tandrii@chromium.org65874e12016-03-04 12:03:02 +00004306def GenerateGerritChangeId(message):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004307 """Returns the Change ID footer value (Ixxxxxx...xxx).
tandrii@chromium.org65874e12016-03-04 12:03:02 +00004308
4309 Works the same way as
4310 https://gerrit-review.googlesource.com/tools/hooks/commit-msg
4311 but can be called on demand on all platforms.
4312
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004313 The basic idea is to generate git hash of a state of the tree, original
4314 commit message, author/committer info and timestamps.
tandrii@chromium.org65874e12016-03-04 12:03:02 +00004315 """
4316 lines = []
4317 tree_hash = RunGitSilent(['write-tree'])
4318 lines.append('tree %s' % tree_hash.strip())
4319 code, parent = RunGitWithCode(['rev-parse', 'HEAD~0'], suppress_stderr=False)
4320 if code == 0:
4321 lines.append('parent %s' % parent.strip())
4322 author = RunGitSilent(['var', 'GIT_AUTHOR_IDENT'])
4323 lines.append('author %s' % author.strip())
4324 committer = RunGitSilent(['var', 'GIT_COMMITTER_IDENT'])
4325 lines.append('committer %s' % committer.strip())
4326 lines.append('')
4327 # Note: Gerrit's commit-hook actually cleans message of some lines and
4328 # whitespace. This code is not doing this, but it clearly won't decrease
4329 # entropy.
4330 lines.append(message)
4331 change_hash = RunCommand(['git', 'hash-object', '-t', 'commit', '--stdin'],
Raul Tambreb946b232019-03-26 14:48:46 +00004332 stdin=('\n'.join(lines)).encode())
tandrii@chromium.org65874e12016-03-04 12:03:02 +00004333 return 'I%s' % change_hash.strip()
4334
4335
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01004336def GetTargetRef(remote, remote_branch, target_branch):
wittman@chromium.org455dc922015-01-26 20:15:50 +00004337 """Computes the remote branch ref to use for the CL.
4338
4339 Args:
4340 remote (str): The git remote for the CL.
4341 remote_branch (str): The git remote branch for the CL.
4342 target_branch (str): The target branch specified by the user.
wittman@chromium.org455dc922015-01-26 20:15:50 +00004343 """
4344 if not (remote and remote_branch):
4345 return None
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00004346
wittman@chromium.org455dc922015-01-26 20:15:50 +00004347 if target_branch:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07004348 # Canonicalize branch references to the equivalent local full symbolic
wittman@chromium.org455dc922015-01-26 20:15:50 +00004349 # refs, which are then translated into the remote full symbolic refs
4350 # below.
4351 if '/' not in target_branch:
4352 remote_branch = 'refs/remotes/%s/%s' % (remote, target_branch)
4353 else:
4354 prefix_replacements = (
4355 ('^((refs/)?remotes/)?branch-heads/', 'refs/remotes/branch-heads/'),
4356 ('^((refs/)?remotes/)?%s/' % remote, 'refs/remotes/%s/' % remote),
4357 ('^(refs/)?heads/', 'refs/remotes/%s/' % remote),
4358 )
4359 match = None
4360 for regex, replacement in prefix_replacements:
4361 match = re.search(regex, target_branch)
4362 if match:
4363 remote_branch = target_branch.replace(match.group(0), replacement)
4364 break
4365 if not match:
4366 # This is a branch path but not one we recognize; use as-is.
4367 remote_branch = target_branch
rmistry@google.comc68112d2015-03-03 12:48:06 +00004368 elif remote_branch in REFS_THAT_ALIAS_TO_OTHER_REFS:
4369 # Handle the refs that need to land in different refs.
4370 remote_branch = REFS_THAT_ALIAS_TO_OTHER_REFS[remote_branch]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00004371
wittman@chromium.org455dc922015-01-26 20:15:50 +00004372 # Create the true path to the remote branch.
4373 # Does the following translation:
4374 # * refs/remotes/origin/refs/diff/test -> refs/diff/test
4375 # * refs/remotes/origin/master -> refs/heads/master
4376 # * refs/remotes/branch-heads/test -> refs/branch-heads/test
4377 if remote_branch.startswith('refs/remotes/%s/refs/' % remote):
4378 remote_branch = remote_branch.replace('refs/remotes/%s/' % remote, '')
4379 elif remote_branch.startswith('refs/remotes/%s/' % remote):
4380 remote_branch = remote_branch.replace('refs/remotes/%s/' % remote,
4381 'refs/heads/')
4382 elif remote_branch.startswith('refs/remotes/branch-heads'):
4383 remote_branch = remote_branch.replace('refs/remotes/', 'refs/')
Andrii Shyshkalov768f1d82016-12-08 15:10:13 +01004384
wittman@chromium.org455dc922015-01-26 20:15:50 +00004385 return remote_branch
4386
4387
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00004388def cleanup_list(l):
4389 """Fixes a list so that comma separated items are put as individual items.
4390
4391 So that "--reviewers joe@c,john@c --reviewers joa@c" results in
4392 options.reviewers == sorted(['joe@c', 'john@c', 'joa@c']).
4393 """
4394 items = sum((i.split(',') for i in l), [])
4395 stripped_items = (i.strip() for i in items)
4396 return sorted(filter(None, stripped_items))
4397
4398
Aaron Gable4db38df2017-11-03 14:59:07 -07004399@subcommand.usage('[flags]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004400@metrics.collector.collect_metrics('git cl upload')
ukai@chromium.orge8077812012-02-03 03:41:46 +00004401def CMDupload(parser, args):
rmistry@google.com78948ed2015-07-08 23:09:57 +00004402 """Uploads the current changelist to codereview.
4403
4404 Can skip dependency patchset uploads for a branch by running:
4405 git config branch.branch_name.skip-deps-uploads True
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004406 To unset, run:
rmistry@google.com78948ed2015-07-08 23:09:57 +00004407 git config --unset branch.branch_name.skip-deps-uploads
4408 Can also set the above globally by using the --global flag.
Dominic Battre7d1c4842017-10-27 09:17:28 +02004409
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004410 If the name of the checked out branch starts with "bug-" or "fix-" followed
4411 by a bug number, this bug number is automatically populated in the CL
Dominic Battre7d1c4842017-10-27 09:17:28 +02004412 description.
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004413
4414 If subject contains text in square brackets or has "<text>: " prefix, such
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004415 text(s) is treated as Gerrit hashtags. For example, CLs with subjects:
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004416 [git-cl] add support for hashtags
4417 Foo bar: implement foo
4418 will be hashtagged with "git-cl" and "foo-bar" respectively.
rmistry@google.com78948ed2015-07-08 23:09:57 +00004419 """
ukai@chromium.orge8077812012-02-03 03:41:46 +00004420 parser.add_option('--bypass-hooks', action='store_true', dest='bypass_hooks',
4421 help='bypass upload presubmit hook')
brettw@chromium.orgb65c43c2013-06-10 22:04:49 +00004422 parser.add_option('--bypass-watchlists', action='store_true',
4423 dest='bypass_watchlists',
4424 help='bypass watchlists auto CC-ing reviewers')
Aaron Gablef7543cd2017-07-20 14:26:31 -07004425 parser.add_option('-f', '--force', action='store_true', dest='force',
ukai@chromium.orge8077812012-02-03 03:41:46 +00004426 help="force yes to questions (don't prompt)")
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004427 parser.add_option('--message', '-m', dest='message',
4428 help='message for patchset')
tandriif9aefb72016-07-01 09:06:51 -07004429 parser.add_option('-b', '--bug',
4430 help='pre-populate the bug number(s) for this issue. '
4431 'If several, separate with commas')
tandriib80458a2016-06-23 12:20:07 -07004432 parser.add_option('--message-file', dest='message_file',
4433 help='file which contains message for patchset')
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004434 parser.add_option('--title', '-t', dest='title',
4435 help='title for patchset')
ukai@chromium.orge8077812012-02-03 03:41:46 +00004436 parser.add_option('-r', '--reviewers',
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00004437 action='append', default=[],
ukai@chromium.orge8077812012-02-03 03:41:46 +00004438 help='reviewer email addresses')
Robert Iannucci6c98dc62017-04-18 11:38:00 -07004439 parser.add_option('--tbrs',
4440 action='append', default=[],
4441 help='TBR email addresses')
ukai@chromium.orge8077812012-02-03 03:41:46 +00004442 parser.add_option('--cc',
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00004443 action='append', default=[],
ukai@chromium.orge8077812012-02-03 03:41:46 +00004444 help='cc email addresses')
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004445 parser.add_option('--hashtag', dest='hashtags',
4446 action='append', default=[],
4447 help=('Gerrit hashtag for new CL; '
4448 'can be applied multiple times'))
adamk@chromium.org36f47302013-04-05 01:08:31 +00004449 parser.add_option('-s', '--send-mail', action='store_true',
Aaron Gable59f48512017-01-12 10:54:46 -08004450 help='send email to reviewer(s) and cc(s) immediately')
ukai@chromium.org8ef7ab22012-11-28 04:24:52 +00004451 parser.add_option('--target_branch',
pgervais@chromium.orgb9f27512014-08-08 15:52:33 +00004452 '--target-branch',
wittman@chromium.org455dc922015-01-26 20:15:50 +00004453 metavar='TARGET',
4454 help='Apply CL to remote ref TARGET. ' +
4455 'Default: remote branch head, or master')
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00004456 parser.add_option('--squash', action='store_true',
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004457 help='Squash multiple commits into one')
Mike Frysingera989d552019-08-14 20:51:23 +00004458 parser.add_option('--no-squash', action='store_false', dest='squash',
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004459 help='Don\'t squash multiple commits into one')
rmistry9eadede2016-09-19 11:22:43 -07004460 parser.add_option('--topic', default=None,
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004461 help='Topic to specify when uploading')
Robert Iannuccif2708bd2017-04-17 15:49:02 -07004462 parser.add_option('--tbr-owners', dest='add_owners_to', action='store_const',
4463 const='TBR', help='add a set of OWNERS to TBR')
4464 parser.add_option('--r-owners', dest='add_owners_to', action='store_const',
4465 const='R', help='add a set of OWNERS to R')
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +00004466 parser.add_option('-c', '--use-commit-queue', action='store_true',
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004467 default=False,
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +00004468 help='tell the CQ to commit this patchset; '
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004469 'implies --send-mail')
4470 parser.add_option('-d', '--cq-dry-run',
4471 action='store_true', default=False,
rmistry@google.comef966222015-04-07 11:15:01 +00004472 help='Send the patchset to do a CQ dry run right after '
4473 'upload.')
Andrii Shyshkalov71f0da32019-07-15 22:45:18 +00004474 parser.add_option('--preserve-tryjobs', action='store_true',
4475 help='instruct the CQ to let tryjobs running even after '
4476 'new patchsets are uploaded instead of canceling '
4477 'prior patchset\' tryjobs')
rmistry@google.com2dd99862015-06-22 12:22:18 +00004478 parser.add_option('--dependencies', action='store_true',
4479 help='Uploads CLs of all the local branches that depend on '
4480 'the current branch')
Ravi Mistry31e7d562018-04-02 12:53:57 -04004481 parser.add_option('-a', '--enable-auto-submit', action='store_true',
4482 help='Sends your change to the CQ after an approval. Only '
4483 'works on repos that have the Auto-Submit label '
4484 'enabled')
Edward Lesmes8e282792018-04-03 18:50:29 -04004485 parser.add_option('--parallel', action='store_true',
4486 help='Run all tests specified by input_api.RunTests in all '
4487 'PRESUBMIT files in parallel.')
Sergiy Byelozyorov1aa405f2018-09-18 17:38:43 +00004488 parser.add_option('--no-autocc', action='store_true',
4489 help='Disables automatic addition of CC emails')
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004490 parser.add_option('--private', action='store_true',
Sergiy Byelozyorov1aa405f2018-09-18 17:38:43 +00004491 help='Set the review private. This implies --no-autocc.')
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004492 parser.add_option('-R', '--retry-failed', action='store_true',
4493 help='Retry failed tryjobs from old patchset immediately '
4494 'after uploading new patchset. Cannot be used with '
4495 '--use-commit-queue or --cq-dry-run.')
4496 parser.add_option('--buildbucket-host', default='cr-buildbucket.appspot.com',
4497 help='Host of buildbucket. The default host is %default.')
4498 auth.add_auth_options(parser)
Sergiy Byelozyorov1aa405f2018-09-18 17:38:43 +00004499
rmistry@google.com2dd99862015-06-22 12:22:18 +00004500 orig_args = args
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00004501 _add_codereview_select_options(parser)
ukai@chromium.orge8077812012-02-03 03:41:46 +00004502 (options, args) = parser.parse_args(args)
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00004503 _process_codereview_select_options(parser, options)
ukai@chromium.orge8077812012-02-03 03:41:46 +00004504
sbc@chromium.org71437c02015-04-09 19:29:40 +00004505 if git_common.is_dirty_git_tree('upload'):
ukai@chromium.orge8077812012-02-03 03:41:46 +00004506 return 1
4507
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00004508 options.reviewers = cleanup_list(options.reviewers)
Robert Iannucci6c98dc62017-04-18 11:38:00 -07004509 options.tbrs = cleanup_list(options.tbrs)
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00004510 options.cc = cleanup_list(options.cc)
4511
tandriib80458a2016-06-23 12:20:07 -07004512 if options.message_file:
4513 if options.message:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004514 parser.error('Only one of --message and --message-file allowed.')
tandriib80458a2016-06-23 12:20:07 -07004515 options.message = gclient_utils.FileRead(options.message_file)
4516 options.message_file = None
4517
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004518 if ([options.cq_dry_run,
4519 options.use_commit_queue,
4520 options.retry_failed].count(True) > 1):
4521 parser.error('Only one of --use-commit-queue, --cq-dry-run, or '
4522 '--retry-failed is allowed.')
tandrii4d0545a2016-07-06 03:56:49 -07004523
Aaron Gableedbc4132017-09-11 13:22:28 -07004524 if options.use_commit_queue:
4525 options.send_mail = True
4526
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00004527 # For sanity of test expectations, do this otherwise lazy-loading *now*.
4528 settings.GetIsGerrit()
4529
Edward Lemur934836a2019-09-09 20:16:54 +00004530 cl = Changelist()
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004531 if options.retry_failed and not cl.GetIssue():
4532 print('No previous patchsets, so --retry-failed has no effect.')
4533 options.retry_failed = False
4534 # cl.GetMostRecentPatchset uses cached information, and can return the last
4535 # patchset before upload. Calling it here makes it clear that it's the
4536 # last patchset before upload. Note that GetMostRecentPatchset will fail
4537 # if no CL has been uploaded yet.
4538 if options.retry_failed:
4539 patchset = cl.GetMostRecentPatchset()
Andrii Shyshkalov9f274432018-10-15 16:40:23 +00004540
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004541 ret = cl.CMDUpload(options, args, orig_args)
4542
4543 if options.retry_failed:
4544 if ret != 0:
4545 print('Upload failed, so --retry-failed has no effect.')
4546 return ret
4547 auth_config = auth.extract_auth_config_from_options(options)
4548 builds = fetch_try_jobs(
4549 auth_config, cl, options.buildbucket_host, patchset)
4550 buckets = _filter_failed(builds)
4551 if len(buckets) == 0:
4552 print('No failed tryjobs, so --retry-failed has no effect.')
4553 return ret
4554 _trigger_try_jobs(auth_config, cl, buckets, options, patchset + 1)
4555
4556 return ret
ukai@chromium.orge8077812012-02-03 03:41:46 +00004557
4558
Francois Dorayd42c6812017-05-30 15:10:20 -04004559@subcommand.usage('--description=<description file>')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004560@metrics.collector.collect_metrics('git cl split')
Francois Dorayd42c6812017-05-30 15:10:20 -04004561def CMDsplit(parser, args):
4562 """Splits a branch into smaller branches and uploads CLs.
4563
4564 Creates a branch and uploads a CL for each group of files modified in the
4565 current branch that share a common OWNERS file. In the CL description and
Quinten Yearsley0c62da92017-05-31 13:39:42 -07004566 comment, the string '$directory', is replaced with the directory containing
Francois Dorayd42c6812017-05-30 15:10:20 -04004567 the shared OWNERS file.
4568 """
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004569 parser.add_option('-d', '--description', dest='description_file',
4570 help='A text file containing a CL description in which '
4571 '$directory will be replaced by each CL\'s directory.')
4572 parser.add_option('-c', '--comment', dest='comment_file',
4573 help='A text file containing a CL comment.')
4574 parser.add_option('-n', '--dry-run', dest='dry_run', action='store_true',
Chris Watkinsba28e462017-12-13 11:22:17 +11004575 default=False,
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004576 help='List the files and reviewers for each CL that would '
4577 'be created, but don\'t create branches or CLs.')
4578 parser.add_option('--cq-dry-run', action='store_true',
4579 help='If set, will do a cq dry run for each uploaded CL. '
4580 'Please be careful when doing this; more than ~10 CLs '
4581 'has the potential to overload our build '
4582 'infrastructure. Try to upload these not during high '
4583 'load times (usually 11-3 Mountain View time). Email '
4584 'infra-dev@chromium.org with any questions.')
Takuto Ikuta51eca592019-02-14 19:40:52 +00004585 parser.add_option('-a', '--enable-auto-submit', action='store_true',
4586 default=True,
4587 help='Sends your change to the CQ after an approval. Only '
4588 'works on repos that have the Auto-Submit label '
4589 'enabled')
Francois Dorayd42c6812017-05-30 15:10:20 -04004590 options, _ = parser.parse_args(args)
4591
4592 if not options.description_file:
4593 parser.error('No --description flag specified.')
4594
4595 def WrappedCMDupload(args):
4596 return CMDupload(OptionParser(), args)
4597
4598 return split_cl.SplitCl(options.description_file, options.comment_file,
Stephen Martiniscb326682018-08-29 21:06:30 +00004599 Changelist, WrappedCMDupload, options.dry_run,
Takuto Ikuta51eca592019-02-14 19:40:52 +00004600 options.cq_dry_run, options.enable_auto_submit)
Francois Dorayd42c6812017-05-30 15:10:20 -04004601
4602
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004603@subcommand.usage('DEPRECATED')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004604@metrics.collector.collect_metrics('git cl commit')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004605def CMDdcommit(parser, args):
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004606 """DEPRECATED: Used to commit the current changelist via git-svn."""
4607 message = ('git-cl no longer supports committing to SVN repositories via '
4608 'git-svn. You probably want to use `git cl land` instead.')
4609 print(message)
4610 return 1
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004611
4612
maruel@chromium.org0633fb42013-08-16 20:06:14 +00004613@subcommand.usage('[upstream branch to apply against]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004614@metrics.collector.collect_metrics('git cl land')
pgervais@chromium.orgcee6dc42014-05-07 17:04:03 +00004615def CMDland(parser, args):
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004616 """Commits the current changelist via git.
4617
4618 In case of Gerrit, uses Gerrit REST api to "submit" the issue, which pushes
4619 upstream and closes the issue automatically and atomically.
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004620 """
4621 parser.add_option('--bypass-hooks', action='store_true', dest='bypass_hooks',
4622 help='bypass upload presubmit hook')
Aaron Gablef7543cd2017-07-20 14:26:31 -07004623 parser.add_option('-f', '--force', action='store_true', dest='force',
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004624 help="force yes to questions (don't prompt)")
Edward Lesmes67b3faa2018-04-13 17:50:52 -04004625 parser.add_option('--parallel', action='store_true',
4626 help='Run all tests specified by input_api.RunTests in all '
4627 'PRESUBMIT files in parallel.')
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004628 (options, args) = parser.parse_args(args)
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004629
Edward Lemur934836a2019-09-09 20:16:54 +00004630 cl = Changelist()
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004631
Robert Iannucci2e73d432018-03-14 01:10:47 -07004632 if not cl.GetIssue():
4633 DieWithError('You must upload the change first to Gerrit.\n'
4634 ' If you would rather have `git cl land` upload '
4635 'automatically for you, see http://crbug.com/642759')
Edward Lemur125d60a2019-09-13 18:25:41 +00004636 return cl.CMDLand(options.force, options.bypass_hooks,
Olivier Robin75ee7252018-04-13 10:02:56 +02004637 options.verbose, options.parallel)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004638
4639
dsinclair@chromium.orgfbed6562015-09-25 21:22:36 +00004640@subcommand.usage('<patch url or issue id or issue url>')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004641@metrics.collector.collect_metrics('git cl patch')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004642def CMDpatch(parser, args):
marq@chromium.orge5e59002013-10-02 23:21:25 +00004643 """Patches in a code review."""
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004644 parser.add_option('-b', dest='newbranch',
4645 help='create a new branch off trunk for the patch')
qsr@chromium.org1ef44af2013-10-16 16:24:32 +00004646 parser.add_option('-f', '--force', action='store_true',
Aaron Gable62619a32017-06-16 08:22:09 -07004647 help='overwrite state on the current or chosen branch')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004648 parser.add_option('-n', '--no-commit', action='store_true', dest='nocommit',
Edward Lemurf38bc172019-09-03 21:02:13 +00004649 help='don\'t commit after patch applies.')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004650
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00004651 group = optparse.OptionGroup(
4652 parser,
4653 'Options for continuing work on the current issue uploaded from a '
4654 'different clone (e.g. different machine). Must be used independently '
4655 'from the other options. No issue number should be specified, and the '
4656 'branch must have an issue number associated with it')
4657 group.add_option('--reapply', action='store_true', dest='reapply',
4658 help='Reset the branch and reapply the issue.\n'
4659 'CAUTION: This will undo any local changes in this '
4660 'branch')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004661
4662 group.add_option('--pull', action='store_true', dest='pull',
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00004663 help='Performs a pull before reapplying.')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004664 parser.add_option_group(group)
4665
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00004666 _add_codereview_select_options(parser)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004667 (options, args) = parser.parse_args(args)
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00004668 _process_codereview_select_options(parser, options)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004669
Andrii Shyshkalov18975322017-01-25 16:44:13 +01004670 if options.reapply:
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004671 if options.newbranch:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004672 parser.error('--reapply works on the current branch only.')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004673 if len(args) > 0:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004674 parser.error('--reapply implies no additional arguments.')
dsinclair@chromium.orgfbed6562015-09-25 21:22:36 +00004675
Edward Lemur934836a2019-09-09 20:16:54 +00004676 cl = Changelist()
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004677 if not cl.GetIssue():
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004678 parser.error('Current branch must have an associated issue.')
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004679
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004680 upstream = cl.GetUpstreamBranch()
Andrii Shyshkalov18975322017-01-25 16:44:13 +01004681 if upstream is None:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004682 parser.error('No upstream branch specified. Cannot reset branch.')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004683
4684 RunGit(['reset', '--hard', upstream])
4685 if options.pull:
4686 RunGit(['pull'])
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004687
Edward Lemurf38bc172019-09-03 21:02:13 +00004688 return cl.CMDPatchIssue(cl.GetIssue(), options.nocommit)
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004689
4690 if len(args) != 1 or not args[0]:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004691 parser.error('Must specify issue number or URL.')
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004692
Edward Lemurf38bc172019-09-03 21:02:13 +00004693 target_issue_arg = ParseIssueNumberArgument(args[0])
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004694 if not target_issue_arg.valid:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004695 parser.error('Invalid issue ID or URL.')
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004696
4697 cl_kwargs = {
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004698 'codereview_host': target_issue_arg.hostname,
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004699 }
4700 detected_codereview_from_url = False
Edward Lemurf38bc172019-09-03 21:02:13 +00004701 if not args[0].isdigit() and not options.forced_codereview:
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004702 detected_codereview_from_url = True
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004703 cl_kwargs['issue'] = target_issue_arg.issue
4704
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004705 # We don't want uncommitted changes mixed up with the patch.
4706 if git_common.is_dirty_git_tree('patch'):
dsinclair@chromium.orgfbed6562015-09-25 21:22:36 +00004707 return 1
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004708
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004709 if options.newbranch:
4710 if options.force:
4711 RunGit(['branch', '-D', options.newbranch],
4712 stderr=subprocess2.PIPE, error_ok=True)
4713 RunGit(['new-branch', options.newbranch])
4714
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004715 cl = Changelist(**cl_kwargs)
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004716
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004717 if detected_codereview_from_url:
Edward Lemurf38bc172019-09-03 21:02:13 +00004718 print('canonical issue/change URL: %s\n' % cl.GetIssueURL())
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004719
Edward Lemurf38bc172019-09-03 21:02:13 +00004720 return cl.CMDPatchWithParsedIssue(
4721 target_issue_arg, options.nocommit, options.force)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004722
4723
jochen@chromium.org3ec0d542014-01-14 20:00:03 +00004724def GetTreeStatus(url=None):
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004725 """Fetches the tree status and returns either 'open', 'closed',
4726 'unknown' or 'unset'."""
jochen@chromium.org3ec0d542014-01-14 20:00:03 +00004727 url = url or settings.GetTreeStatusUrl(error_ok=True)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004728 if url:
4729 status = urllib2.urlopen(url).read().lower()
4730 if status.find('closed') != -1 or status == '0':
4731 return 'closed'
4732 elif status.find('open') != -1 or status == '1':
4733 return 'open'
4734 return 'unknown'
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004735 return 'unset'
4736
dpranke@chromium.org970c5222011-03-12 00:32:24 +00004737
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004738def GetTreeStatusReason():
4739 """Fetches the tree status from a json url and returns the message
4740 with the reason for the tree to be opened or closed."""
msb@chromium.orgbf1a7ba2011-02-01 16:21:46 +00004741 url = settings.GetTreeStatusUrl()
4742 json_url = urlparse.urljoin(url, '/current?format=json')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004743 connection = urllib2.urlopen(json_url)
4744 status = json.loads(connection.read())
4745 connection.close()
4746 return status['message']
4747
dpranke@chromium.org970c5222011-03-12 00:32:24 +00004748
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004749@metrics.collector.collect_metrics('git cl tree')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004750def CMDtree(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004751 """Shows the status of the tree."""
dpranke@chromium.org97ae58e2011-03-18 00:29:20 +00004752 _, args = parser.parse_args(args)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004753 status = GetTreeStatus()
4754 if 'unset' == status:
vapiera7fbd5a2016-06-16 09:17:49 -07004755 print('You must configure your tree status URL by running "git cl config".')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004756 return 2
4757
vapiera7fbd5a2016-06-16 09:17:49 -07004758 print('The tree is %s' % status)
4759 print()
4760 print(GetTreeStatusReason())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004761 if status != 'open':
4762 return 1
4763 return 0
4764
4765
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004766@metrics.collector.collect_metrics('git cl try')
maruel@chromium.org15192402012-09-06 12:38:29 +00004767def CMDtry(parser, args):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004768 """Triggers tryjobs using either Buildbucket or CQ dry run."""
4769 group = optparse.OptionGroup(parser, 'Tryjob options')
maruel@chromium.org15192402012-09-06 12:38:29 +00004770 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004771 '-b', '--bot', action='append',
4772 help=('IMPORTANT: specify ONE builder per --bot flag. Use it multiple '
4773 'times to specify multiple builders. ex: '
4774 '"-b win_rel -b win_layout". See '
4775 'the try server waterfall for the builders name and the tests '
4776 'available.'))
maruel@chromium.org15192402012-09-06 12:38:29 +00004777 group.add_option(
borenet6c0efe62016-10-19 08:13:29 -07004778 '-B', '--bucket', default='',
4779 help=('Buildbucket bucket to send the try requests.'))
4780 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004781 '-r', '--revision',
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004782 help='Revision to use for the tryjob; default: the revision will '
tandriif7b29d42016-10-07 08:45:41 -07004783 'be determined by the try recipe that builder runs, which usually '
4784 'defaults to HEAD of origin/master')
maruel@chromium.org15192402012-09-06 12:38:29 +00004785 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004786 '-c', '--clobber', action='store_true', default=False,
tandriif7b29d42016-10-07 08:45:41 -07004787 help='Force a clobber before building; that is don\'t do an '
tandrii1838bad2016-10-06 00:10:52 -07004788 'incremental build')
maruel@chromium.org15192402012-09-06 12:38:29 +00004789 group.add_option(
Andrii Shyshkalovf9648b52018-02-21 22:32:42 -08004790 '--category', default='git_cl_try', help='Specify custom build category.')
4791 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004792 '--project',
4793 help='Override which project to use. Projects are defined '
tandriif7b29d42016-10-07 08:45:41 -07004794 'in recipe to determine to which repository or directory to '
4795 'apply the patch')
maruel@chromium.org15192402012-09-06 12:38:29 +00004796 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004797 '-p', '--property', dest='properties', action='append', default=[],
4798 help='Specify generic properties in the form -p key1=value1 -p '
tandriif7b29d42016-10-07 08:45:41 -07004799 'key2=value2 etc. The value will be treated as '
4800 'json if decodable, or as string otherwise. '
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004801 'NOTE: using this may make your tryjob not usable for CQ, '
4802 'which will then schedule another tryjob with default properties')
sheyang@chromium.orgdb375572015-08-17 19:22:23 +00004803 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004804 '--buildbucket-host', default='cr-buildbucket.appspot.com',
4805 help='Host of buildbucket. The default host is %default.')
maruel@chromium.org15192402012-09-06 12:38:29 +00004806 parser.add_option_group(group)
Quinten Yearsley983111f2019-09-26 17:18:48 +00004807 parser.add_option(
4808 '-R', '--retry-failed', action='store_true', default=False,
4809 help='Retry failed jobs from the latest set of tryjobs. '
4810 'Not allowed with --bucket and --bot options.')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004811 auth.add_auth_options(parser)
Koji Ishii31c14782018-01-08 17:17:33 +09004812 _add_codereview_issue_select_options(parser)
maruel@chromium.org15192402012-09-06 12:38:29 +00004813 options, args = parser.parse_args(args)
Edward Lemurf38bc172019-09-03 21:02:13 +00004814 _process_codereview_select_options(parser, options)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004815 auth_config = auth.extract_auth_config_from_options(options)
maruel@chromium.org15192402012-09-06 12:38:29 +00004816
machenbach@chromium.org45453142015-09-15 08:45:22 +00004817 # Make sure that all properties are prop=value pairs.
4818 bad_params = [x for x in options.properties if '=' not in x]
4819 if bad_params:
4820 parser.error('Got properties with missing "=": %s' % bad_params)
4821
maruel@chromium.org15192402012-09-06 12:38:29 +00004822 if args:
4823 parser.error('Unknown arguments: %s' % args)
4824
Edward Lemur934836a2019-09-09 20:16:54 +00004825 cl = Changelist(issue=options.issue)
maruel@chromium.org15192402012-09-06 12:38:29 +00004826 if not cl.GetIssue():
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004827 parser.error('Need to upload first.')
maruel@chromium.org15192402012-09-06 12:38:29 +00004828
Edward Lemurf38bc172019-09-03 21:02:13 +00004829 # HACK: warm up Gerrit change detail cache to save on RPCs.
Edward Lemur125d60a2019-09-13 18:25:41 +00004830 cl._GetChangeDetail(['DETAILED_ACCOUNTS', 'ALL_REVISIONS'])
Andrii Shyshkaloveadad922017-01-26 09:38:30 +01004831
tandriie113dfd2016-10-11 10:20:12 -07004832 error_message = cl.CannotTriggerTryJobReason()
4833 if error_message:
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004834 parser.error('Can\'t trigger tryjobs: %s' % error_message)
jrobbins@chromium.org16f10f72014-06-24 22:14:36 +00004835
Quinten Yearsley983111f2019-09-26 17:18:48 +00004836 if options.retry_failed:
4837 if options.bot or options.bucket:
4838 print('ERROR: The option --retry-failed is not compatible with '
4839 '-B, -b, --bucket, or --bot.', file=sys.stderr)
4840 return 1
4841 print('Searching for failed tryjobs...')
4842 builds, patchset = _fetch_latest_builds(
4843 auth_config, cl, options.buildbucket_host)
4844 if options.verbose:
4845 print('Got %d builds in patchset #%d' % (len(builds), patchset))
4846 buckets = _filter_failed(builds)
4847 if not buckets:
4848 print('There are no failed jobs in the latest set of jobs '
4849 '(patchset #%d), doing nothing.' % patchset)
4850 return 0
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004851 num_builders = sum(map(len, buckets.itervalues()))
Quinten Yearsley983111f2019-09-26 17:18:48 +00004852 if num_builders > 10:
4853 confirm_or_exit('There are %d builders with failed builds.'
4854 % num_builders, action='continue')
4855 else:
4856 buckets = _get_bucket_map(cl, options, parser)
4857 if buckets and any(b.startswith('master.') for b in buckets):
4858 print('ERROR: Buildbot masters are not supported.')
4859 return 1
phajdan.jr@chromium.org8da7f272014-03-14 01:28:39 +00004860
qyearsleydd49f942016-10-28 11:57:22 -07004861 # If no bots are listed and we couldn't get a list based on PRESUBMIT files,
4862 # then we default to triggering a CQ dry run (see http://crbug.com/625697).
qyearsley1fdfcb62016-10-24 13:22:03 -07004863 if not buckets:
qyearsley1fdfcb62016-10-24 13:22:03 -07004864 if options.verbose:
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07004865 print('git cl try with no bots now defaults to CQ dry run.')
4866 print('Scheduling CQ dry run on: %s' % cl.GetIssueURL())
4867 return cl.SetCQState(_CQState.DRY_RUN)
stip@chromium.org43064fd2013-12-18 20:07:44 +00004868
borenet6c0efe62016-10-19 08:13:29 -07004869 for builders in buckets.itervalues():
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00004870 if any('triggered' in b for b in builders):
vapiera7fbd5a2016-06-16 09:17:49 -07004871 print('ERROR You are trying to send a job to a triggered bot. This type '
tandriide281ae2016-10-12 06:02:30 -07004872 'of bot requires an initial job from a parent (usually a builder). '
4873 'Instead send your job to the parent.\n'
vapiera7fbd5a2016-06-16 09:17:49 -07004874 'Bot list: %s' % builders, file=sys.stderr)
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00004875 return 1
ilevy@chromium.orgf3b21232012-09-24 20:48:55 +00004876
ilevy@chromium.org36e420b2013-08-06 23:21:12 +00004877 patchset = cl.GetMostRecentPatchset()
Edward Lemur2c210a42019-09-16 23:58:35 +00004878 try:
4879 _trigger_try_jobs(auth_config, cl, buckets, options, patchset)
4880 except BuildbucketResponseException as ex:
4881 print('ERROR: %s' % ex)
4882 return 1
4883 return 0
maruel@chromium.org15192402012-09-06 12:38:29 +00004884
4885
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004886@metrics.collector.collect_metrics('git cl try-results')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004887def CMDtry_results(parser, args):
Quinten Yearsleyd242ed72019-07-25 17:17:55 +00004888 """Prints info about results for tryjobs associated with the current CL."""
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004889 group = optparse.OptionGroup(parser, 'Tryjob results options')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004890 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004891 '-p', '--patchset', type=int, help='patchset number if not current.')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004892 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004893 '--print-master', action='store_true', help='print master name as well.')
tandrii@chromium.org6cf98c82016-03-15 11:56:00 +00004894 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004895 '--color', action='store_true', default=setup_color.IS_TTY,
4896 help='force color output, useful when piping output.')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004897 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004898 '--buildbucket-host', default='cr-buildbucket.appspot.com',
4899 help='Host of buildbucket. The default host is %default.')
qyearsley53f48a12016-09-01 10:45:13 -07004900 group.add_option(
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004901 '--json', help=('Path of JSON output file to write tryjob results to,'
Stefan Zager1306bd02017-06-22 19:26:46 -07004902 'or "-" for stdout.'))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004903 parser.add_option_group(group)
4904 auth.add_auth_options(parser)
Stefan Zager27db3f22017-10-10 15:15:01 -07004905 _add_codereview_issue_select_options(parser)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004906 options, args = parser.parse_args(args)
Edward Lemurf38bc172019-09-03 21:02:13 +00004907 _process_codereview_select_options(parser, options)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004908 if args:
4909 parser.error('Unrecognized args: %s' % ' '.join(args))
4910
4911 auth_config = auth.extract_auth_config_from_options(options)
Edward Lemur934836a2019-09-09 20:16:54 +00004912 cl = Changelist(issue=options.issue)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004913 if not cl.GetIssue():
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004914 parser.error('Need to upload first.')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004915
tandrii221ab252016-10-06 08:12:04 -07004916 patchset = options.patchset
4917 if not patchset:
4918 patchset = cl.GetMostRecentPatchset()
4919 if not patchset:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004920 parser.error('Code review host doesn\'t know about issue %s. '
tandrii221ab252016-10-06 08:12:04 -07004921 'No access to issue or wrong issue number?\n'
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004922 'Either upload first, or pass --patchset explicitly.' %
tandrii221ab252016-10-06 08:12:04 -07004923 cl.GetIssue())
4924
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004925 try:
tandrii221ab252016-10-06 08:12:04 -07004926 jobs = fetch_try_jobs(auth_config, cl, options.buildbucket_host, patchset)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004927 except BuildbucketResponseException as ex:
vapiera7fbd5a2016-06-16 09:17:49 -07004928 print('Buildbucket error: %s' % ex)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004929 return 1
qyearsley53f48a12016-09-01 10:45:13 -07004930 if options.json:
4931 write_try_results_json(options.json, jobs)
4932 else:
4933 print_try_jobs(options, jobs)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004934 return 0
4935
4936
maruel@chromium.org0633fb42013-08-16 20:06:14 +00004937@subcommand.usage('[new upstream branch]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004938@metrics.collector.collect_metrics('git cl upstream')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004939def CMDupstream(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004940 """Prints or sets the name of the upstream branch, if any."""
dpranke@chromium.org97ae58e2011-03-18 00:29:20 +00004941 _, args = parser.parse_args(args)
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00004942 if len(args) > 1:
maruel@chromium.org27bb3872011-05-30 20:33:19 +00004943 parser.error('Unrecognized args: %s' % ' '.join(args))
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00004944
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004945 cl = Changelist()
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00004946 if args:
4947 # One arg means set upstream branch.
bauerb@chromium.orgc9cf90a2014-04-28 20:32:31 +00004948 branch = cl.GetBranch()
stip7a3dd352016-09-22 17:32:28 -07004949 RunGit(['branch', '--set-upstream-to', args[0], branch])
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00004950 cl = Changelist()
vapiera7fbd5a2016-06-16 09:17:49 -07004951 print('Upstream branch set to %s' % (cl.GetUpstreamBranch(),))
bauerb@chromium.orgc9cf90a2014-04-28 20:32:31 +00004952
4953 # Clear configured merge-base, if there is one.
4954 git_common.remove_merge_base(branch)
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00004955 else:
vapiera7fbd5a2016-06-16 09:17:49 -07004956 print(cl.GetUpstreamBranch())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004957 return 0
4958
4959
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004960@metrics.collector.collect_metrics('git cl web')
thestig@chromium.org00858c82013-12-02 23:08:03 +00004961def CMDweb(parser, args):
4962 """Opens the current CL in the web browser."""
4963 _, args = parser.parse_args(args)
4964 if args:
4965 parser.error('Unrecognized args: %s' % ' '.join(args))
4966
4967 issue_url = Changelist().GetIssueURL()
4968 if not issue_url:
vapiera7fbd5a2016-06-16 09:17:49 -07004969 print('ERROR No issue to open', file=sys.stderr)
thestig@chromium.org00858c82013-12-02 23:08:03 +00004970 return 1
4971
Sergiy Byelozyorov2b718322018-10-24 17:43:31 +00004972 # Redirect I/O before invoking browser to hide its output. For example, this
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004973 # allows us to hide the "Created new window in existing browser session."
4974 # message from Chrome. Based on https://stackoverflow.com/a/2323563.
Sergiy Byelozyorov2b718322018-10-24 17:43:31 +00004975 saved_stdout = os.dup(1)
Sergiy Belozorov06684032019-03-06 16:53:08 +00004976 saved_stderr = os.dup(2)
Sergiy Byelozyorov2b718322018-10-24 17:43:31 +00004977 os.close(1)
Sergiy Belozorov06684032019-03-06 16:53:08 +00004978 os.close(2)
Sergiy Byelozyorov2b718322018-10-24 17:43:31 +00004979 os.open(os.devnull, os.O_RDWR)
4980 try:
4981 webbrowser.open(issue_url)
4982 finally:
4983 os.dup2(saved_stdout, 1)
Sergiy Belozorov06684032019-03-06 16:53:08 +00004984 os.dup2(saved_stderr, 2)
thestig@chromium.org00858c82013-12-02 23:08:03 +00004985 return 0
4986
4987
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004988@metrics.collector.collect_metrics('git cl set-commit')
maruel@chromium.org27bb3872011-05-30 20:33:19 +00004989def CMDset_commit(parser, args):
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +00004990 """Sets the commit bit to trigger the CQ."""
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00004991 parser.add_option('-d', '--dry-run', action='store_true',
4992 help='trigger in dry run mode')
4993 parser.add_option('-c', '--clear', action='store_true',
4994 help='stop CQ run, if any')
iannuccie53c9352016-08-17 14:40:40 -07004995 _add_codereview_issue_select_options(parser)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004996 options, args = parser.parse_args(args)
Edward Lemurf38bc172019-09-03 21:02:13 +00004997 _process_codereview_select_options(parser, options)
maruel@chromium.org27bb3872011-05-30 20:33:19 +00004998 if args:
4999 parser.error('Unrecognized args: %s' % ' '.join(args))
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00005000 if options.dry_run and options.clear:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00005001 parser.error('Only one of --dry-run and --clear are allowed.')
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00005002
Edward Lemur934836a2019-09-09 20:16:54 +00005003 cl = Changelist(issue=options.issue)
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00005004 if options.clear:
tandriid9e5ce52016-07-13 02:32:59 -07005005 state = _CQState.NONE
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00005006 elif options.dry_run:
5007 state = _CQState.DRY_RUN
5008 else:
5009 state = _CQState.COMMIT
5010 if not cl.GetIssue():
Quinten Yearsleyc4202212019-07-22 23:34:40 +00005011 parser.error('Must upload the issue first.')
tandrii9de9ec62016-07-13 03:01:59 -07005012 cl.SetCQState(state)
maruel@chromium.org27bb3872011-05-30 20:33:19 +00005013 return 0
5014
5015
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005016@metrics.collector.collect_metrics('git cl set-close')
groby@chromium.org411034a2013-02-26 15:12:01 +00005017def CMDset_close(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005018 """Closes the issue."""
iannuccie53c9352016-08-17 14:40:40 -07005019 _add_codereview_issue_select_options(parser)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00005020 options, args = parser.parse_args(args)
Edward Lemurf38bc172019-09-03 21:02:13 +00005021 _process_codereview_select_options(parser, options)
groby@chromium.org411034a2013-02-26 15:12:01 +00005022 if args:
5023 parser.error('Unrecognized args: %s' % ' '.join(args))
Edward Lemur934836a2019-09-09 20:16:54 +00005024 cl = Changelist(issue=options.issue)
groby@chromium.org411034a2013-02-26 15:12:01 +00005025 # Ensure there actually is an issue to close.
Aaron Gable7139a4e2017-09-05 17:53:09 -07005026 if not cl.GetIssue():
Quinten Yearsleyc4202212019-07-22 23:34:40 +00005027 DieWithError('ERROR: No issue to close.')
groby@chromium.org411034a2013-02-26 15:12:01 +00005028 cl.CloseIssue()
5029 return 0
5030
5031
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005032@metrics.collector.collect_metrics('git cl diff')
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00005033def CMDdiff(parser, args):
wychen@chromium.org37b2ec02015-04-03 00:49:15 +00005034 """Shows differences between local tree and last upload."""
thomasanderson074beb22016-08-29 14:03:20 -07005035 parser.add_option(
5036 '--stat',
5037 action='store_true',
5038 dest='stat',
5039 help='Generate a diffstat')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00005040 options, args = parser.parse_args(args)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00005041 if args:
5042 parser.error('Unrecognized args: %s' % ' '.join(args))
wychen@chromium.org46309bf2015-04-03 21:04:49 +00005043
Edward Lemur934836a2019-09-09 20:16:54 +00005044 cl = Changelist()
sbc@chromium.org78dc9842013-11-25 18:43:44 +00005045 issue = cl.GetIssue()
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00005046 branch = cl.GetBranch()
sbc@chromium.org78dc9842013-11-25 18:43:44 +00005047 if not issue:
5048 DieWithError('No issue found for current branch (%s)' % branch)
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00005049
Aaron Gablea718c3e2017-08-28 17:47:28 -07005050 base = cl._GitGetBranchConfigValue('last-upload-hash')
5051 if not base:
5052 base = cl._GitGetBranchConfigValue('gerritsquashhash')
5053 if not base:
5054 detail = cl._GetChangeDetail(['CURRENT_REVISION', 'CURRENT_COMMIT'])
5055 revision_info = detail['revisions'][detail['current_revision']]
5056 fetch_info = revision_info['fetch']['http']
5057 RunGit(['fetch', fetch_info['url'], fetch_info['ref']])
5058 base = 'FETCH_HEAD'
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00005059
Aaron Gablea718c3e2017-08-28 17:47:28 -07005060 cmd = ['git', 'diff']
5061 if options.stat:
5062 cmd.append('--stat')
5063 cmd.append(base)
5064 subprocess2.check_call(cmd)
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00005065
5066 return 0
5067
5068
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005069@metrics.collector.collect_metrics('git cl owners')
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005070def CMDowners(parser, args):
Dirk Prankebf980882017-09-02 15:08:00 -07005071 """Finds potential owners for reviewing."""
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005072 parser.add_option(
Sidney San Martín8e6f58c2018-06-08 01:02:56 +00005073 '--ignore-current',
5074 action='store_true',
5075 help='Ignore the CL\'s current reviewers and start from scratch.')
5076 parser.add_option(
Sylvain Defresneb1f865d2019-02-12 12:38:22 +00005077 '--ignore-self',
5078 action='store_true',
5079 help='Do not consider CL\'s author as an owners.')
5080 parser.add_option(
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005081 '--no-color',
5082 action='store_true',
5083 help='Use this option to disable color output')
Dirk Prankebf980882017-09-02 15:08:00 -07005084 parser.add_option(
5085 '--batch',
5086 action='store_true',
5087 help='Do not run interactively, just suggest some')
Yang Guo6e269a02019-06-26 11:17:02 +00005088 # TODO: Consider moving this to another command, since other
5089 # git-cl owners commands deal with owners for a given CL.
5090 parser.add_option(
5091 '--show-all',
5092 action='store_true',
5093 help='Show all owners for a particular file')
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005094 options, args = parser.parse_args(args)
5095
5096 author = RunGit(['config', 'user.email']).strip() or None
5097
Edward Lemur934836a2019-09-09 20:16:54 +00005098 cl = Changelist()
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005099
Yang Guo6e269a02019-06-26 11:17:02 +00005100 if options.show_all:
5101 for arg in args:
5102 base_branch = cl.GetCommonAncestorWithUpstream()
5103 change = cl.GetChange(base_branch, None)
5104 database = owners.Database(change.RepositoryRoot(), file, os.path)
5105 database.load_data_needed_for([arg])
5106 print('Owners for %s:' % arg)
5107 for owner in sorted(database.all_possible_owners([arg], None)):
5108 print(' - %s' % owner)
5109 return 0
5110
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005111 if args:
5112 if len(args) > 1:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00005113 parser.error('Unknown args.')
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005114 base_branch = args[0]
5115 else:
5116 # Default to diffing against the common ancestor of the upstream branch.
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00005117 base_branch = cl.GetCommonAncestorWithUpstream()
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005118
5119 change = cl.GetChange(base_branch, None)
Dirk Prankebf980882017-09-02 15:08:00 -07005120 affected_files = [f.LocalPath() for f in change.AffectedFiles()]
5121
5122 if options.batch:
5123 db = owners.Database(change.RepositoryRoot(), file, os.path)
5124 print('\n'.join(db.reviewers_for(affected_files, author)))
5125 return 0
5126
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005127 return owners_finder.OwnersFinder(
Dirk Prankebf980882017-09-02 15:08:00 -07005128 affected_files,
Jochen Eisinger72606f82017-04-04 10:44:18 +02005129 change.RepositoryRoot(),
Edward Lemur707d70b2018-02-07 00:50:14 +01005130 author,
Sidney San Martín8e6f58c2018-06-08 01:02:56 +00005131 [] if options.ignore_current else cl.GetReviewers(),
Edward Lemur707d70b2018-02-07 00:50:14 +01005132 fopen=file, os_path=os.path,
Jochen Eisingerd0573ec2017-04-13 10:55:06 +02005133 disable_color=options.no_color,
Sylvain Defresneb1f865d2019-02-12 12:38:22 +00005134 override_files=change.OriginalOwnersFiles(),
5135 ignore_author=options.ignore_self).run()
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005136
5137
Aiden Bennerc08566e2018-10-03 17:52:42 +00005138def BuildGitDiffCmd(diff_type, upstream_commit, args, allow_prefix=False):
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005139 """Generates a diff command."""
5140 # Generate diff for the current branch's changes.
Aiden Bennerc08566e2018-10-03 17:52:42 +00005141 diff_cmd = ['-c', 'core.quotePath=false', 'diff', '--no-ext-diff']
5142
Aiden Benner6c18a1a2018-11-23 20:18:23 +00005143 if allow_prefix:
5144 # explicitly setting --src-prefix and --dst-prefix is necessary in the
5145 # case that diff.noprefix is set in the user's git config.
5146 diff_cmd += ['--src-prefix=a/', '--dst-prefix=b/']
5147 else:
Aiden Bennerc08566e2018-10-03 17:52:42 +00005148 diff_cmd += ['--no-prefix']
5149
5150 diff_cmd += [diff_type, upstream_commit, '--']
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005151
5152 if args:
5153 for arg in args:
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005154 if os.path.isdir(arg) or os.path.isfile(arg):
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005155 diff_cmd.append(arg)
5156 else:
5157 DieWithError('Argument "%s" is not a file or a directory' % arg)
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005158
5159 return diff_cmd
5160
Andrii Shyshkalov18975322017-01-25 16:44:13 +01005161
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005162def MatchingFileType(file_name, extensions):
Quinten Yearsleyd242ed72019-07-25 17:17:55 +00005163 """Returns True if the file name ends with one of the given extensions."""
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005164 return bool([ext for ext in extensions if file_name.lower().endswith(ext)])
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005165
Andrii Shyshkalov18975322017-01-25 16:44:13 +01005166
enne@chromium.org555cfe42014-01-29 18:21:39 +00005167@subcommand.usage('[files or directories to diff]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005168@metrics.collector.collect_metrics('git cl format')
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005169def CMDformat(parser, args):
sbc@chromium.org9d0644d2015-06-05 23:16:54 +00005170 """Runs auto-formatting tools (clang-format etc.) on the diff."""
Christopher Lamc5ba6922017-01-24 11:19:14 +11005171 CLANG_EXTS = ['.cc', '.cpp', '.h', '.m', '.mm', '.proto', '.java']
kylechar58edce22016-06-17 06:07:51 -07005172 GN_EXTS = ['.gn', '.gni', '.typemap']
enne@chromium.org3b7e15c2014-01-21 17:44:47 +00005173 parser.add_option('--full', action='store_true',
5174 help='Reformat the full content of all touched files')
5175 parser.add_option('--dry-run', action='store_true',
5176 help='Don\'t modify any file on disk.')
Aiden Benner99b0ccb2018-11-20 19:53:31 +00005177 parser.add_option(
5178 '--python',
5179 action='store_true',
5180 default=None,
5181 help='Enables python formatting on all python files.')
5182 parser.add_option(
5183 '--no-python',
5184 action='store_true',
5185 dest='python',
5186 help='Disables python formatting on all python files. '
5187 'Takes precedence over --python. '
5188 'If neither --python or --no-python are set, python '
5189 'files that have a .style.yapf file in an ancestor '
5190 'directory will be formatted.')
Christopher Lamc5ba6922017-01-24 11:19:14 +11005191 parser.add_option('--js', action='store_true',
5192 help='Format javascript code with clang-format.')
wittman@chromium.org04d5a222014-03-07 18:30:42 +00005193 parser.add_option('--diff', action='store_true',
5194 help='Print diff to stdout rather than modifying files.')
Ilya Shermane081cbe2017-08-15 17:51:04 -07005195 parser.add_option('--presubmit', action='store_true',
5196 help='Used when running the script from a presubmit.')
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005197 opts, args = parser.parse_args(args)
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005198
Daniel Chengc55eecf2016-12-30 03:11:02 -08005199 # Normalize any remaining args against the current path, so paths relative to
5200 # the current directory are still resolved as expected.
5201 args = [os.path.join(os.getcwd(), arg) for arg in args]
5202
enne@chromium.orgff7a1fb2013-12-10 19:21:41 +00005203 # git diff generates paths against the root of the repository. Change
5204 # to that directory so clang-format can find files even within subdirs.
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00005205 rel_base_path = settings.GetRelativeRoot()
enne@chromium.orgff7a1fb2013-12-10 19:21:41 +00005206 if rel_base_path:
5207 os.chdir(rel_base_path)
5208
digit@chromium.org29e47272013-05-17 17:01:46 +00005209 # Grab the merge-base commit, i.e. the upstream commit of the current
5210 # branch when it was created or the last time it was rebased. This is
5211 # to cover the case where the user may have called "git fetch origin",
5212 # moving the origin branch to a newer commit, but hasn't rebased yet.
5213 upstream_commit = None
5214 cl = Changelist()
5215 upstream_branch = cl.GetUpstreamBranch()
5216 if upstream_branch:
5217 upstream_commit = RunGit(['merge-base', 'HEAD', upstream_branch])
5218 upstream_commit = upstream_commit.strip()
5219
5220 if not upstream_commit:
5221 DieWithError('Could not find base commit for this branch. '
5222 'Are you in detached state?')
5223
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005224 changed_files_cmd = BuildGitDiffCmd('--name-only', upstream_commit, args)
5225 diff_output = RunGit(changed_files_cmd)
5226 diff_files = diff_output.splitlines()
jkarlin@chromium.orgad21b922016-01-28 17:48:42 +00005227 # Filter out files deleted by this CL
5228 diff_files = [x for x in diff_files if os.path.isfile(x)]
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005229
Christopher Lamc5ba6922017-01-24 11:19:14 +11005230 if opts.js:
Deepanjan Roy605dd312018-07-02 17:48:54 +00005231 CLANG_EXTS.extend(['.js', '.ts'])
Christopher Lamc5ba6922017-01-24 11:19:14 +11005232
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005233 clang_diff_files = [x for x in diff_files if MatchingFileType(x, CLANG_EXTS)]
5234 python_diff_files = [x for x in diff_files if MatchingFileType(x, ['.py'])]
5235 dart_diff_files = [x for x in diff_files if MatchingFileType(x, ['.dart'])]
kylechar@chromium.org8b61f112016-02-05 13:28:58 +00005236 gn_diff_files = [x for x in diff_files if MatchingFileType(x, GN_EXTS)]
digit@chromium.org29e47272013-05-17 17:01:46 +00005237
nick@chromium.org3ac1c4e2014-01-16 02:44:42 +00005238 top_dir = os.path.normpath(
5239 RunGit(["rev-parse", "--show-toplevel"]).rstrip('\n'))
5240
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005241 # Set to 2 to signal to CheckPatchFormatted() that this patch isn't
5242 # formatted. This is used to block during the presubmit.
5243 return_value = 0
5244
sammc@chromium.org0b35f5d2016-02-25 22:39:23 +00005245 if clang_diff_files:
techtonik@gmail.com5573df12016-04-12 18:34:10 +00005246 # Locate the clang-format binary in the checkout
5247 try:
5248 clang_format_tool = clang_format.FindClangFormatToolInChromiumTree()
vapierfd77ac72016-06-16 08:33:57 -07005249 except clang_format.NotFoundError as e:
techtonik@gmail.com5573df12016-04-12 18:34:10 +00005250 DieWithError(e)
5251
sammc@chromium.org0b35f5d2016-02-25 22:39:23 +00005252 if opts.full:
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005253 cmd = [clang_format_tool]
5254 if not opts.dry_run and not opts.diff:
5255 cmd.append('-i')
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005256 stdout = RunCommand(cmd + clang_diff_files, cwd=top_dir)
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005257 if opts.diff:
5258 sys.stdout.write(stdout)
sammc@chromium.org0b35f5d2016-02-25 22:39:23 +00005259 else:
5260 env = os.environ.copy()
5261 env['PATH'] = str(os.path.dirname(clang_format_tool))
5262 try:
5263 script = clang_format.FindClangFormatScriptInChromiumTree(
5264 'clang-format-diff.py')
vapierfd77ac72016-06-16 08:33:57 -07005265 except clang_format.NotFoundError as e:
sammc@chromium.org0b35f5d2016-02-25 22:39:23 +00005266 DieWithError(e)
digit@chromium.orgd6ddc1c2013-10-25 15:36:32 +00005267
sammc@chromium.org0b35f5d2016-02-25 22:39:23 +00005268 cmd = [sys.executable, script, '-p0']
5269 if not opts.dry_run and not opts.diff:
5270 cmd.append('-i')
digit@chromium.orgd6ddc1c2013-10-25 15:36:32 +00005271
sammc@chromium.org0b35f5d2016-02-25 22:39:23 +00005272 diff_cmd = BuildGitDiffCmd('-U0', upstream_commit, clang_diff_files)
5273 diff_output = RunGit(diff_cmd)
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005274
sammc@chromium.org0b35f5d2016-02-25 22:39:23 +00005275 stdout = RunCommand(cmd, stdin=diff_output, cwd=top_dir, env=env)
5276 if opts.diff:
5277 sys.stdout.write(stdout)
5278 if opts.dry_run and len(stdout) > 0:
5279 return_value = 2
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005280
sbc@chromium.org9d0644d2015-06-05 23:16:54 +00005281 # Similar code to above, but using yapf on .py files rather than clang-format
5282 # on C/C++ files
Aiden Benner99b0ccb2018-11-20 19:53:31 +00005283 py_explicitly_disabled = opts.python is not None and not opts.python
5284 if python_diff_files and not py_explicitly_disabled:
Aiden Bennere47ac152018-11-20 16:44:03 +00005285 depot_tools_path = os.path.dirname(os.path.abspath(__file__))
5286 yapf_tool = os.path.join(depot_tools_path, 'yapf')
5287 if sys.platform.startswith('win'):
5288 yapf_tool += '.bat'
sbc@chromium.org9d0644d2015-06-05 23:16:54 +00005289
Aiden Bennerc08566e2018-10-03 17:52:42 +00005290 # If we couldn't find a yapf file we'll default to the chromium style
5291 # specified in depot_tools.
Aiden Bennerc08566e2018-10-03 17:52:42 +00005292 chromium_default_yapf_style = os.path.join(depot_tools_path,
5293 YAPF_CONFIG_FILENAME)
Aiden Bennerc08566e2018-10-03 17:52:42 +00005294 # Used for caching.
5295 yapf_configs = {}
5296 for f in python_diff_files:
5297 # Find the yapf style config for the current file, defaults to depot
5298 # tools default.
Aiden Benner99b0ccb2018-11-20 19:53:31 +00005299 _FindYapfConfigFile(f, yapf_configs, top_dir)
5300
5301 # Turn on python formatting by default if a yapf config is specified.
5302 # This breaks in the case of this repo though since the specified
5303 # style file is also the global default.
5304 if opts.python is None:
5305 filtered_py_files = []
5306 for f in python_diff_files:
5307 if _FindYapfConfigFile(f, yapf_configs, top_dir) is not None:
5308 filtered_py_files.append(f)
5309 else:
5310 filtered_py_files = python_diff_files
5311
5312 # Note: yapf still seems to fix indentation of the entire file
5313 # even if line ranges are specified.
5314 # See https://github.com/google/yapf/issues/499
5315 if not opts.full and filtered_py_files:
5316 py_line_diffs = _ComputeDiffLineRanges(filtered_py_files, upstream_commit)
5317
5318 for f in filtered_py_files:
5319 yapf_config = _FindYapfConfigFile(f, yapf_configs, top_dir)
5320 if yapf_config is None:
5321 yapf_config = chromium_default_yapf_style
Aiden Bennerc08566e2018-10-03 17:52:42 +00005322
5323 cmd = [yapf_tool, '--style', yapf_config, f]
5324
5325 has_formattable_lines = False
5326 if not opts.full:
5327 # Only run yapf over changed line ranges.
5328 for diff_start, diff_len in py_line_diffs[f]:
5329 diff_end = diff_start + diff_len - 1
5330 # Yapf errors out if diff_end < diff_start but this
5331 # is a valid line range diff for a removal.
5332 if diff_end >= diff_start:
5333 has_formattable_lines = True
5334 cmd += ['-l', '{}-{}'.format(diff_start, diff_end)]
5335 # If all line diffs were removals we have nothing to format.
5336 if not has_formattable_lines:
5337 continue
5338
5339 if opts.diff or opts.dry_run:
5340 cmd += ['--diff']
5341 # Will return non-zero exit code if non-empty diff.
5342 stdout = RunCommand(cmd, error_ok=True, cwd=top_dir)
5343 if opts.diff:
5344 sys.stdout.write(stdout)
5345 elif len(stdout) > 0:
5346 return_value = 2
5347 else:
5348 cmd += ['-i']
5349 RunCommand(cmd, cwd=top_dir)
sbc@chromium.org9d0644d2015-06-05 23:16:54 +00005350
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005351 # Dart's formatter does not have the nice property of only operating on
5352 # modified chunks, so hard code full.
5353 if dart_diff_files:
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005354 try:
5355 command = [dart_format.FindDartFmtToolInChromiumTree()]
5356 if not opts.dry_run and not opts.diff:
5357 command.append('-w')
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005358 command.extend(dart_diff_files)
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005359
ppi@chromium.org6593d932016-03-03 15:41:15 +00005360 stdout = RunCommand(command, cwd=top_dir)
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005361 if opts.dry_run and stdout:
5362 return_value = 2
5363 except dart_format.NotFoundError as e:
vapiera7fbd5a2016-06-16 09:17:49 -07005364 print('Warning: Unable to check Dart code formatting. Dart SDK not '
5365 'found in this checkout. Files in other languages are still '
5366 'formatted.')
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005367
kylechar@chromium.org8b61f112016-02-05 13:28:58 +00005368 # Format GN build files. Always run on full build files for canonical form.
5369 if gn_diff_files:
Andrii Shyshkalov18975322017-01-25 16:44:13 +01005370 cmd = ['gn', 'format']
brettw4b8ed592016-08-05 16:19:12 -07005371 if opts.dry_run or opts.diff:
5372 cmd.append('--dry-run')
kylechar@chromium.org8b61f112016-02-05 13:28:58 +00005373 for gn_diff_file in gn_diff_files:
brettw4b8ed592016-08-05 16:19:12 -07005374 gn_ret = subprocess2.call(cmd + [gn_diff_file],
5375 shell=sys.platform == 'win32',
5376 cwd=top_dir)
5377 if opts.dry_run and gn_ret == 2:
5378 return_value = 2 # Not formatted.
5379 elif opts.diff and gn_ret == 2:
5380 # TODO this should compute and print the actual diff.
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005381 print('This change has GN build file diff for ' + gn_diff_file)
brettw4b8ed592016-08-05 16:19:12 -07005382 elif gn_ret != 0:
5383 # For non-dry run cases (and non-2 return values for dry-run), a
5384 # nonzero error code indicates a failure, probably because the file
5385 # doesn't parse.
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005386 DieWithError('gn format failed on ' + gn_diff_file +
5387 '\nTry running `gn format` on this file manually.')
kylechar@chromium.org8b61f112016-02-05 13:28:58 +00005388
Ilya Shermane081cbe2017-08-15 17:51:04 -07005389 # Skip the metrics formatting from the global presubmit hook. These files have
5390 # a separate presubmit hook that issues an error if the files need formatting,
5391 # whereas the top-level presubmit script merely issues a warning. Formatting
5392 # these files is somewhat slow, so it's important not to duplicate the work.
5393 if not opts.presubmit:
5394 for xml_dir in GetDirtyMetricsDirs(diff_files):
5395 tool_dir = os.path.join(top_dir, xml_dir)
5396 cmd = [os.path.join(tool_dir, 'pretty_print.py'), '--non-interactive']
5397 if opts.dry_run or opts.diff:
5398 cmd.append('--diff')
Ilya Sherman235b70d2017-08-22 17:46:38 -07005399 stdout = RunCommand(cmd, cwd=top_dir)
Ilya Shermane081cbe2017-08-15 17:51:04 -07005400 if opts.diff:
5401 sys.stdout.write(stdout)
5402 if opts.dry_run and stdout:
5403 return_value = 2 # Not formatted.
Alexei Svitkinef3cac412017-02-06 11:08:50 -05005404
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005405 return return_value
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005406
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005407
Steven Holte2e664bf2017-04-21 13:10:47 -07005408def GetDirtyMetricsDirs(diff_files):
5409 xml_diff_files = [x for x in diff_files if MatchingFileType(x, ['.xml'])]
5410 metrics_xml_dirs = [
5411 os.path.join('tools', 'metrics', 'actions'),
5412 os.path.join('tools', 'metrics', 'histograms'),
5413 os.path.join('tools', 'metrics', 'rappor'),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005414 os.path.join('tools', 'metrics', 'ukm'),
5415 ]
Steven Holte2e664bf2017-04-21 13:10:47 -07005416 for xml_dir in metrics_xml_dirs:
5417 if any(file.startswith(xml_dir) for file in xml_diff_files):
5418 yield xml_dir
5419
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005420
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005421@subcommand.usage('<codereview url or issue id>')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005422@metrics.collector.collect_metrics('git cl checkout')
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005423def CMDcheckout(parser, args):
Edward Lemurf38bc172019-09-03 21:02:13 +00005424 """Checks out a branch associated with a given Gerrit issue."""
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005425 _, args = parser.parse_args(args)
5426
5427 if len(args) != 1:
5428 parser.print_help()
5429 return 1
5430
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00005431 issue_arg = ParseIssueNumberArgument(args[0])
tandrii@chromium.orgde6c9a12016-04-11 15:33:53 +00005432 if not issue_arg.valid:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00005433 parser.error('Invalid issue ID or URL.')
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02005434
tandrii@chromium.orgabd27e52016-04-11 15:43:32 +00005435 target_issue = str(issue_arg.issue)
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005436
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00005437 def find_issues(issueprefix):
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00005438 output = RunGit(['config', '--local', '--get-regexp',
5439 r'branch\..*\.%s' % issueprefix],
5440 error_ok=True)
5441 for key, issue in [x.split() for x in output.splitlines()]:
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00005442 if issue == target_issue:
5443 yield re.sub(r'branch\.(.*)\.%s' % issueprefix, r'\1', key)
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005444
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00005445 branches = []
5446 for cls in _CODEREVIEW_IMPLEMENTATIONS.values():
tandrii5d48c322016-08-18 16:19:37 -07005447 branches.extend(find_issues(cls.IssueConfigKey()))
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005448 if len(branches) == 0:
vapiera7fbd5a2016-06-16 09:17:49 -07005449 print('No branch found for issue %s.' % target_issue)
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005450 return 1
5451 if len(branches) == 1:
5452 RunGit(['checkout', branches[0]])
5453 else:
vapiera7fbd5a2016-06-16 09:17:49 -07005454 print('Multiple branches match issue %s:' % target_issue)
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005455 for i in range(len(branches)):
vapiera7fbd5a2016-06-16 09:17:49 -07005456 print('%d: %s' % (i, branches[i]))
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005457 which = raw_input('Choose by index: ')
5458 try:
5459 RunGit(['checkout', branches[int(which)]])
5460 except (IndexError, ValueError):
vapiera7fbd5a2016-06-16 09:17:49 -07005461 print('Invalid selection, not checking out any branch.')
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005462 return 1
5463
5464 return 0
5465
5466
maruel@chromium.org29404b52014-09-08 22:58:00 +00005467def CMDlol(parser, args):
5468 # This command is intentionally undocumented.
vapiera7fbd5a2016-06-16 09:17:49 -07005469 print(zlib.decompress(base64.b64decode(
thakis@chromium.org3421c992014-11-02 02:20:32 +00005470 'eNptkLEOwyAMRHe+wupCIqW57v0Vq84WqWtXyrcXnCBsmgMJ+/SSAxMZgRB6NzE'
5471 'E2ObgCKJooYdu4uAQVffUEoE1sRQLxAcqzd7uK2gmStrll1ucV3uZyaY5sXyDd9'
5472 'JAnN+lAXsOMJ90GANAi43mq5/VeeacylKVgi8o6F1SC63FxnagHfJUTfUYdCR/W'
vapiera7fbd5a2016-06-16 09:17:49 -07005473 'Ofe+0dHL7PicpytKP750Fh1q2qnLVof4w8OZWNY')))
maruel@chromium.org29404b52014-09-08 22:58:00 +00005474 return 0
5475
5476
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005477class OptionParser(optparse.OptionParser):
5478 """Creates the option parse and add --verbose support."""
5479 def __init__(self, *args, **kwargs):
maruel@chromium.org0633fb42013-08-16 20:06:14 +00005480 optparse.OptionParser.__init__(
5481 self, *args, prog='git cl', version=__version__, **kwargs)
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005482 self.add_option(
5483 '-v', '--verbose', action='count', default=0,
5484 help='Use 2 times for more debugging info')
5485
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005486 def parse_args(self, args=None, _values=None):
Andrii Shyshkalov46f20cd2018-10-30 06:42:54 +00005487 try:
5488 return self._parse_args(args)
5489 finally:
5490 # Regardless of success or failure of args parsing, we want to report
5491 # metrics, but only after logging has been initialized (if parsing
5492 # succeeded).
5493 global settings
5494 settings = Settings()
5495
5496 if not metrics.DISABLE_METRICS_COLLECTION:
5497 # GetViewVCUrl ultimately calls logging method.
5498 project_url = settings.GetViewVCUrl().strip('/+')
5499 if project_url in metrics_utils.KNOWN_PROJECT_URLS:
5500 metrics.collector.add('project_urls', [project_url])
5501
5502 def _parse_args(self, args=None):
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005503 # Create an optparse.Values object that will store only the actual passed
5504 # options, without the defaults.
5505 actual_options = optparse.Values()
5506 _, args = optparse.OptionParser.parse_args(self, args, actual_options)
5507 # Create an optparse.Values object with the default options.
5508 options = optparse.Values(self.get_default_values().__dict__)
5509 # Update it with the options passed by the user.
5510 options._update_careful(actual_options.__dict__)
5511 # Store the options passed by the user in an _actual_options attribute.
5512 # We store only the keys, and not the values, since the values can contain
5513 # arbitrary information, which might be PII.
5514 metrics.collector.add('arguments', actual_options.__dict__.keys())
5515
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005516 levels = [logging.WARNING, logging.INFO, logging.DEBUG]
Andrii Shyshkalov5b04a572017-01-23 17:44:41 +01005517 logging.basicConfig(
5518 level=levels[min(options.verbose, len(levels) - 1)],
5519 format='[%(levelname).1s%(asctime)s %(process)d %(thread)d '
5520 '%(filename)s] %(message)s')
Edward Lemur83bd7f42018-10-10 00:14:21 +00005521
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005522 return options, args
5523
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005524
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005525def main(argv):
maruel@chromium.org82798cb2012-02-23 18:16:12 +00005526 if sys.hexversion < 0x02060000:
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005527 print('\nYour Python version %s is unsupported, please upgrade.\n' %
vapiera7fbd5a2016-06-16 09:17:49 -07005528 (sys.version.split(' ', 1)[0],), file=sys.stderr)
maruel@chromium.org82798cb2012-02-23 18:16:12 +00005529 return 2
maruel@chromium.org2e23ce32013-05-07 12:42:28 +00005530
maruel@chromium.org39c0b222013-08-17 16:57:01 +00005531 colorize_CMDstatus_doc()
maruel@chromium.org0633fb42013-08-16 20:06:14 +00005532 dispatcher = subcommand.CommandDispatcher(__name__)
5533 try:
5534 return dispatcher.execute(OptionParser(), argv)
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +00005535 except auth.AuthenticationError as e:
5536 DieWithError(str(e))
vapierfd77ac72016-06-16 08:33:57 -07005537 except urllib2.HTTPError as e:
maruel@chromium.org0633fb42013-08-16 20:06:14 +00005538 if e.code != 500:
5539 raise
5540 DieWithError(
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005541 ('App Engine is misbehaving and returned HTTP %d, again. Keep faith '
Quinten Yearsleyc4202212019-07-22 23:34:40 +00005542 'and retry or visit go/isgaeup.\n%s') % (e.code, str(e)))
sbc@chromium.org013731e2015-02-26 18:28:43 +00005543 return 0
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005544
5545
5546if __name__ == '__main__':
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005547 # These affect sys.stdout, so do it outside of main() to simplify mocks in
5548 # the unit tests.
maruel@chromium.org6f09cd92011-04-01 16:38:12 +00005549 fix_encoding.fix_encoding()
iannucci@chromium.org596cd5c2016-04-04 21:34:39 +00005550 setup_color.init()
Edward Lemur6f812e12018-07-31 22:45:57 +00005551 with metrics.collector.print_notice_and_exit():
sbc@chromium.org013731e2015-02-26 18:28:43 +00005552 sys.exit(main(sys.argv[1:]))