iannucci@chromium.org | 405b87e | 2015-11-12 18:08:34 +0000 | [diff] [blame] | 1 | #!/usr/bin/env python |
Andrii Shyshkalov | 0d2dea0 | 2017-07-17 15:17:55 +0200 | [diff] [blame] | 2 | # Copyright (c) 2013 The Chromium Authors. All rights reserved. |
maruel@chromium.org | 725f1c3 | 2011-04-01 20:24:54 +0000 | [diff] [blame] | 3 | # Use of this source code is governed by a BSD-style license that can be |
| 4 | # found in the LICENSE file. |
| 5 | |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 6 | # Copyright (C) 2008 Evan Martin <martine@danga.com> |
| 7 | |
Andrii Shyshkalov | 03da150 | 2018-10-15 03:42:34 +0000 | [diff] [blame] | 8 | """A git-command for integrating reviews on Gerrit.""" |
maruel@chromium.org | 725f1c3 | 2011-04-01 20:24:54 +0000 | [diff] [blame] | 9 | |
vapier | a7fbd5a | 2016-06-16 09:17:49 -0700 | [diff] [blame] | 10 | from __future__ import print_function |
| 11 | |
tapted@chromium.org | 6a0b07c | 2013-07-10 01:29:19 +0000 | [diff] [blame] | 12 | from distutils.version import LooseVersion |
calamity@chromium.org | ffde55c | 2015-03-12 00:44:17 +0000 | [diff] [blame] | 13 | from multiprocessing.pool import ThreadPool |
thakis@chromium.org | 3421c99 | 2014-11-02 02:20:32 +0000 | [diff] [blame] | 14 | import base64 |
rmistry@google.com | 2dd9986 | 2015-06-22 12:22:18 +0000 | [diff] [blame] | 15 | import collections |
Andrii Shyshkalov | f3a20ae | 2017-01-24 21:23:57 +0100 | [diff] [blame] | 16 | import contextlib |
Andrii Shyshkalov | d8aa49f | 2017-03-17 16:05:49 +0100 | [diff] [blame] | 17 | import datetime |
Andrii Shyshkalov | cd6a936 | 2016-12-07 12:04:12 +0100 | [diff] [blame] | 18 | import fnmatch |
sheyang@google.com | 6ebaf78 | 2015-05-12 19:17:54 +0000 | [diff] [blame] | 19 | import httplib |
Andrii Shyshkalov | 34924cd | 2017-03-15 17:08:32 +0100 | [diff] [blame] | 20 | import itertools |
maruel@chromium.org | 4f6852c | 2012-04-20 20:39:20 +0000 | [diff] [blame] | 21 | import json |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 22 | import logging |
calamity@chromium.org | cf19748 | 2016-04-29 20:15:53 +0000 | [diff] [blame] | 23 | import multiprocessing |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 24 | import optparse |
| 25 | import os |
| 26 | import re |
Andrii Shyshkalov | 353637c | 2017-03-14 16:52:18 +0100 | [diff] [blame] | 27 | import shutil |
ukai@chromium.org | 78c4b98 | 2012-02-14 02:20:26 +0000 | [diff] [blame] | 28 | import stat |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 29 | import sys |
Aaron Gable | 9a03ae0 | 2017-11-03 11:31:07 -0700 | [diff] [blame] | 30 | import tempfile |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 31 | import textwrap |
Edward Lemur | fec80c4 | 2018-11-01 23:14:14 +0000 | [diff] [blame] | 32 | import time |
tandrii@chromium.org | b015fac | 2016-02-26 14:52:01 +0000 | [diff] [blame] | 33 | import urllib |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 34 | import urllib2 |
maruel@chromium.org | 967c0a8 | 2013-06-17 22:52:24 +0000 | [diff] [blame] | 35 | import urlparse |
tandrii@chromium.org | b015fac | 2016-02-26 14:52:01 +0000 | [diff] [blame] | 36 | import uuid |
thestig@chromium.org | 00858c8 | 2013-12-02 23:08:03 +0000 | [diff] [blame] | 37 | import webbrowser |
thakis@chromium.org | 3421c99 | 2014-11-02 02:20:32 +0000 | [diff] [blame] | 38 | import zlib |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 39 | |
| 40 | try: |
Quinten Yearsley | b2cc4a9 | 2016-12-15 13:53:26 -0800 | [diff] [blame] | 41 | import readline # pylint: disable=import-error,W0611 |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 42 | except ImportError: |
| 43 | pass |
| 44 | |
maruel@chromium.org | 2e23ce3 | 2013-05-07 12:42:28 +0000 | [diff] [blame] | 45 | from third_party import colorama |
sheyang@google.com | 6ebaf78 | 2015-05-12 19:17:54 +0000 | [diff] [blame] | 46 | from third_party import httplib2 |
vadimsh@chromium.org | cf6a5d2 | 2015-04-09 22:02:00 +0000 | [diff] [blame] | 47 | import auth |
skobes | 6468b90 | 2016-10-24 08:45:10 -0700 | [diff] [blame] | 48 | import checkout |
nick@chromium.org | 3ac1c4e | 2014-01-16 02:44:42 +0000 | [diff] [blame] | 49 | import clang_format |
erg@chromium.org | e0a7c5d | 2015-02-23 20:30:08 +0000 | [diff] [blame] | 50 | import dart_format |
iannucci@chromium.org | 596cd5c | 2016-04-04 21:34:39 +0000 | [diff] [blame] | 51 | import setup_color |
maruel@chromium.org | 6f09cd9 | 2011-04-01 16:38:12 +0000 | [diff] [blame] | 52 | import fix_encoding |
maruel@chromium.org | 0e0436a | 2011-10-25 13:32:41 +0000 | [diff] [blame] | 53 | import gclient_utils |
tandrii@chromium.org | aa5ced1 | 2016-03-29 09:41:14 +0000 | [diff] [blame] | 54 | import gerrit_util |
szager@chromium.org | 151ebcf | 2016-03-09 01:08:25 +0000 | [diff] [blame] | 55 | import git_cache |
iannucci@chromium.org | 9e84927 | 2014-04-04 00:31:55 +0000 | [diff] [blame] | 56 | import git_common |
tandrii@chromium.org | 09d7a6a | 2016-03-04 15:44:48 +0000 | [diff] [blame] | 57 | import git_footers |
Edward Lemur | 5ba1e9c | 2018-07-23 18:19:02 +0000 | [diff] [blame] | 58 | import metrics |
Edward Lesmes | 93277a7 | 2018-10-18 22:04:26 +0000 | [diff] [blame] | 59 | import metrics_utils |
piman@chromium.org | 336f912 | 2014-09-04 02:16:55 +0000 | [diff] [blame] | 60 | import owners |
iannucci@chromium.org | 9e84927 | 2014-04-04 00:31:55 +0000 | [diff] [blame] | 61 | import owners_finder |
maruel@chromium.org | 2a74d37 | 2011-03-29 19:05:50 +0000 | [diff] [blame] | 62 | import presubmit_support |
| 63 | import scm |
Francois Doray | d42c681 | 2017-05-30 15:10:20 -0400 | [diff] [blame] | 64 | import split_cl |
maruel@chromium.org | 0633fb4 | 2013-08-16 20:06:14 +0000 | [diff] [blame] | 65 | import subcommand |
maruel@chromium.org | 32f9f5e | 2011-09-14 13:41:47 +0000 | [diff] [blame] | 66 | import subprocess2 |
maruel@chromium.org | 2a74d37 | 2011-03-29 19:05:50 +0000 | [diff] [blame] | 67 | import watchlists |
| 68 | |
tandrii | 7400cf0 | 2016-06-21 08:48:07 -0700 | [diff] [blame] | 69 | __version__ = '2.0' |
maruel@chromium.org | 2a74d37 | 2011-03-29 19:05:50 +0000 | [diff] [blame] | 70 | |
Edward Lemur | 0f58ae4 | 2019-04-30 17:24:12 +0000 | [diff] [blame^] | 71 | # Traces for git push will be stored in a traces directory inside the |
| 72 | # depot_tools checkout. |
| 73 | DEPOT_TOOLS = os.path.dirname(os.path.abspath(__file__)) |
| 74 | TRACES_DIR = os.path.join(DEPOT_TOOLS, 'traces') |
| 75 | |
| 76 | # When collecting traces, Git hashes will be reduced to 6 characters to reduce |
| 77 | # the size after compression. |
| 78 | GIT_HASH_RE = re.compile(r'\b([a-f0-9]{6})[a-f0-9]{34}\b', flags=re.I) |
| 79 | # Used to redact the cookies from the gitcookies file. |
| 80 | GITCOOKIES_REDACT_RE = re.compile(r'1/.*') |
| 81 | |
| 82 | TRACES_MESSAGE = ( |
| 83 | 'When filing a bug, be sure to include the traces found at:\n' |
| 84 | ' %s.zip\n' |
| 85 | 'Consider including the git config and gitcookies,\n' |
| 86 | 'which we have packed for you at:\n' |
| 87 | ' %s.zip\n') |
| 88 | |
tandrii | 9d2c7a3 | 2016-06-22 03:42:45 -0700 | [diff] [blame] | 89 | COMMIT_BOT_EMAIL = 'commit-bot@chromium.org' |
Aaron Gable | 1bc7bfe | 2016-12-19 10:08:14 -0800 | [diff] [blame] | 90 | POSTUPSTREAM_HOOK = '.git/hooks/post-cl-land' |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 91 | DESCRIPTION_BACKUP_FILE = '~/.git_cl_description_backup' |
rmistry@google.com | c68112d | 2015-03-03 12:48:06 +0000 | [diff] [blame] | 92 | REFS_THAT_ALIAS_TO_OTHER_REFS = { |
| 93 | 'refs/remotes/origin/lkgr': 'refs/remotes/origin/master', |
| 94 | 'refs/remotes/origin/lkcr': 'refs/remotes/origin/master', |
| 95 | } |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 96 | |
thestig@chromium.org | 44202a2 | 2014-03-11 19:22:18 +0000 | [diff] [blame] | 97 | # Valid extensions for files we want to lint. |
| 98 | DEFAULT_LINT_REGEX = r"(.*\.cpp|.*\.cc|.*\.h)" |
| 99 | DEFAULT_LINT_IGNORE_REGEX = r"$^" |
| 100 | |
Aiden Benner | c08566e | 2018-10-03 17:52:42 +0000 | [diff] [blame] | 101 | # File name for yapf style config files. |
| 102 | YAPF_CONFIG_FILENAME = '.style.yapf' |
| 103 | |
borenet | 6c0efe6 | 2016-10-19 08:13:29 -0700 | [diff] [blame] | 104 | # Buildbucket master name prefix. |
| 105 | MASTER_PREFIX = 'master.' |
| 106 | |
maruel@chromium.org | 2e23ce3 | 2013-05-07 12:42:28 +0000 | [diff] [blame] | 107 | # Shortcut since it quickly becomes redundant. |
| 108 | Fore = colorama.Fore |
maruel@chromium.org | 9054173 | 2011-04-01 17:54:18 +0000 | [diff] [blame] | 109 | |
maruel@chromium.org | ddd5941 | 2011-11-30 14:20:38 +0000 | [diff] [blame] | 110 | # Initialized in main() |
| 111 | settings = None |
| 112 | |
Andrii Shyshkalov | 768f1d8 | 2016-12-08 15:10:13 +0100 | [diff] [blame] | 113 | # Used by tests/git_cl_test.py to add extra logging. |
| 114 | # Inside the weirdly failing test, add this: |
| 115 | # >>> self.mock(git_cl, '_IS_BEING_TESTED', True) |
Quinten Yearsley | 0c62da9 | 2017-05-31 13:39:42 -0700 | [diff] [blame] | 116 | # And scroll up to see the stack trace printed. |
Andrii Shyshkalov | 768f1d8 | 2016-12-08 15:10:13 +0100 | [diff] [blame] | 117 | _IS_BEING_TESTED = False |
| 118 | |
maruel@chromium.org | ddd5941 | 2011-11-30 14:20:38 +0000 | [diff] [blame] | 119 | |
Christopher Lam | f732cd5 | 2017-01-24 12:40:11 +1100 | [diff] [blame] | 120 | def DieWithError(message, change_desc=None): |
| 121 | if change_desc: |
| 122 | SaveDescriptionBackup(change_desc) |
| 123 | |
vapier | a7fbd5a | 2016-06-16 09:17:49 -0700 | [diff] [blame] | 124 | print(message, file=sys.stderr) |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 125 | sys.exit(1) |
| 126 | |
| 127 | |
Christopher Lam | f732cd5 | 2017-01-24 12:40:11 +1100 | [diff] [blame] | 128 | def SaveDescriptionBackup(change_desc): |
| 129 | backup_path = os.path.expanduser(DESCRIPTION_BACKUP_FILE) |
Andrii Shyshkalov | d9fdc1f | 2018-09-27 02:13:09 +0000 | [diff] [blame] | 130 | print('\nsaving CL description to %s\n' % backup_path) |
Christopher Lam | f732cd5 | 2017-01-24 12:40:11 +1100 | [diff] [blame] | 131 | backup_file = open(backup_path, 'w') |
| 132 | backup_file.write(change_desc.description) |
| 133 | backup_file.close() |
| 134 | |
| 135 | |
thestig@chromium.org | 8b0553c | 2014-02-11 00:33:37 +0000 | [diff] [blame] | 136 | def GetNoGitPagerEnv(): |
| 137 | env = os.environ.copy() |
| 138 | # 'cat' is a magical git string that disables pagers on all platforms. |
| 139 | env['GIT_PAGER'] = 'cat' |
| 140 | return env |
| 141 | |
vadimsh@chromium.org | 566a02a | 2014-08-22 01:34:13 +0000 | [diff] [blame] | 142 | |
bsep@chromium.org | 627d900 | 2016-04-29 00:00:52 +0000 | [diff] [blame] | 143 | def RunCommand(args, error_ok=False, error_message=None, shell=False, **kwargs): |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 144 | try: |
bsep@chromium.org | 627d900 | 2016-04-29 00:00:52 +0000 | [diff] [blame] | 145 | return subprocess2.check_output(args, shell=shell, **kwargs) |
maruel@chromium.org | 78936cb | 2013-04-11 00:17:52 +0000 | [diff] [blame] | 146 | except subprocess2.CalledProcessError as e: |
| 147 | logging.debug('Failed running %s', args) |
maruel@chromium.org | 32f9f5e | 2011-09-14 13:41:47 +0000 | [diff] [blame] | 148 | if not error_ok: |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 149 | DieWithError( |
maruel@chromium.org | 32f9f5e | 2011-09-14 13:41:47 +0000 | [diff] [blame] | 150 | 'Command "%s" failed.\n%s' % ( |
| 151 | ' '.join(args), error_message or e.stdout or '')) |
| 152 | return e.stdout |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 153 | |
| 154 | |
| 155 | def RunGit(args, **kwargs): |
maruel@chromium.org | 32f9f5e | 2011-09-14 13:41:47 +0000 | [diff] [blame] | 156 | """Returns stdout.""" |
bratell@opera.com | 82b91cd | 2013-07-09 06:33:41 +0000 | [diff] [blame] | 157 | return RunCommand(['git'] + args, **kwargs) |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 158 | |
| 159 | |
enne@chromium.org | 3b7e15c | 2014-01-21 17:44:47 +0000 | [diff] [blame] | 160 | def RunGitWithCode(args, suppress_stderr=False): |
maruel@chromium.org | 32f9f5e | 2011-09-14 13:41:47 +0000 | [diff] [blame] | 161 | """Returns return code and stdout.""" |
tandrii | 5d48c32 | 2016-08-18 16:19:37 -0700 | [diff] [blame] | 162 | if suppress_stderr: |
| 163 | stderr = subprocess2.VOID |
| 164 | else: |
| 165 | stderr = sys.stderr |
szager@chromium.org | 9bb85e2 | 2012-06-13 20:28:23 +0000 | [diff] [blame] | 166 | try: |
tandrii | 5d48c32 | 2016-08-18 16:19:37 -0700 | [diff] [blame] | 167 | (out, _), code = subprocess2.communicate(['git'] + args, |
| 168 | env=GetNoGitPagerEnv(), |
| 169 | stdout=subprocess2.PIPE, |
| 170 | stderr=stderr) |
| 171 | return code, out |
| 172 | except subprocess2.CalledProcessError as e: |
Yoshisato Yanagisawa | 81e3ff5 | 2017-09-26 15:33:34 +0900 | [diff] [blame] | 173 | logging.debug('Failed running %s', ['git'] + args) |
tandrii | 5d48c32 | 2016-08-18 16:19:37 -0700 | [diff] [blame] | 174 | return e.returncode, e.stdout |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 175 | |
| 176 | |
bauerb@chromium.org | 27386dd | 2015-02-16 10:45:39 +0000 | [diff] [blame] | 177 | def RunGitSilent(args): |
clemensh@chromium.org | cbd7dc3 | 2016-05-31 10:33:50 +0000 | [diff] [blame] | 178 | """Returns stdout, suppresses stderr and ignores the return code.""" |
bauerb@chromium.org | 27386dd | 2015-02-16 10:45:39 +0000 | [diff] [blame] | 179 | return RunGitWithCode(args, suppress_stderr=True)[1] |
| 180 | |
| 181 | |
tapted@chromium.org | 6a0b07c | 2013-07-10 01:29:19 +0000 | [diff] [blame] | 182 | def IsGitVersionAtLeast(min_version): |
ilevy@chromium.org | cc56ee4 | 2013-07-10 22:16:29 +0000 | [diff] [blame] | 183 | prefix = 'git version ' |
tapted@chromium.org | 6a0b07c | 2013-07-10 01:29:19 +0000 | [diff] [blame] | 184 | version = RunGit(['--version']).strip() |
ilevy@chromium.org | cc56ee4 | 2013-07-10 22:16:29 +0000 | [diff] [blame] | 185 | return (version.startswith(prefix) and |
| 186 | LooseVersion(version[len(prefix):]) >= LooseVersion(min_version)) |
tapted@chromium.org | 6a0b07c | 2013-07-10 01:29:19 +0000 | [diff] [blame] | 187 | |
| 188 | |
pgervais@chromium.org | 8ba38ff | 2015-06-11 21:41:25 +0000 | [diff] [blame] | 189 | def BranchExists(branch): |
| 190 | """Return True if specified branch exists.""" |
| 191 | code, _ = RunGitWithCode(['rev-parse', '--verify', branch], |
| 192 | suppress_stderr=True) |
| 193 | return not code |
| 194 | |
| 195 | |
tandrii | 2a16b95 | 2016-10-19 07:09:44 -0700 | [diff] [blame] | 196 | def time_sleep(seconds): |
| 197 | # Use this so that it can be mocked in tests without interfering with python |
| 198 | # system machinery. |
tandrii | 2a16b95 | 2016-10-19 07:09:44 -0700 | [diff] [blame] | 199 | return time.sleep(seconds) |
| 200 | |
| 201 | |
Edward Lemur | 01f4a4f | 2018-11-03 00:40:38 +0000 | [diff] [blame] | 202 | def time_time(): |
| 203 | # Use this so that it can be mocked in tests without interfering with python |
| 204 | # system machinery. |
| 205 | return time.time() |
| 206 | |
| 207 | |
maruel@chromium.org | 9054173 | 2011-04-01 17:54:18 +0000 | [diff] [blame] | 208 | def ask_for_data(prompt): |
| 209 | try: |
| 210 | return raw_input(prompt) |
| 211 | except KeyboardInterrupt: |
| 212 | # Hide the exception. |
| 213 | sys.exit(1) |
| 214 | |
| 215 | |
Andrii Shyshkalov | abc26ac | 2017-03-14 14:49:38 +0100 | [diff] [blame] | 216 | def confirm_or_exit(prefix='', action='confirm'): |
| 217 | """Asks user to press enter to continue or press Ctrl+C to abort.""" |
| 218 | if not prefix or prefix.endswith('\n'): |
| 219 | mid = 'Press' |
Andrii Shyshkalov | 353637c | 2017-03-14 16:52:18 +0100 | [diff] [blame] | 220 | elif prefix.endswith('.') or prefix.endswith('?'): |
Andrii Shyshkalov | abc26ac | 2017-03-14 14:49:38 +0100 | [diff] [blame] | 221 | mid = ' Press' |
| 222 | elif prefix.endswith(' '): |
| 223 | mid = 'press' |
| 224 | else: |
| 225 | mid = ' press' |
| 226 | ask_for_data('%s%s Enter to %s, or Ctrl+C to abort' % (prefix, mid, action)) |
| 227 | |
| 228 | |
| 229 | def ask_for_explicit_yes(prompt): |
| 230 | """Returns whether user typed 'y' or 'yes' to confirm the given prompt""" |
| 231 | result = ask_for_data(prompt + ' [Yes/No]: ').lower() |
| 232 | while True: |
| 233 | if 'yes'.startswith(result): |
| 234 | return True |
| 235 | if 'no'.startswith(result): |
| 236 | return False |
| 237 | result = ask_for_data('Please, type yes or no: ').lower() |
| 238 | |
| 239 | |
tandrii | 5d48c32 | 2016-08-18 16:19:37 -0700 | [diff] [blame] | 240 | def _git_branch_config_key(branch, key): |
| 241 | """Helper method to return Git config key for a branch.""" |
| 242 | assert branch, 'branch name is required to set git config for it' |
| 243 | return 'branch.%s.%s' % (branch, key) |
| 244 | |
| 245 | |
| 246 | def _git_get_branch_config_value(key, default=None, value_type=str, |
| 247 | branch=False): |
| 248 | """Returns git config value of given or current branch if any. |
| 249 | |
| 250 | Returns default in all other cases. |
| 251 | """ |
| 252 | assert value_type in (int, str, bool) |
| 253 | if branch is False: # Distinguishing default arg value from None. |
| 254 | branch = GetCurrentBranch() |
| 255 | |
rogerta@chromium.org | caa1655 | 2013-03-18 20:45:05 +0000 | [diff] [blame] | 256 | if not branch: |
tandrii | 5d48c32 | 2016-08-18 16:19:37 -0700 | [diff] [blame] | 257 | return default |
rogerta@chromium.org | caa1655 | 2013-03-18 20:45:05 +0000 | [diff] [blame] | 258 | |
tandrii | 5d48c32 | 2016-08-18 16:19:37 -0700 | [diff] [blame] | 259 | args = ['config'] |
tandrii | 33a46ff | 2016-08-23 05:53:40 -0700 | [diff] [blame] | 260 | if value_type == bool: |
tandrii | 5d48c32 | 2016-08-18 16:19:37 -0700 | [diff] [blame] | 261 | args.append('--bool') |
tandrii | 33a46ff | 2016-08-23 05:53:40 -0700 | [diff] [blame] | 262 | # git config also has --int, but apparently git config suffers from integer |
| 263 | # overflows (http://crbug.com/640115), so don't use it. |
tandrii | 5d48c32 | 2016-08-18 16:19:37 -0700 | [diff] [blame] | 264 | args.append(_git_branch_config_key(branch, key)) |
| 265 | code, out = RunGitWithCode(args) |
| 266 | if code == 0: |
| 267 | value = out.strip() |
| 268 | if value_type == int: |
| 269 | return int(value) |
| 270 | if value_type == bool: |
| 271 | return bool(value.lower() == 'true') |
| 272 | return value |
iannucci@chromium.org | 7954005 | 2012-10-19 23:15:26 +0000 | [diff] [blame] | 273 | return default |
| 274 | |
| 275 | |
tandrii | 5d48c32 | 2016-08-18 16:19:37 -0700 | [diff] [blame] | 276 | def _git_set_branch_config_value(key, value, branch=None, **kwargs): |
| 277 | """Sets the value or unsets if it's None of a git branch config. |
| 278 | |
| 279 | Valid, though not necessarily existing, branch must be provided, |
| 280 | otherwise currently checked out branch is used. |
| 281 | """ |
| 282 | if not branch: |
| 283 | branch = GetCurrentBranch() |
| 284 | assert branch, 'a branch name OR currently checked out branch is required' |
| 285 | args = ['config'] |
qyearsley | 12fa6ff | 2016-08-24 09:18:40 -0700 | [diff] [blame] | 286 | # Check for boolean first, because bool is int, but int is not bool. |
tandrii | 5d48c32 | 2016-08-18 16:19:37 -0700 | [diff] [blame] | 287 | if value is None: |
| 288 | args.append('--unset') |
| 289 | elif isinstance(value, bool): |
| 290 | args.append('--bool') |
| 291 | value = str(value).lower() |
tandrii | 5d48c32 | 2016-08-18 16:19:37 -0700 | [diff] [blame] | 292 | else: |
tandrii | 33a46ff | 2016-08-23 05:53:40 -0700 | [diff] [blame] | 293 | # git config also has --int, but apparently git config suffers from integer |
| 294 | # overflows (http://crbug.com/640115), so don't use it. |
tandrii | 5d48c32 | 2016-08-18 16:19:37 -0700 | [diff] [blame] | 295 | value = str(value) |
| 296 | args.append(_git_branch_config_key(branch, key)) |
| 297 | if value is not None: |
| 298 | args.append(value) |
| 299 | RunGit(args, **kwargs) |
| 300 | |
| 301 | |
Andrii Shyshkalov | a669581 | 2016-12-06 17:47:09 +0100 | [diff] [blame] | 302 | def _get_committer_timestamp(commit): |
Quinten Yearsley | 0c62da9 | 2017-05-31 13:39:42 -0700 | [diff] [blame] | 303 | """Returns Unix timestamp as integer of a committer in a commit. |
Andrii Shyshkalov | a669581 | 2016-12-06 17:47:09 +0100 | [diff] [blame] | 304 | |
| 305 | Commit can be whatever git show would recognize, such as HEAD, sha1 or ref. |
| 306 | """ |
| 307 | # Git also stores timezone offset, but it only affects visual display, |
| 308 | # actual point in time is defined by this timestamp only. |
| 309 | return int(RunGit(['show', '-s', '--format=%ct', commit]).strip()) |
| 310 | |
| 311 | |
| 312 | def _git_amend_head(message, committer_timestamp): |
| 313 | """Amends commit with new message and desired committer_timestamp. |
| 314 | |
| 315 | Sets committer timezone to UTC. |
| 316 | """ |
| 317 | env = os.environ.copy() |
| 318 | env['GIT_COMMITTER_DATE'] = '%d+0000' % committer_timestamp |
| 319 | return RunGit(['commit', '--amend', '-m', message], env=env) |
| 320 | |
| 321 | |
machenbach@chromium.org | 4545314 | 2015-09-15 08:45:22 +0000 | [diff] [blame] | 322 | def _get_properties_from_options(options): |
| 323 | properties = dict(x.split('=', 1) for x in options.properties) |
| 324 | for key, val in properties.iteritems(): |
| 325 | try: |
| 326 | properties[key] = json.loads(val) |
| 327 | except ValueError: |
| 328 | pass # If a value couldn't be evaluated, treat it as a string. |
| 329 | return properties |
| 330 | |
| 331 | |
sheyang@google.com | 6ebaf78 | 2015-05-12 19:17:54 +0000 | [diff] [blame] | 332 | def _prefix_master(master): |
| 333 | """Convert user-specified master name to full master name. |
| 334 | |
| 335 | Buildbucket uses full master name(master.tryserver.chromium.linux) as bucket |
| 336 | name, while the developers always use shortened master name |
| 337 | (tryserver.chromium.linux) by stripping off the prefix 'master.'. This |
| 338 | function does the conversion for buildbucket migration. |
| 339 | """ |
borenet | 6c0efe6 | 2016-10-19 08:13:29 -0700 | [diff] [blame] | 340 | if master.startswith(MASTER_PREFIX): |
sheyang@google.com | 6ebaf78 | 2015-05-12 19:17:54 +0000 | [diff] [blame] | 341 | return master |
borenet | 6c0efe6 | 2016-10-19 08:13:29 -0700 | [diff] [blame] | 342 | return '%s%s' % (MASTER_PREFIX, master) |
| 343 | |
| 344 | |
| 345 | def _unprefix_master(bucket): |
| 346 | """Convert bucket name to shortened master name. |
| 347 | |
| 348 | Buildbucket uses full master name(master.tryserver.chromium.linux) as bucket |
| 349 | name, while the developers always use shortened master name |
| 350 | (tryserver.chromium.linux) by stripping off the prefix 'master.'. This |
| 351 | function does the conversion for buildbucket migration. |
| 352 | """ |
| 353 | if bucket.startswith(MASTER_PREFIX): |
| 354 | return bucket[len(MASTER_PREFIX):] |
| 355 | return bucket |
sheyang@google.com | 6ebaf78 | 2015-05-12 19:17:54 +0000 | [diff] [blame] | 356 | |
| 357 | |
tandrii@chromium.org | b015fac | 2016-02-26 14:52:01 +0000 | [diff] [blame] | 358 | def _buildbucket_retry(operation_name, http, *args, **kwargs): |
| 359 | """Retries requests to buildbucket service and returns parsed json content.""" |
| 360 | try_count = 0 |
| 361 | while True: |
| 362 | response, content = http.request(*args, **kwargs) |
| 363 | try: |
| 364 | content_json = json.loads(content) |
| 365 | except ValueError: |
| 366 | content_json = None |
| 367 | |
| 368 | # Buildbucket could return an error even if status==200. |
| 369 | if content_json and content_json.get('error'): |
nodir@chromium.org | baff4e1 | 2016-03-08 00:33:57 +0000 | [diff] [blame] | 370 | error = content_json.get('error') |
| 371 | if error.get('code') == 403: |
| 372 | raise BuildbucketResponseException( |
| 373 | 'Access denied: %s' % error.get('message', '')) |
tandrii@chromium.org | b015fac | 2016-02-26 14:52:01 +0000 | [diff] [blame] | 374 | msg = 'Error in response. Reason: %s. Message: %s.' % ( |
nodir@chromium.org | baff4e1 | 2016-03-08 00:33:57 +0000 | [diff] [blame] | 375 | error.get('reason', ''), error.get('message', '')) |
tandrii@chromium.org | b015fac | 2016-02-26 14:52:01 +0000 | [diff] [blame] | 376 | raise BuildbucketResponseException(msg) |
| 377 | |
| 378 | if response.status == 200: |
Nodir Turakulov | 23d75d2 | 2018-06-04 12:37:32 -0700 | [diff] [blame] | 379 | if content_json is None: |
tandrii@chromium.org | b015fac | 2016-02-26 14:52:01 +0000 | [diff] [blame] | 380 | raise BuildbucketResponseException( |
| 381 | 'Buildbucket returns invalid json content: %s.\n' |
Nodir Turakulov | 9ac5979 | 2018-06-04 12:34:14 -0700 | [diff] [blame] | 382 | 'Please file bugs at http://crbug.com, ' |
| 383 | 'component "Infra>Platform>BuildBucket".' % |
tandrii@chromium.org | b015fac | 2016-02-26 14:52:01 +0000 | [diff] [blame] | 384 | content) |
| 385 | return content_json |
| 386 | if response.status < 500 or try_count >= 2: |
| 387 | raise httplib2.HttpLib2Error(content) |
| 388 | |
| 389 | # status >= 500 means transient failures. |
| 390 | logging.debug('Transient errors when %s. Will retry.', operation_name) |
tandrii | 2a16b95 | 2016-10-19 07:09:44 -0700 | [diff] [blame] | 391 | time_sleep(0.5 + 1.5*try_count) |
tandrii@chromium.org | b015fac | 2016-02-26 14:52:01 +0000 | [diff] [blame] | 392 | try_count += 1 |
| 393 | assert False, 'unreachable' |
| 394 | |
| 395 | |
qyearsley | 1fdfcb6 | 2016-10-24 13:22:03 -0700 | [diff] [blame] | 396 | def _get_bucket_map(changelist, options, option_parser): |
qyearsley | dd49f94 | 2016-10-28 11:57:22 -0700 | [diff] [blame] | 397 | """Returns a dict mapping bucket names to builders and tests, |
| 398 | for triggering try jobs. |
qyearsley | 1fdfcb6 | 2016-10-24 13:22:03 -0700 | [diff] [blame] | 399 | """ |
qyearsley | dd49f94 | 2016-10-28 11:57:22 -0700 | [diff] [blame] | 400 | # If no bots are listed, we try to get a set of builders and tests based |
| 401 | # on GetPreferredTryMasters functions in PRESUBMIT.py files. |
qyearsley | 1fdfcb6 | 2016-10-24 13:22:03 -0700 | [diff] [blame] | 402 | if not options.bot: |
| 403 | change = changelist.GetChange( |
| 404 | changelist.GetCommonAncestorWithUpstream(), None) |
qyearsley | 136b49f | 2016-10-31 09:02:26 -0700 | [diff] [blame] | 405 | # Get try masters from PRESUBMIT.py files. |
nodir | e4f0fe0 | 2016-11-04 16:23:30 -0700 | [diff] [blame] | 406 | masters = presubmit_support.DoGetTryMasters( |
qyearsley | 1fdfcb6 | 2016-10-24 13:22:03 -0700 | [diff] [blame] | 407 | change=change, |
| 408 | changed_files=change.LocalPaths(), |
| 409 | repository_root=settings.GetRoot(), |
| 410 | default_presubmit=None, |
| 411 | project=None, |
| 412 | verbose=options.verbose, |
| 413 | output_stream=sys.stdout) |
nodir | e4f0fe0 | 2016-11-04 16:23:30 -0700 | [diff] [blame] | 414 | if masters is None: |
| 415 | return None |
Sergiy Byelozyorov | 935b93f | 2016-11-28 20:41:56 +0100 | [diff] [blame] | 416 | return {_prefix_master(m): b for m, b in masters.iteritems()} |
qyearsley | 1fdfcb6 | 2016-10-24 13:22:03 -0700 | [diff] [blame] | 417 | |
qyearsley | 1fdfcb6 | 2016-10-24 13:22:03 -0700 | [diff] [blame] | 418 | if options.bucket: |
| 419 | return {options.bucket: {b: [] for b in options.bot}} |
qyearsley | dd49f94 | 2016-10-28 11:57:22 -0700 | [diff] [blame] | 420 | if options.master: |
| 421 | return {_prefix_master(options.master): {b: [] for b in options.bot}} |
qyearsley | 1fdfcb6 | 2016-10-24 13:22:03 -0700 | [diff] [blame] | 422 | |
qyearsley | dd49f94 | 2016-10-28 11:57:22 -0700 | [diff] [blame] | 423 | # If bots are listed but no master or bucket, then we need to find out |
| 424 | # the corresponding master for each bot. |
| 425 | bucket_map, error_message = _get_bucket_map_for_builders(options.bot) |
| 426 | if error_message: |
| 427 | option_parser.error( |
| 428 | 'Tryserver master cannot be found because: %s\n' |
| 429 | 'Please manually specify the tryserver master, e.g. ' |
| 430 | '"-m tryserver.chromium.linux".' % error_message) |
| 431 | return bucket_map |
qyearsley | 1fdfcb6 | 2016-10-24 13:22:03 -0700 | [diff] [blame] | 432 | |
| 433 | |
qyearsley | 123a468 | 2016-10-26 09:12:17 -0700 | [diff] [blame] | 434 | def _get_bucket_map_for_builders(builders): |
| 435 | """Returns a map of buckets to builders for the given builders.""" |
qyearsley | 1fdfcb6 | 2016-10-24 13:22:03 -0700 | [diff] [blame] | 436 | map_url = 'https://builders-map.appspot.com/' |
| 437 | try: |
qyearsley | 123a468 | 2016-10-26 09:12:17 -0700 | [diff] [blame] | 438 | builders_map = json.load(urllib2.urlopen(map_url)) |
qyearsley | 1fdfcb6 | 2016-10-24 13:22:03 -0700 | [diff] [blame] | 439 | except urllib2.URLError as e: |
| 440 | return None, ('Failed to fetch builder-to-master map from %s. Error: %s.' % |
| 441 | (map_url, e)) |
| 442 | except ValueError as e: |
| 443 | return None, ('Invalid json string from %s. Error: %s.' % (map_url, e)) |
qyearsley | 123a468 | 2016-10-26 09:12:17 -0700 | [diff] [blame] | 444 | if not builders_map: |
qyearsley | 1fdfcb6 | 2016-10-24 13:22:03 -0700 | [diff] [blame] | 445 | return None, 'Failed to build master map.' |
| 446 | |
qyearsley | 123a468 | 2016-10-26 09:12:17 -0700 | [diff] [blame] | 447 | bucket_map = {} |
| 448 | for builder in builders: |
Nodir Turakulov | b422e68 | 2018-02-20 22:51:30 -0800 | [diff] [blame] | 449 | bucket = builders_map.get(builder, {}).get('bucket') |
| 450 | if bucket: |
| 451 | bucket_map.setdefault(bucket, {})[builder] = [] |
qyearsley | 123a468 | 2016-10-26 09:12:17 -0700 | [diff] [blame] | 452 | return bucket_map, None |
qyearsley | 1fdfcb6 | 2016-10-24 13:22:03 -0700 | [diff] [blame] | 453 | |
| 454 | |
Andrii Shyshkalov | f9648b5 | 2018-02-21 22:32:42 -0800 | [diff] [blame] | 455 | def _trigger_try_jobs(auth_config, changelist, buckets, options, patchset): |
qyearsley | 1fdfcb6 | 2016-10-24 13:22:03 -0700 | [diff] [blame] | 456 | """Sends a request to Buildbucket to trigger try jobs for a changelist. |
| 457 | |
| 458 | Args: |
Aaron Gable | fb28d48 | 2018-04-02 13:08:06 -0700 | [diff] [blame] | 459 | auth_config: AuthConfig for Buildbucket. |
qyearsley | 1fdfcb6 | 2016-10-24 13:22:03 -0700 | [diff] [blame] | 460 | changelist: Changelist that the try jobs are associated with. |
| 461 | buckets: A nested dict mapping bucket names to builders to tests. |
| 462 | options: Command-line options. |
| 463 | """ |
tandrii | de281ae | 2016-10-12 06:02:30 -0700 | [diff] [blame] | 464 | assert changelist.GetIssue(), 'CL must be uploaded first' |
| 465 | codereview_url = changelist.GetCodereviewServer() |
| 466 | assert codereview_url, 'CL must be uploaded first' |
| 467 | patchset = patchset or changelist.GetMostRecentPatchset() |
| 468 | assert patchset, 'CL must be uploaded first' |
| 469 | |
| 470 | codereview_host = urlparse.urlparse(codereview_url).hostname |
Aaron Gable | fb28d48 | 2018-04-02 13:08:06 -0700 | [diff] [blame] | 471 | # Cache the buildbucket credentials under the codereview host key, so that |
| 472 | # users can use different credentials for different buckets. |
tandrii | de281ae | 2016-10-12 06:02:30 -0700 | [diff] [blame] | 473 | authenticator = auth.get_authenticator_for_host(codereview_host, auth_config) |
sheyang@google.com | 6ebaf78 | 2015-05-12 19:17:54 +0000 | [diff] [blame] | 474 | http = authenticator.authorize(httplib2.Http()) |
| 475 | http.force_exception_to_status_code = True |
tandrii | de281ae | 2016-10-12 06:02:30 -0700 | [diff] [blame] | 476 | |
sheyang@google.com | 6ebaf78 | 2015-05-12 19:17:54 +0000 | [diff] [blame] | 477 | buildbucket_put_url = ( |
| 478 | 'https://{hostname}/_ah/api/buildbucket/v1/builds/batch'.format( |
sheyang@chromium.org | db37557 | 2015-08-17 19:22:23 +0000 | [diff] [blame] | 479 | hostname=options.buildbucket_host)) |
Andrii Shyshkalov | 03da150 | 2018-10-15 03:42:34 +0000 | [diff] [blame] | 480 | buildset = 'patch/gerrit/{hostname}/{issue}/{patch}'.format( |
tandrii | de281ae | 2016-10-12 06:02:30 -0700 | [diff] [blame] | 481 | hostname=codereview_host, |
| 482 | issue=changelist.GetIssue(), |
sheyang@google.com | 6ebaf78 | 2015-05-12 19:17:54 +0000 | [diff] [blame] | 483 | patch=patchset) |
tandrii | 8c5a353 | 2016-11-04 07:52:02 -0700 | [diff] [blame] | 484 | |
Quinten Yearsley | 0c62da9 | 2017-05-31 13:39:42 -0700 | [diff] [blame] | 485 | shared_parameters_properties = changelist.GetTryJobProperties(patchset) |
Andrii Shyshkalov | f9648b5 | 2018-02-21 22:32:42 -0800 | [diff] [blame] | 486 | shared_parameters_properties['category'] = options.category |
tandrii | 8c5a353 | 2016-11-04 07:52:02 -0700 | [diff] [blame] | 487 | if options.clobber: |
| 488 | shared_parameters_properties['clobber'] = True |
tandrii | de281ae | 2016-10-12 06:02:30 -0700 | [diff] [blame] | 489 | extra_properties = _get_properties_from_options(options) |
tandrii | 8c5a353 | 2016-11-04 07:52:02 -0700 | [diff] [blame] | 490 | if extra_properties: |
| 491 | shared_parameters_properties.update(extra_properties) |
sheyang@google.com | 6ebaf78 | 2015-05-12 19:17:54 +0000 | [diff] [blame] | 492 | |
| 493 | batch_req_body = {'builds': []} |
| 494 | print_text = [] |
| 495 | print_text.append('Tried jobs on:') |
borenet | 6c0efe6 | 2016-10-19 08:13:29 -0700 | [diff] [blame] | 496 | for bucket, builders_and_tests in sorted(buckets.iteritems()): |
| 497 | print_text.append('Bucket: %s' % bucket) |
| 498 | master = None |
| 499 | if bucket.startswith(MASTER_PREFIX): |
| 500 | master = _unprefix_master(bucket) |
sheyang@google.com | 6ebaf78 | 2015-05-12 19:17:54 +0000 | [diff] [blame] | 501 | for builder, tests in sorted(builders_and_tests.iteritems()): |
| 502 | print_text.append(' %s: %s' % (builder, tests)) |
| 503 | parameters = { |
| 504 | 'builder_name': builder, |
nodir@chromium.org | d221731 | 2015-09-21 15:51:21 +0000 | [diff] [blame] | 505 | 'changes': [{ |
Andrii Shyshkalov | eadad92 | 2017-01-26 09:38:30 +0100 | [diff] [blame] | 506 | 'author': {'email': changelist.GetIssueOwner()}, |
nodir@chromium.org | d221731 | 2015-09-21 15:51:21 +0000 | [diff] [blame] | 507 | 'revision': options.revision, |
| 508 | }], |
tandrii | 8c5a353 | 2016-11-04 07:52:02 -0700 | [diff] [blame] | 509 | 'properties': shared_parameters_properties.copy(), |
sheyang@google.com | 6ebaf78 | 2015-05-12 19:17:54 +0000 | [diff] [blame] | 510 | } |
machenbach@chromium.org | 2403e80 | 2016-04-29 12:34:42 +0000 | [diff] [blame] | 511 | if 'presubmit' in builder.lower(): |
| 512 | parameters['properties']['dry_run'] = 'true' |
tandrii@chromium.org | 3764fa2 | 2015-10-21 16:40:40 +0000 | [diff] [blame] | 513 | if tests: |
| 514 | parameters['properties']['testfilter'] = tests |
borenet | 6c0efe6 | 2016-10-19 08:13:29 -0700 | [diff] [blame] | 515 | |
| 516 | tags = [ |
| 517 | 'builder:%s' % builder, |
| 518 | 'buildset:%s' % buildset, |
| 519 | 'user_agent:git_cl_try', |
| 520 | ] |
| 521 | if master: |
| 522 | parameters['properties']['master'] = master |
| 523 | tags.append('master:%s' % master) |
| 524 | |
sheyang@google.com | 6ebaf78 | 2015-05-12 19:17:54 +0000 | [diff] [blame] | 525 | batch_req_body['builds'].append( |
| 526 | { |
| 527 | 'bucket': bucket, |
| 528 | 'parameters_json': json.dumps(parameters), |
tandrii@chromium.org | b015fac | 2016-02-26 14:52:01 +0000 | [diff] [blame] | 529 | 'client_operation_id': str(uuid.uuid4()), |
borenet | 6c0efe6 | 2016-10-19 08:13:29 -0700 | [diff] [blame] | 530 | 'tags': tags, |
sheyang@google.com | 6ebaf78 | 2015-05-12 19:17:54 +0000 | [diff] [blame] | 531 | } |
| 532 | ) |
| 533 | |
tandrii@chromium.org | b015fac | 2016-02-26 14:52:01 +0000 | [diff] [blame] | 534 | _buildbucket_retry( |
qyearsley | eab3c04 | 2016-08-24 09:18:28 -0700 | [diff] [blame] | 535 | 'triggering try jobs', |
tandrii@chromium.org | b015fac | 2016-02-26 14:52:01 +0000 | [diff] [blame] | 536 | http, |
| 537 | buildbucket_put_url, |
| 538 | 'PUT', |
| 539 | body=json.dumps(batch_req_body), |
| 540 | headers={'Content-Type': 'application/json'} |
| 541 | ) |
tandrii@chromium.org | 35c6145 | 2016-02-26 15:24:57 +0000 | [diff] [blame] | 542 | print_text.append('To see results here, run: git cl try-results') |
| 543 | print_text.append('To see results in browser, run: git cl web') |
vapier | a7fbd5a | 2016-06-16 09:17:49 -0700 | [diff] [blame] | 544 | print('\n'.join(print_text)) |
kjellander@chromium.org | 4442454 | 2015-06-02 18:35:29 +0000 | [diff] [blame] | 545 | |
sheyang@google.com | 6ebaf78 | 2015-05-12 19:17:54 +0000 | [diff] [blame] | 546 | |
tandrii | 221ab25 | 2016-10-06 08:12:04 -0700 | [diff] [blame] | 547 | def fetch_try_jobs(auth_config, changelist, buildbucket_host, |
| 548 | patchset=None): |
qyearsley | eab3c04 | 2016-08-24 09:18:28 -0700 | [diff] [blame] | 549 | """Fetches try jobs from buildbucket. |
tandrii@chromium.org | b015fac | 2016-02-26 14:52:01 +0000 | [diff] [blame] | 550 | |
qyearsley | 53f48a1 | 2016-09-01 10:45:13 -0700 | [diff] [blame] | 551 | Returns a map from build id to build info as a dictionary. |
tandrii@chromium.org | b015fac | 2016-02-26 14:52:01 +0000 | [diff] [blame] | 552 | """ |
tandrii | 221ab25 | 2016-10-06 08:12:04 -0700 | [diff] [blame] | 553 | assert buildbucket_host |
| 554 | assert changelist.GetIssue(), 'CL must be uploaded first' |
| 555 | assert changelist.GetCodereviewServer(), 'CL must be uploaded first' |
| 556 | patchset = patchset or changelist.GetMostRecentPatchset() |
| 557 | assert patchset, 'CL must be uploaded first' |
| 558 | |
| 559 | codereview_url = changelist.GetCodereviewServer() |
| 560 | codereview_host = urlparse.urlparse(codereview_url).hostname |
| 561 | authenticator = auth.get_authenticator_for_host(codereview_host, auth_config) |
tandrii@chromium.org | b015fac | 2016-02-26 14:52:01 +0000 | [diff] [blame] | 562 | if authenticator.has_cached_credentials(): |
| 563 | http = authenticator.authorize(httplib2.Http()) |
| 564 | else: |
vapier | a7fbd5a | 2016-06-16 09:17:49 -0700 | [diff] [blame] | 565 | print('Warning: Some results might be missing because %s' % |
| 566 | # Get the message on how to login. |
tandrii | 221ab25 | 2016-10-06 08:12:04 -0700 | [diff] [blame] | 567 | (auth.LoginRequiredError(codereview_host).message,)) |
tandrii@chromium.org | b015fac | 2016-02-26 14:52:01 +0000 | [diff] [blame] | 568 | http = httplib2.Http() |
| 569 | |
| 570 | http.force_exception_to_status_code = True |
| 571 | |
Andrii Shyshkalov | 03da150 | 2018-10-15 03:42:34 +0000 | [diff] [blame] | 572 | buildset = 'patch/gerrit/{hostname}/{issue}/{patch}'.format( |
tandrii | 221ab25 | 2016-10-06 08:12:04 -0700 | [diff] [blame] | 573 | hostname=codereview_host, |
tandrii@chromium.org | b015fac | 2016-02-26 14:52:01 +0000 | [diff] [blame] | 574 | issue=changelist.GetIssue(), |
tandrii | 221ab25 | 2016-10-06 08:12:04 -0700 | [diff] [blame] | 575 | patch=patchset) |
tandrii@chromium.org | b015fac | 2016-02-26 14:52:01 +0000 | [diff] [blame] | 576 | params = {'tag': 'buildset:%s' % buildset} |
| 577 | |
| 578 | builds = {} |
| 579 | while True: |
| 580 | url = 'https://{hostname}/_ah/api/buildbucket/v1/search?{params}'.format( |
tandrii | 221ab25 | 2016-10-06 08:12:04 -0700 | [diff] [blame] | 581 | hostname=buildbucket_host, |
tandrii@chromium.org | b015fac | 2016-02-26 14:52:01 +0000 | [diff] [blame] | 582 | params=urllib.urlencode(params)) |
qyearsley | eab3c04 | 2016-08-24 09:18:28 -0700 | [diff] [blame] | 583 | content = _buildbucket_retry('fetching try jobs', http, url, 'GET') |
tandrii@chromium.org | b015fac | 2016-02-26 14:52:01 +0000 | [diff] [blame] | 584 | for build in content.get('builds', []): |
| 585 | builds[build['id']] = build |
| 586 | if 'next_cursor' in content: |
| 587 | params['start_cursor'] = content['next_cursor'] |
| 588 | else: |
| 589 | break |
| 590 | return builds |
| 591 | |
| 592 | |
qyearsley | eab3c04 | 2016-08-24 09:18:28 -0700 | [diff] [blame] | 593 | def print_try_jobs(options, builds): |
tandrii@chromium.org | b015fac | 2016-02-26 14:52:01 +0000 | [diff] [blame] | 594 | """Prints nicely result of fetch_try_jobs.""" |
| 595 | if not builds: |
Quinten Yearsley | 0c62da9 | 2017-05-31 13:39:42 -0700 | [diff] [blame] | 596 | print('No try jobs scheduled.') |
tandrii@chromium.org | b015fac | 2016-02-26 14:52:01 +0000 | [diff] [blame] | 597 | return |
| 598 | |
| 599 | # Make a copy, because we'll be modifying builds dictionary. |
| 600 | builds = builds.copy() |
| 601 | builder_names_cache = {} |
| 602 | |
| 603 | def get_builder(b): |
| 604 | try: |
| 605 | return builder_names_cache[b['id']] |
| 606 | except KeyError: |
| 607 | try: |
| 608 | parameters = json.loads(b['parameters_json']) |
| 609 | name = parameters['builder_name'] |
| 610 | except (ValueError, KeyError) as error: |
Quinten Yearsley | 0c62da9 | 2017-05-31 13:39:42 -0700 | [diff] [blame] | 611 | print('WARNING: Failed to get builder name for build %s: %s' % ( |
vapier | a7fbd5a | 2016-06-16 09:17:49 -0700 | [diff] [blame] | 612 | b['id'], error)) |
tandrii@chromium.org | b015fac | 2016-02-26 14:52:01 +0000 | [diff] [blame] | 613 | name = None |
| 614 | builder_names_cache[b['id']] = name |
| 615 | return name |
| 616 | |
| 617 | def get_bucket(b): |
| 618 | bucket = b['bucket'] |
| 619 | if bucket.startswith('master.'): |
| 620 | return bucket[len('master.'):] |
| 621 | return bucket |
| 622 | |
| 623 | if options.print_master: |
| 624 | name_fmt = '%%-%ds %%-%ds' % ( |
| 625 | max(len(str(get_bucket(b))) for b in builds.itervalues()), |
| 626 | max(len(str(get_builder(b))) for b in builds.itervalues())) |
| 627 | def get_name(b): |
| 628 | return name_fmt % (get_bucket(b), get_builder(b)) |
| 629 | else: |
| 630 | name_fmt = '%%-%ds' % ( |
| 631 | max(len(str(get_builder(b))) for b in builds.itervalues())) |
| 632 | def get_name(b): |
| 633 | return name_fmt % get_builder(b) |
| 634 | |
| 635 | def sort_key(b): |
| 636 | return b['status'], b.get('result'), get_name(b), b.get('url') |
| 637 | |
| 638 | def pop(title, f, color=None, **kwargs): |
| 639 | """Pop matching builds from `builds` dict and print them.""" |
| 640 | |
tandrii@chromium.org | 6cf98c8 | 2016-03-15 11:56:00 +0000 | [diff] [blame] | 641 | if not options.color or color is None: |
tandrii@chromium.org | b015fac | 2016-02-26 14:52:01 +0000 | [diff] [blame] | 642 | colorize = str |
| 643 | else: |
| 644 | colorize = lambda x: '%s%s%s' % (color, x, Fore.RESET) |
| 645 | |
| 646 | result = [] |
| 647 | for b in builds.values(): |
| 648 | if all(b.get(k) == v for k, v in kwargs.iteritems()): |
| 649 | builds.pop(b['id']) |
| 650 | result.append(b) |
| 651 | if result: |
vapier | a7fbd5a | 2016-06-16 09:17:49 -0700 | [diff] [blame] | 652 | print(colorize(title)) |
tandrii@chromium.org | b015fac | 2016-02-26 14:52:01 +0000 | [diff] [blame] | 653 | for b in sorted(result, key=sort_key): |
vapier | a7fbd5a | 2016-06-16 09:17:49 -0700 | [diff] [blame] | 654 | print(' ', colorize('\t'.join(map(str, f(b))))) |
tandrii@chromium.org | b015fac | 2016-02-26 14:52:01 +0000 | [diff] [blame] | 655 | |
| 656 | total = len(builds) |
| 657 | pop(status='COMPLETED', result='SUCCESS', |
| 658 | title='Successes:', color=Fore.GREEN, |
| 659 | f=lambda b: (get_name(b), b.get('url'))) |
| 660 | pop(status='COMPLETED', result='FAILURE', failure_reason='INFRA_FAILURE', |
| 661 | title='Infra Failures:', color=Fore.MAGENTA, |
| 662 | f=lambda b: (get_name(b), b.get('url'))) |
| 663 | pop(status='COMPLETED', result='FAILURE', failure_reason='BUILD_FAILURE', |
| 664 | title='Failures:', color=Fore.RED, |
| 665 | f=lambda b: (get_name(b), b.get('url'))) |
| 666 | pop(status='COMPLETED', result='CANCELED', |
| 667 | title='Canceled:', color=Fore.MAGENTA, |
| 668 | f=lambda b: (get_name(b),)) |
| 669 | pop(status='COMPLETED', result='FAILURE', |
| 670 | failure_reason='INVALID_BUILD_DEFINITION', |
| 671 | title='Wrong master/builder name:', color=Fore.MAGENTA, |
| 672 | f=lambda b: (get_name(b),)) |
| 673 | pop(status='COMPLETED', result='FAILURE', |
| 674 | title='Other failures:', |
| 675 | f=lambda b: (get_name(b), b.get('failure_reason'), b.get('url'))) |
| 676 | pop(status='COMPLETED', |
| 677 | title='Other finished:', |
| 678 | f=lambda b: (get_name(b), b.get('result'), b.get('url'))) |
| 679 | pop(status='STARTED', |
| 680 | title='Started:', color=Fore.YELLOW, |
| 681 | f=lambda b: (get_name(b), b.get('url'))) |
| 682 | pop(status='SCHEDULED', |
| 683 | title='Scheduled:', |
| 684 | f=lambda b: (get_name(b), 'id=%s' % b['id'])) |
| 685 | # The last section is just in case buildbucket API changes OR there is a bug. |
| 686 | pop(title='Other:', |
| 687 | f=lambda b: (get_name(b), 'id=%s' % b['id'])) |
| 688 | assert len(builds) == 0 |
qyearsley | eab3c04 | 2016-08-24 09:18:28 -0700 | [diff] [blame] | 689 | print('Total: %d try jobs' % total) |
tandrii@chromium.org | b015fac | 2016-02-26 14:52:01 +0000 | [diff] [blame] | 690 | |
| 691 | |
Aiden Benner | c08566e | 2018-10-03 17:52:42 +0000 | [diff] [blame] | 692 | def _ComputeDiffLineRanges(files, upstream_commit): |
| 693 | """Gets the changed line ranges for each file since upstream_commit. |
| 694 | |
| 695 | Parses a git diff on provided files and returns a dict that maps a file name |
| 696 | to an ordered list of range tuples in the form (start_line, count). |
| 697 | Ranges are in the same format as a git diff. |
| 698 | """ |
| 699 | # If files is empty then diff_output will be a full diff. |
| 700 | if len(files) == 0: |
| 701 | return {} |
| 702 | |
Aiden Benner | 6c18a1a | 2018-11-23 20:18:23 +0000 | [diff] [blame] | 703 | # Take the git diff and find the line ranges where there are changes. |
Aiden Benner | c08566e | 2018-10-03 17:52:42 +0000 | [diff] [blame] | 704 | diff_cmd = BuildGitDiffCmd('-U0', upstream_commit, files, allow_prefix=True) |
| 705 | diff_output = RunGit(diff_cmd) |
| 706 | |
| 707 | pattern = r'(?:^diff --git a/(?:.*) b/(.*))|(?:^@@.*\+(.*) @@)' |
| 708 | # 2 capture groups |
| 709 | # 0 == fname of diff file |
| 710 | # 1 == 'diff_start,diff_count' or 'diff_start' |
| 711 | # will match each of |
| 712 | # diff --git a/foo.foo b/foo.py |
| 713 | # @@ -12,2 +14,3 @@ |
| 714 | # @@ -12,2 +17 @@ |
| 715 | # running re.findall on the above string with pattern will give |
| 716 | # [('foo.py', ''), ('', '14,3'), ('', '17')] |
| 717 | |
| 718 | curr_file = None |
| 719 | line_diffs = {} |
| 720 | for match in re.findall(pattern, diff_output, flags=re.MULTILINE): |
| 721 | if match[0] != '': |
| 722 | # Will match the second filename in diff --git a/a.py b/b.py. |
| 723 | curr_file = match[0] |
| 724 | line_diffs[curr_file] = [] |
| 725 | else: |
| 726 | # Matches +14,3 |
| 727 | if ',' in match[1]: |
| 728 | diff_start, diff_count = match[1].split(',') |
| 729 | else: |
| 730 | # Single line changes are of the form +12 instead of +12,1. |
| 731 | diff_start = match[1] |
| 732 | diff_count = 1 |
| 733 | |
| 734 | diff_start = int(diff_start) |
| 735 | diff_count = int(diff_count) |
| 736 | |
| 737 | # If diff_count == 0 this is a removal we can ignore. |
| 738 | line_diffs[curr_file].append((diff_start, diff_count)) |
| 739 | |
| 740 | return line_diffs |
| 741 | |
| 742 | |
Aiden Benner | 99b0ccb | 2018-11-20 19:53:31 +0000 | [diff] [blame] | 743 | def _FindYapfConfigFile(fpath, yapf_config_cache, top_dir=None): |
Aiden Benner | c08566e | 2018-10-03 17:52:42 +0000 | [diff] [blame] | 744 | """Checks if a yapf file is in any parent directory of fpath until top_dir. |
| 745 | |
Aiden Benner | 99b0ccb | 2018-11-20 19:53:31 +0000 | [diff] [blame] | 746 | Recursively checks parent directories to find yapf file and if no yapf file |
| 747 | is found returns None. Uses yapf_config_cache as a cache for |
| 748 | previously found configs. |
Aiden Benner | c08566e | 2018-10-03 17:52:42 +0000 | [diff] [blame] | 749 | """ |
Aiden Benner | 99b0ccb | 2018-11-20 19:53:31 +0000 | [diff] [blame] | 750 | fpath = os.path.abspath(fpath) |
Aiden Benner | c08566e | 2018-10-03 17:52:42 +0000 | [diff] [blame] | 751 | # Return result if we've already computed it. |
| 752 | if fpath in yapf_config_cache: |
| 753 | return yapf_config_cache[fpath] |
| 754 | |
Aiden Benner | 99b0ccb | 2018-11-20 19:53:31 +0000 | [diff] [blame] | 755 | parent_dir = os.path.dirname(fpath) |
| 756 | if os.path.isfile(fpath): |
| 757 | ret = _FindYapfConfigFile(parent_dir, yapf_config_cache, top_dir) |
Aiden Benner | c08566e | 2018-10-03 17:52:42 +0000 | [diff] [blame] | 758 | else: |
Aiden Benner | 99b0ccb | 2018-11-20 19:53:31 +0000 | [diff] [blame] | 759 | # Otherwise fpath is a directory |
| 760 | yapf_file = os.path.join(fpath, YAPF_CONFIG_FILENAME) |
| 761 | if os.path.isfile(yapf_file): |
| 762 | ret = yapf_file |
| 763 | elif fpath == top_dir or parent_dir == fpath: |
| 764 | # If we're at the top level directory, or if we're at root |
| 765 | # there is no provided style. |
| 766 | ret = None |
| 767 | else: |
| 768 | # Otherwise recurse on the current directory. |
| 769 | ret = _FindYapfConfigFile(parent_dir, yapf_config_cache, top_dir) |
Aiden Benner | c08566e | 2018-10-03 17:52:42 +0000 | [diff] [blame] | 770 | yapf_config_cache[fpath] = ret |
| 771 | return ret |
| 772 | |
| 773 | |
qyearsley | 53f48a1 | 2016-09-01 10:45:13 -0700 | [diff] [blame] | 774 | def write_try_results_json(output_file, builds): |
| 775 | """Writes a subset of the data from fetch_try_jobs to a file as JSON. |
| 776 | |
| 777 | The input |builds| dict is assumed to be generated by Buildbucket. |
| 778 | Buildbucket documentation: http://goo.gl/G0s101 |
| 779 | """ |
| 780 | |
| 781 | def convert_build_dict(build): |
Quinten Yearsley | a563d72 | 2017-12-11 16:36:54 -0800 | [diff] [blame] | 782 | """Extracts some of the information from one build dict.""" |
| 783 | parameters = json.loads(build.get('parameters_json', '{}')) or {} |
qyearsley | 53f48a1 | 2016-09-01 10:45:13 -0700 | [diff] [blame] | 784 | return { |
| 785 | 'buildbucket_id': build.get('id'), |
qyearsley | 53f48a1 | 2016-09-01 10:45:13 -0700 | [diff] [blame] | 786 | 'bucket': build.get('bucket'), |
Quinten Yearsley | a563d72 | 2017-12-11 16:36:54 -0800 | [diff] [blame] | 787 | 'builder_name': parameters.get('builder_name'), |
| 788 | 'created_ts': build.get('created_ts'), |
| 789 | 'experimental': build.get('experimental'), |
qyearsley | 53f48a1 | 2016-09-01 10:45:13 -0700 | [diff] [blame] | 790 | 'failure_reason': build.get('failure_reason'), |
Quinten Yearsley | a563d72 | 2017-12-11 16:36:54 -0800 | [diff] [blame] | 791 | 'result': build.get('result'), |
| 792 | 'status': build.get('status'), |
| 793 | 'tags': build.get('tags'), |
qyearsley | 53f48a1 | 2016-09-01 10:45:13 -0700 | [diff] [blame] | 794 | 'url': build.get('url'), |
| 795 | } |
| 796 | |
| 797 | converted = [] |
| 798 | for _, build in sorted(builds.items()): |
Aiden Benner | c08566e | 2018-10-03 17:52:42 +0000 | [diff] [blame] | 799 | converted.append(convert_build_dict(build)) |
qyearsley | 53f48a1 | 2016-09-01 10:45:13 -0700 | [diff] [blame] | 800 | write_json(output_file, converted) |
| 801 | |
| 802 | |
Aaron Gable | 13101a6 | 2018-02-09 13:20:41 -0800 | [diff] [blame] | 803 | def print_stats(args): |
maruel@chromium.org | 49e3d80 | 2012-07-18 23:54:45 +0000 | [diff] [blame] | 804 | """Prints statistics about the change to the user.""" |
| 805 | # --no-ext-diff is broken in some versions of Git, so try to work around |
| 806 | # this by overriding the environment (but there is still a problem if the |
| 807 | # git config key "diff.external" is used). |
thestig@chromium.org | 8b0553c | 2014-02-11 00:33:37 +0000 | [diff] [blame] | 808 | env = GetNoGitPagerEnv() |
maruel@chromium.org | 49e3d80 | 2012-07-18 23:54:45 +0000 | [diff] [blame] | 809 | if 'GIT_EXTERNAL_DIFF' in env: |
| 810 | del env['GIT_EXTERNAL_DIFF'] |
iannucci@chromium.org | 7954005 | 2012-10-19 23:15:26 +0000 | [diff] [blame] | 811 | |
szager@chromium.org | d057f9a | 2014-05-29 21:09:36 +0000 | [diff] [blame] | 812 | try: |
| 813 | stdout = sys.stdout.fileno() |
| 814 | except AttributeError: |
| 815 | stdout = None |
maruel@chromium.org | 49e3d80 | 2012-07-18 23:54:45 +0000 | [diff] [blame] | 816 | return subprocess2.call( |
Aaron Gable | 13101a6 | 2018-02-09 13:20:41 -0800 | [diff] [blame] | 817 | ['git', 'diff', '--no-ext-diff', '--stat', '-l100000', '-C50'] + args, |
szager@chromium.org | d057f9a | 2014-05-29 21:09:36 +0000 | [diff] [blame] | 818 | stdout=stdout, env=env) |
maruel@chromium.org | 49e3d80 | 2012-07-18 23:54:45 +0000 | [diff] [blame] | 819 | |
| 820 | |
sheyang@google.com | 6ebaf78 | 2015-05-12 19:17:54 +0000 | [diff] [blame] | 821 | class BuildbucketResponseException(Exception): |
| 822 | pass |
| 823 | |
| 824 | |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 825 | class Settings(object): |
| 826 | def __init__(self): |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 827 | self.cc = None |
thestig@chromium.org | 7a54e81 | 2014-02-11 19:57:22 +0000 | [diff] [blame] | 828 | self.root = None |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 829 | self.tree_status_url = None |
| 830 | self.viewvc_url = None |
| 831 | self.updated = False |
ukai@chromium.org | e807781 | 2012-02-03 03:41:46 +0000 | [diff] [blame] | 832 | self.is_gerrit = None |
bauerb@chromium.org | 54b400c | 2016-01-14 10:08:25 +0000 | [diff] [blame] | 833 | self.squash_gerrit_uploads = None |
tandrii@chromium.org | 2825353 | 2016-04-14 13:46:56 +0000 | [diff] [blame] | 834 | self.gerrit_skip_ensure_authenticated = None |
jbroman@chromium.org | 615a262 | 2013-05-03 13:20:14 +0000 | [diff] [blame] | 835 | self.git_editor = None |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 836 | |
| 837 | def LazyUpdateIfNeeded(self): |
| 838 | """Updates the settings from a codereview.settings file, if available.""" |
| 839 | if not self.updated: |
pgervais@chromium.org | 87884cc | 2014-01-03 22:23:41 +0000 | [diff] [blame] | 840 | # The only value that actually changes the behavior is |
| 841 | # autoupdate = "false". Everything else means "true". |
nick@chromium.org | 3ac1c4e | 2014-01-16 02:44:42 +0000 | [diff] [blame] | 842 | autoupdate = RunGit(['config', 'rietveld.autoupdate'], |
pgervais@chromium.org | 87884cc | 2014-01-03 22:23:41 +0000 | [diff] [blame] | 843 | error_ok=True |
| 844 | ).strip().lower() |
| 845 | |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 846 | cr_settings_file = FindCodereviewSettingsFile() |
pgervais@chromium.org | 87884cc | 2014-01-03 22:23:41 +0000 | [diff] [blame] | 847 | if autoupdate != 'false' and cr_settings_file: |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 848 | LoadCodereviewSettingsFromFile(cr_settings_file) |
| 849 | self.updated = True |
| 850 | |
thestig@chromium.org | 7a54e81 | 2014-02-11 19:57:22 +0000 | [diff] [blame] | 851 | @staticmethod |
| 852 | def GetRelativeRoot(): |
| 853 | return RunGit(['rev-parse', '--show-cdup']).strip() |
thestig@chromium.org | 8b0553c | 2014-02-11 00:33:37 +0000 | [diff] [blame] | 854 | |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 855 | def GetRoot(self): |
thestig@chromium.org | 7a54e81 | 2014-02-11 19:57:22 +0000 | [diff] [blame] | 856 | if self.root is None: |
| 857 | self.root = os.path.abspath(self.GetRelativeRoot()) |
| 858 | return self.root |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 859 | |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 860 | def GetTreeStatusUrl(self, error_ok=False): |
| 861 | if not self.tree_status_url: |
| 862 | error_message = ('You must configure your tree status URL by running ' |
| 863 | '"git cl config".') |
Edward Lemur | 61ea307 | 2018-12-01 00:34:36 +0000 | [diff] [blame] | 864 | self.tree_status_url = self._GetConfig( |
| 865 | 'rietveld.tree-status-url', error_ok=error_ok, |
| 866 | error_message=error_message) |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 867 | return self.tree_status_url |
| 868 | |
| 869 | def GetViewVCUrl(self): |
| 870 | if not self.viewvc_url: |
Edward Lemur | 61ea307 | 2018-12-01 00:34:36 +0000 | [diff] [blame] | 871 | self.viewvc_url = self._GetConfig('rietveld.viewvc-url', error_ok=True) |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 872 | return self.viewvc_url |
| 873 | |
rmistry@google.com | 9075258 | 2014-01-14 21:04:50 +0000 | [diff] [blame] | 874 | def GetBugPrefix(self): |
Edward Lemur | 61ea307 | 2018-12-01 00:34:36 +0000 | [diff] [blame] | 875 | return self._GetConfig('rietveld.bug-prefix', error_ok=True) |
rmistry@google.com | 78948ed | 2015-07-08 23:09:57 +0000 | [diff] [blame] | 876 | |
rmistry@google.com | 5626a92 | 2015-02-26 14:03:30 +0000 | [diff] [blame] | 877 | def GetRunPostUploadHook(self): |
Edward Lemur | 61ea307 | 2018-12-01 00:34:36 +0000 | [diff] [blame] | 878 | run_post_upload_hook = self._GetConfig( |
| 879 | 'rietveld.run-post-upload-hook', error_ok=True) |
rmistry@google.com | 5626a92 | 2015-02-26 14:03:30 +0000 | [diff] [blame] | 880 | return run_post_upload_hook == "True" |
| 881 | |
bauerb@chromium.org | ae6df35 | 2011-04-06 17:40:39 +0000 | [diff] [blame] | 882 | def GetDefaultCCList(self): |
Edward Lemur | 61ea307 | 2018-12-01 00:34:36 +0000 | [diff] [blame] | 883 | return self._GetConfig('rietveld.cc', error_ok=True) |
tyoshino@chromium.org | c1737d0 | 2013-05-29 14:17:28 +0000 | [diff] [blame] | 884 | |
ukai@chromium.org | e807781 | 2012-02-03 03:41:46 +0000 | [diff] [blame] | 885 | def GetIsGerrit(self): |
Quinten Yearsley | 0c62da9 | 2017-05-31 13:39:42 -0700 | [diff] [blame] | 886 | """Return true if this repo is associated with gerrit code review system.""" |
ukai@chromium.org | e807781 | 2012-02-03 03:41:46 +0000 | [diff] [blame] | 887 | if self.is_gerrit is None: |
Aaron Gable | 9b46527 | 2017-05-12 10:53:51 -0700 | [diff] [blame] | 888 | self.is_gerrit = ( |
| 889 | self._GetConfig('gerrit.host', error_ok=True).lower() == 'true') |
ukai@chromium.org | e807781 | 2012-02-03 03:41:46 +0000 | [diff] [blame] | 890 | return self.is_gerrit |
| 891 | |
bauerb@chromium.org | 54b400c | 2016-01-14 10:08:25 +0000 | [diff] [blame] | 892 | def GetSquashGerritUploads(self): |
| 893 | """Return true if uploads to Gerrit should be squashed by default.""" |
| 894 | if self.squash_gerrit_uploads is None: |
tandrii | a60502f | 2016-06-20 02:01:53 -0700 | [diff] [blame] | 895 | self.squash_gerrit_uploads = self.GetSquashGerritUploadsOverride() |
| 896 | if self.squash_gerrit_uploads is None: |
| 897 | # Default is squash now (http://crbug.com/611892#c23). |
| 898 | self.squash_gerrit_uploads = not ( |
| 899 | RunGit(['config', '--bool', 'gerrit.squash-uploads'], |
| 900 | error_ok=True).strip() == 'false') |
bauerb@chromium.org | 54b400c | 2016-01-14 10:08:25 +0000 | [diff] [blame] | 901 | return self.squash_gerrit_uploads |
| 902 | |
tandrii | a60502f | 2016-06-20 02:01:53 -0700 | [diff] [blame] | 903 | def GetSquashGerritUploadsOverride(self): |
| 904 | """Return True or False if codereview.settings should be overridden. |
| 905 | |
| 906 | Returns None if no override has been defined. |
| 907 | """ |
| 908 | # See also http://crbug.com/611892#c23 |
| 909 | result = RunGit(['config', '--bool', 'gerrit.override-squash-uploads'], |
| 910 | error_ok=True).strip() |
| 911 | if result == 'true': |
| 912 | return True |
| 913 | if result == 'false': |
| 914 | return False |
| 915 | return None |
| 916 | |
tandrii@chromium.org | 2825353 | 2016-04-14 13:46:56 +0000 | [diff] [blame] | 917 | def GetGerritSkipEnsureAuthenticated(self): |
| 918 | """Return True if EnsureAuthenticated should not be done for Gerrit |
| 919 | uploads.""" |
| 920 | if self.gerrit_skip_ensure_authenticated is None: |
| 921 | self.gerrit_skip_ensure_authenticated = ( |
shinyak@chromium.org | 00dbccd | 2016-04-15 07:24:43 +0000 | [diff] [blame] | 922 | RunGit(['config', '--bool', 'gerrit.skip-ensure-authenticated'], |
tandrii@chromium.org | 2825353 | 2016-04-14 13:46:56 +0000 | [diff] [blame] | 923 | error_ok=True).strip() == 'true') |
| 924 | return self.gerrit_skip_ensure_authenticated |
| 925 | |
jbroman@chromium.org | 615a262 | 2013-05-03 13:20:14 +0000 | [diff] [blame] | 926 | def GetGitEditor(self): |
| 927 | """Return the editor specified in the git config, or None if none is.""" |
| 928 | if self.git_editor is None: |
Raul Tambre | 5a52587 | 2019-02-12 19:08:08 +0000 | [diff] [blame] | 929 | # Git requires single quotes for paths with spaces. We need to replace |
| 930 | # them with double quotes for Windows to treat such paths as a single |
| 931 | # path. |
| 932 | self.git_editor = self._GetConfig( |
| 933 | 'core.editor', error_ok=True).replace('\'', '"') |
jbroman@chromium.org | 615a262 | 2013-05-03 13:20:14 +0000 | [diff] [blame] | 934 | return self.git_editor or None |
| 935 | |
thestig@chromium.org | 44202a2 | 2014-03-11 19:22:18 +0000 | [diff] [blame] | 936 | def GetLintRegex(self): |
Edward Lemur | 61ea307 | 2018-12-01 00:34:36 +0000 | [diff] [blame] | 937 | return (self._GetConfig('rietveld.cpplint-regex', error_ok=True) or |
thestig@chromium.org | 44202a2 | 2014-03-11 19:22:18 +0000 | [diff] [blame] | 938 | DEFAULT_LINT_REGEX) |
| 939 | |
| 940 | def GetLintIgnoreRegex(self): |
Edward Lemur | 61ea307 | 2018-12-01 00:34:36 +0000 | [diff] [blame] | 941 | return (self._GetConfig('rietveld.cpplint-ignore-regex', error_ok=True) or |
thestig@chromium.org | 44202a2 | 2014-03-11 19:22:18 +0000 | [diff] [blame] | 942 | DEFAULT_LINT_IGNORE_REGEX) |
| 943 | |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 944 | def _GetConfig(self, param, **kwargs): |
| 945 | self.LazyUpdateIfNeeded() |
| 946 | return RunGit(['config', param], **kwargs).strip() |
| 947 | |
| 948 | |
Andrii Shyshkalov | f3a20ae | 2017-01-24 21:23:57 +0100 | [diff] [blame] | 949 | @contextlib.contextmanager |
| 950 | def _get_gerrit_project_config_file(remote_url): |
| 951 | """Context manager to fetch and store Gerrit's project.config from |
| 952 | refs/meta/config branch and store it in temp file. |
| 953 | |
| 954 | Provides a temporary filename or None if there was error. |
| 955 | """ |
| 956 | error, _ = RunGitWithCode([ |
| 957 | 'fetch', remote_url, |
| 958 | '+refs/meta/config:refs/git_cl/meta/config']) |
| 959 | if error: |
| 960 | # Ref doesn't exist or isn't accessible to current user. |
Quinten Yearsley | 0c62da9 | 2017-05-31 13:39:42 -0700 | [diff] [blame] | 961 | print('WARNING: Failed to fetch project config for %s: %s' % |
Andrii Shyshkalov | f3a20ae | 2017-01-24 21:23:57 +0100 | [diff] [blame] | 962 | (remote_url, error)) |
| 963 | yield None |
| 964 | return |
| 965 | |
| 966 | error, project_config_data = RunGitWithCode( |
| 967 | ['show', 'refs/git_cl/meta/config:project.config']) |
| 968 | if error: |
| 969 | print('WARNING: project.config file not found') |
| 970 | yield None |
| 971 | return |
| 972 | |
| 973 | with gclient_utils.temporary_directory() as tempdir: |
| 974 | project_config_file = os.path.join(tempdir, 'project.config') |
| 975 | gclient_utils.FileWrite(project_config_file, project_config_data) |
| 976 | yield project_config_file |
| 977 | |
| 978 | |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 979 | def ShortBranchName(branch): |
| 980 | """Convert a name like 'refs/heads/foo' to just 'foo'.""" |
tandrii@chromium.org | aa5ced1 | 2016-03-29 09:41:14 +0000 | [diff] [blame] | 981 | return branch.replace('refs/heads/', '', 1) |
| 982 | |
| 983 | |
| 984 | def GetCurrentBranchRef(): |
| 985 | """Returns branch ref (e.g., refs/heads/master) or None.""" |
| 986 | return RunGit(['symbolic-ref', 'HEAD'], |
| 987 | stderr=subprocess2.VOID, error_ok=True).strip() or None |
| 988 | |
| 989 | |
| 990 | def GetCurrentBranch(): |
| 991 | """Returns current branch or None. |
| 992 | |
| 993 | For refs/heads/* branches, returns just last part. For others, full ref. |
| 994 | """ |
| 995 | branchref = GetCurrentBranchRef() |
| 996 | if branchref: |
| 997 | return ShortBranchName(branchref) |
| 998 | return None |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 999 | |
| 1000 | |
tandrii@chromium.org | fa330e8 | 2016-04-13 17:09:52 +0000 | [diff] [blame] | 1001 | class _CQState(object): |
| 1002 | """Enum for states of CL with respect to Commit Queue.""" |
| 1003 | NONE = 'none' |
| 1004 | DRY_RUN = 'dry_run' |
| 1005 | COMMIT = 'commit' |
| 1006 | |
| 1007 | ALL_STATES = [NONE, DRY_RUN, COMMIT] |
| 1008 | |
| 1009 | |
tandrii@chromium.org | f86c7d3 | 2016-04-01 19:27:30 +0000 | [diff] [blame] | 1010 | class _ParsedIssueNumberArgument(object): |
Andrii Shyshkalov | 90f3192 | 2017-04-10 16:10:21 +0200 | [diff] [blame] | 1011 | def __init__(self, issue=None, patchset=None, hostname=None, codereview=None): |
tandrii@chromium.org | f86c7d3 | 2016-04-01 19:27:30 +0000 | [diff] [blame] | 1012 | self.issue = issue |
| 1013 | self.patchset = patchset |
| 1014 | self.hostname = hostname |
Andrii Shyshkalov | f5569d2 | 2018-10-15 03:35:23 +0000 | [diff] [blame] | 1015 | assert codereview in (None, 'gerrit', 'rietveld') |
Andrii Shyshkalov | 90f3192 | 2017-04-10 16:10:21 +0200 | [diff] [blame] | 1016 | self.codereview = codereview |
tandrii@chromium.org | f86c7d3 | 2016-04-01 19:27:30 +0000 | [diff] [blame] | 1017 | |
| 1018 | @property |
| 1019 | def valid(self): |
| 1020 | return self.issue is not None |
| 1021 | |
| 1022 | |
Andrii Shyshkalov | c971239 | 2017-04-11 13:35:21 +0200 | [diff] [blame] | 1023 | def ParseIssueNumberArgument(arg, codereview=None): |
tandrii@chromium.org | f86c7d3 | 2016-04-01 19:27:30 +0000 | [diff] [blame] | 1024 | """Parses the issue argument and returns _ParsedIssueNumberArgument.""" |
| 1025 | fail_result = _ParsedIssueNumberArgument() |
| 1026 | |
| 1027 | if arg.isdigit(): |
Aaron Gable | aee6c85 | 2017-06-26 12:49:01 -0700 | [diff] [blame] | 1028 | return _ParsedIssueNumberArgument(issue=int(arg), codereview=codereview) |
tandrii@chromium.org | f86c7d3 | 2016-04-01 19:27:30 +0000 | [diff] [blame] | 1029 | if not arg.startswith('http'): |
| 1030 | return fail_result |
Aaron Gable | aee6c85 | 2017-06-26 12:49:01 -0700 | [diff] [blame] | 1031 | |
tandrii@chromium.org | f86c7d3 | 2016-04-01 19:27:30 +0000 | [diff] [blame] | 1032 | url = gclient_utils.UpgradeToHttps(arg) |
| 1033 | try: |
| 1034 | parsed_url = urlparse.urlparse(url) |
| 1035 | except ValueError: |
| 1036 | return fail_result |
Andrii Shyshkalov | 28d840e | 2017-04-10 15:45:09 +0200 | [diff] [blame] | 1037 | |
Andrii Shyshkalov | c971239 | 2017-04-11 13:35:21 +0200 | [diff] [blame] | 1038 | if codereview is not None: |
| 1039 | parsed = _CODEREVIEW_IMPLEMENTATIONS[codereview].ParseIssueURL(parsed_url) |
| 1040 | return parsed or fail_result |
| 1041 | |
Andrii Shyshkalov | 0a264d8 | 2018-11-21 00:36:16 +0000 | [diff] [blame] | 1042 | return _GerritChangelistImpl.ParseIssueURL(parsed_url) or fail_result |
tandrii@chromium.org | f86c7d3 | 2016-04-01 19:27:30 +0000 | [diff] [blame] | 1043 | |
| 1044 | |
Andrii Shyshkalov | b07575f | 2018-10-16 06:16:21 +0000 | [diff] [blame] | 1045 | def _create_description_from_log(args): |
| 1046 | """Pulls out the commit log to use as a base for the CL description.""" |
| 1047 | log_args = [] |
| 1048 | if len(args) == 1 and not args[0].endswith('.'): |
| 1049 | log_args = [args[0] + '..'] |
| 1050 | elif len(args) == 1 and args[0].endswith('...'): |
| 1051 | log_args = [args[0][:-1]] |
| 1052 | elif len(args) == 2: |
| 1053 | log_args = [args[0] + '..' + args[1]] |
| 1054 | else: |
| 1055 | log_args = args[:] # Hope for the best! |
| 1056 | return RunGit(['log', '--pretty=format:%s\n\n%b'] + log_args) |
| 1057 | |
| 1058 | |
Aaron Gable | a45ee11 | 2016-11-22 15:14:38 -0800 | [diff] [blame] | 1059 | class GerritChangeNotExists(Exception): |
tandrii | c2405f5 | 2016-10-10 08:13:15 -0700 | [diff] [blame] | 1060 | def __init__(self, issue, url): |
| 1061 | self.issue = issue |
| 1062 | self.url = url |
Aaron Gable | a45ee11 | 2016-11-22 15:14:38 -0800 | [diff] [blame] | 1063 | super(GerritChangeNotExists, self).__init__() |
tandrii | c2405f5 | 2016-10-10 08:13:15 -0700 | [diff] [blame] | 1064 | |
| 1065 | def __str__(self): |
Aaron Gable | a45ee11 | 2016-11-22 15:14:38 -0800 | [diff] [blame] | 1066 | return 'change %s at %s does not exist or you have no access to it' % ( |
tandrii | c2405f5 | 2016-10-10 08:13:15 -0700 | [diff] [blame] | 1067 | self.issue, self.url) |
| 1068 | |
| 1069 | |
Andrii Shyshkalov | d8aa49f | 2017-03-17 16:05:49 +0100 | [diff] [blame] | 1070 | _CommentSummary = collections.namedtuple( |
Quinten Yearsley | 0e617c0 | 2019-02-20 00:37:03 +0000 | [diff] [blame] | 1071 | '_CommentSummary', ['date', 'message', 'sender', 'autogenerated', |
Andrii Shyshkalov | d8aa49f | 2017-03-17 16:05:49 +0100 | [diff] [blame] | 1072 | # TODO(tandrii): these two aren't known in Gerrit. |
| 1073 | 'approval', 'disapproval']) |
| 1074 | |
| 1075 | |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 1076 | class Changelist(object): |
tandrii@chromium.org | aa5ced1 | 2016-03-29 09:41:14 +0000 | [diff] [blame] | 1077 | """Changelist works with one changelist in local branch. |
| 1078 | |
| 1079 | Supports two codereview backends: Rietveld or Gerrit, selected at object |
| 1080 | creation. |
| 1081 | |
tandrii@chromium.org | 8930b3d | 2016-04-13 14:47:02 +0000 | [diff] [blame] | 1082 | Notes: |
| 1083 | * Not safe for concurrent multi-{thread,process} use. |
| 1084 | * Caches values from current branch. Therefore, re-use after branch change |
tandrii | 5d48c32 | 2016-08-18 16:19:37 -0700 | [diff] [blame] | 1085 | with great care. |
tandrii@chromium.org | aa5ced1 | 2016-03-29 09:41:14 +0000 | [diff] [blame] | 1086 | """ |
| 1087 | |
| 1088 | def __init__(self, branchref=None, issue=None, codereview=None, **kwargs): |
| 1089 | """Create a new ChangeList instance. |
| 1090 | |
| 1091 | If issue is given, the codereview must be given too. |
| 1092 | |
| 1093 | If `codereview` is given, it must be 'rietveld' or 'gerrit'. |
| 1094 | Otherwise, it's decided based on current configuration of the local branch, |
| 1095 | with default being 'rietveld' for backwards compatibility. |
| 1096 | See _load_codereview_impl for more details. |
| 1097 | |
| 1098 | **kwargs will be passed directly to codereview implementation. |
| 1099 | """ |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 1100 | # Poke settings so we get the "configure your server" message if necessary. |
maruel@chromium.org | 379d07a | 2011-11-30 14:58:10 +0000 | [diff] [blame] | 1101 | global settings |
| 1102 | if not settings: |
| 1103 | # Happens when git_cl.py is used as a utility library. |
| 1104 | settings = Settings() |
tandrii@chromium.org | aa5ced1 | 2016-03-29 09:41:14 +0000 | [diff] [blame] | 1105 | |
| 1106 | if issue: |
| 1107 | assert codereview, 'codereview must be known, if issue is known' |
| 1108 | |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 1109 | self.branchref = branchref |
| 1110 | if self.branchref: |
clemensh@chromium.org | cbd7dc3 | 2016-05-31 10:33:50 +0000 | [diff] [blame] | 1111 | assert branchref.startswith('refs/heads/') |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 1112 | self.branch = ShortBranchName(self.branchref) |
| 1113 | else: |
| 1114 | self.branch = None |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 1115 | self.upstream_branch = None |
maruel@chromium.org | 1033efd | 2013-07-23 23:25:09 +0000 | [diff] [blame] | 1116 | self.lookedup_issue = False |
| 1117 | self.issue = issue or None |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 1118 | self.has_description = False |
| 1119 | self.description = None |
maruel@chromium.org | 1033efd | 2013-07-23 23:25:09 +0000 | [diff] [blame] | 1120 | self.lookedup_patchset = False |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 1121 | self.patchset = None |
bauerb@chromium.org | ae6df35 | 2011-04-06 17:40:39 +0000 | [diff] [blame] | 1122 | self.cc = None |
Daniel Cheng | 7227d21 | 2017-11-17 08:12:37 -0800 | [diff] [blame] | 1123 | self.more_cc = [] |
vadimsh@chromium.org | cf6a5d2 | 2015-04-09 22:02:00 +0000 | [diff] [blame] | 1124 | self._remote = None |
Andrii Shyshkalov | 81db1d5 | 2018-08-23 02:17:41 +0000 | [diff] [blame] | 1125 | self._cached_remote_url = (False, None) # (is_cached, value) |
vadimsh@chromium.org | cf6a5d2 | 2015-04-09 22:02:00 +0000 | [diff] [blame] | 1126 | |
tandrii@chromium.org | aa5ced1 | 2016-03-29 09:41:14 +0000 | [diff] [blame] | 1127 | self._codereview_impl = None |
tandrii@chromium.org | d68b62b | 2016-03-31 16:09:29 +0000 | [diff] [blame] | 1128 | self._codereview = None |
tandrii@chromium.org | aa5ced1 | 2016-03-29 09:41:14 +0000 | [diff] [blame] | 1129 | self._load_codereview_impl(codereview, **kwargs) |
tandrii@chromium.org | d68b62b | 2016-03-31 16:09:29 +0000 | [diff] [blame] | 1130 | assert self._codereview_impl |
| 1131 | assert self._codereview in _CODEREVIEW_IMPLEMENTATIONS |
tandrii@chromium.org | aa5ced1 | 2016-03-29 09:41:14 +0000 | [diff] [blame] | 1132 | |
| 1133 | def _load_codereview_impl(self, codereview=None, **kwargs): |
| 1134 | if codereview: |
Joe Mason | d87b096 | 2018-12-03 21:04:46 +0000 | [diff] [blame] | 1135 | assert codereview in _CODEREVIEW_IMPLEMENTATIONS, ( |
| 1136 | 'codereview {} not in {}'.format(codereview, |
| 1137 | _CODEREVIEW_IMPLEMENTATIONS)) |
tandrii@chromium.org | d68b62b | 2016-03-31 16:09:29 +0000 | [diff] [blame] | 1138 | cls = _CODEREVIEW_IMPLEMENTATIONS[codereview] |
| 1139 | self._codereview = codereview |
| 1140 | self._codereview_impl = cls(self, **kwargs) |
tandrii@chromium.org | aa5ced1 | 2016-03-29 09:41:14 +0000 | [diff] [blame] | 1141 | return |
| 1142 | |
| 1143 | # Automatic selection based on issue number set for a current branch. |
| 1144 | # Rietveld takes precedence over Gerrit. |
| 1145 | assert not self.issue |
| 1146 | # Whether we find issue or not, we are doing the lookup. |
| 1147 | self.lookedup_issue = True |
tandrii | 5d48c32 | 2016-08-18 16:19:37 -0700 | [diff] [blame] | 1148 | if self.GetBranch(): |
| 1149 | for codereview, cls in _CODEREVIEW_IMPLEMENTATIONS.iteritems(): |
| 1150 | issue = _git_get_branch_config_value( |
| 1151 | cls.IssueConfigKey(), value_type=int, branch=self.GetBranch()) |
| 1152 | if issue: |
| 1153 | self._codereview = codereview |
| 1154 | self._codereview_impl = cls(self, **kwargs) |
| 1155 | self.issue = int(issue) |
| 1156 | return |
tandrii@chromium.org | aa5ced1 | 2016-03-29 09:41:14 +0000 | [diff] [blame] | 1157 | |
Bryce Thomas | cfc9712 | 2018-12-13 20:21:47 +0000 | [diff] [blame] | 1158 | # No issue is set for this branch, so default to gerrit. |
tandrii@chromium.org | aa5ced1 | 2016-03-29 09:41:14 +0000 | [diff] [blame] | 1159 | return self._load_codereview_impl( |
Bryce Thomas | cfc9712 | 2018-12-13 20:21:47 +0000 | [diff] [blame] | 1160 | codereview='gerrit', |
tandrii@chromium.org | aa5ced1 | 2016-03-29 09:41:14 +0000 | [diff] [blame] | 1161 | **kwargs) |
| 1162 | |
tandrii@chromium.org | d68b62b | 2016-03-31 16:09:29 +0000 | [diff] [blame] | 1163 | def IsGerrit(self): |
| 1164 | return self._codereview == 'gerrit' |
bauerb@chromium.org | ae6df35 | 2011-04-06 17:40:39 +0000 | [diff] [blame] | 1165 | |
| 1166 | def GetCCList(self): |
Quinten Yearsley | 0c62da9 | 2017-05-31 13:39:42 -0700 | [diff] [blame] | 1167 | """Returns the users cc'd on this CL. |
bauerb@chromium.org | ae6df35 | 2011-04-06 17:40:39 +0000 | [diff] [blame] | 1168 | |
Quinten Yearsley | 0c62da9 | 2017-05-31 13:39:42 -0700 | [diff] [blame] | 1169 | The return value is a string suitable for passing to git cl with the --cc |
| 1170 | flag. |
bauerb@chromium.org | ae6df35 | 2011-04-06 17:40:39 +0000 | [diff] [blame] | 1171 | """ |
| 1172 | if self.cc is None: |
tyoshino@chromium.org | 99918ab | 2013-09-30 06:17:28 +0000 | [diff] [blame] | 1173 | base_cc = settings.GetDefaultCCList() |
Daniel Cheng | 7227d21 | 2017-11-17 08:12:37 -0800 | [diff] [blame] | 1174 | more_cc = ','.join(self.more_cc) |
bauerb@chromium.org | ae6df35 | 2011-04-06 17:40:39 +0000 | [diff] [blame] | 1175 | self.cc = ','.join(filter(None, (base_cc, more_cc))) or '' |
| 1176 | return self.cc |
| 1177 | |
tyoshino@chromium.org | 99918ab | 2013-09-30 06:17:28 +0000 | [diff] [blame] | 1178 | def GetCCListWithoutDefault(self): |
| 1179 | """Return the users cc'd on this CL excluding default ones.""" |
| 1180 | if self.cc is None: |
Daniel Cheng | 7227d21 | 2017-11-17 08:12:37 -0800 | [diff] [blame] | 1181 | self.cc = ','.join(self.more_cc) |
tyoshino@chromium.org | 99918ab | 2013-09-30 06:17:28 +0000 | [diff] [blame] | 1182 | return self.cc |
| 1183 | |
Daniel Cheng | 7227d21 | 2017-11-17 08:12:37 -0800 | [diff] [blame] | 1184 | def ExtendCC(self, more_cc): |
| 1185 | """Extends the list of users to cc on this CL based on the changed files.""" |
| 1186 | self.more_cc.extend(more_cc) |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 1187 | |
| 1188 | def GetBranch(self): |
| 1189 | """Returns the short branch name, e.g. 'master'.""" |
| 1190 | if not self.branch: |
tandrii@chromium.org | aa5ced1 | 2016-03-29 09:41:14 +0000 | [diff] [blame] | 1191 | branchref = GetCurrentBranchRef() |
szager@chromium.org | d62c61f | 2014-10-20 22:33:21 +0000 | [diff] [blame] | 1192 | if not branchref: |
| 1193 | return None |
| 1194 | self.branchref = branchref |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 1195 | self.branch = ShortBranchName(self.branchref) |
| 1196 | return self.branch |
| 1197 | |
| 1198 | def GetBranchRef(self): |
| 1199 | """Returns the full branch name, e.g. 'refs/heads/master'.""" |
| 1200 | self.GetBranch() # Poke the lazy loader. |
| 1201 | return self.branchref |
| 1202 | |
tandrii@chromium.org | 534f67a | 2016-04-07 18:47:05 +0000 | [diff] [blame] | 1203 | def ClearBranch(self): |
| 1204 | """Clears cached branch data of this object.""" |
| 1205 | self.branch = self.branchref = None |
| 1206 | |
tandrii | 5d48c32 | 2016-08-18 16:19:37 -0700 | [diff] [blame] | 1207 | def _GitGetBranchConfigValue(self, key, default=None, **kwargs): |
| 1208 | assert 'branch' not in kwargs, 'this CL branch is used automatically' |
| 1209 | kwargs['branch'] = self.GetBranch() |
| 1210 | return _git_get_branch_config_value(key, default, **kwargs) |
| 1211 | |
| 1212 | def _GitSetBranchConfigValue(self, key, value, **kwargs): |
| 1213 | assert 'branch' not in kwargs, 'this CL branch is used automatically' |
| 1214 | assert self.GetBranch(), ( |
| 1215 | 'this CL must have an associated branch to %sset %s%s' % |
| 1216 | ('un' if value is None else '', |
| 1217 | key, |
| 1218 | '' if value is None else ' to %r' % value)) |
| 1219 | kwargs['branch'] = self.GetBranch() |
| 1220 | return _git_set_branch_config_value(key, value, **kwargs) |
| 1221 | |
ilevy@chromium.org | 0f58fa8 | 2012-11-05 01:45:20 +0000 | [diff] [blame] | 1222 | @staticmethod |
| 1223 | def FetchUpstreamTuple(branch): |
pgervais@chromium.org | d6617f3 | 2013-11-19 00:34:54 +0000 | [diff] [blame] | 1224 | """Returns a tuple containing remote and remote ref, |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 1225 | e.g. 'origin', 'refs/heads/master' |
| 1226 | """ |
| 1227 | remote = '.' |
tandrii | 5d48c32 | 2016-08-18 16:19:37 -0700 | [diff] [blame] | 1228 | upstream_branch = _git_get_branch_config_value('merge', branch=branch) |
| 1229 | |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 1230 | if upstream_branch: |
tandrii | 5d48c32 | 2016-08-18 16:19:37 -0700 | [diff] [blame] | 1231 | remote = _git_get_branch_config_value('remote', branch=branch) |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 1232 | else: |
bauerb@chromium.org | ade368c | 2011-03-01 08:57:50 +0000 | [diff] [blame] | 1233 | upstream_branch = RunGit(['config', 'rietveld.upstream-branch'], |
| 1234 | error_ok=True).strip() |
| 1235 | if upstream_branch: |
| 1236 | remote = RunGit(['config', 'rietveld.upstream-remote']).strip() |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 1237 | else: |
Aaron Gable | 1bc7bfe | 2016-12-19 10:08:14 -0800 | [diff] [blame] | 1238 | # Else, try to guess the origin remote. |
| 1239 | remote_branches = RunGit(['branch', '-r']).split() |
| 1240 | if 'origin/master' in remote_branches: |
| 1241 | # Fall back on origin/master if it exits. |
| 1242 | remote = 'origin' |
| 1243 | upstream_branch = 'refs/heads/master' |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 1244 | else: |
Aaron Gable | 1bc7bfe | 2016-12-19 10:08:14 -0800 | [diff] [blame] | 1245 | DieWithError( |
| 1246 | 'Unable to determine default branch to diff against.\n' |
| 1247 | 'Either pass complete "git diff"-style arguments, like\n' |
| 1248 | ' git cl upload origin/master\n' |
| 1249 | 'or verify this branch is set up to track another \n' |
| 1250 | '(via the --track argument to "git checkout -b ...").') |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 1251 | |
| 1252 | return remote, upstream_branch |
| 1253 | |
thestig@chromium.org | 8b0553c | 2014-02-11 00:33:37 +0000 | [diff] [blame] | 1254 | def GetCommonAncestorWithUpstream(self): |
pgervais@chromium.org | 8ba38ff | 2015-06-11 21:41:25 +0000 | [diff] [blame] | 1255 | upstream_branch = self.GetUpstreamBranch() |
| 1256 | if not BranchExists(upstream_branch): |
| 1257 | DieWithError('The upstream for the current branch (%s) does not exist ' |
| 1258 | 'anymore.\nPlease fix it and try again.' % self.GetBranch()) |
iannucci@chromium.org | 9e84927 | 2014-04-04 00:31:55 +0000 | [diff] [blame] | 1259 | return git_common.get_or_create_merge_base(self.GetBranch(), |
pgervais@chromium.org | 8ba38ff | 2015-06-11 21:41:25 +0000 | [diff] [blame] | 1260 | upstream_branch) |
thestig@chromium.org | 8b0553c | 2014-02-11 00:33:37 +0000 | [diff] [blame] | 1261 | |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 1262 | def GetUpstreamBranch(self): |
| 1263 | if self.upstream_branch is None: |
ilevy@chromium.org | 0f58fa8 | 2012-11-05 01:45:20 +0000 | [diff] [blame] | 1264 | remote, upstream_branch = self.FetchUpstreamTuple(self.GetBranch()) |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 1265 | if remote is not '.': |
mmoss@chromium.org | e758545 | 2014-08-24 01:41:11 +0000 | [diff] [blame] | 1266 | upstream_branch = upstream_branch.replace('refs/heads/', |
| 1267 | 'refs/remotes/%s/' % remote) |
| 1268 | upstream_branch = upstream_branch.replace('refs/branch-heads/', |
| 1269 | 'refs/remotes/branch-heads/') |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 1270 | self.upstream_branch = upstream_branch |
| 1271 | return self.upstream_branch |
| 1272 | |
ilevy@chromium.org | 0f58fa8 | 2012-11-05 01:45:20 +0000 | [diff] [blame] | 1273 | def GetRemoteBranch(self): |
jmbaker@chromium.org | a2cbbbb | 2012-03-22 20:40:40 +0000 | [diff] [blame] | 1274 | if not self._remote: |
ilevy@chromium.org | 0f58fa8 | 2012-11-05 01:45:20 +0000 | [diff] [blame] | 1275 | remote, branch = None, self.GetBranch() |
| 1276 | seen_branches = set() |
| 1277 | while branch not in seen_branches: |
| 1278 | seen_branches.add(branch) |
| 1279 | remote, branch = self.FetchUpstreamTuple(branch) |
| 1280 | branch = ShortBranchName(branch) |
| 1281 | if remote != '.' or branch.startswith('refs/remotes'): |
| 1282 | break |
| 1283 | else: |
jmbaker@chromium.org | a2cbbbb | 2012-03-22 20:40:40 +0000 | [diff] [blame] | 1284 | remotes = RunGit(['remote'], error_ok=True).split() |
| 1285 | if len(remotes) == 1: |
ilevy@chromium.org | 0f58fa8 | 2012-11-05 01:45:20 +0000 | [diff] [blame] | 1286 | remote, = remotes |
jmbaker@chromium.org | a2cbbbb | 2012-03-22 20:40:40 +0000 | [diff] [blame] | 1287 | elif 'origin' in remotes: |
ilevy@chromium.org | 0f58fa8 | 2012-11-05 01:45:20 +0000 | [diff] [blame] | 1288 | remote = 'origin' |
Aaron Gable | 1bc7bfe | 2016-12-19 10:08:14 -0800 | [diff] [blame] | 1289 | logging.warn('Could not determine which remote this change is ' |
| 1290 | 'associated with, so defaulting to "%s".' % self._remote) |
jmbaker@chromium.org | a2cbbbb | 2012-03-22 20:40:40 +0000 | [diff] [blame] | 1291 | else: |
| 1292 | logging.warn('Could not determine which remote this change is ' |
Aaron Gable | 1bc7bfe | 2016-12-19 10:08:14 -0800 | [diff] [blame] | 1293 | 'associated with.') |
ilevy@chromium.org | 0f58fa8 | 2012-11-05 01:45:20 +0000 | [diff] [blame] | 1294 | branch = 'HEAD' |
| 1295 | if branch.startswith('refs/remotes'): |
| 1296 | self._remote = (remote, branch) |
mmoss@chromium.org | e758545 | 2014-08-24 01:41:11 +0000 | [diff] [blame] | 1297 | elif branch.startswith('refs/branch-heads/'): |
| 1298 | self._remote = (remote, branch.replace('refs/', 'refs/remotes/')) |
ilevy@chromium.org | 0f58fa8 | 2012-11-05 01:45:20 +0000 | [diff] [blame] | 1299 | else: |
| 1300 | self._remote = (remote, 'refs/remotes/%s/%s' % (remote, branch)) |
jmbaker@chromium.org | a2cbbbb | 2012-03-22 20:40:40 +0000 | [diff] [blame] | 1301 | return self._remote |
| 1302 | |
ilevy@chromium.org | 0f58fa8 | 2012-11-05 01:45:20 +0000 | [diff] [blame] | 1303 | def GitSanityChecks(self, upstream_git_obj): |
| 1304 | """Checks git repo status and ensures diff is from local commits.""" |
| 1305 | |
sbc@chromium.org | 7970606 | 2015-01-14 21:18:12 +0000 | [diff] [blame] | 1306 | if upstream_git_obj is None: |
| 1307 | if self.GetBranch() is None: |
Quinten Yearsley | 0c62da9 | 2017-05-31 13:39:42 -0700 | [diff] [blame] | 1308 | print('ERROR: Unable to determine current branch (detached HEAD?)', |
vapier | a7fbd5a | 2016-06-16 09:17:49 -0700 | [diff] [blame] | 1309 | file=sys.stderr) |
sbc@chromium.org | 7970606 | 2015-01-14 21:18:12 +0000 | [diff] [blame] | 1310 | else: |
Quinten Yearsley | 0c62da9 | 2017-05-31 13:39:42 -0700 | [diff] [blame] | 1311 | print('ERROR: No upstream branch.', file=sys.stderr) |
sbc@chromium.org | 7970606 | 2015-01-14 21:18:12 +0000 | [diff] [blame] | 1312 | return False |
| 1313 | |
ilevy@chromium.org | 0f58fa8 | 2012-11-05 01:45:20 +0000 | [diff] [blame] | 1314 | # Verify the commit we're diffing against is in our current branch. |
| 1315 | upstream_sha = RunGit(['rev-parse', '--verify', upstream_git_obj]).strip() |
| 1316 | common_ancestor = RunGit(['merge-base', upstream_sha, 'HEAD']).strip() |
| 1317 | if upstream_sha != common_ancestor: |
vapier | a7fbd5a | 2016-06-16 09:17:49 -0700 | [diff] [blame] | 1318 | print('ERROR: %s is not in the current branch. You may need to rebase ' |
| 1319 | 'your tracking branch' % upstream_sha, file=sys.stderr) |
ilevy@chromium.org | 0f58fa8 | 2012-11-05 01:45:20 +0000 | [diff] [blame] | 1320 | return False |
| 1321 | |
| 1322 | # List the commits inside the diff, and verify they are all local. |
| 1323 | commits_in_diff = RunGit( |
| 1324 | ['rev-list', '^%s' % upstream_sha, 'HEAD']).splitlines() |
| 1325 | code, remote_branch = RunGitWithCode(['config', 'gitcl.remotebranch']) |
| 1326 | remote_branch = remote_branch.strip() |
| 1327 | if code != 0: |
| 1328 | _, remote_branch = self.GetRemoteBranch() |
| 1329 | |
| 1330 | commits_in_remote = RunGit( |
| 1331 | ['rev-list', '^%s' % upstream_sha, remote_branch]).splitlines() |
| 1332 | |
| 1333 | common_commits = set(commits_in_diff) & set(commits_in_remote) |
| 1334 | if common_commits: |
vapier | a7fbd5a | 2016-06-16 09:17:49 -0700 | [diff] [blame] | 1335 | print('ERROR: Your diff contains %d commits already in %s.\n' |
| 1336 | 'Run "git log --oneline %s..HEAD" to get a list of commits in ' |
| 1337 | 'the diff. If you are using a custom git flow, you can override' |
| 1338 | ' the reference used for this check with "git config ' |
| 1339 | 'gitcl.remotebranch <git-ref>".' % ( |
| 1340 | len(common_commits), remote_branch, upstream_git_obj), |
| 1341 | file=sys.stderr) |
ilevy@chromium.org | 0f58fa8 | 2012-11-05 01:45:20 +0000 | [diff] [blame] | 1342 | return False |
| 1343 | return True |
| 1344 | |
kalmard@homejinni.com | 6b0051e | 2012-04-03 15:45:08 +0000 | [diff] [blame] | 1345 | def GetGitBaseUrlFromConfig(self): |
sheyang@chromium.org | a656e70 | 2014-05-15 20:43:05 +0000 | [diff] [blame] | 1346 | """Return the configured base URL from branch.<branchname>.baseurl. |
kalmard@homejinni.com | 6b0051e | 2012-04-03 15:45:08 +0000 | [diff] [blame] | 1347 | |
| 1348 | Returns None if it is not set. |
| 1349 | """ |
tandrii | 5d48c32 | 2016-08-18 16:19:37 -0700 | [diff] [blame] | 1350 | return self._GitGetBranchConfigValue('base-url') |
jmbaker@chromium.org | a2cbbbb | 2012-03-22 20:40:40 +0000 | [diff] [blame] | 1351 | |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 1352 | def GetRemoteUrl(self): |
| 1353 | """Return the configured remote URL, e.g. 'git://example.org/foo.git/'. |
| 1354 | |
| 1355 | Returns None if there is no remote. |
| 1356 | """ |
Andrii Shyshkalov | 81db1d5 | 2018-08-23 02:17:41 +0000 | [diff] [blame] | 1357 | is_cached, value = self._cached_remote_url |
| 1358 | if is_cached: |
| 1359 | return value |
| 1360 | |
ilevy@chromium.org | 0f58fa8 | 2012-11-05 01:45:20 +0000 | [diff] [blame] | 1361 | remote, _ = self.GetRemoteBranch() |
dyen@chromium.org | 2a13d4f | 2014-06-13 00:06:37 +0000 | [diff] [blame] | 1362 | url = RunGit(['config', 'remote.%s.url' % remote], error_ok=True).strip() |
| 1363 | |
Edward Lemur | 298f2cf | 2019-02-22 21:40:39 +0000 | [diff] [blame] | 1364 | # Check if the remote url can be parsed as an URL. |
| 1365 | host = urlparse.urlparse(url).netloc |
| 1366 | if host: |
| 1367 | self._cached_remote_url = (True, url) |
| 1368 | return url |
| 1369 | |
| 1370 | # If it cannot be parsed as an url, assume it is a local directory, probably |
| 1371 | # a git cache. |
| 1372 | logging.warning('"%s" doesn\'t appear to point to a git host. ' |
| 1373 | 'Interpreting it as a local directory.', url) |
| 1374 | if not os.path.isdir(url): |
| 1375 | logging.error( |
| 1376 | 'Remote "%s" for branch "%s" points to "%s", but it doesn\'t exist.', |
| 1377 | remote, url, self.GetBranch()) |
| 1378 | return None |
| 1379 | |
| 1380 | cache_path = url |
| 1381 | url = RunGit(['config', 'remote.%s.url' % remote], |
| 1382 | error_ok=True, |
| 1383 | cwd=url).strip() |
| 1384 | |
| 1385 | host = urlparse.urlparse(url).netloc |
| 1386 | if not host: |
| 1387 | logging.error( |
| 1388 | 'Remote "%(remote)s" for branch "%(branch)s" points to ' |
| 1389 | '"%(cache_path)s", but it is misconfigured.\n' |
| 1390 | '"%(cache_path)s" must be a git repo and must have a remote named ' |
| 1391 | '"%(remote)s" pointing to the git host.', { |
| 1392 | 'remote': remote, |
| 1393 | 'cache_path': cache_path, |
| 1394 | 'branch': self.GetBranch()}) |
| 1395 | return None |
| 1396 | |
Andrii Shyshkalov | 81db1d5 | 2018-08-23 02:17:41 +0000 | [diff] [blame] | 1397 | self._cached_remote_url = (True, url) |
dyen@chromium.org | 2a13d4f | 2014-06-13 00:06:37 +0000 | [diff] [blame] | 1398 | return url |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 1399 | |
tandrii@chromium.org | 87985d2 | 2016-03-24 17:33:33 +0000 | [diff] [blame] | 1400 | def GetIssue(self): |
maruel@chromium.org | 5242430 | 2012-08-29 15:14:30 +0000 | [diff] [blame] | 1401 | """Returns the issue number as a int or None if not set.""" |
tandrii@chromium.org | 87985d2 | 2016-03-24 17:33:33 +0000 | [diff] [blame] | 1402 | if self.issue is None and not self.lookedup_issue: |
tandrii | 5d48c32 | 2016-08-18 16:19:37 -0700 | [diff] [blame] | 1403 | self.issue = self._GitGetBranchConfigValue( |
| 1404 | self._codereview_impl.IssueConfigKey(), value_type=int) |
maruel@chromium.org | 1033efd | 2013-07-23 23:25:09 +0000 | [diff] [blame] | 1405 | self.lookedup_issue = True |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 1406 | return self.issue |
| 1407 | |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 1408 | def GetIssueURL(self): |
| 1409 | """Get the URL for a particular issue.""" |
tandrii@chromium.org | aa5ced1 | 2016-03-29 09:41:14 +0000 | [diff] [blame] | 1410 | issue = self.GetIssue() |
| 1411 | if not issue: |
dbeam@chromium.org | 015fd3d | 2013-06-18 19:02:50 +0000 | [diff] [blame] | 1412 | return None |
tandrii@chromium.org | aa5ced1 | 2016-03-29 09:41:14 +0000 | [diff] [blame] | 1413 | return '%s/%s' % (self._codereview_impl.GetCodereviewServer(), issue) |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 1414 | |
Andrii Shyshkalov | 3186301 | 2017-02-08 11:35:12 +0100 | [diff] [blame] | 1415 | def GetDescription(self, pretty=False, force=False): |
| 1416 | if not self.has_description or force: |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 1417 | if self.GetIssue(): |
Kenneth Russell | 61e2ed4 | 2017-02-15 11:47:13 -0800 | [diff] [blame] | 1418 | self.description = self._codereview_impl.FetchDescription(force=force) |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 1419 | self.has_description = True |
| 1420 | if pretty: |
Asanka Herath | 7c61dcb | 2016-12-14 13:01:58 -0500 | [diff] [blame] | 1421 | # Set width to 72 columns + 2 space indent. |
| 1422 | wrapper = textwrap.TextWrapper(width=74, replace_whitespace=True) |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 1423 | wrapper.initial_indent = wrapper.subsequent_indent = ' ' |
Asanka Herath | 7c61dcb | 2016-12-14 13:01:58 -0500 | [diff] [blame] | 1424 | lines = self.description.splitlines() |
| 1425 | return '\n'.join([wrapper.fill(line) for line in lines]) |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 1426 | return self.description |
| 1427 | |
Robert Iannucci | 09f1f3d | 2017-03-28 16:54:32 -0700 | [diff] [blame] | 1428 | def GetDescriptionFooters(self): |
| 1429 | """Returns (non_footer_lines, footers) for the commit message. |
| 1430 | |
| 1431 | Returns: |
| 1432 | non_footer_lines (list(str)) - Simple list of description lines without |
| 1433 | any footer. The lines do not contain newlines, nor does the list contain |
| 1434 | the empty line between the message and the footers. |
| 1435 | footers (list(tuple(KEY, VALUE))) - List of parsed footers, e.g. |
| 1436 | [("Change-Id", "Ideadbeef...."), ...] |
| 1437 | """ |
| 1438 | raw_description = self.GetDescription() |
| 1439 | msg_lines, _, footers = git_footers.split_footers(raw_description) |
| 1440 | if footers: |
| 1441 | msg_lines = msg_lines[:len(msg_lines)-1] |
| 1442 | return msg_lines, footers |
| 1443 | |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 1444 | def GetPatchset(self): |
maruel@chromium.org | 5242430 | 2012-08-29 15:14:30 +0000 | [diff] [blame] | 1445 | """Returns the patchset number as a int or None if not set.""" |
maruel@chromium.org | 1033efd | 2013-07-23 23:25:09 +0000 | [diff] [blame] | 1446 | if self.patchset is None and not self.lookedup_patchset: |
tandrii | 5d48c32 | 2016-08-18 16:19:37 -0700 | [diff] [blame] | 1447 | self.patchset = self._GitGetBranchConfigValue( |
| 1448 | self._codereview_impl.PatchsetConfigKey(), value_type=int) |
maruel@chromium.org | 1033efd | 2013-07-23 23:25:09 +0000 | [diff] [blame] | 1449 | self.lookedup_patchset = True |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 1450 | return self.patchset |
| 1451 | |
| 1452 | def SetPatchset(self, patchset): |
tandrii | 5d48c32 | 2016-08-18 16:19:37 -0700 | [diff] [blame] | 1453 | """Set this branch's patchset. If patchset=0, clears the patchset.""" |
| 1454 | assert self.GetBranch() |
| 1455 | if not patchset: |
maruel@chromium.org | 1033efd | 2013-07-23 23:25:09 +0000 | [diff] [blame] | 1456 | self.patchset = None |
tandrii | 5d48c32 | 2016-08-18 16:19:37 -0700 | [diff] [blame] | 1457 | else: |
| 1458 | self.patchset = int(patchset) |
| 1459 | self._GitSetBranchConfigValue( |
| 1460 | self._codereview_impl.PatchsetConfigKey(), self.patchset) |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 1461 | |
tandrii@chromium.org | a342c92 | 2016-03-16 07:08:25 +0000 | [diff] [blame] | 1462 | def SetIssue(self, issue=None): |
tandrii | 5d48c32 | 2016-08-18 16:19:37 -0700 | [diff] [blame] | 1463 | """Set this branch's issue. If issue isn't given, clears the issue.""" |
| 1464 | assert self.GetBranch() |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 1465 | if issue: |
tandrii | 5d48c32 | 2016-08-18 16:19:37 -0700 | [diff] [blame] | 1466 | issue = int(issue) |
| 1467 | self._GitSetBranchConfigValue( |
| 1468 | self._codereview_impl.IssueConfigKey(), issue) |
maruel@chromium.org | 1033efd | 2013-07-23 23:25:09 +0000 | [diff] [blame] | 1469 | self.issue = issue |
tandrii@chromium.org | aa5ced1 | 2016-03-29 09:41:14 +0000 | [diff] [blame] | 1470 | codereview_server = self._codereview_impl.GetCodereviewServer() |
| 1471 | if codereview_server: |
tandrii | 5d48c32 | 2016-08-18 16:19:37 -0700 | [diff] [blame] | 1472 | self._GitSetBranchConfigValue( |
| 1473 | self._codereview_impl.CodereviewServerConfigKey(), |
| 1474 | codereview_server) |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 1475 | else: |
tandrii | 5d48c32 | 2016-08-18 16:19:37 -0700 | [diff] [blame] | 1476 | # Reset all of these just to be clean. |
| 1477 | reset_suffixes = [ |
| 1478 | 'last-upload-hash', |
| 1479 | self._codereview_impl.IssueConfigKey(), |
| 1480 | self._codereview_impl.PatchsetConfigKey(), |
| 1481 | self._codereview_impl.CodereviewServerConfigKey(), |
| 1482 | ] + self._PostUnsetIssueProperties() |
| 1483 | for prop in reset_suffixes: |
| 1484 | self._GitSetBranchConfigValue(prop, None, error_ok=True) |
Aaron Gable | ca01e2c | 2017-07-19 11:16:02 -0700 | [diff] [blame] | 1485 | msg = RunGit(['log', '-1', '--format=%B']).strip() |
| 1486 | if msg and git_footers.get_footer_change_id(msg): |
| 1487 | print('WARNING: The change patched into this branch has a Change-Id. ' |
| 1488 | 'Removing it.') |
| 1489 | RunGit(['commit', '--amend', '-m', |
| 1490 | git_footers.remove_footer(msg, 'Change-Id')]) |
maruel@chromium.org | 1033efd | 2013-07-23 23:25:09 +0000 | [diff] [blame] | 1491 | self.issue = None |
tandrii@chromium.org | 9b7fd71 | 2016-06-01 13:45:20 +0000 | [diff] [blame] | 1492 | self.patchset = None |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 1493 | |
dnj | ba1b0f3 | 2016-09-02 12:37:42 -0700 | [diff] [blame] | 1494 | def GetChange(self, upstream_branch, author, local_description=False): |
ilevy@chromium.org | 0f58fa8 | 2012-11-05 01:45:20 +0000 | [diff] [blame] | 1495 | if not self.GitSanityChecks(upstream_branch): |
| 1496 | DieWithError('\nGit sanity check failure') |
| 1497 | |
thestig@chromium.org | 8b0553c | 2014-02-11 00:33:37 +0000 | [diff] [blame] | 1498 | root = settings.GetRelativeRoot() |
bratell@opera.com | f267b0e | 2013-05-02 09:11:43 +0000 | [diff] [blame] | 1499 | if not root: |
| 1500 | root = '.' |
bauerb@chromium.org | 512f1ef | 2011-04-20 15:17:57 +0000 | [diff] [blame] | 1501 | absroot = os.path.abspath(root) |
bauerb@chromium.org | 6fb99c6 | 2011-04-18 15:57:28 +0000 | [diff] [blame] | 1502 | |
| 1503 | # We use the sha1 of HEAD as a name of this change. |
thestig@chromium.org | 8b0553c | 2014-02-11 00:33:37 +0000 | [diff] [blame] | 1504 | name = RunGitWithCode(['rev-parse', 'HEAD'])[1].strip() |
bauerb@chromium.org | 512f1ef | 2011-04-20 15:17:57 +0000 | [diff] [blame] | 1505 | # Need to pass a relative path for msysgit. |
maruel@chromium.org | 2b38e9c | 2011-10-19 00:04:35 +0000 | [diff] [blame] | 1506 | try: |
maruel@chromium.org | 80a9ef1 | 2011-12-13 20:44:10 +0000 | [diff] [blame] | 1507 | files = scm.GIT.CaptureStatus([root], '.', upstream_branch) |
maruel@chromium.org | 2b38e9c | 2011-10-19 00:04:35 +0000 | [diff] [blame] | 1508 | except subprocess2.CalledProcessError: |
| 1509 | DieWithError( |
pgervais@chromium.org | d6617f3 | 2013-11-19 00:34:54 +0000 | [diff] [blame] | 1510 | ('\nFailed to diff against upstream branch %s\n\n' |
maruel@chromium.org | 2b38e9c | 2011-10-19 00:04:35 +0000 | [diff] [blame] | 1511 | 'This branch probably doesn\'t exist anymore. To reset the\n' |
| 1512 | 'tracking branch, please run\n' |
stip | 7a3dd35 | 2016-09-22 17:32:28 -0700 | [diff] [blame] | 1513 | ' git branch --set-upstream-to origin/master %s\n' |
| 1514 | 'or replace origin/master with the relevant branch') % |
maruel@chromium.org | 2b38e9c | 2011-10-19 00:04:35 +0000 | [diff] [blame] | 1515 | (upstream_branch, self.GetBranch())) |
bauerb@chromium.org | 6fb99c6 | 2011-04-18 15:57:28 +0000 | [diff] [blame] | 1516 | |
maruel@chromium.org | 5242430 | 2012-08-29 15:14:30 +0000 | [diff] [blame] | 1517 | issue = self.GetIssue() |
| 1518 | patchset = self.GetPatchset() |
dnj | ba1b0f3 | 2016-09-02 12:37:42 -0700 | [diff] [blame] | 1519 | if issue and not local_description: |
bauerb@chromium.org | 6fb99c6 | 2011-04-18 15:57:28 +0000 | [diff] [blame] | 1520 | description = self.GetDescription() |
| 1521 | else: |
| 1522 | # If the change was never uploaded, use the log messages of all commits |
| 1523 | # up to the branch point, as git cl upload will prefill the description |
| 1524 | # with these log messages. |
thestig@chromium.org | 8b0553c | 2014-02-11 00:33:37 +0000 | [diff] [blame] | 1525 | args = ['log', '--pretty=format:%s%n%n%b', '%s...' % (upstream_branch)] |
| 1526 | description = RunGitWithCode(args)[1].strip() |
maruel@chromium.org | 03b3bdc | 2011-06-14 13:04:12 +0000 | [diff] [blame] | 1527 | |
| 1528 | if not author: |
maruel@chromium.org | 13f623c | 2011-07-22 16:02:23 +0000 | [diff] [blame] | 1529 | author = RunGit(['config', 'user.email']).strip() or None |
asvitkine@chromium.org | 1516995 | 2011-09-27 14:30:53 +0000 | [diff] [blame] | 1530 | return presubmit_support.GitChange( |
bauerb@chromium.org | 6fb99c6 | 2011-04-18 15:57:28 +0000 | [diff] [blame] | 1531 | name, |
| 1532 | description, |
| 1533 | absroot, |
| 1534 | files, |
| 1535 | issue, |
| 1536 | patchset, |
agable@chromium.org | ea84ef1 | 2014-04-30 19:55:12 +0000 | [diff] [blame] | 1537 | author, |
| 1538 | upstream=upstream_branch) |
bauerb@chromium.org | 6fb99c6 | 2011-04-18 15:57:28 +0000 | [diff] [blame] | 1539 | |
dsansome | e2d6fd9 | 2016-09-08 00:10:47 -0700 | [diff] [blame] | 1540 | def UpdateDescription(self, description, force=False): |
Andrii Shyshkalov | 8305115 | 2017-02-07 23:47:29 +0100 | [diff] [blame] | 1541 | self._codereview_impl.UpdateDescriptionRemote(description, force=force) |
tandrii@chromium.org | aa5ced1 | 2016-03-29 09:41:14 +0000 | [diff] [blame] | 1542 | self.description = description |
Andrii Shyshkalov | 8305115 | 2017-02-07 23:47:29 +0100 | [diff] [blame] | 1543 | self.has_description = True |
tandrii@chromium.org | aa5ced1 | 2016-03-29 09:41:14 +0000 | [diff] [blame] | 1544 | |
Robert Iannucci | 09f1f3d | 2017-03-28 16:54:32 -0700 | [diff] [blame] | 1545 | def UpdateDescriptionFooters(self, description_lines, footers, force=False): |
| 1546 | """Sets the description for this CL remotely. |
| 1547 | |
| 1548 | You can get description_lines and footers with GetDescriptionFooters. |
| 1549 | |
| 1550 | Args: |
| 1551 | description_lines (list(str)) - List of CL description lines without |
| 1552 | newline characters. |
| 1553 | footers (list(tuple(KEY, VALUE))) - List of footers, as returned by |
| 1554 | GetDescriptionFooters. Key must conform to the git footers format (i.e. |
| 1555 | `List-Of-Tokens`). It will be case-normalized so that each token is |
| 1556 | title-cased. |
| 1557 | """ |
| 1558 | new_description = '\n'.join(description_lines) |
| 1559 | if footers: |
| 1560 | new_description += '\n' |
| 1561 | for k, v in footers: |
| 1562 | foot = '%s: %s' % (git_footers.normalize_name(k), v) |
| 1563 | if not git_footers.FOOTER_PATTERN.match(foot): |
| 1564 | raise ValueError('Invalid footer %r' % foot) |
| 1565 | new_description += foot + '\n' |
| 1566 | self.UpdateDescription(new_description, force) |
| 1567 | |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 1568 | def RunHook(self, committing, may_prompt, verbose, change, parallel): |
tandrii@chromium.org | aa5ced1 | 2016-03-29 09:41:14 +0000 | [diff] [blame] | 1569 | """Calls sys.exit() if the hook fails; returns a HookResults otherwise.""" |
| 1570 | try: |
| 1571 | return presubmit_support.DoPresubmitChecks(change, committing, |
| 1572 | verbose=verbose, output_stream=sys.stdout, input_stream=sys.stdin, |
| 1573 | default_presubmit=None, may_prompt=may_prompt, |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 1574 | gerrit_obj=self._codereview_impl.GetGerritObjForPresubmit(), |
| 1575 | parallel=parallel) |
vapier | fd77ac7 | 2016-06-16 08:33:57 -0700 | [diff] [blame] | 1576 | except presubmit_support.PresubmitFailure as e: |
Aaron Gable | 5d5f22c | 2018-02-02 09:12:41 -0800 | [diff] [blame] | 1577 | DieWithError('%s\nMaybe your depot_tools is out of date?' % e) |
tandrii@chromium.org | aa5ced1 | 2016-03-29 09:41:14 +0000 | [diff] [blame] | 1578 | |
tandrii@chromium.org | f86c7d3 | 2016-04-01 19:27:30 +0000 | [diff] [blame] | 1579 | def CMDPatchIssue(self, issue_arg, reject, nocommit, directory): |
| 1580 | """Fetches and applies the issue patch from codereview to local branch.""" |
tandrii@chromium.org | ef7c68c | 2016-04-07 09:39:39 +0000 | [diff] [blame] | 1581 | if isinstance(issue_arg, (int, long)) or issue_arg.isdigit(): |
| 1582 | parsed_issue_arg = _ParsedIssueNumberArgument(int(issue_arg)) |
tandrii@chromium.org | f86c7d3 | 2016-04-01 19:27:30 +0000 | [diff] [blame] | 1583 | else: |
| 1584 | # Assume url. |
| 1585 | parsed_issue_arg = self._codereview_impl.ParseIssueURL( |
| 1586 | urlparse.urlparse(issue_arg)) |
| 1587 | if not parsed_issue_arg or not parsed_issue_arg.valid: |
| 1588 | DieWithError('Failed to parse issue argument "%s". ' |
| 1589 | 'Must be an issue number or a valid URL.' % issue_arg) |
| 1590 | return self._codereview_impl.CMDPatchWithParsedIssue( |
Aaron Gable | 62619a3 | 2017-06-16 08:22:09 -0700 | [diff] [blame] | 1591 | parsed_issue_arg, reject, nocommit, directory, False) |
tandrii@chromium.org | f86c7d3 | 2016-04-01 19:27:30 +0000 | [diff] [blame] | 1592 | |
tandrii@chromium.org | 9e6c3a5 | 2016-04-12 14:13:08 +0000 | [diff] [blame] | 1593 | def CMDUpload(self, options, git_diff_args, orig_args): |
| 1594 | """Uploads a change to codereview.""" |
Andrii Shyshkalov | 9f27443 | 2018-10-15 16:40:23 +0000 | [diff] [blame] | 1595 | assert self.IsGerrit() |
Andrii Shyshkalov | 550e924 | 2017-04-12 17:14:49 +0200 | [diff] [blame] | 1596 | custom_cl_base = None |
tandrii@chromium.org | 9e6c3a5 | 2016-04-12 14:13:08 +0000 | [diff] [blame] | 1597 | if git_diff_args: |
Andrii Shyshkalov | 550e924 | 2017-04-12 17:14:49 +0200 | [diff] [blame] | 1598 | custom_cl_base = base_branch = git_diff_args[0] |
tandrii@chromium.org | 9e6c3a5 | 2016-04-12 14:13:08 +0000 | [diff] [blame] | 1599 | else: |
| 1600 | if self.GetBranch() is None: |
| 1601 | DieWithError('Can\'t upload from detached HEAD state. Get on a branch!') |
| 1602 | |
| 1603 | # Default to diffing against common ancestor of upstream branch |
| 1604 | base_branch = self.GetCommonAncestorWithUpstream() |
| 1605 | git_diff_args = [base_branch, 'HEAD'] |
| 1606 | |
Aaron Gable | c4c40d1 | 2017-05-22 11:49:53 -0700 | [diff] [blame] | 1607 | |
Andrii Shyshkalov | 3e63142 | 2017-02-16 17:46:44 +0100 | [diff] [blame] | 1608 | # Fast best-effort checks to abort before running potentially |
| 1609 | # expensive hooks if uploading is likely to fail anyway. Passing these |
| 1610 | # checks does not guarantee that uploading will not fail. |
tandrii@chromium.org | fe30f18 | 2016-04-13 12:15:04 +0000 | [diff] [blame] | 1611 | self._codereview_impl.EnsureAuthenticated(force=options.force) |
Andrii Shyshkalov | bb86fbb | 2017-03-24 14:59:28 +0100 | [diff] [blame] | 1612 | self._codereview_impl.EnsureCanUploadPatchset(force=options.force) |
tandrii@chromium.org | 9e6c3a5 | 2016-04-12 14:13:08 +0000 | [diff] [blame] | 1613 | |
| 1614 | # Apply watchlists on upload. |
| 1615 | change = self.GetChange(base_branch, None) |
| 1616 | watchlist = watchlists.Watchlists(change.RepositoryRoot()) |
| 1617 | files = [f.LocalPath() for f in change.AffectedFiles()] |
| 1618 | if not options.bypass_watchlists: |
Daniel Cheng | 7227d21 | 2017-11-17 08:12:37 -0800 | [diff] [blame] | 1619 | self.ExtendCC(watchlist.GetWatchersForPaths(files)) |
tandrii@chromium.org | 9e6c3a5 | 2016-04-12 14:13:08 +0000 | [diff] [blame] | 1620 | |
| 1621 | if not options.bypass_hooks: |
Robert Iannucci | 6c98dc6 | 2017-04-18 11:38:00 -0700 | [diff] [blame] | 1622 | if options.reviewers or options.tbrs or options.add_owners_to: |
tandrii@chromium.org | 9e6c3a5 | 2016-04-12 14:13:08 +0000 | [diff] [blame] | 1623 | # Set the reviewer list now so that presubmit checks can access it. |
| 1624 | change_description = ChangeDescription(change.FullDescriptionText()) |
| 1625 | change_description.update_reviewers(options.reviewers, |
Robert Iannucci | 6c98dc6 | 2017-04-18 11:38:00 -0700 | [diff] [blame] | 1626 | options.tbrs, |
Robert Iannucci | f2708bd | 2017-04-17 15:49:02 -0700 | [diff] [blame] | 1627 | options.add_owners_to, |
tandrii@chromium.org | 9e6c3a5 | 2016-04-12 14:13:08 +0000 | [diff] [blame] | 1628 | change) |
| 1629 | change.SetDescriptionText(change_description.description) |
| 1630 | hook_results = self.RunHook(committing=False, |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 1631 | may_prompt=not options.force, |
| 1632 | verbose=options.verbose, |
| 1633 | change=change, parallel=options.parallel) |
tandrii@chromium.org | 9e6c3a5 | 2016-04-12 14:13:08 +0000 | [diff] [blame] | 1634 | if not hook_results.should_continue(): |
| 1635 | return 1 |
| 1636 | if not options.reviewers and hook_results.reviewers: |
| 1637 | options.reviewers = hook_results.reviewers.split(',') |
Daniel Cheng | 7227d21 | 2017-11-17 08:12:37 -0800 | [diff] [blame] | 1638 | self.ExtendCC(hook_results.more_cc) |
tandrii@chromium.org | 9e6c3a5 | 2016-04-12 14:13:08 +0000 | [diff] [blame] | 1639 | |
Aaron Gable | 13101a6 | 2018-02-09 13:20:41 -0800 | [diff] [blame] | 1640 | print_stats(git_diff_args) |
Andrii Shyshkalov | 550e924 | 2017-04-12 17:14:49 +0200 | [diff] [blame] | 1641 | ret = self.CMDUploadChange(options, git_diff_args, custom_cl_base, change) |
tandrii@chromium.org | 9e6c3a5 | 2016-04-12 14:13:08 +0000 | [diff] [blame] | 1642 | if not ret: |
tandrii | 5d48c32 | 2016-08-18 16:19:37 -0700 | [diff] [blame] | 1643 | _git_set_branch_config_value('last-upload-hash', |
| 1644 | RunGit(['rev-parse', 'HEAD']).strip()) |
tandrii@chromium.org | 9e6c3a5 | 2016-04-12 14:13:08 +0000 | [diff] [blame] | 1645 | # Run post upload hooks, if specified. |
| 1646 | if settings.GetRunPostUploadHook(): |
| 1647 | presubmit_support.DoPostUploadExecuter( |
| 1648 | change, |
| 1649 | self, |
| 1650 | settings.GetRoot(), |
| 1651 | options.verbose, |
| 1652 | sys.stdout) |
| 1653 | |
| 1654 | # Upload all dependencies if specified. |
| 1655 | if options.dependencies: |
vapier | a7fbd5a | 2016-06-16 09:17:49 -0700 | [diff] [blame] | 1656 | print() |
| 1657 | print('--dependencies has been specified.') |
| 1658 | print('All dependent local branches will be re-uploaded.') |
| 1659 | print() |
tandrii@chromium.org | 9e6c3a5 | 2016-04-12 14:13:08 +0000 | [diff] [blame] | 1660 | # Remove the dependencies flag from args so that we do not end up in a |
| 1661 | # loop. |
| 1662 | orig_args.remove('--dependencies') |
| 1663 | ret = upload_branch_deps(self, orig_args) |
| 1664 | return ret |
| 1665 | |
tandrii@chromium.org | fa330e8 | 2016-04-13 17:09:52 +0000 | [diff] [blame] | 1666 | def SetCQState(self, new_state): |
Quinten Yearsley | fc5fd92 | 2017-05-31 11:50:52 -0700 | [diff] [blame] | 1667 | """Updates the CQ state for the latest patchset. |
tandrii@chromium.org | fa330e8 | 2016-04-13 17:09:52 +0000 | [diff] [blame] | 1668 | |
| 1669 | Issue must have been already uploaded and known. |
| 1670 | """ |
| 1671 | assert new_state in _CQState.ALL_STATES |
| 1672 | assert self.GetIssue() |
qyearsley | 1fdfcb6 | 2016-10-24 13:22:03 -0700 | [diff] [blame] | 1673 | try: |
Quinten Yearsley | fc5fd92 | 2017-05-31 11:50:52 -0700 | [diff] [blame] | 1674 | self._codereview_impl.SetCQState(new_state) |
qyearsley | 1fdfcb6 | 2016-10-24 13:22:03 -0700 | [diff] [blame] | 1675 | return 0 |
| 1676 | except KeyboardInterrupt: |
| 1677 | raise |
| 1678 | except: |
Quinten Yearsley | fc5fd92 | 2017-05-31 11:50:52 -0700 | [diff] [blame] | 1679 | print('WARNING: Failed to %s.\n' |
qyearsley | 1fdfcb6 | 2016-10-24 13:22:03 -0700 | [diff] [blame] | 1680 | 'Either:\n' |
Quinten Yearsley | fc5fd92 | 2017-05-31 11:50:52 -0700 | [diff] [blame] | 1681 | ' * Your project has no CQ,\n' |
| 1682 | ' * You don\'t have permission to change the CQ state,\n' |
| 1683 | ' * There\'s a bug in this code (see stack trace below).\n' |
| 1684 | 'Consider specifying which bots to trigger manually or asking your ' |
| 1685 | 'project owners for permissions or contacting Chrome Infra at:\n' |
| 1686 | 'https://www.chromium.org/infra\n\n' % |
| 1687 | ('cancel CQ' if new_state == _CQState.NONE else 'trigger CQ')) |
qyearsley | 1fdfcb6 | 2016-10-24 13:22:03 -0700 | [diff] [blame] | 1688 | # Still raise exception so that stack trace is printed. |
| 1689 | raise |
| 1690 | |
tandrii@chromium.org | aa5ced1 | 2016-03-29 09:41:14 +0000 | [diff] [blame] | 1691 | # Forward methods to codereview specific implementation. |
| 1692 | |
Aaron Gable | 636b13f | 2017-07-14 10:42:48 -0700 | [diff] [blame] | 1693 | def AddComment(self, message, publish=None): |
| 1694 | return self._codereview_impl.AddComment(message, publish=publish) |
Andrii Shyshkalov | 625986d | 2017-03-16 00:24:37 +0100 | [diff] [blame] | 1695 | |
Aaron Gable | 0ffdf2d | 2017-06-05 13:01:17 -0700 | [diff] [blame] | 1696 | def GetCommentsSummary(self, readable=True): |
Andrii Shyshkalov | d8aa49f | 2017-03-17 16:05:49 +0100 | [diff] [blame] | 1697 | """Returns list of _CommentSummary for each comment. |
| 1698 | |
Aaron Gable | 0ffdf2d | 2017-06-05 13:01:17 -0700 | [diff] [blame] | 1699 | args: |
| 1700 | readable: determines whether the output is designed for a human or a machine |
Andrii Shyshkalov | d8aa49f | 2017-03-17 16:05:49 +0100 | [diff] [blame] | 1701 | """ |
Aaron Gable | 0ffdf2d | 2017-06-05 13:01:17 -0700 | [diff] [blame] | 1702 | return self._codereview_impl.GetCommentsSummary(readable) |
Andrii Shyshkalov | d8aa49f | 2017-03-17 16:05:49 +0100 | [diff] [blame] | 1703 | |
tandrii@chromium.org | aa5ced1 | 2016-03-29 09:41:14 +0000 | [diff] [blame] | 1704 | def CloseIssue(self): |
| 1705 | return self._codereview_impl.CloseIssue() |
| 1706 | |
| 1707 | def GetStatus(self): |
| 1708 | return self._codereview_impl.GetStatus() |
| 1709 | |
| 1710 | def GetCodereviewServer(self): |
| 1711 | return self._codereview_impl.GetCodereviewServer() |
| 1712 | |
tandrii | de281ae | 2016-10-12 06:02:30 -0700 | [diff] [blame] | 1713 | def GetIssueOwner(self): |
| 1714 | """Get owner from codereview, which may differ from this checkout.""" |
| 1715 | return self._codereview_impl.GetIssueOwner() |
| 1716 | |
Edward Lemur | 707d70b | 2018-02-07 00:50:14 +0100 | [diff] [blame] | 1717 | def GetReviewers(self): |
| 1718 | return self._codereview_impl.GetReviewers() |
| 1719 | |
tandrii@chromium.org | aa5ced1 | 2016-03-29 09:41:14 +0000 | [diff] [blame] | 1720 | def GetMostRecentPatchset(self): |
| 1721 | return self._codereview_impl.GetMostRecentPatchset() |
| 1722 | |
tandrii | de281ae | 2016-10-12 06:02:30 -0700 | [diff] [blame] | 1723 | def CannotTriggerTryJobReason(self): |
Quinten Yearsley | 0c62da9 | 2017-05-31 13:39:42 -0700 | [diff] [blame] | 1724 | """Returns reason (str) if unable trigger try jobs on this CL or None.""" |
tandrii | de281ae | 2016-10-12 06:02:30 -0700 | [diff] [blame] | 1725 | return self._codereview_impl.CannotTriggerTryJobReason() |
| 1726 | |
Quinten Yearsley | 0c62da9 | 2017-05-31 13:39:42 -0700 | [diff] [blame] | 1727 | def GetTryJobProperties(self, patchset=None): |
| 1728 | """Returns dictionary of properties to launch try job.""" |
| 1729 | return self._codereview_impl.GetTryJobProperties(patchset=patchset) |
tandrii | 8c5a353 | 2016-11-04 07:52:02 -0700 | [diff] [blame] | 1730 | |
tandrii@chromium.org | aa5ced1 | 2016-03-29 09:41:14 +0000 | [diff] [blame] | 1731 | def __getattr__(self, attr): |
| 1732 | # This is because lots of untested code accesses Rietveld-specific stuff |
| 1733 | # directly, and it's hard to fix for sure. So, just let it work, and fix |
clemensh@chromium.org | cbd7dc3 | 2016-05-31 10:33:50 +0000 | [diff] [blame] | 1734 | # on a case by case basis. |
tandrii | 4d89550 | 2016-08-18 08:26:19 -0700 | [diff] [blame] | 1735 | # Note that child method defines __getattr__ as well, and forwards it here, |
| 1736 | # because _RietveldChangelistImpl is not cleaned up yet, and given |
| 1737 | # deprecation of Rietveld, it should probably be just removed. |
| 1738 | # Until that time, avoid infinite recursion by bypassing __getattr__ |
| 1739 | # of implementation class. |
| 1740 | return self._codereview_impl.__getattribute__(attr) |
tandrii@chromium.org | aa5ced1 | 2016-03-29 09:41:14 +0000 | [diff] [blame] | 1741 | |
| 1742 | |
| 1743 | class _ChangelistCodereviewBase(object): |
| 1744 | """Abstract base class encapsulating codereview specifics of a changelist.""" |
| 1745 | def __init__(self, changelist): |
| 1746 | self._changelist = changelist # instance of Changelist |
| 1747 | |
| 1748 | def __getattr__(self, attr): |
| 1749 | # Forward methods to changelist. |
| 1750 | # TODO(tandrii): maybe clean up _GerritChangelistImpl and |
| 1751 | # _RietveldChangelistImpl to avoid this hack? |
| 1752 | return getattr(self._changelist, attr) |
| 1753 | |
| 1754 | def GetStatus(self): |
| 1755 | """Apply a rough heuristic to give a simple summary of an issue's review |
| 1756 | or CQ status, assuming adherence to a common workflow. |
| 1757 | |
| 1758 | Returns None if no issue for this branch, or specific string keywords. |
| 1759 | """ |
| 1760 | raise NotImplementedError() |
| 1761 | |
| 1762 | def GetCodereviewServer(self): |
| 1763 | """Returns server URL without end slash, like "https://codereview.com".""" |
| 1764 | raise NotImplementedError() |
| 1765 | |
Kenneth Russell | 61e2ed4 | 2017-02-15 11:47:13 -0800 | [diff] [blame] | 1766 | def FetchDescription(self, force=False): |
tandrii@chromium.org | aa5ced1 | 2016-03-29 09:41:14 +0000 | [diff] [blame] | 1767 | """Fetches and returns description from the codereview server.""" |
| 1768 | raise NotImplementedError() |
| 1769 | |
tandrii | 5d48c32 | 2016-08-18 16:19:37 -0700 | [diff] [blame] | 1770 | @classmethod |
| 1771 | def IssueConfigKey(cls): |
| 1772 | """Returns branch setting storing issue number.""" |
tandrii@chromium.org | aa5ced1 | 2016-03-29 09:41:14 +0000 | [diff] [blame] | 1773 | raise NotImplementedError() |
| 1774 | |
tandrii@chromium.org | 5df290f | 2016-04-11 16:12:29 +0000 | [diff] [blame] | 1775 | @classmethod |
tandrii | 5d48c32 | 2016-08-18 16:19:37 -0700 | [diff] [blame] | 1776 | def PatchsetConfigKey(cls): |
| 1777 | """Returns branch setting storing patchset number.""" |
tandrii@chromium.org | aa5ced1 | 2016-03-29 09:41:14 +0000 | [diff] [blame] | 1778 | raise NotImplementedError() |
| 1779 | |
tandrii | 5d48c32 | 2016-08-18 16:19:37 -0700 | [diff] [blame] | 1780 | @classmethod |
| 1781 | def CodereviewServerConfigKey(cls): |
| 1782 | """Returns branch setting storing codereview server.""" |
tandrii@chromium.org | aa5ced1 | 2016-03-29 09:41:14 +0000 | [diff] [blame] | 1783 | raise NotImplementedError() |
| 1784 | |
tandrii@chromium.org | 9b7fd71 | 2016-06-01 13:45:20 +0000 | [diff] [blame] | 1785 | def _PostUnsetIssueProperties(self): |
Quinten Yearsley | 0c62da9 | 2017-05-31 13:39:42 -0700 | [diff] [blame] | 1786 | """Which branch-specific properties to erase when unsetting issue.""" |
tandrii | 5d48c32 | 2016-08-18 16:19:37 -0700 | [diff] [blame] | 1787 | return [] |
tandrii@chromium.org | 9b7fd71 | 2016-06-01 13:45:20 +0000 | [diff] [blame] | 1788 | |
tandrii@chromium.org | 37b07a7 | 2016-04-29 16:42:28 +0000 | [diff] [blame] | 1789 | def GetGerritObjForPresubmit(self): |
| 1790 | # None is valid return value, otherwise presubmit_support.GerritAccessor. |
| 1791 | return None |
| 1792 | |
dsansome | e2d6fd9 | 2016-09-08 00:10:47 -0700 | [diff] [blame] | 1793 | def UpdateDescriptionRemote(self, description, force=False): |
tandrii@chromium.org | aa5ced1 | 2016-03-29 09:41:14 +0000 | [diff] [blame] | 1794 | """Update the description on codereview site.""" |
| 1795 | raise NotImplementedError() |
| 1796 | |
Aaron Gable | 636b13f | 2017-07-14 10:42:48 -0700 | [diff] [blame] | 1797 | def AddComment(self, message, publish=None): |
Andrii Shyshkalov | 625986d | 2017-03-16 00:24:37 +0100 | [diff] [blame] | 1798 | """Posts a comment to the codereview site.""" |
| 1799 | raise NotImplementedError() |
| 1800 | |
Aaron Gable | 0ffdf2d | 2017-06-05 13:01:17 -0700 | [diff] [blame] | 1801 | def GetCommentsSummary(self, readable=True): |
Andrii Shyshkalov | d8aa49f | 2017-03-17 16:05:49 +0100 | [diff] [blame] | 1802 | raise NotImplementedError() |
| 1803 | |
tandrii@chromium.org | aa5ced1 | 2016-03-29 09:41:14 +0000 | [diff] [blame] | 1804 | def CloseIssue(self): |
| 1805 | """Closes the issue.""" |
| 1806 | raise NotImplementedError() |
| 1807 | |
tandrii@chromium.org | aa5ced1 | 2016-03-29 09:41:14 +0000 | [diff] [blame] | 1808 | def GetMostRecentPatchset(self): |
| 1809 | """Returns the most recent patchset number from the codereview site.""" |
| 1810 | raise NotImplementedError() |
| 1811 | |
tandrii@chromium.org | f86c7d3 | 2016-04-01 19:27:30 +0000 | [diff] [blame] | 1812 | def CMDPatchWithParsedIssue(self, parsed_issue_arg, reject, nocommit, |
Aaron Gable | 62619a3 | 2017-06-16 08:22:09 -0700 | [diff] [blame] | 1813 | directory, force): |
tandrii@chromium.org | f86c7d3 | 2016-04-01 19:27:30 +0000 | [diff] [blame] | 1814 | """Fetches and applies the issue. |
| 1815 | |
| 1816 | Arguments: |
| 1817 | parsed_issue_arg: instance of _ParsedIssueNumberArgument. |
| 1818 | reject: if True, reject the failed patch instead of switching to 3-way |
| 1819 | merge. Rietveld only. |
| 1820 | nocommit: do not commit the patch, thus leave the tree dirty. Rietveld |
| 1821 | only. |
| 1822 | directory: switch to directory before applying the patch. Rietveld only. |
Aaron Gable | 62619a3 | 2017-06-16 08:22:09 -0700 | [diff] [blame] | 1823 | force: if true, overwrites existing local state. |
tandrii@chromium.org | f86c7d3 | 2016-04-01 19:27:30 +0000 | [diff] [blame] | 1824 | """ |
| 1825 | raise NotImplementedError() |
| 1826 | |
| 1827 | @staticmethod |
| 1828 | def ParseIssueURL(parsed_url): |
| 1829 | """Parses url and returns instance of _ParsedIssueNumberArgument or None if |
| 1830 | failed.""" |
| 1831 | raise NotImplementedError() |
| 1832 | |
Andrii Shyshkalov | 2f8e924 | 2017-01-23 19:20:19 +0100 | [diff] [blame] | 1833 | def EnsureAuthenticated(self, force, refresh=False): |
tandrii@chromium.org | fe30f18 | 2016-04-13 12:15:04 +0000 | [diff] [blame] | 1834 | """Best effort check that user is authenticated with codereview server. |
| 1835 | |
| 1836 | Arguments: |
| 1837 | force: whether to skip confirmation questions. |
Andrii Shyshkalov | 2f8e924 | 2017-01-23 19:20:19 +0100 | [diff] [blame] | 1838 | refresh: whether to attempt to refresh credentials. Ignored if not |
| 1839 | applicable. |
tandrii@chromium.org | fe30f18 | 2016-04-13 12:15:04 +0000 | [diff] [blame] | 1840 | """ |
tandrii@chromium.org | 9e6c3a5 | 2016-04-12 14:13:08 +0000 | [diff] [blame] | 1841 | raise NotImplementedError() |
| 1842 | |
Andrii Shyshkalov | bb86fbb | 2017-03-24 14:59:28 +0100 | [diff] [blame] | 1843 | def EnsureCanUploadPatchset(self, force): |
Andrii Shyshkalov | 3e63142 | 2017-02-16 17:46:44 +0100 | [diff] [blame] | 1844 | """Best effort check that uploading isn't supposed to fail for predictable |
| 1845 | reasons. |
| 1846 | |
| 1847 | This method should raise informative exception if uploading shouldn't |
| 1848 | proceed. |
Andrii Shyshkalov | bb86fbb | 2017-03-24 14:59:28 +0100 | [diff] [blame] | 1849 | |
| 1850 | Arguments: |
| 1851 | force: whether to skip confirmation questions. |
Andrii Shyshkalov | 3e63142 | 2017-02-16 17:46:44 +0100 | [diff] [blame] | 1852 | """ |
Andrii Shyshkalov | bb86fbb | 2017-03-24 14:59:28 +0100 | [diff] [blame] | 1853 | raise NotImplementedError() |
Andrii Shyshkalov | 3e63142 | 2017-02-16 17:46:44 +0100 | [diff] [blame] | 1854 | |
Andrii Shyshkalov | 550e924 | 2017-04-12 17:14:49 +0200 | [diff] [blame] | 1855 | def CMDUploadChange(self, options, git_diff_args, custom_cl_base, change): |
tandrii@chromium.org | aa6235b | 2016-04-11 21:35:29 +0000 | [diff] [blame] | 1856 | """Uploads a change to codereview.""" |
| 1857 | raise NotImplementedError() |
| 1858 | |
tandrii@chromium.org | fa330e8 | 2016-04-13 17:09:52 +0000 | [diff] [blame] | 1859 | def SetCQState(self, new_state): |
Quinten Yearsley | 0c62da9 | 2017-05-31 13:39:42 -0700 | [diff] [blame] | 1860 | """Updates the CQ state for the latest patchset. |
tandrii@chromium.org | fa330e8 | 2016-04-13 17:09:52 +0000 | [diff] [blame] | 1861 | |
| 1862 | Issue must have been already uploaded and known. |
| 1863 | """ |
| 1864 | raise NotImplementedError() |
| 1865 | |
tandrii | e113dfd | 2016-10-11 10:20:12 -0700 | [diff] [blame] | 1866 | def CannotTriggerTryJobReason(self): |
Quinten Yearsley | 0c62da9 | 2017-05-31 13:39:42 -0700 | [diff] [blame] | 1867 | """Returns reason (str) if unable trigger try jobs on this CL or None.""" |
tandrii | e113dfd | 2016-10-11 10:20:12 -0700 | [diff] [blame] | 1868 | raise NotImplementedError() |
| 1869 | |
tandrii | de281ae | 2016-10-12 06:02:30 -0700 | [diff] [blame] | 1870 | def GetIssueOwner(self): |
| 1871 | raise NotImplementedError() |
| 1872 | |
Edward Lemur | 707d70b | 2018-02-07 00:50:14 +0100 | [diff] [blame] | 1873 | def GetReviewers(self): |
| 1874 | raise NotImplementedError() |
| 1875 | |
Quinten Yearsley | 0c62da9 | 2017-05-31 13:39:42 -0700 | [diff] [blame] | 1876 | def GetTryJobProperties(self, patchset=None): |
tandrii | de281ae | 2016-10-12 06:02:30 -0700 | [diff] [blame] | 1877 | raise NotImplementedError() |
| 1878 | |
tandrii@chromium.org | aa5ced1 | 2016-03-29 09:41:14 +0000 | [diff] [blame] | 1879 | |
tandrii@chromium.org | aa5ced1 | 2016-03-29 09:41:14 +0000 | [diff] [blame] | 1880 | class _GerritChangelistImpl(_ChangelistCodereviewBase): |
Andrii Shyshkalov | 8039be7 | 2017-01-26 09:38:18 +0100 | [diff] [blame] | 1881 | def __init__(self, changelist, auth_config=None, codereview_host=None): |
tandrii@chromium.org | aa5ced1 | 2016-03-29 09:41:14 +0000 | [diff] [blame] | 1882 | # auth_config is Rietveld thing, kept here to preserve interface only. |
| 1883 | super(_GerritChangelistImpl, self).__init__(changelist) |
| 1884 | self._change_id = None |
tandrii@chromium.org | fe30f18 | 2016-04-13 12:15:04 +0000 | [diff] [blame] | 1885 | # Lazily cached values. |
tandrii@chromium.org | fe30f18 | 2016-04-13 12:15:04 +0000 | [diff] [blame] | 1886 | self._gerrit_host = None # e.g. chromium-review.googlesource.com |
Andrii Shyshkalov | 8039be7 | 2017-01-26 09:38:18 +0100 | [diff] [blame] | 1887 | self._gerrit_server = None # e.g. https://chromium-review.googlesource.com |
Andrii Shyshkalov | 258e0a6 | 2017-01-24 16:50:57 +0100 | [diff] [blame] | 1888 | # Map from change number (issue) to its detail cache. |
| 1889 | self._detail_cache = {} |
tandrii@chromium.org | aa5ced1 | 2016-03-29 09:41:14 +0000 | [diff] [blame] | 1890 | |
Andrii Shyshkalov | 8039be7 | 2017-01-26 09:38:18 +0100 | [diff] [blame] | 1891 | if codereview_host is not None: |
| 1892 | assert not codereview_host.startswith('https://'), codereview_host |
| 1893 | self._gerrit_host = codereview_host |
| 1894 | self._gerrit_server = 'https://%s' % codereview_host |
| 1895 | |
tandrii@chromium.org | aa5ced1 | 2016-03-29 09:41:14 +0000 | [diff] [blame] | 1896 | def _GetGerritHost(self): |
| 1897 | # Lazy load of configs. |
| 1898 | self.GetCodereviewServer() |
tandrii | e32e3ea | 2016-06-22 02:52:48 -0700 | [diff] [blame] | 1899 | if self._gerrit_host and '.' not in self._gerrit_host: |
| 1900 | # Abbreviated domain like "chromium" instead of chromium.googlesource.com. |
| 1901 | # This happens for internal stuff http://crbug.com/614312. |
| 1902 | parsed = urlparse.urlparse(self.GetRemoteUrl()) |
| 1903 | if parsed.scheme == 'sso': |
Quinten Yearsley | 0c62da9 | 2017-05-31 13:39:42 -0700 | [diff] [blame] | 1904 | print('WARNING: using non-https URLs for remote is likely broken\n' |
tandrii | e32e3ea | 2016-06-22 02:52:48 -0700 | [diff] [blame] | 1905 | ' Your current remote is: %s' % self.GetRemoteUrl()) |
| 1906 | self._gerrit_host = '%s.googlesource.com' % self._gerrit_host |
| 1907 | self._gerrit_server = 'https://%s' % self._gerrit_host |
tandrii@chromium.org | aa5ced1 | 2016-03-29 09:41:14 +0000 | [diff] [blame] | 1908 | return self._gerrit_host |
| 1909 | |
tandrii@chromium.org | fe30f18 | 2016-04-13 12:15:04 +0000 | [diff] [blame] | 1910 | def _GetGitHost(self): |
| 1911 | """Returns git host to be used when uploading change to Gerrit.""" |
Edward Lemur | 298f2cf | 2019-02-22 21:40:39 +0000 | [diff] [blame] | 1912 | remote_url = self.GetRemoteUrl() |
| 1913 | if not remote_url: |
| 1914 | return None |
| 1915 | return urlparse.urlparse(remote_url).netloc |
tandrii@chromium.org | fe30f18 | 2016-04-13 12:15:04 +0000 | [diff] [blame] | 1916 | |
tandrii@chromium.org | aa5ced1 | 2016-03-29 09:41:14 +0000 | [diff] [blame] | 1917 | def GetCodereviewServer(self): |
| 1918 | if not self._gerrit_server: |
| 1919 | # If we're on a branch then get the server potentially associated |
| 1920 | # with that branch. |
| 1921 | if self.GetIssue(): |
tandrii | 5d48c32 | 2016-08-18 16:19:37 -0700 | [diff] [blame] | 1922 | self._gerrit_server = self._GitGetBranchConfigValue( |
| 1923 | self.CodereviewServerConfigKey()) |
| 1924 | if self._gerrit_server: |
| 1925 | self._gerrit_host = urlparse.urlparse(self._gerrit_server).netloc |
tandrii@chromium.org | aa5ced1 | 2016-03-29 09:41:14 +0000 | [diff] [blame] | 1926 | if not self._gerrit_server: |
| 1927 | # We assume repo to be hosted on Gerrit, and hence Gerrit server |
| 1928 | # has "-review" suffix for lowest level subdomain. |
tandrii@chromium.org | fe30f18 | 2016-04-13 12:15:04 +0000 | [diff] [blame] | 1929 | parts = self._GetGitHost().split('.') |
tandrii@chromium.org | aa5ced1 | 2016-03-29 09:41:14 +0000 | [diff] [blame] | 1930 | parts[0] = parts[0] + '-review' |
| 1931 | self._gerrit_host = '.'.join(parts) |
| 1932 | self._gerrit_server = 'https://%s' % self._gerrit_host |
| 1933 | return self._gerrit_server |
| 1934 | |
Andrii Shyshkalov | 2d0e03c | 2018-08-25 04:18:09 +0000 | [diff] [blame] | 1935 | def _GetGerritProject(self): |
Andrii Shyshkalov | 0ec9d15 | 2018-08-23 00:22:58 +0000 | [diff] [blame] | 1936 | """Returns Gerrit project name based on remote git URL.""" |
Andrii Shyshkalov | 2d0e03c | 2018-08-25 04:18:09 +0000 | [diff] [blame] | 1937 | remote_url = self.GetRemoteUrl() |
Andrii Shyshkalov | 0ec9d15 | 2018-08-23 00:22:58 +0000 | [diff] [blame] | 1938 | if remote_url is None: |
Andrii Shyshkalov | 2d0e03c | 2018-08-25 04:18:09 +0000 | [diff] [blame] | 1939 | logging.warn('can\'t detect Gerrit project.') |
| 1940 | return None |
Andrii Shyshkalov | 0ec9d15 | 2018-08-23 00:22:58 +0000 | [diff] [blame] | 1941 | project = urlparse.urlparse(remote_url).path.strip('/') |
| 1942 | if project.endswith('.git'): |
| 1943 | project = project[:-len('.git')] |
Andrii Shyshkalov | 1e82867 | 2018-08-23 22:34:37 +0000 | [diff] [blame] | 1944 | # *.googlesource.com hosts ensure that Git/Gerrit projects don't start with |
| 1945 | # 'a/' prefix, because 'a/' prefix is used to force authentication in |
| 1946 | # gitiles/git-over-https protocol. E.g., |
| 1947 | # https://chromium.googlesource.com/a/v8/v8 refers to the same repo/project |
| 1948 | # as |
| 1949 | # https://chromium.googlesource.com/v8/v8 |
| 1950 | if project.startswith('a/'): |
| 1951 | project = project[len('a/'):] |
Andrii Shyshkalov | 0ec9d15 | 2018-08-23 00:22:58 +0000 | [diff] [blame] | 1952 | return project |
| 1953 | |
Andrii Shyshkalov | d06cc78 | 2018-08-23 17:24:19 +0000 | [diff] [blame] | 1954 | def _GerritChangeIdentifier(self): |
| 1955 | """Handy method for gerrit_util.ChangeIdentifier for a given CL. |
| 1956 | |
| 1957 | Not to be confused by value of "Change-Id:" footer. |
Andrii Shyshkalov | 2d0e03c | 2018-08-25 04:18:09 +0000 | [diff] [blame] | 1958 | If Gerrit project can be determined, this will speed up Gerrit HTTP API RPC. |
Andrii Shyshkalov | d06cc78 | 2018-08-23 17:24:19 +0000 | [diff] [blame] | 1959 | """ |
Andrii Shyshkalov | 2d0e03c | 2018-08-25 04:18:09 +0000 | [diff] [blame] | 1960 | project = self._GetGerritProject() |
| 1961 | if project: |
| 1962 | return gerrit_util.ChangeIdentifier(project, self.GetIssue()) |
| 1963 | # Fall back on still unique, but less efficient change number. |
| 1964 | return str(self.GetIssue()) |
Andrii Shyshkalov | d06cc78 | 2018-08-23 17:24:19 +0000 | [diff] [blame] | 1965 | |
tandrii@chromium.org | 5df290f | 2016-04-11 16:12:29 +0000 | [diff] [blame] | 1966 | @classmethod |
tandrii | 5d48c32 | 2016-08-18 16:19:37 -0700 | [diff] [blame] | 1967 | def IssueConfigKey(cls): |
tandrii@chromium.org | 5df290f | 2016-04-11 16:12:29 +0000 | [diff] [blame] | 1968 | return 'gerritissue' |
tandrii@chromium.org | aa5ced1 | 2016-03-29 09:41:14 +0000 | [diff] [blame] | 1969 | |
tandrii | 5d48c32 | 2016-08-18 16:19:37 -0700 | [diff] [blame] | 1970 | @classmethod |
| 1971 | def PatchsetConfigKey(cls): |
| 1972 | return 'gerritpatchset' |
| 1973 | |
| 1974 | @classmethod |
| 1975 | def CodereviewServerConfigKey(cls): |
| 1976 | return 'gerritserver' |
| 1977 | |
Andrii Shyshkalov | 2f8e924 | 2017-01-23 19:20:19 +0100 | [diff] [blame] | 1978 | def EnsureAuthenticated(self, force, refresh=None): |
tandrii@chromium.org | 9e6c3a5 | 2016-04-12 14:13:08 +0000 | [diff] [blame] | 1979 | """Best effort check that user is authenticated with Gerrit server.""" |
tandrii@chromium.org | 2825353 | 2016-04-14 13:46:56 +0000 | [diff] [blame] | 1980 | if settings.GetGerritSkipEnsureAuthenticated(): |
| 1981 | # For projects with unusual authentication schemes. |
| 1982 | # See http://crbug.com/603378. |
| 1983 | return |
Vadim Shtayura | b250ec1 | 2018-10-04 00:21:08 +0000 | [diff] [blame] | 1984 | |
| 1985 | # Check presence of cookies only if using cookies-based auth method. |
| 1986 | cookie_auth = gerrit_util.Authenticator.get() |
| 1987 | if not isinstance(cookie_auth, gerrit_util.CookiesAuthenticator): |
tandrii@chromium.org | fe30f18 | 2016-04-13 12:15:04 +0000 | [diff] [blame] | 1988 | return |
Vadim Shtayura | b250ec1 | 2018-10-04 00:21:08 +0000 | [diff] [blame] | 1989 | |
| 1990 | # Lazy-loader to identify Gerrit and Git hosts. |
tandrii@chromium.org | fe30f18 | 2016-04-13 12:15:04 +0000 | [diff] [blame] | 1991 | self.GetCodereviewServer() |
| 1992 | git_host = self._GetGitHost() |
Edward Lemur | 298f2cf | 2019-02-22 21:40:39 +0000 | [diff] [blame] | 1993 | assert self._gerrit_server and self._gerrit_host and git_host |
tandrii@chromium.org | fe30f18 | 2016-04-13 12:15:04 +0000 | [diff] [blame] | 1994 | |
| 1995 | gerrit_auth = cookie_auth.get_auth_header(self._gerrit_host) |
| 1996 | git_auth = cookie_auth.get_auth_header(git_host) |
| 1997 | if gerrit_auth and git_auth: |
| 1998 | if gerrit_auth == git_auth: |
| 1999 | return |
Andrii Shyshkalov | 354e1d2 | 2017-06-09 19:31:33 +0200 | [diff] [blame] | 2000 | all_gsrc = cookie_auth.get_auth_header('d0esN0tEx1st.googlesource.com') |
tandrii@chromium.org | fe30f18 | 2016-04-13 12:15:04 +0000 | [diff] [blame] | 2001 | print(( |
Quinten Yearsley | 0c62da9 | 2017-05-31 13:39:42 -0700 | [diff] [blame] | 2002 | 'WARNING: You have different credentials for Gerrit and git hosts:\n' |
tandrii@chromium.org | fe30f18 | 2016-04-13 12:15:04 +0000 | [diff] [blame] | 2003 | ' %s\n' |
| 2004 | ' %s\n' |
Andrii Shyshkalov | 51acef9 | 2017-04-11 17:19:59 +0200 | [diff] [blame] | 2005 | ' Consider running the following command:\n' |
| 2006 | ' git cl creds-check\n' |
Andrii Shyshkalov | 354e1d2 | 2017-06-09 19:31:33 +0200 | [diff] [blame] | 2007 | ' %s\n' |
Andrii Shyshkalov | 8e4576f | 2017-05-10 15:46:53 +0200 | [diff] [blame] | 2008 | ' %s') % |
Andrii Shyshkalov | 51acef9 | 2017-04-11 17:19:59 +0200 | [diff] [blame] | 2009 | (git_host, self._gerrit_host, |
Andrii Shyshkalov | 354e1d2 | 2017-06-09 19:31:33 +0200 | [diff] [blame] | 2010 | ('Hint: delete creds for .googlesource.com' if all_gsrc else ''), |
tandrii@chromium.org | fe30f18 | 2016-04-13 12:15:04 +0000 | [diff] [blame] | 2011 | cookie_auth.get_new_password_message(git_host))) |
| 2012 | if not force: |
Andrii Shyshkalov | abc26ac | 2017-03-14 14:49:38 +0100 | [diff] [blame] | 2013 | confirm_or_exit('If you know what you are doing', action='continue') |
tandrii@chromium.org | fe30f18 | 2016-04-13 12:15:04 +0000 | [diff] [blame] | 2014 | return |
| 2015 | else: |
| 2016 | missing = ( |
Anna Henningsen | 4e89144 | 2017-07-06 21:40:58 +0200 | [diff] [blame] | 2017 | ([] if gerrit_auth else [self._gerrit_host]) + |
| 2018 | ([] if git_auth else [git_host])) |
tandrii@chromium.org | fe30f18 | 2016-04-13 12:15:04 +0000 | [diff] [blame] | 2019 | DieWithError('Credentials for the following hosts are required:\n' |
| 2020 | ' %s\n' |
| 2021 | 'These are read from %s (or legacy %s)\n' |
| 2022 | '%s' % ( |
| 2023 | '\n '.join(missing), |
| 2024 | cookie_auth.get_gitcookies_path(), |
| 2025 | cookie_auth.get_netrc_path(), |
| 2026 | cookie_auth.get_new_password_message(git_host))) |
| 2027 | |
Andrii Shyshkalov | bb86fbb | 2017-03-24 14:59:28 +0100 | [diff] [blame] | 2028 | def EnsureCanUploadPatchset(self, force): |
Andrii Shyshkalov | 3e63142 | 2017-02-16 17:46:44 +0100 | [diff] [blame] | 2029 | if not self.GetIssue(): |
| 2030 | return |
| 2031 | |
| 2032 | # Warm change details cache now to avoid RPCs later, reducing latency for |
| 2033 | # developers. |
Andrii Shyshkalov | bb86fbb | 2017-03-24 14:59:28 +0100 | [diff] [blame] | 2034 | self._GetChangeDetail( |
Andrii Shyshkalov | c4a7356 | 2018-09-25 18:40:17 +0000 | [diff] [blame] | 2035 | ['DETAILED_ACCOUNTS', 'CURRENT_REVISION', 'CURRENT_COMMIT', 'LABELS']) |
Andrii Shyshkalov | 3e63142 | 2017-02-16 17:46:44 +0100 | [diff] [blame] | 2036 | |
| 2037 | status = self._GetChangeDetail()['status'] |
| 2038 | if status in ('MERGED', 'ABANDONED'): |
| 2039 | DieWithError('Change %s has been %s, new uploads are not allowed' % |
| 2040 | (self.GetIssueURL(), |
| 2041 | 'submitted' if status == 'MERGED' else 'abandoned')) |
| 2042 | |
Vadim Shtayura | b250ec1 | 2018-10-04 00:21:08 +0000 | [diff] [blame] | 2043 | # TODO(vadimsh): For some reason the chunk of code below was skipped if |
| 2044 | # 'is_gce' is True. I'm just refactoring it to be 'skip if not cookies'. |
| 2045 | # Apparently this check is not very important? Otherwise get_auth_email |
| 2046 | # could have been added to other implementations of Authenticator. |
| 2047 | cookies_auth = gerrit_util.Authenticator.get() |
| 2048 | if not isinstance(cookies_auth, gerrit_util.CookiesAuthenticator): |
Andrii Shyshkalov | bb86fbb | 2017-03-24 14:59:28 +0100 | [diff] [blame] | 2049 | return |
Vadim Shtayura | b250ec1 | 2018-10-04 00:21:08 +0000 | [diff] [blame] | 2050 | |
| 2051 | cookies_user = cookies_auth.get_auth_email(self._GetGerritHost()) |
Andrii Shyshkalov | bb86fbb | 2017-03-24 14:59:28 +0100 | [diff] [blame] | 2052 | if self.GetIssueOwner() == cookies_user: |
| 2053 | return |
| 2054 | logging.debug('change %s owner is %s, cookies user is %s', |
| 2055 | self.GetIssue(), self.GetIssueOwner(), cookies_user) |
Quinten Yearsley | 0c62da9 | 2017-05-31 13:39:42 -0700 | [diff] [blame] | 2056 | # Maybe user has linked accounts or something like that, |
Andrii Shyshkalov | bb86fbb | 2017-03-24 14:59:28 +0100 | [diff] [blame] | 2057 | # so ask what Gerrit thinks of this user. |
| 2058 | details = gerrit_util.GetAccountDetails(self._GetGerritHost(), 'self') |
| 2059 | if details['email'] == self.GetIssueOwner(): |
| 2060 | return |
| 2061 | if not force: |
Quinten Yearsley | 0c62da9 | 2017-05-31 13:39:42 -0700 | [diff] [blame] | 2062 | print('WARNING: Change %s is owned by %s, but you authenticate to Gerrit ' |
Andrii Shyshkalov | bb86fbb | 2017-03-24 14:59:28 +0100 | [diff] [blame] | 2063 | 'as %s.\n' |
| 2064 | 'Uploading may fail due to lack of permissions.' % |
| 2065 | (self.GetIssue(), self.GetIssueOwner(), details['email'])) |
| 2066 | confirm_or_exit(action='upload') |
| 2067 | |
tandrii@chromium.org | 9b7fd71 | 2016-06-01 13:45:20 +0000 | [diff] [blame] | 2068 | def _PostUnsetIssueProperties(self): |
| 2069 | """Which branch-specific properties to erase when unsetting issue.""" |
tandrii | 5d48c32 | 2016-08-18 16:19:37 -0700 | [diff] [blame] | 2070 | return ['gerritsquashhash'] |
tandrii@chromium.org | 9b7fd71 | 2016-06-01 13:45:20 +0000 | [diff] [blame] | 2071 | |
tandrii@chromium.org | 37b07a7 | 2016-04-29 16:42:28 +0000 | [diff] [blame] | 2072 | def GetGerritObjForPresubmit(self): |
| 2073 | return presubmit_support.GerritAccessor(self._GetGerritHost()) |
| 2074 | |
tandrii@chromium.org | aa5ced1 | 2016-03-29 09:41:14 +0000 | [diff] [blame] | 2075 | def GetStatus(self): |
tandrii@chromium.org | 013a280 | 2016-03-29 09:52:33 +0000 | [diff] [blame] | 2076 | """Apply a rough heuristic to give a simple summary of an issue's review |
| 2077 | or CQ status, assuming adherence to a common workflow. |
| 2078 | |
| 2079 | Returns None if no issue for this branch, or one of the following keywords: |
Aaron Gable | 9ab38c6 | 2017-04-06 14:36:33 -0700 | [diff] [blame] | 2080 | * 'error' - error from review tool (including deleted issues) |
| 2081 | * 'unsent' - no reviewers added |
| 2082 | * 'waiting' - waiting for review |
| 2083 | * 'reply' - waiting for uploader to reply to review |
| 2084 | * 'lgtm' - Code-Review label has been set |
Andrii Shyshkalov | b8268ca | 2019-04-03 23:33:44 +0000 | [diff] [blame] | 2085 | * 'dry-run' - dry-running in the commit queue |
Aaron Gable | 9ab38c6 | 2017-04-06 14:36:33 -0700 | [diff] [blame] | 2086 | * 'commit' - in the commit queue |
| 2087 | * 'closed' - successfully submitted or abandoned |
tandrii@chromium.org | 013a280 | 2016-03-29 09:52:33 +0000 | [diff] [blame] | 2088 | """ |
| 2089 | if not self.GetIssue(): |
| 2090 | return None |
| 2091 | |
| 2092 | try: |
Aaron Gable | 9ab38c6 | 2017-04-06 14:36:33 -0700 | [diff] [blame] | 2093 | data = self._GetChangeDetail([ |
| 2094 | 'DETAILED_LABELS', 'CURRENT_REVISION', 'SUBMITTABLE']) |
Aaron Gable | a45ee11 | 2016-11-22 15:14:38 -0800 | [diff] [blame] | 2095 | except (httplib.HTTPException, GerritChangeNotExists): |
tandrii@chromium.org | 013a280 | 2016-03-29 09:52:33 +0000 | [diff] [blame] | 2096 | return 'error' |
| 2097 | |
tandrii@chromium.org | 5e1bf38 | 2016-05-17 08:43:24 +0000 | [diff] [blame] | 2098 | if data['status'] in ('ABANDONED', 'MERGED'): |
tandrii@chromium.org | 013a280 | 2016-03-29 09:52:33 +0000 | [diff] [blame] | 2099 | return 'closed' |
| 2100 | |
Andrii Shyshkalov | b8268ca | 2019-04-03 23:33:44 +0000 | [diff] [blame] | 2101 | cq_label = data['labels'].get('Commit-Queue', {}) |
| 2102 | max_cq_vote = 0 |
| 2103 | for vote in cq_label.get('all', []): |
| 2104 | max_cq_vote = max(max_cq_vote, vote.get('value', 0)) |
| 2105 | if max_cq_vote == 2: |
Aaron Gable | 9ab38c6 | 2017-04-06 14:36:33 -0700 | [diff] [blame] | 2106 | return 'commit' |
Andrii Shyshkalov | b8268ca | 2019-04-03 23:33:44 +0000 | [diff] [blame] | 2107 | if max_cq_vote == 1: |
| 2108 | return 'dry-run' |
tandrii@chromium.org | 013a280 | 2016-03-29 09:52:33 +0000 | [diff] [blame] | 2109 | |
Aaron Gable | 9ab38c6 | 2017-04-06 14:36:33 -0700 | [diff] [blame] | 2110 | if data['labels'].get('Code-Review', {}).get('approved'): |
| 2111 | return 'lgtm' |
tandrii@chromium.org | 013a280 | 2016-03-29 09:52:33 +0000 | [diff] [blame] | 2112 | |
| 2113 | if not data.get('reviewers', {}).get('REVIEWER', []): |
| 2114 | return 'unsent' |
| 2115 | |
Andrii Shyshkalov | 33e88a4 | 2017-01-27 14:45:30 +0100 | [diff] [blame] | 2116 | owner = data['owner'].get('_account_id') |
Aaron Gable | 9ab38c6 | 2017-04-06 14:36:33 -0700 | [diff] [blame] | 2117 | messages = sorted(data.get('messages', []), key=lambda m: m.get('updated')) |
| 2118 | last_message_author = messages.pop().get('author', {}) |
| 2119 | while last_message_author: |
Andrii Shyshkalov | 33e88a4 | 2017-01-27 14:45:30 +0100 | [diff] [blame] | 2120 | if last_message_author.get('email') == COMMIT_BOT_EMAIL: |
| 2121 | # Ignore replies from CQ. |
Aaron Gable | 9ab38c6 | 2017-04-06 14:36:33 -0700 | [diff] [blame] | 2122 | last_message_author = messages.pop().get('author', {}) |
Andrii Shyshkalov | 33e88a4 | 2017-01-27 14:45:30 +0100 | [diff] [blame] | 2123 | continue |
Aaron Gable | 9ab38c6 | 2017-04-06 14:36:33 -0700 | [diff] [blame] | 2124 | if last_message_author.get('_account_id') == owner: |
| 2125 | # Most recent message was by owner. |
| 2126 | return 'waiting' |
| 2127 | else: |
tandrii@chromium.org | 013a280 | 2016-03-29 09:52:33 +0000 | [diff] [blame] | 2128 | # Some reply from non-owner. |
| 2129 | return 'reply' |
Aaron Gable | 9ab38c6 | 2017-04-06 14:36:33 -0700 | [diff] [blame] | 2130 | |
| 2131 | # Somehow there are no messages even though there are reviewers. |
| 2132 | return 'unsent' |
tandrii@chromium.org | aa5ced1 | 2016-03-29 09:41:14 +0000 | [diff] [blame] | 2133 | |
| 2134 | def GetMostRecentPatchset(self): |
tandrii@chromium.org | 013a280 | 2016-03-29 09:52:33 +0000 | [diff] [blame] | 2135 | data = self._GetChangeDetail(['CURRENT_REVISION']) |
Aaron Gable | e8856ee | 2017-12-07 12:41:46 -0800 | [diff] [blame] | 2136 | patchset = data['revisions'][data['current_revision']]['_number'] |
| 2137 | self.SetPatchset(patchset) |
| 2138 | return patchset |
tandrii@chromium.org | aa5ced1 | 2016-03-29 09:41:14 +0000 | [diff] [blame] | 2139 | |
Kenneth Russell | 61e2ed4 | 2017-02-15 11:47:13 -0800 | [diff] [blame] | 2140 | def FetchDescription(self, force=False): |
| 2141 | data = self._GetChangeDetail(['CURRENT_REVISION', 'CURRENT_COMMIT'], |
| 2142 | no_cache=force) |
tandrii@chromium.org | 2d3da63 | 2016-04-25 19:23:27 +0000 | [diff] [blame] | 2143 | current_rev = data['current_revision'] |
Dan Beam | cf6df90 | 2018-11-08 01:48:37 +0000 | [diff] [blame] | 2144 | return data['revisions'][current_rev]['commit']['message'].encode( |
| 2145 | 'utf-8', 'ignore') |
tandrii@chromium.org | aa5ced1 | 2016-03-29 09:41:14 +0000 | [diff] [blame] | 2146 | |
dsansome | e2d6fd9 | 2016-09-08 00:10:47 -0700 | [diff] [blame] | 2147 | def UpdateDescriptionRemote(self, description, force=False): |
Andrii Shyshkalov | 889677c | 2018-08-28 20:43:06 +0000 | [diff] [blame] | 2148 | if gerrit_util.HasPendingChangeEdit( |
| 2149 | self._GetGerritHost(), self._GerritChangeIdentifier()): |
dsansome | e2d6fd9 | 2016-09-08 00:10:47 -0700 | [diff] [blame] | 2150 | if not force: |
Andrii Shyshkalov | abc26ac | 2017-03-14 14:49:38 +0100 | [diff] [blame] | 2151 | confirm_or_exit( |
dsansome | e2d6fd9 | 2016-09-08 00:10:47 -0700 | [diff] [blame] | 2152 | 'The description cannot be modified while the issue has a pending ' |
Andrii Shyshkalov | abc26ac | 2017-03-14 14:49:38 +0100 | [diff] [blame] | 2153 | 'unpublished edit. Either publish the edit in the Gerrit web UI ' |
| 2154 | 'or delete it.\n\n', action='delete the unpublished edit') |
dsansome | e2d6fd9 | 2016-09-08 00:10:47 -0700 | [diff] [blame] | 2155 | |
Andrii Shyshkalov | 889677c | 2018-08-28 20:43:06 +0000 | [diff] [blame] | 2156 | gerrit_util.DeletePendingChangeEdit( |
| 2157 | self._GetGerritHost(), self._GerritChangeIdentifier()) |
| 2158 | gerrit_util.SetCommitMessage( |
| 2159 | self._GetGerritHost(), self._GerritChangeIdentifier(), |
| 2160 | description, notify='NONE') |
tandrii@chromium.org | aa5ced1 | 2016-03-29 09:41:14 +0000 | [diff] [blame] | 2161 | |
Aaron Gable | 636b13f | 2017-07-14 10:42:48 -0700 | [diff] [blame] | 2162 | def AddComment(self, message, publish=None): |
Andrii Shyshkalov | 889677c | 2018-08-28 20:43:06 +0000 | [diff] [blame] | 2163 | gerrit_util.SetReview( |
| 2164 | self._GetGerritHost(), self._GerritChangeIdentifier(), |
| 2165 | msg=message, ready=publish) |
Andrii Shyshkalov | 625986d | 2017-03-16 00:24:37 +0100 | [diff] [blame] | 2166 | |
Aaron Gable | 0ffdf2d | 2017-06-05 13:01:17 -0700 | [diff] [blame] | 2167 | def GetCommentsSummary(self, readable=True): |
Andrii Shyshkalov | 5a0cf20 | 2017-03-17 16:14:59 +0100 | [diff] [blame] | 2168 | # DETAILED_ACCOUNTS is to get emails in accounts. |
Quinten Yearsley | 0e617c0 | 2019-02-20 00:37:03 +0000 | [diff] [blame] | 2169 | # CURRENT_REVISION is included to get the latest patchset so that |
| 2170 | # only the robot comments from the latest patchset can be shown. |
Aaron Gable | 0ffdf2d | 2017-06-05 13:01:17 -0700 | [diff] [blame] | 2171 | messages = self._GetChangeDetail( |
Quinten Yearsley | 0e617c0 | 2019-02-20 00:37:03 +0000 | [diff] [blame] | 2172 | options=['MESSAGES', 'DETAILED_ACCOUNTS', |
| 2173 | 'CURRENT_REVISION']).get('messages', []) |
Aaron Gable | 0ffdf2d | 2017-06-05 13:01:17 -0700 | [diff] [blame] | 2174 | file_comments = gerrit_util.GetChangeComments( |
Andrii Shyshkalov | 889677c | 2018-08-28 20:43:06 +0000 | [diff] [blame] | 2175 | self._GetGerritHost(), self._GerritChangeIdentifier()) |
Quinten Yearsley | 0e617c0 | 2019-02-20 00:37:03 +0000 | [diff] [blame] | 2176 | robot_file_comments = gerrit_util.GetChangeRobotComments( |
| 2177 | self._GetGerritHost(), self._GerritChangeIdentifier()) |
| 2178 | |
| 2179 | # Add the robot comments onto the list of comments, but only |
| 2180 | # keep those that are from the latest pachset. |
| 2181 | latest_patch_set = self.GetMostRecentPatchset() |
| 2182 | for path, robot_comments in robot_file_comments.iteritems(): |
| 2183 | line_comments = file_comments.setdefault(path, []) |
| 2184 | line_comments.extend( |
| 2185 | [c for c in robot_comments if c['patch_set'] == latest_patch_set]) |
Aaron Gable | 0ffdf2d | 2017-06-05 13:01:17 -0700 | [diff] [blame] | 2186 | |
| 2187 | # Build dictionary of file comments for easy access and sorting later. |
| 2188 | # {author+date: {path: {patchset: {line: url+message}}}} |
| 2189 | comments = collections.defaultdict( |
| 2190 | lambda: collections.defaultdict(lambda: collections.defaultdict(dict))) |
| 2191 | for path, line_comments in file_comments.iteritems(): |
| 2192 | for comment in line_comments: |
Quinten Yearsley | 0e617c0 | 2019-02-20 00:37:03 +0000 | [diff] [blame] | 2193 | tag = comment.get('tag', '') |
| 2194 | if tag.startswith('autogenerated') and 'robot_id' not in comment: |
Aaron Gable | 0ffdf2d | 2017-06-05 13:01:17 -0700 | [diff] [blame] | 2195 | continue |
| 2196 | key = (comment['author']['email'], comment['updated']) |
| 2197 | if comment.get('side', 'REVISION') == 'PARENT': |
| 2198 | patchset = 'Base' |
| 2199 | else: |
| 2200 | patchset = 'PS%d' % comment['patch_set'] |
| 2201 | line = comment.get('line', 0) |
| 2202 | url = ('https://%s/c/%s/%s/%s#%s%s' % |
| 2203 | (self._GetGerritHost(), self.GetIssue(), comment['patch_set'], path, |
| 2204 | 'b' if comment.get('side') == 'PARENT' else '', |
| 2205 | str(line) if line else '')) |
| 2206 | comments[key][path][patchset][line] = (url, comment['message']) |
| 2207 | |
Quinten Yearsley | 0e617c0 | 2019-02-20 00:37:03 +0000 | [diff] [blame] | 2208 | summaries = [] |
Aaron Gable | 0ffdf2d | 2017-06-05 13:01:17 -0700 | [diff] [blame] | 2209 | for msg in messages: |
Quinten Yearsley | 0e617c0 | 2019-02-20 00:37:03 +0000 | [diff] [blame] | 2210 | summary = self._BuildCommentSummary(msg, comments, readable) |
| 2211 | if summary: |
| 2212 | summaries.append(summary) |
| 2213 | return summaries |
Aaron Gable | 0ffdf2d | 2017-06-05 13:01:17 -0700 | [diff] [blame] | 2214 | |
Quinten Yearsley | 0e617c0 | 2019-02-20 00:37:03 +0000 | [diff] [blame] | 2215 | @staticmethod |
| 2216 | def _BuildCommentSummary(msg, comments, readable): |
| 2217 | key = (msg['author']['email'], msg['date']) |
| 2218 | # Don't bother showing autogenerated messages that don't have associated |
| 2219 | # file or line comments. this will filter out most autogenerated |
| 2220 | # messages, but will keep robot comments like those from Tricium. |
| 2221 | is_autogenerated = msg.get('tag', '').startswith('autogenerated') |
| 2222 | if is_autogenerated and not comments.get(key): |
| 2223 | return None |
| 2224 | message = msg['message'] |
| 2225 | # Gerrit spits out nanoseconds. |
| 2226 | assert len(msg['date'].split('.')[-1]) == 9 |
| 2227 | date = datetime.datetime.strptime(msg['date'][:-3], |
| 2228 | '%Y-%m-%d %H:%M:%S.%f') |
| 2229 | if key in comments: |
| 2230 | message += '\n' |
| 2231 | for path, patchsets in sorted(comments.get(key, {}).items()): |
| 2232 | if readable: |
| 2233 | message += '\n%s' % path |
| 2234 | for patchset, lines in sorted(patchsets.items()): |
| 2235 | for line, (url, content) in sorted(lines.items()): |
| 2236 | if line: |
| 2237 | line_str = 'Line %d' % line |
| 2238 | path_str = '%s:%d:' % (path, line) |
| 2239 | else: |
| 2240 | line_str = 'File comment' |
| 2241 | path_str = '%s:0:' % path |
| 2242 | if readable: |
| 2243 | message += '\n %s, %s: %s' % (patchset, line_str, url) |
| 2244 | message += '\n %s\n' % content |
| 2245 | else: |
| 2246 | message += '\n%s ' % path_str |
| 2247 | message += '\n%s\n' % content |
| 2248 | |
| 2249 | return _CommentSummary( |
| 2250 | date=date, |
| 2251 | message=message, |
| 2252 | sender=msg['author']['email'], |
| 2253 | autogenerated=is_autogenerated, |
| 2254 | # These could be inferred from the text messages and correlated with |
| 2255 | # Code-Review label maximum, however this is not reliable. |
| 2256 | # Leaving as is until the need arises. |
| 2257 | approval=False, |
| 2258 | disapproval=False, |
| 2259 | ) |
Andrii Shyshkalov | d8aa49f | 2017-03-17 16:05:49 +0100 | [diff] [blame] | 2260 | |
tandrii@chromium.org | aa5ced1 | 2016-03-29 09:41:14 +0000 | [diff] [blame] | 2261 | def CloseIssue(self): |
Andrii Shyshkalov | 889677c | 2018-08-28 20:43:06 +0000 | [diff] [blame] | 2262 | gerrit_util.AbandonChange( |
| 2263 | self._GetGerritHost(), self._GerritChangeIdentifier(), msg='') |
tandrii@chromium.org | aa5ced1 | 2016-03-29 09:41:14 +0000 | [diff] [blame] | 2264 | |
tandrii@chromium.org | d68b62b | 2016-03-31 16:09:29 +0000 | [diff] [blame] | 2265 | def SubmitIssue(self, wait_for_merge=True): |
Andrii Shyshkalov | 889677c | 2018-08-28 20:43:06 +0000 | [diff] [blame] | 2266 | gerrit_util.SubmitChange( |
| 2267 | self._GetGerritHost(), self._GerritChangeIdentifier(), |
| 2268 | wait_for_merge=wait_for_merge) |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 2269 | |
Andrii Shyshkalov | b721460 | 2018-08-22 23:20:26 +0000 | [diff] [blame] | 2270 | def _GetChangeDetail(self, options=None, no_cache=False): |
| 2271 | """Returns details of associated Gerrit change and caching results. |
Andrii Shyshkalov | 258e0a6 | 2017-01-24 16:50:57 +0100 | [diff] [blame] | 2272 | |
| 2273 | If fresh data is needed, set no_cache=True which will clear cache and |
| 2274 | thus new data will be fetched from Gerrit. |
| 2275 | """ |
tandrii@chromium.org | aa6235b | 2016-04-11 21:35:29 +0000 | [diff] [blame] | 2276 | options = options or [] |
Andrii Shyshkalov | 03e0ed2 | 2018-08-28 19:39:30 +0000 | [diff] [blame] | 2277 | assert self.GetIssue(), 'issue is required to query Gerrit' |
Andrii Shyshkalov | 258e0a6 | 2017-01-24 16:50:57 +0100 | [diff] [blame] | 2278 | |
Andrii Shyshkalov | 8039be7 | 2017-01-26 09:38:18 +0100 | [diff] [blame] | 2279 | # Optimization to avoid multiple RPCs: |
| 2280 | if (('CURRENT_REVISION' in options or 'ALL_REVISIONS' in options) and |
| 2281 | 'CURRENT_COMMIT' not in options): |
| 2282 | options.append('CURRENT_COMMIT') |
| 2283 | |
Andrii Shyshkalov | 258e0a6 | 2017-01-24 16:50:57 +0100 | [diff] [blame] | 2284 | # Normalize issue and options for consistent keys in cache. |
Andrii Shyshkalov | 03e0ed2 | 2018-08-28 19:39:30 +0000 | [diff] [blame] | 2285 | cache_key = str(self.GetIssue()) |
Andrii Shyshkalov | 258e0a6 | 2017-01-24 16:50:57 +0100 | [diff] [blame] | 2286 | options = [o.upper() for o in options] |
| 2287 | |
| 2288 | # Check in cache first unless no_cache is True. |
| 2289 | if no_cache: |
Andrii Shyshkalov | 03e0ed2 | 2018-08-28 19:39:30 +0000 | [diff] [blame] | 2290 | self._detail_cache.pop(cache_key, None) |
Andrii Shyshkalov | 258e0a6 | 2017-01-24 16:50:57 +0100 | [diff] [blame] | 2291 | else: |
| 2292 | options_set = frozenset(options) |
Andrii Shyshkalov | 03e0ed2 | 2018-08-28 19:39:30 +0000 | [diff] [blame] | 2293 | for cached_options_set, data in self._detail_cache.get(cache_key, []): |
Andrii Shyshkalov | 258e0a6 | 2017-01-24 16:50:57 +0100 | [diff] [blame] | 2294 | # Assumption: data fetched before with extra options is suitable |
| 2295 | # for return for a smaller set of options. |
| 2296 | # For example, if we cached data for |
| 2297 | # options=[CURRENT_REVISION, DETAILED_FOOTERS] |
| 2298 | # and request is for options=[CURRENT_REVISION], |
| 2299 | # THEN we can return prior cached data. |
| 2300 | if options_set.issubset(cached_options_set): |
| 2301 | return data |
| 2302 | |
Andrii Shyshkalov | c6c8b4c | 2016-11-09 20:51:20 +0100 | [diff] [blame] | 2303 | try: |
Andrii Shyshkalov | 03e0ed2 | 2018-08-28 19:39:30 +0000 | [diff] [blame] | 2304 | data = gerrit_util.GetChangeDetail( |
| 2305 | self._GetGerritHost(), self._GerritChangeIdentifier(), options) |
Andrii Shyshkalov | c6c8b4c | 2016-11-09 20:51:20 +0100 | [diff] [blame] | 2306 | except gerrit_util.GerritError as e: |
| 2307 | if e.http_status == 404: |
Andrii Shyshkalov | 03e0ed2 | 2018-08-28 19:39:30 +0000 | [diff] [blame] | 2308 | raise GerritChangeNotExists(self.GetIssue(), self.GetCodereviewServer()) |
Andrii Shyshkalov | c6c8b4c | 2016-11-09 20:51:20 +0100 | [diff] [blame] | 2309 | raise |
Andrii Shyshkalov | 258e0a6 | 2017-01-24 16:50:57 +0100 | [diff] [blame] | 2310 | |
Andrii Shyshkalov | 03e0ed2 | 2018-08-28 19:39:30 +0000 | [diff] [blame] | 2311 | self._detail_cache.setdefault(cache_key, []).append( |
| 2312 | (frozenset(options), data)) |
tandrii | c2405f5 | 2016-10-10 08:13:15 -0700 | [diff] [blame] | 2313 | return data |
tandrii@chromium.org | 013a280 | 2016-03-29 09:52:33 +0000 | [diff] [blame] | 2314 | |
Andrii Shyshkalov | cc5f17e | 2018-08-22 23:35:59 +0000 | [diff] [blame] | 2315 | def _GetChangeCommit(self): |
Andrii Shyshkalov | e263316 | 2018-08-27 23:50:31 +0000 | [diff] [blame] | 2316 | assert self.GetIssue(), 'issue must be set to query Gerrit' |
Aaron Gable | 6f5a8d9 | 2017-04-18 14:49:05 -0700 | [diff] [blame] | 2317 | try: |
Andrii Shyshkalov | e263316 | 2018-08-27 23:50:31 +0000 | [diff] [blame] | 2318 | data = gerrit_util.GetChangeCommit( |
| 2319 | self._GetGerritHost(), self._GerritChangeIdentifier()) |
Aaron Gable | 6f5a8d9 | 2017-04-18 14:49:05 -0700 | [diff] [blame] | 2320 | except gerrit_util.GerritError as e: |
| 2321 | if e.http_status == 404: |
Andrii Shyshkalov | e263316 | 2018-08-27 23:50:31 +0000 | [diff] [blame] | 2322 | raise GerritChangeNotExists(self.GetIssue(), self.GetCodereviewServer()) |
Aaron Gable | 6f5a8d9 | 2017-04-18 14:49:05 -0700 | [diff] [blame] | 2323 | raise |
agable | 32978d9 | 2016-11-01 12:55:02 -0700 | [diff] [blame] | 2324 | return data |
| 2325 | |
Karen Qian | 40c1942 | 2019-03-13 21:28:29 +0000 | [diff] [blame] | 2326 | def _IsCqConfigured(self): |
| 2327 | detail = self._GetChangeDetail(['LABELS']) |
| 2328 | if not u'Commit-Queue' in detail.get('labels', {}): |
| 2329 | return False |
| 2330 | # TODO(crbug/753213): Remove temporary hack |
| 2331 | if ('https://chromium.googlesource.com/chromium/src' == |
| 2332 | self._changelist.GetRemoteUrl() and |
| 2333 | detail['branch'].startswith('refs/branch-heads/')): |
| 2334 | return False |
| 2335 | return True |
| 2336 | |
Olivier Robin | 75ee725 | 2018-04-13 10:02:56 +0200 | [diff] [blame] | 2337 | def CMDLand(self, force, bypass_hooks, verbose, parallel): |
tandrii@chromium.org | d68b62b | 2016-03-31 16:09:29 +0000 | [diff] [blame] | 2338 | if git_common.is_dirty_git_tree('land'): |
| 2339 | return 1 |
Karen Qian | 40c1942 | 2019-03-13 21:28:29 +0000 | [diff] [blame] | 2340 | |
tandrii | d60367b | 2016-06-22 05:25:12 -0700 | [diff] [blame] | 2341 | detail = self._GetChangeDetail(['CURRENT_REVISION', 'LABELS']) |
Karen Qian | 40c1942 | 2019-03-13 21:28:29 +0000 | [diff] [blame] | 2342 | if not force and self._IsCqConfigured(): |
| 2343 | confirm_or_exit('\nIt seems this repository has a Commit Queue, ' |
Andrii Shyshkalov | abc26ac | 2017-03-14 14:49:38 +0100 | [diff] [blame] | 2344 | 'which can test and land changes for you. ' |
| 2345 | 'Are you sure you wish to bypass it?\n', |
| 2346 | action='bypass CQ') |
tandrii@chromium.org | d68b62b | 2016-03-31 16:09:29 +0000 | [diff] [blame] | 2347 | differs = True |
tandrii | c4344b5 | 2016-08-29 06:04:54 -0700 | [diff] [blame] | 2348 | last_upload = self._GitGetBranchConfigValue('gerritsquashhash') |
tandrii@chromium.org | d68b62b | 2016-03-31 16:09:29 +0000 | [diff] [blame] | 2349 | # Note: git diff outputs nothing if there is no diff. |
| 2350 | if not last_upload or RunGit(['diff', last_upload]).strip(): |
Quinten Yearsley | 0c62da9 | 2017-05-31 13:39:42 -0700 | [diff] [blame] | 2351 | print('WARNING: Some changes from local branch haven\'t been uploaded.') |
tandrii@chromium.org | d68b62b | 2016-03-31 16:09:29 +0000 | [diff] [blame] | 2352 | else: |
tandrii@chromium.org | d68b62b | 2016-03-31 16:09:29 +0000 | [diff] [blame] | 2353 | if detail['current_revision'] == last_upload: |
| 2354 | differs = False |
| 2355 | else: |
Quinten Yearsley | 0c62da9 | 2017-05-31 13:39:42 -0700 | [diff] [blame] | 2356 | print('WARNING: Local branch contents differ from latest uploaded ' |
| 2357 | 'patchset.') |
tandrii@chromium.org | d68b62b | 2016-03-31 16:09:29 +0000 | [diff] [blame] | 2358 | if differs: |
| 2359 | if not force: |
Andrii Shyshkalov | abc26ac | 2017-03-14 14:49:38 +0100 | [diff] [blame] | 2360 | confirm_or_exit( |
| 2361 | 'Do you want to submit latest Gerrit patchset and bypass hooks?\n', |
| 2362 | action='submit') |
Quinten Yearsley | 0c62da9 | 2017-05-31 13:39:42 -0700 | [diff] [blame] | 2363 | print('WARNING: Bypassing hooks and submitting latest uploaded patchset.') |
tandrii@chromium.org | d68b62b | 2016-03-31 16:09:29 +0000 | [diff] [blame] | 2364 | elif not bypass_hooks: |
| 2365 | hook_results = self.RunHook( |
| 2366 | committing=True, |
| 2367 | may_prompt=not force, |
| 2368 | verbose=verbose, |
Olivier Robin | 75ee725 | 2018-04-13 10:02:56 +0200 | [diff] [blame] | 2369 | change=self.GetChange(self.GetCommonAncestorWithUpstream(), None), |
| 2370 | parallel=parallel) |
tandrii@chromium.org | d68b62b | 2016-03-31 16:09:29 +0000 | [diff] [blame] | 2371 | if not hook_results.should_continue(): |
| 2372 | return 1 |
| 2373 | |
| 2374 | self.SubmitIssue(wait_for_merge=True) |
| 2375 | print('Issue %s has been submitted.' % self.GetIssueURL()) |
agable | 32978d9 | 2016-11-01 12:55:02 -0700 | [diff] [blame] | 2376 | links = self._GetChangeCommit().get('web_links', []) |
| 2377 | for link in links: |
Aaron Gable | 02cdbb4 | 2016-12-13 16:24:25 -0800 | [diff] [blame] | 2378 | if link.get('name') == 'gitiles' and link.get('url'): |
Quinten Yearsley | 0c62da9 | 2017-05-31 13:39:42 -0700 | [diff] [blame] | 2379 | print('Landed as: %s' % link.get('url')) |
agable | 32978d9 | 2016-11-01 12:55:02 -0700 | [diff] [blame] | 2380 | break |
tandrii@chromium.org | d68b62b | 2016-03-31 16:09:29 +0000 | [diff] [blame] | 2381 | return 0 |
| 2382 | |
tandrii@chromium.org | f86c7d3 | 2016-04-01 19:27:30 +0000 | [diff] [blame] | 2383 | def CMDPatchWithParsedIssue(self, parsed_issue_arg, reject, nocommit, |
Aaron Gable | 62619a3 | 2017-06-16 08:22:09 -0700 | [diff] [blame] | 2384 | directory, force): |
tandrii@chromium.org | f86c7d3 | 2016-04-01 19:27:30 +0000 | [diff] [blame] | 2385 | assert not reject |
tandrii@chromium.org | f86c7d3 | 2016-04-01 19:27:30 +0000 | [diff] [blame] | 2386 | assert not directory |
| 2387 | assert parsed_issue_arg.valid |
| 2388 | |
| 2389 | self._changelist.issue = parsed_issue_arg.issue |
| 2390 | |
| 2391 | if parsed_issue_arg.hostname: |
| 2392 | self._gerrit_host = parsed_issue_arg.hostname |
| 2393 | self._gerrit_server = 'https://%s' % self._gerrit_host |
| 2394 | |
tandrii | c2405f5 | 2016-10-10 08:13:15 -0700 | [diff] [blame] | 2395 | try: |
| 2396 | detail = self._GetChangeDetail(['ALL_REVISIONS']) |
Aaron Gable | a45ee11 | 2016-11-22 15:14:38 -0800 | [diff] [blame] | 2397 | except GerritChangeNotExists as e: |
tandrii | c2405f5 | 2016-10-10 08:13:15 -0700 | [diff] [blame] | 2398 | DieWithError(str(e)) |
tandrii@chromium.org | f86c7d3 | 2016-04-01 19:27:30 +0000 | [diff] [blame] | 2399 | |
| 2400 | if not parsed_issue_arg.patchset: |
| 2401 | # Use current revision by default. |
| 2402 | revision_info = detail['revisions'][detail['current_revision']] |
| 2403 | patchset = int(revision_info['_number']) |
| 2404 | else: |
| 2405 | patchset = parsed_issue_arg.patchset |
| 2406 | for revision_info in detail['revisions'].itervalues(): |
| 2407 | if int(revision_info['_number']) == parsed_issue_arg.patchset: |
| 2408 | break |
| 2409 | else: |
Aaron Gable | a45ee11 | 2016-11-22 15:14:38 -0800 | [diff] [blame] | 2410 | DieWithError('Couldn\'t find patchset %i in change %i' % |
tandrii@chromium.org | f86c7d3 | 2016-04-01 19:27:30 +0000 | [diff] [blame] | 2411 | (parsed_issue_arg.patchset, self.GetIssue())) |
| 2412 | |
Aaron Gable | 697a91b | 2018-01-19 15:20:15 -0800 | [diff] [blame] | 2413 | remote_url = self._changelist.GetRemoteUrl() |
| 2414 | if remote_url.endswith('.git'): |
| 2415 | remote_url = remote_url[:-len('.git')] |
erikchen | 0d14d0d | 2018-08-28 18:57:09 +0000 | [diff] [blame] | 2416 | remote_url = remote_url.rstrip('/') |
| 2417 | |
tandrii@chromium.org | f86c7d3 | 2016-04-01 19:27:30 +0000 | [diff] [blame] | 2418 | fetch_info = revision_info['fetch']['http'] |
erikchen | 0d14d0d | 2018-08-28 18:57:09 +0000 | [diff] [blame] | 2419 | fetch_info['url'] = fetch_info['url'].rstrip('/') |
Aaron Gable | 697a91b | 2018-01-19 15:20:15 -0800 | [diff] [blame] | 2420 | |
| 2421 | if remote_url != fetch_info['url']: |
| 2422 | DieWithError('Trying to patch a change from %s but this repo appears ' |
| 2423 | 'to be %s.' % (fetch_info['url'], remote_url)) |
| 2424 | |
tandrii@chromium.org | f86c7d3 | 2016-04-01 19:27:30 +0000 | [diff] [blame] | 2425 | RunGit(['fetch', fetch_info['url'], fetch_info['ref']]) |
Aaron Gable | 9387b4f | 2017-06-08 10:50:03 -0700 | [diff] [blame] | 2426 | |
Aaron Gable | 62619a3 | 2017-06-16 08:22:09 -0700 | [diff] [blame] | 2427 | if force: |
| 2428 | RunGit(['reset', '--hard', 'FETCH_HEAD']) |
| 2429 | print('Checked out commit for change %i patchset %i locally' % |
| 2430 | (parsed_issue_arg.issue, patchset)) |
Stefan Zager | 2d5f039 | 2017-10-10 15:17:53 -0700 | [diff] [blame] | 2431 | elif nocommit: |
| 2432 | RunGit(['cherry-pick', '--no-commit', 'FETCH_HEAD']) |
| 2433 | print('Patch applied to index.') |
Aaron Gable | 62619a3 | 2017-06-16 08:22:09 -0700 | [diff] [blame] | 2434 | else: |
Aaron Gable | 9387b4f | 2017-06-08 10:50:03 -0700 | [diff] [blame] | 2435 | RunGit(['cherry-pick', 'FETCH_HEAD']) |
| 2436 | print('Committed patch for change %i patchset %i locally.' % |
Aaron Gable | 62619a3 | 2017-06-16 08:22:09 -0700 | [diff] [blame] | 2437 | (parsed_issue_arg.issue, patchset)) |
| 2438 | print('Note: this created a local commit which does not have ' |
| 2439 | 'the same hash as the one uploaded for review. This will make ' |
| 2440 | 'uploading changes based on top of this branch difficult.\n' |
| 2441 | 'If you want to do that, use "git cl patch --force" instead.') |
| 2442 | |
Stefan Zager | d08043c | 2017-10-12 12:07:02 -0700 | [diff] [blame] | 2443 | if self.GetBranch(): |
| 2444 | self.SetIssue(parsed_issue_arg.issue) |
| 2445 | self.SetPatchset(patchset) |
| 2446 | fetched_hash = RunGit(['rev-parse', 'FETCH_HEAD']).strip() |
| 2447 | self._GitSetBranchConfigValue('last-upload-hash', fetched_hash) |
| 2448 | self._GitSetBranchConfigValue('gerritsquashhash', fetched_hash) |
| 2449 | else: |
| 2450 | print('WARNING: You are in detached HEAD state.\n' |
| 2451 | 'The patch has been applied to your checkout, but you will not be ' |
| 2452 | 'able to upload a new patch set to the gerrit issue.\n' |
| 2453 | 'Try using the \'-b\' option if you would like to work on a ' |
| 2454 | 'branch and/or upload a new patch set.') |
| 2455 | |
tandrii@chromium.org | f86c7d3 | 2016-04-01 19:27:30 +0000 | [diff] [blame] | 2456 | return 0 |
| 2457 | |
| 2458 | @staticmethod |
| 2459 | def ParseIssueURL(parsed_url): |
| 2460 | if not parsed_url.scheme or not parsed_url.scheme.startswith('http'): |
| 2461 | return None |
Aaron Gable | 01b9106 | 2017-08-24 17:48:40 -0700 | [diff] [blame] | 2462 | # Gerrit's new UI is https://domain/c/project/+/<issue_number>[/[patchset]] |
| 2463 | # But old GWT UI is https://domain/#/c/project/+/<issue_number>[/[patchset]] |
tandrii@chromium.org | f86c7d3 | 2016-04-01 19:27:30 +0000 | [diff] [blame] | 2464 | # Short urls like https://domain/<issue_number> can be used, but don't allow |
| 2465 | # specifying the patchset (you'd 404), but we allow that here. |
| 2466 | if parsed_url.path == '/': |
| 2467 | part = parsed_url.fragment |
| 2468 | else: |
| 2469 | part = parsed_url.path |
Aaron Gable | 01b9106 | 2017-08-24 17:48:40 -0700 | [diff] [blame] | 2470 | match = re.match('(/c(/.*/\+)?)?/(\d+)(/(\d+)?/?)?$', part) |
tandrii@chromium.org | f86c7d3 | 2016-04-01 19:27:30 +0000 | [diff] [blame] | 2471 | if match: |
| 2472 | return _ParsedIssueNumberArgument( |
Aaron Gable | 01b9106 | 2017-08-24 17:48:40 -0700 | [diff] [blame] | 2473 | issue=int(match.group(3)), |
| 2474 | patchset=int(match.group(5)) if match.group(5) else None, |
Andrii Shyshkalov | 90f3192 | 2017-04-10 16:10:21 +0200 | [diff] [blame] | 2475 | hostname=parsed_url.netloc, |
| 2476 | codereview='gerrit') |
tandrii@chromium.org | f86c7d3 | 2016-04-01 19:27:30 +0000 | [diff] [blame] | 2477 | return None |
| 2478 | |
tandrii | 16e0b4e | 2016-06-07 10:34:28 -0700 | [diff] [blame] | 2479 | def _GerritCommitMsgHookCheck(self, offer_removal): |
| 2480 | hook = os.path.join(settings.GetRoot(), '.git', 'hooks', 'commit-msg') |
| 2481 | if not os.path.exists(hook): |
| 2482 | return |
| 2483 | # Crude attempt to distinguish Gerrit Codereview hook from potentially |
| 2484 | # custom developer made one. |
| 2485 | data = gclient_utils.FileRead(hook) |
| 2486 | if not('From Gerrit Code Review' in data and 'add_ChangeId()' in data): |
| 2487 | return |
Quinten Yearsley | 0c62da9 | 2017-05-31 13:39:42 -0700 | [diff] [blame] | 2488 | print('WARNING: You have Gerrit commit-msg hook installed.\n' |
qyearsley | 12fa6ff | 2016-08-24 09:18:40 -0700 | [diff] [blame] | 2489 | 'It is not necessary for uploading with git cl in squash mode, ' |
tandrii | 16e0b4e | 2016-06-07 10:34:28 -0700 | [diff] [blame] | 2490 | 'and may interfere with it in subtle ways.\n' |
| 2491 | 'We recommend you remove the commit-msg hook.') |
| 2492 | if offer_removal: |
Andrii Shyshkalov | abc26ac | 2017-03-14 14:49:38 +0100 | [diff] [blame] | 2493 | if ask_for_explicit_yes('Do you want to remove it now?'): |
tandrii | 16e0b4e | 2016-06-07 10:34:28 -0700 | [diff] [blame] | 2494 | gclient_utils.rm_file_or_tree(hook) |
| 2495 | print('Gerrit commit-msg hook removed.') |
| 2496 | else: |
| 2497 | print('OK, will keep Gerrit commit-msg hook in place.') |
| 2498 | |
Edward Lemur | 0f58ae4 | 2019-04-30 17:24:12 +0000 | [diff] [blame^] | 2499 | def _RunGitPushWithTraces(self, change_desc, refspec, refspec_opts): |
| 2500 | gclient_utils.safe_makedirs(TRACES_DIR) |
| 2501 | |
| 2502 | # Create a temporary directory to store traces in. Traces will be compressed |
| 2503 | # and stored in a 'traces' dir inside depot_tools. |
| 2504 | traces_dir = tempfile.mkdtemp() |
| 2505 | trace_name = os.path.basename(traces_dir) |
| 2506 | traces_zip = os.path.join(TRACES_DIR, trace_name + '-traces') |
| 2507 | # Create a temporary dir to store git config and gitcookies in. It will be |
| 2508 | # compressed and stored next to the traces. |
| 2509 | git_info_dir = tempfile.mkdtemp() |
| 2510 | git_info_zip = os.path.join(TRACES_DIR, trace_name + '-git-info') |
| 2511 | |
| 2512 | env = os.environ.copy() |
| 2513 | env['GIT_REDACT_COOKIES'] = 'o,SSO,GSSO_Uberproxy' |
| 2514 | env['GIT_TR2_EVENT'] = os.path.join(traces_dir, 'tr2-event') |
| 2515 | env['GIT_TRACE_CURL'] = os.path.join(traces_dir, 'trace-curl') |
| 2516 | env['GIT_TRACE_CURL_NO_DATA'] = '1' |
| 2517 | env['GIT_TRACE_PACKET'] = os.path.join(traces_dir, 'trace-packet') |
| 2518 | |
| 2519 | try: |
| 2520 | push_returncode = 0 |
| 2521 | before_push = time_time() |
| 2522 | push_stdout = gclient_utils.CheckCallAndFilter( |
| 2523 | ['git', 'push', self.GetRemoteUrl(), refspec], |
| 2524 | env=env, |
| 2525 | print_stdout=True, |
| 2526 | # Flush after every line: useful for seeing progress when running as |
| 2527 | # recipe. |
| 2528 | filter_fn=lambda _: sys.stdout.flush()) |
| 2529 | except subprocess2.CalledProcessError as e: |
| 2530 | push_returncode = e.returncode |
| 2531 | DieWithError('Failed to create a change. Please examine output above ' |
| 2532 | 'for the reason of the failure.\n' |
| 2533 | 'Hint: run command below to diagnose common Git/Gerrit ' |
| 2534 | 'credential problems:\n' |
| 2535 | ' git cl creds-check\n' + |
| 2536 | TRACES_MESSAGE % (traces_zip, git_info_zip), |
| 2537 | change_desc) |
| 2538 | finally: |
| 2539 | execution_time = time_time() - before_push |
| 2540 | metrics.collector.add_repeated('sub_commands', { |
| 2541 | 'command': 'git push', |
| 2542 | 'execution_time': execution_time, |
| 2543 | 'exit_code': push_returncode, |
| 2544 | 'arguments': metrics_utils.extract_known_subcommand_args(refspec_opts), |
| 2545 | }) |
| 2546 | |
| 2547 | if push_returncode != 0: |
| 2548 | # Keep only the first 6 characters of the git hashes on the packet |
| 2549 | # trace. This greatly decreases size after compression. |
| 2550 | packet_traces = os.path.join(traces_dir, 'trace-packet') |
| 2551 | contents = gclient_utils.FileRead(packet_traces) |
| 2552 | gclient_utils.FileWrite( |
| 2553 | packet_traces, GIT_HASH_RE.sub(r'\1', contents)) |
| 2554 | shutil.make_archive(traces_zip, 'zip', traces_dir) |
| 2555 | |
| 2556 | # Collect and compress the git config and gitcookies. |
| 2557 | git_config = RunGit(['config', '-l']) |
| 2558 | gclient_utils.FileWrite( |
| 2559 | os.path.join(git_info_dir, 'git-config'), |
| 2560 | git_config) |
| 2561 | |
| 2562 | cookie_auth = gerrit_util.Authenticator.get() |
| 2563 | if isinstance(cookie_auth, gerrit_util.CookiesAuthenticator): |
| 2564 | gitcookies_path = cookie_auth.get_gitcookies_path() |
| 2565 | gitcookies = gclient_utils.FileRead(gitcookies_path) |
| 2566 | gclient_utils.FileWrite( |
| 2567 | os.path.join(git_info_dir, 'gitcookies'), |
| 2568 | GITCOOKIES_REDACT_RE.sub('REDACTED', gitcookies)) |
| 2569 | shutil.make_archive(git_info_zip, 'zip', git_info_dir) |
| 2570 | |
| 2571 | gclient_utils.rmtree(git_info_dir) |
| 2572 | gclient_utils.rmtree(traces_dir) |
| 2573 | |
| 2574 | return push_stdout |
| 2575 | |
Andrii Shyshkalov | 550e924 | 2017-04-12 17:14:49 +0200 | [diff] [blame] | 2576 | def CMDUploadChange(self, options, git_diff_args, custom_cl_base, change): |
tandrii@chromium.org | aa6235b | 2016-04-11 21:35:29 +0000 | [diff] [blame] | 2577 | """Upload the current branch to Gerrit.""" |
tandrii@chromium.org | 9e6c3a5 | 2016-04-12 14:13:08 +0000 | [diff] [blame] | 2578 | if options.squash and options.no_squash: |
| 2579 | DieWithError('Can only use one of --squash or --no-squash') |
tandrii | a60502f | 2016-06-20 02:01:53 -0700 | [diff] [blame] | 2580 | |
| 2581 | if not options.squash and not options.no_squash: |
| 2582 | # Load default for user, repo, squash=true, in this order. |
| 2583 | options.squash = settings.GetSquashGerritUploads() |
| 2584 | elif options.no_squash: |
| 2585 | options.squash = False |
tandrii | 26f3e4e | 2016-06-10 08:37:04 -0700 | [diff] [blame] | 2586 | |
tandrii@chromium.org | aa6235b | 2016-04-11 21:35:29 +0000 | [diff] [blame] | 2587 | remote, remote_branch = self.GetRemoteBranch() |
Andrii Shyshkalov | f3a20ae | 2017-01-24 21:23:57 +0100 | [diff] [blame] | 2588 | branch = GetTargetRef(remote, remote_branch, options.target_branch) |
Aaron Gable | b56ad33 | 2017-01-06 15:24:31 -0800 | [diff] [blame] | 2589 | # This may be None; default fallback value is determined in logic below. |
| 2590 | title = options.title |
| 2591 | |
Dominic Battre | 7d1c484 | 2017-10-27 09:17:28 +0200 | [diff] [blame] | 2592 | # Extract bug number from branch name. |
| 2593 | bug = options.bug |
| 2594 | match = re.match(r'(?:bug|fix)[_-]?(\d+)', self.GetBranch()) |
| 2595 | if not bug and match: |
| 2596 | bug = match.group(1) |
| 2597 | |
tandrii@chromium.org | aa6235b | 2016-04-11 21:35:29 +0000 | [diff] [blame] | 2598 | if options.squash: |
tandrii | 16e0b4e | 2016-06-07 10:34:28 -0700 | [diff] [blame] | 2599 | self._GerritCommitMsgHookCheck(offer_removal=not options.force) |
tandrii@chromium.org | aa6235b | 2016-04-11 21:35:29 +0000 | [diff] [blame] | 2600 | if self.GetIssue(): |
| 2601 | # Try to get the message from a previous upload. |
| 2602 | message = self.GetDescription() |
| 2603 | if not message: |
| 2604 | DieWithError( |
Aaron Gable | a45ee11 | 2016-11-22 15:14:38 -0800 | [diff] [blame] | 2605 | 'failed to fetch description from current Gerrit change %d\n' |
tandrii@chromium.org | aa6235b | 2016-04-11 21:35:29 +0000 | [diff] [blame] | 2606 | '%s' % (self.GetIssue(), self.GetIssueURL())) |
Aaron Gable | b56ad33 | 2017-01-06 15:24:31 -0800 | [diff] [blame] | 2607 | if not title: |
Andrii Shyshkalov | 2d8a207 | 2017-04-10 15:02:18 +0200 | [diff] [blame] | 2608 | if options.message: |
Aaron Gable | 7303dcb | 2017-06-07 14:17:32 -0700 | [diff] [blame] | 2609 | # When uploading a subsequent patchset, -m|--message is taken |
| 2610 | # as the patchset title if --title was not provided. |
| 2611 | title = options.message.strip() |
Andrii Shyshkalov | 2d8a207 | 2017-04-10 15:02:18 +0200 | [diff] [blame] | 2612 | else: |
| 2613 | default_title = RunGit( |
| 2614 | ['show', '-s', '--format=%s', 'HEAD']).strip() |
Aaron Gable | 7303dcb | 2017-06-07 14:17:32 -0700 | [diff] [blame] | 2615 | if options.force: |
| 2616 | title = default_title |
| 2617 | else: |
| 2618 | title = ask_for_data( |
| 2619 | 'Title for patchset [%s]: ' % default_title) or default_title |
tandrii@chromium.org | aa6235b | 2016-04-11 21:35:29 +0000 | [diff] [blame] | 2620 | change_id = self._GetChangeDetail()['change_id'] |
| 2621 | while True: |
| 2622 | footer_change_ids = git_footers.get_footer_change_id(message) |
| 2623 | if footer_change_ids == [change_id]: |
| 2624 | break |
| 2625 | if not footer_change_ids: |
| 2626 | message = git_footers.add_footer_change_id(message, change_id) |
Quinten Yearsley | 0c62da9 | 2017-05-31 13:39:42 -0700 | [diff] [blame] | 2627 | print('WARNING: appended missing Change-Id to change description.') |
tandrii@chromium.org | aa6235b | 2016-04-11 21:35:29 +0000 | [diff] [blame] | 2628 | continue |
| 2629 | # There is already a valid footer but with different or several ids. |
| 2630 | # Doing this automatically is non-trivial as we don't want to lose |
| 2631 | # existing other footers, yet we want to append just 1 desired |
| 2632 | # Change-Id. Thus, just create a new footer, but let user verify the |
| 2633 | # new description. |
| 2634 | message = '%s\n\nChange-Id: %s' % (message, change_id) |
| 2635 | print( |
Aaron Gable | a45ee11 | 2016-11-22 15:14:38 -0800 | [diff] [blame] | 2636 | 'WARNING: change %s has Change-Id footer(s):\n' |
tandrii@chromium.org | aa6235b | 2016-04-11 21:35:29 +0000 | [diff] [blame] | 2637 | ' %s\n' |
Aaron Gable | a45ee11 | 2016-11-22 15:14:38 -0800 | [diff] [blame] | 2638 | 'but change has Change-Id %s, according to Gerrit.\n' |
tandrii@chromium.org | aa6235b | 2016-04-11 21:35:29 +0000 | [diff] [blame] | 2639 | 'Please, check the proposed correction to the description, ' |
| 2640 | 'and edit it if necessary but keep the "Change-Id: %s" footer\n' |
| 2641 | % (self.GetIssue(), '\n '.join(footer_change_ids), change_id, |
| 2642 | change_id)) |
Andrii Shyshkalov | abc26ac | 2017-03-14 14:49:38 +0100 | [diff] [blame] | 2643 | confirm_or_exit(action='edit') |
tandrii@chromium.org | aa6235b | 2016-04-11 21:35:29 +0000 | [diff] [blame] | 2644 | if not options.force: |
| 2645 | change_desc = ChangeDescription(message) |
Dominic Battre | 7d1c484 | 2017-10-27 09:17:28 +0200 | [diff] [blame] | 2646 | change_desc.prompt(bug=bug) |
tandrii@chromium.org | aa6235b | 2016-04-11 21:35:29 +0000 | [diff] [blame] | 2647 | message = change_desc.description |
| 2648 | if not message: |
| 2649 | DieWithError("Description is empty. Aborting...") |
| 2650 | # Continue the while loop. |
| 2651 | # Sanity check of this code - we should end up with proper message |
| 2652 | # footer. |
| 2653 | assert [change_id] == git_footers.get_footer_change_id(message) |
| 2654 | change_desc = ChangeDescription(message) |
Aaron Gable | b56ad33 | 2017-01-06 15:24:31 -0800 | [diff] [blame] | 2655 | else: # if not self.GetIssue() |
| 2656 | if options.message: |
| 2657 | message = options.message |
| 2658 | else: |
Andrii Shyshkalov | b07575f | 2018-10-16 06:16:21 +0000 | [diff] [blame] | 2659 | message = _create_description_from_log(git_diff_args) |
Aaron Gable | b56ad33 | 2017-01-06 15:24:31 -0800 | [diff] [blame] | 2660 | if options.title: |
| 2661 | message = options.title + '\n\n' + message |
| 2662 | change_desc = ChangeDescription(message) |
Andrii Shyshkalov | 8c90d03 | 2017-04-19 21:27:26 +0200 | [diff] [blame] | 2663 | |
tandrii@chromium.org | aa6235b | 2016-04-11 21:35:29 +0000 | [diff] [blame] | 2664 | if not options.force: |
Dominic Battre | 7d1c484 | 2017-10-27 09:17:28 +0200 | [diff] [blame] | 2665 | change_desc.prompt(bug=bug) |
Aaron Gable | b56ad33 | 2017-01-06 15:24:31 -0800 | [diff] [blame] | 2666 | # On first upload, patchset title is always this string, while |
| 2667 | # --title flag gets converted to first line of message. |
| 2668 | title = 'Initial upload' |
tandrii@chromium.org | aa6235b | 2016-04-11 21:35:29 +0000 | [diff] [blame] | 2669 | if not change_desc.description: |
| 2670 | DieWithError("Description is empty. Aborting...") |
Andrii Shyshkalov | 8c90d03 | 2017-04-19 21:27:26 +0200 | [diff] [blame] | 2671 | change_ids = git_footers.get_footer_change_id(change_desc.description) |
tandrii@chromium.org | aa6235b | 2016-04-11 21:35:29 +0000 | [diff] [blame] | 2672 | if len(change_ids) > 1: |
| 2673 | DieWithError('too many Change-Id footers, at most 1 allowed.') |
| 2674 | if not change_ids: |
| 2675 | # Generate the Change-Id automatically. |
Andrii Shyshkalov | 8c90d03 | 2017-04-19 21:27:26 +0200 | [diff] [blame] | 2676 | change_desc.set_description(git_footers.add_footer_change_id( |
| 2677 | change_desc.description, |
| 2678 | GenerateGerritChangeId(change_desc.description))) |
| 2679 | change_ids = git_footers.get_footer_change_id(change_desc.description) |
tandrii@chromium.org | aa6235b | 2016-04-11 21:35:29 +0000 | [diff] [blame] | 2680 | assert len(change_ids) == 1 |
| 2681 | change_id = change_ids[0] |
| 2682 | |
Robert Iannucci | db02dd0 | 2017-04-19 12:18:20 -0700 | [diff] [blame] | 2683 | if options.reviewers or options.tbrs or options.add_owners_to: |
| 2684 | change_desc.update_reviewers(options.reviewers, options.tbrs, |
| 2685 | options.add_owners_to, change) |
| 2686 | |
tandrii@chromium.org | aa6235b | 2016-04-11 21:35:29 +0000 | [diff] [blame] | 2687 | remote, upstream_branch = self.FetchUpstreamTuple(self.GetBranch()) |
Andrii Shyshkalov | 550e924 | 2017-04-12 17:14:49 +0200 | [diff] [blame] | 2688 | parent = self._ComputeParent(remote, upstream_branch, custom_cl_base, |
| 2689 | options.force, change_desc) |
tandrii@chromium.org | aa6235b | 2016-04-11 21:35:29 +0000 | [diff] [blame] | 2690 | tree = RunGit(['rev-parse', 'HEAD:']).strip() |
Aaron Gable | 9a03ae0 | 2017-11-03 11:31:07 -0700 | [diff] [blame] | 2691 | with tempfile.NamedTemporaryFile(delete=False) as desc_tempfile: |
| 2692 | desc_tempfile.write(change_desc.description) |
| 2693 | desc_tempfile.close() |
| 2694 | ref_to_push = RunGit(['commit-tree', tree, '-p', parent, |
| 2695 | '-F', desc_tempfile.name]).strip() |
| 2696 | os.remove(desc_tempfile.name) |
tandrii@chromium.org | aa6235b | 2016-04-11 21:35:29 +0000 | [diff] [blame] | 2697 | else: |
| 2698 | change_desc = ChangeDescription( |
Andrii Shyshkalov | b07575f | 2018-10-16 06:16:21 +0000 | [diff] [blame] | 2699 | options.message or _create_description_from_log(git_diff_args)) |
tandrii@chromium.org | aa6235b | 2016-04-11 21:35:29 +0000 | [diff] [blame] | 2700 | if not change_desc.description: |
| 2701 | DieWithError("Description is empty. Aborting...") |
| 2702 | |
| 2703 | if not git_footers.get_footer_change_id(change_desc.description): |
| 2704 | DownloadGerritHook(False) |
Andrii Shyshkalov | 550e924 | 2017-04-12 17:14:49 +0200 | [diff] [blame] | 2705 | change_desc.set_description( |
| 2706 | self._AddChangeIdToCommitMessage(options, git_diff_args)) |
Robert Iannucci | db02dd0 | 2017-04-19 12:18:20 -0700 | [diff] [blame] | 2707 | if options.reviewers or options.tbrs or options.add_owners_to: |
| 2708 | change_desc.update_reviewers(options.reviewers, options.tbrs, |
| 2709 | options.add_owners_to, change) |
tandrii@chromium.org | aa6235b | 2016-04-11 21:35:29 +0000 | [diff] [blame] | 2710 | ref_to_push = 'HEAD' |
Andrii Shyshkalov | 550e924 | 2017-04-12 17:14:49 +0200 | [diff] [blame] | 2711 | # For no-squash mode, we assume the remote called "origin" is the one we |
| 2712 | # want. It is not worthwhile to support different workflows for |
| 2713 | # no-squash mode. |
| 2714 | parent = 'origin/%s' % branch |
tandrii@chromium.org | aa6235b | 2016-04-11 21:35:29 +0000 | [diff] [blame] | 2715 | change_id = git_footers.get_footer_change_id(change_desc.description)[0] |
| 2716 | |
| 2717 | assert change_desc |
Andrii Shyshkalov | d9fdc1f | 2018-09-27 02:13:09 +0000 | [diff] [blame] | 2718 | SaveDescriptionBackup(change_desc) |
tandrii@chromium.org | aa6235b | 2016-04-11 21:35:29 +0000 | [diff] [blame] | 2719 | commits = RunGitSilent(['rev-list', '%s..%s' % (parent, |
| 2720 | ref_to_push)]).splitlines() |
| 2721 | if len(commits) > 1: |
| 2722 | print('WARNING: This will upload %d commits. Run the following command ' |
| 2723 | 'to see which commits will be uploaded: ' % len(commits)) |
| 2724 | print('git log %s..%s' % (parent, ref_to_push)) |
| 2725 | print('You can also use `git squash-branch` to squash these into a ' |
| 2726 | 'single commit.') |
Andrii Shyshkalov | abc26ac | 2017-03-14 14:49:38 +0100 | [diff] [blame] | 2727 | confirm_or_exit(action='upload') |
tandrii@chromium.org | aa6235b | 2016-04-11 21:35:29 +0000 | [diff] [blame] | 2728 | |
Aaron Gable | 6dadfbf | 2017-05-09 14:27:58 -0700 | [diff] [blame] | 2729 | if options.reviewers or options.tbrs or options.add_owners_to: |
| 2730 | change_desc.update_reviewers(options.reviewers, options.tbrs, |
| 2731 | options.add_owners_to, change) |
| 2732 | |
Andrii Shyshkalov | 76988a8 | 2018-10-15 03:12:25 +0000 | [diff] [blame] | 2733 | reviewers = sorted(change_desc.get_reviewers()) |
| 2734 | # Add cc's from the CC_LIST and --cc flag (if any). |
| 2735 | if not options.private and not options.no_autocc: |
| 2736 | cc = self.GetCCList().split(',') |
| 2737 | else: |
| 2738 | cc = [] |
| 2739 | if options.cc: |
| 2740 | cc.extend(options.cc) |
| 2741 | cc = filter(None, [email.strip() for email in cc]) |
| 2742 | if change_desc.get_cced(): |
| 2743 | cc.extend(change_desc.get_cced()) |
Andrii Shyshkalov | 0da5e8f | 2018-10-30 17:29:18 +0000 | [diff] [blame] | 2744 | if self._GetGerritHost() == 'chromium-review.googlesource.com': |
| 2745 | valid_accounts = set(reviewers + cc) |
| 2746 | # TODO(crbug/877717): relax this for all hosts. |
| 2747 | else: |
| 2748 | valid_accounts = gerrit_util.ValidAccounts( |
| 2749 | self._GetGerritHost(), reviewers + cc) |
Andrii Shyshkalov | f170af4 | 2018-10-30 07:00:44 +0000 | [diff] [blame] | 2750 | logging.info('accounts %s are recognized, %s invalid', |
| 2751 | sorted(valid_accounts), |
| 2752 | set(reviewers + cc).difference(set(valid_accounts))) |
Andrii Shyshkalov | 76988a8 | 2018-10-15 03:12:25 +0000 | [diff] [blame] | 2753 | |
tandrii@chromium.org | bf766ba | 2016-04-13 12:51:23 +0000 | [diff] [blame] | 2754 | # Extra options that can be specified at push time. Doc: |
| 2755 | # https://gerrit-review.googlesource.com/Documentation/user-upload.html |
Andrii Shyshkalov | febbae9 | 2017-04-05 15:05:20 +0000 | [diff] [blame] | 2756 | refspec_opts = [] |
Andrii Shyshkalov | 2d8a207 | 2017-04-10 15:02:18 +0200 | [diff] [blame] | 2757 | |
Aaron Gable | 844cf29 | 2017-06-28 11:32:59 -0700 | [diff] [blame] | 2758 | # By default, new changes are started in WIP mode, and subsequent patchsets |
| 2759 | # don't send email. At any time, passing --send-mail will mark the change |
| 2760 | # ready and send email for that particular patch. |
Aaron Gable | afd5277 | 2017-06-27 16:40:10 -0700 | [diff] [blame] | 2761 | if options.send_mail: |
| 2762 | refspec_opts.append('ready') |
Aaron Gable | 844cf29 | 2017-06-28 11:32:59 -0700 | [diff] [blame] | 2763 | refspec_opts.append('notify=ALL') |
Jamie Madill | 276da0b | 2018-04-27 14:41:20 -0400 | [diff] [blame] | 2764 | elif not self.GetIssue() and options.squash: |
Nodir Turakulov | d0e2cd2 | 2017-11-15 10:22:06 -0800 | [diff] [blame] | 2765 | refspec_opts.append('wip') |
Aaron Gable | afd5277 | 2017-06-27 16:40:10 -0700 | [diff] [blame] | 2766 | else: |
Nodir Turakulov | d0e2cd2 | 2017-11-15 10:22:06 -0800 | [diff] [blame] | 2767 | refspec_opts.append('notify=NONE') |
Aaron Gable | 70f4e24 | 2017-06-26 10:45:59 -0700 | [diff] [blame] | 2768 | |
Andrii Shyshkalov | 2d8a207 | 2017-04-10 15:02:18 +0200 | [diff] [blame] | 2769 | # TODO(tandrii): options.message should be posted as a comment |
Aaron Gable | e5adf61 | 2017-07-14 10:43:58 -0700 | [diff] [blame] | 2770 | # if --send-mail is set on non-initial upload as Rietveld used to do it. |
Andrii Shyshkalov | 2d8a207 | 2017-04-10 15:02:18 +0200 | [diff] [blame] | 2771 | |
Aaron Gable | 9b713dd | 2016-12-14 16:04:21 -0800 | [diff] [blame] | 2772 | if title: |
Nick Carter | 8692b18 | 2017-11-06 16:30:38 -0800 | [diff] [blame] | 2773 | # Punctuation and whitespace in |title| must be percent-encoded. |
| 2774 | refspec_opts.append('m=' + gerrit_util.PercentEncodeForGitRef(title)) |
tandrii@chromium.org | bf766ba | 2016-04-13 12:51:23 +0000 | [diff] [blame] | 2775 | |
agable | c678797 | 2016-09-09 16:13:34 -0700 | [diff] [blame] | 2776 | if options.private: |
Aaron Gable | b02daf0 | 2017-05-23 11:53:46 -0700 | [diff] [blame] | 2777 | refspec_opts.append('private') |
agable | c678797 | 2016-09-09 16:13:34 -0700 | [diff] [blame] | 2778 | |
Andrii Shyshkalov | 2f72791 | 2018-10-15 17:02:33 +0000 | [diff] [blame] | 2779 | for r in sorted(reviewers): |
| 2780 | if r in valid_accounts: |
| 2781 | refspec_opts.append('r=%s' % r) |
| 2782 | reviewers.remove(r) |
| 2783 | else: |
| 2784 | # TODO(tandrii): this should probably be a hard failure. |
| 2785 | print('WARNING: reviewer %s doesn\'t have a Gerrit account, skipping' |
| 2786 | % r) |
| 2787 | for c in sorted(cc): |
| 2788 | # refspec option will be rejected if cc doesn't correspond to an |
| 2789 | # account, even though REST call to add such arbitrary cc may succeed. |
| 2790 | if c in valid_accounts: |
| 2791 | refspec_opts.append('cc=%s' % c) |
| 2792 | cc.remove(c) |
| 2793 | |
rmistry | 9eadede | 2016-09-19 11:22:43 -0700 | [diff] [blame] | 2794 | if options.topic: |
| 2795 | # Documentation on Gerrit topics is here: |
| 2796 | # https://gerrit-review.googlesource.com/Documentation/user-upload.html#topic |
Andrii Shyshkalov | febbae9 | 2017-04-05 15:05:20 +0000 | [diff] [blame] | 2797 | refspec_opts.append('topic=%s' % options.topic) |
rmistry | 9eadede | 2016-09-19 11:22:43 -0700 | [diff] [blame] | 2798 | |
Edward Lemur | 687ca90 | 2018-12-05 02:30:30 +0000 | [diff] [blame] | 2799 | if options.enable_auto_submit: |
| 2800 | refspec_opts.append('l=Auto-Submit+1') |
| 2801 | if options.use_commit_queue: |
| 2802 | refspec_opts.append('l=Commit-Queue+2') |
| 2803 | elif options.cq_dry_run: |
| 2804 | refspec_opts.append('l=Commit-Queue+1') |
| 2805 | |
| 2806 | if change_desc.get_reviewers(tbr_only=True): |
| 2807 | score = gerrit_util.GetCodeReviewTbrScore( |
| 2808 | self._GetGerritHost(), |
| 2809 | self._GetGerritProject()) |
| 2810 | refspec_opts.append('l=Code-Review+%s' % score) |
Andrii Shyshkalov | e7a7fc4 | 2018-10-30 17:35:09 +0000 | [diff] [blame] | 2811 | |
Nodir Turakulov | d0e2cd2 | 2017-11-15 10:22:06 -0800 | [diff] [blame] | 2812 | # Gerrit sorts hashtags, so order is not important. |
Nodir Turakulov | 23b8214 | 2017-11-16 11:04:25 -0800 | [diff] [blame] | 2813 | hashtags = {change_desc.sanitize_hash_tag(t) for t in options.hashtags} |
Nodir Turakulov | d0e2cd2 | 2017-11-15 10:22:06 -0800 | [diff] [blame] | 2814 | if not self.GetIssue(): |
Nodir Turakulov | 23b8214 | 2017-11-16 11:04:25 -0800 | [diff] [blame] | 2815 | hashtags.update(change_desc.get_hash_tags()) |
Nodir Turakulov | d0e2cd2 | 2017-11-15 10:22:06 -0800 | [diff] [blame] | 2816 | refspec_opts += ['hashtag=%s' % t for t in sorted(hashtags)] |
| 2817 | |
Andrii Shyshkalov | febbae9 | 2017-04-05 15:05:20 +0000 | [diff] [blame] | 2818 | refspec_suffix = '' |
| 2819 | if refspec_opts: |
| 2820 | refspec_suffix = '%' + ','.join(refspec_opts) |
| 2821 | assert ' ' not in refspec_suffix, ( |
| 2822 | 'spaces not allowed in refspec: "%s"' % refspec_suffix) |
| 2823 | refspec = '%s:refs/for/%s%s' % (ref_to_push, branch, refspec_suffix) |
| 2824 | |
Edward Lemur | 0f58ae4 | 2019-04-30 17:24:12 +0000 | [diff] [blame^] | 2825 | push_stdout = self._RunGitPushWithTraces(change_desc, refspec, refspec_opts) |
tandrii@chromium.org | aa6235b | 2016-04-11 21:35:29 +0000 | [diff] [blame] | 2826 | |
| 2827 | if options.squash: |
Aaron Gable | 289b431 | 2017-09-13 14:06:16 -0700 | [diff] [blame] | 2828 | regex = re.compile(r'remote:\s+https?://[\w\-\.\+\/#]*/(\d+)\s.*') |
tandrii@chromium.org | aa6235b | 2016-04-11 21:35:29 +0000 | [diff] [blame] | 2829 | change_numbers = [m.group(1) |
| 2830 | for m in map(regex.match, push_stdout.splitlines()) |
| 2831 | if m] |
| 2832 | if len(change_numbers) != 1: |
| 2833 | DieWithError( |
| 2834 | ('Created|Updated %d issues on Gerrit, but only 1 expected.\n' |
Christopher Lam | f732cd5 | 2017-01-24 12:40:11 +1100 | [diff] [blame] | 2835 | 'Change-Id: %s') % (len(change_numbers), change_id), change_desc) |
tandrii@chromium.org | aa6235b | 2016-04-11 21:35:29 +0000 | [diff] [blame] | 2836 | self.SetIssue(change_numbers[0]) |
tandrii | 5d48c32 | 2016-08-18 16:19:37 -0700 | [diff] [blame] | 2837 | self._GitSetBranchConfigValue('gerritsquashhash', ref_to_push) |
tandrii | 8818977 | 2016-09-29 04:29:57 -0700 | [diff] [blame] | 2838 | |
Andrii Shyshkalov | 2f72791 | 2018-10-15 17:02:33 +0000 | [diff] [blame] | 2839 | if self.GetIssue() and (reviewers or cc): |
Andrii Shyshkalov | 0ec9d15 | 2018-08-23 00:22:58 +0000 | [diff] [blame] | 2840 | # GetIssue() is not set in case of non-squash uploads according to tests. |
| 2841 | # TODO(agable): non-squash uploads in git cl should be removed. |
| 2842 | gerrit_util.AddReviewers( |
| 2843 | self._GetGerritHost(), |
Andrii Shyshkalov | d06cc78 | 2018-08-23 17:24:19 +0000 | [diff] [blame] | 2844 | self._GerritChangeIdentifier(), |
Andrii Shyshkalov | 0ec9d15 | 2018-08-23 00:22:58 +0000 | [diff] [blame] | 2845 | reviewers, cc, |
| 2846 | notify=bool(options.send_mail)) |
Aaron Gable | 6dadfbf | 2017-05-09 14:27:58 -0700 | [diff] [blame] | 2847 | |
tandrii@chromium.org | aa6235b | 2016-04-11 21:35:29 +0000 | [diff] [blame] | 2848 | return 0 |
| 2849 | |
Andrii Shyshkalov | 550e924 | 2017-04-12 17:14:49 +0200 | [diff] [blame] | 2850 | def _ComputeParent(self, remote, upstream_branch, custom_cl_base, force, |
| 2851 | change_desc): |
| 2852 | """Computes parent of the generated commit to be uploaded to Gerrit. |
| 2853 | |
| 2854 | Returns revision or a ref name. |
| 2855 | """ |
| 2856 | if custom_cl_base: |
| 2857 | # Try to avoid creating additional unintended CLs when uploading, unless |
| 2858 | # user wants to take this risk. |
| 2859 | local_ref_of_target_remote = self.GetRemoteBranch()[1] |
| 2860 | code, _ = RunGitWithCode(['merge-base', '--is-ancestor', custom_cl_base, |
| 2861 | local_ref_of_target_remote]) |
| 2862 | if code == 1: |
Quinten Yearsley | 0c62da9 | 2017-05-31 13:39:42 -0700 | [diff] [blame] | 2863 | print('\nWARNING: Manually specified base of this CL `%s` ' |
Andrii Shyshkalov | 550e924 | 2017-04-12 17:14:49 +0200 | [diff] [blame] | 2864 | 'doesn\'t seem to belong to target remote branch `%s`.\n\n' |
| 2865 | 'If you proceed with upload, more than 1 CL may be created by ' |
| 2866 | 'Gerrit as a result, in turn confusing or crashing git cl.\n\n' |
| 2867 | 'If you are certain that specified base `%s` has already been ' |
| 2868 | 'uploaded to Gerrit as another CL, you may proceed.\n' % |
| 2869 | (custom_cl_base, local_ref_of_target_remote, custom_cl_base)) |
| 2870 | if not force: |
| 2871 | confirm_or_exit( |
| 2872 | 'Do you take responsibility for cleaning up potential mess ' |
| 2873 | 'resulting from proceeding with upload?', |
| 2874 | action='upload') |
| 2875 | return custom_cl_base |
| 2876 | |
Aaron Gable | f97e33d | 2017-03-30 15:44:27 -0700 | [diff] [blame] | 2877 | if remote != '.': |
| 2878 | return self.GetCommonAncestorWithUpstream() |
| 2879 | |
| 2880 | # If our upstream branch is local, we base our squashed commit on its |
| 2881 | # squashed version. |
| 2882 | upstream_branch_name = scm.GIT.ShortBranchName(upstream_branch) |
| 2883 | |
Aaron Gable | f97e33d | 2017-03-30 15:44:27 -0700 | [diff] [blame] | 2884 | if upstream_branch_name == 'master': |
Aaron Gable | 0bbd1c2 | 2017-05-08 14:37:08 -0700 | [diff] [blame] | 2885 | return self.GetCommonAncestorWithUpstream() |
Aaron Gable | f97e33d | 2017-03-30 15:44:27 -0700 | [diff] [blame] | 2886 | |
| 2887 | # Check the squashed hash of the parent. |
Andrii Shyshkalov | 550e924 | 2017-04-12 17:14:49 +0200 | [diff] [blame] | 2888 | # TODO(tandrii): consider checking parent change in Gerrit and using its |
| 2889 | # hash if tree hash of latest parent revision (patchset) in Gerrit matches |
| 2890 | # the tree hash of the parent branch. The upside is less likely bogus |
| 2891 | # requests to reupload parent change just because it's uploadhash is |
| 2892 | # missing, yet the downside likely exists, too (albeit unknown to me yet). |
Aaron Gable | f97e33d | 2017-03-30 15:44:27 -0700 | [diff] [blame] | 2893 | parent = RunGit(['config', |
| 2894 | 'branch.%s.gerritsquashhash' % upstream_branch_name], |
| 2895 | error_ok=True).strip() |
| 2896 | # Verify that the upstream branch has been uploaded too, otherwise |
| 2897 | # Gerrit will create additional CLs when uploading. |
| 2898 | if not parent or (RunGitSilent(['rev-parse', upstream_branch + ':']) != |
| 2899 | RunGitSilent(['rev-parse', parent + ':'])): |
| 2900 | DieWithError( |
| 2901 | '\nUpload upstream branch %s first.\n' |
| 2902 | 'It is likely that this branch has been rebased since its last ' |
| 2903 | 'upload, so you just need to upload it again.\n' |
| 2904 | '(If you uploaded it with --no-squash, then branch dependencies ' |
| 2905 | 'are not supported, and you should reupload with --squash.)' |
| 2906 | % upstream_branch_name, |
| 2907 | change_desc) |
| 2908 | return parent |
| 2909 | |
tandrii@chromium.org | 8930b3d | 2016-04-13 14:47:02 +0000 | [diff] [blame] | 2910 | def _AddChangeIdToCommitMessage(self, options, args): |
| 2911 | """Re-commits using the current message, assumes the commit hook is in |
| 2912 | place. |
| 2913 | """ |
Andrii Shyshkalov | b07575f | 2018-10-16 06:16:21 +0000 | [diff] [blame] | 2914 | log_desc = options.message or _create_description_from_log(args) |
tandrii@chromium.org | 8930b3d | 2016-04-13 14:47:02 +0000 | [diff] [blame] | 2915 | git_command = ['commit', '--amend', '-m', log_desc] |
| 2916 | RunGit(git_command) |
Andrii Shyshkalov | b07575f | 2018-10-16 06:16:21 +0000 | [diff] [blame] | 2917 | new_log_desc = _create_description_from_log(args) |
tandrii@chromium.org | 8930b3d | 2016-04-13 14:47:02 +0000 | [diff] [blame] | 2918 | if git_footers.get_footer_change_id(new_log_desc): |
vapier | a7fbd5a | 2016-06-16 09:17:49 -0700 | [diff] [blame] | 2919 | print('git-cl: Added Change-Id to commit message.') |
tandrii@chromium.org | 8930b3d | 2016-04-13 14:47:02 +0000 | [diff] [blame] | 2920 | return new_log_desc |
| 2921 | else: |
tandrii@chromium.org | b067ec5 | 2016-05-31 15:24:44 +0000 | [diff] [blame] | 2922 | DieWithError('ERROR: Gerrit commit-msg hook not installed.') |
tandrii@chromium.org | aa6235b | 2016-04-11 21:35:29 +0000 | [diff] [blame] | 2923 | |
tandrii@chromium.org | fa330e8 | 2016-04-13 17:09:52 +0000 | [diff] [blame] | 2924 | def SetCQState(self, new_state): |
| 2925 | """Sets the Commit-Queue label assuming canonical CQ config for Gerrit.""" |
tandrii@chromium.org | fa330e8 | 2016-04-13 17:09:52 +0000 | [diff] [blame] | 2926 | vote_map = { |
| 2927 | _CQState.NONE: 0, |
| 2928 | _CQState.DRY_RUN: 1, |
Andrii Shyshkalov | 1897532 | 2017-01-25 16:44:13 +0100 | [diff] [blame] | 2929 | _CQState.COMMIT: 2, |
tandrii@chromium.org | fa330e8 | 2016-04-13 17:09:52 +0000 | [diff] [blame] | 2930 | } |
Aaron Gable | fc62f76 | 2017-07-17 11:12:07 -0700 | [diff] [blame] | 2931 | labels = {'Commit-Queue': vote_map[new_state]} |
| 2932 | notify = False if new_state == _CQState.DRY_RUN else None |
Andrii Shyshkalov | 889677c | 2018-08-28 20:43:06 +0000 | [diff] [blame] | 2933 | gerrit_util.SetReview( |
| 2934 | self._GetGerritHost(), self._GerritChangeIdentifier(), |
| 2935 | labels=labels, notify=notify) |
tandrii@chromium.org | fa330e8 | 2016-04-13 17:09:52 +0000 | [diff] [blame] | 2936 | |
tandrii | e113dfd | 2016-10-11 10:20:12 -0700 | [diff] [blame] | 2937 | def CannotTriggerTryJobReason(self): |
tandrii | 8c5a353 | 2016-11-04 07:52:02 -0700 | [diff] [blame] | 2938 | try: |
| 2939 | data = self._GetChangeDetail() |
Aaron Gable | a45ee11 | 2016-11-22 15:14:38 -0800 | [diff] [blame] | 2940 | except GerritChangeNotExists: |
| 2941 | return 'Gerrit doesn\'t know about your change %s' % self.GetIssue() |
tandrii | 8c5a353 | 2016-11-04 07:52:02 -0700 | [diff] [blame] | 2942 | |
| 2943 | if data['status'] in ('ABANDONED', 'MERGED'): |
| 2944 | return 'CL %s is closed' % self.GetIssue() |
| 2945 | |
Quinten Yearsley | 0c62da9 | 2017-05-31 13:39:42 -0700 | [diff] [blame] | 2946 | def GetTryJobProperties(self, patchset=None): |
| 2947 | """Returns dictionary of properties to launch try job.""" |
tandrii | 8c5a353 | 2016-11-04 07:52:02 -0700 | [diff] [blame] | 2948 | data = self._GetChangeDetail(['ALL_REVISIONS']) |
| 2949 | patchset = int(patchset or self.GetPatchset()) |
| 2950 | assert patchset |
| 2951 | revision_data = None # Pylint wants it to be defined. |
| 2952 | for revision_data in data['revisions'].itervalues(): |
| 2953 | if int(revision_data['_number']) == patchset: |
| 2954 | break |
| 2955 | else: |
Aaron Gable | a45ee11 | 2016-11-22 15:14:38 -0800 | [diff] [blame] | 2956 | raise Exception('Patchset %d is not known in Gerrit change %d' % |
tandrii | 8c5a353 | 2016-11-04 07:52:02 -0700 | [diff] [blame] | 2957 | (patchset, self.GetIssue())) |
| 2958 | return { |
| 2959 | 'patch_issue': self.GetIssue(), |
| 2960 | 'patch_set': patchset or self.GetPatchset(), |
| 2961 | 'patch_project': data['project'], |
| 2962 | 'patch_storage': 'gerrit', |
| 2963 | 'patch_ref': revision_data['fetch']['http']['ref'], |
| 2964 | 'patch_repository_url': revision_data['fetch']['http']['url'], |
| 2965 | 'patch_gerrit_url': self.GetCodereviewServer(), |
| 2966 | } |
tandrii | e113dfd | 2016-10-11 10:20:12 -0700 | [diff] [blame] | 2967 | |
tandrii | de281ae | 2016-10-12 06:02:30 -0700 | [diff] [blame] | 2968 | def GetIssueOwner(self): |
tandrii | 8c5a353 | 2016-11-04 07:52:02 -0700 | [diff] [blame] | 2969 | return self._GetChangeDetail(['DETAILED_ACCOUNTS'])['owner']['email'] |
tandrii | de281ae | 2016-10-12 06:02:30 -0700 | [diff] [blame] | 2970 | |
Edward Lemur | 707d70b | 2018-02-07 00:50:14 +0100 | [diff] [blame] | 2971 | def GetReviewers(self): |
| 2972 | details = self._GetChangeDetail(['DETAILED_ACCOUNTS']) |
Mohamed Heikal | 171c074 | 2018-11-09 20:38:51 +0000 | [diff] [blame] | 2973 | return [r['email'] for r in details['reviewers'].get('REVIEWER', [])] |
Edward Lemur | 707d70b | 2018-02-07 00:50:14 +0100 | [diff] [blame] | 2974 | |
tandrii@chromium.org | d68b62b | 2016-03-31 16:09:29 +0000 | [diff] [blame] | 2975 | |
| 2976 | _CODEREVIEW_IMPLEMENTATIONS = { |
tandrii@chromium.org | d68b62b | 2016-03-31 16:09:29 +0000 | [diff] [blame] | 2977 | 'gerrit': _GerritChangelistImpl, |
| 2978 | } |
| 2979 | |
tandrii@chromium.org | 013a280 | 2016-03-29 09:52:33 +0000 | [diff] [blame] | 2980 | |
iannucci | e53c935 | 2016-08-17 14:40:40 -0700 | [diff] [blame] | 2981 | def _add_codereview_issue_select_options(parser, extra=""): |
| 2982 | _add_codereview_select_options(parser) |
| 2983 | |
| 2984 | text = ('Operate on this issue number instead of the current branch\'s ' |
| 2985 | 'implicit issue.') |
| 2986 | if extra: |
| 2987 | text += ' '+extra |
| 2988 | parser.add_option('-i', '--issue', type=int, help=text) |
| 2989 | |
| 2990 | |
| 2991 | def _process_codereview_issue_select_options(parser, options): |
| 2992 | _process_codereview_select_options(parser, options) |
| 2993 | if options.issue is not None and not options.forced_codereview: |
| 2994 | parser.error('--issue must be specified with either --rietveld or --gerrit') |
| 2995 | |
| 2996 | |
tandrii@chromium.org | dde6462 | 2016-04-13 17:11:21 +0000 | [diff] [blame] | 2997 | def _add_codereview_select_options(parser): |
| 2998 | """Appends --gerrit and --rietveld options to force specific codereview.""" |
| 2999 | parser.codereview_group = optparse.OptionGroup( |
| 3000 | parser, 'EXPERIMENTAL! Codereview override options') |
| 3001 | parser.add_option_group(parser.codereview_group) |
| 3002 | parser.codereview_group.add_option( |
| 3003 | '--gerrit', action='store_true', |
| 3004 | help='Force the use of Gerrit for codereview') |
| 3005 | parser.codereview_group.add_option( |
| 3006 | '--rietveld', action='store_true', |
| 3007 | help='Force the use of Rietveld for codereview') |
| 3008 | |
| 3009 | |
| 3010 | def _process_codereview_select_options(parser, options): |
Andrii Shyshkalov | feec80e | 2018-10-16 01:00:47 +0000 | [diff] [blame] | 3011 | if options.rietveld: |
| 3012 | parser.error('--rietveld is no longer supported') |
tandrii@chromium.org | dde6462 | 2016-04-13 17:11:21 +0000 | [diff] [blame] | 3013 | options.forced_codereview = None |
| 3014 | if options.gerrit: |
| 3015 | options.forced_codereview = 'gerrit' |
tandrii@chromium.org | dde6462 | 2016-04-13 17:11:21 +0000 | [diff] [blame] | 3016 | |
| 3017 | |
tandrii | f9aefb7 | 2016-07-01 09:06:51 -0700 | [diff] [blame] | 3018 | def _get_bug_line_values(default_project, bugs): |
| 3019 | """Given default_project and comma separated list of bugs, yields bug line |
| 3020 | values. |
| 3021 | |
| 3022 | Each bug can be either: |
| 3023 | * a number, which is combined with default_project |
| 3024 | * string, which is left as is. |
| 3025 | |
| 3026 | This function may produce more than one line, because bugdroid expects one |
| 3027 | project per line. |
| 3028 | |
| 3029 | >>> list(_get_bug_line_values('v8', '123,chromium:789')) |
| 3030 | ['v8:123', 'chromium:789'] |
| 3031 | """ |
| 3032 | default_bugs = [] |
| 3033 | others = [] |
| 3034 | for bug in bugs.split(','): |
| 3035 | bug = bug.strip() |
| 3036 | if bug: |
| 3037 | try: |
| 3038 | default_bugs.append(int(bug)) |
| 3039 | except ValueError: |
| 3040 | others.append(bug) |
| 3041 | |
| 3042 | if default_bugs: |
| 3043 | default_bugs = ','.join(map(str, default_bugs)) |
| 3044 | if default_project: |
| 3045 | yield '%s:%s' % (default_project, default_bugs) |
| 3046 | else: |
| 3047 | yield default_bugs |
| 3048 | for other in sorted(others): |
| 3049 | # Don't bother finding common prefixes, CLs with >2 bugs are very very rare. |
| 3050 | yield other |
| 3051 | |
| 3052 | |
dpranke@chromium.org | 20254fc | 2011-03-22 18:28:59 +0000 | [diff] [blame] | 3053 | class ChangeDescription(object): |
| 3054 | """Contains a parsed form of the change description.""" |
maruel@chromium.org | c6f60e8 | 2013-04-19 17:01:57 +0000 | [diff] [blame] | 3055 | R_LINE = r'^[ \t]*(TBR|R)[ \t]*=[ \t]*(.*?)[ \t]*$' |
bradnelson | d975b30 | 2016-10-23 12:20:23 -0700 | [diff] [blame] | 3056 | CC_LINE = r'^[ \t]*(CC)[ \t]*=[ \t]*(.*?)[ \t]*$' |
Aaron Gable | 3a16ed1 | 2017-03-23 10:51:55 -0700 | [diff] [blame] | 3057 | BUG_LINE = r'^[ \t]*(?:(BUG)[ \t]*=|Bug:)[ \t]*(.*?)[ \t]*$' |
Andrii Shyshkalov | 15e50cc | 2016-12-02 14:34:08 +0100 | [diff] [blame] | 3058 | CHERRY_PICK_LINE = r'^\(cherry picked from commit [a-fA-F0-9]{40}\)$' |
Nodir Turakulov | 23b8214 | 2017-11-16 11:04:25 -0800 | [diff] [blame] | 3059 | STRIP_HASH_TAG_PREFIX = r'^(\s*(revert|reland)( "|:)?\s*)*' |
| 3060 | BRACKET_HASH_TAG = r'\s*\[([^\[\]]+)\]' |
| 3061 | COLON_SEPARATED_HASH_TAG = r'^([a-zA-Z0-9_\- ]+):' |
| 3062 | BAD_HASH_TAG_CHUNK = r'[^a-zA-Z0-9]+' |
dpranke@chromium.org | 20254fc | 2011-03-22 18:28:59 +0000 | [diff] [blame] | 3063 | |
maruel@chromium.org | 78936cb | 2013-04-11 00:17:52 +0000 | [diff] [blame] | 3064 | def __init__(self, description): |
agable@chromium.org | 42c2079 | 2013-09-12 17:34:49 +0000 | [diff] [blame] | 3065 | self._description_lines = (description or '').strip().splitlines() |
maruel@chromium.org | 78936cb | 2013-04-11 00:17:52 +0000 | [diff] [blame] | 3066 | |
agable@chromium.org | 42c2079 | 2013-09-12 17:34:49 +0000 | [diff] [blame] | 3067 | @property # www.logilab.org/ticket/89786 |
Quinten Yearsley | b2cc4a9 | 2016-12-15 13:53:26 -0800 | [diff] [blame] | 3068 | def description(self): # pylint: disable=method-hidden |
agable@chromium.org | 42c2079 | 2013-09-12 17:34:49 +0000 | [diff] [blame] | 3069 | return '\n'.join(self._description_lines) |
| 3070 | |
| 3071 | def set_description(self, desc): |
| 3072 | if isinstance(desc, basestring): |
| 3073 | lines = desc.splitlines() |
| 3074 | else: |
| 3075 | lines = [line.rstrip() for line in desc] |
| 3076 | while lines and not lines[0]: |
| 3077 | lines.pop(0) |
| 3078 | while lines and not lines[-1]: |
| 3079 | lines.pop(-1) |
| 3080 | self._description_lines = lines |
maruel@chromium.org | 78936cb | 2013-04-11 00:17:52 +0000 | [diff] [blame] | 3081 | |
Robert Iannucci | 6c98dc6 | 2017-04-18 11:38:00 -0700 | [diff] [blame] | 3082 | def update_reviewers(self, reviewers, tbrs, add_owners_to=None, change=None): |
| 3083 | """Rewrites the R=/TBR= line(s) as a single line each. |
| 3084 | |
| 3085 | Args: |
| 3086 | reviewers (list(str)) - list of additional emails to use for reviewers. |
| 3087 | tbrs (list(str)) - list of additional emails to use for TBRs. |
| 3088 | add_owners_to (None|'R'|'TBR') - Pass to do an OWNERS lookup for files in |
| 3089 | the change that are missing OWNER coverage. If this is not None, you |
| 3090 | must also pass a value for `change`. |
| 3091 | change (Change) - The Change that should be used for OWNERS lookups. |
| 3092 | """ |
maruel@chromium.org | 78936cb | 2013-04-11 00:17:52 +0000 | [diff] [blame] | 3093 | assert isinstance(reviewers, list), reviewers |
Robert Iannucci | 6c98dc6 | 2017-04-18 11:38:00 -0700 | [diff] [blame] | 3094 | assert isinstance(tbrs, list), tbrs |
| 3095 | |
Robert Iannucci | f2708bd | 2017-04-17 15:49:02 -0700 | [diff] [blame] | 3096 | assert add_owners_to in (None, 'TBR', 'R'), add_owners_to |
Robert Iannucci | a28592e | 2017-04-18 13:14:49 -0700 | [diff] [blame] | 3097 | assert not add_owners_to or change, add_owners_to |
Robert Iannucci | 6c98dc6 | 2017-04-18 11:38:00 -0700 | [diff] [blame] | 3098 | |
| 3099 | if not reviewers and not tbrs and not add_owners_to: |
maruel@chromium.org | 78936cb | 2013-04-11 00:17:52 +0000 | [diff] [blame] | 3100 | return |
Robert Iannucci | 6c98dc6 | 2017-04-18 11:38:00 -0700 | [diff] [blame] | 3101 | |
| 3102 | reviewers = set(reviewers) |
| 3103 | tbrs = set(tbrs) |
| 3104 | LOOKUP = { |
| 3105 | 'TBR': tbrs, |
| 3106 | 'R': reviewers, |
| 3107 | } |
maruel@chromium.org | 78936cb | 2013-04-11 00:17:52 +0000 | [diff] [blame] | 3108 | |
Quinten Yearsley | 0c62da9 | 2017-05-31 13:39:42 -0700 | [diff] [blame] | 3109 | # Get the set of R= and TBR= lines and remove them from the description. |
agable@chromium.org | 42c2079 | 2013-09-12 17:34:49 +0000 | [diff] [blame] | 3110 | regexp = re.compile(self.R_LINE) |
| 3111 | matches = [regexp.match(line) for line in self._description_lines] |
| 3112 | new_desc = [l for i, l in enumerate(self._description_lines) |
| 3113 | if not matches[i]] |
| 3114 | self.set_description(new_desc) |
maruel@chromium.org | 78936cb | 2013-04-11 00:17:52 +0000 | [diff] [blame] | 3115 | |
agable@chromium.org | 42c2079 | 2013-09-12 17:34:49 +0000 | [diff] [blame] | 3116 | # Construct new unified R= and TBR= lines. |
Robert Iannucci | 6c98dc6 | 2017-04-18 11:38:00 -0700 | [diff] [blame] | 3117 | |
| 3118 | # First, update tbrs/reviewers with names from the R=/TBR= lines (if any). |
agable@chromium.org | 42c2079 | 2013-09-12 17:34:49 +0000 | [diff] [blame] | 3119 | for match in matches: |
| 3120 | if not match: |
| 3121 | continue |
Robert Iannucci | 6c98dc6 | 2017-04-18 11:38:00 -0700 | [diff] [blame] | 3122 | LOOKUP[match.group(1)].update(cleanup_list([match.group(2).strip()])) |
| 3123 | |
| 3124 | # Next, maybe fill in OWNERS coverage gaps to either tbrs/reviewers. |
Robert Iannucci | f2708bd | 2017-04-17 15:49:02 -0700 | [diff] [blame] | 3125 | if add_owners_to: |
piman@chromium.org | 336f912 | 2014-09-04 02:16:55 +0000 | [diff] [blame] | 3126 | owners_db = owners.Database(change.RepositoryRoot(), |
Jochen Eisinger | 72606f8 | 2017-04-04 10:44:18 +0200 | [diff] [blame] | 3127 | fopen=file, os_path=os.path) |
piman@chromium.org | 336f912 | 2014-09-04 02:16:55 +0000 | [diff] [blame] | 3128 | missing_files = owners_db.files_not_covered_by(change.LocalPaths(), |
Robert Iannucci | 100aa21 | 2017-04-18 17:28:26 -0700 | [diff] [blame] | 3129 | (tbrs | reviewers)) |
Robert Iannucci | 6c98dc6 | 2017-04-18 11:38:00 -0700 | [diff] [blame] | 3130 | LOOKUP[add_owners_to].update( |
| 3131 | owners_db.reviewers_for(missing_files, change.author_email)) |
Robert Iannucci | f2708bd | 2017-04-17 15:49:02 -0700 | [diff] [blame] | 3132 | |
Robert Iannucci | 6c98dc6 | 2017-04-18 11:38:00 -0700 | [diff] [blame] | 3133 | # If any folks ended up in both groups, remove them from tbrs. |
| 3134 | tbrs -= reviewers |
Robert Iannucci | f2708bd | 2017-04-17 15:49:02 -0700 | [diff] [blame] | 3135 | |
Robert Iannucci | 6c98dc6 | 2017-04-18 11:38:00 -0700 | [diff] [blame] | 3136 | new_r_line = 'R=' + ', '.join(sorted(reviewers)) if reviewers else None |
| 3137 | new_tbr_line = 'TBR=' + ', '.join(sorted(tbrs)) if tbrs else None |
agable@chromium.org | 42c2079 | 2013-09-12 17:34:49 +0000 | [diff] [blame] | 3138 | |
| 3139 | # Put the new lines in the description where the old first R= line was. |
| 3140 | line_loc = next((i for i, match in enumerate(matches) if match), -1) |
| 3141 | if 0 <= line_loc < len(self._description_lines): |
| 3142 | if new_tbr_line: |
| 3143 | self._description_lines.insert(line_loc, new_tbr_line) |
| 3144 | if new_r_line: |
| 3145 | self._description_lines.insert(line_loc, new_r_line) |
maruel@chromium.org | 78936cb | 2013-04-11 00:17:52 +0000 | [diff] [blame] | 3146 | else: |
agable@chromium.org | 42c2079 | 2013-09-12 17:34:49 +0000 | [diff] [blame] | 3147 | if new_r_line: |
| 3148 | self.append_footer(new_r_line) |
| 3149 | if new_tbr_line: |
| 3150 | self.append_footer(new_tbr_line) |
maruel@chromium.org | 78936cb | 2013-04-11 00:17:52 +0000 | [diff] [blame] | 3151 | |
Aaron Gable | 3a16ed1 | 2017-03-23 10:51:55 -0700 | [diff] [blame] | 3152 | def prompt(self, bug=None, git_footer=True): |
maruel@chromium.org | 78936cb | 2013-04-11 00:17:52 +0000 | [diff] [blame] | 3153 | """Asks the user to update the description.""" |
agable@chromium.org | 42c2079 | 2013-09-12 17:34:49 +0000 | [diff] [blame] | 3154 | self.set_description([ |
| 3155 | '# Enter a description of the change.', |
| 3156 | '# This will be displayed on the codereview site.', |
| 3157 | '# The first line will also be used as the subject of the review.', |
alancutter@chromium.org | bd1073e | 2013-06-01 00:34:38 +0000 | [diff] [blame] | 3158 | '#--------------------This line is 72 characters long' |
agable@chromium.org | 42c2079 | 2013-09-12 17:34:49 +0000 | [diff] [blame] | 3159 | '--------------------', |
| 3160 | ] + self._description_lines) |
maruel@chromium.org | 78936cb | 2013-04-11 00:17:52 +0000 | [diff] [blame] | 3161 | |
agable@chromium.org | 42c2079 | 2013-09-12 17:34:49 +0000 | [diff] [blame] | 3162 | regexp = re.compile(self.BUG_LINE) |
Jonas Termansen | d0f7911 | 2019-03-22 15:28:26 +0000 | [diff] [blame] | 3163 | prefix = settings.GetBugPrefix() |
agable@chromium.org | 42c2079 | 2013-09-12 17:34:49 +0000 | [diff] [blame] | 3164 | if not any((regexp.match(line) for line in self._description_lines)): |
tandrii | f9aefb7 | 2016-07-01 09:06:51 -0700 | [diff] [blame] | 3165 | values = list(_get_bug_line_values(prefix, bug or '')) or [prefix] |
Aaron Gable | 3a16ed1 | 2017-03-23 10:51:55 -0700 | [diff] [blame] | 3166 | if git_footer: |
| 3167 | self.append_footer('Bug: %s' % ', '.join(values)) |
| 3168 | else: |
| 3169 | for value in values: |
| 3170 | self.append_footer('BUG=%s' % value) |
tandrii | f9aefb7 | 2016-07-01 09:06:51 -0700 | [diff] [blame] | 3171 | |
agable@chromium.org | 42c2079 | 2013-09-12 17:34:49 +0000 | [diff] [blame] | 3172 | content = gclient_utils.RunEditor(self.description, True, |
jbroman@chromium.org | 615a262 | 2013-05-03 13:20:14 +0000 | [diff] [blame] | 3173 | git_editor=settings.GetGitEditor()) |
maruel@chromium.org | 0e0436a | 2011-10-25 13:32:41 +0000 | [diff] [blame] | 3174 | if not content: |
| 3175 | DieWithError('Running editor failed') |
agable@chromium.org | 42c2079 | 2013-09-12 17:34:49 +0000 | [diff] [blame] | 3176 | lines = content.splitlines() |
maruel@chromium.org | 78936cb | 2013-04-11 00:17:52 +0000 | [diff] [blame] | 3177 | |
Bruce Dawson | 2377b01 | 2018-01-11 16:46:49 -0800 | [diff] [blame] | 3178 | # Strip off comments and default inserted "Bug:" line. |
| 3179 | clean_lines = [line.rstrip() for line in lines if not |
Jonas Termansen | d0f7911 | 2019-03-22 15:28:26 +0000 | [diff] [blame] | 3180 | (line.startswith('#') or |
| 3181 | line.rstrip() == "Bug:" or |
| 3182 | line.rstrip() == "Bug: " + prefix)] |
agable@chromium.org | 42c2079 | 2013-09-12 17:34:49 +0000 | [diff] [blame] | 3183 | if not clean_lines: |
maruel@chromium.org | 0e0436a | 2011-10-25 13:32:41 +0000 | [diff] [blame] | 3184 | DieWithError('No CL description, aborting') |
agable@chromium.org | 42c2079 | 2013-09-12 17:34:49 +0000 | [diff] [blame] | 3185 | self.set_description(clean_lines) |
dpranke@chromium.org | 20254fc | 2011-03-22 18:28:59 +0000 | [diff] [blame] | 3186 | |
maruel@chromium.org | 78936cb | 2013-04-11 00:17:52 +0000 | [diff] [blame] | 3187 | def append_footer(self, line): |
tandrii@chromium.org | 601e1d1 | 2016-06-03 13:03:54 +0000 | [diff] [blame] | 3188 | """Adds a footer line to the description. |
| 3189 | |
| 3190 | Differentiates legacy "KEY=xxx" footers (used to be called tags) and |
| 3191 | Gerrit's footers in the form of "Footer-Key: footer any value" and ensures |
| 3192 | that Gerrit footers are always at the end. |
| 3193 | """ |
| 3194 | parsed_footer_line = git_footers.parse_footer(line) |
| 3195 | if parsed_footer_line: |
| 3196 | # Line is a gerrit footer in the form: Footer-Key: any value. |
| 3197 | # Thus, must be appended observing Gerrit footer rules. |
| 3198 | self.set_description( |
| 3199 | git_footers.add_footer(self.description, |
| 3200 | key=parsed_footer_line[0], |
| 3201 | value=parsed_footer_line[1])) |
| 3202 | return |
| 3203 | |
| 3204 | if not self._description_lines: |
| 3205 | self._description_lines.append(line) |
| 3206 | return |
| 3207 | |
| 3208 | top_lines, gerrit_footers, _ = git_footers.split_footers(self.description) |
| 3209 | if gerrit_footers: |
| 3210 | # git_footers.split_footers ensures that there is an empty line before |
| 3211 | # actual (gerrit) footers, if any. We have to keep it that way. |
| 3212 | assert top_lines and top_lines[-1] == '' |
| 3213 | top_lines, separator = top_lines[:-1], top_lines[-1:] |
| 3214 | else: |
| 3215 | separator = [] # No need for separator if there are no gerrit_footers. |
| 3216 | |
| 3217 | prev_line = top_lines[-1] if top_lines else '' |
| 3218 | if (not presubmit_support.Change.TAG_LINE_RE.match(prev_line) or |
| 3219 | not presubmit_support.Change.TAG_LINE_RE.match(line)): |
| 3220 | top_lines.append('') |
| 3221 | top_lines.append(line) |
| 3222 | self._description_lines = top_lines + separator + gerrit_footers |
dpranke@chromium.org | 20254fc | 2011-03-22 18:28:59 +0000 | [diff] [blame] | 3223 | |
tandrii | 99a72f2 | 2016-08-17 14:33:24 -0700 | [diff] [blame] | 3224 | def get_reviewers(self, tbr_only=False): |
maruel@chromium.org | 78936cb | 2013-04-11 00:17:52 +0000 | [diff] [blame] | 3225 | """Retrieves the list of reviewers.""" |
agable@chromium.org | 42c2079 | 2013-09-12 17:34:49 +0000 | [diff] [blame] | 3226 | matches = [re.match(self.R_LINE, line) for line in self._description_lines] |
tandrii | 99a72f2 | 2016-08-17 14:33:24 -0700 | [diff] [blame] | 3227 | reviewers = [match.group(2).strip() |
| 3228 | for match in matches |
| 3229 | if match and (not tbr_only or match.group(1).upper() == 'TBR')] |
maruel@chromium.org | 78936cb | 2013-04-11 00:17:52 +0000 | [diff] [blame] | 3230 | return cleanup_list(reviewers) |
dpranke@chromium.org | 20254fc | 2011-03-22 18:28:59 +0000 | [diff] [blame] | 3231 | |
bradnelson | d975b30 | 2016-10-23 12:20:23 -0700 | [diff] [blame] | 3232 | def get_cced(self): |
| 3233 | """Retrieves the list of reviewers.""" |
| 3234 | matches = [re.match(self.CC_LINE, line) for line in self._description_lines] |
| 3235 | cced = [match.group(2).strip() for match in matches if match] |
| 3236 | return cleanup_list(cced) |
| 3237 | |
Nodir Turakulov | 23b8214 | 2017-11-16 11:04:25 -0800 | [diff] [blame] | 3238 | def get_hash_tags(self): |
| 3239 | """Extracts and sanitizes a list of Gerrit hashtags.""" |
| 3240 | subject = (self._description_lines or ('',))[0] |
| 3241 | subject = re.sub( |
| 3242 | self.STRIP_HASH_TAG_PREFIX, '', subject, flags=re.IGNORECASE) |
| 3243 | |
| 3244 | tags = [] |
| 3245 | start = 0 |
| 3246 | bracket_exp = re.compile(self.BRACKET_HASH_TAG) |
| 3247 | while True: |
| 3248 | m = bracket_exp.match(subject, start) |
| 3249 | if not m: |
| 3250 | break |
| 3251 | tags.append(self.sanitize_hash_tag(m.group(1))) |
| 3252 | start = m.end() |
| 3253 | |
| 3254 | if not tags: |
| 3255 | # Try "Tag: " prefix. |
| 3256 | m = re.match(self.COLON_SEPARATED_HASH_TAG, subject) |
| 3257 | if m: |
| 3258 | tags.append(self.sanitize_hash_tag(m.group(1))) |
| 3259 | return tags |
| 3260 | |
| 3261 | @classmethod |
| 3262 | def sanitize_hash_tag(cls, tag): |
| 3263 | """Returns a sanitized Gerrit hash tag. |
| 3264 | |
| 3265 | A sanitized hashtag can be used as a git push refspec parameter value. |
| 3266 | """ |
| 3267 | return re.sub(cls.BAD_HASH_TAG_CHUNK, '-', tag).strip('-').lower() |
| 3268 | |
Andrii Shyshkalov | 15e50cc | 2016-12-02 14:34:08 +0100 | [diff] [blame] | 3269 | def update_with_git_number_footers(self, parent_hash, parent_msg, dest_ref): |
| 3270 | """Updates this commit description given the parent. |
| 3271 | |
| 3272 | This is essentially what Gnumbd used to do. |
| 3273 | Consult https://goo.gl/WMmpDe for more details. |
| 3274 | """ |
| 3275 | assert parent_msg # No, orphan branch creation isn't supported. |
| 3276 | assert parent_hash |
| 3277 | assert dest_ref |
| 3278 | parent_footer_map = git_footers.parse_footers(parent_msg) |
| 3279 | # This will also happily parse svn-position, which GnumbD is no longer |
| 3280 | # supporting. While we'd generate correct footers, the verifier plugin |
| 3281 | # installed in Gerrit will block such commit (ie git push below will fail). |
| 3282 | parent_position = git_footers.get_position(parent_footer_map) |
| 3283 | |
| 3284 | # Cherry-picks may have last line obscuring their prior footers, |
| 3285 | # from git_footers perspective. This is also what Gnumbd did. |
| 3286 | cp_line = None |
| 3287 | if (self._description_lines and |
| 3288 | re.match(self.CHERRY_PICK_LINE, self._description_lines[-1])): |
| 3289 | cp_line = self._description_lines.pop() |
| 3290 | |
Andrii Shyshkalov | de37c01 | 2017-07-06 21:06:50 +0200 | [diff] [blame] | 3291 | top_lines, footer_lines, _ = git_footers.split_footers(self.description) |
Andrii Shyshkalov | 15e50cc | 2016-12-02 14:34:08 +0100 | [diff] [blame] | 3292 | |
| 3293 | # Original-ify all Cr- footers, to avoid re-lands, cherry-picks, or just |
| 3294 | # user interference with actual footers we'd insert below. |
Andrii Shyshkalov | de37c01 | 2017-07-06 21:06:50 +0200 | [diff] [blame] | 3295 | for i, line in enumerate(footer_lines): |
| 3296 | k, v = git_footers.parse_footer(line) or (None, None) |
| 3297 | if k and k.startswith('Cr-'): |
| 3298 | footer_lines[i] = '%s: %s' % ('Cr-Original-' + k[len('Cr-'):], v) |
Andrii Shyshkalov | 15e50cc | 2016-12-02 14:34:08 +0100 | [diff] [blame] | 3299 | |
| 3300 | # Add Position and Lineage footers based on the parent. |
Andrii Shyshkalov | b5effa1 | 2016-12-14 19:35:12 +0100 | [diff] [blame] | 3301 | lineage = list(reversed(parent_footer_map.get('Cr-Branched-From', []))) |
Andrii Shyshkalov | 15e50cc | 2016-12-02 14:34:08 +0100 | [diff] [blame] | 3302 | if parent_position[0] == dest_ref: |
| 3303 | # Same branch as parent. |
| 3304 | number = int(parent_position[1]) + 1 |
| 3305 | else: |
| 3306 | number = 1 # New branch, and extra lineage. |
| 3307 | lineage.insert(0, '%s-%s@{#%d}' % (parent_hash, parent_position[0], |
| 3308 | int(parent_position[1]))) |
| 3309 | |
Andrii Shyshkalov | de37c01 | 2017-07-06 21:06:50 +0200 | [diff] [blame] | 3310 | footer_lines.append('Cr-Commit-Position: %s@{#%d}' % (dest_ref, number)) |
| 3311 | footer_lines.extend('Cr-Branched-From: %s' % v for v in lineage) |
Andrii Shyshkalov | 15e50cc | 2016-12-02 14:34:08 +0100 | [diff] [blame] | 3312 | |
| 3313 | self._description_lines = top_lines |
| 3314 | if cp_line: |
| 3315 | self._description_lines.append(cp_line) |
| 3316 | if self._description_lines[-1] != '': |
| 3317 | self._description_lines.append('') # Ensure footer separator. |
Andrii Shyshkalov | de37c01 | 2017-07-06 21:06:50 +0200 | [diff] [blame] | 3318 | self._description_lines.extend(footer_lines) |
Andrii Shyshkalov | 15e50cc | 2016-12-02 14:34:08 +0100 | [diff] [blame] | 3319 | |
dpranke@chromium.org | 20254fc | 2011-03-22 18:28:59 +0000 | [diff] [blame] | 3320 | |
Aaron Gable | a1bab27 | 2017-04-11 16:38:18 -0700 | [diff] [blame] | 3321 | def get_approving_reviewers(props, disapproval=False): |
maruel@chromium.org | e52678e | 2013-04-26 18:34:44 +0000 | [diff] [blame] | 3322 | """Retrieves the reviewers that approved a CL from the issue properties with |
| 3323 | messages. |
| 3324 | |
| 3325 | Note that the list may contain reviewers that are not committer, thus are not |
| 3326 | considered by the CQ. |
Aaron Gable | a1bab27 | 2017-04-11 16:38:18 -0700 | [diff] [blame] | 3327 | |
| 3328 | If disapproval is True, instead returns reviewers who 'not lgtm'd the CL. |
maruel@chromium.org | e52678e | 2013-04-26 18:34:44 +0000 | [diff] [blame] | 3329 | """ |
Aaron Gable | a1bab27 | 2017-04-11 16:38:18 -0700 | [diff] [blame] | 3330 | approval_type = 'disapproval' if disapproval else 'approval' |
maruel@chromium.org | e52678e | 2013-04-26 18:34:44 +0000 | [diff] [blame] | 3331 | return sorted( |
| 3332 | set( |
| 3333 | message['sender'] |
| 3334 | for message in props['messages'] |
Aaron Gable | a1bab27 | 2017-04-11 16:38:18 -0700 | [diff] [blame] | 3335 | if message[approval_type] and message['sender'] in props['reviewers'] |
maruel@chromium.org | e52678e | 2013-04-26 18:34:44 +0000 | [diff] [blame] | 3336 | ) |
| 3337 | ) |
| 3338 | |
| 3339 | |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 3340 | def FindCodereviewSettingsFile(filename='codereview.settings'): |
| 3341 | """Finds the given file starting in the cwd and going up. |
| 3342 | |
| 3343 | Only looks up to the top of the repository unless an |
| 3344 | 'inherit-review-settings-ok' file exists in the root of the repository. |
| 3345 | """ |
| 3346 | inherit_ok_file = 'inherit-review-settings-ok' |
| 3347 | cwd = os.getcwd() |
thestig@chromium.org | 8b0553c | 2014-02-11 00:33:37 +0000 | [diff] [blame] | 3348 | root = settings.GetRoot() |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 3349 | if os.path.isfile(os.path.join(root, inherit_ok_file)): |
| 3350 | root = '/' |
| 3351 | while True: |
| 3352 | if filename in os.listdir(cwd): |
| 3353 | if os.path.isfile(os.path.join(cwd, filename)): |
| 3354 | return open(os.path.join(cwd, filename)) |
| 3355 | if cwd == root: |
| 3356 | break |
| 3357 | cwd = os.path.dirname(cwd) |
| 3358 | |
| 3359 | |
| 3360 | def LoadCodereviewSettingsFromFile(fileobj): |
| 3361 | """Parse a codereview.settings file and updates hooks.""" |
maruel@chromium.org | 99ac1c5 | 2012-01-16 14:52:12 +0000 | [diff] [blame] | 3362 | keyvals = gclient_utils.ParseCodereviewSettingsContent(fileobj.read()) |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 3363 | |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 3364 | def SetProperty(name, setting, unset_error_ok=False): |
| 3365 | fullname = 'rietveld.' + name |
| 3366 | if setting in keyvals: |
| 3367 | RunGit(['config', fullname, keyvals[setting]]) |
| 3368 | else: |
| 3369 | RunGit(['config', '--unset-all', fullname], error_ok=unset_error_ok) |
| 3370 | |
tandrii | 48df581 | 2016-10-17 03:55:37 -0700 | [diff] [blame] | 3371 | if not keyvals.get('GERRIT_HOST', False): |
| 3372 | SetProperty('server', 'CODE_REVIEW_SERVER') |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 3373 | # Only server setting is required. Other settings can be absent. |
| 3374 | # In that case, we ignore errors raised during option deletion attempt. |
| 3375 | SetProperty('cc', 'CC_LIST', unset_error_ok=True) |
| 3376 | SetProperty('tree-status-url', 'STATUS', unset_error_ok=True) |
| 3377 | SetProperty('viewvc-url', 'VIEW_VC', unset_error_ok=True) |
rmistry@google.com | 9075258 | 2014-01-14 21:04:50 +0000 | [diff] [blame] | 3378 | SetProperty('bug-prefix', 'BUG_PREFIX', unset_error_ok=True) |
thestig@chromium.org | 44202a2 | 2014-03-11 19:22:18 +0000 | [diff] [blame] | 3379 | SetProperty('cpplint-regex', 'LINT_REGEX', unset_error_ok=True) |
| 3380 | SetProperty('cpplint-ignore-regex', 'LINT_IGNORE_REGEX', unset_error_ok=True) |
rmistry@google.com | 5626a92 | 2015-02-26 14:03:30 +0000 | [diff] [blame] | 3381 | SetProperty('run-post-upload-hook', 'RUN_POST_UPLOAD_HOOK', |
| 3382 | unset_error_ok=True) |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 3383 | |
ukai@chromium.org | 7044efc | 2013-11-28 01:51:21 +0000 | [diff] [blame] | 3384 | if 'GERRIT_HOST' in keyvals: |
ukai@chromium.org | e807781 | 2012-02-03 03:41:46 +0000 | [diff] [blame] | 3385 | RunGit(['config', 'gerrit.host', keyvals['GERRIT_HOST']]) |
ukai@chromium.org | e807781 | 2012-02-03 03:41:46 +0000 | [diff] [blame] | 3386 | |
bauerb@chromium.org | 54b400c | 2016-01-14 10:08:25 +0000 | [diff] [blame] | 3387 | if 'GERRIT_SQUASH_UPLOADS' in keyvals: |
tandrii | 8dd81ea | 2016-06-16 13:24:23 -0700 | [diff] [blame] | 3388 | RunGit(['config', 'gerrit.squash-uploads', |
| 3389 | keyvals['GERRIT_SQUASH_UPLOADS']]) |
bauerb@chromium.org | 54b400c | 2016-01-14 10:08:25 +0000 | [diff] [blame] | 3390 | |
tandrii@chromium.org | 2825353 | 2016-04-14 13:46:56 +0000 | [diff] [blame] | 3391 | if 'GERRIT_SKIP_ENSURE_AUTHENTICATED' in keyvals: |
shinyak@chromium.org | 00dbccd | 2016-04-15 07:24:43 +0000 | [diff] [blame] | 3392 | RunGit(['config', 'gerrit.skip-ensure-authenticated', |
tandrii@chromium.org | 2825353 | 2016-04-14 13:46:56 +0000 | [diff] [blame] | 3393 | keyvals['GERRIT_SKIP_ENSURE_AUTHENTICATED']]) |
| 3394 | |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 3395 | if 'PUSH_URL_CONFIG' in keyvals and 'ORIGIN_URL_CONFIG' in keyvals: |
Andrii Shyshkalov | 1897532 | 2017-01-25 16:44:13 +0100 | [diff] [blame] | 3396 | # should be of the form |
| 3397 | # PUSH_URL_CONFIG: url.ssh://gitrw.chromium.org.pushinsteadof |
| 3398 | # ORIGIN_URL_CONFIG: http://src.chromium.org/git |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 3399 | RunGit(['config', keyvals['PUSH_URL_CONFIG'], |
| 3400 | keyvals['ORIGIN_URL_CONFIG']]) |
| 3401 | |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 3402 | |
joshua.lock@intel.com | 426f69b | 2012-08-02 23:41:49 +0000 | [diff] [blame] | 3403 | def urlretrieve(source, destination): |
| 3404 | """urllib is broken for SSL connections via a proxy therefore we |
| 3405 | can't use urllib.urlretrieve().""" |
| 3406 | with open(destination, 'w') as f: |
| 3407 | f.write(urllib2.urlopen(source).read()) |
| 3408 | |
| 3409 | |
ukai@chromium.org | 712d610 | 2013-11-27 00:52:58 +0000 | [diff] [blame] | 3410 | def hasSheBang(fname): |
| 3411 | """Checks fname is a #! script.""" |
| 3412 | with open(fname) as f: |
| 3413 | return f.read(2).startswith('#!') |
| 3414 | |
| 3415 | |
bpastene@chromium.org | 917f0ff | 2016-04-05 00:45:30 +0000 | [diff] [blame] | 3416 | # TODO(bpastene) Remove once a cleaner fix to crbug.com/600473 presents itself. |
| 3417 | def DownloadHooks(*args, **kwargs): |
| 3418 | pass |
| 3419 | |
| 3420 | |
tandrii@chromium.org | 18630d6 | 2016-03-04 12:06:02 +0000 | [diff] [blame] | 3421 | def DownloadGerritHook(force): |
| 3422 | """Download and install Gerrit commit-msg hook. |
ukai@chromium.org | 78c4b98 | 2012-02-14 02:20:26 +0000 | [diff] [blame] | 3423 | |
| 3424 | Args: |
| 3425 | force: True to update hooks. False to install hooks if not present. |
| 3426 | """ |
| 3427 | if not settings.GetIsGerrit(): |
| 3428 | return |
ukai@chromium.org | 712d610 | 2013-11-27 00:52:58 +0000 | [diff] [blame] | 3429 | src = 'https://gerrit-review.googlesource.com/tools/hooks/commit-msg' |
ukai@chromium.org | 78c4b98 | 2012-02-14 02:20:26 +0000 | [diff] [blame] | 3430 | dst = os.path.join(settings.GetRoot(), '.git', 'hooks', 'commit-msg') |
| 3431 | if not os.access(dst, os.X_OK): |
| 3432 | if os.path.exists(dst): |
| 3433 | if not force: |
| 3434 | return |
ukai@chromium.org | 78c4b98 | 2012-02-14 02:20:26 +0000 | [diff] [blame] | 3435 | try: |
joshua.lock@intel.com | 426f69b | 2012-08-02 23:41:49 +0000 | [diff] [blame] | 3436 | urlretrieve(src, dst) |
ukai@chromium.org | 712d610 | 2013-11-27 00:52:58 +0000 | [diff] [blame] | 3437 | if not hasSheBang(dst): |
| 3438 | DieWithError('Not a script: %s\n' |
| 3439 | 'You need to download from\n%s\n' |
| 3440 | 'into .git/hooks/commit-msg and ' |
| 3441 | 'chmod +x .git/hooks/commit-msg' % (dst, src)) |
ukai@chromium.org | 78c4b98 | 2012-02-14 02:20:26 +0000 | [diff] [blame] | 3442 | os.chmod(dst, stat.S_IRUSR | stat.S_IWUSR | stat.S_IXUSR) |
| 3443 | except Exception: |
| 3444 | if os.path.exists(dst): |
| 3445 | os.remove(dst) |
ukai@chromium.org | 712d610 | 2013-11-27 00:52:58 +0000 | [diff] [blame] | 3446 | DieWithError('\nFailed to download hooks.\n' |
| 3447 | 'You need to download from\n%s\n' |
| 3448 | 'into .git/hooks/commit-msg and ' |
| 3449 | 'chmod +x .git/hooks/commit-msg' % src) |
ukai@chromium.org | 78c4b98 | 2012-02-14 02:20:26 +0000 | [diff] [blame] | 3450 | |
| 3451 | |
Andrii Shyshkalov | 517948b | 2017-03-15 15:51:59 +0100 | [diff] [blame] | 3452 | class _GitCookiesChecker(object): |
Quinten Yearsley | 0c62da9 | 2017-05-31 13:39:42 -0700 | [diff] [blame] | 3453 | """Provides facilities for validating and suggesting fixes to .gitcookies.""" |
Andrii Shyshkalov | 353637c | 2017-03-14 16:52:18 +0100 | [diff] [blame] | 3454 | |
Andrii Shyshkalov | 34924cd | 2017-03-15 17:08:32 +0100 | [diff] [blame] | 3455 | _GOOGLESOURCE = 'googlesource.com' |
| 3456 | |
| 3457 | def __init__(self): |
| 3458 | # Cached list of [host, identity, source], where source is either |
| 3459 | # .gitcookies or .netrc. |
| 3460 | self._all_hosts = None |
| 3461 | |
Andrii Shyshkalov | 517948b | 2017-03-15 15:51:59 +0100 | [diff] [blame] | 3462 | def ensure_configured_gitcookies(self): |
| 3463 | """Runs checks and suggests fixes to make git use .gitcookies from default |
| 3464 | path.""" |
| 3465 | default = gerrit_util.CookiesAuthenticator.get_gitcookies_path() |
| 3466 | configured_path = RunGitSilent( |
| 3467 | ['config', '--global', 'http.cookiefile']).strip() |
Andrii Shyshkalov | 1e250cd | 2017-05-10 15:39:31 +0200 | [diff] [blame] | 3468 | configured_path = os.path.expanduser(configured_path) |
Andrii Shyshkalov | 517948b | 2017-03-15 15:51:59 +0100 | [diff] [blame] | 3469 | if configured_path: |
| 3470 | self._ensure_default_gitcookies_path(configured_path, default) |
| 3471 | else: |
| 3472 | self._configure_gitcookies_path(default) |
Andrii Shyshkalov | 353637c | 2017-03-14 16:52:18 +0100 | [diff] [blame] | 3473 | |
Andrii Shyshkalov | 517948b | 2017-03-15 15:51:59 +0100 | [diff] [blame] | 3474 | @staticmethod |
| 3475 | def _ensure_default_gitcookies_path(configured_path, default_path): |
| 3476 | assert configured_path |
| 3477 | if configured_path == default_path: |
| 3478 | print('git is already configured to use your .gitcookies from %s' % |
| 3479 | configured_path) |
| 3480 | return |
| 3481 | |
Quinten Yearsley | 0c62da9 | 2017-05-31 13:39:42 -0700 | [diff] [blame] | 3482 | print('WARNING: You have configured custom path to .gitcookies: %s\n' |
Andrii Shyshkalov | 517948b | 2017-03-15 15:51:59 +0100 | [diff] [blame] | 3483 | 'Gerrit and other depot_tools expect .gitcookies at %s\n' % |
| 3484 | (configured_path, default_path)) |
| 3485 | |
| 3486 | if not os.path.exists(configured_path): |
| 3487 | print('However, your configured .gitcookies file is missing.') |
| 3488 | confirm_or_exit('Reconfigure git to use default .gitcookies?', |
| 3489 | action='reconfigure') |
| 3490 | RunGit(['config', '--global', 'http.cookiefile', default_path]) |
| 3491 | return |
| 3492 | |
| 3493 | if os.path.exists(default_path): |
| 3494 | print('WARNING: default .gitcookies file already exists %s' % |
| 3495 | default_path) |
| 3496 | DieWithError('Please delete %s manually and re-run git cl creds-check' % |
| 3497 | default_path) |
| 3498 | |
| 3499 | confirm_or_exit('Move existing .gitcookies to default location?', |
| 3500 | action='move') |
| 3501 | shutil.move(configured_path, default_path) |
Andrii Shyshkalov | 353637c | 2017-03-14 16:52:18 +0100 | [diff] [blame] | 3502 | RunGit(['config', '--global', 'http.cookiefile', default_path]) |
Andrii Shyshkalov | 517948b | 2017-03-15 15:51:59 +0100 | [diff] [blame] | 3503 | print('Moved and reconfigured git to use .gitcookies from %s' % |
| 3504 | default_path) |
Andrii Shyshkalov | 353637c | 2017-03-14 16:52:18 +0100 | [diff] [blame] | 3505 | |
Andrii Shyshkalov | 517948b | 2017-03-15 15:51:59 +0100 | [diff] [blame] | 3506 | @staticmethod |
| 3507 | def _configure_gitcookies_path(default_path): |
| 3508 | netrc_path = gerrit_util.CookiesAuthenticator.get_netrc_path() |
| 3509 | if os.path.exists(netrc_path): |
| 3510 | print('You seem to be using outdated .netrc for git credentials: %s' % |
| 3511 | netrc_path) |
| 3512 | print('This tool will guide you through setting up recommended ' |
| 3513 | '.gitcookies store for git credentials.\n' |
| 3514 | '\n' |
| 3515 | 'IMPORTANT: If something goes wrong and you decide to go back, do:\n' |
| 3516 | ' git config --global --unset http.cookiefile\n' |
| 3517 | ' mv %s %s.backup\n\n' % (default_path, default_path)) |
| 3518 | confirm_or_exit(action='setup .gitcookies') |
| 3519 | RunGit(['config', '--global', 'http.cookiefile', default_path]) |
| 3520 | print('Configured git to use .gitcookies from %s' % default_path) |
Andrii Shyshkalov | 353637c | 2017-03-14 16:52:18 +0100 | [diff] [blame] | 3521 | |
Andrii Shyshkalov | 34924cd | 2017-03-15 17:08:32 +0100 | [diff] [blame] | 3522 | def get_hosts_with_creds(self, include_netrc=False): |
| 3523 | if self._all_hosts is None: |
| 3524 | a = gerrit_util.CookiesAuthenticator() |
| 3525 | self._all_hosts = [ |
| 3526 | (h, u, s) |
| 3527 | for h, u, s in itertools.chain( |
| 3528 | ((h, u, '.netrc') for h, (u, _, _) in a.netrc.hosts.iteritems()), |
| 3529 | ((h, u, '.gitcookies') for h, (u, _) in a.gitcookies.iteritems()) |
| 3530 | ) |
| 3531 | if h.endswith(self._GOOGLESOURCE) |
| 3532 | ] |
| 3533 | |
| 3534 | if include_netrc: |
| 3535 | return self._all_hosts |
| 3536 | return [(h, u, s) for h, u, s in self._all_hosts if s != '.netrc'] |
| 3537 | |
| 3538 | def print_current_creds(self, include_netrc=False): |
| 3539 | hosts = sorted(self.get_hosts_with_creds(include_netrc=include_netrc)) |
| 3540 | if not hosts: |
| 3541 | print('No Git/Gerrit credentials found') |
| 3542 | return |
| 3543 | lengths = [max(map(len, (row[i] for row in hosts))) for i in xrange(3)] |
| 3544 | header = [('Host', 'User', 'Which file'), |
| 3545 | ['=' * l for l in lengths]] |
| 3546 | for row in (header + hosts): |
| 3547 | print('\t'.join((('%%+%ds' % l) % s) |
| 3548 | for l, s in zip(lengths, row))) |
| 3549 | |
Andrii Shyshkalov | 9780050 | 2017-03-16 16:04:32 +0100 | [diff] [blame] | 3550 | @staticmethod |
| 3551 | def _parse_identity(identity): |
Lei Zhang | d3f769a | 2017-12-15 15:16:14 -0800 | [diff] [blame] | 3552 | """Parses identity "git-<username>.domain" into <username> and domain.""" |
| 3553 | # Special case: usernames that contain ".", which are generally not |
Andrii Shyshkalov | 0d2dea0 | 2017-07-17 15:17:55 +0200 | [diff] [blame] | 3554 | # distinguishable from sub-domains. But we do know typical domains: |
| 3555 | if identity.endswith('.chromium.org'): |
| 3556 | domain = 'chromium.org' |
| 3557 | username = identity[:-len('.chromium.org')] |
| 3558 | else: |
| 3559 | username, domain = identity.split('.', 1) |
Andrii Shyshkalov | 9780050 | 2017-03-16 16:04:32 +0100 | [diff] [blame] | 3560 | if username.startswith('git-'): |
| 3561 | username = username[len('git-'):] |
| 3562 | return username, domain |
| 3563 | |
| 3564 | def _get_usernames_of_domain(self, domain): |
| 3565 | """Returns list of usernames referenced by .gitcookies in a given domain.""" |
| 3566 | identities_by_domain = {} |
| 3567 | for _, identity, _ in self.get_hosts_with_creds(): |
| 3568 | username, domain = self._parse_identity(identity) |
| 3569 | identities_by_domain.setdefault(domain, []).append(username) |
| 3570 | return identities_by_domain.get(domain) |
| 3571 | |
| 3572 | def _canonical_git_googlesource_host(self, host): |
| 3573 | """Normalizes Gerrit hosts (with '-review') to Git host.""" |
| 3574 | assert host.endswith(self._GOOGLESOURCE) |
| 3575 | # Prefix doesn't include '.' at the end. |
| 3576 | prefix = host[:-(1 + len(self._GOOGLESOURCE))] |
| 3577 | if prefix.endswith('-review'): |
| 3578 | prefix = prefix[:-len('-review')] |
| 3579 | return prefix + '.' + self._GOOGLESOURCE |
| 3580 | |
Andrii Shyshkalov | 0a0b067 | 2017-03-16 16:27:48 +0100 | [diff] [blame] | 3581 | def _canonical_gerrit_googlesource_host(self, host): |
| 3582 | git_host = self._canonical_git_googlesource_host(host) |
| 3583 | prefix = git_host.split('.', 1)[0] |
| 3584 | return prefix + '-review.' + self._GOOGLESOURCE |
| 3585 | |
Andrii Shyshkalov | c817382 | 2017-07-10 12:10:53 +0200 | [diff] [blame] | 3586 | def _get_counterpart_host(self, host): |
| 3587 | assert host.endswith(self._GOOGLESOURCE) |
| 3588 | git = self._canonical_git_googlesource_host(host) |
| 3589 | gerrit = self._canonical_gerrit_googlesource_host(git) |
| 3590 | return git if gerrit == host else gerrit |
| 3591 | |
Andrii Shyshkalov | 9780050 | 2017-03-16 16:04:32 +0100 | [diff] [blame] | 3592 | def has_generic_host(self): |
| 3593 | """Returns whether generic .googlesource.com has been configured. |
| 3594 | |
| 3595 | Chrome Infra recommends to use explicit ${host}.googlesource.com instead. |
| 3596 | """ |
| 3597 | for host, _, _ in self.get_hosts_with_creds(include_netrc=False): |
| 3598 | if host == '.' + self._GOOGLESOURCE: |
| 3599 | return True |
| 3600 | return False |
| 3601 | |
| 3602 | def _get_git_gerrit_identity_pairs(self): |
| 3603 | """Returns map from canonic host to pair of identities (Git, Gerrit). |
| 3604 | |
| 3605 | One of identities might be None, meaning not configured. |
| 3606 | """ |
| 3607 | host_to_identity_pairs = {} |
| 3608 | for host, identity, _ in self.get_hosts_with_creds(): |
| 3609 | canonical = self._canonical_git_googlesource_host(host) |
| 3610 | pair = host_to_identity_pairs.setdefault(canonical, [None, None]) |
| 3611 | idx = 0 if canonical == host else 1 |
| 3612 | pair[idx] = identity |
| 3613 | return host_to_identity_pairs |
| 3614 | |
| 3615 | def get_partially_configured_hosts(self): |
| 3616 | return set( |
Andrii Shyshkalov | c817382 | 2017-07-10 12:10:53 +0200 | [diff] [blame] | 3617 | (host if i1 else self._canonical_gerrit_googlesource_host(host)) |
| 3618 | for host, (i1, i2) in self._get_git_gerrit_identity_pairs().iteritems() |
| 3619 | if None in (i1, i2) and host != '.' + self._GOOGLESOURCE) |
Andrii Shyshkalov | 9780050 | 2017-03-16 16:04:32 +0100 | [diff] [blame] | 3620 | |
| 3621 | def get_conflicting_hosts(self): |
| 3622 | return set( |
Andrii Shyshkalov | c817382 | 2017-07-10 12:10:53 +0200 | [diff] [blame] | 3623 | host |
| 3624 | for host, (i1, i2) in self._get_git_gerrit_identity_pairs().iteritems() |
Andrii Shyshkalov | 9780050 | 2017-03-16 16:04:32 +0100 | [diff] [blame] | 3625 | if None not in (i1, i2) and i1 != i2) |
| 3626 | |
| 3627 | def get_duplicated_hosts(self): |
| 3628 | counters = collections.Counter(h for h, _, _ in self.get_hosts_with_creds()) |
| 3629 | return set(host for host, count in counters.iteritems() if count > 1) |
| 3630 | |
| 3631 | _EXPECTED_HOST_IDENTITY_DOMAINS = { |
| 3632 | 'chromium.googlesource.com': 'chromium.org', |
| 3633 | 'chrome-internal.googlesource.com': 'google.com', |
| 3634 | } |
| 3635 | |
| 3636 | def get_hosts_with_wrong_identities(self): |
| 3637 | """Finds hosts which **likely** reference wrong identities. |
| 3638 | |
| 3639 | Note: skips hosts which have conflicting identities for Git and Gerrit. |
| 3640 | """ |
| 3641 | hosts = set() |
| 3642 | for host, expected in self._EXPECTED_HOST_IDENTITY_DOMAINS.iteritems(): |
| 3643 | pair = self._get_git_gerrit_identity_pairs().get(host) |
| 3644 | if pair and pair[0] == pair[1]: |
| 3645 | _, domain = self._parse_identity(pair[0]) |
| 3646 | if domain != expected: |
| 3647 | hosts.add(host) |
| 3648 | return hosts |
| 3649 | |
Andrii Shyshkalov | 0a0b067 | 2017-03-16 16:27:48 +0100 | [diff] [blame] | 3650 | @staticmethod |
Andrii Shyshkalov | c817382 | 2017-07-10 12:10:53 +0200 | [diff] [blame] | 3651 | def _format_hosts(hosts, extra_column_func=None): |
Andrii Shyshkalov | 0a0b067 | 2017-03-16 16:27:48 +0100 | [diff] [blame] | 3652 | hosts = sorted(hosts) |
| 3653 | assert hosts |
| 3654 | if extra_column_func is None: |
| 3655 | extras = [''] * len(hosts) |
| 3656 | else: |
| 3657 | extras = [extra_column_func(host) for host in hosts] |
Andrii Shyshkalov | c817382 | 2017-07-10 12:10:53 +0200 | [diff] [blame] | 3658 | tmpl = '%%-%ds %%-%ds' % (max(map(len, hosts)), max(map(len, extras))) |
| 3659 | lines = [] |
Andrii Shyshkalov | 0a0b067 | 2017-03-16 16:27:48 +0100 | [diff] [blame] | 3660 | for he in zip(hosts, extras): |
Andrii Shyshkalov | c817382 | 2017-07-10 12:10:53 +0200 | [diff] [blame] | 3661 | lines.append(tmpl % he) |
| 3662 | return lines |
Andrii Shyshkalov | 0a0b067 | 2017-03-16 16:27:48 +0100 | [diff] [blame] | 3663 | |
Andrii Shyshkalov | c817382 | 2017-07-10 12:10:53 +0200 | [diff] [blame] | 3664 | def _find_problems(self): |
Andrii Shyshkalov | 0a0b067 | 2017-03-16 16:27:48 +0100 | [diff] [blame] | 3665 | if self.has_generic_host(): |
Andrii Shyshkalov | c817382 | 2017-07-10 12:10:53 +0200 | [diff] [blame] | 3666 | yield ('.googlesource.com wildcard record detected', |
| 3667 | ['Chrome Infrastructure team recommends to list full host names ' |
| 3668 | 'explicitly.'], |
| 3669 | None) |
Andrii Shyshkalov | 0a0b067 | 2017-03-16 16:27:48 +0100 | [diff] [blame] | 3670 | |
| 3671 | dups = self.get_duplicated_hosts() |
| 3672 | if dups: |
Andrii Shyshkalov | c817382 | 2017-07-10 12:10:53 +0200 | [diff] [blame] | 3673 | yield ('The following hosts were defined twice', |
| 3674 | self._format_hosts(dups), |
| 3675 | None) |
Andrii Shyshkalov | 0a0b067 | 2017-03-16 16:27:48 +0100 | [diff] [blame] | 3676 | |
| 3677 | partial = self.get_partially_configured_hosts() |
| 3678 | if partial: |
Andrii Shyshkalov | c817382 | 2017-07-10 12:10:53 +0200 | [diff] [blame] | 3679 | yield ('Credentials should come in pairs for Git and Gerrit hosts. ' |
| 3680 | 'These hosts are missing', |
| 3681 | self._format_hosts(partial, lambda host: 'but %s defined' % |
| 3682 | self._get_counterpart_host(host)), |
| 3683 | partial) |
Andrii Shyshkalov | 0a0b067 | 2017-03-16 16:27:48 +0100 | [diff] [blame] | 3684 | |
| 3685 | conflicting = self.get_conflicting_hosts() |
| 3686 | if conflicting: |
Andrii Shyshkalov | c817382 | 2017-07-10 12:10:53 +0200 | [diff] [blame] | 3687 | yield ('The following Git hosts have differing credentials from their ' |
| 3688 | 'Gerrit counterparts', |
| 3689 | self._format_hosts(conflicting, lambda host: '%s vs %s' % |
| 3690 | tuple(self._get_git_gerrit_identity_pairs()[host])), |
| 3691 | conflicting) |
Andrii Shyshkalov | 0a0b067 | 2017-03-16 16:27:48 +0100 | [diff] [blame] | 3692 | |
| 3693 | wrong = self.get_hosts_with_wrong_identities() |
| 3694 | if wrong: |
Andrii Shyshkalov | c817382 | 2017-07-10 12:10:53 +0200 | [diff] [blame] | 3695 | yield ('These hosts likely use wrong identity', |
| 3696 | self._format_hosts(wrong, lambda host: '%s but %s recommended' % |
| 3697 | (self._get_git_gerrit_identity_pairs()[host][0], |
| 3698 | self._EXPECTED_HOST_IDENTITY_DOMAINS[host])), |
| 3699 | wrong) |
| 3700 | |
| 3701 | def find_and_report_problems(self): |
| 3702 | """Returns True if there was at least one problem, else False.""" |
| 3703 | found = False |
| 3704 | bad_hosts = set() |
| 3705 | for title, sublines, hosts in self._find_problems(): |
| 3706 | if not found: |
| 3707 | found = True |
| 3708 | print('\n\n.gitcookies problem report:\n') |
| 3709 | bad_hosts.update(hosts or []) |
| 3710 | print(' %s%s' % (title , (':' if sublines else ''))) |
| 3711 | if sublines: |
| 3712 | print() |
| 3713 | print(' %s' % '\n '.join(sublines)) |
| 3714 | print() |
| 3715 | |
| 3716 | if bad_hosts: |
| 3717 | assert found |
| 3718 | print(' You can manually remove corresponding lines in your %s file and ' |
| 3719 | 'visit the following URLs with correct account to generate ' |
| 3720 | 'correct credential lines:\n' % |
| 3721 | gerrit_util.CookiesAuthenticator.get_gitcookies_path()) |
| 3722 | print(' %s' % '\n '.join(sorted(set( |
| 3723 | gerrit_util.CookiesAuthenticator().get_new_password_url( |
| 3724 | self._canonical_git_googlesource_host(host)) |
| 3725 | for host in bad_hosts |
| 3726 | )))) |
| 3727 | return found |
Andrii Shyshkalov | 0a0b067 | 2017-03-16 16:27:48 +0100 | [diff] [blame] | 3728 | |
Andrii Shyshkalov | 353637c | 2017-03-14 16:52:18 +0100 | [diff] [blame] | 3729 | |
Edward Lemur | 5ba1e9c | 2018-07-23 18:19:02 +0000 | [diff] [blame] | 3730 | @metrics.collector.collect_metrics('git cl creds-check') |
Andrii Shyshkalov | 353637c | 2017-03-14 16:52:18 +0100 | [diff] [blame] | 3731 | def CMDcreds_check(parser, args): |
| 3732 | """Checks credentials and suggests changes.""" |
| 3733 | _, _ = parser.parse_args(args) |
| 3734 | |
Vadim Shtayura | b250ec1 | 2018-10-04 00:21:08 +0000 | [diff] [blame] | 3735 | # Code below checks .gitcookies. Abort if using something else. |
| 3736 | authn = gerrit_util.Authenticator.get() |
| 3737 | if not isinstance(authn, gerrit_util.CookiesAuthenticator): |
| 3738 | if isinstance(authn, gerrit_util.GceAuthenticator): |
| 3739 | DieWithError( |
| 3740 | 'This command is not designed for GCE, are you on a bot?\n' |
| 3741 | 'If you need to run this on GCE, export SKIP_GCE_AUTH_FOR_GIT=1 ' |
| 3742 | 'in your env.') |
Aaron Gable | d10ca0e | 2017-09-11 11:24:10 -0700 | [diff] [blame] | 3743 | DieWithError( |
Vadim Shtayura | b250ec1 | 2018-10-04 00:21:08 +0000 | [diff] [blame] | 3744 | 'This command is not designed for bot environment. It checks ' |
| 3745 | '~/.gitcookies file not generally used on bots.') |
Andrii Shyshkalov | 353637c | 2017-03-14 16:52:18 +0100 | [diff] [blame] | 3746 | |
Andrii Shyshkalov | 517948b | 2017-03-15 15:51:59 +0100 | [diff] [blame] | 3747 | checker = _GitCookiesChecker() |
| 3748 | checker.ensure_configured_gitcookies() |
Andrii Shyshkalov | 34924cd | 2017-03-15 17:08:32 +0100 | [diff] [blame] | 3749 | |
Andrii Shyshkalov | 0a0b067 | 2017-03-16 16:27:48 +0100 | [diff] [blame] | 3750 | print('Your .netrc and .gitcookies have credentials for these hosts:') |
Andrii Shyshkalov | 34924cd | 2017-03-15 17:08:32 +0100 | [diff] [blame] | 3751 | checker.print_current_creds(include_netrc=True) |
| 3752 | |
Andrii Shyshkalov | 0a0b067 | 2017-03-16 16:27:48 +0100 | [diff] [blame] | 3753 | if not checker.find_and_report_problems(): |
Quinten Yearsley | 0c62da9 | 2017-05-31 13:39:42 -0700 | [diff] [blame] | 3754 | print('\nNo problems detected in your .gitcookies file.') |
Andrii Shyshkalov | 0a0b067 | 2017-03-16 16:27:48 +0100 | [diff] [blame] | 3755 | return 0 |
| 3756 | return 1 |
Andrii Shyshkalov | 353637c | 2017-03-14 16:52:18 +0100 | [diff] [blame] | 3757 | |
| 3758 | |
Edward Lemur | 5ba1e9c | 2018-07-23 18:19:02 +0000 | [diff] [blame] | 3759 | @metrics.collector.collect_metrics('git cl baseurl') |
kalmard@homejinni.com | 6b0051e | 2012-04-03 15:45:08 +0000 | [diff] [blame] | 3760 | def CMDbaseurl(parser, args): |
iannucci@chromium.org | d9c1b20 | 2013-07-24 23:52:11 +0000 | [diff] [blame] | 3761 | """Gets or sets base-url for this branch.""" |
kalmard@homejinni.com | 6b0051e | 2012-04-03 15:45:08 +0000 | [diff] [blame] | 3762 | branchref = RunGit(['symbolic-ref', 'HEAD']).strip() |
| 3763 | branch = ShortBranchName(branchref) |
| 3764 | _, args = parser.parse_args(args) |
| 3765 | if not args: |
vapier | a7fbd5a | 2016-06-16 09:17:49 -0700 | [diff] [blame] | 3766 | print('Current base-url:') |
kalmard@homejinni.com | 6b0051e | 2012-04-03 15:45:08 +0000 | [diff] [blame] | 3767 | return RunGit(['config', 'branch.%s.base-url' % branch], |
| 3768 | error_ok=False).strip() |
| 3769 | else: |
vapier | a7fbd5a | 2016-06-16 09:17:49 -0700 | [diff] [blame] | 3770 | print('Setting base-url to %s' % args[0]) |
kalmard@homejinni.com | 6b0051e | 2012-04-03 15:45:08 +0000 | [diff] [blame] | 3771 | return RunGit(['config', 'branch.%s.base-url' % branch, args[0]], |
| 3772 | error_ok=False).strip() |
| 3773 | |
jsbell@chromium.org | b99fbd9 | 2014-09-11 17:29:28 +0000 | [diff] [blame] | 3774 | def color_for_status(status): |
| 3775 | """Maps a Changelist status to color, for CMDstatus and other tools.""" |
| 3776 | return { |
Aaron Gable | 9ab38c6 | 2017-04-06 14:36:33 -0700 | [diff] [blame] | 3777 | 'unsent': Fore.YELLOW, |
jsbell@chromium.org | b99fbd9 | 2014-09-11 17:29:28 +0000 | [diff] [blame] | 3778 | 'waiting': Fore.BLUE, |
| 3779 | 'reply': Fore.YELLOW, |
Aaron Gable | 9ab38c6 | 2017-04-06 14:36:33 -0700 | [diff] [blame] | 3780 | 'not lgtm': Fore.RED, |
jsbell@chromium.org | b99fbd9 | 2014-09-11 17:29:28 +0000 | [diff] [blame] | 3781 | 'lgtm': Fore.GREEN, |
| 3782 | 'commit': Fore.MAGENTA, |
| 3783 | 'closed': Fore.CYAN, |
| 3784 | 'error': Fore.WHITE, |
| 3785 | }.get(status, Fore.WHITE) |
| 3786 | |
tandrii@chromium.org | 04ea846 | 2016-04-25 19:51:21 +0000 | [diff] [blame] | 3787 | |
clemensh@chromium.org | cbd7dc3 | 2016-05-31 10:33:50 +0000 | [diff] [blame] | 3788 | def get_cl_statuses(changes, fine_grained, max_processes=None): |
| 3789 | """Returns a blocking iterable of (cl, status) for given branches. |
calamity@chromium.org | ffde55c | 2015-03-12 00:44:17 +0000 | [diff] [blame] | 3790 | |
| 3791 | If fine_grained is true, this will fetch CL statuses from the server. |
| 3792 | Otherwise, simply indicate if there's a matching url for the given branches. |
| 3793 | |
| 3794 | If max_processes is specified, it is used as the maximum number of processes |
| 3795 | to spawn to fetch CL status from the server. Otherwise 1 process per branch is |
| 3796 | spawned. |
calamity@chromium.org | cf19748 | 2016-04-29 20:15:53 +0000 | [diff] [blame] | 3797 | |
| 3798 | See GetStatus() for a list of possible statuses. |
calamity@chromium.org | ffde55c | 2015-03-12 00:44:17 +0000 | [diff] [blame] | 3799 | """ |
Andrii Shyshkalov | 2f8e924 | 2017-01-23 19:20:19 +0100 | [diff] [blame] | 3800 | if not changes: |
| 3801 | raise StopIteration() |
calamity@chromium.org | cf19748 | 2016-04-29 20:15:53 +0000 | [diff] [blame] | 3802 | |
Andrii Shyshkalov | 2f8e924 | 2017-01-23 19:20:19 +0100 | [diff] [blame] | 3803 | if not fine_grained: |
| 3804 | # Fast path which doesn't involve querying codereview servers. |
Aaron Gable | a1bab27 | 2017-04-11 16:38:18 -0700 | [diff] [blame] | 3805 | # Do not use get_approving_reviewers(), since it requires an HTTP request. |
clemensh@chromium.org | cbd7dc3 | 2016-05-31 10:33:50 +0000 | [diff] [blame] | 3806 | for cl in changes: |
| 3807 | yield (cl, 'waiting' if cl.GetIssueURL() else 'error') |
Andrii Shyshkalov | 2f8e924 | 2017-01-23 19:20:19 +0100 | [diff] [blame] | 3808 | return |
| 3809 | |
| 3810 | # First, sort out authentication issues. |
| 3811 | logging.debug('ensuring credentials exist') |
| 3812 | for cl in changes: |
| 3813 | cl.EnsureAuthenticated(force=False, refresh=True) |
| 3814 | |
| 3815 | def fetch(cl): |
| 3816 | try: |
| 3817 | return (cl, cl.GetStatus()) |
| 3818 | except: |
| 3819 | # See http://crbug.com/629863. |
Andrii Shyshkalov | 9882423 | 2018-04-19 11:37:15 -0700 | [diff] [blame] | 3820 | logging.exception('failed to fetch status for cl %s:', cl.GetIssue()) |
Andrii Shyshkalov | 2f8e924 | 2017-01-23 19:20:19 +0100 | [diff] [blame] | 3821 | raise |
| 3822 | |
| 3823 | threads_count = len(changes) |
| 3824 | if max_processes: |
| 3825 | threads_count = max(1, min(threads_count, max_processes)) |
| 3826 | logging.debug('querying %d CLs using %d threads', len(changes), threads_count) |
| 3827 | |
| 3828 | pool = ThreadPool(threads_count) |
| 3829 | fetched_cls = set() |
| 3830 | try: |
| 3831 | it = pool.imap_unordered(fetch, changes).__iter__() |
| 3832 | while True: |
| 3833 | try: |
| 3834 | cl, status = it.next(timeout=5) |
| 3835 | except multiprocessing.TimeoutError: |
| 3836 | break |
| 3837 | fetched_cls.add(cl) |
| 3838 | yield cl, status |
| 3839 | finally: |
| 3840 | pool.close() |
| 3841 | |
| 3842 | # Add any branches that failed to fetch. |
| 3843 | for cl in set(changes) - fetched_cls: |
| 3844 | yield (cl, 'error') |
jsbell@chromium.org | b99fbd9 | 2014-09-11 17:29:28 +0000 | [diff] [blame] | 3845 | |
rmistry@google.com | 2dd9986 | 2015-06-22 12:22:18 +0000 | [diff] [blame] | 3846 | |
| 3847 | def upload_branch_deps(cl, args): |
| 3848 | """Uploads CLs of local branches that are dependents of the current branch. |
| 3849 | |
| 3850 | If the local branch dependency tree looks like: |
| 3851 | test1 -> test2.1 -> test3.1 |
| 3852 | -> test3.2 |
| 3853 | -> test2.2 -> test3.3 |
| 3854 | |
| 3855 | and you run "git cl upload --dependencies" from test1 then "git cl upload" is |
| 3856 | run on the dependent branches in this order: |
| 3857 | test2.1, test3.1, test3.2, test2.2, test3.3 |
| 3858 | |
| 3859 | Note: This function does not rebase your local dependent branches. Use it when |
| 3860 | you make a change to the parent branch that will not conflict with its |
| 3861 | dependent branches, and you would like their dependencies updated in |
| 3862 | Rietveld. |
| 3863 | """ |
| 3864 | if git_common.is_dirty_git_tree('upload-branch-deps'): |
| 3865 | return 1 |
| 3866 | |
| 3867 | root_branch = cl.GetBranch() |
| 3868 | if root_branch is None: |
| 3869 | DieWithError('Can\'t find dependent branches from detached HEAD state. ' |
| 3870 | 'Get on a branch!') |
Andrii Shyshkalov | 9f27443 | 2018-10-15 16:40:23 +0000 | [diff] [blame] | 3871 | if not cl.GetIssue(): |
rmistry@google.com | 2dd9986 | 2015-06-22 12:22:18 +0000 | [diff] [blame] | 3872 | DieWithError('Current branch does not have an uploaded CL. We cannot set ' |
| 3873 | 'patchset dependencies without an uploaded CL.') |
| 3874 | |
| 3875 | branches = RunGit(['for-each-ref', |
| 3876 | '--format=%(refname:short) %(upstream:short)', |
| 3877 | 'refs/heads']) |
| 3878 | if not branches: |
| 3879 | print('No local branches found.') |
| 3880 | return 0 |
| 3881 | |
| 3882 | # Create a dictionary of all local branches to the branches that are dependent |
| 3883 | # on it. |
| 3884 | tracked_to_dependents = collections.defaultdict(list) |
| 3885 | for b in branches.splitlines(): |
| 3886 | tokens = b.split() |
| 3887 | if len(tokens) == 2: |
| 3888 | branch_name, tracked = tokens |
| 3889 | tracked_to_dependents[tracked].append(branch_name) |
| 3890 | |
vapier | a7fbd5a | 2016-06-16 09:17:49 -0700 | [diff] [blame] | 3891 | print() |
| 3892 | print('The dependent local branches of %s are:' % root_branch) |
rmistry@google.com | 2dd9986 | 2015-06-22 12:22:18 +0000 | [diff] [blame] | 3893 | dependents = [] |
| 3894 | def traverse_dependents_preorder(branch, padding=''): |
| 3895 | dependents_to_process = tracked_to_dependents.get(branch, []) |
| 3896 | padding += ' ' |
| 3897 | for dependent in dependents_to_process: |
vapier | a7fbd5a | 2016-06-16 09:17:49 -0700 | [diff] [blame] | 3898 | print('%s%s' % (padding, dependent)) |
rmistry@google.com | 2dd9986 | 2015-06-22 12:22:18 +0000 | [diff] [blame] | 3899 | dependents.append(dependent) |
| 3900 | traverse_dependents_preorder(dependent, padding) |
| 3901 | traverse_dependents_preorder(root_branch) |
vapier | a7fbd5a | 2016-06-16 09:17:49 -0700 | [diff] [blame] | 3902 | print() |
rmistry@google.com | 2dd9986 | 2015-06-22 12:22:18 +0000 | [diff] [blame] | 3903 | |
| 3904 | if not dependents: |
vapier | a7fbd5a | 2016-06-16 09:17:49 -0700 | [diff] [blame] | 3905 | print('There are no dependent local branches for %s' % root_branch) |
rmistry@google.com | 2dd9986 | 2015-06-22 12:22:18 +0000 | [diff] [blame] | 3906 | return 0 |
| 3907 | |
Andrii Shyshkalov | abc26ac | 2017-03-14 14:49:38 +0100 | [diff] [blame] | 3908 | confirm_or_exit('This command will checkout all dependent branches and run ' |
| 3909 | '"git cl upload".', action='continue') |
rmistry@google.com | 2dd9986 | 2015-06-22 12:22:18 +0000 | [diff] [blame] | 3910 | |
rmistry@google.com | 2dd9986 | 2015-06-22 12:22:18 +0000 | [diff] [blame] | 3911 | # Record all dependents that failed to upload. |
| 3912 | failures = {} |
| 3913 | # Go through all dependents, checkout the branch and upload. |
| 3914 | try: |
| 3915 | for dependent_branch in dependents: |
vapier | a7fbd5a | 2016-06-16 09:17:49 -0700 | [diff] [blame] | 3916 | print() |
| 3917 | print('--------------------------------------') |
| 3918 | print('Running "git cl upload" from %s:' % dependent_branch) |
rmistry@google.com | 2dd9986 | 2015-06-22 12:22:18 +0000 | [diff] [blame] | 3919 | RunGit(['checkout', '-q', dependent_branch]) |
vapier | a7fbd5a | 2016-06-16 09:17:49 -0700 | [diff] [blame] | 3920 | print() |
rmistry@google.com | 2dd9986 | 2015-06-22 12:22:18 +0000 | [diff] [blame] | 3921 | try: |
| 3922 | if CMDupload(OptionParser(), args) != 0: |
vapier | a7fbd5a | 2016-06-16 09:17:49 -0700 | [diff] [blame] | 3923 | print('Upload failed for %s!' % dependent_branch) |
rmistry@google.com | 2dd9986 | 2015-06-22 12:22:18 +0000 | [diff] [blame] | 3924 | failures[dependent_branch] = 1 |
Quinten Yearsley | b2cc4a9 | 2016-12-15 13:53:26 -0800 | [diff] [blame] | 3925 | except: # pylint: disable=bare-except |
rmistry@google.com | 2dd9986 | 2015-06-22 12:22:18 +0000 | [diff] [blame] | 3926 | failures[dependent_branch] = 1 |
vapier | a7fbd5a | 2016-06-16 09:17:49 -0700 | [diff] [blame] | 3927 | print() |
rmistry@google.com | 2dd9986 | 2015-06-22 12:22:18 +0000 | [diff] [blame] | 3928 | finally: |
| 3929 | # Swap back to the original root branch. |
| 3930 | RunGit(['checkout', '-q', root_branch]) |
| 3931 | |
vapier | a7fbd5a | 2016-06-16 09:17:49 -0700 | [diff] [blame] | 3932 | print() |
| 3933 | print('Upload complete for dependent branches!') |
rmistry@google.com | 2dd9986 | 2015-06-22 12:22:18 +0000 | [diff] [blame] | 3934 | for dependent_branch in dependents: |
| 3935 | upload_status = 'failed' if failures.get(dependent_branch) else 'succeeded' |
vapier | a7fbd5a | 2016-06-16 09:17:49 -0700 | [diff] [blame] | 3936 | print(' %s : %s' % (dependent_branch, upload_status)) |
| 3937 | print() |
rmistry@google.com | 2dd9986 | 2015-06-22 12:22:18 +0000 | [diff] [blame] | 3938 | |
| 3939 | return 0 |
| 3940 | |
| 3941 | |
Edward Lemur | 5ba1e9c | 2018-07-23 18:19:02 +0000 | [diff] [blame] | 3942 | @metrics.collector.collect_metrics('git cl archive') |
kmarshall | 3bff56b | 2016-06-06 18:31:47 -0700 | [diff] [blame] | 3943 | def CMDarchive(parser, args): |
| 3944 | """Archives and deletes branches associated with closed changelists.""" |
| 3945 | parser.add_option( |
| 3946 | '-j', '--maxjobs', action='store', type=int, |
kmarshall | 9249e01 | 2016-08-23 12:02:16 -0700 | [diff] [blame] | 3947 | help='The maximum number of jobs to use when retrieving review status.') |
kmarshall | 3bff56b | 2016-06-06 18:31:47 -0700 | [diff] [blame] | 3948 | parser.add_option( |
| 3949 | '-f', '--force', action='store_true', |
| 3950 | help='Bypasses the confirmation prompt.') |
kmarshall | 9249e01 | 2016-08-23 12:02:16 -0700 | [diff] [blame] | 3951 | parser.add_option( |
| 3952 | '-d', '--dry-run', action='store_true', |
| 3953 | help='Skip the branch tagging and removal steps.') |
| 3954 | parser.add_option( |
| 3955 | '-t', '--notags', action='store_true', |
| 3956 | help='Do not tag archived branches. ' |
| 3957 | 'Note: local commit history may be lost.') |
kmarshall | 3bff56b | 2016-06-06 18:31:47 -0700 | [diff] [blame] | 3958 | |
| 3959 | auth.add_auth_options(parser) |
| 3960 | options, args = parser.parse_args(args) |
| 3961 | if args: |
| 3962 | parser.error('Unsupported args: %s' % ' '.join(args)) |
| 3963 | auth_config = auth.extract_auth_config_from_options(options) |
| 3964 | |
| 3965 | branches = RunGit(['for-each-ref', '--format=%(refname)', 'refs/heads']) |
| 3966 | if not branches: |
| 3967 | return 0 |
| 3968 | |
vapier | a7fbd5a | 2016-06-16 09:17:49 -0700 | [diff] [blame] | 3969 | print('Finding all branches associated with closed issues...') |
kmarshall | 3bff56b | 2016-06-06 18:31:47 -0700 | [diff] [blame] | 3970 | changes = [Changelist(branchref=b, auth_config=auth_config) |
| 3971 | for b in branches.splitlines()] |
| 3972 | alignment = max(5, max(len(c.GetBranch()) for c in changes)) |
| 3973 | statuses = get_cl_statuses(changes, |
| 3974 | fine_grained=True, |
| 3975 | max_processes=options.maxjobs) |
| 3976 | proposal = [(cl.GetBranch(), |
| 3977 | 'git-cl-archived-%s-%s' % (cl.GetIssue(), cl.GetBranch())) |
| 3978 | for cl, status in statuses |
Andrii Shyshkalov | 51bdf8c | 2018-10-18 01:07:58 +0000 | [diff] [blame] | 3979 | if status in ('closed', 'rietveld-not-supported')] |
kmarshall | 3bff56b | 2016-06-06 18:31:47 -0700 | [diff] [blame] | 3980 | proposal.sort() |
| 3981 | |
| 3982 | if not proposal: |
vapier | a7fbd5a | 2016-06-16 09:17:49 -0700 | [diff] [blame] | 3983 | print('No branches with closed codereview issues found.') |
kmarshall | 3bff56b | 2016-06-06 18:31:47 -0700 | [diff] [blame] | 3984 | return 0 |
| 3985 | |
| 3986 | current_branch = GetCurrentBranch() |
| 3987 | |
vapier | a7fbd5a | 2016-06-16 09:17:49 -0700 | [diff] [blame] | 3988 | print('\nBranches with closed issues that will be archived:\n') |
kmarshall | 9249e01 | 2016-08-23 12:02:16 -0700 | [diff] [blame] | 3989 | if options.notags: |
| 3990 | for next_item in proposal: |
| 3991 | print(' ' + next_item[0]) |
| 3992 | else: |
| 3993 | print('%*s | %s' % (alignment, 'Branch name', 'Archival tag name')) |
| 3994 | for next_item in proposal: |
| 3995 | print('%*s %s' % (alignment, next_item[0], next_item[1])) |
kmarshall | 3bff56b | 2016-06-06 18:31:47 -0700 | [diff] [blame] | 3996 | |
kmarshall | 9249e01 | 2016-08-23 12:02:16 -0700 | [diff] [blame] | 3997 | # Quit now on precondition failure or if instructed by the user, either |
| 3998 | # via an interactive prompt or by command line flags. |
| 3999 | if options.dry_run: |
| 4000 | print('\nNo changes were made (dry run).\n') |
| 4001 | return 0 |
| 4002 | elif any(branch == current_branch for branch, _ in proposal): |
kmarshall | 3bff56b | 2016-06-06 18:31:47 -0700 | [diff] [blame] | 4003 | print('You are currently on a branch \'%s\' which is associated with a ' |
| 4004 | 'closed codereview issue, so archive cannot proceed. Please ' |
| 4005 | 'checkout another branch and run this command again.' % |
| 4006 | current_branch) |
| 4007 | return 1 |
kmarshall | 9249e01 | 2016-08-23 12:02:16 -0700 | [diff] [blame] | 4008 | elif not options.force: |
sergiyb | 4a5ecbe | 2016-06-20 09:46:00 -0700 | [diff] [blame] | 4009 | answer = ask_for_data('\nProceed with deletion (Y/n)? ').lower() |
| 4010 | if answer not in ('y', ''): |
vapier | a7fbd5a | 2016-06-16 09:17:49 -0700 | [diff] [blame] | 4011 | print('Aborted.') |
kmarshall | 3bff56b | 2016-06-06 18:31:47 -0700 | [diff] [blame] | 4012 | return 1 |
| 4013 | |
| 4014 | for branch, tagname in proposal: |
kmarshall | 9249e01 | 2016-08-23 12:02:16 -0700 | [diff] [blame] | 4015 | if not options.notags: |
| 4016 | RunGit(['tag', tagname, branch]) |
kmarshall | 3bff56b | 2016-06-06 18:31:47 -0700 | [diff] [blame] | 4017 | RunGit(['branch', '-D', branch]) |
kmarshall | 9249e01 | 2016-08-23 12:02:16 -0700 | [diff] [blame] | 4018 | |
vapier | a7fbd5a | 2016-06-16 09:17:49 -0700 | [diff] [blame] | 4019 | print('\nJob\'s done!') |
kmarshall | 3bff56b | 2016-06-06 18:31:47 -0700 | [diff] [blame] | 4020 | |
| 4021 | return 0 |
| 4022 | |
| 4023 | |
Edward Lemur | 5ba1e9c | 2018-07-23 18:19:02 +0000 | [diff] [blame] | 4024 | @metrics.collector.collect_metrics('git cl status') |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 4025 | def CMDstatus(parser, args): |
iannucci@chromium.org | d9c1b20 | 2013-07-24 23:52:11 +0000 | [diff] [blame] | 4026 | """Show status of changelists. |
| 4027 | |
| 4028 | Colors are used to tell the state of the CL unless --fast is used: |
jsbell@chromium.org | aeab41a | 2013-12-10 20:01:22 +0000 | [diff] [blame] | 4029 | - Blue waiting for review |
Aaron Gable | 9ab38c6 | 2017-04-06 14:36:33 -0700 | [diff] [blame] | 4030 | - Yellow waiting for you to reply to review, or not yet sent |
jsbell@chromium.org | aeab41a | 2013-12-10 20:01:22 +0000 | [diff] [blame] | 4031 | - Green LGTM'ed |
Aaron Gable | 9ab38c6 | 2017-04-06 14:36:33 -0700 | [diff] [blame] | 4032 | - Red 'not LGTM'ed |
jsbell@chromium.org | aeab41a | 2013-12-10 20:01:22 +0000 | [diff] [blame] | 4033 | - Magenta in the commit queue |
| 4034 | - Cyan was committed, branch can be deleted |
Aaron Gable | 9ab38c6 | 2017-04-06 14:36:33 -0700 | [diff] [blame] | 4035 | - White error, or unknown status |
iannucci@chromium.org | d9c1b20 | 2013-07-24 23:52:11 +0000 | [diff] [blame] | 4036 | |
| 4037 | Also see 'git cl comments'. |
| 4038 | """ |
Alan Cutter | a3be9a5 | 2019-03-04 18:50:33 +0000 | [diff] [blame] | 4039 | parser.add_option( |
| 4040 | '--no-branch-color', |
| 4041 | action='store_true', |
| 4042 | help='Disable colorized branch names') |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 4043 | parser.add_option('--field', |
phajdan.jr | 289d03e | 2016-08-16 08:21:06 -0700 | [diff] [blame] | 4044 | help='print only specific field (desc|id|patch|status|url)') |
maruel@chromium.org | 1033efd | 2013-07-23 23:25:09 +0000 | [diff] [blame] | 4045 | parser.add_option('-f', '--fast', action='store_true', |
| 4046 | help='Do not retrieve review status') |
calamity@chromium.org | ffde55c | 2015-03-12 00:44:17 +0000 | [diff] [blame] | 4047 | parser.add_option( |
| 4048 | '-j', '--maxjobs', action='store', type=int, |
| 4049 | help='The maximum number of jobs to use when retrieving review status') |
vadimsh@chromium.org | cf6a5d2 | 2015-04-09 22:02:00 +0000 | [diff] [blame] | 4050 | |
| 4051 | auth.add_auth_options(parser) |
iannucci | e53c935 | 2016-08-17 14:40:40 -0700 | [diff] [blame] | 4052 | _add_codereview_issue_select_options( |
| 4053 | parser, 'Must be in conjunction with --field.') |
vadimsh@chromium.org | cf6a5d2 | 2015-04-09 22:02:00 +0000 | [diff] [blame] | 4054 | options, args = parser.parse_args(args) |
iannucci | e53c935 | 2016-08-17 14:40:40 -0700 | [diff] [blame] | 4055 | _process_codereview_issue_select_options(parser, options) |
maruel@chromium.org | 39c0b22 | 2013-08-17 16:57:01 +0000 | [diff] [blame] | 4056 | if args: |
| 4057 | parser.error('Unsupported args: %s' % args) |
vadimsh@chromium.org | cf6a5d2 | 2015-04-09 22:02:00 +0000 | [diff] [blame] | 4058 | auth_config = auth.extract_auth_config_from_options(options) |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 4059 | |
iannucci | e53c935 | 2016-08-17 14:40:40 -0700 | [diff] [blame] | 4060 | if options.issue is not None and not options.field: |
| 4061 | parser.error('--field must be specified with --issue') |
iannucci | 3c972b9 | 2016-08-17 13:24:10 -0700 | [diff] [blame] | 4062 | |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 4063 | if options.field: |
iannucci | 3c972b9 | 2016-08-17 13:24:10 -0700 | [diff] [blame] | 4064 | cl = Changelist(auth_config=auth_config, issue=options.issue, |
| 4065 | codereview=options.forced_codereview) |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 4066 | if options.field.startswith('desc'): |
vapier | a7fbd5a | 2016-06-16 09:17:49 -0700 | [diff] [blame] | 4067 | print(cl.GetDescription()) |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 4068 | elif options.field == 'id': |
| 4069 | issueid = cl.GetIssue() |
| 4070 | if issueid: |
vapier | a7fbd5a | 2016-06-16 09:17:49 -0700 | [diff] [blame] | 4071 | print(issueid) |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 4072 | elif options.field == 'patch': |
Aaron Gable | e8856ee | 2017-12-07 12:41:46 -0800 | [diff] [blame] | 4073 | patchset = cl.GetMostRecentPatchset() |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 4074 | if patchset: |
vapier | a7fbd5a | 2016-06-16 09:17:49 -0700 | [diff] [blame] | 4075 | print(patchset) |
phajdan.jr | 289d03e | 2016-08-16 08:21:06 -0700 | [diff] [blame] | 4076 | elif options.field == 'status': |
| 4077 | print(cl.GetStatus()) |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 4078 | elif options.field == 'url': |
| 4079 | url = cl.GetIssueURL() |
| 4080 | if url: |
vapier | a7fbd5a | 2016-06-16 09:17:49 -0700 | [diff] [blame] | 4081 | print(url) |
maruel@chromium.org | e25c75b | 2013-07-23 18:30:56 +0000 | [diff] [blame] | 4082 | return 0 |
| 4083 | |
| 4084 | branches = RunGit(['for-each-ref', '--format=%(refname)', 'refs/heads']) |
| 4085 | if not branches: |
| 4086 | print('No local branch found.') |
| 4087 | return 0 |
| 4088 | |
clemensh@chromium.org | cbd7dc3 | 2016-05-31 10:33:50 +0000 | [diff] [blame] | 4089 | changes = [ |
vadimsh@chromium.org | cf6a5d2 | 2015-04-09 22:02:00 +0000 | [diff] [blame] | 4090 | Changelist(branchref=b, auth_config=auth_config) |
clemensh@chromium.org | cbd7dc3 | 2016-05-31 10:33:50 +0000 | [diff] [blame] | 4091 | for b in branches.splitlines()] |
vapier | a7fbd5a | 2016-06-16 09:17:49 -0700 | [diff] [blame] | 4092 | print('Branches associated with reviews:') |
clemensh@chromium.org | cbd7dc3 | 2016-05-31 10:33:50 +0000 | [diff] [blame] | 4093 | output = get_cl_statuses(changes, |
calamity@chromium.org | ffde55c | 2015-03-12 00:44:17 +0000 | [diff] [blame] | 4094 | fine_grained=not options.fast, |
clemensh@chromium.org | cbd7dc3 | 2016-05-31 10:33:50 +0000 | [diff] [blame] | 4095 | max_processes=options.maxjobs) |
maruel@chromium.org | 1033efd | 2013-07-23 23:25:09 +0000 | [diff] [blame] | 4096 | |
Daniel McArdle | a23bf59 | 2019-02-12 00:25:12 +0000 | [diff] [blame] | 4097 | current_branch = GetCurrentBranch() |
| 4098 | |
| 4099 | def FormatBranchName(branch, colorize=False): |
| 4100 | """Simulates 'git branch' behavior. Colorizes and prefixes branch name with |
| 4101 | an asterisk when it is the current branch.""" |
| 4102 | |
| 4103 | asterisk = "" |
| 4104 | color = Fore.RESET |
| 4105 | if branch == current_branch: |
| 4106 | asterisk = "* " |
| 4107 | color = Fore.GREEN |
| 4108 | branch_name = ShortBranchName(branch) |
| 4109 | |
| 4110 | if colorize: |
| 4111 | return asterisk + color + branch_name + Fore.RESET |
Daniel McArdle | 452a49f | 2019-02-14 17:28:31 +0000 | [diff] [blame] | 4112 | return asterisk + branch_name |
| 4113 | |
calamity@chromium.org | ffde55c | 2015-03-12 00:44:17 +0000 | [diff] [blame] | 4114 | branch_statuses = {} |
Daniel McArdle | a23bf59 | 2019-02-12 00:25:12 +0000 | [diff] [blame] | 4115 | |
| 4116 | alignment = max(5, max(len(FormatBranchName(c.GetBranch())) for c in changes)) |
clemensh@chromium.org | cbd7dc3 | 2016-05-31 10:33:50 +0000 | [diff] [blame] | 4117 | for cl in sorted(changes, key=lambda c: c.GetBranch()): |
| 4118 | branch = cl.GetBranch() |
calamity@chromium.org | ffde55c | 2015-03-12 00:44:17 +0000 | [diff] [blame] | 4119 | while branch not in branch_statuses: |
clemensh@chromium.org | cbd7dc3 | 2016-05-31 10:33:50 +0000 | [diff] [blame] | 4120 | c, status = output.next() |
| 4121 | branch_statuses[c.GetBranch()] = status |
| 4122 | status = branch_statuses.pop(branch) |
| 4123 | url = cl.GetIssueURL() |
| 4124 | if url and (not status or status == 'error'): |
| 4125 | # The issue probably doesn't exist anymore. |
| 4126 | url += ' (broken)' |
| 4127 | |
nodir@chromium.org | a6de1f4 | 2015-06-10 04:23:17 +0000 | [diff] [blame] | 4128 | color = color_for_status(status) |
maruel@chromium.org | 885f651 | 2013-07-27 02:17:26 +0000 | [diff] [blame] | 4129 | reset = Fore.RESET |
iannucci@chromium.org | 596cd5c | 2016-04-04 21:34:39 +0000 | [diff] [blame] | 4130 | if not setup_color.IS_TTY: |
maruel@chromium.org | 885f651 | 2013-07-27 02:17:26 +0000 | [diff] [blame] | 4131 | color = '' |
| 4132 | reset = '' |
nodir@chromium.org | a6de1f4 | 2015-06-10 04:23:17 +0000 | [diff] [blame] | 4133 | status_str = '(%s)' % status if status else '' |
Daniel McArdle | 452a49f | 2019-02-14 17:28:31 +0000 | [diff] [blame] | 4134 | |
Alan Cutter | a3be9a5 | 2019-03-04 18:50:33 +0000 | [diff] [blame] | 4135 | branch_display = FormatBranchName(branch) |
| 4136 | padding = ' ' * (alignment - len(branch_display)) |
| 4137 | if not options.no_branch_color: |
| 4138 | branch_display = FormatBranchName(branch, colorize=True) |
Daniel McArdle | 452a49f | 2019-02-14 17:28:31 +0000 | [diff] [blame] | 4139 | |
Alan Cutter | a3be9a5 | 2019-03-04 18:50:33 +0000 | [diff] [blame] | 4140 | print(' %s : %s%s %s%s' % (padding + branch_display, color, url, |
| 4141 | status_str, reset)) |
Andrii Shyshkalov | d0e1d9d | 2017-01-24 17:10:51 +0100 | [diff] [blame] | 4142 | |
vapier | a7fbd5a | 2016-06-16 09:17:49 -0700 | [diff] [blame] | 4143 | print() |
Daniel McArdle | a23bf59 | 2019-02-12 00:25:12 +0000 | [diff] [blame] | 4144 | print('Current branch: %s' % current_branch) |
Andrii Shyshkalov | d0e1d9d | 2017-01-24 17:10:51 +0100 | [diff] [blame] | 4145 | for cl in changes: |
Daniel McArdle | a23bf59 | 2019-02-12 00:25:12 +0000 | [diff] [blame] | 4146 | if cl.GetBranch() == current_branch: |
Andrii Shyshkalov | d0e1d9d | 2017-01-24 17:10:51 +0100 | [diff] [blame] | 4147 | break |
dpranke@chromium.org | ee87f58 | 2015-07-31 18:46:25 +0000 | [diff] [blame] | 4148 | if not cl.GetIssue(): |
vapier | a7fbd5a | 2016-06-16 09:17:49 -0700 | [diff] [blame] | 4149 | print('No issue assigned.') |
dpranke@chromium.org | ee87f58 | 2015-07-31 18:46:25 +0000 | [diff] [blame] | 4150 | return 0 |
vapier | a7fbd5a | 2016-06-16 09:17:49 -0700 | [diff] [blame] | 4151 | print('Issue number: %s (%s)' % (cl.GetIssue(), cl.GetIssueURL())) |
maruel@chromium.org | 85616e0 | 2014-07-28 15:37:55 +0000 | [diff] [blame] | 4152 | if not options.fast: |
vapier | a7fbd5a | 2016-06-16 09:17:49 -0700 | [diff] [blame] | 4153 | print('Issue description:') |
| 4154 | print(cl.GetDescription(pretty=True)) |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 4155 | return 0 |
| 4156 | |
| 4157 | |
maruel@chromium.org | 39c0b22 | 2013-08-17 16:57:01 +0000 | [diff] [blame] | 4158 | def colorize_CMDstatus_doc(): |
| 4159 | """To be called once in main() to add colors to git cl status help.""" |
| 4160 | colors = [i for i in dir(Fore) if i[0].isupper()] |
| 4161 | |
| 4162 | def colorize_line(line): |
| 4163 | for color in colors: |
| 4164 | if color in line.upper(): |
Quinten Yearsley | 0c62da9 | 2017-05-31 13:39:42 -0700 | [diff] [blame] | 4165 | # Extract whitespace first and the leading '-'. |
maruel@chromium.org | 39c0b22 | 2013-08-17 16:57:01 +0000 | [diff] [blame] | 4166 | indent = len(line) - len(line.lstrip(' ')) + 1 |
| 4167 | return line[:indent] + getattr(Fore, color) + line[indent:] + Fore.RESET |
| 4168 | return line |
| 4169 | |
| 4170 | lines = CMDstatus.__doc__.splitlines() |
| 4171 | CMDstatus.__doc__ = '\n'.join(colorize_line(l) for l in lines) |
| 4172 | |
| 4173 | |
phajdan.jr | e328cf9 | 2016-08-22 04:12:17 -0700 | [diff] [blame] | 4174 | def write_json(path, contents): |
Stefan Zager | 1306bd0 | 2017-06-22 19:26:46 -0700 | [diff] [blame] | 4175 | if path == '-': |
| 4176 | json.dump(contents, sys.stdout) |
| 4177 | else: |
| 4178 | with open(path, 'w') as f: |
| 4179 | json.dump(contents, f) |
phajdan.jr | e328cf9 | 2016-08-22 04:12:17 -0700 | [diff] [blame] | 4180 | |
| 4181 | |
maruel@chromium.org | 0633fb4 | 2013-08-16 20:06:14 +0000 | [diff] [blame] | 4182 | @subcommand.usage('[issue_number]') |
Edward Lemur | 5ba1e9c | 2018-07-23 18:19:02 +0000 | [diff] [blame] | 4183 | @metrics.collector.collect_metrics('git cl issue') |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 4184 | def CMDissue(parser, args): |
iannucci@chromium.org | d9c1b20 | 2013-07-24 23:52:11 +0000 | [diff] [blame] | 4185 | """Sets or displays the current code review issue number. |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 4186 | |
| 4187 | Pass issue number 0 to clear the current issue. |
iannucci@chromium.org | d9c1b20 | 2013-07-24 23:52:11 +0000 | [diff] [blame] | 4188 | """ |
dnj@chromium.org | 406c440 | 2015-03-03 17:22:28 +0000 | [diff] [blame] | 4189 | parser.add_option('-r', '--reverse', action='store_true', |
| 4190 | help='Lookup the branch(es) for the specified issues. If ' |
| 4191 | 'no issues are specified, all branches with mapped ' |
| 4192 | 'issues will be listed.') |
Stefan Zager | 1306bd0 | 2017-06-22 19:26:46 -0700 | [diff] [blame] | 4193 | parser.add_option('--json', |
| 4194 | help='Path to JSON output file, or "-" for stdout.') |
tandrii@chromium.org | dde6462 | 2016-04-13 17:11:21 +0000 | [diff] [blame] | 4195 | _add_codereview_select_options(parser) |
dnj@chromium.org | 406c440 | 2015-03-03 17:22:28 +0000 | [diff] [blame] | 4196 | options, args = parser.parse_args(args) |
tandrii@chromium.org | dde6462 | 2016-04-13 17:11:21 +0000 | [diff] [blame] | 4197 | _process_codereview_select_options(parser, options) |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 4198 | |
dnj@chromium.org | 406c440 | 2015-03-03 17:22:28 +0000 | [diff] [blame] | 4199 | if options.reverse: |
| 4200 | branches = RunGit(['for-each-ref', 'refs/heads', |
Aaron Gable | ad64abd | 2017-12-04 09:49:13 -0800 | [diff] [blame] | 4201 | '--format=%(refname)']).splitlines() |
dnj@chromium.org | 406c440 | 2015-03-03 17:22:28 +0000 | [diff] [blame] | 4202 | # Reverse issue lookup. |
| 4203 | issue_branch_map = {} |
Daniel Bratell | b56a43a | 2018-09-06 15:49:03 +0000 | [diff] [blame] | 4204 | |
| 4205 | git_config = {} |
| 4206 | for config in RunGit(['config', '--get-regexp', |
| 4207 | r'branch\..*issue']).splitlines(): |
| 4208 | name, _space, val = config.partition(' ') |
| 4209 | git_config[name] = val |
| 4210 | |
dnj@chromium.org | 406c440 | 2015-03-03 17:22:28 +0000 | [diff] [blame] | 4211 | for branch in branches: |
Daniel Bratell | b56a43a | 2018-09-06 15:49:03 +0000 | [diff] [blame] | 4212 | for cls in _CODEREVIEW_IMPLEMENTATIONS.values(): |
| 4213 | config_key = _git_branch_config_key(ShortBranchName(branch), |
| 4214 | cls.IssueConfigKey()) |
| 4215 | issue = git_config.get(config_key) |
| 4216 | if issue: |
| 4217 | issue_branch_map.setdefault(int(issue), []).append(branch) |
dnj@chromium.org | 406c440 | 2015-03-03 17:22:28 +0000 | [diff] [blame] | 4218 | if not args: |
| 4219 | args = sorted(issue_branch_map.iterkeys()) |
phajdan.jr | e328cf9 | 2016-08-22 04:12:17 -0700 | [diff] [blame] | 4220 | result = {} |
dnj@chromium.org | 406c440 | 2015-03-03 17:22:28 +0000 | [diff] [blame] | 4221 | for issue in args: |
Lei Zhang | 5a368d4 | 2019-03-25 23:18:19 +0000 | [diff] [blame] | 4222 | try: |
| 4223 | issue_num = int(issue) |
| 4224 | except ValueError: |
| 4225 | print('ERROR cannot parse issue number: %s' % issue, file=sys.stderr) |
dnj@chromium.org | 406c440 | 2015-03-03 17:22:28 +0000 | [diff] [blame] | 4226 | continue |
Lei Zhang | 5a368d4 | 2019-03-25 23:18:19 +0000 | [diff] [blame] | 4227 | result[issue_num] = issue_branch_map.get(issue_num) |
vapier | a7fbd5a | 2016-06-16 09:17:49 -0700 | [diff] [blame] | 4228 | print('Branch for issue number %s: %s' % ( |
Lei Zhang | 5a368d4 | 2019-03-25 23:18:19 +0000 | [diff] [blame] | 4229 | issue, ', '.join(issue_branch_map.get(issue_num) or ('None',)))) |
phajdan.jr | e328cf9 | 2016-08-22 04:12:17 -0700 | [diff] [blame] | 4230 | if options.json: |
| 4231 | write_json(options.json, result) |
Aaron Gable | 78753da | 2017-06-15 10:35:49 -0700 | [diff] [blame] | 4232 | return 0 |
| 4233 | |
| 4234 | if len(args) > 0: |
| 4235 | issue = ParseIssueNumberArgument(args[0], options.forced_codereview) |
| 4236 | if not issue.valid: |
| 4237 | DieWithError('Pass a url or number to set the issue, 0 to unset it, ' |
| 4238 | 'or no argument to list it.\n' |
| 4239 | 'Maybe you want to run git cl status?') |
| 4240 | cl = Changelist(codereview=issue.codereview) |
| 4241 | cl.SetIssue(issue.issue) |
dnj@chromium.org | 406c440 | 2015-03-03 17:22:28 +0000 | [diff] [blame] | 4242 | else: |
tandrii@chromium.org | dde6462 | 2016-04-13 17:11:21 +0000 | [diff] [blame] | 4243 | cl = Changelist(codereview=options.forced_codereview) |
Aaron Gable | 78753da | 2017-06-15 10:35:49 -0700 | [diff] [blame] | 4244 | print('Issue number: %s (%s)' % (cl.GetIssue(), cl.GetIssueURL())) |
| 4245 | if options.json: |
| 4246 | write_json(options.json, { |
| 4247 | 'issue': cl.GetIssue(), |
| 4248 | 'issue_url': cl.GetIssueURL(), |
| 4249 | }) |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 4250 | return 0 |
| 4251 | |
| 4252 | |
Edward Lemur | 5ba1e9c | 2018-07-23 18:19:02 +0000 | [diff] [blame] | 4253 | @metrics.collector.collect_metrics('git cl comments') |
maruel@chromium.org | 9977a2e | 2012-06-06 22:30:56 +0000 | [diff] [blame] | 4254 | def CMDcomments(parser, args): |
apavlov@chromium.org | e4efd51 | 2014-11-05 09:05:29 +0000 | [diff] [blame] | 4255 | """Shows or posts review comments for any changelist.""" |
| 4256 | parser.add_option('-a', '--add-comment', dest='comment', |
| 4257 | help='comment to add to an issue') |
Sergiy Byelozyorov | cb629a4 | 2018-10-28 19:20:39 +0000 | [diff] [blame] | 4258 | parser.add_option('-p', '--publish', action='store_true', |
| 4259 | help='marks CL as ready and sends comment to reviewers') |
Andrii Shyshkalov | 0d6b46e | 2017-03-17 22:23:22 +0100 | [diff] [blame] | 4260 | parser.add_option('-i', '--issue', dest='issue', |
| 4261 | help='review issue id (defaults to current issue). ' |
| 4262 | 'If given, requires --rietveld or --gerrit') |
Aaron Gable | 0ffdf2d | 2017-06-05 13:01:17 -0700 | [diff] [blame] | 4263 | parser.add_option('-m', '--machine-readable', dest='readable', |
| 4264 | action='store_false', default=True, |
| 4265 | help='output comments in a format compatible with ' |
| 4266 | 'editor parsing') |
smut@google.com | c85ac94 | 2015-09-15 16:34:43 +0000 | [diff] [blame] | 4267 | parser.add_option('-j', '--json-file', |
Stefan Zager | 1306bd0 | 2017-06-22 19:26:46 -0700 | [diff] [blame] | 4268 | help='File to write JSON summary to, or "-" for stdout') |
vadimsh@chromium.org | cf6a5d2 | 2015-04-09 22:02:00 +0000 | [diff] [blame] | 4269 | auth.add_auth_options(parser) |
Andrii Shyshkalov | 625986d | 2017-03-16 00:24:37 +0100 | [diff] [blame] | 4270 | _add_codereview_select_options(parser) |
apavlov@chromium.org | e4efd51 | 2014-11-05 09:05:29 +0000 | [diff] [blame] | 4271 | options, args = parser.parse_args(args) |
Andrii Shyshkalov | 625986d | 2017-03-16 00:24:37 +0100 | [diff] [blame] | 4272 | _process_codereview_select_options(parser, options) |
vadimsh@chromium.org | cf6a5d2 | 2015-04-09 22:02:00 +0000 | [diff] [blame] | 4273 | auth_config = auth.extract_auth_config_from_options(options) |
maruel@chromium.org | 9977a2e | 2012-06-06 22:30:56 +0000 | [diff] [blame] | 4274 | |
apavlov@chromium.org | e4efd51 | 2014-11-05 09:05:29 +0000 | [diff] [blame] | 4275 | issue = None |
| 4276 | if options.issue: |
| 4277 | try: |
| 4278 | issue = int(options.issue) |
| 4279 | except ValueError: |
| 4280 | DieWithError('A review issue id is expected to be a number') |
| 4281 | |
Andrii Shyshkalov | 642641d | 2018-10-16 05:54:41 +0000 | [diff] [blame] | 4282 | cl = Changelist(issue=issue, codereview='gerrit', auth_config=auth_config) |
| 4283 | |
| 4284 | if not cl.IsGerrit(): |
| 4285 | parser.error('rietveld is not supported') |
apavlov@chromium.org | e4efd51 | 2014-11-05 09:05:29 +0000 | [diff] [blame] | 4286 | |
| 4287 | if options.comment: |
Sergiy Byelozyorov | cb629a4 | 2018-10-28 19:20:39 +0000 | [diff] [blame] | 4288 | cl.AddComment(options.comment, options.publish) |
apavlov@chromium.org | e4efd51 | 2014-11-05 09:05:29 +0000 | [diff] [blame] | 4289 | return 0 |
| 4290 | |
Aaron Gable | 0ffdf2d | 2017-06-05 13:01:17 -0700 | [diff] [blame] | 4291 | summary = sorted(cl.GetCommentsSummary(readable=options.readable), |
| 4292 | key=lambda c: c.date) |
Andrii Shyshkalov | d8aa49f | 2017-03-17 16:05:49 +0100 | [diff] [blame] | 4293 | for comment in summary: |
| 4294 | if comment.disapproval: |
apavlov@chromium.org | e4efd51 | 2014-11-05 09:05:29 +0000 | [diff] [blame] | 4295 | color = Fore.RED |
Andrii Shyshkalov | d8aa49f | 2017-03-17 16:05:49 +0100 | [diff] [blame] | 4296 | elif comment.approval: |
apavlov@chromium.org | e4efd51 | 2014-11-05 09:05:29 +0000 | [diff] [blame] | 4297 | color = Fore.GREEN |
Andrii Shyshkalov | d8aa49f | 2017-03-17 16:05:49 +0100 | [diff] [blame] | 4298 | elif comment.sender == cl.GetIssueOwner(): |
apavlov@chromium.org | e4efd51 | 2014-11-05 09:05:29 +0000 | [diff] [blame] | 4299 | color = Fore.MAGENTA |
Quinten Yearsley | 0e617c0 | 2019-02-20 00:37:03 +0000 | [diff] [blame] | 4300 | elif comment.autogenerated: |
| 4301 | color = Fore.CYAN |
apavlov@chromium.org | e4efd51 | 2014-11-05 09:05:29 +0000 | [diff] [blame] | 4302 | else: |
| 4303 | color = Fore.BLUE |
Andrii Shyshkalov | d8aa49f | 2017-03-17 16:05:49 +0100 | [diff] [blame] | 4304 | print('\n%s%s %s%s\n%s' % ( |
| 4305 | color, |
| 4306 | comment.date.strftime('%Y-%m-%d %H:%M:%S UTC'), |
| 4307 | comment.sender, |
| 4308 | Fore.RESET, |
| 4309 | '\n'.join(' ' + l for l in comment.message.strip().splitlines()))) |
| 4310 | |
smut@google.com | c85ac94 | 2015-09-15 16:34:43 +0000 | [diff] [blame] | 4311 | if options.json_file: |
Andrii Shyshkalov | d8aa49f | 2017-03-17 16:05:49 +0100 | [diff] [blame] | 4312 | def pre_serialize(c): |
| 4313 | dct = c.__dict__.copy() |
| 4314 | dct['date'] = dct['date'].strftime('%Y-%m-%d %H:%M:%S.%f') |
| 4315 | return dct |
Leszek Swirski | 45b20c4 | 2018-09-17 17:05:26 +0000 | [diff] [blame] | 4316 | write_json(options.json_file, map(pre_serialize, summary)) |
maruel@chromium.org | 9977a2e | 2012-06-06 22:30:56 +0000 | [diff] [blame] | 4317 | return 0 |
| 4318 | |
| 4319 | |
martiniss@chromium.org | 2b55fe3 | 2016-04-26 20:28:54 +0000 | [diff] [blame] | 4320 | @subcommand.usage('[codereview url or issue id]') |
Edward Lemur | 5ba1e9c | 2018-07-23 18:19:02 +0000 | [diff] [blame] | 4321 | @metrics.collector.collect_metrics('git cl description') |
rsesek@chromium.org | eec7659 | 2013-05-20 16:27:57 +0000 | [diff] [blame] | 4322 | def CMDdescription(parser, args): |
iannucci@chromium.org | d9c1b20 | 2013-07-24 23:52:11 +0000 | [diff] [blame] | 4323 | """Brings up the editor for the current CL's description.""" |
smut@google.com | 34fb6b1 | 2015-07-13 20:03:26 +0000 | [diff] [blame] | 4324 | parser.add_option('-d', '--display', action='store_true', |
| 4325 | help='Display the description instead of opening an editor') |
martiniss@chromium.org | d6648e2 | 2016-04-29 19:22:16 +0000 | [diff] [blame] | 4326 | parser.add_option('-n', '--new-description', |
dnj | ba1b0f3 | 2016-09-02 12:37:42 -0700 | [diff] [blame] | 4327 | help='New description to set for this issue (- for stdin, ' |
| 4328 | '+ to load from local commit HEAD)') |
dsansome | e2d6fd9 | 2016-09-08 00:10:47 -0700 | [diff] [blame] | 4329 | parser.add_option('-f', '--force', action='store_true', |
| 4330 | help='Delete any unpublished Gerrit edits for this issue ' |
| 4331 | 'without prompting') |
martiniss@chromium.org | 2b55fe3 | 2016-04-26 20:28:54 +0000 | [diff] [blame] | 4332 | |
| 4333 | _add_codereview_select_options(parser) |
vadimsh@chromium.org | cf6a5d2 | 2015-04-09 22:02:00 +0000 | [diff] [blame] | 4334 | auth.add_auth_options(parser) |
martiniss@chromium.org | 2b55fe3 | 2016-04-26 20:28:54 +0000 | [diff] [blame] | 4335 | options, args = parser.parse_args(args) |
| 4336 | _process_codereview_select_options(parser, options) |
| 4337 | |
Andrii Shyshkalov | 8039be7 | 2017-01-26 09:38:18 +0100 | [diff] [blame] | 4338 | target_issue_arg = None |
martiniss@chromium.org | 2b55fe3 | 2016-04-26 20:28:54 +0000 | [diff] [blame] | 4339 | if len(args) > 0: |
Andrii Shyshkalov | c971239 | 2017-04-11 13:35:21 +0200 | [diff] [blame] | 4340 | target_issue_arg = ParseIssueNumberArgument(args[0], |
| 4341 | options.forced_codereview) |
Andrii Shyshkalov | 8039be7 | 2017-01-26 09:38:18 +0100 | [diff] [blame] | 4342 | if not target_issue_arg.valid: |
Andrii Shyshkalov | 28d840e | 2017-04-10 15:45:09 +0200 | [diff] [blame] | 4343 | parser.error('invalid codereview url or CL id') |
martiniss@chromium.org | 2b55fe3 | 2016-04-26 20:28:54 +0000 | [diff] [blame] | 4344 | |
martiniss | 6eda05f | 2016-06-30 10:18:35 -0700 | [diff] [blame] | 4345 | kwargs = { |
Andrii Shyshkalov | dd672fb | 2018-10-16 06:09:51 +0000 | [diff] [blame] | 4346 | 'auth_config': auth.extract_auth_config_from_options(options), |
| 4347 | 'codereview': options.forced_codereview, |
martiniss | 6eda05f | 2016-06-30 10:18:35 -0700 | [diff] [blame] | 4348 | } |
Andrii Shyshkalov | c971239 | 2017-04-11 13:35:21 +0200 | [diff] [blame] | 4349 | detected_codereview_from_url = False |
Andrii Shyshkalov | 8039be7 | 2017-01-26 09:38:18 +0100 | [diff] [blame] | 4350 | if target_issue_arg: |
| 4351 | kwargs['issue'] = target_issue_arg.issue |
| 4352 | kwargs['codereview_host'] = target_issue_arg.hostname |
Andrii Shyshkalov | c971239 | 2017-04-11 13:35:21 +0200 | [diff] [blame] | 4353 | if target_issue_arg.codereview and not options.forced_codereview: |
| 4354 | detected_codereview_from_url = True |
| 4355 | kwargs['codereview'] = target_issue_arg.codereview |
martiniss | 6eda05f | 2016-06-30 10:18:35 -0700 | [diff] [blame] | 4356 | |
| 4357 | cl = Changelist(**kwargs) |
rsesek@chromium.org | eec7659 | 2013-05-20 16:27:57 +0000 | [diff] [blame] | 4358 | if not cl.GetIssue(): |
Andrii Shyshkalov | c971239 | 2017-04-11 13:35:21 +0200 | [diff] [blame] | 4359 | assert not detected_codereview_from_url |
rsesek@chromium.org | eec7659 | 2013-05-20 16:27:57 +0000 | [diff] [blame] | 4360 | DieWithError('This branch has no associated changelist.') |
Andrii Shyshkalov | c971239 | 2017-04-11 13:35:21 +0200 | [diff] [blame] | 4361 | |
| 4362 | if detected_codereview_from_url: |
| 4363 | logging.info('canonical issue/change URL: %s (type: %s)\n', |
| 4364 | cl.GetIssueURL(), target_issue_arg.codereview) |
| 4365 | |
rsesek@chromium.org | eec7659 | 2013-05-20 16:27:57 +0000 | [diff] [blame] | 4366 | description = ChangeDescription(cl.GetDescription()) |
martiniss@chromium.org | d6648e2 | 2016-04-29 19:22:16 +0000 | [diff] [blame] | 4367 | |
smut@google.com | 34fb6b1 | 2015-07-13 20:03:26 +0000 | [diff] [blame] | 4368 | if options.display: |
vapier | a7fbd5a | 2016-06-16 09:17:49 -0700 | [diff] [blame] | 4369 | print(description.description) |
smut@google.com | 34fb6b1 | 2015-07-13 20:03:26 +0000 | [diff] [blame] | 4370 | return 0 |
martiniss@chromium.org | d6648e2 | 2016-04-29 19:22:16 +0000 | [diff] [blame] | 4371 | |
| 4372 | if options.new_description: |
| 4373 | text = options.new_description |
| 4374 | if text == '-': |
| 4375 | text = '\n'.join(l.rstrip() for l in sys.stdin) |
dnj | ba1b0f3 | 2016-09-02 12:37:42 -0700 | [diff] [blame] | 4376 | elif text == '+': |
| 4377 | base_branch = cl.GetCommonAncestorWithUpstream() |
| 4378 | change = cl.GetChange(base_branch, None, local_description=True) |
| 4379 | text = change.FullDescriptionText() |
martiniss@chromium.org | d6648e2 | 2016-04-29 19:22:16 +0000 | [diff] [blame] | 4380 | |
| 4381 | description.set_description(text) |
| 4382 | else: |
Aaron Gable | 3a16ed1 | 2017-03-23 10:51:55 -0700 | [diff] [blame] | 4383 | description.prompt(git_footer=cl.IsGerrit()) |
martiniss@chromium.org | d6648e2 | 2016-04-29 19:22:16 +0000 | [diff] [blame] | 4384 | |
Andrii Shyshkalov | 680253d | 2017-03-15 21:07:36 +0100 | [diff] [blame] | 4385 | if cl.GetDescription().strip() != description.description: |
dsansome | e2d6fd9 | 2016-09-08 00:10:47 -0700 | [diff] [blame] | 4386 | cl.UpdateDescription(description.description, force=options.force) |
rsesek@chromium.org | eec7659 | 2013-05-20 16:27:57 +0000 | [diff] [blame] | 4387 | return 0 |
| 4388 | |
| 4389 | |
Edward Lemur | 5ba1e9c | 2018-07-23 18:19:02 +0000 | [diff] [blame] | 4390 | @metrics.collector.collect_metrics('git cl lint') |
thestig@chromium.org | 44202a2 | 2014-03-11 19:22:18 +0000 | [diff] [blame] | 4391 | def CMDlint(parser, args): |
| 4392 | """Runs cpplint on the current changelist.""" |
tzik@chromium.org | f204d4b | 2014-03-13 07:40:55 +0000 | [diff] [blame] | 4393 | parser.add_option('--filter', action='append', metavar='-x,+y', |
| 4394 | help='Comma-separated list of cpplint\'s category-filters') |
vadimsh@chromium.org | cf6a5d2 | 2015-04-09 22:02:00 +0000 | [diff] [blame] | 4395 | auth.add_auth_options(parser) |
| 4396 | options, args = parser.parse_args(args) |
| 4397 | auth_config = auth.extract_auth_config_from_options(options) |
thestig@chromium.org | 44202a2 | 2014-03-11 19:22:18 +0000 | [diff] [blame] | 4398 | |
| 4399 | # Access to a protected member _XX of a client class |
Quinten Yearsley | b2cc4a9 | 2016-12-15 13:53:26 -0800 | [diff] [blame] | 4400 | # pylint: disable=protected-access |
thestig@chromium.org | 44202a2 | 2014-03-11 19:22:18 +0000 | [diff] [blame] | 4401 | try: |
| 4402 | import cpplint |
| 4403 | import cpplint_chromium |
| 4404 | except ImportError: |
vapier | a7fbd5a | 2016-06-16 09:17:49 -0700 | [diff] [blame] | 4405 | print('Your depot_tools is missing cpplint.py and/or cpplint_chromium.py.') |
thestig@chromium.org | 44202a2 | 2014-03-11 19:22:18 +0000 | [diff] [blame] | 4406 | return 1 |
| 4407 | |
| 4408 | # Change the current working directory before calling lint so that it |
| 4409 | # shows the correct base. |
| 4410 | previous_cwd = os.getcwd() |
| 4411 | os.chdir(settings.GetRoot()) |
| 4412 | try: |
vadimsh@chromium.org | cf6a5d2 | 2015-04-09 22:02:00 +0000 | [diff] [blame] | 4413 | cl = Changelist(auth_config=auth_config) |
thestig@chromium.org | 44202a2 | 2014-03-11 19:22:18 +0000 | [diff] [blame] | 4414 | change = cl.GetChange(cl.GetCommonAncestorWithUpstream(), None) |
| 4415 | files = [f.LocalPath() for f in change.AffectedFiles()] |
thestig@chromium.org | 5839eb5 | 2014-05-30 16:20:51 +0000 | [diff] [blame] | 4416 | if not files: |
vapier | a7fbd5a | 2016-06-16 09:17:49 -0700 | [diff] [blame] | 4417 | print('Cannot lint an empty CL') |
thestig@chromium.org | 5839eb5 | 2014-05-30 16:20:51 +0000 | [diff] [blame] | 4418 | return 1 |
thestig@chromium.org | 44202a2 | 2014-03-11 19:22:18 +0000 | [diff] [blame] | 4419 | |
| 4420 | # Process cpplints arguments if any. |
tzik@chromium.org | f204d4b | 2014-03-13 07:40:55 +0000 | [diff] [blame] | 4421 | command = args + files |
| 4422 | if options.filter: |
| 4423 | command = ['--filter=' + ','.join(options.filter)] + command |
| 4424 | filenames = cpplint.ParseArguments(command) |
thestig@chromium.org | 44202a2 | 2014-03-11 19:22:18 +0000 | [diff] [blame] | 4425 | |
| 4426 | white_regex = re.compile(settings.GetLintRegex()) |
| 4427 | black_regex = re.compile(settings.GetLintIgnoreRegex()) |
| 4428 | extra_check_functions = [cpplint_chromium.CheckPointerDeclarationWhitespace] |
| 4429 | for filename in filenames: |
| 4430 | if white_regex.match(filename): |
| 4431 | if black_regex.match(filename): |
vapier | a7fbd5a | 2016-06-16 09:17:49 -0700 | [diff] [blame] | 4432 | print('Ignoring file %s' % filename) |
thestig@chromium.org | 44202a2 | 2014-03-11 19:22:18 +0000 | [diff] [blame] | 4433 | else: |
| 4434 | cpplint.ProcessFile(filename, cpplint._cpplint_state.verbose_level, |
| 4435 | extra_check_functions) |
| 4436 | else: |
vapier | a7fbd5a | 2016-06-16 09:17:49 -0700 | [diff] [blame] | 4437 | print('Skipping file %s' % filename) |
thestig@chromium.org | 44202a2 | 2014-03-11 19:22:18 +0000 | [diff] [blame] | 4438 | finally: |
| 4439 | os.chdir(previous_cwd) |
vapier | a7fbd5a | 2016-06-16 09:17:49 -0700 | [diff] [blame] | 4440 | print('Total errors found: %d\n' % cpplint._cpplint_state.error_count) |
thestig@chromium.org | 44202a2 | 2014-03-11 19:22:18 +0000 | [diff] [blame] | 4441 | if cpplint._cpplint_state.error_count != 0: |
| 4442 | return 1 |
| 4443 | return 0 |
| 4444 | |
| 4445 | |
Edward Lemur | 5ba1e9c | 2018-07-23 18:19:02 +0000 | [diff] [blame] | 4446 | @metrics.collector.collect_metrics('git cl presubmit') |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 4447 | def CMDpresubmit(parser, args): |
iannucci@chromium.org | d9c1b20 | 2013-07-24 23:52:11 +0000 | [diff] [blame] | 4448 | """Runs presubmit tests on the current changelist.""" |
ilevy@chromium.org | 375a902 | 2013-01-07 01:12:05 +0000 | [diff] [blame] | 4449 | parser.add_option('-u', '--upload', action='store_true', |
Aaron Gable | 1bc7bfe | 2016-12-19 10:08:14 -0800 | [diff] [blame] | 4450 | help='Run upload hook instead of the push hook') |
ilevy@chromium.org | 375a902 | 2013-01-07 01:12:05 +0000 | [diff] [blame] | 4451 | parser.add_option('-f', '--force', action='store_true', |
sbc@chromium.org | 495ad15 | 2012-09-04 23:07:42 +0000 | [diff] [blame] | 4452 | help='Run checks even if tree is dirty') |
Aaron Gable | 8076c28 | 2017-11-29 14:39:41 -0800 | [diff] [blame] | 4453 | parser.add_option('--all', action='store_true', |
| 4454 | help='Run checks against all files, not just modified ones') |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 4455 | parser.add_option('--parallel', action='store_true', |
| 4456 | help='Run all tests specified by input_api.RunTests in all ' |
| 4457 | 'PRESUBMIT files in parallel.') |
vadimsh@chromium.org | cf6a5d2 | 2015-04-09 22:02:00 +0000 | [diff] [blame] | 4458 | auth.add_auth_options(parser) |
| 4459 | options, args = parser.parse_args(args) |
| 4460 | auth_config = auth.extract_auth_config_from_options(options) |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 4461 | |
sbc@chromium.org | 71437c0 | 2015-04-09 19:29:40 +0000 | [diff] [blame] | 4462 | if not options.force and git_common.is_dirty_git_tree('presubmit'): |
vapier | a7fbd5a | 2016-06-16 09:17:49 -0700 | [diff] [blame] | 4463 | print('use --force to check even if tree is dirty.') |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 4464 | return 1 |
| 4465 | |
vadimsh@chromium.org | cf6a5d2 | 2015-04-09 22:02:00 +0000 | [diff] [blame] | 4466 | cl = Changelist(auth_config=auth_config) |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 4467 | if args: |
| 4468 | base_branch = args[0] |
| 4469 | else: |
ilevy@chromium.org | 0f58fa8 | 2012-11-05 01:45:20 +0000 | [diff] [blame] | 4470 | # Default to diffing against the common ancestor of the upstream branch. |
thestig@chromium.org | 8b0553c | 2014-02-11 00:33:37 +0000 | [diff] [blame] | 4471 | base_branch = cl.GetCommonAncestorWithUpstream() |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 4472 | |
Aaron Gable | 8076c28 | 2017-11-29 14:39:41 -0800 | [diff] [blame] | 4473 | if options.all: |
| 4474 | base_change = cl.GetChange(base_branch, None) |
| 4475 | files = [('M', f) for f in base_change.AllFiles()] |
| 4476 | change = presubmit_support.GitChange( |
| 4477 | base_change.Name(), |
| 4478 | base_change.FullDescriptionText(), |
| 4479 | base_change.RepositoryRoot(), |
| 4480 | files, |
| 4481 | base_change.issue, |
| 4482 | base_change.patchset, |
| 4483 | base_change.author_email, |
| 4484 | base_change._upstream) |
| 4485 | else: |
| 4486 | change = cl.GetChange(base_branch, None) |
| 4487 | |
ilevy@chromium.org | 051ad0e | 2013-03-04 21:57:34 +0000 | [diff] [blame] | 4488 | cl.RunHook( |
| 4489 | committing=not options.upload, |
| 4490 | may_prompt=False, |
| 4491 | verbose=options.verbose, |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 4492 | change=change, |
| 4493 | parallel=options.parallel) |
dpranke@chromium.org | 0a2bb37 | 2011-03-25 01:16:22 +0000 | [diff] [blame] | 4494 | return 0 |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 4495 | |
| 4496 | |
tandrii@chromium.org | 65874e1 | 2016-03-04 12:03:02 +0000 | [diff] [blame] | 4497 | def GenerateGerritChangeId(message): |
| 4498 | """Returns Ixxxxxx...xxx change id. |
| 4499 | |
| 4500 | Works the same way as |
| 4501 | https://gerrit-review.googlesource.com/tools/hooks/commit-msg |
| 4502 | but can be called on demand on all platforms. |
| 4503 | |
| 4504 | The basic idea is to generate git hash of a state of the tree, original commit |
| 4505 | message, author/committer info and timestamps. |
| 4506 | """ |
| 4507 | lines = [] |
| 4508 | tree_hash = RunGitSilent(['write-tree']) |
| 4509 | lines.append('tree %s' % tree_hash.strip()) |
| 4510 | code, parent = RunGitWithCode(['rev-parse', 'HEAD~0'], suppress_stderr=False) |
| 4511 | if code == 0: |
| 4512 | lines.append('parent %s' % parent.strip()) |
| 4513 | author = RunGitSilent(['var', 'GIT_AUTHOR_IDENT']) |
| 4514 | lines.append('author %s' % author.strip()) |
| 4515 | committer = RunGitSilent(['var', 'GIT_COMMITTER_IDENT']) |
| 4516 | lines.append('committer %s' % committer.strip()) |
| 4517 | lines.append('') |
| 4518 | # Note: Gerrit's commit-hook actually cleans message of some lines and |
| 4519 | # whitespace. This code is not doing this, but it clearly won't decrease |
| 4520 | # entropy. |
| 4521 | lines.append(message) |
| 4522 | change_hash = RunCommand(['git', 'hash-object', '-t', 'commit', '--stdin'], |
Raul Tambre | b946b23 | 2019-03-26 14:48:46 +0000 | [diff] [blame] | 4523 | stdin=('\n'.join(lines)).encode()) |
tandrii@chromium.org | 65874e1 | 2016-03-04 12:03:02 +0000 | [diff] [blame] | 4524 | return 'I%s' % change_hash.strip() |
| 4525 | |
| 4526 | |
Andrii Shyshkalov | f3a20ae | 2017-01-24 21:23:57 +0100 | [diff] [blame] | 4527 | def GetTargetRef(remote, remote_branch, target_branch): |
wittman@chromium.org | 455dc92 | 2015-01-26 20:15:50 +0000 | [diff] [blame] | 4528 | """Computes the remote branch ref to use for the CL. |
| 4529 | |
| 4530 | Args: |
| 4531 | remote (str): The git remote for the CL. |
| 4532 | remote_branch (str): The git remote branch for the CL. |
| 4533 | target_branch (str): The target branch specified by the user. |
wittman@chromium.org | 455dc92 | 2015-01-26 20:15:50 +0000 | [diff] [blame] | 4534 | """ |
| 4535 | if not (remote and remote_branch): |
| 4536 | return None |
bauerb@chromium.org | 27386dd | 2015-02-16 10:45:39 +0000 | [diff] [blame] | 4537 | |
wittman@chromium.org | 455dc92 | 2015-01-26 20:15:50 +0000 | [diff] [blame] | 4538 | if target_branch: |
Quinten Yearsley | 0c62da9 | 2017-05-31 13:39:42 -0700 | [diff] [blame] | 4539 | # Canonicalize branch references to the equivalent local full symbolic |
wittman@chromium.org | 455dc92 | 2015-01-26 20:15:50 +0000 | [diff] [blame] | 4540 | # refs, which are then translated into the remote full symbolic refs |
| 4541 | # below. |
| 4542 | if '/' not in target_branch: |
| 4543 | remote_branch = 'refs/remotes/%s/%s' % (remote, target_branch) |
| 4544 | else: |
| 4545 | prefix_replacements = ( |
| 4546 | ('^((refs/)?remotes/)?branch-heads/', 'refs/remotes/branch-heads/'), |
| 4547 | ('^((refs/)?remotes/)?%s/' % remote, 'refs/remotes/%s/' % remote), |
| 4548 | ('^(refs/)?heads/', 'refs/remotes/%s/' % remote), |
| 4549 | ) |
| 4550 | match = None |
| 4551 | for regex, replacement in prefix_replacements: |
| 4552 | match = re.search(regex, target_branch) |
| 4553 | if match: |
| 4554 | remote_branch = target_branch.replace(match.group(0), replacement) |
| 4555 | break |
| 4556 | if not match: |
| 4557 | # This is a branch path but not one we recognize; use as-is. |
| 4558 | remote_branch = target_branch |
rmistry@google.com | c68112d | 2015-03-03 12:48:06 +0000 | [diff] [blame] | 4559 | elif remote_branch in REFS_THAT_ALIAS_TO_OTHER_REFS: |
| 4560 | # Handle the refs that need to land in different refs. |
| 4561 | remote_branch = REFS_THAT_ALIAS_TO_OTHER_REFS[remote_branch] |
bauerb@chromium.org | 27386dd | 2015-02-16 10:45:39 +0000 | [diff] [blame] | 4562 | |
wittman@chromium.org | 455dc92 | 2015-01-26 20:15:50 +0000 | [diff] [blame] | 4563 | # Create the true path to the remote branch. |
| 4564 | # Does the following translation: |
| 4565 | # * refs/remotes/origin/refs/diff/test -> refs/diff/test |
| 4566 | # * refs/remotes/origin/master -> refs/heads/master |
| 4567 | # * refs/remotes/branch-heads/test -> refs/branch-heads/test |
| 4568 | if remote_branch.startswith('refs/remotes/%s/refs/' % remote): |
| 4569 | remote_branch = remote_branch.replace('refs/remotes/%s/' % remote, '') |
| 4570 | elif remote_branch.startswith('refs/remotes/%s/' % remote): |
| 4571 | remote_branch = remote_branch.replace('refs/remotes/%s/' % remote, |
| 4572 | 'refs/heads/') |
| 4573 | elif remote_branch.startswith('refs/remotes/branch-heads'): |
| 4574 | remote_branch = remote_branch.replace('refs/remotes/', 'refs/') |
Andrii Shyshkalov | 768f1d8 | 2016-12-08 15:10:13 +0100 | [diff] [blame] | 4575 | |
wittman@chromium.org | 455dc92 | 2015-01-26 20:15:50 +0000 | [diff] [blame] | 4576 | return remote_branch |
| 4577 | |
| 4578 | |
maruel@chromium.org | eb52a5c | 2013-04-10 23:17:09 +0000 | [diff] [blame] | 4579 | def cleanup_list(l): |
| 4580 | """Fixes a list so that comma separated items are put as individual items. |
| 4581 | |
| 4582 | So that "--reviewers joe@c,john@c --reviewers joa@c" results in |
| 4583 | options.reviewers == sorted(['joe@c', 'john@c', 'joa@c']). |
| 4584 | """ |
| 4585 | items = sum((i.split(',') for i in l), []) |
| 4586 | stripped_items = (i.strip() for i in items) |
| 4587 | return sorted(filter(None, stripped_items)) |
| 4588 | |
| 4589 | |
Aaron Gable | 4db38df | 2017-11-03 14:59:07 -0700 | [diff] [blame] | 4590 | @subcommand.usage('[flags]') |
Edward Lemur | 5ba1e9c | 2018-07-23 18:19:02 +0000 | [diff] [blame] | 4591 | @metrics.collector.collect_metrics('git cl upload') |
ukai@chromium.org | e807781 | 2012-02-03 03:41:46 +0000 | [diff] [blame] | 4592 | def CMDupload(parser, args): |
rmistry@google.com | 78948ed | 2015-07-08 23:09:57 +0000 | [diff] [blame] | 4593 | """Uploads the current changelist to codereview. |
| 4594 | |
| 4595 | Can skip dependency patchset uploads for a branch by running: |
| 4596 | git config branch.branch_name.skip-deps-uploads True |
| 4597 | To unset run: |
| 4598 | git config --unset branch.branch_name.skip-deps-uploads |
| 4599 | Can also set the above globally by using the --global flag. |
Dominic Battre | 7d1c484 | 2017-10-27 09:17:28 +0200 | [diff] [blame] | 4600 | |
| 4601 | If the name of the checked out branch starts with "bug-" or "fix-" followed by |
| 4602 | a bug number, this bug number is automatically populated in the CL |
| 4603 | description. |
Nodir Turakulov | d0e2cd2 | 2017-11-15 10:22:06 -0800 | [diff] [blame] | 4604 | |
| 4605 | If subject contains text in square brackets or has "<text>: " prefix, such |
| 4606 | text(s) is treated as Gerrit hashtags. For example, CLs with subjects |
| 4607 | [git-cl] add support for hashtags |
| 4608 | Foo bar: implement foo |
| 4609 | will be hashtagged with "git-cl" and "foo-bar" respectively. |
rmistry@google.com | 78948ed | 2015-07-08 23:09:57 +0000 | [diff] [blame] | 4610 | """ |
ukai@chromium.org | e807781 | 2012-02-03 03:41:46 +0000 | [diff] [blame] | 4611 | parser.add_option('--bypass-hooks', action='store_true', dest='bypass_hooks', |
| 4612 | help='bypass upload presubmit hook') |
brettw@chromium.org | b65c43c | 2013-06-10 22:04:49 +0000 | [diff] [blame] | 4613 | parser.add_option('--bypass-watchlists', action='store_true', |
| 4614 | dest='bypass_watchlists', |
| 4615 | help='bypass watchlists auto CC-ing reviewers') |
Aaron Gable | f7543cd | 2017-07-20 14:26:31 -0700 | [diff] [blame] | 4616 | parser.add_option('-f', '--force', action='store_true', dest='force', |
ukai@chromium.org | e807781 | 2012-02-03 03:41:46 +0000 | [diff] [blame] | 4617 | help="force yes to questions (don't prompt)") |
Aaron Gable | 1bc7bfe | 2016-12-19 10:08:14 -0800 | [diff] [blame] | 4618 | parser.add_option('--message', '-m', dest='message', |
| 4619 | help='message for patchset') |
tandrii | f9aefb7 | 2016-07-01 09:06:51 -0700 | [diff] [blame] | 4620 | parser.add_option('-b', '--bug', |
| 4621 | help='pre-populate the bug number(s) for this issue. ' |
| 4622 | 'If several, separate with commas') |
tandrii | b80458a | 2016-06-23 12:20:07 -0700 | [diff] [blame] | 4623 | parser.add_option('--message-file', dest='message_file', |
| 4624 | help='file which contains message for patchset') |
Aaron Gable | 1bc7bfe | 2016-12-19 10:08:14 -0800 | [diff] [blame] | 4625 | parser.add_option('--title', '-t', dest='title', |
| 4626 | help='title for patchset') |
ukai@chromium.org | e807781 | 2012-02-03 03:41:46 +0000 | [diff] [blame] | 4627 | parser.add_option('-r', '--reviewers', |
maruel@chromium.org | eb52a5c | 2013-04-10 23:17:09 +0000 | [diff] [blame] | 4628 | action='append', default=[], |
ukai@chromium.org | e807781 | 2012-02-03 03:41:46 +0000 | [diff] [blame] | 4629 | help='reviewer email addresses') |
Robert Iannucci | 6c98dc6 | 2017-04-18 11:38:00 -0700 | [diff] [blame] | 4630 | parser.add_option('--tbrs', |
| 4631 | action='append', default=[], |
| 4632 | help='TBR email addresses') |
ukai@chromium.org | e807781 | 2012-02-03 03:41:46 +0000 | [diff] [blame] | 4633 | parser.add_option('--cc', |
maruel@chromium.org | eb52a5c | 2013-04-10 23:17:09 +0000 | [diff] [blame] | 4634 | action='append', default=[], |
ukai@chromium.org | e807781 | 2012-02-03 03:41:46 +0000 | [diff] [blame] | 4635 | help='cc email addresses') |
Nodir Turakulov | d0e2cd2 | 2017-11-15 10:22:06 -0800 | [diff] [blame] | 4636 | parser.add_option('--hashtag', dest='hashtags', |
| 4637 | action='append', default=[], |
| 4638 | help=('Gerrit hashtag for new CL; ' |
| 4639 | 'can be applied multiple times')) |
adamk@chromium.org | 36f4730 | 2013-04-05 01:08:31 +0000 | [diff] [blame] | 4640 | parser.add_option('-s', '--send-mail', action='store_true', |
Aaron Gable | 59f4851 | 2017-01-12 10:54:46 -0800 | [diff] [blame] | 4641 | help='send email to reviewer(s) and cc(s) immediately') |
ukai@chromium.org | e807781 | 2012-02-03 03:41:46 +0000 | [diff] [blame] | 4642 | parser.add_option('-c', '--use-commit-queue', action='store_true', |
Aaron Gable | edbc413 | 2017-09-11 13:22:28 -0700 | [diff] [blame] | 4643 | help='tell the commit queue to commit this patchset; ' |
| 4644 | 'implies --send-mail') |
ukai@chromium.org | 8ef7ab2 | 2012-11-28 04:24:52 +0000 | [diff] [blame] | 4645 | parser.add_option('--target_branch', |
pgervais@chromium.org | b9f2751 | 2014-08-08 15:52:33 +0000 | [diff] [blame] | 4646 | '--target-branch', |
wittman@chromium.org | 455dc92 | 2015-01-26 20:15:50 +0000 | [diff] [blame] | 4647 | metavar='TARGET', |
| 4648 | help='Apply CL to remote ref TARGET. ' + |
| 4649 | 'Default: remote branch head, or master') |
bauerb@chromium.org | 27386dd | 2015-02-16 10:45:39 +0000 | [diff] [blame] | 4650 | parser.add_option('--squash', action='store_true', |
Nodir Turakulov | d0e2cd2 | 2017-11-15 10:22:06 -0800 | [diff] [blame] | 4651 | help='Squash multiple commits into one') |
bauerb@chromium.org | 54b400c | 2016-01-14 10:08:25 +0000 | [diff] [blame] | 4652 | parser.add_option('--no-squash', action='store_true', |
Nodir Turakulov | d0e2cd2 | 2017-11-15 10:22:06 -0800 | [diff] [blame] | 4653 | help='Don\'t squash multiple commits into one') |
rmistry | 9eadede | 2016-09-19 11:22:43 -0700 | [diff] [blame] | 4654 | parser.add_option('--topic', default=None, |
Nodir Turakulov | d0e2cd2 | 2017-11-15 10:22:06 -0800 | [diff] [blame] | 4655 | help='Topic to specify when uploading') |
Robert Iannucci | f2708bd | 2017-04-17 15:49:02 -0700 | [diff] [blame] | 4656 | parser.add_option('--tbr-owners', dest='add_owners_to', action='store_const', |
| 4657 | const='TBR', help='add a set of OWNERS to TBR') |
| 4658 | parser.add_option('--r-owners', dest='add_owners_to', action='store_const', |
| 4659 | const='R', help='add a set of OWNERS to R') |
tandrii@chromium.org | d50452a | 2015-11-23 16:38:15 +0000 | [diff] [blame] | 4660 | parser.add_option('-d', '--cq-dry-run', dest='cq_dry_run', |
| 4661 | action='store_true', |
rmistry@google.com | ef96622 | 2015-04-07 11:15:01 +0000 | [diff] [blame] | 4662 | help='Send the patchset to do a CQ dry run right after ' |
| 4663 | 'upload.') |
rmistry@google.com | 2dd9986 | 2015-06-22 12:22:18 +0000 | [diff] [blame] | 4664 | parser.add_option('--dependencies', action='store_true', |
| 4665 | help='Uploads CLs of all the local branches that depend on ' |
| 4666 | 'the current branch') |
Ravi Mistry | 31e7d56 | 2018-04-02 12:53:57 -0400 | [diff] [blame] | 4667 | parser.add_option('-a', '--enable-auto-submit', action='store_true', |
| 4668 | help='Sends your change to the CQ after an approval. Only ' |
| 4669 | 'works on repos that have the Auto-Submit label ' |
| 4670 | 'enabled') |
Edward Lesmes | 8e28279 | 2018-04-03 18:50:29 -0400 | [diff] [blame] | 4671 | parser.add_option('--parallel', action='store_true', |
| 4672 | help='Run all tests specified by input_api.RunTests in all ' |
| 4673 | 'PRESUBMIT files in parallel.') |
pgervais@chromium.org | 9114137 | 2014-01-09 23:27:20 +0000 | [diff] [blame] | 4674 | |
Sergiy Byelozyorov | 1aa405f | 2018-09-18 17:38:43 +0000 | [diff] [blame] | 4675 | parser.add_option('--no-autocc', action='store_true', |
| 4676 | help='Disables automatic addition of CC emails') |
Nodir Turakulov | d0e2cd2 | 2017-11-15 10:22:06 -0800 | [diff] [blame] | 4677 | parser.add_option('--private', action='store_true', |
Sergiy Byelozyorov | 1aa405f | 2018-09-18 17:38:43 +0000 | [diff] [blame] | 4678 | help='Set the review private. This implies --no-autocc.') |
| 4679 | |
rmistry@google.com | 2dd9986 | 2015-06-22 12:22:18 +0000 | [diff] [blame] | 4680 | orig_args = args |
vadimsh@chromium.org | cf6a5d2 | 2015-04-09 22:02:00 +0000 | [diff] [blame] | 4681 | auth.add_auth_options(parser) |
tandrii@chromium.org | dde6462 | 2016-04-13 17:11:21 +0000 | [diff] [blame] | 4682 | _add_codereview_select_options(parser) |
ukai@chromium.org | e807781 | 2012-02-03 03:41:46 +0000 | [diff] [blame] | 4683 | (options, args) = parser.parse_args(args) |
tandrii@chromium.org | dde6462 | 2016-04-13 17:11:21 +0000 | [diff] [blame] | 4684 | _process_codereview_select_options(parser, options) |
vadimsh@chromium.org | cf6a5d2 | 2015-04-09 22:02:00 +0000 | [diff] [blame] | 4685 | auth_config = auth.extract_auth_config_from_options(options) |
ukai@chromium.org | e807781 | 2012-02-03 03:41:46 +0000 | [diff] [blame] | 4686 | |
sbc@chromium.org | 71437c0 | 2015-04-09 19:29:40 +0000 | [diff] [blame] | 4687 | if git_common.is_dirty_git_tree('upload'): |
ukai@chromium.org | e807781 | 2012-02-03 03:41:46 +0000 | [diff] [blame] | 4688 | return 1 |
| 4689 | |
maruel@chromium.org | eb52a5c | 2013-04-10 23:17:09 +0000 | [diff] [blame] | 4690 | options.reviewers = cleanup_list(options.reviewers) |
Robert Iannucci | 6c98dc6 | 2017-04-18 11:38:00 -0700 | [diff] [blame] | 4691 | options.tbrs = cleanup_list(options.tbrs) |
maruel@chromium.org | eb52a5c | 2013-04-10 23:17:09 +0000 | [diff] [blame] | 4692 | options.cc = cleanup_list(options.cc) |
| 4693 | |
tandrii | b80458a | 2016-06-23 12:20:07 -0700 | [diff] [blame] | 4694 | if options.message_file: |
| 4695 | if options.message: |
| 4696 | parser.error('only one of --message and --message-file allowed.') |
| 4697 | options.message = gclient_utils.FileRead(options.message_file) |
| 4698 | options.message_file = None |
| 4699 | |
tandrii | 4d0545a | 2016-07-06 03:56:49 -0700 | [diff] [blame] | 4700 | if options.cq_dry_run and options.use_commit_queue: |
| 4701 | parser.error('only one of --use-commit-queue and --cq-dry-run allowed.') |
| 4702 | |
Aaron Gable | edbc413 | 2017-09-11 13:22:28 -0700 | [diff] [blame] | 4703 | if options.use_commit_queue: |
| 4704 | options.send_mail = True |
| 4705 | |
tandrii@chromium.org | 512d79c | 2016-03-31 12:55:28 +0000 | [diff] [blame] | 4706 | # For sanity of test expectations, do this otherwise lazy-loading *now*. |
| 4707 | settings.GetIsGerrit() |
| 4708 | |
tandrii@chromium.org | dde6462 | 2016-04-13 17:11:21 +0000 | [diff] [blame] | 4709 | cl = Changelist(auth_config=auth_config, codereview=options.forced_codereview) |
Andrii Shyshkalov | 9f27443 | 2018-10-15 16:40:23 +0000 | [diff] [blame] | 4710 | if not cl.IsGerrit(): |
| 4711 | # Error out with instructions for repos not yet configured for Gerrit. |
| 4712 | print('=====================================') |
| 4713 | print('NOTICE: Rietveld is no longer supported. ' |
| 4714 | 'You can upload changes to Gerrit with') |
| 4715 | print(' git cl upload --gerrit') |
| 4716 | print('or set Gerrit to be your default code review tool with') |
| 4717 | print(' git config gerrit.host true') |
| 4718 | print('=====================================') |
| 4719 | return 1 |
| 4720 | |
tandrii@chromium.org | 9e6c3a5 | 2016-04-12 14:13:08 +0000 | [diff] [blame] | 4721 | return cl.CMDUpload(options, args, orig_args) |
ukai@chromium.org | e807781 | 2012-02-03 03:41:46 +0000 | [diff] [blame] | 4722 | |
| 4723 | |
Francois Doray | d42c681 | 2017-05-30 15:10:20 -0400 | [diff] [blame] | 4724 | @subcommand.usage('--description=<description file>') |
Edward Lemur | 5ba1e9c | 2018-07-23 18:19:02 +0000 | [diff] [blame] | 4725 | @metrics.collector.collect_metrics('git cl split') |
Francois Doray | d42c681 | 2017-05-30 15:10:20 -0400 | [diff] [blame] | 4726 | def CMDsplit(parser, args): |
| 4727 | """Splits a branch into smaller branches and uploads CLs. |
| 4728 | |
| 4729 | Creates a branch and uploads a CL for each group of files modified in the |
| 4730 | current branch that share a common OWNERS file. In the CL description and |
Quinten Yearsley | 0c62da9 | 2017-05-31 13:39:42 -0700 | [diff] [blame] | 4731 | comment, the string '$directory', is replaced with the directory containing |
Francois Doray | d42c681 | 2017-05-30 15:10:20 -0400 | [diff] [blame] | 4732 | the shared OWNERS file. |
| 4733 | """ |
| 4734 | parser.add_option("-d", "--description", dest="description_file", |
Gabriel Charette | 02b5ee8 | 2017-11-08 16:36:05 -0500 | [diff] [blame] | 4735 | help="A text file containing a CL description in which " |
| 4736 | "$directory will be replaced by each CL's directory.") |
Francois Doray | d42c681 | 2017-05-30 15:10:20 -0400 | [diff] [blame] | 4737 | parser.add_option("-c", "--comment", dest="comment_file", |
| 4738 | help="A text file containing a CL comment.") |
Chris Watkins | ba28e46 | 2017-12-13 11:22:17 +1100 | [diff] [blame] | 4739 | parser.add_option("-n", "--dry-run", dest="dry_run", action='store_true', |
| 4740 | default=False, |
| 4741 | help="List the files and reviewers for each CL that would " |
| 4742 | "be created, but don't create branches or CLs.") |
Stephen Martinis | cb32668 | 2018-08-29 21:06:30 +0000 | [diff] [blame] | 4743 | parser.add_option("--cq-dry-run", action='store_true', |
| 4744 | help="If set, will do a cq dry run for each uploaded CL. " |
| 4745 | "Please be careful when doing this; more than ~10 CLs " |
| 4746 | "has the potential to overload our build " |
| 4747 | "infrastructure. Try to upload these not during high " |
| 4748 | "load times (usually 11-3 Mountain View time). Email " |
| 4749 | "infra-dev@chromium.org with any questions.") |
Takuto Ikuta | 51eca59 | 2019-02-14 19:40:52 +0000 | [diff] [blame] | 4750 | parser.add_option('-a', '--enable-auto-submit', action='store_true', |
| 4751 | default=True, |
| 4752 | help='Sends your change to the CQ after an approval. Only ' |
| 4753 | 'works on repos that have the Auto-Submit label ' |
| 4754 | 'enabled') |
Francois Doray | d42c681 | 2017-05-30 15:10:20 -0400 | [diff] [blame] | 4755 | options, _ = parser.parse_args(args) |
| 4756 | |
| 4757 | if not options.description_file: |
| 4758 | parser.error('No --description flag specified.') |
| 4759 | |
| 4760 | def WrappedCMDupload(args): |
| 4761 | return CMDupload(OptionParser(), args) |
| 4762 | |
| 4763 | return split_cl.SplitCl(options.description_file, options.comment_file, |
Stephen Martinis | cb32668 | 2018-08-29 21:06:30 +0000 | [diff] [blame] | 4764 | Changelist, WrappedCMDupload, options.dry_run, |
Takuto Ikuta | 51eca59 | 2019-02-14 19:40:52 +0000 | [diff] [blame] | 4765 | options.cq_dry_run, options.enable_auto_submit) |
Francois Doray | d42c681 | 2017-05-30 15:10:20 -0400 | [diff] [blame] | 4766 | |
| 4767 | |
Aaron Gable | 1bc7bfe | 2016-12-19 10:08:14 -0800 | [diff] [blame] | 4768 | @subcommand.usage('DEPRECATED') |
Edward Lemur | 5ba1e9c | 2018-07-23 18:19:02 +0000 | [diff] [blame] | 4769 | @metrics.collector.collect_metrics('git cl commit') |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 4770 | def CMDdcommit(parser, args): |
Aaron Gable | 1bc7bfe | 2016-12-19 10:08:14 -0800 | [diff] [blame] | 4771 | """DEPRECATED: Used to commit the current changelist via git-svn.""" |
| 4772 | message = ('git-cl no longer supports committing to SVN repositories via ' |
| 4773 | 'git-svn. You probably want to use `git cl land` instead.') |
| 4774 | print(message) |
| 4775 | return 1 |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 4776 | |
| 4777 | |
Andrii Shyshkalov | aa31b97 | 2017-03-24 16:16:33 +0100 | [diff] [blame] | 4778 | # Two special branches used by git cl land. |
| 4779 | MERGE_BRANCH = 'git-cl-commit' |
| 4780 | CHERRY_PICK_BRANCH = 'git-cl-cherry-pick' |
| 4781 | |
| 4782 | |
maruel@chromium.org | 0633fb4 | 2013-08-16 20:06:14 +0000 | [diff] [blame] | 4783 | @subcommand.usage('[upstream branch to apply against]') |
Edward Lemur | 5ba1e9c | 2018-07-23 18:19:02 +0000 | [diff] [blame] | 4784 | @metrics.collector.collect_metrics('git cl land') |
pgervais@chromium.org | cee6dc4 | 2014-05-07 17:04:03 +0000 | [diff] [blame] | 4785 | def CMDland(parser, args): |
Aaron Gable | 1bc7bfe | 2016-12-19 10:08:14 -0800 | [diff] [blame] | 4786 | """Commits the current changelist via git. |
| 4787 | |
| 4788 | In case of Gerrit, uses Gerrit REST api to "submit" the issue, which pushes |
| 4789 | upstream and closes the issue automatically and atomically. |
Aaron Gable | 1bc7bfe | 2016-12-19 10:08:14 -0800 | [diff] [blame] | 4790 | """ |
| 4791 | parser.add_option('--bypass-hooks', action='store_true', dest='bypass_hooks', |
| 4792 | help='bypass upload presubmit hook') |
Aaron Gable | f7543cd | 2017-07-20 14:26:31 -0700 | [diff] [blame] | 4793 | parser.add_option('-f', '--force', action='store_true', dest='force', |
Aaron Gable | 1bc7bfe | 2016-12-19 10:08:14 -0800 | [diff] [blame] | 4794 | help="force yes to questions (don't prompt)") |
Edward Lesmes | 67b3faa | 2018-04-13 17:50:52 -0400 | [diff] [blame] | 4795 | parser.add_option('--parallel', action='store_true', |
| 4796 | help='Run all tests specified by input_api.RunTests in all ' |
| 4797 | 'PRESUBMIT files in parallel.') |
Aaron Gable | 1bc7bfe | 2016-12-19 10:08:14 -0800 | [diff] [blame] | 4798 | auth.add_auth_options(parser) |
| 4799 | (options, args) = parser.parse_args(args) |
| 4800 | auth_config = auth.extract_auth_config_from_options(options) |
| 4801 | |
| 4802 | cl = Changelist(auth_config=auth_config) |
| 4803 | |
Robert Iannucci | 2e73d43 | 2018-03-14 01:10:47 -0700 | [diff] [blame] | 4804 | if not cl.IsGerrit(): |
| 4805 | parser.error('rietveld is not supported') |
Aaron Gable | 1bc7bfe | 2016-12-19 10:08:14 -0800 | [diff] [blame] | 4806 | |
Robert Iannucci | 2e73d43 | 2018-03-14 01:10:47 -0700 | [diff] [blame] | 4807 | if not cl.GetIssue(): |
| 4808 | DieWithError('You must upload the change first to Gerrit.\n' |
| 4809 | ' If you would rather have `git cl land` upload ' |
| 4810 | 'automatically for you, see http://crbug.com/642759') |
| 4811 | return cl._codereview_impl.CMDLand(options.force, options.bypass_hooks, |
Olivier Robin | 75ee725 | 2018-04-13 10:02:56 +0200 | [diff] [blame] | 4812 | options.verbose, options.parallel) |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 4813 | |
| 4814 | |
dsinclair@chromium.org | fbed656 | 2015-09-25 21:22:36 +0000 | [diff] [blame] | 4815 | @subcommand.usage('<patch url or issue id or issue url>') |
Edward Lemur | 5ba1e9c | 2018-07-23 18:19:02 +0000 | [diff] [blame] | 4816 | @metrics.collector.collect_metrics('git cl patch') |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 4817 | def CMDpatch(parser, args): |
marq@chromium.org | e5e5900 | 2013-10-02 23:21:25 +0000 | [diff] [blame] | 4818 | """Patches in a code review.""" |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 4819 | parser.add_option('-b', dest='newbranch', |
| 4820 | help='create a new branch off trunk for the patch') |
qsr@chromium.org | 1ef44af | 2013-10-16 16:24:32 +0000 | [diff] [blame] | 4821 | parser.add_option('-f', '--force', action='store_true', |
Aaron Gable | 62619a3 | 2017-06-16 08:22:09 -0700 | [diff] [blame] | 4822 | help='overwrite state on the current or chosen branch') |
qsr@chromium.org | 1ef44af | 2013-10-16 16:24:32 +0000 | [diff] [blame] | 4823 | parser.add_option('-d', '--directory', action='store', metavar='DIR', |
Aaron Gable | 62619a3 | 2017-06-16 08:22:09 -0700 | [diff] [blame] | 4824 | help='change to the directory DIR immediately, ' |
tandrii@chromium.org | f86c7d3 | 2016-04-01 19:27:30 +0000 | [diff] [blame] | 4825 | 'before doing anything else. Rietveld only.') |
qsr@chromium.org | 1ef44af | 2013-10-16 16:24:32 +0000 | [diff] [blame] | 4826 | parser.add_option('--reject', action='store_true', |
tapted@chromium.org | 6a0b07c | 2013-07-10 01:29:19 +0000 | [diff] [blame] | 4827 | help='failed patches spew .rej files rather than ' |
tandrii@chromium.org | f86c7d3 | 2016-04-01 19:27:30 +0000 | [diff] [blame] | 4828 | 'attempting a 3-way merge. Rietveld only.') |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 4829 | parser.add_option('-n', '--no-commit', action='store_true', dest='nocommit', |
tandrii@chromium.org | f86c7d3 | 2016-04-01 19:27:30 +0000 | [diff] [blame] | 4830 | help='don\'t commit after patch applies. Rietveld only.') |
mtrofin@chromium.org | 1d88dd3 | 2016-02-04 16:25:12 +0000 | [diff] [blame] | 4831 | |
tandrii@chromium.org | f86c7d3 | 2016-04-01 19:27:30 +0000 | [diff] [blame] | 4832 | |
| 4833 | group = optparse.OptionGroup( |
| 4834 | parser, |
| 4835 | 'Options for continuing work on the current issue uploaded from a ' |
| 4836 | 'different clone (e.g. different machine). Must be used independently ' |
| 4837 | 'from the other options. No issue number should be specified, and the ' |
| 4838 | 'branch must have an issue number associated with it') |
| 4839 | group.add_option('--reapply', action='store_true', dest='reapply', |
| 4840 | help='Reset the branch and reapply the issue.\n' |
| 4841 | 'CAUTION: This will undo any local changes in this ' |
| 4842 | 'branch') |
mtrofin@chromium.org | 1d88dd3 | 2016-02-04 16:25:12 +0000 | [diff] [blame] | 4843 | |
| 4844 | group.add_option('--pull', action='store_true', dest='pull', |
tandrii@chromium.org | f86c7d3 | 2016-04-01 19:27:30 +0000 | [diff] [blame] | 4845 | help='Performs a pull before reapplying.') |
mtrofin@chromium.org | 1d88dd3 | 2016-02-04 16:25:12 +0000 | [diff] [blame] | 4846 | parser.add_option_group(group) |
| 4847 | |
vadimsh@chromium.org | cf6a5d2 | 2015-04-09 22:02:00 +0000 | [diff] [blame] | 4848 | auth.add_auth_options(parser) |
tandrii@chromium.org | dde6462 | 2016-04-13 17:11:21 +0000 | [diff] [blame] | 4849 | _add_codereview_select_options(parser) |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 4850 | (options, args) = parser.parse_args(args) |
tandrii@chromium.org | dde6462 | 2016-04-13 17:11:21 +0000 | [diff] [blame] | 4851 | _process_codereview_select_options(parser, options) |
vadimsh@chromium.org | cf6a5d2 | 2015-04-09 22:02:00 +0000 | [diff] [blame] | 4852 | auth_config = auth.extract_auth_config_from_options(options) |
| 4853 | |
Andrii Shyshkalov | 1897532 | 2017-01-25 16:44:13 +0100 | [diff] [blame] | 4854 | if options.reapply: |
tandrii@chromium.org | c2786d9 | 2016-05-31 19:53:50 +0000 | [diff] [blame] | 4855 | if options.newbranch: |
| 4856 | parser.error('--reapply works on the current branch only') |
mtrofin@chromium.org | 1d88dd3 | 2016-02-04 16:25:12 +0000 | [diff] [blame] | 4857 | if len(args) > 0: |
tandrii@chromium.org | c2786d9 | 2016-05-31 19:53:50 +0000 | [diff] [blame] | 4858 | parser.error('--reapply implies no additional arguments') |
dsinclair@chromium.org | fbed656 | 2015-09-25 21:22:36 +0000 | [diff] [blame] | 4859 | |
tandrii@chromium.org | c2786d9 | 2016-05-31 19:53:50 +0000 | [diff] [blame] | 4860 | cl = Changelist(auth_config=auth_config, |
| 4861 | codereview=options.forced_codereview) |
| 4862 | if not cl.GetIssue(): |
| 4863 | parser.error('current branch must have an associated issue') |
| 4864 | |
mtrofin@chromium.org | 1d88dd3 | 2016-02-04 16:25:12 +0000 | [diff] [blame] | 4865 | upstream = cl.GetUpstreamBranch() |
Andrii Shyshkalov | 1897532 | 2017-01-25 16:44:13 +0100 | [diff] [blame] | 4866 | if upstream is None: |
tandrii@chromium.org | f86c7d3 | 2016-04-01 19:27:30 +0000 | [diff] [blame] | 4867 | parser.error('No upstream branch specified. Cannot reset branch') |
mtrofin@chromium.org | 1d88dd3 | 2016-02-04 16:25:12 +0000 | [diff] [blame] | 4868 | |
| 4869 | RunGit(['reset', '--hard', upstream]) |
| 4870 | if options.pull: |
| 4871 | RunGit(['pull']) |
mtrofin@chromium.org | 1d88dd3 | 2016-02-04 16:25:12 +0000 | [diff] [blame] | 4872 | |
tandrii@chromium.org | c2786d9 | 2016-05-31 19:53:50 +0000 | [diff] [blame] | 4873 | return cl.CMDPatchIssue(cl.GetIssue(), options.reject, options.nocommit, |
| 4874 | options.directory) |
| 4875 | |
| 4876 | if len(args) != 1 or not args[0]: |
| 4877 | parser.error('Must specify issue number or url') |
| 4878 | |
Andrii Shyshkalov | c971239 | 2017-04-11 13:35:21 +0200 | [diff] [blame] | 4879 | target_issue_arg = ParseIssueNumberArgument(args[0], |
| 4880 | options.forced_codereview) |
| 4881 | if not target_issue_arg.valid: |
| 4882 | parser.error('invalid codereview url or CL id') |
| 4883 | |
| 4884 | cl_kwargs = { |
| 4885 | 'auth_config': auth_config, |
| 4886 | 'codereview_host': target_issue_arg.hostname, |
| 4887 | 'codereview': options.forced_codereview, |
| 4888 | } |
| 4889 | detected_codereview_from_url = False |
| 4890 | if target_issue_arg.codereview and not options.forced_codereview: |
| 4891 | detected_codereview_from_url = True |
| 4892 | cl_kwargs['codereview'] = target_issue_arg.codereview |
| 4893 | cl_kwargs['issue'] = target_issue_arg.issue |
| 4894 | |
tandrii@chromium.org | c2786d9 | 2016-05-31 19:53:50 +0000 | [diff] [blame] | 4895 | # We don't want uncommitted changes mixed up with the patch. |
| 4896 | if git_common.is_dirty_git_tree('patch'): |
dsinclair@chromium.org | fbed656 | 2015-09-25 21:22:36 +0000 | [diff] [blame] | 4897 | return 1 |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 4898 | |
tandrii@chromium.org | c2786d9 | 2016-05-31 19:53:50 +0000 | [diff] [blame] | 4899 | if options.newbranch: |
| 4900 | if options.force: |
| 4901 | RunGit(['branch', '-D', options.newbranch], |
| 4902 | stderr=subprocess2.PIPE, error_ok=True) |
| 4903 | RunGit(['new-branch', options.newbranch]) |
| 4904 | |
Andrii Shyshkalov | c971239 | 2017-04-11 13:35:21 +0200 | [diff] [blame] | 4905 | cl = Changelist(**cl_kwargs) |
tandrii@chromium.org | c2786d9 | 2016-05-31 19:53:50 +0000 | [diff] [blame] | 4906 | |
tandrii@chromium.org | f86c7d3 | 2016-04-01 19:27:30 +0000 | [diff] [blame] | 4907 | if cl.IsGerrit(): |
| 4908 | if options.reject: |
| 4909 | parser.error('--reject is not supported with Gerrit codereview.') |
tandrii@chromium.org | f86c7d3 | 2016-04-01 19:27:30 +0000 | [diff] [blame] | 4910 | if options.directory: |
| 4911 | parser.error('--directory is not supported with Gerrit codereview.') |
| 4912 | |
Andrii Shyshkalov | c971239 | 2017-04-11 13:35:21 +0200 | [diff] [blame] | 4913 | if detected_codereview_from_url: |
| 4914 | print('canonical issue/change URL: %s (type: %s)\n' % |
| 4915 | (cl.GetIssueURL(), target_issue_arg.codereview)) |
| 4916 | |
| 4917 | return cl.CMDPatchWithParsedIssue(target_issue_arg, options.reject, |
Aaron Gable | 62619a3 | 2017-06-16 08:22:09 -0700 | [diff] [blame] | 4918 | options.nocommit, options.directory, |
| 4919 | options.force) |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 4920 | |
| 4921 | |
jochen@chromium.org | 3ec0d54 | 2014-01-14 20:00:03 +0000 | [diff] [blame] | 4922 | def GetTreeStatus(url=None): |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 4923 | """Fetches the tree status and returns either 'open', 'closed', |
| 4924 | 'unknown' or 'unset'.""" |
jochen@chromium.org | 3ec0d54 | 2014-01-14 20:00:03 +0000 | [diff] [blame] | 4925 | url = url or settings.GetTreeStatusUrl(error_ok=True) |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 4926 | if url: |
| 4927 | status = urllib2.urlopen(url).read().lower() |
| 4928 | if status.find('closed') != -1 or status == '0': |
| 4929 | return 'closed' |
| 4930 | elif status.find('open') != -1 or status == '1': |
| 4931 | return 'open' |
| 4932 | return 'unknown' |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 4933 | return 'unset' |
| 4934 | |
dpranke@chromium.org | 970c522 | 2011-03-12 00:32:24 +0000 | [diff] [blame] | 4935 | |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 4936 | def GetTreeStatusReason(): |
| 4937 | """Fetches the tree status from a json url and returns the message |
| 4938 | with the reason for the tree to be opened or closed.""" |
msb@chromium.org | bf1a7ba | 2011-02-01 16:21:46 +0000 | [diff] [blame] | 4939 | url = settings.GetTreeStatusUrl() |
| 4940 | json_url = urlparse.urljoin(url, '/current?format=json') |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 4941 | connection = urllib2.urlopen(json_url) |
| 4942 | status = json.loads(connection.read()) |
| 4943 | connection.close() |
| 4944 | return status['message'] |
| 4945 | |
dpranke@chromium.org | 970c522 | 2011-03-12 00:32:24 +0000 | [diff] [blame] | 4946 | |
Edward Lemur | 5ba1e9c | 2018-07-23 18:19:02 +0000 | [diff] [blame] | 4947 | @metrics.collector.collect_metrics('git cl tree') |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 4948 | def CMDtree(parser, args): |
iannucci@chromium.org | d9c1b20 | 2013-07-24 23:52:11 +0000 | [diff] [blame] | 4949 | """Shows the status of the tree.""" |
dpranke@chromium.org | 97ae58e | 2011-03-18 00:29:20 +0000 | [diff] [blame] | 4950 | _, args = parser.parse_args(args) |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 4951 | status = GetTreeStatus() |
| 4952 | if 'unset' == status: |
vapier | a7fbd5a | 2016-06-16 09:17:49 -0700 | [diff] [blame] | 4953 | print('You must configure your tree status URL by running "git cl config".') |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 4954 | return 2 |
| 4955 | |
vapier | a7fbd5a | 2016-06-16 09:17:49 -0700 | [diff] [blame] | 4956 | print('The tree is %s' % status) |
| 4957 | print() |
| 4958 | print(GetTreeStatusReason()) |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 4959 | if status != 'open': |
| 4960 | return 1 |
| 4961 | return 0 |
| 4962 | |
| 4963 | |
Edward Lemur | 5ba1e9c | 2018-07-23 18:19:02 +0000 | [diff] [blame] | 4964 | @metrics.collector.collect_metrics('git cl try') |
maruel@chromium.org | 1519240 | 2012-09-06 12:38:29 +0000 | [diff] [blame] | 4965 | def CMDtry(parser, args): |
qyearsley | 1fdfcb6 | 2016-10-24 13:22:03 -0700 | [diff] [blame] | 4966 | """Triggers try jobs using either BuildBucket or CQ dry run.""" |
tandrii | 1838bad | 2016-10-06 00:10:52 -0700 | [diff] [blame] | 4967 | group = optparse.OptionGroup(parser, 'Try job options') |
maruel@chromium.org | 1519240 | 2012-09-06 12:38:29 +0000 | [diff] [blame] | 4968 | group.add_option( |
tandrii | 1838bad | 2016-10-06 00:10:52 -0700 | [diff] [blame] | 4969 | '-b', '--bot', action='append', |
| 4970 | help=('IMPORTANT: specify ONE builder per --bot flag. Use it multiple ' |
| 4971 | 'times to specify multiple builders. ex: ' |
| 4972 | '"-b win_rel -b win_layout". See ' |
| 4973 | 'the try server waterfall for the builders name and the tests ' |
| 4974 | 'available.')) |
maruel@chromium.org | 1519240 | 2012-09-06 12:38:29 +0000 | [diff] [blame] | 4975 | group.add_option( |
borenet | 6c0efe6 | 2016-10-19 08:13:29 -0700 | [diff] [blame] | 4976 | '-B', '--bucket', default='', |
| 4977 | help=('Buildbucket bucket to send the try requests.')) |
| 4978 | group.add_option( |
tandrii | 1838bad | 2016-10-06 00:10:52 -0700 | [diff] [blame] | 4979 | '-m', '--master', default='', |
Nodir Turakulov | f6929a1 | 2017-10-09 12:34:44 -0700 | [diff] [blame] | 4980 | help=('DEPRECATED, use -B. The try master where to run the builds.')) |
machenbach@chromium.org | 58a69cb | 2014-03-01 02:08:29 +0000 | [diff] [blame] | 4981 | group.add_option( |
tandrii | 1838bad | 2016-10-06 00:10:52 -0700 | [diff] [blame] | 4982 | '-r', '--revision', |
tandrii | f7b29d4 | 2016-10-07 08:45:41 -0700 | [diff] [blame] | 4983 | help='Revision to use for the try job; default: the revision will ' |
| 4984 | 'be determined by the try recipe that builder runs, which usually ' |
| 4985 | 'defaults to HEAD of origin/master') |
maruel@chromium.org | 1519240 | 2012-09-06 12:38:29 +0000 | [diff] [blame] | 4986 | group.add_option( |
tandrii | 1838bad | 2016-10-06 00:10:52 -0700 | [diff] [blame] | 4987 | '-c', '--clobber', action='store_true', default=False, |
tandrii | f7b29d4 | 2016-10-07 08:45:41 -0700 | [diff] [blame] | 4988 | help='Force a clobber before building; that is don\'t do an ' |
tandrii | 1838bad | 2016-10-06 00:10:52 -0700 | [diff] [blame] | 4989 | 'incremental build') |
maruel@chromium.org | 1519240 | 2012-09-06 12:38:29 +0000 | [diff] [blame] | 4990 | group.add_option( |
Andrii Shyshkalov | f9648b5 | 2018-02-21 22:32:42 -0800 | [diff] [blame] | 4991 | '--category', default='git_cl_try', help='Specify custom build category.') |
| 4992 | group.add_option( |
tandrii | 1838bad | 2016-10-06 00:10:52 -0700 | [diff] [blame] | 4993 | '--project', |
| 4994 | help='Override which project to use. Projects are defined ' |
tandrii | f7b29d4 | 2016-10-07 08:45:41 -0700 | [diff] [blame] | 4995 | 'in recipe to determine to which repository or directory to ' |
| 4996 | 'apply the patch') |
maruel@chromium.org | 1519240 | 2012-09-06 12:38:29 +0000 | [diff] [blame] | 4997 | group.add_option( |
tandrii | 1838bad | 2016-10-06 00:10:52 -0700 | [diff] [blame] | 4998 | '-p', '--property', dest='properties', action='append', default=[], |
| 4999 | help='Specify generic properties in the form -p key1=value1 -p ' |
tandrii | f7b29d4 | 2016-10-07 08:45:41 -0700 | [diff] [blame] | 5000 | 'key2=value2 etc. The value will be treated as ' |
| 5001 | 'json if decodable, or as string otherwise. ' |
| 5002 | 'NOTE: using this may make your try job not usable for CQ, ' |
| 5003 | 'which will then schedule another try job with default properties') |
sheyang@chromium.org | db37557 | 2015-08-17 19:22:23 +0000 | [diff] [blame] | 5004 | group.add_option( |
tandrii | 1838bad | 2016-10-06 00:10:52 -0700 | [diff] [blame] | 5005 | '--buildbucket-host', default='cr-buildbucket.appspot.com', |
| 5006 | help='Host of buildbucket. The default host is %default.') |
maruel@chromium.org | 1519240 | 2012-09-06 12:38:29 +0000 | [diff] [blame] | 5007 | parser.add_option_group(group) |
vadimsh@chromium.org | cf6a5d2 | 2015-04-09 22:02:00 +0000 | [diff] [blame] | 5008 | auth.add_auth_options(parser) |
Koji Ishii | 31c1478 | 2018-01-08 17:17:33 +0900 | [diff] [blame] | 5009 | _add_codereview_issue_select_options(parser) |
maruel@chromium.org | 1519240 | 2012-09-06 12:38:29 +0000 | [diff] [blame] | 5010 | options, args = parser.parse_args(args) |
Koji Ishii | 31c1478 | 2018-01-08 17:17:33 +0900 | [diff] [blame] | 5011 | _process_codereview_issue_select_options(parser, options) |
vadimsh@chromium.org | cf6a5d2 | 2015-04-09 22:02:00 +0000 | [diff] [blame] | 5012 | auth_config = auth.extract_auth_config_from_options(options) |
maruel@chromium.org | 1519240 | 2012-09-06 12:38:29 +0000 | [diff] [blame] | 5013 | |
Nodir Turakulov | f6929a1 | 2017-10-09 12:34:44 -0700 | [diff] [blame] | 5014 | if options.master and options.master.startswith('luci.'): |
| 5015 | parser.error( |
| 5016 | '-m option does not support LUCI. Please pass -B %s' % options.master) |
machenbach@chromium.org | 4545314 | 2015-09-15 08:45:22 +0000 | [diff] [blame] | 5017 | # Make sure that all properties are prop=value pairs. |
| 5018 | bad_params = [x for x in options.properties if '=' not in x] |
| 5019 | if bad_params: |
| 5020 | parser.error('Got properties with missing "=": %s' % bad_params) |
| 5021 | |
maruel@chromium.org | 1519240 | 2012-09-06 12:38:29 +0000 | [diff] [blame] | 5022 | if args: |
| 5023 | parser.error('Unknown arguments: %s' % args) |
| 5024 | |
Koji Ishii | 31c1478 | 2018-01-08 17:17:33 +0900 | [diff] [blame] | 5025 | cl = Changelist(auth_config=auth_config, issue=options.issue, |
| 5026 | codereview=options.forced_codereview) |
maruel@chromium.org | 1519240 | 2012-09-06 12:38:29 +0000 | [diff] [blame] | 5027 | if not cl.GetIssue(): |
| 5028 | parser.error('Need to upload first') |
| 5029 | |
Andrii Shyshkalov | eadad92 | 2017-01-26 09:38:30 +0100 | [diff] [blame] | 5030 | if cl.IsGerrit(): |
| 5031 | # HACK: warm up Gerrit change detail cache to save on RPCs. |
| 5032 | cl._codereview_impl._GetChangeDetail(['DETAILED_ACCOUNTS', 'ALL_REVISIONS']) |
| 5033 | |
tandrii | e113dfd | 2016-10-11 10:20:12 -0700 | [diff] [blame] | 5034 | error_message = cl.CannotTriggerTryJobReason() |
| 5035 | if error_message: |
qyearsley | 99e2cdf | 2016-10-23 12:51:41 -0700 | [diff] [blame] | 5036 | parser.error('Can\'t trigger try jobs: %s' % error_message) |
jrobbins@chromium.org | 16f10f7 | 2014-06-24 22:14:36 +0000 | [diff] [blame] | 5037 | |
borenet | 6c0efe6 | 2016-10-19 08:13:29 -0700 | [diff] [blame] | 5038 | if options.bucket and options.master: |
| 5039 | parser.error('Only one of --bucket and --master may be used.') |
| 5040 | |
qyearsley | 1fdfcb6 | 2016-10-24 13:22:03 -0700 | [diff] [blame] | 5041 | buckets = _get_bucket_map(cl, options, parser) |
phajdan.jr@chromium.org | 8da7f27 | 2014-03-14 01:28:39 +0000 | [diff] [blame] | 5042 | |
qyearsley | dd49f94 | 2016-10-28 11:57:22 -0700 | [diff] [blame] | 5043 | # If no bots are listed and we couldn't get a list based on PRESUBMIT files, |
| 5044 | # then we default to triggering a CQ dry run (see http://crbug.com/625697). |
qyearsley | 1fdfcb6 | 2016-10-24 13:22:03 -0700 | [diff] [blame] | 5045 | if not buckets: |
qyearsley | 1fdfcb6 | 2016-10-24 13:22:03 -0700 | [diff] [blame] | 5046 | if options.verbose: |
Quinten Yearsley | fc5fd92 | 2017-05-31 11:50:52 -0700 | [diff] [blame] | 5047 | print('git cl try with no bots now defaults to CQ dry run.') |
| 5048 | print('Scheduling CQ dry run on: %s' % cl.GetIssueURL()) |
| 5049 | return cl.SetCQState(_CQState.DRY_RUN) |
stip@chromium.org | 43064fd | 2013-12-18 20:07:44 +0000 | [diff] [blame] | 5050 | |
borenet | 6c0efe6 | 2016-10-19 08:13:29 -0700 | [diff] [blame] | 5051 | for builders in buckets.itervalues(): |
machenbach@chromium.org | 58a69cb | 2014-03-01 02:08:29 +0000 | [diff] [blame] | 5052 | if any('triggered' in b for b in builders): |
vapier | a7fbd5a | 2016-06-16 09:17:49 -0700 | [diff] [blame] | 5053 | print('ERROR You are trying to send a job to a triggered bot. This type ' |
tandrii | de281ae | 2016-10-12 06:02:30 -0700 | [diff] [blame] | 5054 | 'of bot requires an initial job from a parent (usually a builder). ' |
| 5055 | 'Instead send your job to the parent.\n' |
vapier | a7fbd5a | 2016-06-16 09:17:49 -0700 | [diff] [blame] | 5056 | 'Bot list: %s' % builders, file=sys.stderr) |
machenbach@chromium.org | 58a69cb | 2014-03-01 02:08:29 +0000 | [diff] [blame] | 5057 | return 1 |
ilevy@chromium.org | f3b2123 | 2012-09-24 20:48:55 +0000 | [diff] [blame] | 5058 | |
ilevy@chromium.org | 36e420b | 2013-08-06 23:21:12 +0000 | [diff] [blame] | 5059 | patchset = cl.GetMostRecentPatchset() |
tandrii | 568043b | 2016-10-11 07:49:18 -0700 | [diff] [blame] | 5060 | try: |
Andrii Shyshkalov | f9648b5 | 2018-02-21 22:32:42 -0800 | [diff] [blame] | 5061 | _trigger_try_jobs(auth_config, cl, buckets, options, patchset) |
tandrii | 568043b | 2016-10-11 07:49:18 -0700 | [diff] [blame] | 5062 | except BuildbucketResponseException as ex: |
| 5063 | print('ERROR: %s' % ex) |
| 5064 | return 1 |
maruel@chromium.org | 1519240 | 2012-09-06 12:38:29 +0000 | [diff] [blame] | 5065 | return 0 |
| 5066 | |
| 5067 | |
Edward Lemur | 5ba1e9c | 2018-07-23 18:19:02 +0000 | [diff] [blame] | 5068 | @metrics.collector.collect_metrics('git cl try-results') |
tandrii@chromium.org | b015fac | 2016-02-26 14:52:01 +0000 | [diff] [blame] | 5069 | def CMDtry_results(parser, args): |
tandrii | 1838bad | 2016-10-06 00:10:52 -0700 | [diff] [blame] | 5070 | """Prints info about try jobs associated with current CL.""" |
| 5071 | group = optparse.OptionGroup(parser, 'Try job results options') |
tandrii@chromium.org | b015fac | 2016-02-26 14:52:01 +0000 | [diff] [blame] | 5072 | group.add_option( |
tandrii | 1838bad | 2016-10-06 00:10:52 -0700 | [diff] [blame] | 5073 | '-p', '--patchset', type=int, help='patchset number if not current.') |
tandrii@chromium.org | b015fac | 2016-02-26 14:52:01 +0000 | [diff] [blame] | 5074 | group.add_option( |
tandrii | 1838bad | 2016-10-06 00:10:52 -0700 | [diff] [blame] | 5075 | '--print-master', action='store_true', help='print master name as well.') |
tandrii@chromium.org | 6cf98c8 | 2016-03-15 11:56:00 +0000 | [diff] [blame] | 5076 | group.add_option( |
tandrii | 1838bad | 2016-10-06 00:10:52 -0700 | [diff] [blame] | 5077 | '--color', action='store_true', default=setup_color.IS_TTY, |
| 5078 | help='force color output, useful when piping output.') |
tandrii@chromium.org | b015fac | 2016-02-26 14:52:01 +0000 | [diff] [blame] | 5079 | group.add_option( |
tandrii | 1838bad | 2016-10-06 00:10:52 -0700 | [diff] [blame] | 5080 | '--buildbucket-host', default='cr-buildbucket.appspot.com', |
| 5081 | help='Host of buildbucket. The default host is %default.') |
qyearsley | 53f48a1 | 2016-09-01 10:45:13 -0700 | [diff] [blame] | 5082 | group.add_option( |
Stefan Zager | 1306bd0 | 2017-06-22 19:26:46 -0700 | [diff] [blame] | 5083 | '--json', help=('Path of JSON output file to write try job results to,' |
| 5084 | 'or "-" for stdout.')) |
tandrii@chromium.org | b015fac | 2016-02-26 14:52:01 +0000 | [diff] [blame] | 5085 | parser.add_option_group(group) |
| 5086 | auth.add_auth_options(parser) |
Stefan Zager | 27db3f2 | 2017-10-10 15:15:01 -0700 | [diff] [blame] | 5087 | _add_codereview_issue_select_options(parser) |
tandrii@chromium.org | b015fac | 2016-02-26 14:52:01 +0000 | [diff] [blame] | 5088 | options, args = parser.parse_args(args) |
Stefan Zager | 27db3f2 | 2017-10-10 15:15:01 -0700 | [diff] [blame] | 5089 | _process_codereview_issue_select_options(parser, options) |
tandrii@chromium.org | b015fac | 2016-02-26 14:52:01 +0000 | [diff] [blame] | 5090 | if args: |
| 5091 | parser.error('Unrecognized args: %s' % ' '.join(args)) |
| 5092 | |
| 5093 | auth_config = auth.extract_auth_config_from_options(options) |
Stefan Zager | 27db3f2 | 2017-10-10 15:15:01 -0700 | [diff] [blame] | 5094 | cl = Changelist( |
| 5095 | issue=options.issue, codereview=options.forced_codereview, |
| 5096 | auth_config=auth_config) |
tandrii@chromium.org | b015fac | 2016-02-26 14:52:01 +0000 | [diff] [blame] | 5097 | if not cl.GetIssue(): |
| 5098 | parser.error('Need to upload first') |
| 5099 | |
tandrii | 221ab25 | 2016-10-06 08:12:04 -0700 | [diff] [blame] | 5100 | patchset = options.patchset |
| 5101 | if not patchset: |
| 5102 | patchset = cl.GetMostRecentPatchset() |
| 5103 | if not patchset: |
| 5104 | parser.error('Codereview doesn\'t know about issue %s. ' |
| 5105 | 'No access to issue or wrong issue number?\n' |
Andrii Shyshkalov | 0a0b067 | 2017-03-16 16:27:48 +0100 | [diff] [blame] | 5106 | 'Either upload first, or pass --patchset explicitly' % |
tandrii | 221ab25 | 2016-10-06 08:12:04 -0700 | [diff] [blame] | 5107 | cl.GetIssue()) |
| 5108 | |
tandrii@chromium.org | b015fac | 2016-02-26 14:52:01 +0000 | [diff] [blame] | 5109 | try: |
tandrii | 221ab25 | 2016-10-06 08:12:04 -0700 | [diff] [blame] | 5110 | jobs = fetch_try_jobs(auth_config, cl, options.buildbucket_host, patchset) |
tandrii@chromium.org | b015fac | 2016-02-26 14:52:01 +0000 | [diff] [blame] | 5111 | except BuildbucketResponseException as ex: |
vapier | a7fbd5a | 2016-06-16 09:17:49 -0700 | [diff] [blame] | 5112 | print('Buildbucket error: %s' % ex) |
tandrii@chromium.org | b015fac | 2016-02-26 14:52:01 +0000 | [diff] [blame] | 5113 | return 1 |
qyearsley | 53f48a1 | 2016-09-01 10:45:13 -0700 | [diff] [blame] | 5114 | if options.json: |
| 5115 | write_try_results_json(options.json, jobs) |
| 5116 | else: |
| 5117 | print_try_jobs(options, jobs) |
tandrii@chromium.org | b015fac | 2016-02-26 14:52:01 +0000 | [diff] [blame] | 5118 | return 0 |
| 5119 | |
| 5120 | |
maruel@chromium.org | 0633fb4 | 2013-08-16 20:06:14 +0000 | [diff] [blame] | 5121 | @subcommand.usage('[new upstream branch]') |
Edward Lemur | 5ba1e9c | 2018-07-23 18:19:02 +0000 | [diff] [blame] | 5122 | @metrics.collector.collect_metrics('git cl upstream') |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 5123 | def CMDupstream(parser, args): |
iannucci@chromium.org | d9c1b20 | 2013-07-24 23:52:11 +0000 | [diff] [blame] | 5124 | """Prints or sets the name of the upstream branch, if any.""" |
dpranke@chromium.org | 97ae58e | 2011-03-18 00:29:20 +0000 | [diff] [blame] | 5125 | _, args = parser.parse_args(args) |
brettw@chromium.org | ac0ba33 | 2012-08-09 23:42:53 +0000 | [diff] [blame] | 5126 | if len(args) > 1: |
maruel@chromium.org | 27bb387 | 2011-05-30 20:33:19 +0000 | [diff] [blame] | 5127 | parser.error('Unrecognized args: %s' % ' '.join(args)) |
brettw@chromium.org | ac0ba33 | 2012-08-09 23:42:53 +0000 | [diff] [blame] | 5128 | |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 5129 | cl = Changelist() |
brettw@chromium.org | ac0ba33 | 2012-08-09 23:42:53 +0000 | [diff] [blame] | 5130 | if args: |
| 5131 | # One arg means set upstream branch. |
bauerb@chromium.org | c9cf90a | 2014-04-28 20:32:31 +0000 | [diff] [blame] | 5132 | branch = cl.GetBranch() |
stip | 7a3dd35 | 2016-09-22 17:32:28 -0700 | [diff] [blame] | 5133 | RunGit(['branch', '--set-upstream-to', args[0], branch]) |
brettw@chromium.org | ac0ba33 | 2012-08-09 23:42:53 +0000 | [diff] [blame] | 5134 | cl = Changelist() |
vapier | a7fbd5a | 2016-06-16 09:17:49 -0700 | [diff] [blame] | 5135 | print('Upstream branch set to %s' % (cl.GetUpstreamBranch(),)) |
bauerb@chromium.org | c9cf90a | 2014-04-28 20:32:31 +0000 | [diff] [blame] | 5136 | |
| 5137 | # Clear configured merge-base, if there is one. |
| 5138 | git_common.remove_merge_base(branch) |
brettw@chromium.org | ac0ba33 | 2012-08-09 23:42:53 +0000 | [diff] [blame] | 5139 | else: |
vapier | a7fbd5a | 2016-06-16 09:17:49 -0700 | [diff] [blame] | 5140 | print(cl.GetUpstreamBranch()) |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 5141 | return 0 |
| 5142 | |
| 5143 | |
Edward Lemur | 5ba1e9c | 2018-07-23 18:19:02 +0000 | [diff] [blame] | 5144 | @metrics.collector.collect_metrics('git cl web') |
thestig@chromium.org | 00858c8 | 2013-12-02 23:08:03 +0000 | [diff] [blame] | 5145 | def CMDweb(parser, args): |
| 5146 | """Opens the current CL in the web browser.""" |
| 5147 | _, args = parser.parse_args(args) |
| 5148 | if args: |
| 5149 | parser.error('Unrecognized args: %s' % ' '.join(args)) |
| 5150 | |
| 5151 | issue_url = Changelist().GetIssueURL() |
| 5152 | if not issue_url: |
vapier | a7fbd5a | 2016-06-16 09:17:49 -0700 | [diff] [blame] | 5153 | print('ERROR No issue to open', file=sys.stderr) |
thestig@chromium.org | 00858c8 | 2013-12-02 23:08:03 +0000 | [diff] [blame] | 5154 | return 1 |
| 5155 | |
Sergiy Byelozyorov | 2b71832 | 2018-10-24 17:43:31 +0000 | [diff] [blame] | 5156 | # Redirect I/O before invoking browser to hide its output. For example, this |
| 5157 | # allows to hide "Created new window in existing browser session." message |
| 5158 | # from Chrome. Based on https://stackoverflow.com/a/2323563. |
| 5159 | saved_stdout = os.dup(1) |
Sergiy Belozorov | 0668403 | 2019-03-06 16:53:08 +0000 | [diff] [blame] | 5160 | saved_stderr = os.dup(2) |
Sergiy Byelozyorov | 2b71832 | 2018-10-24 17:43:31 +0000 | [diff] [blame] | 5161 | os.close(1) |
Sergiy Belozorov | 0668403 | 2019-03-06 16:53:08 +0000 | [diff] [blame] | 5162 | os.close(2) |
Sergiy Byelozyorov | 2b71832 | 2018-10-24 17:43:31 +0000 | [diff] [blame] | 5163 | os.open(os.devnull, os.O_RDWR) |
| 5164 | try: |
| 5165 | webbrowser.open(issue_url) |
| 5166 | finally: |
| 5167 | os.dup2(saved_stdout, 1) |
Sergiy Belozorov | 0668403 | 2019-03-06 16:53:08 +0000 | [diff] [blame] | 5168 | os.dup2(saved_stderr, 2) |
thestig@chromium.org | 00858c8 | 2013-12-02 23:08:03 +0000 | [diff] [blame] | 5169 | return 0 |
| 5170 | |
| 5171 | |
Edward Lemur | 5ba1e9c | 2018-07-23 18:19:02 +0000 | [diff] [blame] | 5172 | @metrics.collector.collect_metrics('git cl set-commit') |
maruel@chromium.org | 27bb387 | 2011-05-30 20:33:19 +0000 | [diff] [blame] | 5173 | def CMDset_commit(parser, args): |
iannucci@chromium.org | d9c1b20 | 2013-07-24 23:52:11 +0000 | [diff] [blame] | 5174 | """Sets the commit bit to trigger the Commit Queue.""" |
tandrii@chromium.org | fa330e8 | 2016-04-13 17:09:52 +0000 | [diff] [blame] | 5175 | parser.add_option('-d', '--dry-run', action='store_true', |
| 5176 | help='trigger in dry run mode') |
| 5177 | parser.add_option('-c', '--clear', action='store_true', |
| 5178 | help='stop CQ run, if any') |
vadimsh@chromium.org | cf6a5d2 | 2015-04-09 22:02:00 +0000 | [diff] [blame] | 5179 | auth.add_auth_options(parser) |
iannucci | e53c935 | 2016-08-17 14:40:40 -0700 | [diff] [blame] | 5180 | _add_codereview_issue_select_options(parser) |
vadimsh@chromium.org | cf6a5d2 | 2015-04-09 22:02:00 +0000 | [diff] [blame] | 5181 | options, args = parser.parse_args(args) |
iannucci | e53c935 | 2016-08-17 14:40:40 -0700 | [diff] [blame] | 5182 | _process_codereview_issue_select_options(parser, options) |
vadimsh@chromium.org | cf6a5d2 | 2015-04-09 22:02:00 +0000 | [diff] [blame] | 5183 | auth_config = auth.extract_auth_config_from_options(options) |
maruel@chromium.org | 27bb387 | 2011-05-30 20:33:19 +0000 | [diff] [blame] | 5184 | if args: |
| 5185 | parser.error('Unrecognized args: %s' % ' '.join(args)) |
tandrii@chromium.org | fa330e8 | 2016-04-13 17:09:52 +0000 | [diff] [blame] | 5186 | if options.dry_run and options.clear: |
| 5187 | parser.error('Make up your mind: both --dry-run and --clear not allowed') |
| 5188 | |
iannucci | e53c935 | 2016-08-17 14:40:40 -0700 | [diff] [blame] | 5189 | cl = Changelist(auth_config=auth_config, issue=options.issue, |
| 5190 | codereview=options.forced_codereview) |
tandrii@chromium.org | fa330e8 | 2016-04-13 17:09:52 +0000 | [diff] [blame] | 5191 | if options.clear: |
tandrii | d9e5ce5 | 2016-07-13 02:32:59 -0700 | [diff] [blame] | 5192 | state = _CQState.NONE |
tandrii@chromium.org | fa330e8 | 2016-04-13 17:09:52 +0000 | [diff] [blame] | 5193 | elif options.dry_run: |
| 5194 | state = _CQState.DRY_RUN |
| 5195 | else: |
| 5196 | state = _CQState.COMMIT |
| 5197 | if not cl.GetIssue(): |
| 5198 | parser.error('Must upload the issue first') |
tandrii | 9de9ec6 | 2016-07-13 03:01:59 -0700 | [diff] [blame] | 5199 | cl.SetCQState(state) |
maruel@chromium.org | 27bb387 | 2011-05-30 20:33:19 +0000 | [diff] [blame] | 5200 | return 0 |
| 5201 | |
| 5202 | |
Edward Lemur | 5ba1e9c | 2018-07-23 18:19:02 +0000 | [diff] [blame] | 5203 | @metrics.collector.collect_metrics('git cl set-close') |
groby@chromium.org | 411034a | 2013-02-26 15:12:01 +0000 | [diff] [blame] | 5204 | def CMDset_close(parser, args): |
iannucci@chromium.org | d9c1b20 | 2013-07-24 23:52:11 +0000 | [diff] [blame] | 5205 | """Closes the issue.""" |
iannucci | e53c935 | 2016-08-17 14:40:40 -0700 | [diff] [blame] | 5206 | _add_codereview_issue_select_options(parser) |
vadimsh@chromium.org | cf6a5d2 | 2015-04-09 22:02:00 +0000 | [diff] [blame] | 5207 | auth.add_auth_options(parser) |
| 5208 | options, args = parser.parse_args(args) |
iannucci | e53c935 | 2016-08-17 14:40:40 -0700 | [diff] [blame] | 5209 | _process_codereview_issue_select_options(parser, options) |
vadimsh@chromium.org | cf6a5d2 | 2015-04-09 22:02:00 +0000 | [diff] [blame] | 5210 | auth_config = auth.extract_auth_config_from_options(options) |
groby@chromium.org | 411034a | 2013-02-26 15:12:01 +0000 | [diff] [blame] | 5211 | if args: |
| 5212 | parser.error('Unrecognized args: %s' % ' '.join(args)) |
iannucci | e53c935 | 2016-08-17 14:40:40 -0700 | [diff] [blame] | 5213 | cl = Changelist(auth_config=auth_config, issue=options.issue, |
| 5214 | codereview=options.forced_codereview) |
groby@chromium.org | 411034a | 2013-02-26 15:12:01 +0000 | [diff] [blame] | 5215 | # Ensure there actually is an issue to close. |
Aaron Gable | 7139a4e | 2017-09-05 17:53:09 -0700 | [diff] [blame] | 5216 | if not cl.GetIssue(): |
| 5217 | DieWithError('ERROR No issue to close') |
groby@chromium.org | 411034a | 2013-02-26 15:12:01 +0000 | [diff] [blame] | 5218 | cl.CloseIssue() |
| 5219 | return 0 |
| 5220 | |
| 5221 | |
Edward Lemur | 5ba1e9c | 2018-07-23 18:19:02 +0000 | [diff] [blame] | 5222 | @metrics.collector.collect_metrics('git cl diff') |
sbc@chromium.org | 87b9bf0 | 2013-09-26 20:35:15 +0000 | [diff] [blame] | 5223 | def CMDdiff(parser, args): |
wychen@chromium.org | 37b2ec0 | 2015-04-03 00:49:15 +0000 | [diff] [blame] | 5224 | """Shows differences between local tree and last upload.""" |
thomasanderson | 074beb2 | 2016-08-29 14:03:20 -0700 | [diff] [blame] | 5225 | parser.add_option( |
| 5226 | '--stat', |
| 5227 | action='store_true', |
| 5228 | dest='stat', |
| 5229 | help='Generate a diffstat') |
vadimsh@chromium.org | cf6a5d2 | 2015-04-09 22:02:00 +0000 | [diff] [blame] | 5230 | auth.add_auth_options(parser) |
| 5231 | options, args = parser.parse_args(args) |
| 5232 | auth_config = auth.extract_auth_config_from_options(options) |
| 5233 | if args: |
| 5234 | parser.error('Unrecognized args: %s' % ' '.join(args)) |
wychen@chromium.org | 46309bf | 2015-04-03 21:04:49 +0000 | [diff] [blame] | 5235 | |
vadimsh@chromium.org | cf6a5d2 | 2015-04-09 22:02:00 +0000 | [diff] [blame] | 5236 | cl = Changelist(auth_config=auth_config) |
sbc@chromium.org | 78dc984 | 2013-11-25 18:43:44 +0000 | [diff] [blame] | 5237 | issue = cl.GetIssue() |
sbc@chromium.org | 87b9bf0 | 2013-09-26 20:35:15 +0000 | [diff] [blame] | 5238 | branch = cl.GetBranch() |
sbc@chromium.org | 78dc984 | 2013-11-25 18:43:44 +0000 | [diff] [blame] | 5239 | if not issue: |
| 5240 | DieWithError('No issue found for current branch (%s)' % branch) |
sbc@chromium.org | 87b9bf0 | 2013-09-26 20:35:15 +0000 | [diff] [blame] | 5241 | |
Aaron Gable | a718c3e | 2017-08-28 17:47:28 -0700 | [diff] [blame] | 5242 | base = cl._GitGetBranchConfigValue('last-upload-hash') |
| 5243 | if not base: |
| 5244 | base = cl._GitGetBranchConfigValue('gerritsquashhash') |
| 5245 | if not base: |
| 5246 | detail = cl._GetChangeDetail(['CURRENT_REVISION', 'CURRENT_COMMIT']) |
| 5247 | revision_info = detail['revisions'][detail['current_revision']] |
| 5248 | fetch_info = revision_info['fetch']['http'] |
| 5249 | RunGit(['fetch', fetch_info['url'], fetch_info['ref']]) |
| 5250 | base = 'FETCH_HEAD' |
sbc@chromium.org | 87b9bf0 | 2013-09-26 20:35:15 +0000 | [diff] [blame] | 5251 | |
Aaron Gable | a718c3e | 2017-08-28 17:47:28 -0700 | [diff] [blame] | 5252 | cmd = ['git', 'diff'] |
| 5253 | if options.stat: |
| 5254 | cmd.append('--stat') |
| 5255 | cmd.append(base) |
| 5256 | subprocess2.check_call(cmd) |
sbc@chromium.org | 87b9bf0 | 2013-09-26 20:35:15 +0000 | [diff] [blame] | 5257 | |
| 5258 | return 0 |
| 5259 | |
| 5260 | |
Edward Lemur | 5ba1e9c | 2018-07-23 18:19:02 +0000 | [diff] [blame] | 5261 | @metrics.collector.collect_metrics('git cl owners') |
ikarienator@chromium.org | faf3fdf | 2013-09-20 02:11:48 +0000 | [diff] [blame] | 5262 | def CMDowners(parser, args): |
Dirk Pranke | bf98088 | 2017-09-02 15:08:00 -0700 | [diff] [blame] | 5263 | """Finds potential owners for reviewing.""" |
ikarienator@chromium.org | faf3fdf | 2013-09-20 02:11:48 +0000 | [diff] [blame] | 5264 | parser.add_option( |
Sidney San MartÃn | 8e6f58c | 2018-06-08 01:02:56 +0000 | [diff] [blame] | 5265 | '--ignore-current', |
| 5266 | action='store_true', |
| 5267 | help='Ignore the CL\'s current reviewers and start from scratch.') |
| 5268 | parser.add_option( |
Sylvain Defresne | b1f865d | 2019-02-12 12:38:22 +0000 | [diff] [blame] | 5269 | '--ignore-self', |
| 5270 | action='store_true', |
| 5271 | help='Do not consider CL\'s author as an owners.') |
| 5272 | parser.add_option( |
ikarienator@chromium.org | faf3fdf | 2013-09-20 02:11:48 +0000 | [diff] [blame] | 5273 | '--no-color', |
| 5274 | action='store_true', |
| 5275 | help='Use this option to disable color output') |
Dirk Pranke | bf98088 | 2017-09-02 15:08:00 -0700 | [diff] [blame] | 5276 | parser.add_option( |
| 5277 | '--batch', |
| 5278 | action='store_true', |
| 5279 | help='Do not run interactively, just suggest some') |
vadimsh@chromium.org | cf6a5d2 | 2015-04-09 22:02:00 +0000 | [diff] [blame] | 5280 | auth.add_auth_options(parser) |
ikarienator@chromium.org | faf3fdf | 2013-09-20 02:11:48 +0000 | [diff] [blame] | 5281 | options, args = parser.parse_args(args) |
vadimsh@chromium.org | cf6a5d2 | 2015-04-09 22:02:00 +0000 | [diff] [blame] | 5282 | auth_config = auth.extract_auth_config_from_options(options) |
ikarienator@chromium.org | faf3fdf | 2013-09-20 02:11:48 +0000 | [diff] [blame] | 5283 | |
| 5284 | author = RunGit(['config', 'user.email']).strip() or None |
| 5285 | |
vadimsh@chromium.org | cf6a5d2 | 2015-04-09 22:02:00 +0000 | [diff] [blame] | 5286 | cl = Changelist(auth_config=auth_config) |
ikarienator@chromium.org | faf3fdf | 2013-09-20 02:11:48 +0000 | [diff] [blame] | 5287 | |
| 5288 | if args: |
| 5289 | if len(args) > 1: |
| 5290 | parser.error('Unknown args') |
| 5291 | base_branch = args[0] |
| 5292 | else: |
| 5293 | # Default to diffing against the common ancestor of the upstream branch. |
thestig@chromium.org | 8b0553c | 2014-02-11 00:33:37 +0000 | [diff] [blame] | 5294 | base_branch = cl.GetCommonAncestorWithUpstream() |
ikarienator@chromium.org | faf3fdf | 2013-09-20 02:11:48 +0000 | [diff] [blame] | 5295 | |
| 5296 | change = cl.GetChange(base_branch, None) |
Dirk Pranke | bf98088 | 2017-09-02 15:08:00 -0700 | [diff] [blame] | 5297 | affected_files = [f.LocalPath() for f in change.AffectedFiles()] |
| 5298 | |
| 5299 | if options.batch: |
| 5300 | db = owners.Database(change.RepositoryRoot(), file, os.path) |
| 5301 | print('\n'.join(db.reviewers_for(affected_files, author))) |
| 5302 | return 0 |
| 5303 | |
ikarienator@chromium.org | faf3fdf | 2013-09-20 02:11:48 +0000 | [diff] [blame] | 5304 | return owners_finder.OwnersFinder( |
Dirk Pranke | bf98088 | 2017-09-02 15:08:00 -0700 | [diff] [blame] | 5305 | affected_files, |
Jochen Eisinger | 72606f8 | 2017-04-04 10:44:18 +0200 | [diff] [blame] | 5306 | change.RepositoryRoot(), |
Edward Lemur | 707d70b | 2018-02-07 00:50:14 +0100 | [diff] [blame] | 5307 | author, |
Sidney San MartÃn | 8e6f58c | 2018-06-08 01:02:56 +0000 | [diff] [blame] | 5308 | [] if options.ignore_current else cl.GetReviewers(), |
Edward Lemur | 707d70b | 2018-02-07 00:50:14 +0100 | [diff] [blame] | 5309 | fopen=file, os_path=os.path, |
Jochen Eisinger | d0573ec | 2017-04-13 10:55:06 +0200 | [diff] [blame] | 5310 | disable_color=options.no_color, |
Sylvain Defresne | b1f865d | 2019-02-12 12:38:22 +0000 | [diff] [blame] | 5311 | override_files=change.OriginalOwnersFiles(), |
| 5312 | ignore_author=options.ignore_self).run() |
ikarienator@chromium.org | faf3fdf | 2013-09-20 02:11:48 +0000 | [diff] [blame] | 5313 | |
| 5314 | |
Aiden Benner | c08566e | 2018-10-03 17:52:42 +0000 | [diff] [blame] | 5315 | def BuildGitDiffCmd(diff_type, upstream_commit, args, allow_prefix=False): |
erg@chromium.org | e0a7c5d | 2015-02-23 20:30:08 +0000 | [diff] [blame] | 5316 | """Generates a diff command.""" |
| 5317 | # Generate diff for the current branch's changes. |
Aiden Benner | c08566e | 2018-10-03 17:52:42 +0000 | [diff] [blame] | 5318 | diff_cmd = ['-c', 'core.quotePath=false', 'diff', '--no-ext-diff'] |
| 5319 | |
Aiden Benner | 6c18a1a | 2018-11-23 20:18:23 +0000 | [diff] [blame] | 5320 | if allow_prefix: |
| 5321 | # explicitly setting --src-prefix and --dst-prefix is necessary in the |
| 5322 | # case that diff.noprefix is set in the user's git config. |
| 5323 | diff_cmd += ['--src-prefix=a/', '--dst-prefix=b/'] |
| 5324 | else: |
Aiden Benner | c08566e | 2018-10-03 17:52:42 +0000 | [diff] [blame] | 5325 | diff_cmd += ['--no-prefix'] |
| 5326 | |
| 5327 | diff_cmd += [diff_type, upstream_commit, '--'] |
erg@chromium.org | e0a7c5d | 2015-02-23 20:30:08 +0000 | [diff] [blame] | 5328 | |
| 5329 | if args: |
| 5330 | for arg in args: |
jkarlin@chromium.org | 6f7fa5e | 2016-01-20 19:32:21 +0000 | [diff] [blame] | 5331 | if os.path.isdir(arg) or os.path.isfile(arg): |
erg@chromium.org | e0a7c5d | 2015-02-23 20:30:08 +0000 | [diff] [blame] | 5332 | diff_cmd.append(arg) |
| 5333 | else: |
| 5334 | DieWithError('Argument "%s" is not a file or a directory' % arg) |
erg@chromium.org | e0a7c5d | 2015-02-23 20:30:08 +0000 | [diff] [blame] | 5335 | |
| 5336 | return diff_cmd |
| 5337 | |
Andrii Shyshkalov | 1897532 | 2017-01-25 16:44:13 +0100 | [diff] [blame] | 5338 | |
jkarlin@chromium.org | 6f7fa5e | 2016-01-20 19:32:21 +0000 | [diff] [blame] | 5339 | def MatchingFileType(file_name, extensions): |
| 5340 | """Returns true if the file name ends with one of the given extensions.""" |
| 5341 | return bool([ext for ext in extensions if file_name.lower().endswith(ext)]) |
erg@chromium.org | e0a7c5d | 2015-02-23 20:30:08 +0000 | [diff] [blame] | 5342 | |
Andrii Shyshkalov | 1897532 | 2017-01-25 16:44:13 +0100 | [diff] [blame] | 5343 | |
enne@chromium.org | 555cfe4 | 2014-01-29 18:21:39 +0000 | [diff] [blame] | 5344 | @subcommand.usage('[files or directories to diff]') |
Edward Lemur | 5ba1e9c | 2018-07-23 18:19:02 +0000 | [diff] [blame] | 5345 | @metrics.collector.collect_metrics('git cl format') |
agable@chromium.org | fab8f82 | 2013-05-06 17:43:09 +0000 | [diff] [blame] | 5346 | def CMDformat(parser, args): |
sbc@chromium.org | 9d0644d | 2015-06-05 23:16:54 +0000 | [diff] [blame] | 5347 | """Runs auto-formatting tools (clang-format etc.) on the diff.""" |
Christopher Lam | c5ba692 | 2017-01-24 11:19:14 +1100 | [diff] [blame] | 5348 | CLANG_EXTS = ['.cc', '.cpp', '.h', '.m', '.mm', '.proto', '.java'] |
kylechar | 58edce2 | 2016-06-17 06:07:51 -0700 | [diff] [blame] | 5349 | GN_EXTS = ['.gn', '.gni', '.typemap'] |
enne@chromium.org | 3b7e15c | 2014-01-21 17:44:47 +0000 | [diff] [blame] | 5350 | parser.add_option('--full', action='store_true', |
| 5351 | help='Reformat the full content of all touched files') |
| 5352 | parser.add_option('--dry-run', action='store_true', |
| 5353 | help='Don\'t modify any file on disk.') |
Aiden Benner | 99b0ccb | 2018-11-20 19:53:31 +0000 | [diff] [blame] | 5354 | parser.add_option( |
| 5355 | '--python', |
| 5356 | action='store_true', |
| 5357 | default=None, |
| 5358 | help='Enables python formatting on all python files.') |
| 5359 | parser.add_option( |
| 5360 | '--no-python', |
| 5361 | action='store_true', |
| 5362 | dest='python', |
| 5363 | help='Disables python formatting on all python files. ' |
| 5364 | 'Takes precedence over --python. ' |
| 5365 | 'If neither --python or --no-python are set, python ' |
| 5366 | 'files that have a .style.yapf file in an ancestor ' |
| 5367 | 'directory will be formatted.') |
Christopher Lam | c5ba692 | 2017-01-24 11:19:14 +1100 | [diff] [blame] | 5368 | parser.add_option('--js', action='store_true', |
| 5369 | help='Format javascript code with clang-format.') |
wittman@chromium.org | 04d5a22 | 2014-03-07 18:30:42 +0000 | [diff] [blame] | 5370 | parser.add_option('--diff', action='store_true', |
| 5371 | help='Print diff to stdout rather than modifying files.') |
Ilya Sherman | e081cbe | 2017-08-15 17:51:04 -0700 | [diff] [blame] | 5372 | parser.add_option('--presubmit', action='store_true', |
| 5373 | help='Used when running the script from a presubmit.') |
agable@chromium.org | fab8f82 | 2013-05-06 17:43:09 +0000 | [diff] [blame] | 5374 | opts, args = parser.parse_args(args) |
agable@chromium.org | fab8f82 | 2013-05-06 17:43:09 +0000 | [diff] [blame] | 5375 | |
Daniel Cheng | c55eecf | 2016-12-30 03:11:02 -0800 | [diff] [blame] | 5376 | # Normalize any remaining args against the current path, so paths relative to |
| 5377 | # the current directory are still resolved as expected. |
| 5378 | args = [os.path.join(os.getcwd(), arg) for arg in args] |
| 5379 | |
enne@chromium.org | ff7a1fb | 2013-12-10 19:21:41 +0000 | [diff] [blame] | 5380 | # git diff generates paths against the root of the repository. Change |
| 5381 | # to that directory so clang-format can find files even within subdirs. |
thestig@chromium.org | 8b0553c | 2014-02-11 00:33:37 +0000 | [diff] [blame] | 5382 | rel_base_path = settings.GetRelativeRoot() |
enne@chromium.org | ff7a1fb | 2013-12-10 19:21:41 +0000 | [diff] [blame] | 5383 | if rel_base_path: |
| 5384 | os.chdir(rel_base_path) |
| 5385 | |
digit@chromium.org | 29e4727 | 2013-05-17 17:01:46 +0000 | [diff] [blame] | 5386 | # Grab the merge-base commit, i.e. the upstream commit of the current |
| 5387 | # branch when it was created or the last time it was rebased. This is |
| 5388 | # to cover the case where the user may have called "git fetch origin", |
| 5389 | # moving the origin branch to a newer commit, but hasn't rebased yet. |
| 5390 | upstream_commit = None |
| 5391 | cl = Changelist() |
| 5392 | upstream_branch = cl.GetUpstreamBranch() |
| 5393 | if upstream_branch: |
| 5394 | upstream_commit = RunGit(['merge-base', 'HEAD', upstream_branch]) |
| 5395 | upstream_commit = upstream_commit.strip() |
| 5396 | |
| 5397 | if not upstream_commit: |
| 5398 | DieWithError('Could not find base commit for this branch. ' |
| 5399 | 'Are you in detached state?') |
| 5400 | |
jkarlin@chromium.org | 6f7fa5e | 2016-01-20 19:32:21 +0000 | [diff] [blame] | 5401 | changed_files_cmd = BuildGitDiffCmd('--name-only', upstream_commit, args) |
| 5402 | diff_output = RunGit(changed_files_cmd) |
| 5403 | diff_files = diff_output.splitlines() |
jkarlin@chromium.org | ad21b92 | 2016-01-28 17:48:42 +0000 | [diff] [blame] | 5404 | # Filter out files deleted by this CL |
| 5405 | diff_files = [x for x in diff_files if os.path.isfile(x)] |
erg@chromium.org | e0a7c5d | 2015-02-23 20:30:08 +0000 | [diff] [blame] | 5406 | |
Christopher Lam | c5ba692 | 2017-01-24 11:19:14 +1100 | [diff] [blame] | 5407 | if opts.js: |
Deepanjan Roy | 605dd31 | 2018-07-02 17:48:54 +0000 | [diff] [blame] | 5408 | CLANG_EXTS.extend(['.js', '.ts']) |
Christopher Lam | c5ba692 | 2017-01-24 11:19:14 +1100 | [diff] [blame] | 5409 | |
jkarlin@chromium.org | 6f7fa5e | 2016-01-20 19:32:21 +0000 | [diff] [blame] | 5410 | clang_diff_files = [x for x in diff_files if MatchingFileType(x, CLANG_EXTS)] |
| 5411 | python_diff_files = [x for x in diff_files if MatchingFileType(x, ['.py'])] |
| 5412 | dart_diff_files = [x for x in diff_files if MatchingFileType(x, ['.dart'])] |
kylechar@chromium.org | 8b61f11 | 2016-02-05 13:28:58 +0000 | [diff] [blame] | 5413 | gn_diff_files = [x for x in diff_files if MatchingFileType(x, GN_EXTS)] |
digit@chromium.org | 29e4727 | 2013-05-17 17:01:46 +0000 | [diff] [blame] | 5414 | |
nick@chromium.org | 3ac1c4e | 2014-01-16 02:44:42 +0000 | [diff] [blame] | 5415 | top_dir = os.path.normpath( |
| 5416 | RunGit(["rev-parse", "--show-toplevel"]).rstrip('\n')) |
| 5417 | |
erg@chromium.org | e0a7c5d | 2015-02-23 20:30:08 +0000 | [diff] [blame] | 5418 | # Set to 2 to signal to CheckPatchFormatted() that this patch isn't |
| 5419 | # formatted. This is used to block during the presubmit. |
| 5420 | return_value = 0 |
| 5421 | |
sammc@chromium.org | 0b35f5d | 2016-02-25 22:39:23 +0000 | [diff] [blame] | 5422 | if clang_diff_files: |
techtonik@gmail.com | 5573df1 | 2016-04-12 18:34:10 +0000 | [diff] [blame] | 5423 | # Locate the clang-format binary in the checkout |
| 5424 | try: |
| 5425 | clang_format_tool = clang_format.FindClangFormatToolInChromiumTree() |
vapier | fd77ac7 | 2016-06-16 08:33:57 -0700 | [diff] [blame] | 5426 | except clang_format.NotFoundError as e: |
techtonik@gmail.com | 5573df1 | 2016-04-12 18:34:10 +0000 | [diff] [blame] | 5427 | DieWithError(e) |
| 5428 | |
sammc@chromium.org | 0b35f5d | 2016-02-25 22:39:23 +0000 | [diff] [blame] | 5429 | if opts.full: |
erg@chromium.org | e0a7c5d | 2015-02-23 20:30:08 +0000 | [diff] [blame] | 5430 | cmd = [clang_format_tool] |
| 5431 | if not opts.dry_run and not opts.diff: |
| 5432 | cmd.append('-i') |
jkarlin@chromium.org | 6f7fa5e | 2016-01-20 19:32:21 +0000 | [diff] [blame] | 5433 | stdout = RunCommand(cmd + clang_diff_files, cwd=top_dir) |
erg@chromium.org | e0a7c5d | 2015-02-23 20:30:08 +0000 | [diff] [blame] | 5434 | if opts.diff: |
| 5435 | sys.stdout.write(stdout) |
sammc@chromium.org | 0b35f5d | 2016-02-25 22:39:23 +0000 | [diff] [blame] | 5436 | else: |
| 5437 | env = os.environ.copy() |
| 5438 | env['PATH'] = str(os.path.dirname(clang_format_tool)) |
| 5439 | try: |
| 5440 | script = clang_format.FindClangFormatScriptInChromiumTree( |
| 5441 | 'clang-format-diff.py') |
vapier | fd77ac7 | 2016-06-16 08:33:57 -0700 | [diff] [blame] | 5442 | except clang_format.NotFoundError as e: |
sammc@chromium.org | 0b35f5d | 2016-02-25 22:39:23 +0000 | [diff] [blame] | 5443 | DieWithError(e) |
digit@chromium.org | d6ddc1c | 2013-10-25 15:36:32 +0000 | [diff] [blame] | 5444 | |
sammc@chromium.org | 0b35f5d | 2016-02-25 22:39:23 +0000 | [diff] [blame] | 5445 | cmd = [sys.executable, script, '-p0'] |
| 5446 | if not opts.dry_run and not opts.diff: |
| 5447 | cmd.append('-i') |
digit@chromium.org | d6ddc1c | 2013-10-25 15:36:32 +0000 | [diff] [blame] | 5448 | |
sammc@chromium.org | 0b35f5d | 2016-02-25 22:39:23 +0000 | [diff] [blame] | 5449 | diff_cmd = BuildGitDiffCmd('-U0', upstream_commit, clang_diff_files) |
| 5450 | diff_output = RunGit(diff_cmd) |
jkarlin@chromium.org | 6f7fa5e | 2016-01-20 19:32:21 +0000 | [diff] [blame] | 5451 | |
sammc@chromium.org | 0b35f5d | 2016-02-25 22:39:23 +0000 | [diff] [blame] | 5452 | stdout = RunCommand(cmd, stdin=diff_output, cwd=top_dir, env=env) |
| 5453 | if opts.diff: |
| 5454 | sys.stdout.write(stdout) |
| 5455 | if opts.dry_run and len(stdout) > 0: |
| 5456 | return_value = 2 |
agable@chromium.org | fab8f82 | 2013-05-06 17:43:09 +0000 | [diff] [blame] | 5457 | |
sbc@chromium.org | 9d0644d | 2015-06-05 23:16:54 +0000 | [diff] [blame] | 5458 | # Similar code to above, but using yapf on .py files rather than clang-format |
| 5459 | # on C/C++ files |
Aiden Benner | 99b0ccb | 2018-11-20 19:53:31 +0000 | [diff] [blame] | 5460 | py_explicitly_disabled = opts.python is not None and not opts.python |
| 5461 | if python_diff_files and not py_explicitly_disabled: |
Aiden Benner | e47ac15 | 2018-11-20 16:44:03 +0000 | [diff] [blame] | 5462 | depot_tools_path = os.path.dirname(os.path.abspath(__file__)) |
| 5463 | yapf_tool = os.path.join(depot_tools_path, 'yapf') |
| 5464 | if sys.platform.startswith('win'): |
| 5465 | yapf_tool += '.bat' |
sbc@chromium.org | 9d0644d | 2015-06-05 23:16:54 +0000 | [diff] [blame] | 5466 | |
Aiden Benner | c08566e | 2018-10-03 17:52:42 +0000 | [diff] [blame] | 5467 | # If we couldn't find a yapf file we'll default to the chromium style |
| 5468 | # specified in depot_tools. |
Aiden Benner | c08566e | 2018-10-03 17:52:42 +0000 | [diff] [blame] | 5469 | chromium_default_yapf_style = os.path.join(depot_tools_path, |
| 5470 | YAPF_CONFIG_FILENAME) |
Aiden Benner | c08566e | 2018-10-03 17:52:42 +0000 | [diff] [blame] | 5471 | # Used for caching. |
| 5472 | yapf_configs = {} |
| 5473 | for f in python_diff_files: |
| 5474 | # Find the yapf style config for the current file, defaults to depot |
| 5475 | # tools default. |
Aiden Benner | 99b0ccb | 2018-11-20 19:53:31 +0000 | [diff] [blame] | 5476 | _FindYapfConfigFile(f, yapf_configs, top_dir) |
| 5477 | |
| 5478 | # Turn on python formatting by default if a yapf config is specified. |
| 5479 | # This breaks in the case of this repo though since the specified |
| 5480 | # style file is also the global default. |
| 5481 | if opts.python is None: |
| 5482 | filtered_py_files = [] |
| 5483 | for f in python_diff_files: |
| 5484 | if _FindYapfConfigFile(f, yapf_configs, top_dir) is not None: |
| 5485 | filtered_py_files.append(f) |
| 5486 | else: |
| 5487 | filtered_py_files = python_diff_files |
| 5488 | |
| 5489 | # Note: yapf still seems to fix indentation of the entire file |
| 5490 | # even if line ranges are specified. |
| 5491 | # See https://github.com/google/yapf/issues/499 |
| 5492 | if not opts.full and filtered_py_files: |
| 5493 | py_line_diffs = _ComputeDiffLineRanges(filtered_py_files, upstream_commit) |
| 5494 | |
| 5495 | for f in filtered_py_files: |
| 5496 | yapf_config = _FindYapfConfigFile(f, yapf_configs, top_dir) |
| 5497 | if yapf_config is None: |
| 5498 | yapf_config = chromium_default_yapf_style |
Aiden Benner | c08566e | 2018-10-03 17:52:42 +0000 | [diff] [blame] | 5499 | |
| 5500 | cmd = [yapf_tool, '--style', yapf_config, f] |
| 5501 | |
| 5502 | has_formattable_lines = False |
| 5503 | if not opts.full: |
| 5504 | # Only run yapf over changed line ranges. |
| 5505 | for diff_start, diff_len in py_line_diffs[f]: |
| 5506 | diff_end = diff_start + diff_len - 1 |
| 5507 | # Yapf errors out if diff_end < diff_start but this |
| 5508 | # is a valid line range diff for a removal. |
| 5509 | if diff_end >= diff_start: |
| 5510 | has_formattable_lines = True |
| 5511 | cmd += ['-l', '{}-{}'.format(diff_start, diff_end)] |
| 5512 | # If all line diffs were removals we have nothing to format. |
| 5513 | if not has_formattable_lines: |
| 5514 | continue |
| 5515 | |
| 5516 | if opts.diff or opts.dry_run: |
| 5517 | cmd += ['--diff'] |
| 5518 | # Will return non-zero exit code if non-empty diff. |
| 5519 | stdout = RunCommand(cmd, error_ok=True, cwd=top_dir) |
| 5520 | if opts.diff: |
| 5521 | sys.stdout.write(stdout) |
| 5522 | elif len(stdout) > 0: |
| 5523 | return_value = 2 |
| 5524 | else: |
| 5525 | cmd += ['-i'] |
| 5526 | RunCommand(cmd, cwd=top_dir) |
sbc@chromium.org | 9d0644d | 2015-06-05 23:16:54 +0000 | [diff] [blame] | 5527 | |
jkarlin@chromium.org | 6f7fa5e | 2016-01-20 19:32:21 +0000 | [diff] [blame] | 5528 | # Dart's formatter does not have the nice property of only operating on |
| 5529 | # modified chunks, so hard code full. |
| 5530 | if dart_diff_files: |
erg@chromium.org | e0a7c5d | 2015-02-23 20:30:08 +0000 | [diff] [blame] | 5531 | try: |
| 5532 | command = [dart_format.FindDartFmtToolInChromiumTree()] |
| 5533 | if not opts.dry_run and not opts.diff: |
| 5534 | command.append('-w') |
jkarlin@chromium.org | 6f7fa5e | 2016-01-20 19:32:21 +0000 | [diff] [blame] | 5535 | command.extend(dart_diff_files) |
erg@chromium.org | e0a7c5d | 2015-02-23 20:30:08 +0000 | [diff] [blame] | 5536 | |
ppi@chromium.org | 6593d93 | 2016-03-03 15:41:15 +0000 | [diff] [blame] | 5537 | stdout = RunCommand(command, cwd=top_dir) |
erg@chromium.org | e0a7c5d | 2015-02-23 20:30:08 +0000 | [diff] [blame] | 5538 | if opts.dry_run and stdout: |
| 5539 | return_value = 2 |
| 5540 | except dart_format.NotFoundError as e: |
vapier | a7fbd5a | 2016-06-16 09:17:49 -0700 | [diff] [blame] | 5541 | print('Warning: Unable to check Dart code formatting. Dart SDK not ' |
| 5542 | 'found in this checkout. Files in other languages are still ' |
| 5543 | 'formatted.') |
erg@chromium.org | e0a7c5d | 2015-02-23 20:30:08 +0000 | [diff] [blame] | 5544 | |
kylechar@chromium.org | 8b61f11 | 2016-02-05 13:28:58 +0000 | [diff] [blame] | 5545 | # Format GN build files. Always run on full build files for canonical form. |
| 5546 | if gn_diff_files: |
Andrii Shyshkalov | 1897532 | 2017-01-25 16:44:13 +0100 | [diff] [blame] | 5547 | cmd = ['gn', 'format'] |
brettw | 4b8ed59 | 2016-08-05 16:19:12 -0700 | [diff] [blame] | 5548 | if opts.dry_run or opts.diff: |
| 5549 | cmd.append('--dry-run') |
kylechar@chromium.org | 8b61f11 | 2016-02-05 13:28:58 +0000 | [diff] [blame] | 5550 | for gn_diff_file in gn_diff_files: |
brettw | 4b8ed59 | 2016-08-05 16:19:12 -0700 | [diff] [blame] | 5551 | gn_ret = subprocess2.call(cmd + [gn_diff_file], |
| 5552 | shell=sys.platform == 'win32', |
| 5553 | cwd=top_dir) |
| 5554 | if opts.dry_run and gn_ret == 2: |
| 5555 | return_value = 2 # Not formatted. |
| 5556 | elif opts.diff and gn_ret == 2: |
| 5557 | # TODO this should compute and print the actual diff. |
| 5558 | print("This change has GN build file diff for " + gn_diff_file) |
| 5559 | elif gn_ret != 0: |
| 5560 | # For non-dry run cases (and non-2 return values for dry-run), a |
| 5561 | # nonzero error code indicates a failure, probably because the file |
| 5562 | # doesn't parse. |
| 5563 | DieWithError("gn format failed on " + gn_diff_file + |
| 5564 | "\nTry running 'gn format' on this file manually.") |
kylechar@chromium.org | 8b61f11 | 2016-02-05 13:28:58 +0000 | [diff] [blame] | 5565 | |
Ilya Sherman | e081cbe | 2017-08-15 17:51:04 -0700 | [diff] [blame] | 5566 | # Skip the metrics formatting from the global presubmit hook. These files have |
| 5567 | # a separate presubmit hook that issues an error if the files need formatting, |
| 5568 | # whereas the top-level presubmit script merely issues a warning. Formatting |
| 5569 | # these files is somewhat slow, so it's important not to duplicate the work. |
| 5570 | if not opts.presubmit: |
| 5571 | for xml_dir in GetDirtyMetricsDirs(diff_files): |
| 5572 | tool_dir = os.path.join(top_dir, xml_dir) |
| 5573 | cmd = [os.path.join(tool_dir, 'pretty_print.py'), '--non-interactive'] |
| 5574 | if opts.dry_run or opts.diff: |
| 5575 | cmd.append('--diff') |
Ilya Sherman | 235b70d | 2017-08-22 17:46:38 -0700 | [diff] [blame] | 5576 | stdout = RunCommand(cmd, cwd=top_dir) |
Ilya Sherman | e081cbe | 2017-08-15 17:51:04 -0700 | [diff] [blame] | 5577 | if opts.diff: |
| 5578 | sys.stdout.write(stdout) |
| 5579 | if opts.dry_run and stdout: |
| 5580 | return_value = 2 # Not formatted. |
Alexei Svitkine | f3cac41 | 2017-02-06 11:08:50 -0500 | [diff] [blame] | 5581 | |
erg@chromium.org | e0a7c5d | 2015-02-23 20:30:08 +0000 | [diff] [blame] | 5582 | return return_value |
agable@chromium.org | fab8f82 | 2013-05-06 17:43:09 +0000 | [diff] [blame] | 5583 | |
Steven Holte | 2e664bf | 2017-04-21 13:10:47 -0700 | [diff] [blame] | 5584 | def GetDirtyMetricsDirs(diff_files): |
| 5585 | xml_diff_files = [x for x in diff_files if MatchingFileType(x, ['.xml'])] |
| 5586 | metrics_xml_dirs = [ |
| 5587 | os.path.join('tools', 'metrics', 'actions'), |
| 5588 | os.path.join('tools', 'metrics', 'histograms'), |
| 5589 | os.path.join('tools', 'metrics', 'rappor'), |
| 5590 | os.path.join('tools', 'metrics', 'ukm')] |
| 5591 | for xml_dir in metrics_xml_dirs: |
| 5592 | if any(file.startswith(xml_dir) for file in xml_diff_files): |
| 5593 | yield xml_dir |
| 5594 | |
agable@chromium.org | fab8f82 | 2013-05-06 17:43:09 +0000 | [diff] [blame] | 5595 | |
scottmg@chromium.org | 84a80c4 | 2015-09-22 20:40:37 +0000 | [diff] [blame] | 5596 | @subcommand.usage('<codereview url or issue id>') |
Edward Lemur | 5ba1e9c | 2018-07-23 18:19:02 +0000 | [diff] [blame] | 5597 | @metrics.collector.collect_metrics('git cl checkout') |
scottmg@chromium.org | 84a80c4 | 2015-09-22 20:40:37 +0000 | [diff] [blame] | 5598 | def CMDcheckout(parser, args): |
tandrii@chromium.org | 5df290f | 2016-04-11 16:12:29 +0000 | [diff] [blame] | 5599 | """Checks out a branch associated with a given Rietveld or Gerrit issue.""" |
scottmg@chromium.org | 84a80c4 | 2015-09-22 20:40:37 +0000 | [diff] [blame] | 5600 | _, args = parser.parse_args(args) |
| 5601 | |
| 5602 | if len(args) != 1: |
| 5603 | parser.print_help() |
| 5604 | return 1 |
| 5605 | |
tandrii@chromium.org | f86c7d3 | 2016-04-01 19:27:30 +0000 | [diff] [blame] | 5606 | issue_arg = ParseIssueNumberArgument(args[0]) |
tandrii@chromium.org | de6c9a1 | 2016-04-11 15:33:53 +0000 | [diff] [blame] | 5607 | if not issue_arg.valid: |
Andrii Shyshkalov | 28d840e | 2017-04-10 15:45:09 +0200 | [diff] [blame] | 5608 | parser.error('invalid codereview url or CL id') |
Andrii Shyshkalov | c971239 | 2017-04-11 13:35:21 +0200 | [diff] [blame] | 5609 | |
tandrii@chromium.org | abd27e5 | 2016-04-11 15:43:32 +0000 | [diff] [blame] | 5610 | target_issue = str(issue_arg.issue) |
scottmg@chromium.org | 84a80c4 | 2015-09-22 20:40:37 +0000 | [diff] [blame] | 5611 | |
tandrii@chromium.org | 5df290f | 2016-04-11 16:12:29 +0000 | [diff] [blame] | 5612 | def find_issues(issueprefix): |
tandrii@chromium.org | 26c8fd2 | 2016-04-11 21:33:21 +0000 | [diff] [blame] | 5613 | output = RunGit(['config', '--local', '--get-regexp', |
| 5614 | r'branch\..*\.%s' % issueprefix], |
| 5615 | error_ok=True) |
| 5616 | for key, issue in [x.split() for x in output.splitlines()]: |
tandrii@chromium.org | 5df290f | 2016-04-11 16:12:29 +0000 | [diff] [blame] | 5617 | if issue == target_issue: |
| 5618 | yield re.sub(r'branch\.(.*)\.%s' % issueprefix, r'\1', key) |
scottmg@chromium.org | 84a80c4 | 2015-09-22 20:40:37 +0000 | [diff] [blame] | 5619 | |
tandrii@chromium.org | 5df290f | 2016-04-11 16:12:29 +0000 | [diff] [blame] | 5620 | branches = [] |
| 5621 | for cls in _CODEREVIEW_IMPLEMENTATIONS.values(): |
tandrii | 5d48c32 | 2016-08-18 16:19:37 -0700 | [diff] [blame] | 5622 | branches.extend(find_issues(cls.IssueConfigKey())) |
scottmg@chromium.org | 84a80c4 | 2015-09-22 20:40:37 +0000 | [diff] [blame] | 5623 | if len(branches) == 0: |
vapier | a7fbd5a | 2016-06-16 09:17:49 -0700 | [diff] [blame] | 5624 | print('No branch found for issue %s.' % target_issue) |
scottmg@chromium.org | 84a80c4 | 2015-09-22 20:40:37 +0000 | [diff] [blame] | 5625 | return 1 |
| 5626 | if len(branches) == 1: |
| 5627 | RunGit(['checkout', branches[0]]) |
| 5628 | else: |
vapier | a7fbd5a | 2016-06-16 09:17:49 -0700 | [diff] [blame] | 5629 | print('Multiple branches match issue %s:' % target_issue) |
scottmg@chromium.org | 84a80c4 | 2015-09-22 20:40:37 +0000 | [diff] [blame] | 5630 | for i in range(len(branches)): |
vapier | a7fbd5a | 2016-06-16 09:17:49 -0700 | [diff] [blame] | 5631 | print('%d: %s' % (i, branches[i])) |
scottmg@chromium.org | 84a80c4 | 2015-09-22 20:40:37 +0000 | [diff] [blame] | 5632 | which = raw_input('Choose by index: ') |
| 5633 | try: |
| 5634 | RunGit(['checkout', branches[int(which)]]) |
| 5635 | except (IndexError, ValueError): |
vapier | a7fbd5a | 2016-06-16 09:17:49 -0700 | [diff] [blame] | 5636 | print('Invalid selection, not checking out any branch.') |
scottmg@chromium.org | 84a80c4 | 2015-09-22 20:40:37 +0000 | [diff] [blame] | 5637 | return 1 |
| 5638 | |
| 5639 | return 0 |
| 5640 | |
| 5641 | |
maruel@chromium.org | 29404b5 | 2014-09-08 22:58:00 +0000 | [diff] [blame] | 5642 | def CMDlol(parser, args): |
| 5643 | # This command is intentionally undocumented. |
vapier | a7fbd5a | 2016-06-16 09:17:49 -0700 | [diff] [blame] | 5644 | print(zlib.decompress(base64.b64decode( |
thakis@chromium.org | 3421c99 | 2014-11-02 02:20:32 +0000 | [diff] [blame] | 5645 | 'eNptkLEOwyAMRHe+wupCIqW57v0Vq84WqWtXyrcXnCBsmgMJ+/SSAxMZgRB6NzE' |
| 5646 | 'E2ObgCKJooYdu4uAQVffUEoE1sRQLxAcqzd7uK2gmStrll1ucV3uZyaY5sXyDd9' |
| 5647 | 'JAnN+lAXsOMJ90GANAi43mq5/VeeacylKVgi8o6F1SC63FxnagHfJUTfUYdCR/W' |
vapier | a7fbd5a | 2016-06-16 09:17:49 -0700 | [diff] [blame] | 5648 | 'Ofe+0dHL7PicpytKP750Fh1q2qnLVof4w8OZWNY'))) |
maruel@chromium.org | 29404b5 | 2014-09-08 22:58:00 +0000 | [diff] [blame] | 5649 | return 0 |
| 5650 | |
| 5651 | |
iannucci@chromium.org | d9c1b20 | 2013-07-24 23:52:11 +0000 | [diff] [blame] | 5652 | class OptionParser(optparse.OptionParser): |
| 5653 | """Creates the option parse and add --verbose support.""" |
| 5654 | def __init__(self, *args, **kwargs): |
maruel@chromium.org | 0633fb4 | 2013-08-16 20:06:14 +0000 | [diff] [blame] | 5655 | optparse.OptionParser.__init__( |
| 5656 | self, *args, prog='git cl', version=__version__, **kwargs) |
iannucci@chromium.org | d9c1b20 | 2013-07-24 23:52:11 +0000 | [diff] [blame] | 5657 | self.add_option( |
| 5658 | '-v', '--verbose', action='count', default=0, |
| 5659 | help='Use 2 times for more debugging info') |
| 5660 | |
Edward Lemur | 5ba1e9c | 2018-07-23 18:19:02 +0000 | [diff] [blame] | 5661 | def parse_args(self, args=None, _values=None): |
Andrii Shyshkalov | 46f20cd | 2018-10-30 06:42:54 +0000 | [diff] [blame] | 5662 | try: |
| 5663 | return self._parse_args(args) |
| 5664 | finally: |
| 5665 | # Regardless of success or failure of args parsing, we want to report |
| 5666 | # metrics, but only after logging has been initialized (if parsing |
| 5667 | # succeeded). |
| 5668 | global settings |
| 5669 | settings = Settings() |
| 5670 | |
| 5671 | if not metrics.DISABLE_METRICS_COLLECTION: |
| 5672 | # GetViewVCUrl ultimately calls logging method. |
| 5673 | project_url = settings.GetViewVCUrl().strip('/+') |
| 5674 | if project_url in metrics_utils.KNOWN_PROJECT_URLS: |
| 5675 | metrics.collector.add('project_urls', [project_url]) |
| 5676 | |
| 5677 | def _parse_args(self, args=None): |
Edward Lemur | 5ba1e9c | 2018-07-23 18:19:02 +0000 | [diff] [blame] | 5678 | # Create an optparse.Values object that will store only the actual passed |
| 5679 | # options, without the defaults. |
| 5680 | actual_options = optparse.Values() |
| 5681 | _, args = optparse.OptionParser.parse_args(self, args, actual_options) |
| 5682 | # Create an optparse.Values object with the default options. |
| 5683 | options = optparse.Values(self.get_default_values().__dict__) |
| 5684 | # Update it with the options passed by the user. |
| 5685 | options._update_careful(actual_options.__dict__) |
| 5686 | # Store the options passed by the user in an _actual_options attribute. |
| 5687 | # We store only the keys, and not the values, since the values can contain |
| 5688 | # arbitrary information, which might be PII. |
| 5689 | metrics.collector.add('arguments', actual_options.__dict__.keys()) |
| 5690 | |
iannucci@chromium.org | d9c1b20 | 2013-07-24 23:52:11 +0000 | [diff] [blame] | 5691 | levels = [logging.WARNING, logging.INFO, logging.DEBUG] |
Andrii Shyshkalov | 5b04a57 | 2017-01-23 17:44:41 +0100 | [diff] [blame] | 5692 | logging.basicConfig( |
| 5693 | level=levels[min(options.verbose, len(levels) - 1)], |
| 5694 | format='[%(levelname).1s%(asctime)s %(process)d %(thread)d ' |
| 5695 | '%(filename)s] %(message)s') |
Edward Lemur | 83bd7f4 | 2018-10-10 00:14:21 +0000 | [diff] [blame] | 5696 | |
iannucci@chromium.org | d9c1b20 | 2013-07-24 23:52:11 +0000 | [diff] [blame] | 5697 | return options, args |
| 5698 | |
iannucci@chromium.org | d9c1b20 | 2013-07-24 23:52:11 +0000 | [diff] [blame] | 5699 | |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 5700 | def main(argv): |
maruel@chromium.org | 82798cb | 2012-02-23 18:16:12 +0000 | [diff] [blame] | 5701 | if sys.hexversion < 0x02060000: |
vapier | a7fbd5a | 2016-06-16 09:17:49 -0700 | [diff] [blame] | 5702 | print('\nYour python version %s is unsupported, please upgrade.\n' % |
| 5703 | (sys.version.split(' ', 1)[0],), file=sys.stderr) |
maruel@chromium.org | 82798cb | 2012-02-23 18:16:12 +0000 | [diff] [blame] | 5704 | return 2 |
maruel@chromium.org | 2e23ce3 | 2013-05-07 12:42:28 +0000 | [diff] [blame] | 5705 | |
maruel@chromium.org | 39c0b22 | 2013-08-17 16:57:01 +0000 | [diff] [blame] | 5706 | colorize_CMDstatus_doc() |
maruel@chromium.org | 0633fb4 | 2013-08-16 20:06:14 +0000 | [diff] [blame] | 5707 | dispatcher = subcommand.CommandDispatcher(__name__) |
| 5708 | try: |
| 5709 | return dispatcher.execute(OptionParser(), argv) |
vadimsh@chromium.org | eed4df3 | 2015-04-10 21:30:20 +0000 | [diff] [blame] | 5710 | except auth.AuthenticationError as e: |
| 5711 | DieWithError(str(e)) |
vapier | fd77ac7 | 2016-06-16 08:33:57 -0700 | [diff] [blame] | 5712 | except urllib2.HTTPError as e: |
maruel@chromium.org | 0633fb4 | 2013-08-16 20:06:14 +0000 | [diff] [blame] | 5713 | if e.code != 500: |
| 5714 | raise |
| 5715 | DieWithError( |
| 5716 | ('AppEngine is misbehaving and returned HTTP %d, again. Keep faith ' |
| 5717 | 'and retry or visit go/isgaeup.\n%s') % (e.code, str(e))) |
sbc@chromium.org | 013731e | 2015-02-26 18:28:43 +0000 | [diff] [blame] | 5718 | return 0 |
chase@chromium.org | cc51cd0 | 2010-12-23 00:48:39 +0000 | [diff] [blame] | 5719 | |
| 5720 | |
| 5721 | if __name__ == '__main__': |
maruel@chromium.org | 2e23ce3 | 2013-05-07 12:42:28 +0000 | [diff] [blame] | 5722 | # These affect sys.stdout so do it outside of main() to simplify mocks in |
| 5723 | # unit testing. |
maruel@chromium.org | 6f09cd9 | 2011-04-01 16:38:12 +0000 | [diff] [blame] | 5724 | fix_encoding.fix_encoding() |
iannucci@chromium.org | 596cd5c | 2016-04-04 21:34:39 +0000 | [diff] [blame] | 5725 | setup_color.init() |
Edward Lemur | 6f812e1 | 2018-07-31 22:45:57 +0000 | [diff] [blame] | 5726 | with metrics.collector.print_notice_and_exit(): |
sbc@chromium.org | 013731e | 2015-02-26 18:28:43 +0000 | [diff] [blame] | 5727 | sys.exit(main(sys.argv[1:])) |