blob: fcb0d5436eb271d37e23d69abec5f3ea3d15eb91 [file] [log] [blame]
Edward Lemur1f3bafb2019-10-08 17:56:33 +00001#!/usr/bin/env vpython
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +02002# Copyright (c) 2013 The Chromium Authors. All rights reserved.
maruel@chromium.org725f1c32011-04-01 20:24:54 +00003# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00006# Copyright (C) 2008 Evan Martin <martine@danga.com>
7
Andrii Shyshkalov03da1502018-10-15 03:42:34 +00008"""A git-command for integrating reviews on Gerrit."""
maruel@chromium.org725f1c32011-04-01 20:24:54 +00009
vapiera7fbd5a2016-06-16 09:17:49 -070010from __future__ import print_function
11
tapted@chromium.org6a0b07c2013-07-10 01:29:19 +000012from distutils.version import LooseVersion
thakis@chromium.org3421c992014-11-02 02:20:32 +000013import base64
rmistry@google.com2dd99862015-06-22 12:22:18 +000014import collections
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +010015import datetime
Brian Sheedyb4307d52019-12-02 19:18:17 +000016import fnmatch
Edward Lemur202c5592019-10-21 22:44:52 +000017import httplib2
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +010018import itertools
maruel@chromium.org4f6852c2012-04-20 20:39:20 +000019import json
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000020import logging
calamity@chromium.orgcf197482016-04-29 20:15:53 +000021import multiprocessing
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000022import optparse
23import os
24import re
Andrii Shyshkalov353637c2017-03-14 16:52:18 +010025import shutil
ukai@chromium.org78c4b982012-02-14 02:20:26 +000026import stat
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000027import sys
Aaron Gable9a03ae02017-11-03 11:31:07 -070028import tempfile
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000029import textwrap
Edward Lemurfec80c42018-11-01 23:14:14 +000030import time
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +000031import uuid
thestig@chromium.org00858c82013-12-02 23:08:03 +000032import webbrowser
thakis@chromium.org3421c992014-11-02 02:20:32 +000033import zlib
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000034
maruel@chromium.org2e23ce32013-05-07 12:42:28 +000035from third_party import colorama
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +000036import auth
nick@chromium.org3ac1c4e2014-01-16 02:44:42 +000037import clang_format
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +000038import dart_format
maruel@chromium.org6f09cd92011-04-01 16:38:12 +000039import fix_encoding
maruel@chromium.org0e0436a2011-10-25 13:32:41 +000040import gclient_utils
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +000041import gerrit_util
iannucci@chromium.org9e849272014-04-04 00:31:55 +000042import git_common
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +000043import git_footers
Edward Lemur85153282020-02-14 22:06:29 +000044import git_new_branch
Edward Lemur5ba1e9c2018-07-23 18:19:02 +000045import metrics
Edward Lesmes93277a72018-10-18 22:04:26 +000046import metrics_utils
piman@chromium.org336f9122014-09-04 02:16:55 +000047import owners
iannucci@chromium.org9e849272014-04-04 00:31:55 +000048import owners_finder
maruel@chromium.org2a74d372011-03-29 19:05:50 +000049import presubmit_support
50import scm
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +000051import setup_color
Francois Dorayd42c6812017-05-30 15:10:20 -040052import split_cl
maruel@chromium.org0633fb42013-08-16 20:06:14 +000053import subcommand
maruel@chromium.org32f9f5e2011-09-14 13:41:47 +000054import subprocess2
maruel@chromium.org2a74d372011-03-29 19:05:50 +000055import watchlists
56
Edward Lemur79d4f992019-11-11 23:49:02 +000057from third_party import six
58from six.moves import urllib
59
60
61if sys.version_info.major == 3:
62 basestring = (str,) # pylint: disable=redefined-builtin
63
Edward Lemurb9830242019-10-30 22:19:20 +000064
tandrii7400cf02016-06-21 08:48:07 -070065__version__ = '2.0'
maruel@chromium.org2a74d372011-03-29 19:05:50 +000066
Edward Lemur0f58ae42019-04-30 17:24:12 +000067# Traces for git push will be stored in a traces directory inside the
68# depot_tools checkout.
69DEPOT_TOOLS = os.path.dirname(os.path.abspath(__file__))
70TRACES_DIR = os.path.join(DEPOT_TOOLS, 'traces')
Edward Lemur227d5102020-02-25 23:45:35 +000071PRESUBMIT_SUPPORT = os.path.join(DEPOT_TOOLS, 'presubmit_support.py')
Edward Lemur0f58ae42019-04-30 17:24:12 +000072
73# When collecting traces, Git hashes will be reduced to 6 characters to reduce
74# the size after compression.
75GIT_HASH_RE = re.compile(r'\b([a-f0-9]{6})[a-f0-9]{34}\b', flags=re.I)
76# Used to redact the cookies from the gitcookies file.
77GITCOOKIES_REDACT_RE = re.compile(r'1/.*')
78
Edward Lemurd4d1ba42019-09-20 21:46:37 +000079MAX_ATTEMPTS = 3
80
Edward Lemur1b52d872019-05-09 21:12:12 +000081# The maximum number of traces we will keep. Multiplied by 3 since we store
82# 3 files per trace.
83MAX_TRACES = 3 * 10
Edward Lemur5737f022019-05-17 01:24:00 +000084# Message to be displayed to the user to inform where to find the traces for a
85# git-cl upload execution.
Edward Lemur0f58ae42019-04-30 17:24:12 +000086TRACES_MESSAGE = (
Edward Lemur1b52d872019-05-09 21:12:12 +000087'\n'
Edward Lemur5737f022019-05-17 01:24:00 +000088'The traces of this git-cl execution have been recorded at:\n'
Edward Lemur1b52d872019-05-09 21:12:12 +000089' %(trace_name)s-traces.zip\n'
Edward Lemur5737f022019-05-17 01:24:00 +000090'Copies of your gitcookies file and git config have been recorded at:\n'
91' %(trace_name)s-git-info.zip\n')
Edward Lemur1b52d872019-05-09 21:12:12 +000092# Format of the message to be stored as part of the traces to give developers a
93# better context when they go through traces.
94TRACES_README_FORMAT = (
95'Date: %(now)s\n'
96'\n'
97'Change: https://%(gerrit_host)s/q/%(change_id)s\n'
98'Title: %(title)s\n'
99'\n'
100'%(description)s\n'
101'\n'
102'Execution time: %(execution_time)s\n'
103'Exit code: %(exit_code)s\n') + TRACES_MESSAGE
Edward Lemur0f58ae42019-04-30 17:24:12 +0000104
tandrii9d2c7a32016-06-22 03:42:45 -0700105COMMIT_BOT_EMAIL = 'commit-bot@chromium.org'
Aaron Gable1bc7bfe2016-12-19 10:08:14 -0800106POSTUPSTREAM_HOOK = '.git/hooks/post-cl-land'
Henrique Ferreiroff249622019-11-28 23:19:29 +0000107DESCRIPTION_BACKUP_FILE = '.git_cl_description_backup'
rmistry@google.comc68112d2015-03-03 12:48:06 +0000108REFS_THAT_ALIAS_TO_OTHER_REFS = {
109 'refs/remotes/origin/lkgr': 'refs/remotes/origin/master',
110 'refs/remotes/origin/lkcr': 'refs/remotes/origin/master',
111}
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000112
thestig@chromium.org44202a22014-03-11 19:22:18 +0000113# Valid extensions for files we want to lint.
114DEFAULT_LINT_REGEX = r"(.*\.cpp|.*\.cc|.*\.h)"
115DEFAULT_LINT_IGNORE_REGEX = r"$^"
116
Aiden Bennerc08566e2018-10-03 17:52:42 +0000117# File name for yapf style config files.
118YAPF_CONFIG_FILENAME = '.style.yapf'
119
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000120# Shortcut since it quickly becomes repetitive.
maruel@chromium.org2e23ce32013-05-07 12:42:28 +0000121Fore = colorama.Fore
maruel@chromium.org90541732011-04-01 17:54:18 +0000122
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000123# Initialized in main()
124settings = None
125
Andrii Shyshkalov768f1d82016-12-08 15:10:13 +0100126# Used by tests/git_cl_test.py to add extra logging.
127# Inside the weirdly failing test, add this:
128# >>> self.mock(git_cl, '_IS_BEING_TESTED', True)
Quinten Yearsley0c62da92017-05-31 13:39:42 -0700129# And scroll up to see the stack trace printed.
Andrii Shyshkalov768f1d82016-12-08 15:10:13 +0100130_IS_BEING_TESTED = False
131
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000132
Christopher Lamf732cd52017-01-24 12:40:11 +1100133def DieWithError(message, change_desc=None):
134 if change_desc:
135 SaveDescriptionBackup(change_desc)
Josip Sokcevic953278a2020-02-28 19:46:36 +0000136 print('\n ** Content of CL description **\n' +
137 '='*72 + '\n' +
138 change_desc.description + '\n' +
139 '='*72 + '\n')
Christopher Lamf732cd52017-01-24 12:40:11 +1100140
vapiera7fbd5a2016-06-16 09:17:49 -0700141 print(message, file=sys.stderr)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000142 sys.exit(1)
143
144
Christopher Lamf732cd52017-01-24 12:40:11 +1100145def SaveDescriptionBackup(change_desc):
Henrique Ferreiro5ae48172019-11-29 16:14:42 +0000146 backup_path = os.path.join(DEPOT_TOOLS, DESCRIPTION_BACKUP_FILE)
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000147 print('\nsaving CL description to %s\n' % backup_path)
Josip906bfde2020-01-31 22:38:49 +0000148 with open(backup_path, 'w') as backup_file:
149 backup_file.write(change_desc.description)
Christopher Lamf732cd52017-01-24 12:40:11 +1100150
151
thestig@chromium.org8b0553c2014-02-11 00:33:37 +0000152def GetNoGitPagerEnv():
153 env = os.environ.copy()
154 # 'cat' is a magical git string that disables pagers on all platforms.
155 env['GIT_PAGER'] = 'cat'
156 return env
157
vadimsh@chromium.org566a02a2014-08-22 01:34:13 +0000158
bsep@chromium.org627d9002016-04-29 00:00:52 +0000159def RunCommand(args, error_ok=False, error_message=None, shell=False, **kwargs):
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000160 try:
Edward Lemur79d4f992019-11-11 23:49:02 +0000161 stdout = subprocess2.check_output(args, shell=shell, **kwargs)
162 return stdout.decode('utf-8', 'replace')
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000163 except subprocess2.CalledProcessError as e:
164 logging.debug('Failed running %s', args)
maruel@chromium.org32f9f5e2011-09-14 13:41:47 +0000165 if not error_ok:
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000166 DieWithError(
maruel@chromium.org32f9f5e2011-09-14 13:41:47 +0000167 'Command "%s" failed.\n%s' % (
168 ' '.join(args), error_message or e.stdout or ''))
Edward Lemur79d4f992019-11-11 23:49:02 +0000169 return e.stdout.decode('utf-8', 'replace')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000170
171
172def RunGit(args, **kwargs):
maruel@chromium.org32f9f5e2011-09-14 13:41:47 +0000173 """Returns stdout."""
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000174 return RunCommand(['git'] + args, **kwargs)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000175
176
enne@chromium.org3b7e15c2014-01-21 17:44:47 +0000177def RunGitWithCode(args, suppress_stderr=False):
maruel@chromium.org32f9f5e2011-09-14 13:41:47 +0000178 """Returns return code and stdout."""
tandrii5d48c322016-08-18 16:19:37 -0700179 if suppress_stderr:
180 stderr = subprocess2.VOID
181 else:
182 stderr = sys.stderr
szager@chromium.org9bb85e22012-06-13 20:28:23 +0000183 try:
tandrii5d48c322016-08-18 16:19:37 -0700184 (out, _), code = subprocess2.communicate(['git'] + args,
185 env=GetNoGitPagerEnv(),
186 stdout=subprocess2.PIPE,
187 stderr=stderr)
Edward Lemur79d4f992019-11-11 23:49:02 +0000188 return code, out.decode('utf-8', 'replace')
tandrii5d48c322016-08-18 16:19:37 -0700189 except subprocess2.CalledProcessError as e:
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +0900190 logging.debug('Failed running %s', ['git'] + args)
Edward Lemur79d4f992019-11-11 23:49:02 +0000191 return e.returncode, e.stdout.decode('utf-8', 'replace')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000192
193
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000194def RunGitSilent(args):
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +0000195 """Returns stdout, suppresses stderr and ignores the return code."""
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000196 return RunGitWithCode(args, suppress_stderr=True)[1]
197
198
tapted@chromium.org6a0b07c2013-07-10 01:29:19 +0000199def IsGitVersionAtLeast(min_version):
ilevy@chromium.orgcc56ee42013-07-10 22:16:29 +0000200 prefix = 'git version '
tapted@chromium.org6a0b07c2013-07-10 01:29:19 +0000201 version = RunGit(['--version']).strip()
ilevy@chromium.orgcc56ee42013-07-10 22:16:29 +0000202 return (version.startswith(prefix) and
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000203 LooseVersion(version[len(prefix):]) >= LooseVersion(min_version))
tapted@chromium.org6a0b07c2013-07-10 01:29:19 +0000204
205
pgervais@chromium.org8ba38ff2015-06-11 21:41:25 +0000206def BranchExists(branch):
207 """Return True if specified branch exists."""
208 code, _ = RunGitWithCode(['rev-parse', '--verify', branch],
209 suppress_stderr=True)
210 return not code
211
212
tandrii2a16b952016-10-19 07:09:44 -0700213def time_sleep(seconds):
214 # Use this so that it can be mocked in tests without interfering with python
215 # system machinery.
tandrii2a16b952016-10-19 07:09:44 -0700216 return time.sleep(seconds)
217
218
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000219def time_time():
220 # Use this so that it can be mocked in tests without interfering with python
221 # system machinery.
222 return time.time()
223
224
Edward Lemur1b52d872019-05-09 21:12:12 +0000225def datetime_now():
226 # Use this so that it can be mocked in tests without interfering with python
227 # system machinery.
228 return datetime.datetime.now()
229
230
Edward Lemur1a83da12020-03-04 21:18:36 +0000231def _raw_input(message):
232 # Use this so that it can be mocked in tests on Python 2 and 3.
233 if sys.version_info.major == 2:
234 return raw_input(message)
235 return input(message)
236
237
maruel@chromium.org90541732011-04-01 17:54:18 +0000238def ask_for_data(prompt):
239 try:
Edward Lemur1a83da12020-03-04 21:18:36 +0000240 return _raw_input(prompt)
maruel@chromium.org90541732011-04-01 17:54:18 +0000241 except KeyboardInterrupt:
242 # Hide the exception.
243 sys.exit(1)
244
245
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100246def confirm_or_exit(prefix='', action='confirm'):
247 """Asks user to press enter to continue or press Ctrl+C to abort."""
248 if not prefix or prefix.endswith('\n'):
249 mid = 'Press'
Andrii Shyshkalov353637c2017-03-14 16:52:18 +0100250 elif prefix.endswith('.') or prefix.endswith('?'):
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100251 mid = ' Press'
252 elif prefix.endswith(' '):
253 mid = 'press'
254 else:
255 mid = ' press'
256 ask_for_data('%s%s Enter to %s, or Ctrl+C to abort' % (prefix, mid, action))
257
258
259def ask_for_explicit_yes(prompt):
Quinten Yearsleyd242ed72019-07-25 17:17:55 +0000260 """Returns whether user typed 'y' or 'yes' to confirm the given prompt."""
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100261 result = ask_for_data(prompt + ' [Yes/No]: ').lower()
262 while True:
263 if 'yes'.startswith(result):
264 return True
265 if 'no'.startswith(result):
266 return False
267 result = ask_for_data('Please, type yes or no: ').lower()
268
269
tandrii5d48c322016-08-18 16:19:37 -0700270def _git_branch_config_key(branch, key):
271 """Helper method to return Git config key for a branch."""
272 assert branch, 'branch name is required to set git config for it'
273 return 'branch.%s.%s' % (branch, key)
274
275
machenbach@chromium.org45453142015-09-15 08:45:22 +0000276def _get_properties_from_options(options):
Quinten Yearsleya19d3532019-09-30 21:54:39 +0000277 prop_list = getattr(options, 'properties', [])
278 properties = dict(x.split('=', 1) for x in prop_list)
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +0000279 for key, val in properties.items():
machenbach@chromium.org45453142015-09-15 08:45:22 +0000280 try:
281 properties[key] = json.loads(val)
282 except ValueError:
283 pass # If a value couldn't be evaluated, treat it as a string.
284 return properties
285
286
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000287# TODO(crbug.com/976104): Remove this function once git-cl try-results has
288# migrated to use buildbucket v2
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000289def _buildbucket_retry(operation_name, http, *args, **kwargs):
290 """Retries requests to buildbucket service and returns parsed json content."""
291 try_count = 0
292 while True:
293 response, content = http.request(*args, **kwargs)
294 try:
295 content_json = json.loads(content)
296 except ValueError:
297 content_json = None
298
299 # Buildbucket could return an error even if status==200.
300 if content_json and content_json.get('error'):
nodir@chromium.orgbaff4e12016-03-08 00:33:57 +0000301 error = content_json.get('error')
302 if error.get('code') == 403:
303 raise BuildbucketResponseException(
304 'Access denied: %s' % error.get('message', ''))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000305 msg = 'Error in response. Reason: %s. Message: %s.' % (
nodir@chromium.orgbaff4e12016-03-08 00:33:57 +0000306 error.get('reason', ''), error.get('message', ''))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000307 raise BuildbucketResponseException(msg)
308
309 if response.status == 200:
Nodir Turakulov23d75d22018-06-04 12:37:32 -0700310 if content_json is None:
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000311 raise BuildbucketResponseException(
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000312 'Buildbucket returned invalid JSON content: %s.\n'
Nodir Turakulov9ac59792018-06-04 12:34:14 -0700313 'Please file bugs at http://crbug.com, '
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000314 'component "Infra>Platform>Buildbucket".' %
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000315 content)
316 return content_json
317 if response.status < 500 or try_count >= 2:
318 raise httplib2.HttpLib2Error(content)
319
320 # status >= 500 means transient failures.
321 logging.debug('Transient errors when %s. Will retry.', operation_name)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000322 time_sleep(0.5 + (1.5 * try_count))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000323 try_count += 1
324 assert False, 'unreachable'
325
326
Edward Lemur4c707a22019-09-24 21:13:43 +0000327def _call_buildbucket(http, buildbucket_host, method, request):
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000328 """Calls a buildbucket v2 method and returns the parsed json response."""
329 headers = {
330 'Accept': 'application/json',
331 'Content-Type': 'application/json',
332 }
333 request = json.dumps(request)
334 url = 'https://%s/prpc/buildbucket.v2.Builds/%s' % (buildbucket_host, method)
335
336 logging.info('POST %s with %s' % (url, request))
337
338 attempts = 1
339 time_to_sleep = 1
340 while True:
341 response, content = http.request(url, 'POST', body=request, headers=headers)
342 if response.status == 200:
343 return json.loads(content[4:])
344 if attempts >= MAX_ATTEMPTS or 400 <= response.status < 500:
345 msg = '%s error when calling POST %s with %s: %s' % (
346 response.status, url, request, content)
347 raise BuildbucketResponseException(msg)
348 logging.debug(
349 '%s error when calling POST %s with %s. '
350 'Sleeping for %d seconds and retrying...' % (
351 response.status, url, request, time_to_sleep))
352 time.sleep(time_to_sleep)
353 time_to_sleep *= 2
354 attempts += 1
355
356 assert False, 'unreachable'
357
358
Edward Lemur6215c792019-10-03 21:59:05 +0000359def _parse_bucket(raw_bucket):
360 legacy = True
361 project = bucket = None
362 if '/' in raw_bucket:
363 legacy = False
364 project, bucket = raw_bucket.split('/', 1)
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000365 # Assume luci.<project>.<bucket>.
Edward Lemur6215c792019-10-03 21:59:05 +0000366 elif raw_bucket.startswith('luci.'):
367 project, bucket = raw_bucket[len('luci.'):].split('.', 1)
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000368 # Otherwise, assume prefix is also the project name.
Edward Lemur6215c792019-10-03 21:59:05 +0000369 elif '.' in raw_bucket:
370 project = raw_bucket.split('.')[0]
371 bucket = raw_bucket
372 # Legacy buckets.
Edward Lemur45768512020-03-02 19:03:14 +0000373 if legacy and project and bucket:
Edward Lemur6215c792019-10-03 21:59:05 +0000374 print('WARNING Please use %s/%s to specify the bucket.' % (project, bucket))
375 return project, bucket
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000376
377
Edward Lemur45768512020-03-02 19:03:14 +0000378def _trigger_try_jobs(changelist, jobs, options, patchset):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000379 """Sends a request to Buildbucket to trigger tryjobs for a changelist.
qyearsley1fdfcb62016-10-24 13:22:03 -0700380
381 Args:
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000382 changelist: Changelist that the tryjobs are associated with.
Edward Lemur45768512020-03-02 19:03:14 +0000383 jobs: A list of (project, bucket, builder).
qyearsley1fdfcb62016-10-24 13:22:03 -0700384 options: Command-line options.
385 """
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000386 print('Scheduling jobs on:')
Edward Lemur45768512020-03-02 19:03:14 +0000387 for project, bucket, builder in jobs:
388 print(' %s/%s: %s' % (project, bucket, builder))
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000389 print('To see results here, run: git cl try-results')
390 print('To see results in browser, run: git cl web')
tandriide281ae2016-10-12 06:02:30 -0700391
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +0000392 requests = _make_try_job_schedule_requests(
Edward Lemur45768512020-03-02 19:03:14 +0000393 changelist, jobs, options, patchset)
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +0000394 if not requests:
395 return
396
Edward Lemur5b929a42019-10-21 17:57:39 +0000397 http = auth.Authenticator().authorize(httplib2.Http())
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +0000398 http.force_exception_to_status_code = True
399
400 batch_request = {'requests': requests}
401 batch_response = _call_buildbucket(
402 http, options.buildbucket_host, 'Batch', batch_request)
403
404 errors = [
405 ' ' + response['error']['message']
406 for response in batch_response.get('responses', [])
407 if 'error' in response
408 ]
409 if errors:
410 raise BuildbucketResponseException(
411 'Failed to schedule builds for some bots:\n%s' % '\n'.join(errors))
412
413
Edward Lemur45768512020-03-02 19:03:14 +0000414def _make_try_job_schedule_requests(changelist, jobs, options, patchset):
Edward Lemurf0faf482019-09-25 20:40:17 +0000415 gerrit_changes = [changelist.GetGerritChange(patchset)]
Quinten Yearsleya19d3532019-09-30 21:54:39 +0000416 shared_properties = {'category': getattr(options, 'category', 'git_cl_try')}
Quinten Yearsleya19d3532019-09-30 21:54:39 +0000417 if getattr(options, 'clobber', False):
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000418 shared_properties['clobber'] = True
419 shared_properties.update(_get_properties_from_options(options) or {})
420
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +0000421 shared_tags = [{'key': 'user_agent', 'value': 'git_cl_try'}]
422 if options.retry_failed:
423 shared_tags.append({'key': 'retry_failed',
424 'value': '1'})
425
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000426 requests = []
Edward Lemur45768512020-03-02 19:03:14 +0000427 for (project, bucket, builder) in jobs:
428 properties = shared_properties.copy()
429 if 'presubmit' in builder.lower():
430 properties['dry_run'] = 'true'
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000431
Edward Lemur45768512020-03-02 19:03:14 +0000432 requests.append({
433 'scheduleBuild': {
434 'requestId': str(uuid.uuid4()),
435 'builder': {
436 'project': getattr(options, 'project', None) or project,
437 'bucket': bucket,
438 'builder': builder,
439 },
440 'gerritChanges': gerrit_changes,
441 'properties': properties,
442 'tags': [
443 {'key': 'builder', 'value': builder},
444 ] + shared_tags,
445 }
446 })
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000447
Edward Lemur45768512020-03-02 19:03:14 +0000448 if options.revision:
449 requests[-1]['scheduleBuild']['gitilesCommit'] = {
450 'host': gerrit_changes[0]['host'],
451 'project': gerrit_changes[0]['project'],
452 'id': options.revision
453 }
Anthony Polito1a5fe232020-01-24 23:17:52 +0000454
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +0000455 return requests
kjellander@chromium.org44424542015-06-02 18:35:29 +0000456
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000457
Edward Lemur5b929a42019-10-21 17:57:39 +0000458def fetch_try_jobs(changelist, buildbucket_host, patchset=None):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000459 """Fetches tryjobs from buildbucket.
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000460
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000461 Returns list of buildbucket.v2.Build with the try jobs for the changelist.
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000462 """
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +0000463 fields = ['id', 'builder', 'status', 'createTime', 'tags']
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000464 request = {
465 'predicate': {
466 'gerritChanges': [changelist.GetGerritChange(patchset)],
467 },
468 'fields': ','.join('builds.*.' + field for field in fields),
469 }
tandrii221ab252016-10-06 08:12:04 -0700470
Edward Lemur5b929a42019-10-21 17:57:39 +0000471 authenticator = auth.Authenticator()
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000472 if authenticator.has_cached_credentials():
473 http = authenticator.authorize(httplib2.Http())
474 else:
vapiera7fbd5a2016-06-16 09:17:49 -0700475 print('Warning: Some results might be missing because %s' %
476 # Get the message on how to login.
Edward Lemurba5bc992019-09-23 22:59:17 +0000477 (auth.LoginRequiredError().message,))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000478 http = httplib2.Http()
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000479 http.force_exception_to_status_code = True
480
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000481 response = _call_buildbucket(http, buildbucket_host, 'SearchBuilds', request)
482 return response.get('builds', [])
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000483
Edward Lemur45768512020-03-02 19:03:14 +0000484
Edward Lemur5b929a42019-10-21 17:57:39 +0000485def _fetch_latest_builds(changelist, buildbucket_host, latest_patchset=None):
Quinten Yearsley983111f2019-09-26 17:18:48 +0000486 """Fetches builds from the latest patchset that has builds (within
487 the last few patchsets).
488
489 Args:
Quinten Yearsley983111f2019-09-26 17:18:48 +0000490 changelist (Changelist): The CL to fetch builds for
491 buildbucket_host (str): Buildbucket host, e.g. "cr-buildbucket.appspot.com"
Andrii Shyshkalov1ad58112019-10-08 01:46:14 +0000492 lastest_patchset(int|NoneType): the patchset to start fetching builds from.
493 If None (default), starts with the latest available patchset.
Quinten Yearsley983111f2019-09-26 17:18:48 +0000494 Returns:
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000495 A tuple (builds, patchset) where builds is a list of buildbucket.v2.Build,
496 and patchset is the patchset number where those builds came from.
Quinten Yearsley983111f2019-09-26 17:18:48 +0000497 """
498 assert buildbucket_host
499 assert changelist.GetIssue(), 'CL must be uploaded first'
500 assert changelist.GetCodereviewServer(), 'CL must be uploaded first'
Andrii Shyshkalov1ad58112019-10-08 01:46:14 +0000501 if latest_patchset is None:
502 assert changelist.GetMostRecentPatchset()
503 ps = changelist.GetMostRecentPatchset()
504 else:
505 assert latest_patchset > 0, latest_patchset
506 ps = latest_patchset
507
Quinten Yearsley983111f2019-09-26 17:18:48 +0000508 min_ps = max(1, ps - 5)
509 while ps >= min_ps:
Edward Lemur5b929a42019-10-21 17:57:39 +0000510 builds = fetch_try_jobs(changelist, buildbucket_host, patchset=ps)
Quinten Yearsley983111f2019-09-26 17:18:48 +0000511 if len(builds):
512 return builds, ps
513 ps -= 1
514 return [], 0
515
516
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +0000517def _filter_failed_for_retry(all_builds):
518 """Returns a list of buckets/builders that are worth retrying.
Quinten Yearsley983111f2019-09-26 17:18:48 +0000519
520 Args:
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +0000521 all_builds (list): Builds, in the format returned by fetch_try_jobs,
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000522 i.e. a list of buildbucket.v2.Builds which includes status and builder
523 info.
Quinten Yearsley983111f2019-09-26 17:18:48 +0000524
525 Returns:
Edward Lemur45768512020-03-02 19:03:14 +0000526 A dict {(proj, bucket): [builders]}. This is the same format accepted by
527 _trigger_try_jobs.
Quinten Yearsley983111f2019-09-26 17:18:48 +0000528 """
Edward Lemur45768512020-03-02 19:03:14 +0000529 grouped = {}
530 for build in all_builds:
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +0000531 builder = build['builder']
Edward Lemur45768512020-03-02 19:03:14 +0000532 key = (builder['project'], builder['bucket'], builder['builder'])
533 grouped.setdefault(key, []).append(build)
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +0000534
Edward Lemur45768512020-03-02 19:03:14 +0000535 jobs = []
536 for (project, bucket, builder), builds in grouped.items():
537 if 'triggered' in builder:
538 print('WARNING: Not scheduling %s. Triggered bots require an initial job '
539 'from a parent. Please schedule a manual job for the parent '
540 'instead.')
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +0000541 continue
542 if any(b['status'] in ('STARTED', 'SCHEDULED') for b in builds):
543 # Don't retry if any are running.
544 continue
Edward Lemur45768512020-03-02 19:03:14 +0000545 # If builder had several builds, retry only if the last one failed.
546 # This is a bit different from CQ, which would re-use *any* SUCCESS-full
547 # build, but in case of retrying failed jobs retrying a flaky one makes
548 # sense.
549 builds = sorted(builds, key=lambda b: b['createTime'])
550 if builds[-1]['status'] not in ('FAILURE', 'INFRA_FAILURE'):
551 continue
552 # Don't retry experimental build previously triggered by CQ.
553 if any(t['key'] == 'cq_experimental' and t['value'] == 'true'
554 for t in builds[-1]['tags']):
555 continue
556 jobs.append((project, bucket, builder))
557
558 # Sort the jobs to make testing easier.
559 return sorted(jobs)
Quinten Yearsley983111f2019-09-26 17:18:48 +0000560
561
qyearsleyeab3c042016-08-24 09:18:28 -0700562def print_try_jobs(options, builds):
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000563 """Prints nicely result of fetch_try_jobs."""
564 if not builds:
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000565 print('No tryjobs scheduled.')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000566 return
567
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000568 longest_builder = max(len(b['builder']['builder']) for b in builds)
569 name_fmt = '{builder:<%d}' % longest_builder
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000570 if options.print_master:
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000571 longest_bucket = max(len(b['builder']['bucket']) for b in builds)
572 name_fmt = ('{bucket:>%d} ' % longest_bucket) + name_fmt
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000573
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000574 builds_by_status = {}
575 for b in builds:
576 builds_by_status.setdefault(b['status'], []).append({
577 'id': b['id'],
578 'name': name_fmt.format(
579 builder=b['builder']['builder'], bucket=b['builder']['bucket']),
580 })
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000581
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000582 sort_key = lambda b: (b['name'], b['id'])
583
584 def print_builds(title, builds, fmt=None, color=None):
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000585 """Pop matching builds from `builds` dict and print them."""
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000586 if not builds:
587 return
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000588
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000589 fmt = fmt or '{name} https://ci.chromium.org/b/{id}'
tandrii@chromium.org6cf98c82016-03-15 11:56:00 +0000590 if not options.color or color is None:
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000591 colorize = lambda x: x
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000592 else:
593 colorize = lambda x: '%s%s%s' % (color, x, Fore.RESET)
594
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000595 print(colorize(title))
596 for b in sorted(builds, key=sort_key):
597 print(' ', colorize(fmt.format(**b)))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000598
599 total = len(builds)
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000600 print_builds(
601 'Successes:', builds_by_status.pop('SUCCESS', []), color=Fore.GREEN)
602 print_builds(
603 'Infra Failures:', builds_by_status.pop('INFRA_FAILURE', []),
604 color=Fore.MAGENTA)
605 print_builds('Failures:', builds_by_status.pop('FAILURE', []), color=Fore.RED)
606 print_builds('Canceled:', builds_by_status.pop('CANCELED', []), fmt='{name}',
607 color=Fore.MAGENTA)
608 print_builds('Started:', builds_by_status.pop('STARTED', []))
609 print_builds(
610 'Scheduled:', builds_by_status.pop('SCHEDULED', []), fmt='{name} id={id}')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000611 # The last section is just in case buildbucket API changes OR there is a bug.
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000612 print_builds(
613 'Other:', sum(builds_by_status.values(), []), fmt='{name} id={id}')
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000614 print('Total: %d tryjobs' % total)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000615
616
Aiden Bennerc08566e2018-10-03 17:52:42 +0000617def _ComputeDiffLineRanges(files, upstream_commit):
618 """Gets the changed line ranges for each file since upstream_commit.
619
620 Parses a git diff on provided files and returns a dict that maps a file name
621 to an ordered list of range tuples in the form (start_line, count).
622 Ranges are in the same format as a git diff.
623 """
624 # If files is empty then diff_output will be a full diff.
625 if len(files) == 0:
626 return {}
627
Aiden Benner6c18a1a2018-11-23 20:18:23 +0000628 # Take the git diff and find the line ranges where there are changes.
Jamie Madill3671a6a2019-10-24 15:13:21 +0000629 diff_cmd = BuildGitDiffCmd('-U0', upstream_commit, files, allow_prefix=True)
Aiden Bennerc08566e2018-10-03 17:52:42 +0000630 diff_output = RunGit(diff_cmd)
631
632 pattern = r'(?:^diff --git a/(?:.*) b/(.*))|(?:^@@.*\+(.*) @@)'
633 # 2 capture groups
634 # 0 == fname of diff file
635 # 1 == 'diff_start,diff_count' or 'diff_start'
636 # will match each of
637 # diff --git a/foo.foo b/foo.py
638 # @@ -12,2 +14,3 @@
639 # @@ -12,2 +17 @@
640 # running re.findall on the above string with pattern will give
641 # [('foo.py', ''), ('', '14,3'), ('', '17')]
642
643 curr_file = None
644 line_diffs = {}
645 for match in re.findall(pattern, diff_output, flags=re.MULTILINE):
646 if match[0] != '':
647 # Will match the second filename in diff --git a/a.py b/b.py.
648 curr_file = match[0]
649 line_diffs[curr_file] = []
650 else:
651 # Matches +14,3
652 if ',' in match[1]:
653 diff_start, diff_count = match[1].split(',')
654 else:
655 # Single line changes are of the form +12 instead of +12,1.
656 diff_start = match[1]
657 diff_count = 1
658
659 diff_start = int(diff_start)
660 diff_count = int(diff_count)
661
662 # If diff_count == 0 this is a removal we can ignore.
663 line_diffs[curr_file].append((diff_start, diff_count))
664
665 return line_diffs
666
667
Aiden Benner99b0ccb2018-11-20 19:53:31 +0000668def _FindYapfConfigFile(fpath, yapf_config_cache, top_dir=None):
Aiden Bennerc08566e2018-10-03 17:52:42 +0000669 """Checks if a yapf file is in any parent directory of fpath until top_dir.
670
Aiden Benner99b0ccb2018-11-20 19:53:31 +0000671 Recursively checks parent directories to find yapf file and if no yapf file
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000672 is found returns None. Uses yapf_config_cache as a cache for previously found
673 configs.
Aiden Bennerc08566e2018-10-03 17:52:42 +0000674 """
Aiden Benner99b0ccb2018-11-20 19:53:31 +0000675 fpath = os.path.abspath(fpath)
Aiden Bennerc08566e2018-10-03 17:52:42 +0000676 # Return result if we've already computed it.
677 if fpath in yapf_config_cache:
678 return yapf_config_cache[fpath]
679
Aiden Benner99b0ccb2018-11-20 19:53:31 +0000680 parent_dir = os.path.dirname(fpath)
681 if os.path.isfile(fpath):
682 ret = _FindYapfConfigFile(parent_dir, yapf_config_cache, top_dir)
Aiden Bennerc08566e2018-10-03 17:52:42 +0000683 else:
Aiden Benner99b0ccb2018-11-20 19:53:31 +0000684 # Otherwise fpath is a directory
685 yapf_file = os.path.join(fpath, YAPF_CONFIG_FILENAME)
686 if os.path.isfile(yapf_file):
687 ret = yapf_file
688 elif fpath == top_dir or parent_dir == fpath:
689 # If we're at the top level directory, or if we're at root
690 # there is no provided style.
691 ret = None
692 else:
693 # Otherwise recurse on the current directory.
694 ret = _FindYapfConfigFile(parent_dir, yapf_config_cache, top_dir)
Aiden Bennerc08566e2018-10-03 17:52:42 +0000695 yapf_config_cache[fpath] = ret
696 return ret
697
698
Brian Sheedyb4307d52019-12-02 19:18:17 +0000699def _GetYapfIgnorePatterns(top_dir):
700 """Returns all patterns in the .yapfignore file.
Brian Sheedy59b06a82019-10-14 17:03:29 +0000701
702 yapf is supposed to handle the ignoring of files listed in .yapfignore itself,
703 but this functionality appears to break when explicitly passing files to
704 yapf for formatting. According to
705 https://github.com/google/yapf/blob/master/README.rst#excluding-files-from-formatting-yapfignore,
706 the .yapfignore file should be in the directory that yapf is invoked from,
707 which we assume to be the top level directory in this case.
708
709 Args:
710 top_dir: The top level directory for the repository being formatted.
711
712 Returns:
Brian Sheedyb4307d52019-12-02 19:18:17 +0000713 A set of all fnmatch patterns to be ignored.
Brian Sheedy59b06a82019-10-14 17:03:29 +0000714 """
715 yapfignore_file = os.path.join(top_dir, '.yapfignore')
Brian Sheedyb4307d52019-12-02 19:18:17 +0000716 ignore_patterns = set()
Brian Sheedy59b06a82019-10-14 17:03:29 +0000717 if not os.path.exists(yapfignore_file):
Brian Sheedyb4307d52019-12-02 19:18:17 +0000718 return ignore_patterns
Brian Sheedy59b06a82019-10-14 17:03:29 +0000719
Brian Sheedyb4307d52019-12-02 19:18:17 +0000720 with open(yapfignore_file) as f:
721 for line in f.readlines():
722 stripped_line = line.strip()
723 # Comments and blank lines should be ignored.
724 if stripped_line.startswith('#') or stripped_line == '':
725 continue
726 ignore_patterns.add(stripped_line)
727 return ignore_patterns
728
729
730def _FilterYapfIgnoredFiles(filepaths, patterns):
731 """Filters out any filepaths that match any of the given patterns.
732
733 Args:
734 filepaths: An iterable of strings containing filepaths to filter.
735 patterns: An iterable of strings containing fnmatch patterns to filter on.
736
737 Returns:
738 A list of strings containing all the elements of |filepaths| that did not
739 match any of the patterns in |patterns|.
740 """
741 # Not inlined so that tests can use the same implementation.
742 return [f for f in filepaths
743 if not any(fnmatch.fnmatch(f, p) for p in patterns)]
Brian Sheedy59b06a82019-10-14 17:03:29 +0000744
745
Aaron Gable13101a62018-02-09 13:20:41 -0800746def print_stats(args):
maruel@chromium.org49e3d802012-07-18 23:54:45 +0000747 """Prints statistics about the change to the user."""
748 # --no-ext-diff is broken in some versions of Git, so try to work around
749 # this by overriding the environment (but there is still a problem if the
750 # git config key "diff.external" is used).
thestig@chromium.org8b0553c2014-02-11 00:33:37 +0000751 env = GetNoGitPagerEnv()
maruel@chromium.org49e3d802012-07-18 23:54:45 +0000752 if 'GIT_EXTERNAL_DIFF' in env:
753 del env['GIT_EXTERNAL_DIFF']
iannucci@chromium.org79540052012-10-19 23:15:26 +0000754
maruel@chromium.org49e3d802012-07-18 23:54:45 +0000755 return subprocess2.call(
Aaron Gable13101a62018-02-09 13:20:41 -0800756 ['git', 'diff', '--no-ext-diff', '--stat', '-l100000', '-C50'] + args,
Edward Lemur0db01f02019-11-12 22:01:51 +0000757 env=env)
maruel@chromium.org49e3d802012-07-18 23:54:45 +0000758
759
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000760class BuildbucketResponseException(Exception):
761 pass
762
763
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000764class Settings(object):
765 def __init__(self):
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000766 self.cc = None
thestig@chromium.org7a54e812014-02-11 19:57:22 +0000767 self.root = None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000768 self.tree_status_url = None
769 self.viewvc_url = None
770 self.updated = False
ukai@chromium.orge8077812012-02-03 03:41:46 +0000771 self.is_gerrit = None
bauerb@chromium.org54b400c2016-01-14 10:08:25 +0000772 self.squash_gerrit_uploads = None
tandrii@chromium.org28253532016-04-14 13:46:56 +0000773 self.gerrit_skip_ensure_authenticated = None
jbroman@chromium.org615a2622013-05-03 13:20:14 +0000774 self.git_editor = None
Jamie Madilldc4d19e2019-10-24 21:50:02 +0000775 self.format_full_by_default = None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000776
Edward Lemur26964072020-02-19 19:18:51 +0000777 def _LazyUpdateIfNeeded(self):
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000778 """Updates the settings from a codereview.settings file, if available."""
Edward Lemur26964072020-02-19 19:18:51 +0000779 if self.updated:
780 return
pgervais@chromium.org87884cc2014-01-03 22:23:41 +0000781
Edward Lemur26964072020-02-19 19:18:51 +0000782 # The only value that actually changes the behavior is
783 # autoupdate = "false". Everything else means "true".
784 autoupdate = (
785 scm.GIT.GetConfig(self.GetRoot(), 'rietveld.autoupdate', '').lower())
786
787 cr_settings_file = FindCodereviewSettingsFile()
788 if autoupdate != 'false' and cr_settings_file:
789 LoadCodereviewSettingsFromFile(cr_settings_file)
790 cr_settings_file.close()
791
792 self.updated = True
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000793
thestig@chromium.org7a54e812014-02-11 19:57:22 +0000794 @staticmethod
795 def GetRelativeRoot():
796 return RunGit(['rev-parse', '--show-cdup']).strip()
thestig@chromium.org8b0553c2014-02-11 00:33:37 +0000797
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000798 def GetRoot(self):
thestig@chromium.org7a54e812014-02-11 19:57:22 +0000799 if self.root is None:
800 self.root = os.path.abspath(self.GetRelativeRoot())
801 return self.root
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000802
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000803 def GetTreeStatusUrl(self, error_ok=False):
804 if not self.tree_status_url:
Edward Lemur26964072020-02-19 19:18:51 +0000805 self.tree_status_url = self._GetConfig('rietveld.tree-status-url')
806 if self.tree_status_url is None and not error_ok:
807 DieWithError(
808 'You must configure your tree status URL by running '
809 '"git cl config".')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000810 return self.tree_status_url
811
812 def GetViewVCUrl(self):
813 if not self.viewvc_url:
Edward Lemur26964072020-02-19 19:18:51 +0000814 self.viewvc_url = self._GetConfig('rietveld.viewvc-url')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000815 return self.viewvc_url
816
rmistry@google.com90752582014-01-14 21:04:50 +0000817 def GetBugPrefix(self):
Edward Lemur26964072020-02-19 19:18:51 +0000818 return self._GetConfig('rietveld.bug-prefix')
rmistry@google.com78948ed2015-07-08 23:09:57 +0000819
rmistry@google.com5626a922015-02-26 14:03:30 +0000820 def GetRunPostUploadHook(self):
Edward Lemur61ea3072018-12-01 00:34:36 +0000821 run_post_upload_hook = self._GetConfig(
Edward Lemur26964072020-02-19 19:18:51 +0000822 'rietveld.run-post-upload-hook')
rmistry@google.com5626a922015-02-26 14:03:30 +0000823 return run_post_upload_hook == "True"
824
bauerb@chromium.orgae6df352011-04-06 17:40:39 +0000825 def GetDefaultCCList(self):
Edward Lemur26964072020-02-19 19:18:51 +0000826 return self._GetConfig('rietveld.cc')
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000827
ukai@chromium.orge8077812012-02-03 03:41:46 +0000828 def GetIsGerrit(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000829 """Returns True if this repo is associated with Gerrit."""
ukai@chromium.orge8077812012-02-03 03:41:46 +0000830 if self.is_gerrit is None:
Edward Lemur26964072020-02-19 19:18:51 +0000831 self.is_gerrit = self._GetConfig('gerrit.host').lower() == 'true'
ukai@chromium.orge8077812012-02-03 03:41:46 +0000832 return self.is_gerrit
833
bauerb@chromium.org54b400c2016-01-14 10:08:25 +0000834 def GetSquashGerritUploads(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000835 """Returns True if uploads to Gerrit should be squashed by default."""
bauerb@chromium.org54b400c2016-01-14 10:08:25 +0000836 if self.squash_gerrit_uploads is None:
tandriia60502f2016-06-20 02:01:53 -0700837 self.squash_gerrit_uploads = self.GetSquashGerritUploadsOverride()
Edward Lemur26964072020-02-19 19:18:51 +0000838 if self.squash_gerrit_uploads is None:
839 # Default is squash now (http://crbug.com/611892#c23).
840 self.squash_gerrit_uploads = self._GetConfig(
841 'gerrit.squash-uploads').lower() != 'false'
bauerb@chromium.org54b400c2016-01-14 10:08:25 +0000842 return self.squash_gerrit_uploads
843
tandriia60502f2016-06-20 02:01:53 -0700844 def GetSquashGerritUploadsOverride(self):
845 """Return True or False if codereview.settings should be overridden.
846
847 Returns None if no override has been defined.
848 """
849 # See also http://crbug.com/611892#c23
Edward Lemur26964072020-02-19 19:18:51 +0000850 result = self._GetConfig('gerrit.override-squash-uploads').lower()
tandriia60502f2016-06-20 02:01:53 -0700851 if result == 'true':
852 return True
853 if result == 'false':
854 return False
855 return None
856
tandrii@chromium.org28253532016-04-14 13:46:56 +0000857 def GetGerritSkipEnsureAuthenticated(self):
858 """Return True if EnsureAuthenticated should not be done for Gerrit
859 uploads."""
860 if self.gerrit_skip_ensure_authenticated is None:
Edward Lemur26964072020-02-19 19:18:51 +0000861 self.gerrit_skip_ensure_authenticated = self._GetConfig(
862 'gerrit.skip-ensure-authenticated').lower() == 'true'
tandrii@chromium.org28253532016-04-14 13:46:56 +0000863 return self.gerrit_skip_ensure_authenticated
864
jbroman@chromium.org615a2622013-05-03 13:20:14 +0000865 def GetGitEditor(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000866 """Returns the editor specified in the git config, or None if none is."""
jbroman@chromium.org615a2622013-05-03 13:20:14 +0000867 if self.git_editor is None:
Raul Tambre5a525872019-02-12 19:08:08 +0000868 # Git requires single quotes for paths with spaces. We need to replace
869 # them with double quotes for Windows to treat such paths as a single
870 # path.
Edward Lemur26964072020-02-19 19:18:51 +0000871 self.git_editor = self._GetConfig('core.editor').replace('\'', '"')
jbroman@chromium.org615a2622013-05-03 13:20:14 +0000872 return self.git_editor or None
873
thestig@chromium.org44202a22014-03-11 19:22:18 +0000874 def GetLintRegex(self):
Edward Lemur26964072020-02-19 19:18:51 +0000875 return self._GetConfig('rietveld.cpplint-regex', DEFAULT_LINT_REGEX)
thestig@chromium.org44202a22014-03-11 19:22:18 +0000876
877 def GetLintIgnoreRegex(self):
Edward Lemur26964072020-02-19 19:18:51 +0000878 return self._GetConfig(
879 'rietveld.cpplint-ignore-regex', DEFAULT_LINT_IGNORE_REGEX)
thestig@chromium.org44202a22014-03-11 19:22:18 +0000880
Jamie Madilldc4d19e2019-10-24 21:50:02 +0000881 def GetFormatFullByDefault(self):
882 if self.format_full_by_default is None:
883 result = (
884 RunGit(['config', '--bool', 'rietveld.format-full-by-default'],
885 error_ok=True).strip())
886 self.format_full_by_default = (result == 'true')
887 return self.format_full_by_default
888
Edward Lemur26964072020-02-19 19:18:51 +0000889 def _GetConfig(self, key, default=''):
890 self._LazyUpdateIfNeeded()
891 return scm.GIT.GetConfig(self.GetRoot(), key, default)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000892
893
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +0000894class _CQState(object):
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +0000895 """Enum for states of CL with respect to CQ."""
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +0000896 NONE = 'none'
897 DRY_RUN = 'dry_run'
898 COMMIT = 'commit'
899
900 ALL_STATES = [NONE, DRY_RUN, COMMIT]
901
902
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000903class _ParsedIssueNumberArgument(object):
Edward Lemurf38bc172019-09-03 21:02:13 +0000904 def __init__(self, issue=None, patchset=None, hostname=None):
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000905 self.issue = issue
906 self.patchset = patchset
907 self.hostname = hostname
908
909 @property
910 def valid(self):
911 return self.issue is not None
912
913
Edward Lemurf38bc172019-09-03 21:02:13 +0000914def ParseIssueNumberArgument(arg):
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000915 """Parses the issue argument and returns _ParsedIssueNumberArgument."""
916 fail_result = _ParsedIssueNumberArgument()
917
Edward Lemur678a6842019-10-03 22:25:05 +0000918 if isinstance(arg, int):
919 return _ParsedIssueNumberArgument(issue=arg)
920 if not isinstance(arg, basestring):
921 return fail_result
922
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000923 if arg.isdigit():
Edward Lemurf38bc172019-09-03 21:02:13 +0000924 return _ParsedIssueNumberArgument(issue=int(arg))
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000925 if not arg.startswith('http'):
926 return fail_result
Aaron Gableaee6c852017-06-26 12:49:01 -0700927
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000928 url = gclient_utils.UpgradeToHttps(arg)
929 try:
Edward Lemur79d4f992019-11-11 23:49:02 +0000930 parsed_url = urllib.parse.urlparse(url)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000931 except ValueError:
932 return fail_result
Andrii Shyshkalov28d840e2017-04-10 15:45:09 +0200933
Edward Lemur678a6842019-10-03 22:25:05 +0000934 # Gerrit's new UI is https://domain/c/project/+/<issue_number>[/[patchset]]
935 # But old GWT UI is https://domain/#/c/project/+/<issue_number>[/[patchset]]
936 # Short urls like https://domain/<issue_number> can be used, but don't allow
937 # specifying the patchset (you'd 404), but we allow that here.
938 if parsed_url.path == '/':
939 part = parsed_url.fragment
940 else:
941 part = parsed_url.path
942
943 match = re.match(
944 r'(/c(/.*/\+)?)?/(?P<issue>\d+)(/(?P<patchset>\d+)?/?)?$', part)
945 if not match:
946 return fail_result
947
948 issue = int(match.group('issue'))
949 patchset = match.group('patchset')
950 return _ParsedIssueNumberArgument(
951 issue=issue,
952 patchset=int(patchset) if patchset else None,
953 hostname=parsed_url.netloc)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000954
955
Andrii Shyshkalovb07575f2018-10-16 06:16:21 +0000956def _create_description_from_log(args):
957 """Pulls out the commit log to use as a base for the CL description."""
958 log_args = []
959 if len(args) == 1 and not args[0].endswith('.'):
960 log_args = [args[0] + '..']
961 elif len(args) == 1 and args[0].endswith('...'):
962 log_args = [args[0][:-1]]
963 elif len(args) == 2:
964 log_args = [args[0] + '..' + args[1]]
965 else:
966 log_args = args[:] # Hope for the best!
967 return RunGit(['log', '--pretty=format:%s\n\n%b'] + log_args)
968
969
Aaron Gablea45ee112016-11-22 15:14:38 -0800970class GerritChangeNotExists(Exception):
tandriic2405f52016-10-10 08:13:15 -0700971 def __init__(self, issue, url):
972 self.issue = issue
973 self.url = url
Aaron Gablea45ee112016-11-22 15:14:38 -0800974 super(GerritChangeNotExists, self).__init__()
tandriic2405f52016-10-10 08:13:15 -0700975
976 def __str__(self):
Aaron Gablea45ee112016-11-22 15:14:38 -0800977 return 'change %s at %s does not exist or you have no access to it' % (
tandriic2405f52016-10-10 08:13:15 -0700978 self.issue, self.url)
979
980
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +0100981_CommentSummary = collections.namedtuple(
Quinten Yearsley0e617c02019-02-20 00:37:03 +0000982 '_CommentSummary', ['date', 'message', 'sender', 'autogenerated',
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +0100983 # TODO(tandrii): these two aren't known in Gerrit.
984 'approval', 'disapproval'])
985
986
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000987class Changelist(object):
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +0000988 """Changelist works with one changelist in local branch.
989
tandrii@chromium.org8930b3d2016-04-13 14:47:02 +0000990 Notes:
991 * Not safe for concurrent multi-{thread,process} use.
992 * Caches values from current branch. Therefore, re-use after branch change
tandrii5d48c322016-08-18 16:19:37 -0700993 with great care.
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +0000994 """
995
Edward Lemur125d60a2019-09-13 18:25:41 +0000996 def __init__(self, branchref=None, issue=None, codereview_host=None):
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +0000997 """Create a new ChangeList instance.
998
Edward Lemurf38bc172019-09-03 21:02:13 +0000999 **kwargs will be passed directly to Gerrit implementation.
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001000 """
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001001 # Poke settings so we get the "configure your server" message if necessary.
maruel@chromium.org379d07a2011-11-30 14:58:10 +00001002 global settings
1003 if not settings:
1004 # Happens when git_cl.py is used as a utility library.
1005 settings = Settings()
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001006
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001007 self.branchref = branchref
1008 if self.branchref:
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00001009 assert branchref.startswith('refs/heads/')
Edward Lemur85153282020-02-14 22:06:29 +00001010 self.branch = scm.GIT.ShortBranchName(self.branchref)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001011 else:
1012 self.branch = None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001013 self.upstream_branch = None
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001014 self.lookedup_issue = False
1015 self.issue = issue or None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001016 self.description = None
Edward Lemur9aa1a962020-02-25 00:58:38 +00001017 self.local_description = None
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001018 self.lookedup_patchset = False
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001019 self.patchset = None
bauerb@chromium.orgae6df352011-04-06 17:40:39 +00001020 self.cc = None
Daniel Cheng7227d212017-11-17 08:12:37 -08001021 self.more_cc = []
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00001022 self._remote = None
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00001023 self._cached_remote_url = (False, None) # (is_cached, value)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00001024
Edward Lemur125d60a2019-09-13 18:25:41 +00001025 # Lazily cached values.
1026 self._gerrit_host = None # e.g. chromium-review.googlesource.com
1027 self._gerrit_server = None # e.g. https://chromium-review.googlesource.com
1028 # Map from change number (issue) to its detail cache.
1029 self._detail_cache = {}
1030
1031 if codereview_host is not None:
1032 assert not codereview_host.startswith('https://'), codereview_host
1033 self._gerrit_host = codereview_host
1034 self._gerrit_server = 'https://%s' % codereview_host
bauerb@chromium.orgae6df352011-04-06 17:40:39 +00001035
1036 def GetCCList(self):
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001037 """Returns the users cc'd on this CL.
bauerb@chromium.orgae6df352011-04-06 17:40:39 +00001038
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001039 The return value is a string suitable for passing to git cl with the --cc
1040 flag.
bauerb@chromium.orgae6df352011-04-06 17:40:39 +00001041 """
1042 if self.cc is None:
tyoshino@chromium.org99918ab2013-09-30 06:17:28 +00001043 base_cc = settings.GetDefaultCCList()
Daniel Cheng7227d212017-11-17 08:12:37 -08001044 more_cc = ','.join(self.more_cc)
bauerb@chromium.orgae6df352011-04-06 17:40:39 +00001045 self.cc = ','.join(filter(None, (base_cc, more_cc))) or ''
1046 return self.cc
1047
tyoshino@chromium.org99918ab2013-09-30 06:17:28 +00001048 def GetCCListWithoutDefault(self):
1049 """Return the users cc'd on this CL excluding default ones."""
1050 if self.cc is None:
Daniel Cheng7227d212017-11-17 08:12:37 -08001051 self.cc = ','.join(self.more_cc)
tyoshino@chromium.org99918ab2013-09-30 06:17:28 +00001052 return self.cc
1053
Daniel Cheng7227d212017-11-17 08:12:37 -08001054 def ExtendCC(self, more_cc):
1055 """Extends the list of users to cc on this CL based on the changed files."""
1056 self.more_cc.extend(more_cc)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001057
1058 def GetBranch(self):
1059 """Returns the short branch name, e.g. 'master'."""
1060 if not self.branch:
Edward Lemur85153282020-02-14 22:06:29 +00001061 branchref = scm.GIT.GetBranchRef(settings.GetRoot())
szager@chromium.orgd62c61f2014-10-20 22:33:21 +00001062 if not branchref:
1063 return None
1064 self.branchref = branchref
Edward Lemur85153282020-02-14 22:06:29 +00001065 self.branch = scm.GIT.ShortBranchName(self.branchref)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001066 return self.branch
1067
1068 def GetBranchRef(self):
1069 """Returns the full branch name, e.g. 'refs/heads/master'."""
1070 self.GetBranch() # Poke the lazy loader.
1071 return self.branchref
1072
tandrii@chromium.org534f67a2016-04-07 18:47:05 +00001073 def ClearBranch(self):
1074 """Clears cached branch data of this object."""
1075 self.branch = self.branchref = None
1076
Edward Lemur85153282020-02-14 22:06:29 +00001077 def _GitGetBranchConfigValue(self, key, default=None):
1078 return scm.GIT.GetBranchConfig(
1079 settings.GetRoot(), self.GetBranch(), key, default)
tandrii5d48c322016-08-18 16:19:37 -07001080
Edward Lemur85153282020-02-14 22:06:29 +00001081 def _GitSetBranchConfigValue(self, key, value):
1082 action = 'set %s to %r' % (key, value)
1083 if not value:
1084 action = 'unset %s' % key
1085 assert self.GetBranch(), 'a branch is needed to ' + action
1086 return scm.GIT.SetBranchConfig(
1087 settings.GetRoot(), self.GetBranch(), key, value)
tandrii5d48c322016-08-18 16:19:37 -07001088
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001089 @staticmethod
1090 def FetchUpstreamTuple(branch):
pgervais@chromium.orgd6617f32013-11-19 00:34:54 +00001091 """Returns a tuple containing remote and remote ref,
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001092 e.g. 'origin', 'refs/heads/master'
1093 """
Edward Lemur15a9b8c2020-02-13 00:52:30 +00001094 remote, upstream_branch = scm.GIT.FetchUpstreamTuple(
1095 settings.GetRoot(), branch)
1096 if not remote or not upstream_branch:
1097 DieWithError(
1098 'Unable to determine default branch to diff against.\n'
1099 'Either pass complete "git diff"-style arguments, like\n'
1100 ' git cl upload origin/master\n'
1101 'or verify this branch is set up to track another \n'
1102 '(via the --track argument to "git checkout -b ...").')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001103
1104 return remote, upstream_branch
1105
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00001106 def GetCommonAncestorWithUpstream(self):
pgervais@chromium.org8ba38ff2015-06-11 21:41:25 +00001107 upstream_branch = self.GetUpstreamBranch()
1108 if not BranchExists(upstream_branch):
1109 DieWithError('The upstream for the current branch (%s) does not exist '
1110 'anymore.\nPlease fix it and try again.' % self.GetBranch())
iannucci@chromium.org9e849272014-04-04 00:31:55 +00001111 return git_common.get_or_create_merge_base(self.GetBranch(),
pgervais@chromium.org8ba38ff2015-06-11 21:41:25 +00001112 upstream_branch)
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00001113
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001114 def GetUpstreamBranch(self):
1115 if self.upstream_branch is None:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001116 remote, upstream_branch = self.FetchUpstreamTuple(self.GetBranch())
Raul Tambrefe1dbe12019-05-02 04:43:57 +00001117 if remote != '.':
mmoss@chromium.orge7585452014-08-24 01:41:11 +00001118 upstream_branch = upstream_branch.replace('refs/heads/',
1119 'refs/remotes/%s/' % remote)
1120 upstream_branch = upstream_branch.replace('refs/branch-heads/',
1121 'refs/remotes/branch-heads/')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001122 self.upstream_branch = upstream_branch
1123 return self.upstream_branch
1124
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001125 def GetRemoteBranch(self):
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001126 if not self._remote:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001127 remote, branch = None, self.GetBranch()
1128 seen_branches = set()
1129 while branch not in seen_branches:
1130 seen_branches.add(branch)
1131 remote, branch = self.FetchUpstreamTuple(branch)
Edward Lemur85153282020-02-14 22:06:29 +00001132 branch = scm.GIT.ShortBranchName(branch)
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001133 if remote != '.' or branch.startswith('refs/remotes'):
1134 break
1135 else:
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001136 remotes = RunGit(['remote'], error_ok=True).split()
1137 if len(remotes) == 1:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001138 remote, = remotes
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001139 elif 'origin' in remotes:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001140 remote = 'origin'
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08001141 logging.warn('Could not determine which remote this change is '
1142 'associated with, so defaulting to "%s".' % self._remote)
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001143 else:
1144 logging.warn('Could not determine which remote this change is '
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08001145 'associated with.')
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001146 branch = 'HEAD'
1147 if branch.startswith('refs/remotes'):
1148 self._remote = (remote, branch)
mmoss@chromium.orge7585452014-08-24 01:41:11 +00001149 elif branch.startswith('refs/branch-heads/'):
1150 self._remote = (remote, branch.replace('refs/', 'refs/remotes/'))
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001151 else:
1152 self._remote = (remote, 'refs/remotes/%s/%s' % (remote, branch))
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001153 return self._remote
1154
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001155 def GitSanityChecks(self, upstream_git_obj):
1156 """Checks git repo status and ensures diff is from local commits."""
1157
sbc@chromium.org79706062015-01-14 21:18:12 +00001158 if upstream_git_obj is None:
1159 if self.GetBranch() is None:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001160 print('ERROR: Unable to determine current branch (detached HEAD?)',
vapiera7fbd5a2016-06-16 09:17:49 -07001161 file=sys.stderr)
sbc@chromium.org79706062015-01-14 21:18:12 +00001162 else:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001163 print('ERROR: No upstream branch.', file=sys.stderr)
sbc@chromium.org79706062015-01-14 21:18:12 +00001164 return False
1165
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001166 # Verify the commit we're diffing against is in our current branch.
1167 upstream_sha = RunGit(['rev-parse', '--verify', upstream_git_obj]).strip()
1168 common_ancestor = RunGit(['merge-base', upstream_sha, 'HEAD']).strip()
1169 if upstream_sha != common_ancestor:
vapiera7fbd5a2016-06-16 09:17:49 -07001170 print('ERROR: %s is not in the current branch. You may need to rebase '
1171 'your tracking branch' % upstream_sha, file=sys.stderr)
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001172 return False
1173
1174 # List the commits inside the diff, and verify they are all local.
1175 commits_in_diff = RunGit(
1176 ['rev-list', '^%s' % upstream_sha, 'HEAD']).splitlines()
1177 code, remote_branch = RunGitWithCode(['config', 'gitcl.remotebranch'])
1178 remote_branch = remote_branch.strip()
1179 if code != 0:
1180 _, remote_branch = self.GetRemoteBranch()
1181
1182 commits_in_remote = RunGit(
1183 ['rev-list', '^%s' % upstream_sha, remote_branch]).splitlines()
1184
1185 common_commits = set(commits_in_diff) & set(commits_in_remote)
1186 if common_commits:
vapiera7fbd5a2016-06-16 09:17:49 -07001187 print('ERROR: Your diff contains %d commits already in %s.\n'
1188 'Run "git log --oneline %s..HEAD" to get a list of commits in '
1189 'the diff. If you are using a custom git flow, you can override'
1190 ' the reference used for this check with "git config '
1191 'gitcl.remotebranch <git-ref>".' % (
1192 len(common_commits), remote_branch, upstream_git_obj),
1193 file=sys.stderr)
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001194 return False
1195 return True
1196
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00001197 def GetGitBaseUrlFromConfig(self):
sheyang@chromium.orga656e702014-05-15 20:43:05 +00001198 """Return the configured base URL from branch.<branchname>.baseurl.
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00001199
1200 Returns None if it is not set.
1201 """
tandrii5d48c322016-08-18 16:19:37 -07001202 return self._GitGetBranchConfigValue('base-url')
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001203
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001204 def GetRemoteUrl(self):
1205 """Return the configured remote URL, e.g. 'git://example.org/foo.git/'.
1206
1207 Returns None if there is no remote.
1208 """
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00001209 is_cached, value = self._cached_remote_url
1210 if is_cached:
1211 return value
1212
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001213 remote, _ = self.GetRemoteBranch()
Edward Lemur26964072020-02-19 19:18:51 +00001214 url = scm.GIT.GetConfig(settings.GetRoot(), 'remote.%s.url' % remote, '')
dyen@chromium.org2a13d4f2014-06-13 00:06:37 +00001215
Edward Lemur298f2cf2019-02-22 21:40:39 +00001216 # Check if the remote url can be parsed as an URL.
Edward Lemur79d4f992019-11-11 23:49:02 +00001217 host = urllib.parse.urlparse(url).netloc
Edward Lemur298f2cf2019-02-22 21:40:39 +00001218 if host:
1219 self._cached_remote_url = (True, url)
1220 return url
1221
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001222 # If it cannot be parsed as an url, assume it is a local directory,
1223 # probably a git cache.
Edward Lemur298f2cf2019-02-22 21:40:39 +00001224 logging.warning('"%s" doesn\'t appear to point to a git host. '
1225 'Interpreting it as a local directory.', url)
1226 if not os.path.isdir(url):
1227 logging.error(
Josip906bfde2020-01-31 22:38:49 +00001228 'Remote "%(remote)s" for branch "%(branch)s" points to "%(url)s", '
1229 'but it doesn\'t exist.',
1230 {'remote': remote, 'branch': self.GetBranch(), 'url': url})
Edward Lemur298f2cf2019-02-22 21:40:39 +00001231 return None
1232
1233 cache_path = url
Edward Lemur26964072020-02-19 19:18:51 +00001234 url = scm.GIT.GetConfig(url, 'remote.%s.url' % remote, '')
Edward Lemur298f2cf2019-02-22 21:40:39 +00001235
Edward Lemur79d4f992019-11-11 23:49:02 +00001236 host = urllib.parse.urlparse(url).netloc
Edward Lemur298f2cf2019-02-22 21:40:39 +00001237 if not host:
1238 logging.error(
1239 'Remote "%(remote)s" for branch "%(branch)s" points to '
1240 '"%(cache_path)s", but it is misconfigured.\n'
1241 '"%(cache_path)s" must be a git repo and must have a remote named '
1242 '"%(remote)s" pointing to the git host.', {
1243 'remote': remote,
1244 'cache_path': cache_path,
1245 'branch': self.GetBranch()})
1246 return None
1247
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00001248 self._cached_remote_url = (True, url)
dyen@chromium.org2a13d4f2014-06-13 00:06:37 +00001249 return url
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001250
tandrii@chromium.org87985d22016-03-24 17:33:33 +00001251 def GetIssue(self):
maruel@chromium.org52424302012-08-29 15:14:30 +00001252 """Returns the issue number as a int or None if not set."""
tandrii@chromium.org87985d22016-03-24 17:33:33 +00001253 if self.issue is None and not self.lookedup_issue:
Edward Lemur85153282020-02-14 22:06:29 +00001254 self.issue = self._GitGetBranchConfigValue(self.IssueConfigKey())
1255 if self.issue is not None:
1256 self.issue = int(self.issue)
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001257 self.lookedup_issue = True
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001258 return self.issue
1259
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001260 def GetIssueURL(self):
1261 """Get the URL for a particular issue."""
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001262 issue = self.GetIssue()
1263 if not issue:
dbeam@chromium.org015fd3d2013-06-18 19:02:50 +00001264 return None
Edward Lemur125d60a2019-09-13 18:25:41 +00001265 return '%s/%s' % (self.GetCodereviewServer(), issue)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001266
Edward Lemur7f6dec02020-02-06 20:23:58 +00001267 def GetLocalDescription(self, upstream_branch):
1268 """Return the log messages of all commits up to the branch point."""
Edward Lemur9aa1a962020-02-25 00:58:38 +00001269 if self.local_description is None:
1270 args = ['log', '--pretty=format:%s%n%n%b', '%s...' % (upstream_branch)]
1271 self.local_description = RunGitWithCode(args)[1].strip()
1272 return self.local_description
Edward Lemur7f6dec02020-02-06 20:23:58 +00001273
Edward Lemur6c6827c2020-02-06 21:15:18 +00001274 def FetchDescription(self, pretty=False):
1275 assert self.GetIssue(), 'issue is required to query Gerrit'
1276
Edward Lemur9aa1a962020-02-25 00:58:38 +00001277 if self.description is None:
Edward Lemur6c6827c2020-02-06 21:15:18 +00001278 data = self._GetChangeDetail(['CURRENT_REVISION', 'CURRENT_COMMIT'])
1279 current_rev = data['current_revision']
1280 self.description = data['revisions'][current_rev]['commit']['message']
Edward Lemur6c6827c2020-02-06 21:15:18 +00001281
1282 if not pretty:
1283 return self.description
1284
1285 # Set width to 72 columns + 2 space indent.
1286 wrapper = textwrap.TextWrapper(width=74, replace_whitespace=True)
1287 wrapper.initial_indent = wrapper.subsequent_indent = ' '
1288 lines = self.description.splitlines()
1289 return '\n'.join([wrapper.fill(line) for line in lines])
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001290
1291 def GetPatchset(self):
maruel@chromium.org52424302012-08-29 15:14:30 +00001292 """Returns the patchset number as a int or None if not set."""
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001293 if self.patchset is None and not self.lookedup_patchset:
Edward Lemur85153282020-02-14 22:06:29 +00001294 self.patchset = self._GitGetBranchConfigValue(self.PatchsetConfigKey())
1295 if self.patchset is not None:
1296 self.patchset = int(self.patchset)
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001297 self.lookedup_patchset = True
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001298 return self.patchset
1299
Edward Lemur9aa1a962020-02-25 00:58:38 +00001300 def GetAuthor(self):
1301 return scm.GIT.GetConfig(settings.GetRoot(), 'user.email')
1302
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001303 def SetPatchset(self, patchset):
tandrii5d48c322016-08-18 16:19:37 -07001304 """Set this branch's patchset. If patchset=0, clears the patchset."""
1305 assert self.GetBranch()
1306 if not patchset:
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001307 self.patchset = None
tandrii5d48c322016-08-18 16:19:37 -07001308 else:
1309 self.patchset = int(patchset)
1310 self._GitSetBranchConfigValue(
Edward Lemur85153282020-02-14 22:06:29 +00001311 self.PatchsetConfigKey(), str(self.patchset))
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001312
tandrii@chromium.orga342c922016-03-16 07:08:25 +00001313 def SetIssue(self, issue=None):
tandrii5d48c322016-08-18 16:19:37 -07001314 """Set this branch's issue. If issue isn't given, clears the issue."""
1315 assert self.GetBranch()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001316 if issue:
tandrii5d48c322016-08-18 16:19:37 -07001317 issue = int(issue)
1318 self._GitSetBranchConfigValue(
Edward Lemur85153282020-02-14 22:06:29 +00001319 self.IssueConfigKey(), str(issue))
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001320 self.issue = issue
Edward Lemur125d60a2019-09-13 18:25:41 +00001321 codereview_server = self.GetCodereviewServer()
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001322 if codereview_server:
tandrii5d48c322016-08-18 16:19:37 -07001323 self._GitSetBranchConfigValue(
Edward Lemur125d60a2019-09-13 18:25:41 +00001324 self.CodereviewServerConfigKey(),
tandrii5d48c322016-08-18 16:19:37 -07001325 codereview_server)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001326 else:
tandrii5d48c322016-08-18 16:19:37 -07001327 # Reset all of these just to be clean.
1328 reset_suffixes = [
1329 'last-upload-hash',
Edward Lemur125d60a2019-09-13 18:25:41 +00001330 self.IssueConfigKey(),
1331 self.PatchsetConfigKey(),
1332 self.CodereviewServerConfigKey(),
tandrii5d48c322016-08-18 16:19:37 -07001333 ] + self._PostUnsetIssueProperties()
1334 for prop in reset_suffixes:
Edward Lemur85153282020-02-14 22:06:29 +00001335 try:
1336 self._GitSetBranchConfigValue(prop, None)
1337 except subprocess2.CalledProcessError:
1338 pass
Aaron Gableca01e2c2017-07-19 11:16:02 -07001339 msg = RunGit(['log', '-1', '--format=%B']).strip()
1340 if msg and git_footers.get_footer_change_id(msg):
1341 print('WARNING: The change patched into this branch has a Change-Id. '
1342 'Removing it.')
1343 RunGit(['commit', '--amend', '-m',
1344 git_footers.remove_footer(msg, 'Change-Id')])
Edward Lemurf38bc172019-09-03 21:02:13 +00001345 self.lookedup_issue = True
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001346 self.issue = None
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00001347 self.patchset = None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001348
Edward Lemur7f6dec02020-02-06 20:23:58 +00001349 def GetChange(self, upstream_branch):
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001350 if not self.GitSanityChecks(upstream_branch):
1351 DieWithError('\nGit sanity check failure')
1352
Edward Lemur7f6dec02020-02-06 20:23:58 +00001353 root = settings.GetRoot()
bauerb@chromium.org6fb99c62011-04-18 15:57:28 +00001354 # We use the sha1 of HEAD as a name of this change.
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00001355 name = RunGitWithCode(['rev-parse', 'HEAD'])[1].strip()
maruel@chromium.org2b38e9c2011-10-19 00:04:35 +00001356 try:
Edward Lemur7f6dec02020-02-06 20:23:58 +00001357 files = scm.GIT.CaptureStatus(root, upstream_branch)
maruel@chromium.org2b38e9c2011-10-19 00:04:35 +00001358 except subprocess2.CalledProcessError:
1359 DieWithError(
pgervais@chromium.orgd6617f32013-11-19 00:34:54 +00001360 ('\nFailed to diff against upstream branch %s\n\n'
maruel@chromium.org2b38e9c2011-10-19 00:04:35 +00001361 'This branch probably doesn\'t exist anymore. To reset the\n'
1362 'tracking branch, please run\n'
stip7a3dd352016-09-22 17:32:28 -07001363 ' git branch --set-upstream-to origin/master %s\n'
1364 'or replace origin/master with the relevant branch') %
maruel@chromium.org2b38e9c2011-10-19 00:04:35 +00001365 (upstream_branch, self.GetBranch()))
bauerb@chromium.org6fb99c62011-04-18 15:57:28 +00001366
maruel@chromium.org52424302012-08-29 15:14:30 +00001367 issue = self.GetIssue()
1368 patchset = self.GetPatchset()
Edward Lemur7f6dec02020-02-06 20:23:58 +00001369 if issue:
Edward Lemur6c6827c2020-02-06 21:15:18 +00001370 description = self.FetchDescription()
bauerb@chromium.org6fb99c62011-04-18 15:57:28 +00001371 else:
1372 # If the change was never uploaded, use the log messages of all commits
1373 # up to the branch point, as git cl upload will prefill the description
1374 # with these log messages.
Edward Lemur7f6dec02020-02-06 20:23:58 +00001375 description = self.GetLocalDescription(upstream_branch)
maruel@chromium.org03b3bdc2011-06-14 13:04:12 +00001376
Edward Lemur9aa1a962020-02-25 00:58:38 +00001377 author = self.GetAuthor()
asvitkine@chromium.org15169952011-09-27 14:30:53 +00001378 return presubmit_support.GitChange(
bauerb@chromium.org6fb99c62011-04-18 15:57:28 +00001379 name,
1380 description,
Edward Lemur7f6dec02020-02-06 20:23:58 +00001381 root,
bauerb@chromium.org6fb99c62011-04-18 15:57:28 +00001382 files,
1383 issue,
1384 patchset,
agable@chromium.orgea84ef12014-04-30 19:55:12 +00001385 author,
1386 upstream=upstream_branch)
bauerb@chromium.org6fb99c62011-04-18 15:57:28 +00001387
dsansomee2d6fd92016-09-08 00:10:47 -07001388 def UpdateDescription(self, description, force=False):
Edward Lemur6c6827c2020-02-06 21:15:18 +00001389 assert self.GetIssue(), 'issue is required to update description'
1390
1391 if gerrit_util.HasPendingChangeEdit(
1392 self._GetGerritHost(), self._GerritChangeIdentifier()):
1393 if not force:
1394 confirm_or_exit(
1395 'The description cannot be modified while the issue has a pending '
1396 'unpublished edit. Either publish the edit in the Gerrit web UI '
1397 'or delete it.\n\n', action='delete the unpublished edit')
1398
1399 gerrit_util.DeletePendingChangeEdit(
1400 self._GetGerritHost(), self._GerritChangeIdentifier())
1401 gerrit_util.SetCommitMessage(
1402 self._GetGerritHost(), self._GerritChangeIdentifier(),
1403 description, notify='NONE')
1404
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001405 self.description = description
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001406
Edward Lemur75526302020-02-27 22:31:05 +00001407 def _GetCommonPresubmitArgs(self, verbose, upstream):
Edward Lemur227d5102020-02-25 23:45:35 +00001408 args = [
Edward Lemur227d5102020-02-25 23:45:35 +00001409 '--author', self.GetAuthor(),
1410 '--root', settings.GetRoot(),
1411 '--upstream', upstream,
1412 ]
1413
1414 args.extend(['--verbose'] * verbose)
1415
1416 issue = self.GetIssue()
1417 patchset = self.GetPatchset()
1418 gerrit_url = self.GetCodereviewServer()
1419 if issue:
1420 args.extend(['--issue', str(issue)])
1421 if patchset:
1422 args.extend(['--patchset', str(patchset)])
1423 if gerrit_url:
1424 args.extend(['--gerrit_url', gerrit_url])
1425
Edward Lemur75526302020-02-27 22:31:05 +00001426 return args
1427
1428 def RunHook(
1429 self, committing, may_prompt, verbose, parallel, upstream, description,
1430 all_files):
1431 """Calls sys.exit() if the hook fails; returns a HookResults otherwise."""
1432 args = self._GetCommonPresubmitArgs(verbose, upstream)
1433 args.append('--commit' if committing else '--upload')
Edward Lemur227d5102020-02-25 23:45:35 +00001434 if may_prompt:
1435 args.append('--may_prompt')
1436 if parallel:
1437 args.append('--parallel')
1438 if all_files:
1439 args.append('--all_files')
1440
1441 with gclient_utils.temporary_file() as description_file:
1442 with gclient_utils.temporary_file() as json_output:
Edward Lemur1a83da12020-03-04 21:18:36 +00001443
1444 gclient_utils.FileWrite(description_file, description)
Edward Lemur227d5102020-02-25 23:45:35 +00001445 args.extend(['--json_output', json_output])
1446 args.extend(['--description_file', description_file])
1447
1448 start = time_time()
1449 p = subprocess2.Popen(['vpython', PRESUBMIT_SUPPORT] + args)
1450 exit_code = p.wait()
1451 metrics.collector.add_repeated('sub_commands', {
1452 'command': 'presubmit',
1453 'execution_time': time_time() - start,
1454 'exit_code': exit_code,
1455 })
1456
1457 if exit_code:
1458 sys.exit(exit_code)
1459
1460 json_results = gclient_utils.FileRead(json_output)
1461 return json.loads(json_results)
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001462
Edward Lemur75526302020-02-27 22:31:05 +00001463 def RunPostUploadHook(self, verbose, upstream, description):
1464 args = self._GetCommonPresubmitArgs(verbose, upstream)
1465 args.append('--post_upload')
1466
1467 with gclient_utils.temporary_file() as description_file:
Edward Lemur1a83da12020-03-04 21:18:36 +00001468 gclient_utils.FileWrite(description_file, description)
Edward Lemur75526302020-02-27 22:31:05 +00001469 args.extend(['--description_file', description_file])
1470 p = subprocess2.Popen(['vpython', PRESUBMIT_SUPPORT] + args)
1471 p.wait()
1472
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001473 def CMDUpload(self, options, git_diff_args, orig_args):
1474 """Uploads a change to codereview."""
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001475 custom_cl_base = None
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001476 if git_diff_args:
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001477 custom_cl_base = base_branch = git_diff_args[0]
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001478 else:
1479 if self.GetBranch() is None:
1480 DieWithError('Can\'t upload from detached HEAD state. Get on a branch!')
1481
1482 # Default to diffing against common ancestor of upstream branch
1483 base_branch = self.GetCommonAncestorWithUpstream()
1484 git_diff_args = [base_branch, 'HEAD']
1485
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001486 # Fast best-effort checks to abort before running potentially expensive
1487 # hooks if uploading is likely to fail anyway. Passing these checks does
1488 # not guarantee that uploading will not fail.
Edward Lemur125d60a2019-09-13 18:25:41 +00001489 self.EnsureAuthenticated(force=options.force)
1490 self.EnsureCanUploadPatchset(force=options.force)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001491
1492 # Apply watchlists on upload.
Edward Lemur7f6dec02020-02-06 20:23:58 +00001493 change = self.GetChange(base_branch)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001494 watchlist = watchlists.Watchlists(change.RepositoryRoot())
1495 files = [f.LocalPath() for f in change.AffectedFiles()]
1496 if not options.bypass_watchlists:
Daniel Cheng7227d212017-11-17 08:12:37 -08001497 self.ExtendCC(watchlist.GetWatchersForPaths(files))
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001498
Edward Lemur1a83da12020-03-04 21:18:36 +00001499 if self.GetIssue():
1500 description = self.FetchDescription()
1501 else:
1502 description = self.GetLocalDescription(base_branch)
Edward Lemur75526302020-02-27 22:31:05 +00001503 if options.reviewers or options.tbrs or options.add_owners_to:
1504 # Set the reviewer list now so that presubmit checks can access it.
1505 change_description = ChangeDescription(description)
1506 change_description.update_reviewers(options.reviewers,
1507 options.tbrs,
1508 options.add_owners_to,
1509 change)
1510 description = change_description.description
1511
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001512 if not options.bypass_hooks:
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001513 hook_results = self.RunHook(committing=False,
Edward Lesmes8e282792018-04-03 18:50:29 -04001514 may_prompt=not options.force,
1515 verbose=options.verbose,
Edward Lemur227d5102020-02-25 23:45:35 +00001516 parallel=options.parallel,
1517 upstream=base_branch,
1518 description=description,
1519 all_files=False)
1520 self.ExtendCC(hook_results['more_cc'])
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001521
Aaron Gable13101a62018-02-09 13:20:41 -08001522 print_stats(git_diff_args)
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001523 ret = self.CMDUploadChange(options, git_diff_args, custom_cl_base, change)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001524 if not ret:
Edward Lemur85153282020-02-14 22:06:29 +00001525 self._GitSetBranchConfigValue(
1526 'last-upload-hash', RunGit(['rev-parse', 'HEAD']).strip())
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001527 # Run post upload hooks, if specified.
1528 if settings.GetRunPostUploadHook():
Edward Lemur75526302020-02-27 22:31:05 +00001529 self.RunPostUploadHook(options.verbose, base_branch, description)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001530
1531 # Upload all dependencies if specified.
1532 if options.dependencies:
vapiera7fbd5a2016-06-16 09:17:49 -07001533 print()
1534 print('--dependencies has been specified.')
1535 print('All dependent local branches will be re-uploaded.')
1536 print()
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001537 # Remove the dependencies flag from args so that we do not end up in a
1538 # loop.
1539 orig_args.remove('--dependencies')
1540 ret = upload_branch_deps(self, orig_args)
1541 return ret
1542
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001543 def SetCQState(self, new_state):
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07001544 """Updates the CQ state for the latest patchset.
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001545
1546 Issue must have been already uploaded and known.
1547 """
1548 assert new_state in _CQState.ALL_STATES
1549 assert self.GetIssue()
qyearsley1fdfcb62016-10-24 13:22:03 -07001550 try:
Edward Lemur125d60a2019-09-13 18:25:41 +00001551 vote_map = {
1552 _CQState.NONE: 0,
1553 _CQState.DRY_RUN: 1,
1554 _CQState.COMMIT: 2,
1555 }
1556 labels = {'Commit-Queue': vote_map[new_state]}
1557 notify = False if new_state == _CQState.DRY_RUN else None
1558 gerrit_util.SetReview(
1559 self._GetGerritHost(), self._GerritChangeIdentifier(),
1560 labels=labels, notify=notify)
qyearsley1fdfcb62016-10-24 13:22:03 -07001561 return 0
1562 except KeyboardInterrupt:
1563 raise
1564 except:
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07001565 print('WARNING: Failed to %s.\n'
qyearsley1fdfcb62016-10-24 13:22:03 -07001566 'Either:\n'
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07001567 ' * Your project has no CQ,\n'
1568 ' * You don\'t have permission to change the CQ state,\n'
1569 ' * There\'s a bug in this code (see stack trace below).\n'
1570 'Consider specifying which bots to trigger manually or asking your '
1571 'project owners for permissions or contacting Chrome Infra at:\n'
1572 'https://www.chromium.org/infra\n\n' %
1573 ('cancel CQ' if new_state == _CQState.NONE else 'trigger CQ'))
qyearsley1fdfcb62016-10-24 13:22:03 -07001574 # Still raise exception so that stack trace is printed.
1575 raise
1576
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001577 def _GetGerritHost(self):
1578 # Lazy load of configs.
1579 self.GetCodereviewServer()
tandriie32e3ea2016-06-22 02:52:48 -07001580 if self._gerrit_host and '.' not in self._gerrit_host:
1581 # Abbreviated domain like "chromium" instead of chromium.googlesource.com.
1582 # This happens for internal stuff http://crbug.com/614312.
Edward Lemur79d4f992019-11-11 23:49:02 +00001583 parsed = urllib.parse.urlparse(self.GetRemoteUrl())
tandriie32e3ea2016-06-22 02:52:48 -07001584 if parsed.scheme == 'sso':
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001585 print('WARNING: using non-https URLs for remote is likely broken\n'
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001586 ' Your current remote is: %s' % self.GetRemoteUrl())
tandriie32e3ea2016-06-22 02:52:48 -07001587 self._gerrit_host = '%s.googlesource.com' % self._gerrit_host
1588 self._gerrit_server = 'https://%s' % self._gerrit_host
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001589 return self._gerrit_host
1590
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001591 def _GetGitHost(self):
1592 """Returns git host to be used when uploading change to Gerrit."""
Edward Lemur298f2cf2019-02-22 21:40:39 +00001593 remote_url = self.GetRemoteUrl()
1594 if not remote_url:
1595 return None
Edward Lemur79d4f992019-11-11 23:49:02 +00001596 return urllib.parse.urlparse(remote_url).netloc
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001597
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001598 def GetCodereviewServer(self):
1599 if not self._gerrit_server:
1600 # If we're on a branch then get the server potentially associated
1601 # with that branch.
Edward Lemur85153282020-02-14 22:06:29 +00001602 if self.GetIssue() and self.GetBranch():
tandrii5d48c322016-08-18 16:19:37 -07001603 self._gerrit_server = self._GitGetBranchConfigValue(
1604 self.CodereviewServerConfigKey())
1605 if self._gerrit_server:
Edward Lemur79d4f992019-11-11 23:49:02 +00001606 self._gerrit_host = urllib.parse.urlparse(self._gerrit_server).netloc
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001607 if not self._gerrit_server:
1608 # We assume repo to be hosted on Gerrit, and hence Gerrit server
1609 # has "-review" suffix for lowest level subdomain.
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001610 parts = self._GetGitHost().split('.')
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001611 parts[0] = parts[0] + '-review'
1612 self._gerrit_host = '.'.join(parts)
1613 self._gerrit_server = 'https://%s' % self._gerrit_host
1614 return self._gerrit_server
1615
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00001616 def _GetGerritProject(self):
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001617 """Returns Gerrit project name based on remote git URL."""
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00001618 remote_url = self.GetRemoteUrl()
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001619 if remote_url is None:
Josip906bfde2020-01-31 22:38:49 +00001620 logging.warning('can\'t detect Gerrit project.')
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00001621 return None
Edward Lemur79d4f992019-11-11 23:49:02 +00001622 project = urllib.parse.urlparse(remote_url).path.strip('/')
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001623 if project.endswith('.git'):
1624 project = project[:-len('.git')]
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00001625 # *.googlesource.com hosts ensure that Git/Gerrit projects don't start with
1626 # 'a/' prefix, because 'a/' prefix is used to force authentication in
1627 # gitiles/git-over-https protocol. E.g.,
1628 # https://chromium.googlesource.com/a/v8/v8 refers to the same repo/project
1629 # as
1630 # https://chromium.googlesource.com/v8/v8
1631 if project.startswith('a/'):
1632 project = project[len('a/'):]
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001633 return project
1634
Andrii Shyshkalovd06cc782018-08-23 17:24:19 +00001635 def _GerritChangeIdentifier(self):
1636 """Handy method for gerrit_util.ChangeIdentifier for a given CL.
1637
1638 Not to be confused by value of "Change-Id:" footer.
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00001639 If Gerrit project can be determined, this will speed up Gerrit HTTP API RPC.
Andrii Shyshkalovd06cc782018-08-23 17:24:19 +00001640 """
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00001641 project = self._GetGerritProject()
1642 if project:
1643 return gerrit_util.ChangeIdentifier(project, self.GetIssue())
1644 # Fall back on still unique, but less efficient change number.
1645 return str(self.GetIssue())
Andrii Shyshkalovd06cc782018-08-23 17:24:19 +00001646
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001647 @classmethod
tandrii5d48c322016-08-18 16:19:37 -07001648 def IssueConfigKey(cls):
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001649 return 'gerritissue'
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001650
tandrii5d48c322016-08-18 16:19:37 -07001651 @classmethod
1652 def PatchsetConfigKey(cls):
1653 return 'gerritpatchset'
1654
1655 @classmethod
1656 def CodereviewServerConfigKey(cls):
1657 return 'gerritserver'
1658
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01001659 def EnsureAuthenticated(self, force, refresh=None):
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001660 """Best effort check that user is authenticated with Gerrit server."""
tandrii@chromium.org28253532016-04-14 13:46:56 +00001661 if settings.GetGerritSkipEnsureAuthenticated():
1662 # For projects with unusual authentication schemes.
1663 # See http://crbug.com/603378.
1664 return
Vadim Shtayurab250ec12018-10-04 00:21:08 +00001665
1666 # Check presence of cookies only if using cookies-based auth method.
1667 cookie_auth = gerrit_util.Authenticator.get()
1668 if not isinstance(cookie_auth, gerrit_util.CookiesAuthenticator):
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001669 return
Vadim Shtayurab250ec12018-10-04 00:21:08 +00001670
Florian Mayerae510e82020-01-30 21:04:48 +00001671 remote_url = self.GetRemoteUrl()
1672 if remote_url is None:
Josip906bfde2020-01-31 22:38:49 +00001673 logging.warning('invalid remote')
Florian Mayerae510e82020-01-30 21:04:48 +00001674 return
1675 if urllib.parse.urlparse(remote_url).scheme != 'https':
Josip906bfde2020-01-31 22:38:49 +00001676 logging.warning('Ignoring branch %(branch)s with non-https remote '
1677 '%(remote)s', {
1678 'branch': self.branch,
1679 'remote': self.GetRemoteUrl()
1680 })
Daniel Chengcf6269b2019-05-18 01:02:12 +00001681 return
1682
Vadim Shtayurab250ec12018-10-04 00:21:08 +00001683 # Lazy-loader to identify Gerrit and Git hosts.
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001684 self.GetCodereviewServer()
1685 git_host = self._GetGitHost()
Edward Lemur298f2cf2019-02-22 21:40:39 +00001686 assert self._gerrit_server and self._gerrit_host and git_host
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001687
1688 gerrit_auth = cookie_auth.get_auth_header(self._gerrit_host)
1689 git_auth = cookie_auth.get_auth_header(git_host)
1690 if gerrit_auth and git_auth:
1691 if gerrit_auth == git_auth:
1692 return
Andrii Shyshkalov354e1d22017-06-09 19:31:33 +02001693 all_gsrc = cookie_auth.get_auth_header('d0esN0tEx1st.googlesource.com')
Raul Tambre80ee78e2019-05-06 22:41:05 +00001694 print(
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001695 'WARNING: You have different credentials for Gerrit and git hosts:\n'
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001696 ' %s\n'
1697 ' %s\n'
Andrii Shyshkalov51acef92017-04-11 17:19:59 +02001698 ' Consider running the following command:\n'
1699 ' git cl creds-check\n'
Andrii Shyshkalov354e1d22017-06-09 19:31:33 +02001700 ' %s\n'
Raul Tambre80ee78e2019-05-06 22:41:05 +00001701 ' %s' %
Andrii Shyshkalov51acef92017-04-11 17:19:59 +02001702 (git_host, self._gerrit_host,
Andrii Shyshkalov354e1d22017-06-09 19:31:33 +02001703 ('Hint: delete creds for .googlesource.com' if all_gsrc else ''),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001704 cookie_auth.get_new_password_message(git_host)))
1705 if not force:
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01001706 confirm_or_exit('If you know what you are doing', action='continue')
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001707 return
1708 else:
1709 missing = (
Anna Henningsen4e891442017-07-06 21:40:58 +02001710 ([] if gerrit_auth else [self._gerrit_host]) +
1711 ([] if git_auth else [git_host]))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001712 DieWithError('Credentials for the following hosts are required:\n'
1713 ' %s\n'
1714 'These are read from %s (or legacy %s)\n'
1715 '%s' % (
1716 '\n '.join(missing),
1717 cookie_auth.get_gitcookies_path(),
1718 cookie_auth.get_netrc_path(),
1719 cookie_auth.get_new_password_message(git_host)))
1720
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001721 def EnsureCanUploadPatchset(self, force):
Andrii Shyshkalov3e631422017-02-16 17:46:44 +01001722 if not self.GetIssue():
1723 return
1724
Andrii Shyshkalov3e631422017-02-16 17:46:44 +01001725 status = self._GetChangeDetail()['status']
1726 if status in ('MERGED', 'ABANDONED'):
1727 DieWithError('Change %s has been %s, new uploads are not allowed' %
1728 (self.GetIssueURL(),
1729 'submitted' if status == 'MERGED' else 'abandoned'))
1730
Vadim Shtayurab250ec12018-10-04 00:21:08 +00001731 # TODO(vadimsh): For some reason the chunk of code below was skipped if
1732 # 'is_gce' is True. I'm just refactoring it to be 'skip if not cookies'.
1733 # Apparently this check is not very important? Otherwise get_auth_email
1734 # could have been added to other implementations of Authenticator.
1735 cookies_auth = gerrit_util.Authenticator.get()
1736 if not isinstance(cookies_auth, gerrit_util.CookiesAuthenticator):
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001737 return
Vadim Shtayurab250ec12018-10-04 00:21:08 +00001738
1739 cookies_user = cookies_auth.get_auth_email(self._GetGerritHost())
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001740 if self.GetIssueOwner() == cookies_user:
1741 return
1742 logging.debug('change %s owner is %s, cookies user is %s',
1743 self.GetIssue(), self.GetIssueOwner(), cookies_user)
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001744 # Maybe user has linked accounts or something like that,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001745 # so ask what Gerrit thinks of this user.
1746 details = gerrit_util.GetAccountDetails(self._GetGerritHost(), 'self')
1747 if details['email'] == self.GetIssueOwner():
1748 return
1749 if not force:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001750 print('WARNING: Change %s is owned by %s, but you authenticate to Gerrit '
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001751 'as %s.\n'
1752 'Uploading may fail due to lack of permissions.' %
1753 (self.GetIssue(), self.GetIssueOwner(), details['email']))
1754 confirm_or_exit(action='upload')
1755
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00001756 def _PostUnsetIssueProperties(self):
1757 """Which branch-specific properties to erase when unsetting issue."""
tandrii5d48c322016-08-18 16:19:37 -07001758 return ['gerritsquashhash']
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00001759
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001760 def GetGerritObjForPresubmit(self):
1761 return presubmit_support.GerritAccessor(self._GetGerritHost())
1762
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001763 def GetStatus(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001764 """Applies a rough heuristic to give a simple summary of an issue's review
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001765 or CQ status, assuming adherence to a common workflow.
1766
1767 Returns None if no issue for this branch, or one of the following keywords:
Aaron Gable9ab38c62017-04-06 14:36:33 -07001768 * 'error' - error from review tool (including deleted issues)
1769 * 'unsent' - no reviewers added
1770 * 'waiting' - waiting for review
1771 * 'reply' - waiting for uploader to reply to review
1772 * 'lgtm' - Code-Review label has been set
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +00001773 * 'dry-run' - dry-running in the CQ
1774 * 'commit' - in the CQ
Aaron Gable9ab38c62017-04-06 14:36:33 -07001775 * 'closed' - successfully submitted or abandoned
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001776 """
1777 if not self.GetIssue():
1778 return None
1779
1780 try:
Aaron Gable9ab38c62017-04-06 14:36:33 -07001781 data = self._GetChangeDetail([
1782 'DETAILED_LABELS', 'CURRENT_REVISION', 'SUBMITTABLE'])
Edward Lemur79d4f992019-11-11 23:49:02 +00001783 except GerritChangeNotExists:
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001784 return 'error'
1785
tandrii@chromium.org5e1bf382016-05-17 08:43:24 +00001786 if data['status'] in ('ABANDONED', 'MERGED'):
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001787 return 'closed'
1788
Andrii Shyshkalovb8268ca2019-04-03 23:33:44 +00001789 cq_label = data['labels'].get('Commit-Queue', {})
1790 max_cq_vote = 0
1791 for vote in cq_label.get('all', []):
1792 max_cq_vote = max(max_cq_vote, vote.get('value', 0))
1793 if max_cq_vote == 2:
Aaron Gable9ab38c62017-04-06 14:36:33 -07001794 return 'commit'
Andrii Shyshkalovb8268ca2019-04-03 23:33:44 +00001795 if max_cq_vote == 1:
1796 return 'dry-run'
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001797
Aaron Gable9ab38c62017-04-06 14:36:33 -07001798 if data['labels'].get('Code-Review', {}).get('approved'):
1799 return 'lgtm'
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001800
1801 if not data.get('reviewers', {}).get('REVIEWER', []):
1802 return 'unsent'
1803
Andrii Shyshkalov33e88a42017-01-27 14:45:30 +01001804 owner = data['owner'].get('_account_id')
Edward Lemur79d4f992019-11-11 23:49:02 +00001805 messages = sorted(data.get('messages', []), key=lambda m: m.get('date'))
Aaron Gable9ab38c62017-04-06 14:36:33 -07001806 last_message_author = messages.pop().get('author', {})
1807 while last_message_author:
Andrii Shyshkalov33e88a42017-01-27 14:45:30 +01001808 if last_message_author.get('email') == COMMIT_BOT_EMAIL:
1809 # Ignore replies from CQ.
Aaron Gable9ab38c62017-04-06 14:36:33 -07001810 last_message_author = messages.pop().get('author', {})
Andrii Shyshkalov33e88a42017-01-27 14:45:30 +01001811 continue
Aaron Gable9ab38c62017-04-06 14:36:33 -07001812 if last_message_author.get('_account_id') == owner:
1813 # Most recent message was by owner.
1814 return 'waiting'
1815 else:
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001816 # Some reply from non-owner.
1817 return 'reply'
Aaron Gable9ab38c62017-04-06 14:36:33 -07001818
1819 # Somehow there are no messages even though there are reviewers.
1820 return 'unsent'
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001821
1822 def GetMostRecentPatchset(self):
Edward Lemur6c6827c2020-02-06 21:15:18 +00001823 if not self.GetIssue():
1824 return None
1825
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001826 data = self._GetChangeDetail(['CURRENT_REVISION'])
Aaron Gablee8856ee2017-12-07 12:41:46 -08001827 patchset = data['revisions'][data['current_revision']]['_number']
1828 self.SetPatchset(patchset)
1829 return patchset
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001830
Aaron Gable636b13f2017-07-14 10:42:48 -07001831 def AddComment(self, message, publish=None):
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00001832 gerrit_util.SetReview(
1833 self._GetGerritHost(), self._GerritChangeIdentifier(),
1834 msg=message, ready=publish)
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01001835
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001836 def GetCommentsSummary(self, readable=True):
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01001837 # DETAILED_ACCOUNTS is to get emails in accounts.
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001838 # CURRENT_REVISION is included to get the latest patchset so that
1839 # only the robot comments from the latest patchset can be shown.
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001840 messages = self._GetChangeDetail(
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001841 options=['MESSAGES', 'DETAILED_ACCOUNTS',
1842 'CURRENT_REVISION']).get('messages', [])
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001843 file_comments = gerrit_util.GetChangeComments(
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00001844 self._GetGerritHost(), self._GerritChangeIdentifier())
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001845 robot_file_comments = gerrit_util.GetChangeRobotComments(
1846 self._GetGerritHost(), self._GerritChangeIdentifier())
1847
1848 # Add the robot comments onto the list of comments, but only
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00001849 # keep those that are from the latest patchset.
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001850 latest_patch_set = self.GetMostRecentPatchset()
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001851 for path, robot_comments in robot_file_comments.items():
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001852 line_comments = file_comments.setdefault(path, [])
1853 line_comments.extend(
1854 [c for c in robot_comments if c['patch_set'] == latest_patch_set])
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001855
1856 # Build dictionary of file comments for easy access and sorting later.
1857 # {author+date: {path: {patchset: {line: url+message}}}}
1858 comments = collections.defaultdict(
1859 lambda: collections.defaultdict(lambda: collections.defaultdict(dict)))
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001860 for path, line_comments in file_comments.items():
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001861 for comment in line_comments:
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001862 tag = comment.get('tag', '')
1863 if tag.startswith('autogenerated') and 'robot_id' not in comment:
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001864 continue
1865 key = (comment['author']['email'], comment['updated'])
1866 if comment.get('side', 'REVISION') == 'PARENT':
1867 patchset = 'Base'
1868 else:
1869 patchset = 'PS%d' % comment['patch_set']
1870 line = comment.get('line', 0)
1871 url = ('https://%s/c/%s/%s/%s#%s%s' %
1872 (self._GetGerritHost(), self.GetIssue(), comment['patch_set'], path,
1873 'b' if comment.get('side') == 'PARENT' else '',
1874 str(line) if line else ''))
1875 comments[key][path][patchset][line] = (url, comment['message'])
1876
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001877 summaries = []
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001878 for msg in messages:
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001879 summary = self._BuildCommentSummary(msg, comments, readable)
1880 if summary:
1881 summaries.append(summary)
1882 return summaries
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001883
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001884 @staticmethod
1885 def _BuildCommentSummary(msg, comments, readable):
1886 key = (msg['author']['email'], msg['date'])
1887 # Don't bother showing autogenerated messages that don't have associated
1888 # file or line comments. this will filter out most autogenerated
1889 # messages, but will keep robot comments like those from Tricium.
1890 is_autogenerated = msg.get('tag', '').startswith('autogenerated')
1891 if is_autogenerated and not comments.get(key):
1892 return None
1893 message = msg['message']
1894 # Gerrit spits out nanoseconds.
1895 assert len(msg['date'].split('.')[-1]) == 9
1896 date = datetime.datetime.strptime(msg['date'][:-3],
1897 '%Y-%m-%d %H:%M:%S.%f')
1898 if key in comments:
1899 message += '\n'
1900 for path, patchsets in sorted(comments.get(key, {}).items()):
1901 if readable:
1902 message += '\n%s' % path
1903 for patchset, lines in sorted(patchsets.items()):
1904 for line, (url, content) in sorted(lines.items()):
1905 if line:
1906 line_str = 'Line %d' % line
1907 path_str = '%s:%d:' % (path, line)
1908 else:
1909 line_str = 'File comment'
1910 path_str = '%s:0:' % path
1911 if readable:
1912 message += '\n %s, %s: %s' % (patchset, line_str, url)
1913 message += '\n %s\n' % content
1914 else:
1915 message += '\n%s ' % path_str
1916 message += '\n%s\n' % content
1917
1918 return _CommentSummary(
1919 date=date,
1920 message=message,
1921 sender=msg['author']['email'],
1922 autogenerated=is_autogenerated,
1923 # These could be inferred from the text messages and correlated with
1924 # Code-Review label maximum, however this is not reliable.
1925 # Leaving as is until the need arises.
1926 approval=False,
1927 disapproval=False,
1928 )
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01001929
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001930 def CloseIssue(self):
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00001931 gerrit_util.AbandonChange(
1932 self._GetGerritHost(), self._GerritChangeIdentifier(), msg='')
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001933
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00001934 def SubmitIssue(self, wait_for_merge=True):
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00001935 gerrit_util.SubmitChange(
1936 self._GetGerritHost(), self._GerritChangeIdentifier(),
1937 wait_for_merge=wait_for_merge)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001938
Edward Lesmes7677e5c2020-02-19 20:39:03 +00001939 def _GetChangeDetail(self, options=None):
1940 """Returns details of associated Gerrit change and caching results."""
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00001941 options = options or []
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001942 assert self.GetIssue(), 'issue is required to query Gerrit'
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01001943
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01001944 # Optimization to avoid multiple RPCs:
Edward Lesmes7677e5c2020-02-19 20:39:03 +00001945 if 'CURRENT_REVISION' in options or 'ALL_REVISIONS' in options:
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01001946 options.append('CURRENT_COMMIT')
1947
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01001948 # Normalize issue and options for consistent keys in cache.
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001949 cache_key = str(self.GetIssue())
Edward Lesmes7677e5c2020-02-19 20:39:03 +00001950 options_set = frozenset(o.upper() for o in options)
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01001951
Edward Lesmes7677e5c2020-02-19 20:39:03 +00001952 for cached_options_set, data in self._detail_cache.get(cache_key, []):
1953 # Assumption: data fetched before with extra options is suitable
1954 # for return for a smaller set of options.
1955 # For example, if we cached data for
1956 # options=[CURRENT_REVISION, DETAILED_FOOTERS]
1957 # and request is for options=[CURRENT_REVISION],
1958 # THEN we can return prior cached data.
1959 if options_set.issubset(cached_options_set):
1960 return data
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01001961
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01001962 try:
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001963 data = gerrit_util.GetChangeDetail(
Edward Lesmes7677e5c2020-02-19 20:39:03 +00001964 self._GetGerritHost(), self._GerritChangeIdentifier(), options_set)
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01001965 except gerrit_util.GerritError as e:
1966 if e.http_status == 404:
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001967 raise GerritChangeNotExists(self.GetIssue(), self.GetCodereviewServer())
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01001968 raise
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01001969
Edward Lesmes7677e5c2020-02-19 20:39:03 +00001970 self._detail_cache.setdefault(cache_key, []).append((options_set, data))
tandriic2405f52016-10-10 08:13:15 -07001971 return data
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001972
Andrii Shyshkalovcc5f17e2018-08-22 23:35:59 +00001973 def _GetChangeCommit(self):
Andrii Shyshkalove2633162018-08-27 23:50:31 +00001974 assert self.GetIssue(), 'issue must be set to query Gerrit'
Aaron Gable6f5a8d92017-04-18 14:49:05 -07001975 try:
Andrii Shyshkalove2633162018-08-27 23:50:31 +00001976 data = gerrit_util.GetChangeCommit(
1977 self._GetGerritHost(), self._GerritChangeIdentifier())
Aaron Gable6f5a8d92017-04-18 14:49:05 -07001978 except gerrit_util.GerritError as e:
1979 if e.http_status == 404:
Andrii Shyshkalove2633162018-08-27 23:50:31 +00001980 raise GerritChangeNotExists(self.GetIssue(), self.GetCodereviewServer())
Aaron Gable6f5a8d92017-04-18 14:49:05 -07001981 raise
agable32978d92016-11-01 12:55:02 -07001982 return data
1983
Karen Qian40c19422019-03-13 21:28:29 +00001984 def _IsCqConfigured(self):
1985 detail = self._GetChangeDetail(['LABELS'])
Andrii Shyshkalov8effa4d2020-01-21 13:23:36 +00001986 return u'Commit-Queue' in detail.get('labels', {})
Karen Qian40c19422019-03-13 21:28:29 +00001987
Olivier Robin75ee7252018-04-13 10:02:56 +02001988 def CMDLand(self, force, bypass_hooks, verbose, parallel):
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00001989 if git_common.is_dirty_git_tree('land'):
1990 return 1
Karen Qian40c19422019-03-13 21:28:29 +00001991
tandriid60367b2016-06-22 05:25:12 -07001992 detail = self._GetChangeDetail(['CURRENT_REVISION', 'LABELS'])
Karen Qian40c19422019-03-13 21:28:29 +00001993 if not force and self._IsCqConfigured():
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +00001994 confirm_or_exit('\nIt seems this repository has a CQ, '
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01001995 'which can test and land changes for you. '
1996 'Are you sure you wish to bypass it?\n',
1997 action='bypass CQ')
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00001998 differs = True
tandriic4344b52016-08-29 06:04:54 -07001999 last_upload = self._GitGetBranchConfigValue('gerritsquashhash')
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002000 # Note: git diff outputs nothing if there is no diff.
2001 if not last_upload or RunGit(['diff', last_upload]).strip():
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002002 print('WARNING: Some changes from local branch haven\'t been uploaded.')
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002003 else:
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002004 if detail['current_revision'] == last_upload:
2005 differs = False
2006 else:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002007 print('WARNING: Local branch contents differ from latest uploaded '
2008 'patchset.')
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002009 if differs:
2010 if not force:
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002011 confirm_or_exit(
2012 'Do you want to submit latest Gerrit patchset and bypass hooks?\n',
2013 action='submit')
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002014 print('WARNING: Bypassing hooks and submitting latest uploaded patchset.')
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002015 elif not bypass_hooks:
Edward Lemur227d5102020-02-25 23:45:35 +00002016 upstream = self.GetCommonAncestorWithUpstream()
2017 if self.GetIssue():
2018 description = self.FetchDescription()
2019 else:
Gregory Nisbet29d5cf82020-02-27 08:16:58 +00002020 description = self.GetLocalDescription(upstream)
Edward Lemur227d5102020-02-25 23:45:35 +00002021 self.RunHook(
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002022 committing=True,
2023 may_prompt=not force,
2024 verbose=verbose,
Edward Lemur227d5102020-02-25 23:45:35 +00002025 parallel=parallel,
2026 upstream=upstream,
2027 description=description,
2028 all_files=False)
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002029
2030 self.SubmitIssue(wait_for_merge=True)
2031 print('Issue %s has been submitted.' % self.GetIssueURL())
agable32978d92016-11-01 12:55:02 -07002032 links = self._GetChangeCommit().get('web_links', [])
2033 for link in links:
Aaron Gable02cdbb42016-12-13 16:24:25 -08002034 if link.get('name') == 'gitiles' and link.get('url'):
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002035 print('Landed as: %s' % link.get('url'))
agable32978d92016-11-01 12:55:02 -07002036 break
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002037 return 0
2038
Edward Lemurf38bc172019-09-03 21:02:13 +00002039 def CMDPatchWithParsedIssue(self, parsed_issue_arg, nocommit, force):
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002040 assert parsed_issue_arg.valid
2041
Edward Lemur125d60a2019-09-13 18:25:41 +00002042 self.issue = parsed_issue_arg.issue
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002043
2044 if parsed_issue_arg.hostname:
2045 self._gerrit_host = parsed_issue_arg.hostname
2046 self._gerrit_server = 'https://%s' % self._gerrit_host
2047
tandriic2405f52016-10-10 08:13:15 -07002048 try:
2049 detail = self._GetChangeDetail(['ALL_REVISIONS'])
Aaron Gablea45ee112016-11-22 15:14:38 -08002050 except GerritChangeNotExists as e:
tandriic2405f52016-10-10 08:13:15 -07002051 DieWithError(str(e))
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002052
2053 if not parsed_issue_arg.patchset:
2054 # Use current revision by default.
2055 revision_info = detail['revisions'][detail['current_revision']]
2056 patchset = int(revision_info['_number'])
2057 else:
2058 patchset = parsed_issue_arg.patchset
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00002059 for revision_info in detail['revisions'].values():
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002060 if int(revision_info['_number']) == parsed_issue_arg.patchset:
2061 break
2062 else:
Aaron Gablea45ee112016-11-22 15:14:38 -08002063 DieWithError('Couldn\'t find patchset %i in change %i' %
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002064 (parsed_issue_arg.patchset, self.GetIssue()))
2065
Edward Lemur125d60a2019-09-13 18:25:41 +00002066 remote_url = self.GetRemoteUrl()
Aaron Gable697a91b2018-01-19 15:20:15 -08002067 if remote_url.endswith('.git'):
2068 remote_url = remote_url[:-len('.git')]
erikchen0d14d0d2018-08-28 18:57:09 +00002069 remote_url = remote_url.rstrip('/')
2070
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002071 fetch_info = revision_info['fetch']['http']
erikchen0d14d0d2018-08-28 18:57:09 +00002072 fetch_info['url'] = fetch_info['url'].rstrip('/')
Aaron Gable697a91b2018-01-19 15:20:15 -08002073
2074 if remote_url != fetch_info['url']:
2075 DieWithError('Trying to patch a change from %s but this repo appears '
2076 'to be %s.' % (fetch_info['url'], remote_url))
2077
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002078 RunGit(['fetch', fetch_info['url'], fetch_info['ref']])
Aaron Gable9387b4f2017-06-08 10:50:03 -07002079
Aaron Gable62619a32017-06-16 08:22:09 -07002080 if force:
2081 RunGit(['reset', '--hard', 'FETCH_HEAD'])
2082 print('Checked out commit for change %i patchset %i locally' %
2083 (parsed_issue_arg.issue, patchset))
Stefan Zager2d5f0392017-10-10 15:17:53 -07002084 elif nocommit:
2085 RunGit(['cherry-pick', '--no-commit', 'FETCH_HEAD'])
2086 print('Patch applied to index.')
Aaron Gable62619a32017-06-16 08:22:09 -07002087 else:
Aaron Gable9387b4f2017-06-08 10:50:03 -07002088 RunGit(['cherry-pick', 'FETCH_HEAD'])
2089 print('Committed patch for change %i patchset %i locally.' %
Aaron Gable62619a32017-06-16 08:22:09 -07002090 (parsed_issue_arg.issue, patchset))
2091 print('Note: this created a local commit which does not have '
2092 'the same hash as the one uploaded for review. This will make '
2093 'uploading changes based on top of this branch difficult.\n'
2094 'If you want to do that, use "git cl patch --force" instead.')
2095
Stefan Zagerd08043c2017-10-12 12:07:02 -07002096 if self.GetBranch():
2097 self.SetIssue(parsed_issue_arg.issue)
2098 self.SetPatchset(patchset)
2099 fetched_hash = RunGit(['rev-parse', 'FETCH_HEAD']).strip()
2100 self._GitSetBranchConfigValue('last-upload-hash', fetched_hash)
2101 self._GitSetBranchConfigValue('gerritsquashhash', fetched_hash)
2102 else:
2103 print('WARNING: You are in detached HEAD state.\n'
2104 'The patch has been applied to your checkout, but you will not be '
2105 'able to upload a new patch set to the gerrit issue.\n'
2106 'Try using the \'-b\' option if you would like to work on a '
2107 'branch and/or upload a new patch set.')
2108
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002109 return 0
2110
tandrii16e0b4e2016-06-07 10:34:28 -07002111 def _GerritCommitMsgHookCheck(self, offer_removal):
2112 hook = os.path.join(settings.GetRoot(), '.git', 'hooks', 'commit-msg')
2113 if not os.path.exists(hook):
2114 return
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002115 # Crude attempt to distinguish Gerrit Codereview hook from a potentially
2116 # custom developer-made one.
tandrii16e0b4e2016-06-07 10:34:28 -07002117 data = gclient_utils.FileRead(hook)
2118 if not('From Gerrit Code Review' in data and 'add_ChangeId()' in data):
2119 return
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002120 print('WARNING: You have Gerrit commit-msg hook installed.\n'
qyearsley12fa6ff2016-08-24 09:18:40 -07002121 'It is not necessary for uploading with git cl in squash mode, '
tandrii16e0b4e2016-06-07 10:34:28 -07002122 'and may interfere with it in subtle ways.\n'
2123 'We recommend you remove the commit-msg hook.')
2124 if offer_removal:
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002125 if ask_for_explicit_yes('Do you want to remove it now?'):
tandrii16e0b4e2016-06-07 10:34:28 -07002126 gclient_utils.rm_file_or_tree(hook)
2127 print('Gerrit commit-msg hook removed.')
2128 else:
2129 print('OK, will keep Gerrit commit-msg hook in place.')
2130
Edward Lemur1b52d872019-05-09 21:12:12 +00002131 def _CleanUpOldTraces(self):
2132 """Keep only the last |MAX_TRACES| traces."""
2133 try:
2134 traces = sorted([
2135 os.path.join(TRACES_DIR, f)
2136 for f in os.listdir(TRACES_DIR)
2137 if (os.path.isfile(os.path.join(TRACES_DIR, f))
2138 and not f.startswith('tmp'))
2139 ])
2140 traces_to_delete = traces[:-MAX_TRACES]
2141 for trace in traces_to_delete:
Daniel Chengcf6269b2019-05-18 01:02:12 +00002142 os.remove(trace)
Edward Lemur1b52d872019-05-09 21:12:12 +00002143 except OSError:
2144 print('WARNING: Failed to remove old git traces from\n'
2145 ' %s'
2146 'Consider removing them manually.' % TRACES_DIR)
Edward Lemurdc8e23d2019-05-07 00:45:48 +00002147
Edward Lemur5737f022019-05-17 01:24:00 +00002148 def _WriteGitPushTraces(self, trace_name, traces_dir, git_push_metadata):
Edward Lemur1b52d872019-05-09 21:12:12 +00002149 """Zip and write the git push traces stored in traces_dir."""
2150 gclient_utils.safe_makedirs(TRACES_DIR)
Edward Lemur1b52d872019-05-09 21:12:12 +00002151 traces_zip = trace_name + '-traces'
2152 traces_readme = trace_name + '-README'
Michael Mosse7f0b4c2019-05-08 04:36:24 +00002153 # Create a temporary dir to store git config and gitcookies in. It will be
2154 # compressed and stored next to the traces.
2155 git_info_dir = tempfile.mkdtemp()
Edward Lemur1b52d872019-05-09 21:12:12 +00002156 git_info_zip = trace_name + '-git-info'
2157
Edward Lemur5737f022019-05-17 01:24:00 +00002158 git_push_metadata['now'] = datetime_now().strftime('%c')
Eric Boren67c48202019-05-30 16:52:51 +00002159 if sys.stdin.encoding and sys.stdin.encoding != 'utf-8':
sangwoo.ko7a614332019-05-22 02:46:19 +00002160 git_push_metadata['now'] = git_push_metadata['now'].decode(
2161 sys.stdin.encoding)
2162
Edward Lemur1b52d872019-05-09 21:12:12 +00002163 git_push_metadata['trace_name'] = trace_name
2164 gclient_utils.FileWrite(
2165 traces_readme, TRACES_README_FORMAT % git_push_metadata)
2166
2167 # Keep only the first 6 characters of the git hashes on the packet
2168 # trace. This greatly decreases size after compression.
2169 packet_traces = os.path.join(traces_dir, 'trace-packet')
2170 if os.path.isfile(packet_traces):
2171 contents = gclient_utils.FileRead(packet_traces)
2172 gclient_utils.FileWrite(
2173 packet_traces, GIT_HASH_RE.sub(r'\1', contents))
2174 shutil.make_archive(traces_zip, 'zip', traces_dir)
2175
2176 # Collect and compress the git config and gitcookies.
2177 git_config = RunGit(['config', '-l'])
2178 gclient_utils.FileWrite(
2179 os.path.join(git_info_dir, 'git-config'),
2180 git_config)
2181
2182 cookie_auth = gerrit_util.Authenticator.get()
2183 if isinstance(cookie_auth, gerrit_util.CookiesAuthenticator):
2184 gitcookies_path = cookie_auth.get_gitcookies_path()
2185 if os.path.isfile(gitcookies_path):
2186 gitcookies = gclient_utils.FileRead(gitcookies_path)
2187 gclient_utils.FileWrite(
2188 os.path.join(git_info_dir, 'gitcookies'),
2189 GITCOOKIES_REDACT_RE.sub('REDACTED', gitcookies))
2190 shutil.make_archive(git_info_zip, 'zip', git_info_dir)
2191
Edward Lemur1b52d872019-05-09 21:12:12 +00002192 gclient_utils.rmtree(git_info_dir)
2193
2194 def _RunGitPushWithTraces(
2195 self, change_desc, refspec, refspec_opts, git_push_metadata):
2196 """Run git push and collect the traces resulting from the execution."""
2197 # Create a temporary directory to store traces in. Traces will be compressed
2198 # and stored in a 'traces' dir inside depot_tools.
2199 traces_dir = tempfile.mkdtemp()
Edward Lemur5737f022019-05-17 01:24:00 +00002200 trace_name = os.path.join(
2201 TRACES_DIR, datetime_now().strftime('%Y%m%dT%H%M%S.%f'))
Edward Lemur0f58ae42019-04-30 17:24:12 +00002202
2203 env = os.environ.copy()
2204 env['GIT_REDACT_COOKIES'] = 'o,SSO,GSSO_Uberproxy'
2205 env['GIT_TR2_EVENT'] = os.path.join(traces_dir, 'tr2-event')
Jonathan Nieder9779b142019-05-29 23:19:29 +00002206 env['GIT_TRACE2_EVENT'] = os.path.join(traces_dir, 'tr2-event')
Edward Lemur0f58ae42019-04-30 17:24:12 +00002207 env['GIT_TRACE_CURL'] = os.path.join(traces_dir, 'trace-curl')
2208 env['GIT_TRACE_CURL_NO_DATA'] = '1'
2209 env['GIT_TRACE_PACKET'] = os.path.join(traces_dir, 'trace-packet')
2210
2211 try:
2212 push_returncode = 0
Edward Lemur1b52d872019-05-09 21:12:12 +00002213 remote_url = self.GetRemoteUrl()
Edward Lemur0f58ae42019-04-30 17:24:12 +00002214 before_push = time_time()
2215 push_stdout = gclient_utils.CheckCallAndFilter(
Edward Lemur1b52d872019-05-09 21:12:12 +00002216 ['git', 'push', remote_url, refspec],
Edward Lemur0f58ae42019-04-30 17:24:12 +00002217 env=env,
2218 print_stdout=True,
2219 # Flush after every line: useful for seeing progress when running as
2220 # recipe.
2221 filter_fn=lambda _: sys.stdout.flush())
Edward Lemur79d4f992019-11-11 23:49:02 +00002222 push_stdout = push_stdout.decode('utf-8', 'replace')
Edward Lemur0f58ae42019-04-30 17:24:12 +00002223 except subprocess2.CalledProcessError as e:
2224 push_returncode = e.returncode
2225 DieWithError('Failed to create a change. Please examine output above '
2226 'for the reason of the failure.\n'
2227 'Hint: run command below to diagnose common Git/Gerrit '
2228 'credential problems:\n'
Edward Lemur5737f022019-05-17 01:24:00 +00002229 ' git cl creds-check\n'
2230 '\n'
2231 'If git-cl is not working correctly, file a bug under the '
2232 'Infra>SDK component including the files below.\n'
2233 'Review the files before upload, since they might contain '
2234 'sensitive information.\n'
2235 'Set the Restrict-View-Google label so that they are not '
2236 'publicly accessible.\n'
2237 + TRACES_MESSAGE % {'trace_name': trace_name},
Edward Lemur0f58ae42019-04-30 17:24:12 +00002238 change_desc)
2239 finally:
2240 execution_time = time_time() - before_push
2241 metrics.collector.add_repeated('sub_commands', {
2242 'command': 'git push',
2243 'execution_time': execution_time,
2244 'exit_code': push_returncode,
2245 'arguments': metrics_utils.extract_known_subcommand_args(refspec_opts),
2246 })
2247
Edward Lemur1b52d872019-05-09 21:12:12 +00002248 git_push_metadata['execution_time'] = execution_time
2249 git_push_metadata['exit_code'] = push_returncode
Edward Lemur5737f022019-05-17 01:24:00 +00002250 self._WriteGitPushTraces(trace_name, traces_dir, git_push_metadata)
Edward Lemur0f58ae42019-04-30 17:24:12 +00002251
Edward Lemur1b52d872019-05-09 21:12:12 +00002252 self._CleanUpOldTraces()
Edward Lemur0f58ae42019-04-30 17:24:12 +00002253 gclient_utils.rmtree(traces_dir)
2254
2255 return push_stdout
2256
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002257 def CMDUploadChange(self, options, git_diff_args, custom_cl_base, change):
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002258 """Upload the current branch to Gerrit."""
Mike Frysingera989d552019-08-14 20:51:23 +00002259 if options.squash is None:
tandriia60502f2016-06-20 02:01:53 -07002260 # Load default for user, repo, squash=true, in this order.
2261 options.squash = settings.GetSquashGerritUploads()
tandrii26f3e4e2016-06-10 08:37:04 -07002262
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002263 remote, remote_branch = self.GetRemoteBranch()
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01002264 branch = GetTargetRef(remote, remote_branch, options.target_branch)
Aaron Gableb56ad332017-01-06 15:24:31 -08002265 # This may be None; default fallback value is determined in logic below.
2266 title = options.title
2267
Dominic Battre7d1c4842017-10-27 09:17:28 +02002268 # Extract bug number from branch name.
2269 bug = options.bug
Dan Beamd8b04ca2019-10-10 21:23:26 +00002270 fixed = options.fixed
2271 match = re.match(r'(?P<type>bug|fix(?:e[sd])?)[_-]?(?P<bugnum>\d+)',
2272 self.GetBranch())
2273 if not bug and not fixed and match:
2274 if match.group('type') == 'bug':
2275 bug = match.group('bugnum')
2276 else:
2277 fixed = match.group('bugnum')
Dominic Battre7d1c4842017-10-27 09:17:28 +02002278
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002279 if options.squash:
tandrii16e0b4e2016-06-07 10:34:28 -07002280 self._GerritCommitMsgHookCheck(offer_removal=not options.force)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002281 if self.GetIssue():
2282 # Try to get the message from a previous upload.
Edward Lemur6c6827c2020-02-06 21:15:18 +00002283 message = self.FetchDescription()
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002284 if not message:
2285 DieWithError(
Aaron Gablea45ee112016-11-22 15:14:38 -08002286 'failed to fetch description from current Gerrit change %d\n'
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002287 '%s' % (self.GetIssue(), self.GetIssueURL()))
Aaron Gableb56ad332017-01-06 15:24:31 -08002288 if not title:
Andrii Shyshkalov2d8a2072017-04-10 15:02:18 +02002289 if options.message:
Aaron Gable7303dcb2017-06-07 14:17:32 -07002290 # When uploading a subsequent patchset, -m|--message is taken
2291 # as the patchset title if --title was not provided.
2292 title = options.message.strip()
Andrii Shyshkalov2d8a2072017-04-10 15:02:18 +02002293 else:
2294 default_title = RunGit(
2295 ['show', '-s', '--format=%s', 'HEAD']).strip()
Aaron Gable7303dcb2017-06-07 14:17:32 -07002296 if options.force:
2297 title = default_title
2298 else:
2299 title = ask_for_data(
2300 'Title for patchset [%s]: ' % default_title) or default_title
Josipe827b0f2020-01-30 00:07:20 +00002301
2302 # User requested to change description
2303 if options.edit_description:
2304 change_desc = ChangeDescription(message, bug=bug, fixed=fixed)
2305 change_desc.prompt()
2306 message = change_desc.description
2307
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002308 change_id = self._GetChangeDetail()['change_id']
2309 while True:
2310 footer_change_ids = git_footers.get_footer_change_id(message)
2311 if footer_change_ids == [change_id]:
2312 break
2313 if not footer_change_ids:
2314 message = git_footers.add_footer_change_id(message, change_id)
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002315 print('WARNING: appended missing Change-Id to change description.')
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002316 continue
2317 # There is already a valid footer but with different or several ids.
2318 # Doing this automatically is non-trivial as we don't want to lose
2319 # existing other footers, yet we want to append just 1 desired
2320 # Change-Id. Thus, just create a new footer, but let user verify the
2321 # new description.
2322 message = '%s\n\nChange-Id: %s' % (message, change_id)
Dan Beamd8b04ca2019-10-10 21:23:26 +00002323 change_desc = ChangeDescription(message, bug=bug, fixed=fixed)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002324 if not options.force:
Anthony Polito8b955342019-09-24 19:01:36 +00002325 print(
2326 'WARNING: change %s has Change-Id footer(s):\n'
2327 ' %s\n'
2328 'but change has Change-Id %s, according to Gerrit.\n'
2329 'Please, check the proposed correction to the description, '
2330 'and edit it if necessary but keep the "Change-Id: %s" footer\n'
2331 % (self.GetIssue(), '\n '.join(footer_change_ids), change_id,
2332 change_id))
2333 confirm_or_exit(action='edit')
2334 change_desc.prompt()
2335
2336 message = change_desc.description
2337 if not message:
2338 DieWithError("Description is empty. Aborting...")
2339
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002340 # Continue the while loop.
2341 # Sanity check of this code - we should end up with proper message
2342 # footer.
2343 assert [change_id] == git_footers.get_footer_change_id(message)
Dan Beamd8b04ca2019-10-10 21:23:26 +00002344 change_desc = ChangeDescription(message, bug=bug, fixed=fixed)
Aaron Gableb56ad332017-01-06 15:24:31 -08002345 else: # if not self.GetIssue()
2346 if options.message:
2347 message = options.message
2348 else:
Andrii Shyshkalovb07575f2018-10-16 06:16:21 +00002349 message = _create_description_from_log(git_diff_args)
Aaron Gableb56ad332017-01-06 15:24:31 -08002350 if options.title:
2351 message = options.title + '\n\n' + message
Dan Beamd8b04ca2019-10-10 21:23:26 +00002352 change_desc = ChangeDescription(message, bug=bug, fixed=fixed)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002353 if not options.force:
Anthony Polito8b955342019-09-24 19:01:36 +00002354 change_desc.prompt()
2355
Aaron Gableb56ad332017-01-06 15:24:31 -08002356 # On first upload, patchset title is always this string, while
2357 # --title flag gets converted to first line of message.
2358 title = 'Initial upload'
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002359 if not change_desc.description:
2360 DieWithError("Description is empty. Aborting...")
Andrii Shyshkalov8c90d032017-04-19 21:27:26 +02002361 change_ids = git_footers.get_footer_change_id(change_desc.description)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002362 if len(change_ids) > 1:
2363 DieWithError('too many Change-Id footers, at most 1 allowed.')
2364 if not change_ids:
2365 # Generate the Change-Id automatically.
Andrii Shyshkalov8c90d032017-04-19 21:27:26 +02002366 change_desc.set_description(git_footers.add_footer_change_id(
2367 change_desc.description,
2368 GenerateGerritChangeId(change_desc.description)))
2369 change_ids = git_footers.get_footer_change_id(change_desc.description)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002370 assert len(change_ids) == 1
2371 change_id = change_ids[0]
2372
Robert Iannuccidb02dd02017-04-19 12:18:20 -07002373 if options.reviewers or options.tbrs or options.add_owners_to:
2374 change_desc.update_reviewers(options.reviewers, options.tbrs,
2375 options.add_owners_to, change)
Andrii Shyshkalov71f0da32019-07-15 22:45:18 +00002376 if options.preserve_tryjobs:
2377 change_desc.set_preserve_tryjobs()
Robert Iannuccidb02dd02017-04-19 12:18:20 -07002378
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002379 remote, upstream_branch = self.FetchUpstreamTuple(self.GetBranch())
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002380 parent = self._ComputeParent(remote, upstream_branch, custom_cl_base,
2381 options.force, change_desc)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002382 tree = RunGit(['rev-parse', 'HEAD:']).strip()
Edward Lemur1773f372020-02-22 00:27:14 +00002383 with gclient_utils.temporary_file() as desc_tempfile:
2384 gclient_utils.FileWrite(desc_tempfile, change_desc.description)
2385 ref_to_push = RunGit(
2386 ['commit-tree', tree, '-p', parent, '-F', desc_tempfile]).strip()
Anthony Polito8b955342019-09-24 19:01:36 +00002387 else: # if not options.squash
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002388 change_desc = ChangeDescription(
Andrii Shyshkalovb07575f2018-10-16 06:16:21 +00002389 options.message or _create_description_from_log(git_diff_args))
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002390 if not change_desc.description:
2391 DieWithError("Description is empty. Aborting...")
2392
2393 if not git_footers.get_footer_change_id(change_desc.description):
2394 DownloadGerritHook(False)
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002395 change_desc.set_description(
2396 self._AddChangeIdToCommitMessage(options, git_diff_args))
Robert Iannuccidb02dd02017-04-19 12:18:20 -07002397 if options.reviewers or options.tbrs or options.add_owners_to:
2398 change_desc.update_reviewers(options.reviewers, options.tbrs,
2399 options.add_owners_to, change)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002400 ref_to_push = 'HEAD'
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002401 # For no-squash mode, we assume the remote called "origin" is the one we
2402 # want. It is not worthwhile to support different workflows for
2403 # no-squash mode.
2404 parent = 'origin/%s' % branch
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002405 change_id = git_footers.get_footer_change_id(change_desc.description)[0]
2406
2407 assert change_desc
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +00002408 SaveDescriptionBackup(change_desc)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002409 commits = RunGitSilent(['rev-list', '%s..%s' % (parent,
2410 ref_to_push)]).splitlines()
2411 if len(commits) > 1:
2412 print('WARNING: This will upload %d commits. Run the following command '
2413 'to see which commits will be uploaded: ' % len(commits))
2414 print('git log %s..%s' % (parent, ref_to_push))
2415 print('You can also use `git squash-branch` to squash these into a '
2416 'single commit.')
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002417 confirm_or_exit(action='upload')
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002418
Aaron Gable6dadfbf2017-05-09 14:27:58 -07002419 if options.reviewers or options.tbrs or options.add_owners_to:
2420 change_desc.update_reviewers(options.reviewers, options.tbrs,
2421 options.add_owners_to, change)
2422
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00002423 reviewers = sorted(change_desc.get_reviewers())
Edward Lemur4508b422019-10-03 21:56:35 +00002424 cc = []
2425 # Add CCs from WATCHLISTS and rietveld.cc git config unless this is
2426 # the initial upload, the CL is private, or auto-CCing has ben disabled.
2427 if not (self.GetIssue() or options.private or options.no_autocc):
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00002428 cc = self.GetCCList().split(',')
Edward Lemur4508b422019-10-03 21:56:35 +00002429 # Add cc's from the --cc flag.
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00002430 if options.cc:
2431 cc.extend(options.cc)
Edward Lemur79d4f992019-11-11 23:49:02 +00002432 cc = [email.strip() for email in cc if email.strip()]
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00002433 if change_desc.get_cced():
2434 cc.extend(change_desc.get_cced())
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00002435 if self._GetGerritHost() == 'chromium-review.googlesource.com':
2436 valid_accounts = set(reviewers + cc)
2437 # TODO(crbug/877717): relax this for all hosts.
2438 else:
2439 valid_accounts = gerrit_util.ValidAccounts(
2440 self._GetGerritHost(), reviewers + cc)
Andrii Shyshkalovf170af42018-10-30 07:00:44 +00002441 logging.info('accounts %s are recognized, %s invalid',
2442 sorted(valid_accounts),
2443 set(reviewers + cc).difference(set(valid_accounts)))
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00002444
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00002445 # Extra options that can be specified at push time. Doc:
2446 # https://gerrit-review.googlesource.com/Documentation/user-upload.html
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00002447 refspec_opts = []
Andrii Shyshkalov2d8a2072017-04-10 15:02:18 +02002448
Aaron Gable844cf292017-06-28 11:32:59 -07002449 # By default, new changes are started in WIP mode, and subsequent patchsets
2450 # don't send email. At any time, passing --send-mail will mark the change
2451 # ready and send email for that particular patch.
Aaron Gableafd52772017-06-27 16:40:10 -07002452 if options.send_mail:
2453 refspec_opts.append('ready')
Aaron Gable844cf292017-06-28 11:32:59 -07002454 refspec_opts.append('notify=ALL')
Jamie Madill276da0b2018-04-27 14:41:20 -04002455 elif not self.GetIssue() and options.squash:
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08002456 refspec_opts.append('wip')
Aaron Gableafd52772017-06-27 16:40:10 -07002457 else:
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08002458 refspec_opts.append('notify=NONE')
Aaron Gable70f4e242017-06-26 10:45:59 -07002459
Andrii Shyshkalov2d8a2072017-04-10 15:02:18 +02002460 # TODO(tandrii): options.message should be posted as a comment
Aaron Gablee5adf612017-07-14 10:43:58 -07002461 # if --send-mail is set on non-initial upload as Rietveld used to do it.
Andrii Shyshkalov2d8a2072017-04-10 15:02:18 +02002462
Aaron Gable9b713dd2016-12-14 16:04:21 -08002463 if title:
Nick Carter8692b182017-11-06 16:30:38 -08002464 # Punctuation and whitespace in |title| must be percent-encoded.
2465 refspec_opts.append('m=' + gerrit_util.PercentEncodeForGitRef(title))
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00002466
agablec6787972016-09-09 16:13:34 -07002467 if options.private:
Aaron Gableb02daf02017-05-23 11:53:46 -07002468 refspec_opts.append('private')
agablec6787972016-09-09 16:13:34 -07002469
Andrii Shyshkalov2f727912018-10-15 17:02:33 +00002470 for r in sorted(reviewers):
2471 if r in valid_accounts:
2472 refspec_opts.append('r=%s' % r)
2473 reviewers.remove(r)
2474 else:
2475 # TODO(tandrii): this should probably be a hard failure.
2476 print('WARNING: reviewer %s doesn\'t have a Gerrit account, skipping'
2477 % r)
2478 for c in sorted(cc):
2479 # refspec option will be rejected if cc doesn't correspond to an
2480 # account, even though REST call to add such arbitrary cc may succeed.
2481 if c in valid_accounts:
2482 refspec_opts.append('cc=%s' % c)
2483 cc.remove(c)
2484
rmistry9eadede2016-09-19 11:22:43 -07002485 if options.topic:
2486 # Documentation on Gerrit topics is here:
2487 # https://gerrit-review.googlesource.com/Documentation/user-upload.html#topic
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00002488 refspec_opts.append('topic=%s' % options.topic)
rmistry9eadede2016-09-19 11:22:43 -07002489
Edward Lemur687ca902018-12-05 02:30:30 +00002490 if options.enable_auto_submit:
2491 refspec_opts.append('l=Auto-Submit+1')
2492 if options.use_commit_queue:
2493 refspec_opts.append('l=Commit-Queue+2')
2494 elif options.cq_dry_run:
2495 refspec_opts.append('l=Commit-Queue+1')
2496
2497 if change_desc.get_reviewers(tbr_only=True):
2498 score = gerrit_util.GetCodeReviewTbrScore(
2499 self._GetGerritHost(),
2500 self._GetGerritProject())
2501 refspec_opts.append('l=Code-Review+%s' % score)
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00002502
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08002503 # Gerrit sorts hashtags, so order is not important.
Nodir Turakulov23b82142017-11-16 11:04:25 -08002504 hashtags = {change_desc.sanitize_hash_tag(t) for t in options.hashtags}
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08002505 if not self.GetIssue():
Nodir Turakulov23b82142017-11-16 11:04:25 -08002506 hashtags.update(change_desc.get_hash_tags())
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08002507 refspec_opts += ['hashtag=%s' % t for t in sorted(hashtags)]
2508
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00002509 refspec_suffix = ''
2510 if refspec_opts:
2511 refspec_suffix = '%' + ','.join(refspec_opts)
2512 assert ' ' not in refspec_suffix, (
2513 'spaces not allowed in refspec: "%s"' % refspec_suffix)
2514 refspec = '%s:refs/for/%s%s' % (ref_to_push, branch, refspec_suffix)
2515
Edward Lemur1b52d872019-05-09 21:12:12 +00002516 git_push_metadata = {
2517 'gerrit_host': self._GetGerritHost(),
2518 'title': title or '<untitled>',
2519 'change_id': change_id,
2520 'description': change_desc.description,
2521 }
2522 push_stdout = self._RunGitPushWithTraces(
2523 change_desc, refspec, refspec_opts, git_push_metadata)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002524
2525 if options.squash:
Aaron Gable289b4312017-09-13 14:06:16 -07002526 regex = re.compile(r'remote:\s+https?://[\w\-\.\+\/#]*/(\d+)\s.*')
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002527 change_numbers = [m.group(1)
2528 for m in map(regex.match, push_stdout.splitlines())
2529 if m]
2530 if len(change_numbers) != 1:
2531 DieWithError(
2532 ('Created|Updated %d issues on Gerrit, but only 1 expected.\n'
Christopher Lamf732cd52017-01-24 12:40:11 +11002533 'Change-Id: %s') % (len(change_numbers), change_id), change_desc)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002534 self.SetIssue(change_numbers[0])
tandrii5d48c322016-08-18 16:19:37 -07002535 self._GitSetBranchConfigValue('gerritsquashhash', ref_to_push)
tandrii88189772016-09-29 04:29:57 -07002536
Andrii Shyshkalov2f727912018-10-15 17:02:33 +00002537 if self.GetIssue() and (reviewers or cc):
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00002538 # GetIssue() is not set in case of non-squash uploads according to tests.
2539 # TODO(agable): non-squash uploads in git cl should be removed.
2540 gerrit_util.AddReviewers(
2541 self._GetGerritHost(),
Andrii Shyshkalovd06cc782018-08-23 17:24:19 +00002542 self._GerritChangeIdentifier(),
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00002543 reviewers, cc,
2544 notify=bool(options.send_mail))
Aaron Gable6dadfbf2017-05-09 14:27:58 -07002545
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002546 return 0
2547
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002548 def _ComputeParent(self, remote, upstream_branch, custom_cl_base, force,
2549 change_desc):
2550 """Computes parent of the generated commit to be uploaded to Gerrit.
2551
2552 Returns revision or a ref name.
2553 """
2554 if custom_cl_base:
2555 # Try to avoid creating additional unintended CLs when uploading, unless
2556 # user wants to take this risk.
2557 local_ref_of_target_remote = self.GetRemoteBranch()[1]
2558 code, _ = RunGitWithCode(['merge-base', '--is-ancestor', custom_cl_base,
2559 local_ref_of_target_remote])
2560 if code == 1:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002561 print('\nWARNING: Manually specified base of this CL `%s` '
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002562 'doesn\'t seem to belong to target remote branch `%s`.\n\n'
2563 'If you proceed with upload, more than 1 CL may be created by '
2564 'Gerrit as a result, in turn confusing or crashing git cl.\n\n'
2565 'If you are certain that specified base `%s` has already been '
2566 'uploaded to Gerrit as another CL, you may proceed.\n' %
2567 (custom_cl_base, local_ref_of_target_remote, custom_cl_base))
2568 if not force:
2569 confirm_or_exit(
2570 'Do you take responsibility for cleaning up potential mess '
2571 'resulting from proceeding with upload?',
2572 action='upload')
2573 return custom_cl_base
2574
Aaron Gablef97e33d2017-03-30 15:44:27 -07002575 if remote != '.':
2576 return self.GetCommonAncestorWithUpstream()
2577
2578 # If our upstream branch is local, we base our squashed commit on its
2579 # squashed version.
2580 upstream_branch_name = scm.GIT.ShortBranchName(upstream_branch)
2581
Aaron Gablef97e33d2017-03-30 15:44:27 -07002582 if upstream_branch_name == 'master':
Aaron Gable0bbd1c22017-05-08 14:37:08 -07002583 return self.GetCommonAncestorWithUpstream()
Aaron Gablef97e33d2017-03-30 15:44:27 -07002584
2585 # Check the squashed hash of the parent.
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002586 # TODO(tandrii): consider checking parent change in Gerrit and using its
2587 # hash if tree hash of latest parent revision (patchset) in Gerrit matches
2588 # the tree hash of the parent branch. The upside is less likely bogus
2589 # requests to reupload parent change just because it's uploadhash is
2590 # missing, yet the downside likely exists, too (albeit unknown to me yet).
Aaron Gablef97e33d2017-03-30 15:44:27 -07002591 parent = RunGit(['config',
2592 'branch.%s.gerritsquashhash' % upstream_branch_name],
2593 error_ok=True).strip()
2594 # Verify that the upstream branch has been uploaded too, otherwise
2595 # Gerrit will create additional CLs when uploading.
2596 if not parent or (RunGitSilent(['rev-parse', upstream_branch + ':']) !=
2597 RunGitSilent(['rev-parse', parent + ':'])):
2598 DieWithError(
2599 '\nUpload upstream branch %s first.\n'
2600 'It is likely that this branch has been rebased since its last '
2601 'upload, so you just need to upload it again.\n'
2602 '(If you uploaded it with --no-squash, then branch dependencies '
2603 'are not supported, and you should reupload with --squash.)'
2604 % upstream_branch_name,
2605 change_desc)
2606 return parent
2607
tandrii@chromium.org8930b3d2016-04-13 14:47:02 +00002608 def _AddChangeIdToCommitMessage(self, options, args):
2609 """Re-commits using the current message, assumes the commit hook is in
2610 place.
2611 """
Andrii Shyshkalovb07575f2018-10-16 06:16:21 +00002612 log_desc = options.message or _create_description_from_log(args)
tandrii@chromium.org8930b3d2016-04-13 14:47:02 +00002613 git_command = ['commit', '--amend', '-m', log_desc]
2614 RunGit(git_command)
Andrii Shyshkalovb07575f2018-10-16 06:16:21 +00002615 new_log_desc = _create_description_from_log(args)
tandrii@chromium.org8930b3d2016-04-13 14:47:02 +00002616 if git_footers.get_footer_change_id(new_log_desc):
vapiera7fbd5a2016-06-16 09:17:49 -07002617 print('git-cl: Added Change-Id to commit message.')
tandrii@chromium.org8930b3d2016-04-13 14:47:02 +00002618 return new_log_desc
2619 else:
tandrii@chromium.orgb067ec52016-05-31 15:24:44 +00002620 DieWithError('ERROR: Gerrit commit-msg hook not installed.')
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002621
tandriie113dfd2016-10-11 10:20:12 -07002622 def CannotTriggerTryJobReason(self):
tandrii8c5a3532016-11-04 07:52:02 -07002623 try:
2624 data = self._GetChangeDetail()
Aaron Gablea45ee112016-11-22 15:14:38 -08002625 except GerritChangeNotExists:
2626 return 'Gerrit doesn\'t know about your change %s' % self.GetIssue()
tandrii8c5a3532016-11-04 07:52:02 -07002627
2628 if data['status'] in ('ABANDONED', 'MERGED'):
2629 return 'CL %s is closed' % self.GetIssue()
2630
Edward Lemurd4d1ba42019-09-20 21:46:37 +00002631 def GetGerritChange(self, patchset=None):
2632 """Returns a buildbucket.v2.GerritChange message for the current issue."""
Edward Lemur79d4f992019-11-11 23:49:02 +00002633 host = urllib.parse.urlparse(self.GetCodereviewServer()).hostname
Edward Lemurd4d1ba42019-09-20 21:46:37 +00002634 issue = self.GetIssue()
Edward Lemur2c210a42019-09-16 23:58:35 +00002635 patchset = int(patchset or self.GetPatchset())
Edward Lemurd4d1ba42019-09-20 21:46:37 +00002636 data = self._GetChangeDetail(['ALL_REVISIONS'])
2637
2638 assert host and issue and patchset, 'CL must be uploaded first'
2639
2640 has_patchset = any(
2641 int(revision_data['_number']) == patchset
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00002642 for revision_data in data['revisions'].values())
Edward Lemurd4d1ba42019-09-20 21:46:37 +00002643 if not has_patchset:
Aaron Gablea45ee112016-11-22 15:14:38 -08002644 raise Exception('Patchset %d is not known in Gerrit change %d' %
tandrii8c5a3532016-11-04 07:52:02 -07002645 (patchset, self.GetIssue()))
Edward Lemurd4d1ba42019-09-20 21:46:37 +00002646
tandrii8c5a3532016-11-04 07:52:02 -07002647 return {
Edward Lemurd4d1ba42019-09-20 21:46:37 +00002648 'host': host,
2649 'change': issue,
2650 'project': data['project'],
2651 'patchset': patchset,
tandrii8c5a3532016-11-04 07:52:02 -07002652 }
tandriie113dfd2016-10-11 10:20:12 -07002653
tandriide281ae2016-10-12 06:02:30 -07002654 def GetIssueOwner(self):
tandrii8c5a3532016-11-04 07:52:02 -07002655 return self._GetChangeDetail(['DETAILED_ACCOUNTS'])['owner']['email']
tandriide281ae2016-10-12 06:02:30 -07002656
Edward Lemur707d70b2018-02-07 00:50:14 +01002657 def GetReviewers(self):
2658 details = self._GetChangeDetail(['DETAILED_ACCOUNTS'])
Mohamed Heikal171c0742018-11-09 20:38:51 +00002659 return [r['email'] for r in details['reviewers'].get('REVIEWER', [])]
Edward Lemur707d70b2018-02-07 00:50:14 +01002660
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002661
tandriif9aefb72016-07-01 09:06:51 -07002662def _get_bug_line_values(default_project, bugs):
2663 """Given default_project and comma separated list of bugs, yields bug line
2664 values.
2665
2666 Each bug can be either:
2667 * a number, which is combined with default_project
2668 * string, which is left as is.
2669
2670 This function may produce more than one line, because bugdroid expects one
2671 project per line.
2672
2673 >>> list(_get_bug_line_values('v8', '123,chromium:789'))
2674 ['v8:123', 'chromium:789']
2675 """
2676 default_bugs = []
2677 others = []
2678 for bug in bugs.split(','):
2679 bug = bug.strip()
2680 if bug:
2681 try:
2682 default_bugs.append(int(bug))
2683 except ValueError:
2684 others.append(bug)
2685
2686 if default_bugs:
2687 default_bugs = ','.join(map(str, default_bugs))
2688 if default_project:
2689 yield '%s:%s' % (default_project, default_bugs)
2690 else:
2691 yield default_bugs
2692 for other in sorted(others):
2693 # Don't bother finding common prefixes, CLs with >2 bugs are very very rare.
2694 yield other
2695
2696
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00002697class ChangeDescription(object):
2698 """Contains a parsed form of the change description."""
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00002699 R_LINE = r'^[ \t]*(TBR|R)[ \t]*=[ \t]*(.*?)[ \t]*$'
bradnelsond975b302016-10-23 12:20:23 -07002700 CC_LINE = r'^[ \t]*(CC)[ \t]*=[ \t]*(.*?)[ \t]*$'
Aaron Gable3a16ed12017-03-23 10:51:55 -07002701 BUG_LINE = r'^[ \t]*(?:(BUG)[ \t]*=|Bug:)[ \t]*(.*?)[ \t]*$'
Dan Beamd8b04ca2019-10-10 21:23:26 +00002702 FIXED_LINE = r'^[ \t]*Fixed[ \t]*:[ \t]*(.*?)[ \t]*$'
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01002703 CHERRY_PICK_LINE = r'^\(cherry picked from commit [a-fA-F0-9]{40}\)$'
Nodir Turakulov23b82142017-11-16 11:04:25 -08002704 STRIP_HASH_TAG_PREFIX = r'^(\s*(revert|reland)( "|:)?\s*)*'
2705 BRACKET_HASH_TAG = r'\s*\[([^\[\]]+)\]'
Anthony Polito02b5af32019-12-02 19:49:47 +00002706 COLON_SEPARATED_HASH_TAG = r'^([a-zA-Z0-9_\- ]+):($|[^:])'
Nodir Turakulov23b82142017-11-16 11:04:25 -08002707 BAD_HASH_TAG_CHUNK = r'[^a-zA-Z0-9]+'
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00002708
Dan Beamd8b04ca2019-10-10 21:23:26 +00002709 def __init__(self, description, bug=None, fixed=None):
agable@chromium.org42c20792013-09-12 17:34:49 +00002710 self._description_lines = (description or '').strip().splitlines()
Anthony Polito8b955342019-09-24 19:01:36 +00002711 if bug:
2712 regexp = re.compile(self.BUG_LINE)
2713 prefix = settings.GetBugPrefix()
2714 if not any((regexp.match(line) for line in self._description_lines)):
2715 values = list(_get_bug_line_values(prefix, bug))
2716 self.append_footer('Bug: %s' % ', '.join(values))
Dan Beamd8b04ca2019-10-10 21:23:26 +00002717 if fixed:
2718 regexp = re.compile(self.FIXED_LINE)
2719 prefix = settings.GetBugPrefix()
2720 if not any((regexp.match(line) for line in self._description_lines)):
2721 values = list(_get_bug_line_values(prefix, fixed))
2722 self.append_footer('Fixed: %s' % ', '.join(values))
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002723
agable@chromium.org42c20792013-09-12 17:34:49 +00002724 @property # www.logilab.org/ticket/89786
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -08002725 def description(self): # pylint: disable=method-hidden
agable@chromium.org42c20792013-09-12 17:34:49 +00002726 return '\n'.join(self._description_lines)
2727
2728 def set_description(self, desc):
2729 if isinstance(desc, basestring):
2730 lines = desc.splitlines()
2731 else:
2732 lines = [line.rstrip() for line in desc]
2733 while lines and not lines[0]:
2734 lines.pop(0)
2735 while lines and not lines[-1]:
2736 lines.pop(-1)
2737 self._description_lines = lines
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002738
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002739 def update_reviewers(self, reviewers, tbrs, add_owners_to=None, change=None):
2740 """Rewrites the R=/TBR= line(s) as a single line each.
2741
2742 Args:
2743 reviewers (list(str)) - list of additional emails to use for reviewers.
2744 tbrs (list(str)) - list of additional emails to use for TBRs.
2745 add_owners_to (None|'R'|'TBR') - Pass to do an OWNERS lookup for files in
2746 the change that are missing OWNER coverage. If this is not None, you
2747 must also pass a value for `change`.
2748 change (Change) - The Change that should be used for OWNERS lookups.
2749 """
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002750 assert isinstance(reviewers, list), reviewers
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002751 assert isinstance(tbrs, list), tbrs
2752
Robert Iannuccif2708bd2017-04-17 15:49:02 -07002753 assert add_owners_to in (None, 'TBR', 'R'), add_owners_to
Robert Iannuccia28592e2017-04-18 13:14:49 -07002754 assert not add_owners_to or change, add_owners_to
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002755
2756 if not reviewers and not tbrs and not add_owners_to:
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002757 return
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002758
2759 reviewers = set(reviewers)
2760 tbrs = set(tbrs)
2761 LOOKUP = {
2762 'TBR': tbrs,
2763 'R': reviewers,
2764 }
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002765
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002766 # Get the set of R= and TBR= lines and remove them from the description.
agable@chromium.org42c20792013-09-12 17:34:49 +00002767 regexp = re.compile(self.R_LINE)
2768 matches = [regexp.match(line) for line in self._description_lines]
2769 new_desc = [l for i, l in enumerate(self._description_lines)
2770 if not matches[i]]
2771 self.set_description(new_desc)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002772
agable@chromium.org42c20792013-09-12 17:34:49 +00002773 # Construct new unified R= and TBR= lines.
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002774
2775 # First, update tbrs/reviewers with names from the R=/TBR= lines (if any).
agable@chromium.org42c20792013-09-12 17:34:49 +00002776 for match in matches:
2777 if not match:
2778 continue
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002779 LOOKUP[match.group(1)].update(cleanup_list([match.group(2).strip()]))
2780
2781 # Next, maybe fill in OWNERS coverage gaps to either tbrs/reviewers.
Robert Iannuccif2708bd2017-04-17 15:49:02 -07002782 if add_owners_to:
piman@chromium.org336f9122014-09-04 02:16:55 +00002783 owners_db = owners.Database(change.RepositoryRoot(),
Jochen Eisinger72606f82017-04-04 10:44:18 +02002784 fopen=file, os_path=os.path)
piman@chromium.org336f9122014-09-04 02:16:55 +00002785 missing_files = owners_db.files_not_covered_by(change.LocalPaths(),
Robert Iannucci100aa212017-04-18 17:28:26 -07002786 (tbrs | reviewers))
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002787 LOOKUP[add_owners_to].update(
2788 owners_db.reviewers_for(missing_files, change.author_email))
Robert Iannuccif2708bd2017-04-17 15:49:02 -07002789
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002790 # If any folks ended up in both groups, remove them from tbrs.
2791 tbrs -= reviewers
Robert Iannuccif2708bd2017-04-17 15:49:02 -07002792
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002793 new_r_line = 'R=' + ', '.join(sorted(reviewers)) if reviewers else None
2794 new_tbr_line = 'TBR=' + ', '.join(sorted(tbrs)) if tbrs else None
agable@chromium.org42c20792013-09-12 17:34:49 +00002795
2796 # Put the new lines in the description where the old first R= line was.
2797 line_loc = next((i for i, match in enumerate(matches) if match), -1)
2798 if 0 <= line_loc < len(self._description_lines):
2799 if new_tbr_line:
2800 self._description_lines.insert(line_loc, new_tbr_line)
2801 if new_r_line:
2802 self._description_lines.insert(line_loc, new_r_line)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002803 else:
agable@chromium.org42c20792013-09-12 17:34:49 +00002804 if new_r_line:
2805 self.append_footer(new_r_line)
2806 if new_tbr_line:
2807 self.append_footer(new_tbr_line)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002808
Andrii Shyshkalov71f0da32019-07-15 22:45:18 +00002809 def set_preserve_tryjobs(self):
2810 """Ensures description footer contains 'Cq-Do-Not-Cancel-Tryjobs: true'."""
2811 footers = git_footers.parse_footers(self.description)
2812 for v in footers.get('Cq-Do-Not-Cancel-Tryjobs', []):
2813 if v.lower() == 'true':
2814 return
2815 self.append_footer('Cq-Do-Not-Cancel-Tryjobs: true')
2816
Anthony Polito8b955342019-09-24 19:01:36 +00002817 def prompt(self):
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002818 """Asks the user to update the description."""
agable@chromium.org42c20792013-09-12 17:34:49 +00002819 self.set_description([
2820 '# Enter a description of the change.',
2821 '# This will be displayed on the codereview site.',
2822 '# The first line will also be used as the subject of the review.',
alancutter@chromium.orgbd1073e2013-06-01 00:34:38 +00002823 '#--------------------This line is 72 characters long'
agable@chromium.org42c20792013-09-12 17:34:49 +00002824 '--------------------',
2825 ] + self._description_lines)
Dan Beamd8b04ca2019-10-10 21:23:26 +00002826 bug_regexp = re.compile(self.BUG_LINE)
2827 fixed_regexp = re.compile(self.FIXED_LINE)
Jonas Termansend0f79112019-03-22 15:28:26 +00002828 prefix = settings.GetBugPrefix()
Dan Beamd8b04ca2019-10-10 21:23:26 +00002829 has_issue = lambda l: bug_regexp.match(l) or fixed_regexp.match(l)
2830 if not any((has_issue(line) for line in self._description_lines)):
Anthony Polito8b955342019-09-24 19:01:36 +00002831 self.append_footer('Bug: %s' % prefix)
tandriif9aefb72016-07-01 09:06:51 -07002832
agable@chromium.org42c20792013-09-12 17:34:49 +00002833 content = gclient_utils.RunEditor(self.description, True,
Edward Lemur79d4f992019-11-11 23:49:02 +00002834 git_editor=settings.GetGitEditor())
maruel@chromium.org0e0436a2011-10-25 13:32:41 +00002835 if not content:
2836 DieWithError('Running editor failed')
agable@chromium.org42c20792013-09-12 17:34:49 +00002837 lines = content.splitlines()
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002838
Bruce Dawson2377b012018-01-11 16:46:49 -08002839 # Strip off comments and default inserted "Bug:" line.
2840 clean_lines = [line.rstrip() for line in lines if not
Jonas Termansend0f79112019-03-22 15:28:26 +00002841 (line.startswith('#') or
2842 line.rstrip() == "Bug:" or
2843 line.rstrip() == "Bug: " + prefix)]
agable@chromium.org42c20792013-09-12 17:34:49 +00002844 if not clean_lines:
maruel@chromium.org0e0436a2011-10-25 13:32:41 +00002845 DieWithError('No CL description, aborting')
agable@chromium.org42c20792013-09-12 17:34:49 +00002846 self.set_description(clean_lines)
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00002847
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002848 def append_footer(self, line):
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002849 """Adds a footer line to the description.
2850
2851 Differentiates legacy "KEY=xxx" footers (used to be called tags) and
2852 Gerrit's footers in the form of "Footer-Key: footer any value" and ensures
2853 that Gerrit footers are always at the end.
2854 """
2855 parsed_footer_line = git_footers.parse_footer(line)
2856 if parsed_footer_line:
2857 # Line is a gerrit footer in the form: Footer-Key: any value.
2858 # Thus, must be appended observing Gerrit footer rules.
2859 self.set_description(
2860 git_footers.add_footer(self.description,
2861 key=parsed_footer_line[0],
2862 value=parsed_footer_line[1]))
2863 return
2864
2865 if not self._description_lines:
2866 self._description_lines.append(line)
2867 return
2868
2869 top_lines, gerrit_footers, _ = git_footers.split_footers(self.description)
2870 if gerrit_footers:
2871 # git_footers.split_footers ensures that there is an empty line before
2872 # actual (gerrit) footers, if any. We have to keep it that way.
2873 assert top_lines and top_lines[-1] == ''
2874 top_lines, separator = top_lines[:-1], top_lines[-1:]
2875 else:
2876 separator = [] # No need for separator if there are no gerrit_footers.
2877
2878 prev_line = top_lines[-1] if top_lines else ''
2879 if (not presubmit_support.Change.TAG_LINE_RE.match(prev_line) or
2880 not presubmit_support.Change.TAG_LINE_RE.match(line)):
2881 top_lines.append('')
2882 top_lines.append(line)
2883 self._description_lines = top_lines + separator + gerrit_footers
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00002884
tandrii99a72f22016-08-17 14:33:24 -07002885 def get_reviewers(self, tbr_only=False):
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002886 """Retrieves the list of reviewers."""
agable@chromium.org42c20792013-09-12 17:34:49 +00002887 matches = [re.match(self.R_LINE, line) for line in self._description_lines]
tandrii99a72f22016-08-17 14:33:24 -07002888 reviewers = [match.group(2).strip()
2889 for match in matches
2890 if match and (not tbr_only or match.group(1).upper() == 'TBR')]
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002891 return cleanup_list(reviewers)
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00002892
bradnelsond975b302016-10-23 12:20:23 -07002893 def get_cced(self):
2894 """Retrieves the list of reviewers."""
2895 matches = [re.match(self.CC_LINE, line) for line in self._description_lines]
2896 cced = [match.group(2).strip() for match in matches if match]
2897 return cleanup_list(cced)
2898
Nodir Turakulov23b82142017-11-16 11:04:25 -08002899 def get_hash_tags(self):
2900 """Extracts and sanitizes a list of Gerrit hashtags."""
2901 subject = (self._description_lines or ('',))[0]
2902 subject = re.sub(
2903 self.STRIP_HASH_TAG_PREFIX, '', subject, flags=re.IGNORECASE)
2904
2905 tags = []
2906 start = 0
2907 bracket_exp = re.compile(self.BRACKET_HASH_TAG)
2908 while True:
2909 m = bracket_exp.match(subject, start)
2910 if not m:
2911 break
2912 tags.append(self.sanitize_hash_tag(m.group(1)))
2913 start = m.end()
2914
2915 if not tags:
2916 # Try "Tag: " prefix.
2917 m = re.match(self.COLON_SEPARATED_HASH_TAG, subject)
2918 if m:
2919 tags.append(self.sanitize_hash_tag(m.group(1)))
2920 return tags
2921
2922 @classmethod
2923 def sanitize_hash_tag(cls, tag):
2924 """Returns a sanitized Gerrit hash tag.
2925
2926 A sanitized hashtag can be used as a git push refspec parameter value.
2927 """
2928 return re.sub(cls.BAD_HASH_TAG_CHUNK, '-', tag).strip('-').lower()
2929
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01002930 def update_with_git_number_footers(self, parent_hash, parent_msg, dest_ref):
2931 """Updates this commit description given the parent.
2932
2933 This is essentially what Gnumbd used to do.
2934 Consult https://goo.gl/WMmpDe for more details.
2935 """
2936 assert parent_msg # No, orphan branch creation isn't supported.
2937 assert parent_hash
2938 assert dest_ref
2939 parent_footer_map = git_footers.parse_footers(parent_msg)
2940 # This will also happily parse svn-position, which GnumbD is no longer
2941 # supporting. While we'd generate correct footers, the verifier plugin
2942 # installed in Gerrit will block such commit (ie git push below will fail).
2943 parent_position = git_footers.get_position(parent_footer_map)
2944
2945 # Cherry-picks may have last line obscuring their prior footers,
2946 # from git_footers perspective. This is also what Gnumbd did.
2947 cp_line = None
2948 if (self._description_lines and
2949 re.match(self.CHERRY_PICK_LINE, self._description_lines[-1])):
2950 cp_line = self._description_lines.pop()
2951
Andrii Shyshkalovde37c012017-07-06 21:06:50 +02002952 top_lines, footer_lines, _ = git_footers.split_footers(self.description)
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01002953
2954 # Original-ify all Cr- footers, to avoid re-lands, cherry-picks, or just
2955 # user interference with actual footers we'd insert below.
Andrii Shyshkalovde37c012017-07-06 21:06:50 +02002956 for i, line in enumerate(footer_lines):
2957 k, v = git_footers.parse_footer(line) or (None, None)
2958 if k and k.startswith('Cr-'):
2959 footer_lines[i] = '%s: %s' % ('Cr-Original-' + k[len('Cr-'):], v)
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01002960
2961 # Add Position and Lineage footers based on the parent.
Andrii Shyshkalovb5effa12016-12-14 19:35:12 +01002962 lineage = list(reversed(parent_footer_map.get('Cr-Branched-From', [])))
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01002963 if parent_position[0] == dest_ref:
2964 # Same branch as parent.
2965 number = int(parent_position[1]) + 1
2966 else:
2967 number = 1 # New branch, and extra lineage.
2968 lineage.insert(0, '%s-%s@{#%d}' % (parent_hash, parent_position[0],
2969 int(parent_position[1])))
2970
Andrii Shyshkalovde37c012017-07-06 21:06:50 +02002971 footer_lines.append('Cr-Commit-Position: %s@{#%d}' % (dest_ref, number))
2972 footer_lines.extend('Cr-Branched-From: %s' % v for v in lineage)
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01002973
2974 self._description_lines = top_lines
2975 if cp_line:
2976 self._description_lines.append(cp_line)
2977 if self._description_lines[-1] != '':
2978 self._description_lines.append('') # Ensure footer separator.
Andrii Shyshkalovde37c012017-07-06 21:06:50 +02002979 self._description_lines.extend(footer_lines)
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01002980
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00002981
Aaron Gablea1bab272017-04-11 16:38:18 -07002982def get_approving_reviewers(props, disapproval=False):
maruel@chromium.orge52678e2013-04-26 18:34:44 +00002983 """Retrieves the reviewers that approved a CL from the issue properties with
2984 messages.
2985
2986 Note that the list may contain reviewers that are not committer, thus are not
2987 considered by the CQ.
Aaron Gablea1bab272017-04-11 16:38:18 -07002988
2989 If disapproval is True, instead returns reviewers who 'not lgtm'd the CL.
maruel@chromium.orge52678e2013-04-26 18:34:44 +00002990 """
Aaron Gablea1bab272017-04-11 16:38:18 -07002991 approval_type = 'disapproval' if disapproval else 'approval'
maruel@chromium.orge52678e2013-04-26 18:34:44 +00002992 return sorted(
2993 set(
2994 message['sender']
2995 for message in props['messages']
Aaron Gablea1bab272017-04-11 16:38:18 -07002996 if message[approval_type] and message['sender'] in props['reviewers']
maruel@chromium.orge52678e2013-04-26 18:34:44 +00002997 )
2998 )
2999
3000
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003001def FindCodereviewSettingsFile(filename='codereview.settings'):
3002 """Finds the given file starting in the cwd and going up.
3003
3004 Only looks up to the top of the repository unless an
3005 'inherit-review-settings-ok' file exists in the root of the repository.
3006 """
3007 inherit_ok_file = 'inherit-review-settings-ok'
3008 cwd = os.getcwd()
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00003009 root = settings.GetRoot()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003010 if os.path.isfile(os.path.join(root, inherit_ok_file)):
3011 root = '/'
3012 while True:
3013 if filename in os.listdir(cwd):
3014 if os.path.isfile(os.path.join(cwd, filename)):
3015 return open(os.path.join(cwd, filename))
3016 if cwd == root:
3017 break
3018 cwd = os.path.dirname(cwd)
3019
3020
3021def LoadCodereviewSettingsFromFile(fileobj):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003022 """Parses a codereview.settings file and updates hooks."""
maruel@chromium.org99ac1c52012-01-16 14:52:12 +00003023 keyvals = gclient_utils.ParseCodereviewSettingsContent(fileobj.read())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003024
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003025 def SetProperty(name, setting, unset_error_ok=False):
3026 fullname = 'rietveld.' + name
3027 if setting in keyvals:
3028 RunGit(['config', fullname, keyvals[setting]])
3029 else:
3030 RunGit(['config', '--unset-all', fullname], error_ok=unset_error_ok)
3031
tandrii48df5812016-10-17 03:55:37 -07003032 if not keyvals.get('GERRIT_HOST', False):
3033 SetProperty('server', 'CODE_REVIEW_SERVER')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003034 # Only server setting is required. Other settings can be absent.
3035 # In that case, we ignore errors raised during option deletion attempt.
3036 SetProperty('cc', 'CC_LIST', unset_error_ok=True)
3037 SetProperty('tree-status-url', 'STATUS', unset_error_ok=True)
3038 SetProperty('viewvc-url', 'VIEW_VC', unset_error_ok=True)
rmistry@google.com90752582014-01-14 21:04:50 +00003039 SetProperty('bug-prefix', 'BUG_PREFIX', unset_error_ok=True)
thestig@chromium.org44202a22014-03-11 19:22:18 +00003040 SetProperty('cpplint-regex', 'LINT_REGEX', unset_error_ok=True)
3041 SetProperty('cpplint-ignore-regex', 'LINT_IGNORE_REGEX', unset_error_ok=True)
rmistry@google.com5626a922015-02-26 14:03:30 +00003042 SetProperty('run-post-upload-hook', 'RUN_POST_UPLOAD_HOOK',
3043 unset_error_ok=True)
Jamie Madilldc4d19e2019-10-24 21:50:02 +00003044 SetProperty(
3045 'format-full-by-default', 'FORMAT_FULL_BY_DEFAULT', unset_error_ok=True)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003046
ukai@chromium.org7044efc2013-11-28 01:51:21 +00003047 if 'GERRIT_HOST' in keyvals:
ukai@chromium.orge8077812012-02-03 03:41:46 +00003048 RunGit(['config', 'gerrit.host', keyvals['GERRIT_HOST']])
ukai@chromium.orge8077812012-02-03 03:41:46 +00003049
bauerb@chromium.org54b400c2016-01-14 10:08:25 +00003050 if 'GERRIT_SQUASH_UPLOADS' in keyvals:
tandrii8dd81ea2016-06-16 13:24:23 -07003051 RunGit(['config', 'gerrit.squash-uploads',
3052 keyvals['GERRIT_SQUASH_UPLOADS']])
bauerb@chromium.org54b400c2016-01-14 10:08:25 +00003053
tandrii@chromium.org28253532016-04-14 13:46:56 +00003054 if 'GERRIT_SKIP_ENSURE_AUTHENTICATED' in keyvals:
shinyak@chromium.org00dbccd2016-04-15 07:24:43 +00003055 RunGit(['config', 'gerrit.skip-ensure-authenticated',
tandrii@chromium.org28253532016-04-14 13:46:56 +00003056 keyvals['GERRIT_SKIP_ENSURE_AUTHENTICATED']])
3057
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003058 if 'PUSH_URL_CONFIG' in keyvals and 'ORIGIN_URL_CONFIG' in keyvals:
Andrii Shyshkalov18975322017-01-25 16:44:13 +01003059 # should be of the form
3060 # PUSH_URL_CONFIG: url.ssh://gitrw.chromium.org.pushinsteadof
3061 # ORIGIN_URL_CONFIG: http://src.chromium.org/git
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003062 RunGit(['config', keyvals['PUSH_URL_CONFIG'],
3063 keyvals['ORIGIN_URL_CONFIG']])
3064
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003065
joshua.lock@intel.com426f69b2012-08-02 23:41:49 +00003066def urlretrieve(source, destination):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003067 """Downloads a network object to a local file, like urllib.urlretrieve.
3068
3069 This is necessary because urllib is broken for SSL connections via a proxy.
3070 """
joshua.lock@intel.com426f69b2012-08-02 23:41:49 +00003071 with open(destination, 'w') as f:
Edward Lemur79d4f992019-11-11 23:49:02 +00003072 f.write(urllib.request.urlopen(source).read())
joshua.lock@intel.com426f69b2012-08-02 23:41:49 +00003073
3074
ukai@chromium.org712d6102013-11-27 00:52:58 +00003075def hasSheBang(fname):
3076 """Checks fname is a #! script."""
3077 with open(fname) as f:
3078 return f.read(2).startswith('#!')
3079
3080
bpastene@chromium.org917f0ff2016-04-05 00:45:30 +00003081# TODO(bpastene) Remove once a cleaner fix to crbug.com/600473 presents itself.
3082def DownloadHooks(*args, **kwargs):
3083 pass
3084
3085
tandrii@chromium.org18630d62016-03-04 12:06:02 +00003086def DownloadGerritHook(force):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003087 """Downloads and installs a Gerrit commit-msg hook.
ukai@chromium.org78c4b982012-02-14 02:20:26 +00003088
3089 Args:
3090 force: True to update hooks. False to install hooks if not present.
3091 """
3092 if not settings.GetIsGerrit():
3093 return
ukai@chromium.org712d6102013-11-27 00:52:58 +00003094 src = 'https://gerrit-review.googlesource.com/tools/hooks/commit-msg'
ukai@chromium.org78c4b982012-02-14 02:20:26 +00003095 dst = os.path.join(settings.GetRoot(), '.git', 'hooks', 'commit-msg')
3096 if not os.access(dst, os.X_OK):
3097 if os.path.exists(dst):
3098 if not force:
3099 return
ukai@chromium.org78c4b982012-02-14 02:20:26 +00003100 try:
joshua.lock@intel.com426f69b2012-08-02 23:41:49 +00003101 urlretrieve(src, dst)
ukai@chromium.org712d6102013-11-27 00:52:58 +00003102 if not hasSheBang(dst):
3103 DieWithError('Not a script: %s\n'
3104 'You need to download from\n%s\n'
3105 'into .git/hooks/commit-msg and '
3106 'chmod +x .git/hooks/commit-msg' % (dst, src))
ukai@chromium.org78c4b982012-02-14 02:20:26 +00003107 os.chmod(dst, stat.S_IRUSR | stat.S_IWUSR | stat.S_IXUSR)
3108 except Exception:
3109 if os.path.exists(dst):
3110 os.remove(dst)
ukai@chromium.org712d6102013-11-27 00:52:58 +00003111 DieWithError('\nFailed to download hooks.\n'
3112 'You need to download from\n%s\n'
3113 'into .git/hooks/commit-msg and '
3114 'chmod +x .git/hooks/commit-msg' % src)
ukai@chromium.org78c4b982012-02-14 02:20:26 +00003115
3116
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003117class _GitCookiesChecker(object):
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003118 """Provides facilities for validating and suggesting fixes to .gitcookies."""
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003119
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003120 _GOOGLESOURCE = 'googlesource.com'
3121
3122 def __init__(self):
3123 # Cached list of [host, identity, source], where source is either
3124 # .gitcookies or .netrc.
3125 self._all_hosts = None
3126
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003127 def ensure_configured_gitcookies(self):
3128 """Runs checks and suggests fixes to make git use .gitcookies from default
3129 path."""
3130 default = gerrit_util.CookiesAuthenticator.get_gitcookies_path()
3131 configured_path = RunGitSilent(
3132 ['config', '--global', 'http.cookiefile']).strip()
Andrii Shyshkalov1e250cd2017-05-10 15:39:31 +02003133 configured_path = os.path.expanduser(configured_path)
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003134 if configured_path:
3135 self._ensure_default_gitcookies_path(configured_path, default)
3136 else:
3137 self._configure_gitcookies_path(default)
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003138
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003139 @staticmethod
3140 def _ensure_default_gitcookies_path(configured_path, default_path):
3141 assert configured_path
3142 if configured_path == default_path:
3143 print('git is already configured to use your .gitcookies from %s' %
3144 configured_path)
3145 return
3146
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003147 print('WARNING: You have configured custom path to .gitcookies: %s\n'
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003148 'Gerrit and other depot_tools expect .gitcookies at %s\n' %
3149 (configured_path, default_path))
3150
3151 if not os.path.exists(configured_path):
3152 print('However, your configured .gitcookies file is missing.')
3153 confirm_or_exit('Reconfigure git to use default .gitcookies?',
3154 action='reconfigure')
3155 RunGit(['config', '--global', 'http.cookiefile', default_path])
3156 return
3157
3158 if os.path.exists(default_path):
3159 print('WARNING: default .gitcookies file already exists %s' %
3160 default_path)
3161 DieWithError('Please delete %s manually and re-run git cl creds-check' %
3162 default_path)
3163
3164 confirm_or_exit('Move existing .gitcookies to default location?',
3165 action='move')
3166 shutil.move(configured_path, default_path)
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003167 RunGit(['config', '--global', 'http.cookiefile', default_path])
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003168 print('Moved and reconfigured git to use .gitcookies from %s' %
3169 default_path)
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003170
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003171 @staticmethod
3172 def _configure_gitcookies_path(default_path):
3173 netrc_path = gerrit_util.CookiesAuthenticator.get_netrc_path()
3174 if os.path.exists(netrc_path):
3175 print('You seem to be using outdated .netrc for git credentials: %s' %
3176 netrc_path)
3177 print('This tool will guide you through setting up recommended '
3178 '.gitcookies store for git credentials.\n'
3179 '\n'
3180 'IMPORTANT: If something goes wrong and you decide to go back, do:\n'
3181 ' git config --global --unset http.cookiefile\n'
3182 ' mv %s %s.backup\n\n' % (default_path, default_path))
3183 confirm_or_exit(action='setup .gitcookies')
3184 RunGit(['config', '--global', 'http.cookiefile', default_path])
3185 print('Configured git to use .gitcookies from %s' % default_path)
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003186
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003187 def get_hosts_with_creds(self, include_netrc=False):
3188 if self._all_hosts is None:
3189 a = gerrit_util.CookiesAuthenticator()
3190 self._all_hosts = [
3191 (h, u, s)
3192 for h, u, s in itertools.chain(
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00003193 ((h, u, '.netrc') for h, (u, _, _) in a.netrc.hosts.items()),
3194 ((h, u, '.gitcookies') for h, (u, _) in a.gitcookies.items())
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003195 )
3196 if h.endswith(self._GOOGLESOURCE)
3197 ]
3198
3199 if include_netrc:
3200 return self._all_hosts
3201 return [(h, u, s) for h, u, s in self._all_hosts if s != '.netrc']
3202
3203 def print_current_creds(self, include_netrc=False):
3204 hosts = sorted(self.get_hosts_with_creds(include_netrc=include_netrc))
3205 if not hosts:
3206 print('No Git/Gerrit credentials found')
3207 return
Edward Lemur79d4f992019-11-11 23:49:02 +00003208 lengths = [max(map(len, (row[i] for row in hosts))) for i in range(3)]
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003209 header = [('Host', 'User', 'Which file'),
3210 ['=' * l for l in lengths]]
3211 for row in (header + hosts):
3212 print('\t'.join((('%%+%ds' % l) % s)
3213 for l, s in zip(lengths, row)))
3214
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003215 @staticmethod
3216 def _parse_identity(identity):
Lei Zhangd3f769a2017-12-15 15:16:14 -08003217 """Parses identity "git-<username>.domain" into <username> and domain."""
3218 # Special case: usernames that contain ".", which are generally not
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +02003219 # distinguishable from sub-domains. But we do know typical domains:
3220 if identity.endswith('.chromium.org'):
3221 domain = 'chromium.org'
3222 username = identity[:-len('.chromium.org')]
3223 else:
3224 username, domain = identity.split('.', 1)
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003225 if username.startswith('git-'):
3226 username = username[len('git-'):]
3227 return username, domain
3228
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003229 def _canonical_git_googlesource_host(self, host):
3230 """Normalizes Gerrit hosts (with '-review') to Git host."""
3231 assert host.endswith(self._GOOGLESOURCE)
3232 # Prefix doesn't include '.' at the end.
3233 prefix = host[:-(1 + len(self._GOOGLESOURCE))]
3234 if prefix.endswith('-review'):
3235 prefix = prefix[:-len('-review')]
3236 return prefix + '.' + self._GOOGLESOURCE
3237
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003238 def _canonical_gerrit_googlesource_host(self, host):
3239 git_host = self._canonical_git_googlesource_host(host)
3240 prefix = git_host.split('.', 1)[0]
3241 return prefix + '-review.' + self._GOOGLESOURCE
3242
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003243 def _get_counterpart_host(self, host):
3244 assert host.endswith(self._GOOGLESOURCE)
3245 git = self._canonical_git_googlesource_host(host)
3246 gerrit = self._canonical_gerrit_googlesource_host(git)
3247 return git if gerrit == host else gerrit
3248
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003249 def has_generic_host(self):
3250 """Returns whether generic .googlesource.com has been configured.
3251
3252 Chrome Infra recommends to use explicit ${host}.googlesource.com instead.
3253 """
3254 for host, _, _ in self.get_hosts_with_creds(include_netrc=False):
3255 if host == '.' + self._GOOGLESOURCE:
3256 return True
3257 return False
3258
3259 def _get_git_gerrit_identity_pairs(self):
3260 """Returns map from canonic host to pair of identities (Git, Gerrit).
3261
3262 One of identities might be None, meaning not configured.
3263 """
3264 host_to_identity_pairs = {}
3265 for host, identity, _ in self.get_hosts_with_creds():
3266 canonical = self._canonical_git_googlesource_host(host)
3267 pair = host_to_identity_pairs.setdefault(canonical, [None, None])
3268 idx = 0 if canonical == host else 1
3269 pair[idx] = identity
3270 return host_to_identity_pairs
3271
3272 def get_partially_configured_hosts(self):
3273 return set(
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003274 (host if i1 else self._canonical_gerrit_googlesource_host(host))
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00003275 for host, (i1, i2) in self._get_git_gerrit_identity_pairs().items()
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003276 if None in (i1, i2) and host != '.' + self._GOOGLESOURCE)
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003277
3278 def get_conflicting_hosts(self):
3279 return set(
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003280 host
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00003281 for host, (i1, i2) in self._get_git_gerrit_identity_pairs().items()
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003282 if None not in (i1, i2) and i1 != i2)
3283
3284 def get_duplicated_hosts(self):
3285 counters = collections.Counter(h for h, _, _ in self.get_hosts_with_creds())
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00003286 return set(host for host, count in counters.items() if count > 1)
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003287
3288 _EXPECTED_HOST_IDENTITY_DOMAINS = {
3289 'chromium.googlesource.com': 'chromium.org',
3290 'chrome-internal.googlesource.com': 'google.com',
3291 }
3292
3293 def get_hosts_with_wrong_identities(self):
3294 """Finds hosts which **likely** reference wrong identities.
3295
3296 Note: skips hosts which have conflicting identities for Git and Gerrit.
3297 """
3298 hosts = set()
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00003299 for host, expected in self._EXPECTED_HOST_IDENTITY_DOMAINS.items():
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003300 pair = self._get_git_gerrit_identity_pairs().get(host)
3301 if pair and pair[0] == pair[1]:
3302 _, domain = self._parse_identity(pair[0])
3303 if domain != expected:
3304 hosts.add(host)
3305 return hosts
3306
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003307 @staticmethod
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003308 def _format_hosts(hosts, extra_column_func=None):
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003309 hosts = sorted(hosts)
3310 assert hosts
3311 if extra_column_func is None:
3312 extras = [''] * len(hosts)
3313 else:
3314 extras = [extra_column_func(host) for host in hosts]
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003315 tmpl = '%%-%ds %%-%ds' % (max(map(len, hosts)), max(map(len, extras)))
3316 lines = []
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003317 for he in zip(hosts, extras):
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003318 lines.append(tmpl % he)
3319 return lines
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003320
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003321 def _find_problems(self):
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003322 if self.has_generic_host():
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003323 yield ('.googlesource.com wildcard record detected',
3324 ['Chrome Infrastructure team recommends to list full host names '
3325 'explicitly.'],
3326 None)
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003327
3328 dups = self.get_duplicated_hosts()
3329 if dups:
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003330 yield ('The following hosts were defined twice',
3331 self._format_hosts(dups),
3332 None)
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003333
3334 partial = self.get_partially_configured_hosts()
3335 if partial:
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003336 yield ('Credentials should come in pairs for Git and Gerrit hosts. '
3337 'These hosts are missing',
3338 self._format_hosts(partial, lambda host: 'but %s defined' %
3339 self._get_counterpart_host(host)),
3340 partial)
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003341
3342 conflicting = self.get_conflicting_hosts()
3343 if conflicting:
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003344 yield ('The following Git hosts have differing credentials from their '
3345 'Gerrit counterparts',
3346 self._format_hosts(conflicting, lambda host: '%s vs %s' %
3347 tuple(self._get_git_gerrit_identity_pairs()[host])),
3348 conflicting)
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003349
3350 wrong = self.get_hosts_with_wrong_identities()
3351 if wrong:
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003352 yield ('These hosts likely use wrong identity',
3353 self._format_hosts(wrong, lambda host: '%s but %s recommended' %
3354 (self._get_git_gerrit_identity_pairs()[host][0],
3355 self._EXPECTED_HOST_IDENTITY_DOMAINS[host])),
3356 wrong)
3357
3358 def find_and_report_problems(self):
3359 """Returns True if there was at least one problem, else False."""
3360 found = False
3361 bad_hosts = set()
3362 for title, sublines, hosts in self._find_problems():
3363 if not found:
3364 found = True
3365 print('\n\n.gitcookies problem report:\n')
3366 bad_hosts.update(hosts or [])
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003367 print(' %s%s' % (title, (':' if sublines else '')))
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003368 if sublines:
3369 print()
3370 print(' %s' % '\n '.join(sublines))
3371 print()
3372
3373 if bad_hosts:
3374 assert found
3375 print(' You can manually remove corresponding lines in your %s file and '
3376 'visit the following URLs with correct account to generate '
3377 'correct credential lines:\n' %
3378 gerrit_util.CookiesAuthenticator.get_gitcookies_path())
3379 print(' %s' % '\n '.join(sorted(set(
3380 gerrit_util.CookiesAuthenticator().get_new_password_url(
3381 self._canonical_git_googlesource_host(host))
3382 for host in bad_hosts
3383 ))))
3384 return found
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003385
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003386
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003387@metrics.collector.collect_metrics('git cl creds-check')
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003388def CMDcreds_check(parser, args):
3389 """Checks credentials and suggests changes."""
3390 _, _ = parser.parse_args(args)
3391
Vadim Shtayurab250ec12018-10-04 00:21:08 +00003392 # Code below checks .gitcookies. Abort if using something else.
3393 authn = gerrit_util.Authenticator.get()
3394 if not isinstance(authn, gerrit_util.CookiesAuthenticator):
3395 if isinstance(authn, gerrit_util.GceAuthenticator):
3396 DieWithError(
3397 'This command is not designed for GCE, are you on a bot?\n'
3398 'If you need to run this on GCE, export SKIP_GCE_AUTH_FOR_GIT=1 '
3399 'in your env.')
Aaron Gabled10ca0e2017-09-11 11:24:10 -07003400 DieWithError(
Vadim Shtayurab250ec12018-10-04 00:21:08 +00003401 'This command is not designed for bot environment. It checks '
3402 '~/.gitcookies file not generally used on bots.')
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003403
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003404 checker = _GitCookiesChecker()
3405 checker.ensure_configured_gitcookies()
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003406
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003407 print('Your .netrc and .gitcookies have credentials for these hosts:')
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003408 checker.print_current_creds(include_netrc=True)
3409
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003410 if not checker.find_and_report_problems():
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003411 print('\nNo problems detected in your .gitcookies file.')
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003412 return 0
3413 return 1
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003414
3415
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003416@metrics.collector.collect_metrics('git cl baseurl')
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00003417def CMDbaseurl(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00003418 """Gets or sets base-url for this branch."""
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00003419 branchref = RunGit(['symbolic-ref', 'HEAD']).strip()
Edward Lemur85153282020-02-14 22:06:29 +00003420 branch = scm.GIT.ShortBranchName(branchref)
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00003421 _, args = parser.parse_args(args)
3422 if not args:
vapiera7fbd5a2016-06-16 09:17:49 -07003423 print('Current base-url:')
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00003424 return RunGit(['config', 'branch.%s.base-url' % branch],
3425 error_ok=False).strip()
3426 else:
vapiera7fbd5a2016-06-16 09:17:49 -07003427 print('Setting base-url to %s' % args[0])
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00003428 return RunGit(['config', 'branch.%s.base-url' % branch, args[0]],
3429 error_ok=False).strip()
3430
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003431
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00003432def color_for_status(status):
3433 """Maps a Changelist status to color, for CMDstatus and other tools."""
3434 return {
Aaron Gable9ab38c62017-04-06 14:36:33 -07003435 'unsent': Fore.YELLOW,
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00003436 'waiting': Fore.BLUE,
3437 'reply': Fore.YELLOW,
Aaron Gable9ab38c62017-04-06 14:36:33 -07003438 'not lgtm': Fore.RED,
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00003439 'lgtm': Fore.GREEN,
3440 'commit': Fore.MAGENTA,
3441 'closed': Fore.CYAN,
3442 'error': Fore.WHITE,
3443 }.get(status, Fore.WHITE)
3444
tandrii@chromium.org04ea8462016-04-25 19:51:21 +00003445
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003446def get_cl_statuses(changes, fine_grained, max_processes=None):
3447 """Returns a blocking iterable of (cl, status) for given branches.
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00003448
3449 If fine_grained is true, this will fetch CL statuses from the server.
3450 Otherwise, simply indicate if there's a matching url for the given branches.
3451
3452 If max_processes is specified, it is used as the maximum number of processes
3453 to spawn to fetch CL status from the server. Otherwise 1 process per branch is
3454 spawned.
calamity@chromium.orgcf197482016-04-29 20:15:53 +00003455
3456 See GetStatus() for a list of possible statuses.
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00003457 """
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01003458 if not changes:
Edward Lemur61bf4172020-02-24 23:22:37 +00003459 return
calamity@chromium.orgcf197482016-04-29 20:15:53 +00003460
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01003461 if not fine_grained:
3462 # Fast path which doesn't involve querying codereview servers.
Aaron Gablea1bab272017-04-11 16:38:18 -07003463 # Do not use get_approving_reviewers(), since it requires an HTTP request.
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003464 for cl in changes:
3465 yield (cl, 'waiting' if cl.GetIssueURL() else 'error')
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01003466 return
3467
3468 # First, sort out authentication issues.
3469 logging.debug('ensuring credentials exist')
3470 for cl in changes:
3471 cl.EnsureAuthenticated(force=False, refresh=True)
3472
3473 def fetch(cl):
3474 try:
3475 return (cl, cl.GetStatus())
3476 except:
3477 # See http://crbug.com/629863.
Andrii Shyshkalov98824232018-04-19 11:37:15 -07003478 logging.exception('failed to fetch status for cl %s:', cl.GetIssue())
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01003479 raise
3480
3481 threads_count = len(changes)
3482 if max_processes:
3483 threads_count = max(1, min(threads_count, max_processes))
3484 logging.debug('querying %d CLs using %d threads', len(changes), threads_count)
3485
Edward Lemur61bf4172020-02-24 23:22:37 +00003486 pool = multiprocessing.pool.ThreadPool(threads_count)
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01003487 fetched_cls = set()
3488 try:
3489 it = pool.imap_unordered(fetch, changes).__iter__()
3490 while True:
3491 try:
3492 cl, status = it.next(timeout=5)
Edward Lemur61bf4172020-02-24 23:22:37 +00003493 except (multiprocessing.TimeoutError, StopIteration):
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01003494 break
3495 fetched_cls.add(cl)
3496 yield cl, status
3497 finally:
3498 pool.close()
3499
3500 # Add any branches that failed to fetch.
3501 for cl in set(changes) - fetched_cls:
3502 yield (cl, 'error')
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00003503
rmistry@google.com2dd99862015-06-22 12:22:18 +00003504
3505def upload_branch_deps(cl, args):
3506 """Uploads CLs of local branches that are dependents of the current branch.
3507
3508 If the local branch dependency tree looks like:
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003509
3510 test1 -> test2.1 -> test3.1
3511 -> test3.2
3512 -> test2.2 -> test3.3
rmistry@google.com2dd99862015-06-22 12:22:18 +00003513
3514 and you run "git cl upload --dependencies" from test1 then "git cl upload" is
3515 run on the dependent branches in this order:
3516 test2.1, test3.1, test3.2, test2.2, test3.3
3517
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003518 Note: This function does not rebase your local dependent branches. Use it
3519 when you make a change to the parent branch that will not conflict
3520 with its dependent branches, and you would like their dependencies
3521 updated in Rietveld.
rmistry@google.com2dd99862015-06-22 12:22:18 +00003522 """
3523 if git_common.is_dirty_git_tree('upload-branch-deps'):
3524 return 1
3525
3526 root_branch = cl.GetBranch()
3527 if root_branch is None:
3528 DieWithError('Can\'t find dependent branches from detached HEAD state. '
3529 'Get on a branch!')
Andrii Shyshkalov9f274432018-10-15 16:40:23 +00003530 if not cl.GetIssue():
rmistry@google.com2dd99862015-06-22 12:22:18 +00003531 DieWithError('Current branch does not have an uploaded CL. We cannot set '
3532 'patchset dependencies without an uploaded CL.')
3533
3534 branches = RunGit(['for-each-ref',
3535 '--format=%(refname:short) %(upstream:short)',
3536 'refs/heads'])
3537 if not branches:
3538 print('No local branches found.')
3539 return 0
3540
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003541 # Create a dictionary of all local branches to the branches that are
3542 # dependent on it.
rmistry@google.com2dd99862015-06-22 12:22:18 +00003543 tracked_to_dependents = collections.defaultdict(list)
3544 for b in branches.splitlines():
3545 tokens = b.split()
3546 if len(tokens) == 2:
3547 branch_name, tracked = tokens
3548 tracked_to_dependents[tracked].append(branch_name)
3549
vapiera7fbd5a2016-06-16 09:17:49 -07003550 print()
3551 print('The dependent local branches of %s are:' % root_branch)
rmistry@google.com2dd99862015-06-22 12:22:18 +00003552 dependents = []
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003553
rmistry@google.com2dd99862015-06-22 12:22:18 +00003554 def traverse_dependents_preorder(branch, padding=''):
3555 dependents_to_process = tracked_to_dependents.get(branch, [])
3556 padding += ' '
3557 for dependent in dependents_to_process:
vapiera7fbd5a2016-06-16 09:17:49 -07003558 print('%s%s' % (padding, dependent))
rmistry@google.com2dd99862015-06-22 12:22:18 +00003559 dependents.append(dependent)
3560 traverse_dependents_preorder(dependent, padding)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003561
rmistry@google.com2dd99862015-06-22 12:22:18 +00003562 traverse_dependents_preorder(root_branch)
vapiera7fbd5a2016-06-16 09:17:49 -07003563 print()
rmistry@google.com2dd99862015-06-22 12:22:18 +00003564
3565 if not dependents:
vapiera7fbd5a2016-06-16 09:17:49 -07003566 print('There are no dependent local branches for %s' % root_branch)
rmistry@google.com2dd99862015-06-22 12:22:18 +00003567 return 0
3568
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01003569 confirm_or_exit('This command will checkout all dependent branches and run '
3570 '"git cl upload".', action='continue')
rmistry@google.com2dd99862015-06-22 12:22:18 +00003571
rmistry@google.com2dd99862015-06-22 12:22:18 +00003572 # Record all dependents that failed to upload.
3573 failures = {}
3574 # Go through all dependents, checkout the branch and upload.
3575 try:
3576 for dependent_branch in dependents:
vapiera7fbd5a2016-06-16 09:17:49 -07003577 print()
3578 print('--------------------------------------')
3579 print('Running "git cl upload" from %s:' % dependent_branch)
rmistry@google.com2dd99862015-06-22 12:22:18 +00003580 RunGit(['checkout', '-q', dependent_branch])
vapiera7fbd5a2016-06-16 09:17:49 -07003581 print()
rmistry@google.com2dd99862015-06-22 12:22:18 +00003582 try:
3583 if CMDupload(OptionParser(), args) != 0:
vapiera7fbd5a2016-06-16 09:17:49 -07003584 print('Upload failed for %s!' % dependent_branch)
rmistry@google.com2dd99862015-06-22 12:22:18 +00003585 failures[dependent_branch] = 1
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -08003586 except: # pylint: disable=bare-except
rmistry@google.com2dd99862015-06-22 12:22:18 +00003587 failures[dependent_branch] = 1
vapiera7fbd5a2016-06-16 09:17:49 -07003588 print()
rmistry@google.com2dd99862015-06-22 12:22:18 +00003589 finally:
3590 # Swap back to the original root branch.
3591 RunGit(['checkout', '-q', root_branch])
3592
vapiera7fbd5a2016-06-16 09:17:49 -07003593 print()
3594 print('Upload complete for dependent branches!')
rmistry@google.com2dd99862015-06-22 12:22:18 +00003595 for dependent_branch in dependents:
3596 upload_status = 'failed' if failures.get(dependent_branch) else 'succeeded'
vapiera7fbd5a2016-06-16 09:17:49 -07003597 print(' %s : %s' % (dependent_branch, upload_status))
3598 print()
rmistry@google.com2dd99862015-06-22 12:22:18 +00003599
3600 return 0
3601
3602
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00003603def GetArchiveTagForBranch(issue_num, branch_name, existing_tags):
3604 """Given a proposed tag name, returns a tag name that is guaranteed to be
3605 unique. If 'foo' is proposed but already exists, then 'foo-2' is used,
3606 or 'foo-3', and so on."""
3607
3608 proposed_tag = 'git-cl-archived-%s-%s' % (issue_num, branch_name)
3609 for suffix_num in itertools.count(1):
3610 if suffix_num == 1:
3611 to_check = proposed_tag
3612 else:
3613 to_check = '%s-%d' % (proposed_tag, suffix_num)
3614
3615 if to_check not in existing_tags:
3616 return to_check
3617
3618
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003619@metrics.collector.collect_metrics('git cl archive')
kmarshall3bff56b2016-06-06 18:31:47 -07003620def CMDarchive(parser, args):
3621 """Archives and deletes branches associated with closed changelists."""
3622 parser.add_option(
3623 '-j', '--maxjobs', action='store', type=int,
kmarshall9249e012016-08-23 12:02:16 -07003624 help='The maximum number of jobs to use when retrieving review status.')
kmarshall3bff56b2016-06-06 18:31:47 -07003625 parser.add_option(
3626 '-f', '--force', action='store_true',
3627 help='Bypasses the confirmation prompt.')
kmarshall9249e012016-08-23 12:02:16 -07003628 parser.add_option(
3629 '-d', '--dry-run', action='store_true',
3630 help='Skip the branch tagging and removal steps.')
3631 parser.add_option(
3632 '-t', '--notags', action='store_true',
3633 help='Do not tag archived branches. '
3634 'Note: local commit history may be lost.')
kmarshall3bff56b2016-06-06 18:31:47 -07003635
kmarshall3bff56b2016-06-06 18:31:47 -07003636 options, args = parser.parse_args(args)
3637 if args:
3638 parser.error('Unsupported args: %s' % ' '.join(args))
kmarshall3bff56b2016-06-06 18:31:47 -07003639
3640 branches = RunGit(['for-each-ref', '--format=%(refname)', 'refs/heads'])
3641 if not branches:
3642 return 0
3643
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00003644 tags = RunGit(['for-each-ref', '--format=%(refname)',
3645 'refs/tags']).splitlines() or []
3646 tags = [t.split('/')[-1] for t in tags]
3647
vapiera7fbd5a2016-06-16 09:17:49 -07003648 print('Finding all branches associated with closed issues...')
Edward Lemur934836a2019-09-09 20:16:54 +00003649 changes = [Changelist(branchref=b)
3650 for b in branches.splitlines()]
kmarshall3bff56b2016-06-06 18:31:47 -07003651 alignment = max(5, max(len(c.GetBranch()) for c in changes))
3652 statuses = get_cl_statuses(changes,
3653 fine_grained=True,
3654 max_processes=options.maxjobs)
3655 proposal = [(cl.GetBranch(),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00003656 GetArchiveTagForBranch(cl.GetIssue(), cl.GetBranch(),
3657 tags))
kmarshall3bff56b2016-06-06 18:31:47 -07003658 for cl, status in statuses
Andrii Shyshkalov51bdf8c2018-10-18 01:07:58 +00003659 if status in ('closed', 'rietveld-not-supported')]
kmarshall3bff56b2016-06-06 18:31:47 -07003660 proposal.sort()
3661
3662 if not proposal:
vapiera7fbd5a2016-06-16 09:17:49 -07003663 print('No branches with closed codereview issues found.')
kmarshall3bff56b2016-06-06 18:31:47 -07003664 return 0
3665
Edward Lemur85153282020-02-14 22:06:29 +00003666 current_branch = scm.GIT.GetBranch(settings.GetRoot())
kmarshall3bff56b2016-06-06 18:31:47 -07003667
vapiera7fbd5a2016-06-16 09:17:49 -07003668 print('\nBranches with closed issues that will be archived:\n')
kmarshall9249e012016-08-23 12:02:16 -07003669 if options.notags:
3670 for next_item in proposal:
3671 print(' ' + next_item[0])
3672 else:
3673 print('%*s | %s' % (alignment, 'Branch name', 'Archival tag name'))
3674 for next_item in proposal:
3675 print('%*s %s' % (alignment, next_item[0], next_item[1]))
kmarshall3bff56b2016-06-06 18:31:47 -07003676
kmarshall9249e012016-08-23 12:02:16 -07003677 # Quit now on precondition failure or if instructed by the user, either
3678 # via an interactive prompt or by command line flags.
3679 if options.dry_run:
3680 print('\nNo changes were made (dry run).\n')
3681 return 0
3682 elif any(branch == current_branch for branch, _ in proposal):
kmarshall3bff56b2016-06-06 18:31:47 -07003683 print('You are currently on a branch \'%s\' which is associated with a '
3684 'closed codereview issue, so archive cannot proceed. Please '
3685 'checkout another branch and run this command again.' %
3686 current_branch)
3687 return 1
kmarshall9249e012016-08-23 12:02:16 -07003688 elif not options.force:
sergiyb4a5ecbe2016-06-20 09:46:00 -07003689 answer = ask_for_data('\nProceed with deletion (Y/n)? ').lower()
3690 if answer not in ('y', ''):
vapiera7fbd5a2016-06-16 09:17:49 -07003691 print('Aborted.')
kmarshall3bff56b2016-06-06 18:31:47 -07003692 return 1
3693
3694 for branch, tagname in proposal:
kmarshall9249e012016-08-23 12:02:16 -07003695 if not options.notags:
3696 RunGit(['tag', tagname, branch])
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00003697
3698 if RunGitWithCode(['branch', '-D', branch])[0] != 0:
3699 # Clean up the tag if we failed to delete the branch.
3700 RunGit(['tag', '-d', tagname])
kmarshall9249e012016-08-23 12:02:16 -07003701
vapiera7fbd5a2016-06-16 09:17:49 -07003702 print('\nJob\'s done!')
kmarshall3bff56b2016-06-06 18:31:47 -07003703
3704 return 0
3705
3706
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003707@metrics.collector.collect_metrics('git cl status')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003708def CMDstatus(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00003709 """Show status of changelists.
3710
3711 Colors are used to tell the state of the CL unless --fast is used:
jsbell@chromium.orgaeab41a2013-12-10 20:01:22 +00003712 - Blue waiting for review
Aaron Gable9ab38c62017-04-06 14:36:33 -07003713 - Yellow waiting for you to reply to review, or not yet sent
jsbell@chromium.orgaeab41a2013-12-10 20:01:22 +00003714 - Green LGTM'ed
Aaron Gable9ab38c62017-04-06 14:36:33 -07003715 - Red 'not LGTM'ed
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +00003716 - Magenta in the CQ
jsbell@chromium.orgaeab41a2013-12-10 20:01:22 +00003717 - Cyan was committed, branch can be deleted
Aaron Gable9ab38c62017-04-06 14:36:33 -07003718 - White error, or unknown status
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00003719
3720 Also see 'git cl comments'.
3721 """
Alan Cuttera3be9a52019-03-04 18:50:33 +00003722 parser.add_option(
3723 '--no-branch-color',
3724 action='store_true',
3725 help='Disable colorized branch names')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003726 parser.add_option('--field',
phajdan.jr289d03e2016-08-16 08:21:06 -07003727 help='print only specific field (desc|id|patch|status|url)')
maruel@chromium.org1033efd2013-07-23 23:25:09 +00003728 parser.add_option('-f', '--fast', action='store_true',
3729 help='Do not retrieve review status')
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00003730 parser.add_option(
3731 '-j', '--maxjobs', action='store', type=int,
3732 help='The maximum number of jobs to use when retrieving review status')
Edward Lemur52969c92020-02-06 18:15:28 +00003733 parser.add_option(
3734 '-i', '--issue', type=int,
3735 help='Operate on this issue instead of the current branch\'s implicit '
3736 'issue. Requires --field to be set.')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00003737 options, args = parser.parse_args(args)
maruel@chromium.org39c0b222013-08-17 16:57:01 +00003738 if args:
3739 parser.error('Unsupported args: %s' % args)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003740
iannuccie53c9352016-08-17 14:40:40 -07003741 if options.issue is not None and not options.field:
Edward Lemur6c6827c2020-02-06 21:15:18 +00003742 parser.error('--field must be given when --issue is set.')
iannucci3c972b92016-08-17 13:24:10 -07003743
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003744 if options.field:
Edward Lemur934836a2019-09-09 20:16:54 +00003745 cl = Changelist(issue=options.issue)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003746 if options.field.startswith('desc'):
Edward Lemur6c6827c2020-02-06 21:15:18 +00003747 if cl.GetIssue():
3748 print(cl.FetchDescription())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003749 elif options.field == 'id':
3750 issueid = cl.GetIssue()
3751 if issueid:
vapiera7fbd5a2016-06-16 09:17:49 -07003752 print(issueid)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003753 elif options.field == 'patch':
Aaron Gablee8856ee2017-12-07 12:41:46 -08003754 patchset = cl.GetMostRecentPatchset()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003755 if patchset:
vapiera7fbd5a2016-06-16 09:17:49 -07003756 print(patchset)
phajdan.jr289d03e2016-08-16 08:21:06 -07003757 elif options.field == 'status':
3758 print(cl.GetStatus())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003759 elif options.field == 'url':
3760 url = cl.GetIssueURL()
3761 if url:
vapiera7fbd5a2016-06-16 09:17:49 -07003762 print(url)
maruel@chromium.orge25c75b2013-07-23 18:30:56 +00003763 return 0
3764
3765 branches = RunGit(['for-each-ref', '--format=%(refname)', 'refs/heads'])
3766 if not branches:
3767 print('No local branch found.')
3768 return 0
3769
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003770 changes = [
Edward Lemur934836a2019-09-09 20:16:54 +00003771 Changelist(branchref=b)
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003772 for b in branches.splitlines()]
vapiera7fbd5a2016-06-16 09:17:49 -07003773 print('Branches associated with reviews:')
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003774 output = get_cl_statuses(changes,
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00003775 fine_grained=not options.fast,
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003776 max_processes=options.maxjobs)
maruel@chromium.org1033efd2013-07-23 23:25:09 +00003777
Edward Lemur85153282020-02-14 22:06:29 +00003778 current_branch = scm.GIT.GetBranch(settings.GetRoot())
Daniel McArdlea23bf592019-02-12 00:25:12 +00003779
3780 def FormatBranchName(branch, colorize=False):
3781 """Simulates 'git branch' behavior. Colorizes and prefixes branch name with
3782 an asterisk when it is the current branch."""
3783
3784 asterisk = ""
3785 color = Fore.RESET
3786 if branch == current_branch:
3787 asterisk = "* "
3788 color = Fore.GREEN
Edward Lemur85153282020-02-14 22:06:29 +00003789 branch_name = scm.GIT.ShortBranchName(branch)
Daniel McArdlea23bf592019-02-12 00:25:12 +00003790
3791 if colorize:
3792 return asterisk + color + branch_name + Fore.RESET
Daniel McArdle452a49f2019-02-14 17:28:31 +00003793 return asterisk + branch_name
3794
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00003795 branch_statuses = {}
Daniel McArdlea23bf592019-02-12 00:25:12 +00003796
3797 alignment = max(5, max(len(FormatBranchName(c.GetBranch())) for c in changes))
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003798 for cl in sorted(changes, key=lambda c: c.GetBranch()):
3799 branch = cl.GetBranch()
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00003800 while branch not in branch_statuses:
Edward Lemur79d4f992019-11-11 23:49:02 +00003801 c, status = next(output)
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003802 branch_statuses[c.GetBranch()] = status
3803 status = branch_statuses.pop(branch)
3804 url = cl.GetIssueURL()
3805 if url and (not status or status == 'error'):
3806 # The issue probably doesn't exist anymore.
3807 url += ' (broken)'
3808
nodir@chromium.orga6de1f42015-06-10 04:23:17 +00003809 color = color_for_status(status)
maruel@chromium.org885f6512013-07-27 02:17:26 +00003810 reset = Fore.RESET
iannucci@chromium.org596cd5c2016-04-04 21:34:39 +00003811 if not setup_color.IS_TTY:
maruel@chromium.org885f6512013-07-27 02:17:26 +00003812 color = ''
3813 reset = ''
nodir@chromium.orga6de1f42015-06-10 04:23:17 +00003814 status_str = '(%s)' % status if status else ''
Daniel McArdle452a49f2019-02-14 17:28:31 +00003815
Alan Cuttera3be9a52019-03-04 18:50:33 +00003816 branch_display = FormatBranchName(branch)
3817 padding = ' ' * (alignment - len(branch_display))
3818 if not options.no_branch_color:
3819 branch_display = FormatBranchName(branch, colorize=True)
Daniel McArdle452a49f2019-02-14 17:28:31 +00003820
Alan Cuttera3be9a52019-03-04 18:50:33 +00003821 print(' %s : %s%s %s%s' % (padding + branch_display, color, url,
3822 status_str, reset))
Andrii Shyshkalovd0e1d9d2017-01-24 17:10:51 +01003823
vapiera7fbd5a2016-06-16 09:17:49 -07003824 print()
Daniel McArdlea23bf592019-02-12 00:25:12 +00003825 print('Current branch: %s' % current_branch)
Andrii Shyshkalovd0e1d9d2017-01-24 17:10:51 +01003826 for cl in changes:
Daniel McArdlea23bf592019-02-12 00:25:12 +00003827 if cl.GetBranch() == current_branch:
Andrii Shyshkalovd0e1d9d2017-01-24 17:10:51 +01003828 break
dpranke@chromium.orgee87f582015-07-31 18:46:25 +00003829 if not cl.GetIssue():
vapiera7fbd5a2016-06-16 09:17:49 -07003830 print('No issue assigned.')
dpranke@chromium.orgee87f582015-07-31 18:46:25 +00003831 return 0
vapiera7fbd5a2016-06-16 09:17:49 -07003832 print('Issue number: %s (%s)' % (cl.GetIssue(), cl.GetIssueURL()))
maruel@chromium.org85616e02014-07-28 15:37:55 +00003833 if not options.fast:
vapiera7fbd5a2016-06-16 09:17:49 -07003834 print('Issue description:')
Edward Lemur6c6827c2020-02-06 21:15:18 +00003835 print(cl.FetchDescription(pretty=True))
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003836 return 0
3837
3838
maruel@chromium.org39c0b222013-08-17 16:57:01 +00003839def colorize_CMDstatus_doc():
3840 """To be called once in main() to add colors to git cl status help."""
3841 colors = [i for i in dir(Fore) if i[0].isupper()]
3842
3843 def colorize_line(line):
3844 for color in colors:
3845 if color in line.upper():
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003846 # Extract whitespace first and the leading '-'.
maruel@chromium.org39c0b222013-08-17 16:57:01 +00003847 indent = len(line) - len(line.lstrip(' ')) + 1
3848 return line[:indent] + getattr(Fore, color) + line[indent:] + Fore.RESET
3849 return line
3850
3851 lines = CMDstatus.__doc__.splitlines()
3852 CMDstatus.__doc__ = '\n'.join(colorize_line(l) for l in lines)
3853
3854
phajdan.jre328cf92016-08-22 04:12:17 -07003855def write_json(path, contents):
Stefan Zager1306bd02017-06-22 19:26:46 -07003856 if path == '-':
3857 json.dump(contents, sys.stdout)
3858 else:
3859 with open(path, 'w') as f:
3860 json.dump(contents, f)
phajdan.jre328cf92016-08-22 04:12:17 -07003861
3862
maruel@chromium.org0633fb42013-08-16 20:06:14 +00003863@subcommand.usage('[issue_number]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003864@metrics.collector.collect_metrics('git cl issue')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003865def CMDissue(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00003866 """Sets or displays the current code review issue number.
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003867
3868 Pass issue number 0 to clear the current issue.
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00003869 """
dnj@chromium.org406c4402015-03-03 17:22:28 +00003870 parser.add_option('-r', '--reverse', action='store_true',
3871 help='Lookup the branch(es) for the specified issues. If '
3872 'no issues are specified, all branches with mapped '
3873 'issues will be listed.')
Stefan Zager1306bd02017-06-22 19:26:46 -07003874 parser.add_option('--json',
3875 help='Path to JSON output file, or "-" for stdout.')
dnj@chromium.org406c4402015-03-03 17:22:28 +00003876 options, args = parser.parse_args(args)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003877
dnj@chromium.org406c4402015-03-03 17:22:28 +00003878 if options.reverse:
3879 branches = RunGit(['for-each-ref', 'refs/heads',
Aaron Gablead64abd2017-12-04 09:49:13 -08003880 '--format=%(refname)']).splitlines()
dnj@chromium.org406c4402015-03-03 17:22:28 +00003881 # Reverse issue lookup.
3882 issue_branch_map = {}
Daniel Bratellb56a43a2018-09-06 15:49:03 +00003883
3884 git_config = {}
3885 for config in RunGit(['config', '--get-regexp',
3886 r'branch\..*issue']).splitlines():
3887 name, _space, val = config.partition(' ')
3888 git_config[name] = val
3889
dnj@chromium.org406c4402015-03-03 17:22:28 +00003890 for branch in branches:
Edward Lemur85153282020-02-14 22:06:29 +00003891 config_key = _git_branch_config_key(scm.GIT.ShortBranchName(branch),
Edward Lemur52969c92020-02-06 18:15:28 +00003892 Changelist.IssueConfigKey())
3893 issue = git_config.get(config_key)
3894 if issue:
3895 issue_branch_map.setdefault(int(issue), []).append(branch)
dnj@chromium.org406c4402015-03-03 17:22:28 +00003896 if not args:
3897 args = sorted(issue_branch_map.iterkeys())
phajdan.jre328cf92016-08-22 04:12:17 -07003898 result = {}
dnj@chromium.org406c4402015-03-03 17:22:28 +00003899 for issue in args:
Lei Zhang5a368d42019-03-25 23:18:19 +00003900 try:
3901 issue_num = int(issue)
3902 except ValueError:
3903 print('ERROR cannot parse issue number: %s' % issue, file=sys.stderr)
dnj@chromium.org406c4402015-03-03 17:22:28 +00003904 continue
Lei Zhang5a368d42019-03-25 23:18:19 +00003905 result[issue_num] = issue_branch_map.get(issue_num)
vapiera7fbd5a2016-06-16 09:17:49 -07003906 print('Branch for issue number %s: %s' % (
Lei Zhang5a368d42019-03-25 23:18:19 +00003907 issue, ', '.join(issue_branch_map.get(issue_num) or ('None',))))
phajdan.jre328cf92016-08-22 04:12:17 -07003908 if options.json:
3909 write_json(options.json, result)
Aaron Gable78753da2017-06-15 10:35:49 -07003910 return 0
3911
3912 if len(args) > 0:
Edward Lemurf38bc172019-09-03 21:02:13 +00003913 issue = ParseIssueNumberArgument(args[0])
Aaron Gable78753da2017-06-15 10:35:49 -07003914 if not issue.valid:
3915 DieWithError('Pass a url or number to set the issue, 0 to unset it, '
3916 'or no argument to list it.\n'
3917 'Maybe you want to run git cl status?')
Edward Lemurf38bc172019-09-03 21:02:13 +00003918 cl = Changelist()
Aaron Gable78753da2017-06-15 10:35:49 -07003919 cl.SetIssue(issue.issue)
dnj@chromium.org406c4402015-03-03 17:22:28 +00003920 else:
Edward Lemurf38bc172019-09-03 21:02:13 +00003921 cl = Changelist()
Aaron Gable78753da2017-06-15 10:35:49 -07003922 print('Issue number: %s (%s)' % (cl.GetIssue(), cl.GetIssueURL()))
3923 if options.json:
3924 write_json(options.json, {
3925 'issue': cl.GetIssue(),
3926 'issue_url': cl.GetIssueURL(),
3927 })
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003928 return 0
3929
3930
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003931@metrics.collector.collect_metrics('git cl comments')
maruel@chromium.org9977a2e2012-06-06 22:30:56 +00003932def CMDcomments(parser, args):
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003933 """Shows or posts review comments for any changelist."""
3934 parser.add_option('-a', '--add-comment', dest='comment',
3935 help='comment to add to an issue')
Sergiy Byelozyorovcb629a42018-10-28 19:20:39 +00003936 parser.add_option('-p', '--publish', action='store_true',
3937 help='marks CL as ready and sends comment to reviewers')
Andrii Shyshkalov0d6b46e2017-03-17 22:23:22 +01003938 parser.add_option('-i', '--issue', dest='issue',
Edward Lemurf38bc172019-09-03 21:02:13 +00003939 help='review issue id (defaults to current issue).')
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07003940 parser.add_option('-m', '--machine-readable', dest='readable',
3941 action='store_false', default=True,
3942 help='output comments in a format compatible with '
3943 'editor parsing')
smut@google.comc85ac942015-09-15 16:34:43 +00003944 parser.add_option('-j', '--json-file',
Stefan Zager1306bd02017-06-22 19:26:46 -07003945 help='File to write JSON summary to, or "-" for stdout')
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003946 options, args = parser.parse_args(args)
maruel@chromium.org9977a2e2012-06-06 22:30:56 +00003947
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003948 issue = None
3949 if options.issue:
3950 try:
3951 issue = int(options.issue)
3952 except ValueError:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00003953 DieWithError('A review issue ID is expected to be a number.')
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003954
Edward Lemur934836a2019-09-09 20:16:54 +00003955 cl = Changelist(issue=issue)
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003956
3957 if options.comment:
Sergiy Byelozyorovcb629a42018-10-28 19:20:39 +00003958 cl.AddComment(options.comment, options.publish)
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003959 return 0
3960
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07003961 summary = sorted(cl.GetCommentsSummary(readable=options.readable),
3962 key=lambda c: c.date)
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01003963 for comment in summary:
3964 if comment.disapproval:
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003965 color = Fore.RED
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01003966 elif comment.approval:
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003967 color = Fore.GREEN
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01003968 elif comment.sender == cl.GetIssueOwner():
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003969 color = Fore.MAGENTA
Quinten Yearsley0e617c02019-02-20 00:37:03 +00003970 elif comment.autogenerated:
3971 color = Fore.CYAN
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003972 else:
3973 color = Fore.BLUE
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01003974 print('\n%s%s %s%s\n%s' % (
3975 color,
3976 comment.date.strftime('%Y-%m-%d %H:%M:%S UTC'),
3977 comment.sender,
3978 Fore.RESET,
3979 '\n'.join(' ' + l for l in comment.message.strip().splitlines())))
3980
smut@google.comc85ac942015-09-15 16:34:43 +00003981 if options.json_file:
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01003982 def pre_serialize(c):
Edward Lemur79d4f992019-11-11 23:49:02 +00003983 dct = c._asdict().copy()
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01003984 dct['date'] = dct['date'].strftime('%Y-%m-%d %H:%M:%S.%f')
3985 return dct
Edward Lemur79d4f992019-11-11 23:49:02 +00003986 write_json(options.json_file, [pre_serialize(x) for x in summary])
maruel@chromium.org9977a2e2012-06-06 22:30:56 +00003987 return 0
3988
3989
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00003990@subcommand.usage('[codereview url or issue id]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003991@metrics.collector.collect_metrics('git cl description')
rsesek@chromium.orgeec76592013-05-20 16:27:57 +00003992def CMDdescription(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00003993 """Brings up the editor for the current CL's description."""
smut@google.com34fb6b12015-07-13 20:03:26 +00003994 parser.add_option('-d', '--display', action='store_true',
3995 help='Display the description instead of opening an editor')
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00003996 parser.add_option('-n', '--new-description',
dnjba1b0f32016-09-02 12:37:42 -07003997 help='New description to set for this issue (- for stdin, '
3998 '+ to load from local commit HEAD)')
dsansomee2d6fd92016-09-08 00:10:47 -07003999 parser.add_option('-f', '--force', action='store_true',
4000 help='Delete any unpublished Gerrit edits for this issue '
4001 'without prompting')
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00004002
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00004003 options, args = parser.parse_args(args)
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00004004
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01004005 target_issue_arg = None
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00004006 if len(args) > 0:
Edward Lemurf38bc172019-09-03 21:02:13 +00004007 target_issue_arg = ParseIssueNumberArgument(args[0])
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01004008 if not target_issue_arg.valid:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004009 parser.error('Invalid issue ID or URL.')
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00004010
Edward Lemur934836a2019-09-09 20:16:54 +00004011 kwargs = {}
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01004012 if target_issue_arg:
4013 kwargs['issue'] = target_issue_arg.issue
4014 kwargs['codereview_host'] = target_issue_arg.hostname
martiniss6eda05f2016-06-30 10:18:35 -07004015
4016 cl = Changelist(**kwargs)
rsesek@chromium.orgeec76592013-05-20 16:27:57 +00004017 if not cl.GetIssue():
4018 DieWithError('This branch has no associated changelist.')
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004019
Edward Lemur678a6842019-10-03 22:25:05 +00004020 if args and not args[0].isdigit():
Edward Lemurf38bc172019-09-03 21:02:13 +00004021 logging.info('canonical issue/change URL: %s\n', cl.GetIssueURL())
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004022
Edward Lemur6c6827c2020-02-06 21:15:18 +00004023 description = ChangeDescription(cl.FetchDescription())
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00004024
smut@google.com34fb6b12015-07-13 20:03:26 +00004025 if options.display:
vapiera7fbd5a2016-06-16 09:17:49 -07004026 print(description.description)
smut@google.com34fb6b12015-07-13 20:03:26 +00004027 return 0
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00004028
4029 if options.new_description:
4030 text = options.new_description
4031 if text == '-':
4032 text = '\n'.join(l.rstrip() for l in sys.stdin)
dnjba1b0f32016-09-02 12:37:42 -07004033 elif text == '+':
4034 base_branch = cl.GetCommonAncestorWithUpstream()
Edward Lemur7f6dec02020-02-06 20:23:58 +00004035 text = cl.GetLocalDescription(base_branch)
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00004036
4037 description.set_description(text)
4038 else:
Edward Lemurf38bc172019-09-03 21:02:13 +00004039 description.prompt()
Edward Lemur6c6827c2020-02-06 21:15:18 +00004040 if cl.FetchDescription().strip() != description.description:
dsansomee2d6fd92016-09-08 00:10:47 -07004041 cl.UpdateDescription(description.description, force=options.force)
rsesek@chromium.orgeec76592013-05-20 16:27:57 +00004042 return 0
4043
4044
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004045@metrics.collector.collect_metrics('git cl lint')
thestig@chromium.org44202a22014-03-11 19:22:18 +00004046def CMDlint(parser, args):
4047 """Runs cpplint on the current changelist."""
tzik@chromium.orgf204d4b2014-03-13 07:40:55 +00004048 parser.add_option('--filter', action='append', metavar='-x,+y',
4049 help='Comma-separated list of cpplint\'s category-filters')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004050 options, args = parser.parse_args(args)
thestig@chromium.org44202a22014-03-11 19:22:18 +00004051
4052 # Access to a protected member _XX of a client class
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -08004053 # pylint: disable=protected-access
thestig@chromium.org44202a22014-03-11 19:22:18 +00004054 try:
4055 import cpplint
4056 import cpplint_chromium
4057 except ImportError:
vapiera7fbd5a2016-06-16 09:17:49 -07004058 print('Your depot_tools is missing cpplint.py and/or cpplint_chromium.py.')
thestig@chromium.org44202a22014-03-11 19:22:18 +00004059 return 1
4060
4061 # Change the current working directory before calling lint so that it
4062 # shows the correct base.
4063 previous_cwd = os.getcwd()
4064 os.chdir(settings.GetRoot())
4065 try:
Edward Lemur934836a2019-09-09 20:16:54 +00004066 cl = Changelist()
Edward Lemur7f6dec02020-02-06 20:23:58 +00004067 change = cl.GetChange(cl.GetCommonAncestorWithUpstream())
thestig@chromium.org44202a22014-03-11 19:22:18 +00004068 files = [f.LocalPath() for f in change.AffectedFiles()]
thestig@chromium.org5839eb52014-05-30 16:20:51 +00004069 if not files:
vapiera7fbd5a2016-06-16 09:17:49 -07004070 print('Cannot lint an empty CL')
thestig@chromium.org5839eb52014-05-30 16:20:51 +00004071 return 1
thestig@chromium.org44202a22014-03-11 19:22:18 +00004072
4073 # Process cpplints arguments if any.
tzik@chromium.orgf204d4b2014-03-13 07:40:55 +00004074 command = args + files
4075 if options.filter:
4076 command = ['--filter=' + ','.join(options.filter)] + command
4077 filenames = cpplint.ParseArguments(command)
thestig@chromium.org44202a22014-03-11 19:22:18 +00004078
4079 white_regex = re.compile(settings.GetLintRegex())
4080 black_regex = re.compile(settings.GetLintIgnoreRegex())
4081 extra_check_functions = [cpplint_chromium.CheckPointerDeclarationWhitespace]
4082 for filename in filenames:
4083 if white_regex.match(filename):
4084 if black_regex.match(filename):
vapiera7fbd5a2016-06-16 09:17:49 -07004085 print('Ignoring file %s' % filename)
thestig@chromium.org44202a22014-03-11 19:22:18 +00004086 else:
4087 cpplint.ProcessFile(filename, cpplint._cpplint_state.verbose_level,
4088 extra_check_functions)
4089 else:
vapiera7fbd5a2016-06-16 09:17:49 -07004090 print('Skipping file %s' % filename)
thestig@chromium.org44202a22014-03-11 19:22:18 +00004091 finally:
4092 os.chdir(previous_cwd)
vapiera7fbd5a2016-06-16 09:17:49 -07004093 print('Total errors found: %d\n' % cpplint._cpplint_state.error_count)
thestig@chromium.org44202a22014-03-11 19:22:18 +00004094 if cpplint._cpplint_state.error_count != 0:
4095 return 1
4096 return 0
4097
4098
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004099@metrics.collector.collect_metrics('git cl presubmit')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004100def CMDpresubmit(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004101 """Runs presubmit tests on the current changelist."""
ilevy@chromium.org375a9022013-01-07 01:12:05 +00004102 parser.add_option('-u', '--upload', action='store_true',
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004103 help='Run upload hook instead of the push hook')
ilevy@chromium.org375a9022013-01-07 01:12:05 +00004104 parser.add_option('-f', '--force', action='store_true',
sbc@chromium.org495ad152012-09-04 23:07:42 +00004105 help='Run checks even if tree is dirty')
Aaron Gable8076c282017-11-29 14:39:41 -08004106 parser.add_option('--all', action='store_true',
4107 help='Run checks against all files, not just modified ones')
Edward Lesmes8e282792018-04-03 18:50:29 -04004108 parser.add_option('--parallel', action='store_true',
4109 help='Run all tests specified by input_api.RunTests in all '
4110 'PRESUBMIT files in parallel.')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004111 options, args = parser.parse_args(args)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004112
sbc@chromium.org71437c02015-04-09 19:29:40 +00004113 if not options.force and git_common.is_dirty_git_tree('presubmit'):
vapiera7fbd5a2016-06-16 09:17:49 -07004114 print('use --force to check even if tree is dirty.')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004115 return 1
4116
Edward Lemur934836a2019-09-09 20:16:54 +00004117 cl = Changelist()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004118 if args:
4119 base_branch = args[0]
4120 else:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00004121 # Default to diffing against the common ancestor of the upstream branch.
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00004122 base_branch = cl.GetCommonAncestorWithUpstream()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004123
Gregory Nisbet29d5cf82020-02-27 08:16:58 +00004124 if cl.GetIssue():
4125 description = cl.FetchDescription()
Aaron Gable8076c282017-11-29 14:39:41 -08004126 else:
Gregory Nisbet29d5cf82020-02-27 08:16:58 +00004127 description = cl.GetLocalDescription(base_branch)
Aaron Gable8076c282017-11-29 14:39:41 -08004128
ilevy@chromium.org051ad0e2013-03-04 21:57:34 +00004129 cl.RunHook(
4130 committing=not options.upload,
4131 may_prompt=False,
4132 verbose=options.verbose,
Edward Lemur227d5102020-02-25 23:45:35 +00004133 parallel=options.parallel,
4134 upstream=base_branch,
4135 description=description,
4136 all_files=options.all)
dpranke@chromium.org0a2bb372011-03-25 01:16:22 +00004137 return 0
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004138
4139
tandrii@chromium.org65874e12016-03-04 12:03:02 +00004140def GenerateGerritChangeId(message):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004141 """Returns the Change ID footer value (Ixxxxxx...xxx).
tandrii@chromium.org65874e12016-03-04 12:03:02 +00004142
4143 Works the same way as
4144 https://gerrit-review.googlesource.com/tools/hooks/commit-msg
4145 but can be called on demand on all platforms.
4146
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004147 The basic idea is to generate git hash of a state of the tree, original
4148 commit message, author/committer info and timestamps.
tandrii@chromium.org65874e12016-03-04 12:03:02 +00004149 """
4150 lines = []
4151 tree_hash = RunGitSilent(['write-tree'])
4152 lines.append('tree %s' % tree_hash.strip())
4153 code, parent = RunGitWithCode(['rev-parse', 'HEAD~0'], suppress_stderr=False)
4154 if code == 0:
4155 lines.append('parent %s' % parent.strip())
4156 author = RunGitSilent(['var', 'GIT_AUTHOR_IDENT'])
4157 lines.append('author %s' % author.strip())
4158 committer = RunGitSilent(['var', 'GIT_COMMITTER_IDENT'])
4159 lines.append('committer %s' % committer.strip())
4160 lines.append('')
4161 # Note: Gerrit's commit-hook actually cleans message of some lines and
4162 # whitespace. This code is not doing this, but it clearly won't decrease
4163 # entropy.
4164 lines.append(message)
4165 change_hash = RunCommand(['git', 'hash-object', '-t', 'commit', '--stdin'],
Raul Tambreb946b232019-03-26 14:48:46 +00004166 stdin=('\n'.join(lines)).encode())
tandrii@chromium.org65874e12016-03-04 12:03:02 +00004167 return 'I%s' % change_hash.strip()
4168
4169
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01004170def GetTargetRef(remote, remote_branch, target_branch):
wittman@chromium.org455dc922015-01-26 20:15:50 +00004171 """Computes the remote branch ref to use for the CL.
4172
4173 Args:
4174 remote (str): The git remote for the CL.
4175 remote_branch (str): The git remote branch for the CL.
4176 target_branch (str): The target branch specified by the user.
wittman@chromium.org455dc922015-01-26 20:15:50 +00004177 """
4178 if not (remote and remote_branch):
4179 return None
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00004180
wittman@chromium.org455dc922015-01-26 20:15:50 +00004181 if target_branch:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07004182 # Canonicalize branch references to the equivalent local full symbolic
wittman@chromium.org455dc922015-01-26 20:15:50 +00004183 # refs, which are then translated into the remote full symbolic refs
4184 # below.
4185 if '/' not in target_branch:
4186 remote_branch = 'refs/remotes/%s/%s' % (remote, target_branch)
4187 else:
4188 prefix_replacements = (
4189 ('^((refs/)?remotes/)?branch-heads/', 'refs/remotes/branch-heads/'),
4190 ('^((refs/)?remotes/)?%s/' % remote, 'refs/remotes/%s/' % remote),
4191 ('^(refs/)?heads/', 'refs/remotes/%s/' % remote),
4192 )
4193 match = None
4194 for regex, replacement in prefix_replacements:
4195 match = re.search(regex, target_branch)
4196 if match:
4197 remote_branch = target_branch.replace(match.group(0), replacement)
4198 break
4199 if not match:
4200 # This is a branch path but not one we recognize; use as-is.
4201 remote_branch = target_branch
rmistry@google.comc68112d2015-03-03 12:48:06 +00004202 elif remote_branch in REFS_THAT_ALIAS_TO_OTHER_REFS:
4203 # Handle the refs that need to land in different refs.
4204 remote_branch = REFS_THAT_ALIAS_TO_OTHER_REFS[remote_branch]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00004205
wittman@chromium.org455dc922015-01-26 20:15:50 +00004206 # Create the true path to the remote branch.
4207 # Does the following translation:
4208 # * refs/remotes/origin/refs/diff/test -> refs/diff/test
4209 # * refs/remotes/origin/master -> refs/heads/master
4210 # * refs/remotes/branch-heads/test -> refs/branch-heads/test
4211 if remote_branch.startswith('refs/remotes/%s/refs/' % remote):
4212 remote_branch = remote_branch.replace('refs/remotes/%s/' % remote, '')
4213 elif remote_branch.startswith('refs/remotes/%s/' % remote):
4214 remote_branch = remote_branch.replace('refs/remotes/%s/' % remote,
4215 'refs/heads/')
4216 elif remote_branch.startswith('refs/remotes/branch-heads'):
4217 remote_branch = remote_branch.replace('refs/remotes/', 'refs/')
Andrii Shyshkalov768f1d82016-12-08 15:10:13 +01004218
wittman@chromium.org455dc922015-01-26 20:15:50 +00004219 return remote_branch
4220
4221
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00004222def cleanup_list(l):
4223 """Fixes a list so that comma separated items are put as individual items.
4224
4225 So that "--reviewers joe@c,john@c --reviewers joa@c" results in
4226 options.reviewers == sorted(['joe@c', 'john@c', 'joa@c']).
4227 """
4228 items = sum((i.split(',') for i in l), [])
4229 stripped_items = (i.strip() for i in items)
4230 return sorted(filter(None, stripped_items))
4231
4232
Aaron Gable4db38df2017-11-03 14:59:07 -07004233@subcommand.usage('[flags]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004234@metrics.collector.collect_metrics('git cl upload')
ukai@chromium.orge8077812012-02-03 03:41:46 +00004235def CMDupload(parser, args):
rmistry@google.com78948ed2015-07-08 23:09:57 +00004236 """Uploads the current changelist to codereview.
4237
4238 Can skip dependency patchset uploads for a branch by running:
4239 git config branch.branch_name.skip-deps-uploads True
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004240 To unset, run:
rmistry@google.com78948ed2015-07-08 23:09:57 +00004241 git config --unset branch.branch_name.skip-deps-uploads
4242 Can also set the above globally by using the --global flag.
Dominic Battre7d1c4842017-10-27 09:17:28 +02004243
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004244 If the name of the checked out branch starts with "bug-" or "fix-" followed
4245 by a bug number, this bug number is automatically populated in the CL
Dominic Battre7d1c4842017-10-27 09:17:28 +02004246 description.
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004247
4248 If subject contains text in square brackets or has "<text>: " prefix, such
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004249 text(s) is treated as Gerrit hashtags. For example, CLs with subjects:
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004250 [git-cl] add support for hashtags
4251 Foo bar: implement foo
4252 will be hashtagged with "git-cl" and "foo-bar" respectively.
rmistry@google.com78948ed2015-07-08 23:09:57 +00004253 """
ukai@chromium.orge8077812012-02-03 03:41:46 +00004254 parser.add_option('--bypass-hooks', action='store_true', dest='bypass_hooks',
4255 help='bypass upload presubmit hook')
brettw@chromium.orgb65c43c2013-06-10 22:04:49 +00004256 parser.add_option('--bypass-watchlists', action='store_true',
4257 dest='bypass_watchlists',
4258 help='bypass watchlists auto CC-ing reviewers')
Aaron Gablef7543cd2017-07-20 14:26:31 -07004259 parser.add_option('-f', '--force', action='store_true', dest='force',
ukai@chromium.orge8077812012-02-03 03:41:46 +00004260 help="force yes to questions (don't prompt)")
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004261 parser.add_option('--message', '-m', dest='message',
4262 help='message for patchset')
tandriif9aefb72016-07-01 09:06:51 -07004263 parser.add_option('-b', '--bug',
4264 help='pre-populate the bug number(s) for this issue. '
4265 'If several, separate with commas')
tandriib80458a2016-06-23 12:20:07 -07004266 parser.add_option('--message-file', dest='message_file',
4267 help='file which contains message for patchset')
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004268 parser.add_option('--title', '-t', dest='title',
4269 help='title for patchset')
ukai@chromium.orge8077812012-02-03 03:41:46 +00004270 parser.add_option('-r', '--reviewers',
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00004271 action='append', default=[],
ukai@chromium.orge8077812012-02-03 03:41:46 +00004272 help='reviewer email addresses')
Robert Iannucci6c98dc62017-04-18 11:38:00 -07004273 parser.add_option('--tbrs',
4274 action='append', default=[],
4275 help='TBR email addresses')
ukai@chromium.orge8077812012-02-03 03:41:46 +00004276 parser.add_option('--cc',
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00004277 action='append', default=[],
ukai@chromium.orge8077812012-02-03 03:41:46 +00004278 help='cc email addresses')
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004279 parser.add_option('--hashtag', dest='hashtags',
4280 action='append', default=[],
4281 help=('Gerrit hashtag for new CL; '
4282 'can be applied multiple times'))
adamk@chromium.org36f47302013-04-05 01:08:31 +00004283 parser.add_option('-s', '--send-mail', action='store_true',
Aaron Gable59f48512017-01-12 10:54:46 -08004284 help='send email to reviewer(s) and cc(s) immediately')
ukai@chromium.org8ef7ab22012-11-28 04:24:52 +00004285 parser.add_option('--target_branch',
pgervais@chromium.orgb9f27512014-08-08 15:52:33 +00004286 '--target-branch',
wittman@chromium.org455dc922015-01-26 20:15:50 +00004287 metavar='TARGET',
4288 help='Apply CL to remote ref TARGET. ' +
4289 'Default: remote branch head, or master')
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00004290 parser.add_option('--squash', action='store_true',
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004291 help='Squash multiple commits into one')
Mike Frysingera989d552019-08-14 20:51:23 +00004292 parser.add_option('--no-squash', action='store_false', dest='squash',
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004293 help='Don\'t squash multiple commits into one')
rmistry9eadede2016-09-19 11:22:43 -07004294 parser.add_option('--topic', default=None,
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004295 help='Topic to specify when uploading')
Robert Iannuccif2708bd2017-04-17 15:49:02 -07004296 parser.add_option('--tbr-owners', dest='add_owners_to', action='store_const',
4297 const='TBR', help='add a set of OWNERS to TBR')
4298 parser.add_option('--r-owners', dest='add_owners_to', action='store_const',
4299 const='R', help='add a set of OWNERS to R')
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +00004300 parser.add_option('-c', '--use-commit-queue', action='store_true',
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004301 default=False,
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +00004302 help='tell the CQ to commit this patchset; '
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004303 'implies --send-mail')
4304 parser.add_option('-d', '--cq-dry-run',
4305 action='store_true', default=False,
rmistry@google.comef966222015-04-07 11:15:01 +00004306 help='Send the patchset to do a CQ dry run right after '
4307 'upload.')
Andrii Shyshkalov71f0da32019-07-15 22:45:18 +00004308 parser.add_option('--preserve-tryjobs', action='store_true',
4309 help='instruct the CQ to let tryjobs running even after '
4310 'new patchsets are uploaded instead of canceling '
4311 'prior patchset\' tryjobs')
rmistry@google.com2dd99862015-06-22 12:22:18 +00004312 parser.add_option('--dependencies', action='store_true',
4313 help='Uploads CLs of all the local branches that depend on '
4314 'the current branch')
Ravi Mistry31e7d562018-04-02 12:53:57 -04004315 parser.add_option('-a', '--enable-auto-submit', action='store_true',
4316 help='Sends your change to the CQ after an approval. Only '
4317 'works on repos that have the Auto-Submit label '
4318 'enabled')
Edward Lesmes8e282792018-04-03 18:50:29 -04004319 parser.add_option('--parallel', action='store_true',
4320 help='Run all tests specified by input_api.RunTests in all '
4321 'PRESUBMIT files in parallel.')
Sergiy Byelozyorov1aa405f2018-09-18 17:38:43 +00004322 parser.add_option('--no-autocc', action='store_true',
4323 help='Disables automatic addition of CC emails')
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004324 parser.add_option('--private', action='store_true',
Sergiy Byelozyorov1aa405f2018-09-18 17:38:43 +00004325 help='Set the review private. This implies --no-autocc.')
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004326 parser.add_option('-R', '--retry-failed', action='store_true',
4327 help='Retry failed tryjobs from old patchset immediately '
4328 'after uploading new patchset. Cannot be used with '
4329 '--use-commit-queue or --cq-dry-run.')
4330 parser.add_option('--buildbucket-host', default='cr-buildbucket.appspot.com',
4331 help='Host of buildbucket. The default host is %default.')
Dan Beamd8b04ca2019-10-10 21:23:26 +00004332 parser.add_option('--fixed', '-x',
4333 help='List of bugs that will be commented on and marked '
4334 'fixed (pre-populates "Fixed:" tag). Same format as '
4335 '-b option / "Bug:" tag. If fixing several issues, '
4336 'separate with commas.')
Josipe827b0f2020-01-30 00:07:20 +00004337 parser.add_option('--edit-description', action='store_true', default=False,
4338 help='Modify description before upload. Cannot be used '
4339 'with --force. It is a noop when --no-squash is set '
4340 'or a new commit is created.')
Sergiy Byelozyorov1aa405f2018-09-18 17:38:43 +00004341
rmistry@google.com2dd99862015-06-22 12:22:18 +00004342 orig_args = args
ukai@chromium.orge8077812012-02-03 03:41:46 +00004343 (options, args) = parser.parse_args(args)
4344
sbc@chromium.org71437c02015-04-09 19:29:40 +00004345 if git_common.is_dirty_git_tree('upload'):
ukai@chromium.orge8077812012-02-03 03:41:46 +00004346 return 1
4347
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00004348 options.reviewers = cleanup_list(options.reviewers)
Robert Iannucci6c98dc62017-04-18 11:38:00 -07004349 options.tbrs = cleanup_list(options.tbrs)
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00004350 options.cc = cleanup_list(options.cc)
4351
Josipe827b0f2020-01-30 00:07:20 +00004352 if options.edit_description and options.force:
4353 parser.error('Only one of --force and --edit-description allowed')
4354
tandriib80458a2016-06-23 12:20:07 -07004355 if options.message_file:
4356 if options.message:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004357 parser.error('Only one of --message and --message-file allowed.')
tandriib80458a2016-06-23 12:20:07 -07004358 options.message = gclient_utils.FileRead(options.message_file)
4359 options.message_file = None
4360
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004361 if ([options.cq_dry_run,
4362 options.use_commit_queue,
4363 options.retry_failed].count(True) > 1):
4364 parser.error('Only one of --use-commit-queue, --cq-dry-run, or '
4365 '--retry-failed is allowed.')
tandrii4d0545a2016-07-06 03:56:49 -07004366
Aaron Gableedbc4132017-09-11 13:22:28 -07004367 if options.use_commit_queue:
4368 options.send_mail = True
4369
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00004370 # For sanity of test expectations, do this otherwise lazy-loading *now*.
4371 settings.GetIsGerrit()
4372
Edward Lemur934836a2019-09-09 20:16:54 +00004373 cl = Changelist()
Edward Lesmes7677e5c2020-02-19 20:39:03 +00004374 # Warm change details cache now to avoid RPCs later, reducing latency for
4375 # developers.
4376 if cl.GetIssue():
4377 cl._GetChangeDetail(
4378 ['DETAILED_ACCOUNTS', 'CURRENT_REVISION', 'CURRENT_COMMIT', 'LABELS'])
4379
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004380 if options.retry_failed and not cl.GetIssue():
4381 print('No previous patchsets, so --retry-failed has no effect.')
4382 options.retry_failed = False
Edward Lesmes7677e5c2020-02-19 20:39:03 +00004383
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004384 # cl.GetMostRecentPatchset uses cached information, and can return the last
4385 # patchset before upload. Calling it here makes it clear that it's the
4386 # last patchset before upload. Note that GetMostRecentPatchset will fail
4387 # if no CL has been uploaded yet.
4388 if options.retry_failed:
4389 patchset = cl.GetMostRecentPatchset()
Andrii Shyshkalov9f274432018-10-15 16:40:23 +00004390
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004391 ret = cl.CMDUpload(options, args, orig_args)
4392
4393 if options.retry_failed:
4394 if ret != 0:
4395 print('Upload failed, so --retry-failed has no effect.')
4396 return ret
Andrii Shyshkalov1ad58112019-10-08 01:46:14 +00004397 builds, _ = _fetch_latest_builds(
Edward Lemur5b929a42019-10-21 17:57:39 +00004398 cl, options.buildbucket_host, latest_patchset=patchset)
Edward Lemur45768512020-03-02 19:03:14 +00004399 jobs = _filter_failed_for_retry(builds)
4400 if len(jobs) == 0:
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004401 print('No failed tryjobs, so --retry-failed has no effect.')
4402 return ret
Edward Lemur45768512020-03-02 19:03:14 +00004403 _trigger_try_jobs(cl, jobs, options, patchset + 1)
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004404
4405 return ret
ukai@chromium.orge8077812012-02-03 03:41:46 +00004406
4407
Francois Dorayd42c6812017-05-30 15:10:20 -04004408@subcommand.usage('--description=<description file>')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004409@metrics.collector.collect_metrics('git cl split')
Francois Dorayd42c6812017-05-30 15:10:20 -04004410def CMDsplit(parser, args):
4411 """Splits a branch into smaller branches and uploads CLs.
4412
4413 Creates a branch and uploads a CL for each group of files modified in the
4414 current branch that share a common OWNERS file. In the CL description and
Edward Lemurac5c55f2020-02-29 00:17:16 +00004415 comment, the string '$directory', is replaced with the directory containing
4416 the shared OWNERS file.
Francois Dorayd42c6812017-05-30 15:10:20 -04004417 """
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004418 parser.add_option('-d', '--description', dest='description_file',
4419 help='A text file containing a CL description in which '
4420 '$directory will be replaced by each CL\'s directory.')
4421 parser.add_option('-c', '--comment', dest='comment_file',
4422 help='A text file containing a CL comment.')
4423 parser.add_option('-n', '--dry-run', dest='dry_run', action='store_true',
Chris Watkinsba28e462017-12-13 11:22:17 +11004424 default=False,
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004425 help='List the files and reviewers for each CL that would '
4426 'be created, but don\'t create branches or CLs.')
4427 parser.add_option('--cq-dry-run', action='store_true',
4428 help='If set, will do a cq dry run for each uploaded CL. '
4429 'Please be careful when doing this; more than ~10 CLs '
4430 'has the potential to overload our build '
4431 'infrastructure. Try to upload these not during high '
4432 'load times (usually 11-3 Mountain View time). Email '
4433 'infra-dev@chromium.org with any questions.')
Takuto Ikuta51eca592019-02-14 19:40:52 +00004434 parser.add_option('-a', '--enable-auto-submit', action='store_true',
4435 default=True,
4436 help='Sends your change to the CQ after an approval. Only '
4437 'works on repos that have the Auto-Submit label '
4438 'enabled')
Francois Dorayd42c6812017-05-30 15:10:20 -04004439 options, _ = parser.parse_args(args)
4440
4441 if not options.description_file:
4442 parser.error('No --description flag specified.')
4443
4444 def WrappedCMDupload(args):
4445 return CMDupload(OptionParser(), args)
4446
4447 return split_cl.SplitCl(options.description_file, options.comment_file,
Stephen Martiniscb326682018-08-29 21:06:30 +00004448 Changelist, WrappedCMDupload, options.dry_run,
Takuto Ikuta51eca592019-02-14 19:40:52 +00004449 options.cq_dry_run, options.enable_auto_submit)
Francois Dorayd42c6812017-05-30 15:10:20 -04004450
4451
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004452@subcommand.usage('DEPRECATED')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004453@metrics.collector.collect_metrics('git cl commit')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004454def CMDdcommit(parser, args):
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004455 """DEPRECATED: Used to commit the current changelist via git-svn."""
4456 message = ('git-cl no longer supports committing to SVN repositories via '
4457 'git-svn. You probably want to use `git cl land` instead.')
4458 print(message)
4459 return 1
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004460
4461
maruel@chromium.org0633fb42013-08-16 20:06:14 +00004462@subcommand.usage('[upstream branch to apply against]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004463@metrics.collector.collect_metrics('git cl land')
pgervais@chromium.orgcee6dc42014-05-07 17:04:03 +00004464def CMDland(parser, args):
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004465 """Commits the current changelist via git.
4466
4467 In case of Gerrit, uses Gerrit REST api to "submit" the issue, which pushes
4468 upstream and closes the issue automatically and atomically.
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004469 """
4470 parser.add_option('--bypass-hooks', action='store_true', dest='bypass_hooks',
4471 help='bypass upload presubmit hook')
Aaron Gablef7543cd2017-07-20 14:26:31 -07004472 parser.add_option('-f', '--force', action='store_true', dest='force',
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004473 help="force yes to questions (don't prompt)")
Edward Lesmes67b3faa2018-04-13 17:50:52 -04004474 parser.add_option('--parallel', action='store_true',
4475 help='Run all tests specified by input_api.RunTests in all '
4476 'PRESUBMIT files in parallel.')
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004477 (options, args) = parser.parse_args(args)
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004478
Edward Lemur934836a2019-09-09 20:16:54 +00004479 cl = Changelist()
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004480
Robert Iannucci2e73d432018-03-14 01:10:47 -07004481 if not cl.GetIssue():
4482 DieWithError('You must upload the change first to Gerrit.\n'
4483 ' If you would rather have `git cl land` upload '
4484 'automatically for you, see http://crbug.com/642759')
Edward Lemur125d60a2019-09-13 18:25:41 +00004485 return cl.CMDLand(options.force, options.bypass_hooks,
Olivier Robin75ee7252018-04-13 10:02:56 +02004486 options.verbose, options.parallel)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004487
4488
dsinclair@chromium.orgfbed6562015-09-25 21:22:36 +00004489@subcommand.usage('<patch url or issue id or issue url>')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004490@metrics.collector.collect_metrics('git cl patch')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004491def CMDpatch(parser, args):
marq@chromium.orge5e59002013-10-02 23:21:25 +00004492 """Patches in a code review."""
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004493 parser.add_option('-b', dest='newbranch',
4494 help='create a new branch off trunk for the patch')
qsr@chromium.org1ef44af2013-10-16 16:24:32 +00004495 parser.add_option('-f', '--force', action='store_true',
Aaron Gable62619a32017-06-16 08:22:09 -07004496 help='overwrite state on the current or chosen branch')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004497 parser.add_option('-n', '--no-commit', action='store_true', dest='nocommit',
Edward Lemurf38bc172019-09-03 21:02:13 +00004498 help='don\'t commit after patch applies.')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004499
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00004500 group = optparse.OptionGroup(
4501 parser,
4502 'Options for continuing work on the current issue uploaded from a '
4503 'different clone (e.g. different machine). Must be used independently '
4504 'from the other options. No issue number should be specified, and the '
4505 'branch must have an issue number associated with it')
4506 group.add_option('--reapply', action='store_true', dest='reapply',
4507 help='Reset the branch and reapply the issue.\n'
4508 'CAUTION: This will undo any local changes in this '
4509 'branch')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004510
4511 group.add_option('--pull', action='store_true', dest='pull',
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00004512 help='Performs a pull before reapplying.')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004513 parser.add_option_group(group)
4514
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004515 (options, args) = parser.parse_args(args)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004516
Andrii Shyshkalov18975322017-01-25 16:44:13 +01004517 if options.reapply:
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004518 if options.newbranch:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004519 parser.error('--reapply works on the current branch only.')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004520 if len(args) > 0:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004521 parser.error('--reapply implies no additional arguments.')
dsinclair@chromium.orgfbed6562015-09-25 21:22:36 +00004522
Edward Lemur934836a2019-09-09 20:16:54 +00004523 cl = Changelist()
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004524 if not cl.GetIssue():
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004525 parser.error('Current branch must have an associated issue.')
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004526
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004527 upstream = cl.GetUpstreamBranch()
Andrii Shyshkalov18975322017-01-25 16:44:13 +01004528 if upstream is None:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004529 parser.error('No upstream branch specified. Cannot reset branch.')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004530
4531 RunGit(['reset', '--hard', upstream])
4532 if options.pull:
4533 RunGit(['pull'])
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004534
Edward Lemur678a6842019-10-03 22:25:05 +00004535 target_issue_arg = ParseIssueNumberArgument(cl.GetIssue())
4536 return cl.CMDPatchWithParsedIssue(target_issue_arg, options.nocommit, False)
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004537
4538 if len(args) != 1 or not args[0]:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004539 parser.error('Must specify issue number or URL.')
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004540
Edward Lemurf38bc172019-09-03 21:02:13 +00004541 target_issue_arg = ParseIssueNumberArgument(args[0])
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004542 if not target_issue_arg.valid:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004543 parser.error('Invalid issue ID or URL.')
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004544
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004545 # We don't want uncommitted changes mixed up with the patch.
4546 if git_common.is_dirty_git_tree('patch'):
dsinclair@chromium.orgfbed6562015-09-25 21:22:36 +00004547 return 1
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004548
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004549 if options.newbranch:
4550 if options.force:
4551 RunGit(['branch', '-D', options.newbranch],
4552 stderr=subprocess2.PIPE, error_ok=True)
Edward Lemur84101642020-02-21 21:40:34 +00004553 git_new_branch.create_new_branch(options.newbranch)
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004554
Edward Lemur678a6842019-10-03 22:25:05 +00004555 cl = Changelist(
4556 codereview_host=target_issue_arg.hostname, issue=target_issue_arg.issue)
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004557
Edward Lemur678a6842019-10-03 22:25:05 +00004558 if not args[0].isdigit():
Edward Lemurf38bc172019-09-03 21:02:13 +00004559 print('canonical issue/change URL: %s\n' % cl.GetIssueURL())
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004560
Edward Lemurf38bc172019-09-03 21:02:13 +00004561 return cl.CMDPatchWithParsedIssue(
4562 target_issue_arg, options.nocommit, options.force)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004563
4564
jochen@chromium.org3ec0d542014-01-14 20:00:03 +00004565def GetTreeStatus(url=None):
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004566 """Fetches the tree status and returns either 'open', 'closed',
4567 'unknown' or 'unset'."""
jochen@chromium.org3ec0d542014-01-14 20:00:03 +00004568 url = url or settings.GetTreeStatusUrl(error_ok=True)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004569 if url:
Edward Lemur79d4f992019-11-11 23:49:02 +00004570 status = urllib.request.urlopen(url).read().lower()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004571 if status.find('closed') != -1 or status == '0':
4572 return 'closed'
4573 elif status.find('open') != -1 or status == '1':
4574 return 'open'
4575 return 'unknown'
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004576 return 'unset'
4577
dpranke@chromium.org970c5222011-03-12 00:32:24 +00004578
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004579def GetTreeStatusReason():
4580 """Fetches the tree status from a json url and returns the message
4581 with the reason for the tree to be opened or closed."""
msb@chromium.orgbf1a7ba2011-02-01 16:21:46 +00004582 url = settings.GetTreeStatusUrl()
4583 json_url = urlparse.urljoin(url, '/current?format=json')
Edward Lemur79d4f992019-11-11 23:49:02 +00004584 connection = urllib.request.urlopen(json_url)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004585 status = json.loads(connection.read())
4586 connection.close()
4587 return status['message']
4588
dpranke@chromium.org970c5222011-03-12 00:32:24 +00004589
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004590@metrics.collector.collect_metrics('git cl tree')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004591def CMDtree(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004592 """Shows the status of the tree."""
dpranke@chromium.org97ae58e2011-03-18 00:29:20 +00004593 _, args = parser.parse_args(args)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004594 status = GetTreeStatus()
4595 if 'unset' == status:
vapiera7fbd5a2016-06-16 09:17:49 -07004596 print('You must configure your tree status URL by running "git cl config".')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004597 return 2
4598
vapiera7fbd5a2016-06-16 09:17:49 -07004599 print('The tree is %s' % status)
4600 print()
4601 print(GetTreeStatusReason())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004602 if status != 'open':
4603 return 1
4604 return 0
4605
4606
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004607@metrics.collector.collect_metrics('git cl try')
maruel@chromium.org15192402012-09-06 12:38:29 +00004608def CMDtry(parser, args):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004609 """Triggers tryjobs using either Buildbucket or CQ dry run."""
4610 group = optparse.OptionGroup(parser, 'Tryjob options')
maruel@chromium.org15192402012-09-06 12:38:29 +00004611 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004612 '-b', '--bot', action='append',
4613 help=('IMPORTANT: specify ONE builder per --bot flag. Use it multiple '
4614 'times to specify multiple builders. ex: '
4615 '"-b win_rel -b win_layout". See '
4616 'the try server waterfall for the builders name and the tests '
4617 'available.'))
maruel@chromium.org15192402012-09-06 12:38:29 +00004618 group.add_option(
borenet6c0efe62016-10-19 08:13:29 -07004619 '-B', '--bucket', default='',
4620 help=('Buildbucket bucket to send the try requests.'))
4621 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004622 '-r', '--revision',
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004623 help='Revision to use for the tryjob; default: the revision will '
tandriif7b29d42016-10-07 08:45:41 -07004624 'be determined by the try recipe that builder runs, which usually '
4625 'defaults to HEAD of origin/master')
maruel@chromium.org15192402012-09-06 12:38:29 +00004626 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004627 '-c', '--clobber', action='store_true', default=False,
tandriif7b29d42016-10-07 08:45:41 -07004628 help='Force a clobber before building; that is don\'t do an '
tandrii1838bad2016-10-06 00:10:52 -07004629 'incremental build')
maruel@chromium.org15192402012-09-06 12:38:29 +00004630 group.add_option(
Andrii Shyshkalovf9648b52018-02-21 22:32:42 -08004631 '--category', default='git_cl_try', help='Specify custom build category.')
4632 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004633 '--project',
4634 help='Override which project to use. Projects are defined '
tandriif7b29d42016-10-07 08:45:41 -07004635 'in recipe to determine to which repository or directory to '
4636 'apply the patch')
maruel@chromium.org15192402012-09-06 12:38:29 +00004637 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004638 '-p', '--property', dest='properties', action='append', default=[],
4639 help='Specify generic properties in the form -p key1=value1 -p '
tandriif7b29d42016-10-07 08:45:41 -07004640 'key2=value2 etc. The value will be treated as '
4641 'json if decodable, or as string otherwise. '
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004642 'NOTE: using this may make your tryjob not usable for CQ, '
4643 'which will then schedule another tryjob with default properties')
sheyang@chromium.orgdb375572015-08-17 19:22:23 +00004644 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004645 '--buildbucket-host', default='cr-buildbucket.appspot.com',
4646 help='Host of buildbucket. The default host is %default.')
maruel@chromium.org15192402012-09-06 12:38:29 +00004647 parser.add_option_group(group)
Quinten Yearsley983111f2019-09-26 17:18:48 +00004648 parser.add_option(
4649 '-R', '--retry-failed', action='store_true', default=False,
4650 help='Retry failed jobs from the latest set of tryjobs. '
4651 'Not allowed with --bucket and --bot options.')
Edward Lemur52969c92020-02-06 18:15:28 +00004652 parser.add_option(
4653 '-i', '--issue', type=int,
4654 help='Operate on this issue instead of the current branch\'s implicit '
4655 'issue.')
maruel@chromium.org15192402012-09-06 12:38:29 +00004656 options, args = parser.parse_args(args)
4657
machenbach@chromium.org45453142015-09-15 08:45:22 +00004658 # Make sure that all properties are prop=value pairs.
4659 bad_params = [x for x in options.properties if '=' not in x]
4660 if bad_params:
4661 parser.error('Got properties with missing "=": %s' % bad_params)
4662
maruel@chromium.org15192402012-09-06 12:38:29 +00004663 if args:
4664 parser.error('Unknown arguments: %s' % args)
4665
Edward Lemur934836a2019-09-09 20:16:54 +00004666 cl = Changelist(issue=options.issue)
maruel@chromium.org15192402012-09-06 12:38:29 +00004667 if not cl.GetIssue():
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004668 parser.error('Need to upload first.')
maruel@chromium.org15192402012-09-06 12:38:29 +00004669
Edward Lemurf38bc172019-09-03 21:02:13 +00004670 # HACK: warm up Gerrit change detail cache to save on RPCs.
Edward Lemur125d60a2019-09-13 18:25:41 +00004671 cl._GetChangeDetail(['DETAILED_ACCOUNTS', 'ALL_REVISIONS'])
Andrii Shyshkaloveadad922017-01-26 09:38:30 +01004672
tandriie113dfd2016-10-11 10:20:12 -07004673 error_message = cl.CannotTriggerTryJobReason()
4674 if error_message:
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004675 parser.error('Can\'t trigger tryjobs: %s' % error_message)
jrobbins@chromium.org16f10f72014-06-24 22:14:36 +00004676
Edward Lemur45768512020-03-02 19:03:14 +00004677 if options.bot:
4678 if options.retry_failed:
4679 parser.error('--bot is not compatible with --retry-failed.')
4680 if not options.bucket:
4681 parser.error('A bucket (e.g. "chromium/try") is required.')
4682
4683 triggered = [b for b in options.bot if 'triggered' in b]
4684 if triggered:
4685 parser.error(
4686 'Cannot schedule builds on triggered bots: %s.\n'
4687 'This type of bot requires an initial job from a parent (usually a '
4688 'builder). Schedule a job on the parent instead.\n' % triggered)
4689
4690 if options.bucket.startswith('.master'):
4691 parser.error('Buildbot masters are not supported.')
4692
4693 project, bucket = _parse_bucket(options.bucket)
4694 if project is None or bucket is None:
4695 parser.error('Invalid bucket: %s.' % options.bucket)
4696 jobs = sorted((project, bucket, bot) for bot in options.bot)
4697 elif options.retry_failed:
Quinten Yearsley983111f2019-09-26 17:18:48 +00004698 print('Searching for failed tryjobs...')
Edward Lemur5b929a42019-10-21 17:57:39 +00004699 builds, patchset = _fetch_latest_builds(cl, options.buildbucket_host)
Quinten Yearsley983111f2019-09-26 17:18:48 +00004700 if options.verbose:
4701 print('Got %d builds in patchset #%d' % (len(builds), patchset))
Edward Lemur45768512020-03-02 19:03:14 +00004702 jobs = _filter_failed_for_retry(builds)
4703 if not jobs:
Quinten Yearsley983111f2019-09-26 17:18:48 +00004704 print('There are no failed jobs in the latest set of jobs '
4705 '(patchset #%d), doing nothing.' % patchset)
4706 return 0
Edward Lemur45768512020-03-02 19:03:14 +00004707 num_builders = len(jobs)
Quinten Yearsley983111f2019-09-26 17:18:48 +00004708 if num_builders > 10:
4709 confirm_or_exit('There are %d builders with failed builds.'
4710 % num_builders, action='continue')
4711 else:
qyearsley1fdfcb62016-10-24 13:22:03 -07004712 if options.verbose:
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07004713 print('git cl try with no bots now defaults to CQ dry run.')
4714 print('Scheduling CQ dry run on: %s' % cl.GetIssueURL())
4715 return cl.SetCQState(_CQState.DRY_RUN)
stip@chromium.org43064fd2013-12-18 20:07:44 +00004716
ilevy@chromium.org36e420b2013-08-06 23:21:12 +00004717 patchset = cl.GetMostRecentPatchset()
Edward Lemur2c210a42019-09-16 23:58:35 +00004718 try:
Edward Lemur45768512020-03-02 19:03:14 +00004719 _trigger_try_jobs(cl, jobs, options, patchset)
Edward Lemur2c210a42019-09-16 23:58:35 +00004720 except BuildbucketResponseException as ex:
4721 print('ERROR: %s' % ex)
4722 return 1
4723 return 0
maruel@chromium.org15192402012-09-06 12:38:29 +00004724
4725
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004726@metrics.collector.collect_metrics('git cl try-results')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004727def CMDtry_results(parser, args):
Quinten Yearsleyd242ed72019-07-25 17:17:55 +00004728 """Prints info about results for tryjobs associated with the current CL."""
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004729 group = optparse.OptionGroup(parser, 'Tryjob results options')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004730 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004731 '-p', '--patchset', type=int, help='patchset number if not current.')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004732 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004733 '--print-master', action='store_true', help='print master name as well.')
tandrii@chromium.org6cf98c82016-03-15 11:56:00 +00004734 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004735 '--color', action='store_true', default=setup_color.IS_TTY,
4736 help='force color output, useful when piping output.')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004737 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004738 '--buildbucket-host', default='cr-buildbucket.appspot.com',
4739 help='Host of buildbucket. The default host is %default.')
qyearsley53f48a12016-09-01 10:45:13 -07004740 group.add_option(
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004741 '--json', help=('Path of JSON output file to write tryjob results to,'
Stefan Zager1306bd02017-06-22 19:26:46 -07004742 'or "-" for stdout.'))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004743 parser.add_option_group(group)
Edward Lemur52969c92020-02-06 18:15:28 +00004744 parser.add_option(
4745 '-i', '--issue', type=int,
4746 help='Operate on this issue instead of the current branch\'s implicit '
4747 'issue.')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004748 options, args = parser.parse_args(args)
4749 if args:
4750 parser.error('Unrecognized args: %s' % ' '.join(args))
4751
Edward Lemur934836a2019-09-09 20:16:54 +00004752 cl = Changelist(issue=options.issue)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004753 if not cl.GetIssue():
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004754 parser.error('Need to upload first.')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004755
tandrii221ab252016-10-06 08:12:04 -07004756 patchset = options.patchset
4757 if not patchset:
4758 patchset = cl.GetMostRecentPatchset()
4759 if not patchset:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004760 parser.error('Code review host doesn\'t know about issue %s. '
tandrii221ab252016-10-06 08:12:04 -07004761 'No access to issue or wrong issue number?\n'
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004762 'Either upload first, or pass --patchset explicitly.' %
tandrii221ab252016-10-06 08:12:04 -07004763 cl.GetIssue())
4764
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004765 try:
Edward Lemur5b929a42019-10-21 17:57:39 +00004766 jobs = fetch_try_jobs(cl, options.buildbucket_host, patchset)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004767 except BuildbucketResponseException as ex:
vapiera7fbd5a2016-06-16 09:17:49 -07004768 print('Buildbucket error: %s' % ex)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004769 return 1
qyearsley53f48a12016-09-01 10:45:13 -07004770 if options.json:
Edward Lemurbaaf6be2019-10-09 18:00:44 +00004771 write_json(options.json, jobs)
qyearsley53f48a12016-09-01 10:45:13 -07004772 else:
4773 print_try_jobs(options, jobs)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004774 return 0
4775
4776
maruel@chromium.org0633fb42013-08-16 20:06:14 +00004777@subcommand.usage('[new upstream branch]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004778@metrics.collector.collect_metrics('git cl upstream')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004779def CMDupstream(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004780 """Prints or sets the name of the upstream branch, if any."""
dpranke@chromium.org97ae58e2011-03-18 00:29:20 +00004781 _, args = parser.parse_args(args)
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00004782 if len(args) > 1:
maruel@chromium.org27bb3872011-05-30 20:33:19 +00004783 parser.error('Unrecognized args: %s' % ' '.join(args))
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00004784
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004785 cl = Changelist()
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00004786 if args:
4787 # One arg means set upstream branch.
bauerb@chromium.orgc9cf90a2014-04-28 20:32:31 +00004788 branch = cl.GetBranch()
stip7a3dd352016-09-22 17:32:28 -07004789 RunGit(['branch', '--set-upstream-to', args[0], branch])
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00004790 cl = Changelist()
vapiera7fbd5a2016-06-16 09:17:49 -07004791 print('Upstream branch set to %s' % (cl.GetUpstreamBranch(),))
bauerb@chromium.orgc9cf90a2014-04-28 20:32:31 +00004792
4793 # Clear configured merge-base, if there is one.
4794 git_common.remove_merge_base(branch)
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00004795 else:
vapiera7fbd5a2016-06-16 09:17:49 -07004796 print(cl.GetUpstreamBranch())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004797 return 0
4798
4799
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004800@metrics.collector.collect_metrics('git cl web')
thestig@chromium.org00858c82013-12-02 23:08:03 +00004801def CMDweb(parser, args):
4802 """Opens the current CL in the web browser."""
4803 _, args = parser.parse_args(args)
4804 if args:
4805 parser.error('Unrecognized args: %s' % ' '.join(args))
4806
4807 issue_url = Changelist().GetIssueURL()
4808 if not issue_url:
vapiera7fbd5a2016-06-16 09:17:49 -07004809 print('ERROR No issue to open', file=sys.stderr)
thestig@chromium.org00858c82013-12-02 23:08:03 +00004810 return 1
4811
Sergiy Byelozyorov2b718322018-10-24 17:43:31 +00004812 # Redirect I/O before invoking browser to hide its output. For example, this
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004813 # allows us to hide the "Created new window in existing browser session."
4814 # message from Chrome. Based on https://stackoverflow.com/a/2323563.
Sergiy Byelozyorov2b718322018-10-24 17:43:31 +00004815 saved_stdout = os.dup(1)
Sergiy Belozorov06684032019-03-06 16:53:08 +00004816 saved_stderr = os.dup(2)
Sergiy Byelozyorov2b718322018-10-24 17:43:31 +00004817 os.close(1)
Sergiy Belozorov06684032019-03-06 16:53:08 +00004818 os.close(2)
Sergiy Byelozyorov2b718322018-10-24 17:43:31 +00004819 os.open(os.devnull, os.O_RDWR)
4820 try:
4821 webbrowser.open(issue_url)
4822 finally:
4823 os.dup2(saved_stdout, 1)
Sergiy Belozorov06684032019-03-06 16:53:08 +00004824 os.dup2(saved_stderr, 2)
thestig@chromium.org00858c82013-12-02 23:08:03 +00004825 return 0
4826
4827
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004828@metrics.collector.collect_metrics('git cl set-commit')
maruel@chromium.org27bb3872011-05-30 20:33:19 +00004829def CMDset_commit(parser, args):
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +00004830 """Sets the commit bit to trigger the CQ."""
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00004831 parser.add_option('-d', '--dry-run', action='store_true',
4832 help='trigger in dry run mode')
4833 parser.add_option('-c', '--clear', action='store_true',
4834 help='stop CQ run, if any')
Edward Lemur52969c92020-02-06 18:15:28 +00004835 parser.add_option(
4836 '-i', '--issue', type=int,
4837 help='Operate on this issue instead of the current branch\'s implicit '
4838 'issue.')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004839 options, args = parser.parse_args(args)
maruel@chromium.org27bb3872011-05-30 20:33:19 +00004840 if args:
4841 parser.error('Unrecognized args: %s' % ' '.join(args))
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00004842 if options.dry_run and options.clear:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004843 parser.error('Only one of --dry-run and --clear are allowed.')
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00004844
Edward Lemur934836a2019-09-09 20:16:54 +00004845 cl = Changelist(issue=options.issue)
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00004846 if options.clear:
tandriid9e5ce52016-07-13 02:32:59 -07004847 state = _CQState.NONE
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00004848 elif options.dry_run:
4849 state = _CQState.DRY_RUN
4850 else:
4851 state = _CQState.COMMIT
4852 if not cl.GetIssue():
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004853 parser.error('Must upload the issue first.')
tandrii9de9ec62016-07-13 03:01:59 -07004854 cl.SetCQState(state)
maruel@chromium.org27bb3872011-05-30 20:33:19 +00004855 return 0
4856
4857
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004858@metrics.collector.collect_metrics('git cl set-close')
groby@chromium.org411034a2013-02-26 15:12:01 +00004859def CMDset_close(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004860 """Closes the issue."""
Edward Lemur52969c92020-02-06 18:15:28 +00004861 parser.add_option(
4862 '-i', '--issue', type=int,
4863 help='Operate on this issue instead of the current branch\'s implicit '
4864 'issue.')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004865 options, args = parser.parse_args(args)
groby@chromium.org411034a2013-02-26 15:12:01 +00004866 if args:
4867 parser.error('Unrecognized args: %s' % ' '.join(args))
Edward Lemur934836a2019-09-09 20:16:54 +00004868 cl = Changelist(issue=options.issue)
groby@chromium.org411034a2013-02-26 15:12:01 +00004869 # Ensure there actually is an issue to close.
Aaron Gable7139a4e2017-09-05 17:53:09 -07004870 if not cl.GetIssue():
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004871 DieWithError('ERROR: No issue to close.')
groby@chromium.org411034a2013-02-26 15:12:01 +00004872 cl.CloseIssue()
4873 return 0
4874
4875
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004876@metrics.collector.collect_metrics('git cl diff')
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00004877def CMDdiff(parser, args):
wychen@chromium.org37b2ec02015-04-03 00:49:15 +00004878 """Shows differences between local tree and last upload."""
thomasanderson074beb22016-08-29 14:03:20 -07004879 parser.add_option(
4880 '--stat',
4881 action='store_true',
4882 dest='stat',
4883 help='Generate a diffstat')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004884 options, args = parser.parse_args(args)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004885 if args:
4886 parser.error('Unrecognized args: %s' % ' '.join(args))
wychen@chromium.org46309bf2015-04-03 21:04:49 +00004887
Edward Lemur934836a2019-09-09 20:16:54 +00004888 cl = Changelist()
sbc@chromium.org78dc9842013-11-25 18:43:44 +00004889 issue = cl.GetIssue()
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00004890 branch = cl.GetBranch()
sbc@chromium.org78dc9842013-11-25 18:43:44 +00004891 if not issue:
4892 DieWithError('No issue found for current branch (%s)' % branch)
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00004893
Aaron Gablea718c3e2017-08-28 17:47:28 -07004894 base = cl._GitGetBranchConfigValue('last-upload-hash')
4895 if not base:
4896 base = cl._GitGetBranchConfigValue('gerritsquashhash')
4897 if not base:
4898 detail = cl._GetChangeDetail(['CURRENT_REVISION', 'CURRENT_COMMIT'])
4899 revision_info = detail['revisions'][detail['current_revision']]
4900 fetch_info = revision_info['fetch']['http']
4901 RunGit(['fetch', fetch_info['url'], fetch_info['ref']])
4902 base = 'FETCH_HEAD'
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00004903
Aaron Gablea718c3e2017-08-28 17:47:28 -07004904 cmd = ['git', 'diff']
4905 if options.stat:
4906 cmd.append('--stat')
4907 cmd.append(base)
4908 subprocess2.check_call(cmd)
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00004909
4910 return 0
4911
4912
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004913@metrics.collector.collect_metrics('git cl owners')
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00004914def CMDowners(parser, args):
Dirk Prankebf980882017-09-02 15:08:00 -07004915 """Finds potential owners for reviewing."""
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00004916 parser.add_option(
Sidney San Martín8e6f58c2018-06-08 01:02:56 +00004917 '--ignore-current',
4918 action='store_true',
4919 help='Ignore the CL\'s current reviewers and start from scratch.')
4920 parser.add_option(
Sylvain Defresneb1f865d2019-02-12 12:38:22 +00004921 '--ignore-self',
4922 action='store_true',
4923 help='Do not consider CL\'s author as an owners.')
4924 parser.add_option(
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00004925 '--no-color',
4926 action='store_true',
4927 help='Use this option to disable color output')
Dirk Prankebf980882017-09-02 15:08:00 -07004928 parser.add_option(
4929 '--batch',
4930 action='store_true',
4931 help='Do not run interactively, just suggest some')
Yang Guo6e269a02019-06-26 11:17:02 +00004932 # TODO: Consider moving this to another command, since other
4933 # git-cl owners commands deal with owners for a given CL.
4934 parser.add_option(
4935 '--show-all',
4936 action='store_true',
4937 help='Show all owners for a particular file')
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00004938 options, args = parser.parse_args(args)
4939
4940 author = RunGit(['config', 'user.email']).strip() or None
4941
Edward Lemur934836a2019-09-09 20:16:54 +00004942 cl = Changelist()
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00004943
Yang Guo6e269a02019-06-26 11:17:02 +00004944 if options.show_all:
4945 for arg in args:
4946 base_branch = cl.GetCommonAncestorWithUpstream()
Edward Lemur7f6dec02020-02-06 20:23:58 +00004947 database = owners.Database(settings.GetRoot(), file, os.path)
Yang Guo6e269a02019-06-26 11:17:02 +00004948 database.load_data_needed_for([arg])
4949 print('Owners for %s:' % arg)
4950 for owner in sorted(database.all_possible_owners([arg], None)):
4951 print(' - %s' % owner)
4952 return 0
4953
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00004954 if args:
4955 if len(args) > 1:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004956 parser.error('Unknown args.')
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00004957 base_branch = args[0]
4958 else:
4959 # Default to diffing against the common ancestor of the upstream branch.
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00004960 base_branch = cl.GetCommonAncestorWithUpstream()
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00004961
Edward Lemur7f6dec02020-02-06 20:23:58 +00004962 change = cl.GetChange(base_branch)
Dirk Prankebf980882017-09-02 15:08:00 -07004963 affected_files = [f.LocalPath() for f in change.AffectedFiles()]
4964
4965 if options.batch:
4966 db = owners.Database(change.RepositoryRoot(), file, os.path)
4967 print('\n'.join(db.reviewers_for(affected_files, author)))
4968 return 0
4969
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00004970 return owners_finder.OwnersFinder(
Dirk Prankebf980882017-09-02 15:08:00 -07004971 affected_files,
Jochen Eisinger72606f82017-04-04 10:44:18 +02004972 change.RepositoryRoot(),
Edward Lemur707d70b2018-02-07 00:50:14 +01004973 author,
Sidney San Martín8e6f58c2018-06-08 01:02:56 +00004974 [] if options.ignore_current else cl.GetReviewers(),
Edward Lemur707d70b2018-02-07 00:50:14 +01004975 fopen=file, os_path=os.path,
Jochen Eisingerd0573ec2017-04-13 10:55:06 +02004976 disable_color=options.no_color,
Sylvain Defresneb1f865d2019-02-12 12:38:22 +00004977 override_files=change.OriginalOwnersFiles(),
4978 ignore_author=options.ignore_self).run()
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00004979
4980
Aiden Bennerc08566e2018-10-03 17:52:42 +00004981def BuildGitDiffCmd(diff_type, upstream_commit, args, allow_prefix=False):
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00004982 """Generates a diff command."""
4983 # Generate diff for the current branch's changes.
Aiden Bennerc08566e2018-10-03 17:52:42 +00004984 diff_cmd = ['-c', 'core.quotePath=false', 'diff', '--no-ext-diff']
4985
Aiden Benner6c18a1a2018-11-23 20:18:23 +00004986 if allow_prefix:
4987 # explicitly setting --src-prefix and --dst-prefix is necessary in the
4988 # case that diff.noprefix is set in the user's git config.
4989 diff_cmd += ['--src-prefix=a/', '--dst-prefix=b/']
4990 else:
Aiden Bennerc08566e2018-10-03 17:52:42 +00004991 diff_cmd += ['--no-prefix']
4992
4993 diff_cmd += [diff_type, upstream_commit, '--']
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00004994
4995 if args:
4996 for arg in args:
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00004997 if os.path.isdir(arg) or os.path.isfile(arg):
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00004998 diff_cmd.append(arg)
4999 else:
5000 DieWithError('Argument "%s" is not a file or a directory' % arg)
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005001
5002 return diff_cmd
5003
Andrii Shyshkalov18975322017-01-25 16:44:13 +01005004
Jamie Madill5e96ad12020-01-13 16:08:35 +00005005def _RunClangFormatDiff(opts, clang_diff_files, top_dir, upstream_commit):
5006 """Runs clang-format-diff and sets a return value if necessary."""
5007
5008 if not clang_diff_files:
5009 return 0
5010
5011 # Set to 2 to signal to CheckPatchFormatted() that this patch isn't
5012 # formatted. This is used to block during the presubmit.
5013 return_value = 0
5014
5015 # Locate the clang-format binary in the checkout
5016 try:
5017 clang_format_tool = clang_format.FindClangFormatToolInChromiumTree()
5018 except clang_format.NotFoundError as e:
5019 DieWithError(e)
5020
5021 if opts.full or settings.GetFormatFullByDefault():
5022 cmd = [clang_format_tool]
5023 if not opts.dry_run and not opts.diff:
5024 cmd.append('-i')
5025 if opts.dry_run:
5026 for diff_file in clang_diff_files:
5027 with open(diff_file, 'r') as myfile:
5028 code = myfile.read().replace('\r\n', '\n')
5029 stdout = RunCommand(cmd + [diff_file], cwd=top_dir)
5030 stdout = stdout.replace('\r\n', '\n')
5031 if opts.diff:
5032 sys.stdout.write(stdout)
5033 if code != stdout:
5034 return_value = 2
5035 else:
5036 stdout = RunCommand(cmd + clang_diff_files, cwd=top_dir)
5037 if opts.diff:
5038 sys.stdout.write(stdout)
5039 else:
5040 env = os.environ.copy()
5041 env['PATH'] = str(os.path.dirname(clang_format_tool))
5042 try:
5043 script = clang_format.FindClangFormatScriptInChromiumTree(
5044 'clang-format-diff.py')
5045 except clang_format.NotFoundError as e:
5046 DieWithError(e)
5047
5048 cmd = [sys.executable, script, '-p0']
5049 if not opts.dry_run and not opts.diff:
5050 cmd.append('-i')
5051
5052 diff_cmd = BuildGitDiffCmd('-U0', upstream_commit, clang_diff_files)
Edward Lemur1a83da12020-03-04 21:18:36 +00005053 diff_output = RunGit(diff_cmd).encode('utf-8')
Jamie Madill5e96ad12020-01-13 16:08:35 +00005054
5055 stdout = RunCommand(cmd, stdin=diff_output, cwd=top_dir, env=env)
5056 if opts.diff:
5057 sys.stdout.write(stdout)
5058 if opts.dry_run and len(stdout) > 0:
5059 return_value = 2
5060
5061 return return_value
5062
5063
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005064def MatchingFileType(file_name, extensions):
Quinten Yearsleyd242ed72019-07-25 17:17:55 +00005065 """Returns True if the file name ends with one of the given extensions."""
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005066 return bool([ext for ext in extensions if file_name.lower().endswith(ext)])
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005067
Andrii Shyshkalov18975322017-01-25 16:44:13 +01005068
enne@chromium.org555cfe42014-01-29 18:21:39 +00005069@subcommand.usage('[files or directories to diff]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005070@metrics.collector.collect_metrics('git cl format')
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005071def CMDformat(parser, args):
sbc@chromium.org9d0644d2015-06-05 23:16:54 +00005072 """Runs auto-formatting tools (clang-format etc.) on the diff."""
Christopher Lamc5ba6922017-01-24 11:19:14 +11005073 CLANG_EXTS = ['.cc', '.cpp', '.h', '.m', '.mm', '.proto', '.java']
kylechar58edce22016-06-17 06:07:51 -07005074 GN_EXTS = ['.gn', '.gni', '.typemap']
enne@chromium.org3b7e15c2014-01-21 17:44:47 +00005075 parser.add_option('--full', action='store_true',
5076 help='Reformat the full content of all touched files')
5077 parser.add_option('--dry-run', action='store_true',
5078 help='Don\'t modify any file on disk.')
Aiden Benner99b0ccb2018-11-20 19:53:31 +00005079 parser.add_option(
Garrett Beatyed0cc5f2020-01-06 17:26:13 +00005080 '--no-clang-format',
5081 dest='clang_format',
5082 action='store_false',
5083 default=True,
5084 help='Disables formatting of various file types using clang-format.')
5085 parser.add_option(
Aiden Benner99b0ccb2018-11-20 19:53:31 +00005086 '--python',
5087 action='store_true',
5088 default=None,
5089 help='Enables python formatting on all python files.')
5090 parser.add_option(
5091 '--no-python',
5092 action='store_true',
Garrett Beaty91a6f332020-01-06 16:57:24 +00005093 default=False,
Aiden Benner99b0ccb2018-11-20 19:53:31 +00005094 help='Disables python formatting on all python files. '
Garrett Beaty91a6f332020-01-06 16:57:24 +00005095 'If neither --python or --no-python are set, python files that have a '
5096 '.style.yapf file in an ancestor directory will be formatted. '
5097 'It is an error to set both.')
Garrett Beatyed0cc5f2020-01-06 17:26:13 +00005098 parser.add_option(
5099 '--js',
5100 action='store_true',
5101 help='Format javascript code with clang-format. '
5102 'Has no effect if --no-clang-format is set.')
wittman@chromium.org04d5a222014-03-07 18:30:42 +00005103 parser.add_option('--diff', action='store_true',
5104 help='Print diff to stdout rather than modifying files.')
Ilya Shermane081cbe2017-08-15 17:51:04 -07005105 parser.add_option('--presubmit', action='store_true',
5106 help='Used when running the script from a presubmit.')
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005107 opts, args = parser.parse_args(args)
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005108
Garrett Beaty91a6f332020-01-06 16:57:24 +00005109 if opts.python is not None and opts.no_python:
5110 raise parser.error('Cannot set both --python and --no-python')
5111 if opts.no_python:
5112 opts.python = False
5113
Daniel Chengc55eecf2016-12-30 03:11:02 -08005114 # Normalize any remaining args against the current path, so paths relative to
5115 # the current directory are still resolved as expected.
5116 args = [os.path.join(os.getcwd(), arg) for arg in args]
5117
enne@chromium.orgff7a1fb2013-12-10 19:21:41 +00005118 # git diff generates paths against the root of the repository. Change
5119 # to that directory so clang-format can find files even within subdirs.
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00005120 rel_base_path = settings.GetRelativeRoot()
enne@chromium.orgff7a1fb2013-12-10 19:21:41 +00005121 if rel_base_path:
5122 os.chdir(rel_base_path)
5123
digit@chromium.org29e47272013-05-17 17:01:46 +00005124 # Grab the merge-base commit, i.e. the upstream commit of the current
5125 # branch when it was created or the last time it was rebased. This is
5126 # to cover the case where the user may have called "git fetch origin",
5127 # moving the origin branch to a newer commit, but hasn't rebased yet.
5128 upstream_commit = None
5129 cl = Changelist()
5130 upstream_branch = cl.GetUpstreamBranch()
5131 if upstream_branch:
5132 upstream_commit = RunGit(['merge-base', 'HEAD', upstream_branch])
5133 upstream_commit = upstream_commit.strip()
5134
5135 if not upstream_commit:
5136 DieWithError('Could not find base commit for this branch. '
5137 'Are you in detached state?')
5138
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005139 changed_files_cmd = BuildGitDiffCmd('--name-only', upstream_commit, args)
5140 diff_output = RunGit(changed_files_cmd)
5141 diff_files = diff_output.splitlines()
jkarlin@chromium.orgad21b922016-01-28 17:48:42 +00005142 # Filter out files deleted by this CL
5143 diff_files = [x for x in diff_files if os.path.isfile(x)]
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005144
Andreas Haas417d89c2020-02-06 10:24:27 +00005145 if opts.js:
Deepanjan Roy605dd312018-07-02 17:48:54 +00005146 CLANG_EXTS.extend(['.js', '.ts'])
Christopher Lamc5ba6922017-01-24 11:19:14 +11005147
Garrett Beatyed0cc5f2020-01-06 17:26:13 +00005148 clang_diff_files = []
5149 if opts.clang_format:
5150 clang_diff_files = [
5151 x for x in diff_files if MatchingFileType(x, CLANG_EXTS)
5152 ]
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005153 python_diff_files = [x for x in diff_files if MatchingFileType(x, ['.py'])]
5154 dart_diff_files = [x for x in diff_files if MatchingFileType(x, ['.dart'])]
kylechar@chromium.org8b61f112016-02-05 13:28:58 +00005155 gn_diff_files = [x for x in diff_files if MatchingFileType(x, GN_EXTS)]
digit@chromium.org29e47272013-05-17 17:01:46 +00005156
nick@chromium.org3ac1c4e2014-01-16 02:44:42 +00005157 top_dir = os.path.normpath(
5158 RunGit(["rev-parse", "--show-toplevel"]).rstrip('\n'))
5159
Jamie Madill5e96ad12020-01-13 16:08:35 +00005160 return_value = _RunClangFormatDiff(opts, clang_diff_files, top_dir,
5161 upstream_commit)
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005162
sbc@chromium.org9d0644d2015-06-05 23:16:54 +00005163 # Similar code to above, but using yapf on .py files rather than clang-format
5164 # on C/C++ files
Aiden Benner99b0ccb2018-11-20 19:53:31 +00005165 py_explicitly_disabled = opts.python is not None and not opts.python
5166 if python_diff_files and not py_explicitly_disabled:
Aiden Bennere47ac152018-11-20 16:44:03 +00005167 depot_tools_path = os.path.dirname(os.path.abspath(__file__))
5168 yapf_tool = os.path.join(depot_tools_path, 'yapf')
5169 if sys.platform.startswith('win'):
5170 yapf_tool += '.bat'
sbc@chromium.org9d0644d2015-06-05 23:16:54 +00005171
Aiden Bennerc08566e2018-10-03 17:52:42 +00005172 # Used for caching.
5173 yapf_configs = {}
5174 for f in python_diff_files:
5175 # Find the yapf style config for the current file, defaults to depot
5176 # tools default.
Aiden Benner99b0ccb2018-11-20 19:53:31 +00005177 _FindYapfConfigFile(f, yapf_configs, top_dir)
5178
5179 # Turn on python formatting by default if a yapf config is specified.
5180 # This breaks in the case of this repo though since the specified
5181 # style file is also the global default.
5182 if opts.python is None:
5183 filtered_py_files = []
5184 for f in python_diff_files:
5185 if _FindYapfConfigFile(f, yapf_configs, top_dir) is not None:
5186 filtered_py_files.append(f)
5187 else:
5188 filtered_py_files = python_diff_files
5189
5190 # Note: yapf still seems to fix indentation of the entire file
5191 # even if line ranges are specified.
5192 # See https://github.com/google/yapf/issues/499
5193 if not opts.full and filtered_py_files:
5194 py_line_diffs = _ComputeDiffLineRanges(filtered_py_files, upstream_commit)
5195
Brian Sheedyb4307d52019-12-02 19:18:17 +00005196 yapfignore_patterns = _GetYapfIgnorePatterns(top_dir)
5197 filtered_py_files = _FilterYapfIgnoredFiles(filtered_py_files,
5198 yapfignore_patterns)
Brian Sheedy59b06a82019-10-14 17:03:29 +00005199
Aiden Benner99b0ccb2018-11-20 19:53:31 +00005200 for f in filtered_py_files:
Andrew Grievefa40bfa2020-01-07 02:32:57 +00005201 yapf_style = _FindYapfConfigFile(f, yapf_configs, top_dir)
5202 # Default to pep8 if not .style.yapf is found.
5203 if not yapf_style:
5204 yapf_style = 'pep8'
Aiden Bennerc08566e2018-10-03 17:52:42 +00005205
Andrew Grievefa40bfa2020-01-07 02:32:57 +00005206 cmd = [yapf_tool, '--style', yapf_style, f]
Aiden Bennerc08566e2018-10-03 17:52:42 +00005207
5208 has_formattable_lines = False
5209 if not opts.full:
5210 # Only run yapf over changed line ranges.
5211 for diff_start, diff_len in py_line_diffs[f]:
5212 diff_end = diff_start + diff_len - 1
5213 # Yapf errors out if diff_end < diff_start but this
5214 # is a valid line range diff for a removal.
5215 if diff_end >= diff_start:
5216 has_formattable_lines = True
5217 cmd += ['-l', '{}-{}'.format(diff_start, diff_end)]
5218 # If all line diffs were removals we have nothing to format.
5219 if not has_formattable_lines:
5220 continue
5221
5222 if opts.diff or opts.dry_run:
5223 cmd += ['--diff']
5224 # Will return non-zero exit code if non-empty diff.
5225 stdout = RunCommand(cmd, error_ok=True, cwd=top_dir)
5226 if opts.diff:
5227 sys.stdout.write(stdout)
5228 elif len(stdout) > 0:
5229 return_value = 2
5230 else:
5231 cmd += ['-i']
5232 RunCommand(cmd, cwd=top_dir)
sbc@chromium.org9d0644d2015-06-05 23:16:54 +00005233
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005234 # Dart's formatter does not have the nice property of only operating on
5235 # modified chunks, so hard code full.
5236 if dart_diff_files:
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005237 try:
5238 command = [dart_format.FindDartFmtToolInChromiumTree()]
5239 if not opts.dry_run and not opts.diff:
5240 command.append('-w')
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005241 command.extend(dart_diff_files)
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005242
ppi@chromium.org6593d932016-03-03 15:41:15 +00005243 stdout = RunCommand(command, cwd=top_dir)
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005244 if opts.dry_run and stdout:
5245 return_value = 2
Jamie Madill5e96ad12020-01-13 16:08:35 +00005246 except dart_format.NotFoundError:
vapiera7fbd5a2016-06-16 09:17:49 -07005247 print('Warning: Unable to check Dart code formatting. Dart SDK not '
5248 'found in this checkout. Files in other languages are still '
5249 'formatted.')
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005250
kylechar@chromium.org8b61f112016-02-05 13:28:58 +00005251 # Format GN build files. Always run on full build files for canonical form.
5252 if gn_diff_files:
Andrii Shyshkalov18975322017-01-25 16:44:13 +01005253 cmd = ['gn', 'format']
brettw4b8ed592016-08-05 16:19:12 -07005254 if opts.dry_run or opts.diff:
5255 cmd.append('--dry-run')
kylechar@chromium.org8b61f112016-02-05 13:28:58 +00005256 for gn_diff_file in gn_diff_files:
brettw4b8ed592016-08-05 16:19:12 -07005257 gn_ret = subprocess2.call(cmd + [gn_diff_file],
5258 shell=sys.platform == 'win32',
5259 cwd=top_dir)
5260 if opts.dry_run and gn_ret == 2:
5261 return_value = 2 # Not formatted.
5262 elif opts.diff and gn_ret == 2:
5263 # TODO this should compute and print the actual diff.
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005264 print('This change has GN build file diff for ' + gn_diff_file)
brettw4b8ed592016-08-05 16:19:12 -07005265 elif gn_ret != 0:
5266 # For non-dry run cases (and non-2 return values for dry-run), a
5267 # nonzero error code indicates a failure, probably because the file
5268 # doesn't parse.
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005269 DieWithError('gn format failed on ' + gn_diff_file +
5270 '\nTry running `gn format` on this file manually.')
kylechar@chromium.org8b61f112016-02-05 13:28:58 +00005271
Ilya Shermane081cbe2017-08-15 17:51:04 -07005272 # Skip the metrics formatting from the global presubmit hook. These files have
5273 # a separate presubmit hook that issues an error if the files need formatting,
5274 # whereas the top-level presubmit script merely issues a warning. Formatting
5275 # these files is somewhat slow, so it's important not to duplicate the work.
5276 if not opts.presubmit:
5277 for xml_dir in GetDirtyMetricsDirs(diff_files):
5278 tool_dir = os.path.join(top_dir, xml_dir)
5279 cmd = [os.path.join(tool_dir, 'pretty_print.py'), '--non-interactive']
5280 if opts.dry_run or opts.diff:
5281 cmd.append('--diff')
Ilya Sherman235b70d2017-08-22 17:46:38 -07005282 stdout = RunCommand(cmd, cwd=top_dir)
Ilya Shermane081cbe2017-08-15 17:51:04 -07005283 if opts.diff:
5284 sys.stdout.write(stdout)
5285 if opts.dry_run and stdout:
5286 return_value = 2 # Not formatted.
Alexei Svitkinef3cac412017-02-06 11:08:50 -05005287
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005288 return return_value
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005289
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005290
Steven Holte2e664bf2017-04-21 13:10:47 -07005291def GetDirtyMetricsDirs(diff_files):
5292 xml_diff_files = [x for x in diff_files if MatchingFileType(x, ['.xml'])]
5293 metrics_xml_dirs = [
5294 os.path.join('tools', 'metrics', 'actions'),
5295 os.path.join('tools', 'metrics', 'histograms'),
5296 os.path.join('tools', 'metrics', 'rappor'),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005297 os.path.join('tools', 'metrics', 'ukm'),
5298 ]
Steven Holte2e664bf2017-04-21 13:10:47 -07005299 for xml_dir in metrics_xml_dirs:
5300 if any(file.startswith(xml_dir) for file in xml_diff_files):
5301 yield xml_dir
5302
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005303
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005304@subcommand.usage('<codereview url or issue id>')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005305@metrics.collector.collect_metrics('git cl checkout')
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005306def CMDcheckout(parser, args):
Edward Lemurf38bc172019-09-03 21:02:13 +00005307 """Checks out a branch associated with a given Gerrit issue."""
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005308 _, args = parser.parse_args(args)
5309
5310 if len(args) != 1:
5311 parser.print_help()
5312 return 1
5313
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00005314 issue_arg = ParseIssueNumberArgument(args[0])
tandrii@chromium.orgde6c9a12016-04-11 15:33:53 +00005315 if not issue_arg.valid:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00005316 parser.error('Invalid issue ID or URL.')
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02005317
tandrii@chromium.orgabd27e52016-04-11 15:43:32 +00005318 target_issue = str(issue_arg.issue)
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005319
Edward Lemur52969c92020-02-06 18:15:28 +00005320 issueprefix = Changelist.IssueConfigKey()
5321 output = RunGit(['config', '--local', '--get-regexp',
5322 r'branch\..*\.%s' % issueprefix],
5323 error_ok=True)
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005324
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00005325 branches = []
Edward Lemur52969c92020-02-06 18:15:28 +00005326 for key, issue in [x.split() for x in output.splitlines()]:
5327 if issue == target_issue:
5328 branches.append(re.sub(r'branch\.(.*)\.%s' % issueprefix, r'\1', key))
5329
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005330 if len(branches) == 0:
vapiera7fbd5a2016-06-16 09:17:49 -07005331 print('No branch found for issue %s.' % target_issue)
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005332 return 1
5333 if len(branches) == 1:
5334 RunGit(['checkout', branches[0]])
5335 else:
vapiera7fbd5a2016-06-16 09:17:49 -07005336 print('Multiple branches match issue %s:' % target_issue)
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005337 for i in range(len(branches)):
vapiera7fbd5a2016-06-16 09:17:49 -07005338 print('%d: %s' % (i, branches[i]))
Edward Lemur1a83da12020-03-04 21:18:36 +00005339 which = ask_for_data('Choose by index: ')
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005340 try:
5341 RunGit(['checkout', branches[int(which)]])
5342 except (IndexError, ValueError):
vapiera7fbd5a2016-06-16 09:17:49 -07005343 print('Invalid selection, not checking out any branch.')
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005344 return 1
5345
5346 return 0
5347
5348
maruel@chromium.org29404b52014-09-08 22:58:00 +00005349def CMDlol(parser, args):
5350 # This command is intentionally undocumented.
vapiera7fbd5a2016-06-16 09:17:49 -07005351 print(zlib.decompress(base64.b64decode(
thakis@chromium.org3421c992014-11-02 02:20:32 +00005352 'eNptkLEOwyAMRHe+wupCIqW57v0Vq84WqWtXyrcXnCBsmgMJ+/SSAxMZgRB6NzE'
5353 'E2ObgCKJooYdu4uAQVffUEoE1sRQLxAcqzd7uK2gmStrll1ucV3uZyaY5sXyDd9'
5354 'JAnN+lAXsOMJ90GANAi43mq5/VeeacylKVgi8o6F1SC63FxnagHfJUTfUYdCR/W'
vapiera7fbd5a2016-06-16 09:17:49 -07005355 'Ofe+0dHL7PicpytKP750Fh1q2qnLVof4w8OZWNY')))
maruel@chromium.org29404b52014-09-08 22:58:00 +00005356 return 0
5357
5358
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005359class OptionParser(optparse.OptionParser):
5360 """Creates the option parse and add --verbose support."""
5361 def __init__(self, *args, **kwargs):
maruel@chromium.org0633fb42013-08-16 20:06:14 +00005362 optparse.OptionParser.__init__(
5363 self, *args, prog='git cl', version=__version__, **kwargs)
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005364 self.add_option(
5365 '-v', '--verbose', action='count', default=0,
5366 help='Use 2 times for more debugging info')
5367
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005368 def parse_args(self, args=None, _values=None):
Andrii Shyshkalov46f20cd2018-10-30 06:42:54 +00005369 try:
5370 return self._parse_args(args)
5371 finally:
5372 # Regardless of success or failure of args parsing, we want to report
5373 # metrics, but only after logging has been initialized (if parsing
5374 # succeeded).
5375 global settings
5376 settings = Settings()
5377
5378 if not metrics.DISABLE_METRICS_COLLECTION:
5379 # GetViewVCUrl ultimately calls logging method.
5380 project_url = settings.GetViewVCUrl().strip('/+')
5381 if project_url in metrics_utils.KNOWN_PROJECT_URLS:
5382 metrics.collector.add('project_urls', [project_url])
5383
5384 def _parse_args(self, args=None):
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005385 # Create an optparse.Values object that will store only the actual passed
5386 # options, without the defaults.
5387 actual_options = optparse.Values()
5388 _, args = optparse.OptionParser.parse_args(self, args, actual_options)
5389 # Create an optparse.Values object with the default options.
5390 options = optparse.Values(self.get_default_values().__dict__)
5391 # Update it with the options passed by the user.
5392 options._update_careful(actual_options.__dict__)
5393 # Store the options passed by the user in an _actual_options attribute.
5394 # We store only the keys, and not the values, since the values can contain
5395 # arbitrary information, which might be PII.
Edward Lemur79d4f992019-11-11 23:49:02 +00005396 metrics.collector.add('arguments', list(actual_options.__dict__.keys()))
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005397
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005398 levels = [logging.WARNING, logging.INFO, logging.DEBUG]
Andrii Shyshkalov5b04a572017-01-23 17:44:41 +01005399 logging.basicConfig(
5400 level=levels[min(options.verbose, len(levels) - 1)],
5401 format='[%(levelname).1s%(asctime)s %(process)d %(thread)d '
5402 '%(filename)s] %(message)s')
Edward Lemur83bd7f42018-10-10 00:14:21 +00005403
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005404 return options, args
5405
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005406
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005407def main(argv):
maruel@chromium.org82798cb2012-02-23 18:16:12 +00005408 if sys.hexversion < 0x02060000:
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005409 print('\nYour Python version %s is unsupported, please upgrade.\n' %
vapiera7fbd5a2016-06-16 09:17:49 -07005410 (sys.version.split(' ', 1)[0],), file=sys.stderr)
maruel@chromium.org82798cb2012-02-23 18:16:12 +00005411 return 2
maruel@chromium.org2e23ce32013-05-07 12:42:28 +00005412
maruel@chromium.org39c0b222013-08-17 16:57:01 +00005413 colorize_CMDstatus_doc()
maruel@chromium.org0633fb42013-08-16 20:06:14 +00005414 dispatcher = subcommand.CommandDispatcher(__name__)
5415 try:
5416 return dispatcher.execute(OptionParser(), argv)
Edward Lemur5b929a42019-10-21 17:57:39 +00005417 except auth.LoginRequiredError as e:
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +00005418 DieWithError(str(e))
Edward Lemur79d4f992019-11-11 23:49:02 +00005419 except urllib.error.HTTPError as e:
maruel@chromium.org0633fb42013-08-16 20:06:14 +00005420 if e.code != 500:
5421 raise
5422 DieWithError(
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005423 ('App Engine is misbehaving and returned HTTP %d, again. Keep faith '
Quinten Yearsleyc4202212019-07-22 23:34:40 +00005424 'and retry or visit go/isgaeup.\n%s') % (e.code, str(e)))
sbc@chromium.org013731e2015-02-26 18:28:43 +00005425 return 0
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005426
5427
5428if __name__ == '__main__':
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005429 # These affect sys.stdout, so do it outside of main() to simplify mocks in
5430 # the unit tests.
maruel@chromium.org6f09cd92011-04-01 16:38:12 +00005431 fix_encoding.fix_encoding()
iannucci@chromium.org596cd5c2016-04-04 21:34:39 +00005432 setup_color.init()
Edward Lemur6f812e12018-07-31 22:45:57 +00005433 with metrics.collector.print_notice_and_exit():
sbc@chromium.org013731e2015-02-26 18:28:43 +00005434 sys.exit(main(sys.argv[1:]))