blob: 28a8a98f2c54204924b08c7b10a181c64ea713c1 [file] [log] [blame]
Edward Lemur1f3bafb2019-10-08 17:56:33 +00001#!/usr/bin/env vpython
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +02002# Copyright (c) 2013 The Chromium Authors. All rights reserved.
maruel@chromium.org725f1c32011-04-01 20:24:54 +00003# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00006# Copyright (C) 2008 Evan Martin <martine@danga.com>
7
Andrii Shyshkalov03da1502018-10-15 03:42:34 +00008"""A git-command for integrating reviews on Gerrit."""
maruel@chromium.org725f1c32011-04-01 20:24:54 +00009
vapiera7fbd5a2016-06-16 09:17:49 -070010from __future__ import print_function
11
tapted@chromium.org6a0b07c2013-07-10 01:29:19 +000012from distutils.version import LooseVersion
calamity@chromium.orgffde55c2015-03-12 00:44:17 +000013from multiprocessing.pool import ThreadPool
thakis@chromium.org3421c992014-11-02 02:20:32 +000014import base64
rmistry@google.com2dd99862015-06-22 12:22:18 +000015import collections
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +010016import datetime
Brian Sheedyb4307d52019-12-02 19:18:17 +000017import fnmatch
Edward Lemur202c5592019-10-21 22:44:52 +000018import httplib2
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +010019import itertools
maruel@chromium.org4f6852c2012-04-20 20:39:20 +000020import json
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000021import logging
calamity@chromium.orgcf197482016-04-29 20:15:53 +000022import multiprocessing
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000023import optparse
24import os
25import re
Andrii Shyshkalov353637c2017-03-14 16:52:18 +010026import shutil
ukai@chromium.org78c4b982012-02-14 02:20:26 +000027import stat
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000028import sys
Aaron Gable9a03ae02017-11-03 11:31:07 -070029import tempfile
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000030import textwrap
Edward Lemurfec80c42018-11-01 23:14:14 +000031import time
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +000032import uuid
thestig@chromium.org00858c82013-12-02 23:08:03 +000033import webbrowser
thakis@chromium.org3421c992014-11-02 02:20:32 +000034import zlib
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000035
maruel@chromium.org2e23ce32013-05-07 12:42:28 +000036from third_party import colorama
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +000037import auth
nick@chromium.org3ac1c4e2014-01-16 02:44:42 +000038import clang_format
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +000039import dart_format
maruel@chromium.org6f09cd92011-04-01 16:38:12 +000040import fix_encoding
maruel@chromium.org0e0436a2011-10-25 13:32:41 +000041import gclient_utils
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +000042import gerrit_util
iannucci@chromium.org9e849272014-04-04 00:31:55 +000043import git_common
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +000044import git_footers
Edward Lemur85153282020-02-14 22:06:29 +000045import git_new_branch
Edward Lemur5ba1e9c2018-07-23 18:19:02 +000046import metrics
Edward Lesmes93277a72018-10-18 22:04:26 +000047import metrics_utils
piman@chromium.org336f9122014-09-04 02:16:55 +000048import owners
iannucci@chromium.org9e849272014-04-04 00:31:55 +000049import owners_finder
maruel@chromium.org2a74d372011-03-29 19:05:50 +000050import presubmit_support
51import scm
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +000052import setup_color
Francois Dorayd42c6812017-05-30 15:10:20 -040053import split_cl
maruel@chromium.org0633fb42013-08-16 20:06:14 +000054import subcommand
maruel@chromium.org32f9f5e2011-09-14 13:41:47 +000055import subprocess2
maruel@chromium.org2a74d372011-03-29 19:05:50 +000056import watchlists
57
Edward Lemur79d4f992019-11-11 23:49:02 +000058from third_party import six
59from six.moves import urllib
60
61
62if sys.version_info.major == 3:
63 basestring = (str,) # pylint: disable=redefined-builtin
64
Edward Lemurb9830242019-10-30 22:19:20 +000065
tandrii7400cf02016-06-21 08:48:07 -070066__version__ = '2.0'
maruel@chromium.org2a74d372011-03-29 19:05:50 +000067
Edward Lemur0f58ae42019-04-30 17:24:12 +000068# Traces for git push will be stored in a traces directory inside the
69# depot_tools checkout.
70DEPOT_TOOLS = os.path.dirname(os.path.abspath(__file__))
71TRACES_DIR = os.path.join(DEPOT_TOOLS, 'traces')
72
73# When collecting traces, Git hashes will be reduced to 6 characters to reduce
74# the size after compression.
75GIT_HASH_RE = re.compile(r'\b([a-f0-9]{6})[a-f0-9]{34}\b', flags=re.I)
76# Used to redact the cookies from the gitcookies file.
77GITCOOKIES_REDACT_RE = re.compile(r'1/.*')
78
Edward Lemurd4d1ba42019-09-20 21:46:37 +000079MAX_ATTEMPTS = 3
80
Edward Lemur1b52d872019-05-09 21:12:12 +000081# The maximum number of traces we will keep. Multiplied by 3 since we store
82# 3 files per trace.
83MAX_TRACES = 3 * 10
Edward Lemur5737f022019-05-17 01:24:00 +000084# Message to be displayed to the user to inform where to find the traces for a
85# git-cl upload execution.
Edward Lemur0f58ae42019-04-30 17:24:12 +000086TRACES_MESSAGE = (
Edward Lemur1b52d872019-05-09 21:12:12 +000087'\n'
Edward Lemur5737f022019-05-17 01:24:00 +000088'The traces of this git-cl execution have been recorded at:\n'
Edward Lemur1b52d872019-05-09 21:12:12 +000089' %(trace_name)s-traces.zip\n'
Edward Lemur5737f022019-05-17 01:24:00 +000090'Copies of your gitcookies file and git config have been recorded at:\n'
91' %(trace_name)s-git-info.zip\n')
Edward Lemur1b52d872019-05-09 21:12:12 +000092# Format of the message to be stored as part of the traces to give developers a
93# better context when they go through traces.
94TRACES_README_FORMAT = (
95'Date: %(now)s\n'
96'\n'
97'Change: https://%(gerrit_host)s/q/%(change_id)s\n'
98'Title: %(title)s\n'
99'\n'
100'%(description)s\n'
101'\n'
102'Execution time: %(execution_time)s\n'
103'Exit code: %(exit_code)s\n') + TRACES_MESSAGE
Edward Lemur0f58ae42019-04-30 17:24:12 +0000104
tandrii9d2c7a32016-06-22 03:42:45 -0700105COMMIT_BOT_EMAIL = 'commit-bot@chromium.org'
Aaron Gable1bc7bfe2016-12-19 10:08:14 -0800106POSTUPSTREAM_HOOK = '.git/hooks/post-cl-land'
Henrique Ferreiroff249622019-11-28 23:19:29 +0000107DESCRIPTION_BACKUP_FILE = '.git_cl_description_backup'
rmistry@google.comc68112d2015-03-03 12:48:06 +0000108REFS_THAT_ALIAS_TO_OTHER_REFS = {
109 'refs/remotes/origin/lkgr': 'refs/remotes/origin/master',
110 'refs/remotes/origin/lkcr': 'refs/remotes/origin/master',
111}
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000112
thestig@chromium.org44202a22014-03-11 19:22:18 +0000113# Valid extensions for files we want to lint.
114DEFAULT_LINT_REGEX = r"(.*\.cpp|.*\.cc|.*\.h)"
115DEFAULT_LINT_IGNORE_REGEX = r"$^"
116
Aiden Bennerc08566e2018-10-03 17:52:42 +0000117# File name for yapf style config files.
118YAPF_CONFIG_FILENAME = '.style.yapf'
119
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000120# Shortcut since it quickly becomes repetitive.
maruel@chromium.org2e23ce32013-05-07 12:42:28 +0000121Fore = colorama.Fore
maruel@chromium.org90541732011-04-01 17:54:18 +0000122
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000123# Initialized in main()
124settings = None
125
Andrii Shyshkalov768f1d82016-12-08 15:10:13 +0100126# Used by tests/git_cl_test.py to add extra logging.
127# Inside the weirdly failing test, add this:
128# >>> self.mock(git_cl, '_IS_BEING_TESTED', True)
Quinten Yearsley0c62da92017-05-31 13:39:42 -0700129# And scroll up to see the stack trace printed.
Andrii Shyshkalov768f1d82016-12-08 15:10:13 +0100130_IS_BEING_TESTED = False
131
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000132
Christopher Lamf732cd52017-01-24 12:40:11 +1100133def DieWithError(message, change_desc=None):
134 if change_desc:
135 SaveDescriptionBackup(change_desc)
136
vapiera7fbd5a2016-06-16 09:17:49 -0700137 print(message, file=sys.stderr)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000138 sys.exit(1)
139
140
Christopher Lamf732cd52017-01-24 12:40:11 +1100141def SaveDescriptionBackup(change_desc):
Henrique Ferreiro5ae48172019-11-29 16:14:42 +0000142 backup_path = os.path.join(DEPOT_TOOLS, DESCRIPTION_BACKUP_FILE)
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000143 print('\nsaving CL description to %s\n' % backup_path)
Josip906bfde2020-01-31 22:38:49 +0000144 with open(backup_path, 'w') as backup_file:
145 backup_file.write(change_desc.description)
Christopher Lamf732cd52017-01-24 12:40:11 +1100146
147
thestig@chromium.org8b0553c2014-02-11 00:33:37 +0000148def GetNoGitPagerEnv():
149 env = os.environ.copy()
150 # 'cat' is a magical git string that disables pagers on all platforms.
151 env['GIT_PAGER'] = 'cat'
152 return env
153
vadimsh@chromium.org566a02a2014-08-22 01:34:13 +0000154
bsep@chromium.org627d9002016-04-29 00:00:52 +0000155def RunCommand(args, error_ok=False, error_message=None, shell=False, **kwargs):
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000156 try:
Edward Lemur79d4f992019-11-11 23:49:02 +0000157 stdout = subprocess2.check_output(args, shell=shell, **kwargs)
158 return stdout.decode('utf-8', 'replace')
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000159 except subprocess2.CalledProcessError as e:
160 logging.debug('Failed running %s', args)
maruel@chromium.org32f9f5e2011-09-14 13:41:47 +0000161 if not error_ok:
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000162 DieWithError(
maruel@chromium.org32f9f5e2011-09-14 13:41:47 +0000163 'Command "%s" failed.\n%s' % (
164 ' '.join(args), error_message or e.stdout or ''))
Edward Lemur79d4f992019-11-11 23:49:02 +0000165 return e.stdout.decode('utf-8', 'replace')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000166
167
168def RunGit(args, **kwargs):
maruel@chromium.org32f9f5e2011-09-14 13:41:47 +0000169 """Returns stdout."""
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000170 return RunCommand(['git'] + args, **kwargs)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000171
172
enne@chromium.org3b7e15c2014-01-21 17:44:47 +0000173def RunGitWithCode(args, suppress_stderr=False):
maruel@chromium.org32f9f5e2011-09-14 13:41:47 +0000174 """Returns return code and stdout."""
tandrii5d48c322016-08-18 16:19:37 -0700175 if suppress_stderr:
176 stderr = subprocess2.VOID
177 else:
178 stderr = sys.stderr
szager@chromium.org9bb85e22012-06-13 20:28:23 +0000179 try:
tandrii5d48c322016-08-18 16:19:37 -0700180 (out, _), code = subprocess2.communicate(['git'] + args,
181 env=GetNoGitPagerEnv(),
182 stdout=subprocess2.PIPE,
183 stderr=stderr)
Edward Lemur79d4f992019-11-11 23:49:02 +0000184 return code, out.decode('utf-8', 'replace')
tandrii5d48c322016-08-18 16:19:37 -0700185 except subprocess2.CalledProcessError as e:
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +0900186 logging.debug('Failed running %s', ['git'] + args)
Edward Lemur79d4f992019-11-11 23:49:02 +0000187 return e.returncode, e.stdout.decode('utf-8', 'replace')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000188
189
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000190def RunGitSilent(args):
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +0000191 """Returns stdout, suppresses stderr and ignores the return code."""
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000192 return RunGitWithCode(args, suppress_stderr=True)[1]
193
194
tapted@chromium.org6a0b07c2013-07-10 01:29:19 +0000195def IsGitVersionAtLeast(min_version):
ilevy@chromium.orgcc56ee42013-07-10 22:16:29 +0000196 prefix = 'git version '
tapted@chromium.org6a0b07c2013-07-10 01:29:19 +0000197 version = RunGit(['--version']).strip()
ilevy@chromium.orgcc56ee42013-07-10 22:16:29 +0000198 return (version.startswith(prefix) and
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000199 LooseVersion(version[len(prefix):]) >= LooseVersion(min_version))
tapted@chromium.org6a0b07c2013-07-10 01:29:19 +0000200
201
pgervais@chromium.org8ba38ff2015-06-11 21:41:25 +0000202def BranchExists(branch):
203 """Return True if specified branch exists."""
204 code, _ = RunGitWithCode(['rev-parse', '--verify', branch],
205 suppress_stderr=True)
206 return not code
207
208
tandrii2a16b952016-10-19 07:09:44 -0700209def time_sleep(seconds):
210 # Use this so that it can be mocked in tests without interfering with python
211 # system machinery.
tandrii2a16b952016-10-19 07:09:44 -0700212 return time.sleep(seconds)
213
214
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000215def time_time():
216 # Use this so that it can be mocked in tests without interfering with python
217 # system machinery.
218 return time.time()
219
220
Edward Lemur1b52d872019-05-09 21:12:12 +0000221def datetime_now():
222 # Use this so that it can be mocked in tests without interfering with python
223 # system machinery.
224 return datetime.datetime.now()
225
226
maruel@chromium.org90541732011-04-01 17:54:18 +0000227def ask_for_data(prompt):
228 try:
229 return raw_input(prompt)
230 except KeyboardInterrupt:
231 # Hide the exception.
232 sys.exit(1)
233
234
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100235def confirm_or_exit(prefix='', action='confirm'):
236 """Asks user to press enter to continue or press Ctrl+C to abort."""
237 if not prefix or prefix.endswith('\n'):
238 mid = 'Press'
Andrii Shyshkalov353637c2017-03-14 16:52:18 +0100239 elif prefix.endswith('.') or prefix.endswith('?'):
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100240 mid = ' Press'
241 elif prefix.endswith(' '):
242 mid = 'press'
243 else:
244 mid = ' press'
245 ask_for_data('%s%s Enter to %s, or Ctrl+C to abort' % (prefix, mid, action))
246
247
248def ask_for_explicit_yes(prompt):
Quinten Yearsleyd242ed72019-07-25 17:17:55 +0000249 """Returns whether user typed 'y' or 'yes' to confirm the given prompt."""
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100250 result = ask_for_data(prompt + ' [Yes/No]: ').lower()
251 while True:
252 if 'yes'.startswith(result):
253 return True
254 if 'no'.startswith(result):
255 return False
256 result = ask_for_data('Please, type yes or no: ').lower()
257
258
tandrii5d48c322016-08-18 16:19:37 -0700259def _git_branch_config_key(branch, key):
260 """Helper method to return Git config key for a branch."""
261 assert branch, 'branch name is required to set git config for it'
262 return 'branch.%s.%s' % (branch, key)
263
264
machenbach@chromium.org45453142015-09-15 08:45:22 +0000265def _get_properties_from_options(options):
Quinten Yearsleya19d3532019-09-30 21:54:39 +0000266 prop_list = getattr(options, 'properties', [])
267 properties = dict(x.split('=', 1) for x in prop_list)
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +0000268 for key, val in properties.items():
machenbach@chromium.org45453142015-09-15 08:45:22 +0000269 try:
270 properties[key] = json.loads(val)
271 except ValueError:
272 pass # If a value couldn't be evaluated, treat it as a string.
273 return properties
274
275
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000276# TODO(crbug.com/976104): Remove this function once git-cl try-results has
277# migrated to use buildbucket v2
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000278def _buildbucket_retry(operation_name, http, *args, **kwargs):
279 """Retries requests to buildbucket service and returns parsed json content."""
280 try_count = 0
281 while True:
282 response, content = http.request(*args, **kwargs)
283 try:
284 content_json = json.loads(content)
285 except ValueError:
286 content_json = None
287
288 # Buildbucket could return an error even if status==200.
289 if content_json and content_json.get('error'):
nodir@chromium.orgbaff4e12016-03-08 00:33:57 +0000290 error = content_json.get('error')
291 if error.get('code') == 403:
292 raise BuildbucketResponseException(
293 'Access denied: %s' % error.get('message', ''))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000294 msg = 'Error in response. Reason: %s. Message: %s.' % (
nodir@chromium.orgbaff4e12016-03-08 00:33:57 +0000295 error.get('reason', ''), error.get('message', ''))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000296 raise BuildbucketResponseException(msg)
297
298 if response.status == 200:
Nodir Turakulov23d75d22018-06-04 12:37:32 -0700299 if content_json is None:
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000300 raise BuildbucketResponseException(
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000301 'Buildbucket returned invalid JSON content: %s.\n'
Nodir Turakulov9ac59792018-06-04 12:34:14 -0700302 'Please file bugs at http://crbug.com, '
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000303 'component "Infra>Platform>Buildbucket".' %
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000304 content)
305 return content_json
306 if response.status < 500 or try_count >= 2:
307 raise httplib2.HttpLib2Error(content)
308
309 # status >= 500 means transient failures.
310 logging.debug('Transient errors when %s. Will retry.', operation_name)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000311 time_sleep(0.5 + (1.5 * try_count))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000312 try_count += 1
313 assert False, 'unreachable'
314
315
Edward Lemur4c707a22019-09-24 21:13:43 +0000316def _call_buildbucket(http, buildbucket_host, method, request):
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000317 """Calls a buildbucket v2 method and returns the parsed json response."""
318 headers = {
319 'Accept': 'application/json',
320 'Content-Type': 'application/json',
321 }
322 request = json.dumps(request)
323 url = 'https://%s/prpc/buildbucket.v2.Builds/%s' % (buildbucket_host, method)
324
325 logging.info('POST %s with %s' % (url, request))
326
327 attempts = 1
328 time_to_sleep = 1
329 while True:
330 response, content = http.request(url, 'POST', body=request, headers=headers)
331 if response.status == 200:
332 return json.loads(content[4:])
333 if attempts >= MAX_ATTEMPTS or 400 <= response.status < 500:
334 msg = '%s error when calling POST %s with %s: %s' % (
335 response.status, url, request, content)
336 raise BuildbucketResponseException(msg)
337 logging.debug(
338 '%s error when calling POST %s with %s. '
339 'Sleeping for %d seconds and retrying...' % (
340 response.status, url, request, time_to_sleep))
341 time.sleep(time_to_sleep)
342 time_to_sleep *= 2
343 attempts += 1
344
345 assert False, 'unreachable'
346
347
qyearsley1fdfcb62016-10-24 13:22:03 -0700348def _get_bucket_map(changelist, options, option_parser):
qyearsleydd49f942016-10-28 11:57:22 -0700349 """Returns a dict mapping bucket names to builders and tests,
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000350 for triggering tryjobs.
qyearsley1fdfcb62016-10-24 13:22:03 -0700351 """
qyearsleydd49f942016-10-28 11:57:22 -0700352 # If no bots are listed, we try to get a set of builders and tests based
353 # on GetPreferredTryMasters functions in PRESUBMIT.py files.
qyearsley1fdfcb62016-10-24 13:22:03 -0700354 if not options.bot:
Edward Lemur3b8094a2020-02-07 22:34:43 +0000355 change = changelist.GetChange(changelist.GetCommonAncestorWithUpstream())
qyearsley136b49f2016-10-31 09:02:26 -0700356 # Get try masters from PRESUBMIT.py files.
nodire4f0fe02016-11-04 16:23:30 -0700357 masters = presubmit_support.DoGetTryMasters(
qyearsley1fdfcb62016-10-24 13:22:03 -0700358 change=change,
359 changed_files=change.LocalPaths(),
360 repository_root=settings.GetRoot(),
361 default_presubmit=None,
362 project=None,
363 verbose=options.verbose,
364 output_stream=sys.stdout)
nodire4f0fe02016-11-04 16:23:30 -0700365 if masters is None:
366 return None
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +0000367 return {m: b for m, b in masters.items()}
qyearsley1fdfcb62016-10-24 13:22:03 -0700368
qyearsley1fdfcb62016-10-24 13:22:03 -0700369 if options.bucket:
370 return {options.bucket: {b: [] for b in options.bot}}
Andrii Shyshkalov75424372019-08-30 22:48:15 +0000371 option_parser.error(
Edward Lemur5ef16a32019-11-11 21:13:25 +0000372 'Please specify the bucket, e.g. "-B chromium/try".')
qyearsley1fdfcb62016-10-24 13:22:03 -0700373
374
Edward Lemur6215c792019-10-03 21:59:05 +0000375def _parse_bucket(raw_bucket):
376 legacy = True
377 project = bucket = None
378 if '/' in raw_bucket:
379 legacy = False
380 project, bucket = raw_bucket.split('/', 1)
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000381 # Assume luci.<project>.<bucket>.
Edward Lemur6215c792019-10-03 21:59:05 +0000382 elif raw_bucket.startswith('luci.'):
383 project, bucket = raw_bucket[len('luci.'):].split('.', 1)
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000384 # Otherwise, assume prefix is also the project name.
Edward Lemur6215c792019-10-03 21:59:05 +0000385 elif '.' in raw_bucket:
386 project = raw_bucket.split('.')[0]
387 bucket = raw_bucket
388 # Legacy buckets.
389 if legacy:
390 print('WARNING Please use %s/%s to specify the bucket.' % (project, bucket))
391 return project, bucket
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000392
393
Edward Lemur5b929a42019-10-21 17:57:39 +0000394def _trigger_try_jobs(changelist, buckets, options, patchset):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000395 """Sends a request to Buildbucket to trigger tryjobs for a changelist.
qyearsley1fdfcb62016-10-24 13:22:03 -0700396
397 Args:
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000398 changelist: Changelist that the tryjobs are associated with.
qyearsley1fdfcb62016-10-24 13:22:03 -0700399 buckets: A nested dict mapping bucket names to builders to tests.
400 options: Command-line options.
401 """
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000402 print('Scheduling jobs on:')
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +0000403 for bucket, builders_and_tests in sorted(buckets.items()):
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000404 print('Bucket:', bucket)
405 print('\n'.join(
406 ' %s: %s' % (builder, tests)
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +0000407 for builder, tests in sorted(builders_and_tests.items())))
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000408 print('To see results here, run: git cl try-results')
409 print('To see results in browser, run: git cl web')
tandriide281ae2016-10-12 06:02:30 -0700410
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +0000411 requests = _make_try_job_schedule_requests(
412 changelist, buckets, options, patchset)
413 if not requests:
414 return
415
Edward Lemur5b929a42019-10-21 17:57:39 +0000416 http = auth.Authenticator().authorize(httplib2.Http())
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +0000417 http.force_exception_to_status_code = True
418
419 batch_request = {'requests': requests}
420 batch_response = _call_buildbucket(
421 http, options.buildbucket_host, 'Batch', batch_request)
422
423 errors = [
424 ' ' + response['error']['message']
425 for response in batch_response.get('responses', [])
426 if 'error' in response
427 ]
428 if errors:
429 raise BuildbucketResponseException(
430 'Failed to schedule builds for some bots:\n%s' % '\n'.join(errors))
431
432
433def _make_try_job_schedule_requests(changelist, buckets, options, patchset):
Edward Lemurf0faf482019-09-25 20:40:17 +0000434 gerrit_changes = [changelist.GetGerritChange(patchset)]
Quinten Yearsleya19d3532019-09-30 21:54:39 +0000435 shared_properties = {'category': getattr(options, 'category', 'git_cl_try')}
Quinten Yearsleya19d3532019-09-30 21:54:39 +0000436 if getattr(options, 'clobber', False):
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000437 shared_properties['clobber'] = True
438 shared_properties.update(_get_properties_from_options(options) or {})
439
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +0000440 shared_tags = [{'key': 'user_agent', 'value': 'git_cl_try'}]
441 if options.retry_failed:
442 shared_tags.append({'key': 'retry_failed',
443 'value': '1'})
444
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000445 requests = []
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +0000446 for raw_bucket, builders_and_tests in sorted(buckets.items()):
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000447 project, bucket = _parse_bucket(raw_bucket)
448 if not project or not bucket:
449 print('WARNING Could not parse bucket "%s". Skipping.' % raw_bucket)
450 continue
451
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +0000452 for builder, tests in sorted(builders_and_tests.items()):
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000453 properties = shared_properties.copy()
454 if 'presubmit' in builder.lower():
455 properties['dry_run'] = 'true'
456 if tests:
457 properties['testfilter'] = tests
458
459 requests.append({
460 'scheduleBuild': {
461 'requestId': str(uuid.uuid4()),
462 'builder': {
Quinten Yearsleya19d3532019-09-30 21:54:39 +0000463 'project': getattr(options, 'project', None) or project,
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000464 'bucket': bucket,
465 'builder': builder,
466 },
467 'gerritChanges': gerrit_changes,
468 'properties': properties,
469 'tags': [
470 {'key': 'builder', 'value': builder},
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +0000471 ] + shared_tags,
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000472 }
473 })
Anthony Polito1a5fe232020-01-24 23:17:52 +0000474
475 if options.revision:
476 requests[-1]['scheduleBuild']['gitilesCommit'] = {
477 'host': gerrit_changes[0]['host'],
478 'project': gerrit_changes[0]['project'],
479 'id': options.revision
480 }
481
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +0000482 return requests
kjellander@chromium.org44424542015-06-02 18:35:29 +0000483
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000484
Edward Lemur5b929a42019-10-21 17:57:39 +0000485def fetch_try_jobs(changelist, buildbucket_host, patchset=None):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000486 """Fetches tryjobs from buildbucket.
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000487
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000488 Returns list of buildbucket.v2.Build with the try jobs for the changelist.
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000489 """
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +0000490 fields = ['id', 'builder', 'status', 'createTime', 'tags']
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000491 request = {
492 'predicate': {
493 'gerritChanges': [changelist.GetGerritChange(patchset)],
494 },
495 'fields': ','.join('builds.*.' + field for field in fields),
496 }
tandrii221ab252016-10-06 08:12:04 -0700497
Edward Lemur5b929a42019-10-21 17:57:39 +0000498 authenticator = auth.Authenticator()
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000499 if authenticator.has_cached_credentials():
500 http = authenticator.authorize(httplib2.Http())
501 else:
vapiera7fbd5a2016-06-16 09:17:49 -0700502 print('Warning: Some results might be missing because %s' %
503 # Get the message on how to login.
Edward Lemurba5bc992019-09-23 22:59:17 +0000504 (auth.LoginRequiredError().message,))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000505 http = httplib2.Http()
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000506 http.force_exception_to_status_code = True
507
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000508 response = _call_buildbucket(http, buildbucket_host, 'SearchBuilds', request)
509 return response.get('builds', [])
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000510
Edward Lemur5b929a42019-10-21 17:57:39 +0000511def _fetch_latest_builds(changelist, buildbucket_host, latest_patchset=None):
Quinten Yearsley983111f2019-09-26 17:18:48 +0000512 """Fetches builds from the latest patchset that has builds (within
513 the last few patchsets).
514
515 Args:
Quinten Yearsley983111f2019-09-26 17:18:48 +0000516 changelist (Changelist): The CL to fetch builds for
517 buildbucket_host (str): Buildbucket host, e.g. "cr-buildbucket.appspot.com"
Andrii Shyshkalov1ad58112019-10-08 01:46:14 +0000518 lastest_patchset(int|NoneType): the patchset to start fetching builds from.
519 If None (default), starts with the latest available patchset.
Quinten Yearsley983111f2019-09-26 17:18:48 +0000520 Returns:
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000521 A tuple (builds, patchset) where builds is a list of buildbucket.v2.Build,
522 and patchset is the patchset number where those builds came from.
Quinten Yearsley983111f2019-09-26 17:18:48 +0000523 """
524 assert buildbucket_host
525 assert changelist.GetIssue(), 'CL must be uploaded first'
526 assert changelist.GetCodereviewServer(), 'CL must be uploaded first'
Andrii Shyshkalov1ad58112019-10-08 01:46:14 +0000527 if latest_patchset is None:
528 assert changelist.GetMostRecentPatchset()
529 ps = changelist.GetMostRecentPatchset()
530 else:
531 assert latest_patchset > 0, latest_patchset
532 ps = latest_patchset
533
Quinten Yearsley983111f2019-09-26 17:18:48 +0000534 min_ps = max(1, ps - 5)
535 while ps >= min_ps:
Edward Lemur5b929a42019-10-21 17:57:39 +0000536 builds = fetch_try_jobs(changelist, buildbucket_host, patchset=ps)
Quinten Yearsley983111f2019-09-26 17:18:48 +0000537 if len(builds):
538 return builds, ps
539 ps -= 1
540 return [], 0
541
542
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +0000543def _filter_failed_for_retry(all_builds):
544 """Returns a list of buckets/builders that are worth retrying.
Quinten Yearsley983111f2019-09-26 17:18:48 +0000545
546 Args:
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +0000547 all_builds (list): Builds, in the format returned by fetch_try_jobs,
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000548 i.e. a list of buildbucket.v2.Builds which includes status and builder
549 info.
Quinten Yearsley983111f2019-09-26 17:18:48 +0000550
551 Returns:
552 A dict of bucket to builder to tests (empty list). This is the same format
553 accepted by _trigger_try_jobs and returned by _get_bucket_map.
554 """
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +0000555
556 def _builder_of(build):
557 builder = build['builder']
558 return (builder['project'], builder['bucket'], builder['builder'])
559
560 res = collections.defaultdict(dict)
561 ordered = sorted(all_builds, key=lambda b: (_builder_of(b), b['createTime']))
562 for (proj, buck, bldr), builds in itertools.groupby(ordered, key=_builder_of):
563 # If builder had several builds, retry only if the last one failed.
564 # This is a bit different from CQ, which would re-use *any* SUCCESS-full
565 # build, but in case of retrying failed jobs retrying a flaky one makes
566 # sense.
567 builds = list(builds)
568 if builds[-1]['status'] not in ('FAILURE', 'INFRA_FAILURE'):
569 continue
570 if any(t['key'] == 'cq_experimental' and t['value'] == 'true'
571 for t in builds[-1]['tags']):
572 # Don't retry experimental build previously triggered by CQ.
573 continue
574 if any(b['status'] in ('STARTED', 'SCHEDULED') for b in builds):
575 # Don't retry if any are running.
576 continue
577 res[proj + '/' + buck][bldr] = []
578 return res
Quinten Yearsley983111f2019-09-26 17:18:48 +0000579
580
qyearsleyeab3c042016-08-24 09:18:28 -0700581def print_try_jobs(options, builds):
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000582 """Prints nicely result of fetch_try_jobs."""
583 if not builds:
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000584 print('No tryjobs scheduled.')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000585 return
586
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000587 longest_builder = max(len(b['builder']['builder']) for b in builds)
588 name_fmt = '{builder:<%d}' % longest_builder
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000589 if options.print_master:
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000590 longest_bucket = max(len(b['builder']['bucket']) for b in builds)
591 name_fmt = ('{bucket:>%d} ' % longest_bucket) + name_fmt
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000592
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000593 builds_by_status = {}
594 for b in builds:
595 builds_by_status.setdefault(b['status'], []).append({
596 'id': b['id'],
597 'name': name_fmt.format(
598 builder=b['builder']['builder'], bucket=b['builder']['bucket']),
599 })
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000600
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000601 sort_key = lambda b: (b['name'], b['id'])
602
603 def print_builds(title, builds, fmt=None, color=None):
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000604 """Pop matching builds from `builds` dict and print them."""
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000605 if not builds:
606 return
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000607
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000608 fmt = fmt or '{name} https://ci.chromium.org/b/{id}'
tandrii@chromium.org6cf98c82016-03-15 11:56:00 +0000609 if not options.color or color is None:
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000610 colorize = lambda x: x
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000611 else:
612 colorize = lambda x: '%s%s%s' % (color, x, Fore.RESET)
613
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000614 print(colorize(title))
615 for b in sorted(builds, key=sort_key):
616 print(' ', colorize(fmt.format(**b)))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000617
618 total = len(builds)
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000619 print_builds(
620 'Successes:', builds_by_status.pop('SUCCESS', []), color=Fore.GREEN)
621 print_builds(
622 'Infra Failures:', builds_by_status.pop('INFRA_FAILURE', []),
623 color=Fore.MAGENTA)
624 print_builds('Failures:', builds_by_status.pop('FAILURE', []), color=Fore.RED)
625 print_builds('Canceled:', builds_by_status.pop('CANCELED', []), fmt='{name}',
626 color=Fore.MAGENTA)
627 print_builds('Started:', builds_by_status.pop('STARTED', []))
628 print_builds(
629 'Scheduled:', builds_by_status.pop('SCHEDULED', []), fmt='{name} id={id}')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000630 # The last section is just in case buildbucket API changes OR there is a bug.
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000631 print_builds(
632 'Other:', sum(builds_by_status.values(), []), fmt='{name} id={id}')
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000633 print('Total: %d tryjobs' % total)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000634
635
Aiden Bennerc08566e2018-10-03 17:52:42 +0000636def _ComputeDiffLineRanges(files, upstream_commit):
637 """Gets the changed line ranges for each file since upstream_commit.
638
639 Parses a git diff on provided files and returns a dict that maps a file name
640 to an ordered list of range tuples in the form (start_line, count).
641 Ranges are in the same format as a git diff.
642 """
643 # If files is empty then diff_output will be a full diff.
644 if len(files) == 0:
645 return {}
646
Aiden Benner6c18a1a2018-11-23 20:18:23 +0000647 # Take the git diff and find the line ranges where there are changes.
Jamie Madill3671a6a2019-10-24 15:13:21 +0000648 diff_cmd = BuildGitDiffCmd('-U0', upstream_commit, files, allow_prefix=True)
Aiden Bennerc08566e2018-10-03 17:52:42 +0000649 diff_output = RunGit(diff_cmd)
650
651 pattern = r'(?:^diff --git a/(?:.*) b/(.*))|(?:^@@.*\+(.*) @@)'
652 # 2 capture groups
653 # 0 == fname of diff file
654 # 1 == 'diff_start,diff_count' or 'diff_start'
655 # will match each of
656 # diff --git a/foo.foo b/foo.py
657 # @@ -12,2 +14,3 @@
658 # @@ -12,2 +17 @@
659 # running re.findall on the above string with pattern will give
660 # [('foo.py', ''), ('', '14,3'), ('', '17')]
661
662 curr_file = None
663 line_diffs = {}
664 for match in re.findall(pattern, diff_output, flags=re.MULTILINE):
665 if match[0] != '':
666 # Will match the second filename in diff --git a/a.py b/b.py.
667 curr_file = match[0]
668 line_diffs[curr_file] = []
669 else:
670 # Matches +14,3
671 if ',' in match[1]:
672 diff_start, diff_count = match[1].split(',')
673 else:
674 # Single line changes are of the form +12 instead of +12,1.
675 diff_start = match[1]
676 diff_count = 1
677
678 diff_start = int(diff_start)
679 diff_count = int(diff_count)
680
681 # If diff_count == 0 this is a removal we can ignore.
682 line_diffs[curr_file].append((diff_start, diff_count))
683
684 return line_diffs
685
686
Aiden Benner99b0ccb2018-11-20 19:53:31 +0000687def _FindYapfConfigFile(fpath, yapf_config_cache, top_dir=None):
Aiden Bennerc08566e2018-10-03 17:52:42 +0000688 """Checks if a yapf file is in any parent directory of fpath until top_dir.
689
Aiden Benner99b0ccb2018-11-20 19:53:31 +0000690 Recursively checks parent directories to find yapf file and if no yapf file
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000691 is found returns None. Uses yapf_config_cache as a cache for previously found
692 configs.
Aiden Bennerc08566e2018-10-03 17:52:42 +0000693 """
Aiden Benner99b0ccb2018-11-20 19:53:31 +0000694 fpath = os.path.abspath(fpath)
Aiden Bennerc08566e2018-10-03 17:52:42 +0000695 # Return result if we've already computed it.
696 if fpath in yapf_config_cache:
697 return yapf_config_cache[fpath]
698
Aiden Benner99b0ccb2018-11-20 19:53:31 +0000699 parent_dir = os.path.dirname(fpath)
700 if os.path.isfile(fpath):
701 ret = _FindYapfConfigFile(parent_dir, yapf_config_cache, top_dir)
Aiden Bennerc08566e2018-10-03 17:52:42 +0000702 else:
Aiden Benner99b0ccb2018-11-20 19:53:31 +0000703 # Otherwise fpath is a directory
704 yapf_file = os.path.join(fpath, YAPF_CONFIG_FILENAME)
705 if os.path.isfile(yapf_file):
706 ret = yapf_file
707 elif fpath == top_dir or parent_dir == fpath:
708 # If we're at the top level directory, or if we're at root
709 # there is no provided style.
710 ret = None
711 else:
712 # Otherwise recurse on the current directory.
713 ret = _FindYapfConfigFile(parent_dir, yapf_config_cache, top_dir)
Aiden Bennerc08566e2018-10-03 17:52:42 +0000714 yapf_config_cache[fpath] = ret
715 return ret
716
717
Brian Sheedyb4307d52019-12-02 19:18:17 +0000718def _GetYapfIgnorePatterns(top_dir):
719 """Returns all patterns in the .yapfignore file.
Brian Sheedy59b06a82019-10-14 17:03:29 +0000720
721 yapf is supposed to handle the ignoring of files listed in .yapfignore itself,
722 but this functionality appears to break when explicitly passing files to
723 yapf for formatting. According to
724 https://github.com/google/yapf/blob/master/README.rst#excluding-files-from-formatting-yapfignore,
725 the .yapfignore file should be in the directory that yapf is invoked from,
726 which we assume to be the top level directory in this case.
727
728 Args:
729 top_dir: The top level directory for the repository being formatted.
730
731 Returns:
Brian Sheedyb4307d52019-12-02 19:18:17 +0000732 A set of all fnmatch patterns to be ignored.
Brian Sheedy59b06a82019-10-14 17:03:29 +0000733 """
734 yapfignore_file = os.path.join(top_dir, '.yapfignore')
Brian Sheedyb4307d52019-12-02 19:18:17 +0000735 ignore_patterns = set()
Brian Sheedy59b06a82019-10-14 17:03:29 +0000736 if not os.path.exists(yapfignore_file):
Brian Sheedyb4307d52019-12-02 19:18:17 +0000737 return ignore_patterns
Brian Sheedy59b06a82019-10-14 17:03:29 +0000738
Brian Sheedyb4307d52019-12-02 19:18:17 +0000739 with open(yapfignore_file) as f:
740 for line in f.readlines():
741 stripped_line = line.strip()
742 # Comments and blank lines should be ignored.
743 if stripped_line.startswith('#') or stripped_line == '':
744 continue
745 ignore_patterns.add(stripped_line)
746 return ignore_patterns
747
748
749def _FilterYapfIgnoredFiles(filepaths, patterns):
750 """Filters out any filepaths that match any of the given patterns.
751
752 Args:
753 filepaths: An iterable of strings containing filepaths to filter.
754 patterns: An iterable of strings containing fnmatch patterns to filter on.
755
756 Returns:
757 A list of strings containing all the elements of |filepaths| that did not
758 match any of the patterns in |patterns|.
759 """
760 # Not inlined so that tests can use the same implementation.
761 return [f for f in filepaths
762 if not any(fnmatch.fnmatch(f, p) for p in patterns)]
Brian Sheedy59b06a82019-10-14 17:03:29 +0000763
764
Aaron Gable13101a62018-02-09 13:20:41 -0800765def print_stats(args):
maruel@chromium.org49e3d802012-07-18 23:54:45 +0000766 """Prints statistics about the change to the user."""
767 # --no-ext-diff is broken in some versions of Git, so try to work around
768 # this by overriding the environment (but there is still a problem if the
769 # git config key "diff.external" is used).
thestig@chromium.org8b0553c2014-02-11 00:33:37 +0000770 env = GetNoGitPagerEnv()
maruel@chromium.org49e3d802012-07-18 23:54:45 +0000771 if 'GIT_EXTERNAL_DIFF' in env:
772 del env['GIT_EXTERNAL_DIFF']
iannucci@chromium.org79540052012-10-19 23:15:26 +0000773
maruel@chromium.org49e3d802012-07-18 23:54:45 +0000774 return subprocess2.call(
Aaron Gable13101a62018-02-09 13:20:41 -0800775 ['git', 'diff', '--no-ext-diff', '--stat', '-l100000', '-C50'] + args,
Edward Lemur0db01f02019-11-12 22:01:51 +0000776 env=env)
maruel@chromium.org49e3d802012-07-18 23:54:45 +0000777
778
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000779class BuildbucketResponseException(Exception):
780 pass
781
782
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000783class Settings(object):
784 def __init__(self):
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000785 self.cc = None
thestig@chromium.org7a54e812014-02-11 19:57:22 +0000786 self.root = None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000787 self.tree_status_url = None
788 self.viewvc_url = None
789 self.updated = False
ukai@chromium.orge8077812012-02-03 03:41:46 +0000790 self.is_gerrit = None
bauerb@chromium.org54b400c2016-01-14 10:08:25 +0000791 self.squash_gerrit_uploads = None
tandrii@chromium.org28253532016-04-14 13:46:56 +0000792 self.gerrit_skip_ensure_authenticated = None
jbroman@chromium.org615a2622013-05-03 13:20:14 +0000793 self.git_editor = None
Jamie Madilldc4d19e2019-10-24 21:50:02 +0000794 self.format_full_by_default = None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000795
Edward Lemur26964072020-02-19 19:18:51 +0000796 def _LazyUpdateIfNeeded(self):
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000797 """Updates the settings from a codereview.settings file, if available."""
Edward Lemur26964072020-02-19 19:18:51 +0000798 if self.updated:
799 return
pgervais@chromium.org87884cc2014-01-03 22:23:41 +0000800
Edward Lemur26964072020-02-19 19:18:51 +0000801 # The only value that actually changes the behavior is
802 # autoupdate = "false". Everything else means "true".
803 autoupdate = (
804 scm.GIT.GetConfig(self.GetRoot(), 'rietveld.autoupdate', '').lower())
805
806 cr_settings_file = FindCodereviewSettingsFile()
807 if autoupdate != 'false' and cr_settings_file:
808 LoadCodereviewSettingsFromFile(cr_settings_file)
809 cr_settings_file.close()
810
811 self.updated = True
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000812
thestig@chromium.org7a54e812014-02-11 19:57:22 +0000813 @staticmethod
814 def GetRelativeRoot():
815 return RunGit(['rev-parse', '--show-cdup']).strip()
thestig@chromium.org8b0553c2014-02-11 00:33:37 +0000816
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000817 def GetRoot(self):
thestig@chromium.org7a54e812014-02-11 19:57:22 +0000818 if self.root is None:
819 self.root = os.path.abspath(self.GetRelativeRoot())
820 return self.root
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000821
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000822 def GetTreeStatusUrl(self, error_ok=False):
823 if not self.tree_status_url:
Edward Lemur26964072020-02-19 19:18:51 +0000824 self.tree_status_url = self._GetConfig('rietveld.tree-status-url')
825 if self.tree_status_url is None and not error_ok:
826 DieWithError(
827 'You must configure your tree status URL by running '
828 '"git cl config".')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000829 return self.tree_status_url
830
831 def GetViewVCUrl(self):
832 if not self.viewvc_url:
Edward Lemur26964072020-02-19 19:18:51 +0000833 self.viewvc_url = self._GetConfig('rietveld.viewvc-url')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000834 return self.viewvc_url
835
rmistry@google.com90752582014-01-14 21:04:50 +0000836 def GetBugPrefix(self):
Edward Lemur26964072020-02-19 19:18:51 +0000837 return self._GetConfig('rietveld.bug-prefix')
rmistry@google.com78948ed2015-07-08 23:09:57 +0000838
rmistry@google.com5626a922015-02-26 14:03:30 +0000839 def GetRunPostUploadHook(self):
Edward Lemur61ea3072018-12-01 00:34:36 +0000840 run_post_upload_hook = self._GetConfig(
Edward Lemur26964072020-02-19 19:18:51 +0000841 'rietveld.run-post-upload-hook')
rmistry@google.com5626a922015-02-26 14:03:30 +0000842 return run_post_upload_hook == "True"
843
bauerb@chromium.orgae6df352011-04-06 17:40:39 +0000844 def GetDefaultCCList(self):
Edward Lemur26964072020-02-19 19:18:51 +0000845 return self._GetConfig('rietveld.cc')
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000846
ukai@chromium.orge8077812012-02-03 03:41:46 +0000847 def GetIsGerrit(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000848 """Returns True if this repo is associated with Gerrit."""
ukai@chromium.orge8077812012-02-03 03:41:46 +0000849 if self.is_gerrit is None:
Edward Lemur26964072020-02-19 19:18:51 +0000850 self.is_gerrit = self._GetConfig('gerrit.host').lower() == 'true'
ukai@chromium.orge8077812012-02-03 03:41:46 +0000851 return self.is_gerrit
852
bauerb@chromium.org54b400c2016-01-14 10:08:25 +0000853 def GetSquashGerritUploads(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000854 """Returns True if uploads to Gerrit should be squashed by default."""
bauerb@chromium.org54b400c2016-01-14 10:08:25 +0000855 if self.squash_gerrit_uploads is None:
tandriia60502f2016-06-20 02:01:53 -0700856 self.squash_gerrit_uploads = self.GetSquashGerritUploadsOverride()
Edward Lemur26964072020-02-19 19:18:51 +0000857 if self.squash_gerrit_uploads is None:
858 # Default is squash now (http://crbug.com/611892#c23).
859 self.squash_gerrit_uploads = self._GetConfig(
860 'gerrit.squash-uploads').lower() != 'false'
bauerb@chromium.org54b400c2016-01-14 10:08:25 +0000861 return self.squash_gerrit_uploads
862
tandriia60502f2016-06-20 02:01:53 -0700863 def GetSquashGerritUploadsOverride(self):
864 """Return True or False if codereview.settings should be overridden.
865
866 Returns None if no override has been defined.
867 """
868 # See also http://crbug.com/611892#c23
Edward Lemur26964072020-02-19 19:18:51 +0000869 result = self._GetConfig('gerrit.override-squash-uploads').lower()
tandriia60502f2016-06-20 02:01:53 -0700870 if result == 'true':
871 return True
872 if result == 'false':
873 return False
874 return None
875
tandrii@chromium.org28253532016-04-14 13:46:56 +0000876 def GetGerritSkipEnsureAuthenticated(self):
877 """Return True if EnsureAuthenticated should not be done for Gerrit
878 uploads."""
879 if self.gerrit_skip_ensure_authenticated is None:
Edward Lemur26964072020-02-19 19:18:51 +0000880 self.gerrit_skip_ensure_authenticated = self._GetConfig(
881 'gerrit.skip-ensure-authenticated').lower() == 'true'
tandrii@chromium.org28253532016-04-14 13:46:56 +0000882 return self.gerrit_skip_ensure_authenticated
883
jbroman@chromium.org615a2622013-05-03 13:20:14 +0000884 def GetGitEditor(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000885 """Returns the editor specified in the git config, or None if none is."""
jbroman@chromium.org615a2622013-05-03 13:20:14 +0000886 if self.git_editor is None:
Raul Tambre5a525872019-02-12 19:08:08 +0000887 # Git requires single quotes for paths with spaces. We need to replace
888 # them with double quotes for Windows to treat such paths as a single
889 # path.
Edward Lemur26964072020-02-19 19:18:51 +0000890 self.git_editor = self._GetConfig('core.editor').replace('\'', '"')
jbroman@chromium.org615a2622013-05-03 13:20:14 +0000891 return self.git_editor or None
892
thestig@chromium.org44202a22014-03-11 19:22:18 +0000893 def GetLintRegex(self):
Edward Lemur26964072020-02-19 19:18:51 +0000894 return self._GetConfig('rietveld.cpplint-regex', DEFAULT_LINT_REGEX)
thestig@chromium.org44202a22014-03-11 19:22:18 +0000895
896 def GetLintIgnoreRegex(self):
Edward Lemur26964072020-02-19 19:18:51 +0000897 return self._GetConfig(
898 'rietveld.cpplint-ignore-regex', DEFAULT_LINT_IGNORE_REGEX)
thestig@chromium.org44202a22014-03-11 19:22:18 +0000899
Jamie Madilldc4d19e2019-10-24 21:50:02 +0000900 def GetFormatFullByDefault(self):
901 if self.format_full_by_default is None:
902 result = (
903 RunGit(['config', '--bool', 'rietveld.format-full-by-default'],
904 error_ok=True).strip())
905 self.format_full_by_default = (result == 'true')
906 return self.format_full_by_default
907
Edward Lemur26964072020-02-19 19:18:51 +0000908 def _GetConfig(self, key, default=''):
909 self._LazyUpdateIfNeeded()
910 return scm.GIT.GetConfig(self.GetRoot(), key, default)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000911
912
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +0000913class _CQState(object):
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +0000914 """Enum for states of CL with respect to CQ."""
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +0000915 NONE = 'none'
916 DRY_RUN = 'dry_run'
917 COMMIT = 'commit'
918
919 ALL_STATES = [NONE, DRY_RUN, COMMIT]
920
921
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000922class _ParsedIssueNumberArgument(object):
Edward Lemurf38bc172019-09-03 21:02:13 +0000923 def __init__(self, issue=None, patchset=None, hostname=None):
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000924 self.issue = issue
925 self.patchset = patchset
926 self.hostname = hostname
927
928 @property
929 def valid(self):
930 return self.issue is not None
931
932
Edward Lemurf38bc172019-09-03 21:02:13 +0000933def ParseIssueNumberArgument(arg):
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000934 """Parses the issue argument and returns _ParsedIssueNumberArgument."""
935 fail_result = _ParsedIssueNumberArgument()
936
Edward Lemur678a6842019-10-03 22:25:05 +0000937 if isinstance(arg, int):
938 return _ParsedIssueNumberArgument(issue=arg)
939 if not isinstance(arg, basestring):
940 return fail_result
941
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000942 if arg.isdigit():
Edward Lemurf38bc172019-09-03 21:02:13 +0000943 return _ParsedIssueNumberArgument(issue=int(arg))
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000944 if not arg.startswith('http'):
945 return fail_result
Aaron Gableaee6c852017-06-26 12:49:01 -0700946
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000947 url = gclient_utils.UpgradeToHttps(arg)
948 try:
Edward Lemur79d4f992019-11-11 23:49:02 +0000949 parsed_url = urllib.parse.urlparse(url)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000950 except ValueError:
951 return fail_result
Andrii Shyshkalov28d840e2017-04-10 15:45:09 +0200952
Edward Lemur678a6842019-10-03 22:25:05 +0000953 # Gerrit's new UI is https://domain/c/project/+/<issue_number>[/[patchset]]
954 # But old GWT UI is https://domain/#/c/project/+/<issue_number>[/[patchset]]
955 # Short urls like https://domain/<issue_number> can be used, but don't allow
956 # specifying the patchset (you'd 404), but we allow that here.
957 if parsed_url.path == '/':
958 part = parsed_url.fragment
959 else:
960 part = parsed_url.path
961
962 match = re.match(
963 r'(/c(/.*/\+)?)?/(?P<issue>\d+)(/(?P<patchset>\d+)?/?)?$', part)
964 if not match:
965 return fail_result
966
967 issue = int(match.group('issue'))
968 patchset = match.group('patchset')
969 return _ParsedIssueNumberArgument(
970 issue=issue,
971 patchset=int(patchset) if patchset else None,
972 hostname=parsed_url.netloc)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000973
974
Andrii Shyshkalovb07575f2018-10-16 06:16:21 +0000975def _create_description_from_log(args):
976 """Pulls out the commit log to use as a base for the CL description."""
977 log_args = []
978 if len(args) == 1 and not args[0].endswith('.'):
979 log_args = [args[0] + '..']
980 elif len(args) == 1 and args[0].endswith('...'):
981 log_args = [args[0][:-1]]
982 elif len(args) == 2:
983 log_args = [args[0] + '..' + args[1]]
984 else:
985 log_args = args[:] # Hope for the best!
986 return RunGit(['log', '--pretty=format:%s\n\n%b'] + log_args)
987
988
Aaron Gablea45ee112016-11-22 15:14:38 -0800989class GerritChangeNotExists(Exception):
tandriic2405f52016-10-10 08:13:15 -0700990 def __init__(self, issue, url):
991 self.issue = issue
992 self.url = url
Aaron Gablea45ee112016-11-22 15:14:38 -0800993 super(GerritChangeNotExists, self).__init__()
tandriic2405f52016-10-10 08:13:15 -0700994
995 def __str__(self):
Aaron Gablea45ee112016-11-22 15:14:38 -0800996 return 'change %s at %s does not exist or you have no access to it' % (
tandriic2405f52016-10-10 08:13:15 -0700997 self.issue, self.url)
998
999
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01001000_CommentSummary = collections.namedtuple(
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001001 '_CommentSummary', ['date', 'message', 'sender', 'autogenerated',
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01001002 # TODO(tandrii): these two aren't known in Gerrit.
1003 'approval', 'disapproval'])
1004
1005
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001006class Changelist(object):
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001007 """Changelist works with one changelist in local branch.
1008
tandrii@chromium.org8930b3d2016-04-13 14:47:02 +00001009 Notes:
1010 * Not safe for concurrent multi-{thread,process} use.
1011 * Caches values from current branch. Therefore, re-use after branch change
tandrii5d48c322016-08-18 16:19:37 -07001012 with great care.
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001013 """
1014
Edward Lemur125d60a2019-09-13 18:25:41 +00001015 def __init__(self, branchref=None, issue=None, codereview_host=None):
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001016 """Create a new ChangeList instance.
1017
Edward Lemurf38bc172019-09-03 21:02:13 +00001018 **kwargs will be passed directly to Gerrit implementation.
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001019 """
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001020 # Poke settings so we get the "configure your server" message if necessary.
maruel@chromium.org379d07a2011-11-30 14:58:10 +00001021 global settings
1022 if not settings:
1023 # Happens when git_cl.py is used as a utility library.
1024 settings = Settings()
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001025
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001026 self.branchref = branchref
1027 if self.branchref:
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00001028 assert branchref.startswith('refs/heads/')
Edward Lemur85153282020-02-14 22:06:29 +00001029 self.branch = scm.GIT.ShortBranchName(self.branchref)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001030 else:
1031 self.branch = None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001032 self.upstream_branch = None
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001033 self.lookedup_issue = False
1034 self.issue = issue or None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001035 self.has_description = False
1036 self.description = None
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001037 self.lookedup_patchset = False
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001038 self.patchset = None
bauerb@chromium.orgae6df352011-04-06 17:40:39 +00001039 self.cc = None
Daniel Cheng7227d212017-11-17 08:12:37 -08001040 self.more_cc = []
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00001041 self._remote = None
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00001042 self._cached_remote_url = (False, None) # (is_cached, value)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00001043
Edward Lemur125d60a2019-09-13 18:25:41 +00001044 # Lazily cached values.
1045 self._gerrit_host = None # e.g. chromium-review.googlesource.com
1046 self._gerrit_server = None # e.g. https://chromium-review.googlesource.com
1047 # Map from change number (issue) to its detail cache.
1048 self._detail_cache = {}
1049
1050 if codereview_host is not None:
1051 assert not codereview_host.startswith('https://'), codereview_host
1052 self._gerrit_host = codereview_host
1053 self._gerrit_server = 'https://%s' % codereview_host
bauerb@chromium.orgae6df352011-04-06 17:40:39 +00001054
1055 def GetCCList(self):
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001056 """Returns the users cc'd on this CL.
bauerb@chromium.orgae6df352011-04-06 17:40:39 +00001057
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001058 The return value is a string suitable for passing to git cl with the --cc
1059 flag.
bauerb@chromium.orgae6df352011-04-06 17:40:39 +00001060 """
1061 if self.cc is None:
tyoshino@chromium.org99918ab2013-09-30 06:17:28 +00001062 base_cc = settings.GetDefaultCCList()
Daniel Cheng7227d212017-11-17 08:12:37 -08001063 more_cc = ','.join(self.more_cc)
bauerb@chromium.orgae6df352011-04-06 17:40:39 +00001064 self.cc = ','.join(filter(None, (base_cc, more_cc))) or ''
1065 return self.cc
1066
tyoshino@chromium.org99918ab2013-09-30 06:17:28 +00001067 def GetCCListWithoutDefault(self):
1068 """Return the users cc'd on this CL excluding default ones."""
1069 if self.cc is None:
Daniel Cheng7227d212017-11-17 08:12:37 -08001070 self.cc = ','.join(self.more_cc)
tyoshino@chromium.org99918ab2013-09-30 06:17:28 +00001071 return self.cc
1072
Daniel Cheng7227d212017-11-17 08:12:37 -08001073 def ExtendCC(self, more_cc):
1074 """Extends the list of users to cc on this CL based on the changed files."""
1075 self.more_cc.extend(more_cc)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001076
1077 def GetBranch(self):
1078 """Returns the short branch name, e.g. 'master'."""
1079 if not self.branch:
Edward Lemur85153282020-02-14 22:06:29 +00001080 branchref = scm.GIT.GetBranchRef(settings.GetRoot())
szager@chromium.orgd62c61f2014-10-20 22:33:21 +00001081 if not branchref:
1082 return None
1083 self.branchref = branchref
Edward Lemur85153282020-02-14 22:06:29 +00001084 self.branch = scm.GIT.ShortBranchName(self.branchref)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001085 return self.branch
1086
1087 def GetBranchRef(self):
1088 """Returns the full branch name, e.g. 'refs/heads/master'."""
1089 self.GetBranch() # Poke the lazy loader.
1090 return self.branchref
1091
tandrii@chromium.org534f67a2016-04-07 18:47:05 +00001092 def ClearBranch(self):
1093 """Clears cached branch data of this object."""
1094 self.branch = self.branchref = None
1095
Edward Lemur85153282020-02-14 22:06:29 +00001096 def _GitGetBranchConfigValue(self, key, default=None):
1097 return scm.GIT.GetBranchConfig(
1098 settings.GetRoot(), self.GetBranch(), key, default)
tandrii5d48c322016-08-18 16:19:37 -07001099
Edward Lemur85153282020-02-14 22:06:29 +00001100 def _GitSetBranchConfigValue(self, key, value):
1101 action = 'set %s to %r' % (key, value)
1102 if not value:
1103 action = 'unset %s' % key
1104 assert self.GetBranch(), 'a branch is needed to ' + action
1105 return scm.GIT.SetBranchConfig(
1106 settings.GetRoot(), self.GetBranch(), key, value)
tandrii5d48c322016-08-18 16:19:37 -07001107
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001108 @staticmethod
1109 def FetchUpstreamTuple(branch):
pgervais@chromium.orgd6617f32013-11-19 00:34:54 +00001110 """Returns a tuple containing remote and remote ref,
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001111 e.g. 'origin', 'refs/heads/master'
1112 """
Edward Lemur15a9b8c2020-02-13 00:52:30 +00001113 remote, upstream_branch = scm.GIT.FetchUpstreamTuple(
1114 settings.GetRoot(), branch)
1115 if not remote or not upstream_branch:
1116 DieWithError(
1117 'Unable to determine default branch to diff against.\n'
1118 'Either pass complete "git diff"-style arguments, like\n'
1119 ' git cl upload origin/master\n'
1120 'or verify this branch is set up to track another \n'
1121 '(via the --track argument to "git checkout -b ...").')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001122
1123 return remote, upstream_branch
1124
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00001125 def GetCommonAncestorWithUpstream(self):
pgervais@chromium.org8ba38ff2015-06-11 21:41:25 +00001126 upstream_branch = self.GetUpstreamBranch()
1127 if not BranchExists(upstream_branch):
1128 DieWithError('The upstream for the current branch (%s) does not exist '
1129 'anymore.\nPlease fix it and try again.' % self.GetBranch())
iannucci@chromium.org9e849272014-04-04 00:31:55 +00001130 return git_common.get_or_create_merge_base(self.GetBranch(),
pgervais@chromium.org8ba38ff2015-06-11 21:41:25 +00001131 upstream_branch)
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00001132
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001133 def GetUpstreamBranch(self):
1134 if self.upstream_branch is None:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001135 remote, upstream_branch = self.FetchUpstreamTuple(self.GetBranch())
Raul Tambrefe1dbe12019-05-02 04:43:57 +00001136 if remote != '.':
mmoss@chromium.orge7585452014-08-24 01:41:11 +00001137 upstream_branch = upstream_branch.replace('refs/heads/',
1138 'refs/remotes/%s/' % remote)
1139 upstream_branch = upstream_branch.replace('refs/branch-heads/',
1140 'refs/remotes/branch-heads/')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001141 self.upstream_branch = upstream_branch
1142 return self.upstream_branch
1143
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001144 def GetRemoteBranch(self):
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001145 if not self._remote:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001146 remote, branch = None, self.GetBranch()
1147 seen_branches = set()
1148 while branch not in seen_branches:
1149 seen_branches.add(branch)
1150 remote, branch = self.FetchUpstreamTuple(branch)
Edward Lemur85153282020-02-14 22:06:29 +00001151 branch = scm.GIT.ShortBranchName(branch)
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001152 if remote != '.' or branch.startswith('refs/remotes'):
1153 break
1154 else:
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001155 remotes = RunGit(['remote'], error_ok=True).split()
1156 if len(remotes) == 1:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001157 remote, = remotes
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001158 elif 'origin' in remotes:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001159 remote = 'origin'
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08001160 logging.warn('Could not determine which remote this change is '
1161 'associated with, so defaulting to "%s".' % self._remote)
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001162 else:
1163 logging.warn('Could not determine which remote this change is '
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08001164 'associated with.')
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001165 branch = 'HEAD'
1166 if branch.startswith('refs/remotes'):
1167 self._remote = (remote, branch)
mmoss@chromium.orge7585452014-08-24 01:41:11 +00001168 elif branch.startswith('refs/branch-heads/'):
1169 self._remote = (remote, branch.replace('refs/', 'refs/remotes/'))
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001170 else:
1171 self._remote = (remote, 'refs/remotes/%s/%s' % (remote, branch))
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001172 return self._remote
1173
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001174 def GitSanityChecks(self, upstream_git_obj):
1175 """Checks git repo status and ensures diff is from local commits."""
1176
sbc@chromium.org79706062015-01-14 21:18:12 +00001177 if upstream_git_obj is None:
1178 if self.GetBranch() is None:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001179 print('ERROR: Unable to determine current branch (detached HEAD?)',
vapiera7fbd5a2016-06-16 09:17:49 -07001180 file=sys.stderr)
sbc@chromium.org79706062015-01-14 21:18:12 +00001181 else:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001182 print('ERROR: No upstream branch.', file=sys.stderr)
sbc@chromium.org79706062015-01-14 21:18:12 +00001183 return False
1184
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001185 # Verify the commit we're diffing against is in our current branch.
1186 upstream_sha = RunGit(['rev-parse', '--verify', upstream_git_obj]).strip()
1187 common_ancestor = RunGit(['merge-base', upstream_sha, 'HEAD']).strip()
1188 if upstream_sha != common_ancestor:
vapiera7fbd5a2016-06-16 09:17:49 -07001189 print('ERROR: %s is not in the current branch. You may need to rebase '
1190 'your tracking branch' % upstream_sha, file=sys.stderr)
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001191 return False
1192
1193 # List the commits inside the diff, and verify they are all local.
1194 commits_in_diff = RunGit(
1195 ['rev-list', '^%s' % upstream_sha, 'HEAD']).splitlines()
1196 code, remote_branch = RunGitWithCode(['config', 'gitcl.remotebranch'])
1197 remote_branch = remote_branch.strip()
1198 if code != 0:
1199 _, remote_branch = self.GetRemoteBranch()
1200
1201 commits_in_remote = RunGit(
1202 ['rev-list', '^%s' % upstream_sha, remote_branch]).splitlines()
1203
1204 common_commits = set(commits_in_diff) & set(commits_in_remote)
1205 if common_commits:
vapiera7fbd5a2016-06-16 09:17:49 -07001206 print('ERROR: Your diff contains %d commits already in %s.\n'
1207 'Run "git log --oneline %s..HEAD" to get a list of commits in '
1208 'the diff. If you are using a custom git flow, you can override'
1209 ' the reference used for this check with "git config '
1210 'gitcl.remotebranch <git-ref>".' % (
1211 len(common_commits), remote_branch, upstream_git_obj),
1212 file=sys.stderr)
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001213 return False
1214 return True
1215
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00001216 def GetGitBaseUrlFromConfig(self):
sheyang@chromium.orga656e702014-05-15 20:43:05 +00001217 """Return the configured base URL from branch.<branchname>.baseurl.
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00001218
1219 Returns None if it is not set.
1220 """
tandrii5d48c322016-08-18 16:19:37 -07001221 return self._GitGetBranchConfigValue('base-url')
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001222
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001223 def GetRemoteUrl(self):
1224 """Return the configured remote URL, e.g. 'git://example.org/foo.git/'.
1225
1226 Returns None if there is no remote.
1227 """
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00001228 is_cached, value = self._cached_remote_url
1229 if is_cached:
1230 return value
1231
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001232 remote, _ = self.GetRemoteBranch()
Edward Lemur26964072020-02-19 19:18:51 +00001233 url = scm.GIT.GetConfig(settings.GetRoot(), 'remote.%s.url' % remote, '')
dyen@chromium.org2a13d4f2014-06-13 00:06:37 +00001234
Edward Lemur298f2cf2019-02-22 21:40:39 +00001235 # Check if the remote url can be parsed as an URL.
Edward Lemur79d4f992019-11-11 23:49:02 +00001236 host = urllib.parse.urlparse(url).netloc
Edward Lemur298f2cf2019-02-22 21:40:39 +00001237 if host:
1238 self._cached_remote_url = (True, url)
1239 return url
1240
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001241 # If it cannot be parsed as an url, assume it is a local directory,
1242 # probably a git cache.
Edward Lemur298f2cf2019-02-22 21:40:39 +00001243 logging.warning('"%s" doesn\'t appear to point to a git host. '
1244 'Interpreting it as a local directory.', url)
1245 if not os.path.isdir(url):
1246 logging.error(
Josip906bfde2020-01-31 22:38:49 +00001247 'Remote "%(remote)s" for branch "%(branch)s" points to "%(url)s", '
1248 'but it doesn\'t exist.',
1249 {'remote': remote, 'branch': self.GetBranch(), 'url': url})
Edward Lemur298f2cf2019-02-22 21:40:39 +00001250 return None
1251
1252 cache_path = url
Edward Lemur26964072020-02-19 19:18:51 +00001253 url = scm.GIT.GetConfig(url, 'remote.%s.url' % remote, '')
Edward Lemur298f2cf2019-02-22 21:40:39 +00001254
Edward Lemur79d4f992019-11-11 23:49:02 +00001255 host = urllib.parse.urlparse(url).netloc
Edward Lemur298f2cf2019-02-22 21:40:39 +00001256 if not host:
1257 logging.error(
1258 'Remote "%(remote)s" for branch "%(branch)s" points to '
1259 '"%(cache_path)s", but it is misconfigured.\n'
1260 '"%(cache_path)s" must be a git repo and must have a remote named '
1261 '"%(remote)s" pointing to the git host.', {
1262 'remote': remote,
1263 'cache_path': cache_path,
1264 'branch': self.GetBranch()})
1265 return None
1266
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00001267 self._cached_remote_url = (True, url)
dyen@chromium.org2a13d4f2014-06-13 00:06:37 +00001268 return url
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001269
tandrii@chromium.org87985d22016-03-24 17:33:33 +00001270 def GetIssue(self):
maruel@chromium.org52424302012-08-29 15:14:30 +00001271 """Returns the issue number as a int or None if not set."""
tandrii@chromium.org87985d22016-03-24 17:33:33 +00001272 if self.issue is None and not self.lookedup_issue:
Edward Lemur85153282020-02-14 22:06:29 +00001273 self.issue = self._GitGetBranchConfigValue(self.IssueConfigKey())
1274 if self.issue is not None:
1275 self.issue = int(self.issue)
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001276 self.lookedup_issue = True
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001277 return self.issue
1278
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001279 def GetIssueURL(self):
1280 """Get the URL for a particular issue."""
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001281 issue = self.GetIssue()
1282 if not issue:
dbeam@chromium.org015fd3d2013-06-18 19:02:50 +00001283 return None
Edward Lemur125d60a2019-09-13 18:25:41 +00001284 return '%s/%s' % (self.GetCodereviewServer(), issue)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001285
Edward Lemur7f6dec02020-02-06 20:23:58 +00001286 def GetLocalDescription(self, upstream_branch):
1287 """Return the log messages of all commits up to the branch point."""
1288 args = ['log', '--pretty=format:%s%n%n%b', '%s...' % (upstream_branch)]
1289 return RunGitWithCode(args)[1].strip()
1290
Edward Lemur6c6827c2020-02-06 21:15:18 +00001291 def FetchDescription(self, pretty=False):
1292 assert self.GetIssue(), 'issue is required to query Gerrit'
1293
1294 if not self.has_description:
1295 data = self._GetChangeDetail(['CURRENT_REVISION', 'CURRENT_COMMIT'])
1296 current_rev = data['current_revision']
1297 self.description = data['revisions'][current_rev]['commit']['message']
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001298 self.has_description = True
Edward Lemur6c6827c2020-02-06 21:15:18 +00001299
1300 if not pretty:
1301 return self.description
1302
1303 # Set width to 72 columns + 2 space indent.
1304 wrapper = textwrap.TextWrapper(width=74, replace_whitespace=True)
1305 wrapper.initial_indent = wrapper.subsequent_indent = ' '
1306 lines = self.description.splitlines()
1307 return '\n'.join([wrapper.fill(line) for line in lines])
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001308
1309 def GetPatchset(self):
maruel@chromium.org52424302012-08-29 15:14:30 +00001310 """Returns the patchset number as a int or None if not set."""
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001311 if self.patchset is None and not self.lookedup_patchset:
Edward Lemur85153282020-02-14 22:06:29 +00001312 self.patchset = self._GitGetBranchConfigValue(self.PatchsetConfigKey())
1313 if self.patchset is not None:
1314 self.patchset = int(self.patchset)
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001315 self.lookedup_patchset = True
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001316 return self.patchset
1317
1318 def SetPatchset(self, patchset):
tandrii5d48c322016-08-18 16:19:37 -07001319 """Set this branch's patchset. If patchset=0, clears the patchset."""
1320 assert self.GetBranch()
1321 if not patchset:
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001322 self.patchset = None
tandrii5d48c322016-08-18 16:19:37 -07001323 else:
1324 self.patchset = int(patchset)
1325 self._GitSetBranchConfigValue(
Edward Lemur85153282020-02-14 22:06:29 +00001326 self.PatchsetConfigKey(), str(self.patchset))
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001327
tandrii@chromium.orga342c922016-03-16 07:08:25 +00001328 def SetIssue(self, issue=None):
tandrii5d48c322016-08-18 16:19:37 -07001329 """Set this branch's issue. If issue isn't given, clears the issue."""
1330 assert self.GetBranch()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001331 if issue:
tandrii5d48c322016-08-18 16:19:37 -07001332 issue = int(issue)
1333 self._GitSetBranchConfigValue(
Edward Lemur85153282020-02-14 22:06:29 +00001334 self.IssueConfigKey(), str(issue))
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001335 self.issue = issue
Edward Lemur125d60a2019-09-13 18:25:41 +00001336 codereview_server = self.GetCodereviewServer()
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001337 if codereview_server:
tandrii5d48c322016-08-18 16:19:37 -07001338 self._GitSetBranchConfigValue(
Edward Lemur125d60a2019-09-13 18:25:41 +00001339 self.CodereviewServerConfigKey(),
tandrii5d48c322016-08-18 16:19:37 -07001340 codereview_server)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001341 else:
tandrii5d48c322016-08-18 16:19:37 -07001342 # Reset all of these just to be clean.
1343 reset_suffixes = [
1344 'last-upload-hash',
Edward Lemur125d60a2019-09-13 18:25:41 +00001345 self.IssueConfigKey(),
1346 self.PatchsetConfigKey(),
1347 self.CodereviewServerConfigKey(),
tandrii5d48c322016-08-18 16:19:37 -07001348 ] + self._PostUnsetIssueProperties()
1349 for prop in reset_suffixes:
Edward Lemur85153282020-02-14 22:06:29 +00001350 try:
1351 self._GitSetBranchConfigValue(prop, None)
1352 except subprocess2.CalledProcessError:
1353 pass
Aaron Gableca01e2c2017-07-19 11:16:02 -07001354 msg = RunGit(['log', '-1', '--format=%B']).strip()
1355 if msg and git_footers.get_footer_change_id(msg):
1356 print('WARNING: The change patched into this branch has a Change-Id. '
1357 'Removing it.')
1358 RunGit(['commit', '--amend', '-m',
1359 git_footers.remove_footer(msg, 'Change-Id')])
Edward Lemurf38bc172019-09-03 21:02:13 +00001360 self.lookedup_issue = True
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001361 self.issue = None
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00001362 self.patchset = None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001363
Edward Lemur7f6dec02020-02-06 20:23:58 +00001364 def GetChange(self, upstream_branch):
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001365 if not self.GitSanityChecks(upstream_branch):
1366 DieWithError('\nGit sanity check failure')
1367
Edward Lemur7f6dec02020-02-06 20:23:58 +00001368 root = settings.GetRoot()
bauerb@chromium.org6fb99c62011-04-18 15:57:28 +00001369 # We use the sha1 of HEAD as a name of this change.
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00001370 name = RunGitWithCode(['rev-parse', 'HEAD'])[1].strip()
maruel@chromium.org2b38e9c2011-10-19 00:04:35 +00001371 try:
Edward Lemur7f6dec02020-02-06 20:23:58 +00001372 files = scm.GIT.CaptureStatus(root, upstream_branch)
maruel@chromium.org2b38e9c2011-10-19 00:04:35 +00001373 except subprocess2.CalledProcessError:
1374 DieWithError(
pgervais@chromium.orgd6617f32013-11-19 00:34:54 +00001375 ('\nFailed to diff against upstream branch %s\n\n'
maruel@chromium.org2b38e9c2011-10-19 00:04:35 +00001376 'This branch probably doesn\'t exist anymore. To reset the\n'
1377 'tracking branch, please run\n'
stip7a3dd352016-09-22 17:32:28 -07001378 ' git branch --set-upstream-to origin/master %s\n'
1379 'or replace origin/master with the relevant branch') %
maruel@chromium.org2b38e9c2011-10-19 00:04:35 +00001380 (upstream_branch, self.GetBranch()))
bauerb@chromium.org6fb99c62011-04-18 15:57:28 +00001381
maruel@chromium.org52424302012-08-29 15:14:30 +00001382 issue = self.GetIssue()
1383 patchset = self.GetPatchset()
Edward Lemur7f6dec02020-02-06 20:23:58 +00001384 if issue:
Edward Lemur6c6827c2020-02-06 21:15:18 +00001385 description = self.FetchDescription()
bauerb@chromium.org6fb99c62011-04-18 15:57:28 +00001386 else:
1387 # If the change was never uploaded, use the log messages of all commits
1388 # up to the branch point, as git cl upload will prefill the description
1389 # with these log messages.
Edward Lemur7f6dec02020-02-06 20:23:58 +00001390 description = self.GetLocalDescription(upstream_branch)
maruel@chromium.org03b3bdc2011-06-14 13:04:12 +00001391
Edward Lemur7f6dec02020-02-06 20:23:58 +00001392 author = RunGit(['config', 'user.email']).strip() or None
asvitkine@chromium.org15169952011-09-27 14:30:53 +00001393 return presubmit_support.GitChange(
bauerb@chromium.org6fb99c62011-04-18 15:57:28 +00001394 name,
1395 description,
Edward Lemur7f6dec02020-02-06 20:23:58 +00001396 root,
bauerb@chromium.org6fb99c62011-04-18 15:57:28 +00001397 files,
1398 issue,
1399 patchset,
agable@chromium.orgea84ef12014-04-30 19:55:12 +00001400 author,
1401 upstream=upstream_branch)
bauerb@chromium.org6fb99c62011-04-18 15:57:28 +00001402
dsansomee2d6fd92016-09-08 00:10:47 -07001403 def UpdateDescription(self, description, force=False):
Edward Lemur6c6827c2020-02-06 21:15:18 +00001404 assert self.GetIssue(), 'issue is required to update description'
1405
1406 if gerrit_util.HasPendingChangeEdit(
1407 self._GetGerritHost(), self._GerritChangeIdentifier()):
1408 if not force:
1409 confirm_or_exit(
1410 'The description cannot be modified while the issue has a pending '
1411 'unpublished edit. Either publish the edit in the Gerrit web UI '
1412 'or delete it.\n\n', action='delete the unpublished edit')
1413
1414 gerrit_util.DeletePendingChangeEdit(
1415 self._GetGerritHost(), self._GerritChangeIdentifier())
1416 gerrit_util.SetCommitMessage(
1417 self._GetGerritHost(), self._GerritChangeIdentifier(),
1418 description, notify='NONE')
1419
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001420 self.description = description
Andrii Shyshkalov83051152017-02-07 23:47:29 +01001421 self.has_description = True
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001422
Edward Lesmes8e282792018-04-03 18:50:29 -04001423 def RunHook(self, committing, may_prompt, verbose, change, parallel):
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001424 """Calls sys.exit() if the hook fails; returns a HookResults otherwise."""
1425 try:
Edward Lemur2c48f242019-06-04 16:14:09 +00001426 start = time_time()
1427 result = presubmit_support.DoPresubmitChecks(change, committing,
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001428 verbose=verbose, output_stream=sys.stdout, input_stream=sys.stdin,
1429 default_presubmit=None, may_prompt=may_prompt,
Edward Lemur125d60a2019-09-13 18:25:41 +00001430 gerrit_obj=self.GetGerritObjForPresubmit(),
Edward Lesmes8e282792018-04-03 18:50:29 -04001431 parallel=parallel)
Edward Lemur2c48f242019-06-04 16:14:09 +00001432 metrics.collector.add_repeated('sub_commands', {
1433 'command': 'presubmit',
1434 'execution_time': time_time() - start,
1435 'exit_code': 0 if result.should_continue() else 1,
1436 })
1437 return result
vapierfd77ac72016-06-16 08:33:57 -07001438 except presubmit_support.PresubmitFailure as e:
Aaron Gable5d5f22c2018-02-02 09:12:41 -08001439 DieWithError('%s\nMaybe your depot_tools is out of date?' % e)
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001440
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001441 def CMDUpload(self, options, git_diff_args, orig_args):
1442 """Uploads a change to codereview."""
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001443 custom_cl_base = None
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001444 if git_diff_args:
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001445 custom_cl_base = base_branch = git_diff_args[0]
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001446 else:
1447 if self.GetBranch() is None:
1448 DieWithError('Can\'t upload from detached HEAD state. Get on a branch!')
1449
1450 # Default to diffing against common ancestor of upstream branch
1451 base_branch = self.GetCommonAncestorWithUpstream()
1452 git_diff_args = [base_branch, 'HEAD']
1453
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001454 # Fast best-effort checks to abort before running potentially expensive
1455 # hooks if uploading is likely to fail anyway. Passing these checks does
1456 # not guarantee that uploading will not fail.
Edward Lemur125d60a2019-09-13 18:25:41 +00001457 self.EnsureAuthenticated(force=options.force)
1458 self.EnsureCanUploadPatchset(force=options.force)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001459
1460 # Apply watchlists on upload.
Edward Lemur7f6dec02020-02-06 20:23:58 +00001461 change = self.GetChange(base_branch)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001462 watchlist = watchlists.Watchlists(change.RepositoryRoot())
1463 files = [f.LocalPath() for f in change.AffectedFiles()]
1464 if not options.bypass_watchlists:
Daniel Cheng7227d212017-11-17 08:12:37 -08001465 self.ExtendCC(watchlist.GetWatchersForPaths(files))
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001466
1467 if not options.bypass_hooks:
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001468 if options.reviewers or options.tbrs or options.add_owners_to:
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001469 # Set the reviewer list now so that presubmit checks can access it.
1470 change_description = ChangeDescription(change.FullDescriptionText())
1471 change_description.update_reviewers(options.reviewers,
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001472 options.tbrs,
Robert Iannuccif2708bd2017-04-17 15:49:02 -07001473 options.add_owners_to,
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001474 change)
1475 change.SetDescriptionText(change_description.description)
1476 hook_results = self.RunHook(committing=False,
Edward Lesmes8e282792018-04-03 18:50:29 -04001477 may_prompt=not options.force,
1478 verbose=options.verbose,
1479 change=change, parallel=options.parallel)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001480 if not hook_results.should_continue():
1481 return 1
1482 if not options.reviewers and hook_results.reviewers:
1483 options.reviewers = hook_results.reviewers.split(',')
Daniel Cheng7227d212017-11-17 08:12:37 -08001484 self.ExtendCC(hook_results.more_cc)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001485
Aaron Gable13101a62018-02-09 13:20:41 -08001486 print_stats(git_diff_args)
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001487 ret = self.CMDUploadChange(options, git_diff_args, custom_cl_base, change)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001488 if not ret:
Edward Lemur85153282020-02-14 22:06:29 +00001489 self._GitSetBranchConfigValue(
1490 'last-upload-hash', RunGit(['rev-parse', 'HEAD']).strip())
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001491 # Run post upload hooks, if specified.
1492 if settings.GetRunPostUploadHook():
1493 presubmit_support.DoPostUploadExecuter(
1494 change,
Edward Lemur016a0872020-02-04 22:13:28 +00001495 self.GetGerritObjForPresubmit(),
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001496 settings.GetRoot(),
1497 options.verbose,
1498 sys.stdout)
1499
1500 # Upload all dependencies if specified.
1501 if options.dependencies:
vapiera7fbd5a2016-06-16 09:17:49 -07001502 print()
1503 print('--dependencies has been specified.')
1504 print('All dependent local branches will be re-uploaded.')
1505 print()
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001506 # Remove the dependencies flag from args so that we do not end up in a
1507 # loop.
1508 orig_args.remove('--dependencies')
1509 ret = upload_branch_deps(self, orig_args)
1510 return ret
1511
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001512 def SetCQState(self, new_state):
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07001513 """Updates the CQ state for the latest patchset.
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001514
1515 Issue must have been already uploaded and known.
1516 """
1517 assert new_state in _CQState.ALL_STATES
1518 assert self.GetIssue()
qyearsley1fdfcb62016-10-24 13:22:03 -07001519 try:
Edward Lemur125d60a2019-09-13 18:25:41 +00001520 vote_map = {
1521 _CQState.NONE: 0,
1522 _CQState.DRY_RUN: 1,
1523 _CQState.COMMIT: 2,
1524 }
1525 labels = {'Commit-Queue': vote_map[new_state]}
1526 notify = False if new_state == _CQState.DRY_RUN else None
1527 gerrit_util.SetReview(
1528 self._GetGerritHost(), self._GerritChangeIdentifier(),
1529 labels=labels, notify=notify)
qyearsley1fdfcb62016-10-24 13:22:03 -07001530 return 0
1531 except KeyboardInterrupt:
1532 raise
1533 except:
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07001534 print('WARNING: Failed to %s.\n'
qyearsley1fdfcb62016-10-24 13:22:03 -07001535 'Either:\n'
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07001536 ' * Your project has no CQ,\n'
1537 ' * You don\'t have permission to change the CQ state,\n'
1538 ' * There\'s a bug in this code (see stack trace below).\n'
1539 'Consider specifying which bots to trigger manually or asking your '
1540 'project owners for permissions or contacting Chrome Infra at:\n'
1541 'https://www.chromium.org/infra\n\n' %
1542 ('cancel CQ' if new_state == _CQState.NONE else 'trigger CQ'))
qyearsley1fdfcb62016-10-24 13:22:03 -07001543 # Still raise exception so that stack trace is printed.
1544 raise
1545
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001546 def _GetGerritHost(self):
1547 # Lazy load of configs.
1548 self.GetCodereviewServer()
tandriie32e3ea2016-06-22 02:52:48 -07001549 if self._gerrit_host and '.' not in self._gerrit_host:
1550 # Abbreviated domain like "chromium" instead of chromium.googlesource.com.
1551 # This happens for internal stuff http://crbug.com/614312.
Edward Lemur79d4f992019-11-11 23:49:02 +00001552 parsed = urllib.parse.urlparse(self.GetRemoteUrl())
tandriie32e3ea2016-06-22 02:52:48 -07001553 if parsed.scheme == 'sso':
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001554 print('WARNING: using non-https URLs for remote is likely broken\n'
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001555 ' Your current remote is: %s' % self.GetRemoteUrl())
tandriie32e3ea2016-06-22 02:52:48 -07001556 self._gerrit_host = '%s.googlesource.com' % self._gerrit_host
1557 self._gerrit_server = 'https://%s' % self._gerrit_host
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001558 return self._gerrit_host
1559
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001560 def _GetGitHost(self):
1561 """Returns git host to be used when uploading change to Gerrit."""
Edward Lemur298f2cf2019-02-22 21:40:39 +00001562 remote_url = self.GetRemoteUrl()
1563 if not remote_url:
1564 return None
Edward Lemur79d4f992019-11-11 23:49:02 +00001565 return urllib.parse.urlparse(remote_url).netloc
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001566
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001567 def GetCodereviewServer(self):
1568 if not self._gerrit_server:
1569 # If we're on a branch then get the server potentially associated
1570 # with that branch.
Edward Lemur85153282020-02-14 22:06:29 +00001571 if self.GetIssue() and self.GetBranch():
tandrii5d48c322016-08-18 16:19:37 -07001572 self._gerrit_server = self._GitGetBranchConfigValue(
1573 self.CodereviewServerConfigKey())
1574 if self._gerrit_server:
Edward Lemur79d4f992019-11-11 23:49:02 +00001575 self._gerrit_host = urllib.parse.urlparse(self._gerrit_server).netloc
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001576 if not self._gerrit_server:
1577 # We assume repo to be hosted on Gerrit, and hence Gerrit server
1578 # has "-review" suffix for lowest level subdomain.
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001579 parts = self._GetGitHost().split('.')
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001580 parts[0] = parts[0] + '-review'
1581 self._gerrit_host = '.'.join(parts)
1582 self._gerrit_server = 'https://%s' % self._gerrit_host
1583 return self._gerrit_server
1584
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00001585 def _GetGerritProject(self):
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001586 """Returns Gerrit project name based on remote git URL."""
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00001587 remote_url = self.GetRemoteUrl()
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001588 if remote_url is None:
Josip906bfde2020-01-31 22:38:49 +00001589 logging.warning('can\'t detect Gerrit project.')
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00001590 return None
Edward Lemur79d4f992019-11-11 23:49:02 +00001591 project = urllib.parse.urlparse(remote_url).path.strip('/')
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001592 if project.endswith('.git'):
1593 project = project[:-len('.git')]
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00001594 # *.googlesource.com hosts ensure that Git/Gerrit projects don't start with
1595 # 'a/' prefix, because 'a/' prefix is used to force authentication in
1596 # gitiles/git-over-https protocol. E.g.,
1597 # https://chromium.googlesource.com/a/v8/v8 refers to the same repo/project
1598 # as
1599 # https://chromium.googlesource.com/v8/v8
1600 if project.startswith('a/'):
1601 project = project[len('a/'):]
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001602 return project
1603
Andrii Shyshkalovd06cc782018-08-23 17:24:19 +00001604 def _GerritChangeIdentifier(self):
1605 """Handy method for gerrit_util.ChangeIdentifier for a given CL.
1606
1607 Not to be confused by value of "Change-Id:" footer.
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00001608 If Gerrit project can be determined, this will speed up Gerrit HTTP API RPC.
Andrii Shyshkalovd06cc782018-08-23 17:24:19 +00001609 """
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00001610 project = self._GetGerritProject()
1611 if project:
1612 return gerrit_util.ChangeIdentifier(project, self.GetIssue())
1613 # Fall back on still unique, but less efficient change number.
1614 return str(self.GetIssue())
Andrii Shyshkalovd06cc782018-08-23 17:24:19 +00001615
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001616 @classmethod
tandrii5d48c322016-08-18 16:19:37 -07001617 def IssueConfigKey(cls):
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001618 return 'gerritissue'
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001619
tandrii5d48c322016-08-18 16:19:37 -07001620 @classmethod
1621 def PatchsetConfigKey(cls):
1622 return 'gerritpatchset'
1623
1624 @classmethod
1625 def CodereviewServerConfigKey(cls):
1626 return 'gerritserver'
1627
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01001628 def EnsureAuthenticated(self, force, refresh=None):
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001629 """Best effort check that user is authenticated with Gerrit server."""
tandrii@chromium.org28253532016-04-14 13:46:56 +00001630 if settings.GetGerritSkipEnsureAuthenticated():
1631 # For projects with unusual authentication schemes.
1632 # See http://crbug.com/603378.
1633 return
Vadim Shtayurab250ec12018-10-04 00:21:08 +00001634
1635 # Check presence of cookies only if using cookies-based auth method.
1636 cookie_auth = gerrit_util.Authenticator.get()
1637 if not isinstance(cookie_auth, gerrit_util.CookiesAuthenticator):
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001638 return
Vadim Shtayurab250ec12018-10-04 00:21:08 +00001639
Florian Mayerae510e82020-01-30 21:04:48 +00001640 remote_url = self.GetRemoteUrl()
1641 if remote_url is None:
Josip906bfde2020-01-31 22:38:49 +00001642 logging.warning('invalid remote')
Florian Mayerae510e82020-01-30 21:04:48 +00001643 return
1644 if urllib.parse.urlparse(remote_url).scheme != 'https':
Josip906bfde2020-01-31 22:38:49 +00001645 logging.warning('Ignoring branch %(branch)s with non-https remote '
1646 '%(remote)s', {
1647 'branch': self.branch,
1648 'remote': self.GetRemoteUrl()
1649 })
Daniel Chengcf6269b2019-05-18 01:02:12 +00001650 return
1651
Vadim Shtayurab250ec12018-10-04 00:21:08 +00001652 # Lazy-loader to identify Gerrit and Git hosts.
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001653 self.GetCodereviewServer()
1654 git_host = self._GetGitHost()
Edward Lemur298f2cf2019-02-22 21:40:39 +00001655 assert self._gerrit_server and self._gerrit_host and git_host
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001656
1657 gerrit_auth = cookie_auth.get_auth_header(self._gerrit_host)
1658 git_auth = cookie_auth.get_auth_header(git_host)
1659 if gerrit_auth and git_auth:
1660 if gerrit_auth == git_auth:
1661 return
Andrii Shyshkalov354e1d22017-06-09 19:31:33 +02001662 all_gsrc = cookie_auth.get_auth_header('d0esN0tEx1st.googlesource.com')
Raul Tambre80ee78e2019-05-06 22:41:05 +00001663 print(
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001664 'WARNING: You have different credentials for Gerrit and git hosts:\n'
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001665 ' %s\n'
1666 ' %s\n'
Andrii Shyshkalov51acef92017-04-11 17:19:59 +02001667 ' Consider running the following command:\n'
1668 ' git cl creds-check\n'
Andrii Shyshkalov354e1d22017-06-09 19:31:33 +02001669 ' %s\n'
Raul Tambre80ee78e2019-05-06 22:41:05 +00001670 ' %s' %
Andrii Shyshkalov51acef92017-04-11 17:19:59 +02001671 (git_host, self._gerrit_host,
Andrii Shyshkalov354e1d22017-06-09 19:31:33 +02001672 ('Hint: delete creds for .googlesource.com' if all_gsrc else ''),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001673 cookie_auth.get_new_password_message(git_host)))
1674 if not force:
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01001675 confirm_or_exit('If you know what you are doing', action='continue')
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001676 return
1677 else:
1678 missing = (
Anna Henningsen4e891442017-07-06 21:40:58 +02001679 ([] if gerrit_auth else [self._gerrit_host]) +
1680 ([] if git_auth else [git_host]))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001681 DieWithError('Credentials for the following hosts are required:\n'
1682 ' %s\n'
1683 'These are read from %s (or legacy %s)\n'
1684 '%s' % (
1685 '\n '.join(missing),
1686 cookie_auth.get_gitcookies_path(),
1687 cookie_auth.get_netrc_path(),
1688 cookie_auth.get_new_password_message(git_host)))
1689
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001690 def EnsureCanUploadPatchset(self, force):
Andrii Shyshkalov3e631422017-02-16 17:46:44 +01001691 if not self.GetIssue():
1692 return
1693
Andrii Shyshkalov3e631422017-02-16 17:46:44 +01001694 status = self._GetChangeDetail()['status']
1695 if status in ('MERGED', 'ABANDONED'):
1696 DieWithError('Change %s has been %s, new uploads are not allowed' %
1697 (self.GetIssueURL(),
1698 'submitted' if status == 'MERGED' else 'abandoned'))
1699
Vadim Shtayurab250ec12018-10-04 00:21:08 +00001700 # TODO(vadimsh): For some reason the chunk of code below was skipped if
1701 # 'is_gce' is True. I'm just refactoring it to be 'skip if not cookies'.
1702 # Apparently this check is not very important? Otherwise get_auth_email
1703 # could have been added to other implementations of Authenticator.
1704 cookies_auth = gerrit_util.Authenticator.get()
1705 if not isinstance(cookies_auth, gerrit_util.CookiesAuthenticator):
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001706 return
Vadim Shtayurab250ec12018-10-04 00:21:08 +00001707
1708 cookies_user = cookies_auth.get_auth_email(self._GetGerritHost())
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001709 if self.GetIssueOwner() == cookies_user:
1710 return
1711 logging.debug('change %s owner is %s, cookies user is %s',
1712 self.GetIssue(), self.GetIssueOwner(), cookies_user)
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001713 # Maybe user has linked accounts or something like that,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001714 # so ask what Gerrit thinks of this user.
1715 details = gerrit_util.GetAccountDetails(self._GetGerritHost(), 'self')
1716 if details['email'] == self.GetIssueOwner():
1717 return
1718 if not force:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001719 print('WARNING: Change %s is owned by %s, but you authenticate to Gerrit '
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001720 'as %s.\n'
1721 'Uploading may fail due to lack of permissions.' %
1722 (self.GetIssue(), self.GetIssueOwner(), details['email']))
1723 confirm_or_exit(action='upload')
1724
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00001725 def _PostUnsetIssueProperties(self):
1726 """Which branch-specific properties to erase when unsetting issue."""
tandrii5d48c322016-08-18 16:19:37 -07001727 return ['gerritsquashhash']
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00001728
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001729 def GetGerritObjForPresubmit(self):
1730 return presubmit_support.GerritAccessor(self._GetGerritHost())
1731
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001732 def GetStatus(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001733 """Applies a rough heuristic to give a simple summary of an issue's review
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001734 or CQ status, assuming adherence to a common workflow.
1735
1736 Returns None if no issue for this branch, or one of the following keywords:
Aaron Gable9ab38c62017-04-06 14:36:33 -07001737 * 'error' - error from review tool (including deleted issues)
1738 * 'unsent' - no reviewers added
1739 * 'waiting' - waiting for review
1740 * 'reply' - waiting for uploader to reply to review
1741 * 'lgtm' - Code-Review label has been set
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +00001742 * 'dry-run' - dry-running in the CQ
1743 * 'commit' - in the CQ
Aaron Gable9ab38c62017-04-06 14:36:33 -07001744 * 'closed' - successfully submitted or abandoned
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001745 """
1746 if not self.GetIssue():
1747 return None
1748
1749 try:
Aaron Gable9ab38c62017-04-06 14:36:33 -07001750 data = self._GetChangeDetail([
1751 'DETAILED_LABELS', 'CURRENT_REVISION', 'SUBMITTABLE'])
Edward Lemur79d4f992019-11-11 23:49:02 +00001752 except GerritChangeNotExists:
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001753 return 'error'
1754
tandrii@chromium.org5e1bf382016-05-17 08:43:24 +00001755 if data['status'] in ('ABANDONED', 'MERGED'):
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001756 return 'closed'
1757
Andrii Shyshkalovb8268ca2019-04-03 23:33:44 +00001758 cq_label = data['labels'].get('Commit-Queue', {})
1759 max_cq_vote = 0
1760 for vote in cq_label.get('all', []):
1761 max_cq_vote = max(max_cq_vote, vote.get('value', 0))
1762 if max_cq_vote == 2:
Aaron Gable9ab38c62017-04-06 14:36:33 -07001763 return 'commit'
Andrii Shyshkalovb8268ca2019-04-03 23:33:44 +00001764 if max_cq_vote == 1:
1765 return 'dry-run'
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001766
Aaron Gable9ab38c62017-04-06 14:36:33 -07001767 if data['labels'].get('Code-Review', {}).get('approved'):
1768 return 'lgtm'
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001769
1770 if not data.get('reviewers', {}).get('REVIEWER', []):
1771 return 'unsent'
1772
Andrii Shyshkalov33e88a42017-01-27 14:45:30 +01001773 owner = data['owner'].get('_account_id')
Edward Lemur79d4f992019-11-11 23:49:02 +00001774 messages = sorted(data.get('messages', []), key=lambda m: m.get('date'))
Aaron Gable9ab38c62017-04-06 14:36:33 -07001775 last_message_author = messages.pop().get('author', {})
1776 while last_message_author:
Andrii Shyshkalov33e88a42017-01-27 14:45:30 +01001777 if last_message_author.get('email') == COMMIT_BOT_EMAIL:
1778 # Ignore replies from CQ.
Aaron Gable9ab38c62017-04-06 14:36:33 -07001779 last_message_author = messages.pop().get('author', {})
Andrii Shyshkalov33e88a42017-01-27 14:45:30 +01001780 continue
Aaron Gable9ab38c62017-04-06 14:36:33 -07001781 if last_message_author.get('_account_id') == owner:
1782 # Most recent message was by owner.
1783 return 'waiting'
1784 else:
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001785 # Some reply from non-owner.
1786 return 'reply'
Aaron Gable9ab38c62017-04-06 14:36:33 -07001787
1788 # Somehow there are no messages even though there are reviewers.
1789 return 'unsent'
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001790
1791 def GetMostRecentPatchset(self):
Edward Lemur6c6827c2020-02-06 21:15:18 +00001792 if not self.GetIssue():
1793 return None
1794
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001795 data = self._GetChangeDetail(['CURRENT_REVISION'])
Aaron Gablee8856ee2017-12-07 12:41:46 -08001796 patchset = data['revisions'][data['current_revision']]['_number']
1797 self.SetPatchset(patchset)
1798 return patchset
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001799
Aaron Gable636b13f2017-07-14 10:42:48 -07001800 def AddComment(self, message, publish=None):
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00001801 gerrit_util.SetReview(
1802 self._GetGerritHost(), self._GerritChangeIdentifier(),
1803 msg=message, ready=publish)
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01001804
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001805 def GetCommentsSummary(self, readable=True):
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01001806 # DETAILED_ACCOUNTS is to get emails in accounts.
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001807 # CURRENT_REVISION is included to get the latest patchset so that
1808 # only the robot comments from the latest patchset can be shown.
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001809 messages = self._GetChangeDetail(
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001810 options=['MESSAGES', 'DETAILED_ACCOUNTS',
1811 'CURRENT_REVISION']).get('messages', [])
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001812 file_comments = gerrit_util.GetChangeComments(
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00001813 self._GetGerritHost(), self._GerritChangeIdentifier())
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001814 robot_file_comments = gerrit_util.GetChangeRobotComments(
1815 self._GetGerritHost(), self._GerritChangeIdentifier())
1816
1817 # Add the robot comments onto the list of comments, but only
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00001818 # keep those that are from the latest patchset.
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001819 latest_patch_set = self.GetMostRecentPatchset()
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001820 for path, robot_comments in robot_file_comments.items():
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001821 line_comments = file_comments.setdefault(path, [])
1822 line_comments.extend(
1823 [c for c in robot_comments if c['patch_set'] == latest_patch_set])
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001824
1825 # Build dictionary of file comments for easy access and sorting later.
1826 # {author+date: {path: {patchset: {line: url+message}}}}
1827 comments = collections.defaultdict(
1828 lambda: collections.defaultdict(lambda: collections.defaultdict(dict)))
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001829 for path, line_comments in file_comments.items():
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001830 for comment in line_comments:
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001831 tag = comment.get('tag', '')
1832 if tag.startswith('autogenerated') and 'robot_id' not in comment:
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001833 continue
1834 key = (comment['author']['email'], comment['updated'])
1835 if comment.get('side', 'REVISION') == 'PARENT':
1836 patchset = 'Base'
1837 else:
1838 patchset = 'PS%d' % comment['patch_set']
1839 line = comment.get('line', 0)
1840 url = ('https://%s/c/%s/%s/%s#%s%s' %
1841 (self._GetGerritHost(), self.GetIssue(), comment['patch_set'], path,
1842 'b' if comment.get('side') == 'PARENT' else '',
1843 str(line) if line else ''))
1844 comments[key][path][patchset][line] = (url, comment['message'])
1845
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001846 summaries = []
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001847 for msg in messages:
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001848 summary = self._BuildCommentSummary(msg, comments, readable)
1849 if summary:
1850 summaries.append(summary)
1851 return summaries
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001852
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001853 @staticmethod
1854 def _BuildCommentSummary(msg, comments, readable):
1855 key = (msg['author']['email'], msg['date'])
1856 # Don't bother showing autogenerated messages that don't have associated
1857 # file or line comments. this will filter out most autogenerated
1858 # messages, but will keep robot comments like those from Tricium.
1859 is_autogenerated = msg.get('tag', '').startswith('autogenerated')
1860 if is_autogenerated and not comments.get(key):
1861 return None
1862 message = msg['message']
1863 # Gerrit spits out nanoseconds.
1864 assert len(msg['date'].split('.')[-1]) == 9
1865 date = datetime.datetime.strptime(msg['date'][:-3],
1866 '%Y-%m-%d %H:%M:%S.%f')
1867 if key in comments:
1868 message += '\n'
1869 for path, patchsets in sorted(comments.get(key, {}).items()):
1870 if readable:
1871 message += '\n%s' % path
1872 for patchset, lines in sorted(patchsets.items()):
1873 for line, (url, content) in sorted(lines.items()):
1874 if line:
1875 line_str = 'Line %d' % line
1876 path_str = '%s:%d:' % (path, line)
1877 else:
1878 line_str = 'File comment'
1879 path_str = '%s:0:' % path
1880 if readable:
1881 message += '\n %s, %s: %s' % (patchset, line_str, url)
1882 message += '\n %s\n' % content
1883 else:
1884 message += '\n%s ' % path_str
1885 message += '\n%s\n' % content
1886
1887 return _CommentSummary(
1888 date=date,
1889 message=message,
1890 sender=msg['author']['email'],
1891 autogenerated=is_autogenerated,
1892 # These could be inferred from the text messages and correlated with
1893 # Code-Review label maximum, however this is not reliable.
1894 # Leaving as is until the need arises.
1895 approval=False,
1896 disapproval=False,
1897 )
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01001898
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001899 def CloseIssue(self):
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00001900 gerrit_util.AbandonChange(
1901 self._GetGerritHost(), self._GerritChangeIdentifier(), msg='')
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001902
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00001903 def SubmitIssue(self, wait_for_merge=True):
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00001904 gerrit_util.SubmitChange(
1905 self._GetGerritHost(), self._GerritChangeIdentifier(),
1906 wait_for_merge=wait_for_merge)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001907
Edward Lesmes7677e5c2020-02-19 20:39:03 +00001908 def _GetChangeDetail(self, options=None):
1909 """Returns details of associated Gerrit change and caching results."""
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00001910 options = options or []
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001911 assert self.GetIssue(), 'issue is required to query Gerrit'
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01001912
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01001913 # Optimization to avoid multiple RPCs:
Edward Lesmes7677e5c2020-02-19 20:39:03 +00001914 if 'CURRENT_REVISION' in options or 'ALL_REVISIONS' in options:
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01001915 options.append('CURRENT_COMMIT')
1916
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01001917 # Normalize issue and options for consistent keys in cache.
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001918 cache_key = str(self.GetIssue())
Edward Lesmes7677e5c2020-02-19 20:39:03 +00001919 options_set = frozenset(o.upper() for o in options)
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01001920
Edward Lesmes7677e5c2020-02-19 20:39:03 +00001921 for cached_options_set, data in self._detail_cache.get(cache_key, []):
1922 # Assumption: data fetched before with extra options is suitable
1923 # for return for a smaller set of options.
1924 # For example, if we cached data for
1925 # options=[CURRENT_REVISION, DETAILED_FOOTERS]
1926 # and request is for options=[CURRENT_REVISION],
1927 # THEN we can return prior cached data.
1928 if options_set.issubset(cached_options_set):
1929 return data
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01001930
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01001931 try:
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001932 data = gerrit_util.GetChangeDetail(
Edward Lesmes7677e5c2020-02-19 20:39:03 +00001933 self._GetGerritHost(), self._GerritChangeIdentifier(), options_set)
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01001934 except gerrit_util.GerritError as e:
1935 if e.http_status == 404:
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001936 raise GerritChangeNotExists(self.GetIssue(), self.GetCodereviewServer())
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01001937 raise
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01001938
Edward Lesmes7677e5c2020-02-19 20:39:03 +00001939 self._detail_cache.setdefault(cache_key, []).append((options_set, data))
tandriic2405f52016-10-10 08:13:15 -07001940 return data
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001941
Andrii Shyshkalovcc5f17e2018-08-22 23:35:59 +00001942 def _GetChangeCommit(self):
Andrii Shyshkalove2633162018-08-27 23:50:31 +00001943 assert self.GetIssue(), 'issue must be set to query Gerrit'
Aaron Gable6f5a8d92017-04-18 14:49:05 -07001944 try:
Andrii Shyshkalove2633162018-08-27 23:50:31 +00001945 data = gerrit_util.GetChangeCommit(
1946 self._GetGerritHost(), self._GerritChangeIdentifier())
Aaron Gable6f5a8d92017-04-18 14:49:05 -07001947 except gerrit_util.GerritError as e:
1948 if e.http_status == 404:
Andrii Shyshkalove2633162018-08-27 23:50:31 +00001949 raise GerritChangeNotExists(self.GetIssue(), self.GetCodereviewServer())
Aaron Gable6f5a8d92017-04-18 14:49:05 -07001950 raise
agable32978d92016-11-01 12:55:02 -07001951 return data
1952
Karen Qian40c19422019-03-13 21:28:29 +00001953 def _IsCqConfigured(self):
1954 detail = self._GetChangeDetail(['LABELS'])
Andrii Shyshkalov8effa4d2020-01-21 13:23:36 +00001955 return u'Commit-Queue' in detail.get('labels', {})
Karen Qian40c19422019-03-13 21:28:29 +00001956
Olivier Robin75ee7252018-04-13 10:02:56 +02001957 def CMDLand(self, force, bypass_hooks, verbose, parallel):
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00001958 if git_common.is_dirty_git_tree('land'):
1959 return 1
Karen Qian40c19422019-03-13 21:28:29 +00001960
tandriid60367b2016-06-22 05:25:12 -07001961 detail = self._GetChangeDetail(['CURRENT_REVISION', 'LABELS'])
Karen Qian40c19422019-03-13 21:28:29 +00001962 if not force and self._IsCqConfigured():
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +00001963 confirm_or_exit('\nIt seems this repository has a CQ, '
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01001964 'which can test and land changes for you. '
1965 'Are you sure you wish to bypass it?\n',
1966 action='bypass CQ')
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00001967 differs = True
tandriic4344b52016-08-29 06:04:54 -07001968 last_upload = self._GitGetBranchConfigValue('gerritsquashhash')
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00001969 # Note: git diff outputs nothing if there is no diff.
1970 if not last_upload or RunGit(['diff', last_upload]).strip():
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001971 print('WARNING: Some changes from local branch haven\'t been uploaded.')
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00001972 else:
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00001973 if detail['current_revision'] == last_upload:
1974 differs = False
1975 else:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001976 print('WARNING: Local branch contents differ from latest uploaded '
1977 'patchset.')
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00001978 if differs:
1979 if not force:
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01001980 confirm_or_exit(
1981 'Do you want to submit latest Gerrit patchset and bypass hooks?\n',
1982 action='submit')
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001983 print('WARNING: Bypassing hooks and submitting latest uploaded patchset.')
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00001984 elif not bypass_hooks:
1985 hook_results = self.RunHook(
1986 committing=True,
1987 may_prompt=not force,
1988 verbose=verbose,
Edward Lemur7f6dec02020-02-06 20:23:58 +00001989 change=self.GetChange(self.GetCommonAncestorWithUpstream()),
Olivier Robin75ee7252018-04-13 10:02:56 +02001990 parallel=parallel)
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00001991 if not hook_results.should_continue():
1992 return 1
1993
1994 self.SubmitIssue(wait_for_merge=True)
1995 print('Issue %s has been submitted.' % self.GetIssueURL())
agable32978d92016-11-01 12:55:02 -07001996 links = self._GetChangeCommit().get('web_links', [])
1997 for link in links:
Aaron Gable02cdbb42016-12-13 16:24:25 -08001998 if link.get('name') == 'gitiles' and link.get('url'):
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001999 print('Landed as: %s' % link.get('url'))
agable32978d92016-11-01 12:55:02 -07002000 break
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002001 return 0
2002
Edward Lemurf38bc172019-09-03 21:02:13 +00002003 def CMDPatchWithParsedIssue(self, parsed_issue_arg, nocommit, force):
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002004 assert parsed_issue_arg.valid
2005
Edward Lemur125d60a2019-09-13 18:25:41 +00002006 self.issue = parsed_issue_arg.issue
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002007
2008 if parsed_issue_arg.hostname:
2009 self._gerrit_host = parsed_issue_arg.hostname
2010 self._gerrit_server = 'https://%s' % self._gerrit_host
2011
tandriic2405f52016-10-10 08:13:15 -07002012 try:
2013 detail = self._GetChangeDetail(['ALL_REVISIONS'])
Aaron Gablea45ee112016-11-22 15:14:38 -08002014 except GerritChangeNotExists as e:
tandriic2405f52016-10-10 08:13:15 -07002015 DieWithError(str(e))
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002016
2017 if not parsed_issue_arg.patchset:
2018 # Use current revision by default.
2019 revision_info = detail['revisions'][detail['current_revision']]
2020 patchset = int(revision_info['_number'])
2021 else:
2022 patchset = parsed_issue_arg.patchset
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00002023 for revision_info in detail['revisions'].values():
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002024 if int(revision_info['_number']) == parsed_issue_arg.patchset:
2025 break
2026 else:
Aaron Gablea45ee112016-11-22 15:14:38 -08002027 DieWithError('Couldn\'t find patchset %i in change %i' %
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002028 (parsed_issue_arg.patchset, self.GetIssue()))
2029
Edward Lemur125d60a2019-09-13 18:25:41 +00002030 remote_url = self.GetRemoteUrl()
Aaron Gable697a91b2018-01-19 15:20:15 -08002031 if remote_url.endswith('.git'):
2032 remote_url = remote_url[:-len('.git')]
erikchen0d14d0d2018-08-28 18:57:09 +00002033 remote_url = remote_url.rstrip('/')
2034
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002035 fetch_info = revision_info['fetch']['http']
erikchen0d14d0d2018-08-28 18:57:09 +00002036 fetch_info['url'] = fetch_info['url'].rstrip('/')
Aaron Gable697a91b2018-01-19 15:20:15 -08002037
2038 if remote_url != fetch_info['url']:
2039 DieWithError('Trying to patch a change from %s but this repo appears '
2040 'to be %s.' % (fetch_info['url'], remote_url))
2041
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002042 RunGit(['fetch', fetch_info['url'], fetch_info['ref']])
Aaron Gable9387b4f2017-06-08 10:50:03 -07002043
Aaron Gable62619a32017-06-16 08:22:09 -07002044 if force:
2045 RunGit(['reset', '--hard', 'FETCH_HEAD'])
2046 print('Checked out commit for change %i patchset %i locally' %
2047 (parsed_issue_arg.issue, patchset))
Stefan Zager2d5f0392017-10-10 15:17:53 -07002048 elif nocommit:
2049 RunGit(['cherry-pick', '--no-commit', 'FETCH_HEAD'])
2050 print('Patch applied to index.')
Aaron Gable62619a32017-06-16 08:22:09 -07002051 else:
Aaron Gable9387b4f2017-06-08 10:50:03 -07002052 RunGit(['cherry-pick', 'FETCH_HEAD'])
2053 print('Committed patch for change %i patchset %i locally.' %
Aaron Gable62619a32017-06-16 08:22:09 -07002054 (parsed_issue_arg.issue, patchset))
2055 print('Note: this created a local commit which does not have '
2056 'the same hash as the one uploaded for review. This will make '
2057 'uploading changes based on top of this branch difficult.\n'
2058 'If you want to do that, use "git cl patch --force" instead.')
2059
Stefan Zagerd08043c2017-10-12 12:07:02 -07002060 if self.GetBranch():
2061 self.SetIssue(parsed_issue_arg.issue)
2062 self.SetPatchset(patchset)
2063 fetched_hash = RunGit(['rev-parse', 'FETCH_HEAD']).strip()
2064 self._GitSetBranchConfigValue('last-upload-hash', fetched_hash)
2065 self._GitSetBranchConfigValue('gerritsquashhash', fetched_hash)
2066 else:
2067 print('WARNING: You are in detached HEAD state.\n'
2068 'The patch has been applied to your checkout, but you will not be '
2069 'able to upload a new patch set to the gerrit issue.\n'
2070 'Try using the \'-b\' option if you would like to work on a '
2071 'branch and/or upload a new patch set.')
2072
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002073 return 0
2074
tandrii16e0b4e2016-06-07 10:34:28 -07002075 def _GerritCommitMsgHookCheck(self, offer_removal):
2076 hook = os.path.join(settings.GetRoot(), '.git', 'hooks', 'commit-msg')
2077 if not os.path.exists(hook):
2078 return
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002079 # Crude attempt to distinguish Gerrit Codereview hook from a potentially
2080 # custom developer-made one.
tandrii16e0b4e2016-06-07 10:34:28 -07002081 data = gclient_utils.FileRead(hook)
2082 if not('From Gerrit Code Review' in data and 'add_ChangeId()' in data):
2083 return
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002084 print('WARNING: You have Gerrit commit-msg hook installed.\n'
qyearsley12fa6ff2016-08-24 09:18:40 -07002085 'It is not necessary for uploading with git cl in squash mode, '
tandrii16e0b4e2016-06-07 10:34:28 -07002086 'and may interfere with it in subtle ways.\n'
2087 'We recommend you remove the commit-msg hook.')
2088 if offer_removal:
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002089 if ask_for_explicit_yes('Do you want to remove it now?'):
tandrii16e0b4e2016-06-07 10:34:28 -07002090 gclient_utils.rm_file_or_tree(hook)
2091 print('Gerrit commit-msg hook removed.')
2092 else:
2093 print('OK, will keep Gerrit commit-msg hook in place.')
2094
Edward Lemur1b52d872019-05-09 21:12:12 +00002095 def _CleanUpOldTraces(self):
2096 """Keep only the last |MAX_TRACES| traces."""
2097 try:
2098 traces = sorted([
2099 os.path.join(TRACES_DIR, f)
2100 for f in os.listdir(TRACES_DIR)
2101 if (os.path.isfile(os.path.join(TRACES_DIR, f))
2102 and not f.startswith('tmp'))
2103 ])
2104 traces_to_delete = traces[:-MAX_TRACES]
2105 for trace in traces_to_delete:
Daniel Chengcf6269b2019-05-18 01:02:12 +00002106 os.remove(trace)
Edward Lemur1b52d872019-05-09 21:12:12 +00002107 except OSError:
2108 print('WARNING: Failed to remove old git traces from\n'
2109 ' %s'
2110 'Consider removing them manually.' % TRACES_DIR)
Edward Lemurdc8e23d2019-05-07 00:45:48 +00002111
Edward Lemur5737f022019-05-17 01:24:00 +00002112 def _WriteGitPushTraces(self, trace_name, traces_dir, git_push_metadata):
Edward Lemur1b52d872019-05-09 21:12:12 +00002113 """Zip and write the git push traces stored in traces_dir."""
2114 gclient_utils.safe_makedirs(TRACES_DIR)
Edward Lemur1b52d872019-05-09 21:12:12 +00002115 traces_zip = trace_name + '-traces'
2116 traces_readme = trace_name + '-README'
Michael Mosse7f0b4c2019-05-08 04:36:24 +00002117 # Create a temporary dir to store git config and gitcookies in. It will be
2118 # compressed and stored next to the traces.
2119 git_info_dir = tempfile.mkdtemp()
Edward Lemur1b52d872019-05-09 21:12:12 +00002120 git_info_zip = trace_name + '-git-info'
2121
Edward Lemur5737f022019-05-17 01:24:00 +00002122 git_push_metadata['now'] = datetime_now().strftime('%c')
Eric Boren67c48202019-05-30 16:52:51 +00002123 if sys.stdin.encoding and sys.stdin.encoding != 'utf-8':
sangwoo.ko7a614332019-05-22 02:46:19 +00002124 git_push_metadata['now'] = git_push_metadata['now'].decode(
2125 sys.stdin.encoding)
2126
Edward Lemur1b52d872019-05-09 21:12:12 +00002127 git_push_metadata['trace_name'] = trace_name
2128 gclient_utils.FileWrite(
2129 traces_readme, TRACES_README_FORMAT % git_push_metadata)
2130
2131 # Keep only the first 6 characters of the git hashes on the packet
2132 # trace. This greatly decreases size after compression.
2133 packet_traces = os.path.join(traces_dir, 'trace-packet')
2134 if os.path.isfile(packet_traces):
2135 contents = gclient_utils.FileRead(packet_traces)
2136 gclient_utils.FileWrite(
2137 packet_traces, GIT_HASH_RE.sub(r'\1', contents))
2138 shutil.make_archive(traces_zip, 'zip', traces_dir)
2139
2140 # Collect and compress the git config and gitcookies.
2141 git_config = RunGit(['config', '-l'])
2142 gclient_utils.FileWrite(
2143 os.path.join(git_info_dir, 'git-config'),
2144 git_config)
2145
2146 cookie_auth = gerrit_util.Authenticator.get()
2147 if isinstance(cookie_auth, gerrit_util.CookiesAuthenticator):
2148 gitcookies_path = cookie_auth.get_gitcookies_path()
2149 if os.path.isfile(gitcookies_path):
2150 gitcookies = gclient_utils.FileRead(gitcookies_path)
2151 gclient_utils.FileWrite(
2152 os.path.join(git_info_dir, 'gitcookies'),
2153 GITCOOKIES_REDACT_RE.sub('REDACTED', gitcookies))
2154 shutil.make_archive(git_info_zip, 'zip', git_info_dir)
2155
Edward Lemur1b52d872019-05-09 21:12:12 +00002156 gclient_utils.rmtree(git_info_dir)
2157
2158 def _RunGitPushWithTraces(
2159 self, change_desc, refspec, refspec_opts, git_push_metadata):
2160 """Run git push and collect the traces resulting from the execution."""
2161 # Create a temporary directory to store traces in. Traces will be compressed
2162 # and stored in a 'traces' dir inside depot_tools.
2163 traces_dir = tempfile.mkdtemp()
Edward Lemur5737f022019-05-17 01:24:00 +00002164 trace_name = os.path.join(
2165 TRACES_DIR, datetime_now().strftime('%Y%m%dT%H%M%S.%f'))
Edward Lemur0f58ae42019-04-30 17:24:12 +00002166
2167 env = os.environ.copy()
2168 env['GIT_REDACT_COOKIES'] = 'o,SSO,GSSO_Uberproxy'
2169 env['GIT_TR2_EVENT'] = os.path.join(traces_dir, 'tr2-event')
Jonathan Nieder9779b142019-05-29 23:19:29 +00002170 env['GIT_TRACE2_EVENT'] = os.path.join(traces_dir, 'tr2-event')
Edward Lemur0f58ae42019-04-30 17:24:12 +00002171 env['GIT_TRACE_CURL'] = os.path.join(traces_dir, 'trace-curl')
2172 env['GIT_TRACE_CURL_NO_DATA'] = '1'
2173 env['GIT_TRACE_PACKET'] = os.path.join(traces_dir, 'trace-packet')
2174
2175 try:
2176 push_returncode = 0
Edward Lemur1b52d872019-05-09 21:12:12 +00002177 remote_url = self.GetRemoteUrl()
Edward Lemur0f58ae42019-04-30 17:24:12 +00002178 before_push = time_time()
2179 push_stdout = gclient_utils.CheckCallAndFilter(
Edward Lemur1b52d872019-05-09 21:12:12 +00002180 ['git', 'push', remote_url, refspec],
Edward Lemur0f58ae42019-04-30 17:24:12 +00002181 env=env,
2182 print_stdout=True,
2183 # Flush after every line: useful for seeing progress when running as
2184 # recipe.
2185 filter_fn=lambda _: sys.stdout.flush())
Edward Lemur79d4f992019-11-11 23:49:02 +00002186 push_stdout = push_stdout.decode('utf-8', 'replace')
Edward Lemur0f58ae42019-04-30 17:24:12 +00002187 except subprocess2.CalledProcessError as e:
2188 push_returncode = e.returncode
2189 DieWithError('Failed to create a change. Please examine output above '
2190 'for the reason of the failure.\n'
2191 'Hint: run command below to diagnose common Git/Gerrit '
2192 'credential problems:\n'
Edward Lemur5737f022019-05-17 01:24:00 +00002193 ' git cl creds-check\n'
2194 '\n'
2195 'If git-cl is not working correctly, file a bug under the '
2196 'Infra>SDK component including the files below.\n'
2197 'Review the files before upload, since they might contain '
2198 'sensitive information.\n'
2199 'Set the Restrict-View-Google label so that they are not '
2200 'publicly accessible.\n'
2201 + TRACES_MESSAGE % {'trace_name': trace_name},
Edward Lemur0f58ae42019-04-30 17:24:12 +00002202 change_desc)
2203 finally:
2204 execution_time = time_time() - before_push
2205 metrics.collector.add_repeated('sub_commands', {
2206 'command': 'git push',
2207 'execution_time': execution_time,
2208 'exit_code': push_returncode,
2209 'arguments': metrics_utils.extract_known_subcommand_args(refspec_opts),
2210 })
2211
Edward Lemur1b52d872019-05-09 21:12:12 +00002212 git_push_metadata['execution_time'] = execution_time
2213 git_push_metadata['exit_code'] = push_returncode
Edward Lemur5737f022019-05-17 01:24:00 +00002214 self._WriteGitPushTraces(trace_name, traces_dir, git_push_metadata)
Edward Lemur0f58ae42019-04-30 17:24:12 +00002215
Edward Lemur1b52d872019-05-09 21:12:12 +00002216 self._CleanUpOldTraces()
Edward Lemur0f58ae42019-04-30 17:24:12 +00002217 gclient_utils.rmtree(traces_dir)
2218
2219 return push_stdout
2220
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002221 def CMDUploadChange(self, options, git_diff_args, custom_cl_base, change):
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002222 """Upload the current branch to Gerrit."""
Mike Frysingera989d552019-08-14 20:51:23 +00002223 if options.squash is None:
tandriia60502f2016-06-20 02:01:53 -07002224 # Load default for user, repo, squash=true, in this order.
2225 options.squash = settings.GetSquashGerritUploads()
tandrii26f3e4e2016-06-10 08:37:04 -07002226
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002227 remote, remote_branch = self.GetRemoteBranch()
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01002228 branch = GetTargetRef(remote, remote_branch, options.target_branch)
Aaron Gableb56ad332017-01-06 15:24:31 -08002229 # This may be None; default fallback value is determined in logic below.
2230 title = options.title
2231
Dominic Battre7d1c4842017-10-27 09:17:28 +02002232 # Extract bug number from branch name.
2233 bug = options.bug
Dan Beamd8b04ca2019-10-10 21:23:26 +00002234 fixed = options.fixed
2235 match = re.match(r'(?P<type>bug|fix(?:e[sd])?)[_-]?(?P<bugnum>\d+)',
2236 self.GetBranch())
2237 if not bug and not fixed and match:
2238 if match.group('type') == 'bug':
2239 bug = match.group('bugnum')
2240 else:
2241 fixed = match.group('bugnum')
Dominic Battre7d1c4842017-10-27 09:17:28 +02002242
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002243 if options.squash:
tandrii16e0b4e2016-06-07 10:34:28 -07002244 self._GerritCommitMsgHookCheck(offer_removal=not options.force)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002245 if self.GetIssue():
2246 # Try to get the message from a previous upload.
Edward Lemur6c6827c2020-02-06 21:15:18 +00002247 message = self.FetchDescription()
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002248 if not message:
2249 DieWithError(
Aaron Gablea45ee112016-11-22 15:14:38 -08002250 'failed to fetch description from current Gerrit change %d\n'
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002251 '%s' % (self.GetIssue(), self.GetIssueURL()))
Aaron Gableb56ad332017-01-06 15:24:31 -08002252 if not title:
Andrii Shyshkalov2d8a2072017-04-10 15:02:18 +02002253 if options.message:
Aaron Gable7303dcb2017-06-07 14:17:32 -07002254 # When uploading a subsequent patchset, -m|--message is taken
2255 # as the patchset title if --title was not provided.
2256 title = options.message.strip()
Andrii Shyshkalov2d8a2072017-04-10 15:02:18 +02002257 else:
2258 default_title = RunGit(
2259 ['show', '-s', '--format=%s', 'HEAD']).strip()
Aaron Gable7303dcb2017-06-07 14:17:32 -07002260 if options.force:
2261 title = default_title
2262 else:
2263 title = ask_for_data(
2264 'Title for patchset [%s]: ' % default_title) or default_title
Josipe827b0f2020-01-30 00:07:20 +00002265
2266 # User requested to change description
2267 if options.edit_description:
2268 change_desc = ChangeDescription(message, bug=bug, fixed=fixed)
2269 change_desc.prompt()
2270 message = change_desc.description
2271
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002272 change_id = self._GetChangeDetail()['change_id']
2273 while True:
2274 footer_change_ids = git_footers.get_footer_change_id(message)
2275 if footer_change_ids == [change_id]:
2276 break
2277 if not footer_change_ids:
2278 message = git_footers.add_footer_change_id(message, change_id)
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002279 print('WARNING: appended missing Change-Id to change description.')
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002280 continue
2281 # There is already a valid footer but with different or several ids.
2282 # Doing this automatically is non-trivial as we don't want to lose
2283 # existing other footers, yet we want to append just 1 desired
2284 # Change-Id. Thus, just create a new footer, but let user verify the
2285 # new description.
2286 message = '%s\n\nChange-Id: %s' % (message, change_id)
Dan Beamd8b04ca2019-10-10 21:23:26 +00002287 change_desc = ChangeDescription(message, bug=bug, fixed=fixed)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002288 if not options.force:
Anthony Polito8b955342019-09-24 19:01:36 +00002289 print(
2290 'WARNING: change %s has Change-Id footer(s):\n'
2291 ' %s\n'
2292 'but change has Change-Id %s, according to Gerrit.\n'
2293 'Please, check the proposed correction to the description, '
2294 'and edit it if necessary but keep the "Change-Id: %s" footer\n'
2295 % (self.GetIssue(), '\n '.join(footer_change_ids), change_id,
2296 change_id))
2297 confirm_or_exit(action='edit')
2298 change_desc.prompt()
2299
2300 message = change_desc.description
2301 if not message:
2302 DieWithError("Description is empty. Aborting...")
2303
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002304 # Continue the while loop.
2305 # Sanity check of this code - we should end up with proper message
2306 # footer.
2307 assert [change_id] == git_footers.get_footer_change_id(message)
Dan Beamd8b04ca2019-10-10 21:23:26 +00002308 change_desc = ChangeDescription(message, bug=bug, fixed=fixed)
Aaron Gableb56ad332017-01-06 15:24:31 -08002309 else: # if not self.GetIssue()
2310 if options.message:
2311 message = options.message
2312 else:
Andrii Shyshkalovb07575f2018-10-16 06:16:21 +00002313 message = _create_description_from_log(git_diff_args)
Aaron Gableb56ad332017-01-06 15:24:31 -08002314 if options.title:
2315 message = options.title + '\n\n' + message
Dan Beamd8b04ca2019-10-10 21:23:26 +00002316 change_desc = ChangeDescription(message, bug=bug, fixed=fixed)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002317 if not options.force:
Anthony Polito8b955342019-09-24 19:01:36 +00002318 change_desc.prompt()
2319
Aaron Gableb56ad332017-01-06 15:24:31 -08002320 # On first upload, patchset title is always this string, while
2321 # --title flag gets converted to first line of message.
2322 title = 'Initial upload'
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002323 if not change_desc.description:
2324 DieWithError("Description is empty. Aborting...")
Andrii Shyshkalov8c90d032017-04-19 21:27:26 +02002325 change_ids = git_footers.get_footer_change_id(change_desc.description)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002326 if len(change_ids) > 1:
2327 DieWithError('too many Change-Id footers, at most 1 allowed.')
2328 if not change_ids:
2329 # Generate the Change-Id automatically.
Andrii Shyshkalov8c90d032017-04-19 21:27:26 +02002330 change_desc.set_description(git_footers.add_footer_change_id(
2331 change_desc.description,
2332 GenerateGerritChangeId(change_desc.description)))
2333 change_ids = git_footers.get_footer_change_id(change_desc.description)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002334 assert len(change_ids) == 1
2335 change_id = change_ids[0]
2336
Robert Iannuccidb02dd02017-04-19 12:18:20 -07002337 if options.reviewers or options.tbrs or options.add_owners_to:
2338 change_desc.update_reviewers(options.reviewers, options.tbrs,
2339 options.add_owners_to, change)
Andrii Shyshkalov71f0da32019-07-15 22:45:18 +00002340 if options.preserve_tryjobs:
2341 change_desc.set_preserve_tryjobs()
Robert Iannuccidb02dd02017-04-19 12:18:20 -07002342
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002343 remote, upstream_branch = self.FetchUpstreamTuple(self.GetBranch())
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002344 parent = self._ComputeParent(remote, upstream_branch, custom_cl_base,
2345 options.force, change_desc)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002346 tree = RunGit(['rev-parse', 'HEAD:']).strip()
Edward Lesmesf6a22322019-11-04 22:14:39 +00002347 with tempfile.NamedTemporaryFile(delete=False) as desc_tempfile:
Edward Lemur79d4f992019-11-11 23:49:02 +00002348 desc_tempfile.write(change_desc.description.encode('utf-8', 'replace'))
Aaron Gable9a03ae02017-11-03 11:31:07 -07002349 desc_tempfile.close()
2350 ref_to_push = RunGit(['commit-tree', tree, '-p', parent,
2351 '-F', desc_tempfile.name]).strip()
2352 os.remove(desc_tempfile.name)
Anthony Polito8b955342019-09-24 19:01:36 +00002353 else: # if not options.squash
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002354 change_desc = ChangeDescription(
Andrii Shyshkalovb07575f2018-10-16 06:16:21 +00002355 options.message or _create_description_from_log(git_diff_args))
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002356 if not change_desc.description:
2357 DieWithError("Description is empty. Aborting...")
2358
2359 if not git_footers.get_footer_change_id(change_desc.description):
2360 DownloadGerritHook(False)
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002361 change_desc.set_description(
2362 self._AddChangeIdToCommitMessage(options, git_diff_args))
Robert Iannuccidb02dd02017-04-19 12:18:20 -07002363 if options.reviewers or options.tbrs or options.add_owners_to:
2364 change_desc.update_reviewers(options.reviewers, options.tbrs,
2365 options.add_owners_to, change)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002366 ref_to_push = 'HEAD'
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002367 # For no-squash mode, we assume the remote called "origin" is the one we
2368 # want. It is not worthwhile to support different workflows for
2369 # no-squash mode.
2370 parent = 'origin/%s' % branch
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002371 change_id = git_footers.get_footer_change_id(change_desc.description)[0]
2372
2373 assert change_desc
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +00002374 SaveDescriptionBackup(change_desc)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002375 commits = RunGitSilent(['rev-list', '%s..%s' % (parent,
2376 ref_to_push)]).splitlines()
2377 if len(commits) > 1:
2378 print('WARNING: This will upload %d commits. Run the following command '
2379 'to see which commits will be uploaded: ' % len(commits))
2380 print('git log %s..%s' % (parent, ref_to_push))
2381 print('You can also use `git squash-branch` to squash these into a '
2382 'single commit.')
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002383 confirm_or_exit(action='upload')
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002384
Aaron Gable6dadfbf2017-05-09 14:27:58 -07002385 if options.reviewers or options.tbrs or options.add_owners_to:
2386 change_desc.update_reviewers(options.reviewers, options.tbrs,
2387 options.add_owners_to, change)
2388
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00002389 reviewers = sorted(change_desc.get_reviewers())
Edward Lemur4508b422019-10-03 21:56:35 +00002390 cc = []
2391 # Add CCs from WATCHLISTS and rietveld.cc git config unless this is
2392 # the initial upload, the CL is private, or auto-CCing has ben disabled.
2393 if not (self.GetIssue() or options.private or options.no_autocc):
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00002394 cc = self.GetCCList().split(',')
Edward Lemur4508b422019-10-03 21:56:35 +00002395 # Add cc's from the --cc flag.
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00002396 if options.cc:
2397 cc.extend(options.cc)
Edward Lemur79d4f992019-11-11 23:49:02 +00002398 cc = [email.strip() for email in cc if email.strip()]
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00002399 if change_desc.get_cced():
2400 cc.extend(change_desc.get_cced())
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00002401 if self._GetGerritHost() == 'chromium-review.googlesource.com':
2402 valid_accounts = set(reviewers + cc)
2403 # TODO(crbug/877717): relax this for all hosts.
2404 else:
2405 valid_accounts = gerrit_util.ValidAccounts(
2406 self._GetGerritHost(), reviewers + cc)
Andrii Shyshkalovf170af42018-10-30 07:00:44 +00002407 logging.info('accounts %s are recognized, %s invalid',
2408 sorted(valid_accounts),
2409 set(reviewers + cc).difference(set(valid_accounts)))
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00002410
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00002411 # Extra options that can be specified at push time. Doc:
2412 # https://gerrit-review.googlesource.com/Documentation/user-upload.html
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00002413 refspec_opts = []
Andrii Shyshkalov2d8a2072017-04-10 15:02:18 +02002414
Aaron Gable844cf292017-06-28 11:32:59 -07002415 # By default, new changes are started in WIP mode, and subsequent patchsets
2416 # don't send email. At any time, passing --send-mail will mark the change
2417 # ready and send email for that particular patch.
Aaron Gableafd52772017-06-27 16:40:10 -07002418 if options.send_mail:
2419 refspec_opts.append('ready')
Aaron Gable844cf292017-06-28 11:32:59 -07002420 refspec_opts.append('notify=ALL')
Jamie Madill276da0b2018-04-27 14:41:20 -04002421 elif not self.GetIssue() and options.squash:
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08002422 refspec_opts.append('wip')
Aaron Gableafd52772017-06-27 16:40:10 -07002423 else:
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08002424 refspec_opts.append('notify=NONE')
Aaron Gable70f4e242017-06-26 10:45:59 -07002425
Andrii Shyshkalov2d8a2072017-04-10 15:02:18 +02002426 # TODO(tandrii): options.message should be posted as a comment
Aaron Gablee5adf612017-07-14 10:43:58 -07002427 # if --send-mail is set on non-initial upload as Rietveld used to do it.
Andrii Shyshkalov2d8a2072017-04-10 15:02:18 +02002428
Aaron Gable9b713dd2016-12-14 16:04:21 -08002429 if title:
Nick Carter8692b182017-11-06 16:30:38 -08002430 # Punctuation and whitespace in |title| must be percent-encoded.
2431 refspec_opts.append('m=' + gerrit_util.PercentEncodeForGitRef(title))
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00002432
agablec6787972016-09-09 16:13:34 -07002433 if options.private:
Aaron Gableb02daf02017-05-23 11:53:46 -07002434 refspec_opts.append('private')
agablec6787972016-09-09 16:13:34 -07002435
Andrii Shyshkalov2f727912018-10-15 17:02:33 +00002436 for r in sorted(reviewers):
2437 if r in valid_accounts:
2438 refspec_opts.append('r=%s' % r)
2439 reviewers.remove(r)
2440 else:
2441 # TODO(tandrii): this should probably be a hard failure.
2442 print('WARNING: reviewer %s doesn\'t have a Gerrit account, skipping'
2443 % r)
2444 for c in sorted(cc):
2445 # refspec option will be rejected if cc doesn't correspond to an
2446 # account, even though REST call to add such arbitrary cc may succeed.
2447 if c in valid_accounts:
2448 refspec_opts.append('cc=%s' % c)
2449 cc.remove(c)
2450
rmistry9eadede2016-09-19 11:22:43 -07002451 if options.topic:
2452 # Documentation on Gerrit topics is here:
2453 # https://gerrit-review.googlesource.com/Documentation/user-upload.html#topic
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00002454 refspec_opts.append('topic=%s' % options.topic)
rmistry9eadede2016-09-19 11:22:43 -07002455
Edward Lemur687ca902018-12-05 02:30:30 +00002456 if options.enable_auto_submit:
2457 refspec_opts.append('l=Auto-Submit+1')
2458 if options.use_commit_queue:
2459 refspec_opts.append('l=Commit-Queue+2')
2460 elif options.cq_dry_run:
2461 refspec_opts.append('l=Commit-Queue+1')
2462
2463 if change_desc.get_reviewers(tbr_only=True):
2464 score = gerrit_util.GetCodeReviewTbrScore(
2465 self._GetGerritHost(),
2466 self._GetGerritProject())
2467 refspec_opts.append('l=Code-Review+%s' % score)
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00002468
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08002469 # Gerrit sorts hashtags, so order is not important.
Nodir Turakulov23b82142017-11-16 11:04:25 -08002470 hashtags = {change_desc.sanitize_hash_tag(t) for t in options.hashtags}
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08002471 if not self.GetIssue():
Nodir Turakulov23b82142017-11-16 11:04:25 -08002472 hashtags.update(change_desc.get_hash_tags())
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08002473 refspec_opts += ['hashtag=%s' % t for t in sorted(hashtags)]
2474
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00002475 refspec_suffix = ''
2476 if refspec_opts:
2477 refspec_suffix = '%' + ','.join(refspec_opts)
2478 assert ' ' not in refspec_suffix, (
2479 'spaces not allowed in refspec: "%s"' % refspec_suffix)
2480 refspec = '%s:refs/for/%s%s' % (ref_to_push, branch, refspec_suffix)
2481
Edward Lemur1b52d872019-05-09 21:12:12 +00002482 git_push_metadata = {
2483 'gerrit_host': self._GetGerritHost(),
2484 'title': title or '<untitled>',
2485 'change_id': change_id,
2486 'description': change_desc.description,
2487 }
2488 push_stdout = self._RunGitPushWithTraces(
2489 change_desc, refspec, refspec_opts, git_push_metadata)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002490
2491 if options.squash:
Aaron Gable289b4312017-09-13 14:06:16 -07002492 regex = re.compile(r'remote:\s+https?://[\w\-\.\+\/#]*/(\d+)\s.*')
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002493 change_numbers = [m.group(1)
2494 for m in map(regex.match, push_stdout.splitlines())
2495 if m]
2496 if len(change_numbers) != 1:
2497 DieWithError(
2498 ('Created|Updated %d issues on Gerrit, but only 1 expected.\n'
Christopher Lamf732cd52017-01-24 12:40:11 +11002499 'Change-Id: %s') % (len(change_numbers), change_id), change_desc)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002500 self.SetIssue(change_numbers[0])
tandrii5d48c322016-08-18 16:19:37 -07002501 self._GitSetBranchConfigValue('gerritsquashhash', ref_to_push)
tandrii88189772016-09-29 04:29:57 -07002502
Andrii Shyshkalov2f727912018-10-15 17:02:33 +00002503 if self.GetIssue() and (reviewers or cc):
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00002504 # GetIssue() is not set in case of non-squash uploads according to tests.
2505 # TODO(agable): non-squash uploads in git cl should be removed.
2506 gerrit_util.AddReviewers(
2507 self._GetGerritHost(),
Andrii Shyshkalovd06cc782018-08-23 17:24:19 +00002508 self._GerritChangeIdentifier(),
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00002509 reviewers, cc,
2510 notify=bool(options.send_mail))
Aaron Gable6dadfbf2017-05-09 14:27:58 -07002511
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002512 return 0
2513
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002514 def _ComputeParent(self, remote, upstream_branch, custom_cl_base, force,
2515 change_desc):
2516 """Computes parent of the generated commit to be uploaded to Gerrit.
2517
2518 Returns revision or a ref name.
2519 """
2520 if custom_cl_base:
2521 # Try to avoid creating additional unintended CLs when uploading, unless
2522 # user wants to take this risk.
2523 local_ref_of_target_remote = self.GetRemoteBranch()[1]
2524 code, _ = RunGitWithCode(['merge-base', '--is-ancestor', custom_cl_base,
2525 local_ref_of_target_remote])
2526 if code == 1:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002527 print('\nWARNING: Manually specified base of this CL `%s` '
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002528 'doesn\'t seem to belong to target remote branch `%s`.\n\n'
2529 'If you proceed with upload, more than 1 CL may be created by '
2530 'Gerrit as a result, in turn confusing or crashing git cl.\n\n'
2531 'If you are certain that specified base `%s` has already been '
2532 'uploaded to Gerrit as another CL, you may proceed.\n' %
2533 (custom_cl_base, local_ref_of_target_remote, custom_cl_base))
2534 if not force:
2535 confirm_or_exit(
2536 'Do you take responsibility for cleaning up potential mess '
2537 'resulting from proceeding with upload?',
2538 action='upload')
2539 return custom_cl_base
2540
Aaron Gablef97e33d2017-03-30 15:44:27 -07002541 if remote != '.':
2542 return self.GetCommonAncestorWithUpstream()
2543
2544 # If our upstream branch is local, we base our squashed commit on its
2545 # squashed version.
2546 upstream_branch_name = scm.GIT.ShortBranchName(upstream_branch)
2547
Aaron Gablef97e33d2017-03-30 15:44:27 -07002548 if upstream_branch_name == 'master':
Aaron Gable0bbd1c22017-05-08 14:37:08 -07002549 return self.GetCommonAncestorWithUpstream()
Aaron Gablef97e33d2017-03-30 15:44:27 -07002550
2551 # Check the squashed hash of the parent.
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002552 # TODO(tandrii): consider checking parent change in Gerrit and using its
2553 # hash if tree hash of latest parent revision (patchset) in Gerrit matches
2554 # the tree hash of the parent branch. The upside is less likely bogus
2555 # requests to reupload parent change just because it's uploadhash is
2556 # missing, yet the downside likely exists, too (albeit unknown to me yet).
Aaron Gablef97e33d2017-03-30 15:44:27 -07002557 parent = RunGit(['config',
2558 'branch.%s.gerritsquashhash' % upstream_branch_name],
2559 error_ok=True).strip()
2560 # Verify that the upstream branch has been uploaded too, otherwise
2561 # Gerrit will create additional CLs when uploading.
2562 if not parent or (RunGitSilent(['rev-parse', upstream_branch + ':']) !=
2563 RunGitSilent(['rev-parse', parent + ':'])):
2564 DieWithError(
2565 '\nUpload upstream branch %s first.\n'
2566 'It is likely that this branch has been rebased since its last '
2567 'upload, so you just need to upload it again.\n'
2568 '(If you uploaded it with --no-squash, then branch dependencies '
2569 'are not supported, and you should reupload with --squash.)'
2570 % upstream_branch_name,
2571 change_desc)
2572 return parent
2573
tandrii@chromium.org8930b3d2016-04-13 14:47:02 +00002574 def _AddChangeIdToCommitMessage(self, options, args):
2575 """Re-commits using the current message, assumes the commit hook is in
2576 place.
2577 """
Andrii Shyshkalovb07575f2018-10-16 06:16:21 +00002578 log_desc = options.message or _create_description_from_log(args)
tandrii@chromium.org8930b3d2016-04-13 14:47:02 +00002579 git_command = ['commit', '--amend', '-m', log_desc]
2580 RunGit(git_command)
Andrii Shyshkalovb07575f2018-10-16 06:16:21 +00002581 new_log_desc = _create_description_from_log(args)
tandrii@chromium.org8930b3d2016-04-13 14:47:02 +00002582 if git_footers.get_footer_change_id(new_log_desc):
vapiera7fbd5a2016-06-16 09:17:49 -07002583 print('git-cl: Added Change-Id to commit message.')
tandrii@chromium.org8930b3d2016-04-13 14:47:02 +00002584 return new_log_desc
2585 else:
tandrii@chromium.orgb067ec52016-05-31 15:24:44 +00002586 DieWithError('ERROR: Gerrit commit-msg hook not installed.')
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002587
tandriie113dfd2016-10-11 10:20:12 -07002588 def CannotTriggerTryJobReason(self):
tandrii8c5a3532016-11-04 07:52:02 -07002589 try:
2590 data = self._GetChangeDetail()
Aaron Gablea45ee112016-11-22 15:14:38 -08002591 except GerritChangeNotExists:
2592 return 'Gerrit doesn\'t know about your change %s' % self.GetIssue()
tandrii8c5a3532016-11-04 07:52:02 -07002593
2594 if data['status'] in ('ABANDONED', 'MERGED'):
2595 return 'CL %s is closed' % self.GetIssue()
2596
Edward Lemurd4d1ba42019-09-20 21:46:37 +00002597 def GetGerritChange(self, patchset=None):
2598 """Returns a buildbucket.v2.GerritChange message for the current issue."""
Edward Lemur79d4f992019-11-11 23:49:02 +00002599 host = urllib.parse.urlparse(self.GetCodereviewServer()).hostname
Edward Lemurd4d1ba42019-09-20 21:46:37 +00002600 issue = self.GetIssue()
Edward Lemur2c210a42019-09-16 23:58:35 +00002601 patchset = int(patchset or self.GetPatchset())
Edward Lemurd4d1ba42019-09-20 21:46:37 +00002602 data = self._GetChangeDetail(['ALL_REVISIONS'])
2603
2604 assert host and issue and patchset, 'CL must be uploaded first'
2605
2606 has_patchset = any(
2607 int(revision_data['_number']) == patchset
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00002608 for revision_data in data['revisions'].values())
Edward Lemurd4d1ba42019-09-20 21:46:37 +00002609 if not has_patchset:
Aaron Gablea45ee112016-11-22 15:14:38 -08002610 raise Exception('Patchset %d is not known in Gerrit change %d' %
tandrii8c5a3532016-11-04 07:52:02 -07002611 (patchset, self.GetIssue()))
Edward Lemurd4d1ba42019-09-20 21:46:37 +00002612
tandrii8c5a3532016-11-04 07:52:02 -07002613 return {
Edward Lemurd4d1ba42019-09-20 21:46:37 +00002614 'host': host,
2615 'change': issue,
2616 'project': data['project'],
2617 'patchset': patchset,
tandrii8c5a3532016-11-04 07:52:02 -07002618 }
tandriie113dfd2016-10-11 10:20:12 -07002619
tandriide281ae2016-10-12 06:02:30 -07002620 def GetIssueOwner(self):
tandrii8c5a3532016-11-04 07:52:02 -07002621 return self._GetChangeDetail(['DETAILED_ACCOUNTS'])['owner']['email']
tandriide281ae2016-10-12 06:02:30 -07002622
Edward Lemur707d70b2018-02-07 00:50:14 +01002623 def GetReviewers(self):
2624 details = self._GetChangeDetail(['DETAILED_ACCOUNTS'])
Mohamed Heikal171c0742018-11-09 20:38:51 +00002625 return [r['email'] for r in details['reviewers'].get('REVIEWER', [])]
Edward Lemur707d70b2018-02-07 00:50:14 +01002626
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002627
tandriif9aefb72016-07-01 09:06:51 -07002628def _get_bug_line_values(default_project, bugs):
2629 """Given default_project and comma separated list of bugs, yields bug line
2630 values.
2631
2632 Each bug can be either:
2633 * a number, which is combined with default_project
2634 * string, which is left as is.
2635
2636 This function may produce more than one line, because bugdroid expects one
2637 project per line.
2638
2639 >>> list(_get_bug_line_values('v8', '123,chromium:789'))
2640 ['v8:123', 'chromium:789']
2641 """
2642 default_bugs = []
2643 others = []
2644 for bug in bugs.split(','):
2645 bug = bug.strip()
2646 if bug:
2647 try:
2648 default_bugs.append(int(bug))
2649 except ValueError:
2650 others.append(bug)
2651
2652 if default_bugs:
2653 default_bugs = ','.join(map(str, default_bugs))
2654 if default_project:
2655 yield '%s:%s' % (default_project, default_bugs)
2656 else:
2657 yield default_bugs
2658 for other in sorted(others):
2659 # Don't bother finding common prefixes, CLs with >2 bugs are very very rare.
2660 yield other
2661
2662
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00002663class ChangeDescription(object):
2664 """Contains a parsed form of the change description."""
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00002665 R_LINE = r'^[ \t]*(TBR|R)[ \t]*=[ \t]*(.*?)[ \t]*$'
bradnelsond975b302016-10-23 12:20:23 -07002666 CC_LINE = r'^[ \t]*(CC)[ \t]*=[ \t]*(.*?)[ \t]*$'
Aaron Gable3a16ed12017-03-23 10:51:55 -07002667 BUG_LINE = r'^[ \t]*(?:(BUG)[ \t]*=|Bug:)[ \t]*(.*?)[ \t]*$'
Dan Beamd8b04ca2019-10-10 21:23:26 +00002668 FIXED_LINE = r'^[ \t]*Fixed[ \t]*:[ \t]*(.*?)[ \t]*$'
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01002669 CHERRY_PICK_LINE = r'^\(cherry picked from commit [a-fA-F0-9]{40}\)$'
Nodir Turakulov23b82142017-11-16 11:04:25 -08002670 STRIP_HASH_TAG_PREFIX = r'^(\s*(revert|reland)( "|:)?\s*)*'
2671 BRACKET_HASH_TAG = r'\s*\[([^\[\]]+)\]'
Anthony Polito02b5af32019-12-02 19:49:47 +00002672 COLON_SEPARATED_HASH_TAG = r'^([a-zA-Z0-9_\- ]+):($|[^:])'
Nodir Turakulov23b82142017-11-16 11:04:25 -08002673 BAD_HASH_TAG_CHUNK = r'[^a-zA-Z0-9]+'
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00002674
Dan Beamd8b04ca2019-10-10 21:23:26 +00002675 def __init__(self, description, bug=None, fixed=None):
agable@chromium.org42c20792013-09-12 17:34:49 +00002676 self._description_lines = (description or '').strip().splitlines()
Anthony Polito8b955342019-09-24 19:01:36 +00002677 if bug:
2678 regexp = re.compile(self.BUG_LINE)
2679 prefix = settings.GetBugPrefix()
2680 if not any((regexp.match(line) for line in self._description_lines)):
2681 values = list(_get_bug_line_values(prefix, bug))
2682 self.append_footer('Bug: %s' % ', '.join(values))
Dan Beamd8b04ca2019-10-10 21:23:26 +00002683 if fixed:
2684 regexp = re.compile(self.FIXED_LINE)
2685 prefix = settings.GetBugPrefix()
2686 if not any((regexp.match(line) for line in self._description_lines)):
2687 values = list(_get_bug_line_values(prefix, fixed))
2688 self.append_footer('Fixed: %s' % ', '.join(values))
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002689
agable@chromium.org42c20792013-09-12 17:34:49 +00002690 @property # www.logilab.org/ticket/89786
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -08002691 def description(self): # pylint: disable=method-hidden
agable@chromium.org42c20792013-09-12 17:34:49 +00002692 return '\n'.join(self._description_lines)
2693
2694 def set_description(self, desc):
2695 if isinstance(desc, basestring):
2696 lines = desc.splitlines()
2697 else:
2698 lines = [line.rstrip() for line in desc]
2699 while lines and not lines[0]:
2700 lines.pop(0)
2701 while lines and not lines[-1]:
2702 lines.pop(-1)
2703 self._description_lines = lines
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002704
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002705 def update_reviewers(self, reviewers, tbrs, add_owners_to=None, change=None):
2706 """Rewrites the R=/TBR= line(s) as a single line each.
2707
2708 Args:
2709 reviewers (list(str)) - list of additional emails to use for reviewers.
2710 tbrs (list(str)) - list of additional emails to use for TBRs.
2711 add_owners_to (None|'R'|'TBR') - Pass to do an OWNERS lookup for files in
2712 the change that are missing OWNER coverage. If this is not None, you
2713 must also pass a value for `change`.
2714 change (Change) - The Change that should be used for OWNERS lookups.
2715 """
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002716 assert isinstance(reviewers, list), reviewers
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002717 assert isinstance(tbrs, list), tbrs
2718
Robert Iannuccif2708bd2017-04-17 15:49:02 -07002719 assert add_owners_to in (None, 'TBR', 'R'), add_owners_to
Robert Iannuccia28592e2017-04-18 13:14:49 -07002720 assert not add_owners_to or change, add_owners_to
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002721
2722 if not reviewers and not tbrs and not add_owners_to:
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002723 return
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002724
2725 reviewers = set(reviewers)
2726 tbrs = set(tbrs)
2727 LOOKUP = {
2728 'TBR': tbrs,
2729 'R': reviewers,
2730 }
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002731
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002732 # Get the set of R= and TBR= lines and remove them from the description.
agable@chromium.org42c20792013-09-12 17:34:49 +00002733 regexp = re.compile(self.R_LINE)
2734 matches = [regexp.match(line) for line in self._description_lines]
2735 new_desc = [l for i, l in enumerate(self._description_lines)
2736 if not matches[i]]
2737 self.set_description(new_desc)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002738
agable@chromium.org42c20792013-09-12 17:34:49 +00002739 # Construct new unified R= and TBR= lines.
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002740
2741 # First, update tbrs/reviewers with names from the R=/TBR= lines (if any).
agable@chromium.org42c20792013-09-12 17:34:49 +00002742 for match in matches:
2743 if not match:
2744 continue
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002745 LOOKUP[match.group(1)].update(cleanup_list([match.group(2).strip()]))
2746
2747 # Next, maybe fill in OWNERS coverage gaps to either tbrs/reviewers.
Robert Iannuccif2708bd2017-04-17 15:49:02 -07002748 if add_owners_to:
piman@chromium.org336f9122014-09-04 02:16:55 +00002749 owners_db = owners.Database(change.RepositoryRoot(),
Jochen Eisinger72606f82017-04-04 10:44:18 +02002750 fopen=file, os_path=os.path)
piman@chromium.org336f9122014-09-04 02:16:55 +00002751 missing_files = owners_db.files_not_covered_by(change.LocalPaths(),
Robert Iannucci100aa212017-04-18 17:28:26 -07002752 (tbrs | reviewers))
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002753 LOOKUP[add_owners_to].update(
2754 owners_db.reviewers_for(missing_files, change.author_email))
Robert Iannuccif2708bd2017-04-17 15:49:02 -07002755
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002756 # If any folks ended up in both groups, remove them from tbrs.
2757 tbrs -= reviewers
Robert Iannuccif2708bd2017-04-17 15:49:02 -07002758
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002759 new_r_line = 'R=' + ', '.join(sorted(reviewers)) if reviewers else None
2760 new_tbr_line = 'TBR=' + ', '.join(sorted(tbrs)) if tbrs else None
agable@chromium.org42c20792013-09-12 17:34:49 +00002761
2762 # Put the new lines in the description where the old first R= line was.
2763 line_loc = next((i for i, match in enumerate(matches) if match), -1)
2764 if 0 <= line_loc < len(self._description_lines):
2765 if new_tbr_line:
2766 self._description_lines.insert(line_loc, new_tbr_line)
2767 if new_r_line:
2768 self._description_lines.insert(line_loc, new_r_line)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002769 else:
agable@chromium.org42c20792013-09-12 17:34:49 +00002770 if new_r_line:
2771 self.append_footer(new_r_line)
2772 if new_tbr_line:
2773 self.append_footer(new_tbr_line)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002774
Andrii Shyshkalov71f0da32019-07-15 22:45:18 +00002775 def set_preserve_tryjobs(self):
2776 """Ensures description footer contains 'Cq-Do-Not-Cancel-Tryjobs: true'."""
2777 footers = git_footers.parse_footers(self.description)
2778 for v in footers.get('Cq-Do-Not-Cancel-Tryjobs', []):
2779 if v.lower() == 'true':
2780 return
2781 self.append_footer('Cq-Do-Not-Cancel-Tryjobs: true')
2782
Anthony Polito8b955342019-09-24 19:01:36 +00002783 def prompt(self):
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002784 """Asks the user to update the description."""
agable@chromium.org42c20792013-09-12 17:34:49 +00002785 self.set_description([
2786 '# Enter a description of the change.',
2787 '# This will be displayed on the codereview site.',
2788 '# The first line will also be used as the subject of the review.',
alancutter@chromium.orgbd1073e2013-06-01 00:34:38 +00002789 '#--------------------This line is 72 characters long'
agable@chromium.org42c20792013-09-12 17:34:49 +00002790 '--------------------',
2791 ] + self._description_lines)
Dan Beamd8b04ca2019-10-10 21:23:26 +00002792 bug_regexp = re.compile(self.BUG_LINE)
2793 fixed_regexp = re.compile(self.FIXED_LINE)
Jonas Termansend0f79112019-03-22 15:28:26 +00002794 prefix = settings.GetBugPrefix()
Dan Beamd8b04ca2019-10-10 21:23:26 +00002795 has_issue = lambda l: bug_regexp.match(l) or fixed_regexp.match(l)
2796 if not any((has_issue(line) for line in self._description_lines)):
Anthony Polito8b955342019-09-24 19:01:36 +00002797 self.append_footer('Bug: %s' % prefix)
tandriif9aefb72016-07-01 09:06:51 -07002798
agable@chromium.org42c20792013-09-12 17:34:49 +00002799 content = gclient_utils.RunEditor(self.description, True,
Edward Lemur79d4f992019-11-11 23:49:02 +00002800 git_editor=settings.GetGitEditor())
maruel@chromium.org0e0436a2011-10-25 13:32:41 +00002801 if not content:
2802 DieWithError('Running editor failed')
agable@chromium.org42c20792013-09-12 17:34:49 +00002803 lines = content.splitlines()
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002804
Bruce Dawson2377b012018-01-11 16:46:49 -08002805 # Strip off comments and default inserted "Bug:" line.
2806 clean_lines = [line.rstrip() for line in lines if not
Jonas Termansend0f79112019-03-22 15:28:26 +00002807 (line.startswith('#') or
2808 line.rstrip() == "Bug:" or
2809 line.rstrip() == "Bug: " + prefix)]
agable@chromium.org42c20792013-09-12 17:34:49 +00002810 if not clean_lines:
maruel@chromium.org0e0436a2011-10-25 13:32:41 +00002811 DieWithError('No CL description, aborting')
agable@chromium.org42c20792013-09-12 17:34:49 +00002812 self.set_description(clean_lines)
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00002813
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002814 def append_footer(self, line):
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002815 """Adds a footer line to the description.
2816
2817 Differentiates legacy "KEY=xxx" footers (used to be called tags) and
2818 Gerrit's footers in the form of "Footer-Key: footer any value" and ensures
2819 that Gerrit footers are always at the end.
2820 """
2821 parsed_footer_line = git_footers.parse_footer(line)
2822 if parsed_footer_line:
2823 # Line is a gerrit footer in the form: Footer-Key: any value.
2824 # Thus, must be appended observing Gerrit footer rules.
2825 self.set_description(
2826 git_footers.add_footer(self.description,
2827 key=parsed_footer_line[0],
2828 value=parsed_footer_line[1]))
2829 return
2830
2831 if not self._description_lines:
2832 self._description_lines.append(line)
2833 return
2834
2835 top_lines, gerrit_footers, _ = git_footers.split_footers(self.description)
2836 if gerrit_footers:
2837 # git_footers.split_footers ensures that there is an empty line before
2838 # actual (gerrit) footers, if any. We have to keep it that way.
2839 assert top_lines and top_lines[-1] == ''
2840 top_lines, separator = top_lines[:-1], top_lines[-1:]
2841 else:
2842 separator = [] # No need for separator if there are no gerrit_footers.
2843
2844 prev_line = top_lines[-1] if top_lines else ''
2845 if (not presubmit_support.Change.TAG_LINE_RE.match(prev_line) or
2846 not presubmit_support.Change.TAG_LINE_RE.match(line)):
2847 top_lines.append('')
2848 top_lines.append(line)
2849 self._description_lines = top_lines + separator + gerrit_footers
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00002850
tandrii99a72f22016-08-17 14:33:24 -07002851 def get_reviewers(self, tbr_only=False):
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002852 """Retrieves the list of reviewers."""
agable@chromium.org42c20792013-09-12 17:34:49 +00002853 matches = [re.match(self.R_LINE, line) for line in self._description_lines]
tandrii99a72f22016-08-17 14:33:24 -07002854 reviewers = [match.group(2).strip()
2855 for match in matches
2856 if match and (not tbr_only or match.group(1).upper() == 'TBR')]
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002857 return cleanup_list(reviewers)
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00002858
bradnelsond975b302016-10-23 12:20:23 -07002859 def get_cced(self):
2860 """Retrieves the list of reviewers."""
2861 matches = [re.match(self.CC_LINE, line) for line in self._description_lines]
2862 cced = [match.group(2).strip() for match in matches if match]
2863 return cleanup_list(cced)
2864
Nodir Turakulov23b82142017-11-16 11:04:25 -08002865 def get_hash_tags(self):
2866 """Extracts and sanitizes a list of Gerrit hashtags."""
2867 subject = (self._description_lines or ('',))[0]
2868 subject = re.sub(
2869 self.STRIP_HASH_TAG_PREFIX, '', subject, flags=re.IGNORECASE)
2870
2871 tags = []
2872 start = 0
2873 bracket_exp = re.compile(self.BRACKET_HASH_TAG)
2874 while True:
2875 m = bracket_exp.match(subject, start)
2876 if not m:
2877 break
2878 tags.append(self.sanitize_hash_tag(m.group(1)))
2879 start = m.end()
2880
2881 if not tags:
2882 # Try "Tag: " prefix.
2883 m = re.match(self.COLON_SEPARATED_HASH_TAG, subject)
2884 if m:
2885 tags.append(self.sanitize_hash_tag(m.group(1)))
2886 return tags
2887
2888 @classmethod
2889 def sanitize_hash_tag(cls, tag):
2890 """Returns a sanitized Gerrit hash tag.
2891
2892 A sanitized hashtag can be used as a git push refspec parameter value.
2893 """
2894 return re.sub(cls.BAD_HASH_TAG_CHUNK, '-', tag).strip('-').lower()
2895
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01002896 def update_with_git_number_footers(self, parent_hash, parent_msg, dest_ref):
2897 """Updates this commit description given the parent.
2898
2899 This is essentially what Gnumbd used to do.
2900 Consult https://goo.gl/WMmpDe for more details.
2901 """
2902 assert parent_msg # No, orphan branch creation isn't supported.
2903 assert parent_hash
2904 assert dest_ref
2905 parent_footer_map = git_footers.parse_footers(parent_msg)
2906 # This will also happily parse svn-position, which GnumbD is no longer
2907 # supporting. While we'd generate correct footers, the verifier plugin
2908 # installed in Gerrit will block such commit (ie git push below will fail).
2909 parent_position = git_footers.get_position(parent_footer_map)
2910
2911 # Cherry-picks may have last line obscuring their prior footers,
2912 # from git_footers perspective. This is also what Gnumbd did.
2913 cp_line = None
2914 if (self._description_lines and
2915 re.match(self.CHERRY_PICK_LINE, self._description_lines[-1])):
2916 cp_line = self._description_lines.pop()
2917
Andrii Shyshkalovde37c012017-07-06 21:06:50 +02002918 top_lines, footer_lines, _ = git_footers.split_footers(self.description)
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01002919
2920 # Original-ify all Cr- footers, to avoid re-lands, cherry-picks, or just
2921 # user interference with actual footers we'd insert below.
Andrii Shyshkalovde37c012017-07-06 21:06:50 +02002922 for i, line in enumerate(footer_lines):
2923 k, v = git_footers.parse_footer(line) or (None, None)
2924 if k and k.startswith('Cr-'):
2925 footer_lines[i] = '%s: %s' % ('Cr-Original-' + k[len('Cr-'):], v)
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01002926
2927 # Add Position and Lineage footers based on the parent.
Andrii Shyshkalovb5effa12016-12-14 19:35:12 +01002928 lineage = list(reversed(parent_footer_map.get('Cr-Branched-From', [])))
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01002929 if parent_position[0] == dest_ref:
2930 # Same branch as parent.
2931 number = int(parent_position[1]) + 1
2932 else:
2933 number = 1 # New branch, and extra lineage.
2934 lineage.insert(0, '%s-%s@{#%d}' % (parent_hash, parent_position[0],
2935 int(parent_position[1])))
2936
Andrii Shyshkalovde37c012017-07-06 21:06:50 +02002937 footer_lines.append('Cr-Commit-Position: %s@{#%d}' % (dest_ref, number))
2938 footer_lines.extend('Cr-Branched-From: %s' % v for v in lineage)
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01002939
2940 self._description_lines = top_lines
2941 if cp_line:
2942 self._description_lines.append(cp_line)
2943 if self._description_lines[-1] != '':
2944 self._description_lines.append('') # Ensure footer separator.
Andrii Shyshkalovde37c012017-07-06 21:06:50 +02002945 self._description_lines.extend(footer_lines)
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01002946
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00002947
Aaron Gablea1bab272017-04-11 16:38:18 -07002948def get_approving_reviewers(props, disapproval=False):
maruel@chromium.orge52678e2013-04-26 18:34:44 +00002949 """Retrieves the reviewers that approved a CL from the issue properties with
2950 messages.
2951
2952 Note that the list may contain reviewers that are not committer, thus are not
2953 considered by the CQ.
Aaron Gablea1bab272017-04-11 16:38:18 -07002954
2955 If disapproval is True, instead returns reviewers who 'not lgtm'd the CL.
maruel@chromium.orge52678e2013-04-26 18:34:44 +00002956 """
Aaron Gablea1bab272017-04-11 16:38:18 -07002957 approval_type = 'disapproval' if disapproval else 'approval'
maruel@chromium.orge52678e2013-04-26 18:34:44 +00002958 return sorted(
2959 set(
2960 message['sender']
2961 for message in props['messages']
Aaron Gablea1bab272017-04-11 16:38:18 -07002962 if message[approval_type] and message['sender'] in props['reviewers']
maruel@chromium.orge52678e2013-04-26 18:34:44 +00002963 )
2964 )
2965
2966
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00002967def FindCodereviewSettingsFile(filename='codereview.settings'):
2968 """Finds the given file starting in the cwd and going up.
2969
2970 Only looks up to the top of the repository unless an
2971 'inherit-review-settings-ok' file exists in the root of the repository.
2972 """
2973 inherit_ok_file = 'inherit-review-settings-ok'
2974 cwd = os.getcwd()
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00002975 root = settings.GetRoot()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00002976 if os.path.isfile(os.path.join(root, inherit_ok_file)):
2977 root = '/'
2978 while True:
2979 if filename in os.listdir(cwd):
2980 if os.path.isfile(os.path.join(cwd, filename)):
2981 return open(os.path.join(cwd, filename))
2982 if cwd == root:
2983 break
2984 cwd = os.path.dirname(cwd)
2985
2986
2987def LoadCodereviewSettingsFromFile(fileobj):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002988 """Parses a codereview.settings file and updates hooks."""
maruel@chromium.org99ac1c52012-01-16 14:52:12 +00002989 keyvals = gclient_utils.ParseCodereviewSettingsContent(fileobj.read())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00002990
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00002991 def SetProperty(name, setting, unset_error_ok=False):
2992 fullname = 'rietveld.' + name
2993 if setting in keyvals:
2994 RunGit(['config', fullname, keyvals[setting]])
2995 else:
2996 RunGit(['config', '--unset-all', fullname], error_ok=unset_error_ok)
2997
tandrii48df5812016-10-17 03:55:37 -07002998 if not keyvals.get('GERRIT_HOST', False):
2999 SetProperty('server', 'CODE_REVIEW_SERVER')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003000 # Only server setting is required. Other settings can be absent.
3001 # In that case, we ignore errors raised during option deletion attempt.
3002 SetProperty('cc', 'CC_LIST', unset_error_ok=True)
3003 SetProperty('tree-status-url', 'STATUS', unset_error_ok=True)
3004 SetProperty('viewvc-url', 'VIEW_VC', unset_error_ok=True)
rmistry@google.com90752582014-01-14 21:04:50 +00003005 SetProperty('bug-prefix', 'BUG_PREFIX', unset_error_ok=True)
thestig@chromium.org44202a22014-03-11 19:22:18 +00003006 SetProperty('cpplint-regex', 'LINT_REGEX', unset_error_ok=True)
3007 SetProperty('cpplint-ignore-regex', 'LINT_IGNORE_REGEX', unset_error_ok=True)
rmistry@google.com5626a922015-02-26 14:03:30 +00003008 SetProperty('run-post-upload-hook', 'RUN_POST_UPLOAD_HOOK',
3009 unset_error_ok=True)
Jamie Madilldc4d19e2019-10-24 21:50:02 +00003010 SetProperty(
3011 'format-full-by-default', 'FORMAT_FULL_BY_DEFAULT', unset_error_ok=True)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003012
ukai@chromium.org7044efc2013-11-28 01:51:21 +00003013 if 'GERRIT_HOST' in keyvals:
ukai@chromium.orge8077812012-02-03 03:41:46 +00003014 RunGit(['config', 'gerrit.host', keyvals['GERRIT_HOST']])
ukai@chromium.orge8077812012-02-03 03:41:46 +00003015
bauerb@chromium.org54b400c2016-01-14 10:08:25 +00003016 if 'GERRIT_SQUASH_UPLOADS' in keyvals:
tandrii8dd81ea2016-06-16 13:24:23 -07003017 RunGit(['config', 'gerrit.squash-uploads',
3018 keyvals['GERRIT_SQUASH_UPLOADS']])
bauerb@chromium.org54b400c2016-01-14 10:08:25 +00003019
tandrii@chromium.org28253532016-04-14 13:46:56 +00003020 if 'GERRIT_SKIP_ENSURE_AUTHENTICATED' in keyvals:
shinyak@chromium.org00dbccd2016-04-15 07:24:43 +00003021 RunGit(['config', 'gerrit.skip-ensure-authenticated',
tandrii@chromium.org28253532016-04-14 13:46:56 +00003022 keyvals['GERRIT_SKIP_ENSURE_AUTHENTICATED']])
3023
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003024 if 'PUSH_URL_CONFIG' in keyvals and 'ORIGIN_URL_CONFIG' in keyvals:
Andrii Shyshkalov18975322017-01-25 16:44:13 +01003025 # should be of the form
3026 # PUSH_URL_CONFIG: url.ssh://gitrw.chromium.org.pushinsteadof
3027 # ORIGIN_URL_CONFIG: http://src.chromium.org/git
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003028 RunGit(['config', keyvals['PUSH_URL_CONFIG'],
3029 keyvals['ORIGIN_URL_CONFIG']])
3030
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003031
joshua.lock@intel.com426f69b2012-08-02 23:41:49 +00003032def urlretrieve(source, destination):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003033 """Downloads a network object to a local file, like urllib.urlretrieve.
3034
3035 This is necessary because urllib is broken for SSL connections via a proxy.
3036 """
joshua.lock@intel.com426f69b2012-08-02 23:41:49 +00003037 with open(destination, 'w') as f:
Edward Lemur79d4f992019-11-11 23:49:02 +00003038 f.write(urllib.request.urlopen(source).read())
joshua.lock@intel.com426f69b2012-08-02 23:41:49 +00003039
3040
ukai@chromium.org712d6102013-11-27 00:52:58 +00003041def hasSheBang(fname):
3042 """Checks fname is a #! script."""
3043 with open(fname) as f:
3044 return f.read(2).startswith('#!')
3045
3046
bpastene@chromium.org917f0ff2016-04-05 00:45:30 +00003047# TODO(bpastene) Remove once a cleaner fix to crbug.com/600473 presents itself.
3048def DownloadHooks(*args, **kwargs):
3049 pass
3050
3051
tandrii@chromium.org18630d62016-03-04 12:06:02 +00003052def DownloadGerritHook(force):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003053 """Downloads and installs a Gerrit commit-msg hook.
ukai@chromium.org78c4b982012-02-14 02:20:26 +00003054
3055 Args:
3056 force: True to update hooks. False to install hooks if not present.
3057 """
3058 if not settings.GetIsGerrit():
3059 return
ukai@chromium.org712d6102013-11-27 00:52:58 +00003060 src = 'https://gerrit-review.googlesource.com/tools/hooks/commit-msg'
ukai@chromium.org78c4b982012-02-14 02:20:26 +00003061 dst = os.path.join(settings.GetRoot(), '.git', 'hooks', 'commit-msg')
3062 if not os.access(dst, os.X_OK):
3063 if os.path.exists(dst):
3064 if not force:
3065 return
ukai@chromium.org78c4b982012-02-14 02:20:26 +00003066 try:
joshua.lock@intel.com426f69b2012-08-02 23:41:49 +00003067 urlretrieve(src, dst)
ukai@chromium.org712d6102013-11-27 00:52:58 +00003068 if not hasSheBang(dst):
3069 DieWithError('Not a script: %s\n'
3070 'You need to download from\n%s\n'
3071 'into .git/hooks/commit-msg and '
3072 'chmod +x .git/hooks/commit-msg' % (dst, src))
ukai@chromium.org78c4b982012-02-14 02:20:26 +00003073 os.chmod(dst, stat.S_IRUSR | stat.S_IWUSR | stat.S_IXUSR)
3074 except Exception:
3075 if os.path.exists(dst):
3076 os.remove(dst)
ukai@chromium.org712d6102013-11-27 00:52:58 +00003077 DieWithError('\nFailed to download hooks.\n'
3078 'You need to download from\n%s\n'
3079 'into .git/hooks/commit-msg and '
3080 'chmod +x .git/hooks/commit-msg' % src)
ukai@chromium.org78c4b982012-02-14 02:20:26 +00003081
3082
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003083class _GitCookiesChecker(object):
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003084 """Provides facilities for validating and suggesting fixes to .gitcookies."""
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003085
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003086 _GOOGLESOURCE = 'googlesource.com'
3087
3088 def __init__(self):
3089 # Cached list of [host, identity, source], where source is either
3090 # .gitcookies or .netrc.
3091 self._all_hosts = None
3092
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003093 def ensure_configured_gitcookies(self):
3094 """Runs checks and suggests fixes to make git use .gitcookies from default
3095 path."""
3096 default = gerrit_util.CookiesAuthenticator.get_gitcookies_path()
3097 configured_path = RunGitSilent(
3098 ['config', '--global', 'http.cookiefile']).strip()
Andrii Shyshkalov1e250cd2017-05-10 15:39:31 +02003099 configured_path = os.path.expanduser(configured_path)
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003100 if configured_path:
3101 self._ensure_default_gitcookies_path(configured_path, default)
3102 else:
3103 self._configure_gitcookies_path(default)
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003104
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003105 @staticmethod
3106 def _ensure_default_gitcookies_path(configured_path, default_path):
3107 assert configured_path
3108 if configured_path == default_path:
3109 print('git is already configured to use your .gitcookies from %s' %
3110 configured_path)
3111 return
3112
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003113 print('WARNING: You have configured custom path to .gitcookies: %s\n'
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003114 'Gerrit and other depot_tools expect .gitcookies at %s\n' %
3115 (configured_path, default_path))
3116
3117 if not os.path.exists(configured_path):
3118 print('However, your configured .gitcookies file is missing.')
3119 confirm_or_exit('Reconfigure git to use default .gitcookies?',
3120 action='reconfigure')
3121 RunGit(['config', '--global', 'http.cookiefile', default_path])
3122 return
3123
3124 if os.path.exists(default_path):
3125 print('WARNING: default .gitcookies file already exists %s' %
3126 default_path)
3127 DieWithError('Please delete %s manually and re-run git cl creds-check' %
3128 default_path)
3129
3130 confirm_or_exit('Move existing .gitcookies to default location?',
3131 action='move')
3132 shutil.move(configured_path, default_path)
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003133 RunGit(['config', '--global', 'http.cookiefile', default_path])
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003134 print('Moved and reconfigured git to use .gitcookies from %s' %
3135 default_path)
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003136
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003137 @staticmethod
3138 def _configure_gitcookies_path(default_path):
3139 netrc_path = gerrit_util.CookiesAuthenticator.get_netrc_path()
3140 if os.path.exists(netrc_path):
3141 print('You seem to be using outdated .netrc for git credentials: %s' %
3142 netrc_path)
3143 print('This tool will guide you through setting up recommended '
3144 '.gitcookies store for git credentials.\n'
3145 '\n'
3146 'IMPORTANT: If something goes wrong and you decide to go back, do:\n'
3147 ' git config --global --unset http.cookiefile\n'
3148 ' mv %s %s.backup\n\n' % (default_path, default_path))
3149 confirm_or_exit(action='setup .gitcookies')
3150 RunGit(['config', '--global', 'http.cookiefile', default_path])
3151 print('Configured git to use .gitcookies from %s' % default_path)
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003152
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003153 def get_hosts_with_creds(self, include_netrc=False):
3154 if self._all_hosts is None:
3155 a = gerrit_util.CookiesAuthenticator()
3156 self._all_hosts = [
3157 (h, u, s)
3158 for h, u, s in itertools.chain(
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00003159 ((h, u, '.netrc') for h, (u, _, _) in a.netrc.hosts.items()),
3160 ((h, u, '.gitcookies') for h, (u, _) in a.gitcookies.items())
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003161 )
3162 if h.endswith(self._GOOGLESOURCE)
3163 ]
3164
3165 if include_netrc:
3166 return self._all_hosts
3167 return [(h, u, s) for h, u, s in self._all_hosts if s != '.netrc']
3168
3169 def print_current_creds(self, include_netrc=False):
3170 hosts = sorted(self.get_hosts_with_creds(include_netrc=include_netrc))
3171 if not hosts:
3172 print('No Git/Gerrit credentials found')
3173 return
Edward Lemur79d4f992019-11-11 23:49:02 +00003174 lengths = [max(map(len, (row[i] for row in hosts))) for i in range(3)]
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003175 header = [('Host', 'User', 'Which file'),
3176 ['=' * l for l in lengths]]
3177 for row in (header + hosts):
3178 print('\t'.join((('%%+%ds' % l) % s)
3179 for l, s in zip(lengths, row)))
3180
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003181 @staticmethod
3182 def _parse_identity(identity):
Lei Zhangd3f769a2017-12-15 15:16:14 -08003183 """Parses identity "git-<username>.domain" into <username> and domain."""
3184 # Special case: usernames that contain ".", which are generally not
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +02003185 # distinguishable from sub-domains. But we do know typical domains:
3186 if identity.endswith('.chromium.org'):
3187 domain = 'chromium.org'
3188 username = identity[:-len('.chromium.org')]
3189 else:
3190 username, domain = identity.split('.', 1)
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003191 if username.startswith('git-'):
3192 username = username[len('git-'):]
3193 return username, domain
3194
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003195 def _canonical_git_googlesource_host(self, host):
3196 """Normalizes Gerrit hosts (with '-review') to Git host."""
3197 assert host.endswith(self._GOOGLESOURCE)
3198 # Prefix doesn't include '.' at the end.
3199 prefix = host[:-(1 + len(self._GOOGLESOURCE))]
3200 if prefix.endswith('-review'):
3201 prefix = prefix[:-len('-review')]
3202 return prefix + '.' + self._GOOGLESOURCE
3203
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003204 def _canonical_gerrit_googlesource_host(self, host):
3205 git_host = self._canonical_git_googlesource_host(host)
3206 prefix = git_host.split('.', 1)[0]
3207 return prefix + '-review.' + self._GOOGLESOURCE
3208
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003209 def _get_counterpart_host(self, host):
3210 assert host.endswith(self._GOOGLESOURCE)
3211 git = self._canonical_git_googlesource_host(host)
3212 gerrit = self._canonical_gerrit_googlesource_host(git)
3213 return git if gerrit == host else gerrit
3214
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003215 def has_generic_host(self):
3216 """Returns whether generic .googlesource.com has been configured.
3217
3218 Chrome Infra recommends to use explicit ${host}.googlesource.com instead.
3219 """
3220 for host, _, _ in self.get_hosts_with_creds(include_netrc=False):
3221 if host == '.' + self._GOOGLESOURCE:
3222 return True
3223 return False
3224
3225 def _get_git_gerrit_identity_pairs(self):
3226 """Returns map from canonic host to pair of identities (Git, Gerrit).
3227
3228 One of identities might be None, meaning not configured.
3229 """
3230 host_to_identity_pairs = {}
3231 for host, identity, _ in self.get_hosts_with_creds():
3232 canonical = self._canonical_git_googlesource_host(host)
3233 pair = host_to_identity_pairs.setdefault(canonical, [None, None])
3234 idx = 0 if canonical == host else 1
3235 pair[idx] = identity
3236 return host_to_identity_pairs
3237
3238 def get_partially_configured_hosts(self):
3239 return set(
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003240 (host if i1 else self._canonical_gerrit_googlesource_host(host))
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00003241 for host, (i1, i2) in self._get_git_gerrit_identity_pairs().items()
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003242 if None in (i1, i2) and host != '.' + self._GOOGLESOURCE)
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003243
3244 def get_conflicting_hosts(self):
3245 return set(
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003246 host
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00003247 for host, (i1, i2) in self._get_git_gerrit_identity_pairs().items()
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003248 if None not in (i1, i2) and i1 != i2)
3249
3250 def get_duplicated_hosts(self):
3251 counters = collections.Counter(h for h, _, _ in self.get_hosts_with_creds())
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00003252 return set(host for host, count in counters.items() if count > 1)
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003253
3254 _EXPECTED_HOST_IDENTITY_DOMAINS = {
3255 'chromium.googlesource.com': 'chromium.org',
3256 'chrome-internal.googlesource.com': 'google.com',
3257 }
3258
3259 def get_hosts_with_wrong_identities(self):
3260 """Finds hosts which **likely** reference wrong identities.
3261
3262 Note: skips hosts which have conflicting identities for Git and Gerrit.
3263 """
3264 hosts = set()
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00003265 for host, expected in self._EXPECTED_HOST_IDENTITY_DOMAINS.items():
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003266 pair = self._get_git_gerrit_identity_pairs().get(host)
3267 if pair and pair[0] == pair[1]:
3268 _, domain = self._parse_identity(pair[0])
3269 if domain != expected:
3270 hosts.add(host)
3271 return hosts
3272
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003273 @staticmethod
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003274 def _format_hosts(hosts, extra_column_func=None):
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003275 hosts = sorted(hosts)
3276 assert hosts
3277 if extra_column_func is None:
3278 extras = [''] * len(hosts)
3279 else:
3280 extras = [extra_column_func(host) for host in hosts]
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003281 tmpl = '%%-%ds %%-%ds' % (max(map(len, hosts)), max(map(len, extras)))
3282 lines = []
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003283 for he in zip(hosts, extras):
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003284 lines.append(tmpl % he)
3285 return lines
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003286
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003287 def _find_problems(self):
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003288 if self.has_generic_host():
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003289 yield ('.googlesource.com wildcard record detected',
3290 ['Chrome Infrastructure team recommends to list full host names '
3291 'explicitly.'],
3292 None)
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003293
3294 dups = self.get_duplicated_hosts()
3295 if dups:
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003296 yield ('The following hosts were defined twice',
3297 self._format_hosts(dups),
3298 None)
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003299
3300 partial = self.get_partially_configured_hosts()
3301 if partial:
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003302 yield ('Credentials should come in pairs for Git and Gerrit hosts. '
3303 'These hosts are missing',
3304 self._format_hosts(partial, lambda host: 'but %s defined' %
3305 self._get_counterpart_host(host)),
3306 partial)
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003307
3308 conflicting = self.get_conflicting_hosts()
3309 if conflicting:
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003310 yield ('The following Git hosts have differing credentials from their '
3311 'Gerrit counterparts',
3312 self._format_hosts(conflicting, lambda host: '%s vs %s' %
3313 tuple(self._get_git_gerrit_identity_pairs()[host])),
3314 conflicting)
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003315
3316 wrong = self.get_hosts_with_wrong_identities()
3317 if wrong:
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003318 yield ('These hosts likely use wrong identity',
3319 self._format_hosts(wrong, lambda host: '%s but %s recommended' %
3320 (self._get_git_gerrit_identity_pairs()[host][0],
3321 self._EXPECTED_HOST_IDENTITY_DOMAINS[host])),
3322 wrong)
3323
3324 def find_and_report_problems(self):
3325 """Returns True if there was at least one problem, else False."""
3326 found = False
3327 bad_hosts = set()
3328 for title, sublines, hosts in self._find_problems():
3329 if not found:
3330 found = True
3331 print('\n\n.gitcookies problem report:\n')
3332 bad_hosts.update(hosts or [])
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003333 print(' %s%s' % (title, (':' if sublines else '')))
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003334 if sublines:
3335 print()
3336 print(' %s' % '\n '.join(sublines))
3337 print()
3338
3339 if bad_hosts:
3340 assert found
3341 print(' You can manually remove corresponding lines in your %s file and '
3342 'visit the following URLs with correct account to generate '
3343 'correct credential lines:\n' %
3344 gerrit_util.CookiesAuthenticator.get_gitcookies_path())
3345 print(' %s' % '\n '.join(sorted(set(
3346 gerrit_util.CookiesAuthenticator().get_new_password_url(
3347 self._canonical_git_googlesource_host(host))
3348 for host in bad_hosts
3349 ))))
3350 return found
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003351
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003352
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003353@metrics.collector.collect_metrics('git cl creds-check')
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003354def CMDcreds_check(parser, args):
3355 """Checks credentials and suggests changes."""
3356 _, _ = parser.parse_args(args)
3357
Vadim Shtayurab250ec12018-10-04 00:21:08 +00003358 # Code below checks .gitcookies. Abort if using something else.
3359 authn = gerrit_util.Authenticator.get()
3360 if not isinstance(authn, gerrit_util.CookiesAuthenticator):
3361 if isinstance(authn, gerrit_util.GceAuthenticator):
3362 DieWithError(
3363 'This command is not designed for GCE, are you on a bot?\n'
3364 'If you need to run this on GCE, export SKIP_GCE_AUTH_FOR_GIT=1 '
3365 'in your env.')
Aaron Gabled10ca0e2017-09-11 11:24:10 -07003366 DieWithError(
Vadim Shtayurab250ec12018-10-04 00:21:08 +00003367 'This command is not designed for bot environment. It checks '
3368 '~/.gitcookies file not generally used on bots.')
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003369
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003370 checker = _GitCookiesChecker()
3371 checker.ensure_configured_gitcookies()
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003372
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003373 print('Your .netrc and .gitcookies have credentials for these hosts:')
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003374 checker.print_current_creds(include_netrc=True)
3375
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003376 if not checker.find_and_report_problems():
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003377 print('\nNo problems detected in your .gitcookies file.')
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003378 return 0
3379 return 1
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003380
3381
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003382@metrics.collector.collect_metrics('git cl baseurl')
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00003383def CMDbaseurl(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00003384 """Gets or sets base-url for this branch."""
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00003385 branchref = RunGit(['symbolic-ref', 'HEAD']).strip()
Edward Lemur85153282020-02-14 22:06:29 +00003386 branch = scm.GIT.ShortBranchName(branchref)
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00003387 _, args = parser.parse_args(args)
3388 if not args:
vapiera7fbd5a2016-06-16 09:17:49 -07003389 print('Current base-url:')
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00003390 return RunGit(['config', 'branch.%s.base-url' % branch],
3391 error_ok=False).strip()
3392 else:
vapiera7fbd5a2016-06-16 09:17:49 -07003393 print('Setting base-url to %s' % args[0])
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00003394 return RunGit(['config', 'branch.%s.base-url' % branch, args[0]],
3395 error_ok=False).strip()
3396
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003397
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00003398def color_for_status(status):
3399 """Maps a Changelist status to color, for CMDstatus and other tools."""
3400 return {
Aaron Gable9ab38c62017-04-06 14:36:33 -07003401 'unsent': Fore.YELLOW,
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00003402 'waiting': Fore.BLUE,
3403 'reply': Fore.YELLOW,
Aaron Gable9ab38c62017-04-06 14:36:33 -07003404 'not lgtm': Fore.RED,
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00003405 'lgtm': Fore.GREEN,
3406 'commit': Fore.MAGENTA,
3407 'closed': Fore.CYAN,
3408 'error': Fore.WHITE,
3409 }.get(status, Fore.WHITE)
3410
tandrii@chromium.org04ea8462016-04-25 19:51:21 +00003411
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003412def get_cl_statuses(changes, fine_grained, max_processes=None):
3413 """Returns a blocking iterable of (cl, status) for given branches.
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00003414
3415 If fine_grained is true, this will fetch CL statuses from the server.
3416 Otherwise, simply indicate if there's a matching url for the given branches.
3417
3418 If max_processes is specified, it is used as the maximum number of processes
3419 to spawn to fetch CL status from the server. Otherwise 1 process per branch is
3420 spawned.
calamity@chromium.orgcf197482016-04-29 20:15:53 +00003421
3422 See GetStatus() for a list of possible statuses.
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00003423 """
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01003424 if not changes:
3425 raise StopIteration()
calamity@chromium.orgcf197482016-04-29 20:15:53 +00003426
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01003427 if not fine_grained:
3428 # Fast path which doesn't involve querying codereview servers.
Aaron Gablea1bab272017-04-11 16:38:18 -07003429 # Do not use get_approving_reviewers(), since it requires an HTTP request.
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003430 for cl in changes:
3431 yield (cl, 'waiting' if cl.GetIssueURL() else 'error')
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01003432 return
3433
3434 # First, sort out authentication issues.
3435 logging.debug('ensuring credentials exist')
3436 for cl in changes:
3437 cl.EnsureAuthenticated(force=False, refresh=True)
3438
3439 def fetch(cl):
3440 try:
3441 return (cl, cl.GetStatus())
3442 except:
3443 # See http://crbug.com/629863.
Andrii Shyshkalov98824232018-04-19 11:37:15 -07003444 logging.exception('failed to fetch status for cl %s:', cl.GetIssue())
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01003445 raise
3446
3447 threads_count = len(changes)
3448 if max_processes:
3449 threads_count = max(1, min(threads_count, max_processes))
3450 logging.debug('querying %d CLs using %d threads', len(changes), threads_count)
3451
3452 pool = ThreadPool(threads_count)
3453 fetched_cls = set()
3454 try:
3455 it = pool.imap_unordered(fetch, changes).__iter__()
3456 while True:
3457 try:
3458 cl, status = it.next(timeout=5)
3459 except multiprocessing.TimeoutError:
3460 break
3461 fetched_cls.add(cl)
3462 yield cl, status
3463 finally:
3464 pool.close()
3465
3466 # Add any branches that failed to fetch.
3467 for cl in set(changes) - fetched_cls:
3468 yield (cl, 'error')
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00003469
rmistry@google.com2dd99862015-06-22 12:22:18 +00003470
3471def upload_branch_deps(cl, args):
3472 """Uploads CLs of local branches that are dependents of the current branch.
3473
3474 If the local branch dependency tree looks like:
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003475
3476 test1 -> test2.1 -> test3.1
3477 -> test3.2
3478 -> test2.2 -> test3.3
rmistry@google.com2dd99862015-06-22 12:22:18 +00003479
3480 and you run "git cl upload --dependencies" from test1 then "git cl upload" is
3481 run on the dependent branches in this order:
3482 test2.1, test3.1, test3.2, test2.2, test3.3
3483
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003484 Note: This function does not rebase your local dependent branches. Use it
3485 when you make a change to the parent branch that will not conflict
3486 with its dependent branches, and you would like their dependencies
3487 updated in Rietveld.
rmistry@google.com2dd99862015-06-22 12:22:18 +00003488 """
3489 if git_common.is_dirty_git_tree('upload-branch-deps'):
3490 return 1
3491
3492 root_branch = cl.GetBranch()
3493 if root_branch is None:
3494 DieWithError('Can\'t find dependent branches from detached HEAD state. '
3495 'Get on a branch!')
Andrii Shyshkalov9f274432018-10-15 16:40:23 +00003496 if not cl.GetIssue():
rmistry@google.com2dd99862015-06-22 12:22:18 +00003497 DieWithError('Current branch does not have an uploaded CL. We cannot set '
3498 'patchset dependencies without an uploaded CL.')
3499
3500 branches = RunGit(['for-each-ref',
3501 '--format=%(refname:short) %(upstream:short)',
3502 'refs/heads'])
3503 if not branches:
3504 print('No local branches found.')
3505 return 0
3506
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003507 # Create a dictionary of all local branches to the branches that are
3508 # dependent on it.
rmistry@google.com2dd99862015-06-22 12:22:18 +00003509 tracked_to_dependents = collections.defaultdict(list)
3510 for b in branches.splitlines():
3511 tokens = b.split()
3512 if len(tokens) == 2:
3513 branch_name, tracked = tokens
3514 tracked_to_dependents[tracked].append(branch_name)
3515
vapiera7fbd5a2016-06-16 09:17:49 -07003516 print()
3517 print('The dependent local branches of %s are:' % root_branch)
rmistry@google.com2dd99862015-06-22 12:22:18 +00003518 dependents = []
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003519
rmistry@google.com2dd99862015-06-22 12:22:18 +00003520 def traverse_dependents_preorder(branch, padding=''):
3521 dependents_to_process = tracked_to_dependents.get(branch, [])
3522 padding += ' '
3523 for dependent in dependents_to_process:
vapiera7fbd5a2016-06-16 09:17:49 -07003524 print('%s%s' % (padding, dependent))
rmistry@google.com2dd99862015-06-22 12:22:18 +00003525 dependents.append(dependent)
3526 traverse_dependents_preorder(dependent, padding)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003527
rmistry@google.com2dd99862015-06-22 12:22:18 +00003528 traverse_dependents_preorder(root_branch)
vapiera7fbd5a2016-06-16 09:17:49 -07003529 print()
rmistry@google.com2dd99862015-06-22 12:22:18 +00003530
3531 if not dependents:
vapiera7fbd5a2016-06-16 09:17:49 -07003532 print('There are no dependent local branches for %s' % root_branch)
rmistry@google.com2dd99862015-06-22 12:22:18 +00003533 return 0
3534
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01003535 confirm_or_exit('This command will checkout all dependent branches and run '
3536 '"git cl upload".', action='continue')
rmistry@google.com2dd99862015-06-22 12:22:18 +00003537
rmistry@google.com2dd99862015-06-22 12:22:18 +00003538 # Record all dependents that failed to upload.
3539 failures = {}
3540 # Go through all dependents, checkout the branch and upload.
3541 try:
3542 for dependent_branch in dependents:
vapiera7fbd5a2016-06-16 09:17:49 -07003543 print()
3544 print('--------------------------------------')
3545 print('Running "git cl upload" from %s:' % dependent_branch)
rmistry@google.com2dd99862015-06-22 12:22:18 +00003546 RunGit(['checkout', '-q', dependent_branch])
vapiera7fbd5a2016-06-16 09:17:49 -07003547 print()
rmistry@google.com2dd99862015-06-22 12:22:18 +00003548 try:
3549 if CMDupload(OptionParser(), args) != 0:
vapiera7fbd5a2016-06-16 09:17:49 -07003550 print('Upload failed for %s!' % dependent_branch)
rmistry@google.com2dd99862015-06-22 12:22:18 +00003551 failures[dependent_branch] = 1
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -08003552 except: # pylint: disable=bare-except
rmistry@google.com2dd99862015-06-22 12:22:18 +00003553 failures[dependent_branch] = 1
vapiera7fbd5a2016-06-16 09:17:49 -07003554 print()
rmistry@google.com2dd99862015-06-22 12:22:18 +00003555 finally:
3556 # Swap back to the original root branch.
3557 RunGit(['checkout', '-q', root_branch])
3558
vapiera7fbd5a2016-06-16 09:17:49 -07003559 print()
3560 print('Upload complete for dependent branches!')
rmistry@google.com2dd99862015-06-22 12:22:18 +00003561 for dependent_branch in dependents:
3562 upload_status = 'failed' if failures.get(dependent_branch) else 'succeeded'
vapiera7fbd5a2016-06-16 09:17:49 -07003563 print(' %s : %s' % (dependent_branch, upload_status))
3564 print()
rmistry@google.com2dd99862015-06-22 12:22:18 +00003565
3566 return 0
3567
3568
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00003569def GetArchiveTagForBranch(issue_num, branch_name, existing_tags):
3570 """Given a proposed tag name, returns a tag name that is guaranteed to be
3571 unique. If 'foo' is proposed but already exists, then 'foo-2' is used,
3572 or 'foo-3', and so on."""
3573
3574 proposed_tag = 'git-cl-archived-%s-%s' % (issue_num, branch_name)
3575 for suffix_num in itertools.count(1):
3576 if suffix_num == 1:
3577 to_check = proposed_tag
3578 else:
3579 to_check = '%s-%d' % (proposed_tag, suffix_num)
3580
3581 if to_check not in existing_tags:
3582 return to_check
3583
3584
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003585@metrics.collector.collect_metrics('git cl archive')
kmarshall3bff56b2016-06-06 18:31:47 -07003586def CMDarchive(parser, args):
3587 """Archives and deletes branches associated with closed changelists."""
3588 parser.add_option(
3589 '-j', '--maxjobs', action='store', type=int,
kmarshall9249e012016-08-23 12:02:16 -07003590 help='The maximum number of jobs to use when retrieving review status.')
kmarshall3bff56b2016-06-06 18:31:47 -07003591 parser.add_option(
3592 '-f', '--force', action='store_true',
3593 help='Bypasses the confirmation prompt.')
kmarshall9249e012016-08-23 12:02:16 -07003594 parser.add_option(
3595 '-d', '--dry-run', action='store_true',
3596 help='Skip the branch tagging and removal steps.')
3597 parser.add_option(
3598 '-t', '--notags', action='store_true',
3599 help='Do not tag archived branches. '
3600 'Note: local commit history may be lost.')
kmarshall3bff56b2016-06-06 18:31:47 -07003601
kmarshall3bff56b2016-06-06 18:31:47 -07003602 options, args = parser.parse_args(args)
3603 if args:
3604 parser.error('Unsupported args: %s' % ' '.join(args))
kmarshall3bff56b2016-06-06 18:31:47 -07003605
3606 branches = RunGit(['for-each-ref', '--format=%(refname)', 'refs/heads'])
3607 if not branches:
3608 return 0
3609
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00003610 tags = RunGit(['for-each-ref', '--format=%(refname)',
3611 'refs/tags']).splitlines() or []
3612 tags = [t.split('/')[-1] for t in tags]
3613
vapiera7fbd5a2016-06-16 09:17:49 -07003614 print('Finding all branches associated with closed issues...')
Edward Lemur934836a2019-09-09 20:16:54 +00003615 changes = [Changelist(branchref=b)
3616 for b in branches.splitlines()]
kmarshall3bff56b2016-06-06 18:31:47 -07003617 alignment = max(5, max(len(c.GetBranch()) for c in changes))
3618 statuses = get_cl_statuses(changes,
3619 fine_grained=True,
3620 max_processes=options.maxjobs)
3621 proposal = [(cl.GetBranch(),
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00003622 GetArchiveTagForBranch(cl.GetIssue(), cl.GetBranch(),
3623 tags))
kmarshall3bff56b2016-06-06 18:31:47 -07003624 for cl, status in statuses
Andrii Shyshkalov51bdf8c2018-10-18 01:07:58 +00003625 if status in ('closed', 'rietveld-not-supported')]
kmarshall3bff56b2016-06-06 18:31:47 -07003626 proposal.sort()
3627
3628 if not proposal:
vapiera7fbd5a2016-06-16 09:17:49 -07003629 print('No branches with closed codereview issues found.')
kmarshall3bff56b2016-06-06 18:31:47 -07003630 return 0
3631
Edward Lemur85153282020-02-14 22:06:29 +00003632 current_branch = scm.GIT.GetBranch(settings.GetRoot())
kmarshall3bff56b2016-06-06 18:31:47 -07003633
vapiera7fbd5a2016-06-16 09:17:49 -07003634 print('\nBranches with closed issues that will be archived:\n')
kmarshall9249e012016-08-23 12:02:16 -07003635 if options.notags:
3636 for next_item in proposal:
3637 print(' ' + next_item[0])
3638 else:
3639 print('%*s | %s' % (alignment, 'Branch name', 'Archival tag name'))
3640 for next_item in proposal:
3641 print('%*s %s' % (alignment, next_item[0], next_item[1]))
kmarshall3bff56b2016-06-06 18:31:47 -07003642
kmarshall9249e012016-08-23 12:02:16 -07003643 # Quit now on precondition failure or if instructed by the user, either
3644 # via an interactive prompt or by command line flags.
3645 if options.dry_run:
3646 print('\nNo changes were made (dry run).\n')
3647 return 0
3648 elif any(branch == current_branch for branch, _ in proposal):
kmarshall3bff56b2016-06-06 18:31:47 -07003649 print('You are currently on a branch \'%s\' which is associated with a '
3650 'closed codereview issue, so archive cannot proceed. Please '
3651 'checkout another branch and run this command again.' %
3652 current_branch)
3653 return 1
kmarshall9249e012016-08-23 12:02:16 -07003654 elif not options.force:
sergiyb4a5ecbe2016-06-20 09:46:00 -07003655 answer = ask_for_data('\nProceed with deletion (Y/n)? ').lower()
3656 if answer not in ('y', ''):
vapiera7fbd5a2016-06-16 09:17:49 -07003657 print('Aborted.')
kmarshall3bff56b2016-06-06 18:31:47 -07003658 return 1
3659
3660 for branch, tagname in proposal:
kmarshall9249e012016-08-23 12:02:16 -07003661 if not options.notags:
3662 RunGit(['tag', tagname, branch])
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00003663
3664 if RunGitWithCode(['branch', '-D', branch])[0] != 0:
3665 # Clean up the tag if we failed to delete the branch.
3666 RunGit(['tag', '-d', tagname])
kmarshall9249e012016-08-23 12:02:16 -07003667
vapiera7fbd5a2016-06-16 09:17:49 -07003668 print('\nJob\'s done!')
kmarshall3bff56b2016-06-06 18:31:47 -07003669
3670 return 0
3671
3672
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003673@metrics.collector.collect_metrics('git cl status')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003674def CMDstatus(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00003675 """Show status of changelists.
3676
3677 Colors are used to tell the state of the CL unless --fast is used:
jsbell@chromium.orgaeab41a2013-12-10 20:01:22 +00003678 - Blue waiting for review
Aaron Gable9ab38c62017-04-06 14:36:33 -07003679 - Yellow waiting for you to reply to review, or not yet sent
jsbell@chromium.orgaeab41a2013-12-10 20:01:22 +00003680 - Green LGTM'ed
Aaron Gable9ab38c62017-04-06 14:36:33 -07003681 - Red 'not LGTM'ed
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +00003682 - Magenta in the CQ
jsbell@chromium.orgaeab41a2013-12-10 20:01:22 +00003683 - Cyan was committed, branch can be deleted
Aaron Gable9ab38c62017-04-06 14:36:33 -07003684 - White error, or unknown status
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00003685
3686 Also see 'git cl comments'.
3687 """
Alan Cuttera3be9a52019-03-04 18:50:33 +00003688 parser.add_option(
3689 '--no-branch-color',
3690 action='store_true',
3691 help='Disable colorized branch names')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003692 parser.add_option('--field',
phajdan.jr289d03e2016-08-16 08:21:06 -07003693 help='print only specific field (desc|id|patch|status|url)')
maruel@chromium.org1033efd2013-07-23 23:25:09 +00003694 parser.add_option('-f', '--fast', action='store_true',
3695 help='Do not retrieve review status')
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00003696 parser.add_option(
3697 '-j', '--maxjobs', action='store', type=int,
3698 help='The maximum number of jobs to use when retrieving review status')
Edward Lemur52969c92020-02-06 18:15:28 +00003699 parser.add_option(
3700 '-i', '--issue', type=int,
3701 help='Operate on this issue instead of the current branch\'s implicit '
3702 'issue. Requires --field to be set.')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00003703 options, args = parser.parse_args(args)
maruel@chromium.org39c0b222013-08-17 16:57:01 +00003704 if args:
3705 parser.error('Unsupported args: %s' % args)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003706
iannuccie53c9352016-08-17 14:40:40 -07003707 if options.issue is not None and not options.field:
Edward Lemur6c6827c2020-02-06 21:15:18 +00003708 parser.error('--field must be given when --issue is set.')
iannucci3c972b92016-08-17 13:24:10 -07003709
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003710 if options.field:
Edward Lemur934836a2019-09-09 20:16:54 +00003711 cl = Changelist(issue=options.issue)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003712 if options.field.startswith('desc'):
Edward Lemur6c6827c2020-02-06 21:15:18 +00003713 if cl.GetIssue():
3714 print(cl.FetchDescription())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003715 elif options.field == 'id':
3716 issueid = cl.GetIssue()
3717 if issueid:
vapiera7fbd5a2016-06-16 09:17:49 -07003718 print(issueid)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003719 elif options.field == 'patch':
Aaron Gablee8856ee2017-12-07 12:41:46 -08003720 patchset = cl.GetMostRecentPatchset()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003721 if patchset:
vapiera7fbd5a2016-06-16 09:17:49 -07003722 print(patchset)
phajdan.jr289d03e2016-08-16 08:21:06 -07003723 elif options.field == 'status':
3724 print(cl.GetStatus())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003725 elif options.field == 'url':
3726 url = cl.GetIssueURL()
3727 if url:
vapiera7fbd5a2016-06-16 09:17:49 -07003728 print(url)
maruel@chromium.orge25c75b2013-07-23 18:30:56 +00003729 return 0
3730
3731 branches = RunGit(['for-each-ref', '--format=%(refname)', 'refs/heads'])
3732 if not branches:
3733 print('No local branch found.')
3734 return 0
3735
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003736 changes = [
Edward Lemur934836a2019-09-09 20:16:54 +00003737 Changelist(branchref=b)
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003738 for b in branches.splitlines()]
vapiera7fbd5a2016-06-16 09:17:49 -07003739 print('Branches associated with reviews:')
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003740 output = get_cl_statuses(changes,
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00003741 fine_grained=not options.fast,
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003742 max_processes=options.maxjobs)
maruel@chromium.org1033efd2013-07-23 23:25:09 +00003743
Edward Lemur85153282020-02-14 22:06:29 +00003744 current_branch = scm.GIT.GetBranch(settings.GetRoot())
Daniel McArdlea23bf592019-02-12 00:25:12 +00003745
3746 def FormatBranchName(branch, colorize=False):
3747 """Simulates 'git branch' behavior. Colorizes and prefixes branch name with
3748 an asterisk when it is the current branch."""
3749
3750 asterisk = ""
3751 color = Fore.RESET
3752 if branch == current_branch:
3753 asterisk = "* "
3754 color = Fore.GREEN
Edward Lemur85153282020-02-14 22:06:29 +00003755 branch_name = scm.GIT.ShortBranchName(branch)
Daniel McArdlea23bf592019-02-12 00:25:12 +00003756
3757 if colorize:
3758 return asterisk + color + branch_name + Fore.RESET
Daniel McArdle452a49f2019-02-14 17:28:31 +00003759 return asterisk + branch_name
3760
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00003761 branch_statuses = {}
Daniel McArdlea23bf592019-02-12 00:25:12 +00003762
3763 alignment = max(5, max(len(FormatBranchName(c.GetBranch())) for c in changes))
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003764 for cl in sorted(changes, key=lambda c: c.GetBranch()):
3765 branch = cl.GetBranch()
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00003766 while branch not in branch_statuses:
Edward Lemur79d4f992019-11-11 23:49:02 +00003767 c, status = next(output)
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003768 branch_statuses[c.GetBranch()] = status
3769 status = branch_statuses.pop(branch)
3770 url = cl.GetIssueURL()
3771 if url and (not status or status == 'error'):
3772 # The issue probably doesn't exist anymore.
3773 url += ' (broken)'
3774
nodir@chromium.orga6de1f42015-06-10 04:23:17 +00003775 color = color_for_status(status)
maruel@chromium.org885f6512013-07-27 02:17:26 +00003776 reset = Fore.RESET
iannucci@chromium.org596cd5c2016-04-04 21:34:39 +00003777 if not setup_color.IS_TTY:
maruel@chromium.org885f6512013-07-27 02:17:26 +00003778 color = ''
3779 reset = ''
nodir@chromium.orga6de1f42015-06-10 04:23:17 +00003780 status_str = '(%s)' % status if status else ''
Daniel McArdle452a49f2019-02-14 17:28:31 +00003781
Alan Cuttera3be9a52019-03-04 18:50:33 +00003782 branch_display = FormatBranchName(branch)
3783 padding = ' ' * (alignment - len(branch_display))
3784 if not options.no_branch_color:
3785 branch_display = FormatBranchName(branch, colorize=True)
Daniel McArdle452a49f2019-02-14 17:28:31 +00003786
Alan Cuttera3be9a52019-03-04 18:50:33 +00003787 print(' %s : %s%s %s%s' % (padding + branch_display, color, url,
3788 status_str, reset))
Andrii Shyshkalovd0e1d9d2017-01-24 17:10:51 +01003789
vapiera7fbd5a2016-06-16 09:17:49 -07003790 print()
Daniel McArdlea23bf592019-02-12 00:25:12 +00003791 print('Current branch: %s' % current_branch)
Andrii Shyshkalovd0e1d9d2017-01-24 17:10:51 +01003792 for cl in changes:
Daniel McArdlea23bf592019-02-12 00:25:12 +00003793 if cl.GetBranch() == current_branch:
Andrii Shyshkalovd0e1d9d2017-01-24 17:10:51 +01003794 break
dpranke@chromium.orgee87f582015-07-31 18:46:25 +00003795 if not cl.GetIssue():
vapiera7fbd5a2016-06-16 09:17:49 -07003796 print('No issue assigned.')
dpranke@chromium.orgee87f582015-07-31 18:46:25 +00003797 return 0
vapiera7fbd5a2016-06-16 09:17:49 -07003798 print('Issue number: %s (%s)' % (cl.GetIssue(), cl.GetIssueURL()))
maruel@chromium.org85616e02014-07-28 15:37:55 +00003799 if not options.fast:
vapiera7fbd5a2016-06-16 09:17:49 -07003800 print('Issue description:')
Edward Lemur6c6827c2020-02-06 21:15:18 +00003801 print(cl.FetchDescription(pretty=True))
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003802 return 0
3803
3804
maruel@chromium.org39c0b222013-08-17 16:57:01 +00003805def colorize_CMDstatus_doc():
3806 """To be called once in main() to add colors to git cl status help."""
3807 colors = [i for i in dir(Fore) if i[0].isupper()]
3808
3809 def colorize_line(line):
3810 for color in colors:
3811 if color in line.upper():
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003812 # Extract whitespace first and the leading '-'.
maruel@chromium.org39c0b222013-08-17 16:57:01 +00003813 indent = len(line) - len(line.lstrip(' ')) + 1
3814 return line[:indent] + getattr(Fore, color) + line[indent:] + Fore.RESET
3815 return line
3816
3817 lines = CMDstatus.__doc__.splitlines()
3818 CMDstatus.__doc__ = '\n'.join(colorize_line(l) for l in lines)
3819
3820
phajdan.jre328cf92016-08-22 04:12:17 -07003821def write_json(path, contents):
Stefan Zager1306bd02017-06-22 19:26:46 -07003822 if path == '-':
3823 json.dump(contents, sys.stdout)
3824 else:
3825 with open(path, 'w') as f:
3826 json.dump(contents, f)
phajdan.jre328cf92016-08-22 04:12:17 -07003827
3828
maruel@chromium.org0633fb42013-08-16 20:06:14 +00003829@subcommand.usage('[issue_number]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003830@metrics.collector.collect_metrics('git cl issue')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003831def CMDissue(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00003832 """Sets or displays the current code review issue number.
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003833
3834 Pass issue number 0 to clear the current issue.
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00003835 """
dnj@chromium.org406c4402015-03-03 17:22:28 +00003836 parser.add_option('-r', '--reverse', action='store_true',
3837 help='Lookup the branch(es) for the specified issues. If '
3838 'no issues are specified, all branches with mapped '
3839 'issues will be listed.')
Stefan Zager1306bd02017-06-22 19:26:46 -07003840 parser.add_option('--json',
3841 help='Path to JSON output file, or "-" for stdout.')
dnj@chromium.org406c4402015-03-03 17:22:28 +00003842 options, args = parser.parse_args(args)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003843
dnj@chromium.org406c4402015-03-03 17:22:28 +00003844 if options.reverse:
3845 branches = RunGit(['for-each-ref', 'refs/heads',
Aaron Gablead64abd2017-12-04 09:49:13 -08003846 '--format=%(refname)']).splitlines()
dnj@chromium.org406c4402015-03-03 17:22:28 +00003847 # Reverse issue lookup.
3848 issue_branch_map = {}
Daniel Bratellb56a43a2018-09-06 15:49:03 +00003849
3850 git_config = {}
3851 for config in RunGit(['config', '--get-regexp',
3852 r'branch\..*issue']).splitlines():
3853 name, _space, val = config.partition(' ')
3854 git_config[name] = val
3855
dnj@chromium.org406c4402015-03-03 17:22:28 +00003856 for branch in branches:
Edward Lemur85153282020-02-14 22:06:29 +00003857 config_key = _git_branch_config_key(scm.GIT.ShortBranchName(branch),
Edward Lemur52969c92020-02-06 18:15:28 +00003858 Changelist.IssueConfigKey())
3859 issue = git_config.get(config_key)
3860 if issue:
3861 issue_branch_map.setdefault(int(issue), []).append(branch)
dnj@chromium.org406c4402015-03-03 17:22:28 +00003862 if not args:
3863 args = sorted(issue_branch_map.iterkeys())
phajdan.jre328cf92016-08-22 04:12:17 -07003864 result = {}
dnj@chromium.org406c4402015-03-03 17:22:28 +00003865 for issue in args:
Lei Zhang5a368d42019-03-25 23:18:19 +00003866 try:
3867 issue_num = int(issue)
3868 except ValueError:
3869 print('ERROR cannot parse issue number: %s' % issue, file=sys.stderr)
dnj@chromium.org406c4402015-03-03 17:22:28 +00003870 continue
Lei Zhang5a368d42019-03-25 23:18:19 +00003871 result[issue_num] = issue_branch_map.get(issue_num)
vapiera7fbd5a2016-06-16 09:17:49 -07003872 print('Branch for issue number %s: %s' % (
Lei Zhang5a368d42019-03-25 23:18:19 +00003873 issue, ', '.join(issue_branch_map.get(issue_num) or ('None',))))
phajdan.jre328cf92016-08-22 04:12:17 -07003874 if options.json:
3875 write_json(options.json, result)
Aaron Gable78753da2017-06-15 10:35:49 -07003876 return 0
3877
3878 if len(args) > 0:
Edward Lemurf38bc172019-09-03 21:02:13 +00003879 issue = ParseIssueNumberArgument(args[0])
Aaron Gable78753da2017-06-15 10:35:49 -07003880 if not issue.valid:
3881 DieWithError('Pass a url or number to set the issue, 0 to unset it, '
3882 'or no argument to list it.\n'
3883 'Maybe you want to run git cl status?')
Edward Lemurf38bc172019-09-03 21:02:13 +00003884 cl = Changelist()
Aaron Gable78753da2017-06-15 10:35:49 -07003885 cl.SetIssue(issue.issue)
dnj@chromium.org406c4402015-03-03 17:22:28 +00003886 else:
Edward Lemurf38bc172019-09-03 21:02:13 +00003887 cl = Changelist()
Aaron Gable78753da2017-06-15 10:35:49 -07003888 print('Issue number: %s (%s)' % (cl.GetIssue(), cl.GetIssueURL()))
3889 if options.json:
3890 write_json(options.json, {
3891 'issue': cl.GetIssue(),
3892 'issue_url': cl.GetIssueURL(),
3893 })
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003894 return 0
3895
3896
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003897@metrics.collector.collect_metrics('git cl comments')
maruel@chromium.org9977a2e2012-06-06 22:30:56 +00003898def CMDcomments(parser, args):
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003899 """Shows or posts review comments for any changelist."""
3900 parser.add_option('-a', '--add-comment', dest='comment',
3901 help='comment to add to an issue')
Sergiy Byelozyorovcb629a42018-10-28 19:20:39 +00003902 parser.add_option('-p', '--publish', action='store_true',
3903 help='marks CL as ready and sends comment to reviewers')
Andrii Shyshkalov0d6b46e2017-03-17 22:23:22 +01003904 parser.add_option('-i', '--issue', dest='issue',
Edward Lemurf38bc172019-09-03 21:02:13 +00003905 help='review issue id (defaults to current issue).')
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07003906 parser.add_option('-m', '--machine-readable', dest='readable',
3907 action='store_false', default=True,
3908 help='output comments in a format compatible with '
3909 'editor parsing')
smut@google.comc85ac942015-09-15 16:34:43 +00003910 parser.add_option('-j', '--json-file',
Stefan Zager1306bd02017-06-22 19:26:46 -07003911 help='File to write JSON summary to, or "-" for stdout')
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003912 options, args = parser.parse_args(args)
maruel@chromium.org9977a2e2012-06-06 22:30:56 +00003913
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003914 issue = None
3915 if options.issue:
3916 try:
3917 issue = int(options.issue)
3918 except ValueError:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00003919 DieWithError('A review issue ID is expected to be a number.')
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003920
Edward Lemur934836a2019-09-09 20:16:54 +00003921 cl = Changelist(issue=issue)
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003922
3923 if options.comment:
Sergiy Byelozyorovcb629a42018-10-28 19:20:39 +00003924 cl.AddComment(options.comment, options.publish)
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003925 return 0
3926
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07003927 summary = sorted(cl.GetCommentsSummary(readable=options.readable),
3928 key=lambda c: c.date)
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01003929 for comment in summary:
3930 if comment.disapproval:
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003931 color = Fore.RED
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01003932 elif comment.approval:
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003933 color = Fore.GREEN
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01003934 elif comment.sender == cl.GetIssueOwner():
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003935 color = Fore.MAGENTA
Quinten Yearsley0e617c02019-02-20 00:37:03 +00003936 elif comment.autogenerated:
3937 color = Fore.CYAN
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003938 else:
3939 color = Fore.BLUE
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01003940 print('\n%s%s %s%s\n%s' % (
3941 color,
3942 comment.date.strftime('%Y-%m-%d %H:%M:%S UTC'),
3943 comment.sender,
3944 Fore.RESET,
3945 '\n'.join(' ' + l for l in comment.message.strip().splitlines())))
3946
smut@google.comc85ac942015-09-15 16:34:43 +00003947 if options.json_file:
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01003948 def pre_serialize(c):
Edward Lemur79d4f992019-11-11 23:49:02 +00003949 dct = c._asdict().copy()
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01003950 dct['date'] = dct['date'].strftime('%Y-%m-%d %H:%M:%S.%f')
3951 return dct
Edward Lemur79d4f992019-11-11 23:49:02 +00003952 write_json(options.json_file, [pre_serialize(x) for x in summary])
maruel@chromium.org9977a2e2012-06-06 22:30:56 +00003953 return 0
3954
3955
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00003956@subcommand.usage('[codereview url or issue id]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003957@metrics.collector.collect_metrics('git cl description')
rsesek@chromium.orgeec76592013-05-20 16:27:57 +00003958def CMDdescription(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00003959 """Brings up the editor for the current CL's description."""
smut@google.com34fb6b12015-07-13 20:03:26 +00003960 parser.add_option('-d', '--display', action='store_true',
3961 help='Display the description instead of opening an editor')
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00003962 parser.add_option('-n', '--new-description',
dnjba1b0f32016-09-02 12:37:42 -07003963 help='New description to set for this issue (- for stdin, '
3964 '+ to load from local commit HEAD)')
dsansomee2d6fd92016-09-08 00:10:47 -07003965 parser.add_option('-f', '--force', action='store_true',
3966 help='Delete any unpublished Gerrit edits for this issue '
3967 'without prompting')
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00003968
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00003969 options, args = parser.parse_args(args)
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00003970
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01003971 target_issue_arg = None
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00003972 if len(args) > 0:
Edward Lemurf38bc172019-09-03 21:02:13 +00003973 target_issue_arg = ParseIssueNumberArgument(args[0])
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01003974 if not target_issue_arg.valid:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00003975 parser.error('Invalid issue ID or URL.')
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00003976
Edward Lemur934836a2019-09-09 20:16:54 +00003977 kwargs = {}
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01003978 if target_issue_arg:
3979 kwargs['issue'] = target_issue_arg.issue
3980 kwargs['codereview_host'] = target_issue_arg.hostname
martiniss6eda05f2016-06-30 10:18:35 -07003981
3982 cl = Changelist(**kwargs)
rsesek@chromium.orgeec76592013-05-20 16:27:57 +00003983 if not cl.GetIssue():
3984 DieWithError('This branch has no associated changelist.')
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02003985
Edward Lemur678a6842019-10-03 22:25:05 +00003986 if args and not args[0].isdigit():
Edward Lemurf38bc172019-09-03 21:02:13 +00003987 logging.info('canonical issue/change URL: %s\n', cl.GetIssueURL())
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02003988
Edward Lemur6c6827c2020-02-06 21:15:18 +00003989 description = ChangeDescription(cl.FetchDescription())
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00003990
smut@google.com34fb6b12015-07-13 20:03:26 +00003991 if options.display:
vapiera7fbd5a2016-06-16 09:17:49 -07003992 print(description.description)
smut@google.com34fb6b12015-07-13 20:03:26 +00003993 return 0
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00003994
3995 if options.new_description:
3996 text = options.new_description
3997 if text == '-':
3998 text = '\n'.join(l.rstrip() for l in sys.stdin)
dnjba1b0f32016-09-02 12:37:42 -07003999 elif text == '+':
4000 base_branch = cl.GetCommonAncestorWithUpstream()
Edward Lemur7f6dec02020-02-06 20:23:58 +00004001 text = cl.GetLocalDescription(base_branch)
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00004002
4003 description.set_description(text)
4004 else:
Edward Lemurf38bc172019-09-03 21:02:13 +00004005 description.prompt()
Edward Lemur6c6827c2020-02-06 21:15:18 +00004006 if cl.FetchDescription().strip() != description.description:
dsansomee2d6fd92016-09-08 00:10:47 -07004007 cl.UpdateDescription(description.description, force=options.force)
rsesek@chromium.orgeec76592013-05-20 16:27:57 +00004008 return 0
4009
4010
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004011@metrics.collector.collect_metrics('git cl lint')
thestig@chromium.org44202a22014-03-11 19:22:18 +00004012def CMDlint(parser, args):
4013 """Runs cpplint on the current changelist."""
tzik@chromium.orgf204d4b2014-03-13 07:40:55 +00004014 parser.add_option('--filter', action='append', metavar='-x,+y',
4015 help='Comma-separated list of cpplint\'s category-filters')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004016 options, args = parser.parse_args(args)
thestig@chromium.org44202a22014-03-11 19:22:18 +00004017
4018 # Access to a protected member _XX of a client class
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -08004019 # pylint: disable=protected-access
thestig@chromium.org44202a22014-03-11 19:22:18 +00004020 try:
4021 import cpplint
4022 import cpplint_chromium
4023 except ImportError:
vapiera7fbd5a2016-06-16 09:17:49 -07004024 print('Your depot_tools is missing cpplint.py and/or cpplint_chromium.py.')
thestig@chromium.org44202a22014-03-11 19:22:18 +00004025 return 1
4026
4027 # Change the current working directory before calling lint so that it
4028 # shows the correct base.
4029 previous_cwd = os.getcwd()
4030 os.chdir(settings.GetRoot())
4031 try:
Edward Lemur934836a2019-09-09 20:16:54 +00004032 cl = Changelist()
Edward Lemur7f6dec02020-02-06 20:23:58 +00004033 change = cl.GetChange(cl.GetCommonAncestorWithUpstream())
thestig@chromium.org44202a22014-03-11 19:22:18 +00004034 files = [f.LocalPath() for f in change.AffectedFiles()]
thestig@chromium.org5839eb52014-05-30 16:20:51 +00004035 if not files:
vapiera7fbd5a2016-06-16 09:17:49 -07004036 print('Cannot lint an empty CL')
thestig@chromium.org5839eb52014-05-30 16:20:51 +00004037 return 1
thestig@chromium.org44202a22014-03-11 19:22:18 +00004038
4039 # Process cpplints arguments if any.
tzik@chromium.orgf204d4b2014-03-13 07:40:55 +00004040 command = args + files
4041 if options.filter:
4042 command = ['--filter=' + ','.join(options.filter)] + command
4043 filenames = cpplint.ParseArguments(command)
thestig@chromium.org44202a22014-03-11 19:22:18 +00004044
4045 white_regex = re.compile(settings.GetLintRegex())
4046 black_regex = re.compile(settings.GetLintIgnoreRegex())
4047 extra_check_functions = [cpplint_chromium.CheckPointerDeclarationWhitespace]
4048 for filename in filenames:
4049 if white_regex.match(filename):
4050 if black_regex.match(filename):
vapiera7fbd5a2016-06-16 09:17:49 -07004051 print('Ignoring file %s' % filename)
thestig@chromium.org44202a22014-03-11 19:22:18 +00004052 else:
4053 cpplint.ProcessFile(filename, cpplint._cpplint_state.verbose_level,
4054 extra_check_functions)
4055 else:
vapiera7fbd5a2016-06-16 09:17:49 -07004056 print('Skipping file %s' % filename)
thestig@chromium.org44202a22014-03-11 19:22:18 +00004057 finally:
4058 os.chdir(previous_cwd)
vapiera7fbd5a2016-06-16 09:17:49 -07004059 print('Total errors found: %d\n' % cpplint._cpplint_state.error_count)
thestig@chromium.org44202a22014-03-11 19:22:18 +00004060 if cpplint._cpplint_state.error_count != 0:
4061 return 1
4062 return 0
4063
4064
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004065@metrics.collector.collect_metrics('git cl presubmit')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004066def CMDpresubmit(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004067 """Runs presubmit tests on the current changelist."""
ilevy@chromium.org375a9022013-01-07 01:12:05 +00004068 parser.add_option('-u', '--upload', action='store_true',
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004069 help='Run upload hook instead of the push hook')
ilevy@chromium.org375a9022013-01-07 01:12:05 +00004070 parser.add_option('-f', '--force', action='store_true',
sbc@chromium.org495ad152012-09-04 23:07:42 +00004071 help='Run checks even if tree is dirty')
Aaron Gable8076c282017-11-29 14:39:41 -08004072 parser.add_option('--all', action='store_true',
4073 help='Run checks against all files, not just modified ones')
Edward Lesmes8e282792018-04-03 18:50:29 -04004074 parser.add_option('--parallel', action='store_true',
4075 help='Run all tests specified by input_api.RunTests in all '
4076 'PRESUBMIT files in parallel.')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004077 options, args = parser.parse_args(args)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004078
sbc@chromium.org71437c02015-04-09 19:29:40 +00004079 if not options.force and git_common.is_dirty_git_tree('presubmit'):
vapiera7fbd5a2016-06-16 09:17:49 -07004080 print('use --force to check even if tree is dirty.')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004081 return 1
4082
Edward Lemur934836a2019-09-09 20:16:54 +00004083 cl = Changelist()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004084 if args:
4085 base_branch = args[0]
4086 else:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00004087 # Default to diffing against the common ancestor of the upstream branch.
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00004088 base_branch = cl.GetCommonAncestorWithUpstream()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004089
Aaron Gable8076c282017-11-29 14:39:41 -08004090 if options.all:
Edward Lemur7f6dec02020-02-06 20:23:58 +00004091 base_change = cl.GetChange(base_branch)
Aaron Gable8076c282017-11-29 14:39:41 -08004092 files = [('M', f) for f in base_change.AllFiles()]
4093 change = presubmit_support.GitChange(
4094 base_change.Name(),
4095 base_change.FullDescriptionText(),
4096 base_change.RepositoryRoot(),
4097 files,
4098 base_change.issue,
4099 base_change.patchset,
4100 base_change.author_email,
4101 base_change._upstream)
4102 else:
Edward Lemur7f6dec02020-02-06 20:23:58 +00004103 change = cl.GetChange(base_branch)
Aaron Gable8076c282017-11-29 14:39:41 -08004104
ilevy@chromium.org051ad0e2013-03-04 21:57:34 +00004105 cl.RunHook(
4106 committing=not options.upload,
4107 may_prompt=False,
4108 verbose=options.verbose,
Edward Lesmes8e282792018-04-03 18:50:29 -04004109 change=change,
4110 parallel=options.parallel)
dpranke@chromium.org0a2bb372011-03-25 01:16:22 +00004111 return 0
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004112
4113
tandrii@chromium.org65874e12016-03-04 12:03:02 +00004114def GenerateGerritChangeId(message):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004115 """Returns the Change ID footer value (Ixxxxxx...xxx).
tandrii@chromium.org65874e12016-03-04 12:03:02 +00004116
4117 Works the same way as
4118 https://gerrit-review.googlesource.com/tools/hooks/commit-msg
4119 but can be called on demand on all platforms.
4120
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004121 The basic idea is to generate git hash of a state of the tree, original
4122 commit message, author/committer info and timestamps.
tandrii@chromium.org65874e12016-03-04 12:03:02 +00004123 """
4124 lines = []
4125 tree_hash = RunGitSilent(['write-tree'])
4126 lines.append('tree %s' % tree_hash.strip())
4127 code, parent = RunGitWithCode(['rev-parse', 'HEAD~0'], suppress_stderr=False)
4128 if code == 0:
4129 lines.append('parent %s' % parent.strip())
4130 author = RunGitSilent(['var', 'GIT_AUTHOR_IDENT'])
4131 lines.append('author %s' % author.strip())
4132 committer = RunGitSilent(['var', 'GIT_COMMITTER_IDENT'])
4133 lines.append('committer %s' % committer.strip())
4134 lines.append('')
4135 # Note: Gerrit's commit-hook actually cleans message of some lines and
4136 # whitespace. This code is not doing this, but it clearly won't decrease
4137 # entropy.
4138 lines.append(message)
4139 change_hash = RunCommand(['git', 'hash-object', '-t', 'commit', '--stdin'],
Raul Tambreb946b232019-03-26 14:48:46 +00004140 stdin=('\n'.join(lines)).encode())
tandrii@chromium.org65874e12016-03-04 12:03:02 +00004141 return 'I%s' % change_hash.strip()
4142
4143
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01004144def GetTargetRef(remote, remote_branch, target_branch):
wittman@chromium.org455dc922015-01-26 20:15:50 +00004145 """Computes the remote branch ref to use for the CL.
4146
4147 Args:
4148 remote (str): The git remote for the CL.
4149 remote_branch (str): The git remote branch for the CL.
4150 target_branch (str): The target branch specified by the user.
wittman@chromium.org455dc922015-01-26 20:15:50 +00004151 """
4152 if not (remote and remote_branch):
4153 return None
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00004154
wittman@chromium.org455dc922015-01-26 20:15:50 +00004155 if target_branch:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07004156 # Canonicalize branch references to the equivalent local full symbolic
wittman@chromium.org455dc922015-01-26 20:15:50 +00004157 # refs, which are then translated into the remote full symbolic refs
4158 # below.
4159 if '/' not in target_branch:
4160 remote_branch = 'refs/remotes/%s/%s' % (remote, target_branch)
4161 else:
4162 prefix_replacements = (
4163 ('^((refs/)?remotes/)?branch-heads/', 'refs/remotes/branch-heads/'),
4164 ('^((refs/)?remotes/)?%s/' % remote, 'refs/remotes/%s/' % remote),
4165 ('^(refs/)?heads/', 'refs/remotes/%s/' % remote),
4166 )
4167 match = None
4168 for regex, replacement in prefix_replacements:
4169 match = re.search(regex, target_branch)
4170 if match:
4171 remote_branch = target_branch.replace(match.group(0), replacement)
4172 break
4173 if not match:
4174 # This is a branch path but not one we recognize; use as-is.
4175 remote_branch = target_branch
rmistry@google.comc68112d2015-03-03 12:48:06 +00004176 elif remote_branch in REFS_THAT_ALIAS_TO_OTHER_REFS:
4177 # Handle the refs that need to land in different refs.
4178 remote_branch = REFS_THAT_ALIAS_TO_OTHER_REFS[remote_branch]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00004179
wittman@chromium.org455dc922015-01-26 20:15:50 +00004180 # Create the true path to the remote branch.
4181 # Does the following translation:
4182 # * refs/remotes/origin/refs/diff/test -> refs/diff/test
4183 # * refs/remotes/origin/master -> refs/heads/master
4184 # * refs/remotes/branch-heads/test -> refs/branch-heads/test
4185 if remote_branch.startswith('refs/remotes/%s/refs/' % remote):
4186 remote_branch = remote_branch.replace('refs/remotes/%s/' % remote, '')
4187 elif remote_branch.startswith('refs/remotes/%s/' % remote):
4188 remote_branch = remote_branch.replace('refs/remotes/%s/' % remote,
4189 'refs/heads/')
4190 elif remote_branch.startswith('refs/remotes/branch-heads'):
4191 remote_branch = remote_branch.replace('refs/remotes/', 'refs/')
Andrii Shyshkalov768f1d82016-12-08 15:10:13 +01004192
wittman@chromium.org455dc922015-01-26 20:15:50 +00004193 return remote_branch
4194
4195
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00004196def cleanup_list(l):
4197 """Fixes a list so that comma separated items are put as individual items.
4198
4199 So that "--reviewers joe@c,john@c --reviewers joa@c" results in
4200 options.reviewers == sorted(['joe@c', 'john@c', 'joa@c']).
4201 """
4202 items = sum((i.split(',') for i in l), [])
4203 stripped_items = (i.strip() for i in items)
4204 return sorted(filter(None, stripped_items))
4205
4206
Aaron Gable4db38df2017-11-03 14:59:07 -07004207@subcommand.usage('[flags]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004208@metrics.collector.collect_metrics('git cl upload')
ukai@chromium.orge8077812012-02-03 03:41:46 +00004209def CMDupload(parser, args):
rmistry@google.com78948ed2015-07-08 23:09:57 +00004210 """Uploads the current changelist to codereview.
4211
4212 Can skip dependency patchset uploads for a branch by running:
4213 git config branch.branch_name.skip-deps-uploads True
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004214 To unset, run:
rmistry@google.com78948ed2015-07-08 23:09:57 +00004215 git config --unset branch.branch_name.skip-deps-uploads
4216 Can also set the above globally by using the --global flag.
Dominic Battre7d1c4842017-10-27 09:17:28 +02004217
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004218 If the name of the checked out branch starts with "bug-" or "fix-" followed
4219 by a bug number, this bug number is automatically populated in the CL
Dominic Battre7d1c4842017-10-27 09:17:28 +02004220 description.
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004221
4222 If subject contains text in square brackets or has "<text>: " prefix, such
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004223 text(s) is treated as Gerrit hashtags. For example, CLs with subjects:
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004224 [git-cl] add support for hashtags
4225 Foo bar: implement foo
4226 will be hashtagged with "git-cl" and "foo-bar" respectively.
rmistry@google.com78948ed2015-07-08 23:09:57 +00004227 """
ukai@chromium.orge8077812012-02-03 03:41:46 +00004228 parser.add_option('--bypass-hooks', action='store_true', dest='bypass_hooks',
4229 help='bypass upload presubmit hook')
brettw@chromium.orgb65c43c2013-06-10 22:04:49 +00004230 parser.add_option('--bypass-watchlists', action='store_true',
4231 dest='bypass_watchlists',
4232 help='bypass watchlists auto CC-ing reviewers')
Aaron Gablef7543cd2017-07-20 14:26:31 -07004233 parser.add_option('-f', '--force', action='store_true', dest='force',
ukai@chromium.orge8077812012-02-03 03:41:46 +00004234 help="force yes to questions (don't prompt)")
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004235 parser.add_option('--message', '-m', dest='message',
4236 help='message for patchset')
tandriif9aefb72016-07-01 09:06:51 -07004237 parser.add_option('-b', '--bug',
4238 help='pre-populate the bug number(s) for this issue. '
4239 'If several, separate with commas')
tandriib80458a2016-06-23 12:20:07 -07004240 parser.add_option('--message-file', dest='message_file',
4241 help='file which contains message for patchset')
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004242 parser.add_option('--title', '-t', dest='title',
4243 help='title for patchset')
ukai@chromium.orge8077812012-02-03 03:41:46 +00004244 parser.add_option('-r', '--reviewers',
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00004245 action='append', default=[],
ukai@chromium.orge8077812012-02-03 03:41:46 +00004246 help='reviewer email addresses')
Robert Iannucci6c98dc62017-04-18 11:38:00 -07004247 parser.add_option('--tbrs',
4248 action='append', default=[],
4249 help='TBR email addresses')
ukai@chromium.orge8077812012-02-03 03:41:46 +00004250 parser.add_option('--cc',
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00004251 action='append', default=[],
ukai@chromium.orge8077812012-02-03 03:41:46 +00004252 help='cc email addresses')
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004253 parser.add_option('--hashtag', dest='hashtags',
4254 action='append', default=[],
4255 help=('Gerrit hashtag for new CL; '
4256 'can be applied multiple times'))
adamk@chromium.org36f47302013-04-05 01:08:31 +00004257 parser.add_option('-s', '--send-mail', action='store_true',
Aaron Gable59f48512017-01-12 10:54:46 -08004258 help='send email to reviewer(s) and cc(s) immediately')
ukai@chromium.org8ef7ab22012-11-28 04:24:52 +00004259 parser.add_option('--target_branch',
pgervais@chromium.orgb9f27512014-08-08 15:52:33 +00004260 '--target-branch',
wittman@chromium.org455dc922015-01-26 20:15:50 +00004261 metavar='TARGET',
4262 help='Apply CL to remote ref TARGET. ' +
4263 'Default: remote branch head, or master')
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00004264 parser.add_option('--squash', action='store_true',
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004265 help='Squash multiple commits into one')
Mike Frysingera989d552019-08-14 20:51:23 +00004266 parser.add_option('--no-squash', action='store_false', dest='squash',
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004267 help='Don\'t squash multiple commits into one')
rmistry9eadede2016-09-19 11:22:43 -07004268 parser.add_option('--topic', default=None,
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004269 help='Topic to specify when uploading')
Robert Iannuccif2708bd2017-04-17 15:49:02 -07004270 parser.add_option('--tbr-owners', dest='add_owners_to', action='store_const',
4271 const='TBR', help='add a set of OWNERS to TBR')
4272 parser.add_option('--r-owners', dest='add_owners_to', action='store_const',
4273 const='R', help='add a set of OWNERS to R')
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +00004274 parser.add_option('-c', '--use-commit-queue', action='store_true',
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004275 default=False,
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +00004276 help='tell the CQ to commit this patchset; '
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004277 'implies --send-mail')
4278 parser.add_option('-d', '--cq-dry-run',
4279 action='store_true', default=False,
rmistry@google.comef966222015-04-07 11:15:01 +00004280 help='Send the patchset to do a CQ dry run right after '
4281 'upload.')
Andrii Shyshkalov71f0da32019-07-15 22:45:18 +00004282 parser.add_option('--preserve-tryjobs', action='store_true',
4283 help='instruct the CQ to let tryjobs running even after '
4284 'new patchsets are uploaded instead of canceling '
4285 'prior patchset\' tryjobs')
rmistry@google.com2dd99862015-06-22 12:22:18 +00004286 parser.add_option('--dependencies', action='store_true',
4287 help='Uploads CLs of all the local branches that depend on '
4288 'the current branch')
Ravi Mistry31e7d562018-04-02 12:53:57 -04004289 parser.add_option('-a', '--enable-auto-submit', action='store_true',
4290 help='Sends your change to the CQ after an approval. Only '
4291 'works on repos that have the Auto-Submit label '
4292 'enabled')
Edward Lesmes8e282792018-04-03 18:50:29 -04004293 parser.add_option('--parallel', action='store_true',
4294 help='Run all tests specified by input_api.RunTests in all '
4295 'PRESUBMIT files in parallel.')
Sergiy Byelozyorov1aa405f2018-09-18 17:38:43 +00004296 parser.add_option('--no-autocc', action='store_true',
4297 help='Disables automatic addition of CC emails')
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004298 parser.add_option('--private', action='store_true',
Sergiy Byelozyorov1aa405f2018-09-18 17:38:43 +00004299 help='Set the review private. This implies --no-autocc.')
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004300 parser.add_option('-R', '--retry-failed', action='store_true',
4301 help='Retry failed tryjobs from old patchset immediately '
4302 'after uploading new patchset. Cannot be used with '
4303 '--use-commit-queue or --cq-dry-run.')
4304 parser.add_option('--buildbucket-host', default='cr-buildbucket.appspot.com',
4305 help='Host of buildbucket. The default host is %default.')
Dan Beamd8b04ca2019-10-10 21:23:26 +00004306 parser.add_option('--fixed', '-x',
4307 help='List of bugs that will be commented on and marked '
4308 'fixed (pre-populates "Fixed:" tag). Same format as '
4309 '-b option / "Bug:" tag. If fixing several issues, '
4310 'separate with commas.')
Josipe827b0f2020-01-30 00:07:20 +00004311 parser.add_option('--edit-description', action='store_true', default=False,
4312 help='Modify description before upload. Cannot be used '
4313 'with --force. It is a noop when --no-squash is set '
4314 'or a new commit is created.')
Sergiy Byelozyorov1aa405f2018-09-18 17:38:43 +00004315
rmistry@google.com2dd99862015-06-22 12:22:18 +00004316 orig_args = args
ukai@chromium.orge8077812012-02-03 03:41:46 +00004317 (options, args) = parser.parse_args(args)
4318
sbc@chromium.org71437c02015-04-09 19:29:40 +00004319 if git_common.is_dirty_git_tree('upload'):
ukai@chromium.orge8077812012-02-03 03:41:46 +00004320 return 1
4321
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00004322 options.reviewers = cleanup_list(options.reviewers)
Robert Iannucci6c98dc62017-04-18 11:38:00 -07004323 options.tbrs = cleanup_list(options.tbrs)
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00004324 options.cc = cleanup_list(options.cc)
4325
Josipe827b0f2020-01-30 00:07:20 +00004326 if options.edit_description and options.force:
4327 parser.error('Only one of --force and --edit-description allowed')
4328
tandriib80458a2016-06-23 12:20:07 -07004329 if options.message_file:
4330 if options.message:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004331 parser.error('Only one of --message and --message-file allowed.')
tandriib80458a2016-06-23 12:20:07 -07004332 options.message = gclient_utils.FileRead(options.message_file)
4333 options.message_file = None
4334
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004335 if ([options.cq_dry_run,
4336 options.use_commit_queue,
4337 options.retry_failed].count(True) > 1):
4338 parser.error('Only one of --use-commit-queue, --cq-dry-run, or '
4339 '--retry-failed is allowed.')
tandrii4d0545a2016-07-06 03:56:49 -07004340
Aaron Gableedbc4132017-09-11 13:22:28 -07004341 if options.use_commit_queue:
4342 options.send_mail = True
4343
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00004344 # For sanity of test expectations, do this otherwise lazy-loading *now*.
4345 settings.GetIsGerrit()
4346
Edward Lemur934836a2019-09-09 20:16:54 +00004347 cl = Changelist()
Edward Lesmes7677e5c2020-02-19 20:39:03 +00004348 # Warm change details cache now to avoid RPCs later, reducing latency for
4349 # developers.
4350 if cl.GetIssue():
4351 cl._GetChangeDetail(
4352 ['DETAILED_ACCOUNTS', 'CURRENT_REVISION', 'CURRENT_COMMIT', 'LABELS'])
4353
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004354 if options.retry_failed and not cl.GetIssue():
4355 print('No previous patchsets, so --retry-failed has no effect.')
4356 options.retry_failed = False
Edward Lesmes7677e5c2020-02-19 20:39:03 +00004357
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004358 # cl.GetMostRecentPatchset uses cached information, and can return the last
4359 # patchset before upload. Calling it here makes it clear that it's the
4360 # last patchset before upload. Note that GetMostRecentPatchset will fail
4361 # if no CL has been uploaded yet.
4362 if options.retry_failed:
4363 patchset = cl.GetMostRecentPatchset()
Andrii Shyshkalov9f274432018-10-15 16:40:23 +00004364
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004365 ret = cl.CMDUpload(options, args, orig_args)
4366
4367 if options.retry_failed:
4368 if ret != 0:
4369 print('Upload failed, so --retry-failed has no effect.')
4370 return ret
Andrii Shyshkalov1ad58112019-10-08 01:46:14 +00004371 builds, _ = _fetch_latest_builds(
Edward Lemur5b929a42019-10-21 17:57:39 +00004372 cl, options.buildbucket_host, latest_patchset=patchset)
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00004373 buckets = _filter_failed_for_retry(builds)
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004374 if len(buckets) == 0:
4375 print('No failed tryjobs, so --retry-failed has no effect.')
4376 return ret
Edward Lemur5b929a42019-10-21 17:57:39 +00004377 _trigger_try_jobs(cl, buckets, options, patchset + 1)
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004378
4379 return ret
ukai@chromium.orge8077812012-02-03 03:41:46 +00004380
4381
Francois Dorayd42c6812017-05-30 15:10:20 -04004382@subcommand.usage('--description=<description file>')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004383@metrics.collector.collect_metrics('git cl split')
Francois Dorayd42c6812017-05-30 15:10:20 -04004384def CMDsplit(parser, args):
4385 """Splits a branch into smaller branches and uploads CLs.
4386
4387 Creates a branch and uploads a CL for each group of files modified in the
4388 current branch that share a common OWNERS file. In the CL description and
Yannic Bonenberger68409632020-01-23 18:29:01 +00004389 comment, '$directory' is replaced with the directory containing the changes
4390 in this CL, '$cl_index' is replaced with the index of the CL we're currently
4391 sending out, and '$num_cls' is replaced with the total number of CLs that
4392 we're sending out in this split.
Francois Dorayd42c6812017-05-30 15:10:20 -04004393 """
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004394 parser.add_option('-d', '--description', dest='description_file',
4395 help='A text file containing a CL description in which '
4396 '$directory will be replaced by each CL\'s directory.')
4397 parser.add_option('-c', '--comment', dest='comment_file',
4398 help='A text file containing a CL comment.')
4399 parser.add_option('-n', '--dry-run', dest='dry_run', action='store_true',
Chris Watkinsba28e462017-12-13 11:22:17 +11004400 default=False,
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004401 help='List the files and reviewers for each CL that would '
4402 'be created, but don\'t create branches or CLs.')
4403 parser.add_option('--cq-dry-run', action='store_true',
4404 help='If set, will do a cq dry run for each uploaded CL. '
4405 'Please be careful when doing this; more than ~10 CLs '
4406 'has the potential to overload our build '
4407 'infrastructure. Try to upload these not during high '
4408 'load times (usually 11-3 Mountain View time). Email '
4409 'infra-dev@chromium.org with any questions.')
Takuto Ikuta51eca592019-02-14 19:40:52 +00004410 parser.add_option('-a', '--enable-auto-submit', action='store_true',
4411 default=True,
4412 help='Sends your change to the CQ after an approval. Only '
4413 'works on repos that have the Auto-Submit label '
4414 'enabled')
Francois Dorayd42c6812017-05-30 15:10:20 -04004415 options, _ = parser.parse_args(args)
4416
4417 if not options.description_file:
4418 parser.error('No --description flag specified.')
4419
4420 def WrappedCMDupload(args):
4421 return CMDupload(OptionParser(), args)
4422
4423 return split_cl.SplitCl(options.description_file, options.comment_file,
Stephen Martiniscb326682018-08-29 21:06:30 +00004424 Changelist, WrappedCMDupload, options.dry_run,
Takuto Ikuta51eca592019-02-14 19:40:52 +00004425 options.cq_dry_run, options.enable_auto_submit)
Francois Dorayd42c6812017-05-30 15:10:20 -04004426
4427
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004428@subcommand.usage('DEPRECATED')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004429@metrics.collector.collect_metrics('git cl commit')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004430def CMDdcommit(parser, args):
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004431 """DEPRECATED: Used to commit the current changelist via git-svn."""
4432 message = ('git-cl no longer supports committing to SVN repositories via '
4433 'git-svn. You probably want to use `git cl land` instead.')
4434 print(message)
4435 return 1
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004436
4437
maruel@chromium.org0633fb42013-08-16 20:06:14 +00004438@subcommand.usage('[upstream branch to apply against]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004439@metrics.collector.collect_metrics('git cl land')
pgervais@chromium.orgcee6dc42014-05-07 17:04:03 +00004440def CMDland(parser, args):
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004441 """Commits the current changelist via git.
4442
4443 In case of Gerrit, uses Gerrit REST api to "submit" the issue, which pushes
4444 upstream and closes the issue automatically and atomically.
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004445 """
4446 parser.add_option('--bypass-hooks', action='store_true', dest='bypass_hooks',
4447 help='bypass upload presubmit hook')
Aaron Gablef7543cd2017-07-20 14:26:31 -07004448 parser.add_option('-f', '--force', action='store_true', dest='force',
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004449 help="force yes to questions (don't prompt)")
Edward Lesmes67b3faa2018-04-13 17:50:52 -04004450 parser.add_option('--parallel', action='store_true',
4451 help='Run all tests specified by input_api.RunTests in all '
4452 'PRESUBMIT files in parallel.')
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004453 (options, args) = parser.parse_args(args)
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004454
Edward Lemur934836a2019-09-09 20:16:54 +00004455 cl = Changelist()
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004456
Robert Iannucci2e73d432018-03-14 01:10:47 -07004457 if not cl.GetIssue():
4458 DieWithError('You must upload the change first to Gerrit.\n'
4459 ' If you would rather have `git cl land` upload '
4460 'automatically for you, see http://crbug.com/642759')
Edward Lemur125d60a2019-09-13 18:25:41 +00004461 return cl.CMDLand(options.force, options.bypass_hooks,
Olivier Robin75ee7252018-04-13 10:02:56 +02004462 options.verbose, options.parallel)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004463
4464
dsinclair@chromium.orgfbed6562015-09-25 21:22:36 +00004465@subcommand.usage('<patch url or issue id or issue url>')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004466@metrics.collector.collect_metrics('git cl patch')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004467def CMDpatch(parser, args):
marq@chromium.orge5e59002013-10-02 23:21:25 +00004468 """Patches in a code review."""
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004469 parser.add_option('-b', dest='newbranch',
4470 help='create a new branch off trunk for the patch')
qsr@chromium.org1ef44af2013-10-16 16:24:32 +00004471 parser.add_option('-f', '--force', action='store_true',
Aaron Gable62619a32017-06-16 08:22:09 -07004472 help='overwrite state on the current or chosen branch')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004473 parser.add_option('-n', '--no-commit', action='store_true', dest='nocommit',
Edward Lemurf38bc172019-09-03 21:02:13 +00004474 help='don\'t commit after patch applies.')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004475
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00004476 group = optparse.OptionGroup(
4477 parser,
4478 'Options for continuing work on the current issue uploaded from a '
4479 'different clone (e.g. different machine). Must be used independently '
4480 'from the other options. No issue number should be specified, and the '
4481 'branch must have an issue number associated with it')
4482 group.add_option('--reapply', action='store_true', dest='reapply',
4483 help='Reset the branch and reapply the issue.\n'
4484 'CAUTION: This will undo any local changes in this '
4485 'branch')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004486
4487 group.add_option('--pull', action='store_true', dest='pull',
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00004488 help='Performs a pull before reapplying.')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004489 parser.add_option_group(group)
4490
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004491 (options, args) = parser.parse_args(args)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004492
Andrii Shyshkalov18975322017-01-25 16:44:13 +01004493 if options.reapply:
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004494 if options.newbranch:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004495 parser.error('--reapply works on the current branch only.')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004496 if len(args) > 0:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004497 parser.error('--reapply implies no additional arguments.')
dsinclair@chromium.orgfbed6562015-09-25 21:22:36 +00004498
Edward Lemur934836a2019-09-09 20:16:54 +00004499 cl = Changelist()
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004500 if not cl.GetIssue():
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004501 parser.error('Current branch must have an associated issue.')
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004502
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004503 upstream = cl.GetUpstreamBranch()
Andrii Shyshkalov18975322017-01-25 16:44:13 +01004504 if upstream is None:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004505 parser.error('No upstream branch specified. Cannot reset branch.')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004506
4507 RunGit(['reset', '--hard', upstream])
4508 if options.pull:
4509 RunGit(['pull'])
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004510
Edward Lemur678a6842019-10-03 22:25:05 +00004511 target_issue_arg = ParseIssueNumberArgument(cl.GetIssue())
4512 return cl.CMDPatchWithParsedIssue(target_issue_arg, options.nocommit, False)
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004513
4514 if len(args) != 1 or not args[0]:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004515 parser.error('Must specify issue number or URL.')
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004516
Edward Lemurf38bc172019-09-03 21:02:13 +00004517 target_issue_arg = ParseIssueNumberArgument(args[0])
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004518 if not target_issue_arg.valid:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004519 parser.error('Invalid issue ID or URL.')
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004520
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004521 # We don't want uncommitted changes mixed up with the patch.
4522 if git_common.is_dirty_git_tree('patch'):
dsinclair@chromium.orgfbed6562015-09-25 21:22:36 +00004523 return 1
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004524
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004525 if options.newbranch:
4526 if options.force:
4527 RunGit(['branch', '-D', options.newbranch],
4528 stderr=subprocess2.PIPE, error_ok=True)
Edward Lemur85153282020-02-14 22:06:29 +00004529 git_new_branch.main(options.newbranch)
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004530
Edward Lemur678a6842019-10-03 22:25:05 +00004531 cl = Changelist(
4532 codereview_host=target_issue_arg.hostname, issue=target_issue_arg.issue)
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004533
Edward Lemur678a6842019-10-03 22:25:05 +00004534 if not args[0].isdigit():
Edward Lemurf38bc172019-09-03 21:02:13 +00004535 print('canonical issue/change URL: %s\n' % cl.GetIssueURL())
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004536
Edward Lemurf38bc172019-09-03 21:02:13 +00004537 return cl.CMDPatchWithParsedIssue(
4538 target_issue_arg, options.nocommit, options.force)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004539
4540
jochen@chromium.org3ec0d542014-01-14 20:00:03 +00004541def GetTreeStatus(url=None):
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004542 """Fetches the tree status and returns either 'open', 'closed',
4543 'unknown' or 'unset'."""
jochen@chromium.org3ec0d542014-01-14 20:00:03 +00004544 url = url or settings.GetTreeStatusUrl(error_ok=True)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004545 if url:
Edward Lemur79d4f992019-11-11 23:49:02 +00004546 status = urllib.request.urlopen(url).read().lower()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004547 if status.find('closed') != -1 or status == '0':
4548 return 'closed'
4549 elif status.find('open') != -1 or status == '1':
4550 return 'open'
4551 return 'unknown'
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004552 return 'unset'
4553
dpranke@chromium.org970c5222011-03-12 00:32:24 +00004554
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004555def GetTreeStatusReason():
4556 """Fetches the tree status from a json url and returns the message
4557 with the reason for the tree to be opened or closed."""
msb@chromium.orgbf1a7ba2011-02-01 16:21:46 +00004558 url = settings.GetTreeStatusUrl()
4559 json_url = urlparse.urljoin(url, '/current?format=json')
Edward Lemur79d4f992019-11-11 23:49:02 +00004560 connection = urllib.request.urlopen(json_url)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004561 status = json.loads(connection.read())
4562 connection.close()
4563 return status['message']
4564
dpranke@chromium.org970c5222011-03-12 00:32:24 +00004565
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004566@metrics.collector.collect_metrics('git cl tree')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004567def CMDtree(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004568 """Shows the status of the tree."""
dpranke@chromium.org97ae58e2011-03-18 00:29:20 +00004569 _, args = parser.parse_args(args)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004570 status = GetTreeStatus()
4571 if 'unset' == status:
vapiera7fbd5a2016-06-16 09:17:49 -07004572 print('You must configure your tree status URL by running "git cl config".')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004573 return 2
4574
vapiera7fbd5a2016-06-16 09:17:49 -07004575 print('The tree is %s' % status)
4576 print()
4577 print(GetTreeStatusReason())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004578 if status != 'open':
4579 return 1
4580 return 0
4581
4582
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004583@metrics.collector.collect_metrics('git cl try')
maruel@chromium.org15192402012-09-06 12:38:29 +00004584def CMDtry(parser, args):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004585 """Triggers tryjobs using either Buildbucket or CQ dry run."""
4586 group = optparse.OptionGroup(parser, 'Tryjob options')
maruel@chromium.org15192402012-09-06 12:38:29 +00004587 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004588 '-b', '--bot', action='append',
4589 help=('IMPORTANT: specify ONE builder per --bot flag. Use it multiple '
4590 'times to specify multiple builders. ex: '
4591 '"-b win_rel -b win_layout". See '
4592 'the try server waterfall for the builders name and the tests '
4593 'available.'))
maruel@chromium.org15192402012-09-06 12:38:29 +00004594 group.add_option(
borenet6c0efe62016-10-19 08:13:29 -07004595 '-B', '--bucket', default='',
4596 help=('Buildbucket bucket to send the try requests.'))
4597 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004598 '-r', '--revision',
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004599 help='Revision to use for the tryjob; default: the revision will '
tandriif7b29d42016-10-07 08:45:41 -07004600 'be determined by the try recipe that builder runs, which usually '
4601 'defaults to HEAD of origin/master')
maruel@chromium.org15192402012-09-06 12:38:29 +00004602 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004603 '-c', '--clobber', action='store_true', default=False,
tandriif7b29d42016-10-07 08:45:41 -07004604 help='Force a clobber before building; that is don\'t do an '
tandrii1838bad2016-10-06 00:10:52 -07004605 'incremental build')
maruel@chromium.org15192402012-09-06 12:38:29 +00004606 group.add_option(
Andrii Shyshkalovf9648b52018-02-21 22:32:42 -08004607 '--category', default='git_cl_try', help='Specify custom build category.')
4608 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004609 '--project',
4610 help='Override which project to use. Projects are defined '
tandriif7b29d42016-10-07 08:45:41 -07004611 'in recipe to determine to which repository or directory to '
4612 'apply the patch')
maruel@chromium.org15192402012-09-06 12:38:29 +00004613 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004614 '-p', '--property', dest='properties', action='append', default=[],
4615 help='Specify generic properties in the form -p key1=value1 -p '
tandriif7b29d42016-10-07 08:45:41 -07004616 'key2=value2 etc. The value will be treated as '
4617 'json if decodable, or as string otherwise. '
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004618 'NOTE: using this may make your tryjob not usable for CQ, '
4619 'which will then schedule another tryjob with default properties')
sheyang@chromium.orgdb375572015-08-17 19:22:23 +00004620 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004621 '--buildbucket-host', default='cr-buildbucket.appspot.com',
4622 help='Host of buildbucket. The default host is %default.')
maruel@chromium.org15192402012-09-06 12:38:29 +00004623 parser.add_option_group(group)
Quinten Yearsley983111f2019-09-26 17:18:48 +00004624 parser.add_option(
4625 '-R', '--retry-failed', action='store_true', default=False,
4626 help='Retry failed jobs from the latest set of tryjobs. '
4627 'Not allowed with --bucket and --bot options.')
Edward Lemur52969c92020-02-06 18:15:28 +00004628 parser.add_option(
4629 '-i', '--issue', type=int,
4630 help='Operate on this issue instead of the current branch\'s implicit '
4631 'issue.')
maruel@chromium.org15192402012-09-06 12:38:29 +00004632 options, args = parser.parse_args(args)
4633
machenbach@chromium.org45453142015-09-15 08:45:22 +00004634 # Make sure that all properties are prop=value pairs.
4635 bad_params = [x for x in options.properties if '=' not in x]
4636 if bad_params:
4637 parser.error('Got properties with missing "=": %s' % bad_params)
4638
maruel@chromium.org15192402012-09-06 12:38:29 +00004639 if args:
4640 parser.error('Unknown arguments: %s' % args)
4641
Edward Lemur934836a2019-09-09 20:16:54 +00004642 cl = Changelist(issue=options.issue)
maruel@chromium.org15192402012-09-06 12:38:29 +00004643 if not cl.GetIssue():
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004644 parser.error('Need to upload first.')
maruel@chromium.org15192402012-09-06 12:38:29 +00004645
Edward Lemurf38bc172019-09-03 21:02:13 +00004646 # HACK: warm up Gerrit change detail cache to save on RPCs.
Edward Lemur125d60a2019-09-13 18:25:41 +00004647 cl._GetChangeDetail(['DETAILED_ACCOUNTS', 'ALL_REVISIONS'])
Andrii Shyshkaloveadad922017-01-26 09:38:30 +01004648
tandriie113dfd2016-10-11 10:20:12 -07004649 error_message = cl.CannotTriggerTryJobReason()
4650 if error_message:
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004651 parser.error('Can\'t trigger tryjobs: %s' % error_message)
jrobbins@chromium.org16f10f72014-06-24 22:14:36 +00004652
Quinten Yearsley983111f2019-09-26 17:18:48 +00004653 if options.retry_failed:
4654 if options.bot or options.bucket:
4655 print('ERROR: The option --retry-failed is not compatible with '
4656 '-B, -b, --bucket, or --bot.', file=sys.stderr)
4657 return 1
4658 print('Searching for failed tryjobs...')
Edward Lemur5b929a42019-10-21 17:57:39 +00004659 builds, patchset = _fetch_latest_builds(cl, options.buildbucket_host)
Quinten Yearsley983111f2019-09-26 17:18:48 +00004660 if options.verbose:
4661 print('Got %d builds in patchset #%d' % (len(builds), patchset))
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +00004662 buckets = _filter_failed_for_retry(builds)
Quinten Yearsley983111f2019-09-26 17:18:48 +00004663 if not buckets:
4664 print('There are no failed jobs in the latest set of jobs '
4665 '(patchset #%d), doing nothing.' % patchset)
4666 return 0
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00004667 num_builders = sum(map(len, buckets.values()))
Quinten Yearsley983111f2019-09-26 17:18:48 +00004668 if num_builders > 10:
4669 confirm_or_exit('There are %d builders with failed builds.'
4670 % num_builders, action='continue')
4671 else:
4672 buckets = _get_bucket_map(cl, options, parser)
4673 if buckets and any(b.startswith('master.') for b in buckets):
4674 print('ERROR: Buildbot masters are not supported.')
4675 return 1
phajdan.jr@chromium.org8da7f272014-03-14 01:28:39 +00004676
qyearsleydd49f942016-10-28 11:57:22 -07004677 # If no bots are listed and we couldn't get a list based on PRESUBMIT files,
4678 # then we default to triggering a CQ dry run (see http://crbug.com/625697).
qyearsley1fdfcb62016-10-24 13:22:03 -07004679 if not buckets:
qyearsley1fdfcb62016-10-24 13:22:03 -07004680 if options.verbose:
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07004681 print('git cl try with no bots now defaults to CQ dry run.')
4682 print('Scheduling CQ dry run on: %s' % cl.GetIssueURL())
4683 return cl.SetCQState(_CQState.DRY_RUN)
stip@chromium.org43064fd2013-12-18 20:07:44 +00004684
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00004685 for builders in buckets.values():
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00004686 if any('triggered' in b for b in builders):
vapiera7fbd5a2016-06-16 09:17:49 -07004687 print('ERROR You are trying to send a job to a triggered bot. This type '
tandriide281ae2016-10-12 06:02:30 -07004688 'of bot requires an initial job from a parent (usually a builder). '
4689 'Instead send your job to the parent.\n'
vapiera7fbd5a2016-06-16 09:17:49 -07004690 'Bot list: %s' % builders, file=sys.stderr)
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00004691 return 1
ilevy@chromium.orgf3b21232012-09-24 20:48:55 +00004692
ilevy@chromium.org36e420b2013-08-06 23:21:12 +00004693 patchset = cl.GetMostRecentPatchset()
Edward Lemur2c210a42019-09-16 23:58:35 +00004694 try:
Edward Lemur5b929a42019-10-21 17:57:39 +00004695 _trigger_try_jobs(cl, buckets, options, patchset)
Edward Lemur2c210a42019-09-16 23:58:35 +00004696 except BuildbucketResponseException as ex:
4697 print('ERROR: %s' % ex)
4698 return 1
4699 return 0
maruel@chromium.org15192402012-09-06 12:38:29 +00004700
4701
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004702@metrics.collector.collect_metrics('git cl try-results')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004703def CMDtry_results(parser, args):
Quinten Yearsleyd242ed72019-07-25 17:17:55 +00004704 """Prints info about results for tryjobs associated with the current CL."""
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004705 group = optparse.OptionGroup(parser, 'Tryjob results options')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004706 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004707 '-p', '--patchset', type=int, help='patchset number if not current.')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004708 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004709 '--print-master', action='store_true', help='print master name as well.')
tandrii@chromium.org6cf98c82016-03-15 11:56:00 +00004710 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004711 '--color', action='store_true', default=setup_color.IS_TTY,
4712 help='force color output, useful when piping output.')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004713 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004714 '--buildbucket-host', default='cr-buildbucket.appspot.com',
4715 help='Host of buildbucket. The default host is %default.')
qyearsley53f48a12016-09-01 10:45:13 -07004716 group.add_option(
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004717 '--json', help=('Path of JSON output file to write tryjob results to,'
Stefan Zager1306bd02017-06-22 19:26:46 -07004718 'or "-" for stdout.'))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004719 parser.add_option_group(group)
Edward Lemur52969c92020-02-06 18:15:28 +00004720 parser.add_option(
4721 '-i', '--issue', type=int,
4722 help='Operate on this issue instead of the current branch\'s implicit '
4723 'issue.')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004724 options, args = parser.parse_args(args)
4725 if args:
4726 parser.error('Unrecognized args: %s' % ' '.join(args))
4727
Edward Lemur934836a2019-09-09 20:16:54 +00004728 cl = Changelist(issue=options.issue)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004729 if not cl.GetIssue():
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004730 parser.error('Need to upload first.')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004731
tandrii221ab252016-10-06 08:12:04 -07004732 patchset = options.patchset
4733 if not patchset:
4734 patchset = cl.GetMostRecentPatchset()
4735 if not patchset:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004736 parser.error('Code review host doesn\'t know about issue %s. '
tandrii221ab252016-10-06 08:12:04 -07004737 'No access to issue or wrong issue number?\n'
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004738 'Either upload first, or pass --patchset explicitly.' %
tandrii221ab252016-10-06 08:12:04 -07004739 cl.GetIssue())
4740
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004741 try:
Edward Lemur5b929a42019-10-21 17:57:39 +00004742 jobs = fetch_try_jobs(cl, options.buildbucket_host, patchset)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004743 except BuildbucketResponseException as ex:
vapiera7fbd5a2016-06-16 09:17:49 -07004744 print('Buildbucket error: %s' % ex)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004745 return 1
qyearsley53f48a12016-09-01 10:45:13 -07004746 if options.json:
Edward Lemurbaaf6be2019-10-09 18:00:44 +00004747 write_json(options.json, jobs)
qyearsley53f48a12016-09-01 10:45:13 -07004748 else:
4749 print_try_jobs(options, jobs)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004750 return 0
4751
4752
maruel@chromium.org0633fb42013-08-16 20:06:14 +00004753@subcommand.usage('[new upstream branch]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004754@metrics.collector.collect_metrics('git cl upstream')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004755def CMDupstream(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004756 """Prints or sets the name of the upstream branch, if any."""
dpranke@chromium.org97ae58e2011-03-18 00:29:20 +00004757 _, args = parser.parse_args(args)
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00004758 if len(args) > 1:
maruel@chromium.org27bb3872011-05-30 20:33:19 +00004759 parser.error('Unrecognized args: %s' % ' '.join(args))
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00004760
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004761 cl = Changelist()
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00004762 if args:
4763 # One arg means set upstream branch.
bauerb@chromium.orgc9cf90a2014-04-28 20:32:31 +00004764 branch = cl.GetBranch()
stip7a3dd352016-09-22 17:32:28 -07004765 RunGit(['branch', '--set-upstream-to', args[0], branch])
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00004766 cl = Changelist()
vapiera7fbd5a2016-06-16 09:17:49 -07004767 print('Upstream branch set to %s' % (cl.GetUpstreamBranch(),))
bauerb@chromium.orgc9cf90a2014-04-28 20:32:31 +00004768
4769 # Clear configured merge-base, if there is one.
4770 git_common.remove_merge_base(branch)
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00004771 else:
vapiera7fbd5a2016-06-16 09:17:49 -07004772 print(cl.GetUpstreamBranch())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004773 return 0
4774
4775
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004776@metrics.collector.collect_metrics('git cl web')
thestig@chromium.org00858c82013-12-02 23:08:03 +00004777def CMDweb(parser, args):
4778 """Opens the current CL in the web browser."""
4779 _, args = parser.parse_args(args)
4780 if args:
4781 parser.error('Unrecognized args: %s' % ' '.join(args))
4782
4783 issue_url = Changelist().GetIssueURL()
4784 if not issue_url:
vapiera7fbd5a2016-06-16 09:17:49 -07004785 print('ERROR No issue to open', file=sys.stderr)
thestig@chromium.org00858c82013-12-02 23:08:03 +00004786 return 1
4787
Sergiy Byelozyorov2b718322018-10-24 17:43:31 +00004788 # Redirect I/O before invoking browser to hide its output. For example, this
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004789 # allows us to hide the "Created new window in existing browser session."
4790 # message from Chrome. Based on https://stackoverflow.com/a/2323563.
Sergiy Byelozyorov2b718322018-10-24 17:43:31 +00004791 saved_stdout = os.dup(1)
Sergiy Belozorov06684032019-03-06 16:53:08 +00004792 saved_stderr = os.dup(2)
Sergiy Byelozyorov2b718322018-10-24 17:43:31 +00004793 os.close(1)
Sergiy Belozorov06684032019-03-06 16:53:08 +00004794 os.close(2)
Sergiy Byelozyorov2b718322018-10-24 17:43:31 +00004795 os.open(os.devnull, os.O_RDWR)
4796 try:
4797 webbrowser.open(issue_url)
4798 finally:
4799 os.dup2(saved_stdout, 1)
Sergiy Belozorov06684032019-03-06 16:53:08 +00004800 os.dup2(saved_stderr, 2)
thestig@chromium.org00858c82013-12-02 23:08:03 +00004801 return 0
4802
4803
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004804@metrics.collector.collect_metrics('git cl set-commit')
maruel@chromium.org27bb3872011-05-30 20:33:19 +00004805def CMDset_commit(parser, args):
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +00004806 """Sets the commit bit to trigger the CQ."""
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00004807 parser.add_option('-d', '--dry-run', action='store_true',
4808 help='trigger in dry run mode')
4809 parser.add_option('-c', '--clear', action='store_true',
4810 help='stop CQ run, if any')
Edward Lemur52969c92020-02-06 18:15:28 +00004811 parser.add_option(
4812 '-i', '--issue', type=int,
4813 help='Operate on this issue instead of the current branch\'s implicit '
4814 'issue.')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004815 options, args = parser.parse_args(args)
maruel@chromium.org27bb3872011-05-30 20:33:19 +00004816 if args:
4817 parser.error('Unrecognized args: %s' % ' '.join(args))
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00004818 if options.dry_run and options.clear:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004819 parser.error('Only one of --dry-run and --clear are allowed.')
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00004820
Edward Lemur934836a2019-09-09 20:16:54 +00004821 cl = Changelist(issue=options.issue)
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00004822 if options.clear:
tandriid9e5ce52016-07-13 02:32:59 -07004823 state = _CQState.NONE
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00004824 elif options.dry_run:
4825 state = _CQState.DRY_RUN
4826 else:
4827 state = _CQState.COMMIT
4828 if not cl.GetIssue():
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004829 parser.error('Must upload the issue first.')
tandrii9de9ec62016-07-13 03:01:59 -07004830 cl.SetCQState(state)
maruel@chromium.org27bb3872011-05-30 20:33:19 +00004831 return 0
4832
4833
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004834@metrics.collector.collect_metrics('git cl set-close')
groby@chromium.org411034a2013-02-26 15:12:01 +00004835def CMDset_close(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004836 """Closes the issue."""
Edward Lemur52969c92020-02-06 18:15:28 +00004837 parser.add_option(
4838 '-i', '--issue', type=int,
4839 help='Operate on this issue instead of the current branch\'s implicit '
4840 'issue.')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004841 options, args = parser.parse_args(args)
groby@chromium.org411034a2013-02-26 15:12:01 +00004842 if args:
4843 parser.error('Unrecognized args: %s' % ' '.join(args))
Edward Lemur934836a2019-09-09 20:16:54 +00004844 cl = Changelist(issue=options.issue)
groby@chromium.org411034a2013-02-26 15:12:01 +00004845 # Ensure there actually is an issue to close.
Aaron Gable7139a4e2017-09-05 17:53:09 -07004846 if not cl.GetIssue():
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004847 DieWithError('ERROR: No issue to close.')
groby@chromium.org411034a2013-02-26 15:12:01 +00004848 cl.CloseIssue()
4849 return 0
4850
4851
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004852@metrics.collector.collect_metrics('git cl diff')
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00004853def CMDdiff(parser, args):
wychen@chromium.org37b2ec02015-04-03 00:49:15 +00004854 """Shows differences between local tree and last upload."""
thomasanderson074beb22016-08-29 14:03:20 -07004855 parser.add_option(
4856 '--stat',
4857 action='store_true',
4858 dest='stat',
4859 help='Generate a diffstat')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004860 options, args = parser.parse_args(args)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004861 if args:
4862 parser.error('Unrecognized args: %s' % ' '.join(args))
wychen@chromium.org46309bf2015-04-03 21:04:49 +00004863
Edward Lemur934836a2019-09-09 20:16:54 +00004864 cl = Changelist()
sbc@chromium.org78dc9842013-11-25 18:43:44 +00004865 issue = cl.GetIssue()
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00004866 branch = cl.GetBranch()
sbc@chromium.org78dc9842013-11-25 18:43:44 +00004867 if not issue:
4868 DieWithError('No issue found for current branch (%s)' % branch)
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00004869
Aaron Gablea718c3e2017-08-28 17:47:28 -07004870 base = cl._GitGetBranchConfigValue('last-upload-hash')
4871 if not base:
4872 base = cl._GitGetBranchConfigValue('gerritsquashhash')
4873 if not base:
4874 detail = cl._GetChangeDetail(['CURRENT_REVISION', 'CURRENT_COMMIT'])
4875 revision_info = detail['revisions'][detail['current_revision']]
4876 fetch_info = revision_info['fetch']['http']
4877 RunGit(['fetch', fetch_info['url'], fetch_info['ref']])
4878 base = 'FETCH_HEAD'
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00004879
Aaron Gablea718c3e2017-08-28 17:47:28 -07004880 cmd = ['git', 'diff']
4881 if options.stat:
4882 cmd.append('--stat')
4883 cmd.append(base)
4884 subprocess2.check_call(cmd)
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00004885
4886 return 0
4887
4888
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004889@metrics.collector.collect_metrics('git cl owners')
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00004890def CMDowners(parser, args):
Dirk Prankebf980882017-09-02 15:08:00 -07004891 """Finds potential owners for reviewing."""
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00004892 parser.add_option(
Sidney San Martín8e6f58c2018-06-08 01:02:56 +00004893 '--ignore-current',
4894 action='store_true',
4895 help='Ignore the CL\'s current reviewers and start from scratch.')
4896 parser.add_option(
Sylvain Defresneb1f865d2019-02-12 12:38:22 +00004897 '--ignore-self',
4898 action='store_true',
4899 help='Do not consider CL\'s author as an owners.')
4900 parser.add_option(
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00004901 '--no-color',
4902 action='store_true',
4903 help='Use this option to disable color output')
Dirk Prankebf980882017-09-02 15:08:00 -07004904 parser.add_option(
4905 '--batch',
4906 action='store_true',
4907 help='Do not run interactively, just suggest some')
Yang Guo6e269a02019-06-26 11:17:02 +00004908 # TODO: Consider moving this to another command, since other
4909 # git-cl owners commands deal with owners for a given CL.
4910 parser.add_option(
4911 '--show-all',
4912 action='store_true',
4913 help='Show all owners for a particular file')
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00004914 options, args = parser.parse_args(args)
4915
4916 author = RunGit(['config', 'user.email']).strip() or None
4917
Edward Lemur934836a2019-09-09 20:16:54 +00004918 cl = Changelist()
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00004919
Yang Guo6e269a02019-06-26 11:17:02 +00004920 if options.show_all:
4921 for arg in args:
4922 base_branch = cl.GetCommonAncestorWithUpstream()
Edward Lemur7f6dec02020-02-06 20:23:58 +00004923 database = owners.Database(settings.GetRoot(), file, os.path)
Yang Guo6e269a02019-06-26 11:17:02 +00004924 database.load_data_needed_for([arg])
4925 print('Owners for %s:' % arg)
4926 for owner in sorted(database.all_possible_owners([arg], None)):
4927 print(' - %s' % owner)
4928 return 0
4929
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00004930 if args:
4931 if len(args) > 1:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004932 parser.error('Unknown args.')
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00004933 base_branch = args[0]
4934 else:
4935 # Default to diffing against the common ancestor of the upstream branch.
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00004936 base_branch = cl.GetCommonAncestorWithUpstream()
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00004937
Edward Lemur7f6dec02020-02-06 20:23:58 +00004938 change = cl.GetChange(base_branch)
Dirk Prankebf980882017-09-02 15:08:00 -07004939 affected_files = [f.LocalPath() for f in change.AffectedFiles()]
4940
4941 if options.batch:
4942 db = owners.Database(change.RepositoryRoot(), file, os.path)
4943 print('\n'.join(db.reviewers_for(affected_files, author)))
4944 return 0
4945
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00004946 return owners_finder.OwnersFinder(
Dirk Prankebf980882017-09-02 15:08:00 -07004947 affected_files,
Jochen Eisinger72606f82017-04-04 10:44:18 +02004948 change.RepositoryRoot(),
Edward Lemur707d70b2018-02-07 00:50:14 +01004949 author,
Sidney San Martín8e6f58c2018-06-08 01:02:56 +00004950 [] if options.ignore_current else cl.GetReviewers(),
Edward Lemur707d70b2018-02-07 00:50:14 +01004951 fopen=file, os_path=os.path,
Jochen Eisingerd0573ec2017-04-13 10:55:06 +02004952 disable_color=options.no_color,
Sylvain Defresneb1f865d2019-02-12 12:38:22 +00004953 override_files=change.OriginalOwnersFiles(),
4954 ignore_author=options.ignore_self).run()
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00004955
4956
Aiden Bennerc08566e2018-10-03 17:52:42 +00004957def BuildGitDiffCmd(diff_type, upstream_commit, args, allow_prefix=False):
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00004958 """Generates a diff command."""
4959 # Generate diff for the current branch's changes.
Aiden Bennerc08566e2018-10-03 17:52:42 +00004960 diff_cmd = ['-c', 'core.quotePath=false', 'diff', '--no-ext-diff']
4961
Aiden Benner6c18a1a2018-11-23 20:18:23 +00004962 if allow_prefix:
4963 # explicitly setting --src-prefix and --dst-prefix is necessary in the
4964 # case that diff.noprefix is set in the user's git config.
4965 diff_cmd += ['--src-prefix=a/', '--dst-prefix=b/']
4966 else:
Aiden Bennerc08566e2018-10-03 17:52:42 +00004967 diff_cmd += ['--no-prefix']
4968
4969 diff_cmd += [diff_type, upstream_commit, '--']
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00004970
4971 if args:
4972 for arg in args:
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00004973 if os.path.isdir(arg) or os.path.isfile(arg):
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00004974 diff_cmd.append(arg)
4975 else:
4976 DieWithError('Argument "%s" is not a file or a directory' % arg)
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00004977
4978 return diff_cmd
4979
Andrii Shyshkalov18975322017-01-25 16:44:13 +01004980
Jamie Madill5e96ad12020-01-13 16:08:35 +00004981def _RunClangFormatDiff(opts, clang_diff_files, top_dir, upstream_commit):
4982 """Runs clang-format-diff and sets a return value if necessary."""
4983
4984 if not clang_diff_files:
4985 return 0
4986
4987 # Set to 2 to signal to CheckPatchFormatted() that this patch isn't
4988 # formatted. This is used to block during the presubmit.
4989 return_value = 0
4990
4991 # Locate the clang-format binary in the checkout
4992 try:
4993 clang_format_tool = clang_format.FindClangFormatToolInChromiumTree()
4994 except clang_format.NotFoundError as e:
4995 DieWithError(e)
4996
4997 if opts.full or settings.GetFormatFullByDefault():
4998 cmd = [clang_format_tool]
4999 if not opts.dry_run and not opts.diff:
5000 cmd.append('-i')
5001 if opts.dry_run:
5002 for diff_file in clang_diff_files:
5003 with open(diff_file, 'r') as myfile:
5004 code = myfile.read().replace('\r\n', '\n')
5005 stdout = RunCommand(cmd + [diff_file], cwd=top_dir)
5006 stdout = stdout.replace('\r\n', '\n')
5007 if opts.diff:
5008 sys.stdout.write(stdout)
5009 if code != stdout:
5010 return_value = 2
5011 else:
5012 stdout = RunCommand(cmd + clang_diff_files, cwd=top_dir)
5013 if opts.diff:
5014 sys.stdout.write(stdout)
5015 else:
5016 env = os.environ.copy()
5017 env['PATH'] = str(os.path.dirname(clang_format_tool))
5018 try:
5019 script = clang_format.FindClangFormatScriptInChromiumTree(
5020 'clang-format-diff.py')
5021 except clang_format.NotFoundError as e:
5022 DieWithError(e)
5023
5024 cmd = [sys.executable, script, '-p0']
5025 if not opts.dry_run and not opts.diff:
5026 cmd.append('-i')
5027
5028 diff_cmd = BuildGitDiffCmd('-U0', upstream_commit, clang_diff_files)
5029 diff_output = RunGit(diff_cmd)
5030
5031 stdout = RunCommand(cmd, stdin=diff_output, cwd=top_dir, env=env)
5032 if opts.diff:
5033 sys.stdout.write(stdout)
5034 if opts.dry_run and len(stdout) > 0:
5035 return_value = 2
5036
5037 return return_value
5038
5039
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005040def MatchingFileType(file_name, extensions):
Quinten Yearsleyd242ed72019-07-25 17:17:55 +00005041 """Returns True if the file name ends with one of the given extensions."""
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005042 return bool([ext for ext in extensions if file_name.lower().endswith(ext)])
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005043
Andrii Shyshkalov18975322017-01-25 16:44:13 +01005044
enne@chromium.org555cfe42014-01-29 18:21:39 +00005045@subcommand.usage('[files or directories to diff]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005046@metrics.collector.collect_metrics('git cl format')
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005047def CMDformat(parser, args):
sbc@chromium.org9d0644d2015-06-05 23:16:54 +00005048 """Runs auto-formatting tools (clang-format etc.) on the diff."""
Christopher Lamc5ba6922017-01-24 11:19:14 +11005049 CLANG_EXTS = ['.cc', '.cpp', '.h', '.m', '.mm', '.proto', '.java']
kylechar58edce22016-06-17 06:07:51 -07005050 GN_EXTS = ['.gn', '.gni', '.typemap']
enne@chromium.org3b7e15c2014-01-21 17:44:47 +00005051 parser.add_option('--full', action='store_true',
5052 help='Reformat the full content of all touched files')
5053 parser.add_option('--dry-run', action='store_true',
5054 help='Don\'t modify any file on disk.')
Aiden Benner99b0ccb2018-11-20 19:53:31 +00005055 parser.add_option(
Garrett Beatyed0cc5f2020-01-06 17:26:13 +00005056 '--no-clang-format',
5057 dest='clang_format',
5058 action='store_false',
5059 default=True,
5060 help='Disables formatting of various file types using clang-format.')
5061 parser.add_option(
Aiden Benner99b0ccb2018-11-20 19:53:31 +00005062 '--python',
5063 action='store_true',
5064 default=None,
5065 help='Enables python formatting on all python files.')
5066 parser.add_option(
5067 '--no-python',
5068 action='store_true',
Garrett Beaty91a6f332020-01-06 16:57:24 +00005069 default=False,
Aiden Benner99b0ccb2018-11-20 19:53:31 +00005070 help='Disables python formatting on all python files. '
Garrett Beaty91a6f332020-01-06 16:57:24 +00005071 'If neither --python or --no-python are set, python files that have a '
5072 '.style.yapf file in an ancestor directory will be formatted. '
5073 'It is an error to set both.')
Garrett Beatyed0cc5f2020-01-06 17:26:13 +00005074 parser.add_option(
5075 '--js',
5076 action='store_true',
5077 help='Format javascript code with clang-format. '
5078 'Has no effect if --no-clang-format is set.')
wittman@chromium.org04d5a222014-03-07 18:30:42 +00005079 parser.add_option('--diff', action='store_true',
5080 help='Print diff to stdout rather than modifying files.')
Ilya Shermane081cbe2017-08-15 17:51:04 -07005081 parser.add_option('--presubmit', action='store_true',
5082 help='Used when running the script from a presubmit.')
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005083 opts, args = parser.parse_args(args)
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005084
Garrett Beaty91a6f332020-01-06 16:57:24 +00005085 if opts.python is not None and opts.no_python:
5086 raise parser.error('Cannot set both --python and --no-python')
5087 if opts.no_python:
5088 opts.python = False
5089
Daniel Chengc55eecf2016-12-30 03:11:02 -08005090 # Normalize any remaining args against the current path, so paths relative to
5091 # the current directory are still resolved as expected.
5092 args = [os.path.join(os.getcwd(), arg) for arg in args]
5093
enne@chromium.orgff7a1fb2013-12-10 19:21:41 +00005094 # git diff generates paths against the root of the repository. Change
5095 # to that directory so clang-format can find files even within subdirs.
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00005096 rel_base_path = settings.GetRelativeRoot()
enne@chromium.orgff7a1fb2013-12-10 19:21:41 +00005097 if rel_base_path:
5098 os.chdir(rel_base_path)
5099
digit@chromium.org29e47272013-05-17 17:01:46 +00005100 # Grab the merge-base commit, i.e. the upstream commit of the current
5101 # branch when it was created or the last time it was rebased. This is
5102 # to cover the case where the user may have called "git fetch origin",
5103 # moving the origin branch to a newer commit, but hasn't rebased yet.
5104 upstream_commit = None
5105 cl = Changelist()
5106 upstream_branch = cl.GetUpstreamBranch()
5107 if upstream_branch:
5108 upstream_commit = RunGit(['merge-base', 'HEAD', upstream_branch])
5109 upstream_commit = upstream_commit.strip()
5110
5111 if not upstream_commit:
5112 DieWithError('Could not find base commit for this branch. '
5113 'Are you in detached state?')
5114
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005115 changed_files_cmd = BuildGitDiffCmd('--name-only', upstream_commit, args)
5116 diff_output = RunGit(changed_files_cmd)
5117 diff_files = diff_output.splitlines()
jkarlin@chromium.orgad21b922016-01-28 17:48:42 +00005118 # Filter out files deleted by this CL
5119 diff_files = [x for x in diff_files if os.path.isfile(x)]
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005120
Andreas Haas417d89c2020-02-06 10:24:27 +00005121 if opts.js:
Deepanjan Roy605dd312018-07-02 17:48:54 +00005122 CLANG_EXTS.extend(['.js', '.ts'])
Christopher Lamc5ba6922017-01-24 11:19:14 +11005123
Garrett Beatyed0cc5f2020-01-06 17:26:13 +00005124 clang_diff_files = []
5125 if opts.clang_format:
5126 clang_diff_files = [
5127 x for x in diff_files if MatchingFileType(x, CLANG_EXTS)
5128 ]
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005129 python_diff_files = [x for x in diff_files if MatchingFileType(x, ['.py'])]
5130 dart_diff_files = [x for x in diff_files if MatchingFileType(x, ['.dart'])]
kylechar@chromium.org8b61f112016-02-05 13:28:58 +00005131 gn_diff_files = [x for x in diff_files if MatchingFileType(x, GN_EXTS)]
digit@chromium.org29e47272013-05-17 17:01:46 +00005132
nick@chromium.org3ac1c4e2014-01-16 02:44:42 +00005133 top_dir = os.path.normpath(
5134 RunGit(["rev-parse", "--show-toplevel"]).rstrip('\n'))
5135
Jamie Madill5e96ad12020-01-13 16:08:35 +00005136 return_value = _RunClangFormatDiff(opts, clang_diff_files, top_dir,
5137 upstream_commit)
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005138
sbc@chromium.org9d0644d2015-06-05 23:16:54 +00005139 # Similar code to above, but using yapf on .py files rather than clang-format
5140 # on C/C++ files
Aiden Benner99b0ccb2018-11-20 19:53:31 +00005141 py_explicitly_disabled = opts.python is not None and not opts.python
5142 if python_diff_files and not py_explicitly_disabled:
Aiden Bennere47ac152018-11-20 16:44:03 +00005143 depot_tools_path = os.path.dirname(os.path.abspath(__file__))
5144 yapf_tool = os.path.join(depot_tools_path, 'yapf')
5145 if sys.platform.startswith('win'):
5146 yapf_tool += '.bat'
sbc@chromium.org9d0644d2015-06-05 23:16:54 +00005147
Aiden Bennerc08566e2018-10-03 17:52:42 +00005148 # Used for caching.
5149 yapf_configs = {}
5150 for f in python_diff_files:
5151 # Find the yapf style config for the current file, defaults to depot
5152 # tools default.
Aiden Benner99b0ccb2018-11-20 19:53:31 +00005153 _FindYapfConfigFile(f, yapf_configs, top_dir)
5154
5155 # Turn on python formatting by default if a yapf config is specified.
5156 # This breaks in the case of this repo though since the specified
5157 # style file is also the global default.
5158 if opts.python is None:
5159 filtered_py_files = []
5160 for f in python_diff_files:
5161 if _FindYapfConfigFile(f, yapf_configs, top_dir) is not None:
5162 filtered_py_files.append(f)
5163 else:
5164 filtered_py_files = python_diff_files
5165
5166 # Note: yapf still seems to fix indentation of the entire file
5167 # even if line ranges are specified.
5168 # See https://github.com/google/yapf/issues/499
5169 if not opts.full and filtered_py_files:
5170 py_line_diffs = _ComputeDiffLineRanges(filtered_py_files, upstream_commit)
5171
Brian Sheedyb4307d52019-12-02 19:18:17 +00005172 yapfignore_patterns = _GetYapfIgnorePatterns(top_dir)
5173 filtered_py_files = _FilterYapfIgnoredFiles(filtered_py_files,
5174 yapfignore_patterns)
Brian Sheedy59b06a82019-10-14 17:03:29 +00005175
Aiden Benner99b0ccb2018-11-20 19:53:31 +00005176 for f in filtered_py_files:
Andrew Grievefa40bfa2020-01-07 02:32:57 +00005177 yapf_style = _FindYapfConfigFile(f, yapf_configs, top_dir)
5178 # Default to pep8 if not .style.yapf is found.
5179 if not yapf_style:
5180 yapf_style = 'pep8'
Aiden Bennerc08566e2018-10-03 17:52:42 +00005181
Andrew Grievefa40bfa2020-01-07 02:32:57 +00005182 cmd = [yapf_tool, '--style', yapf_style, f]
Aiden Bennerc08566e2018-10-03 17:52:42 +00005183
5184 has_formattable_lines = False
5185 if not opts.full:
5186 # Only run yapf over changed line ranges.
5187 for diff_start, diff_len in py_line_diffs[f]:
5188 diff_end = diff_start + diff_len - 1
5189 # Yapf errors out if diff_end < diff_start but this
5190 # is a valid line range diff for a removal.
5191 if diff_end >= diff_start:
5192 has_formattable_lines = True
5193 cmd += ['-l', '{}-{}'.format(diff_start, diff_end)]
5194 # If all line diffs were removals we have nothing to format.
5195 if not has_formattable_lines:
5196 continue
5197
5198 if opts.diff or opts.dry_run:
5199 cmd += ['--diff']
5200 # Will return non-zero exit code if non-empty diff.
5201 stdout = RunCommand(cmd, error_ok=True, cwd=top_dir)
5202 if opts.diff:
5203 sys.stdout.write(stdout)
5204 elif len(stdout) > 0:
5205 return_value = 2
5206 else:
5207 cmd += ['-i']
5208 RunCommand(cmd, cwd=top_dir)
sbc@chromium.org9d0644d2015-06-05 23:16:54 +00005209
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005210 # Dart's formatter does not have the nice property of only operating on
5211 # modified chunks, so hard code full.
5212 if dart_diff_files:
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005213 try:
5214 command = [dart_format.FindDartFmtToolInChromiumTree()]
5215 if not opts.dry_run and not opts.diff:
5216 command.append('-w')
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005217 command.extend(dart_diff_files)
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005218
ppi@chromium.org6593d932016-03-03 15:41:15 +00005219 stdout = RunCommand(command, cwd=top_dir)
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005220 if opts.dry_run and stdout:
5221 return_value = 2
Jamie Madill5e96ad12020-01-13 16:08:35 +00005222 except dart_format.NotFoundError:
vapiera7fbd5a2016-06-16 09:17:49 -07005223 print('Warning: Unable to check Dart code formatting. Dart SDK not '
5224 'found in this checkout. Files in other languages are still '
5225 'formatted.')
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005226
kylechar@chromium.org8b61f112016-02-05 13:28:58 +00005227 # Format GN build files. Always run on full build files for canonical form.
5228 if gn_diff_files:
Andrii Shyshkalov18975322017-01-25 16:44:13 +01005229 cmd = ['gn', 'format']
brettw4b8ed592016-08-05 16:19:12 -07005230 if opts.dry_run or opts.diff:
5231 cmd.append('--dry-run')
kylechar@chromium.org8b61f112016-02-05 13:28:58 +00005232 for gn_diff_file in gn_diff_files:
brettw4b8ed592016-08-05 16:19:12 -07005233 gn_ret = subprocess2.call(cmd + [gn_diff_file],
5234 shell=sys.platform == 'win32',
5235 cwd=top_dir)
5236 if opts.dry_run and gn_ret == 2:
5237 return_value = 2 # Not formatted.
5238 elif opts.diff and gn_ret == 2:
5239 # TODO this should compute and print the actual diff.
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005240 print('This change has GN build file diff for ' + gn_diff_file)
brettw4b8ed592016-08-05 16:19:12 -07005241 elif gn_ret != 0:
5242 # For non-dry run cases (and non-2 return values for dry-run), a
5243 # nonzero error code indicates a failure, probably because the file
5244 # doesn't parse.
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005245 DieWithError('gn format failed on ' + gn_diff_file +
5246 '\nTry running `gn format` on this file manually.')
kylechar@chromium.org8b61f112016-02-05 13:28:58 +00005247
Ilya Shermane081cbe2017-08-15 17:51:04 -07005248 # Skip the metrics formatting from the global presubmit hook. These files have
5249 # a separate presubmit hook that issues an error if the files need formatting,
5250 # whereas the top-level presubmit script merely issues a warning. Formatting
5251 # these files is somewhat slow, so it's important not to duplicate the work.
5252 if not opts.presubmit:
5253 for xml_dir in GetDirtyMetricsDirs(diff_files):
5254 tool_dir = os.path.join(top_dir, xml_dir)
5255 cmd = [os.path.join(tool_dir, 'pretty_print.py'), '--non-interactive']
5256 if opts.dry_run or opts.diff:
5257 cmd.append('--diff')
Ilya Sherman235b70d2017-08-22 17:46:38 -07005258 stdout = RunCommand(cmd, cwd=top_dir)
Ilya Shermane081cbe2017-08-15 17:51:04 -07005259 if opts.diff:
5260 sys.stdout.write(stdout)
5261 if opts.dry_run and stdout:
5262 return_value = 2 # Not formatted.
Alexei Svitkinef3cac412017-02-06 11:08:50 -05005263
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005264 return return_value
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005265
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005266
Steven Holte2e664bf2017-04-21 13:10:47 -07005267def GetDirtyMetricsDirs(diff_files):
5268 xml_diff_files = [x for x in diff_files if MatchingFileType(x, ['.xml'])]
5269 metrics_xml_dirs = [
5270 os.path.join('tools', 'metrics', 'actions'),
5271 os.path.join('tools', 'metrics', 'histograms'),
5272 os.path.join('tools', 'metrics', 'rappor'),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005273 os.path.join('tools', 'metrics', 'ukm'),
5274 ]
Steven Holte2e664bf2017-04-21 13:10:47 -07005275 for xml_dir in metrics_xml_dirs:
5276 if any(file.startswith(xml_dir) for file in xml_diff_files):
5277 yield xml_dir
5278
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005279
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005280@subcommand.usage('<codereview url or issue id>')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005281@metrics.collector.collect_metrics('git cl checkout')
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005282def CMDcheckout(parser, args):
Edward Lemurf38bc172019-09-03 21:02:13 +00005283 """Checks out a branch associated with a given Gerrit issue."""
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005284 _, args = parser.parse_args(args)
5285
5286 if len(args) != 1:
5287 parser.print_help()
5288 return 1
5289
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00005290 issue_arg = ParseIssueNumberArgument(args[0])
tandrii@chromium.orgde6c9a12016-04-11 15:33:53 +00005291 if not issue_arg.valid:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00005292 parser.error('Invalid issue ID or URL.')
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02005293
tandrii@chromium.orgabd27e52016-04-11 15:43:32 +00005294 target_issue = str(issue_arg.issue)
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005295
Edward Lemur52969c92020-02-06 18:15:28 +00005296 issueprefix = Changelist.IssueConfigKey()
5297 output = RunGit(['config', '--local', '--get-regexp',
5298 r'branch\..*\.%s' % issueprefix],
5299 error_ok=True)
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005300
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00005301 branches = []
Edward Lemur52969c92020-02-06 18:15:28 +00005302 for key, issue in [x.split() for x in output.splitlines()]:
5303 if issue == target_issue:
5304 branches.append(re.sub(r'branch\.(.*)\.%s' % issueprefix, r'\1', key))
5305
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005306 if len(branches) == 0:
vapiera7fbd5a2016-06-16 09:17:49 -07005307 print('No branch found for issue %s.' % target_issue)
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005308 return 1
5309 if len(branches) == 1:
5310 RunGit(['checkout', branches[0]])
5311 else:
vapiera7fbd5a2016-06-16 09:17:49 -07005312 print('Multiple branches match issue %s:' % target_issue)
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005313 for i in range(len(branches)):
vapiera7fbd5a2016-06-16 09:17:49 -07005314 print('%d: %s' % (i, branches[i]))
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005315 which = raw_input('Choose by index: ')
5316 try:
5317 RunGit(['checkout', branches[int(which)]])
5318 except (IndexError, ValueError):
vapiera7fbd5a2016-06-16 09:17:49 -07005319 print('Invalid selection, not checking out any branch.')
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005320 return 1
5321
5322 return 0
5323
5324
maruel@chromium.org29404b52014-09-08 22:58:00 +00005325def CMDlol(parser, args):
5326 # This command is intentionally undocumented.
vapiera7fbd5a2016-06-16 09:17:49 -07005327 print(zlib.decompress(base64.b64decode(
thakis@chromium.org3421c992014-11-02 02:20:32 +00005328 'eNptkLEOwyAMRHe+wupCIqW57v0Vq84WqWtXyrcXnCBsmgMJ+/SSAxMZgRB6NzE'
5329 'E2ObgCKJooYdu4uAQVffUEoE1sRQLxAcqzd7uK2gmStrll1ucV3uZyaY5sXyDd9'
5330 'JAnN+lAXsOMJ90GANAi43mq5/VeeacylKVgi8o6F1SC63FxnagHfJUTfUYdCR/W'
vapiera7fbd5a2016-06-16 09:17:49 -07005331 'Ofe+0dHL7PicpytKP750Fh1q2qnLVof4w8OZWNY')))
maruel@chromium.org29404b52014-09-08 22:58:00 +00005332 return 0
5333
5334
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005335class OptionParser(optparse.OptionParser):
5336 """Creates the option parse and add --verbose support."""
5337 def __init__(self, *args, **kwargs):
maruel@chromium.org0633fb42013-08-16 20:06:14 +00005338 optparse.OptionParser.__init__(
5339 self, *args, prog='git cl', version=__version__, **kwargs)
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005340 self.add_option(
5341 '-v', '--verbose', action='count', default=0,
5342 help='Use 2 times for more debugging info')
5343
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005344 def parse_args(self, args=None, _values=None):
Andrii Shyshkalov46f20cd2018-10-30 06:42:54 +00005345 try:
5346 return self._parse_args(args)
5347 finally:
5348 # Regardless of success or failure of args parsing, we want to report
5349 # metrics, but only after logging has been initialized (if parsing
5350 # succeeded).
5351 global settings
5352 settings = Settings()
5353
5354 if not metrics.DISABLE_METRICS_COLLECTION:
5355 # GetViewVCUrl ultimately calls logging method.
5356 project_url = settings.GetViewVCUrl().strip('/+')
5357 if project_url in metrics_utils.KNOWN_PROJECT_URLS:
5358 metrics.collector.add('project_urls', [project_url])
5359
5360 def _parse_args(self, args=None):
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005361 # Create an optparse.Values object that will store only the actual passed
5362 # options, without the defaults.
5363 actual_options = optparse.Values()
5364 _, args = optparse.OptionParser.parse_args(self, args, actual_options)
5365 # Create an optparse.Values object with the default options.
5366 options = optparse.Values(self.get_default_values().__dict__)
5367 # Update it with the options passed by the user.
5368 options._update_careful(actual_options.__dict__)
5369 # Store the options passed by the user in an _actual_options attribute.
5370 # We store only the keys, and not the values, since the values can contain
5371 # arbitrary information, which might be PII.
Edward Lemur79d4f992019-11-11 23:49:02 +00005372 metrics.collector.add('arguments', list(actual_options.__dict__.keys()))
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005373
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005374 levels = [logging.WARNING, logging.INFO, logging.DEBUG]
Andrii Shyshkalov5b04a572017-01-23 17:44:41 +01005375 logging.basicConfig(
5376 level=levels[min(options.verbose, len(levels) - 1)],
5377 format='[%(levelname).1s%(asctime)s %(process)d %(thread)d '
5378 '%(filename)s] %(message)s')
Edward Lemur83bd7f42018-10-10 00:14:21 +00005379
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005380 return options, args
5381
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005382
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005383def main(argv):
maruel@chromium.org82798cb2012-02-23 18:16:12 +00005384 if sys.hexversion < 0x02060000:
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005385 print('\nYour Python version %s is unsupported, please upgrade.\n' %
vapiera7fbd5a2016-06-16 09:17:49 -07005386 (sys.version.split(' ', 1)[0],), file=sys.stderr)
maruel@chromium.org82798cb2012-02-23 18:16:12 +00005387 return 2
maruel@chromium.org2e23ce32013-05-07 12:42:28 +00005388
maruel@chromium.org39c0b222013-08-17 16:57:01 +00005389 colorize_CMDstatus_doc()
maruel@chromium.org0633fb42013-08-16 20:06:14 +00005390 dispatcher = subcommand.CommandDispatcher(__name__)
5391 try:
5392 return dispatcher.execute(OptionParser(), argv)
Edward Lemur5b929a42019-10-21 17:57:39 +00005393 except auth.LoginRequiredError as e:
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +00005394 DieWithError(str(e))
Edward Lemur79d4f992019-11-11 23:49:02 +00005395 except urllib.error.HTTPError as e:
maruel@chromium.org0633fb42013-08-16 20:06:14 +00005396 if e.code != 500:
5397 raise
5398 DieWithError(
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005399 ('App Engine is misbehaving and returned HTTP %d, again. Keep faith '
Quinten Yearsleyc4202212019-07-22 23:34:40 +00005400 'and retry or visit go/isgaeup.\n%s') % (e.code, str(e)))
sbc@chromium.org013731e2015-02-26 18:28:43 +00005401 return 0
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005402
5403
5404if __name__ == '__main__':
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005405 # These affect sys.stdout, so do it outside of main() to simplify mocks in
5406 # the unit tests.
maruel@chromium.org6f09cd92011-04-01 16:38:12 +00005407 fix_encoding.fix_encoding()
iannucci@chromium.org596cd5c2016-04-04 21:34:39 +00005408 setup_color.init()
Edward Lemur6f812e12018-07-31 22:45:57 +00005409 with metrics.collector.print_notice_and_exit():
sbc@chromium.org013731e2015-02-26 18:28:43 +00005410 sys.exit(main(sys.argv[1:]))