blob: 87904a900e7622acd12e44bdd6db069846be9e78 [file] [log] [blame]
Edward Lemur1f3bafb2019-10-08 17:56:33 +00001#!/usr/bin/env vpython
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +02002# Copyright (c) 2013 The Chromium Authors. All rights reserved.
maruel@chromium.org725f1c32011-04-01 20:24:54 +00003# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00006# Copyright (C) 2008 Evan Martin <martine@danga.com>
7
Andrii Shyshkalov03da1502018-10-15 03:42:34 +00008"""A git-command for integrating reviews on Gerrit."""
maruel@chromium.org725f1c32011-04-01 20:24:54 +00009
vapiera7fbd5a2016-06-16 09:17:49 -070010from __future__ import print_function
11
thakis@chromium.org3421c992014-11-02 02:20:32 +000012import base64
rmistry@google.com2dd99862015-06-22 12:22:18 +000013import collections
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +010014import datetime
Brian Sheedyb4307d52019-12-02 19:18:17 +000015import fnmatch
Edward Lemur202c5592019-10-21 22:44:52 +000016import httplib2
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +010017import itertools
maruel@chromium.org4f6852c2012-04-20 20:39:20 +000018import json
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000019import logging
calamity@chromium.orgcf197482016-04-29 20:15:53 +000020import multiprocessing
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000021import optparse
22import os
23import re
Andrii Shyshkalov353637c2017-03-14 16:52:18 +010024import shutil
ukai@chromium.org78c4b982012-02-14 02:20:26 +000025import stat
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000026import sys
Aaron Gable9a03ae02017-11-03 11:31:07 -070027import tempfile
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000028import textwrap
Edward Lemurfec80c42018-11-01 23:14:14 +000029import time
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +000030import uuid
thestig@chromium.org00858c82013-12-02 23:08:03 +000031import webbrowser
thakis@chromium.org3421c992014-11-02 02:20:32 +000032import zlib
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000033
maruel@chromium.org2e23ce32013-05-07 12:42:28 +000034from third_party import colorama
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +000035import auth
nick@chromium.org3ac1c4e2014-01-16 02:44:42 +000036import clang_format
maruel@chromium.org6f09cd92011-04-01 16:38:12 +000037import fix_encoding
maruel@chromium.org0e0436a2011-10-25 13:32:41 +000038import gclient_utils
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +000039import gerrit_util
iannucci@chromium.org9e849272014-04-04 00:31:55 +000040import git_common
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +000041import git_footers
Edward Lemur85153282020-02-14 22:06:29 +000042import git_new_branch
Edward Lemur5ba1e9c2018-07-23 18:19:02 +000043import metrics
Edward Lesmes93277a72018-10-18 22:04:26 +000044import metrics_utils
Edward Lesmeseeca9c62020-11-20 00:00:17 +000045import owners_client
iannucci@chromium.org9e849272014-04-04 00:31:55 +000046import owners_finder
Lei Zhangb8c62cf2020-07-15 20:09:37 +000047import presubmit_canned_checks
maruel@chromium.org2a74d372011-03-29 19:05:50 +000048import presubmit_support
49import scm
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +000050import setup_color
Francois Dorayd42c6812017-05-30 15:10:20 -040051import split_cl
maruel@chromium.org0633fb42013-08-16 20:06:14 +000052import subcommand
maruel@chromium.org32f9f5e2011-09-14 13:41:47 +000053import subprocess2
maruel@chromium.org2a74d372011-03-29 19:05:50 +000054import watchlists
55
Edward Lemur79d4f992019-11-11 23:49:02 +000056from third_party import six
57from six.moves import urllib
58
59
60if sys.version_info.major == 3:
61 basestring = (str,) # pylint: disable=redefined-builtin
62
Edward Lemurb9830242019-10-30 22:19:20 +000063
tandrii7400cf02016-06-21 08:48:07 -070064__version__ = '2.0'
maruel@chromium.org2a74d372011-03-29 19:05:50 +000065
Edward Lemur0f58ae42019-04-30 17:24:12 +000066# Traces for git push will be stored in a traces directory inside the
67# depot_tools checkout.
68DEPOT_TOOLS = os.path.dirname(os.path.abspath(__file__))
69TRACES_DIR = os.path.join(DEPOT_TOOLS, 'traces')
Edward Lemur227d5102020-02-25 23:45:35 +000070PRESUBMIT_SUPPORT = os.path.join(DEPOT_TOOLS, 'presubmit_support.py')
Edward Lemur0f58ae42019-04-30 17:24:12 +000071
72# When collecting traces, Git hashes will be reduced to 6 characters to reduce
73# the size after compression.
74GIT_HASH_RE = re.compile(r'\b([a-f0-9]{6})[a-f0-9]{34}\b', flags=re.I)
75# Used to redact the cookies from the gitcookies file.
76GITCOOKIES_REDACT_RE = re.compile(r'1/.*')
77
Edward Lemurd4d1ba42019-09-20 21:46:37 +000078MAX_ATTEMPTS = 3
79
Edward Lemur1b52d872019-05-09 21:12:12 +000080# The maximum number of traces we will keep. Multiplied by 3 since we store
81# 3 files per trace.
82MAX_TRACES = 3 * 10
Edward Lemur5737f022019-05-17 01:24:00 +000083# Message to be displayed to the user to inform where to find the traces for a
84# git-cl upload execution.
Edward Lemur0f58ae42019-04-30 17:24:12 +000085TRACES_MESSAGE = (
Edward Lemur1b52d872019-05-09 21:12:12 +000086'\n'
Edward Lemur5737f022019-05-17 01:24:00 +000087'The traces of this git-cl execution have been recorded at:\n'
Edward Lemur1b52d872019-05-09 21:12:12 +000088' %(trace_name)s-traces.zip\n'
Edward Lemur5737f022019-05-17 01:24:00 +000089'Copies of your gitcookies file and git config have been recorded at:\n'
90' %(trace_name)s-git-info.zip\n')
Edward Lemur1b52d872019-05-09 21:12:12 +000091# Format of the message to be stored as part of the traces to give developers a
92# better context when they go through traces.
93TRACES_README_FORMAT = (
94'Date: %(now)s\n'
95'\n'
96'Change: https://%(gerrit_host)s/q/%(change_id)s\n'
97'Title: %(title)s\n'
98'\n'
99'%(description)s\n'
100'\n'
101'Execution time: %(execution_time)s\n'
102'Exit code: %(exit_code)s\n') + TRACES_MESSAGE
Edward Lemur0f58ae42019-04-30 17:24:12 +0000103
Aaron Gable1bc7bfe2016-12-19 10:08:14 -0800104POSTUPSTREAM_HOOK = '.git/hooks/post-cl-land'
Henrique Ferreiroff249622019-11-28 23:19:29 +0000105DESCRIPTION_BACKUP_FILE = '.git_cl_description_backup'
rmistry@google.comc68112d2015-03-03 12:48:06 +0000106REFS_THAT_ALIAS_TO_OTHER_REFS = {
107 'refs/remotes/origin/lkgr': 'refs/remotes/origin/master',
108 'refs/remotes/origin/lkcr': 'refs/remotes/origin/master',
109}
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000110
Josip Sokcevicc39ab992020-09-24 20:09:15 +0000111DEFAULT_OLD_BRANCH = 'refs/remotes/origin/master'
112DEFAULT_NEW_BRANCH = 'refs/remotes/origin/main'
113
thestig@chromium.org44202a22014-03-11 19:22:18 +0000114# Valid extensions for files we want to lint.
115DEFAULT_LINT_REGEX = r"(.*\.cpp|.*\.cc|.*\.h)"
116DEFAULT_LINT_IGNORE_REGEX = r"$^"
117
Aiden Bennerc08566e2018-10-03 17:52:42 +0000118# File name for yapf style config files.
119YAPF_CONFIG_FILENAME = '.style.yapf'
120
Edward Lesmes50da7702020-03-30 19:23:43 +0000121# The issue, patchset and codereview server are stored on git config for each
122# branch under branch.<branch-name>.<config-key>.
123ISSUE_CONFIG_KEY = 'gerritissue'
124PATCHSET_CONFIG_KEY = 'gerritpatchset'
125CODEREVIEW_SERVER_CONFIG_KEY = 'gerritserver'
126
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000127# Shortcut since it quickly becomes repetitive.
maruel@chromium.org2e23ce32013-05-07 12:42:28 +0000128Fore = colorama.Fore
maruel@chromium.org90541732011-04-01 17:54:18 +0000129
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000130# Initialized in main()
131settings = None
132
Andrii Shyshkalov768f1d82016-12-08 15:10:13 +0100133# Used by tests/git_cl_test.py to add extra logging.
134# Inside the weirdly failing test, add this:
135# >>> self.mock(git_cl, '_IS_BEING_TESTED', True)
Quinten Yearsley0c62da92017-05-31 13:39:42 -0700136# And scroll up to see the stack trace printed.
Andrii Shyshkalov768f1d82016-12-08 15:10:13 +0100137_IS_BEING_TESTED = False
138
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000139
Andrii Shyshkalov1ee78cd2020-03-12 01:31:53 +0000140_KNOWN_GERRIT_TO_SHORT_URLS = {
141 'https://chrome-internal-review.googlesource.com': 'https://crrev.com/i',
142 'https://chromium-review.googlesource.com': 'https://crrev.com/c',
143}
Andrii Shyshkalov8aebb602020-04-16 22:10:27 +0000144assert len(_KNOWN_GERRIT_TO_SHORT_URLS) == len(
145 set(_KNOWN_GERRIT_TO_SHORT_URLS.values())), 'must have unique values'
Andrii Shyshkalov1ee78cd2020-03-12 01:31:53 +0000146
147
Josip Sokcevicf736cab2020-10-20 23:41:38 +0000148class GitPushError(Exception):
149 pass
150
151
Christopher Lamf732cd52017-01-24 12:40:11 +1100152def DieWithError(message, change_desc=None):
153 if change_desc:
154 SaveDescriptionBackup(change_desc)
Josip Sokcevic953278a2020-02-28 19:46:36 +0000155 print('\n ** Content of CL description **\n' +
156 '='*72 + '\n' +
157 change_desc.description + '\n' +
158 '='*72 + '\n')
Christopher Lamf732cd52017-01-24 12:40:11 +1100159
vapiera7fbd5a2016-06-16 09:17:49 -0700160 print(message, file=sys.stderr)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000161 sys.exit(1)
162
163
Christopher Lamf732cd52017-01-24 12:40:11 +1100164def SaveDescriptionBackup(change_desc):
Henrique Ferreiro5ae48172019-11-29 16:14:42 +0000165 backup_path = os.path.join(DEPOT_TOOLS, DESCRIPTION_BACKUP_FILE)
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000166 print('\nsaving CL description to %s\n' % backup_path)
Josip906bfde2020-01-31 22:38:49 +0000167 with open(backup_path, 'w') as backup_file:
168 backup_file.write(change_desc.description)
Christopher Lamf732cd52017-01-24 12:40:11 +1100169
170
thestig@chromium.org8b0553c2014-02-11 00:33:37 +0000171def GetNoGitPagerEnv():
172 env = os.environ.copy()
173 # 'cat' is a magical git string that disables pagers on all platforms.
174 env['GIT_PAGER'] = 'cat'
175 return env
176
vadimsh@chromium.org566a02a2014-08-22 01:34:13 +0000177
bsep@chromium.org627d9002016-04-29 00:00:52 +0000178def RunCommand(args, error_ok=False, error_message=None, shell=False, **kwargs):
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000179 try:
Edward Lemur79d4f992019-11-11 23:49:02 +0000180 stdout = subprocess2.check_output(args, shell=shell, **kwargs)
181 return stdout.decode('utf-8', 'replace')
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000182 except subprocess2.CalledProcessError as e:
183 logging.debug('Failed running %s', args)
maruel@chromium.org32f9f5e2011-09-14 13:41:47 +0000184 if not error_ok:
Alan Cutter594fd332020-07-21 23:55:27 +0000185 message = error_message or e.stdout.decode('utf-8', 'replace') or ''
186 DieWithError('Command "%s" failed.\n%s' % (' '.join(args), message))
Edward Lemur79d4f992019-11-11 23:49:02 +0000187 return e.stdout.decode('utf-8', 'replace')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000188
189
190def RunGit(args, **kwargs):
maruel@chromium.org32f9f5e2011-09-14 13:41:47 +0000191 """Returns stdout."""
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000192 return RunCommand(['git'] + args, **kwargs)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000193
194
enne@chromium.org3b7e15c2014-01-21 17:44:47 +0000195def RunGitWithCode(args, suppress_stderr=False):
maruel@chromium.org32f9f5e2011-09-14 13:41:47 +0000196 """Returns return code and stdout."""
tandrii5d48c322016-08-18 16:19:37 -0700197 if suppress_stderr:
Edward Lesmescf06cad2020-12-14 22:03:23 +0000198 stderr = subprocess2.DEVNULL
tandrii5d48c322016-08-18 16:19:37 -0700199 else:
200 stderr = sys.stderr
szager@chromium.org9bb85e22012-06-13 20:28:23 +0000201 try:
tandrii5d48c322016-08-18 16:19:37 -0700202 (out, _), code = subprocess2.communicate(['git'] + args,
203 env=GetNoGitPagerEnv(),
204 stdout=subprocess2.PIPE,
205 stderr=stderr)
Edward Lemur79d4f992019-11-11 23:49:02 +0000206 return code, out.decode('utf-8', 'replace')
tandrii5d48c322016-08-18 16:19:37 -0700207 except subprocess2.CalledProcessError as e:
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +0900208 logging.debug('Failed running %s', ['git'] + args)
Edward Lemur79d4f992019-11-11 23:49:02 +0000209 return e.returncode, e.stdout.decode('utf-8', 'replace')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000210
211
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000212def RunGitSilent(args):
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +0000213 """Returns stdout, suppresses stderr and ignores the return code."""
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000214 return RunGitWithCode(args, suppress_stderr=True)[1]
215
216
tandrii2a16b952016-10-19 07:09:44 -0700217def time_sleep(seconds):
218 # Use this so that it can be mocked in tests without interfering with python
219 # system machinery.
tandrii2a16b952016-10-19 07:09:44 -0700220 return time.sleep(seconds)
221
222
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000223def time_time():
224 # Use this so that it can be mocked in tests without interfering with python
225 # system machinery.
226 return time.time()
227
228
Edward Lemur1b52d872019-05-09 21:12:12 +0000229def datetime_now():
230 # Use this so that it can be mocked in tests without interfering with python
231 # system machinery.
232 return datetime.datetime.now()
233
234
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100235def confirm_or_exit(prefix='', action='confirm'):
236 """Asks user to press enter to continue or press Ctrl+C to abort."""
237 if not prefix or prefix.endswith('\n'):
238 mid = 'Press'
Andrii Shyshkalov353637c2017-03-14 16:52:18 +0100239 elif prefix.endswith('.') or prefix.endswith('?'):
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100240 mid = ' Press'
241 elif prefix.endswith(' '):
242 mid = 'press'
243 else:
244 mid = ' press'
Edward Lesmesae3586b2020-03-23 21:21:14 +0000245 gclient_utils.AskForData(
246 '%s%s Enter to %s, or Ctrl+C to abort' % (prefix, mid, action))
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100247
248
249def ask_for_explicit_yes(prompt):
Quinten Yearsleyd242ed72019-07-25 17:17:55 +0000250 """Returns whether user typed 'y' or 'yes' to confirm the given prompt."""
Edward Lesmesae3586b2020-03-23 21:21:14 +0000251 result = gclient_utils.AskForData(prompt + ' [Yes/No]: ').lower()
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100252 while True:
253 if 'yes'.startswith(result):
254 return True
255 if 'no'.startswith(result):
256 return False
Edward Lesmesae3586b2020-03-23 21:21:14 +0000257 result = gclient_utils.AskForData('Please, type yes or no: ').lower()
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100258
259
machenbach@chromium.org45453142015-09-15 08:45:22 +0000260def _get_properties_from_options(options):
Quinten Yearsleya19d3532019-09-30 21:54:39 +0000261 prop_list = getattr(options, 'properties', [])
262 properties = dict(x.split('=', 1) for x in prop_list)
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +0000263 for key, val in properties.items():
machenbach@chromium.org45453142015-09-15 08:45:22 +0000264 try:
265 properties[key] = json.loads(val)
266 except ValueError:
267 pass # If a value couldn't be evaluated, treat it as a string.
268 return properties
269
270
Edward Lemur4c707a22019-09-24 21:13:43 +0000271def _call_buildbucket(http, buildbucket_host, method, request):
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000272 """Calls a buildbucket v2 method and returns the parsed json response."""
273 headers = {
274 'Accept': 'application/json',
275 'Content-Type': 'application/json',
276 }
277 request = json.dumps(request)
278 url = 'https://%s/prpc/buildbucket.v2.Builds/%s' % (buildbucket_host, method)
279
280 logging.info('POST %s with %s' % (url, request))
281
282 attempts = 1
283 time_to_sleep = 1
284 while True:
285 response, content = http.request(url, 'POST', body=request, headers=headers)
286 if response.status == 200:
287 return json.loads(content[4:])
288 if attempts >= MAX_ATTEMPTS or 400 <= response.status < 500:
289 msg = '%s error when calling POST %s with %s: %s' % (
290 response.status, url, request, content)
291 raise BuildbucketResponseException(msg)
292 logging.debug(
293 '%s error when calling POST %s with %s. '
294 'Sleeping for %d seconds and retrying...' % (
295 response.status, url, request, time_to_sleep))
296 time.sleep(time_to_sleep)
297 time_to_sleep *= 2
298 attempts += 1
299
300 assert False, 'unreachable'
301
302
Edward Lemur6215c792019-10-03 21:59:05 +0000303def _parse_bucket(raw_bucket):
304 legacy = True
305 project = bucket = None
306 if '/' in raw_bucket:
307 legacy = False
308 project, bucket = raw_bucket.split('/', 1)
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000309 # Assume luci.<project>.<bucket>.
Edward Lemur6215c792019-10-03 21:59:05 +0000310 elif raw_bucket.startswith('luci.'):
311 project, bucket = raw_bucket[len('luci.'):].split('.', 1)
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000312 # Otherwise, assume prefix is also the project name.
Edward Lemur6215c792019-10-03 21:59:05 +0000313 elif '.' in raw_bucket:
314 project = raw_bucket.split('.')[0]
315 bucket = raw_bucket
316 # Legacy buckets.
Edward Lemur45768512020-03-02 19:03:14 +0000317 if legacy and project and bucket:
Edward Lemur6215c792019-10-03 21:59:05 +0000318 print('WARNING Please use %s/%s to specify the bucket.' % (project, bucket))
319 return project, bucket
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000320
321
Quinten Yearsley777660f2020-03-04 23:37:06 +0000322def _trigger_tryjobs(changelist, jobs, options, patchset):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000323 """Sends a request to Buildbucket to trigger tryjobs for a changelist.
qyearsley1fdfcb62016-10-24 13:22:03 -0700324
325 Args:
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000326 changelist: Changelist that the tryjobs are associated with.
Edward Lemur45768512020-03-02 19:03:14 +0000327 jobs: A list of (project, bucket, builder).
qyearsley1fdfcb62016-10-24 13:22:03 -0700328 options: Command-line options.
329 """
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000330 print('Scheduling jobs on:')
Edward Lemur45768512020-03-02 19:03:14 +0000331 for project, bucket, builder in jobs:
332 print(' %s/%s: %s' % (project, bucket, builder))
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000333 print('To see results here, run: git cl try-results')
334 print('To see results in browser, run: git cl web')
tandriide281ae2016-10-12 06:02:30 -0700335
Quinten Yearsley777660f2020-03-04 23:37:06 +0000336 requests = _make_tryjob_schedule_requests(changelist, jobs, options, patchset)
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +0000337 if not requests:
338 return
339
Edward Lemur5b929a42019-10-21 17:57:39 +0000340 http = auth.Authenticator().authorize(httplib2.Http())
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +0000341 http.force_exception_to_status_code = True
342
343 batch_request = {'requests': requests}
344 batch_response = _call_buildbucket(
345 http, options.buildbucket_host, 'Batch', batch_request)
346
347 errors = [
348 ' ' + response['error']['message']
349 for response in batch_response.get('responses', [])
350 if 'error' in response
351 ]
352 if errors:
353 raise BuildbucketResponseException(
354 'Failed to schedule builds for some bots:\n%s' % '\n'.join(errors))
355
356
Quinten Yearsley777660f2020-03-04 23:37:06 +0000357def _make_tryjob_schedule_requests(changelist, jobs, options, patchset):
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +0000358 """Constructs requests for Buildbucket to trigger tryjobs."""
Edward Lemurf0faf482019-09-25 20:40:17 +0000359 gerrit_changes = [changelist.GetGerritChange(patchset)]
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +0000360 shared_properties = {
361 'category': options.ensure_value('category', 'git_cl_try')
362 }
363 if options.ensure_value('clobber', False):
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000364 shared_properties['clobber'] = True
365 shared_properties.update(_get_properties_from_options(options) or {})
366
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +0000367 shared_tags = [{'key': 'user_agent', 'value': 'git_cl_try'}]
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +0000368 if options.ensure_value('retry_failed', False):
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +0000369 shared_tags.append({'key': 'retry_failed',
370 'value': '1'})
371
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000372 requests = []
Edward Lemur45768512020-03-02 19:03:14 +0000373 for (project, bucket, builder) in jobs:
374 properties = shared_properties.copy()
375 if 'presubmit' in builder.lower():
376 properties['dry_run'] = 'true'
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000377
Edward Lemur45768512020-03-02 19:03:14 +0000378 requests.append({
379 'scheduleBuild': {
380 'requestId': str(uuid.uuid4()),
381 'builder': {
382 'project': getattr(options, 'project', None) or project,
383 'bucket': bucket,
384 'builder': builder,
385 },
386 'gerritChanges': gerrit_changes,
387 'properties': properties,
388 'tags': [
389 {'key': 'builder', 'value': builder},
390 ] + shared_tags,
391 }
392 })
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000393
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +0000394 if options.ensure_value('revision', None):
Josip Sokcevic9011a5b2021-02-12 18:59:44 +0000395 remote, remote_branch = changelist.GetRemoteBranch()
Edward Lemur45768512020-03-02 19:03:14 +0000396 requests[-1]['scheduleBuild']['gitilesCommit'] = {
397 'host': gerrit_changes[0]['host'],
398 'project': gerrit_changes[0]['project'],
Josip Sokcevic9011a5b2021-02-12 18:59:44 +0000399 'id': options.revision,
400 'ref': GetTargetRef(remote, remote_branch, None)
Edward Lemur45768512020-03-02 19:03:14 +0000401 }
Anthony Polito1a5fe232020-01-24 23:17:52 +0000402
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +0000403 return requests
kjellander@chromium.org44424542015-06-02 18:35:29 +0000404
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000405
Quinten Yearsley777660f2020-03-04 23:37:06 +0000406def _fetch_tryjobs(changelist, buildbucket_host, patchset=None):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000407 """Fetches tryjobs from buildbucket.
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000408
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000409 Returns list of buildbucket.v2.Build with the try jobs for the changelist.
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000410 """
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +0000411 fields = ['id', 'builder', 'status', 'createTime', 'tags']
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000412 request = {
413 'predicate': {
414 'gerritChanges': [changelist.GetGerritChange(patchset)],
415 },
416 'fields': ','.join('builds.*.' + field for field in fields),
417 }
tandrii221ab252016-10-06 08:12:04 -0700418
Edward Lemur5b929a42019-10-21 17:57:39 +0000419 authenticator = auth.Authenticator()
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000420 if authenticator.has_cached_credentials():
421 http = authenticator.authorize(httplib2.Http())
422 else:
vapiera7fbd5a2016-06-16 09:17:49 -0700423 print('Warning: Some results might be missing because %s' %
424 # Get the message on how to login.
Andrii Shyshkalov2517afd2021-01-19 17:07:43 +0000425 (str(auth.LoginRequiredError()),))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000426 http = httplib2.Http()
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000427 http.force_exception_to_status_code = True
428
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000429 response = _call_buildbucket(http, buildbucket_host, 'SearchBuilds', request)
430 return response.get('builds', [])
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000431
Edward Lemur45768512020-03-02 19:03:14 +0000432
Edward Lemur5b929a42019-10-21 17:57:39 +0000433def _fetch_latest_builds(changelist, buildbucket_host, latest_patchset=None):
Quinten Yearsley983111f2019-09-26 17:18:48 +0000434 """Fetches builds from the latest patchset that has builds (within
435 the last few patchsets).
436
437 Args:
Quinten Yearsley983111f2019-09-26 17:18:48 +0000438 changelist (Changelist): The CL to fetch builds for
439 buildbucket_host (str): Buildbucket host, e.g. "cr-buildbucket.appspot.com"
Andrii Shyshkalov1ad58112019-10-08 01:46:14 +0000440 lastest_patchset(int|NoneType): the patchset to start fetching builds from.
441 If None (default), starts with the latest available patchset.
Quinten Yearsley983111f2019-09-26 17:18:48 +0000442 Returns:
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000443 A tuple (builds, patchset) where builds is a list of buildbucket.v2.Build,
444 and patchset is the patchset number where those builds came from.
Quinten Yearsley983111f2019-09-26 17:18:48 +0000445 """
446 assert buildbucket_host
447 assert changelist.GetIssue(), 'CL must be uploaded first'
448 assert changelist.GetCodereviewServer(), 'CL must be uploaded first'
Andrii Shyshkalov1ad58112019-10-08 01:46:14 +0000449 if latest_patchset is None:
450 assert changelist.GetMostRecentPatchset()
451 ps = changelist.GetMostRecentPatchset()
452 else:
453 assert latest_patchset > 0, latest_patchset
454 ps = latest_patchset
455
Quinten Yearsley983111f2019-09-26 17:18:48 +0000456 min_ps = max(1, ps - 5)
457 while ps >= min_ps:
Quinten Yearsley777660f2020-03-04 23:37:06 +0000458 builds = _fetch_tryjobs(changelist, buildbucket_host, patchset=ps)
Quinten Yearsley983111f2019-09-26 17:18:48 +0000459 if len(builds):
460 return builds, ps
461 ps -= 1
462 return [], 0
463
464
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +0000465def _filter_failed_for_retry(all_builds):
466 """Returns a list of buckets/builders that are worth retrying.
Quinten Yearsley983111f2019-09-26 17:18:48 +0000467
468 Args:
Quinten Yearsley777660f2020-03-04 23:37:06 +0000469 all_builds (list): Builds, in the format returned by _fetch_tryjobs,
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000470 i.e. a list of buildbucket.v2.Builds which includes status and builder
471 info.
Quinten Yearsley983111f2019-09-26 17:18:48 +0000472
473 Returns:
Edward Lemur45768512020-03-02 19:03:14 +0000474 A dict {(proj, bucket): [builders]}. This is the same format accepted by
Quinten Yearsley777660f2020-03-04 23:37:06 +0000475 _trigger_tryjobs.
Quinten Yearsley983111f2019-09-26 17:18:48 +0000476 """
Edward Lemur45768512020-03-02 19:03:14 +0000477 grouped = {}
478 for build in all_builds:
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +0000479 builder = build['builder']
Edward Lemur45768512020-03-02 19:03:14 +0000480 key = (builder['project'], builder['bucket'], builder['builder'])
481 grouped.setdefault(key, []).append(build)
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +0000482
Edward Lemur45768512020-03-02 19:03:14 +0000483 jobs = []
484 for (project, bucket, builder), builds in grouped.items():
485 if 'triggered' in builder:
486 print('WARNING: Not scheduling %s. Triggered bots require an initial job '
487 'from a parent. Please schedule a manual job for the parent '
488 'instead.')
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +0000489 continue
490 if any(b['status'] in ('STARTED', 'SCHEDULED') for b in builds):
491 # Don't retry if any are running.
492 continue
Edward Lemur45768512020-03-02 19:03:14 +0000493 # If builder had several builds, retry only if the last one failed.
494 # This is a bit different from CQ, which would re-use *any* SUCCESS-full
495 # build, but in case of retrying failed jobs retrying a flaky one makes
496 # sense.
497 builds = sorted(builds, key=lambda b: b['createTime'])
498 if builds[-1]['status'] not in ('FAILURE', 'INFRA_FAILURE'):
499 continue
500 # Don't retry experimental build previously triggered by CQ.
501 if any(t['key'] == 'cq_experimental' and t['value'] == 'true'
502 for t in builds[-1]['tags']):
503 continue
504 jobs.append((project, bucket, builder))
505
506 # Sort the jobs to make testing easier.
507 return sorted(jobs)
Quinten Yearsley983111f2019-09-26 17:18:48 +0000508
509
Quinten Yearsley777660f2020-03-04 23:37:06 +0000510def _print_tryjobs(options, builds):
511 """Prints nicely result of _fetch_tryjobs."""
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000512 if not builds:
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000513 print('No tryjobs scheduled.')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000514 return
515
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000516 longest_builder = max(len(b['builder']['builder']) for b in builds)
517 name_fmt = '{builder:<%d}' % longest_builder
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000518 if options.print_master:
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000519 longest_bucket = max(len(b['builder']['bucket']) for b in builds)
520 name_fmt = ('{bucket:>%d} ' % longest_bucket) + name_fmt
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000521
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000522 builds_by_status = {}
523 for b in builds:
524 builds_by_status.setdefault(b['status'], []).append({
525 'id': b['id'],
526 'name': name_fmt.format(
527 builder=b['builder']['builder'], bucket=b['builder']['bucket']),
528 })
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000529
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000530 sort_key = lambda b: (b['name'], b['id'])
531
532 def print_builds(title, builds, fmt=None, color=None):
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000533 """Pop matching builds from `builds` dict and print them."""
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000534 if not builds:
535 return
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000536
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000537 fmt = fmt or '{name} https://ci.chromium.org/b/{id}'
tandrii@chromium.org6cf98c82016-03-15 11:56:00 +0000538 if not options.color or color is None:
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000539 colorize = lambda x: x
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000540 else:
541 colorize = lambda x: '%s%s%s' % (color, x, Fore.RESET)
542
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000543 print(colorize(title))
544 for b in sorted(builds, key=sort_key):
545 print(' ', colorize(fmt.format(**b)))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000546
547 total = len(builds)
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000548 print_builds(
549 'Successes:', builds_by_status.pop('SUCCESS', []), color=Fore.GREEN)
550 print_builds(
551 'Infra Failures:', builds_by_status.pop('INFRA_FAILURE', []),
552 color=Fore.MAGENTA)
553 print_builds('Failures:', builds_by_status.pop('FAILURE', []), color=Fore.RED)
554 print_builds('Canceled:', builds_by_status.pop('CANCELED', []), fmt='{name}',
555 color=Fore.MAGENTA)
Andrii Shyshkalov792630c2020-10-19 16:47:44 +0000556 print_builds('Started:', builds_by_status.pop('STARTED', []),
557 color=Fore.YELLOW)
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000558 print_builds(
559 'Scheduled:', builds_by_status.pop('SCHEDULED', []), fmt='{name} id={id}')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000560 # The last section is just in case buildbucket API changes OR there is a bug.
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000561 print_builds(
562 'Other:', sum(builds_by_status.values(), []), fmt='{name} id={id}')
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000563 print('Total: %d tryjobs' % total)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000564
565
Aiden Bennerc08566e2018-10-03 17:52:42 +0000566def _ComputeDiffLineRanges(files, upstream_commit):
567 """Gets the changed line ranges for each file since upstream_commit.
568
569 Parses a git diff on provided files and returns a dict that maps a file name
570 to an ordered list of range tuples in the form (start_line, count).
571 Ranges are in the same format as a git diff.
572 """
573 # If files is empty then diff_output will be a full diff.
574 if len(files) == 0:
575 return {}
576
Aiden Benner6c18a1a2018-11-23 20:18:23 +0000577 # Take the git diff and find the line ranges where there are changes.
Jamie Madill3671a6a2019-10-24 15:13:21 +0000578 diff_cmd = BuildGitDiffCmd('-U0', upstream_commit, files, allow_prefix=True)
Aiden Bennerc08566e2018-10-03 17:52:42 +0000579 diff_output = RunGit(diff_cmd)
580
581 pattern = r'(?:^diff --git a/(?:.*) b/(.*))|(?:^@@.*\+(.*) @@)'
582 # 2 capture groups
583 # 0 == fname of diff file
584 # 1 == 'diff_start,diff_count' or 'diff_start'
585 # will match each of
586 # diff --git a/foo.foo b/foo.py
587 # @@ -12,2 +14,3 @@
588 # @@ -12,2 +17 @@
589 # running re.findall on the above string with pattern will give
590 # [('foo.py', ''), ('', '14,3'), ('', '17')]
591
592 curr_file = None
593 line_diffs = {}
594 for match in re.findall(pattern, diff_output, flags=re.MULTILINE):
595 if match[0] != '':
596 # Will match the second filename in diff --git a/a.py b/b.py.
597 curr_file = match[0]
598 line_diffs[curr_file] = []
599 else:
600 # Matches +14,3
601 if ',' in match[1]:
602 diff_start, diff_count = match[1].split(',')
603 else:
604 # Single line changes are of the form +12 instead of +12,1.
605 diff_start = match[1]
606 diff_count = 1
607
608 diff_start = int(diff_start)
609 diff_count = int(diff_count)
610
611 # If diff_count == 0 this is a removal we can ignore.
612 line_diffs[curr_file].append((diff_start, diff_count))
613
614 return line_diffs
615
616
Aiden Benner99b0ccb2018-11-20 19:53:31 +0000617def _FindYapfConfigFile(fpath, yapf_config_cache, top_dir=None):
Aiden Bennerc08566e2018-10-03 17:52:42 +0000618 """Checks if a yapf file is in any parent directory of fpath until top_dir.
619
Aiden Benner99b0ccb2018-11-20 19:53:31 +0000620 Recursively checks parent directories to find yapf file and if no yapf file
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000621 is found returns None. Uses yapf_config_cache as a cache for previously found
622 configs.
Aiden Bennerc08566e2018-10-03 17:52:42 +0000623 """
Aiden Benner99b0ccb2018-11-20 19:53:31 +0000624 fpath = os.path.abspath(fpath)
Aiden Bennerc08566e2018-10-03 17:52:42 +0000625 # Return result if we've already computed it.
626 if fpath in yapf_config_cache:
627 return yapf_config_cache[fpath]
628
Aiden Benner99b0ccb2018-11-20 19:53:31 +0000629 parent_dir = os.path.dirname(fpath)
630 if os.path.isfile(fpath):
631 ret = _FindYapfConfigFile(parent_dir, yapf_config_cache, top_dir)
Aiden Bennerc08566e2018-10-03 17:52:42 +0000632 else:
Aiden Benner99b0ccb2018-11-20 19:53:31 +0000633 # Otherwise fpath is a directory
634 yapf_file = os.path.join(fpath, YAPF_CONFIG_FILENAME)
635 if os.path.isfile(yapf_file):
636 ret = yapf_file
637 elif fpath == top_dir or parent_dir == fpath:
638 # If we're at the top level directory, or if we're at root
639 # there is no provided style.
640 ret = None
641 else:
642 # Otherwise recurse on the current directory.
643 ret = _FindYapfConfigFile(parent_dir, yapf_config_cache, top_dir)
Aiden Bennerc08566e2018-10-03 17:52:42 +0000644 yapf_config_cache[fpath] = ret
645 return ret
646
647
Brian Sheedyb4307d52019-12-02 19:18:17 +0000648def _GetYapfIgnorePatterns(top_dir):
649 """Returns all patterns in the .yapfignore file.
Brian Sheedy59b06a82019-10-14 17:03:29 +0000650
651 yapf is supposed to handle the ignoring of files listed in .yapfignore itself,
652 but this functionality appears to break when explicitly passing files to
653 yapf for formatting. According to
Josip Sokcevicc39ab992020-09-24 20:09:15 +0000654 https://github.com/google/yapf/blob/HEAD/README.rst#excluding-files-from-formatting-yapfignore,
Brian Sheedy59b06a82019-10-14 17:03:29 +0000655 the .yapfignore file should be in the directory that yapf is invoked from,
656 which we assume to be the top level directory in this case.
657
658 Args:
659 top_dir: The top level directory for the repository being formatted.
660
661 Returns:
Brian Sheedyb4307d52019-12-02 19:18:17 +0000662 A set of all fnmatch patterns to be ignored.
Brian Sheedy59b06a82019-10-14 17:03:29 +0000663 """
664 yapfignore_file = os.path.join(top_dir, '.yapfignore')
Brian Sheedyb4307d52019-12-02 19:18:17 +0000665 ignore_patterns = set()
Brian Sheedy59b06a82019-10-14 17:03:29 +0000666 if not os.path.exists(yapfignore_file):
Brian Sheedyb4307d52019-12-02 19:18:17 +0000667 return ignore_patterns
Brian Sheedy59b06a82019-10-14 17:03:29 +0000668
Brian Sheedyb4307d52019-12-02 19:18:17 +0000669 with open(yapfignore_file) as f:
670 for line in f.readlines():
671 stripped_line = line.strip()
672 # Comments and blank lines should be ignored.
673 if stripped_line.startswith('#') or stripped_line == '':
674 continue
675 ignore_patterns.add(stripped_line)
676 return ignore_patterns
677
678
679def _FilterYapfIgnoredFiles(filepaths, patterns):
680 """Filters out any filepaths that match any of the given patterns.
681
682 Args:
683 filepaths: An iterable of strings containing filepaths to filter.
684 patterns: An iterable of strings containing fnmatch patterns to filter on.
685
686 Returns:
687 A list of strings containing all the elements of |filepaths| that did not
688 match any of the patterns in |patterns|.
689 """
690 # Not inlined so that tests can use the same implementation.
691 return [f for f in filepaths
692 if not any(fnmatch.fnmatch(f, p) for p in patterns)]
Brian Sheedy59b06a82019-10-14 17:03:29 +0000693
694
Aaron Gable13101a62018-02-09 13:20:41 -0800695def print_stats(args):
maruel@chromium.org49e3d802012-07-18 23:54:45 +0000696 """Prints statistics about the change to the user."""
697 # --no-ext-diff is broken in some versions of Git, so try to work around
698 # this by overriding the environment (but there is still a problem if the
699 # git config key "diff.external" is used).
thestig@chromium.org8b0553c2014-02-11 00:33:37 +0000700 env = GetNoGitPagerEnv()
maruel@chromium.org49e3d802012-07-18 23:54:45 +0000701 if 'GIT_EXTERNAL_DIFF' in env:
702 del env['GIT_EXTERNAL_DIFF']
iannucci@chromium.org79540052012-10-19 23:15:26 +0000703
maruel@chromium.org49e3d802012-07-18 23:54:45 +0000704 return subprocess2.call(
Aaron Gable13101a62018-02-09 13:20:41 -0800705 ['git', 'diff', '--no-ext-diff', '--stat', '-l100000', '-C50'] + args,
Edward Lemur0db01f02019-11-12 22:01:51 +0000706 env=env)
maruel@chromium.org49e3d802012-07-18 23:54:45 +0000707
708
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000709class BuildbucketResponseException(Exception):
710 pass
711
712
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000713class Settings(object):
714 def __init__(self):
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000715 self.cc = None
thestig@chromium.org7a54e812014-02-11 19:57:22 +0000716 self.root = None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000717 self.tree_status_url = None
718 self.viewvc_url = None
719 self.updated = False
ukai@chromium.orge8077812012-02-03 03:41:46 +0000720 self.is_gerrit = None
bauerb@chromium.org54b400c2016-01-14 10:08:25 +0000721 self.squash_gerrit_uploads = None
tandrii@chromium.org28253532016-04-14 13:46:56 +0000722 self.gerrit_skip_ensure_authenticated = None
jbroman@chromium.org615a2622013-05-03 13:20:14 +0000723 self.git_editor = None
Jamie Madilldc4d19e2019-10-24 21:50:02 +0000724 self.format_full_by_default = None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000725
Edward Lemur26964072020-02-19 19:18:51 +0000726 def _LazyUpdateIfNeeded(self):
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000727 """Updates the settings from a codereview.settings file, if available."""
Edward Lemur26964072020-02-19 19:18:51 +0000728 if self.updated:
729 return
pgervais@chromium.org87884cc2014-01-03 22:23:41 +0000730
Edward Lemur26964072020-02-19 19:18:51 +0000731 # The only value that actually changes the behavior is
732 # autoupdate = "false". Everything else means "true".
733 autoupdate = (
734 scm.GIT.GetConfig(self.GetRoot(), 'rietveld.autoupdate', '').lower())
735
736 cr_settings_file = FindCodereviewSettingsFile()
737 if autoupdate != 'false' and cr_settings_file:
738 LoadCodereviewSettingsFromFile(cr_settings_file)
739 cr_settings_file.close()
740
741 self.updated = True
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000742
thestig@chromium.org7a54e812014-02-11 19:57:22 +0000743 @staticmethod
744 def GetRelativeRoot():
Edward Lesmes50da7702020-03-30 19:23:43 +0000745 return scm.GIT.GetCheckoutRoot('.')
thestig@chromium.org8b0553c2014-02-11 00:33:37 +0000746
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000747 def GetRoot(self):
thestig@chromium.org7a54e812014-02-11 19:57:22 +0000748 if self.root is None:
749 self.root = os.path.abspath(self.GetRelativeRoot())
750 return self.root
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000751
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000752 def GetTreeStatusUrl(self, error_ok=False):
753 if not self.tree_status_url:
Edward Lemur26964072020-02-19 19:18:51 +0000754 self.tree_status_url = self._GetConfig('rietveld.tree-status-url')
755 if self.tree_status_url is None and not error_ok:
756 DieWithError(
757 'You must configure your tree status URL by running '
758 '"git cl config".')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000759 return self.tree_status_url
760
761 def GetViewVCUrl(self):
762 if not self.viewvc_url:
Edward Lemur26964072020-02-19 19:18:51 +0000763 self.viewvc_url = self._GetConfig('rietveld.viewvc-url')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000764 return self.viewvc_url
765
rmistry@google.com90752582014-01-14 21:04:50 +0000766 def GetBugPrefix(self):
Edward Lemur26964072020-02-19 19:18:51 +0000767 return self._GetConfig('rietveld.bug-prefix')
rmistry@google.com78948ed2015-07-08 23:09:57 +0000768
rmistry@google.com5626a922015-02-26 14:03:30 +0000769 def GetRunPostUploadHook(self):
Edward Lemur61ea3072018-12-01 00:34:36 +0000770 run_post_upload_hook = self._GetConfig(
Edward Lemur26964072020-02-19 19:18:51 +0000771 'rietveld.run-post-upload-hook')
rmistry@google.com5626a922015-02-26 14:03:30 +0000772 return run_post_upload_hook == "True"
773
bauerb@chromium.orgae6df352011-04-06 17:40:39 +0000774 def GetDefaultCCList(self):
Edward Lemur26964072020-02-19 19:18:51 +0000775 return self._GetConfig('rietveld.cc')
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000776
bauerb@chromium.org54b400c2016-01-14 10:08:25 +0000777 def GetSquashGerritUploads(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000778 """Returns True if uploads to Gerrit should be squashed by default."""
bauerb@chromium.org54b400c2016-01-14 10:08:25 +0000779 if self.squash_gerrit_uploads is None:
Edward Lesmes4de54132020-05-05 19:41:33 +0000780 self.squash_gerrit_uploads = self.GetSquashGerritUploadsOverride()
781 if self.squash_gerrit_uploads is None:
Edward Lemur26964072020-02-19 19:18:51 +0000782 # Default is squash now (http://crbug.com/611892#c23).
783 self.squash_gerrit_uploads = self._GetConfig(
784 'gerrit.squash-uploads').lower() != 'false'
bauerb@chromium.org54b400c2016-01-14 10:08:25 +0000785 return self.squash_gerrit_uploads
786
Edward Lesmes4de54132020-05-05 19:41:33 +0000787 def GetSquashGerritUploadsOverride(self):
788 """Return True or False if codereview.settings should be overridden.
789
790 Returns None if no override has been defined.
791 """
792 # See also http://crbug.com/611892#c23
793 result = self._GetConfig('gerrit.override-squash-uploads').lower()
794 if result == 'true':
795 return True
796 if result == 'false':
797 return False
798 return None
799
tandrii@chromium.org28253532016-04-14 13:46:56 +0000800 def GetGerritSkipEnsureAuthenticated(self):
801 """Return True if EnsureAuthenticated should not be done for Gerrit
802 uploads."""
803 if self.gerrit_skip_ensure_authenticated is None:
Edward Lemur26964072020-02-19 19:18:51 +0000804 self.gerrit_skip_ensure_authenticated = self._GetConfig(
805 'gerrit.skip-ensure-authenticated').lower() == 'true'
tandrii@chromium.org28253532016-04-14 13:46:56 +0000806 return self.gerrit_skip_ensure_authenticated
807
jbroman@chromium.org615a2622013-05-03 13:20:14 +0000808 def GetGitEditor(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000809 """Returns the editor specified in the git config, or None if none is."""
jbroman@chromium.org615a2622013-05-03 13:20:14 +0000810 if self.git_editor is None:
Raul Tambre5a525872019-02-12 19:08:08 +0000811 # Git requires single quotes for paths with spaces. We need to replace
812 # them with double quotes for Windows to treat such paths as a single
813 # path.
Edward Lemur26964072020-02-19 19:18:51 +0000814 self.git_editor = self._GetConfig('core.editor').replace('\'', '"')
jbroman@chromium.org615a2622013-05-03 13:20:14 +0000815 return self.git_editor or None
816
thestig@chromium.org44202a22014-03-11 19:22:18 +0000817 def GetLintRegex(self):
Edward Lemur26964072020-02-19 19:18:51 +0000818 return self._GetConfig('rietveld.cpplint-regex', DEFAULT_LINT_REGEX)
thestig@chromium.org44202a22014-03-11 19:22:18 +0000819
820 def GetLintIgnoreRegex(self):
Edward Lemur26964072020-02-19 19:18:51 +0000821 return self._GetConfig(
822 'rietveld.cpplint-ignore-regex', DEFAULT_LINT_IGNORE_REGEX)
thestig@chromium.org44202a22014-03-11 19:22:18 +0000823
Jamie Madilldc4d19e2019-10-24 21:50:02 +0000824 def GetFormatFullByDefault(self):
825 if self.format_full_by_default is None:
826 result = (
827 RunGit(['config', '--bool', 'rietveld.format-full-by-default'],
828 error_ok=True).strip())
829 self.format_full_by_default = (result == 'true')
830 return self.format_full_by_default
831
Edward Lemur26964072020-02-19 19:18:51 +0000832 def _GetConfig(self, key, default=''):
833 self._LazyUpdateIfNeeded()
834 return scm.GIT.GetConfig(self.GetRoot(), key, default)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000835
836
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +0000837class _CQState(object):
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +0000838 """Enum for states of CL with respect to CQ."""
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +0000839 NONE = 'none'
840 DRY_RUN = 'dry_run'
841 COMMIT = 'commit'
842
843 ALL_STATES = [NONE, DRY_RUN, COMMIT]
844
845
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000846class _ParsedIssueNumberArgument(object):
Edward Lemurf38bc172019-09-03 21:02:13 +0000847 def __init__(self, issue=None, patchset=None, hostname=None):
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000848 self.issue = issue
849 self.patchset = patchset
850 self.hostname = hostname
851
852 @property
853 def valid(self):
854 return self.issue is not None
855
856
Edward Lemurf38bc172019-09-03 21:02:13 +0000857def ParseIssueNumberArgument(arg):
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000858 """Parses the issue argument and returns _ParsedIssueNumberArgument."""
859 fail_result = _ParsedIssueNumberArgument()
860
Edward Lemur678a6842019-10-03 22:25:05 +0000861 if isinstance(arg, int):
862 return _ParsedIssueNumberArgument(issue=arg)
863 if not isinstance(arg, basestring):
864 return fail_result
865
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000866 if arg.isdigit():
Edward Lemurf38bc172019-09-03 21:02:13 +0000867 return _ParsedIssueNumberArgument(issue=int(arg))
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000868 if not arg.startswith('http'):
869 return fail_result
Aaron Gableaee6c852017-06-26 12:49:01 -0700870
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000871 url = gclient_utils.UpgradeToHttps(arg)
Andrii Shyshkalov8aebb602020-04-16 22:10:27 +0000872 for gerrit_url, short_url in _KNOWN_GERRIT_TO_SHORT_URLS.items():
873 if url.startswith(short_url):
874 url = gerrit_url + url[len(short_url):]
875 break
876
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000877 try:
Edward Lemur79d4f992019-11-11 23:49:02 +0000878 parsed_url = urllib.parse.urlparse(url)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000879 except ValueError:
880 return fail_result
Andrii Shyshkalov28d840e2017-04-10 15:45:09 +0200881
Edward Lemur678a6842019-10-03 22:25:05 +0000882 # Gerrit's new UI is https://domain/c/project/+/<issue_number>[/[patchset]]
883 # But old GWT UI is https://domain/#/c/project/+/<issue_number>[/[patchset]]
884 # Short urls like https://domain/<issue_number> can be used, but don't allow
885 # specifying the patchset (you'd 404), but we allow that here.
886 if parsed_url.path == '/':
887 part = parsed_url.fragment
888 else:
889 part = parsed_url.path
890
891 match = re.match(
892 r'(/c(/.*/\+)?)?/(?P<issue>\d+)(/(?P<patchset>\d+)?/?)?$', part)
893 if not match:
894 return fail_result
895
896 issue = int(match.group('issue'))
897 patchset = match.group('patchset')
898 return _ParsedIssueNumberArgument(
899 issue=issue,
900 patchset=int(patchset) if patchset else None,
901 hostname=parsed_url.netloc)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000902
903
Andrii Shyshkalovb07575f2018-10-16 06:16:21 +0000904def _create_description_from_log(args):
905 """Pulls out the commit log to use as a base for the CL description."""
906 log_args = []
907 if len(args) == 1 and not args[0].endswith('.'):
908 log_args = [args[0] + '..']
909 elif len(args) == 1 and args[0].endswith('...'):
910 log_args = [args[0][:-1]]
911 elif len(args) == 2:
912 log_args = [args[0] + '..' + args[1]]
913 else:
914 log_args = args[:] # Hope for the best!
Manh Nguyene3644862020-08-05 18:25:46 +0000915 return RunGit(['log', '--pretty=format:%B%n'] + log_args)
Andrii Shyshkalovb07575f2018-10-16 06:16:21 +0000916
917
Aaron Gablea45ee112016-11-22 15:14:38 -0800918class GerritChangeNotExists(Exception):
tandriic2405f52016-10-10 08:13:15 -0700919 def __init__(self, issue, url):
920 self.issue = issue
921 self.url = url
Aaron Gablea45ee112016-11-22 15:14:38 -0800922 super(GerritChangeNotExists, self).__init__()
tandriic2405f52016-10-10 08:13:15 -0700923
924 def __str__(self):
Aaron Gablea45ee112016-11-22 15:14:38 -0800925 return 'change %s at %s does not exist or you have no access to it' % (
tandriic2405f52016-10-10 08:13:15 -0700926 self.issue, self.url)
927
928
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +0100929_CommentSummary = collections.namedtuple(
Quinten Yearsley0e617c02019-02-20 00:37:03 +0000930 '_CommentSummary', ['date', 'message', 'sender', 'autogenerated',
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +0100931 # TODO(tandrii): these two aren't known in Gerrit.
932 'approval', 'disapproval'])
933
934
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000935class Changelist(object):
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +0000936 """Changelist works with one changelist in local branch.
937
tandrii@chromium.org8930b3d2016-04-13 14:47:02 +0000938 Notes:
939 * Not safe for concurrent multi-{thread,process} use.
940 * Caches values from current branch. Therefore, re-use after branch change
tandrii5d48c322016-08-18 16:19:37 -0700941 with great care.
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +0000942 """
943
Sigurd Schneider9abde8c2020-11-17 08:44:52 +0000944 def __init__(self,
945 branchref=None,
946 issue=None,
947 codereview_host=None,
948 commit_date=None):
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +0000949 """Create a new ChangeList instance.
950
Edward Lemurf38bc172019-09-03 21:02:13 +0000951 **kwargs will be passed directly to Gerrit implementation.
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +0000952 """
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000953 # Poke settings so we get the "configure your server" message if necessary.
maruel@chromium.org379d07a2011-11-30 14:58:10 +0000954 global settings
955 if not settings:
956 # Happens when git_cl.py is used as a utility library.
957 settings = Settings()
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +0000958
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000959 self.branchref = branchref
960 if self.branchref:
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +0000961 assert branchref.startswith('refs/heads/')
Edward Lemur85153282020-02-14 22:06:29 +0000962 self.branch = scm.GIT.ShortBranchName(self.branchref)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000963 else:
964 self.branch = None
Sigurd Schneider9abde8c2020-11-17 08:44:52 +0000965 self.commit_date = commit_date
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000966 self.upstream_branch = None
maruel@chromium.org1033efd2013-07-23 23:25:09 +0000967 self.lookedup_issue = False
968 self.issue = issue or None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000969 self.description = None
maruel@chromium.org1033efd2013-07-23 23:25:09 +0000970 self.lookedup_patchset = False
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000971 self.patchset = None
bauerb@chromium.orgae6df352011-04-06 17:40:39 +0000972 self.cc = None
Daniel Cheng7227d212017-11-17 08:12:37 -0800973 self.more_cc = []
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +0000974 self._remote = None
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +0000975 self._cached_remote_url = (False, None) # (is_cached, value)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +0000976
Edward Lemur125d60a2019-09-13 18:25:41 +0000977 # Lazily cached values.
978 self._gerrit_host = None # e.g. chromium-review.googlesource.com
979 self._gerrit_server = None # e.g. https://chromium-review.googlesource.com
Edward Lesmese1576912021-02-16 21:53:34 +0000980 self._owners_client = None
Edward Lemur125d60a2019-09-13 18:25:41 +0000981 # Map from change number (issue) to its detail cache.
982 self._detail_cache = {}
983
984 if codereview_host is not None:
985 assert not codereview_host.startswith('https://'), codereview_host
986 self._gerrit_host = codereview_host
987 self._gerrit_server = 'https://%s' % codereview_host
bauerb@chromium.orgae6df352011-04-06 17:40:39 +0000988
Edward Lesmese1576912021-02-16 21:53:34 +0000989 @property
990 def owners_client(self):
991 if self._owners_client is None:
992 remote, remote_branch = self.GetRemoteBranch()
993 branch = GetTargetRef(remote, remote_branch, None)
994 self._owners_client = owners_client.GetCodeOwnersClient(
995 root=settings.GetRoot(),
Edward Lesmes1eaaab52021-03-02 23:52:54 +0000996 upstream=self.GetCommonAncestorWithUpstream(),
Edward Lesmese1576912021-02-16 21:53:34 +0000997 host=self.GetGerritHost(),
998 project=self.GetGerritProject(),
999 branch=branch)
1000 return self._owners_client
1001
bauerb@chromium.orgae6df352011-04-06 17:40:39 +00001002 def GetCCList(self):
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001003 """Returns the users cc'd on this CL.
bauerb@chromium.orgae6df352011-04-06 17:40:39 +00001004
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001005 The return value is a string suitable for passing to git cl with the --cc
1006 flag.
bauerb@chromium.orgae6df352011-04-06 17:40:39 +00001007 """
1008 if self.cc is None:
tyoshino@chromium.org99918ab2013-09-30 06:17:28 +00001009 base_cc = settings.GetDefaultCCList()
Daniel Cheng7227d212017-11-17 08:12:37 -08001010 more_cc = ','.join(self.more_cc)
bauerb@chromium.orgae6df352011-04-06 17:40:39 +00001011 self.cc = ','.join(filter(None, (base_cc, more_cc))) or ''
1012 return self.cc
1013
Daniel Cheng7227d212017-11-17 08:12:37 -08001014 def ExtendCC(self, more_cc):
1015 """Extends the list of users to cc on this CL based on the changed files."""
1016 self.more_cc.extend(more_cc)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001017
Sigurd Schneider9abde8c2020-11-17 08:44:52 +00001018 def GetCommitDate(self):
1019 """Returns the commit date as provided in the constructor"""
1020 return self.commit_date
1021
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001022 def GetBranch(self):
Josip Sokcevicc39ab992020-09-24 20:09:15 +00001023 """Returns the short branch name, e.g. 'main'."""
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001024 if not self.branch:
Edward Lemur85153282020-02-14 22:06:29 +00001025 branchref = scm.GIT.GetBranchRef(settings.GetRoot())
szager@chromium.orgd62c61f2014-10-20 22:33:21 +00001026 if not branchref:
1027 return None
1028 self.branchref = branchref
Edward Lemur85153282020-02-14 22:06:29 +00001029 self.branch = scm.GIT.ShortBranchName(self.branchref)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001030 return self.branch
1031
1032 def GetBranchRef(self):
Josip Sokcevicc39ab992020-09-24 20:09:15 +00001033 """Returns the full branch name, e.g. 'refs/heads/main'."""
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001034 self.GetBranch() # Poke the lazy loader.
1035 return self.branchref
1036
Edward Lemur85153282020-02-14 22:06:29 +00001037 def _GitGetBranchConfigValue(self, key, default=None):
1038 return scm.GIT.GetBranchConfig(
1039 settings.GetRoot(), self.GetBranch(), key, default)
tandrii5d48c322016-08-18 16:19:37 -07001040
Edward Lemur85153282020-02-14 22:06:29 +00001041 def _GitSetBranchConfigValue(self, key, value):
1042 action = 'set %s to %r' % (key, value)
1043 if not value:
1044 action = 'unset %s' % key
1045 assert self.GetBranch(), 'a branch is needed to ' + action
1046 return scm.GIT.SetBranchConfig(
1047 settings.GetRoot(), self.GetBranch(), key, value)
tandrii5d48c322016-08-18 16:19:37 -07001048
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001049 @staticmethod
1050 def FetchUpstreamTuple(branch):
pgervais@chromium.orgd6617f32013-11-19 00:34:54 +00001051 """Returns a tuple containing remote and remote ref,
Josip Sokcevicc39ab992020-09-24 20:09:15 +00001052 e.g. 'origin', 'refs/heads/main'
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001053 """
Edward Lemur15a9b8c2020-02-13 00:52:30 +00001054 remote, upstream_branch = scm.GIT.FetchUpstreamTuple(
1055 settings.GetRoot(), branch)
1056 if not remote or not upstream_branch:
1057 DieWithError(
1058 'Unable to determine default branch to diff against.\n'
Josip Sokcevicb038f722021-01-06 18:28:11 +00001059 'Verify this branch is set up to track another \n'
1060 '(via the --track argument to "git checkout -b ..."). \n'
1061 'or pass complete "git diff"-style arguments if supported, like\n'
1062 ' git cl upload origin/main\n')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001063
1064 return remote, upstream_branch
1065
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00001066 def GetCommonAncestorWithUpstream(self):
pgervais@chromium.org8ba38ff2015-06-11 21:41:25 +00001067 upstream_branch = self.GetUpstreamBranch()
Edward Lesmes50da7702020-03-30 19:23:43 +00001068 if not scm.GIT.IsValidRevision(settings.GetRoot(), upstream_branch):
pgervais@chromium.org8ba38ff2015-06-11 21:41:25 +00001069 DieWithError('The upstream for the current branch (%s) does not exist '
1070 'anymore.\nPlease fix it and try again.' % self.GetBranch())
iannucci@chromium.org9e849272014-04-04 00:31:55 +00001071 return git_common.get_or_create_merge_base(self.GetBranch(),
pgervais@chromium.org8ba38ff2015-06-11 21:41:25 +00001072 upstream_branch)
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00001073
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001074 def GetUpstreamBranch(self):
1075 if self.upstream_branch is None:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001076 remote, upstream_branch = self.FetchUpstreamTuple(self.GetBranch())
Raul Tambrefe1dbe12019-05-02 04:43:57 +00001077 if remote != '.':
mmoss@chromium.orge7585452014-08-24 01:41:11 +00001078 upstream_branch = upstream_branch.replace('refs/heads/',
1079 'refs/remotes/%s/' % remote)
1080 upstream_branch = upstream_branch.replace('refs/branch-heads/',
1081 'refs/remotes/branch-heads/')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001082 self.upstream_branch = upstream_branch
1083 return self.upstream_branch
1084
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001085 def GetRemoteBranch(self):
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001086 if not self._remote:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001087 remote, branch = None, self.GetBranch()
1088 seen_branches = set()
1089 while branch not in seen_branches:
1090 seen_branches.add(branch)
1091 remote, branch = self.FetchUpstreamTuple(branch)
Edward Lemur85153282020-02-14 22:06:29 +00001092 branch = scm.GIT.ShortBranchName(branch)
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001093 if remote != '.' or branch.startswith('refs/remotes'):
1094 break
1095 else:
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001096 remotes = RunGit(['remote'], error_ok=True).split()
1097 if len(remotes) == 1:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001098 remote, = remotes
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001099 elif 'origin' in remotes:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001100 remote = 'origin'
Gavin Make6a62332020-12-04 21:57:10 +00001101 logging.warning('Could not determine which remote this change is '
1102 'associated with, so defaulting to "%s".' %
1103 self._remote)
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001104 else:
Gavin Make6a62332020-12-04 21:57:10 +00001105 logging.warning('Could not determine which remote this change is '
1106 'associated with.')
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001107 branch = 'HEAD'
1108 if branch.startswith('refs/remotes'):
1109 self._remote = (remote, branch)
mmoss@chromium.orge7585452014-08-24 01:41:11 +00001110 elif branch.startswith('refs/branch-heads/'):
1111 self._remote = (remote, branch.replace('refs/', 'refs/remotes/'))
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001112 else:
1113 self._remote = (remote, 'refs/remotes/%s/%s' % (remote, branch))
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001114 return self._remote
1115
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001116 def GetRemoteUrl(self):
1117 """Return the configured remote URL, e.g. 'git://example.org/foo.git/'.
1118
1119 Returns None if there is no remote.
1120 """
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00001121 is_cached, value = self._cached_remote_url
1122 if is_cached:
1123 return value
1124
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001125 remote, _ = self.GetRemoteBranch()
Edward Lemur26964072020-02-19 19:18:51 +00001126 url = scm.GIT.GetConfig(settings.GetRoot(), 'remote.%s.url' % remote, '')
dyen@chromium.org2a13d4f2014-06-13 00:06:37 +00001127
Edward Lemur298f2cf2019-02-22 21:40:39 +00001128 # Check if the remote url can be parsed as an URL.
Edward Lemur79d4f992019-11-11 23:49:02 +00001129 host = urllib.parse.urlparse(url).netloc
Edward Lemur298f2cf2019-02-22 21:40:39 +00001130 if host:
1131 self._cached_remote_url = (True, url)
1132 return url
1133
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001134 # If it cannot be parsed as an url, assume it is a local directory,
1135 # probably a git cache.
Edward Lemur298f2cf2019-02-22 21:40:39 +00001136 logging.warning('"%s" doesn\'t appear to point to a git host. '
1137 'Interpreting it as a local directory.', url)
1138 if not os.path.isdir(url):
1139 logging.error(
Josip906bfde2020-01-31 22:38:49 +00001140 'Remote "%(remote)s" for branch "%(branch)s" points to "%(url)s", '
1141 'but it doesn\'t exist.',
1142 {'remote': remote, 'branch': self.GetBranch(), 'url': url})
Edward Lemur298f2cf2019-02-22 21:40:39 +00001143 return None
1144
1145 cache_path = url
Edward Lemur26964072020-02-19 19:18:51 +00001146 url = scm.GIT.GetConfig(url, 'remote.%s.url' % remote, '')
Edward Lemur298f2cf2019-02-22 21:40:39 +00001147
Edward Lemur79d4f992019-11-11 23:49:02 +00001148 host = urllib.parse.urlparse(url).netloc
Edward Lemur298f2cf2019-02-22 21:40:39 +00001149 if not host:
1150 logging.error(
1151 'Remote "%(remote)s" for branch "%(branch)s" points to '
1152 '"%(cache_path)s", but it is misconfigured.\n'
1153 '"%(cache_path)s" must be a git repo and must have a remote named '
1154 '"%(remote)s" pointing to the git host.', {
1155 'remote': remote,
1156 'cache_path': cache_path,
1157 'branch': self.GetBranch()})
1158 return None
1159
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00001160 self._cached_remote_url = (True, url)
dyen@chromium.org2a13d4f2014-06-13 00:06:37 +00001161 return url
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001162
tandrii@chromium.org87985d22016-03-24 17:33:33 +00001163 def GetIssue(self):
maruel@chromium.org52424302012-08-29 15:14:30 +00001164 """Returns the issue number as a int or None if not set."""
tandrii@chromium.org87985d22016-03-24 17:33:33 +00001165 if self.issue is None and not self.lookedup_issue:
Edward Lesmes50da7702020-03-30 19:23:43 +00001166 self.issue = self._GitGetBranchConfigValue(ISSUE_CONFIG_KEY)
Edward Lemur85153282020-02-14 22:06:29 +00001167 if self.issue is not None:
1168 self.issue = int(self.issue)
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001169 self.lookedup_issue = True
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001170 return self.issue
1171
Andrii Shyshkalov1ee78cd2020-03-12 01:31:53 +00001172 def GetIssueURL(self, short=False):
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001173 """Get the URL for a particular issue."""
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001174 issue = self.GetIssue()
1175 if not issue:
dbeam@chromium.org015fd3d2013-06-18 19:02:50 +00001176 return None
Andrii Shyshkalov1ee78cd2020-03-12 01:31:53 +00001177 server = self.GetCodereviewServer()
1178 if short:
1179 server = _KNOWN_GERRIT_TO_SHORT_URLS.get(server, server)
1180 return '%s/%s' % (server, issue)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001181
Edward Lemur6c6827c2020-02-06 21:15:18 +00001182 def FetchDescription(self, pretty=False):
1183 assert self.GetIssue(), 'issue is required to query Gerrit'
1184
Edward Lemur9aa1a962020-02-25 00:58:38 +00001185 if self.description is None:
Edward Lemur6c6827c2020-02-06 21:15:18 +00001186 data = self._GetChangeDetail(['CURRENT_REVISION', 'CURRENT_COMMIT'])
1187 current_rev = data['current_revision']
1188 self.description = data['revisions'][current_rev]['commit']['message']
Edward Lemur6c6827c2020-02-06 21:15:18 +00001189
1190 if not pretty:
1191 return self.description
1192
1193 # Set width to 72 columns + 2 space indent.
1194 wrapper = textwrap.TextWrapper(width=74, replace_whitespace=True)
1195 wrapper.initial_indent = wrapper.subsequent_indent = ' '
1196 lines = self.description.splitlines()
1197 return '\n'.join([wrapper.fill(line) for line in lines])
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001198
1199 def GetPatchset(self):
maruel@chromium.org52424302012-08-29 15:14:30 +00001200 """Returns the patchset number as a int or None if not set."""
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001201 if self.patchset is None and not self.lookedup_patchset:
Edward Lesmes50da7702020-03-30 19:23:43 +00001202 self.patchset = self._GitGetBranchConfigValue(PATCHSET_CONFIG_KEY)
Edward Lemur85153282020-02-14 22:06:29 +00001203 if self.patchset is not None:
1204 self.patchset = int(self.patchset)
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001205 self.lookedup_patchset = True
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001206 return self.patchset
1207
Edward Lemur9aa1a962020-02-25 00:58:38 +00001208 def GetAuthor(self):
1209 return scm.GIT.GetConfig(settings.GetRoot(), 'user.email')
1210
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001211 def SetPatchset(self, patchset):
tandrii5d48c322016-08-18 16:19:37 -07001212 """Set this branch's patchset. If patchset=0, clears the patchset."""
1213 assert self.GetBranch()
1214 if not patchset:
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001215 self.patchset = None
tandrii5d48c322016-08-18 16:19:37 -07001216 else:
1217 self.patchset = int(patchset)
Edward Lesmes50da7702020-03-30 19:23:43 +00001218 self._GitSetBranchConfigValue(PATCHSET_CONFIG_KEY, str(self.patchset))
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001219
tandrii@chromium.orga342c922016-03-16 07:08:25 +00001220 def SetIssue(self, issue=None):
tandrii5d48c322016-08-18 16:19:37 -07001221 """Set this branch's issue. If issue isn't given, clears the issue."""
1222 assert self.GetBranch()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001223 if issue:
tandrii5d48c322016-08-18 16:19:37 -07001224 issue = int(issue)
Edward Lesmes50da7702020-03-30 19:23:43 +00001225 self._GitSetBranchConfigValue(ISSUE_CONFIG_KEY, str(issue))
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001226 self.issue = issue
Edward Lemur125d60a2019-09-13 18:25:41 +00001227 codereview_server = self.GetCodereviewServer()
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001228 if codereview_server:
tandrii5d48c322016-08-18 16:19:37 -07001229 self._GitSetBranchConfigValue(
Edward Lesmes50da7702020-03-30 19:23:43 +00001230 CODEREVIEW_SERVER_CONFIG_KEY, codereview_server)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001231 else:
tandrii5d48c322016-08-18 16:19:37 -07001232 # Reset all of these just to be clean.
1233 reset_suffixes = [
1234 'last-upload-hash',
Edward Lesmes50da7702020-03-30 19:23:43 +00001235 ISSUE_CONFIG_KEY,
1236 PATCHSET_CONFIG_KEY,
1237 CODEREVIEW_SERVER_CONFIG_KEY,
1238 'gerritsquashhash',
1239 ]
tandrii5d48c322016-08-18 16:19:37 -07001240 for prop in reset_suffixes:
Edward Lemur85153282020-02-14 22:06:29 +00001241 try:
1242 self._GitSetBranchConfigValue(prop, None)
1243 except subprocess2.CalledProcessError:
1244 pass
Aaron Gableca01e2c2017-07-19 11:16:02 -07001245 msg = RunGit(['log', '-1', '--format=%B']).strip()
1246 if msg and git_footers.get_footer_change_id(msg):
1247 print('WARNING: The change patched into this branch has a Change-Id. '
1248 'Removing it.')
1249 RunGit(['commit', '--amend', '-m',
1250 git_footers.remove_footer(msg, 'Change-Id')])
Edward Lemurf38bc172019-09-03 21:02:13 +00001251 self.lookedup_issue = True
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001252 self.issue = None
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00001253 self.patchset = None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001254
Edward Lemur2c62b332020-03-12 22:12:33 +00001255 def GetAffectedFiles(self, upstream):
maruel@chromium.org2b38e9c2011-10-19 00:04:35 +00001256 try:
Edward Lemur2c62b332020-03-12 22:12:33 +00001257 return [f for _, f in scm.GIT.CaptureStatus(settings.GetRoot(), upstream)]
maruel@chromium.org2b38e9c2011-10-19 00:04:35 +00001258 except subprocess2.CalledProcessError:
1259 DieWithError(
pgervais@chromium.orgd6617f32013-11-19 00:34:54 +00001260 ('\nFailed to diff against upstream branch %s\n\n'
maruel@chromium.org2b38e9c2011-10-19 00:04:35 +00001261 'This branch probably doesn\'t exist anymore. To reset the\n'
1262 'tracking branch, please run\n'
Josip Sokcevicc39ab992020-09-24 20:09:15 +00001263 ' git branch --set-upstream-to origin/main %s\n'
1264 'or replace origin/main with the relevant branch') %
Edward Lemur2c62b332020-03-12 22:12:33 +00001265 (upstream, self.GetBranch()))
bauerb@chromium.org6fb99c62011-04-18 15:57:28 +00001266
dsansomee2d6fd92016-09-08 00:10:47 -07001267 def UpdateDescription(self, description, force=False):
Edward Lemur6c6827c2020-02-06 21:15:18 +00001268 assert self.GetIssue(), 'issue is required to update description'
1269
1270 if gerrit_util.HasPendingChangeEdit(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001271 self.GetGerritHost(), self._GerritChangeIdentifier()):
Edward Lemur6c6827c2020-02-06 21:15:18 +00001272 if not force:
1273 confirm_or_exit(
1274 'The description cannot be modified while the issue has a pending '
1275 'unpublished edit. Either publish the edit in the Gerrit web UI '
1276 'or delete it.\n\n', action='delete the unpublished edit')
1277
1278 gerrit_util.DeletePendingChangeEdit(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001279 self.GetGerritHost(), self._GerritChangeIdentifier())
Edward Lemur6c6827c2020-02-06 21:15:18 +00001280 gerrit_util.SetCommitMessage(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001281 self.GetGerritHost(), self._GerritChangeIdentifier(),
Edward Lemur6c6827c2020-02-06 21:15:18 +00001282 description, notify='NONE')
1283
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001284 self.description = description
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001285
Edward Lemur75526302020-02-27 22:31:05 +00001286 def _GetCommonPresubmitArgs(self, verbose, upstream):
Edward Lemur227d5102020-02-25 23:45:35 +00001287 args = [
Edward Lemur227d5102020-02-25 23:45:35 +00001288 '--root', settings.GetRoot(),
1289 '--upstream', upstream,
1290 ]
1291
1292 args.extend(['--verbose'] * verbose)
1293
Edward Lesmeseb1bd622021-03-01 19:54:07 +00001294 remote, remote_branch = self.GetRemoteBranch()
1295 target_ref = GetTargetRef(remote, remote_branch, None)
1296 args.extend(['--gerrit_url', self.GetCodereviewServer()])
1297 args.extend(['--gerrit_project', self.GetGerritProject()])
1298 args.extend(['--gerrit_branch', target_ref])
1299
Edward Lemur99df04e2020-03-05 19:39:43 +00001300 author = self.GetAuthor()
Edward Lemur227d5102020-02-25 23:45:35 +00001301 issue = self.GetIssue()
1302 patchset = self.GetPatchset()
Edward Lemur99df04e2020-03-05 19:39:43 +00001303 if author:
1304 args.extend(['--author', author])
Edward Lemur227d5102020-02-25 23:45:35 +00001305 if issue:
1306 args.extend(['--issue', str(issue)])
1307 if patchset:
1308 args.extend(['--patchset', str(patchset)])
Edward Lemur227d5102020-02-25 23:45:35 +00001309
Edward Lemur75526302020-02-27 22:31:05 +00001310 return args
1311
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00001312 def RunHook(self, committing, may_prompt, verbose, parallel, upstream,
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001313 description, all_files, resultdb=False, realm=None):
Edward Lemur75526302020-02-27 22:31:05 +00001314 """Calls sys.exit() if the hook fails; returns a HookResults otherwise."""
1315 args = self._GetCommonPresubmitArgs(verbose, upstream)
1316 args.append('--commit' if committing else '--upload')
Edward Lemur227d5102020-02-25 23:45:35 +00001317 if may_prompt:
1318 args.append('--may_prompt')
1319 if parallel:
1320 args.append('--parallel')
1321 if all_files:
1322 args.append('--all_files')
1323
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001324 if resultdb and not realm:
1325 # TODO (crbug.com/1113463): store realm somewhere and look it up so
1326 # it is not required to pass the realm flag
1327 print('Note: ResultDB reporting will NOT be performed because --realm'
1328 ' was not specified. To enable ResultDB, please run the command'
1329 ' again with the --realm argument to specify the LUCI realm.')
1330
1331 py2_results = self._RunPresubmit(args, resultdb, realm, description,
1332 use_python3=False)
1333 py3_results = self._RunPresubmit(args, resultdb, realm, description,
1334 use_python3=True)
1335 return self._MergePresubmitResults(py2_results, py3_results)
1336
1337 def _RunPresubmit(self, args, resultdb, realm, description, use_python3):
1338 args = args[:]
1339 vpython = 'vpython3' if use_python3 else 'vpython'
1340
Edward Lemur227d5102020-02-25 23:45:35 +00001341 with gclient_utils.temporary_file() as description_file:
1342 with gclient_utils.temporary_file() as json_output:
Edward Lemur1a83da12020-03-04 21:18:36 +00001343 gclient_utils.FileWrite(description_file, description)
Edward Lemur227d5102020-02-25 23:45:35 +00001344 args.extend(['--json_output', json_output])
1345 args.extend(['--description_file', description_file])
1346
1347 start = time_time()
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001348 cmd = [vpython, PRESUBMIT_SUPPORT] + args
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001349 if resultdb and realm:
1350 cmd = ['rdb', 'stream', '-new', '-realm', realm, '--'] + cmd
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00001351
1352 p = subprocess2.Popen(cmd)
Edward Lemur227d5102020-02-25 23:45:35 +00001353 exit_code = p.wait()
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00001354
Edward Lemur227d5102020-02-25 23:45:35 +00001355 metrics.collector.add_repeated('sub_commands', {
1356 'command': 'presubmit',
1357 'execution_time': time_time() - start,
1358 'exit_code': exit_code,
1359 })
1360
1361 if exit_code:
1362 sys.exit(exit_code)
1363
1364 json_results = gclient_utils.FileRead(json_output)
1365 return json.loads(json_results)
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001366
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001367 def _MergePresubmitResults(self, py2_results, py3_results):
1368 return {
1369 'more_cc': sorted(set(py2_results.get('more_cc', []) +
1370 py3_results.get('more_cc', []))),
1371 'errors': (
1372 py2_results.get('errors', []) + py3_results.get('errors', [])),
1373 'notifications': (
1374 py2_results.get('notifications', []) +
1375 py3_results.get('notifications', [])),
1376 'warnings': (
1377 py2_results.get('warnings', []) + py3_results.get('warnings', []))
1378 }
1379
Edward Lemur75526302020-02-27 22:31:05 +00001380 def RunPostUploadHook(self, verbose, upstream, description):
1381 args = self._GetCommonPresubmitArgs(verbose, upstream)
1382 args.append('--post_upload')
1383
1384 with gclient_utils.temporary_file() as description_file:
Edward Lemur1a83da12020-03-04 21:18:36 +00001385 gclient_utils.FileWrite(description_file, description)
Edward Lemur75526302020-02-27 22:31:05 +00001386 args.extend(['--description_file', description_file])
1387 p = subprocess2.Popen(['vpython', PRESUBMIT_SUPPORT] + args)
1388 p.wait()
1389
Edward Lemur5a644f82020-03-18 16:44:57 +00001390 def _GetDescriptionForUpload(self, options, git_diff_args, files):
1391 # Get description message for upload.
1392 if self.GetIssue():
1393 description = self.FetchDescription()
1394 elif options.message:
1395 description = options.message
1396 else:
1397 description = _create_description_from_log(git_diff_args)
1398 if options.title and options.squash:
Edward Lesmes0dd54822020-03-26 18:24:25 +00001399 description = options.title + '\n\n' + description
Edward Lemur5a644f82020-03-18 16:44:57 +00001400
1401 # Extract bug number from branch name.
1402 bug = options.bug
1403 fixed = options.fixed
1404 match = re.match(r'(?P<type>bug|fix(?:e[sd])?)[_-]?(?P<bugnum>\d+)',
1405 self.GetBranch())
1406 if not bug and not fixed and match:
1407 if match.group('type') == 'bug':
1408 bug = match.group('bugnum')
1409 else:
1410 fixed = match.group('bugnum')
1411
1412 change_description = ChangeDescription(description, bug, fixed)
1413
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001414 # Fill gaps in OWNERS coverage to tbrs/reviewers if requested.
1415 if options.add_owners_to:
1416 assert options.add_owners_to in ('TBR', 'R'), options.add_owners_to
Edward Lesmese1576912021-02-16 21:53:34 +00001417 status = self.owners_client.GetFilesApprovalStatus(
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001418 files, [], options.tbrs + options.reviewers)
1419 missing_files = [
1420 f for f in files
Edward Lesmese1576912021-02-16 21:53:34 +00001421 if status[f] == self._owners_client.INSUFFICIENT_REVIEWERS
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001422 ]
Edward Lesmese1576912021-02-16 21:53:34 +00001423 owners = self.owners_client.SuggestOwners(
1424 missing_files, exclude=[self.GetAuthor()])
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001425 if options.add_owners_to == 'TBR':
1426 assert isinstance(options.tbrs, list), options.tbrs
1427 options.tbrs.extend(owners)
1428 else:
1429 assert isinstance(options.reviewers, list), options.reviewers
1430 options.reviewers.extend(owners)
1431
Edward Lemur5a644f82020-03-18 16:44:57 +00001432 # Set the reviewer list now so that presubmit checks can access it.
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001433 if options.reviewers or options.tbrs:
1434 change_description.update_reviewers(options.reviewers, options.tbrs)
Edward Lemur5a644f82020-03-18 16:44:57 +00001435
1436 return change_description
1437
1438 def _GetTitleForUpload(self, options):
1439 # When not squashing, just return options.title.
1440 if not options.squash:
1441 return options.title
1442
1443 # On first upload, patchset title is always this string, while options.title
1444 # gets converted to first line of message.
1445 if not self.GetIssue():
1446 return 'Initial upload'
1447
1448 # When uploading subsequent patchsets, options.message is taken as the title
1449 # if options.title is not provided.
1450 if options.title:
1451 return options.title
1452 if options.message:
1453 return options.message.strip()
1454
1455 # Use the subject of the last commit as title by default.
Edward Lesmes50da7702020-03-30 19:23:43 +00001456 title = RunGit(['show', '-s', '--format=%s', 'HEAD']).strip()
Mario Bianuccicebfb4e2020-07-22 23:08:16 +00001457 if options.force or options.skip_title:
Edward Lemur5a644f82020-03-18 16:44:57 +00001458 return title
Edward Lesmesae3586b2020-03-23 21:21:14 +00001459 user_title = gclient_utils.AskForData('Title for patchset [%s]: ' % title)
1460 return user_title or title
Edward Lemur5a644f82020-03-18 16:44:57 +00001461
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001462 def CMDUpload(self, options, git_diff_args, orig_args):
1463 """Uploads a change to codereview."""
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001464 custom_cl_base = None
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001465 if git_diff_args:
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001466 custom_cl_base = base_branch = git_diff_args[0]
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001467 else:
1468 if self.GetBranch() is None:
1469 DieWithError('Can\'t upload from detached HEAD state. Get on a branch!')
1470
1471 # Default to diffing against common ancestor of upstream branch
1472 base_branch = self.GetCommonAncestorWithUpstream()
1473 git_diff_args = [base_branch, 'HEAD']
1474
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001475 # Fast best-effort checks to abort before running potentially expensive
1476 # hooks if uploading is likely to fail anyway. Passing these checks does
1477 # not guarantee that uploading will not fail.
Edward Lemur125d60a2019-09-13 18:25:41 +00001478 self.EnsureAuthenticated(force=options.force)
1479 self.EnsureCanUploadPatchset(force=options.force)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001480
1481 # Apply watchlists on upload.
Edward Lemur2c62b332020-03-12 22:12:33 +00001482 watchlist = watchlists.Watchlists(settings.GetRoot())
1483 files = self.GetAffectedFiles(base_branch)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001484 if not options.bypass_watchlists:
Daniel Cheng7227d212017-11-17 08:12:37 -08001485 self.ExtendCC(watchlist.GetWatchersForPaths(files))
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001486
Edward Lemur5a644f82020-03-18 16:44:57 +00001487 change_desc = self._GetDescriptionForUpload(options, git_diff_args, files)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001488 if not options.bypass_hooks:
Edward Lemur2c62b332020-03-12 22:12:33 +00001489 hook_results = self.RunHook(
1490 committing=False,
1491 may_prompt=not options.force,
1492 verbose=options.verbose,
1493 parallel=options.parallel,
1494 upstream=base_branch,
Edward Lemur5a644f82020-03-18 16:44:57 +00001495 description=change_desc.description,
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00001496 all_files=False,
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001497 resultdb=options.resultdb,
1498 realm=options.realm)
Edward Lemur227d5102020-02-25 23:45:35 +00001499 self.ExtendCC(hook_results['more_cc'])
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001500
Aaron Gable13101a62018-02-09 13:20:41 -08001501 print_stats(git_diff_args)
Edward Lemura12175c2020-03-09 16:58:26 +00001502 ret = self.CMDUploadChange(
Edward Lemur5a644f82020-03-18 16:44:57 +00001503 options, git_diff_args, custom_cl_base, change_desc)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001504 if not ret:
Edward Lemur85153282020-02-14 22:06:29 +00001505 self._GitSetBranchConfigValue(
Edward Lesmes50da7702020-03-30 19:23:43 +00001506 'last-upload-hash', scm.GIT.ResolveCommit(settings.GetRoot(), 'HEAD'))
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001507 # Run post upload hooks, if specified.
1508 if settings.GetRunPostUploadHook():
Edward Lemur5a644f82020-03-18 16:44:57 +00001509 self.RunPostUploadHook(
1510 options.verbose, base_branch, change_desc.description)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001511
1512 # Upload all dependencies if specified.
1513 if options.dependencies:
vapiera7fbd5a2016-06-16 09:17:49 -07001514 print()
1515 print('--dependencies has been specified.')
1516 print('All dependent local branches will be re-uploaded.')
1517 print()
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001518 # Remove the dependencies flag from args so that we do not end up in a
1519 # loop.
1520 orig_args.remove('--dependencies')
Jose Lopes3863fc52020-04-07 17:00:25 +00001521 ret = upload_branch_deps(self, orig_args, options.force)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001522 return ret
1523
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001524 def SetCQState(self, new_state):
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07001525 """Updates the CQ state for the latest patchset.
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001526
1527 Issue must have been already uploaded and known.
1528 """
1529 assert new_state in _CQState.ALL_STATES
1530 assert self.GetIssue()
qyearsley1fdfcb62016-10-24 13:22:03 -07001531 try:
Edward Lemur125d60a2019-09-13 18:25:41 +00001532 vote_map = {
1533 _CQState.NONE: 0,
1534 _CQState.DRY_RUN: 1,
1535 _CQState.COMMIT: 2,
1536 }
1537 labels = {'Commit-Queue': vote_map[new_state]}
1538 notify = False if new_state == _CQState.DRY_RUN else None
1539 gerrit_util.SetReview(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001540 self.GetGerritHost(), self._GerritChangeIdentifier(),
Edward Lemur125d60a2019-09-13 18:25:41 +00001541 labels=labels, notify=notify)
qyearsley1fdfcb62016-10-24 13:22:03 -07001542 return 0
1543 except KeyboardInterrupt:
1544 raise
1545 except:
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07001546 print('WARNING: Failed to %s.\n'
qyearsley1fdfcb62016-10-24 13:22:03 -07001547 'Either:\n'
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07001548 ' * Your project has no CQ,\n'
1549 ' * You don\'t have permission to change the CQ state,\n'
1550 ' * There\'s a bug in this code (see stack trace below).\n'
1551 'Consider specifying which bots to trigger manually or asking your '
1552 'project owners for permissions or contacting Chrome Infra at:\n'
1553 'https://www.chromium.org/infra\n\n' %
1554 ('cancel CQ' if new_state == _CQState.NONE else 'trigger CQ'))
qyearsley1fdfcb62016-10-24 13:22:03 -07001555 # Still raise exception so that stack trace is printed.
1556 raise
1557
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001558 def GetGerritHost(self):
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001559 # Lazy load of configs.
1560 self.GetCodereviewServer()
tandriie32e3ea2016-06-22 02:52:48 -07001561 if self._gerrit_host and '.' not in self._gerrit_host:
1562 # Abbreviated domain like "chromium" instead of chromium.googlesource.com.
1563 # This happens for internal stuff http://crbug.com/614312.
Edward Lemur79d4f992019-11-11 23:49:02 +00001564 parsed = urllib.parse.urlparse(self.GetRemoteUrl())
tandriie32e3ea2016-06-22 02:52:48 -07001565 if parsed.scheme == 'sso':
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001566 print('WARNING: using non-https URLs for remote is likely broken\n'
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001567 ' Your current remote is: %s' % self.GetRemoteUrl())
tandriie32e3ea2016-06-22 02:52:48 -07001568 self._gerrit_host = '%s.googlesource.com' % self._gerrit_host
1569 self._gerrit_server = 'https://%s' % self._gerrit_host
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001570 return self._gerrit_host
1571
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001572 def _GetGitHost(self):
1573 """Returns git host to be used when uploading change to Gerrit."""
Edward Lemur298f2cf2019-02-22 21:40:39 +00001574 remote_url = self.GetRemoteUrl()
1575 if not remote_url:
1576 return None
Edward Lemur79d4f992019-11-11 23:49:02 +00001577 return urllib.parse.urlparse(remote_url).netloc
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001578
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001579 def GetCodereviewServer(self):
1580 if not self._gerrit_server:
1581 # If we're on a branch then get the server potentially associated
1582 # with that branch.
Edward Lemur85153282020-02-14 22:06:29 +00001583 if self.GetIssue() and self.GetBranch():
tandrii5d48c322016-08-18 16:19:37 -07001584 self._gerrit_server = self._GitGetBranchConfigValue(
Edward Lesmes50da7702020-03-30 19:23:43 +00001585 CODEREVIEW_SERVER_CONFIG_KEY)
tandrii5d48c322016-08-18 16:19:37 -07001586 if self._gerrit_server:
Edward Lemur79d4f992019-11-11 23:49:02 +00001587 self._gerrit_host = urllib.parse.urlparse(self._gerrit_server).netloc
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001588 if not self._gerrit_server:
1589 # We assume repo to be hosted on Gerrit, and hence Gerrit server
1590 # has "-review" suffix for lowest level subdomain.
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001591 parts = self._GetGitHost().split('.')
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001592 parts[0] = parts[0] + '-review'
1593 self._gerrit_host = '.'.join(parts)
1594 self._gerrit_server = 'https://%s' % self._gerrit_host
1595 return self._gerrit_server
1596
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001597 def GetGerritProject(self):
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001598 """Returns Gerrit project name based on remote git URL."""
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00001599 remote_url = self.GetRemoteUrl()
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001600 if remote_url is None:
Josip906bfde2020-01-31 22:38:49 +00001601 logging.warning('can\'t detect Gerrit project.')
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00001602 return None
Edward Lemur79d4f992019-11-11 23:49:02 +00001603 project = urllib.parse.urlparse(remote_url).path.strip('/')
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001604 if project.endswith('.git'):
1605 project = project[:-len('.git')]
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00001606 # *.googlesource.com hosts ensure that Git/Gerrit projects don't start with
1607 # 'a/' prefix, because 'a/' prefix is used to force authentication in
1608 # gitiles/git-over-https protocol. E.g.,
1609 # https://chromium.googlesource.com/a/v8/v8 refers to the same repo/project
1610 # as
1611 # https://chromium.googlesource.com/v8/v8
1612 if project.startswith('a/'):
1613 project = project[len('a/'):]
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001614 return project
1615
Andrii Shyshkalovd06cc782018-08-23 17:24:19 +00001616 def _GerritChangeIdentifier(self):
1617 """Handy method for gerrit_util.ChangeIdentifier for a given CL.
1618
1619 Not to be confused by value of "Change-Id:" footer.
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00001620 If Gerrit project can be determined, this will speed up Gerrit HTTP API RPC.
Andrii Shyshkalovd06cc782018-08-23 17:24:19 +00001621 """
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001622 project = self.GetGerritProject()
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00001623 if project:
1624 return gerrit_util.ChangeIdentifier(project, self.GetIssue())
1625 # Fall back on still unique, but less efficient change number.
1626 return str(self.GetIssue())
Andrii Shyshkalovd06cc782018-08-23 17:24:19 +00001627
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01001628 def EnsureAuthenticated(self, force, refresh=None):
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001629 """Best effort check that user is authenticated with Gerrit server."""
tandrii@chromium.org28253532016-04-14 13:46:56 +00001630 if settings.GetGerritSkipEnsureAuthenticated():
1631 # For projects with unusual authentication schemes.
1632 # See http://crbug.com/603378.
1633 return
Vadim Shtayurab250ec12018-10-04 00:21:08 +00001634
1635 # Check presence of cookies only if using cookies-based auth method.
1636 cookie_auth = gerrit_util.Authenticator.get()
1637 if not isinstance(cookie_auth, gerrit_util.CookiesAuthenticator):
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001638 return
Vadim Shtayurab250ec12018-10-04 00:21:08 +00001639
Florian Mayerae510e82020-01-30 21:04:48 +00001640 remote_url = self.GetRemoteUrl()
1641 if remote_url is None:
Josip906bfde2020-01-31 22:38:49 +00001642 logging.warning('invalid remote')
Florian Mayerae510e82020-01-30 21:04:48 +00001643 return
1644 if urllib.parse.urlparse(remote_url).scheme != 'https':
Josip906bfde2020-01-31 22:38:49 +00001645 logging.warning('Ignoring branch %(branch)s with non-https remote '
1646 '%(remote)s', {
1647 'branch': self.branch,
1648 'remote': self.GetRemoteUrl()
1649 })
Daniel Chengcf6269b2019-05-18 01:02:12 +00001650 return
1651
Vadim Shtayurab250ec12018-10-04 00:21:08 +00001652 # Lazy-loader to identify Gerrit and Git hosts.
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001653 self.GetCodereviewServer()
1654 git_host = self._GetGitHost()
Edward Lemur298f2cf2019-02-22 21:40:39 +00001655 assert self._gerrit_server and self._gerrit_host and git_host
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001656
1657 gerrit_auth = cookie_auth.get_auth_header(self._gerrit_host)
1658 git_auth = cookie_auth.get_auth_header(git_host)
1659 if gerrit_auth and git_auth:
1660 if gerrit_auth == git_auth:
1661 return
Andrii Shyshkalov354e1d22017-06-09 19:31:33 +02001662 all_gsrc = cookie_auth.get_auth_header('d0esN0tEx1st.googlesource.com')
Raul Tambre80ee78e2019-05-06 22:41:05 +00001663 print(
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001664 'WARNING: You have different credentials for Gerrit and git hosts:\n'
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001665 ' %s\n'
1666 ' %s\n'
Andrii Shyshkalov51acef92017-04-11 17:19:59 +02001667 ' Consider running the following command:\n'
1668 ' git cl creds-check\n'
Andrii Shyshkalov354e1d22017-06-09 19:31:33 +02001669 ' %s\n'
Raul Tambre80ee78e2019-05-06 22:41:05 +00001670 ' %s' %
Andrii Shyshkalov51acef92017-04-11 17:19:59 +02001671 (git_host, self._gerrit_host,
Andrii Shyshkalov354e1d22017-06-09 19:31:33 +02001672 ('Hint: delete creds for .googlesource.com' if all_gsrc else ''),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001673 cookie_auth.get_new_password_message(git_host)))
1674 if not force:
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01001675 confirm_or_exit('If you know what you are doing', action='continue')
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001676 return
1677 else:
1678 missing = (
Anna Henningsen4e891442017-07-06 21:40:58 +02001679 ([] if gerrit_auth else [self._gerrit_host]) +
1680 ([] if git_auth else [git_host]))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001681 DieWithError('Credentials for the following hosts are required:\n'
1682 ' %s\n'
1683 'These are read from %s (or legacy %s)\n'
1684 '%s' % (
1685 '\n '.join(missing),
1686 cookie_auth.get_gitcookies_path(),
1687 cookie_auth.get_netrc_path(),
1688 cookie_auth.get_new_password_message(git_host)))
1689
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001690 def EnsureCanUploadPatchset(self, force):
Andrii Shyshkalov3e631422017-02-16 17:46:44 +01001691 if not self.GetIssue():
1692 return
1693
Andrii Shyshkalov3e631422017-02-16 17:46:44 +01001694 status = self._GetChangeDetail()['status']
1695 if status in ('MERGED', 'ABANDONED'):
1696 DieWithError('Change %s has been %s, new uploads are not allowed' %
1697 (self.GetIssueURL(),
1698 'submitted' if status == 'MERGED' else 'abandoned'))
1699
Vadim Shtayurab250ec12018-10-04 00:21:08 +00001700 # TODO(vadimsh): For some reason the chunk of code below was skipped if
1701 # 'is_gce' is True. I'm just refactoring it to be 'skip if not cookies'.
1702 # Apparently this check is not very important? Otherwise get_auth_email
1703 # could have been added to other implementations of Authenticator.
1704 cookies_auth = gerrit_util.Authenticator.get()
1705 if not isinstance(cookies_auth, gerrit_util.CookiesAuthenticator):
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001706 return
Vadim Shtayurab250ec12018-10-04 00:21:08 +00001707
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001708 cookies_user = cookies_auth.get_auth_email(self.GetGerritHost())
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001709 if self.GetIssueOwner() == cookies_user:
1710 return
1711 logging.debug('change %s owner is %s, cookies user is %s',
1712 self.GetIssue(), self.GetIssueOwner(), cookies_user)
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001713 # Maybe user has linked accounts or something like that,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001714 # so ask what Gerrit thinks of this user.
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001715 details = gerrit_util.GetAccountDetails(self.GetGerritHost(), 'self')
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001716 if details['email'] == self.GetIssueOwner():
1717 return
1718 if not force:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001719 print('WARNING: Change %s is owned by %s, but you authenticate to Gerrit '
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001720 'as %s.\n'
1721 'Uploading may fail due to lack of permissions.' %
1722 (self.GetIssue(), self.GetIssueOwner(), details['email']))
1723 confirm_or_exit(action='upload')
1724
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001725 def GetStatus(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001726 """Applies a rough heuristic to give a simple summary of an issue's review
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001727 or CQ status, assuming adherence to a common workflow.
1728
1729 Returns None if no issue for this branch, or one of the following keywords:
Aaron Gable9ab38c62017-04-06 14:36:33 -07001730 * 'error' - error from review tool (including deleted issues)
1731 * 'unsent' - no reviewers added
1732 * 'waiting' - waiting for review
1733 * 'reply' - waiting for uploader to reply to review
1734 * 'lgtm' - Code-Review label has been set
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +00001735 * 'dry-run' - dry-running in the CQ
1736 * 'commit' - in the CQ
Aaron Gable9ab38c62017-04-06 14:36:33 -07001737 * 'closed' - successfully submitted or abandoned
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001738 """
1739 if not self.GetIssue():
1740 return None
1741
1742 try:
Aaron Gable9ab38c62017-04-06 14:36:33 -07001743 data = self._GetChangeDetail([
1744 'DETAILED_LABELS', 'CURRENT_REVISION', 'SUBMITTABLE'])
Edward Lemur79d4f992019-11-11 23:49:02 +00001745 except GerritChangeNotExists:
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001746 return 'error'
1747
tandrii@chromium.org5e1bf382016-05-17 08:43:24 +00001748 if data['status'] in ('ABANDONED', 'MERGED'):
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001749 return 'closed'
1750
Andrii Shyshkalovb8268ca2019-04-03 23:33:44 +00001751 cq_label = data['labels'].get('Commit-Queue', {})
1752 max_cq_vote = 0
1753 for vote in cq_label.get('all', []):
1754 max_cq_vote = max(max_cq_vote, vote.get('value', 0))
1755 if max_cq_vote == 2:
Aaron Gable9ab38c62017-04-06 14:36:33 -07001756 return 'commit'
Andrii Shyshkalovb8268ca2019-04-03 23:33:44 +00001757 if max_cq_vote == 1:
1758 return 'dry-run'
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001759
Aaron Gable9ab38c62017-04-06 14:36:33 -07001760 if data['labels'].get('Code-Review', {}).get('approved'):
1761 return 'lgtm'
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001762
1763 if not data.get('reviewers', {}).get('REVIEWER', []):
1764 return 'unsent'
1765
Andrii Shyshkalov33e88a42017-01-27 14:45:30 +01001766 owner = data['owner'].get('_account_id')
Edward Lemur79d4f992019-11-11 23:49:02 +00001767 messages = sorted(data.get('messages', []), key=lambda m: m.get('date'))
Andrii Shyshkalov8aa9d622020-03-10 19:15:35 +00001768 while messages:
1769 m = messages.pop()
1770 if m.get('tag', '').startswith('autogenerated:cq:'):
Andrii Shyshkalov33e88a42017-01-27 14:45:30 +01001771 # Ignore replies from CQ.
1772 continue
Andrii Shyshkalov8aa9d622020-03-10 19:15:35 +00001773 if m.get('author', {}).get('_account_id') == owner:
Aaron Gable9ab38c62017-04-06 14:36:33 -07001774 # Most recent message was by owner.
1775 return 'waiting'
1776 else:
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001777 # Some reply from non-owner.
1778 return 'reply'
Aaron Gable9ab38c62017-04-06 14:36:33 -07001779
1780 # Somehow there are no messages even though there are reviewers.
1781 return 'unsent'
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001782
1783 def GetMostRecentPatchset(self):
Edward Lemur6c6827c2020-02-06 21:15:18 +00001784 if not self.GetIssue():
1785 return None
1786
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001787 data = self._GetChangeDetail(['CURRENT_REVISION'])
Aaron Gablee8856ee2017-12-07 12:41:46 -08001788 patchset = data['revisions'][data['current_revision']]['_number']
1789 self.SetPatchset(patchset)
1790 return patchset
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001791
Gavin Make61ccc52020-11-13 00:12:57 +00001792 def GetMostRecentDryRunPatchset(self):
1793 """Get patchsets equivalent to the most recent patchset and return
1794 the patchset with the latest dry run. If none have been dry run, return
1795 the latest patchset."""
1796 if not self.GetIssue():
1797 return None
1798
1799 data = self._GetChangeDetail(['ALL_REVISIONS'])
1800 patchset = data['revisions'][data['current_revision']]['_number']
1801 dry_run = set([int(m['_revision_number'])
1802 for m in data.get('messages', [])
1803 if m.get('tag', '').endswith('dry-run')])
1804
1805 for revision_info in sorted(data.get('revisions', {}).values(),
1806 key=lambda c: c['_number'], reverse=True):
1807 if revision_info['_number'] in dry_run:
1808 patchset = revision_info['_number']
1809 break
1810 if revision_info.get('kind', '') not in \
1811 ('NO_CHANGE', 'NO_CODE_CHANGE', 'TRIVIAL_REBASE'):
1812 break
1813 self.SetPatchset(patchset)
1814 return patchset
1815
Aaron Gable636b13f2017-07-14 10:42:48 -07001816 def AddComment(self, message, publish=None):
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00001817 gerrit_util.SetReview(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001818 self.GetGerritHost(), self._GerritChangeIdentifier(),
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00001819 msg=message, ready=publish)
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01001820
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001821 def GetCommentsSummary(self, readable=True):
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01001822 # DETAILED_ACCOUNTS is to get emails in accounts.
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001823 # CURRENT_REVISION is included to get the latest patchset so that
1824 # only the robot comments from the latest patchset can be shown.
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001825 messages = self._GetChangeDetail(
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001826 options=['MESSAGES', 'DETAILED_ACCOUNTS',
1827 'CURRENT_REVISION']).get('messages', [])
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001828 file_comments = gerrit_util.GetChangeComments(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001829 self.GetGerritHost(), self._GerritChangeIdentifier())
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001830 robot_file_comments = gerrit_util.GetChangeRobotComments(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001831 self.GetGerritHost(), self._GerritChangeIdentifier())
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001832
1833 # Add the robot comments onto the list of comments, but only
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00001834 # keep those that are from the latest patchset.
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001835 latest_patch_set = self.GetMostRecentPatchset()
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001836 for path, robot_comments in robot_file_comments.items():
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001837 line_comments = file_comments.setdefault(path, [])
1838 line_comments.extend(
1839 [c for c in robot_comments if c['patch_set'] == latest_patch_set])
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001840
1841 # Build dictionary of file comments for easy access and sorting later.
1842 # {author+date: {path: {patchset: {line: url+message}}}}
1843 comments = collections.defaultdict(
1844 lambda: collections.defaultdict(lambda: collections.defaultdict(dict)))
Andrii Shyshkalova3762a92020-11-25 10:20:42 +00001845
1846 server = self.GetCodereviewServer()
1847 if server in _KNOWN_GERRIT_TO_SHORT_URLS:
1848 # /c/ is automatically added by short URL server.
1849 url_prefix = '%s/%s' % (_KNOWN_GERRIT_TO_SHORT_URLS[server],
1850 self.GetIssue())
1851 else:
1852 url_prefix = '%s/c/%s' % (server, self.GetIssue())
1853
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001854 for path, line_comments in file_comments.items():
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001855 for comment in line_comments:
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001856 tag = comment.get('tag', '')
1857 if tag.startswith('autogenerated') and 'robot_id' not in comment:
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001858 continue
1859 key = (comment['author']['email'], comment['updated'])
1860 if comment.get('side', 'REVISION') == 'PARENT':
1861 patchset = 'Base'
1862 else:
1863 patchset = 'PS%d' % comment['patch_set']
1864 line = comment.get('line', 0)
Andrii Shyshkalova3762a92020-11-25 10:20:42 +00001865 url = ('%s/%s/%s#%s%s' %
1866 (url_prefix, comment['patch_set'], path,
1867 'b' if comment.get('side') == 'PARENT' else '',
1868 str(line) if line else ''))
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001869 comments[key][path][patchset][line] = (url, comment['message'])
1870
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001871 summaries = []
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001872 for msg in messages:
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001873 summary = self._BuildCommentSummary(msg, comments, readable)
1874 if summary:
1875 summaries.append(summary)
1876 return summaries
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001877
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001878 @staticmethod
1879 def _BuildCommentSummary(msg, comments, readable):
1880 key = (msg['author']['email'], msg['date'])
1881 # Don't bother showing autogenerated messages that don't have associated
1882 # file or line comments. this will filter out most autogenerated
1883 # messages, but will keep robot comments like those from Tricium.
1884 is_autogenerated = msg.get('tag', '').startswith('autogenerated')
1885 if is_autogenerated and not comments.get(key):
1886 return None
1887 message = msg['message']
1888 # Gerrit spits out nanoseconds.
1889 assert len(msg['date'].split('.')[-1]) == 9
1890 date = datetime.datetime.strptime(msg['date'][:-3],
1891 '%Y-%m-%d %H:%M:%S.%f')
1892 if key in comments:
1893 message += '\n'
1894 for path, patchsets in sorted(comments.get(key, {}).items()):
1895 if readable:
1896 message += '\n%s' % path
1897 for patchset, lines in sorted(patchsets.items()):
1898 for line, (url, content) in sorted(lines.items()):
1899 if line:
1900 line_str = 'Line %d' % line
1901 path_str = '%s:%d:' % (path, line)
1902 else:
1903 line_str = 'File comment'
1904 path_str = '%s:0:' % path
1905 if readable:
1906 message += '\n %s, %s: %s' % (patchset, line_str, url)
1907 message += '\n %s\n' % content
1908 else:
1909 message += '\n%s ' % path_str
1910 message += '\n%s\n' % content
1911
1912 return _CommentSummary(
1913 date=date,
1914 message=message,
1915 sender=msg['author']['email'],
1916 autogenerated=is_autogenerated,
1917 # These could be inferred from the text messages and correlated with
1918 # Code-Review label maximum, however this is not reliable.
1919 # Leaving as is until the need arises.
1920 approval=False,
1921 disapproval=False,
1922 )
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01001923
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001924 def CloseIssue(self):
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00001925 gerrit_util.AbandonChange(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001926 self.GetGerritHost(), self._GerritChangeIdentifier(), msg='')
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001927
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00001928 def SubmitIssue(self, wait_for_merge=True):
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00001929 gerrit_util.SubmitChange(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001930 self.GetGerritHost(), self._GerritChangeIdentifier(),
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00001931 wait_for_merge=wait_for_merge)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001932
Edward Lesmes7677e5c2020-02-19 20:39:03 +00001933 def _GetChangeDetail(self, options=None):
1934 """Returns details of associated Gerrit change and caching results."""
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00001935 options = options or []
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001936 assert self.GetIssue(), 'issue is required to query Gerrit'
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01001937
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01001938 # Optimization to avoid multiple RPCs:
Edward Lesmes7677e5c2020-02-19 20:39:03 +00001939 if 'CURRENT_REVISION' in options or 'ALL_REVISIONS' in options:
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01001940 options.append('CURRENT_COMMIT')
1941
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01001942 # Normalize issue and options for consistent keys in cache.
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001943 cache_key = str(self.GetIssue())
Edward Lesmes7677e5c2020-02-19 20:39:03 +00001944 options_set = frozenset(o.upper() for o in options)
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01001945
Edward Lesmes7677e5c2020-02-19 20:39:03 +00001946 for cached_options_set, data in self._detail_cache.get(cache_key, []):
1947 # Assumption: data fetched before with extra options is suitable
1948 # for return for a smaller set of options.
1949 # For example, if we cached data for
1950 # options=[CURRENT_REVISION, DETAILED_FOOTERS]
1951 # and request is for options=[CURRENT_REVISION],
1952 # THEN we can return prior cached data.
1953 if options_set.issubset(cached_options_set):
1954 return data
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01001955
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01001956 try:
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001957 data = gerrit_util.GetChangeDetail(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001958 self.GetGerritHost(), self._GerritChangeIdentifier(), options_set)
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01001959 except gerrit_util.GerritError as e:
1960 if e.http_status == 404:
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001961 raise GerritChangeNotExists(self.GetIssue(), self.GetCodereviewServer())
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01001962 raise
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01001963
Edward Lesmes7677e5c2020-02-19 20:39:03 +00001964 self._detail_cache.setdefault(cache_key, []).append((options_set, data))
tandriic2405f52016-10-10 08:13:15 -07001965 return data
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001966
Andrii Shyshkalovcc5f17e2018-08-22 23:35:59 +00001967 def _GetChangeCommit(self):
Andrii Shyshkalove2633162018-08-27 23:50:31 +00001968 assert self.GetIssue(), 'issue must be set to query Gerrit'
Aaron Gable6f5a8d92017-04-18 14:49:05 -07001969 try:
Andrii Shyshkalove2633162018-08-27 23:50:31 +00001970 data = gerrit_util.GetChangeCommit(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001971 self.GetGerritHost(), self._GerritChangeIdentifier())
Aaron Gable6f5a8d92017-04-18 14:49:05 -07001972 except gerrit_util.GerritError as e:
1973 if e.http_status == 404:
Andrii Shyshkalove2633162018-08-27 23:50:31 +00001974 raise GerritChangeNotExists(self.GetIssue(), self.GetCodereviewServer())
Aaron Gable6f5a8d92017-04-18 14:49:05 -07001975 raise
agable32978d92016-11-01 12:55:02 -07001976 return data
1977
Karen Qian40c19422019-03-13 21:28:29 +00001978 def _IsCqConfigured(self):
1979 detail = self._GetChangeDetail(['LABELS'])
Andrii Shyshkalov8effa4d2020-01-21 13:23:36 +00001980 return u'Commit-Queue' in detail.get('labels', {})
Karen Qian40c19422019-03-13 21:28:29 +00001981
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001982 def CMDLand(self, force, bypass_hooks, verbose, parallel, resultdb, realm):
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00001983 if git_common.is_dirty_git_tree('land'):
1984 return 1
Karen Qian40c19422019-03-13 21:28:29 +00001985
tandriid60367b2016-06-22 05:25:12 -07001986 detail = self._GetChangeDetail(['CURRENT_REVISION', 'LABELS'])
Karen Qian40c19422019-03-13 21:28:29 +00001987 if not force and self._IsCqConfigured():
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +00001988 confirm_or_exit('\nIt seems this repository has a CQ, '
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01001989 'which can test and land changes for you. '
1990 'Are you sure you wish to bypass it?\n',
1991 action='bypass CQ')
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00001992 differs = True
tandriic4344b52016-08-29 06:04:54 -07001993 last_upload = self._GitGetBranchConfigValue('gerritsquashhash')
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00001994 # Note: git diff outputs nothing if there is no diff.
1995 if not last_upload or RunGit(['diff', last_upload]).strip():
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001996 print('WARNING: Some changes from local branch haven\'t been uploaded.')
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00001997 else:
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00001998 if detail['current_revision'] == last_upload:
1999 differs = False
2000 else:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002001 print('WARNING: Local branch contents differ from latest uploaded '
2002 'patchset.')
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002003 if differs:
2004 if not force:
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002005 confirm_or_exit(
2006 'Do you want to submit latest Gerrit patchset and bypass hooks?\n',
2007 action='submit')
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002008 print('WARNING: Bypassing hooks and submitting latest uploaded patchset.')
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002009 elif not bypass_hooks:
Edward Lemur227d5102020-02-25 23:45:35 +00002010 upstream = self.GetCommonAncestorWithUpstream()
2011 if self.GetIssue():
2012 description = self.FetchDescription()
2013 else:
Edward Lemura12175c2020-03-09 16:58:26 +00002014 description = _create_description_from_log([upstream])
Edward Lemur227d5102020-02-25 23:45:35 +00002015 self.RunHook(
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002016 committing=True,
2017 may_prompt=not force,
2018 verbose=verbose,
Edward Lemur227d5102020-02-25 23:45:35 +00002019 parallel=parallel,
2020 upstream=upstream,
2021 description=description,
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00002022 all_files=False,
Saagar Sanghavi03b15132020-08-10 16:43:41 +00002023 resultdb=resultdb,
2024 realm=realm)
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002025
2026 self.SubmitIssue(wait_for_merge=True)
2027 print('Issue %s has been submitted.' % self.GetIssueURL())
agable32978d92016-11-01 12:55:02 -07002028 links = self._GetChangeCommit().get('web_links', [])
2029 for link in links:
Aaron Gable02cdbb42016-12-13 16:24:25 -08002030 if link.get('name') == 'gitiles' and link.get('url'):
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002031 print('Landed as: %s' % link.get('url'))
agable32978d92016-11-01 12:55:02 -07002032 break
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002033 return 0
2034
Bruce Dawsonf362f6f2021-02-18 23:15:17 +00002035 def CMDPatchWithParsedIssue(self, parsed_issue_arg, nocommit, force,
2036 newbranch):
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002037 assert parsed_issue_arg.valid
2038
Edward Lemur125d60a2019-09-13 18:25:41 +00002039 self.issue = parsed_issue_arg.issue
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002040
2041 if parsed_issue_arg.hostname:
2042 self._gerrit_host = parsed_issue_arg.hostname
2043 self._gerrit_server = 'https://%s' % self._gerrit_host
2044
tandriic2405f52016-10-10 08:13:15 -07002045 try:
2046 detail = self._GetChangeDetail(['ALL_REVISIONS'])
Aaron Gablea45ee112016-11-22 15:14:38 -08002047 except GerritChangeNotExists as e:
tandriic2405f52016-10-10 08:13:15 -07002048 DieWithError(str(e))
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002049
2050 if not parsed_issue_arg.patchset:
2051 # Use current revision by default.
2052 revision_info = detail['revisions'][detail['current_revision']]
2053 patchset = int(revision_info['_number'])
2054 else:
2055 patchset = parsed_issue_arg.patchset
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00002056 for revision_info in detail['revisions'].values():
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002057 if int(revision_info['_number']) == parsed_issue_arg.patchset:
2058 break
2059 else:
Aaron Gablea45ee112016-11-22 15:14:38 -08002060 DieWithError('Couldn\'t find patchset %i in change %i' %
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002061 (parsed_issue_arg.patchset, self.GetIssue()))
2062
Edward Lemur125d60a2019-09-13 18:25:41 +00002063 remote_url = self.GetRemoteUrl()
Aaron Gable697a91b2018-01-19 15:20:15 -08002064 if remote_url.endswith('.git'):
2065 remote_url = remote_url[:-len('.git')]
erikchen0d14d0d2018-08-28 18:57:09 +00002066 remote_url = remote_url.rstrip('/')
2067
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002068 fetch_info = revision_info['fetch']['http']
erikchen0d14d0d2018-08-28 18:57:09 +00002069 fetch_info['url'] = fetch_info['url'].rstrip('/')
Aaron Gable697a91b2018-01-19 15:20:15 -08002070
2071 if remote_url != fetch_info['url']:
2072 DieWithError('Trying to patch a change from %s but this repo appears '
2073 'to be %s.' % (fetch_info['url'], remote_url))
2074
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002075 RunGit(['fetch', fetch_info['url'], fetch_info['ref']])
Aaron Gable9387b4f2017-06-08 10:50:03 -07002076
Bruce Dawsonf362f6f2021-02-18 23:15:17 +00002077 # If we have created a new branch then do the "set issue" immediately in
2078 # case the cherry-pick fails, which happens when resolving conflicts.
2079 if newbranch:
2080 self.SetIssue(parsed_issue_arg.issue)
2081
Aaron Gable62619a32017-06-16 08:22:09 -07002082 if force:
2083 RunGit(['reset', '--hard', 'FETCH_HEAD'])
2084 print('Checked out commit for change %i patchset %i locally' %
2085 (parsed_issue_arg.issue, patchset))
Stefan Zager2d5f0392017-10-10 15:17:53 -07002086 elif nocommit:
2087 RunGit(['cherry-pick', '--no-commit', 'FETCH_HEAD'])
2088 print('Patch applied to index.')
Aaron Gable62619a32017-06-16 08:22:09 -07002089 else:
Aaron Gable9387b4f2017-06-08 10:50:03 -07002090 RunGit(['cherry-pick', 'FETCH_HEAD'])
2091 print('Committed patch for change %i patchset %i locally.' %
Aaron Gable62619a32017-06-16 08:22:09 -07002092 (parsed_issue_arg.issue, patchset))
2093 print('Note: this created a local commit which does not have '
2094 'the same hash as the one uploaded for review. This will make '
2095 'uploading changes based on top of this branch difficult.\n'
2096 'If you want to do that, use "git cl patch --force" instead.')
2097
Stefan Zagerd08043c2017-10-12 12:07:02 -07002098 if self.GetBranch():
2099 self.SetIssue(parsed_issue_arg.issue)
2100 self.SetPatchset(patchset)
Edward Lesmes50da7702020-03-30 19:23:43 +00002101 fetched_hash = scm.GIT.ResolveCommit(settings.GetRoot(), 'FETCH_HEAD')
Stefan Zagerd08043c2017-10-12 12:07:02 -07002102 self._GitSetBranchConfigValue('last-upload-hash', fetched_hash)
2103 self._GitSetBranchConfigValue('gerritsquashhash', fetched_hash)
2104 else:
2105 print('WARNING: You are in detached HEAD state.\n'
2106 'The patch has been applied to your checkout, but you will not be '
2107 'able to upload a new patch set to the gerrit issue.\n'
2108 'Try using the \'-b\' option if you would like to work on a '
2109 'branch and/or upload a new patch set.')
2110
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002111 return 0
2112
tandrii16e0b4e2016-06-07 10:34:28 -07002113 def _GerritCommitMsgHookCheck(self, offer_removal):
2114 hook = os.path.join(settings.GetRoot(), '.git', 'hooks', 'commit-msg')
2115 if not os.path.exists(hook):
2116 return
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002117 # Crude attempt to distinguish Gerrit Codereview hook from a potentially
2118 # custom developer-made one.
tandrii16e0b4e2016-06-07 10:34:28 -07002119 data = gclient_utils.FileRead(hook)
2120 if not('From Gerrit Code Review' in data and 'add_ChangeId()' in data):
2121 return
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002122 print('WARNING: You have Gerrit commit-msg hook installed.\n'
qyearsley12fa6ff2016-08-24 09:18:40 -07002123 'It is not necessary for uploading with git cl in squash mode, '
tandrii16e0b4e2016-06-07 10:34:28 -07002124 'and may interfere with it in subtle ways.\n'
2125 'We recommend you remove the commit-msg hook.')
2126 if offer_removal:
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002127 if ask_for_explicit_yes('Do you want to remove it now?'):
tandrii16e0b4e2016-06-07 10:34:28 -07002128 gclient_utils.rm_file_or_tree(hook)
2129 print('Gerrit commit-msg hook removed.')
2130 else:
2131 print('OK, will keep Gerrit commit-msg hook in place.')
2132
Edward Lemur1b52d872019-05-09 21:12:12 +00002133 def _CleanUpOldTraces(self):
2134 """Keep only the last |MAX_TRACES| traces."""
2135 try:
2136 traces = sorted([
2137 os.path.join(TRACES_DIR, f)
2138 for f in os.listdir(TRACES_DIR)
2139 if (os.path.isfile(os.path.join(TRACES_DIR, f))
2140 and not f.startswith('tmp'))
2141 ])
2142 traces_to_delete = traces[:-MAX_TRACES]
2143 for trace in traces_to_delete:
Daniel Chengcf6269b2019-05-18 01:02:12 +00002144 os.remove(trace)
Edward Lemur1b52d872019-05-09 21:12:12 +00002145 except OSError:
2146 print('WARNING: Failed to remove old git traces from\n'
2147 ' %s'
2148 'Consider removing them manually.' % TRACES_DIR)
Edward Lemurdc8e23d2019-05-07 00:45:48 +00002149
Edward Lemur5737f022019-05-17 01:24:00 +00002150 def _WriteGitPushTraces(self, trace_name, traces_dir, git_push_metadata):
Edward Lemur1b52d872019-05-09 21:12:12 +00002151 """Zip and write the git push traces stored in traces_dir."""
2152 gclient_utils.safe_makedirs(TRACES_DIR)
Edward Lemur1b52d872019-05-09 21:12:12 +00002153 traces_zip = trace_name + '-traces'
2154 traces_readme = trace_name + '-README'
Michael Mosse7f0b4c2019-05-08 04:36:24 +00002155 # Create a temporary dir to store git config and gitcookies in. It will be
2156 # compressed and stored next to the traces.
2157 git_info_dir = tempfile.mkdtemp()
Edward Lemur1b52d872019-05-09 21:12:12 +00002158 git_info_zip = trace_name + '-git-info'
2159
Josip Sokcevic5e18b602020-04-23 21:47:00 +00002160 git_push_metadata['now'] = datetime_now().strftime('%Y-%m-%dT%H:%M:%S.%f')
sangwoo.ko7a614332019-05-22 02:46:19 +00002161
Edward Lemur1b52d872019-05-09 21:12:12 +00002162 git_push_metadata['trace_name'] = trace_name
2163 gclient_utils.FileWrite(
2164 traces_readme, TRACES_README_FORMAT % git_push_metadata)
2165
2166 # Keep only the first 6 characters of the git hashes on the packet
2167 # trace. This greatly decreases size after compression.
2168 packet_traces = os.path.join(traces_dir, 'trace-packet')
2169 if os.path.isfile(packet_traces):
2170 contents = gclient_utils.FileRead(packet_traces)
2171 gclient_utils.FileWrite(
2172 packet_traces, GIT_HASH_RE.sub(r'\1', contents))
2173 shutil.make_archive(traces_zip, 'zip', traces_dir)
2174
2175 # Collect and compress the git config and gitcookies.
2176 git_config = RunGit(['config', '-l'])
2177 gclient_utils.FileWrite(
2178 os.path.join(git_info_dir, 'git-config'),
2179 git_config)
2180
2181 cookie_auth = gerrit_util.Authenticator.get()
2182 if isinstance(cookie_auth, gerrit_util.CookiesAuthenticator):
2183 gitcookies_path = cookie_auth.get_gitcookies_path()
2184 if os.path.isfile(gitcookies_path):
2185 gitcookies = gclient_utils.FileRead(gitcookies_path)
2186 gclient_utils.FileWrite(
2187 os.path.join(git_info_dir, 'gitcookies'),
2188 GITCOOKIES_REDACT_RE.sub('REDACTED', gitcookies))
2189 shutil.make_archive(git_info_zip, 'zip', git_info_dir)
2190
Edward Lemur1b52d872019-05-09 21:12:12 +00002191 gclient_utils.rmtree(git_info_dir)
2192
Josip Sokcevicf2cfd3d2021-03-30 18:39:18 +00002193 def _RunGitPushWithTraces(self,
2194 refspec,
2195 refspec_opts,
2196 git_push_metadata,
2197 git_push_options=None):
Edward Lemur1b52d872019-05-09 21:12:12 +00002198 """Run git push and collect the traces resulting from the execution."""
2199 # Create a temporary directory to store traces in. Traces will be compressed
2200 # and stored in a 'traces' dir inside depot_tools.
2201 traces_dir = tempfile.mkdtemp()
Edward Lemur5737f022019-05-17 01:24:00 +00002202 trace_name = os.path.join(
2203 TRACES_DIR, datetime_now().strftime('%Y%m%dT%H%M%S.%f'))
Edward Lemur0f58ae42019-04-30 17:24:12 +00002204
2205 env = os.environ.copy()
2206 env['GIT_REDACT_COOKIES'] = 'o,SSO,GSSO_Uberproxy'
2207 env['GIT_TR2_EVENT'] = os.path.join(traces_dir, 'tr2-event')
Jonathan Nieder9779b142019-05-29 23:19:29 +00002208 env['GIT_TRACE2_EVENT'] = os.path.join(traces_dir, 'tr2-event')
Edward Lemur0f58ae42019-04-30 17:24:12 +00002209 env['GIT_TRACE_CURL'] = os.path.join(traces_dir, 'trace-curl')
2210 env['GIT_TRACE_CURL_NO_DATA'] = '1'
2211 env['GIT_TRACE_PACKET'] = os.path.join(traces_dir, 'trace-packet')
2212
2213 try:
2214 push_returncode = 0
Edward Lemur1b52d872019-05-09 21:12:12 +00002215 remote_url = self.GetRemoteUrl()
Edward Lemur0f58ae42019-04-30 17:24:12 +00002216 before_push = time_time()
Josip Sokcevicf2cfd3d2021-03-30 18:39:18 +00002217 push_cmd = ['git', 'push', remote_url, refspec]
2218 if git_push_options:
2219 for opt in git_push_options:
2220 push_cmd.extend(['-o', opt])
2221
Edward Lemur0f58ae42019-04-30 17:24:12 +00002222 push_stdout = gclient_utils.CheckCallAndFilter(
Josip Sokcevicf2cfd3d2021-03-30 18:39:18 +00002223 push_cmd,
Edward Lemur0f58ae42019-04-30 17:24:12 +00002224 env=env,
2225 print_stdout=True,
2226 # Flush after every line: useful for seeing progress when running as
2227 # recipe.
2228 filter_fn=lambda _: sys.stdout.flush())
Edward Lemur79d4f992019-11-11 23:49:02 +00002229 push_stdout = push_stdout.decode('utf-8', 'replace')
Edward Lemur0f58ae42019-04-30 17:24:12 +00002230 except subprocess2.CalledProcessError as e:
2231 push_returncode = e.returncode
Josip Sokcevicf736cab2020-10-20 23:41:38 +00002232 raise GitPushError(
2233 'Failed to create a change. Please examine output above for the '
2234 'reason of the failure.\n'
Josip Sokcevic7386a1e2021-02-12 19:00:34 +00002235 'For emergencies, Googlers can escalate to '
2236 'go/gob-support or go/notify#gob\n'
Josip Sokcevicf736cab2020-10-20 23:41:38 +00002237 'Hint: run command below to diagnose common Git/Gerrit '
2238 'credential problems:\n'
2239 ' git cl creds-check\n'
2240 '\n'
2241 'If git-cl is not working correctly, file a bug under the Infra>SDK '
2242 'component including the files below.\n'
2243 'Review the files before upload, since they might contain sensitive '
2244 'information.\n'
2245 'Set the Restrict-View-Google label so that they are not publicly '
2246 'accessible.\n' + TRACES_MESSAGE % {'trace_name': trace_name})
Edward Lemur0f58ae42019-04-30 17:24:12 +00002247 finally:
2248 execution_time = time_time() - before_push
2249 metrics.collector.add_repeated('sub_commands', {
2250 'command': 'git push',
2251 'execution_time': execution_time,
2252 'exit_code': push_returncode,
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +00002253 'arguments': metrics_utils.extract_known_subcommand_args(refspec_opts),
Edward Lemur0f58ae42019-04-30 17:24:12 +00002254 })
2255
Edward Lemur1b52d872019-05-09 21:12:12 +00002256 git_push_metadata['execution_time'] = execution_time
2257 git_push_metadata['exit_code'] = push_returncode
Edward Lemur5737f022019-05-17 01:24:00 +00002258 self._WriteGitPushTraces(trace_name, traces_dir, git_push_metadata)
Edward Lemur0f58ae42019-04-30 17:24:12 +00002259
Edward Lemur1b52d872019-05-09 21:12:12 +00002260 self._CleanUpOldTraces()
Edward Lemur0f58ae42019-04-30 17:24:12 +00002261 gclient_utils.rmtree(traces_dir)
2262
2263 return push_stdout
2264
Josip Sokcevicf736cab2020-10-20 23:41:38 +00002265 def CMDUploadChange(self, options, git_diff_args, custom_cl_base,
2266 change_desc):
2267 """Upload the current branch to Gerrit, retry if new remote HEAD is
2268 found. options and change_desc may be mutated."""
Josip Sokcevicb631a882021-01-06 18:18:10 +00002269 remote, remote_branch = self.GetRemoteBranch()
2270 branch = GetTargetRef(remote, remote_branch, options.target_branch)
2271
Josip Sokcevicf736cab2020-10-20 23:41:38 +00002272 try:
2273 return self._CMDUploadChange(options, git_diff_args, custom_cl_base,
Josip Sokcevicb631a882021-01-06 18:18:10 +00002274 change_desc, branch)
Josip Sokcevicf736cab2020-10-20 23:41:38 +00002275 except GitPushError as e:
Josip Sokcevicb631a882021-01-06 18:18:10 +00002276 # Repository might be in the middle of transition to main branch as
2277 # default, and uploads to old default might be blocked.
2278 if remote_branch not in [DEFAULT_OLD_BRANCH, DEFAULT_NEW_BRANCH]:
Josip Sokcevicf736cab2020-10-20 23:41:38 +00002279 DieWithError(str(e), change_desc)
2280
Josip Sokcevicb631a882021-01-06 18:18:10 +00002281 project_head = gerrit_util.GetProjectHead(self._gerrit_host,
2282 self.GetGerritProject())
2283 if project_head == branch:
2284 DieWithError(str(e), change_desc)
2285 branch = project_head
2286
2287 print("WARNING: Fetching remote state and retrying upload to default "
2288 "branch...")
2289 RunGit(['fetch', '--prune', remote])
Josip Sokcevicf736cab2020-10-20 23:41:38 +00002290 options.edit_description = False
2291 options.force = True
2292 try:
Josip Sokcevicb631a882021-01-06 18:18:10 +00002293 self._CMDUploadChange(options, git_diff_args, custom_cl_base,
2294 change_desc, branch)
Josip Sokcevicf736cab2020-10-20 23:41:38 +00002295 except GitPushError as e:
2296 DieWithError(str(e), change_desc)
2297
2298 def _CMDUploadChange(self, options, git_diff_args, custom_cl_base,
Josip Sokcevicb631a882021-01-06 18:18:10 +00002299 change_desc, branch):
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002300 """Upload the current branch to Gerrit."""
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002301 if options.squash:
tandrii16e0b4e2016-06-07 10:34:28 -07002302 self._GerritCommitMsgHookCheck(offer_removal=not options.force)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002303 if self.GetIssue():
Josipe827b0f2020-01-30 00:07:20 +00002304 # User requested to change description
2305 if options.edit_description:
Josipe827b0f2020-01-30 00:07:20 +00002306 change_desc.prompt()
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002307 change_id = self._GetChangeDetail()['change_id']
Edward Lemur5a644f82020-03-18 16:44:57 +00002308 change_desc.ensure_change_id(change_id)
Aaron Gableb56ad332017-01-06 15:24:31 -08002309 else: # if not self.GetIssue()
Gavin Mak68e6cf32021-01-25 18:24:08 +00002310 if not options.force and not options.message_file:
Anthony Polito8b955342019-09-24 19:01:36 +00002311 change_desc.prompt()
Andrii Shyshkalov8c90d032017-04-19 21:27:26 +02002312 change_ids = git_footers.get_footer_change_id(change_desc.description)
Edward Lemur5a644f82020-03-18 16:44:57 +00002313 if len(change_ids) == 1:
2314 change_id = change_ids[0]
2315 else:
2316 change_id = GenerateGerritChangeId(change_desc.description)
2317 change_desc.ensure_change_id(change_id)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002318
Andrii Shyshkalov71f0da32019-07-15 22:45:18 +00002319 if options.preserve_tryjobs:
2320 change_desc.set_preserve_tryjobs()
Robert Iannuccidb02dd02017-04-19 12:18:20 -07002321
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002322 remote, upstream_branch = self.FetchUpstreamTuple(self.GetBranch())
Edward Lemur5a644f82020-03-18 16:44:57 +00002323 parent = self._ComputeParent(
2324 remote, upstream_branch, custom_cl_base, options.force, change_desc)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002325 tree = RunGit(['rev-parse', 'HEAD:']).strip()
Edward Lemur1773f372020-02-22 00:27:14 +00002326 with gclient_utils.temporary_file() as desc_tempfile:
2327 gclient_utils.FileWrite(desc_tempfile, change_desc.description)
2328 ref_to_push = RunGit(
2329 ['commit-tree', tree, '-p', parent, '-F', desc_tempfile]).strip()
Anthony Polito8b955342019-09-24 19:01:36 +00002330 else: # if not options.squash
Gregory Nisbet48d9e1e2021-04-15 23:35:54 +00002331 if options.no_add_changeid:
2332 pass
2333 else: # adding Change-Ids is okay.
2334 if not git_footers.get_footer_change_id(change_desc.description):
2335 DownloadGerritHook(False)
2336 change_desc.set_description(
2337 self._AddChangeIdToCommitMessage(change_desc.description,
2338 git_diff_args))
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002339 ref_to_push = 'HEAD'
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002340 # For no-squash mode, we assume the remote called "origin" is the one we
2341 # want. It is not worthwhile to support different workflows for
2342 # no-squash mode.
2343 parent = 'origin/%s' % branch
Gregory Nisbet48d9e1e2021-04-15 23:35:54 +00002344 # attempt to extract the changeid from the current description
2345 # fail informatively if not possible.
2346 change_id_candidates = git_footers.get_footer_change_id(
2347 change_desc.description)
2348 if not change_id_candidates:
2349 DieWithError("Unable to extract change-id from message.")
2350 change_id = change_id_candidates[0]
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002351
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +00002352 SaveDescriptionBackup(change_desc)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002353 commits = RunGitSilent(['rev-list', '%s..%s' % (parent,
2354 ref_to_push)]).splitlines()
2355 if len(commits) > 1:
2356 print('WARNING: This will upload %d commits. Run the following command '
2357 'to see which commits will be uploaded: ' % len(commits))
2358 print('git log %s..%s' % (parent, ref_to_push))
2359 print('You can also use `git squash-branch` to squash these into a '
2360 'single commit.')
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002361 confirm_or_exit(action='upload')
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002362
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00002363 reviewers = sorted(change_desc.get_reviewers())
Edward Lemur4508b422019-10-03 21:56:35 +00002364 cc = []
2365 # Add CCs from WATCHLISTS and rietveld.cc git config unless this is
2366 # the initial upload, the CL is private, or auto-CCing has ben disabled.
2367 if not (self.GetIssue() or options.private or options.no_autocc):
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00002368 cc = self.GetCCList().split(',')
Gavin Makb1c08f62021-04-01 18:05:58 +00002369 if len(cc) > 100:
2370 lsc = ('https://chromium.googlesource.com/chromium/src/+/HEAD/docs/'
2371 'process/lsc/lsc_workflow.md')
2372 print('WARNING: This will auto-CC %s users.' % len(cc))
2373 print('LSC may be more appropriate: %s' % lsc)
2374 print('You can also use the --no-autocc flag to disable auto-CC.')
2375 confirm_or_exit(action='continue')
Edward Lemur4508b422019-10-03 21:56:35 +00002376 # Add cc's from the --cc flag.
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00002377 if options.cc:
2378 cc.extend(options.cc)
Edward Lemur79d4f992019-11-11 23:49:02 +00002379 cc = [email.strip() for email in cc if email.strip()]
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00002380 if change_desc.get_cced():
2381 cc.extend(change_desc.get_cced())
Edward Lesmeseeca9c62020-11-20 00:00:17 +00002382 if self.GetGerritHost() == 'chromium-review.googlesource.com':
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00002383 valid_accounts = set(reviewers + cc)
2384 # TODO(crbug/877717): relax this for all hosts.
2385 else:
2386 valid_accounts = gerrit_util.ValidAccounts(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00002387 self.GetGerritHost(), reviewers + cc)
Andrii Shyshkalovf170af42018-10-30 07:00:44 +00002388 logging.info('accounts %s are recognized, %s invalid',
2389 sorted(valid_accounts),
2390 set(reviewers + cc).difference(set(valid_accounts)))
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00002391
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00002392 # Extra options that can be specified at push time. Doc:
2393 # https://gerrit-review.googlesource.com/Documentation/user-upload.html
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +00002394 refspec_opts = []
Andrii Shyshkalov2d8a2072017-04-10 15:02:18 +02002395
Aaron Gable844cf292017-06-28 11:32:59 -07002396 # By default, new changes are started in WIP mode, and subsequent patchsets
2397 # don't send email. At any time, passing --send-mail will mark the change
2398 # ready and send email for that particular patch.
Aaron Gableafd52772017-06-27 16:40:10 -07002399 if options.send_mail:
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +00002400 refspec_opts.append('ready')
2401 refspec_opts.append('notify=ALL')
Jamie Madill276da0b2018-04-27 14:41:20 -04002402 elif not self.GetIssue() and options.squash:
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +00002403 refspec_opts.append('wip')
Aaron Gableafd52772017-06-27 16:40:10 -07002404 else:
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +00002405 refspec_opts.append('notify=NONE')
Aaron Gable70f4e242017-06-26 10:45:59 -07002406
Andrii Shyshkalov2d8a2072017-04-10 15:02:18 +02002407 # TODO(tandrii): options.message should be posted as a comment
Aaron Gablee5adf612017-07-14 10:43:58 -07002408 # if --send-mail is set on non-initial upload as Rietveld used to do it.
Andrii Shyshkalov2d8a2072017-04-10 15:02:18 +02002409
Josip Sokcevicf736cab2020-10-20 23:41:38 +00002410 # Set options.title in case user was prompted in _GetTitleForUpload and
2411 # _CMDUploadChange needs to be called again.
2412 options.title = self._GetTitleForUpload(options)
2413 if options.title:
Nick Carter8692b182017-11-06 16:30:38 -08002414 # Punctuation and whitespace in |title| must be percent-encoded.
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +00002415 refspec_opts.append(
Josip Sokcevicf736cab2020-10-20 23:41:38 +00002416 'm=' + gerrit_util.PercentEncodeForGitRef(options.title))
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00002417
agablec6787972016-09-09 16:13:34 -07002418 if options.private:
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +00002419 refspec_opts.append('private')
agablec6787972016-09-09 16:13:34 -07002420
Andrii Shyshkalov2f727912018-10-15 17:02:33 +00002421 for r in sorted(reviewers):
2422 if r in valid_accounts:
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +00002423 refspec_opts.append('r=%s' % r)
Andrii Shyshkalov2f727912018-10-15 17:02:33 +00002424 reviewers.remove(r)
2425 else:
2426 # TODO(tandrii): this should probably be a hard failure.
2427 print('WARNING: reviewer %s doesn\'t have a Gerrit account, skipping'
2428 % r)
2429 for c in sorted(cc):
2430 # refspec option will be rejected if cc doesn't correspond to an
2431 # account, even though REST call to add such arbitrary cc may succeed.
2432 if c in valid_accounts:
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +00002433 refspec_opts.append('cc=%s' % c)
Andrii Shyshkalov2f727912018-10-15 17:02:33 +00002434 cc.remove(c)
2435
rmistry9eadede2016-09-19 11:22:43 -07002436 if options.topic:
2437 # Documentation on Gerrit topics is here:
2438 # https://gerrit-review.googlesource.com/Documentation/user-upload.html#topic
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +00002439 refspec_opts.append('topic=%s' % options.topic)
rmistry9eadede2016-09-19 11:22:43 -07002440
Edward Lemur687ca902018-12-05 02:30:30 +00002441 if options.enable_auto_submit:
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +00002442 refspec_opts.append('l=Auto-Submit+1')
Edward Lesmes10c3dd62021-02-08 21:13:57 +00002443 if options.set_bot_commit:
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +00002444 refspec_opts.append('l=Bot-Commit+1')
Edward Lemur687ca902018-12-05 02:30:30 +00002445 if options.use_commit_queue:
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +00002446 refspec_opts.append('l=Commit-Queue+2')
Edward Lemur687ca902018-12-05 02:30:30 +00002447 elif options.cq_dry_run:
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +00002448 refspec_opts.append('l=Commit-Queue+1')
Edward Lemur687ca902018-12-05 02:30:30 +00002449
2450 if change_desc.get_reviewers(tbr_only=True):
2451 score = gerrit_util.GetCodeReviewTbrScore(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00002452 self.GetGerritHost(),
2453 self.GetGerritProject())
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +00002454 refspec_opts.append('l=Code-Review+%s' % score)
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00002455
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08002456 # Gerrit sorts hashtags, so order is not important.
Nodir Turakulov23b82142017-11-16 11:04:25 -08002457 hashtags = {change_desc.sanitize_hash_tag(t) for t in options.hashtags}
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08002458 if not self.GetIssue():
Nodir Turakulov23b82142017-11-16 11:04:25 -08002459 hashtags.update(change_desc.get_hash_tags())
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +00002460 refspec_opts += ['hashtag=%s' % t for t in sorted(hashtags)]
2461
2462 refspec_suffix = ''
2463 if refspec_opts:
2464 refspec_suffix = '%' + ','.join(refspec_opts)
2465 assert ' ' not in refspec_suffix, (
2466 'spaces not allowed in refspec: "%s"' % refspec_suffix)
2467 refspec = '%s:refs/for/%s%s' % (ref_to_push, branch, refspec_suffix)
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00002468
Edward Lemur1b52d872019-05-09 21:12:12 +00002469 git_push_metadata = {
Edward Lesmeseeca9c62020-11-20 00:00:17 +00002470 'gerrit_host': self.GetGerritHost(),
Josip Sokcevicf736cab2020-10-20 23:41:38 +00002471 'title': options.title or '<untitled>',
Edward Lemur1b52d872019-05-09 21:12:12 +00002472 'change_id': change_id,
2473 'description': change_desc.description,
2474 }
Josip Sokcevicf2cfd3d2021-03-30 18:39:18 +00002475
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +00002476 push_stdout = self._RunGitPushWithTraces(refspec, refspec_opts,
Josip Sokcevicf2cfd3d2021-03-30 18:39:18 +00002477 git_push_metadata,
2478 options.push_options)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002479
2480 if options.squash:
Aaron Gable289b4312017-09-13 14:06:16 -07002481 regex = re.compile(r'remote:\s+https?://[\w\-\.\+\/#]*/(\d+)\s.*')
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002482 change_numbers = [m.group(1)
2483 for m in map(regex.match, push_stdout.splitlines())
2484 if m]
2485 if len(change_numbers) != 1:
2486 DieWithError(
2487 ('Created|Updated %d issues on Gerrit, but only 1 expected.\n'
Christopher Lamf732cd52017-01-24 12:40:11 +11002488 'Change-Id: %s') % (len(change_numbers), change_id), change_desc)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002489 self.SetIssue(change_numbers[0])
tandrii5d48c322016-08-18 16:19:37 -07002490 self._GitSetBranchConfigValue('gerritsquashhash', ref_to_push)
tandrii88189772016-09-29 04:29:57 -07002491
Andrii Shyshkalov2f727912018-10-15 17:02:33 +00002492 if self.GetIssue() and (reviewers or cc):
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00002493 # GetIssue() is not set in case of non-squash uploads according to tests.
Aaron Gable6e7ddb62020-05-27 22:23:29 +00002494 # TODO(crbug.com/751901): non-squash uploads in git cl should be removed.
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00002495 gerrit_util.AddReviewers(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00002496 self.GetGerritHost(),
Andrii Shyshkalovd06cc782018-08-23 17:24:19 +00002497 self._GerritChangeIdentifier(),
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00002498 reviewers, cc,
2499 notify=bool(options.send_mail))
Aaron Gable6dadfbf2017-05-09 14:27:58 -07002500
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002501 return 0
2502
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002503 def _ComputeParent(self, remote, upstream_branch, custom_cl_base, force,
2504 change_desc):
2505 """Computes parent of the generated commit to be uploaded to Gerrit.
2506
2507 Returns revision or a ref name.
2508 """
2509 if custom_cl_base:
2510 # Try to avoid creating additional unintended CLs when uploading, unless
2511 # user wants to take this risk.
2512 local_ref_of_target_remote = self.GetRemoteBranch()[1]
2513 code, _ = RunGitWithCode(['merge-base', '--is-ancestor', custom_cl_base,
2514 local_ref_of_target_remote])
2515 if code == 1:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002516 print('\nWARNING: Manually specified base of this CL `%s` '
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002517 'doesn\'t seem to belong to target remote branch `%s`.\n\n'
2518 'If you proceed with upload, more than 1 CL may be created by '
2519 'Gerrit as a result, in turn confusing or crashing git cl.\n\n'
2520 'If you are certain that specified base `%s` has already been '
2521 'uploaded to Gerrit as another CL, you may proceed.\n' %
2522 (custom_cl_base, local_ref_of_target_remote, custom_cl_base))
2523 if not force:
2524 confirm_or_exit(
2525 'Do you take responsibility for cleaning up potential mess '
2526 'resulting from proceeding with upload?',
2527 action='upload')
2528 return custom_cl_base
2529
Aaron Gablef97e33d2017-03-30 15:44:27 -07002530 if remote != '.':
2531 return self.GetCommonAncestorWithUpstream()
2532
2533 # If our upstream branch is local, we base our squashed commit on its
2534 # squashed version.
2535 upstream_branch_name = scm.GIT.ShortBranchName(upstream_branch)
2536
Aaron Gablef97e33d2017-03-30 15:44:27 -07002537 if upstream_branch_name == 'master':
Aaron Gable0bbd1c22017-05-08 14:37:08 -07002538 return self.GetCommonAncestorWithUpstream()
Glen Robertson7d98e222020-08-27 17:53:11 +00002539 if upstream_branch_name == 'main':
2540 return self.GetCommonAncestorWithUpstream()
Aaron Gablef97e33d2017-03-30 15:44:27 -07002541
2542 # Check the squashed hash of the parent.
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002543 # TODO(tandrii): consider checking parent change in Gerrit and using its
2544 # hash if tree hash of latest parent revision (patchset) in Gerrit matches
2545 # the tree hash of the parent branch. The upside is less likely bogus
2546 # requests to reupload parent change just because it's uploadhash is
2547 # missing, yet the downside likely exists, too (albeit unknown to me yet).
Edward Lesmesa680c232020-03-31 18:26:44 +00002548 parent = scm.GIT.GetBranchConfig(
2549 settings.GetRoot(), upstream_branch_name, 'gerritsquashhash')
Aaron Gablef97e33d2017-03-30 15:44:27 -07002550 # Verify that the upstream branch has been uploaded too, otherwise
2551 # Gerrit will create additional CLs when uploading.
2552 if not parent or (RunGitSilent(['rev-parse', upstream_branch + ':']) !=
2553 RunGitSilent(['rev-parse', parent + ':'])):
2554 DieWithError(
2555 '\nUpload upstream branch %s first.\n'
2556 'It is likely that this branch has been rebased since its last '
2557 'upload, so you just need to upload it again.\n'
2558 '(If you uploaded it with --no-squash, then branch dependencies '
2559 'are not supported, and you should reupload with --squash.)'
2560 % upstream_branch_name,
2561 change_desc)
2562 return parent
2563
Edward Lemura12175c2020-03-09 16:58:26 +00002564 def _AddChangeIdToCommitMessage(self, log_desc, args):
tandrii@chromium.org8930b3d2016-04-13 14:47:02 +00002565 """Re-commits using the current message, assumes the commit hook is in
2566 place.
2567 """
Edward Lemura12175c2020-03-09 16:58:26 +00002568 RunGit(['commit', '--amend', '-m', log_desc])
Andrii Shyshkalovb07575f2018-10-16 06:16:21 +00002569 new_log_desc = _create_description_from_log(args)
tandrii@chromium.org8930b3d2016-04-13 14:47:02 +00002570 if git_footers.get_footer_change_id(new_log_desc):
vapiera7fbd5a2016-06-16 09:17:49 -07002571 print('git-cl: Added Change-Id to commit message.')
tandrii@chromium.org8930b3d2016-04-13 14:47:02 +00002572 return new_log_desc
2573 else:
tandrii@chromium.orgb067ec52016-05-31 15:24:44 +00002574 DieWithError('ERROR: Gerrit commit-msg hook not installed.')
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002575
tandriie113dfd2016-10-11 10:20:12 -07002576 def CannotTriggerTryJobReason(self):
tandrii8c5a3532016-11-04 07:52:02 -07002577 try:
2578 data = self._GetChangeDetail()
Aaron Gablea45ee112016-11-22 15:14:38 -08002579 except GerritChangeNotExists:
2580 return 'Gerrit doesn\'t know about your change %s' % self.GetIssue()
tandrii8c5a3532016-11-04 07:52:02 -07002581
2582 if data['status'] in ('ABANDONED', 'MERGED'):
2583 return 'CL %s is closed' % self.GetIssue()
2584
Edward Lemurd4d1ba42019-09-20 21:46:37 +00002585 def GetGerritChange(self, patchset=None):
2586 """Returns a buildbucket.v2.GerritChange message for the current issue."""
Edward Lemur79d4f992019-11-11 23:49:02 +00002587 host = urllib.parse.urlparse(self.GetCodereviewServer()).hostname
Edward Lemurd4d1ba42019-09-20 21:46:37 +00002588 issue = self.GetIssue()
Edward Lemur2c210a42019-09-16 23:58:35 +00002589 patchset = int(patchset or self.GetPatchset())
Edward Lemurd4d1ba42019-09-20 21:46:37 +00002590 data = self._GetChangeDetail(['ALL_REVISIONS'])
2591
2592 assert host and issue and patchset, 'CL must be uploaded first'
2593
2594 has_patchset = any(
2595 int(revision_data['_number']) == patchset
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00002596 for revision_data in data['revisions'].values())
Edward Lemurd4d1ba42019-09-20 21:46:37 +00002597 if not has_patchset:
Aaron Gablea45ee112016-11-22 15:14:38 -08002598 raise Exception('Patchset %d is not known in Gerrit change %d' %
tandrii8c5a3532016-11-04 07:52:02 -07002599 (patchset, self.GetIssue()))
Edward Lemurd4d1ba42019-09-20 21:46:37 +00002600
tandrii8c5a3532016-11-04 07:52:02 -07002601 return {
Edward Lemurd4d1ba42019-09-20 21:46:37 +00002602 'host': host,
2603 'change': issue,
2604 'project': data['project'],
2605 'patchset': patchset,
tandrii8c5a3532016-11-04 07:52:02 -07002606 }
tandriie113dfd2016-10-11 10:20:12 -07002607
tandriide281ae2016-10-12 06:02:30 -07002608 def GetIssueOwner(self):
tandrii8c5a3532016-11-04 07:52:02 -07002609 return self._GetChangeDetail(['DETAILED_ACCOUNTS'])['owner']['email']
tandriide281ae2016-10-12 06:02:30 -07002610
Edward Lemur707d70b2018-02-07 00:50:14 +01002611 def GetReviewers(self):
2612 details = self._GetChangeDetail(['DETAILED_ACCOUNTS'])
Mohamed Heikal171c0742018-11-09 20:38:51 +00002613 return [r['email'] for r in details['reviewers'].get('REVIEWER', [])]
Edward Lemur707d70b2018-02-07 00:50:14 +01002614
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002615
Lei Zhang8a0efc12020-08-05 19:58:45 +00002616def _get_bug_line_values(default_project_prefix, bugs):
2617 """Given default_project_prefix and comma separated list of bugs, yields bug
2618 line values.
tandriif9aefb72016-07-01 09:06:51 -07002619
2620 Each bug can be either:
Lei Zhang8a0efc12020-08-05 19:58:45 +00002621 * a number, which is combined with default_project_prefix
tandriif9aefb72016-07-01 09:06:51 -07002622 * string, which is left as is.
2623
2624 This function may produce more than one line, because bugdroid expects one
2625 project per line.
2626
Lei Zhang8a0efc12020-08-05 19:58:45 +00002627 >>> list(_get_bug_line_values('v8:', '123,chromium:789'))
tandriif9aefb72016-07-01 09:06:51 -07002628 ['v8:123', 'chromium:789']
2629 """
2630 default_bugs = []
2631 others = []
2632 for bug in bugs.split(','):
2633 bug = bug.strip()
2634 if bug:
2635 try:
2636 default_bugs.append(int(bug))
2637 except ValueError:
2638 others.append(bug)
2639
2640 if default_bugs:
2641 default_bugs = ','.join(map(str, default_bugs))
Lei Zhang8a0efc12020-08-05 19:58:45 +00002642 if default_project_prefix:
2643 if not default_project_prefix.endswith(':'):
2644 default_project_prefix += ':'
2645 yield '%s%s' % (default_project_prefix, default_bugs)
tandriif9aefb72016-07-01 09:06:51 -07002646 else:
2647 yield default_bugs
2648 for other in sorted(others):
2649 # Don't bother finding common prefixes, CLs with >2 bugs are very very rare.
2650 yield other
2651
2652
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00002653class ChangeDescription(object):
2654 """Contains a parsed form of the change description."""
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00002655 R_LINE = r'^[ \t]*(TBR|R)[ \t]*=[ \t]*(.*?)[ \t]*$'
bradnelsond975b302016-10-23 12:20:23 -07002656 CC_LINE = r'^[ \t]*(CC)[ \t]*=[ \t]*(.*?)[ \t]*$'
Aaron Gable3a16ed12017-03-23 10:51:55 -07002657 BUG_LINE = r'^[ \t]*(?:(BUG)[ \t]*=|Bug:)[ \t]*(.*?)[ \t]*$'
Dan Beamd8b04ca2019-10-10 21:23:26 +00002658 FIXED_LINE = r'^[ \t]*Fixed[ \t]*:[ \t]*(.*?)[ \t]*$'
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01002659 CHERRY_PICK_LINE = r'^\(cherry picked from commit [a-fA-F0-9]{40}\)$'
Nodir Turakulov23b82142017-11-16 11:04:25 -08002660 STRIP_HASH_TAG_PREFIX = r'^(\s*(revert|reland)( "|:)?\s*)*'
2661 BRACKET_HASH_TAG = r'\s*\[([^\[\]]+)\]'
Anthony Polito02b5af32019-12-02 19:49:47 +00002662 COLON_SEPARATED_HASH_TAG = r'^([a-zA-Z0-9_\- ]+):($|[^:])'
Nodir Turakulov23b82142017-11-16 11:04:25 -08002663 BAD_HASH_TAG_CHUNK = r'[^a-zA-Z0-9]+'
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00002664
Dan Beamd8b04ca2019-10-10 21:23:26 +00002665 def __init__(self, description, bug=None, fixed=None):
agable@chromium.org42c20792013-09-12 17:34:49 +00002666 self._description_lines = (description or '').strip().splitlines()
Anthony Polito8b955342019-09-24 19:01:36 +00002667 if bug:
2668 regexp = re.compile(self.BUG_LINE)
2669 prefix = settings.GetBugPrefix()
2670 if not any((regexp.match(line) for line in self._description_lines)):
2671 values = list(_get_bug_line_values(prefix, bug))
2672 self.append_footer('Bug: %s' % ', '.join(values))
Dan Beamd8b04ca2019-10-10 21:23:26 +00002673 if fixed:
2674 regexp = re.compile(self.FIXED_LINE)
2675 prefix = settings.GetBugPrefix()
2676 if not any((regexp.match(line) for line in self._description_lines)):
2677 values = list(_get_bug_line_values(prefix, fixed))
2678 self.append_footer('Fixed: %s' % ', '.join(values))
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002679
agable@chromium.org42c20792013-09-12 17:34:49 +00002680 @property # www.logilab.org/ticket/89786
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -08002681 def description(self): # pylint: disable=method-hidden
agable@chromium.org42c20792013-09-12 17:34:49 +00002682 return '\n'.join(self._description_lines)
2683
2684 def set_description(self, desc):
2685 if isinstance(desc, basestring):
2686 lines = desc.splitlines()
2687 else:
2688 lines = [line.rstrip() for line in desc]
2689 while lines and not lines[0]:
2690 lines.pop(0)
2691 while lines and not lines[-1]:
2692 lines.pop(-1)
2693 self._description_lines = lines
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002694
Edward Lemur5a644f82020-03-18 16:44:57 +00002695 def ensure_change_id(self, change_id):
2696 description = self.description
2697 footer_change_ids = git_footers.get_footer_change_id(description)
2698 # Make sure that the Change-Id in the description matches the given one.
2699 if footer_change_ids != [change_id]:
2700 if footer_change_ids:
2701 # Remove any existing Change-Id footers since they don't match the
2702 # expected change_id footer.
2703 description = git_footers.remove_footer(description, 'Change-Id')
2704 print('WARNING: Change-Id has been set to %s. Use `git cl issue 0` '
2705 'if you want to set a new one.')
2706 # Add the expected Change-Id footer.
2707 description = git_footers.add_footer_change_id(description, change_id)
2708 self.set_description(description)
2709
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00002710 def update_reviewers(self, reviewers, tbrs):
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002711 """Rewrites the R=/TBR= line(s) as a single line each.
2712
2713 Args:
2714 reviewers (list(str)) - list of additional emails to use for reviewers.
2715 tbrs (list(str)) - list of additional emails to use for TBRs.
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002716 """
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00002717 if not reviewers and not tbrs:
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002718 return
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002719
2720 reviewers = set(reviewers)
2721 tbrs = set(tbrs)
2722 LOOKUP = {
2723 'TBR': tbrs,
2724 'R': reviewers,
2725 }
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002726
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002727 # Get the set of R= and TBR= lines and remove them from the description.
agable@chromium.org42c20792013-09-12 17:34:49 +00002728 regexp = re.compile(self.R_LINE)
2729 matches = [regexp.match(line) for line in self._description_lines]
2730 new_desc = [l for i, l in enumerate(self._description_lines)
2731 if not matches[i]]
2732 self.set_description(new_desc)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002733
agable@chromium.org42c20792013-09-12 17:34:49 +00002734 # Construct new unified R= and TBR= lines.
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002735
2736 # First, update tbrs/reviewers with names from the R=/TBR= lines (if any).
agable@chromium.org42c20792013-09-12 17:34:49 +00002737 for match in matches:
2738 if not match:
2739 continue
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002740 LOOKUP[match.group(1)].update(cleanup_list([match.group(2).strip()]))
2741
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002742 # If any folks ended up in both groups, remove them from tbrs.
2743 tbrs -= reviewers
Robert Iannuccif2708bd2017-04-17 15:49:02 -07002744
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002745 new_r_line = 'R=' + ', '.join(sorted(reviewers)) if reviewers else None
2746 new_tbr_line = 'TBR=' + ', '.join(sorted(tbrs)) if tbrs else None
agable@chromium.org42c20792013-09-12 17:34:49 +00002747
2748 # Put the new lines in the description where the old first R= line was.
2749 line_loc = next((i for i, match in enumerate(matches) if match), -1)
2750 if 0 <= line_loc < len(self._description_lines):
2751 if new_tbr_line:
2752 self._description_lines.insert(line_loc, new_tbr_line)
2753 if new_r_line:
2754 self._description_lines.insert(line_loc, new_r_line)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002755 else:
agable@chromium.org42c20792013-09-12 17:34:49 +00002756 if new_r_line:
2757 self.append_footer(new_r_line)
2758 if new_tbr_line:
2759 self.append_footer(new_tbr_line)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002760
Andrii Shyshkalov71f0da32019-07-15 22:45:18 +00002761 def set_preserve_tryjobs(self):
2762 """Ensures description footer contains 'Cq-Do-Not-Cancel-Tryjobs: true'."""
2763 footers = git_footers.parse_footers(self.description)
2764 for v in footers.get('Cq-Do-Not-Cancel-Tryjobs', []):
2765 if v.lower() == 'true':
2766 return
2767 self.append_footer('Cq-Do-Not-Cancel-Tryjobs: true')
2768
Anthony Polito8b955342019-09-24 19:01:36 +00002769 def prompt(self):
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002770 """Asks the user to update the description."""
agable@chromium.org42c20792013-09-12 17:34:49 +00002771 self.set_description([
2772 '# Enter a description of the change.',
2773 '# This will be displayed on the codereview site.',
2774 '# The first line will also be used as the subject of the review.',
alancutter@chromium.orgbd1073e2013-06-01 00:34:38 +00002775 '#--------------------This line is 72 characters long'
agable@chromium.org42c20792013-09-12 17:34:49 +00002776 '--------------------',
2777 ] + self._description_lines)
Dan Beamd8b04ca2019-10-10 21:23:26 +00002778 bug_regexp = re.compile(self.BUG_LINE)
2779 fixed_regexp = re.compile(self.FIXED_LINE)
Jonas Termansend0f79112019-03-22 15:28:26 +00002780 prefix = settings.GetBugPrefix()
Sigurd Schneider8630bb12020-11-11 14:02:49 +00002781 has_issue = lambda l: bug_regexp.match(l) or fixed_regexp.match(l)
Sigurd Schneider9abde8c2020-11-17 08:44:52 +00002782
Dan Beamd8b04ca2019-10-10 21:23:26 +00002783 if not any((has_issue(line) for line in self._description_lines)):
Anthony Polito8b955342019-09-24 19:01:36 +00002784 self.append_footer('Bug: %s' % prefix)
tandriif9aefb72016-07-01 09:06:51 -07002785
Bruce Dawsonfc487042020-10-27 19:11:37 +00002786 print('Waiting for editor...')
agable@chromium.org42c20792013-09-12 17:34:49 +00002787 content = gclient_utils.RunEditor(self.description, True,
Edward Lemur79d4f992019-11-11 23:49:02 +00002788 git_editor=settings.GetGitEditor())
maruel@chromium.org0e0436a2011-10-25 13:32:41 +00002789 if not content:
2790 DieWithError('Running editor failed')
agable@chromium.org42c20792013-09-12 17:34:49 +00002791 lines = content.splitlines()
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002792
Bruce Dawson2377b012018-01-11 16:46:49 -08002793 # Strip off comments and default inserted "Bug:" line.
2794 clean_lines = [line.rstrip() for line in lines if not
Jonas Termansend0f79112019-03-22 15:28:26 +00002795 (line.startswith('#') or
2796 line.rstrip() == "Bug:" or
2797 line.rstrip() == "Bug: " + prefix)]
agable@chromium.org42c20792013-09-12 17:34:49 +00002798 if not clean_lines:
maruel@chromium.org0e0436a2011-10-25 13:32:41 +00002799 DieWithError('No CL description, aborting')
agable@chromium.org42c20792013-09-12 17:34:49 +00002800 self.set_description(clean_lines)
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00002801
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002802 def append_footer(self, line):
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002803 """Adds a footer line to the description.
2804
2805 Differentiates legacy "KEY=xxx" footers (used to be called tags) and
2806 Gerrit's footers in the form of "Footer-Key: footer any value" and ensures
2807 that Gerrit footers are always at the end.
2808 """
2809 parsed_footer_line = git_footers.parse_footer(line)
2810 if parsed_footer_line:
2811 # Line is a gerrit footer in the form: Footer-Key: any value.
2812 # Thus, must be appended observing Gerrit footer rules.
2813 self.set_description(
2814 git_footers.add_footer(self.description,
2815 key=parsed_footer_line[0],
2816 value=parsed_footer_line[1]))
2817 return
2818
2819 if not self._description_lines:
2820 self._description_lines.append(line)
2821 return
2822
2823 top_lines, gerrit_footers, _ = git_footers.split_footers(self.description)
2824 if gerrit_footers:
2825 # git_footers.split_footers ensures that there is an empty line before
2826 # actual (gerrit) footers, if any. We have to keep it that way.
2827 assert top_lines and top_lines[-1] == ''
2828 top_lines, separator = top_lines[:-1], top_lines[-1:]
2829 else:
2830 separator = [] # No need for separator if there are no gerrit_footers.
2831
2832 prev_line = top_lines[-1] if top_lines else ''
2833 if (not presubmit_support.Change.TAG_LINE_RE.match(prev_line) or
2834 not presubmit_support.Change.TAG_LINE_RE.match(line)):
2835 top_lines.append('')
2836 top_lines.append(line)
2837 self._description_lines = top_lines + separator + gerrit_footers
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00002838
tandrii99a72f22016-08-17 14:33:24 -07002839 def get_reviewers(self, tbr_only=False):
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002840 """Retrieves the list of reviewers."""
agable@chromium.org42c20792013-09-12 17:34:49 +00002841 matches = [re.match(self.R_LINE, line) for line in self._description_lines]
tandrii99a72f22016-08-17 14:33:24 -07002842 reviewers = [match.group(2).strip()
2843 for match in matches
2844 if match and (not tbr_only or match.group(1).upper() == 'TBR')]
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002845 return cleanup_list(reviewers)
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00002846
bradnelsond975b302016-10-23 12:20:23 -07002847 def get_cced(self):
2848 """Retrieves the list of reviewers."""
2849 matches = [re.match(self.CC_LINE, line) for line in self._description_lines]
2850 cced = [match.group(2).strip() for match in matches if match]
2851 return cleanup_list(cced)
2852
Nodir Turakulov23b82142017-11-16 11:04:25 -08002853 def get_hash_tags(self):
2854 """Extracts and sanitizes a list of Gerrit hashtags."""
2855 subject = (self._description_lines or ('',))[0]
2856 subject = re.sub(
2857 self.STRIP_HASH_TAG_PREFIX, '', subject, flags=re.IGNORECASE)
2858
2859 tags = []
2860 start = 0
2861 bracket_exp = re.compile(self.BRACKET_HASH_TAG)
2862 while True:
2863 m = bracket_exp.match(subject, start)
2864 if not m:
2865 break
2866 tags.append(self.sanitize_hash_tag(m.group(1)))
2867 start = m.end()
2868
2869 if not tags:
2870 # Try "Tag: " prefix.
2871 m = re.match(self.COLON_SEPARATED_HASH_TAG, subject)
2872 if m:
2873 tags.append(self.sanitize_hash_tag(m.group(1)))
2874 return tags
2875
2876 @classmethod
2877 def sanitize_hash_tag(cls, tag):
2878 """Returns a sanitized Gerrit hash tag.
2879
2880 A sanitized hashtag can be used as a git push refspec parameter value.
2881 """
2882 return re.sub(cls.BAD_HASH_TAG_CHUNK, '-', tag).strip('-').lower()
2883
maruel@chromium.orge52678e2013-04-26 18:34:44 +00002884
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00002885def FindCodereviewSettingsFile(filename='codereview.settings'):
2886 """Finds the given file starting in the cwd and going up.
2887
2888 Only looks up to the top of the repository unless an
2889 'inherit-review-settings-ok' file exists in the root of the repository.
2890 """
2891 inherit_ok_file = 'inherit-review-settings-ok'
2892 cwd = os.getcwd()
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00002893 root = settings.GetRoot()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00002894 if os.path.isfile(os.path.join(root, inherit_ok_file)):
2895 root = '/'
2896 while True:
2897 if filename in os.listdir(cwd):
2898 if os.path.isfile(os.path.join(cwd, filename)):
2899 return open(os.path.join(cwd, filename))
2900 if cwd == root:
2901 break
2902 cwd = os.path.dirname(cwd)
2903
2904
2905def LoadCodereviewSettingsFromFile(fileobj):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002906 """Parses a codereview.settings file and updates hooks."""
maruel@chromium.org99ac1c52012-01-16 14:52:12 +00002907 keyvals = gclient_utils.ParseCodereviewSettingsContent(fileobj.read())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00002908
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00002909 def SetProperty(name, setting, unset_error_ok=False):
2910 fullname = 'rietveld.' + name
2911 if setting in keyvals:
2912 RunGit(['config', fullname, keyvals[setting]])
2913 else:
2914 RunGit(['config', '--unset-all', fullname], error_ok=unset_error_ok)
2915
tandrii48df5812016-10-17 03:55:37 -07002916 if not keyvals.get('GERRIT_HOST', False):
2917 SetProperty('server', 'CODE_REVIEW_SERVER')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00002918 # Only server setting is required. Other settings can be absent.
2919 # In that case, we ignore errors raised during option deletion attempt.
2920 SetProperty('cc', 'CC_LIST', unset_error_ok=True)
2921 SetProperty('tree-status-url', 'STATUS', unset_error_ok=True)
2922 SetProperty('viewvc-url', 'VIEW_VC', unset_error_ok=True)
rmistry@google.com90752582014-01-14 21:04:50 +00002923 SetProperty('bug-prefix', 'BUG_PREFIX', unset_error_ok=True)
thestig@chromium.org44202a22014-03-11 19:22:18 +00002924 SetProperty('cpplint-regex', 'LINT_REGEX', unset_error_ok=True)
2925 SetProperty('cpplint-ignore-regex', 'LINT_IGNORE_REGEX', unset_error_ok=True)
rmistry@google.com5626a922015-02-26 14:03:30 +00002926 SetProperty('run-post-upload-hook', 'RUN_POST_UPLOAD_HOOK',
2927 unset_error_ok=True)
Jamie Madilldc4d19e2019-10-24 21:50:02 +00002928 SetProperty(
2929 'format-full-by-default', 'FORMAT_FULL_BY_DEFAULT', unset_error_ok=True)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00002930
ukai@chromium.org7044efc2013-11-28 01:51:21 +00002931 if 'GERRIT_HOST' in keyvals:
ukai@chromium.orge8077812012-02-03 03:41:46 +00002932 RunGit(['config', 'gerrit.host', keyvals['GERRIT_HOST']])
ukai@chromium.orge8077812012-02-03 03:41:46 +00002933
bauerb@chromium.org54b400c2016-01-14 10:08:25 +00002934 if 'GERRIT_SQUASH_UPLOADS' in keyvals:
Edward Lesmes4de54132020-05-05 19:41:33 +00002935 RunGit(['config', 'gerrit.squash-uploads',
2936 keyvals['GERRIT_SQUASH_UPLOADS']])
bauerb@chromium.org54b400c2016-01-14 10:08:25 +00002937
tandrii@chromium.org28253532016-04-14 13:46:56 +00002938 if 'GERRIT_SKIP_ENSURE_AUTHENTICATED' in keyvals:
shinyak@chromium.org00dbccd2016-04-15 07:24:43 +00002939 RunGit(['config', 'gerrit.skip-ensure-authenticated',
tandrii@chromium.org28253532016-04-14 13:46:56 +00002940 keyvals['GERRIT_SKIP_ENSURE_AUTHENTICATED']])
2941
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00002942 if 'PUSH_URL_CONFIG' in keyvals and 'ORIGIN_URL_CONFIG' in keyvals:
Andrii Shyshkalov18975322017-01-25 16:44:13 +01002943 # should be of the form
2944 # PUSH_URL_CONFIG: url.ssh://gitrw.chromium.org.pushinsteadof
2945 # ORIGIN_URL_CONFIG: http://src.chromium.org/git
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00002946 RunGit(['config', keyvals['PUSH_URL_CONFIG'],
2947 keyvals['ORIGIN_URL_CONFIG']])
2948
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00002949
joshua.lock@intel.com426f69b2012-08-02 23:41:49 +00002950def urlretrieve(source, destination):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002951 """Downloads a network object to a local file, like urllib.urlretrieve.
2952
2953 This is necessary because urllib is broken for SSL connections via a proxy.
2954 """
joshua.lock@intel.com426f69b2012-08-02 23:41:49 +00002955 with open(destination, 'w') as f:
Edward Lemur79d4f992019-11-11 23:49:02 +00002956 f.write(urllib.request.urlopen(source).read())
joshua.lock@intel.com426f69b2012-08-02 23:41:49 +00002957
2958
ukai@chromium.org712d6102013-11-27 00:52:58 +00002959def hasSheBang(fname):
2960 """Checks fname is a #! script."""
2961 with open(fname) as f:
2962 return f.read(2).startswith('#!')
2963
2964
tandrii@chromium.org18630d62016-03-04 12:06:02 +00002965def DownloadGerritHook(force):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002966 """Downloads and installs a Gerrit commit-msg hook.
ukai@chromium.org78c4b982012-02-14 02:20:26 +00002967
2968 Args:
2969 force: True to update hooks. False to install hooks if not present.
2970 """
ukai@chromium.org712d6102013-11-27 00:52:58 +00002971 src = 'https://gerrit-review.googlesource.com/tools/hooks/commit-msg'
ukai@chromium.org78c4b982012-02-14 02:20:26 +00002972 dst = os.path.join(settings.GetRoot(), '.git', 'hooks', 'commit-msg')
2973 if not os.access(dst, os.X_OK):
2974 if os.path.exists(dst):
2975 if not force:
2976 return
ukai@chromium.org78c4b982012-02-14 02:20:26 +00002977 try:
joshua.lock@intel.com426f69b2012-08-02 23:41:49 +00002978 urlretrieve(src, dst)
ukai@chromium.org712d6102013-11-27 00:52:58 +00002979 if not hasSheBang(dst):
2980 DieWithError('Not a script: %s\n'
2981 'You need to download from\n%s\n'
2982 'into .git/hooks/commit-msg and '
2983 'chmod +x .git/hooks/commit-msg' % (dst, src))
ukai@chromium.org78c4b982012-02-14 02:20:26 +00002984 os.chmod(dst, stat.S_IRUSR | stat.S_IWUSR | stat.S_IXUSR)
2985 except Exception:
2986 if os.path.exists(dst):
2987 os.remove(dst)
ukai@chromium.org712d6102013-11-27 00:52:58 +00002988 DieWithError('\nFailed to download hooks.\n'
2989 'You need to download from\n%s\n'
2990 'into .git/hooks/commit-msg and '
2991 'chmod +x .git/hooks/commit-msg' % src)
ukai@chromium.org78c4b982012-02-14 02:20:26 +00002992
2993
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01002994class _GitCookiesChecker(object):
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002995 """Provides facilities for validating and suggesting fixes to .gitcookies."""
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002996
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002997 _GOOGLESOURCE = 'googlesource.com'
2998
2999 def __init__(self):
3000 # Cached list of [host, identity, source], where source is either
3001 # .gitcookies or .netrc.
3002 self._all_hosts = None
3003
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003004 def ensure_configured_gitcookies(self):
3005 """Runs checks and suggests fixes to make git use .gitcookies from default
3006 path."""
3007 default = gerrit_util.CookiesAuthenticator.get_gitcookies_path()
3008 configured_path = RunGitSilent(
3009 ['config', '--global', 'http.cookiefile']).strip()
Andrii Shyshkalov1e250cd2017-05-10 15:39:31 +02003010 configured_path = os.path.expanduser(configured_path)
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003011 if configured_path:
3012 self._ensure_default_gitcookies_path(configured_path, default)
3013 else:
3014 self._configure_gitcookies_path(default)
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003015
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003016 @staticmethod
3017 def _ensure_default_gitcookies_path(configured_path, default_path):
3018 assert configured_path
3019 if configured_path == default_path:
3020 print('git is already configured to use your .gitcookies from %s' %
3021 configured_path)
3022 return
3023
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003024 print('WARNING: You have configured custom path to .gitcookies: %s\n'
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003025 'Gerrit and other depot_tools expect .gitcookies at %s\n' %
3026 (configured_path, default_path))
3027
3028 if not os.path.exists(configured_path):
3029 print('However, your configured .gitcookies file is missing.')
3030 confirm_or_exit('Reconfigure git to use default .gitcookies?',
3031 action='reconfigure')
3032 RunGit(['config', '--global', 'http.cookiefile', default_path])
3033 return
3034
3035 if os.path.exists(default_path):
3036 print('WARNING: default .gitcookies file already exists %s' %
3037 default_path)
3038 DieWithError('Please delete %s manually and re-run git cl creds-check' %
3039 default_path)
3040
3041 confirm_or_exit('Move existing .gitcookies to default location?',
3042 action='move')
3043 shutil.move(configured_path, default_path)
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003044 RunGit(['config', '--global', 'http.cookiefile', default_path])
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003045 print('Moved and reconfigured git to use .gitcookies from %s' %
3046 default_path)
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003047
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003048 @staticmethod
3049 def _configure_gitcookies_path(default_path):
3050 netrc_path = gerrit_util.CookiesAuthenticator.get_netrc_path()
3051 if os.path.exists(netrc_path):
3052 print('You seem to be using outdated .netrc for git credentials: %s' %
3053 netrc_path)
3054 print('This tool will guide you through setting up recommended '
3055 '.gitcookies store for git credentials.\n'
3056 '\n'
3057 'IMPORTANT: If something goes wrong and you decide to go back, do:\n'
3058 ' git config --global --unset http.cookiefile\n'
3059 ' mv %s %s.backup\n\n' % (default_path, default_path))
3060 confirm_or_exit(action='setup .gitcookies')
3061 RunGit(['config', '--global', 'http.cookiefile', default_path])
3062 print('Configured git to use .gitcookies from %s' % default_path)
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003063
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003064 def get_hosts_with_creds(self, include_netrc=False):
3065 if self._all_hosts is None:
3066 a = gerrit_util.CookiesAuthenticator()
3067 self._all_hosts = [
3068 (h, u, s)
3069 for h, u, s in itertools.chain(
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00003070 ((h, u, '.netrc') for h, (u, _, _) in a.netrc.hosts.items()),
3071 ((h, u, '.gitcookies') for h, (u, _) in a.gitcookies.items())
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003072 )
3073 if h.endswith(self._GOOGLESOURCE)
3074 ]
3075
3076 if include_netrc:
3077 return self._all_hosts
3078 return [(h, u, s) for h, u, s in self._all_hosts if s != '.netrc']
3079
3080 def print_current_creds(self, include_netrc=False):
3081 hosts = sorted(self.get_hosts_with_creds(include_netrc=include_netrc))
3082 if not hosts:
3083 print('No Git/Gerrit credentials found')
3084 return
Edward Lemur79d4f992019-11-11 23:49:02 +00003085 lengths = [max(map(len, (row[i] for row in hosts))) for i in range(3)]
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003086 header = [('Host', 'User', 'Which file'),
3087 ['=' * l for l in lengths]]
3088 for row in (header + hosts):
3089 print('\t'.join((('%%+%ds' % l) % s)
3090 for l, s in zip(lengths, row)))
3091
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003092 @staticmethod
3093 def _parse_identity(identity):
Lei Zhangd3f769a2017-12-15 15:16:14 -08003094 """Parses identity "git-<username>.domain" into <username> and domain."""
3095 # Special case: usernames that contain ".", which are generally not
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +02003096 # distinguishable from sub-domains. But we do know typical domains:
3097 if identity.endswith('.chromium.org'):
3098 domain = 'chromium.org'
3099 username = identity[:-len('.chromium.org')]
3100 else:
3101 username, domain = identity.split('.', 1)
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003102 if username.startswith('git-'):
3103 username = username[len('git-'):]
3104 return username, domain
3105
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003106 def _canonical_git_googlesource_host(self, host):
3107 """Normalizes Gerrit hosts (with '-review') to Git host."""
3108 assert host.endswith(self._GOOGLESOURCE)
3109 # Prefix doesn't include '.' at the end.
3110 prefix = host[:-(1 + len(self._GOOGLESOURCE))]
3111 if prefix.endswith('-review'):
3112 prefix = prefix[:-len('-review')]
3113 return prefix + '.' + self._GOOGLESOURCE
3114
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003115 def _canonical_gerrit_googlesource_host(self, host):
3116 git_host = self._canonical_git_googlesource_host(host)
3117 prefix = git_host.split('.', 1)[0]
3118 return prefix + '-review.' + self._GOOGLESOURCE
3119
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003120 def _get_counterpart_host(self, host):
3121 assert host.endswith(self._GOOGLESOURCE)
3122 git = self._canonical_git_googlesource_host(host)
3123 gerrit = self._canonical_gerrit_googlesource_host(git)
3124 return git if gerrit == host else gerrit
3125
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003126 def has_generic_host(self):
3127 """Returns whether generic .googlesource.com has been configured.
3128
3129 Chrome Infra recommends to use explicit ${host}.googlesource.com instead.
3130 """
3131 for host, _, _ in self.get_hosts_with_creds(include_netrc=False):
3132 if host == '.' + self._GOOGLESOURCE:
3133 return True
3134 return False
3135
3136 def _get_git_gerrit_identity_pairs(self):
3137 """Returns map from canonic host to pair of identities (Git, Gerrit).
3138
3139 One of identities might be None, meaning not configured.
3140 """
3141 host_to_identity_pairs = {}
3142 for host, identity, _ in self.get_hosts_with_creds():
3143 canonical = self._canonical_git_googlesource_host(host)
3144 pair = host_to_identity_pairs.setdefault(canonical, [None, None])
3145 idx = 0 if canonical == host else 1
3146 pair[idx] = identity
3147 return host_to_identity_pairs
3148
3149 def get_partially_configured_hosts(self):
3150 return set(
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003151 (host if i1 else self._canonical_gerrit_googlesource_host(host))
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00003152 for host, (i1, i2) in self._get_git_gerrit_identity_pairs().items()
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003153 if None in (i1, i2) and host != '.' + self._GOOGLESOURCE)
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003154
3155 def get_conflicting_hosts(self):
3156 return set(
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003157 host
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00003158 for host, (i1, i2) in self._get_git_gerrit_identity_pairs().items()
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003159 if None not in (i1, i2) and i1 != i2)
3160
3161 def get_duplicated_hosts(self):
3162 counters = collections.Counter(h for h, _, _ in self.get_hosts_with_creds())
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00003163 return set(host for host, count in counters.items() if count > 1)
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003164
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003165
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003166 @staticmethod
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003167 def _format_hosts(hosts, extra_column_func=None):
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003168 hosts = sorted(hosts)
3169 assert hosts
3170 if extra_column_func is None:
3171 extras = [''] * len(hosts)
3172 else:
3173 extras = [extra_column_func(host) for host in hosts]
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003174 tmpl = '%%-%ds %%-%ds' % (max(map(len, hosts)), max(map(len, extras)))
3175 lines = []
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003176 for he in zip(hosts, extras):
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003177 lines.append(tmpl % he)
3178 return lines
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003179
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003180 def _find_problems(self):
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003181 if self.has_generic_host():
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003182 yield ('.googlesource.com wildcard record detected',
3183 ['Chrome Infrastructure team recommends to list full host names '
3184 'explicitly.'],
3185 None)
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003186
3187 dups = self.get_duplicated_hosts()
3188 if dups:
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003189 yield ('The following hosts were defined twice',
3190 self._format_hosts(dups),
3191 None)
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003192
3193 partial = self.get_partially_configured_hosts()
3194 if partial:
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003195 yield ('Credentials should come in pairs for Git and Gerrit hosts. '
3196 'These hosts are missing',
3197 self._format_hosts(partial, lambda host: 'but %s defined' %
3198 self._get_counterpart_host(host)),
3199 partial)
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003200
3201 conflicting = self.get_conflicting_hosts()
3202 if conflicting:
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003203 yield ('The following Git hosts have differing credentials from their '
3204 'Gerrit counterparts',
3205 self._format_hosts(conflicting, lambda host: '%s vs %s' %
3206 tuple(self._get_git_gerrit_identity_pairs()[host])),
3207 conflicting)
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003208
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003209 def find_and_report_problems(self):
3210 """Returns True if there was at least one problem, else False."""
3211 found = False
3212 bad_hosts = set()
3213 for title, sublines, hosts in self._find_problems():
3214 if not found:
3215 found = True
3216 print('\n\n.gitcookies problem report:\n')
3217 bad_hosts.update(hosts or [])
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003218 print(' %s%s' % (title, (':' if sublines else '')))
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003219 if sublines:
3220 print()
3221 print(' %s' % '\n '.join(sublines))
3222 print()
3223
3224 if bad_hosts:
3225 assert found
3226 print(' You can manually remove corresponding lines in your %s file and '
3227 'visit the following URLs with correct account to generate '
3228 'correct credential lines:\n' %
3229 gerrit_util.CookiesAuthenticator.get_gitcookies_path())
3230 print(' %s' % '\n '.join(sorted(set(
3231 gerrit_util.CookiesAuthenticator().get_new_password_url(
3232 self._canonical_git_googlesource_host(host))
3233 for host in bad_hosts
3234 ))))
3235 return found
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003236
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003237
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003238@metrics.collector.collect_metrics('git cl creds-check')
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003239def CMDcreds_check(parser, args):
3240 """Checks credentials and suggests changes."""
3241 _, _ = parser.parse_args(args)
3242
Vadim Shtayurab250ec12018-10-04 00:21:08 +00003243 # Code below checks .gitcookies. Abort if using something else.
3244 authn = gerrit_util.Authenticator.get()
3245 if not isinstance(authn, gerrit_util.CookiesAuthenticator):
Edward Lemur57d47422020-03-06 20:43:07 +00003246 message = (
Vadim Shtayurab250ec12018-10-04 00:21:08 +00003247 'This command is not designed for bot environment. It checks '
3248 '~/.gitcookies file not generally used on bots.')
Edward Lemur57d47422020-03-06 20:43:07 +00003249 # TODO(crbug.com/1059384): Automatically detect when running on cloudtop.
3250 if isinstance(authn, gerrit_util.GceAuthenticator):
3251 message += (
3252 '\n'
3253 'If you need to run this on GCE or a cloudtop instance, '
3254 'export SKIP_GCE_AUTH_FOR_GIT=1 in your env.')
3255 DieWithError(message)
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003256
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003257 checker = _GitCookiesChecker()
3258 checker.ensure_configured_gitcookies()
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003259
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003260 print('Your .netrc and .gitcookies have credentials for these hosts:')
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003261 checker.print_current_creds(include_netrc=True)
3262
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003263 if not checker.find_and_report_problems():
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003264 print('\nNo problems detected in your .gitcookies file.')
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003265 return 0
3266 return 1
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003267
3268
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003269@metrics.collector.collect_metrics('git cl baseurl')
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00003270def CMDbaseurl(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00003271 """Gets or sets base-url for this branch."""
Edward Lesmes50da7702020-03-30 19:23:43 +00003272 branchref = scm.GIT.GetBranchRef(settings.GetRoot())
Edward Lemur85153282020-02-14 22:06:29 +00003273 branch = scm.GIT.ShortBranchName(branchref)
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00003274 _, args = parser.parse_args(args)
3275 if not args:
vapiera7fbd5a2016-06-16 09:17:49 -07003276 print('Current base-url:')
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00003277 return RunGit(['config', 'branch.%s.base-url' % branch],
3278 error_ok=False).strip()
3279 else:
vapiera7fbd5a2016-06-16 09:17:49 -07003280 print('Setting base-url to %s' % args[0])
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00003281 return RunGit(['config', 'branch.%s.base-url' % branch, args[0]],
3282 error_ok=False).strip()
3283
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003284
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00003285def color_for_status(status):
3286 """Maps a Changelist status to color, for CMDstatus and other tools."""
Bruce Dawsonb73f8a92020-03-27 22:03:08 +00003287 BOLD = '\033[1m'
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00003288 return {
Bruce Dawsonb73f8a92020-03-27 22:03:08 +00003289 'unsent': BOLD + Fore.YELLOW,
3290 'waiting': BOLD + Fore.RED,
3291 'reply': BOLD + Fore.YELLOW,
3292 'not lgtm': BOLD + Fore.RED,
3293 'lgtm': BOLD + Fore.GREEN,
3294 'commit': BOLD + Fore.MAGENTA,
3295 'closed': BOLD + Fore.CYAN,
3296 'error': BOLD + Fore.WHITE,
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00003297 }.get(status, Fore.WHITE)
3298
tandrii@chromium.org04ea8462016-04-25 19:51:21 +00003299
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003300def get_cl_statuses(changes, fine_grained, max_processes=None):
3301 """Returns a blocking iterable of (cl, status) for given branches.
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00003302
3303 If fine_grained is true, this will fetch CL statuses from the server.
3304 Otherwise, simply indicate if there's a matching url for the given branches.
3305
3306 If max_processes is specified, it is used as the maximum number of processes
3307 to spawn to fetch CL status from the server. Otherwise 1 process per branch is
3308 spawned.
calamity@chromium.orgcf197482016-04-29 20:15:53 +00003309
3310 See GetStatus() for a list of possible statuses.
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00003311 """
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01003312 if not changes:
Edward Lemur61bf4172020-02-24 23:22:37 +00003313 return
calamity@chromium.orgcf197482016-04-29 20:15:53 +00003314
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01003315 if not fine_grained:
3316 # Fast path which doesn't involve querying codereview servers.
Aaron Gablea1bab272017-04-11 16:38:18 -07003317 # Do not use get_approving_reviewers(), since it requires an HTTP request.
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003318 for cl in changes:
3319 yield (cl, 'waiting' if cl.GetIssueURL() else 'error')
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01003320 return
3321
3322 # First, sort out authentication issues.
3323 logging.debug('ensuring credentials exist')
3324 for cl in changes:
3325 cl.EnsureAuthenticated(force=False, refresh=True)
3326
3327 def fetch(cl):
3328 try:
3329 return (cl, cl.GetStatus())
3330 except:
3331 # See http://crbug.com/629863.
Andrii Shyshkalov98824232018-04-19 11:37:15 -07003332 logging.exception('failed to fetch status for cl %s:', cl.GetIssue())
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01003333 raise
3334
3335 threads_count = len(changes)
3336 if max_processes:
3337 threads_count = max(1, min(threads_count, max_processes))
3338 logging.debug('querying %d CLs using %d threads', len(changes), threads_count)
3339
Edward Lemur61bf4172020-02-24 23:22:37 +00003340 pool = multiprocessing.pool.ThreadPool(threads_count)
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01003341 fetched_cls = set()
3342 try:
3343 it = pool.imap_unordered(fetch, changes).__iter__()
3344 while True:
3345 try:
3346 cl, status = it.next(timeout=5)
Edward Lemur61bf4172020-02-24 23:22:37 +00003347 except (multiprocessing.TimeoutError, StopIteration):
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01003348 break
3349 fetched_cls.add(cl)
3350 yield cl, status
3351 finally:
3352 pool.close()
3353
3354 # Add any branches that failed to fetch.
3355 for cl in set(changes) - fetched_cls:
3356 yield (cl, 'error')
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00003357
rmistry@google.com2dd99862015-06-22 12:22:18 +00003358
Jose Lopes3863fc52020-04-07 17:00:25 +00003359def upload_branch_deps(cl, args, force=False):
rmistry@google.com2dd99862015-06-22 12:22:18 +00003360 """Uploads CLs of local branches that are dependents of the current branch.
3361
3362 If the local branch dependency tree looks like:
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003363
3364 test1 -> test2.1 -> test3.1
3365 -> test3.2
3366 -> test2.2 -> test3.3
rmistry@google.com2dd99862015-06-22 12:22:18 +00003367
3368 and you run "git cl upload --dependencies" from test1 then "git cl upload" is
3369 run on the dependent branches in this order:
3370 test2.1, test3.1, test3.2, test2.2, test3.3
3371
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003372 Note: This function does not rebase your local dependent branches. Use it
3373 when you make a change to the parent branch that will not conflict
3374 with its dependent branches, and you would like their dependencies
3375 updated in Rietveld.
rmistry@google.com2dd99862015-06-22 12:22:18 +00003376 """
3377 if git_common.is_dirty_git_tree('upload-branch-deps'):
3378 return 1
3379
3380 root_branch = cl.GetBranch()
3381 if root_branch is None:
3382 DieWithError('Can\'t find dependent branches from detached HEAD state. '
3383 'Get on a branch!')
Andrii Shyshkalov9f274432018-10-15 16:40:23 +00003384 if not cl.GetIssue():
rmistry@google.com2dd99862015-06-22 12:22:18 +00003385 DieWithError('Current branch does not have an uploaded CL. We cannot set '
3386 'patchset dependencies without an uploaded CL.')
3387
3388 branches = RunGit(['for-each-ref',
3389 '--format=%(refname:short) %(upstream:short)',
3390 'refs/heads'])
3391 if not branches:
3392 print('No local branches found.')
3393 return 0
3394
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003395 # Create a dictionary of all local branches to the branches that are
3396 # dependent on it.
rmistry@google.com2dd99862015-06-22 12:22:18 +00003397 tracked_to_dependents = collections.defaultdict(list)
3398 for b in branches.splitlines():
3399 tokens = b.split()
3400 if len(tokens) == 2:
3401 branch_name, tracked = tokens
3402 tracked_to_dependents[tracked].append(branch_name)
3403
vapiera7fbd5a2016-06-16 09:17:49 -07003404 print()
3405 print('The dependent local branches of %s are:' % root_branch)
rmistry@google.com2dd99862015-06-22 12:22:18 +00003406 dependents = []
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003407
rmistry@google.com2dd99862015-06-22 12:22:18 +00003408 def traverse_dependents_preorder(branch, padding=''):
3409 dependents_to_process = tracked_to_dependents.get(branch, [])
3410 padding += ' '
3411 for dependent in dependents_to_process:
vapiera7fbd5a2016-06-16 09:17:49 -07003412 print('%s%s' % (padding, dependent))
rmistry@google.com2dd99862015-06-22 12:22:18 +00003413 dependents.append(dependent)
3414 traverse_dependents_preorder(dependent, padding)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003415
rmistry@google.com2dd99862015-06-22 12:22:18 +00003416 traverse_dependents_preorder(root_branch)
vapiera7fbd5a2016-06-16 09:17:49 -07003417 print()
rmistry@google.com2dd99862015-06-22 12:22:18 +00003418
3419 if not dependents:
vapiera7fbd5a2016-06-16 09:17:49 -07003420 print('There are no dependent local branches for %s' % root_branch)
rmistry@google.com2dd99862015-06-22 12:22:18 +00003421 return 0
3422
Jose Lopes3863fc52020-04-07 17:00:25 +00003423 if not force:
3424 confirm_or_exit('This command will checkout all dependent branches and run '
3425 '"git cl upload".', action='continue')
rmistry@google.com2dd99862015-06-22 12:22:18 +00003426
rmistry@google.com2dd99862015-06-22 12:22:18 +00003427 # Record all dependents that failed to upload.
3428 failures = {}
3429 # Go through all dependents, checkout the branch and upload.
3430 try:
3431 for dependent_branch in dependents:
vapiera7fbd5a2016-06-16 09:17:49 -07003432 print()
3433 print('--------------------------------------')
3434 print('Running "git cl upload" from %s:' % dependent_branch)
rmistry@google.com2dd99862015-06-22 12:22:18 +00003435 RunGit(['checkout', '-q', dependent_branch])
vapiera7fbd5a2016-06-16 09:17:49 -07003436 print()
rmistry@google.com2dd99862015-06-22 12:22:18 +00003437 try:
3438 if CMDupload(OptionParser(), args) != 0:
vapiera7fbd5a2016-06-16 09:17:49 -07003439 print('Upload failed for %s!' % dependent_branch)
rmistry@google.com2dd99862015-06-22 12:22:18 +00003440 failures[dependent_branch] = 1
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -08003441 except: # pylint: disable=bare-except
rmistry@google.com2dd99862015-06-22 12:22:18 +00003442 failures[dependent_branch] = 1
vapiera7fbd5a2016-06-16 09:17:49 -07003443 print()
rmistry@google.com2dd99862015-06-22 12:22:18 +00003444 finally:
3445 # Swap back to the original root branch.
3446 RunGit(['checkout', '-q', root_branch])
3447
vapiera7fbd5a2016-06-16 09:17:49 -07003448 print()
3449 print('Upload complete for dependent branches!')
rmistry@google.com2dd99862015-06-22 12:22:18 +00003450 for dependent_branch in dependents:
3451 upload_status = 'failed' if failures.get(dependent_branch) else 'succeeded'
vapiera7fbd5a2016-06-16 09:17:49 -07003452 print(' %s : %s' % (dependent_branch, upload_status))
3453 print()
rmistry@google.com2dd99862015-06-22 12:22:18 +00003454
3455 return 0
3456
3457
Tibor Goldschwendt7c5efb22020-03-25 01:23:54 +00003458def GetArchiveTagForBranch(issue_num, branch_name, existing_tags, pattern):
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00003459 """Given a proposed tag name, returns a tag name that is guaranteed to be
3460 unique. If 'foo' is proposed but already exists, then 'foo-2' is used,
3461 or 'foo-3', and so on."""
3462
Tibor Goldschwendt7c5efb22020-03-25 01:23:54 +00003463 proposed_tag = pattern.format(**{'issue': issue_num, 'branch': branch_name})
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00003464 for suffix_num in itertools.count(1):
3465 if suffix_num == 1:
3466 to_check = proposed_tag
3467 else:
3468 to_check = '%s-%d' % (proposed_tag, suffix_num)
3469
3470 if to_check not in existing_tags:
3471 return to_check
3472
3473
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003474@metrics.collector.collect_metrics('git cl archive')
kmarshall3bff56b2016-06-06 18:31:47 -07003475def CMDarchive(parser, args):
3476 """Archives and deletes branches associated with closed changelists."""
3477 parser.add_option(
3478 '-j', '--maxjobs', action='store', type=int,
kmarshall9249e012016-08-23 12:02:16 -07003479 help='The maximum number of jobs to use when retrieving review status.')
kmarshall3bff56b2016-06-06 18:31:47 -07003480 parser.add_option(
3481 '-f', '--force', action='store_true',
3482 help='Bypasses the confirmation prompt.')
kmarshall9249e012016-08-23 12:02:16 -07003483 parser.add_option(
3484 '-d', '--dry-run', action='store_true',
3485 help='Skip the branch tagging and removal steps.')
3486 parser.add_option(
3487 '-t', '--notags', action='store_true',
3488 help='Do not tag archived branches. '
3489 'Note: local commit history may be lost.')
Tibor Goldschwendt7c5efb22020-03-25 01:23:54 +00003490 parser.add_option(
3491 '-p',
3492 '--pattern',
3493 default='git-cl-archived-{issue}-{branch}',
3494 help='Format string for archive tags. '
3495 'E.g. \'archived-{issue}-{branch}\'.')
kmarshall3bff56b2016-06-06 18:31:47 -07003496
kmarshall3bff56b2016-06-06 18:31:47 -07003497 options, args = parser.parse_args(args)
3498 if args:
3499 parser.error('Unsupported args: %s' % ' '.join(args))
kmarshall3bff56b2016-06-06 18:31:47 -07003500
3501 branches = RunGit(['for-each-ref', '--format=%(refname)', 'refs/heads'])
3502 if not branches:
3503 return 0
3504
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00003505 tags = RunGit(['for-each-ref', '--format=%(refname)',
3506 'refs/tags']).splitlines() or []
3507 tags = [t.split('/')[-1] for t in tags]
3508
vapiera7fbd5a2016-06-16 09:17:49 -07003509 print('Finding all branches associated with closed issues...')
Edward Lemur934836a2019-09-09 20:16:54 +00003510 changes = [Changelist(branchref=b)
3511 for b in branches.splitlines()]
kmarshall3bff56b2016-06-06 18:31:47 -07003512 alignment = max(5, max(len(c.GetBranch()) for c in changes))
3513 statuses = get_cl_statuses(changes,
3514 fine_grained=True,
3515 max_processes=options.maxjobs)
3516 proposal = [(cl.GetBranch(),
Tibor Goldschwendt7c5efb22020-03-25 01:23:54 +00003517 GetArchiveTagForBranch(cl.GetIssue(), cl.GetBranch(), tags,
3518 options.pattern))
kmarshall3bff56b2016-06-06 18:31:47 -07003519 for cl, status in statuses
Andrii Shyshkalov51bdf8c2018-10-18 01:07:58 +00003520 if status in ('closed', 'rietveld-not-supported')]
kmarshall3bff56b2016-06-06 18:31:47 -07003521 proposal.sort()
3522
3523 if not proposal:
vapiera7fbd5a2016-06-16 09:17:49 -07003524 print('No branches with closed codereview issues found.')
kmarshall3bff56b2016-06-06 18:31:47 -07003525 return 0
3526
Edward Lemur85153282020-02-14 22:06:29 +00003527 current_branch = scm.GIT.GetBranch(settings.GetRoot())
kmarshall3bff56b2016-06-06 18:31:47 -07003528
vapiera7fbd5a2016-06-16 09:17:49 -07003529 print('\nBranches with closed issues that will be archived:\n')
kmarshall9249e012016-08-23 12:02:16 -07003530 if options.notags:
3531 for next_item in proposal:
3532 print(' ' + next_item[0])
3533 else:
3534 print('%*s | %s' % (alignment, 'Branch name', 'Archival tag name'))
3535 for next_item in proposal:
3536 print('%*s %s' % (alignment, next_item[0], next_item[1]))
kmarshall3bff56b2016-06-06 18:31:47 -07003537
kmarshall9249e012016-08-23 12:02:16 -07003538 # Quit now on precondition failure or if instructed by the user, either
3539 # via an interactive prompt or by command line flags.
3540 if options.dry_run:
3541 print('\nNo changes were made (dry run).\n')
3542 return 0
3543 elif any(branch == current_branch for branch, _ in proposal):
kmarshall3bff56b2016-06-06 18:31:47 -07003544 print('You are currently on a branch \'%s\' which is associated with a '
3545 'closed codereview issue, so archive cannot proceed. Please '
3546 'checkout another branch and run this command again.' %
3547 current_branch)
3548 return 1
kmarshall9249e012016-08-23 12:02:16 -07003549 elif not options.force:
Edward Lesmesae3586b2020-03-23 21:21:14 +00003550 answer = gclient_utils.AskForData('\nProceed with deletion (Y/n)? ').lower()
sergiyb4a5ecbe2016-06-20 09:46:00 -07003551 if answer not in ('y', ''):
vapiera7fbd5a2016-06-16 09:17:49 -07003552 print('Aborted.')
kmarshall3bff56b2016-06-06 18:31:47 -07003553 return 1
3554
3555 for branch, tagname in proposal:
kmarshall9249e012016-08-23 12:02:16 -07003556 if not options.notags:
3557 RunGit(['tag', tagname, branch])
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00003558
3559 if RunGitWithCode(['branch', '-D', branch])[0] != 0:
3560 # Clean up the tag if we failed to delete the branch.
3561 RunGit(['tag', '-d', tagname])
kmarshall9249e012016-08-23 12:02:16 -07003562
vapiera7fbd5a2016-06-16 09:17:49 -07003563 print('\nJob\'s done!')
kmarshall3bff56b2016-06-06 18:31:47 -07003564
3565 return 0
3566
3567
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003568@metrics.collector.collect_metrics('git cl status')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003569def CMDstatus(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00003570 """Show status of changelists.
3571
3572 Colors are used to tell the state of the CL unless --fast is used:
jsbell@chromium.orgaeab41a2013-12-10 20:01:22 +00003573 - Blue waiting for review
Aaron Gable9ab38c62017-04-06 14:36:33 -07003574 - Yellow waiting for you to reply to review, or not yet sent
jsbell@chromium.orgaeab41a2013-12-10 20:01:22 +00003575 - Green LGTM'ed
Aaron Gable9ab38c62017-04-06 14:36:33 -07003576 - Red 'not LGTM'ed
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +00003577 - Magenta in the CQ
jsbell@chromium.orgaeab41a2013-12-10 20:01:22 +00003578 - Cyan was committed, branch can be deleted
Aaron Gable9ab38c62017-04-06 14:36:33 -07003579 - White error, or unknown status
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00003580
3581 Also see 'git cl comments'.
3582 """
Alan Cuttera3be9a52019-03-04 18:50:33 +00003583 parser.add_option(
3584 '--no-branch-color',
3585 action='store_true',
3586 help='Disable colorized branch names')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003587 parser.add_option('--field',
phajdan.jr289d03e2016-08-16 08:21:06 -07003588 help='print only specific field (desc|id|patch|status|url)')
maruel@chromium.org1033efd2013-07-23 23:25:09 +00003589 parser.add_option('-f', '--fast', action='store_true',
3590 help='Do not retrieve review status')
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00003591 parser.add_option(
3592 '-j', '--maxjobs', action='store', type=int,
3593 help='The maximum number of jobs to use when retrieving review status')
Edward Lemur52969c92020-02-06 18:15:28 +00003594 parser.add_option(
3595 '-i', '--issue', type=int,
3596 help='Operate on this issue instead of the current branch\'s implicit '
3597 'issue. Requires --field to be set.')
Sigurd Schneider9abde8c2020-11-17 08:44:52 +00003598 parser.add_option('-d',
3599 '--date-order',
3600 action='store_true',
3601 help='Order branches by committer date.')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00003602 options, args = parser.parse_args(args)
maruel@chromium.org39c0b222013-08-17 16:57:01 +00003603 if args:
3604 parser.error('Unsupported args: %s' % args)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003605
iannuccie53c9352016-08-17 14:40:40 -07003606 if options.issue is not None and not options.field:
Edward Lemur6c6827c2020-02-06 21:15:18 +00003607 parser.error('--field must be given when --issue is set.')
iannucci3c972b92016-08-17 13:24:10 -07003608
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003609 if options.field:
Edward Lemur934836a2019-09-09 20:16:54 +00003610 cl = Changelist(issue=options.issue)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003611 if options.field.startswith('desc'):
Edward Lemur6c6827c2020-02-06 21:15:18 +00003612 if cl.GetIssue():
3613 print(cl.FetchDescription())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003614 elif options.field == 'id':
3615 issueid = cl.GetIssue()
3616 if issueid:
vapiera7fbd5a2016-06-16 09:17:49 -07003617 print(issueid)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003618 elif options.field == 'patch':
Aaron Gablee8856ee2017-12-07 12:41:46 -08003619 patchset = cl.GetMostRecentPatchset()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003620 if patchset:
vapiera7fbd5a2016-06-16 09:17:49 -07003621 print(patchset)
phajdan.jr289d03e2016-08-16 08:21:06 -07003622 elif options.field == 'status':
3623 print(cl.GetStatus())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003624 elif options.field == 'url':
3625 url = cl.GetIssueURL()
3626 if url:
vapiera7fbd5a2016-06-16 09:17:49 -07003627 print(url)
maruel@chromium.orge25c75b2013-07-23 18:30:56 +00003628 return 0
3629
Sigurd Schneider9abde8c2020-11-17 08:44:52 +00003630 branches = RunGit([
3631 'for-each-ref', '--format=%(refname) %(committerdate:unix)', 'refs/heads'
3632 ])
maruel@chromium.orge25c75b2013-07-23 18:30:56 +00003633 if not branches:
3634 print('No local branch found.')
3635 return 0
3636
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003637 changes = [
Sigurd Schneider9abde8c2020-11-17 08:44:52 +00003638 Changelist(branchref=b, commit_date=ct)
3639 for b, ct in map(lambda line: line.split(' '), branches.splitlines())
3640 ]
vapiera7fbd5a2016-06-16 09:17:49 -07003641 print('Branches associated with reviews:')
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003642 output = get_cl_statuses(changes,
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00003643 fine_grained=not options.fast,
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003644 max_processes=options.maxjobs)
maruel@chromium.org1033efd2013-07-23 23:25:09 +00003645
Edward Lemur85153282020-02-14 22:06:29 +00003646 current_branch = scm.GIT.GetBranch(settings.GetRoot())
Daniel McArdlea23bf592019-02-12 00:25:12 +00003647
3648 def FormatBranchName(branch, colorize=False):
3649 """Simulates 'git branch' behavior. Colorizes and prefixes branch name with
3650 an asterisk when it is the current branch."""
3651
3652 asterisk = ""
3653 color = Fore.RESET
3654 if branch == current_branch:
3655 asterisk = "* "
3656 color = Fore.GREEN
Edward Lemur85153282020-02-14 22:06:29 +00003657 branch_name = scm.GIT.ShortBranchName(branch)
Daniel McArdlea23bf592019-02-12 00:25:12 +00003658
3659 if colorize:
3660 return asterisk + color + branch_name + Fore.RESET
Daniel McArdle452a49f2019-02-14 17:28:31 +00003661 return asterisk + branch_name
3662
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00003663 branch_statuses = {}
Daniel McArdlea23bf592019-02-12 00:25:12 +00003664
3665 alignment = max(5, max(len(FormatBranchName(c.GetBranch())) for c in changes))
Sigurd Schneider9abde8c2020-11-17 08:44:52 +00003666 if options.date_order:
3667 sorted_changes = sorted(changes,
3668 key=lambda c: c.GetCommitDate(),
3669 reverse=True)
3670 else:
3671 sorted_changes = sorted(changes, key=lambda c: c.GetBranch())
3672 for cl in sorted_changes:
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003673 branch = cl.GetBranch()
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00003674 while branch not in branch_statuses:
Edward Lemur79d4f992019-11-11 23:49:02 +00003675 c, status = next(output)
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003676 branch_statuses[c.GetBranch()] = status
3677 status = branch_statuses.pop(branch)
Andrii Shyshkalov1ee78cd2020-03-12 01:31:53 +00003678 url = cl.GetIssueURL(short=True)
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003679 if url and (not status or status == 'error'):
3680 # The issue probably doesn't exist anymore.
3681 url += ' (broken)'
3682
nodir@chromium.orga6de1f42015-06-10 04:23:17 +00003683 color = color_for_status(status)
Bruce Dawsonb73f8a92020-03-27 22:03:08 +00003684 # Turn off bold as well as colors.
3685 END = '\033[0m'
3686 reset = Fore.RESET + END
iannucci@chromium.org596cd5c2016-04-04 21:34:39 +00003687 if not setup_color.IS_TTY:
maruel@chromium.org885f6512013-07-27 02:17:26 +00003688 color = ''
3689 reset = ''
nodir@chromium.orga6de1f42015-06-10 04:23:17 +00003690 status_str = '(%s)' % status if status else ''
Daniel McArdle452a49f2019-02-14 17:28:31 +00003691
Alan Cuttera3be9a52019-03-04 18:50:33 +00003692 branch_display = FormatBranchName(branch)
3693 padding = ' ' * (alignment - len(branch_display))
3694 if not options.no_branch_color:
3695 branch_display = FormatBranchName(branch, colorize=True)
Daniel McArdle452a49f2019-02-14 17:28:31 +00003696
Alan Cuttera3be9a52019-03-04 18:50:33 +00003697 print(' %s : %s%s %s%s' % (padding + branch_display, color, url,
3698 status_str, reset))
Andrii Shyshkalovd0e1d9d2017-01-24 17:10:51 +01003699
vapiera7fbd5a2016-06-16 09:17:49 -07003700 print()
Daniel McArdlea23bf592019-02-12 00:25:12 +00003701 print('Current branch: %s' % current_branch)
Andrii Shyshkalovd0e1d9d2017-01-24 17:10:51 +01003702 for cl in changes:
Daniel McArdlea23bf592019-02-12 00:25:12 +00003703 if cl.GetBranch() == current_branch:
Andrii Shyshkalovd0e1d9d2017-01-24 17:10:51 +01003704 break
dpranke@chromium.orgee87f582015-07-31 18:46:25 +00003705 if not cl.GetIssue():
vapiera7fbd5a2016-06-16 09:17:49 -07003706 print('No issue assigned.')
dpranke@chromium.orgee87f582015-07-31 18:46:25 +00003707 return 0
vapiera7fbd5a2016-06-16 09:17:49 -07003708 print('Issue number: %s (%s)' % (cl.GetIssue(), cl.GetIssueURL()))
maruel@chromium.org85616e02014-07-28 15:37:55 +00003709 if not options.fast:
vapiera7fbd5a2016-06-16 09:17:49 -07003710 print('Issue description:')
Edward Lemur6c6827c2020-02-06 21:15:18 +00003711 print(cl.FetchDescription(pretty=True))
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003712 return 0
3713
3714
maruel@chromium.org39c0b222013-08-17 16:57:01 +00003715def colorize_CMDstatus_doc():
3716 """To be called once in main() to add colors to git cl status help."""
3717 colors = [i for i in dir(Fore) if i[0].isupper()]
3718
3719 def colorize_line(line):
3720 for color in colors:
3721 if color in line.upper():
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003722 # Extract whitespace first and the leading '-'.
maruel@chromium.org39c0b222013-08-17 16:57:01 +00003723 indent = len(line) - len(line.lstrip(' ')) + 1
3724 return line[:indent] + getattr(Fore, color) + line[indent:] + Fore.RESET
3725 return line
3726
3727 lines = CMDstatus.__doc__.splitlines()
3728 CMDstatus.__doc__ = '\n'.join(colorize_line(l) for l in lines)
3729
3730
phajdan.jre328cf92016-08-22 04:12:17 -07003731def write_json(path, contents):
Stefan Zager1306bd02017-06-22 19:26:46 -07003732 if path == '-':
3733 json.dump(contents, sys.stdout)
3734 else:
3735 with open(path, 'w') as f:
3736 json.dump(contents, f)
phajdan.jre328cf92016-08-22 04:12:17 -07003737
3738
maruel@chromium.org0633fb42013-08-16 20:06:14 +00003739@subcommand.usage('[issue_number]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003740@metrics.collector.collect_metrics('git cl issue')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003741def CMDissue(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00003742 """Sets or displays the current code review issue number.
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003743
3744 Pass issue number 0 to clear the current issue.
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00003745 """
dnj@chromium.org406c4402015-03-03 17:22:28 +00003746 parser.add_option('-r', '--reverse', action='store_true',
3747 help='Lookup the branch(es) for the specified issues. If '
3748 'no issues are specified, all branches with mapped '
3749 'issues will be listed.')
Stefan Zager1306bd02017-06-22 19:26:46 -07003750 parser.add_option('--json',
3751 help='Path to JSON output file, or "-" for stdout.')
dnj@chromium.org406c4402015-03-03 17:22:28 +00003752 options, args = parser.parse_args(args)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003753
dnj@chromium.org406c4402015-03-03 17:22:28 +00003754 if options.reverse:
3755 branches = RunGit(['for-each-ref', 'refs/heads',
Aaron Gablead64abd2017-12-04 09:49:13 -08003756 '--format=%(refname)']).splitlines()
dnj@chromium.org406c4402015-03-03 17:22:28 +00003757 # Reverse issue lookup.
3758 issue_branch_map = {}
Daniel Bratellb56a43a2018-09-06 15:49:03 +00003759
3760 git_config = {}
3761 for config in RunGit(['config', '--get-regexp',
3762 r'branch\..*issue']).splitlines():
3763 name, _space, val = config.partition(' ')
3764 git_config[name] = val
3765
dnj@chromium.org406c4402015-03-03 17:22:28 +00003766 for branch in branches:
Edward Lesmes50da7702020-03-30 19:23:43 +00003767 issue = git_config.get(
3768 'branch.%s.%s' % (scm.GIT.ShortBranchName(branch), ISSUE_CONFIG_KEY))
Edward Lemur52969c92020-02-06 18:15:28 +00003769 if issue:
3770 issue_branch_map.setdefault(int(issue), []).append(branch)
dnj@chromium.org406c4402015-03-03 17:22:28 +00003771 if not args:
Carlos Caballero81923d62020-07-06 18:22:27 +00003772 args = sorted(issue_branch_map.keys())
phajdan.jre328cf92016-08-22 04:12:17 -07003773 result = {}
dnj@chromium.org406c4402015-03-03 17:22:28 +00003774 for issue in args:
Lei Zhang5a368d42019-03-25 23:18:19 +00003775 try:
3776 issue_num = int(issue)
3777 except ValueError:
3778 print('ERROR cannot parse issue number: %s' % issue, file=sys.stderr)
dnj@chromium.org406c4402015-03-03 17:22:28 +00003779 continue
Lei Zhang5a368d42019-03-25 23:18:19 +00003780 result[issue_num] = issue_branch_map.get(issue_num)
vapiera7fbd5a2016-06-16 09:17:49 -07003781 print('Branch for issue number %s: %s' % (
Lei Zhang5a368d42019-03-25 23:18:19 +00003782 issue, ', '.join(issue_branch_map.get(issue_num) or ('None',))))
phajdan.jre328cf92016-08-22 04:12:17 -07003783 if options.json:
3784 write_json(options.json, result)
Aaron Gable78753da2017-06-15 10:35:49 -07003785 return 0
3786
3787 if len(args) > 0:
Edward Lemurf38bc172019-09-03 21:02:13 +00003788 issue = ParseIssueNumberArgument(args[0])
Aaron Gable78753da2017-06-15 10:35:49 -07003789 if not issue.valid:
3790 DieWithError('Pass a url or number to set the issue, 0 to unset it, '
3791 'or no argument to list it.\n'
3792 'Maybe you want to run git cl status?')
Edward Lemurf38bc172019-09-03 21:02:13 +00003793 cl = Changelist()
Aaron Gable78753da2017-06-15 10:35:49 -07003794 cl.SetIssue(issue.issue)
dnj@chromium.org406c4402015-03-03 17:22:28 +00003795 else:
Edward Lemurf38bc172019-09-03 21:02:13 +00003796 cl = Changelist()
Aaron Gable78753da2017-06-15 10:35:49 -07003797 print('Issue number: %s (%s)' % (cl.GetIssue(), cl.GetIssueURL()))
3798 if options.json:
3799 write_json(options.json, {
Nodir Turakulov27379632021-03-17 18:53:29 +00003800 'gerrit_host': cl.GetGerritHost(),
3801 'gerrit_project': cl.GetGerritProject(),
Aaron Gable78753da2017-06-15 10:35:49 -07003802 'issue_url': cl.GetIssueURL(),
Nodir Turakulov27379632021-03-17 18:53:29 +00003803 'issue': cl.GetIssue(),
Aaron Gable78753da2017-06-15 10:35:49 -07003804 })
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003805 return 0
3806
3807
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003808@metrics.collector.collect_metrics('git cl comments')
maruel@chromium.org9977a2e2012-06-06 22:30:56 +00003809def CMDcomments(parser, args):
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003810 """Shows or posts review comments for any changelist."""
3811 parser.add_option('-a', '--add-comment', dest='comment',
3812 help='comment to add to an issue')
Sergiy Byelozyorovcb629a42018-10-28 19:20:39 +00003813 parser.add_option('-p', '--publish', action='store_true',
3814 help='marks CL as ready and sends comment to reviewers')
Andrii Shyshkalov0d6b46e2017-03-17 22:23:22 +01003815 parser.add_option('-i', '--issue', dest='issue',
Edward Lemurf38bc172019-09-03 21:02:13 +00003816 help='review issue id (defaults to current issue).')
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07003817 parser.add_option('-m', '--machine-readable', dest='readable',
3818 action='store_false', default=True,
3819 help='output comments in a format compatible with '
3820 'editor parsing')
smut@google.comc85ac942015-09-15 16:34:43 +00003821 parser.add_option('-j', '--json-file',
Stefan Zager1306bd02017-06-22 19:26:46 -07003822 help='File to write JSON summary to, or "-" for stdout')
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003823 options, args = parser.parse_args(args)
maruel@chromium.org9977a2e2012-06-06 22:30:56 +00003824
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003825 issue = None
3826 if options.issue:
3827 try:
3828 issue = int(options.issue)
3829 except ValueError:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00003830 DieWithError('A review issue ID is expected to be a number.')
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003831
Edward Lemur934836a2019-09-09 20:16:54 +00003832 cl = Changelist(issue=issue)
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003833
3834 if options.comment:
Sergiy Byelozyorovcb629a42018-10-28 19:20:39 +00003835 cl.AddComment(options.comment, options.publish)
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003836 return 0
3837
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07003838 summary = sorted(cl.GetCommentsSummary(readable=options.readable),
3839 key=lambda c: c.date)
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01003840 for comment in summary:
3841 if comment.disapproval:
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003842 color = Fore.RED
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01003843 elif comment.approval:
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003844 color = Fore.GREEN
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01003845 elif comment.sender == cl.GetIssueOwner():
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003846 color = Fore.MAGENTA
Quinten Yearsley0e617c02019-02-20 00:37:03 +00003847 elif comment.autogenerated:
3848 color = Fore.CYAN
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003849 else:
3850 color = Fore.BLUE
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01003851 print('\n%s%s %s%s\n%s' % (
3852 color,
3853 comment.date.strftime('%Y-%m-%d %H:%M:%S UTC'),
3854 comment.sender,
3855 Fore.RESET,
3856 '\n'.join(' ' + l for l in comment.message.strip().splitlines())))
3857
smut@google.comc85ac942015-09-15 16:34:43 +00003858 if options.json_file:
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01003859 def pre_serialize(c):
Edward Lemur79d4f992019-11-11 23:49:02 +00003860 dct = c._asdict().copy()
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01003861 dct['date'] = dct['date'].strftime('%Y-%m-%d %H:%M:%S.%f')
3862 return dct
Edward Lemur79d4f992019-11-11 23:49:02 +00003863 write_json(options.json_file, [pre_serialize(x) for x in summary])
maruel@chromium.org9977a2e2012-06-06 22:30:56 +00003864 return 0
3865
3866
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00003867@subcommand.usage('[codereview url or issue id]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003868@metrics.collector.collect_metrics('git cl description')
rsesek@chromium.orgeec76592013-05-20 16:27:57 +00003869def CMDdescription(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00003870 """Brings up the editor for the current CL's description."""
smut@google.com34fb6b12015-07-13 20:03:26 +00003871 parser.add_option('-d', '--display', action='store_true',
3872 help='Display the description instead of opening an editor')
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00003873 parser.add_option('-n', '--new-description',
dnjba1b0f32016-09-02 12:37:42 -07003874 help='New description to set for this issue (- for stdin, '
3875 '+ to load from local commit HEAD)')
dsansomee2d6fd92016-09-08 00:10:47 -07003876 parser.add_option('-f', '--force', action='store_true',
3877 help='Delete any unpublished Gerrit edits for this issue '
3878 'without prompting')
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00003879
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00003880 options, args = parser.parse_args(args)
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00003881
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01003882 target_issue_arg = None
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00003883 if len(args) > 0:
Edward Lemurf38bc172019-09-03 21:02:13 +00003884 target_issue_arg = ParseIssueNumberArgument(args[0])
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01003885 if not target_issue_arg.valid:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00003886 parser.error('Invalid issue ID or URL.')
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00003887
Edward Lemur934836a2019-09-09 20:16:54 +00003888 kwargs = {}
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01003889 if target_issue_arg:
3890 kwargs['issue'] = target_issue_arg.issue
3891 kwargs['codereview_host'] = target_issue_arg.hostname
martiniss6eda05f2016-06-30 10:18:35 -07003892
3893 cl = Changelist(**kwargs)
rsesek@chromium.orgeec76592013-05-20 16:27:57 +00003894 if not cl.GetIssue():
3895 DieWithError('This branch has no associated changelist.')
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02003896
Edward Lemur678a6842019-10-03 22:25:05 +00003897 if args and not args[0].isdigit():
Edward Lemurf38bc172019-09-03 21:02:13 +00003898 logging.info('canonical issue/change URL: %s\n', cl.GetIssueURL())
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02003899
Edward Lemur6c6827c2020-02-06 21:15:18 +00003900 description = ChangeDescription(cl.FetchDescription())
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00003901
smut@google.com34fb6b12015-07-13 20:03:26 +00003902 if options.display:
vapiera7fbd5a2016-06-16 09:17:49 -07003903 print(description.description)
smut@google.com34fb6b12015-07-13 20:03:26 +00003904 return 0
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00003905
3906 if options.new_description:
3907 text = options.new_description
3908 if text == '-':
3909 text = '\n'.join(l.rstrip() for l in sys.stdin)
dnjba1b0f32016-09-02 12:37:42 -07003910 elif text == '+':
3911 base_branch = cl.GetCommonAncestorWithUpstream()
Edward Lemura12175c2020-03-09 16:58:26 +00003912 text = _create_description_from_log([base_branch])
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00003913
3914 description.set_description(text)
3915 else:
Edward Lemurf38bc172019-09-03 21:02:13 +00003916 description.prompt()
Edward Lemur6c6827c2020-02-06 21:15:18 +00003917 if cl.FetchDescription().strip() != description.description:
dsansomee2d6fd92016-09-08 00:10:47 -07003918 cl.UpdateDescription(description.description, force=options.force)
rsesek@chromium.orgeec76592013-05-20 16:27:57 +00003919 return 0
3920
3921
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003922@metrics.collector.collect_metrics('git cl lint')
thestig@chromium.org44202a22014-03-11 19:22:18 +00003923def CMDlint(parser, args):
3924 """Runs cpplint on the current changelist."""
tzik@chromium.orgf204d4b2014-03-13 07:40:55 +00003925 parser.add_option('--filter', action='append', metavar='-x,+y',
3926 help='Comma-separated list of cpplint\'s category-filters')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00003927 options, args = parser.parse_args(args)
thestig@chromium.org44202a22014-03-11 19:22:18 +00003928
3929 # Access to a protected member _XX of a client class
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -08003930 # pylint: disable=protected-access
thestig@chromium.org44202a22014-03-11 19:22:18 +00003931 try:
3932 import cpplint
3933 import cpplint_chromium
3934 except ImportError:
vapiera7fbd5a2016-06-16 09:17:49 -07003935 print('Your depot_tools is missing cpplint.py and/or cpplint_chromium.py.')
thestig@chromium.org44202a22014-03-11 19:22:18 +00003936 return 1
3937
3938 # Change the current working directory before calling lint so that it
3939 # shows the correct base.
3940 previous_cwd = os.getcwd()
3941 os.chdir(settings.GetRoot())
3942 try:
Edward Lemur934836a2019-09-09 20:16:54 +00003943 cl = Changelist()
Edward Lemur2c62b332020-03-12 22:12:33 +00003944 files = cl.GetAffectedFiles(cl.GetCommonAncestorWithUpstream())
thestig@chromium.org5839eb52014-05-30 16:20:51 +00003945 if not files:
vapiera7fbd5a2016-06-16 09:17:49 -07003946 print('Cannot lint an empty CL')
thestig@chromium.org5839eb52014-05-30 16:20:51 +00003947 return 1
thestig@chromium.org44202a22014-03-11 19:22:18 +00003948
Lei Zhangb8c62cf2020-07-15 20:09:37 +00003949 # Process cpplint arguments, if any.
3950 filters = presubmit_canned_checks.GetCppLintFilters(options.filter)
3951 command = ['--filter=' + ','.join(filters)] + args + files
tzik@chromium.orgf204d4b2014-03-13 07:40:55 +00003952 filenames = cpplint.ParseArguments(command)
thestig@chromium.org44202a22014-03-11 19:22:18 +00003953
Lei Zhang379d1ad2020-07-15 19:40:06 +00003954 include_regex = re.compile(settings.GetLintRegex())
3955 ignore_regex = re.compile(settings.GetLintIgnoreRegex())
thestig@chromium.org44202a22014-03-11 19:22:18 +00003956 extra_check_functions = [cpplint_chromium.CheckPointerDeclarationWhitespace]
3957 for filename in filenames:
Lei Zhang379d1ad2020-07-15 19:40:06 +00003958 if not include_regex.match(filename):
vapiera7fbd5a2016-06-16 09:17:49 -07003959 print('Skipping file %s' % filename)
Lei Zhang379d1ad2020-07-15 19:40:06 +00003960 continue
3961
3962 if ignore_regex.match(filename):
3963 print('Ignoring file %s' % filename)
3964 continue
3965
3966 cpplint.ProcessFile(filename, cpplint._cpplint_state.verbose_level,
3967 extra_check_functions)
thestig@chromium.org44202a22014-03-11 19:22:18 +00003968 finally:
3969 os.chdir(previous_cwd)
vapiera7fbd5a2016-06-16 09:17:49 -07003970 print('Total errors found: %d\n' % cpplint._cpplint_state.error_count)
thestig@chromium.org44202a22014-03-11 19:22:18 +00003971 if cpplint._cpplint_state.error_count != 0:
3972 return 1
3973 return 0
3974
3975
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003976@metrics.collector.collect_metrics('git cl presubmit')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003977def CMDpresubmit(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00003978 """Runs presubmit tests on the current changelist."""
ilevy@chromium.org375a9022013-01-07 01:12:05 +00003979 parser.add_option('-u', '--upload', action='store_true',
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08003980 help='Run upload hook instead of the push hook')
ilevy@chromium.org375a9022013-01-07 01:12:05 +00003981 parser.add_option('-f', '--force', action='store_true',
sbc@chromium.org495ad152012-09-04 23:07:42 +00003982 help='Run checks even if tree is dirty')
Aaron Gable8076c282017-11-29 14:39:41 -08003983 parser.add_option('--all', action='store_true',
3984 help='Run checks against all files, not just modified ones')
Edward Lesmes8e282792018-04-03 18:50:29 -04003985 parser.add_option('--parallel', action='store_true',
3986 help='Run all tests specified by input_api.RunTests in all '
3987 'PRESUBMIT files in parallel.')
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00003988 parser.add_option('--resultdb', action='store_true',
3989 help='Run presubmit checks in the ResultSink environment '
3990 'and send results to the ResultDB database.')
Saagar Sanghavi03b15132020-08-10 16:43:41 +00003991 parser.add_option('--realm', help='LUCI realm if reporting to ResultDB')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00003992 options, args = parser.parse_args(args)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003993
sbc@chromium.org71437c02015-04-09 19:29:40 +00003994 if not options.force and git_common.is_dirty_git_tree('presubmit'):
vapiera7fbd5a2016-06-16 09:17:49 -07003995 print('use --force to check even if tree is dirty.')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003996 return 1
3997
Edward Lemur934836a2019-09-09 20:16:54 +00003998 cl = Changelist()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003999 if args:
4000 base_branch = args[0]
4001 else:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00004002 # Default to diffing against the common ancestor of the upstream branch.
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00004003 base_branch = cl.GetCommonAncestorWithUpstream()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004004
Gregory Nisbet29d5cf82020-02-27 08:16:58 +00004005 if cl.GetIssue():
4006 description = cl.FetchDescription()
Aaron Gable8076c282017-11-29 14:39:41 -08004007 else:
Edward Lemura12175c2020-03-09 16:58:26 +00004008 description = _create_description_from_log([base_branch])
Aaron Gable8076c282017-11-29 14:39:41 -08004009
ilevy@chromium.org051ad0e2013-03-04 21:57:34 +00004010 cl.RunHook(
4011 committing=not options.upload,
4012 may_prompt=False,
4013 verbose=options.verbose,
Edward Lemur227d5102020-02-25 23:45:35 +00004014 parallel=options.parallel,
4015 upstream=base_branch,
4016 description=description,
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00004017 all_files=options.all,
Saagar Sanghavi03b15132020-08-10 16:43:41 +00004018 resultdb=options.resultdb,
4019 realm=options.realm)
dpranke@chromium.org0a2bb372011-03-25 01:16:22 +00004020 return 0
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004021
4022
tandrii@chromium.org65874e12016-03-04 12:03:02 +00004023def GenerateGerritChangeId(message):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004024 """Returns the Change ID footer value (Ixxxxxx...xxx).
tandrii@chromium.org65874e12016-03-04 12:03:02 +00004025
4026 Works the same way as
4027 https://gerrit-review.googlesource.com/tools/hooks/commit-msg
4028 but can be called on demand on all platforms.
4029
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004030 The basic idea is to generate git hash of a state of the tree, original
4031 commit message, author/committer info and timestamps.
tandrii@chromium.org65874e12016-03-04 12:03:02 +00004032 """
4033 lines = []
4034 tree_hash = RunGitSilent(['write-tree'])
4035 lines.append('tree %s' % tree_hash.strip())
4036 code, parent = RunGitWithCode(['rev-parse', 'HEAD~0'], suppress_stderr=False)
4037 if code == 0:
4038 lines.append('parent %s' % parent.strip())
4039 author = RunGitSilent(['var', 'GIT_AUTHOR_IDENT'])
4040 lines.append('author %s' % author.strip())
4041 committer = RunGitSilent(['var', 'GIT_COMMITTER_IDENT'])
4042 lines.append('committer %s' % committer.strip())
4043 lines.append('')
4044 # Note: Gerrit's commit-hook actually cleans message of some lines and
4045 # whitespace. This code is not doing this, but it clearly won't decrease
4046 # entropy.
4047 lines.append(message)
4048 change_hash = RunCommand(['git', 'hash-object', '-t', 'commit', '--stdin'],
Raul Tambreb946b232019-03-26 14:48:46 +00004049 stdin=('\n'.join(lines)).encode())
tandrii@chromium.org65874e12016-03-04 12:03:02 +00004050 return 'I%s' % change_hash.strip()
4051
4052
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01004053def GetTargetRef(remote, remote_branch, target_branch):
wittman@chromium.org455dc922015-01-26 20:15:50 +00004054 """Computes the remote branch ref to use for the CL.
4055
4056 Args:
4057 remote (str): The git remote for the CL.
4058 remote_branch (str): The git remote branch for the CL.
4059 target_branch (str): The target branch specified by the user.
wittman@chromium.org455dc922015-01-26 20:15:50 +00004060 """
4061 if not (remote and remote_branch):
4062 return None
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00004063
wittman@chromium.org455dc922015-01-26 20:15:50 +00004064 if target_branch:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07004065 # Canonicalize branch references to the equivalent local full symbolic
wittman@chromium.org455dc922015-01-26 20:15:50 +00004066 # refs, which are then translated into the remote full symbolic refs
4067 # below.
4068 if '/' not in target_branch:
4069 remote_branch = 'refs/remotes/%s/%s' % (remote, target_branch)
4070 else:
4071 prefix_replacements = (
4072 ('^((refs/)?remotes/)?branch-heads/', 'refs/remotes/branch-heads/'),
4073 ('^((refs/)?remotes/)?%s/' % remote, 'refs/remotes/%s/' % remote),
4074 ('^(refs/)?heads/', 'refs/remotes/%s/' % remote),
4075 )
4076 match = None
4077 for regex, replacement in prefix_replacements:
4078 match = re.search(regex, target_branch)
4079 if match:
4080 remote_branch = target_branch.replace(match.group(0), replacement)
4081 break
4082 if not match:
4083 # This is a branch path but not one we recognize; use as-is.
4084 remote_branch = target_branch
rmistry@google.comc68112d2015-03-03 12:48:06 +00004085 elif remote_branch in REFS_THAT_ALIAS_TO_OTHER_REFS:
4086 # Handle the refs that need to land in different refs.
4087 remote_branch = REFS_THAT_ALIAS_TO_OTHER_REFS[remote_branch]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00004088
Josip Sokcevicc39ab992020-09-24 20:09:15 +00004089 # Migration to new default branch, only if available on remote.
4090 allow_push_on_master = bool(os.environ.get("ALLOW_PUSH_TO_MASTER", None))
4091 if remote_branch == DEFAULT_OLD_BRANCH and not allow_push_on_master:
4092 if RunGit(['show-branch', DEFAULT_NEW_BRANCH], error_ok=True,
4093 stderr=subprocess2.PIPE):
4094 # TODO(crbug.com/ID): Print location to local git migration script.
4095 print("WARNING: Using new branch name %s instead of %s" % (
4096 DEFAULT_NEW_BRANCH, DEFAULT_OLD_BRANCH))
4097 remote_branch = DEFAULT_NEW_BRANCH
4098
wittman@chromium.org455dc922015-01-26 20:15:50 +00004099 # Create the true path to the remote branch.
4100 # Does the following translation:
4101 # * refs/remotes/origin/refs/diff/test -> refs/diff/test
Josip Sokcevicc39ab992020-09-24 20:09:15 +00004102 # * refs/remotes/origin/main -> refs/heads/main
wittman@chromium.org455dc922015-01-26 20:15:50 +00004103 # * refs/remotes/branch-heads/test -> refs/branch-heads/test
4104 if remote_branch.startswith('refs/remotes/%s/refs/' % remote):
4105 remote_branch = remote_branch.replace('refs/remotes/%s/' % remote, '')
4106 elif remote_branch.startswith('refs/remotes/%s/' % remote):
4107 remote_branch = remote_branch.replace('refs/remotes/%s/' % remote,
4108 'refs/heads/')
4109 elif remote_branch.startswith('refs/remotes/branch-heads'):
4110 remote_branch = remote_branch.replace('refs/remotes/', 'refs/')
Andrii Shyshkalov768f1d82016-12-08 15:10:13 +01004111
wittman@chromium.org455dc922015-01-26 20:15:50 +00004112 return remote_branch
4113
4114
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00004115def cleanup_list(l):
4116 """Fixes a list so that comma separated items are put as individual items.
4117
4118 So that "--reviewers joe@c,john@c --reviewers joa@c" results in
4119 options.reviewers == sorted(['joe@c', 'john@c', 'joa@c']).
4120 """
4121 items = sum((i.split(',') for i in l), [])
4122 stripped_items = (i.strip() for i in items)
4123 return sorted(filter(None, stripped_items))
4124
4125
Aaron Gable4db38df2017-11-03 14:59:07 -07004126@subcommand.usage('[flags]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004127@metrics.collector.collect_metrics('git cl upload')
ukai@chromium.orge8077812012-02-03 03:41:46 +00004128def CMDupload(parser, args):
rmistry@google.com78948ed2015-07-08 23:09:57 +00004129 """Uploads the current changelist to codereview.
4130
4131 Can skip dependency patchset uploads for a branch by running:
4132 git config branch.branch_name.skip-deps-uploads True
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004133 To unset, run:
rmistry@google.com78948ed2015-07-08 23:09:57 +00004134 git config --unset branch.branch_name.skip-deps-uploads
4135 Can also set the above globally by using the --global flag.
Dominic Battre7d1c4842017-10-27 09:17:28 +02004136
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004137 If the name of the checked out branch starts with "bug-" or "fix-" followed
4138 by a bug number, this bug number is automatically populated in the CL
Dominic Battre7d1c4842017-10-27 09:17:28 +02004139 description.
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004140
4141 If subject contains text in square brackets or has "<text>: " prefix, such
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004142 text(s) is treated as Gerrit hashtags. For example, CLs with subjects:
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004143 [git-cl] add support for hashtags
4144 Foo bar: implement foo
4145 will be hashtagged with "git-cl" and "foo-bar" respectively.
rmistry@google.com78948ed2015-07-08 23:09:57 +00004146 """
ukai@chromium.orge8077812012-02-03 03:41:46 +00004147 parser.add_option('--bypass-hooks', action='store_true', dest='bypass_hooks',
4148 help='bypass upload presubmit hook')
brettw@chromium.orgb65c43c2013-06-10 22:04:49 +00004149 parser.add_option('--bypass-watchlists', action='store_true',
4150 dest='bypass_watchlists',
4151 help='bypass watchlists auto CC-ing reviewers')
Aaron Gablef7543cd2017-07-20 14:26:31 -07004152 parser.add_option('-f', '--force', action='store_true', dest='force',
ukai@chromium.orge8077812012-02-03 03:41:46 +00004153 help="force yes to questions (don't prompt)")
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004154 parser.add_option('--message', '-m', dest='message',
4155 help='message for patchset')
tandriif9aefb72016-07-01 09:06:51 -07004156 parser.add_option('-b', '--bug',
4157 help='pre-populate the bug number(s) for this issue. '
4158 'If several, separate with commas')
tandriib80458a2016-06-23 12:20:07 -07004159 parser.add_option('--message-file', dest='message_file',
4160 help='file which contains message for patchset')
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004161 parser.add_option('--title', '-t', dest='title',
4162 help='title for patchset')
Mario Bianuccicebfb4e2020-07-22 23:08:16 +00004163 parser.add_option('-T', '--skip-title', action='store_true',
4164 dest='skip_title',
4165 help='Use the most recent commit message as the title of '
4166 'the patchset')
ukai@chromium.orge8077812012-02-03 03:41:46 +00004167 parser.add_option('-r', '--reviewers',
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00004168 action='append', default=[],
ukai@chromium.orge8077812012-02-03 03:41:46 +00004169 help='reviewer email addresses')
Robert Iannucci6c98dc62017-04-18 11:38:00 -07004170 parser.add_option('--tbrs',
4171 action='append', default=[],
4172 help='TBR email addresses')
ukai@chromium.orge8077812012-02-03 03:41:46 +00004173 parser.add_option('--cc',
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00004174 action='append', default=[],
ukai@chromium.orge8077812012-02-03 03:41:46 +00004175 help='cc email addresses')
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004176 parser.add_option('--hashtag', dest='hashtags',
4177 action='append', default=[],
4178 help=('Gerrit hashtag for new CL; '
4179 'can be applied multiple times'))
adamk@chromium.org36f47302013-04-05 01:08:31 +00004180 parser.add_option('-s', '--send-mail', action='store_true',
Aaron Gable59f48512017-01-12 10:54:46 -08004181 help='send email to reviewer(s) and cc(s) immediately')
ukai@chromium.org8ef7ab22012-11-28 04:24:52 +00004182 parser.add_option('--target_branch',
pgervais@chromium.orgb9f27512014-08-08 15:52:33 +00004183 '--target-branch',
wittman@chromium.org455dc922015-01-26 20:15:50 +00004184 metavar='TARGET',
4185 help='Apply CL to remote ref TARGET. ' +
Josip Sokcevicc39ab992020-09-24 20:09:15 +00004186 'Default: remote branch head, or main')
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00004187 parser.add_option('--squash', action='store_true',
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004188 help='Squash multiple commits into one')
Mike Frysingera989d552019-08-14 20:51:23 +00004189 parser.add_option('--no-squash', action='store_false', dest='squash',
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004190 help='Don\'t squash multiple commits into one')
rmistry9eadede2016-09-19 11:22:43 -07004191 parser.add_option('--topic', default=None,
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004192 help='Topic to specify when uploading')
Robert Iannuccif2708bd2017-04-17 15:49:02 -07004193 parser.add_option('--tbr-owners', dest='add_owners_to', action='store_const',
4194 const='TBR', help='add a set of OWNERS to TBR')
4195 parser.add_option('--r-owners', dest='add_owners_to', action='store_const',
4196 const='R', help='add a set of OWNERS to R')
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +00004197 parser.add_option('-c', '--use-commit-queue', action='store_true',
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004198 default=False,
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +00004199 help='tell the CQ to commit this patchset; '
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004200 'implies --send-mail')
4201 parser.add_option('-d', '--cq-dry-run',
4202 action='store_true', default=False,
rmistry@google.comef966222015-04-07 11:15:01 +00004203 help='Send the patchset to do a CQ dry run right after '
4204 'upload.')
Edward Lesmes10c3dd62021-02-08 21:13:57 +00004205 parser.add_option('--set-bot-commit', action='store_true',
4206 help=optparse.SUPPRESS_HELP)
Andrii Shyshkalov71f0da32019-07-15 22:45:18 +00004207 parser.add_option('--preserve-tryjobs', action='store_true',
4208 help='instruct the CQ to let tryjobs running even after '
4209 'new patchsets are uploaded instead of canceling '
4210 'prior patchset\' tryjobs')
rmistry@google.com2dd99862015-06-22 12:22:18 +00004211 parser.add_option('--dependencies', action='store_true',
4212 help='Uploads CLs of all the local branches that depend on '
4213 'the current branch')
Ravi Mistry31e7d562018-04-02 12:53:57 -04004214 parser.add_option('-a', '--enable-auto-submit', action='store_true',
4215 help='Sends your change to the CQ after an approval. Only '
4216 'works on repos that have the Auto-Submit label '
4217 'enabled')
Edward Lesmes8e282792018-04-03 18:50:29 -04004218 parser.add_option('--parallel', action='store_true',
4219 help='Run all tests specified by input_api.RunTests in all '
4220 'PRESUBMIT files in parallel.')
Sergiy Byelozyorov1aa405f2018-09-18 17:38:43 +00004221 parser.add_option('--no-autocc', action='store_true',
4222 help='Disables automatic addition of CC emails')
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004223 parser.add_option('--private', action='store_true',
Sergiy Byelozyorov1aa405f2018-09-18 17:38:43 +00004224 help='Set the review private. This implies --no-autocc.')
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004225 parser.add_option('-R', '--retry-failed', action='store_true',
4226 help='Retry failed tryjobs from old patchset immediately '
4227 'after uploading new patchset. Cannot be used with '
4228 '--use-commit-queue or --cq-dry-run.')
4229 parser.add_option('--buildbucket-host', default='cr-buildbucket.appspot.com',
4230 help='Host of buildbucket. The default host is %default.')
Dan Beamd8b04ca2019-10-10 21:23:26 +00004231 parser.add_option('--fixed', '-x',
4232 help='List of bugs that will be commented on and marked '
4233 'fixed (pre-populates "Fixed:" tag). Same format as '
4234 '-b option / "Bug:" tag. If fixing several issues, '
4235 'separate with commas.')
Josipe827b0f2020-01-30 00:07:20 +00004236 parser.add_option('--edit-description', action='store_true', default=False,
4237 help='Modify description before upload. Cannot be used '
4238 'with --force. It is a noop when --no-squash is set '
4239 'or a new commit is created.')
Ng Zhi Ancdaf0be2020-05-27 20:57:28 +00004240 parser.add_option('--git-completion-helper', action="store_true",
4241 help=optparse.SUPPRESS_HELP)
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00004242 parser.add_option('--resultdb', action='store_true',
4243 help='Run presubmit checks in the ResultSink environment '
4244 'and send results to the ResultDB database.')
Saagar Sanghavi03b15132020-08-10 16:43:41 +00004245 parser.add_option('--realm', help='LUCI realm if reporting to ResultDB')
Josip Sokcevicf2cfd3d2021-03-30 18:39:18 +00004246 parser.add_option('-o',
4247 '--push-options',
4248 action='append',
4249 default=[],
4250 help='Transmit the given string to the server when '
4251 'performing git push (pass-through). See git-push '
4252 'documentation for more details.')
Gregory Nisbet48d9e1e2021-04-15 23:35:54 +00004253 parser.add_option('--no-add-changeid',
4254 action='store_true',
4255 dest='no_add_changeid',
4256 help='Do not add change-ids to messages.')
Sergiy Byelozyorov1aa405f2018-09-18 17:38:43 +00004257
rmistry@google.com2dd99862015-06-22 12:22:18 +00004258 orig_args = args
ukai@chromium.orge8077812012-02-03 03:41:46 +00004259 (options, args) = parser.parse_args(args)
4260
Ng Zhi Ancdaf0be2020-05-27 20:57:28 +00004261 if options.git_completion_helper:
Edward Lesmesb7db1832020-06-22 20:22:27 +00004262 print(' '.join(opt.get_opt_string() for opt in parser.option_list
4263 if opt.help != optparse.SUPPRESS_HELP))
4264 return
Ng Zhi Ancdaf0be2020-05-27 20:57:28 +00004265
sbc@chromium.org71437c02015-04-09 19:29:40 +00004266 if git_common.is_dirty_git_tree('upload'):
ukai@chromium.orge8077812012-02-03 03:41:46 +00004267 return 1
4268
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00004269 options.reviewers = cleanup_list(options.reviewers)
Robert Iannucci6c98dc62017-04-18 11:38:00 -07004270 options.tbrs = cleanup_list(options.tbrs)
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00004271 options.cc = cleanup_list(options.cc)
4272
Josipe827b0f2020-01-30 00:07:20 +00004273 if options.edit_description and options.force:
4274 parser.error('Only one of --force and --edit-description allowed')
4275
tandriib80458a2016-06-23 12:20:07 -07004276 if options.message_file:
4277 if options.message:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004278 parser.error('Only one of --message and --message-file allowed.')
tandriib80458a2016-06-23 12:20:07 -07004279 options.message = gclient_utils.FileRead(options.message_file)
tandriib80458a2016-06-23 12:20:07 -07004280
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004281 if ([options.cq_dry_run,
4282 options.use_commit_queue,
4283 options.retry_failed].count(True) > 1):
4284 parser.error('Only one of --use-commit-queue, --cq-dry-run, or '
4285 '--retry-failed is allowed.')
tandrii4d0545a2016-07-06 03:56:49 -07004286
Mario Bianuccicebfb4e2020-07-22 23:08:16 +00004287 if options.skip_title and options.title:
4288 parser.error('Only one of --title and --skip-title allowed.')
4289
Aaron Gableedbc4132017-09-11 13:22:28 -07004290 if options.use_commit_queue:
4291 options.send_mail = True
4292
Edward Lesmes0dd54822020-03-26 18:24:25 +00004293 if options.squash is None:
4294 # Load default for user, repo, squash=true, in this order.
4295 options.squash = settings.GetSquashGerritUploads()
4296
Josip Sokcevic1cabb172021-04-08 19:15:35 +00004297 cl = Changelist(branchref=options.target_branch)
Edward Lesmes7677e5c2020-02-19 20:39:03 +00004298 # Warm change details cache now to avoid RPCs later, reducing latency for
4299 # developers.
4300 if cl.GetIssue():
4301 cl._GetChangeDetail(
4302 ['DETAILED_ACCOUNTS', 'CURRENT_REVISION', 'CURRENT_COMMIT', 'LABELS'])
4303
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004304 if options.retry_failed and not cl.GetIssue():
4305 print('No previous patchsets, so --retry-failed has no effect.')
4306 options.retry_failed = False
Edward Lesmes7677e5c2020-02-19 20:39:03 +00004307
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004308 # cl.GetMostRecentPatchset uses cached information, and can return the last
4309 # patchset before upload. Calling it here makes it clear that it's the
4310 # last patchset before upload. Note that GetMostRecentPatchset will fail
4311 # if no CL has been uploaded yet.
4312 if options.retry_failed:
4313 patchset = cl.GetMostRecentPatchset()
Andrii Shyshkalov9f274432018-10-15 16:40:23 +00004314
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004315 ret = cl.CMDUpload(options, args, orig_args)
4316
4317 if options.retry_failed:
4318 if ret != 0:
4319 print('Upload failed, so --retry-failed has no effect.')
4320 return ret
Andrii Shyshkalov1ad58112019-10-08 01:46:14 +00004321 builds, _ = _fetch_latest_builds(
Edward Lemur5b929a42019-10-21 17:57:39 +00004322 cl, options.buildbucket_host, latest_patchset=patchset)
Edward Lemur45768512020-03-02 19:03:14 +00004323 jobs = _filter_failed_for_retry(builds)
4324 if len(jobs) == 0:
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004325 print('No failed tryjobs, so --retry-failed has no effect.')
4326 return ret
Quinten Yearsley777660f2020-03-04 23:37:06 +00004327 _trigger_tryjobs(cl, jobs, options, patchset + 1)
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004328
4329 return ret
ukai@chromium.orge8077812012-02-03 03:41:46 +00004330
4331
Francois Dorayd42c6812017-05-30 15:10:20 -04004332@subcommand.usage('--description=<description file>')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004333@metrics.collector.collect_metrics('git cl split')
Francois Dorayd42c6812017-05-30 15:10:20 -04004334def CMDsplit(parser, args):
4335 """Splits a branch into smaller branches and uploads CLs.
4336
4337 Creates a branch and uploads a CL for each group of files modified in the
4338 current branch that share a common OWNERS file. In the CL description and
Edward Lemurac5c55f2020-02-29 00:17:16 +00004339 comment, the string '$directory', is replaced with the directory containing
4340 the shared OWNERS file.
Francois Dorayd42c6812017-05-30 15:10:20 -04004341 """
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004342 parser.add_option('-d', '--description', dest='description_file',
4343 help='A text file containing a CL description in which '
4344 '$directory will be replaced by each CL\'s directory.')
4345 parser.add_option('-c', '--comment', dest='comment_file',
4346 help='A text file containing a CL comment.')
4347 parser.add_option('-n', '--dry-run', dest='dry_run', action='store_true',
Chris Watkinsba28e462017-12-13 11:22:17 +11004348 default=False,
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004349 help='List the files and reviewers for each CL that would '
4350 'be created, but don\'t create branches or CLs.')
4351 parser.add_option('--cq-dry-run', action='store_true',
4352 help='If set, will do a cq dry run for each uploaded CL. '
4353 'Please be careful when doing this; more than ~10 CLs '
4354 'has the potential to overload our build '
4355 'infrastructure. Try to upload these not during high '
4356 'load times (usually 11-3 Mountain View time). Email '
4357 'infra-dev@chromium.org with any questions.')
Takuto Ikuta51eca592019-02-14 19:40:52 +00004358 parser.add_option('-a', '--enable-auto-submit', action='store_true',
4359 default=True,
4360 help='Sends your change to the CQ after an approval. Only '
4361 'works on repos that have the Auto-Submit label '
4362 'enabled')
Francois Dorayd42c6812017-05-30 15:10:20 -04004363 options, _ = parser.parse_args(args)
4364
4365 if not options.description_file:
4366 parser.error('No --description flag specified.')
4367
4368 def WrappedCMDupload(args):
4369 return CMDupload(OptionParser(), args)
4370
Edward Lemur2c62b332020-03-12 22:12:33 +00004371 return split_cl.SplitCl(
4372 options.description_file, options.comment_file, Changelist,
4373 WrappedCMDupload, options.dry_run, options.cq_dry_run,
4374 options.enable_auto_submit, settings.GetRoot())
Francois Dorayd42c6812017-05-30 15:10:20 -04004375
4376
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004377@subcommand.usage('DEPRECATED')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004378@metrics.collector.collect_metrics('git cl commit')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004379def CMDdcommit(parser, args):
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004380 """DEPRECATED: Used to commit the current changelist via git-svn."""
4381 message = ('git-cl no longer supports committing to SVN repositories via '
4382 'git-svn. You probably want to use `git cl land` instead.')
4383 print(message)
4384 return 1
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004385
4386
maruel@chromium.org0633fb42013-08-16 20:06:14 +00004387@subcommand.usage('[upstream branch to apply against]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004388@metrics.collector.collect_metrics('git cl land')
pgervais@chromium.orgcee6dc42014-05-07 17:04:03 +00004389def CMDland(parser, args):
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004390 """Commits the current changelist via git.
4391
4392 In case of Gerrit, uses Gerrit REST api to "submit" the issue, which pushes
4393 upstream and closes the issue automatically and atomically.
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004394 """
4395 parser.add_option('--bypass-hooks', action='store_true', dest='bypass_hooks',
4396 help='bypass upload presubmit hook')
Aaron Gablef7543cd2017-07-20 14:26:31 -07004397 parser.add_option('-f', '--force', action='store_true', dest='force',
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004398 help="force yes to questions (don't prompt)")
Edward Lesmes67b3faa2018-04-13 17:50:52 -04004399 parser.add_option('--parallel', action='store_true',
4400 help='Run all tests specified by input_api.RunTests in all '
4401 'PRESUBMIT files in parallel.')
Saagar Sanghavi03b15132020-08-10 16:43:41 +00004402 parser.add_option('--resultdb', action='store_true',
4403 help='Run presubmit checks in the ResultSink environment '
4404 'and send results to the ResultDB database.')
4405 parser.add_option('--realm', help='LUCI realm if reporting to ResultDB')
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004406 (options, args) = parser.parse_args(args)
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004407
Edward Lemur934836a2019-09-09 20:16:54 +00004408 cl = Changelist()
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004409
Robert Iannucci2e73d432018-03-14 01:10:47 -07004410 if not cl.GetIssue():
4411 DieWithError('You must upload the change first to Gerrit.\n'
4412 ' If you would rather have `git cl land` upload '
4413 'automatically for you, see http://crbug.com/642759')
Saagar Sanghavi03b15132020-08-10 16:43:41 +00004414 return cl.CMDLand(options.force, options.bypass_hooks, options.verbose,
4415 options.parallel, options.resultdb, options.realm)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004416
4417
dsinclair@chromium.orgfbed6562015-09-25 21:22:36 +00004418@subcommand.usage('<patch url or issue id or issue url>')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004419@metrics.collector.collect_metrics('git cl patch')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004420def CMDpatch(parser, args):
marq@chromium.orge5e59002013-10-02 23:21:25 +00004421 """Patches in a code review."""
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004422 parser.add_option('-b', dest='newbranch',
4423 help='create a new branch off trunk for the patch')
qsr@chromium.org1ef44af2013-10-16 16:24:32 +00004424 parser.add_option('-f', '--force', action='store_true',
Aaron Gable62619a32017-06-16 08:22:09 -07004425 help='overwrite state on the current or chosen branch')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004426 parser.add_option('-n', '--no-commit', action='store_true', dest='nocommit',
Edward Lemurf38bc172019-09-03 21:02:13 +00004427 help='don\'t commit after patch applies.')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004428
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00004429 group = optparse.OptionGroup(
4430 parser,
4431 'Options for continuing work on the current issue uploaded from a '
4432 'different clone (e.g. different machine). Must be used independently '
4433 'from the other options. No issue number should be specified, and the '
4434 'branch must have an issue number associated with it')
4435 group.add_option('--reapply', action='store_true', dest='reapply',
4436 help='Reset the branch and reapply the issue.\n'
4437 'CAUTION: This will undo any local changes in this '
4438 'branch')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004439
4440 group.add_option('--pull', action='store_true', dest='pull',
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00004441 help='Performs a pull before reapplying.')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004442 parser.add_option_group(group)
4443
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004444 (options, args) = parser.parse_args(args)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004445
Andrii Shyshkalov18975322017-01-25 16:44:13 +01004446 if options.reapply:
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004447 if options.newbranch:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004448 parser.error('--reapply works on the current branch only.')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004449 if len(args) > 0:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004450 parser.error('--reapply implies no additional arguments.')
dsinclair@chromium.orgfbed6562015-09-25 21:22:36 +00004451
Edward Lemur934836a2019-09-09 20:16:54 +00004452 cl = Changelist()
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004453 if not cl.GetIssue():
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004454 parser.error('Current branch must have an associated issue.')
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004455
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004456 upstream = cl.GetUpstreamBranch()
Andrii Shyshkalov18975322017-01-25 16:44:13 +01004457 if upstream is None:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004458 parser.error('No upstream branch specified. Cannot reset branch.')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004459
4460 RunGit(['reset', '--hard', upstream])
4461 if options.pull:
4462 RunGit(['pull'])
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004463
Edward Lemur678a6842019-10-03 22:25:05 +00004464 target_issue_arg = ParseIssueNumberArgument(cl.GetIssue())
Bruce Dawsonf362f6f2021-02-18 23:15:17 +00004465 return cl.CMDPatchWithParsedIssue(target_issue_arg, options.nocommit, False,
4466 False)
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004467
4468 if len(args) != 1 or not args[0]:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004469 parser.error('Must specify issue number or URL.')
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004470
Edward Lemurf38bc172019-09-03 21:02:13 +00004471 target_issue_arg = ParseIssueNumberArgument(args[0])
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004472 if not target_issue_arg.valid:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004473 parser.error('Invalid issue ID or URL.')
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004474
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004475 # We don't want uncommitted changes mixed up with the patch.
4476 if git_common.is_dirty_git_tree('patch'):
dsinclair@chromium.orgfbed6562015-09-25 21:22:36 +00004477 return 1
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004478
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004479 if options.newbranch:
4480 if options.force:
4481 RunGit(['branch', '-D', options.newbranch],
4482 stderr=subprocess2.PIPE, error_ok=True)
Edward Lemur84101642020-02-21 21:40:34 +00004483 git_new_branch.create_new_branch(options.newbranch)
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004484
Edward Lemur678a6842019-10-03 22:25:05 +00004485 cl = Changelist(
4486 codereview_host=target_issue_arg.hostname, issue=target_issue_arg.issue)
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004487
Edward Lemur678a6842019-10-03 22:25:05 +00004488 if not args[0].isdigit():
Edward Lemurf38bc172019-09-03 21:02:13 +00004489 print('canonical issue/change URL: %s\n' % cl.GetIssueURL())
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004490
Bruce Dawsonf362f6f2021-02-18 23:15:17 +00004491 return cl.CMDPatchWithParsedIssue(target_issue_arg, options.nocommit,
4492 options.force, options.newbranch)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004493
4494
jochen@chromium.org3ec0d542014-01-14 20:00:03 +00004495def GetTreeStatus(url=None):
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004496 """Fetches the tree status and returns either 'open', 'closed',
4497 'unknown' or 'unset'."""
jochen@chromium.org3ec0d542014-01-14 20:00:03 +00004498 url = url or settings.GetTreeStatusUrl(error_ok=True)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004499 if url:
Daniel McArdle8b4eeff2020-07-20 17:02:47 +00004500 status = str(urllib.request.urlopen(url).read().lower())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004501 if status.find('closed') != -1 or status == '0':
4502 return 'closed'
4503 elif status.find('open') != -1 or status == '1':
4504 return 'open'
4505 return 'unknown'
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004506 return 'unset'
4507
dpranke@chromium.org970c5222011-03-12 00:32:24 +00004508
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004509def GetTreeStatusReason():
4510 """Fetches the tree status from a json url and returns the message
4511 with the reason for the tree to be opened or closed."""
msb@chromium.orgbf1a7ba2011-02-01 16:21:46 +00004512 url = settings.GetTreeStatusUrl()
Daniel McArdle8b4eeff2020-07-20 17:02:47 +00004513 json_url = urllib.parse.urljoin(url, '/current?format=json')
Edward Lemur79d4f992019-11-11 23:49:02 +00004514 connection = urllib.request.urlopen(json_url)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004515 status = json.loads(connection.read())
4516 connection.close()
4517 return status['message']
4518
dpranke@chromium.org970c5222011-03-12 00:32:24 +00004519
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004520@metrics.collector.collect_metrics('git cl tree')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004521def CMDtree(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004522 """Shows the status of the tree."""
dpranke@chromium.org97ae58e2011-03-18 00:29:20 +00004523 _, args = parser.parse_args(args)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004524 status = GetTreeStatus()
4525 if 'unset' == status:
vapiera7fbd5a2016-06-16 09:17:49 -07004526 print('You must configure your tree status URL by running "git cl config".')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004527 return 2
4528
vapiera7fbd5a2016-06-16 09:17:49 -07004529 print('The tree is %s' % status)
4530 print()
4531 print(GetTreeStatusReason())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004532 if status != 'open':
4533 return 1
4534 return 0
4535
4536
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004537@metrics.collector.collect_metrics('git cl try')
maruel@chromium.org15192402012-09-06 12:38:29 +00004538def CMDtry(parser, args):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004539 """Triggers tryjobs using either Buildbucket or CQ dry run."""
4540 group = optparse.OptionGroup(parser, 'Tryjob options')
maruel@chromium.org15192402012-09-06 12:38:29 +00004541 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004542 '-b', '--bot', action='append',
4543 help=('IMPORTANT: specify ONE builder per --bot flag. Use it multiple '
4544 'times to specify multiple builders. ex: '
4545 '"-b win_rel -b win_layout". See '
4546 'the try server waterfall for the builders name and the tests '
4547 'available.'))
maruel@chromium.org15192402012-09-06 12:38:29 +00004548 group.add_option(
borenet6c0efe62016-10-19 08:13:29 -07004549 '-B', '--bucket', default='',
4550 help=('Buildbucket bucket to send the try requests.'))
4551 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004552 '-r', '--revision',
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004553 help='Revision to use for the tryjob; default: the revision will '
tandriif7b29d42016-10-07 08:45:41 -07004554 'be determined by the try recipe that builder runs, which usually '
Josip Sokcevicc39ab992020-09-24 20:09:15 +00004555 'defaults to HEAD of origin/master or origin/main')
maruel@chromium.org15192402012-09-06 12:38:29 +00004556 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004557 '-c', '--clobber', action='store_true', default=False,
tandriif7b29d42016-10-07 08:45:41 -07004558 help='Force a clobber before building; that is don\'t do an '
tandrii1838bad2016-10-06 00:10:52 -07004559 'incremental build')
maruel@chromium.org15192402012-09-06 12:38:29 +00004560 group.add_option(
Andrii Shyshkalovf9648b52018-02-21 22:32:42 -08004561 '--category', default='git_cl_try', help='Specify custom build category.')
4562 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004563 '--project',
4564 help='Override which project to use. Projects are defined '
tandriif7b29d42016-10-07 08:45:41 -07004565 'in recipe to determine to which repository or directory to '
4566 'apply the patch')
maruel@chromium.org15192402012-09-06 12:38:29 +00004567 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004568 '-p', '--property', dest='properties', action='append', default=[],
4569 help='Specify generic properties in the form -p key1=value1 -p '
tandriif7b29d42016-10-07 08:45:41 -07004570 'key2=value2 etc. The value will be treated as '
4571 'json if decodable, or as string otherwise. '
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004572 'NOTE: using this may make your tryjob not usable for CQ, '
4573 'which will then schedule another tryjob with default properties')
sheyang@chromium.orgdb375572015-08-17 19:22:23 +00004574 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004575 '--buildbucket-host', default='cr-buildbucket.appspot.com',
4576 help='Host of buildbucket. The default host is %default.')
maruel@chromium.org15192402012-09-06 12:38:29 +00004577 parser.add_option_group(group)
Quinten Yearsley983111f2019-09-26 17:18:48 +00004578 parser.add_option(
4579 '-R', '--retry-failed', action='store_true', default=False,
4580 help='Retry failed jobs from the latest set of tryjobs. '
4581 'Not allowed with --bucket and --bot options.')
Edward Lemur52969c92020-02-06 18:15:28 +00004582 parser.add_option(
4583 '-i', '--issue', type=int,
4584 help='Operate on this issue instead of the current branch\'s implicit '
4585 'issue.')
maruel@chromium.org15192402012-09-06 12:38:29 +00004586 options, args = parser.parse_args(args)
4587
machenbach@chromium.org45453142015-09-15 08:45:22 +00004588 # Make sure that all properties are prop=value pairs.
4589 bad_params = [x for x in options.properties if '=' not in x]
4590 if bad_params:
4591 parser.error('Got properties with missing "=": %s' % bad_params)
4592
maruel@chromium.org15192402012-09-06 12:38:29 +00004593 if args:
4594 parser.error('Unknown arguments: %s' % args)
4595
Edward Lemur934836a2019-09-09 20:16:54 +00004596 cl = Changelist(issue=options.issue)
maruel@chromium.org15192402012-09-06 12:38:29 +00004597 if not cl.GetIssue():
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004598 parser.error('Need to upload first.')
maruel@chromium.org15192402012-09-06 12:38:29 +00004599
Edward Lemurf38bc172019-09-03 21:02:13 +00004600 # HACK: warm up Gerrit change detail cache to save on RPCs.
Edward Lemur125d60a2019-09-13 18:25:41 +00004601 cl._GetChangeDetail(['DETAILED_ACCOUNTS', 'ALL_REVISIONS'])
Andrii Shyshkaloveadad922017-01-26 09:38:30 +01004602
tandriie113dfd2016-10-11 10:20:12 -07004603 error_message = cl.CannotTriggerTryJobReason()
4604 if error_message:
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004605 parser.error('Can\'t trigger tryjobs: %s' % error_message)
jrobbins@chromium.org16f10f72014-06-24 22:14:36 +00004606
Edward Lemur45768512020-03-02 19:03:14 +00004607 if options.bot:
4608 if options.retry_failed:
4609 parser.error('--bot is not compatible with --retry-failed.')
4610 if not options.bucket:
4611 parser.error('A bucket (e.g. "chromium/try") is required.')
4612
4613 triggered = [b for b in options.bot if 'triggered' in b]
4614 if triggered:
4615 parser.error(
4616 'Cannot schedule builds on triggered bots: %s.\n'
4617 'This type of bot requires an initial job from a parent (usually a '
4618 'builder). Schedule a job on the parent instead.\n' % triggered)
4619
4620 if options.bucket.startswith('.master'):
4621 parser.error('Buildbot masters are not supported.')
4622
4623 project, bucket = _parse_bucket(options.bucket)
4624 if project is None or bucket is None:
4625 parser.error('Invalid bucket: %s.' % options.bucket)
4626 jobs = sorted((project, bucket, bot) for bot in options.bot)
4627 elif options.retry_failed:
Quinten Yearsley983111f2019-09-26 17:18:48 +00004628 print('Searching for failed tryjobs...')
Edward Lemur5b929a42019-10-21 17:57:39 +00004629 builds, patchset = _fetch_latest_builds(cl, options.buildbucket_host)
Quinten Yearsley983111f2019-09-26 17:18:48 +00004630 if options.verbose:
4631 print('Got %d builds in patchset #%d' % (len(builds), patchset))
Edward Lemur45768512020-03-02 19:03:14 +00004632 jobs = _filter_failed_for_retry(builds)
4633 if not jobs:
Quinten Yearsley983111f2019-09-26 17:18:48 +00004634 print('There are no failed jobs in the latest set of jobs '
4635 '(patchset #%d), doing nothing.' % patchset)
4636 return 0
Edward Lemur45768512020-03-02 19:03:14 +00004637 num_builders = len(jobs)
Quinten Yearsley983111f2019-09-26 17:18:48 +00004638 if num_builders > 10:
4639 confirm_or_exit('There are %d builders with failed builds.'
4640 % num_builders, action='continue')
4641 else:
qyearsley1fdfcb62016-10-24 13:22:03 -07004642 if options.verbose:
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07004643 print('git cl try with no bots now defaults to CQ dry run.')
4644 print('Scheduling CQ dry run on: %s' % cl.GetIssueURL())
4645 return cl.SetCQState(_CQState.DRY_RUN)
stip@chromium.org43064fd2013-12-18 20:07:44 +00004646
ilevy@chromium.org36e420b2013-08-06 23:21:12 +00004647 patchset = cl.GetMostRecentPatchset()
Edward Lemur2c210a42019-09-16 23:58:35 +00004648 try:
Quinten Yearsley777660f2020-03-04 23:37:06 +00004649 _trigger_tryjobs(cl, jobs, options, patchset)
Edward Lemur2c210a42019-09-16 23:58:35 +00004650 except BuildbucketResponseException as ex:
4651 print('ERROR: %s' % ex)
4652 return 1
4653 return 0
maruel@chromium.org15192402012-09-06 12:38:29 +00004654
4655
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004656@metrics.collector.collect_metrics('git cl try-results')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004657def CMDtry_results(parser, args):
Quinten Yearsleyd242ed72019-07-25 17:17:55 +00004658 """Prints info about results for tryjobs associated with the current CL."""
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004659 group = optparse.OptionGroup(parser, 'Tryjob results options')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004660 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004661 '-p', '--patchset', type=int, help='patchset number if not current.')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004662 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004663 '--print-master', action='store_true', help='print master name as well.')
tandrii@chromium.org6cf98c82016-03-15 11:56:00 +00004664 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004665 '--color', action='store_true', default=setup_color.IS_TTY,
4666 help='force color output, useful when piping output.')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004667 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004668 '--buildbucket-host', default='cr-buildbucket.appspot.com',
4669 help='Host of buildbucket. The default host is %default.')
qyearsley53f48a12016-09-01 10:45:13 -07004670 group.add_option(
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004671 '--json', help=('Path of JSON output file to write tryjob results to,'
Stefan Zager1306bd02017-06-22 19:26:46 -07004672 'or "-" for stdout.'))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004673 parser.add_option_group(group)
Edward Lemur52969c92020-02-06 18:15:28 +00004674 parser.add_option(
4675 '-i', '--issue', type=int,
4676 help='Operate on this issue instead of the current branch\'s implicit '
4677 'issue.')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004678 options, args = parser.parse_args(args)
4679 if args:
4680 parser.error('Unrecognized args: %s' % ' '.join(args))
4681
Edward Lemur934836a2019-09-09 20:16:54 +00004682 cl = Changelist(issue=options.issue)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004683 if not cl.GetIssue():
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004684 parser.error('Need to upload first.')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004685
tandrii221ab252016-10-06 08:12:04 -07004686 patchset = options.patchset
4687 if not patchset:
Gavin Make61ccc52020-11-13 00:12:57 +00004688 patchset = cl.GetMostRecentDryRunPatchset()
tandrii221ab252016-10-06 08:12:04 -07004689 if not patchset:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004690 parser.error('Code review host doesn\'t know about issue %s. '
tandrii221ab252016-10-06 08:12:04 -07004691 'No access to issue or wrong issue number?\n'
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004692 'Either upload first, or pass --patchset explicitly.' %
tandrii221ab252016-10-06 08:12:04 -07004693 cl.GetIssue())
4694
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004695 try:
Quinten Yearsley777660f2020-03-04 23:37:06 +00004696 jobs = _fetch_tryjobs(cl, options.buildbucket_host, patchset)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004697 except BuildbucketResponseException as ex:
vapiera7fbd5a2016-06-16 09:17:49 -07004698 print('Buildbucket error: %s' % ex)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004699 return 1
qyearsley53f48a12016-09-01 10:45:13 -07004700 if options.json:
Edward Lemurbaaf6be2019-10-09 18:00:44 +00004701 write_json(options.json, jobs)
qyearsley53f48a12016-09-01 10:45:13 -07004702 else:
Quinten Yearsley777660f2020-03-04 23:37:06 +00004703 _print_tryjobs(options, jobs)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004704 return 0
4705
4706
maruel@chromium.org0633fb42013-08-16 20:06:14 +00004707@subcommand.usage('[new upstream branch]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004708@metrics.collector.collect_metrics('git cl upstream')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004709def CMDupstream(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004710 """Prints or sets the name of the upstream branch, if any."""
dpranke@chromium.org97ae58e2011-03-18 00:29:20 +00004711 _, args = parser.parse_args(args)
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00004712 if len(args) > 1:
maruel@chromium.org27bb3872011-05-30 20:33:19 +00004713 parser.error('Unrecognized args: %s' % ' '.join(args))
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00004714
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004715 cl = Changelist()
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00004716 if args:
4717 # One arg means set upstream branch.
bauerb@chromium.orgc9cf90a2014-04-28 20:32:31 +00004718 branch = cl.GetBranch()
stip7a3dd352016-09-22 17:32:28 -07004719 RunGit(['branch', '--set-upstream-to', args[0], branch])
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00004720 cl = Changelist()
vapiera7fbd5a2016-06-16 09:17:49 -07004721 print('Upstream branch set to %s' % (cl.GetUpstreamBranch(),))
bauerb@chromium.orgc9cf90a2014-04-28 20:32:31 +00004722
4723 # Clear configured merge-base, if there is one.
4724 git_common.remove_merge_base(branch)
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00004725 else:
vapiera7fbd5a2016-06-16 09:17:49 -07004726 print(cl.GetUpstreamBranch())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004727 return 0
4728
4729
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004730@metrics.collector.collect_metrics('git cl web')
thestig@chromium.org00858c82013-12-02 23:08:03 +00004731def CMDweb(parser, args):
4732 """Opens the current CL in the web browser."""
4733 _, args = parser.parse_args(args)
4734 if args:
4735 parser.error('Unrecognized args: %s' % ' '.join(args))
4736
4737 issue_url = Changelist().GetIssueURL()
4738 if not issue_url:
vapiera7fbd5a2016-06-16 09:17:49 -07004739 print('ERROR No issue to open', file=sys.stderr)
thestig@chromium.org00858c82013-12-02 23:08:03 +00004740 return 1
4741
Sergiy Byelozyorov2b718322018-10-24 17:43:31 +00004742 # Redirect I/O before invoking browser to hide its output. For example, this
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004743 # allows us to hide the "Created new window in existing browser session."
4744 # message from Chrome. Based on https://stackoverflow.com/a/2323563.
Sergiy Byelozyorov2b718322018-10-24 17:43:31 +00004745 saved_stdout = os.dup(1)
Sergiy Belozorov06684032019-03-06 16:53:08 +00004746 saved_stderr = os.dup(2)
Sergiy Byelozyorov2b718322018-10-24 17:43:31 +00004747 os.close(1)
Sergiy Belozorov06684032019-03-06 16:53:08 +00004748 os.close(2)
Sergiy Byelozyorov2b718322018-10-24 17:43:31 +00004749 os.open(os.devnull, os.O_RDWR)
4750 try:
4751 webbrowser.open(issue_url)
4752 finally:
4753 os.dup2(saved_stdout, 1)
Sergiy Belozorov06684032019-03-06 16:53:08 +00004754 os.dup2(saved_stderr, 2)
thestig@chromium.org00858c82013-12-02 23:08:03 +00004755 return 0
4756
4757
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004758@metrics.collector.collect_metrics('git cl set-commit')
maruel@chromium.org27bb3872011-05-30 20:33:19 +00004759def CMDset_commit(parser, args):
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +00004760 """Sets the commit bit to trigger the CQ."""
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00004761 parser.add_option('-d', '--dry-run', action='store_true',
4762 help='trigger in dry run mode')
4763 parser.add_option('-c', '--clear', action='store_true',
4764 help='stop CQ run, if any')
Edward Lemur52969c92020-02-06 18:15:28 +00004765 parser.add_option(
4766 '-i', '--issue', type=int,
4767 help='Operate on this issue instead of the current branch\'s implicit '
4768 'issue.')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004769 options, args = parser.parse_args(args)
maruel@chromium.org27bb3872011-05-30 20:33:19 +00004770 if args:
4771 parser.error('Unrecognized args: %s' % ' '.join(args))
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00004772 if options.dry_run and options.clear:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004773 parser.error('Only one of --dry-run and --clear are allowed.')
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00004774
Edward Lemur934836a2019-09-09 20:16:54 +00004775 cl = Changelist(issue=options.issue)
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00004776 if options.clear:
tandriid9e5ce52016-07-13 02:32:59 -07004777 state = _CQState.NONE
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00004778 elif options.dry_run:
4779 state = _CQState.DRY_RUN
4780 else:
4781 state = _CQState.COMMIT
4782 if not cl.GetIssue():
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004783 parser.error('Must upload the issue first.')
tandrii9de9ec62016-07-13 03:01:59 -07004784 cl.SetCQState(state)
maruel@chromium.org27bb3872011-05-30 20:33:19 +00004785 return 0
4786
4787
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004788@metrics.collector.collect_metrics('git cl set-close')
groby@chromium.org411034a2013-02-26 15:12:01 +00004789def CMDset_close(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004790 """Closes the issue."""
Edward Lemur52969c92020-02-06 18:15:28 +00004791 parser.add_option(
4792 '-i', '--issue', type=int,
4793 help='Operate on this issue instead of the current branch\'s implicit '
4794 'issue.')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004795 options, args = parser.parse_args(args)
groby@chromium.org411034a2013-02-26 15:12:01 +00004796 if args:
4797 parser.error('Unrecognized args: %s' % ' '.join(args))
Edward Lemur934836a2019-09-09 20:16:54 +00004798 cl = Changelist(issue=options.issue)
groby@chromium.org411034a2013-02-26 15:12:01 +00004799 # Ensure there actually is an issue to close.
Aaron Gable7139a4e2017-09-05 17:53:09 -07004800 if not cl.GetIssue():
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004801 DieWithError('ERROR: No issue to close.')
groby@chromium.org411034a2013-02-26 15:12:01 +00004802 cl.CloseIssue()
4803 return 0
4804
4805
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004806@metrics.collector.collect_metrics('git cl diff')
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00004807def CMDdiff(parser, args):
wychen@chromium.org37b2ec02015-04-03 00:49:15 +00004808 """Shows differences between local tree and last upload."""
thomasanderson074beb22016-08-29 14:03:20 -07004809 parser.add_option(
4810 '--stat',
4811 action='store_true',
4812 dest='stat',
4813 help='Generate a diffstat')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004814 options, args = parser.parse_args(args)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004815 if args:
4816 parser.error('Unrecognized args: %s' % ' '.join(args))
wychen@chromium.org46309bf2015-04-03 21:04:49 +00004817
Edward Lemur934836a2019-09-09 20:16:54 +00004818 cl = Changelist()
sbc@chromium.org78dc9842013-11-25 18:43:44 +00004819 issue = cl.GetIssue()
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00004820 branch = cl.GetBranch()
sbc@chromium.org78dc9842013-11-25 18:43:44 +00004821 if not issue:
4822 DieWithError('No issue found for current branch (%s)' % branch)
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00004823
Aaron Gablea718c3e2017-08-28 17:47:28 -07004824 base = cl._GitGetBranchConfigValue('last-upload-hash')
4825 if not base:
4826 base = cl._GitGetBranchConfigValue('gerritsquashhash')
4827 if not base:
4828 detail = cl._GetChangeDetail(['CURRENT_REVISION', 'CURRENT_COMMIT'])
4829 revision_info = detail['revisions'][detail['current_revision']]
4830 fetch_info = revision_info['fetch']['http']
4831 RunGit(['fetch', fetch_info['url'], fetch_info['ref']])
4832 base = 'FETCH_HEAD'
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00004833
Aaron Gablea718c3e2017-08-28 17:47:28 -07004834 cmd = ['git', 'diff']
4835 if options.stat:
4836 cmd.append('--stat')
4837 cmd.append(base)
4838 subprocess2.check_call(cmd)
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00004839
4840 return 0
4841
4842
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004843@metrics.collector.collect_metrics('git cl owners')
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00004844def CMDowners(parser, args):
Dirk Prankebf980882017-09-02 15:08:00 -07004845 """Finds potential owners for reviewing."""
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00004846 parser.add_option(
Sidney San Martín8e6f58c2018-06-08 01:02:56 +00004847 '--ignore-current',
4848 action='store_true',
4849 help='Ignore the CL\'s current reviewers and start from scratch.')
4850 parser.add_option(
Sylvain Defresneb1f865d2019-02-12 12:38:22 +00004851 '--ignore-self',
4852 action='store_true',
4853 help='Do not consider CL\'s author as an owners.')
4854 parser.add_option(
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00004855 '--no-color',
4856 action='store_true',
4857 help='Use this option to disable color output')
Dirk Prankebf980882017-09-02 15:08:00 -07004858 parser.add_option(
4859 '--batch',
4860 action='store_true',
4861 help='Do not run interactively, just suggest some')
Yang Guo6e269a02019-06-26 11:17:02 +00004862 # TODO: Consider moving this to another command, since other
4863 # git-cl owners commands deal with owners for a given CL.
4864 parser.add_option(
4865 '--show-all',
4866 action='store_true',
4867 help='Show all owners for a particular file')
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00004868 options, args = parser.parse_args(args)
4869
Edward Lemur934836a2019-09-09 20:16:54 +00004870 cl = Changelist()
Edward Lesmes50da7702020-03-30 19:23:43 +00004871 author = cl.GetAuthor()
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00004872
Yang Guo6e269a02019-06-26 11:17:02 +00004873 if options.show_all:
Bruce Dawson97ed44a2020-05-06 17:04:03 +00004874 if len(args) == 0:
4875 print('No files specified for --show-all. Nothing to do.')
4876 return 0
Edward Lesmese1576912021-02-16 21:53:34 +00004877 owners_by_path = cl.owners_client.BatchListOwners(args)
Edward Lesmes0e4e5ae2021-01-08 18:28:46 +00004878 for path in args:
4879 print('Owners for %s:' % path)
4880 print('\n'.join(
4881 ' - %s' % owner
4882 for owner in owners_by_path.get(path, ['No owners found'])))
Yang Guo6e269a02019-06-26 11:17:02 +00004883 return 0
4884
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00004885 if args:
4886 if len(args) > 1:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004887 parser.error('Unknown args.')
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00004888 base_branch = args[0]
4889 else:
4890 # Default to diffing against the common ancestor of the upstream branch.
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00004891 base_branch = cl.GetCommonAncestorWithUpstream()
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00004892
Edward Lemur2c62b332020-03-12 22:12:33 +00004893 affected_files = cl.GetAffectedFiles(base_branch)
Dirk Prankebf980882017-09-02 15:08:00 -07004894
4895 if options.batch:
Edward Lesmese1576912021-02-16 21:53:34 +00004896 owners = cl.owners_client.SuggestOwners(affected_files, exclude=[author])
4897 print('\n'.join(owners))
Dirk Prankebf980882017-09-02 15:08:00 -07004898 return 0
4899
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00004900 return owners_finder.OwnersFinder(
Dirk Prankebf980882017-09-02 15:08:00 -07004901 affected_files,
Edward Lemur707d70b2018-02-07 00:50:14 +01004902 author,
Sidney San Martín8e6f58c2018-06-08 01:02:56 +00004903 [] if options.ignore_current else cl.GetReviewers(),
Edward Lesmes5cd75472021-02-19 00:34:25 +00004904 cl.owners_client,
Jochen Eisingerd0573ec2017-04-13 10:55:06 +02004905 disable_color=options.no_color,
Sylvain Defresneb1f865d2019-02-12 12:38:22 +00004906 ignore_author=options.ignore_self).run()
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00004907
4908
Aiden Bennerc08566e2018-10-03 17:52:42 +00004909def BuildGitDiffCmd(diff_type, upstream_commit, args, allow_prefix=False):
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00004910 """Generates a diff command."""
4911 # Generate diff for the current branch's changes.
Aiden Bennerc08566e2018-10-03 17:52:42 +00004912 diff_cmd = ['-c', 'core.quotePath=false', 'diff', '--no-ext-diff']
4913
Aiden Benner6c18a1a2018-11-23 20:18:23 +00004914 if allow_prefix:
4915 # explicitly setting --src-prefix and --dst-prefix is necessary in the
4916 # case that diff.noprefix is set in the user's git config.
4917 diff_cmd += ['--src-prefix=a/', '--dst-prefix=b/']
4918 else:
Aiden Bennerc08566e2018-10-03 17:52:42 +00004919 diff_cmd += ['--no-prefix']
4920
4921 diff_cmd += [diff_type, upstream_commit, '--']
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00004922
4923 if args:
4924 for arg in args:
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00004925 if os.path.isdir(arg) or os.path.isfile(arg):
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00004926 diff_cmd.append(arg)
4927 else:
4928 DieWithError('Argument "%s" is not a file or a directory' % arg)
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00004929
4930 return diff_cmd
4931
Andrii Shyshkalov18975322017-01-25 16:44:13 +01004932
Jamie Madill5e96ad12020-01-13 16:08:35 +00004933def _RunClangFormatDiff(opts, clang_diff_files, top_dir, upstream_commit):
4934 """Runs clang-format-diff and sets a return value if necessary."""
4935
4936 if not clang_diff_files:
4937 return 0
4938
4939 # Set to 2 to signal to CheckPatchFormatted() that this patch isn't
4940 # formatted. This is used to block during the presubmit.
4941 return_value = 0
4942
4943 # Locate the clang-format binary in the checkout
4944 try:
4945 clang_format_tool = clang_format.FindClangFormatToolInChromiumTree()
4946 except clang_format.NotFoundError as e:
4947 DieWithError(e)
4948
4949 if opts.full or settings.GetFormatFullByDefault():
4950 cmd = [clang_format_tool]
4951 if not opts.dry_run and not opts.diff:
4952 cmd.append('-i')
4953 if opts.dry_run:
4954 for diff_file in clang_diff_files:
4955 with open(diff_file, 'r') as myfile:
4956 code = myfile.read().replace('\r\n', '\n')
4957 stdout = RunCommand(cmd + [diff_file], cwd=top_dir)
4958 stdout = stdout.replace('\r\n', '\n')
4959 if opts.diff:
4960 sys.stdout.write(stdout)
4961 if code != stdout:
4962 return_value = 2
4963 else:
4964 stdout = RunCommand(cmd + clang_diff_files, cwd=top_dir)
4965 if opts.diff:
4966 sys.stdout.write(stdout)
4967 else:
Jamie Madill5e96ad12020-01-13 16:08:35 +00004968 try:
4969 script = clang_format.FindClangFormatScriptInChromiumTree(
4970 'clang-format-diff.py')
4971 except clang_format.NotFoundError as e:
4972 DieWithError(e)
4973
Edward Lesmes89624cd2020-04-06 17:51:56 +00004974 cmd = ['vpython', script, '-p0']
Jamie Madill5e96ad12020-01-13 16:08:35 +00004975 if not opts.dry_run and not opts.diff:
4976 cmd.append('-i')
4977
4978 diff_cmd = BuildGitDiffCmd('-U0', upstream_commit, clang_diff_files)
Edward Lemur1a83da12020-03-04 21:18:36 +00004979 diff_output = RunGit(diff_cmd).encode('utf-8')
Jamie Madill5e96ad12020-01-13 16:08:35 +00004980
Edward Lesmes89624cd2020-04-06 17:51:56 +00004981 env = os.environ.copy()
4982 env['PATH'] = (
4983 str(os.path.dirname(clang_format_tool)) + os.pathsep + env['PATH'])
4984 stdout = RunCommand(
4985 cmd, stdin=diff_output, cwd=top_dir, env=env,
Ilya Sherman7aed4bb2020-05-20 22:34:14 +00004986 shell=sys.platform.startswith('win32'))
Jamie Madill5e96ad12020-01-13 16:08:35 +00004987 if opts.diff:
4988 sys.stdout.write(stdout)
4989 if opts.dry_run and len(stdout) > 0:
4990 return_value = 2
4991
4992 return return_value
4993
4994
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00004995def MatchingFileType(file_name, extensions):
Quinten Yearsleyd242ed72019-07-25 17:17:55 +00004996 """Returns True if the file name ends with one of the given extensions."""
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00004997 return bool([ext for ext in extensions if file_name.lower().endswith(ext)])
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00004998
Andrii Shyshkalov18975322017-01-25 16:44:13 +01004999
enne@chromium.org555cfe42014-01-29 18:21:39 +00005000@subcommand.usage('[files or directories to diff]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005001@metrics.collector.collect_metrics('git cl format')
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005002def CMDformat(parser, args):
sbc@chromium.org9d0644d2015-06-05 23:16:54 +00005003 """Runs auto-formatting tools (clang-format etc.) on the diff."""
Christopher Lamc5ba6922017-01-24 11:19:14 +11005004 CLANG_EXTS = ['.cc', '.cpp', '.h', '.m', '.mm', '.proto', '.java']
kylechar58edce22016-06-17 06:07:51 -07005005 GN_EXTS = ['.gn', '.gni', '.typemap']
enne@chromium.org3b7e15c2014-01-21 17:44:47 +00005006 parser.add_option('--full', action='store_true',
5007 help='Reformat the full content of all touched files')
5008 parser.add_option('--dry-run', action='store_true',
5009 help='Don\'t modify any file on disk.')
Aiden Benner99b0ccb2018-11-20 19:53:31 +00005010 parser.add_option(
Garrett Beatyed0cc5f2020-01-06 17:26:13 +00005011 '--no-clang-format',
5012 dest='clang_format',
5013 action='store_false',
5014 default=True,
5015 help='Disables formatting of various file types using clang-format.')
5016 parser.add_option(
Aiden Benner99b0ccb2018-11-20 19:53:31 +00005017 '--python',
5018 action='store_true',
5019 default=None,
5020 help='Enables python formatting on all python files.')
5021 parser.add_option(
5022 '--no-python',
5023 action='store_true',
Garrett Beaty91a6f332020-01-06 16:57:24 +00005024 default=False,
Aiden Benner99b0ccb2018-11-20 19:53:31 +00005025 help='Disables python formatting on all python files. '
Garrett Beaty91a6f332020-01-06 16:57:24 +00005026 'If neither --python or --no-python are set, python files that have a '
5027 '.style.yapf file in an ancestor directory will be formatted. '
5028 'It is an error to set both.')
Garrett Beatyed0cc5f2020-01-06 17:26:13 +00005029 parser.add_option(
5030 '--js',
5031 action='store_true',
5032 help='Format javascript code with clang-format. '
5033 'Has no effect if --no-clang-format is set.')
wittman@chromium.org04d5a222014-03-07 18:30:42 +00005034 parser.add_option('--diff', action='store_true',
5035 help='Print diff to stdout rather than modifying files.')
Ilya Shermane081cbe2017-08-15 17:51:04 -07005036 parser.add_option('--presubmit', action='store_true',
5037 help='Used when running the script from a presubmit.')
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005038 opts, args = parser.parse_args(args)
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005039
Garrett Beaty91a6f332020-01-06 16:57:24 +00005040 if opts.python is not None and opts.no_python:
5041 raise parser.error('Cannot set both --python and --no-python')
5042 if opts.no_python:
5043 opts.python = False
5044
Daniel Chengc55eecf2016-12-30 03:11:02 -08005045 # Normalize any remaining args against the current path, so paths relative to
5046 # the current directory are still resolved as expected.
5047 args = [os.path.join(os.getcwd(), arg) for arg in args]
5048
enne@chromium.orgff7a1fb2013-12-10 19:21:41 +00005049 # git diff generates paths against the root of the repository. Change
5050 # to that directory so clang-format can find files even within subdirs.
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00005051 rel_base_path = settings.GetRelativeRoot()
enne@chromium.orgff7a1fb2013-12-10 19:21:41 +00005052 if rel_base_path:
5053 os.chdir(rel_base_path)
5054
digit@chromium.org29e47272013-05-17 17:01:46 +00005055 # Grab the merge-base commit, i.e. the upstream commit of the current
5056 # branch when it was created or the last time it was rebased. This is
5057 # to cover the case where the user may have called "git fetch origin",
5058 # moving the origin branch to a newer commit, but hasn't rebased yet.
5059 upstream_commit = None
5060 cl = Changelist()
5061 upstream_branch = cl.GetUpstreamBranch()
5062 if upstream_branch:
5063 upstream_commit = RunGit(['merge-base', 'HEAD', upstream_branch])
5064 upstream_commit = upstream_commit.strip()
5065
5066 if not upstream_commit:
5067 DieWithError('Could not find base commit for this branch. '
5068 'Are you in detached state?')
5069
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005070 changed_files_cmd = BuildGitDiffCmd('--name-only', upstream_commit, args)
5071 diff_output = RunGit(changed_files_cmd)
5072 diff_files = diff_output.splitlines()
jkarlin@chromium.orgad21b922016-01-28 17:48:42 +00005073 # Filter out files deleted by this CL
5074 diff_files = [x for x in diff_files if os.path.isfile(x)]
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005075
Andreas Haas417d89c2020-02-06 10:24:27 +00005076 if opts.js:
Deepanjan Roy605dd312018-07-02 17:48:54 +00005077 CLANG_EXTS.extend(['.js', '.ts'])
Christopher Lamc5ba6922017-01-24 11:19:14 +11005078
Garrett Beatyed0cc5f2020-01-06 17:26:13 +00005079 clang_diff_files = []
5080 if opts.clang_format:
5081 clang_diff_files = [
5082 x for x in diff_files if MatchingFileType(x, CLANG_EXTS)
5083 ]
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005084 python_diff_files = [x for x in diff_files if MatchingFileType(x, ['.py'])]
kylechar@chromium.org8b61f112016-02-05 13:28:58 +00005085 gn_diff_files = [x for x in diff_files if MatchingFileType(x, GN_EXTS)]
digit@chromium.org29e47272013-05-17 17:01:46 +00005086
Edward Lesmes50da7702020-03-30 19:23:43 +00005087 top_dir = settings.GetRoot()
nick@chromium.org3ac1c4e2014-01-16 02:44:42 +00005088
Jamie Madill5e96ad12020-01-13 16:08:35 +00005089 return_value = _RunClangFormatDiff(opts, clang_diff_files, top_dir,
5090 upstream_commit)
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005091
sbc@chromium.org9d0644d2015-06-05 23:16:54 +00005092 # Similar code to above, but using yapf on .py files rather than clang-format
5093 # on C/C++ files
Aiden Benner99b0ccb2018-11-20 19:53:31 +00005094 py_explicitly_disabled = opts.python is not None and not opts.python
5095 if python_diff_files and not py_explicitly_disabled:
Aiden Bennere47ac152018-11-20 16:44:03 +00005096 depot_tools_path = os.path.dirname(os.path.abspath(__file__))
5097 yapf_tool = os.path.join(depot_tools_path, 'yapf')
sbc@chromium.org9d0644d2015-06-05 23:16:54 +00005098
Aiden Bennerc08566e2018-10-03 17:52:42 +00005099 # Used for caching.
5100 yapf_configs = {}
5101 for f in python_diff_files:
5102 # Find the yapf style config for the current file, defaults to depot
5103 # tools default.
Aiden Benner99b0ccb2018-11-20 19:53:31 +00005104 _FindYapfConfigFile(f, yapf_configs, top_dir)
5105
5106 # Turn on python formatting by default if a yapf config is specified.
5107 # This breaks in the case of this repo though since the specified
5108 # style file is also the global default.
5109 if opts.python is None:
5110 filtered_py_files = []
5111 for f in python_diff_files:
5112 if _FindYapfConfigFile(f, yapf_configs, top_dir) is not None:
5113 filtered_py_files.append(f)
5114 else:
5115 filtered_py_files = python_diff_files
5116
5117 # Note: yapf still seems to fix indentation of the entire file
5118 # even if line ranges are specified.
5119 # See https://github.com/google/yapf/issues/499
5120 if not opts.full and filtered_py_files:
5121 py_line_diffs = _ComputeDiffLineRanges(filtered_py_files, upstream_commit)
5122
Brian Sheedyb4307d52019-12-02 19:18:17 +00005123 yapfignore_patterns = _GetYapfIgnorePatterns(top_dir)
5124 filtered_py_files = _FilterYapfIgnoredFiles(filtered_py_files,
5125 yapfignore_patterns)
Brian Sheedy59b06a82019-10-14 17:03:29 +00005126
Aiden Benner99b0ccb2018-11-20 19:53:31 +00005127 for f in filtered_py_files:
Andrew Grievefa40bfa2020-01-07 02:32:57 +00005128 yapf_style = _FindYapfConfigFile(f, yapf_configs, top_dir)
5129 # Default to pep8 if not .style.yapf is found.
5130 if not yapf_style:
5131 yapf_style = 'pep8'
Aiden Bennerc08566e2018-10-03 17:52:42 +00005132
Peter Wend9399922020-06-17 17:33:49 +00005133 with open(f, 'r') as py_f:
5134 if 'python3' in py_f.readline():
5135 vpython_script = 'vpython3'
5136 else:
5137 vpython_script = 'vpython'
5138
5139 cmd = [vpython_script, yapf_tool, '--style', yapf_style, f]
Aiden Bennerc08566e2018-10-03 17:52:42 +00005140
5141 has_formattable_lines = False
5142 if not opts.full:
5143 # Only run yapf over changed line ranges.
5144 for diff_start, diff_len in py_line_diffs[f]:
5145 diff_end = diff_start + diff_len - 1
5146 # Yapf errors out if diff_end < diff_start but this
5147 # is a valid line range diff for a removal.
5148 if diff_end >= diff_start:
5149 has_formattable_lines = True
5150 cmd += ['-l', '{}-{}'.format(diff_start, diff_end)]
5151 # If all line diffs were removals we have nothing to format.
5152 if not has_formattable_lines:
5153 continue
5154
5155 if opts.diff or opts.dry_run:
5156 cmd += ['--diff']
5157 # Will return non-zero exit code if non-empty diff.
Edward Lesmesb7db1832020-06-22 20:22:27 +00005158 stdout = RunCommand(cmd,
5159 error_ok=True,
5160 cwd=top_dir,
5161 shell=sys.platform.startswith('win32'))
Aiden Bennerc08566e2018-10-03 17:52:42 +00005162 if opts.diff:
5163 sys.stdout.write(stdout)
5164 elif len(stdout) > 0:
5165 return_value = 2
5166 else:
5167 cmd += ['-i']
Edward Lesmesb7db1832020-06-22 20:22:27 +00005168 RunCommand(cmd, cwd=top_dir, shell=sys.platform.startswith('win32'))
sbc@chromium.org9d0644d2015-06-05 23:16:54 +00005169
kylechar@chromium.org8b61f112016-02-05 13:28:58 +00005170 # Format GN build files. Always run on full build files for canonical form.
5171 if gn_diff_files:
Andrii Shyshkalov18975322017-01-25 16:44:13 +01005172 cmd = ['gn', 'format']
brettw4b8ed592016-08-05 16:19:12 -07005173 if opts.dry_run or opts.diff:
5174 cmd.append('--dry-run')
kylechar@chromium.org8b61f112016-02-05 13:28:58 +00005175 for gn_diff_file in gn_diff_files:
brettw4b8ed592016-08-05 16:19:12 -07005176 gn_ret = subprocess2.call(cmd + [gn_diff_file],
Ilya Sherman7aed4bb2020-05-20 22:34:14 +00005177 shell=sys.platform.startswith('win'),
brettw4b8ed592016-08-05 16:19:12 -07005178 cwd=top_dir)
5179 if opts.dry_run and gn_ret == 2:
5180 return_value = 2 # Not formatted.
5181 elif opts.diff and gn_ret == 2:
5182 # TODO this should compute and print the actual diff.
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005183 print('This change has GN build file diff for ' + gn_diff_file)
brettw4b8ed592016-08-05 16:19:12 -07005184 elif gn_ret != 0:
5185 # For non-dry run cases (and non-2 return values for dry-run), a
5186 # nonzero error code indicates a failure, probably because the file
5187 # doesn't parse.
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005188 DieWithError('gn format failed on ' + gn_diff_file +
5189 '\nTry running `gn format` on this file manually.')
kylechar@chromium.org8b61f112016-02-05 13:28:58 +00005190
Ilya Shermane081cbe2017-08-15 17:51:04 -07005191 # Skip the metrics formatting from the global presubmit hook. These files have
5192 # a separate presubmit hook that issues an error if the files need formatting,
5193 # whereas the top-level presubmit script merely issues a warning. Formatting
5194 # these files is somewhat slow, so it's important not to duplicate the work.
5195 if not opts.presubmit:
Wenhan (Han) Zhang3bd3c992020-08-14 16:27:39 +00005196 for diff_xml in GetDiffXMLs(diff_files):
5197 xml_dir = GetMetricsDir(diff_xml)
5198 if not xml_dir:
5199 continue
5200
Ilya Shermane081cbe2017-08-15 17:51:04 -07005201 tool_dir = os.path.join(top_dir, xml_dir)
Ilya Sherman7aed4bb2020-05-20 22:34:14 +00005202 pretty_print_tool = os.path.join(tool_dir, 'pretty_print.py')
5203 cmd = ['vpython', pretty_print_tool, '--non-interactive']
Wenhan (Han) Zhang3bd3c992020-08-14 16:27:39 +00005204
5205 # If the XML file is histograms.xml or enums.xml, add the xml path to the
5206 # command as histograms/pretty_print.py now needs a relative path argument
5207 # after splitting the histograms into multiple directories.
5208 # For example, in tools/metrics/ukm, pretty-print could be run using:
5209 # $ python pretty_print.py
5210 # But in tools/metrics/histogrmas, pretty-print should be run with an
5211 # additional relative path argument, like:
5212 # $ python pretty_print.py histograms_xml/UMA/histograms.xml
5213 # $ python pretty_print.py enums.xml
5214
5215 # TODO (crbug/1116488): Remove this check after ensuring that the updated
5216 # version of histograms/pretty_print.py is released.
5217 filepath_required = os.path.exists(
5218 os.path.join(tool_dir, 'validate_prefix.py'))
5219
Weilun Shib92c4b72020-08-27 17:45:11 +00005220 if (diff_xml.endswith('histograms.xml') or diff_xml.endswith('enums.xml')
5221 or diff_xml.endswith('histogram_suffixes_list.xml')
5222 ) and filepath_required:
Wenhan (Han) Zhang3bd3c992020-08-14 16:27:39 +00005223 cmd.append(diff_xml)
5224
Ilya Shermane081cbe2017-08-15 17:51:04 -07005225 if opts.dry_run or opts.diff:
5226 cmd.append('--diff')
Wenhan (Han) Zhang3bd3c992020-08-14 16:27:39 +00005227
Ilya Sherman7aed4bb2020-05-20 22:34:14 +00005228 # TODO(isherman): Once this file runs only on Python 3.3+, drop the
5229 # `shell` param and instead replace `'vpython'` with
5230 # `shutil.which('frob')` above: https://stackoverflow.com/a/32799942
Wenhan (Han) Zhang3bd3c992020-08-14 16:27:39 +00005231 stdout = RunCommand(cmd,
5232 cwd=top_dir,
Ilya Sherman7aed4bb2020-05-20 22:34:14 +00005233 shell=sys.platform.startswith('win32'))
Ilya Shermane081cbe2017-08-15 17:51:04 -07005234 if opts.diff:
5235 sys.stdout.write(stdout)
5236 if opts.dry_run and stdout:
5237 return_value = 2 # Not formatted.
Alexei Svitkinef3cac412017-02-06 11:08:50 -05005238
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005239 return return_value
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005240
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005241
Wenhan (Han) Zhang3bd3c992020-08-14 16:27:39 +00005242def GetDiffXMLs(diff_files):
5243 return [
5244 os.path.normpath(x) for x in diff_files if MatchingFileType(x, ['.xml'])
5245 ]
5246
5247
5248def GetMetricsDir(diff_xml):
Steven Holte2e664bf2017-04-21 13:10:47 -07005249 metrics_xml_dirs = [
5250 os.path.join('tools', 'metrics', 'actions'),
5251 os.path.join('tools', 'metrics', 'histograms'),
5252 os.path.join('tools', 'metrics', 'rappor'),
Ilya Shermanb67e60c2020-05-20 22:27:03 +00005253 os.path.join('tools', 'metrics', 'structured'),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005254 os.path.join('tools', 'metrics', 'ukm'),
5255 ]
Steven Holte2e664bf2017-04-21 13:10:47 -07005256 for xml_dir in metrics_xml_dirs:
Wenhan (Han) Zhang3bd3c992020-08-14 16:27:39 +00005257 if diff_xml.startswith(xml_dir):
5258 return xml_dir
5259 return None
Steven Holte2e664bf2017-04-21 13:10:47 -07005260
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005261
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005262@subcommand.usage('<codereview url or issue id>')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005263@metrics.collector.collect_metrics('git cl checkout')
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005264def CMDcheckout(parser, args):
Edward Lemurf38bc172019-09-03 21:02:13 +00005265 """Checks out a branch associated with a given Gerrit issue."""
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005266 _, args = parser.parse_args(args)
5267
5268 if len(args) != 1:
5269 parser.print_help()
5270 return 1
5271
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00005272 issue_arg = ParseIssueNumberArgument(args[0])
tandrii@chromium.orgde6c9a12016-04-11 15:33:53 +00005273 if not issue_arg.valid:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00005274 parser.error('Invalid issue ID or URL.')
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02005275
tandrii@chromium.orgabd27e52016-04-11 15:43:32 +00005276 target_issue = str(issue_arg.issue)
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005277
Edward Lemur52969c92020-02-06 18:15:28 +00005278 output = RunGit(['config', '--local', '--get-regexp',
Edward Lesmes50da7702020-03-30 19:23:43 +00005279 r'branch\..*\.' + ISSUE_CONFIG_KEY],
Edward Lemur52969c92020-02-06 18:15:28 +00005280 error_ok=True)
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005281
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00005282 branches = []
Edward Lemur52969c92020-02-06 18:15:28 +00005283 for key, issue in [x.split() for x in output.splitlines()]:
5284 if issue == target_issue:
Edward Lesmes50da7702020-03-30 19:23:43 +00005285 branches.append(re.sub(r'branch\.(.*)\.' + ISSUE_CONFIG_KEY, r'\1', key))
Edward Lemur52969c92020-02-06 18:15:28 +00005286
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005287 if len(branches) == 0:
vapiera7fbd5a2016-06-16 09:17:49 -07005288 print('No branch found for issue %s.' % target_issue)
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005289 return 1
5290 if len(branches) == 1:
5291 RunGit(['checkout', branches[0]])
5292 else:
vapiera7fbd5a2016-06-16 09:17:49 -07005293 print('Multiple branches match issue %s:' % target_issue)
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005294 for i in range(len(branches)):
vapiera7fbd5a2016-06-16 09:17:49 -07005295 print('%d: %s' % (i, branches[i]))
Edward Lesmesae3586b2020-03-23 21:21:14 +00005296 which = gclient_utils.AskForData('Choose by index: ')
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005297 try:
5298 RunGit(['checkout', branches[int(which)]])
5299 except (IndexError, ValueError):
vapiera7fbd5a2016-06-16 09:17:49 -07005300 print('Invalid selection, not checking out any branch.')
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005301 return 1
5302
5303 return 0
5304
5305
maruel@chromium.org29404b52014-09-08 22:58:00 +00005306def CMDlol(parser, args):
5307 # This command is intentionally undocumented.
vapiera7fbd5a2016-06-16 09:17:49 -07005308 print(zlib.decompress(base64.b64decode(
thakis@chromium.org3421c992014-11-02 02:20:32 +00005309 'eNptkLEOwyAMRHe+wupCIqW57v0Vq84WqWtXyrcXnCBsmgMJ+/SSAxMZgRB6NzE'
5310 'E2ObgCKJooYdu4uAQVffUEoE1sRQLxAcqzd7uK2gmStrll1ucV3uZyaY5sXyDd9'
5311 'JAnN+lAXsOMJ90GANAi43mq5/VeeacylKVgi8o6F1SC63FxnagHfJUTfUYdCR/W'
Gavin Mak18f45d22020-12-04 21:45:10 +00005312 'Ofe+0dHL7PicpytKP750Fh1q2qnLVof4w8OZWNY')).decode('utf-8'))
maruel@chromium.org29404b52014-09-08 22:58:00 +00005313 return 0
5314
5315
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005316class OptionParser(optparse.OptionParser):
5317 """Creates the option parse and add --verbose support."""
Sigurd Schneider9abde8c2020-11-17 08:44:52 +00005318
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005319 def __init__(self, *args, **kwargs):
maruel@chromium.org0633fb42013-08-16 20:06:14 +00005320 optparse.OptionParser.__init__(
5321 self, *args, prog='git cl', version=__version__, **kwargs)
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005322 self.add_option(
5323 '-v', '--verbose', action='count', default=0,
5324 help='Use 2 times for more debugging info')
5325
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005326 def parse_args(self, args=None, _values=None):
Andrii Shyshkalov46f20cd2018-10-30 06:42:54 +00005327 try:
5328 return self._parse_args(args)
5329 finally:
5330 # Regardless of success or failure of args parsing, we want to report
5331 # metrics, but only after logging has been initialized (if parsing
5332 # succeeded).
5333 global settings
5334 settings = Settings()
5335
5336 if not metrics.DISABLE_METRICS_COLLECTION:
5337 # GetViewVCUrl ultimately calls logging method.
5338 project_url = settings.GetViewVCUrl().strip('/+')
5339 if project_url in metrics_utils.KNOWN_PROJECT_URLS:
5340 metrics.collector.add('project_urls', [project_url])
5341
5342 def _parse_args(self, args=None):
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005343 # Create an optparse.Values object that will store only the actual passed
5344 # options, without the defaults.
5345 actual_options = optparse.Values()
5346 _, args = optparse.OptionParser.parse_args(self, args, actual_options)
5347 # Create an optparse.Values object with the default options.
5348 options = optparse.Values(self.get_default_values().__dict__)
5349 # Update it with the options passed by the user.
5350 options._update_careful(actual_options.__dict__)
5351 # Store the options passed by the user in an _actual_options attribute.
5352 # We store only the keys, and not the values, since the values can contain
5353 # arbitrary information, which might be PII.
Edward Lemur79d4f992019-11-11 23:49:02 +00005354 metrics.collector.add('arguments', list(actual_options.__dict__.keys()))
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005355
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005356 levels = [logging.WARNING, logging.INFO, logging.DEBUG]
Andrii Shyshkalov5b04a572017-01-23 17:44:41 +01005357 logging.basicConfig(
5358 level=levels[min(options.verbose, len(levels) - 1)],
5359 format='[%(levelname).1s%(asctime)s %(process)d %(thread)d '
5360 '%(filename)s] %(message)s')
Edward Lemur83bd7f42018-10-10 00:14:21 +00005361
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005362 return options, args
5363
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005364
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005365def main(argv):
maruel@chromium.org82798cb2012-02-23 18:16:12 +00005366 if sys.hexversion < 0x02060000:
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005367 print('\nYour Python version %s is unsupported, please upgrade.\n' %
vapiera7fbd5a2016-06-16 09:17:49 -07005368 (sys.version.split(' ', 1)[0],), file=sys.stderr)
maruel@chromium.org82798cb2012-02-23 18:16:12 +00005369 return 2
maruel@chromium.org2e23ce32013-05-07 12:42:28 +00005370
maruel@chromium.org39c0b222013-08-17 16:57:01 +00005371 colorize_CMDstatus_doc()
maruel@chromium.org0633fb42013-08-16 20:06:14 +00005372 dispatcher = subcommand.CommandDispatcher(__name__)
5373 try:
5374 return dispatcher.execute(OptionParser(), argv)
Edward Lemur5b929a42019-10-21 17:57:39 +00005375 except auth.LoginRequiredError as e:
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +00005376 DieWithError(str(e))
Edward Lemur79d4f992019-11-11 23:49:02 +00005377 except urllib.error.HTTPError as e:
maruel@chromium.org0633fb42013-08-16 20:06:14 +00005378 if e.code != 500:
5379 raise
5380 DieWithError(
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005381 ('App Engine is misbehaving and returned HTTP %d, again. Keep faith '
Quinten Yearsleyc4202212019-07-22 23:34:40 +00005382 'and retry or visit go/isgaeup.\n%s') % (e.code, str(e)))
sbc@chromium.org013731e2015-02-26 18:28:43 +00005383 return 0
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005384
5385
5386if __name__ == '__main__':
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005387 # These affect sys.stdout, so do it outside of main() to simplify mocks in
5388 # the unit tests.
maruel@chromium.org6f09cd92011-04-01 16:38:12 +00005389 fix_encoding.fix_encoding()
iannucci@chromium.org596cd5c2016-04-04 21:34:39 +00005390 setup_color.init()
Edward Lemur6f812e12018-07-31 22:45:57 +00005391 with metrics.collector.print_notice_and_exit():
sbc@chromium.org013731e2015-02-26 18:28:43 +00005392 sys.exit(main(sys.argv[1:]))