blob: 1e2f675cb05f9992d1062dce4e3023a874576384 [file] [log] [blame]
Josip Sokcevic4de5dea2022-03-23 21:15:14 +00001#!/usr/bin/env vpython3
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +02002# Copyright (c) 2013 The Chromium Authors. All rights reserved.
maruel@chromium.org725f1c32011-04-01 20:24:54 +00003# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00006# Copyright (C) 2008 Evan Martin <martine@danga.com>
7
Andrii Shyshkalov03da1502018-10-15 03:42:34 +00008"""A git-command for integrating reviews on Gerrit."""
maruel@chromium.org725f1c32011-04-01 20:24:54 +00009
vapiera7fbd5a2016-06-16 09:17:49 -070010from __future__ import print_function
11
thakis@chromium.org3421c992014-11-02 02:20:32 +000012import base64
rmistry@google.com2dd99862015-06-22 12:22:18 +000013import collections
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +010014import datetime
Brian Sheedyb4307d52019-12-02 19:18:17 +000015import fnmatch
Edward Lemur202c5592019-10-21 22:44:52 +000016import httplib2
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +010017import itertools
maruel@chromium.org4f6852c2012-04-20 20:39:20 +000018import json
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000019import logging
calamity@chromium.orgcf197482016-04-29 20:15:53 +000020import multiprocessing
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000021import optparse
22import os
23import re
Andrii Shyshkalov353637c2017-03-14 16:52:18 +010024import shutil
ukai@chromium.org78c4b982012-02-14 02:20:26 +000025import stat
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000026import sys
Aaron Gable9a03ae02017-11-03 11:31:07 -070027import tempfile
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000028import textwrap
Edward Lemurfec80c42018-11-01 23:14:14 +000029import time
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +000030import uuid
thestig@chromium.org00858c82013-12-02 23:08:03 +000031import webbrowser
thakis@chromium.org3421c992014-11-02 02:20:32 +000032import zlib
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000033
maruel@chromium.org2e23ce32013-05-07 12:42:28 +000034from third_party import colorama
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +000035import auth
nick@chromium.org3ac1c4e2014-01-16 02:44:42 +000036import clang_format
maruel@chromium.org6f09cd92011-04-01 16:38:12 +000037import fix_encoding
maruel@chromium.org0e0436a2011-10-25 13:32:41 +000038import gclient_utils
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +000039import gerrit_util
iannucci@chromium.org9e849272014-04-04 00:31:55 +000040import git_common
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +000041import git_footers
Edward Lemur85153282020-02-14 22:06:29 +000042import git_new_branch
Edward Lemur5ba1e9c2018-07-23 18:19:02 +000043import metrics
Edward Lesmes93277a72018-10-18 22:04:26 +000044import metrics_utils
Edward Lesmeseeca9c62020-11-20 00:00:17 +000045import owners_client
iannucci@chromium.org9e849272014-04-04 00:31:55 +000046import owners_finder
Lei Zhangb8c62cf2020-07-15 20:09:37 +000047import presubmit_canned_checks
maruel@chromium.org2a74d372011-03-29 19:05:50 +000048import presubmit_support
Lukasz Anforowiczb4d39542021-09-30 23:39:25 +000049import rustfmt
maruel@chromium.org2a74d372011-03-29 19:05:50 +000050import scm
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +000051import setup_color
Francois Dorayd42c6812017-05-30 15:10:20 -040052import split_cl
maruel@chromium.org0633fb42013-08-16 20:06:14 +000053import subcommand
maruel@chromium.org32f9f5e2011-09-14 13:41:47 +000054import subprocess2
Olivier Robin0a6b5442022-04-07 07:25:04 +000055import swift_format
maruel@chromium.org2a74d372011-03-29 19:05:50 +000056import watchlists
57
Edward Lemur79d4f992019-11-11 23:49:02 +000058from third_party import six
59from six.moves import urllib
60
61
62if sys.version_info.major == 3:
63 basestring = (str,) # pylint: disable=redefined-builtin
64
Edward Lemurb9830242019-10-30 22:19:20 +000065
tandrii7400cf02016-06-21 08:48:07 -070066__version__ = '2.0'
maruel@chromium.org2a74d372011-03-29 19:05:50 +000067
Edward Lemur0f58ae42019-04-30 17:24:12 +000068# Traces for git push will be stored in a traces directory inside the
69# depot_tools checkout.
70DEPOT_TOOLS = os.path.dirname(os.path.abspath(__file__))
71TRACES_DIR = os.path.join(DEPOT_TOOLS, 'traces')
Edward Lemur227d5102020-02-25 23:45:35 +000072PRESUBMIT_SUPPORT = os.path.join(DEPOT_TOOLS, 'presubmit_support.py')
Edward Lemur0f58ae42019-04-30 17:24:12 +000073
74# When collecting traces, Git hashes will be reduced to 6 characters to reduce
75# the size after compression.
76GIT_HASH_RE = re.compile(r'\b([a-f0-9]{6})[a-f0-9]{34}\b', flags=re.I)
77# Used to redact the cookies from the gitcookies file.
78GITCOOKIES_REDACT_RE = re.compile(r'1/.*')
79
Edward Lemurd4d1ba42019-09-20 21:46:37 +000080MAX_ATTEMPTS = 3
81
Edward Lemur1b52d872019-05-09 21:12:12 +000082# The maximum number of traces we will keep. Multiplied by 3 since we store
83# 3 files per trace.
84MAX_TRACES = 3 * 10
Edward Lemur5737f022019-05-17 01:24:00 +000085# Message to be displayed to the user to inform where to find the traces for a
86# git-cl upload execution.
Edward Lemur0f58ae42019-04-30 17:24:12 +000087TRACES_MESSAGE = (
Edward Lemur1b52d872019-05-09 21:12:12 +000088'\n'
Edward Lemur5737f022019-05-17 01:24:00 +000089'The traces of this git-cl execution have been recorded at:\n'
Edward Lemur1b52d872019-05-09 21:12:12 +000090' %(trace_name)s-traces.zip\n'
Edward Lemur5737f022019-05-17 01:24:00 +000091'Copies of your gitcookies file and git config have been recorded at:\n'
92' %(trace_name)s-git-info.zip\n')
Edward Lemur1b52d872019-05-09 21:12:12 +000093# Format of the message to be stored as part of the traces to give developers a
94# better context when they go through traces.
95TRACES_README_FORMAT = (
96'Date: %(now)s\n'
97'\n'
98'Change: https://%(gerrit_host)s/q/%(change_id)s\n'
99'Title: %(title)s\n'
100'\n'
101'%(description)s\n'
102'\n'
103'Execution time: %(execution_time)s\n'
104'Exit code: %(exit_code)s\n') + TRACES_MESSAGE
Edward Lemur0f58ae42019-04-30 17:24:12 +0000105
Aaron Gable1bc7bfe2016-12-19 10:08:14 -0800106POSTUPSTREAM_HOOK = '.git/hooks/post-cl-land'
Henrique Ferreiroff249622019-11-28 23:19:29 +0000107DESCRIPTION_BACKUP_FILE = '.git_cl_description_backup'
rmistry@google.comc68112d2015-03-03 12:48:06 +0000108REFS_THAT_ALIAS_TO_OTHER_REFS = {
Josip Sokcevic7e133ff2021-07-13 17:44:53 +0000109 'refs/remotes/origin/lkgr': 'refs/remotes/origin/main',
110 'refs/remotes/origin/lkcr': 'refs/remotes/origin/main',
rmistry@google.comc68112d2015-03-03 12:48:06 +0000111}
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000112
Josip Sokcevicc39ab992020-09-24 20:09:15 +0000113DEFAULT_OLD_BRANCH = 'refs/remotes/origin/master'
114DEFAULT_NEW_BRANCH = 'refs/remotes/origin/main'
115
thestig@chromium.org44202a22014-03-11 19:22:18 +0000116# Valid extensions for files we want to lint.
117DEFAULT_LINT_REGEX = r"(.*\.cpp|.*\.cc|.*\.h)"
118DEFAULT_LINT_IGNORE_REGEX = r"$^"
119
Aiden Bennerc08566e2018-10-03 17:52:42 +0000120# File name for yapf style config files.
121YAPF_CONFIG_FILENAME = '.style.yapf'
122
Edward Lesmes50da7702020-03-30 19:23:43 +0000123# The issue, patchset and codereview server are stored on git config for each
124# branch under branch.<branch-name>.<config-key>.
125ISSUE_CONFIG_KEY = 'gerritissue'
126PATCHSET_CONFIG_KEY = 'gerritpatchset'
127CODEREVIEW_SERVER_CONFIG_KEY = 'gerritserver'
128
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000129# Shortcut since it quickly becomes repetitive.
maruel@chromium.org2e23ce32013-05-07 12:42:28 +0000130Fore = colorama.Fore
maruel@chromium.org90541732011-04-01 17:54:18 +0000131
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000132# Initialized in main()
133settings = None
134
Andrii Shyshkalov768f1d82016-12-08 15:10:13 +0100135# Used by tests/git_cl_test.py to add extra logging.
136# Inside the weirdly failing test, add this:
137# >>> self.mock(git_cl, '_IS_BEING_TESTED', True)
Quinten Yearsley0c62da92017-05-31 13:39:42 -0700138# And scroll up to see the stack trace printed.
Andrii Shyshkalov768f1d82016-12-08 15:10:13 +0100139_IS_BEING_TESTED = False
140
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000141
Andrii Shyshkalov1ee78cd2020-03-12 01:31:53 +0000142_KNOWN_GERRIT_TO_SHORT_URLS = {
143 'https://chrome-internal-review.googlesource.com': 'https://crrev.com/i',
144 'https://chromium-review.googlesource.com': 'https://crrev.com/c',
145}
Andrii Shyshkalov8aebb602020-04-16 22:10:27 +0000146assert len(_KNOWN_GERRIT_TO_SHORT_URLS) == len(
147 set(_KNOWN_GERRIT_TO_SHORT_URLS.values())), 'must have unique values'
Andrii Shyshkalov1ee78cd2020-03-12 01:31:53 +0000148
149
Josip Sokcevicf736cab2020-10-20 23:41:38 +0000150class GitPushError(Exception):
151 pass
152
153
Christopher Lamf732cd52017-01-24 12:40:11 +1100154def DieWithError(message, change_desc=None):
155 if change_desc:
156 SaveDescriptionBackup(change_desc)
Josip Sokcevic953278a2020-02-28 19:46:36 +0000157 print('\n ** Content of CL description **\n' +
158 '='*72 + '\n' +
159 change_desc.description + '\n' +
160 '='*72 + '\n')
Christopher Lamf732cd52017-01-24 12:40:11 +1100161
vapiera7fbd5a2016-06-16 09:17:49 -0700162 print(message, file=sys.stderr)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000163 sys.exit(1)
164
165
Christopher Lamf732cd52017-01-24 12:40:11 +1100166def SaveDescriptionBackup(change_desc):
Henrique Ferreiro5ae48172019-11-29 16:14:42 +0000167 backup_path = os.path.join(DEPOT_TOOLS, DESCRIPTION_BACKUP_FILE)
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000168 print('\nsaving CL description to %s\n' % backup_path)
sokcevic07152802021-08-18 00:06:34 +0000169 with open(backup_path, 'wb') as backup_file:
170 backup_file.write(change_desc.description.encode('utf-8'))
Christopher Lamf732cd52017-01-24 12:40:11 +1100171
172
thestig@chromium.org8b0553c2014-02-11 00:33:37 +0000173def GetNoGitPagerEnv():
174 env = os.environ.copy()
175 # 'cat' is a magical git string that disables pagers on all platforms.
176 env['GIT_PAGER'] = 'cat'
177 return env
178
vadimsh@chromium.org566a02a2014-08-22 01:34:13 +0000179
bsep@chromium.org627d9002016-04-29 00:00:52 +0000180def RunCommand(args, error_ok=False, error_message=None, shell=False, **kwargs):
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000181 try:
Edward Lemur79d4f992019-11-11 23:49:02 +0000182 stdout = subprocess2.check_output(args, shell=shell, **kwargs)
183 return stdout.decode('utf-8', 'replace')
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000184 except subprocess2.CalledProcessError as e:
185 logging.debug('Failed running %s', args)
maruel@chromium.org32f9f5e2011-09-14 13:41:47 +0000186 if not error_ok:
Alan Cutter594fd332020-07-21 23:55:27 +0000187 message = error_message or e.stdout.decode('utf-8', 'replace') or ''
188 DieWithError('Command "%s" failed.\n%s' % (' '.join(args), message))
Josip Sokcevic673e8ed2021-10-27 23:46:18 +0000189 out = e.stdout.decode('utf-8', 'replace')
190 if e.stderr:
191 out += e.stderr.decode('utf-8', 'replace')
192 return out
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000193
194
195def RunGit(args, **kwargs):
maruel@chromium.org32f9f5e2011-09-14 13:41:47 +0000196 """Returns stdout."""
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000197 return RunCommand(['git'] + args, **kwargs)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000198
199
enne@chromium.org3b7e15c2014-01-21 17:44:47 +0000200def RunGitWithCode(args, suppress_stderr=False):
maruel@chromium.org32f9f5e2011-09-14 13:41:47 +0000201 """Returns return code and stdout."""
tandrii5d48c322016-08-18 16:19:37 -0700202 if suppress_stderr:
Edward Lesmescf06cad2020-12-14 22:03:23 +0000203 stderr = subprocess2.DEVNULL
tandrii5d48c322016-08-18 16:19:37 -0700204 else:
205 stderr = sys.stderr
szager@chromium.org9bb85e22012-06-13 20:28:23 +0000206 try:
tandrii5d48c322016-08-18 16:19:37 -0700207 (out, _), code = subprocess2.communicate(['git'] + args,
208 env=GetNoGitPagerEnv(),
209 stdout=subprocess2.PIPE,
210 stderr=stderr)
Edward Lemur79d4f992019-11-11 23:49:02 +0000211 return code, out.decode('utf-8', 'replace')
tandrii5d48c322016-08-18 16:19:37 -0700212 except subprocess2.CalledProcessError as e:
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +0900213 logging.debug('Failed running %s', ['git'] + args)
Edward Lemur79d4f992019-11-11 23:49:02 +0000214 return e.returncode, e.stdout.decode('utf-8', 'replace')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000215
216
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000217def RunGitSilent(args):
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +0000218 """Returns stdout, suppresses stderr and ignores the return code."""
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000219 return RunGitWithCode(args, suppress_stderr=True)[1]
220
221
tandrii2a16b952016-10-19 07:09:44 -0700222def time_sleep(seconds):
223 # Use this so that it can be mocked in tests without interfering with python
224 # system machinery.
tandrii2a16b952016-10-19 07:09:44 -0700225 return time.sleep(seconds)
226
227
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000228def time_time():
229 # Use this so that it can be mocked in tests without interfering with python
230 # system machinery.
231 return time.time()
232
233
Edward Lemur1b52d872019-05-09 21:12:12 +0000234def datetime_now():
235 # Use this so that it can be mocked in tests without interfering with python
236 # system machinery.
237 return datetime.datetime.now()
238
239
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100240def confirm_or_exit(prefix='', action='confirm'):
241 """Asks user to press enter to continue or press Ctrl+C to abort."""
242 if not prefix or prefix.endswith('\n'):
243 mid = 'Press'
Andrii Shyshkalov353637c2017-03-14 16:52:18 +0100244 elif prefix.endswith('.') or prefix.endswith('?'):
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100245 mid = ' Press'
246 elif prefix.endswith(' '):
247 mid = 'press'
248 else:
249 mid = ' press'
Edward Lesmesae3586b2020-03-23 21:21:14 +0000250 gclient_utils.AskForData(
251 '%s%s Enter to %s, or Ctrl+C to abort' % (prefix, mid, action))
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100252
253
254def ask_for_explicit_yes(prompt):
Quinten Yearsleyd242ed72019-07-25 17:17:55 +0000255 """Returns whether user typed 'y' or 'yes' to confirm the given prompt."""
Edward Lesmesae3586b2020-03-23 21:21:14 +0000256 result = gclient_utils.AskForData(prompt + ' [Yes/No]: ').lower()
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100257 while True:
258 if 'yes'.startswith(result):
259 return True
260 if 'no'.startswith(result):
261 return False
Edward Lesmesae3586b2020-03-23 21:21:14 +0000262 result = gclient_utils.AskForData('Please, type yes or no: ').lower()
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100263
264
machenbach@chromium.org45453142015-09-15 08:45:22 +0000265def _get_properties_from_options(options):
Quinten Yearsleya19d3532019-09-30 21:54:39 +0000266 prop_list = getattr(options, 'properties', [])
267 properties = dict(x.split('=', 1) for x in prop_list)
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +0000268 for key, val in properties.items():
machenbach@chromium.org45453142015-09-15 08:45:22 +0000269 try:
270 properties[key] = json.loads(val)
271 except ValueError:
272 pass # If a value couldn't be evaluated, treat it as a string.
273 return properties
274
275
Edward Lemur4c707a22019-09-24 21:13:43 +0000276def _call_buildbucket(http, buildbucket_host, method, request):
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000277 """Calls a buildbucket v2 method and returns the parsed json response."""
278 headers = {
279 'Accept': 'application/json',
280 'Content-Type': 'application/json',
281 }
282 request = json.dumps(request)
283 url = 'https://%s/prpc/buildbucket.v2.Builds/%s' % (buildbucket_host, method)
284
285 logging.info('POST %s with %s' % (url, request))
286
287 attempts = 1
288 time_to_sleep = 1
289 while True:
290 response, content = http.request(url, 'POST', body=request, headers=headers)
291 if response.status == 200:
292 return json.loads(content[4:])
293 if attempts >= MAX_ATTEMPTS or 400 <= response.status < 500:
294 msg = '%s error when calling POST %s with %s: %s' % (
295 response.status, url, request, content)
296 raise BuildbucketResponseException(msg)
297 logging.debug(
298 '%s error when calling POST %s with %s. '
299 'Sleeping for %d seconds and retrying...' % (
300 response.status, url, request, time_to_sleep))
301 time.sleep(time_to_sleep)
302 time_to_sleep *= 2
303 attempts += 1
304
305 assert False, 'unreachable'
306
307
Edward Lemur6215c792019-10-03 21:59:05 +0000308def _parse_bucket(raw_bucket):
309 legacy = True
310 project = bucket = None
311 if '/' in raw_bucket:
312 legacy = False
313 project, bucket = raw_bucket.split('/', 1)
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000314 # Assume luci.<project>.<bucket>.
Edward Lemur6215c792019-10-03 21:59:05 +0000315 elif raw_bucket.startswith('luci.'):
316 project, bucket = raw_bucket[len('luci.'):].split('.', 1)
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000317 # Otherwise, assume prefix is also the project name.
Edward Lemur6215c792019-10-03 21:59:05 +0000318 elif '.' in raw_bucket:
319 project = raw_bucket.split('.')[0]
320 bucket = raw_bucket
321 # Legacy buckets.
Edward Lemur45768512020-03-02 19:03:14 +0000322 if legacy and project and bucket:
Edward Lemur6215c792019-10-03 21:59:05 +0000323 print('WARNING Please use %s/%s to specify the bucket.' % (project, bucket))
324 return project, bucket
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000325
326
Quinten Yearsley777660f2020-03-04 23:37:06 +0000327def _trigger_tryjobs(changelist, jobs, options, patchset):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000328 """Sends a request to Buildbucket to trigger tryjobs for a changelist.
qyearsley1fdfcb62016-10-24 13:22:03 -0700329
330 Args:
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000331 changelist: Changelist that the tryjobs are associated with.
Edward Lemur45768512020-03-02 19:03:14 +0000332 jobs: A list of (project, bucket, builder).
qyearsley1fdfcb62016-10-24 13:22:03 -0700333 options: Command-line options.
334 """
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000335 print('Scheduling jobs on:')
Edward Lemur45768512020-03-02 19:03:14 +0000336 for project, bucket, builder in jobs:
337 print(' %s/%s: %s' % (project, bucket, builder))
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000338 print('To see results here, run: git cl try-results')
339 print('To see results in browser, run: git cl web')
tandriide281ae2016-10-12 06:02:30 -0700340
Quinten Yearsley777660f2020-03-04 23:37:06 +0000341 requests = _make_tryjob_schedule_requests(changelist, jobs, options, patchset)
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +0000342 if not requests:
343 return
344
Edward Lemur5b929a42019-10-21 17:57:39 +0000345 http = auth.Authenticator().authorize(httplib2.Http())
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +0000346 http.force_exception_to_status_code = True
347
348 batch_request = {'requests': requests}
349 batch_response = _call_buildbucket(
350 http, options.buildbucket_host, 'Batch', batch_request)
351
352 errors = [
353 ' ' + response['error']['message']
354 for response in batch_response.get('responses', [])
355 if 'error' in response
356 ]
357 if errors:
358 raise BuildbucketResponseException(
359 'Failed to schedule builds for some bots:\n%s' % '\n'.join(errors))
360
361
Quinten Yearsley777660f2020-03-04 23:37:06 +0000362def _make_tryjob_schedule_requests(changelist, jobs, options, patchset):
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +0000363 """Constructs requests for Buildbucket to trigger tryjobs."""
Edward Lemurf0faf482019-09-25 20:40:17 +0000364 gerrit_changes = [changelist.GetGerritChange(patchset)]
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +0000365 shared_properties = {
366 'category': options.ensure_value('category', 'git_cl_try')
367 }
368 if options.ensure_value('clobber', False):
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000369 shared_properties['clobber'] = True
370 shared_properties.update(_get_properties_from_options(options) or {})
371
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +0000372 shared_tags = [{'key': 'user_agent', 'value': 'git_cl_try'}]
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +0000373 if options.ensure_value('retry_failed', False):
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +0000374 shared_tags.append({'key': 'retry_failed',
375 'value': '1'})
376
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000377 requests = []
Edward Lemur45768512020-03-02 19:03:14 +0000378 for (project, bucket, builder) in jobs:
379 properties = shared_properties.copy()
380 if 'presubmit' in builder.lower():
381 properties['dry_run'] = 'true'
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000382
Edward Lemur45768512020-03-02 19:03:14 +0000383 requests.append({
384 'scheduleBuild': {
385 'requestId': str(uuid.uuid4()),
386 'builder': {
387 'project': getattr(options, 'project', None) or project,
388 'bucket': bucket,
389 'builder': builder,
390 },
391 'gerritChanges': gerrit_changes,
392 'properties': properties,
393 'tags': [
394 {'key': 'builder', 'value': builder},
395 ] + shared_tags,
396 }
397 })
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000398
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +0000399 if options.ensure_value('revision', None):
Josip Sokcevic9011a5b2021-02-12 18:59:44 +0000400 remote, remote_branch = changelist.GetRemoteBranch()
Edward Lemur45768512020-03-02 19:03:14 +0000401 requests[-1]['scheduleBuild']['gitilesCommit'] = {
402 'host': gerrit_changes[0]['host'],
403 'project': gerrit_changes[0]['project'],
Josip Sokcevic9011a5b2021-02-12 18:59:44 +0000404 'id': options.revision,
405 'ref': GetTargetRef(remote, remote_branch, None)
Edward Lemur45768512020-03-02 19:03:14 +0000406 }
Anthony Polito1a5fe232020-01-24 23:17:52 +0000407
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +0000408 return requests
kjellander@chromium.org44424542015-06-02 18:35:29 +0000409
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000410
Quinten Yearsley777660f2020-03-04 23:37:06 +0000411def _fetch_tryjobs(changelist, buildbucket_host, patchset=None):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000412 """Fetches tryjobs from buildbucket.
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000413
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000414 Returns list of buildbucket.v2.Build with the try jobs for the changelist.
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000415 """
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +0000416 fields = ['id', 'builder', 'status', 'createTime', 'tags']
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000417 request = {
418 'predicate': {
419 'gerritChanges': [changelist.GetGerritChange(patchset)],
420 },
421 'fields': ','.join('builds.*.' + field for field in fields),
422 }
tandrii221ab252016-10-06 08:12:04 -0700423
Edward Lemur5b929a42019-10-21 17:57:39 +0000424 authenticator = auth.Authenticator()
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000425 if authenticator.has_cached_credentials():
426 http = authenticator.authorize(httplib2.Http())
427 else:
vapiera7fbd5a2016-06-16 09:17:49 -0700428 print('Warning: Some results might be missing because %s' %
429 # Get the message on how to login.
Andrii Shyshkalov2517afd2021-01-19 17:07:43 +0000430 (str(auth.LoginRequiredError()),))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000431 http = httplib2.Http()
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000432 http.force_exception_to_status_code = True
433
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000434 response = _call_buildbucket(http, buildbucket_host, 'SearchBuilds', request)
435 return response.get('builds', [])
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000436
Edward Lemur45768512020-03-02 19:03:14 +0000437
Edward Lemur5b929a42019-10-21 17:57:39 +0000438def _fetch_latest_builds(changelist, buildbucket_host, latest_patchset=None):
Quinten Yearsley983111f2019-09-26 17:18:48 +0000439 """Fetches builds from the latest patchset that has builds (within
440 the last few patchsets).
441
442 Args:
Quinten Yearsley983111f2019-09-26 17:18:48 +0000443 changelist (Changelist): The CL to fetch builds for
444 buildbucket_host (str): Buildbucket host, e.g. "cr-buildbucket.appspot.com"
Andrii Shyshkalov1ad58112019-10-08 01:46:14 +0000445 lastest_patchset(int|NoneType): the patchset to start fetching builds from.
446 If None (default), starts with the latest available patchset.
Quinten Yearsley983111f2019-09-26 17:18:48 +0000447 Returns:
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000448 A tuple (builds, patchset) where builds is a list of buildbucket.v2.Build,
449 and patchset is the patchset number where those builds came from.
Quinten Yearsley983111f2019-09-26 17:18:48 +0000450 """
451 assert buildbucket_host
452 assert changelist.GetIssue(), 'CL must be uploaded first'
453 assert changelist.GetCodereviewServer(), 'CL must be uploaded first'
Andrii Shyshkalov1ad58112019-10-08 01:46:14 +0000454 if latest_patchset is None:
455 assert changelist.GetMostRecentPatchset()
456 ps = changelist.GetMostRecentPatchset()
457 else:
458 assert latest_patchset > 0, latest_patchset
459 ps = latest_patchset
460
Quinten Yearsley983111f2019-09-26 17:18:48 +0000461 min_ps = max(1, ps - 5)
462 while ps >= min_ps:
Quinten Yearsley777660f2020-03-04 23:37:06 +0000463 builds = _fetch_tryjobs(changelist, buildbucket_host, patchset=ps)
Quinten Yearsley983111f2019-09-26 17:18:48 +0000464 if len(builds):
465 return builds, ps
466 ps -= 1
467 return [], 0
468
469
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +0000470def _filter_failed_for_retry(all_builds):
471 """Returns a list of buckets/builders that are worth retrying.
Quinten Yearsley983111f2019-09-26 17:18:48 +0000472
473 Args:
Quinten Yearsley777660f2020-03-04 23:37:06 +0000474 all_builds (list): Builds, in the format returned by _fetch_tryjobs,
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000475 i.e. a list of buildbucket.v2.Builds which includes status and builder
476 info.
Quinten Yearsley983111f2019-09-26 17:18:48 +0000477
478 Returns:
Edward Lemur45768512020-03-02 19:03:14 +0000479 A dict {(proj, bucket): [builders]}. This is the same format accepted by
Quinten Yearsley777660f2020-03-04 23:37:06 +0000480 _trigger_tryjobs.
Quinten Yearsley983111f2019-09-26 17:18:48 +0000481 """
Edward Lemur45768512020-03-02 19:03:14 +0000482 grouped = {}
483 for build in all_builds:
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +0000484 builder = build['builder']
Edward Lemur45768512020-03-02 19:03:14 +0000485 key = (builder['project'], builder['bucket'], builder['builder'])
486 grouped.setdefault(key, []).append(build)
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +0000487
Edward Lemur45768512020-03-02 19:03:14 +0000488 jobs = []
489 for (project, bucket, builder), builds in grouped.items():
490 if 'triggered' in builder:
491 print('WARNING: Not scheduling %s. Triggered bots require an initial job '
492 'from a parent. Please schedule a manual job for the parent '
493 'instead.')
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +0000494 continue
495 if any(b['status'] in ('STARTED', 'SCHEDULED') for b in builds):
496 # Don't retry if any are running.
497 continue
Edward Lemur45768512020-03-02 19:03:14 +0000498 # If builder had several builds, retry only if the last one failed.
499 # This is a bit different from CQ, which would re-use *any* SUCCESS-full
500 # build, but in case of retrying failed jobs retrying a flaky one makes
501 # sense.
502 builds = sorted(builds, key=lambda b: b['createTime'])
503 if builds[-1]['status'] not in ('FAILURE', 'INFRA_FAILURE'):
504 continue
505 # Don't retry experimental build previously triggered by CQ.
506 if any(t['key'] == 'cq_experimental' and t['value'] == 'true'
507 for t in builds[-1]['tags']):
508 continue
509 jobs.append((project, bucket, builder))
510
511 # Sort the jobs to make testing easier.
512 return sorted(jobs)
Quinten Yearsley983111f2019-09-26 17:18:48 +0000513
514
Quinten Yearsley777660f2020-03-04 23:37:06 +0000515def _print_tryjobs(options, builds):
516 """Prints nicely result of _fetch_tryjobs."""
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000517 if not builds:
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000518 print('No tryjobs scheduled.')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000519 return
520
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000521 longest_builder = max(len(b['builder']['builder']) for b in builds)
522 name_fmt = '{builder:<%d}' % longest_builder
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000523 if options.print_master:
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000524 longest_bucket = max(len(b['builder']['bucket']) for b in builds)
525 name_fmt = ('{bucket:>%d} ' % longest_bucket) + name_fmt
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000526
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000527 builds_by_status = {}
528 for b in builds:
529 builds_by_status.setdefault(b['status'], []).append({
530 'id': b['id'],
531 'name': name_fmt.format(
532 builder=b['builder']['builder'], bucket=b['builder']['bucket']),
533 })
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000534
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000535 sort_key = lambda b: (b['name'], b['id'])
536
537 def print_builds(title, builds, fmt=None, color=None):
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000538 """Pop matching builds from `builds` dict and print them."""
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000539 if not builds:
540 return
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000541
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000542 fmt = fmt or '{name} https://ci.chromium.org/b/{id}'
tandrii@chromium.org6cf98c82016-03-15 11:56:00 +0000543 if not options.color or color is None:
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000544 colorize = lambda x: x
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000545 else:
546 colorize = lambda x: '%s%s%s' % (color, x, Fore.RESET)
547
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000548 print(colorize(title))
549 for b in sorted(builds, key=sort_key):
550 print(' ', colorize(fmt.format(**b)))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000551
552 total = len(builds)
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000553 print_builds(
554 'Successes:', builds_by_status.pop('SUCCESS', []), color=Fore.GREEN)
555 print_builds(
556 'Infra Failures:', builds_by_status.pop('INFRA_FAILURE', []),
557 color=Fore.MAGENTA)
558 print_builds('Failures:', builds_by_status.pop('FAILURE', []), color=Fore.RED)
559 print_builds('Canceled:', builds_by_status.pop('CANCELED', []), fmt='{name}',
560 color=Fore.MAGENTA)
Andrii Shyshkalov792630c2020-10-19 16:47:44 +0000561 print_builds('Started:', builds_by_status.pop('STARTED', []),
562 color=Fore.YELLOW)
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000563 print_builds(
564 'Scheduled:', builds_by_status.pop('SCHEDULED', []), fmt='{name} id={id}')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000565 # The last section is just in case buildbucket API changes OR there is a bug.
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000566 print_builds(
567 'Other:', sum(builds_by_status.values(), []), fmt='{name} id={id}')
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000568 print('Total: %d tryjobs' % total)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000569
570
Aiden Bennerc08566e2018-10-03 17:52:42 +0000571def _ComputeDiffLineRanges(files, upstream_commit):
572 """Gets the changed line ranges for each file since upstream_commit.
573
574 Parses a git diff on provided files and returns a dict that maps a file name
575 to an ordered list of range tuples in the form (start_line, count).
576 Ranges are in the same format as a git diff.
577 """
578 # If files is empty then diff_output will be a full diff.
579 if len(files) == 0:
580 return {}
581
Aiden Benner6c18a1a2018-11-23 20:18:23 +0000582 # Take the git diff and find the line ranges where there are changes.
Jamie Madill3671a6a2019-10-24 15:13:21 +0000583 diff_cmd = BuildGitDiffCmd('-U0', upstream_commit, files, allow_prefix=True)
Aiden Bennerc08566e2018-10-03 17:52:42 +0000584 diff_output = RunGit(diff_cmd)
585
586 pattern = r'(?:^diff --git a/(?:.*) b/(.*))|(?:^@@.*\+(.*) @@)'
587 # 2 capture groups
588 # 0 == fname of diff file
589 # 1 == 'diff_start,diff_count' or 'diff_start'
590 # will match each of
591 # diff --git a/foo.foo b/foo.py
592 # @@ -12,2 +14,3 @@
593 # @@ -12,2 +17 @@
594 # running re.findall on the above string with pattern will give
595 # [('foo.py', ''), ('', '14,3'), ('', '17')]
596
597 curr_file = None
598 line_diffs = {}
599 for match in re.findall(pattern, diff_output, flags=re.MULTILINE):
600 if match[0] != '':
601 # Will match the second filename in diff --git a/a.py b/b.py.
602 curr_file = match[0]
603 line_diffs[curr_file] = []
604 else:
605 # Matches +14,3
606 if ',' in match[1]:
607 diff_start, diff_count = match[1].split(',')
608 else:
609 # Single line changes are of the form +12 instead of +12,1.
610 diff_start = match[1]
611 diff_count = 1
612
613 diff_start = int(diff_start)
614 diff_count = int(diff_count)
615
616 # If diff_count == 0 this is a removal we can ignore.
617 line_diffs[curr_file].append((diff_start, diff_count))
618
619 return line_diffs
620
621
Aiden Benner99b0ccb2018-11-20 19:53:31 +0000622def _FindYapfConfigFile(fpath, yapf_config_cache, top_dir=None):
Aiden Bennerc08566e2018-10-03 17:52:42 +0000623 """Checks if a yapf file is in any parent directory of fpath until top_dir.
624
Aiden Benner99b0ccb2018-11-20 19:53:31 +0000625 Recursively checks parent directories to find yapf file and if no yapf file
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000626 is found returns None. Uses yapf_config_cache as a cache for previously found
627 configs.
Aiden Bennerc08566e2018-10-03 17:52:42 +0000628 """
Aiden Benner99b0ccb2018-11-20 19:53:31 +0000629 fpath = os.path.abspath(fpath)
Aiden Bennerc08566e2018-10-03 17:52:42 +0000630 # Return result if we've already computed it.
631 if fpath in yapf_config_cache:
632 return yapf_config_cache[fpath]
633
Aiden Benner99b0ccb2018-11-20 19:53:31 +0000634 parent_dir = os.path.dirname(fpath)
635 if os.path.isfile(fpath):
636 ret = _FindYapfConfigFile(parent_dir, yapf_config_cache, top_dir)
Aiden Bennerc08566e2018-10-03 17:52:42 +0000637 else:
Aiden Benner99b0ccb2018-11-20 19:53:31 +0000638 # Otherwise fpath is a directory
639 yapf_file = os.path.join(fpath, YAPF_CONFIG_FILENAME)
640 if os.path.isfile(yapf_file):
641 ret = yapf_file
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +0000642 elif fpath in (top_dir, parent_dir):
Aiden Benner99b0ccb2018-11-20 19:53:31 +0000643 # If we're at the top level directory, or if we're at root
644 # there is no provided style.
645 ret = None
646 else:
647 # Otherwise recurse on the current directory.
648 ret = _FindYapfConfigFile(parent_dir, yapf_config_cache, top_dir)
Aiden Bennerc08566e2018-10-03 17:52:42 +0000649 yapf_config_cache[fpath] = ret
650 return ret
651
652
Brian Sheedyb4307d52019-12-02 19:18:17 +0000653def _GetYapfIgnorePatterns(top_dir):
654 """Returns all patterns in the .yapfignore file.
Brian Sheedy59b06a82019-10-14 17:03:29 +0000655
656 yapf is supposed to handle the ignoring of files listed in .yapfignore itself,
657 but this functionality appears to break when explicitly passing files to
658 yapf for formatting. According to
Josip Sokcevicc39ab992020-09-24 20:09:15 +0000659 https://github.com/google/yapf/blob/HEAD/README.rst#excluding-files-from-formatting-yapfignore,
Brian Sheedy59b06a82019-10-14 17:03:29 +0000660 the .yapfignore file should be in the directory that yapf is invoked from,
661 which we assume to be the top level directory in this case.
662
663 Args:
664 top_dir: The top level directory for the repository being formatted.
665
666 Returns:
Brian Sheedyb4307d52019-12-02 19:18:17 +0000667 A set of all fnmatch patterns to be ignored.
Brian Sheedy59b06a82019-10-14 17:03:29 +0000668 """
669 yapfignore_file = os.path.join(top_dir, '.yapfignore')
Brian Sheedyb4307d52019-12-02 19:18:17 +0000670 ignore_patterns = set()
Brian Sheedy59b06a82019-10-14 17:03:29 +0000671 if not os.path.exists(yapfignore_file):
Brian Sheedyb4307d52019-12-02 19:18:17 +0000672 return ignore_patterns
Brian Sheedy59b06a82019-10-14 17:03:29 +0000673
Anthony Politoc64e3902021-04-30 21:55:25 +0000674 for line in gclient_utils.FileRead(yapfignore_file).split('\n'):
675 stripped_line = line.strip()
676 # Comments and blank lines should be ignored.
677 if stripped_line.startswith('#') or stripped_line == '':
678 continue
679 ignore_patterns.add(stripped_line)
Brian Sheedyb4307d52019-12-02 19:18:17 +0000680 return ignore_patterns
681
682
683def _FilterYapfIgnoredFiles(filepaths, patterns):
684 """Filters out any filepaths that match any of the given patterns.
685
686 Args:
687 filepaths: An iterable of strings containing filepaths to filter.
688 patterns: An iterable of strings containing fnmatch patterns to filter on.
689
690 Returns:
691 A list of strings containing all the elements of |filepaths| that did not
692 match any of the patterns in |patterns|.
693 """
694 # Not inlined so that tests can use the same implementation.
695 return [f for f in filepaths
696 if not any(fnmatch.fnmatch(f, p) for p in patterns)]
Brian Sheedy59b06a82019-10-14 17:03:29 +0000697
698
Aaron Gable13101a62018-02-09 13:20:41 -0800699def print_stats(args):
maruel@chromium.org49e3d802012-07-18 23:54:45 +0000700 """Prints statistics about the change to the user."""
701 # --no-ext-diff is broken in some versions of Git, so try to work around
702 # this by overriding the environment (but there is still a problem if the
703 # git config key "diff.external" is used).
thestig@chromium.org8b0553c2014-02-11 00:33:37 +0000704 env = GetNoGitPagerEnv()
maruel@chromium.org49e3d802012-07-18 23:54:45 +0000705 if 'GIT_EXTERNAL_DIFF' in env:
706 del env['GIT_EXTERNAL_DIFF']
iannucci@chromium.org79540052012-10-19 23:15:26 +0000707
maruel@chromium.org49e3d802012-07-18 23:54:45 +0000708 return subprocess2.call(
Aaron Gable13101a62018-02-09 13:20:41 -0800709 ['git', 'diff', '--no-ext-diff', '--stat', '-l100000', '-C50'] + args,
Edward Lemur0db01f02019-11-12 22:01:51 +0000710 env=env)
maruel@chromium.org49e3d802012-07-18 23:54:45 +0000711
712
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000713class BuildbucketResponseException(Exception):
714 pass
715
716
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000717class Settings(object):
718 def __init__(self):
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000719 self.cc = None
thestig@chromium.org7a54e812014-02-11 19:57:22 +0000720 self.root = None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000721 self.tree_status_url = None
722 self.viewvc_url = None
723 self.updated = False
ukai@chromium.orge8077812012-02-03 03:41:46 +0000724 self.is_gerrit = None
bauerb@chromium.org54b400c2016-01-14 10:08:25 +0000725 self.squash_gerrit_uploads = None
tandrii@chromium.org28253532016-04-14 13:46:56 +0000726 self.gerrit_skip_ensure_authenticated = None
jbroman@chromium.org615a2622013-05-03 13:20:14 +0000727 self.git_editor = None
Jamie Madilldc4d19e2019-10-24 21:50:02 +0000728 self.format_full_by_default = None
Sigurd Schneider1bfda8e2021-06-30 14:46:25 +0000729 self.is_status_commit_order_by_date = None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000730
Edward Lemur26964072020-02-19 19:18:51 +0000731 def _LazyUpdateIfNeeded(self):
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000732 """Updates the settings from a codereview.settings file, if available."""
Edward Lemur26964072020-02-19 19:18:51 +0000733 if self.updated:
734 return
pgervais@chromium.org87884cc2014-01-03 22:23:41 +0000735
Edward Lemur26964072020-02-19 19:18:51 +0000736 # The only value that actually changes the behavior is
737 # autoupdate = "false". Everything else means "true".
738 autoupdate = (
739 scm.GIT.GetConfig(self.GetRoot(), 'rietveld.autoupdate', '').lower())
740
741 cr_settings_file = FindCodereviewSettingsFile()
742 if autoupdate != 'false' and cr_settings_file:
743 LoadCodereviewSettingsFromFile(cr_settings_file)
744 cr_settings_file.close()
745
746 self.updated = True
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000747
thestig@chromium.org7a54e812014-02-11 19:57:22 +0000748 @staticmethod
749 def GetRelativeRoot():
Edward Lesmes50da7702020-03-30 19:23:43 +0000750 return scm.GIT.GetCheckoutRoot('.')
thestig@chromium.org8b0553c2014-02-11 00:33:37 +0000751
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000752 def GetRoot(self):
thestig@chromium.org7a54e812014-02-11 19:57:22 +0000753 if self.root is None:
754 self.root = os.path.abspath(self.GetRelativeRoot())
755 return self.root
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000756
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000757 def GetTreeStatusUrl(self, error_ok=False):
758 if not self.tree_status_url:
Edward Lemur26964072020-02-19 19:18:51 +0000759 self.tree_status_url = self._GetConfig('rietveld.tree-status-url')
760 if self.tree_status_url is None and not error_ok:
761 DieWithError(
762 'You must configure your tree status URL by running '
763 '"git cl config".')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000764 return self.tree_status_url
765
766 def GetViewVCUrl(self):
767 if not self.viewvc_url:
Edward Lemur26964072020-02-19 19:18:51 +0000768 self.viewvc_url = self._GetConfig('rietveld.viewvc-url')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000769 return self.viewvc_url
770
rmistry@google.com90752582014-01-14 21:04:50 +0000771 def GetBugPrefix(self):
Edward Lemur26964072020-02-19 19:18:51 +0000772 return self._GetConfig('rietveld.bug-prefix')
rmistry@google.com78948ed2015-07-08 23:09:57 +0000773
rmistry@google.com5626a922015-02-26 14:03:30 +0000774 def GetRunPostUploadHook(self):
Edward Lemur61ea3072018-12-01 00:34:36 +0000775 run_post_upload_hook = self._GetConfig(
Edward Lemur26964072020-02-19 19:18:51 +0000776 'rietveld.run-post-upload-hook')
rmistry@google.com5626a922015-02-26 14:03:30 +0000777 return run_post_upload_hook == "True"
778
bauerb@chromium.orgae6df352011-04-06 17:40:39 +0000779 def GetDefaultCCList(self):
Edward Lemur26964072020-02-19 19:18:51 +0000780 return self._GetConfig('rietveld.cc')
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000781
Dirk Pranke6f0df682021-06-25 00:42:33 +0000782 def GetUsePython3(self):
783 return self._GetConfig('rietveld.use-python3')
784
bauerb@chromium.org54b400c2016-01-14 10:08:25 +0000785 def GetSquashGerritUploads(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000786 """Returns True if uploads to Gerrit should be squashed by default."""
bauerb@chromium.org54b400c2016-01-14 10:08:25 +0000787 if self.squash_gerrit_uploads is None:
Edward Lesmes4de54132020-05-05 19:41:33 +0000788 self.squash_gerrit_uploads = self.GetSquashGerritUploadsOverride()
789 if self.squash_gerrit_uploads is None:
Edward Lemur26964072020-02-19 19:18:51 +0000790 # Default is squash now (http://crbug.com/611892#c23).
791 self.squash_gerrit_uploads = self._GetConfig(
792 'gerrit.squash-uploads').lower() != 'false'
bauerb@chromium.org54b400c2016-01-14 10:08:25 +0000793 return self.squash_gerrit_uploads
794
Edward Lesmes4de54132020-05-05 19:41:33 +0000795 def GetSquashGerritUploadsOverride(self):
796 """Return True or False if codereview.settings should be overridden.
797
798 Returns None if no override has been defined.
799 """
800 # See also http://crbug.com/611892#c23
801 result = self._GetConfig('gerrit.override-squash-uploads').lower()
802 if result == 'true':
803 return True
804 if result == 'false':
805 return False
806 return None
807
tandrii@chromium.org28253532016-04-14 13:46:56 +0000808 def GetGerritSkipEnsureAuthenticated(self):
809 """Return True if EnsureAuthenticated should not be done for Gerrit
810 uploads."""
811 if self.gerrit_skip_ensure_authenticated is None:
Edward Lemur26964072020-02-19 19:18:51 +0000812 self.gerrit_skip_ensure_authenticated = self._GetConfig(
813 'gerrit.skip-ensure-authenticated').lower() == 'true'
tandrii@chromium.org28253532016-04-14 13:46:56 +0000814 return self.gerrit_skip_ensure_authenticated
815
jbroman@chromium.org615a2622013-05-03 13:20:14 +0000816 def GetGitEditor(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000817 """Returns the editor specified in the git config, or None if none is."""
jbroman@chromium.org615a2622013-05-03 13:20:14 +0000818 if self.git_editor is None:
Raul Tambre5a525872019-02-12 19:08:08 +0000819 # Git requires single quotes for paths with spaces. We need to replace
820 # them with double quotes for Windows to treat such paths as a single
821 # path.
Edward Lemur26964072020-02-19 19:18:51 +0000822 self.git_editor = self._GetConfig('core.editor').replace('\'', '"')
jbroman@chromium.org615a2622013-05-03 13:20:14 +0000823 return self.git_editor or None
824
thestig@chromium.org44202a22014-03-11 19:22:18 +0000825 def GetLintRegex(self):
Edward Lemur26964072020-02-19 19:18:51 +0000826 return self._GetConfig('rietveld.cpplint-regex', DEFAULT_LINT_REGEX)
thestig@chromium.org44202a22014-03-11 19:22:18 +0000827
828 def GetLintIgnoreRegex(self):
Edward Lemur26964072020-02-19 19:18:51 +0000829 return self._GetConfig(
830 'rietveld.cpplint-ignore-regex', DEFAULT_LINT_IGNORE_REGEX)
thestig@chromium.org44202a22014-03-11 19:22:18 +0000831
Jamie Madilldc4d19e2019-10-24 21:50:02 +0000832 def GetFormatFullByDefault(self):
833 if self.format_full_by_default is None:
Jamie Madillac6f6232021-07-07 20:54:08 +0000834 self._LazyUpdateIfNeeded()
Jamie Madilldc4d19e2019-10-24 21:50:02 +0000835 result = (
836 RunGit(['config', '--bool', 'rietveld.format-full-by-default'],
837 error_ok=True).strip())
838 self.format_full_by_default = (result == 'true')
839 return self.format_full_by_default
840
Sigurd Schneider1bfda8e2021-06-30 14:46:25 +0000841 def IsStatusCommitOrderByDate(self):
842 if self.is_status_commit_order_by_date is None:
843 result = (RunGit(['config', '--bool', 'cl.date-order'],
844 error_ok=True).strip())
845 self.is_status_commit_order_by_date = (result == 'true')
846 return self.is_status_commit_order_by_date
847
Edward Lemur26964072020-02-19 19:18:51 +0000848 def _GetConfig(self, key, default=''):
849 self._LazyUpdateIfNeeded()
850 return scm.GIT.GetConfig(self.GetRoot(), key, default)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000851
852
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +0000853class _CQState(object):
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +0000854 """Enum for states of CL with respect to CQ."""
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +0000855 NONE = 'none'
Greg Gutermanbe5fccd2021-06-14 17:58:20 +0000856 QUICK_RUN = 'quick_run'
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +0000857 DRY_RUN = 'dry_run'
858 COMMIT = 'commit'
859
Greg Gutermanbe5fccd2021-06-14 17:58:20 +0000860 ALL_STATES = [NONE, QUICK_RUN, DRY_RUN, COMMIT]
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +0000861
862
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000863class _ParsedIssueNumberArgument(object):
Edward Lemurf38bc172019-09-03 21:02:13 +0000864 def __init__(self, issue=None, patchset=None, hostname=None):
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000865 self.issue = issue
866 self.patchset = patchset
867 self.hostname = hostname
868
869 @property
870 def valid(self):
871 return self.issue is not None
872
873
Edward Lemurf38bc172019-09-03 21:02:13 +0000874def ParseIssueNumberArgument(arg):
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000875 """Parses the issue argument and returns _ParsedIssueNumberArgument."""
876 fail_result = _ParsedIssueNumberArgument()
877
Edward Lemur678a6842019-10-03 22:25:05 +0000878 if isinstance(arg, int):
879 return _ParsedIssueNumberArgument(issue=arg)
880 if not isinstance(arg, basestring):
881 return fail_result
882
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000883 if arg.isdigit():
Edward Lemurf38bc172019-09-03 21:02:13 +0000884 return _ParsedIssueNumberArgument(issue=int(arg))
Aaron Gableaee6c852017-06-26 12:49:01 -0700885
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000886 url = gclient_utils.UpgradeToHttps(arg)
Alex Turner30ae6372022-01-04 02:32:52 +0000887 if not url.startswith('http'):
888 return fail_result
Andrii Shyshkalov8aebb602020-04-16 22:10:27 +0000889 for gerrit_url, short_url in _KNOWN_GERRIT_TO_SHORT_URLS.items():
890 if url.startswith(short_url):
891 url = gerrit_url + url[len(short_url):]
892 break
893
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000894 try:
Edward Lemur79d4f992019-11-11 23:49:02 +0000895 parsed_url = urllib.parse.urlparse(url)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000896 except ValueError:
897 return fail_result
Andrii Shyshkalov28d840e2017-04-10 15:45:09 +0200898
Alex Turner30ae6372022-01-04 02:32:52 +0000899 # If "https://" was automatically added, fail if `arg` looks unlikely to be a
900 # URL.
901 if not arg.startswith('http') and '.' not in parsed_url.netloc:
902 return fail_result
903
Edward Lemur678a6842019-10-03 22:25:05 +0000904 # Gerrit's new UI is https://domain/c/project/+/<issue_number>[/[patchset]]
905 # But old GWT UI is https://domain/#/c/project/+/<issue_number>[/[patchset]]
906 # Short urls like https://domain/<issue_number> can be used, but don't allow
907 # specifying the patchset (you'd 404), but we allow that here.
908 if parsed_url.path == '/':
909 part = parsed_url.fragment
910 else:
911 part = parsed_url.path
912
913 match = re.match(
914 r'(/c(/.*/\+)?)?/(?P<issue>\d+)(/(?P<patchset>\d+)?/?)?$', part)
915 if not match:
916 return fail_result
917
918 issue = int(match.group('issue'))
919 patchset = match.group('patchset')
920 return _ParsedIssueNumberArgument(
921 issue=issue,
922 patchset=int(patchset) if patchset else None,
923 hostname=parsed_url.netloc)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000924
925
Andrii Shyshkalovb07575f2018-10-16 06:16:21 +0000926def _create_description_from_log(args):
927 """Pulls out the commit log to use as a base for the CL description."""
928 log_args = []
929 if len(args) == 1 and not args[0].endswith('.'):
930 log_args = [args[0] + '..']
931 elif len(args) == 1 and args[0].endswith('...'):
932 log_args = [args[0][:-1]]
933 elif len(args) == 2:
934 log_args = [args[0] + '..' + args[1]]
935 else:
936 log_args = args[:] # Hope for the best!
Manh Nguyene3644862020-08-05 18:25:46 +0000937 return RunGit(['log', '--pretty=format:%B%n'] + log_args)
Andrii Shyshkalovb07575f2018-10-16 06:16:21 +0000938
939
Aaron Gablea45ee112016-11-22 15:14:38 -0800940class GerritChangeNotExists(Exception):
tandriic2405f52016-10-10 08:13:15 -0700941 def __init__(self, issue, url):
942 self.issue = issue
943 self.url = url
Aaron Gablea45ee112016-11-22 15:14:38 -0800944 super(GerritChangeNotExists, self).__init__()
tandriic2405f52016-10-10 08:13:15 -0700945
946 def __str__(self):
Aaron Gablea45ee112016-11-22 15:14:38 -0800947 return 'change %s at %s does not exist or you have no access to it' % (
tandriic2405f52016-10-10 08:13:15 -0700948 self.issue, self.url)
949
950
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +0100951_CommentSummary = collections.namedtuple(
Quinten Yearsley0e617c02019-02-20 00:37:03 +0000952 '_CommentSummary', ['date', 'message', 'sender', 'autogenerated',
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +0100953 # TODO(tandrii): these two aren't known in Gerrit.
954 'approval', 'disapproval'])
955
956
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000957class Changelist(object):
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +0000958 """Changelist works with one changelist in local branch.
959
tandrii@chromium.org8930b3d2016-04-13 14:47:02 +0000960 Notes:
961 * Not safe for concurrent multi-{thread,process} use.
962 * Caches values from current branch. Therefore, re-use after branch change
tandrii5d48c322016-08-18 16:19:37 -0700963 with great care.
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +0000964 """
965
Sigurd Schneider9abde8c2020-11-17 08:44:52 +0000966 def __init__(self,
967 branchref=None,
968 issue=None,
969 codereview_host=None,
970 commit_date=None):
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +0000971 """Create a new ChangeList instance.
972
Edward Lemurf38bc172019-09-03 21:02:13 +0000973 **kwargs will be passed directly to Gerrit implementation.
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +0000974 """
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000975 # Poke settings so we get the "configure your server" message if necessary.
maruel@chromium.org379d07a2011-11-30 14:58:10 +0000976 global settings
977 if not settings:
978 # Happens when git_cl.py is used as a utility library.
979 settings = Settings()
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +0000980
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000981 self.branchref = branchref
982 if self.branchref:
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +0000983 assert branchref.startswith('refs/heads/')
Edward Lemur85153282020-02-14 22:06:29 +0000984 self.branch = scm.GIT.ShortBranchName(self.branchref)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000985 else:
986 self.branch = None
Sigurd Schneider9abde8c2020-11-17 08:44:52 +0000987 self.commit_date = commit_date
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000988 self.upstream_branch = None
maruel@chromium.org1033efd2013-07-23 23:25:09 +0000989 self.lookedup_issue = False
990 self.issue = issue or None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000991 self.description = None
maruel@chromium.org1033efd2013-07-23 23:25:09 +0000992 self.lookedup_patchset = False
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000993 self.patchset = None
bauerb@chromium.orgae6df352011-04-06 17:40:39 +0000994 self.cc = None
Daniel Cheng7227d212017-11-17 08:12:37 -0800995 self.more_cc = []
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +0000996 self._remote = None
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +0000997 self._cached_remote_url = (False, None) # (is_cached, value)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +0000998
Edward Lemur125d60a2019-09-13 18:25:41 +0000999 # Lazily cached values.
1000 self._gerrit_host = None # e.g. chromium-review.googlesource.com
1001 self._gerrit_server = None # e.g. https://chromium-review.googlesource.com
Edward Lesmese1576912021-02-16 21:53:34 +00001002 self._owners_client = None
Edward Lemur125d60a2019-09-13 18:25:41 +00001003 # Map from change number (issue) to its detail cache.
1004 self._detail_cache = {}
1005
1006 if codereview_host is not None:
1007 assert not codereview_host.startswith('https://'), codereview_host
1008 self._gerrit_host = codereview_host
1009 self._gerrit_server = 'https://%s' % codereview_host
bauerb@chromium.orgae6df352011-04-06 17:40:39 +00001010
Edward Lesmese1576912021-02-16 21:53:34 +00001011 @property
1012 def owners_client(self):
1013 if self._owners_client is None:
1014 remote, remote_branch = self.GetRemoteBranch()
1015 branch = GetTargetRef(remote, remote_branch, None)
1016 self._owners_client = owners_client.GetCodeOwnersClient(
1017 root=settings.GetRoot(),
Edward Lesmes1eaaab52021-03-02 23:52:54 +00001018 upstream=self.GetCommonAncestorWithUpstream(),
Edward Lesmese1576912021-02-16 21:53:34 +00001019 host=self.GetGerritHost(),
1020 project=self.GetGerritProject(),
1021 branch=branch)
1022 return self._owners_client
1023
bauerb@chromium.orgae6df352011-04-06 17:40:39 +00001024 def GetCCList(self):
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001025 """Returns the users cc'd on this CL.
bauerb@chromium.orgae6df352011-04-06 17:40:39 +00001026
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001027 The return value is a string suitable for passing to git cl with the --cc
1028 flag.
bauerb@chromium.orgae6df352011-04-06 17:40:39 +00001029 """
1030 if self.cc is None:
tyoshino@chromium.org99918ab2013-09-30 06:17:28 +00001031 base_cc = settings.GetDefaultCCList()
Daniel Cheng7227d212017-11-17 08:12:37 -08001032 more_cc = ','.join(self.more_cc)
bauerb@chromium.orgae6df352011-04-06 17:40:39 +00001033 self.cc = ','.join(filter(None, (base_cc, more_cc))) or ''
1034 return self.cc
1035
Daniel Cheng7227d212017-11-17 08:12:37 -08001036 def ExtendCC(self, more_cc):
1037 """Extends the list of users to cc on this CL based on the changed files."""
1038 self.more_cc.extend(more_cc)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001039
Sigurd Schneider9abde8c2020-11-17 08:44:52 +00001040 def GetCommitDate(self):
1041 """Returns the commit date as provided in the constructor"""
1042 return self.commit_date
1043
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001044 def GetBranch(self):
Josip Sokcevicc39ab992020-09-24 20:09:15 +00001045 """Returns the short branch name, e.g. 'main'."""
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001046 if not self.branch:
Edward Lemur85153282020-02-14 22:06:29 +00001047 branchref = scm.GIT.GetBranchRef(settings.GetRoot())
szager@chromium.orgd62c61f2014-10-20 22:33:21 +00001048 if not branchref:
1049 return None
1050 self.branchref = branchref
Edward Lemur85153282020-02-14 22:06:29 +00001051 self.branch = scm.GIT.ShortBranchName(self.branchref)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001052 return self.branch
1053
1054 def GetBranchRef(self):
Josip Sokcevicc39ab992020-09-24 20:09:15 +00001055 """Returns the full branch name, e.g. 'refs/heads/main'."""
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001056 self.GetBranch() # Poke the lazy loader.
1057 return self.branchref
1058
Edward Lemur85153282020-02-14 22:06:29 +00001059 def _GitGetBranchConfigValue(self, key, default=None):
1060 return scm.GIT.GetBranchConfig(
1061 settings.GetRoot(), self.GetBranch(), key, default)
tandrii5d48c322016-08-18 16:19:37 -07001062
Edward Lemur85153282020-02-14 22:06:29 +00001063 def _GitSetBranchConfigValue(self, key, value):
1064 action = 'set %s to %r' % (key, value)
1065 if not value:
1066 action = 'unset %s' % key
1067 assert self.GetBranch(), 'a branch is needed to ' + action
1068 return scm.GIT.SetBranchConfig(
1069 settings.GetRoot(), self.GetBranch(), key, value)
tandrii5d48c322016-08-18 16:19:37 -07001070
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001071 @staticmethod
1072 def FetchUpstreamTuple(branch):
pgervais@chromium.orgd6617f32013-11-19 00:34:54 +00001073 """Returns a tuple containing remote and remote ref,
Josip Sokcevicc39ab992020-09-24 20:09:15 +00001074 e.g. 'origin', 'refs/heads/main'
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001075 """
Edward Lemur15a9b8c2020-02-13 00:52:30 +00001076 remote, upstream_branch = scm.GIT.FetchUpstreamTuple(
1077 settings.GetRoot(), branch)
1078 if not remote or not upstream_branch:
1079 DieWithError(
1080 'Unable to determine default branch to diff against.\n'
Josip Sokcevicb038f722021-01-06 18:28:11 +00001081 'Verify this branch is set up to track another \n'
1082 '(via the --track argument to "git checkout -b ..."). \n'
1083 'or pass complete "git diff"-style arguments if supported, like\n'
1084 ' git cl upload origin/main\n')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001085
1086 return remote, upstream_branch
1087
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00001088 def GetCommonAncestorWithUpstream(self):
pgervais@chromium.org8ba38ff2015-06-11 21:41:25 +00001089 upstream_branch = self.GetUpstreamBranch()
Edward Lesmes50da7702020-03-30 19:23:43 +00001090 if not scm.GIT.IsValidRevision(settings.GetRoot(), upstream_branch):
pgervais@chromium.org8ba38ff2015-06-11 21:41:25 +00001091 DieWithError('The upstream for the current branch (%s) does not exist '
1092 'anymore.\nPlease fix it and try again.' % self.GetBranch())
iannucci@chromium.org9e849272014-04-04 00:31:55 +00001093 return git_common.get_or_create_merge_base(self.GetBranch(),
pgervais@chromium.org8ba38ff2015-06-11 21:41:25 +00001094 upstream_branch)
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00001095
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001096 def GetUpstreamBranch(self):
1097 if self.upstream_branch is None:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001098 remote, upstream_branch = self.FetchUpstreamTuple(self.GetBranch())
Raul Tambrefe1dbe12019-05-02 04:43:57 +00001099 if remote != '.':
mmoss@chromium.orge7585452014-08-24 01:41:11 +00001100 upstream_branch = upstream_branch.replace('refs/heads/',
1101 'refs/remotes/%s/' % remote)
1102 upstream_branch = upstream_branch.replace('refs/branch-heads/',
1103 'refs/remotes/branch-heads/')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001104 self.upstream_branch = upstream_branch
1105 return self.upstream_branch
1106
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001107 def GetRemoteBranch(self):
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001108 if not self._remote:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001109 remote, branch = None, self.GetBranch()
1110 seen_branches = set()
1111 while branch not in seen_branches:
1112 seen_branches.add(branch)
1113 remote, branch = self.FetchUpstreamTuple(branch)
Edward Lemur85153282020-02-14 22:06:29 +00001114 branch = scm.GIT.ShortBranchName(branch)
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001115 if remote != '.' or branch.startswith('refs/remotes'):
1116 break
1117 else:
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001118 remotes = RunGit(['remote'], error_ok=True).split()
1119 if len(remotes) == 1:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001120 remote, = remotes
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001121 elif 'origin' in remotes:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001122 remote = 'origin'
Gavin Make6a62332020-12-04 21:57:10 +00001123 logging.warning('Could not determine which remote this change is '
1124 'associated with, so defaulting to "%s".' %
1125 self._remote)
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001126 else:
Gavin Make6a62332020-12-04 21:57:10 +00001127 logging.warning('Could not determine which remote this change is '
1128 'associated with.')
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001129 branch = 'HEAD'
1130 if branch.startswith('refs/remotes'):
1131 self._remote = (remote, branch)
mmoss@chromium.orge7585452014-08-24 01:41:11 +00001132 elif branch.startswith('refs/branch-heads/'):
1133 self._remote = (remote, branch.replace('refs/', 'refs/remotes/'))
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001134 else:
1135 self._remote = (remote, 'refs/remotes/%s/%s' % (remote, branch))
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001136 return self._remote
1137
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001138 def GetRemoteUrl(self):
1139 """Return the configured remote URL, e.g. 'git://example.org/foo.git/'.
1140
1141 Returns None if there is no remote.
1142 """
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00001143 is_cached, value = self._cached_remote_url
1144 if is_cached:
1145 return value
1146
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001147 remote, _ = self.GetRemoteBranch()
Edward Lemur26964072020-02-19 19:18:51 +00001148 url = scm.GIT.GetConfig(settings.GetRoot(), 'remote.%s.url' % remote, '')
dyen@chromium.org2a13d4f2014-06-13 00:06:37 +00001149
Edward Lemur298f2cf2019-02-22 21:40:39 +00001150 # Check if the remote url can be parsed as an URL.
Edward Lemur79d4f992019-11-11 23:49:02 +00001151 host = urllib.parse.urlparse(url).netloc
Edward Lemur298f2cf2019-02-22 21:40:39 +00001152 if host:
1153 self._cached_remote_url = (True, url)
1154 return url
1155
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001156 # If it cannot be parsed as an url, assume it is a local directory,
1157 # probably a git cache.
Edward Lemur298f2cf2019-02-22 21:40:39 +00001158 logging.warning('"%s" doesn\'t appear to point to a git host. '
1159 'Interpreting it as a local directory.', url)
1160 if not os.path.isdir(url):
1161 logging.error(
Josip906bfde2020-01-31 22:38:49 +00001162 'Remote "%(remote)s" for branch "%(branch)s" points to "%(url)s", '
1163 'but it doesn\'t exist.',
1164 {'remote': remote, 'branch': self.GetBranch(), 'url': url})
Edward Lemur298f2cf2019-02-22 21:40:39 +00001165 return None
1166
1167 cache_path = url
Edward Lemur26964072020-02-19 19:18:51 +00001168 url = scm.GIT.GetConfig(url, 'remote.%s.url' % remote, '')
Edward Lemur298f2cf2019-02-22 21:40:39 +00001169
Edward Lemur79d4f992019-11-11 23:49:02 +00001170 host = urllib.parse.urlparse(url).netloc
Edward Lemur298f2cf2019-02-22 21:40:39 +00001171 if not host:
1172 logging.error(
1173 'Remote "%(remote)s" for branch "%(branch)s" points to '
1174 '"%(cache_path)s", but it is misconfigured.\n'
1175 '"%(cache_path)s" must be a git repo and must have a remote named '
1176 '"%(remote)s" pointing to the git host.', {
1177 'remote': remote,
1178 'cache_path': cache_path,
1179 'branch': self.GetBranch()})
1180 return None
1181
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00001182 self._cached_remote_url = (True, url)
dyen@chromium.org2a13d4f2014-06-13 00:06:37 +00001183 return url
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001184
tandrii@chromium.org87985d22016-03-24 17:33:33 +00001185 def GetIssue(self):
maruel@chromium.org52424302012-08-29 15:14:30 +00001186 """Returns the issue number as a int or None if not set."""
tandrii@chromium.org87985d22016-03-24 17:33:33 +00001187 if self.issue is None and not self.lookedup_issue:
Edward Lesmes50da7702020-03-30 19:23:43 +00001188 self.issue = self._GitGetBranchConfigValue(ISSUE_CONFIG_KEY)
Edward Lemur85153282020-02-14 22:06:29 +00001189 if self.issue is not None:
1190 self.issue = int(self.issue)
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001191 self.lookedup_issue = True
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001192 return self.issue
1193
Andrii Shyshkalov1ee78cd2020-03-12 01:31:53 +00001194 def GetIssueURL(self, short=False):
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001195 """Get the URL for a particular issue."""
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001196 issue = self.GetIssue()
1197 if not issue:
dbeam@chromium.org015fd3d2013-06-18 19:02:50 +00001198 return None
Andrii Shyshkalov1ee78cd2020-03-12 01:31:53 +00001199 server = self.GetCodereviewServer()
1200 if short:
1201 server = _KNOWN_GERRIT_TO_SHORT_URLS.get(server, server)
1202 return '%s/%s' % (server, issue)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001203
Dirk Pranke6f0df682021-06-25 00:42:33 +00001204 def GetUsePython3(self):
Josip Sokcevic340edc32021-07-08 17:01:46 +00001205 return settings.GetUsePython3()
Dirk Pranke6f0df682021-06-25 00:42:33 +00001206
Edward Lemur6c6827c2020-02-06 21:15:18 +00001207 def FetchDescription(self, pretty=False):
1208 assert self.GetIssue(), 'issue is required to query Gerrit'
1209
Edward Lemur9aa1a962020-02-25 00:58:38 +00001210 if self.description is None:
Edward Lemur6c6827c2020-02-06 21:15:18 +00001211 data = self._GetChangeDetail(['CURRENT_REVISION', 'CURRENT_COMMIT'])
1212 current_rev = data['current_revision']
1213 self.description = data['revisions'][current_rev]['commit']['message']
Edward Lemur6c6827c2020-02-06 21:15:18 +00001214
1215 if not pretty:
1216 return self.description
1217
1218 # Set width to 72 columns + 2 space indent.
1219 wrapper = textwrap.TextWrapper(width=74, replace_whitespace=True)
1220 wrapper.initial_indent = wrapper.subsequent_indent = ' '
1221 lines = self.description.splitlines()
1222 return '\n'.join([wrapper.fill(line) for line in lines])
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001223
1224 def GetPatchset(self):
maruel@chromium.org52424302012-08-29 15:14:30 +00001225 """Returns the patchset number as a int or None if not set."""
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001226 if self.patchset is None and not self.lookedup_patchset:
Edward Lesmes50da7702020-03-30 19:23:43 +00001227 self.patchset = self._GitGetBranchConfigValue(PATCHSET_CONFIG_KEY)
Edward Lemur85153282020-02-14 22:06:29 +00001228 if self.patchset is not None:
1229 self.patchset = int(self.patchset)
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001230 self.lookedup_patchset = True
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001231 return self.patchset
1232
Edward Lemur9aa1a962020-02-25 00:58:38 +00001233 def GetAuthor(self):
1234 return scm.GIT.GetConfig(settings.GetRoot(), 'user.email')
1235
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001236 def SetPatchset(self, patchset):
tandrii5d48c322016-08-18 16:19:37 -07001237 """Set this branch's patchset. If patchset=0, clears the patchset."""
1238 assert self.GetBranch()
1239 if not patchset:
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001240 self.patchset = None
tandrii5d48c322016-08-18 16:19:37 -07001241 else:
1242 self.patchset = int(patchset)
Edward Lesmes50da7702020-03-30 19:23:43 +00001243 self._GitSetBranchConfigValue(PATCHSET_CONFIG_KEY, str(self.patchset))
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001244
tandrii@chromium.orga342c922016-03-16 07:08:25 +00001245 def SetIssue(self, issue=None):
tandrii5d48c322016-08-18 16:19:37 -07001246 """Set this branch's issue. If issue isn't given, clears the issue."""
1247 assert self.GetBranch()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001248 if issue:
tandrii5d48c322016-08-18 16:19:37 -07001249 issue = int(issue)
Edward Lesmes50da7702020-03-30 19:23:43 +00001250 self._GitSetBranchConfigValue(ISSUE_CONFIG_KEY, str(issue))
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001251 self.issue = issue
Edward Lemur125d60a2019-09-13 18:25:41 +00001252 codereview_server = self.GetCodereviewServer()
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001253 if codereview_server:
tandrii5d48c322016-08-18 16:19:37 -07001254 self._GitSetBranchConfigValue(
Edward Lesmes50da7702020-03-30 19:23:43 +00001255 CODEREVIEW_SERVER_CONFIG_KEY, codereview_server)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001256 else:
tandrii5d48c322016-08-18 16:19:37 -07001257 # Reset all of these just to be clean.
1258 reset_suffixes = [
1259 'last-upload-hash',
Edward Lesmes50da7702020-03-30 19:23:43 +00001260 ISSUE_CONFIG_KEY,
1261 PATCHSET_CONFIG_KEY,
1262 CODEREVIEW_SERVER_CONFIG_KEY,
1263 'gerritsquashhash',
1264 ]
tandrii5d48c322016-08-18 16:19:37 -07001265 for prop in reset_suffixes:
Edward Lemur85153282020-02-14 22:06:29 +00001266 try:
1267 self._GitSetBranchConfigValue(prop, None)
1268 except subprocess2.CalledProcessError:
1269 pass
Aaron Gableca01e2c2017-07-19 11:16:02 -07001270 msg = RunGit(['log', '-1', '--format=%B']).strip()
1271 if msg and git_footers.get_footer_change_id(msg):
1272 print('WARNING: The change patched into this branch has a Change-Id. '
1273 'Removing it.')
1274 RunGit(['commit', '--amend', '-m',
1275 git_footers.remove_footer(msg, 'Change-Id')])
Edward Lemurf38bc172019-09-03 21:02:13 +00001276 self.lookedup_issue = True
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001277 self.issue = None
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00001278 self.patchset = None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001279
Edward Lemur2c62b332020-03-12 22:12:33 +00001280 def GetAffectedFiles(self, upstream):
maruel@chromium.org2b38e9c2011-10-19 00:04:35 +00001281 try:
Edward Lemur2c62b332020-03-12 22:12:33 +00001282 return [f for _, f in scm.GIT.CaptureStatus(settings.GetRoot(), upstream)]
maruel@chromium.org2b38e9c2011-10-19 00:04:35 +00001283 except subprocess2.CalledProcessError:
1284 DieWithError(
pgervais@chromium.orgd6617f32013-11-19 00:34:54 +00001285 ('\nFailed to diff against upstream branch %s\n\n'
maruel@chromium.org2b38e9c2011-10-19 00:04:35 +00001286 'This branch probably doesn\'t exist anymore. To reset the\n'
1287 'tracking branch, please run\n'
Josip Sokcevicc39ab992020-09-24 20:09:15 +00001288 ' git branch --set-upstream-to origin/main %s\n'
1289 'or replace origin/main with the relevant branch') %
Edward Lemur2c62b332020-03-12 22:12:33 +00001290 (upstream, self.GetBranch()))
bauerb@chromium.org6fb99c62011-04-18 15:57:28 +00001291
dsansomee2d6fd92016-09-08 00:10:47 -07001292 def UpdateDescription(self, description, force=False):
Edward Lemur6c6827c2020-02-06 21:15:18 +00001293 assert self.GetIssue(), 'issue is required to update description'
1294
1295 if gerrit_util.HasPendingChangeEdit(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001296 self.GetGerritHost(), self._GerritChangeIdentifier()):
Edward Lemur6c6827c2020-02-06 21:15:18 +00001297 if not force:
1298 confirm_or_exit(
1299 'The description cannot be modified while the issue has a pending '
1300 'unpublished edit. Either publish the edit in the Gerrit web UI '
1301 'or delete it.\n\n', action='delete the unpublished edit')
1302
1303 gerrit_util.DeletePendingChangeEdit(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001304 self.GetGerritHost(), self._GerritChangeIdentifier())
Edward Lemur6c6827c2020-02-06 21:15:18 +00001305 gerrit_util.SetCommitMessage(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001306 self.GetGerritHost(), self._GerritChangeIdentifier(),
Edward Lemur6c6827c2020-02-06 21:15:18 +00001307 description, notify='NONE')
1308
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001309 self.description = description
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001310
Edward Lemur75526302020-02-27 22:31:05 +00001311 def _GetCommonPresubmitArgs(self, verbose, upstream):
Edward Lemur227d5102020-02-25 23:45:35 +00001312 args = [
Edward Lemur227d5102020-02-25 23:45:35 +00001313 '--root', settings.GetRoot(),
1314 '--upstream', upstream,
1315 ]
1316
1317 args.extend(['--verbose'] * verbose)
1318
Edward Lesmeseb1bd622021-03-01 19:54:07 +00001319 remote, remote_branch = self.GetRemoteBranch()
1320 target_ref = GetTargetRef(remote, remote_branch, None)
1321 args.extend(['--gerrit_url', self.GetCodereviewServer()])
1322 args.extend(['--gerrit_project', self.GetGerritProject()])
1323 args.extend(['--gerrit_branch', target_ref])
1324
Edward Lemur99df04e2020-03-05 19:39:43 +00001325 author = self.GetAuthor()
Edward Lemur227d5102020-02-25 23:45:35 +00001326 issue = self.GetIssue()
1327 patchset = self.GetPatchset()
Edward Lemur99df04e2020-03-05 19:39:43 +00001328 if author:
1329 args.extend(['--author', author])
Edward Lemur227d5102020-02-25 23:45:35 +00001330 if issue:
1331 args.extend(['--issue', str(issue)])
1332 if patchset:
1333 args.extend(['--patchset', str(patchset)])
Edward Lemur227d5102020-02-25 23:45:35 +00001334
Edward Lemur75526302020-02-27 22:31:05 +00001335 return args
1336
Josip Sokcevic017544d2022-03-31 23:47:53 +00001337 def RunHook(self,
1338 committing,
1339 may_prompt,
1340 verbose,
1341 parallel,
1342 upstream,
1343 description,
1344 all_files,
1345 files=None,
1346 resultdb=False,
1347 realm=None):
Edward Lemur75526302020-02-27 22:31:05 +00001348 """Calls sys.exit() if the hook fails; returns a HookResults otherwise."""
1349 args = self._GetCommonPresubmitArgs(verbose, upstream)
1350 args.append('--commit' if committing else '--upload')
Edward Lemur227d5102020-02-25 23:45:35 +00001351 if may_prompt:
1352 args.append('--may_prompt')
1353 if parallel:
1354 args.append('--parallel')
1355 if all_files:
1356 args.append('--all_files')
Josip Sokcevic017544d2022-03-31 23:47:53 +00001357 if files:
1358 args.extend(files.split(';'))
1359 args.append('--source_controlled_only')
Edward Lemur227d5102020-02-25 23:45:35 +00001360
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001361 if resultdb and not realm:
1362 # TODO (crbug.com/1113463): store realm somewhere and look it up so
1363 # it is not required to pass the realm flag
1364 print('Note: ResultDB reporting will NOT be performed because --realm'
1365 ' was not specified. To enable ResultDB, please run the command'
1366 ' again with the --realm argument to specify the LUCI realm.')
1367
1368 py2_results = self._RunPresubmit(args, resultdb, realm, description,
1369 use_python3=False)
1370 py3_results = self._RunPresubmit(args, resultdb, realm, description,
1371 use_python3=True)
1372 return self._MergePresubmitResults(py2_results, py3_results)
1373
1374 def _RunPresubmit(self, args, resultdb, realm, description, use_python3):
1375 args = args[:]
1376 vpython = 'vpython3' if use_python3 else 'vpython'
1377
Edward Lemur227d5102020-02-25 23:45:35 +00001378 with gclient_utils.temporary_file() as description_file:
1379 with gclient_utils.temporary_file() as json_output:
Edward Lemur1a83da12020-03-04 21:18:36 +00001380 gclient_utils.FileWrite(description_file, description)
Edward Lemur227d5102020-02-25 23:45:35 +00001381 args.extend(['--json_output', json_output])
1382 args.extend(['--description_file', description_file])
Dirk Pranke6f0df682021-06-25 00:42:33 +00001383 if self.GetUsePython3():
1384 args.append('--use-python3')
Edward Lemur227d5102020-02-25 23:45:35 +00001385 start = time_time()
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001386 cmd = [vpython, PRESUBMIT_SUPPORT] + args
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001387 if resultdb and realm:
1388 cmd = ['rdb', 'stream', '-new', '-realm', realm, '--'] + cmd
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00001389
1390 p = subprocess2.Popen(cmd)
Edward Lemur227d5102020-02-25 23:45:35 +00001391 exit_code = p.wait()
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00001392
Edward Lemur227d5102020-02-25 23:45:35 +00001393 metrics.collector.add_repeated('sub_commands', {
1394 'command': 'presubmit',
1395 'execution_time': time_time() - start,
1396 'exit_code': exit_code,
1397 })
1398
1399 if exit_code:
1400 sys.exit(exit_code)
1401
1402 json_results = gclient_utils.FileRead(json_output)
1403 return json.loads(json_results)
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001404
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001405 def _MergePresubmitResults(self, py2_results, py3_results):
1406 return {
1407 'more_cc': sorted(set(py2_results.get('more_cc', []) +
1408 py3_results.get('more_cc', []))),
1409 'errors': (
1410 py2_results.get('errors', []) + py3_results.get('errors', [])),
1411 'notifications': (
1412 py2_results.get('notifications', []) +
1413 py3_results.get('notifications', [])),
1414 'warnings': (
1415 py2_results.get('warnings', []) + py3_results.get('warnings', []))
1416 }
1417
Edward Lemur75526302020-02-27 22:31:05 +00001418 def RunPostUploadHook(self, verbose, upstream, description):
1419 args = self._GetCommonPresubmitArgs(verbose, upstream)
1420 args.append('--post_upload')
1421
1422 with gclient_utils.temporary_file() as description_file:
Edward Lemur1a83da12020-03-04 21:18:36 +00001423 gclient_utils.FileWrite(description_file, description)
Edward Lemur75526302020-02-27 22:31:05 +00001424 args.extend(['--description_file', description_file])
Josip Sokcevice293d3d2022-02-16 22:52:15 +00001425 p_py2 = subprocess2.Popen(['vpython', PRESUBMIT_SUPPORT] + args)
1426 p_py3 = subprocess2.Popen(['vpython3', PRESUBMIT_SUPPORT] + args +
1427 ['--use-python3'])
1428 p_py2.wait()
1429 p_py3.wait()
Edward Lemur75526302020-02-27 22:31:05 +00001430
Edward Lemur5a644f82020-03-18 16:44:57 +00001431 def _GetDescriptionForUpload(self, options, git_diff_args, files):
1432 # Get description message for upload.
1433 if self.GetIssue():
1434 description = self.FetchDescription()
1435 elif options.message:
1436 description = options.message
1437 else:
1438 description = _create_description_from_log(git_diff_args)
1439 if options.title and options.squash:
Edward Lesmes0dd54822020-03-26 18:24:25 +00001440 description = options.title + '\n\n' + description
Edward Lemur5a644f82020-03-18 16:44:57 +00001441
Edward Lemur5a644f82020-03-18 16:44:57 +00001442 bug = options.bug
1443 fixed = options.fixed
Josip Sokcevic340edc32021-07-08 17:01:46 +00001444 if not self.GetIssue():
1445 # Extract bug number from branch name, but only if issue is being created.
1446 # It must start with bug or fix, followed by _ or - and number.
1447 # Optionally, it may contain _ or - after number with arbitrary text.
1448 # Examples:
1449 # bug-123
1450 # bug_123
1451 # fix-123
1452 # fix-123-some-description
1453 match = re.match(
1454 r'^(?P<type>bug|fix(?:e[sd])?)[_-]?(?P<bugnum>\d+)([-_]|$)',
1455 self.GetBranch())
1456 if not bug and not fixed and match:
1457 if match.group('type') == 'bug':
1458 bug = match.group('bugnum')
1459 else:
1460 fixed = match.group('bugnum')
Edward Lemur5a644f82020-03-18 16:44:57 +00001461
1462 change_description = ChangeDescription(description, bug, fixed)
1463
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001464 # Fill gaps in OWNERS coverage to tbrs/reviewers if requested.
1465 if options.add_owners_to:
1466 assert options.add_owners_to in ('TBR', 'R'), options.add_owners_to
Edward Lesmese1576912021-02-16 21:53:34 +00001467 status = self.owners_client.GetFilesApprovalStatus(
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001468 files, [], options.tbrs + options.reviewers)
1469 missing_files = [
1470 f for f in files
Edward Lesmese1576912021-02-16 21:53:34 +00001471 if status[f] == self._owners_client.INSUFFICIENT_REVIEWERS
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001472 ]
Edward Lesmese1576912021-02-16 21:53:34 +00001473 owners = self.owners_client.SuggestOwners(
1474 missing_files, exclude=[self.GetAuthor()])
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001475 if options.add_owners_to == 'TBR':
1476 assert isinstance(options.tbrs, list), options.tbrs
1477 options.tbrs.extend(owners)
1478 else:
1479 assert isinstance(options.reviewers, list), options.reviewers
1480 options.reviewers.extend(owners)
1481
Edward Lemur5a644f82020-03-18 16:44:57 +00001482 # Set the reviewer list now so that presubmit checks can access it.
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001483 if options.reviewers or options.tbrs:
1484 change_description.update_reviewers(options.reviewers, options.tbrs)
Edward Lemur5a644f82020-03-18 16:44:57 +00001485
1486 return change_description
1487
1488 def _GetTitleForUpload(self, options):
1489 # When not squashing, just return options.title.
1490 if not options.squash:
1491 return options.title
1492
1493 # On first upload, patchset title is always this string, while options.title
1494 # gets converted to first line of message.
1495 if not self.GetIssue():
1496 return 'Initial upload'
1497
1498 # When uploading subsequent patchsets, options.message is taken as the title
1499 # if options.title is not provided.
1500 if options.title:
1501 return options.title
1502 if options.message:
1503 return options.message.strip()
1504
1505 # Use the subject of the last commit as title by default.
Edward Lesmes50da7702020-03-30 19:23:43 +00001506 title = RunGit(['show', '-s', '--format=%s', 'HEAD']).strip()
Mario Bianuccicebfb4e2020-07-22 23:08:16 +00001507 if options.force or options.skip_title:
Edward Lemur5a644f82020-03-18 16:44:57 +00001508 return title
Edward Lesmesae3586b2020-03-23 21:21:14 +00001509 user_title = gclient_utils.AskForData('Title for patchset [%s]: ' % title)
mlcui3da91712021-05-05 10:00:30 +00001510
1511 # Use the default title if the user confirms the default with a 'y'.
1512 if user_title.lower() == 'y':
1513 return title
Edward Lesmesae3586b2020-03-23 21:21:14 +00001514 return user_title or title
Edward Lemur5a644f82020-03-18 16:44:57 +00001515
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001516 def CMDUpload(self, options, git_diff_args, orig_args):
1517 """Uploads a change to codereview."""
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001518 custom_cl_base = None
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001519 if git_diff_args:
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001520 custom_cl_base = base_branch = git_diff_args[0]
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001521 else:
1522 if self.GetBranch() is None:
1523 DieWithError('Can\'t upload from detached HEAD state. Get on a branch!')
1524
1525 # Default to diffing against common ancestor of upstream branch
1526 base_branch = self.GetCommonAncestorWithUpstream()
1527 git_diff_args = [base_branch, 'HEAD']
1528
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001529 # Fast best-effort checks to abort before running potentially expensive
1530 # hooks if uploading is likely to fail anyway. Passing these checks does
1531 # not guarantee that uploading will not fail.
Edward Lemur125d60a2019-09-13 18:25:41 +00001532 self.EnsureAuthenticated(force=options.force)
1533 self.EnsureCanUploadPatchset(force=options.force)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001534
1535 # Apply watchlists on upload.
Edward Lemur2c62b332020-03-12 22:12:33 +00001536 watchlist = watchlists.Watchlists(settings.GetRoot())
1537 files = self.GetAffectedFiles(base_branch)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001538 if not options.bypass_watchlists:
Daniel Cheng7227d212017-11-17 08:12:37 -08001539 self.ExtendCC(watchlist.GetWatchersForPaths(files))
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001540
Edward Lemur5a644f82020-03-18 16:44:57 +00001541 change_desc = self._GetDescriptionForUpload(options, git_diff_args, files)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001542 if not options.bypass_hooks:
Edward Lemur2c62b332020-03-12 22:12:33 +00001543 hook_results = self.RunHook(
1544 committing=False,
1545 may_prompt=not options.force,
1546 verbose=options.verbose,
1547 parallel=options.parallel,
1548 upstream=base_branch,
Edward Lemur5a644f82020-03-18 16:44:57 +00001549 description=change_desc.description,
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00001550 all_files=False,
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001551 resultdb=options.resultdb,
1552 realm=options.realm)
Edward Lemur227d5102020-02-25 23:45:35 +00001553 self.ExtendCC(hook_results['more_cc'])
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001554
Aaron Gable13101a62018-02-09 13:20:41 -08001555 print_stats(git_diff_args)
Edward Lemura12175c2020-03-09 16:58:26 +00001556 ret = self.CMDUploadChange(
Edward Lemur5a644f82020-03-18 16:44:57 +00001557 options, git_diff_args, custom_cl_base, change_desc)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001558 if not ret:
Edward Lemur85153282020-02-14 22:06:29 +00001559 self._GitSetBranchConfigValue(
Edward Lesmes50da7702020-03-30 19:23:43 +00001560 'last-upload-hash', scm.GIT.ResolveCommit(settings.GetRoot(), 'HEAD'))
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001561 # Run post upload hooks, if specified.
1562 if settings.GetRunPostUploadHook():
Edward Lemur5a644f82020-03-18 16:44:57 +00001563 self.RunPostUploadHook(
1564 options.verbose, base_branch, change_desc.description)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001565
1566 # Upload all dependencies if specified.
1567 if options.dependencies:
vapiera7fbd5a2016-06-16 09:17:49 -07001568 print()
1569 print('--dependencies has been specified.')
1570 print('All dependent local branches will be re-uploaded.')
1571 print()
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001572 # Remove the dependencies flag from args so that we do not end up in a
1573 # loop.
1574 orig_args.remove('--dependencies')
Jose Lopes3863fc52020-04-07 17:00:25 +00001575 ret = upload_branch_deps(self, orig_args, options.force)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001576 return ret
1577
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001578 def SetCQState(self, new_state):
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07001579 """Updates the CQ state for the latest patchset.
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001580
Greg Gutermanbe5fccd2021-06-14 17:58:20 +00001581 Issue must have been already uploaded and known. Optionally allows for
1582 updating Quick-Run (QR) state.
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001583 """
1584 assert new_state in _CQState.ALL_STATES
1585 assert self.GetIssue()
qyearsley1fdfcb62016-10-24 13:22:03 -07001586 try:
Edward Lemur125d60a2019-09-13 18:25:41 +00001587 vote_map = {
1588 _CQState.NONE: 0,
Greg Gutermanbe5fccd2021-06-14 17:58:20 +00001589 _CQState.QUICK_RUN: 1,
Edward Lemur125d60a2019-09-13 18:25:41 +00001590 _CQState.DRY_RUN: 1,
1591 _CQState.COMMIT: 2,
1592 }
Greg Gutermanbe5fccd2021-06-14 17:58:20 +00001593 if new_state == _CQState.QUICK_RUN:
1594 labels = {
1595 'Commit-Queue': vote_map[_CQState.DRY_RUN],
1596 'Quick-Run': vote_map[_CQState.QUICK_RUN],
1597 }
1598 else:
1599 labels = {'Commit-Queue': vote_map[new_state]}
Edward Lemur125d60a2019-09-13 18:25:41 +00001600 notify = False if new_state == _CQState.DRY_RUN else None
1601 gerrit_util.SetReview(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001602 self.GetGerritHost(), self._GerritChangeIdentifier(),
Edward Lemur125d60a2019-09-13 18:25:41 +00001603 labels=labels, notify=notify)
qyearsley1fdfcb62016-10-24 13:22:03 -07001604 return 0
1605 except KeyboardInterrupt:
1606 raise
1607 except:
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07001608 print('WARNING: Failed to %s.\n'
qyearsley1fdfcb62016-10-24 13:22:03 -07001609 'Either:\n'
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07001610 ' * Your project has no CQ,\n'
1611 ' * You don\'t have permission to change the CQ state,\n'
1612 ' * There\'s a bug in this code (see stack trace below).\n'
1613 'Consider specifying which bots to trigger manually or asking your '
1614 'project owners for permissions or contacting Chrome Infra at:\n'
1615 'https://www.chromium.org/infra\n\n' %
1616 ('cancel CQ' if new_state == _CQState.NONE else 'trigger CQ'))
qyearsley1fdfcb62016-10-24 13:22:03 -07001617 # Still raise exception so that stack trace is printed.
1618 raise
1619
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001620 def GetGerritHost(self):
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001621 # Lazy load of configs.
1622 self.GetCodereviewServer()
tandriie32e3ea2016-06-22 02:52:48 -07001623 if self._gerrit_host and '.' not in self._gerrit_host:
1624 # Abbreviated domain like "chromium" instead of chromium.googlesource.com.
1625 # This happens for internal stuff http://crbug.com/614312.
Edward Lemur79d4f992019-11-11 23:49:02 +00001626 parsed = urllib.parse.urlparse(self.GetRemoteUrl())
tandriie32e3ea2016-06-22 02:52:48 -07001627 if parsed.scheme == 'sso':
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001628 print('WARNING: using non-https URLs for remote is likely broken\n'
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001629 ' Your current remote is: %s' % self.GetRemoteUrl())
tandriie32e3ea2016-06-22 02:52:48 -07001630 self._gerrit_host = '%s.googlesource.com' % self._gerrit_host
1631 self._gerrit_server = 'https://%s' % self._gerrit_host
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001632 return self._gerrit_host
1633
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001634 def _GetGitHost(self):
1635 """Returns git host to be used when uploading change to Gerrit."""
Edward Lemur298f2cf2019-02-22 21:40:39 +00001636 remote_url = self.GetRemoteUrl()
1637 if not remote_url:
1638 return None
Edward Lemur79d4f992019-11-11 23:49:02 +00001639 return urllib.parse.urlparse(remote_url).netloc
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001640
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001641 def GetCodereviewServer(self):
1642 if not self._gerrit_server:
1643 # If we're on a branch then get the server potentially associated
1644 # with that branch.
Edward Lemur85153282020-02-14 22:06:29 +00001645 if self.GetIssue() and self.GetBranch():
tandrii5d48c322016-08-18 16:19:37 -07001646 self._gerrit_server = self._GitGetBranchConfigValue(
Edward Lesmes50da7702020-03-30 19:23:43 +00001647 CODEREVIEW_SERVER_CONFIG_KEY)
tandrii5d48c322016-08-18 16:19:37 -07001648 if self._gerrit_server:
Edward Lemur79d4f992019-11-11 23:49:02 +00001649 self._gerrit_host = urllib.parse.urlparse(self._gerrit_server).netloc
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001650 if not self._gerrit_server:
1651 # We assume repo to be hosted on Gerrit, and hence Gerrit server
1652 # has "-review" suffix for lowest level subdomain.
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001653 parts = self._GetGitHost().split('.')
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001654 parts[0] = parts[0] + '-review'
1655 self._gerrit_host = '.'.join(parts)
1656 self._gerrit_server = 'https://%s' % self._gerrit_host
1657 return self._gerrit_server
1658
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001659 def GetGerritProject(self):
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001660 """Returns Gerrit project name based on remote git URL."""
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00001661 remote_url = self.GetRemoteUrl()
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001662 if remote_url is None:
Josip906bfde2020-01-31 22:38:49 +00001663 logging.warning('can\'t detect Gerrit project.')
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00001664 return None
Edward Lemur79d4f992019-11-11 23:49:02 +00001665 project = urllib.parse.urlparse(remote_url).path.strip('/')
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001666 if project.endswith('.git'):
1667 project = project[:-len('.git')]
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00001668 # *.googlesource.com hosts ensure that Git/Gerrit projects don't start with
1669 # 'a/' prefix, because 'a/' prefix is used to force authentication in
1670 # gitiles/git-over-https protocol. E.g.,
1671 # https://chromium.googlesource.com/a/v8/v8 refers to the same repo/project
1672 # as
1673 # https://chromium.googlesource.com/v8/v8
1674 if project.startswith('a/'):
1675 project = project[len('a/'):]
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001676 return project
1677
Andrii Shyshkalovd06cc782018-08-23 17:24:19 +00001678 def _GerritChangeIdentifier(self):
1679 """Handy method for gerrit_util.ChangeIdentifier for a given CL.
1680
1681 Not to be confused by value of "Change-Id:" footer.
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00001682 If Gerrit project can be determined, this will speed up Gerrit HTTP API RPC.
Andrii Shyshkalovd06cc782018-08-23 17:24:19 +00001683 """
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001684 project = self.GetGerritProject()
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00001685 if project:
1686 return gerrit_util.ChangeIdentifier(project, self.GetIssue())
1687 # Fall back on still unique, but less efficient change number.
1688 return str(self.GetIssue())
Andrii Shyshkalovd06cc782018-08-23 17:24:19 +00001689
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01001690 def EnsureAuthenticated(self, force, refresh=None):
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001691 """Best effort check that user is authenticated with Gerrit server."""
tandrii@chromium.org28253532016-04-14 13:46:56 +00001692 if settings.GetGerritSkipEnsureAuthenticated():
1693 # For projects with unusual authentication schemes.
1694 # See http://crbug.com/603378.
1695 return
Vadim Shtayurab250ec12018-10-04 00:21:08 +00001696
1697 # Check presence of cookies only if using cookies-based auth method.
1698 cookie_auth = gerrit_util.Authenticator.get()
1699 if not isinstance(cookie_auth, gerrit_util.CookiesAuthenticator):
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001700 return
Vadim Shtayurab250ec12018-10-04 00:21:08 +00001701
Florian Mayerae510e82020-01-30 21:04:48 +00001702 remote_url = self.GetRemoteUrl()
1703 if remote_url is None:
Josip906bfde2020-01-31 22:38:49 +00001704 logging.warning('invalid remote')
Florian Mayerae510e82020-01-30 21:04:48 +00001705 return
1706 if urllib.parse.urlparse(remote_url).scheme != 'https':
Josip906bfde2020-01-31 22:38:49 +00001707 logging.warning('Ignoring branch %(branch)s with non-https remote '
1708 '%(remote)s', {
1709 'branch': self.branch,
1710 'remote': self.GetRemoteUrl()
1711 })
Daniel Chengcf6269b2019-05-18 01:02:12 +00001712 return
1713
Vadim Shtayurab250ec12018-10-04 00:21:08 +00001714 # Lazy-loader to identify Gerrit and Git hosts.
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001715 self.GetCodereviewServer()
1716 git_host = self._GetGitHost()
Edward Lemur298f2cf2019-02-22 21:40:39 +00001717 assert self._gerrit_server and self._gerrit_host and git_host
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001718
1719 gerrit_auth = cookie_auth.get_auth_header(self._gerrit_host)
1720 git_auth = cookie_auth.get_auth_header(git_host)
1721 if gerrit_auth and git_auth:
1722 if gerrit_auth == git_auth:
1723 return
Andrii Shyshkalov354e1d22017-06-09 19:31:33 +02001724 all_gsrc = cookie_auth.get_auth_header('d0esN0tEx1st.googlesource.com')
Raul Tambre80ee78e2019-05-06 22:41:05 +00001725 print(
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001726 'WARNING: You have different credentials for Gerrit and git hosts:\n'
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001727 ' %s\n'
1728 ' %s\n'
Andrii Shyshkalov51acef92017-04-11 17:19:59 +02001729 ' Consider running the following command:\n'
1730 ' git cl creds-check\n'
Andrii Shyshkalov354e1d22017-06-09 19:31:33 +02001731 ' %s\n'
Raul Tambre80ee78e2019-05-06 22:41:05 +00001732 ' %s' %
Andrii Shyshkalov51acef92017-04-11 17:19:59 +02001733 (git_host, self._gerrit_host,
Andrii Shyshkalov354e1d22017-06-09 19:31:33 +02001734 ('Hint: delete creds for .googlesource.com' if all_gsrc else ''),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001735 cookie_auth.get_new_password_message(git_host)))
1736 if not force:
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01001737 confirm_or_exit('If you know what you are doing', action='continue')
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001738 return
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +00001739
1740 missing = (
1741 ([] if gerrit_auth else [self._gerrit_host]) +
1742 ([] if git_auth else [git_host]))
1743 DieWithError('Credentials for the following hosts are required:\n'
1744 ' %s\n'
1745 'These are read from %s (or legacy %s)\n'
1746 '%s' % (
1747 '\n '.join(missing),
1748 cookie_auth.get_gitcookies_path(),
1749 cookie_auth.get_netrc_path(),
1750 cookie_auth.get_new_password_message(git_host)))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001751
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001752 def EnsureCanUploadPatchset(self, force):
Andrii Shyshkalov3e631422017-02-16 17:46:44 +01001753 if not self.GetIssue():
1754 return
1755
Andrii Shyshkalov3e631422017-02-16 17:46:44 +01001756 status = self._GetChangeDetail()['status']
1757 if status in ('MERGED', 'ABANDONED'):
1758 DieWithError('Change %s has been %s, new uploads are not allowed' %
1759 (self.GetIssueURL(),
1760 'submitted' if status == 'MERGED' else 'abandoned'))
1761
Vadim Shtayurab250ec12018-10-04 00:21:08 +00001762 # TODO(vadimsh): For some reason the chunk of code below was skipped if
1763 # 'is_gce' is True. I'm just refactoring it to be 'skip if not cookies'.
1764 # Apparently this check is not very important? Otherwise get_auth_email
1765 # could have been added to other implementations of Authenticator.
1766 cookies_auth = gerrit_util.Authenticator.get()
1767 if not isinstance(cookies_auth, gerrit_util.CookiesAuthenticator):
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001768 return
Vadim Shtayurab250ec12018-10-04 00:21:08 +00001769
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001770 cookies_user = cookies_auth.get_auth_email(self.GetGerritHost())
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001771 if self.GetIssueOwner() == cookies_user:
1772 return
1773 logging.debug('change %s owner is %s, cookies user is %s',
1774 self.GetIssue(), self.GetIssueOwner(), cookies_user)
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001775 # Maybe user has linked accounts or something like that,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001776 # so ask what Gerrit thinks of this user.
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001777 details = gerrit_util.GetAccountDetails(self.GetGerritHost(), 'self')
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001778 if details['email'] == self.GetIssueOwner():
1779 return
1780 if not force:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001781 print('WARNING: Change %s is owned by %s, but you authenticate to Gerrit '
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001782 'as %s.\n'
1783 'Uploading may fail due to lack of permissions.' %
1784 (self.GetIssue(), self.GetIssueOwner(), details['email']))
1785 confirm_or_exit(action='upload')
1786
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001787 def GetStatus(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001788 """Applies a rough heuristic to give a simple summary of an issue's review
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001789 or CQ status, assuming adherence to a common workflow.
1790
1791 Returns None if no issue for this branch, or one of the following keywords:
Aaron Gable9ab38c62017-04-06 14:36:33 -07001792 * 'error' - error from review tool (including deleted issues)
1793 * 'unsent' - no reviewers added
1794 * 'waiting' - waiting for review
1795 * 'reply' - waiting for uploader to reply to review
1796 * 'lgtm' - Code-Review label has been set
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +00001797 * 'dry-run' - dry-running in the CQ
1798 * 'commit' - in the CQ
Aaron Gable9ab38c62017-04-06 14:36:33 -07001799 * 'closed' - successfully submitted or abandoned
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001800 """
1801 if not self.GetIssue():
1802 return None
1803
1804 try:
Aaron Gable9ab38c62017-04-06 14:36:33 -07001805 data = self._GetChangeDetail([
1806 'DETAILED_LABELS', 'CURRENT_REVISION', 'SUBMITTABLE'])
Edward Lemur79d4f992019-11-11 23:49:02 +00001807 except GerritChangeNotExists:
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001808 return 'error'
1809
tandrii@chromium.org5e1bf382016-05-17 08:43:24 +00001810 if data['status'] in ('ABANDONED', 'MERGED'):
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001811 return 'closed'
1812
Andrii Shyshkalovb8268ca2019-04-03 23:33:44 +00001813 cq_label = data['labels'].get('Commit-Queue', {})
1814 max_cq_vote = 0
1815 for vote in cq_label.get('all', []):
1816 max_cq_vote = max(max_cq_vote, vote.get('value', 0))
1817 if max_cq_vote == 2:
Aaron Gable9ab38c62017-04-06 14:36:33 -07001818 return 'commit'
Andrii Shyshkalovb8268ca2019-04-03 23:33:44 +00001819 if max_cq_vote == 1:
1820 return 'dry-run'
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001821
Aaron Gable9ab38c62017-04-06 14:36:33 -07001822 if data['labels'].get('Code-Review', {}).get('approved'):
1823 return 'lgtm'
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001824
1825 if not data.get('reviewers', {}).get('REVIEWER', []):
1826 return 'unsent'
1827
Andrii Shyshkalov33e88a42017-01-27 14:45:30 +01001828 owner = data['owner'].get('_account_id')
Edward Lemur79d4f992019-11-11 23:49:02 +00001829 messages = sorted(data.get('messages', []), key=lambda m: m.get('date'))
Andrii Shyshkalov8aa9d622020-03-10 19:15:35 +00001830 while messages:
1831 m = messages.pop()
Andrii Shyshkalov899785a2021-07-09 12:45:37 +00001832 if (m.get('tag', '').startswith('autogenerated:cq') or
1833 m.get('tag', '').startswith('autogenerated:cv')):
1834 # Ignore replies from LUCI CV/CQ.
Andrii Shyshkalov33e88a42017-01-27 14:45:30 +01001835 continue
Andrii Shyshkalov8aa9d622020-03-10 19:15:35 +00001836 if m.get('author', {}).get('_account_id') == owner:
Aaron Gable9ab38c62017-04-06 14:36:33 -07001837 # Most recent message was by owner.
1838 return 'waiting'
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +00001839
1840 # Some reply from non-owner.
1841 return 'reply'
Aaron Gable9ab38c62017-04-06 14:36:33 -07001842
1843 # Somehow there are no messages even though there are reviewers.
1844 return 'unsent'
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001845
1846 def GetMostRecentPatchset(self):
Edward Lemur6c6827c2020-02-06 21:15:18 +00001847 if not self.GetIssue():
1848 return None
1849
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001850 data = self._GetChangeDetail(['CURRENT_REVISION'])
Aaron Gablee8856ee2017-12-07 12:41:46 -08001851 patchset = data['revisions'][data['current_revision']]['_number']
1852 self.SetPatchset(patchset)
1853 return patchset
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001854
Gavin Make61ccc52020-11-13 00:12:57 +00001855 def GetMostRecentDryRunPatchset(self):
1856 """Get patchsets equivalent to the most recent patchset and return
1857 the patchset with the latest dry run. If none have been dry run, return
1858 the latest patchset."""
1859 if not self.GetIssue():
1860 return None
1861
1862 data = self._GetChangeDetail(['ALL_REVISIONS'])
1863 patchset = data['revisions'][data['current_revision']]['_number']
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +00001864 dry_run = {int(m['_revision_number'])
1865 for m in data.get('messages', [])
1866 if m.get('tag', '').endswith('dry-run')}
Gavin Make61ccc52020-11-13 00:12:57 +00001867
1868 for revision_info in sorted(data.get('revisions', {}).values(),
1869 key=lambda c: c['_number'], reverse=True):
1870 if revision_info['_number'] in dry_run:
1871 patchset = revision_info['_number']
1872 break
1873 if revision_info.get('kind', '') not in \
1874 ('NO_CHANGE', 'NO_CODE_CHANGE', 'TRIVIAL_REBASE'):
1875 break
1876 self.SetPatchset(patchset)
1877 return patchset
1878
Aaron Gable636b13f2017-07-14 10:42:48 -07001879 def AddComment(self, message, publish=None):
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00001880 gerrit_util.SetReview(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001881 self.GetGerritHost(), self._GerritChangeIdentifier(),
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00001882 msg=message, ready=publish)
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01001883
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001884 def GetCommentsSummary(self, readable=True):
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01001885 # DETAILED_ACCOUNTS is to get emails in accounts.
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001886 # CURRENT_REVISION is included to get the latest patchset so that
1887 # only the robot comments from the latest patchset can be shown.
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001888 messages = self._GetChangeDetail(
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001889 options=['MESSAGES', 'DETAILED_ACCOUNTS',
1890 'CURRENT_REVISION']).get('messages', [])
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001891 file_comments = gerrit_util.GetChangeComments(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001892 self.GetGerritHost(), self._GerritChangeIdentifier())
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001893 robot_file_comments = gerrit_util.GetChangeRobotComments(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001894 self.GetGerritHost(), self._GerritChangeIdentifier())
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001895
1896 # Add the robot comments onto the list of comments, but only
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00001897 # keep those that are from the latest patchset.
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001898 latest_patch_set = self.GetMostRecentPatchset()
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001899 for path, robot_comments in robot_file_comments.items():
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001900 line_comments = file_comments.setdefault(path, [])
1901 line_comments.extend(
1902 [c for c in robot_comments if c['patch_set'] == latest_patch_set])
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001903
1904 # Build dictionary of file comments for easy access and sorting later.
1905 # {author+date: {path: {patchset: {line: url+message}}}}
1906 comments = collections.defaultdict(
1907 lambda: collections.defaultdict(lambda: collections.defaultdict(dict)))
Andrii Shyshkalova3762a92020-11-25 10:20:42 +00001908
1909 server = self.GetCodereviewServer()
1910 if server in _KNOWN_GERRIT_TO_SHORT_URLS:
1911 # /c/ is automatically added by short URL server.
1912 url_prefix = '%s/%s' % (_KNOWN_GERRIT_TO_SHORT_URLS[server],
1913 self.GetIssue())
1914 else:
1915 url_prefix = '%s/c/%s' % (server, self.GetIssue())
1916
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001917 for path, line_comments in file_comments.items():
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001918 for comment in line_comments:
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001919 tag = comment.get('tag', '')
1920 if tag.startswith('autogenerated') and 'robot_id' not in comment:
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001921 continue
1922 key = (comment['author']['email'], comment['updated'])
1923 if comment.get('side', 'REVISION') == 'PARENT':
1924 patchset = 'Base'
1925 else:
1926 patchset = 'PS%d' % comment['patch_set']
1927 line = comment.get('line', 0)
Andrii Shyshkalova3762a92020-11-25 10:20:42 +00001928 url = ('%s/%s/%s#%s%s' %
1929 (url_prefix, comment['patch_set'], path,
1930 'b' if comment.get('side') == 'PARENT' else '',
1931 str(line) if line else ''))
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001932 comments[key][path][patchset][line] = (url, comment['message'])
1933
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001934 summaries = []
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001935 for msg in messages:
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001936 summary = self._BuildCommentSummary(msg, comments, readable)
1937 if summary:
1938 summaries.append(summary)
1939 return summaries
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001940
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001941 @staticmethod
1942 def _BuildCommentSummary(msg, comments, readable):
Josip Sokcevic266129c2021-11-09 00:22:00 +00001943 if 'email' not in msg['author']:
1944 # Some bot accounts may not have an email associated.
1945 return None
1946
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001947 key = (msg['author']['email'], msg['date'])
1948 # Don't bother showing autogenerated messages that don't have associated
1949 # file or line comments. this will filter out most autogenerated
1950 # messages, but will keep robot comments like those from Tricium.
1951 is_autogenerated = msg.get('tag', '').startswith('autogenerated')
1952 if is_autogenerated and not comments.get(key):
1953 return None
1954 message = msg['message']
1955 # Gerrit spits out nanoseconds.
1956 assert len(msg['date'].split('.')[-1]) == 9
1957 date = datetime.datetime.strptime(msg['date'][:-3],
1958 '%Y-%m-%d %H:%M:%S.%f')
1959 if key in comments:
1960 message += '\n'
1961 for path, patchsets in sorted(comments.get(key, {}).items()):
1962 if readable:
1963 message += '\n%s' % path
1964 for patchset, lines in sorted(patchsets.items()):
1965 for line, (url, content) in sorted(lines.items()):
1966 if line:
1967 line_str = 'Line %d' % line
1968 path_str = '%s:%d:' % (path, line)
1969 else:
1970 line_str = 'File comment'
1971 path_str = '%s:0:' % path
1972 if readable:
1973 message += '\n %s, %s: %s' % (patchset, line_str, url)
1974 message += '\n %s\n' % content
1975 else:
1976 message += '\n%s ' % path_str
1977 message += '\n%s\n' % content
1978
1979 return _CommentSummary(
1980 date=date,
1981 message=message,
1982 sender=msg['author']['email'],
1983 autogenerated=is_autogenerated,
1984 # These could be inferred from the text messages and correlated with
1985 # Code-Review label maximum, however this is not reliable.
1986 # Leaving as is until the need arises.
1987 approval=False,
1988 disapproval=False,
1989 )
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01001990
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001991 def CloseIssue(self):
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00001992 gerrit_util.AbandonChange(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001993 self.GetGerritHost(), self._GerritChangeIdentifier(), msg='')
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001994
Xinan Lin1bd4ffa2021-07-28 00:54:22 +00001995 def SubmitIssue(self):
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00001996 gerrit_util.SubmitChange(
Xinan Lin1bd4ffa2021-07-28 00:54:22 +00001997 self.GetGerritHost(), self._GerritChangeIdentifier())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001998
Edward Lesmes7677e5c2020-02-19 20:39:03 +00001999 def _GetChangeDetail(self, options=None):
2000 """Returns details of associated Gerrit change and caching results."""
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002001 options = options or []
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002002 assert self.GetIssue(), 'issue is required to query Gerrit'
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002003
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01002004 # Optimization to avoid multiple RPCs:
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002005 if 'CURRENT_REVISION' in options or 'ALL_REVISIONS' in options:
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01002006 options.append('CURRENT_COMMIT')
2007
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002008 # Normalize issue and options for consistent keys in cache.
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002009 cache_key = str(self.GetIssue())
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002010 options_set = frozenset(o.upper() for o in options)
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002011
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002012 for cached_options_set, data in self._detail_cache.get(cache_key, []):
2013 # Assumption: data fetched before with extra options is suitable
2014 # for return for a smaller set of options.
2015 # For example, if we cached data for
2016 # options=[CURRENT_REVISION, DETAILED_FOOTERS]
2017 # and request is for options=[CURRENT_REVISION],
2018 # THEN we can return prior cached data.
2019 if options_set.issubset(cached_options_set):
2020 return data
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002021
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01002022 try:
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002023 data = gerrit_util.GetChangeDetail(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00002024 self.GetGerritHost(), self._GerritChangeIdentifier(), options_set)
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01002025 except gerrit_util.GerritError as e:
2026 if e.http_status == 404:
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002027 raise GerritChangeNotExists(self.GetIssue(), self.GetCodereviewServer())
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01002028 raise
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002029
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002030 self._detail_cache.setdefault(cache_key, []).append((options_set, data))
tandriic2405f52016-10-10 08:13:15 -07002031 return data
tandrii@chromium.org013a2802016-03-29 09:52:33 +00002032
Andrii Shyshkalovcc5f17e2018-08-22 23:35:59 +00002033 def _GetChangeCommit(self):
Andrii Shyshkalove2633162018-08-27 23:50:31 +00002034 assert self.GetIssue(), 'issue must be set to query Gerrit'
Aaron Gable6f5a8d92017-04-18 14:49:05 -07002035 try:
Andrii Shyshkalove2633162018-08-27 23:50:31 +00002036 data = gerrit_util.GetChangeCommit(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00002037 self.GetGerritHost(), self._GerritChangeIdentifier())
Aaron Gable6f5a8d92017-04-18 14:49:05 -07002038 except gerrit_util.GerritError as e:
2039 if e.http_status == 404:
Andrii Shyshkalove2633162018-08-27 23:50:31 +00002040 raise GerritChangeNotExists(self.GetIssue(), self.GetCodereviewServer())
Aaron Gable6f5a8d92017-04-18 14:49:05 -07002041 raise
agable32978d92016-11-01 12:55:02 -07002042 return data
2043
Karen Qian40c19422019-03-13 21:28:29 +00002044 def _IsCqConfigured(self):
2045 detail = self._GetChangeDetail(['LABELS'])
Andrii Shyshkalov8effa4d2020-01-21 13:23:36 +00002046 return u'Commit-Queue' in detail.get('labels', {})
Karen Qian40c19422019-03-13 21:28:29 +00002047
Saagar Sanghavi03b15132020-08-10 16:43:41 +00002048 def CMDLand(self, force, bypass_hooks, verbose, parallel, resultdb, realm):
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002049 if git_common.is_dirty_git_tree('land'):
2050 return 1
Karen Qian40c19422019-03-13 21:28:29 +00002051
tandriid60367b2016-06-22 05:25:12 -07002052 detail = self._GetChangeDetail(['CURRENT_REVISION', 'LABELS'])
Karen Qian40c19422019-03-13 21:28:29 +00002053 if not force and self._IsCqConfigured():
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +00002054 confirm_or_exit('\nIt seems this repository has a CQ, '
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002055 'which can test and land changes for you. '
2056 'Are you sure you wish to bypass it?\n',
2057 action='bypass CQ')
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002058 differs = True
tandriic4344b52016-08-29 06:04:54 -07002059 last_upload = self._GitGetBranchConfigValue('gerritsquashhash')
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002060 # Note: git diff outputs nothing if there is no diff.
2061 if not last_upload or RunGit(['diff', last_upload]).strip():
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002062 print('WARNING: Some changes from local branch haven\'t been uploaded.')
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002063 else:
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002064 if detail['current_revision'] == last_upload:
2065 differs = False
2066 else:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002067 print('WARNING: Local branch contents differ from latest uploaded '
2068 'patchset.')
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002069 if differs:
2070 if not force:
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002071 confirm_or_exit(
2072 'Do you want to submit latest Gerrit patchset and bypass hooks?\n',
2073 action='submit')
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002074 print('WARNING: Bypassing hooks and submitting latest uploaded patchset.')
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002075 elif not bypass_hooks:
Edward Lemur227d5102020-02-25 23:45:35 +00002076 upstream = self.GetCommonAncestorWithUpstream()
2077 if self.GetIssue():
2078 description = self.FetchDescription()
2079 else:
Edward Lemura12175c2020-03-09 16:58:26 +00002080 description = _create_description_from_log([upstream])
Edward Lemur227d5102020-02-25 23:45:35 +00002081 self.RunHook(
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002082 committing=True,
2083 may_prompt=not force,
2084 verbose=verbose,
Edward Lemur227d5102020-02-25 23:45:35 +00002085 parallel=parallel,
2086 upstream=upstream,
2087 description=description,
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00002088 all_files=False,
Saagar Sanghavi03b15132020-08-10 16:43:41 +00002089 resultdb=resultdb,
2090 realm=realm)
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002091
Xinan Lin1bd4ffa2021-07-28 00:54:22 +00002092 self.SubmitIssue()
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002093 print('Issue %s has been submitted.' % self.GetIssueURL())
agable32978d92016-11-01 12:55:02 -07002094 links = self._GetChangeCommit().get('web_links', [])
2095 for link in links:
Michael Mosse371c642021-09-29 16:41:04 +00002096 if link.get('name') in ['gitiles', 'browse'] and link.get('url'):
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002097 print('Landed as: %s' % link.get('url'))
agable32978d92016-11-01 12:55:02 -07002098 break
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002099 return 0
2100
Bruce Dawsonf362f6f2021-02-18 23:15:17 +00002101 def CMDPatchWithParsedIssue(self, parsed_issue_arg, nocommit, force,
2102 newbranch):
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002103 assert parsed_issue_arg.valid
2104
Edward Lemur125d60a2019-09-13 18:25:41 +00002105 self.issue = parsed_issue_arg.issue
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002106
2107 if parsed_issue_arg.hostname:
2108 self._gerrit_host = parsed_issue_arg.hostname
2109 self._gerrit_server = 'https://%s' % self._gerrit_host
2110
tandriic2405f52016-10-10 08:13:15 -07002111 try:
2112 detail = self._GetChangeDetail(['ALL_REVISIONS'])
Aaron Gablea45ee112016-11-22 15:14:38 -08002113 except GerritChangeNotExists as e:
tandriic2405f52016-10-10 08:13:15 -07002114 DieWithError(str(e))
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002115
2116 if not parsed_issue_arg.patchset:
2117 # Use current revision by default.
2118 revision_info = detail['revisions'][detail['current_revision']]
2119 patchset = int(revision_info['_number'])
2120 else:
2121 patchset = parsed_issue_arg.patchset
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00002122 for revision_info in detail['revisions'].values():
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002123 if int(revision_info['_number']) == parsed_issue_arg.patchset:
2124 break
2125 else:
Aaron Gablea45ee112016-11-22 15:14:38 -08002126 DieWithError('Couldn\'t find patchset %i in change %i' %
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002127 (parsed_issue_arg.patchset, self.GetIssue()))
2128
Edward Lemur125d60a2019-09-13 18:25:41 +00002129 remote_url = self.GetRemoteUrl()
Aaron Gable697a91b2018-01-19 15:20:15 -08002130 if remote_url.endswith('.git'):
2131 remote_url = remote_url[:-len('.git')]
erikchen0d14d0d2018-08-28 18:57:09 +00002132 remote_url = remote_url.rstrip('/')
2133
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002134 fetch_info = revision_info['fetch']['http']
erikchen0d14d0d2018-08-28 18:57:09 +00002135 fetch_info['url'] = fetch_info['url'].rstrip('/')
Aaron Gable697a91b2018-01-19 15:20:15 -08002136
2137 if remote_url != fetch_info['url']:
2138 DieWithError('Trying to patch a change from %s but this repo appears '
2139 'to be %s.' % (fetch_info['url'], remote_url))
2140
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002141 RunGit(['fetch', fetch_info['url'], fetch_info['ref']])
Aaron Gable9387b4f2017-06-08 10:50:03 -07002142
Bruce Dawsonf362f6f2021-02-18 23:15:17 +00002143 # If we have created a new branch then do the "set issue" immediately in
2144 # case the cherry-pick fails, which happens when resolving conflicts.
2145 if newbranch:
2146 self.SetIssue(parsed_issue_arg.issue)
2147
Aaron Gable62619a32017-06-16 08:22:09 -07002148 if force:
2149 RunGit(['reset', '--hard', 'FETCH_HEAD'])
2150 print('Checked out commit for change %i patchset %i locally' %
2151 (parsed_issue_arg.issue, patchset))
Stefan Zager2d5f0392017-10-10 15:17:53 -07002152 elif nocommit:
2153 RunGit(['cherry-pick', '--no-commit', 'FETCH_HEAD'])
2154 print('Patch applied to index.')
Aaron Gable62619a32017-06-16 08:22:09 -07002155 else:
Aaron Gable9387b4f2017-06-08 10:50:03 -07002156 RunGit(['cherry-pick', 'FETCH_HEAD'])
2157 print('Committed patch for change %i patchset %i locally.' %
Aaron Gable62619a32017-06-16 08:22:09 -07002158 (parsed_issue_arg.issue, patchset))
2159 print('Note: this created a local commit which does not have '
2160 'the same hash as the one uploaded for review. This will make '
2161 'uploading changes based on top of this branch difficult.\n'
2162 'If you want to do that, use "git cl patch --force" instead.')
2163
Stefan Zagerd08043c2017-10-12 12:07:02 -07002164 if self.GetBranch():
2165 self.SetIssue(parsed_issue_arg.issue)
2166 self.SetPatchset(patchset)
Edward Lesmes50da7702020-03-30 19:23:43 +00002167 fetched_hash = scm.GIT.ResolveCommit(settings.GetRoot(), 'FETCH_HEAD')
Stefan Zagerd08043c2017-10-12 12:07:02 -07002168 self._GitSetBranchConfigValue('last-upload-hash', fetched_hash)
2169 self._GitSetBranchConfigValue('gerritsquashhash', fetched_hash)
2170 else:
2171 print('WARNING: You are in detached HEAD state.\n'
2172 'The patch has been applied to your checkout, but you will not be '
2173 'able to upload a new patch set to the gerrit issue.\n'
2174 'Try using the \'-b\' option if you would like to work on a '
2175 'branch and/or upload a new patch set.')
2176
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002177 return 0
2178
tandrii16e0b4e2016-06-07 10:34:28 -07002179 def _GerritCommitMsgHookCheck(self, offer_removal):
2180 hook = os.path.join(settings.GetRoot(), '.git', 'hooks', 'commit-msg')
2181 if not os.path.exists(hook):
2182 return
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002183 # Crude attempt to distinguish Gerrit Codereview hook from a potentially
2184 # custom developer-made one.
tandrii16e0b4e2016-06-07 10:34:28 -07002185 data = gclient_utils.FileRead(hook)
2186 if not('From Gerrit Code Review' in data and 'add_ChangeId()' in data):
2187 return
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002188 print('WARNING: You have Gerrit commit-msg hook installed.\n'
qyearsley12fa6ff2016-08-24 09:18:40 -07002189 'It is not necessary for uploading with git cl in squash mode, '
tandrii16e0b4e2016-06-07 10:34:28 -07002190 'and may interfere with it in subtle ways.\n'
2191 'We recommend you remove the commit-msg hook.')
2192 if offer_removal:
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002193 if ask_for_explicit_yes('Do you want to remove it now?'):
tandrii16e0b4e2016-06-07 10:34:28 -07002194 gclient_utils.rm_file_or_tree(hook)
2195 print('Gerrit commit-msg hook removed.')
2196 else:
2197 print('OK, will keep Gerrit commit-msg hook in place.')
2198
Edward Lemur1b52d872019-05-09 21:12:12 +00002199 def _CleanUpOldTraces(self):
2200 """Keep only the last |MAX_TRACES| traces."""
2201 try:
2202 traces = sorted([
2203 os.path.join(TRACES_DIR, f)
2204 for f in os.listdir(TRACES_DIR)
2205 if (os.path.isfile(os.path.join(TRACES_DIR, f))
2206 and not f.startswith('tmp'))
2207 ])
2208 traces_to_delete = traces[:-MAX_TRACES]
2209 for trace in traces_to_delete:
Daniel Chengcf6269b2019-05-18 01:02:12 +00002210 os.remove(trace)
Edward Lemur1b52d872019-05-09 21:12:12 +00002211 except OSError:
2212 print('WARNING: Failed to remove old git traces from\n'
2213 ' %s'
2214 'Consider removing them manually.' % TRACES_DIR)
Edward Lemurdc8e23d2019-05-07 00:45:48 +00002215
Edward Lemur5737f022019-05-17 01:24:00 +00002216 def _WriteGitPushTraces(self, trace_name, traces_dir, git_push_metadata):
Edward Lemur1b52d872019-05-09 21:12:12 +00002217 """Zip and write the git push traces stored in traces_dir."""
2218 gclient_utils.safe_makedirs(TRACES_DIR)
Edward Lemur1b52d872019-05-09 21:12:12 +00002219 traces_zip = trace_name + '-traces'
2220 traces_readme = trace_name + '-README'
Michael Mosse7f0b4c2019-05-08 04:36:24 +00002221 # Create a temporary dir to store git config and gitcookies in. It will be
2222 # compressed and stored next to the traces.
2223 git_info_dir = tempfile.mkdtemp()
Edward Lemur1b52d872019-05-09 21:12:12 +00002224 git_info_zip = trace_name + '-git-info'
2225
Josip Sokcevic5e18b602020-04-23 21:47:00 +00002226 git_push_metadata['now'] = datetime_now().strftime('%Y-%m-%dT%H:%M:%S.%f')
sangwoo.ko7a614332019-05-22 02:46:19 +00002227
Edward Lemur1b52d872019-05-09 21:12:12 +00002228 git_push_metadata['trace_name'] = trace_name
2229 gclient_utils.FileWrite(
2230 traces_readme, TRACES_README_FORMAT % git_push_metadata)
2231
2232 # Keep only the first 6 characters of the git hashes on the packet
2233 # trace. This greatly decreases size after compression.
2234 packet_traces = os.path.join(traces_dir, 'trace-packet')
2235 if os.path.isfile(packet_traces):
2236 contents = gclient_utils.FileRead(packet_traces)
2237 gclient_utils.FileWrite(
2238 packet_traces, GIT_HASH_RE.sub(r'\1', contents))
2239 shutil.make_archive(traces_zip, 'zip', traces_dir)
2240
2241 # Collect and compress the git config and gitcookies.
2242 git_config = RunGit(['config', '-l'])
2243 gclient_utils.FileWrite(
2244 os.path.join(git_info_dir, 'git-config'),
2245 git_config)
2246
2247 cookie_auth = gerrit_util.Authenticator.get()
2248 if isinstance(cookie_auth, gerrit_util.CookiesAuthenticator):
2249 gitcookies_path = cookie_auth.get_gitcookies_path()
2250 if os.path.isfile(gitcookies_path):
2251 gitcookies = gclient_utils.FileRead(gitcookies_path)
2252 gclient_utils.FileWrite(
2253 os.path.join(git_info_dir, 'gitcookies'),
2254 GITCOOKIES_REDACT_RE.sub('REDACTED', gitcookies))
2255 shutil.make_archive(git_info_zip, 'zip', git_info_dir)
2256
Edward Lemur1b52d872019-05-09 21:12:12 +00002257 gclient_utils.rmtree(git_info_dir)
2258
Josip Sokcevicf2cfd3d2021-03-30 18:39:18 +00002259 def _RunGitPushWithTraces(self,
2260 refspec,
2261 refspec_opts,
2262 git_push_metadata,
2263 git_push_options=None):
Edward Lemur1b52d872019-05-09 21:12:12 +00002264 """Run git push and collect the traces resulting from the execution."""
2265 # Create a temporary directory to store traces in. Traces will be compressed
2266 # and stored in a 'traces' dir inside depot_tools.
2267 traces_dir = tempfile.mkdtemp()
Edward Lemur5737f022019-05-17 01:24:00 +00002268 trace_name = os.path.join(
2269 TRACES_DIR, datetime_now().strftime('%Y%m%dT%H%M%S.%f'))
Edward Lemur0f58ae42019-04-30 17:24:12 +00002270
2271 env = os.environ.copy()
2272 env['GIT_REDACT_COOKIES'] = 'o,SSO,GSSO_Uberproxy'
2273 env['GIT_TR2_EVENT'] = os.path.join(traces_dir, 'tr2-event')
Jonathan Nieder9779b142019-05-29 23:19:29 +00002274 env['GIT_TRACE2_EVENT'] = os.path.join(traces_dir, 'tr2-event')
Edward Lemur0f58ae42019-04-30 17:24:12 +00002275 env['GIT_TRACE_CURL'] = os.path.join(traces_dir, 'trace-curl')
2276 env['GIT_TRACE_CURL_NO_DATA'] = '1'
2277 env['GIT_TRACE_PACKET'] = os.path.join(traces_dir, 'trace-packet')
2278
2279 try:
2280 push_returncode = 0
Edward Lemur1b52d872019-05-09 21:12:12 +00002281 remote_url = self.GetRemoteUrl()
Edward Lemur0f58ae42019-04-30 17:24:12 +00002282 before_push = time_time()
Josip Sokcevicf2cfd3d2021-03-30 18:39:18 +00002283 push_cmd = ['git', 'push', remote_url, refspec]
2284 if git_push_options:
2285 for opt in git_push_options:
2286 push_cmd.extend(['-o', opt])
2287
Edward Lemur0f58ae42019-04-30 17:24:12 +00002288 push_stdout = gclient_utils.CheckCallAndFilter(
Josip Sokcevicf2cfd3d2021-03-30 18:39:18 +00002289 push_cmd,
Edward Lemur0f58ae42019-04-30 17:24:12 +00002290 env=env,
2291 print_stdout=True,
2292 # Flush after every line: useful for seeing progress when running as
2293 # recipe.
2294 filter_fn=lambda _: sys.stdout.flush())
Edward Lemur79d4f992019-11-11 23:49:02 +00002295 push_stdout = push_stdout.decode('utf-8', 'replace')
Edward Lemur0f58ae42019-04-30 17:24:12 +00002296 except subprocess2.CalledProcessError as e:
2297 push_returncode = e.returncode
Josip Sokcevic740825e2021-05-12 18:28:34 +00002298 if 'blocked keyword' in str(e.stdout):
2299 raise GitPushError(
2300 'Failed to create a change, very likely due to blocked keyword. '
2301 'Please examine output above for the reason of the failure.\n'
2302 'If this is a false positive, you can try to bypass blocked '
2303 'keyword by using push option '
2304 '-o uploadvalidator~skip, e.g.:\n'
2305 'git cl upload -o uploadvalidator~skip\n\n'
2306 'If git-cl is not working correctly, file a bug under the '
2307 'Infra>SDK component.')
Josip Sokcevic54e30e72022-02-10 22:32:24 +00002308 if 'git push -o nokeycheck' in str(e.stdout):
2309 raise GitPushError(
2310 'Failed to create a change, very likely due to a private key being '
2311 'detected. Please examine output above for the reason of the '
2312 'failure.\n'
2313 'If this is a false positive, you can try to bypass private key '
2314 'detection by using push option '
2315 '-o nokeycheck, e.g.:\n'
2316 'git cl upload -o nokeycheck\n\n'
2317 'If git-cl is not working correctly, file a bug under the '
2318 'Infra>SDK component.')
Josip Sokcevic740825e2021-05-12 18:28:34 +00002319
Josip Sokcevicf736cab2020-10-20 23:41:38 +00002320 raise GitPushError(
2321 'Failed to create a change. Please examine output above for the '
2322 'reason of the failure.\n'
Josip Sokcevic7386a1e2021-02-12 19:00:34 +00002323 'For emergencies, Googlers can escalate to '
2324 'go/gob-support or go/notify#gob\n'
Josip Sokcevicf736cab2020-10-20 23:41:38 +00002325 'Hint: run command below to diagnose common Git/Gerrit '
2326 'credential problems:\n'
2327 ' git cl creds-check\n'
2328 '\n'
2329 'If git-cl is not working correctly, file a bug under the Infra>SDK '
2330 'component including the files below.\n'
2331 'Review the files before upload, since they might contain sensitive '
2332 'information.\n'
2333 'Set the Restrict-View-Google label so that they are not publicly '
2334 'accessible.\n' + TRACES_MESSAGE % {'trace_name': trace_name})
Edward Lemur0f58ae42019-04-30 17:24:12 +00002335 finally:
2336 execution_time = time_time() - before_push
2337 metrics.collector.add_repeated('sub_commands', {
2338 'command': 'git push',
2339 'execution_time': execution_time,
2340 'exit_code': push_returncode,
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +00002341 'arguments': metrics_utils.extract_known_subcommand_args(refspec_opts),
Edward Lemur0f58ae42019-04-30 17:24:12 +00002342 })
2343
Edward Lemur1b52d872019-05-09 21:12:12 +00002344 git_push_metadata['execution_time'] = execution_time
2345 git_push_metadata['exit_code'] = push_returncode
Edward Lemur5737f022019-05-17 01:24:00 +00002346 self._WriteGitPushTraces(trace_name, traces_dir, git_push_metadata)
Edward Lemur0f58ae42019-04-30 17:24:12 +00002347
Edward Lemur1b52d872019-05-09 21:12:12 +00002348 self._CleanUpOldTraces()
Edward Lemur0f58ae42019-04-30 17:24:12 +00002349 gclient_utils.rmtree(traces_dir)
2350
2351 return push_stdout
2352
Josip Sokcevicf736cab2020-10-20 23:41:38 +00002353 def CMDUploadChange(self, options, git_diff_args, custom_cl_base,
2354 change_desc):
2355 """Upload the current branch to Gerrit, retry if new remote HEAD is
2356 found. options and change_desc may be mutated."""
Josip Sokcevicb631a882021-01-06 18:18:10 +00002357 remote, remote_branch = self.GetRemoteBranch()
2358 branch = GetTargetRef(remote, remote_branch, options.target_branch)
2359
Josip Sokcevicf736cab2020-10-20 23:41:38 +00002360 try:
2361 return self._CMDUploadChange(options, git_diff_args, custom_cl_base,
Josip Sokcevicb631a882021-01-06 18:18:10 +00002362 change_desc, branch)
Josip Sokcevicf736cab2020-10-20 23:41:38 +00002363 except GitPushError as e:
Josip Sokcevicb631a882021-01-06 18:18:10 +00002364 # Repository might be in the middle of transition to main branch as
2365 # default, and uploads to old default might be blocked.
2366 if remote_branch not in [DEFAULT_OLD_BRANCH, DEFAULT_NEW_BRANCH]:
Josip Sokcevicf736cab2020-10-20 23:41:38 +00002367 DieWithError(str(e), change_desc)
2368
Josip Sokcevicb631a882021-01-06 18:18:10 +00002369 project_head = gerrit_util.GetProjectHead(self._gerrit_host,
2370 self.GetGerritProject())
2371 if project_head == branch:
2372 DieWithError(str(e), change_desc)
2373 branch = project_head
2374
2375 print("WARNING: Fetching remote state and retrying upload to default "
2376 "branch...")
2377 RunGit(['fetch', '--prune', remote])
Josip Sokcevicf736cab2020-10-20 23:41:38 +00002378 options.edit_description = False
2379 options.force = True
2380 try:
Josip Sokcevicb631a882021-01-06 18:18:10 +00002381 self._CMDUploadChange(options, git_diff_args, custom_cl_base,
2382 change_desc, branch)
Josip Sokcevicf736cab2020-10-20 23:41:38 +00002383 except GitPushError as e:
2384 DieWithError(str(e), change_desc)
2385
2386 def _CMDUploadChange(self, options, git_diff_args, custom_cl_base,
Josip Sokcevicb631a882021-01-06 18:18:10 +00002387 change_desc, branch):
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002388 """Upload the current branch to Gerrit."""
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002389 if options.squash:
tandrii16e0b4e2016-06-07 10:34:28 -07002390 self._GerritCommitMsgHookCheck(offer_removal=not options.force)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002391 if self.GetIssue():
Josipe827b0f2020-01-30 00:07:20 +00002392 # User requested to change description
2393 if options.edit_description:
Josipe827b0f2020-01-30 00:07:20 +00002394 change_desc.prompt()
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002395 change_id = self._GetChangeDetail()['change_id']
Edward Lemur5a644f82020-03-18 16:44:57 +00002396 change_desc.ensure_change_id(change_id)
Aaron Gableb56ad332017-01-06 15:24:31 -08002397 else: # if not self.GetIssue()
Gavin Mak68e6cf32021-01-25 18:24:08 +00002398 if not options.force and not options.message_file:
Anthony Polito8b955342019-09-24 19:01:36 +00002399 change_desc.prompt()
Andrii Shyshkalov8c90d032017-04-19 21:27:26 +02002400 change_ids = git_footers.get_footer_change_id(change_desc.description)
Edward Lemur5a644f82020-03-18 16:44:57 +00002401 if len(change_ids) == 1:
2402 change_id = change_ids[0]
2403 else:
2404 change_id = GenerateGerritChangeId(change_desc.description)
2405 change_desc.ensure_change_id(change_id)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002406
Andrii Shyshkalov71f0da32019-07-15 22:45:18 +00002407 if options.preserve_tryjobs:
2408 change_desc.set_preserve_tryjobs()
Robert Iannuccidb02dd02017-04-19 12:18:20 -07002409
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002410 remote, upstream_branch = self.FetchUpstreamTuple(self.GetBranch())
Edward Lemur5a644f82020-03-18 16:44:57 +00002411 parent = self._ComputeParent(
2412 remote, upstream_branch, custom_cl_base, options.force, change_desc)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002413 tree = RunGit(['rev-parse', 'HEAD:']).strip()
Edward Lemur1773f372020-02-22 00:27:14 +00002414 with gclient_utils.temporary_file() as desc_tempfile:
2415 gclient_utils.FileWrite(desc_tempfile, change_desc.description)
2416 ref_to_push = RunGit(
2417 ['commit-tree', tree, '-p', parent, '-F', desc_tempfile]).strip()
Anthony Polito8b955342019-09-24 19:01:36 +00002418 else: # if not options.squash
Gregory Nisbet48d9e1e2021-04-15 23:35:54 +00002419 if options.no_add_changeid:
2420 pass
2421 else: # adding Change-Ids is okay.
2422 if not git_footers.get_footer_change_id(change_desc.description):
2423 DownloadGerritHook(False)
2424 change_desc.set_description(
2425 self._AddChangeIdToCommitMessage(change_desc.description,
2426 git_diff_args))
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002427 ref_to_push = 'HEAD'
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002428 # For no-squash mode, we assume the remote called "origin" is the one we
2429 # want. It is not worthwhile to support different workflows for
2430 # no-squash mode.
2431 parent = 'origin/%s' % branch
Gregory Nisbet48d9e1e2021-04-15 23:35:54 +00002432 # attempt to extract the changeid from the current description
2433 # fail informatively if not possible.
2434 change_id_candidates = git_footers.get_footer_change_id(
2435 change_desc.description)
2436 if not change_id_candidates:
2437 DieWithError("Unable to extract change-id from message.")
2438 change_id = change_id_candidates[0]
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002439
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +00002440 SaveDescriptionBackup(change_desc)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002441 commits = RunGitSilent(['rev-list', '%s..%s' % (parent,
2442 ref_to_push)]).splitlines()
2443 if len(commits) > 1:
2444 print('WARNING: This will upload %d commits. Run the following command '
2445 'to see which commits will be uploaded: ' % len(commits))
2446 print('git log %s..%s' % (parent, ref_to_push))
2447 print('You can also use `git squash-branch` to squash these into a '
2448 'single commit.')
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002449 confirm_or_exit(action='upload')
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002450
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00002451 reviewers = sorted(change_desc.get_reviewers())
Edward Lemur4508b422019-10-03 21:56:35 +00002452 cc = []
2453 # Add CCs from WATCHLISTS and rietveld.cc git config unless this is
2454 # the initial upload, the CL is private, or auto-CCing has ben disabled.
2455 if not (self.GetIssue() or options.private or options.no_autocc):
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00002456 cc = self.GetCCList().split(',')
Gavin Makb1c08f62021-04-01 18:05:58 +00002457 if len(cc) > 100:
2458 lsc = ('https://chromium.googlesource.com/chromium/src/+/HEAD/docs/'
2459 'process/lsc/lsc_workflow.md')
2460 print('WARNING: This will auto-CC %s users.' % len(cc))
2461 print('LSC may be more appropriate: %s' % lsc)
2462 print('You can also use the --no-autocc flag to disable auto-CC.')
2463 confirm_or_exit(action='continue')
Edward Lemur4508b422019-10-03 21:56:35 +00002464 # Add cc's from the --cc flag.
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00002465 if options.cc:
2466 cc.extend(options.cc)
Edward Lemur79d4f992019-11-11 23:49:02 +00002467 cc = [email.strip() for email in cc if email.strip()]
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00002468 if change_desc.get_cced():
2469 cc.extend(change_desc.get_cced())
Edward Lesmeseeca9c62020-11-20 00:00:17 +00002470 if self.GetGerritHost() == 'chromium-review.googlesource.com':
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00002471 valid_accounts = set(reviewers + cc)
2472 # TODO(crbug/877717): relax this for all hosts.
2473 else:
2474 valid_accounts = gerrit_util.ValidAccounts(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00002475 self.GetGerritHost(), reviewers + cc)
Andrii Shyshkalovf170af42018-10-30 07:00:44 +00002476 logging.info('accounts %s are recognized, %s invalid',
2477 sorted(valid_accounts),
2478 set(reviewers + cc).difference(set(valid_accounts)))
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00002479
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00002480 # Extra options that can be specified at push time. Doc:
2481 # https://gerrit-review.googlesource.com/Documentation/user-upload.html
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +00002482 refspec_opts = []
Andrii Shyshkalov2d8a2072017-04-10 15:02:18 +02002483
Aaron Gable844cf292017-06-28 11:32:59 -07002484 # By default, new changes are started in WIP mode, and subsequent patchsets
2485 # don't send email. At any time, passing --send-mail will mark the change
2486 # ready and send email for that particular patch.
Aaron Gableafd52772017-06-27 16:40:10 -07002487 if options.send_mail:
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +00002488 refspec_opts.append('ready')
2489 refspec_opts.append('notify=ALL')
Jamie Madill276da0b2018-04-27 14:41:20 -04002490 elif not self.GetIssue() and options.squash:
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +00002491 refspec_opts.append('wip')
Aaron Gableafd52772017-06-27 16:40:10 -07002492 else:
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +00002493 refspec_opts.append('notify=NONE')
Aaron Gable70f4e242017-06-26 10:45:59 -07002494
Andrii Shyshkalov2d8a2072017-04-10 15:02:18 +02002495 # TODO(tandrii): options.message should be posted as a comment
Aaron Gablee5adf612017-07-14 10:43:58 -07002496 # if --send-mail is set on non-initial upload as Rietveld used to do it.
Andrii Shyshkalov2d8a2072017-04-10 15:02:18 +02002497
Josip Sokcevicf736cab2020-10-20 23:41:38 +00002498 # Set options.title in case user was prompted in _GetTitleForUpload and
2499 # _CMDUploadChange needs to be called again.
2500 options.title = self._GetTitleForUpload(options)
2501 if options.title:
Nick Carter8692b182017-11-06 16:30:38 -08002502 # Punctuation and whitespace in |title| must be percent-encoded.
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +00002503 refspec_opts.append(
Josip Sokcevicf736cab2020-10-20 23:41:38 +00002504 'm=' + gerrit_util.PercentEncodeForGitRef(options.title))
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00002505
agablec6787972016-09-09 16:13:34 -07002506 if options.private:
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +00002507 refspec_opts.append('private')
agablec6787972016-09-09 16:13:34 -07002508
Andrii Shyshkalov2f727912018-10-15 17:02:33 +00002509 for r in sorted(reviewers):
2510 if r in valid_accounts:
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +00002511 refspec_opts.append('r=%s' % r)
Andrii Shyshkalov2f727912018-10-15 17:02:33 +00002512 reviewers.remove(r)
2513 else:
2514 # TODO(tandrii): this should probably be a hard failure.
2515 print('WARNING: reviewer %s doesn\'t have a Gerrit account, skipping'
2516 % r)
2517 for c in sorted(cc):
2518 # refspec option will be rejected if cc doesn't correspond to an
2519 # account, even though REST call to add such arbitrary cc may succeed.
2520 if c in valid_accounts:
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +00002521 refspec_opts.append('cc=%s' % c)
Andrii Shyshkalov2f727912018-10-15 17:02:33 +00002522 cc.remove(c)
2523
rmistry9eadede2016-09-19 11:22:43 -07002524 if options.topic:
2525 # Documentation on Gerrit topics is here:
2526 # https://gerrit-review.googlesource.com/Documentation/user-upload.html#topic
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +00002527 refspec_opts.append('topic=%s' % options.topic)
rmistry9eadede2016-09-19 11:22:43 -07002528
Edward Lemur687ca902018-12-05 02:30:30 +00002529 if options.enable_auto_submit:
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +00002530 refspec_opts.append('l=Auto-Submit+1')
Edward Lesmes10c3dd62021-02-08 21:13:57 +00002531 if options.set_bot_commit:
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +00002532 refspec_opts.append('l=Bot-Commit+1')
Edward Lemur687ca902018-12-05 02:30:30 +00002533 if options.use_commit_queue:
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +00002534 refspec_opts.append('l=Commit-Queue+2')
Edward Lemur687ca902018-12-05 02:30:30 +00002535 elif options.cq_dry_run:
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +00002536 refspec_opts.append('l=Commit-Queue+1')
Greg Gutermanbe5fccd2021-06-14 17:58:20 +00002537 elif options.cq_quick_run:
2538 refspec_opts.append('l=Commit-Queue+1')
2539 refspec_opts.append('l=Quick-Run+1')
Edward Lemur687ca902018-12-05 02:30:30 +00002540
2541 if change_desc.get_reviewers(tbr_only=True):
2542 score = gerrit_util.GetCodeReviewTbrScore(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00002543 self.GetGerritHost(),
2544 self.GetGerritProject())
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +00002545 refspec_opts.append('l=Code-Review+%s' % score)
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00002546
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08002547 # Gerrit sorts hashtags, so order is not important.
Nodir Turakulov23b82142017-11-16 11:04:25 -08002548 hashtags = {change_desc.sanitize_hash_tag(t) for t in options.hashtags}
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08002549 if not self.GetIssue():
Nodir Turakulov23b82142017-11-16 11:04:25 -08002550 hashtags.update(change_desc.get_hash_tags())
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +00002551 refspec_opts += ['hashtag=%s' % t for t in sorted(hashtags)]
2552
2553 refspec_suffix = ''
2554 if refspec_opts:
2555 refspec_suffix = '%' + ','.join(refspec_opts)
2556 assert ' ' not in refspec_suffix, (
2557 'spaces not allowed in refspec: "%s"' % refspec_suffix)
2558 refspec = '%s:refs/for/%s%s' % (ref_to_push, branch, refspec_suffix)
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00002559
Edward Lemur1b52d872019-05-09 21:12:12 +00002560 git_push_metadata = {
Edward Lesmeseeca9c62020-11-20 00:00:17 +00002561 'gerrit_host': self.GetGerritHost(),
Josip Sokcevicf736cab2020-10-20 23:41:38 +00002562 'title': options.title or '<untitled>',
Edward Lemur1b52d872019-05-09 21:12:12 +00002563 'change_id': change_id,
2564 'description': change_desc.description,
2565 }
Josip Sokcevicf2cfd3d2021-03-30 18:39:18 +00002566
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +00002567 push_stdout = self._RunGitPushWithTraces(refspec, refspec_opts,
Josip Sokcevicf2cfd3d2021-03-30 18:39:18 +00002568 git_push_metadata,
2569 options.push_options)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002570
2571 if options.squash:
Aaron Gable289b4312017-09-13 14:06:16 -07002572 regex = re.compile(r'remote:\s+https?://[\w\-\.\+\/#]*/(\d+)\s.*')
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002573 change_numbers = [m.group(1)
2574 for m in map(regex.match, push_stdout.splitlines())
2575 if m]
2576 if len(change_numbers) != 1:
2577 DieWithError(
2578 ('Created|Updated %d issues on Gerrit, but only 1 expected.\n'
Christopher Lamf732cd52017-01-24 12:40:11 +11002579 'Change-Id: %s') % (len(change_numbers), change_id), change_desc)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002580 self.SetIssue(change_numbers[0])
tandrii5d48c322016-08-18 16:19:37 -07002581 self._GitSetBranchConfigValue('gerritsquashhash', ref_to_push)
tandrii88189772016-09-29 04:29:57 -07002582
Andrii Shyshkalov2f727912018-10-15 17:02:33 +00002583 if self.GetIssue() and (reviewers or cc):
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00002584 # GetIssue() is not set in case of non-squash uploads according to tests.
Aaron Gable6e7ddb62020-05-27 22:23:29 +00002585 # TODO(crbug.com/751901): non-squash uploads in git cl should be removed.
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00002586 gerrit_util.AddReviewers(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00002587 self.GetGerritHost(),
Andrii Shyshkalovd06cc782018-08-23 17:24:19 +00002588 self._GerritChangeIdentifier(),
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00002589 reviewers, cc,
2590 notify=bool(options.send_mail))
Aaron Gable6dadfbf2017-05-09 14:27:58 -07002591
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002592 return 0
2593
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002594 def _ComputeParent(self, remote, upstream_branch, custom_cl_base, force,
2595 change_desc):
2596 """Computes parent of the generated commit to be uploaded to Gerrit.
2597
2598 Returns revision or a ref name.
2599 """
2600 if custom_cl_base:
2601 # Try to avoid creating additional unintended CLs when uploading, unless
2602 # user wants to take this risk.
2603 local_ref_of_target_remote = self.GetRemoteBranch()[1]
2604 code, _ = RunGitWithCode(['merge-base', '--is-ancestor', custom_cl_base,
2605 local_ref_of_target_remote])
2606 if code == 1:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002607 print('\nWARNING: Manually specified base of this CL `%s` '
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002608 'doesn\'t seem to belong to target remote branch `%s`.\n\n'
2609 'If you proceed with upload, more than 1 CL may be created by '
2610 'Gerrit as a result, in turn confusing or crashing git cl.\n\n'
2611 'If you are certain that specified base `%s` has already been '
2612 'uploaded to Gerrit as another CL, you may proceed.\n' %
2613 (custom_cl_base, local_ref_of_target_remote, custom_cl_base))
2614 if not force:
2615 confirm_or_exit(
2616 'Do you take responsibility for cleaning up potential mess '
2617 'resulting from proceeding with upload?',
2618 action='upload')
2619 return custom_cl_base
2620
Aaron Gablef97e33d2017-03-30 15:44:27 -07002621 if remote != '.':
2622 return self.GetCommonAncestorWithUpstream()
2623
2624 # If our upstream branch is local, we base our squashed commit on its
2625 # squashed version.
2626 upstream_branch_name = scm.GIT.ShortBranchName(upstream_branch)
2627
Aaron Gablef97e33d2017-03-30 15:44:27 -07002628 if upstream_branch_name == 'master':
Aaron Gable0bbd1c22017-05-08 14:37:08 -07002629 return self.GetCommonAncestorWithUpstream()
Glen Robertson7d98e222020-08-27 17:53:11 +00002630 if upstream_branch_name == 'main':
2631 return self.GetCommonAncestorWithUpstream()
Aaron Gablef97e33d2017-03-30 15:44:27 -07002632
2633 # Check the squashed hash of the parent.
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002634 # TODO(tandrii): consider checking parent change in Gerrit and using its
2635 # hash if tree hash of latest parent revision (patchset) in Gerrit matches
2636 # the tree hash of the parent branch. The upside is less likely bogus
2637 # requests to reupload parent change just because it's uploadhash is
2638 # missing, yet the downside likely exists, too (albeit unknown to me yet).
Edward Lesmesa680c232020-03-31 18:26:44 +00002639 parent = scm.GIT.GetBranchConfig(
2640 settings.GetRoot(), upstream_branch_name, 'gerritsquashhash')
Aaron Gablef97e33d2017-03-30 15:44:27 -07002641 # Verify that the upstream branch has been uploaded too, otherwise
2642 # Gerrit will create additional CLs when uploading.
2643 if not parent or (RunGitSilent(['rev-parse', upstream_branch + ':']) !=
2644 RunGitSilent(['rev-parse', parent + ':'])):
2645 DieWithError(
2646 '\nUpload upstream branch %s first.\n'
2647 'It is likely that this branch has been rebased since its last '
2648 'upload, so you just need to upload it again.\n'
2649 '(If you uploaded it with --no-squash, then branch dependencies '
2650 'are not supported, and you should reupload with --squash.)'
2651 % upstream_branch_name,
2652 change_desc)
2653 return parent
2654
Edward Lemura12175c2020-03-09 16:58:26 +00002655 def _AddChangeIdToCommitMessage(self, log_desc, args):
tandrii@chromium.org8930b3d2016-04-13 14:47:02 +00002656 """Re-commits using the current message, assumes the commit hook is in
2657 place.
2658 """
Edward Lemura12175c2020-03-09 16:58:26 +00002659 RunGit(['commit', '--amend', '-m', log_desc])
Andrii Shyshkalovb07575f2018-10-16 06:16:21 +00002660 new_log_desc = _create_description_from_log(args)
tandrii@chromium.org8930b3d2016-04-13 14:47:02 +00002661 if git_footers.get_footer_change_id(new_log_desc):
vapiera7fbd5a2016-06-16 09:17:49 -07002662 print('git-cl: Added Change-Id to commit message.')
tandrii@chromium.org8930b3d2016-04-13 14:47:02 +00002663 return new_log_desc
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +00002664
2665 DieWithError('ERROR: Gerrit commit-msg hook not installed.')
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002666
tandriie113dfd2016-10-11 10:20:12 -07002667 def CannotTriggerTryJobReason(self):
tandrii8c5a3532016-11-04 07:52:02 -07002668 try:
2669 data = self._GetChangeDetail()
Aaron Gablea45ee112016-11-22 15:14:38 -08002670 except GerritChangeNotExists:
2671 return 'Gerrit doesn\'t know about your change %s' % self.GetIssue()
tandrii8c5a3532016-11-04 07:52:02 -07002672
2673 if data['status'] in ('ABANDONED', 'MERGED'):
2674 return 'CL %s is closed' % self.GetIssue()
2675
Edward Lemurd4d1ba42019-09-20 21:46:37 +00002676 def GetGerritChange(self, patchset=None):
2677 """Returns a buildbucket.v2.GerritChange message for the current issue."""
Edward Lemur79d4f992019-11-11 23:49:02 +00002678 host = urllib.parse.urlparse(self.GetCodereviewServer()).hostname
Edward Lemurd4d1ba42019-09-20 21:46:37 +00002679 issue = self.GetIssue()
Edward Lemur2c210a42019-09-16 23:58:35 +00002680 patchset = int(patchset or self.GetPatchset())
Edward Lemurd4d1ba42019-09-20 21:46:37 +00002681 data = self._GetChangeDetail(['ALL_REVISIONS'])
2682
2683 assert host and issue and patchset, 'CL must be uploaded first'
2684
2685 has_patchset = any(
2686 int(revision_data['_number']) == patchset
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00002687 for revision_data in data['revisions'].values())
Edward Lemurd4d1ba42019-09-20 21:46:37 +00002688 if not has_patchset:
Aaron Gablea45ee112016-11-22 15:14:38 -08002689 raise Exception('Patchset %d is not known in Gerrit change %d' %
tandrii8c5a3532016-11-04 07:52:02 -07002690 (patchset, self.GetIssue()))
Edward Lemurd4d1ba42019-09-20 21:46:37 +00002691
tandrii8c5a3532016-11-04 07:52:02 -07002692 return {
Edward Lemurd4d1ba42019-09-20 21:46:37 +00002693 'host': host,
2694 'change': issue,
2695 'project': data['project'],
2696 'patchset': patchset,
tandrii8c5a3532016-11-04 07:52:02 -07002697 }
tandriie113dfd2016-10-11 10:20:12 -07002698
tandriide281ae2016-10-12 06:02:30 -07002699 def GetIssueOwner(self):
tandrii8c5a3532016-11-04 07:52:02 -07002700 return self._GetChangeDetail(['DETAILED_ACCOUNTS'])['owner']['email']
tandriide281ae2016-10-12 06:02:30 -07002701
Edward Lemur707d70b2018-02-07 00:50:14 +01002702 def GetReviewers(self):
2703 details = self._GetChangeDetail(['DETAILED_ACCOUNTS'])
Mohamed Heikal171c0742018-11-09 20:38:51 +00002704 return [r['email'] for r in details['reviewers'].get('REVIEWER', [])]
Edward Lemur707d70b2018-02-07 00:50:14 +01002705
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002706
Lei Zhang8a0efc12020-08-05 19:58:45 +00002707def _get_bug_line_values(default_project_prefix, bugs):
2708 """Given default_project_prefix and comma separated list of bugs, yields bug
2709 line values.
tandriif9aefb72016-07-01 09:06:51 -07002710
2711 Each bug can be either:
Lei Zhang8a0efc12020-08-05 19:58:45 +00002712 * a number, which is combined with default_project_prefix
tandriif9aefb72016-07-01 09:06:51 -07002713 * string, which is left as is.
2714
2715 This function may produce more than one line, because bugdroid expects one
2716 project per line.
2717
Lei Zhang8a0efc12020-08-05 19:58:45 +00002718 >>> list(_get_bug_line_values('v8:', '123,chromium:789'))
tandriif9aefb72016-07-01 09:06:51 -07002719 ['v8:123', 'chromium:789']
2720 """
2721 default_bugs = []
2722 others = []
2723 for bug in bugs.split(','):
2724 bug = bug.strip()
2725 if bug:
2726 try:
2727 default_bugs.append(int(bug))
2728 except ValueError:
2729 others.append(bug)
2730
2731 if default_bugs:
2732 default_bugs = ','.join(map(str, default_bugs))
Lei Zhang8a0efc12020-08-05 19:58:45 +00002733 if default_project_prefix:
2734 if not default_project_prefix.endswith(':'):
2735 default_project_prefix += ':'
2736 yield '%s%s' % (default_project_prefix, default_bugs)
tandriif9aefb72016-07-01 09:06:51 -07002737 else:
2738 yield default_bugs
2739 for other in sorted(others):
2740 # Don't bother finding common prefixes, CLs with >2 bugs are very very rare.
2741 yield other
2742
2743
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00002744class ChangeDescription(object):
2745 """Contains a parsed form of the change description."""
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00002746 R_LINE = r'^[ \t]*(TBR|R)[ \t]*=[ \t]*(.*?)[ \t]*$'
bradnelsond975b302016-10-23 12:20:23 -07002747 CC_LINE = r'^[ \t]*(CC)[ \t]*=[ \t]*(.*?)[ \t]*$'
Aaron Gable3a16ed12017-03-23 10:51:55 -07002748 BUG_LINE = r'^[ \t]*(?:(BUG)[ \t]*=|Bug:)[ \t]*(.*?)[ \t]*$'
Dan Beamd8b04ca2019-10-10 21:23:26 +00002749 FIXED_LINE = r'^[ \t]*Fixed[ \t]*:[ \t]*(.*?)[ \t]*$'
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01002750 CHERRY_PICK_LINE = r'^\(cherry picked from commit [a-fA-F0-9]{40}\)$'
Nodir Turakulov23b82142017-11-16 11:04:25 -08002751 STRIP_HASH_TAG_PREFIX = r'^(\s*(revert|reland)( "|:)?\s*)*'
2752 BRACKET_HASH_TAG = r'\s*\[([^\[\]]+)\]'
Anthony Polito02b5af32019-12-02 19:49:47 +00002753 COLON_SEPARATED_HASH_TAG = r'^([a-zA-Z0-9_\- ]+):($|[^:])'
Nodir Turakulov23b82142017-11-16 11:04:25 -08002754 BAD_HASH_TAG_CHUNK = r'[^a-zA-Z0-9]+'
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00002755
Dan Beamd8b04ca2019-10-10 21:23:26 +00002756 def __init__(self, description, bug=None, fixed=None):
agable@chromium.org42c20792013-09-12 17:34:49 +00002757 self._description_lines = (description or '').strip().splitlines()
Anthony Polito8b955342019-09-24 19:01:36 +00002758 if bug:
2759 regexp = re.compile(self.BUG_LINE)
2760 prefix = settings.GetBugPrefix()
2761 if not any((regexp.match(line) for line in self._description_lines)):
2762 values = list(_get_bug_line_values(prefix, bug))
2763 self.append_footer('Bug: %s' % ', '.join(values))
Dan Beamd8b04ca2019-10-10 21:23:26 +00002764 if fixed:
2765 regexp = re.compile(self.FIXED_LINE)
2766 prefix = settings.GetBugPrefix()
2767 if not any((regexp.match(line) for line in self._description_lines)):
2768 values = list(_get_bug_line_values(prefix, fixed))
2769 self.append_footer('Fixed: %s' % ', '.join(values))
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002770
agable@chromium.org42c20792013-09-12 17:34:49 +00002771 @property # www.logilab.org/ticket/89786
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -08002772 def description(self): # pylint: disable=method-hidden
agable@chromium.org42c20792013-09-12 17:34:49 +00002773 return '\n'.join(self._description_lines)
2774
2775 def set_description(self, desc):
2776 if isinstance(desc, basestring):
2777 lines = desc.splitlines()
2778 else:
2779 lines = [line.rstrip() for line in desc]
2780 while lines and not lines[0]:
2781 lines.pop(0)
2782 while lines and not lines[-1]:
2783 lines.pop(-1)
2784 self._description_lines = lines
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002785
Edward Lemur5a644f82020-03-18 16:44:57 +00002786 def ensure_change_id(self, change_id):
2787 description = self.description
2788 footer_change_ids = git_footers.get_footer_change_id(description)
2789 # Make sure that the Change-Id in the description matches the given one.
2790 if footer_change_ids != [change_id]:
2791 if footer_change_ids:
2792 # Remove any existing Change-Id footers since they don't match the
2793 # expected change_id footer.
2794 description = git_footers.remove_footer(description, 'Change-Id')
2795 print('WARNING: Change-Id has been set to %s. Use `git cl issue 0` '
2796 'if you want to set a new one.')
2797 # Add the expected Change-Id footer.
2798 description = git_footers.add_footer_change_id(description, change_id)
2799 self.set_description(description)
2800
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00002801 def update_reviewers(self, reviewers, tbrs):
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002802 """Rewrites the R=/TBR= line(s) as a single line each.
2803
2804 Args:
2805 reviewers (list(str)) - list of additional emails to use for reviewers.
2806 tbrs (list(str)) - list of additional emails to use for TBRs.
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002807 """
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00002808 if not reviewers and not tbrs:
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002809 return
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002810
2811 reviewers = set(reviewers)
2812 tbrs = set(tbrs)
2813 LOOKUP = {
2814 'TBR': tbrs,
2815 'R': reviewers,
2816 }
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002817
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002818 # Get the set of R= and TBR= lines and remove them from the description.
agable@chromium.org42c20792013-09-12 17:34:49 +00002819 regexp = re.compile(self.R_LINE)
2820 matches = [regexp.match(line) for line in self._description_lines]
2821 new_desc = [l for i, l in enumerate(self._description_lines)
2822 if not matches[i]]
2823 self.set_description(new_desc)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002824
agable@chromium.org42c20792013-09-12 17:34:49 +00002825 # Construct new unified R= and TBR= lines.
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002826
2827 # First, update tbrs/reviewers with names from the R=/TBR= lines (if any).
agable@chromium.org42c20792013-09-12 17:34:49 +00002828 for match in matches:
2829 if not match:
2830 continue
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002831 LOOKUP[match.group(1)].update(cleanup_list([match.group(2).strip()]))
2832
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002833 # If any folks ended up in both groups, remove them from tbrs.
2834 tbrs -= reviewers
Robert Iannuccif2708bd2017-04-17 15:49:02 -07002835
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002836 new_r_line = 'R=' + ', '.join(sorted(reviewers)) if reviewers else None
2837 new_tbr_line = 'TBR=' + ', '.join(sorted(tbrs)) if tbrs else None
agable@chromium.org42c20792013-09-12 17:34:49 +00002838
2839 # Put the new lines in the description where the old first R= line was.
2840 line_loc = next((i for i, match in enumerate(matches) if match), -1)
2841 if 0 <= line_loc < len(self._description_lines):
2842 if new_tbr_line:
2843 self._description_lines.insert(line_loc, new_tbr_line)
2844 if new_r_line:
2845 self._description_lines.insert(line_loc, new_r_line)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002846 else:
agable@chromium.org42c20792013-09-12 17:34:49 +00002847 if new_r_line:
2848 self.append_footer(new_r_line)
2849 if new_tbr_line:
2850 self.append_footer(new_tbr_line)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002851
Andrii Shyshkalov71f0da32019-07-15 22:45:18 +00002852 def set_preserve_tryjobs(self):
2853 """Ensures description footer contains 'Cq-Do-Not-Cancel-Tryjobs: true'."""
2854 footers = git_footers.parse_footers(self.description)
2855 for v in footers.get('Cq-Do-Not-Cancel-Tryjobs', []):
2856 if v.lower() == 'true':
2857 return
2858 self.append_footer('Cq-Do-Not-Cancel-Tryjobs: true')
2859
Anthony Polito8b955342019-09-24 19:01:36 +00002860 def prompt(self):
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002861 """Asks the user to update the description."""
agable@chromium.org42c20792013-09-12 17:34:49 +00002862 self.set_description([
2863 '# Enter a description of the change.',
2864 '# This will be displayed on the codereview site.',
2865 '# The first line will also be used as the subject of the review.',
alancutter@chromium.orgbd1073e2013-06-01 00:34:38 +00002866 '#--------------------This line is 72 characters long'
agable@chromium.org42c20792013-09-12 17:34:49 +00002867 '--------------------',
2868 ] + self._description_lines)
Dan Beamd8b04ca2019-10-10 21:23:26 +00002869 bug_regexp = re.compile(self.BUG_LINE)
2870 fixed_regexp = re.compile(self.FIXED_LINE)
Jonas Termansend0f79112019-03-22 15:28:26 +00002871 prefix = settings.GetBugPrefix()
Sigurd Schneider8630bb12020-11-11 14:02:49 +00002872 has_issue = lambda l: bug_regexp.match(l) or fixed_regexp.match(l)
Sigurd Schneider9abde8c2020-11-17 08:44:52 +00002873
Dan Beamd8b04ca2019-10-10 21:23:26 +00002874 if not any((has_issue(line) for line in self._description_lines)):
Anthony Polito8b955342019-09-24 19:01:36 +00002875 self.append_footer('Bug: %s' % prefix)
tandriif9aefb72016-07-01 09:06:51 -07002876
Bruce Dawsonfc487042020-10-27 19:11:37 +00002877 print('Waiting for editor...')
agable@chromium.org42c20792013-09-12 17:34:49 +00002878 content = gclient_utils.RunEditor(self.description, True,
Edward Lemur79d4f992019-11-11 23:49:02 +00002879 git_editor=settings.GetGitEditor())
maruel@chromium.org0e0436a2011-10-25 13:32:41 +00002880 if not content:
2881 DieWithError('Running editor failed')
agable@chromium.org42c20792013-09-12 17:34:49 +00002882 lines = content.splitlines()
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002883
Bruce Dawson2377b012018-01-11 16:46:49 -08002884 # Strip off comments and default inserted "Bug:" line.
2885 clean_lines = [line.rstrip() for line in lines if not
Jonas Termansend0f79112019-03-22 15:28:26 +00002886 (line.startswith('#') or
2887 line.rstrip() == "Bug:" or
2888 line.rstrip() == "Bug: " + prefix)]
agable@chromium.org42c20792013-09-12 17:34:49 +00002889 if not clean_lines:
maruel@chromium.org0e0436a2011-10-25 13:32:41 +00002890 DieWithError('No CL description, aborting')
agable@chromium.org42c20792013-09-12 17:34:49 +00002891 self.set_description(clean_lines)
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00002892
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002893 def append_footer(self, line):
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002894 """Adds a footer line to the description.
2895
2896 Differentiates legacy "KEY=xxx" footers (used to be called tags) and
2897 Gerrit's footers in the form of "Footer-Key: footer any value" and ensures
2898 that Gerrit footers are always at the end.
2899 """
2900 parsed_footer_line = git_footers.parse_footer(line)
2901 if parsed_footer_line:
2902 # Line is a gerrit footer in the form: Footer-Key: any value.
2903 # Thus, must be appended observing Gerrit footer rules.
2904 self.set_description(
2905 git_footers.add_footer(self.description,
2906 key=parsed_footer_line[0],
2907 value=parsed_footer_line[1]))
2908 return
2909
2910 if not self._description_lines:
2911 self._description_lines.append(line)
2912 return
2913
2914 top_lines, gerrit_footers, _ = git_footers.split_footers(self.description)
2915 if gerrit_footers:
2916 # git_footers.split_footers ensures that there is an empty line before
2917 # actual (gerrit) footers, if any. We have to keep it that way.
2918 assert top_lines and top_lines[-1] == ''
2919 top_lines, separator = top_lines[:-1], top_lines[-1:]
2920 else:
2921 separator = [] # No need for separator if there are no gerrit_footers.
2922
2923 prev_line = top_lines[-1] if top_lines else ''
2924 if (not presubmit_support.Change.TAG_LINE_RE.match(prev_line) or
2925 not presubmit_support.Change.TAG_LINE_RE.match(line)):
2926 top_lines.append('')
2927 top_lines.append(line)
2928 self._description_lines = top_lines + separator + gerrit_footers
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00002929
tandrii99a72f22016-08-17 14:33:24 -07002930 def get_reviewers(self, tbr_only=False):
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002931 """Retrieves the list of reviewers."""
agable@chromium.org42c20792013-09-12 17:34:49 +00002932 matches = [re.match(self.R_LINE, line) for line in self._description_lines]
tandrii99a72f22016-08-17 14:33:24 -07002933 reviewers = [match.group(2).strip()
2934 for match in matches
2935 if match and (not tbr_only or match.group(1).upper() == 'TBR')]
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002936 return cleanup_list(reviewers)
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00002937
bradnelsond975b302016-10-23 12:20:23 -07002938 def get_cced(self):
2939 """Retrieves the list of reviewers."""
2940 matches = [re.match(self.CC_LINE, line) for line in self._description_lines]
2941 cced = [match.group(2).strip() for match in matches if match]
2942 return cleanup_list(cced)
2943
Nodir Turakulov23b82142017-11-16 11:04:25 -08002944 def get_hash_tags(self):
2945 """Extracts and sanitizes a list of Gerrit hashtags."""
2946 subject = (self._description_lines or ('',))[0]
2947 subject = re.sub(
2948 self.STRIP_HASH_TAG_PREFIX, '', subject, flags=re.IGNORECASE)
2949
2950 tags = []
2951 start = 0
2952 bracket_exp = re.compile(self.BRACKET_HASH_TAG)
2953 while True:
2954 m = bracket_exp.match(subject, start)
2955 if not m:
2956 break
2957 tags.append(self.sanitize_hash_tag(m.group(1)))
2958 start = m.end()
2959
2960 if not tags:
2961 # Try "Tag: " prefix.
2962 m = re.match(self.COLON_SEPARATED_HASH_TAG, subject)
2963 if m:
2964 tags.append(self.sanitize_hash_tag(m.group(1)))
2965 return tags
2966
2967 @classmethod
2968 def sanitize_hash_tag(cls, tag):
2969 """Returns a sanitized Gerrit hash tag.
2970
2971 A sanitized hashtag can be used as a git push refspec parameter value.
2972 """
2973 return re.sub(cls.BAD_HASH_TAG_CHUNK, '-', tag).strip('-').lower()
2974
maruel@chromium.orge52678e2013-04-26 18:34:44 +00002975
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00002976def FindCodereviewSettingsFile(filename='codereview.settings'):
2977 """Finds the given file starting in the cwd and going up.
2978
2979 Only looks up to the top of the repository unless an
2980 'inherit-review-settings-ok' file exists in the root of the repository.
2981 """
2982 inherit_ok_file = 'inherit-review-settings-ok'
2983 cwd = os.getcwd()
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00002984 root = settings.GetRoot()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00002985 if os.path.isfile(os.path.join(root, inherit_ok_file)):
2986 root = '/'
2987 while True:
2988 if filename in os.listdir(cwd):
2989 if os.path.isfile(os.path.join(cwd, filename)):
2990 return open(os.path.join(cwd, filename))
2991 if cwd == root:
2992 break
2993 cwd = os.path.dirname(cwd)
2994
2995
2996def LoadCodereviewSettingsFromFile(fileobj):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002997 """Parses a codereview.settings file and updates hooks."""
maruel@chromium.org99ac1c52012-01-16 14:52:12 +00002998 keyvals = gclient_utils.ParseCodereviewSettingsContent(fileobj.read())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00002999
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003000 def SetProperty(name, setting, unset_error_ok=False):
3001 fullname = 'rietveld.' + name
3002 if setting in keyvals:
3003 RunGit(['config', fullname, keyvals[setting]])
3004 else:
3005 RunGit(['config', '--unset-all', fullname], error_ok=unset_error_ok)
3006
tandrii48df5812016-10-17 03:55:37 -07003007 if not keyvals.get('GERRIT_HOST', False):
3008 SetProperty('server', 'CODE_REVIEW_SERVER')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003009 # Only server setting is required. Other settings can be absent.
3010 # In that case, we ignore errors raised during option deletion attempt.
3011 SetProperty('cc', 'CC_LIST', unset_error_ok=True)
3012 SetProperty('tree-status-url', 'STATUS', unset_error_ok=True)
3013 SetProperty('viewvc-url', 'VIEW_VC', unset_error_ok=True)
rmistry@google.com90752582014-01-14 21:04:50 +00003014 SetProperty('bug-prefix', 'BUG_PREFIX', unset_error_ok=True)
thestig@chromium.org44202a22014-03-11 19:22:18 +00003015 SetProperty('cpplint-regex', 'LINT_REGEX', unset_error_ok=True)
3016 SetProperty('cpplint-ignore-regex', 'LINT_IGNORE_REGEX', unset_error_ok=True)
rmistry@google.com5626a922015-02-26 14:03:30 +00003017 SetProperty('run-post-upload-hook', 'RUN_POST_UPLOAD_HOOK',
3018 unset_error_ok=True)
Jamie Madilldc4d19e2019-10-24 21:50:02 +00003019 SetProperty(
3020 'format-full-by-default', 'FORMAT_FULL_BY_DEFAULT', unset_error_ok=True)
Dirk Pranke6f0df682021-06-25 00:42:33 +00003021 SetProperty('use-python3', 'USE_PYTHON3', unset_error_ok=True)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003022
ukai@chromium.org7044efc2013-11-28 01:51:21 +00003023 if 'GERRIT_HOST' in keyvals:
ukai@chromium.orge8077812012-02-03 03:41:46 +00003024 RunGit(['config', 'gerrit.host', keyvals['GERRIT_HOST']])
ukai@chromium.orge8077812012-02-03 03:41:46 +00003025
bauerb@chromium.org54b400c2016-01-14 10:08:25 +00003026 if 'GERRIT_SQUASH_UPLOADS' in keyvals:
Edward Lesmes4de54132020-05-05 19:41:33 +00003027 RunGit(['config', 'gerrit.squash-uploads',
3028 keyvals['GERRIT_SQUASH_UPLOADS']])
bauerb@chromium.org54b400c2016-01-14 10:08:25 +00003029
tandrii@chromium.org28253532016-04-14 13:46:56 +00003030 if 'GERRIT_SKIP_ENSURE_AUTHENTICATED' in keyvals:
shinyak@chromium.org00dbccd2016-04-15 07:24:43 +00003031 RunGit(['config', 'gerrit.skip-ensure-authenticated',
tandrii@chromium.org28253532016-04-14 13:46:56 +00003032 keyvals['GERRIT_SKIP_ENSURE_AUTHENTICATED']])
3033
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003034 if 'PUSH_URL_CONFIG' in keyvals and 'ORIGIN_URL_CONFIG' in keyvals:
Andrii Shyshkalov18975322017-01-25 16:44:13 +01003035 # should be of the form
3036 # PUSH_URL_CONFIG: url.ssh://gitrw.chromium.org.pushinsteadof
3037 # ORIGIN_URL_CONFIG: http://src.chromium.org/git
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003038 RunGit(['config', keyvals['PUSH_URL_CONFIG'],
3039 keyvals['ORIGIN_URL_CONFIG']])
3040
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003041
joshua.lock@intel.com426f69b2012-08-02 23:41:49 +00003042def urlretrieve(source, destination):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003043 """Downloads a network object to a local file, like urllib.urlretrieve.
3044
3045 This is necessary because urllib is broken for SSL connections via a proxy.
3046 """
Vadim Shtayuraf7b8f8f2021-11-15 19:10:05 +00003047 with open(destination, 'wb') as f:
Edward Lemur79d4f992019-11-11 23:49:02 +00003048 f.write(urllib.request.urlopen(source).read())
joshua.lock@intel.com426f69b2012-08-02 23:41:49 +00003049
3050
ukai@chromium.org712d6102013-11-27 00:52:58 +00003051def hasSheBang(fname):
3052 """Checks fname is a #! script."""
3053 with open(fname) as f:
3054 return f.read(2).startswith('#!')
3055
3056
tandrii@chromium.org18630d62016-03-04 12:06:02 +00003057def DownloadGerritHook(force):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003058 """Downloads and installs a Gerrit commit-msg hook.
ukai@chromium.org78c4b982012-02-14 02:20:26 +00003059
3060 Args:
3061 force: True to update hooks. False to install hooks if not present.
3062 """
ukai@chromium.org712d6102013-11-27 00:52:58 +00003063 src = 'https://gerrit-review.googlesource.com/tools/hooks/commit-msg'
ukai@chromium.org78c4b982012-02-14 02:20:26 +00003064 dst = os.path.join(settings.GetRoot(), '.git', 'hooks', 'commit-msg')
3065 if not os.access(dst, os.X_OK):
3066 if os.path.exists(dst):
3067 if not force:
3068 return
ukai@chromium.org78c4b982012-02-14 02:20:26 +00003069 try:
joshua.lock@intel.com426f69b2012-08-02 23:41:49 +00003070 urlretrieve(src, dst)
ukai@chromium.org712d6102013-11-27 00:52:58 +00003071 if not hasSheBang(dst):
3072 DieWithError('Not a script: %s\n'
3073 'You need to download from\n%s\n'
3074 'into .git/hooks/commit-msg and '
3075 'chmod +x .git/hooks/commit-msg' % (dst, src))
ukai@chromium.org78c4b982012-02-14 02:20:26 +00003076 os.chmod(dst, stat.S_IRUSR | stat.S_IWUSR | stat.S_IXUSR)
3077 except Exception:
3078 if os.path.exists(dst):
3079 os.remove(dst)
ukai@chromium.org712d6102013-11-27 00:52:58 +00003080 DieWithError('\nFailed to download hooks.\n'
3081 'You need to download from\n%s\n'
3082 'into .git/hooks/commit-msg and '
3083 'chmod +x .git/hooks/commit-msg' % src)
ukai@chromium.org78c4b982012-02-14 02:20:26 +00003084
3085
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003086class _GitCookiesChecker(object):
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003087 """Provides facilities for validating and suggesting fixes to .gitcookies."""
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003088
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003089 _GOOGLESOURCE = 'googlesource.com'
3090
3091 def __init__(self):
3092 # Cached list of [host, identity, source], where source is either
3093 # .gitcookies or .netrc.
3094 self._all_hosts = None
3095
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003096 def ensure_configured_gitcookies(self):
3097 """Runs checks and suggests fixes to make git use .gitcookies from default
3098 path."""
3099 default = gerrit_util.CookiesAuthenticator.get_gitcookies_path()
3100 configured_path = RunGitSilent(
3101 ['config', '--global', 'http.cookiefile']).strip()
Andrii Shyshkalov1e250cd2017-05-10 15:39:31 +02003102 configured_path = os.path.expanduser(configured_path)
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003103 if configured_path:
3104 self._ensure_default_gitcookies_path(configured_path, default)
3105 else:
3106 self._configure_gitcookies_path(default)
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003107
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003108 @staticmethod
3109 def _ensure_default_gitcookies_path(configured_path, default_path):
3110 assert configured_path
3111 if configured_path == default_path:
3112 print('git is already configured to use your .gitcookies from %s' %
3113 configured_path)
3114 return
3115
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003116 print('WARNING: You have configured custom path to .gitcookies: %s\n'
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003117 'Gerrit and other depot_tools expect .gitcookies at %s\n' %
3118 (configured_path, default_path))
3119
3120 if not os.path.exists(configured_path):
3121 print('However, your configured .gitcookies file is missing.')
3122 confirm_or_exit('Reconfigure git to use default .gitcookies?',
3123 action='reconfigure')
3124 RunGit(['config', '--global', 'http.cookiefile', default_path])
3125 return
3126
3127 if os.path.exists(default_path):
3128 print('WARNING: default .gitcookies file already exists %s' %
3129 default_path)
3130 DieWithError('Please delete %s manually and re-run git cl creds-check' %
3131 default_path)
3132
3133 confirm_or_exit('Move existing .gitcookies to default location?',
3134 action='move')
3135 shutil.move(configured_path, default_path)
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003136 RunGit(['config', '--global', 'http.cookiefile', default_path])
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003137 print('Moved and reconfigured git to use .gitcookies from %s' %
3138 default_path)
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003139
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003140 @staticmethod
3141 def _configure_gitcookies_path(default_path):
3142 netrc_path = gerrit_util.CookiesAuthenticator.get_netrc_path()
3143 if os.path.exists(netrc_path):
3144 print('You seem to be using outdated .netrc for git credentials: %s' %
3145 netrc_path)
3146 print('This tool will guide you through setting up recommended '
3147 '.gitcookies store for git credentials.\n'
3148 '\n'
3149 'IMPORTANT: If something goes wrong and you decide to go back, do:\n'
3150 ' git config --global --unset http.cookiefile\n'
3151 ' mv %s %s.backup\n\n' % (default_path, default_path))
3152 confirm_or_exit(action='setup .gitcookies')
3153 RunGit(['config', '--global', 'http.cookiefile', default_path])
3154 print('Configured git to use .gitcookies from %s' % default_path)
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003155
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003156 def get_hosts_with_creds(self, include_netrc=False):
3157 if self._all_hosts is None:
3158 a = gerrit_util.CookiesAuthenticator()
3159 self._all_hosts = [
3160 (h, u, s)
3161 for h, u, s in itertools.chain(
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00003162 ((h, u, '.netrc') for h, (u, _, _) in a.netrc.hosts.items()),
3163 ((h, u, '.gitcookies') for h, (u, _) in a.gitcookies.items())
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003164 )
3165 if h.endswith(self._GOOGLESOURCE)
3166 ]
3167
3168 if include_netrc:
3169 return self._all_hosts
3170 return [(h, u, s) for h, u, s in self._all_hosts if s != '.netrc']
3171
3172 def print_current_creds(self, include_netrc=False):
3173 hosts = sorted(self.get_hosts_with_creds(include_netrc=include_netrc))
3174 if not hosts:
3175 print('No Git/Gerrit credentials found')
3176 return
Edward Lemur79d4f992019-11-11 23:49:02 +00003177 lengths = [max(map(len, (row[i] for row in hosts))) for i in range(3)]
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003178 header = [('Host', 'User', 'Which file'),
3179 ['=' * l for l in lengths]]
3180 for row in (header + hosts):
3181 print('\t'.join((('%%+%ds' % l) % s)
3182 for l, s in zip(lengths, row)))
3183
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003184 @staticmethod
3185 def _parse_identity(identity):
Lei Zhangd3f769a2017-12-15 15:16:14 -08003186 """Parses identity "git-<username>.domain" into <username> and domain."""
3187 # Special case: usernames that contain ".", which are generally not
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +02003188 # distinguishable from sub-domains. But we do know typical domains:
3189 if identity.endswith('.chromium.org'):
3190 domain = 'chromium.org'
3191 username = identity[:-len('.chromium.org')]
3192 else:
3193 username, domain = identity.split('.', 1)
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003194 if username.startswith('git-'):
3195 username = username[len('git-'):]
3196 return username, domain
3197
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003198 def _canonical_git_googlesource_host(self, host):
3199 """Normalizes Gerrit hosts (with '-review') to Git host."""
3200 assert host.endswith(self._GOOGLESOURCE)
3201 # Prefix doesn't include '.' at the end.
3202 prefix = host[:-(1 + len(self._GOOGLESOURCE))]
3203 if prefix.endswith('-review'):
3204 prefix = prefix[:-len('-review')]
3205 return prefix + '.' + self._GOOGLESOURCE
3206
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003207 def _canonical_gerrit_googlesource_host(self, host):
3208 git_host = self._canonical_git_googlesource_host(host)
3209 prefix = git_host.split('.', 1)[0]
3210 return prefix + '-review.' + self._GOOGLESOURCE
3211
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003212 def _get_counterpart_host(self, host):
3213 assert host.endswith(self._GOOGLESOURCE)
3214 git = self._canonical_git_googlesource_host(host)
3215 gerrit = self._canonical_gerrit_googlesource_host(git)
3216 return git if gerrit == host else gerrit
3217
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003218 def has_generic_host(self):
3219 """Returns whether generic .googlesource.com has been configured.
3220
3221 Chrome Infra recommends to use explicit ${host}.googlesource.com instead.
3222 """
3223 for host, _, _ in self.get_hosts_with_creds(include_netrc=False):
3224 if host == '.' + self._GOOGLESOURCE:
3225 return True
3226 return False
3227
3228 def _get_git_gerrit_identity_pairs(self):
3229 """Returns map from canonic host to pair of identities (Git, Gerrit).
3230
3231 One of identities might be None, meaning not configured.
3232 """
3233 host_to_identity_pairs = {}
3234 for host, identity, _ in self.get_hosts_with_creds():
3235 canonical = self._canonical_git_googlesource_host(host)
3236 pair = host_to_identity_pairs.setdefault(canonical, [None, None])
3237 idx = 0 if canonical == host else 1
3238 pair[idx] = identity
3239 return host_to_identity_pairs
3240
3241 def get_partially_configured_hosts(self):
3242 return set(
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003243 (host if i1 else self._canonical_gerrit_googlesource_host(host))
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00003244 for host, (i1, i2) in self._get_git_gerrit_identity_pairs().items()
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003245 if None in (i1, i2) and host != '.' + self._GOOGLESOURCE)
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003246
3247 def get_conflicting_hosts(self):
3248 return set(
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003249 host
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00003250 for host, (i1, i2) in self._get_git_gerrit_identity_pairs().items()
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003251 if None not in (i1, i2) and i1 != i2)
3252
3253 def get_duplicated_hosts(self):
3254 counters = collections.Counter(h for h, _, _ in self.get_hosts_with_creds())
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00003255 return set(host for host, count in counters.items() if count > 1)
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003256
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003257
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003258 @staticmethod
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003259 def _format_hosts(hosts, extra_column_func=None):
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003260 hosts = sorted(hosts)
3261 assert hosts
3262 if extra_column_func is None:
3263 extras = [''] * len(hosts)
3264 else:
3265 extras = [extra_column_func(host) for host in hosts]
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003266 tmpl = '%%-%ds %%-%ds' % (max(map(len, hosts)), max(map(len, extras)))
3267 lines = []
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003268 for he in zip(hosts, extras):
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003269 lines.append(tmpl % he)
3270 return lines
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003271
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003272 def _find_problems(self):
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003273 if self.has_generic_host():
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003274 yield ('.googlesource.com wildcard record detected',
3275 ['Chrome Infrastructure team recommends to list full host names '
3276 'explicitly.'],
3277 None)
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003278
3279 dups = self.get_duplicated_hosts()
3280 if dups:
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003281 yield ('The following hosts were defined twice',
3282 self._format_hosts(dups),
3283 None)
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003284
3285 partial = self.get_partially_configured_hosts()
3286 if partial:
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003287 yield ('Credentials should come in pairs for Git and Gerrit hosts. '
3288 'These hosts are missing',
3289 self._format_hosts(partial, lambda host: 'but %s defined' %
3290 self._get_counterpart_host(host)),
3291 partial)
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003292
3293 conflicting = self.get_conflicting_hosts()
3294 if conflicting:
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003295 yield ('The following Git hosts have differing credentials from their '
3296 'Gerrit counterparts',
3297 self._format_hosts(conflicting, lambda host: '%s vs %s' %
3298 tuple(self._get_git_gerrit_identity_pairs()[host])),
3299 conflicting)
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003300
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003301 def find_and_report_problems(self):
3302 """Returns True if there was at least one problem, else False."""
3303 found = False
3304 bad_hosts = set()
3305 for title, sublines, hosts in self._find_problems():
3306 if not found:
3307 found = True
3308 print('\n\n.gitcookies problem report:\n')
3309 bad_hosts.update(hosts or [])
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003310 print(' %s%s' % (title, (':' if sublines else '')))
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003311 if sublines:
3312 print()
3313 print(' %s' % '\n '.join(sublines))
3314 print()
3315
3316 if bad_hosts:
3317 assert found
3318 print(' You can manually remove corresponding lines in your %s file and '
3319 'visit the following URLs with correct account to generate '
3320 'correct credential lines:\n' %
3321 gerrit_util.CookiesAuthenticator.get_gitcookies_path())
3322 print(' %s' % '\n '.join(sorted(set(
3323 gerrit_util.CookiesAuthenticator().get_new_password_url(
3324 self._canonical_git_googlesource_host(host))
3325 for host in bad_hosts
3326 ))))
3327 return found
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003328
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003329
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003330@metrics.collector.collect_metrics('git cl creds-check')
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003331def CMDcreds_check(parser, args):
3332 """Checks credentials and suggests changes."""
3333 _, _ = parser.parse_args(args)
3334
Vadim Shtayurab250ec12018-10-04 00:21:08 +00003335 # Code below checks .gitcookies. Abort if using something else.
3336 authn = gerrit_util.Authenticator.get()
3337 if not isinstance(authn, gerrit_util.CookiesAuthenticator):
Edward Lemur57d47422020-03-06 20:43:07 +00003338 message = (
Vadim Shtayurab250ec12018-10-04 00:21:08 +00003339 'This command is not designed for bot environment. It checks '
3340 '~/.gitcookies file not generally used on bots.')
Edward Lemur57d47422020-03-06 20:43:07 +00003341 # TODO(crbug.com/1059384): Automatically detect when running on cloudtop.
3342 if isinstance(authn, gerrit_util.GceAuthenticator):
3343 message += (
3344 '\n'
3345 'If you need to run this on GCE or a cloudtop instance, '
3346 'export SKIP_GCE_AUTH_FOR_GIT=1 in your env.')
3347 DieWithError(message)
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003348
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003349 checker = _GitCookiesChecker()
3350 checker.ensure_configured_gitcookies()
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003351
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003352 print('Your .netrc and .gitcookies have credentials for these hosts:')
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003353 checker.print_current_creds(include_netrc=True)
3354
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003355 if not checker.find_and_report_problems():
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003356 print('\nNo problems detected in your .gitcookies file.')
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003357 return 0
3358 return 1
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003359
3360
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003361@metrics.collector.collect_metrics('git cl baseurl')
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00003362def CMDbaseurl(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00003363 """Gets or sets base-url for this branch."""
Edward Lesmes50da7702020-03-30 19:23:43 +00003364 branchref = scm.GIT.GetBranchRef(settings.GetRoot())
Edward Lemur85153282020-02-14 22:06:29 +00003365 branch = scm.GIT.ShortBranchName(branchref)
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00003366 _, args = parser.parse_args(args)
3367 if not args:
vapiera7fbd5a2016-06-16 09:17:49 -07003368 print('Current base-url:')
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00003369 return RunGit(['config', 'branch.%s.base-url' % branch],
3370 error_ok=False).strip()
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +00003371
3372 print('Setting base-url to %s' % args[0])
3373 return RunGit(['config', 'branch.%s.base-url' % branch, args[0]],
3374 error_ok=False).strip()
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00003375
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003376
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00003377def color_for_status(status):
3378 """Maps a Changelist status to color, for CMDstatus and other tools."""
Bruce Dawsonb73f8a92020-03-27 22:03:08 +00003379 BOLD = '\033[1m'
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00003380 return {
Bruce Dawsonb73f8a92020-03-27 22:03:08 +00003381 'unsent': BOLD + Fore.YELLOW,
3382 'waiting': BOLD + Fore.RED,
3383 'reply': BOLD + Fore.YELLOW,
3384 'not lgtm': BOLD + Fore.RED,
3385 'lgtm': BOLD + Fore.GREEN,
3386 'commit': BOLD + Fore.MAGENTA,
3387 'closed': BOLD + Fore.CYAN,
3388 'error': BOLD + Fore.WHITE,
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00003389 }.get(status, Fore.WHITE)
3390
tandrii@chromium.org04ea8462016-04-25 19:51:21 +00003391
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003392def get_cl_statuses(changes, fine_grained, max_processes=None):
3393 """Returns a blocking iterable of (cl, status) for given branches.
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00003394
3395 If fine_grained is true, this will fetch CL statuses from the server.
3396 Otherwise, simply indicate if there's a matching url for the given branches.
3397
3398 If max_processes is specified, it is used as the maximum number of processes
3399 to spawn to fetch CL status from the server. Otherwise 1 process per branch is
3400 spawned.
calamity@chromium.orgcf197482016-04-29 20:15:53 +00003401
3402 See GetStatus() for a list of possible statuses.
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00003403 """
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01003404 if not changes:
Edward Lemur61bf4172020-02-24 23:22:37 +00003405 return
calamity@chromium.orgcf197482016-04-29 20:15:53 +00003406
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01003407 if not fine_grained:
3408 # Fast path which doesn't involve querying codereview servers.
Aaron Gablea1bab272017-04-11 16:38:18 -07003409 # Do not use get_approving_reviewers(), since it requires an HTTP request.
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003410 for cl in changes:
3411 yield (cl, 'waiting' if cl.GetIssueURL() else 'error')
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01003412 return
3413
3414 # First, sort out authentication issues.
3415 logging.debug('ensuring credentials exist')
3416 for cl in changes:
3417 cl.EnsureAuthenticated(force=False, refresh=True)
3418
3419 def fetch(cl):
3420 try:
3421 return (cl, cl.GetStatus())
3422 except:
3423 # See http://crbug.com/629863.
Andrii Shyshkalov98824232018-04-19 11:37:15 -07003424 logging.exception('failed to fetch status for cl %s:', cl.GetIssue())
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01003425 raise
3426
3427 threads_count = len(changes)
3428 if max_processes:
3429 threads_count = max(1, min(threads_count, max_processes))
3430 logging.debug('querying %d CLs using %d threads', len(changes), threads_count)
3431
Edward Lemur61bf4172020-02-24 23:22:37 +00003432 pool = multiprocessing.pool.ThreadPool(threads_count)
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01003433 fetched_cls = set()
3434 try:
3435 it = pool.imap_unordered(fetch, changes).__iter__()
3436 while True:
3437 try:
3438 cl, status = it.next(timeout=5)
Edward Lemur61bf4172020-02-24 23:22:37 +00003439 except (multiprocessing.TimeoutError, StopIteration):
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01003440 break
3441 fetched_cls.add(cl)
3442 yield cl, status
3443 finally:
3444 pool.close()
3445
3446 # Add any branches that failed to fetch.
3447 for cl in set(changes) - fetched_cls:
3448 yield (cl, 'error')
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00003449
rmistry@google.com2dd99862015-06-22 12:22:18 +00003450
Jose Lopes3863fc52020-04-07 17:00:25 +00003451def upload_branch_deps(cl, args, force=False):
rmistry@google.com2dd99862015-06-22 12:22:18 +00003452 """Uploads CLs of local branches that are dependents of the current branch.
3453
3454 If the local branch dependency tree looks like:
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003455
3456 test1 -> test2.1 -> test3.1
3457 -> test3.2
3458 -> test2.2 -> test3.3
rmistry@google.com2dd99862015-06-22 12:22:18 +00003459
3460 and you run "git cl upload --dependencies" from test1 then "git cl upload" is
3461 run on the dependent branches in this order:
3462 test2.1, test3.1, test3.2, test2.2, test3.3
3463
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003464 Note: This function does not rebase your local dependent branches. Use it
3465 when you make a change to the parent branch that will not conflict
3466 with its dependent branches, and you would like their dependencies
3467 updated in Rietveld.
rmistry@google.com2dd99862015-06-22 12:22:18 +00003468 """
3469 if git_common.is_dirty_git_tree('upload-branch-deps'):
3470 return 1
3471
3472 root_branch = cl.GetBranch()
3473 if root_branch is None:
3474 DieWithError('Can\'t find dependent branches from detached HEAD state. '
3475 'Get on a branch!')
Andrii Shyshkalov9f274432018-10-15 16:40:23 +00003476 if not cl.GetIssue():
rmistry@google.com2dd99862015-06-22 12:22:18 +00003477 DieWithError('Current branch does not have an uploaded CL. We cannot set '
3478 'patchset dependencies without an uploaded CL.')
3479
3480 branches = RunGit(['for-each-ref',
3481 '--format=%(refname:short) %(upstream:short)',
3482 'refs/heads'])
3483 if not branches:
3484 print('No local branches found.')
3485 return 0
3486
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003487 # Create a dictionary of all local branches to the branches that are
3488 # dependent on it.
rmistry@google.com2dd99862015-06-22 12:22:18 +00003489 tracked_to_dependents = collections.defaultdict(list)
3490 for b in branches.splitlines():
3491 tokens = b.split()
3492 if len(tokens) == 2:
3493 branch_name, tracked = tokens
3494 tracked_to_dependents[tracked].append(branch_name)
3495
vapiera7fbd5a2016-06-16 09:17:49 -07003496 print()
3497 print('The dependent local branches of %s are:' % root_branch)
rmistry@google.com2dd99862015-06-22 12:22:18 +00003498 dependents = []
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003499
rmistry@google.com2dd99862015-06-22 12:22:18 +00003500 def traverse_dependents_preorder(branch, padding=''):
3501 dependents_to_process = tracked_to_dependents.get(branch, [])
3502 padding += ' '
3503 for dependent in dependents_to_process:
vapiera7fbd5a2016-06-16 09:17:49 -07003504 print('%s%s' % (padding, dependent))
rmistry@google.com2dd99862015-06-22 12:22:18 +00003505 dependents.append(dependent)
3506 traverse_dependents_preorder(dependent, padding)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003507
rmistry@google.com2dd99862015-06-22 12:22:18 +00003508 traverse_dependents_preorder(root_branch)
vapiera7fbd5a2016-06-16 09:17:49 -07003509 print()
rmistry@google.com2dd99862015-06-22 12:22:18 +00003510
3511 if not dependents:
vapiera7fbd5a2016-06-16 09:17:49 -07003512 print('There are no dependent local branches for %s' % root_branch)
rmistry@google.com2dd99862015-06-22 12:22:18 +00003513 return 0
3514
Jose Lopes3863fc52020-04-07 17:00:25 +00003515 if not force:
3516 confirm_or_exit('This command will checkout all dependent branches and run '
3517 '"git cl upload".', action='continue')
rmistry@google.com2dd99862015-06-22 12:22:18 +00003518
rmistry@google.com2dd99862015-06-22 12:22:18 +00003519 # Record all dependents that failed to upload.
3520 failures = {}
3521 # Go through all dependents, checkout the branch and upload.
3522 try:
3523 for dependent_branch in dependents:
vapiera7fbd5a2016-06-16 09:17:49 -07003524 print()
3525 print('--------------------------------------')
3526 print('Running "git cl upload" from %s:' % dependent_branch)
rmistry@google.com2dd99862015-06-22 12:22:18 +00003527 RunGit(['checkout', '-q', dependent_branch])
vapiera7fbd5a2016-06-16 09:17:49 -07003528 print()
rmistry@google.com2dd99862015-06-22 12:22:18 +00003529 try:
3530 if CMDupload(OptionParser(), args) != 0:
vapiera7fbd5a2016-06-16 09:17:49 -07003531 print('Upload failed for %s!' % dependent_branch)
rmistry@google.com2dd99862015-06-22 12:22:18 +00003532 failures[dependent_branch] = 1
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -08003533 except: # pylint: disable=bare-except
rmistry@google.com2dd99862015-06-22 12:22:18 +00003534 failures[dependent_branch] = 1
vapiera7fbd5a2016-06-16 09:17:49 -07003535 print()
rmistry@google.com2dd99862015-06-22 12:22:18 +00003536 finally:
3537 # Swap back to the original root branch.
3538 RunGit(['checkout', '-q', root_branch])
3539
vapiera7fbd5a2016-06-16 09:17:49 -07003540 print()
3541 print('Upload complete for dependent branches!')
rmistry@google.com2dd99862015-06-22 12:22:18 +00003542 for dependent_branch in dependents:
3543 upload_status = 'failed' if failures.get(dependent_branch) else 'succeeded'
vapiera7fbd5a2016-06-16 09:17:49 -07003544 print(' %s : %s' % (dependent_branch, upload_status))
3545 print()
rmistry@google.com2dd99862015-06-22 12:22:18 +00003546
3547 return 0
3548
3549
Tibor Goldschwendt7c5efb22020-03-25 01:23:54 +00003550def GetArchiveTagForBranch(issue_num, branch_name, existing_tags, pattern):
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00003551 """Given a proposed tag name, returns a tag name that is guaranteed to be
3552 unique. If 'foo' is proposed but already exists, then 'foo-2' is used,
3553 or 'foo-3', and so on."""
3554
Tibor Goldschwendt7c5efb22020-03-25 01:23:54 +00003555 proposed_tag = pattern.format(**{'issue': issue_num, 'branch': branch_name})
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00003556 for suffix_num in itertools.count(1):
3557 if suffix_num == 1:
3558 to_check = proposed_tag
3559 else:
3560 to_check = '%s-%d' % (proposed_tag, suffix_num)
3561
3562 if to_check not in existing_tags:
3563 return to_check
3564
3565
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003566@metrics.collector.collect_metrics('git cl archive')
kmarshall3bff56b2016-06-06 18:31:47 -07003567def CMDarchive(parser, args):
3568 """Archives and deletes branches associated with closed changelists."""
3569 parser.add_option(
3570 '-j', '--maxjobs', action='store', type=int,
kmarshall9249e012016-08-23 12:02:16 -07003571 help='The maximum number of jobs to use when retrieving review status.')
kmarshall3bff56b2016-06-06 18:31:47 -07003572 parser.add_option(
3573 '-f', '--force', action='store_true',
3574 help='Bypasses the confirmation prompt.')
kmarshall9249e012016-08-23 12:02:16 -07003575 parser.add_option(
3576 '-d', '--dry-run', action='store_true',
3577 help='Skip the branch tagging and removal steps.')
3578 parser.add_option(
3579 '-t', '--notags', action='store_true',
3580 help='Do not tag archived branches. '
3581 'Note: local commit history may be lost.')
Tibor Goldschwendt7c5efb22020-03-25 01:23:54 +00003582 parser.add_option(
3583 '-p',
3584 '--pattern',
3585 default='git-cl-archived-{issue}-{branch}',
3586 help='Format string for archive tags. '
3587 'E.g. \'archived-{issue}-{branch}\'.')
kmarshall3bff56b2016-06-06 18:31:47 -07003588
kmarshall3bff56b2016-06-06 18:31:47 -07003589 options, args = parser.parse_args(args)
3590 if args:
3591 parser.error('Unsupported args: %s' % ' '.join(args))
kmarshall3bff56b2016-06-06 18:31:47 -07003592
3593 branches = RunGit(['for-each-ref', '--format=%(refname)', 'refs/heads'])
3594 if not branches:
3595 return 0
3596
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00003597 tags = RunGit(['for-each-ref', '--format=%(refname)',
3598 'refs/tags']).splitlines() or []
3599 tags = [t.split('/')[-1] for t in tags]
3600
vapiera7fbd5a2016-06-16 09:17:49 -07003601 print('Finding all branches associated with closed issues...')
Edward Lemur934836a2019-09-09 20:16:54 +00003602 changes = [Changelist(branchref=b)
3603 for b in branches.splitlines()]
kmarshall3bff56b2016-06-06 18:31:47 -07003604 alignment = max(5, max(len(c.GetBranch()) for c in changes))
3605 statuses = get_cl_statuses(changes,
3606 fine_grained=True,
3607 max_processes=options.maxjobs)
3608 proposal = [(cl.GetBranch(),
Tibor Goldschwendt7c5efb22020-03-25 01:23:54 +00003609 GetArchiveTagForBranch(cl.GetIssue(), cl.GetBranch(), tags,
3610 options.pattern))
kmarshall3bff56b2016-06-06 18:31:47 -07003611 for cl, status in statuses
Andrii Shyshkalov51bdf8c2018-10-18 01:07:58 +00003612 if status in ('closed', 'rietveld-not-supported')]
kmarshall3bff56b2016-06-06 18:31:47 -07003613 proposal.sort()
3614
3615 if not proposal:
vapiera7fbd5a2016-06-16 09:17:49 -07003616 print('No branches with closed codereview issues found.')
kmarshall3bff56b2016-06-06 18:31:47 -07003617 return 0
3618
Edward Lemur85153282020-02-14 22:06:29 +00003619 current_branch = scm.GIT.GetBranch(settings.GetRoot())
kmarshall3bff56b2016-06-06 18:31:47 -07003620
vapiera7fbd5a2016-06-16 09:17:49 -07003621 print('\nBranches with closed issues that will be archived:\n')
kmarshall9249e012016-08-23 12:02:16 -07003622 if options.notags:
3623 for next_item in proposal:
3624 print(' ' + next_item[0])
3625 else:
3626 print('%*s | %s' % (alignment, 'Branch name', 'Archival tag name'))
3627 for next_item in proposal:
3628 print('%*s %s' % (alignment, next_item[0], next_item[1]))
kmarshall3bff56b2016-06-06 18:31:47 -07003629
kmarshall9249e012016-08-23 12:02:16 -07003630 # Quit now on precondition failure or if instructed by the user, either
3631 # via an interactive prompt or by command line flags.
3632 if options.dry_run:
3633 print('\nNo changes were made (dry run).\n')
3634 return 0
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +00003635
3636 if any(branch == current_branch for branch, _ in proposal):
kmarshall3bff56b2016-06-06 18:31:47 -07003637 print('You are currently on a branch \'%s\' which is associated with a '
3638 'closed codereview issue, so archive cannot proceed. Please '
3639 'checkout another branch and run this command again.' %
3640 current_branch)
3641 return 1
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +00003642
3643 if not options.force:
Edward Lesmesae3586b2020-03-23 21:21:14 +00003644 answer = gclient_utils.AskForData('\nProceed with deletion (Y/n)? ').lower()
sergiyb4a5ecbe2016-06-20 09:46:00 -07003645 if answer not in ('y', ''):
vapiera7fbd5a2016-06-16 09:17:49 -07003646 print('Aborted.')
kmarshall3bff56b2016-06-06 18:31:47 -07003647 return 1
3648
3649 for branch, tagname in proposal:
kmarshall9249e012016-08-23 12:02:16 -07003650 if not options.notags:
3651 RunGit(['tag', tagname, branch])
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00003652
3653 if RunGitWithCode(['branch', '-D', branch])[0] != 0:
3654 # Clean up the tag if we failed to delete the branch.
3655 RunGit(['tag', '-d', tagname])
kmarshall9249e012016-08-23 12:02:16 -07003656
vapiera7fbd5a2016-06-16 09:17:49 -07003657 print('\nJob\'s done!')
kmarshall3bff56b2016-06-06 18:31:47 -07003658
3659 return 0
3660
3661
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003662@metrics.collector.collect_metrics('git cl status')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003663def CMDstatus(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00003664 """Show status of changelists.
3665
3666 Colors are used to tell the state of the CL unless --fast is used:
jsbell@chromium.orgaeab41a2013-12-10 20:01:22 +00003667 - Blue waiting for review
Aaron Gable9ab38c62017-04-06 14:36:33 -07003668 - Yellow waiting for you to reply to review, or not yet sent
jsbell@chromium.orgaeab41a2013-12-10 20:01:22 +00003669 - Green LGTM'ed
Aaron Gable9ab38c62017-04-06 14:36:33 -07003670 - Red 'not LGTM'ed
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +00003671 - Magenta in the CQ
jsbell@chromium.orgaeab41a2013-12-10 20:01:22 +00003672 - Cyan was committed, branch can be deleted
Aaron Gable9ab38c62017-04-06 14:36:33 -07003673 - White error, or unknown status
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00003674
3675 Also see 'git cl comments'.
3676 """
Alan Cuttera3be9a52019-03-04 18:50:33 +00003677 parser.add_option(
3678 '--no-branch-color',
3679 action='store_true',
3680 help='Disable colorized branch names')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003681 parser.add_option('--field',
phajdan.jr289d03e2016-08-16 08:21:06 -07003682 help='print only specific field (desc|id|patch|status|url)')
maruel@chromium.org1033efd2013-07-23 23:25:09 +00003683 parser.add_option('-f', '--fast', action='store_true',
3684 help='Do not retrieve review status')
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00003685 parser.add_option(
3686 '-j', '--maxjobs', action='store', type=int,
3687 help='The maximum number of jobs to use when retrieving review status')
Edward Lemur52969c92020-02-06 18:15:28 +00003688 parser.add_option(
3689 '-i', '--issue', type=int,
3690 help='Operate on this issue instead of the current branch\'s implicit '
3691 'issue. Requires --field to be set.')
Sigurd Schneider9abde8c2020-11-17 08:44:52 +00003692 parser.add_option('-d',
3693 '--date-order',
3694 action='store_true',
3695 help='Order branches by committer date.')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00003696 options, args = parser.parse_args(args)
maruel@chromium.org39c0b222013-08-17 16:57:01 +00003697 if args:
3698 parser.error('Unsupported args: %s' % args)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003699
iannuccie53c9352016-08-17 14:40:40 -07003700 if options.issue is not None and not options.field:
Edward Lemur6c6827c2020-02-06 21:15:18 +00003701 parser.error('--field must be given when --issue is set.')
iannucci3c972b92016-08-17 13:24:10 -07003702
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003703 if options.field:
Edward Lemur934836a2019-09-09 20:16:54 +00003704 cl = Changelist(issue=options.issue)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003705 if options.field.startswith('desc'):
Edward Lemur6c6827c2020-02-06 21:15:18 +00003706 if cl.GetIssue():
3707 print(cl.FetchDescription())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003708 elif options.field == 'id':
3709 issueid = cl.GetIssue()
3710 if issueid:
vapiera7fbd5a2016-06-16 09:17:49 -07003711 print(issueid)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003712 elif options.field == 'patch':
Aaron Gablee8856ee2017-12-07 12:41:46 -08003713 patchset = cl.GetMostRecentPatchset()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003714 if patchset:
vapiera7fbd5a2016-06-16 09:17:49 -07003715 print(patchset)
phajdan.jr289d03e2016-08-16 08:21:06 -07003716 elif options.field == 'status':
3717 print(cl.GetStatus())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003718 elif options.field == 'url':
3719 url = cl.GetIssueURL()
3720 if url:
vapiera7fbd5a2016-06-16 09:17:49 -07003721 print(url)
maruel@chromium.orge25c75b2013-07-23 18:30:56 +00003722 return 0
3723
Sigurd Schneider9abde8c2020-11-17 08:44:52 +00003724 branches = RunGit([
3725 'for-each-ref', '--format=%(refname) %(committerdate:unix)', 'refs/heads'
3726 ])
maruel@chromium.orge25c75b2013-07-23 18:30:56 +00003727 if not branches:
3728 print('No local branch found.')
3729 return 0
3730
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003731 changes = [
Sigurd Schneider9abde8c2020-11-17 08:44:52 +00003732 Changelist(branchref=b, commit_date=ct)
3733 for b, ct in map(lambda line: line.split(' '), branches.splitlines())
3734 ]
vapiera7fbd5a2016-06-16 09:17:49 -07003735 print('Branches associated with reviews:')
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003736 output = get_cl_statuses(changes,
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00003737 fine_grained=not options.fast,
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003738 max_processes=options.maxjobs)
maruel@chromium.org1033efd2013-07-23 23:25:09 +00003739
Edward Lemur85153282020-02-14 22:06:29 +00003740 current_branch = scm.GIT.GetBranch(settings.GetRoot())
Daniel McArdlea23bf592019-02-12 00:25:12 +00003741
3742 def FormatBranchName(branch, colorize=False):
3743 """Simulates 'git branch' behavior. Colorizes and prefixes branch name with
3744 an asterisk when it is the current branch."""
3745
3746 asterisk = ""
3747 color = Fore.RESET
3748 if branch == current_branch:
3749 asterisk = "* "
3750 color = Fore.GREEN
Edward Lemur85153282020-02-14 22:06:29 +00003751 branch_name = scm.GIT.ShortBranchName(branch)
Daniel McArdlea23bf592019-02-12 00:25:12 +00003752
3753 if colorize:
3754 return asterisk + color + branch_name + Fore.RESET
Daniel McArdle452a49f2019-02-14 17:28:31 +00003755 return asterisk + branch_name
3756
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00003757 branch_statuses = {}
Daniel McArdlea23bf592019-02-12 00:25:12 +00003758
3759 alignment = max(5, max(len(FormatBranchName(c.GetBranch())) for c in changes))
Sigurd Schneider1bfda8e2021-06-30 14:46:25 +00003760
3761 if options.date_order or settings.IsStatusCommitOrderByDate():
Sigurd Schneider9abde8c2020-11-17 08:44:52 +00003762 sorted_changes = sorted(changes,
3763 key=lambda c: c.GetCommitDate(),
3764 reverse=True)
3765 else:
3766 sorted_changes = sorted(changes, key=lambda c: c.GetBranch())
3767 for cl in sorted_changes:
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003768 branch = cl.GetBranch()
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00003769 while branch not in branch_statuses:
Edward Lemur79d4f992019-11-11 23:49:02 +00003770 c, status = next(output)
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003771 branch_statuses[c.GetBranch()] = status
3772 status = branch_statuses.pop(branch)
Andrii Shyshkalov1ee78cd2020-03-12 01:31:53 +00003773 url = cl.GetIssueURL(short=True)
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003774 if url and (not status or status == 'error'):
3775 # The issue probably doesn't exist anymore.
3776 url += ' (broken)'
3777
nodir@chromium.orga6de1f42015-06-10 04:23:17 +00003778 color = color_for_status(status)
Bruce Dawsonb73f8a92020-03-27 22:03:08 +00003779 # Turn off bold as well as colors.
3780 END = '\033[0m'
3781 reset = Fore.RESET + END
iannucci@chromium.org596cd5c2016-04-04 21:34:39 +00003782 if not setup_color.IS_TTY:
maruel@chromium.org885f6512013-07-27 02:17:26 +00003783 color = ''
3784 reset = ''
nodir@chromium.orga6de1f42015-06-10 04:23:17 +00003785 status_str = '(%s)' % status if status else ''
Daniel McArdle452a49f2019-02-14 17:28:31 +00003786
Alan Cuttera3be9a52019-03-04 18:50:33 +00003787 branch_display = FormatBranchName(branch)
3788 padding = ' ' * (alignment - len(branch_display))
3789 if not options.no_branch_color:
3790 branch_display = FormatBranchName(branch, colorize=True)
Daniel McArdle452a49f2019-02-14 17:28:31 +00003791
Alan Cuttera3be9a52019-03-04 18:50:33 +00003792 print(' %s : %s%s %s%s' % (padding + branch_display, color, url,
3793 status_str, reset))
Andrii Shyshkalovd0e1d9d2017-01-24 17:10:51 +01003794
vapiera7fbd5a2016-06-16 09:17:49 -07003795 print()
Daniel McArdlea23bf592019-02-12 00:25:12 +00003796 print('Current branch: %s' % current_branch)
Andrii Shyshkalovd0e1d9d2017-01-24 17:10:51 +01003797 for cl in changes:
Daniel McArdlea23bf592019-02-12 00:25:12 +00003798 if cl.GetBranch() == current_branch:
Andrii Shyshkalovd0e1d9d2017-01-24 17:10:51 +01003799 break
dpranke@chromium.orgee87f582015-07-31 18:46:25 +00003800 if not cl.GetIssue():
vapiera7fbd5a2016-06-16 09:17:49 -07003801 print('No issue assigned.')
dpranke@chromium.orgee87f582015-07-31 18:46:25 +00003802 return 0
vapiera7fbd5a2016-06-16 09:17:49 -07003803 print('Issue number: %s (%s)' % (cl.GetIssue(), cl.GetIssueURL()))
maruel@chromium.org85616e02014-07-28 15:37:55 +00003804 if not options.fast:
vapiera7fbd5a2016-06-16 09:17:49 -07003805 print('Issue description:')
Edward Lemur6c6827c2020-02-06 21:15:18 +00003806 print(cl.FetchDescription(pretty=True))
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003807 return 0
3808
3809
maruel@chromium.org39c0b222013-08-17 16:57:01 +00003810def colorize_CMDstatus_doc():
3811 """To be called once in main() to add colors to git cl status help."""
3812 colors = [i for i in dir(Fore) if i[0].isupper()]
3813
3814 def colorize_line(line):
3815 for color in colors:
3816 if color in line.upper():
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003817 # Extract whitespace first and the leading '-'.
maruel@chromium.org39c0b222013-08-17 16:57:01 +00003818 indent = len(line) - len(line.lstrip(' ')) + 1
3819 return line[:indent] + getattr(Fore, color) + line[indent:] + Fore.RESET
3820 return line
3821
3822 lines = CMDstatus.__doc__.splitlines()
3823 CMDstatus.__doc__ = '\n'.join(colorize_line(l) for l in lines)
3824
3825
phajdan.jre328cf92016-08-22 04:12:17 -07003826def write_json(path, contents):
Stefan Zager1306bd02017-06-22 19:26:46 -07003827 if path == '-':
3828 json.dump(contents, sys.stdout)
3829 else:
3830 with open(path, 'w') as f:
3831 json.dump(contents, f)
phajdan.jre328cf92016-08-22 04:12:17 -07003832
3833
maruel@chromium.org0633fb42013-08-16 20:06:14 +00003834@subcommand.usage('[issue_number]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003835@metrics.collector.collect_metrics('git cl issue')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003836def CMDissue(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00003837 """Sets or displays the current code review issue number.
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003838
3839 Pass issue number 0 to clear the current issue.
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00003840 """
dnj@chromium.org406c4402015-03-03 17:22:28 +00003841 parser.add_option('-r', '--reverse', action='store_true',
3842 help='Lookup the branch(es) for the specified issues. If '
3843 'no issues are specified, all branches with mapped '
3844 'issues will be listed.')
Stefan Zager1306bd02017-06-22 19:26:46 -07003845 parser.add_option('--json',
3846 help='Path to JSON output file, or "-" for stdout.')
dnj@chromium.org406c4402015-03-03 17:22:28 +00003847 options, args = parser.parse_args(args)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003848
dnj@chromium.org406c4402015-03-03 17:22:28 +00003849 if options.reverse:
3850 branches = RunGit(['for-each-ref', 'refs/heads',
Aaron Gablead64abd2017-12-04 09:49:13 -08003851 '--format=%(refname)']).splitlines()
dnj@chromium.org406c4402015-03-03 17:22:28 +00003852 # Reverse issue lookup.
3853 issue_branch_map = {}
Daniel Bratellb56a43a2018-09-06 15:49:03 +00003854
3855 git_config = {}
3856 for config in RunGit(['config', '--get-regexp',
3857 r'branch\..*issue']).splitlines():
3858 name, _space, val = config.partition(' ')
3859 git_config[name] = val
3860
dnj@chromium.org406c4402015-03-03 17:22:28 +00003861 for branch in branches:
Edward Lesmes50da7702020-03-30 19:23:43 +00003862 issue = git_config.get(
3863 'branch.%s.%s' % (scm.GIT.ShortBranchName(branch), ISSUE_CONFIG_KEY))
Edward Lemur52969c92020-02-06 18:15:28 +00003864 if issue:
3865 issue_branch_map.setdefault(int(issue), []).append(branch)
dnj@chromium.org406c4402015-03-03 17:22:28 +00003866 if not args:
Carlos Caballero81923d62020-07-06 18:22:27 +00003867 args = sorted(issue_branch_map.keys())
phajdan.jre328cf92016-08-22 04:12:17 -07003868 result = {}
dnj@chromium.org406c4402015-03-03 17:22:28 +00003869 for issue in args:
Lei Zhang5a368d42019-03-25 23:18:19 +00003870 try:
3871 issue_num = int(issue)
3872 except ValueError:
3873 print('ERROR cannot parse issue number: %s' % issue, file=sys.stderr)
dnj@chromium.org406c4402015-03-03 17:22:28 +00003874 continue
Lei Zhang5a368d42019-03-25 23:18:19 +00003875 result[issue_num] = issue_branch_map.get(issue_num)
vapiera7fbd5a2016-06-16 09:17:49 -07003876 print('Branch for issue number %s: %s' % (
Lei Zhang5a368d42019-03-25 23:18:19 +00003877 issue, ', '.join(issue_branch_map.get(issue_num) or ('None',))))
phajdan.jre328cf92016-08-22 04:12:17 -07003878 if options.json:
3879 write_json(options.json, result)
Aaron Gable78753da2017-06-15 10:35:49 -07003880 return 0
3881
3882 if len(args) > 0:
Edward Lemurf38bc172019-09-03 21:02:13 +00003883 issue = ParseIssueNumberArgument(args[0])
Aaron Gable78753da2017-06-15 10:35:49 -07003884 if not issue.valid:
3885 DieWithError('Pass a url or number to set the issue, 0 to unset it, '
3886 'or no argument to list it.\n'
3887 'Maybe you want to run git cl status?')
Edward Lemurf38bc172019-09-03 21:02:13 +00003888 cl = Changelist()
Aaron Gable78753da2017-06-15 10:35:49 -07003889 cl.SetIssue(issue.issue)
dnj@chromium.org406c4402015-03-03 17:22:28 +00003890 else:
Edward Lemurf38bc172019-09-03 21:02:13 +00003891 cl = Changelist()
Aaron Gable78753da2017-06-15 10:35:49 -07003892 print('Issue number: %s (%s)' % (cl.GetIssue(), cl.GetIssueURL()))
3893 if options.json:
3894 write_json(options.json, {
Nodir Turakulov27379632021-03-17 18:53:29 +00003895 'gerrit_host': cl.GetGerritHost(),
3896 'gerrit_project': cl.GetGerritProject(),
Aaron Gable78753da2017-06-15 10:35:49 -07003897 'issue_url': cl.GetIssueURL(),
Nodir Turakulov27379632021-03-17 18:53:29 +00003898 'issue': cl.GetIssue(),
Aaron Gable78753da2017-06-15 10:35:49 -07003899 })
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003900 return 0
3901
3902
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003903@metrics.collector.collect_metrics('git cl comments')
maruel@chromium.org9977a2e2012-06-06 22:30:56 +00003904def CMDcomments(parser, args):
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003905 """Shows or posts review comments for any changelist."""
3906 parser.add_option('-a', '--add-comment', dest='comment',
3907 help='comment to add to an issue')
Sergiy Byelozyorovcb629a42018-10-28 19:20:39 +00003908 parser.add_option('-p', '--publish', action='store_true',
3909 help='marks CL as ready and sends comment to reviewers')
Andrii Shyshkalov0d6b46e2017-03-17 22:23:22 +01003910 parser.add_option('-i', '--issue', dest='issue',
Edward Lemurf38bc172019-09-03 21:02:13 +00003911 help='review issue id (defaults to current issue).')
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07003912 parser.add_option('-m', '--machine-readable', dest='readable',
3913 action='store_false', default=True,
3914 help='output comments in a format compatible with '
3915 'editor parsing')
smut@google.comc85ac942015-09-15 16:34:43 +00003916 parser.add_option('-j', '--json-file',
Stefan Zager1306bd02017-06-22 19:26:46 -07003917 help='File to write JSON summary to, or "-" for stdout')
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003918 options, args = parser.parse_args(args)
maruel@chromium.org9977a2e2012-06-06 22:30:56 +00003919
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003920 issue = None
3921 if options.issue:
3922 try:
3923 issue = int(options.issue)
3924 except ValueError:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00003925 DieWithError('A review issue ID is expected to be a number.')
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003926
Edward Lemur934836a2019-09-09 20:16:54 +00003927 cl = Changelist(issue=issue)
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003928
3929 if options.comment:
Sergiy Byelozyorovcb629a42018-10-28 19:20:39 +00003930 cl.AddComment(options.comment, options.publish)
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003931 return 0
3932
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07003933 summary = sorted(cl.GetCommentsSummary(readable=options.readable),
3934 key=lambda c: c.date)
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01003935 for comment in summary:
3936 if comment.disapproval:
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003937 color = Fore.RED
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01003938 elif comment.approval:
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003939 color = Fore.GREEN
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01003940 elif comment.sender == cl.GetIssueOwner():
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003941 color = Fore.MAGENTA
Quinten Yearsley0e617c02019-02-20 00:37:03 +00003942 elif comment.autogenerated:
3943 color = Fore.CYAN
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003944 else:
3945 color = Fore.BLUE
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01003946 print('\n%s%s %s%s\n%s' % (
3947 color,
3948 comment.date.strftime('%Y-%m-%d %H:%M:%S UTC'),
3949 comment.sender,
3950 Fore.RESET,
3951 '\n'.join(' ' + l for l in comment.message.strip().splitlines())))
3952
smut@google.comc85ac942015-09-15 16:34:43 +00003953 if options.json_file:
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01003954 def pre_serialize(c):
Edward Lemur79d4f992019-11-11 23:49:02 +00003955 dct = c._asdict().copy()
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01003956 dct['date'] = dct['date'].strftime('%Y-%m-%d %H:%M:%S.%f')
3957 return dct
Edward Lemur79d4f992019-11-11 23:49:02 +00003958 write_json(options.json_file, [pre_serialize(x) for x in summary])
maruel@chromium.org9977a2e2012-06-06 22:30:56 +00003959 return 0
3960
3961
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00003962@subcommand.usage('[codereview url or issue id]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003963@metrics.collector.collect_metrics('git cl description')
rsesek@chromium.orgeec76592013-05-20 16:27:57 +00003964def CMDdescription(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00003965 """Brings up the editor for the current CL's description."""
smut@google.com34fb6b12015-07-13 20:03:26 +00003966 parser.add_option('-d', '--display', action='store_true',
3967 help='Display the description instead of opening an editor')
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00003968 parser.add_option('-n', '--new-description',
dnjba1b0f32016-09-02 12:37:42 -07003969 help='New description to set for this issue (- for stdin, '
3970 '+ to load from local commit HEAD)')
dsansomee2d6fd92016-09-08 00:10:47 -07003971 parser.add_option('-f', '--force', action='store_true',
3972 help='Delete any unpublished Gerrit edits for this issue '
3973 'without prompting')
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00003974
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00003975 options, args = parser.parse_args(args)
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00003976
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01003977 target_issue_arg = None
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00003978 if len(args) > 0:
Edward Lemurf38bc172019-09-03 21:02:13 +00003979 target_issue_arg = ParseIssueNumberArgument(args[0])
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01003980 if not target_issue_arg.valid:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00003981 parser.error('Invalid issue ID or URL.')
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00003982
Edward Lemur934836a2019-09-09 20:16:54 +00003983 kwargs = {}
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01003984 if target_issue_arg:
3985 kwargs['issue'] = target_issue_arg.issue
3986 kwargs['codereview_host'] = target_issue_arg.hostname
martiniss6eda05f2016-06-30 10:18:35 -07003987
3988 cl = Changelist(**kwargs)
rsesek@chromium.orgeec76592013-05-20 16:27:57 +00003989 if not cl.GetIssue():
3990 DieWithError('This branch has no associated changelist.')
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02003991
Edward Lemur678a6842019-10-03 22:25:05 +00003992 if args and not args[0].isdigit():
Edward Lemurf38bc172019-09-03 21:02:13 +00003993 logging.info('canonical issue/change URL: %s\n', cl.GetIssueURL())
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02003994
Edward Lemur6c6827c2020-02-06 21:15:18 +00003995 description = ChangeDescription(cl.FetchDescription())
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00003996
smut@google.com34fb6b12015-07-13 20:03:26 +00003997 if options.display:
vapiera7fbd5a2016-06-16 09:17:49 -07003998 print(description.description)
smut@google.com34fb6b12015-07-13 20:03:26 +00003999 return 0
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00004000
4001 if options.new_description:
4002 text = options.new_description
4003 if text == '-':
4004 text = '\n'.join(l.rstrip() for l in sys.stdin)
dnjba1b0f32016-09-02 12:37:42 -07004005 elif text == '+':
4006 base_branch = cl.GetCommonAncestorWithUpstream()
Edward Lemura12175c2020-03-09 16:58:26 +00004007 text = _create_description_from_log([base_branch])
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00004008
4009 description.set_description(text)
4010 else:
Edward Lemurf38bc172019-09-03 21:02:13 +00004011 description.prompt()
Edward Lemur6c6827c2020-02-06 21:15:18 +00004012 if cl.FetchDescription().strip() != description.description:
dsansomee2d6fd92016-09-08 00:10:47 -07004013 cl.UpdateDescription(description.description, force=options.force)
rsesek@chromium.orgeec76592013-05-20 16:27:57 +00004014 return 0
4015
4016
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004017@metrics.collector.collect_metrics('git cl lint')
thestig@chromium.org44202a22014-03-11 19:22:18 +00004018def CMDlint(parser, args):
4019 """Runs cpplint on the current changelist."""
tzik@chromium.orgf204d4b2014-03-13 07:40:55 +00004020 parser.add_option('--filter', action='append', metavar='-x,+y',
4021 help='Comma-separated list of cpplint\'s category-filters')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004022 options, args = parser.parse_args(args)
thestig@chromium.org44202a22014-03-11 19:22:18 +00004023
4024 # Access to a protected member _XX of a client class
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -08004025 # pylint: disable=protected-access
thestig@chromium.org44202a22014-03-11 19:22:18 +00004026 try:
4027 import cpplint
4028 import cpplint_chromium
4029 except ImportError:
vapiera7fbd5a2016-06-16 09:17:49 -07004030 print('Your depot_tools is missing cpplint.py and/or cpplint_chromium.py.')
thestig@chromium.org44202a22014-03-11 19:22:18 +00004031 return 1
4032
4033 # Change the current working directory before calling lint so that it
4034 # shows the correct base.
4035 previous_cwd = os.getcwd()
4036 os.chdir(settings.GetRoot())
4037 try:
Edward Lemur934836a2019-09-09 20:16:54 +00004038 cl = Changelist()
Edward Lemur2c62b332020-03-12 22:12:33 +00004039 files = cl.GetAffectedFiles(cl.GetCommonAncestorWithUpstream())
thestig@chromium.org5839eb52014-05-30 16:20:51 +00004040 if not files:
vapiera7fbd5a2016-06-16 09:17:49 -07004041 print('Cannot lint an empty CL')
thestig@chromium.org5839eb52014-05-30 16:20:51 +00004042 return 1
thestig@chromium.org44202a22014-03-11 19:22:18 +00004043
Lei Zhangb8c62cf2020-07-15 20:09:37 +00004044 # Process cpplint arguments, if any.
4045 filters = presubmit_canned_checks.GetCppLintFilters(options.filter)
4046 command = ['--filter=' + ','.join(filters)] + args + files
tzik@chromium.orgf204d4b2014-03-13 07:40:55 +00004047 filenames = cpplint.ParseArguments(command)
thestig@chromium.org44202a22014-03-11 19:22:18 +00004048
Lei Zhang379d1ad2020-07-15 19:40:06 +00004049 include_regex = re.compile(settings.GetLintRegex())
4050 ignore_regex = re.compile(settings.GetLintIgnoreRegex())
thestig@chromium.org44202a22014-03-11 19:22:18 +00004051 extra_check_functions = [cpplint_chromium.CheckPointerDeclarationWhitespace]
4052 for filename in filenames:
Lei Zhang379d1ad2020-07-15 19:40:06 +00004053 if not include_regex.match(filename):
vapiera7fbd5a2016-06-16 09:17:49 -07004054 print('Skipping file %s' % filename)
Lei Zhang379d1ad2020-07-15 19:40:06 +00004055 continue
4056
4057 if ignore_regex.match(filename):
4058 print('Ignoring file %s' % filename)
4059 continue
4060
4061 cpplint.ProcessFile(filename, cpplint._cpplint_state.verbose_level,
4062 extra_check_functions)
thestig@chromium.org44202a22014-03-11 19:22:18 +00004063 finally:
4064 os.chdir(previous_cwd)
vapiera7fbd5a2016-06-16 09:17:49 -07004065 print('Total errors found: %d\n' % cpplint._cpplint_state.error_count)
thestig@chromium.org44202a22014-03-11 19:22:18 +00004066 if cpplint._cpplint_state.error_count != 0:
4067 return 1
4068 return 0
4069
4070
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004071@metrics.collector.collect_metrics('git cl presubmit')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004072def CMDpresubmit(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004073 """Runs presubmit tests on the current changelist."""
ilevy@chromium.org375a9022013-01-07 01:12:05 +00004074 parser.add_option('-u', '--upload', action='store_true',
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004075 help='Run upload hook instead of the push hook')
ilevy@chromium.org375a9022013-01-07 01:12:05 +00004076 parser.add_option('-f', '--force', action='store_true',
sbc@chromium.org495ad152012-09-04 23:07:42 +00004077 help='Run checks even if tree is dirty')
Aaron Gable8076c282017-11-29 14:39:41 -08004078 parser.add_option('--all', action='store_true',
4079 help='Run checks against all files, not just modified ones')
Josip Sokcevic017544d2022-03-31 23:47:53 +00004080 parser.add_option('--files',
4081 nargs=1,
4082 help='Semicolon-separated list of files to be marked as '
4083 'modified when executing presubmit or post-upload hooks. '
4084 'fnmatch wildcards can also be used.')
Edward Lesmes8e282792018-04-03 18:50:29 -04004085 parser.add_option('--parallel', action='store_true',
4086 help='Run all tests specified by input_api.RunTests in all '
4087 'PRESUBMIT files in parallel.')
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00004088 parser.add_option('--resultdb', action='store_true',
4089 help='Run presubmit checks in the ResultSink environment '
4090 'and send results to the ResultDB database.')
Saagar Sanghavi03b15132020-08-10 16:43:41 +00004091 parser.add_option('--realm', help='LUCI realm if reporting to ResultDB')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004092 options, args = parser.parse_args(args)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004093
sbc@chromium.org71437c02015-04-09 19:29:40 +00004094 if not options.force and git_common.is_dirty_git_tree('presubmit'):
vapiera7fbd5a2016-06-16 09:17:49 -07004095 print('use --force to check even if tree is dirty.')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004096 return 1
4097
Edward Lemur934836a2019-09-09 20:16:54 +00004098 cl = Changelist()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004099 if args:
4100 base_branch = args[0]
4101 else:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00004102 # Default to diffing against the common ancestor of the upstream branch.
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00004103 base_branch = cl.GetCommonAncestorWithUpstream()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004104
Gregory Nisbet29d5cf82020-02-27 08:16:58 +00004105 if cl.GetIssue():
4106 description = cl.FetchDescription()
Aaron Gable8076c282017-11-29 14:39:41 -08004107 else:
Edward Lemura12175c2020-03-09 16:58:26 +00004108 description = _create_description_from_log([base_branch])
Aaron Gable8076c282017-11-29 14:39:41 -08004109
Josip Sokcevic017544d2022-03-31 23:47:53 +00004110 cl.RunHook(committing=not options.upload,
4111 may_prompt=False,
4112 verbose=options.verbose,
4113 parallel=options.parallel,
4114 upstream=base_branch,
4115 description=description,
4116 all_files=options.all,
4117 files=options.files,
4118 resultdb=options.resultdb,
4119 realm=options.realm)
dpranke@chromium.org0a2bb372011-03-25 01:16:22 +00004120 return 0
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004121
4122
tandrii@chromium.org65874e12016-03-04 12:03:02 +00004123def GenerateGerritChangeId(message):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004124 """Returns the Change ID footer value (Ixxxxxx...xxx).
tandrii@chromium.org65874e12016-03-04 12:03:02 +00004125
4126 Works the same way as
4127 https://gerrit-review.googlesource.com/tools/hooks/commit-msg
4128 but can be called on demand on all platforms.
4129
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004130 The basic idea is to generate git hash of a state of the tree, original
4131 commit message, author/committer info and timestamps.
tandrii@chromium.org65874e12016-03-04 12:03:02 +00004132 """
4133 lines = []
4134 tree_hash = RunGitSilent(['write-tree'])
4135 lines.append('tree %s' % tree_hash.strip())
4136 code, parent = RunGitWithCode(['rev-parse', 'HEAD~0'], suppress_stderr=False)
4137 if code == 0:
4138 lines.append('parent %s' % parent.strip())
4139 author = RunGitSilent(['var', 'GIT_AUTHOR_IDENT'])
4140 lines.append('author %s' % author.strip())
4141 committer = RunGitSilent(['var', 'GIT_COMMITTER_IDENT'])
4142 lines.append('committer %s' % committer.strip())
4143 lines.append('')
4144 # Note: Gerrit's commit-hook actually cleans message of some lines and
4145 # whitespace. This code is not doing this, but it clearly won't decrease
4146 # entropy.
4147 lines.append(message)
4148 change_hash = RunCommand(['git', 'hash-object', '-t', 'commit', '--stdin'],
Raul Tambreb946b232019-03-26 14:48:46 +00004149 stdin=('\n'.join(lines)).encode())
tandrii@chromium.org65874e12016-03-04 12:03:02 +00004150 return 'I%s' % change_hash.strip()
4151
4152
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01004153def GetTargetRef(remote, remote_branch, target_branch):
wittman@chromium.org455dc922015-01-26 20:15:50 +00004154 """Computes the remote branch ref to use for the CL.
4155
4156 Args:
4157 remote (str): The git remote for the CL.
4158 remote_branch (str): The git remote branch for the CL.
4159 target_branch (str): The target branch specified by the user.
wittman@chromium.org455dc922015-01-26 20:15:50 +00004160 """
4161 if not (remote and remote_branch):
4162 return None
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00004163
wittman@chromium.org455dc922015-01-26 20:15:50 +00004164 if target_branch:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07004165 # Canonicalize branch references to the equivalent local full symbolic
wittman@chromium.org455dc922015-01-26 20:15:50 +00004166 # refs, which are then translated into the remote full symbolic refs
4167 # below.
4168 if '/' not in target_branch:
4169 remote_branch = 'refs/remotes/%s/%s' % (remote, target_branch)
4170 else:
4171 prefix_replacements = (
4172 ('^((refs/)?remotes/)?branch-heads/', 'refs/remotes/branch-heads/'),
4173 ('^((refs/)?remotes/)?%s/' % remote, 'refs/remotes/%s/' % remote),
4174 ('^(refs/)?heads/', 'refs/remotes/%s/' % remote),
4175 )
4176 match = None
4177 for regex, replacement in prefix_replacements:
4178 match = re.search(regex, target_branch)
4179 if match:
4180 remote_branch = target_branch.replace(match.group(0), replacement)
4181 break
4182 if not match:
4183 # This is a branch path but not one we recognize; use as-is.
4184 remote_branch = target_branch
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +00004185 # pylint: disable=consider-using-get
rmistry@google.comc68112d2015-03-03 12:48:06 +00004186 elif remote_branch in REFS_THAT_ALIAS_TO_OTHER_REFS:
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +00004187 # pylint: enable=consider-using-get
rmistry@google.comc68112d2015-03-03 12:48:06 +00004188 # Handle the refs that need to land in different refs.
4189 remote_branch = REFS_THAT_ALIAS_TO_OTHER_REFS[remote_branch]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00004190
wittman@chromium.org455dc922015-01-26 20:15:50 +00004191 # Create the true path to the remote branch.
4192 # Does the following translation:
4193 # * refs/remotes/origin/refs/diff/test -> refs/diff/test
Josip Sokcevicc39ab992020-09-24 20:09:15 +00004194 # * refs/remotes/origin/main -> refs/heads/main
wittman@chromium.org455dc922015-01-26 20:15:50 +00004195 # * refs/remotes/branch-heads/test -> refs/branch-heads/test
4196 if remote_branch.startswith('refs/remotes/%s/refs/' % remote):
4197 remote_branch = remote_branch.replace('refs/remotes/%s/' % remote, '')
4198 elif remote_branch.startswith('refs/remotes/%s/' % remote):
4199 remote_branch = remote_branch.replace('refs/remotes/%s/' % remote,
4200 'refs/heads/')
4201 elif remote_branch.startswith('refs/remotes/branch-heads'):
4202 remote_branch = remote_branch.replace('refs/remotes/', 'refs/')
Andrii Shyshkalov768f1d82016-12-08 15:10:13 +01004203
wittman@chromium.org455dc922015-01-26 20:15:50 +00004204 return remote_branch
4205
4206
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00004207def cleanup_list(l):
4208 """Fixes a list so that comma separated items are put as individual items.
4209
4210 So that "--reviewers joe@c,john@c --reviewers joa@c" results in
4211 options.reviewers == sorted(['joe@c', 'john@c', 'joa@c']).
4212 """
4213 items = sum((i.split(',') for i in l), [])
4214 stripped_items = (i.strip() for i in items)
4215 return sorted(filter(None, stripped_items))
4216
4217
Aaron Gable4db38df2017-11-03 14:59:07 -07004218@subcommand.usage('[flags]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004219@metrics.collector.collect_metrics('git cl upload')
ukai@chromium.orge8077812012-02-03 03:41:46 +00004220def CMDupload(parser, args):
rmistry@google.com78948ed2015-07-08 23:09:57 +00004221 """Uploads the current changelist to codereview.
4222
4223 Can skip dependency patchset uploads for a branch by running:
4224 git config branch.branch_name.skip-deps-uploads True
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004225 To unset, run:
rmistry@google.com78948ed2015-07-08 23:09:57 +00004226 git config --unset branch.branch_name.skip-deps-uploads
4227 Can also set the above globally by using the --global flag.
Dominic Battre7d1c4842017-10-27 09:17:28 +02004228
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004229 If the name of the checked out branch starts with "bug-" or "fix-" followed
4230 by a bug number, this bug number is automatically populated in the CL
Dominic Battre7d1c4842017-10-27 09:17:28 +02004231 description.
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004232
4233 If subject contains text in square brackets or has "<text>: " prefix, such
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004234 text(s) is treated as Gerrit hashtags. For example, CLs with subjects:
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004235 [git-cl] add support for hashtags
4236 Foo bar: implement foo
4237 will be hashtagged with "git-cl" and "foo-bar" respectively.
rmistry@google.com78948ed2015-07-08 23:09:57 +00004238 """
ukai@chromium.orge8077812012-02-03 03:41:46 +00004239 parser.add_option('--bypass-hooks', action='store_true', dest='bypass_hooks',
4240 help='bypass upload presubmit hook')
brettw@chromium.orgb65c43c2013-06-10 22:04:49 +00004241 parser.add_option('--bypass-watchlists', action='store_true',
4242 dest='bypass_watchlists',
4243 help='bypass watchlists auto CC-ing reviewers')
Aaron Gablef7543cd2017-07-20 14:26:31 -07004244 parser.add_option('-f', '--force', action='store_true', dest='force',
ukai@chromium.orge8077812012-02-03 03:41:46 +00004245 help="force yes to questions (don't prompt)")
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004246 parser.add_option('--message', '-m', dest='message',
4247 help='message for patchset')
tandriif9aefb72016-07-01 09:06:51 -07004248 parser.add_option('-b', '--bug',
4249 help='pre-populate the bug number(s) for this issue. '
4250 'If several, separate with commas')
tandriib80458a2016-06-23 12:20:07 -07004251 parser.add_option('--message-file', dest='message_file',
4252 help='file which contains message for patchset')
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004253 parser.add_option('--title', '-t', dest='title',
4254 help='title for patchset')
Mario Bianuccicebfb4e2020-07-22 23:08:16 +00004255 parser.add_option('-T', '--skip-title', action='store_true',
4256 dest='skip_title',
4257 help='Use the most recent commit message as the title of '
4258 'the patchset')
ukai@chromium.orge8077812012-02-03 03:41:46 +00004259 parser.add_option('-r', '--reviewers',
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00004260 action='append', default=[],
ukai@chromium.orge8077812012-02-03 03:41:46 +00004261 help='reviewer email addresses')
Robert Iannucci6c98dc62017-04-18 11:38:00 -07004262 parser.add_option('--tbrs',
4263 action='append', default=[],
4264 help='TBR email addresses')
ukai@chromium.orge8077812012-02-03 03:41:46 +00004265 parser.add_option('--cc',
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00004266 action='append', default=[],
ukai@chromium.orge8077812012-02-03 03:41:46 +00004267 help='cc email addresses')
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004268 parser.add_option('--hashtag', dest='hashtags',
4269 action='append', default=[],
4270 help=('Gerrit hashtag for new CL; '
4271 'can be applied multiple times'))
adamk@chromium.org36f47302013-04-05 01:08:31 +00004272 parser.add_option('-s', '--send-mail', action='store_true',
Aaron Gable59f48512017-01-12 10:54:46 -08004273 help='send email to reviewer(s) and cc(s) immediately')
ukai@chromium.org8ef7ab22012-11-28 04:24:52 +00004274 parser.add_option('--target_branch',
pgervais@chromium.orgb9f27512014-08-08 15:52:33 +00004275 '--target-branch',
wittman@chromium.org455dc922015-01-26 20:15:50 +00004276 metavar='TARGET',
4277 help='Apply CL to remote ref TARGET. ' +
Josip Sokcevicc39ab992020-09-24 20:09:15 +00004278 'Default: remote branch head, or main')
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00004279 parser.add_option('--squash', action='store_true',
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004280 help='Squash multiple commits into one')
Mike Frysingera989d552019-08-14 20:51:23 +00004281 parser.add_option('--no-squash', action='store_false', dest='squash',
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004282 help='Don\'t squash multiple commits into one')
rmistry9eadede2016-09-19 11:22:43 -07004283 parser.add_option('--topic', default=None,
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004284 help='Topic to specify when uploading')
Robert Iannuccif2708bd2017-04-17 15:49:02 -07004285 parser.add_option('--tbr-owners', dest='add_owners_to', action='store_const',
4286 const='TBR', help='add a set of OWNERS to TBR')
4287 parser.add_option('--r-owners', dest='add_owners_to', action='store_const',
4288 const='R', help='add a set of OWNERS to R')
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +00004289 parser.add_option('-c', '--use-commit-queue', action='store_true',
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004290 default=False,
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +00004291 help='tell the CQ to commit this patchset; '
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004292 'implies --send-mail')
4293 parser.add_option('-d', '--cq-dry-run',
4294 action='store_true', default=False,
rmistry@google.comef966222015-04-07 11:15:01 +00004295 help='Send the patchset to do a CQ dry run right after '
4296 'upload.')
Greg Gutermanbe5fccd2021-06-14 17:58:20 +00004297 parser.add_option(
4298 '-q',
4299 '--cq-quick-run',
4300 action='store_true',
4301 default=False,
4302 help='Send the patchset to do a CQ quick run right after '
4303 'upload (https://source.chromium.org/chromium/chromium/src/+/main:do'
4304 'cs/cq_quick_run.md) (chromium only).')
Edward Lesmes10c3dd62021-02-08 21:13:57 +00004305 parser.add_option('--set-bot-commit', action='store_true',
4306 help=optparse.SUPPRESS_HELP)
Andrii Shyshkalov71f0da32019-07-15 22:45:18 +00004307 parser.add_option('--preserve-tryjobs', action='store_true',
4308 help='instruct the CQ to let tryjobs running even after '
4309 'new patchsets are uploaded instead of canceling '
4310 'prior patchset\' tryjobs')
rmistry@google.com2dd99862015-06-22 12:22:18 +00004311 parser.add_option('--dependencies', action='store_true',
4312 help='Uploads CLs of all the local branches that depend on '
4313 'the current branch')
Ravi Mistry31e7d562018-04-02 12:53:57 -04004314 parser.add_option('-a', '--enable-auto-submit', action='store_true',
4315 help='Sends your change to the CQ after an approval. Only '
4316 'works on repos that have the Auto-Submit label '
4317 'enabled')
Edward Lesmes8e282792018-04-03 18:50:29 -04004318 parser.add_option('--parallel', action='store_true',
4319 help='Run all tests specified by input_api.RunTests in all '
4320 'PRESUBMIT files in parallel.')
Sergiy Byelozyorov1aa405f2018-09-18 17:38:43 +00004321 parser.add_option('--no-autocc', action='store_true',
4322 help='Disables automatic addition of CC emails')
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004323 parser.add_option('--private', action='store_true',
Sergiy Byelozyorov1aa405f2018-09-18 17:38:43 +00004324 help='Set the review private. This implies --no-autocc.')
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004325 parser.add_option('-R', '--retry-failed', action='store_true',
4326 help='Retry failed tryjobs from old patchset immediately '
4327 'after uploading new patchset. Cannot be used with '
4328 '--use-commit-queue or --cq-dry-run.')
4329 parser.add_option('--buildbucket-host', default='cr-buildbucket.appspot.com',
4330 help='Host of buildbucket. The default host is %default.')
Dan Beamd8b04ca2019-10-10 21:23:26 +00004331 parser.add_option('--fixed', '-x',
4332 help='List of bugs that will be commented on and marked '
4333 'fixed (pre-populates "Fixed:" tag). Same format as '
4334 '-b option / "Bug:" tag. If fixing several issues, '
4335 'separate with commas.')
Josipe827b0f2020-01-30 00:07:20 +00004336 parser.add_option('--edit-description', action='store_true', default=False,
4337 help='Modify description before upload. Cannot be used '
4338 'with --force. It is a noop when --no-squash is set '
4339 'or a new commit is created.')
Ng Zhi Ancdaf0be2020-05-27 20:57:28 +00004340 parser.add_option('--git-completion-helper', action="store_true",
4341 help=optparse.SUPPRESS_HELP)
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00004342 parser.add_option('--resultdb', action='store_true',
4343 help='Run presubmit checks in the ResultSink environment '
4344 'and send results to the ResultDB database.')
Saagar Sanghavi03b15132020-08-10 16:43:41 +00004345 parser.add_option('--realm', help='LUCI realm if reporting to ResultDB')
Josip Sokcevicf2cfd3d2021-03-30 18:39:18 +00004346 parser.add_option('-o',
4347 '--push-options',
4348 action='append',
4349 default=[],
4350 help='Transmit the given string to the server when '
4351 'performing git push (pass-through). See git-push '
4352 'documentation for more details.')
Gregory Nisbet48d9e1e2021-04-15 23:35:54 +00004353 parser.add_option('--no-add-changeid',
4354 action='store_true',
4355 dest='no_add_changeid',
4356 help='Do not add change-ids to messages.')
Sergiy Byelozyorov1aa405f2018-09-18 17:38:43 +00004357
rmistry@google.com2dd99862015-06-22 12:22:18 +00004358 orig_args = args
ukai@chromium.orge8077812012-02-03 03:41:46 +00004359 (options, args) = parser.parse_args(args)
4360
Ng Zhi Ancdaf0be2020-05-27 20:57:28 +00004361 if options.git_completion_helper:
Edward Lesmesb7db1832020-06-22 20:22:27 +00004362 print(' '.join(opt.get_opt_string() for opt in parser.option_list
4363 if opt.help != optparse.SUPPRESS_HELP))
4364 return
Ng Zhi Ancdaf0be2020-05-27 20:57:28 +00004365
sbc@chromium.org71437c02015-04-09 19:29:40 +00004366 if git_common.is_dirty_git_tree('upload'):
ukai@chromium.orge8077812012-02-03 03:41:46 +00004367 return 1
4368
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00004369 options.reviewers = cleanup_list(options.reviewers)
Robert Iannucci6c98dc62017-04-18 11:38:00 -07004370 options.tbrs = cleanup_list(options.tbrs)
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00004371 options.cc = cleanup_list(options.cc)
4372
Josipe827b0f2020-01-30 00:07:20 +00004373 if options.edit_description and options.force:
4374 parser.error('Only one of --force and --edit-description allowed')
4375
tandriib80458a2016-06-23 12:20:07 -07004376 if options.message_file:
4377 if options.message:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004378 parser.error('Only one of --message and --message-file allowed.')
tandriib80458a2016-06-23 12:20:07 -07004379 options.message = gclient_utils.FileRead(options.message_file)
tandriib80458a2016-06-23 12:20:07 -07004380
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004381 if ([options.cq_dry_run,
Greg Gutermanbe5fccd2021-06-14 17:58:20 +00004382 options.cq_quick_run,
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004383 options.use_commit_queue,
4384 options.retry_failed].count(True) > 1):
Greg Gutermanbe5fccd2021-06-14 17:58:20 +00004385 parser.error('Only one of --use-commit-queue, --cq-dry-run, --cq-quick-run '
4386 'or --retry-failed is allowed.')
tandrii4d0545a2016-07-06 03:56:49 -07004387
Mario Bianuccicebfb4e2020-07-22 23:08:16 +00004388 if options.skip_title and options.title:
4389 parser.error('Only one of --title and --skip-title allowed.')
4390
Aaron Gableedbc4132017-09-11 13:22:28 -07004391 if options.use_commit_queue:
4392 options.send_mail = True
4393
Edward Lesmes0dd54822020-03-26 18:24:25 +00004394 if options.squash is None:
4395 # Load default for user, repo, squash=true, in this order.
4396 options.squash = settings.GetSquashGerritUploads()
4397
Josip Sokcevic1cabb172021-04-08 19:15:35 +00004398 cl = Changelist(branchref=options.target_branch)
Edward Lesmes7677e5c2020-02-19 20:39:03 +00004399 # Warm change details cache now to avoid RPCs later, reducing latency for
4400 # developers.
4401 if cl.GetIssue():
4402 cl._GetChangeDetail(
4403 ['DETAILED_ACCOUNTS', 'CURRENT_REVISION', 'CURRENT_COMMIT', 'LABELS'])
4404
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004405 if options.retry_failed and not cl.GetIssue():
4406 print('No previous patchsets, so --retry-failed has no effect.')
4407 options.retry_failed = False
Edward Lesmes7677e5c2020-02-19 20:39:03 +00004408
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004409 # cl.GetMostRecentPatchset uses cached information, and can return the last
4410 # patchset before upload. Calling it here makes it clear that it's the
4411 # last patchset before upload. Note that GetMostRecentPatchset will fail
4412 # if no CL has been uploaded yet.
4413 if options.retry_failed:
4414 patchset = cl.GetMostRecentPatchset()
Andrii Shyshkalov9f274432018-10-15 16:40:23 +00004415
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004416 ret = cl.CMDUpload(options, args, orig_args)
4417
4418 if options.retry_failed:
4419 if ret != 0:
4420 print('Upload failed, so --retry-failed has no effect.')
4421 return ret
Andrii Shyshkalov1ad58112019-10-08 01:46:14 +00004422 builds, _ = _fetch_latest_builds(
Edward Lemur5b929a42019-10-21 17:57:39 +00004423 cl, options.buildbucket_host, latest_patchset=patchset)
Edward Lemur45768512020-03-02 19:03:14 +00004424 jobs = _filter_failed_for_retry(builds)
4425 if len(jobs) == 0:
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004426 print('No failed tryjobs, so --retry-failed has no effect.')
4427 return ret
Quinten Yearsley777660f2020-03-04 23:37:06 +00004428 _trigger_tryjobs(cl, jobs, options, patchset + 1)
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004429
4430 return ret
ukai@chromium.orge8077812012-02-03 03:41:46 +00004431
4432
Francois Dorayd42c6812017-05-30 15:10:20 -04004433@subcommand.usage('--description=<description file>')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004434@metrics.collector.collect_metrics('git cl split')
Francois Dorayd42c6812017-05-30 15:10:20 -04004435def CMDsplit(parser, args):
4436 """Splits a branch into smaller branches and uploads CLs.
4437
4438 Creates a branch and uploads a CL for each group of files modified in the
4439 current branch that share a common OWNERS file. In the CL description and
Edward Lemurac5c55f2020-02-29 00:17:16 +00004440 comment, the string '$directory', is replaced with the directory containing
4441 the shared OWNERS file.
Francois Dorayd42c6812017-05-30 15:10:20 -04004442 """
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004443 parser.add_option('-d', '--description', dest='description_file',
4444 help='A text file containing a CL description in which '
4445 '$directory will be replaced by each CL\'s directory.')
4446 parser.add_option('-c', '--comment', dest='comment_file',
4447 help='A text file containing a CL comment.')
4448 parser.add_option('-n', '--dry-run', dest='dry_run', action='store_true',
Chris Watkinsba28e462017-12-13 11:22:17 +11004449 default=False,
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004450 help='List the files and reviewers for each CL that would '
4451 'be created, but don\'t create branches or CLs.')
4452 parser.add_option('--cq-dry-run', action='store_true',
4453 help='If set, will do a cq dry run for each uploaded CL. '
4454 'Please be careful when doing this; more than ~10 CLs '
4455 'has the potential to overload our build '
4456 'infrastructure. Try to upload these not during high '
4457 'load times (usually 11-3 Mountain View time). Email '
4458 'infra-dev@chromium.org with any questions.')
Takuto Ikuta51eca592019-02-14 19:40:52 +00004459 parser.add_option('-a', '--enable-auto-submit', action='store_true',
4460 default=True,
4461 help='Sends your change to the CQ after an approval. Only '
4462 'works on repos that have the Auto-Submit label '
4463 'enabled')
Francois Dorayd42c6812017-05-30 15:10:20 -04004464 options, _ = parser.parse_args(args)
4465
4466 if not options.description_file:
4467 parser.error('No --description flag specified.')
4468
4469 def WrappedCMDupload(args):
4470 return CMDupload(OptionParser(), args)
4471
Edward Lemur2c62b332020-03-12 22:12:33 +00004472 return split_cl.SplitCl(
4473 options.description_file, options.comment_file, Changelist,
4474 WrappedCMDupload, options.dry_run, options.cq_dry_run,
4475 options.enable_auto_submit, settings.GetRoot())
Francois Dorayd42c6812017-05-30 15:10:20 -04004476
4477
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004478@subcommand.usage('DEPRECATED')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004479@metrics.collector.collect_metrics('git cl commit')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004480def CMDdcommit(parser, args):
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004481 """DEPRECATED: Used to commit the current changelist via git-svn."""
4482 message = ('git-cl no longer supports committing to SVN repositories via '
4483 'git-svn. You probably want to use `git cl land` instead.')
4484 print(message)
4485 return 1
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004486
4487
maruel@chromium.org0633fb42013-08-16 20:06:14 +00004488@subcommand.usage('[upstream branch to apply against]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004489@metrics.collector.collect_metrics('git cl land')
pgervais@chromium.orgcee6dc42014-05-07 17:04:03 +00004490def CMDland(parser, args):
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004491 """Commits the current changelist via git.
4492
4493 In case of Gerrit, uses Gerrit REST api to "submit" the issue, which pushes
4494 upstream and closes the issue automatically and atomically.
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004495 """
4496 parser.add_option('--bypass-hooks', action='store_true', dest='bypass_hooks',
4497 help='bypass upload presubmit hook')
Aaron Gablef7543cd2017-07-20 14:26:31 -07004498 parser.add_option('-f', '--force', action='store_true', dest='force',
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004499 help="force yes to questions (don't prompt)")
Edward Lesmes67b3faa2018-04-13 17:50:52 -04004500 parser.add_option('--parallel', action='store_true',
4501 help='Run all tests specified by input_api.RunTests in all '
4502 'PRESUBMIT files in parallel.')
Saagar Sanghavi03b15132020-08-10 16:43:41 +00004503 parser.add_option('--resultdb', action='store_true',
4504 help='Run presubmit checks in the ResultSink environment '
4505 'and send results to the ResultDB database.')
4506 parser.add_option('--realm', help='LUCI realm if reporting to ResultDB')
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004507 (options, args) = parser.parse_args(args)
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004508
Edward Lemur934836a2019-09-09 20:16:54 +00004509 cl = Changelist()
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004510
Robert Iannucci2e73d432018-03-14 01:10:47 -07004511 if not cl.GetIssue():
4512 DieWithError('You must upload the change first to Gerrit.\n'
4513 ' If you would rather have `git cl land` upload '
4514 'automatically for you, see http://crbug.com/642759')
Saagar Sanghavi03b15132020-08-10 16:43:41 +00004515 return cl.CMDLand(options.force, options.bypass_hooks, options.verbose,
4516 options.parallel, options.resultdb, options.realm)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004517
4518
dsinclair@chromium.orgfbed6562015-09-25 21:22:36 +00004519@subcommand.usage('<patch url or issue id or issue url>')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004520@metrics.collector.collect_metrics('git cl patch')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004521def CMDpatch(parser, args):
marq@chromium.orge5e59002013-10-02 23:21:25 +00004522 """Patches in a code review."""
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004523 parser.add_option('-b', dest='newbranch',
4524 help='create a new branch off trunk for the patch')
qsr@chromium.org1ef44af2013-10-16 16:24:32 +00004525 parser.add_option('-f', '--force', action='store_true',
Aaron Gable62619a32017-06-16 08:22:09 -07004526 help='overwrite state on the current or chosen branch')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004527 parser.add_option('-n', '--no-commit', action='store_true', dest='nocommit',
Edward Lemurf38bc172019-09-03 21:02:13 +00004528 help='don\'t commit after patch applies.')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004529
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00004530 group = optparse.OptionGroup(
4531 parser,
4532 'Options for continuing work on the current issue uploaded from a '
4533 'different clone (e.g. different machine). Must be used independently '
4534 'from the other options. No issue number should be specified, and the '
4535 'branch must have an issue number associated with it')
4536 group.add_option('--reapply', action='store_true', dest='reapply',
4537 help='Reset the branch and reapply the issue.\n'
4538 'CAUTION: This will undo any local changes in this '
4539 'branch')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004540
4541 group.add_option('--pull', action='store_true', dest='pull',
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00004542 help='Performs a pull before reapplying.')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004543 parser.add_option_group(group)
4544
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004545 (options, args) = parser.parse_args(args)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004546
Andrii Shyshkalov18975322017-01-25 16:44:13 +01004547 if options.reapply:
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004548 if options.newbranch:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004549 parser.error('--reapply works on the current branch only.')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004550 if len(args) > 0:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004551 parser.error('--reapply implies no additional arguments.')
dsinclair@chromium.orgfbed6562015-09-25 21:22:36 +00004552
Edward Lemur934836a2019-09-09 20:16:54 +00004553 cl = Changelist()
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004554 if not cl.GetIssue():
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004555 parser.error('Current branch must have an associated issue.')
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004556
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004557 upstream = cl.GetUpstreamBranch()
Andrii Shyshkalov18975322017-01-25 16:44:13 +01004558 if upstream is None:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004559 parser.error('No upstream branch specified. Cannot reset branch.')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004560
4561 RunGit(['reset', '--hard', upstream])
4562 if options.pull:
4563 RunGit(['pull'])
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004564
Edward Lemur678a6842019-10-03 22:25:05 +00004565 target_issue_arg = ParseIssueNumberArgument(cl.GetIssue())
Bruce Dawsonf362f6f2021-02-18 23:15:17 +00004566 return cl.CMDPatchWithParsedIssue(target_issue_arg, options.nocommit, False,
4567 False)
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004568
4569 if len(args) != 1 or not args[0]:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004570 parser.error('Must specify issue number or URL.')
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004571
Edward Lemurf38bc172019-09-03 21:02:13 +00004572 target_issue_arg = ParseIssueNumberArgument(args[0])
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004573 if not target_issue_arg.valid:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004574 parser.error('Invalid issue ID or URL.')
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004575
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004576 # We don't want uncommitted changes mixed up with the patch.
4577 if git_common.is_dirty_git_tree('patch'):
dsinclair@chromium.orgfbed6562015-09-25 21:22:36 +00004578 return 1
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004579
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004580 if options.newbranch:
4581 if options.force:
4582 RunGit(['branch', '-D', options.newbranch],
4583 stderr=subprocess2.PIPE, error_ok=True)
Edward Lemur84101642020-02-21 21:40:34 +00004584 git_new_branch.create_new_branch(options.newbranch)
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004585
Edward Lemur678a6842019-10-03 22:25:05 +00004586 cl = Changelist(
4587 codereview_host=target_issue_arg.hostname, issue=target_issue_arg.issue)
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004588
Edward Lemur678a6842019-10-03 22:25:05 +00004589 if not args[0].isdigit():
Edward Lemurf38bc172019-09-03 21:02:13 +00004590 print('canonical issue/change URL: %s\n' % cl.GetIssueURL())
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004591
Bruce Dawsonf362f6f2021-02-18 23:15:17 +00004592 return cl.CMDPatchWithParsedIssue(target_issue_arg, options.nocommit,
4593 options.force, options.newbranch)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004594
4595
jochen@chromium.org3ec0d542014-01-14 20:00:03 +00004596def GetTreeStatus(url=None):
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004597 """Fetches the tree status and returns either 'open', 'closed',
4598 'unknown' or 'unset'."""
jochen@chromium.org3ec0d542014-01-14 20:00:03 +00004599 url = url or settings.GetTreeStatusUrl(error_ok=True)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004600 if url:
Daniel McArdle8b4eeff2020-07-20 17:02:47 +00004601 status = str(urllib.request.urlopen(url).read().lower())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004602 if status.find('closed') != -1 or status == '0':
4603 return 'closed'
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +00004604
4605 if status.find('open') != -1 or status == '1':
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004606 return 'open'
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +00004607
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004608 return 'unknown'
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004609 return 'unset'
4610
dpranke@chromium.org970c5222011-03-12 00:32:24 +00004611
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004612def GetTreeStatusReason():
4613 """Fetches the tree status from a json url and returns the message
4614 with the reason for the tree to be opened or closed."""
msb@chromium.orgbf1a7ba2011-02-01 16:21:46 +00004615 url = settings.GetTreeStatusUrl()
Daniel McArdle8b4eeff2020-07-20 17:02:47 +00004616 json_url = urllib.parse.urljoin(url, '/current?format=json')
Edward Lemur79d4f992019-11-11 23:49:02 +00004617 connection = urllib.request.urlopen(json_url)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004618 status = json.loads(connection.read())
4619 connection.close()
4620 return status['message']
4621
dpranke@chromium.org970c5222011-03-12 00:32:24 +00004622
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004623@metrics.collector.collect_metrics('git cl tree')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004624def CMDtree(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004625 """Shows the status of the tree."""
dpranke@chromium.org97ae58e2011-03-18 00:29:20 +00004626 _, args = parser.parse_args(args)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004627 status = GetTreeStatus()
4628 if 'unset' == status:
vapiera7fbd5a2016-06-16 09:17:49 -07004629 print('You must configure your tree status URL by running "git cl config".')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004630 return 2
4631
vapiera7fbd5a2016-06-16 09:17:49 -07004632 print('The tree is %s' % status)
4633 print()
4634 print(GetTreeStatusReason())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004635 if status != 'open':
4636 return 1
4637 return 0
4638
4639
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004640@metrics.collector.collect_metrics('git cl try')
maruel@chromium.org15192402012-09-06 12:38:29 +00004641def CMDtry(parser, args):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004642 """Triggers tryjobs using either Buildbucket or CQ dry run."""
4643 group = optparse.OptionGroup(parser, 'Tryjob options')
maruel@chromium.org15192402012-09-06 12:38:29 +00004644 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004645 '-b', '--bot', action='append',
4646 help=('IMPORTANT: specify ONE builder per --bot flag. Use it multiple '
4647 'times to specify multiple builders. ex: '
4648 '"-b win_rel -b win_layout". See '
4649 'the try server waterfall for the builders name and the tests '
4650 'available.'))
maruel@chromium.org15192402012-09-06 12:38:29 +00004651 group.add_option(
borenet6c0efe62016-10-19 08:13:29 -07004652 '-B', '--bucket', default='',
4653 help=('Buildbucket bucket to send the try requests.'))
4654 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004655 '-r', '--revision',
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004656 help='Revision to use for the tryjob; default: the revision will '
tandriif7b29d42016-10-07 08:45:41 -07004657 'be determined by the try recipe that builder runs, which usually '
Josip Sokcevicc39ab992020-09-24 20:09:15 +00004658 'defaults to HEAD of origin/master or origin/main')
maruel@chromium.org15192402012-09-06 12:38:29 +00004659 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004660 '-c', '--clobber', action='store_true', default=False,
tandriif7b29d42016-10-07 08:45:41 -07004661 help='Force a clobber before building; that is don\'t do an '
tandrii1838bad2016-10-06 00:10:52 -07004662 'incremental build')
maruel@chromium.org15192402012-09-06 12:38:29 +00004663 group.add_option(
Greg Gutermanbe5fccd2021-06-14 17:58:20 +00004664 '-q',
4665 '--quick-run',
4666 action='store_true',
4667 default=False,
4668 help='trigger in quick run mode '
4669 '(https://source.chromium.org/chromium/chromium/src/+/main:docs/cq_q'
4670 'uick_run.md) (chromium only).')
4671 group.add_option(
Andrii Shyshkalovf9648b52018-02-21 22:32:42 -08004672 '--category', default='git_cl_try', help='Specify custom build category.')
4673 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004674 '--project',
4675 help='Override which project to use. Projects are defined '
tandriif7b29d42016-10-07 08:45:41 -07004676 'in recipe to determine to which repository or directory to '
4677 'apply the patch')
maruel@chromium.org15192402012-09-06 12:38:29 +00004678 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004679 '-p', '--property', dest='properties', action='append', default=[],
4680 help='Specify generic properties in the form -p key1=value1 -p '
tandriif7b29d42016-10-07 08:45:41 -07004681 'key2=value2 etc. The value will be treated as '
4682 'json if decodable, or as string otherwise. '
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004683 'NOTE: using this may make your tryjob not usable for CQ, '
4684 'which will then schedule another tryjob with default properties')
sheyang@chromium.orgdb375572015-08-17 19:22:23 +00004685 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004686 '--buildbucket-host', default='cr-buildbucket.appspot.com',
4687 help='Host of buildbucket. The default host is %default.')
maruel@chromium.org15192402012-09-06 12:38:29 +00004688 parser.add_option_group(group)
Quinten Yearsley983111f2019-09-26 17:18:48 +00004689 parser.add_option(
4690 '-R', '--retry-failed', action='store_true', default=False,
4691 help='Retry failed jobs from the latest set of tryjobs. '
4692 'Not allowed with --bucket and --bot options.')
Edward Lemur52969c92020-02-06 18:15:28 +00004693 parser.add_option(
4694 '-i', '--issue', type=int,
4695 help='Operate on this issue instead of the current branch\'s implicit '
4696 'issue.')
maruel@chromium.org15192402012-09-06 12:38:29 +00004697 options, args = parser.parse_args(args)
4698
machenbach@chromium.org45453142015-09-15 08:45:22 +00004699 # Make sure that all properties are prop=value pairs.
4700 bad_params = [x for x in options.properties if '=' not in x]
4701 if bad_params:
4702 parser.error('Got properties with missing "=": %s' % bad_params)
4703
maruel@chromium.org15192402012-09-06 12:38:29 +00004704 if args:
4705 parser.error('Unknown arguments: %s' % args)
4706
Edward Lemur934836a2019-09-09 20:16:54 +00004707 cl = Changelist(issue=options.issue)
maruel@chromium.org15192402012-09-06 12:38:29 +00004708 if not cl.GetIssue():
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004709 parser.error('Need to upload first.')
maruel@chromium.org15192402012-09-06 12:38:29 +00004710
Edward Lemurf38bc172019-09-03 21:02:13 +00004711 # HACK: warm up Gerrit change detail cache to save on RPCs.
Edward Lemur125d60a2019-09-13 18:25:41 +00004712 cl._GetChangeDetail(['DETAILED_ACCOUNTS', 'ALL_REVISIONS'])
Andrii Shyshkaloveadad922017-01-26 09:38:30 +01004713
tandriie113dfd2016-10-11 10:20:12 -07004714 error_message = cl.CannotTriggerTryJobReason()
4715 if error_message:
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004716 parser.error('Can\'t trigger tryjobs: %s' % error_message)
jrobbins@chromium.org16f10f72014-06-24 22:14:36 +00004717
Edward Lemur45768512020-03-02 19:03:14 +00004718 if options.bot:
4719 if options.retry_failed:
4720 parser.error('--bot is not compatible with --retry-failed.')
4721 if not options.bucket:
4722 parser.error('A bucket (e.g. "chromium/try") is required.')
4723
4724 triggered = [b for b in options.bot if 'triggered' in b]
4725 if triggered:
4726 parser.error(
4727 'Cannot schedule builds on triggered bots: %s.\n'
4728 'This type of bot requires an initial job from a parent (usually a '
4729 'builder). Schedule a job on the parent instead.\n' % triggered)
4730
4731 if options.bucket.startswith('.master'):
4732 parser.error('Buildbot masters are not supported.')
4733
4734 project, bucket = _parse_bucket(options.bucket)
4735 if project is None or bucket is None:
4736 parser.error('Invalid bucket: %s.' % options.bucket)
4737 jobs = sorted((project, bucket, bot) for bot in options.bot)
4738 elif options.retry_failed:
Quinten Yearsley983111f2019-09-26 17:18:48 +00004739 print('Searching for failed tryjobs...')
Edward Lemur5b929a42019-10-21 17:57:39 +00004740 builds, patchset = _fetch_latest_builds(cl, options.buildbucket_host)
Quinten Yearsley983111f2019-09-26 17:18:48 +00004741 if options.verbose:
4742 print('Got %d builds in patchset #%d' % (len(builds), patchset))
Edward Lemur45768512020-03-02 19:03:14 +00004743 jobs = _filter_failed_for_retry(builds)
4744 if not jobs:
Quinten Yearsley983111f2019-09-26 17:18:48 +00004745 print('There are no failed jobs in the latest set of jobs '
4746 '(patchset #%d), doing nothing.' % patchset)
4747 return 0
Edward Lemur45768512020-03-02 19:03:14 +00004748 num_builders = len(jobs)
Quinten Yearsley983111f2019-09-26 17:18:48 +00004749 if num_builders > 10:
4750 confirm_or_exit('There are %d builders with failed builds.'
4751 % num_builders, action='continue')
Greg Gutermanbe5fccd2021-06-14 17:58:20 +00004752 elif options.quick_run:
4753 print('Scheduling CQ quick run on: %s' % cl.GetIssueURL())
4754 return cl.SetCQState(_CQState.QUICK_RUN)
Quinten Yearsley983111f2019-09-26 17:18:48 +00004755 else:
qyearsley1fdfcb62016-10-24 13:22:03 -07004756 if options.verbose:
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07004757 print('git cl try with no bots now defaults to CQ dry run.')
4758 print('Scheduling CQ dry run on: %s' % cl.GetIssueURL())
4759 return cl.SetCQState(_CQState.DRY_RUN)
stip@chromium.org43064fd2013-12-18 20:07:44 +00004760
ilevy@chromium.org36e420b2013-08-06 23:21:12 +00004761 patchset = cl.GetMostRecentPatchset()
Edward Lemur2c210a42019-09-16 23:58:35 +00004762 try:
Quinten Yearsley777660f2020-03-04 23:37:06 +00004763 _trigger_tryjobs(cl, jobs, options, patchset)
Edward Lemur2c210a42019-09-16 23:58:35 +00004764 except BuildbucketResponseException as ex:
4765 print('ERROR: %s' % ex)
4766 return 1
4767 return 0
maruel@chromium.org15192402012-09-06 12:38:29 +00004768
4769
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004770@metrics.collector.collect_metrics('git cl try-results')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004771def CMDtry_results(parser, args):
Quinten Yearsleyd242ed72019-07-25 17:17:55 +00004772 """Prints info about results for tryjobs associated with the current CL."""
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004773 group = optparse.OptionGroup(parser, 'Tryjob results options')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004774 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004775 '-p', '--patchset', type=int, help='patchset number if not current.')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004776 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004777 '--print-master', action='store_true', help='print master name as well.')
tandrii@chromium.org6cf98c82016-03-15 11:56:00 +00004778 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004779 '--color', action='store_true', default=setup_color.IS_TTY,
4780 help='force color output, useful when piping output.')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004781 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004782 '--buildbucket-host', default='cr-buildbucket.appspot.com',
4783 help='Host of buildbucket. The default host is %default.')
qyearsley53f48a12016-09-01 10:45:13 -07004784 group.add_option(
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004785 '--json', help=('Path of JSON output file to write tryjob results to,'
Stefan Zager1306bd02017-06-22 19:26:46 -07004786 'or "-" for stdout.'))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004787 parser.add_option_group(group)
Edward Lemur52969c92020-02-06 18:15:28 +00004788 parser.add_option(
4789 '-i', '--issue', type=int,
4790 help='Operate on this issue instead of the current branch\'s implicit '
4791 'issue.')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004792 options, args = parser.parse_args(args)
4793 if args:
4794 parser.error('Unrecognized args: %s' % ' '.join(args))
4795
Edward Lemur934836a2019-09-09 20:16:54 +00004796 cl = Changelist(issue=options.issue)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004797 if not cl.GetIssue():
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004798 parser.error('Need to upload first.')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004799
tandrii221ab252016-10-06 08:12:04 -07004800 patchset = options.patchset
4801 if not patchset:
Gavin Make61ccc52020-11-13 00:12:57 +00004802 patchset = cl.GetMostRecentDryRunPatchset()
tandrii221ab252016-10-06 08:12:04 -07004803 if not patchset:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004804 parser.error('Code review host doesn\'t know about issue %s. '
tandrii221ab252016-10-06 08:12:04 -07004805 'No access to issue or wrong issue number?\n'
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004806 'Either upload first, or pass --patchset explicitly.' %
tandrii221ab252016-10-06 08:12:04 -07004807 cl.GetIssue())
4808
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004809 try:
Quinten Yearsley777660f2020-03-04 23:37:06 +00004810 jobs = _fetch_tryjobs(cl, options.buildbucket_host, patchset)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004811 except BuildbucketResponseException as ex:
vapiera7fbd5a2016-06-16 09:17:49 -07004812 print('Buildbucket error: %s' % ex)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004813 return 1
qyearsley53f48a12016-09-01 10:45:13 -07004814 if options.json:
Edward Lemurbaaf6be2019-10-09 18:00:44 +00004815 write_json(options.json, jobs)
qyearsley53f48a12016-09-01 10:45:13 -07004816 else:
Quinten Yearsley777660f2020-03-04 23:37:06 +00004817 _print_tryjobs(options, jobs)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004818 return 0
4819
4820
maruel@chromium.org0633fb42013-08-16 20:06:14 +00004821@subcommand.usage('[new upstream branch]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004822@metrics.collector.collect_metrics('git cl upstream')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004823def CMDupstream(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004824 """Prints or sets the name of the upstream branch, if any."""
dpranke@chromium.org97ae58e2011-03-18 00:29:20 +00004825 _, args = parser.parse_args(args)
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00004826 if len(args) > 1:
maruel@chromium.org27bb3872011-05-30 20:33:19 +00004827 parser.error('Unrecognized args: %s' % ' '.join(args))
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00004828
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004829 cl = Changelist()
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00004830 if args:
4831 # One arg means set upstream branch.
bauerb@chromium.orgc9cf90a2014-04-28 20:32:31 +00004832 branch = cl.GetBranch()
stip7a3dd352016-09-22 17:32:28 -07004833 RunGit(['branch', '--set-upstream-to', args[0], branch])
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00004834 cl = Changelist()
vapiera7fbd5a2016-06-16 09:17:49 -07004835 print('Upstream branch set to %s' % (cl.GetUpstreamBranch(),))
bauerb@chromium.orgc9cf90a2014-04-28 20:32:31 +00004836
4837 # Clear configured merge-base, if there is one.
4838 git_common.remove_merge_base(branch)
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00004839 else:
vapiera7fbd5a2016-06-16 09:17:49 -07004840 print(cl.GetUpstreamBranch())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004841 return 0
4842
4843
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004844@metrics.collector.collect_metrics('git cl web')
thestig@chromium.org00858c82013-12-02 23:08:03 +00004845def CMDweb(parser, args):
4846 """Opens the current CL in the web browser."""
4847 _, args = parser.parse_args(args)
4848 if args:
4849 parser.error('Unrecognized args: %s' % ' '.join(args))
4850
4851 issue_url = Changelist().GetIssueURL()
4852 if not issue_url:
vapiera7fbd5a2016-06-16 09:17:49 -07004853 print('ERROR No issue to open', file=sys.stderr)
thestig@chromium.org00858c82013-12-02 23:08:03 +00004854 return 1
4855
Sergiy Byelozyorov2b718322018-10-24 17:43:31 +00004856 # Redirect I/O before invoking browser to hide its output. For example, this
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004857 # allows us to hide the "Created new window in existing browser session."
4858 # message from Chrome. Based on https://stackoverflow.com/a/2323563.
Sergiy Byelozyorov2b718322018-10-24 17:43:31 +00004859 saved_stdout = os.dup(1)
Sergiy Belozorov06684032019-03-06 16:53:08 +00004860 saved_stderr = os.dup(2)
Sergiy Byelozyorov2b718322018-10-24 17:43:31 +00004861 os.close(1)
Sergiy Belozorov06684032019-03-06 16:53:08 +00004862 os.close(2)
Sergiy Byelozyorov2b718322018-10-24 17:43:31 +00004863 os.open(os.devnull, os.O_RDWR)
4864 try:
4865 webbrowser.open(issue_url)
4866 finally:
4867 os.dup2(saved_stdout, 1)
Sergiy Belozorov06684032019-03-06 16:53:08 +00004868 os.dup2(saved_stderr, 2)
thestig@chromium.org00858c82013-12-02 23:08:03 +00004869 return 0
4870
4871
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004872@metrics.collector.collect_metrics('git cl set-commit')
maruel@chromium.org27bb3872011-05-30 20:33:19 +00004873def CMDset_commit(parser, args):
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +00004874 """Sets the commit bit to trigger the CQ."""
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00004875 parser.add_option('-d', '--dry-run', action='store_true',
4876 help='trigger in dry run mode')
Greg Gutermanbe5fccd2021-06-14 17:58:20 +00004877 parser.add_option(
4878 '-q',
4879 '--quick-run',
4880 action='store_true',
4881 help='trigger in quick run mode '
4882 '(https://source.chromium.org/chromium/chromium/src/+/main:docs/cq_qu'
4883 'ick_run.md) (chromium only).')
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00004884 parser.add_option('-c', '--clear', action='store_true',
4885 help='stop CQ run, if any')
Edward Lemur52969c92020-02-06 18:15:28 +00004886 parser.add_option(
4887 '-i', '--issue', type=int,
4888 help='Operate on this issue instead of the current branch\'s implicit '
4889 'issue.')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004890 options, args = parser.parse_args(args)
maruel@chromium.org27bb3872011-05-30 20:33:19 +00004891 if args:
4892 parser.error('Unrecognized args: %s' % ' '.join(args))
Greg Gutermanbe5fccd2021-06-14 17:58:20 +00004893 if [options.dry_run, options.quick_run, options.clear].count(True) > 1:
4894 parser.error('Only one of --dry-run, --quick-run, and --clear are allowed.')
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00004895
Edward Lemur934836a2019-09-09 20:16:54 +00004896 cl = Changelist(issue=options.issue)
Greg Gutermanbe5fccd2021-06-14 17:58:20 +00004897 if not cl.GetIssue():
4898 parser.error('Must upload the issue first.')
4899
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00004900 if options.clear:
tandriid9e5ce52016-07-13 02:32:59 -07004901 state = _CQState.NONE
Greg Gutermanbe5fccd2021-06-14 17:58:20 +00004902 elif options.quick_run:
4903 state = _CQState.QUICK_RUN
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00004904 elif options.dry_run:
4905 state = _CQState.DRY_RUN
4906 else:
4907 state = _CQState.COMMIT
tandrii9de9ec62016-07-13 03:01:59 -07004908 cl.SetCQState(state)
maruel@chromium.org27bb3872011-05-30 20:33:19 +00004909 return 0
4910
4911
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004912@metrics.collector.collect_metrics('git cl set-close')
groby@chromium.org411034a2013-02-26 15:12:01 +00004913def CMDset_close(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004914 """Closes the issue."""
Edward Lemur52969c92020-02-06 18:15:28 +00004915 parser.add_option(
4916 '-i', '--issue', type=int,
4917 help='Operate on this issue instead of the current branch\'s implicit '
4918 'issue.')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004919 options, args = parser.parse_args(args)
groby@chromium.org411034a2013-02-26 15:12:01 +00004920 if args:
4921 parser.error('Unrecognized args: %s' % ' '.join(args))
Edward Lemur934836a2019-09-09 20:16:54 +00004922 cl = Changelist(issue=options.issue)
groby@chromium.org411034a2013-02-26 15:12:01 +00004923 # Ensure there actually is an issue to close.
Aaron Gable7139a4e2017-09-05 17:53:09 -07004924 if not cl.GetIssue():
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004925 DieWithError('ERROR: No issue to close.')
groby@chromium.org411034a2013-02-26 15:12:01 +00004926 cl.CloseIssue()
4927 return 0
4928
4929
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004930@metrics.collector.collect_metrics('git cl diff')
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00004931def CMDdiff(parser, args):
wychen@chromium.org37b2ec02015-04-03 00:49:15 +00004932 """Shows differences between local tree and last upload."""
thomasanderson074beb22016-08-29 14:03:20 -07004933 parser.add_option(
4934 '--stat',
4935 action='store_true',
4936 dest='stat',
4937 help='Generate a diffstat')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004938 options, args = parser.parse_args(args)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004939 if args:
4940 parser.error('Unrecognized args: %s' % ' '.join(args))
wychen@chromium.org46309bf2015-04-03 21:04:49 +00004941
Edward Lemur934836a2019-09-09 20:16:54 +00004942 cl = Changelist()
sbc@chromium.org78dc9842013-11-25 18:43:44 +00004943 issue = cl.GetIssue()
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00004944 branch = cl.GetBranch()
sbc@chromium.org78dc9842013-11-25 18:43:44 +00004945 if not issue:
4946 DieWithError('No issue found for current branch (%s)' % branch)
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00004947
Aaron Gablea718c3e2017-08-28 17:47:28 -07004948 base = cl._GitGetBranchConfigValue('last-upload-hash')
4949 if not base:
4950 base = cl._GitGetBranchConfigValue('gerritsquashhash')
4951 if not base:
4952 detail = cl._GetChangeDetail(['CURRENT_REVISION', 'CURRENT_COMMIT'])
4953 revision_info = detail['revisions'][detail['current_revision']]
4954 fetch_info = revision_info['fetch']['http']
4955 RunGit(['fetch', fetch_info['url'], fetch_info['ref']])
4956 base = 'FETCH_HEAD'
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00004957
Aaron Gablea718c3e2017-08-28 17:47:28 -07004958 cmd = ['git', 'diff']
4959 if options.stat:
4960 cmd.append('--stat')
4961 cmd.append(base)
4962 subprocess2.check_call(cmd)
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00004963
4964 return 0
4965
4966
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004967@metrics.collector.collect_metrics('git cl owners')
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00004968def CMDowners(parser, args):
Dirk Prankebf980882017-09-02 15:08:00 -07004969 """Finds potential owners for reviewing."""
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00004970 parser.add_option(
Sidney San Martín8e6f58c2018-06-08 01:02:56 +00004971 '--ignore-current',
4972 action='store_true',
4973 help='Ignore the CL\'s current reviewers and start from scratch.')
4974 parser.add_option(
Sylvain Defresneb1f865d2019-02-12 12:38:22 +00004975 '--ignore-self',
4976 action='store_true',
4977 help='Do not consider CL\'s author as an owners.')
4978 parser.add_option(
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00004979 '--no-color',
4980 action='store_true',
4981 help='Use this option to disable color output')
Dirk Prankebf980882017-09-02 15:08:00 -07004982 parser.add_option(
4983 '--batch',
4984 action='store_true',
4985 help='Do not run interactively, just suggest some')
Yang Guo6e269a02019-06-26 11:17:02 +00004986 # TODO: Consider moving this to another command, since other
4987 # git-cl owners commands deal with owners for a given CL.
4988 parser.add_option(
4989 '--show-all',
4990 action='store_true',
4991 help='Show all owners for a particular file')
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00004992 options, args = parser.parse_args(args)
4993
Edward Lemur934836a2019-09-09 20:16:54 +00004994 cl = Changelist()
Edward Lesmes50da7702020-03-30 19:23:43 +00004995 author = cl.GetAuthor()
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00004996
Yang Guo6e269a02019-06-26 11:17:02 +00004997 if options.show_all:
Bruce Dawson97ed44a2020-05-06 17:04:03 +00004998 if len(args) == 0:
4999 print('No files specified for --show-all. Nothing to do.')
5000 return 0
Edward Lesmese1576912021-02-16 21:53:34 +00005001 owners_by_path = cl.owners_client.BatchListOwners(args)
Edward Lesmes0e4e5ae2021-01-08 18:28:46 +00005002 for path in args:
5003 print('Owners for %s:' % path)
5004 print('\n'.join(
5005 ' - %s' % owner
5006 for owner in owners_by_path.get(path, ['No owners found'])))
Yang Guo6e269a02019-06-26 11:17:02 +00005007 return 0
5008
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005009 if args:
5010 if len(args) > 1:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00005011 parser.error('Unknown args.')
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005012 base_branch = args[0]
5013 else:
5014 # Default to diffing against the common ancestor of the upstream branch.
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00005015 base_branch = cl.GetCommonAncestorWithUpstream()
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005016
Edward Lemur2c62b332020-03-12 22:12:33 +00005017 affected_files = cl.GetAffectedFiles(base_branch)
Dirk Prankebf980882017-09-02 15:08:00 -07005018
5019 if options.batch:
Edward Lesmese1576912021-02-16 21:53:34 +00005020 owners = cl.owners_client.SuggestOwners(affected_files, exclude=[author])
5021 print('\n'.join(owners))
Dirk Prankebf980882017-09-02 15:08:00 -07005022 return 0
5023
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005024 return owners_finder.OwnersFinder(
Dirk Prankebf980882017-09-02 15:08:00 -07005025 affected_files,
Edward Lemur707d70b2018-02-07 00:50:14 +01005026 author,
Sidney San Martín8e6f58c2018-06-08 01:02:56 +00005027 [] if options.ignore_current else cl.GetReviewers(),
Edward Lesmes5cd75472021-02-19 00:34:25 +00005028 cl.owners_client,
Jochen Eisingerd0573ec2017-04-13 10:55:06 +02005029 disable_color=options.no_color,
Sylvain Defresneb1f865d2019-02-12 12:38:22 +00005030 ignore_author=options.ignore_self).run()
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005031
5032
Aiden Bennerc08566e2018-10-03 17:52:42 +00005033def BuildGitDiffCmd(diff_type, upstream_commit, args, allow_prefix=False):
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005034 """Generates a diff command."""
5035 # Generate diff for the current branch's changes.
Aiden Bennerc08566e2018-10-03 17:52:42 +00005036 diff_cmd = ['-c', 'core.quotePath=false', 'diff', '--no-ext-diff']
5037
Aiden Benner6c18a1a2018-11-23 20:18:23 +00005038 if allow_prefix:
5039 # explicitly setting --src-prefix and --dst-prefix is necessary in the
5040 # case that diff.noprefix is set in the user's git config.
5041 diff_cmd += ['--src-prefix=a/', '--dst-prefix=b/']
5042 else:
Aiden Bennerc08566e2018-10-03 17:52:42 +00005043 diff_cmd += ['--no-prefix']
5044
5045 diff_cmd += [diff_type, upstream_commit, '--']
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005046
5047 if args:
5048 for arg in args:
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005049 if os.path.isdir(arg) or os.path.isfile(arg):
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005050 diff_cmd.append(arg)
5051 else:
5052 DieWithError('Argument "%s" is not a file or a directory' % arg)
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005053
5054 return diff_cmd
5055
Andrii Shyshkalov18975322017-01-25 16:44:13 +01005056
Jamie Madill5e96ad12020-01-13 16:08:35 +00005057def _RunClangFormatDiff(opts, clang_diff_files, top_dir, upstream_commit):
5058 """Runs clang-format-diff and sets a return value if necessary."""
5059
5060 if not clang_diff_files:
5061 return 0
5062
5063 # Set to 2 to signal to CheckPatchFormatted() that this patch isn't
5064 # formatted. This is used to block during the presubmit.
5065 return_value = 0
5066
5067 # Locate the clang-format binary in the checkout
5068 try:
5069 clang_format_tool = clang_format.FindClangFormatToolInChromiumTree()
5070 except clang_format.NotFoundError as e:
5071 DieWithError(e)
5072
5073 if opts.full or settings.GetFormatFullByDefault():
5074 cmd = [clang_format_tool]
5075 if not opts.dry_run and not opts.diff:
5076 cmd.append('-i')
5077 if opts.dry_run:
5078 for diff_file in clang_diff_files:
5079 with open(diff_file, 'r') as myfile:
5080 code = myfile.read().replace('\r\n', '\n')
5081 stdout = RunCommand(cmd + [diff_file], cwd=top_dir)
5082 stdout = stdout.replace('\r\n', '\n')
5083 if opts.diff:
5084 sys.stdout.write(stdout)
5085 if code != stdout:
5086 return_value = 2
5087 else:
5088 stdout = RunCommand(cmd + clang_diff_files, cwd=top_dir)
5089 if opts.diff:
5090 sys.stdout.write(stdout)
5091 else:
Jamie Madill5e96ad12020-01-13 16:08:35 +00005092 try:
5093 script = clang_format.FindClangFormatScriptInChromiumTree(
5094 'clang-format-diff.py')
5095 except clang_format.NotFoundError as e:
5096 DieWithError(e)
5097
Josip Sokcevic2a827fc2022-03-04 17:51:47 +00005098 cmd = ['vpython3', script, '-p0']
Jamie Madill5e96ad12020-01-13 16:08:35 +00005099 if not opts.dry_run and not opts.diff:
5100 cmd.append('-i')
5101
5102 diff_cmd = BuildGitDiffCmd('-U0', upstream_commit, clang_diff_files)
Edward Lemur1a83da12020-03-04 21:18:36 +00005103 diff_output = RunGit(diff_cmd).encode('utf-8')
Jamie Madill5e96ad12020-01-13 16:08:35 +00005104
Edward Lesmes89624cd2020-04-06 17:51:56 +00005105 env = os.environ.copy()
5106 env['PATH'] = (
5107 str(os.path.dirname(clang_format_tool)) + os.pathsep + env['PATH'])
5108 stdout = RunCommand(
5109 cmd, stdin=diff_output, cwd=top_dir, env=env,
Ilya Sherman7aed4bb2020-05-20 22:34:14 +00005110 shell=sys.platform.startswith('win32'))
Jamie Madill5e96ad12020-01-13 16:08:35 +00005111 if opts.diff:
5112 sys.stdout.write(stdout)
5113 if opts.dry_run and len(stdout) > 0:
5114 return_value = 2
5115
5116 return return_value
5117
5118
Lukasz Anforowiczb4d39542021-09-30 23:39:25 +00005119def _RunRustFmt(opts, rust_diff_files, top_dir, upstream_commit):
5120 """Runs rustfmt. Just like _RunClangFormatDiff returns 2 to indicate that
5121 presubmit checks have failed (and returns 0 otherwise)."""
5122
5123 if not rust_diff_files:
5124 return 0
5125
5126 # Locate the rustfmt binary.
5127 try:
5128 rustfmt_tool = rustfmt.FindRustfmtToolInChromiumTree()
5129 except rustfmt.NotFoundError as e:
5130 DieWithError(e)
5131
5132 # TODO(crbug.com/1231317): Support formatting only the changed lines
5133 # if `opts.full or settings.GetFormatFullByDefault()` is False. See also:
5134 # https://github.com/emilio/rustfmt-format-diff
5135 cmd = [rustfmt_tool]
5136 if opts.dry_run:
5137 cmd.append('--check')
5138 cmd += rust_diff_files
5139 rustfmt_exitcode = subprocess2.call(cmd)
5140
5141 if opts.presubmit and rustfmt_exitcode != 0:
5142 return 2
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +00005143
5144 return 0
Lukasz Anforowiczb4d39542021-09-30 23:39:25 +00005145
5146
Olivier Robin0a6b5442022-04-07 07:25:04 +00005147def _RunSwiftFormat(opts, swift_diff_files, top_dir, upstream_commit):
5148 """Runs swift-format. Just like _RunClangFormatDiff returns 2 to indicate
5149 that presubmit checks have failed (and returns 0 otherwise)."""
5150
5151 if not swift_diff_files:
5152 return 0
5153
5154 # Locate the swift-format binary.
5155 try:
5156 swift_format_tool = swift_format.FindSwiftFormatToolInChromiumTree()
5157 except swift_format.NotFoundError as e:
5158 DieWithError(e)
5159
5160 cmd = [swift_format_tool]
5161 if opts.dry_run:
5162 cmd.append('lint')
5163 else:
5164 cmd += ['format', '-i']
5165 cmd += swift_diff_files
5166 swift_format_exitcode = subprocess2.call(cmd)
5167
5168 if opts.presubmit and swift_format_exitcode != 0:
5169 return 2
5170
5171 return 0
5172
5173
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005174def MatchingFileType(file_name, extensions):
Quinten Yearsleyd242ed72019-07-25 17:17:55 +00005175 """Returns True if the file name ends with one of the given extensions."""
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005176 return bool([ext for ext in extensions if file_name.lower().endswith(ext)])
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005177
Andrii Shyshkalov18975322017-01-25 16:44:13 +01005178
enne@chromium.org555cfe42014-01-29 18:21:39 +00005179@subcommand.usage('[files or directories to diff]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005180@metrics.collector.collect_metrics('git cl format')
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005181def CMDformat(parser, args):
sbc@chromium.org9d0644d2015-06-05 23:16:54 +00005182 """Runs auto-formatting tools (clang-format etc.) on the diff."""
Christopher Lamc5ba6922017-01-24 11:19:14 +11005183 CLANG_EXTS = ['.cc', '.cpp', '.h', '.m', '.mm', '.proto', '.java']
kylechar58edce22016-06-17 06:07:51 -07005184 GN_EXTS = ['.gn', '.gni', '.typemap']
Lukasz Anforowiczb4d39542021-09-30 23:39:25 +00005185 RUST_EXTS = ['.rs']
Olivier Robin0a6b5442022-04-07 07:25:04 +00005186 SWIFT_EXTS = ['.swift']
enne@chromium.org3b7e15c2014-01-21 17:44:47 +00005187 parser.add_option('--full', action='store_true',
5188 help='Reformat the full content of all touched files')
Tomasz Åšniatowski58194462021-08-27 17:36:16 +00005189 parser.add_option('--upstream', help='Branch to check against')
enne@chromium.org3b7e15c2014-01-21 17:44:47 +00005190 parser.add_option('--dry-run', action='store_true',
5191 help='Don\'t modify any file on disk.')
Aiden Benner99b0ccb2018-11-20 19:53:31 +00005192 parser.add_option(
Garrett Beatyed0cc5f2020-01-06 17:26:13 +00005193 '--no-clang-format',
5194 dest='clang_format',
5195 action='store_false',
5196 default=True,
5197 help='Disables formatting of various file types using clang-format.')
5198 parser.add_option(
Aiden Benner99b0ccb2018-11-20 19:53:31 +00005199 '--python',
5200 action='store_true',
5201 default=None,
5202 help='Enables python formatting on all python files.')
5203 parser.add_option(
5204 '--no-python',
5205 action='store_true',
Garrett Beaty91a6f332020-01-06 16:57:24 +00005206 default=False,
Aiden Benner99b0ccb2018-11-20 19:53:31 +00005207 help='Disables python formatting on all python files. '
Garrett Beaty91a6f332020-01-06 16:57:24 +00005208 'If neither --python or --no-python are set, python files that have a '
5209 '.style.yapf file in an ancestor directory will be formatted. '
5210 'It is an error to set both.')
Garrett Beatyed0cc5f2020-01-06 17:26:13 +00005211 parser.add_option(
5212 '--js',
5213 action='store_true',
5214 help='Format javascript code with clang-format. '
5215 'Has no effect if --no-clang-format is set.')
wittman@chromium.org04d5a222014-03-07 18:30:42 +00005216 parser.add_option('--diff', action='store_true',
5217 help='Print diff to stdout rather than modifying files.')
Ilya Shermane081cbe2017-08-15 17:51:04 -07005218 parser.add_option('--presubmit', action='store_true',
5219 help='Used when running the script from a presubmit.')
Lukasz Anforowiczb4d39542021-09-30 23:39:25 +00005220
5221 parser.add_option('--rust-fmt',
5222 dest='use_rust_fmt',
5223 action='store_true',
5224 default=rustfmt.IsRustfmtSupported(),
5225 help='Enables formatting of Rust file types using rustfmt.')
5226 parser.add_option(
5227 '--no-rust-fmt',
5228 dest='use_rust_fmt',
5229 action='store_false',
5230 help='Disables formatting of Rust file types using rustfmt.')
5231
Olivier Robin0a6b5442022-04-07 07:25:04 +00005232 parser.add_option(
5233 '--swift-format',
5234 dest='use_swift_format',
5235 action='store_true',
5236 default=False,
5237 help='Enables formatting of Swift file types using swift-format '
5238 '(macOS host only).')
5239 parser.add_option(
5240 '--no-swift-format',
5241 dest='use_swift_format',
5242 action='store_false',
5243 help='Disables formatting of Swift file types using swift-format.')
5244
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005245 opts, args = parser.parse_args(args)
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005246
Garrett Beaty91a6f332020-01-06 16:57:24 +00005247 if opts.python is not None and opts.no_python:
5248 raise parser.error('Cannot set both --python and --no-python')
5249 if opts.no_python:
5250 opts.python = False
5251
Daniel Chengc55eecf2016-12-30 03:11:02 -08005252 # Normalize any remaining args against the current path, so paths relative to
5253 # the current directory are still resolved as expected.
5254 args = [os.path.join(os.getcwd(), arg) for arg in args]
5255
enne@chromium.orgff7a1fb2013-12-10 19:21:41 +00005256 # git diff generates paths against the root of the repository. Change
5257 # to that directory so clang-format can find files even within subdirs.
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00005258 rel_base_path = settings.GetRelativeRoot()
enne@chromium.orgff7a1fb2013-12-10 19:21:41 +00005259 if rel_base_path:
5260 os.chdir(rel_base_path)
5261
digit@chromium.org29e47272013-05-17 17:01:46 +00005262 # Grab the merge-base commit, i.e. the upstream commit of the current
5263 # branch when it was created or the last time it was rebased. This is
5264 # to cover the case where the user may have called "git fetch origin",
5265 # moving the origin branch to a newer commit, but hasn't rebased yet.
5266 upstream_commit = None
Tomasz Åšniatowski58194462021-08-27 17:36:16 +00005267 upstream_branch = opts.upstream
5268 if not upstream_branch:
5269 cl = Changelist()
5270 upstream_branch = cl.GetUpstreamBranch()
digit@chromium.org29e47272013-05-17 17:01:46 +00005271 if upstream_branch:
5272 upstream_commit = RunGit(['merge-base', 'HEAD', upstream_branch])
5273 upstream_commit = upstream_commit.strip()
5274
5275 if not upstream_commit:
5276 DieWithError('Could not find base commit for this branch. '
5277 'Are you in detached state?')
5278
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005279 changed_files_cmd = BuildGitDiffCmd('--name-only', upstream_commit, args)
5280 diff_output = RunGit(changed_files_cmd)
5281 diff_files = diff_output.splitlines()
jkarlin@chromium.orgad21b922016-01-28 17:48:42 +00005282 # Filter out files deleted by this CL
5283 diff_files = [x for x in diff_files if os.path.isfile(x)]
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005284
Andreas Haas417d89c2020-02-06 10:24:27 +00005285 if opts.js:
Deepanjan Roy605dd312018-07-02 17:48:54 +00005286 CLANG_EXTS.extend(['.js', '.ts'])
Christopher Lamc5ba6922017-01-24 11:19:14 +11005287
Garrett Beatyed0cc5f2020-01-06 17:26:13 +00005288 clang_diff_files = []
5289 if opts.clang_format:
5290 clang_diff_files = [
5291 x for x in diff_files if MatchingFileType(x, CLANG_EXTS)
5292 ]
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005293 python_diff_files = [x for x in diff_files if MatchingFileType(x, ['.py'])]
Lukasz Anforowiczb4d39542021-09-30 23:39:25 +00005294 rust_diff_files = [x for x in diff_files if MatchingFileType(x, RUST_EXTS)]
Olivier Robin0a6b5442022-04-07 07:25:04 +00005295 swift_diff_files = [x for x in diff_files if MatchingFileType(x, SWIFT_EXTS)]
kylechar@chromium.org8b61f112016-02-05 13:28:58 +00005296 gn_diff_files = [x for x in diff_files if MatchingFileType(x, GN_EXTS)]
digit@chromium.org29e47272013-05-17 17:01:46 +00005297
Edward Lesmes50da7702020-03-30 19:23:43 +00005298 top_dir = settings.GetRoot()
nick@chromium.org3ac1c4e2014-01-16 02:44:42 +00005299
Jamie Madill5e96ad12020-01-13 16:08:35 +00005300 return_value = _RunClangFormatDiff(opts, clang_diff_files, top_dir,
5301 upstream_commit)
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005302
Lukasz Anforowiczb4d39542021-09-30 23:39:25 +00005303 if opts.use_rust_fmt:
5304 rust_fmt_return_value = _RunRustFmt(opts, rust_diff_files, top_dir,
5305 upstream_commit)
5306 if rust_fmt_return_value == 2:
5307 return_value = 2
5308
Olivier Robin0a6b5442022-04-07 07:25:04 +00005309 if opts.use_swift_format:
5310 if sys.platform != 'darwin':
5311 DieWithError('swift-format is only supported on macOS.')
5312 swift_format_return_value = _RunSwiftFormat(opts, swift_diff_files, top_dir,
5313 upstream_commit)
5314 if swift_format_return_value == 2:
5315 return_value = 2
5316
sbc@chromium.org9d0644d2015-06-05 23:16:54 +00005317 # Similar code to above, but using yapf on .py files rather than clang-format
5318 # on C/C++ files
Aiden Benner99b0ccb2018-11-20 19:53:31 +00005319 py_explicitly_disabled = opts.python is not None and not opts.python
5320 if python_diff_files and not py_explicitly_disabled:
Aiden Bennere47ac152018-11-20 16:44:03 +00005321 depot_tools_path = os.path.dirname(os.path.abspath(__file__))
5322 yapf_tool = os.path.join(depot_tools_path, 'yapf')
sbc@chromium.org9d0644d2015-06-05 23:16:54 +00005323
Aiden Bennerc08566e2018-10-03 17:52:42 +00005324 # Used for caching.
5325 yapf_configs = {}
5326 for f in python_diff_files:
5327 # Find the yapf style config for the current file, defaults to depot
5328 # tools default.
Aiden Benner99b0ccb2018-11-20 19:53:31 +00005329 _FindYapfConfigFile(f, yapf_configs, top_dir)
5330
5331 # Turn on python formatting by default if a yapf config is specified.
5332 # This breaks in the case of this repo though since the specified
5333 # style file is also the global default.
5334 if opts.python is None:
5335 filtered_py_files = []
5336 for f in python_diff_files:
5337 if _FindYapfConfigFile(f, yapf_configs, top_dir) is not None:
5338 filtered_py_files.append(f)
5339 else:
5340 filtered_py_files = python_diff_files
5341
5342 # Note: yapf still seems to fix indentation of the entire file
5343 # even if line ranges are specified.
5344 # See https://github.com/google/yapf/issues/499
5345 if not opts.full and filtered_py_files:
5346 py_line_diffs = _ComputeDiffLineRanges(filtered_py_files, upstream_commit)
5347
Brian Sheedyb4307d52019-12-02 19:18:17 +00005348 yapfignore_patterns = _GetYapfIgnorePatterns(top_dir)
5349 filtered_py_files = _FilterYapfIgnoredFiles(filtered_py_files,
5350 yapfignore_patterns)
Brian Sheedy59b06a82019-10-14 17:03:29 +00005351
Aiden Benner99b0ccb2018-11-20 19:53:31 +00005352 for f in filtered_py_files:
Andrew Grievefa40bfa2020-01-07 02:32:57 +00005353 yapf_style = _FindYapfConfigFile(f, yapf_configs, top_dir)
5354 # Default to pep8 if not .style.yapf is found.
5355 if not yapf_style:
5356 yapf_style = 'pep8'
Aiden Bennerc08566e2018-10-03 17:52:42 +00005357
Peter Wend9399922020-06-17 17:33:49 +00005358 with open(f, 'r') as py_f:
Andrew Grieveb9e694c2021-11-15 19:04:46 +00005359 if 'python2' in py_f.readline():
Peter Wend9399922020-06-17 17:33:49 +00005360 vpython_script = 'vpython'
Andrew Grieveb9e694c2021-11-15 19:04:46 +00005361 else:
5362 vpython_script = 'vpython3'
Peter Wend9399922020-06-17 17:33:49 +00005363
5364 cmd = [vpython_script, yapf_tool, '--style', yapf_style, f]
Aiden Bennerc08566e2018-10-03 17:52:42 +00005365
5366 has_formattable_lines = False
5367 if not opts.full:
5368 # Only run yapf over changed line ranges.
5369 for diff_start, diff_len in py_line_diffs[f]:
5370 diff_end = diff_start + diff_len - 1
5371 # Yapf errors out if diff_end < diff_start but this
5372 # is a valid line range diff for a removal.
5373 if diff_end >= diff_start:
5374 has_formattable_lines = True
5375 cmd += ['-l', '{}-{}'.format(diff_start, diff_end)]
5376 # If all line diffs were removals we have nothing to format.
5377 if not has_formattable_lines:
5378 continue
5379
5380 if opts.diff or opts.dry_run:
5381 cmd += ['--diff']
5382 # Will return non-zero exit code if non-empty diff.
Edward Lesmesb7db1832020-06-22 20:22:27 +00005383 stdout = RunCommand(cmd,
5384 error_ok=True,
Josip Sokcevic673e8ed2021-10-27 23:46:18 +00005385 stderr=subprocess2.PIPE,
Edward Lesmesb7db1832020-06-22 20:22:27 +00005386 cwd=top_dir,
5387 shell=sys.platform.startswith('win32'))
Aiden Bennerc08566e2018-10-03 17:52:42 +00005388 if opts.diff:
5389 sys.stdout.write(stdout)
5390 elif len(stdout) > 0:
5391 return_value = 2
5392 else:
5393 cmd += ['-i']
Edward Lesmesb7db1832020-06-22 20:22:27 +00005394 RunCommand(cmd, cwd=top_dir, shell=sys.platform.startswith('win32'))
sbc@chromium.org9d0644d2015-06-05 23:16:54 +00005395
kylechar@chromium.org8b61f112016-02-05 13:28:58 +00005396 # Format GN build files. Always run on full build files for canonical form.
5397 if gn_diff_files:
Andrii Shyshkalov18975322017-01-25 16:44:13 +01005398 cmd = ['gn', 'format']
brettw4b8ed592016-08-05 16:19:12 -07005399 if opts.dry_run or opts.diff:
5400 cmd.append('--dry-run')
kylechar@chromium.org8b61f112016-02-05 13:28:58 +00005401 for gn_diff_file in gn_diff_files:
brettw4b8ed592016-08-05 16:19:12 -07005402 gn_ret = subprocess2.call(cmd + [gn_diff_file],
Ilya Sherman7aed4bb2020-05-20 22:34:14 +00005403 shell=sys.platform.startswith('win'),
brettw4b8ed592016-08-05 16:19:12 -07005404 cwd=top_dir)
5405 if opts.dry_run and gn_ret == 2:
5406 return_value = 2 # Not formatted.
5407 elif opts.diff and gn_ret == 2:
5408 # TODO this should compute and print the actual diff.
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005409 print('This change has GN build file diff for ' + gn_diff_file)
brettw4b8ed592016-08-05 16:19:12 -07005410 elif gn_ret != 0:
5411 # For non-dry run cases (and non-2 return values for dry-run), a
5412 # nonzero error code indicates a failure, probably because the file
5413 # doesn't parse.
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005414 DieWithError('gn format failed on ' + gn_diff_file +
5415 '\nTry running `gn format` on this file manually.')
kylechar@chromium.org8b61f112016-02-05 13:28:58 +00005416
Ilya Shermane081cbe2017-08-15 17:51:04 -07005417 # Skip the metrics formatting from the global presubmit hook. These files have
5418 # a separate presubmit hook that issues an error if the files need formatting,
5419 # whereas the top-level presubmit script merely issues a warning. Formatting
5420 # these files is somewhat slow, so it's important not to duplicate the work.
5421 if not opts.presubmit:
Wenhan (Han) Zhang3bd3c992020-08-14 16:27:39 +00005422 for diff_xml in GetDiffXMLs(diff_files):
5423 xml_dir = GetMetricsDir(diff_xml)
5424 if not xml_dir:
5425 continue
5426
Ilya Shermane081cbe2017-08-15 17:51:04 -07005427 tool_dir = os.path.join(top_dir, xml_dir)
Ilya Sherman7aed4bb2020-05-20 22:34:14 +00005428 pretty_print_tool = os.path.join(tool_dir, 'pretty_print.py')
5429 cmd = ['vpython', pretty_print_tool, '--non-interactive']
Wenhan (Han) Zhang3bd3c992020-08-14 16:27:39 +00005430
5431 # If the XML file is histograms.xml or enums.xml, add the xml path to the
5432 # command as histograms/pretty_print.py now needs a relative path argument
5433 # after splitting the histograms into multiple directories.
5434 # For example, in tools/metrics/ukm, pretty-print could be run using:
5435 # $ python pretty_print.py
5436 # But in tools/metrics/histogrmas, pretty-print should be run with an
5437 # additional relative path argument, like:
Peter Kastingee088882021-08-03 17:57:00 +00005438 # $ python pretty_print.py metadata/UMA/histograms.xml
Wenhan (Han) Zhang3bd3c992020-08-14 16:27:39 +00005439 # $ python pretty_print.py enums.xml
5440
5441 # TODO (crbug/1116488): Remove this check after ensuring that the updated
5442 # version of histograms/pretty_print.py is released.
5443 filepath_required = os.path.exists(
5444 os.path.join(tool_dir, 'validate_prefix.py'))
5445
Weilun Shib92c4b72020-08-27 17:45:11 +00005446 if (diff_xml.endswith('histograms.xml') or diff_xml.endswith('enums.xml')
5447 or diff_xml.endswith('histogram_suffixes_list.xml')
5448 ) and filepath_required:
Wenhan (Han) Zhang3bd3c992020-08-14 16:27:39 +00005449 cmd.append(diff_xml)
5450
Ilya Shermane081cbe2017-08-15 17:51:04 -07005451 if opts.dry_run or opts.diff:
5452 cmd.append('--diff')
Wenhan (Han) Zhang3bd3c992020-08-14 16:27:39 +00005453
Ilya Sherman7aed4bb2020-05-20 22:34:14 +00005454 # TODO(isherman): Once this file runs only on Python 3.3+, drop the
5455 # `shell` param and instead replace `'vpython'` with
5456 # `shutil.which('frob')` above: https://stackoverflow.com/a/32799942
Wenhan (Han) Zhang3bd3c992020-08-14 16:27:39 +00005457 stdout = RunCommand(cmd,
5458 cwd=top_dir,
Ilya Sherman7aed4bb2020-05-20 22:34:14 +00005459 shell=sys.platform.startswith('win32'))
Ilya Shermane081cbe2017-08-15 17:51:04 -07005460 if opts.diff:
5461 sys.stdout.write(stdout)
5462 if opts.dry_run and stdout:
5463 return_value = 2 # Not formatted.
Alexei Svitkinef3cac412017-02-06 11:08:50 -05005464
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005465 return return_value
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005466
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005467
Wenhan (Han) Zhang3bd3c992020-08-14 16:27:39 +00005468def GetDiffXMLs(diff_files):
5469 return [
5470 os.path.normpath(x) for x in diff_files if MatchingFileType(x, ['.xml'])
5471 ]
5472
5473
5474def GetMetricsDir(diff_xml):
Steven Holte2e664bf2017-04-21 13:10:47 -07005475 metrics_xml_dirs = [
5476 os.path.join('tools', 'metrics', 'actions'),
5477 os.path.join('tools', 'metrics', 'histograms'),
5478 os.path.join('tools', 'metrics', 'rappor'),
Ilya Shermanb67e60c2020-05-20 22:27:03 +00005479 os.path.join('tools', 'metrics', 'structured'),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005480 os.path.join('tools', 'metrics', 'ukm'),
5481 ]
Steven Holte2e664bf2017-04-21 13:10:47 -07005482 for xml_dir in metrics_xml_dirs:
Wenhan (Han) Zhang3bd3c992020-08-14 16:27:39 +00005483 if diff_xml.startswith(xml_dir):
5484 return xml_dir
5485 return None
Steven Holte2e664bf2017-04-21 13:10:47 -07005486
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005487
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005488@subcommand.usage('<codereview url or issue id>')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005489@metrics.collector.collect_metrics('git cl checkout')
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005490def CMDcheckout(parser, args):
Edward Lemurf38bc172019-09-03 21:02:13 +00005491 """Checks out a branch associated with a given Gerrit issue."""
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005492 _, args = parser.parse_args(args)
5493
5494 if len(args) != 1:
5495 parser.print_help()
5496 return 1
5497
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00005498 issue_arg = ParseIssueNumberArgument(args[0])
tandrii@chromium.orgde6c9a12016-04-11 15:33:53 +00005499 if not issue_arg.valid:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00005500 parser.error('Invalid issue ID or URL.')
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02005501
tandrii@chromium.orgabd27e52016-04-11 15:43:32 +00005502 target_issue = str(issue_arg.issue)
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005503
Edward Lemur52969c92020-02-06 18:15:28 +00005504 output = RunGit(['config', '--local', '--get-regexp',
Edward Lesmes50da7702020-03-30 19:23:43 +00005505 r'branch\..*\.' + ISSUE_CONFIG_KEY],
Edward Lemur52969c92020-02-06 18:15:28 +00005506 error_ok=True)
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005507
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00005508 branches = []
Edward Lemur52969c92020-02-06 18:15:28 +00005509 for key, issue in [x.split() for x in output.splitlines()]:
5510 if issue == target_issue:
Edward Lesmes50da7702020-03-30 19:23:43 +00005511 branches.append(re.sub(r'branch\.(.*)\.' + ISSUE_CONFIG_KEY, r'\1', key))
Edward Lemur52969c92020-02-06 18:15:28 +00005512
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005513 if len(branches) == 0:
vapiera7fbd5a2016-06-16 09:17:49 -07005514 print('No branch found for issue %s.' % target_issue)
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005515 return 1
5516 if len(branches) == 1:
5517 RunGit(['checkout', branches[0]])
5518 else:
vapiera7fbd5a2016-06-16 09:17:49 -07005519 print('Multiple branches match issue %s:' % target_issue)
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005520 for i in range(len(branches)):
vapiera7fbd5a2016-06-16 09:17:49 -07005521 print('%d: %s' % (i, branches[i]))
Edward Lesmesae3586b2020-03-23 21:21:14 +00005522 which = gclient_utils.AskForData('Choose by index: ')
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005523 try:
5524 RunGit(['checkout', branches[int(which)]])
5525 except (IndexError, ValueError):
vapiera7fbd5a2016-06-16 09:17:49 -07005526 print('Invalid selection, not checking out any branch.')
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005527 return 1
5528
5529 return 0
5530
5531
maruel@chromium.org29404b52014-09-08 22:58:00 +00005532def CMDlol(parser, args):
5533 # This command is intentionally undocumented.
vapiera7fbd5a2016-06-16 09:17:49 -07005534 print(zlib.decompress(base64.b64decode(
thakis@chromium.org3421c992014-11-02 02:20:32 +00005535 'eNptkLEOwyAMRHe+wupCIqW57v0Vq84WqWtXyrcXnCBsmgMJ+/SSAxMZgRB6NzE'
5536 'E2ObgCKJooYdu4uAQVffUEoE1sRQLxAcqzd7uK2gmStrll1ucV3uZyaY5sXyDd9'
5537 'JAnN+lAXsOMJ90GANAi43mq5/VeeacylKVgi8o6F1SC63FxnagHfJUTfUYdCR/W'
Gavin Mak18f45d22020-12-04 21:45:10 +00005538 'Ofe+0dHL7PicpytKP750Fh1q2qnLVof4w8OZWNY')).decode('utf-8'))
maruel@chromium.org29404b52014-09-08 22:58:00 +00005539 return 0
5540
5541
Josip Sokcevic0399e172022-03-21 23:11:51 +00005542def CMDversion(parser, args):
5543 import utils
5544 print(utils.depot_tools_version())
5545
5546
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005547class OptionParser(optparse.OptionParser):
5548 """Creates the option parse and add --verbose support."""
Sigurd Schneider9abde8c2020-11-17 08:44:52 +00005549
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005550 def __init__(self, *args, **kwargs):
maruel@chromium.org0633fb42013-08-16 20:06:14 +00005551 optparse.OptionParser.__init__(
5552 self, *args, prog='git cl', version=__version__, **kwargs)
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005553 self.add_option(
5554 '-v', '--verbose', action='count', default=0,
5555 help='Use 2 times for more debugging info')
5556
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005557 def parse_args(self, args=None, _values=None):
Andrii Shyshkalov46f20cd2018-10-30 06:42:54 +00005558 try:
5559 return self._parse_args(args)
5560 finally:
5561 # Regardless of success or failure of args parsing, we want to report
5562 # metrics, but only after logging has been initialized (if parsing
5563 # succeeded).
5564 global settings
5565 settings = Settings()
5566
Edward Lesmes9c349062021-05-06 20:02:39 +00005567 if metrics.collector.config.should_collect_metrics:
Andrii Shyshkalov46f20cd2018-10-30 06:42:54 +00005568 # GetViewVCUrl ultimately calls logging method.
5569 project_url = settings.GetViewVCUrl().strip('/+')
5570 if project_url in metrics_utils.KNOWN_PROJECT_URLS:
5571 metrics.collector.add('project_urls', [project_url])
5572
5573 def _parse_args(self, args=None):
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005574 # Create an optparse.Values object that will store only the actual passed
5575 # options, without the defaults.
5576 actual_options = optparse.Values()
5577 _, args = optparse.OptionParser.parse_args(self, args, actual_options)
5578 # Create an optparse.Values object with the default options.
5579 options = optparse.Values(self.get_default_values().__dict__)
5580 # Update it with the options passed by the user.
5581 options._update_careful(actual_options.__dict__)
5582 # Store the options passed by the user in an _actual_options attribute.
5583 # We store only the keys, and not the values, since the values can contain
5584 # arbitrary information, which might be PII.
Edward Lemur79d4f992019-11-11 23:49:02 +00005585 metrics.collector.add('arguments', list(actual_options.__dict__.keys()))
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005586
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005587 levels = [logging.WARNING, logging.INFO, logging.DEBUG]
Andrii Shyshkalov5b04a572017-01-23 17:44:41 +01005588 logging.basicConfig(
5589 level=levels[min(options.verbose, len(levels) - 1)],
5590 format='[%(levelname).1s%(asctime)s %(process)d %(thread)d '
5591 '%(filename)s] %(message)s')
Edward Lemur83bd7f42018-10-10 00:14:21 +00005592
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005593 return options, args
5594
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005595
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005596def main(argv):
maruel@chromium.org82798cb2012-02-23 18:16:12 +00005597 if sys.hexversion < 0x02060000:
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005598 print('\nYour Python version %s is unsupported, please upgrade.\n' %
vapiera7fbd5a2016-06-16 09:17:49 -07005599 (sys.version.split(' ', 1)[0],), file=sys.stderr)
maruel@chromium.org82798cb2012-02-23 18:16:12 +00005600 return 2
maruel@chromium.org2e23ce32013-05-07 12:42:28 +00005601
maruel@chromium.org39c0b222013-08-17 16:57:01 +00005602 colorize_CMDstatus_doc()
maruel@chromium.org0633fb42013-08-16 20:06:14 +00005603 dispatcher = subcommand.CommandDispatcher(__name__)
5604 try:
5605 return dispatcher.execute(OptionParser(), argv)
Edward Lemur5b929a42019-10-21 17:57:39 +00005606 except auth.LoginRequiredError as e:
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +00005607 DieWithError(str(e))
Edward Lemur79d4f992019-11-11 23:49:02 +00005608 except urllib.error.HTTPError as e:
maruel@chromium.org0633fb42013-08-16 20:06:14 +00005609 if e.code != 500:
5610 raise
5611 DieWithError(
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005612 ('App Engine is misbehaving and returned HTTP %d, again. Keep faith '
Quinten Yearsleyc4202212019-07-22 23:34:40 +00005613 'and retry or visit go/isgaeup.\n%s') % (e.code, str(e)))
sbc@chromium.org013731e2015-02-26 18:28:43 +00005614 return 0
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005615
5616
5617if __name__ == '__main__':
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005618 # These affect sys.stdout, so do it outside of main() to simplify mocks in
5619 # the unit tests.
maruel@chromium.org6f09cd92011-04-01 16:38:12 +00005620 fix_encoding.fix_encoding()
iannucci@chromium.org596cd5c2016-04-04 21:34:39 +00005621 setup_color.init()
Edward Lemur6f812e12018-07-31 22:45:57 +00005622 with metrics.collector.print_notice_and_exit():
sbc@chromium.org013731e2015-02-26 18:28:43 +00005623 sys.exit(main(sys.argv[1:]))