blob: 054f659059b6938b8b46d8aaf1f4cac73728e93f [file] [log] [blame]
Josip Sokcevic4de5dea2022-03-23 21:15:14 +00001#!/usr/bin/env vpython3
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +02002# Copyright (c) 2013 The Chromium Authors. All rights reserved.
maruel@chromium.org725f1c32011-04-01 20:24:54 +00003# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00006# Copyright (C) 2008 Evan Martin <martine@danga.com>
7
Andrii Shyshkalov03da1502018-10-15 03:42:34 +00008"""A git-command for integrating reviews on Gerrit."""
maruel@chromium.org725f1c32011-04-01 20:24:54 +00009
vapiera7fbd5a2016-06-16 09:17:49 -070010from __future__ import print_function
11
thakis@chromium.org3421c992014-11-02 02:20:32 +000012import base64
rmistry@google.com2dd99862015-06-22 12:22:18 +000013import collections
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +010014import datetime
Brian Sheedyb4307d52019-12-02 19:18:17 +000015import fnmatch
Edward Lemur202c5592019-10-21 22:44:52 +000016import httplib2
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +010017import itertools
maruel@chromium.org4f6852c2012-04-20 20:39:20 +000018import json
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000019import logging
calamity@chromium.orgcf197482016-04-29 20:15:53 +000020import multiprocessing
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000021import optparse
22import os
23import re
Andrii Shyshkalov353637c2017-03-14 16:52:18 +010024import shutil
ukai@chromium.org78c4b982012-02-14 02:20:26 +000025import stat
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000026import sys
Aaron Gable9a03ae02017-11-03 11:31:07 -070027import tempfile
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000028import textwrap
Edward Lemurfec80c42018-11-01 23:14:14 +000029import time
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +000030import uuid
thestig@chromium.org00858c82013-12-02 23:08:03 +000031import webbrowser
thakis@chromium.org3421c992014-11-02 02:20:32 +000032import zlib
chase@chromium.orgcc51cd02010-12-23 00:48:39 +000033
maruel@chromium.org2e23ce32013-05-07 12:42:28 +000034from third_party import colorama
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +000035import auth
nick@chromium.org3ac1c4e2014-01-16 02:44:42 +000036import clang_format
maruel@chromium.org6f09cd92011-04-01 16:38:12 +000037import fix_encoding
maruel@chromium.org0e0436a2011-10-25 13:32:41 +000038import gclient_utils
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +000039import gerrit_util
iannucci@chromium.org9e849272014-04-04 00:31:55 +000040import git_common
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +000041import git_footers
Edward Lemur85153282020-02-14 22:06:29 +000042import git_new_branch
Edward Lemur5ba1e9c2018-07-23 18:19:02 +000043import metrics
Edward Lesmes93277a72018-10-18 22:04:26 +000044import metrics_utils
Edward Lesmeseeca9c62020-11-20 00:00:17 +000045import owners_client
iannucci@chromium.org9e849272014-04-04 00:31:55 +000046import owners_finder
Lei Zhangb8c62cf2020-07-15 20:09:37 +000047import presubmit_canned_checks
maruel@chromium.org2a74d372011-03-29 19:05:50 +000048import presubmit_support
Lukasz Anforowiczb4d39542021-09-30 23:39:25 +000049import rustfmt
maruel@chromium.org2a74d372011-03-29 19:05:50 +000050import scm
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +000051import setup_color
Francois Dorayd42c6812017-05-30 15:10:20 -040052import split_cl
maruel@chromium.org0633fb42013-08-16 20:06:14 +000053import subcommand
maruel@chromium.org32f9f5e2011-09-14 13:41:47 +000054import subprocess2
Olivier Robin0a6b5442022-04-07 07:25:04 +000055import swift_format
maruel@chromium.org2a74d372011-03-29 19:05:50 +000056import watchlists
57
Edward Lemur79d4f992019-11-11 23:49:02 +000058from third_party import six
59from six.moves import urllib
60
61
62if sys.version_info.major == 3:
63 basestring = (str,) # pylint: disable=redefined-builtin
64
Edward Lemurb9830242019-10-30 22:19:20 +000065
tandrii7400cf02016-06-21 08:48:07 -070066__version__ = '2.0'
maruel@chromium.org2a74d372011-03-29 19:05:50 +000067
Edward Lemur0f58ae42019-04-30 17:24:12 +000068# Traces for git push will be stored in a traces directory inside the
69# depot_tools checkout.
70DEPOT_TOOLS = os.path.dirname(os.path.abspath(__file__))
71TRACES_DIR = os.path.join(DEPOT_TOOLS, 'traces')
Edward Lemur227d5102020-02-25 23:45:35 +000072PRESUBMIT_SUPPORT = os.path.join(DEPOT_TOOLS, 'presubmit_support.py')
Edward Lemur0f58ae42019-04-30 17:24:12 +000073
74# When collecting traces, Git hashes will be reduced to 6 characters to reduce
75# the size after compression.
76GIT_HASH_RE = re.compile(r'\b([a-f0-9]{6})[a-f0-9]{34}\b', flags=re.I)
77# Used to redact the cookies from the gitcookies file.
78GITCOOKIES_REDACT_RE = re.compile(r'1/.*')
79
Edward Lemurd4d1ba42019-09-20 21:46:37 +000080MAX_ATTEMPTS = 3
81
Edward Lemur1b52d872019-05-09 21:12:12 +000082# The maximum number of traces we will keep. Multiplied by 3 since we store
83# 3 files per trace.
84MAX_TRACES = 3 * 10
Edward Lemur5737f022019-05-17 01:24:00 +000085# Message to be displayed to the user to inform where to find the traces for a
86# git-cl upload execution.
Edward Lemur0f58ae42019-04-30 17:24:12 +000087TRACES_MESSAGE = (
Edward Lemur1b52d872019-05-09 21:12:12 +000088'\n'
Edward Lemur5737f022019-05-17 01:24:00 +000089'The traces of this git-cl execution have been recorded at:\n'
Edward Lemur1b52d872019-05-09 21:12:12 +000090' %(trace_name)s-traces.zip\n'
Edward Lemur5737f022019-05-17 01:24:00 +000091'Copies of your gitcookies file and git config have been recorded at:\n'
92' %(trace_name)s-git-info.zip\n')
Edward Lemur1b52d872019-05-09 21:12:12 +000093# Format of the message to be stored as part of the traces to give developers a
94# better context when they go through traces.
95TRACES_README_FORMAT = (
96'Date: %(now)s\n'
97'\n'
98'Change: https://%(gerrit_host)s/q/%(change_id)s\n'
99'Title: %(title)s\n'
100'\n'
101'%(description)s\n'
102'\n'
103'Execution time: %(execution_time)s\n'
104'Exit code: %(exit_code)s\n') + TRACES_MESSAGE
Edward Lemur0f58ae42019-04-30 17:24:12 +0000105
Aaron Gable1bc7bfe2016-12-19 10:08:14 -0800106POSTUPSTREAM_HOOK = '.git/hooks/post-cl-land'
Henrique Ferreiroff249622019-11-28 23:19:29 +0000107DESCRIPTION_BACKUP_FILE = '.git_cl_description_backup'
rmistry@google.comc68112d2015-03-03 12:48:06 +0000108REFS_THAT_ALIAS_TO_OTHER_REFS = {
Josip Sokcevic7e133ff2021-07-13 17:44:53 +0000109 'refs/remotes/origin/lkgr': 'refs/remotes/origin/main',
110 'refs/remotes/origin/lkcr': 'refs/remotes/origin/main',
rmistry@google.comc68112d2015-03-03 12:48:06 +0000111}
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000112
Josip Sokcevicc39ab992020-09-24 20:09:15 +0000113DEFAULT_OLD_BRANCH = 'refs/remotes/origin/master'
114DEFAULT_NEW_BRANCH = 'refs/remotes/origin/main'
115
thestig@chromium.org44202a22014-03-11 19:22:18 +0000116# Valid extensions for files we want to lint.
117DEFAULT_LINT_REGEX = r"(.*\.cpp|.*\.cc|.*\.h)"
118DEFAULT_LINT_IGNORE_REGEX = r"$^"
119
Aiden Bennerc08566e2018-10-03 17:52:42 +0000120# File name for yapf style config files.
121YAPF_CONFIG_FILENAME = '.style.yapf'
122
Edward Lesmes50da7702020-03-30 19:23:43 +0000123# The issue, patchset and codereview server are stored on git config for each
124# branch under branch.<branch-name>.<config-key>.
125ISSUE_CONFIG_KEY = 'gerritissue'
126PATCHSET_CONFIG_KEY = 'gerritpatchset'
127CODEREVIEW_SERVER_CONFIG_KEY = 'gerritserver'
128
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000129# Shortcut since it quickly becomes repetitive.
maruel@chromium.org2e23ce32013-05-07 12:42:28 +0000130Fore = colorama.Fore
maruel@chromium.org90541732011-04-01 17:54:18 +0000131
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000132# Initialized in main()
133settings = None
134
Andrii Shyshkalov768f1d82016-12-08 15:10:13 +0100135# Used by tests/git_cl_test.py to add extra logging.
136# Inside the weirdly failing test, add this:
137# >>> self.mock(git_cl, '_IS_BEING_TESTED', True)
Quinten Yearsley0c62da92017-05-31 13:39:42 -0700138# And scroll up to see the stack trace printed.
Andrii Shyshkalov768f1d82016-12-08 15:10:13 +0100139_IS_BEING_TESTED = False
140
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000141
Andrii Shyshkalov1ee78cd2020-03-12 01:31:53 +0000142_KNOWN_GERRIT_TO_SHORT_URLS = {
143 'https://chrome-internal-review.googlesource.com': 'https://crrev.com/i',
144 'https://chromium-review.googlesource.com': 'https://crrev.com/c',
145}
Andrii Shyshkalov8aebb602020-04-16 22:10:27 +0000146assert len(_KNOWN_GERRIT_TO_SHORT_URLS) == len(
147 set(_KNOWN_GERRIT_TO_SHORT_URLS.values())), 'must have unique values'
Andrii Shyshkalov1ee78cd2020-03-12 01:31:53 +0000148
149
Josip Sokcevicf736cab2020-10-20 23:41:38 +0000150class GitPushError(Exception):
151 pass
152
153
Christopher Lamf732cd52017-01-24 12:40:11 +1100154def DieWithError(message, change_desc=None):
155 if change_desc:
156 SaveDescriptionBackup(change_desc)
Josip Sokcevic953278a2020-02-28 19:46:36 +0000157 print('\n ** Content of CL description **\n' +
158 '='*72 + '\n' +
159 change_desc.description + '\n' +
160 '='*72 + '\n')
Christopher Lamf732cd52017-01-24 12:40:11 +1100161
vapiera7fbd5a2016-06-16 09:17:49 -0700162 print(message, file=sys.stderr)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000163 sys.exit(1)
164
165
Christopher Lamf732cd52017-01-24 12:40:11 +1100166def SaveDescriptionBackup(change_desc):
Henrique Ferreiro5ae48172019-11-29 16:14:42 +0000167 backup_path = os.path.join(DEPOT_TOOLS, DESCRIPTION_BACKUP_FILE)
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000168 print('\nsaving CL description to %s\n' % backup_path)
sokcevic07152802021-08-18 00:06:34 +0000169 with open(backup_path, 'wb') as backup_file:
170 backup_file.write(change_desc.description.encode('utf-8'))
Christopher Lamf732cd52017-01-24 12:40:11 +1100171
172
thestig@chromium.org8b0553c2014-02-11 00:33:37 +0000173def GetNoGitPagerEnv():
174 env = os.environ.copy()
175 # 'cat' is a magical git string that disables pagers on all platforms.
176 env['GIT_PAGER'] = 'cat'
177 return env
178
vadimsh@chromium.org566a02a2014-08-22 01:34:13 +0000179
bsep@chromium.org627d9002016-04-29 00:00:52 +0000180def RunCommand(args, error_ok=False, error_message=None, shell=False, **kwargs):
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000181 try:
Edward Lemur79d4f992019-11-11 23:49:02 +0000182 stdout = subprocess2.check_output(args, shell=shell, **kwargs)
183 return stdout.decode('utf-8', 'replace')
maruel@chromium.org78936cb2013-04-11 00:17:52 +0000184 except subprocess2.CalledProcessError as e:
185 logging.debug('Failed running %s', args)
maruel@chromium.org32f9f5e2011-09-14 13:41:47 +0000186 if not error_ok:
Alan Cutter594fd332020-07-21 23:55:27 +0000187 message = error_message or e.stdout.decode('utf-8', 'replace') or ''
188 DieWithError('Command "%s" failed.\n%s' % (' '.join(args), message))
Josip Sokcevic673e8ed2021-10-27 23:46:18 +0000189 out = e.stdout.decode('utf-8', 'replace')
190 if e.stderr:
191 out += e.stderr.decode('utf-8', 'replace')
192 return out
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000193
194
195def RunGit(args, **kwargs):
maruel@chromium.org32f9f5e2011-09-14 13:41:47 +0000196 """Returns stdout."""
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000197 return RunCommand(['git'] + args, **kwargs)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000198
199
enne@chromium.org3b7e15c2014-01-21 17:44:47 +0000200def RunGitWithCode(args, suppress_stderr=False):
maruel@chromium.org32f9f5e2011-09-14 13:41:47 +0000201 """Returns return code and stdout."""
tandrii5d48c322016-08-18 16:19:37 -0700202 if suppress_stderr:
Edward Lesmescf06cad2020-12-14 22:03:23 +0000203 stderr = subprocess2.DEVNULL
tandrii5d48c322016-08-18 16:19:37 -0700204 else:
205 stderr = sys.stderr
szager@chromium.org9bb85e22012-06-13 20:28:23 +0000206 try:
tandrii5d48c322016-08-18 16:19:37 -0700207 (out, _), code = subprocess2.communicate(['git'] + args,
208 env=GetNoGitPagerEnv(),
209 stdout=subprocess2.PIPE,
210 stderr=stderr)
Edward Lemur79d4f992019-11-11 23:49:02 +0000211 return code, out.decode('utf-8', 'replace')
tandrii5d48c322016-08-18 16:19:37 -0700212 except subprocess2.CalledProcessError as e:
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +0900213 logging.debug('Failed running %s', ['git'] + args)
Edward Lemur79d4f992019-11-11 23:49:02 +0000214 return e.returncode, e.stdout.decode('utf-8', 'replace')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000215
216
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000217def RunGitSilent(args):
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +0000218 """Returns stdout, suppresses stderr and ignores the return code."""
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000219 return RunGitWithCode(args, suppress_stderr=True)[1]
220
221
tandrii2a16b952016-10-19 07:09:44 -0700222def time_sleep(seconds):
223 # Use this so that it can be mocked in tests without interfering with python
224 # system machinery.
tandrii2a16b952016-10-19 07:09:44 -0700225 return time.sleep(seconds)
226
227
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000228def time_time():
229 # Use this so that it can be mocked in tests without interfering with python
230 # system machinery.
231 return time.time()
232
233
Edward Lemur1b52d872019-05-09 21:12:12 +0000234def datetime_now():
235 # Use this so that it can be mocked in tests without interfering with python
236 # system machinery.
237 return datetime.datetime.now()
238
239
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100240def confirm_or_exit(prefix='', action='confirm'):
241 """Asks user to press enter to continue or press Ctrl+C to abort."""
242 if not prefix or prefix.endswith('\n'):
243 mid = 'Press'
Andrii Shyshkalov353637c2017-03-14 16:52:18 +0100244 elif prefix.endswith('.') or prefix.endswith('?'):
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100245 mid = ' Press'
246 elif prefix.endswith(' '):
247 mid = 'press'
248 else:
249 mid = ' press'
Edward Lesmesae3586b2020-03-23 21:21:14 +0000250 gclient_utils.AskForData(
251 '%s%s Enter to %s, or Ctrl+C to abort' % (prefix, mid, action))
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100252
253
254def ask_for_explicit_yes(prompt):
Quinten Yearsleyd242ed72019-07-25 17:17:55 +0000255 """Returns whether user typed 'y' or 'yes' to confirm the given prompt."""
Edward Lesmesae3586b2020-03-23 21:21:14 +0000256 result = gclient_utils.AskForData(prompt + ' [Yes/No]: ').lower()
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100257 while True:
258 if 'yes'.startswith(result):
259 return True
260 if 'no'.startswith(result):
261 return False
Edward Lesmesae3586b2020-03-23 21:21:14 +0000262 result = gclient_utils.AskForData('Please, type yes or no: ').lower()
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100263
264
machenbach@chromium.org45453142015-09-15 08:45:22 +0000265def _get_properties_from_options(options):
Quinten Yearsleya19d3532019-09-30 21:54:39 +0000266 prop_list = getattr(options, 'properties', [])
267 properties = dict(x.split('=', 1) for x in prop_list)
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +0000268 for key, val in properties.items():
machenbach@chromium.org45453142015-09-15 08:45:22 +0000269 try:
270 properties[key] = json.loads(val)
271 except ValueError:
272 pass # If a value couldn't be evaluated, treat it as a string.
273 return properties
274
275
Edward Lemur4c707a22019-09-24 21:13:43 +0000276def _call_buildbucket(http, buildbucket_host, method, request):
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000277 """Calls a buildbucket v2 method and returns the parsed json response."""
278 headers = {
279 'Accept': 'application/json',
280 'Content-Type': 'application/json',
281 }
282 request = json.dumps(request)
283 url = 'https://%s/prpc/buildbucket.v2.Builds/%s' % (buildbucket_host, method)
284
285 logging.info('POST %s with %s' % (url, request))
286
287 attempts = 1
288 time_to_sleep = 1
289 while True:
290 response, content = http.request(url, 'POST', body=request, headers=headers)
291 if response.status == 200:
292 return json.loads(content[4:])
293 if attempts >= MAX_ATTEMPTS or 400 <= response.status < 500:
294 msg = '%s error when calling POST %s with %s: %s' % (
295 response.status, url, request, content)
296 raise BuildbucketResponseException(msg)
297 logging.debug(
298 '%s error when calling POST %s with %s. '
299 'Sleeping for %d seconds and retrying...' % (
300 response.status, url, request, time_to_sleep))
301 time.sleep(time_to_sleep)
302 time_to_sleep *= 2
303 attempts += 1
304
305 assert False, 'unreachable'
306
307
Edward Lemur6215c792019-10-03 21:59:05 +0000308def _parse_bucket(raw_bucket):
309 legacy = True
310 project = bucket = None
311 if '/' in raw_bucket:
312 legacy = False
313 project, bucket = raw_bucket.split('/', 1)
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000314 # Assume luci.<project>.<bucket>.
Edward Lemur6215c792019-10-03 21:59:05 +0000315 elif raw_bucket.startswith('luci.'):
316 project, bucket = raw_bucket[len('luci.'):].split('.', 1)
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000317 # Otherwise, assume prefix is also the project name.
Edward Lemur6215c792019-10-03 21:59:05 +0000318 elif '.' in raw_bucket:
319 project = raw_bucket.split('.')[0]
320 bucket = raw_bucket
321 # Legacy buckets.
Edward Lemur45768512020-03-02 19:03:14 +0000322 if legacy and project and bucket:
Edward Lemur6215c792019-10-03 21:59:05 +0000323 print('WARNING Please use %s/%s to specify the bucket.' % (project, bucket))
324 return project, bucket
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000325
326
Quinten Yearsley777660f2020-03-04 23:37:06 +0000327def _trigger_tryjobs(changelist, jobs, options, patchset):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000328 """Sends a request to Buildbucket to trigger tryjobs for a changelist.
qyearsley1fdfcb62016-10-24 13:22:03 -0700329
330 Args:
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000331 changelist: Changelist that the tryjobs are associated with.
Edward Lemur45768512020-03-02 19:03:14 +0000332 jobs: A list of (project, bucket, builder).
qyearsley1fdfcb62016-10-24 13:22:03 -0700333 options: Command-line options.
334 """
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000335 print('Scheduling jobs on:')
Edward Lemur45768512020-03-02 19:03:14 +0000336 for project, bucket, builder in jobs:
337 print(' %s/%s: %s' % (project, bucket, builder))
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000338 print('To see results here, run: git cl try-results')
339 print('To see results in browser, run: git cl web')
tandriide281ae2016-10-12 06:02:30 -0700340
Quinten Yearsley777660f2020-03-04 23:37:06 +0000341 requests = _make_tryjob_schedule_requests(changelist, jobs, options, patchset)
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +0000342 if not requests:
343 return
344
Edward Lemur5b929a42019-10-21 17:57:39 +0000345 http = auth.Authenticator().authorize(httplib2.Http())
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +0000346 http.force_exception_to_status_code = True
347
348 batch_request = {'requests': requests}
349 batch_response = _call_buildbucket(
350 http, options.buildbucket_host, 'Batch', batch_request)
351
352 errors = [
353 ' ' + response['error']['message']
354 for response in batch_response.get('responses', [])
355 if 'error' in response
356 ]
357 if errors:
358 raise BuildbucketResponseException(
359 'Failed to schedule builds for some bots:\n%s' % '\n'.join(errors))
360
361
Quinten Yearsley777660f2020-03-04 23:37:06 +0000362def _make_tryjob_schedule_requests(changelist, jobs, options, patchset):
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +0000363 """Constructs requests for Buildbucket to trigger tryjobs."""
Edward Lemurf0faf482019-09-25 20:40:17 +0000364 gerrit_changes = [changelist.GetGerritChange(patchset)]
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +0000365 shared_properties = {
366 'category': options.ensure_value('category', 'git_cl_try')
367 }
368 if options.ensure_value('clobber', False):
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000369 shared_properties['clobber'] = True
370 shared_properties.update(_get_properties_from_options(options) or {})
371
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +0000372 shared_tags = [{'key': 'user_agent', 'value': 'git_cl_try'}]
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +0000373 if options.ensure_value('retry_failed', False):
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +0000374 shared_tags.append({'key': 'retry_failed',
375 'value': '1'})
376
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000377 requests = []
Edward Lemur45768512020-03-02 19:03:14 +0000378 for (project, bucket, builder) in jobs:
379 properties = shared_properties.copy()
380 if 'presubmit' in builder.lower():
381 properties['dry_run'] = 'true'
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000382
Edward Lemur45768512020-03-02 19:03:14 +0000383 requests.append({
384 'scheduleBuild': {
385 'requestId': str(uuid.uuid4()),
386 'builder': {
387 'project': getattr(options, 'project', None) or project,
388 'bucket': bucket,
389 'builder': builder,
390 },
391 'gerritChanges': gerrit_changes,
392 'properties': properties,
393 'tags': [
394 {'key': 'builder', 'value': builder},
395 ] + shared_tags,
396 }
397 })
Edward Lemurd4d1ba42019-09-20 21:46:37 +0000398
Quinten Yearsleyee8be8a2020-03-05 21:48:32 +0000399 if options.ensure_value('revision', None):
Josip Sokcevic9011a5b2021-02-12 18:59:44 +0000400 remote, remote_branch = changelist.GetRemoteBranch()
Edward Lemur45768512020-03-02 19:03:14 +0000401 requests[-1]['scheduleBuild']['gitilesCommit'] = {
402 'host': gerrit_changes[0]['host'],
403 'project': gerrit_changes[0]['project'],
Josip Sokcevic9011a5b2021-02-12 18:59:44 +0000404 'id': options.revision,
405 'ref': GetTargetRef(remote, remote_branch, None)
Edward Lemur45768512020-03-02 19:03:14 +0000406 }
Anthony Polito1a5fe232020-01-24 23:17:52 +0000407
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +0000408 return requests
kjellander@chromium.org44424542015-06-02 18:35:29 +0000409
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000410
Quinten Yearsley777660f2020-03-04 23:37:06 +0000411def _fetch_tryjobs(changelist, buildbucket_host, patchset=None):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000412 """Fetches tryjobs from buildbucket.
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000413
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000414 Returns list of buildbucket.v2.Build with the try jobs for the changelist.
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000415 """
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +0000416 fields = ['id', 'builder', 'status', 'createTime', 'tags']
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000417 request = {
418 'predicate': {
419 'gerritChanges': [changelist.GetGerritChange(patchset)],
420 },
421 'fields': ','.join('builds.*.' + field for field in fields),
422 }
tandrii221ab252016-10-06 08:12:04 -0700423
Edward Lemur5b929a42019-10-21 17:57:39 +0000424 authenticator = auth.Authenticator()
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000425 if authenticator.has_cached_credentials():
426 http = authenticator.authorize(httplib2.Http())
427 else:
vapiera7fbd5a2016-06-16 09:17:49 -0700428 print('Warning: Some results might be missing because %s' %
429 # Get the message on how to login.
Andrii Shyshkalov2517afd2021-01-19 17:07:43 +0000430 (str(auth.LoginRequiredError()),))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000431 http = httplib2.Http()
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000432 http.force_exception_to_status_code = True
433
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000434 response = _call_buildbucket(http, buildbucket_host, 'SearchBuilds', request)
435 return response.get('builds', [])
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000436
Edward Lemur45768512020-03-02 19:03:14 +0000437
Edward Lemur5b929a42019-10-21 17:57:39 +0000438def _fetch_latest_builds(changelist, buildbucket_host, latest_patchset=None):
Quinten Yearsley983111f2019-09-26 17:18:48 +0000439 """Fetches builds from the latest patchset that has builds (within
440 the last few patchsets).
441
442 Args:
Quinten Yearsley983111f2019-09-26 17:18:48 +0000443 changelist (Changelist): The CL to fetch builds for
444 buildbucket_host (str): Buildbucket host, e.g. "cr-buildbucket.appspot.com"
Andrii Shyshkalov1ad58112019-10-08 01:46:14 +0000445 lastest_patchset(int|NoneType): the patchset to start fetching builds from.
446 If None (default), starts with the latest available patchset.
Quinten Yearsley983111f2019-09-26 17:18:48 +0000447 Returns:
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000448 A tuple (builds, patchset) where builds is a list of buildbucket.v2.Build,
449 and patchset is the patchset number where those builds came from.
Quinten Yearsley983111f2019-09-26 17:18:48 +0000450 """
451 assert buildbucket_host
452 assert changelist.GetIssue(), 'CL must be uploaded first'
453 assert changelist.GetCodereviewServer(), 'CL must be uploaded first'
Andrii Shyshkalov1ad58112019-10-08 01:46:14 +0000454 if latest_patchset is None:
455 assert changelist.GetMostRecentPatchset()
456 ps = changelist.GetMostRecentPatchset()
457 else:
458 assert latest_patchset > 0, latest_patchset
459 ps = latest_patchset
460
Quinten Yearsley983111f2019-09-26 17:18:48 +0000461 min_ps = max(1, ps - 5)
462 while ps >= min_ps:
Quinten Yearsley777660f2020-03-04 23:37:06 +0000463 builds = _fetch_tryjobs(changelist, buildbucket_host, patchset=ps)
Quinten Yearsley983111f2019-09-26 17:18:48 +0000464 if len(builds):
465 return builds, ps
466 ps -= 1
467 return [], 0
468
469
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +0000470def _filter_failed_for_retry(all_builds):
471 """Returns a list of buckets/builders that are worth retrying.
Quinten Yearsley983111f2019-09-26 17:18:48 +0000472
473 Args:
Quinten Yearsley777660f2020-03-04 23:37:06 +0000474 all_builds (list): Builds, in the format returned by _fetch_tryjobs,
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000475 i.e. a list of buildbucket.v2.Builds which includes status and builder
476 info.
Quinten Yearsley983111f2019-09-26 17:18:48 +0000477
478 Returns:
Edward Lemur45768512020-03-02 19:03:14 +0000479 A dict {(proj, bucket): [builders]}. This is the same format accepted by
Quinten Yearsley777660f2020-03-04 23:37:06 +0000480 _trigger_tryjobs.
Quinten Yearsley983111f2019-09-26 17:18:48 +0000481 """
Edward Lemur45768512020-03-02 19:03:14 +0000482 grouped = {}
483 for build in all_builds:
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +0000484 builder = build['builder']
Edward Lemur45768512020-03-02 19:03:14 +0000485 key = (builder['project'], builder['bucket'], builder['builder'])
486 grouped.setdefault(key, []).append(build)
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +0000487
Edward Lemur45768512020-03-02 19:03:14 +0000488 jobs = []
489 for (project, bucket, builder), builds in grouped.items():
490 if 'triggered' in builder:
491 print('WARNING: Not scheduling %s. Triggered bots require an initial job '
492 'from a parent. Please schedule a manual job for the parent '
493 'instead.')
Andrii Shyshkalov2cbae8a2019-10-11 21:30:27 +0000494 continue
495 if any(b['status'] in ('STARTED', 'SCHEDULED') for b in builds):
496 # Don't retry if any are running.
497 continue
Edward Lemur45768512020-03-02 19:03:14 +0000498 # If builder had several builds, retry only if the last one failed.
499 # This is a bit different from CQ, which would re-use *any* SUCCESS-full
500 # build, but in case of retrying failed jobs retrying a flaky one makes
501 # sense.
502 builds = sorted(builds, key=lambda b: b['createTime'])
503 if builds[-1]['status'] not in ('FAILURE', 'INFRA_FAILURE'):
504 continue
505 # Don't retry experimental build previously triggered by CQ.
506 if any(t['key'] == 'cq_experimental' and t['value'] == 'true'
507 for t in builds[-1]['tags']):
508 continue
509 jobs.append((project, bucket, builder))
510
511 # Sort the jobs to make testing easier.
512 return sorted(jobs)
Quinten Yearsley983111f2019-09-26 17:18:48 +0000513
514
Quinten Yearsley777660f2020-03-04 23:37:06 +0000515def _print_tryjobs(options, builds):
516 """Prints nicely result of _fetch_tryjobs."""
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000517 if not builds:
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000518 print('No tryjobs scheduled.')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000519 return
520
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000521 longest_builder = max(len(b['builder']['builder']) for b in builds)
522 name_fmt = '{builder:<%d}' % longest_builder
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000523 if options.print_master:
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000524 longest_bucket = max(len(b['builder']['bucket']) for b in builds)
525 name_fmt = ('{bucket:>%d} ' % longest_bucket) + name_fmt
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000526
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000527 builds_by_status = {}
528 for b in builds:
529 builds_by_status.setdefault(b['status'], []).append({
530 'id': b['id'],
531 'name': name_fmt.format(
532 builder=b['builder']['builder'], bucket=b['builder']['bucket']),
533 })
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000534
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000535 sort_key = lambda b: (b['name'], b['id'])
536
537 def print_builds(title, builds, fmt=None, color=None):
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000538 """Pop matching builds from `builds` dict and print them."""
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000539 if not builds:
540 return
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000541
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000542 fmt = fmt or '{name} https://ci.chromium.org/b/{id}'
tandrii@chromium.org6cf98c82016-03-15 11:56:00 +0000543 if not options.color or color is None:
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000544 colorize = lambda x: x
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000545 else:
546 colorize = lambda x: '%s%s%s' % (color, x, Fore.RESET)
547
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000548 print(colorize(title))
549 for b in sorted(builds, key=sort_key):
550 print(' ', colorize(fmt.format(**b)))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000551
552 total = len(builds)
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000553 print_builds(
554 'Successes:', builds_by_status.pop('SUCCESS', []), color=Fore.GREEN)
555 print_builds(
556 'Infra Failures:', builds_by_status.pop('INFRA_FAILURE', []),
557 color=Fore.MAGENTA)
558 print_builds('Failures:', builds_by_status.pop('FAILURE', []), color=Fore.RED)
559 print_builds('Canceled:', builds_by_status.pop('CANCELED', []), fmt='{name}',
560 color=Fore.MAGENTA)
Andrii Shyshkalov792630c2020-10-19 16:47:44 +0000561 print_builds('Started:', builds_by_status.pop('STARTED', []),
562 color=Fore.YELLOW)
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000563 print_builds(
564 'Scheduled:', builds_by_status.pop('SCHEDULED', []), fmt='{name} id={id}')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000565 # The last section is just in case buildbucket API changes OR there is a bug.
Edward Lemurbaaf6be2019-10-09 18:00:44 +0000566 print_builds(
567 'Other:', sum(builds_by_status.values(), []), fmt='{name} id={id}')
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000568 print('Total: %d tryjobs' % total)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +0000569
570
Aiden Bennerc08566e2018-10-03 17:52:42 +0000571def _ComputeDiffLineRanges(files, upstream_commit):
572 """Gets the changed line ranges for each file since upstream_commit.
573
574 Parses a git diff on provided files and returns a dict that maps a file name
575 to an ordered list of range tuples in the form (start_line, count).
576 Ranges are in the same format as a git diff.
577 """
578 # If files is empty then diff_output will be a full diff.
579 if len(files) == 0:
580 return {}
581
Aiden Benner6c18a1a2018-11-23 20:18:23 +0000582 # Take the git diff and find the line ranges where there are changes.
Jamie Madill3671a6a2019-10-24 15:13:21 +0000583 diff_cmd = BuildGitDiffCmd('-U0', upstream_commit, files, allow_prefix=True)
Aiden Bennerc08566e2018-10-03 17:52:42 +0000584 diff_output = RunGit(diff_cmd)
585
586 pattern = r'(?:^diff --git a/(?:.*) b/(.*))|(?:^@@.*\+(.*) @@)'
587 # 2 capture groups
588 # 0 == fname of diff file
589 # 1 == 'diff_start,diff_count' or 'diff_start'
590 # will match each of
591 # diff --git a/foo.foo b/foo.py
592 # @@ -12,2 +14,3 @@
593 # @@ -12,2 +17 @@
594 # running re.findall on the above string with pattern will give
595 # [('foo.py', ''), ('', '14,3'), ('', '17')]
596
597 curr_file = None
598 line_diffs = {}
599 for match in re.findall(pattern, diff_output, flags=re.MULTILINE):
600 if match[0] != '':
601 # Will match the second filename in diff --git a/a.py b/b.py.
602 curr_file = match[0]
603 line_diffs[curr_file] = []
604 else:
605 # Matches +14,3
606 if ',' in match[1]:
607 diff_start, diff_count = match[1].split(',')
608 else:
609 # Single line changes are of the form +12 instead of +12,1.
610 diff_start = match[1]
611 diff_count = 1
612
613 diff_start = int(diff_start)
614 diff_count = int(diff_count)
615
616 # If diff_count == 0 this is a removal we can ignore.
617 line_diffs[curr_file].append((diff_start, diff_count))
618
619 return line_diffs
620
621
Aiden Benner99b0ccb2018-11-20 19:53:31 +0000622def _FindYapfConfigFile(fpath, yapf_config_cache, top_dir=None):
Aiden Bennerc08566e2018-10-03 17:52:42 +0000623 """Checks if a yapf file is in any parent directory of fpath until top_dir.
624
Aiden Benner99b0ccb2018-11-20 19:53:31 +0000625 Recursively checks parent directories to find yapf file and if no yapf file
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000626 is found returns None. Uses yapf_config_cache as a cache for previously found
627 configs.
Aiden Bennerc08566e2018-10-03 17:52:42 +0000628 """
Aiden Benner99b0ccb2018-11-20 19:53:31 +0000629 fpath = os.path.abspath(fpath)
Aiden Bennerc08566e2018-10-03 17:52:42 +0000630 # Return result if we've already computed it.
631 if fpath in yapf_config_cache:
632 return yapf_config_cache[fpath]
633
Aiden Benner99b0ccb2018-11-20 19:53:31 +0000634 parent_dir = os.path.dirname(fpath)
635 if os.path.isfile(fpath):
636 ret = _FindYapfConfigFile(parent_dir, yapf_config_cache, top_dir)
Aiden Bennerc08566e2018-10-03 17:52:42 +0000637 else:
Aiden Benner99b0ccb2018-11-20 19:53:31 +0000638 # Otherwise fpath is a directory
639 yapf_file = os.path.join(fpath, YAPF_CONFIG_FILENAME)
640 if os.path.isfile(yapf_file):
641 ret = yapf_file
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +0000642 elif fpath in (top_dir, parent_dir):
Aiden Benner99b0ccb2018-11-20 19:53:31 +0000643 # If we're at the top level directory, or if we're at root
644 # there is no provided style.
645 ret = None
646 else:
647 # Otherwise recurse on the current directory.
648 ret = _FindYapfConfigFile(parent_dir, yapf_config_cache, top_dir)
Aiden Bennerc08566e2018-10-03 17:52:42 +0000649 yapf_config_cache[fpath] = ret
650 return ret
651
652
Brian Sheedyb4307d52019-12-02 19:18:17 +0000653def _GetYapfIgnorePatterns(top_dir):
654 """Returns all patterns in the .yapfignore file.
Brian Sheedy59b06a82019-10-14 17:03:29 +0000655
656 yapf is supposed to handle the ignoring of files listed in .yapfignore itself,
657 but this functionality appears to break when explicitly passing files to
658 yapf for formatting. According to
Josip Sokcevicc39ab992020-09-24 20:09:15 +0000659 https://github.com/google/yapf/blob/HEAD/README.rst#excluding-files-from-formatting-yapfignore,
Brian Sheedy59b06a82019-10-14 17:03:29 +0000660 the .yapfignore file should be in the directory that yapf is invoked from,
661 which we assume to be the top level directory in this case.
662
663 Args:
664 top_dir: The top level directory for the repository being formatted.
665
666 Returns:
Brian Sheedyb4307d52019-12-02 19:18:17 +0000667 A set of all fnmatch patterns to be ignored.
Brian Sheedy59b06a82019-10-14 17:03:29 +0000668 """
669 yapfignore_file = os.path.join(top_dir, '.yapfignore')
Brian Sheedyb4307d52019-12-02 19:18:17 +0000670 ignore_patterns = set()
Brian Sheedy59b06a82019-10-14 17:03:29 +0000671 if not os.path.exists(yapfignore_file):
Brian Sheedyb4307d52019-12-02 19:18:17 +0000672 return ignore_patterns
Brian Sheedy59b06a82019-10-14 17:03:29 +0000673
Anthony Politoc64e3902021-04-30 21:55:25 +0000674 for line in gclient_utils.FileRead(yapfignore_file).split('\n'):
675 stripped_line = line.strip()
676 # Comments and blank lines should be ignored.
677 if stripped_line.startswith('#') or stripped_line == '':
678 continue
679 ignore_patterns.add(stripped_line)
Brian Sheedyb4307d52019-12-02 19:18:17 +0000680 return ignore_patterns
681
682
683def _FilterYapfIgnoredFiles(filepaths, patterns):
684 """Filters out any filepaths that match any of the given patterns.
685
686 Args:
687 filepaths: An iterable of strings containing filepaths to filter.
688 patterns: An iterable of strings containing fnmatch patterns to filter on.
689
690 Returns:
691 A list of strings containing all the elements of |filepaths| that did not
692 match any of the patterns in |patterns|.
693 """
694 # Not inlined so that tests can use the same implementation.
695 return [f for f in filepaths
696 if not any(fnmatch.fnmatch(f, p) for p in patterns)]
Brian Sheedy59b06a82019-10-14 17:03:29 +0000697
698
Aaron Gable13101a62018-02-09 13:20:41 -0800699def print_stats(args):
maruel@chromium.org49e3d802012-07-18 23:54:45 +0000700 """Prints statistics about the change to the user."""
701 # --no-ext-diff is broken in some versions of Git, so try to work around
702 # this by overriding the environment (but there is still a problem if the
703 # git config key "diff.external" is used).
thestig@chromium.org8b0553c2014-02-11 00:33:37 +0000704 env = GetNoGitPagerEnv()
maruel@chromium.org49e3d802012-07-18 23:54:45 +0000705 if 'GIT_EXTERNAL_DIFF' in env:
706 del env['GIT_EXTERNAL_DIFF']
iannucci@chromium.org79540052012-10-19 23:15:26 +0000707
maruel@chromium.org49e3d802012-07-18 23:54:45 +0000708 return subprocess2.call(
Aaron Gable13101a62018-02-09 13:20:41 -0800709 ['git', 'diff', '--no-ext-diff', '--stat', '-l100000', '-C50'] + args,
Edward Lemur0db01f02019-11-12 22:01:51 +0000710 env=env)
maruel@chromium.org49e3d802012-07-18 23:54:45 +0000711
712
sheyang@google.com6ebaf782015-05-12 19:17:54 +0000713class BuildbucketResponseException(Exception):
714 pass
715
716
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000717class Settings(object):
718 def __init__(self):
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000719 self.cc = None
thestig@chromium.org7a54e812014-02-11 19:57:22 +0000720 self.root = None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000721 self.tree_status_url = None
722 self.viewvc_url = None
723 self.updated = False
ukai@chromium.orge8077812012-02-03 03:41:46 +0000724 self.is_gerrit = None
bauerb@chromium.org54b400c2016-01-14 10:08:25 +0000725 self.squash_gerrit_uploads = None
tandrii@chromium.org28253532016-04-14 13:46:56 +0000726 self.gerrit_skip_ensure_authenticated = None
jbroman@chromium.org615a2622013-05-03 13:20:14 +0000727 self.git_editor = None
Jamie Madilldc4d19e2019-10-24 21:50:02 +0000728 self.format_full_by_default = None
Sigurd Schneider1bfda8e2021-06-30 14:46:25 +0000729 self.is_status_commit_order_by_date = None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000730
Edward Lemur26964072020-02-19 19:18:51 +0000731 def _LazyUpdateIfNeeded(self):
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000732 """Updates the settings from a codereview.settings file, if available."""
Edward Lemur26964072020-02-19 19:18:51 +0000733 if self.updated:
734 return
pgervais@chromium.org87884cc2014-01-03 22:23:41 +0000735
Edward Lemur26964072020-02-19 19:18:51 +0000736 # The only value that actually changes the behavior is
737 # autoupdate = "false". Everything else means "true".
738 autoupdate = (
739 scm.GIT.GetConfig(self.GetRoot(), 'rietveld.autoupdate', '').lower())
740
741 cr_settings_file = FindCodereviewSettingsFile()
742 if autoupdate != 'false' and cr_settings_file:
743 LoadCodereviewSettingsFromFile(cr_settings_file)
744 cr_settings_file.close()
745
746 self.updated = True
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000747
thestig@chromium.org7a54e812014-02-11 19:57:22 +0000748 @staticmethod
749 def GetRelativeRoot():
Edward Lesmes50da7702020-03-30 19:23:43 +0000750 return scm.GIT.GetCheckoutRoot('.')
thestig@chromium.org8b0553c2014-02-11 00:33:37 +0000751
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000752 def GetRoot(self):
thestig@chromium.org7a54e812014-02-11 19:57:22 +0000753 if self.root is None:
754 self.root = os.path.abspath(self.GetRelativeRoot())
755 return self.root
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000756
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000757 def GetTreeStatusUrl(self, error_ok=False):
758 if not self.tree_status_url:
Edward Lemur26964072020-02-19 19:18:51 +0000759 self.tree_status_url = self._GetConfig('rietveld.tree-status-url')
760 if self.tree_status_url is None and not error_ok:
761 DieWithError(
762 'You must configure your tree status URL by running '
763 '"git cl config".')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000764 return self.tree_status_url
765
766 def GetViewVCUrl(self):
767 if not self.viewvc_url:
Edward Lemur26964072020-02-19 19:18:51 +0000768 self.viewvc_url = self._GetConfig('rietveld.viewvc-url')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000769 return self.viewvc_url
770
rmistry@google.com90752582014-01-14 21:04:50 +0000771 def GetBugPrefix(self):
Edward Lemur26964072020-02-19 19:18:51 +0000772 return self._GetConfig('rietveld.bug-prefix')
rmistry@google.com78948ed2015-07-08 23:09:57 +0000773
rmistry@google.com5626a922015-02-26 14:03:30 +0000774 def GetRunPostUploadHook(self):
Edward Lemur61ea3072018-12-01 00:34:36 +0000775 run_post_upload_hook = self._GetConfig(
Edward Lemur26964072020-02-19 19:18:51 +0000776 'rietveld.run-post-upload-hook')
rmistry@google.com5626a922015-02-26 14:03:30 +0000777 return run_post_upload_hook == "True"
778
bauerb@chromium.orgae6df352011-04-06 17:40:39 +0000779 def GetDefaultCCList(self):
Edward Lemur26964072020-02-19 19:18:51 +0000780 return self._GetConfig('rietveld.cc')
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000781
Dirk Pranke6f0df682021-06-25 00:42:33 +0000782 def GetUsePython3(self):
783 return self._GetConfig('rietveld.use-python3')
784
bauerb@chromium.org54b400c2016-01-14 10:08:25 +0000785 def GetSquashGerritUploads(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000786 """Returns True if uploads to Gerrit should be squashed by default."""
bauerb@chromium.org54b400c2016-01-14 10:08:25 +0000787 if self.squash_gerrit_uploads is None:
Edward Lesmes4de54132020-05-05 19:41:33 +0000788 self.squash_gerrit_uploads = self.GetSquashGerritUploadsOverride()
789 if self.squash_gerrit_uploads is None:
Edward Lemur26964072020-02-19 19:18:51 +0000790 # Default is squash now (http://crbug.com/611892#c23).
791 self.squash_gerrit_uploads = self._GetConfig(
792 'gerrit.squash-uploads').lower() != 'false'
bauerb@chromium.org54b400c2016-01-14 10:08:25 +0000793 return self.squash_gerrit_uploads
794
Edward Lesmes4de54132020-05-05 19:41:33 +0000795 def GetSquashGerritUploadsOverride(self):
796 """Return True or False if codereview.settings should be overridden.
797
798 Returns None if no override has been defined.
799 """
800 # See also http://crbug.com/611892#c23
801 result = self._GetConfig('gerrit.override-squash-uploads').lower()
802 if result == 'true':
803 return True
804 if result == 'false':
805 return False
806 return None
807
tandrii@chromium.org28253532016-04-14 13:46:56 +0000808 def GetGerritSkipEnsureAuthenticated(self):
809 """Return True if EnsureAuthenticated should not be done for Gerrit
810 uploads."""
811 if self.gerrit_skip_ensure_authenticated is None:
Edward Lemur26964072020-02-19 19:18:51 +0000812 self.gerrit_skip_ensure_authenticated = self._GetConfig(
813 'gerrit.skip-ensure-authenticated').lower() == 'true'
tandrii@chromium.org28253532016-04-14 13:46:56 +0000814 return self.gerrit_skip_ensure_authenticated
815
jbroman@chromium.org615a2622013-05-03 13:20:14 +0000816 def GetGitEditor(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +0000817 """Returns the editor specified in the git config, or None if none is."""
jbroman@chromium.org615a2622013-05-03 13:20:14 +0000818 if self.git_editor is None:
Raul Tambre5a525872019-02-12 19:08:08 +0000819 # Git requires single quotes for paths with spaces. We need to replace
820 # them with double quotes for Windows to treat such paths as a single
821 # path.
Edward Lemur26964072020-02-19 19:18:51 +0000822 self.git_editor = self._GetConfig('core.editor').replace('\'', '"')
jbroman@chromium.org615a2622013-05-03 13:20:14 +0000823 return self.git_editor or None
824
thestig@chromium.org44202a22014-03-11 19:22:18 +0000825 def GetLintRegex(self):
Edward Lemur26964072020-02-19 19:18:51 +0000826 return self._GetConfig('rietveld.cpplint-regex', DEFAULT_LINT_REGEX)
thestig@chromium.org44202a22014-03-11 19:22:18 +0000827
828 def GetLintIgnoreRegex(self):
Edward Lemur26964072020-02-19 19:18:51 +0000829 return self._GetConfig(
830 'rietveld.cpplint-ignore-regex', DEFAULT_LINT_IGNORE_REGEX)
thestig@chromium.org44202a22014-03-11 19:22:18 +0000831
Jamie Madilldc4d19e2019-10-24 21:50:02 +0000832 def GetFormatFullByDefault(self):
833 if self.format_full_by_default is None:
Jamie Madillac6f6232021-07-07 20:54:08 +0000834 self._LazyUpdateIfNeeded()
Jamie Madilldc4d19e2019-10-24 21:50:02 +0000835 result = (
836 RunGit(['config', '--bool', 'rietveld.format-full-by-default'],
837 error_ok=True).strip())
838 self.format_full_by_default = (result == 'true')
839 return self.format_full_by_default
840
Sigurd Schneider1bfda8e2021-06-30 14:46:25 +0000841 def IsStatusCommitOrderByDate(self):
842 if self.is_status_commit_order_by_date is None:
843 result = (RunGit(['config', '--bool', 'cl.date-order'],
844 error_ok=True).strip())
845 self.is_status_commit_order_by_date = (result == 'true')
846 return self.is_status_commit_order_by_date
847
Edward Lemur26964072020-02-19 19:18:51 +0000848 def _GetConfig(self, key, default=''):
849 self._LazyUpdateIfNeeded()
850 return scm.GIT.GetConfig(self.GetRoot(), key, default)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000851
852
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +0000853class _CQState(object):
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +0000854 """Enum for states of CL with respect to CQ."""
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +0000855 NONE = 'none'
Greg Gutermanbe5fccd2021-06-14 17:58:20 +0000856 QUICK_RUN = 'quick_run'
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +0000857 DRY_RUN = 'dry_run'
858 COMMIT = 'commit'
859
Greg Gutermanbe5fccd2021-06-14 17:58:20 +0000860 ALL_STATES = [NONE, QUICK_RUN, DRY_RUN, COMMIT]
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +0000861
862
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000863class _ParsedIssueNumberArgument(object):
Edward Lemurf38bc172019-09-03 21:02:13 +0000864 def __init__(self, issue=None, patchset=None, hostname=None):
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000865 self.issue = issue
866 self.patchset = patchset
867 self.hostname = hostname
868
869 @property
870 def valid(self):
871 return self.issue is not None
872
873
Edward Lemurf38bc172019-09-03 21:02:13 +0000874def ParseIssueNumberArgument(arg):
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000875 """Parses the issue argument and returns _ParsedIssueNumberArgument."""
876 fail_result = _ParsedIssueNumberArgument()
877
Edward Lemur678a6842019-10-03 22:25:05 +0000878 if isinstance(arg, int):
879 return _ParsedIssueNumberArgument(issue=arg)
880 if not isinstance(arg, basestring):
881 return fail_result
882
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000883 if arg.isdigit():
Edward Lemurf38bc172019-09-03 21:02:13 +0000884 return _ParsedIssueNumberArgument(issue=int(arg))
Aaron Gableaee6c852017-06-26 12:49:01 -0700885
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000886 url = gclient_utils.UpgradeToHttps(arg)
Alex Turner30ae6372022-01-04 02:32:52 +0000887 if not url.startswith('http'):
888 return fail_result
Andrii Shyshkalov8aebb602020-04-16 22:10:27 +0000889 for gerrit_url, short_url in _KNOWN_GERRIT_TO_SHORT_URLS.items():
890 if url.startswith(short_url):
891 url = gerrit_url + url[len(short_url):]
892 break
893
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000894 try:
Edward Lemur79d4f992019-11-11 23:49:02 +0000895 parsed_url = urllib.parse.urlparse(url)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000896 except ValueError:
897 return fail_result
Andrii Shyshkalov28d840e2017-04-10 15:45:09 +0200898
Alex Turner30ae6372022-01-04 02:32:52 +0000899 # If "https://" was automatically added, fail if `arg` looks unlikely to be a
900 # URL.
901 if not arg.startswith('http') and '.' not in parsed_url.netloc:
902 return fail_result
903
Edward Lemur678a6842019-10-03 22:25:05 +0000904 # Gerrit's new UI is https://domain/c/project/+/<issue_number>[/[patchset]]
905 # But old GWT UI is https://domain/#/c/project/+/<issue_number>[/[patchset]]
906 # Short urls like https://domain/<issue_number> can be used, but don't allow
907 # specifying the patchset (you'd 404), but we allow that here.
908 if parsed_url.path == '/':
909 part = parsed_url.fragment
910 else:
911 part = parsed_url.path
912
913 match = re.match(
914 r'(/c(/.*/\+)?)?/(?P<issue>\d+)(/(?P<patchset>\d+)?/?)?$', part)
915 if not match:
916 return fail_result
917
918 issue = int(match.group('issue'))
919 patchset = match.group('patchset')
920 return _ParsedIssueNumberArgument(
921 issue=issue,
922 patchset=int(patchset) if patchset else None,
923 hostname=parsed_url.netloc)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000924
925
Andrii Shyshkalovb07575f2018-10-16 06:16:21 +0000926def _create_description_from_log(args):
927 """Pulls out the commit log to use as a base for the CL description."""
928 log_args = []
929 if len(args) == 1 and not args[0].endswith('.'):
930 log_args = [args[0] + '..']
931 elif len(args) == 1 and args[0].endswith('...'):
932 log_args = [args[0][:-1]]
933 elif len(args) == 2:
934 log_args = [args[0] + '..' + args[1]]
935 else:
936 log_args = args[:] # Hope for the best!
Manh Nguyene3644862020-08-05 18:25:46 +0000937 return RunGit(['log', '--pretty=format:%B%n'] + log_args)
Andrii Shyshkalovb07575f2018-10-16 06:16:21 +0000938
939
Aaron Gablea45ee112016-11-22 15:14:38 -0800940class GerritChangeNotExists(Exception):
tandriic2405f52016-10-10 08:13:15 -0700941 def __init__(self, issue, url):
942 self.issue = issue
943 self.url = url
Aaron Gablea45ee112016-11-22 15:14:38 -0800944 super(GerritChangeNotExists, self).__init__()
tandriic2405f52016-10-10 08:13:15 -0700945
946 def __str__(self):
Aaron Gablea45ee112016-11-22 15:14:38 -0800947 return 'change %s at %s does not exist or you have no access to it' % (
tandriic2405f52016-10-10 08:13:15 -0700948 self.issue, self.url)
949
950
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +0100951_CommentSummary = collections.namedtuple(
Quinten Yearsley0e617c02019-02-20 00:37:03 +0000952 '_CommentSummary', ['date', 'message', 'sender', 'autogenerated',
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +0100953 # TODO(tandrii): these two aren't known in Gerrit.
954 'approval', 'disapproval'])
955
956
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000957class Changelist(object):
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +0000958 """Changelist works with one changelist in local branch.
959
tandrii@chromium.org8930b3d2016-04-13 14:47:02 +0000960 Notes:
961 * Not safe for concurrent multi-{thread,process} use.
962 * Caches values from current branch. Therefore, re-use after branch change
tandrii5d48c322016-08-18 16:19:37 -0700963 with great care.
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +0000964 """
965
Sigurd Schneider9abde8c2020-11-17 08:44:52 +0000966 def __init__(self,
967 branchref=None,
968 issue=None,
969 codereview_host=None,
970 commit_date=None):
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +0000971 """Create a new ChangeList instance.
972
Edward Lemurf38bc172019-09-03 21:02:13 +0000973 **kwargs will be passed directly to Gerrit implementation.
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +0000974 """
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000975 # Poke settings so we get the "configure your server" message if necessary.
maruel@chromium.org379d07a2011-11-30 14:58:10 +0000976 global settings
977 if not settings:
978 # Happens when git_cl.py is used as a utility library.
979 settings = Settings()
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +0000980
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000981 self.branchref = branchref
982 if self.branchref:
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +0000983 assert branchref.startswith('refs/heads/')
Edward Lemur85153282020-02-14 22:06:29 +0000984 self.branch = scm.GIT.ShortBranchName(self.branchref)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000985 else:
986 self.branch = None
Sigurd Schneider9abde8c2020-11-17 08:44:52 +0000987 self.commit_date = commit_date
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000988 self.upstream_branch = None
maruel@chromium.org1033efd2013-07-23 23:25:09 +0000989 self.lookedup_issue = False
990 self.issue = issue or None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000991 self.description = None
maruel@chromium.org1033efd2013-07-23 23:25:09 +0000992 self.lookedup_patchset = False
chase@chromium.orgcc51cd02010-12-23 00:48:39 +0000993 self.patchset = None
bauerb@chromium.orgae6df352011-04-06 17:40:39 +0000994 self.cc = None
Daniel Cheng7227d212017-11-17 08:12:37 -0800995 self.more_cc = []
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +0000996 self._remote = None
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +0000997 self._cached_remote_url = (False, None) # (is_cached, value)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +0000998
Edward Lemur125d60a2019-09-13 18:25:41 +0000999 # Lazily cached values.
1000 self._gerrit_host = None # e.g. chromium-review.googlesource.com
1001 self._gerrit_server = None # e.g. https://chromium-review.googlesource.com
Edward Lesmese1576912021-02-16 21:53:34 +00001002 self._owners_client = None
Edward Lemur125d60a2019-09-13 18:25:41 +00001003 # Map from change number (issue) to its detail cache.
1004 self._detail_cache = {}
1005
1006 if codereview_host is not None:
1007 assert not codereview_host.startswith('https://'), codereview_host
1008 self._gerrit_host = codereview_host
1009 self._gerrit_server = 'https://%s' % codereview_host
bauerb@chromium.orgae6df352011-04-06 17:40:39 +00001010
Edward Lesmese1576912021-02-16 21:53:34 +00001011 @property
1012 def owners_client(self):
1013 if self._owners_client is None:
1014 remote, remote_branch = self.GetRemoteBranch()
1015 branch = GetTargetRef(remote, remote_branch, None)
1016 self._owners_client = owners_client.GetCodeOwnersClient(
1017 root=settings.GetRoot(),
Edward Lesmes1eaaab52021-03-02 23:52:54 +00001018 upstream=self.GetCommonAncestorWithUpstream(),
Edward Lesmese1576912021-02-16 21:53:34 +00001019 host=self.GetGerritHost(),
1020 project=self.GetGerritProject(),
1021 branch=branch)
1022 return self._owners_client
1023
bauerb@chromium.orgae6df352011-04-06 17:40:39 +00001024 def GetCCList(self):
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001025 """Returns the users cc'd on this CL.
bauerb@chromium.orgae6df352011-04-06 17:40:39 +00001026
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001027 The return value is a string suitable for passing to git cl with the --cc
1028 flag.
bauerb@chromium.orgae6df352011-04-06 17:40:39 +00001029 """
1030 if self.cc is None:
tyoshino@chromium.org99918ab2013-09-30 06:17:28 +00001031 base_cc = settings.GetDefaultCCList()
Daniel Cheng7227d212017-11-17 08:12:37 -08001032 more_cc = ','.join(self.more_cc)
bauerb@chromium.orgae6df352011-04-06 17:40:39 +00001033 self.cc = ','.join(filter(None, (base_cc, more_cc))) or ''
1034 return self.cc
1035
Daniel Cheng7227d212017-11-17 08:12:37 -08001036 def ExtendCC(self, more_cc):
1037 """Extends the list of users to cc on this CL based on the changed files."""
1038 self.more_cc.extend(more_cc)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001039
Sigurd Schneider9abde8c2020-11-17 08:44:52 +00001040 def GetCommitDate(self):
1041 """Returns the commit date as provided in the constructor"""
1042 return self.commit_date
1043
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001044 def GetBranch(self):
Josip Sokcevicc39ab992020-09-24 20:09:15 +00001045 """Returns the short branch name, e.g. 'main'."""
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001046 if not self.branch:
Edward Lemur85153282020-02-14 22:06:29 +00001047 branchref = scm.GIT.GetBranchRef(settings.GetRoot())
szager@chromium.orgd62c61f2014-10-20 22:33:21 +00001048 if not branchref:
1049 return None
1050 self.branchref = branchref
Edward Lemur85153282020-02-14 22:06:29 +00001051 self.branch = scm.GIT.ShortBranchName(self.branchref)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001052 return self.branch
1053
1054 def GetBranchRef(self):
Josip Sokcevicc39ab992020-09-24 20:09:15 +00001055 """Returns the full branch name, e.g. 'refs/heads/main'."""
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001056 self.GetBranch() # Poke the lazy loader.
1057 return self.branchref
1058
Edward Lemur85153282020-02-14 22:06:29 +00001059 def _GitGetBranchConfigValue(self, key, default=None):
1060 return scm.GIT.GetBranchConfig(
1061 settings.GetRoot(), self.GetBranch(), key, default)
tandrii5d48c322016-08-18 16:19:37 -07001062
Edward Lemur85153282020-02-14 22:06:29 +00001063 def _GitSetBranchConfigValue(self, key, value):
1064 action = 'set %s to %r' % (key, value)
1065 if not value:
1066 action = 'unset %s' % key
1067 assert self.GetBranch(), 'a branch is needed to ' + action
1068 return scm.GIT.SetBranchConfig(
1069 settings.GetRoot(), self.GetBranch(), key, value)
tandrii5d48c322016-08-18 16:19:37 -07001070
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001071 @staticmethod
1072 def FetchUpstreamTuple(branch):
pgervais@chromium.orgd6617f32013-11-19 00:34:54 +00001073 """Returns a tuple containing remote and remote ref,
Josip Sokcevicc39ab992020-09-24 20:09:15 +00001074 e.g. 'origin', 'refs/heads/main'
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001075 """
Edward Lemur15a9b8c2020-02-13 00:52:30 +00001076 remote, upstream_branch = scm.GIT.FetchUpstreamTuple(
1077 settings.GetRoot(), branch)
1078 if not remote or not upstream_branch:
1079 DieWithError(
1080 'Unable to determine default branch to diff against.\n'
Josip Sokcevicb038f722021-01-06 18:28:11 +00001081 'Verify this branch is set up to track another \n'
1082 '(via the --track argument to "git checkout -b ..."). \n'
1083 'or pass complete "git diff"-style arguments if supported, like\n'
1084 ' git cl upload origin/main\n')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001085
1086 return remote, upstream_branch
1087
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00001088 def GetCommonAncestorWithUpstream(self):
pgervais@chromium.org8ba38ff2015-06-11 21:41:25 +00001089 upstream_branch = self.GetUpstreamBranch()
Edward Lesmes50da7702020-03-30 19:23:43 +00001090 if not scm.GIT.IsValidRevision(settings.GetRoot(), upstream_branch):
pgervais@chromium.org8ba38ff2015-06-11 21:41:25 +00001091 DieWithError('The upstream for the current branch (%s) does not exist '
1092 'anymore.\nPlease fix it and try again.' % self.GetBranch())
iannucci@chromium.org9e849272014-04-04 00:31:55 +00001093 return git_common.get_or_create_merge_base(self.GetBranch(),
pgervais@chromium.org8ba38ff2015-06-11 21:41:25 +00001094 upstream_branch)
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00001095
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001096 def GetUpstreamBranch(self):
1097 if self.upstream_branch is None:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001098 remote, upstream_branch = self.FetchUpstreamTuple(self.GetBranch())
Raul Tambrefe1dbe12019-05-02 04:43:57 +00001099 if remote != '.':
mmoss@chromium.orge7585452014-08-24 01:41:11 +00001100 upstream_branch = upstream_branch.replace('refs/heads/',
1101 'refs/remotes/%s/' % remote)
1102 upstream_branch = upstream_branch.replace('refs/branch-heads/',
1103 'refs/remotes/branch-heads/')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001104 self.upstream_branch = upstream_branch
1105 return self.upstream_branch
1106
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001107 def GetRemoteBranch(self):
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001108 if not self._remote:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001109 remote, branch = None, self.GetBranch()
1110 seen_branches = set()
1111 while branch not in seen_branches:
1112 seen_branches.add(branch)
1113 remote, branch = self.FetchUpstreamTuple(branch)
Edward Lemur85153282020-02-14 22:06:29 +00001114 branch = scm.GIT.ShortBranchName(branch)
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001115 if remote != '.' or branch.startswith('refs/remotes'):
1116 break
1117 else:
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001118 remotes = RunGit(['remote'], error_ok=True).split()
1119 if len(remotes) == 1:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001120 remote, = remotes
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001121 elif 'origin' in remotes:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001122 remote = 'origin'
Gavin Make6a62332020-12-04 21:57:10 +00001123 logging.warning('Could not determine which remote this change is '
1124 'associated with, so defaulting to "%s".' %
1125 self._remote)
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001126 else:
Gavin Make6a62332020-12-04 21:57:10 +00001127 logging.warning('Could not determine which remote this change is '
1128 'associated with.')
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001129 branch = 'HEAD'
1130 if branch.startswith('refs/remotes'):
1131 self._remote = (remote, branch)
mmoss@chromium.orge7585452014-08-24 01:41:11 +00001132 elif branch.startswith('refs/branch-heads/'):
1133 self._remote = (remote, branch.replace('refs/', 'refs/remotes/'))
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001134 else:
1135 self._remote = (remote, 'refs/remotes/%s/%s' % (remote, branch))
jmbaker@chromium.orga2cbbbb2012-03-22 20:40:40 +00001136 return self._remote
1137
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001138 def GetRemoteUrl(self):
1139 """Return the configured remote URL, e.g. 'git://example.org/foo.git/'.
1140
1141 Returns None if there is no remote.
1142 """
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00001143 is_cached, value = self._cached_remote_url
1144 if is_cached:
1145 return value
1146
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00001147 remote, _ = self.GetRemoteBranch()
Edward Lemur26964072020-02-19 19:18:51 +00001148 url = scm.GIT.GetConfig(settings.GetRoot(), 'remote.%s.url' % remote, '')
dyen@chromium.org2a13d4f2014-06-13 00:06:37 +00001149
Edward Lemur298f2cf2019-02-22 21:40:39 +00001150 # Check if the remote url can be parsed as an URL.
Edward Lemur79d4f992019-11-11 23:49:02 +00001151 host = urllib.parse.urlparse(url).netloc
Edward Lemur298f2cf2019-02-22 21:40:39 +00001152 if host:
1153 self._cached_remote_url = (True, url)
1154 return url
1155
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001156 # If it cannot be parsed as an url, assume it is a local directory,
1157 # probably a git cache.
Edward Lemur298f2cf2019-02-22 21:40:39 +00001158 logging.warning('"%s" doesn\'t appear to point to a git host. '
1159 'Interpreting it as a local directory.', url)
1160 if not os.path.isdir(url):
1161 logging.error(
Josip906bfde2020-01-31 22:38:49 +00001162 'Remote "%(remote)s" for branch "%(branch)s" points to "%(url)s", '
1163 'but it doesn\'t exist.',
1164 {'remote': remote, 'branch': self.GetBranch(), 'url': url})
Edward Lemur298f2cf2019-02-22 21:40:39 +00001165 return None
1166
1167 cache_path = url
Edward Lemur26964072020-02-19 19:18:51 +00001168 url = scm.GIT.GetConfig(url, 'remote.%s.url' % remote, '')
Edward Lemur298f2cf2019-02-22 21:40:39 +00001169
Edward Lemur79d4f992019-11-11 23:49:02 +00001170 host = urllib.parse.urlparse(url).netloc
Edward Lemur298f2cf2019-02-22 21:40:39 +00001171 if not host:
1172 logging.error(
1173 'Remote "%(remote)s" for branch "%(branch)s" points to '
1174 '"%(cache_path)s", but it is misconfigured.\n'
1175 '"%(cache_path)s" must be a git repo and must have a remote named '
1176 '"%(remote)s" pointing to the git host.', {
1177 'remote': remote,
1178 'cache_path': cache_path,
1179 'branch': self.GetBranch()})
1180 return None
1181
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00001182 self._cached_remote_url = (True, url)
dyen@chromium.org2a13d4f2014-06-13 00:06:37 +00001183 return url
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001184
tandrii@chromium.org87985d22016-03-24 17:33:33 +00001185 def GetIssue(self):
maruel@chromium.org52424302012-08-29 15:14:30 +00001186 """Returns the issue number as a int or None if not set."""
tandrii@chromium.org87985d22016-03-24 17:33:33 +00001187 if self.issue is None and not self.lookedup_issue:
Edward Lesmes50da7702020-03-30 19:23:43 +00001188 self.issue = self._GitGetBranchConfigValue(ISSUE_CONFIG_KEY)
Edward Lemur85153282020-02-14 22:06:29 +00001189 if self.issue is not None:
1190 self.issue = int(self.issue)
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001191 self.lookedup_issue = True
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001192 return self.issue
1193
Andrii Shyshkalov1ee78cd2020-03-12 01:31:53 +00001194 def GetIssueURL(self, short=False):
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001195 """Get the URL for a particular issue."""
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001196 issue = self.GetIssue()
1197 if not issue:
dbeam@chromium.org015fd3d2013-06-18 19:02:50 +00001198 return None
Andrii Shyshkalov1ee78cd2020-03-12 01:31:53 +00001199 server = self.GetCodereviewServer()
1200 if short:
1201 server = _KNOWN_GERRIT_TO_SHORT_URLS.get(server, server)
1202 return '%s/%s' % (server, issue)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001203
Dirk Pranke6f0df682021-06-25 00:42:33 +00001204 def GetUsePython3(self):
Josip Sokcevic340edc32021-07-08 17:01:46 +00001205 return settings.GetUsePython3()
Dirk Pranke6f0df682021-06-25 00:42:33 +00001206
Edward Lemur6c6827c2020-02-06 21:15:18 +00001207 def FetchDescription(self, pretty=False):
1208 assert self.GetIssue(), 'issue is required to query Gerrit'
1209
Edward Lemur9aa1a962020-02-25 00:58:38 +00001210 if self.description is None:
Edward Lemur6c6827c2020-02-06 21:15:18 +00001211 data = self._GetChangeDetail(['CURRENT_REVISION', 'CURRENT_COMMIT'])
1212 current_rev = data['current_revision']
1213 self.description = data['revisions'][current_rev]['commit']['message']
Edward Lemur6c6827c2020-02-06 21:15:18 +00001214
1215 if not pretty:
1216 return self.description
1217
1218 # Set width to 72 columns + 2 space indent.
1219 wrapper = textwrap.TextWrapper(width=74, replace_whitespace=True)
1220 wrapper.initial_indent = wrapper.subsequent_indent = ' '
1221 lines = self.description.splitlines()
1222 return '\n'.join([wrapper.fill(line) for line in lines])
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001223
1224 def GetPatchset(self):
maruel@chromium.org52424302012-08-29 15:14:30 +00001225 """Returns the patchset number as a int or None if not set."""
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001226 if self.patchset is None and not self.lookedup_patchset:
Edward Lesmes50da7702020-03-30 19:23:43 +00001227 self.patchset = self._GitGetBranchConfigValue(PATCHSET_CONFIG_KEY)
Edward Lemur85153282020-02-14 22:06:29 +00001228 if self.patchset is not None:
1229 self.patchset = int(self.patchset)
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001230 self.lookedup_patchset = True
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001231 return self.patchset
1232
Edward Lemur9aa1a962020-02-25 00:58:38 +00001233 def GetAuthor(self):
1234 return scm.GIT.GetConfig(settings.GetRoot(), 'user.email')
1235
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001236 def SetPatchset(self, patchset):
tandrii5d48c322016-08-18 16:19:37 -07001237 """Set this branch's patchset. If patchset=0, clears the patchset."""
1238 assert self.GetBranch()
1239 if not patchset:
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001240 self.patchset = None
tandrii5d48c322016-08-18 16:19:37 -07001241 else:
1242 self.patchset = int(patchset)
Edward Lesmes50da7702020-03-30 19:23:43 +00001243 self._GitSetBranchConfigValue(PATCHSET_CONFIG_KEY, str(self.patchset))
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001244
tandrii@chromium.orga342c922016-03-16 07:08:25 +00001245 def SetIssue(self, issue=None):
tandrii5d48c322016-08-18 16:19:37 -07001246 """Set this branch's issue. If issue isn't given, clears the issue."""
1247 assert self.GetBranch()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001248 if issue:
tandrii5d48c322016-08-18 16:19:37 -07001249 issue = int(issue)
Edward Lesmes50da7702020-03-30 19:23:43 +00001250 self._GitSetBranchConfigValue(ISSUE_CONFIG_KEY, str(issue))
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001251 self.issue = issue
Edward Lemur125d60a2019-09-13 18:25:41 +00001252 codereview_server = self.GetCodereviewServer()
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001253 if codereview_server:
tandrii5d48c322016-08-18 16:19:37 -07001254 self._GitSetBranchConfigValue(
Edward Lesmes50da7702020-03-30 19:23:43 +00001255 CODEREVIEW_SERVER_CONFIG_KEY, codereview_server)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001256 else:
tandrii5d48c322016-08-18 16:19:37 -07001257 # Reset all of these just to be clean.
1258 reset_suffixes = [
1259 'last-upload-hash',
Edward Lesmes50da7702020-03-30 19:23:43 +00001260 ISSUE_CONFIG_KEY,
1261 PATCHSET_CONFIG_KEY,
1262 CODEREVIEW_SERVER_CONFIG_KEY,
1263 'gerritsquashhash',
1264 ]
tandrii5d48c322016-08-18 16:19:37 -07001265 for prop in reset_suffixes:
Edward Lemur85153282020-02-14 22:06:29 +00001266 try:
1267 self._GitSetBranchConfigValue(prop, None)
1268 except subprocess2.CalledProcessError:
1269 pass
Aaron Gableca01e2c2017-07-19 11:16:02 -07001270 msg = RunGit(['log', '-1', '--format=%B']).strip()
1271 if msg and git_footers.get_footer_change_id(msg):
1272 print('WARNING: The change patched into this branch has a Change-Id. '
1273 'Removing it.')
1274 RunGit(['commit', '--amend', '-m',
1275 git_footers.remove_footer(msg, 'Change-Id')])
Edward Lemurf38bc172019-09-03 21:02:13 +00001276 self.lookedup_issue = True
maruel@chromium.org1033efd2013-07-23 23:25:09 +00001277 self.issue = None
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00001278 self.patchset = None
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00001279
Edward Lemur2c62b332020-03-12 22:12:33 +00001280 def GetAffectedFiles(self, upstream):
maruel@chromium.org2b38e9c2011-10-19 00:04:35 +00001281 try:
Edward Lemur2c62b332020-03-12 22:12:33 +00001282 return [f for _, f in scm.GIT.CaptureStatus(settings.GetRoot(), upstream)]
maruel@chromium.org2b38e9c2011-10-19 00:04:35 +00001283 except subprocess2.CalledProcessError:
1284 DieWithError(
pgervais@chromium.orgd6617f32013-11-19 00:34:54 +00001285 ('\nFailed to diff against upstream branch %s\n\n'
maruel@chromium.org2b38e9c2011-10-19 00:04:35 +00001286 'This branch probably doesn\'t exist anymore. To reset the\n'
1287 'tracking branch, please run\n'
Josip Sokcevicc39ab992020-09-24 20:09:15 +00001288 ' git branch --set-upstream-to origin/main %s\n'
1289 'or replace origin/main with the relevant branch') %
Edward Lemur2c62b332020-03-12 22:12:33 +00001290 (upstream, self.GetBranch()))
bauerb@chromium.org6fb99c62011-04-18 15:57:28 +00001291
dsansomee2d6fd92016-09-08 00:10:47 -07001292 def UpdateDescription(self, description, force=False):
Edward Lemur6c6827c2020-02-06 21:15:18 +00001293 assert self.GetIssue(), 'issue is required to update description'
1294
1295 if gerrit_util.HasPendingChangeEdit(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001296 self.GetGerritHost(), self._GerritChangeIdentifier()):
Edward Lemur6c6827c2020-02-06 21:15:18 +00001297 if not force:
1298 confirm_or_exit(
1299 'The description cannot be modified while the issue has a pending '
1300 'unpublished edit. Either publish the edit in the Gerrit web UI '
1301 'or delete it.\n\n', action='delete the unpublished edit')
1302
1303 gerrit_util.DeletePendingChangeEdit(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001304 self.GetGerritHost(), self._GerritChangeIdentifier())
Edward Lemur6c6827c2020-02-06 21:15:18 +00001305 gerrit_util.SetCommitMessage(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001306 self.GetGerritHost(), self._GerritChangeIdentifier(),
Edward Lemur6c6827c2020-02-06 21:15:18 +00001307 description, notify='NONE')
1308
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001309 self.description = description
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001310
Edward Lemur75526302020-02-27 22:31:05 +00001311 def _GetCommonPresubmitArgs(self, verbose, upstream):
Edward Lemur227d5102020-02-25 23:45:35 +00001312 args = [
Edward Lemur227d5102020-02-25 23:45:35 +00001313 '--root', settings.GetRoot(),
1314 '--upstream', upstream,
1315 ]
1316
1317 args.extend(['--verbose'] * verbose)
1318
Edward Lesmeseb1bd622021-03-01 19:54:07 +00001319 remote, remote_branch = self.GetRemoteBranch()
1320 target_ref = GetTargetRef(remote, remote_branch, None)
1321 args.extend(['--gerrit_url', self.GetCodereviewServer()])
1322 args.extend(['--gerrit_project', self.GetGerritProject()])
1323 args.extend(['--gerrit_branch', target_ref])
1324
Edward Lemur99df04e2020-03-05 19:39:43 +00001325 author = self.GetAuthor()
Edward Lemur227d5102020-02-25 23:45:35 +00001326 issue = self.GetIssue()
1327 patchset = self.GetPatchset()
Edward Lemur99df04e2020-03-05 19:39:43 +00001328 if author:
1329 args.extend(['--author', author])
Edward Lemur227d5102020-02-25 23:45:35 +00001330 if issue:
1331 args.extend(['--issue', str(issue)])
1332 if patchset:
1333 args.extend(['--patchset', str(patchset)])
Edward Lemur227d5102020-02-25 23:45:35 +00001334
Edward Lemur75526302020-02-27 22:31:05 +00001335 return args
1336
Josip Sokcevic017544d2022-03-31 23:47:53 +00001337 def RunHook(self,
1338 committing,
1339 may_prompt,
1340 verbose,
1341 parallel,
1342 upstream,
1343 description,
1344 all_files,
1345 files=None,
1346 resultdb=False,
1347 realm=None):
Edward Lemur75526302020-02-27 22:31:05 +00001348 """Calls sys.exit() if the hook fails; returns a HookResults otherwise."""
1349 args = self._GetCommonPresubmitArgs(verbose, upstream)
1350 args.append('--commit' if committing else '--upload')
Edward Lemur227d5102020-02-25 23:45:35 +00001351 if may_prompt:
1352 args.append('--may_prompt')
1353 if parallel:
1354 args.append('--parallel')
1355 if all_files:
1356 args.append('--all_files')
Josip Sokcevic017544d2022-03-31 23:47:53 +00001357 if files:
1358 args.extend(files.split(';'))
1359 args.append('--source_controlled_only')
Edward Lemur227d5102020-02-25 23:45:35 +00001360
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001361 if resultdb and not realm:
1362 # TODO (crbug.com/1113463): store realm somewhere and look it up so
1363 # it is not required to pass the realm flag
1364 print('Note: ResultDB reporting will NOT be performed because --realm'
1365 ' was not specified. To enable ResultDB, please run the command'
1366 ' again with the --realm argument to specify the LUCI realm.')
1367
1368 py2_results = self._RunPresubmit(args, resultdb, realm, description,
1369 use_python3=False)
1370 py3_results = self._RunPresubmit(args, resultdb, realm, description,
1371 use_python3=True)
1372 return self._MergePresubmitResults(py2_results, py3_results)
1373
1374 def _RunPresubmit(self, args, resultdb, realm, description, use_python3):
1375 args = args[:]
1376 vpython = 'vpython3' if use_python3 else 'vpython'
1377
Edward Lemur227d5102020-02-25 23:45:35 +00001378 with gclient_utils.temporary_file() as description_file:
1379 with gclient_utils.temporary_file() as json_output:
Edward Lemur1a83da12020-03-04 21:18:36 +00001380 gclient_utils.FileWrite(description_file, description)
Edward Lemur227d5102020-02-25 23:45:35 +00001381 args.extend(['--json_output', json_output])
1382 args.extend(['--description_file', description_file])
Dirk Pranke6f0df682021-06-25 00:42:33 +00001383 if self.GetUsePython3():
1384 args.append('--use-python3')
Edward Lemur227d5102020-02-25 23:45:35 +00001385 start = time_time()
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001386 cmd = [vpython, PRESUBMIT_SUPPORT] + args
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001387 if resultdb and realm:
1388 cmd = ['rdb', 'stream', '-new', '-realm', realm, '--'] + cmd
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00001389
1390 p = subprocess2.Popen(cmd)
Edward Lemur227d5102020-02-25 23:45:35 +00001391 exit_code = p.wait()
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00001392
Edward Lemur227d5102020-02-25 23:45:35 +00001393 metrics.collector.add_repeated('sub_commands', {
1394 'command': 'presubmit',
1395 'execution_time': time_time() - start,
1396 'exit_code': exit_code,
1397 })
1398
1399 if exit_code:
1400 sys.exit(exit_code)
1401
1402 json_results = gclient_utils.FileRead(json_output)
1403 return json.loads(json_results)
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001404
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001405 def _MergePresubmitResults(self, py2_results, py3_results):
1406 return {
1407 'more_cc': sorted(set(py2_results.get('more_cc', []) +
1408 py3_results.get('more_cc', []))),
1409 'errors': (
1410 py2_results.get('errors', []) + py3_results.get('errors', [])),
1411 'notifications': (
1412 py2_results.get('notifications', []) +
1413 py3_results.get('notifications', [])),
1414 'warnings': (
1415 py2_results.get('warnings', []) + py3_results.get('warnings', []))
1416 }
1417
Edward Lemur75526302020-02-27 22:31:05 +00001418 def RunPostUploadHook(self, verbose, upstream, description):
1419 args = self._GetCommonPresubmitArgs(verbose, upstream)
1420 args.append('--post_upload')
1421
1422 with gclient_utils.temporary_file() as description_file:
Edward Lemur1a83da12020-03-04 21:18:36 +00001423 gclient_utils.FileWrite(description_file, description)
Edward Lemur75526302020-02-27 22:31:05 +00001424 args.extend(['--description_file', description_file])
Josip Sokcevice293d3d2022-02-16 22:52:15 +00001425 p_py2 = subprocess2.Popen(['vpython', PRESUBMIT_SUPPORT] + args)
1426 p_py3 = subprocess2.Popen(['vpython3', PRESUBMIT_SUPPORT] + args +
1427 ['--use-python3'])
1428 p_py2.wait()
1429 p_py3.wait()
Edward Lemur75526302020-02-27 22:31:05 +00001430
Edward Lemur5a644f82020-03-18 16:44:57 +00001431 def _GetDescriptionForUpload(self, options, git_diff_args, files):
1432 # Get description message for upload.
1433 if self.GetIssue():
1434 description = self.FetchDescription()
1435 elif options.message:
1436 description = options.message
1437 else:
1438 description = _create_description_from_log(git_diff_args)
1439 if options.title and options.squash:
Edward Lesmes0dd54822020-03-26 18:24:25 +00001440 description = options.title + '\n\n' + description
Edward Lemur5a644f82020-03-18 16:44:57 +00001441
Edward Lemur5a644f82020-03-18 16:44:57 +00001442 bug = options.bug
1443 fixed = options.fixed
Josip Sokcevic340edc32021-07-08 17:01:46 +00001444 if not self.GetIssue():
1445 # Extract bug number from branch name, but only if issue is being created.
1446 # It must start with bug or fix, followed by _ or - and number.
1447 # Optionally, it may contain _ or - after number with arbitrary text.
1448 # Examples:
1449 # bug-123
1450 # bug_123
1451 # fix-123
1452 # fix-123-some-description
1453 match = re.match(
1454 r'^(?P<type>bug|fix(?:e[sd])?)[_-]?(?P<bugnum>\d+)([-_]|$)',
1455 self.GetBranch())
1456 if not bug and not fixed and match:
1457 if match.group('type') == 'bug':
1458 bug = match.group('bugnum')
1459 else:
1460 fixed = match.group('bugnum')
Edward Lemur5a644f82020-03-18 16:44:57 +00001461
1462 change_description = ChangeDescription(description, bug, fixed)
1463
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001464 # Fill gaps in OWNERS coverage to tbrs/reviewers if requested.
1465 if options.add_owners_to:
1466 assert options.add_owners_to in ('TBR', 'R'), options.add_owners_to
Edward Lesmese1576912021-02-16 21:53:34 +00001467 status = self.owners_client.GetFilesApprovalStatus(
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001468 files, [], options.tbrs + options.reviewers)
1469 missing_files = [
1470 f for f in files
Edward Lesmese1576912021-02-16 21:53:34 +00001471 if status[f] == self._owners_client.INSUFFICIENT_REVIEWERS
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001472 ]
Edward Lesmese1576912021-02-16 21:53:34 +00001473 owners = self.owners_client.SuggestOwners(
1474 missing_files, exclude=[self.GetAuthor()])
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001475 if options.add_owners_to == 'TBR':
1476 assert isinstance(options.tbrs, list), options.tbrs
1477 options.tbrs.extend(owners)
1478 else:
1479 assert isinstance(options.reviewers, list), options.reviewers
1480 options.reviewers.extend(owners)
1481
Edward Lemur5a644f82020-03-18 16:44:57 +00001482 # Set the reviewer list now so that presubmit checks can access it.
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00001483 if options.reviewers or options.tbrs:
1484 change_description.update_reviewers(options.reviewers, options.tbrs)
Edward Lemur5a644f82020-03-18 16:44:57 +00001485
1486 return change_description
1487
1488 def _GetTitleForUpload(self, options):
1489 # When not squashing, just return options.title.
1490 if not options.squash:
1491 return options.title
1492
1493 # On first upload, patchset title is always this string, while options.title
1494 # gets converted to first line of message.
1495 if not self.GetIssue():
1496 return 'Initial upload'
1497
1498 # When uploading subsequent patchsets, options.message is taken as the title
1499 # if options.title is not provided.
1500 if options.title:
1501 return options.title
1502 if options.message:
1503 return options.message.strip()
1504
1505 # Use the subject of the last commit as title by default.
Edward Lesmes50da7702020-03-30 19:23:43 +00001506 title = RunGit(['show', '-s', '--format=%s', 'HEAD']).strip()
Mario Bianuccicebfb4e2020-07-22 23:08:16 +00001507 if options.force or options.skip_title:
Edward Lemur5a644f82020-03-18 16:44:57 +00001508 return title
Edward Lesmesae3586b2020-03-23 21:21:14 +00001509 user_title = gclient_utils.AskForData('Title for patchset [%s]: ' % title)
mlcui3da91712021-05-05 10:00:30 +00001510
1511 # Use the default title if the user confirms the default with a 'y'.
1512 if user_title.lower() == 'y':
1513 return title
Edward Lesmesae3586b2020-03-23 21:21:14 +00001514 return user_title or title
Edward Lemur5a644f82020-03-18 16:44:57 +00001515
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001516 def CMDUpload(self, options, git_diff_args, orig_args):
1517 """Uploads a change to codereview."""
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001518 custom_cl_base = None
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001519 if git_diff_args:
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001520 custom_cl_base = base_branch = git_diff_args[0]
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001521 else:
1522 if self.GetBranch() is None:
1523 DieWithError('Can\'t upload from detached HEAD state. Get on a branch!')
1524
1525 # Default to diffing against common ancestor of upstream branch
1526 base_branch = self.GetCommonAncestorWithUpstream()
1527 git_diff_args = [base_branch, 'HEAD']
1528
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001529 # Fast best-effort checks to abort before running potentially expensive
1530 # hooks if uploading is likely to fail anyway. Passing these checks does
1531 # not guarantee that uploading will not fail.
Edward Lemur125d60a2019-09-13 18:25:41 +00001532 self.EnsureAuthenticated(force=options.force)
1533 self.EnsureCanUploadPatchset(force=options.force)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001534
1535 # Apply watchlists on upload.
Edward Lemur2c62b332020-03-12 22:12:33 +00001536 watchlist = watchlists.Watchlists(settings.GetRoot())
1537 files = self.GetAffectedFiles(base_branch)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001538 if not options.bypass_watchlists:
Daniel Cheng7227d212017-11-17 08:12:37 -08001539 self.ExtendCC(watchlist.GetWatchersForPaths(files))
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001540
Edward Lemur5a644f82020-03-18 16:44:57 +00001541 change_desc = self._GetDescriptionForUpload(options, git_diff_args, files)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001542 if not options.bypass_hooks:
Edward Lemur2c62b332020-03-12 22:12:33 +00001543 hook_results = self.RunHook(
1544 committing=False,
1545 may_prompt=not options.force,
1546 verbose=options.verbose,
1547 parallel=options.parallel,
1548 upstream=base_branch,
Edward Lemur5a644f82020-03-18 16:44:57 +00001549 description=change_desc.description,
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00001550 all_files=False,
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001551 resultdb=options.resultdb,
1552 realm=options.realm)
Edward Lemur227d5102020-02-25 23:45:35 +00001553 self.ExtendCC(hook_results['more_cc'])
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001554
Aaron Gable13101a62018-02-09 13:20:41 -08001555 print_stats(git_diff_args)
Edward Lemura12175c2020-03-09 16:58:26 +00001556 ret = self.CMDUploadChange(
Edward Lemur5a644f82020-03-18 16:44:57 +00001557 options, git_diff_args, custom_cl_base, change_desc)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001558 if not ret:
Edward Lemur85153282020-02-14 22:06:29 +00001559 self._GitSetBranchConfigValue(
Edward Lesmes50da7702020-03-30 19:23:43 +00001560 'last-upload-hash', scm.GIT.ResolveCommit(settings.GetRoot(), 'HEAD'))
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001561 # Run post upload hooks, if specified.
1562 if settings.GetRunPostUploadHook():
Edward Lemur5a644f82020-03-18 16:44:57 +00001563 self.RunPostUploadHook(
1564 options.verbose, base_branch, change_desc.description)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001565
1566 # Upload all dependencies if specified.
1567 if options.dependencies:
vapiera7fbd5a2016-06-16 09:17:49 -07001568 print()
1569 print('--dependencies has been specified.')
1570 print('All dependent local branches will be re-uploaded.')
1571 print()
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001572 # Remove the dependencies flag from args so that we do not end up in a
1573 # loop.
1574 orig_args.remove('--dependencies')
Jose Lopes3863fc52020-04-07 17:00:25 +00001575 ret = upload_branch_deps(self, orig_args, options.force)
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001576 return ret
1577
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001578 def SetCQState(self, new_state):
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07001579 """Updates the CQ state for the latest patchset.
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001580
Greg Gutermanbe5fccd2021-06-14 17:58:20 +00001581 Issue must have been already uploaded and known. Optionally allows for
1582 updating Quick-Run (QR) state.
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00001583 """
1584 assert new_state in _CQState.ALL_STATES
1585 assert self.GetIssue()
qyearsley1fdfcb62016-10-24 13:22:03 -07001586 try:
Edward Lemur125d60a2019-09-13 18:25:41 +00001587 vote_map = {
1588 _CQState.NONE: 0,
Greg Gutermanbe5fccd2021-06-14 17:58:20 +00001589 _CQState.QUICK_RUN: 1,
Edward Lemur125d60a2019-09-13 18:25:41 +00001590 _CQState.DRY_RUN: 1,
1591 _CQState.COMMIT: 2,
1592 }
Greg Gutermanbe5fccd2021-06-14 17:58:20 +00001593 if new_state == _CQState.QUICK_RUN:
1594 labels = {
1595 'Commit-Queue': vote_map[_CQState.DRY_RUN],
1596 'Quick-Run': vote_map[_CQState.QUICK_RUN],
1597 }
1598 else:
1599 labels = {'Commit-Queue': vote_map[new_state]}
Edward Lemur125d60a2019-09-13 18:25:41 +00001600 notify = False if new_state == _CQState.DRY_RUN else None
1601 gerrit_util.SetReview(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001602 self.GetGerritHost(), self._GerritChangeIdentifier(),
Edward Lemur125d60a2019-09-13 18:25:41 +00001603 labels=labels, notify=notify)
qyearsley1fdfcb62016-10-24 13:22:03 -07001604 return 0
1605 except KeyboardInterrupt:
1606 raise
1607 except:
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07001608 print('WARNING: Failed to %s.\n'
qyearsley1fdfcb62016-10-24 13:22:03 -07001609 'Either:\n'
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07001610 ' * Your project has no CQ,\n'
1611 ' * You don\'t have permission to change the CQ state,\n'
1612 ' * There\'s a bug in this code (see stack trace below).\n'
1613 'Consider specifying which bots to trigger manually or asking your '
1614 'project owners for permissions or contacting Chrome Infra at:\n'
1615 'https://www.chromium.org/infra\n\n' %
1616 ('cancel CQ' if new_state == _CQState.NONE else 'trigger CQ'))
qyearsley1fdfcb62016-10-24 13:22:03 -07001617 # Still raise exception so that stack trace is printed.
1618 raise
1619
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001620 def GetGerritHost(self):
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001621 # Lazy load of configs.
1622 self.GetCodereviewServer()
tandriie32e3ea2016-06-22 02:52:48 -07001623 if self._gerrit_host and '.' not in self._gerrit_host:
1624 # Abbreviated domain like "chromium" instead of chromium.googlesource.com.
1625 # This happens for internal stuff http://crbug.com/614312.
Edward Lemur79d4f992019-11-11 23:49:02 +00001626 parsed = urllib.parse.urlparse(self.GetRemoteUrl())
tandriie32e3ea2016-06-22 02:52:48 -07001627 if parsed.scheme == 'sso':
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001628 print('WARNING: using non-https URLs for remote is likely broken\n'
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001629 ' Your current remote is: %s' % self.GetRemoteUrl())
tandriie32e3ea2016-06-22 02:52:48 -07001630 self._gerrit_host = '%s.googlesource.com' % self._gerrit_host
1631 self._gerrit_server = 'https://%s' % self._gerrit_host
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001632 return self._gerrit_host
1633
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001634 def _GetGitHost(self):
1635 """Returns git host to be used when uploading change to Gerrit."""
Edward Lemur298f2cf2019-02-22 21:40:39 +00001636 remote_url = self.GetRemoteUrl()
1637 if not remote_url:
1638 return None
Edward Lemur79d4f992019-11-11 23:49:02 +00001639 return urllib.parse.urlparse(remote_url).netloc
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001640
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001641 def GetCodereviewServer(self):
1642 if not self._gerrit_server:
1643 # If we're on a branch then get the server potentially associated
1644 # with that branch.
Edward Lemur85153282020-02-14 22:06:29 +00001645 if self.GetIssue() and self.GetBranch():
tandrii5d48c322016-08-18 16:19:37 -07001646 self._gerrit_server = self._GitGetBranchConfigValue(
Edward Lesmes50da7702020-03-30 19:23:43 +00001647 CODEREVIEW_SERVER_CONFIG_KEY)
tandrii5d48c322016-08-18 16:19:37 -07001648 if self._gerrit_server:
Edward Lemur79d4f992019-11-11 23:49:02 +00001649 self._gerrit_host = urllib.parse.urlparse(self._gerrit_server).netloc
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001650 if not self._gerrit_server:
1651 # We assume repo to be hosted on Gerrit, and hence Gerrit server
1652 # has "-review" suffix for lowest level subdomain.
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001653 parts = self._GetGitHost().split('.')
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001654 parts[0] = parts[0] + '-review'
1655 self._gerrit_host = '.'.join(parts)
1656 self._gerrit_server = 'https://%s' % self._gerrit_host
1657 return self._gerrit_server
1658
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001659 def GetGerritProject(self):
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001660 """Returns Gerrit project name based on remote git URL."""
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00001661 remote_url = self.GetRemoteUrl()
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001662 if remote_url is None:
Josip906bfde2020-01-31 22:38:49 +00001663 logging.warning('can\'t detect Gerrit project.')
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00001664 return None
Edward Lemur79d4f992019-11-11 23:49:02 +00001665 project = urllib.parse.urlparse(remote_url).path.strip('/')
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001666 if project.endswith('.git'):
1667 project = project[:-len('.git')]
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00001668 # *.googlesource.com hosts ensure that Git/Gerrit projects don't start with
1669 # 'a/' prefix, because 'a/' prefix is used to force authentication in
1670 # gitiles/git-over-https protocol. E.g.,
1671 # https://chromium.googlesource.com/a/v8/v8 refers to the same repo/project
1672 # as
1673 # https://chromium.googlesource.com/v8/v8
1674 if project.startswith('a/'):
1675 project = project[len('a/'):]
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001676 return project
1677
Andrii Shyshkalovd06cc782018-08-23 17:24:19 +00001678 def _GerritChangeIdentifier(self):
1679 """Handy method for gerrit_util.ChangeIdentifier for a given CL.
1680
1681 Not to be confused by value of "Change-Id:" footer.
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00001682 If Gerrit project can be determined, this will speed up Gerrit HTTP API RPC.
Andrii Shyshkalovd06cc782018-08-23 17:24:19 +00001683 """
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001684 project = self.GetGerritProject()
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00001685 if project:
1686 return gerrit_util.ChangeIdentifier(project, self.GetIssue())
1687 # Fall back on still unique, but less efficient change number.
1688 return str(self.GetIssue())
Andrii Shyshkalovd06cc782018-08-23 17:24:19 +00001689
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01001690 def EnsureAuthenticated(self, force, refresh=None):
tandrii@chromium.org9e6c3a52016-04-12 14:13:08 +00001691 """Best effort check that user is authenticated with Gerrit server."""
tandrii@chromium.org28253532016-04-14 13:46:56 +00001692 if settings.GetGerritSkipEnsureAuthenticated():
1693 # For projects with unusual authentication schemes.
1694 # See http://crbug.com/603378.
1695 return
Vadim Shtayurab250ec12018-10-04 00:21:08 +00001696
1697 # Check presence of cookies only if using cookies-based auth method.
1698 cookie_auth = gerrit_util.Authenticator.get()
1699 if not isinstance(cookie_auth, gerrit_util.CookiesAuthenticator):
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001700 return
Vadim Shtayurab250ec12018-10-04 00:21:08 +00001701
Florian Mayerae510e82020-01-30 21:04:48 +00001702 remote_url = self.GetRemoteUrl()
1703 if remote_url is None:
Josip906bfde2020-01-31 22:38:49 +00001704 logging.warning('invalid remote')
Florian Mayerae510e82020-01-30 21:04:48 +00001705 return
1706 if urllib.parse.urlparse(remote_url).scheme != 'https':
Josip906bfde2020-01-31 22:38:49 +00001707 logging.warning('Ignoring branch %(branch)s with non-https remote '
1708 '%(remote)s', {
1709 'branch': self.branch,
1710 'remote': self.GetRemoteUrl()
1711 })
Daniel Chengcf6269b2019-05-18 01:02:12 +00001712 return
1713
Vadim Shtayurab250ec12018-10-04 00:21:08 +00001714 # Lazy-loader to identify Gerrit and Git hosts.
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001715 self.GetCodereviewServer()
1716 git_host = self._GetGitHost()
Edward Lemur298f2cf2019-02-22 21:40:39 +00001717 assert self._gerrit_server and self._gerrit_host and git_host
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001718
1719 gerrit_auth = cookie_auth.get_auth_header(self._gerrit_host)
1720 git_auth = cookie_auth.get_auth_header(git_host)
1721 if gerrit_auth and git_auth:
1722 if gerrit_auth == git_auth:
1723 return
Andrii Shyshkalov354e1d22017-06-09 19:31:33 +02001724 all_gsrc = cookie_auth.get_auth_header('d0esN0tEx1st.googlesource.com')
Raul Tambre80ee78e2019-05-06 22:41:05 +00001725 print(
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001726 'WARNING: You have different credentials for Gerrit and git hosts:\n'
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001727 ' %s\n'
1728 ' %s\n'
Andrii Shyshkalov51acef92017-04-11 17:19:59 +02001729 ' Consider running the following command:\n'
1730 ' git cl creds-check\n'
Andrii Shyshkalov354e1d22017-06-09 19:31:33 +02001731 ' %s\n'
Raul Tambre80ee78e2019-05-06 22:41:05 +00001732 ' %s' %
Andrii Shyshkalov51acef92017-04-11 17:19:59 +02001733 (git_host, self._gerrit_host,
Andrii Shyshkalov354e1d22017-06-09 19:31:33 +02001734 ('Hint: delete creds for .googlesource.com' if all_gsrc else ''),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001735 cookie_auth.get_new_password_message(git_host)))
1736 if not force:
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01001737 confirm_or_exit('If you know what you are doing', action='continue')
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001738 return
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +00001739
1740 missing = (
1741 ([] if gerrit_auth else [self._gerrit_host]) +
1742 ([] if git_auth else [git_host]))
1743 DieWithError('Credentials for the following hosts are required:\n'
1744 ' %s\n'
1745 'These are read from %s (or legacy %s)\n'
1746 '%s' % (
1747 '\n '.join(missing),
1748 cookie_auth.get_gitcookies_path(),
1749 cookie_auth.get_netrc_path(),
1750 cookie_auth.get_new_password_message(git_host)))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001751
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001752 def EnsureCanUploadPatchset(self, force):
Andrii Shyshkalov3e631422017-02-16 17:46:44 +01001753 if not self.GetIssue():
1754 return
1755
Andrii Shyshkalov3e631422017-02-16 17:46:44 +01001756 status = self._GetChangeDetail()['status']
Joanna Wang583ca662022-04-27 21:17:17 +00001757 if status == 'ABANDONED':
1758 DieWithError(
1759 'Change %s has been abandoned, new uploads are not allowed' %
1760 (self.GetIssueURL()))
1761 if status == 'MERGED':
1762 answer = gclient_utils.AskForData(
1763 'Change %s has been submitted, new uploads are not allowed. '
1764 'Would you like to start a new change (Y/n)?' % self.GetIssueURL()
1765 ).lower()
1766 if answer not in ('y', ''):
1767 DieWithError('New uploads are not allowed.')
1768 self.SetIssue()
1769 return
Andrii Shyshkalov3e631422017-02-16 17:46:44 +01001770
Vadim Shtayurab250ec12018-10-04 00:21:08 +00001771 # TODO(vadimsh): For some reason the chunk of code below was skipped if
1772 # 'is_gce' is True. I'm just refactoring it to be 'skip if not cookies'.
1773 # Apparently this check is not very important? Otherwise get_auth_email
1774 # could have been added to other implementations of Authenticator.
1775 cookies_auth = gerrit_util.Authenticator.get()
1776 if not isinstance(cookies_auth, gerrit_util.CookiesAuthenticator):
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001777 return
Vadim Shtayurab250ec12018-10-04 00:21:08 +00001778
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001779 cookies_user = cookies_auth.get_auth_email(self.GetGerritHost())
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001780 if self.GetIssueOwner() == cookies_user:
1781 return
1782 logging.debug('change %s owner is %s, cookies user is %s',
1783 self.GetIssue(), self.GetIssueOwner(), cookies_user)
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001784 # Maybe user has linked accounts or something like that,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001785 # so ask what Gerrit thinks of this user.
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001786 details = gerrit_util.GetAccountDetails(self.GetGerritHost(), 'self')
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001787 if details['email'] == self.GetIssueOwner():
1788 return
1789 if not force:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001790 print('WARNING: Change %s is owned by %s, but you authenticate to Gerrit '
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001791 'as %s.\n'
1792 'Uploading may fail due to lack of permissions.' %
1793 (self.GetIssue(), self.GetIssueOwner(), details['email']))
1794 confirm_or_exit(action='upload')
1795
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001796 def GetStatus(self):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00001797 """Applies a rough heuristic to give a simple summary of an issue's review
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001798 or CQ status, assuming adherence to a common workflow.
1799
1800 Returns None if no issue for this branch, or one of the following keywords:
Aaron Gable9ab38c62017-04-06 14:36:33 -07001801 * 'error' - error from review tool (including deleted issues)
1802 * 'unsent' - no reviewers added
1803 * 'waiting' - waiting for review
1804 * 'reply' - waiting for uploader to reply to review
1805 * 'lgtm' - Code-Review label has been set
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +00001806 * 'dry-run' - dry-running in the CQ
1807 * 'commit' - in the CQ
Aaron Gable9ab38c62017-04-06 14:36:33 -07001808 * 'closed' - successfully submitted or abandoned
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001809 """
1810 if not self.GetIssue():
1811 return None
1812
1813 try:
Aaron Gable9ab38c62017-04-06 14:36:33 -07001814 data = self._GetChangeDetail([
1815 'DETAILED_LABELS', 'CURRENT_REVISION', 'SUBMITTABLE'])
Edward Lemur79d4f992019-11-11 23:49:02 +00001816 except GerritChangeNotExists:
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001817 return 'error'
1818
tandrii@chromium.org5e1bf382016-05-17 08:43:24 +00001819 if data['status'] in ('ABANDONED', 'MERGED'):
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001820 return 'closed'
1821
Andrii Shyshkalovb8268ca2019-04-03 23:33:44 +00001822 cq_label = data['labels'].get('Commit-Queue', {})
1823 max_cq_vote = 0
1824 for vote in cq_label.get('all', []):
1825 max_cq_vote = max(max_cq_vote, vote.get('value', 0))
1826 if max_cq_vote == 2:
Aaron Gable9ab38c62017-04-06 14:36:33 -07001827 return 'commit'
Andrii Shyshkalovb8268ca2019-04-03 23:33:44 +00001828 if max_cq_vote == 1:
1829 return 'dry-run'
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001830
Aaron Gable9ab38c62017-04-06 14:36:33 -07001831 if data['labels'].get('Code-Review', {}).get('approved'):
1832 return 'lgtm'
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001833
1834 if not data.get('reviewers', {}).get('REVIEWER', []):
1835 return 'unsent'
1836
Andrii Shyshkalov33e88a42017-01-27 14:45:30 +01001837 owner = data['owner'].get('_account_id')
Edward Lemur79d4f992019-11-11 23:49:02 +00001838 messages = sorted(data.get('messages', []), key=lambda m: m.get('date'))
Andrii Shyshkalov8aa9d622020-03-10 19:15:35 +00001839 while messages:
1840 m = messages.pop()
Andrii Shyshkalov899785a2021-07-09 12:45:37 +00001841 if (m.get('tag', '').startswith('autogenerated:cq') or
1842 m.get('tag', '').startswith('autogenerated:cv')):
1843 # Ignore replies from LUCI CV/CQ.
Andrii Shyshkalov33e88a42017-01-27 14:45:30 +01001844 continue
Andrii Shyshkalov8aa9d622020-03-10 19:15:35 +00001845 if m.get('author', {}).get('_account_id') == owner:
Aaron Gable9ab38c62017-04-06 14:36:33 -07001846 # Most recent message was by owner.
1847 return 'waiting'
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +00001848
1849 # Some reply from non-owner.
1850 return 'reply'
Aaron Gable9ab38c62017-04-06 14:36:33 -07001851
1852 # Somehow there are no messages even though there are reviewers.
1853 return 'unsent'
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001854
1855 def GetMostRecentPatchset(self):
Edward Lemur6c6827c2020-02-06 21:15:18 +00001856 if not self.GetIssue():
1857 return None
1858
tandrii@chromium.org013a2802016-03-29 09:52:33 +00001859 data = self._GetChangeDetail(['CURRENT_REVISION'])
Aaron Gablee8856ee2017-12-07 12:41:46 -08001860 patchset = data['revisions'][data['current_revision']]['_number']
1861 self.SetPatchset(patchset)
1862 return patchset
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001863
Gavin Make61ccc52020-11-13 00:12:57 +00001864 def GetMostRecentDryRunPatchset(self):
1865 """Get patchsets equivalent to the most recent patchset and return
1866 the patchset with the latest dry run. If none have been dry run, return
1867 the latest patchset."""
1868 if not self.GetIssue():
1869 return None
1870
1871 data = self._GetChangeDetail(['ALL_REVISIONS'])
1872 patchset = data['revisions'][data['current_revision']]['_number']
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +00001873 dry_run = {int(m['_revision_number'])
1874 for m in data.get('messages', [])
1875 if m.get('tag', '').endswith('dry-run')}
Gavin Make61ccc52020-11-13 00:12:57 +00001876
1877 for revision_info in sorted(data.get('revisions', {}).values(),
1878 key=lambda c: c['_number'], reverse=True):
1879 if revision_info['_number'] in dry_run:
1880 patchset = revision_info['_number']
1881 break
1882 if revision_info.get('kind', '') not in \
1883 ('NO_CHANGE', 'NO_CODE_CHANGE', 'TRIVIAL_REBASE'):
1884 break
1885 self.SetPatchset(patchset)
1886 return patchset
1887
Aaron Gable636b13f2017-07-14 10:42:48 -07001888 def AddComment(self, message, publish=None):
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00001889 gerrit_util.SetReview(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001890 self.GetGerritHost(), self._GerritChangeIdentifier(),
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00001891 msg=message, ready=publish)
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01001892
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001893 def GetCommentsSummary(self, readable=True):
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01001894 # DETAILED_ACCOUNTS is to get emails in accounts.
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001895 # CURRENT_REVISION is included to get the latest patchset so that
1896 # only the robot comments from the latest patchset can be shown.
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001897 messages = self._GetChangeDetail(
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001898 options=['MESSAGES', 'DETAILED_ACCOUNTS',
1899 'CURRENT_REVISION']).get('messages', [])
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001900 file_comments = gerrit_util.GetChangeComments(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001901 self.GetGerritHost(), self._GerritChangeIdentifier())
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001902 robot_file_comments = gerrit_util.GetChangeRobotComments(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00001903 self.GetGerritHost(), self._GerritChangeIdentifier())
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001904
1905 # Add the robot comments onto the list of comments, but only
Andrii Shyshkalovaeee6a82019-10-09 21:56:25 +00001906 # keep those that are from the latest patchset.
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001907 latest_patch_set = self.GetMostRecentPatchset()
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001908 for path, robot_comments in robot_file_comments.items():
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001909 line_comments = file_comments.setdefault(path, [])
1910 line_comments.extend(
1911 [c for c in robot_comments if c['patch_set'] == latest_patch_set])
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001912
1913 # Build dictionary of file comments for easy access and sorting later.
1914 # {author+date: {path: {patchset: {line: url+message}}}}
1915 comments = collections.defaultdict(
1916 lambda: collections.defaultdict(lambda: collections.defaultdict(dict)))
Andrii Shyshkalova3762a92020-11-25 10:20:42 +00001917
1918 server = self.GetCodereviewServer()
1919 if server in _KNOWN_GERRIT_TO_SHORT_URLS:
1920 # /c/ is automatically added by short URL server.
1921 url_prefix = '%s/%s' % (_KNOWN_GERRIT_TO_SHORT_URLS[server],
1922 self.GetIssue())
1923 else:
1924 url_prefix = '%s/c/%s' % (server, self.GetIssue())
1925
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001926 for path, line_comments in file_comments.items():
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001927 for comment in line_comments:
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001928 tag = comment.get('tag', '')
1929 if tag.startswith('autogenerated') and 'robot_id' not in comment:
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001930 continue
1931 key = (comment['author']['email'], comment['updated'])
1932 if comment.get('side', 'REVISION') == 'PARENT':
1933 patchset = 'Base'
1934 else:
1935 patchset = 'PS%d' % comment['patch_set']
1936 line = comment.get('line', 0)
Andrii Shyshkalova3762a92020-11-25 10:20:42 +00001937 url = ('%s/%s/%s#%s%s' %
1938 (url_prefix, comment['patch_set'], path,
1939 'b' if comment.get('side') == 'PARENT' else '',
1940 str(line) if line else ''))
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001941 comments[key][path][patchset][line] = (url, comment['message'])
1942
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001943 summaries = []
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001944 for msg in messages:
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001945 summary = self._BuildCommentSummary(msg, comments, readable)
1946 if summary:
1947 summaries.append(summary)
1948 return summaries
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07001949
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001950 @staticmethod
1951 def _BuildCommentSummary(msg, comments, readable):
Josip Sokcevic266129c2021-11-09 00:22:00 +00001952 if 'email' not in msg['author']:
1953 # Some bot accounts may not have an email associated.
1954 return None
1955
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001956 key = (msg['author']['email'], msg['date'])
1957 # Don't bother showing autogenerated messages that don't have associated
1958 # file or line comments. this will filter out most autogenerated
1959 # messages, but will keep robot comments like those from Tricium.
1960 is_autogenerated = msg.get('tag', '').startswith('autogenerated')
1961 if is_autogenerated and not comments.get(key):
1962 return None
1963 message = msg['message']
1964 # Gerrit spits out nanoseconds.
1965 assert len(msg['date'].split('.')[-1]) == 9
1966 date = datetime.datetime.strptime(msg['date'][:-3],
1967 '%Y-%m-%d %H:%M:%S.%f')
1968 if key in comments:
1969 message += '\n'
1970 for path, patchsets in sorted(comments.get(key, {}).items()):
1971 if readable:
1972 message += '\n%s' % path
1973 for patchset, lines in sorted(patchsets.items()):
1974 for line, (url, content) in sorted(lines.items()):
1975 if line:
1976 line_str = 'Line %d' % line
1977 path_str = '%s:%d:' % (path, line)
1978 else:
1979 line_str = 'File comment'
1980 path_str = '%s:0:' % path
1981 if readable:
1982 message += '\n %s, %s: %s' % (patchset, line_str, url)
1983 message += '\n %s\n' % content
1984 else:
1985 message += '\n%s ' % path_str
1986 message += '\n%s\n' % content
1987
1988 return _CommentSummary(
1989 date=date,
1990 message=message,
1991 sender=msg['author']['email'],
1992 autogenerated=is_autogenerated,
1993 # These could be inferred from the text messages and correlated with
1994 # Code-Review label maximum, however this is not reliable.
1995 # Leaving as is until the need arises.
1996 approval=False,
1997 disapproval=False,
1998 )
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01001999
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00002000 def CloseIssue(self):
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002001 gerrit_util.AbandonChange(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00002002 self.GetGerritHost(), self._GerritChangeIdentifier(), msg='')
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00002003
Xinan Lin1bd4ffa2021-07-28 00:54:22 +00002004 def SubmitIssue(self):
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002005 gerrit_util.SubmitChange(
Xinan Lin1bd4ffa2021-07-28 00:54:22 +00002006 self.GetGerritHost(), self._GerritChangeIdentifier())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00002007
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002008 def _GetChangeDetail(self, options=None):
2009 """Returns details of associated Gerrit change and caching results."""
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002010 options = options or []
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002011 assert self.GetIssue(), 'issue is required to query Gerrit'
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002012
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01002013 # Optimization to avoid multiple RPCs:
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002014 if 'CURRENT_REVISION' in options or 'ALL_REVISIONS' in options:
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01002015 options.append('CURRENT_COMMIT')
2016
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002017 # Normalize issue and options for consistent keys in cache.
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002018 cache_key = str(self.GetIssue())
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002019 options_set = frozenset(o.upper() for o in options)
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002020
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002021 for cached_options_set, data in self._detail_cache.get(cache_key, []):
2022 # Assumption: data fetched before with extra options is suitable
2023 # for return for a smaller set of options.
2024 # For example, if we cached data for
2025 # options=[CURRENT_REVISION, DETAILED_FOOTERS]
2026 # and request is for options=[CURRENT_REVISION],
2027 # THEN we can return prior cached data.
2028 if options_set.issubset(cached_options_set):
2029 return data
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002030
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01002031 try:
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002032 data = gerrit_util.GetChangeDetail(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00002033 self.GetGerritHost(), self._GerritChangeIdentifier(), options_set)
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01002034 except gerrit_util.GerritError as e:
2035 if e.http_status == 404:
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002036 raise GerritChangeNotExists(self.GetIssue(), self.GetCodereviewServer())
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01002037 raise
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002038
Edward Lesmes7677e5c2020-02-19 20:39:03 +00002039 self._detail_cache.setdefault(cache_key, []).append((options_set, data))
tandriic2405f52016-10-10 08:13:15 -07002040 return data
tandrii@chromium.org013a2802016-03-29 09:52:33 +00002041
Andrii Shyshkalovcc5f17e2018-08-22 23:35:59 +00002042 def _GetChangeCommit(self):
Andrii Shyshkalove2633162018-08-27 23:50:31 +00002043 assert self.GetIssue(), 'issue must be set to query Gerrit'
Aaron Gable6f5a8d92017-04-18 14:49:05 -07002044 try:
Andrii Shyshkalove2633162018-08-27 23:50:31 +00002045 data = gerrit_util.GetChangeCommit(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00002046 self.GetGerritHost(), self._GerritChangeIdentifier())
Aaron Gable6f5a8d92017-04-18 14:49:05 -07002047 except gerrit_util.GerritError as e:
2048 if e.http_status == 404:
Andrii Shyshkalove2633162018-08-27 23:50:31 +00002049 raise GerritChangeNotExists(self.GetIssue(), self.GetCodereviewServer())
Aaron Gable6f5a8d92017-04-18 14:49:05 -07002050 raise
agable32978d92016-11-01 12:55:02 -07002051 return data
2052
Karen Qian40c19422019-03-13 21:28:29 +00002053 def _IsCqConfigured(self):
2054 detail = self._GetChangeDetail(['LABELS'])
Andrii Shyshkalov8effa4d2020-01-21 13:23:36 +00002055 return u'Commit-Queue' in detail.get('labels', {})
Karen Qian40c19422019-03-13 21:28:29 +00002056
Saagar Sanghavi03b15132020-08-10 16:43:41 +00002057 def CMDLand(self, force, bypass_hooks, verbose, parallel, resultdb, realm):
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002058 if git_common.is_dirty_git_tree('land'):
2059 return 1
Karen Qian40c19422019-03-13 21:28:29 +00002060
tandriid60367b2016-06-22 05:25:12 -07002061 detail = self._GetChangeDetail(['CURRENT_REVISION', 'LABELS'])
Karen Qian40c19422019-03-13 21:28:29 +00002062 if not force and self._IsCqConfigured():
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +00002063 confirm_or_exit('\nIt seems this repository has a CQ, '
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002064 'which can test and land changes for you. '
2065 'Are you sure you wish to bypass it?\n',
2066 action='bypass CQ')
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002067 differs = True
tandriic4344b52016-08-29 06:04:54 -07002068 last_upload = self._GitGetBranchConfigValue('gerritsquashhash')
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002069 # Note: git diff outputs nothing if there is no diff.
2070 if not last_upload or RunGit(['diff', last_upload]).strip():
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002071 print('WARNING: Some changes from local branch haven\'t been uploaded.')
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002072 else:
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002073 if detail['current_revision'] == last_upload:
2074 differs = False
2075 else:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002076 print('WARNING: Local branch contents differ from latest uploaded '
2077 'patchset.')
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002078 if differs:
2079 if not force:
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002080 confirm_or_exit(
2081 'Do you want to submit latest Gerrit patchset and bypass hooks?\n',
2082 action='submit')
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002083 print('WARNING: Bypassing hooks and submitting latest uploaded patchset.')
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002084 elif not bypass_hooks:
Edward Lemur227d5102020-02-25 23:45:35 +00002085 upstream = self.GetCommonAncestorWithUpstream()
2086 if self.GetIssue():
2087 description = self.FetchDescription()
2088 else:
Edward Lemura12175c2020-03-09 16:58:26 +00002089 description = _create_description_from_log([upstream])
Edward Lemur227d5102020-02-25 23:45:35 +00002090 self.RunHook(
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002091 committing=True,
2092 may_prompt=not force,
2093 verbose=verbose,
Edward Lemur227d5102020-02-25 23:45:35 +00002094 parallel=parallel,
2095 upstream=upstream,
2096 description=description,
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00002097 all_files=False,
Saagar Sanghavi03b15132020-08-10 16:43:41 +00002098 resultdb=resultdb,
2099 realm=realm)
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002100
Xinan Lin1bd4ffa2021-07-28 00:54:22 +00002101 self.SubmitIssue()
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002102 print('Issue %s has been submitted.' % self.GetIssueURL())
agable32978d92016-11-01 12:55:02 -07002103 links = self._GetChangeCommit().get('web_links', [])
2104 for link in links:
Michael Mosse371c642021-09-29 16:41:04 +00002105 if link.get('name') in ['gitiles', 'browse'] and link.get('url'):
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002106 print('Landed as: %s' % link.get('url'))
agable32978d92016-11-01 12:55:02 -07002107 break
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002108 return 0
2109
Bruce Dawsonf362f6f2021-02-18 23:15:17 +00002110 def CMDPatchWithParsedIssue(self, parsed_issue_arg, nocommit, force,
2111 newbranch):
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002112 assert parsed_issue_arg.valid
2113
Edward Lemur125d60a2019-09-13 18:25:41 +00002114 self.issue = parsed_issue_arg.issue
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002115
2116 if parsed_issue_arg.hostname:
2117 self._gerrit_host = parsed_issue_arg.hostname
2118 self._gerrit_server = 'https://%s' % self._gerrit_host
2119
tandriic2405f52016-10-10 08:13:15 -07002120 try:
2121 detail = self._GetChangeDetail(['ALL_REVISIONS'])
Aaron Gablea45ee112016-11-22 15:14:38 -08002122 except GerritChangeNotExists as e:
tandriic2405f52016-10-10 08:13:15 -07002123 DieWithError(str(e))
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002124
2125 if not parsed_issue_arg.patchset:
2126 # Use current revision by default.
2127 revision_info = detail['revisions'][detail['current_revision']]
2128 patchset = int(revision_info['_number'])
2129 else:
2130 patchset = parsed_issue_arg.patchset
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00002131 for revision_info in detail['revisions'].values():
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002132 if int(revision_info['_number']) == parsed_issue_arg.patchset:
2133 break
2134 else:
Aaron Gablea45ee112016-11-22 15:14:38 -08002135 DieWithError('Couldn\'t find patchset %i in change %i' %
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002136 (parsed_issue_arg.patchset, self.GetIssue()))
2137
Edward Lemur125d60a2019-09-13 18:25:41 +00002138 remote_url = self.GetRemoteUrl()
Aaron Gable697a91b2018-01-19 15:20:15 -08002139 if remote_url.endswith('.git'):
2140 remote_url = remote_url[:-len('.git')]
erikchen0d14d0d2018-08-28 18:57:09 +00002141 remote_url = remote_url.rstrip('/')
2142
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002143 fetch_info = revision_info['fetch']['http']
erikchen0d14d0d2018-08-28 18:57:09 +00002144 fetch_info['url'] = fetch_info['url'].rstrip('/')
Aaron Gable697a91b2018-01-19 15:20:15 -08002145
2146 if remote_url != fetch_info['url']:
2147 DieWithError('Trying to patch a change from %s but this repo appears '
2148 'to be %s.' % (fetch_info['url'], remote_url))
2149
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002150 RunGit(['fetch', fetch_info['url'], fetch_info['ref']])
Aaron Gable9387b4f2017-06-08 10:50:03 -07002151
Bruce Dawsonf362f6f2021-02-18 23:15:17 +00002152 # If we have created a new branch then do the "set issue" immediately in
2153 # case the cherry-pick fails, which happens when resolving conflicts.
2154 if newbranch:
2155 self.SetIssue(parsed_issue_arg.issue)
2156
Aaron Gable62619a32017-06-16 08:22:09 -07002157 if force:
2158 RunGit(['reset', '--hard', 'FETCH_HEAD'])
2159 print('Checked out commit for change %i patchset %i locally' %
2160 (parsed_issue_arg.issue, patchset))
Stefan Zager2d5f0392017-10-10 15:17:53 -07002161 elif nocommit:
2162 RunGit(['cherry-pick', '--no-commit', 'FETCH_HEAD'])
2163 print('Patch applied to index.')
Aaron Gable62619a32017-06-16 08:22:09 -07002164 else:
Aaron Gable9387b4f2017-06-08 10:50:03 -07002165 RunGit(['cherry-pick', 'FETCH_HEAD'])
2166 print('Committed patch for change %i patchset %i locally.' %
Aaron Gable62619a32017-06-16 08:22:09 -07002167 (parsed_issue_arg.issue, patchset))
2168 print('Note: this created a local commit which does not have '
2169 'the same hash as the one uploaded for review. This will make '
2170 'uploading changes based on top of this branch difficult.\n'
2171 'If you want to do that, use "git cl patch --force" instead.')
2172
Stefan Zagerd08043c2017-10-12 12:07:02 -07002173 if self.GetBranch():
2174 self.SetIssue(parsed_issue_arg.issue)
2175 self.SetPatchset(patchset)
Edward Lesmes50da7702020-03-30 19:23:43 +00002176 fetched_hash = scm.GIT.ResolveCommit(settings.GetRoot(), 'FETCH_HEAD')
Stefan Zagerd08043c2017-10-12 12:07:02 -07002177 self._GitSetBranchConfigValue('last-upload-hash', fetched_hash)
2178 self._GitSetBranchConfigValue('gerritsquashhash', fetched_hash)
2179 else:
2180 print('WARNING: You are in detached HEAD state.\n'
2181 'The patch has been applied to your checkout, but you will not be '
2182 'able to upload a new patch set to the gerrit issue.\n'
2183 'Try using the \'-b\' option if you would like to work on a '
2184 'branch and/or upload a new patch set.')
2185
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002186 return 0
2187
tandrii16e0b4e2016-06-07 10:34:28 -07002188 def _GerritCommitMsgHookCheck(self, offer_removal):
2189 hook = os.path.join(settings.GetRoot(), '.git', 'hooks', 'commit-msg')
2190 if not os.path.exists(hook):
2191 return
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00002192 # Crude attempt to distinguish Gerrit Codereview hook from a potentially
2193 # custom developer-made one.
tandrii16e0b4e2016-06-07 10:34:28 -07002194 data = gclient_utils.FileRead(hook)
2195 if not('From Gerrit Code Review' in data and 'add_ChangeId()' in data):
2196 return
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002197 print('WARNING: You have Gerrit commit-msg hook installed.\n'
qyearsley12fa6ff2016-08-24 09:18:40 -07002198 'It is not necessary for uploading with git cl in squash mode, '
tandrii16e0b4e2016-06-07 10:34:28 -07002199 'and may interfere with it in subtle ways.\n'
2200 'We recommend you remove the commit-msg hook.')
2201 if offer_removal:
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002202 if ask_for_explicit_yes('Do you want to remove it now?'):
tandrii16e0b4e2016-06-07 10:34:28 -07002203 gclient_utils.rm_file_or_tree(hook)
2204 print('Gerrit commit-msg hook removed.')
2205 else:
2206 print('OK, will keep Gerrit commit-msg hook in place.')
2207
Edward Lemur1b52d872019-05-09 21:12:12 +00002208 def _CleanUpOldTraces(self):
2209 """Keep only the last |MAX_TRACES| traces."""
2210 try:
2211 traces = sorted([
2212 os.path.join(TRACES_DIR, f)
2213 for f in os.listdir(TRACES_DIR)
2214 if (os.path.isfile(os.path.join(TRACES_DIR, f))
2215 and not f.startswith('tmp'))
2216 ])
2217 traces_to_delete = traces[:-MAX_TRACES]
2218 for trace in traces_to_delete:
Daniel Chengcf6269b2019-05-18 01:02:12 +00002219 os.remove(trace)
Edward Lemur1b52d872019-05-09 21:12:12 +00002220 except OSError:
2221 print('WARNING: Failed to remove old git traces from\n'
2222 ' %s'
2223 'Consider removing them manually.' % TRACES_DIR)
Edward Lemurdc8e23d2019-05-07 00:45:48 +00002224
Edward Lemur5737f022019-05-17 01:24:00 +00002225 def _WriteGitPushTraces(self, trace_name, traces_dir, git_push_metadata):
Edward Lemur1b52d872019-05-09 21:12:12 +00002226 """Zip and write the git push traces stored in traces_dir."""
2227 gclient_utils.safe_makedirs(TRACES_DIR)
Edward Lemur1b52d872019-05-09 21:12:12 +00002228 traces_zip = trace_name + '-traces'
2229 traces_readme = trace_name + '-README'
Michael Mosse7f0b4c2019-05-08 04:36:24 +00002230 # Create a temporary dir to store git config and gitcookies in. It will be
2231 # compressed and stored next to the traces.
2232 git_info_dir = tempfile.mkdtemp()
Edward Lemur1b52d872019-05-09 21:12:12 +00002233 git_info_zip = trace_name + '-git-info'
2234
Josip Sokcevic5e18b602020-04-23 21:47:00 +00002235 git_push_metadata['now'] = datetime_now().strftime('%Y-%m-%dT%H:%M:%S.%f')
sangwoo.ko7a614332019-05-22 02:46:19 +00002236
Edward Lemur1b52d872019-05-09 21:12:12 +00002237 git_push_metadata['trace_name'] = trace_name
2238 gclient_utils.FileWrite(
2239 traces_readme, TRACES_README_FORMAT % git_push_metadata)
2240
2241 # Keep only the first 6 characters of the git hashes on the packet
2242 # trace. This greatly decreases size after compression.
2243 packet_traces = os.path.join(traces_dir, 'trace-packet')
2244 if os.path.isfile(packet_traces):
2245 contents = gclient_utils.FileRead(packet_traces)
2246 gclient_utils.FileWrite(
2247 packet_traces, GIT_HASH_RE.sub(r'\1', contents))
2248 shutil.make_archive(traces_zip, 'zip', traces_dir)
2249
2250 # Collect and compress the git config and gitcookies.
2251 git_config = RunGit(['config', '-l'])
2252 gclient_utils.FileWrite(
2253 os.path.join(git_info_dir, 'git-config'),
2254 git_config)
2255
2256 cookie_auth = gerrit_util.Authenticator.get()
2257 if isinstance(cookie_auth, gerrit_util.CookiesAuthenticator):
2258 gitcookies_path = cookie_auth.get_gitcookies_path()
2259 if os.path.isfile(gitcookies_path):
2260 gitcookies = gclient_utils.FileRead(gitcookies_path)
2261 gclient_utils.FileWrite(
2262 os.path.join(git_info_dir, 'gitcookies'),
2263 GITCOOKIES_REDACT_RE.sub('REDACTED', gitcookies))
2264 shutil.make_archive(git_info_zip, 'zip', git_info_dir)
2265
Edward Lemur1b52d872019-05-09 21:12:12 +00002266 gclient_utils.rmtree(git_info_dir)
2267
Josip Sokcevicf2cfd3d2021-03-30 18:39:18 +00002268 def _RunGitPushWithTraces(self,
2269 refspec,
2270 refspec_opts,
2271 git_push_metadata,
2272 git_push_options=None):
Edward Lemur1b52d872019-05-09 21:12:12 +00002273 """Run git push and collect the traces resulting from the execution."""
2274 # Create a temporary directory to store traces in. Traces will be compressed
2275 # and stored in a 'traces' dir inside depot_tools.
2276 traces_dir = tempfile.mkdtemp()
Edward Lemur5737f022019-05-17 01:24:00 +00002277 trace_name = os.path.join(
2278 TRACES_DIR, datetime_now().strftime('%Y%m%dT%H%M%S.%f'))
Edward Lemur0f58ae42019-04-30 17:24:12 +00002279
2280 env = os.environ.copy()
2281 env['GIT_REDACT_COOKIES'] = 'o,SSO,GSSO_Uberproxy'
2282 env['GIT_TR2_EVENT'] = os.path.join(traces_dir, 'tr2-event')
Jonathan Nieder9779b142019-05-29 23:19:29 +00002283 env['GIT_TRACE2_EVENT'] = os.path.join(traces_dir, 'tr2-event')
Edward Lemur0f58ae42019-04-30 17:24:12 +00002284 env['GIT_TRACE_CURL'] = os.path.join(traces_dir, 'trace-curl')
2285 env['GIT_TRACE_CURL_NO_DATA'] = '1'
2286 env['GIT_TRACE_PACKET'] = os.path.join(traces_dir, 'trace-packet')
2287
2288 try:
2289 push_returncode = 0
Edward Lemur1b52d872019-05-09 21:12:12 +00002290 remote_url = self.GetRemoteUrl()
Edward Lemur0f58ae42019-04-30 17:24:12 +00002291 before_push = time_time()
Josip Sokcevicf2cfd3d2021-03-30 18:39:18 +00002292 push_cmd = ['git', 'push', remote_url, refspec]
2293 if git_push_options:
2294 for opt in git_push_options:
2295 push_cmd.extend(['-o', opt])
2296
Edward Lemur0f58ae42019-04-30 17:24:12 +00002297 push_stdout = gclient_utils.CheckCallAndFilter(
Josip Sokcevicf2cfd3d2021-03-30 18:39:18 +00002298 push_cmd,
Edward Lemur0f58ae42019-04-30 17:24:12 +00002299 env=env,
2300 print_stdout=True,
2301 # Flush after every line: useful for seeing progress when running as
2302 # recipe.
2303 filter_fn=lambda _: sys.stdout.flush())
Edward Lemur79d4f992019-11-11 23:49:02 +00002304 push_stdout = push_stdout.decode('utf-8', 'replace')
Edward Lemur0f58ae42019-04-30 17:24:12 +00002305 except subprocess2.CalledProcessError as e:
2306 push_returncode = e.returncode
Josip Sokcevic740825e2021-05-12 18:28:34 +00002307 if 'blocked keyword' in str(e.stdout):
2308 raise GitPushError(
2309 'Failed to create a change, very likely due to blocked keyword. '
2310 'Please examine output above for the reason of the failure.\n'
2311 'If this is a false positive, you can try to bypass blocked '
2312 'keyword by using push option '
2313 '-o uploadvalidator~skip, e.g.:\n'
2314 'git cl upload -o uploadvalidator~skip\n\n'
2315 'If git-cl is not working correctly, file a bug under the '
2316 'Infra>SDK component.')
Josip Sokcevic54e30e72022-02-10 22:32:24 +00002317 if 'git push -o nokeycheck' in str(e.stdout):
2318 raise GitPushError(
2319 'Failed to create a change, very likely due to a private key being '
2320 'detected. Please examine output above for the reason of the '
2321 'failure.\n'
2322 'If this is a false positive, you can try to bypass private key '
2323 'detection by using push option '
2324 '-o nokeycheck, e.g.:\n'
2325 'git cl upload -o nokeycheck\n\n'
2326 'If git-cl is not working correctly, file a bug under the '
2327 'Infra>SDK component.')
Josip Sokcevic740825e2021-05-12 18:28:34 +00002328
Josip Sokcevicf736cab2020-10-20 23:41:38 +00002329 raise GitPushError(
2330 'Failed to create a change. Please examine output above for the '
2331 'reason of the failure.\n'
Josip Sokcevic7386a1e2021-02-12 19:00:34 +00002332 'For emergencies, Googlers can escalate to '
2333 'go/gob-support or go/notify#gob\n'
Josip Sokcevicf736cab2020-10-20 23:41:38 +00002334 'Hint: run command below to diagnose common Git/Gerrit '
2335 'credential problems:\n'
2336 ' git cl creds-check\n'
2337 '\n'
2338 'If git-cl is not working correctly, file a bug under the Infra>SDK '
2339 'component including the files below.\n'
2340 'Review the files before upload, since they might contain sensitive '
2341 'information.\n'
2342 'Set the Restrict-View-Google label so that they are not publicly '
2343 'accessible.\n' + TRACES_MESSAGE % {'trace_name': trace_name})
Edward Lemur0f58ae42019-04-30 17:24:12 +00002344 finally:
2345 execution_time = time_time() - before_push
2346 metrics.collector.add_repeated('sub_commands', {
2347 'command': 'git push',
2348 'execution_time': execution_time,
2349 'exit_code': push_returncode,
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +00002350 'arguments': metrics_utils.extract_known_subcommand_args(refspec_opts),
Edward Lemur0f58ae42019-04-30 17:24:12 +00002351 })
2352
Edward Lemur1b52d872019-05-09 21:12:12 +00002353 git_push_metadata['execution_time'] = execution_time
2354 git_push_metadata['exit_code'] = push_returncode
Edward Lemur5737f022019-05-17 01:24:00 +00002355 self._WriteGitPushTraces(trace_name, traces_dir, git_push_metadata)
Edward Lemur0f58ae42019-04-30 17:24:12 +00002356
Edward Lemur1b52d872019-05-09 21:12:12 +00002357 self._CleanUpOldTraces()
Edward Lemur0f58ae42019-04-30 17:24:12 +00002358 gclient_utils.rmtree(traces_dir)
2359
2360 return push_stdout
2361
Josip Sokcevicf736cab2020-10-20 23:41:38 +00002362 def CMDUploadChange(self, options, git_diff_args, custom_cl_base,
2363 change_desc):
2364 """Upload the current branch to Gerrit, retry if new remote HEAD is
2365 found. options and change_desc may be mutated."""
Josip Sokcevicb631a882021-01-06 18:18:10 +00002366 remote, remote_branch = self.GetRemoteBranch()
2367 branch = GetTargetRef(remote, remote_branch, options.target_branch)
2368
Josip Sokcevicf736cab2020-10-20 23:41:38 +00002369 try:
2370 return self._CMDUploadChange(options, git_diff_args, custom_cl_base,
Josip Sokcevicb631a882021-01-06 18:18:10 +00002371 change_desc, branch)
Josip Sokcevicf736cab2020-10-20 23:41:38 +00002372 except GitPushError as e:
Josip Sokcevicb631a882021-01-06 18:18:10 +00002373 # Repository might be in the middle of transition to main branch as
2374 # default, and uploads to old default might be blocked.
2375 if remote_branch not in [DEFAULT_OLD_BRANCH, DEFAULT_NEW_BRANCH]:
Josip Sokcevicf736cab2020-10-20 23:41:38 +00002376 DieWithError(str(e), change_desc)
2377
Josip Sokcevicb631a882021-01-06 18:18:10 +00002378 project_head = gerrit_util.GetProjectHead(self._gerrit_host,
2379 self.GetGerritProject())
2380 if project_head == branch:
2381 DieWithError(str(e), change_desc)
2382 branch = project_head
2383
2384 print("WARNING: Fetching remote state and retrying upload to default "
2385 "branch...")
2386 RunGit(['fetch', '--prune', remote])
Josip Sokcevicf736cab2020-10-20 23:41:38 +00002387 options.edit_description = False
2388 options.force = True
2389 try:
Josip Sokcevicb631a882021-01-06 18:18:10 +00002390 self._CMDUploadChange(options, git_diff_args, custom_cl_base,
2391 change_desc, branch)
Josip Sokcevicf736cab2020-10-20 23:41:38 +00002392 except GitPushError as e:
2393 DieWithError(str(e), change_desc)
2394
2395 def _CMDUploadChange(self, options, git_diff_args, custom_cl_base,
Josip Sokcevicb631a882021-01-06 18:18:10 +00002396 change_desc, branch):
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002397 """Upload the current branch to Gerrit."""
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002398 if options.squash:
tandrii16e0b4e2016-06-07 10:34:28 -07002399 self._GerritCommitMsgHookCheck(offer_removal=not options.force)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002400 if self.GetIssue():
Josipe827b0f2020-01-30 00:07:20 +00002401 # User requested to change description
2402 if options.edit_description:
Josipe827b0f2020-01-30 00:07:20 +00002403 change_desc.prompt()
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002404 change_id = self._GetChangeDetail()['change_id']
Edward Lemur5a644f82020-03-18 16:44:57 +00002405 change_desc.ensure_change_id(change_id)
Aaron Gableb56ad332017-01-06 15:24:31 -08002406 else: # if not self.GetIssue()
Gavin Mak68e6cf32021-01-25 18:24:08 +00002407 if not options.force and not options.message_file:
Anthony Polito8b955342019-09-24 19:01:36 +00002408 change_desc.prompt()
Andrii Shyshkalov8c90d032017-04-19 21:27:26 +02002409 change_ids = git_footers.get_footer_change_id(change_desc.description)
Edward Lemur5a644f82020-03-18 16:44:57 +00002410 if len(change_ids) == 1:
2411 change_id = change_ids[0]
2412 else:
2413 change_id = GenerateGerritChangeId(change_desc.description)
2414 change_desc.ensure_change_id(change_id)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002415
Andrii Shyshkalov71f0da32019-07-15 22:45:18 +00002416 if options.preserve_tryjobs:
2417 change_desc.set_preserve_tryjobs()
Robert Iannuccidb02dd02017-04-19 12:18:20 -07002418
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002419 remote, upstream_branch = self.FetchUpstreamTuple(self.GetBranch())
Edward Lemur5a644f82020-03-18 16:44:57 +00002420 parent = self._ComputeParent(
2421 remote, upstream_branch, custom_cl_base, options.force, change_desc)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002422 tree = RunGit(['rev-parse', 'HEAD:']).strip()
Edward Lemur1773f372020-02-22 00:27:14 +00002423 with gclient_utils.temporary_file() as desc_tempfile:
2424 gclient_utils.FileWrite(desc_tempfile, change_desc.description)
2425 ref_to_push = RunGit(
2426 ['commit-tree', tree, '-p', parent, '-F', desc_tempfile]).strip()
Anthony Polito8b955342019-09-24 19:01:36 +00002427 else: # if not options.squash
Gregory Nisbet48d9e1e2021-04-15 23:35:54 +00002428 if options.no_add_changeid:
2429 pass
2430 else: # adding Change-Ids is okay.
2431 if not git_footers.get_footer_change_id(change_desc.description):
2432 DownloadGerritHook(False)
2433 change_desc.set_description(
2434 self._AddChangeIdToCommitMessage(change_desc.description,
2435 git_diff_args))
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002436 ref_to_push = 'HEAD'
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002437 # For no-squash mode, we assume the remote called "origin" is the one we
2438 # want. It is not worthwhile to support different workflows for
2439 # no-squash mode.
2440 parent = 'origin/%s' % branch
Gregory Nisbet48d9e1e2021-04-15 23:35:54 +00002441 # attempt to extract the changeid from the current description
2442 # fail informatively if not possible.
2443 change_id_candidates = git_footers.get_footer_change_id(
2444 change_desc.description)
2445 if not change_id_candidates:
2446 DieWithError("Unable to extract change-id from message.")
2447 change_id = change_id_candidates[0]
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002448
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +00002449 SaveDescriptionBackup(change_desc)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002450 commits = RunGitSilent(['rev-list', '%s..%s' % (parent,
2451 ref_to_push)]).splitlines()
2452 if len(commits) > 1:
2453 print('WARNING: This will upload %d commits. Run the following command '
2454 'to see which commits will be uploaded: ' % len(commits))
2455 print('git log %s..%s' % (parent, ref_to_push))
2456 print('You can also use `git squash-branch` to squash these into a '
2457 'single commit.')
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002458 confirm_or_exit(action='upload')
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002459
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00002460 reviewers = sorted(change_desc.get_reviewers())
Edward Lemur4508b422019-10-03 21:56:35 +00002461 cc = []
2462 # Add CCs from WATCHLISTS and rietveld.cc git config unless this is
2463 # the initial upload, the CL is private, or auto-CCing has ben disabled.
2464 if not (self.GetIssue() or options.private or options.no_autocc):
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00002465 cc = self.GetCCList().split(',')
Gavin Makb1c08f62021-04-01 18:05:58 +00002466 if len(cc) > 100:
2467 lsc = ('https://chromium.googlesource.com/chromium/src/+/HEAD/docs/'
2468 'process/lsc/lsc_workflow.md')
2469 print('WARNING: This will auto-CC %s users.' % len(cc))
2470 print('LSC may be more appropriate: %s' % lsc)
2471 print('You can also use the --no-autocc flag to disable auto-CC.')
2472 confirm_or_exit(action='continue')
Edward Lemur4508b422019-10-03 21:56:35 +00002473 # Add cc's from the --cc flag.
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00002474 if options.cc:
2475 cc.extend(options.cc)
Edward Lemur79d4f992019-11-11 23:49:02 +00002476 cc = [email.strip() for email in cc if email.strip()]
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00002477 if change_desc.get_cced():
2478 cc.extend(change_desc.get_cced())
Edward Lesmeseeca9c62020-11-20 00:00:17 +00002479 if self.GetGerritHost() == 'chromium-review.googlesource.com':
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00002480 valid_accounts = set(reviewers + cc)
2481 # TODO(crbug/877717): relax this for all hosts.
2482 else:
2483 valid_accounts = gerrit_util.ValidAccounts(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00002484 self.GetGerritHost(), reviewers + cc)
Andrii Shyshkalovf170af42018-10-30 07:00:44 +00002485 logging.info('accounts %s are recognized, %s invalid',
2486 sorted(valid_accounts),
2487 set(reviewers + cc).difference(set(valid_accounts)))
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00002488
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00002489 # Extra options that can be specified at push time. Doc:
2490 # https://gerrit-review.googlesource.com/Documentation/user-upload.html
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +00002491 refspec_opts = []
Andrii Shyshkalov2d8a2072017-04-10 15:02:18 +02002492
Aaron Gable844cf292017-06-28 11:32:59 -07002493 # By default, new changes are started in WIP mode, and subsequent patchsets
2494 # don't send email. At any time, passing --send-mail will mark the change
2495 # ready and send email for that particular patch.
Aaron Gableafd52772017-06-27 16:40:10 -07002496 if options.send_mail:
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +00002497 refspec_opts.append('ready')
2498 refspec_opts.append('notify=ALL')
Jamie Madill276da0b2018-04-27 14:41:20 -04002499 elif not self.GetIssue() and options.squash:
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +00002500 refspec_opts.append('wip')
Aaron Gableafd52772017-06-27 16:40:10 -07002501 else:
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +00002502 refspec_opts.append('notify=NONE')
Aaron Gable70f4e242017-06-26 10:45:59 -07002503
Andrii Shyshkalov2d8a2072017-04-10 15:02:18 +02002504 # TODO(tandrii): options.message should be posted as a comment
Aaron Gablee5adf612017-07-14 10:43:58 -07002505 # if --send-mail is set on non-initial upload as Rietveld used to do it.
Andrii Shyshkalov2d8a2072017-04-10 15:02:18 +02002506
Josip Sokcevicf736cab2020-10-20 23:41:38 +00002507 # Set options.title in case user was prompted in _GetTitleForUpload and
2508 # _CMDUploadChange needs to be called again.
2509 options.title = self._GetTitleForUpload(options)
2510 if options.title:
Nick Carter8692b182017-11-06 16:30:38 -08002511 # Punctuation and whitespace in |title| must be percent-encoded.
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +00002512 refspec_opts.append(
Josip Sokcevicf736cab2020-10-20 23:41:38 +00002513 'm=' + gerrit_util.PercentEncodeForGitRef(options.title))
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00002514
agablec6787972016-09-09 16:13:34 -07002515 if options.private:
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +00002516 refspec_opts.append('private')
agablec6787972016-09-09 16:13:34 -07002517
Andrii Shyshkalov2f727912018-10-15 17:02:33 +00002518 for r in sorted(reviewers):
2519 if r in valid_accounts:
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +00002520 refspec_opts.append('r=%s' % r)
Andrii Shyshkalov2f727912018-10-15 17:02:33 +00002521 reviewers.remove(r)
2522 else:
2523 # TODO(tandrii): this should probably be a hard failure.
2524 print('WARNING: reviewer %s doesn\'t have a Gerrit account, skipping'
2525 % r)
2526 for c in sorted(cc):
2527 # refspec option will be rejected if cc doesn't correspond to an
2528 # account, even though REST call to add such arbitrary cc may succeed.
2529 if c in valid_accounts:
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +00002530 refspec_opts.append('cc=%s' % c)
Andrii Shyshkalov2f727912018-10-15 17:02:33 +00002531 cc.remove(c)
2532
rmistry9eadede2016-09-19 11:22:43 -07002533 if options.topic:
2534 # Documentation on Gerrit topics is here:
2535 # https://gerrit-review.googlesource.com/Documentation/user-upload.html#topic
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +00002536 refspec_opts.append('topic=%s' % options.topic)
rmistry9eadede2016-09-19 11:22:43 -07002537
Edward Lemur687ca902018-12-05 02:30:30 +00002538 if options.enable_auto_submit:
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +00002539 refspec_opts.append('l=Auto-Submit+1')
Edward Lesmes10c3dd62021-02-08 21:13:57 +00002540 if options.set_bot_commit:
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +00002541 refspec_opts.append('l=Bot-Commit+1')
Edward Lemur687ca902018-12-05 02:30:30 +00002542 if options.use_commit_queue:
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +00002543 refspec_opts.append('l=Commit-Queue+2')
Edward Lemur687ca902018-12-05 02:30:30 +00002544 elif options.cq_dry_run:
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +00002545 refspec_opts.append('l=Commit-Queue+1')
Greg Gutermanbe5fccd2021-06-14 17:58:20 +00002546 elif options.cq_quick_run:
2547 refspec_opts.append('l=Commit-Queue+1')
2548 refspec_opts.append('l=Quick-Run+1')
Edward Lemur687ca902018-12-05 02:30:30 +00002549
2550 if change_desc.get_reviewers(tbr_only=True):
2551 score = gerrit_util.GetCodeReviewTbrScore(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00002552 self.GetGerritHost(),
2553 self.GetGerritProject())
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +00002554 refspec_opts.append('l=Code-Review+%s' % score)
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00002555
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08002556 # Gerrit sorts hashtags, so order is not important.
Nodir Turakulov23b82142017-11-16 11:04:25 -08002557 hashtags = {change_desc.sanitize_hash_tag(t) for t in options.hashtags}
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08002558 if not self.GetIssue():
Nodir Turakulov23b82142017-11-16 11:04:25 -08002559 hashtags.update(change_desc.get_hash_tags())
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +00002560 refspec_opts += ['hashtag=%s' % t for t in sorted(hashtags)]
2561
2562 refspec_suffix = ''
2563 if refspec_opts:
2564 refspec_suffix = '%' + ','.join(refspec_opts)
2565 assert ' ' not in refspec_suffix, (
2566 'spaces not allowed in refspec: "%s"' % refspec_suffix)
2567 refspec = '%s:refs/for/%s%s' % (ref_to_push, branch, refspec_suffix)
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00002568
Edward Lemur1b52d872019-05-09 21:12:12 +00002569 git_push_metadata = {
Edward Lesmeseeca9c62020-11-20 00:00:17 +00002570 'gerrit_host': self.GetGerritHost(),
Josip Sokcevicf736cab2020-10-20 23:41:38 +00002571 'title': options.title or '<untitled>',
Edward Lemur1b52d872019-05-09 21:12:12 +00002572 'change_id': change_id,
2573 'description': change_desc.description,
2574 }
Josip Sokcevicf2cfd3d2021-03-30 18:39:18 +00002575
Josip Sokcevicd0ba91f2021-03-29 20:12:09 +00002576 push_stdout = self._RunGitPushWithTraces(refspec, refspec_opts,
Josip Sokcevicf2cfd3d2021-03-30 18:39:18 +00002577 git_push_metadata,
2578 options.push_options)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002579
2580 if options.squash:
Aaron Gable289b4312017-09-13 14:06:16 -07002581 regex = re.compile(r'remote:\s+https?://[\w\-\.\+\/#]*/(\d+)\s.*')
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002582 change_numbers = [m.group(1)
2583 for m in map(regex.match, push_stdout.splitlines())
2584 if m]
2585 if len(change_numbers) != 1:
2586 DieWithError(
2587 ('Created|Updated %d issues on Gerrit, but only 1 expected.\n'
Christopher Lamf732cd52017-01-24 12:40:11 +11002588 'Change-Id: %s') % (len(change_numbers), change_id), change_desc)
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002589 self.SetIssue(change_numbers[0])
tandrii5d48c322016-08-18 16:19:37 -07002590 self._GitSetBranchConfigValue('gerritsquashhash', ref_to_push)
tandrii88189772016-09-29 04:29:57 -07002591
Andrii Shyshkalov2f727912018-10-15 17:02:33 +00002592 if self.GetIssue() and (reviewers or cc):
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00002593 # GetIssue() is not set in case of non-squash uploads according to tests.
Aaron Gable6e7ddb62020-05-27 22:23:29 +00002594 # TODO(crbug.com/751901): non-squash uploads in git cl should be removed.
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00002595 gerrit_util.AddReviewers(
Edward Lesmeseeca9c62020-11-20 00:00:17 +00002596 self.GetGerritHost(),
Andrii Shyshkalovd06cc782018-08-23 17:24:19 +00002597 self._GerritChangeIdentifier(),
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00002598 reviewers, cc,
2599 notify=bool(options.send_mail))
Aaron Gable6dadfbf2017-05-09 14:27:58 -07002600
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002601 return 0
2602
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002603 def _ComputeParent(self, remote, upstream_branch, custom_cl_base, force,
2604 change_desc):
2605 """Computes parent of the generated commit to be uploaded to Gerrit.
2606
2607 Returns revision or a ref name.
2608 """
2609 if custom_cl_base:
2610 # Try to avoid creating additional unintended CLs when uploading, unless
2611 # user wants to take this risk.
2612 local_ref_of_target_remote = self.GetRemoteBranch()[1]
2613 code, _ = RunGitWithCode(['merge-base', '--is-ancestor', custom_cl_base,
2614 local_ref_of_target_remote])
2615 if code == 1:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002616 print('\nWARNING: Manually specified base of this CL `%s` '
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002617 'doesn\'t seem to belong to target remote branch `%s`.\n\n'
2618 'If you proceed with upload, more than 1 CL may be created by '
2619 'Gerrit as a result, in turn confusing or crashing git cl.\n\n'
2620 'If you are certain that specified base `%s` has already been '
2621 'uploaded to Gerrit as another CL, you may proceed.\n' %
2622 (custom_cl_base, local_ref_of_target_remote, custom_cl_base))
2623 if not force:
2624 confirm_or_exit(
2625 'Do you take responsibility for cleaning up potential mess '
2626 'resulting from proceeding with upload?',
2627 action='upload')
2628 return custom_cl_base
2629
Aaron Gablef97e33d2017-03-30 15:44:27 -07002630 if remote != '.':
2631 return self.GetCommonAncestorWithUpstream()
2632
2633 # If our upstream branch is local, we base our squashed commit on its
2634 # squashed version.
2635 upstream_branch_name = scm.GIT.ShortBranchName(upstream_branch)
2636
Aaron Gablef97e33d2017-03-30 15:44:27 -07002637 if upstream_branch_name == 'master':
Aaron Gable0bbd1c22017-05-08 14:37:08 -07002638 return self.GetCommonAncestorWithUpstream()
Glen Robertson7d98e222020-08-27 17:53:11 +00002639 if upstream_branch_name == 'main':
2640 return self.GetCommonAncestorWithUpstream()
Aaron Gablef97e33d2017-03-30 15:44:27 -07002641
2642 # Check the squashed hash of the parent.
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02002643 # TODO(tandrii): consider checking parent change in Gerrit and using its
2644 # hash if tree hash of latest parent revision (patchset) in Gerrit matches
2645 # the tree hash of the parent branch. The upside is less likely bogus
2646 # requests to reupload parent change just because it's uploadhash is
2647 # missing, yet the downside likely exists, too (albeit unknown to me yet).
Edward Lesmesa680c232020-03-31 18:26:44 +00002648 parent = scm.GIT.GetBranchConfig(
2649 settings.GetRoot(), upstream_branch_name, 'gerritsquashhash')
Aaron Gablef97e33d2017-03-30 15:44:27 -07002650 # Verify that the upstream branch has been uploaded too, otherwise
2651 # Gerrit will create additional CLs when uploading.
2652 if not parent or (RunGitSilent(['rev-parse', upstream_branch + ':']) !=
2653 RunGitSilent(['rev-parse', parent + ':'])):
2654 DieWithError(
2655 '\nUpload upstream branch %s first.\n'
2656 'It is likely that this branch has been rebased since its last '
2657 'upload, so you just need to upload it again.\n'
2658 '(If you uploaded it with --no-squash, then branch dependencies '
2659 'are not supported, and you should reupload with --squash.)'
2660 % upstream_branch_name,
2661 change_desc)
2662 return parent
2663
Edward Lemura12175c2020-03-09 16:58:26 +00002664 def _AddChangeIdToCommitMessage(self, log_desc, args):
tandrii@chromium.org8930b3d2016-04-13 14:47:02 +00002665 """Re-commits using the current message, assumes the commit hook is in
2666 place.
2667 """
Edward Lemura12175c2020-03-09 16:58:26 +00002668 RunGit(['commit', '--amend', '-m', log_desc])
Andrii Shyshkalovb07575f2018-10-16 06:16:21 +00002669 new_log_desc = _create_description_from_log(args)
tandrii@chromium.org8930b3d2016-04-13 14:47:02 +00002670 if git_footers.get_footer_change_id(new_log_desc):
vapiera7fbd5a2016-06-16 09:17:49 -07002671 print('git-cl: Added Change-Id to commit message.')
tandrii@chromium.org8930b3d2016-04-13 14:47:02 +00002672 return new_log_desc
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +00002673
2674 DieWithError('ERROR: Gerrit commit-msg hook not installed.')
tandrii@chromium.orgaa6235b2016-04-11 21:35:29 +00002675
tandriie113dfd2016-10-11 10:20:12 -07002676 def CannotTriggerTryJobReason(self):
tandrii8c5a3532016-11-04 07:52:02 -07002677 try:
2678 data = self._GetChangeDetail()
Aaron Gablea45ee112016-11-22 15:14:38 -08002679 except GerritChangeNotExists:
2680 return 'Gerrit doesn\'t know about your change %s' % self.GetIssue()
tandrii8c5a3532016-11-04 07:52:02 -07002681
2682 if data['status'] in ('ABANDONED', 'MERGED'):
2683 return 'CL %s is closed' % self.GetIssue()
2684
Edward Lemurd4d1ba42019-09-20 21:46:37 +00002685 def GetGerritChange(self, patchset=None):
2686 """Returns a buildbucket.v2.GerritChange message for the current issue."""
Edward Lemur79d4f992019-11-11 23:49:02 +00002687 host = urllib.parse.urlparse(self.GetCodereviewServer()).hostname
Edward Lemurd4d1ba42019-09-20 21:46:37 +00002688 issue = self.GetIssue()
Edward Lemur2c210a42019-09-16 23:58:35 +00002689 patchset = int(patchset or self.GetPatchset())
Edward Lemurd4d1ba42019-09-20 21:46:37 +00002690 data = self._GetChangeDetail(['ALL_REVISIONS'])
2691
2692 assert host and issue and patchset, 'CL must be uploaded first'
2693
2694 has_patchset = any(
2695 int(revision_data['_number']) == patchset
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00002696 for revision_data in data['revisions'].values())
Edward Lemurd4d1ba42019-09-20 21:46:37 +00002697 if not has_patchset:
Aaron Gablea45ee112016-11-22 15:14:38 -08002698 raise Exception('Patchset %d is not known in Gerrit change %d' %
tandrii8c5a3532016-11-04 07:52:02 -07002699 (patchset, self.GetIssue()))
Edward Lemurd4d1ba42019-09-20 21:46:37 +00002700
tandrii8c5a3532016-11-04 07:52:02 -07002701 return {
Edward Lemurd4d1ba42019-09-20 21:46:37 +00002702 'host': host,
2703 'change': issue,
2704 'project': data['project'],
2705 'patchset': patchset,
tandrii8c5a3532016-11-04 07:52:02 -07002706 }
tandriie113dfd2016-10-11 10:20:12 -07002707
tandriide281ae2016-10-12 06:02:30 -07002708 def GetIssueOwner(self):
tandrii8c5a3532016-11-04 07:52:02 -07002709 return self._GetChangeDetail(['DETAILED_ACCOUNTS'])['owner']['email']
tandriide281ae2016-10-12 06:02:30 -07002710
Edward Lemur707d70b2018-02-07 00:50:14 +01002711 def GetReviewers(self):
2712 details = self._GetChangeDetail(['DETAILED_ACCOUNTS'])
Mohamed Heikal171c0742018-11-09 20:38:51 +00002713 return [r['email'] for r in details['reviewers'].get('REVIEWER', [])]
Edward Lemur707d70b2018-02-07 00:50:14 +01002714
tandrii@chromium.orgd68b62b2016-03-31 16:09:29 +00002715
Lei Zhang8a0efc12020-08-05 19:58:45 +00002716def _get_bug_line_values(default_project_prefix, bugs):
2717 """Given default_project_prefix and comma separated list of bugs, yields bug
2718 line values.
tandriif9aefb72016-07-01 09:06:51 -07002719
2720 Each bug can be either:
Lei Zhang8a0efc12020-08-05 19:58:45 +00002721 * a number, which is combined with default_project_prefix
tandriif9aefb72016-07-01 09:06:51 -07002722 * string, which is left as is.
2723
2724 This function may produce more than one line, because bugdroid expects one
2725 project per line.
2726
Lei Zhang8a0efc12020-08-05 19:58:45 +00002727 >>> list(_get_bug_line_values('v8:', '123,chromium:789'))
tandriif9aefb72016-07-01 09:06:51 -07002728 ['v8:123', 'chromium:789']
2729 """
2730 default_bugs = []
2731 others = []
2732 for bug in bugs.split(','):
2733 bug = bug.strip()
2734 if bug:
2735 try:
2736 default_bugs.append(int(bug))
2737 except ValueError:
2738 others.append(bug)
2739
2740 if default_bugs:
2741 default_bugs = ','.join(map(str, default_bugs))
Lei Zhang8a0efc12020-08-05 19:58:45 +00002742 if default_project_prefix:
2743 if not default_project_prefix.endswith(':'):
2744 default_project_prefix += ':'
2745 yield '%s%s' % (default_project_prefix, default_bugs)
tandriif9aefb72016-07-01 09:06:51 -07002746 else:
2747 yield default_bugs
2748 for other in sorted(others):
2749 # Don't bother finding common prefixes, CLs with >2 bugs are very very rare.
2750 yield other
2751
2752
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00002753class ChangeDescription(object):
2754 """Contains a parsed form of the change description."""
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00002755 R_LINE = r'^[ \t]*(TBR|R)[ \t]*=[ \t]*(.*?)[ \t]*$'
bradnelsond975b302016-10-23 12:20:23 -07002756 CC_LINE = r'^[ \t]*(CC)[ \t]*=[ \t]*(.*?)[ \t]*$'
Aaron Gable3a16ed12017-03-23 10:51:55 -07002757 BUG_LINE = r'^[ \t]*(?:(BUG)[ \t]*=|Bug:)[ \t]*(.*?)[ \t]*$'
Dan Beamd8b04ca2019-10-10 21:23:26 +00002758 FIXED_LINE = r'^[ \t]*Fixed[ \t]*:[ \t]*(.*?)[ \t]*$'
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +01002759 CHERRY_PICK_LINE = r'^\(cherry picked from commit [a-fA-F0-9]{40}\)$'
Nodir Turakulov23b82142017-11-16 11:04:25 -08002760 STRIP_HASH_TAG_PREFIX = r'^(\s*(revert|reland)( "|:)?\s*)*'
2761 BRACKET_HASH_TAG = r'\s*\[([^\[\]]+)\]'
Anthony Polito02b5af32019-12-02 19:49:47 +00002762 COLON_SEPARATED_HASH_TAG = r'^([a-zA-Z0-9_\- ]+):($|[^:])'
Nodir Turakulov23b82142017-11-16 11:04:25 -08002763 BAD_HASH_TAG_CHUNK = r'[^a-zA-Z0-9]+'
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00002764
Dan Beamd8b04ca2019-10-10 21:23:26 +00002765 def __init__(self, description, bug=None, fixed=None):
agable@chromium.org42c20792013-09-12 17:34:49 +00002766 self._description_lines = (description or '').strip().splitlines()
Anthony Polito8b955342019-09-24 19:01:36 +00002767 if bug:
2768 regexp = re.compile(self.BUG_LINE)
2769 prefix = settings.GetBugPrefix()
2770 if not any((regexp.match(line) for line in self._description_lines)):
2771 values = list(_get_bug_line_values(prefix, bug))
2772 self.append_footer('Bug: %s' % ', '.join(values))
Dan Beamd8b04ca2019-10-10 21:23:26 +00002773 if fixed:
2774 regexp = re.compile(self.FIXED_LINE)
2775 prefix = settings.GetBugPrefix()
2776 if not any((regexp.match(line) for line in self._description_lines)):
2777 values = list(_get_bug_line_values(prefix, fixed))
2778 self.append_footer('Fixed: %s' % ', '.join(values))
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002779
agable@chromium.org42c20792013-09-12 17:34:49 +00002780 @property # www.logilab.org/ticket/89786
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -08002781 def description(self): # pylint: disable=method-hidden
agable@chromium.org42c20792013-09-12 17:34:49 +00002782 return '\n'.join(self._description_lines)
2783
2784 def set_description(self, desc):
2785 if isinstance(desc, basestring):
2786 lines = desc.splitlines()
2787 else:
2788 lines = [line.rstrip() for line in desc]
2789 while lines and not lines[0]:
2790 lines.pop(0)
2791 while lines and not lines[-1]:
2792 lines.pop(-1)
2793 self._description_lines = lines
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002794
Edward Lemur5a644f82020-03-18 16:44:57 +00002795 def ensure_change_id(self, change_id):
2796 description = self.description
2797 footer_change_ids = git_footers.get_footer_change_id(description)
2798 # Make sure that the Change-Id in the description matches the given one.
2799 if footer_change_ids != [change_id]:
2800 if footer_change_ids:
2801 # Remove any existing Change-Id footers since they don't match the
2802 # expected change_id footer.
2803 description = git_footers.remove_footer(description, 'Change-Id')
2804 print('WARNING: Change-Id has been set to %s. Use `git cl issue 0` '
2805 'if you want to set a new one.')
2806 # Add the expected Change-Id footer.
2807 description = git_footers.add_footer_change_id(description, change_id)
2808 self.set_description(description)
2809
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00002810 def update_reviewers(self, reviewers, tbrs):
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002811 """Rewrites the R=/TBR= line(s) as a single line each.
2812
2813 Args:
2814 reviewers (list(str)) - list of additional emails to use for reviewers.
2815 tbrs (list(str)) - list of additional emails to use for TBRs.
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002816 """
Edward Lesmes8c43c3f2021-01-20 00:20:26 +00002817 if not reviewers and not tbrs:
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002818 return
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002819
2820 reviewers = set(reviewers)
2821 tbrs = set(tbrs)
2822 LOOKUP = {
2823 'TBR': tbrs,
2824 'R': reviewers,
2825 }
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002826
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002827 # Get the set of R= and TBR= lines and remove them from the description.
agable@chromium.org42c20792013-09-12 17:34:49 +00002828 regexp = re.compile(self.R_LINE)
2829 matches = [regexp.match(line) for line in self._description_lines]
2830 new_desc = [l for i, l in enumerate(self._description_lines)
2831 if not matches[i]]
2832 self.set_description(new_desc)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002833
agable@chromium.org42c20792013-09-12 17:34:49 +00002834 # Construct new unified R= and TBR= lines.
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002835
2836 # First, update tbrs/reviewers with names from the R=/TBR= lines (if any).
agable@chromium.org42c20792013-09-12 17:34:49 +00002837 for match in matches:
2838 if not match:
2839 continue
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002840 LOOKUP[match.group(1)].update(cleanup_list([match.group(2).strip()]))
2841
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002842 # If any folks ended up in both groups, remove them from tbrs.
2843 tbrs -= reviewers
Robert Iannuccif2708bd2017-04-17 15:49:02 -07002844
Robert Iannucci6c98dc62017-04-18 11:38:00 -07002845 new_r_line = 'R=' + ', '.join(sorted(reviewers)) if reviewers else None
2846 new_tbr_line = 'TBR=' + ', '.join(sorted(tbrs)) if tbrs else None
agable@chromium.org42c20792013-09-12 17:34:49 +00002847
2848 # Put the new lines in the description where the old first R= line was.
2849 line_loc = next((i for i, match in enumerate(matches) if match), -1)
2850 if 0 <= line_loc < len(self._description_lines):
2851 if new_tbr_line:
2852 self._description_lines.insert(line_loc, new_tbr_line)
2853 if new_r_line:
2854 self._description_lines.insert(line_loc, new_r_line)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002855 else:
agable@chromium.org42c20792013-09-12 17:34:49 +00002856 if new_r_line:
2857 self.append_footer(new_r_line)
2858 if new_tbr_line:
2859 self.append_footer(new_tbr_line)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002860
Andrii Shyshkalov71f0da32019-07-15 22:45:18 +00002861 def set_preserve_tryjobs(self):
2862 """Ensures description footer contains 'Cq-Do-Not-Cancel-Tryjobs: true'."""
2863 footers = git_footers.parse_footers(self.description)
2864 for v in footers.get('Cq-Do-Not-Cancel-Tryjobs', []):
2865 if v.lower() == 'true':
2866 return
2867 self.append_footer('Cq-Do-Not-Cancel-Tryjobs: true')
2868
Anthony Polito8b955342019-09-24 19:01:36 +00002869 def prompt(self):
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002870 """Asks the user to update the description."""
agable@chromium.org42c20792013-09-12 17:34:49 +00002871 self.set_description([
2872 '# Enter a description of the change.',
2873 '# This will be displayed on the codereview site.',
2874 '# The first line will also be used as the subject of the review.',
alancutter@chromium.orgbd1073e2013-06-01 00:34:38 +00002875 '#--------------------This line is 72 characters long'
agable@chromium.org42c20792013-09-12 17:34:49 +00002876 '--------------------',
2877 ] + self._description_lines)
Dan Beamd8b04ca2019-10-10 21:23:26 +00002878 bug_regexp = re.compile(self.BUG_LINE)
2879 fixed_regexp = re.compile(self.FIXED_LINE)
Jonas Termansend0f79112019-03-22 15:28:26 +00002880 prefix = settings.GetBugPrefix()
Sigurd Schneider8630bb12020-11-11 14:02:49 +00002881 has_issue = lambda l: bug_regexp.match(l) or fixed_regexp.match(l)
Sigurd Schneider9abde8c2020-11-17 08:44:52 +00002882
Dan Beamd8b04ca2019-10-10 21:23:26 +00002883 if not any((has_issue(line) for line in self._description_lines)):
Anthony Polito8b955342019-09-24 19:01:36 +00002884 self.append_footer('Bug: %s' % prefix)
tandriif9aefb72016-07-01 09:06:51 -07002885
Bruce Dawsonfc487042020-10-27 19:11:37 +00002886 print('Waiting for editor...')
agable@chromium.org42c20792013-09-12 17:34:49 +00002887 content = gclient_utils.RunEditor(self.description, True,
Edward Lemur79d4f992019-11-11 23:49:02 +00002888 git_editor=settings.GetGitEditor())
maruel@chromium.org0e0436a2011-10-25 13:32:41 +00002889 if not content:
2890 DieWithError('Running editor failed')
agable@chromium.org42c20792013-09-12 17:34:49 +00002891 lines = content.splitlines()
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002892
Bruce Dawson2377b012018-01-11 16:46:49 -08002893 # Strip off comments and default inserted "Bug:" line.
2894 clean_lines = [line.rstrip() for line in lines if not
Jonas Termansend0f79112019-03-22 15:28:26 +00002895 (line.startswith('#') or
2896 line.rstrip() == "Bug:" or
2897 line.rstrip() == "Bug: " + prefix)]
agable@chromium.org42c20792013-09-12 17:34:49 +00002898 if not clean_lines:
maruel@chromium.org0e0436a2011-10-25 13:32:41 +00002899 DieWithError('No CL description, aborting')
agable@chromium.org42c20792013-09-12 17:34:49 +00002900 self.set_description(clean_lines)
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00002901
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002902 def append_footer(self, line):
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002903 """Adds a footer line to the description.
2904
2905 Differentiates legacy "KEY=xxx" footers (used to be called tags) and
2906 Gerrit's footers in the form of "Footer-Key: footer any value" and ensures
2907 that Gerrit footers are always at the end.
2908 """
2909 parsed_footer_line = git_footers.parse_footer(line)
2910 if parsed_footer_line:
2911 # Line is a gerrit footer in the form: Footer-Key: any value.
2912 # Thus, must be appended observing Gerrit footer rules.
2913 self.set_description(
2914 git_footers.add_footer(self.description,
2915 key=parsed_footer_line[0],
2916 value=parsed_footer_line[1]))
2917 return
2918
2919 if not self._description_lines:
2920 self._description_lines.append(line)
2921 return
2922
2923 top_lines, gerrit_footers, _ = git_footers.split_footers(self.description)
2924 if gerrit_footers:
2925 # git_footers.split_footers ensures that there is an empty line before
2926 # actual (gerrit) footers, if any. We have to keep it that way.
2927 assert top_lines and top_lines[-1] == ''
2928 top_lines, separator = top_lines[:-1], top_lines[-1:]
2929 else:
2930 separator = [] # No need for separator if there are no gerrit_footers.
2931
2932 prev_line = top_lines[-1] if top_lines else ''
2933 if (not presubmit_support.Change.TAG_LINE_RE.match(prev_line) or
2934 not presubmit_support.Change.TAG_LINE_RE.match(line)):
2935 top_lines.append('')
2936 top_lines.append(line)
2937 self._description_lines = top_lines + separator + gerrit_footers
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00002938
tandrii99a72f22016-08-17 14:33:24 -07002939 def get_reviewers(self, tbr_only=False):
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002940 """Retrieves the list of reviewers."""
agable@chromium.org42c20792013-09-12 17:34:49 +00002941 matches = [re.match(self.R_LINE, line) for line in self._description_lines]
tandrii99a72f22016-08-17 14:33:24 -07002942 reviewers = [match.group(2).strip()
2943 for match in matches
2944 if match and (not tbr_only or match.group(1).upper() == 'TBR')]
maruel@chromium.org78936cb2013-04-11 00:17:52 +00002945 return cleanup_list(reviewers)
dpranke@chromium.org20254fc2011-03-22 18:28:59 +00002946
bradnelsond975b302016-10-23 12:20:23 -07002947 def get_cced(self):
2948 """Retrieves the list of reviewers."""
2949 matches = [re.match(self.CC_LINE, line) for line in self._description_lines]
2950 cced = [match.group(2).strip() for match in matches if match]
2951 return cleanup_list(cced)
2952
Nodir Turakulov23b82142017-11-16 11:04:25 -08002953 def get_hash_tags(self):
2954 """Extracts and sanitizes a list of Gerrit hashtags."""
2955 subject = (self._description_lines or ('',))[0]
2956 subject = re.sub(
2957 self.STRIP_HASH_TAG_PREFIX, '', subject, flags=re.IGNORECASE)
2958
2959 tags = []
2960 start = 0
2961 bracket_exp = re.compile(self.BRACKET_HASH_TAG)
2962 while True:
2963 m = bracket_exp.match(subject, start)
2964 if not m:
2965 break
2966 tags.append(self.sanitize_hash_tag(m.group(1)))
2967 start = m.end()
2968
2969 if not tags:
2970 # Try "Tag: " prefix.
2971 m = re.match(self.COLON_SEPARATED_HASH_TAG, subject)
2972 if m:
2973 tags.append(self.sanitize_hash_tag(m.group(1)))
2974 return tags
2975
2976 @classmethod
2977 def sanitize_hash_tag(cls, tag):
2978 """Returns a sanitized Gerrit hash tag.
2979
2980 A sanitized hashtag can be used as a git push refspec parameter value.
2981 """
2982 return re.sub(cls.BAD_HASH_TAG_CHUNK, '-', tag).strip('-').lower()
2983
maruel@chromium.orge52678e2013-04-26 18:34:44 +00002984
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00002985def FindCodereviewSettingsFile(filename='codereview.settings'):
2986 """Finds the given file starting in the cwd and going up.
2987
2988 Only looks up to the top of the repository unless an
2989 'inherit-review-settings-ok' file exists in the root of the repository.
2990 """
2991 inherit_ok_file = 'inherit-review-settings-ok'
2992 cwd = os.getcwd()
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00002993 root = settings.GetRoot()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00002994 if os.path.isfile(os.path.join(root, inherit_ok_file)):
2995 root = '/'
2996 while True:
2997 if filename in os.listdir(cwd):
2998 if os.path.isfile(os.path.join(cwd, filename)):
2999 return open(os.path.join(cwd, filename))
3000 if cwd == root:
3001 break
3002 cwd = os.path.dirname(cwd)
3003
3004
3005def LoadCodereviewSettingsFromFile(fileobj):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003006 """Parses a codereview.settings file and updates hooks."""
maruel@chromium.org99ac1c52012-01-16 14:52:12 +00003007 keyvals = gclient_utils.ParseCodereviewSettingsContent(fileobj.read())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003008
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003009 def SetProperty(name, setting, unset_error_ok=False):
3010 fullname = 'rietveld.' + name
3011 if setting in keyvals:
3012 RunGit(['config', fullname, keyvals[setting]])
3013 else:
3014 RunGit(['config', '--unset-all', fullname], error_ok=unset_error_ok)
3015
tandrii48df5812016-10-17 03:55:37 -07003016 if not keyvals.get('GERRIT_HOST', False):
3017 SetProperty('server', 'CODE_REVIEW_SERVER')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003018 # Only server setting is required. Other settings can be absent.
3019 # In that case, we ignore errors raised during option deletion attempt.
3020 SetProperty('cc', 'CC_LIST', unset_error_ok=True)
3021 SetProperty('tree-status-url', 'STATUS', unset_error_ok=True)
3022 SetProperty('viewvc-url', 'VIEW_VC', unset_error_ok=True)
rmistry@google.com90752582014-01-14 21:04:50 +00003023 SetProperty('bug-prefix', 'BUG_PREFIX', unset_error_ok=True)
thestig@chromium.org44202a22014-03-11 19:22:18 +00003024 SetProperty('cpplint-regex', 'LINT_REGEX', unset_error_ok=True)
3025 SetProperty('cpplint-ignore-regex', 'LINT_IGNORE_REGEX', unset_error_ok=True)
rmistry@google.com5626a922015-02-26 14:03:30 +00003026 SetProperty('run-post-upload-hook', 'RUN_POST_UPLOAD_HOOK',
3027 unset_error_ok=True)
Jamie Madilldc4d19e2019-10-24 21:50:02 +00003028 SetProperty(
3029 'format-full-by-default', 'FORMAT_FULL_BY_DEFAULT', unset_error_ok=True)
Dirk Pranke6f0df682021-06-25 00:42:33 +00003030 SetProperty('use-python3', 'USE_PYTHON3', unset_error_ok=True)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003031
ukai@chromium.org7044efc2013-11-28 01:51:21 +00003032 if 'GERRIT_HOST' in keyvals:
ukai@chromium.orge8077812012-02-03 03:41:46 +00003033 RunGit(['config', 'gerrit.host', keyvals['GERRIT_HOST']])
ukai@chromium.orge8077812012-02-03 03:41:46 +00003034
bauerb@chromium.org54b400c2016-01-14 10:08:25 +00003035 if 'GERRIT_SQUASH_UPLOADS' in keyvals:
Edward Lesmes4de54132020-05-05 19:41:33 +00003036 RunGit(['config', 'gerrit.squash-uploads',
3037 keyvals['GERRIT_SQUASH_UPLOADS']])
bauerb@chromium.org54b400c2016-01-14 10:08:25 +00003038
tandrii@chromium.org28253532016-04-14 13:46:56 +00003039 if 'GERRIT_SKIP_ENSURE_AUTHENTICATED' in keyvals:
shinyak@chromium.org00dbccd2016-04-15 07:24:43 +00003040 RunGit(['config', 'gerrit.skip-ensure-authenticated',
tandrii@chromium.org28253532016-04-14 13:46:56 +00003041 keyvals['GERRIT_SKIP_ENSURE_AUTHENTICATED']])
3042
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003043 if 'PUSH_URL_CONFIG' in keyvals and 'ORIGIN_URL_CONFIG' in keyvals:
Andrii Shyshkalov18975322017-01-25 16:44:13 +01003044 # should be of the form
3045 # PUSH_URL_CONFIG: url.ssh://gitrw.chromium.org.pushinsteadof
3046 # ORIGIN_URL_CONFIG: http://src.chromium.org/git
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003047 RunGit(['config', keyvals['PUSH_URL_CONFIG'],
3048 keyvals['ORIGIN_URL_CONFIG']])
3049
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003050
joshua.lock@intel.com426f69b2012-08-02 23:41:49 +00003051def urlretrieve(source, destination):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003052 """Downloads a network object to a local file, like urllib.urlretrieve.
3053
3054 This is necessary because urllib is broken for SSL connections via a proxy.
3055 """
Vadim Shtayuraf7b8f8f2021-11-15 19:10:05 +00003056 with open(destination, 'wb') as f:
Edward Lemur79d4f992019-11-11 23:49:02 +00003057 f.write(urllib.request.urlopen(source).read())
joshua.lock@intel.com426f69b2012-08-02 23:41:49 +00003058
3059
ukai@chromium.org712d6102013-11-27 00:52:58 +00003060def hasSheBang(fname):
3061 """Checks fname is a #! script."""
3062 with open(fname) as f:
3063 return f.read(2).startswith('#!')
3064
3065
tandrii@chromium.org18630d62016-03-04 12:06:02 +00003066def DownloadGerritHook(force):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003067 """Downloads and installs a Gerrit commit-msg hook.
ukai@chromium.org78c4b982012-02-14 02:20:26 +00003068
3069 Args:
3070 force: True to update hooks. False to install hooks if not present.
3071 """
ukai@chromium.org712d6102013-11-27 00:52:58 +00003072 src = 'https://gerrit-review.googlesource.com/tools/hooks/commit-msg'
ukai@chromium.org78c4b982012-02-14 02:20:26 +00003073 dst = os.path.join(settings.GetRoot(), '.git', 'hooks', 'commit-msg')
3074 if not os.access(dst, os.X_OK):
3075 if os.path.exists(dst):
3076 if not force:
3077 return
ukai@chromium.org78c4b982012-02-14 02:20:26 +00003078 try:
joshua.lock@intel.com426f69b2012-08-02 23:41:49 +00003079 urlretrieve(src, dst)
ukai@chromium.org712d6102013-11-27 00:52:58 +00003080 if not hasSheBang(dst):
3081 DieWithError('Not a script: %s\n'
3082 'You need to download from\n%s\n'
3083 'into .git/hooks/commit-msg and '
3084 'chmod +x .git/hooks/commit-msg' % (dst, src))
ukai@chromium.org78c4b982012-02-14 02:20:26 +00003085 os.chmod(dst, stat.S_IRUSR | stat.S_IWUSR | stat.S_IXUSR)
3086 except Exception:
3087 if os.path.exists(dst):
3088 os.remove(dst)
ukai@chromium.org712d6102013-11-27 00:52:58 +00003089 DieWithError('\nFailed to download hooks.\n'
3090 'You need to download from\n%s\n'
3091 'into .git/hooks/commit-msg and '
3092 'chmod +x .git/hooks/commit-msg' % src)
ukai@chromium.org78c4b982012-02-14 02:20:26 +00003093
3094
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003095class _GitCookiesChecker(object):
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003096 """Provides facilities for validating and suggesting fixes to .gitcookies."""
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003097
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003098 _GOOGLESOURCE = 'googlesource.com'
3099
3100 def __init__(self):
3101 # Cached list of [host, identity, source], where source is either
3102 # .gitcookies or .netrc.
3103 self._all_hosts = None
3104
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003105 def ensure_configured_gitcookies(self):
3106 """Runs checks and suggests fixes to make git use .gitcookies from default
3107 path."""
3108 default = gerrit_util.CookiesAuthenticator.get_gitcookies_path()
3109 configured_path = RunGitSilent(
3110 ['config', '--global', 'http.cookiefile']).strip()
Andrii Shyshkalov1e250cd2017-05-10 15:39:31 +02003111 configured_path = os.path.expanduser(configured_path)
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003112 if configured_path:
3113 self._ensure_default_gitcookies_path(configured_path, default)
3114 else:
3115 self._configure_gitcookies_path(default)
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003116
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003117 @staticmethod
3118 def _ensure_default_gitcookies_path(configured_path, default_path):
3119 assert configured_path
3120 if configured_path == default_path:
3121 print('git is already configured to use your .gitcookies from %s' %
3122 configured_path)
3123 return
3124
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003125 print('WARNING: You have configured custom path to .gitcookies: %s\n'
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003126 'Gerrit and other depot_tools expect .gitcookies at %s\n' %
3127 (configured_path, default_path))
3128
3129 if not os.path.exists(configured_path):
3130 print('However, your configured .gitcookies file is missing.')
3131 confirm_or_exit('Reconfigure git to use default .gitcookies?',
3132 action='reconfigure')
3133 RunGit(['config', '--global', 'http.cookiefile', default_path])
3134 return
3135
3136 if os.path.exists(default_path):
3137 print('WARNING: default .gitcookies file already exists %s' %
3138 default_path)
3139 DieWithError('Please delete %s manually and re-run git cl creds-check' %
3140 default_path)
3141
3142 confirm_or_exit('Move existing .gitcookies to default location?',
3143 action='move')
3144 shutil.move(configured_path, default_path)
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003145 RunGit(['config', '--global', 'http.cookiefile', default_path])
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003146 print('Moved and reconfigured git to use .gitcookies from %s' %
3147 default_path)
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003148
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003149 @staticmethod
3150 def _configure_gitcookies_path(default_path):
3151 netrc_path = gerrit_util.CookiesAuthenticator.get_netrc_path()
3152 if os.path.exists(netrc_path):
3153 print('You seem to be using outdated .netrc for git credentials: %s' %
3154 netrc_path)
3155 print('This tool will guide you through setting up recommended '
3156 '.gitcookies store for git credentials.\n'
3157 '\n'
3158 'IMPORTANT: If something goes wrong and you decide to go back, do:\n'
3159 ' git config --global --unset http.cookiefile\n'
3160 ' mv %s %s.backup\n\n' % (default_path, default_path))
3161 confirm_or_exit(action='setup .gitcookies')
3162 RunGit(['config', '--global', 'http.cookiefile', default_path])
3163 print('Configured git to use .gitcookies from %s' % default_path)
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003164
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003165 def get_hosts_with_creds(self, include_netrc=False):
3166 if self._all_hosts is None:
3167 a = gerrit_util.CookiesAuthenticator()
3168 self._all_hosts = [
3169 (h, u, s)
3170 for h, u, s in itertools.chain(
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00003171 ((h, u, '.netrc') for h, (u, _, _) in a.netrc.hosts.items()),
3172 ((h, u, '.gitcookies') for h, (u, _) in a.gitcookies.items())
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003173 )
3174 if h.endswith(self._GOOGLESOURCE)
3175 ]
3176
3177 if include_netrc:
3178 return self._all_hosts
3179 return [(h, u, s) for h, u, s in self._all_hosts if s != '.netrc']
3180
3181 def print_current_creds(self, include_netrc=False):
3182 hosts = sorted(self.get_hosts_with_creds(include_netrc=include_netrc))
3183 if not hosts:
3184 print('No Git/Gerrit credentials found')
3185 return
Edward Lemur79d4f992019-11-11 23:49:02 +00003186 lengths = [max(map(len, (row[i] for row in hosts))) for i in range(3)]
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003187 header = [('Host', 'User', 'Which file'),
3188 ['=' * l for l in lengths]]
3189 for row in (header + hosts):
3190 print('\t'.join((('%%+%ds' % l) % s)
3191 for l, s in zip(lengths, row)))
3192
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003193 @staticmethod
3194 def _parse_identity(identity):
Lei Zhangd3f769a2017-12-15 15:16:14 -08003195 """Parses identity "git-<username>.domain" into <username> and domain."""
3196 # Special case: usernames that contain ".", which are generally not
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +02003197 # distinguishable from sub-domains. But we do know typical domains:
3198 if identity.endswith('.chromium.org'):
3199 domain = 'chromium.org'
3200 username = identity[:-len('.chromium.org')]
3201 else:
3202 username, domain = identity.split('.', 1)
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003203 if username.startswith('git-'):
3204 username = username[len('git-'):]
3205 return username, domain
3206
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003207 def _canonical_git_googlesource_host(self, host):
3208 """Normalizes Gerrit hosts (with '-review') to Git host."""
3209 assert host.endswith(self._GOOGLESOURCE)
3210 # Prefix doesn't include '.' at the end.
3211 prefix = host[:-(1 + len(self._GOOGLESOURCE))]
3212 if prefix.endswith('-review'):
3213 prefix = prefix[:-len('-review')]
3214 return prefix + '.' + self._GOOGLESOURCE
3215
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003216 def _canonical_gerrit_googlesource_host(self, host):
3217 git_host = self._canonical_git_googlesource_host(host)
3218 prefix = git_host.split('.', 1)[0]
3219 return prefix + '-review.' + self._GOOGLESOURCE
3220
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003221 def _get_counterpart_host(self, host):
3222 assert host.endswith(self._GOOGLESOURCE)
3223 git = self._canonical_git_googlesource_host(host)
3224 gerrit = self._canonical_gerrit_googlesource_host(git)
3225 return git if gerrit == host else gerrit
3226
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003227 def has_generic_host(self):
3228 """Returns whether generic .googlesource.com has been configured.
3229
3230 Chrome Infra recommends to use explicit ${host}.googlesource.com instead.
3231 """
3232 for host, _, _ in self.get_hosts_with_creds(include_netrc=False):
3233 if host == '.' + self._GOOGLESOURCE:
3234 return True
3235 return False
3236
3237 def _get_git_gerrit_identity_pairs(self):
3238 """Returns map from canonic host to pair of identities (Git, Gerrit).
3239
3240 One of identities might be None, meaning not configured.
3241 """
3242 host_to_identity_pairs = {}
3243 for host, identity, _ in self.get_hosts_with_creds():
3244 canonical = self._canonical_git_googlesource_host(host)
3245 pair = host_to_identity_pairs.setdefault(canonical, [None, None])
3246 idx = 0 if canonical == host else 1
3247 pair[idx] = identity
3248 return host_to_identity_pairs
3249
3250 def get_partially_configured_hosts(self):
3251 return set(
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003252 (host if i1 else self._canonical_gerrit_googlesource_host(host))
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00003253 for host, (i1, i2) in self._get_git_gerrit_identity_pairs().items()
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003254 if None in (i1, i2) and host != '.' + self._GOOGLESOURCE)
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003255
3256 def get_conflicting_hosts(self):
3257 return set(
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003258 host
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00003259 for host, (i1, i2) in self._get_git_gerrit_identity_pairs().items()
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003260 if None not in (i1, i2) and i1 != i2)
3261
3262 def get_duplicated_hosts(self):
3263 counters = collections.Counter(h for h, _, _ in self.get_hosts_with_creds())
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00003264 return set(host for host, count in counters.items() if count > 1)
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003265
Andrii Shyshkalov97800502017-03-16 16:04:32 +01003266
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003267 @staticmethod
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003268 def _format_hosts(hosts, extra_column_func=None):
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003269 hosts = sorted(hosts)
3270 assert hosts
3271 if extra_column_func is None:
3272 extras = [''] * len(hosts)
3273 else:
3274 extras = [extra_column_func(host) for host in hosts]
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003275 tmpl = '%%-%ds %%-%ds' % (max(map(len, hosts)), max(map(len, extras)))
3276 lines = []
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003277 for he in zip(hosts, extras):
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003278 lines.append(tmpl % he)
3279 return lines
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003280
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003281 def _find_problems(self):
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003282 if self.has_generic_host():
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003283 yield ('.googlesource.com wildcard record detected',
3284 ['Chrome Infrastructure team recommends to list full host names '
3285 'explicitly.'],
3286 None)
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003287
3288 dups = self.get_duplicated_hosts()
3289 if dups:
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003290 yield ('The following hosts were defined twice',
3291 self._format_hosts(dups),
3292 None)
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003293
3294 partial = self.get_partially_configured_hosts()
3295 if partial:
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003296 yield ('Credentials should come in pairs for Git and Gerrit hosts. '
3297 'These hosts are missing',
3298 self._format_hosts(partial, lambda host: 'but %s defined' %
3299 self._get_counterpart_host(host)),
3300 partial)
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003301
3302 conflicting = self.get_conflicting_hosts()
3303 if conflicting:
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003304 yield ('The following Git hosts have differing credentials from their '
3305 'Gerrit counterparts',
3306 self._format_hosts(conflicting, lambda host: '%s vs %s' %
3307 tuple(self._get_git_gerrit_identity_pairs()[host])),
3308 conflicting)
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003309
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003310 def find_and_report_problems(self):
3311 """Returns True if there was at least one problem, else False."""
3312 found = False
3313 bad_hosts = set()
3314 for title, sublines, hosts in self._find_problems():
3315 if not found:
3316 found = True
3317 print('\n\n.gitcookies problem report:\n')
3318 bad_hosts.update(hosts or [])
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003319 print(' %s%s' % (title, (':' if sublines else '')))
Andrii Shyshkalovc8173822017-07-10 12:10:53 +02003320 if sublines:
3321 print()
3322 print(' %s' % '\n '.join(sublines))
3323 print()
3324
3325 if bad_hosts:
3326 assert found
3327 print(' You can manually remove corresponding lines in your %s file and '
3328 'visit the following URLs with correct account to generate '
3329 'correct credential lines:\n' %
3330 gerrit_util.CookiesAuthenticator.get_gitcookies_path())
3331 print(' %s' % '\n '.join(sorted(set(
3332 gerrit_util.CookiesAuthenticator().get_new_password_url(
3333 self._canonical_git_googlesource_host(host))
3334 for host in bad_hosts
3335 ))))
3336 return found
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003337
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003338
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003339@metrics.collector.collect_metrics('git cl creds-check')
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003340def CMDcreds_check(parser, args):
3341 """Checks credentials and suggests changes."""
3342 _, _ = parser.parse_args(args)
3343
Vadim Shtayurab250ec12018-10-04 00:21:08 +00003344 # Code below checks .gitcookies. Abort if using something else.
3345 authn = gerrit_util.Authenticator.get()
3346 if not isinstance(authn, gerrit_util.CookiesAuthenticator):
Edward Lemur57d47422020-03-06 20:43:07 +00003347 message = (
Vadim Shtayurab250ec12018-10-04 00:21:08 +00003348 'This command is not designed for bot environment. It checks '
3349 '~/.gitcookies file not generally used on bots.')
Edward Lemur57d47422020-03-06 20:43:07 +00003350 # TODO(crbug.com/1059384): Automatically detect when running on cloudtop.
3351 if isinstance(authn, gerrit_util.GceAuthenticator):
3352 message += (
3353 '\n'
3354 'If you need to run this on GCE or a cloudtop instance, '
3355 'export SKIP_GCE_AUTH_FOR_GIT=1 in your env.')
3356 DieWithError(message)
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003357
Andrii Shyshkalov517948b2017-03-15 15:51:59 +01003358 checker = _GitCookiesChecker()
3359 checker.ensure_configured_gitcookies()
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003360
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003361 print('Your .netrc and .gitcookies have credentials for these hosts:')
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003362 checker.print_current_creds(include_netrc=True)
3363
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003364 if not checker.find_and_report_problems():
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003365 print('\nNo problems detected in your .gitcookies file.')
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01003366 return 0
3367 return 1
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01003368
3369
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003370@metrics.collector.collect_metrics('git cl baseurl')
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00003371def CMDbaseurl(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00003372 """Gets or sets base-url for this branch."""
Edward Lesmes50da7702020-03-30 19:23:43 +00003373 branchref = scm.GIT.GetBranchRef(settings.GetRoot())
Edward Lemur85153282020-02-14 22:06:29 +00003374 branch = scm.GIT.ShortBranchName(branchref)
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00003375 _, args = parser.parse_args(args)
3376 if not args:
vapiera7fbd5a2016-06-16 09:17:49 -07003377 print('Current base-url:')
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00003378 return RunGit(['config', 'branch.%s.base-url' % branch],
3379 error_ok=False).strip()
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +00003380
3381 print('Setting base-url to %s' % args[0])
3382 return RunGit(['config', 'branch.%s.base-url' % branch, args[0]],
3383 error_ok=False).strip()
kalmard@homejinni.com6b0051e2012-04-03 15:45:08 +00003384
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003385
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00003386def color_for_status(status):
3387 """Maps a Changelist status to color, for CMDstatus and other tools."""
Bruce Dawsonb73f8a92020-03-27 22:03:08 +00003388 BOLD = '\033[1m'
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00003389 return {
Bruce Dawsonb73f8a92020-03-27 22:03:08 +00003390 'unsent': BOLD + Fore.YELLOW,
3391 'waiting': BOLD + Fore.RED,
3392 'reply': BOLD + Fore.YELLOW,
3393 'not lgtm': BOLD + Fore.RED,
3394 'lgtm': BOLD + Fore.GREEN,
3395 'commit': BOLD + Fore.MAGENTA,
3396 'closed': BOLD + Fore.CYAN,
3397 'error': BOLD + Fore.WHITE,
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00003398 }.get(status, Fore.WHITE)
3399
tandrii@chromium.org04ea8462016-04-25 19:51:21 +00003400
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003401def get_cl_statuses(changes, fine_grained, max_processes=None):
3402 """Returns a blocking iterable of (cl, status) for given branches.
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00003403
3404 If fine_grained is true, this will fetch CL statuses from the server.
3405 Otherwise, simply indicate if there's a matching url for the given branches.
3406
3407 If max_processes is specified, it is used as the maximum number of processes
3408 to spawn to fetch CL status from the server. Otherwise 1 process per branch is
3409 spawned.
calamity@chromium.orgcf197482016-04-29 20:15:53 +00003410
3411 See GetStatus() for a list of possible statuses.
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00003412 """
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01003413 if not changes:
Edward Lemur61bf4172020-02-24 23:22:37 +00003414 return
calamity@chromium.orgcf197482016-04-29 20:15:53 +00003415
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01003416 if not fine_grained:
3417 # Fast path which doesn't involve querying codereview servers.
Aaron Gablea1bab272017-04-11 16:38:18 -07003418 # Do not use get_approving_reviewers(), since it requires an HTTP request.
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003419 for cl in changes:
3420 yield (cl, 'waiting' if cl.GetIssueURL() else 'error')
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01003421 return
3422
3423 # First, sort out authentication issues.
3424 logging.debug('ensuring credentials exist')
3425 for cl in changes:
3426 cl.EnsureAuthenticated(force=False, refresh=True)
3427
3428 def fetch(cl):
3429 try:
3430 return (cl, cl.GetStatus())
3431 except:
3432 # See http://crbug.com/629863.
Andrii Shyshkalov98824232018-04-19 11:37:15 -07003433 logging.exception('failed to fetch status for cl %s:', cl.GetIssue())
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01003434 raise
3435
3436 threads_count = len(changes)
3437 if max_processes:
3438 threads_count = max(1, min(threads_count, max_processes))
3439 logging.debug('querying %d CLs using %d threads', len(changes), threads_count)
3440
Edward Lemur61bf4172020-02-24 23:22:37 +00003441 pool = multiprocessing.pool.ThreadPool(threads_count)
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01003442 fetched_cls = set()
3443 try:
3444 it = pool.imap_unordered(fetch, changes).__iter__()
3445 while True:
3446 try:
3447 cl, status = it.next(timeout=5)
Edward Lemur61bf4172020-02-24 23:22:37 +00003448 except (multiprocessing.TimeoutError, StopIteration):
Andrii Shyshkalov2f8e9242017-01-23 19:20:19 +01003449 break
3450 fetched_cls.add(cl)
3451 yield cl, status
3452 finally:
3453 pool.close()
3454
3455 # Add any branches that failed to fetch.
3456 for cl in set(changes) - fetched_cls:
3457 yield (cl, 'error')
jsbell@chromium.orgb99fbd92014-09-11 17:29:28 +00003458
rmistry@google.com2dd99862015-06-22 12:22:18 +00003459
Jose Lopes3863fc52020-04-07 17:00:25 +00003460def upload_branch_deps(cl, args, force=False):
rmistry@google.com2dd99862015-06-22 12:22:18 +00003461 """Uploads CLs of local branches that are dependents of the current branch.
3462
3463 If the local branch dependency tree looks like:
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003464
3465 test1 -> test2.1 -> test3.1
3466 -> test3.2
3467 -> test2.2 -> test3.3
rmistry@google.com2dd99862015-06-22 12:22:18 +00003468
3469 and you run "git cl upload --dependencies" from test1 then "git cl upload" is
3470 run on the dependent branches in this order:
3471 test2.1, test3.1, test3.2, test2.2, test3.3
3472
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003473 Note: This function does not rebase your local dependent branches. Use it
3474 when you make a change to the parent branch that will not conflict
3475 with its dependent branches, and you would like their dependencies
3476 updated in Rietveld.
rmistry@google.com2dd99862015-06-22 12:22:18 +00003477 """
3478 if git_common.is_dirty_git_tree('upload-branch-deps'):
3479 return 1
3480
3481 root_branch = cl.GetBranch()
3482 if root_branch is None:
3483 DieWithError('Can\'t find dependent branches from detached HEAD state. '
3484 'Get on a branch!')
Andrii Shyshkalov9f274432018-10-15 16:40:23 +00003485 if not cl.GetIssue():
rmistry@google.com2dd99862015-06-22 12:22:18 +00003486 DieWithError('Current branch does not have an uploaded CL. We cannot set '
3487 'patchset dependencies without an uploaded CL.')
3488
3489 branches = RunGit(['for-each-ref',
3490 '--format=%(refname:short) %(upstream:short)',
3491 'refs/heads'])
3492 if not branches:
3493 print('No local branches found.')
3494 return 0
3495
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003496 # Create a dictionary of all local branches to the branches that are
3497 # dependent on it.
rmistry@google.com2dd99862015-06-22 12:22:18 +00003498 tracked_to_dependents = collections.defaultdict(list)
3499 for b in branches.splitlines():
3500 tokens = b.split()
3501 if len(tokens) == 2:
3502 branch_name, tracked = tokens
3503 tracked_to_dependents[tracked].append(branch_name)
3504
vapiera7fbd5a2016-06-16 09:17:49 -07003505 print()
3506 print('The dependent local branches of %s are:' % root_branch)
rmistry@google.com2dd99862015-06-22 12:22:18 +00003507 dependents = []
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003508
rmistry@google.com2dd99862015-06-22 12:22:18 +00003509 def traverse_dependents_preorder(branch, padding=''):
3510 dependents_to_process = tracked_to_dependents.get(branch, [])
3511 padding += ' '
3512 for dependent in dependents_to_process:
vapiera7fbd5a2016-06-16 09:17:49 -07003513 print('%s%s' % (padding, dependent))
rmistry@google.com2dd99862015-06-22 12:22:18 +00003514 dependents.append(dependent)
3515 traverse_dependents_preorder(dependent, padding)
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00003516
rmistry@google.com2dd99862015-06-22 12:22:18 +00003517 traverse_dependents_preorder(root_branch)
vapiera7fbd5a2016-06-16 09:17:49 -07003518 print()
rmistry@google.com2dd99862015-06-22 12:22:18 +00003519
3520 if not dependents:
vapiera7fbd5a2016-06-16 09:17:49 -07003521 print('There are no dependent local branches for %s' % root_branch)
rmistry@google.com2dd99862015-06-22 12:22:18 +00003522 return 0
3523
Jose Lopes3863fc52020-04-07 17:00:25 +00003524 if not force:
3525 confirm_or_exit('This command will checkout all dependent branches and run '
3526 '"git cl upload".', action='continue')
rmistry@google.com2dd99862015-06-22 12:22:18 +00003527
rmistry@google.com2dd99862015-06-22 12:22:18 +00003528 # Record all dependents that failed to upload.
3529 failures = {}
3530 # Go through all dependents, checkout the branch and upload.
3531 try:
3532 for dependent_branch in dependents:
vapiera7fbd5a2016-06-16 09:17:49 -07003533 print()
3534 print('--------------------------------------')
3535 print('Running "git cl upload" from %s:' % dependent_branch)
rmistry@google.com2dd99862015-06-22 12:22:18 +00003536 RunGit(['checkout', '-q', dependent_branch])
vapiera7fbd5a2016-06-16 09:17:49 -07003537 print()
rmistry@google.com2dd99862015-06-22 12:22:18 +00003538 try:
3539 if CMDupload(OptionParser(), args) != 0:
vapiera7fbd5a2016-06-16 09:17:49 -07003540 print('Upload failed for %s!' % dependent_branch)
rmistry@google.com2dd99862015-06-22 12:22:18 +00003541 failures[dependent_branch] = 1
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -08003542 except: # pylint: disable=bare-except
rmistry@google.com2dd99862015-06-22 12:22:18 +00003543 failures[dependent_branch] = 1
vapiera7fbd5a2016-06-16 09:17:49 -07003544 print()
rmistry@google.com2dd99862015-06-22 12:22:18 +00003545 finally:
3546 # Swap back to the original root branch.
3547 RunGit(['checkout', '-q', root_branch])
3548
vapiera7fbd5a2016-06-16 09:17:49 -07003549 print()
3550 print('Upload complete for dependent branches!')
rmistry@google.com2dd99862015-06-22 12:22:18 +00003551 for dependent_branch in dependents:
3552 upload_status = 'failed' if failures.get(dependent_branch) else 'succeeded'
vapiera7fbd5a2016-06-16 09:17:49 -07003553 print(' %s : %s' % (dependent_branch, upload_status))
3554 print()
rmistry@google.com2dd99862015-06-22 12:22:18 +00003555
3556 return 0
3557
3558
Tibor Goldschwendt7c5efb22020-03-25 01:23:54 +00003559def GetArchiveTagForBranch(issue_num, branch_name, existing_tags, pattern):
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00003560 """Given a proposed tag name, returns a tag name that is guaranteed to be
3561 unique. If 'foo' is proposed but already exists, then 'foo-2' is used,
3562 or 'foo-3', and so on."""
3563
Tibor Goldschwendt7c5efb22020-03-25 01:23:54 +00003564 proposed_tag = pattern.format(**{'issue': issue_num, 'branch': branch_name})
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00003565 for suffix_num in itertools.count(1):
3566 if suffix_num == 1:
3567 to_check = proposed_tag
3568 else:
3569 to_check = '%s-%d' % (proposed_tag, suffix_num)
3570
3571 if to_check not in existing_tags:
3572 return to_check
3573
3574
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003575@metrics.collector.collect_metrics('git cl archive')
kmarshall3bff56b2016-06-06 18:31:47 -07003576def CMDarchive(parser, args):
3577 """Archives and deletes branches associated with closed changelists."""
3578 parser.add_option(
3579 '-j', '--maxjobs', action='store', type=int,
kmarshall9249e012016-08-23 12:02:16 -07003580 help='The maximum number of jobs to use when retrieving review status.')
kmarshall3bff56b2016-06-06 18:31:47 -07003581 parser.add_option(
3582 '-f', '--force', action='store_true',
3583 help='Bypasses the confirmation prompt.')
kmarshall9249e012016-08-23 12:02:16 -07003584 parser.add_option(
3585 '-d', '--dry-run', action='store_true',
3586 help='Skip the branch tagging and removal steps.')
3587 parser.add_option(
3588 '-t', '--notags', action='store_true',
3589 help='Do not tag archived branches. '
3590 'Note: local commit history may be lost.')
Tibor Goldschwendt7c5efb22020-03-25 01:23:54 +00003591 parser.add_option(
3592 '-p',
3593 '--pattern',
3594 default='git-cl-archived-{issue}-{branch}',
3595 help='Format string for archive tags. '
3596 'E.g. \'archived-{issue}-{branch}\'.')
kmarshall3bff56b2016-06-06 18:31:47 -07003597
kmarshall3bff56b2016-06-06 18:31:47 -07003598 options, args = parser.parse_args(args)
3599 if args:
3600 parser.error('Unsupported args: %s' % ' '.join(args))
kmarshall3bff56b2016-06-06 18:31:47 -07003601
3602 branches = RunGit(['for-each-ref', '--format=%(refname)', 'refs/heads'])
3603 if not branches:
3604 return 0
3605
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00003606 tags = RunGit(['for-each-ref', '--format=%(refname)',
3607 'refs/tags']).splitlines() or []
3608 tags = [t.split('/')[-1] for t in tags]
3609
vapiera7fbd5a2016-06-16 09:17:49 -07003610 print('Finding all branches associated with closed issues...')
Edward Lemur934836a2019-09-09 20:16:54 +00003611 changes = [Changelist(branchref=b)
3612 for b in branches.splitlines()]
kmarshall3bff56b2016-06-06 18:31:47 -07003613 alignment = max(5, max(len(c.GetBranch()) for c in changes))
3614 statuses = get_cl_statuses(changes,
3615 fine_grained=True,
3616 max_processes=options.maxjobs)
3617 proposal = [(cl.GetBranch(),
Tibor Goldschwendt7c5efb22020-03-25 01:23:54 +00003618 GetArchiveTagForBranch(cl.GetIssue(), cl.GetBranch(), tags,
3619 options.pattern))
kmarshall3bff56b2016-06-06 18:31:47 -07003620 for cl, status in statuses
Andrii Shyshkalov51bdf8c2018-10-18 01:07:58 +00003621 if status in ('closed', 'rietveld-not-supported')]
kmarshall3bff56b2016-06-06 18:31:47 -07003622 proposal.sort()
3623
3624 if not proposal:
vapiera7fbd5a2016-06-16 09:17:49 -07003625 print('No branches with closed codereview issues found.')
kmarshall3bff56b2016-06-06 18:31:47 -07003626 return 0
3627
Edward Lemur85153282020-02-14 22:06:29 +00003628 current_branch = scm.GIT.GetBranch(settings.GetRoot())
kmarshall3bff56b2016-06-06 18:31:47 -07003629
vapiera7fbd5a2016-06-16 09:17:49 -07003630 print('\nBranches with closed issues that will be archived:\n')
kmarshall9249e012016-08-23 12:02:16 -07003631 if options.notags:
3632 for next_item in proposal:
3633 print(' ' + next_item[0])
3634 else:
3635 print('%*s | %s' % (alignment, 'Branch name', 'Archival tag name'))
3636 for next_item in proposal:
3637 print('%*s %s' % (alignment, next_item[0], next_item[1]))
kmarshall3bff56b2016-06-06 18:31:47 -07003638
kmarshall9249e012016-08-23 12:02:16 -07003639 # Quit now on precondition failure or if instructed by the user, either
3640 # via an interactive prompt or by command line flags.
3641 if options.dry_run:
3642 print('\nNo changes were made (dry run).\n')
3643 return 0
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +00003644
3645 if any(branch == current_branch for branch, _ in proposal):
kmarshall3bff56b2016-06-06 18:31:47 -07003646 print('You are currently on a branch \'%s\' which is associated with a '
3647 'closed codereview issue, so archive cannot proceed. Please '
3648 'checkout another branch and run this command again.' %
3649 current_branch)
3650 return 1
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +00003651
3652 if not options.force:
Edward Lesmesae3586b2020-03-23 21:21:14 +00003653 answer = gclient_utils.AskForData('\nProceed with deletion (Y/n)? ').lower()
sergiyb4a5ecbe2016-06-20 09:46:00 -07003654 if answer not in ('y', ''):
vapiera7fbd5a2016-06-16 09:17:49 -07003655 print('Aborted.')
kmarshall3bff56b2016-06-06 18:31:47 -07003656 return 1
3657
3658 for branch, tagname in proposal:
kmarshall9249e012016-08-23 12:02:16 -07003659 if not options.notags:
3660 RunGit(['tag', tagname, branch])
Kevin Marshall0e60ecd2019-12-04 17:44:13 +00003661
3662 if RunGitWithCode(['branch', '-D', branch])[0] != 0:
3663 # Clean up the tag if we failed to delete the branch.
3664 RunGit(['tag', '-d', tagname])
kmarshall9249e012016-08-23 12:02:16 -07003665
vapiera7fbd5a2016-06-16 09:17:49 -07003666 print('\nJob\'s done!')
kmarshall3bff56b2016-06-06 18:31:47 -07003667
3668 return 0
3669
3670
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003671@metrics.collector.collect_metrics('git cl status')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003672def CMDstatus(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00003673 """Show status of changelists.
3674
3675 Colors are used to tell the state of the CL unless --fast is used:
jsbell@chromium.orgaeab41a2013-12-10 20:01:22 +00003676 - Blue waiting for review
Aaron Gable9ab38c62017-04-06 14:36:33 -07003677 - Yellow waiting for you to reply to review, or not yet sent
jsbell@chromium.orgaeab41a2013-12-10 20:01:22 +00003678 - Green LGTM'ed
Aaron Gable9ab38c62017-04-06 14:36:33 -07003679 - Red 'not LGTM'ed
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +00003680 - Magenta in the CQ
jsbell@chromium.orgaeab41a2013-12-10 20:01:22 +00003681 - Cyan was committed, branch can be deleted
Aaron Gable9ab38c62017-04-06 14:36:33 -07003682 - White error, or unknown status
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00003683
3684 Also see 'git cl comments'.
3685 """
Alan Cuttera3be9a52019-03-04 18:50:33 +00003686 parser.add_option(
3687 '--no-branch-color',
3688 action='store_true',
3689 help='Disable colorized branch names')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003690 parser.add_option('--field',
phajdan.jr289d03e2016-08-16 08:21:06 -07003691 help='print only specific field (desc|id|patch|status|url)')
maruel@chromium.org1033efd2013-07-23 23:25:09 +00003692 parser.add_option('-f', '--fast', action='store_true',
3693 help='Do not retrieve review status')
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00003694 parser.add_option(
3695 '-j', '--maxjobs', action='store', type=int,
3696 help='The maximum number of jobs to use when retrieving review status')
Edward Lemur52969c92020-02-06 18:15:28 +00003697 parser.add_option(
3698 '-i', '--issue', type=int,
3699 help='Operate on this issue instead of the current branch\'s implicit '
3700 'issue. Requires --field to be set.')
Sigurd Schneider9abde8c2020-11-17 08:44:52 +00003701 parser.add_option('-d',
3702 '--date-order',
3703 action='store_true',
3704 help='Order branches by committer date.')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00003705 options, args = parser.parse_args(args)
maruel@chromium.org39c0b222013-08-17 16:57:01 +00003706 if args:
3707 parser.error('Unsupported args: %s' % args)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003708
iannuccie53c9352016-08-17 14:40:40 -07003709 if options.issue is not None and not options.field:
Edward Lemur6c6827c2020-02-06 21:15:18 +00003710 parser.error('--field must be given when --issue is set.')
iannucci3c972b92016-08-17 13:24:10 -07003711
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003712 if options.field:
Edward Lemur934836a2019-09-09 20:16:54 +00003713 cl = Changelist(issue=options.issue)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003714 if options.field.startswith('desc'):
Edward Lemur6c6827c2020-02-06 21:15:18 +00003715 if cl.GetIssue():
3716 print(cl.FetchDescription())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003717 elif options.field == 'id':
3718 issueid = cl.GetIssue()
3719 if issueid:
vapiera7fbd5a2016-06-16 09:17:49 -07003720 print(issueid)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003721 elif options.field == 'patch':
Aaron Gablee8856ee2017-12-07 12:41:46 -08003722 patchset = cl.GetMostRecentPatchset()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003723 if patchset:
vapiera7fbd5a2016-06-16 09:17:49 -07003724 print(patchset)
phajdan.jr289d03e2016-08-16 08:21:06 -07003725 elif options.field == 'status':
3726 print(cl.GetStatus())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003727 elif options.field == 'url':
3728 url = cl.GetIssueURL()
3729 if url:
vapiera7fbd5a2016-06-16 09:17:49 -07003730 print(url)
maruel@chromium.orge25c75b2013-07-23 18:30:56 +00003731 return 0
3732
Sigurd Schneider9abde8c2020-11-17 08:44:52 +00003733 branches = RunGit([
3734 'for-each-ref', '--format=%(refname) %(committerdate:unix)', 'refs/heads'
3735 ])
maruel@chromium.orge25c75b2013-07-23 18:30:56 +00003736 if not branches:
3737 print('No local branch found.')
3738 return 0
3739
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003740 changes = [
Sigurd Schneider9abde8c2020-11-17 08:44:52 +00003741 Changelist(branchref=b, commit_date=ct)
3742 for b, ct in map(lambda line: line.split(' '), branches.splitlines())
3743 ]
vapiera7fbd5a2016-06-16 09:17:49 -07003744 print('Branches associated with reviews:')
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003745 output = get_cl_statuses(changes,
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00003746 fine_grained=not options.fast,
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003747 max_processes=options.maxjobs)
maruel@chromium.org1033efd2013-07-23 23:25:09 +00003748
Edward Lemur85153282020-02-14 22:06:29 +00003749 current_branch = scm.GIT.GetBranch(settings.GetRoot())
Daniel McArdlea23bf592019-02-12 00:25:12 +00003750
3751 def FormatBranchName(branch, colorize=False):
3752 """Simulates 'git branch' behavior. Colorizes and prefixes branch name with
3753 an asterisk when it is the current branch."""
3754
3755 asterisk = ""
3756 color = Fore.RESET
3757 if branch == current_branch:
3758 asterisk = "* "
3759 color = Fore.GREEN
Edward Lemur85153282020-02-14 22:06:29 +00003760 branch_name = scm.GIT.ShortBranchName(branch)
Daniel McArdlea23bf592019-02-12 00:25:12 +00003761
3762 if colorize:
3763 return asterisk + color + branch_name + Fore.RESET
Daniel McArdle452a49f2019-02-14 17:28:31 +00003764 return asterisk + branch_name
3765
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00003766 branch_statuses = {}
Daniel McArdlea23bf592019-02-12 00:25:12 +00003767
3768 alignment = max(5, max(len(FormatBranchName(c.GetBranch())) for c in changes))
Sigurd Schneider1bfda8e2021-06-30 14:46:25 +00003769
3770 if options.date_order or settings.IsStatusCommitOrderByDate():
Sigurd Schneider9abde8c2020-11-17 08:44:52 +00003771 sorted_changes = sorted(changes,
3772 key=lambda c: c.GetCommitDate(),
3773 reverse=True)
3774 else:
3775 sorted_changes = sorted(changes, key=lambda c: c.GetBranch())
3776 for cl in sorted_changes:
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003777 branch = cl.GetBranch()
calamity@chromium.orgffde55c2015-03-12 00:44:17 +00003778 while branch not in branch_statuses:
Edward Lemur79d4f992019-11-11 23:49:02 +00003779 c, status = next(output)
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003780 branch_statuses[c.GetBranch()] = status
3781 status = branch_statuses.pop(branch)
Andrii Shyshkalov1ee78cd2020-03-12 01:31:53 +00003782 url = cl.GetIssueURL(short=True)
clemensh@chromium.orgcbd7dc32016-05-31 10:33:50 +00003783 if url and (not status or status == 'error'):
3784 # The issue probably doesn't exist anymore.
3785 url += ' (broken)'
3786
nodir@chromium.orga6de1f42015-06-10 04:23:17 +00003787 color = color_for_status(status)
Bruce Dawsonb73f8a92020-03-27 22:03:08 +00003788 # Turn off bold as well as colors.
3789 END = '\033[0m'
3790 reset = Fore.RESET + END
iannucci@chromium.org596cd5c2016-04-04 21:34:39 +00003791 if not setup_color.IS_TTY:
maruel@chromium.org885f6512013-07-27 02:17:26 +00003792 color = ''
3793 reset = ''
nodir@chromium.orga6de1f42015-06-10 04:23:17 +00003794 status_str = '(%s)' % status if status else ''
Daniel McArdle452a49f2019-02-14 17:28:31 +00003795
Alan Cuttera3be9a52019-03-04 18:50:33 +00003796 branch_display = FormatBranchName(branch)
3797 padding = ' ' * (alignment - len(branch_display))
3798 if not options.no_branch_color:
3799 branch_display = FormatBranchName(branch, colorize=True)
Daniel McArdle452a49f2019-02-14 17:28:31 +00003800
Alan Cuttera3be9a52019-03-04 18:50:33 +00003801 print(' %s : %s%s %s%s' % (padding + branch_display, color, url,
3802 status_str, reset))
Andrii Shyshkalovd0e1d9d2017-01-24 17:10:51 +01003803
vapiera7fbd5a2016-06-16 09:17:49 -07003804 print()
Daniel McArdlea23bf592019-02-12 00:25:12 +00003805 print('Current branch: %s' % current_branch)
Andrii Shyshkalovd0e1d9d2017-01-24 17:10:51 +01003806 for cl in changes:
Daniel McArdlea23bf592019-02-12 00:25:12 +00003807 if cl.GetBranch() == current_branch:
Andrii Shyshkalovd0e1d9d2017-01-24 17:10:51 +01003808 break
dpranke@chromium.orgee87f582015-07-31 18:46:25 +00003809 if not cl.GetIssue():
vapiera7fbd5a2016-06-16 09:17:49 -07003810 print('No issue assigned.')
dpranke@chromium.orgee87f582015-07-31 18:46:25 +00003811 return 0
vapiera7fbd5a2016-06-16 09:17:49 -07003812 print('Issue number: %s (%s)' % (cl.GetIssue(), cl.GetIssueURL()))
maruel@chromium.org85616e02014-07-28 15:37:55 +00003813 if not options.fast:
vapiera7fbd5a2016-06-16 09:17:49 -07003814 print('Issue description:')
Edward Lemur6c6827c2020-02-06 21:15:18 +00003815 print(cl.FetchDescription(pretty=True))
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003816 return 0
3817
3818
maruel@chromium.org39c0b222013-08-17 16:57:01 +00003819def colorize_CMDstatus_doc():
3820 """To be called once in main() to add colors to git cl status help."""
3821 colors = [i for i in dir(Fore) if i[0].isupper()]
3822
3823 def colorize_line(line):
3824 for color in colors:
3825 if color in line.upper():
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003826 # Extract whitespace first and the leading '-'.
maruel@chromium.org39c0b222013-08-17 16:57:01 +00003827 indent = len(line) - len(line.lstrip(' ')) + 1
3828 return line[:indent] + getattr(Fore, color) + line[indent:] + Fore.RESET
3829 return line
3830
3831 lines = CMDstatus.__doc__.splitlines()
3832 CMDstatus.__doc__ = '\n'.join(colorize_line(l) for l in lines)
3833
3834
phajdan.jre328cf92016-08-22 04:12:17 -07003835def write_json(path, contents):
Stefan Zager1306bd02017-06-22 19:26:46 -07003836 if path == '-':
3837 json.dump(contents, sys.stdout)
3838 else:
3839 with open(path, 'w') as f:
3840 json.dump(contents, f)
phajdan.jre328cf92016-08-22 04:12:17 -07003841
3842
maruel@chromium.org0633fb42013-08-16 20:06:14 +00003843@subcommand.usage('[issue_number]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003844@metrics.collector.collect_metrics('git cl issue')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003845def CMDissue(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00003846 """Sets or displays the current code review issue number.
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003847
3848 Pass issue number 0 to clear the current issue.
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00003849 """
dnj@chromium.org406c4402015-03-03 17:22:28 +00003850 parser.add_option('-r', '--reverse', action='store_true',
3851 help='Lookup the branch(es) for the specified issues. If '
3852 'no issues are specified, all branches with mapped '
3853 'issues will be listed.')
Stefan Zager1306bd02017-06-22 19:26:46 -07003854 parser.add_option('--json',
3855 help='Path to JSON output file, or "-" for stdout.')
dnj@chromium.org406c4402015-03-03 17:22:28 +00003856 options, args = parser.parse_args(args)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003857
dnj@chromium.org406c4402015-03-03 17:22:28 +00003858 if options.reverse:
3859 branches = RunGit(['for-each-ref', 'refs/heads',
Aaron Gablead64abd2017-12-04 09:49:13 -08003860 '--format=%(refname)']).splitlines()
dnj@chromium.org406c4402015-03-03 17:22:28 +00003861 # Reverse issue lookup.
3862 issue_branch_map = {}
Daniel Bratellb56a43a2018-09-06 15:49:03 +00003863
3864 git_config = {}
3865 for config in RunGit(['config', '--get-regexp',
3866 r'branch\..*issue']).splitlines():
3867 name, _space, val = config.partition(' ')
3868 git_config[name] = val
3869
dnj@chromium.org406c4402015-03-03 17:22:28 +00003870 for branch in branches:
Edward Lesmes50da7702020-03-30 19:23:43 +00003871 issue = git_config.get(
3872 'branch.%s.%s' % (scm.GIT.ShortBranchName(branch), ISSUE_CONFIG_KEY))
Edward Lemur52969c92020-02-06 18:15:28 +00003873 if issue:
3874 issue_branch_map.setdefault(int(issue), []).append(branch)
dnj@chromium.org406c4402015-03-03 17:22:28 +00003875 if not args:
Carlos Caballero81923d62020-07-06 18:22:27 +00003876 args = sorted(issue_branch_map.keys())
phajdan.jre328cf92016-08-22 04:12:17 -07003877 result = {}
dnj@chromium.org406c4402015-03-03 17:22:28 +00003878 for issue in args:
Lei Zhang5a368d42019-03-25 23:18:19 +00003879 try:
3880 issue_num = int(issue)
3881 except ValueError:
3882 print('ERROR cannot parse issue number: %s' % issue, file=sys.stderr)
dnj@chromium.org406c4402015-03-03 17:22:28 +00003883 continue
Lei Zhang5a368d42019-03-25 23:18:19 +00003884 result[issue_num] = issue_branch_map.get(issue_num)
vapiera7fbd5a2016-06-16 09:17:49 -07003885 print('Branch for issue number %s: %s' % (
Lei Zhang5a368d42019-03-25 23:18:19 +00003886 issue, ', '.join(issue_branch_map.get(issue_num) or ('None',))))
phajdan.jre328cf92016-08-22 04:12:17 -07003887 if options.json:
3888 write_json(options.json, result)
Aaron Gable78753da2017-06-15 10:35:49 -07003889 return 0
3890
3891 if len(args) > 0:
Edward Lemurf38bc172019-09-03 21:02:13 +00003892 issue = ParseIssueNumberArgument(args[0])
Aaron Gable78753da2017-06-15 10:35:49 -07003893 if not issue.valid:
3894 DieWithError('Pass a url or number to set the issue, 0 to unset it, '
3895 'or no argument to list it.\n'
3896 'Maybe you want to run git cl status?')
Edward Lemurf38bc172019-09-03 21:02:13 +00003897 cl = Changelist()
Aaron Gable78753da2017-06-15 10:35:49 -07003898 cl.SetIssue(issue.issue)
dnj@chromium.org406c4402015-03-03 17:22:28 +00003899 else:
Edward Lemurf38bc172019-09-03 21:02:13 +00003900 cl = Changelist()
Aaron Gable78753da2017-06-15 10:35:49 -07003901 print('Issue number: %s (%s)' % (cl.GetIssue(), cl.GetIssueURL()))
3902 if options.json:
3903 write_json(options.json, {
Nodir Turakulov27379632021-03-17 18:53:29 +00003904 'gerrit_host': cl.GetGerritHost(),
3905 'gerrit_project': cl.GetGerritProject(),
Aaron Gable78753da2017-06-15 10:35:49 -07003906 'issue_url': cl.GetIssueURL(),
Nodir Turakulov27379632021-03-17 18:53:29 +00003907 'issue': cl.GetIssue(),
Aaron Gable78753da2017-06-15 10:35:49 -07003908 })
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00003909 return 0
3910
3911
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003912@metrics.collector.collect_metrics('git cl comments')
maruel@chromium.org9977a2e2012-06-06 22:30:56 +00003913def CMDcomments(parser, args):
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003914 """Shows or posts review comments for any changelist."""
3915 parser.add_option('-a', '--add-comment', dest='comment',
3916 help='comment to add to an issue')
Sergiy Byelozyorovcb629a42018-10-28 19:20:39 +00003917 parser.add_option('-p', '--publish', action='store_true',
3918 help='marks CL as ready and sends comment to reviewers')
Andrii Shyshkalov0d6b46e2017-03-17 22:23:22 +01003919 parser.add_option('-i', '--issue', dest='issue',
Edward Lemurf38bc172019-09-03 21:02:13 +00003920 help='review issue id (defaults to current issue).')
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07003921 parser.add_option('-m', '--machine-readable', dest='readable',
3922 action='store_false', default=True,
3923 help='output comments in a format compatible with '
3924 'editor parsing')
smut@google.comc85ac942015-09-15 16:34:43 +00003925 parser.add_option('-j', '--json-file',
Stefan Zager1306bd02017-06-22 19:26:46 -07003926 help='File to write JSON summary to, or "-" for stdout')
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003927 options, args = parser.parse_args(args)
maruel@chromium.org9977a2e2012-06-06 22:30:56 +00003928
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003929 issue = None
3930 if options.issue:
3931 try:
3932 issue = int(options.issue)
3933 except ValueError:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00003934 DieWithError('A review issue ID is expected to be a number.')
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003935
Edward Lemur934836a2019-09-09 20:16:54 +00003936 cl = Changelist(issue=issue)
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003937
3938 if options.comment:
Sergiy Byelozyorovcb629a42018-10-28 19:20:39 +00003939 cl.AddComment(options.comment, options.publish)
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003940 return 0
3941
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07003942 summary = sorted(cl.GetCommentsSummary(readable=options.readable),
3943 key=lambda c: c.date)
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01003944 for comment in summary:
3945 if comment.disapproval:
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003946 color = Fore.RED
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01003947 elif comment.approval:
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003948 color = Fore.GREEN
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01003949 elif comment.sender == cl.GetIssueOwner():
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003950 color = Fore.MAGENTA
Quinten Yearsley0e617c02019-02-20 00:37:03 +00003951 elif comment.autogenerated:
3952 color = Fore.CYAN
apavlov@chromium.orge4efd512014-11-05 09:05:29 +00003953 else:
3954 color = Fore.BLUE
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01003955 print('\n%s%s %s%s\n%s' % (
3956 color,
3957 comment.date.strftime('%Y-%m-%d %H:%M:%S UTC'),
3958 comment.sender,
3959 Fore.RESET,
3960 '\n'.join(' ' + l for l in comment.message.strip().splitlines())))
3961
smut@google.comc85ac942015-09-15 16:34:43 +00003962 if options.json_file:
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01003963 def pre_serialize(c):
Edward Lemur79d4f992019-11-11 23:49:02 +00003964 dct = c._asdict().copy()
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01003965 dct['date'] = dct['date'].strftime('%Y-%m-%d %H:%M:%S.%f')
3966 return dct
Edward Lemur79d4f992019-11-11 23:49:02 +00003967 write_json(options.json_file, [pre_serialize(x) for x in summary])
maruel@chromium.org9977a2e2012-06-06 22:30:56 +00003968 return 0
3969
3970
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00003971@subcommand.usage('[codereview url or issue id]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00003972@metrics.collector.collect_metrics('git cl description')
rsesek@chromium.orgeec76592013-05-20 16:27:57 +00003973def CMDdescription(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00003974 """Brings up the editor for the current CL's description."""
smut@google.com34fb6b12015-07-13 20:03:26 +00003975 parser.add_option('-d', '--display', action='store_true',
3976 help='Display the description instead of opening an editor')
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00003977 parser.add_option('-n', '--new-description',
dnjba1b0f32016-09-02 12:37:42 -07003978 help='New description to set for this issue (- for stdin, '
3979 '+ to load from local commit HEAD)')
dsansomee2d6fd92016-09-08 00:10:47 -07003980 parser.add_option('-f', '--force', action='store_true',
3981 help='Delete any unpublished Gerrit edits for this issue '
3982 'without prompting')
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00003983
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00003984 options, args = parser.parse_args(args)
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00003985
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01003986 target_issue_arg = None
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00003987 if len(args) > 0:
Edward Lemurf38bc172019-09-03 21:02:13 +00003988 target_issue_arg = ParseIssueNumberArgument(args[0])
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01003989 if not target_issue_arg.valid:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00003990 parser.error('Invalid issue ID or URL.')
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00003991
Edward Lemur934836a2019-09-09 20:16:54 +00003992 kwargs = {}
Andrii Shyshkalov8039be72017-01-26 09:38:18 +01003993 if target_issue_arg:
3994 kwargs['issue'] = target_issue_arg.issue
3995 kwargs['codereview_host'] = target_issue_arg.hostname
martiniss6eda05f2016-06-30 10:18:35 -07003996
3997 cl = Changelist(**kwargs)
rsesek@chromium.orgeec76592013-05-20 16:27:57 +00003998 if not cl.GetIssue():
3999 DieWithError('This branch has no associated changelist.')
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004000
Edward Lemur678a6842019-10-03 22:25:05 +00004001 if args and not args[0].isdigit():
Edward Lemurf38bc172019-09-03 21:02:13 +00004002 logging.info('canonical issue/change URL: %s\n', cl.GetIssueURL())
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004003
Edward Lemur6c6827c2020-02-06 21:15:18 +00004004 description = ChangeDescription(cl.FetchDescription())
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00004005
smut@google.com34fb6b12015-07-13 20:03:26 +00004006 if options.display:
vapiera7fbd5a2016-06-16 09:17:49 -07004007 print(description.description)
smut@google.com34fb6b12015-07-13 20:03:26 +00004008 return 0
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00004009
4010 if options.new_description:
4011 text = options.new_description
4012 if text == '-':
4013 text = '\n'.join(l.rstrip() for l in sys.stdin)
dnjba1b0f32016-09-02 12:37:42 -07004014 elif text == '+':
4015 base_branch = cl.GetCommonAncestorWithUpstream()
Edward Lemura12175c2020-03-09 16:58:26 +00004016 text = _create_description_from_log([base_branch])
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00004017
4018 description.set_description(text)
4019 else:
Edward Lemurf38bc172019-09-03 21:02:13 +00004020 description.prompt()
Edward Lemur6c6827c2020-02-06 21:15:18 +00004021 if cl.FetchDescription().strip() != description.description:
dsansomee2d6fd92016-09-08 00:10:47 -07004022 cl.UpdateDescription(description.description, force=options.force)
rsesek@chromium.orgeec76592013-05-20 16:27:57 +00004023 return 0
4024
4025
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004026@metrics.collector.collect_metrics('git cl lint')
thestig@chromium.org44202a22014-03-11 19:22:18 +00004027def CMDlint(parser, args):
4028 """Runs cpplint on the current changelist."""
tzik@chromium.orgf204d4b2014-03-13 07:40:55 +00004029 parser.add_option('--filter', action='append', metavar='-x,+y',
4030 help='Comma-separated list of cpplint\'s category-filters')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004031 options, args = parser.parse_args(args)
thestig@chromium.org44202a22014-03-11 19:22:18 +00004032
4033 # Access to a protected member _XX of a client class
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -08004034 # pylint: disable=protected-access
thestig@chromium.org44202a22014-03-11 19:22:18 +00004035 try:
4036 import cpplint
4037 import cpplint_chromium
4038 except ImportError:
vapiera7fbd5a2016-06-16 09:17:49 -07004039 print('Your depot_tools is missing cpplint.py and/or cpplint_chromium.py.')
thestig@chromium.org44202a22014-03-11 19:22:18 +00004040 return 1
4041
4042 # Change the current working directory before calling lint so that it
4043 # shows the correct base.
4044 previous_cwd = os.getcwd()
4045 os.chdir(settings.GetRoot())
4046 try:
Edward Lemur934836a2019-09-09 20:16:54 +00004047 cl = Changelist()
Edward Lemur2c62b332020-03-12 22:12:33 +00004048 files = cl.GetAffectedFiles(cl.GetCommonAncestorWithUpstream())
thestig@chromium.org5839eb52014-05-30 16:20:51 +00004049 if not files:
vapiera7fbd5a2016-06-16 09:17:49 -07004050 print('Cannot lint an empty CL')
thestig@chromium.org5839eb52014-05-30 16:20:51 +00004051 return 1
thestig@chromium.org44202a22014-03-11 19:22:18 +00004052
Lei Zhangb8c62cf2020-07-15 20:09:37 +00004053 # Process cpplint arguments, if any.
4054 filters = presubmit_canned_checks.GetCppLintFilters(options.filter)
4055 command = ['--filter=' + ','.join(filters)] + args + files
tzik@chromium.orgf204d4b2014-03-13 07:40:55 +00004056 filenames = cpplint.ParseArguments(command)
thestig@chromium.org44202a22014-03-11 19:22:18 +00004057
Lei Zhang379d1ad2020-07-15 19:40:06 +00004058 include_regex = re.compile(settings.GetLintRegex())
4059 ignore_regex = re.compile(settings.GetLintIgnoreRegex())
thestig@chromium.org44202a22014-03-11 19:22:18 +00004060 extra_check_functions = [cpplint_chromium.CheckPointerDeclarationWhitespace]
4061 for filename in filenames:
Lei Zhang379d1ad2020-07-15 19:40:06 +00004062 if not include_regex.match(filename):
vapiera7fbd5a2016-06-16 09:17:49 -07004063 print('Skipping file %s' % filename)
Lei Zhang379d1ad2020-07-15 19:40:06 +00004064 continue
4065
4066 if ignore_regex.match(filename):
4067 print('Ignoring file %s' % filename)
4068 continue
4069
4070 cpplint.ProcessFile(filename, cpplint._cpplint_state.verbose_level,
4071 extra_check_functions)
thestig@chromium.org44202a22014-03-11 19:22:18 +00004072 finally:
4073 os.chdir(previous_cwd)
vapiera7fbd5a2016-06-16 09:17:49 -07004074 print('Total errors found: %d\n' % cpplint._cpplint_state.error_count)
thestig@chromium.org44202a22014-03-11 19:22:18 +00004075 if cpplint._cpplint_state.error_count != 0:
4076 return 1
4077 return 0
4078
4079
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004080@metrics.collector.collect_metrics('git cl presubmit')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004081def CMDpresubmit(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004082 """Runs presubmit tests on the current changelist."""
ilevy@chromium.org375a9022013-01-07 01:12:05 +00004083 parser.add_option('-u', '--upload', action='store_true',
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004084 help='Run upload hook instead of the push hook')
ilevy@chromium.org375a9022013-01-07 01:12:05 +00004085 parser.add_option('-f', '--force', action='store_true',
sbc@chromium.org495ad152012-09-04 23:07:42 +00004086 help='Run checks even if tree is dirty')
Aaron Gable8076c282017-11-29 14:39:41 -08004087 parser.add_option('--all', action='store_true',
4088 help='Run checks against all files, not just modified ones')
Josip Sokcevic017544d2022-03-31 23:47:53 +00004089 parser.add_option('--files',
4090 nargs=1,
4091 help='Semicolon-separated list of files to be marked as '
4092 'modified when executing presubmit or post-upload hooks. '
4093 'fnmatch wildcards can also be used.')
Edward Lesmes8e282792018-04-03 18:50:29 -04004094 parser.add_option('--parallel', action='store_true',
4095 help='Run all tests specified by input_api.RunTests in all '
4096 'PRESUBMIT files in parallel.')
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00004097 parser.add_option('--resultdb', action='store_true',
4098 help='Run presubmit checks in the ResultSink environment '
4099 'and send results to the ResultDB database.')
Saagar Sanghavi03b15132020-08-10 16:43:41 +00004100 parser.add_option('--realm', help='LUCI realm if reporting to ResultDB')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004101 options, args = parser.parse_args(args)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004102
sbc@chromium.org71437c02015-04-09 19:29:40 +00004103 if not options.force and git_common.is_dirty_git_tree('presubmit'):
vapiera7fbd5a2016-06-16 09:17:49 -07004104 print('use --force to check even if tree is dirty.')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004105 return 1
4106
Edward Lemur934836a2019-09-09 20:16:54 +00004107 cl = Changelist()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004108 if args:
4109 base_branch = args[0]
4110 else:
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +00004111 # Default to diffing against the common ancestor of the upstream branch.
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00004112 base_branch = cl.GetCommonAncestorWithUpstream()
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004113
Gregory Nisbet29d5cf82020-02-27 08:16:58 +00004114 if cl.GetIssue():
4115 description = cl.FetchDescription()
Aaron Gable8076c282017-11-29 14:39:41 -08004116 else:
Edward Lemura12175c2020-03-09 16:58:26 +00004117 description = _create_description_from_log([base_branch])
Aaron Gable8076c282017-11-29 14:39:41 -08004118
Josip Sokcevic017544d2022-03-31 23:47:53 +00004119 cl.RunHook(committing=not options.upload,
4120 may_prompt=False,
4121 verbose=options.verbose,
4122 parallel=options.parallel,
4123 upstream=base_branch,
4124 description=description,
4125 all_files=options.all,
4126 files=options.files,
4127 resultdb=options.resultdb,
4128 realm=options.realm)
dpranke@chromium.org0a2bb372011-03-25 01:16:22 +00004129 return 0
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004130
4131
tandrii@chromium.org65874e12016-03-04 12:03:02 +00004132def GenerateGerritChangeId(message):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004133 """Returns the Change ID footer value (Ixxxxxx...xxx).
tandrii@chromium.org65874e12016-03-04 12:03:02 +00004134
4135 Works the same way as
4136 https://gerrit-review.googlesource.com/tools/hooks/commit-msg
4137 but can be called on demand on all platforms.
4138
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004139 The basic idea is to generate git hash of a state of the tree, original
4140 commit message, author/committer info and timestamps.
tandrii@chromium.org65874e12016-03-04 12:03:02 +00004141 """
4142 lines = []
4143 tree_hash = RunGitSilent(['write-tree'])
4144 lines.append('tree %s' % tree_hash.strip())
4145 code, parent = RunGitWithCode(['rev-parse', 'HEAD~0'], suppress_stderr=False)
4146 if code == 0:
4147 lines.append('parent %s' % parent.strip())
4148 author = RunGitSilent(['var', 'GIT_AUTHOR_IDENT'])
4149 lines.append('author %s' % author.strip())
4150 committer = RunGitSilent(['var', 'GIT_COMMITTER_IDENT'])
4151 lines.append('committer %s' % committer.strip())
4152 lines.append('')
4153 # Note: Gerrit's commit-hook actually cleans message of some lines and
4154 # whitespace. This code is not doing this, but it clearly won't decrease
4155 # entropy.
4156 lines.append(message)
4157 change_hash = RunCommand(['git', 'hash-object', '-t', 'commit', '--stdin'],
Raul Tambreb946b232019-03-26 14:48:46 +00004158 stdin=('\n'.join(lines)).encode())
tandrii@chromium.org65874e12016-03-04 12:03:02 +00004159 return 'I%s' % change_hash.strip()
4160
4161
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01004162def GetTargetRef(remote, remote_branch, target_branch):
wittman@chromium.org455dc922015-01-26 20:15:50 +00004163 """Computes the remote branch ref to use for the CL.
4164
4165 Args:
4166 remote (str): The git remote for the CL.
4167 remote_branch (str): The git remote branch for the CL.
4168 target_branch (str): The target branch specified by the user.
wittman@chromium.org455dc922015-01-26 20:15:50 +00004169 """
4170 if not (remote and remote_branch):
4171 return None
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00004172
wittman@chromium.org455dc922015-01-26 20:15:50 +00004173 if target_branch:
Quinten Yearsley0c62da92017-05-31 13:39:42 -07004174 # Canonicalize branch references to the equivalent local full symbolic
wittman@chromium.org455dc922015-01-26 20:15:50 +00004175 # refs, which are then translated into the remote full symbolic refs
4176 # below.
4177 if '/' not in target_branch:
4178 remote_branch = 'refs/remotes/%s/%s' % (remote, target_branch)
4179 else:
4180 prefix_replacements = (
4181 ('^((refs/)?remotes/)?branch-heads/', 'refs/remotes/branch-heads/'),
4182 ('^((refs/)?remotes/)?%s/' % remote, 'refs/remotes/%s/' % remote),
4183 ('^(refs/)?heads/', 'refs/remotes/%s/' % remote),
4184 )
4185 match = None
4186 for regex, replacement in prefix_replacements:
4187 match = re.search(regex, target_branch)
4188 if match:
4189 remote_branch = target_branch.replace(match.group(0), replacement)
4190 break
4191 if not match:
4192 # This is a branch path but not one we recognize; use as-is.
4193 remote_branch = target_branch
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +00004194 # pylint: disable=consider-using-get
rmistry@google.comc68112d2015-03-03 12:48:06 +00004195 elif remote_branch in REFS_THAT_ALIAS_TO_OTHER_REFS:
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +00004196 # pylint: enable=consider-using-get
rmistry@google.comc68112d2015-03-03 12:48:06 +00004197 # Handle the refs that need to land in different refs.
4198 remote_branch = REFS_THAT_ALIAS_TO_OTHER_REFS[remote_branch]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00004199
wittman@chromium.org455dc922015-01-26 20:15:50 +00004200 # Create the true path to the remote branch.
4201 # Does the following translation:
4202 # * refs/remotes/origin/refs/diff/test -> refs/diff/test
Josip Sokcevicc39ab992020-09-24 20:09:15 +00004203 # * refs/remotes/origin/main -> refs/heads/main
wittman@chromium.org455dc922015-01-26 20:15:50 +00004204 # * refs/remotes/branch-heads/test -> refs/branch-heads/test
4205 if remote_branch.startswith('refs/remotes/%s/refs/' % remote):
4206 remote_branch = remote_branch.replace('refs/remotes/%s/' % remote, '')
4207 elif remote_branch.startswith('refs/remotes/%s/' % remote):
4208 remote_branch = remote_branch.replace('refs/remotes/%s/' % remote,
4209 'refs/heads/')
4210 elif remote_branch.startswith('refs/remotes/branch-heads'):
4211 remote_branch = remote_branch.replace('refs/remotes/', 'refs/')
Andrii Shyshkalov768f1d82016-12-08 15:10:13 +01004212
wittman@chromium.org455dc922015-01-26 20:15:50 +00004213 return remote_branch
4214
4215
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00004216def cleanup_list(l):
4217 """Fixes a list so that comma separated items are put as individual items.
4218
4219 So that "--reviewers joe@c,john@c --reviewers joa@c" results in
4220 options.reviewers == sorted(['joe@c', 'john@c', 'joa@c']).
4221 """
4222 items = sum((i.split(',') for i in l), [])
4223 stripped_items = (i.strip() for i in items)
4224 return sorted(filter(None, stripped_items))
4225
4226
Aaron Gable4db38df2017-11-03 14:59:07 -07004227@subcommand.usage('[flags]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004228@metrics.collector.collect_metrics('git cl upload')
ukai@chromium.orge8077812012-02-03 03:41:46 +00004229def CMDupload(parser, args):
rmistry@google.com78948ed2015-07-08 23:09:57 +00004230 """Uploads the current changelist to codereview.
4231
4232 Can skip dependency patchset uploads for a branch by running:
4233 git config branch.branch_name.skip-deps-uploads True
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004234 To unset, run:
rmistry@google.com78948ed2015-07-08 23:09:57 +00004235 git config --unset branch.branch_name.skip-deps-uploads
4236 Can also set the above globally by using the --global flag.
Dominic Battre7d1c4842017-10-27 09:17:28 +02004237
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004238 If the name of the checked out branch starts with "bug-" or "fix-" followed
4239 by a bug number, this bug number is automatically populated in the CL
Dominic Battre7d1c4842017-10-27 09:17:28 +02004240 description.
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004241
4242 If subject contains text in square brackets or has "<text>: " prefix, such
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004243 text(s) is treated as Gerrit hashtags. For example, CLs with subjects:
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004244 [git-cl] add support for hashtags
4245 Foo bar: implement foo
4246 will be hashtagged with "git-cl" and "foo-bar" respectively.
rmistry@google.com78948ed2015-07-08 23:09:57 +00004247 """
ukai@chromium.orge8077812012-02-03 03:41:46 +00004248 parser.add_option('--bypass-hooks', action='store_true', dest='bypass_hooks',
4249 help='bypass upload presubmit hook')
brettw@chromium.orgb65c43c2013-06-10 22:04:49 +00004250 parser.add_option('--bypass-watchlists', action='store_true',
4251 dest='bypass_watchlists',
4252 help='bypass watchlists auto CC-ing reviewers')
Aaron Gablef7543cd2017-07-20 14:26:31 -07004253 parser.add_option('-f', '--force', action='store_true', dest='force',
ukai@chromium.orge8077812012-02-03 03:41:46 +00004254 help="force yes to questions (don't prompt)")
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004255 parser.add_option('--message', '-m', dest='message',
4256 help='message for patchset')
tandriif9aefb72016-07-01 09:06:51 -07004257 parser.add_option('-b', '--bug',
4258 help='pre-populate the bug number(s) for this issue. '
4259 'If several, separate with commas')
tandriib80458a2016-06-23 12:20:07 -07004260 parser.add_option('--message-file', dest='message_file',
4261 help='file which contains message for patchset')
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004262 parser.add_option('--title', '-t', dest='title',
4263 help='title for patchset')
Mario Bianuccicebfb4e2020-07-22 23:08:16 +00004264 parser.add_option('-T', '--skip-title', action='store_true',
4265 dest='skip_title',
4266 help='Use the most recent commit message as the title of '
4267 'the patchset')
ukai@chromium.orge8077812012-02-03 03:41:46 +00004268 parser.add_option('-r', '--reviewers',
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00004269 action='append', default=[],
ukai@chromium.orge8077812012-02-03 03:41:46 +00004270 help='reviewer email addresses')
Robert Iannucci6c98dc62017-04-18 11:38:00 -07004271 parser.add_option('--tbrs',
4272 action='append', default=[],
4273 help='TBR email addresses')
ukai@chromium.orge8077812012-02-03 03:41:46 +00004274 parser.add_option('--cc',
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00004275 action='append', default=[],
ukai@chromium.orge8077812012-02-03 03:41:46 +00004276 help='cc email addresses')
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004277 parser.add_option('--hashtag', dest='hashtags',
4278 action='append', default=[],
4279 help=('Gerrit hashtag for new CL; '
4280 'can be applied multiple times'))
adamk@chromium.org36f47302013-04-05 01:08:31 +00004281 parser.add_option('-s', '--send-mail', action='store_true',
Aaron Gable59f48512017-01-12 10:54:46 -08004282 help='send email to reviewer(s) and cc(s) immediately')
ukai@chromium.org8ef7ab22012-11-28 04:24:52 +00004283 parser.add_option('--target_branch',
pgervais@chromium.orgb9f27512014-08-08 15:52:33 +00004284 '--target-branch',
wittman@chromium.org455dc922015-01-26 20:15:50 +00004285 metavar='TARGET',
4286 help='Apply CL to remote ref TARGET. ' +
Josip Sokcevicc39ab992020-09-24 20:09:15 +00004287 'Default: remote branch head, or main')
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00004288 parser.add_option('--squash', action='store_true',
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004289 help='Squash multiple commits into one')
Mike Frysingera989d552019-08-14 20:51:23 +00004290 parser.add_option('--no-squash', action='store_false', dest='squash',
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004291 help='Don\'t squash multiple commits into one')
rmistry9eadede2016-09-19 11:22:43 -07004292 parser.add_option('--topic', default=None,
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004293 help='Topic to specify when uploading')
Robert Iannuccif2708bd2017-04-17 15:49:02 -07004294 parser.add_option('--tbr-owners', dest='add_owners_to', action='store_const',
4295 const='TBR', help='add a set of OWNERS to TBR')
4296 parser.add_option('--r-owners', dest='add_owners_to', action='store_const',
4297 const='R', help='add a set of OWNERS to R')
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +00004298 parser.add_option('-c', '--use-commit-queue', action='store_true',
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004299 default=False,
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +00004300 help='tell the CQ to commit this patchset; '
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004301 'implies --send-mail')
4302 parser.add_option('-d', '--cq-dry-run',
4303 action='store_true', default=False,
rmistry@google.comef966222015-04-07 11:15:01 +00004304 help='Send the patchset to do a CQ dry run right after '
4305 'upload.')
Greg Gutermanbe5fccd2021-06-14 17:58:20 +00004306 parser.add_option(
4307 '-q',
4308 '--cq-quick-run',
4309 action='store_true',
4310 default=False,
4311 help='Send the patchset to do a CQ quick run right after '
4312 'upload (https://source.chromium.org/chromium/chromium/src/+/main:do'
4313 'cs/cq_quick_run.md) (chromium only).')
Edward Lesmes10c3dd62021-02-08 21:13:57 +00004314 parser.add_option('--set-bot-commit', action='store_true',
4315 help=optparse.SUPPRESS_HELP)
Andrii Shyshkalov71f0da32019-07-15 22:45:18 +00004316 parser.add_option('--preserve-tryjobs', action='store_true',
4317 help='instruct the CQ to let tryjobs running even after '
4318 'new patchsets are uploaded instead of canceling '
4319 'prior patchset\' tryjobs')
rmistry@google.com2dd99862015-06-22 12:22:18 +00004320 parser.add_option('--dependencies', action='store_true',
4321 help='Uploads CLs of all the local branches that depend on '
4322 'the current branch')
Ravi Mistry31e7d562018-04-02 12:53:57 -04004323 parser.add_option('-a', '--enable-auto-submit', action='store_true',
4324 help='Sends your change to the CQ after an approval. Only '
4325 'works on repos that have the Auto-Submit label '
4326 'enabled')
Edward Lesmes8e282792018-04-03 18:50:29 -04004327 parser.add_option('--parallel', action='store_true',
4328 help='Run all tests specified by input_api.RunTests in all '
4329 'PRESUBMIT files in parallel.')
Sergiy Byelozyorov1aa405f2018-09-18 17:38:43 +00004330 parser.add_option('--no-autocc', action='store_true',
4331 help='Disables automatic addition of CC emails')
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -08004332 parser.add_option('--private', action='store_true',
Sergiy Byelozyorov1aa405f2018-09-18 17:38:43 +00004333 help='Set the review private. This implies --no-autocc.')
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004334 parser.add_option('-R', '--retry-failed', action='store_true',
4335 help='Retry failed tryjobs from old patchset immediately '
4336 'after uploading new patchset. Cannot be used with '
4337 '--use-commit-queue or --cq-dry-run.')
4338 parser.add_option('--buildbucket-host', default='cr-buildbucket.appspot.com',
4339 help='Host of buildbucket. The default host is %default.')
Dan Beamd8b04ca2019-10-10 21:23:26 +00004340 parser.add_option('--fixed', '-x',
4341 help='List of bugs that will be commented on and marked '
4342 'fixed (pre-populates "Fixed:" tag). Same format as '
4343 '-b option / "Bug:" tag. If fixing several issues, '
4344 'separate with commas.')
Josipe827b0f2020-01-30 00:07:20 +00004345 parser.add_option('--edit-description', action='store_true', default=False,
4346 help='Modify description before upload. Cannot be used '
4347 'with --force. It is a noop when --no-squash is set '
4348 'or a new commit is created.')
Ng Zhi Ancdaf0be2020-05-27 20:57:28 +00004349 parser.add_option('--git-completion-helper', action="store_true",
4350 help=optparse.SUPPRESS_HELP)
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00004351 parser.add_option('--resultdb', action='store_true',
4352 help='Run presubmit checks in the ResultSink environment '
4353 'and send results to the ResultDB database.')
Saagar Sanghavi03b15132020-08-10 16:43:41 +00004354 parser.add_option('--realm', help='LUCI realm if reporting to ResultDB')
Josip Sokcevicf2cfd3d2021-03-30 18:39:18 +00004355 parser.add_option('-o',
4356 '--push-options',
4357 action='append',
4358 default=[],
4359 help='Transmit the given string to the server when '
4360 'performing git push (pass-through). See git-push '
4361 'documentation for more details.')
Gregory Nisbet48d9e1e2021-04-15 23:35:54 +00004362 parser.add_option('--no-add-changeid',
4363 action='store_true',
4364 dest='no_add_changeid',
4365 help='Do not add change-ids to messages.')
Sergiy Byelozyorov1aa405f2018-09-18 17:38:43 +00004366
rmistry@google.com2dd99862015-06-22 12:22:18 +00004367 orig_args = args
ukai@chromium.orge8077812012-02-03 03:41:46 +00004368 (options, args) = parser.parse_args(args)
4369
Ng Zhi Ancdaf0be2020-05-27 20:57:28 +00004370 if options.git_completion_helper:
Edward Lesmesb7db1832020-06-22 20:22:27 +00004371 print(' '.join(opt.get_opt_string() for opt in parser.option_list
4372 if opt.help != optparse.SUPPRESS_HELP))
4373 return
Ng Zhi Ancdaf0be2020-05-27 20:57:28 +00004374
sbc@chromium.org71437c02015-04-09 19:29:40 +00004375 if git_common.is_dirty_git_tree('upload'):
ukai@chromium.orge8077812012-02-03 03:41:46 +00004376 return 1
4377
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00004378 options.reviewers = cleanup_list(options.reviewers)
Robert Iannucci6c98dc62017-04-18 11:38:00 -07004379 options.tbrs = cleanup_list(options.tbrs)
maruel@chromium.orgeb52a5c2013-04-10 23:17:09 +00004380 options.cc = cleanup_list(options.cc)
4381
Josipe827b0f2020-01-30 00:07:20 +00004382 if options.edit_description and options.force:
4383 parser.error('Only one of --force and --edit-description allowed')
4384
tandriib80458a2016-06-23 12:20:07 -07004385 if options.message_file:
4386 if options.message:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004387 parser.error('Only one of --message and --message-file allowed.')
tandriib80458a2016-06-23 12:20:07 -07004388 options.message = gclient_utils.FileRead(options.message_file)
tandriib80458a2016-06-23 12:20:07 -07004389
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004390 if ([options.cq_dry_run,
Greg Gutermanbe5fccd2021-06-14 17:58:20 +00004391 options.cq_quick_run,
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004392 options.use_commit_queue,
4393 options.retry_failed].count(True) > 1):
Greg Gutermanbe5fccd2021-06-14 17:58:20 +00004394 parser.error('Only one of --use-commit-queue, --cq-dry-run, --cq-quick-run '
4395 'or --retry-failed is allowed.')
tandrii4d0545a2016-07-06 03:56:49 -07004396
Mario Bianuccicebfb4e2020-07-22 23:08:16 +00004397 if options.skip_title and options.title:
4398 parser.error('Only one of --title and --skip-title allowed.')
4399
Aaron Gableedbc4132017-09-11 13:22:28 -07004400 if options.use_commit_queue:
4401 options.send_mail = True
4402
Edward Lesmes0dd54822020-03-26 18:24:25 +00004403 if options.squash is None:
4404 # Load default for user, repo, squash=true, in this order.
4405 options.squash = settings.GetSquashGerritUploads()
4406
Josip Sokcevic1cabb172021-04-08 19:15:35 +00004407 cl = Changelist(branchref=options.target_branch)
Edward Lesmes7677e5c2020-02-19 20:39:03 +00004408 # Warm change details cache now to avoid RPCs later, reducing latency for
4409 # developers.
4410 if cl.GetIssue():
4411 cl._GetChangeDetail(
4412 ['DETAILED_ACCOUNTS', 'CURRENT_REVISION', 'CURRENT_COMMIT', 'LABELS'])
4413
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004414 if options.retry_failed and not cl.GetIssue():
4415 print('No previous patchsets, so --retry-failed has no effect.')
4416 options.retry_failed = False
Edward Lesmes7677e5c2020-02-19 20:39:03 +00004417
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004418 # cl.GetMostRecentPatchset uses cached information, and can return the last
4419 # patchset before upload. Calling it here makes it clear that it's the
4420 # last patchset before upload. Note that GetMostRecentPatchset will fail
4421 # if no CL has been uploaded yet.
4422 if options.retry_failed:
4423 patchset = cl.GetMostRecentPatchset()
Andrii Shyshkalov9f274432018-10-15 16:40:23 +00004424
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004425 ret = cl.CMDUpload(options, args, orig_args)
4426
4427 if options.retry_failed:
4428 if ret != 0:
4429 print('Upload failed, so --retry-failed has no effect.')
4430 return ret
Andrii Shyshkalov1ad58112019-10-08 01:46:14 +00004431 builds, _ = _fetch_latest_builds(
Edward Lemur5b929a42019-10-21 17:57:39 +00004432 cl, options.buildbucket_host, latest_patchset=patchset)
Edward Lemur45768512020-03-02 19:03:14 +00004433 jobs = _filter_failed_for_retry(builds)
4434 if len(jobs) == 0:
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004435 print('No failed tryjobs, so --retry-failed has no effect.')
4436 return ret
Quinten Yearsley777660f2020-03-04 23:37:06 +00004437 _trigger_tryjobs(cl, jobs, options, patchset + 1)
Quinten Yearsleya19d3532019-09-30 21:54:39 +00004438
4439 return ret
ukai@chromium.orge8077812012-02-03 03:41:46 +00004440
4441
Francois Dorayd42c6812017-05-30 15:10:20 -04004442@subcommand.usage('--description=<description file>')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004443@metrics.collector.collect_metrics('git cl split')
Francois Dorayd42c6812017-05-30 15:10:20 -04004444def CMDsplit(parser, args):
4445 """Splits a branch into smaller branches and uploads CLs.
4446
4447 Creates a branch and uploads a CL for each group of files modified in the
4448 current branch that share a common OWNERS file. In the CL description and
Edward Lemurac5c55f2020-02-29 00:17:16 +00004449 comment, the string '$directory', is replaced with the directory containing
4450 the shared OWNERS file.
Francois Dorayd42c6812017-05-30 15:10:20 -04004451 """
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004452 parser.add_option('-d', '--description', dest='description_file',
4453 help='A text file containing a CL description in which '
4454 '$directory will be replaced by each CL\'s directory.')
4455 parser.add_option('-c', '--comment', dest='comment_file',
4456 help='A text file containing a CL comment.')
4457 parser.add_option('-n', '--dry-run', dest='dry_run', action='store_true',
Chris Watkinsba28e462017-12-13 11:22:17 +11004458 default=False,
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004459 help='List the files and reviewers for each CL that would '
4460 'be created, but don\'t create branches or CLs.')
4461 parser.add_option('--cq-dry-run', action='store_true',
4462 help='If set, will do a cq dry run for each uploaded CL. '
4463 'Please be careful when doing this; more than ~10 CLs '
4464 'has the potential to overload our build '
4465 'infrastructure. Try to upload these not during high '
4466 'load times (usually 11-3 Mountain View time). Email '
4467 'infra-dev@chromium.org with any questions.')
Takuto Ikuta51eca592019-02-14 19:40:52 +00004468 parser.add_option('-a', '--enable-auto-submit', action='store_true',
4469 default=True,
4470 help='Sends your change to the CQ after an approval. Only '
4471 'works on repos that have the Auto-Submit label '
4472 'enabled')
Francois Dorayd42c6812017-05-30 15:10:20 -04004473 options, _ = parser.parse_args(args)
4474
4475 if not options.description_file:
4476 parser.error('No --description flag specified.')
4477
4478 def WrappedCMDupload(args):
4479 return CMDupload(OptionParser(), args)
4480
Edward Lemur2c62b332020-03-12 22:12:33 +00004481 return split_cl.SplitCl(
4482 options.description_file, options.comment_file, Changelist,
4483 WrappedCMDupload, options.dry_run, options.cq_dry_run,
4484 options.enable_auto_submit, settings.GetRoot())
Francois Dorayd42c6812017-05-30 15:10:20 -04004485
4486
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004487@subcommand.usage('DEPRECATED')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004488@metrics.collector.collect_metrics('git cl commit')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004489def CMDdcommit(parser, args):
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004490 """DEPRECATED: Used to commit the current changelist via git-svn."""
4491 message = ('git-cl no longer supports committing to SVN repositories via '
4492 'git-svn. You probably want to use `git cl land` instead.')
4493 print(message)
4494 return 1
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004495
4496
maruel@chromium.org0633fb42013-08-16 20:06:14 +00004497@subcommand.usage('[upstream branch to apply against]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004498@metrics.collector.collect_metrics('git cl land')
pgervais@chromium.orgcee6dc42014-05-07 17:04:03 +00004499def CMDland(parser, args):
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004500 """Commits the current changelist via git.
4501
4502 In case of Gerrit, uses Gerrit REST api to "submit" the issue, which pushes
4503 upstream and closes the issue automatically and atomically.
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004504 """
4505 parser.add_option('--bypass-hooks', action='store_true', dest='bypass_hooks',
4506 help='bypass upload presubmit hook')
Aaron Gablef7543cd2017-07-20 14:26:31 -07004507 parser.add_option('-f', '--force', action='store_true', dest='force',
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004508 help="force yes to questions (don't prompt)")
Edward Lesmes67b3faa2018-04-13 17:50:52 -04004509 parser.add_option('--parallel', action='store_true',
4510 help='Run all tests specified by input_api.RunTests in all '
4511 'PRESUBMIT files in parallel.')
Saagar Sanghavi03b15132020-08-10 16:43:41 +00004512 parser.add_option('--resultdb', action='store_true',
4513 help='Run presubmit checks in the ResultSink environment '
4514 'and send results to the ResultDB database.')
4515 parser.add_option('--realm', help='LUCI realm if reporting to ResultDB')
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004516 (options, args) = parser.parse_args(args)
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004517
Edward Lemur934836a2019-09-09 20:16:54 +00004518 cl = Changelist()
Aaron Gable1bc7bfe2016-12-19 10:08:14 -08004519
Robert Iannucci2e73d432018-03-14 01:10:47 -07004520 if not cl.GetIssue():
4521 DieWithError('You must upload the change first to Gerrit.\n'
4522 ' If you would rather have `git cl land` upload '
4523 'automatically for you, see http://crbug.com/642759')
Saagar Sanghavi03b15132020-08-10 16:43:41 +00004524 return cl.CMDLand(options.force, options.bypass_hooks, options.verbose,
4525 options.parallel, options.resultdb, options.realm)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004526
4527
dsinclair@chromium.orgfbed6562015-09-25 21:22:36 +00004528@subcommand.usage('<patch url or issue id or issue url>')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004529@metrics.collector.collect_metrics('git cl patch')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004530def CMDpatch(parser, args):
marq@chromium.orge5e59002013-10-02 23:21:25 +00004531 """Patches in a code review."""
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004532 parser.add_option('-b', dest='newbranch',
4533 help='create a new branch off trunk for the patch')
qsr@chromium.org1ef44af2013-10-16 16:24:32 +00004534 parser.add_option('-f', '--force', action='store_true',
Aaron Gable62619a32017-06-16 08:22:09 -07004535 help='overwrite state on the current or chosen branch')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004536 parser.add_option('-n', '--no-commit', action='store_true', dest='nocommit',
Edward Lemurf38bc172019-09-03 21:02:13 +00004537 help='don\'t commit after patch applies.')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004538
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00004539 group = optparse.OptionGroup(
4540 parser,
4541 'Options for continuing work on the current issue uploaded from a '
4542 'different clone (e.g. different machine). Must be used independently '
4543 'from the other options. No issue number should be specified, and the '
4544 'branch must have an issue number associated with it')
4545 group.add_option('--reapply', action='store_true', dest='reapply',
4546 help='Reset the branch and reapply the issue.\n'
4547 'CAUTION: This will undo any local changes in this '
4548 'branch')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004549
4550 group.add_option('--pull', action='store_true', dest='pull',
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00004551 help='Performs a pull before reapplying.')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004552 parser.add_option_group(group)
4553
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004554 (options, args) = parser.parse_args(args)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004555
Andrii Shyshkalov18975322017-01-25 16:44:13 +01004556 if options.reapply:
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004557 if options.newbranch:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004558 parser.error('--reapply works on the current branch only.')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004559 if len(args) > 0:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004560 parser.error('--reapply implies no additional arguments.')
dsinclair@chromium.orgfbed6562015-09-25 21:22:36 +00004561
Edward Lemur934836a2019-09-09 20:16:54 +00004562 cl = Changelist()
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004563 if not cl.GetIssue():
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004564 parser.error('Current branch must have an associated issue.')
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004565
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004566 upstream = cl.GetUpstreamBranch()
Andrii Shyshkalov18975322017-01-25 16:44:13 +01004567 if upstream is None:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004568 parser.error('No upstream branch specified. Cannot reset branch.')
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004569
4570 RunGit(['reset', '--hard', upstream])
4571 if options.pull:
4572 RunGit(['pull'])
mtrofin@chromium.org1d88dd32016-02-04 16:25:12 +00004573
Edward Lemur678a6842019-10-03 22:25:05 +00004574 target_issue_arg = ParseIssueNumberArgument(cl.GetIssue())
Bruce Dawsonf362f6f2021-02-18 23:15:17 +00004575 return cl.CMDPatchWithParsedIssue(target_issue_arg, options.nocommit, False,
4576 False)
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004577
4578 if len(args) != 1 or not args[0]:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004579 parser.error('Must specify issue number or URL.')
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004580
Edward Lemurf38bc172019-09-03 21:02:13 +00004581 target_issue_arg = ParseIssueNumberArgument(args[0])
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004582 if not target_issue_arg.valid:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004583 parser.error('Invalid issue ID or URL.')
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004584
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004585 # We don't want uncommitted changes mixed up with the patch.
4586 if git_common.is_dirty_git_tree('patch'):
dsinclair@chromium.orgfbed6562015-09-25 21:22:36 +00004587 return 1
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004588
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004589 if options.newbranch:
4590 if options.force:
4591 RunGit(['branch', '-D', options.newbranch],
4592 stderr=subprocess2.PIPE, error_ok=True)
Edward Lemur84101642020-02-21 21:40:34 +00004593 git_new_branch.create_new_branch(options.newbranch)
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004594
Edward Lemur678a6842019-10-03 22:25:05 +00004595 cl = Changelist(
4596 codereview_host=target_issue_arg.hostname, issue=target_issue_arg.issue)
tandrii@chromium.orgc2786d92016-05-31 19:53:50 +00004597
Edward Lemur678a6842019-10-03 22:25:05 +00004598 if not args[0].isdigit():
Edward Lemurf38bc172019-09-03 21:02:13 +00004599 print('canonical issue/change URL: %s\n' % cl.GetIssueURL())
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02004600
Bruce Dawsonf362f6f2021-02-18 23:15:17 +00004601 return cl.CMDPatchWithParsedIssue(target_issue_arg, options.nocommit,
4602 options.force, options.newbranch)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004603
4604
jochen@chromium.org3ec0d542014-01-14 20:00:03 +00004605def GetTreeStatus(url=None):
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004606 """Fetches the tree status and returns either 'open', 'closed',
4607 'unknown' or 'unset'."""
jochen@chromium.org3ec0d542014-01-14 20:00:03 +00004608 url = url or settings.GetTreeStatusUrl(error_ok=True)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004609 if url:
Daniel McArdle8b4eeff2020-07-20 17:02:47 +00004610 status = str(urllib.request.urlopen(url).read().lower())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004611 if status.find('closed') != -1 or status == '0':
4612 return 'closed'
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +00004613
4614 if status.find('open') != -1 or status == '1':
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004615 return 'open'
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +00004616
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004617 return 'unknown'
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004618 return 'unset'
4619
dpranke@chromium.org970c5222011-03-12 00:32:24 +00004620
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004621def GetTreeStatusReason():
4622 """Fetches the tree status from a json url and returns the message
4623 with the reason for the tree to be opened or closed."""
msb@chromium.orgbf1a7ba2011-02-01 16:21:46 +00004624 url = settings.GetTreeStatusUrl()
Daniel McArdle8b4eeff2020-07-20 17:02:47 +00004625 json_url = urllib.parse.urljoin(url, '/current?format=json')
Edward Lemur79d4f992019-11-11 23:49:02 +00004626 connection = urllib.request.urlopen(json_url)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004627 status = json.loads(connection.read())
4628 connection.close()
4629 return status['message']
4630
dpranke@chromium.org970c5222011-03-12 00:32:24 +00004631
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004632@metrics.collector.collect_metrics('git cl tree')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004633def CMDtree(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004634 """Shows the status of the tree."""
dpranke@chromium.org97ae58e2011-03-18 00:29:20 +00004635 _, args = parser.parse_args(args)
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004636 status = GetTreeStatus()
4637 if 'unset' == status:
vapiera7fbd5a2016-06-16 09:17:49 -07004638 print('You must configure your tree status URL by running "git cl config".')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004639 return 2
4640
vapiera7fbd5a2016-06-16 09:17:49 -07004641 print('The tree is %s' % status)
4642 print()
4643 print(GetTreeStatusReason())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004644 if status != 'open':
4645 return 1
4646 return 0
4647
4648
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004649@metrics.collector.collect_metrics('git cl try')
maruel@chromium.org15192402012-09-06 12:38:29 +00004650def CMDtry(parser, args):
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004651 """Triggers tryjobs using either Buildbucket or CQ dry run."""
4652 group = optparse.OptionGroup(parser, 'Tryjob options')
maruel@chromium.org15192402012-09-06 12:38:29 +00004653 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004654 '-b', '--bot', action='append',
4655 help=('IMPORTANT: specify ONE builder per --bot flag. Use it multiple '
4656 'times to specify multiple builders. ex: '
4657 '"-b win_rel -b win_layout". See '
4658 'the try server waterfall for the builders name and the tests '
4659 'available.'))
maruel@chromium.org15192402012-09-06 12:38:29 +00004660 group.add_option(
borenet6c0efe62016-10-19 08:13:29 -07004661 '-B', '--bucket', default='',
4662 help=('Buildbucket bucket to send the try requests.'))
4663 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004664 '-r', '--revision',
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004665 help='Revision to use for the tryjob; default: the revision will '
tandriif7b29d42016-10-07 08:45:41 -07004666 'be determined by the try recipe that builder runs, which usually '
Josip Sokcevicc39ab992020-09-24 20:09:15 +00004667 'defaults to HEAD of origin/master or origin/main')
maruel@chromium.org15192402012-09-06 12:38:29 +00004668 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004669 '-c', '--clobber', action='store_true', default=False,
tandriif7b29d42016-10-07 08:45:41 -07004670 help='Force a clobber before building; that is don\'t do an '
tandrii1838bad2016-10-06 00:10:52 -07004671 'incremental build')
maruel@chromium.org15192402012-09-06 12:38:29 +00004672 group.add_option(
Greg Gutermanbe5fccd2021-06-14 17:58:20 +00004673 '-q',
4674 '--quick-run',
4675 action='store_true',
4676 default=False,
4677 help='trigger in quick run mode '
4678 '(https://source.chromium.org/chromium/chromium/src/+/main:docs/cq_q'
4679 'uick_run.md) (chromium only).')
4680 group.add_option(
Andrii Shyshkalovf9648b52018-02-21 22:32:42 -08004681 '--category', default='git_cl_try', help='Specify custom build category.')
4682 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004683 '--project',
4684 help='Override which project to use. Projects are defined '
tandriif7b29d42016-10-07 08:45:41 -07004685 'in recipe to determine to which repository or directory to '
4686 'apply the patch')
maruel@chromium.org15192402012-09-06 12:38:29 +00004687 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004688 '-p', '--property', dest='properties', action='append', default=[],
4689 help='Specify generic properties in the form -p key1=value1 -p '
tandriif7b29d42016-10-07 08:45:41 -07004690 'key2=value2 etc. The value will be treated as '
4691 'json if decodable, or as string otherwise. '
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004692 'NOTE: using this may make your tryjob not usable for CQ, '
4693 'which will then schedule another tryjob with default properties')
sheyang@chromium.orgdb375572015-08-17 19:22:23 +00004694 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004695 '--buildbucket-host', default='cr-buildbucket.appspot.com',
4696 help='Host of buildbucket. The default host is %default.')
maruel@chromium.org15192402012-09-06 12:38:29 +00004697 parser.add_option_group(group)
Quinten Yearsley983111f2019-09-26 17:18:48 +00004698 parser.add_option(
4699 '-R', '--retry-failed', action='store_true', default=False,
4700 help='Retry failed jobs from the latest set of tryjobs. '
4701 'Not allowed with --bucket and --bot options.')
Edward Lemur52969c92020-02-06 18:15:28 +00004702 parser.add_option(
4703 '-i', '--issue', type=int,
4704 help='Operate on this issue instead of the current branch\'s implicit '
4705 'issue.')
maruel@chromium.org15192402012-09-06 12:38:29 +00004706 options, args = parser.parse_args(args)
4707
machenbach@chromium.org45453142015-09-15 08:45:22 +00004708 # Make sure that all properties are prop=value pairs.
4709 bad_params = [x for x in options.properties if '=' not in x]
4710 if bad_params:
4711 parser.error('Got properties with missing "=": %s' % bad_params)
4712
maruel@chromium.org15192402012-09-06 12:38:29 +00004713 if args:
4714 parser.error('Unknown arguments: %s' % args)
4715
Edward Lemur934836a2019-09-09 20:16:54 +00004716 cl = Changelist(issue=options.issue)
maruel@chromium.org15192402012-09-06 12:38:29 +00004717 if not cl.GetIssue():
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004718 parser.error('Need to upload first.')
maruel@chromium.org15192402012-09-06 12:38:29 +00004719
Edward Lemurf38bc172019-09-03 21:02:13 +00004720 # HACK: warm up Gerrit change detail cache to save on RPCs.
Edward Lemur125d60a2019-09-13 18:25:41 +00004721 cl._GetChangeDetail(['DETAILED_ACCOUNTS', 'ALL_REVISIONS'])
Andrii Shyshkaloveadad922017-01-26 09:38:30 +01004722
tandriie113dfd2016-10-11 10:20:12 -07004723 error_message = cl.CannotTriggerTryJobReason()
4724 if error_message:
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004725 parser.error('Can\'t trigger tryjobs: %s' % error_message)
jrobbins@chromium.org16f10f72014-06-24 22:14:36 +00004726
Edward Lemur45768512020-03-02 19:03:14 +00004727 if options.bot:
4728 if options.retry_failed:
4729 parser.error('--bot is not compatible with --retry-failed.')
4730 if not options.bucket:
4731 parser.error('A bucket (e.g. "chromium/try") is required.')
4732
4733 triggered = [b for b in options.bot if 'triggered' in b]
4734 if triggered:
4735 parser.error(
4736 'Cannot schedule builds on triggered bots: %s.\n'
4737 'This type of bot requires an initial job from a parent (usually a '
4738 'builder). Schedule a job on the parent instead.\n' % triggered)
4739
4740 if options.bucket.startswith('.master'):
4741 parser.error('Buildbot masters are not supported.')
4742
4743 project, bucket = _parse_bucket(options.bucket)
4744 if project is None or bucket is None:
4745 parser.error('Invalid bucket: %s.' % options.bucket)
4746 jobs = sorted((project, bucket, bot) for bot in options.bot)
4747 elif options.retry_failed:
Quinten Yearsley983111f2019-09-26 17:18:48 +00004748 print('Searching for failed tryjobs...')
Edward Lemur5b929a42019-10-21 17:57:39 +00004749 builds, patchset = _fetch_latest_builds(cl, options.buildbucket_host)
Quinten Yearsley983111f2019-09-26 17:18:48 +00004750 if options.verbose:
4751 print('Got %d builds in patchset #%d' % (len(builds), patchset))
Edward Lemur45768512020-03-02 19:03:14 +00004752 jobs = _filter_failed_for_retry(builds)
4753 if not jobs:
Quinten Yearsley983111f2019-09-26 17:18:48 +00004754 print('There are no failed jobs in the latest set of jobs '
4755 '(patchset #%d), doing nothing.' % patchset)
4756 return 0
Edward Lemur45768512020-03-02 19:03:14 +00004757 num_builders = len(jobs)
Quinten Yearsley983111f2019-09-26 17:18:48 +00004758 if num_builders > 10:
4759 confirm_or_exit('There are %d builders with failed builds.'
4760 % num_builders, action='continue')
Greg Gutermanbe5fccd2021-06-14 17:58:20 +00004761 elif options.quick_run:
4762 print('Scheduling CQ quick run on: %s' % cl.GetIssueURL())
4763 return cl.SetCQState(_CQState.QUICK_RUN)
Quinten Yearsley983111f2019-09-26 17:18:48 +00004764 else:
qyearsley1fdfcb62016-10-24 13:22:03 -07004765 if options.verbose:
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07004766 print('git cl try with no bots now defaults to CQ dry run.')
4767 print('Scheduling CQ dry run on: %s' % cl.GetIssueURL())
4768 return cl.SetCQState(_CQState.DRY_RUN)
stip@chromium.org43064fd2013-12-18 20:07:44 +00004769
ilevy@chromium.org36e420b2013-08-06 23:21:12 +00004770 patchset = cl.GetMostRecentPatchset()
Edward Lemur2c210a42019-09-16 23:58:35 +00004771 try:
Quinten Yearsley777660f2020-03-04 23:37:06 +00004772 _trigger_tryjobs(cl, jobs, options, patchset)
Edward Lemur2c210a42019-09-16 23:58:35 +00004773 except BuildbucketResponseException as ex:
4774 print('ERROR: %s' % ex)
4775 return 1
4776 return 0
maruel@chromium.org15192402012-09-06 12:38:29 +00004777
4778
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004779@metrics.collector.collect_metrics('git cl try-results')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004780def CMDtry_results(parser, args):
Quinten Yearsleyd242ed72019-07-25 17:17:55 +00004781 """Prints info about results for tryjobs associated with the current CL."""
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004782 group = optparse.OptionGroup(parser, 'Tryjob results options')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004783 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004784 '-p', '--patchset', type=int, help='patchset number if not current.')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004785 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004786 '--print-master', action='store_true', help='print master name as well.')
tandrii@chromium.org6cf98c82016-03-15 11:56:00 +00004787 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004788 '--color', action='store_true', default=setup_color.IS_TTY,
4789 help='force color output, useful when piping output.')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004790 group.add_option(
tandrii1838bad2016-10-06 00:10:52 -07004791 '--buildbucket-host', default='cr-buildbucket.appspot.com',
4792 help='Host of buildbucket. The default host is %default.')
qyearsley53f48a12016-09-01 10:45:13 -07004793 group.add_option(
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004794 '--json', help=('Path of JSON output file to write tryjob results to,'
Stefan Zager1306bd02017-06-22 19:26:46 -07004795 'or "-" for stdout.'))
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004796 parser.add_option_group(group)
Edward Lemur52969c92020-02-06 18:15:28 +00004797 parser.add_option(
4798 '-i', '--issue', type=int,
4799 help='Operate on this issue instead of the current branch\'s implicit '
4800 'issue.')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004801 options, args = parser.parse_args(args)
4802 if args:
4803 parser.error('Unrecognized args: %s' % ' '.join(args))
4804
Edward Lemur934836a2019-09-09 20:16:54 +00004805 cl = Changelist(issue=options.issue)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004806 if not cl.GetIssue():
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004807 parser.error('Need to upload first.')
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004808
tandrii221ab252016-10-06 08:12:04 -07004809 patchset = options.patchset
4810 if not patchset:
Gavin Make61ccc52020-11-13 00:12:57 +00004811 patchset = cl.GetMostRecentDryRunPatchset()
tandrii221ab252016-10-06 08:12:04 -07004812 if not patchset:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004813 parser.error('Code review host doesn\'t know about issue %s. '
tandrii221ab252016-10-06 08:12:04 -07004814 'No access to issue or wrong issue number?\n'
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004815 'Either upload first, or pass --patchset explicitly.' %
tandrii221ab252016-10-06 08:12:04 -07004816 cl.GetIssue())
4817
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004818 try:
Quinten Yearsley777660f2020-03-04 23:37:06 +00004819 jobs = _fetch_tryjobs(cl, options.buildbucket_host, patchset)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004820 except BuildbucketResponseException as ex:
vapiera7fbd5a2016-06-16 09:17:49 -07004821 print('Buildbucket error: %s' % ex)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004822 return 1
qyearsley53f48a12016-09-01 10:45:13 -07004823 if options.json:
Edward Lemurbaaf6be2019-10-09 18:00:44 +00004824 write_json(options.json, jobs)
qyearsley53f48a12016-09-01 10:45:13 -07004825 else:
Quinten Yearsley777660f2020-03-04 23:37:06 +00004826 _print_tryjobs(options, jobs)
tandrii@chromium.orgb015fac2016-02-26 14:52:01 +00004827 return 0
4828
4829
maruel@chromium.org0633fb42013-08-16 20:06:14 +00004830@subcommand.usage('[new upstream branch]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004831@metrics.collector.collect_metrics('git cl upstream')
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004832def CMDupstream(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004833 """Prints or sets the name of the upstream branch, if any."""
dpranke@chromium.org97ae58e2011-03-18 00:29:20 +00004834 _, args = parser.parse_args(args)
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00004835 if len(args) > 1:
maruel@chromium.org27bb3872011-05-30 20:33:19 +00004836 parser.error('Unrecognized args: %s' % ' '.join(args))
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00004837
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004838 cl = Changelist()
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00004839 if args:
4840 # One arg means set upstream branch.
bauerb@chromium.orgc9cf90a2014-04-28 20:32:31 +00004841 branch = cl.GetBranch()
stip7a3dd352016-09-22 17:32:28 -07004842 RunGit(['branch', '--set-upstream-to', args[0], branch])
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00004843 cl = Changelist()
vapiera7fbd5a2016-06-16 09:17:49 -07004844 print('Upstream branch set to %s' % (cl.GetUpstreamBranch(),))
bauerb@chromium.orgc9cf90a2014-04-28 20:32:31 +00004845
4846 # Clear configured merge-base, if there is one.
4847 git_common.remove_merge_base(branch)
brettw@chromium.orgac0ba332012-08-09 23:42:53 +00004848 else:
vapiera7fbd5a2016-06-16 09:17:49 -07004849 print(cl.GetUpstreamBranch())
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00004850 return 0
4851
4852
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004853@metrics.collector.collect_metrics('git cl web')
thestig@chromium.org00858c82013-12-02 23:08:03 +00004854def CMDweb(parser, args):
4855 """Opens the current CL in the web browser."""
4856 _, args = parser.parse_args(args)
4857 if args:
4858 parser.error('Unrecognized args: %s' % ' '.join(args))
4859
4860 issue_url = Changelist().GetIssueURL()
4861 if not issue_url:
vapiera7fbd5a2016-06-16 09:17:49 -07004862 print('ERROR No issue to open', file=sys.stderr)
thestig@chromium.org00858c82013-12-02 23:08:03 +00004863 return 1
4864
Sergiy Byelozyorov2b718322018-10-24 17:43:31 +00004865 # Redirect I/O before invoking browser to hide its output. For example, this
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00004866 # allows us to hide the "Created new window in existing browser session."
4867 # message from Chrome. Based on https://stackoverflow.com/a/2323563.
Sergiy Byelozyorov2b718322018-10-24 17:43:31 +00004868 saved_stdout = os.dup(1)
Sergiy Belozorov06684032019-03-06 16:53:08 +00004869 saved_stderr = os.dup(2)
Sergiy Byelozyorov2b718322018-10-24 17:43:31 +00004870 os.close(1)
Sergiy Belozorov06684032019-03-06 16:53:08 +00004871 os.close(2)
Sergiy Byelozyorov2b718322018-10-24 17:43:31 +00004872 os.open(os.devnull, os.O_RDWR)
4873 try:
4874 webbrowser.open(issue_url)
4875 finally:
4876 os.dup2(saved_stdout, 1)
Sergiy Belozorov06684032019-03-06 16:53:08 +00004877 os.dup2(saved_stderr, 2)
thestig@chromium.org00858c82013-12-02 23:08:03 +00004878 return 0
4879
4880
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004881@metrics.collector.collect_metrics('git cl set-commit')
maruel@chromium.org27bb3872011-05-30 20:33:19 +00004882def CMDset_commit(parser, args):
Andrii Shyshkalov0e889b72019-07-15 22:28:48 +00004883 """Sets the commit bit to trigger the CQ."""
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00004884 parser.add_option('-d', '--dry-run', action='store_true',
4885 help='trigger in dry run mode')
Greg Gutermanbe5fccd2021-06-14 17:58:20 +00004886 parser.add_option(
4887 '-q',
4888 '--quick-run',
4889 action='store_true',
4890 help='trigger in quick run mode '
4891 '(https://source.chromium.org/chromium/chromium/src/+/main:docs/cq_qu'
4892 'ick_run.md) (chromium only).')
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00004893 parser.add_option('-c', '--clear', action='store_true',
4894 help='stop CQ run, if any')
Edward Lemur52969c92020-02-06 18:15:28 +00004895 parser.add_option(
4896 '-i', '--issue', type=int,
4897 help='Operate on this issue instead of the current branch\'s implicit '
4898 'issue.')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004899 options, args = parser.parse_args(args)
maruel@chromium.org27bb3872011-05-30 20:33:19 +00004900 if args:
4901 parser.error('Unrecognized args: %s' % ' '.join(args))
Greg Gutermanbe5fccd2021-06-14 17:58:20 +00004902 if [options.dry_run, options.quick_run, options.clear].count(True) > 1:
4903 parser.error('Only one of --dry-run, --quick-run, and --clear are allowed.')
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00004904
Edward Lemur934836a2019-09-09 20:16:54 +00004905 cl = Changelist(issue=options.issue)
Greg Gutermanbe5fccd2021-06-14 17:58:20 +00004906 if not cl.GetIssue():
4907 parser.error('Must upload the issue first.')
4908
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00004909 if options.clear:
tandriid9e5ce52016-07-13 02:32:59 -07004910 state = _CQState.NONE
Greg Gutermanbe5fccd2021-06-14 17:58:20 +00004911 elif options.quick_run:
4912 state = _CQState.QUICK_RUN
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00004913 elif options.dry_run:
4914 state = _CQState.DRY_RUN
4915 else:
4916 state = _CQState.COMMIT
tandrii9de9ec62016-07-13 03:01:59 -07004917 cl.SetCQState(state)
maruel@chromium.org27bb3872011-05-30 20:33:19 +00004918 return 0
4919
4920
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004921@metrics.collector.collect_metrics('git cl set-close')
groby@chromium.org411034a2013-02-26 15:12:01 +00004922def CMDset_close(parser, args):
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00004923 """Closes the issue."""
Edward Lemur52969c92020-02-06 18:15:28 +00004924 parser.add_option(
4925 '-i', '--issue', type=int,
4926 help='Operate on this issue instead of the current branch\'s implicit '
4927 'issue.')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004928 options, args = parser.parse_args(args)
groby@chromium.org411034a2013-02-26 15:12:01 +00004929 if args:
4930 parser.error('Unrecognized args: %s' % ' '.join(args))
Edward Lemur934836a2019-09-09 20:16:54 +00004931 cl = Changelist(issue=options.issue)
groby@chromium.org411034a2013-02-26 15:12:01 +00004932 # Ensure there actually is an issue to close.
Aaron Gable7139a4e2017-09-05 17:53:09 -07004933 if not cl.GetIssue():
Quinten Yearsleyc4202212019-07-22 23:34:40 +00004934 DieWithError('ERROR: No issue to close.')
groby@chromium.org411034a2013-02-26 15:12:01 +00004935 cl.CloseIssue()
4936 return 0
4937
4938
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004939@metrics.collector.collect_metrics('git cl diff')
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00004940def CMDdiff(parser, args):
wychen@chromium.org37b2ec02015-04-03 00:49:15 +00004941 """Shows differences between local tree and last upload."""
thomasanderson074beb22016-08-29 14:03:20 -07004942 parser.add_option(
4943 '--stat',
4944 action='store_true',
4945 dest='stat',
4946 help='Generate a diffstat')
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004947 options, args = parser.parse_args(args)
vadimsh@chromium.orgcf6a5d22015-04-09 22:02:00 +00004948 if args:
4949 parser.error('Unrecognized args: %s' % ' '.join(args))
wychen@chromium.org46309bf2015-04-03 21:04:49 +00004950
Edward Lemur934836a2019-09-09 20:16:54 +00004951 cl = Changelist()
sbc@chromium.org78dc9842013-11-25 18:43:44 +00004952 issue = cl.GetIssue()
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00004953 branch = cl.GetBranch()
sbc@chromium.org78dc9842013-11-25 18:43:44 +00004954 if not issue:
4955 DieWithError('No issue found for current branch (%s)' % branch)
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00004956
Aaron Gablea718c3e2017-08-28 17:47:28 -07004957 base = cl._GitGetBranchConfigValue('last-upload-hash')
4958 if not base:
4959 base = cl._GitGetBranchConfigValue('gerritsquashhash')
4960 if not base:
4961 detail = cl._GetChangeDetail(['CURRENT_REVISION', 'CURRENT_COMMIT'])
4962 revision_info = detail['revisions'][detail['current_revision']]
4963 fetch_info = revision_info['fetch']['http']
4964 RunGit(['fetch', fetch_info['url'], fetch_info['ref']])
4965 base = 'FETCH_HEAD'
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00004966
Aaron Gablea718c3e2017-08-28 17:47:28 -07004967 cmd = ['git', 'diff']
4968 if options.stat:
4969 cmd.append('--stat')
4970 cmd.append(base)
4971 subprocess2.check_call(cmd)
sbc@chromium.org87b9bf02013-09-26 20:35:15 +00004972
4973 return 0
4974
4975
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00004976@metrics.collector.collect_metrics('git cl owners')
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00004977def CMDowners(parser, args):
Dirk Prankebf980882017-09-02 15:08:00 -07004978 """Finds potential owners for reviewing."""
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00004979 parser.add_option(
Sidney San Martín8e6f58c2018-06-08 01:02:56 +00004980 '--ignore-current',
4981 action='store_true',
4982 help='Ignore the CL\'s current reviewers and start from scratch.')
4983 parser.add_option(
Sylvain Defresneb1f865d2019-02-12 12:38:22 +00004984 '--ignore-self',
4985 action='store_true',
4986 help='Do not consider CL\'s author as an owners.')
4987 parser.add_option(
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00004988 '--no-color',
4989 action='store_true',
4990 help='Use this option to disable color output')
Dirk Prankebf980882017-09-02 15:08:00 -07004991 parser.add_option(
4992 '--batch',
4993 action='store_true',
4994 help='Do not run interactively, just suggest some')
Yang Guo6e269a02019-06-26 11:17:02 +00004995 # TODO: Consider moving this to another command, since other
4996 # git-cl owners commands deal with owners for a given CL.
4997 parser.add_option(
4998 '--show-all',
4999 action='store_true',
5000 help='Show all owners for a particular file')
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005001 options, args = parser.parse_args(args)
5002
Edward Lemur934836a2019-09-09 20:16:54 +00005003 cl = Changelist()
Edward Lesmes50da7702020-03-30 19:23:43 +00005004 author = cl.GetAuthor()
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005005
Yang Guo6e269a02019-06-26 11:17:02 +00005006 if options.show_all:
Bruce Dawson97ed44a2020-05-06 17:04:03 +00005007 if len(args) == 0:
5008 print('No files specified for --show-all. Nothing to do.')
5009 return 0
Edward Lesmese1576912021-02-16 21:53:34 +00005010 owners_by_path = cl.owners_client.BatchListOwners(args)
Edward Lesmes0e4e5ae2021-01-08 18:28:46 +00005011 for path in args:
5012 print('Owners for %s:' % path)
5013 print('\n'.join(
5014 ' - %s' % owner
5015 for owner in owners_by_path.get(path, ['No owners found'])))
Yang Guo6e269a02019-06-26 11:17:02 +00005016 return 0
5017
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005018 if args:
5019 if len(args) > 1:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00005020 parser.error('Unknown args.')
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005021 base_branch = args[0]
5022 else:
5023 # Default to diffing against the common ancestor of the upstream branch.
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00005024 base_branch = cl.GetCommonAncestorWithUpstream()
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005025
Edward Lemur2c62b332020-03-12 22:12:33 +00005026 affected_files = cl.GetAffectedFiles(base_branch)
Dirk Prankebf980882017-09-02 15:08:00 -07005027
5028 if options.batch:
Edward Lesmese1576912021-02-16 21:53:34 +00005029 owners = cl.owners_client.SuggestOwners(affected_files, exclude=[author])
5030 print('\n'.join(owners))
Dirk Prankebf980882017-09-02 15:08:00 -07005031 return 0
5032
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005033 return owners_finder.OwnersFinder(
Dirk Prankebf980882017-09-02 15:08:00 -07005034 affected_files,
Edward Lemur707d70b2018-02-07 00:50:14 +01005035 author,
Sidney San Martín8e6f58c2018-06-08 01:02:56 +00005036 [] if options.ignore_current else cl.GetReviewers(),
Edward Lesmes5cd75472021-02-19 00:34:25 +00005037 cl.owners_client,
Jochen Eisingerd0573ec2017-04-13 10:55:06 +02005038 disable_color=options.no_color,
Sylvain Defresneb1f865d2019-02-12 12:38:22 +00005039 ignore_author=options.ignore_self).run()
ikarienator@chromium.orgfaf3fdf2013-09-20 02:11:48 +00005040
5041
Aiden Bennerc08566e2018-10-03 17:52:42 +00005042def BuildGitDiffCmd(diff_type, upstream_commit, args, allow_prefix=False):
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005043 """Generates a diff command."""
5044 # Generate diff for the current branch's changes.
Aiden Bennerc08566e2018-10-03 17:52:42 +00005045 diff_cmd = ['-c', 'core.quotePath=false', 'diff', '--no-ext-diff']
5046
Aiden Benner6c18a1a2018-11-23 20:18:23 +00005047 if allow_prefix:
5048 # explicitly setting --src-prefix and --dst-prefix is necessary in the
5049 # case that diff.noprefix is set in the user's git config.
5050 diff_cmd += ['--src-prefix=a/', '--dst-prefix=b/']
5051 else:
Aiden Bennerc08566e2018-10-03 17:52:42 +00005052 diff_cmd += ['--no-prefix']
5053
5054 diff_cmd += [diff_type, upstream_commit, '--']
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005055
5056 if args:
5057 for arg in args:
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005058 if os.path.isdir(arg) or os.path.isfile(arg):
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005059 diff_cmd.append(arg)
5060 else:
5061 DieWithError('Argument "%s" is not a file or a directory' % arg)
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005062
5063 return diff_cmd
5064
Andrii Shyshkalov18975322017-01-25 16:44:13 +01005065
Jamie Madill5e96ad12020-01-13 16:08:35 +00005066def _RunClangFormatDiff(opts, clang_diff_files, top_dir, upstream_commit):
5067 """Runs clang-format-diff and sets a return value if necessary."""
5068
5069 if not clang_diff_files:
5070 return 0
5071
5072 # Set to 2 to signal to CheckPatchFormatted() that this patch isn't
5073 # formatted. This is used to block during the presubmit.
5074 return_value = 0
5075
5076 # Locate the clang-format binary in the checkout
5077 try:
5078 clang_format_tool = clang_format.FindClangFormatToolInChromiumTree()
5079 except clang_format.NotFoundError as e:
5080 DieWithError(e)
5081
5082 if opts.full or settings.GetFormatFullByDefault():
5083 cmd = [clang_format_tool]
5084 if not opts.dry_run and not opts.diff:
5085 cmd.append('-i')
5086 if opts.dry_run:
5087 for diff_file in clang_diff_files:
5088 with open(diff_file, 'r') as myfile:
5089 code = myfile.read().replace('\r\n', '\n')
5090 stdout = RunCommand(cmd + [diff_file], cwd=top_dir)
5091 stdout = stdout.replace('\r\n', '\n')
5092 if opts.diff:
5093 sys.stdout.write(stdout)
5094 if code != stdout:
5095 return_value = 2
5096 else:
5097 stdout = RunCommand(cmd + clang_diff_files, cwd=top_dir)
5098 if opts.diff:
5099 sys.stdout.write(stdout)
5100 else:
Jamie Madill5e96ad12020-01-13 16:08:35 +00005101 try:
5102 script = clang_format.FindClangFormatScriptInChromiumTree(
5103 'clang-format-diff.py')
5104 except clang_format.NotFoundError as e:
5105 DieWithError(e)
5106
Josip Sokcevic2a827fc2022-03-04 17:51:47 +00005107 cmd = ['vpython3', script, '-p0']
Jamie Madill5e96ad12020-01-13 16:08:35 +00005108 if not opts.dry_run and not opts.diff:
5109 cmd.append('-i')
5110
5111 diff_cmd = BuildGitDiffCmd('-U0', upstream_commit, clang_diff_files)
Edward Lemur1a83da12020-03-04 21:18:36 +00005112 diff_output = RunGit(diff_cmd).encode('utf-8')
Jamie Madill5e96ad12020-01-13 16:08:35 +00005113
Edward Lesmes89624cd2020-04-06 17:51:56 +00005114 env = os.environ.copy()
5115 env['PATH'] = (
5116 str(os.path.dirname(clang_format_tool)) + os.pathsep + env['PATH'])
5117 stdout = RunCommand(
5118 cmd, stdin=diff_output, cwd=top_dir, env=env,
Ilya Sherman7aed4bb2020-05-20 22:34:14 +00005119 shell=sys.platform.startswith('win32'))
Jamie Madill5e96ad12020-01-13 16:08:35 +00005120 if opts.diff:
5121 sys.stdout.write(stdout)
5122 if opts.dry_run and len(stdout) > 0:
5123 return_value = 2
5124
5125 return return_value
5126
5127
Lukasz Anforowiczb4d39542021-09-30 23:39:25 +00005128def _RunRustFmt(opts, rust_diff_files, top_dir, upstream_commit):
5129 """Runs rustfmt. Just like _RunClangFormatDiff returns 2 to indicate that
5130 presubmit checks have failed (and returns 0 otherwise)."""
5131
5132 if not rust_diff_files:
5133 return 0
5134
5135 # Locate the rustfmt binary.
5136 try:
5137 rustfmt_tool = rustfmt.FindRustfmtToolInChromiumTree()
5138 except rustfmt.NotFoundError as e:
5139 DieWithError(e)
5140
5141 # TODO(crbug.com/1231317): Support formatting only the changed lines
5142 # if `opts.full or settings.GetFormatFullByDefault()` is False. See also:
5143 # https://github.com/emilio/rustfmt-format-diff
5144 cmd = [rustfmt_tool]
5145 if opts.dry_run:
5146 cmd.append('--check')
5147 cmd += rust_diff_files
5148 rustfmt_exitcode = subprocess2.call(cmd)
5149
5150 if opts.presubmit and rustfmt_exitcode != 0:
5151 return 2
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +00005152
5153 return 0
Lukasz Anforowiczb4d39542021-09-30 23:39:25 +00005154
5155
Olivier Robin0a6b5442022-04-07 07:25:04 +00005156def _RunSwiftFormat(opts, swift_diff_files, top_dir, upstream_commit):
5157 """Runs swift-format. Just like _RunClangFormatDiff returns 2 to indicate
5158 that presubmit checks have failed (and returns 0 otherwise)."""
5159
5160 if not swift_diff_files:
5161 return 0
5162
5163 # Locate the swift-format binary.
5164 try:
5165 swift_format_tool = swift_format.FindSwiftFormatToolInChromiumTree()
5166 except swift_format.NotFoundError as e:
5167 DieWithError(e)
5168
5169 cmd = [swift_format_tool]
5170 if opts.dry_run:
Olivier Robin7f39e3d2022-04-28 08:20:49 +00005171 cmd += ['lint', '-s']
Olivier Robin0a6b5442022-04-07 07:25:04 +00005172 else:
5173 cmd += ['format', '-i']
5174 cmd += swift_diff_files
5175 swift_format_exitcode = subprocess2.call(cmd)
5176
5177 if opts.presubmit and swift_format_exitcode != 0:
5178 return 2
5179
5180 return 0
5181
5182
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005183def MatchingFileType(file_name, extensions):
Quinten Yearsleyd242ed72019-07-25 17:17:55 +00005184 """Returns True if the file name ends with one of the given extensions."""
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005185 return bool([ext for ext in extensions if file_name.lower().endswith(ext)])
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005186
Andrii Shyshkalov18975322017-01-25 16:44:13 +01005187
enne@chromium.org555cfe42014-01-29 18:21:39 +00005188@subcommand.usage('[files or directories to diff]')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005189@metrics.collector.collect_metrics('git cl format')
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005190def CMDformat(parser, args):
sbc@chromium.org9d0644d2015-06-05 23:16:54 +00005191 """Runs auto-formatting tools (clang-format etc.) on the diff."""
Christopher Lamc5ba6922017-01-24 11:19:14 +11005192 CLANG_EXTS = ['.cc', '.cpp', '.h', '.m', '.mm', '.proto', '.java']
kylechar58edce22016-06-17 06:07:51 -07005193 GN_EXTS = ['.gn', '.gni', '.typemap']
Lukasz Anforowiczb4d39542021-09-30 23:39:25 +00005194 RUST_EXTS = ['.rs']
Olivier Robin0a6b5442022-04-07 07:25:04 +00005195 SWIFT_EXTS = ['.swift']
enne@chromium.org3b7e15c2014-01-21 17:44:47 +00005196 parser.add_option('--full', action='store_true',
5197 help='Reformat the full content of all touched files')
Tomasz Åšniatowski58194462021-08-27 17:36:16 +00005198 parser.add_option('--upstream', help='Branch to check against')
enne@chromium.org3b7e15c2014-01-21 17:44:47 +00005199 parser.add_option('--dry-run', action='store_true',
5200 help='Don\'t modify any file on disk.')
Aiden Benner99b0ccb2018-11-20 19:53:31 +00005201 parser.add_option(
Garrett Beatyed0cc5f2020-01-06 17:26:13 +00005202 '--no-clang-format',
5203 dest='clang_format',
5204 action='store_false',
5205 default=True,
5206 help='Disables formatting of various file types using clang-format.')
5207 parser.add_option(
Aiden Benner99b0ccb2018-11-20 19:53:31 +00005208 '--python',
5209 action='store_true',
5210 default=None,
5211 help='Enables python formatting on all python files.')
5212 parser.add_option(
5213 '--no-python',
5214 action='store_true',
Garrett Beaty91a6f332020-01-06 16:57:24 +00005215 default=False,
Aiden Benner99b0ccb2018-11-20 19:53:31 +00005216 help='Disables python formatting on all python files. '
Garrett Beaty91a6f332020-01-06 16:57:24 +00005217 'If neither --python or --no-python are set, python files that have a '
5218 '.style.yapf file in an ancestor directory will be formatted. '
5219 'It is an error to set both.')
Garrett Beatyed0cc5f2020-01-06 17:26:13 +00005220 parser.add_option(
5221 '--js',
5222 action='store_true',
5223 help='Format javascript code with clang-format. '
5224 'Has no effect if --no-clang-format is set.')
wittman@chromium.org04d5a222014-03-07 18:30:42 +00005225 parser.add_option('--diff', action='store_true',
5226 help='Print diff to stdout rather than modifying files.')
Ilya Shermane081cbe2017-08-15 17:51:04 -07005227 parser.add_option('--presubmit', action='store_true',
5228 help='Used when running the script from a presubmit.')
Lukasz Anforowiczb4d39542021-09-30 23:39:25 +00005229
5230 parser.add_option('--rust-fmt',
5231 dest='use_rust_fmt',
5232 action='store_true',
5233 default=rustfmt.IsRustfmtSupported(),
5234 help='Enables formatting of Rust file types using rustfmt.')
5235 parser.add_option(
5236 '--no-rust-fmt',
5237 dest='use_rust_fmt',
5238 action='store_false',
5239 help='Disables formatting of Rust file types using rustfmt.')
5240
Olivier Robin0a6b5442022-04-07 07:25:04 +00005241 parser.add_option(
5242 '--swift-format',
5243 dest='use_swift_format',
5244 action='store_true',
Olivier Robin7f39e3d2022-04-28 08:20:49 +00005245 default=swift_format.IsSwiftFormatSupported(),
Olivier Robin0a6b5442022-04-07 07:25:04 +00005246 help='Enables formatting of Swift file types using swift-format '
5247 '(macOS host only).')
5248 parser.add_option(
5249 '--no-swift-format',
5250 dest='use_swift_format',
5251 action='store_false',
5252 help='Disables formatting of Swift file types using swift-format.')
5253
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005254 opts, args = parser.parse_args(args)
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005255
Garrett Beaty91a6f332020-01-06 16:57:24 +00005256 if opts.python is not None and opts.no_python:
5257 raise parser.error('Cannot set both --python and --no-python')
5258 if opts.no_python:
5259 opts.python = False
5260
Daniel Chengc55eecf2016-12-30 03:11:02 -08005261 # Normalize any remaining args against the current path, so paths relative to
5262 # the current directory are still resolved as expected.
5263 args = [os.path.join(os.getcwd(), arg) for arg in args]
5264
enne@chromium.orgff7a1fb2013-12-10 19:21:41 +00005265 # git diff generates paths against the root of the repository. Change
5266 # to that directory so clang-format can find files even within subdirs.
thestig@chromium.org8b0553c2014-02-11 00:33:37 +00005267 rel_base_path = settings.GetRelativeRoot()
enne@chromium.orgff7a1fb2013-12-10 19:21:41 +00005268 if rel_base_path:
5269 os.chdir(rel_base_path)
5270
digit@chromium.org29e47272013-05-17 17:01:46 +00005271 # Grab the merge-base commit, i.e. the upstream commit of the current
5272 # branch when it was created or the last time it was rebased. This is
5273 # to cover the case where the user may have called "git fetch origin",
5274 # moving the origin branch to a newer commit, but hasn't rebased yet.
5275 upstream_commit = None
Tomasz Åšniatowski58194462021-08-27 17:36:16 +00005276 upstream_branch = opts.upstream
5277 if not upstream_branch:
5278 cl = Changelist()
5279 upstream_branch = cl.GetUpstreamBranch()
digit@chromium.org29e47272013-05-17 17:01:46 +00005280 if upstream_branch:
5281 upstream_commit = RunGit(['merge-base', 'HEAD', upstream_branch])
5282 upstream_commit = upstream_commit.strip()
5283
5284 if not upstream_commit:
5285 DieWithError('Could not find base commit for this branch. '
5286 'Are you in detached state?')
5287
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005288 changed_files_cmd = BuildGitDiffCmd('--name-only', upstream_commit, args)
5289 diff_output = RunGit(changed_files_cmd)
5290 diff_files = diff_output.splitlines()
jkarlin@chromium.orgad21b922016-01-28 17:48:42 +00005291 # Filter out files deleted by this CL
5292 diff_files = [x for x in diff_files if os.path.isfile(x)]
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005293
Andreas Haas417d89c2020-02-06 10:24:27 +00005294 if opts.js:
Deepanjan Roy605dd312018-07-02 17:48:54 +00005295 CLANG_EXTS.extend(['.js', '.ts'])
Christopher Lamc5ba6922017-01-24 11:19:14 +11005296
Garrett Beatyed0cc5f2020-01-06 17:26:13 +00005297 clang_diff_files = []
5298 if opts.clang_format:
5299 clang_diff_files = [
5300 x for x in diff_files if MatchingFileType(x, CLANG_EXTS)
5301 ]
jkarlin@chromium.org6f7fa5e2016-01-20 19:32:21 +00005302 python_diff_files = [x for x in diff_files if MatchingFileType(x, ['.py'])]
Lukasz Anforowiczb4d39542021-09-30 23:39:25 +00005303 rust_diff_files = [x for x in diff_files if MatchingFileType(x, RUST_EXTS)]
Olivier Robin0a6b5442022-04-07 07:25:04 +00005304 swift_diff_files = [x for x in diff_files if MatchingFileType(x, SWIFT_EXTS)]
kylechar@chromium.org8b61f112016-02-05 13:28:58 +00005305 gn_diff_files = [x for x in diff_files if MatchingFileType(x, GN_EXTS)]
digit@chromium.org29e47272013-05-17 17:01:46 +00005306
Edward Lesmes50da7702020-03-30 19:23:43 +00005307 top_dir = settings.GetRoot()
nick@chromium.org3ac1c4e2014-01-16 02:44:42 +00005308
Jamie Madill5e96ad12020-01-13 16:08:35 +00005309 return_value = _RunClangFormatDiff(opts, clang_diff_files, top_dir,
5310 upstream_commit)
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005311
Lukasz Anforowiczb4d39542021-09-30 23:39:25 +00005312 if opts.use_rust_fmt:
5313 rust_fmt_return_value = _RunRustFmt(opts, rust_diff_files, top_dir,
5314 upstream_commit)
5315 if rust_fmt_return_value == 2:
5316 return_value = 2
5317
Olivier Robin0a6b5442022-04-07 07:25:04 +00005318 if opts.use_swift_format:
5319 if sys.platform != 'darwin':
5320 DieWithError('swift-format is only supported on macOS.')
5321 swift_format_return_value = _RunSwiftFormat(opts, swift_diff_files, top_dir,
5322 upstream_commit)
5323 if swift_format_return_value == 2:
5324 return_value = 2
5325
sbc@chromium.org9d0644d2015-06-05 23:16:54 +00005326 # Similar code to above, but using yapf on .py files rather than clang-format
5327 # on C/C++ files
Aiden Benner99b0ccb2018-11-20 19:53:31 +00005328 py_explicitly_disabled = opts.python is not None and not opts.python
5329 if python_diff_files and not py_explicitly_disabled:
Aiden Bennere47ac152018-11-20 16:44:03 +00005330 depot_tools_path = os.path.dirname(os.path.abspath(__file__))
5331 yapf_tool = os.path.join(depot_tools_path, 'yapf')
sbc@chromium.org9d0644d2015-06-05 23:16:54 +00005332
Aiden Bennerc08566e2018-10-03 17:52:42 +00005333 # Used for caching.
5334 yapf_configs = {}
5335 for f in python_diff_files:
5336 # Find the yapf style config for the current file, defaults to depot
5337 # tools default.
Aiden Benner99b0ccb2018-11-20 19:53:31 +00005338 _FindYapfConfigFile(f, yapf_configs, top_dir)
5339
5340 # Turn on python formatting by default if a yapf config is specified.
5341 # This breaks in the case of this repo though since the specified
5342 # style file is also the global default.
5343 if opts.python is None:
5344 filtered_py_files = []
5345 for f in python_diff_files:
5346 if _FindYapfConfigFile(f, yapf_configs, top_dir) is not None:
5347 filtered_py_files.append(f)
5348 else:
5349 filtered_py_files = python_diff_files
5350
5351 # Note: yapf still seems to fix indentation of the entire file
5352 # even if line ranges are specified.
5353 # See https://github.com/google/yapf/issues/499
5354 if not opts.full and filtered_py_files:
5355 py_line_diffs = _ComputeDiffLineRanges(filtered_py_files, upstream_commit)
5356
Brian Sheedyb4307d52019-12-02 19:18:17 +00005357 yapfignore_patterns = _GetYapfIgnorePatterns(top_dir)
5358 filtered_py_files = _FilterYapfIgnoredFiles(filtered_py_files,
5359 yapfignore_patterns)
Brian Sheedy59b06a82019-10-14 17:03:29 +00005360
Aiden Benner99b0ccb2018-11-20 19:53:31 +00005361 for f in filtered_py_files:
Andrew Grievefa40bfa2020-01-07 02:32:57 +00005362 yapf_style = _FindYapfConfigFile(f, yapf_configs, top_dir)
5363 # Default to pep8 if not .style.yapf is found.
5364 if not yapf_style:
5365 yapf_style = 'pep8'
Aiden Bennerc08566e2018-10-03 17:52:42 +00005366
Peter Wend9399922020-06-17 17:33:49 +00005367 with open(f, 'r') as py_f:
Andrew Grieveb9e694c2021-11-15 19:04:46 +00005368 if 'python2' in py_f.readline():
Peter Wend9399922020-06-17 17:33:49 +00005369 vpython_script = 'vpython'
Andrew Grieveb9e694c2021-11-15 19:04:46 +00005370 else:
5371 vpython_script = 'vpython3'
Peter Wend9399922020-06-17 17:33:49 +00005372
5373 cmd = [vpython_script, yapf_tool, '--style', yapf_style, f]
Aiden Bennerc08566e2018-10-03 17:52:42 +00005374
5375 has_formattable_lines = False
5376 if not opts.full:
5377 # Only run yapf over changed line ranges.
5378 for diff_start, diff_len in py_line_diffs[f]:
5379 diff_end = diff_start + diff_len - 1
5380 # Yapf errors out if diff_end < diff_start but this
5381 # is a valid line range diff for a removal.
5382 if diff_end >= diff_start:
5383 has_formattable_lines = True
5384 cmd += ['-l', '{}-{}'.format(diff_start, diff_end)]
5385 # If all line diffs were removals we have nothing to format.
5386 if not has_formattable_lines:
5387 continue
5388
5389 if opts.diff or opts.dry_run:
5390 cmd += ['--diff']
5391 # Will return non-zero exit code if non-empty diff.
Edward Lesmesb7db1832020-06-22 20:22:27 +00005392 stdout = RunCommand(cmd,
5393 error_ok=True,
Josip Sokcevic673e8ed2021-10-27 23:46:18 +00005394 stderr=subprocess2.PIPE,
Edward Lesmesb7db1832020-06-22 20:22:27 +00005395 cwd=top_dir,
5396 shell=sys.platform.startswith('win32'))
Aiden Bennerc08566e2018-10-03 17:52:42 +00005397 if opts.diff:
5398 sys.stdout.write(stdout)
5399 elif len(stdout) > 0:
5400 return_value = 2
5401 else:
5402 cmd += ['-i']
Edward Lesmesb7db1832020-06-22 20:22:27 +00005403 RunCommand(cmd, cwd=top_dir, shell=sys.platform.startswith('win32'))
sbc@chromium.org9d0644d2015-06-05 23:16:54 +00005404
kylechar@chromium.org8b61f112016-02-05 13:28:58 +00005405 # Format GN build files. Always run on full build files for canonical form.
5406 if gn_diff_files:
Andrii Shyshkalov18975322017-01-25 16:44:13 +01005407 cmd = ['gn', 'format']
brettw4b8ed592016-08-05 16:19:12 -07005408 if opts.dry_run or opts.diff:
5409 cmd.append('--dry-run')
kylechar@chromium.org8b61f112016-02-05 13:28:58 +00005410 for gn_diff_file in gn_diff_files:
brettw4b8ed592016-08-05 16:19:12 -07005411 gn_ret = subprocess2.call(cmd + [gn_diff_file],
Ilya Sherman7aed4bb2020-05-20 22:34:14 +00005412 shell=sys.platform.startswith('win'),
brettw4b8ed592016-08-05 16:19:12 -07005413 cwd=top_dir)
5414 if opts.dry_run and gn_ret == 2:
5415 return_value = 2 # Not formatted.
5416 elif opts.diff and gn_ret == 2:
5417 # TODO this should compute and print the actual diff.
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005418 print('This change has GN build file diff for ' + gn_diff_file)
brettw4b8ed592016-08-05 16:19:12 -07005419 elif gn_ret != 0:
5420 # For non-dry run cases (and non-2 return values for dry-run), a
5421 # nonzero error code indicates a failure, probably because the file
5422 # doesn't parse.
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005423 DieWithError('gn format failed on ' + gn_diff_file +
5424 '\nTry running `gn format` on this file manually.')
kylechar@chromium.org8b61f112016-02-05 13:28:58 +00005425
Ilya Shermane081cbe2017-08-15 17:51:04 -07005426 # Skip the metrics formatting from the global presubmit hook. These files have
5427 # a separate presubmit hook that issues an error if the files need formatting,
5428 # whereas the top-level presubmit script merely issues a warning. Formatting
5429 # these files is somewhat slow, so it's important not to duplicate the work.
5430 if not opts.presubmit:
Wenhan (Han) Zhang3bd3c992020-08-14 16:27:39 +00005431 for diff_xml in GetDiffXMLs(diff_files):
5432 xml_dir = GetMetricsDir(diff_xml)
5433 if not xml_dir:
5434 continue
5435
Ilya Shermane081cbe2017-08-15 17:51:04 -07005436 tool_dir = os.path.join(top_dir, xml_dir)
Ilya Sherman7aed4bb2020-05-20 22:34:14 +00005437 pretty_print_tool = os.path.join(tool_dir, 'pretty_print.py')
5438 cmd = ['vpython', pretty_print_tool, '--non-interactive']
Wenhan (Han) Zhang3bd3c992020-08-14 16:27:39 +00005439
5440 # If the XML file is histograms.xml or enums.xml, add the xml path to the
5441 # command as histograms/pretty_print.py now needs a relative path argument
5442 # after splitting the histograms into multiple directories.
5443 # For example, in tools/metrics/ukm, pretty-print could be run using:
5444 # $ python pretty_print.py
5445 # But in tools/metrics/histogrmas, pretty-print should be run with an
5446 # additional relative path argument, like:
Peter Kastingee088882021-08-03 17:57:00 +00005447 # $ python pretty_print.py metadata/UMA/histograms.xml
Wenhan (Han) Zhang3bd3c992020-08-14 16:27:39 +00005448 # $ python pretty_print.py enums.xml
5449
5450 # TODO (crbug/1116488): Remove this check after ensuring that the updated
5451 # version of histograms/pretty_print.py is released.
5452 filepath_required = os.path.exists(
5453 os.path.join(tool_dir, 'validate_prefix.py'))
5454
Weilun Shib92c4b72020-08-27 17:45:11 +00005455 if (diff_xml.endswith('histograms.xml') or diff_xml.endswith('enums.xml')
5456 or diff_xml.endswith('histogram_suffixes_list.xml')
5457 ) and filepath_required:
Wenhan (Han) Zhang3bd3c992020-08-14 16:27:39 +00005458 cmd.append(diff_xml)
5459
Ilya Shermane081cbe2017-08-15 17:51:04 -07005460 if opts.dry_run or opts.diff:
5461 cmd.append('--diff')
Wenhan (Han) Zhang3bd3c992020-08-14 16:27:39 +00005462
Ilya Sherman7aed4bb2020-05-20 22:34:14 +00005463 # TODO(isherman): Once this file runs only on Python 3.3+, drop the
5464 # `shell` param and instead replace `'vpython'` with
5465 # `shutil.which('frob')` above: https://stackoverflow.com/a/32799942
Wenhan (Han) Zhang3bd3c992020-08-14 16:27:39 +00005466 stdout = RunCommand(cmd,
5467 cwd=top_dir,
Ilya Sherman7aed4bb2020-05-20 22:34:14 +00005468 shell=sys.platform.startswith('win32'))
Ilya Shermane081cbe2017-08-15 17:51:04 -07005469 if opts.diff:
5470 sys.stdout.write(stdout)
5471 if opts.dry_run and stdout:
5472 return_value = 2 # Not formatted.
Alexei Svitkinef3cac412017-02-06 11:08:50 -05005473
erg@chromium.orge0a7c5d2015-02-23 20:30:08 +00005474 return return_value
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005475
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005476
Wenhan (Han) Zhang3bd3c992020-08-14 16:27:39 +00005477def GetDiffXMLs(diff_files):
5478 return [
5479 os.path.normpath(x) for x in diff_files if MatchingFileType(x, ['.xml'])
5480 ]
5481
5482
5483def GetMetricsDir(diff_xml):
Steven Holte2e664bf2017-04-21 13:10:47 -07005484 metrics_xml_dirs = [
5485 os.path.join('tools', 'metrics', 'actions'),
5486 os.path.join('tools', 'metrics', 'histograms'),
5487 os.path.join('tools', 'metrics', 'rappor'),
Ilya Shermanb67e60c2020-05-20 22:27:03 +00005488 os.path.join('tools', 'metrics', 'structured'),
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005489 os.path.join('tools', 'metrics', 'ukm'),
5490 ]
Steven Holte2e664bf2017-04-21 13:10:47 -07005491 for xml_dir in metrics_xml_dirs:
Wenhan (Han) Zhang3bd3c992020-08-14 16:27:39 +00005492 if diff_xml.startswith(xml_dir):
5493 return xml_dir
5494 return None
Steven Holte2e664bf2017-04-21 13:10:47 -07005495
agable@chromium.orgfab8f822013-05-06 17:43:09 +00005496
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005497@subcommand.usage('<codereview url or issue id>')
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005498@metrics.collector.collect_metrics('git cl checkout')
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005499def CMDcheckout(parser, args):
Edward Lemurf38bc172019-09-03 21:02:13 +00005500 """Checks out a branch associated with a given Gerrit issue."""
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005501 _, args = parser.parse_args(args)
5502
5503 if len(args) != 1:
5504 parser.print_help()
5505 return 1
5506
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00005507 issue_arg = ParseIssueNumberArgument(args[0])
tandrii@chromium.orgde6c9a12016-04-11 15:33:53 +00005508 if not issue_arg.valid:
Quinten Yearsleyc4202212019-07-22 23:34:40 +00005509 parser.error('Invalid issue ID or URL.')
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02005510
tandrii@chromium.orgabd27e52016-04-11 15:43:32 +00005511 target_issue = str(issue_arg.issue)
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005512
Edward Lemur52969c92020-02-06 18:15:28 +00005513 output = RunGit(['config', '--local', '--get-regexp',
Edward Lesmes50da7702020-03-30 19:23:43 +00005514 r'branch\..*\.' + ISSUE_CONFIG_KEY],
Edward Lemur52969c92020-02-06 18:15:28 +00005515 error_ok=True)
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005516
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00005517 branches = []
Edward Lemur52969c92020-02-06 18:15:28 +00005518 for key, issue in [x.split() for x in output.splitlines()]:
5519 if issue == target_issue:
Edward Lesmes50da7702020-03-30 19:23:43 +00005520 branches.append(re.sub(r'branch\.(.*)\.' + ISSUE_CONFIG_KEY, r'\1', key))
Edward Lemur52969c92020-02-06 18:15:28 +00005521
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005522 if len(branches) == 0:
vapiera7fbd5a2016-06-16 09:17:49 -07005523 print('No branch found for issue %s.' % target_issue)
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005524 return 1
5525 if len(branches) == 1:
5526 RunGit(['checkout', branches[0]])
5527 else:
vapiera7fbd5a2016-06-16 09:17:49 -07005528 print('Multiple branches match issue %s:' % target_issue)
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005529 for i in range(len(branches)):
vapiera7fbd5a2016-06-16 09:17:49 -07005530 print('%d: %s' % (i, branches[i]))
Edward Lesmesae3586b2020-03-23 21:21:14 +00005531 which = gclient_utils.AskForData('Choose by index: ')
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005532 try:
5533 RunGit(['checkout', branches[int(which)]])
5534 except (IndexError, ValueError):
vapiera7fbd5a2016-06-16 09:17:49 -07005535 print('Invalid selection, not checking out any branch.')
scottmg@chromium.org84a80c42015-09-22 20:40:37 +00005536 return 1
5537
5538 return 0
5539
5540
maruel@chromium.org29404b52014-09-08 22:58:00 +00005541def CMDlol(parser, args):
5542 # This command is intentionally undocumented.
vapiera7fbd5a2016-06-16 09:17:49 -07005543 print(zlib.decompress(base64.b64decode(
thakis@chromium.org3421c992014-11-02 02:20:32 +00005544 'eNptkLEOwyAMRHe+wupCIqW57v0Vq84WqWtXyrcXnCBsmgMJ+/SSAxMZgRB6NzE'
5545 'E2ObgCKJooYdu4uAQVffUEoE1sRQLxAcqzd7uK2gmStrll1ucV3uZyaY5sXyDd9'
5546 'JAnN+lAXsOMJ90GANAi43mq5/VeeacylKVgi8o6F1SC63FxnagHfJUTfUYdCR/W'
Gavin Mak18f45d22020-12-04 21:45:10 +00005547 'Ofe+0dHL7PicpytKP750Fh1q2qnLVof4w8OZWNY')).decode('utf-8'))
maruel@chromium.org29404b52014-09-08 22:58:00 +00005548 return 0
5549
5550
Josip Sokcevic0399e172022-03-21 23:11:51 +00005551def CMDversion(parser, args):
5552 import utils
5553 print(utils.depot_tools_version())
5554
5555
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005556class OptionParser(optparse.OptionParser):
5557 """Creates the option parse and add --verbose support."""
Sigurd Schneider9abde8c2020-11-17 08:44:52 +00005558
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005559 def __init__(self, *args, **kwargs):
maruel@chromium.org0633fb42013-08-16 20:06:14 +00005560 optparse.OptionParser.__init__(
5561 self, *args, prog='git cl', version=__version__, **kwargs)
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005562 self.add_option(
5563 '-v', '--verbose', action='count', default=0,
5564 help='Use 2 times for more debugging info')
5565
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005566 def parse_args(self, args=None, _values=None):
Andrii Shyshkalov46f20cd2018-10-30 06:42:54 +00005567 try:
5568 return self._parse_args(args)
5569 finally:
5570 # Regardless of success or failure of args parsing, we want to report
5571 # metrics, but only after logging has been initialized (if parsing
5572 # succeeded).
5573 global settings
5574 settings = Settings()
5575
Edward Lesmes9c349062021-05-06 20:02:39 +00005576 if metrics.collector.config.should_collect_metrics:
Andrii Shyshkalov46f20cd2018-10-30 06:42:54 +00005577 # GetViewVCUrl ultimately calls logging method.
5578 project_url = settings.GetViewVCUrl().strip('/+')
5579 if project_url in metrics_utils.KNOWN_PROJECT_URLS:
5580 metrics.collector.add('project_urls', [project_url])
5581
5582 def _parse_args(self, args=None):
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005583 # Create an optparse.Values object that will store only the actual passed
5584 # options, without the defaults.
5585 actual_options = optparse.Values()
5586 _, args = optparse.OptionParser.parse_args(self, args, actual_options)
5587 # Create an optparse.Values object with the default options.
5588 options = optparse.Values(self.get_default_values().__dict__)
5589 # Update it with the options passed by the user.
5590 options._update_careful(actual_options.__dict__)
5591 # Store the options passed by the user in an _actual_options attribute.
5592 # We store only the keys, and not the values, since the values can contain
5593 # arbitrary information, which might be PII.
Edward Lemur79d4f992019-11-11 23:49:02 +00005594 metrics.collector.add('arguments', list(actual_options.__dict__.keys()))
Edward Lemur5ba1e9c2018-07-23 18:19:02 +00005595
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005596 levels = [logging.WARNING, logging.INFO, logging.DEBUG]
Andrii Shyshkalov5b04a572017-01-23 17:44:41 +01005597 logging.basicConfig(
5598 level=levels[min(options.verbose, len(levels) - 1)],
5599 format='[%(levelname).1s%(asctime)s %(process)d %(thread)d '
5600 '%(filename)s] %(message)s')
Edward Lemur83bd7f42018-10-10 00:14:21 +00005601
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005602 return options, args
5603
iannucci@chromium.orgd9c1b202013-07-24 23:52:11 +00005604
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005605def main(argv):
maruel@chromium.org82798cb2012-02-23 18:16:12 +00005606 if sys.hexversion < 0x02060000:
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005607 print('\nYour Python version %s is unsupported, please upgrade.\n' %
vapiera7fbd5a2016-06-16 09:17:49 -07005608 (sys.version.split(' ', 1)[0],), file=sys.stderr)
maruel@chromium.org82798cb2012-02-23 18:16:12 +00005609 return 2
maruel@chromium.org2e23ce32013-05-07 12:42:28 +00005610
maruel@chromium.org39c0b222013-08-17 16:57:01 +00005611 colorize_CMDstatus_doc()
maruel@chromium.org0633fb42013-08-16 20:06:14 +00005612 dispatcher = subcommand.CommandDispatcher(__name__)
5613 try:
5614 return dispatcher.execute(OptionParser(), argv)
Edward Lemur5b929a42019-10-21 17:57:39 +00005615 except auth.LoginRequiredError as e:
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +00005616 DieWithError(str(e))
Edward Lemur79d4f992019-11-11 23:49:02 +00005617 except urllib.error.HTTPError as e:
maruel@chromium.org0633fb42013-08-16 20:06:14 +00005618 if e.code != 500:
5619 raise
5620 DieWithError(
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005621 ('App Engine is misbehaving and returned HTTP %d, again. Keep faith '
Quinten Yearsleyc4202212019-07-22 23:34:40 +00005622 'and retry or visit go/isgaeup.\n%s') % (e.code, str(e)))
sbc@chromium.org013731e2015-02-26 18:28:43 +00005623 return 0
chase@chromium.orgcc51cd02010-12-23 00:48:39 +00005624
5625
5626if __name__ == '__main__':
Quinten Yearsleyd9cbe7a2019-09-03 16:49:11 +00005627 # These affect sys.stdout, so do it outside of main() to simplify mocks in
5628 # the unit tests.
maruel@chromium.org6f09cd92011-04-01 16:38:12 +00005629 fix_encoding.fix_encoding()
iannucci@chromium.org596cd5c2016-04-04 21:34:39 +00005630 setup_color.init()
Edward Lemur6f812e12018-07-31 22:45:57 +00005631 with metrics.collector.print_notice_and_exit():
sbc@chromium.org013731e2015-02-26 18:28:43 +00005632 sys.exit(main(sys.argv[1:]))