commit 7f39e3d1858ab69672cc9058313d9babf32226c3
author Olivier Robin <olivierrobin@google.com> Thu Apr 28 08:20:49 2022 +0000
committer LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu Apr 28 08:20:49 2022 +0000
tree 05636155e8bce9e6e3dc76181642b24852a3521d
parent 381db68adc980da8e158f53405d25495c65aa8b2

Make swift-format default True on Mac hosts

Also make swift lint strict to catch every formatting errors.

Bug: 1263872
Change-Id: Ie717c1f03ec1a0257cafceecc2055767d0be2077
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3605589
Reviewed-by: Brian Ryner <bryner@google.com>
Auto-Submit: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Gavin Mak <gavinmak@google.com>

git_cl.py

diff --git a/git_cl.py b/git_cl.py
index 627f03e..054f659 100755
--- a/git_cl.py
+++ b/git_cl.py
@@ -5168,7 +5168,7 @@
 
   cmd = [swift_format_tool]
   if opts.dry_run:
-    cmd.append('lint')
+    cmd += ['lint', '-s']
   else:
     cmd += ['format', '-i']
   cmd += swift_diff_files
@@ -5242,7 +5242,7 @@
       '--swift-format',
       dest='use_swift_format',
       action='store_true',
-      default=False,
+      default=swift_format.IsSwiftFormatSupported(),
       help='Enables formatting of Swift file types using swift-format '
       '(macOS host only).')
   parser.add_option(