commit 4f50adb3325cbc0eb19ad3d94fd63a3dc4418817
author Weilun Shi <sweilun@chromium.org> Tue Jan 17 20:43:17 2023 +0000
committer LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue Jan 17 20:43:17 2023 +0000
tree 459fcb79ddf2aa7503e83dfd2c505d5771e7a19b
parent 7879da9e9dfc4ee3c44b7a52f446bb52de83a9a1

Remove the one-linear check for the validate_prefix file

The validate_prefix file is now rolled out on prod so we
don't need that check any more.

Bug: 1116488
Change-Id: Ibbbfd29366e3e41d8e52d65dd7553f2e521ffd63
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4167358
Commit-Queue: Gavin Mak <gavinmak@google.com>
Auto-Submit: Weilun Shi <sweilun@chromium.org>
Commit-Queue: Weilun Shi <sweilun@chromium.org>
Reviewed-by: Gavin Mak <gavinmak@google.com>

git_cl.py

diff --git a/git_cl.py b/git_cl.py
index 0e2793f..a1bbbeb 100755
--- a/git_cl.py
+++ b/git_cl.py
@@ -5648,14 +5648,8 @@
       #   $ python pretty_print.py metadata/UMA/histograms.xml
       #   $ python pretty_print.py enums.xml
 
-      # TODO (crbug/1116488): Remove this check after ensuring that the updated
-      # version of histograms/pretty_print.py is released.
-      filepath_required = os.path.exists(
-          os.path.join(tool_dir, 'validate_prefix.py'))
-
       if (diff_xml.endswith('histograms.xml') or diff_xml.endswith('enums.xml')
-          or diff_xml.endswith('histogram_suffixes_list.xml')
-          ) and filepath_required:
+          or diff_xml.endswith('histogram_suffixes_list.xml')):
         cmd.append(diff_xml)
 
       if opts.dry_run or opts.diff: