blob: a44be31e0c5bfd365e23eaa078dce6ce431e1f5b [file] [log] [blame]
maruel@chromium.org725f1c32011-04-01 20:24:54 +00001#!/usr/bin/env python
maruel@chromium.org3bbf2942012-01-10 16:52:06 +00002# Copyright (c) 2012 The Chromium Authors. All rights reserved.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00003# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5
6"""Enables directory-specific presubmit checks to run at upload and/or commit.
7"""
8
Raul Tambre80ee78e2019-05-06 22:41:05 +00009from __future__ import print_function
10
Saagar Sanghavi99816902020-08-11 22:41:25 +000011__version__ = '2.0.0'
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000012
13# TODO(joi) Add caching where appropriate/needed. The API is designed to allow
14# caching (between all different invocations of presubmit scripts for a given
15# change). We should add it as our presubmit scripts start feeling slow.
16
Edward Lemura5799e32020-01-17 19:26:51 +000017import argparse
Takeshi Yoshino07a6bea2017-08-02 02:44:06 +090018import ast # Exposed through the API.
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +000019import contextlib
Yoshisato Yanagisawa406de132018-06-29 05:43:25 +000020import cpplint
dcheng091b7db2016-06-16 01:27:51 -070021import fnmatch # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000022import glob
asvitkine@chromium.org15169952011-09-27 14:30:53 +000023import inspect
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +000024import itertools
maruel@chromium.org4f6852c2012-04-20 20:39:20 +000025import json # Exposed through the API.
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +000026import logging
ilevy@chromium.orgbc117312013-04-20 03:57:56 +000027import multiprocessing
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000028import os # Somewhat exposed through the API.
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +000029import random
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000030import re # Exposed through the API.
Edward Lesmes8e282792018-04-03 18:50:29 -040031import signal
Allen Webbfe7d7092021-05-18 02:05:49 +000032import six
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000033import sys # Parts exposed through API.
34import tempfile # Exposed through the API.
Edward Lesmes8e282792018-04-03 18:50:29 -040035import threading
jam@chromium.org2a891dc2009-08-20 20:33:37 +000036import time
Edward Lemurde9e3ca2019-10-24 21:13:31 +000037import traceback
maruel@chromium.org1487d532009-06-06 00:22:57 +000038import unittest # Exposed through the API.
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +000039from warnings import warn
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000040
41# Local imports.
maruel@chromium.org35625c72011-03-23 17:34:02 +000042import fix_encoding
Yoshisato Yanagisawa04600b42019-03-15 03:03:41 +000043import gclient_paths # Exposed through the API
44import gclient_utils
Aaron Gableb584c4f2017-04-26 16:28:08 -070045import git_footers
tandrii@chromium.org015ebae2016-04-25 19:37:22 +000046import gerrit_util
Edward Lesmes9ce03f82021-01-12 20:13:31 +000047import owners as owners_db
48import owners_client
Jochen Eisinger76f5fc62017-04-07 16:27:46 +020049import owners_finder
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000050import presubmit_canned_checks
Saagar Sanghavi9949ab72020-07-20 20:56:40 +000051import rdb_wrapper
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +000052import scm
maruel@chromium.org84f4fe32011-04-06 13:26:45 +000053import subprocess2 as subprocess # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000054
Edward Lemur16af3562019-10-17 22:11:33 +000055if sys.version_info.major == 2:
56 # TODO(1009814): Expose urllib2 only through urllib_request and urllib_error
57 import urllib2 # Exposed through the API.
58 import urlparse
59 import urllib2 as urllib_request
60 import urllib2 as urllib_error
61else:
62 import urllib.parse as urlparse
63 import urllib.request as urllib_request
64 import urllib.error as urllib_error
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000065
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +000066# Ask for feedback only once in program lifetime.
67_ASKED_FOR_FEEDBACK = False
68
Edward Lemurecc27072020-01-06 16:42:34 +000069def time_time():
70 # Use this so that it can be mocked in tests without interfering with python
71 # system machinery.
72 return time.time()
73
74
maruel@chromium.org899e1c12011-04-07 17:03:18 +000075class PresubmitFailure(Exception):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000076 pass
77
78
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000079class CommandData(object):
Edward Lemur940c2822019-08-23 00:34:25 +000080 def __init__(self, name, cmd, kwargs, message, python3=False):
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000081 self.name = name
82 self.cmd = cmd
Edward Lesmes8e282792018-04-03 18:50:29 -040083 self.stdin = kwargs.get('stdin', None)
Edward Lemur2d6b67c2019-08-23 22:25:41 +000084 self.kwargs = kwargs.copy()
Edward Lesmes8e282792018-04-03 18:50:29 -040085 self.kwargs['stdout'] = subprocess.PIPE
86 self.kwargs['stderr'] = subprocess.STDOUT
87 self.kwargs['stdin'] = subprocess.PIPE
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000088 self.message = message
89 self.info = None
Edward Lemur940c2822019-08-23 00:34:25 +000090 self.python3 = python3
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000091
ilevy@chromium.orgbc117312013-04-20 03:57:56 +000092
Edward Lesmes8e282792018-04-03 18:50:29 -040093# Adapted from
94# https://github.com/google/gtest-parallel/blob/master/gtest_parallel.py#L37
95#
96# An object that catches SIGINT sent to the Python process and notices
97# if processes passed to wait() die by SIGINT (we need to look for
98# both of those cases, because pressing Ctrl+C can result in either
99# the main process or one of the subprocesses getting the signal).
100#
101# Before a SIGINT is seen, wait(p) will simply call p.wait() and
102# return the result. Once a SIGINT has been seen (in the main process
103# or a subprocess, including the one the current call is waiting for),
Edward Lemur9a5bb612019-09-26 02:01:52 +0000104# wait(p) will call p.terminate().
Edward Lesmes8e282792018-04-03 18:50:29 -0400105class SigintHandler(object):
Edward Lesmes8e282792018-04-03 18:50:29 -0400106 sigint_returncodes = {-signal.SIGINT, # Unix
107 -1073741510, # Windows
108 }
109 def __init__(self):
110 self.__lock = threading.Lock()
111 self.__processes = set()
112 self.__got_sigint = False
Edward Lemur9a5bb612019-09-26 02:01:52 +0000113 self.__previous_signal = signal.signal(signal.SIGINT, self.interrupt)
Edward Lesmes8e282792018-04-03 18:50:29 -0400114
115 def __on_sigint(self):
116 self.__got_sigint = True
117 while self.__processes:
118 try:
119 self.__processes.pop().terminate()
120 except OSError:
121 pass
122
Edward Lemur9a5bb612019-09-26 02:01:52 +0000123 def interrupt(self, signal_num, frame):
Edward Lesmes8e282792018-04-03 18:50:29 -0400124 with self.__lock:
125 self.__on_sigint()
Edward Lemur9a5bb612019-09-26 02:01:52 +0000126 self.__previous_signal(signal_num, frame)
Edward Lesmes8e282792018-04-03 18:50:29 -0400127
128 def got_sigint(self):
129 with self.__lock:
130 return self.__got_sigint
131
132 def wait(self, p, stdin):
133 with self.__lock:
134 if self.__got_sigint:
135 p.terminate()
136 self.__processes.add(p)
137 stdout, stderr = p.communicate(stdin)
138 code = p.returncode
139 with self.__lock:
140 self.__processes.discard(p)
141 if code in self.sigint_returncodes:
142 self.__on_sigint()
Edward Lesmes8e282792018-04-03 18:50:29 -0400143 return stdout, stderr
144
145sigint_handler = SigintHandler()
146
147
Edward Lemurecc27072020-01-06 16:42:34 +0000148class Timer(object):
149 def __init__(self, timeout, fn):
150 self.completed = False
151 self._fn = fn
152 self._timer = threading.Timer(timeout, self._onTimer) if timeout else None
153
154 def __enter__(self):
155 if self._timer:
156 self._timer.start()
157 return self
158
159 def __exit__(self, _type, _value, _traceback):
160 if self._timer:
161 self._timer.cancel()
162
163 def _onTimer(self):
164 self._fn()
165 self.completed = True
166
167
Edward Lesmes8e282792018-04-03 18:50:29 -0400168class ThreadPool(object):
Edward Lemurecc27072020-01-06 16:42:34 +0000169 def __init__(self, pool_size=None, timeout=None):
170 self.timeout = timeout
Edward Lesmes8e282792018-04-03 18:50:29 -0400171 self._pool_size = pool_size or multiprocessing.cpu_count()
172 self._messages = []
173 self._messages_lock = threading.Lock()
174 self._tests = []
175 self._tests_lock = threading.Lock()
176 self._nonparallel_tests = []
177
Edward Lemurecc27072020-01-06 16:42:34 +0000178 def _GetCommand(self, test):
Edward Lemur940c2822019-08-23 00:34:25 +0000179 vpython = 'vpython'
180 if test.python3:
181 vpython += '3'
182 if sys.platform == 'win32':
183 vpython += '.bat'
Edward Lesmes8e282792018-04-03 18:50:29 -0400184
185 cmd = test.cmd
186 if cmd[0] == 'python':
187 cmd = list(cmd)
188 cmd[0] = vpython
189 elif cmd[0].endswith('.py'):
190 cmd = [vpython] + cmd
191
Edward Lemur336e51f2019-11-14 21:42:04 +0000192 # On Windows, scripts on the current directory take precedence over PATH, so
193 # that when testing depot_tools on Windows, calling `vpython.bat` will
194 # execute the copy of vpython of the depot_tools under test instead of the
195 # one in the bot.
196 # As a workaround, we run the tests from the parent directory instead.
197 if (cmd[0] == vpython and
198 'cwd' in test.kwargs and
199 os.path.basename(test.kwargs['cwd']) == 'depot_tools'):
200 test.kwargs['cwd'] = os.path.dirname(test.kwargs['cwd'])
201 cmd[1] = os.path.join('depot_tools', cmd[1])
202
Edward Lemurecc27072020-01-06 16:42:34 +0000203 return cmd
204
205 def _RunWithTimeout(self, cmd, stdin, kwargs):
206 p = subprocess.Popen(cmd, **kwargs)
207 with Timer(self.timeout, p.terminate) as timer:
208 stdout, _ = sigint_handler.wait(p, stdin)
209 if timer.completed:
210 stdout = 'Process timed out after %ss\n%s' % (self.timeout, stdout)
Josip Sokcevicb4a7cff2021-06-09 22:56:42 +0000211 return p.returncode, stdout.decode('utf-8', 'ignore');
Edward Lemurecc27072020-01-06 16:42:34 +0000212
213 def CallCommand(self, test):
214 """Runs an external program.
215
Edward Lemura5799e32020-01-17 19:26:51 +0000216 This function converts invocation of .py files and invocations of 'python'
Edward Lemurecc27072020-01-06 16:42:34 +0000217 to vpython invocations.
218 """
219 cmd = self._GetCommand(test)
Edward Lesmes8e282792018-04-03 18:50:29 -0400220 try:
Edward Lemurecc27072020-01-06 16:42:34 +0000221 start = time_time()
222 returncode, stdout = self._RunWithTimeout(cmd, test.stdin, test.kwargs)
223 duration = time_time() - start
Edward Lemur7cf94382019-11-15 22:36:41 +0000224 except Exception:
Edward Lemurecc27072020-01-06 16:42:34 +0000225 duration = time_time() - start
Edward Lesmes8e282792018-04-03 18:50:29 -0400226 return test.message(
Edward Lemur7cf94382019-11-15 22:36:41 +0000227 '%s\n%s exec failure (%4.2fs)\n%s' % (
228 test.name, ' '.join(cmd), duration, traceback.format_exc()))
Edward Lemurde9e3ca2019-10-24 21:13:31 +0000229
Edward Lemurecc27072020-01-06 16:42:34 +0000230 if returncode != 0:
Edward Lesmes8e282792018-04-03 18:50:29 -0400231 return test.message(
Edward Lemur7cf94382019-11-15 22:36:41 +0000232 '%s\n%s (%4.2fs) failed\n%s' % (
233 test.name, ' '.join(cmd), duration, stdout))
Edward Lemurecc27072020-01-06 16:42:34 +0000234
Edward Lesmes8e282792018-04-03 18:50:29 -0400235 if test.info:
Edward Lemur7cf94382019-11-15 22:36:41 +0000236 return test.info('%s\n%s (%4.2fs)' % (test.name, ' '.join(cmd), duration))
Edward Lesmes8e282792018-04-03 18:50:29 -0400237
238 def AddTests(self, tests, parallel=True):
239 if parallel:
240 self._tests.extend(tests)
241 else:
242 self._nonparallel_tests.extend(tests)
243
244 def RunAsync(self):
245 self._messages = []
246
247 def _WorkerFn():
248 while True:
249 test = None
250 with self._tests_lock:
251 if not self._tests:
252 break
253 test = self._tests.pop()
254 result = self.CallCommand(test)
255 if result:
256 with self._messages_lock:
257 self._messages.append(result)
258
259 def _StartDaemon():
260 t = threading.Thread(target=_WorkerFn)
261 t.daemon = True
262 t.start()
263 return t
264
265 while self._nonparallel_tests:
266 test = self._nonparallel_tests.pop()
267 result = self.CallCommand(test)
268 if result:
269 self._messages.append(result)
270
271 if self._tests:
272 threads = [_StartDaemon() for _ in range(self._pool_size)]
273 for worker in threads:
274 worker.join()
275
276 return self._messages
277
278
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000279def normpath(path):
280 '''Version of os.path.normpath that also changes backward slashes to
281 forward slashes when not running on Windows.
282 '''
283 # This is safe to always do because the Windows version of os.path.normpath
284 # will replace forward slashes with backward slashes.
285 path = path.replace(os.sep, '/')
286 return os.path.normpath(path)
287
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000288
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000289def _RightHandSideLinesImpl(affected_files):
290 """Implements RightHandSideLines for InputApi and GclChange."""
291 for af in affected_files:
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000292 lines = af.ChangedContents()
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000293 for line in lines:
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000294 yield (af, line[0], line[1])
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000295
296
Edward Lemur6eb1d322020-02-27 22:20:15 +0000297def prompt_should_continue(prompt_string):
298 sys.stdout.write(prompt_string)
Dirk Pranke7288f882021-06-03 18:01:30 +0000299 sys.stdout.flush()
Edward Lemur6eb1d322020-02-27 22:20:15 +0000300 response = sys.stdin.readline().strip().lower()
301 return response in ('y', 'yes')
dpranke@chromium.org5ac21012011-03-16 02:58:25 +0000302
303
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000304# Top level object so multiprocessing can pickle
305# Public access through OutputApi object.
306class _PresubmitResult(object):
307 """Base class for result objects."""
308 fatal = False
309 should_prompt = False
310
311 def __init__(self, message, items=None, long_text=''):
312 """
313 message: A short one-line message to indicate errors.
314 items: A list of short strings to indicate where errors occurred.
315 long_text: multi-line text output, e.g. from another tool
316 """
317 self._message = message
318 self._items = items or []
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000319 self._long_text = long_text.rstrip()
320
Edward Lemur6eb1d322020-02-27 22:20:15 +0000321 def handle(self):
322 sys.stdout.write(self._message)
323 sys.stdout.write('\n')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000324 for index, item in enumerate(self._items):
Edward Lemur6eb1d322020-02-27 22:20:15 +0000325 sys.stdout.write(' ')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000326 # Write separately in case it's unicode.
Edward Lemur6eb1d322020-02-27 22:20:15 +0000327 sys.stdout.write(str(item))
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000328 if index < len(self._items) - 1:
Edward Lemur6eb1d322020-02-27 22:20:15 +0000329 sys.stdout.write(' \\')
330 sys.stdout.write('\n')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000331 if self._long_text:
Edward Lemur6eb1d322020-02-27 22:20:15 +0000332 sys.stdout.write('\n***************\n')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000333 # Write separately in case it's unicode.
Edward Lemur6eb1d322020-02-27 22:20:15 +0000334 sys.stdout.write(self._long_text)
335 sys.stdout.write('\n***************\n')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000336
Debrian Figueroadd2737e2019-06-21 23:50:13 +0000337 def json_format(self):
338 return {
339 'message': self._message,
Debrian Figueroa6095d402019-06-28 18:47:18 +0000340 'items': [str(item) for item in self._items],
Debrian Figueroadd2737e2019-06-21 23:50:13 +0000341 'long_text': self._long_text,
342 'fatal': self.fatal
343 }
344
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000345
346# Top level object so multiprocessing can pickle
347# Public access through OutputApi object.
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000348class _PresubmitError(_PresubmitResult):
349 """A hard presubmit error."""
350 fatal = True
351
352
353# Top level object so multiprocessing can pickle
354# Public access through OutputApi object.
355class _PresubmitPromptWarning(_PresubmitResult):
356 """An warning that prompts the user if they want to continue."""
357 should_prompt = True
358
359
360# Top level object so multiprocessing can pickle
361# Public access through OutputApi object.
362class _PresubmitNotifyResult(_PresubmitResult):
363 """Just print something to the screen -- but it's not even a warning."""
364 pass
365
366
367# Top level object so multiprocessing can pickle
368# Public access through OutputApi object.
369class _MailTextResult(_PresubmitResult):
370 """A warning that should be included in the review request email."""
371 def __init__(self, *args, **kwargs):
372 super(_MailTextResult, self).__init__()
373 raise NotImplementedError()
374
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000375class GerritAccessor(object):
376 """Limited Gerrit functionality for canned presubmit checks to work.
377
378 To avoid excessive Gerrit calls, caches the results.
379 """
380
Edward Lesmeseb1bd622021-03-01 19:54:07 +0000381 def __init__(self, url=None, project=None, branch=None):
382 self.host = urlparse.urlparse(url).netloc if url else None
383 self.project = project
384 self.branch = branch
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000385 self.cache = {}
Edward Lesmes8170c292021-03-19 20:04:43 +0000386 self.code_owners_enabled = None
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000387
388 def _FetchChangeDetail(self, issue):
389 # Separate function to be easily mocked in tests.
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +0100390 try:
391 return gerrit_util.GetChangeDetail(
392 self.host, str(issue),
Aaron Gable6f5a8d92017-04-18 14:49:05 -0700393 ['ALL_REVISIONS', 'DETAILED_LABELS', 'ALL_COMMITS'])
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +0100394 except gerrit_util.GerritError as e:
395 if e.http_status == 404:
396 raise Exception('Either Gerrit issue %s doesn\'t exist, or '
397 'no credentials to fetch issue details' % issue)
398 raise
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000399
400 def GetChangeInfo(self, issue):
401 """Returns labels and all revisions (patchsets) for this issue.
402
403 The result is a dictionary according to Gerrit REST Api.
404 https://gerrit-review.googlesource.com/Documentation/rest-api.html
405
406 However, API isn't very clear what's inside, so see tests for example.
407 """
408 assert issue
409 cache_key = int(issue)
410 if cache_key not in self.cache:
411 self.cache[cache_key] = self._FetchChangeDetail(issue)
412 return self.cache[cache_key]
413
414 def GetChangeDescription(self, issue, patchset=None):
415 """If patchset is none, fetches current patchset."""
416 info = self.GetChangeInfo(issue)
417 # info is a reference to cache. We'll modify it here adding description to
418 # it to the right patchset, if it is not yet there.
419
420 # Find revision info for the patchset we want.
421 if patchset is not None:
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +0000422 for rev, rev_info in info['revisions'].items():
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000423 if str(rev_info['_number']) == str(patchset):
424 break
425 else:
426 raise Exception('patchset %s doesn\'t exist in issue %s' % (
427 patchset, issue))
428 else:
429 rev = info['current_revision']
430 rev_info = info['revisions'][rev]
431
Andrii Shyshkalov9c3a4642017-01-24 17:41:22 +0100432 return rev_info['commit']['message']
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000433
Mun Yong Jang603d01e2017-12-19 16:38:30 -0800434 def GetDestRef(self, issue):
435 ref = self.GetChangeInfo(issue)['branch']
436 if not ref.startswith('refs/'):
437 # NOTE: it is possible to create 'refs/x' branch,
438 # aka 'refs/heads/refs/x'. However, this is ill-advised.
439 ref = 'refs/heads/%s' % ref
440 return ref
441
Edward Lesmes02d4b822020-11-11 00:37:35 +0000442 def _GetApproversForLabel(self, issue, label):
443 change_info = self.GetChangeInfo(issue)
444 label_info = change_info.get('labels', {}).get(label, {})
445 values = label_info.get('values', {}).keys()
446 if not values:
447 return []
448 max_value = max(int(v) for v in values)
449 return [v for v in label_info.get('all', [])
450 if v.get('value', 0) == max_value]
451
Edward Lesmesc4566172021-03-19 16:55:13 +0000452 def IsBotCommitApproved(self, issue):
453 return bool(self._GetApproversForLabel(issue, 'Bot-Commit'))
454
Edward Lesmescf49cb82020-11-11 01:08:36 +0000455 def IsOwnersOverrideApproved(self, issue):
456 return bool(self._GetApproversForLabel(issue, 'Owners-Override'))
457
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000458 def GetChangeOwner(self, issue):
459 return self.GetChangeInfo(issue)['owner']['email']
460
461 def GetChangeReviewers(self, issue, approving_only=True):
Aaron Gable8b478f02017-07-31 15:33:19 -0700462 changeinfo = self.GetChangeInfo(issue)
463 if approving_only:
Edward Lesmes02d4b822020-11-11 00:37:35 +0000464 reviewers = self._GetApproversForLabel(issue, 'Code-Review')
Aaron Gable8b478f02017-07-31 15:33:19 -0700465 else:
466 reviewers = changeinfo.get('reviewers', {}).get('REVIEWER', [])
467 return [r.get('email') for r in reviewers]
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000468
Edward Lemure4d329c2020-02-03 20:41:18 +0000469 def UpdateDescription(self, description, issue):
470 gerrit_util.SetCommitMessage(self.host, issue, description, notify='NONE')
471
Edward Lesmes8170c292021-03-19 20:04:43 +0000472 def IsCodeOwnersEnabledOnRepo(self):
473 if self.code_owners_enabled is None:
474 self.code_owners_enabled = gerrit_util.IsCodeOwnersEnabledOnRepo(
Edward Lesmes392c4072021-03-19 21:58:45 +0000475 self.host, self.project)
Edward Lesmes8170c292021-03-19 20:04:43 +0000476 return self.code_owners_enabled
477
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000478
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000479class OutputApi(object):
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000480 """An instance of OutputApi gets passed to presubmit scripts so that they
481 can output various types of results.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000482 """
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000483 PresubmitResult = _PresubmitResult
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000484 PresubmitError = _PresubmitError
485 PresubmitPromptWarning = _PresubmitPromptWarning
486 PresubmitNotifyResult = _PresubmitNotifyResult
487 MailTextResult = _MailTextResult
488
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000489 def __init__(self, is_committing):
490 self.is_committing = is_committing
Daniel Cheng7227d212017-11-17 08:12:37 -0800491 self.more_cc = []
492
493 def AppendCC(self, cc):
494 """Appends a user to cc for this change."""
495 self.more_cc.append(cc)
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000496
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000497 def PresubmitPromptOrNotify(self, *args, **kwargs):
498 """Warn the user when uploading, but only notify if committing."""
499 if self.is_committing:
500 return self.PresubmitNotifyResult(*args, **kwargs)
501 return self.PresubmitPromptWarning(*args, **kwargs)
502
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000503
504class InputApi(object):
505 """An instance of this object is passed to presubmit scripts so they can
506 know stuff about the change they're looking at.
507 """
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000508 # Method could be a function
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800509 # pylint: disable=no-self-use
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000510
maruel@chromium.org3410d912009-06-09 20:56:16 +0000511 # File extensions that are considered source files from a style guide
512 # perspective. Don't modify this list from a presubmit script!
maruel@chromium.orgc33455a2011-06-24 19:14:18 +0000513 #
514 # Files without an extension aren't included in the list. If you want to
local_bot30f774e2020-06-25 18:23:34 +0000515 # filter them as source files, add r'(^|.*?[\\\/])[^.]+$' to the allow list.
local_bot64021412020-07-08 21:05:39 +0000516 # Note that ALL CAPS files are skipped in DEFAULT_FILES_TO_SKIP below.
517 DEFAULT_FILES_TO_CHECK = (
maruel@chromium.org3410d912009-06-09 20:56:16 +0000518 # C++ and friends
Edward Lemura5799e32020-01-17 19:26:51 +0000519 r'.+\.c$', r'.+\.cc$', r'.+\.cpp$', r'.+\.h$', r'.+\.m$', r'.+\.mm$',
520 r'.+\.inl$', r'.+\.asm$', r'.+\.hxx$', r'.+\.hpp$', r'.+\.s$', r'.+\.S$',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000521 # Scripts
Edward Lemura5799e32020-01-17 19:26:51 +0000522 r'.+\.js$', r'.+\.py$', r'.+\.sh$', r'.+\.rb$', r'.+\.pl$', r'.+\.pm$',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000523 # Other
Edward Lemura5799e32020-01-17 19:26:51 +0000524 r'.+\.java$', r'.+\.mk$', r'.+\.am$', r'.+\.css$', r'.+\.mojom$',
525 r'.+\.fidl$'
maruel@chromium.org3410d912009-06-09 20:56:16 +0000526 )
527
528 # Path regexp that should be excluded from being considered containing source
529 # files. Don't modify this list from a presubmit script!
local_bot64021412020-07-08 21:05:39 +0000530 DEFAULT_FILES_TO_SKIP = (
Edward Lemura5799e32020-01-17 19:26:51 +0000531 r'testing_support[\\\/]google_appengine[\\\/].*',
532 r'.*\bexperimental[\\\/].*',
Kent Tamura179dd1e2018-04-26 15:07:41 +0900533 # Exclude third_party/.* but NOT third_party/{WebKit,blink}
534 # (crbug.com/539768 and crbug.com/836555).
Edward Lemura5799e32020-01-17 19:26:51 +0000535 r'.*\bthird_party[\\\/](?!(WebKit|blink)[\\\/]).*',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000536 # Output directories (just in case)
Edward Lemura5799e32020-01-17 19:26:51 +0000537 r'.*\bDebug[\\\/].*',
538 r'.*\bRelease[\\\/].*',
539 r'.*\bxcodebuild[\\\/].*',
540 r'.*\bout[\\\/].*',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000541 # All caps files like README and LICENCE.
Edward Lemura5799e32020-01-17 19:26:51 +0000542 r'.*\b[A-Z0-9_]{2,}$',
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +0000543 # SCM (can happen in dual SCM configuration). (Slightly over aggressive)
Edward Lemura5799e32020-01-17 19:26:51 +0000544 r'(|.*[\\\/])\.git[\\\/].*',
545 r'(|.*[\\\/])\.svn[\\\/].*',
maruel@chromium.org7ccb4bb2011-11-07 20:26:20 +0000546 # There is no point in processing a patch file.
Edward Lemura5799e32020-01-17 19:26:51 +0000547 r'.+\.diff$',
548 r'.+\.patch$',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000549 )
550
local_bot30f774e2020-06-25 18:23:34 +0000551 # TODO(https://crbug.com/1098562): Remove once no longer used
552 @property
553 def DEFAULT_WHITE_LIST(self):
local_bot64021412020-07-08 21:05:39 +0000554 return self.DEFAULT_FILES_TO_CHECK
local_bot30f774e2020-06-25 18:23:34 +0000555
556 # TODO(https://crbug.com/1098562): Remove once no longer used
local_bot37ce2012020-06-26 17:39:24 +0000557 @DEFAULT_WHITE_LIST.setter
558 def DEFAULT_WHITE_LIST(self, value):
local_bot64021412020-07-08 21:05:39 +0000559 self.DEFAULT_FILES_TO_CHECK = value
560
561 # TODO(https://crbug.com/1098562): Remove once no longer used
562 @property
563 def DEFAULT_ALLOW_LIST(self):
564 return self.DEFAULT_FILES_TO_CHECK
565
566 # TODO(https://crbug.com/1098562): Remove once no longer used
567 @DEFAULT_ALLOW_LIST.setter
568 def DEFAULT_ALLOW_LIST(self, value):
569 self.DEFAULT_FILES_TO_CHECK = value
local_bot37ce2012020-06-26 17:39:24 +0000570
571 # TODO(https://crbug.com/1098562): Remove once no longer used
local_bot30f774e2020-06-25 18:23:34 +0000572 @property
573 def DEFAULT_BLACK_LIST(self):
local_bot64021412020-07-08 21:05:39 +0000574 return self.DEFAULT_FILES_TO_SKIP
local_bot30f774e2020-06-25 18:23:34 +0000575
local_bot37ce2012020-06-26 17:39:24 +0000576 # TODO(https://crbug.com/1098562): Remove once no longer used
577 @DEFAULT_BLACK_LIST.setter
578 def DEFAULT_BLACK_LIST(self, value):
local_bot64021412020-07-08 21:05:39 +0000579 self.DEFAULT_FILES_TO_SKIP = value
580
581 # TODO(https://crbug.com/1098562): Remove once no longer used
582 @property
583 def DEFAULT_BLOCK_LIST(self):
584 return self.DEFAULT_FILES_TO_SKIP
585
586 # TODO(https://crbug.com/1098562): Remove once no longer used
587 @DEFAULT_BLOCK_LIST.setter
588 def DEFAULT_BLOCK_LIST(self, value):
589 self.DEFAULT_FILES_TO_SKIP = value
local_bot37ce2012020-06-26 17:39:24 +0000590
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000591 def __init__(self, change, presubmit_path, is_committing,
Edward Lesmes8e282792018-04-03 18:50:29 -0400592 verbose, gerrit_obj, dry_run=None, thread_pool=None, parallel=False):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000593 """Builds an InputApi object.
594
595 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000596 change: A presubmit.Change object.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000597 presubmit_path: The path to the presubmit script being processed.
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000598 is_committing: True if the change is about to be committed.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000599 gerrit_obj: provides basic Gerrit codereview functionality.
600 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -0400601 parallel: if true, all tests reported via input_api.RunTests for all
602 PRESUBMIT files will be run in parallel.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000603 """
maruel@chromium.org9711bba2009-05-22 23:51:39 +0000604 # Version number of the presubmit_support script.
605 self.version = [int(x) for x in __version__.split('.')]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000606 self.change = change
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000607 self.is_committing = is_committing
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000608 self.gerrit = gerrit_obj
tandrii@chromium.org57bafac2016-04-28 05:09:03 +0000609 self.dry_run = dry_run
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000610
Edward Lesmes8e282792018-04-03 18:50:29 -0400611 self.parallel = parallel
612 self.thread_pool = thread_pool or ThreadPool()
613
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000614 # We expose various modules and functions as attributes of the input_api
615 # so that presubmit scripts don't have to import them.
Takeshi Yoshino07a6bea2017-08-02 02:44:06 +0900616 self.ast = ast
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000617 self.basename = os.path.basename
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000618 self.cpplint = cpplint
dcheng091b7db2016-06-16 01:27:51 -0700619 self.fnmatch = fnmatch
Yoshisato Yanagisawa04600b42019-03-15 03:03:41 +0000620 self.gclient_paths = gclient_paths
Yoshisato Yanagisawa57dd17b2019-03-22 09:10:29 +0000621 # TODO(yyanagisawa): stop exposing this when python3 become default.
622 # Since python3's tempfile has TemporaryDirectory, we do not need this.
623 self.temporary_directory = gclient_utils.temporary_directory
dpranke@chromium.org17cc2442012-10-17 21:12:09 +0000624 self.glob = glob.glob
maruel@chromium.orgfb11c7b2010-03-18 18:22:14 +0000625 self.json = json
maruel@chromium.org6fba34d2011-06-02 13:45:12 +0000626 self.logging = logging.getLogger('PRESUBMIT')
maruel@chromium.org2b5ce562011-03-31 16:15:44 +0000627 self.os_listdir = os.listdir
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000628 self.os_path = os.path
pgervais@chromium.orgbd0cace2014-10-02 23:23:46 +0000629 self.os_stat = os.stat
Yoshisato Yanagisawa406de132018-06-29 05:43:25 +0000630 self.os_walk = os.walk
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000631 self.re = re
632 self.subprocess = subprocess
Edward Lemurb9830242019-10-30 22:19:20 +0000633 self.sys = sys
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000634 self.tempfile = tempfile
dpranke@chromium.org0d1bdea2011-03-24 22:54:38 +0000635 self.time = time
maruel@chromium.org1487d532009-06-06 00:22:57 +0000636 self.unittest = unittest
Edward Lemurb9830242019-10-30 22:19:20 +0000637 if sys.version_info.major == 2:
638 self.urllib2 = urllib2
Edward Lemur16af3562019-10-17 22:11:33 +0000639 self.urllib_request = urllib_request
640 self.urllib_error = urllib_error
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000641
Robert Iannucci50258932018-03-19 10:30:59 -0700642 self.is_windows = sys.platform == 'win32'
643
Edward Lemurb9646622019-10-25 20:57:35 +0000644 # Set python_executable to 'vpython' in order to allow scripts in other
645 # repos (e.g. src.git) to automatically pick up that repo's .vpython file,
646 # instead of inheriting the one in depot_tools.
647 self.python_executable = 'vpython'
Erik Staab69135d12021-05-14 22:31:57 +0000648 # Offer a python 3 executable for use during the migration off of python 2.
649 self.python3_executable = 'vpython3'
maruel@chromium.orgc0b22972009-06-25 16:19:14 +0000650 self.environ = os.environ
651
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000652 # InputApi.platform is the platform you're currently running on.
653 self.platform = sys.platform
654
iannucci@chromium.org0af3bb32015-06-12 20:44:35 +0000655 self.cpu_count = multiprocessing.cpu_count()
656
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000657 # The local path of the currently-being-processed presubmit script.
maruel@chromium.org3d235242009-05-15 12:40:48 +0000658 self._current_presubmit_path = os.path.dirname(presubmit_path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000659
660 # We carry the canned checks so presubmit scripts can easily use them.
661 self.canned_checks = presubmit_canned_checks
662
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +0100663 # Temporary files we must manually remove at the end of a run.
664 self._named_temporary_files = []
Jochen Eisinger72606f82017-04-04 10:44:18 +0200665
Edward Lesmesdc11c6b2021-03-19 19:22:05 +0000666 self.owners_client = None
667 if self.gerrit:
668 self.owners_client = owners_client.GetCodeOwnersClient(
669 root=change.RepositoryRoot(),
670 upstream=change.UpstreamBranch(),
671 host=self.gerrit.host,
672 project=self.gerrit.project,
673 branch=self.gerrit.branch)
Edward Lesmes9ce03f82021-01-12 20:13:31 +0000674 self.owners_db = owners_db.Database(
675 change.RepositoryRoot(), fopen=open, os_path=self.os_path)
Jochen Eisinger76f5fc62017-04-07 16:27:46 +0200676 self.owners_finder = owners_finder.OwnersFinder
maruel@chromium.org899e1c12011-04-07 17:03:18 +0000677 self.verbose = verbose
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000678 self.Command = CommandData
dpranke@chromium.org2a009622011-03-01 02:43:31 +0000679
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000680 # Replace <hash_map> and <hash_set> as headers that need to be included
Edward Lemura5799e32020-01-17 19:26:51 +0000681 # with 'base/containers/hash_tables.h' instead.
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000682 # Access to a protected member _XX of a client class
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800683 # pylint: disable=protected-access
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000684 self.cpplint._re_pattern_templates = [
danakj@chromium.org18278522013-06-11 22:42:32 +0000685 (a, b, 'base/containers/hash_tables.h')
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000686 if header in ('<hash_map>', '<hash_set>') else (a, b, header)
687 for (a, b, header) in cpplint._re_pattern_templates
688 ]
689
Edward Lemurecc27072020-01-06 16:42:34 +0000690 def SetTimeout(self, timeout):
691 self.thread_pool.timeout = timeout
692
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000693 def PresubmitLocalPath(self):
694 """Returns the local path of the presubmit script currently being run.
695
696 This is useful if you don't want to hard-code absolute paths in the
697 presubmit script. For example, It can be used to find another file
698 relative to the PRESUBMIT.py script, so the whole tree can be branched and
699 the presubmit script still works, without editing its content.
700 """
maruel@chromium.org3d235242009-05-15 12:40:48 +0000701 return self._current_presubmit_path
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000702
agable0b65e732016-11-22 09:25:46 -0800703 def AffectedFiles(self, include_deletes=True, file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000704 """Same as input_api.change.AffectedFiles() except only lists files
705 (and optionally directories) in the same directory as the current presubmit
Bruce Dawson7a0b07a2020-04-23 17:14:40 +0000706 script, or subdirectories thereof. Note that files are listed using the OS
707 path separator, so backslashes are used as separators on Windows.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000708 """
Edward Lemura5799e32020-01-17 19:26:51 +0000709 dir_with_slash = normpath('%s/' % self.PresubmitLocalPath())
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000710 if len(dir_with_slash) == 1:
711 dir_with_slash = ''
sail@chromium.org5538e022011-05-12 17:53:16 +0000712
Edward Lemurb9830242019-10-30 22:19:20 +0000713 return list(filter(
maruel@chromium.org4661e0c2009-06-04 00:45:26 +0000714 lambda x: normpath(x.AbsoluteLocalPath()).startswith(dir_with_slash),
Edward Lemurb9830242019-10-30 22:19:20 +0000715 self.change.AffectedFiles(include_deletes, file_filter)))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000716
agable0b65e732016-11-22 09:25:46 -0800717 def LocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000718 """Returns local paths of input_api.AffectedFiles()."""
agable0b65e732016-11-22 09:25:46 -0800719 paths = [af.LocalPath() for af in self.AffectedFiles()]
Edward Lemura5799e32020-01-17 19:26:51 +0000720 logging.debug('LocalPaths: %s', paths)
pgervais@chromium.org2f64f782014-04-25 00:12:33 +0000721 return paths
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000722
agable0b65e732016-11-22 09:25:46 -0800723 def AbsoluteLocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000724 """Returns absolute local paths of input_api.AffectedFiles()."""
agable0b65e732016-11-22 09:25:46 -0800725 return [af.AbsoluteLocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000726
John Budorick16162372018-04-18 10:39:53 -0700727 def AffectedTestableFiles(self, include_deletes=None, **kwargs):
agable0b65e732016-11-22 09:25:46 -0800728 """Same as input_api.change.AffectedTestableFiles() except only lists files
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000729 in the same directory as the current presubmit script, or subdirectories
730 thereof.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000731 """
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000732 if include_deletes is not None:
Edward Lemura5799e32020-01-17 19:26:51 +0000733 warn('AffectedTestableFiles(include_deletes=%s)'
734 ' is deprecated and ignored' % str(include_deletes),
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000735 category=DeprecationWarning,
736 stacklevel=2)
Edward Lemurb9830242019-10-30 22:19:20 +0000737 return list(filter(
738 lambda x: x.IsTestableFile(),
739 self.AffectedFiles(include_deletes=False, **kwargs)))
agable0b65e732016-11-22 09:25:46 -0800740
741 def AffectedTextFiles(self, include_deletes=None):
742 """An alias to AffectedTestableFiles for backwards compatibility."""
743 return self.AffectedTestableFiles(include_deletes=include_deletes)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000744
Josip Sokcevic8c955952021-02-01 21:32:57 +0000745 def FilterSourceFile(self,
746 affected_file,
747 files_to_check=None,
748 files_to_skip=None,
749 allow_list=None,
750 block_list=None):
Edward Lemura5799e32020-01-17 19:26:51 +0000751 """Filters out files that aren't considered 'source file'.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000752
local_bot64021412020-07-08 21:05:39 +0000753 If files_to_check or files_to_skip is None, InputApi.DEFAULT_FILES_TO_CHECK
754 and InputApi.DEFAULT_FILES_TO_SKIP is used respectively.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000755
756 The lists will be compiled as regular expression and
757 AffectedFile.LocalPath() needs to pass both list.
758
759 Note: Copy-paste this function to suit your needs or use a lambda function.
760 """
local_bot64021412020-07-08 21:05:39 +0000761 if files_to_check is None:
762 files_to_check = self.DEFAULT_FILES_TO_CHECK
763 if files_to_skip is None:
764 files_to_skip = self.DEFAULT_FILES_TO_SKIP
local_bot30f774e2020-06-25 18:23:34 +0000765
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000766 def Find(affected_file, items):
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000767 local_path = affected_file.LocalPath()
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000768 for item in items:
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +0000769 if self.re.match(item, local_path):
maruel@chromium.org3410d912009-06-09 20:56:16 +0000770 return True
771 return False
local_bot64021412020-07-08 21:05:39 +0000772 return (Find(affected_file, files_to_check) and
773 not Find(affected_file, files_to_skip))
maruel@chromium.org3410d912009-06-09 20:56:16 +0000774
775 def AffectedSourceFiles(self, source_file):
agable0b65e732016-11-22 09:25:46 -0800776 """Filter the list of AffectedTestableFiles by the function source_file.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000777
778 If source_file is None, InputApi.FilterSourceFile() is used.
779 """
780 if not source_file:
781 source_file = self.FilterSourceFile
Edward Lemurb9830242019-10-30 22:19:20 +0000782 return list(filter(source_file, self.AffectedTestableFiles()))
maruel@chromium.org3410d912009-06-09 20:56:16 +0000783
784 def RightHandSideLines(self, source_file_filter=None):
Edward Lemura5799e32020-01-17 19:26:51 +0000785 """An iterator over all text lines in 'new' version of changed files.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000786
787 Only lists lines from new or modified text files in the change that are
788 contained by the directory of the currently executing presubmit script.
789
790 This is useful for doing line-by-line regex checks, like checking for
791 trailing whitespace.
792
793 Yields:
794 a 3 tuple:
795 the AffectedFile instance of the current file;
796 integer line number (1-based); and
797 the contents of the line as a string.
maruel@chromium.org1487d532009-06-06 00:22:57 +0000798
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000799 Note: The carriage return (LF or CR) is stripped off.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000800 """
maruel@chromium.org3410d912009-06-09 20:56:16 +0000801 files = self.AffectedSourceFiles(source_file_filter)
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000802 return _RightHandSideLinesImpl(files)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000803
maruel@chromium.orge3608df2009-11-10 20:22:57 +0000804 def ReadFile(self, file_item, mode='r'):
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000805 """Reads an arbitrary file.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000806
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000807 Deny reading anything outside the repository.
808 """
maruel@chromium.orge3608df2009-11-10 20:22:57 +0000809 if isinstance(file_item, AffectedFile):
810 file_item = file_item.AbsoluteLocalPath()
811 if not file_item.startswith(self.change.RepositoryRoot()):
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000812 raise IOError('Access outside the repository root is denied.')
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +0000813 return gclient_utils.FileRead(file_item, mode)
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000814
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +0100815 def CreateTemporaryFile(self, **kwargs):
816 """Returns a named temporary file that must be removed with a call to
817 RemoveTemporaryFiles().
818
819 All keyword arguments are forwarded to tempfile.NamedTemporaryFile(),
820 except for |delete|, which is always set to False.
821
822 Presubmit checks that need to create a temporary file and pass it for
823 reading should use this function instead of NamedTemporaryFile(), as
824 Windows fails to open a file that is already open for writing.
825
826 with input_api.CreateTemporaryFile() as f:
827 f.write('xyz')
828 f.close()
829 input_api.subprocess.check_output(['script-that', '--reads-from',
830 f.name])
831
832
833 Note that callers of CreateTemporaryFile() should not worry about removing
834 any temporary file; this is done transparently by the presubmit handling
835 code.
836 """
837 if 'delete' in kwargs:
838 # Prevent users from passing |delete|; we take care of file deletion
839 # ourselves and this prevents unintuitive error messages when we pass
840 # delete=False and 'delete' is also in kwargs.
841 raise TypeError('CreateTemporaryFile() does not take a "delete" '
842 'argument, file deletion is handled automatically by '
843 'the same presubmit_support code that creates InputApi '
844 'objects.')
845 temp_file = self.tempfile.NamedTemporaryFile(delete=False, **kwargs)
846 self._named_temporary_files.append(temp_file.name)
847 return temp_file
848
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000849 @property
850 def tbr(self):
851 """Returns if a change is TBR'ed."""
Jeremy Romandce22502017-06-20 15:37:29 -0400852 return 'TBR' in self.change.tags or self.change.TBRsFromDescription()
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000853
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +0000854 def RunTests(self, tests_mix, parallel=True):
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000855 tests = []
856 msgs = []
857 for t in tests_mix:
Edward Lesmes8e282792018-04-03 18:50:29 -0400858 if isinstance(t, OutputApi.PresubmitResult) and t:
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000859 msgs.append(t)
860 else:
861 assert issubclass(t.message, _PresubmitResult)
862 tests.append(t)
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +0000863 if self.verbose:
864 t.info = _PresubmitNotifyResult
Edward Lemur1037c742018-05-01 18:56:04 -0400865 if not t.kwargs.get('cwd'):
866 t.kwargs['cwd'] = self.PresubmitLocalPath()
Edward Lesmes8e282792018-04-03 18:50:29 -0400867 self.thread_pool.AddTests(tests, parallel)
Edward Lemur21000eb2019-05-24 23:25:58 +0000868 # When self.parallel is True (i.e. --parallel is passed as an option)
869 # RunTests doesn't actually run tests. It adds them to a ThreadPool that
870 # will run all tests once all PRESUBMIT files are processed.
871 # Otherwise, it will run them and return the results.
872 if not self.parallel:
Edward Lesmes8e282792018-04-03 18:50:29 -0400873 msgs.extend(self.thread_pool.RunAsync())
874 return msgs
scottmg86099d72016-09-01 09:16:51 -0700875
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000876
nick@chromium.orgff526192013-06-10 19:30:26 +0000877class _DiffCache(object):
878 """Caches diffs retrieved from a particular SCM."""
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000879 def __init__(self, upstream=None):
880 """Stores the upstream revision against which all diffs will be computed."""
881 self._upstream = upstream
nick@chromium.orgff526192013-06-10 19:30:26 +0000882
883 def GetDiff(self, path, local_root):
884 """Get the diff for a particular path."""
885 raise NotImplementedError()
886
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700887 def GetOldContents(self, path, local_root):
888 """Get the old version for a particular path."""
889 raise NotImplementedError()
890
nick@chromium.orgff526192013-06-10 19:30:26 +0000891
nick@chromium.orgff526192013-06-10 19:30:26 +0000892class _GitDiffCache(_DiffCache):
893 """DiffCache implementation for git; gets all file diffs at once."""
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000894 def __init__(self, upstream):
895 super(_GitDiffCache, self).__init__(upstream=upstream)
nick@chromium.orgff526192013-06-10 19:30:26 +0000896 self._diffs_by_file = None
897
898 def GetDiff(self, path, local_root):
899 if not self._diffs_by_file:
900 # Compute a single diff for all files and parse the output; should
901 # with git this is much faster than computing one diff for each file.
902 diffs = {}
903
904 # Don't specify any filenames below, because there are command line length
905 # limits on some platforms and GenerateDiff would fail.
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000906 unified_diff = scm.GIT.GenerateDiff(local_root, files=[], full_move=True,
907 branch=self._upstream)
nick@chromium.orgff526192013-06-10 19:30:26 +0000908
909 # This regex matches the path twice, separated by a space. Note that
910 # filename itself may contain spaces.
911 file_marker = re.compile('^diff --git (?P<filename>.*) (?P=filename)$')
912 current_diff = []
913 keep_line_endings = True
914 for x in unified_diff.splitlines(keep_line_endings):
915 match = file_marker.match(x)
916 if match:
917 # Marks the start of a new per-file section.
918 diffs[match.group('filename')] = current_diff = [x]
919 elif x.startswith('diff --git'):
920 raise PresubmitFailure('Unexpected diff line: %s' % x)
921 else:
922 current_diff.append(x)
923
924 self._diffs_by_file = dict(
925 (normpath(path), ''.join(diff)) for path, diff in diffs.items())
926
927 if path not in self._diffs_by_file:
928 raise PresubmitFailure(
929 'Unified diff did not contain entry for file %s' % path)
930
931 return self._diffs_by_file[path]
932
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700933 def GetOldContents(self, path, local_root):
934 return scm.GIT.GetOldContents(local_root, path, branch=self._upstream)
935
nick@chromium.orgff526192013-06-10 19:30:26 +0000936
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000937class AffectedFile(object):
938 """Representation of a file in a change."""
nick@chromium.orgff526192013-06-10 19:30:26 +0000939
940 DIFF_CACHE = _DiffCache
941
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000942 # Method could be a function
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800943 # pylint: disable=no-self-use
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000944 def __init__(self, path, action, repository_root, diff_cache):
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000945 self._path = path
946 self._action = action
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000947 self._local_root = repository_root
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000948 self._is_directory = None
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000949 self._cached_changed_contents = None
950 self._cached_new_contents = None
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000951 self._diff_cache = diff_cache
tobiasjs2836bcf2016-08-16 04:08:16 -0700952 logging.debug('%s(%s)', self.__class__.__name__, self._path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000953
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000954 def LocalPath(self):
955 """Returns the path of this file on the local disk relative to client root.
Andrew Grieve92b8b992017-11-02 09:42:24 -0400956
957 This should be used for error messages but not for accessing files,
958 because presubmit checks are run with CWD=PresubmitLocalPath() (which is
959 often != client root).
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000960 """
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000961 return normpath(self._path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000962
963 def AbsoluteLocalPath(self):
964 """Returns the absolute path of this file on the local disk.
965 """
chase@chromium.org8e416c82009-10-06 04:30:44 +0000966 return os.path.abspath(os.path.join(self._local_root, self.LocalPath()))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000967
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000968 def Action(self):
969 """Returns the action on this opened file, e.g. A, M, D, etc."""
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000970 return self._action
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000971
agable0b65e732016-11-22 09:25:46 -0800972 def IsTestableFile(self):
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000973 """Returns True if the file is a text file and not a binary file.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000974
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000975 Deleted files are not text file."""
maruel@chromium.org1e08c002009-05-28 19:09:33 +0000976 raise NotImplementedError() # Implement when needed
977
agable0b65e732016-11-22 09:25:46 -0800978 def IsTextFile(self):
979 """An alias to IsTestableFile for backwards compatibility."""
980 return self.IsTestableFile()
981
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700982 def OldContents(self):
983 """Returns an iterator over the lines in the old version of file.
984
Daniel Cheng2da34fe2017-03-21 20:42:12 -0700985 The old version is the file before any modifications in the user's
Edward Lemura5799e32020-01-17 19:26:51 +0000986 workspace, i.e. the 'left hand side'.
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700987
988 Contents will be empty if the file is a directory or does not exist.
989 Note: The carriage returns (LF or CR) are stripped off.
990 """
991 return self._diff_cache.GetOldContents(self.LocalPath(),
992 self._local_root).splitlines()
993
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000994 def NewContents(self):
995 """Returns an iterator over the lines in the new version of file.
996
Edward Lemura5799e32020-01-17 19:26:51 +0000997 The new version is the file in the user's workspace, i.e. the 'right hand
998 side'.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000999
1000 Contents will be empty if the file is a directory or does not exist.
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +00001001 Note: The carriage returns (LF or CR) are stripped off.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001002 """
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +00001003 if self._cached_new_contents is None:
1004 self._cached_new_contents = []
agable0b65e732016-11-22 09:25:46 -08001005 try:
1006 self._cached_new_contents = gclient_utils.FileRead(
1007 self.AbsoluteLocalPath(), 'rU').splitlines()
1008 except IOError:
1009 pass # File not found? That's fine; maybe it was deleted.
Greg Thompson30cde452021-06-01 16:38:47 +00001010 except UnicodeDecodeError as e:
Dirk Pranke6fc394f2021-05-26 23:25:14 +00001011 # log the filename since we're probably trying to read a binary
1012 # file, and shouldn't be.
1013 print('Error reading %s: %s' % (self.AbsoluteLocalPath(), e))
1014 raise
1015
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +00001016 return self._cached_new_contents[:]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001017
Bruce Dawsonf0bcfdd2021-05-21 18:10:23 +00001018 def ChangedContents(self, keeplinebreaks=False):
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001019 """Returns a list of tuples (line number, line text) of all new lines.
1020
1021 This relies on the scm diff output describing each changed code section
1022 with a line of the form
1023
1024 ^@@ <old line num>,<old size> <new line num>,<new size> @@$
1025 """
Bruce Dawsonf0bcfdd2021-05-21 18:10:23 +00001026 # Don't return cached results when line breaks are requested.
1027 if not keeplinebreaks and self._cached_changed_contents is not None:
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +00001028 return self._cached_changed_contents[:]
Bruce Dawsonf0bcfdd2021-05-21 18:10:23 +00001029 result = []
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001030 line_num = 0
1031
Bruce Dawsonf0bcfdd2021-05-21 18:10:23 +00001032 # The keeplinebreaks parameter to splitlines must be True or else the
1033 # CheckForWindowsLineEndings presubmit will be a NOP.
1034 for line in self.GenerateScmDiff().splitlines(keeplinebreaks):
Edward Lemurac5c55f2020-02-29 00:17:16 +00001035 m = re.match(r'^@@ [0-9\,\+\-]+ \+([0-9]+)\,[0-9]+ @@', line)
1036 if m:
1037 line_num = int(m.groups(1)[0])
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001038 continue
1039 if line.startswith('+') and not line.startswith('++'):
Bruce Dawsonf0bcfdd2021-05-21 18:10:23 +00001040 result.append((line_num, line[1:]))
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001041 if not line.startswith('-'):
1042 line_num += 1
Bruce Dawsonf0bcfdd2021-05-21 18:10:23 +00001043 # Don't cache results with line breaks.
1044 if keeplinebreaks:
1045 return result;
1046 self._cached_changed_contents = result
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +00001047 return self._cached_changed_contents[:]
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001048
maruel@chromium.org5de13972009-06-10 18:16:06 +00001049 def __str__(self):
1050 return self.LocalPath()
1051
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001052 def GenerateScmDiff(self):
nick@chromium.orgff526192013-06-10 19:30:26 +00001053 return self._diff_cache.GetDiff(self.LocalPath(), self._local_root)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001054
maruel@chromium.org58407af2011-04-12 23:15:57 +00001055
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001056class GitAffectedFile(AffectedFile):
1057 """Representation of a file in a change out of a git checkout."""
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +00001058 # Method 'NNN' is abstract in class 'NNN' but is not overridden
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -08001059 # pylint: disable=abstract-method
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001060
nick@chromium.orgff526192013-06-10 19:30:26 +00001061 DIFF_CACHE = _GitDiffCache
1062
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001063 def __init__(self, *args, **kwargs):
1064 AffectedFile.__init__(self, *args, **kwargs)
1065 self._server_path = None
agable0b65e732016-11-22 09:25:46 -08001066 self._is_testable_file = None
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001067
agable0b65e732016-11-22 09:25:46 -08001068 def IsTestableFile(self):
1069 if self._is_testable_file is None:
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001070 if self.Action() == 'D':
agable0b65e732016-11-22 09:25:46 -08001071 # A deleted file is not testable.
1072 self._is_testable_file = False
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001073 else:
agable0b65e732016-11-22 09:25:46 -08001074 self._is_testable_file = os.path.isfile(self.AbsoluteLocalPath())
1075 return self._is_testable_file
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001076
maruel@chromium.orgc1938752011-04-12 23:11:13 +00001077
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001078class Change(object):
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001079 """Describe a change.
1080
1081 Used directly by the presubmit scripts to query the current change being
1082 tested.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +00001083
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001084 Instance members:
nick@chromium.orgff526192013-06-10 19:30:26 +00001085 tags: Dictionary of KEY=VALUE pairs found in the change description.
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001086 self.KEY: equivalent to tags['KEY']
1087 """
1088
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001089 _AFFECTED_FILES = AffectedFile
1090
Edward Lemura5799e32020-01-17 19:26:51 +00001091 # Matches key/value (or 'tag') lines in changelist descriptions.
maruel@chromium.org428342a2011-11-10 15:46:33 +00001092 TAG_LINE_RE = re.compile(
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001093 '^[ \t]*(?P<key>[A-Z][A-Z_0-9]*)[ \t]*=[ \t]*(?P<value>.*?)[ \t]*$')
maruel@chromium.orgc1938752011-04-12 23:11:13 +00001094 scm = ''
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001095
maruel@chromium.org58407af2011-04-12 23:15:57 +00001096 def __init__(
agable@chromium.orgea84ef12014-04-30 19:55:12 +00001097 self, name, description, local_root, files, issue, patchset, author,
1098 upstream=None):
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001099 if files is None:
1100 files = []
1101 self._name = name
chase@chromium.org8e416c82009-10-06 04:30:44 +00001102 # Convert root into an absolute path.
1103 self._local_root = os.path.abspath(local_root)
agable@chromium.orgea84ef12014-04-30 19:55:12 +00001104 self._upstream = upstream
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001105 self.issue = issue
1106 self.patchset = patchset
maruel@chromium.org58407af2011-04-12 23:15:57 +00001107 self.author_email = author
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001108
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001109 self._full_description = ''
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001110 self.tags = {}
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001111 self._description_without_tags = ''
1112 self.SetDescriptionText(description)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001113
maruel@chromium.orge085d812011-10-10 19:49:15 +00001114 assert all(
1115 (isinstance(f, (list, tuple)) and len(f) == 2) for f in files), files
1116
agable@chromium.orgea84ef12014-04-30 19:55:12 +00001117 diff_cache = self._AFFECTED_FILES.DIFF_CACHE(self._upstream)
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001118 self._affected_files = [
nick@chromium.orgff526192013-06-10 19:30:26 +00001119 self._AFFECTED_FILES(path, action.strip(), self._local_root, diff_cache)
1120 for action, path in files
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +00001121 ]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001122
Edward Lesmes9ce03f82021-01-12 20:13:31 +00001123 def UpstreamBranch(self):
1124 """Returns the upstream branch for the change."""
1125 return self._upstream
1126
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001127 def Name(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001128 """Returns the change name."""
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001129 return self._name
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001130
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001131 def DescriptionText(self):
1132 """Returns the user-entered changelist description, minus tags.
1133
Edward Lemura5799e32020-01-17 19:26:51 +00001134 Any line in the user-provided description starting with e.g. 'FOO='
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001135 (whitespace permitted before and around) is considered a tag line. Such
1136 lines are stripped out of the description this function returns.
1137 """
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001138 return self._description_without_tags
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001139
1140 def FullDescriptionText(self):
1141 """Returns the complete changelist description including tags."""
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001142 return self._full_description
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001143
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001144 def SetDescriptionText(self, description):
1145 """Sets the full description text (including tags) to |description|.
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001146
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001147 Also updates the list of tags."""
1148 self._full_description = description
1149
1150 # From the description text, build up a dictionary of key/value pairs
Edward Lemura5799e32020-01-17 19:26:51 +00001151 # plus the description minus all key/value or 'tag' lines.
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001152 description_without_tags = []
1153 self.tags = {}
1154 for line in self._full_description.splitlines():
1155 m = self.TAG_LINE_RE.match(line)
1156 if m:
1157 self.tags[m.group('key')] = m.group('value')
1158 else:
1159 description_without_tags.append(line)
1160
1161 # Change back to text and remove whitespace at end.
1162 self._description_without_tags = (
1163 '\n'.join(description_without_tags).rstrip())
1164
Edward Lemur69bb8be2020-02-03 20:37:38 +00001165 def AddDescriptionFooter(self, key, value):
1166 """Adds the given footer to the change description.
1167
1168 Args:
1169 key: A string with the key for the git footer. It must conform to
1170 the git footers format (i.e. 'List-Of-Tokens') and will be case
1171 normalized so that each token is title-cased.
1172 value: A string with the value for the git footer.
1173 """
1174 description = git_footers.add_footer(
1175 self.FullDescriptionText(), git_footers.normalize_name(key), value)
1176 self.SetDescriptionText(description)
1177
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001178 def RepositoryRoot(self):
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001179 """Returns the repository (checkout) root directory for this change,
1180 as an absolute path.
1181 """
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001182 return self._local_root
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001183
1184 def __getattr__(self, attr):
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001185 """Return tags directly as attributes on the object."""
Edward Lemura5799e32020-01-17 19:26:51 +00001186 if not re.match(r'^[A-Z_]*$', attr):
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001187 raise AttributeError(self, attr)
maruel@chromium.orge1a524f2009-05-27 14:43:46 +00001188 return self.tags.get(attr)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001189
Edward Lemur69bb8be2020-02-03 20:37:38 +00001190 def GitFootersFromDescription(self):
1191 """Return the git footers present in the description.
1192
1193 Returns:
1194 footers: A dict of {footer: [values]} containing a multimap of the footers
1195 in the change description.
1196 """
1197 return git_footers.parse_footers(self.FullDescriptionText())
1198
Aaron Gablefc03e672017-05-15 14:09:42 -07001199 def BugsFromDescription(self):
1200 """Returns all bugs referenced in the commit description."""
Aaron Gable12ef5012017-05-15 14:29:00 -07001201 tags = [b.strip() for b in self.tags.get('BUG', '').split(',') if b.strip()]
Caleb Rouleauc0546b92019-02-22 06:12:57 +00001202 footers = []
Edward Lemur69bb8be2020-02-03 20:37:38 +00001203 parsed = self.GitFootersFromDescription()
Dan Beam62954042019-10-03 21:20:33 +00001204 unsplit_footers = parsed.get('Bug', []) + parsed.get('Fixed', [])
Caleb Rouleauc0546b92019-02-22 06:12:57 +00001205 for unsplit_footer in unsplit_footers:
1206 footers += [b.strip() for b in unsplit_footer.split(',')]
Aaron Gable12ef5012017-05-15 14:29:00 -07001207 return sorted(set(tags + footers))
Aaron Gablefc03e672017-05-15 14:09:42 -07001208
1209 def ReviewersFromDescription(self):
1210 """Returns all reviewers listed in the commit description."""
Edward Lemura5799e32020-01-17 19:26:51 +00001211 # We don't support a 'R:' git-footer for reviewers; that is in metadata.
Aaron Gable12ef5012017-05-15 14:29:00 -07001212 tags = [r.strip() for r in self.tags.get('R', '').split(',') if r.strip()]
1213 return sorted(set(tags))
Aaron Gablefc03e672017-05-15 14:09:42 -07001214
1215 def TBRsFromDescription(self):
1216 """Returns all TBR reviewers listed in the commit description."""
Aaron Gable12ef5012017-05-15 14:29:00 -07001217 tags = [r.strip() for r in self.tags.get('TBR', '').split(',') if r.strip()]
Aaron Gable6e7ddb62020-05-27 22:23:29 +00001218 # TODO(crbug.com/839208): Remove support for 'Tbr:' when TBRs are
1219 # programmatically determined by self-CR+1s.
Edward Lemur69bb8be2020-02-03 20:37:38 +00001220 footers = self.GitFootersFromDescription().get('Tbr', [])
Aaron Gable12ef5012017-05-15 14:29:00 -07001221 return sorted(set(tags + footers))
Aaron Gablefc03e672017-05-15 14:09:42 -07001222
Aaron Gable6e7ddb62020-05-27 22:23:29 +00001223 # TODO(crbug.com/753425): Delete these once we're sure they're unused.
Aaron Gablefc03e672017-05-15 14:09:42 -07001224 @property
1225 def BUG(self):
1226 return ','.join(self.BugsFromDescription())
1227 @property
1228 def R(self):
1229 return ','.join(self.ReviewersFromDescription())
1230 @property
1231 def TBR(self):
1232 return ','.join(self.TBRsFromDescription())
1233
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001234 def AllFiles(self, root=None):
1235 """List all files under source control in the repo."""
1236 raise NotImplementedError()
1237
agable0b65e732016-11-22 09:25:46 -08001238 def AffectedFiles(self, include_deletes=True, file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001239 """Returns a list of AffectedFile instances for all files in the change.
1240
1241 Args:
1242 include_deletes: If false, deleted files will be filtered out.
sail@chromium.org5538e022011-05-12 17:53:16 +00001243 file_filter: An additional filter to apply.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001244
1245 Returns:
1246 [AffectedFile(path, action), AffectedFile(path, action)]
1247 """
Edward Lemurb9830242019-10-30 22:19:20 +00001248 affected = list(filter(file_filter, self._affected_files))
sail@chromium.org5538e022011-05-12 17:53:16 +00001249
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001250 if include_deletes:
1251 return affected
Edward Lemurb9830242019-10-30 22:19:20 +00001252 return list(filter(lambda x: x.Action() != 'D', affected))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001253
John Budorick16162372018-04-18 10:39:53 -07001254 def AffectedTestableFiles(self, include_deletes=None, **kwargs):
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +00001255 """Return a list of the existing text files in a change."""
1256 if include_deletes is not None:
Edward Lemura5799e32020-01-17 19:26:51 +00001257 warn('AffectedTeestableFiles(include_deletes=%s)'
1258 ' is deprecated and ignored' % str(include_deletes),
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +00001259 category=DeprecationWarning,
1260 stacklevel=2)
Edward Lemurb9830242019-10-30 22:19:20 +00001261 return list(filter(
1262 lambda x: x.IsTestableFile(),
1263 self.AffectedFiles(include_deletes=False, **kwargs)))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001264
agable0b65e732016-11-22 09:25:46 -08001265 def AffectedTextFiles(self, include_deletes=None):
1266 """An alias to AffectedTestableFiles for backwards compatibility."""
1267 return self.AffectedTestableFiles(include_deletes=include_deletes)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001268
agable0b65e732016-11-22 09:25:46 -08001269 def LocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001270 """Convenience function."""
agable0b65e732016-11-22 09:25:46 -08001271 return [af.LocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001272
agable0b65e732016-11-22 09:25:46 -08001273 def AbsoluteLocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001274 """Convenience function."""
agable0b65e732016-11-22 09:25:46 -08001275 return [af.AbsoluteLocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001276
1277 def RightHandSideLines(self):
Edward Lemura5799e32020-01-17 19:26:51 +00001278 """An iterator over all text lines in 'new' version of changed files.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001279
1280 Lists lines from new or modified text files in the change.
1281
1282 This is useful for doing line-by-line regex checks, like checking for
1283 trailing whitespace.
1284
1285 Yields:
1286 a 3 tuple:
1287 the AffectedFile instance of the current file;
1288 integer line number (1-based); and
1289 the contents of the line as a string.
1290 """
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +00001291 return _RightHandSideLinesImpl(
1292 x for x in self.AffectedFiles(include_deletes=False)
agable0b65e732016-11-22 09:25:46 -08001293 if x.IsTestableFile())
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001294
Jochen Eisingerd0573ec2017-04-13 10:55:06 +02001295 def OriginalOwnersFiles(self):
1296 """A map from path names of affected OWNERS files to their old content."""
1297 def owners_file_filter(f):
1298 return 'OWNERS' in os.path.split(f.LocalPath())[1]
1299 files = self.AffectedFiles(file_filter=owners_file_filter)
1300 return dict([(f.LocalPath(), f.OldContents()) for f in files])
1301
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001302
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001303class GitChange(Change):
1304 _AFFECTED_FILES = GitAffectedFile
maruel@chromium.orgc1938752011-04-12 23:11:13 +00001305 scm = 'git'
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +00001306
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001307 def AllFiles(self, root=None):
1308 """List all files under source control in the repo."""
1309 root = root or self.RepositoryRoot()
1310 return subprocess.check_output(
Aaron Gable7817f022017-12-12 09:43:17 -08001311 ['git', '-c', 'core.quotePath=false', 'ls-files', '--', '.'],
Josip Sokcevic0b123462021-06-08 20:41:32 +00001312 cwd=root).decode('utf-8', 'ignore').splitlines()
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001313
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001314
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001315def ListRelevantPresubmitFiles(files, root):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001316 """Finds all presubmit files that apply to a given set of source files.
1317
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001318 If inherit-review-settings-ok is present right under root, looks for
1319 PRESUBMIT.py in directories enclosing root.
1320
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001321 Args:
1322 files: An iterable container containing file paths.
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001323 root: Path where to stop searching.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001324
1325 Return:
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001326 List of absolute paths of the existing PRESUBMIT.py scripts.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001327 """
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001328 files = [normpath(os.path.join(root, f)) for f in files]
1329
1330 # List all the individual directories containing files.
1331 directories = set([os.path.dirname(f) for f in files])
1332
1333 # Ignore root if inherit-review-settings-ok is present.
1334 if os.path.isfile(os.path.join(root, 'inherit-review-settings-ok')):
1335 root = None
1336
1337 # Collect all unique directories that may contain PRESUBMIT.py.
1338 candidates = set()
1339 for directory in directories:
1340 while True:
1341 if directory in candidates:
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001342 break
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001343 candidates.add(directory)
1344 if directory == root:
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001345 break
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001346 parent_dir = os.path.dirname(directory)
1347 if parent_dir == directory:
1348 # We hit the system root directory.
1349 break
1350 directory = parent_dir
1351
1352 # Look for PRESUBMIT.py in all candidate directories.
1353 results = []
1354 for directory in sorted(list(candidates)):
tobiasjsff061c02016-08-17 03:23:57 -07001355 try:
1356 for f in os.listdir(directory):
1357 p = os.path.join(directory, f)
1358 if os.path.isfile(p) and re.match(
1359 r'PRESUBMIT.*\.py$', f) and not f.startswith('PRESUBMIT_test'):
1360 results.append(p)
1361 except OSError:
1362 pass
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001363
tobiasjs2836bcf2016-08-16 04:08:16 -07001364 logging.debug('Presubmit files: %s', ','.join(results))
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001365 return results
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001366
1367
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001368class GetTryMastersExecuter(object):
1369 @staticmethod
1370 def ExecPresubmitScript(script_text, presubmit_path, project, change):
1371 """Executes GetPreferredTryMasters() from a single presubmit script.
1372
1373 Args:
1374 script_text: The text of the presubmit script.
1375 presubmit_path: Project script to run.
1376 project: Project name to pass to presubmit script for bot selection.
1377
1378 Return:
1379 A map of try masters to map of builders to set of tests.
1380 """
1381 context = {}
1382 try:
Raul Tambre09e64b42019-05-14 01:57:22 +00001383 exec(compile(script_text, 'PRESUBMIT.py', 'exec', dont_inherit=True),
1384 context)
Raul Tambre7c938462019-05-24 16:35:35 +00001385 except Exception as e:
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001386 raise PresubmitFailure('"%s" had an exception.\n%s'
1387 % (presubmit_path, e))
1388
1389 function_name = 'GetPreferredTryMasters'
1390 if function_name not in context:
1391 return {}
1392 get_preferred_try_masters = context[function_name]
1393 if not len(inspect.getargspec(get_preferred_try_masters)[0]) == 2:
1394 raise PresubmitFailure(
1395 'Expected function "GetPreferredTryMasters" to take two arguments.')
1396 return get_preferred_try_masters(project, change)
1397
1398
rmistry@google.com5626a922015-02-26 14:03:30 +00001399class GetPostUploadExecuter(object):
1400 @staticmethod
Edward Lemur016a0872020-02-04 22:13:28 +00001401 def ExecPresubmitScript(script_text, presubmit_path, gerrit_obj, change):
rmistry@google.com5626a922015-02-26 14:03:30 +00001402 """Executes PostUploadHook() from a single presubmit script.
1403
1404 Args:
1405 script_text: The text of the presubmit script.
1406 presubmit_path: Project script to run.
Edward Lemur016a0872020-02-04 22:13:28 +00001407 gerrit_obj: The GerritAccessor object.
rmistry@google.com5626a922015-02-26 14:03:30 +00001408 change: The Change object.
1409
1410 Return:
1411 A list of results objects.
1412 """
1413 context = {}
1414 try:
Raul Tambre09e64b42019-05-14 01:57:22 +00001415 exec(compile(script_text, 'PRESUBMIT.py', 'exec', dont_inherit=True),
1416 context)
Raul Tambre7c938462019-05-24 16:35:35 +00001417 except Exception as e:
rmistry@google.com5626a922015-02-26 14:03:30 +00001418 raise PresubmitFailure('"%s" had an exception.\n%s'
1419 % (presubmit_path, e))
1420
1421 function_name = 'PostUploadHook'
1422 if function_name not in context:
1423 return {}
1424 post_upload_hook = context[function_name]
1425 if not len(inspect.getargspec(post_upload_hook)[0]) == 3:
1426 raise PresubmitFailure(
1427 'Expected function "PostUploadHook" to take three arguments.')
Edward Lemur016a0872020-02-04 22:13:28 +00001428 return post_upload_hook(gerrit_obj, change, OutputApi(False))
rmistry@google.com5626a922015-02-26 14:03:30 +00001429
1430
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001431def _MergeMasters(masters1, masters2):
1432 """Merges two master maps. Merges also the tests of each builder."""
1433 result = {}
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001434 for (master, builders) in itertools.chain(masters1.items(),
1435 masters2.items()):
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001436 new_builders = result.setdefault(master, {})
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001437 for (builder, tests) in builders.items():
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001438 new_builders.setdefault(builder, set([])).update(tests)
1439 return result
1440
1441
1442def DoGetTryMasters(change,
1443 changed_files,
1444 repository_root,
1445 default_presubmit,
1446 project,
1447 verbose,
1448 output_stream):
1449 """Get the list of try masters from the presubmit scripts.
1450
1451 Args:
1452 changed_files: List of modified files.
1453 repository_root: The repository root.
1454 default_presubmit: A default presubmit script to execute in any case.
1455 project: Optional name of a project used in selecting trybots.
1456 verbose: Prints debug info.
1457 output_stream: A stream to write debug output to.
1458
1459 Return:
1460 Map of try masters to map of builders to set of tests.
1461 """
1462 presubmit_files = ListRelevantPresubmitFiles(changed_files, repository_root)
1463 if not presubmit_files and verbose:
Edward Lemura5799e32020-01-17 19:26:51 +00001464 output_stream.write('Warning, no PRESUBMIT.py found.\n')
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001465 results = {}
1466 executer = GetTryMastersExecuter()
1467
1468 if default_presubmit:
1469 if verbose:
Edward Lemura5799e32020-01-17 19:26:51 +00001470 output_stream.write('Running default presubmit script.\n')
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001471 fake_path = os.path.join(repository_root, 'PRESUBMIT.py')
1472 results = _MergeMasters(results, executer.ExecPresubmitScript(
1473 default_presubmit, fake_path, project, change))
1474 for filename in presubmit_files:
1475 filename = os.path.abspath(filename)
1476 if verbose:
Edward Lemura5799e32020-01-17 19:26:51 +00001477 output_stream.write('Running %s\n' % filename)
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001478 # Accept CRLF presubmit script.
1479 presubmit_script = gclient_utils.FileRead(filename, 'rU')
1480 results = _MergeMasters(results, executer.ExecPresubmitScript(
1481 presubmit_script, filename, project, change))
1482
1483 # Make sets to lists again for later JSON serialization.
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001484 for builders in results.values():
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001485 for builder in builders:
1486 builders[builder] = list(builders[builder])
1487
1488 if results and verbose:
1489 output_stream.write('%s\n' % str(results))
1490 return results
1491
1492
rmistry@google.com5626a922015-02-26 14:03:30 +00001493def DoPostUploadExecuter(change,
Edward Lemur016a0872020-02-04 22:13:28 +00001494 gerrit_obj,
Edward Lemur6eb1d322020-02-27 22:20:15 +00001495 verbose):
rmistry@google.com5626a922015-02-26 14:03:30 +00001496 """Execute the post upload hook.
1497
1498 Args:
1499 change: The Change object.
Edward Lemur016a0872020-02-04 22:13:28 +00001500 gerrit_obj: The GerritAccessor object.
rmistry@google.com5626a922015-02-26 14:03:30 +00001501 verbose: Prints debug info.
rmistry@google.com5626a922015-02-26 14:03:30 +00001502 """
1503 presubmit_files = ListRelevantPresubmitFiles(
Edward Lemur6eb1d322020-02-27 22:20:15 +00001504 change.LocalPaths(), change.RepositoryRoot())
rmistry@google.com5626a922015-02-26 14:03:30 +00001505 if not presubmit_files and verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001506 sys.stdout.write('Warning, no PRESUBMIT.py found.\n')
rmistry@google.com5626a922015-02-26 14:03:30 +00001507 results = []
1508 executer = GetPostUploadExecuter()
1509 # The root presubmit file should be executed after the ones in subdirectories.
1510 # i.e. the specific post upload hooks should run before the general ones.
1511 # Thus, reverse the order provided by ListRelevantPresubmitFiles.
1512 presubmit_files.reverse()
1513
1514 for filename in presubmit_files:
1515 filename = os.path.abspath(filename)
1516 if verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001517 sys.stdout.write('Running %s\n' % filename)
rmistry@google.com5626a922015-02-26 14:03:30 +00001518 # Accept CRLF presubmit script.
1519 presubmit_script = gclient_utils.FileRead(filename, 'rU')
1520 results.extend(executer.ExecPresubmitScript(
Edward Lemur016a0872020-02-04 22:13:28 +00001521 presubmit_script, filename, gerrit_obj, change))
rmistry@google.com5626a922015-02-26 14:03:30 +00001522
Edward Lemur6eb1d322020-02-27 22:20:15 +00001523 if not results:
1524 return 0
1525
1526 sys.stdout.write('\n')
1527 sys.stdout.write('** Post Upload Hook Messages **\n')
1528
1529 exit_code = 0
1530 for result in results:
1531 if result.fatal:
1532 exit_code = 1
1533 result.handle()
1534 sys.stdout.write('\n')
1535
1536 return exit_code
rmistry@google.com5626a922015-02-26 14:03:30 +00001537
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001538class PresubmitExecuter(object):
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001539 def __init__(self, change, committing, verbose, gerrit_obj, dry_run=None,
Edward Lesmeseb1bd622021-03-01 19:54:07 +00001540 thread_pool=None, parallel=False):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001541 """
1542 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001543 change: The Change object.
agable92bec4f2016-08-24 09:27:27 -07001544 committing: True if 'git cl land' is running, False if 'git cl upload' is.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001545 gerrit_obj: provides basic Gerrit codereview functionality.
1546 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -04001547 parallel: if true, all tests reported via input_api.RunTests for all
1548 PRESUBMIT files will be run in parallel.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001549 """
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001550 self.change = change
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001551 self.committing = committing
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001552 self.gerrit = gerrit_obj
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001553 self.verbose = verbose
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001554 self.dry_run = dry_run
Daniel Cheng7227d212017-11-17 08:12:37 -08001555 self.more_cc = []
Edward Lesmes8e282792018-04-03 18:50:29 -04001556 self.thread_pool = thread_pool
1557 self.parallel = parallel
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001558
1559 def ExecPresubmitScript(self, script_text, presubmit_path):
1560 """Executes a single presubmit script.
1561
1562 Args:
1563 script_text: The text of the presubmit script.
1564 presubmit_path: The path to the presubmit file (this will be reported via
1565 input_api.PresubmitLocalPath()).
1566
1567 Return:
1568 A list of result objects, empty if no problems.
1569 """
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001570
chase@chromium.org8e416c82009-10-06 04:30:44 +00001571 # Change to the presubmit file's directory to support local imports.
1572 main_path = os.getcwd()
Saagar Sanghavi98b332f2020-07-31 17:19:15 +00001573 presubmit_dir = os.path.dirname(presubmit_path)
1574 os.chdir(presubmit_dir)
chase@chromium.org8e416c82009-10-06 04:30:44 +00001575
1576 # Load the presubmit script into context.
dpranke@chromium.org970c5222011-03-12 00:32:24 +00001577 input_api = InputApi(self.change, presubmit_path, self.committing,
Aaron Gable668c1d82018-04-03 10:19:16 -07001578 self.verbose, gerrit_obj=self.gerrit,
Edward Lesmes8e282792018-04-03 18:50:29 -04001579 dry_run=self.dry_run, thread_pool=self.thread_pool,
1580 parallel=self.parallel)
Daniel Cheng7227d212017-11-17 08:12:37 -08001581 output_api = OutputApi(self.committing)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001582 context = {}
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001583
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001584 # Try to figure out whether these presubmit checks should be run under
1585 # python2 or python3. We need to do this without actually trying to
1586 # compile the text, since the text might compile in one but not the
1587 # other.
1588 m = re.search('^USE_PYTHON3 = True$', script_text, flags=re.MULTILINE)
1589 use_python3 = m is not None
1590 if (((sys.version_info.major == 2) and use_python3) or
1591 ((sys.version_info.major == 3) and not use_python3)):
1592 return []
1593
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001594 try:
Raul Tambre09e64b42019-05-14 01:57:22 +00001595 exec(compile(script_text, 'PRESUBMIT.py', 'exec', dont_inherit=True),
1596 context)
Raul Tambre7c938462019-05-24 16:35:35 +00001597 except Exception as e:
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001598 raise PresubmitFailure('"%s" had an exception.\n%s' % (presubmit_path, e))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001599
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001600 context['__args'] = (input_api, output_api)
Ben Pastene8351dc12020-08-06 05:01:35 +00001601
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001602 # Get path of presubmit directory relative to repository root.
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001603 # Always use forward slashes, so that path is same in *nix and Windows
1604 root = input_api.change.RepositoryRoot()
1605 rel_path = os.path.relpath(presubmit_dir, root)
1606 rel_path = rel_path.replace(os.path.sep, '/')
Ben Pastene8351dc12020-08-06 05:01:35 +00001607
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001608 # Get the URL of git remote origin and use it to identify host and project
Edward Lesmeseb1bd622021-03-01 19:54:07 +00001609 host = project = ''
1610 if self.gerrit:
1611 host = self.gerrit.host or ''
1612 project = self.gerrit.project or ''
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001613
1614 # Prefix for test names
1615 prefix = 'presubmit:%s/%s:%s/' % (host, project, rel_path)
1616
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001617 # Perform all the desired presubmit checks.
1618 results = []
Ben Pastene8351dc12020-08-06 05:01:35 +00001619
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001620 try:
Scott Leecc2fe9b2020-11-19 19:38:06 +00001621 version = [
1622 int(x) for x in context.get('PRESUBMIT_VERSION', '0.0.0').split('.')
1623 ]
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001624
Scott Leecc2fe9b2020-11-19 19:38:06 +00001625 with rdb_wrapper.client(prefix) as sink:
1626 if version >= [2, 0, 0]:
1627 for function_name in context:
1628 if not function_name.startswith('Check'):
1629 continue
1630 if function_name.endswith('Commit') and not self.committing:
1631 continue
1632 if function_name.endswith('Upload') and self.committing:
1633 continue
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001634 logging.debug('Running %s in %s', function_name, presubmit_path)
1635 results.extend(
Scott Leecc2fe9b2020-11-19 19:38:06 +00001636 self._run_check_function(function_name, context, sink))
1637 logging.debug('Running %s done.', function_name)
1638 self.more_cc.extend(output_api.more_cc)
1639
1640 else: # Old format
1641 if self.committing:
1642 function_name = 'CheckChangeOnCommit'
1643 else:
1644 function_name = 'CheckChangeOnUpload'
1645 if function_name in context:
1646 logging.debug('Running %s in %s', function_name, presubmit_path)
1647 results.extend(
1648 self._run_check_function(function_name, context, sink))
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001649 logging.debug('Running %s done.', function_name)
1650 self.more_cc.extend(output_api.more_cc)
1651
1652 finally:
1653 for f in input_api._named_temporary_files:
1654 os.remove(f)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001655
chase@chromium.org8e416c82009-10-06 04:30:44 +00001656 # Return the process to the original working directory.
1657 os.chdir(main_path)
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001658 return results
1659
Scott Leecc2fe9b2020-11-19 19:38:06 +00001660 def _run_check_function(self, function_name, context, sink=None):
1661 """Evaluates and returns the result of a given presubmit function.
1662
1663 If sink is given, the result of the presubmit function will be reported
1664 to the ResultSink.
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001665
1666 Args:
Scott Leecc2fe9b2020-11-19 19:38:06 +00001667 function_name: the name of the presubmit function to evaluate
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001668 context: a context dictionary in which the function will be evaluated
Scott Leecc2fe9b2020-11-19 19:38:06 +00001669 sink: an instance of ResultSink. None, by default.
1670 Returns:
1671 the result of the presubmit function call.
1672 """
1673 start_time = time_time()
1674 try:
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001675 result = eval(function_name + '(*__args)', context)
1676 self._check_result_type(result)
Allen Webbfe7d7092021-05-18 02:05:49 +00001677 except Exception:
Scott Leecc2fe9b2020-11-19 19:38:06 +00001678 if sink:
1679 elapsed_time = time_time() - start_time
1680 sink.report(function_name, rdb_wrapper.STATUS_FAIL, elapsed_time)
Allen Webbfe7d7092021-05-18 02:05:49 +00001681 # TODO(crbug.com/953884): replace reraise with native py3:
Allen Webbb65bbfe2021-05-11 21:22:01 +00001682 # raise .. from e
Allen Webbfe7d7092021-05-18 02:05:49 +00001683 e_type, e_value, e_tb = sys.exc_info()
Dirk Pranke6fc394f2021-05-26 23:25:14 +00001684 print('Evaluation of %s failed: %s' % (function_name, e_value))
1685 six.reraise(e_type, e_value, e_tb)
Scott Leecc2fe9b2020-11-19 19:38:06 +00001686
Bruce Dawson2bdc49f2021-05-21 19:13:03 +00001687 elapsed_time = time_time() - start_time
1688 if elapsed_time > 10.0:
1689 sys.stdout.write(
1690 '%s took %.1fs to run.\n' % (function_name, elapsed_time))
Scott Leecc2fe9b2020-11-19 19:38:06 +00001691 if sink:
Scott Leecc2fe9b2020-11-19 19:38:06 +00001692 status = rdb_wrapper.STATUS_PASS
1693 if any(r.fatal for r in result):
1694 status = rdb_wrapper.STATUS_FAIL
1695 sink.report(function_name, status, elapsed_time)
1696
1697 return result
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001698
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00001699 def _check_result_type(self, result):
1700 """Helper function which ensures result is a list, and all elements are
1701 instances of OutputApi.PresubmitResult"""
1702 if not isinstance(result, (tuple, list)):
1703 raise PresubmitFailure('Presubmit functions must return a tuple or list')
1704 if not all(isinstance(res, OutputApi.PresubmitResult) for res in result):
1705 raise PresubmitFailure(
1706 'All presubmit results must be of types derived from '
1707 'output_api.PresubmitResult')
1708
1709
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001710def DoPresubmitChecks(change,
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001711 committing,
1712 verbose,
maruel@chromium.orgb0dfd352009-06-10 14:12:54 +00001713 default_presubmit,
dpranke@chromium.org970c5222011-03-12 00:32:24 +00001714 may_prompt,
Aaron Gable668c1d82018-04-03 10:19:16 -07001715 gerrit_obj,
Edward Lesmes8e282792018-04-03 18:50:29 -04001716 dry_run=None,
Debrian Figueroadd2737e2019-06-21 23:50:13 +00001717 parallel=False,
Edward Lesmeseb1bd622021-03-01 19:54:07 +00001718 json_output=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001719 """Runs all presubmit checks that apply to the files in the change.
1720
1721 This finds all PRESUBMIT.py files in directories enclosing the files in the
1722 change (up to the repository root) and calls the relevant entrypoint function
1723 depending on whether the change is being committed or uploaded.
1724
1725 Prints errors, warnings and notifications. Prompts the user for warnings
1726 when needed.
1727
1728 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001729 change: The Change object.
agable92bec4f2016-08-24 09:27:27 -07001730 committing: True if 'git cl land' is running, False if 'git cl upload' is.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001731 verbose: Prints debug info.
maruel@chromium.org0ff1fab2009-05-22 13:08:15 +00001732 default_presubmit: A default presubmit script to execute in any case.
Quinten Yearsley516fe7f2016-12-14 11:50:18 -08001733 may_prompt: Enable (y/n) questions on warning or error. If False,
1734 any questions are answered with yes by default.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001735 gerrit_obj: provides basic Gerrit codereview functionality.
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001736 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -04001737 parallel: if true, all tests specified by input_api.RunTests in all
1738 PRESUBMIT files will be run in parallel.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001739
1740 Return:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001741 1 if presubmit checks failed or 0 otherwise.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001742 """
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001743 old_environ = os.environ
1744 try:
1745 # Make sure python subprocesses won't generate .pyc files.
1746 os.environ = os.environ.copy()
Edward Lemurb9830242019-10-30 22:19:20 +00001747 os.environ['PYTHONDONTWRITEBYTECODE'] = '1'
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001748
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001749 python_version = 'Python %s' % sys.version_info.major
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001750 if committing:
Dirk Pranke6fc394f2021-05-26 23:25:14 +00001751 sys.stdout.write('Running %s presubmit commit checks ...\n' %
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001752 python_version)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001753 else:
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001754 sys.stdout.write('Running %s presubmit upload checks ...\n' %
1755 python_version)
Edward Lemurecc27072020-01-06 16:42:34 +00001756 start_time = time_time()
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001757 presubmit_files = ListRelevantPresubmitFiles(
agable0b65e732016-11-22 09:25:46 -08001758 change.AbsoluteLocalPaths(), change.RepositoryRoot())
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001759 if not presubmit_files and verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001760 sys.stdout.write('Warning, no PRESUBMIT.py found.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001761 results = []
Edward Lesmes8e282792018-04-03 18:50:29 -04001762 thread_pool = ThreadPool()
Edward Lemur7e3c67f2018-07-20 20:52:49 +00001763 executer = PresubmitExecuter(change, committing, verbose, gerrit_obj,
Edward Lesmeseb1bd622021-03-01 19:54:07 +00001764 dry_run, thread_pool, parallel)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001765 if default_presubmit:
1766 if verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001767 sys.stdout.write('Running default presubmit script.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001768 fake_path = os.path.join(change.RepositoryRoot(), 'PRESUBMIT.py')
1769 results += executer.ExecPresubmitScript(default_presubmit, fake_path)
1770 for filename in presubmit_files:
1771 filename = os.path.abspath(filename)
1772 if verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001773 sys.stdout.write('Running %s\n' % filename)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001774 # Accept CRLF presubmit script.
1775 presubmit_script = gclient_utils.FileRead(filename, 'rU')
1776 results += executer.ExecPresubmitScript(presubmit_script, filename)
Edward Lesmes8e282792018-04-03 18:50:29 -04001777 results += thread_pool.RunAsync()
1778
Edward Lemur6eb1d322020-02-27 22:20:15 +00001779 messages = {}
1780 should_prompt = False
1781 presubmits_failed = False
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001782 for result in results:
1783 if result.fatal:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001784 presubmits_failed = True
1785 messages.setdefault('ERRORS', []).append(result)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001786 elif result.should_prompt:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001787 should_prompt = True
1788 messages.setdefault('Warnings', []).append(result)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001789 else:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001790 messages.setdefault('Messages', []).append(result)
pam@chromium.orged9a0832009-09-09 22:48:55 +00001791
Edward Lemur6eb1d322020-02-27 22:20:15 +00001792 sys.stdout.write('\n')
1793 for name, items in messages.items():
1794 sys.stdout.write('** Presubmit %s **\n' % name)
1795 for item in items:
1796 item.handle()
1797 sys.stdout.write('\n')
pam@chromium.orged9a0832009-09-09 22:48:55 +00001798
Edward Lemurecc27072020-01-06 16:42:34 +00001799 total_time = time_time() - start_time
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001800 if total_time > 1.0:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001801 sys.stdout.write(
1802 'Presubmit checks took %.1fs to calculate.\n\n' % total_time)
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +00001803
Edward Lemur6eb1d322020-02-27 22:20:15 +00001804 if not should_prompt and not presubmits_failed:
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001805 sys.stdout.write('%s presubmit checks passed.\n' % python_version)
Edward Lemur6eb1d322020-02-27 22:20:15 +00001806 elif should_prompt:
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001807 sys.stdout.write('There were %s presubmit warnings. ' % python_version)
Quinten Yearsley516fe7f2016-12-14 11:50:18 -08001808 if may_prompt:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001809 presubmits_failed = not prompt_should_continue(
1810 'Are you sure you wish to continue? (y/N): ')
Garrett Beatyacb807e2020-08-28 18:17:24 +00001811 else:
1812 sys.stdout.write('\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001813
Edward Lemur1dc66e12020-02-21 21:36:34 +00001814 if json_output:
1815 # Write the presubmit results to json output
1816 presubmit_results = {
1817 'errors': [
Edward Lemur6eb1d322020-02-27 22:20:15 +00001818 error.json_format()
1819 for error in messages.get('ERRORS', [])
Edward Lemur1dc66e12020-02-21 21:36:34 +00001820 ],
1821 'notifications': [
Edward Lemur6eb1d322020-02-27 22:20:15 +00001822 notification.json_format()
1823 for notification in messages.get('Messages', [])
Edward Lemur1dc66e12020-02-21 21:36:34 +00001824 ],
1825 'warnings': [
Edward Lemur6eb1d322020-02-27 22:20:15 +00001826 warning.json_format()
1827 for warning in messages.get('Warnings', [])
Edward Lemur1dc66e12020-02-21 21:36:34 +00001828 ],
Edward Lemur6eb1d322020-02-27 22:20:15 +00001829 'more_cc': executer.more_cc,
Edward Lemur1dc66e12020-02-21 21:36:34 +00001830 }
1831
1832 gclient_utils.FileWrite(
1833 json_output, json.dumps(presubmit_results, sort_keys=True))
1834
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001835 global _ASKED_FOR_FEEDBACK
1836 # Ask for feedback one time out of 5.
1837 if (len(results) and random.randint(0, 4) == 0 and not _ASKED_FOR_FEEDBACK):
Edward Lemur6eb1d322020-02-27 22:20:15 +00001838 sys.stdout.write(
maruel@chromium.org1ce8e662014-01-14 15:23:00 +00001839 'Was the presubmit check useful? If not, run "git cl presubmit -v"\n'
1840 'to figure out which PRESUBMIT.py was run, then run git blame\n'
1841 'on the file to figure out who to ask for help.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001842 _ASKED_FOR_FEEDBACK = True
Edward Lemur6eb1d322020-02-27 22:20:15 +00001843
1844 return 1 if presubmits_failed else 0
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001845 finally:
1846 os.environ = old_environ
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001847
1848
Edward Lemur50984a62020-02-06 18:10:18 +00001849def _scan_sub_dirs(mask, recursive):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001850 if not recursive:
pgervais@chromium.orge57b09d2014-05-07 00:58:13 +00001851 return [x for x in glob.glob(mask) if x not in ('.svn', '.git')]
Lei Zhang9611c4c2017-04-04 01:41:56 -07001852
1853 results = []
1854 for root, dirs, files in os.walk('.'):
1855 if '.svn' in dirs:
1856 dirs.remove('.svn')
1857 if '.git' in dirs:
1858 dirs.remove('.git')
1859 for name in files:
1860 if fnmatch.fnmatch(name, mask):
1861 results.append(os.path.join(root, name))
1862 return results
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001863
1864
Edward Lemur50984a62020-02-06 18:10:18 +00001865def _parse_files(args, recursive):
tobiasjs2836bcf2016-08-16 04:08:16 -07001866 logging.debug('Searching for %s', args)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001867 files = []
1868 for arg in args:
Edward Lemur50984a62020-02-06 18:10:18 +00001869 files.extend([('M', f) for f in _scan_sub_dirs(arg, recursive)])
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001870 return files
1871
1872
Edward Lemur50984a62020-02-06 18:10:18 +00001873def _parse_change(parser, options):
1874 """Process change options.
1875
1876 Args:
1877 parser: The parser used to parse the arguments from command line.
1878 options: The arguments parsed from command line.
1879 Returns:
1880 A GitChange if the change root is a git repository, or a Change otherwise.
1881 """
1882 if options.files and options.all_files:
1883 parser.error('<files> cannot be specified when --all-files is set.')
1884
Edward Lesmes44ea3ff2020-02-05 00:14:30 +00001885 change_scm = scm.determine_scm(options.root)
Edward Lemur50984a62020-02-06 18:10:18 +00001886 if change_scm != 'git' and not options.files:
1887 parser.error('<files> is not optional for unversioned directories.')
1888
1889 if options.files:
1890 change_files = _parse_files(options.files, options.recursive)
1891 elif options.all_files:
1892 change_files = [('M', f) for f in scm.GIT.GetAllFiles(options.root)]
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001893 else:
Edward Lemur50984a62020-02-06 18:10:18 +00001894 change_files = scm.GIT.CaptureStatus(
Edward Lemur7f6dec02020-02-06 20:23:58 +00001895 options.root, options.upstream or None)
Edward Lemur50984a62020-02-06 18:10:18 +00001896
1897 logging.info('Found %d file(s).', len(change_files))
1898
1899 change_class = GitChange if change_scm == 'git' else Change
1900 return change_class(
1901 options.name,
1902 options.description,
1903 options.root,
1904 change_files,
1905 options.issue,
1906 options.patchset,
1907 options.author,
1908 upstream=options.upstream)
1909
1910
1911def _parse_gerrit_options(parser, options):
1912 """Process gerrit options.
1913
1914 SIDE EFFECTS: Modifies options.author and options.description from Gerrit if
1915 options.gerrit_fetch is set.
1916
1917 Args:
1918 parser: The parser used to parse the arguments from command line.
1919 options: The arguments parsed from command line.
1920 Returns:
Stephen Martinisfb09de22021-02-25 03:41:13 +00001921 A GerritAccessor object if options.gerrit_url is set, or None otherwise.
Edward Lemur50984a62020-02-06 18:10:18 +00001922 """
1923 gerrit_obj = None
Stephen Martinisfb09de22021-02-25 03:41:13 +00001924 if options.gerrit_url:
Edward Lesmeseb1bd622021-03-01 19:54:07 +00001925 gerrit_obj = GerritAccessor(
1926 url=options.gerrit_url,
1927 project=options.gerrit_project,
1928 branch=options.gerrit_branch)
Edward Lemur50984a62020-02-06 18:10:18 +00001929
1930 if not options.gerrit_fetch:
1931 return gerrit_obj
1932
1933 if not options.gerrit_url or not options.issue or not options.patchset:
1934 parser.error(
1935 '--gerrit_fetch requires --gerrit_url, --issue and --patchset.')
1936
1937 options.author = gerrit_obj.GetChangeOwner(options.issue)
1938 options.description = gerrit_obj.GetChangeDescription(
1939 options.issue, options.patchset)
1940
1941 logging.info('Got author: "%s"', options.author)
1942 logging.info('Got description: """\n%s\n"""', options.description)
1943
1944 return gerrit_obj
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001945
1946
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001947@contextlib.contextmanager
1948def canned_check_filter(method_names):
1949 filtered = {}
1950 try:
1951 for method_name in method_names:
1952 if not hasattr(presubmit_canned_checks, method_name):
Gavin Make6a62332020-12-04 21:57:10 +00001953 logging.warning('Skipping unknown "canned" check %s' % method_name)
Aaron Gableecee74c2018-04-02 15:13:08 -07001954 continue
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001955 filtered[method_name] = getattr(presubmit_canned_checks, method_name)
1956 setattr(presubmit_canned_checks, method_name, lambda *_a, **_kw: [])
1957 yield
1958 finally:
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001959 for name, method in filtered.items():
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001960 setattr(presubmit_canned_checks, name, method)
1961
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +00001962
sbc@chromium.org013731e2015-02-26 18:28:43 +00001963def main(argv=None):
Edward Lemura5799e32020-01-17 19:26:51 +00001964 parser = argparse.ArgumentParser(usage='%(prog)s [options] <files...>')
1965 hooks = parser.add_mutually_exclusive_group()
1966 hooks.add_argument('-c', '--commit', action='store_true',
1967 help='Use commit instead of upload checks.')
1968 hooks.add_argument('-u', '--upload', action='store_false', dest='commit',
1969 help='Use upload instead of commit checks.')
Edward Lemur75526302020-02-27 22:31:05 +00001970 hooks.add_argument('--post_upload', action='store_true',
1971 help='Run post-upload commit hooks.')
Edward Lemura5799e32020-01-17 19:26:51 +00001972 parser.add_argument('-r', '--recursive', action='store_true',
1973 help='Act recursively.')
1974 parser.add_argument('-v', '--verbose', action='count', default=0,
1975 help='Use 2 times for more debug info.')
1976 parser.add_argument('--name', default='no name')
1977 parser.add_argument('--author')
Edward Lemur227d5102020-02-25 23:45:35 +00001978 desc = parser.add_mutually_exclusive_group()
1979 desc.add_argument('--description', default='', help='The change description.')
1980 desc.add_argument('--description_file',
1981 help='File to read change description from.')
Edward Lemura5799e32020-01-17 19:26:51 +00001982 parser.add_argument('--issue', type=int, default=0)
1983 parser.add_argument('--patchset', type=int, default=0)
1984 parser.add_argument('--root', default=os.getcwd(),
1985 help='Search for PRESUBMIT.py up to this directory. '
1986 'If inherit-review-settings-ok is present in this '
1987 'directory, parent directories up to the root file '
1988 'system directories will also be searched.')
1989 parser.add_argument('--upstream',
1990 help='Git only: the base ref or upstream branch against '
1991 'which the diff should be computed.')
1992 parser.add_argument('--default_presubmit')
1993 parser.add_argument('--may_prompt', action='store_true', default=False)
1994 parser.add_argument('--skip_canned', action='append', default=[],
1995 help='A list of checks to skip which appear in '
1996 'presubmit_canned_checks. Can be provided multiple times '
1997 'to skip multiple canned checks.')
1998 parser.add_argument('--dry_run', action='store_true', help=argparse.SUPPRESS)
1999 parser.add_argument('--gerrit_url', help=argparse.SUPPRESS)
Edward Lesmeseb1bd622021-03-01 19:54:07 +00002000 parser.add_argument('--gerrit_project', help=argparse.SUPPRESS)
2001 parser.add_argument('--gerrit_branch', help=argparse.SUPPRESS)
Edward Lemura5799e32020-01-17 19:26:51 +00002002 parser.add_argument('--gerrit_fetch', action='store_true',
2003 help=argparse.SUPPRESS)
2004 parser.add_argument('--parallel', action='store_true',
2005 help='Run all tests specified by input_api.RunTests in '
2006 'all PRESUBMIT files in parallel.')
2007 parser.add_argument('--json_output',
2008 help='Write presubmit errors to json output.')
Edward Lemur1dc66e12020-02-21 21:36:34 +00002009 parser.add_argument('--all_files', action='store_true',
Edward Lemur50984a62020-02-06 18:10:18 +00002010 help='Mark all files under source control as modified.')
Edward Lemura5799e32020-01-17 19:26:51 +00002011 parser.add_argument('files', nargs='*',
2012 help='List of files to be marked as modified when '
2013 'executing presubmit or post-upload hooks. fnmatch '
2014 'wildcards can also be used.')
Edward Lemura5799e32020-01-17 19:26:51 +00002015 options = parser.parse_args(argv)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00002016
Erik Staabcca5c492020-04-16 17:40:07 +00002017 log_level = logging.ERROR
maruel@chromium.org899e1c12011-04-07 17:03:18 +00002018 if options.verbose >= 2:
Erik Staabcca5c492020-04-16 17:40:07 +00002019 log_level = logging.DEBUG
maruel@chromium.org899e1c12011-04-07 17:03:18 +00002020 elif options.verbose:
Erik Staabcca5c492020-04-16 17:40:07 +00002021 log_level = logging.INFO
2022 log_format = ('[%(levelname).1s%(asctime)s %(process)d %(thread)d '
2023 '%(filename)s] %(message)s')
2024 logging.basicConfig(format=log_format, level=log_level)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00002025
Edward Lemur227d5102020-02-25 23:45:35 +00002026 if options.description_file:
2027 options.description = gclient_utils.FileRead(options.description_file)
Edward Lemur50984a62020-02-06 18:10:18 +00002028 gerrit_obj = _parse_gerrit_options(parser, options)
2029 change = _parse_change(parser, options)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00002030
maruel@chromium.org899e1c12011-04-07 17:03:18 +00002031 try:
Edward Lemur75526302020-02-27 22:31:05 +00002032 if options.post_upload:
2033 return DoPostUploadExecuter(
2034 change,
2035 gerrit_obj,
2036 options.verbose)
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00002037 with canned_check_filter(options.skip_canned):
Edward Lemur6eb1d322020-02-27 22:20:15 +00002038 return DoPresubmitChecks(
Edward Lemur50984a62020-02-06 18:10:18 +00002039 change,
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00002040 options.commit,
2041 options.verbose,
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00002042 options.default_presubmit,
2043 options.may_prompt,
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00002044 gerrit_obj,
Edward Lesmes8e282792018-04-03 18:50:29 -04002045 options.dry_run,
Debrian Figueroadd2737e2019-06-21 23:50:13 +00002046 options.parallel,
Edward Lesmeseb1bd622021-03-01 19:54:07 +00002047 options.json_output)
Raul Tambre7c938462019-05-24 16:35:35 +00002048 except PresubmitFailure as e:
Raul Tambre80ee78e2019-05-06 22:41:05 +00002049 print(e, file=sys.stderr)
2050 print('Maybe your depot_tools is out of date?', file=sys.stderr)
maruel@chromium.org899e1c12011-04-07 17:03:18 +00002051 return 2
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00002052
2053
2054if __name__ == '__main__':
maruel@chromium.org35625c72011-03-23 17:34:02 +00002055 fix_encoding.fix_encoding()
sbc@chromium.org013731e2015-02-26 18:28:43 +00002056 try:
2057 sys.exit(main())
2058 except KeyboardInterrupt:
2059 sys.stderr.write('interrupted\n')
sergiybf8a3b382016-07-05 11:21:30 -07002060 sys.exit(2)