blob: 7e8895ae2095a295f370752cfa1ee11eb6e20c9b [file] [log] [blame]
maruel@chromium.orgddd59412011-11-30 14:20:38 +00001#!/usr/bin/env python
maruel@chromium.orgeb5edbc2012-01-16 17:03:28 +00002# Copyright (c) 2012 The Chromium Authors. All rights reserved.
maruel@chromium.orgddd59412011-11-30 14:20:38 +00003# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5
6"""Unit tests for git_cl.py."""
7
Andrii Shyshkalovcd6a9362016-12-07 12:04:12 +01008import contextlib
Andrii Shyshkalovd8aa49f2017-03-17 16:05:49 +01009import datetime
tandriide281ae2016-10-12 06:02:30 -070010import json
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +010011import logging
maruel@chromium.orgddd59412011-11-30 14:20:38 +000012import os
maruel@chromium.orga3353652011-11-30 14:26:57 +000013import StringIO
maruel@chromium.orgddd59412011-11-30 14:20:38 +000014import sys
Aaron Gable9a03ae02017-11-03 11:31:07 -070015import tempfile
maruel@chromium.orgddd59412011-11-30 14:20:38 +000016import unittest
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +000017import urlparse
maruel@chromium.orgddd59412011-11-30 14:20:38 +000018
19sys.path.insert(0, os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
20
21from testing_support.auto_stub import TestCase
22
Edward Lemur5ba1e9c2018-07-23 18:19:02 +000023import metrics
24# We have to disable monitoring before importing git_cl.
25metrics.DISABLE_METRICS_COLLECTION = True
26
Eric Boren2fb63102018-10-05 13:05:03 +000027import gerrit_util
maruel@chromium.orgddd59412011-11-30 14:20:38 +000028import git_cl
iannucci@chromium.org9e849272014-04-04 00:31:55 +000029import git_common
tandrii@chromium.org57d86542016-03-04 16:11:32 +000030import git_footers
maruel@chromium.orgddd59412011-11-30 14:20:38 +000031import subprocess2
maruel@chromium.orgddd59412011-11-30 14:20:38 +000032
tandrii5d48c322016-08-18 16:19:37 -070033def callError(code=1, cmd='', cwd='', stdout='', stderr=''):
34 return subprocess2.CalledProcessError(code, cmd, cwd, stdout, stderr)
35
36
37CERR1 = callError(1)
38
39
Aaron Gable9a03ae02017-11-03 11:31:07 -070040def MakeNamedTemporaryFileMock(expected_content):
41 class NamedTemporaryFileMock(object):
42 def __init__(self, *args, **kwargs):
43 self.name = '/tmp/named'
44 self.expected_content = expected_content
45
46 def __enter__(self):
47 return self
48
49 def __exit__(self, _type, _value, _tb):
50 pass
51
52 def write(self, content):
53 if self.expected_content:
54 assert content == self.expected_content
55
56 def close(self):
57 pass
58
59 return NamedTemporaryFileMock
60
61
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000062class ChangelistMock(object):
63 # A class variable so we can access it when we don't have access to the
64 # instance that's being set.
65 desc = ""
66 def __init__(self, **kwargs):
67 pass
68 def GetIssue(self):
69 return 1
Kenneth Russell61e2ed42017-02-15 11:47:13 -080070 def GetDescription(self, force=False):
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000071 return ChangelistMock.desc
dsansomee2d6fd92016-09-08 00:10:47 -070072 def UpdateDescription(self, desc, force=False):
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +000073 ChangelistMock.desc = desc
74
tandrii5d48c322016-08-18 16:19:37 -070075
maruel@chromium.org2e72bb12012-01-17 15:18:35 +000076class PresubmitMock(object):
77 def __init__(self, *args, **kwargs):
78 self.reviewers = []
Daniel Cheng7227d212017-11-17 08:12:37 -080079 self.more_cc = ['chromium-reviews+test-more-cc@chromium.org']
80
maruel@chromium.org2e72bb12012-01-17 15:18:35 +000081 @staticmethod
82 def should_continue():
83 return True
84
85
maruel@chromium.org2e72bb12012-01-17 15:18:35 +000086class WatchlistsMock(object):
87 def __init__(self, _):
88 pass
89 @staticmethod
90 def GetWatchersForPaths(_):
91 return ['joe@example.com']
92
93
ukai@chromium.org78c4b982012-02-14 02:20:26 +000094class CodereviewSettingsFileMock(object):
95 def __init__(self):
96 pass
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -080097 # pylint: disable=no-self-use
ukai@chromium.org78c4b982012-02-14 02:20:26 +000098 def read(self):
99 return ("CODE_REVIEW_SERVER: gerrit.chromium.org\n" +
andybons@chromium.org11f46eb2016-02-02 19:26:51 +0000100 "GERRIT_HOST: True\n")
ukai@chromium.org78c4b982012-02-14 02:20:26 +0000101
102
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000103class AuthenticatorMock(object):
104 def __init__(self, *_args):
105 pass
106 def has_cached_credentials(self):
107 return True
tandrii221ab252016-10-06 08:12:04 -0700108 def authorize(self, http):
109 return http
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000110
111
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100112def CookiesAuthenticatorMockFactory(hosts_with_creds=None, same_auth=False):
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000113 """Use to mock Gerrit/Git credentials from ~/.netrc or ~/.gitcookies.
114
115 Usage:
116 >>> self.mock(git_cl.gerrit_util, "CookiesAuthenticator",
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100117 CookiesAuthenticatorMockFactory({'host': ('user', _, 'pass')})
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000118
119 OR
120 >>> self.mock(git_cl.gerrit_util, "CookiesAuthenticator",
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100121 CookiesAuthenticatorMockFactory(
122 same_auth=('user', '', 'pass'))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000123 """
124 class CookiesAuthenticatorMock(git_cl.gerrit_util.CookiesAuthenticator):
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800125 def __init__(self): # pylint: disable=super-init-not-called
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000126 # Intentionally not calling super() because it reads actual cookie files.
127 pass
128 @classmethod
129 def get_gitcookies_path(cls):
130 return '~/.gitcookies'
131 @classmethod
132 def get_netrc_path(cls):
133 return '~/.netrc'
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100134 def _get_auth_for_host(self, host):
135 if same_auth:
136 return same_auth
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000137 return (hosts_with_creds or {}).get(host)
138 return CookiesAuthenticatorMock
139
Aaron Gable9a03ae02017-11-03 11:31:07 -0700140
kmarshall9249e012016-08-23 12:02:16 -0700141class MockChangelistWithBranchAndIssue():
142 def __init__(self, branch, issue):
143 self.branch = branch
144 self.issue = issue
145 def GetBranch(self):
146 return self.branch
147 def GetIssue(self):
148 return self.issue
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000149
tandriic2405f52016-10-10 08:13:15 -0700150
151class SystemExitMock(Exception):
152 pass
153
154
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000155class TestGitClBasic(unittest.TestCase):
Andrii Shyshkalov31863012017-02-08 11:35:12 +0100156 def test_get_description(self):
Andrii Shyshkalovf5569d22018-10-15 03:35:23 +0000157 cl = git_cl.Changelist(issue=1, codereview='gerrit',
Andrii Shyshkalov31863012017-02-08 11:35:12 +0100158 codereview_host='host')
159 cl.description = 'x'
160 cl.has_description = True
Kenneth Russell61e2ed42017-02-15 11:47:13 -0800161 cl._codereview_impl.FetchDescription = lambda *a, **kw: 'y'
Andrii Shyshkalov31863012017-02-08 11:35:12 +0100162 self.assertEquals(cl.GetDescription(), 'x')
163 self.assertEquals(cl.GetDescription(force=True), 'y')
164 self.assertEquals(cl.GetDescription(), 'y')
165
Robert Iannucci09f1f3d2017-03-28 16:54:32 -0700166 def test_description_footers(self):
167 cl = git_cl.Changelist(issue=1, codereview='gerrit',
168 codereview_host='host')
169 cl.description = '\n'.join([
170 'This is some message',
171 '',
172 'It has some lines',
173 'and, also',
174 '',
175 'Some: Really',
176 'Awesome: Footers',
177 ])
178 cl.has_description = True
179 cl._codereview_impl.UpdateDescriptionRemote = lambda *a, **kw: 'y'
180 msg, footers = cl.GetDescriptionFooters()
181 self.assertEquals(
182 msg, ['This is some message', '', 'It has some lines', 'and, also'])
183 self.assertEquals(footers, [('Some', 'Really'), ('Awesome', 'Footers')])
184
185 msg.append('wut')
186 footers.append(('gnarly-dude', 'beans'))
187 cl.UpdateDescriptionFooters(msg, footers)
188 self.assertEquals(cl.GetDescription().splitlines(), [
189 'This is some message',
190 '',
191 'It has some lines',
192 'and, also',
193 'wut'
194 '',
195 'Some: Really',
196 'Awesome: Footers',
197 'Gnarly-Dude: beans',
198 ])
199
Andrii Shyshkalov71f0da32019-07-15 22:45:18 +0000200 def test_set_preserve_tryjobs(self):
201 d = git_cl.ChangeDescription('Simple.')
202 d.set_preserve_tryjobs()
203 self.assertEqual(d.description.splitlines(), [
204 'Simple.',
205 '',
206 'Cq-Do-Not-Cancel-Tryjobs: true',
207 ])
208 before = d.description
209 d.set_preserve_tryjobs()
210 self.assertEqual(before, d.description)
211
212 d = git_cl.ChangeDescription('\n'.join([
213 'One is enough',
214 '',
215 'Cq-Do-Not-Cancel-Tryjobs: dups not encouraged, but don\'t hurt',
216 'Change-Id: Ideadbeef',
217 ]))
218 d.set_preserve_tryjobs()
219 self.assertEqual(d.description.splitlines(), [
220 'One is enough',
221 '',
222 'Cq-Do-Not-Cancel-Tryjobs: dups not encouraged, but don\'t hurt',
223 'Change-Id: Ideadbeef',
224 'Cq-Do-Not-Cancel-Tryjobs: true',
225 ])
226
227
tandriif9aefb72016-07-01 09:06:51 -0700228 def test_get_bug_line_values(self):
229 f = lambda p, bugs: list(git_cl._get_bug_line_values(p, bugs))
230 self.assertEqual(f('', ''), [])
231 self.assertEqual(f('', '123,v8:456'), ['123', 'v8:456'])
232 self.assertEqual(f('v8', '456'), ['v8:456'])
233 self.assertEqual(f('v8', 'chromium:123,456'), ['v8:456', 'chromium:123'])
234 # Not nice, but not worth carying.
235 self.assertEqual(f('v8', 'chromium:123,456,v8:123'),
236 ['v8:456', 'chromium:123', 'v8:123'])
237
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100238 def _test_git_number(self, parent_msg, dest_ref, child_msg,
239 parent_hash='parenthash'):
240 desc = git_cl.ChangeDescription(child_msg)
241 desc.update_with_git_number_footers(parent_hash, parent_msg, dest_ref)
242 return desc.description
243
244 def assertEqualByLine(self, actual, expected):
245 self.assertEqual(actual.splitlines(), expected.splitlines())
246
247 def test_git_number_bad_parent(self):
248 with self.assertRaises(ValueError):
249 self._test_git_number('Parent', 'refs/heads/master', 'Child')
250
251 def test_git_number_bad_parent_footer(self):
252 with self.assertRaises(AssertionError):
253 self._test_git_number(
254 'Parent\n'
255 '\n'
256 'Cr-Commit-Position: wrong',
257 'refs/heads/master', 'Child')
258
259 def test_git_number_bad_lineage_ignored(self):
260 actual = self._test_git_number(
261 'Parent\n'
262 '\n'
263 'Cr-Commit-Position: refs/heads/master@{#1}\n'
264 'Cr-Branched-From: mustBeReal40CharHash-branch@{#pos}',
265 'refs/heads/master', 'Child')
266 self.assertEqualByLine(
267 actual,
268 'Child\n'
269 '\n'
270 'Cr-Commit-Position: refs/heads/master@{#2}\n'
271 'Cr-Branched-From: mustBeReal40CharHash-branch@{#pos}')
272
273 def test_git_number_same_branch(self):
274 actual = self._test_git_number(
275 'Parent\n'
276 '\n'
277 'Cr-Commit-Position: refs/heads/master@{#12}',
278 dest_ref='refs/heads/master',
279 child_msg='Child')
280 self.assertEqualByLine(
281 actual,
282 'Child\n'
283 '\n'
284 'Cr-Commit-Position: refs/heads/master@{#13}')
285
Andrii Shyshkalovde37c012017-07-06 21:06:50 +0200286 def test_git_number_same_branch_mixed_footers(self):
287 actual = self._test_git_number(
288 'Parent\n'
289 '\n'
290 'Cr-Commit-Position: refs/heads/master@{#12}',
291 dest_ref='refs/heads/master',
292 child_msg='Child\n'
293 '\n'
294 'Broken-by: design\n'
295 'BUG=123')
296 self.assertEqualByLine(
297 actual,
298 'Child\n'
299 '\n'
300 'Broken-by: design\n'
301 'BUG=123\n'
302 'Cr-Commit-Position: refs/heads/master@{#13}')
303
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100304 def test_git_number_same_branch_with_originals(self):
305 actual = self._test_git_number(
306 'Parent\n'
307 '\n'
308 'Cr-Commit-Position: refs/heads/master@{#12}',
309 dest_ref='refs/heads/master',
310 child_msg='Child\n'
311 '\n'
312 'Some users are smart and insert their own footers\n'
313 '\n'
314 'Cr-Whatever: value\n'
315 'Cr-Commit-Position: refs/copy/paste@{#22}')
316 self.assertEqualByLine(
317 actual,
318 'Child\n'
319 '\n'
320 'Some users are smart and insert their own footers\n'
321 '\n'
322 'Cr-Original-Whatever: value\n'
323 'Cr-Original-Commit-Position: refs/copy/paste@{#22}\n'
324 'Cr-Commit-Position: refs/heads/master@{#13}')
325
326 def test_git_number_new_branch(self):
327 actual = self._test_git_number(
328 'Parent\n'
329 '\n'
330 'Cr-Commit-Position: refs/heads/master@{#12}',
331 dest_ref='refs/heads/branch',
332 child_msg='Child')
333 self.assertEqualByLine(
334 actual,
335 'Child\n'
336 '\n'
337 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
338 'Cr-Branched-From: parenthash-refs/heads/master@{#12}')
339
340 def test_git_number_lineage(self):
341 actual = self._test_git_number(
342 'Parent\n'
343 '\n'
344 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
345 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
346 dest_ref='refs/heads/branch',
347 child_msg='Child')
348 self.assertEqualByLine(
349 actual,
350 'Child\n'
351 '\n'
352 'Cr-Commit-Position: refs/heads/branch@{#2}\n'
353 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
354
355 def test_git_number_moooooooore_lineage(self):
356 actual = self._test_git_number(
357 'Parent\n'
358 '\n'
359 'Cr-Commit-Position: refs/heads/branch@{#5}\n'
360 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
361 dest_ref='refs/heads/mooore',
362 child_msg='Child')
363 self.assertEqualByLine(
364 actual,
365 'Child\n'
366 '\n'
367 'Cr-Commit-Position: refs/heads/mooore@{#1}\n'
368 'Cr-Branched-From: parenthash-refs/heads/branch@{#5}\n'
369 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
370
Andrii Shyshkalovb5effa12016-12-14 19:35:12 +0100371 def test_git_number_ever_moooooooore_lineage(self):
Robert Iannucci456b0d62018-03-13 19:15:50 -0700372 self.maxDiff = 10000 # pylint: disable=attribute-defined-outside-init
Andrii Shyshkalovb5effa12016-12-14 19:35:12 +0100373 actual = self._test_git_number(
374 'CQ commit on fresh new branch + numbering.\n'
375 '\n'
376 'NOTRY=True\n'
377 'NOPRESUBMIT=True\n'
378 'BUG=\n'
379 '\n'
380 'Review-Url: https://codereview.chromium.org/2577703003\n'
381 'Cr-Commit-Position: refs/heads/gnumb-test/br@{#1}\n'
382 'Cr-Branched-From: 0749ff9edc-refs/heads/gnumb-test/cq@{#4}\n'
383 'Cr-Branched-From: 5c49df2da6-refs/heads/master@{#41618}',
384 dest_ref='refs/heads/gnumb-test/cl',
385 child_msg='git cl on fresh new branch + numbering.\n'
386 '\n'
387 'Review-Url: https://codereview.chromium.org/2575043003 .\n')
388 self.assertEqualByLine(
389 actual,
390 'git cl on fresh new branch + numbering.\n'
391 '\n'
392 'Review-Url: https://codereview.chromium.org/2575043003 .\n'
393 'Cr-Commit-Position: refs/heads/gnumb-test/cl@{#1}\n'
394 'Cr-Branched-From: parenthash-refs/heads/gnumb-test/br@{#1}\n'
395 'Cr-Branched-From: 0749ff9edc-refs/heads/gnumb-test/cq@{#4}\n'
396 'Cr-Branched-From: 5c49df2da6-refs/heads/master@{#41618}')
Andrii Shyshkalov15e50cc2016-12-02 14:34:08 +0100397
398 def test_git_number_cherry_pick(self):
399 actual = self._test_git_number(
400 'Parent\n'
401 '\n'
402 'Cr-Commit-Position: refs/heads/branch@{#1}\n'
403 'Cr-Branched-From: somehash-refs/heads/master@{#12}',
404 dest_ref='refs/heads/branch',
405 child_msg='Child, which is cherry-pick from master\n'
406 '\n'
407 'Cr-Commit-Position: refs/heads/master@{#100}\n'
408 '(cherry picked from commit deadbeef12345678deadbeef12345678deadbeef)')
409 self.assertEqualByLine(
410 actual,
411 'Child, which is cherry-pick from master\n'
412 '\n'
413 '(cherry picked from commit deadbeef12345678deadbeef12345678deadbeef)\n'
414 '\n'
415 'Cr-Original-Commit-Position: refs/heads/master@{#100}\n'
416 'Cr-Commit-Position: refs/heads/branch@{#2}\n'
417 'Cr-Branched-From: somehash-refs/heads/master@{#12}')
418
Andrii Shyshkalovd4c86732018-09-25 04:29:31 +0000419 def test_gerrit_mirror_hack(self):
420 cr = 'chromium-review.googlesource.com'
421 url0 = 'https://%s/a/changes/x?a=b' % cr
422 origMirrors = git_cl.gerrit_util._GERRIT_MIRROR_PREFIXES
423 try:
424 git_cl.gerrit_util._GERRIT_MIRROR_PREFIXES = ['us1', 'us2']
425 url1 = git_cl.gerrit_util._UseGerritMirror(url0, cr)
426 url2 = git_cl.gerrit_util._UseGerritMirror(url1, cr)
427 url3 = git_cl.gerrit_util._UseGerritMirror(url2, cr)
428
429 self.assertNotEqual(url1, url2)
430 self.assertEqual(sorted((url1, url2)), [
431 'https://us1-mirror-chromium-review.googlesource.com/a/changes/x?a=b',
432 'https://us2-mirror-chromium-review.googlesource.com/a/changes/x?a=b'])
433 self.assertEqual(url1, url3)
434 finally:
435 git_cl.gerrit_util._GERRIT_MIRROR_PREFIXES = origMirrors
436
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +0000437 def test_valid_accounts(self):
438 mock_per_account = {
439 'u1': None, # 404, doesn't exist.
440 'u2': {
441 '_account_id': 123124,
442 'avatars': [],
443 'email': 'u2@example.com',
444 'name': 'User Number 2',
445 'status': 'OOO',
446 },
447 'u3': git_cl.gerrit_util.GerritError(500, 'retries didn\'t help :('),
448 }
449 def GetAccountDetailsMock(_, account):
450 # Poor-man's mock library's side_effect.
451 v = mock_per_account.pop(account)
452 if isinstance(v, Exception):
453 raise v
454 return v
455
456 original = git_cl.gerrit_util.GetAccountDetails
457 try:
458 git_cl.gerrit_util.GetAccountDetails = GetAccountDetailsMock
459 actual = git_cl.gerrit_util.ValidAccounts(
460 'host', ['u1', 'u2', 'u3'], max_threads=1)
461 finally:
462 git_cl.gerrit_util.GetAccountDetails = original
463 self.assertEqual(actual, {
464 'u2': {
465 '_account_id': 123124,
466 'avatars': [],
467 'email': 'u2@example.com',
468 'name': 'User Number 2',
469 'status': 'OOO',
470 },
471 })
472
473
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +0000474
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200475class TestParseIssueURL(unittest.TestCase):
476 def _validate(self, parsed, issue=None, patchset=None, hostname=None,
477 codereview=None, fail=False):
478 self.assertIsNotNone(parsed)
479 if fail:
480 self.assertFalse(parsed.valid)
481 return
482 self.assertTrue(parsed.valid)
483 self.assertEqual(parsed.issue, issue)
484 self.assertEqual(parsed.patchset, patchset)
485 self.assertEqual(parsed.hostname, hostname)
486 self.assertEqual(parsed.codereview, codereview)
487
488 def _run_and_validate(self, func, url, *args, **kwargs):
489 result = func(urlparse.urlparse(url))
490 if kwargs.pop('fail', False):
491 self.assertIsNone(result)
492 return None
493 self._validate(result, *args, fail=False, **kwargs)
494
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200495 def test_gerrit(self):
496 def test(url, issue=None, patchset=None, hostname=None, fail=None):
497 self._test_ParseIssueUrl(
498 git_cl._GerritChangelistImpl.ParseIssueURL,
499 url, issue, patchset, hostname, fail)
500 def test(url, *args, **kwargs):
501 self._run_and_validate(git_cl._GerritChangelistImpl.ParseIssueURL, url,
502 *args, codereview='gerrit', **kwargs)
503
504 test('http://chrome-review.source.com/c/123',
505 123, None, 'chrome-review.source.com')
506 test('https://chrome-review.source.com/c/123/',
507 123, None, 'chrome-review.source.com')
508 test('https://chrome-review.source.com/c/123/4',
509 123, 4, 'chrome-review.source.com')
510 test('https://chrome-review.source.com/#/c/123/4',
511 123, 4, 'chrome-review.source.com')
512 test('https://chrome-review.source.com/c/123/4',
513 123, 4, 'chrome-review.source.com')
514 test('https://chrome-review.source.com/123',
515 123, None, 'chrome-review.source.com')
516 test('https://chrome-review.source.com/123/4',
517 123, 4, 'chrome-review.source.com')
518
519 test('https://chrome-review.source.com/c/123/1/whatisthis', fail=True)
520 test('https://chrome-review.source.com/c/abc/', fail=True)
521 test('ssh://chrome-review.source.com/c/123/1/', fail=True)
522
523 def test_ParseIssueNumberArgument(self):
524 def test(arg, *args, **kwargs):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +0200525 codereview_hint = kwargs.pop('hint', None)
526 self._validate(git_cl.ParseIssueNumberArgument(arg, codereview_hint),
527 *args, **kwargs)
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200528
529 test('123', 123)
530 test('', fail=True)
531 test('abc', fail=True)
532 test('123/1', fail=True)
533 test('123a', fail=True)
534 test('ssh://chrome-review.source.com/#/c/123/4/', fail=True)
Andrii Shyshkalovf5569d22018-10-15 03:35:23 +0000535
536 # Looks like Rietveld and Gerrit, but we should select Gerrit now
537 # w/ or w/o hint.
Andrii Shyshkalovc9712392017-04-11 13:35:21 +0200538 test('https://codereview.source.com/123',
539 123, None, 'codereview.source.com', 'gerrit',
540 hint='gerrit')
Andrii Shyshkalovf5569d22018-10-15 03:35:23 +0000541 test('https://codereview.source.com/123',
542 123, None, 'codereview.source.com', 'gerrit')
543
Andrii Shyshkalov90f31922017-04-10 16:10:21 +0200544 # Gerrrit.
545 test('https://chrome-review.source.com/c/123/4',
546 123, 4, 'chrome-review.source.com', 'gerrit')
547 test('https://chrome-review.source.com/bad/123/4', fail=True)
548
549
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100550class GitCookiesCheckerTest(TestCase):
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100551 def setUp(self):
552 super(GitCookiesCheckerTest, self).setUp()
553 self.c = git_cl._GitCookiesChecker()
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100554 self.c._all_hosts = []
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100555
556 def mock_hosts_creds(self, subhost_identity_pairs):
557 def ensure_googlesource(h):
558 if not h.endswith(self.c._GOOGLESOURCE):
559 assert not h.endswith('.')
560 return h + '.' + self.c._GOOGLESOURCE
561 return h
562 self.c._all_hosts = [(ensure_googlesource(h), i, '.gitcookies')
563 for h, i in subhost_identity_pairs]
564
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +0200565 def test_identity_parsing(self):
566 self.assertEqual(self.c._parse_identity('ldap.google.com'),
567 ('ldap', 'google.com'))
568 self.assertEqual(self.c._parse_identity('git-ldap.example.com'),
569 ('ldap', 'example.com'))
570 # Specical case because we know there are no subdomains in chromium.org.
571 self.assertEqual(self.c._parse_identity('git-note.period.chromium.org'),
572 ('note.period', 'chromium.org'))
Lei Zhangd3f769a2017-12-15 15:16:14 -0800573 # Pathological: ".period." can be either username OR domain, more likely
574 # domain.
Andrii Shyshkalov0d2dea02017-07-17 15:17:55 +0200575 self.assertEqual(self.c._parse_identity('git-note.period.example.com'),
576 ('note', 'period.example.com'))
577
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100578 def test_analysis_nothing(self):
579 self.c._all_hosts = []
580 self.assertFalse(self.c.has_generic_host())
581 self.assertEqual(set(), self.c.get_conflicting_hosts())
582 self.assertEqual(set(), self.c.get_duplicated_hosts())
583 self.assertEqual(set(), self.c.get_partially_configured_hosts())
584 self.assertEqual(set(), self.c.get_hosts_with_wrong_identities())
585
586 def test_analysis(self):
587 self.mock_hosts_creds([
588 ('.googlesource.com', 'git-example.chromium.org'),
589
590 ('chromium', 'git-example.google.com'),
591 ('chromium-review', 'git-example.google.com'),
592 ('chrome-internal', 'git-example.chromium.org'),
593 ('chrome-internal-review', 'git-example.chromium.org'),
594 ('conflict', 'git-example.google.com'),
595 ('conflict-review', 'git-example.chromium.org'),
596 ('dup', 'git-example.google.com'),
597 ('dup', 'git-example.google.com'),
598 ('dup-review', 'git-example.google.com'),
599 ('partial', 'git-example.google.com'),
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200600 ('gpartial-review', 'git-example.google.com'),
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100601 ])
602 self.assertTrue(self.c.has_generic_host())
603 self.assertEqual(set(['conflict.googlesource.com']),
604 self.c.get_conflicting_hosts())
605 self.assertEqual(set(['dup.googlesource.com']),
606 self.c.get_duplicated_hosts())
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200607 self.assertEqual(set(['partial.googlesource.com',
608 'gpartial-review.googlesource.com']),
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100609 self.c.get_partially_configured_hosts())
610 self.assertEqual(set(['chromium.googlesource.com',
611 'chrome-internal.googlesource.com']),
612 self.c.get_hosts_with_wrong_identities())
613
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100614 def test_report_no_problems(self):
615 self.test_analysis_nothing()
616 self.mock(sys, 'stdout', StringIO.StringIO())
617 self.assertFalse(self.c.find_and_report_problems())
618 self.assertEqual(sys.stdout.getvalue(), '')
619
620 def test_report(self):
621 self.test_analysis()
622 self.mock(sys, 'stdout', StringIO.StringIO())
Andrii Shyshkalovc8173822017-07-10 12:10:53 +0200623 self.mock(git_cl.gerrit_util.CookiesAuthenticator, 'get_gitcookies_path',
624 classmethod(lambda _: '~/.gitcookies'))
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +0100625 self.assertTrue(self.c.find_and_report_problems())
626 with open(os.path.join(os.path.dirname(__file__),
627 'git_cl_creds_check_report.txt')) as f:
628 expected = f.read()
629 def by_line(text):
630 return [l.rstrip() for l in text.rstrip().splitlines()]
Robert Iannucci456b0d62018-03-13 19:15:50 -0700631 self.maxDiff = 10000 # pylint: disable=attribute-defined-outside-init
Andrii Shyshkalov4812e612017-03-27 17:22:57 +0200632 self.assertEqual(by_line(sys.stdout.getvalue().strip()), by_line(expected))
Andrii Shyshkalov97800502017-03-16 16:04:32 +0100633
Nodir Turakulovd0e2cd22017-11-15 10:22:06 -0800634
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000635class TestGitCl(TestCase):
636 def setUp(self):
637 super(TestGitCl, self).setUp()
638 self.calls = []
tandrii9d206752016-06-20 11:32:47 -0700639 self._calls_done = []
Edward Lemur01f4a4f2018-11-03 00:40:38 +0000640 self.mock(git_cl, 'time_time',
641 lambda: self._mocked_call('time.time'))
642 self.mock(git_cl.metrics.collector, 'add_repeated',
643 lambda *a: self._mocked_call('add_repeated', *a))
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000644 self.mock(subprocess2, 'call', self._mocked_call)
645 self.mock(subprocess2, 'check_call', self._mocked_call)
646 self.mock(subprocess2, 'check_output', self._mocked_call)
tandrii5d48c322016-08-18 16:19:37 -0700647 self.mock(subprocess2, 'communicate',
648 lambda *a, **kw: ([self._mocked_call(*a, **kw), ''], 0))
tandrii@chromium.orga342c922016-03-16 07:08:25 +0000649 self.mock(git_cl.gclient_utils, 'CheckCallAndFilter', self._mocked_call)
sbc@chromium.org71437c02015-04-09 19:29:40 +0000650 self.mock(git_common, 'is_dirty_git_tree', lambda x: False)
iannucci@chromium.org9e849272014-04-04 00:31:55 +0000651 self.mock(git_common, 'get_or_create_merge_base',
652 lambda *a: (
653 self._mocked_call(['get_or_create_merge_base']+list(a))))
pgervais@chromium.org8ba38ff2015-06-11 21:41:25 +0000654 self.mock(git_cl, 'BranchExists', lambda _: True)
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000655 self.mock(git_cl, 'FindCodereviewSettingsFile', lambda: '')
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000656 self.mock(git_cl, 'SaveDescriptionBackup', lambda _:
657 self._mocked_call('SaveDescriptionBackup'))
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100658 self.mock(git_cl, 'ask_for_data', lambda *a, **k: self._mocked_call(
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000659 *(['ask_for_data'] + list(a)), **k))
phajdan.jre328cf92016-08-22 04:12:17 -0700660 self.mock(git_cl, 'write_json', lambda path, contents:
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +0000661 self._mocked_call('write_json', path, contents))
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000662 self.mock(git_cl.presubmit_support, 'DoPresubmitChecks', PresubmitMock)
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000663 self.mock(git_cl.watchlists, 'Watchlists', WatchlistsMock)
vadimsh@chromium.orgeed4df32015-04-10 21:30:20 +0000664 self.mock(git_cl.auth, 'get_authenticator_for_host', AuthenticatorMock)
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +0100665 self.mock(git_cl.gerrit_util, 'GetChangeDetail',
666 lambda *args, **kwargs: self._mocked_call(
667 'GetChangeDetail', *args, **kwargs))
Aaron Gable0ffdf2d2017-06-05 13:01:17 -0700668 self.mock(git_cl.gerrit_util, 'GetChangeComments',
669 lambda *args, **kwargs: self._mocked_call(
670 'GetChangeComments', *args, **kwargs))
Quinten Yearsley0e617c02019-02-20 00:37:03 +0000671 self.mock(git_cl.gerrit_util, 'GetChangeRobotComments',
672 lambda *args, **kwargs: self._mocked_call(
673 'GetChangeRobotComments', *args, **kwargs))
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +0100674 self.mock(git_cl.gerrit_util, 'AddReviewers',
Aaron Gable6dadfbf2017-05-09 14:27:58 -0700675 lambda h, i, reviewers, ccs, notify: self._mocked_call(
676 'AddReviewers', h, i, reviewers, ccs, notify))
Aaron Gablefd238082017-06-07 13:42:34 -0700677 self.mock(git_cl.gerrit_util, 'SetReview',
Aaron Gablefc62f762017-07-17 11:12:07 -0700678 lambda h, i, msg=None, labels=None, notify=None:
679 self._mocked_call('SetReview', h, i, msg, labels, notify))
Andrii Shyshkalov733d4ec2018-04-19 11:48:58 -0700680 self.mock(git_cl.gerrit_util.LuciContextAuthenticator, 'is_luci',
681 staticmethod(lambda: False))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000682 self.mock(git_cl.gerrit_util.GceAuthenticator, 'is_gce',
683 classmethod(lambda _: False))
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +0000684 self.mock(git_cl.gerrit_util, 'ValidAccounts',
685 lambda host, accounts:
686 self._mocked_call('ValidAccounts', host, accounts))
tandriic2405f52016-10-10 08:13:15 -0700687 self.mock(git_cl, 'DieWithError',
Christopher Lamf732cd52017-01-24 12:40:11 +1100688 lambda msg, change=None: self._mocked_call(['DieWithError', msg]))
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000689 # It's important to reset settings to not have inter-tests interference.
690 git_cl.settings = None
691
692 def tearDown(self):
wychen@chromium.org445c8962015-04-28 23:30:05 +0000693 try:
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100694 self.assertEquals([], self.calls)
695 except AssertionError:
wychen@chromium.org445c8962015-04-28 23:30:05 +0000696 if not self.has_failed():
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100697 raise
698 # Sadly, has_failed() returns True if this OR any other tests before this
699 # one have failed.
Andrii Shyshkalove05d4882017-04-12 14:34:49 +0200700 git_cl.logging.error(
701 '!!!!!! IF YOU SEE THIS, READ BELOW, IT WILL SAVE YOUR TIME !!!!!\n'
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100702 'There are un-consumed self.calls after this test has finished.\n'
703 'If you don\'t know which test this is, run:\n'
Aaron Gable3a16ed12017-03-23 10:51:55 -0700704 ' tests/git_cl_tests.py -v\n'
Andrii Shyshkalove05d4882017-04-12 14:34:49 +0200705 'If you are already running only this test, then **first** fix the '
706 'problem whose exception is emitted below by unittest runner.\n'
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100707 'Else, to be sure what\'s going on, run this test **alone** with \n'
Aaron Gable3a16ed12017-03-23 10:51:55 -0700708 ' tests/git_cl_tests.py TestGitCl.<name>\n'
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +0100709 'and follow instructions above.\n' +
710 '=' * 80)
wychen@chromium.org445c8962015-04-28 23:30:05 +0000711 finally:
712 super(TestGitCl, self).tearDown()
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000713
iannucci@chromium.org9e849272014-04-04 00:31:55 +0000714 def _mocked_call(self, *args, **_kwargs):
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000715 self.assertTrue(
716 self.calls,
tandrii9d206752016-06-20 11:32:47 -0700717 '@%d Expected: <Missing> Actual: %r' % (len(self._calls_done), args))
wychen@chromium.orga872e752015-04-28 23:42:18 +0000718 top = self.calls.pop(0)
wychen@chromium.orga872e752015-04-28 23:42:18 +0000719 expected_args, result = top
720
maruel@chromium.orge52678e2013-04-26 18:34:44 +0000721 # Also logs otherwise it could get caught in a try/finally and be hard to
722 # diagnose.
723 if expected_args != args:
tandrii9d206752016-06-20 11:32:47 -0700724 N = 5
725 prior_calls = '\n '.join(
726 '@%d: %r' % (len(self._calls_done) - N + i, c[0])
727 for i, c in enumerate(self._calls_done[-N:]))
728 following_calls = '\n '.join(
729 '@%d: %r' % (len(self._calls_done) + i + 1, c[0])
730 for i, c in enumerate(self.calls[:N]))
731 extended_msg = (
732 'A few prior calls:\n %s\n\n'
733 'This (expected):\n @%d: %r\n'
734 'This (actual):\n @%d: %r\n\n'
735 'A few following expected calls:\n %s' %
736 (prior_calls, len(self._calls_done), expected_args,
737 len(self._calls_done), args, following_calls))
738 git_cl.logging.error(extended_msg)
739
tandrii99a72f22016-08-17 14:33:24 -0700740 self.fail('@%d\n'
741 ' Expected: %r\n'
742 ' Actual: %r' % (
tandrii9d206752016-06-20 11:32:47 -0700743 len(self._calls_done), expected_args, args))
744
745 self._calls_done.append(top)
tandrii5d48c322016-08-18 16:19:37 -0700746 if isinstance(result, Exception):
747 raise result
maruel@chromium.org2e72bb12012-01-17 15:18:35 +0000748 return result
749
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +0100750 def test_ask_for_explicit_yes_true(self):
751 self.calls = [
752 (('ask_for_data', 'prompt [Yes/No]: '), 'blah'),
753 (('ask_for_data', 'Please, type yes or no: '), 'ye'),
754 ]
755 self.assertTrue(git_cl.ask_for_explicit_yes('prompt'))
756
tandrii48df5812016-10-17 03:55:37 -0700757 def test_LoadCodereviewSettingsFromFile_gerrit(self):
758 codereview_file = StringIO.StringIO('GERRIT_HOST: true')
759 self.calls = [
760 ((['git', 'config', '--unset-all', 'rietveld.cc'],), CERR1),
tandrii48df5812016-10-17 03:55:37 -0700761 ((['git', 'config', '--unset-all', 'rietveld.tree-status-url'],), CERR1),
762 ((['git', 'config', '--unset-all', 'rietveld.viewvc-url'],), CERR1),
763 ((['git', 'config', '--unset-all', 'rietveld.bug-prefix'],), CERR1),
764 ((['git', 'config', '--unset-all', 'rietveld.cpplint-regex'],), CERR1),
tandrii48df5812016-10-17 03:55:37 -0700765 ((['git', 'config', '--unset-all', 'rietveld.cpplint-ignore-regex'],),
766 CERR1),
tandrii48df5812016-10-17 03:55:37 -0700767 ((['git', 'config', '--unset-all', 'rietveld.run-post-upload-hook'],),
768 CERR1),
769 ((['git', 'config', 'gerrit.host', 'true'],), ''),
770 ]
771 self.assertIsNone(git_cl.LoadCodereviewSettingsFromFile(codereview_file))
772
maruel@chromium.orga3353652011-11-30 14:26:57 +0000773 @classmethod
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000774 def _is_gerrit_calls(cls, gerrit=False):
775 return [((['git', 'config', 'rietveld.autoupdate'],), ''),
776 ((['git', 'config', 'gerrit.host'],), 'True' if gerrit else '')]
777
778 @classmethod
tandrii@chromium.org1e67bb72016-02-11 12:15:49 +0000779 def _git_post_upload_calls(cls):
780 return [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000781 ((['git', 'rev-parse', 'HEAD'],), 'hash'),
782 ((['git', 'symbolic-ref', 'HEAD'],), 'hash'),
783 ((['git',
tyoshino@chromium.orgc1737d02013-05-29 14:17:28 +0000784 'config', 'branch.hash.last-upload-hash', 'hash'],), ''),
rmistry@google.com5626a922015-02-26 14:03:30 +0000785 ((['git', 'config', 'rietveld.run-post-upload-hook'],), ''),
maruel@chromium.orgddd59412011-11-30 14:20:38 +0000786 ]
787
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000788 @staticmethod
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000789 def _git_sanity_checks(diff_base, working_branch, get_remote_branch=True):
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000790 fake_ancestor = 'fake_ancestor'
791 fake_cl = 'fake_cl_for_patch'
792 return [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000793 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000794 'rev-parse', '--verify', diff_base],), fake_ancestor),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000795 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000796 'merge-base', fake_ancestor, 'HEAD'],), fake_ancestor),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000797 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000798 'rev-list', '^' + fake_ancestor, 'HEAD'],), fake_cl),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000799 # Mock a config miss (error code 1)
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000800 ((['git',
tandrii5d48c322016-08-18 16:19:37 -0700801 'config', 'gitcl.remotebranch'],), CERR1),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000802 ] + ([
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000803 # Call to GetRemoteBranch()
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000804 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000805 'config', 'branch.%s.merge' % working_branch],),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000806 'refs/heads/master'),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000807 ((['git',
bratell@opera.comf267b0e2013-05-02 09:11:43 +0000808 'config', 'branch.%s.remote' % working_branch],), 'origin'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000809 ] if get_remote_branch else []) + [
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000810 ((['git', 'rev-list', '^' + fake_ancestor,
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000811 'refs/remotes/origin/master'],), ''),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000812 ]
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000813
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000814 @classmethod
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000815 def _gerrit_ensure_auth_calls(
816 cls, issue=None, skip_auth_check=False, short_hostname='chromium'):
shinyak@chromium.org00dbccd2016-04-15 07:24:43 +0000817 cmd = ['git', 'config', '--bool', 'gerrit.skip-ensure-authenticated']
tandrii@chromium.org28253532016-04-14 13:46:56 +0000818 if skip_auth_check:
819 return [((cmd, ), 'true')]
820
tandrii5d48c322016-08-18 16:19:37 -0700821 calls = [((cmd, ), CERR1)]
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000822 calls.extend([
823 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
824 ((['git', 'config', 'branch.master.remote'],), 'origin'),
825 ((['git', 'config', 'remote.origin.url'],),
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000826 'https://%s.googlesource.com/my/repo' % short_hostname),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000827 ])
Daniel Chengcf6269b2019-05-18 01:02:12 +0000828 if issue:
829 calls.extend([
830 ((['git', 'config', 'branch.master.gerritserver'],), CERR1),
831 ])
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000832 return calls
833
834 @classmethod
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100835 def _gerrit_base_calls(cls, issue=None, fetched_description=None,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200836 fetched_status=None, other_cl_owner=None,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000837 custom_cl_base=None, short_hostname='chromium'):
Aaron Gable13101a62018-02-09 13:20:41 -0800838 calls = cls._is_gerrit_calls(True)
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100839 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200840 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200841 ((['git', 'config', 'branch.master.gerritissue'],),
842 CERR1 if issue is None else str(issue)),
843 ]
844
845 if custom_cl_base:
846 ancestor_revision = custom_cl_base
847 else:
848 # Determine ancestor_revision to be merge base.
849 ancestor_revision = 'fake_ancestor_sha'
850 calls += [
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000851 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
bratell@opera.com82b91cd2013-07-09 06:33:41 +0000852 ((['git', 'config', 'branch.master.remote'],), 'origin'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000853 ((['get_or_create_merge_base', 'master',
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200854 'refs/remotes/origin/master'],), ancestor_revision),
855 ]
856
857 # Calls to verify branch point is ancestor
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000858 calls += cls._gerrit_ensure_auth_calls(
859 issue=issue, short_hostname=short_hostname)
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100860
861 if issue:
862 calls += [
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000863 (('GetChangeDetail', '%s-review.googlesource.com' % short_hostname,
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +0000864 'my%2Frepo~123456',
Andrii Shyshkalovc4a73562018-09-25 18:40:17 +0000865 ['DETAILED_ACCOUNTS', 'CURRENT_REVISION', 'CURRENT_COMMIT', 'LABELS']
866 ),
Andrii Shyshkalov3e631422017-02-16 17:46:44 +0100867 {
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100868 'owner': {'email': (other_cl_owner or 'owner@example.com')},
Andrii Shyshkalov3e631422017-02-16 17:46:44 +0100869 'change_id': '123456789',
870 'current_revision': 'sha1_of_current_revision',
871 'revisions': { 'sha1_of_current_revision': {
872 'commit': {'message': fetched_description},
873 }},
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100874 'status': fetched_status or 'NEW',
Andrii Shyshkalov3e631422017-02-16 17:46:44 +0100875 }),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100876 ]
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100877 if fetched_status == 'ABANDONED':
878 calls += [
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000879 (('DieWithError', 'Change https://%s-review.googlesource.com/'
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100880 '123456 has been abandoned, new uploads are not '
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000881 'allowed' % short_hostname), SystemExitMock()),
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +0100882 ]
883 return calls
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +0100884 if other_cl_owner:
885 calls += [
886 (('ask_for_data', 'Press Enter to upload, or Ctrl+C to abort'), ''),
887 ]
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100888
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200889 calls += cls._git_sanity_checks(ancestor_revision, 'master',
890 get_remote_branch=False)
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100891 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200892 ((['git', 'rev-parse', '--show-cdup'],), ''),
893 ((['git', 'rev-parse', 'HEAD'],), '12345'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +0000894
Aaron Gable7817f022017-12-12 09:43:17 -0800895 ((['git', '-c', 'core.quotePath=false', 'diff', '--name-status',
896 '--no-renames', '-r', ancestor_revision + '...', '.'],),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200897 'M\t.gitignore\n'),
898 ((['git', 'config', 'branch.master.gerritpatchset'],), CERR1),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100899 ]
900
901 if not issue:
902 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200903 ((['git', 'log', '--pretty=format:%s%n%n%b',
904 ancestor_revision + '...'],),
ilevy@chromium.org0f58fa82012-11-05 01:45:20 +0000905 'foo'),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100906 ]
907
908 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200909 ((['git', 'config', 'user.email'],), 'me@example.com'),
Edward Lemur2c48f242019-06-04 16:14:09 +0000910 (('time.time',), 1000,),
911 (('time.time',), 3000,),
912 (('add_repeated', 'sub_commands', {
913 'execution_time': 2000,
914 'command': 'presubmit',
915 'exit_code': 0
916 }), None,),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200917 ((['git', 'diff', '--no-ext-diff', '--stat', '-l100000', '-C50'] +
918 ([custom_cl_base] if custom_cl_base else
919 [ancestor_revision, 'HEAD']),),
920 '+dat'),
Andrii Shyshkalov02939562017-02-16 17:47:17 +0100921 ]
922 return calls
ukai@chromium.orge8077812012-02-03 03:41:46 +0000923
tandrii@chromium.org1e67bb72016-02-11 12:15:49 +0000924 @classmethod
925 def _gerrit_upload_calls(cls, description, reviewers, squash,
tandriia60502f2016-06-20 02:01:53 -0700926 squash_mode='default',
tandrii@chromium.org10625002016-03-04 20:03:47 +0000927 expected_upstream_ref='origin/refs/heads/master',
Aaron Gablefd238082017-06-07 13:42:34 -0700928 title=None, notify=False,
Andrii Shyshkalove9c78ff2017-02-06 15:53:13 +0100929 post_amend_description=None, issue=None, cc=None,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +0000930 custom_cl_base=None, tbr=None,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +0000931 short_hostname='chromium',
Edward Lemur1b52d872019-05-09 21:12:12 +0000932 labels=None, change_id=None, original_title=None,
933 final_description=None, gitcookies_exists=True):
tandrii@chromium.org10625002016-03-04 20:03:47 +0000934 if post_amend_description is None:
935 post_amend_description = description
bradnelsond975b302016-10-23 12:20:23 -0700936 cc = cc or []
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200937 # Determined in `_gerrit_base_calls`.
938 determined_ancestor_revision = custom_cl_base or 'fake_ancestor_sha'
939
940 calls = []
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000941
tandriia60502f2016-06-20 02:01:53 -0700942 if squash_mode == 'default':
943 calls.extend([
944 ((['git', 'config', '--bool', 'gerrit.override-squash-uploads'],), ''),
945 ((['git', 'config', '--bool', 'gerrit.squash-uploads'],), ''),
946 ])
947 elif squash_mode in ('override_squash', 'override_nosquash'):
948 calls.extend([
949 ((['git', 'config', '--bool', 'gerrit.override-squash-uploads'],),
950 'true' if squash_mode == 'override_squash' else 'false'),
951 ])
952 else:
953 assert squash_mode in ('squash', 'nosquash')
954
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000955 # If issue is given, then description is fetched from Gerrit instead.
956 if issue is None:
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000957 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200958 ((['git', 'log', '--pretty=format:%s\n\n%b',
959 ((custom_cl_base + '..') if custom_cl_base else
960 'fake_ancestor_sha..HEAD')],),
961 description),
962 ]
Aaron Gableb56ad332017-01-06 15:24:31 -0800963 if squash:
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +0000964 title = 'Initial_upload'
Aaron Gableb56ad332017-01-06 15:24:31 -0800965 else:
966 if not title:
967 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200968 ((['git', 'show', '-s', '--format=%s', 'HEAD'],), ''),
969 (('ask_for_data', 'Title for patchset []: '), 'User input'),
Aaron Gableb56ad332017-01-06 15:24:31 -0800970 ]
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +0000971 title = 'User_input'
tandrii@chromium.org57d86542016-03-04 16:11:32 +0000972 if not git_footers.get_footer_change_id(description) and not squash:
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +0000973 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200974 (('DownloadGerritHook', False), ''),
975 # Amending of commit message to get the Change-Id.
976 ((['git', 'log', '--pretty=format:%s\n\n%b',
977 determined_ancestor_revision + '..HEAD'],),
978 description),
979 ((['git', 'commit', '--amend', '-m', description],), ''),
980 ((['git', 'log', '--pretty=format:%s\n\n%b',
981 determined_ancestor_revision + '..HEAD'],),
982 post_amend_description)
983 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000984 if squash:
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000985 if not issue:
986 # Prompting to edit description on first upload.
987 calls += [
Jonas Termansend0f79112019-03-22 15:28:26 +0000988 ((['git', 'config', 'rietveld.bug-prefix'],), ''),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200989 ((['git', 'config', 'core.editor'],), ''),
990 ((['RunEditor'],), description),
tandrii@chromium.org512d79c2016-03-31 12:55:28 +0000991 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +0000992 ref_to_push = 'abcdef0123456789'
993 calls += [
Andrii Shyshkalov550e9242017-04-12 17:14:49 +0200994 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
995 ((['git', 'config', 'branch.master.remote'],), 'origin'),
996 ]
997
998 if custom_cl_base is None:
999 calls += [
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001000 ((['get_or_create_merge_base', 'master',
1001 'refs/remotes/origin/master'],),
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001002 'origin/master'),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001003 ]
1004 parent = 'origin/master'
1005 else:
1006 calls += [
1007 ((['git', 'merge-base', '--is-ancestor', custom_cl_base,
1008 'refs/remotes/origin/master'],),
1009 callError(1)), # Means not ancenstor.
1010 (('ask_for_data',
1011 'Do you take responsibility for cleaning up potential mess '
1012 'resulting from proceeding with upload? Press Enter to upload, '
1013 'or Ctrl+C to abort'), ''),
1014 ]
1015 parent = custom_cl_base
1016
1017 calls += [
1018 ((['git', 'rev-parse', 'HEAD:'],), # `HEAD:` means HEAD's tree hash.
1019 '0123456789abcdef'),
1020 ((['git', 'commit-tree', '0123456789abcdef', '-p', parent,
Aaron Gable9a03ae02017-11-03 11:31:07 -07001021 '-F', '/tmp/named'],),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001022 ref_to_push),
1023 ]
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001024 else:
1025 ref_to_push = 'HEAD'
1026
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001027 calls += [
Andrii Shyshkalovd9fdc1f2018-09-27 02:13:09 +00001028 (('SaveDescriptionBackup',), None),
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001029 ((['git', 'rev-list',
1030 (custom_cl_base if custom_cl_base else expected_upstream_ref) + '..' +
1031 ref_to_push],),
1032 '1hashPerLine\n'),
1033 ]
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001034
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001035 metrics_arguments = []
1036
Aaron Gableafd52772017-06-27 16:40:10 -07001037 if notify:
Aaron Gable844cf292017-06-28 11:32:59 -07001038 ref_suffix = '%ready,notify=ALL'
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001039 metrics_arguments += ['ready', 'notify=ALL']
Aaron Gable844cf292017-06-28 11:32:59 -07001040 else:
Jamie Madill276da0b2018-04-27 14:41:20 -04001041 if not issue and squash:
Aaron Gable844cf292017-06-28 11:32:59 -07001042 ref_suffix = '%wip'
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001043 metrics_arguments.append('wip')
Aaron Gable844cf292017-06-28 11:32:59 -07001044 else:
1045 ref_suffix = '%notify=NONE'
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001046 metrics_arguments.append('notify=NONE')
Aaron Gable9b713dd2016-12-14 16:04:21 -08001047
Aaron Gable70f4e242017-06-26 10:45:59 -07001048 if title:
Aaron Gableafd52772017-06-27 16:40:10 -07001049 ref_suffix += ',m=' + title
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001050 metrics_arguments.append('m')
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001051
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00001052 calls += [
Andrii Shyshkalovba7b0a42018-10-15 03:20:35 +00001053 ((['git', 'config', 'rietveld.cc'],), ''),
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00001054 ]
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001055 if short_hostname == 'chromium':
1056 # All reviwers and ccs get into ref_suffix.
1057 for r in sorted(reviewers):
1058 ref_suffix += ',r=%s' % r
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001059 metrics_arguments.append('r')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001060 for c in sorted(['chromium-reviews+test-more-cc@chromium.org',
1061 'joe@example.com'] + cc):
1062 ref_suffix += ',cc=%s' % c
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001063 metrics_arguments.append('cc')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001064 reviewers, cc = [], []
1065 else:
1066 # TODO(crbug/877717): remove this case.
1067 calls += [
1068 (('ValidAccounts', '%s-review.googlesource.com' % short_hostname,
1069 sorted(reviewers) + ['joe@example.com',
1070 'chromium-reviews+test-more-cc@chromium.org'] + cc),
1071 {
1072 e: {'email': e}
1073 for e in (reviewers + ['joe@example.com'] + cc)
1074 })
1075 ]
1076 for r in sorted(reviewers):
1077 if r != 'bad-account-or-email':
1078 ref_suffix += ',r=%s' % r
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001079 metrics_arguments.append('r')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001080 reviewers.remove(r)
1081 for c in sorted(['joe@example.com'] + cc):
1082 ref_suffix += ',cc=%s' % c
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001083 metrics_arguments.append('cc')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001084 if c in cc:
1085 cc.remove(c)
Andrii Shyshkalov76988a82018-10-15 03:12:25 +00001086
Edward Lemur687ca902018-12-05 02:30:30 +00001087 for k, v in sorted((labels or {}).items()):
1088 ref_suffix += ',l=%s+%d' % (k, v)
1089 metrics_arguments.append('l=%s+%d' % (k, v))
1090
1091 if tbr:
1092 calls += [
1093 (('GetCodeReviewTbrScore',
1094 '%s-review.googlesource.com' % short_hostname,
1095 'my/repo'),
1096 2,),
1097 ]
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001098
Edward Lemur01f4a4f2018-11-03 00:40:38 +00001099 calls += [
1100 (('time.time',), 1000,),
1101 ((['git', 'push',
1102 'https://%s.googlesource.com/my/repo' % short_hostname,
1103 ref_to_push + ':refs/for/refs/heads/master' + ref_suffix],),
1104 (('remote:\n'
1105 'remote: Processing changes: (\)\n'
1106 'remote: Processing changes: (|)\n'
1107 'remote: Processing changes: (/)\n'
1108 'remote: Processing changes: (-)\n'
1109 'remote: Processing changes: new: 1 (/)\n'
1110 'remote: Processing changes: new: 1, done\n'
1111 'remote:\n'
1112 'remote: New Changes:\n'
1113 'remote: https://%s-review.googlesource.com/#/c/my/repo/+/123456'
1114 ' XXX\n'
1115 'remote:\n'
1116 'To https://%s.googlesource.com/my/repo\n'
1117 ' * [new branch] hhhh -> refs/for/refs/heads/master\n'
1118 ) % (short_hostname, short_hostname)),),
1119 (('time.time',), 2000,),
1120 (('add_repeated',
1121 'sub_commands',
1122 {
1123 'execution_time': 1000,
1124 'command': 'git push',
1125 'exit_code': 0,
1126 'arguments': sorted(metrics_arguments),
1127 }),
1128 None,),
1129 ]
1130
Edward Lemur1b52d872019-05-09 21:12:12 +00001131 final_description = final_description or post_amend_description.strip()
1132 original_title = original_title or title or '<untitled>'
1133 # Trace-related calls
1134 calls += [
1135 # Write a description with context for the current trace.
1136 ((['FileWrite', 'TRACES_DIR/20170316T200041.000000-README',
Edward Lemur75391d42019-05-14 23:35:56 +00001137 'Thu Mar 16 20:00:41 2017\n'
1138 '%(short_hostname)s-review.googlesource.com\n'
1139 '%(change_id)s\n'
1140 '%(title)s\n'
1141 '%(description)s\n'
1142 '1000\n'
1143 '0\n'
1144 '%(trace_name)s' % {
Edward Lemur1b52d872019-05-09 21:12:12 +00001145 'short_hostname': short_hostname,
1146 'change_id': change_id,
1147 'description': final_description,
1148 'title': original_title,
Edward Lemur75391d42019-05-14 23:35:56 +00001149 'trace_name': 'TRACES_DIR/20170316T200041.000000',
Edward Lemur1b52d872019-05-09 21:12:12 +00001150 }],),
1151 None,
1152 ),
1153 # Read traces and shorten git hashes.
1154 ((['os.path.isfile', 'TEMP_DIR/trace-packet'],),
1155 True,
1156 ),
1157 ((['FileRead', 'TEMP_DIR/trace-packet'],),
1158 ('git-hash: 0123456789012345678901234567890123456789\n'
1159 'git-hash: abcdeabcdeabcdeabcdeabcdeabcdeabcdeabcde\n'),
1160 ),
1161 ((['FileWrite', 'TEMP_DIR/trace-packet',
1162 'git-hash: 012345\n'
1163 'git-hash: abcdea\n'],),
1164 None,
1165 ),
1166 # Make zip file for the git traces.
1167 ((['make_archive', 'TRACES_DIR/20170316T200041.000000-traces', 'zip',
1168 'TEMP_DIR'],),
1169 None,
1170 ),
1171 # Collect git config and gitcookies.
1172 ((['git', 'config', '-l'],),
1173 'git-config-output',
1174 ),
1175 ((['FileWrite', 'TEMP_DIR/git-config', 'git-config-output'],),
1176 None,
1177 ),
1178 ((['os.path.isfile', '~/.gitcookies'],),
1179 gitcookies_exists,
1180 ),
1181 ]
1182 if gitcookies_exists:
1183 calls += [
1184 ((['FileRead', '~/.gitcookies'],),
1185 'gitcookies 1/SECRET',
1186 ),
1187 ((['FileWrite', 'TEMP_DIR/gitcookies', 'gitcookies REDACTED'],),
1188 None,
1189 ),
1190 ]
1191 calls += [
1192 # Make zip file for the git config and gitcookies.
1193 ((['make_archive', 'TRACES_DIR/20170316T200041.000000-git-info', 'zip',
1194 'TEMP_DIR'],),
1195 None,
1196 ),
1197 ]
1198
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001199 if squash:
1200 calls += [
tandrii33a46ff2016-08-23 05:53:40 -07001201 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
tandrii5d48c322016-08-18 16:19:37 -07001202 ''),
tandrii@chromium.orgaa5ced12016-03-29 09:41:14 +00001203 ((['git', 'config', 'branch.master.gerritserver',
tandrii5d48c322016-08-18 16:19:37 -07001204 'https://chromium-review.googlesource.com'],), ''),
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001205 ((['git', 'config', 'branch.master.gerritsquashhash',
1206 'abcdef0123456789'],), ''),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001207 ]
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001208 # TODO(crbug/877717): this should never be used.
1209 if squash and short_hostname != 'chromium':
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001210 calls += [
1211 (('AddReviewers',
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00001212 'chromium-review.googlesource.com', 'my%2Frepo~123456',
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001213 sorted(reviewers),
Andrii Shyshkalov2f727912018-10-15 17:02:33 +00001214 cc + ['chromium-reviews+test-more-cc@chromium.org'],
1215 notify),
1216 ''),
Andrii Shyshkalov0ec9d152018-08-23 00:22:58 +00001217 ]
tandrii@chromium.org1e67bb72016-02-11 12:15:49 +00001218 calls += cls._git_post_upload_calls()
ukai@chromium.orge8077812012-02-03 03:41:46 +00001219 return calls
1220
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001221 def _run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001222 self,
1223 upload_args,
1224 description,
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00001225 reviewers=None,
tandriia60502f2016-06-20 02:01:53 -07001226 squash=True,
1227 squash_mode=None,
tandrii@chromium.org10625002016-03-04 20:03:47 +00001228 expected_upstream_ref='origin/refs/heads/master',
Aaron Gable9b713dd2016-12-14 16:04:21 -08001229 title=None,
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001230 notify=False,
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001231 post_amend_description=None,
bradnelsond975b302016-10-23 12:20:23 -07001232 issue=None,
Andrii Shyshkalove9c78ff2017-02-06 15:53:13 +01001233 cc=None,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001234 fetched_status=None,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001235 other_cl_owner=None,
Aaron Gablefd238082017-06-07 13:42:34 -07001236 custom_cl_base=None,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001237 tbr=None,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001238 short_hostname='chromium',
Edward Lemur1b52d872019-05-09 21:12:12 +00001239 labels=None,
1240 change_id=None,
1241 original_title=None,
1242 final_description=None,
1243 gitcookies_exists=True):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001244 """Generic gerrit upload test framework."""
tandriia60502f2016-06-20 02:01:53 -07001245 if squash_mode is None:
1246 if '--no-squash' in upload_args:
1247 squash_mode = 'nosquash'
1248 elif '--squash' in upload_args:
1249 squash_mode = 'squash'
1250 else:
1251 squash_mode = 'default'
1252
tandrii@chromium.orgbf766ba2016-04-13 12:51:23 +00001253 reviewers = reviewers or []
bradnelsond975b302016-10-23 12:20:23 -07001254 cc = cc or []
tandrii@chromium.org28253532016-04-14 13:46:56 +00001255 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
tandrii16e0b4e2016-06-07 10:34:28 -07001256 self.mock(git_cl.gerrit_util, 'CookiesAuthenticator',
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001257 CookiesAuthenticatorMockFactory(
1258 same_auth=('git-owner.example.com', '', 'pass')))
tandrii16e0b4e2016-06-07 10:34:28 -07001259 self.mock(git_cl._GerritChangelistImpl, '_GerritCommitMsgHookCheck',
1260 lambda _, offer_removal: None)
tandriia60502f2016-06-20 02:01:53 -07001261 self.mock(git_cl.gclient_utils, 'RunEditor',
1262 lambda *_, **__: self._mocked_call(['RunEditor']))
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001263 self.mock(git_cl, 'DownloadGerritHook', lambda force: self._mocked_call(
1264 'DownloadGerritHook', force))
Edward Lemur1b52d872019-05-09 21:12:12 +00001265 self.mock(git_cl.gclient_utils, 'FileRead',
1266 lambda path: self._mocked_call(['FileRead', path]))
1267 self.mock(git_cl.gclient_utils, 'FileWrite',
1268 lambda path, contents: self._mocked_call(
1269 ['FileWrite', path, contents]))
1270 self.mock(git_cl, 'datetime_now',
1271 lambda: datetime.datetime(2017, 3, 16, 20, 0, 41, 0))
1272 self.mock(git_cl.tempfile, 'mkdtemp', lambda: 'TEMP_DIR')
1273 self.mock(git_cl, 'TRACES_DIR', 'TRACES_DIR')
Edward Lemur75391d42019-05-14 23:35:56 +00001274 self.mock(git_cl, 'TRACES_README_FORMAT',
1275 '%(now)s\n'
1276 '%(gerrit_host)s\n'
1277 '%(change_id)s\n'
1278 '%(title)s\n'
1279 '%(description)s\n'
1280 '%(execution_time)s\n'
1281 '%(exit_code)s\n'
1282 '%(trace_name)s')
Edward Lemur1b52d872019-05-09 21:12:12 +00001283 self.mock(git_cl.shutil, 'make_archive',
1284 lambda *args: self._mocked_call(['make_archive'] + list(args)))
1285 self.mock(os.path, 'isfile',
1286 lambda path: self._mocked_call(['os.path.isfile', path]))
tandriia60502f2016-06-20 02:01:53 -07001287
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001288 self.calls = self._gerrit_base_calls(
1289 issue=issue,
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001290 fetched_description=description,
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001291 fetched_status=fetched_status,
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001292 other_cl_owner=other_cl_owner,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001293 custom_cl_base=custom_cl_base,
1294 short_hostname=short_hostname)
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001295 if fetched_status != 'ABANDONED':
Aaron Gable9a03ae02017-11-03 11:31:07 -07001296 self.mock(tempfile, 'NamedTemporaryFile', MakeNamedTemporaryFileMock(
1297 expected_content=description))
1298 self.mock(os, 'remove', lambda _: True)
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001299 self.calls += self._gerrit_upload_calls(
1300 description, reviewers, squash,
1301 squash_mode=squash_mode,
1302 expected_upstream_ref=expected_upstream_ref,
Aaron Gablefd238082017-06-07 13:42:34 -07001303 title=title, notify=notify,
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001304 post_amend_description=post_amend_description,
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00001305 issue=issue, cc=cc,
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001306 custom_cl_base=custom_cl_base, tbr=tbr,
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001307 short_hostname=short_hostname,
Edward Lemur1b52d872019-05-09 21:12:12 +00001308 labels=labels,
1309 change_id=change_id,
1310 original_title=original_title,
1311 final_description=final_description,
1312 gitcookies_exists=gitcookies_exists)
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +00001313 # Uncomment when debugging.
Raul Tambre80ee78e2019-05-06 22:41:05 +00001314 # print('\n'.join(map(lambda x: '%2i: %s' % x, enumerate(self.calls))))
ukai@chromium.orge8077812012-02-03 03:41:46 +00001315 git_cl.main(['upload'] + upload_args)
1316
Edward Lemur1b52d872019-05-09 21:12:12 +00001317 def test_gerrit_upload_traces_no_gitcookies(self):
1318 self._run_gerrit_upload_test(
1319 ['--no-squash'],
1320 'desc\n\nBUG=\n',
1321 [],
1322 squash=False,
1323 post_amend_description='desc\n\nBUG=\n\nChange-Id: Ixxx',
1324 change_id='Ixxx',
1325 gitcookies_exists=False)
1326
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001327 def test_gerrit_upload_without_change_id(self):
tandriia60502f2016-06-20 02:01:53 -07001328 self._run_gerrit_upload_test(
1329 ['--no-squash'],
1330 'desc\n\nBUG=\n',
1331 [],
1332 squash=False,
Edward Lemur1b52d872019-05-09 21:12:12 +00001333 post_amend_description='desc\n\nBUG=\n\nChange-Id: Ixxx',
1334 change_id='Ixxx')
tandriia60502f2016-06-20 02:01:53 -07001335
1336 def test_gerrit_upload_without_change_id_override_nosquash(self):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001337 self._run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001338 [],
jamesr@chromium.org35d1a842012-07-27 00:20:43 +00001339 'desc\n\nBUG=\n',
tandrii@chromium.org10625002016-03-04 20:03:47 +00001340 [],
tandriia60502f2016-06-20 02:01:53 -07001341 squash=False,
1342 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001343 post_amend_description='desc\n\nBUG=\n\nChange-Id: Ixxx',
1344 change_id='Ixxx')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001345
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001346 def test_gerrit_no_reviewer(self):
1347 self._run_gerrit_upload_test(
1348 [],
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +00001349 'desc\n\nBUG=\n\nChange-Id: I123456789\n',
tandriia60502f2016-06-20 02:01:53 -07001350 [],
1351 squash=False,
Edward Lemur1b52d872019-05-09 21:12:12 +00001352 squash_mode='override_nosquash',
1353 change_id='I123456789')
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001354
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001355 def test_gerrit_no_reviewer_non_chromium_host(self):
1356 # TODO(crbug/877717): remove this test case.
1357 self._run_gerrit_upload_test(
1358 [],
1359 'desc\n\nBUG=\n\nChange-Id: I123456789\n',
1360 [],
1361 squash=False,
1362 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001363 short_hostname='other',
1364 change_id='I123456789')
Andrii Shyshkalov0da5e8f2018-10-30 17:29:18 +00001365
Nick Carter8692b182017-11-06 16:30:38 -08001366 def test_gerrit_patchset_title_special_chars(self):
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001367 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
1368 self._run_gerrit_upload_test(
Nick Carter8692b182017-11-06 16:30:38 -08001369 ['-f', '-t', 'We\'ll escape ^_ ^ special chars...@{u}'],
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001370 'desc\n\nBUG=\n\nChange-Id: I123456789',
1371 squash=False,
1372 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001373 title='We%27ll_escape_%5E%5F_%5E_special_chars%2E%2E%2E%40%7Bu%7D',
1374 change_id='I123456789',
1375 original_title='We\'ll escape ^_ ^ special chars...@{u}')
Andrii Shyshkalovfebbae92017-04-05 15:05:20 +00001376
ukai@chromium.orge8077812012-02-03 03:41:46 +00001377 def test_gerrit_reviewers_cmd_line(self):
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001378 self._run_gerrit_upload_test(
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001379 ['-r', 'foo@example.com', '--send-mail'],
tandrii@chromium.org09d7a6a2016-03-04 15:44:48 +00001380 'desc\n\nBUG=\n\nChange-Id: I123456789',
tandrii@chromium.org8da45402016-05-24 23:11:03 +00001381 ['foo@example.com'],
tandriia60502f2016-06-20 02:01:53 -07001382 squash=False,
1383 squash_mode='override_nosquash',
Edward Lemur1b52d872019-05-09 21:12:12 +00001384 notify=True,
1385 change_id='I123456789',
1386 final_description=
1387 'desc\n\nBUG=\nR=foo@example.com\n\nChange-Id: I123456789')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001388
1389 def test_gerrit_reviewer_multiple(self):
Edward Lemur687ca902018-12-05 02:30:30 +00001390 self.mock(git_cl.gerrit_util, 'GetCodeReviewTbrScore',
1391 lambda *a: self._mocked_call('GetCodeReviewTbrScore', *a))
sivachandra@chromium.orgaebe87f2012-10-22 20:34:21 +00001392 self._run_gerrit_upload_test(
ukai@chromium.orge8077812012-02-03 03:41:46 +00001393 [],
bradnelsond975b302016-10-23 12:20:23 -07001394 'desc\nTBR=reviewer@example.com\nBUG=\nR=another@example.com\n'
1395 'CC=more@example.com,people@example.com\n\n'
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +09001396 'Change-Id: 123456789',
tandriia60502f2016-06-20 02:01:53 -07001397 ['reviewer@example.com', 'another@example.com'],
Yoshisato Yanagisawa81e3ff52017-09-26 15:33:34 +09001398 expected_upstream_ref='origin/master',
Aaron Gablefd238082017-06-07 13:42:34 -07001399 cc=['more@example.com', 'people@example.com'],
Edward Lemur687ca902018-12-05 02:30:30 +00001400 tbr='reviewer@example.com',
Edward Lemur1b52d872019-05-09 21:12:12 +00001401 labels={'Code-Review': 2},
1402 change_id='123456789',
1403 original_title='Initial upload')
tandriia60502f2016-06-20 02:01:53 -07001404
1405 def test_gerrit_upload_squash_first_is_default(self):
tandriia60502f2016-06-20 02:01:53 -07001406 self._run_gerrit_upload_test(
1407 [],
1408 'desc\nBUG=\n\nChange-Id: 123456789',
1409 [],
Edward Lemur1b52d872019-05-09 21:12:12 +00001410 expected_upstream_ref='origin/master',
1411 change_id='123456789',
1412 original_title='Initial upload')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001413
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001414 def test_gerrit_upload_squash_first(self):
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001415 self._run_gerrit_upload_test(
1416 ['--squash'],
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001417 'desc\nBUG=\n\nChange-Id: 123456789',
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001418 [],
luqui@chromium.org609f3952015-05-04 22:47:04 +00001419 squash=True,
Edward Lemur1b52d872019-05-09 21:12:12 +00001420 expected_upstream_ref='origin/master',
1421 change_id='123456789',
1422 original_title='Initial upload')
ukai@chromium.orge8077812012-02-03 03:41:46 +00001423
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001424 def test_gerrit_upload_squash_first_with_labels(self):
1425 self._run_gerrit_upload_test(
1426 ['--squash', '--cq-dry-run', '--enable-auto-submit'],
1427 'desc\nBUG=\n\nChange-Id: 123456789',
1428 [],
1429 squash=True,
1430 expected_upstream_ref='origin/master',
Edward Lemur1b52d872019-05-09 21:12:12 +00001431 labels={'Commit-Queue': 1, 'Auto-Submit': 1},
1432 change_id='123456789',
1433 original_title='Initial upload')
Andrii Shyshkalove7a7fc42018-10-30 17:35:09 +00001434
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001435 def test_gerrit_upload_squash_first_against_rev(self):
1436 custom_cl_base = 'custom_cl_base_rev_or_branch'
1437 self._run_gerrit_upload_test(
1438 ['--squash', custom_cl_base],
1439 'desc\nBUG=\n\nChange-Id: 123456789',
1440 [],
1441 squash=True,
1442 expected_upstream_ref='origin/master',
Edward Lemur1b52d872019-05-09 21:12:12 +00001443 custom_cl_base=custom_cl_base,
1444 change_id='123456789',
1445 original_title='Initial upload')
Andrii Shyshkalov550e9242017-04-12 17:14:49 +02001446 self.assertIn(
1447 'If you proceed with upload, more than 1 CL may be created by Gerrit',
1448 sys.stdout.getvalue())
1449
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001450 def test_gerrit_upload_squash_reupload(self):
1451 description = 'desc\nBUG=\n\nChange-Id: 123456789'
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001452 self._run_gerrit_upload_test(
1453 ['--squash'],
1454 description,
1455 [],
1456 squash=True,
1457 expected_upstream_ref='origin/master',
Edward Lemur1b52d872019-05-09 21:12:12 +00001458 issue=123456,
1459 change_id='123456789',
1460 original_title='User input')
tandrii@chromium.org512d79c2016-03-31 12:55:28 +00001461
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001462 def test_gerrit_upload_squash_reupload_to_abandoned(self):
1463 self.mock(git_cl, 'DieWithError',
1464 lambda msg, change=None: self._mocked_call('DieWithError', msg))
1465 description = 'desc\nBUG=\n\nChange-Id: 123456789'
1466 with self.assertRaises(SystemExitMock):
1467 self._run_gerrit_upload_test(
1468 ['--squash'],
1469 description,
1470 [],
1471 squash=True,
1472 expected_upstream_ref='origin/master',
1473 issue=123456,
Edward Lemur1b52d872019-05-09 21:12:12 +00001474 fetched_status='ABANDONED',
1475 change_id='123456789')
Andrii Shyshkalov5c3d0b32017-02-16 17:47:31 +01001476
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001477 def test_gerrit_upload_squash_reupload_to_not_owned(self):
1478 self.mock(git_cl.gerrit_util, 'GetAccountDetails',
1479 lambda *_, **__: {'email': 'yet-another@example.com'})
1480 description = 'desc\nBUG=\n\nChange-Id: 123456789'
1481 self._run_gerrit_upload_test(
1482 ['--squash'],
1483 description,
1484 [],
1485 squash=True,
1486 expected_upstream_ref='origin/master',
1487 issue=123456,
Edward Lemur1b52d872019-05-09 21:12:12 +00001488 other_cl_owner='other@example.com',
1489 change_id='123456789',
1490 original_title='User input')
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001491 self.assertIn(
Quinten Yearsley0c62da92017-05-31 13:39:42 -07001492 'WARNING: Change 123456 is owned by other@example.com, but you '
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001493 'authenticate to Gerrit as yet-another@example.com.\n'
1494 'Uploading may fail due to lack of permissions',
1495 git_cl.sys.stdout.getvalue())
1496
rmistry@google.com2dd99862015-06-22 12:22:18 +00001497 def test_upload_branch_deps(self):
tandrii@chromium.org28253532016-04-14 13:46:56 +00001498 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
rmistry@google.com2dd99862015-06-22 12:22:18 +00001499 def mock_run_git(*args, **_kwargs):
1500 if args[0] == ['for-each-ref',
1501 '--format=%(refname:short) %(upstream:short)',
1502 'refs/heads']:
1503 # Create a local branch dependency tree that looks like this:
1504 # test1 -> test2 -> test3 -> test4 -> test5
1505 # -> test3.1
1506 # test6 -> test0
1507 branch_deps = [
1508 'test2 test1', # test1 -> test2
1509 'test3 test2', # test2 -> test3
1510 'test3.1 test2', # test2 -> test3.1
1511 'test4 test3', # test3 -> test4
1512 'test5 test4', # test4 -> test5
1513 'test6 test0', # test0 -> test6
1514 'test7', # test7
1515 ]
1516 return '\n'.join(branch_deps)
1517 self.mock(git_cl, 'RunGit', mock_run_git)
1518
1519 class RecordCalls:
1520 times_called = 0
1521 record_calls = RecordCalls()
1522 def mock_CMDupload(*args, **_kwargs):
1523 record_calls.times_called += 1
1524 return 0
1525 self.mock(git_cl, 'CMDupload', mock_CMDupload)
1526
1527 self.calls = [
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01001528 (('ask_for_data', 'This command will checkout all dependent branches '
1529 'and run "git cl upload". Press Enter to continue, '
1530 'or Ctrl+C to abort'), ''),
1531 ]
rmistry@google.com2dd99862015-06-22 12:22:18 +00001532
1533 class MockChangelist():
1534 def __init__(self):
1535 pass
1536 def GetBranch(self):
1537 return 'test1'
1538 def GetIssue(self):
1539 return '123'
1540 def GetPatchset(self):
1541 return '1001'
tandrii@chromium.org4c72b082016-03-31 22:26:35 +00001542 def IsGerrit(self):
1543 return False
rmistry@google.com2dd99862015-06-22 12:22:18 +00001544
1545 ret = git_cl.upload_branch_deps(MockChangelist(), [])
1546 # CMDupload should have been called 5 times because of 5 dependent branches.
1547 self.assertEquals(5, record_calls.times_called)
1548 self.assertEquals(0, ret)
1549
tandrii@chromium.org65874e12016-03-04 12:03:02 +00001550 def test_gerrit_change_id(self):
1551 self.calls = [
1552 ((['git', 'write-tree'], ),
1553 'hashtree'),
1554 ((['git', 'rev-parse', 'HEAD~0'], ),
1555 'branch-parent'),
1556 ((['git', 'var', 'GIT_AUTHOR_IDENT'], ),
1557 'A B <a@b.org> 1456848326 +0100'),
1558 ((['git', 'var', 'GIT_COMMITTER_IDENT'], ),
1559 'C D <c@d.org> 1456858326 +0100'),
1560 ((['git', 'hash-object', '-t', 'commit', '--stdin'], ),
1561 'hashchange'),
1562 ]
1563 change_id = git_cl.GenerateGerritChangeId('line1\nline2\n')
1564 self.assertEqual(change_id, 'Ihashchange')
1565
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00001566 def test_desecription_append_footer(self):
1567 for init_desc, footer_line, expected_desc in [
1568 # Use unique desc first lines for easy test failure identification.
1569 ('foo', 'R=one', 'foo\n\nR=one'),
1570 ('foo\n\nR=one', 'BUG=', 'foo\n\nR=one\nBUG='),
1571 ('foo\n\nR=one', 'Change-Id: Ixx', 'foo\n\nR=one\n\nChange-Id: Ixx'),
1572 ('foo\n\nChange-Id: Ixx', 'R=one', 'foo\n\nR=one\n\nChange-Id: Ixx'),
1573 ('foo\n\nR=one\n\nChange-Id: Ixx', 'TBR=two',
1574 'foo\n\nR=one\nTBR=two\n\nChange-Id: Ixx'),
1575 ('foo\n\nR=one\n\nChange-Id: Ixx', 'Foo-Bar: baz',
1576 'foo\n\nR=one\n\nChange-Id: Ixx\nFoo-Bar: baz'),
1577 ('foo\n\nChange-Id: Ixx', 'Foo-Bak: baz',
1578 'foo\n\nChange-Id: Ixx\nFoo-Bak: baz'),
1579 ('foo', 'Change-Id: Ixx', 'foo\n\nChange-Id: Ixx'),
1580 ]:
1581 desc = git_cl.ChangeDescription(init_desc)
1582 desc.append_footer(footer_line)
1583 self.assertEqual(desc.description, expected_desc)
1584
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001585 def test_update_reviewers(self):
1586 data = [
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001587 ('foo', [], [],
1588 'foo'),
1589 ('foo\nR=xx', [], [],
1590 'foo\nR=xx'),
1591 ('foo\nTBR=xx', [], [],
1592 'foo\nTBR=xx'),
1593 ('foo', ['a@c'], [],
1594 'foo\n\nR=a@c'),
1595 ('foo\nR=xx', ['a@c'], [],
1596 'foo\n\nR=a@c, xx'),
1597 ('foo\nTBR=xx', ['a@c'], [],
1598 'foo\n\nR=a@c\nTBR=xx'),
1599 ('foo\nTBR=xx\nR=yy', ['a@c'], [],
1600 'foo\n\nR=a@c, yy\nTBR=xx'),
1601 ('foo\nBUG=', ['a@c'], [],
1602 'foo\nBUG=\nR=a@c'),
1603 ('foo\nR=xx\nTBR=yy\nR=bar', ['a@c'], [],
1604 'foo\n\nR=a@c, bar, xx\nTBR=yy'),
1605 ('foo', ['a@c', 'b@c'], [],
1606 'foo\n\nR=a@c, b@c'),
1607 ('foo\nBar\n\nR=\nBUG=', ['c@c'], [],
1608 'foo\nBar\n\nR=c@c\nBUG='),
1609 ('foo\nBar\n\nR=\nBUG=\nR=', ['c@c'], [],
1610 'foo\nBar\n\nR=c@c\nBUG='),
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001611 # Same as the line before, but full of whitespaces.
1612 (
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001613 'foo\nBar\n\n R = \n BUG = \n R = ', ['c@c'], [],
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001614 'foo\nBar\n\nR=c@c\n BUG =',
1615 ),
1616 # Whitespaces aren't interpreted as new lines.
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001617 ('foo BUG=allo R=joe ', ['c@c'], [],
1618 'foo BUG=allo R=joe\n\nR=c@c'),
1619 # Redundant TBRs get promoted to Rs
1620 ('foo\n\nR=a@c\nTBR=t@c', ['b@c', 'a@c'], ['a@c', 't@c'],
1621 'foo\n\nR=a@c, b@c\nTBR=t@c'),
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001622 ]
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001623 expected = [i[-1] for i in data]
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001624 actual = []
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001625 for orig, reviewers, tbrs, _expected in data:
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001626 obj = git_cl.ChangeDescription(orig)
Robert Iannucci6c98dc62017-04-18 11:38:00 -07001627 obj.update_reviewers(reviewers, tbrs)
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001628 actual.append(obj.description)
1629 self.assertEqual(expected, actual)
maruel@chromium.org78936cb2013-04-11 00:17:52 +00001630
Nodir Turakulov23b82142017-11-16 11:04:25 -08001631 def test_get_hash_tags(self):
1632 cases = [
1633 ('', []),
1634 ('a', []),
1635 ('[a]', ['a']),
1636 ('[aa]', ['aa']),
1637 ('[a ]', ['a']),
1638 ('[a- ]', ['a']),
1639 ('[a- b]', ['a-b']),
1640 ('[a--b]', ['a-b']),
1641 ('[a', []),
1642 ('[a]x', ['a']),
1643 ('[aa]x', ['aa']),
1644 ('[a b]', ['a-b']),
1645 ('[a b]', ['a-b']),
1646 ('[a__b]', ['a-b']),
1647 ('[a] x', ['a']),
1648 ('[a][b]', ['a', 'b']),
1649 ('[a] [b]', ['a', 'b']),
1650 ('[a][b]x', ['a', 'b']),
1651 ('[a][b] x', ['a', 'b']),
1652 ('[a]\n[b]', ['a']),
1653 ('[a\nb]', []),
1654 ('[a][', ['a']),
1655 ('Revert "[a] feature"', ['a']),
1656 ('Reland "[a] feature"', ['a']),
1657 ('Revert: [a] feature', ['a']),
1658 ('Reland: [a] feature', ['a']),
1659 ('Revert "Reland: [a] feature"', ['a']),
1660 ('Foo: feature', ['foo']),
1661 ('Foo Bar: feature', ['foo-bar']),
1662 ('Revert "Foo bar: feature"', ['foo-bar']),
1663 ('Reland "Foo bar: feature"', ['foo-bar']),
1664 ]
1665 for desc, expected in cases:
1666 change_desc = git_cl.ChangeDescription(desc)
1667 actual = change_desc.get_hash_tags()
1668 self.assertEqual(
1669 actual,
1670 expected,
1671 'GetHashTags(%r) == %r, expected %r' % (desc, actual, expected))
1672
Quinten Yearsley0e617c02019-02-20 00:37:03 +00001673
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001674 self.assertEqual(None, git_cl.GetTargetRef('origin', None, 'master'))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001675 self.assertEqual(None, git_cl.GetTargetRef(None,
1676 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001677 'master'))
bauerb@chromium.org27386dd2015-02-16 10:45:39 +00001678
wittman@chromium.org455dc922015-01-26 20:15:50 +00001679 # Check default target refs for branches.
1680 self.assertEqual('refs/heads/master',
1681 git_cl.GetTargetRef('origin', 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001682 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001683 self.assertEqual('refs/heads/master',
1684 git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkgr',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001685 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001686 self.assertEqual('refs/heads/master',
1687 git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkcr',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001688 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001689 self.assertEqual('refs/branch-heads/123',
1690 git_cl.GetTargetRef('origin',
1691 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001692 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001693 self.assertEqual('refs/diff/test',
1694 git_cl.GetTargetRef('origin',
1695 'refs/remotes/origin/refs/diff/test',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001696 None))
rmistry@google.comc68112d2015-03-03 12:48:06 +00001697 self.assertEqual('refs/heads/chrome/m42',
1698 git_cl.GetTargetRef('origin',
1699 'refs/remotes/origin/chrome/m42',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001700 None))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001701
1702 # Check target refs for user-specified target branch.
1703 for branch in ('branch-heads/123', 'remotes/branch-heads/123',
1704 'refs/remotes/branch-heads/123'):
1705 self.assertEqual('refs/branch-heads/123',
1706 git_cl.GetTargetRef('origin',
1707 'refs/remotes/origin/master',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001708 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001709 for branch in ('origin/master', 'remotes/origin/master',
1710 'refs/remotes/origin/master'):
1711 self.assertEqual('refs/heads/master',
1712 git_cl.GetTargetRef('origin',
1713 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001714 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001715 for branch in ('master', 'heads/master', 'refs/heads/master'):
1716 self.assertEqual('refs/heads/master',
1717 git_cl.GetTargetRef('origin',
1718 'refs/remotes/branch-heads/123',
Andrii Shyshkalovf3a20ae2017-01-24 21:23:57 +01001719 branch))
wittman@chromium.org455dc922015-01-26 20:15:50 +00001720
wychen@chromium.orga872e752015-04-28 23:42:18 +00001721 def test_patch_when_dirty(self):
1722 # Patch when local tree is dirty
1723 self.mock(git_common, 'is_dirty_git_tree', lambda x: True)
1724 self.assertNotEqual(git_cl.main(['patch', '123456']), 0)
1725
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001726 @staticmethod
1727 def _get_gerrit_codereview_server_calls(branch, value=None,
1728 git_short_host='host',
Aaron Gable697a91b2018-01-19 15:20:15 -08001729 detect_branch=True,
1730 detect_server=True):
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001731 """Returns calls executed by _GerritChangelistImpl.GetCodereviewServer.
1732
1733 If value is given, branch.<BRANCH>.gerritcodereview is already set.
1734 """
1735 calls = []
1736 if detect_branch:
1737 calls.append(((['git', 'symbolic-ref', 'HEAD'],), branch))
Aaron Gable697a91b2018-01-19 15:20:15 -08001738 if detect_server:
1739 calls.append(((['git', 'config', 'branch.' + branch + '.gerritserver'],),
1740 CERR1 if value is None else value))
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001741 if value is None:
1742 calls += [
1743 ((['git', 'config', 'branch.' + branch + '.merge'],),
1744 'refs/heads' + branch),
1745 ((['git', 'config', 'branch.' + branch + '.remote'],),
1746 'origin'),
1747 ((['git', 'config', 'remote.origin.url'],),
1748 'https://%s.googlesource.com/my/repo' % git_short_host),
1749 ]
1750 return calls
1751
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001752 def _patch_common(self, force_codereview=False,
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001753 new_branch=False, git_short_host='host',
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001754 detect_gerrit_server=False,
1755 actual_codereview=None,
1756 codereview_in_url=False):
tandrii@chromium.org28253532016-04-14 13:46:56 +00001757 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
wychen@chromium.orga872e752015-04-28 23:42:18 +00001758 self.mock(git_cl, 'IsGitVersionAtLeast', lambda *args: True)
1759
tandriidf09a462016-08-18 16:23:55 -07001760 if new_branch:
1761 self.calls = [((['git', 'new-branch', 'master'],), ''),]
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001762
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001763 if codereview_in_url and actual_codereview == 'rietveld':
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001764 self.calls += [
1765 ((['git', 'rev-parse', '--show-cdup'],), ''),
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001766 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001767 ]
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001768
1769 if not force_codereview and not codereview_in_url:
1770 # These calls detect codereview to use.
1771 self.calls += [
1772 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001773 ((['git', 'config', 'branch.master.gerritissue'],), CERR1),
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001774 ]
1775 if detect_gerrit_server:
1776 self.calls += self._get_gerrit_codereview_server_calls(
1777 'master', git_short_host=git_short_host,
1778 detect_branch=not new_branch and force_codereview)
1779 actual_codereview = 'gerrit'
1780
1781 if actual_codereview == 'gerrit':
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001782 self.calls += [
1783 (('GetChangeDetail', git_short_host + '-review.googlesource.com',
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001784 'my%2Frepo~123456', ['ALL_REVISIONS', 'CURRENT_COMMIT']),
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001785 {
1786 'current_revision': '7777777777',
1787 'revisions': {
1788 '1111111111': {
1789 '_number': 1,
1790 'fetch': {'http': {
1791 'url': 'https://%s.googlesource.com/my/repo' % git_short_host,
1792 'ref': 'refs/changes/56/123456/1',
1793 }},
1794 },
1795 '7777777777': {
1796 '_number': 7,
1797 'fetch': {'http': {
1798 'url': 'https://%s.googlesource.com/my/repo' % git_short_host,
1799 'ref': 'refs/changes/56/123456/7',
1800 }},
1801 },
1802 },
1803 }),
1804 ]
wychen@chromium.orga872e752015-04-28 23:42:18 +00001805
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001806 def test_patch_gerrit_default(self):
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001807 self._patch_common(git_short_host='chromium', detect_gerrit_server=True)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001808 self.calls += [
1809 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
1810 'refs/changes/56/123456/7'],), ''),
Aaron Gable62619a32017-06-16 08:22:09 -07001811 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001812 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
Aaron Gable697a91b2018-01-19 15:20:15 -08001813 ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001814 ((['git', 'config', 'branch.master.gerritserver',
1815 'https://chromium-review.googlesource.com'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001816 ((['git', 'config', 'branch.master.gerritpatchset', '7'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001817 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1818 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1819 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001820 ]
1821 self.assertEqual(git_cl.main(['patch', '123456']), 0)
1822
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001823 def test_patch_gerrit_new_branch(self):
1824 self._patch_common(
1825 git_short_host='chromium', detect_gerrit_server=True, new_branch=True)
1826 self.calls += [
1827 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
1828 'refs/changes/56/123456/7'],), ''),
1829 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
1830 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
1831 ''),
1832 ((['git', 'config', 'branch.master.gerritserver',
1833 'https://chromium-review.googlesource.com'],), ''),
1834 ((['git', 'config', 'branch.master.gerritpatchset', '7'],), ''),
1835 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1836 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1837 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
1838 ]
1839 self.assertEqual(git_cl.main(['patch', '-b', 'master', '123456']), 0)
1840
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001841 def test_patch_gerrit_force(self):
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001842 self._patch_common(
1843 force_codereview=True, git_short_host='host', detect_gerrit_server=True)
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001844 self.calls += [
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001845 ((['git', 'fetch', 'https://host.googlesource.com/my/repo',
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001846 'refs/changes/56/123456/7'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001847 ((['git', 'reset', '--hard', 'FETCH_HEAD'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001848 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
tandrii5d48c322016-08-18 16:19:37 -07001849 ''),
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001850 ((['git', 'config', 'branch.master.gerritserver',
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001851 'https://host-review.googlesource.com'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001852 ((['git', 'config', 'branch.master.gerritpatchset', '7'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001853 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1854 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1855 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001856 ]
Aaron Gable62619a32017-06-16 08:22:09 -07001857 self.assertEqual(git_cl.main(['patch', '--gerrit', '123456', '--force']), 0)
tandrii@chromium.orgdde64622016-04-13 17:11:21 +00001858
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001859 def test_patch_gerrit_guess_by_url(self):
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001860 self.calls += self._get_gerrit_codereview_server_calls(
1861 'master', git_short_host='else', detect_server=False)
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001862 self._patch_common(
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001863 actual_codereview='gerrit', git_short_host='else',
1864 codereview_in_url=True, detect_gerrit_server=False)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001865 self.calls += [
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001866 ((['git', 'fetch', 'https://else.googlesource.com/my/repo',
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001867 'refs/changes/56/123456/1'],), ''),
Aaron Gable62619a32017-06-16 08:22:09 -07001868 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001869 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
tandrii5d48c322016-08-18 16:19:37 -07001870 ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001871 ((['git', 'config', 'branch.master.gerritserver',
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001872 'https://else-review.googlesource.com'],), ''),
tandrii33a46ff2016-08-23 05:53:40 -07001873 ((['git', 'config', 'branch.master.gerritpatchset', '1'],), ''),
Aaron Gable9387b4f2017-06-08 10:50:03 -07001874 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1875 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1876 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001877 ]
1878 self.assertEqual(git_cl.main(
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01001879 ['patch', 'https://else-review.googlesource.com/#/c/123456/1']), 0)
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001880
Aaron Gable697a91b2018-01-19 15:20:15 -08001881 def test_patch_gerrit_guess_by_url_with_repo(self):
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00001882 self.calls += self._get_gerrit_codereview_server_calls(
1883 'master', git_short_host='else', detect_server=False)
Aaron Gable697a91b2018-01-19 15:20:15 -08001884 self._patch_common(
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001885 actual_codereview='gerrit', git_short_host='else',
1886 codereview_in_url=True, detect_gerrit_server=False)
Aaron Gable697a91b2018-01-19 15:20:15 -08001887 self.calls += [
1888 ((['git', 'fetch', 'https://else.googlesource.com/my/repo',
1889 'refs/changes/56/123456/1'],), ''),
1890 ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
1891 ((['git', 'config', 'branch.master.gerritissue', '123456'],),
1892 ''),
1893 ((['git', 'config', 'branch.master.gerritserver',
1894 'https://else-review.googlesource.com'],), ''),
1895 ((['git', 'config', 'branch.master.gerritpatchset', '1'],), ''),
1896 ((['git', 'rev-parse', 'FETCH_HEAD'],), 'deadbeef'),
1897 ((['git', 'config', 'branch.master.last-upload-hash', 'deadbeef'],), ''),
1898 ((['git', 'config', 'branch.master.gerritsquashhash', 'deadbeef'],), ''),
1899 ]
1900 self.assertEqual(git_cl.main(
1901 ['patch', 'https://else-review.googlesource.com/c/my/repo/+/123456/1']),
1902 0)
1903
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001904 def test_patch_gerrit_conflict(self):
Andrii Shyshkalovf57841b2018-08-28 00:48:53 +00001905 self._patch_common(detect_gerrit_server=True, git_short_host='chromium')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001906 self.calls += [
1907 ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001908 'refs/changes/56/123456/7'],), ''),
tandrii5d48c322016-08-18 16:19:37 -07001909 ((['git', 'cherry-pick', 'FETCH_HEAD'],), CERR1),
1910 ((['DieWithError', 'Command "git cherry-pick FETCH_HEAD" failed.\n'],),
1911 SystemExitMock()),
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001912 ]
1913 with self.assertRaises(SystemExitMock):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001914 git_cl.main(['patch', '123456'])
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00001915
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001916 def test_patch_gerrit_not_exists(self):
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01001917 def notExists(_issue, *_, **kwargs):
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +01001918 raise git_cl.gerrit_util.GerritError(404, '')
1919 self.mock(git_cl.gerrit_util, 'GetChangeDetail', notExists)
1920
tandriic2405f52016-10-10 08:13:15 -07001921 self.calls = [
1922 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
tandriic2405f52016-10-10 08:13:15 -07001923 ((['git', 'config', 'branch.master.gerritissue'],), CERR1),
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001924 ((['git', 'config', 'branch.master.gerritserver'],), CERR1),
1925 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
1926 ((['git', 'config', 'branch.master.remote'],), 'origin'),
1927 ((['git', 'config', 'remote.origin.url'],),
1928 'https://chromium.googlesource.com/my/repo'),
1929 ((['DieWithError',
1930 'change 123456 at https://chromium-review.googlesource.com does not '
1931 'exist or you have no access to it'],), SystemExitMock()),
tandriic2405f52016-10-10 08:13:15 -07001932 ]
1933 with self.assertRaises(SystemExitMock):
Andrii Shyshkalovc9712392017-04-11 13:35:21 +02001934 self.assertEqual(1, git_cl.main(['patch', '123456']))
tandriic2405f52016-10-10 08:13:15 -07001935
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001936 def _checkout_calls(self):
1937 return [
1938 ((['git', 'config', '--local', '--get-regexp',
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001939 'branch\\..*\\.gerritissue'], ),
1940 ('branch.ger-branch.gerritissue 123456\n'
1941 'branch.gbranch654.gerritissue 654321\n')),
1942 ]
1943
1944 def test_checkout_gerrit(self):
1945 """Tests git cl checkout <issue>."""
1946 self.calls = self._checkout_calls()
1947 self.calls += [((['git', 'checkout', 'ger-branch'], ), '')]
1948 self.assertEqual(0, git_cl.main(['checkout', '123456']))
1949
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001950 def test_checkout_not_found(self):
1951 """Tests git cl checkout <issue>."""
tandrii@chromium.org28253532016-04-14 13:46:56 +00001952 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
tandrii@chromium.org5df290f2016-04-11 16:12:29 +00001953 self.calls = self._checkout_calls()
1954 self.assertEqual(1, git_cl.main(['checkout', '99999']))
1955
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001956 def test_checkout_no_branch_issues(self):
1957 """Tests git cl checkout <issue>."""
tandrii@chromium.org28253532016-04-14 13:46:56 +00001958 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001959 self.calls = [
1960 ((['git', 'config', '--local', '--get-regexp',
tandrii5d48c322016-08-18 16:19:37 -07001961 'branch\\..*\\.gerritissue'], ), CERR1),
tandrii@chromium.org26c8fd22016-04-11 21:33:21 +00001962 ]
1963 self.assertEqual(1, git_cl.main(['checkout', '99999']))
1964
tandrii@chromium.org28253532016-04-14 13:46:56 +00001965 def _test_gerrit_ensure_authenticated_common(self, auth,
1966 skip_auth_check=False):
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001967 self.mock(git_cl.gerrit_util, 'CookiesAuthenticator',
1968 CookiesAuthenticatorMockFactory(hosts_with_creds=auth))
1969 self.mock(git_cl, 'DieWithError',
Christopher Lamf732cd52017-01-24 12:40:11 +11001970 lambda msg, change=None: self._mocked_call(['DieWithError', msg]))
tandrii@chromium.org28253532016-04-14 13:46:56 +00001971 self.calls = self._gerrit_ensure_auth_calls(skip_auth_check=skip_auth_check)
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001972 cl = git_cl.Changelist(codereview='gerrit')
tandrii@chromium.org28253532016-04-14 13:46:56 +00001973 cl.branch = 'master'
1974 cl.branchref = 'refs/heads/master'
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001975 cl.lookedup_issue = True
1976 return cl
1977
1978 def test_gerrit_ensure_authenticated_missing(self):
1979 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001980 'chromium.googlesource.com': ('git-is.ok', '', 'but gerrit is missing'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001981 })
1982 self.calls.append(
1983 ((['DieWithError',
1984 'Credentials for the following hosts are required:\n'
1985 ' chromium-review.googlesource.com\n'
1986 'These are read from ~/.gitcookies (or legacy ~/.netrc)\n'
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01001987 'You can (re)generate your credentials by visiting '
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001988 'https://chromium-review.googlesource.com/new-password'],), ''),)
1989 self.assertIsNone(cl.EnsureAuthenticated(force=False))
1990
1991 def test_gerrit_ensure_authenticated_conflict(self):
tandrii@chromium.org28253532016-04-14 13:46:56 +00001992 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001993 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01001994 'chromium.googlesource.com':
1995 ('git-one.example.com', None, 'secret1'),
1996 'chromium-review.googlesource.com':
1997 ('git-other.example.com', None, 'secret2'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00001998 })
1999 self.calls.append(
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002000 (('ask_for_data', 'If you know what you are doing '
2001 'press Enter to continue, or Ctrl+C to abort'), ''))
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002002 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2003
2004 def test_gerrit_ensure_authenticated_ok(self):
2005 cl = self._test_gerrit_ensure_authenticated_common(auth={
Andrii Shyshkalovbb86fbb2017-03-24 14:59:28 +01002006 'chromium.googlesource.com':
2007 ('git-same.example.com', None, 'secret'),
2008 'chromium-review.googlesource.com':
2009 ('git-same.example.com', None, 'secret'),
tandrii@chromium.orgfe30f182016-04-13 12:15:04 +00002010 })
2011 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2012
tandrii@chromium.org28253532016-04-14 13:46:56 +00002013 def test_gerrit_ensure_authenticated_skipped(self):
2014 cl = self._test_gerrit_ensure_authenticated_common(
2015 auth={}, skip_auth_check=True)
2016 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2017
Eric Boren2fb63102018-10-05 13:05:03 +00002018 def test_gerrit_ensure_authenticated_bearer_token(self):
2019 cl = self._test_gerrit_ensure_authenticated_common(auth={
2020 'chromium.googlesource.com':
2021 ('', None, 'secret'),
2022 'chromium-review.googlesource.com':
2023 ('', None, 'secret'),
2024 })
2025 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2026 header = gerrit_util.CookiesAuthenticator().get_auth_header(
2027 'chromium.googlesource.com')
2028 self.assertTrue('Bearer' in header)
2029
Daniel Chengcf6269b2019-05-18 01:02:12 +00002030 def test_gerrit_ensure_authenticated_non_https(self):
2031 self.calls = [
2032 ((['git', 'config', '--bool',
2033 'gerrit.skip-ensure-authenticated'],), CERR1),
2034 ((['git', 'config', 'branch.master.merge'],), 'refs/heads/master'),
2035 ((['git', 'config', 'branch.master.remote'],), 'origin'),
2036 ((['git', 'config', 'remote.origin.url'],), 'custom-scheme://repo'),
2037 ]
2038 self.mock(git_cl.gerrit_util, 'CookiesAuthenticator',
2039 CookiesAuthenticatorMockFactory(hosts_with_creds={}))
2040 cl = git_cl.Changelist(codereview='gerrit')
2041 cl.branch = 'master'
2042 cl.branchref = 'refs/heads/master'
2043 cl.lookedup_issue = True
2044 self.assertIsNone(cl.EnsureAuthenticated(force=False))
2045
Andrii Shyshkalov828701b2016-12-09 10:46:47 +01002046 def _cmd_set_commit_gerrit_common(self, vote, notify=None):
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002047 self.mock(git_cl.gerrit_util, 'SetReview',
Andrii Shyshkalov828701b2016-12-09 10:46:47 +01002048 lambda h, i, labels, notify=None:
2049 self._mocked_call(['SetReview', h, i, labels, notify]))
2050
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002051 self.calls = [
2052 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii33a46ff2016-08-23 05:53:40 -07002053 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002054 ((['git', 'config', 'branch.feature.gerritserver'],),
2055 'https://chromium-review.googlesource.com'),
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002056 ((['git', 'config', 'branch.feature.merge'],), 'refs/heads/master'),
2057 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
2058 ((['git', 'config', 'remote.origin.url'],),
2059 'https://chromium.googlesource.com/infra/infra.git'),
2060 ((['SetReview', 'chromium-review.googlesource.com',
2061 'infra%2Finfra~123',
Andrii Shyshkalov828701b2016-12-09 10:46:47 +01002062 {'Commit-Queue': vote}, notify],), ''),
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002063 ]
tandriid9e5ce52016-07-13 02:32:59 -07002064
2065 def test_cmd_set_commit_gerrit_clear(self):
2066 self._cmd_set_commit_gerrit_common(0)
2067 self.assertEqual(0, git_cl.main(['set-commit', '-c']))
2068
2069 def test_cmd_set_commit_gerrit_dry(self):
Aaron Gable75e78722017-06-09 10:40:16 -07002070 self._cmd_set_commit_gerrit_common(1, notify=False)
tandrii@chromium.orgfa330e82016-04-13 17:09:52 +00002071 self.assertEqual(0, git_cl.main(['set-commit', '-d']))
2072
tandriid9e5ce52016-07-13 02:32:59 -07002073 def test_cmd_set_commit_gerrit(self):
2074 self._cmd_set_commit_gerrit_common(2)
2075 self.assertEqual(0, git_cl.main(['set-commit']))
2076
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002077 def test_description_display(self):
2078 out = StringIO.StringIO()
2079 self.mock(git_cl.sys, 'stdout', out)
2080
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002081 self.mock(git_cl, 'Changelist', ChangelistMock)
2082 ChangelistMock.desc = 'foo\n'
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002083
2084 self.assertEqual(0, git_cl.main(['description', '-d']))
2085 self.assertEqual('foo\n', out.getvalue())
2086
iannucci3c972b92016-08-17 13:24:10 -07002087 def test_StatusFieldOverrideIssueMissingArgs(self):
2088 out = StringIO.StringIO()
2089 self.mock(git_cl.sys, 'stderr', out)
2090
2091 try:
2092 self.assertEqual(git_cl.main(['status', '--issue', '1']), 0)
2093 except SystemExit as ex:
2094 self.assertEqual(ex.code, 2)
iannuccie53c9352016-08-17 14:40:40 -07002095 self.assertRegexpMatches(out.getvalue(), r'--issue must be specified')
iannucci3c972b92016-08-17 13:24:10 -07002096
2097 out = StringIO.StringIO()
2098 self.mock(git_cl.sys, 'stderr', out)
2099
2100 try:
Andrii Shyshkalovfeec80e2018-10-16 01:00:47 +00002101 self.assertEqual(git_cl.main(['status', '--issue', '1', '--gerrit']), 0)
iannucci3c972b92016-08-17 13:24:10 -07002102 except SystemExit as ex:
2103 self.assertEqual(ex.code, 2)
iannuccie53c9352016-08-17 14:40:40 -07002104 self.assertRegexpMatches(out.getvalue(), r'--field must be specified')
iannucci3c972b92016-08-17 13:24:10 -07002105
2106 def test_StatusFieldOverrideIssue(self):
2107 out = StringIO.StringIO()
2108 self.mock(git_cl.sys, 'stdout', out)
2109
2110 def assertIssue(cl_self, *_args):
2111 self.assertEquals(cl_self.issue, 1)
2112 return 'foobar'
2113
2114 self.mock(git_cl.Changelist, 'GetDescription', assertIssue)
iannuccie53c9352016-08-17 14:40:40 -07002115 self.assertEqual(
Andrii Shyshkalovfeec80e2018-10-16 01:00:47 +00002116 git_cl.main(['status', '--issue', '1', '--gerrit', '--field', 'desc']),
iannuccie53c9352016-08-17 14:40:40 -07002117 0)
iannucci3c972b92016-08-17 13:24:10 -07002118 self.assertEqual(out.getvalue(), 'foobar\n')
2119
iannuccie53c9352016-08-17 14:40:40 -07002120 def test_SetCloseOverrideIssue(self):
2121 def assertIssue(cl_self, *_args):
2122 self.assertEquals(cl_self.issue, 1)
2123 return 'foobar'
2124
2125 self.mock(git_cl.Changelist, 'GetDescription', assertIssue)
2126 self.mock(git_cl.Changelist, 'CloseIssue', lambda *_: None)
iannuccie53c9352016-08-17 14:40:40 -07002127 self.assertEqual(
Andrii Shyshkalovfeec80e2018-10-16 01:00:47 +00002128 git_cl.main(['set-close', '--issue', '1', '--gerrit']), 0)
iannuccie53c9352016-08-17 14:40:40 -07002129
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00002130 def test_description(self):
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002131 out = StringIO.StringIO()
2132 self.mock(git_cl.sys, 'stdout', out)
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01002133 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002134 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
2135 ((['git', 'config', 'branch.feature.merge'],), 'feature'),
2136 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
2137 ((['git', 'config', 'remote.origin.url'],),
2138 'https://chromium.googlesource.com/my/repo'),
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00002139 (('GetChangeDetail', 'chromium-review.googlesource.com',
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002140 'my%2Frepo~123123', ['CURRENT_REVISION', 'CURRENT_COMMIT']),
Andrii Shyshkalov8fc0c1d2017-01-26 09:38:10 +01002141 {
2142 'current_revision': 'sha1',
2143 'revisions': {'sha1': {
2144 'commit': {'message': 'foobar'},
2145 }},
2146 }),
2147 ]
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002148 self.assertEqual(0, git_cl.main([
Andrii Shyshkalovdd672fb2018-10-16 06:09:51 +00002149 'description',
2150 'https://chromium-review.googlesource.com/c/my/repo/+/123123',
2151 '-d']))
martiniss@chromium.org2b55fe32016-04-26 20:28:54 +00002152 self.assertEqual('foobar\n', out.getvalue())
2153
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002154 def test_description_set_raw(self):
2155 out = StringIO.StringIO()
2156 self.mock(git_cl.sys, 'stdout', out)
2157
2158 self.mock(git_cl, 'Changelist', ChangelistMock)
2159 self.mock(git_cl.sys, 'stdin', StringIO.StringIO('hihi'))
2160
2161 self.assertEqual(0, git_cl.main(['description', '-n', 'hihi']))
2162 self.assertEqual('hihi', ChangelistMock.desc)
2163
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002164 def test_description_appends_bug_line(self):
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002165 current_desc = 'Some.\n\nChange-Id: xxx'
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002166
2167 def RunEditor(desc, _, **kwargs):
2168 self.assertEquals(
2169 '# Enter a description of the change.\n'
2170 '# This will be displayed on the codereview site.\n'
2171 '# The first line will also be used as the subject of the review.\n'
2172 '#--------------------This line is 72 characters long'
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002173 '--------------------\n'
Aaron Gable3a16ed12017-03-23 10:51:55 -07002174 'Some.\n\nChange-Id: xxx\nBug: ',
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002175 desc)
tandrii@chromium.org601e1d12016-06-03 13:03:54 +00002176 # Simulate user changing something.
Aaron Gable3a16ed12017-03-23 10:51:55 -07002177 return 'Some.\n\nChange-Id: xxx\nBug: 123'
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002178
dsansomee2d6fd92016-09-08 00:10:47 -07002179 def UpdateDescriptionRemote(_, desc, force=False):
Aaron Gable3a16ed12017-03-23 10:51:55 -07002180 self.assertEquals(desc, 'Some.\n\nChange-Id: xxx\nBug: 123')
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002181
2182 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2183 self.mock(git_cl.Changelist, 'GetDescription',
2184 lambda *args: current_desc)
2185 self.mock(git_cl._GerritChangelistImpl, 'UpdateDescriptionRemote',
2186 UpdateDescriptionRemote)
2187 self.mock(git_cl.gclient_utils, 'RunEditor', RunEditor)
2188
2189 self.calls = [
2190 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii33a46ff2016-08-23 05:53:40 -07002191 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
tandrii5d48c322016-08-18 16:19:37 -07002192 ((['git', 'config', 'rietveld.autoupdate'],), CERR1),
2193 ((['git', 'config', 'rietveld.bug-prefix'],), CERR1),
tandrii@chromium.orgd605a512016-06-03 09:55:00 +00002194 ((['git', 'config', 'core.editor'],), 'vi'),
2195 ]
2196 self.assertEqual(0, git_cl.main(['description', '--gerrit']))
2197
martiniss@chromium.orgd6648e22016-04-29 19:22:16 +00002198 def test_description_set_stdin(self):
2199 out = StringIO.StringIO()
2200 self.mock(git_cl.sys, 'stdout', out)
2201
2202 self.mock(git_cl, 'Changelist', ChangelistMock)
2203 self.mock(git_cl.sys, 'stdin', StringIO.StringIO('hi \r\n\t there\n\nman'))
2204
2205 self.assertEqual(0, git_cl.main(['description', '-n', '-']))
2206 self.assertEqual('hi\n\t there\n\nman', ChangelistMock.desc)
2207
kmarshall3bff56b2016-06-06 18:31:47 -07002208 def test_archive(self):
tandrii1c67da62016-06-10 07:35:53 -07002209 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2210
kmarshall3bff56b2016-06-06 18:31:47 -07002211 self.calls = \
2212 [((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2213 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Andrii Shyshkalova185e2e2018-11-21 00:42:55 +00002214 ((['git', 'config', 'branch.master.gerritissue'],), '456'),
2215 ((['git', 'config', 'branch.foo.gerritissue'],), CERR1),
tandrii33a46ff2016-08-23 05:53:40 -07002216 ((['git', 'config', 'branch.bar.gerritissue'],), '789'),
kmarshall3bff56b2016-06-06 18:31:47 -07002217 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2218 ((['git', 'tag', 'git-cl-archived-456-foo', 'foo'],), ''),
2219 ((['git', 'branch', '-D', 'foo'],), '')]
2220
kmarshall3bff56b2016-06-06 18:31:47 -07002221 self.mock(git_cl, 'get_cl_statuses',
2222 lambda branches, fine_grained, max_processes:
kmarshall9249e012016-08-23 12:02:16 -07002223 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2224 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
2225 (MockChangelistWithBranchAndIssue('bar', 789), 'open')])
kmarshall3bff56b2016-06-06 18:31:47 -07002226
2227 self.assertEqual(0, git_cl.main(['archive', '-f']))
2228
2229 def test_archive_current_branch_fails(self):
tandrii1c67da62016-06-10 07:35:53 -07002230 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
kmarshall3bff56b2016-06-06 18:31:47 -07002231 self.calls = \
2232 [((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2233 'refs/heads/master'),
Andrii Shyshkalova185e2e2018-11-21 00:42:55 +00002234 ((['git', 'config', 'branch.master.gerritissue'],), '1'),
kmarshall3bff56b2016-06-06 18:31:47 -07002235 ((['git', 'symbolic-ref', 'HEAD'],), 'master')]
2236
kmarshall9249e012016-08-23 12:02:16 -07002237 self.mock(git_cl, 'get_cl_statuses',
2238 lambda branches, fine_grained, max_processes:
2239 [(MockChangelistWithBranchAndIssue('master', 1), 'closed')])
2240
2241 self.assertEqual(1, git_cl.main(['archive', '-f']))
2242
2243 def test_archive_dry_run(self):
2244 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2245
2246 self.calls = \
2247 [((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2248 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Andrii Shyshkalova185e2e2018-11-21 00:42:55 +00002249 ((['git', 'config', 'branch.master.gerritissue'],), '456'),
2250 ((['git', 'config', 'branch.foo.gerritissue'],), CERR1),
kmarshall9249e012016-08-23 12:02:16 -07002251 ((['git', 'config', 'branch.bar.gerritissue'],), '789'),
2252 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),]
kmarshall3bff56b2016-06-06 18:31:47 -07002253
2254 self.mock(git_cl, 'get_cl_statuses',
2255 lambda branches, fine_grained, max_processes:
kmarshall9249e012016-08-23 12:02:16 -07002256 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2257 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
2258 (MockChangelistWithBranchAndIssue('bar', 789), 'open')])
kmarshall3bff56b2016-06-06 18:31:47 -07002259
kmarshall9249e012016-08-23 12:02:16 -07002260 self.assertEqual(0, git_cl.main(['archive', '-f', '--dry-run']))
2261
2262 def test_archive_no_tags(self):
2263 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2264
2265 self.calls = \
2266 [((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
2267 'refs/heads/master\nrefs/heads/foo\nrefs/heads/bar'),
Andrii Shyshkalova185e2e2018-11-21 00:42:55 +00002268 ((['git', 'config', 'branch.master.gerritissue'],), '1'),
2269 ((['git', 'config', 'branch.foo.gerritissue'],), '456'),
2270 ((['git', 'config', 'branch.bar.gerritissue'],), CERR1),
kmarshall9249e012016-08-23 12:02:16 -07002271 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
2272 ((['git', 'branch', '-D', 'foo'],), '')]
2273
2274 self.mock(git_cl, 'get_cl_statuses',
2275 lambda branches, fine_grained, max_processes:
2276 [(MockChangelistWithBranchAndIssue('master', 1), 'open'),
2277 (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
2278 (MockChangelistWithBranchAndIssue('bar', 789), 'open')])
2279
2280 self.assertEqual(0, git_cl.main(['archive', '-f', '--notags']))
kmarshall3bff56b2016-06-06 18:31:47 -07002281
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002282 def test_cmd_issue_erase_existing(self):
2283 out = StringIO.StringIO()
2284 self.mock(git_cl.sys, 'stdout', out)
2285 self.calls = [
2286 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii33a46ff2016-08-23 05:53:40 -07002287 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002288 # Let this command raise exception (retcode=1) - it should be ignored.
2289 ((['git', 'config', '--unset', 'branch.feature.last-upload-hash'],),
tandrii5d48c322016-08-18 16:19:37 -07002290 CERR1),
2291 ((['git', 'config', '--unset', 'branch.feature.gerritissue'],), ''),
2292 ((['git', 'config', '--unset', 'branch.feature.gerritpatchset'],), ''),
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002293 ((['git', 'config', '--unset', 'branch.feature.gerritserver'],), ''),
2294 ((['git', 'config', '--unset', 'branch.feature.gerritsquashhash'],),
2295 ''),
Aaron Gableca01e2c2017-07-19 11:16:02 -07002296 ((['git', 'log', '-1', '--format=%B'],), 'This is a description'),
tandrii@chromium.org9b7fd712016-06-01 13:45:20 +00002297 ]
2298 self.assertEqual(0, git_cl.main(['issue', '0']))
2299
Aaron Gable400e9892017-07-12 15:31:21 -07002300 def test_cmd_issue_erase_existing_with_change_id(self):
2301 out = StringIO.StringIO()
2302 self.mock(git_cl.sys, 'stdout', out)
2303 self.mock(git_cl.Changelist, 'GetDescription',
2304 lambda _: 'This is a description\n\nChange-Id: Ideadbeef')
2305 self.calls = [
2306 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
Aaron Gable400e9892017-07-12 15:31:21 -07002307 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
Aaron Gable400e9892017-07-12 15:31:21 -07002308 # Let this command raise exception (retcode=1) - it should be ignored.
2309 ((['git', 'config', '--unset', 'branch.feature.last-upload-hash'],),
2310 CERR1),
2311 ((['git', 'config', '--unset', 'branch.feature.gerritissue'],), ''),
2312 ((['git', 'config', '--unset', 'branch.feature.gerritpatchset'],), ''),
2313 ((['git', 'config', '--unset', 'branch.feature.gerritserver'],), ''),
2314 ((['git', 'config', '--unset', 'branch.feature.gerritsquashhash'],),
2315 ''),
Aaron Gableca01e2c2017-07-19 11:16:02 -07002316 ((['git', 'log', '-1', '--format=%B'],),
2317 'This is a description\n\nChange-Id: Ideadbeef'),
2318 ((['git', 'commit', '--amend', '-m', 'This is a description\n'],), ''),
Aaron Gable400e9892017-07-12 15:31:21 -07002319 ]
2320 self.assertEqual(0, git_cl.main(['issue', '0']))
2321
phajdan.jre328cf92016-08-22 04:12:17 -07002322 def test_cmd_issue_json(self):
2323 out = StringIO.StringIO()
2324 self.mock(git_cl.sys, 'stdout', out)
2325 self.calls = [
2326 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
Andrii Shyshkalova185e2e2018-11-21 00:42:55 +00002327 ((['git', 'config', 'branch.feature.gerritissue'],), '123'),
2328 ((['git', 'config', 'branch.feature.gerritserver'],),
2329 'https://chromium-review.googlesource.com'),
phajdan.jre328cf92016-08-22 04:12:17 -07002330 (('write_json', 'output.json',
Andrii Shyshkalova185e2e2018-11-21 00:42:55 +00002331 {'issue': 123,
2332 'issue_url': 'https://chromium-review.googlesource.com/123'}),
phajdan.jre328cf92016-08-22 04:12:17 -07002333 ''),
2334 ]
2335 self.assertEqual(0, git_cl.main(['issue', '--json', 'output.json']))
2336
tandrii8c5a3532016-11-04 07:52:02 -07002337 def test_git_cl_try_default_cq_dry_run_gerrit(self):
2338 self.mock(git_cl.Changelist, 'GetChange',
2339 lambda _, *a: (
2340 self._mocked_call(['GetChange']+list(a))))
2341 self.mock(git_cl.presubmit_support, 'DoGetTryMasters',
2342 lambda *_, **__: (
2343 self._mocked_call(['DoGetTryMasters'])))
2344 self.mock(git_cl._GerritChangelistImpl, 'SetCQState',
2345 lambda _, s: self._mocked_call(['SetCQState', s]))
2346
tandrii8c5a3532016-11-04 07:52:02 -07002347 self.calls = [
2348 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii8c5a3532016-11-04 07:52:02 -07002349 ((['git', 'config', 'branch.feature.gerritissue'],), '123456'),
2350 ((['git', 'config', 'branch.feature.gerritserver'],),
2351 'https://chromium-review.googlesource.com'),
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002352 ((['git', 'config', 'branch.feature.merge'],), 'feature'),
2353 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
2354 ((['git', 'config', 'remote.origin.url'],),
2355 'https://chromium.googlesource.com/depot_tools'),
2356 (('GetChangeDetail', 'chromium-review.googlesource.com',
2357 'depot_tools~123456',
Andrii Shyshkaloveadad922017-01-26 09:38:30 +01002358 ['DETAILED_ACCOUNTS', 'ALL_REVISIONS', 'CURRENT_COMMIT']), {
2359 'project': 'depot_tools',
2360 'status': 'OPEN',
2361 'owner': {'email': 'owner@e.mail'},
2362 'revisions': {
2363 'deadbeaf': {
2364 '_number': 6,
2365 },
2366 'beeeeeef': {
2367 '_number': 7,
2368 'fetch': {'http': {
2369 'url': 'https://chromium.googlesource.com/depot_tools',
2370 'ref': 'refs/changes/56/123456/7'
2371 }},
2372 },
2373 },
2374 }),
tandrii8c5a3532016-11-04 07:52:02 -07002375 ((['git', 'config', 'branch.feature.merge'],), 'feature'),
2376 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
2377 ((['get_or_create_merge_base', 'feature', 'feature'],),
2378 'fake_ancestor_sha'),
2379 ((['GetChange', 'fake_ancestor_sha', None], ),
2380 git_cl.presubmit_support.GitChange(
2381 '', '', '', '', '', '', '', '')),
2382 ((['git', 'rev-parse', '--show-cdup'],), '../'),
2383 ((['DoGetTryMasters'], ), None),
2384 ((['SetCQState', git_cl._CQState.DRY_RUN], ), None),
2385 ]
2386 out = StringIO.StringIO()
2387 self.mock(git_cl.sys, 'stdout', out)
2388 self.assertEqual(0, git_cl.main(['try']))
2389 self.assertEqual(
2390 out.getvalue(),
Quinten Yearsleyfc5fd922017-05-31 11:50:52 -07002391 'Scheduling CQ dry run on: '
tandrii8c5a3532016-11-04 07:52:02 -07002392 'https://chromium-review.googlesource.com/123456\n')
2393
tandrii8c5a3532016-11-04 07:52:02 -07002394 def test_git_cl_try_buildbucket_with_properties_gerrit(self):
2395 self.mock(git_cl.Changelist, 'GetMostRecentPatchset', lambda _: 7)
2396 self.mock(git_cl.uuid, 'uuid4', lambda: 'uuid4')
2397
tandrii8c5a3532016-11-04 07:52:02 -07002398 self.calls = [
2399 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii8c5a3532016-11-04 07:52:02 -07002400 ((['git', 'config', 'branch.feature.gerritissue'],), '123456'),
2401 ((['git', 'config', 'branch.feature.gerritserver'],),
2402 'https://chromium-review.googlesource.com'),
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002403 ((['git', 'config', 'branch.feature.merge'],), 'feature'),
2404 ((['git', 'config', 'branch.feature.remote'],), 'origin'),
2405 ((['git', 'config', 'remote.origin.url'],),
2406 'https://chromium.googlesource.com/depot_tools'),
2407 (('GetChangeDetail', 'chromium-review.googlesource.com',
2408 'depot_tools~123456',
Andrii Shyshkaloveadad922017-01-26 09:38:30 +01002409 ['DETAILED_ACCOUNTS', 'ALL_REVISIONS', 'CURRENT_COMMIT']), {
tandrii8c5a3532016-11-04 07:52:02 -07002410 'project': 'depot_tools',
Andrii Shyshkaloveadad922017-01-26 09:38:30 +01002411 'status': 'OPEN',
2412 'owner': {'email': 'owner@e.mail'},
tandrii8c5a3532016-11-04 07:52:02 -07002413 'revisions': {
2414 'deadbeaf': {
2415 '_number': 6,
2416 },
2417 'beeeeeef': {
2418 '_number': 7,
2419 'fetch': {'http': {
2420 'url': 'https://chromium.googlesource.com/depot_tools',
2421 'ref': 'refs/changes/56/123456/7'
2422 }},
2423 },
2424 },
2425 }),
2426 ]
2427
2428 def _buildbucket_retry(*_, **kw):
2429 # self.maxDiff = 10000
2430 body = json.loads(kw['body'])
2431 self.assertEqual(len(body['builds']), 1)
2432 build = body['builds'][0]
2433 params = json.loads(build.pop('parameters_json'))
2434 self.assertEqual(params, {
2435 u'builder_name': u'win',
2436 u'changes': [{u'author': {u'email': u'owner@e.mail'},
2437 u'revision': None}],
2438 u'properties': {
2439 u'category': u'git_cl_try',
2440 u'key': u'val',
2441 u'json': [{u'a': 1}, None],
tandrii8c5a3532016-11-04 07:52:02 -07002442
2443 u'patch_gerrit_url':
2444 u'https://chromium-review.googlesource.com',
2445 u'patch_issue': 123456,
2446 u'patch_project': u'depot_tools',
2447 u'patch_ref': u'refs/changes/56/123456/7',
2448 u'patch_repository_url':
2449 u'https://chromium.googlesource.com/depot_tools',
2450 u'patch_set': 7,
2451 u'patch_storage': u'gerrit',
2452 }
2453 })
2454 self.assertEqual(build, {
Andrii Shyshkalov03da1502018-10-15 03:42:34 +00002455 u'bucket': u'luci.chromium.try',
tandrii8c5a3532016-11-04 07:52:02 -07002456 u'client_operation_id': u'uuid4',
2457 u'tags': [
2458 u'builder:win',
2459 u'buildset:patch/gerrit/chromium-review.googlesource.com/123456/7',
2460 u'user_agent:git_cl_try',
Andrii Shyshkalov03da1502018-10-15 03:42:34 +00002461 ],
tandrii8c5a3532016-11-04 07:52:02 -07002462 })
2463
2464 self.mock(git_cl, '_buildbucket_retry', _buildbucket_retry)
2465
2466 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2467 self.assertEqual(0, git_cl.main([
Andrii Shyshkalov03da1502018-10-15 03:42:34 +00002468 'try', '-B', 'luci.chromium.try', '-b', 'win',
tandrii8c5a3532016-11-04 07:52:02 -07002469 '-p', 'key=val', '-p', 'json=[{"a":1}, null]']))
2470 self.assertRegexpMatches(
2471 git_cl.sys.stdout.getvalue(),
Andrii Shyshkalov03da1502018-10-15 03:42:34 +00002472 'Tried jobs on:\nBucket: luci.chromium.try')
tandriide281ae2016-10-12 06:02:30 -07002473
tandrii16e0b4e2016-06-07 10:34:28 -07002474 def _common_GerritCommitMsgHookCheck(self):
2475 self.mock(git_cl.sys, 'stdout', StringIO.StringIO())
2476 self.mock(git_cl.os.path, 'abspath',
2477 lambda path: self._mocked_call(['abspath', path]))
2478 self.mock(git_cl.os.path, 'exists',
2479 lambda path: self._mocked_call(['exists', path]))
2480 self.mock(git_cl.gclient_utils, 'FileRead',
2481 lambda path: self._mocked_call(['FileRead', path]))
2482 self.mock(git_cl.gclient_utils, 'rm_file_or_tree',
2483 lambda path: self._mocked_call(['rm_file_or_tree', path]))
2484 self.calls = [
2485 ((['git', 'rev-parse', '--show-cdup'],), '../'),
2486 ((['abspath', '../'],), '/abs/git_repo_root'),
2487 ]
2488 return git_cl.Changelist(codereview='gerrit', issue=123)
2489
2490 def test_GerritCommitMsgHookCheck_custom_hook(self):
2491 cl = self._common_GerritCommitMsgHookCheck()
2492 self.calls += [
2493 ((['exists', '/abs/git_repo_root/.git/hooks/commit-msg'],), True),
2494 ((['FileRead', '/abs/git_repo_root/.git/hooks/commit-msg'],),
2495 '#!/bin/sh\necho "custom hook"')
2496 ]
2497 cl._codereview_impl._GerritCommitMsgHookCheck(offer_removal=True)
2498
2499 def test_GerritCommitMsgHookCheck_not_exists(self):
2500 cl = self._common_GerritCommitMsgHookCheck()
2501 self.calls += [
2502 ((['exists', '/abs/git_repo_root/.git/hooks/commit-msg'],), False),
2503 ]
2504 cl._codereview_impl._GerritCommitMsgHookCheck(offer_removal=True)
2505
2506 def test_GerritCommitMsgHookCheck(self):
2507 cl = self._common_GerritCommitMsgHookCheck()
2508 self.calls += [
2509 ((['exists', '/abs/git_repo_root/.git/hooks/commit-msg'],), True),
2510 ((['FileRead', '/abs/git_repo_root/.git/hooks/commit-msg'],),
2511 '...\n# From Gerrit Code Review\n...\nadd_ChangeId()\n'),
Andrii Shyshkalovabc26ac2017-03-14 14:49:38 +01002512 (('ask_for_data', 'Do you want to remove it now? [Yes/No]: '), 'Yes'),
tandrii16e0b4e2016-06-07 10:34:28 -07002513 ((['rm_file_or_tree', '/abs/git_repo_root/.git/hooks/commit-msg'],),
2514 ''),
2515 ]
2516 cl._codereview_impl._GerritCommitMsgHookCheck(offer_removal=True)
2517
tandriic4344b52016-08-29 06:04:54 -07002518 def test_GerritCmdLand(self):
2519 self.calls += [
2520 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
2521 ((['git', 'config', 'branch.feature.gerritsquashhash'],),
2522 'deadbeaf'),
2523 ((['git', 'diff', 'deadbeaf'],), ''), # No diff.
2524 ((['git', 'config', 'branch.feature.gerritserver'],),
2525 'chromium-review.googlesource.com'),
2526 ]
2527 cl = git_cl.Changelist(issue=123, codereview='gerrit')
2528 cl._codereview_impl._GetChangeDetail = lambda _: {
2529 'labels': {},
2530 'current_revision': 'deadbeaf',
2531 }
agable32978d92016-11-01 12:55:02 -07002532 cl._codereview_impl._GetChangeCommit = lambda: {
2533 'commit': 'deadbeef',
Aaron Gable02cdbb42016-12-13 16:24:25 -08002534 'web_links': [{'name': 'gitiles',
agable32978d92016-11-01 12:55:02 -07002535 'url': 'https://git.googlesource.com/test/+/deadbeef'}],
2536 }
tandriic4344b52016-08-29 06:04:54 -07002537 cl._codereview_impl.SubmitIssue = lambda wait_for_merge: None
tandrii8da412c2016-09-07 16:01:07 -07002538 out = StringIO.StringIO()
2539 self.mock(sys, 'stdout', out)
Olivier Robin75ee7252018-04-13 10:02:56 +02002540 self.assertEqual(0, cl.CMDLand(force=True,
2541 bypass_hooks=True,
2542 verbose=True,
2543 parallel=False))
tandrii8da412c2016-09-07 16:01:07 -07002544 self.assertRegexpMatches(out.getvalue(), 'Issue.*123 has been submitted')
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002545 self.assertRegexpMatches(out.getvalue(), 'Landed as: .*deadbeef')
tandriic4344b52016-08-29 06:04:54 -07002546
tandrii221ab252016-10-06 08:12:04 -07002547 BUILDBUCKET_BUILDS_MAP = {
Quinten Yearsleya563d722017-12-11 16:36:54 -08002548 '9000': {
2549 'id': '9000',
2550 'bucket': 'master.x.y',
2551 'created_by': 'user:someone@chromium.org',
2552 'created_ts': '147200002222000',
2553 'experimental': False,
2554 'parameters_json': json.dumps({
2555 'builder_name': 'my-bot',
2556 'properties': {'category': 'cq'},
2557 }),
2558 'status': 'STARTED',
2559 'tags': [
2560 'build_address:x.y/my-bot/2',
2561 'builder:my-bot',
2562 'experimental:false',
2563 'user_agent:cq',
2564 ],
2565 'url': 'http://build.cr.org/p/x.y/builders/my-bot/builds/2',
2566 },
2567 '8000': {
2568 'id': '8000',
2569 'bucket': 'master.x.y',
2570 'created_by': 'user:someone@chromium.org',
2571 'created_ts': '147200001111000',
2572 'experimental': False,
2573 'failure_reason': 'BUILD_FAILURE',
2574 'parameters_json': json.dumps({
2575 'builder_name': 'my-bot',
2576 'properties': {'category': 'cq'},
2577 }),
2578 'result_details_json': json.dumps({
2579 'properties': {'buildnumber': 1},
2580 }),
2581 'result': 'FAILURE',
2582 'status': 'COMPLETED',
2583 'tags': [
2584 'build_address:x.y/my-bot/1',
2585 'builder:my-bot',
2586 'experimental:false',
2587 'user_agent:cq',
2588 ],
2589 'url': 'http://build.cr.org/p/x.y/builders/my-bot/builds/1',
2590 },
2591 }
tandrii221ab252016-10-06 08:12:04 -07002592
2593 def test_write_try_results_json(self):
2594 expected_output = [
Quinten Yearsleya563d722017-12-11 16:36:54 -08002595 {
2596 'bucket': 'master.x.y',
2597 'buildbucket_id': '8000',
2598 'builder_name': 'my-bot',
2599 'created_ts': '147200001111000',
2600 'experimental': False,
2601 'failure_reason': 'BUILD_FAILURE',
2602 'result': 'FAILURE',
2603 'status': 'COMPLETED',
2604 'tags': [
2605 'build_address:x.y/my-bot/1',
2606 'builder:my-bot',
2607 'experimental:false',
2608 'user_agent:cq',
2609 ],
2610 'url': 'http://build.cr.org/p/x.y/builders/my-bot/builds/1',
2611 },
2612 {
2613 'bucket': 'master.x.y',
2614 'buildbucket_id': '9000',
2615 'builder_name': 'my-bot',
2616 'created_ts': '147200002222000',
2617 'experimental': False,
2618 'failure_reason': None,
2619 'result': None,
2620 'status': 'STARTED',
2621 'tags': [
2622 'build_address:x.y/my-bot/2',
2623 'builder:my-bot',
2624 'experimental:false',
2625 'user_agent:cq',
2626 ],
2627 'url': 'http://build.cr.org/p/x.y/builders/my-bot/builds/2',
2628 },
tandrii221ab252016-10-06 08:12:04 -07002629 ]
2630 self.calls = [(('write_json', 'output.json', expected_output), '')]
2631 git_cl.write_try_results_json('output.json', self.BUILDBUCKET_BUILDS_MAP)
2632
tandrii45b2a582016-10-11 03:14:16 -07002633 def _setup_fetch_try_jobs(self, most_recent_patchset=20001):
tandrii221ab252016-10-06 08:12:04 -07002634 out = StringIO.StringIO()
2635 self.mock(sys, 'stdout', out)
tandrii45b2a582016-10-11 03:14:16 -07002636 self.mock(git_cl.Changelist, 'GetMostRecentPatchset',
2637 lambda *args: most_recent_patchset)
tandrii221ab252016-10-06 08:12:04 -07002638 self.mock(git_cl.auth, 'get_authenticator_for_host', lambda host, _cfg:
2639 self._mocked_call(['get_authenticator_for_host', host]))
2640 self.mock(git_cl, '_buildbucket_retry', lambda *_, **__:
2641 self._mocked_call(['_buildbucket_retry']))
tandrii45b2a582016-10-11 03:14:16 -07002642
tandrii45b2a582016-10-11 03:14:16 -07002643 def _setup_fetch_try_jobs_gerrit(self, *request_results):
2644 self._setup_fetch_try_jobs(most_recent_patchset=13)
2645 self.calls += [
2646 ((['git', 'symbolic-ref', 'HEAD'],), 'feature'),
tandrii45b2a582016-10-11 03:14:16 -07002647 ((['git', 'config', 'branch.feature.gerritissue'],), '1'),
Ravi Mistryfda50ca2016-11-14 10:19:18 -05002648 # TODO(tandrii): Uncomment the below if we decide to support checking
2649 # patchsets for Gerrit.
tandrii45b2a582016-10-11 03:14:16 -07002650 # Simulate that Gerrit has more patchsets than local.
Ravi Mistryfda50ca2016-11-14 10:19:18 -05002651 # ((['git', 'config', 'branch.feature.gerritpatchset'],), '12'),
tandrii45b2a582016-10-11 03:14:16 -07002652 ((['git', 'config', 'branch.feature.gerritserver'],),
2653 'https://x-review.googlesource.com'),
2654 ((['get_authenticator_for_host', 'x-review.googlesource.com'],),
2655 AuthenticatorMock()),
2656 ] + [((['_buildbucket_retry'],), r) for r in request_results]
2657
2658 def test_fetch_try_jobs_none_gerrit(self):
2659 self._setup_fetch_try_jobs_gerrit({})
2660 self.assertEqual(0, git_cl.main(['try-results']))
Ravi Mistryfda50ca2016-11-14 10:19:18 -05002661 # TODO(tandrii): Uncomment the below if we decide to support checking
2662 # patchsets for Gerrit.
2663 # self.assertRegexpMatches(
2664 # sys.stdout.getvalue(),
2665 # r'Warning: Codereview server has newer patchsets \(13\)')
tandrii45b2a582016-10-11 03:14:16 -07002666 self.assertRegexpMatches(sys.stdout.getvalue(), 'No try jobs')
2667
2668 def test_fetch_try_jobs_some_gerrit(self):
2669 self._setup_fetch_try_jobs_gerrit({
2670 'builds': self.BUILDBUCKET_BUILDS_MAP.values(),
2671 })
Ravi Mistryfda50ca2016-11-14 10:19:18 -05002672 # TODO(tandrii): Uncomment the below if we decide to support checking
2673 # patchsets for Gerrit.
2674 # self.calls.remove(
2675 # ((['git', 'config', 'branch.feature.gerritpatchset'],), '12'))
tandrii45b2a582016-10-11 03:14:16 -07002676 self.assertEqual(0, git_cl.main(['try-results', '--patchset', '5']))
2677
2678 # ... and doesn't result in warning.
2679 self.assertNotRegexpMatches(sys.stdout.getvalue(), 'Warning')
2680 self.assertRegexpMatches(sys.stdout.getvalue(), '^Failures:')
tandrii221ab252016-10-06 08:12:04 -07002681 self.assertRegexpMatches(sys.stdout.getvalue(), 'Started:')
2682 self.assertRegexpMatches(sys.stdout.getvalue(), '2 try jobs')
2683
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002684 def _mock_gerrit_changes_for_detail_cache(self):
2685 self.mock(git_cl._GerritChangelistImpl, '_GetGerritHost', lambda _: 'host')
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002686
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002687 def test_gerrit_change_detail_cache_simple(self):
2688 self._mock_gerrit_changes_for_detail_cache()
2689 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002690 (('GetChangeDetail', 'host', 'my%2Frepo~1', []), 'a'),
2691 (('GetChangeDetail', 'host', 'ab%2Frepo~2', []), 'b'),
2692 (('GetChangeDetail', 'host', 'ab%2Frepo~2', []), 'b2'),
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002693 ]
Andrii Shyshkalovb7214602018-08-22 23:20:26 +00002694 cl1 = git_cl.Changelist(issue=1, codereview='gerrit')
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002695 cl1._cached_remote_url = (
2696 True, 'https://chromium.googlesource.com/a/my/repo.git/')
Andrii Shyshkalovb7214602018-08-22 23:20:26 +00002697 cl2 = git_cl.Changelist(issue=2, codereview='gerrit')
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002698 cl2._cached_remote_url = (
2699 True, 'https://chromium.googlesource.com/ab/repo')
Andrii Shyshkalovb7214602018-08-22 23:20:26 +00002700 self.assertEqual(cl1._GetChangeDetail(), 'a') # Miss.
2701 self.assertEqual(cl1._GetChangeDetail(), 'a')
2702 self.assertEqual(cl2._GetChangeDetail(), 'b') # Miss.
2703 self.assertEqual(cl2._GetChangeDetail(no_cache=True), 'b2') # Miss.
2704 self.assertEqual(cl1._GetChangeDetail(), 'a')
2705 self.assertEqual(cl2._GetChangeDetail(), 'b2')
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002706
2707 def test_gerrit_change_detail_cache_options(self):
2708 self._mock_gerrit_changes_for_detail_cache()
2709 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002710 (('GetChangeDetail', 'host', 'repo~1', ['C', 'A', 'B']), 'cab'),
2711 (('GetChangeDetail', 'host', 'repo~1', ['A', 'D']), 'ad'),
2712 (('GetChangeDetail', 'host', 'repo~1', ['A']), 'a'), # no_cache=True
2713 # no longer in cache.
2714 (('GetChangeDetail', 'host', 'repo~1', ['B']), 'b'),
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002715 ]
2716 cl = git_cl.Changelist(issue=1, codereview='gerrit')
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002717 cl._cached_remote_url = (True, 'https://chromium.googlesource.com/repo/')
Andrii Shyshkalov258e0a62017-01-24 16:50:57 +01002718 self.assertEqual(cl._GetChangeDetail(options=['C', 'A', 'B']), 'cab')
2719 self.assertEqual(cl._GetChangeDetail(options=['A', 'B', 'C']), 'cab')
2720 self.assertEqual(cl._GetChangeDetail(options=['B', 'A']), 'cab')
2721 self.assertEqual(cl._GetChangeDetail(options=['C']), 'cab')
2722 self.assertEqual(cl._GetChangeDetail(options=['A']), 'cab')
2723 self.assertEqual(cl._GetChangeDetail(), 'cab')
2724
2725 self.assertEqual(cl._GetChangeDetail(options=['A', 'D']), 'ad')
2726 self.assertEqual(cl._GetChangeDetail(options=['A']), 'cab')
2727 self.assertEqual(cl._GetChangeDetail(options=['D']), 'ad')
2728 self.assertEqual(cl._GetChangeDetail(), 'cab')
2729
2730 # Finally, no_cache should invalidate all caches for given change.
2731 self.assertEqual(cl._GetChangeDetail(options=['A'], no_cache=True), 'a')
2732 self.assertEqual(cl._GetChangeDetail(options=['B']), 'b')
2733
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002734 def test_gerrit_description_caching(self):
2735 def gen_detail(rev, desc):
2736 return {
2737 'current_revision': rev,
2738 'revisions': {rev: {'commit': {'message': desc}}}
2739 }
2740 self.calls = [
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002741 (('GetChangeDetail', 'host', 'my%2Frepo~1',
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002742 ['CURRENT_REVISION', 'CURRENT_COMMIT']),
2743 gen_detail('rev1', 'desc1')),
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002744 (('GetChangeDetail', 'host', 'my%2Frepo~1',
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002745 ['CURRENT_REVISION', 'CURRENT_COMMIT']),
2746 gen_detail('rev2', 'desc2')),
2747 ]
2748
2749 self._mock_gerrit_changes_for_detail_cache()
2750 cl = git_cl.Changelist(issue=1, codereview='gerrit')
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002751 cl._cached_remote_url = (
2752 True, 'https://chromium.googlesource.com/a/my/repo.git/')
Andrii Shyshkalov21fb8242017-02-15 21:09:27 +01002753 self.assertEqual(cl.GetDescription(), 'desc1')
2754 self.assertEqual(cl.GetDescription(), 'desc1') # cache hit.
2755 self.assertEqual(cl.GetDescription(force=True), 'desc2')
tandrii@chromium.orgf86c7d32016-04-01 19:27:30 +00002756
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002757 def test_print_current_creds(self):
2758 class CookiesAuthenticatorMock(object):
2759 def __init__(self):
2760 self.gitcookies = {
2761 'host.googlesource.com': ('user', 'pass'),
2762 'host-review.googlesource.com': ('user', 'pass'),
2763 }
2764 self.netrc = self
2765 self.netrc.hosts = {
2766 'github.com': ('user2', None, 'pass2'),
2767 'host2.googlesource.com': ('user3', None, 'pass'),
2768 }
2769 self.mock(git_cl.gerrit_util, 'CookiesAuthenticator',
2770 CookiesAuthenticatorMock)
2771 self.mock(sys, 'stdout', StringIO.StringIO())
2772 git_cl._GitCookiesChecker().print_current_creds(include_netrc=True)
2773 self.assertEqual(list(sys.stdout.getvalue().splitlines()), [
2774 ' Host\t User\t Which file',
2775 '============================\t=====\t===========',
2776 'host-review.googlesource.com\t user\t.gitcookies',
2777 ' host.googlesource.com\t user\t.gitcookies',
2778 ' host2.googlesource.com\tuser3\t .netrc',
2779 ])
2780 sys.stdout.buf = ''
2781 git_cl._GitCookiesChecker().print_current_creds(include_netrc=False)
2782 self.assertEqual(list(sys.stdout.getvalue().splitlines()), [
2783 ' Host\tUser\t Which file',
2784 '============================\t====\t===========',
2785 'host-review.googlesource.com\tuser\t.gitcookies',
2786 ' host.googlesource.com\tuser\t.gitcookies',
2787 ])
2788
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002789 def _common_creds_check_mocks(self):
2790 def exists_mock(path):
2791 dirname = os.path.dirname(path)
2792 if dirname == os.path.expanduser('~'):
2793 dirname = '~'
2794 base = os.path.basename(path)
2795 if base in ('.netrc', '.gitcookies'):
2796 return self._mocked_call('os.path.exists', '%s/%s' % (dirname, base))
2797 # git cl also checks for existence other files not relevant to this test.
2798 return None
2799 self.mock(os.path, 'exists', exists_mock)
2800 self.mock(sys, 'stdout', StringIO.StringIO())
2801
2802 def test_creds_check_gitcookies_not_configured(self):
2803 self._common_creds_check_mocks()
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002804 self.mock(git_cl._GitCookiesChecker, 'get_hosts_with_creds',
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01002805 lambda _, include_netrc=False: [])
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002806 self.calls = [
Aaron Gable8797cab2018-03-06 13:55:00 -08002807 ((['git', 'config', '--path', 'http.cookiefile'],), CERR1),
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002808 ((['git', 'config', '--global', 'http.cookiefile'],), CERR1),
2809 (('os.path.exists', '~/.netrc'), True),
2810 (('ask_for_data', 'Press Enter to setup .gitcookies, '
2811 'or Ctrl+C to abort'), ''),
2812 ((['git', 'config', '--global', 'http.cookiefile',
2813 os.path.expanduser('~/.gitcookies')], ), ''),
2814 ]
2815 self.assertEqual(0, git_cl.main(['creds-check']))
2816 self.assertRegexpMatches(
2817 sys.stdout.getvalue(),
2818 '^You seem to be using outdated .netrc for git credentials:')
2819 self.assertRegexpMatches(
2820 sys.stdout.getvalue(),
2821 '\nConfigured git to use .gitcookies from')
2822
2823 def test_creds_check_gitcookies_configured_custom_broken(self):
2824 self._common_creds_check_mocks()
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01002825 self.mock(git_cl._GitCookiesChecker, 'get_hosts_with_creds',
Andrii Shyshkalov0a0b0672017-03-16 16:27:48 +01002826 lambda _, include_netrc=False: [])
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002827 self.calls = [
Aaron Gable8797cab2018-03-06 13:55:00 -08002828 ((['git', 'config', '--path', 'http.cookiefile'],), CERR1),
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002829 ((['git', 'config', '--global', 'http.cookiefile'],),
2830 '/custom/.gitcookies'),
2831 (('os.path.exists', '/custom/.gitcookies'), False),
2832 (('ask_for_data', 'Reconfigure git to use default .gitcookies? '
2833 'Press Enter to reconfigure, or Ctrl+C to abort'), ''),
2834 ((['git', 'config', '--global', 'http.cookiefile',
2835 os.path.expanduser('~/.gitcookies')], ), ''),
2836 ]
2837 self.assertEqual(0, git_cl.main(['creds-check']))
2838 self.assertRegexpMatches(
2839 sys.stdout.getvalue(),
Quinten Yearsley0c62da92017-05-31 13:39:42 -07002840 'WARNING: You have configured custom path to .gitcookies: ')
Andrii Shyshkalov353637c2017-03-14 16:52:18 +01002841 self.assertRegexpMatches(
2842 sys.stdout.getvalue(),
2843 'However, your configured .gitcookies file is missing.')
2844
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002845 def test_git_cl_comment_add_gerrit(self):
2846 self.mock(git_cl.gerrit_util, 'SetReview',
Aaron Gable636b13f2017-07-14 10:42:48 -07002847 lambda host, change, msg, ready:
2848 self._mocked_call('SetReview', host, change, msg, ready))
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002849 self.calls = [
2850 ((['git', 'symbolic-ref', 'HEAD'],), CERR1),
2851 ((['git', 'symbolic-ref', 'HEAD'],), CERR1),
2852 ((['git', 'config', 'rietveld.upstream-branch'],), CERR1),
2853 ((['git', 'branch', '-r'],), 'origin/HEAD -> origin/master\n'
2854 'origin/master'),
2855 ((['git', 'config', 'remote.origin.url'],),
2856 'https://chromium.googlesource.com/infra/infra'),
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002857 (('SetReview', 'chromium-review.googlesource.com', 'infra%2Finfra~10',
2858 'msg', None),
Aaron Gable636b13f2017-07-14 10:42:48 -07002859 None),
Andrii Shyshkalov625986d2017-03-16 00:24:37 +01002860 ]
2861 self.assertEqual(0, git_cl.main(['comment', '--gerrit', '-i', '10',
2862 '-a', 'msg']))
2863
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002864 def test_git_cl_comments_fetch_gerrit(self):
2865 self.mock(sys, 'stdout', StringIO.StringIO())
2866 self.calls = [
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002867 ((['git', 'config', 'branch.foo.gerritserver'],), ''),
2868 ((['git', 'config', 'branch.foo.merge'],), ''),
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002869 ((['git', 'config', 'rietveld.upstream-branch'],), CERR1),
2870 ((['git', 'branch', '-r'],), 'origin/HEAD -> origin/master\n'
2871 'origin/master'),
2872 ((['git', 'config', 'remote.origin.url'],),
2873 'https://chromium.googlesource.com/infra/infra'),
Andrii Shyshkalov03e0ed22018-08-28 19:39:30 +00002874 (('GetChangeDetail', 'chromium-review.googlesource.com',
2875 'infra%2Finfra~1',
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002876 ['MESSAGES', 'DETAILED_ACCOUNTS', 'CURRENT_REVISION',
2877 'CURRENT_COMMIT']), {
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002878 'owner': {'email': 'owner@example.com'},
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002879 'current_revision': 'ba5eba11',
2880 'revisions': {
2881 'deadbeaf': {
2882 '_number': 1,
2883 },
2884 'ba5eba11': {
2885 '_number': 2,
2886 },
2887 },
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002888 'messages': [
2889 {
2890 u'_revision_number': 1,
2891 u'author': {
2892 u'_account_id': 1111084,
2893 u'email': u'commit-bot@chromium.org',
2894 u'name': u'Commit Bot'
2895 },
2896 u'date': u'2017-03-15 20:08:45.000000000',
2897 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046dc50b',
Dirk Prankef6a58802017-10-17 12:49:42 -07002898 u'message': u'Patch Set 1:\n\nDry run: CQ is trying the patch...',
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002899 u'tag': u'autogenerated:cq:dry-run'
2900 },
2901 {
2902 u'_revision_number': 2,
2903 u'author': {
2904 u'_account_id': 11151243,
2905 u'email': u'owner@example.com',
2906 u'name': u'owner'
2907 },
2908 u'date': u'2017-03-16 20:00:41.000000000',
2909 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
2910 u'message': u'PTAL',
2911 },
2912 {
2913 u'_revision_number': 2,
2914 u'author': {
2915 u'_account_id': 148512 ,
2916 u'email': u'reviewer@example.com',
2917 u'name': u'reviewer'
2918 },
2919 u'date': u'2017-03-17 05:19:37.500000000',
2920 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d4568',
2921 u'message': u'Patch Set 2: Code-Review+1',
2922 },
2923 ]
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002924 }),
Andrii Shyshkalov889677c2018-08-28 20:43:06 +00002925 (('GetChangeComments', 'chromium-review.googlesource.com',
2926 'infra%2Finfra~1'), {
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002927 '/COMMIT_MSG': [
2928 {
2929 'author': {'email': u'reviewer@example.com'},
2930 'updated': u'2017-03-17 05:19:37.500000000',
2931 'patch_set': 2,
2932 'side': 'REVISION',
2933 'message': 'Please include a bug link',
2934 },
2935 ],
2936 'codereview.settings': [
2937 {
2938 'author': {'email': u'owner@example.com'},
2939 'updated': u'2017-03-16 20:00:41.000000000',
2940 'patch_set': 2,
2941 'side': 'PARENT',
2942 'line': 42,
2943 'message': 'I removed this because it is bad',
2944 },
2945 ]
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002946 }),
2947 (('GetChangeRobotComments', 'chromium-review.googlesource.com',
2948 'infra%2Finfra~1'), {}),
2949 ((['git', 'config', 'branch.foo.gerritpatchset', '2'],), ''),
Leszek Swirski45b20c42018-09-17 17:05:26 +00002950 ] * 2 + [
2951 (('write_json', 'output.json', [
2952 {
2953 u'date': u'2017-03-16 20:00:41.000000',
2954 u'message': (
2955 u'PTAL\n' +
2956 u'\n' +
2957 u'codereview.settings\n' +
2958 u' Base, Line 42: https://chromium-review.googlesource.com/' +
2959 u'c/1/2/codereview.settings#b42\n' +
2960 u' I removed this because it is bad\n'),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002961 u'autogenerated': False,
Leszek Swirski45b20c42018-09-17 17:05:26 +00002962 u'approval': False,
2963 u'disapproval': False,
2964 u'sender': u'owner@example.com'
2965 }, {
2966 u'date': u'2017-03-17 05:19:37.500000',
2967 u'message': (
2968 u'Patch Set 2: Code-Review+1\n' +
2969 u'\n' +
2970 u'/COMMIT_MSG\n' +
2971 u' PS2, File comment: https://chromium-review.googlesource' +
2972 u'.com/c/1/2//COMMIT_MSG#\n' +
2973 u' Please include a bug link\n'),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002974 u'autogenerated': False,
Leszek Swirski45b20c42018-09-17 17:05:26 +00002975 u'approval': False,
2976 u'disapproval': False,
2977 u'sender': u'reviewer@example.com'
2978 }
2979 ]),'')
2980 ]
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002981 expected_comments_summary = [
2982 git_cl._CommentSummary(
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002983 message=(
2984 u'PTAL\n' +
2985 u'\n' +
2986 u'codereview.settings\n' +
2987 u' Base, Line 42: https://chromium-review.googlesource.com/' +
2988 u'c/1/2/codereview.settings#b42\n' +
2989 u' I removed this because it is bad\n'),
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002990 date=datetime.datetime(2017, 3, 16, 20, 0, 41, 0),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00002991 autogenerated=False,
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01002992 disapproval=False, approval=False, sender=u'owner@example.com'),
2993 git_cl._CommentSummary(
Aaron Gable0ffdf2d2017-06-05 13:01:17 -07002994 message=(
2995 u'Patch Set 2: Code-Review+1\n' +
2996 u'\n' +
2997 u'/COMMIT_MSG\n' +
2998 u' PS2, File comment: https://chromium-review.googlesource.com/' +
2999 u'c/1/2//COMMIT_MSG#\n' +
3000 u' Please include a bug link\n'),
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01003001 date=datetime.datetime(2017, 3, 17, 5, 19, 37, 500000),
Quinten Yearsley0e617c02019-02-20 00:37:03 +00003002 autogenerated=False,
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01003003 disapproval=False, approval=False, sender=u'reviewer@example.com'),
3004 ]
Quinten Yearsley0e617c02019-02-20 00:37:03 +00003005 cl = git_cl.Changelist(
3006 codereview='gerrit', issue=1, branchref='refs/heads/foo')
Andrii Shyshkalov5a0cf202017-03-17 16:14:59 +01003007 self.assertEqual(cl.GetCommentsSummary(), expected_comments_summary)
Quinten Yearsley0e617c02019-02-20 00:37:03 +00003008 self.mock(git_cl.Changelist, 'GetBranch', lambda _: 'foo')
3009 self.assertEqual(
3010 0, git_cl.main(['comments', '-i', '1', '-j', 'output.json']))
3011
3012 def test_git_cl_comments_robot_comments(self):
3013 # git cl comments also fetches robot comments (which are considered a type
3014 # of autogenerated comment), and unlike other types of comments, only robot
3015 # comments from the latest patchset are shown.
3016 self.mock(sys, 'stdout', StringIO.StringIO())
3017 self.calls = [
3018 ((['git', 'config', 'branch.foo.gerritserver'],), ''),
3019 ((['git', 'config', 'branch.foo.merge'],), ''),
3020 ((['git', 'config', 'rietveld.upstream-branch'],), CERR1),
3021 ((['git', 'branch', '-r'],), 'origin/HEAD -> origin/master\n'
3022 'origin/master'),
3023 ((['git', 'config', 'remote.origin.url'],),
3024 'https://chromium.googlesource.com/infra/infra'),
3025 (('GetChangeDetail', 'chromium-review.googlesource.com',
3026 'infra%2Finfra~1',
3027 ['MESSAGES', 'DETAILED_ACCOUNTS', 'CURRENT_REVISION',
3028 'CURRENT_COMMIT']), {
3029 'owner': {'email': 'owner@example.com'},
3030 'current_revision': 'ba5eba11',
3031 'revisions': {
3032 'deadbeaf': {
3033 '_number': 1,
3034 },
3035 'ba5eba11': {
3036 '_number': 2,
3037 },
3038 },
3039 'messages': [
3040 {
3041 u'_revision_number': 1,
3042 u'author': {
3043 u'_account_id': 1111084,
3044 u'email': u'commit-bot@chromium.org',
3045 u'name': u'Commit Bot'
3046 },
3047 u'date': u'2017-03-15 20:08:45.000000000',
3048 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046dc50b',
3049 u'message': u'Patch Set 1:\n\nDry run: CQ is trying the patch...',
3050 u'tag': u'autogenerated:cq:dry-run'
3051 },
3052 {
3053 u'_revision_number': 1,
3054 u'author': {
3055 u'_account_id': 123,
3056 u'email': u'tricium@serviceaccount.com',
3057 u'name': u'Tricium'
3058 },
3059 u'date': u'2017-03-16 20:00:41.000000000',
3060 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
3061 u'message': u'(1 comment)',
3062 u'tag': u'autogenerated:tricium',
3063 },
3064 {
3065 u'_revision_number': 1,
3066 u'author': {
3067 u'_account_id': 123,
3068 u'email': u'tricium@serviceaccount.com',
3069 u'name': u'Tricium'
3070 },
3071 u'date': u'2017-03-16 20:00:41.000000000',
3072 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
3073 u'message': u'(1 comment)',
3074 u'tag': u'autogenerated:tricium',
3075 },
3076 {
3077 u'_revision_number': 2,
3078 u'author': {
3079 u'_account_id': 123 ,
3080 u'email': u'tricium@serviceaccount.com',
3081 u'name': u'reviewer'
3082 },
3083 u'date': u'2017-03-17 05:30:37.000000000',
3084 u'tag': u'autogenerated:tricium',
3085 u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d4568',
3086 u'message': u'(1 comment)',
3087 },
3088 ]
3089 }),
3090 (('GetChangeComments', 'chromium-review.googlesource.com',
3091 'infra%2Finfra~1'), {}),
3092 (('GetChangeRobotComments', 'chromium-review.googlesource.com',
3093 'infra%2Finfra~1'), {
3094 'codereview.settings': [
3095 {
3096 u'author': {u'email': u'tricium@serviceaccount.com'},
3097 u'updated': u'2017-03-17 05:30:37.000000000',
3098 u'robot_run_id': u'5565031076855808',
3099 u'robot_id': u'Linter/Category',
3100 u'tag': u'autogenerated:tricium',
3101 u'patch_set': 2,
3102 u'side': u'REVISION',
3103 u'message': u'Linter warning message text',
3104 u'line': 32,
3105 },
3106 ],
3107 }),
3108 ((['git', 'config', 'branch.foo.gerritpatchset', '2'],), ''),
3109 ]
3110 expected_comments_summary = [
3111 git_cl._CommentSummary(date=datetime.datetime(2017, 3, 17, 5, 30, 37),
3112 message=(
3113 u'(1 comment)\n\ncodereview.settings\n'
3114 u' PS2, Line 32: https://chromium-review.googlesource.com/'
3115 u'c/1/2/codereview.settings#32\n'
3116 u' Linter warning message text\n'),
3117 sender=u'tricium@serviceaccount.com',
3118 autogenerated=True, approval=False, disapproval=False)
3119 ]
3120 cl = git_cl.Changelist(
3121 codereview='gerrit', issue=1, branchref='refs/heads/foo')
3122 self.assertEqual(cl.GetCommentsSummary(), expected_comments_summary)
Andrii Shyshkalov34924cd2017-03-15 17:08:32 +01003123
Andrii Shyshkalov81db1d52018-08-23 02:17:41 +00003124 def test_get_remote_url_with_mirror(self):
3125 original_os_path_isdir = os.path.isdir
3126 def selective_os_path_isdir_mock(path):
3127 if path == '/cache/this-dir-exists':
3128 return self._mocked_call('os.path.isdir', path)
3129 return original_os_path_isdir(path)
3130 self.mock(os.path, 'isdir', selective_os_path_isdir_mock)
3131
3132 url = 'https://chromium.googlesource.com/my/repo'
3133 self.calls = [
3134 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
3135 ((['git', 'config', 'branch.master.merge'],), 'master'),
3136 ((['git', 'config', 'branch.master.remote'],), 'origin'),
3137 ((['git', 'config', 'remote.origin.url'],),
3138 '/cache/this-dir-exists'),
3139 (('os.path.isdir', '/cache/this-dir-exists'),
3140 True),
3141 # Runs in /cache/this-dir-exists.
3142 ((['git', 'config', 'remote.origin.url'],),
3143 url),
3144 ]
3145 cl = git_cl.Changelist(codereview='gerrit', issue=1)
3146 self.assertEqual(cl.GetRemoteUrl(), url)
3147 self.assertEqual(cl.GetRemoteUrl(), url) # Must be cached.
3148
Edward Lemur298f2cf2019-02-22 21:40:39 +00003149 def test_get_remote_url_non_existing_mirror(self):
3150 original_os_path_isdir = os.path.isdir
3151 def selective_os_path_isdir_mock(path):
3152 if path == '/cache/this-dir-doesnt-exist':
3153 return self._mocked_call('os.path.isdir', path)
3154 return original_os_path_isdir(path)
3155 self.mock(os.path, 'isdir', selective_os_path_isdir_mock)
3156 self.mock(logging, 'error',
3157 lambda fmt, *a: self._mocked_call('logging.error', fmt % a))
3158
3159 self.calls = [
3160 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
3161 ((['git', 'config', 'branch.master.merge'],), 'master'),
3162 ((['git', 'config', 'branch.master.remote'],), 'origin'),
3163 ((['git', 'config', 'remote.origin.url'],),
3164 '/cache/this-dir-doesnt-exist'),
3165 (('os.path.isdir', '/cache/this-dir-doesnt-exist'),
3166 False),
3167 (('logging.error',
3168 'Remote "origin" for branch "/cache/this-dir-doesnt-exist" points to'
3169 ' "master", but it doesn\'t exist.'), None),
3170 ]
3171 cl = git_cl.Changelist(codereview='gerrit', issue=1)
3172 self.assertIsNone(cl.GetRemoteUrl())
3173
3174 def test_get_remote_url_misconfigured_mirror(self):
3175 original_os_path_isdir = os.path.isdir
3176 def selective_os_path_isdir_mock(path):
3177 if path == '/cache/this-dir-exists':
3178 return self._mocked_call('os.path.isdir', path)
3179 return original_os_path_isdir(path)
3180 self.mock(os.path, 'isdir', selective_os_path_isdir_mock)
3181 self.mock(logging, 'error',
3182 lambda *a: self._mocked_call('logging.error', *a))
3183
3184 self.calls = [
3185 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
3186 ((['git', 'config', 'branch.master.merge'],), 'master'),
3187 ((['git', 'config', 'branch.master.remote'],), 'origin'),
3188 ((['git', 'config', 'remote.origin.url'],),
3189 '/cache/this-dir-exists'),
3190 (('os.path.isdir', '/cache/this-dir-exists'), True),
3191 # Runs in /cache/this-dir-exists.
3192 ((['git', 'config', 'remote.origin.url'],), ''),
3193 (('logging.error',
3194 'Remote "%(remote)s" for branch "%(branch)s" points to '
3195 '"%(cache_path)s", but it is misconfigured.\n'
3196 '"%(cache_path)s" must be a git repo and must have a remote named '
3197 '"%(remote)s" pointing to the git host.', {
3198 'remote': 'origin',
3199 'cache_path': '/cache/this-dir-exists',
3200 'branch': 'master'}
3201 ), None),
3202 ]
3203 cl = git_cl.Changelist(codereview='gerrit', issue=1)
3204 self.assertIsNone(cl.GetRemoteUrl())
3205
3206
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00003207 def test_gerrit_change_identifier_with_project(self):
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00003208 self.calls = [
3209 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
3210 ((['git', 'config', 'branch.master.merge'],), 'master'),
3211 ((['git', 'config', 'branch.master.remote'],), 'origin'),
3212 ((['git', 'config', 'remote.origin.url'],),
3213 'https://chromium.googlesource.com/a/my/repo.git/'),
3214 ]
Andrii Shyshkalov2d0e03c2018-08-25 04:18:09 +00003215 cl = git_cl.Changelist(codereview='gerrit', issue=123456)
3216 self.assertEqual(cl._GerritChangeIdentifier(), 'my%2Frepo~123456')
3217
3218 def test_gerrit_change_identifier_without_project(self):
3219 self.calls = [
3220 ((['git', 'symbolic-ref', 'HEAD'],), 'master'),
3221 ((['git', 'config', 'branch.master.merge'],), 'master'),
3222 ((['git', 'config', 'branch.master.remote'],), 'origin'),
3223 ((['git', 'config', 'remote.origin.url'],), CERR1),
3224 ]
3225 cl = git_cl.Changelist(codereview='gerrit', issue=123456)
3226 self.assertEqual(cl._GerritChangeIdentifier(), '123456')
Andrii Shyshkalov1e828672018-08-23 22:34:37 +00003227
Quinten Yearsley0c62da92017-05-31 13:39:42 -07003228
maruel@chromium.orgddd59412011-11-30 14:20:38 +00003229if __name__ == '__main__':
Andrii Shyshkalov18df0cd2017-01-25 15:22:20 +01003230 logging.basicConfig(
3231 level=logging.DEBUG if '-v' in sys.argv else logging.ERROR)
maruel@chromium.orgddd59412011-11-30 14:20:38 +00003232 unittest.main()